jiebi/CodeConvo huggingface dataset:
Change:
(release.quality, release.commit.clone()) } <ins> fn normalize_base_path(p: &str) -> String { let p = p.trim_matches('/'); if p.is_empty() { return "/".to_string(); } format!("/{}/", p.trim_matches('/')) } </ins> impl ConnectionManager { pub fn new(ctx: &CommandContext, platform: Platform, args: ServeWebArgs) -> Arc<Self> { <ins> let base_path = normalize_base_path(args.server_base_path.as_deref().unwrap_or_default()); </ins> Arc::new(Self { platform, args, <ins> base_path, </ins> log: ctx.log.clone(), cache: DownloadCache::new(ctx.paths.web_server_storage()), update_service: UpdateService::new(

Discussion:
The command was augmented with the argument here in Because the does not include the , any attempts to mint a key will result in a 404 if the server-base-path is set. I think this is the reason why I am experiencing an issue that any sign-in attempt in the browser (e.g., Github Copilot, Settings Sync) do not persist between page refreshes. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.1 OS Version: x64 Steps to Reproduce: the browser, observe 404s to
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
assigned to you since you approved the original PR
Change:
this._tabButtons.dispose(); } const actions = this._getInitialTabActionBarArgs(); <del> this._tabButtons = new DropdownWithPrimaryActionViewItem(actions.primaryAction, actions.dropdownAction, actions.dropdownMenuActions, actions.className, this._contextMenuService, this._keybindingService, this._notificationService, actions.dropdownIcon || 'codicon-chevron-down'); </del> <ins> this._tabButtons = new DropdownWithPrimaryActionViewItem(actions.primaryAction, actions.dropdownAction, actions.dropdownMenuActions, actions.className, this._contextMenuService, actions.dropdownIcon || 'codicon-chevron-down'); </ins> return this._tabButtons; } return super.getActionViewItem(action);

Discussion:
For reuse by other code areas
Also polish styling including a hover over the joint buttons
Mockup: !
Fixed in
Change:
import { ITextModelContentProvider, ITextModelService } from 'vs/editor/common/services/resolverService'; import { Schemas } from 'vs/base/common/network'; import { ITextModel } from 'vs/editor/common/model'; <del> import { structuralEquals } from 'vs/base/common/equals'; </del> function getIconFromIconDto(iconDto?: UriComponents | { light: UriComponents; dark: UriComponents } | ThemeIcon): URI | { light: URI; dark: URI } | ThemeIcon | undefined { if (iconDto === undefined) {

Discussion:
Steps to Reproduce: a folder/workspace that contains a git repository some commits so that you have some outgoing changes in the history graph the output window, switch to the Git output channel, and clear the contents the "Refresh" action in the "Source Control" viewlet should see a entry int the output channel
Change:
return { data: FuzzyScore.Default, visibility: true }; } <del> const score = fuzzyScore(this._pattern, this._lowercasePattern, 0, labelStr, labelStr.toLowerCase(), 0); </del> <ins> const score = fuzzyScore(this._pattern, this._lowercasePattern, 0, labelStr, labelStr.toLowerCase(), 0, { firstMatchCanBeWeak: true, boostFullMatch: true }); </ins> if (score) { this._matchCount++; return labels.length === 1 ?

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 Stable OS Version: Windows 11 Steps to Reproduce: a .md file, add a header ⌘T, type 1.66.2: works fine ! 1.67.0: No matching workspaces symbols !
I confirmed that markdown returns the workspace symbols in this case. They then seem to be filtered out on the VS Code side
https://user-
Did the filtering for quick pick change?
This is a regression from I have changed how is configured and made the wrong adoption here...
Change:
} this.helpInformation = helpInformation; <ins> this._onDidChangeHelpInformation.fire(); </ins> const viewsRegistry = Registry.as<IViewsRegistry>(Extensions.ViewsRegistry); if (this.helpInformation.length) {

Discussion:
Steps to Reproduce: remote explorer and view help links ( etc) under the viewlet for existing remote extensions. additional remote extensions and view the help link options again. Expected: links for the newer extensions show up in the lists. Actual: does not change. and reopening updates the list.
Change:
} public select(range: IRange | null = null): void { <ins> this.input.select(); </ins> if (range) { this.input.setSelectionRange(range.start, range.end); if (range.end === this.input.value.length) { this.input.scrollLeft = this.input.scrollWidth; } <del> } else { this.input.select(); </del> } }

Discussion:
I think this started for me with the new insiders version today, when I press to open symbol, often focus remains in the editor and is not put into the input box. See video: ! Steps for me are to switch to another editor and then immediately try //cc for a related fix in this area
I can still reproduce in todays insider, but with command palette. !
This seems to happen when the input box is not shown so: ctrl+tab cmd+shift+p
points me to this
thanks a lot for bisecting this and the revert
Change:
return; } runAccessibilityHelpAction(accessor, codeEditor, 'inlineChat'); <del> }, CTX_INLINE_CHAT_FOCUSED)); </del> <ins> }, ContextKeyExpr.or(CTX_INLINE_CHAT_RESPONSE_FOCUSED, CTX_INLINE_CHAT_FOCUSED))); </ins> } }

Discussion:
Refs: chat view. Ask some things keyboard focus on the request item (what you typed) -nothing happens This is inconsistent with the behaviour when the focus is on the response. Megan informed me that this behaviour is by design, but I do not see understand what is the benefit of this behaviour. What are we getting with this inconsistency?
cc and for feedback. The thought here was a user has typed the request - thus knows what it says generally and doesn't need to carefully inspect it. Also, the request is typically concise. Open to adding support for this though - we'd have to consider if we want the and to cycle through each list item. IMO, it would be a bit annoying to have to go through one's requests like this.
I discussed this with JooYoung and he agreed we should not do this unless it's requested
Change:
remoteAuthority: this._environmentService.remoteAuthority }); let icon: URI | ThemeIcon | { light: URI; dark: URI } | undefined; <del> if (task.configurationProperties.icon) { </del> <ins> if (task.configurationProperties.icon?.id) { </ins> icon = ThemeIcon.fromId(task.configurationProperties.icon.id); } else { const taskGroupKind = task.configurationProperties.group ? GroupKind.to(task.configurationProperties.group) : undefined;

Discussion:
Testing I the following to the "Core - Build" task in this repo: The color shows in the "Run Task" quick pick, but not in the terminal tabs (I tried reloading, but still no color). !
the color will only take effect the next time you run the task - don't think it's worth listening to the config and updating. we don't do that for existing terminals either when an icon or color is set for their profile <img width="1291" alt="Screen Shot 2022-06-28 at 12 06 04 PM" src="https://user-"
Alex mentioned , I actually reproduced the icon and color not applying when testing also
I'm guessing it's just on tasks run via ? It works when running Core - Build explicitly but not ctrl+shift+b: !
should work for dependsOn tasks
works w ctrl+shift+b for other default build tasks () https://user-
works w ctrl+shift+b and the VS Code build task for me https://user-
can you pls send me the exact task config this isn't working for?
it's was just what was shown in the screenshot, the small change to . Might be related to Windows somehow then if you don't see it?
not sure why I can't reproduce it, but could be fixed by
I can still repro this in the latest insiders.
yes so can on Windows. we're going to debug
are there any task load messages in the output channel?
or any way the build task on windows is handled specially?
If there's an issue reading tasks from then an error should be logged to the tasks output channel, and I don't have any. The Run Build Task command shouldn't be handled any differently here, and I confirmed that this isn't build specific by making this keybinding:
to verify: set an icon for a dependency task
If I just set the icon color it now changes the icon away from the tools icon (its still the tools icon in the task quick pick): !
Change:
if (linesDecorationsClassName) { r[rLen++] = new DecorationToRender(d.range.startLineNumber, d.range.endLineNumber, linesDecorationsClassName); } <ins> const firstLineDecorationClassName = d.options.firstLineDecorationClassName; if (firstLineDecorationClassName) { r[rLen++] = new DecorationToRender(d.range.startLineNumber, d.range.startLineNumber, firstLineDecorationClassName); } </ins> } return r; }

Discussion:
When a section is wrapped after folding. Fold its parent with itself unfolded will display several wrong fold indicators.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.724 --- <!-- score: 0.616 --- <!-- score: 0.606 --- <!-- score: 0.575 --- <!-- score: 0.569 --<!-- potentialduplicatescomment --
!
Change:
getFindState(): FindReplaceState; findNext(): void; findPrevious(): void; <ins> focusTabsView(): void; </ins> registerProcessSupport(isSupported: boolean): void; /**

Discussion:
This would be useful since we can now navigate the tabs via the keyboard, so you could hit <keybinding, up n times, enter to focus that terminal.
Also it's a little tough to tell which split pane is actually focused right now, perhaps some extra visual hint?
Opening to double check what the ideal keybinding would be on each platform
Let's go with ctrl/cmd+shift+ for this, to align with 's navigate tabs keybinding.
Change:
public getWordDefinitions(): [LanguageId, RegExp][] { let result: [LanguageId, RegExp][] = []; <del> this._entries.forEach((value, language) => { </del> <ins> for (const [language, entries] of this._entries2) { const value = entries.getRichEditSupport(); </ins> if (value) { result.push([language, value.wordDefinition]); } <del> }); </del> <ins> } </ins> return result; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --We have started to get reports from users that Toggle Line Comments does the wrong thing: I think this stems from the default Clojure extension which sets to be a single . Calva changes this here: This has been working for years, and still does for many people, but some days ago it stopped working for some. I also notice that the default extension has moved to its own repository, where there is now a PR to fix the line comment configuration: However, I think it is wrong that the default extension sometimes overrides an installed extension here. Then that API can't be trusted at all. I worry about what more configuration is now sometimes being overridden. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.52.1 OS Version: N/A Steps to Reproduce: Calva a file the command Toggle Line Comment on an uncommented line Expected: It gets commented with Actual: It gets commented with Please let me know how I can assist in fixing this issue. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Not applicable
I am surprised that this ever worked reliably, it must have been some amazing timing luck. defines a language configuration at . Language configuration file handling is implemented by waiting for the language to be first used (like embedded in another language like a markdown fence or a file using the language is opened) and then reading async the language configuration file and applying it. This is done . Whenever the language configuration file finishes reading, it will go and configure the in pretty much the exact same way an extension calling configures it . So deep down there is no difference between those two calls and basically those two calls are racing themselves and it is lucky that until now the call reading the descriptive file was always faster than the imperative call from your extension. If you want to be sure to overwrite the builtin language configuration, you can define your own language configuration file using: But I also see how you would expect that the imperative call would "win" over the descriptive way, so maybe we can do something on our side to give a higher priority to the imperative call way of configuring languages.
Thanks !

This is great information. Calva has been relying on this luck for a very long time. And yes, I actually choose to do it the imperative way very consciously, assuming it was the way to be sure I could override the defaults.
Change:
this.notebookEditor.hideMarkupPreviews([this.viewCell]); <del> this.templateData.container.classList.toggle('collapsed', false); </del> this.templateData.container.classList.toggle('markdown-cell-edit-mode', true); if (this.editor && this.editor.hasModel()) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59-Insider OS Version: Windows 10 Steps to Reproduce: a notebook a cell cells are rotated 270 degrees. Seems to be because we use the 'collapsed' classname for cell collapse, and loads a stylesheet which applies to the classname. This stylesheet is not loaded in desktop VS Code so the problem seems to only impact Codespaces This is particularly unfortunate for the interactive window because all code cell inputs are collapsed by default, but it also impacts any collapsed cell in native notebooks all up. !
I filed this a long time ago, but this is pretty bad, I will just change the styles to work around it in the meantime
fix proposal from
Change:
return new ContextKeyNotEqualsExpr(key, value); } <ins> public static glob(key: string, value: string): ContextKeyExpr { return new ContextKeyGlobExpr(key, value); } </ins> public static not(key: string): ContextKeyExpr { return new ContextKeyNotExpr(key); }

Discussion:
VSCode Version: 1.12.0 OS Version: MacOS Sierra 10.12.4 In , we'd like to be able to provide context menus for all gradle files. The current clause is limited to language types () or a single file name (). It would be helpful if there was support for glob pattern matching, as mentioned in
Hi, Any update on this?
I will push an additional change that expands this to support normal regular expressions instead of just glob-patterns. We figured that's more powerful and closer to ST
Will this be usable in matching any when clause value? Can you give an example?
You write , so will execute this . A sample from my dummy extensions (matches filenames ending in )
This is AWESOME! Should reduce the number of duplicate menu items I need to define
Slight update on this: The value must be enclosed in slashes, so . I have updated above sample
FYI: I tried to apply this feature to the "loaded script view" by following the entry in the release notes: ! But without much success. After looking into the test item and the corresponding feature item, I noticed that the latest syntax uses regular regexp syntax. I've taken the liberty to change the release notes to this: ! I did not attempt to clarify why actually matches "Docker files".
Hmm, I am writing a simple extension, and would like to copy any resourceName. It works without any when clause, but the menu item also shows up, when r-clicking inside the empty space. I would like to prevent it. Is there something like this ?
Ok I found . And its actually what I was looking for. But I did not found it in the docs, but code base.
Change:
if (this._fileOperations === fileOperations && this._resources) { return this._resources; } <ins> const sortedFileOperations = fileOperations.sort(compareBulkFileOperations); </ins> const resources: IResourceDiffEditorInput[] = []; <del> for (const operation of fileOperations) { </del> <ins> for (const operation of sortedFileOperations) { </ins> const operationUri = operation.uri; const previewUri = this._currentProvider!.asPreviewUri(operationUri); // delete -> show single editor

Discussion:
Testing With all the files in the multi-diff editor collapsed to make it easy to see: ! To repro, try to rename this:
I see, that's a good point thanks!
To verify: Do a rename but do not accept rename Click on The refactor preview should open Open the multi diff editor from there by clicking on any change in the refactor preveiw Check that the order of the files in the refactor preview matches the order of the files in the multi diff editor
Change:
// Set numeric locale to ensure '.' is used as the decimal separator exec(`${ps} ${args}`, { maxBuffer: 1000 * 1024, env: { LC_NUMERIC: 'en_US.UTF-8' } }, (err, stdout, stderr) => { <del> if (err || stderr) { </del> <ins> // Silently ignoring the screen size is bogus error. See https://github.com/microsoft/vscode/issues/98590 if (err || (stderr && !stderr.includes('screen size is bogus'))) { </ins> reject(err || new Error(stderr.toString())); } else { parsePsOutput(stdout, addToTree);

Discussion:
Issue Type: <bBug</ba WSL window ! It looks similar to . A possible fix might be: cc: VS Code version: Code - Insiders 1.46.0-insider (, 2020-05-22T21:13:15.709Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ vscode-eslint2.1.5 gitlens10.2.1 EditorConfig0.15.1 graphql-for-vscode1.15.3 vscode-emacs-friendly0.9.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.2 powershell-preview2020.5.0 debugger-for-chrome4.12.8 material-theme3.7.1 </details<!-- generated by issue reporter --
Seeing this too, trying to attach to a dotnet process in WSL 2 in both insiders and stable: ! Version: 1.46.0-insider (user setup) Commit: Date: 2020-05-26T05:47:43.684Z (9 hrs ago) Electron: 8.3.0 Chrome: 80.0.3987.165 12.13.0 V8: 8.0.426.27-electron.0 OS: WindowsNT x64 10.0. Version: 1.45.1 (system setup) Commit: Date: 2020-05-14T08:27:35.169Z Electron: 7.2.4 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: WindowsNT x64 10.0.
Same problem here, right after upgrading from WSL 1 to WSL 2. Might be the same cause as and :
Also experiencing this with WSL 2 trying to debug using gdb (Attach)
I am reproducing this issue when trying to bring up the prompt textbox to select the process ID of the process to attach. Unfortunately, this PR did not fix the original reported issue My environment: WSL2 with Ubuntu 20.04.

Omnisharp v1.22.1 Visual Studio Code Insiders: ! Is there a workaround? This issue has been around since at least June 2019.
You had a proposed fix for this a while ago that looked good to me, do you want to go ahead and check that in?
Change:
this._openerService, this._keybindingService, this._hoverService, <ins> this._configurationService, </ins> context.onContentsChanged ); return this._renderedHoverParts;

Discussion:
Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers
Change:
string.appendVariable('BAR', b => { }); assert.equal(string.value, '${BAR}'); <ins> string = new types.SnippetString(); string.appendChoice(['b', 'a', 'r']); assert.equal(string.value, '${1|b,a,r|}'); string = new types.SnippetString(); string.appendChoice(['b', 'a', 'r'], 0); assert.equal(string.value, '${0|b,a,r|}'); string = new types.SnippetString(); string.appendText('foo').appendChoice(['far', 'boo']).appendText('bar'); assert.equal(string.value, 'foo${1|far,boo|}bar'); string = new types.SnippetString(); string.appendText('foo').appendChoice(['far', '$boo']).appendText('bar'); assert.equal(string.value, 'foo${1|far,$boo|}bar'); string = new types.SnippetString(); string.appendText('foo').appendPlaceholder('farboo').appendChoice(['far', 'boo']).appendText('bar'); assert.equal(string.value, 'foo${1:farboo}${2|far,boo|}bar'); </ins> }); test('instanceof doesn't work for FileSystemError #49386', function () {

Discussion:
In the snippet docs there's syntax for adding choices for placeholders: Currently the class has methods for , , etc. but there isn't an option for choices. We can build these manually, but it'd be better if we could stick to a nice API.
Also seems like the escape method is private, making it more difficult to do this manually without duplicating the implementation.
Actually, is escaped so it seems like we can't do this at all without building the whole string ourselves..
Well, you can do
That seems to have worked, thanks! I did have to copy your escape function and add to it though!
Hello,is this issue solved ? I am new on this repo and looking for good first issues to solve, this issue looks good for my purpose. Can anyone please guide me about solving this please?
This issue would be closed if it's solved. So, "yes" it up for a grab. This is the code pointer entry point: