jiebi/CodeConvo huggingface dataset:
Change:
}); reset(parent, this._grid.element); <ins> this._register(this._grid); </ins> this._ctxUsesColumnLayout.set(false); this.applyOptions(initialOptions);

Discussion:
While working on I noticed that some of the UI elements (and maybe other things?) are not registered as disposable, and thus may leak when the merge editor is freed from an editor group that closes. For example the and all input views seem to not dispose.
Hm, I think also the merge model, I suggest to do a pass and register as appropiate.
Change:
} } <del> const "_URI = URI.file(''); </del> function refreshIfSeparator(value: string, explorerService: IExplorerService): void { if (value && ((value.indexOf('/') >= 0) || (value.indexOf('') >= 0))) { // New input contains separator, multiple resources will get created workaround for #68204

Discussion:
Issue Type: <bBug</bExplorer asks to input file name for a new file on the wrong level after pressing <kbdEscape</kbdbutton. On the gif file below we have focus on directory, but input field created on the root level of the project. ! asks to create this issue. Related issue is Keyboard navigation: simple. Extension to switching keyboard context is installed. VS Code version: Code - Insiders 1.32.0-insider (, 2019-02-22T08:34:22.116Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ atom-keybindings3.0.6 </details<!-- generated by issue reporter --
My understanding is that this is because keyboard navigation still attempts to select the nearest file beginning with when you press , and that the “create file” action is only triggered secondary to that, so the focus has already shifted when the file is created. Super annoying.
Change:
continue; } <del> if (!attributes) { attributes = await this.remoteExplorerService.tunnelModel.getAttributes(this.remoteExplorerService.tunnelModel.candidates); } const portAttributes = attributes?.get(value.port); </del> if (portAttributes?.onAutoForward === OnPortForward.Ignore) { this.logService.trace(`ForwardedPorts: (ProcForwarding) Port ${value.port} is ignored`); continue;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Code space VS code OS Version: Codespaces Steps to Reproduce: is the file for initializing docker in codespace: space is not automatically port forwarding or I'm not able to manually add the port forwarding. 've tried with and without --host in
any help here? much appreciated!
since you have in your I would expect Codespaces to forward the port when you connect to the Codespace. For that, I would recommend you report an issue over in If you don't include the property then we should see that something is listening on 3000 and forward it. However, we don't forward ports that already have something listening on them at the time that VS Code connects to the Codespace. I think that your is happing a bit sooner than we expect and then we don't forward the port. Since you do have configured we should still forward the port. I'll make a fix for this. It should be in a VS Code insiders build by the end of the week.
Change:
import { IFileSystemProviderWithOpenReadWriteCloseCapability, FileReadStreamOptions, createFileSystemProviderError, FileSystemProviderErrorCode, ensureFileSystemProviderError } from 'vs/platform/files/common/files'; import { canceled } from 'vs/base/common/errors'; import { IErrorTransformer, IDataTransformer, WriteableStream } from 'vs/base/common/stream'; <ins> import product from 'vs/platform/product/common/product'; </ins> export interface ICreateReadStreamOptions extends FileReadStreamOptions {

Discussion:
Issue Type: <bBug</bWhat's "it" here? I assume it means VS Code. Should probably be explicit. VS Code version: Code 1.55.2 (, 2021-04-13T09:36:32.643Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ vscode-sqlite0.12.0 rainbow-csv1.8.1 dotenv1.0.1 vscode-js-profile-flame0.0.15 material-icon-theme4.6.0 rewrap1.14.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
return [terminalToReuse.terminal, commandExecutable, undefined]; } <del> await this.terminalCreationQueue; const createTerminalPromise = this.doCreateTerminal(group, launchConfigs); this.terminalCreationQueue = createTerminalPromise; const result: ITerminalInstance = await createTerminalPromise; </del> <ins> this.terminalCreationQueue = this.terminalCreationQueue.then(() => this.doCreateTerminal(group, launchConfigs!)); const result: ITerminalInstance = (await this.terminalCreationQueue)!; </ins> const terminalKey = result.instanceId.toString(); result.onDisposed((terminal) => {

Discussion:
our selfhost repo: microsoft/vscode <kbdCtrl Shift B</kbdto start the default build Sometimes you get 2 build tasks in separate terminals, not in split mode Sometimes <kbdCtrl C</kbdin one of them will close the panel, despite the fact that there is still a terminal open and the other task running. !
I haven't been able to reproduce this on windows or mac.
are you using linux? local or remote?
Yeah, this is remote: WSL
In WSL (cannot repro locally) when I run the build task via the command pallette -, I see that they're not split terminals. When I do ctrl + shift +b IE , they are in split terminals. thoughts?
could have to do with this?
To verify, add tasks that are similar to the following to your in an open folder: Then, run the task "Repos". Verify that you see two tasks in a split terminal. Run 2-3 more times to double check, as this was a race.
I still see this in selfhost. ! After killing one of them and running <kbdCtrl Shift B</kbdonce again: !
In fact I hit the bug more often than not.
have you seen this bug since?
Nope, good to close!
Change:
"priority": "builtin", "selector": [ { <del> "filenamePattern": "*.{mp3,wav,ogg}" </del> <ins> "filenamePattern": "*.{mp3,wav,ogg,oga}" </ins> } ] },

Discussion:
Type: <bBug</bOkay this is not actually an error but... I was working with a video file and it's name is ".ogg" is a video and audio file format/extension. In the explorer's tab the VS Code app says its an audio file, but it is not. The working of the file is proper in the browser but when you try to open it from VS Code itself it shows an error as "An error occurred while loading the audio file. Open file using VS Code standard text/binary editor?". According to me the app VS Code is not able to distinguish between if the file is an audio file of a video one. Lookng forward to this conversation, and hoping it gets fixed in the next VS Code update. Thank You in advance. Vishnu Soni VS Code version: Code 1.75.0 (, 2023-02-01T15:23:45.584Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ LiveServer5.7.9 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Although is a general container file format, I think is now recommended for audio content (or the more explicit ). If you want though, you can configure so that opens with the video preview instead of the audio one:
But what if want it to open both (audio and video) simultaneously
Reply
Change:
const SEARCH_CANCELLED_MESSAGE = nls.localize('searchCanceled', "Search was canceled before any results could be found - "); export class SearchView extends ViewPane { <del> private static readonly MAX_TEXT_RESULTS = 10000; </del> private static readonly ACTIONS_RIGHT_CLASS_NAME = 'actions-right'; private isDisposed = false;

Discussion:
Investigate removing Max results limitation for Search and replace results Currently we set max limit to . We need to investigate on lifting this.
Assigning this to you. I see that you are working on improving the performance for Search results. Currently we have an hard limitation of 2048. But we never measure what is the threshold. Since you are already exercising Search performance this would be a good one to look at. Thanks
I noticed . An improvement may be to not open all files in which terms were found and replaced. As a software engineer myself I sometimes have to make many changes (just today some 33k machine names in 280 XML files). Version 1.3.1 crashed on me, but even if it had worked, I would have stared at many open files. And there's no shortcut to "save all" and "close all" :( I had to revert to Notepad++, which simply makes the changes in-place on disk, without opening all files. Maybe doing something similar is an option?
This would be nice to fix/improve. I have to open Atom just to do find/replace.
There should at least be a warning telling the user that not all the occurrences have been replaced. It is very misleading when "Replace All" only replaces the first items.
Please increase this number or make it configurable
Same here. I'd like you to make the number configurable. I'd like to set this to "No Limit" also, hopefully.
The current upper bound for search in VSCode is occurrences. Is there a way to change it?
Please make this maximum / upper boundary configurable.
I wonder what is measuring? ! Also, when I set it to 2000, I see 4000 results show up when I search a single letter.
You will also get results in open files beyond the limit
This is a bit of a foot gun... Using some ridicules high value freeses VS Code eventually. Will create a separate issue for that
Change:
/** * Log the given trace message to the channel. * <del> * Messages are only printed when the user has enabled trace logging. </del> <ins> * Messages are only logged when the {@link LogOutputChannel.logLevel log level} is {@link LogLevel.Trace trace}. </ins> * * @param message trace message to log */

Discussion:
Testing the API lacks an explanation of the interaction between channel log levels and app log levels. the comments of the individual log methods all have the form "Messages are only printed when the user has enabled xxx logging" but nowhere is explained how "xxx logging enablement" is related to the log level. I would rather expect something like "xxx messages are only logged when the log level is xxx or lower."
Change:
private _profileLocation = this.options.profileLocation; get profileLocation() { return this._profileLocation; } <del> protected _verificationStatus = ExtensionVerificationStatus.Unverified; </del> <ins> protected _verificationStatus: ExtensionVerificationStatus = false; </ins> get verificationStatus() { return this._verificationStatus; } protected _operation = InstallOperation.Install;

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log
Change:
'disable-hardware-acceleration', // override for the color profile to use <del> 'force-color-profile', // override which password-store is used 'password-store' </del> <ins> 'force-color-profile' </ins> ]; if (process.platform === 'linux') { // Force enable screen readers on Linux via this flag SUPPORTED_ELECTRON_SWITCHES.push('force-renderer-accessibility'); <ins> // override which password-store is used on Linux SUPPORTED_ELECTRON_SWITCHES.push('password-store'); </ins> } const SUPPORTED_MAIN_PROCESS_SWITCHES = [

Discussion:
Originally posted by in This was mostly an oversight on my part.
Fixed in In the (Configure Runtime Arguments) we have two improvements: both and now show up in completions (they no longer say "not allowed") in is plumbed through properly
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
verification: run: make sure and show up in completions make sure you are currently logged in to any account and have an extension that asks for auth now set to restart VS Code you should be asked to log in because you are now using the inmemory store remote the setting from your now restart VS Code you should be logged in again because you are no longer using the inmemory store
Sorry the completion should only be seen on Linux
Change:
set dataProvider(dataProvider: ITreeViewDataProvider | undefined) { if (dataProvider) { <ins> if (this.visible) { this.activate(); } </ins> const self = this; this._dataProvider = new class implements ITreeViewDataProvider { private _isEmpty: boolean = true;

Discussion:
creates a tree view opens the tree view disposes the tree view while it's still open creates the tree view again The tree view will stay empty until it's is toggled Real world repo (also works as steps to verify): to a Codespace (to use a specific build of VS Code you can specify a commit in the URL with , ex ) the Remote Explorer the page. This will cause the Codespace to load with the remote explorer visible 'll see that the Codespace view in the remote explorer is empty
update
Change:
.vs-dark .monaco-workbench.mac .panel.integrated-terminal .xterm-rows, .hc-black .monaco-workbench.mac .panel.integrated-terminal .xterm-rows { cursor: -webkit-image-set(url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=') 1x, url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC') 2x) 5 8, text; <del> } </del>  No newline at end of file <ins> } .monaco-workbench .quick-open-terminal-configure { background-image: url('configure.svg'); } .vs-dark .monaco-workbench .quick-open-terminal-configure, .hc-black .monaco-workbench .quick-open-terminal-configure { background-image: url('configure-inverse.svg'); } </ins>

Discussion:
Needs one for some keybindings
Also should add a rename terminal button to each entry for easy discoverability
Change:
private accessibilitySupport: 'on' | 'off' | 'auto' | undefined; private workspaceTrustEnabled: boolean | undefined; private settingsProfilesEnabled: boolean | undefined; <ins> private experimentsEnabled: boolean | undefined; </ins> constructor( @IHostService private readonly hostService: IHostService,

Discussion:
a session which was opted into an experiment (eg Control Center) experiments Experiment is still running. (eg Control Center is still rendered) ! !
I think reload is required for the experiment to be disabled. Have you?
If reload is required, we should leverage the mechanism that prompts the user to reload, whenever the setting changes.
Change:
this.updatedAllowedExtension(providerId, session.account.label, extensionId, extensionName, true); // And also set it as the preferred account for the extension <del> storageService.store(`${extensionName}-${providerId}`, session.id, StorageScope.GLOBAL, StorageTarget.MACHINE); </del> <ins> storageService.store(`${extensionName}-${providerId}-${scopes.join('-')}`, session.id, StorageScope.GLOBAL, StorageTarget.MACHINE); </ins> } });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: an extension that does this: 'll notice that is though it should exist because we created it on line 1. This is because we cache the session id based on the provider id & extension name but really we should be caching them based on provider id, extension name, AND SCOPES. This will allow the 3rd time to find the session created in the first line.
Verification steps: The code session3 should not be undefined.
is your solution to this issue the reason that the Insiders builds have started bugging me at least once a day to sign into GitHub? With four windows open, each with two extensions that want a GitHub token (GitLens and GitHub Issues and Pull Requests), I have to generate 8 tokens to make VS Code stop bugging me... at which point it almost always discovers a VS Code update, and often we do the dance again after it restarts.
(And never mind, I see it was, and I see you fixed it!)
Reopening this because I reverted the change that fixed it.
just checking to see if there were any updates on this issue?
haven't had a chance to revisit this. You can take a look at my commit if you'd like. The problem I needed to address is migrating from the old storage keys to the new storage keys and my commit didn't handle that. Unfortunately, I have some other work I'm working on at the moment so I won't be able to look at this this month.
This appears to be fixed. Closing now
verification: original steps to repro. Instead, session3 should be defined.
Change:
}, onHide: () => { this.validationHasFocus = false; <ins> this.editorContainer.style.borderBottomLeftRadius = '2px'; this.editorContainer.style.borderBottomRightRadius = '2px'; </ins> disposables.dispose(); }, anchorAlignment: AnchorAlignment.LEFT

Discussion:
Source control warning not aligned on the right hand side with the input field: <img width="473" alt="image" src="https://user-"
Draft PR here but I feel that there is a better way. For whatever reason the editor within SCM input is not as wide as the input it is rendered in—or something like that. Open to ideas!
Here is the updated layout: <img width="567" alt="image" src="https://user-"
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { ConfigurationChangedEvent, EditorAutoClosingEditStrategy, EditorAutoClosingStrategy, EditorAutoIndentStrategy, EditorAutoSurroundStrategy, EditorOption, TextEditorCursorStyle } from 'vs/editor/common/config/editorOptions'; </del> <ins> import { ConfigurationChangedEvent, EditorAutoClosingEditStrategy, EditorAutoClosingStrategy, EditorAutoIndentStrategy, EditorAutoSurroundStrategy, EditorOption } from 'vs/editor/common/config/editorOptions'; </ins> import { LineTokens } from 'vs/editor/common/tokens/lineTokens'; import { Position } from 'vs/editor/common/core/position'; import { Range } from 'vs/editor/common/core/range';

Discussion:
Using copilot completions in the latest VS Code insiders, I see the cursor being pushed to after the suggested text. This makes it very difficult to work with the text while passive completions are suggested. <img width="1126" alt="image" src=""
FYI I didn't think of this.
is it possible to differentiate between an inline completion and inlay hint in the editor? maybe we could have different behavior in different cases?
Change:
nativeLabel = ` "${nativeLabelText}"`; } } <del> const hoverMessage = new MarkdownString('', true).appendMarkdown(`[${label}](${link.url.toString()}${nativeLabel}) (${kb})`); </del> <ins> const hoverMessage = new MarkdownString('', true).appendMarkdown(`[${label}](${link.url.toString(true)}${nativeLabel}) (${kb})`); </ins> return hoverMessage; } else { return new MarkdownString().appendText(`${label} (${kb})`);

Discussion:
Issue Type: <bBug</b- Open a new file (!important) Set file type to Markdown Create a markdown link with a query string name-value pair containing an equals sign ("=") like Hover over the url (i.e. "") to engage the Follow Link tooltip Click "Follow link" link Observe that the browser address bar shows an encoded equals sign ("=") in the url (i.e. "") I cannot reproduce this issue with online monarch-editor () if that helps. VS Code version: Code 1.50.0 (, 2020-10-07T06:10:52.432Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ gitlens10.2.2 prettier-vscode5.7.1 vscode-docker1.6.0 remote-containers0.145.0 vscode-typescript-tslint-plugin1.2.3 debugger-for-chrome4.12.11 debugger-for-edge1.0.15 </details<!-- generated by issue reporter --
Hello, I would like to work on this bug. I have done a small amount of investigating so far, I am concluded that this only happens with the prompt and not when the command/control click shortcut is used. I also concluded that this only happens with markdown and not other extensions. This leaves me to believe that the issue lies within the "markdown-language-features" extension. I was hoping I might be able to get some guidance on how to find the code responsible for executing after the prompt is clicked on. I am thinking that I need to work on or but from the debugging I have conducted so far I cant get any breakpoints to break. Thank you!
I think this is a duplicate of
YouTube links in Markdown don't longer work because of this bug. YouTube will redirect you to their homepage because it can't find the video.
The reason for this problem is that if you pass in a URI link, it'll call the toString function to display it .And the toString function of the URI will by default encode. ! ! So is there a need for encode? If not, we can solve this problem by toString(true). !
Change:
if (editor) { this._bindToEditor(editor); this._disposables.add(_outlineService.onDidChange(() => this._bindToEditor(editor))); <ins> this._disposables.add(editor.onDidChangeControl(() => this._bindToEditor(editor))); </ins> } this._onDidUpdate.fire(this); }

Discussion:
Testing In a non-split editor: ! In a split editor: ! As you can see, the breadcrumbs only show up to the file and no further.
Change:
}); }, 'update alignment view zones')); <ins> // word wrap special case - sync transient state from result model to input[1|2] models const mirrorWordWrapTransientState = () => { const state = readTransientState(model.resultTextModel, this._codeEditorService); writeTransientState(model.input2.textModel, state, this._codeEditorService); writeTransientState(model.input1.textModel, state, this._codeEditorService); }; this._sessionDisposables.add(this._codeEditorService.onDidChangeTransientModelProperty(candidate => { if (candidate === this.inputResultView.editor.getModel()) { mirrorWordWrapTransientState(); } })); mirrorWordWrapTransientState(); </ins> // detect when base, input1, and input2 become empty and replace THIS editor with its result editor // TODO@jrieken@hediet this needs a better/cleaner solution

Discussion:
It was weird when I toggled word wrap in the merge editor yet only the editor I was focused on had it toggled. I kind of expected all editors to have it toggled. My rationale is that toggling word wrap is usually a symptom of having long lines and the chances that all three editors have long lines is high if a single editor has long lines.
I agree. Until recently word wrap only toggled one side of the diff editor. See