jiebi/CodeConvo huggingface dataset:
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-web-links/-/xterm-addon-web-links-0.2.1.tgz#6d1f2ce613e09870badf17615e7a1170a31542b2" integrity sha512-2KnHtiq0IG7hfwv3jw2/jQeH1RBk2d5CH4zvgwQe00rLofSJqSfgnJ7gwowxxpGHrpbPr6Lv4AmH/joaNw2+HQ== <del> xterm@4.2.0: version "4.2.0" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.2.0.tgz#b9980b2ae18c64ed31bcc95eace3bcecffebbbd9" integrity sha512-oNfLqt+LmghLPOt5UcskP5Km1fXpTBHsTZ99nxJKY2N0MNFXBKIVXUcNNhHCa74JGZFMGhLT58A/UN3HcPXSfg== </del> <ins> xterm@4.2.0-vscode1: version "4.2.0-vscode1" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.2.0-vscode1.tgz#dbd67e52536578ea6b772d69a97da1487acf29e3" integrity sha512-frw5Kprzkko8+G0vp4jOcwTeOpYFbSb2+QShpeQGJ7l3Hg3MTM7kt1G+nLxBPKnkFAmei/JcJTUGJdp/lldAfA== </ins>

Discussion:
This increases the amount of work done when typing commands to be significantly more. Upstream:
Can't really verify this issue without debugging into the code, inside (formatted) you will see an function, the args are start/end. Add a breakpoint to that function and verify the args are a range for a single like (eg. 15, 15) after typing a single character into the terminal. Here is the failing case where the terminal is re-rendering lines 0-15: ! Use the canvas renderer to verify.
A better way to verify: to DOM renderer paint flashing: ! you type into the prompt only a single line will flash
Verified in latest (). Can this issue be closed?
Change:
test('Opening a notebook should fire activeNotebook event changed only once', async function () { const openedEditor = onDidOpenNotebookEditor(); const resource = await utils.createRandomFile(undefined, undefined, '.nbdtest'); <del> const editor = await vscode.window.showNotebookDocument(resource); </del> <ins> const document = await vscode.workspace.openNotebookDocument(resource); const editor = await vscode.window.showNotebookDocument(document); </ins> assert.ok(await openedEditor); assert.strictEqual(editor.notebook.uri.toString(), resource.toString()); });

Discussion:
The has been finalized with VS Code 1.68 (). If your extension was using the proposal, you should now switch to the finalized version of this API. In the majority of cases, this switch is as simple as: your extension to target VS Code in the new from your list of enabled API proposal. However there are few small bumps to be aware of: has been renamed . Please make sure to switch over to the new property name as part of this migrationWe did not finalize the version of that takes a uri. Instead you can use Here's a list of all current consumers of the old API proposal: [x] ms-vsliveshare.vsliveshare — [X] ms- — [x] Dot net interactive — [x] GitHub.codespaces — [x] ms- — If you own one of these extensions, please migrate to the finalized notebook editor API. Let me know once the new version of your extension is published and I will remove your extension from the list of api consumers
I am actually fine in ESLint. The dependency was because of notebook support in LSP and LSP already converted to the final version for the 8.x release of the LSP libs.
Thank you everyone who's checked off their extension so far! If you have, I plan to remove your extension from the list of API consumers in July. This will only start effecting the insiders builds of VS Code at first, but please let me know if you notice any issues
I'm working on the change for Codespaces and expect it to be in our next extension release (1.10.0) in a few days. I'll reply back once it's on the marketplace.
We just published GitHub Codespaces 1.10.0 with this change, so you should be able to remove our extension from the list of proposed API consumers.
Change:
<del> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><path fill="#646465" d="M6 4v8l4-4-4-4zm1 2.414L8.586 8 7 9.586V6.414z"/></svg> </del>  No newline at end of file

Discussion:
Noticed how the process explorer is bundling and still. Can we not use Codicons for this? //cc
Oh this seems to be used in the issue reporter, not process explorer. But not sure how to actually see it...
are we actually using these icons? I'm not seeing it: !
it looks like these are only used when VSCode is connected to a remote to show the remote processes as well. I didn't even know we had that, pretty cool: ! Anyhow, my request still seems valid.
PR up at !
Change:
Editor = 4, } <del> export class ChatRequestEditorData { </del> <ins> export class ChatRequestEditorData implements vscode.ChatRequestEditorData { </ins> constructor( readonly document: vscode.TextDocument, readonly selection: vscode.Selection,

Discussion:
Today inline chat for editors and notebooks rely on implicit variables, e.g . This isn't proper and we should have real API, e.g some extra property on that encapsulates data about the chat location.
Done, no more implicit variables
Change:
"dependencies": { "jsonc-parser": "^3.0.0", "request-light": "^0.5.4", <del> "vscode-json-languageservice": "^4.1.9", </del> <ins> "vscode-json-languageservice": "^4.1.10", </ins> "vscode-languageserver": "^7.0.0", "vscode-uri": "^3.0.2" },

Discussion:
Version: 1.62.2 (user setup) Commit: Date: 2021-11-11T20:56:38.428Z Electron: 13.5.2 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0. Have the settings file add a syntax error (e.g. at the endno errors reported JSON language server log says
Fails on a regular expression which is part of the validation schema for the setting does not need to be escaped With the changes for we now create regular expression with flag which is more restrictive regarding unnecessary escapes.
The fix is to a.) handle malformed regular expression b.) if creating a regular expression with fails, try a second time without
Closing for verification since it looks like this is in the release branch.
Change:
import { TestLifecycleService } from 'vs/workbench/test/browser/workbenchTestServices'; import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; <del> class TestWebglAddon { </del> <ins> class TestWebglAddon implements WebglAddon { </ins> static shouldThrow = false; static isEnabled = false; readonly onChangeTextureAtlas = new Emitter().event as IEvent<HTMLCanvasElement>; <ins> readonly onAddTextureAtlasCanvas = new Emitter().event as IEvent<HTMLCanvasElement>; </ins> readonly onContextLoss = new Emitter().event as IEvent<void>; activate() { TestWebglAddon.isEnabled = !TestWebglAddon.shouldThrow;

Discussion:
Issue Type: <bPerformance Issue</bEver since I got this M1 mac with apple silicon, any scrolling I do in VSCode is super choppy and laggy. To reproduce it on my machine I just need to open an editor with a scrollbar or a terminal with some history and scroll quickly up and down. VS Code version: Code 1.69.2 (, 2022-07-18T16:32:39.000Z) OS version: Darwin arm64 21.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryProcess Info</summary</details<details<summaryWorkspace Info</summary</details<details<summaryExtensions (11)</summaryExtensionVersion ------ prettier-vscode9.5.0 go0.35.1 githd2.3.3 vscode-docker1.22.1 python2022.10.1 vscode-pylance2022.8.10 jupyter2022.6. jupyter-keymap1.0.0 jupyter-renderers1.0.9 vsliveshare1.0.5669 vscode-yaml1.9.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you do a performance profile in devtools (Help Toggle Developer Tools) and upload it here? !
Sure, attached.
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
There's an abnormal about of garbage collection in that profile which I've never seen before: !
what sort of monitor are you connected to? Could you also open devtools via the Help menu and run in the console? My guess is your font size is so large that the terminal's texture atlas is thrashing and redrawing all glyphs almost every frame.
Upstream issue tracking the texture cap problem:
This one can only be verified by the
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

I'll mark this issue as verified as part of . Please file a new issue if the bug continues to occur on the latest Stable and/or Insiders versions of VS Code.
Change:
import { IExtensionsProfileScannerService, IScannedProfileExtension } from 'vs/platform/extensionManagement/common/extensionsProfileScannerService'; import { IUserDataProfilesService } from 'vs/platform/userDataProfile/common/userDataProfile'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; <ins> import { ILocalizedString } from 'vs/platform/action/common/action'; </ins> export type IScannedExtensionManifest = IRelaxedExtensionManifest & { __metadata?: Metadata };

Discussion:
Issue Type: <bBug</bChinesenotebookrestart Extension version: 2022.6. VS Code version: Code 1.69.0 (, 2022-07-07T05:28:36.503Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Are these ok ! ! !
thanks for filling this issue please could you upload a screenshot of the issue.
I have a same issue with him. I guess it relates to CJK language pack since restart and interrupt buttons also disappear in Korean. ! !
I also have the same issue. Since updating vscode and jupyter extension to the latest version, when I use the Chinese language pack, the restart and interrupt buttons on the global toolbar will disappear. When I uninstall the Chinese language pack, or downgrade vscode and jupyter extension, these problems will go away. Please check this problem, thanks! <img width="831" alt="image" src="https://user-"
I met this problem since last auto update of vscode. Suffering for days, haven't realized that its a bug for language package.
I'm sorry you are running into this, we'll try to get this resolve asap.
Hello ! We just released a hotfix that re-enables those buttons that you reported missing. Please install and let us know how it goes! Thank you for using our extension. Your time and feedback are appreciated.
It is worked. Thanks:smile: !
It works in Korean, too. Thanks! !
This is actually an issue in vscode core. It looks like an issue with this code: The messages is of type: string: string | { message: string; comment: string[] } when it should really only be string: string. I’ll fix this
calm down bot
Change:
Object.keys(this._sessionRestoredRecommendations).forEach(x => output[x.toLowerCase()] = { reasonId: this._sessionRestoredRecommendations[x].reasonId, <del> reasonText: localize('restoredRecommendation', "You will receive recommendations for this extension in your next VS Code session.") </del> <ins> reasonText: localize('restoredRecommendation', "You will receive recommendations for this extension in your future VS Code sessions.") </ins> }); return output;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --In most recent insiders. <!-- Use Help Report Issue to prefill these. --Steps to Reproduce: " a few times, sometimes extensions will show up, but not have their badge. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
This may only be an issue in multi-root workspaces
Change:
icon: nextChangeIcon }, TextCompareEditorActiveContext, <del> 11 </del> <ins> 11, undefined, EditorContextKeys.hasChanges, </ins> ); MenuRegistry.appendMenuItem(MenuId.EditorTitle, {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Please disable the "Previous Change," "Next Change," and similar buttons in the diff view when there are no differences (both files are equal). This would be a swift way to ensure that no differences exist, especially when cheking between local and remote files. Such clarity can be crucial in certain situations. On the right side, it's also possible to observe the differences on the "file map." However, at times, this map might be cluttered with additional markings, such as code warnings, which can lead to confusion. Typically, I find myself clicking the "Next Change" button when I need to verify the presence of differences. If the file doesn't scroll, I can be confident that none exist. Yet, this workaround is unnecessary. Furthermore, adhering to good UX practices involves displaying buttons as disabled when they lack any action. !
When you are scrolled away from the single diff in a file, you can use these buttons to scroll back again to the diff. If there buttons would be disabled, this does not work anymore. Maybe the feature "Toggle Collapse Unchanged Lines" might help you.
If there are no differences (both files are equal) the buttons are useless (there is no diff to scroll to) and should be disabled to follow good UI practices. Edit: I improved the issue description.
!
Change:
easy = 42; ||| <del> >**Tip:** You can also enable the checks workspace or application wide by adding |"javascript.implicitProjectConfig.checkJs": true| to your workspace or user settings and explicitly ignoring files or lines using |// @ts-nocheck| and |// @ts-ignore|. Check out the docs on [JavaScript in VS Code](https://code.visualstudio.com/docs/languages/javascript) to learn more. </del> <ins> >**Tip:** You can also enable the checks workspace or application wide by adding |"javascript.implicitProjectConfig.checkJs": true| to your workspace or user settings and explicitly ignoring files or lines using |// @ts-nocheck| and |// @ts-expect-error|. Check out the docs on [JavaScript in VS Code](https://code.visualstudio.com/docs/languages/javascript) to learn more. </ins> ## Thanks!

Discussion:
Following up on microsoft/TypeScript, is now a valid completion directive. It should be recommended over in the editor walkthrough that mentions comment directives.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.668 --<!-- potentialduplicatescomment --
Change:
*--------------------------------------------------------------------------------------------*/ import { retry } from './retry'; <del> const { installBrowsersWithProgressBar } = require('playwright/lib/install/installer'); </del> <ins> const { installDefaultBrowsersForNpmInstall } = require('playwright/lib/utils/registry'); </ins> async function install() { <del> await retry(() => installBrowsersWithProgressBar()); </del> <ins> await retry(() => installDefaultBrowsersForNpmInstall()); </ins> } install();

Discussion:
This code seems to reach into the module: When trying to update to the file is no longer found and seems gone.
Change:
} private async _createOriginalWebview(id: string, resource: URI): Promise<void> { <ins> if (this._originalWebview) { this._originalWebview.dispose(); } </ins> this._originalWebview = this.instantiationService.createInstance(BackLayerWebView, this, id, resource, this.webviewOptions) as BackLayerWebView<IDiffCellInfo>; // attach the webview container to the DOM tree first this._list.rowsContainer.insertAdjacentElement('afterbegin', this._originalWebview.element);

Discussion:
Issue Type: <bBug</bRepro a notebook in the diff view (tested with the github issues notebook) down to another file bug In dev tools, see: VS Code version: Code - OSS Dev 1.55.0 (Commit unknown, Date unknown) OS version: Darwin x64 20.3.0 <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ docs-view0.0.9 vscode-eslint2.1.14 EditorConfig0.16.4 vscode-pull-request-github0.23.1 svg1.4.5 template-string-converter0.4.7 git-graph1.29.0 vscode-language-pack-de1.54.1 vscode-dotnet-runtime1.0.0 vscode-edge-devtools1.1.3 python2021.2. jupyter2021.3. remote-containers0.163.0 remote-ssh0.64.0 remote-ssh-edit0.64.0 azure-account0.9.6 cpptools1.2.2 hexeditor1.4.0 vscode-github-issue-notebooks0.0.68 vscode-markdown-notebook0.0.14 debugger-for-chrome4.12.12 debugger-for-edge1.0.15 shader-toy0.10.15 </details<!-- generated by issue reporter --
I believe that webviews in diff editors are being leaked at the moment. For normal notebooks, I see the webview disposed of in the method: However I don't see the same in notebookTextDiffEditor
Hm, now I'm just more confused. It seems the webviews are not disposed of when the diff editor is closed (and is not fired on the either). However they are disposed of when another notebook diff editor is opened The root cause of this issue is that the webview is no longer in the dom but it also isn't disposed. We then try posting a message to it which causes an exception. Here's the call stack that triggers this error: !
I started to see leaks of recently, which is likely a regression, and probably in the logic.
Change:
import { IKeyMods } from 'vs/base/parts/quickinput/common/quickInput'; import * as nls from 'vs/nls'; import { ICommandService } from 'vs/platform/commands/common/commands'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';

Discussion:
I noticed terminals can accept : Note that this does not map 1 to 1 to , you have to: offset properly: convert properly: //cc
Steps: open 2 empty editor groups, focus the first group execute a command that triggers below code [1] terminal opens in first group not second
Moving to September. //cc
Change:
const majorNodeVersion = parseInt(/^(d+)./.exec(process.versions.node)[1]); if (majorNodeVersion < 14 || majorNodeVersion >= 17) { <del> console.error('033[1;31m*** Please use node.js versions >=14 and <=17.033[0;0m'); </del> <ins> console.error('033[1;31m*** Please use node.js versions >=14 and <17.033[0;0m'); </ins> err = true; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: n/a <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: latest OS Version: macOS 11.2.3 Steps to Reproduce: repo npm version < 14 or ≥ 17 to see this message message or just read the commit diff to see the problem
from check is for ≥ 17 but error message says to use ≤ 17, thus exactly v17 is both valid and invalid
Change:
import { Button, IButtonStyles } from 'vs/base/browser/ui/button/button'; import { MarkdownString } from 'vs/base/common/htmlContent'; import { Disposable } from 'vs/base/common/lifecycle'; <ins> import { localize } from 'vs/nls'; </ins> import { ContextKeyExpr, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IChatFollowup } from 'vs/workbench/contrib/chat/common/chatService';

Discussion:
Users in the fable study weren't sure if the question was asking them something (given it's a chat experience) or if it was actionable. Could we use a better icon to indicate this? Should we add static text: ? We should also add to the aria label.
Is this just something where you might not be sure what it is, then you click it, and you instantly find out, and then it's no longer a question? That's how UX has to work sometimes. Not opposed to an aria label. Sounds like it's about screenreader and also sighted users though (since you mentioned an icon) If we changed the icon, something with the "submit" button might help? Or putting the question in quotes?
The copilot sparkle icon is redundant IMO, since this question exists within the copilot chat panel. Yes, a submit / run icon would be better I think to indicate what will happen. The current styling makes it look like a link, so a user might think clicking on that could do any number of things.
!
I don't really like that one, sorry, I don't think "run" is the right meaning
I don't love it either. Other ideas?
Maybe submit? But otherwise I think "sparkle" makes sense for "send this to the magic AI"
We're within the copilot chat panel already - so not sure the sparkle is necessary.
It's just blue text that does something very different than all the other blue text, so I think it needs something to differentiate it, and I think the sparkle works as well as anything
It differentiates it but doesn't give any indication of what will happen. That's what users have reported.
Well I don't have any other ideas
any ideas for a better icon here?
I think we can mention follow ups in the accessibility help dialog.
To verify: in the chat input box, and make sure you it contains "In the input box, navigate to the suggested follow up question (Shift+Tab) and press Enter to run it." with a screen reader on, focus the input box. to the suggested question and verify that the aria label indicates it's a suggested question.
Change:
import { NullLogService } from 'vs/platform/log/common/log'; import { isLinux, isWindows } from 'vs/base/common/platform'; import { DisposableStore } from 'vs/base/common/lifecycle'; <del> import { isEqual } from 'vs/base/common/resources'; </del> <ins> import { isEqual, joinPath } from 'vs/base/common/resources'; </ins> import { VSBuffer, VSBufferReadable, streamToBufferReadableStream, VSBufferReadableStream, bufferToReadable, bufferToStream, streamToBuffer } from 'vs/base/common/buffer'; import { find } from 'vs/base/common/arrays';

Discussion:
Could be related to the Untitled file title changes. The tests hang here: ! /cc
The same on macOS.

This was nicely uncovered by our internally implements a logic that throws an error in case multiple calls are made in parallel and a folder was created in the meantime. This is due to the fact that throws when a directory already exists. However, node's own implementation does not throw with the recurse option set to . We should align our implementation and not throw when a folder already exists.
Verification: run our smoke test and see how the hot-exit tests succeed.