jiebi/CodeConvo huggingface dataset:
Change:
const gridDescriptor = createSerializedGrid({ orientation: this.toGridViewOrientation( layout.orientation, <del> (this.gridWidget.orientation === Orientation.VERTICAL) ? Orientation.HORIZONTAL : Orientation.VERTICAL // fix https://github.com/Microsoft/vscode/issues/52975 </del> <ins> this.isTwoDimensionalGrid() ? this.gridWidget.orientation :			// preserve original orientation for 2-dimensional grids orthogonal(this.gridWidget.orientation) // otherwise flip (fix https://github.com/Microsoft/vscode/issues/52975) </ins> ), groups: layout.groups });

Discussion:
Steps to Reproduce: 2x2 grid it again =the layout flips (top right editor ends up bottom left)
Change:
import { NotebookCellsChangeType } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { INotebookKernel, INotebookKernelService } from 'vs/workbench/contrib/notebook/common/notebookKernelService'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; <del> import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; </del> import { IStatusbarEntry, IStatusbarEntryAccessor, IStatusbarService, StatusbarAlignment } from 'vs/workbench/services/statusbar/browser/statusbar'; <ins> import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; </ins> class ImplictKernelSelector implements IDisposable {

Discussion:
This is a missing adoption when notebooks became floating window capable. Notice how the status bar entry appears in the main window and not the floating window: ! We have had a similar issue with the text editor status bar and solved it by instantiating it per-window: I think a similar approach would work for notebooks too. The key for this to work is that you get a scoped in the that allows you to listen only to editor change events in the respective window. Consequently, you use a main-window scoped editor service for the main-window status bar: Let me know if you have questions, but I think its easy to copy what we do for editor status here.
When I reload the window with a floating notebook, the status bar does not appear (macOS): !
This is my attempt to fix this issue The problem here is if we register the contrib , we won't get the event. The event is the only place where we get the window's unique instantiationService (which gives us the right statusbarservice). Without the right statusbarservice, we can't register notebook status bar items to the right place.
Not very happy about that, filed
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
label.setFile(joinPath(parent, value || ' '), labelOptions); // update label icon while typing! }), DOM.addStandardDisposableListener(inputBox.inputElement, DOM.EventType.KEY_DOWN, (e: IKeyboardEvent) => { <del> if (e.equals(KeyCode.Enter)) { </del> <ins> if (e.equals(KeyCode.F2)) { const dotIndex = inputBox.value.lastIndexOf('.'); if (stat.isDirectory || dotIndex === -1) { return; } if (currentSelectionState === 'prefix') { currentSelectionState = 'all'; inputBox.select({ start: 0, end: inputBox.value.length }); } else if (currentSelectionState === 'all') { currentSelectionState = 'suffix'; inputBox.select({ start: dotIndex + 1, end: inputBox.value.length }); } else { currentSelectionState = 'prefix'; inputBox.select({ start: 0, end: dotIndex }); } } else if (e.equals(KeyCode.Enter)) { </ins> if (!inputBox.validate()) { done(true, true); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When I select a file in the left side bar and hit the file prefix is selected. ! I would like to hit a second time to select the whole file name. ! When I press a third time the prefix should be selected again. So pressing should just toggle between "prefix" and "whole name". This is a feature I use very often in Total Commander. It is usefull if you want to copy the complete file name.
Interesting idea. Maybe the second press could select just the suffix, and the third press cycle around to just the prefix.
I like Personally I would think cycling from left to right would be best 1st press =prefix 2nd press =all 3rd press =suffix 4th press =cycles back around to prefix when highlighting the suffix, should it also include the seperating dot?
I think the dot should only be selected, wenn all is selected.
that's actually what I meant. I forgot to count the initial F2 that begins the rename operation.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
! Coming to a VS Code near you. There's still some quirks to work out as right now it is hardcoded to F2 but technically you can set the rename keybinding to anything. It's especially not clear on macOS where the default keybinding is but clicking and having your selection change would be infuriating
Great. But I would still prefer if the dot was not selected in combination with the suffix. When you select the suffix you usually want to change it something else. This means you would have to type the dot again.
To verify ensure that pressing after entering rename mode cycles between different segments of the file name
Change:
return true; } case VSCodeOscPt.Property: { <del> const deserialized = args.length ? deserializeMessage(args[0]) : ''; </del> <ins> const arg0 = args[0]; const deserialized = arg0 !== undefined ? deserializeMessage(arg0) : ''; </ins> const { key, value } = parseKeyValueAssignment(deserialized); if (value === undefined) { return true;

Discussion:
Run a command - for example - then and it doesn't exit that command !
Same issue: Versione: 1.78.1 Commit: Data: 2023-05-04T09:57:42.343Z Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 Sistema operativo: Darwin x64 18.7.0 In modalità sandbox: No
insiders-releasecontrl+Cbash: no job control in this shell
me too!
I am also facing the same problem and it is quite frustrating since killing the terminal is not killing the process and every time I have identify the pid and kill it from another terminal. I notice that it is tagged "Closed" but it is not fixed as of yet, atleast in Code-Insiders. Please fix this issue or suggest some sort of solution.
me either
this clearly isn't fixed
The issue this was tracking with the error in console is fixed, let's track any separate problem in
Change:
let result = await provider.provideCompletionItems(model, new Position(1, 8), context)!; assert.equal(result.suggestions.length, 1); <del> toDispose.dispose(); </del> }); test('No snippets shown when triggering completions at whitespace on line that already has text #62335', async function () {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Version: 1.49.0-insider Commit: Date: 2020-08-17T17:11:16.078Z (1 day ago) Electron: 9.2.0 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Darwin x64 19.6.0 Steps to Reproduce: Add the following python snippet: or PowerShell snippet: : which will cause auto-closing pair... (at this point you have where is the cursor) add a or and hit TAB or ENTER on the intellisense item NOTE THE TRAILING . Snippets and auto-closing pairs should play nice together so that the whole experience generates valid code. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Here's a javascript example for array destructuring: which gets you: when you type:
better example! A javascript example for : which gets you: when you type:
for verification, this: should get you: on insert mode replace (default is SHIFT + ENTER)
I'll note that it works fine in non-json files, but is reversed in a json file (as are the insert/replace hints in the suggestion box). W10
that seems like a separate issue not related to this fix. Can you open a new issue?
Yes, I'll open another issue.
Change:
@IMenuService private readonly menuService: IMenuService, @ITelemetryService private readonly telemetryService: ITelemetryService, @IExplorerService private readonly explorerService: IExplorerService, <del> @IStorageService private readonly storageService: IStorageService </del> <ins> @IStorageService private readonly storageService: IStorageService, @IClipboardService private clipboardService: IClipboardService </ins> ) { super({ ...(options as IViewletPanelOptions), id: ExplorerView.ID, ariaHeaderLabel: nls.localize('explorerSection', "Files Explorer Section") }, keybindingService, contextMenuService, configurationService);

Discussion:
<!-- Use Help Report Issue to prefill these. --- VSCode Version: Confirmed in 1.31 and the latest insider. Version: 1.32.0-insider Commit: Version: 1.31.0 (system setup) Commit: OS Version:Windows_NT x64 10.0. Steps to Reproduce: an arbitrary folder in vscode (call it vscode 1) a new vscode window (call it vscode 2) and open another arbitrary folder. a file in vscode 1. +C or select copy from the right-click menu of the file in vscode 1. to paste the file in vscode 2 with Ctrl+V doesn't work. The "paste" menu item in the right-click menu is also grayed out. This used to work in 1.30.2. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Even dragging the files instead of and it will only move files, not folders. Open all the directories (which is a nice new feature). Drag over to the 2nd windows workspace, and all you'll get is files, not folders. OS Version: 4.20.5-arch1-1-ARCH
PR:
Change:
this._webviewWorkbenchService.revealWebview(this._currentReleaseNotes, activeEditorPane ? activeEditorPane.group : this._editorGroupService.activeGroup, false); } else { this._currentReleaseNotes = this._webviewWorkbenchService.createWebview( <del> generateUuid(), </del> <ins> 'vs_code_release_notes', </ins> 'releaseNotes', title, { group: ACTIVE_GROUP, preserveFocus: false },

Discussion:
Issue Type: <bBug</bRelease Notes from Help menu it Release Notes doesn't show an icon on its normal tab, the pinned one is empty. VS Code version: Code - Insiders 1.46.0-insider (, 2020-05-07T16:19:54.327Z) OS version: Windows_NT x64 10.0. ! Compare its appearance to that of my adjacent pinned tab, which is my file (very handy to be able to pin it, kudos to ) <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.669 --- <!-- score: 0.543 --- <!-- score: 0.532 --- <!-- score: 0.455 --<!-- potentialduplicatescomment --
This actually looks like a bug to me, because release notes should have the product icon. Looking into devtools I see it being referenced: ! However, this file does not exist on disk likely because it gets inlined, as you can see in the welcome tab where the icon appears properly: ! Assigning a couple of people to check this.
I should add that I indeed moved this icon to a new place (we had many copies of it). So it could be a regression from that work.
so this is a regression from my push but I think the way the icon is used in here is not ideal because it prevents the image from being inlined: A better solution would be to have it referenced from CSS like we do e.g. in the welcome page: However this would require some name to appear as part of the label we could override. I am not sure how to pass a resource name to the webview? Currently it looks like we add a UUID: ! Open for ideas. Last resort is to just bring back that icon, but then we have it duplicate as before.
This actually has nothing to do with pinned tabs as it appears blank normally: !
Change:
flex: 1; font-size: 11px; font-weight: bold; <del> text-transform: uppercase; </del> overflow: hidden; text-overflow: ellipsis; }

Discussion:
Issue Type: <bBug</bWe are developing an extension that implements a source control provider. It successfully adds s to its section. However the standard themes display the group captions in UPPERCASE by styling them with For our use case it's important to show the group captions in their actual case. AFAIK there isn't a way for our extension to make that happen. VS Code version: Code 1.34.0 (, 2019-05-15T21:59:37.030Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Yeah... let's then change the casing style and just uppercase them on the Git extension directly.
, Removing the styling , is that it or I should add it somewhere ? Because you said
Yeah we want to keep the git extension section as , etc.
, Could not find the exact detail of what to remove. Removing the style will remove it in all places , so that is not correct. I dont understand what group captions actually mean ( CC : , if you could help ) I found there are these ResourceGroup () for which the style is applied. Please help me out with this on the correct approach.
I think proposes that you do remove that style, but that you also change the code to explicitly uppercase the localized captions of the the three items being created there. With those changes Git users won't see any change of behaviour, but other SCM extensions can set mixed-case captions and have them display to the end user.
, Sorry got confused with the group captions , Sent a PR to fix this !
I'd love to see your PR get merged, but for some reason I don't understand it apparently failed in the Windows part of Azure Pipelines. can you help get this moving?
The windows build error might be some random errors , Happened in one more PR ( ) I guess that is not an issue and should confirm that.
Is there some way you can resubmit your PR to the build pipeline? Maybe it will pass the second time. Or if it doesn't perhaps there will be more info in the log.
Change:
workspaceFolderExtensionsConfigContents.set(workspaceFolder.uri, extensionsConfigContent); })); <del> const isWorkspaceRecommended = workspaceExtensionsConfigContent && workspaceExtensionsConfigContent.recommendations?.some(r => r === extensionId); const recommendedWorksapceFolders = workspace.folders.filter(workspaceFolder => workspaceFolderExtensionsConfigContents.get(workspaceFolder.uri)?.recommendations?.some(r => r === extensionId)); </del> <ins> const isWorkspaceRecommended = workspaceExtensionsConfigContent && workspaceExtensionsConfigContent.recommendations?.some(r => r.toLowerCase() === extensionId); const recommendedWorksapceFolders = workspace.folders.filter(workspaceFolder => workspaceFolderExtensionsConfigContents.get(workspaceFolder.uri)?.recommendations?.some(r => r.toLowerCase() === extensionId)); </ins> const isRecommended = isWorkspaceRecommended || recommendedWorksapceFolders.length > 0; const workspaceOrFolders = isRecommended

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: MacOS Monterey 12.3.1 Steps to Reproduce: any directory or workspace, empty directory in the video below for example. Extensions tab, search "volar", then add first two extensions, and into workspace recommendations. : Every time you try to add one of these two extensions, the newly extension id in is a string start with a upper case like "", and the rest of others will change to all lower case string like "", this makes further "Add to Workspace Recommendations" oprations work incorrectly. https://user- My guessing: The function and returns an array of lowercase strings, however those adding or removing functions only push the raw extensionId to config file, which causes this bug when the raw extensionId has upper case.
I am not sure what the bug is here? Since extension ids are case insensitive, we handle them correctly while reading or writing. Can you please let us know what feature is not working?
Well, a simple description: you can click twice when adding first time it will add "" string and second time "". https://user-
Got it. Thanks for providing info.
Change:
private serverProcess: cp.ChildProcess | undefined; <del> constructor(private adapterExecutable: IDebugAdapterExecutable, private debugType: string, private readonly outputService?: IOutputService) { </del> <ins> constructor(private adapterExecutable: IDebugAdapterExecutable, private debugType: string) { </ins> super(); }

Discussion:
Just wondering whether the "Extensions" output channel is actually used for anything? I have checked it when troubleshooting extensions many times and don't think I've ever actually seen any output in there
This is being used by debug adapter Feel free to remove it if you are not using.
Oh, wow No clue about that
I guess it was introduced in , previously showed errors from all extensions, now I think those errors go to other general logs, and probably just this one usage got left behind. any idea if there was some discussion about this in the past? Or I will remove it
not aware of anyone using it. I think we can go ahead and remove it. fyi
bit off-topic here but I was looking around for an issue around a "combined" log (showing the channel inline) - is there such a thing and I'm just missing it? that way I wouldn't have to click around into various logs when I'm trying to figure out what's going on with vscode - I realize I could tail the various files and write a script to make that more convenient I was also thinking maybe an extension could fill that need but then I saw
I think there is an issue to open multiple output channels at once. Please search into our issues.
there are only 10 open issues tagged output - altho this issue is about output and got labeled debug instead - I looked at the debug tagged issues too and didn't see it - should I create one?
Here is the similar request -
Change:
<key>reservedWords</key> <dict> <key>match</key> <del> <string>(b(?&lt;!-|$)(?i:configuration|node|process|enum|filter|sequence|class|data|define|function|dynamicparam|inlinescript|var|parallel|param|workflow)b(?!-|.))</string> </del> <ins> <string>(b(?&lt;!-|$)(?i:configuration|node|enum|filter|sequence|class|data|define|function|dynamicparam|inlinescript|var|parallel|param|workflow)b(?!-|.))</string> </ins> <key>name</key> <string>keyword.other.powershell</string> </dict>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actionRegistry'; import { SyncActionDescriptor } from 'vs/platform/actions/common/actions'; import { IConfigurationRegistry, Extensions as ConfigurationExtensions } from 'vs/platform/configuration/common/configurationRegistry'; <del> import { ShowCurrentReleaseNotesAction, ProductContribution, UpdateContribution, LightUpdateContribution } from './update'; </del> <ins> import { ShowCurrentReleaseNotesAction, ProductContribution, UpdateContribution } from './update'; </ins> Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench) .registerWorkbenchContribution(ProductContribution); <del> if (isMacintosh || product.quality !== 'stable') { Registry.as<IGlobalActivityRegistry>(GlobalActivityExtensions) .registerActivity(LightUpdateContribution); } else { Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench) .registerWorkbenchContribution(UpdateContribution); } </del> <ins> Registry.as<IGlobalActivityRegistry>(GlobalActivityExtensions) .registerActivity(UpdateContribution); </ins> // Editor const editorDescriptor = new EditorDescriptor(

Discussion:
We should push the update UI we were running on insiders to stable. Since the new update notification UI is less invasive, there is the concern that users might forget to update and ignore the notification. Therefore we should add an update reminder, when a user did not update after a period of time. The proposal is to show the existing Update Available message box, when the user did not update after 5 days since the notification has appeared.
Will be fixed by
Fixed.
Change:
getScoped(scope: EnvironmentVariableScope): EnvironmentVariableCollection; } <del> export type EnvironmentVariableScope = { </del> <ins> /** * The scope object to which the environment variable collection applies. */ export interface EnvironmentVariableScope { </ins> /** * Any specific workspace folder to get collection for. */ workspaceFolder?: WorkspaceFolder; <del> }; </del> <ins> } </ins> /** * A location in the editor at which progress information can be shown. It depends on the

Discussion:
Some small tweaks are needed for the new -type it should be an interface, not a type. it lacks a jsdoc comment it's not clear why can be optional?
Will correct it right away It's not something we expect all consumers to consider, as many folks may not care about applying env variables to a particular workspace. In future we may introduce other parameters, and consumers who don't care about it, can simply omit them: A consumer who only cares about shell: cc/
Change:
* Whether to show a compact hover */ compact?: boolean; <ins> /** * Whether to skip the fade in animation, this should be used when hovering from one hover to * another in the same group so it looks like the hover is moving from one element to the other. */ skipFadeInAnimation?: boolean; </ins> } export interface IHoverAction {

Discussion:
Native browser tooltips and many custom ones (Figma, Discord, Edge tabs) keep the tooltip element visible when moving between elements. Would be nice to do the same, to make mouse exploration even snappier. Discord icon bar: ! macOS dock: !
cc as this discussion was spawned off cc as owner of the hover widget cc as we talked about this a few times and he brought it up most recently in the team chat
fyi I'm the main hover widget person This seems doable, needs some thinking on how this would be exposed in the API. It's also a feature of native browser tooltips when hovering from one element with to another.
Thanks for confirmation :)