jiebi/CodeConvo huggingface dataset:
Change:
parsedArgs['_'] = []; <ins> let readFromStdinPromise: Promise<void> | undefined; </ins> if (hasReadStdinArg && hasStdinWithoutTty()) { try { let stdinFilePath = cliStdInFilePath; if (!stdinFilePath) { stdinFilePath = getStdinFilePath(); <del> await readFromStdin(stdinFilePath, verbose); // throws error if file can not be written </del> <ins> const readFromStdinDone = new DeferredPromise<void>(); await readFromStdin(stdinFilePath, verbose, () => readFromStdinDone.complete()); // throws error if file can not be written if (!parsedArgs.wait) { // if `--wait` is not provided, we keep this process alive // for at least as long as the stdin stream is open to // ensure that we read all the data. readFromStdinPromise = readFromStdinDone.p; } </ins> } // Make sure to open tmp file translatePath(stdinFilePath, mapFileUri, folderURIs, fileURIs); <del> // Enable --wait to get all data and ignore adding this to history parsedArgs.wait = true; </del> <ins> // Ignore adding this to history </ins> parsedArgs['skip-add-to-recently-opened'] = true; console.log(`Reading from stdin via: ${stdinFilePath}`); } catch (e) { console.log(`Failed to create file to read via stdin: ${e.toString()}`); } } if (parsedArgs.extensionDevelopmentPath) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (WSL depends on some dependencies) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0 OS Version: Windows 11 23H2 Steps to Reproduce: In a WSL shell run . does not return until the editor tab is closed again. This is no longer intended behaviour since was solved. In PowerShell on the Windows host, the command does work as intended, when running .
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified with VSCode 1.89.0 stable
Change:
import { NOTEBOOK_IS_ACTIVE_EDITOR, NOTEBOOK_OUTPUT_FOCUSED } from 'vs/workbench/contrib/notebook/common/notebookContextKeys'; import { runAccessibilityHelpAction, showAccessibleOutput } from 'vs/workbench/contrib/notebook/browser/notebookAccessibility'; import { IAccessibleViewService } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; <ins> import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; </ins> /*--------------------------------------------------------------------------------------------- */

Discussion:
Hello, I am using jupyter notebook with VsCode. Everything works pretty well, but when I display the output of a cell with control+down arrow, the screen reader announces the entire output cell, but I can't scroll through it line by line with the arrow keys. It would be helpful if the system cursor could scroll within the output cell as in an editor. I also searched within the options, but could not find one that would enable this feature. Germano
thanks for the feedback, we are currently trying to make some improvements in this exact area. I was using for improving the context when focusing on the cell output since, from my experimentation with the screen reader, it tended to jump around to different outputs, but your suggested change might just resolve that issue by better containing the reader within that single output.
Will be one of the reasons we add
can you consider doing this in July?
verification: run a cell with output, either click the output to focus it, or press ctrl+down (default) press alt+F2 output should be presented in an accessible view
I tried to verify with a GitHub Issues notebook, and here's what I get: <img width="1920" alt="image" src=""This view isn't scrollable via mouse or via keyboard arrow down.
support was for jupyter notebooks, not github issue notebooks. We probably shouldn't be showing anything for github issue notebooks for now
strange overflow behavior covered by verification (should only affect ipynb files): run a cell with output, either click the output to focus it, or press ctrl+down (default) press alt+F2 output should be presented in an accessible view
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.21", </del> <ins> "xterm": "5.2.0-beta.22", </ins> "xterm-addon-canvas": "0.4.0-beta.7", "xterm-addon-search": "0.11.0", "xterm-addon-serialize": "0.9.0", "xterm-addon-unicode11": "0.5.0", <del> "xterm-addon-webgl": "0.15.0-beta.4", "xterm-headless": "5.2.0-beta.21", </del> <ins> "xterm-addon-webgl": "0.15.0-beta.5", "xterm-headless": "5.2.0-beta.22", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Type: <bBug</bAfter mutating the accessibility buffer for the integrated terminal in the latest iteration of VS Code, the state of the buffer does not restore after tabbing away and refocusing the terminal accessibility buffer using the keyboard. This makes it so that screen reader users cannot get the correct information after inadvertently modifying the buffer. Additionally, if the buffer is in an incorrect state, newly coming output from the terminal will not be reflected in the buffer, making that particular terminal session unusable for screen reader users. Steps to Reproduce: VS Code in the screen reader optimized mode a new integrated terminal a command that outputs text to the terminal, such as -tab to the accessibility buffer and observe that the information is presented correctly the buffer by typing arbitrary characters (or in the extreme case, press ctrl+a and delete the entire buffer) back to the shell and shift-tab to the buffer again, observe that the buffer remains in the incorrect state back to the shell and type in the command that outputs to the terminal again -tab back to the buffer, observe that the buffer remains in the incorrect state and the newly output information does not appear in the buffer. Actual result: The buffer do not return to its correct state after edit. Expected result: After the buffer has been modified, refocusing the buffer via keyboard should return it to its correct state. Note: This used to work during the early iteration of the accessibility buffer. Tested using NVDA 2022.4 on Windows 11 Pro and the latest commit on the main branch at the time of this report (commit: ) VS Code version: Code - OSS Dev 1.75.0 (Commit unknown, Date unknown) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.3. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
The problem still occurs as of the latest version of VS code.
Change:
import { Color } from 'vs/base/common/color'; import { EventType, EventHelper, Dimension, append, $, addDisposableListener, prepend, reset, getWindow, getWindowId, isAncestor, getActiveDocument, isHTMLElement } from 'vs/base/browser/dom'; import { CustomMenubarControl } from 'vs/workbench/browser/parts/titlebar/menubarControl'; <del> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; </del> <ins> import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; </ins> import { Emitter, Event } from 'vs/base/common/event'; import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage'; import { Parts, IWorkbenchLayoutService, ActivityBarPosition, LayoutSettings, EditorActionsLocation, EditorTabsMode } from 'vs/workbench/services/layout/browser/layoutService';

Discussion:
Currently, allows several variables. It would be awesome for extensibility, if would be supported, with being an arbitrary context variable. Then extensions could contribute to the window title (candidates would be or ). I'd be up to create a PR! Related:
Sounds interesting, feel free to give it a try. The variables are substituted from here:
anyone assign me pls
Verification steps: an extension, create a contxt key and register a title variable to in settings and add the newly created title variable (for example ) sure the window title correctly renders the value of the variable in the command center / window title area
Change:
this.updateStatus({ message: new MarkdownString(localize('globally enabled', "This extension is enabled globally.")) }, true); return; } <del> if (this.extension.enablementState === EnablementState.EnabledWorkspace) { this.updateStatus({ message: new MarkdownString(localize('workspace enabled', "This extension is enabled for this workspace by the user.")) }, true); return; } </del> } if (!isEnabled && !isRunning) {

Discussion:
Type: <bBug</bfolder under WSL. to extension and for some extension chose Enable Enable (Workspace). ! Problem: extension is displayed as enabled in WSL globally ! It must be displayed as enabled in this workspace, see for example how it looks when not using WSL ! VS Code version: Code 1.78.2 (, 2023-05-10T14:39:26.248Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ Bookmarks13.3.1 jupyter-keymap1.1.0 remote-containers0.292.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.78.8 remote-explorer0.4.0 vscode-gn1.1.0 ng-template16.0.0 asciidoctor-vscode2.9.8 vscode-fish1.0.33 bitbake1.1.2 cmake-tools1.14.31 cpptools1.15.4 cpptools-extension-pack1.3.0 makefile-tools0.7.0 vscode-xml0.25.0 shader1.1.5 cmake0.0.17 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Seems like a UI bug
Change:
openFolderSettings(folder: URI, options?: IEditorOptions, group?: IEditorGroup): TPromise<IEditor>; switchSettings(target: ConfigurationTarget, resource: URI): TPromise<void>; openGlobalKeybindingSettings(textual: boolean): TPromise<void>; <ins> openRawDefaultKeybindings(): TPromise<IEditor>; </ins> configureSettingsForLanguage(language: string): void; }

Discussion:
New Setting: New Action: Currently, allows users to disable the side-by-side default/user settings view, instead allowing us to view our customized settings file in isolation when using the command. A corresponding option does not yet exist for , although it would be equally useful. Additionally, something like contribution in should be implemented to allow access of the default keybindings if is disabled.
I'd like to take solve this issue. any suggestions? What files will I have to work with for this? This would be my first contribution to VSCode!
References: for Opening raw default for not opening default settings
Hey guys, I got some work around for showing user settings in (GUI) (yet not pushed in my PR), but I had a question. If we set : and open (GUI), it should show only user keybinding settings. But then how should we handle and actions in menu (3 dot at right corner)?
The filtering effects of & seem to be isolated to the UI, so I would expect them to retain their existing functionality. The proposed changes are intended to affect .
Change:
this.tree.setInput({ processes: { processRoots } }); this.tree.layout(window.innerHeight, window.innerWidth); <ins> this.tree.onKeyDown(e => { const event = new StandardKeyboardEvent(e); if (event.keyCode === KeyCode.KeyE && event.altKey) { const selectionPids = this.getSelectedPids(); void Promise.all(selectionPids.map((pid) => this.nativeHostService.killProcess(pid, 'SIGTERM'))).then(() => this.tree?.refresh()); } }); </ins> this.tree.onContextMenu(e => { if (isProcessItem(e.element)) { this.showContextMenu(e.element, true);

Discussion:
Depends on This is common for process explorers on Windows at least, might also make sense to bring this to Linux.
This should be doable now that has landed via
Change:
position: static; /** disable sticky positions for sticky compact/shrink tabs if the available space is too little */ } <del> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.tab-actions-left .action-label { margin-right: 4px !important; } </del> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-shrink.tab-actions-left::after, .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-shrink.tab-actions-off::after { content: '';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: macOS 12.5 Steps to Reproduce: to at the tab's close button - it's too far to the left, butting up against the start of the tab (especially noticeable when hovered over) compared to when set to Comparison: <img width="148" alt="image" src="https://user-"<img width="137" alt="image" src="https://user-"
Agree it looks too far to the beginning of the tab. I think the change in pushes the close button more to the left, can you elaborate why that was done? Today: <img width="178" alt="image" src="https://user-"After removing the 4px: <img width="175" alt="image" src="https://user-"
I'm trying to remember why that was changed and can't remember, happy to remove if it doesn't appear to break anything.
Change:
}; } <del> revert(diff: DetailedLineRangeMapping): void { if (diff.innerChanges) { this.revertRangeMappings(diff.innerChanges); return; } </del> <ins> revert(diff: LineRangeMapping): void { </ins> const model = this._diffModel.get(); if (!model || !model.isDiffUpToDate.get()) { return; }

Discussion:
a change it using the gutter arrow :bug: indentation is lost
Can you share a screenshot/screenrecording and provide context on the document you have? Thanks!
Cannot reproduce: ! Please always try to include as much context as you can.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Hi Henning I think I can also reproduce this in 1.84.0-insider (MacOS). I believe the preconditions to reproduce is to set (which is also the default) and revert a deleted code chunk. See attached gif. !
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
Change:
'window.zoomLevel': { 'type': 'number', 'default': 0, <ins> 'minimum': -5, </ins> 'description': localize('zoomLevel', "Adjust the zoom level of the window. The original size is 0 and each increment above (e.g. 1) or below (e.g. -1) represents zooming 20% larger or smaller. You can also enter decimals to adjust the zoom level with a finer granularity."), ignoreSync: true, tags: ['accessibility']

Discussion:
Issue Type: <bBug</b#Steps Go to preferences Enter a zoom value too small (I entered -140) #Result Everything dissapears and clicking on the window minimizes it. CTRL + "+" doesn't work #Workaround Go to under AppData/Roaming/Code and change the zoom value in the file to normal levels VS Code version: Code 1.69.1 (, 2022-07-12T08:21:24.514Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ better-cpp-syntax1.15.19 jupyter-keymap1.0.0 remote-containers0.241.3 remote-ssh0.84.0 remote-ssh-edit0.80.0 remote-wsl0.66.3 vscode-intelephense-client1.8.2 prettier-vscode9.5.0 cpptools1.10.8 save-as-root1.4.2 markdown-all-in-one3.4.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
</dict> <dict> <key>begin</key> <del> <string>(?&lt;![-])#</string> </del> <ins> <string>(?&lt;![`-])#</string> </ins> <key>end</key> <string>$</string> <key>name</key>

Discussion:
There's syntax highlighting as part of the PowerShell extension to indicate comments. It serves to highlight comments in green. The highlighting looks for a pattern of to detect the start of a comment. In PowerShell, backtick is the escape character, and can be used to treat the character as a literal character instead of the start of a comment. The regular expression that detects comments doesn't take this into account. ! This line has incorrect syntax highlighting. The backtick should escape the and negate the syntax highlighting that colors the remainder of the line green. The regular expression in the PowerShell syntax tmlanguage file can be changed:  Adding the backtick character would resolve this issue, and then the pattern would be -])#`. ! I'm planning on submitting a PR to fix this after submitting this issue.
Change:
} createTerminal(options?: ICreateTerminalOptions): ITerminalInstance { <ins> console.log(options); </ins> const shellLaunchConfig = this._convertProfileToShellLaunchConfig(options?.config || options); if (options?.cwd) {

Discussion:
The terminal commands and are used for both the panel buttons and the commands in the CP (that we do want to use the defaultLocation for). Not sure how to differentiate between them - don't think we want to duplicate the actions. let me know what you think
Let's wait until after is done since that will likely add target support to the create commands
Other reproes: Ctrl / Cmd J to open the panel - terminal editor is created focus the terminal editor, click the trash can on the panel , close the editor tab - a bunch of errors in the console
Change:
'use strict'; import 'vs/css!./media/explorerviewlet'; <ins> import nls = require('vs/nls'); </ins> import { IActionRunner } from 'vs/base/common/actions'; import { TPromise } from 'vs/base/common/winjs.base'; import * as DOM from 'vs/base/browser/dom';

Discussion:
Today we show the workspace name it seems.
! What does "title" mean? 1 or 2?
2
It should be FOLDERS in multi root mode, and foldername_ otherwise, right?
Right
It behaves exactly in this way currently. I suppose this issue should be closed.
We should first ask if he can still repro this issue since is not seeing it, are tehre special repro steps
There are no special steps to repro this, so please confirm
!
I still cannot reproduce this. Also, your layout differs from mine - control buttons on the EXPLORER bar. Could you please explain, how I can switch VSCode into such a view?
I have "open editors" section disabled.
Change:
if (!activePane || !this.toolBar) { return 0; } <del> return this.toolBar.getItemsWidth() + 5 + (this.globalToolBar?.getItemsWidth() ?? 0); // 5px toolBar padding-left </del> <ins> // Each toolbar item has 4px margin in the panel toolbar const toolBarWidth = this.toolBar.getItemsWidth() + this.toolBar.getItemsLength() * 4; const globalToolBarWidth = this.globalToolBar ? this.globalToolBar.getItemsWidth() + this.globalToolBar.getItemsLength() * 4 : 0; return 5 + toolBarWidth + globalToolBarWidth; // 5px toolBar padding-left </ins> } private onTitleAreaContextMenu(event: StandardMouseEvent): void {

Discussion:
extra padding right to the dropdown in terminal in insider release as shown in image below ! in stable release I don't see it !
also the terminal action also not work when I open the insiders window if create a one more terminal and then these actions start working !
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
Looks like regression by
Thanks for reporting these issues I created a separate issue for the second bug you mentioned here:
Change:
"config.scanRepositories": "List of paths to search for git repositories in.", "config.showProgress": "Controls whether git actions should show progress.", "config.rebaseWhenSync": "Force git to use rebase when running the sync command.", <del> "config.confirmEmptyCommits": "Always confirm the creation of empty commits.", </del> <ins> "config.confirmEmptyCommits": "Always confirm the creation of empty commits for the 'Git: Commit Empty' command.", </ins> "config.fetchOnPull": "Fetch all branches when pulling or just the current one.", "config.pullTags": "Fetch all tags when pulling.", "config.autoStash": "Stash any changes before pulling and restore them after successful pull.",

Discussion:
I'd love it if the description would specify that this setting only pertains to the command as explained in , as opposed to the SCM interface, which would be the expected behavior according to the current description.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.564 --<!-- potentialduplicatescomment --
Feel free to submit a PR for this instead. Here's where you want to edit:
Cool, thanks!
Change:
replacePattern = parseReplaceString('newfoo-newbar'); actual = replacePattern.buildReplaceString(['Foo-Bar-abc'], true); assert.equal(actual, 'Newfoo-newbar'); <ins> replacePattern = parseReplaceString('newfoo_newbar'); actual = replacePattern.buildReplaceString(['Foo_Bar'], true); assert.equal(actual, 'Newfoo_Newbar'); replacePattern = parseReplaceString('newfoo_newbar_newabc'); actual = replacePattern.buildReplaceString(['Foo_Bar_Abc'], true); assert.equal(actual, 'Newfoo_Newbar_Newabc'); replacePattern = parseReplaceString('newfoo_newbar'); actual = replacePattern.buildReplaceString(['Foo_Bar_abc'], true); assert.equal(actual, 'Newfoo_newbar'); replacePattern = parseReplaceString('newfoo_newbar-abc'); actual = replacePattern.buildReplaceString(['Foo_Bar-abc'], true); assert.equal(actual, 'Newfoo_newbar-abc'); </ins> }); });

Discussion:
and , Similar to , We can implement for underscore character as well , Proposing this will be only just underscore or just hyphen replacements and not both. Foo-Bar replaced with newfoo-newbar with case preserved will be Newfoo-Newbar and FooBar will be NewfooNewBar. Please let me know if this gets a node from you guys ? Thanks!
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.706 --<!-- potentialduplicatescomment --