jiebi/CodeConvo huggingface dataset:
Change:
@IWorkspaceTrustManagementService private readonly _workspaceTrustManagementService: IWorkspaceTrustManagementService, @ILogService private readonly _logService: ILogService) { super(); <del> if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } </del> <ins> this._taskService.onDidReconnectToTasks((() => { if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } })); </ins> this._register(this._workspaceTrustManagementService.onDidChangeTrust(async trusted => { if (trusted) { await this._tryRunTasks();

Discussion:
Currently, one can have a task that runs on folder open (startup), but if window is reloaded, they get a notification "The task '<myTask' is already active." with options to terminate or restart the task. It would be great to have an option to never see this notification either as a button or within gear-icon context menu on the notification.
Yeah this is happening because of automatic tasks / reconnected tasks each trying to start the same one. We should ignore the request if it's coming from one or the other source (reconnection or automatic) and the task is already running
Workaround for now is to remove the folderOpen property or disable reconnection
I do not see my task getting run either on first open or window reload
found that this does not work in old Codespaces, which we are tracking here .

create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first
Change:
this._inFlightRequests.set(extensionId, inFlightRequests); } } <del> return session; </del> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: an extension that does this: 'll notice that is though it should exist because we created it on line 1. This is because we cache the session id based on the provider id & extension name but really we should be caching them based on provider id, extension name, AND SCOPES. This will allow the 3rd time to find the session created in the first line.
Verification steps: The code session3 should not be undefined.
is your solution to this issue the reason that the Insiders builds have started bugging me at least once a day to sign into GitHub? With four windows open, each with two extensions that want a GitHub token (GitLens and GitHub Issues and Pull Requests), I have to generate 8 tokens to make VS Code stop bugging me... at which point it almost always discovers a VS Code update, and often we do the dance again after it restarts.
(And never mind, I see it was, and I see you fixed it!)
Reopening this because I reverted the change that fixed it.
just checking to see if there were any updates on this issue?
haven't had a chance to revisit this. You can take a look at my commit if you'd like. The problem I needed to address is migrating from the old storage keys to the new storage keys and my commit didn't handle that. Unfortunately, I have some other work I'm working on at the moment so I won't be able to look at this this month.
This appears to be fixed. Closing now
verification: original steps to repro. Instead, session3 should be defined.
Change:
if (options.recursive) { command.push('--recursive'); } <ins> if (options.ref) { command.push('--branch', `'${options.ref}'`); } </ins> await this.exec(options.parentPath, command, { cancellationToken, env: { 'GIT_HTTP_USER_AGENT': this.userAgent },

Discussion:
Testing According to , we can have git checkout a specific branch as part of the cloning command. That way we can avoid slowness as well as a double progress indicator.
Verification From your browser, enter . This should clone the repo and checkout the branch , and there should only be one progress notification for the clone progress, there shouldn't be a second progress notification for the checkout
I just get messages like Version: 1.73.0-insider (user setup) Commit: Date: 2022-10-26T09:31:30.519Z Edit: It's missing url=. Will try again.
Thanks
Change:
title: localize('workbench.action.terminal.clearLong', "Clear Terminal"), icon: Codicon.clearAll }, <del> group: 'execute', </del> <ins> group: 'navigation', </ins> order: 4, when: ContextKeyExpr.equals('view', TERMINAL_VIEW_ID), isHiddenByDefault: true

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VS Code has always been able to clear Terminal only by binding shortcuts or shortcut menus. When debugging server logs, we will often need to clear the logs, and Chrome DevTools provides a separate button for that as well. I can submit a PR for this. ! !
This is actually already a feature but recently regressed. Clear Terminal is in the overflow menu, and in the next release you'll be able to right click to show it in the panel again: !
Change:
const gtkIMModuleFile = process.env['GTK_IM_MODULE_FILE']; const gdkBackend = process.env['GDK_BACKEND']; const gioModuleDir = process.env['GIO_MODULE_DIR']; <ins> const gtkExePrefix = process.env['GTK_EXE_PREFIX']; </ins> delete process.env['GDK_PIXBUF_MODULE_FILE']; delete process.env['GDK_PIXBUF_MODULEDIR']; delete process.env['GTK_IM_MODULE_FILE']; delete process.env['GDK_BACKEND']; delete process.env['GIO_MODULE_DIR']; <ins> delete process.env['GTK_EXE_PREFIX']; </ins> shell.openExternal(url);

Discussion:
Ubuntu 22.10, Gnome 43.1, fresh VM - The errors are not shown the second time I call and also VS Code seems to start and work I saw , but that should be in by now.
Change:
dependencies: is-number "^7.0.0" <ins> vscode-uri@^3.0.8: version "3.0.8" resolved "https://registry.yarnpkg.com/vscode-uri/-/vscode-uri-3.0.8.tgz#1770938d3e72588659a172d0fd4642780083ff9f" integrity sha512-AyFQ0EVmsOZOlAnxoFOGOq1SQDWAB7C6aqMGS23svWAllfOaxbuFvcT8D1i8z3Gyn8fraVeZNNmN6e9bxxXkKw== </ins> which-pm@^2.1.1: version "2.1.1" resolved "https://registry.yarnpkg.com/which-pm/-/which-pm-2.1.1.tgz#0be2b70c67e94a32e87b9768a94a7f0954f2dcfa"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: NA <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: NA OS Version: NA extensions/npm does depend on vscode-uri (tasks.?s import it), but doesn't declare it in , which results in following build failure of vscode: Please add into dependencies. I'd love to submit a PR myself, but unfortunately .
how are you building VS Code? I don't see this error.
As per instructions in this repository. step fails with the error I mentioned. , in dependencies.
Can you share a link to the instructions?
Here is my build script: And it fails: Unless
Can you reproduce the problem you're seeing with just the repo?
It is already so. I don't use any other repos.
your build script isn't in Does this issue occur when you use the build scripts in
is exactly from this repository. Well, after of course.
Any news on this?
Was this issue fixed?
what should we do here?
I think you just need to submit a PR adding this dependency
Exactly, I confirm.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified Built from successfully without needing to remove
Change:
if (value === true) { newValue = 'on'; } else if (value === false) { <del> newValue = 'auto'; </del> <ins> newValue = 'off'; </ins> } return [ ['debug.autoExpandLazyVariables', { value: newValue }],

Discussion:
Testing There does not seem to be a need to keep the setting in the JSON, it can be removed because "auto" (with which the value is replaced) is the new default.
Also- should be translated to ? That was my interpretation.
Not sure I understand. Can you state steps to repro, your expectation vs what actually happened?
I believe this is what Christof meant: to false. the window that it now says this is the default value, we expected the line to disappear completely, since the absence of already implies
Thanks, are you in screen reader mode when that is the case?
yup! but I'm not sure if it happens regardless. Isn't it just the process of auto-migrating the setting to the new one?
I see some bugs with this, thanks for the issue. To verify: With or without screen reader mode, if you have it set to and reload, you should see it set to . With or without screen reader mode, if you have it set to and reload, you should see it set to .
Thanks for the clear verification steps, Also made much easier with profiles editor
Change:
return false; } <ins> private _getEditorFromContext(context?: KernelQuickPickContext): INotebookEditor | undefined { let editor: INotebookEditor | undefined; if (context !== undefined && 'notebookEditorId' in context) { const editorId = context.notebookEditorId; const matchingEditor = this._editorService.visibleEditorPanes.find((editorPane) => { const notebookEditor = getNotebookEditorFromEditorPane(editorPane); return notebookEditor?.getId() === editorId; }); editor = getNotebookEditorFromEditorPane(matchingEditor); } else if (context !== undefined && 'notebookEditor' in context) { editor = context?.notebookEditor; } else { editor = getNotebookEditorFromEditorPane(this._editorService.activeEditorPane); } return editor; } </ins> private _getKernelPickerQuickPickItems( notebookTextModel: NotebookTextModel, matchResult: INotebookKernelMatchResult,

Discussion:
Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width="601" alt="image" src="https://user-"This can be simplified as a single "Selected" group at the very top <img width="601" alt="image" src="https://user-"
Change:
await this.synchroniseUserDataSyncStoreType(); } <del> this.notificationService.info(localize('sync turned on', "{0} is turned on", `${SYNC_TITLE} [(${localize('show log', "show log")})](command:${SHOW_SYNC_LOG_COMMAND_ID})`)); </del> <ins> this.notificationService.info(localize('sync turned on', "{0} is turned on", SYNC_TITLE)); </ins> } async turnoff(everywhere: boolean): Promise<void> {

Discussion:
Wasn't sure why we show this link when turning Settings Sync on. Do we need it for some reason? Seems somewhat low-level/technical. If so, maybe it should be after the string e.g. <img width="498" alt="CleanShot 2022-10-07 at 15 43 07 src="https://user-"
Yah, it was in the beginning for users to discover what is happening. But, I agree that it does not has to be user facing.
Change:
} else { slideManager.classList.add('showDetails'); slideManager.classList.remove('showCategories'); <del> this.container.querySelector<HTMLButtonElement>('.prev-button.button-link')!.style.display = 'block'; </del> <ins> const showGoBackButton = this.editorInput.showWelcome || this.prevWalkthrough; this.container.querySelector<HTMLButtonElement>('.prev-button.button-link')!.style.display = showGoBackButton ? 'block' : 'none'; </ins> this.container.querySelector('.gettingStartedSlideDetails')!.querySelectorAll('button').forEach(button => button.disabled = false); this.container.querySelector('.gettingStartedSlideCategories')!.querySelectorAll('button').forEach(button => button.disabled = true); this.container.querySelector('.gettingStartedSlideCategories')!.querySelectorAll('input').forEach(button => button.disabled = true);

Discussion:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.
Change:
AppMutex: product.win32MutexName, TunnelMutex: product.win32TunnelMutex, TunnelServiceMutex: product.win32TunnelServiceMutex, <ins> TunnelApplicationName: product.tunnelApplicationName, </ins> ApplicationName: product.applicationName, Arch: arch, AppId: { 'ia32': ia32AppId, 'x64': x64AppId, 'arm64': arm64AppId }[arch],

Discussion:
Type: <bBug</bVS Code version: Code - Insiders 1.80.0-insider (, 2023-06-19T05:35:37.388Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
same here
Made a fix but didn't create a PR apparently. Fixed in next Insiders.
Reopening due to
Change:
AppMutex: product.win32MutexName, TunnelMutex: product.win32TunnelMutex, TunnelServiceMutex: product.win32TunnelServiceMutex, <ins> TunnelApplicationName: product.tunnelApplicationName, </ins> ApplicationName: product.applicationName, Arch: arch, AppId: { 'ia32': ia32AppId, 'x64': x64AppId, 'arm64': arm64AppId }[arch],

Discussion:
Running can block the VS Code update on Windows as it prevents deleting the parent folder. The updater needs a way to terminate it, and a mutex to know that it needs to be terminated.
Change:
import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { ILocalizedString } from 'vs/platform/action/common/action'; import { Codicon } from 'vs/base/common/codicons'; <ins> import { CancellationError } from 'vs/base/common/errors'; </ins> registerSingleton(IEditSessionsLogService, EditSessionsLogService, InstantiationType.Delayed); registerSingleton(IEditSessionsStorageService, EditSessionsWorkbenchService, InstantiationType.Delayed);

Discussion:
extension suppresses cancellation errors so Create New Codespace errors or cancellations show up as reports all errors as rather than distinguishing cancellation errors
Change:
const uri = URI.parse(request.url); const entry = WebviewProtocolProvider.validWebviewFilePaths.get(uri.path); if (typeof entry === 'string') { <del> let url: string; if (uri.path.startsWith('/electron-browser')) { url = require.toUrl(`vs/workbench/contrib/webview/electron-browser/pre/${entry}`); } else { url = require.toUrl(`vs/workbench/contrib/webview/browser/pre/${entry}`); } return callback(decodeURIComponent(url.replace(`${Schemas.file}://`, ''))); </del> <ins> const relativeResourcePath = uri.path.startsWith('/electron-browser') ? `vs/workbench/contrib/webview/electron-browser/pre/${entry}` : `vs/workbench/contrib/webview/browser/pre/${entry}`; const url = FileAccess.asFileUri(relativeResourcePath, require); return callback(decodeURIComponent(url.fsPath)); </ins> } } catch { // noop

Discussion:
The context is: and the deprecation of I noticed 2 uses of that ideally we can replace with and : I would have done it but wasn't exactly sure, my guess would be to use the variant here since we are in context.
Right now it looks like returns a uri. Will it instead return a uri as part of ?
sorry, forgot to mention: currently on I have just put stubs that do nothing, but in the branch, you will: get a scheme when using get a scheme when using As long as you are in environments, it should be unless you add this to a renderer (e.g. DOM).
Change:
const out = new vscode.MarkdownString(); appendDocumentationAsMarkdown(out, documentation, tags, filePathConverter); out.baseUri = baseUri; <ins> out.isTrusted = { enabledCommands: [OpenJsDocLinkCommand.id] }; </ins> return out; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: see below, pulled from the "Help About" dialog. Also confirmed in 1.71.2. OS Version: see below, pulled from the "Help About" dialog. Steps to Reproduce: above VSCode Insiders build. (Instructions don't require system path to be updated.) a directory in WSL, say . , where is the distro of your choice. the WSL extension as prompted and reload. the editor and run , where is the distro of your choice. (Steps 2-4 were just to initialize some VSCode state.) a new file in that directory with the following contents: restart editor. (Works either way.) over above. tooltip will appear with "some thing linking Foo" where is hyperlinked. Click the hyperlink in the tooltip. attempts to open a file at the path in the parent Windows OS, outside of any WSL distro. Note that this reproduces both with the WSL extension enabled the whole time (skipping step 5) and with it disabled at step 5.
Did this get missed?
I have the same issue with VSCode running in WSL2 (Ubuntu)
Same issue here, using a remote connection to a VM running on Hyper-V. Host OS is Windows, guest OS is Ubuntu 22.04. It only happens when clicking the link in the tooltip. Using directly in the editor works as expected.
Still seeing this issue. Looking forward to this getting resolved soon.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
mainContext: IMainContext, private readonly _logService: ILogService, private readonly _commands: ExtHostCommands, <del> private readonly _documents: ExtHostDocuments, private readonly _notebooks: ExtHostNotebookController </del> <ins> private readonly _documents: ExtHostDocuments </ins> ) { super(); this._proxy = mainContext.getProxy(MainContext.MainThreadChatAgents2);

Discussion:
Today inline chat for editors and notebooks rely on implicit variables, e.g . This isn't proper and we should have real API, e.g some extra property on that encapsulates data about the chat location.
Done, no more implicit variables
Change:
}), true); }); <del> test('Unable to open '%A0.txt': URI malformed #76506', function () { </del> <ins> test('Unable to open '%A0.txt': URI malformed #76506, part 2', function () { </ins> assert.strictEqual(URI.parse('file://some/%.txt').toString(), 'file://some/%25.txt'); assert.strictEqual(URI.parse('file://some/%A0.txt').toString(), 'file://some/%25A0.txt'); });

Discussion:
wrongly encode IPv6 literals ( This is an issue with but if I understand correctly issues should be reported here ) can parse IPv6 literal address fine (examples are using node REPL) but will encode the : This string representation of the URI cannot be used for example by a web browser. This encoding seems to happen here <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: main ( ) OS Version: linux Steps to Reproduce: actual: expected:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Looks similar to:
Change:
private readonly transientDisposables = this._register(new DisposableStore()); private enabled: boolean = false; private workbenchState: WorkbenchState; <del> private keybindingLabel?: KeybindingLabel; </del> <ins> private keybindingLabels = new Set<KeybindingLabel>(); </ins> constructor( container: HTMLElement,

Discussion:
Version of VS Code: 1.89.0 ! Your operating system: Windows 11 List of extensions that you have installed: Happens with none installed. Reproducible steps: 1 - Open VsCode. 2 - Hover over the Show Settings Ctrl + , Watermark 3 - Hover over Find in Files Ctrl + Shift + F What you expected to see, versus what you actually saw: When hover on Ctrl + , ! When hover on Ctrl + Shift + F and any other !
This is a regression from
Does the cause some other bug?
I think we need to properly keep track of disposables.
Change:
private _backgroundColor: Color; constructor(editor: ICodeEditor, private exceptionInfo: IExceptionInfo, private lineNumber: number, @IContextViewService private contextViewService: IContextViewService, @IDebugService private debugService: IDebugService,

Discussion:
<!-- Do you have a question? Please ask it on --- Tests: VSCode Version: 1.11.0-insider OS Version: Windows Steps to Reproduce: debug as node app. Observe: exception widget is not showing. It does if I throw new Error ('Hello World')