jiebi/CodeConvo huggingface dataset:
Change:
} if (dependenciesAndPackExtensions.length) { <del> // filter out installed and known extensions </del> <ins> // filter out known extensions </ins> const identifiers = [...knownIdentifiers, ...allDependenciesAndPacks.map(r => r.gallery.identifier)]; const ids = dependenciesAndPackExtensions.filter(id => identifiers.every(galleryIdentifier => !areSameExtensions(galleryIdentifier, { id }))); if (ids.length) {

Discussion:
VS Code Version: stable and from sources When launching the server and installing extensions using that have a common dependency, one of the extensions will fail activating, prompting to reload VS Code. For example installing, and contains which depends on also depends on installation task finishes first and then trying to activate fails as for installation which is part of installation task Steps to Reproduce: this branch in gitpod or codespaces will fail activating and a notification shows prompting to reload vscode <img width="448" alt="error_iamge" src="https://user-"cc
would you accept a PR fixing this? I took a look but it doesn't look something trivial to fix properly, I but I don't think is a good fix
PR would be always welcome. Agreed it is not trivial. Let's see if there is a simple fix that fixes this and won't cause any regressions.
Created a PR with a possible fix
ping, by any chance for July
I am sorry that I am on vacation so cannot be looked in July.
I was following this other , but it was marked as a duplicate and was therefore closed. This isse seems to be closed as well, although the issue persists. Specifically, it seems that VS Code Dev Containers installs extensions in alphabetical order, so that if an extension that comes later in the order is a pre-requisite for another that is earlier, then the installations will not behave as expected. Example, is a pre-requisite for , but comes later in alphabetical order. Thus, requires a VS Code Session restart after building the Dev Container. Is this issue fixed in VS Code Insiders, but not released yet?
The issue you reported is using the build 1.71. and this fix was pushed in 1.72.. So please update your VS Code and try.
Change:
opacity: .8; } <ins> .runtime-extensions-editor .monaco-action-bar  { height: unset; } </ins> .runtime-extensions-editor .monaco-action-bar .actions-container { justify-content: left; }

Discussion:
"Running Extensions" tab extensions with uncaught errors 's a barely visible piece of a "report issue" button ! !
I could use some help here. Change it such that the action bar is always shown: The "Report Issue" action label is cut short to be 22x22px : <img width="268" alt="image" src="https://user-"
Looks like the default styling of the action items is icon only (codicon) and that comes with a fixed width... I will look into a fix
I got the message to show in VS Code stable, but I couldn't get it to show in insiders. Maybe I'm holding it wrong though so I will leave someone else to verify.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Nope. The button "Report Issue" is still hidden in .
Well, there was an attempt... While fixing I just patched the aforementioned lines but what kind of error does your extension throw to be reported there? Can you share your sample?
In :
Change:
registerEditorAction(FoldAllBlockCommentsAction); registerEditorAction(FoldAllRegionsAction); registerEditorAction(UnfoldAllRegionsAction); <del> registerEditorAction(FoldAllRegionsExceptAction); registerEditorAction(UnfoldAllRegionsExceptAction); </del> <ins> registerEditorAction(FoldAllExceptAction); registerEditorAction(UnfoldAllExceptAction); </ins> registerEditorAction(ToggleFoldAction); registerEditorAction(GotoParentFoldAction); registerEditorAction(GotoPreviousFoldAction);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 OS Version: Win 10 Pro Steps to Reproduce: some code with several regions and code blocks cursor inside a region, press Ctrl+Shift+P and select "Fold all regions except selected" just the other regions are folded but all code blocks.
Yes, it should fold everything, not just regions. I fix the command label.
Change:
if (shouldRestartFind) { this._start({ forceRevealReplace: false, <del> seedSearchStringFromSelection: false, </del> <ins> seedSearchStringFromSelection: false && this._editor.getConfiguration().contribInfo.find.seedSearchStringFromSelection, </ins> shouldFocus: FindStartFocusAction.NoFocusChange, shouldAnimate: false, });

Discussion:
VSCode Version: Code 1.17.2 (, 2017-10-16T13:47:41.889Z) OS Version: Darwin x64 17.0.0 Extensions: ExtensionVersion ------ unity-tools0.1.9 unity-debug1.2.1 vscode-eslint1.3.2 python0.7.0 cpptools0.14.0 csharp1.12.1 mono-debug0.15.7 vscode-arduino0.2.9 Steps to Reproduce: the user setting "": false, text in a document command-e command-f Expected results: VS Code matches the standard Mac text find behavior, where command-e populates the search pasteboard with the current selection, but doesn't show the find panel. Pressing command-f thereafter shows the find panel, revealing what I put in there with command-e. Actual results: pressing command-e shows the find panel and doesn't populate the search pasteboard Plx to allow me to match the macOS standard behavior! Is my favest! <!-- Launch with to check. --Reproduces without extensions: Yes
Change:
totalTime: sample.totalTime, percentage: sample.percentage, functionName: sample.location, <del> callstack: sample.caller.map(c => `${c.percentage}|${c.location}`).join('<'), extensionId: '' </del> <ins> callstack: sample.caller.map(c => c.location).join('<'), extensionId: '<<renderer>>' </ins> }; this._telemetryService.publicLog2<TelemetrySampleData, TelemetrySampleDataClassification>('prof.freeze.sample', data);

Discussion:
Since long we automatically profile the extension host when it becomes unresponsive. In that cases we send a signal via telemetry and in bad cases we ask users to file issues. During that we ask them to attach the corresponding profile but we have mixed results with that. So, in addition to the existing flow we want to log a richer telemetry event that uploads the heaviest sample trace from the profiling
Change:
text-decoration: underline; } <del> .settings-editor.no-toc-search > .settings-body .settings-tree-container .monaco-list-rows, </del> .settings-editor.narrow-width > .settings-body .settings-tree-container .monaco-list-rows { margin-left: 0px; }

Discussion:
Issue Type: <bBug</bRepro steps: settings to for a setting screen really large :bug: Content does not center with the header <img width="1282" alt="image" src="https://user-"VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-23T06:13:04.232Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ vscode-browser-preview0.2.5 vscode-svgviewer1.4.7 prettier-vscode1.7.3 vscode-typescript-tslint-plugin0.3.0 debugger-for-chrome4.11.1 code-settings-sync3.2.4 (5 theme extensions excluded) </details<!-- generated by issue reporter --
Change:
static readonly SourceFixAll: CodeActionKind; /** <ins> * Base kind for all code actions applying to the enitre notebook's scope. CodeActionKinds using * this should always begin with `notebook.` * * This requires that new CodeActions be created for it and contributed via extensions. * Pre-existing kinds can not just have the new `notebook.` prefix added to them, as the functionality * is unique to the full-notebook scope. * * Notebook CodeActionKinds can be initialized as either of the following (both resulting in `notebook.source.xyz`): * - `const newKind =  CodeActionKind.Notebook.append(CodeActionKind.Source.append('xyz').value)` * - `const newKind =  CodeActionKind.Notebook.append('source.xyz')` * * Example Kinds/Actions: * - `notebook.source.organizeImports` (might move all imports to a new top cell) * - `notebook.source.normalizeVariableNames` (might rename all variables to a standardized casing format) */ static readonly Notebook: CodeActionKind; /** </ins> * Private constructor, use statix `CodeActionKind.XYZ` to derive from an existing code action kind. * * @param value The value of the kind, such as `refactor.extract.function`.

Discussion:
Issue to document the final state of the CodeActionKind. Current proposition is as follows: A new top level kind will be introduced as , referenced as for extension authors and core usage If a notebook CodeAction is called against a notebook, it will ONLY be called against the first cell of the notebook, and will precede the standard source CodeActions that will run against each cell in asynchronously. This is to ensure that all edits involving multiple cells will be addressed before any per cell action is taken. (ex: move all imports to top of notebook, normalize variable names, source.organizeImports, etc.) Extension authors will be recommended via documentation in to use one of the following notations to create their kind: - The following also works, but is less explicit: - Extension authors will be expected to register their provider with an adequate , as well as that contains the field The following will be to : thank you
Change:
} } <ins> get hasErrorState(): boolean { if (this._workingCopy && 'hasState' in this._workingCopy) { return this._workingCopy.hasState(StoredFileWorkingCopyState.ERROR); } return false; } get hasConflictState(): boolean { if (this._workingCopy && 'hasState' in this._workingCopy) { return this._workingCopy.hasState(StoredFileWorkingCopyState.CONFLICT); } return false; } </ins> revert(options?: IRevertOptions): Promise<void> { assertType(this.isResolved()); return this._workingCopy!.revert(options);

Discussion:
Set auto save: afterDelay Edit a notebook See the dirty indicator briefly appear after editing
I guess this is
We never did that for custom editors because it requires code to ensure that an editor that is closed but pending to be saved via auto save is really waited upon on shutdown. To further explain: the behaviour is driven by method if you return from that method no dirty indicator will show up this means a user can close an editor with dirty changes as such, components have to ensure that the save continues in the background and even on shutdown Files implement this here: I think the reason we never adopted this for notebooks as that notebooks have a dual model: complex and simple. With simple (which is based on file working copies), we can probably implement this now similar to what files do, but it needs careful testing what happens when you close a notebook quickly enough before auto save finished.
We could revisit this once we remove complex notebook model and friends but the saving of notebooks is more complex than files and I wonder if it's worth it to implement this. Also the dirty indicator is also an indicator that saving is not done yet, which is valuable as saving notebooks is not necessarily instant. what do you think ?
I think it's ok to close if this is complicated. It's also a bit odd that if I edit and immediately close the tab, it asks me whether I want to save, when I've enabled autosave.
with your recent changes in and please take note of Specifically: being able to close an editor that is now not dirty because of auto-save may result in data loss if closing the editor disposes state that is needed for saving. Filed as planned for July. Nevertheless, I appreciate that you are willing to look into this issue
Change:
import { resolveMarketplaceHeaders } from 'vs/platform/externalServices/common/marketplace'; import { IStorageService } from 'vs/platform/storage/common/storage'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <ins> import { StopWatch } from 'vs/base/common/stopwatch'; </ins> const CURRENT_TARGET_PLATFORM = isWeb ? TargetPlatform.WEB : getTargetPlatform(platform, arch); const ACTIVITY_HEADER_NAME = 'X-Market-Search-Activity-Id';

Discussion:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.
Change:
name: Object.hasOwn(open.apps, configuredBrowser) ? open.apps[(configuredBrowser as keyof typeof open['apps'])] : configuredBrowser } }); <ins> res.stderr?.on('data', (data: Buffer) => { this.logService.error(`Error openening external URL '${url}' using browser '${configuredBrowser}': ${data.toString()}`); }); </ins> } catch (error) { this.logService.error(`Unable to open external URL '${url}' using browser '${configuredBrowser}' due to ${error}.`); return shell.openExternal(url);

Discussion:
Testing Not sure if this is possible, but I set the to even though I don't have Firefox... then I tried to open something and nothing happened. I was confused because I thought I had Firefox installed, but I guess I remembered incorrectly! I think something like this is increasingly important in the workspace-setting level. Sure, the protection of this is behind Workspace Trust... but I don't seem to get any notification or indication that there's a setting applied that influences how VS Code opens the browser or if it's going to no-op. Considering this setting influences things like user auth flows, I think we should try to do something here. I was surprised that no browser was opened when I attempted to log in to a GitHub extension... which makes sense if this setting is set to something invalid.
I think this might be reported as and misses a fix or workaround. If someone has an idea, either by contributing to or seeing what we can do here:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
It appears that this is fixed by opening the default instead of what is configured. That makes sense to me.
Change:
} public showPreviousSearchTerm() { <del> let previous = this.searchHistory.previous(); </del> <ins> let previous; if (this.searchInput.getValue().length === 0) { previous = this.searchHistory.current(); } else { this.searchHistory.addIfNotPresent(this.searchInput.getValue()); previous = this.searchHistory.previous(); } </ins> if (previous) { this.searchInput.setValue(previous); }

Discussion:
Search for "foo" Search for "bar" Click the 'clear results' button Use alt+up to get the last history item It should be "bar", but it's "foo"
Change:
} } <ins> // Action bars const toolbarHoverBackgroundColor = theme.getColor(toolbarHoverBackground); if (toolbarHoverBackgroundColor) { collector.addRule(` .monaco-editor .find-widget .button:not(.disabled):hover, .monaco-editor .find-widget .codicon-find-selection:hover { background-color: ${toolbarHoverBackgroundColor} !important; } `); } </ins> // This rule is used to override the outline color for synthetic-focus find input. const focusOutline = theme.getColor(focusBorder); if (focusOutline) {

Discussion:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"
Change:
await this.commitWithAnyInput({ all: true, signoff: true }); } <ins> @command('git.commitAllAmend') async commitAllAmend(): Promise<void> { await this.commitWithAnyInput({ all: true, amend: true }); } </ins> @command('git.undoCommit') async undoCommit(): Promise<void> { const HEAD = this.model.HEAD;

Discussion:
Like: git commit --amend
Are you referring to the out of the box git behavior or any particular git extension?
I would guess the out of the box behaviour, because it seems to be missing? I can see there is an "undo last commit", but this unstages everything from the last commit, which is not the same thing as amending the current commit. git-gui and atom have a simple checkbox which then amends the current commit instead of creating a new one - would it be possible to have the same in vscode? It's the one thing that stops me using vscode's built in git interface. In other words, you should be able to check and then uncheck the checkbox and be left in the original state. With the "undo last commit", this isn't possible.
Yes, out of the box
command was some time ago by
Should there be something in the menu? Please can you tell me where the option is?
Hmmm.... looks like it has disappeared for some reason, probably was omitted when git integration was ported to new API... will probably know if it was by-design, or just someone missed one command while porting git integration.
I believe we simply missed it... sorry for that.
I'll add it again.
Change:
"title": "%cleanInvalidImageAttachment.title%" }, { <del> "command": "notebook.cellOutput.copyToClipboard", "title": "%copyOutputToClipboard.title%" </del> <ins> "command": "notebook.cellOutput.copy", "title": "%copyCellOutput.title%" </ins> } ], "notebooks": [

Discussion:
It should be just "Copy Output", the "to Clipboard" is obvious? This then aligns with other copy actions across the product Testing
Change:
this._renderOverviewViewport(); })); <del> this._register(DOM.addStandardDisposableListener(this._overviewViewportDomElement.domNode, DOM.EventType.POINTER_DOWN, (e) => { </del> <ins> this._register(DOM.addStandardDisposableListener(container, DOM.EventType.POINTER_DOWN, (e) => { </ins> this.notebookEditor.delegateVerticalScrollbarPointerDown(e); })); }

Discussion:
Testing Open a notebook diff. Clicking on the left side of the scroll bar nicely navigates the editor viewport to the right location. Clicking on the middle and right part of the scroll bar does nothing Compare this with the Editor Diff where a click in any area navigates.
Hmm verifying as I no longer see the right hand side of the scrollbar. Which I guess is fine.
Change:
/* Window Title Menu */ .monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center { z-index: 2500; <del> } /* MacOS Desktop supports click event despite `drag` and therefore we don't need to clear it */ .monaco-workbench:not(.mac) .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center, .monaco-workbench.mac.web .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center { </del> -webkit-app-region: no-drag; }

Discussion:
Insiders 1.82.0 Looks like the command center and associated toolbar buttons aren't functioning when clicked. Weirdly it seems like I can sometimes(?) get a hover state but it doesn't always work. Repeated clicks minimizes the window which makes me think the events are going straight to the titlebar and being handled as such.
I can reproduce
Maybe an Electron 25 update regression with draggable regions and custom title bar? //cc
looks like behavior on macOS is now aligned with windows and linux, the region no longer emits events. Behavior changed with this commit and verified with the following fiddle Looks like we would need to revert this change to align with Windows and Linux.
Yeah, looks like drag and click isn't working for macOS anymore. It always seems like an oversight/bug but a wanted one. To enable clicking again I have the for the CC even for mac. On the downside it means that the window cannot be repositioned from the CC anymore
Slack is the same, you cannot drag from their command center either.
Change:
"welcome.publishFolder": { "message": "You can also directly publish this folder to a GitHub repository. Once published, you'll have access to source control features powered by git and GitHub.n[$(github) Publish to GitHub](command:github.publish)", "comment": [ <ins> "{Locked='$(github)'}", "Do not translate '$(github)'. It will be rendered as an icon", </ins> "{Locked='](command:github.publish'}", "Do not translate the 'command:*' part inside of the '(..)'. It is an internal command syntax for VS Code", "Please make sure there is no space between the right bracket and left parenthesis:  ]( this is an internal syntax for links"

Discussion:
Testing With the pseudolanguage pack, on an open folder with no initialized repository, the links in the SCM viewlet do not render properly: !
this is what I see in today's Insiders release (2022-07-06): <img width="411" alt="image" src="https://user-"Looks like the buttons appear correctly, though it looks like the icon in the "Publish to GitHub" button has been translated.
what would be the best way to indicate in a file that the icon should not be translated. I see that there is already a pattern to indicate that the should not be translated. Can we establish something similar for icons as well?
you can add more comments that lock the icons as well:
Change:
} private toNativeSaveDialogOptions(options: ISaveDialogOptions): Electron.SaveDialogOptions { <ins> options.defaultUri = options.defaultUri ? URI.file(options.defaultUri.path) : undefined; </ins> return { defaultPath: options.defaultUri && options.defaultUri.fsPath, buttonLabel: options.saveLabel,

Discussion:
vscode with no folder (purple status bar) untitled file, save as file how the simple dialog offers me the root path. This is wrong imho, you should offer the home directory, or at least something wich I choose the last time
Could we keep the Untitled URI scheme here? All file scheme URIs are absolute. Which means that the remote file picker would have to use a heuristic like checking for "Untitled-" in the path to tell that the user home should be used.
Feel free to change. is the expert on the untitled URIs...
the URI only seems to be used in combination of the dialog itself (both native and custom - ), so I think we can preserve the if you deal with the untitled case in both worlds.