jiebi/CodeConvo huggingface dataset:
Change:
} export interface IPartsSplash { <ins> zoomLevel: number | undefined; </ins> baseTheme: string; colorInfo: { background: string;

Discussion:
! cc
is this with latest from main, eg out of source? I believe there is no insiders with the larger titlebar (due to CC)
the activity bar also changes size... there must be more to it. I guess rapid render is getting wrong values. Do you use zoom?
Correct, this is main on OSS. Confirmed that I wasn't zoomed.
is there some conflict of zoom here? Even the watermark renders for a bit slightly enlarged before shrinking?
I can only reproduce with zoom enabled, e.g zoom in once or twice reload workbench rapid render but also water mark are wrongly sized during load
LGTM other than the window controls overlay (WCO), which is being tracked at
Change:
.monaco-workbench > .part.titlebar > .window-controls-container .window-icon.window-close:hover { background-color: white; <ins> } /* Menubar styles */ .monaco-workbench .menubar { display: flex; flex-shrink: 1; box-sizing: border-box; height: 30px; -webkit-app-region: no-drag; overflow: hidden; flex-wrap: wrap; } .monaco-workbench.fullscreen .menubar { margin: 0px; padding: 0px 5px; } .monaco-workbench .menubar > .menubar-menu-button { align-items: center; box-sizing: border-box; padding: 0px 8px; cursor: default; -webkit-app-region: no-drag; zoom: 1; white-space: nowrap; } .monaco-workbench .menubar .menubar-menu-items-holder { position: absolute; left: 0px; opacity: 1; z-index: 2000; } .monaco-workbench .menubar .menubar-menu-items-holder.monaco-menu-container { font-family: "Segoe WPC", "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", sans-serif, "Droid Sans Fallback"; outline: 0; border: none; } .monaco-workbench .menubar .menubar-menu-items-holder.monaco-menu-container :focus { outline: 0; } .hc-black .monaco-workbench .menubar .menubar-menu-items-holder.monaco-menu-container { border: 2px solid #6FC3DF; </ins> }  No newline at end of file

Discussion:
I like how menu and title part are now merged, but I feel it could merge even more to reflect the structure in the DOM: move all of into (rename to and merge the CSS into the existing one) rename to something like do not extend from in , since this is no longer a workbench managed part
Change:
setFocus(item: ITreeItem): void { if (this.tree) { <del> this.focus(); </del> <ins> this.focus(true, item); </ins> this.tree.setFocus([item]); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView. I'm using canSelectMany but this does not appear to make a difference one or more items in the view reveal with focus: true and select: false item will be expanded, but will not be scrolled to; instead one of the selected nodes is still shown. If no node is selected, the focused item is shown as expected. My use case is that I want to allow selecting multiple items in a tree, but the easiest way to navigate the tree is by clicking in a different view. When that happens, I call "reveal". I do not want to select as that would prevent multi-selection. So instead I chose "focus", which would be fine, except that if any selection exists in the tree, the tree will not scroll to the newly revealed node. Instead, it keeps one of the selected nodes visible (always the same one, not necessarily the closest one)
can you try out the latest insider build of VS Code: if the issue is fixed there, can you please respond with so we can mark this issue as verified to be fixed?

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
or maybe if you could provide steps. I tried to follow the original steps but I wasn't quite sure I understood.
/verified
Change:
'editor.inlineSuggest.showToolbar': { type: 'string', default: defaults.showToolbar, <del> enum: ['always', 'onHover'], </del> <ins> enum: ['always', 'onHover', 'never'], </ins> enumDescriptions: [ nls.localize('inlineSuggest.showToolbar.always', "Show the inline suggestion toolbar whenever an inline suggestion is shown."), nls.localize('inlineSuggest.showToolbar.onHover', "Show the inline suggestion toolbar when hovering over an inline suggestion."), <ins> nls.localize('inlineSuggest.showToolbar.never', "Never show the inline suggestion toolbar."), </ins> ], description: nls.localize('inlineSuggest.showToolbar', "Controls when to show the inline suggestion toolbar."), },

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src="" alt="drawing" width="600"/Currently, we can control when to show the inline suggestion toolbar by setting to "always" or "onHover", which are defined as follows: "always": show the inline suggestion toolbar whenever an inline suggestion is shown, and "onHover": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option "never" as follows "never": do not show the inline suggestion toolbar.
I think this should be very easy to implement. Up for a PR?
I would like to take this.
Any ideas why this setting isn't in the Settings JSON file? .
Thank you so much for accepting the request and for the contribution!
Change:
return isEqual(model.uri, userDataProfileService.currentProfile.keybindingsResource); } <del> registerEditorContribution(DefineKeybindingController.ID, DefineKeybindingController, EditorContributionInstantiation.AfterFirstRender); registerEditorCommand(new DefineKeybindingCommand()); </del> <ins> registerEditorContribution(DEFINE_KEYBINDING_EDITOR_CONTRIB_ID, DefineKeybindingEditorContribution, EditorContributionInstantiation.AfterFirstRender); </ins>

Discussion:
With there is a new -menu which a big blue buttons. This is used in the merge editor and to hint to open the merge editor. This new menu should be used for: [x] [ ] ~~ / [x] [ ]
Other potential adoptors [ ] [ ] [ ] [ ]
Digging into it, I don't think can be adopted for the diff editor, as the button should be for both editors, not only the right side ( is a , but is ).
Change:
test('Should find autolinks', async () => { const links = await getLinksForFile('pre <http://example.com> post'); <del> assert.strictEqual(links.length, 1); const link = links[0]; assertRangeEqual(link.range, new vscode.Range(0, 5, 0, 23)); </del> <ins> assertLinksEqual(links, [ new vscode.Range(0, 5, 0, 23) ]); </ins> }); test('Should not detect links inside html comment blocks', async () => {

Discussion:
Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.61.2 OS Version: macOS Big Sur Steps to Reproduce: a new markdown file. ! But according to it isn't necessary to escape spaces when the text is enclosed in :
Removing help wanted since this is a bit more complicated than anticipated
Thanks!
Change:
import * as assert from 'assert'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; <ins> import { match } from 'vs/base/common/glob'; </ins> function createContext(ctx: any) { return {

Discussion:
VSCode Version: 1.12.0 OS Version: MacOS Sierra 10.12.4 In , we'd like to be able to provide context menus for all gradle files. The current clause is limited to language types () or a single file name (). It would be helpful if there was support for glob pattern matching, as mentioned in
Hi, Any update on this?
I will push an additional change that expands this to support normal regular expressions instead of just glob-patterns. We figured that's more powerful and closer to ST
Will this be usable in matching any when clause value? Can you give an example?
You write , so will execute this . A sample from my dummy extensions (matches filenames ending in )
This is AWESOME! Should reduce the number of duplicate menu items I need to define
Slight update on this: The value must be enclosed in slashes, so . I have updated above sample
FYI: I tried to apply this feature to the "loaded script view" by following the entry in the release notes: ! But without much success. After looking into the test item and the corresponding feature item, I noticed that the latest syntax uses regular regexp syntax. I've taken the liberty to change the release notes to this: ! I did not attempt to clarify why actually matches "Docker files".
Hmm, I am writing a simple extension, and would like to copy any resourceName. It works without any when clause, but the menu item also shows up, when r-clicking inside the empty space. I would like to prevent it. Is there something like this ?
Ok I found . And its actually what I was looking for. But I did not found it in the docs, but code base.
Change:
this._register(this.viewDescriptorService.onDidChangeContainerLocation(({ viewContainer, from, to }) => this.onDidChangeViewContainerLocation(viewContainer, from, to))); // View Container Visibility Changes <del> this.paneCompositePart.onDidPaneCompositeOpen(e => this.onDidChangeViewContainerVisibility(e.getId(), true)); this.paneCompositePart.onDidPaneCompositeClose(e => this.onDidChangeViewContainerVisibility(e.getId(), false)); </del> <ins> this._register(this.paneCompositePart.onDidPaneCompositeOpen(e => this.onDidChangeViewContainerVisibility(e.getId(), true))); this._register(this.paneCompositePart.onDidPaneCompositeClose(e => this.onDidChangeViewContainerVisibility(e.getId(), false))); </ins> // Extension registration const disposables = this._register(new DisposableStore());

Discussion:
Explorer focused: ! It's only working for debug: !
It seems to working for me <img width="370" alt="image" src=""Do you have any special theme, or customisations or set up? Probably try trouble shooting?
Also the state can be frozen: ! ! Same thing in dark modern. No errors in console
Here's a repro that seems reliable: the side bar narrow enough to make some of your activity icons get displaced into the ... menu. an option from that menu. Its icon appears and get selected with the underline correct. drag that icon left to position it nearer the start of the set of tabs in order for it not to get displaced onto the ... menu again. It loses its underline and even when you switch to another icon and back to this one it doesn't get underlined.
To reset, move activity bar to side, then back to top again.
Thanks for repro steps
OFF TOPIC. May I ask how to move the activity bar from left to top? Tried searching for settings and Googling, but didn't get any results.
if you're on the Insiders build you can right click the activity bar to change the position
To verify: Move activity bar to top Reduce the width of sidebar so that activity bar actions are exactly fit Switch to Debug view container. All activity bar actions moved to overflow action From overflow action, select explorer Make sure explorer is shown active
Change:
// - ColEnd  = 789 // // These all support single quote ' in the place of " and [] in the place of () <ins> // // See the tests for an exhaustive list of all supported formats </ins> const lineAndColumnRegexClauses = [ // foo:339 // foo:339:12 // foo:339:12-789 <ins> // foo:339:12-341.789 </ins> // foo:339.12 // foo 339 // foo 339:12                              [#140780] // foo 339.12 <ins> // foo#339 // foo#339:12                              [#190288] // foo#339.12 </ins> // "foo",339 // "foo",339:12 // "foo",339.12 // "foo",339.12-789 // "foo",339.12-341.789 <del> `(?::| |['"],)${r()}([:.]${c()}(?:-(?:${re()}.)?${ce()})?)?` + eolSuffix, </del> <ins> `(?::|#| |['"],)${r()}([:.]${c()}(?:-(?:${re()}.)?${ce()})?)?` + eolSuffix, </ins> // The quotes below are optional           [#171652] // "foo", line 339                         [#40468] // "foo", line 339, col 12

Discussion:
In terminal, ctrl+click at , will open the file without problems, but using an anchor , gives the following error: !
This is actually a request for to indicate line number which we haven't had requested before. Right now it's considered to be part of the file name.
Change:
this._register(this.model.onDidChange(() => { this.updateContextKeys(); })); <del> this._register(this.editor.onDidChangeModelContent(() => { this.contextKeys.inlineSuggestionJustCommitted.reset(); })); this._register(this.editor.onDidChangeCursorPosition(() => { this.contextKeys.inlineSuggestionJustCommitted.reset(); })); </del> this.updateContextKeys(); }

Discussion:
(See attached recording) I have enclose it in new use cmd+left to go to start of line ghost suggestions get accepted https://user-
Change:
} return out; } <del> } </del> <ins> } </ins>  No newline at end of file

Discussion:
Steps to Reproduce: the markdown: Bug Only is detected as a clickable link.
Hey can I try working on this one?
Sure, here's the relevant regular expression that matches links: And the related tests: You can run the tests by opening VS Code and selecting the from the debug target menu. The regexp is rather complex so let me know if you have any questions
Could you please tell me what is the expected behaviour?
In the example, it should underline and as clickable links that open files and
Change:
} if (this.issueReporterWindow) { <ins> const getModelData = await this.getIssueData(); if (getModelData) { const { issueTitle, issueBody } = getModelData; if (issueTitle || issueBody) { data.issueTitle = data.issueTitle ?? issueTitle; data.issueBody = data.issueBody ?? issueBody; // close issue reporter and re-open with new data this.issueReporterWindow.close(); this.openAuxIssueReporter(data); return; } } </ins> this.issueReporterWindow.focus(); return; } <ins> this.openAuxIssueReporter(data); } async openAuxIssueReporter(data: IssueReporterData): Promise<void> { </ins> const disposables = new DisposableStore(); // Auxiliary Window

Discussion:
Testing to open the issue reporter for an extension issue reporter open, return to the main window step 1 for another extension =issue reporter opens but doesn't update the issue reporter input fields.
Change:
contents = 'contents', when = 'when', group = 'group', <ins> enablement = 'enablement', </ins> } export interface ViewWelcome {

Discussion:
Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual "NO FOLDER OPEN" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.
Similarly on the Source Control view, it starts with a message saying "No source control providers registered" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like "Please wait while we look for source control providers". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display "No source control providers registered".
This will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.
On this, we could potentially add a message.
That might help.
Closing this until we get actual user feedback that it's needed, sorry
Change:
export const GitSimilarOutputRegex = /most similar command iss+([^s]{3,})/; export const FreePortOutputRegex = /address already in use d.d.d.d:(dddd)|Unable to bind [^ ]*:(d+)|can't listen on port (d+)|listen EADDRINUSE [^ ]*:(d+)/; export const GitPushOutputRegex = /git push --set-upstream origin ([^s]+)/; <del> export const GitCreatePrOutputRegex = /Create a pull request for '([^s]+)' on GitHub by visiting:s+remote:s+(https:.+pull.+)/; </del> <ins> export const GitCreatePrOutputRegex = /Create a pull request for '([^s]+)' on GitHub by visiting:s*remote:s*(https:.+pull.+)/; </ins> export function gitSimilarCommand(): ITerminalQuickFixOptions { return {

Discussion:
Testing Reading the testplan item I got the impression that is a built in command to be recognised by quick fix. It does not get recognised for me. Did I misunderstand this? !
Sorry for the unclear directions. You should see the git create pr action when you run from a branch that has an upstream remote for the first time. So, for example: git checkout -b merogge/test git push quick fix should appear to push to upstream remote take that suggestion quick fix should appear to create pr
Thanks for clarifying. I just followed the steps you suggested and there is no quick fix to create a PR !
yeah can repro, looks like a regression
This flow is pretty sweet
Change:
const OpenInEditorCommandId = 'search.action.openInEditor'; const OpenNewEditorToSideCommandId = 'search.action.openNewEditorToSide'; const FocusQueryEditorWidgetCommandId = 'search.action.focusQueryEditorWidget'; <ins> const FocusQueryEditorFilesToIncludeCommandId = 'search.action.focusFilesToInclude'; const FocusQueryEditorFilesToExcludeCommandId = 'search.action.focusFilesToExclude'; </ins> const ToggleSearchEditorCaseSensitiveCommandId = 'toggleSearchEditorCaseSensitive'; const ToggleSearchEditorWholeWordCommandId = 'toggleSearchEditorWholeWord';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In the search editor, there is to focus on the query. I'd like to be able to set a keyboard shortcut to focus on "files to include" and "files to exclude". I'd be willing to add this. It doesn't seem too difficult.
Change:
.pipe(replace('@@NAME_LONG@@', product.nameLong)) .pipe(replace('@@NAME@@', product.applicationName)) .pipe(replace('@@LICENSE@@', product.licenseName)) <del> .pipe(rename('usr/share/appdata/' + product.applicationName + '.appdata.xml')); </del> <ins> .pipe(rename('BUILD/usr/share/appdata/' + product.applicationName + '.appdata.xml')); </ins> const workspaceMime = gulp.src('resources/linux/code-workspace.xml', { base: '.' }) .pipe(replace('@@NAME_LONG@@', product.nameLong))

Discussion:
Neither the vscode repository nor the package itself provide any appdata, which is important to have gnome-software working properly. The vscode repository should generate appstream data (xml) and provide them. So the PackageKit can save it into /var/cache/app-info/xmls/. The itself also should install a into /usr/share/metainfo/. Look here:
I believe we include in the root of the package, is that not the case?
Unfortunately, it is not the case. There's no or file. Output from : The preferred place for that appdata file is Then the repository creation should also include generating AppStream repository metadata. The mechanics of doing this is documented here: (Ignore the argument, that should not be used)
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This should be reopened, because it's still broken.
Confirmed that the deb package is good but that the rpm package has this issue.
I have about 200 messages coming a day I don't know what happened how do I unsubscribe from this Microsoft thing vs code please advise
see
Verification steps: the on a Linux distribution with rpm (the link downloads an x64 .rpm file) in a terminal that shows up.