jiebi/CodeConvo huggingface dataset:
Change:
* The code in this file is generated from files in ./src/ */ <ins> // ESM-uncomment-begin // let __marked_exports = {}; // (function() { //   function define(deps, factory) { //     factory(__marked_exports); //   } //   define.amd = true; // ESM-uncomment-end </ins> (function (global, factory) { <ins> typeof define === 'function' && define.amd ? define(['exports'], factory) : </ins> typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) : <del> typeof define === 'function' && define.amd ? define(['exports'], factory) : (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.marked = {})); })(this, (function (exports) { </del> <ins> (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.marked = {})); })(this, (function (exports) { </ins> 'use strict'; /**

Discussion:
We lost changes that where ESM relevant. I am trying to fix it in our ESM branch, maybe backport it from there: The old code also had this line, which I am not sure is needed: cc
Sorry about that. Is this for Monaco or the esm work? I'd love to get a point where we can just have this as a normal dependency instead of copying it into our sources. Marked now publishes both a commonjs and esm builds too. Is there some way VS Code could use Marked as a normal dependency in a way that would also work for Monaco? If I recall we've tried to avoid adding real dependencies to Monaco
I only noticed for our work, not sure about Monaco ESM. Would be great to get it working again on .
I think the ESM work will unblock this. esbuild will be able to bring in and include node modules into our bundle, the AMD bundler we currently use can only bundle AMD modules and not commonjs modules.
I would have hoped that the Monaco Editor checks would have caught this. Is there something we should improve there?
For monaco-editor-core, these are the only tests: It does not test markdown features.
Change:
}; const disposableStore = new DisposableStore(); disposableStore.add(this._editorWidget.onKeyDown((e) => { <del> if (e.keyCode === KeyCode.Escape || shouldHide(e.browserEvent, this._keybindingService, this._configurationService)) { </del> <ins> if (e.keyCode === KeyCode.Enter) { this._commandService.executeCommand('editor.action.openLink'); } else if (e.keyCode === KeyCode.Escape || shouldHide(e.browserEvent, this._keybindingService, this._configurationService)) { </ins> hide(e); } else if (e.keyCode === KeyCode.KeyH && provider.options.readMoreUrl) { const url: string = provider.options.readMoreUrl;

Discussion:
!
In the chat view responses, users can hit on the link, so we will do the same here.
to verify: run an command that produces file links open the accessible view by focusing that chat response and using move your cursor to the link and press the file should be opened
Change:
const model = this.editor.getModel(); const inlineValuesSetting = this.configurationService.getValue<IDebugConfiguration>('debug').inlineValues; <del> const inlineValuesTurnedOn = inlineValuesSetting === true || (inlineValuesSetting === 'auto' && model && this.languageFeaturesService.inlineValuesProvider.has(model)); </del> <ins> const inlineValuesTurnedOn = inlineValuesSetting === true || inlineValuesSetting === 'on' || (inlineValuesSetting === 'auto' && model && this.languageFeaturesService.inlineValuesProvider.has(model)); </ins> if (!inlineValuesTurnedOn || !model || !stackFrame || model.uri.toString() !== stackFrame.source.uri.toString()) { if (!this.removeInlineValuesScheduler.isScheduled()) { this.removeInlineValuesScheduler.schedule();

Discussion:
Today the "Debug: Inline Values" setting uses low-level "true" and "false" values (in addition to the more high-level "auto"): <img width="352" alt="CleanShot 2022-02-21 at 14 31 00 src="https://user-"I suggest to support (and surface in the UI) "on" and "off" values and only keep the booleans for backward compatibility.
Hi! Can I work on this issue?
I think this is a "good first issue", do you agree?
Yes, I would take a PR for this. Make sure that it's backwards compatible so that if a user has true or false set, those still work as they did before.
Change:
const workbenchRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench); workbenchRegistry.registerWorkbenchContribution(ExtensionsContributions, LifecyclePhase.Restored); <del> workbenchRegistry.registerWorkbenchContribution(StatusUpdater, LifecyclePhase.Restored); </del> <ins> workbenchRegistry.registerWorkbenchContribution(StatusUpdater, LifecyclePhase.Eventually); </ins> workbenchRegistry.registerWorkbenchContribution(MaliciousExtensionChecker, LifecyclePhase.Eventually); workbenchRegistry.registerWorkbenchContribution(KeymapExtensions, LifecyclePhase.Restored); workbenchRegistry.registerWorkbenchContribution(ExtensionsViewletViewsContribution, LifecyclePhase.Restored);

Discussion:
re The automatic perf monitoring has shown a high number of calls to . This means the call/function itself is slow or it is called at a very high rate (so that the profiler always sees it running) The most common stacktrace via which this is reported comes through .
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I don't think this is a dupe because the callstack comes in via which I don't see in the other trace
But I think the root cause is same for both that is slow as mentioned in the summary of the other issue. Hence I marked it as duplicate.
Pfff - that would mean it is catastrophically slow. My suspicion is that it is just slow but that comes in combination with being over eagerly called? Maybe some event leakage or some over eager calling through some other means. This symptom might disappear when has become fast but I think we need to understand why it ends up on a hot code path in the first place
Will investigate why this is being eagerly called too.
Change:
when: HasSpeechProvider.negate(), group: 'navigation', order: -1 <del> }, { id: TerminalChatExecute, when: HasSpeechProvider.negate(), group: 'navigation', order: -1 </del> }] }); }

Discussion:
terminal I -notice double microphone icons I do not have the voice extension installed. ! fyi
Caused by:
looks the most relevant
Why does the terminal have its own execute menu?
Is it possible to clean up the parallel execute menu and submit actions? I'm unclear whether I can just move the voice actions to or you need a new parallel menu for terminal customizations.
I did the first one, seems to work, but please clean up the terminal-specific stuff if possible
Can you be more specific?
so I do have a lot of special code for terminal in using stuff like , which maybe now is obsolete? Did something change to consolidate inline chat in terminal?
This isn't actionable without more info. Terminal chat still has a separate widget implementation, it extends inline chat and shares a lot of code, but must be separate as it's not a monaco content widget for example.
Yeah I did a quick attempt to remove my terminal specific code but restored it, as it still seemed to be needed.
That was directed at the terminal widget stuff- it has its own execute menu and execute action, and I only looked briefly but it seemed like it was doing the same thing as the base chat submit action. TerminalChatWidget uses InlineChatWidget which uses the normal ChatWidget, I'd expect that the execute toolbar can be the same regardless of whether it shows up in an editor or a terminal.
did all that stuff so she might be able to comment better than me.
When I last investigated this, , the chat widget's submit action was dependent on an editor, which we don't have in terminal chat, and was defined in a place where the was not accessible. I can look into doing this now though as it seems the code has changed since then.
Change:
} } <ins> private updateExtensionsPinnedState(pinned: boolean): Promise<void> { return this.progressService.withProgress({ location: ProgressLocation.Extensions, title: nls.localize('updatingExtensions', "Updating Extensions Auto Update State"), }, () => this.extensionManagementService.resetPinnedStateForAllUserExtensions(pinned)); } </ins> private reset(): void { for (const task of this.tasksInProgress) { task.cancel();

Discussion:
Testing Disable Auto Update for All Extensions. Enable Auto Update for All Extensions. Search for an installed extension. Auto Update is not checked. When I clear the search box, sometimes the checkboxes are then checked. Again searching for an installed extension shows the boxes unchecked.
Do you mean the checkbox is not checked when you search for an installed extension? Otherwise it is checked?
Yes.
Actually now I just reproduced it without searching. This is after enabling auto update for all: <img width="1272" alt="image" src=""
updated after a while! I also noticed that when I clear the search box it takes a very long time for the Extensions panel to show the installed extensions when I just enabled or disabled auto update for all extensions. There seems to be a performance issue.
Thats right, this action updates all extensions to disable auto update. This is any async operation. I would probably show a progress to indicate that operation is running.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
cellExecuteToolbar: MenuId.InteractiveCellExecute, cellExecutePrimary: undefined }, <del> cellEditorContributions: [], </del> <ins> cellEditorContributions: EditorExtensionsRegistry.getSomeEditorContributions([ SelectionClipboardContributionID, ContextMenuController.ID, ModesHoverController.ID, MarkerController.ID ]), </ins> options: this.#notebookOptions });

Discussion:
Issue Type: <bBug</bpython file with # %% comments a cell over something like 'print' in the interactive window Expected: Hover window shows up Actual: No hover messages are sent to the LS. I suspect hovering over the IW notebook just isn't hooked up. VS Code version: Code - Insiders 1.63.0-insider (, 2021-11-09T15:23:39.737Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-eslint2.2.2 prettier-vscode9.0.0 remotehub0.18.0 better-cpp-syntax1.15.10 vscode-position1.0.3 regexp-preview0.1.5 python2021.12.-dev vscode-pylance9999.0.0-dev jupyter2021.10. jupyter-keymap1.0.0 jupyter-renderers1.0.3 remote-containers0.205.1 remote-ssh0.66.0 remote-ssh-edit0.66.0 remote-ssh-edit-nightly2021.11.3789 remote-ssh-nightly2021.11.3793 remote-wsl0.58.5 vscode-remote-extensionpack0.21.0 cpptools1.7.1 cpptools-extension-pack1.0.0 live-server0.2.9 vscode-github-issue-notebooks0.0.112 vscode-selfhost-test-provider0.3.8 vscode-typescript-next4.6. rpa-eslint-snippets0.0.2 rest-book4.2.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This used to work in the webview implementation
This might be because the uri is not what we expect? Meaning the language service registered for a document filter doesn't match.
/verified. Although not sure if I should be verifying as I submitted the fix
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "4.20.0-beta.13", "xterm-addon-search": "0.10.0-beta.2", </del> <ins> "xterm": "4.20.0-beta.20", "xterm-addon-search": "0.10.0-beta.3", </ins> "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.13.0-beta.7" </del> <ins> "xterm-addon-webgl": "0.13.0-beta.9" </ins> } }

Discussion:
Follow up on Thanks for the fix, but I can still reproduce the issue in the insiders build I just downloaded: ! I've opened lots of terminals which I have now closed again (only welcome screen opened now). If vscode is visible in the background: ! If vscode is either minimized or completely behind other windows: !
I feel like this is just Chromium perhaps batching the webgl calls or something, the GPU memory according to devtools jumps around a bit but always ends around the same value even after creating many terminals: ! The terminal is unique in VS Code wrt GPU as it's currently the only part that uses webgl, so that explains why GPU memory is affected primarily by the terminal and no other component. I'm not sure there is anything we can do here since we are now disposing of all the webgl objects that need to be manually freed in
This is very interesting, I get the same results as you with the frame rate performance overlay, one more clue I found but I guess that doesn't help too much is that this also is reflected in the gpu process memory usage. This is when many terminals has been opened and closed again: ! Same instance minimized: ! I can make GPU process usage go beyond 4GB without any sign of stopping by just opening ~10 tabs, closing them again and doing it over again many times, so I guess it's something more than just Chrome doing batching or keeping memory for performance reasons etc.
One more clue, after opening and closing terminals again (now with no terminals open) I take a javascript heap profile in devtools (after pressing "Collect garbage" a few times), top usage is from many instances of arrays in belonging to ! Number and size of these seems to scale well with how many terminals that have been opened historically, so I think each instance of still leave resources behind.
With ram, terminals take a fairly constant amount as it's pee allocated when you create the terminal. This is based on your scrollback setting so if you have that as a large number your memory usage per terminal will go up, even when the scrollback isn't full.
Change:
if (this.globalActivityActionBar) { availableHeight -= (this.globalActivityActionBar.viewItems.length * ActivitybarPart.ACTION_HEIGHT); // adjust height for global actions showing } <ins> if (this.menubar) { availableHeight -= this.menubar.clientHeight; } </ins> this.compositeBar.layout(new Dimension(width, availableHeight)); }

Discussion:
Steps to Reproduce: web in Safari on compact menu = it moves !
I diagnosed this and see 2 issues: the menu items are not removed from the DOM when menu is not showing () you seem to be using instead of to hide the menu items, is there any particular reason? using the issue is not as bad anymore (I only see one initial jump) I suggest we use / (our helper), but I am not sure if you rely on the behavior of visibility?
I mentioned the reasoning in the linked issue, but in the compact case we can remove them from the DOM safely so patching that should help here.
Change:
} else { this._logger.info(message); } <del> const m = message.match(/^s*Open this link in your browser (https://([^/]+)/([^/]+)/([^/]+))/); </del> <ins> const m = message.match(/^s*Open this link in your browser (https://([^/s]+)/([^/s]+)/([^/s]+))/); </ins> if (m) { const info: ConnectionInfo = { link: m[1], domain: m[2], extensionId: 'ms-vscode.remote-server', hostName: m[4] }; this.setTunnelStatus(TunnelStates.connected(info));

Discussion:
Testing Pasting it as text does that.
Same cause as . The parsed hostname also included a
Marking as dup

Testing <img width="445" alt="Screenshot showing notification that the tunnel is ready, but the link to access the tunnel from doesn't render properly due to an extra space in the link." src="https://user-"

Testing using latest Insiders click Turn on Remote Tunnel Access log in using the GitHub flow Unable to turn on remote tunnel
Can you specify a different machine name with the setting ?
:+1: Using worked for me
I'm unable to verify the issue right now because my Ubuntu VM broke. is the issue resolved for you without having to set the setting?
I confirm, the issue is fixed for me
Change:
protected renderExpression(expression: IExpression, data: IExpressionTemplateData, highlights: IHighlight[]): void { renderVariable(expression as Variable, data, true, highlights, this.linkDetector); <ins> data.expression.classList.toggle('nested-variable', isNestedVariable(expression)); </ins> } protected getInputBoxOptions(expression: IExpression): IInputBoxOptions | undefined {

Discussion:
The new lazy variable evaluation button line-height or dimensions appear to be too large. The button creates frequent gaps in-between node items and creates unsightly misalignment. This is not a settings font issue because the issue appeared with the change to the lazy evaluation button in version 1.67.1. This new button does not improve JavaScript debugging. The ellipsis button did not do this. Version: 1.67.1 (user setup) Commit: Date: 2022-05-06T12:37:03.389Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: JavaScript object to console window the gaps between expandable nodes any collapsed variable to evaluate. The item will jump and become misaligned. !
Hey is there a reason that the variables view tree is 22px tall while the hover variables rows are 18px tall? I just noticed this.
I think the idea is to make the debugHover tree smaller, while the other trees in views should be larger. The problem here seems to be that the debugHover reuses the and by that the height of the hover items is 22. So the height should be configurable, and debugHover should be able to say to the variableDelagate that the height is 18 in this case.
The variables tree in the debug hover is correctly sized. It's just a CSS issue on that one button. I guess it's intentional, and that's fine, so I'll just fix the css.
okey. Thanks for fixing
This broke the alignment of the lazy button in the debug console because the text wraps there
Change:
commandStartMarker?: IMarker; commandStartX?: number; <ins> commandRightPromptStartX?: number; commandRightPromptEndX?: number; </ins> commandLines?: IMarker; commandExecutedMarker?: IMarker;

Discussion:
Setup a right prompt in fish/zsh and make sure the command detected is accurate.
zsh uses for this, perhaps we should have a generic ignored ranges mechanism and combine this with the line continuation solution?
Change:
name: 'msCompile', label: localize('msCompile', 'Microsoft compiler problems'), owner: 'msCompile', <ins> source: 'cpp', </ins> applyTo: ApplyToKind.allDocuments, fileLocation: FileLocationKind.Absolute, pattern: ProblemPatternRegistry.get('msCompile')

Discussion:
Type: <bBug</bIncluding a non-existent file in C++ causes an error that does not get matched. The problem is that the regex will match "error" but not "fatal error" (or "fatal error" with 2 spaces in the case of invoking msbuild instead of cl). VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-24T05:23:09.316Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I have a PR available for this:
I don't get a useful message about the problem in the problems view: <img width="317" alt="image" src=""Test task (for Windows at least):
I took a look at the PR for this to see if the problem matcher ever includes a message, and it does. The PR adds an optional group but doesn't increment the group numbers that each part of the problem is set as. I'm not sure how this would work for an optional group.
Please feel free to mark as verified if this is good enough.
pretty sure you found a bug. changing to will exclude the group from the result and not mess with the group indexes.
I do get a useful message now: <img width="1413" alt="image" src=""However when running Alex's provided task for the first time, I was prompted about which problem matcher I wanted to run on the output, and I don't think I should have to specify that again if my task already included a specific problem matcher
Change:
vscode.languages.registerWorkspaceSymbolProvider(new MdWorkspaceSymbolProvider(symbolProvider, workspaceContents)), vscode.languages.registerReferenceProvider(selector, referencesProvider), vscode.languages.registerRenameProvider(selector, new MdRenameProvider(referencesProvider, workspaceContents, githubSlugifier)), <ins> vscode.languages.registerDefinitionProvider(selector, new MdDefinitionProvider(referencesProvider)), </ins> MdPathCompletionProvider.register(selector, engine, linkProvider), registerDropIntoEditor(selector), registerFindFileReferences(commandManager, referencesProvider),

Discussion:
Enable triggering go to definition on a markdown reference link to jump to the link definition Go to def should jump to the definition at the end of the file
Related
Created a PR fixing this
Works well, I was a bit confused to see this tooltip with 'Execute command' though, is there a way to make that more context-specific? !
Change:
.monaco-hover hr { margin-top: 4px; <del> margin-bottom: -6px; </del> <ins> margin-bottom: -4px; </ins> margin-left: -10px; margin-right: -10px; height: 1px; } .monaco-hover p:first-child, <ins> .monaco-hover .code:first-child, </ins> .monaco-hover ul:first-child { margin-top: 0; } .monaco-hover p:last-child, <ins> .monaco-hover .code:last-child, </ins> .monaco-hover ul:last-child { margin-bottom: 0; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.1 commit OS Version: macOS 10.15 Sorry in advance if this is the wrong place for the issue, I'm not sure if this belongs in one of the LSP client library packages. Either way hover boxes, from LSP plugins, seem to render horizontal rules () a bit off: <img width="652" alt="image" src="https://user-"The horizontal rule is slightly cutting through the line beginning with "throw" Steps to Reproduce: a language server that produces a horizontal rule ( uses this) a hover? <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No I'm not sure how to reproduce this without using a language server extension!
the easiest would be if you start with this at the Haskell language server repository. What I would need is the generated markdown of the hover to investigate. You can link to this issue so that the Haskell devs can provide it.
Here's some markdown string we are sending via the hover request haskelln :: SessionException -IO ByteStringnhaskelln :: forall a e. Exception e =e -anhaskellnthrow :: forall a e. Exception e =e -an It looks like there is a blank line between the horizontal rule and where the third markdown block begins
Got a more minimal example <img width="104" alt="image" src="https://user-"from the markdown: haskellnLine 3n
Thanks for the fix!
can you mark the bug as verified since you reviewed and tested the PR.