jiebi/CodeConvo huggingface dataset:
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .monaco-workbench .part.panel > .content .pane-body.output-view .monaco-editor, .monaco-workbench .part.panel > .content .pane-body.output-view .monaco-editor .margin, .monaco-workbench .part.panel > .content .pane-body.output-view .monaco-editor .monaco-editor-background { background-color: var(--vscode-outputEditor-background); } .monaco-workbench .part.panel > .content .pane-body.output-view .sticky-widget { background-color: var(--vscode-outputEditorStickyScroll-background, var(--vscode-panel-background)); } </ins>

Discussion:
Repro: Use a theme that has the editor as a different color to the panel Print a json object to an output channel !
Hi thank you for posting this issue. It is a bit unclear from the screen-shot what the expected output should be. Are you referring to what looks like the terminal sticky scroll?
that's output (monaco) sticky scroll, not terminal. The bottom has a dark sticky scroll color and looks odd when the panel background is different to the editor.
I see better now thanks. I'll look into setting a different background color depending on if the editor is a simple one or inside of the output view.
I am investigating how to detect if a specific editor is the editor in the output view. I was initially considering looking at the classList to find if or is there, but the editor dom node class list appears to be undefined for the output view. I was wondering if there is perhaps another way to detect this?
I am not aware of a method to get the editor of the output view, but it should be easy to add: Is that what you need?
Ah maybe I can directly access the editor of the output view pane and verify that the current editor is equal to this editor maybe?
But you are inside an editor contribution or? Not sure how that would work given layering violations.
Yes that's right the change would be inside of the file which is a contribution. I'll think more about how to detect the type of the current editor
Not sure if it helps, but we can control the options we pass in to the editor for output and do so here:
It's a bit of a tricky problem if you want this to work well across all themes. You probably need to support null or transparent values for the bg and hover bg keys and then resolve the colors manually into opaque colors by combining them with the bg color underneath. This might be the right internal API to do that?
I was investigating the uri of the output editor, and noticed it has a scheme equal to 'output'. I can just use it in order to detect if the current editor is an output view editor and change the background accordingly.
Change:
this.focusSearch(); } <del> if (options.query) { this.searchWidget.setValue(options.query); </del> <ins> const recoveredViewState = options.viewState ? options.viewState as ISettingsEditorViewState : undefined; const query: string | undefined = recoveredViewState?.query ?? options.query; if (query !== undefined) { this.searchWidget.setValue(query); this.viewState.query = query; </ins> } <del> const target: SettingsTarget = options.folderUri || <SettingsTarget>options.target; </del> <ins> const target: SettingsTarget | undefined = options.folderUri ?? recoveredViewState?.settingsTarget ?? <SettingsTarget | undefined>options.target; </ins> if (target) { this.settingsTargetsWidget.settingsTarget = target; this.viewState.settingsTarget = target;

Discussion:
Issue Type: <bBug</bthe settings UI. for a setting (e.g. "inlay"). the settings tab to a new editor group. Note that the search you entered previously has been cleared. https://user- VS Code version: Code 1.60.0 (, 2021-09-01T10:54:53.442Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 vscode-nginx-conf0.1.3 reorder-lines-by-length1.0.2 docs-view0.0.9 pgformatter1.17.0 vscode-eslint2.1.25 gitlens11.6.0 vscode-diff1.4.2 shell-format7.1.0 go0.27.2 postgresql0.0.2 rainbow-csv1.9.1 render-crlf1.5.21 template-string-converter0.5.3 python2021.9. vscode-pylance2021.9.2 jupyter2021.8. jupyter-keymap1.0.0 debugger-for-chrome4.13.0 nbsp-vscode0.0.1 vscode-commons0.0.6 vscode-yaml0.22.0 final-newline0.3.2 vscode-hexdump1.8.1 change-case1.0.0 markdown-all-in-one3.4.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
A function called in is being called after the drop, which is correct. But, the function in the same file name isn't being called when the user does step 3 above. Another repro is to use the "move editor to X group" commands. Therefore, the fix doesn't have to do directly with dnd.
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; import * as platform from 'vs/base/common/platform'; suite('Keytar', () => { test('loads and is functional', function (done) { if (platform.isLinux) { // Skip test due to set up issue with Travis. this.skip(); return; } (async () => { const keytar = await import('keytar'); const name = `VSCode Test ${Math.floor(Math.random() * 1e9)}`; try { await keytar.setPassword(name, 'foo', 'bar'); assert.equal(await keytar.getPassword(name, 'foo'), 'bar'); await keytar.deletePassword(name, 'foo'); assert.equal(await keytar.getPassword(name, 'foo'), undefined); } catch (err) { // try to clean up try { await keytar.deletePassword(name, 'foo'); } finally { // tslint:disable-next-line: no-unsafe-finally throw err; } } })().then(done, done); }); }); </del>  No newline at end of file

Discussion:
What is the purpose of in vs/platform? should only be used for shared services across processes. Please move it elsewhere, e.g. .
Change:
const options: IDropdownMenuOptions = { contextMenuProvider: this.contextMenuProvider, <del> labelRenderer: labelRenderer </del> <ins> labelRenderer: labelRenderer, menuAsChild: this.menuAsChild </ins> }; // Render the DropdownMenu around a simple action to toggle it

Discussion:
!
Reproduces in an insiders build from 3 days ago. Maybe related to context view changes?
closedWith
Change:
} } <del> async runTask(root: IWorkspace | IWorkspaceFolder | undefined, taskId: string | ITaskIdentifier | undefined): Promise<ITaskSummary | null> { </del> <ins> async runTask(root: IWorkspace | IWorkspaceFolder | undefined, taskId: string | ITaskIdentifier | undefined, token = this.globalCancellation.token): Promise<IRunnerTaskSummary | null> { </ins> if (!taskId) { return Promise.resolve(null); }

Discussion:
Clone and npm install. Hit F5, it never starts: <img width="484" alt="image" src=""I am on macOS.
This is probably because a prelaunch task is still running / your problem matchers haven't matched anything. Please make sure you have the right problem matchers installed, otherwise I suggest opening issues for them if they don't match correctly.
Would be great if debug could give me a hint.
Will keep open to track it, it's not a rare problem
We should also keep the terminal open if the task fails, currently it closes immediately which can be confusing
Would also be nice if we could cancel the pending launch attempt, e.g. by showing the debug toolbar immediately and disabling all buttons except the stop button. Right now when I get into this state I end up just reloading the whole window and incurring the pain of all extensions reactivating, which takes several seconds on my machine (git, TS etc)
After 10 seconds we'll show !
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
import { IIgnoredExtensionsManagementService } from 'vs/platform/userDataSync/common/ignoredExtensions'; import { IUserDataAutoSyncService } from 'vs/platform/userDataSync/common/userDataSync'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <ins> import { isBoolean } from 'vs/base/common/types'; </ins> interface IExtensionStateProvider<T> { (extension: Extension): T;

Discussion:
Today I noticed that VSCode updates and installs extensions even if they are disabled. In fact, I was reminded of a couple of extensions I no longer use by the hundreds of megabytes downloaded in the background. Could you consider adding this as a toggle in settings or disabling this behavior altogether?
I see your point. But what is the reason behind having such extension installed and disabled, instead of uninstalling it?
So that they don't update in the background and waste traffic on my metered connection ;) I switch between a lot of languages and runtimes regularly. I use VSCode for C++, C#, F#, PHP, Python, JS/Flow, Processing, GLSL/HLSL, Arduino and others, but I like to keep a "working set" of supporting extensions, depending on the project I'm working on. This comes down to the question "what does disabling extensions actually do", besides declutter the list? Initially I thought this would help with memory usage and startup time, but I don't believe that's really the case. If there's no practical use for disabling, maybe that option should be deprecated in favor of just uninstalling them.
Yes, Disabling helps you in creating a working set. But I see your point and agreed that not auto updating a disabled extension makes sense.
Know that disabled extension can also still popup a notification as well. I'm sure the C++ extension (ms-vscode.cpptools) occasionally (not sure when exactly) asks you to enter a survey even when the extension is disabled.
This should not happen. Please file a separate issue with steps to repro.
I will take a look at this one and follow up with a pull request.
I was wondering about the current status of this issue? If this issue still persists, I would love to contribute and try to resolve it. If this is the case, I would highly appreciate a code pointer to the update procedure, as I am fairly new to this project.
I have not had the chance to look into this. is this something that we still want to pursue?
It looks to me like you have already implemented the desired changes a few days ago?
This is not yet supported and contribution is very much appreciated. Code pointer: Auto update of extensions happen here
Thank you I will look into it. I would say, we just out the disabled extensions and do not return them.

Do you have something different / more elaborate in mind? And do you happen to know an easy way to test this function (i.e. forcing an auto-update)?
I was able to implement this feature and also a configuration to let users decide on whether disabled extensions should be updated. The PR can be found at .
Change:
} test('ExtensionTipsService: No Prompt for valid workspace recommendations when galleryService is absent', () => { <del> instantiationService.stub(IExtensionGalleryService, 'isEnabled', false); return testNoPromptOrRecommendationsForValidRecommendations(mockTestData.validRecommendedExtensions); </del> <ins> const galleryQuerySpy = sinon.spy(); instantiationService.stub(IExtensionGalleryService, { query: galleryQuerySpy, isEnabled: () => false }); return testNoPromptOrRecommendationsForValidRecommendations(mockTestData.validRecommendedExtensions) .then(() => assert.ok(galleryQuerySpy.notCalled)); </ins> }); test('ExtensionTipsService: No Prompt for valid workspace recommendations during extension development', () => {

Discussion:
I am just interacting with the extensions viewlet.
There is a in place that ensures never gets called if the gallery is not configured, so I don't see how this can happen. I am not able to repro either. Can you provide more details about your setup and what actions you were performing?
Perhaps it has something to do with not being invoked as a function. Perhaps should be at
Thanks That must be it. This got introduced in . This was supposed to cover the case of no gallery service. Can you fix this and see why the test case wasn't failing?
Change:
selectKernelForNotebook(kernel: INotebookKernel, notebook: INotebookTextModelLike): void; /** <ins> * Set the kernel that a notebook should use when it starts up */ preselectKernelForNotebook(kernel: INotebookKernel, notebook: INotebookTextModelLike): void; /** </ins> * Bind a notebook type to a kernel. * @param viewType * @param kernel

Discussion:
Error from telemetry. I ran into this as well sometimes when opening a second IW.
Here are some of my findings: We don't have smoke tests for IW Some how the stable version of Jupyter is in the smoke tests Stable version is some how (for some reason) launching IW, hence we see errors Could be because we're testing in stable vs code and requires insiders.
Note: These are messages on the CI server (in our tests). Seems to be in smoke tests.
I believe we get these on CI too: Here's an example from running on main:
I believe this is an issue in core. We might be changing the selected notebook to nothing and it doesn't handle it.
is used only when an issue isn't yet assigned to its rightful owner.
this repros every time an interactive window with a specific name is created for the first time - we haven't created the document for that IW yet. But then the same $acceptNotebookAssociation is fired again after creating that document anyway
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.13.0-beta.2: version "0.13.0-beta.2" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.2.tgz#f58a7a3641ad7c8ac82dd24cfb0165656ed9ac1c" integrity sha512-98tX0BkpD402RoCO6SyikUXpzCn9/OQhlXsRmM/kRFCxMWWofStWTXzCPhN0MjIx2IdGueDjCmnShhidwihErg== xterm-headless@4.20.0-beta.5: version "4.20.0-beta.5" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.20.0-beta.5.tgz#edcff27eb6437d158e6aea2ed7658e783bee5641" integrity sha512-8SnVUsuNUrQ5P0XU/9Iau3uK7Tf8q/p0KHHwkwJXVxZDIlaDH9XKSs91U9BjJJE3sJgRxH4NSiDYR3vFLSFpxw== xterm@4.20.0-beta.5: version "4.20.0-beta.5" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.20.0-beta.5.tgz#d707b0dcb477a554135fb767b24003fced079866" integrity sha512-KBWfk9UPBKRy662DVGGTZEcW1becEjYvlyWbn2hLj9h2gy6Q4EEEEbggJh8I7SGwdFizl+apHQGhEOZmFCA70w== </del> <ins> xterm-addon-webgl@0.13.0-beta.3: version "0.13.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.3.tgz#2b456c3105238e64b40a30787d6335f5f6f85abb" integrity sha512-DFGcXAolA0VTsOLIKcORxUOp/FTJdD/YiRzKVLARjgOycwVRKvW2L5Tge8Z7ysZ16sKfnV2vCXyonXYfUWozXw== xterm-headless@4.20.0-beta.6: version "4.20.0-beta.6" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.20.0-beta.6.tgz#bd016379e9fac47e5b8870d567cdf330cf6f49fc" integrity sha512-EV0V7pxMKI0OEcOCD+6vdXq6rBARr7dSN3PovTsZnDWg5dmvUb2eEmz6BTejJj3UVd/JXNEmEXM+tCh97rDCDg== xterm@4.20.0-beta.6: version "4.20.0-beta.6" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.20.0-beta.6.tgz#3ed87ba383a5cf44284098278f714df7113e3e3c" integrity sha512-xJd6vyOuYo4Ht/hTY3DyXGIj0U6kHjr2vWQ1lRmearo3t7QKf7uqOAAfTLeWt/g1P8qe/r0DnsNTeag6vI9RVw== </ins> yallist@^4.0.0: version "4.0.0"

Discussion:
fixed in Need to update xterm to pull it in: !
What's a way to verify this issue on Windows?
With Powershell on Windows in the integrated terminal without a powerline font enabled: You should get something like this: <img width="62" alt="image" src="https://user-"
They seem a bit clipped to me: !
tracked in
Change:
if (matches && matches.length >= 1) { this.openExternalWithString(this.session, matches.length > 1 ? matches[1] : ''); this.trigger.fire(); <del> this.internalDispose(); </del> return true; } }

Discussion:
I'm trying to use the configuration from website, but I'm facing a problem with the third option. I would like to use like these: and . But I can't find a way to achieve this with : Is it something possible? Thanks a lot
That launch config works for me and does what's expected. Note that the "serverReadyAction" in the latter config does not call the " debug client-side" launch config. For that you would want to use the and put in " debug client-side" for the .
Yes, I agree with you, both configurations are working as expected. I wasn't very clear in my first message, I will try to explain better. On my NextJs project, I can have the following configurations: The first one start the project and enables debugging on server side, the second one open chrome and enables debugging on client side. If I put on the second configuration, it will work just fine: What I want, is using the third configurations only to : start the project, enable debugging on server/client side and open chrome with my . Is it possible to achieve something like this ? I can't find any option in that case to make my working.
serverReadyAction doesn't accept additional configuration properties to pass to the launch config. The reason for this is mostly that intellisense doesn't work in that action (under the hood it's provided by a different extension) so writing configuration in the nested object is hard. The way to do this is define the separate launch config and reference it. Copying your original configuration set:
Your configuration plus two small additions almost give the result I'm looking for! I still have too issues with this: If I kill the (by clicking on the icon), is not automatically killed dispite the option. When I start , is automatically started, but I can see both elements here: !. Is it possible to hide the last one (wich should be automatically killed when is stopped)? I clearly saw that you explained to me why it was not possible to do this (use on a ) in a single configuration, but is there a "hacky" way the achieve my main goal? Or is something planned in the futur? Or maybe there is a way to fix my remaining concerns with the current configuration?

No, this is not possible and is not something we'd do, since you would not be able to control the debug session in that case. That's a bug, will put in a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
* signaled by returning `undefined`, `null`, or an empty array. */ provideDocumentRangeFormattingEdits(document: TextDocument, range: Range, options: FormattingOptions, token: CancellationToken): ProviderResult<TextEdit[]>; <ins> /** * Provide formatting edits for multiple ranges in a document. * * This function is optional but allows a formatter to perform faster when formatting only modified ranges or when * formatting a large number of selections. * * The given ranges are hints and providers can decide to format a smaller * or larger range. Often this is done by adjusting the start and end * of the range to full syntax nodes. * * @param document The document in which the command was invoked. * @param ranges The ranges which should be formatted. * @param options Options controlling formatting. * @param token A cancellation token. * @return A set of text edits or a thenable that resolves to such. The lack of a result can be * signaled by returning `undefined`, `null`, or an empty array. */ provideDocumentRangesFormattingEdits?(document: TextDocument, ranges: Range[], options: FormattingOptions, token: CancellationToken): ProviderResult<TextEdit[]>; </ins> } /**

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --With set to , VSCode will sequentially send requests to its provider(s). It'd be nice if the whole list of ranges could be sent at once instead of sequentially, allowing the formatter to handle this batch as it sees fit. This could be achieved by modifying to take an additional optional metadata parameter that the provider can use to express support for this mode.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Would the team be open to PR for this change? I'm happy to provide one.
To give additional context, we've had user reports like this: When a file has lots of modified chunks, we see lots of round-trips to the server. Batching the requests can provide a very important performance improvement in some cases.
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding!
feedback from API sync, have explicit optional function
fyi this is done and LSP adoption is welcome
already provided a PR for LSP.
To verify: make sure API has a new optional function and make sure it's properly documented (extra) write a dummy extension that implements this and make sure it's called
Change:
// hidden items move into overflow or ignore if (action.hideActions.isHidden) { someAreHidden = true; <del> primary[i] = undefined!; </del> <ins> primary[i] = undefined; </ins> if (this._options?.hiddenItemStrategy !== HiddenItemStrategy.Ignore) { extraSecondary[i] = action; }

Discussion:
open a file from a pull request get an error saying id cannot be read from undefined
this is a regression from
Yes, I too saw this when testing day before yesterday, but as soon as I updated this went away.
Change:
assert.ok(model.getValue().includes('MANUAL')); }); <ins> test('re-run should discard pending edits', async function () { let count = 1; store.add(chatAgentService.registerDynamicAgent({ id: 'testEditorAgent2', ...agentData }, { async invoke(request, progress, history, token) { progress({ kind: 'textEdit', uri: model.uri, edits: [{ range: new Range(1, 1, 1, 1), text: request.message + (count++) }] }); return {}; }, })); ctrl = instaService.createInstance(TestController, editor); const rerun = new RerunAction(); model.setValue(''); const p = ctrl.waitFor([...TestController.INIT_SEQUENCE, State.SHOW_REQUEST, State.SHOW_RESPONSE, State.WAIT_FOR_INPUT]); const r = ctrl.run({ message: 'PROMPT_', autoSend: true }); await p; assert.strictEqual(model.getValue(), 'PROMPT_1'); const p2 = ctrl.waitFor([State.SHOW_REQUEST, State.SHOW_RESPONSE, State.WAIT_FOR_INPUT]); await instaService.invokeFunction(rerun.runInlineChatCommand, ctrl, editor); await p2; assert.strictEqual(model.getValue(), 'PROMPT_2'); ctrl.finishExistingSession(); await r; }); </ins> });

Discussion:
make an inline chat request that changes code select the re-generate action :bug: the previous changes aren't undone