jiebi/CodeConvo huggingface dataset:
Change:
import { assertAllDefined, assertIsDefined } from 'vs/base/common/types'; import { NotificationsCenterVisibleContext } from 'vs/workbench/common/contextkeys'; import { INotificationService } from 'vs/platform/notification/common/notification'; <ins> import { AccessibleNotificationEvent, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> export class NotificationsCenter extends Themable implements INotificationsCenterController {

Discussion:
Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
type: 'boolean', default: true, description: nls.localize('useRelativeTime', "Determines if relative time will be used in comment timestamps (ex. '1 day ago').") <ins> }, 'comments.visible': { type: 'boolean', default: true, description: nls.localize('comments.visible', "Controls the visibility of the comments bar and comment threads in editors that have commenting ranges and comments.") </ins> } } });

Discussion:
See related issue that was closed by user who opened it: I think it'd be fantastic to hide the discussion/comment bar for those of us that like to keep our interface really minimal. Part of it is how it's distracting to see the + sign moving all over the document with the cursor. I'd like to be able to turn it off in the settings for all circumstances. <img width="115" alt="image" src="https://user-"
I second that! VSCode already has a reputation of being an angry fruit salad. A car radio with a full color display in demo-mode, and then 50 of them built into a store display, scream less than VSCode. Ok I might be exaggerating a bit here.. but I am for from exaggerating when I say that I have about 180 lines in my file just to tone it down. Today I would like to make that a 181 lines. Cheerio!
Have you tried the command "Comments: Toggle Editor Commenting"? If that's not enough then I can also add a setting.
While the "Comments: Toggle Editor Commenting" command is useful, it doesn't persist and doesn't completely solve the issue: if I enable Zen mode and then disable Zen mode, then this gutter will reappear and I will need to toggle again. after running the toggle, the gutter is still wider than it would be without this extension enabled. I just disable this extension until I need it and then enable it temporarily when I need it.
I'll make some updates to better persist the disablement.
Hello! I'm also looking forward to hiding this button. Actually I just need to make commits in vs code, and I don't use review even when a pull request is open But of course someday I will use it, it's just that this good function is not for every day
Incoming change does the following: Persists your pre-zen mode comment toggled state when exiting zen mode Introduces the setting Still let you quickly toggle commenting on an off irrespective of , similar to how toggle word wrap works.
Thanks for the progress!! It seems like the new settings don't do anything about the double-wide gutter. That's a pretty big deal because I'm losing a decent chunk of screen real estate even when commenting is turned off.
I was going to address that in a separate PR to keep my changes smaller. I'm planning to fix it today!
Oh hurray!! So exciting!!
Change:
private readonly _hoverOperation: HoverOperation<IHoverPart>; private _currentResult: HoverResult | null = null; <del> private _isChangingDecorations: boolean = false; </del> constructor( private readonly _editor: ICodeEditor,

Discussion:
I was trying to copying a new setting in the problems hover and it was extremely painful to do so: https://user-
This is editor hover and hence assigning to
FWIW this works fine for me on Windows.
Change:
@IInstantiationService private instantiationService: IInstantiationService, @IWorkspaceContextService private contextService: IWorkspaceContextService, @ITerminalService private terminalService: ITerminalService, <del> @IThemeService private themeService: IThemeService </del> <ins> @IThemeService private themeService: IThemeService, @IMessageService private messageService: IMessageService </ins> ) { super(TERMINAL_PANEL_ID, telemetryService); }

Discussion:
Steps to Reproduce: terminal as "faketerm" +`
On Linux (ElementaryOS) I get an error dialog with message 'The terminal process terminated with exit code: 1'. Setting as verified, although more details would be helpful.
Indeed that verifies it. Thanks.
Change:
await this.code.waitForElement(SEARCH_BOX); } <del> async searchForExtension(name: string): Promise<any> { </del> <ins> async searchForExtension(id: string): Promise<any> { </ins> await this.code.waitAndClick(SEARCH_BOX); await this.code.waitForActiveElement(SEARCH_BOX); <del> await this.code.waitForTypeInEditor(SEARCH_BOX, `name:"${name}"`); </del> <ins> await this.code.waitForTypeInEditor(SEARCH_BOX, `@id:${id}`); </ins> } <del> async installExtension(name: string): Promise<void> { await this.searchForExtension(name); </del> <ins> async installExtension(id: string, name: string): Promise<void> { await this.searchForExtension(id); </ins> const ariaLabel = `${name}. Press enter for extension details.`; await this.code.waitAndClick(`div.extensions-viewlet[id="workbench.view.extensions"] .monaco-list-row[aria-label="${ariaLabel}"] .extension li[class='action-item'] .extension-action.install`); await this.code.waitForElement(`.extension-editor .monaco-action-bar .action-item:not(.disabled) .extension-action.uninstall`);

Discussion:
Extensions smoke tests are failing
This was caused because of two reasons has changed their search strategy and looking for extension by name is broken - label of an extension has string which was a bug introduced recently. Fixed them here -
Change:
return this._apiObject; } <ins> get isDisposed(): boolean { return !this._sender; } </ins> dispose(): void { if (this._sender?.flush) { <del> // Disposed of so now we set it to undefined Promise.resolve(this._sender.flush()).then(this._sender = undefined); </del> <ins> let tempSender: vscode.TelemetrySender | undefined = this._sender; this._sender = undefined; Promise.resolve(tempSender.flush!()).then(tempSender = undefined); </ins> this._apiObject = undefined; <ins> } else { this._sender = undefined; </ins> } } }

Discussion:
Testing Given this code: I was expecting my event handlers not to fire since the logger is disposed, but they still fire.
This still repros for me <img width="1210" alt="image" src="https://user-"
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.46: version "0.14.0-beta.46" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.46.tgz#d25cbdf18f67e45b60782c5abe4accf2ddaf0c0f" integrity sha512-kULKDY2toIjgI8GlM0AEmi8wcBJxhv+b49tBJFYpgTV338gGD5cFfFl4zunOwO7+N0de8G5a5P16MVRjHp5ARg== </del> <ins> xterm-addon-webgl@0.14.0-beta.50: version "0.14.0-beta.50" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </ins> <del> xterm-headless@5.1.0-beta.82: version "5.1.0-beta.82" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.82.tgz#980348b9a2d53b307b538891fb2cb35dbfab2598" integrity sha512-h7D7IStH5LpXqL4IvGU5nE13LNHc6OrOQZm8GtJgKh2PZhHfQ2vLdDnW0SfeiIBtNvr4Hg8CX0uFYuSlBUA0GQ== </del> <ins> xterm-headless@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.87.tgz#6eb3114bbe006088ce1aab063f14ce87b93c1001" integrity sha512-/LEyLBkyAMy5r2iGur1CW0UsCGu1oEuskAccokbwOGS5Ad/uPZUDQUAuCmfSSX3gauz5TBqBPLYIRdY0u0DEJg== </ins> <del> xterm@5.1.0-beta.82: version "5.1.0-beta.82" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.82.tgz#e1e4c7db5547e0b9f8a381ed59c266269363c21e" integrity sha512-/s6ueCDOmgJpLS2P5uttQLvy9Pg9uE+R0G9rnXC2e7bxks0ljnc2V4w2PMd2Iidk4oR4F/4K/rFhCPlX+cVZ3A== </del> <ins> xterm@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </ins> yallist@^4.0.0: version "4.0.0"

Discussion:
Testing Code insiders, set how the inactive selection colour is stronger than the active selection colour I can only reproduce this with "canvas", all other gpu acceleration options work fine. Terminal focused ! Terminal not focused !
Upstream:
Change:
); // border: defaults to active background colors.registerColor( <del> 'commandCenter.border', { dark: activeBackground, hcDark: colors.inputBorder, light: activeBackground, hcLight: colors.inputBorder }, </del> <ins> 'commandCenter.border', { dark: PANEL_BORDER, hcDark: PANEL_BORDER, light: PANEL_BORDER, hcLight: PANEL_BORDER }, </ins> localize('commandCenter-border', "Border color of the command center"), false );

Discussion:
Testing I believe the border contrast needs to be 3:1 between the border and bg color of the title bar. Something like might be a little closer to what we want: <img width="489" alt="CleanShot 2022-05-31 at 13 02 15 src="https://user-"<img width="520" alt="CleanShot 2022-05-31 at 13 01 04 src="https://user-"
Your suggested colors falls back to which actually aren't defined for for light/dark themes, only for HC themes... I went with variants of the foreground-color. The contrast-ratio tool in devtools seems broken... Do you mind making more directly in this branch:
Change:
return true; } else if (thing && typeof thing === 'object') { return typeof (<IMarkdownString>thing).value === 'string' <del> && (typeof (<IMarkdownString>thing).isTrusted === 'boolean' || (<IMarkdownString>thing).isTrusted === undefined) </del> <ins> && (typeof (<IMarkdownString>thing).isTrusted === 'boolean' || typeof (<IMarkdownString>thing).isTrusted === 'object' || (<IMarkdownString>thing).isTrusted === undefined) </ins> && (typeof (<IMarkdownString>thing).supportThemeIcons === 'boolean' || (<IMarkdownString>thing).supportThemeIcons === undefined); } return false;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: see below, pulled from the "Help About" dialog. Also confirmed in 1.71.2. OS Version: see below, pulled from the "Help About" dialog. Steps to Reproduce: above VSCode Insiders build. (Instructions don't require system path to be updated.) a directory in WSL, say . , where is the distro of your choice. the WSL extension as prompted and reload. the editor and run , where is the distro of your choice. (Steps 2-4 were just to initialize some VSCode state.) a new file in that directory with the following contents: restart editor. (Works either way.) over above. tooltip will appear with "some thing linking Foo" where is hyperlinked. Click the hyperlink in the tooltip. attempts to open a file at the path in the parent Windows OS, outside of any WSL distro. Note that this reproduces both with the WSL extension enabled the whole time (skipping step 5) and with it disabled at step 5.
Did this get missed?
I have the same issue with VSCode running in WSL2 (Ubuntu)
Same issue here, using a remote connection to a VM running on Hyper-V. Host OS is Windows, guest OS is Ubuntu 22.04. It only happens when clicking the link in the tooltip. Using directly in the editor works as expected.
Still seeing this issue. Looking forward to this getting resolved soon.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
import DiagnosticsManager from './features/diagnostics'; import { LanguageDescription } from './utils/languageDescription'; import * as fileSchemes from './utils/fileSchemes'; <ins> import { CachedNavTreeResponse } from './features/baseCodeLensProvider'; </ins> const validateSetting = 'validate.enable';

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.
Change:
const handleTitleClickOrTouch = (e: MouseEvent | GestureEvent): void => { let target: HTMLElement; if (e instanceof MouseEvent) { <del> if (e.button !== 0 || (isMacintosh && e.ctrlKey)) { return undefined; // only for left mouse click (ctrl+click on macos is right-click) </del> <ins> if (e.button !== 0 /* middle/right mouse button */ || (isMacintosh && e.ctrlKey /* macOS context menu */)) { return undefined; </ins> } target = e.target as HTMLElement;

Discussion:
open vscode for web on macOS ctrl+click into a tab that is not active context menu opens but also the tab opens fyi this is similar to and requires the same fix. Interestingly on Electron this does not seem to be an issue, maybe produces context menu event in Electron but not in Web?
Change:
private _widgetManager: TerminalWidgetManager | undefined; private _processCwd: string | undefined; private _standardLinkProviders: ILinkProvider[] = []; <del> private _standardLinkProvidersDisposables: IDisposable[] = []; </del> <ins> private _linkProvidersDisposables: IDisposable[] = []; </ins> constructor( private _xterm: Terminal,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.61.0 Commit: Date: 2021-10-07T18:11:58.853Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Steps to Reproduce: the Terminal Sample from the vscode-extension-sample repository the a task that reuses a terminal. For example, I used a user task like: On the first run of the task the 'link' text will create a hover link correctly. If you re-run the task so the terminal has 2 (or more) runs of the task in the same terminal then the link will fail to detect correctly. Adding a breakpoint to there appears to be 1 call per execution of the task in the terminal. I think when the terminal is re-used it re-registers the link provider and if two link providers have overlapping links they both seem to fail (which is a known issue but due to this bug all link providers start failing if tasks are run multiple times).
Putting a breakpoint in the registerLinkProvider call for xterm (here ) I see multiple copies of all of the link providers: <img width="574" alt="Screen Shot 2021-10-12 at 9 15 30 AM" src="https://user-"
Change:
} }; observable.addObserver(observer); <ins> observable.reportChanges(); </ins> return { dispose() { observable.removeObserver(observer);

Discussion:
Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.
I cannot find your reversed P, nonetheless, with diff version 2 and removed "ignore leading/trailing whitespace", I get this: <img width="1384" alt="image" src=""and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width="551" alt="image" src=""
Change:
async showEditsPreview(textModel0: ITextModel, textModelN: ITextModel, allEdits: ISingleEditOperation[][]) { <del> const diff = await this._editorWorkerService.computeDiff(textModel0.uri, textModelN.uri, { ignoreTrimWhitespace: false, maxComputationTimeMs: 5000, computeMoves: false }, 'advanced'); if (!diff || diff.changes.length === 0) { this.hideEditsPreview(); return; } </del> this._elements.previewDiff.classList.remove('hidden'); const languageSelection: ILanguageSelection = { languageId: textModel0.getLanguageId(), onDidChange: Event.None };

Discussion:
Enable screen reader mode or use preview mode Create a code error Invoke inline chat and use The response doesn't get shown in the diff editor and sometimes doesn't come back at all. The console shows the error below
I see:
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
screen reader mode a code error inline that and use /fix response doesn't get shown in the diff editor and sometimes doesn't come back at all.
Maybe related
Change:
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IWindowService } from 'vs/platform/windows/common/windows'; <del> import Severity from 'vs/base/common/severity'; </del> import { URI } from 'vs/base/common/uri'; import { IExtension, ExtensionState, IExtensionsWorkbenchService, AutoUpdateConfigurationKey, AutoCheckUpdatesConfigurationKey } from 'vs/workbench/contrib/extensions/common/extensions'; import { IEditorService, SIDE_GROUP, ACTIVE_GROUP } from 'vs/workbench/services/editor/common/editorService';

Discussion:
Issue Type: <bBug</bI noticed when I install extension by clicking on the green "Install" button from within the VScode extension page, as opposed to the "Would you like to install..." notification/chat bubble in the lower right corner of the editor, the chat bubble stays there, asking me if I want to install the extension I just installed. Would be great if the state was in sync and the bubble would be dismissed when I installed the extension, no matter how. <details<summaryScreenshot after installation</summary<img width="2032" alt="Screen Shot 2019-05-06 at 17 54 50" src="https://user-"</detailsVS Code version: Code 1.33.1 (, 2019-04-11T08:22:55.268Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ project-manager10.5.1 solargraph0.19.6 bracket-pair-colorizer1.0.61 vscode-eslint1.8.2 es7-react-js-snippets2.2.2 gitlens9.7.1 prettier-vscode1.9.0 rails-snippets1.0.8 rest-client0.21.2 vscode-codemetrics1.18.0 vscode-language-babel0.0.22 ruby-rubocop0.8.0 sublime-keybindings4.0.0 debugger-for-chrome4.11.3 JavaScriptSnippets0.2.0 ruby0.22.3 code-settings-sync3.2.9 change-case1.0.0 JavaScriptSnippets1.7.2 </details<!-- generated by issue reporter --
, I would like to try this , Some starter and code pointers would be helpful :)
It depends on how got this notification. can you please let us know how you got this?
It shouldn't depend on that. I got it by clicking install button in VS Code Extension Marketplace website, in the browser.
This notification comes from here -
, I checked the code but just wanted to discuss on one thing .

Is that notification needed in the first place , clicking on install button on top will do the same job , Also removing that notification will keep the two scenarios consistent and same (Normally opening that extension page and opening the extension page from browser) We can remove the notification prompt to fix the inconsistency .
, were you able to look into this ? I can remove the notification bubble and send a PR, please confirm :)
Yeah it look unnecessary for me. Please remove it.