jiebi/CodeConvo huggingface dataset:
Change:
const foundHoverActions = new Map<string, { range: Range; action: CommentRangeAction }>(); for (const decoration of this.commentingRangeDecorations) { const range = decoration.getActiveRange(); <del> if (range && ((range.startLineNumber <= commentRange.startLineNumber) || (commentRange.endLineNumber <= range.endLineNumber))) { </del> <ins> if (range && this.areRangesIntersectingOrTouchingByLine(range, commentRange)) { </ins> // We can have several commenting ranges that match from the same owner because of how // the line hover and selection decoration is done. // The ranges must be merged so that we can see if the new commentRange fits within them.

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW
Change:
id: ShowSignalSoundHelp.ID, title: localize2('signals.sound.help', "Help: List Signal Sounds"), f1: true, <ins> metadata: { description: localize('accessibility.sound.help.description', "List all accessibility sounds / audio cues and configure their settings") } </ins> }); }

Discussion:
Type: <bBug</bCC I know the setting structure has changed. However, I don't hear any audio cue sound across all the supported settings even if I have turned on everything on. Tested on Windows. VS Code version: Code - Insiders 1.87.0-insider (, 2024-02-13T05:47:27.450Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (101)</summaryExtensionVersion ------ vscode-openapi4.21.1 android-dev-ext1.4.0 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.122 mermaid-markdown-syntax-highlighting1.6.0 doxdocgen1.4.0 vscode-markdownlint0.53.0 vscode-quick-select0.2.9 vscode-deno3.33.3 gitlens14.6.1 prettier-vscode10.1.0 vscode-firefox-debug2.9.10 shell-format7.2.5 vscode-google-translate1.4.13 codespaces1.16.10 copilot1.160.705 copilot-chat0.13. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.81.

cloudcode2.4.0 overleaf-workshop0.9.1 cslpreview0.2.2 easy-snippet0.7.5 path-autocomplete1.25.0 latex-workshop9.18.0 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 commitlint2.4.7 language-julia1.71.1 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 git-graph1.30.0 azure-dev0.8.0 vscode-azureappservice0.25.1 vscode-azurecontainerapps0.6.1 vscode-azurefunctions1.13.3 vscode-azureresourcegroups0.8.3 vscode-azurestaticwebapps0.12.2 vscode-azurestorage0.15.3 vscode-azurevirtualmachines0.6.5 vscode-cosmosdb0.20.1 debugpy2024.1. python2023.25. vscode-pylance2023.12.103 jupyter2024.1. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.342.0 remote-ssh0.109. remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.25.0 azure-account0.11.6 azure-repos0.38.0 cmake-tools1.16.32 cpptools-extension-pack1.3.0 powershell2024.3.0 remote-explorer0.5. remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-node-azure-pack1.2.0 vscode-selfhost-test-provider0.3.25 vscode-serial-monitor0.11.0 vscode-speech0.5.

vsliveshare1.0.5905 windows-ai-studio0.2.4 autodocstring0.6.1 pandocciter0.10.4 shiny-python0.1.5 shinyuieditor0.5.0 quarto1.110.1 r-debugger0.5.4 vscode-xml0.26.1 vscode-yaml1.14.0 r2.8.2 multi-command1.6.0 AudioQ0.0.2 vscode-deepl1.0.10 abc-music0.4.0 lua3.7.4 latex-utilities0.4.12 cmake0.0.17 vscode-terminal-here0.2.4 windows-terminal0.7.0 errorlens3.16.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-conventional-commits1.25.0 markdown-all-in-one3.6.2 grammarly0.25.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
just realized this and working on a fix right now.
figured it out, there was a rename of the audio cues and a typo in the new folder for the resources
Change:
*--------------------------------------------------------------------------------------------*/ .vscode-dark img[src$=#gh-light-mode-only], <del> .vscode-light img[src$=#gh-dark-mode-only] { </del> <ins> .vscode-light img[src$=#gh-dark-mode-only], .vscode-high-contrast img[src$=#gh-light-mode-only], .vscode-high-contrast-light img[src$=#gh-dark-mode-only] { </ins> display: none; }

Discussion:
High Contrast themes display both dark and light mode markdown content simultaneously. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: MacOS 14.2.1 Steps to Reproduce: a markdown document an image with both a light and dark variant to a high-contrast theme if both light and dark variants are displayed
works, but causes the image to never show.
Change:
getWindows(options: { includeAuxiliaryWindows: false }): Promise<Array<IOpenedMainWindow>>; getWindowCount(): Promise<number>; getActiveWindowId(): Promise<number | undefined>; <ins> getActiveWindowPosition(): Promise<IRectangle | undefined>; </ins> openWindow(options?: IOpenEmptyWindowOptions): Promise<void>; openWindow(toOpen: IWindowOpenable[], options?: IOpenWindowOptions): Promise<void>;

Discussion:
atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor. in these two examples, i have one large curved secondary monitor where vs code is. open an aux window, and it spawns it in my laptop's screen. same thing if full screened on secondary monitor. different when full screen on main screen (see ) wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.
that should be possible if you provide the coordinates for where to open the window via : You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the . Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
panelHeight = 0; panelWidth = 0; } else if (panelPosition === Position.BOTTOM) { <del> if (this.panelHeight === previousMaxPanelHeight) { panelHeight = maxPanelHeight; } else if (this.panelHeight > 0) { </del> <ins> if (this.panelHeight > 0) { </ins> panelHeight = Math.min(maxPanelHeight, Math.max(this.partLayoutInfo.panel.minHeight, this.panelHeight)); } else { panelHeight = sidebarSize.height * DEFAULT_PANEL_SIZE_COEFFICIENT;

Discussion:
VSCode Version: Code 1.19.2 (, 2018-01-10T15:55:03.538Z) OS Version: Windows_NT x64 10.0. Extensions: ExtensionVersion ------ code-gnu-global0.2.2 vscode-clang0.2.2 cpptools0.14.5 Description: The terminal panel automatically maximized when I resize the window. I think this was caused by the method of maximizing this panel. Maybe it was like this: And when I resize the window to be less high, the condition is reached because I only changed the window's height, didn't change the panel's. Although this is not a serious problem, I still feel annoyed as I should use my mouse to click the button each time I do so. Hope you can fix this Steps to Reproduce: an empty window, no folder open needed the powershell terminal, and make it longer(x-axis) the window on a top corner, either left-top or right-top(You can drag it there using mouse or using keyboard Win+Right,Win+Up) By now, you can see the maximize button has changed <!-- Launch with to check. --Reproduces without extensions: Yes
I acknowledge this bug and we accpet PRs that fix this code pointer Easy repro steps panel size of whole vscode window such that the panel thinks it is maximized size of hwole vscode window, panel remains maximized and occupies most of space
I'd like to take this. Will drop a PR.
Just to clarify and document the issue, I'm uploading a gif. !
yes that is exactly the issue, thanks for providing a gif
I just opened a PR. Please check.
Change:
"name": "punctuation.definition.string.end.html" }, "1": { <del> "name": "source.js-ignored-vscode" </del> <ins> "name": "source.js" </ins> } }, "name": "string.quoted.double.html",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.71.0 Commit: Date: 2022-09-01T07:25:10.472Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.10.7-arch1-1 Sandboxed: No Steps to Reproduce: a file with the contents: a SvelteKit project and open any file. as shown in the video. https://user- Result: Without a space - it doesn't work. With space - it works. Cause: When the cursor is in front of the character, it thinks it is already AFTER , although this is not true. PS The same problem is in the last character, before , in the file.
This also happens in the HTML with where being cursor position. The problem seems to be because the position of the cursor is on the border of the embedded language. Maybe it could be changed to using the previous character, when possible, instead of the next?
Thanks - I can reproduce what you are saying. I don't really know what svelte kit is nor what extension you are using. So, I am focusing on html. Using "F1 Inspect Editor Tokens and Scopes" shows me that the language at position is classified as html, not JavaScript. <img width="728" alt="Screenshot 2022-12-05 at 16 22 35" src="https://user-"Because of that no JS snippets are shown. Passing this on to who maintains the TextMate grammars for this.

An easy workaround on your end would be to configure the snippet to also work for the "outer" language
SvelteKit: SvelteJS is the 4th most popular framework (behind ReactJS Vue Angular), and considered to have the best DX of all frameworks. Extension for SvelteJS: But I hope that solving the problem in html/js, will also solve the problem in SvelteJS.
Related to
what do you think of modifying the solution to so that we don't ignore strings? PR
Change:
'vscode.experimental.editSession.continue', '_workbench.editSessions.actions.continueEditSession', 'Continue the current edit session in a different workspace', [ApiCommandArgument.Uri.with('workspaceUri', 'The target workspace to continue the current edit session in')], ApiCommandResult.Void <ins> ), // --- context keys new ApiCommand( 'setContext', '_setContext', 'Set a custom context key value that can be used in when clauses.', [ ApiCommandArgument.String.with('name', 'The context key name'), new ApiCommandArgument('value', 'The context key value', () => true, v => v), ], ApiCommandResult.Void </ins> ) ];

Discussion:
This came from vscode-docs issue customer comment "The biggest missing documentation for extensions is the lack of setContext here " Should we add the description and metadata so that it will be part of the _generateCommandsDocumentation output?
FYI I would love this. At the same time, could we think about adding the corollary ? The number of hoops that need to be jumped through to get the right context make things very difficult (and other impossible). Here is a concrete example. In GitLens, I have commands that navigate forward and backward through revisions. The current diff editor behavior make these difficult to implement well -- leaving aside the details there, to work around it one solution I've come up with is duplicating those 2 commands, 1 for normal editors and 1 for diff editors. And then I have to duplicate all the placements ( and and then have the command behave appropriately based on the context. Alternatively, if there was a type api, I could avoid all of that, and just look up in my existing command and do the right thing. Way less complexity and explosion of commands and placements. Please?
I am also very concerned about this issue. I found the when I'm reading the source code of , but I didn't find it in , but in the . I hope the official team can fix this issue soon. Best wishes. : )
Like I found use of in the samples () and the 2016 update documentation. 2016 blog reference, but not in API docs and this issue has been open more than a year? Is it maybe considered "proposed API"?
seems like the issue belongs to , right?
same here too... unfortunately documentation is falling behind!
examples to Command Extension Guide with
Why is this still open? Are we happy that it is documented in the docs?
Change:
// Listen to language changes on the model this._textModelDisposables.add(this._textModel.onDidChangeLanguage((e) => this.setRegisteredLanguage(this._languageService, e.newLanguage, this.language))); this._textModelDisposables.add(this._textModel.onWillDispose(() => this.textModel = undefined)); <del> this._textModelDisposables.add(this._textModel.onDidChangeContent(() => { </del> <ins> this._textModelDisposables.add(this._textModel.onDidChangeContent((e) => { </ins> if (this._textModel) { this._versionId = this._textModel.getVersionId(); this._alternativeId = this._textModel.getAlternativeVersionId(); } this._textBufferHash = null; <del> this._onDidChangeContent.fire('content'); </del> <ins> this._onDidChangeContent.fire({ type: 'model', event: e }); </ins> })); this._textModel._overwriteVersionId(this._versionId);

Discussion:
Testing 1) I started with 2) I ran the first two cells and then committed 3) I reran cell 1 4) I changed cell 3 to use different file names 5) I opened the notebook diff from the SCM view -(a) cell metadata changes were shown -(b) changes to cell 3 where hidden -(c) toggling the "Toggle Collapse Unchanged Regions" didn't do anything !
I was unable to reproduce (b) reliably.
Verifier: Make the workbench small enough so when opening only the first cells show up Run the first two cells Commit/stage the file Scroll to the last cell, make changes, save (if you don't have auto save) Open the diff view, the change in the last cell should be rendered.
cannot test this due to
Change:
public async playAudioCue(cue: AudioCue, options: IAudioCueOptions = {}): Promise<void> { const alertMessage = cue.alertMessage; if (this.isAlertEnabled(cue, options.userGesture) && alertMessage) { <del> this.accessibilityService.alert(alertMessage); </del> <ins> this.accessibilityService.status(alertMessage); </ins> } if (this.isCueEnabled(cue, options.userGesture)) {

Discussion:
Testing While testing I noticed that when I moved my cursor on a line with an error, the word was read, but the contents of that line were no longer read. I was wondering if this is intended? I noticed that sometimes the beginning of the text on the line is read, before it breaks off and reads the alerts.
I noticed that sometimes when I put my cursor on a line with a breakpoint, it does not read the word . Is the alert only supposed to sound at specific moments? Ie, for example the first time the cursor is placed on an active line with a breakpoint?
alerts interrupt whatever else might be read by design. And yes, it looks like in your case, you're using mouse clicks vs arrow keys to navigate between the lines. We listen to arrow keys, thus it's expected that you wouldn't hear the cues.
Additionally, I have checked with our power SR users and the alerts are working as expected in the editor.
I am going to open an issue to get more feedback on this.
Hi thank you for the clarification, that makes sense.
We are going to use instead here because editor content is the priority.
Change:
} })); <ins> // Title Menu changes this._register(this.titleService.onDidChangeCommandCenterVisibility(() => this.doUpdateLayoutConfiguration())); </ins> // Fullscreen changes this._register(onDidChangeFullscreen(() => this.onFullscreenChanged()));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest OS Version: MacOS Latest Steps to Reproduce: I have already disabled the following but I still have an empty top bar taking space in fullscreen mode, whereas before this change I could have removed the topbar completely. Before <img width="1439" alt="Screenshot 2023-08-03 at 10 13 57" src=""After <img width="1439" alt="Screenshot 2023-08-03 at 10 13 32" src=""Similar issue:
Workaround: It seems to be fixed once I exit/enter the fullscreen mode again.
To clarify--this is the issue you're running into? That issue is just about being able to toggle it in the first place, which does work as expected today. This behavior seems scoped to fullscreen mode specifically.
I also have this problem. I need that top bar completely removed, but I can turn off stuff and it still stays up. Is this really forced on us to not be able to remove?
actually that worked, had to go outside of fullscreen and now in fullscreen it correctly disappears. Cheers ;)
Yeah, I don't think this is intentional but just wanted to confirm the issue.
Change:
let hasEdits: boolean = false; for (const value of values) { const edit = this.getEdits(model, value)[0]; <del> hasEdits = this.applyEditsToBuffer(edit, model); </del> <ins> hasEdits = !!edit && this.applyEditsToBuffer(edit, model); </ins> } if (hasEdits) { return this.textFileService.save(model.uri);

Discussion:
Reproduce: vscode-insiders latest vscode-insiders vscode-insiders command `Clear Display Language Preference https://user-
Change:
*--------------------------------------------------------------------------------------------*/ .monaco-editor .parameter-hints-widget { <del> /* Must be higher than sash's z-index and terminal canvases */ z-index: 40; </del> <ins> /* Must be higher than the sash's z-index and terminal canvases but lower than the suggest widget */ z-index: 39; </ins> display: flex; flex-direction: column; line-height: 1.5em;

Discussion:
Old behavior: ! New behavior: ! This new behavior doesn't happen all the time, this appears to happen because both suggest and parameter hints use z-index 40 right now. cc Caused by
To verify: Find a method with large parameter docs like Scroll that line to near the top Re-type to trigger hints, the parameter hint should show below Press ctrl+space (or mac equivalent) to show intellisense Also: Reload window Find a method with large parameter docs like Scroll that line to near the top Press ctrl+space (or mac equivalent) to show intellisense Press escape Re-type to trigger hints, the parameter hint should show below Press ctrl+space (or mac equivalent) to show intellisense, intellisense should be on top of parameter hints
I'm seeing this - I expected to see the definition !
when I scroll down a bit: !
that's actually the correct behavior; intellisense should cover the parameter hints popup
oh I was confused because usually old behavior is bad new is good (expected)
so this was a regression?
Yep it was a regression
Change:
this.applyStyles(); <ins> // Allows focus to switch to next/previous entry after tab into an actionbar item DOM.addDisposableListener(this.treeContainer.getHTMLElement(), DOM.EventType.KEY_DOWN, (e: KeyboardEvent) => { const keyboardEvent: StandardKeyboardEvent = new StandardKeyboardEvent(e); if (keyboardEvent.keyCode === KeyCode.DownArrow || keyboardEvent.keyCode === KeyCode.UpArrow || keyboardEvent.keyCode === KeyCode.PageDown || keyboardEvent.keyCode === KeyCode.PageUp) { DOM.EventHelper.stop(e, true); this.navigateInTree(keyboardEvent.keyCode, keyboardEvent.shiftKey); this.inputBox.inputElement.focus(); } }); </ins> return this.builder.getHTMLElement(); }

Discussion:
While testing . VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-01T05:07:59.267Z) OS Version: Darwin x64 16.7.0 Steps to Reproduce: 3 terminals from the command palette <kbdArrowDown</kbdto the last terminal in the switcher <kbdTab</kbdto rename the terminal -keyboard focus disappears from the input box (and seems to be nowhere). I need a second <kbdTab</kbdto move the keyboard focus to the rename action in the selected row. A single <kbdTab</kbdshould suffice.
This is also an issue with task configuration
Change:
Editor = 'editor' } <del> export const enum TerminalCommandIcon { TriangleRight = 'triangle-right', ChevronRight = 'chevron-right', } export const enum TerminalCommandIconError { TriangleRight = 'triangle-right', ChevronRight = 'chevron-right', X = 'x' } </del> export type TerminalIcon = ThemeIcon | URI | { light: URI; dark: URI }; export interface IShellLaunchConfigDto {

Discussion:
Currently you can disable them via: But this is not particularly easy and the decorations still end up rendering. We should have a switch that disables them outright, including adding them to xterm.
<img width="1111" alt="Screen Shot 2022-02-23 at 5 04 01 PM" src="https://user-"It is enabled even though shell integration is off... But thanks for the fix, now i can go back to using the integrated terminal! EDIT: the fix doesn't work, guess i'm stuck with iterm2 for now...
they're rectangles so you're probably on a pretty old build (1 week+?), updating will probably fix it for you.
are there any verification steps?
It's still unreleased, but use to disable them.