jiebi/CodeConvo huggingface dataset:
Change:
updateScopeOverrides(element: SettingsTreeSettingElement, onDidClickOverrideElement: Emitter<ISettingOverrideClickEvent>, onApplyFilter: Emitter<string>) { this.scopeOverridesIndicator.element.innerText = ''; this.scopeOverridesIndicator.element.style.display = 'none'; <del> this.scopeOverridesIndicator.element.tabIndex = 0; </del> <ins> this.scopeOverridesIndicator.focusElement = this.scopeOverridesIndicator.element; </ins> if (element.hasPolicyValue) { // If the setting falls under a policy, then no matter what the user sets, the policy value takes effect. this.scopeOverridesIndicator.element.style.display = 'inline';

Discussion:
Change the key event handling so that the user can tab once into the indicators container, and then use left/right arrows to focus on different indicators.
the Settings editor, search on the setting. tab should focus on the first indicator. again should go to the checkbox. -tabbing twice from there should focus the entire setting again. again to the indicator. The left and right arrow keys, along with the home and end keys should allow the user to focus onto the other indicators. indicators container should keep track of the focused indicator. If the second indicator is focused, and the user tabs to the checkbox and back, the second indicator should be the one focused rather than the first one.
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.39.tgz#e8376e1485ee7d763c07d1a8f1354114f65b3e3e" integrity sha512-h45wkecgfqXXoAUqgNytAfSd6g0xNT6rZy/enVaEU0aes7QoL9pxHUKkCry8PP6hs03Slk0VxQ4AGsbSZGvK/w== <del> xterm-addon-serialize@0.7.0-beta.12: version "0.7.0-beta.12" resolved "https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.7.0-beta.12.tgz#4f845d8b1a9f9b7ae3f910455ce8c58b041babc7" integrity sha512-b4Ug0B/RSJMux+KAcp+PXVqubVyXjN1yCQw1FOkgVYTpmd9AH/X+EcxKml5Lz8DsKmsXqfD9AlV3WpEeT+OtMw== </del> <ins> xterm-addon-serialize@0.7.0-beta.13: version "0.7.0-beta.13" resolved "https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.7.0-beta.13.tgz#5c859c8657cab7f28405aab1a0715daf54bc7714" integrity sha512-TYFlm/gds0pOmpzXw7ZWx8Cy48lMaOZZqZgfm5pWU37HPvzfKxXSVdYL1biWpRCH2zCH+3cWmOma8W1pBRr+Eg== </ins> xterm-addon-unicode11@0.4.0-beta.3: version "0.4.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.39: version "0.12.0-beta.39" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.39.tgz#f5fafd2c4d1ec046ff6b57edf850234948cf630a" integrity sha512-116gk9KYqbMyCcjedDYhqg3RKl0CI19I1l/+u8JdJb6bucv835Hj60W2it5AAsmvw726FEXwhMoOaY3gs+n1/g== </del> <ins> xterm-addon-webgl@0.12.0-beta.41: version "0.12.0-beta.41" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.41.tgz#17dbca975b6e9b34526ebc57f4de59ee295da1b6" integrity sha512-wvQxC5diMYEJEMaILfz+4CWB2GgtzjzNQRNDnK7R7Y9wDI+P4idDlQKgyH0nA93sl9R4zgqlBVha//wuq4vfZg== </ins> xterm-headless@4.19.0-beta.60: version "4.19.0-beta.60"

Discussion:
Notice the words in the following screenshot: ! Does not reproduce in , from 3 days ago. I'm on Windows, using as my font, default size, no zoom.
Caused by
Change:
public setHypertextValidationCallback() { } } <ins> class TestURI extends URI { constructor(private _fakePath: string) { super(); }; get fsPath(): string { return this._fakePath; } } class TestWorkspace implements IWorkspace { resource: URI; constructor(basePath: string) { this.resource = new TestURI(basePath); } } </ins> suite('Workbench - TerminalLinkHandler', () => { suite('localLinkRegex', () => { test('Windows', () => {

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with "./". Many build systems and tools output file paths relative to the directory the command was run, without the leading "./", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in "" Is there a reason why relative paths of this form (e.g. no leading "./") are not included?
The reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.
I'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:
Nice. I'll write a PR...
That would be awesome :+1:
Fixed in
Change:
*--------------------------------------------------------------------------------------------*/ .monaco-editor .sticky-line { <del> color : var(--vscode-editorLineNumber-foreground); overflow : hidden; white-space : nowrap; display : inline-block; </del> <ins> color: var(--vscode-editorLineNumber-foreground); overflow: hidden; white-space: nowrap; display: inline-block; </ins> } .monaco-editor .sticky-line-number { <del> text-align : right; float : left; </del> <ins> text-align: right; float: left; </ins> } .monaco-editor .sticky-line-root { <del> background-color : inherit; overflow : hidden; white-space : nowrap; width : 100%; </del> <ins> background-color: inherit; overflow: hidden; white-space: nowrap; width: 100%; } .monaco-editor.hc-black .sticky-widget, .monaco-editor.hc-white .sticky-widget { border-bottom: 1px solid var(--vscode-contrastBorder); </ins> } .monaco-editor .sticky-line-root:hover { background-color: var(--vscode-editorStickyScrollHover-background); <del> cursor : pointer; </del> <ins> cursor: pointer; </ins> } .monaco-editor .sticky-widget { <del> width : 100%; box-shadow : var(--vscode-scrollbar-shadow) 0 3px 2px -2px; z-index : 11; background-color : var(--vscode-editorStickyScroll-background); </del> <ins> width: 100%; box-shadow: var(--vscode-scrollbar-shadow) 0 3px 2px -2px; z-index: 11; background-color: var(--vscode-editorStickyScroll-background); </ins> } .monaco-editor .sticky-widget.peek { <del> background-color : var(--vscode-peekViewEditorStickyScroll-background); </del> <ins> background-color: var(--vscode-peekViewEditorStickyScroll-background); </ins> }

Discussion:
Type: <bBug</bstick scroll to high contrast down in a file Bug There is no contrast between the stick scroll content and the normal editor content: ! Related VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-26T05:22:17.192Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
For verification: sticky scroll, switch to high-contrast and scroll down the file. should see a border on the bottom of the sticky scroll widget
I see it in dark theme but not light high contrast: !
Change:
const snippet = await new Promise<Snippet | undefined>((resolve, reject) => { const { lineNumber, column } = editor.getPosition(); <del> const { snippet, name, langId } = Args.fromUser(arg); </del> <ins> const { snippet, name, langId } = Args.fromUser(args[0]); </ins> if (snippet) { return resolve(new Snippet(

Discussion:
Type: <bBug</bIf I bind a snippet like so: before the last update, it would insert the snippet when I press the shortcut, but now it brings up the Snippet Selector. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-19T05:21:29.044Z) OS version: Darwin arm64 21.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (24)</summaryExtensionVersion ------ vscode-apollo1.19.11 vscode-tailwindcss0.8.6 better-toml0.3.2 npm-intellisense1.4.2 vscode-eslint2.2.6 vscode-quick-select0.2.9 prettier-vscode9.5.0 auto-rename-tag0.1.10 shell-format7.2.2 bash-ide-vscode1.14.0 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.22.1 remote-ssh0.85. remote-ssh-edit0.80.0 vscode-typescript-next4.8. prisma4.0.0 vscode-yaml1.9.1 rust-analyzer0.4.1132 vs-code-prettier-eslint5.0.3 code-settings-sync3.4.3 shellcheck0.19.5 vscode-lldb1.7.2 vscode-import-cost3.3.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
verified using the parameter. didn't try with one by , but imagine it works the same way ?
Change:
*--------------------------------------------------------------------------------------------*/ import * as DOM from '../../../../../../base/browser/dom.js'; <del> import { ICellViewModel } from '../../notebookBrowser.js'; </del> <ins> import { ICellViewModel, INotebookEditorDelegate } from '../../notebookBrowser.js'; </ins> import { CellContentPart } from '../cellPart.js'; export class CellDecorations extends CellContentPart { constructor( <ins> readonly notebookEditor: INotebookEditorDelegate, </ins> readonly rootContainer: HTMLElement, readonly decorationContainer: HTMLElement, ) {

Discussion:
Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width="981" alt="image" src=""I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width="980" alt="image" src=""It appears that the Code cells lost their yellow highlight.
Change:
const info = document.createElement('div'); const building = document.createElement('div'); <ins> const errorTitle = n => nls.localize('totalErrors', "{0} Errors", n); const warningTitle = n => nls.localize('totalWarnings', "{0} Warnings", n); const infoTitle = n => nls.localize('totalInfos', "{0} Infos", n); </ins> Dom.addClass(element, 'task-statusbar-item'); Dom.addClass(label, 'task-statusbar-item-label'); element.appendChild(label); <del> element.title = nls.localize('problems', "Problems"); </del> Dom.addClass(errorIcon, 'task-statusbar-item-label-error'); Dom.addClass(errorIcon, 'mask-icon');

Discussion:
Issue Type: <bFeature Request</bVSCode uses different conventions for the problem counters in the problems view and in the status bar. The problems view displays: 1 2 ... 999 1K 2K ... 10K+ and the tooltip shows the actual number. The status bar displays: for errors/warnings: 1 2 ... 99+ and the tooltip doesn't show the actual number. for infos: 1 2 ... (always the actual number), the tooltip doesn't show the actual number. <img width="118" alt="problems-view" src="https://user-"<img width="108" alt="status-bar" src="https://user-"VS Code version: Code 1.21.0 (, 2018-03-07T10:54:22.798Z) OS version: Darwin x64 17.4.0 <!-- generated by issue reporter --
assigning to you. I personally would adopt the status bar to the problems view. Everything over 99 is not very informative anyways.
Change:
assert.deepEqual(['2', '3', '1'], toArray(testObject)); }); <ins> test('previous returns null if the current position is the first one', () => { const testObject = new HistoryNavigator(['1', '2', '3']); testObject.first(); assert.deepEqual(testObject.previous(), null); }); test('previous returns object if the current position is not the first one', () => { const testObject = new HistoryNavigator(['1', '2', '3']); testObject.first(); testObject.next(); assert.deepEqual(testObject.previous(), '1'); }); test('next returns null if the current position is the last one', () => { const testObject = new HistoryNavigator(['1', '2', '3']); testObject.last(); assert.deepEqual(testObject.next(), null); }); test('next returns object if the current position is not the last one', () => { const testObject = new HistoryNavigator(['1', '2', '3']); testObject.last(); testObject.previous(); assert.deepEqual(testObject.next(), '3'); }); </ins> test('clear', () => { const testObject = new HistoryNavigator(['a', 'b', 'c']); assert.equal(testObject.previous(), 'c');

Discussion:
In the debug console, evaluate something, then 3 times. Press up, get Press up again, get again Press up again, get the previous history entry Seems like it always reduces down to 2 entries, or there might be something else weird going on
Oh wait, this is in vscode right?
We are de-duplicating history entries which makes sense for me. This is designed behavior What is the use case of seeing 3 times in history?
The bug is that I see it twice, when I should see it once
I can not repro. What are you doing differnetly than me in this gif Please note that I pressed up only two times at the end. Thus is only once in history !
Hmm, extra steps Execute things as above Press up to go through history, it works Press down to go back Press down a couple extra times - I did this because I was expecting to get back to an empty input if I press down Then, I press up on and nothing happens, it's still on !
Ok, the issue is when you reach the end of history up / down take an extra hit to get the previous or the next one. Duplication is not related. Renaming this issue. I am open for PRs that fix this Code pointer Probably the has an issue at the end of history
Hello. I would like to contribute on this if you are open. I will submit a PR as soon as I fix it :)
To verify: debugging, open debug console , then evaluate sure pressing up gets you all the way back to the end of history in the debug console input sure pressing down gets you immieadly to the previous history element. Thus no duplicatino happens
Change:
} async function renameWithQuickPick(c: ITerminalServicesCollection, accessor: ServicesAccessor, resource?: unknown) { <del> const instance = getResourceOrActiveInstance(c, resource); </del> <ins> let instance: ITerminalInstance | undefined = resource as ITerminalInstance; if (!instance) { instance = getResourceOrActiveInstance(c, resource); } </ins> if (instance) { const title = await accessor.get(IQuickInputService).input({ value: instance.title,

Discussion:
Hi, The terminal option is not deleting and terminal option is not renaming correctly in command palette. Version: Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314Edition: Version: OS build: : Id: Description: Fluent product icons for Visual Studio Code Version: 0.0.18 Publisher: Miguel Solorio : Id: Description: Material Design Icons for Visual Studio Code Version: 4.30.1 Publisher: Philipp Kief Vscode. internal terminals. command palatte type to list terminals. to a terminal using delete icon button. to a terminal using rename icon button. corresponding terminal on clicking . corresponding terminal on clicking . not deleted ( clicking did nothing ). last terminal in the list of terminals instead of corresponding terminal. error when tried to delete terminal: ! Also, can we change the rename terminal icon to codicon. It would be much easier to understand than codicon.
works for me but I can repro not working.
Hi, let me explain the terminal rename issue again Steps to reproduce the issue 3 terminals ! 2nd terminal rename option ! terminal name from to ! but After rename, 3rd terminal is renamed instead of 2nd terminal ! My VSCode settings:
Change:
/** * Sequences pioneered by iTerm. */ <del> ITerm = 1337 </del> <ins> ITerm = 1337, SetCwd = 7, SetWindowsFriendlyCwd = 9 </ins> } /**

Discussion:
Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
On Windows Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one () Code pointer:
I'm taking this.
sounds good
I've just submitted the PR. You can check it anytime you want.
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .
Change:
}).toString(); <del> const blob = new Blob([`${jsSrc};ncomputeBaseline();`], { type: 'application/javascript' }); </del> <ins> const blob = new Blob([`(${jsSrc})();`], { type: 'application/javascript' }); </ins> const blobUrl = URL.createObjectURL(blob); const worker = createBlobWorker(blobUrl, { name: 'perfBaseline' });

Discussion:
It looks like the move of the fibonacci numbers to a web worker fails on In the console I see: The code points to this: <img width="814" alt="image" src="https://user-"I found this only because the web perf bot no longer finishes, waiting for the startup timings console log message that we do here: I cannot step over this method, it seems to throw.
also happens in desktop
Looks like minification removes the function name and therefore it fails <img width="831" alt="Screenshot 2023-01-27 at 11 45 10" src="https://user-"
I confirm the error on Windows, for the latest Insiders and Exploration builds.
Works
Change:
"config.detectSubmodules": "Controls whether to automatically detect git submodules.", "colors.added": "Color for added resources.", "config.detectSubmodulesLimit": "Controls the limit of git submodules detected.", <ins> "config.syncRebase": "Synchronize changes using rebase.", </ins> "colors.modified": "Color for modified resources.", "colors.deleted": "Color for deleted resources.", "colors.untracked": "Color for untracked resources.",

Discussion:
Currently the sync icon will sync with pull and merge, which results in undesirable (in my case) merge commits. ! It would be helpful if there was a "Sync with rebase" option for clicking this icon. I see a PR was performed to add Sync (Rebase) command (, though I still don't even see this command in the git menu for 1.23.1 today?), but this does not apply to clicking the actual icon. A setting to change its default value would be great.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.479 --<!-- potentialduplicatescomment --
shouldn't the setting text say something like instead of saying . If a branch is already configured to use rebase by default this setting has no effect (i.e. unchecking the box does not use merge)
Change:
export interface ITerminalProcessFactory { create(env: { [key: string]: string }): cp.ChildProcess; } <ins> if (platform.isLinux) { const file = '/etc/os-release'; fileExists(file).then(exists => { if (!exists) { return; } readFile(file).then(b => { const contents = b.toString(); if (contents.indexOf('NAME=Fedora') >= 0) { isFedora = true; } }); }); } export let isFedora = false; </ins>  No newline at end of file

Discussion:
VSCode Version: Code 1.17.0 (, 2017-10-04T23:33:45.303Z) OS Version: Linux x64 4.12.0-2-amd64 Extensions: Extensions are disabled Steps to Reproduce: window doesn't look well ! <!-- Launch with to check. --Reproduces without extensions: Yes/No
Here is how my integrated terminal looks like !
what distro are you using? I've seen Fedora acts a little odd with font rendering both in the editor and the terminal. see
I'm experiencing the same issue on Fedora 26 / Gnome 3.24.2 / VSCode version 1.17.0. The only affected component is the terminal so far, other fonts look good. The issue is not present in VSCode 1.16.1.
i am using debian 9 / xfce4 / VSCode version 1.17.0
For Fedora right now the workaround is to use a different font:
it works like a charm. Thanks a lot :)
Thks now looks very well.
Pushed to master and release/1.17
Not sure I've got issue right, but looks like custom fonts such as are not working after last update. Before update everything worked fine. Wouldn't say it is too important, but would be nice to get it back. Linux Mint 18.2 x64. !
Same issue here with Fira Code font Ubuntu 17.04 x64
yes also here FiraCode looks weird now. macOS 10.13
same here as after 1.17.1 update it looks weird now with SF Mono on macOS. ! it looks weird, because before 1.17.1 it was awesome
This is the issue tracking the blurry text in 1.17.1
Change:
}, 'debug.internalConsoleOptions': INTERNAL_CONSOLE_OPTIONS_SCHEMA, 'debug.openDebug': { <del> enum: ['neverOpen', 'openOnSessionStart', 'openOnFirstSessionStart'], </del> <ins> enum: ['neverOpen', 'openOnSessionStart', 'openOnFirstSessionStart', 'openOnDebugBreak'], </ins> default: 'openOnFirstSessionStart', description: nls.localize('openDebug', "Controls whether debug view should be open on debugging session start.") },

Discussion:
Currently if I start my App with another View than Debug View open and the debugger breaks because of a break point or an exception I have to manually switch to the debug view. It would be incredible if I could set an option to display the debug view in that cases automatically Thanks for your great Work!
This is a fair feature request. If we get more users asksing for this we would be willing to accept a PR that fixes this. Thanks
Why only as PR? I guess it will be only a very small change but I'm not a Typescript dev and have no idea about the internal structure of VS Code. For your team this should be a quick fix.
Because we encourage people to be invovled in our open source project Code pointer The following setting should be updated to also cover this case  to also have the following option "openOnDebugBreak" No typescript knowledge is needed for this PR fyi
Change:
text: string, expected: (Pick<ITerminalSimpleLink, 'text'> & { range: [number, number][] })[] ) { <del> await assertLinkHelper(text, expected, detector, type); </del> <ins> const race = await Promise.race([ assertLinkHelper(text, expected, detector, type).then(() => 'success'), timeout(2).then(() => 'timeout') ]); strictEqual(race, 'success', `Awaiting link assertion for "${text}" timed out`); </ins> } setup(() => {

Discussion:
These flakes are a bit odd, not sure what could cause them and the failures seem a bit all over the place
I some logs that will help with debugging future failures. Closing in the meantime until a new one pops up.
Change:
this.onExitCallback(this); } }); <del> this.toDispose.push(DOM.addDisposableListener(this.parentDomElement, 'mousedown', (event) => { // Drop selection and focus terminal on Linux to enable middle button paste when click // occurs on the selection itself. if (event.which === 2 && platform.isLinux) { this.focus(true); } })); this.toDispose.push(DOM.addDisposableListener(this.parentDomElement, 'mouseup', (event) => { if (event.which !== 3) { this.focus(); } })); this.toDispose.push(DOM.addDisposableListener(this.parentDomElement, 'keyup', (event: KeyboardEvent) => { // Keep terminal open on escape if (event.keyCode === 27) { event.stopPropagation(); } })); </del> this.xterm.open(this.terminalDomElement);

Discussion:
Currently events are handled in each terminal instance, this means that event handlers go off for each terminal instances for an event on the terminal panel.