jiebi/CodeConvo huggingface dataset:
Change:
if (/Please,? commit your changes or stash them/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.DirtyWorkTree; err.gitTreeish = treeish; <ins> } else if (/You are on a branch yet to be born/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.BranchNotYetBorn; </ins> } throw err;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Steps to Reproduce: a existing folder in vscode sure the folder has files "init repository" buttun in vscode a change (delete a file) in vscode source control the error: ! I would suggest popping up a dialog asking the user if he/she wants to create a branch first.
Change:
containerIcon: icon || viewContainer?.icon, containerTitle: item.contextualTitle || viewContainer?.name, canToggleVisibility: true, <del> canMoveView: true, </del> <ins> canMoveView: viewContainer?.id !== REMOTE, </ins> treeView: type === ViewType.Tree ? this.instantiationService.createInstance(CustomTreeView, item.id, item.name) : undefined, collapsed: this.showCollapsed(container) || initialVisibility === InitialVisibility.Collapsed, order: order,

Discussion:
1) install the Remote-SSH and the Codespaces extension 2) Open the remote explorer 3) Select SSH Targets 3) Grab the SSH Targets view and drag it onto the activity bar -the drop down still shows both entries but without any view -the dropped view only shows SSH Targets (as expected) and so there is no way to get to Codespaces anymore 4) Use the SSH Targets view and move it back into the Remote Explorer -two views, one of them a zombie
Looks like somehow the remote explorer got enable for moving views again...
Change:
containerIcon: icon || viewContainer?.icon, containerTitle: item.contextualTitle || viewContainer?.name, canToggleVisibility: true, <del> canMoveView: true, </del> <ins> canMoveView: viewContainer?.id !== REMOTE, </ins> treeView: type === ViewType.Tree ? this.instantiationService.createInstance(CustomTreeView, item.id, item.name) : undefined, collapsed: this.showCollapsed(container) || initialVisibility === InitialVisibility.Collapsed, order: order,

Discussion:
Issue Type: <bBug</b! VS Code version: Code - Insiders 1.50.0-insider (, 2020-09-12T00:56:22.923Z) OS version: Darwin x64 19.4.0 Remote OS version: Linux x64 4.19.76-linuxkit <details<summarySystem Info</summary </details<!-- generated by issue reporter --
This is the order that it's contributed in. Do you think that the settings UI should sort them alphabetically like they are in the suggest widget, or leave them in contribution order, in case that is important? Looking through some enum settings, some seem to order the options in an intentional way, like with the default first, or the simpler options first. Some are random or are sorted. I think I am inclined to display them in contributed order to keep this an option (and we can sort the encodings manually), but I'm not sure, what do you think?
It should be this order, same as the picker: ! The encodings are not sorted by name intentionally. But they are grouped by type and I guess that is not very visible in the settings editor.
Oh, got it. I've seen a few of these cases where it would make sense to display the enumDescription in the dropdown instead of the actual value. It doesn't make sense in general but it would be cool to provide an option for settings to opt into that, what do you think?
Yeah I think it would make a lot of sense in this case
I think we should add an option to the schema contribution for this but I have no clue what to call it
If the dropdown list will now display the enumDescriptions, should the description footer on the list show the value to be set? Should the collapsed dropdown control show the selected value or its enumDescription?
Yes, I'd say just swap them I think it should show the enumDescriptioni
I'll start working on this issue. Thanks for your help.
Now this will show with the key in the description area in square brackets. But it would look much nicer to match the editor encoding picker, so I opened for that.
Change:
import { ResourceLabel, IResourceLabel } from 'vs/workbench/browser/labels'; import { TAB_ACTIVE_FOREGROUND, TAB_UNFOCUSED_ACTIVE_FOREGROUND } from 'vs/workbench/common/theme'; import { EventType as TouchEventType, GestureEvent, Gesture } from 'vs/base/browser/touch'; <del> import { addDisposableListener, EventType, EventHelper, Dimension } from 'vs/base/browser/dom'; </del> <ins> import { addDisposableListener, EventType, EventHelper, Dimension, isAncestor } from 'vs/base/browser/dom'; </ins> import { IAction } from 'vs/base/common/actions'; import { CLOSE_EDITOR_COMMAND_ID } from 'vs/workbench/browser/parts/editor/editorCommands'; import { Color } from 'vs/base/common/color';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: Codespaces OS Version: iPadOS 14 Steps to Reproduce: any repo in Codespaces off any file touch (not mouse) to click on any button at the top right corner (git, duplicate tab, close file, dropdown ellipsis) you click or it fires the command, showing the Command Palette (just like when you click on regular tabs when visible) you click it just blinks the dropdown items, and the same command in the Command Palette <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Just to clarify: we currently do not fully support touch devices, so it may well be that the experience is buggy. Other related issues:
no problem, I understand I just wanna report the issue, because Codespaces could be a game changing for me, if iPadOS is fully supported. Thank you
I think this should be fixable, marking as help wanted if someone wants to chime in. The code that opens the command palette is probably doing something wrong: or
looks like this is from the code you : This is registered on the title container here: So it will open whenever you tap anywhere into the title area, including actions. My first idea was to register this listener simply on the same element as we do here: But that somehow was not working. I attempted a fix via
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
if (this.groupsService.count === 1) { this.groupsService.addGroup(this.groupsService.groups[0], GroupDirection.LEFT, { activate: true }); <del> let gettingStartedSize: number; if (fullSize.width > 1600) { gettingStartedSize = 800; } else if (fullSize.width > 800) { gettingStartedSize = 400; } else { gettingStartedSize = 350; } </del> <ins> const gettingStartedSize = Math.floor(fullSize.width / 2); </ins> const gettingStartedGroup = this.groupsService.getGroups(GroupsOrder.MOST_RECENTLY_ACTIVE).find(group => (group.activeEditor instanceof GettingStartedInput)); this.groupsService.setSize(assertIsDefined(gettingStartedGroup), { width: gettingStartedSize, height: fullSize.height });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Python extension we use in our walkthrough to open a Python file while user is working with the walkthrough: . occupies more than half of the space and requires adjusting the column again: ! this to bicep extension where it opens up nicely: ! They used their own command: which we cannot use in the Python extension. We have to rely on VSCode command itself: , so a python file can be opened without waiting for extension to activate. More context: cc/
I am not sure who owns this today, I think Logan?
I can verify this occupies half space now, although I think it should be opened to the right side like bicep as the main context is still getting started.
Verified. I agree it should be opened to the right side,
Could you please open another issue for that? Thanks.
Change:
"statusBarItem.remoteBackground": "#16825D", "sideBarSectionHeader.background": "#0000", "sideBarSectionHeader.border": "#61616130", <del> "tab.lastPinnedBorder": "#81818130", </del> <ins> "tab.lastPinnedBorder": "#61616130", </ins> "notebook.focusedCellBackground": "#c8ddf150", "notebook.cellBorderColor": "#dae3e9", "notebook.outputContainerBackgroundColor": "#c8ddf150"

Discussion:
The grey used as the pinned tab separator could be a bit stronger and I suggest it is the same grey as for the View separators. !
Yeah, this color is pretty much randomly selected. would you be interested in picking colors for our default themes? Just today I pushed to add the color to our default themes but I did not really spend a lot of time thinking about which color fits best. Most often I picked the border color of the peek view inside the editor. The color key is
Are we sure we don't want to push this as a default for all themes? Because out of the box it's nearly impossible to tell the difference in other themes. Like below, can you tell which files are pinned? !
yeah if you can find a good base color and rule for it, I am all up for it
Change:
import { StartDebugQuickAccessProvider } from 'vs/workbench/contrib/debug/browser/debugQuickAccess'; import { DebugProgressContribution } from 'vs/workbench/contrib/debug/browser/debugProgress'; import { DebugTitleContribution } from 'vs/workbench/contrib/debug/browser/debugTitle'; <ins> import { Codicon } from 'vs/base/common/codicons'; </ins> class OpenDebugViewletAction extends ShowViewletAction { public static readonly ID = VIEWLET_ID;

Discussion:
Today I see no debug icon in the activity bar.
Yeah, I also can't see !
Removed in Looks like not longer in font and has different character code but it's actually in font
Sorry about that, I must've copied the wrong unicode character when I was cleaning up the unused debug icons. Looking into PR right now.
Change:
strictEqual(list.statuses[1].icon!.id, Codicon.zap.id, 'zap~spin should have animation removed only'); }); <ins> test('add should fire onDidRemoveStatus if same status id with a different object reference was added', () => { const eventCalls: string[] = []; list.onDidAddStatus(() => eventCalls.push('add')); list.onDidRemoveStatus(() => eventCalls.push('remove')); list.add({ id: 'test', severity: Severity.Info }); list.add({ id: 'test', severity: Severity.Info }); deepStrictEqual(eventCalls, [ 'add', 'remove', 'add' ]); }); </ins> test('remove', () => { list.add({ id: 'info', severity: Severity.Info }); list.add({ id: 'warning', severity: Severity.Warning });

Discussion:
Just saw , this goes against the design. It's meant to only add the status if it doesn't already exist, if the status changed then it should use a different id and/or remove the old status first.
I'm not clear on the solution. There're a limited number of Terminal Status IDs: In this case status ID hasn't changed, it's still , only the description which comes with it has updated.
working on it, I'll send a PR to you in a bit
Validate still doesn't happen.
Change:
return result; } <del> export class LazyBreakpointEditorContribution extends Disposable implements IBreakpointEditorContribution { private _contrib: IBreakpointEditorContribution | undefined; constructor(editor: ICodeEditor, @IInstantiationService instantiationService: IInstantiationService) { super(); const listener = editor.onDidChangeModel(() => { if (editor.hasModel()) { listener.dispose(); this._contrib = this._register(instantiationService.createInstance(BreakpointEditorContribution, editor)); } }); } showBreakpointWidget(lineNumber: number, column: number | undefined, context?: BreakpointWidgetContext | undefined): void { this._contrib?.showBreakpointWidget(lineNumber, column, context); } closeBreakpointWidget(): void { this._contrib?.closeBreakpointWidget(); } getContextMenuActionsAtPosition(lineNumber: number, model: ITextModel): IAction[] { return this._contrib?.getContextMenuActionsAtPosition(lineNumber, model) ?? []; } } class BreakpointEditorContribution implements IBreakpointEditorContribution { </del> <ins> export class BreakpointEditorContribution implements IBreakpointEditorContribution { </ins> private breakpointHintDecoration: string | null = null; private breakpointWidget: BreakpointWidget | undefined;

Discussion:
With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:
Replacing me with who took over quick pick.
Change:
resolved "https://registry.yarnpkg.com/request-light/-/request-light-0.5.4.tgz#497a98c6d8ae49536417a5e2d7f383b934f3e38c" integrity sha512-t3566CMweOFlUk7Y1DJMu5OrtpoZEb6aSTsLQVT3wtrIEJ5NhcY9G/Oqxvjllzl4a15zXfFlcr9q40LbLVQJqw== <del> vscode-json-languageservice@^4.1.9: version "4.1.9" resolved "https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-4.1.9.tgz#fb48edc69e37167c3cafd447c3fa898052d87b61" integrity sha512-kxNHitUy2fCxmP6vAp0SRLrUSuecUYzzxlC+85cC3jJlFHWmvtCJOzikC+kcUnIdls9fQSB8n0yHs8Sl6taxJw== </del> <ins> vscode-json-languageservice@^4.1.10: version "4.1.10" resolved "https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-4.1.10.tgz#5d5729fc4f3e02f41599e0104523a1877c25f0fb" integrity sha512-IHliMEEYSY0tJjJt0ECb8ESx/nRXpoy9kN42WVQXgaqGyizFAf3jibSiezDQTrrY7f3kywXggCU+kkJEM+OLZQ== </ins> dependencies: jsonc-parser "^3.0.0" vscode-languageserver-textdocument "^1.0.1"

Discussion:
Version: 1.62.2 (user setup) Commit: Date: 2021-11-11T20:56:38.428Z Electron: 13.5.2 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0. Have the settings file add a syntax error (e.g. at the endno errors reported JSON language server log says
Fails on a regular expression which is part of the validation schema for the setting does not need to be escaped With the changes for we now create regular expression with flag which is more restrictive regarding unnecessary escapes.
The fix is to a.) handle malformed regular expression b.) if creating a regular expression with fails, try a second time without
Closing for verification since it looks like this is in the release branch.
Change:
import { ILogService } from 'vs/platform/log/common/log'; import { IHostService } from 'vs/workbench/services/host/browser/host'; import { DeferredPromise } from 'vs/base/common/async'; <del> import { ISpeechService, ISpeechProvider, HasSpeechProvider, ISpeechToTextSession, SpeechToTextInProgress, IKeywordRecognitionSession, KeywordRecognitionStatus, SpeechToTextStatus } from 'vs/workbench/contrib/speech/common/speechService'; </del> <ins> import { ISpeechService, ISpeechProvider, HasSpeechProvider, ISpeechToTextSession, SpeechToTextInProgress, IKeywordRecognitionSession, KeywordRecognitionStatus, SpeechToTextStatus, speechLanguageConfigToLanguage, SPEECH_LANGUAGE_CONFIG } from 'vs/workbench/contrib/speech/common/speechService'; </ins> import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

Discussion:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked
Change:
import { isWeb, isIOS, isMacintosh, isWindows } from 'vs/base/common/platform'; import { createMetaElement } from 'vs/base/browser/dom'; import { isSafari, isStandalone } from 'vs/base/browser/browser'; <ins> import { selectionBackground } from 'vs/platform/theme/common/colorRegistry'; </ins> registerThemingParticipant((theme, collector) => {

Discussion:
open quick input or the find widget type and select some text observe that the selection is not rendered (this happened with this insiders update, I'm quite sure it was working in yesterday's insiders) https://user-
So it looks like the use of CSS variables in some cases is dangerous. Here explains a bit more. My fix is to revert back to how it was for
Change:
display: none; } <del> .scm-view .scm-input .scm-editor .scm-editor-toolbar.disabled .action-item { cursor: default; } .scm-view .scm-input .scm-editor .scm-editor-toolbar.disabled .action-label:hover, .scm-view .scm-input .scm-editor .scm-editor-toolbar.disabled .action-item.monaco-dropdown-with-primary:hover { background-color: unset; } </del> .scm-view .scm-input .scm-editor .scm-editor-toolbar.scroll-decoration { box-shadow: var(--vscode-scrollbar-shadow) 0 6px 6px -6px inset; }

Discussion:
keyboard focus to SCM generate commit message button the nice blue outline being rendered hover over the button. The outline is no longer visible
Is the button enabled or disabled? I am asking as from what I can tell the pattern is that for enabled buttons the focus outline is not persisted when the button is hovered over. Disabled buttons persist the focus outline as they do not have a hover.
Reopening as I implemented the wrong fix.
The button is enabled. I noticed that in the Find Widget for example the focus outline is persisted on hover. Which imho is the natural thing to do.
With the PR linked above, the behaviour will be consistent with the rest of the actions. We can start a separate conversation whether we want to update all actions to keep the focus border on hover.
Change:
import { Color } from 'vs/base/common/color'; import { trim } from 'vs/base/common/strings'; import { addDisposableListener, EventType, EventHelper, Dimension } from 'vs/base/browser/dom'; <del> import { MenubarPart } from 'vs/workbench/browser/parts/menubar/menubarPart'; </del> <ins> import { MenubarControl } from 'vs/workbench/browser/parts/titlebar/menubarControl'; </ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { template, getBaseLabel } from 'vs/base/common/labels'; import { IUriDisplayService } from 'vs/platform/uriDisplay/common/uriDisplay';

Discussion:
I like how menu and title part are now merged, but I feel it could merge even more to reflect the structure in the DOM: move all of into (rename to and merge the CSS into the existing one) rename to something like do not extend from in , since this is no longer a workbench managed part
Change:
"--vscode-statusBarItem-errorForeground", "--vscode-statusBarItem-focusBorder", "--vscode-statusBarItem-hoverBackground", <ins> "--vscode-statusBarItem-hoverForeground", </ins> "--vscode-statusBarItem-prominentBackground", "--vscode-statusBarItem-prominentForeground", "--vscode-statusBarItem-prominentHoverBackground",

Discussion:
Hi. i am creating a theme pack for VSCode. I have discovered that there is a to customize the background color of a status bar hovered item but there is no option to customize the color of the hovered item foreground color. Something like !
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Yeah there seems to be colors like but not the relevant foreground colors. //cc
Added with values defaulting to in . You'll be able to set that manually in your or in the theme itself.
nice, but we do have more hover backgrounds: <img width="725" alt="image" src=""I am not sure about the compact one but maybe prominent one needs it too?
Added via