jiebi/CodeConvo huggingface dataset:
Change:
// to hang in resolver extensions if (!this.shellLaunchConfig.customPtyImplementation && this._configHelper.config.shellIntegration?.enabled && !this.shellLaunchConfig.executable) { const os = await this._processManager.getBackendOS(); <del> this.shellLaunchConfig.executable = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os })).path; </del> <ins> const defaultProfile = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os })); this.shellLaunchConfig.executable = defaultProfile.path; this.shellLaunchConfig.args = defaultProfile.args; this.shellLaunchConfig.icon = defaultProfile.icon; this.shellLaunchConfig.color = defaultProfile.color; this.shellLaunchConfig.env = defaultProfile.env; </ins> } await this._createProcess();

Discussion:
reported by
becomes undefined here
to verify: set your default profile to null add something to your such as an statement create a terminal ensure your file has been run
Change:
import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { IProgressService, ProgressLocation } from 'vs/platform/progress/common/progress'; <ins> import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; </ins> const targetMenus = [ MenuId.EditorContextShare,

Discussion:
Testing My extension's provider is not receiving the within the passed to its I think this's caused by this -

Testing takes a but doesn't respect the selector's . I created an extension which uses Share Provider API, but its share contribution wasn't being invoked. It seems the language isn't being passed - see 3rd arg being an empty string .
I observe the same, using: registers the share provider, however as soon as I add a language, this is no longer the case
Change:
const no = localize('no', "No"); const answer = await window.showInformationMessage(localize('fork', "You don't have permissions to push to '{0}/{1}' on GitHub. Would you like to create a fork and push to it instead?", owner, repo), yes, no); <del> if (answer === no) { </del> <ins> if (answer !== yes) { </ins> return; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.66.2 (Universal) Commit: Date: 2022-04-11T07:49:20.994Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Darwin x64 20.5.0 Steps to Reproduce: push a commit to a repo that user don't have permission message modal will show to ask user if they want to create a fork repo button create a fork for you user don't want to creat a fork, that's why they close it. <img width="504" alt="Screen Shot 2022-04-29 at 11 18 18 PM" src="https://user-"I check the code, looks like github extention only check  to return. What I suggest If you think this were resonable, I will make a PR for it
Change:
constructor( @IContextKeyService private contextKeyService: IContextKeyService, @ILabelService private readonly labelService: ILabelService, <del> @IQuickInputService private quickInputService: IQuickInputService </del> <ins> @IQuickInputService private quickInputService: IQuickInputService, @ICodeEditorService private readonly codeEditorService: ICodeEditorService, </ins> ) { this.providerCount = ShareProviderCountContext.bindTo(this.contextKeyService); }

Discussion:
Testing My extension's provider is not receiving the within the passed to its I think this's caused by this -

Testing takes a but doesn't respect the selector's . I created an extension which uses Share Provider API, but its share contribution wasn't being invoked. It seems the language isn't being passed - see 3rd arg being an empty string .
I observe the same, using: registers the share provider, however as soon as I add a language, this is no longer the case
Change:
font-size: 13px; border-radius: 0; min-width: 160px; <del> max-width: 500px; </del> <ins> max-width: 80vw; </ins> z-index: 40; display: block; width: 100%;

Discussion:
Last year a change was to the source actions input which a max-width property The problem with this is that has no effect, unless the width of the input is over 500px. We were using this source action with an extension which looked up imports to add, and due to using a monorepo these had some quite long paths. ! Rather than using a fixed 500px max width, what would you reckon to using something that would allow users to make use of wider screens - we have been testing a patch using - since this is a max width, rather than the width always used, this width restriction only comes into effects for longer imports, so for shorter imports, this is a no-op, but for larger imports, it expands into the available space, rather than truncates. Screenshot with larger input. !
Change:
return; } <del> const previewValue = this.getPreviewValue(textEditorModel, startLineNumber); </del> <ins> const previewValue = this.getPreviewValue(textEditorModel, startLineNumber, result); </ins> let wordRange: Range; if (result.originSelectionRange) {

Discussion:
Issue Type: <bBug</bGitHub Pull Request extension repo Hover on Press CMD key ! Ideally we should be able to implementation of at the top and definition at the bottom, but :( VS Code version: Code - Insiders 1.34.0-insider (, 2019-04-09T05:14:40.620Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (50)</summaryExtensionVersion ------ vscode-apollo1.5.2 markdown-emoji0.0.7 solargraph0.19.6 npm-intellisense1.3.0 vscode-svgviewer2.0.0 vscode-markdownlint0.26.0 vscode-eslint1.8.2 xml2.4.0 gitlens9.6.0 remotehub0.2.0 tsl-problem-matcher0.0.4 EditorConfig0.13.0 tslint1.0.43 vscode-npm-script0.3.5 vsc-material-theme2.8.2 prettier-vscode1.8.1 flow-for-vscode1.1.1 vscode-pull-request-github-insiders1.98.0 ocaml0.6.43 beautify1.4.11 references-plusplus0.0.5 graphql-for-vscode1.13.0 dotenv1.0.1 theme-monokai-pro-vscode1.1.12 vscode-azurefunctions0.16.0 vscode-language-pack-zh-hans1.33.2 python2019.3.6558 azure-account0.8.1 cpptools0.22.1 Go0.9.2 powershell1.12.0 vscode-typescript-tslint-plugin1.0.0 wordcount0.1.0 vsliveshare1.0.18 debugger-for-chrome4.11.3 debugger-for-ios-web0.1.2 vetur0.18.1 subtitles-editor1.0.2 vscode-versionlens0.22.0 material-icon-theme3.7.0 seti-icons0.1.3 ruby0.22.3 smartpaste0.0.3 toggle0.0.1 vscode-fuzzsymbols0.0.1 sass-indented1.5.1 rust0.6.1 sourcekit-lsp0.0.

1 vscode-lldb1.2.2 vscode-intelli-nav0.0.6 (12 theme extensions excluded) </details<!-- generated by issue reporter --
adding since I believe the implementation peak when holding CMD is determined by VS Code
Yeah, today we count matching bracket (up to a low maximum of lines) to compute the preview. not sure if TypeScript provides  but that would certainly help here
Ok, we do set the but it is just the range of the identifier (). I've opened to track having this information returned from TypeScript
Planning to do work to support API proposed by in June. We would not actually ship this until TS 3.6 however
To verify, please make sure you are using TS 3.6 in your workspace and follow original instructions in the github PR extension's codebase
Change:
import { IDialogService, IFileDialogService } from 'vs/platform/dialogs/common/dialogs'; import { mnemonicButtonLabel } from 'vs/base/common/labels'; import { Query } from 'vs/workbench/contrib/extensions/common/extensionQuery'; <del> import { Promises } from 'vs/base/common/async'; </del> import { EditorExtensions } from 'vs/workbench/common/editor'; import { WORKSPACE_TRUST_EXTENSION_SUPPORT } from 'vs/workbench/services/workspaces/common/workspaceTrust'; import { ExtensionsCompletionItemsProvider } from 'vs/workbench/contrib/extensions/browser/extensionsCompletionItemsProvider';

Discussion:
Type: <bBug</ban activated extension. Extensions view to see it. a newer VSIX of this extension onto the view. a "Restart Extension" button on the view but also a notification advising a reload of VS Code and offering a "Reload Now" button. ! VS Code version: Code 1.89.0 (, 2024-05-01T02:09:22.859Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Yes, it still happens in 1.89.1
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
<string>#9CDCFE</string> </dict> </dict> <ins> <dict> <key>name</key> <string>CSS property value</string> <key>scope</key> <string>css.support.property-value, css.constant.rgb-value</string> <key>settings</key> <dict> <key>foreground</key> <string>#CE9178</string> </dict> </dict> </ins> </array> </dict> </plist>

Discussion:
Before Dec update: ! After: ! As you can see, while the property names are highlighted, the values are the same whether it is valid or not. The data is in the file, it is just not getting read, or the colour is no longer set, for whatever reason.
We changed the default themes to be more consistent with Visual studio where css attribute values are white (or red for string values) regardless if valid or not.
I think the validation if a value is correct or not should be done in a validator. Having this also in the tokenizer will make the tokenizer more complex and we will have to update on every spec change.
Marked as verified, which basically means it reverted to the previous behavior as the change was rejected.
The change was not rejected. It just needed extra changes in for SASS.
oh, I guess I wasn't seeing it because I was on the VS theme. I don't see CSS consistency with Sass on latest alpha: CSS ! Sass ! Less ! CSS ! Sass ! Less !
Looks like there's still an issue with functions then. Please open a new issue.
Adding back verified as the new issue is captured in
Change:
} public override render(container: HTMLElement): IDisposable { <ins> this.message.style.visibility = 'visible'; </ins> container.appendChild(this.message); return toDisposable(() => this.message.remove()); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.92.0 (Universal) Commit: Date: 2024-07-31T23:26:45.634Z Electron: 30.1.2 ElectronBuildId: Chromium: 124.0.6367.243 20.14.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.5.0 Steps to Reproduce: this snippet in the test-provider-sample project running the test, both the editor peek view and test result view do not render correctly. !
Sorry, this got lost in the shuffle of the call stack UI :(
Verification steps: out the of vscode-extension-samples into and F5 the "easy math" test in Open the error messages for all the tests that fail and verify they're all visible
Change:
const model = ref.object.textEditorModel; <del> const formatEdits = await getDocumentFormattingEditsUntilResult( </del> <ins> const formatEdits = await getDocumentFormattingEditsWithSelectedProvider( </ins> this.editorWorkerService, this.languageFeaturesService, model, <del> model.getOptions(), </del> <ins> FormattingMode.Silent, </ins> token );

Discussion:
Related: Looking into reports of X formatter being used instead of Y in various flows. Looking at both on save and on execution formatting participants, one common point is that when is specifically being used, the intended formatter is applied as expected. Some early digging is pointing to a use of instead of , so will be working out a fix there. Will update this thread as is relevant.
do you have some minimal verif steps?
Verification Steps: Install Black Formatter + Ruff Create with only the following:create notebook with a single code cell, and contents In Stable () Save Notebook Black formatter runs =nothing changes Ruff formatter runs =Single quotations turned to double quotations () In Insiders () Save Notebook ONLY Black formatter runs =nothing changes

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a "Formatting with autopep8" message in the status bar even though that formatter extension isn't installed! However manually triggering "Format Cell" does use black.
Change:
isEnabled(): boolean; focus(fromRight?: boolean): void; // TODO@isidorn what is this? blur(): void; <ins> showHover?(): void; </ins> } export interface IActionViewItemProvider {

Discussion:
This ask is from the Copilot team in response to feedback they've received. When something is represented via only an icon, and is focused via keyboard, we should automatically focus the tooltip.
cc
related
we would also want to do this for all toolbars <img width="202" alt="Screenshot 2023-11-01 at 10 12 16 AM" src=""
Just out of curiosity, what does "focus the tooltip mean"? Does it mean "make the tooltip visible"? (sorry- the language is a bit confusing. tooltips are not actually focusable, right?)
yes I think meant to show the hover, not focus it as that would break left/right navigation.
Yep, it just shows the hover, doesn't focus it.
Change:
}; } <ins> private _tokenToPlainText(token: Token): string { if (token.children) { return token.children.map(x => this._tokenToPlainText(x)).join(''); } switch (token.type) { case 'text': case 'emoji': case 'code_inline': return token.content; default: return ''; } } </ins> private _addLinkRenderer(md: MarkdownIt): void { const original = md.renderer.rules.link_open;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0.0 OS Version: Windows 10 build .4598 Steps to Reproduce: a header with a raw HTML element HTML is included in markdown header anchors ( is included!)
Note: links without the HTML tag work in editor mode only
This is for path completions, right? Seems to work fine for me ! Does this reproduce in the with all ?
I'm not referring to autocompletion, but what I mean is for the anchor links to work in preview mode (editor mode is fine) they have to include raw HTML tags I.e., the attribute values generated for headers include raw HTML tags I tested it in with all extensions disabled and same result, but still I will test it in insiders build
tested at (clean), same results
Change:
assert.equal(variables[0].extHostId, parent.extHostId, 'ExtHostId should match the parent since we will use it to get the real children'); }); <ins> test('Get children for very large list', async () => { const parent = { kind: 'variable', notebook: notebookModel, id: '1', extHostId: 1, name: 'list', value: '[...]', hasNamedChildren: false, indexedChildrenCount: 1_000_000 } as INotebookVariableElement; results = []; const groups = await dataSource.getChildren(parent); const children = await dataSource.getChildren(groups[99]); assert(children.length === 100, 'We should have a full page of child groups'); assert(!provideVariablesCalled, 'provideVariables should not be called'); assert.equal(children[0].extHostId, parent.extHostId, 'ExtHostId should match the parent since we will use it to get the real children'); }); </ins> test('Cancel while enumerating through children', async () => { const parent = { kind: 'variable', notebook: notebookModel, id: '1', extHostId: 1, name: 'list', value: '[...]', hasNamedChildren: false, indexedChildrenCount: 10 } as INotebookVariableElement; results = [

Discussion:
viewing a very long list in the variables viewer will not show all entries. debug variables view handles this with nested groups: <img width="231" alt="image" src=""
verification steps: the notebook variable view with the cell the variable view in the debug sideview check that the children of the variable are accurate
Change:
dependencies: nan "2.14.2" <ins> "@vscode/sudo-prompt@^9.3.0": version "9.3.0" resolved "https://registry.yarnpkg.com/@vscode/sudo-prompt/-/sudo-prompt-9.3.0.tgz#5c63b195986d1d6a142856146e51c6b46a3319b2" integrity sha512-/c/A4/fEBhKXiEW2+Cv8qid6uWA6Igg9iaHrlMoNyoHynziYLYFCaF8lGcmvQ20wEi5l7xyx4YxG2h5nVKazeg== </ins> "@vscode/vscode-languagedetection@1.0.21": version "1.0.21" resolved "https://registry.yarnpkg.com/@vscode/vscode-languagedetection/-/vscode-languagedetection-1.0.21.tgz#89b48f293f6aa3341bb888c1118d16ff13b032d3"

Discussion:
To recreate: Edit a file requiring sudo (eg ) When saving, VSCode will request sudo permissions and, after granting, gives the following error: I do NOT have Rosetta installed but understand VS Code is supposed to be M1 compatible. Here is the version info:
I cannot reproduce and I am on a M1 as well. thoughts? did you install the universal app?
For triggering we use a 3rd-party module which on macOS uses osascript saved as application bundle As a quick check, trigger a sudo prompt from vscode and open the OS temp directory and check for , following is the executable architecture So unless the user has rosetta installed this application will not be launched on M1 as reported here. you might have rosetta installed hence the failure was not seen, can be confirmed with
Not sure if that applet can be converted to universal, might also be worth looking at alternatives for sudo-prompt given that repo is now archived.
I would suggest to fork the module and convert that applet to universal if that is straightforward.
I don't see the source for the applet under the user repositories, will have to reach out to the author.
Maybe:
would you be able to test this scenario again from the following build that includes a potential fix:
Thanks for all your efforts on this (and . I discovered this on a new M1 Mac where I had not yet installed Rosetta but eventually caved in and installed it. Unfortunately it doesn't appear Rosetta can be easily uninstalled for testing. Happy to give this another go the next time I have a fresh Mac install but don't foresee that in the immediate future...
Verification on a mac with ARM chip without Rosetta 2 installed ([1]) use open try to edit (in the comment area!!!) from the error retry as sudo verify you get a prompt and save works [1] The presence of these files are a good indicator that you have Rosetta2 installed:
I take it you just re-compiled the applet for universal & updated the package with the base64 encoded string (is that right?)
yes! Here is what I did: decode the base64 encoded value unzip it open the apple script in apple script editor export it as application bundle (I have Rosetta 2 installed so it seems to export as universal bundle by default) zip it base64 encode it release as fork from