jiebi/CodeConvo huggingface dataset:
Change:
return TPromise.as(null); } <ins> getMainProcessId(): TPromise<number> { this.logService.log('Received request for process ID from other instance.'); return TPromise.as(process.pid); } </ins> }  No newline at end of file

Discussion:
This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Pushed a workaround.
Reopening, using the () workaround causes issues as it will undock windows it seems.
This happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.
As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Just tried the suggested workaround and it did not work. Using Windows 10 Home
I've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?
Seems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build
Must have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.
I started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build
Update: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.
This is happening to me also since the previous 2 releases. Changing the value of did not help
Change:
x: position[0], y: position[1] }; <del> this.applicationStorageMainService.store(processExplorerWindowState, JSON.stringify(state), StorageScope.APPLICATION, StorageTarget.MACHINE); </del> <ins> this.stateMainService.setItem(processExplorerWindowState, state); </ins> }; this.processExplorerWindow.on('moved', storeState);

Discussion:
This is a follow up from I would suggest to not use the storage service for process explorer state but . That is the same service we also use to store window state for workbench windows. Using storage service from the main process requires you to await the event because unlike state service, the storage service is not ready when you use it: State service is always available and can be used as a drop-in replacement. Here is where its used for windows and the key we use is , so maybe it should be .
Change:
if (this.configurationService.getValue<IDebugConfiguration>('debug').closeReadonlyTabsOnEnd) { const editorsToClose = this.editorService.getEditors(EditorsOrder.SEQUENTIAL).filter(({ editor }) => { <del> if (editor.resource?.scheme === DEBUG_SCHEME) { return editor.isReadonly() && session.getId() === Source.getEncodedDebugData(editor.resource).sessionId; } return false; </del> <ins> return editor.resource?.scheme === DEBUG_SCHEME && session.getId() === Source.getEncodedDebugData(editor.resource).sessionId; </ins> }); this.editorService.closeEditors(editorsToClose); }

Discussion:
After ending a debug session the readonly code tab that was opened does not auto-close. This is frustrating, because I often start trying to edit this file without thinking, and of course I cannot.
If this issue is still valid, I'd love to work on it.
I would like to work on this bug as well
THis is still valid, feel free to give it a shot!
Great! I'll try then:)
I'll tried to fix it in this Let me know if there was any problem.
Completed in
I couldn't verify this--I enabled , debugged an extension, opened the file from the Loaded Scripts section (which is readonly), and the tab remained open after terminating my debug session. Are there other steps I should use?
Confirmed that enabling the setting doesn't resolve the issue on Windows.
Change:
} ); <ins> public setActiveModifiedBaseRange(range: ModifiedBaseRange | undefined, tx: ITransaction): void { this.manuallySetActiveModifiedBaseRange.set({ range, counter: this.counter++ }, tx); } </ins> public setState( baseRange: ModifiedBaseRange, state: ModifiedBaseRangeState,

Discussion:
Testing It would seem to make sense to start at the first unhandled conflict (currently starts at the top of the file).
This would also help a first-time user understand what they are looking at. Without a conflict being highlighted, it is easy to get confused over all the filled and unfilled rectangles: <img width="2060" alt="image" src="https://user-"With the first conflict selected this is less the case because the 3 unfilled rectangles stand out: <img width="2061" alt="image" src="https://user-"
But the first conflict is revealed automatically, right?
Change:
this.layout(); }; <ins> const ctxKeys = new Set<string>([SCMInputContextKeys.ActionCount.key]); this.repositoryDisposables.add(Event.filter(this.toolbarContextKeyService.onDidChangeContext, e => e.affectsSome(ctxKeys))(onDidChangeActionButton, this)); </ins> this.repositoryDisposables.add(input.onDidChangeActionButton(onDidChangeActionButton, this)); this.repositoryDisposables.add(this.scmService.onDidChangeInputValueProviders(onDidChangeActionButton, this)); this.repositoryDisposables.add(Event.filter(this.configurationService.onDidChangeConfiguration, e => e.affectsConfiguration('scm.showInputActionButton'))(onDidChangeActionButton, this));

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!
Change:
}); } } <ins> for (const diff of m.rights) { const range = diff.outputRange.toInclusiveRange(); if (range) { result.push({ range, options: { className: `merge-editor-diff result`, description: 'Merge Editor', isWholeLine: true, } }); } if (diff.rangeMappings) { for (const d of diff.rangeMappings) { result.push({ range: d.outputRange, options: { className: `merge-editor-diff-word result`, description: 'Merge Editor' } }); } } } </ins> } return result; });

Discussion:
I really like how I can see the word-level change per line now in the merge editor, but shouldn't the colors be identical to the diff editor? !
I agree the new color needs to be tweaked. Would you also use the green background?
I think making this look as close as a diff editor if possible would be nice because I am so used at looking at diffs with their color coding. //cc
Change:
} async stage(path: string, data: string): Promise<void> { <del> const child = this.stream(['hash-object', '--stdin', '-w'], { stdio: [null, null, null] }); </del> <ins> const child = this.stream(['hash-object', '--stdin', '-w', '--path', path], { stdio: [null, null, null] }); </ins> child.stdin.end(data, 'utf8'); const { exitCode, stdout } = await exec(child);

Discussion:
VSCode Version: 1.7.2 OS Version: Windows 10 Steps to Reproduce: a repo with a config like: a .gitattributes that looks like: a file with crlf line endings the file using git add on the command line and commit bar to baz in VS Code and save to the git tab, select the file, Ctrl-A to select everything, and use the ... menu at the top-right to select stage lines diff --staged Expected: One line changed - bar -baz, with the line endings lf (due to autocrlf=true) Actual: Whole file changed, as the line endings have changed to crlf
Change:
import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'; import { SingleServerExtensionManagementServerService } from 'vs/workbench/services/extensions/node/extensionManagementServerService'; import { Query } from 'vs/workbench/parts/extensions/common/extensionQuery'; <del> import { SuggestEnabledInput, attachSuggestEnabledInputBoxStyler } from 'vs/workbench/parts/codeEditor/browser/suggestEnabledInput'; </del> <ins> import { SuggestEnabledInput, attachSuggestEnabledInputBoxStyler } from 'vs/workbench/parts/codeEditor/electron-browser/suggestEnabledInput'; </ins> import { alert } from 'vs/base/browser/ui/aria/aria'; interface SearchInputEvent extends Event {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.2 OS Version: kubuntu 18.04 Steps to Reproduce: some text to extension search bar it (by the way I can only select whole text, not part of it) isn't copied to the second clipboard (this is linux specific, middle button clipboard) ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.481 --<!-- potentialduplicatescomment --
Does this work as expected when you select text from other search boxes? For example: The find widget in the editor?
As you see on gif, it works as expected on search box
What about from the editor? Open a file and try the same on the text in the file.
It works everywhere except extension search field. I'm sure it occurred after intellisence in this bar was introduced
If that tiny editor would include the contribution, it would begin to work.
The problem is that the editor lives in the layer and uses the clipboard from electron. Do you recall the need to have the in the layer and not in the layer? Note: This issue will also affect the search in the new Settings editor
I think electron-browser is fine
Change:
this._versionId = this._textModel.getVersionId(); this._alternativeId = this._textModel.getAlternativeVersionId(); } <ins> this._textBufferHash = null; </ins> this._onDidChangeContent.fire('content'); }));

Discussion:
Testing Repro steps: some changes to a cell, in my case I a cell with some content the changes some lines from the cell that was in step 1, and save. diff view launched from "changes" SCM view should diff between staged and working.
Now the diff view for the changes in the 'Staged Changes' group is the same as the diff view for the unstaged changes
I am seeing it as I would expect. This is diff launched from staged (where the cell was ) ! This is diff launched on unstaged: !
Works for me too, can you share the text file contents in the 3 cases Commited ipynb Staged ipynb & finally changed ipynb
Original steps LGTM
Original file: ! Modification 1: ! Modification 2: ! Observe that the diffs for the Staged and Working Changes regions below are identical !
Change:
protected createTextEditorModel(value: ITextBufferFactory, resource?: URI, modeId?: string): TPromise<EditorModel> { const firstLineText = this.getFirstLineText(value); const mode = this.getOrCreateMode(this.modeService, modeId, firstLineText); return TPromise.as(this.doCreateTextEditorModel(value, mode, resource)); }

Discussion:
Edit a file tracked by Git Stage the file In the SCM viewlet, click the file in the "staged" section to open an editor that says Type in the file In 1.24.1, I can't edit it because it's a read-only editor In 1.25, I can type in the editor, but changes aren't actually written anywhere. If I switch away from the file and switch back, they are gone
please review
thanks for the fix, I will review it now.
Merged pr, closing
Change:
} } <del> export interface IDropdownOptions extends IBaseDropdownOptions { contextViewProvider: IContextViewProvider; } export class Dropdown extends BaseDropdown { private contextViewProvider: IContextViewProvider; constructor(container: HTMLElement, options: IDropdownOptions) { super(container, options); this.contextViewProvider = options.contextViewProvider; } override show(): void { super.show(); this.element.classList.add('active'); this.contextViewProvider.showContextView({ getAnchor: () => this.getAnchor(), render: (container) => { return this.renderContents(container); }, onDOMEvent: (e, activeElement) => { this.onEvent(e, activeElement); }, onHide: () => this.onHide() }); } protected getAnchor(): HTMLElement | IAnchor { return this.element; } protected onHide(): void { this.element.classList.remove('active'); } override hide(): void { super.hide(); this.contextViewProvider?.hideContextView(); } protected renderContents(container: HTMLElement): IDisposable | null { return null; } } </del> export interface IActionProvider { getActions(): readonly IAction[]; }

Discussion:
These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers
Change:
return joinPath(lastActiveFolder, untitledFileName); } <del> return schemeFilter === Schemas.file ? URI.file(untitledFileName) : URI.from({ scheme: schemeFilter, authority: remoteAuthority, path: posix.sep + untitledFileName }); </del> <ins> return untitledResource.with({ path: untitledFileName }); </ins> } async revert(resource: URI, options?: IRevertOptions): Promise<boolean> {

Discussion:
vscode with no folder (purple status bar) untitled file, save as file how the simple dialog offers me the root path. This is wrong imho, you should offer the home directory, or at least something wich I choose the last time
Could we keep the Untitled URI scheme here? All file scheme URIs are absolute. Which means that the remote file picker would have to use a heuristic like checking for "Untitled-" in the path to tell that the user home should be used.
Feel free to change. is the expert on the untitled URIs...
the URI only seems to be used in combination of the dialog itself (both native and custom - ), so I think we can preserve the if you deal with the untitled case in both worlds.
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.1.0-beta.87", "xterm-addon-canvas": "0.3.0-beta.35", </del> <ins> "xterm": "5.2.0-beta.2", "xterm-addon-canvas": "0.4.0-beta.1", </ins> "xterm-addon-search": "0.11.0-beta.7", "xterm-addon-unicode11": "0.5.0-beta.5", <del> "xterm-addon-webgl": "0.14.0-beta.50" </del> <ins> "xterm-addon-webgl": "0.15.0-beta.1" </ins> } }

Discussion:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:
Change:
}, 'explorer.incrementalNaming': { 'type': 'string', <del> enum: ['simple', 'smart'], </del> <ins> enum: ['simple', 'smart', 'disabled'], </ins> enumDescriptions: [ nls.localize('simple', "Appends the word "copy" at the end of the duplicated name potentially followed by a number"), <del> nls.localize('smart', "Adds a number at the end of the duplicated name. If some number is already part of the name, tries to increase that number") </del> <ins> nls.localize('smart', "Adds a number at the end of the duplicated name. If some number is already part of the name, tries to increase that number"), nls.localize('disabled', "Disables incremental naming. If two files with the same name exist you will be prompted to overwrite the existing file") </ins> ], description: nls.localize('explorer.incrementalNaming', "Controls what naming strategy to use when a giving a new name to a duplicated explorer item on paste."), default: 'simple'

Discussion:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file
Change:
if (argv.tfs) { new mocha.reporters.Spec(runner); <del> // TODO@deepak the mocha Junit reporter seems to cause a hang when running with Electron 6 inside docker container // new MochaJUnitReporter(runner, { // 	reporterOptions: { // 		testsuitesTitle: `${argv.tfs} ${process.platform}`, // 		mochaFile: process.env.BUILD_ARTIFACTSTAGINGDIRECTORY ? path.join(process.env.BUILD_ARTIFACTSTAGINGDIRECTORY, `test-results/${process.platform}-${argv.tfs.toLowerCase().replace(/[^w]/g, '-')}-results.xml`) : undefined // 	} // }); </del> <ins> new MochaJUnitReporter(runner, { reporterOptions: { testsuitesTitle: `${argv.tfs} ${process.platform}`, mochaFile: process.env.BUILD_ARTIFACTSTAGINGDIRECTORY ? path.join(process.env.BUILD_ARTIFACTSTAGINGDIRECTORY, `test-results/${process.platform}-${argv.tfs.toLowerCase().replace(/[^w]/g, '-')}-results.xml`) : undefined } }); </ins> } else { const reporterPath = path.join(path.dirname(require.resolve('mocha')), 'lib', 'reporters', argv.reporter); let Reporter;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --- [x] Adopt a multi-stage pipeline for better visibility into dependencies [x] Review all test suites and ensure that they emit XML test results [x] Add pipeline task to publish the test results
Change:
#   Licensed under the MIT License. See License.txt in the project root for license information. # --------------------------------------------------------------------------------------------- <del> $Global:__VSCodeOriginalPrompt = (Get-Command Prompt).ScriptBlock </del> <ins> $Global:__VSCodeOriginalPrompt = $function:Prompt </ins> function Global:__VSCode-Get-LastExitCode { <del> if ($? -eq $True) { return "0" } </del> <ins> if ($? -eq $True) { return 0 } </ins> # TODO: Should we just return a string instead? <del> return "-1" </del> <ins> return -1 </ins> } function Global:Prompt() {

Discussion:
I have a profile for PowerShell using the and once I enable the the prompt is no longer loading. With it enabled I see this prompt: ! When I disable I get my expected prompt: ! My prompt function within my PowerShell profile:
this is happening because line is throwing because there is no history in a newly created session
champion , should be able to handle this early next week
i could do a pr
also, here you should use and check if the CWD is a filesystem path. like:
that would be awesome! I'm fairly new to pwsh so any comments on the rest of the script would be appreciated too
Under what cases would the file system not be available?
the provider could be something other than filesystem, like the registry, certificate or environment you can see them if you run
just tried , neat
We probably want to keep the CWD even on non-filesystem providers actually, just give it a different scheme or something in that case to let VS Code differentiate it from a regular path. That way we would still get the cwd folder showing up in the tab: !
also, is it only supposed to support powershell 7 and not win PS?
Yep, no windows powershell
does vscode also supports osc 9;9 for CWD Tracking like win term?
some discussion on the topic in , my plan is to move us over to using our own custom sequences to avoid shell integration getting confused and give us freedom to change what them as we please.
let me know if I'm missing something though, I don't think running another terminal's shell integration script is particularly useful. Instead, you would use the arg injection or set it up manually (docs aren't written yet).
I see you have the sequences we support in your profile, these would break when we action as we'd probably move to use
yeah, I will probably remove them after the chages in and get into a release
Good to hear, let us know if you hit any other problems as I have a pretty simple pwsh setup
Can confirm latest build resolves this now on Inisiders: !
Change:
this.domNode.remove(); } <ins> get model(): BreadcrumbsModel | undefined { return this._model.value; } </ins> layout(dim: dom.Dimension | undefined): void { this._widget.layout(dim); }

Discussion:
profile on startup and have a css file opened the registers a fs provider for this somehow ends up causing a dom layout via the breadcrumbs <img width="606" alt="image" src="https://user-"
The trigger is that registering a file system causes a label service change event which causes breadcrumbs to re-render. Tho, we can likely optimise this