jiebi/CodeConvo huggingface dataset:
Change:
this.ignoreSelectionChangedEvent = true; try { this.tree.setSelection([element]); <del> this.tree.reveal(element); </del> <ins> // If the element is outside of the screen bounds, // position it in the middle if (this.tree.getRelativeTop(element) === null) { this.tree.reveal(element, 0.5); } else { this.tree.reveal(element); } </ins> } catch (e) { } finally { this.ignoreSelectionChangedEvent = false;

Discussion:
Right now when a breakpoint is hit, the function in is called, and it in turn calls . The logic of is that it shows the wanted element at the very bottom of the scroll view. What this means is that in the Call Stack view, we'll only see the thread that hit the breakpoint and the first frame at the very bottom -- Ideally I think we want to show this at the top, so that we can see the whole stack trace, not just the first frame.
try it out in VS Code insiders from Friday and let us know if it behaves good for you so we add a verified label here. Thanks
did you get a chance to give this a spin?
sorry for the late reply. I tested it on the latest Insiders Build and it works as expected -- on breakpoint, the stack view shows the current thread in the middle if there are multiple threads in the program and the behavior is not changed compared to the previous version if there are fewer threads.
Also another question for you I can see that you guys (i.e. the VSCode team at Microsoft) are working heavily on Debugging UX improvements and our teams at Facebook could also suggest a few improvements we could benefit from. What is the process on picking the improvements to work on? Is it only done via feature requests? If so, how do you pick and prioritize the requests?
Thanks for coming back, adding verified label. For suggestions on improvments please create new feature requests. Feel free to ping me on them. Thanks
Change:
@IPreferencesSearchService private readonly preferencesSearchService: IPreferencesSearchService, @ILogService private readonly logService: ILogService, @IContextKeyService contextKeyService: IContextKeyService, <del> @IStorageService private readonly storageService: IStorageService, @INotificationService private readonly notificationService: INotificationService, </del> <ins> @IStorageService storageService: IStorageService, </ins> @IEditorGroupsService protected editorGroupService: IEditorGroupsService, @IUserDataSyncWorkbenchService private readonly userDataSyncWorkbenchService: IUserDataSyncWorkbenchService, @IUserDataAutoSyncEnablementService private readonly userDataAutoSyncEnablementService: IUserDataAutoSyncEnablementService,

Discussion:
I am sure by now everyone got this: !
I used to get issues about people not sure whether settings were saved, now I don't. You should only see it once in a new user data dir. I think it's useful, I'd prefer to keep it.
I think given our latest move to reduce notifications we should revisit this. //cc
Agree. would you be open to remove this notification now? This only happens in JSON settings? This one is advanced and maybe those users do not need help?
This happens with our standard settings editor: !
Oh I misunderstood, then I would definitely remove this notification. Most UI now days do not have an Apply button and none of the notify that you do not have to click apply for the setting to be applied. did we run some user studies where participants would get confused if their settings get saved? Could we maybe remove this notification and run a short study to gather some impressions. Reopening this issue for discussion
As I remember, this came directly from user studies. But that was 3 years ago and maybe we can just assume that people are used to it now? You will also only get it once.
I don't remember the details from the user study but I think it would be fine to remove this and then also follow up with a short study.
cool. do you mind if we remove this in May debt week, so we have the whole May milestone to gather feedback and maybe do a short study?
Since I noticed this again now in endgame week with fresh installs, decided to put up a PR with the notification removed in
Awesome, thanks for doing that
verified
Change:
this._renderedParts.push({ type: 'statusBar', hoverElement: renderedStatusBar.hoverElement, <ins> actions: renderedStatusBar.actions, </ins> }); } return toDisposable(() => { disposables.dispose(); });

Discussion:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!
Change:
order: 1.45 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 5, }]

Discussion:
Type: <bBug</b- VS Code Version: 1.74.1 OS Version: Windows NT x64 10.0. Issue appeared just after upgrading VSCode to ver. 1.74.1 Currently, it is impossible to go to the function definition by clicking Ctrl+Click on the function name or using the F12 button. Also, the Go to definition option in Top Menu-Go-Go to Definition is disabled. VS Code version: Code 1.74.1 (, 2022-12-14T10:30:51.966Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
What code language? Is the option also disabled in the context menu? was a previous issue about this and related options not getting enabled in the top-level Go menu. Maybe this has come back. Do you think this didn't happen in 1.74.0?
- maybe caused by
Yeah, looks like the precondition for the command is too strong
Javascript I don't have such an option in the context menu I'm not 100% sure, which version I had previously installed, but I'm using VSCode almost every day, so I'm pretty sure I was using 1.74.0 or 1.73.1, and that behavior has occurred after auto-upgrade to 1.74.1. I've never noticed anything like it before.
After a clean uninstall (Uninstalled and deleted %APPDATA%Code and %USERPROFILE%.vscode), and installing 1.74.1 again, the problem does not occur anymore.
Change:
}; } async function main(arch = process.arch) { <del> const version = product.electronRepository ? '19.1.10' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '19.1.11' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith
Change:
} private updateStatusEntry(): void { <del> const visible = this.configurationService.getValue(KeywordActivationContribution.SETTINGS_ID) !== KeywordActivationContribution.SETTINGS_VALUE.OFF; </del> <ins> const visible = supportsKeywordActivation(this.configurationService, this.speechService); </ins> if (visible) { if (!this.entry.value) { this.createStatusEntry();

Discussion:
Type: <bBug</bIt's unexpected to switch to editor window and notice micophone appeared in status bar with tooltip "Waiting for voice chat to end" (very strange message for because it looks like it listens everything at this moment) at the end of meeting. ! Clicking on it opens settings with search for , but only result is Extenions Experimental: Deferred Startup Finished Activation (), which adds to confusion. I won't expect to see this status item until I gave explicit approval to use mic. VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-19T05:37:08.195Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
/assign bpasero I think you are latest committer that changed activation
Same here, how do i disable this feature? Cant find it in settings
This is related only to Insiders version and will be gone with today's Insiders build.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
return renderHunks()?.position; } <del> protected _updateSummaryMessage(hunkCount: number) { </del> <ins> private _updateSummaryMessage(remaining: number, total: number) { const needsReview = this._configService.getValue<boolean>(InlineChatConfigKeys.AcceptedOrDiscardBeforeSave); </ins> let message: string; <del> if (hunkCount === 0) { message = localize('change.0', "Nothing changed"); } else if (hunkCount === 1) { message = localize('change.1', "1 change"); </del> <ins> if (total === 0) { message = localize('change.0', "Nothing changed."); } else if (remaining === 1) { message = needsReview ? localize('review.1', "$(info) Accept or Discard 1 change.") : localize('change.1', "1 change"); </ins> } else { <del> message = localize('lines.NM', "{0} changes", hunkCount); </del> <ins> message = needsReview ? localize('review.N', "$(info) Accept or Discard {0} changes.", remaining) : localize('change.N', "{0} changes", total); } let title: string | undefined; if (needsReview) { title = localize('review', "Review (accept or discard) all changes before continuing."); </ins> } <del> this._zone.widget.updateStatus(message); </del> <ins> this._zone.widget.updateStatus(message, { title }); </ins> } hasFocus(): boolean {

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, InternalInlineSuggestOptions> { constructor() { const defaults: InternalInlineSuggestOptions = { <del> enabled: false, </del> <ins> enabled: true, </ins> mode: 'subwordSmart' };

Discussion:
Now that the feature has matured in its implementation, consider changing the default to .
I will do this as first action next milestone!
Change:
counter++; } while (existingNotebookDocument.has(notebookUri.toString())); <ins> InteractiveEditorInput.setName(notebookUri, title); </ins> logService.debug('Open new interactive window:', notebookUri.toString(), inputUri.toString());

Discussion:
VS Code Version: 1.80.1 OS Version: Win-10 Python extension: v2023.12.0 Steps to Reproduce: an empty file with cell =you will see the interactive window with tab name , ... Please confirm if this is work as designed. I remember it wasn't the case at the beginning of the year. This type of naming causes tremendous confusing when working on more than 2 interactive windows within a Workplace. Please let me know if I should report it to Thanks!
Probably the same error after last update. VS Code Version: 1.80.1 OS Version: Ubuntu 22.04 "jupyter.interactiveWindow.creationMode": "perFile" name of source python file is lost, only tab names 'interactive-1', 'interactive-2'
not intentional, it should still include the python filename in the interactive tab. investigating
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { window, InputBoxOptions, Uri, OutputChannel, Disposable } from 'vscode'; </del> <ins> import { window, InputBoxOptions, Uri, OutputChannel, Disposable, workspace } from 'vscode'; </ins> import { IDisposable, EmptyDisposable, toDisposable } from './util'; import * as path from 'path'; import { IIPCHandler, IIPCServer, createIPCServer } from './ipc/ipcServer';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.0 OS Version: Ubuntu 19.10 Steps to Reproduce: add: { "git.enabled": false, "git.terminalAuthentication": false, "git.githubAuthentication": false, } to push from the integrated terminal <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Error text: Missing or invalid credentials. Error: connect ENOENT at PipeConnectWrap.afterConnect [as oncomplete] () { errno: 'ENOENT', code: 'ENOENT', syscall: 'connect', address: '' }
Did you restart the terminal after your disabled it?
Yes, I've both killed the terminal and restarted the VM. Not sure if this is helpful, but before I the two new settings vscode was trying to handle the authentication even though I had set (requesting username and password from the command palette). That's what sent me looking for the new settings in the first place.
Change:
} assertFn(() => { <del> if (!dontAssertStartLine) { if (changes.length > 0 && changes[0].original.startLineNumber !== changes[0].modified.startLineNumber) { </del> <ins> if (!dontAssertStartLine && changes.length > 0) { if (changes[0].modified.startLineNumber !== changes[0].original.startLineNumber) { return false; } if (modifiedLines.length - changes[changes.length - 1].modified.endLineNumberExclusive !== originalLines.length - changes[changes.length - 1].original.endLineNumberExclusive) { </ins> return false; } }

Discussion:
Monaco Editor Repro  To verify bug-fix: Click on "Compare with latest dev" and notice that the alignment is correct in the dev version. (edited by Type: <bBug</b! This is a diff for a file that has been removed and regenerated using . Line 202 on the left should not be marked as deleted and there should not be an empty line on the right under line 201. This also causes the diff from this point to be misaligned: ! ! Last screenshot also shows how diff becomes even more misaligned if the same bug appears again later in the diff. This is not open-source project, so can't point to a commit with this change on github, but the same happened in my other projects when I regenerated by removing it and reinstalling deps. VS Code version: Code 1.86.1 (, 2024-02-07T09:07:19.849Z) OS version: Linux x64 6.1.0-17-amd64 Modes: <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This also happens when there aren't many changes to the file: !
Thanks for reporting! Can you reproduce this issue?
I still can with latest version !
Created a repro repo: There are two commits. Open diff between them in vscode to see the bug. Easier to notice with ! enabled
Played with playground bisect for fun, and since I did I can as well post the results: !
Probably it broke with
I'm not familiar with vscode source code, so the fix doesn't make much sense to me. Could you explain why the bug would happen only for some changes and not all of them? Unless it's hard to explain. I'm very interested what was the cause here.
The bug fix is just this: ! Which I think was an oversight when I combined and into (and then later only modify and not and ). This code looks at words in both sides and checks how many equal parts they have. If more than 1/3 of a word changed, the entire word is marked as changed. The bug here was that in your specific case, the word was extended in a wrong way.

Even worse, the modified side was extended into the next line, whereas the original side wasn't. This caused the misalignment (and assertion failure). The function is quite tricky.
Thank you!
Change:
this._widgetDisposableStore.add(editorModel.onDidChangeContent(() => { const value = editorModel.getValue(); if (this.input?.resource && value !== '') { <del> (this.input as ReplEditorInput).historyService.replaceLast(this.input.resource, value); </del> <ins> const historyService = (this.input as ReplEditorInput).historyService; if (!historyService.matchesCurrent(this.input.resource, value)) { historyService.replaceLast(this.input.resource, value); } </ins> } }));

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --four cells from the interactive window input box, e.g. , , , reexecute multiple commands from earlier in your history, e.g. and use via the up arrow executing an entry from earlier in the history e.g. , scroll position resets to the bottom of the history, and you have to start over and scroll up from the most recent command (4 -3 - 2 -1). This can be frustrating for users who are trying to reexecute multiple commands. Note also that the original interactive window used to preserve your scroll history in the interactive window so that you didn't have to scroll back up through the entire history, and users have complained about this behavior change:
The expectation is that the interactive window input behaves just like a REPL. would address this. Per discussion with we should have shared logic for handing history traversal.
Any news on that? I agree with the PR that the current behavior is quite frustrating and deserves further attention.
Yes this is one of my main frustrations with the IW still. At minimum I just want the up arrow to go to the last executed code, not have cycle through like 20 cells every time I need to re-run something. And it did used to work this way ~1.5 yrs ago.
Change:
private extensionsControlManifest: Promise<IExtensionsControlManifest> | undefined; private lastReportTimestamp = 0; <del> private readonly installingExtensions = new Map<string, IInstallExtensionTask>(); </del> <ins> private readonly installingExtensions = new Map<string, { task: IInstallExtensionTask; waitingTasks: IInstallExtensionTask[] }>(); </ins> private readonly uninstallingExtensions = new Map<string, IUninstallExtensionTask>(); private readonly _onInstallExtension = this._register(new Emitter<ServerInstallExtensionEvent>());

Discussion:
VS Code Version: stable and from sources When launching the server and installing extensions using that have a common dependency, one of the extensions will fail activating, prompting to reload VS Code. For example installing, and contains which depends on also depends on installation task finishes first and then trying to activate fails as for installation which is part of installation task Steps to Reproduce: this branch in gitpod or codespaces will fail activating and a notification shows prompting to reload vscode <img width="448" alt="error_iamge" src="https://user-"cc
would you accept a PR fixing this? I took a look but it doesn't look something trivial to fix properly, I but I don't think is a good fix
PR would be always welcome. Agreed it is not trivial. Let's see if there is a simple fix that fixes this and won't cause any regressions.
Created a PR with a possible fix
ping, by any chance for July
I am sorry that I am on vacation so cannot be looked in July.
I was following this other , but it was marked as a duplicate and was therefore closed. This isse seems to be closed as well, although the issue persists. Specifically, it seems that VS Code Dev Containers installs extensions in alphabetical order, so that if an extension that comes later in the order is a pre-requisite for another that is earlier, then the installations will not behave as expected. Example, is a pre-requisite for , but comes later in alphabetical order. Thus, requires a VS Code Session restart after building the Dev Container. Is this issue fixed in VS Code Insiders, but not released yet?
The issue you reported is using the build 1.71. and this fix was pushed in 1.72.. So please update your VS Code and try.
Change:
return; } await model.accept(editor); <del> alert('Accepted'); </del> model.stop(); editor.focus(); }

Discussion:
cc and got some feedback that it could be useful to alert when a completion is accepted. I can imagine why this would be helpful, but also, the user has taken the action and knows what the completion is, so wonder if this would just add noise.
IMO, this is not necessary b/c users take the accept gesture; thus, the event result is very obvious.
Agree, it's also clear because the user's focus is in the editor right where the suggestion was inserted.
Will wait for more feedback, but seems likely we'll close this.
I agree, however that announcement is currently present if I accept a suggestion from the accessible view. I wonder if it should be removed there for consistency. There is a change of context that happens because the accessible view closes and focus goes to the editor, which I believe serves as a confirmation.
it seems like I should verify that a screen reader alert does not happen when accepting a completion in the "accessible view". Which accessible view is this?
Correct, the inline completions accessible view, so trigger an inline completion, then use alt+f2
Change:
return this.connectionInfo; } <ins> this.storageService.store(REMOTE_TUNNEL_HAS_USED_BEFORE, true, StorageScope.APPLICATION, StorageTarget.MACHINE); </ins> let tokenProblems = false; for (let i = 0; i < INVALID_TOKEN_RETRIES; i++) { tokenProblems = false;

Discussion:
After starting up VS Code for the first time, something strange appears in the status bar: ! Click it. Then click the notification link. The output opens empty. Wait long enough and an error comes up: !
The "syntax error" will log the output, so if you see that again, please share more details what do you think about not showing the "Looking for tunnel" progress on startup? Most users don't use remote tunnels, so this is just noise.
I think user only see that if they turned on Remote Tunnel Access. Yes, I guess we can remove it.
It looks like that progress is shown whenever the RemoteTunnelWorkbenchContribution is instantiated unless there's already a known session.
Change:
'description': localize('audioCues.terminalQuickFix', "Plays a sound when terminal Quick Fixes are available."), ...audioCueFeatureBase, }, <ins> 'audioCues.terminalBell': { 'description': localize('audioCues.terminalBell', "Plays a sound when the terminal bell is ringing."), ...audioCueFeatureBase, default: 'on' }, </ins> 'audioCues.diffLineInserted': { 'description': localize('audioCues.diffLineInserted', "Plays a sound when the focus moves to an inserted line in Accessible Diff Viewer mode or to the next/previous change."), ...audioCueFeatureBase,

Discussion:
When using the command, Roberto did not know there was a configure action available. He said: It works, but in all my time using the editor, it never occurred to me to try using the tab key in that list. I always assumed it was read only. Originally posted by in
also this discoverability issue. Additionally, he found that has to be pressed twice to reach the settings gear when running .
He suggested we use checkboxes instead and combine with .
Need to assess which other actions we need to fix
I think it is possible using the quick pick api to render checkboxes for this. Let me un-assign Tyler and in case you need help with the API feel free to reach out to me and we can find the right usage.