jiebi/CodeConvo huggingface dataset:
Change:
private insertRepository(repositories: ISCMRepository[], repository: ISCMRepository): void { const index = binarySearch(repositories, repository, this._compareRepositories); <del> if (index < 0) { repositories.splice(~index, 0, repository); } </del> <ins> repositories.splice(index < 0 ? ~index : index, 0, repository); </ins> } private onWillSaveState(): void {

Discussion:
Issue Type: <bBug</bWith the recent update 1.66, where the release note mentions that repositories are listed in alphabetical order in source control tab. But, this created another bug where if we have 2 repros with same name under a folder, one of them will miss in the list. Steps to reproduce: 1) Create root folder and project1 and project2 as sub folder under it 2) Create a git repo name with 'test' under each project1/2 3) Now add root folder to the project explorer. And you will notice only one test git repo listed under source control tab VS Code version: Code 1.66.0 (, 2022-03-30T05:50:14.623Z) OS version: Windows_NT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-90-generic <!-- generated by issue reporter --
/assign
I've already pointed one duplicate to this. I think a fix needs to be considered for recovery.
yeah, I am currently looking at this and I will make sure that it is in the next recovery release.
The fix for this has been checked into main and it will be fixed in tomorrow's Insiders release. I am also porting this fix to to the release branch and it will be part of the next recovery release.
Change:
// Close aux window when last group removed const groupView = this.assertGroupView(group); if (this.count === 1 && this.activeGroup === groupView) { <del> this.close(); </del> <ins> this.doClose(false /* do not merge any groups to main part */); </ins> } // Otherwise delegate to parent implementation

Discussion:
Testing It would be great if we can have a command to bring back those editors to the main window.
I think that should actually be the default behaviour when you just close the window. That will prevent ugly confirmation dialogs for dirty editors when you attempt to close the floating window.
Verification: open a floating window with some editors (e.g. by dragging an editor tab out of the window) close the floating window, e.g. from the X window button verify all editors of the floating window are moved back to the main window
Change:
Diff: { kind: OperationKind.Diff, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as DiffOperation, Fetch: (showProgress: boolean) => ({ kind: OperationKind.Fetch, blocking: false, readOnly: false, remote: true, retry: true, showProgress } as FetchOperation), FindTrackingBranches: { kind: OperationKind.FindTrackingBranches, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as FindTrackingBranchesOperation, <del> GetBranch: { kind: OperationKind.GetBranch, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as GetBranchOperation, </del> <ins> GetBranch: { kind: OperationKind.GetBranch, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as GetBranchOperation, </ins> GetBranches: { kind: OperationKind.GetBranches, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as GetBranchesOperation, GetCommitTemplate: { kind: OperationKind.GetCommitTemplate, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as GetCommitTemplateOperation, GetObjectDetails: { kind: OperationKind.GetObjectDetails, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as GetObjectDetailsOperation,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0 (user setup) Commit: Date: 2024-07-01T18:52:22.949Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Steps to Reproduce: to to at the icon I'm not sure if it's a new feature or a bug, but it wasn't like that in previous version (1.90).
Thanks for reporting this issue. This will be fixed in tomorrow's VS Code Insiders release and the next VS Code Stable release.
Thank you for checking and fixing it.
Change:
import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import Event, { Emitter } from 'vs/base/common/event'; import { addDisposableListener, addClass } from 'vs/base/browser/dom'; <del> import { editorBackground, editorForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { editorBackground, editorForeground, textLinkForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { ITheme, LIGHT, DARK } from 'vs/platform/theme/common/themeService'; import { WebviewFindWidget } from './webviewFindWidget'; import { IContextViewService } from 'vs/platform/contextview/browser/contextView';

Discussion:
! It looks surprisingly good in this screenshot, but in reality it's way worse. Contrast ratio: background: , color:
It doesn't make much sense to me. Background color changes ... color stays the same. If background is close to blue () =links become low contrast ! If background is close to orange () =code samples become low contrast !
Change:
), () => undefined, 100)(() => this._onDidChange.fire())); } <del> async resolveContents(): Promise<[string | undefined, [string, string | undefined][]]> { </del> <ins> async resolveContents(donotResolveSettings?: boolean): Promise<[string | undefined, [string, string | undefined][]]> { </ins> const resolveContents = async (resources: URI[]): Promise<(string | undefined)[]> => { return Promise.all(resources.map(async resource => {

Discussion:
apply the patch that logs fs calls which is included below run open a folder and open a single css file don't modify it (i.e. avoid hot exit) and reload the window <details<summaryPatch</summary</detailsObserve the following fs calls that occur before the first editor rendering: IMHO the following fs calls should be postponed: [ ] [ ] [ ] [x] I also noticed that we read the following files twice: [ ]
I have no clue what we use install source for, but lots of digging reveals this commit:
Updating the list - is only read once.
is read twice because First time during initialising configuration without user tasks User tasks is read later when there is an idle time - by reloading user configuration - during which settings and tasks files are read.
Install source is a common telemetry property. It can be set after installing VS Code. It came as an ask from Anaconda, to know how many installations came from them. We decided to go with creating a new file rather than updating existing files, to avoid scenarios where we'd break important files (eg or ). I don't have great ideas to work around this other than refactoring the code until the first telemetry event gets submitted, which is still pretty early. Will ask around to learn whether this common telemetry property is still in use.
is gone!
Tasks and Launches are part of Config and they are accessed sync from config service. In order to prevent reading these files during start up we should loading them until they are needed. (probably workbench restored phase) an assertion to make sure no component is reading them until then
This needs considerable refactoring and I do not think it is worth a change for the gain given that these files are resolved in parallel. Hence marking this as no fix.
Change:
"scopeName": "text.pug", "path": "./syntaxes/pug.tmLanguage.json" } <del> ] </del> <ins> ], "configurationDefaults": { "[jade]": { "diffEditor.ignoreTrimWhitespace": false } } </ins> }, "repository": { "type": "git",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
render(): void { this.container.innerText = ''; <ins> this.container.title = ''; </ins> if (!this.extension) { return;

Discussion:
A11yMAS; #A11ySev1; #A11yTCS; #DesktopApp; #BM-PowerShellCore-MAC-Jan21; #PowerShell Core; #MAS1.3.1; #MAC; #AINotInScope; #Info and Relationships; #Voiceover; #Element: Button; #ScreenReader; #Benchmark. Application Name: Visual Studio Code Version: 1.66.2(user setup) PowerShell Verion: v2022.5.0 MAC Version: macOS Monterey 12.2.1 Voiceover with using shortcut key Command+F5. VS Code Space Insiders VS Code Space insiders till Extension in the left navigation and press enter till Search Extensions in Marketplace and type PowerShell and press enter till Rating information check whether Voiceover is reading the rating information such as 4 stars rated for PowerShell or not Voiceover is not announcing about "rating" information about the PowerShell. Voiceover should be announcing about "Rating" information about the PowerShell for the users to understand how much PowerShell is rated !
The rating element should have an aria-label which has the rating in it, so the user can hear the rating. should be pretty straight forward, feel free to assign back to me if you would like me to push this.
Issue is fixed. Adding #Closed; tag.
Change:
import { CommandDetectionCapability } from 'vs/platform/terminal/common/capabilities/commandDetectionCapability'; import { TerminalCapabilityStore } from 'vs/platform/terminal/common/capabilities/terminalCapabilityStore'; import { ITerminalQuickFixAction, ITerminalInstance } from 'vs/workbench/contrib/terminal/browser/terminal'; <del> import { freePort, FreePortOutputRegex, gitCreatePr, GitCreatePrOutputRegex, GitPushOutputRegex, gitPushSetUpstream, gitSimilarCommand, GitSimilarOutputRegex } from 'vs/workbench/contrib/terminal/browser/terminalQuickFixBuiltinActions'; </del> <ins> import { freePort, FreePortOutputRegex, gitCreatePr, GitCreatePrOutputRegex, GitPushOutputRegex, gitPushSetUpstream, gitSimilarCommand, GitSimilarOutputRegex, gitTwoDashes, GitTwoDashesRegex } from 'vs/workbench/contrib/terminal/browser/terminalQuickFixBuiltinActions'; </ins> import { TerminalQuickFixAddon, getQuickFixes } from 'vs/workbench/contrib/terminal/browser/xterm/quickFixAddon'; import { Terminal } from 'xterm';

Discussion:
With we're getting some initial terminal quick fixes. We have a bunch more ideas, let's use this issue to track adding more at a later date when we have more information on how the feature is received.
Also want to consider the setting to disable one or more of these
The open URL one (the only one I’ve seen so far) was a really pleasant surprise and I immediately adopted it into my workflow for opening a GitHub PR after pushing a new branch. Another one I would love to see is opening files with merge conflicts: <img width="615" alt="image" src="https://user-"
great idea!
I think this can be closed since we have individual issues tracking ideas
Change:
"icon": "$(add)" }, { <ins> "command": "git.stageAllMerge", "title": "%command.stageAllMerge%", "category": "Git", "icon": "$(add)" }, { </ins> "command": "git.stageSelectedRanges", "title": "%command.stageSelectedRanges%", "category": "Git"

Discussion:
Issue Type: <bBug</bDuring a rebase (not sure if that's the only scenario), my SOURCE CONTROL tab display three sections, MERGE CHANGES, STAGED CHANGES and CHANGES. If I click the + button on the CHANGES section, in order to stage all items below CHANGES, VS Code also adds everything on MERGE CHANGES. VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-29T05:33:59.143Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ markdown-mermaid1.5.0 better-toml0.3.2 vscode-eslint2.1.5 gitlens10.2.1 plantuml2.13.8 svg1.1.8 vscode-peacock3.7.0 chat0.33.0 rust-analyzer0.2.151 vscode-todo-parser1.9.1 remote-wsl0.44.2 vsliveshare1.0.2104 vsliveshare-audio0.1.85 vsliveshare-pack0.3.4 vscode-xml0.11.0 vscode-yaml0.7.2 crates0.4.9 vscode-hexdump1.7.2 markdown-all-in-one2.8.0 </details<!-- generated by issue reporter --
Hello I would like to work on this issue if no one else is. Regards.
hey could you please review the pr that I have opened and also could you please suggest any changes if required.
Hi I'm also working on this issue. You can check my PR
I have gone through your PR also left a comment.
Change:
assert.strictEqual(extension.outdated, true); }); <del> test('extension is not outdated when local is built in and older than gallery', () => { </del> <ins> test('extension is outdated when local is built in and older than gallery', () => { </ins> const extension = instantiationService.createInstance(Extension, () => ExtensionState.Installed, undefined, aLocalExtension('somext', { version: '1.0.0' }, { type: ExtensionType.System }), aGalleryExtension('somext', { version: '1.0.1' })); <del> assert.strictEqual(extension.outdated, false); </del> <ins> assert.strictEqual(extension.outdated, true); </ins> }); test('extension is outdated when local and gallery are on same version but on different target platforms', () => {

Discussion:
Ability to update built in extensions
This is a pre-request to enable built-in extension to on-board to
Disabled updating builtin extensions in stable
Change:
}); suite('renderers', () => { <del> test('should re-evaluate gpu acceleration auto when the setting is changed', async () => { </del> <ins> // This is skipped until the webgl renderer bug is fixed in Chromium // https://bugs.chromium.org/p/chromium/issues/detail?id=1476475 test.skip('should re-evaluate gpu acceleration auto when the setting is changed', async () => { </ins> // Check initial state strictEqual(TestWebglAddon.isEnabled, false);

Discussion:
Type: <bBug</bOpen terminal. Start typing. Note the noticeable delay in the text rendering on screen even though the cursor advances. In fact some timess the text never renders. Makes the terminal pretty unusable. VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-10T05:33:20.243Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ togglehs0.1.2 vscode-eslint2.4.2 githistory0.6.20 gitlens2023.8.1005 dotnet-test-explorer0.7.8 copilot1.101.325 copilot-chat0.7. vscode-mojom0.1.4 mojom-language0.0.1 vscode-clangd0.1.24 csharp2.0.328 vscode-dotnet-runtime1.6.0 python2023.15. vscode-pylance2023.8.21 remote-wsl0.81.0 cpptools1.17.1 powershell2023.6.0 vscode-jest5.2.3 clang-format1.9.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
does changing help?
Yes. It apparently was set to auto previously. If it turn it to "off" the issue goes away.
repro's for me with set to or . does not repro for or gif: !
I can't reproduce this unfortunately
I still have a consistent repro if you want me to try anything or collect diagnostics.
Findings from looking at it together: It repro'd in Code - OSS It did not repro in xterm demo It did not repro in Code - OSS with symlinked webgl addon It repro'd after running scripts/update-xterm
I'm going to manually look through all the code that went in around rendering ~1-2 weeks ago to see if I can spot something.
Maybe it's related to Chromium.
Upstream bug filed at , thanks to
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verified on Linux
verified on windows
Change:
this._socketWriter.resume(); break; } <ins> case ProtocolMessageType.KeepAlive: { // nothing to do break; } </ins> } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Background: Modern reverse proxies like nginx or cloudflare use timeouts for dormant websocket connections. For nginx this defaults to 60s and for Cloudflare to 100s. In case of Cloudflare, this is not configurable for non-enterpise users. Due to the fixes in , the management connection is now typically being idle for extended periods of time. If the web-socket connection is being terminated by the reverse proxy, even if it can be reestablished immediately, a modal dialog is being shown, which disturbs the user immensely. For reference see In order to support Cloudflare it is essential, that we either implement a keep-alive ping (my proposal would by every 45s by default), or alternatively, make it so an immediate reconnect does not cause any negative consequences for the user.
any insights here?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Version: 1.71.0-insider Commit: Date: 2022-08-26T23:24:52.456Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36 /verified I do no longer experience regular reconnects every 100 seconds behind cloudflare with the build above.
Change:
this.includesExcludesContainer = DOM.append(container, DOM.$('.includes-excludes')); // Toggle query details button <del> this.toggleQueryDetailsButton = DOM.append(this.includesExcludesContainer, DOM.$('.expand' + ThemeIcon.asCSSSelector(searchDetailsIcon), { tabindex: 0, role: 'button' })); this._register(this.hoverService.setupManagedHover(getDefaultHoverDelegate('element'), this.toggleQueryDetailsButton, localize('moreSearch', "Toggle Search Details"))); </del> <ins> const toggleQueryDetailsLabel = localize('moreSearch', "Toggle Search Details"); this.toggleQueryDetailsButton = DOM.append(this.includesExcludesContainer, DOM.$('.expand' + ThemeIcon.asCSSSelector(searchDetailsIcon), { tabindex: 0, role: 'button', 'aria-label': toggleQueryDetailsLabel })); this._register(this.hoverService.setupManagedHover(getDefaultHoverDelegate('element'), this.toggleQueryDetailsButton, toggleQueryDetailsLabel)); </ins> this._register(DOM.addDisposableListener(this.toggleQueryDetailsButton, DOM.EventType.CLICK, e => { DOM.EventHelper.stop(e); this.toggleIncludesExcludes();

Discussion:
Steps to reproduce: any document, press controll+shift+f to open the find all functionality. tab (4 times) until you hear "button" or "button expanded". Issues: does not announce that the button is an expandable one, and that it is in the collapsed state. This appears to be a regression in the insiders build when compared with the latest stable release, where the button is announced as collapsed or expanded. does not have any label for the button. It is just announced as "button".
are you aware of any regressions that could have caused this in the tree view? I don't think that I changed anything in search for this to happen..
I'm not aware of any changes to this. Furthermore, in testing with VoiceOver, this is working as expected. Does this repro with NVDA on Windows? If not, it's possible something changed with JAWS.
This doesn't repro with NVDA, trying JAWS next
doesn't repro for me using JAWS either, has any setting changed for you?
The expand/collapsed state is indicated to me for all screen readers. I can repro the button not having an aria label, which we should fix.
Change:
} class TestTask extends CommonTask { <ins> constructor() { super('test', undefined, undefined, {}, {}, { kind: '', label: '' }); } </ins> protected getFolderId(): string | undefined { throw new Error('Method not implemented.'); }

Discussion:
Due to an oversight, does not enforce arguments or its return type. Fixing this exposes around 80 typings errors in our codebase that should be addressed To fix this issue in your code: , comment out the . (Do not check in this change. I will check in the change to the signature once all error have been fixed) look at the file assigned to you and fix the type error (you may need to restart the compile since we are changing such a core type) [x] — [x] — [x] — [x] — [x] — [x] — [x] — [ ] — [ ] — [ ] — [ ] — [x] — [x] — [x] — [x] — [x] — [x] — [ ] — [x] —