jiebi/CodeConvo huggingface dataset:
Change:
role: 'Editor', ostypes: ["TEXT", "utxt", "TUTX", "****"], extensions: ["ascx", "asp", "aspx", "bash", "bash_login", "bash_logout", "bash_profile", "bashrc", "bat", "bowerrc", "c", "cc", "clj", "cljs", "cljx", "clojure", "cmd", "code-workspace", "coffee", "config", "cpp", "cs", "cshtml", "csproj", "css", "csx", "ctp", "cxx", "dockerfile", "dot", "dtd", "editorconfig", "edn", "eyaml", "eyml", "fs", "fsi", "fsscript", "fsx", "gemspec", "gitattributes", "gitconfig", "gitignore", "go", "h", "handlebars", "hbs", "hh", "hpp", "htm", "html", "hxx", "ini", "jade", "jav", "java", "js", "jscsrc", "jshintrc", "jshtm", "json", "jsp", "less", "lua", "m", "makefile", "markdown", "md", "mdoc", "mdown", "mdtext", "mdtxt", "mdwn", "mkd", "mkdn", "ml", "mli", "php", "phtml", "pl", "pl6", "pm", "pm6", "pod", "pp", "profile", "properties", "ps1", "psd1", "psgi", "psm1", "py", "r", "rb", "rhistory", "rprofile", "rs", "rt", "scss", "sh", "shtml", "sql", "svg", "svgz", "t", "ts", "txt", "vb", "wxi", "wxl", "wxs", "xaml", "xcodeproj", "xcworkspace", "xml", "yaml", "yml", "zlogin", "zlogout", "zprofile", "zsh", "zshenv", "zshrc"], <ins> utis: ['public.source-code'], </ins> iconFile: 'resources/darwin/code_file.icns' }], darwinBundleURLTypes: [{

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: n/a OS Version: n/a Steps to Reproduce: space on python file doesn't show with syntax highlighting <img width="324" alt="screen shot 2017-05-03 at 1 56 59 pm" src=""<img width="909" alt="screen shot 2017-05-03 at 1 57 01 pm" src=""
This seems to be doable—I see TextMate 2 handle previews for all source code.
Thanks to allows this to happen. Setting it for November.
Awesome, thanks for the fast pull!
I'm sure this will be great for tonnes of users. I have this older ticket - but it got shelved. A variable explorer like spyder. made a fantastic effort in surfacing these here I wonder how hard it would be to rip apart the debug variable explorer. I don't know where to start. A friend illustrated to me 6 mths back that the content inside vscode could be inspected like google chrome with divs and dom hierarchy.
The changes don't seem to have made any change. For example, after installing today's Insiders, files still don't show source in QuickLook, although they are associated with Code.
LaunchServices may not have picked up on the change, and it's a bit fiddly (especially if you have multiple apps with the same CFBundleIdentifier on the machine). It also won't work if the CodeSignature is invalid. I downloaded Insiders today (1.18.0-insider) and didn't see the new key in the , FWIW.
I'll take a look at it in November.
Are you sure all this needs is to add the key? I can't get this to work on my machine in any way. Also, the official docs say: I get the feeling that this is not sufficient for Quick Look, but rather that a Quick Look plugin is required to get this to work.
OK guys, I'm going to close this and revert the PR for two reasons: Causes issues There are other alternatives out there which do a much better job than Code:
Change:
await actions[0].run(); assert.strictEqual(configurationService.getValue('example.stringSetting'), 'three'); const actionsUpdated = settingRenderer.getActions(uri); <del> assert.strictEqual(actionsUpdated?.length, 2); </del> <ins> assert.strictEqual(actionsUpdated?.length, 3); </ins> assert.strictEqual(actionsUpdated[0].label, 'Restore value of "Example: String Setting"'); assert.strictEqual(actions[1].label, 'View in Settings'); <ins> assert.strictEqual(actions[2].label, 'Copy Setting ID'); </ins> assert.strictEqual(configurationService.getValue('example.stringSetting'), 'three'); // Restore the value

Discussion:
Testing Click on a setting link in the release notes Get a tooltip "View '<title' in Settings" context menu It seems strange to open a context menu on left-click and to open one with only a single menu item. Can we skip doing this if "View" is the only action?
My preference would be to keep it consistent so that a context menu always opens when the button is clicked. There was some discussion of adding a "copy setting id" item in there too, which would fix the only-one-item issue.
Will be fixed by , which adds a "copy" action to the menu.
Another option is to open the context menu when the "gear" icon is hit, but go directly to the setting if the text is clicked (or vise versa)
Change:
import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { Action2 } from 'vs/platform/actions/common/actions'; import { AudioCue, IAudioCueService } from 'vs/platform/audioCues/browser/audioCueService'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput'; <del> import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences'; </del> export class ShowAudioCueHelp extends Action2 { static readonly ID = 'audioCues.help';

Discussion:
When using the command, Roberto did not know there was a configure action available. He said: It works, but in all my time using the editor, it never occurred to me to try using the tab key in that list. I always assumed it was read only. Originally posted by in
also this discoverability issue. Additionally, he found that has to be pressed twice to reach the settings gear when running .
He suggested we use checkboxes instead and combine with .
Need to assess which other actions we need to fix
I think it is possible using the quick pick api to render checkboxes for this. Let me un-assign Tyler and in case you need help with the API feel free to reach out to me and we can find the right usage.
Change:
for (const r of contentsBySource.contents.recommendations) { const extensionId = r.toLowerCase(); if (invalidExtensions.indexOf(extensionId) === -1) { <del> let recommendation = this._allWorkspaceRecommendedExtensions.filter(r => r.extensionId === extensionId)[0]; </del> <ins> let recommendation = tmpAllWorkspaceRecommendations.filter(r => r.extensionId === extensionId)[0]; </ins> if (!recommendation) { recommendation = { extensionId, sources: [] }; <del> this._allWorkspaceRecommendedExtensions.push(recommendation); </del> <ins> tmpAllWorkspaceRecommendations.push(recommendation); </ins> } if (recommendation.sources.indexOf(contentsBySource.source) === -1) { recommendation.sources.push(contentsBySource.source);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --In most recent insiders. <!-- Use Help Report Issue to prefill these. --Steps to Reproduce: " a few times, sometimes extensions will show up, but not have their badge. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
This may only be an issue in multi-root workspaces
Change:
insertingText = newIndentation + this.trimStart(movingLineText); } else { // no enter rule matches, let's check indentatin rules then. <del> virtualModel.getLineContent = (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.getLineContent(movingLineNumber); } else { return model.getLineContent(lineNumber); } </del> <ins> const virtualModel: IVirtualModel = { tokenization: { getLineTokens: (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.tokenization.getLineTokens(movingLineNumber); } else { return model.tokenization.getLineTokens(lineNumber); } }, getLanguageId, getLanguageIdAtPosition, }, getLineContent: (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.getLineContent(movingLineNumber); } else { return model.getLineContent(lineNumber); } }, </ins> }; const indentOfMovingLine = getGoodIndentForLine( this._autoIndent,

Discussion:
Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.
See and for similar/duplicates.
should be fixed by
Thanks for the fix!

Start with the following code: select the first method move it down
This reproduces for very simple examples:
See also and
Should be fixed with

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.0 OS Version: Windows 10 Home 22H2 build .4412 (+ WSL2 inside Win10) Steps to Reproduce: (similar to this issue: ) code: cursor at line 5 and perform 3 times. moved line is misplaced: In a vscode window opened in WSL this also happens: 1-WSL. Sample code: 2-WSL. Set cursor at line 2 and perform 3 times. 3-WSL. The last bracked is misplaced:
should be fixed by

<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When writing Lua code in VSCode, using Alt + Up/Down to move a line of code no longer automatically aligns the context of the code. Before the update, it would automatically align.
could you please help triage this issue? Thank you!
Hi yes thanks for the ping, this appears to be related to some recent auto-indentation changes I have made.
should be fixed with
Change:
@IInstantiationService private _instantiationService: IInstantiationService, @IRemoteAgentService private _remoteAgentService: IRemoteAgentService, @IViewsService private _viewsService: IViewsService, <ins> @IConfigurationService private readonly _configurationService: IConfigurationService, </ins> @IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService, @ITerminalEditorService private readonly _terminalEditorService: ITerminalEditorService, @ITerminalGroupService private readonly _terminalGroupService: ITerminalGroupService,

Discussion:
I noticed terminals can accept : Note that this does not map 1 to 1 to , you have to: offset properly: convert properly: //cc
Steps: open 2 empty editor groups, focus the first group execute a command that triggers below code [1] terminal opens in first group not second
Moving to September. //cc
Change:
await testObject.activationPromise; const recommendations = testObject.getAllRecommendationsWithReason(); <del> assert.ok(recommendations['ms-python.python'], 'ms-python.python extension shall exist'); assert.ok(!recommendations['mockpublisher2.mockextension2'], 'mockpublisher2.mockextension2 extension shall not exist'); assert.ok(!recommendations['ms-dotnettools.csharp'], 'ms-dotnettools.csharp extension shall not exist'); </del> <ins> assert.deepStrictEqual(Object.keys(recommendations), ['ms-python.python', 'mockpublisher1.mockextension1']); </ins> }); test('ExtensionRecommendationsService: Able to dynamically ignore/unignore global recommendations', async () => {

Discussion:
Cannot reproduce it locally. Will check how often this is failing.
I was able to reproduce this same bug locally with just using the . Reproduction: and select TypeScript (I also used and no ) Open and change the test to only have debugger for tests Output: ! VSCode install version: ! Happy to send along the reproduction project if needed edit: after more exploration, I found that all the other areas of worked. So using instead of is a workaround.+
Change:
const done = (value?: vscode.DebugSession) => { listener.dispose(); cancellationListener.dispose(); <del> this.lateDisposables.delete(listener); this.lateDisposables.delete(cancellationListener); </del> <ins> this.disposables.delete(listener); this.disposables.delete(cancellationListener); </ins> _resolve(value); };

Discussion:
I'm trying to use the configuration from website, but I'm facing a problem with the third option. I would like to use like these: and . But I can't find a way to achieve this with : Is it something possible? Thanks a lot
That launch config works for me and does what's expected. Note that the "serverReadyAction" in the latter config does not call the " debug client-side" launch config. For that you would want to use the and put in " debug client-side" for the .
Yes, I agree with you, both configurations are working as expected. I wasn't very clear in my first message, I will try to explain better. On my NextJs project, I can have the following configurations: The first one start the project and enables debugging on server side, the second one open chrome and enables debugging on client side. If I put on the second configuration, it will work just fine: What I want, is using the third configurations only to : start the project, enable debugging on server/client side and open chrome with my . Is it possible to achieve something like this ? I can't find any option in that case to make my working.
serverReadyAction doesn't accept additional configuration properties to pass to the launch config. The reason for this is mostly that intellisense doesn't work in that action (under the hood it's provided by a different extension) so writing configuration in the nested object is hard. The way to do this is define the separate launch config and reference it. Copying your original configuration set:
Your configuration plus two small additions almost give the result I'm looking for! I still have too issues with this: If I kill the (by clicking on the icon), is not automatically killed dispite the option. When I start , is automatically started, but I can see both elements here: !. Is it possible to hide the last one (wich should be automatically killed when is stopped)? I clearly saw that you explained to me why it was not possible to do this (use on a ) in a single configuration, but is there a "hacky" way the achieve my main goal? Or is something planned in the futur? Or maybe there is a way to fix my remaining concerns with the current configuration?

No, this is not possible and is not something we'd do, since you would not be able to control the debug session in that case. That's a bug, will put in a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
readonly location: vscode.Location; /** <del> * Resolve this input to a model that contains the actual data. When there are no result </del> <ins> * Resolve this input to a model that contains the actual data. When there are no result </ins> * than `undefined` or `null` should be returned. */ resolve(): vscode.ProviderResult<SymbolTreeModel<T>>; /** * This function is called when re-running from history. The symbols tree has tracked <del> * the original location of this input and that is now passed to this input. The </del> <ins> * the original location of this input and that is now passed to this input. The </ins> * implementation of this function should return a clone where the `location`-property * uses the provided `location` <del> * </del> <ins> * </ins> * @param location The location at which the new input should be anchored. * @returns A new input which location is anchored at the position. */

Discussion:
Ah, sorry for the breakage... I believe asking for both is the best option for now but I can also add a "migration" path into the implementation, e.g use when seeing Originally posted by in
Change:
const previewFrontMatter = vscode.workspace.getConfiguration('markdown')['previewFrontMatter']; const text = document.getText(); const contents = previewFrontMatter === 'hide' ? text.replace(FrontMatterRegex, '') : text; <del> const body = this.engine.render(contents); </del> <ins> const body = this.engine.render(sourceUri, contents); </ins> return `<!DOCTYPE html> <html>

Discussion:
The current behaviour of Code's Markdown previewer when clicking a relative link is actually a bit cryptic: it attempts to open the file relative to the user's home path with the system's application of choice. This will commonly lead to errors being dispatched because the file cannot be found. If I have the following Markdown: Clicking the link will make my system attempt to open . Given that even , I strongly believe that they should be supported here. Such links should instead be relative to the markdown file's directory and open the linked file using the Code editor.
+1; opening markdown files by clicking a (relative) link in the preview would be a very powerful feature both for writing developer documentation (split into individual files by topic) for a project, but also for viewing that documentation.
Related: Is this behavior something vscode could change for its markdown preview?
Change:
readonly minimumSize: number; /** <del> * A minimum size for this view. </del> <ins> * A maximum size for this view. </ins> * * @remarks If none, set it to `Number.POSITIVE_INFINITY`. */

Discussion:
Type: <bBug</bThe comment in line 55 of mentions a minimum size when it should be referring to a maximum size. VS Code version: Code 1.70.0 (, 2022-08-04T04:38:55.829Z) OS version: Darwin x64 21.6.0 Modes: <!-- generated by issue reporter --
Please open PRs for simple typos
Change:
}); }); <ins> test('filter by default source with "@source: " prefix', () => { const command = 'a' + uuid.generateUuid(); const expected = aResolvedKeybindingItem({ command, firstPart: { keyCode: KeyCode.Escape }, when: 'context1 && context2', isDefault: true }); prepareKeybindingService(expected); return testObject.resolve({}).then(() => { const actual = testObject.fetch('@source: default').filter(element => element.keybindingItem.command === command)[0]; assert.ok(actual); }); }); test('filter by user source with "@source: " prefix', () => { const command = 'a' + uuid.generateUuid(); const expected = aResolvedKeybindingItem({ command, firstPart: { keyCode: KeyCode.Escape }, when: 'context1 && context2', isDefault: false }); prepareKeybindingService(expected); return testObject.resolve({}).then(() => { const actual = testObject.fetch('@source: user').filter(element => element.keybindingItem.command === command)[0]; assert.ok(actual); }); }); </ins> test('filter by when context', () => { const command = 'a' + uuid.generateUuid(); const expected = aResolvedKeybindingItem({ command, firstPart: { keyCode: KeyCode.Escape }, when: 'whenContext1 && whenContext2', isDefault: false });

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.20.0-ins OS Version: win7x64 In we have a column called "Source". How about to create a filter called "source:user", so as "source:default", etc... ? !
any code-pointer to start on this?
Here it is -
hey! are you working on this? If not, I can take this.
I'm already started on this. Thanks for asking though.
sumitted a PR here. Care to comment / review.
Change:
} } <del> public goToNextModifiedBaseRange(onlyConflicting: boolean): void { </del> <ins> public goToNextModifiedBaseRange(predicate: (m: ModifiedBaseRange) => boolean): void { </ins> this.goToConflict( (e, l) => this.model.modifiedBaseRanges .get() .find( (r) => <del> (!onlyConflicting || r.isConflicting) && </del> <ins> predicate(r) && </ins> this.getRange(e, r, undefined).startLineNumber > l ) || this.model.modifiedBaseRanges .get() <del> .find((r) => !onlyConflicting || r.isConflicting) </del> <ins> .find((r) => predicate(r)) </ins> ); } <del> public goToPreviousModifiedBaseRange(onlyConflicting: boolean): void { </del> <ins> public goToPreviousModifiedBaseRange(predicate: (m: ModifiedBaseRange) => boolean): void { </ins> this.goToConflict( (e, l) => findLast( this.model.modifiedBaseRanges.get(), (r) => <del> (!onlyConflicting || r.isConflicting) && </del> <ins> predicate(r) && </ins> this.getRange(e, r, undefined).endLineNumberExclusive < l ) || findLast( this.model.modifiedBaseRanges.get(), <del> (r) => !onlyConflicting || r.isConflicting </del> <ins> (r) => predicate(r) </ins> ) ); }

Discussion:
Testing Clone Use the command and select the folder Select in the quick pick It looks like the file has 4 conflict Pressing "Go to Next Conflict" highlights the first conflict Pressing "Go to Next Conflict" again does not do anything Also interesting that the editor minimap only has one conflict marker
I also saw this. It seemed to happen when both inputs make the same change.
On , once it moves past the first conflict and try to go back to it, it doesn't go back to it properly. !
This is weird, I cannot reproduce this. Also, for , I only have 2 conflicts. And this checkbox is also very weird: !
I'm on commit , not the latest commit. Does that make a difference?
If you can reproduce on the latest commit, can you try to give me a call?
yup, things look good on the latest on master for diff-merge-datasets for demo1. :) One thing I noticed, though, is that, if you're focused on the result and try to skip to next conflict, it's hard to tell by looking at the two inputs where the conflict is (seems that the two inputs aren't telling me anything in this screenshot): ! When I make the input editors a little bigger, then it starts making a little more sense. ! Not too big of a deal though, just wanted to bring your attention to it!