jiebi/CodeConvo huggingface dataset:
Change:
const editorService = accessor.get(IEditorService); return showAccessibleOutput(accessibleViewService, editorService); <del> }, NOTEBOOK_OUTPUT_FOCUSED)); </del> <ins> }, ContextKeyExpr.and(NOTEBOOK_OUTPUT_FOCUSED, ContextKeyExpr.equals('resourceExtname', '.ipynb')) )); </ins> } }

Discussion:
Hello, I am using jupyter notebook with VsCode. Everything works pretty well, but when I display the output of a cell with control+down arrow, the screen reader announces the entire output cell, but I can't scroll through it line by line with the arrow keys. It would be helpful if the system cursor could scroll within the output cell as in an editor. I also searched within the options, but could not find one that would enable this feature. Germano
thanks for the feedback, we are currently trying to make some improvements in this exact area. I was using for improving the context when focusing on the cell output since, from my experimentation with the screen reader, it tended to jump around to different outputs, but your suggested change might just resolve that issue by better containing the reader within that single output.
Will be one of the reasons we add
can you consider doing this in July?
verification: run a cell with output, either click the output to focus it, or press ctrl+down (default) press alt+F2 output should be presented in an accessible view
I tried to verify with a GitHub Issues notebook, and here's what I get: <img width="1920" alt="image" src=""This view isn't scrollable via mouse or via keyboard arrow down.
support was for jupyter notebooks, not github issue notebooks. We probably shouldn't be showing anything for github issue notebooks for now
strange overflow behavior covered by verification (should only affect ipynb files): run a cell with output, either click the output to focus it, or press ctrl+down (default) press alt+F2 output should be presented in an accessible view
Change:
return chunks.join(); } <del> public discardMergeChanges(): void { this.resultTextModel.setValue(this.resultSnapshot); } </del> constructor( readonly base: ITextModel, readonly input1: InputData,

Discussion:
a merge editor a change, make sure there is one unhandled conflict left the VS Code window (or close and reopen VS Code) the merge editor matter what you do, the changes from step 2 will be written to disk I think this is because step 3 sets the base for the revert operation that takes place at step 5. Thus, when reverting the merge editor changes, it will write the contents of the file after step 3 to disk, no the contents of the file after step 1. I think if we no longer automatically remove conflict markers, we don't need to save and restore the original content anymore: The user does not have auto-save enabled: The user opens a merge editor. The file stays non-dirty. The user modifies the result by clicking on the checkboxes or changing text in the result. This will make the result file dirty. The user closes the file with the "x" on the tab. 1.1) The file contains unhandled conflicts: A prompt shows with the options , and 1.2) The file does not contain unhandled conflicts: A prompt shows with the options , and (same dialog when closing a dirty normal file) The user has auto-save enabled: The user opens a merge editor. The file stays non-dirty. The user modifies the result by clicking on the checkboxes or changing text in the result. The file stays non-dirty and is written to disk. The user closes the file with the "x" on the tab. 2.1) The file contains unhandled conflicts: A prompt shows with the options and 2.2) The file does not contain unhandled conflicts: No prompt is shown Maybe we don't even need the prompt for 2.1). Maybe all prompts could have a checkbox to stage the file after saving it. What do you think?
Change:
this._register(editor.onDidChangeCursorPosition(e => transaction(tx => { /** @description onDidChangeCursorPosition */ this.updateObservables(tx, VersionIdChangeReason.Other); <del> if (e.reason === CursorChangeReason.Explicit) { </del> <ins> if (e.reason === CursorChangeReason.Explicit || e.source === 'api') { </ins> this.model.get()?.stop(tx); } })));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (need GitHub Copilot and Vim only) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 OS Version: MacOS Steps to Reproduce: both GitHub Copilot and Vim. a suggestion from Copilot. escape to go to Vim's normal mode. around the cursor. get random suggestions all over the place which is quite annoying. This only happens with Copilot + Vim, and it only happens after the refactor was merged (). In general, my feel is that after the refactor, the inline completion feature has been way buggier. Here's a video. You can see how even though I am not in insertion mode, and I am not typing anything, I get random and annoying suggestions all over the place.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
The issue still persists.
I've had similar problems.
inline suggestion should only be triggered when . Will this be handled at the editor level?
~I wonder if vim navigation fires (because this triggers inline completions). But also, I don't think this changed with the rewrite, before onDidType would also trigger inline completions.~ It is that the cursor change reason is not .
can you verify if this is fixed in latest insiders?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified thank you works as expected now
For extension authors, do I also need to upgrade my vscode dependency to the latest version?
You can, but you don't need to.
/verified.
Change:
} GutterActionsRegistry.registerGutterActionsGenerator(({ lineNumber, editor, accessor }, result) => { <ins> const inlineChatService = accessor.get(IInlineChatService); const noProviders = Iterable.isEmpty(inlineChatService.getAllProvider()); if (noProviders) { return; } </ins> const configurationService = accessor.get(IConfigurationService); result.push(new Action( 'inlineChat.toggleShowGutterIcon',

Discussion:
a repo in click on the gutter :bug: Toggle Inline Chat Icon is present in the context menu
Also
Good catch thanks
It has been decided to mark this fix as a candidate and include it in the next recovery release
Change:
// Make visible this.isVisible = true; <del> // Focus if (focus) { const list = assertIsDefined(this.list); list.domFocus(); } </del> } private createNotificationsList(): void {

Discussion:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated
Change:
opacity: 0.4 !important; } <ins> .monaco-button-dropdown > .monaco-button.monaco-text-button { border-right-width: 0 !important; } </ins> .monaco-button-dropdown .monaco-button-dropdown-separator { padding: 4px 0; cursor: default;

Discussion:
You can see in the image that the split part doesn't look right. FYI my theme is ! /cc
//cc
I think this might be another style issue with the button border since the separator container use the full height: <img width="430" alt="CleanShot 2022-07-20 at 10 56 10 src="https://user-"If you don't set a border it looks normal: <img width="237" alt="CleanShot 2022-07-20 at 10 54 13 src="https://user-"
thanks for tracking this down. I will try to squeeze a fix in this week.
Change:
/** * Log the given warning message to the channel. * <del> * Messages are only printed when the user has enabled warn logging. </del> <ins> * Messages are only logged when the {@link LogOutputChannel.logLevel log level} is {@link LogLevel.Warn warn} or lower. </ins> * * @param message warning message to log */

Discussion:
Testing the API lacks an explanation of the interaction between channel log levels and app log levels. the comments of the individual log methods all have the form "Messages are only printed when the user has enabled xxx logging" but nowhere is explained how "xxx logging enablement" is related to the log level. I would rather expect something like "xxx messages are only logged when the log level is xxx or lower."
Change:
} async provideShare(item: IShareableItem, token: CancellationToken): Promise<URI | undefined> { <ins> const language = this.codeEditorService.getActiveCodeEditor()?.getModel()?.getLanguageId() ?? ''; </ins> const providers = [...this._providers.values()] <del> .filter((p) => score(p.selector, item.resourceUri, '', true, undefined, undefined) > 0) </del> <ins> .filter((p) => score(p.selector, item.resourceUri, language, true, undefined, undefined) > 0) </ins> .sort((a, b) => a.priority - b.priority); if (providers.length === 0) {

Discussion:
Testing My extension's provider is not receiving the within the passed to its I think this's caused by this -

Testing takes a but doesn't respect the selector's . I created an extension which uses Share Provider API, but its share contribution wasn't being invoked. It seems the language isn't being passed - see 3rd arg being an empty string .
I observe the same, using: registers the share provider, however as soon as I add a language, this is no longer the case
Change:
import { isLanguagePackExtension } from 'vs/platform/extensions/common/extensions'; import { registerThemingParticipant, IColorTheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; import { ThemeIcon } from 'vs/base/common/themables'; <del> import { foreground, listActiveSelectionForeground, listActiveSelectionBackground, listInactiveSelectionForeground, listInactiveSelectionBackground, listFocusForeground, listFocusBackground, listHoverForeground, listHoverBackground } from 'vs/platform/theme/common/colorRegistry'; </del> import { WORKBENCH_BACKGROUND } from 'vs/workbench/common/theme'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { HoverPosition } from 'vs/base/browser/ui/hover/hoverWidget';

Discussion:
The extension name becomes non-opaque as I hover over each extension name. https://user- cc
Seems like we've been playing whack-a-mole with the disabled state styles recently. any idea what's going on here?
It seems we have different ways to set the disabled color. Fixed it to use the defined disabled color that is already being used for description.
Thanks
Change:
import { AccessibleViewType, AdvancedContentProvider, ExtensionContentProvider } from 'vs/platform/accessibility/browser/accessibleView'; import { ContextKeyExpression } from 'vs/platform/contextkey/common/contextkey'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; <ins> import { alert } from 'vs/base/browser/ui/aria/aria'; </ins> export interface IAccessibleViewImplentation { type: AccessibleViewType;

Discussion:
a chat request that produces some code blocks the accessible view in screen reader mode the keyboard shortcuts or left/right arrows in the toolbar to verify that go to next/previous code block actions work sometimes the cursor doesn't move to the code block

several chat requests a chat response screen reader mode, use to open the accessible view the up arrow on the toolbar to go to the previous response see native alert dialog. it should instead be a screen reader aria alert. !

a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !
Change:
})); this._register(suggestController.widget.value.onDidHide(() => { this.isSuggestWidgetVisible = false; <del> this.setInactiveDelayed.schedule(); this.update(this._isActive); </del> <ins> this.update(false); </ins> })); this._register(suggestController.widget.value.onDidFocus(() => { this.isSuggestWidgetVisible = true;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Windows Steps to Reproduce: Have these internal settings enabled: "editor.inlineSuggest.allowQuickSuggestions": true, "editor.inlineSuggest.allowSuggestOnTriggerCharacters": true The Intellisense interaction with grey text is awesome! But I noticed some flickering. Here is the GIF. ! I grabbed screenshots to make the flickering clear: WLC prediction is in Italics ! When Intellisense is up, Intellisense text is in Italics and wlc prediction is not. ! When .is typed, there is a small latency where wlc prediction disappears. This is because . is a trigger character for Intellisense so first it will process Intellisense and then request the wlc inlineCompletionProvider. ! After that small latency, the wlc prediction shows up again in Italics ! So, the 2 main problems here are 1) When Intellisense pops up while walking the prediction, the prediction goes from Italics to non-Italics. It goes back to Italics when Intellisense is dismissed (either by manual dismissal or item committed). In VS, we keep the font for grey text the same regardless of whether Intellisense is up or not, that would be helpful in VS Code. 2) The small delay that happens when a trigger character is hit and the wlc prediction disappears and comes back again. cc
This is normal, I use Copilot and experience the same thing.

I believe this is not a bug but a slight delay in rendering.
I cannot reproduce: ! Please log all calls from VS Code into your implementation of the inline completions provider and send me that log.
Here are the logs, lmk if you need anything else.
I was able to repro the bug in code-oss. ghostText is indeed when the flickering happens. I captured a GIF of the logs so you can see at what point ghostText becomes undefined. ! Here are the logs
I was also able to repro this bug in the sample extension. I used the extension from here - !
Verified that inline completions do not flicker anymore.
Change:
addToHistory(input: string): void { this._inlineChatWidget.addToHistory(input); this._inlineChatWidget.saveState(); <ins> this._inlineChatWidget.value = input; this._inlineChatWidget.selectAll(true); </ins> } setValue(value?: string) { this._inlineChatWidget.value = value ?? '';

Discussion:
VSCode Version: 0.10.11 OS Version: OSX 10.10 Is it possible to use the .es6 file extension, and still have the editor enable intellisense appropriately? For instance, I have some projects that use the ".es6" extension, and keywords like "module" have red lines under them, and the file isn't processed in the same way that a .js file is. Renaming the file to .js fixes the issues (but isn't always an option, due to internal project reasons).
In the latest you can associate file extensions to languages and the association is persisted, pls see:
Change:
const testRow = 339; const testCol = 12; const testRowEnd = 341; <del> const testColEnd = 14; </del> <ins> const testColEnd = 789; </ins> const testLinks: ITestLink[] = [ // Simple { link: 'foo', prefix: undefined, suffix: undefined, hasRow: false, hasCol: false }, { link: 'foo:339', prefix: undefined, suffix: ':339', hasRow: true, hasCol: false }, { link: 'foo:339:12', prefix: undefined, suffix: ':339:12', hasRow: true, hasCol: true }, <ins> { link: 'foo:339:12-789', prefix: undefined, suffix: ':339:12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo:339.12-341.789', prefix: undefined, suffix: ':339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> { link: 'foo:339.12', prefix: undefined, suffix: ':339.12', hasRow: true, hasCol: true }, <ins> { link: 'foo:339.12-789', prefix: undefined, suffix: ':339.12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo:339.12-341.789', prefix: undefined, suffix: ':339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> { link: 'foo 339', prefix: undefined, suffix: ' 339', hasRow: true, hasCol: false }, { link: 'foo 339:12', prefix: undefined, suffix: ' 339:12', hasRow: true, hasCol: true }, <ins> { link: 'foo 339:12-789', prefix: undefined, suffix: ' 339:12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo 339:12-341.789', prefix: undefined, suffix: ' 339:12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> { link: 'foo 339.12', prefix: undefined, suffix: ' 339.12', hasRow: true, hasCol: true }, <del> { link: 'foo 339.12-14', prefix: undefined, suffix: ' 339.12-14', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo 339.12-341.14', prefix: undefined, suffix: ' 339.12-341.14', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </del> <ins> { link: 'foo 339.12-789', prefix: undefined, suffix: ' 339.12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo 339.12-341.789', prefix: undefined, suffix: ' 339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> // Double quotes { link: '"foo",339', prefix: '"', suffix: '",339', hasRow: true, hasCol: false },

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --When working on Haskell code, may produce error output in the following format: It would be nice to have terminal link detection support for this format (or, to discard the part and just jump to the start column). Currently, this format seems to trip up the parser: it detects the file, line number, and start column correctly, but then it seems to select backwards to near the start of the file. (Note: ghcid seems to treat the end column index as inclusive, i.e. the cursor is before the last notable character.)
Can reproduce: ! Selects from 1:3 to 115 !
What is detected:
Caused by a bad regex match: !
Change:
arguments: [this.repository.sourceControl], }, description: `${icon}${behind}${ahead}`, <del> enabled: !this.state.isSyncInProgress </del> <ins> enabled: !this.state.isCheckoutInProgress && !this.state.isSyncInProgress </ins> }; } private onDidChangeOperations(): void { <ins> const isCheckoutInProgress = this.repository.operations.isRunning(OperationKind.Checkout) || this.repository.operations.isRunning(OperationKind.CheckoutTracking); </ins> const isCommitInProgress = this.repository.operations.isRunning(OperationKind.Commit) || this.repository.operations.isRunning(OperationKind.PostCommitCommand) ||

Discussion:
Type: <bBug</bto an existing branch from . Control Side panel then shows Sync Changes button. , clicking on Sync button causes to commits from previous branch to merge into current branch VS Code version: Code 1.74.3 (, 2023-01-09T16:59:02.252Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ laravel-blade1.1.2 jupyter-keymap1.0.0 remote-wsl0.72.0 alignment0.3.0 vscode-log-viewer0.12.2 vscode-intelephense-client1.9.4 gitlens13.2.0 cmake-tools1.13.44 cpptools1.13.9 cpptools-extension-pack1.3.0 laravel-blade1.32.0 cmake0.0.17 php-debug1.30.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .markdown-cell-row { padding-bottom: ${CELL_BOTTOM_MARGIN}px; }`); collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .markdown-cell-row .cell-bottom-toolbar-container { margin-top: ${CELL_BOTTOM_MARGIN}px; }`); collector.addRule(`.notebookOverlay .output { margin: 0px ${CELL_MARGIN}px 0px ${CODE_CELL_LEFT_MARGIN + CELL_RUN_GUTTER}px; }`); <del> collector.addRule(`.notebookOverlay .output { width: calc(100% - ${CODE_CELL_LEFT_MARGIN + CELL_RUN_GUTTER + CELL_MARGIN}px); }`); </del> <ins> collector.addRule(`.notebookOverlay .output { width: calc(100% - ${CODE_CELL_LEFT_MARGIN + CELL_RUN_GUTTER + (CELL_MARGIN * 2)}px); }`); </ins> collector.addRule(`.notebookOverlay .cell-bottom-toolbar-container { width: calc(100% - ${CELL_MARGIN * 2 + CELL_RUN_GUTTER}px); margin: 0px ${CELL_MARGIN * 2}px 0px ${CELL_MARGIN + CELL_RUN_GUTTER}px; }`); collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .monaco-list-row  > div.cell.markdown { padding-left: ${CELL_RUN_GUTTER}px; }`);

Discussion:
todays insiders run on the right hand side <img width="446" alt="Screenshot 2020-07-03 at 10 28 15" src="https://user-"
Forgot to update the output width when I increased the right side margin. Will create a release candidate PR and will assign this to the recovery milestone when it gets created.
Change:
import { toDisposable } from 'vs/base/common/lifecycle'; import { mainWindow } from 'vs/base/browser/window'; import { QuickPick } from 'vs/platform/quickinput/browser/quickInput'; <del> import { IQuickPickItem } from 'vs/platform/quickinput/common/quickInput'; </del> <ins> import { IQuickPickItem, ItemActivation } from 'vs/platform/quickinput/common/quickInput'; </ins> import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; import { IThemeService } from 'vs/platform/theme/common/themeService'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

Discussion:
Steps to Reproduce: the web UI "Open Folder" in a path that exists on disk and enter <img width="791" alt="image" src=""
This is weird. The in the quick pick don't appear to be getting updated.
Also, not just in web.
Git bisect points to
I don't see anything super obvious in , but here's the behavior I can observe: simple file picker sets the does not get reset. The old behavior is that it would get reset.
Clearing here fixes things, but I don't think that's the right fix: