jiebi/CodeConvo huggingface dataset:
Change:
this.setEditorHidden(!visible, true); } this._onDidChangePartVisibility.fire(); <ins> this._onDidLayout.fire(this._dimension); </ins> })); }

Discussion:
use web (windows?) use with open quick pick, all is good change to open quick pick, the top position is wrong <img width="1394" alt="Screenshot 2022-05-12 at 16 53 01" src="https://user-"This is because is only ready after a layout change event and that event isn't triggered by the title bar change. Once you resize the window (or force another layout) things will recover
fyi
I will push a fix as part as a title menu effort (the title menu being overlayed by QP)
Sorry, I was wrong about that... I could figure out on the spot what event is missing. Sorry, passing it on
Change:
await this.commitWithAnyInput({ all: false, signoff: true }); } <ins> @command('git.commitStagedAmend') async commitStagedAmend(): Promise<void> { await this.commitWithAnyInput({ all: false, amend: true }); } </ins> @command('git.commitAll') async commitAll(): Promise<void> { await this.commitWithAnyInput({ all: true });

Discussion:
Like: git commit --amend
Are you referring to the out of the box git behavior or any particular git extension?
I would guess the out of the box behaviour, because it seems to be missing? I can see there is an "undo last commit", but this unstages everything from the last commit, which is not the same thing as amending the current commit. git-gui and atom have a simple checkbox which then amends the current commit instead of creating a new one - would it be possible to have the same in vscode? It's the one thing that stops me using vscode's built in git interface. In other words, you should be able to check and then uncheck the checkbox and be left in the original state. With the "undo last commit", this isn't possible.
Yes, out of the box
command was some time ago by
Should there be something in the menu? Please can you tell me where the option is?
Hmmm.... looks like it has disappeared for some reason, probably was omitted when git integration was ported to new API... will probably know if it was by-design, or just someone missed one command while porting git integration.
I believe we simply missed it... sorry for that.
I'll add it again.
Change:
} async toggleRecommendation(extensionId: string): Promise<void> { <ins> extensionId = extensionId.toLowerCase(); </ins> const workspace = this.workspaceContextService.getWorkspace(); const workspaceExtensionsConfigContent = workspace.configuration ? await this.resolveWorkspaceExtensionConfig(workspace.configuration) : undefined; const workspaceFolderExtensionsConfigContents = new ResourceMap<IExtensionsConfigContent>();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: MacOS Monterey 12.3.1 Steps to Reproduce: any directory or workspace, empty directory in the video below for example. Extensions tab, search "volar", then add first two extensions, and into workspace recommendations. : Every time you try to add one of these two extensions, the newly extension id in is a string start with a upper case like "", and the rest of others will change to all lower case string like "", this makes further "Add to Workspace Recommendations" oprations work incorrectly. https://user- My guessing: The function and returns an array of lowercase strings, however those adding or removing functions only push the raw extensionId to config file, which causes this bug when the raw extensionId has upper case.
I am not sure what the bug is here? Since extension ids are case insensitive, we handle them correctly while reading or writing. Can you please let us know what feature is not working?
Well, a simple description: you can click twice when adding first time it will add "" string and second time "". https://user-
Got it. Thanks for providing info.
Change:
import { IChatCodeBlockContextProviderService } from '../../chat/browser/chat.js'; import { ICodeBlockActionContext } from '../../chat/browser/codeBlockPart.js'; import { getSimpleEditorOptions } from '../../codeEditor/browser/simpleEditorOptions.js'; <ins> import { Schemas } from '../../../../base/common/network.js'; import { ITextModelContentProvider, ITextModelService } from '../../../../editor/common/services/resolverService.js'; </ins> const enum DIMENSIONS { MAX_WIDTH = 600

Discussion:
Testing Repro: "getting started with accessiblity features" second step click on blue button to "open accessible view" results in an error in dev console says that "the editor is not accessible at this time" and advises to turn on screen optimized view, but I already have that on as you can see in status bar item. Version: 1.94.0-insider Commit: Date: 2024-09-24T05:04:12.797Z Electron: 30.5.1 ElectronBuildId: Chromium: 124.0.6367.243 20.16.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0
As part of this flow - I was also confused why a new file is opened after I close the Accessible View: !
I'm getting "the editor is not accessible at this time" messages while moving focus to the Python REPL input box or the Copilot Chat input box !
seems like an issue with the walkthrough accessible view?
this looks an issue with the accessible view editor. I'm seeing a similar issue when I open the chat-panel and request the accessible view.
Change:
width = dom.getTotalWidth(containerDomNode); this._contentWidth = width; this._updateMinimumWidth(); <del> this._updateResizableNodeMaxDimensions(); </del> this._resizableNode.layout(height, width); if (this._hasHorizontalScrollbar()) {

Discussion:
In stable: In today's insiders: is too small for its contents second resize, I can't extend the hover to the right enough to fit the content, so I have to also resize up , note how resizing is difficult because hover disappears too easily
I put the important label because hover became very hard to use. Feel free to remove it
Change:
this.focus = new Trait(() => this.view.getFocusedElements()[0], _options.identityProvider); this.selection = new Trait(() => this.view.getSelectedElements()[0], _options.identityProvider); this.anchor = new Trait(() => this.view.getAnchorElement(), _options.identityProvider); <del> this.view = new TreeNodeList(_user, container, this.treeDelegate, this.renderers, this.focus, this.selection, this.anchor, { ...asListOptions(() => this.model, _options), tree: this }); </del> <ins> this.view = new TreeNodeList(_user, container, this.treeDelegate, this.renderers, this.focus, this.selection, this.anchor, { ...asListOptions(() => this.model, _options), tree: this, stickyScrollProvider: () => this.stickyScrollController }); </ins> this.model = this.createModel(_user, this.view, _options); onDidChangeCollapseStateRelay.input = this.model.onDidChangeCollapseState;

Discussion:
Testing Repro: a node in a tree that is fairly deep. a parent node. that there's a slight flicker. Consecutive collapse/expands don't have that, only the first. ]()
Change:
import { localize } from 'vs/nls'; import { ITerminalInstance } from 'vs/workbench/contrib/terminal/browser/terminal'; import { TerminalCapability } from 'vs/platform/terminal/common/capabilities/capabilities'; <del> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { TerminalSettingId } from 'vs/platform/terminal/common/terminal'; export function getShellIntegrationTooltip(instance: ITerminalInstance, markdown: boolean, configurationService: IConfigurationService): string { if (!configurationService.getValue(TerminalSettingId.ShellIntegrationEnabled) || instance.disableShellIntegrationReporting) { return ''; } </del> <ins> export function getShellIntegrationTooltip(instance: ITerminalInstance, markdown: boolean): string { </ins> const shellIntegrationCapabilities: TerminalCapability[] = []; if (instance.capabilities.has(TerminalCapability.CommandDetection)) { shellIntegrationCapabilities.push(TerminalCapability.CommandDetection);

Discussion:
Testing It turns out "Run Recent Command" works both with shell integration disabled and enabled, but I wasn't seeing the shell integration prompt on Windows. I'm using pwsh 7. When I disable shell integration, I see the header that tells me I'm using version 7. When I enable shell integration, I see just the prompt. My profile references the following script:
what do you mean that your profile references that script? could you provide the profile you're using?
also what's the value of your ?
PS1: Init script: Screenshot: ! Edit: I just realized the word prompt isn't what I meant. Changed the issue title.
oh you should see it only on hover of the icon in the tab list.
we changed this so no longer show in the buffer
It doesn't seem to be in the tab list icon hover: !
I think this is working as designed since we hid the message? This is also by design, it's just populating that list that only happens when shell integration is enabled.
Oh it should be on the tab hover though.
not seeing it on mac either
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
import { PatternInputWidget, ExcludePatternInputWidget } from 'vs/workbench/parts/search/browser/patternInputWidget'; import { SearchRenderer, SearchDataSource, SearchSorter, SearchAccessibilityProvider, SearchFilter } from 'vs/workbench/parts/search/browser/searchResultsView'; import { SearchWidget, ISearchWidgetOptions } from 'vs/workbench/parts/search/browser/searchWidget'; <del> import { RefreshAction, CollapseAllAction, ClearSearchResultsAction } from 'vs/workbench/parts/search/browser/searchActions'; </del> <ins> import { RefreshAction, CollapseDeepestExpandedLevelAction, ClearSearchResultsAction } from 'vs/workbench/parts/search/browser/searchActions'; </ins> import { IReplaceService } from 'vs/workbench/parts/search/common/replace'; import Severity from 'vs/base/common/severity'; import { IUntitledEditorService } from 'vs/workbench/services/untitled/common/untitledEditorService';

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
this.toDispose.push(this.session.addListener2(debug.SessionEvents.OUTPUT, (event: DebugProtocol.OutputEvent) => { if (event.body && event.body.category === 'telemetry') { <del> this.telemetryService.publicLog(event.body.output, event.body.data); </del> <ins> const key = this.configurationManager.getAdapter().aiKey; // only log telemetry events from debug adapter if the adapter provided the telemetry key if (key) { if (!this.telemetryAdapter) { this.telemetryAdapter = new AIAdapter(key, this.session.getType()); } this.telemetryAdapter.log(event.body.output, event.body.data); } </ins> } else if (event.body && typeof event.body.output === 'string' && event.body.output.length > 0) { this.onOutput(event); }

Discussion:
If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).
this is probably something you want to use...
The functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .
we are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?
yes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?
What we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.
For Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?
previously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.
Change:
private async listExtensions(showVersions: boolean, category?: string): Promise<void> { let extensions = await this.extensionManagementService.getInstalled(ExtensionType.User); <del> if (category) { </del> <ins> // TODO: we should save this array in a common place so that the command and extensionQuery can use it that way changing it is easier const categories = ['"programming languages"', 'snippets', 'linters', 'themes', 'debuggers', 'formatters', 'keymaps', '"scm providers"', 'other', '"extension packs"', '"language packs"']; if (category && category !== '') { if (categories.indexOf(category.toLowerCase()) < 0) { console.log('Invalid category please enter a valid category. To list valid categories run --category without a category specified'); return; } </ins> extensions = extensions.filter(e => { if (e.manifest.categories) { const lowerCaseCategories: string[] = e.manifest.categories.map(c => c.toLowerCase());

Discussion:
Testing More of a feature request, it would be great if you didn't supply a category when running that it would print out a list of categories available (like below). I could always go to the extension viewlet and run but that's an extra step and would be nice to show the options inline. <img width="276" alt="image" src="https://user-"
Also tried running this for extension packs and tried to guess the format, printing out the category names would've helped here: <img width="604" alt="image" src="https://user-"

Testing When entering a category that does not exists (e.g. 'theme' instead of 'themes') then there is no feedback that the category does not exist.
Change:
showOptionButtons?: boolean; checkImeCompletionState?: boolean; showResultCount?: boolean; <ins> appendCaseSensitiveLabel?: string; appendRegexLabel?: string; appendWholeWordsLabel?: string; type?: 'Terminal' | 'Webview'; </ins> } export abstract class SimpleFindWidget extends Widget {

Discussion:
And instead pass in (or don't) a new option for the type
so the complexity here is that we can't reference the keybinding service within the super call to the constructor and need to do that to provide the options to the find input object that's read only.
the alternative would be to pass in the options from both the terminal view and terminal editor (redundant)
going to pass in an options object and handle the keybinding in simple find widget
Spent awhile on this, don't think we will get to it
Change:
.monaco-menu .monaco-action-bar.vertical .keybinding { font-size: inherit; padding: 0 2em; <del> overflow: hidden; </del> max-height: 100%; }

Discussion:
Type: <bBug</bObserved on SCM view: ! VS Code version: Code - Insiders 1.89.0-insider (, 2024-04-05T05:52:23.778Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (52)</summaryExtensionVersion ------ Bookmarks13.5.0 tsl-problem-matcher0.6.2 open-in-github-button0.1.1 vscode-opennewinstance0.0.12 vscode-eslint2.4.4 githistory0.6.20 prettier-vscode10.4.0 vscode-open-in-github2.2.1 intersystems-dxjetpack0.1.2 searchable-debug-console0.0.2 thefoldingstuff0.2.1 codespaces1.16.18 copilot1.178.0 copilot-chat0.15.

vscode-github-actions0.26.2 vscode-pull-request-github0.86.0 vscode-memfs0.0.3- vscode-favorites1.11.0 rest-client0.25.1 vscode-pr-pinger0.0.6 workspace-storage-cleanup1.1.5 vscode-docker1.29.0 debugpy2024.4.0 python2024.4.0 vscode-pylance2024.4.1 jupyter2024.3.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.9 vscode-jupyter-powertoys0.1.1 vscode-jupyter-slideshow0.1.6 remote-containers0.354.0 remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-wsl0.88.0 azure-account0.11.6 extension-test-runner0.0.9 hexeditor1.9.14 live-server0.4.13 remote-explorer0.4.3 remote-server1.5.1 vscode-github-issue-notebooks0.0.130 vscode-js-profile-flame1.0.9 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.8.0 material-icon-theme4.34.0 material-product-icons1.7.0 vscode-thunder-client2.20.3 vscode-xml0.26.1 rest-book6.2.1 luna-paint0.16.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
I used Culprit is by
Change:
this._createTree(this._treeContainer); <del> this._treeViewModel = this.instantiationService.createInstance(SCMHistoryViewModel); this._register(this._treeViewModel); </del> this.onDidChangeBodyVisibility(async visible => { if (!visible) { this._visibilityDisposables.clear(); return; } <del> // Clear repository state this._treeViewModel.clearRepositoryState(); </del> <ins> // Create view model this._treeViewModel = this.instantiationService.createInstance(SCMHistoryViewModel); this._visibilityDisposables.add(this._treeViewModel); </ins> // Initial rendering await this._progressService.withProgress({ location: this.id }, async () => {

Discussion:
Type: <bBug</bspecific branches to display on the graph (in my case main, origin/main and upstream/main). VS Code, or close and reopen the workspace. has reverted to 'Auto' VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-11T05:04:03.124Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
even if you move away from the source control tab and come back it is changed back to auto.
I'm not seeing that happen on today's Insiders.
ohh, may be i am on different version than you. (i do not see a pending update though) Version: 1.94.0-insider Commit: Date: 2024-09-11T05:04:03.124Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
Change:
if (success.status === 200) { try { const obj = JSON.parse(success.responseText); <del> if (obj && Array.isArray(obj.results)) { const objects = <{ package: SearchPackageInfo }[]>obj.results; </del> <ins> if (obj && Array.isArray(obj.objects)) { const objects = <{ package: SearchPackageInfo; }[]>obj.objects; </ins> for (let object of objects) { this.processPackage(object.package, addValue, isLast, collector); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi So I noticed that the autocomplete is slow to update or can sometimes return wrong/outdated information. For example: if a package releases a patch / new version, it can take hours, maybe days until the autocompletion also suggests that version. My second concern about this is that it's actually using which is not run by npm and they have a separate which users are not aware of when using this VS Code extension. Source code From a privacy policy perspective / GDPR and also reliability issues it seems appropriate to remove all usage of this third-party API and only use npm's. Relevant past issues about npms from this repository (I found many more in other repositories):
To verify, check that code completion in dependencies of work as expected. run VSCode in a environment where is not on the path, and use hovers over dependencies of . as dependency and verify that the hover shows the actual latest version (currently 15)
Change:
*--------------------------------------------------------------------------------------------*/ import { EditorContributionInstantiation, registerEditorContribution } from 'vs/editor/browser/editorExtensions'; <del> import { ToggleStickyScroll, FocusStickyScroll, SelectPreviousStickyScrollLine, SelectNextStickyScrollLine, GoToStickyScrollLine } from 'vs/editor/contrib/stickyScroll/browser/stickyScrollActions'; </del> <ins> import { ToggleStickyScroll, FocusStickyScroll, SelectEditor, SelectPreviousStickyScrollLine, SelectNextStickyScrollLine, GoToStickyScrollLine } from 'vs/editor/contrib/stickyScroll/browser/stickyScrollActions'; </ins> import { StickyScrollController } from 'vs/editor/contrib/stickyScroll/browser/stickyScrollController'; import { registerAction2 } from 'vs/platform/actions/common/actions';

Discussion:
Testing around an open file in the editor with Stick Scroll enabled. Sticky Scroll Try to move focus out of Sticky Scroll. Tried pressing . Tried running "Focus Sticky Scroll" command a second time. Only way to get focus back to the editor is to select a level and press . I think should put you back into the editor
Change:
this._updateWidgetWidth(); } })); <ins> this._register(this._editor.onDidChangeModel(() => updateScrollLeftPosition())); </ins> updateScrollLeftPosition(); this._register(this._editor.onDidLayoutChange((e) => {

Discussion:
This issue appears to occur under the following conditions: two files that render sticky lines in one file to the right so that sticky scroll is sideways scrolled (you may need to enable the sideways scrolling setting on sticky scroll) the second file, observe that the sticky lines are not there
Change:
getAnchor: () => e, getActions: () => this.textInputActions, getActionsContext: () => target, <del> onHide: () => target.focus() // fixes https://github.com/microsoft/vscode/issues/52948 </del> }); } }

Discussion:
click to open context menu in text editor +P to open quick open :bug: both context menu and quick open are dismissed !
re: context menu
This is not a regression so assigning to december
I'm going to pass to you for your take. Here's what I found out. When we show the command palette that causes the editor context menu to trigger the hide: This hide, focuses the editor... but in doing so, that causes the Quick Pick's didBlur to hide: which will hide the quick pick if is set to which is the default. This behavior with context menus seems to repro: Always in context menus of the editor Only with custom menus (not native menus) in the rest of the product (tree views, Account/Gear menu, etc)
Two actions here: needs to be removed or handled better (passing that to or menus should follow the logic: if ESC/selection, focus what was previously focused. If dismissed due to focus lost, don't restore focus (this goes to
my suspicion is that the editor contribution is old and unnecessary as the behavior is built-in to the menu widget. Removing it, we can centralize the logic to the menu widget.
re-opening as we still have some work to do on the custom menu side