jiebi/CodeConvo huggingface dataset:
Change:
if (ctx.leadingWord.word.length !== 0 && ctx.leadingWord.startColumn > this._context.leadingWord.startColumn) { // started a new word while IntelliSense shows -> retrigger but reuse all items that we currently have <del> const map = this._completionModel.getItemsByProvider(); this.trigger({ auto: this._context.auto, retrigger: true, clipboardText: this._completionModel.clipboardText, completionOptions: { providerItemsToReuse: map } }); </del> <ins> if (LineContext.shouldAutoTrigger(this._editor)) { const map = this._completionModel.getItemsByProvider(); this.trigger({ auto: this._context.auto, retrigger: true, clipboardText: this._completionModel.clipboardText, completionOptions: { providerItemsToReuse: map } }); } </ins> return; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.1 (Universal) and 1.75.0-insider (Universal) OS Version: macOS 12.5.1 Steps to Reproduce: the extension in VS Code and run the "Run Extension" task from the "Run and Debug" panel a new untitled file and change the language to "TypeScript JSX" the file contents to the cursor in between the quotes: completions manually should see two completions provided by the extension, and this point the completions should still be visible this point the completion list should still be open, but it has closed you type instead of then the list stays open as expected This behaviour seems to have changed recently because it worked as expected in the September release (and maybe the October one?)
I can reproduce but I am not quite sure what's happening. It seems like typing is understood as entering a new word and retriggering completions. That carries over the existing items (foo-20 and foo-hello) and they should be kept stable. However, the also seems to be a trigger character which cancels the pending request, loses the in-flight items, and retriggers only for the provider that is triggered by that character
Emmet is the provider that is triggered by the 2. <img width="808" alt="Screenshot 2022-12-16 at 13 44 33" src="https://user-"
Change:
override run(accessor: ServicesAccessor, ...args: any[]): void { convertNotebookIndentation(accessor, true); } }

Discussion:
to repro: click notebook indentations statusbar entry run "indent using spaces/tabs" and select a new number entry will not update, however indentations work correctly given the selection that the user made and the current settings.

No a "choose intentation type" entry in status bar when editing in a notebook. I have a notebook with tab indentation but it seems theres some global spaces setting that overrides it... even pasting a literal tab charachter inserts spaces :/ !
False alarm. The status bar entry just moved so much that I didn't see it right away, and it has a different name in the status bar entries context menu.
Actually, looks like the status bar is really slow to update. I saw it update eventually, but I'm not sure what caused it to finally show the correct thing. !
Change:
this._process = null; } this._onDisposed.fire(this); <del> this._toDispose = lifecycle.dispose(this._toDispose); </del> <ins> this._processDisposables = lifecycle.dispose(this._processDisposables); this._instanceDisposables = lifecycle.dispose(this._instanceDisposables); </ins> } public focus(force?: boolean): void {

Discussion:
From
For January we decided to keep the task in the core. So there is no need to make this 'public' API now. May be it would be good to first experiment a little with the new API.
just to make sure, were you thinking of using a prompt (press any key to close) that can be reused? Or a terminal that executes something, the pty process dies and just sits there ("dead") until another task command is sent?
I would like to achieve the following: create a new terminal and allow terminal reuse (could be an additional option) without actually running a terminal right away (if necessary we could run it as well) run a command in the terminal. This will create the actual shell process. Usually the shell would be started with /c receive an exit event when the shell exists reuse the terminal to run another command in the terminal which creates a new shell process. Use case if for a build task: if the user runs the build tasks 3 times in a row I would like to have one terminal (e.g. on entry in the drop down in the terminal pane) which contains the output of all three task runs.
I have one additional question. Does the terminal require to run a shell or would the terminal be able to run any other arbitrary process (for example a ).
I got it working to run an arbitrary program. Only drawback is that I needed to specify the full path to the program (e.g. ). Any idea why this is the case?
do you mean the shell path you're using is and it's not working like that? I guess the resolution stuff is contained within , I would think it would probably be safest to always wrap the command within or . Wrapping the command means the process will die when it finishes so I don't see a downside?
the only problem is argument passing with spaces contained. If you call node directly then you pass the args as a string[]. If you call the for example you need to construct a single string with proper arg quoting to ensure everything works when for example the command to call contains spaces. And you save a process :-)
could this be useful for Python terminal execution?
Change:
tsServerLog = { type: 'file', uri: logFilePath }; args.push('--logVerbosity', TsServerLogLevel.toString(configuration.tsServerLogLevel)); <del> args.push('--logFile', `"${logFilePath.fsPath}"`); </del> <ins> args.push('--logFile', logFilePath.fsPath); </ins> } } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0 OS Version: Darwin x64 23.2.0 Steps to Reproduce: custom node: any ts project. . The log file is not generated actually.
After attaching to the tsserver with , I see a strange error:
I set "typescript.tsserver.nodePath" to be a script which echos its CLI args and it also shows that the spaces aren't be escaped properly in This looks like a bug in ( which will likely be broken for any Mac user, including one that commented on the original PR
This should already be fixed:
I'll double-check when I get a free moment, but I swear I had updated to the latest version of VSCode when I was testing last week.
I've verified my installation is up-to-date and I still am getting a TSServer crash. I can't find any relevant logs that would indicate the cause of failure. What I do know is that using my (TS 5.2.2) works fine. <img width="1198" alt="" src=""
I found another bug, the log file path is also not being escaped if one has enabled. All of my logs are being written to rather than
this is still an issue as of VSCode 1.88.0
Also I just noticed the description of contains Can you update your review process to ensure that someone with a MacOS machine tests changes?
The ts server seems to just crash and attempt to start in a loop forever. nothing is in the log folder from the logs. my settings:
Can confirm this still crashes on windows.

Seems to work fine for me on Mac. Taking a look now
Seems risky to fix given that this areas has caused problems before so moving to June
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
} if (linkToOpen) { <del> this.openerService.open(linkToOpen, { fromUserGesture: true, allowCommands: true, fromWorkspace: true }); </del> <ins> this.openerService.open(linkToOpen, { fromUserGesture: true, allowCommands: false, fromWorkspace: true }); </ins> } break; }

Discussion:
A remote code execution vulnerability exists in VS Code 1.71 and earlier versions for malicious notebooks. These notebooks could use command uris to execute arbitrary commands, including potentially dangerous commands The fix is available starting with VS Code 1.71.1. The mitigates this attack by performing input validation on the URL pointing to the repository to be cloned. Do not open notebooks from untrusted sources. The patch for this can be found at An advisory for this can be found at MSRC details for this can be found at
the docs and advisories say it's fixed in 1.71.1, but it's only fixed in 1.72.1
Change:
padding-left: 1px; } <ins> .monaco-editor .comment-range-glyph.comment-thread:before { content: "ea6b"; } .monaco-editor .comment-range-glyph.comment-thread-unresolved:before { content: "ec0a"; } </ins> .monaco-editor.inline-comment .margin-view-overlays .codicon-folding-expanded, .monaco-editor.inline-comment .margin-view-overlays .codicon-folding-collapsed { margin-left: 11px;

Discussion:
Comments in the editor have a different color based on their resolved status. We could do something similar for the icon in the gutter, and make obvious which comment is resolved even when comments are folded. Maybe change the icon color? Or use a different icon? (also related to )
Example of how it currently looks: ! Example with adjusted colours: ! Note that colour alone is not a full solution since it is not that accessible, but I think it should be included in the final solution.
A different icon/unicode character for resolved would be good here.
Let's get done first.
Change:
return mdLs!.getDocumentHighlights(document, params.position, token); }); <ins> return registerDynamicClientFeature(configurationManager, (settings) => !!settings?.markdown.occurrencesHighlight.enabled, () => { const registrationOptions: DocumentHighlightRegistrationOptions = { documentSelector: null, }; return connection.client.register(DocumentHighlightRequest.type, registrationOptions); }); </ins> }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: macOS 12.1 21C52 x86_64 Recently upgraded to 1.73 and no longer seeing selection highlighting. <img width="1728" alt="Screen Shot 2022-11-09 at 8 44 07 AM" src="https://user-"Default setting still and set on the user level as well to no avail. <img width="1728" alt="Screen Shot 2022-11-09 at 8 41 34 AM" src="https://user-"<img width="803" alt="Screen Shot 2022-11-09 at 8 41 56 AM" src="https://user-"
I am only seeing this in Markdown (including code blocks) but not source code.
The problem seems to be that previously you'd get a match if the cursor was at the start of the word but now only if you select/highlight the entire word (or subset). If this is a change in functionality, any way to update settings to restore previous out-of-box behavior?
I believe this might be caused by markdown now registering a document highlight provider. When a language registers a document highlight provider, the non-semantic based, text editor word highlight takes a back seat. I think you can turn this down via , or maybe . Let me loop in , maybe he has more ideas.
Change:
comment: ['Label for action that will decrease the hover verbosity level.'] }, "Decrease Hover Verbosity Level"), alias: 'Decrease Hover Verbosity Level', <del> precondition: EditorContextKeys.hoverFocused, kbOpts: { kbExpr: EditorContextKeys.hoverFocused, primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KeyK, KeyMod.CtrlCmd | KeyCode.KeyM), weight: KeybindingWeight.EditorContrib } </del> <ins> precondition: EditorContextKeys.hoverFocused </ins> }); }

Discussion:
Testing The keybinding does not work on windows due to quick open. Also the keybinding collides with the command. I wonder if this could be solved without registering keybindings. One idea could be that when the hover is focused the user could just use and on the keyboard to increase and decrease the hover (possibly also arrow keys could work). Make sure to mention in the hover of the increase and decrease actions what the keybinding or keyboard key is.
That's a very good point. I think we would still want ideally the + and - to be linked to keybindings so they can be configured by the user. I'll remove the keybindings, so they can simply be set by the users if they so wish. The current code already renders the keybindings if they are set: Perhaps they are not fetched correctly in your case because of the keybinding collisions. !
Change:
this._onDidAcceptInput.fire(); const editorValue = this.getInput(); <del> this._chatAccessibilityService.acceptRequest(); </del> <ins> const requestId = this._chatAccessibilityService.acceptRequest(); </ins> const input = !opts ? editorValue : 'query' in opts ? opts.query : `${opts.prefix} ${editorValue}`;

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.
Change:
} private getMaxExpandedBodySize(): number { <ins> let minVisibleOpenEditors = this.configurationService.getValue<number>('explorer.openEditors.minVisible'); // If it's not a number setting it to 0 will result in dynamic resizing. if (typeof minVisibleOpenEditors !== 'number') { minVisibleOpenEditors = OpenEditorsView.DEFAULT_MIN_VISIBLE_OPEN_EDITORS; } </ins> const containerModel = this.viewDescriptorService.getViewContainerModel(this.viewDescriptorService.getViewContainerByViewId(this.id)!)!; if (containerModel.visibleViewDescriptors.length <= 1) { return Number.POSITIVE_INFINITY; } <del> return this.elementCount * OpenEditorsDelegate.ITEM_HEIGHT; </del> <ins> return (Math.max(this.elementCount, minVisibleOpenEditors)) * OpenEditorsDelegate.ITEM_HEIGHT; </ins> } private getMinExpandedBodySize(): number {

Discussion:
Issue Type: <bBug</bthe "OPEN EDITORS" section of the explorer open, and above the explorer's main section. -click one of the files in the main section, but delay the second click slightly. The file opens on the first click and gets to the OPEN EDITORS section. This moves everything below it down by the height of one line, so if that happens before the second click, you're clicking on a different file. Often, instead of opening the second file, it opens a text entry field near the bottom of the explorer's main section (not necessarily anywhere near the mouse cursor) as if I'm trying to create a new file at the top-level of my project. VS Code version: Code 1.57.1 (, 2021-06-17T13:26:56.255Z) OS version: Linux x64 5.12.14-arch1-1 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ vscode-styled-jsx2.0.0 vscode-modelines2.0.5 vscode-eslint2.1.23 vscode-html-css1.10.2 tslint1.0.47 auto-close-tag0.5.11 dotenv1.0.1 vscode-language-pack-en-GB1.54.1 python2021.6. vscode-pylance2021.7.2 jupyter2021.6. remote-containers0.183.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 remote-wsl0.56.5 vscode-remote-extensionpack0.21.0 cpptools1.5.1 lit-plugin1.2.1 sourcekit-lsp0.0.1 vim1.21.5 viml1.0.1 html-css-class-completion1.20.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This is a known limitation. However I could not find the duplicate so let's keep this one open.
I did subsequently find the issue that this duplicates, but it had been closed by a bot: .
The limit is at currently but in theory can be changed to a higher value:
Change:
constructor() { super({ id: 'editor.createFoldingRangeFromSelection', <del> label: nls.localize('createManualFoldRange.label', "Create Manual Folding Range from Selection"), alias: 'Create Manual Folding Range from Selection', </del> <ins> label: nls.localize('createManualFoldRange.label', "Create Folding Range from Selection"), alias: 'Create Folding Range from Selection', </ins> precondition: CONTEXT_FOLDING_ENABLED, kbOpts: { kbExpr: EditorContextKeys.editorTextFocus,

Discussion:
Testing You could remove "manual" from the action name, i.e. "Create folding range from selection" or maybe even "Fold selection".
Fold selection could be confusing if there are already folding ranges at the selection position. it's more than just folding (it creates a range) sounds too similar than the commands that just collapse (, ,...)
I'm not opposed to remove the 'Manual'
Change:
export const MOVE_EDITOR_INTO_NEW_WINDOW_COMMAND_ID = 'workbench.action.moveEditorToNewWindow'; export const COPY_EDITOR_INTO_NEW_WINDOW_COMMAND_ID = 'workbench.action.copyEditorToNewWindow'; <ins> export const MOVE_EDITOR_GROUP_INTO_NEW_WINDOW_COMMAND_ID = 'workbench.action.moveEditorGroupToNewWindow'; export const COPY_EDITOR_GROUP_INTO_NEW_WINDOW_COMMAND_ID = 'workbench.action.copyEditorGroupToNewWindow'; export const NEW_EMPTY_EDITOR_WINDOW_COMMAND_ID = 'workbench.action.newEmptyEditorWindow'; </ins> export const API_OPEN_EDITOR_COMMAND_ID = '_workbench.open'; export const API_OPEN_DIFF_EDITOR_COMMAND_ID = '_workbench.diff'; export const API_OPEN_WITH_EDITOR_COMMAND_ID = '_workbench.openWith';

Discussion:
Testing I am wondering if there should be a context menu action for this? !
Yeah, I actually decided to do a bit more: Editor Tab Container Context Menu: <img width="447" alt="image" src=""Empty Editor Group Context Menu: <img width="458" alt="image" src="" to open an empty aux window
Change:
} } getStatus(limit = 5000): Promise<{ status: IFileStatus[]; didHitLimit: boolean; }> { return new Promise<{ status: IFileStatus[]; didHitLimit: boolean; }>((c, e) => { const parser = new GitStatusParser();

Discussion:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!
Change:
constructor( editor: ICodeEditor, <ins> minimumSize: dom.Dimension, </ins> @IContextKeyService contextKeyService: IContextKeyService ) { <del> super(editor); </del> <ins> super(editor, minimumSize); </ins> this._hoverVisibleKey = EditorContextKeys.hoverVisible.bindTo(contextKeyService); this._hoverFocusedKey = EditorContextKeys.hoverFocused.bindTo(contextKeyService);

Discussion:
Testing !
I think the minimum size should me much bigger: !
Currently the minimum height is the line height plus 8 pixels, and the minimum width is 4/3 times the minimum height. Do you think the minimum width should be larger or perhaps dynamic and depending on the current width?
I think a min width of 150px could work
To verify: a hover and make sure that the hover can be sized down to a minimum width of 150px provided that the hover width is naturally above 150px a small hover with a natural width smaller than 150px, verify it can not be sized down to a smaller width than its initial width
Change:
/** * A string including ANSI escape sequences that will be written to the terminal emulator <del> * _before_ the terminal process has launched, a trailing n is added at the end of the string. * This allows for example the terminal instance to display a styled message as the first line * of the terminal. Use x1b over 033 or e for the escape control character. </del> <ins> * _before_ the terminal process has launched, when a string is specified, a trailing n is * added at the end. This allows for example the terminal instance to display a styled message * as the first line of the terminal. Use x1b over 033 or e for the escape control character. </ins> */ <del> initialText?: string; </del> <ins> initialText?: string | { text: string; trailingNewLine: boolean }; </ins> /** * Custom PTY/pseudoterminal process to use.

Discussion:
!
works in OSS !
also works for me in insider's
works for that exact task for me !
It's because of this: Here's the I was using:
This works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !
Change:
*--------------------------------------------------------------------------------------------*/ import { localize } from 'vs/nls'; <del> import { ExtensionInstallLocation, IExtensionManagementServer, IExtensionManagementServerService, IProfileAwareExtensionManagementService } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; </del> <ins> import { ExtensionInstallLocation, IExtensionManagementServer, IExtensionManagementServerService } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; </ins> import { IRemoteAgentService } from 'vs/workbench/services/remote/common/remoteAgentService'; import { Schemas } from 'vs/base/common/network'; <del> import { Event } from 'vs/base/common/event'; </del> import { IChannel } from 'vs/base/parts/ipc/common/ipc'; import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { ILabelService } from 'vs/platform/label/common/label';

Discussion:
<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: stable from sources Regression in current september release Steps to Reproduce: server, open workbench in browser settings sync some extension remote server logs cc