jiebi/CodeConvo huggingface dataset:
Change:
} private openExternalWithString(session: vscode.DebugSession, captureString: string) { const args: ServerReadyAction = session.configuration.serverReadyAction; let uri;

Discussion:
I'm trying to use the configuration from website, but I'm facing a problem with the third option. I would like to use like these: and . But I can't find a way to achieve this with : Is it something possible? Thanks a lot
That launch config works for me and does what's expected. Note that the "serverReadyAction" in the latter config does not call the " debug client-side" launch config. For that you would want to use the and put in " debug client-side" for the .
Yes, I agree with you, both configurations are working as expected. I wasn't very clear in my first message, I will try to explain better. On my NextJs project, I can have the following configurations: The first one start the project and enables debugging on server side, the second one open chrome and enables debugging on client side. If I put on the second configuration, it will work just fine: What I want, is using the third configurations only to : start the project, enable debugging on server/client side and open chrome with my . Is it possible to achieve something like this ? I can't find any option in that case to make my working.
serverReadyAction doesn't accept additional configuration properties to pass to the launch config. The reason for this is mostly that intellisense doesn't work in that action (under the hood it's provided by a different extension) so writing configuration in the nested object is hard. The way to do this is define the separate launch config and reference it. Copying your original configuration set:
Your configuration plus two small additions almost give the result I'm looking for! I still have too issues with this: If I kill the (by clicking on the icon), is not automatically killed dispite the option. When I start , is automatically started, but I can see both elements here: !. Is it possible to hide the last one (wich should be automatically killed when is stopped)? I clearly saw that you explained to me why it was not possible to do this (use on a ) in a single configuration, but is there a "hacky" way the achieve my main goal? Or is something planned in the futur? Or maybe there is a way to fix my remaining concerns with the current configuration?

No, this is not possible and is not something we'd do, since you would not be able to control the debug session in that case. That's a bug, will put in a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
errorTelemetry.dispose(); service.dispose(); <ins> sinon.restore(); </ins> })); test('Unexpected Error Telemetry removes PII but preserves Code file path', sinonTestFn(function (this: any) {

Discussion:
In short, if you use without calling you are leaking memory. See for the details. I'm seeing a lot of memory used in unit tests and it appears to be coming from sinon. This may be contributing to our unit test OOM issue on Windows 32 bit. Let's see if fixing this lets us run the unit tests again. To fix I have made disposable, and there were some places where tests failed or the refactor seemed larger:
The biggest gain would be from fixing the leak from as it is used many places.
I don't know if you own , but I am looking into a fix for it since it will have the biggest impact.
I've reopened this.
Thanks. I should be careful to not do and instead as that will prevent GitHub from auto closing it
With , I have made disposable and handled disposing it in most tests. There are several places where the way to handle this isn't clear or made test fail when I just naively disposed it. I have them in the issue above.
the instance in is already restored at , but the others should be fixed in Let me know if I miss any! Edit: I ended up making changes in both files.
For those tests where I am just using , should I have to still call or I should wait for your change to dispose the ?
You can wait for my change to dispose the .
FYI Windows ia32 started turning green again
and the only files left are yours. The is now disposable and should be disposed in these test files to properly restore and prevent a memory leak.
Thank you for the fast response everyone!
need help
Change:
{ link: 'foo', prefix: undefined, suffix: undefined, hasRow: false, hasCol: false }, { link: 'foo:339', prefix: undefined, suffix: ':339', hasRow: true, hasCol: false }, { link: 'foo:339:12', prefix: undefined, suffix: ':339:12', hasRow: true, hasCol: true }, <ins> { link: 'foo:339.12', prefix: undefined, suffix: ':339.12', hasRow: true, hasCol: true }, </ins> { link: 'foo 339', prefix: undefined, suffix: ' 339', hasRow: true, hasCol: false }, { link: 'foo 339:12', prefix: undefined, suffix: ' 339:12', hasRow: true, hasCol: true }, <ins> { link: 'foo 339.12', prefix: undefined, suffix: ' 339.12', hasRow: true, hasCol: true }, </ins> // Double quotes { link: '"foo",339', prefix: '"', suffix: '",339', hasRow: true, hasCol: false }, { link: '"foo",339:12', prefix: '"', suffix: '",339:12', hasRow: true, hasCol: true }, <ins> { link: '"foo",339.12', prefix: '"', suffix: '",339.12', hasRow: true, hasCol: true }, </ins> { link: '"foo", line 339', prefix: '"', suffix: '", line 339', hasRow: true, hasCol: false }, { link: '"foo", line 339, col 12', prefix: '"', suffix: '", line 339, col 12', hasRow: true, hasCol: true }, { link: '"foo", line 339, column 12', prefix: '"', suffix: '", line 339, column 12', hasRow: true, hasCol: true },

Discussion:
The : This doesn't currently work in VSCode. It does support a very wide range of formats and I don't recall ever seeing this format before (even from GNU tools) so I suspect nobody else uses it. Nonetheless it's easy to add support in VSCode. See
Doesn't seem to work, see <img width="825" alt="Screenshot 2023-08-29 at 14 41 05" src=""
The PR intentionally left that out: But it should be easy to add so will leave this open.
Change:
} const editorLineHeight = this._editor.getOption(EditorOption.lineHeight); const widgetHeight: number = this._lineNumbers.length * editorLineHeight + this._lastLineRelativePosition; <ins> this._rootDomNode.style.display = widgetHeight > 0 ? 'block' : 'none'; </ins> this._rootDomNode.style.height = widgetHeight.toString() + 'px'; const minimapSide = this._editor.getOption(EditorOption.minimap).side; if (minimapSide === 'left') {

Discussion:
Type: <bBug</bstick scroll to high contrast down in a file Bug There is no contrast between the stick scroll content and the normal editor content: ! Related VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-26T05:22:17.192Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
For verification: sticky scroll, switch to high-contrast and scroll down the file. should see a border on the bottom of the sticky scroll widget
I see it in dark theme but not light high contrast: !
Change:
registerEditorCommand(new SuggestCommand({ id: 'selectLastSuggestion', <del> precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.MultipleSuggestions), </del> <ins> precondition: ContextKeyExpr.and(SuggestContext.Visible, ContextKeyExpr.or(SuggestContext.MultipleSuggestions, SuggestContext.HasFocusedSuggestion.negate())), </ins> handler: c => c.selectLastSuggestion() })); registerEditorCommand(new SuggestCommand({ id: 'selectPrevSuggestion', <del> precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.MultipleSuggestions), </del> <ins> precondition: ContextKeyExpr.and(SuggestContext.Visible, ContextKeyExpr.or(SuggestContext.MultipleSuggestions, SuggestContext.HasFocusedSuggestion.negate())), </ins> handler: c => c.selectPrevSuggestion(), kbOpts: { weight: weight,

Discussion:
Type: <bBug</bOpen new document. Set . Type now start typing the editor will show suggestion (with only one in the list). Now pressing should select the available suggestion, but it can not be done. On the other hand if you type and then start typing the list will contain two items and selection works as expected - when you press the first item is selected and you can navigate the list with and VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
with the setting set to "never" is it expected that there is one selected by default? I didn't have to arrow down for this to happen !
Change:
readonly model = this.viewModel.map(m => /** @description model */ m?.model); protected readonly htmlElements = h('div.code-view', [ <del> h('div.title@header', [ </del> <ins> h('div.header@header', [ </ins> h('span.title@title'), h('span.description@description'), h('span.detail@detail'),

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !
Change:
this._electricChars = null; this.shouldAutoCloseBefore = { <del> quote: this._getShouldAutoClose(languageId, this.autoClosingQuotes), bracket: this._getShouldAutoClose(languageId, this.autoClosingBrackets) </del> <ins> quote: this._getShouldAutoClose(languageId, this.autoClosingQuotes, true), bracket: this._getShouldAutoClose(languageId, this.autoClosingBrackets, false) </ins> }; this.autoClosingPairs = this.languageConfigurationService.getLanguageConfiguration(languageId).getAutoClosingPairs();

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Can the addition of the closing curly brace be whenever the opening curly brace is automatically initiated in an f-string in python? currently this doesn't happen and i need to add the closing curly brace when done - this feature would be useful --
Please add more details, e.g. a code sample.
apologies - I actually had but for some reason the main body of text wasn't posted. please see a below a code example - thank you. This is the current way in which the curly brace is interpreted in an f string. As you can see when you enter the opening curly brace, the closing one is not automatically inserted and i have to enter it manually.. it would be incredibly useful if the closing brace was automatically (in the same way automatic closing of brackets and braces is achieved outside of the print statement in the editor) to achieve something like: having said this - this is a trivial feature request, but i find myself using this a lot
is defined as bracket pair, also for when in strings, so I believe it should work.
Thank you for the reply! Hmm this doesn't for me unfortunately, is there a setting that needs to be activated?
does autoclose in strings in general e.g. https://user- But not at the position before the closing e.g. https://user- Relevant code:
ha! thank you, this is really interesting - i can confirm that it works when entering before the closing - funny because i have only ever really required the the braces before the closing comma (because this then creates a whitespace between the statement and the answer which is intended for visual purposes will this be treated as a bug to fix? again this obviously isn't critical. happy to close. thanks
This cannot be fixed at the moment. The behaviour is controlled by the autoCloseBefore property in the language configuration file, but quotes are not appropriate for that property. JavaScript and TypeScript make an exception for backticks.
Change:
} else if (event.equals(KeyCode.RightArrow) || event.equals(KeyCode.Tab)) { this.focusNext(); } else if (event.equals(KeyCode.Escape) && this.isFocused && !this.isOpen) { <del> this.focusState = this.currentMenubarVisibility === 'toggle' ? MenubarState.HIDDEN : MenubarState.VISIBLE; </del> <ins> this.setUnfocusedState(); </ins> } else { eventHandled = false; }

Discussion:
Issue Type: <bBug</bWhen using the custom title bar and the toggled menu bar setting, the menu bar becomes stuck in the toggled on state. This primarily occurs when the active VS Code window becomes inactive while the menu bar is toggled on. When using multiple VS Code windows this makes it difficult to identify the correct window because the title bar's filename information is hidden. Steps to reproduce: the setting to , and setting to VS Code is the active window, hold down the key to show the menu bar the key while still holding the key to switch to another application. The active VS Code window becomes inactive and the menu bar is visible. Alternatively you can click outside of the active VS Code window while the menu bar is being displayed. VS Code version: Code 1.25.0 (, 2018-07-05T13:11:58.697Z) OS version: Windows_NT x64 10.0. <details<summaryExtensions (4)</summaryExtensionVersion ------ classic-asp0.0.4 vscode-icon-theme1.6.2 csharp1.15.2 PowerShell1.8.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.538 --- <!-- score: 0.491 --- <!-- score: 0.483 --- <!-- score: 0.482 --- <!-- score: 0.48 --<!-- potentialduplicatescomment --
Change:
height: 16px; } <ins> .monaco-workbench .part.sidebar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus, .monaco-workbench .part.sidebar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus { outline: 0 !important; /* activity bar indicates focus custom */ } .monaco-workbench .part.sidebar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label, .monaco-workbench .part.sidebar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label { border-radius: 0px; outline-offset: 2px; } .monaco-workbench .part.sidebar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label::before, .monaco-workbench .part.sidebar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label::before { position: absolute; left: 6px; /* place icon in center */ } </ins> .monaco-workbench .part.sidebar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked:not(:focus) .active-item-indicator:before, .monaco-workbench .part.sidebar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked.clicked:focus .active-item-indicator:before, .monaco-workbench .part.sidebar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked:not(:focus) .active-item-indicator:before,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.1 OS Version: macOS Sonoma(14.0) Steps to Reproduce: the color theme to high contrast theme will see the activity bar icon size and the border is weird !
pinging
Change:
this._sizeObserver.observe(dimension); })); <del> this._register(autorun((reader) => { /** @description Update widget dimension */ </del> <ins> const placeholderMessage = derived(reader => { </ins> const items = this._viewItems.read(reader); <del> this._elements.placeholder.classList.toggle('visible', items.length === 0); </del> <ins> if (items.length > 0) { return undefined; } const vm = this._viewModel.read(reader); return (!vm || vm.isLoading.read(reader)) ? localize('loading', 'Loading...') : localize('noChangedFiles', 'No Changed Files'); }); this._register(autorun((reader) => { const message = placeholderMessage.read(reader); this._elements.placeholder.innerText = message ?? ''; this._elements.placeholder.classList.toggle('visible', !!message); </ins> })); this._scrollableElements.content.style.position = 'relative';

Discussion:
open a multifile diff reload window while the diff editor stores and loads it says that there are no changes yet <img width="1178" alt="Screenshot 2024-06-21 at 09 16 43" src=""
Thanks for filing! Briefly looked into it, but fixing it is a little bit more complex than I thought. The model creation is what takes a while, and during that time the multi file diff editor just has no model. It would be better if the model creation is immediate, but it has some property, that the editor could then show.
Change:
this.updateLabels(menuBarMenu.titleElement, menuBarMenu.buttonElement, menuBarMenu.label); }); <del> this.updateOverflowAction(); </del> <ins> if (!this.overflowLayoutScheduled) { this.overflowLayoutScheduled = DOM.scheduleAtNextAnimationFrame(() => { this.updateOverflowAction(); this.overflowLayoutScheduled = void 0; }); } </ins> this.setUnfocusedState(); }

Discussion:
There is signed of the explorer getting slower during the last days: <img width="387" alt="screenshot 2018-12-06 at 14 06 20" src="https://user-"
adding cos is busy and you probably know the explorer well... Not sure that promise adoption caused this - file operation have always been properly async...
One of my suspisions might be the changing of startup phases in addition to promise adoption. has the overall startup speed changed, or only the explorer got slower? Also can you see the change when you measure locally? If yes we can do some bisection to find the cause. Did all viewlets get slower? Also there has been no code changes in the explorer this milestone thus my reason for suspecting other things.
My =change touched a ton of promises, not just file service, so it could well be related. I saw a bit of places in the file service that were not truly async, e.g. where was used.
Blaming this on the promise-adoption is easy, but we all know by now they run on and it would require loads of them to get 50ms extra...
I am not worried about the time a takes, but rather the fact that our execution order of things on startup is changing by adopting because we have many places where code is now running on that previously was running sync in places where we wrapped a complete value into a promise under certain conditions.
Maybe I understood wrong but that shouldn't happen unless those things also run via , right? Ticks (multiple) are processes at the end of an event loop cycle and only then comes the next event.
yeah that might be true (hopefully is). I am running test now on Linux with a commit from 26th of November vs. today to see if there is something.
Bisecting on Linux I see a slowdown from to for the restoring of viewlet through:
Nice find, I will verify on Windows. I verifeid that on OS X there is no slowdown, which is correlated to the fact that menus are the cause (since we do not use custom menus on OS X)
To proove the theory: disabling custom title bar on Linux restores the good time for me on that commit.
does the overall startup time get 50ms slower too, or is it just reflected in the explorer?

I'd say that's because 99% of startups open the explorer when opening the editor. These are great findings.
it looks like the workbench ready time is actually worse when the native menu is enabled for me, so overall I see no total slowdown. Also the editor restore seems to be roughly the same with custom and native title.
this seems to be caused by  being called during startup which seems to access DOM properties that cause a forced layout. If I comment out that method, I see the normal times reported. I suggest you check if this method could be called after a delay, e.g. via
Change:
import { localize } from 'vs/nls'; import { hostname, homedir } from 'os'; import { URI } from 'vs/base/common/uri'; <ins> import { CharCode } from 'vs/base/common/charCode'; </ins> type RemoteTunnelEnablementClassification = { owner: 'aeschli';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: VS Code Version: 1.74 OS Version: Windows 11 Pro Developers Build ! Error Code image attached Passes an invalid argument upon launch using the latest vs code Version 1.74
I can take this... The workaround is to use the setting to pick a name that does not start with a
to something starting with a dash remote tunnel access it comes up successfully
Change:
return TimeBasedVariableResolver.monthNames[new Date().getMonth()]; } else if (name === 'CURRENT_MONTH_NAME_SHORT') { return TimeBasedVariableResolver.monthNamesShort[new Date().getMonth()]; <ins> } else if (name === 'CURRENT_SECONDS_UNIX') { return String(Math.floor(Date.now() / 1000)); </ins> } return undefined;

Discussion:
I would like a new Snippet Variable for time to be to the variables listed here. Something like or Number of seconds since the unix epoch.
Nice. I would like to work on that
I've got a commit here that works on my local build. Does this look good to you? I just get the milliseconds since epoch using and divide by 1,000. However I use to round to the nearest integer so there aren't a bunch of decimals. If that's what you wanted, I'll go ahead and open the PR, but just wanted to share it for discussion before I go ahead and do that.
I thought was the normal way of doing that? PS: just occurred, would be better since could go upwards
Ah you are right, completely forgot about . Definitely a cleaner look, and I've also changed round to floor. The new commit is and local build works perfect. Was there anything else that crossed your mind?
tested this is a Snippet in Insiders edition today. Works as expected. Thank you very much.