jiebi/CodeConvo huggingface dataset:
Change:
"variable.language" ], "settings": { <del> "foreground": "#AB6526" </del> <ins> "foreground": "#9C5D27" </ins> } }, {

Discussion:
Environment Details: VSCode Version : 1.24.0 OS Version : Win10 Additional Details: MAS Violated : MAS 1.4.3 Tools Used : Color Contrast Analyzer Repro Steps: 1)Navigate to Settings--Select color theme --Select Quiet light. 2)Check color contrast ratio for the Explorer content on the screen. Actual: Color contrast ratio is less than 4.5:1 for the black colored content when focused. Similar issue is observed in following themes: Abyss Kimbie dark Monokai Dimmed High contrast Install additional color theme Expected: Color contrast ratio should be more than 4.5:1 for the content on a screen. Recommendations: Refer below link which is repository of bug fixes code snippets:   User Impact: The low vision/visually impaired users will not be able to view the content properly. MAS Reference: MAS 1.4.3 - {-765f-489c-b18f-}  Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.981 --- <!-- score: 0.924 --- <!-- score: 0.875 --- <!-- score: 0.869 --- <!-- score: 0.867 --<!-- potentialduplicates_comment --
Per our agreement, we will not be fixing color contrast issues with third party themes. cc
just a note that we are the authors of this theme (actually I am the original author) Does this mean that we only fix for the Light+ and Dark+?
we're supposed to fix any issues for themes that we own and ship with out of the box (except for third party themes we don't own). I didn't know we own QuietLight so I'll re-open.
Checked and verified in below version i.e 1.27.0-Insiders. The issue still exist in Quite Light theme. Similar issue is observed in following themes: 1)Solarized light:All the text in the page fail in color contrast ratio i.e 4.5:1 2)Light visual studio: Black coloured text fail in color contrast ratio i.e 4.5:1
please see for the unused variable color issues
Change:
} } })); <ins> this.initContextKeys(contextKeyService); } private initContextKeys(contextKeyService: IContextKeyService): void { queueMicrotask(() => { contextKeyService.bufferChangeEvents(() => { this.debugType = CONTEXT_DEBUG_TYPE.bindTo(contextKeyService); this.debugState = CONTEXT_DEBUG_STATE.bindTo(contextKeyService); this.inDebugMode = CONTEXT_IN_DEBUG_MODE.bindTo(contextKeyService); this.debugUx = CONTEXT_DEBUG_UX.bindTo(contextKeyService); this.debugUx.set(this.debugStorage.loadDebugUxState()); this.breakpointsExist = CONTEXT_BREAKPOINTS_EXIST.bindTo(contextKeyService); // Need to set disassemblyViewFocus here to make it in the same context as the debug event handlers this.disassemblyViewFocus = CONTEXT_DISASSEMBLY_VIEW_FOCUS.bindTo(contextKeyService); }); const setBreakpointsExistContext = () => this.breakpointsExist.set(!!(this.model.getBreakpoints().length || this.model.getDataBreakpoints().length || this.model.getFunctionBreakpoints().length)); setBreakpointsExistContext(); this.disposables.add(this.model.onDidChangeBreakpoints(() => setBreakpointsExistContext())); }); </ins> } getModel(): IDebugModel {

Discussion:
The debug viewlet breaks and does not load when the window is loaded with that viewlet visible Reload window with debug viewlet visible DebugActionViewItem is created, requires DebugService DebugService is instantiated, sets some context keys The context keys cause the debug view to refresh, the toolbar in the view header wants to refresh its actions, this leads to creating DebugActionViewItem again DebugService is not done being instantiated, so we try to instantiate a second one Repeat The context keys maybe should not be owned by the service, but could be a separate contribution
I think this was technically caused by , causing the DebugService to be created a little later than it was before. FYI My PR makes it happen a little more often, since otherwise the editor contribs might cause DebugService to be instantiated early, but I can repro this without my PR. I think the context keys can live in a separate workbench contrib that depends on DebugService, and listens to its events to update the keys.
The stack
That or don't set them from within the ctor but after your object/services is initialized (and cached)
Change:
assert.ok(completions.some(x => x.insertText === 'file%20with%20space.md'), 'Has encoded path completion'); }); <ins> test('Should support completions on angle bracket path with spaces', async () => { const completions = await getCompletionsAtCursor(workspacePath('new.md'), joinLines( `[](</sub with space/${CURSOR}` )); assert.ok(completions.some(x => x.insertText === 'file.md'), 'Has path completion'); }); test('Should not escape spaces in path names that use angle brackets', async () => { { const completions = await getCompletionsAtCursor(workspacePath('new.md'), joinLines( `[](<./sub/${CURSOR}` )); assert.ok(completions.some(x => x.insertText === 'file with space.md'), 'Has encoded path completion'); } { const completions = await getCompletionsAtCursor(workspacePath('new.md'), joinLines( `[](<./sub/${CURSOR}>` )); assert.ok(completions.some(x => x.insertText === 'file with space.md'), 'Has encoded path completion'); } }); </ins> test('Should complete paths for path with encoded spaces', async () => { const completions = await getCompletionsAtCursor(workspacePath('new.md'), joinLines( `[](./sub%20with%20space/${CURSOR})`

Discussion:
Issue Type: <bBug</bTrigger path suggestions inside a markdown link that uses angle brackets: Bug No suggestions show up VS Code version: Code - Insiders 1.69.0-insider (Universal) (, 2022-06-17T05:16:27.373Z) OS version: Darwin x64 21.5.0 Restricted Mode: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Relevant code:
So I'm new to this project. Do I ask if I can be assigned this bug? Or is it whoever submits an solution first makes the pull request?
You can ask, I am currently working on this now - but you can try as well.
Alright thanks. So in general I can just work on a problem that catches my attention and ask/answer questions when appropriate?
Yes pretty much, you can work on any problem or issue that you would like.
What specifically is the bug here? Is the desired behavior where when you type a list of path links should appear?
Yes, it should work the same way it does if you remove the from the link One extra note: spaces should not be encoded inside links so for extra points make accepting a file suggestion with spaces in the name inserts a real space instead of
How do I recompile typescript files so vscode reflects the changes I made? Is it or ?
Is this the behavior you were looking for?
Change:
widget.tabIndex = 0; if (!this.attachedContextDisposables.isDisposed) { <del> this.attachedContextDisposables.add(this.hoverService.setupManagedHover(hoverDelegate, widget, hoverElement)); </del> <ins> this.attachedContextDisposables.add(this.hoverService.setupManagedHover(hoverDelegate, widget, hoverElement, { trapFocus: false })); </ins> // No delay for keyboard this.attachedContextDisposables.add(dom.addDisposableListener(widget, 'keydown', (event) => {

Discussion:
Testing a large image () it into chat window freezes for a few seconds Seems we spent in the !
cc. is there a compromise on what we hash for the ID? ie, maybe half of the bytes instead of the full thing, or something of the sort, since ATM we are just hashing the entire received
It looks like the function is trying to hash the Uint8Array naively as an object (hashing each key and value for each element in the array) which is going to be extraordinarily slow. should complete in millisecond(s) :)
should our detect if it's web and if crypto is available and use that if so? I can see this happening again.
Yea, I think having it check for typed arrays and arraybuffers would make sense. Unfortunately is sync and webcrypto is async, however, so it would not be a drop-in replacement.
perhaps we could have a signature like to catch at compile time and redirect that use to the async version in ?
Change:
@IContextKeyService private _contextKeyService: IContextKeyService, @ILabelService labelService: ILabelService, @ILifecycleService lifecycleService: ILifecycleService, <ins> @ILogService private readonly _logService: ILogService, </ins> @IDialogService private _dialogService: IDialogService, @IInstantiationService private _instantiationService: IInstantiationService, @IRemoteAgentService private _remoteAgentService: IRemoteAgentService,

Discussion:
From Run the command Enter: In the eventual modal dialog, press Expecting a window reload, but there is an error instead. You can also call the command I debugged it down to veto from terminal. Exception thrown while serializing the terminal: The veto hander should handle all exceptions and return false, unless it really wants to veto the window close.
Closing for verification as it looks like this has been merged into release/1.62
Remote connection is going in a restarting loop. Restart remote connection is the only thing that we are getting now. Not possible to work at all with vscode.
Change:
super(); this._activeTasks = Object.create(null); <del> this._instances = Object.create(null); </del> this._busyTasks = Object.create(null); this._terminals = Object.create(null); this._idleTaskTerminals = new LinkedMap<string, string>();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 and older and (with slightly different behavior) insiders as of 5/4/2023 OS Version: MacOS 13.3.1 (a) Steps to Reproduce: Use these commands to produce and launch a suitable project: First bug: in either 1.78.0 or the nightly, use to launch , then hit Cmd-Shift-B to launch . You end up with two copies of running, when it should have an implicit of 1. Hit Cmd-Shift-B again, and it will tell you you've hit the instance limit. The problem here is that dependent tasks don't count towards the instance limit. Second bug: Now add to , and repeat the above. There is no change in the nightly (as you might expect), but surprisingly 1.78.0 now reports that it can't start a second copy. But thats just a bug; if you change it to and repeat, 1.78.0, still tells you it can't launch a second copy. This bug was fixed by , so I'm just including it for completeness. Third bug: Add to . Now hit Cmd-Shift-B to launch , then use to launch . will (correctly) re-use the already running task, rather than launching a new one. Now kill all the terminals (to make the next step less confusing). Hit Cmd-Shift-B to launch sleeper, wait 5 seconds, and hit Cmd-Shift-B again, wait another 5 seconds for the first task to finish, and then run .

Now, although the second task is still running, starts a new one. The issue here is that when looking for an existing dependent task, uses the task's , which only matches the first instance of a task with greater than 1 (and here, that task has already finished).
Change:
resolved "https://registry.yarnpkg.com/napi-build-utils/-/napi-build-utils-1.0.2.tgz#b1fddc0b2c46e380a0b7a76f984dd47c41a13806" integrity sha512-ONmRUqK7zj7DWX0D9ADe03wbwOBZxNAfF20PlGfCWQcD3+/MakShIHrMqx9YwPTfxDdF1zLeL+RGZiR9kGMLdg== <del> native-is-elevated@0.6.0: version "0.6.0" resolved "https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.6.0.tgz#9fd9c9c53bfd87d6e6af15a5d6bcb8e592b7ec79" integrity sha512-HW1wDo4WYZC7W68kaS0cs7FtDTrcFoAY1APc4SlU4Un/FuL7pjilXFEteBCA58EWClKk0912JLIoekOJ/NohnQ== </del> <ins> native-is-elevated@0.7.0: version "0.7.0" resolved "https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.7.0.tgz#77499639e232edad1886403969e2bf236294e7af" integrity sha512-tp8hUqK7vexBiyIWKMvmRxdG6kqUtO+3eay9iB0i16NYgvCqE5wMe1Y0guHilpkmRgvVXEWNW4et1+qqcwpLBA== </ins> native-keymap@^3.3.2: version "3.3.3"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 (user setup) OS Version: Windows 10 22H2 To fix the issue please update the native-is-elevated package. It was fixed two months ago.
Could you maybe verify using our insiders? You can give our preview releases a try from:
It seems working properly now. Thanks!
Change:
} else { this.hover = this._register(this.hoverService.setupManagedHover(this.hoverDelegate, this.container, hoverContents)); } <del> if (entry.command !== ShowTooltipCommand /* prevents flicker on click */) { this.focusListener.value = addDisposableListener(this.labelContainer, EventType.FOCUS, e => { EventHelper.stop(e); this.hover?.show(false); }); this.focusOutListener.value = addDisposableListener(this.labelContainer, EventType.FOCUS_OUT, e => { EventHelper.stop(e); this.hover?.hide(); }); } </del> } // Update: Command

Discussion:
a rust project Hold mousedown on the rust analyzer status bar contribution. The hover appears and disappears when the mouse is released.
it seems like you to prevent flickering from happening in the status bar. Maybe this is not required anymore? It seems like this is causing the flickering to happen currently. cc as he the if condition
I those listeners so that the tooltip is shown and hidden when keyboard focus moves into / out of status bar items. I just tested and those listeners are no longer needed because of work you've done to support showing the tooltip for items around the workbench when they're focused with the keyboard
Change:
} } <del> await runCell(accessor, context); </del> <ins> await runCell(editorGroupsService, context); </ins> } });

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem
Change:
await Promise.all(byExtension.map(async e => { const latest = e.sort((a, b) => semver.rcompare(a.manifest.version, b.manifest.version))[0]; if (!installed.has(latest.identifier.id.toLowerCase())) { <del> this._onDidRemoveExtension.fire(latest); </del> <ins> await this.beforeRemovingExtension(latest); </ins> } })); const toRemove: ILocalExtension[] = extensions.filter(e => uninstalled[new ExtensionIdentifierWithVersion(e.identifier, e.manifest.version).key()]);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.46.0 OS Version: Windows 10/macOS Catalina 10.15.4 VS Code 1.46 no longer executes the Attached test extension (rename file extension to .vsix) which creates a file on uninstall in the user's home directory. Using VS Code 1.45.1 the file is created on both Windows and macOS. Using VS Code 1.46 no file is created. Steps to Reproduce: attached extension extension VS Code VS Code again file is created <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: This is an extension management problem
Change:
test('filters simple globs', () => { t.setText('hello, !world'); assert.deepStrictEqual(t.globList, [{ text: 'hello', include: true }, { text: 'world', include: false }]); <del> assert.deepStrictEqual(t.onlyTags, new Set()); </del> <ins> assert.deepStrictEqual(t.includeTags, new Set()); assert.deepStrictEqual(t.excludeTags, new Set()); </ins> assertFilteringFor(termFiltersOff); }); test('filters to patterns', () => { t.setText('@doc'); assert.deepStrictEqual(t.globList, []); <del> assert.deepStrictEqual(t.onlyTags, new Set()); </del> <ins> assert.deepStrictEqual(t.includeTags, new Set()); assert.deepStrictEqual(t.excludeTags, new Set()); </ins> assertFilteringFor({ ...termFiltersOff, [TestFilterTerm.CurrentDoc]: true,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Splitting this out from In the Test UI you can filter by text or exclude text using and filter by a . It would be nice if we could also negate tags in the filter like to exclude a specific tag. <!-- Describe the feature you'd like. --
Starting point, this is where tag filtering happens:
Change:
} ] } <del> ], synchronous, { kind: SelectionStateType.Handle, primary: previouslyPrimary, selections: beforeSelections }, () => undefined, undefined); </del> <ins> ], synchronous, { kind: SelectionStateType.Handle, primary: previouslyPrimary, selections: beforeSelections }, () => endSelections, undefined); </ins> return this._viewCells[index]; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.
Change:
// Multi Monitor (non-fullscreen): be less strict because metrics can be crazy const bounds = { x: state.x, y: state.y, width: state.width, height: state.height }; const display = screen.getDisplayMatching(bounds); <ins> const displayWorkingArea = this.getWorkingArea(display); </ins> if ( <del> display &&												// we have a display matching the desired bounds bounds.x < display.bounds.x + display.bounds.width &&	// prevent window from falling out of the screen to the right bounds.y < display.bounds.y + display.bounds.height &&	// prevent window from falling out of the screen to the bottom bounds.x + bounds.width > display.bounds.x &&			// prevent window from falling out of the screen to the left bounds.y + bounds.height > display.bounds.y				// prevent window from falling out of the scree nto the top </del> <ins> display &&														// we have a display matching the desired bounds displayWorkingArea &&											// we have valid working area bounds bounds.x < displayWorkingArea.x + displayWorkingArea.width &&	// prevent window from falling out of the screen to the right bounds.y < displayWorkingArea.y + displayWorkingArea.height &&	// prevent window from falling out of the screen to the bottom bounds.x + bounds.width > displayWorkingArea.x &&				// prevent window from falling out of the screen to the left bounds.y + bounds.height > displayWorkingArea.y					// prevent window from falling out of the scree nto the top </ins> ) { if (state.mode === WindowMode.Maximized) { const defaults = defaultWindowState(WindowMode.Maximized); // when maximized, make sure we have good values when the user restores the window

Discussion:
A fresh install of Code - stable, insiders and code-oss - will spawn a floating window relative to the top of the screen, not to the work area. Code stores the window position, so moving the window makes it spawn in the new location next time. ! Issue Type: <bBug</bSteps to reproduce: Taskbar at top of screen Display resolution: 1366x768 Install fresh copy of Code. Run Code (with or without extensions disabled) VS Code version: Code 1.23.1+ OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
via