jiebi/CodeConvo huggingface dataset:
Change:
import { CodeActionController } from 'vs/editor/contrib/codeAction/browser/codeActionController'; import { IResolvedTextEditorModel, ITextModelContentProvider, ITextModelService } from 'vs/editor/common/services/resolverService'; import { Schemas } from 'vs/base/common/network'; <ins> import { IDragAndDropData } from 'vs/base/browser/dnd'; import { fillEditorsDragData } from 'vs/workbench/browser/dnd'; import { ElementsDragAndDropData } from 'vs/base/browser/ui/list/listView'; import { CodeDataTransfers } from 'vs/platform/dnd/browser/dnd'; </ins> type TreeElement = ISCMRepository | ISCMInput | ISCMActionButton | ISCMResourceGroup | IResourceNode<ISCMResource, ISCMResourceGroup> | ISCMResource;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I frequently use the drag-and-drop feature from the Explorer view to open files into specific panes. It would be really nice if this functionality was supported in the Source Control panel as well. I imagine it working like: Drag from filename into pane opens diff in that pane Drag from file icon into pane opens original file in that pane with reversed behavior if .
Not sure if this belongs here, or would be better a new feature request: If I have already two panels open next to each other, opening the git diff in one panel is pretty small and no fun to read, e.g.: ! For me it would be nice, if the first two panels would be used for the diff In IntelliJ the diffs opens in a detached popup, which I can move around and resize individually. I also like this feature a lot
please open a new issue -- although note, that the behavior you describe is unlikely to change, as that is how tab management works in VS Code.
One additional use case: I just enabled drag and drop into the SCM input box. It would be nice if we could drag and drop files from the SCM panel into the box to insert this file path (this already works with files from the explorer)
Change:
"errorForeground": "#f1897f", "badge.background": "#705697AA", "progressBar.background": "#705697", <del> "walkThrough.embeddedEditorBackground": "#00000014" </del> <ins> "walkThrough.embeddedEditorBackground": "#00000014", "editorIndentGuide.background": "#aaaaaa60", "editorIndentGuide.activeBackground": "#777777b0" </ins> } }

Discussion:
Issue Type: <bBug</bthe embedded Quiet Light theme. and insertion point into an indented section. that the active indent guide is indistinguishable from other indent guides. ! Based on this should be easy to fix. Will you accept a PR? VS Code version: Code - Insiders 1.38.0-insider (, 2019-08-21T13:26:22.457Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
if you'd like to submit a PR feel free to do so
Verification steps: Verify that the Quiet Light theme indent guides (default and active) look like this: !
Change:
__vsc_update_prompt <ins> __vsc_restore_exit_code() { return $1 } </ins> __vsc_prompt_cmd_original() { __vsc_status="$?" # Evaluate the original PROMPT_COMMAND similarly to how bash would normally

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: V1.70.0 OS Version: Ubuntu 20.04 Steps to Reproduce: to latest V1.70.0 version of VSCode starship prompt for the bash shell. I have my starship prompt configured to update if the previous command execution failed for unknown reasons. After the latest update, every command execution seems to fail only in VSCode's terminal. Below is the expected behaviour, in a bash terminal: The screenshot of the same with colors: ! Now in the VSCode's terminal (running bash): (It shows the error condition even in a brand new instance of the terminal) A screenshot of the same with colors: ! This behaviour of always erroring out even for a successful command execution started today after VSCode auto updated to V1.70.0 Below is the information I got from menu: Version: 1.70.0 Commit: Date: 2022-08-04T04:38:48.541Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Linux x64 5.15.0-43-generic snap
Did you notice
, thanks for the prompt response! Yes, by disabling shell-integration, starship prompt started behaving as expected. Shall I close this issue or consider this a bug with shell-integration ?

I don't see why there was a need to enable Shell Integration by default, spent the last 2 hours trying to figure out what was wrong
This probably has nothing to do with starship (I have the same issue without starship). This is just a specific case of and should probably be closed as a duplicate
Change:
export type ParsedExpression = (path: string, basename?: string, siblingsFn?: () => string[] | TPromise<string[]>) => string | TPromise<string> /* the matching pattern */; export interface IGlobOptions { <ins> /** * Simplify patterns for use as exclusion filters during tree traversal to skip entire subtrees. Cannot be used outside of a tree traversal. */ </ins> trimForExclusions?: boolean; }

Discussion:
Steps to Reproduce: a workspace with one folder that contains another folder "qunit" with some files 1 Clear Editor History some files from the qunit folder to add them to quick open history settings and define a files.exclude like this: =the qunit folder should now hide from the explorer =bring up quick open and notice the file from qunit still showing up This is unexpected, I have code that listens to changes to the pattern and remove entries that no longer match. When I debug this I end up in this location right before I enter here: The pattern does not match, but I verified that the setting is the one as defined. It gets created right here: Is there something wrong with parsing maybe? I have lost the ability to understand or even debug our glob implementation. Assigning to you in the hope that you have better ways of doing so. I think what we need is a way to log exactly how the matching happens within glob. Today this method is so heavily optimized and complex that I always loose myself in it.
Should have documented this: trimForExclusions is an optimization that only works for exclusions in a tree traversal. It simplifies the pattern to only match the folder 'qunit', but not the files in it. In a tree traversal that is enough and a much faster check to do. Opened a PR to clarify.
thanks
Change:
commandManager.register(new commands.ReloadPlugins(previewManager, engine)); return commandManager; }

Discussion:
Enable triggering go to definition on a markdown reference link to jump to the link definition Go to def should jump to the definition at the end of the file
Related
Created a PR fixing this
Works well, I was a bit confused to see this tooltip with 'Execute command' though, is there a way to make that more context-specific? !
Change:
} private filterEvent({ profileLocation, applicationScoped }: { profileLocation?: URI; applicationScoped?: boolean }): boolean { <ins> profileLocation = profileLocation ?? this.userDataProfilesService.defaultProfile.extensionsResource; </ins> return applicationScoped || this.uriIdentityService.extUri.isEqual(this.userDataProfileService.currentProfile.extensionsResource, profileLocation); }

Discussion:
Hit Install, the button changes to "Installing" for 1sec, then goes back to "Install". Repeatedly fails. Reload showed the extension installed. <img width="1289" alt="image" src="https://user-"Version: 1.72.0-insider Commit: User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Edg/107.0.1387.2 Embedder: <!-- generated by web issue reporter --
Change:
newIndex++; line = buffer.getLine(newIndex); } <ins> width += line!.length; </ins> return { width, newIndex }; }

Discussion:
Testing have fixed with on in a narrow terminal type select , existing text is re-rendered correctly select again, :bug: no effect https://user-
I'm having trouble reproducing this
could be related to the (now fixed) problem of losing terminal focus, since that's a precondition for the action to run
Change:
} private onContextMenu(e: ITreeContextMenuEvent<RenderableMatch | null>): void { <del> if (!e.element) { return; } </del> if (!this.contextMenu) { this.contextMenu = this._register(this.menuService.createMenu(MenuId.SearchContext, this.contextKeyService)); }

Discussion:
Search view, context menu on empty area -no context menu In this case we should still offer the option to move the search view to the panel. Since it is a "global" action, and it only appears when there are results in the search view
, can i take a look at this or are you working on this ? :)
You can take a look
, I understood how "Toggle Search View Position" works both in and functionality. So when we right click on the search result then only the option comes up , so it is bound to search result. So what is the approach we should take to fix this ? We need to move this whole functionality to somewhere else rite ? ( Like some button next "Refresh","Clear All Search Results".... ? ) Please suggest me the way forward :)
do you know how to add a context menu to an empty tree?
gets fired for every place in the tree, including empty items. Here's an example how I use this in the explorer
I think we should use that for this command, rather than
, I tried doing this and here is what I found. There is already trigger in If we remove this check then it will work on empty tree also ( ) In case of no results , we are showing custom message and here the tree is no longer in the view , so right clicking there would not work. ( ) Ideally if we remove that mentioned in case 2 , then what suggested is already there but as the tree itself is not valid in case of "No Search Results" because of showing some custom message described above. Please let me know the way forward to fix this :)
Good analysis. Can we change it to keep the tree in the DOM when that no results message is shown? Not sure how the tree is sized in css but it would have to be vertically flexible. Also, when I am right clicking on an empty tree, I should not see context menu items that are not valid without a row, like copy, dismiss, etc.
Change:
if (updateProps) { tunnelProperties.name = updateProps.name ?? tunnelProperties.name; tunnelProperties.local = (('local' in updateProps) ? updateProps.local : (('localPort' in updateProps) ? updateProps.localPort : undefined)) ?? tunnelProperties.local; <del> tunnelProperties.privacy = updateProps.privacy ?? tunnelProperties.privacy; </del> <ins> tunnelProperties.privacy = tunnelProperties.privacy; </ins> } } return tunnelProperties;

Discussion:
I had to clear settings sync for an unrelated issue and start fresh, but enabling the "UI State" option causes the error below to be continually thrown. If I disable the "UI State" option in settings sync, it starts working again. Type: <bBug</bsettings sync, check all boxes except "UI State" settings sync log, see that it succeeds settings sync config to include UI State VS Code version: Code 1.85.1 (Universal) (, 2023-12-13T09:48:06.308Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ erb0.0.1 vscode-eslint2.4.2 prettier-vscode10.1.0 codespaces1.16.6 copilot1.148.0 copilot-chat0.11.1 vscode-graphql-syntax1.2.3 endwise1.5.1 remote-containers0.327.0 proto0.0.4 rewrap1.16.3 gitblame10.6.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you please share the UI state using following steps F1 Export Profile... Select only UI state Export the profile and share it
The exported file is 2.3 MB, and it has some things inside that might be considered sensitive, I'm not sure. Is there a way I can share it privately?
You can share it to me by email - 2.3 MB is way under the limits right?
Just emailed the file, thank you!
I just checked the size limits on the server and it is indeed 2MB caps
Thanks for sharing. I figured out that port forwarding state is taking majority of the size. Hence assigning to
Discussed with and there are 3 easy things I can do to quickly reduce the size: Don't save empty values Add an expiry time to values so they don't live forever Save fewer fields per port in . For example, only tunnels should be stored + restored, so should be removed. So should , , , and .
the limit per resource version is 2mb atm
Are there steps to verify this?

To verify: to a Codespace and forward a port the remote connection the steps in to collect a profile the file created in step 3. Check that the port that you just forwarded in step 1 is listed there under a key and that it doesn't have a value.
For the step, does this mean to stop the codespace?
This is verified. The new port forwarded doesn't have , but I did notice some old ports of mine from old codespaces still having . Not sure if that was expected to be covered.
The behavior you see is expected. I didn't add any cleanup of the old state.
Change:
content: renderStringAsPlaintext(message), inlineClassName: `test-message-inline-content test-message-inline-content-s${severity} ${this.contentIdClass}` }; <ins> options.showIfCollapsed = true; </ins> const rulerColor = severity === TestMessageType.Error ? overviewRulerError

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently, the inlay hints will clean and shows again as scheduler's strategy. It's might not friendly if you are editing some line who has many hints. I have an idea: Clean all hints where the cursor’s line when we are editing the code and append new hints by the scheduler. I think It's might improve the experience about inlay hints.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.494 --<!-- potentialduplicatescomment --
/gifPlease
!
I think inlay hints should disappear immediately if the surrounding text is deleted. Afaik, currently, when text gets deleted, decorations inside of that text get collapsed but are not deleted.
Yes, I agree that hints should disappear immediately when their "anchor" position is removed. Maybe it's not so easy to know what remove actually means in this case. Arguably this is an editor bug as I was expecting this to work?
I wouldn't call this a bug - decorations are never removed automatically. Alex suggests (I asked him before his vacation): I also suggest to extend the inlay hints API so that a hint refers to a range. The hint itself then can either be after or before the range. The range allows to better predict what should happen with the hint if the text changes. With injected text, we now have two cursor stops around inlay hints - both refer to the same model position. Maybe the move behavior of inlay text should depend on the view position where the text change was caused from? I suggest to think about how we can better predict synchronously how a text change affects inlay hints.
This is how we started, mostly to optionally support overlay hints, and everyone was confused about ranges for inlay hints. Using a range with before/after screams "position" and I don't want to leak an implementation detail into the API. We would also still have the case of empty ranges... I'd rather create "fake ranges" from positions so that I can use the notion of collapsed ranges.
I have pushed a change () to use the range of touching words of inlay positions (when possible).

In that case will be and my expectation was that decorations hide/disappear when removing all their text.. is that a bug in decorations land or am I using this wrong? Should I listen to decoration changes and "manually" remove them?
I think so, decorations are not removed automatically.
But what does mean then?
Ah, maybe I forgot to consider that flag for injected text, I'll look into it tomorrow.
Change:
if (token.map && token.type !== 'inline') { token.attrSet('data-line', String(token.map[0])); token.attrJoin('class', 'code-line'); <ins> token.attrJoin('dir', 'auto'); </ins> } } });

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi! I want to solve this issue as a good-first-issue. Please help me if you can :) In Github there was a problem that README and issues don't work for RTL languages. () Then on November 16, 2021, Github announced that we fixed this problem: () But vscode does not support it yet. For example we see ) in github like this: ! But in vscode, we see the markdown preview like this: ! Feature or improvement request: Providing support for correctly previewing RTL languages texts.
Hi! Can you help me to solve this issue? (as a good-first-issue) I opened a pull request here:
/verified
Change:
enabled: false }, autoClosingBrackets: configurationService.getValue('editor.autoClosingBrackets'), <del> quickSuggestions: false </del> <ins> quickSuggestions: false, accessibilitySupport: configurationService.getValue<'auto' | 'off' | 'on'>('editor.accessibilitySupport'), </ins> }; } }

Discussion:
Ref: I would expect the comment editor to behave just like a regular editor window, but in my case it is not. I don't hear screen reader feedback as I move through words and lines with the keyboard. Also, when I press a routing cursor key on my braille display, it does not move the cursor to the desired character. Tested with NVDA and JAWS. Invoke the action to leave a comment in the current line Write some text Use ctrl+left and ctrl+right to move through words Use up and down arrow keys to move through lines If you have a braille display with routing keys, press a routing cursor key to move to a specific character in the text
Change:
weight: KeybindingWeight.WorkbenchContrib, // markdown keybinding, focus on list: higher weight to override list.focusDown }, { <del> when: NOTEBOOK_EDITOR_FOCUSED, primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageUp, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageUp }, weight: KeybindingWeight.WorkbenchContrib </del> <ins> when: ContextKeyExpr.and(NOTEBOOK_CELL_EDITOR_FOCUSED, CONTEXT_ACCESSIBILITY_MODE_ENABLED), primary: KeyMod.CtrlCmd | KeyCode.PageUp, mac: { primary: KeyMod.WinCtrl | KeyCode.PageUp, }, weight: KeybindingWeight.WorkbenchContrib + 1 </ins> }, ], });

Discussion:
mentioned that the current keybinding for this controls speech rate for jaws users on windows should be used for code chat next code block and go to next /previous cell
related ctrl+pagedown/pageup are currently bound to next/previous editor
shouldn't those have context keys though that will mean this can still work for notebook cells?
next/previous editor don't have context keys for those keybindings, so it will be a behavior change. We could add the bindings just for SR mode if you don't think those users would be annoyed by it.
what do you think? I also don't want to surprise users with this behavior change.
I don’t think this is a surprise change. If we weigh the tradeoff, going with the new keybindings avoiding SR keys might be more beneficial in the long run.
Change:
this.logService.warn(logMsg); break; case Severity.Info: <del> this.logService.info(logMsg); </del> <ins> this.logService.trace(logMsg); </ins> break; } }

Discussion:
Version: 1.77.1 Commit: Date: 2023-04-04T23:20:37.202Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Linux x64 5.15.0-69-generic Sandboxed: No install code from start from terminal Lot of log output is shown. See blow shows that the log level is Info
Change:
} } <ins> const globalStylesheets = new Map<HTMLStyleElement /* main stylesheet */, Set<HTMLStyleElement /* aux window clones that track the main stylesheet */>>(); export function isGlobalStylesheet(node: Node): boolean { return globalStylesheets.has(node as HTMLStyleElement); } </ins> export function createStyleSheet(container: HTMLElement = document.head, beforeAppend?: (style: HTMLStyleElement) => void, disposableStore?: DisposableStore): HTMLStyleElement { const style = document.createElement('style'); style.type = 'text/css';

Discussion:
Type: <bBug</bThe fix for seems to have stopped working in the latest Insiders build. VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-06T05:34:22.485Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Range:
Really a bad bug: none of the global styles would get copied properly, a lot of other CSS related things must have been broken. Fix tomorrow!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
} } } <del> const activationEventsNode = findNodeAtLocation(tree, ['activationEvents']); if (activationEventsNode?.type === 'array' && activationEventsNode.children) { for (const activationEventNode of activationEventsNode.children) { const activationEvent = getNodeValue(activationEventNode); </del> <ins> } const activationEventsNode = findNodeAtLocation(tree, ['activationEvents']); if (activationEventsNode?.type === 'array' && activationEventsNode.children) { for (const activationEventNode of activationEventsNode.children) { const activationEvent = getNodeValue(activationEventNode); if (info.implicitActivationEvents?.has(activationEvent) && redundantImplicitActivationEventPrefixes.some((prefix) => activationEvent.startsWith(prefix))) { const start = document.positionAt(activationEventNode.offset); const end = document.positionAt(activationEventNode.offset + activationEventNode.length); diagnostics.push(new Diagnostic(new Range(start, end), redundantImplicitActivationEvent, DiagnosticSeverity.Warning)); } else { </ins> for (const implicitActivationEventPrefix of reservedImplicitActivationEventPrefixes) { if (activationEvent.startsWith(implicitActivationEventPrefix)) { const start = document.positionAt(activationEventNode.offset);

Discussion:
Following the addition of implicit activation events in the November release, we'd like to provide lint warnings via the extension-editing extension when an extension declares activation events which are already implied by its declared contributions.
cc as a heads up--we previously discussed this in and at the time agreed that a simple warning for the reserved/internal event was sufficient. We've since updated the docs and extension samples to mention that you don't need to explicitly list many events anymore. In discussion with Kai, the next step to round out this work and make extension authors aware of the new behavior is to provide lint warnings for all redundant events in the extension-editing extension. Let me know if you have any questions or concerns.