jiebi/CodeConvo huggingface dataset:
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'windows-foreground-love' { export function allowSetForegroundWindow(pid?: number): boolean; } </ins>  No newline at end of file

Discussion:
This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Pushed a workaround.
Reopening, using the () workaround causes issues as it will undock windows it seems.
This happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.
As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Just tried the suggested workaround and it did not work. Using Windows 10 Home
I've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?
Seems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build
Must have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.
I started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build
Update: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.
This is happening to me also since the previous 2 releases. Changing the value of did not help
Change:
getHeight(element: T): number; getTemplateId(element: T): string; hasDynamicHeight?(element: T): boolean; <ins> setDynamicHeight?(element: T, height: number): void; </ins> } export interface IListRenderer<T, TTemplateData> {

Discussion:
See the GIF directly. ! As shown above, the settings UI always scrolls automatically, so I cannot find the modification because it went away. Marking or deselecting any item may cause this issue. VS Code version: Code 1.31.0 (, 2019-02-05T22:35:56.624Z) OS version: Windows_NT x64 10.0.
Annoyed me so much. Note that it happens with dropdowns and selecting an item, and occasionally by inputting textbox and clicking to defocus it.
Having this exact problem as well. I just installed VS code and am having this problem while giving it a trial run. Sigh....
Maybe related to
This isn't what I thought it was, I have to assign to you I think the ListView renders the setting items with their default heights, then rerenders and saves the offset of the anchor element. Then it fixes the heights of the elements and maintains the offset of the anchor element. But since it measured the anchor element when the elements had default heights, the list will be shifted if the real heights were different from the default heights. Maybe an anchor element should be measured before rendering the items with default heights or something like that. I made the default heights more accurate which helps.
Why is the list re-rendered when a check box is clicked?
When the config service says something changed, we rerender everything. It seems unnecessary in this case but it's hard to tell that the change event came "from" this instance of the settings editor and also, some values can be normalized when they get back to us, and since it should be safe to rerender, I don't put a lot of effort into reducing unneeded renders. Another way to repro this, open two settings editors in two groups, change a setting in Group 1, and see the editor in Group 2 scroll. If this just can't really be fixed there are things I can do like updating the value of a rendered setting row without actually calling setChildren. But that only works for some settings, adds more complexity, etc.
It can definitely be fixed. I was just wondering why the rerender was needed. ;)
cc
Change:
description = nls.localize('languageDescriptionConfigured', "({0})", this.modeService.getModeIdForLanguageName(lang.toLowerCase())); } <del> // construct a fake resource to be able to show nice icons if any let fakeResource: URI | undefined; const extensions = this.modeService.getExtensions(lang); if (extensions && extensions.length) { fakeResource = URI.file(extensions[0]); } else { const filenames = this.modeService.getFilenames(lang); if (filenames && filenames.length) { fakeResource = URI.file(filenames[0]); } } </del> return { label: lang, <del> iconClasses: getIconClasses(this.modelService, this.modeService, fakeResource), </del> <ins> iconClasses: getIconClasses(this.modelService, this.modeService, this.getResource(lang)), </ins> description }; });

Discussion:
if you just want to 'Select Language Mode', languages has icons. but if you want to 'Configure File Association', languages has no icons
True, up for grab if someone wants to do it.
I'm going to work on it.
Change:
|| e.hasChanged(EditorOption.fontInfo) || e.hasChanged(EditorOption.readOnly) || e.hasChanged(EditorOption.wordSegmenterLocales) <del> || e.hasChanged(EditorOption.cursorStyle) </del> ); }

Discussion:
Using copilot completions in the latest VS Code insiders, I see the cursor being pushed to after the suggested text. This makes it very difficult to work with the text while passive completions are suggested. <img width="1126" alt="image" src=""
FYI I didn't think of this.
is it possible to differentiate between an inline completion and inlay hint in the editor? maybe we could have different behavior in different cases?
Change:
group: 'navigation', order: 10, command: openToSideCommand, <del> when: ContextKeyExpr.or(ResourceContextKey.IsFileSystemResource, ResourceContextKey.Scheme.isEqualTo(Schemas.untitled)) </del> <ins> when: isFileOrUntitledResourceContextKey </ins> }); MenuRegistry.appendMenuItem(MenuId.OpenEditorsContext, {

Discussion:
VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select "Select for Compare". click on any other item and select "Compare with Selected". ! Does this issue occur when all extensions are disabled?: Yes
//cc not sure we have a context key to use here already
Code pointer We would need to use that context key for all the compare context menu actions in the Open Editors view
isn't this just a matter of using for this command? We seem to be using this also to limit commands such as "Copy"?
you are correct, I checked and this is indeed the context key we needed here.
Will have to revert this due to
PR:
/verified
Change:
* in arbitrary order and the initial debug configuration is piped through the chain. * Returning the value 'undefined' prevents the debug session from starting. * Returning the value 'null' prevents the debug session from starting and opens the underlying debug configuration instead. <del> * </del> <ins> * </ins> * @param folder The workspace folder from which the configuration originates from or undefined for a folderless setup. * @param debugConfiguration The [debug configuration](#DebugConfiguration) to resolve. * @param token A cancellation token.

Discussion:
Problem The time you search for the branch and not find any, there are no other options to proceed. <img width="682" alt="screen shot 2018-09-15 at 11 06 09" src="https://user-"I as a developer would need to delete the search and then click on "create a new branch". Solution Keep "create a new branch" option always. <img width="656" alt="screen shot 2018-09-15 at 11 22 56" src="https://user-"
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.617 --- <!-- score: 0.587 --- <!-- score: 0.552 --- <!-- score: 0.547 --- <!-- score: 0.529 --<!-- potentialduplicatescomment --
Is this supported from an extension? Eg: keep an option always visible.
Dang, just noticed that you already submitted a PR to address this. Closed my PR, feel free to grab the integration test I if you want
since my PR is merged already, feel free to create a PR with tests :)
I a PR to add tests and also fix a small bug (when explicitly settings items on a the field was not properly propagated). Additional thoughts I had (should open another issue for discussion?): In my opinion, items that should always be shown shouldn't display search highlights. The highlights are possibly redundant and IMO it would look more elegant without I feel like after accepting the option, the input text should be preserved. Would a PR to address this be accepted? Also, possibly should this behavior be exposed for user control? (i.e. similarly to a field, a field.)
:+1: Nah, sounds like a very good default value.
Change:
})); this._register(vscode.workspace.onDidChangeTextDocument(e => { <del> if (isMarkdownFile(e.document)) { </del> <ins> if (this.isRelevantMarkdownDocument(e.document)) { </ins> this._onDidChangeMarkdownDocumentEmitter.fire(e.document); } })); } <ins> private isRelevantMarkdownDocument(doc: vscode.TextDocument) { return isMarkdownFile(doc) && doc.uri.scheme !== 'vscode-bulkeditpreview'; } </ins> public async getMarkdownDocument(resource: vscode.Uri): Promise<SkinnyTextDocument | undefined> { <del> const matchingDocument = vscode.workspace.textDocuments.find((doc) => doc.uri.toString() === resource.toString()); </del> <ins> const matchingDocument = vscode.workspace.textDocuments.find((doc) => this.isRelevantMarkdownDocument(doc) && doc.uri.toString() === resource.toString()); </ins> if (matchingDocument) { return matchingDocument; }

Discussion:
Testing in VS Code the following content Rename , shift + enter to show preview. Accept the preview Rename the same symbol again, shift + enter to show preview. Preview constantly spins. Clicking on the changes opens an empty side by side editor !
Change:
discardHunk, toggleDiff: !hunkData.isInsertion() ? toggleDiff : undefined, remove, <ins> move </ins> }; this._hunkDisplayData.set(hunkData, data);

Discussion:
open inline chat have it make multiple hunks (hint: ask it to use a util that needs to be imported) there is no gesture to visit all hunks except for accepting/discarding them... This can also help with accessibility when using the move
To verify let inline chat make multiple changes, e.g ask it to import a util or let is change the label of two actions make sure the inline chat status says "N changes" (n=2) select and to navigate between the changes
Change:
}, { id: CreateEmptyProfileAction.ID, label: CreateEmptyProfileAction.TITLE.value, <del> }], { canPickMany: false, title: localize('create settings profile', "{0}: Create...", PROFILES_CATEGORY) }); </del> <ins> }], { hideInput: true, canPickMany: false, title: localize('create settings profile', "{0}: Create...", PROFILES_CATEGORY) }); </ins> if (pick) { return commandService.executeCommand(pick.id); }

Discussion:
Noticed that we're providing a filter input here—seems like it isn't needed for this type of quick pick. <img width="636" alt="CleanShot 2022-08-09 at 11 13 31 src="https://user-"
Change:
constructor() { super({ id: 'merge.toggleActiveConflictInput2', <del> title: localize('merge.toggleActiveConflictInput2', "Merge Editor: Toggle Active Conflict In Input 2"), </del> <ins> category: localize('mergeEditor', "Merge Editor"), title: localize('merge.toggleActiveConflictInput2', "Toggle Active Conflict In Input 2"), </ins> f1: true, }); }

Discussion:
While working on I noticed that some of the UI elements (and maybe other things?) are not registered as disposable, and thus may leak when the merge editor is freed from an editor group that closes. For example the and all input views seem to not dispose.
Hm, I think also the merge model, I suggest to do a pass and register as appropiate.
Change:
"emmetPreferencesCssMsProperties": "Comma separated CSS properties that get the 'ms' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'ms' prefix.", "emmetPreferencesCssFuzzySearchMinScore": "The minimum score (from 0 to 1) that fuzzy-matched abbreviation should achieve. Lower values may produce many false-positive matches, higher values may reduce possible matches.", "emmetOptimizeStylesheetParsing": "When set to `false`, the whole file is parsed to determine if current position is valid for expanding Emmet abbreviations. When set to `true`, only the content around the current position in css/scss/less files is parsed.", <del> "emmetPreferencesOutputReverseAttributes": "If `true`, reverses attribute merging directions when resolving snippets." </del> <ins> "emmetPreferencesOutputReverseAttributes": "If `true`, reverses attribute merging directions when resolving snippets.", "emmetPreferencesCssColorShort": "If `true`, color values like #f will be expanded to #fff instead of #ffffff." </ins> }

Discussion:
"emmet.preferences": { "": true } Why not working?
Does the new modular emmet support this feature?
yes, it should be passed as option:
Looks like it is enabled by default. Since VS Code doesnt change that particular property, we will need to debug why this doesnt work.
I'm having the same problem, using the latest VS Code version: 1.35.0. After adding the setting as mentioned above, Emmet in VS Code still expands to instead of . Hope this could get some love, because small color values are just way more sexy!
I updated the Emmet dependency, and now is enabled by default in the latest Insiders. I still have to add the setting to VS Code if one wants to disable it for whatever reason, so I'll leave this issue open.
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.39: version "0.12.0-beta.39" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.39.tgz#f5fafd2c4d1ec046ff6b57edf850234948cf630a" integrity sha512-116gk9KYqbMyCcjedDYhqg3RKl0CI19I1l/+u8JdJb6bucv835Hj60W2it5AAsmvw726FEXwhMoOaY3gs+n1/g== </del> <ins> xterm-addon-webgl@0.12.0-beta.41: version "0.12.0-beta.41" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.41.tgz#17dbca975b6e9b34526ebc57f4de59ee295da1b6" integrity sha512-wvQxC5diMYEJEMaILfz+4CWB2GgtzjzNQRNDnK7R7Y9wDI+P4idDlQKgyH0nA93sl9R4zgqlBVha//wuq4vfZg== </ins> xterm@4.19.0-beta.60: version "4.19.0-beta.60"

Discussion:
Notice the words in the following screenshot: ! Does not reproduce in , from 3 days ago. I'm on Windows, using as my font, default size, no zoom.
Caused by
Change:
} // If the command center is visible then the quickinput should go over the title bar and the banner if (this.titleService.isCommandCenterVisible) { <del> quickPickTop = 0; </del> <ins> quickPickTop = 6; </ins> } return { top, quickPickTop }; }

Discussion:
To better display the connection between the title bar input and the quick input, I suggest we place it on top of the input vs anchored to the top of the window. E.g. <img width="648" alt="CleanShot 2022-12-13 at 12 56 09 src="https://user-"
Change:
flex: 1; } <ins> .monaco-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus, .monaco-workbench .part.auxiliarybar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus { outline: 0 !important; /* activity bar indicates focus custom */ } .monaco-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label, .monaco-workbench .part.auxiliarybar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label { border-radius: 0px; outline-offset: 2px; } .monaco-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label::before, .monaco-workbench .part.auxiliarybar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label::before { position: absolute; left: 6px; /* place icon in center */ } </ins> .monaco-workbench .part.auxiliarybar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked:not(:focus) .active-item-indicator:before, .monaco-workbench .part.auxiliarybar > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked.clicked:focus .active-item-indicator:before, .monaco-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked:not(:focus) .active-item-indicator:before,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.1 OS Version: macOS Sonoma(14.0) Steps to Reproduce: the color theme to high contrast theme will see the activity bar icon size and the border is weird !
pinging
Change:
public disposeTemplate(templateId: string, templateData: any): void { if (templateId === templateEntryItem) { this.entryItemRenderer.disposeTemplate(null, templateId, templateData); <ins> } else { const data = templateData as IQuickOpenEntryGroupTemplateData; data.actionBar.dispose(); data.actionBar = null; data.container = null; data.description.dispose(); data.description = null; data.detail.dispose(); data.detail = null; data.group = null; data.icon = null; data.label.dispose(); data.label = null; data.prefix = null; </ins> } <del> const data = templateData as IQuickOpenEntryGroupTemplateData; data.actionBar.dispose(); data.actionBar = null; data.container = null; data.description.dispose(); data.description = null; data.detail.dispose(); data.detail = null; data.group = null; data.icon = null; data.label.dispose(); data.label = null; data.prefix = null; </del> } }

Discussion:
Issue Id: <-e6e6-b9ac-f191-</b<br /<br /Versions <br /- <br /- <br /- <br /- <br /- <br /Stack <br /TypeError: Cannot read property 'dispose' of undefined<br /<br /<br /<br /at Array.forEach (native)<br /<br /at Array.forEach (native)<br /<br /<br /<br /<br /
Just reproduced locally after closing the "?" help quick open: Cannot read property 'dispose' of undefined: TypeError: Cannot read property 'dispose' of undefined at Renderer.disposeTemplate () at Renderer.disposeTemplate () at at Array.forEach (native) at at Array.forEach (native) at RowCache.garbageCollect () at TreeView.onSetInput () at TreeView.onModelEvents () at Array.<anonymous()WorkbenchShell.onUnexpectedError @ //Users/bpasero/Development/monaco/out/vs/workbench/electron- [uncaught exception]: TypeError: Cannot read property 'firstChild' of nullonError @ TypeError: Cannot read property 'firstChild' of null at EntryItemRenderer.LegacyRenderer.renderElement () at Renderer.renderElement () at Renderer.renderElement () at () at ViewItem.insertInDOM () at TreeView.insertItemInDOM () at () at at () at ()onError @ Uncaught TypeError: Cannot read property 'firstChild' of null //Users/bpasero/Development/monaco/out/vs/workbench/electron- Cannot read property 'dispose' of undefined: TypeError: Cannot read property 'dispose' of undefined at Renderer.disposeTemplate () at Renderer.disposeTemplate () at at Array.forEach (native) at at Array.forEach (native) at RowCache.garbageCollect () at TreeView.onSetInput () at TreeView.onModelEvents () at Array.<anonymous()
This is bad as it can bring quick open into a broken state. To reproduce open quick open, type ? and repeat: !
Closing as per commit

Issue Id: <-bdb0-aec8-eb4a-</b<br /<br /Versions <br /- <br /- <br /Stack <br /TypeError: Cannot read property 'dispose' of undefined<br /<br /<br /<br /at Array.forEach (native)<br /<br /at Array.forEach (native)<br /<br /<br /<br /<br /
Woopsie.
Sorry for the confusion, this one is still open, the other one is fixed.