jiebi/CodeConvo huggingface dataset:
Change:
} async encrypt(value: string): Promise<string> { <ins> this.logService.trace('[EncryptionMainService] Encrypting value.'); </ins> try { <del> this.logService.trace('[EncryptionMainService] Encrypting value.'); </del> const result = JSON.stringify(safeStorage.encryptString(value)); this.logService.trace('[EncryptionMainService] Encrypted value.'); return result;

Discussion:
Hi thank you for your reply. After start VSCode Insider with the parameters , when I try to authorize the Github Copilot the message returned at terminal is: ExtensionUrlTrustService#isExtensionUrlTrusted There are no configured trusted keys and the authentication process never ends. Originally posted by in
Can you follow these steps so that we can get more information on what's going on? Open the Command Palette Run the command To the right of , click the double check mark button. (enables trace logging as the default) Start the login, wait for the issue to happen... Open the Output pane (cmd+shift+u) drop in this issue he contents of the following: Output channel Output channel Output channel Open the Command Palette Run the command To the right of , click the double check mark button. (to set the default back to info)
same here
can you follow the steps?
You know what, this is likely fixed in this ^^ PR. Let's see what tomorrow's Insider build has
Cool! Thanks! Waiting for the next version.
I will try with the updated version and return here.
Confirm the latest version released today fixed everything!
Problem solved!!! Thank you guys.
Change:
<ins> <?xml version='1.0' standalone='no' ?> <svg xmlns='http://www.w3.org/2000/svg' version='1.1' width='10px' height='10px'> <style> circle { animation: ball 0.6s linear infinite; } circle:nth-child(2) { animation-delay: 0.075s; } circle:nth-child(3) { animation-delay: 0.15s; } circle:nth-child(4) { animation-delay: 0.225s; } circle:nth-child(5) { animation-delay: 0.3s; } circle:nth-child(6) { animation-delay: 0.375s; } circle:nth-child(7) { animation-delay: 0.45s; } circle:nth-child(8) { animation-delay: 0.525s; } @keyframes ball { from { opacity: 1; } to { opacity: 0.3; } } </style> <g style="fill:grey;"> <circle cx='5' cy='1' r='1' style='opacity:0.3;' /> <circle cx='7.8284' cy='2.1716' r='1' style='opacity:0.3;' /> <circle cx='9' cy='5' r='1' style='opacity:0.3;' /> <circle cx='7.8284' cy='7.8284' r='1' style='opacity:0.3;' /> <circle cx='5' cy='9' r='1' style='opacity:0.3;' /> <circle cx='2.1716' cy='7.8284' r='1' style='opacity:0.3;' /> <circle cx='1' cy='5' r='1' style='opacity:0.3;' /> <circle cx='2.1716' cy='2.1716' r='1' style='opacity:0.3;' /> </g> </svg> </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: CPUs | Apple M1 (8 x 24) -- | -- GPU Status | 2dcanvas: enabled canvasooprasterization: disabledoff directrenderingdisplaycompositor: disabledoffok gpucompositing: enabled metal: disabledoff multiplerasterthreads: enabledon opengl: enabledon rasterization: enabled rawdraw: disabledoffok skiarenderer: enabledon videodecode: enabled videoencode: enabled webgl: enabled webgl2: enabled Load (avg) | 2, 2, 2 Memory (System) | 16.00GB (0.08GB free) Screen Reader | no VM | 0% Steps to Reproduce: in extensions the scroll gutter https://user-
Using the list widget underneath, hence assigning to
This happens because the list is paged and is loading each element from the network. Want to provide a better loading animation here?
Can we do something simple and use the loading icon animation? https://user-
What do you think
This is much better! Thank you for looking into this
Change:
break; } default: { <del> commandArg = ''; title = localize('scm button commit title', "{0} Commit", icon ?? '$(check)'); </del> if (alwaysCommitToNewBranch) { tooltip = this.state.isCommitInProgress ? localize('scm button committing to new branch tooltip', "Committing Changes to New Branch...") : localize('scm button commit to new branch tooltip', "Commit Changes to New Branch"); <del> } else { tooltip = this.state.isCommitInProgress ? localize('scm button committing tooltip', "Committing Changes...") : localize('scm button commit tooltip', "Commit Changes"); </del> } break; } } <del> return { command: { command: 'git.commit', title: title, tooltip: tooltip, arguments: [this.repository.sourceControl, commandArg], }, secondaryCommands: this.getCommitActionButtonSecondaryCommands(), enabled: this.state.repositoryHasChangesToCommit && !this.state.isCommitInProgress && !this.state.isMergeInProgress }; </del> <ins> return { command: 'git.commit', title, tooltip, arguments: [this.repository.sourceControl, commandArg] }; </ins> } private getCommitActionButtonSecondaryCommands(): Command[][] { const commandGroups: Command[][] = []; <del> for (const provider of this.postCommitCommandsProviderRegistry.getPostCommitCommandsProviders()) { const commands = provider.getCommands(new ApiRepository(this.repository)); commandGroups.push((commands ?? []).map(c => { return { command: 'git.commit', title: c.title, arguments: [this.repository.sourceControl, c.command] }; })); } </del> <ins> if (!this.state.isRebaseInProgress) { for (const provider of this.postCommitCommandsProviderRegistry.getPostCommitCommandsProviders()) { const commands = provider.getCommands(new ApiRepository(this.repository)); commandGroups.push((commands ?? []).map(c => { return { command: 'git.commit', title: c.title, arguments: [this.repository.sourceControl, c.command] }; })); } </ins> <del> if (commandGroups.length > 0) { commandGroups[0].splice(0, 0, { command: 'git.commit', title: localize('scm secondary button commit', "Commit") }); </del> <ins> if (commandGroups.length > 0) { commandGroups[0].splice(0, 0, { command: 'git.commit', title: localize('scm secondary button commit', "Commit") }); } </ins> } return commandGroups;

Discussion:
Testing [ ] Update label accordingly (deferred) [x] Remove secondary actions
Pushing this out to the next milestone as there are some things I need to investigate first related to the rebase flow.
Decided to keep the "Commit" label for the button to keep things simple. Will change it if needed, based on customer feedback.
Change:
interface ILanguageConfiguration { comments?: ICommentRule; brackets?: CharacterPair[]; <ins> autoClosingPairs?: CharacterPair[]; surroundingPairs?: CharacterPair[]; </ins> } export class LanguageConfigurationFileHandler {

Discussion:
I have editor.autoClosingBrackets set to true but it seems it works stricly with brackets. I guess autoclosing single/double quotes is not implemented yet? If not, please do it. I think it is a common feature for every editor.
What language is missing them?
Closing after a number of days without a reply.
Change:
title: strings.fetching }; const promise = (async () => { <del> let taskGroupTasks: (Task | ConfiguringTask)[] = []; </del> <ins> let groupTasks: (Task | ConfiguringTask)[] = []; </ins> async function runSingleTask(task: Task | undefined, problemMatcherOptions: IProblemMatcherRunOptions | undefined, that: AbstractTaskService) { that.run(task, problemMatcherOptions, TaskRunSource.User).then(undefined, reason => {

Discussion:
Running the command is activating various unnecessary extensions
This is by design - we have to activate any extensions which contribute tasks to fetch the build tasks, if any, that they contribute.
is that the case even if there's a default task configured? I have a suspicion something has changed because building, for example, vscode repo or just a new extension repo with didn't use to activate, e.g., ocaml extension (and there weren't any changes on the ocaml ext side). I would imagine we in general don't need to activate many extensions if there's a default build task?
Note to self - this was happening before the change where we resolve workspace tasks
This is happening because we check for glob tasks as the default - since we aren't sure which it might be, we have to call with no args and that activates all task providers
this originated here seems like not worth it in most cases. this should probably behind a setting
Change:
}); this._tree.onDidOpen(e => { const aside = (e.browserEvent instanceof MouseEvent) && (e.browserEvent.ctrlKey || e.browserEvent.metaKey || e.browserEvent.altKey); <del> const goto = !e.browserEvent || ((e.browserEvent instanceof MouseEvent) && e.browserEvent.detail === 2); </del> <ins> const goto = !e.browserEvent || (e.browserEvent instanceof KeyboardEvent) || ((e.browserEvent instanceof MouseEvent) && e.browserEvent.detail === 2); </ins> if (aside) { onEvent(e.elements[0], 'side');

Discussion:
Previously was F12 on at It's impossible to navigate to the first result
This is from but that change seems correct, I think we should fix , I think it is just assuming that browserEvent will be undefined when triggered by the keyboard. We can change this for pass for any KeyboardEvent too. Also FYI
Thanks
Change:
} private static _compareTitles(a: string | ILocalizedString, b: string | ILocalizedString) { <del> const aStr = typeof a === 'string' ? a : a.value; const bStr = typeof b === 'string' ? b : b.value; </del> <ins> const aStr = typeof a === 'string' ? a : a.original; const bStr = typeof b === 'string' ? b : b.original; </ins> return aStr.localeCompare(bStr); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.50.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: . UI items are incorrect order when applying the language pack. UI items are sorted in ASC item name of after translation order. Case: <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (only Japanese Language Pack)
Changes button UI, too...
I believe this was a purposeful menu API decision.
Nope. See
Nope. See Thanks! I want to try doing fix this.
I know I can manually sort these, but there are two problems I see: 's an exhaustive process to sort and maintain proper sorting for each menu, as time goes by. would only fix one menu at the time. I can fix the git menus, but what about the others? While the user first submitted the issue about the Git menus, they then rewrote the issue to be about general UI menus. Notice the user is talking about menus in general, so this applies to the default sort. If we don't want to change the default sort order, we should just close this issue.
I get it, Thanks! If name of translation is changed, UI order would be unexpectedly changed. As far as I'm concerned, It would be better to change the default so that UI items are inserted in the order they exist in the object.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified It works! ! ! VS Code version: Code - Insiders 1.51.0-insider (, 2020-10-29T06:01:21.160Z) OS version: Windows_NT x64 10.0.
Change:
string = new types.SnippetString(); string.appendText('foo').appendChoice(['far', '$boo']).appendText('bar'); <del> assert.strictEqual(string.value, 'foo${1|far,$boo|}bar'); </del> <ins> assert.strictEqual(string.value, 'foo${1|far,$boo|}bar'); </ins> string = new types.SnippetString(); string.appendText('foo').appendPlaceholder('farboo').appendChoice(['far', 'boo']).appendText('bar'); assert.strictEqual(string.value, 'foo${1:farboo}${2|far,boo|}bar'); }); <ins> test('Snippet choices are incorrectly escaped/applied #180132', function () { { const s = new types.SnippetString(); s.appendChoice(["aaa$aaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaa$aaa|}bbb$bbb'); } { const s = new types.SnippetString(); s.appendChoice(["aaa,aaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaa,aaa|}bbb$bbb'); } { const s = new types.SnippetString(); s.appendChoice(["aaa|aaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaa|aaa|}bbb$bbb'); } { const s = new types.SnippetString(); s.appendChoice(["aaaaaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaaaaa|}bbb$bbb'); } }); </ins> test('instanceof doesn't work for FileSystemError #49386', function () { const error = types.FileSystemError.Unavailable('foo'); assert.ok(error instanceof Error);

Discussion:
This code inserts a snippet with some dollars but no backslashes: But it shows up with backslashes: !
Change:
import { onUnexpectedError } from 'vs/base/common/errors'; import { KeyCode, KeyMod, SimpleKeybinding } from 'vs/base/common/keyCodes'; import { dispose, IDisposable, DisposableStore, toDisposable, MutableDisposable } from 'vs/base/common/lifecycle'; <ins> import { StableEditorScrollState } from 'vs/editor/browser/core/editorState'; </ins> import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { EditorAction, EditorCommand, registerEditorAction, registerEditorCommand, registerEditorContribution, ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { EditOperation } from 'vs/editor/common/core/editOperation';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I would like an option to virtually prevent vscode from pushing down the current focused line when new lines are automatically . For example, when I click to automatically add an import, vscode adds the import line and the current focused line is scrolled down. This causes a distraction because the line I'm working on is moved away even tho I didn't want to scroll. Here is a gif showing how IntelliJ behavior when new lines are automatically above the current selected line. Note that after the import statement is the current line is virtually kept the same (the line number do change, of course, but the scroll is set to a new position in order to respect the old position): ! The next gif show how vscode pushes down the code and loses the previous virtual position: ! Would be possible to add an option to vscode behavior like IntelliJ in this situation?
Technically, the editor does not scroll. The scrollTop is maintained. It just happens that everything is pushed down by the auto-import which inserts a line at the top of the file. This can be done from the outside if you know there are edits unrelated to the current cursor position in the suggestion e.g.:
I'd like to help out with this! Any additional pointers would be appreciated.
This is where the first potential edit happens: and this is where it is done: So, those two places should be used to capture and restore the scroll state
to verify: down a bit a typescript suggestion that adds an import sure that the scroll position stays stable (lines aren't pushed down)
Change:
if (!state.conflicting && !state.isInputIncluded(inputNumber)) { result.push( !state.isInputIncluded(inputNumber) <del> ? command(localize('accept', "$(pass) Accept {0}", inputData.title), async () => { </del> <ins> ? command(localize('accept', "Accept {0}", inputData.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,

Discussion:
Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used—not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width="269" alt="CleanShot 2022-09-27 at 11 42 19 src="https://user-"<img width="244" alt="CleanShot 2022-09-27 at 11 43 33 src="https://user-"
I can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.
Why don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.
Change:
postcss "^7.0.0" postcss-selector-parser "^3.0.0" <del> sudo-prompt@9.2.1: version "9.2.1" resolved "https://registry.yarnpkg.com/sudo-prompt/-/sudo-prompt-9.2.1.tgz#77efb84309c9ca489527a4e749f287e6bdd52afd" integrity sha512-Mu7R0g4ig9TUuGSxJavny5Rv0egCEtpZRNMrZaYS1vxkiIxGiGUwoezU3LazIQ+KE04hTrTfNPgxU5gzi7F5Pw== </del> sumchecker@^3.0.1: version "3.0.1" resolved "https://registry.yarnpkg.com/sumchecker/-/sumchecker-3.0.1.tgz#6377e996795abb0b6d348e9b3e1dfb24345a8e42"

Discussion:
To recreate: Edit a file requiring sudo (eg ) When saving, VSCode will request sudo permissions and, after granting, gives the following error: I do NOT have Rosetta installed but understand VS Code is supposed to be M1 compatible. Here is the version info:
I cannot reproduce and I am on a M1 as well. thoughts? did you install the universal app?
For triggering we use a 3rd-party module which on macOS uses osascript saved as application bundle As a quick check, trigger a sudo prompt from vscode and open the OS temp directory and check for , following is the executable architecture So unless the user has rosetta installed this application will not be launched on M1 as reported here. you might have rosetta installed hence the failure was not seen, can be confirmed with
Not sure if that applet can be converted to universal, might also be worth looking at alternatives for sudo-prompt given that repo is now archived.
I would suggest to fork the module and convert that applet to universal if that is straightforward.
I don't see the source for the applet under the user repositories, will have to reach out to the author.
Maybe:
would you be able to test this scenario again from the following build that includes a potential fix:
Thanks for all your efforts on this (and . I discovered this on a new M1 Mac where I had not yet installed Rosetta but eventually caved in and installed it. Unfortunately it doesn't appear Rosetta can be easily uninstalled for testing. Happy to give this another go the next time I have a fresh Mac install but don't foresee that in the immediate future...
Verification on a mac with ARM chip without Rosetta 2 installed ([1]) use open try to edit (in the comment area!!!) from the error retry as sudo verify you get a prompt and save works [1] The presence of these files are a good indicator that you have Rosetta2 installed:
I take it you just re-compiled the applet for universal & updated the package with the base64 encoded string (is that right?)
yes! Here is what I did: decode the base64 encoded value unzip it open the apple script in apple script editor export it as application bundle (I have Rosetta 2 installed so it seems to export as universal bundle by default) zip it base64 encode it release as fork from
Change:
import { IChatResponseViewModel } from 'vs/workbench/contrib/chat/common/chatViewModel'; import { renderStringAsPlaintext } from 'vs/base/browser/markdownRenderer'; import { MarkdownString } from 'vs/base/common/htmlContent'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { AccessibilityVoiceSettingId } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </ins> const CHAT_RESPONSE_PENDING_ALLOWANCE_MS = 4000; export class ChatAccessibilityService extends Disposable implements IChatAccessibilityService {

Discussion:
Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Makes sense cc
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
would you, yourself, enable this? I worry about turning off regions.
I don’t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).
That makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,
Yes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.
do you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.
That happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.
I use a separate sound card for my screen reader.
what are some verification steps for this issue?

enable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response
I am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.
Sorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.
Change:
const toolbar = instantiationService.createInstance(MenuWorkbenchToolBar, targetHtmlElement, menuId, { menuOptions: { renderShortTitle: true }, <del> toolbarOptions: { primaryGroup: () => false } </del> <ins> toolbarOptions: { primaryGroup: (g) => g === 'primary' } </ins> }); this._store.add(toolbar); }

Discussion:
! I personally find it a bit strange to have no primary action and only secondary actions hidden behind "...". What is the rationale? //cc
We are looking at pulling these out as primary actions like so. See . <img width="1015" alt="CleanShot 2022-10-03 at 09 11 23 src="https://user-"
!
!