jiebi/CodeConvo huggingface dataset:
Change:
this._openTaskFile(resource, TaskSourceKind.WorkspaceFile); } }); <del> TaskCommandsRegistered.bindTo(this._contextKeyService).set(true); </del> } private get workspaceFolders(): IWorkspaceFolder[] {

Discussion:
a folder try to run task Says task command not found !
What commit is that insiders based on? I believe I fixed this yesterday.
It says there is no updates for me but this is
Is that in oss? Hard to tell
No this is just todays insiders. I can test again on monday if you'd like
Thanks can you repro in oss?
Can repro when running the task command but not ctrl+shift+b. so this is a diff't bug
Reopen due to revert:
Change:
return; } <del> await super.openAuxIssueReporter(data); </del> <ins> const bounds = await this.nativeHostService.getActiveWindowPosition(); if (!bounds) { return; } await this.openAuxIssueReporter(data, bounds); </ins> // Get platform information const { arch, release, type } = await this.nativeHostService.getOSProperties();

Discussion:
atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor. in these two examples, i have one large curved secondary monitor where vs code is. open an aux window, and it spawns it in my laptop's screen. same thing if full screened on secondary monitor. different when full screen on main screen (see ) wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.
that should be possible if you provide the coordinates for where to open the window via : You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the . Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
this._editor.revealPositionInCenterIfOutsideViewport(widgetData.position); const remainingHunks = this._session.hunkData.pending; <del> this._updateSummaryMessage(remainingHunks); </del> <ins> this._updateSummaryMessage(remainingHunks, this._session.hunkData.size); </ins> const mode = this._configService.getValue<'on' | 'off' | 'auto'>(InlineChatConfigKeys.AccessibleDiffView);

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
"default": "prompt", "markdownDescription": "%config.openRepositoryInParentFolders%", "scope": "resource" <del> }, "git.publishBeforeContinueOn": { "type": "string", "enum": [ "prompt", "always", "never" ], "markdownEnumDescriptions": [ "%config.publishBeforeContinueOn.prompt%", "%config.publishBeforeContinueOn.always%", "%config.publishBeforeContinueOn.never%" ], "default": "prompt", "markdownDescription": "%config.publishBeforeContinueOn%", "scope": "resource", "tags": [ "experimental" ] </del> } } },

Discussion:
Testing on Windows 11, latest Insiders When I selected in the publish warning, the same notification toasted again. ! ! I hit Cancel again, and I was then prompted to sign into GitHub, which I already did in the browser before getting the branch toast: ! Perhaps tied to
I realize I'm now getting duplicate toasts after any option. When I selected Allow, I got the same toast again: !

Testing Choosing Never failed: <img width="458" alt="image" src="https://user-"
Choosing Always also failed: <img width="453" alt="image" src="https://user-"
I was using a public repo:
I experience the same on Windows 11 with the repo:
Create New Codespace still fails with ContinueOn
The original issue reported here was due to the fact that we weren't properly awaiting the branch publish before invoking the codespace creation. based on our offline discussion I think you're encountering a different issue because the publish completes but the codespace creation doesn't start, and only if you aren't signed into the GitHub Codespaces extension, so I'm going to close this issue and we can file a new one to investigate the scenario you've uncovered since I can't reproduce it at the moment:

Testing I can't choose to publish and ask again next time: <img width="264" alt="image" src="https://user-"
Also: The text doesn't indicate that the Always/Never choice only applies to the current workspace folder (as I just discovered) and not to all repositories.
+1, I was about to file the same issue.
Great feedback, this leads me to think we should just have 'Yes' and 'Cancel' as the options here, because choosing 'Never' will break the Continue On flow (i.e. it's not an option that we can actually support, and per we should actually throw a and bail out of the whole flow here).
'Publish Branch' might be clearer than 'Yes'. The PR extension uses this dialog: <img width="261" alt="image" src="https://user-"
The "fix" for this is more problematic for me. I used to have this in my settings: Now every time I quit VS Code (I'm on Mac if it makes a difference), I see the dialog and I have to press "Cancel". Even worse, pressing "Cancel" seems to only close the dialog and reopen it again. can we reopen this issue and restore the setting at least? That'd be highly appreciated. Thanks.
Change:
export default class TypeScriptReferencesCodeLensProvider extends TypeScriptBaseCodeLensProvider { public constructor( client: ITypeScriptServiceClient, <del> private readonly language: string </del> <ins> private readonly language: string, cachedResponse: CachedNavTreeResponse </ins> ) { <del> super(client); </del> <ins> super(client, cachedResponse); </ins> } public updateConfiguration(): void {

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.
Change:
} async resolveLink(processManager: Pick<ITerminalProcessManager, 'initialCwd' | 'os' | 'remoteAuthority' | 'userHome'> & { backend?: Pick<ITerminalBackend, 'getWslPath'> }, link: string, uri?: URI): Promise<ResolvedLink> { <ins> // Correct scheme and authority for remote terminals if (uri && uri.scheme === Schemas.file && processManager.remoteAuthority) { uri = uri.with({ scheme: Schemas.vscodeRemote, authority: processManager.remoteAuthority }); } </ins> // Get the link cache let cache = this._resolvedLinkCaches.get(processManager.remoteAuthority ?? ''); if (!cache) {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --It would be great if VS Code would support URIs. For example, Gradle will write the following in the terminal after running Java tests: ! (I had to redact some parts of the path, but imagine that it's a full URI starting at and ending at .) Doing CTRL+click on the URI doesn't open the file, because VS Code is trying to interpret the entire string as a file path, including the part. It would also be great if the dialog would also support URIs. This can be useful when copying and pasting text into it.
The terminal should support this, maybe you're hitting some edge case: <img width="636" alt="Screenshot 2024-03-25 at 5 35 17 AM" src=""Could you try on the and if it happens there could you try get a trace log when you hover the link? cc about supporting file:// paths in quick pick.
I'm installing and setting up insiders. In the meantime, I got some more info. CTRL + hover over the path underlines it, so VS Code does recognize it: ! (You don't see the cursor in the screenshot, because I could only do a screenshot with Print Screen, which seems to remove the cursor. The cursor was over the text.) Clicking the link shows the following: ! It seems to have trouble with the leading . Running in WSL 2, Ubuntu, and VS Code is running in Windows, in case it makes a difference.
I get the same behavior with both VS Code 1.87.2 and 1.88.0-insider.
This is what I see in the terminal trace (in the Insiders version): ! and further up I actually see something related to the URI: !
I just tried this in a "real" Linux. There it did work, I could CTRL+click on the . It seems that WSL might be the issue.
were you using the Remote - WSL extension or just a WSL terminal?
With remote connection: ! So, this extension: !
Can reproduce: ! !
Change:
export class OpenEditorsView extends ViewPane { private static readonly DEFAULT_VISIBLE_OPEN_EDITORS = 9; <ins> private static readonly DEFAULT_MIN_VISIBLE_OPEN_EDITORS = 0; </ins> static readonly ID = 'workbench.explorer.openEditorsView'; static readonly NAME = nls.localize({ key: 'openEditors', comment: ['Open is an adjective'] }, "Open Editors");

Discussion:
Issue Type: <bBug</bthe "OPEN EDITORS" section of the explorer open, and above the explorer's main section. -click one of the files in the main section, but delay the second click slightly. The file opens on the first click and gets to the OPEN EDITORS section. This moves everything below it down by the height of one line, so if that happens before the second click, you're clicking on a different file. Often, instead of opening the second file, it opens a text entry field near the bottom of the explorer's main section (not necessarily anywhere near the mouse cursor) as if I'm trying to create a new file at the top-level of my project. VS Code version: Code 1.57.1 (, 2021-06-17T13:26:56.255Z) OS version: Linux x64 5.12.14-arch1-1 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ vscode-styled-jsx2.0.0 vscode-modelines2.0.5 vscode-eslint2.1.23 vscode-html-css1.10.2 tslint1.0.47 auto-close-tag0.5.11 dotenv1.0.1 vscode-language-pack-en-GB1.54.1 python2021.6. vscode-pylance2021.7.2 jupyter2021.6. remote-containers0.183.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 remote-wsl0.56.5 vscode-remote-extensionpack0.21.0 cpptools1.5.1 lit-plugin1.2.1 sourcekit-lsp0.0.1 vim1.21.5 viml1.0.1 html-css-class-completion1.20.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This is a known limitation. However I could not find the duplicate so let's keep this one open.
I did subsequently find the issue that this duplicates, but it had been closed by a bot: .
The limit is at currently but in theory can be changed to a higher value:
Change:
"contributes": { "languages": [{ "id": "ruby", <del> "extensions": [ ".rb", ".rbx", ".rjs", ".gemspec", ".pp", ".rake", ".ru" ], </del> <ins> "extensions": [ ".rb", ".rbx", ".rjs", ".gemspec", ".rake", ".ru" ], </ins> "filenames": [ "rakefile", "gemfile", "guardfile" ], "aliases": [ "Ruby", "rb" ], "configuration": "./ruby.configuration.json"

Discussion:
VSCode Version: 1.0.0 OS Version: Fedora 23 x86_64 Steps to Reproduce: VSCode Puppet Extension puppet manifest (.pp file) detects it as a Ruby file type The included Ruby language extension has the puppet extension (.pp) in its extensions list and overrides any installed Puppet extension causing Puppet manifest files to always be detected as Ruby files unless a manual override is put into the User Configuration.
// CC
Any progress with this?
This was fixed back in the July/August release. I should have closed it then, sorry. See PR
Change:
import { Model } from '../model'; import { Repository as BaseRepository, Resource } from '../repository'; <del> import { InputBox, Git, API, Repository, Remote, RepositoryState, Branch, ForcePushMode, Ref, Submodule, Commit, Change, RepositoryUIState, Status, LogOptions, APIState, CommitOptions, RefType, CredentialsProvider, BranchQuery, PushErrorHandler, PublishEvent, FetchOptions, RemoteSourceProvider, RemoteSourcePublisher, PostCommitCommandsProvider, RefQuery, BranchProtectionProvider } from './git'; </del> <ins> import { InputBox, Git, API, Repository, Remote, RepositoryState, Branch, ForcePushMode, Ref, Submodule, Commit, Change, RepositoryUIState, Status, LogOptions, APIState, CommitOptions, RefType, CredentialsProvider, BranchQuery, PushErrorHandler, PublishEvent, FetchOptions, RemoteSourceProvider, RemoteSourcePublisher, PostCommitCommandsProvider, RefQuery, BranchProtectionProvider, InitOptions } from './git'; </ins> import { Event, SourceControlInputBox, Uri, SourceControl, Disposable, commands, CancellationToken } from 'vscode'; import { combinedDisposable, mapEvent } from '../util'; import { toGitUri } from '../uri';

Discussion:
I would have expected that the command creates a repository with a branch 'main'. I was using the latest insider: This is the repository created using 'Publish to Github'
Related to
In this particular scenario we should honor the default branch setting on GitHub rather than the VS Code setting.
Change:
import * as MarkdownItType from 'markdown-it'; import { languages, workspace, Disposable, TextDocument, Uri, Diagnostic, Range, DiagnosticSeverity, Position, env, l10n } from 'vscode'; <ins> import { INormalizedVersion, normalizeVersion, parseVersion } from './extensionEngineValidation'; </ins> const product = JSON.parse(fs.readFileSync(path.join(env.appRoot, 'product.json'), { encoding: 'utf-8' })); const allowedBadgeProviders: string[] = (product.extensionAllowedBadgeProviders || []).map((s: string) => s.toLowerCase());

Discussion:
When developing extension the warning in : is wrong because it doesn't check if the extension is supported on older VSCode versions:
Change:
import {readFile} from 'vs/base/node/pfs'; import {IRichEditConfiguration} from 'vs/editor/common/modes/supports/richEditSupport'; import {IModeService} from 'vs/editor/common/services/modeService'; <ins> import {IAutoClosingPair} from 'vs/editor/common/modes'; </ins> type CharacterPair = [string, string];

Discussion:
I have editor.autoClosingBrackets set to true but it seems it works stricly with brackets. I guess autoclosing single/double quotes is not implemented yet? If not, please do it. I think it is a common feature for every editor.
What language is missing them?
Closing after a number of days without a reply.
Change:
export class BulkEditPreviewProvider implements ITextModelContentProvider { <del> static readonly Schema = 'vscode-bulkeditpreview'; </del> <ins> private static readonly Schema = 'vscode-bulkeditpreview-editor'; </ins> static emptyPreview = URI.from({ scheme: BulkEditPreviewProvider.Schema, fragment: 'empty' });

Discussion:
Make a refactor and open the refactor preview Click on accept/discard The editor showing the refactor preview does not close
Change:
const onSuccess = async (value: string): Promise<void> => { try { <del> const created = isFolder ? await fileService.createFolder(resources.joinPath(folder.resource, value)) : await textFileService.create(resources.joinPath(folder.resource, value)); </del> <ins> const created = isFolder ? await workingCopyFileService.createFolder(resources.joinPath(folder.resource, value)) : await textFileService.create(resources.joinPath(folder.resource, value)); </ins> await refreshIfSeparator(value, explorerService); isFolder ?

Discussion:
It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.
Some background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.
We currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.
I don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both
Verification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.
Thanks for fixing!
Change:
private keybindings?: (action: IAction) => ResolvedKeybinding | undefined; private clazz: string | undefined; private anchorAlignmentProvider: (() => AnchorAlignment) | undefined; <ins> private menuAsChild?: boolean; </ins> <del> constructor(action: IAction, menuActions: ReadonlyArray<IAction>, contextMenuProvider: IContextMenuProvider, actionViewItemProvider: IActionViewItemProvider | undefined, actionRunner: IActionRunner, keybindings: ((action: IAction) => ResolvedKeybinding | undefined) | undefined, clazz: string | undefined, anchorAlignmentProvider?: () => AnchorAlignment); constructor(action: IAction, actionProvider: IActionProvider, contextMenuProvider: IContextMenuProvider, actionViewItemProvider: IActionViewItemProvider | undefined, actionRunner: IActionRunner, keybindings: ((action: IAction) => ResolvedKeybinding) | undefined, clazz: string | undefined, anchorAlignmentProvider?: () => AnchorAlignment); constructor(action: IAction, menuActionsOrProvider: ReadonlyArray<IAction> | IActionProvider, contextMenuProvider: IContextMenuProvider, actionViewItemProvider: IActionViewItemProvider | undefined, actionRunner: IActionRunner, keybindings: ((action: IAction) => ResolvedKeybinding | undefined) | undefined, clazz: string | undefined, anchorAlignmentProvider?: () => AnchorAlignment) { </del> <ins> constructor(action: IAction, menuActions: ReadonlyArray<IAction>, contextMenuProvider: IContextMenuProvider, actionViewItemProvider: IActionViewItemProvider | undefined, actionRunner: IActionRunner, keybindings: ((action: IAction) => ResolvedKeybinding | undefined) | undefined, clazz: string | undefined, anchorAlignmentProvider?: () => AnchorAlignment, menuAsChild?: boolean); constructor(action: IAction, actionProvider: IActionProvider, contextMenuProvider: IContextMenuProvider, actionViewItemProvider: IActionViewItemProvider | undefined, actionRunner: IActionRunner, keybindings: ((action: IAction) => ResolvedKeybinding) | undefined, clazz: string | undefined, anchorAlignmentProvider?: () => AnchorAlignment, menuAsChild?: boolean); constructor(action: IAction, menuActionsOrProvider: ReadonlyArray<IAction> | IActionProvider, contextMenuProvider: IContextMenuProvider, actionViewItemProvider: IActionViewItemProvider | undefined, actionRunner: IActionRunner, keybindings: ((action: IAction) => ResolvedKeybinding | undefined) | undefined, clazz: string | undefined, anchorAlignmentProvider?: () => AnchorAlignment, menuAsChild?: boolean) { </ins> super(null, action); this.menuActionsOrProvider = menuActionsOrProvider;

Discussion:
!
Reproduces in an insiders build from 3 days ago. Maybe related to context view changes?
closedWith
Change:
this.contextMenuService.showContextMenu({ getAnchor: () => anchor, <del> getActions: () => Separator.join(...actions), </del> <ins> getActions: () => Separator.join(...allActions.map((a) => a[1])), </ins> onHide: () => menu.dispose(), }); });

Discussion:
configure "testing.defaultGutterClickAction": "contextMenu", open a test file and click on a test icon a context menu opens but the test commands aren't atop <img width="356" alt="Screenshot 2023-03-31 at 15 41 37" src="https://user-"
Change:
import { localize } from 'vs/nls'; import { mark } from 'vs/base/common/performance'; import { Emitter, Event } from 'vs/base/common/event'; <del> import { Dimension, EventHelper, EventType, ModifierKeyEmitter, addDisposableListener, cloneGlobalStylesheets, copyAttributes, createLinkElement, createMetaElement, getActiveWindow, getClientArea, getWindowId, isGlobalStylesheet, position, registerWindow, sharedMutationObserver, size, trackAttributes } from 'vs/base/browser/dom'; </del> <ins> import { Dimension, EventHelper, EventType, ModifierKeyEmitter, addDisposableListener, cloneGlobalStylesheets, copyAttributes, createLinkElement, createMetaElement, getActiveWindow, getClientArea, getWindowId, isGlobalStylesheet, position, registerWindow, sharedMutationObserver, trackAttributes } from 'vs/base/browser/dom'; </ins> import { CodeWindow, ensureCodeWindow, mainWindow } from 'vs/base/browser/window'; import { Disposable, DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions';

Discussion:
Testing a workspace a tab into a new floating window in a couple times using keyboard shortcuts the zoom status bar item to zoom out. When the zoom out happens, the status bar item will move further right, as expected because everything is getting small. However, the hover itself moved further left. I would expect it to either stay under my cursor (ideal) or move with the status bar item. !
It also moves around unexpectedly when I zoom in.
My cursor isn't showing properly in this gif, but I think you can get the idea. !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
class: ThemeIcon.asClassName(settingsEditIcon), enabled: true, id: 'workbench.action.editListItem', <del> label: this.getLocalizedStrings().editActionTooltip, </del> <ins> label: '', </ins> tooltip: this.getLocalizedStrings().editActionTooltip, run: () => this.editSetting(idx) },

Discussion:
When hovering over any setting with the "object" structure there is a rendering issue on the right side of the row. See screenshot attached. !
Edit: this effects all settings with type "object", not related to screen readers. Repros with all screen reader related apps turned off.
I now but this is it intel they give my money