jiebi/CodeConvo huggingface dataset:
Change:
// If undefined is passed checks if any element is currently being edited. isEditable(stat: ExplorerItem | undefined): boolean; findClosest(resource: URI): ExplorerItem | null; <ins> findClosestRoot(resource: URI): ExplorerItem | null; </ins> refresh(): Promise<void>; setToCopy(stats: ExplorerItem[], cut: boolean): Promise<void>; isCut(stat: ExplorerItem): boolean;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --Related Issues: <!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Linux x64 5.8.0-44-generic Steps to Reproduce: a root folder (files-exclude-sample) that folder create two nested folders (child1, child2) root folder (files-exclude-sample), create a workspace definition file (files-exclude-) root folder (files-exclude-sample), create a .vscode folder .vscode folder create a file to previous steps, just clone this GitHub repo: VSCode, open the workspace (files-exclude-) looks ok. You have tree root folders (files-exclude-sample, child1 and child2) ! you expand all three folder you can see something like ! specified in root folder , child1 and child2 are excluded from child1 folder child1 folder is collapsed (not removed from explorer tree) and it appears inside root folder (files-exclude-sample) folder ! expected behavior is that child1 is not collapsed and it does not appear inside root folder <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
the owner of the file explorer is
I acknowledge this issue. MR workspace support with when one root folder is a subfolder of another root folder has some issues. If somebody is passionate about fixing this let me know and I can provide pointers
Created fixing this
Thanks to a great pr by this is now fixed
Change:
export const MENU_MNEMONIC_REGEX = /(&([^s&]))|(^|[^&])&([^s&])/; export const MENU_ESCAPED_MNEMONIC_REGEX = /(&amp;)?(&amp;)([^s&])/g; <del> const menuSelectionIcon = registerIcon('menu-selection', Codicon.chevronRight); const menuSubmenuIcon = registerIcon('menu-submenu', Codicon.check); </del> <ins> const menuSelectionIcon = registerIcon('menu-selection', Codicon.check); const menuSubmenuIcon = registerIcon('menu-submenu', Codicon.chevronRight); </ins> export enum Direction { Right,

Discussion:
Issue Type: <bBug</bThe preference icon in File option is not correct. It should be , not √. ! VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T08:44:55.510Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Actually duplicate of

Issue Type: <bBug</bafter the latest update observed tick marks in the menu instead of the "" sign to indicate there is a submenu. is this expected change? i have pinned the menu in the sidebar. ! VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T06:26:58.340Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.15.0-96-generic <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ remote-containers0.112.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.2 vscode-remote-extensionpack0.20.0 debugger-for-chrome4.12.6 ng-template0.901.2 vscode-eslint2.1.5 gitlens10.2.1 EditorConfig0.14.5 prettier-vscode4.4.0 node-debug21.42.2 typescript-javascript-grammar0.0.53 vscode-typescript-tslint-plugin1.2.3 vsliveshare1.0.2000 vscode-xml0.11.0 vscode-yaml0.7.2 LiveServer5.6.1 sonarlint-vscode1.15.0 vscodeintellicode1.2.6 </details<!-- generated by issue reporter --
I don't think that this one is intended. /cc May be something with codicons or styles. I noticed that I have sometimes spinning instead of because former overrides styles of loader. Haven't noticed this problem before
related to product icon overrides?
sorry for mention, I was not aware about changes in approach to use Codicons and thought that it might be unintentional font update. Yes, looks like it was part of . PR with fix is available
Change:
} } <del> return true; </del> <ins> return false; </ins> } public getSurroundingPairs(): IAutoClosingPair[] {

Discussion:
VSCode Version: Code 1.14.0 (, 2017-07-10T18:36:31.751Z) OS Version: Windows_NT ia32 10.0. Extensions: ExtensionVersion ------ jshint0.10.15 vscode-todo-parser1.8.10 debugger-for-chrome3.1.6 language-liquid0.0.2 vscode-jest2.2.0 Writing a less-than sign automatically adds a greater-than sign after it. The update seems to have caused this as I have never had an issue with it before. Steps to Reproduce: a fenced JavaScript code block like: javascript a inside the fence. will add a after the you typed resulting in: javascript &lt; <!-- Launch with to check. --Reproduces without extensions: Yes

Generalization of Steps to Reproduce: a markdown file: the js code block, type Bug inserted. Root cause* Markdown defines and as auto closing pairs. Js does not. It appears that we always use the document language's autoclosing pairs instead of the autoclosing pairs of the embedded language at the current cursor position
Good catch, auto close should check language around cursor instead of model.
Another case: Based on JS's auto closing rules, we would expect completion to
Change:
preview: HTMLElement; builtin: HTMLElement; license: HTMLElement; <ins> version: HTMLElement; </ins> publisher: HTMLElement; installCount: HTMLElement; rating: HTMLElement;

Discussion:
Version: 1.44.0-insider Commit: Date: 2020-03-31T08:28:37.335Z The extensions view header has all the important information about an extension, but not the installed or latest version number. I often need this when filing issues to a extension. !
Change:
}); this.model.updateBreakpoints(data); <ins> if (this.telemetryAdapter) { this.telemetryAdapter.dispose(); this.telemetryAdapter = null; } </ins> this.inDebugMode.reset(); }

Discussion:
If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).
this is probably something you want to use...
The functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .
we are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?
yes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?
What we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.
For Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?
previously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.
Change:
* @param slc The shell launch config to check. */ export function shouldUseEnvironmentVariableCollection(slc: IShellLaunchConfig): boolean { <del> return !slc.strictEnv && !slc.hideFromUser; </del> <ins> return !slc.strictEnv; </ins> }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No For proposed API: <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.85.0-insider (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: a hidden terminal using to text to terminal, for eg. "echo hello" no events are fired Same is not the case if is set to . cc/
Any idea where the issue could be here? We require this to start leveraging
This is by design according to this: We tweaked the condition in to work properly on remotes, and tried to force shell integration for debug terminals here: I don't see an issue with changing hidden terminals from having shell integration, we just need to watch the incoming issues for problems.
If we have shell integration in hidden terminals is conflicts with but I think the thinking was changed in If you don't want env collections you must pass , which means you need to provide the entire environment.
I still repro this with the following minimum repro: Changing to fires the event. Or maybe there are other steps that should be taken?
Reopening as your steps seem correct
possible that the hidden terminal isn't yet a part of yet, so is not within here? Yes, seems like it
We should include in I think
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
these steps are good
Change:
onExtensionError(extension: ExtensionIdentifier, error: Error): boolean { const logger = this._telemetryLoggers.get(extension.value); <ins> if (logger && logger.isDisposed) { this._telemetryLoggers.delete(extension.value); return false; } </ins> if (!logger || logger.ignoreUnhandledExtHostErrors) { return false; }

Discussion:
Testing Given this code: I was expecting my event handlers not to fire since the logger is disposed, but they still fire.
This still repros for me <img width="1210" alt="image" src="https://user-"
Change:
} else { delete this._elements.statusLabel.dataset['state']; } <ins> this._elements.statusLabel.dataset['title'] = ops.title; </ins> this._onDidChangeHeight.fire(); }

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
actionOptions.run(this.actionContainer); })); <del> this._register(dom.addDisposableListener(this.actionContainer, dom.EventType.KEY_UP, e => { </del> <ins> this._register(dom.addDisposableListener(this.actionContainer, dom.EventType.KEY_DOWN, e => { </ins> const event = new StandardKeyboardEvent(e); <del> if (event.equals(KeyCode.Enter)) { </del> <ins> if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) { </ins> e.stopPropagation(); e.preventDefault(); actionOptions.run(this.actionContainer);

Discussion:
workspace trust workspace untrusted settings the hover for the workspace trust indicator and focus it to the action and press enter :bug: The action doesn't run pressing tab :bug: Focus leaves the hover and the hover stays open
Change:
return stream; } <del> private readFileUnbuffered(provider: IFileSystemProviderWithFileReadWriteCapability | IFileSystemProviderWithFileAtomicReadCapability | IFileSystemProviderWithFileReadCapability, resource: URI, options?: IReadFileOptions & IReadFileStreamOptions): VSBufferReadableStream { </del> <ins> private readFileUnbuffered(provider: IFileSystemProviderWithFileReadWriteCapability | IFileSystemProviderWithFileAtomicReadCapability, resource: URI, options?: IReadFileOptions & IReadFileStreamOptions): VSBufferReadableStream { </ins> const stream = newWriteableStream<VSBuffer>(data => VSBuffer.concat(data)); // Read the file into the stream async but do not wait for

Discussion:
Refs: I do not understand this condition: How does that make sure a method exists? The only check for this that is valid currently is , the is just a detail of the file system and not a capability.
This looks like an actual typo to me or missing code review, not sure the consequences, as it could lead to errors when wrongly asserting, so maybe moving to August for investigation.
TLDR I misunderstood how the declared capabilities relate to the actual declared methods and the meaning of . For context, this change came in through and the intention of this change was to support the scenario where an has declared but not : since is optional in the interface and the capability requires both and to be implemented: I made this change because when implementing a with but not , this would result in throwing here: I see how it's possible that a which has check does not have a method implemented. Additionally I see that we have other examples of how to handle the requirement of a readonly filesystem which implements both and , e.g.: I am reverting Apologies for the incorrect code change and thank you for pointing this out.
Change:
export const file = 'file'; export const untitled = 'untitled'; export const git = 'git'; <ins> export const github = 'github'; </ins> /** Live share scheme */ export const vsls = 'vsls'; export const walkThroughSnippet = 'walkThroughSnippet';

Discussion:
a TS file Bug The repo index downloads quickly but TS initialization takes a long time From a profile, I noticed that some calls from the TS Server take between 200 and 400ms: ! I also noticed that we seem to be making network requests which invoke for a bunch of repos with names that look like file paths. ! Following this further, I noticed the request on JS/TS sends over two copies of every file: Note that these paths are transformed into URIs that look like: The first one is the correct path AFAIK? Not sure where the second one is coming from, but it seems to be the request that generates the network requests Does remote hub have two file system providers, one for and one for ? If it does, should JS/TS ignore the open documents?
Yes, there are two file system providers, and you can just deal with the URIs.
I consistently see two requests for TS server, is that expected? <img width="966" alt="image" src="https://user-"
Yes, we start two instance of the server: one fast one and one for project wide support. Hopefully with caching though this does not actually result in two network requests
Change:
} override getTitle(verbosity?: Verbosity): string { <ins> let title: string; </ins> if (this.hasIdenticalSides) { <del> return this.primary.getTitle(verbosity) ?? this.getName(); </del> <ins> title = this.primary.getTitle(verbosity) ?? this.getName(); } else { title = super.getTitle(verbosity); </ins> } <del> return super.getTitle(verbosity); </del> <ins> const preferredTitle = this.getPreferredTitle(); if (preferredTitle) { title = `${preferredTitle} (${title})`; } return title; } protected getPreferredTitle(): string | undefined { if (this.preferredName && this.preferredDescription) { return `${this.preferredName} ${this.preferredDescription}`; } if (this.preferredName || this.preferredDescription) { return this.preferredName ?? this.preferredDescription; } return undefined; </ins> } override getLabelExtraClasses(): string[] {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When set to fixed, the title of diff editor which is opened by clicking item in timeline view will only show the title of the editor, and I also need to see all of the editor name: !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
*/ export const editorLightBulbForeground = registerColor('editorLightBulb.foreground', { dark: '#FFCC00', light: '#DDB100', hcDark: '#FFCC00', hcLight: '#007ACC' }, nls.localize('editorLightBulbForeground', "The color used for the lightbulb actions icon.")); export const editorLightBulbAutoFixForeground = registerColor('editorLightBulbAutoFix.foreground', { dark: '#75BEFF', light: '#007ACC', hcDark: '#75BEFF', hcLight: '#007ACC' }, nls.localize('editorLightBulbAutoFixForeground', "The color used for the lightbulb auto fix actions icon.")); <ins> export const editorLightBulbAiForeground = registerColor('editorLightBulbAi.foreground', { dark: darken(iconForeground, 0.4), light: lighten(iconForeground, 1.7), hcDark: iconForeground, hcLight: iconForeground }, nls.localize('editorLightBulbAiForeground', "The color used for the lightbulb AI icon.")); </ins> /** * Diff Editor Colors

Discussion:
I like the AI sparkle but I think its color is too strong. IMO it should be less strong and so that it blends away a little more <img width="192" alt="Screenshot 2023-11-29 at 12 46 12" src=""
for help
Hey thanks for writing about this, this is indeed a good point. I can make the opacity lower (set it for example to 0.5). With such an opacity, the icon looks as follows: ! ! What do you think ?
Looks like an improvement
Change:
[...this.viewCell.outputs].reverse().forEach(output => { if (this.outputElements.has(output)) { // already exist <del> prevElement = this.outputElements.get(output); </del> <ins> prevElement = this.outputElements.get(output)!.element; </ins> return; } // newly added element let currIndex = this.viewCell.outputs.indexOf(output); this.renderOutput(output, currIndex, prevElement); <del> prevElement = this.outputElements.get(output); </del> <ins> prevElement = this.outputElements.get(output)!.element; </ins> }); let editorHeight = templateData.editor!.getContentHeight();

Discussion:
Notice the cell goes beyond the right margin. Seems to happen for all cells
is it related to the indentation change?
I don't think there's an issue here anymore? I did push a change to ensure that a line of text with no whitespace will break and not overflow. But I don't see any other issues with overflowing horizontally. I do see plain text outputs overflowing if I resize the editor to be narrower...
Change:
}); ptyProcess.on('exit', function (exitCode) { <ins> ptyProcess.kill(); </ins> process.exit(exitCode); });

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.1 OS Version: OSX 10.11.6 Steps to Reproduce: multiple workspaces open each with bash and do stuff in each Code either by update or reboot that bash histories are not restored useful when you run a complex command to run a project in a particular way.
I believe this is related to the terminal instances not being shut down gracefully when vscode is shutdown.
I'd like to attempt a PR for this. But I'm unable to reproduce this. Here's what I tried: multiple instances of VSCode with integrated terminals in them. a few commands in the integrated terminals Quit VS Code (in Mac OS X) a new terminal window and hit key to cycle through my bash history. I was able to view the commands I ran from within VS Code. This could also be an issue because of differences in bash configuration.
I believe this mainly just needs the program to also call in addition to killing itself when it's orphaned. It would be great if you could look into this. FYI here's another issue with more details which I'll close off in favor of this one

Particularly on Windows, should be called to terminate the process. This will ensure the sockets are closed and the pty agent is shutdown.
Closing in favor of
Change:
*/ export const editorLightBulbForeground = registerColor('editorLightBulb.foreground', { dark: '#FFCC00', light: '#DDB100', hcDark: '#FFCC00', hcLight: '#007ACC' }, nls.localize('editorLightBulbForeground', "The color used for the lightbulb actions icon.")); export const editorLightBulbAutoFixForeground = registerColor('editorLightBulbAutoFix.foreground', { dark: '#75BEFF', light: '#007ACC', hcDark: '#75BEFF', hcLight: '#007ACC' }, nls.localize('editorLightBulbAutoFixForeground', "The color used for the lightbulb auto fix actions icon.")); <del> export const editorLightBulbAiForeground = registerColor('editorLightBulbAi.foreground', { dark: darken(iconForeground, 0.4), light: lighten(iconForeground, 1), hcDark: iconForeground, hcLight: iconForeground }, nls.localize('editorLightBulbAiForeground', "The color used for the lightbulb AI icon.")); </del> <ins> export const editorLightBulbAiForeground = registerColor('editorLightBulbAi.foreground', { dark: editorLightBulbForeground, light: editorLightBulbForeground, hcDark: editorLightBulbForeground, hcLight: editorLightBulbForeground }, nls.localize('editorLightBulbAiForeground', "The color used for the lightbulb AI icon.")); </ins> /** * Diff Editor Colors

Discussion:
This is subjective (and others might not feel this way) but the grey sparkle looks a bit off-putting to me, especially in dark mode. I guess there was feedback that non-filled grey sparkle was not too visible, but the current solution seems less pleasant. <img width="643" alt="image" src=""<img width="455" alt="image" src=""
I agree. What about using the same yellow as the lightbulb? In the end it is just a different lightbulb. And we don't need to make up a new color. !
I will change the color of the sparkle to make it yellow
Is that ok for you?
I thought changed this before from yellow to grey based of previous feedback. :) Maybe we should just increase the contrast?
I think the yellow looks good and has some advantages: we don't need to come up with a new color. It's difficult to pick a color that works for existing themes the sparkle is just a variant of the lightbulb and the hope is using the same color will convey that
Hi afaik the sparkle was always white or slightly grey, so now we are thinking of changing it to yellow