jiebi/CodeConvo huggingface dataset:
Change:
* Given the `repository.root` compute the relative path while trying to preserve * the casing of the resource URI. The `repository.root` segment of the path can * have a casing mismatch if the folder/workspace is being opened with incorrect <del> * casing. </del> <ins> * casing which is why we attempt to use substring() before relative(). </ins> */ export function relativePath(from: string, to: string): string { <del> // On Windows, there are cases in which `from` is a path that contains a trailing `` character // (ex: C:, serverfolder) due to the implementation of `path.normalize()`. This behavior is // by design as documented in https://github.com/nodejs/node/issues/1765. if (isWindows) { from = from.replace(/$/, ''); </del> <ins> // There are cases in which the `from` path may contain a trailing separator at // the end (ex: "C:", "serverfolder" (Windows) or "/" (Linux/macOS)) which // is by design as documented in https://github.com/nodejs/node/issues/1765. If // the trailing separator is missing, we add it. if (from.charAt(from.length - 1) !== sep) { from += sep; </ins> } if (isDescendant(from, to) && from.length < to.length) { <del> return to.substring(from.length + 1); </del> <ins> return to.substring(from.length); </ins> } // Fallback to `path.relative`

Discussion:
VS Code Version: 1.82.0-insider OS Version: Ubuntu 22.04 The path is missing the first character in the path for a specific file on the 'git show --textconv' lines 'ub-folder' vs 'sub-folder' If the command is run manually, with the correct path there are no issues Working (Non-root folder) 2023-08-03 19:10:33.264 [info] git show --textconv [4ms] 2023-08-03 19:10:33.267 [info] git ls-tree -l HEAD -- [4ms] Not Working (Root folder) 2023-08-03 19:12:26.351 [info] git show --textconv [20ms] 2023-08-03 19:12:26.386 [info] git ls-tree -l HEAD -- [35ms] Expected (Root folder) 2023-08-03 19:12:26.351 [info] git show --textconv [20ms] 2023-08-03 19:12:26.386 [info] git ls-tree -l HEAD -- [35ms] Originally posted by in
could you please share repro steps that I could use to reproduce this? Or the complete contents of the git output window would also help. I have a suspicion where the issue is but I need the logs to reproduce and fix the issue. Thanks!
Hello Ladislau Szomoru, open vsc go to Source Control (Ctrl+Shift+G) look under "Staged Changes" and click on notice left side is always empty and right side shows entire file changed. Thanks, Gregory Porras
Change:
return true; } <del> private async commitWithAnyInput(repository: Repository, opts?: CommitOptions): Promise<void> { </del> <ins> private async commitWithAnyInput(repository: Repository, opts: CommitOptions): Promise<void> { </ins> const message = repository.inputBox.value; const root = Uri.file(repository.root); const config = workspace.getConfiguration('git', root);

Discussion:
Issue Type: <bBug</bWhen I drill down into the git menu and choose the option to , I really don't need the same confirmation dialog as when I just hit the top-level check mark in the source control pane. The dialog tells me ; this is an incorrect warning at this stage, since I clearly invoked it by choosing . I certainly don't want to choose the option in response to this warning, since it's a good warning to have when I accidentally hit the checkmark without staging any changes. VS Code version: Code 1.67.0 (, 2022-05-04T12:14:47.100Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Change:
context.subscriptions.push(vscode.languages.registerDocumentSymbolProvider(selector, new MDDocumentSymbolProvider(engine))); context.subscriptions.push(vscode.languages.registerDocumentLinkProvider(selector, new LinkProvider())); <ins> context.subscriptions.push(vscode.languages.registerFoldingProvider(selector, new MarkdownFoldingProvider(engine))); </ins> const previewSecuritySelector = new PreviewSecuritySelector(cspArbiter, previewManager);

Discussion:
:+1:
+1
Why is this essential feature still not a thing?
because it relies on which is non-trivial and it needs to be prioritized against other work.
+1
+1
+1 or adding a heading list view(TOC view) on the right side, it's really convenient for editing a large markdown file.
Please refer to the org-mode tab feature to implement, it's powerful.
+1
duplicate of
Reopening to track the markdown specific work of
I noticed that this is already implemented in the latest insider build, thanks a lot. One more request, would you please preserve the last blank line of a folded region? I mean becomes instead of One reason is that currently
Can anyone update the status on this?
it's coming to the next stable release.
Change:
<meta charset="UTF-8"> <meta http-equiv="Content-Security-Policy" <del> content="default-src 'none'; script-src 'sha256-PXLLbTxUqUn4p+KvvFj5cqYN1AHAoeOHkHWZwsmuGck=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </del> <ins> content="default-src 'none'; script-src 'sha256-tzEa4Fy2HeWh9MuG37ZD3KtUwJ9bB44fgpDcvpmRm2w=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </ins> <!-- Disable pinch zooming --> <meta name="viewport"

Discussion:
I just tried Codespaces for the first time. I clicked on Codespaces, and then I started my first Jupyter template. Then I opened one of the included notebooks (). The window opened is empty and it loops forever (small moving blue line moving from left to right on top of window). It also opens the following notifications: " Error loading webview: Error: Could not register service workers: NotSupportedError: Failed to register a ServiceWorker for scope ('') with script (''): The user denied permission to use Service Worker.. " There seems to be an option for "Insiders Version". I tried that as well, but to no avail, same error. I also tried the latest version of the Jupyter extension plugin by Microsoft, still the same error. The demo/jupyter template seems to be broken. Also any advise on how to try it out ? cheers ADD ISSUE DESCRIPTION HERE Version: 1.76.0 Commit: User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36 Embedder: codespaces <!-- generated by web issue reporter --
What browser are you using? Are you in private mode?
hi thanks for the follow up. I'm not sure what "private mode" means, but I was using a standard Chrome browser in a linux laptop. chrome://version ==110.0.5481.177 (Official Build) (64-bit)
In chrome it's called incognito mode. Are you using it or any other privacy type settings, specifically around cookies?
Oh, apologies. No, I was not using incognito mode. I don't have any special cookies settings, or using any extension in that direction. Pretty vanilla set up, as far as I know.
Also I tried from 2 different computers, both using Chrome, and Linux 22.04.
Oh, ok, today I tried once again. And this time I noticed that Chrome is configured to block third-party cookies -- I hadn't noticed before because that only kicks in later, once I open the jupyter notebooks. Once I clicked on the little icon to enable it, it works!
Maybe worth finding a way to communicate this to the user ?
Thanks for confirming. Discussed in AFAIk we can't actually track that this setting is causing the error, but I'll see if we can add some suggestion text to the error message we show
Change:
*/ this.telemetryReporter.sendTelemetryEvent('git.command', { command: id }); <del> return result.catch(async err => { </del> <ins> return result.catch(err => { </ins> const options: MessageOptions = { modal: true };

Discussion:
commit action button is doing “Commit & Sync” is a conflicting change on the remote the file, write a commit message, and CTRL + ENTER succeeded, but the sync operation results in a merge conflict
Change:
min-width: 0; } <del> .monaco-list-row.disabled .extension-list-item .details .description { </del> <ins> .monaco-list-row.disabled .extension-list-item { </ins> color: var(--vscode-disabledForeground); } <ins> .monaco-list-row.disabled.selected .extension-list-item .details .header .name, </ins> .monaco-list-row.disabled.selected .extension-list-item .details .description { color: unset; }

Discussion:
The extension name becomes non-opaque as I hover over each extension name. https://user- cc
Seems like we've been playing whack-a-mole with the disabled state styles recently. any idea what's going on here?
It seems we have different ways to set the disabled color. Fixed it to use the defined disabled color that is already being used for description.
Thanks
Change:
import * as path from 'path'; import * as vscode from 'vscode'; import { DocumentSelector } from '../configuration/documentSelector'; <ins> import * as languageIds from '../configuration/languageIds'; </ins> import { API } from '../tsServer/api'; import type * as Proto from '../tsServer/protocol/protocol'; import * as typeConverters from '../typeConverters'; <del> import { ClientCapability, ITypeScriptServiceClient, ServerResponse } from '../typescriptService'; </del> <ins> import { ClientCapability, ITypeScriptServiceClient } from '../typescriptService'; </ins> import FileConfigurationManager from './fileConfigurationManager'; import { conditionalRegistration, requireSomeCapability } from './util/dependentRegistration'; <ins> import { LanguageDescription } from '../configuration/languageDescription'; type RenameResponse = { readonly type: 'rename'; readonly body: Proto.RenameResponseBody; } | { readonly type: 'jsxLinkedEditing'; readonly spans: readonly Proto.TextSpan[]; }; </ins> class TypeScriptRenameProvider implements vscode.RenameProvider { public constructor( <ins> private readonly language: LanguageDescription, </ins> private readonly client: ITypeScriptServiceClient, private readonly fileConfigurationManager: FileConfigurationManager ) { }

Discussion:
!
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Why has this been marked out of scope? This is a feature that was .
facing the same
Same problem here. This IS crucial for big projects.
To verify: renames should rename matching tags now. Test on both html tag names () and custom components () you change , then renaming custom components should instead renaming all references to that component
Change:
word-break: break-all; } <ins> .monaco-workbench .repl .repl-tree.word-wrap .monaco-tl-contents .expression.nested-variable { white-space: pre; /* Preserve whitespace but don't wrap */ } </ins> .monaco-workbench.mac .repl .repl-tree .monaco-tl-twistie.collapsible + .monaco-tl-contents, .monaco-workbench.mac .repl .repl-tree .monaco-tl-twistie { cursor: pointer;

Discussion:
The new lazy variable evaluation button line-height or dimensions appear to be too large. The button creates frequent gaps in-between node items and creates unsightly misalignment. This is not a settings font issue because the issue appeared with the change to the lazy evaluation button in version 1.67.1. This new button does not improve JavaScript debugging. The ellipsis button did not do this. Version: 1.67.1 (user setup) Commit: Date: 2022-05-06T12:37:03.389Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: JavaScript object to console window the gaps between expandable nodes any collapsed variable to evaluate. The item will jump and become misaligned. !
Hey is there a reason that the variables view tree is 22px tall while the hover variables rows are 18px tall? I just noticed this.
I think the idea is to make the debugHover tree smaller, while the other trees in views should be larger. The problem here seems to be that the debugHover reuses the and by that the height of the hover items is 22. So the height should be configurable, and debugHover should be able to say to the variableDelagate that the height is 18 in this case.
The variables tree in the debug hover is correctly sized. It's just a CSS issue on that one button. I guess it's intentional, and that's fine, so I'll just fix the css.
okey. Thanks for fixing
This broke the alignment of the lazy button in the debug console because the text wraps there
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> import { IStateService } from 'vs/platform/state/node/state'; import { machineIdKey } from 'vs/platform/telemetry/common/telemetry'; import { resolveMachineId as resolveNodeMachineId } from 'vs/platform/telemetry/node/telemetryUtils'; <del> export async function resolveMachineId(stateService: IStateService) { </del> <ins> export async function resolveMachineId(stateService: IStateService, logService: ILogService) { </ins> // Call the node layers implementation to avoid code duplication <del> const machineId = await resolveNodeMachineId(stateService); </del> <ins> const machineId = await resolveNodeMachineId(stateService, logService); </ins> stateService.setItem(machineIdKey, machineId); return machineId; }

Discussion:
When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to
if you support the idea I can provide a PR
that all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.
Change:
}; } catch (e) { this._logService.warn(`Couldn't get layout info, a terminal was probably disconnected`, e.message); <del> this._logService.info('Reattach to wrong terminal debug info - layout info by id', t); this._logService.info('Reattach to wrong terminal debug info - _revivePtyIdMap', Array.from(this._revivedPtyIdMap.values())); </del> <ins> this._logService.debug('Reattach to wrong terminal debug info - layout info by id', t); this._logService.debug('Reattach to wrong terminal debug info - _revivePtyIdMap', Array.from(this._revivedPtyIdMap.values())); this._logService.debug('Reattach to wrong terminal debug info - _ptys ids', Array.from(this._ptys.keys())); </ins> // this will be filtered out and not reconnected return { terminal: null,

Discussion:
some terminals and type in them the window or restart VS Code they don't persist Started happening in OSS on Wednesday July 5th
is undefined !
it gets set to !
that's the return value (see )
yes, true. but the call returns so it's getting reset somewhere. not via !
I'm on to the cause... The process is getting killed after detaching on reload, so reconnect breaks: Revive after restart is working for me.
Ah found it: Investigating...
Parsed state is null so reconnect stops here:
Change:
import { Schemas } from 'vs/base/common/network'; import { OperatingSystem } from 'vs/base/common/platform'; import { URI } from 'vs/base/common/uri'; <del> import { ITextResourceEditorInput } from 'vs/platform/editor/common/editor'; </del> <ins> import { ITextEditorSelection, ITextResourceEditorInput } from 'vs/platform/editor/common/editor'; </ins> import { IFileService, IFileStatWithPartialMetadata } from 'vs/platform/files/common/files'; import { FileService } from 'vs/platform/files/common/fileService'; import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock';

Discussion:
My project is under https://user- Reproduce steps: vscode open a folder which file path contains space, for example: an integrated terminal the path link Versions:
nice I can repro with the space in the name, thanks for following up
I can still repro with Windows.
I looked into this, and it will be tricky because we currently use space as one of the characters which indicates the end of a path. One idea would be to check if such a link exists (using our original regex) and if not, use regex on the subsequent sequence - then concatenating the two results for First result would be doesn't exist process exists
https://user- Look the above video, I have several questions. path is not a existed path in the disk, but also clickable. I click the , it open a file which is not why the whole string is recogonized to a path? the real path is:
this is actually about when the parents of the link have a space, it's expected currently that an absolute path with a space won't work.
is it expected that a local link with a space somewhere within the path is not detected? that is the case currently - verified via adding a test to
absolute paths (eg. ) won't work because of Relative paths without spaces with absolute ancestors that have spaces (eg. inside ) should work but don't in some cases.
When verifying, make sure to test both on a Windows machine and a non-Windows machine.
Doesn't work for me on a Mac, I guess thats probably because I still haven't got the fix in the latest insider build.
are you on ?
Worked for me on macOS. Don't have a Windows machine to try this out so someone else will need to verify on Windows.
Yes, I'm on that same version. Here's what it looks like for me on a Mac with spaces !
still not work in latest version: https://user-
For absolute paths, see I wasn't able to get to work, though. It'd open the file, but place the cursor at the beginning.
please provide some more details, it works for me: !
This is the behaviour with version 1.70.0 After ctrl+clik a popup appears at the top of the screen and I have to hit enter to go to the suggested file:line.
I can repro that on Windows, Remote-WSL and macOS.

The file must not be in the root directory for this to happen. !
let's track that problem in and as this issue is becoming quite unwieldy/unfocused.
created to track the problem related to quotes you're seeing. Could you re-verify this if all good outside of these 3 issues I created? It's difficult to manage this issue as it's so general.
Change:
.monaco-hover .monaco-tokenized-source { white-space: pre-wrap; <del> word-break: break-all; </del> } .monaco-hover .hover-row.status-bar {

Discussion:
Version: 1.48.2 (user setup) Commit: Date: 2020-08-25T10:13:11.295Z Electron: 7.3.2 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. ! Breadcrumb for myself, in case a repro is required: I was reducing material-ui for abug.
FYI
Thanks for your great project, I would like to try to fix this issue. Before I begin to do, I want to have a discussion there. my idea for fixing this issue is that: I will check the current string(in this issuse is '=') whether hit the scopes(produced by vscode-textmate) such as "" defined in file, then apply different css style not allow new line for operator. But the problem is that we can't get scopes info, because we don't allow use tokenize method but can ony use tokenize2 method (because of performance reason): So in my opinion, this idea seems not the right fix for the issuse, right ? If so, how about just detect whether the current string is typescript operator, such as through typescript api(I am not sure this api is really exist) ?
Doing a fix specific about the token scope list would make this change tied up to TextMate, while the editor itself supports another tokenization engine named Monarch, which does not produce scope lists. What I find interesting is that our wrapping computer does a lot better in this case: ! Even when using the DOM wrapping points computed by the browser via , that symbol is not broken: ! So I believe there might be something off in the CSS of the hover widget that is causing the browser to break in the middle of . When computing wrapping points via the browser, is the CSS we use for . Perhaps the hover widget is using something else that would cause such behavior?
Thanks for offering these information. It seems I misunderstood this issue before. the message "TypeScript QuickInfo should not wrap in the middle of an operator", make me think I need only handle the operator not other single word, this make things more complicated. So I just remove relevant css as you suggested
I did a quick blame on the CSS and it looks like it was introduced via
Change:
// Convert spaces to allow the non-breaking space char (ascii 160) .replace(/ /g, `[${'u00A0'} ]`); <del> return new RegExp(`(${suffixClause})`, 'g'); }); </del> <ins> return new RegExp(`(${suffixClause})`, eolOnly ? undefined : 'g'); } </ins> /** * Removes the optional link suffix which contains line and column information.

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work!

It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged