jiebi/CodeConvo huggingface dataset:
Change:
})); this._register(this._inlineChatService.onDidChangeProviders(() => this._onEnablementOrModelChanged())); this._register(this._editor.onDidChangeModel(() => this._onEnablementOrModelChanged())); <ins> this._onEnablementOrModelChanged(); </ins> } private _onEnablementOrModelChanged(): void {

Discussion:
Testing a New Text File and add some empty lines. around the file. No gutter sparkle icons shown. ! the file Still no gutter sparkle icons. Sparkle icons show up after some text is entered. If you remove the text in that session with the file, the sparkle icons are displayed but if you close and reopen the empty file, no sparkle icons. !

Testing a file and see gutter sparkle icon displayed on empty line. either View: Split in Group or View: Toggle Split in Group cursor to a line where there gutter sparkle icon should be displayed. No gutter sparkle icon is visible. Split in Group again and gutter sparkle icon is displayed as expected

Testing a file and test that gutter sparkle icon appears when the cursor is on an empty line. the file to the side or bottom of the editor to start a new editor group. the cursor to an empty line. No gutter sparkle icon is visiable. Note that moving a second editor into the new editor group correctly displays the sparkle icon. Also going back to the original first file in the editor group now shows the sparkle icon.
Change:
"compilerOptions": { "module": "amd", "moduleResolution": "node", <del> "noImplicitAny": true, </del> "experimentalDecorators": true, "noImplicitReturns": true, "noUnusedLocals": true, <del> "noImplicitThis": true, "alwaysStrict": true, </del> "strict": true, "forceConsistentCasingInFileNames": true, "baseUrl": ".",

Discussion:
has "strict" set to true, which "noImplicitAny", "noImplicitThis", and "alwaysStrict" but they are set to true explicitly anyway in the same file which is just redundant.
Change:
}, editor); this._disposables.add(this._diffEditor); this._diffEditor.setModel({ original: this._session.textModel0, modified: editor.getModel() }); <ins> this._diffEditor.updateOptions({ lineDecorationsWidth: editor.getLayoutInfo().decorationsWidth }); </ins> const doStyle = () => { const theme = themeService.getColorTheme();

Discussion:
There is an alignment difference between the initial editor and the inline preview editor.
How do you get that inline diff to appear? Is there a setting for that?
You may enable the inline diff by clicking on the arrow icon which opens a menu, where you can select
Change:
return candidate; } <del> function incrementFileName(name: string, isFolder: boolean): string { </del> <ins> export function incrementFileName(name: string, isFolder: boolean): string { const separators = '[.-_]'; </ins> // file.1.txt=>file.2.txt <del> if (!isFolder && name.match(/(.*.)(d+)(..*)$/)) { return name.replace(/(.*.)(d+)(..*)$/, (match, g1?, g2?, g3?) => { return g1 + (parseInt(g2) + 1) + g3; }); </del> <ins> let suffixFileRegex = RegExp('(.*' + separators + ')(d+)(..*)$'); if (!isFolder && name.match(suffixFileRegex)) { return name.replace(suffixFileRegex, (match, g1?, g2?, g3?) => { return g1 + strings.pad(parseInt(g2) + 1, g2.length) + g3; }); } // 1.file.txt=>2.file.txt let prefixFileRegex = RegExp('(d+)(' + separators + '.*)(..*)$'); if (!isFolder && name.match(prefixFileRegex)) { return name.replace(prefixFileRegex, (match, g1?, g2?, g3?) => { return strings.pad(parseInt(g1) + 1, g1.length) + g2 + g3; }); </ins> } // file.txt=>file.1.txt

Discussion:
VSCode Version: 1.22.0-insider OS Version: macOS 10.13.3 Currently VSCode increments suffix when copying a file. Copying makes . But there are cases when the is specified in prefix not suffix, for instance when dealing with migrations we have files like , copying this results in creating a file named which is not the desired result. It would be great if VSCode could detect and increment the prefix if needed. It also requires minimal changes to method to add the functionality.
Testing something like should be enough to handle the case.
If there is a simple PR to handle this case we would be happy to merge it in
Great, I'll make the changes and create PR
This caused which we should take for May
Change:
} } }); <del> quickpick.onDidChangeActive(themes => selectTheme(themes[0]?.theme, false)); </del> <ins> quickpick.onDidChangeActive(themes => { if (result === undefined) { selectTheme(themes[0]?.theme, false); } }); </ins> quickpick.onDidHide(() => { if (result === undefined) {

Discussion:
Pre-req: Settings Sync on brand new empty profile a theme Settings sync asks this strange question: ! Additionally: this dialog Theme is still applied but not installed
I tried and can't repro. Are there any specific steps you followed?
were there specific steps to repro this?
I can verify that cancelling the dialog no longer leaves the theme applied, thanks I can still reproduce the main issue though. Why would I not want to synchronize the theme I just picked for my brand new profile, given the profile is being synced?
I think is using the general extension install command that will ask user to sync or not before installing. If it is in core, one can use the API directly to install.
I think we still want an install confirmation dialog, but I agree that there should be no question about syncing.
Change:
"scope": [ "entity.name.function", "support.function", <del> "support.constant.handlebars" </del> <ins> "support.constant.handlebars", "source.powershell variable.other.member" </ins> ], "settings": { "foreground": "#DCDCAA"

Discussion:
One of the first things I noticed when switching from Sublime Text 3 to VSCode for PowerShell code is VSCode doesn't change the syntax highlighting color for methods. In Sublime Text 3 and PowerShell IDE, methods use a separate color. VSCode method color is the same color as variables. Below, both editors are using the same TextMate color scheme: Sublime Text 3: ! VSCode: ! I am hoping someone with more experience in VSCode might have a temporary workaround in until there's an official fix for this. Wishful thinking.. but something like: below: VSCode Version: 1.36.1 (user setup) OS Version: (Windows 10 64bit) Steps to Reproduce: Open PowerShell code that has PowerShell methods
You can use the "Developer: Inspect TM scope" to get the correct scope for your setting: <img width="388" alt="textmatescope" src="https://user-"You could also make your own theme that does colors the way you want.
We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the . Just in case, in a few simple steps you can get started . See also our guidelines. Happy Coding!
I'll fix it for the default themes.
Thank you for the tip to use "Developer: Inspect TM scope". This was extremely helpful.
Change:
if (newActiveItem) { quickpick.activeItems = [newActiveItem as ThemeItem]; } <del> }); </del> <ins> })); </ins> this.trigger(value); quickpick.show(); <ins> }).finally(() => { disposables.dispose(); </ins> }); }

Discussion:
Quick pickers are itself disposables, as well as the events they provide. Noticed a few leaks around picker instances and/or events: //cc
There's already a that is called when the picker hides. Isn't that good enough?
see the various events (those beginning with ) and how they are not getting disposed.
But they are going to an emitter that is owned by the quickpick. Disposing the quickpick is also disposed all its emitters. There's no real leak here.
my understanding is that an that gets disposed (when you dispose the quick picker) does not dispose the -functions it had returned, i.e. this code is not running: But maybe or can also chime in.
Yes - an emitter doesn't dispose its listeners. you basically rely on GC'ing here and I am uncertain if that actually works (e.g some disposables are tracked centrally for later blaming). I understand your motives but we generally dispose all the things
Change:
const insertCommandKeybinding = keybindingService.lookupKeybinding(TerminalChatCommandId.InsertCommand)?.getAriaLabel(); const makeRequestKeybinding = keybindingService.lookupKeybinding(TerminalChatCommandId.MakeRequest)?.getAriaLabel(); const startChatKeybinding = keybindingService.lookupKeybinding(TerminalChatCommandId.Start)?.getAriaLabel(); <del> const focusResponseKeybinding = keybindingService.lookupKeybinding(TerminalChatCommandId.FocusResponse)?.getAriaLabel(); const focusInputKeybinding = keybindingService.lookupKeybinding(TerminalChatCommandId.FocusInput)?.getAriaLabel(); </del> <ins> const focusResponseKeybinding = keybindingService.lookupKeybinding('chat.action.focus')?.getAriaLabel(); const focusInputKeybinding = keybindingService.lookupKeybinding('workbench.action.chat.focusInput')?.getAriaLabel(); </ins> content.push(localize('inlineChat.overview', "Inline chat occurs within a terminal. It is useful for suggesting terminal commands. Keep in mind that AI generated code may be incorrect.")); content.push(localize('inlineChat.access', "It can be activated using the command: Terminal: Start Chat ({0}), which will focus the input box.", startChatKeybinding)); content.push(makeRequestKeybinding ? localize('inlineChat.input', "The input box is where the user can type a request and can make the request ({0}). The widget will be closed and all content will be discarded when the Escape key is pressed and the terminal will regain focus.", makeRequestKeybinding) : localize('inlineChat.inputNoKb', "The input box is where the user can type a request and can make the request by tabbing to the Make Request button, which is not currently triggerable via keybindings. The widget will be closed and all content will be discarded when the Escape key is pressed and the terminal will regain focus."));

Discussion:
Originally posted by in
this is working AFAICT
On Windows, have to use Ctrl+Up to both go to the list and to go back down to the inputbox. after I focus the list, when I press Up again, it goes back in the input history and changes the inputbox, instead of moving up the list. !
Only tested on mac. Strange that they're different. does that reproduce in the panel chat?
No. It only occurs in terminal chat
Change:
this.onScreenReaderModeChange(); } })); <ins> CommandsRegistry.registerCommand({ id: 'showEditorScreenReaderNotification', handler: () => this.showScreenReaderNotification() }); </ins> this.updateScreenReaderModeElement(this._accessibilityService.isScreenReaderOptimized()); } <ins> private showScreenReaderNotification(): void { this.screenReaderNotification = this.notificationService.prompt( Severity.Info, localize('screenReaderDetectedExplanation.question', "Are you using a screen reader to operate VS Code?"), [{ label: localize('screenReaderDetectedExplanation.answerYes', "Yes"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'on', ConfigurationTarget.USER); } }, { label: localize('screenReaderDetectedExplanation.answerNo', "No"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'off', ConfigurationTarget.USER); } }], { sticky: true, priority: NotificationPriority.URGENT } ); Event.once(this.screenReaderNotification.onDidClose)(() => this.screenReaderNotification = null); } </ins> private updateScreenReaderModeElement(visible: boolean): void { if (visible) { if (!this.screenReaderModeElement.value) {

Discussion:
Type: <bBug</bRestarted Insiders for an update and Screen Reader mode is suddenly on, including audio cues while typing. I have no idea how to disable it, as the status bar icon is clickable (changes color), but doesn't do anything. (Edit: I eventually found command, but I don't see any logs that I used that command before) cc who recommended as assignee. ! VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-24T05:35:10.309Z) OS version: Darwin x64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
not aware of any changes on your end, so i'm just reverting the only relevant PR
Just launched a fresh Insiders and got this notification: ! I do see it detecting a11y for me in telemetry events …` Version: , 2023-10-25T05:37:06.169Z (9 hrs ago)
Indeed then, it seems an issue with detection , not sure why this would be showing otherwise as nothing's changed on my side.
Or something you're running
No changes have been made in the runtime with respect to a11y detection, on macOS the runtime can enter a11y mode in the following 2 scenarios, 1) Setting attribute on the application which is usually done by screen readers (VoiceOver) 2) Setting attribute on the applications which is usually done by third party window managers are you using any custom window tiling managers ? List under can give a hint
I do run window managers, yes. So, I guess I'll close this for now as it might have been an update, like Bartender 5.
Change:
this._applyLayout(); <del> this._mouseDownListener = dom.addStandardDisposableListener(this._canvas.domNode, 'mousedown', (e) => { </del> <ins> this._mouseDownListener = dom.addStandardDisposableListener(this._domNode.domNode, 'mousedown', (e) => { </ins> e.preventDefault(); const renderMinimap = this._options.renderMinimap;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.36-Insider OS Version: Windows 10 Steps to Reproduce: click into minimap <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
You can click and drag the highlighted area, but you can't click in a non-highlighted area and have it move to that section of the code. I disabled the other extensions, reloaded the app and closed it out and re-opened it again. Still no go.
The same issue. Dragging the highlighted area on the minimap works. Click outside the highlighted area in order to move to that area doesn't work.
Just to add more information, it is also happening on VSCode Linux. Version: 1.36.0-insider Commit: Date: 2019-06-25T05:17:18.032Z Electron: 4.2.5 Chrome: 69.0.3497.128 10.11.0 V8: 6.9.427.31-electron.0 OS: Linux x64 4.15.0-52-generic
I'm copying my info from the closed report at the top, as it's also happening on macOS (therefor across the board, it seems): Issue Type: <bBug</bSince this build it is no longer possible to click on the minimap to jump to a position in code. Instead one is forced to drag the view-highlight in the minimap.

VS Code version: Code - Insiders 1.36.0-insider (, 2019-06-21T05:18:36.348Z) OS version: Darwin x64 18.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ vscode-intelephense-client1.0.14 vscode-tailwindcss0.2.0 npm-intellisense1.3.0 laravel-blade1.1.2 vscode-markdownlint0.28.0 vscode-eslint1.9.0 EditorConfig0.13.0 vscode-npm-script0.3.7 LogFileHighlighter2.5.0 file-icons1.0.17 auto-close-tag0.5.6 gc-excelviewer2.1.32 todo-tree0.0.135 phpcs1.0.5 path-autocomplete1.13.3 sftp1.12.7 tailwind-sass-syntax1.1.1 dotenv1.0.1 vscode-duplicate1.2.1 atom-keybindings3.0.6 vetur0.21.0 code-settings-sync3.2.9 vscode-wakatime2.1.2 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Change:
} } <del> private safeParseJson(text: string | undefined, defaultObject: any) { try { return text ? JSON.parse(text) || defaultObject : defaultObject; } catch (e) { return defaultObject; } } </del> async openReporter(data: IssueReporterData): Promise<void> { if (!this.issueReporterWindow) { this.issueReporterParentWindow = BrowserWindow.getFocusedWindow();

Discussion:
This is a follow up from I would suggest to not use the storage service for process explorer state but . That is the same service we also use to store window state for workbench windows. Using storage service from the main process requires you to await the event because unlike state service, the storage service is not ready when you use it: State service is always available and can be used as a drop-in replacement. Here is where its used for windows and the key we use is , so maybe it should be .
Change:
private internalDispose() { this.disposables.forEach(d => d.dispose()); <del> this.disposables = []; </del> <ins> this.disposables.clear(); </ins> } <del> override dispose() { this.lateDisposables.forEach(d => d.dispose()); return super.dispose(); </del> <ins> public sessionStopped() { this.stoppedEmitter.fire(); </ins> } detectPattern(s: string): boolean {

Discussion:
I'm trying to use the configuration from website, but I'm facing a problem with the third option. I would like to use like these: and . But I can't find a way to achieve this with : Is it something possible? Thanks a lot
That launch config works for me and does what's expected. Note that the "serverReadyAction" in the latter config does not call the " debug client-side" launch config. For that you would want to use the and put in " debug client-side" for the .
Yes, I agree with you, both configurations are working as expected. I wasn't very clear in my first message, I will try to explain better. On my NextJs project, I can have the following configurations: The first one start the project and enables debugging on server side, the second one open chrome and enables debugging on client side. If I put on the second configuration, it will work just fine: What I want, is using the third configurations only to : start the project, enable debugging on server/client side and open chrome with my . Is it possible to achieve something like this ? I can't find any option in that case to make my working.
serverReadyAction doesn't accept additional configuration properties to pass to the launch config. The reason for this is mostly that intellisense doesn't work in that action (under the hood it's provided by a different extension) so writing configuration in the nested object is hard. The way to do this is define the separate launch config and reference it. Copying your original configuration set:
Your configuration plus two small additions almost give the result I'm looking for! I still have too issues with this: If I kill the (by clicking on the icon), is not automatically killed dispite the option. When I start , is automatically started, but I can see both elements here: !. Is it possible to hide the last one (wich should be automatically killed when is stopped)? I clearly saw that you explained to me why it was not possible to do this (use on a ) in a single configuration, but is there a "hacky" way the achieve my main goal? Or is something planned in the futur? Or maybe there is a way to fix my remaining concerns with the current configuration?

No, this is not possible and is not something we'd do, since you would not be able to control the debug session in that case. That's a bug, will put in a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
.scm-view .monaco-list-row .history-item > .label-container > .label > .codicon { font-size: 14px; <del> color: inherit; </del> <ins> color: inherit !important; </ins> padding: 2px; } .scm-view .monaco-list-row .history-item > .label-container > .label > .codicon.codicon-git-branch { font-size: 12px; <del> color: inherit; </del> padding: 3px; }

Discussion:
Testing There is a second branch on the same commit, and the icon is dark when selected in light+ theme ! !
Great catch! This should look like the rest of the workbench badges: !
Change:
this._body = dom.$('.body'); <del> this._scrollbar = new DomScrollableElement(this._body, {}); </del> <ins> this._scrollbar = new DomScrollableElement(this._body, { alwaysConsumeMouseWheel: true, }); </ins> dom.append(this.domNode, this._scrollbar.getDomNode()); this._disposables.add(this._scrollbar);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version:1.68.1 OS Version:windows 10 Steps to Reproduce: the cursor is in parentheses, press ctrl+shift+space. the popup panel to top or end. ! And is there any way to scroll the hints popup panel with the keyboard? When using the up and down keys, it only moves the cursor in editor.
Also seeing this for the suggest details. Looks similar to
Change:
export interface ICompound { name: string; <ins> stopAll?: boolean; </ins> preLaunchTask?: string | TaskIdentifier; configurations: (string | { name: string, folder: string })[]; presentation?: IConfigPresentation;

Discussion:
Ever since I started using the new JS debugger, when running our top level target and then manually closing the code-oss window, the and targets remain: ! Eventually, maybe 1 minute later, the goes away, but the other one stays, I always have to manually disconnect from it. ! cc
This is because is set for the shared process and extension host, which allows them to reconnect when vscode is reloaded. Eventually js-debug in extension host gives up, but the shared process is using the previous Node debugger which doesn't give up. Both these are working as designed, this is kind of a downside of the compound launch configs in that there's no "compound stop".
Yeah, would actually LOVE a compound stop. Could this be a feature of compounds, & Meaning, if something like was set in the compound, all targets would share the same action, and I would see no actions.
We could add a attribute to the compound, however how would that work? Clicking stop on any of the compound sessions would send stop to all sessions? And it would never be rendered as dicsonnect?
Maybe compound launch configs could have a pseudo-root, which has a "stop" action that affects all individual configs? ` The compound config could have an option whether sessions can be stopped individually, or whether stopping one session is treated as stopping the whole set of configuration.
ok makes somewhat sense, the flaw of my proposel is that once compound starts 4 sessions those sessions are not related in any way. So adding a pseudo root might be smart. The pseudo root would not be rendered, and the pseudo root would remember the attribute. Here are code pointers for a PR. We should add the attribute and to the schema . Code pointer for the debug session to add the pseudo root stopAll smartness
I like both options.
This bug has been fixed in to the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command pallette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Please let's have the bot not do this for ourselves.
BTW, the bot's wording sounds wrong: in to the latest...
Much better, and I this attribute to our compound config. But the behavior partly confuses me and I opened