jiebi/CodeConvo huggingface dataset:
Change:
} async runWithContext(accessor: ServicesAccessor, context: INotebookActionContext): Promise<void> { <del> const newCell = context.notebookEditor.insertNotebookCell(context.cell, this.kind, this.direction, undefined, true); if (newCell) { context.notebookEditor.focusNotebookCell(newCell, 'editor'); } </del> <ins> context.notebookEditor.insertNotebookCell(context.cell, this.kind, this.direction, undefined, true); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.
Change:
for (const label of cwds) { items.push({ label }); } items = items.reverse(); <ins> // Gather previous session history const history = this._instantiationService.invokeFunction(getDirectoryHistory); const previousSessionItems: IQuickPickItem[] = []; // Only add previous session item if it's not in this session for (const [label] of history.entries) { if (!cwds.includes(label)) { previousSessionItems.push({ label, buttons: [removeFromCommandHistoryButton] }); } } if (previousSessionItems.length > 0) { items.push( { type: 'separator', label: 'previous sessions' }, ...previousSessionItems ); } </ins> } if (items.length === 0) { return;

Discussion:
We should not sync this Should this be per terminal instance? No We should persist similar to recent commands as well Should persisted entries work across different shells? Probably We should invalidate entries similar to commands Let's support removing entries, using a icon that shows only on active and hovered item Let's not use the x for failed, we can improve visualizing errors later on
Change:
} } <ins> export class UnhideAllTestsAction extends Action2 { constructor() { super({ id: TestCommandId.UnhideAllTestsAction, title: localize('unhideAllTests', 'Unhide All Tests'), }); } public override run(accessor: ServicesAccessor) { const service = accessor.get(ITestService); service.excluded.clear(); return Promise.resolve(); } } </ins> const testItemInlineAndInContext = (order: ActionOrder, when?: ContextKeyExpression) => [ { id: MenuId.TestItem,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I would like to run all the tests from the task. However, if there is a hidden test (e.g. by mistake), that test will not be executed. Is it possible to make work from task? Or if there is a command that ignores the hidden ones and runs all tests, that would be fine.
It looks like expects some arguments but you're looking for a command that unhides all instead.
Code pointer for the existing action:
Should there be a new command to unhide all tests say testing.hideAll or a task to run all tasks including hidden tests - testing.runAllIncludingHidden?
Yes! please.
Verified it unhides all hidden tests.
Change:
import 'vs/css!./media/quickInput'; import { localize } from 'vs/nls'; import { DisposableStore } from 'vs/base/common/lifecycle'; <ins> import { IQuickInputButton } from 'vs/platform/quickinput/common/quickInput'; import { IAction } from 'vs/base/common/actions'; </ins> const iconPathToClass: Record<string, string> = {}; const iconClassGenerator = new IdGenerator('quick-input-button-icon-'); <del> export function getIconClass(iconPath: { dark: URI; light?: URI } | undefined): string | undefined { </del> <ins> function getIconClass(iconPath: { dark: URI; light?: URI } | undefined): string | undefined { </ins> if (!iconPath) { return undefined; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Ubuntu 23.04 Steps to Reproduce: the command palette using ctrl+shift+p (or cmd+shift+p on mac) the escape key, closing the command palette 7 times that instance count has increased by 7, instance count has increased by 211, instance count has increased by 240 and instance count has increased by 302. The total disposable count has increased by 1137 from to . One class that has increased the most in the above test was . Looking where relates to the quick input I found this code in where actions are created: Perhaps it could be this code that causes the to be created. It seems the actions aren't registered/disposed like other disposables.
Thanks for reporting this! I think I've cleaned up the ... now we use the simpler non-disposable kind... I'll chip away at the rest over time.
Thanks a lot, I see now: No more Actions are leaked (211 -0) Disposable stores are 211 less leaked (240 -29) Emitter are 211 less leaked (302 -91) MutableDisposable instance count still increases (7 -7) I'll try to find more information for the MutableDisposables and DisposableStores where exactly they are created! Thanks again! Edit: The MutableDisposables are created in : They are kept alive by a 200ms timeout and disposed after 200ms so it's no problem: Just the test executing too fast / finishing before the MutableDisposables were disposed. :)
Change:
} } ] <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
One of the first things I noticed when switching from Sublime Text 3 to VSCode for PowerShell code is VSCode doesn't change the syntax highlighting color for methods. In Sublime Text 3 and PowerShell IDE, methods use a separate color. VSCode method color is the same color as variables. Below, both editors are using the same TextMate color scheme: Sublime Text 3: ! VSCode: ! I am hoping someone with more experience in VSCode might have a temporary workaround in until there's an official fix for this. Wishful thinking.. but something like: below: VSCode Version: 1.36.1 (user setup) OS Version: (Windows 10 64bit) Steps to Reproduce: Open PowerShell code that has PowerShell methods
You can use the "Developer: Inspect TM scope" to get the correct scope for your setting: <img width="388" alt="textmatescope" src="https://user-"You could also make your own theme that does colors the way you want.
We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the . Just in case, in a few simple steps you can get started . See also our guidelines. Happy Coding!
I'll fix it for the default themes.
Thank you for the tip to use "Developer: Inspect TM scope". This was extremely helpful.
Change:
return await this.run(Operation.Ignore, async () => { const ignoreFile = `${this.repository.root}${path.sep}.gitignore`; const textToAppend = files <del> .map(uri => relativePath(this.repository.root, uri.fsPath).replace(//g, '/')) </del> <ins> .map(uri => relativePath(this.repository.root, uri.fsPath) .replace(/|[/g, match => match === '' ? '/' : `${match}`)) </ins> .join('n'); const document = await new Promise(c => fs.exists(ignoreFile, c))

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.3 OS Version: Windows 11 Steps to Reproduce: a git repository a file with brackets in the name, e.g. the file in the git tab and add it to the file Desired behavior: The filename is to the such that the file is ignored Observed behavior: The file name is to but it is not ignored. This is because the syntax of does not interpret brackets literally. To ignore a filename that includes brackets requires escaping brackets with backslashes. gitignore after step 3: for desired effect should be: Proposed fix: Pre-process file names to to escape special characters.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Change:
const lineAndColumnRegexClauses = [ // foo:339 // foo:339:12 <ins> // foo:339.12 </ins> // foo 339 // foo 339:12                             [#140780] <ins> // foo 339.12 </ins> // "foo",339 // "foo",339:12 <del> `(?::| |['"],)${r()}(:${c()})?` + eolSuffix, </del> <ins> // "foo",339.12 `(?::| |['"],)${r()}([:.]${c()})?` + eolSuffix, </ins> // The quotes below are optional          [#171652] // "foo", line 339                        [#40468] // "foo", line 339, col 12

Discussion:
The : This doesn't currently work in VSCode. It does support a very wide range of formats and I don't recall ever seeing this format before (even from GNU tools) so I suspect nobody else uses it. Nonetheless it's easy to add support in VSCode. See
Doesn't seem to work, see <img width="825" alt="Screenshot 2023-08-29 at 14 41 05" src=""
The PR intentionally left that out: But it should be easy to add so will leave this open.
Change:
this._hidden = value; } <del> protected _saneDescription?: string; </del> <ins> private _saneDescription?: string; </ins> get saneDescription() { return this._saneDescription; }

Discussion:
So that we can add full path to Quick Search
Verification: Open from the command palette search for something Notice the folder paths next to the names of the files - that's the description! <img width="623" alt="image" src=""
Change:
font-style: italic; } <ins> .settings-editor > .settings-body > .settings-tree-container .setting-item .setting-item-title .setting-item-overrides a.modified-scope { text-decoration: underline; cursor: pointer; } </ins> .settings-editor > .settings-body > .settings-tree-container .setting-item .setting-item-label { margin-right: 7px; }

Discussion:
Issue Type: <bFeature Request</bTesting Just a thought: When I see "Modified in: Workspace" I might want to go there and check. I'd keep font and color as they are and add an underline and pointer cursor to "Workspace" on hover. VS Code version: Code - Insiders 1.27.0-insider (, 2018-08-29T05:12:15.247Z) OS version: Darwin x64 17.7.0 <!-- generated by issue reporter --
Good idea!
I would take a PR for this "Modified in: Workspace" - the word Workspace is underlined When clicked, it switches to the Workspace scope, and copies the setting key into the search bar, so the view is filtered to just that one setting
I'm interested in looking into this if that is alright.
Change:
*/ uri: string; /** <del> * The format options </del> <ins> * The sort options </ins> */ options: SortOptions; }

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-22T05:24:32.270Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
This part of in-preparation release notes will also need updating:
Change:
import { ICommandService } from 'vs/platform/commands/common/commands'; import { CoreEditingCommands } from 'vs/editor/browser/controller/coreCommands'; import { getErrorMessage } from 'vs/base/common/errors'; <ins> import { EditorOverride } from 'vs/platform/editor/common/editor'; </ins> const emptyEditableSettingsContent = '{n}';

Discussion:
Steps to Reproduce: workbench editor associations to open *.json with a custom editor (e.g. HEX) to change this setting later = you cannot because in order to edit the values, you need to go to the JSON but it will open the custom editor always: ! Imho we should have a way to prevent the override from happening fro built in files such as settings. Only workaround is to entirely reset the setting. //cc
I've made a PR to fix this issue. I'm not sure why it is showing so many changes, it might be due to it being based off of the openWith PR that we had open before it got merged.
Change:
appendPlaceholder(value: string | ((snippet: SnippetString) => any), number?: number): SnippetString; /** <ins> * Builder-function that appends a choice (`${1|a,b,c}`) to * the [`value`](#SnippetString.value) of this snippet string. * * @param values The values for choices - the array of strings * @param number The number of this tabstop, defaults to an auto-increment * value starting at 1. * @return This snippet string. */ appendChoice(values: string[], number?: number): SnippetString; /** </ins> * Builder-function that appends a variable (`${VAR}`) to * the [`value`](#SnippetString.value) of this snippet string. *

Discussion:
In the snippet docs there's syntax for adding choices for placeholders: Currently the class has methods for , , etc. but there isn't an option for choices. We can build these manually, but it'd be better if we could stick to a nice API.
Also seems like the escape method is private, making it more difficult to do this manually without duplicating the implementation.
Actually, is escaped so it seems like we can't do this at all without building the whole string ourselves..
Well, you can do
That seems to have worked, thanks! I did have to copy your escape function and add to it though!
Hello,is this issue solved ? I am new on this repo and looking for good first issues to solve, this issue looks good for my purpose. Can anyone please guide me about solving this please?
This issue would be closed if it's solved. So, "yes" it up for a grab. This is the code pointer entry point:
Change:
// Add a hover tab loop if the hover has at least one element with a valid tabIndex const firstContainerFocusElement = this._hover.containerDomNode; <del> const lastContainerFocusElement = this.findLastFocusableChild(this._hover.contentsDomNode); </del> <ins> const lastContainerFocusElement = this.findLastFocusableChild(this._hover.containerDomNode); </ins> if (lastContainerFocusElement) { const beforeContainerFocusElement = dom.prepend(this._hoverContainer, $('div')); const afterContainerFocusElement = dom.append(this._hoverContainer, $('div'));

Discussion:
workspace trust workspace untrusted settings the hover for the workspace trust indicator and focus it to the action and press enter :bug: The action doesn't run pressing tab :bug: Focus leaves the hover and the hover stays open
Change:
* Makes sure that visible editors are always shown in the explorer even if they are filtered out by settings. */ export class FilesFilter implements ITreeFilter<ExplorerItem, FuzzyScore> { <del> private hiddenExpressionPerRoot: Map<string, CachedParsedExpression>; private uriVisibilityMap = new Map<URI, boolean>(); </del> <ins> private hiddenExpressionPerRoot = new Map<string, CachedParsedExpression>(); </ins> private editorsAffectingFilter = new Set<IEditorInput>(); private _onDidChange = new Emitter<void>(); private toDispose: IDisposable[] = [];

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --Related Issues: <!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Linux x64 5.8.0-44-generic Steps to Reproduce: a root folder (files-exclude-sample) that folder create two nested folders (child1, child2) root folder (files-exclude-sample), create a workspace definition file (files-exclude-) root folder (files-exclude-sample), create a .vscode folder .vscode folder create a file to previous steps, just clone this GitHub repo: VSCode, open the workspace (files-exclude-) looks ok. You have tree root folders (files-exclude-sample, child1 and child2) ! you expand all three folder you can see something like ! specified in root folder , child1 and child2 are excluded from child1 folder child1 folder is collapsed (not removed from explorer tree) and it appears inside root folder (files-exclude-sample) folder ! expected behavior is that child1 is not collapsed and it does not appear inside root folder <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
the owner of the file explorer is
I acknowledge this issue. MR workspace support with when one root folder is a subfolder of another root folder has some issues. If somebody is passionate about fixing this let me know and I can provide pointers
Created fixing this
Thanks to a great pr by this is now fixed
Change:
collapseAll(elements?: any[], recursive?: boolean): WinJS.Promise; /** <ins> * Collapses several elements. * Collapses all elements at the greatest tree depth that has expanded elements. * The returned promise returns a boolean for whether the elements were collapsed or not. */ collapseDeepestExpandedLevel(): WinJS.Promise; /** </ins> * Toggles an element's expansion state. */ toggleExpansion(element: any, recursive?: boolean): WinJS.Promise;

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
} override getName() { <del> if (this._initTitle) { return this._initTitle; } const p = this.primary.resource!.path; const basename = paths.basename(p); return basename.substr(0, basename.length - paths.extname(p).length); </del> <ins> return this.name; </ins> } override isModified() {

Discussion:
VS Code Version: 1.80.1 OS Version: Win-10 Python extension: v2023.12.0 Steps to Reproduce: an empty file with cell =you will see the interactive window with tab name , ... Please confirm if this is work as designed. I remember it wasn't the case at the beginning of the year. This type of naming causes tremendous confusing when working on more than 2 interactive windows within a Workplace. Please let me know if I should report it to Thanks!
Probably the same error after last update. VS Code Version: 1.80.1 OS Version: Ubuntu 22.04 "jupyter.interactiveWindow.creationMode": "perFile" name of source python file is lost, only tab names 'interactive-1', 'interactive-2'
not intentional, it should still include the python filename in the interactive tab. investigating
Change:
} })); this._disposables.push(dom.addStandardDisposableListener(this._domNode, 'click', e => { <ins> // Make sure that focus / cursor location is not lost when clicking widget icon this._editor.focus(); </ins> // a bit of extra work to make sure the menu // doesn't cover the line-text const { top, height } = dom.getDomNodePagePosition(this._domNode);

Discussion:
Feature Request Type: Move cursor to . Click on the light bulb and apply the codefix. The cursor is gone. It would be nice if it were still at the position it was before the codefix. Ideally, there would be a key I could press to enter the lightbulb-menu so I wouldn't have to use the mouse at all. VS Code version: Code - Insiders 1.20.0-insider (, 2018-02-02T06:17:03.200Z) OS version: Linux x64 4.4.0-83-generic
I'm unable to reproduce this in the VS Code 1.20 main release or in the current insiders. Are you still hitting this?
Yeah, the cursor is gone the moment I click on the light bulb, and then typing does nothing. I'm on the 2018-02-08 release of vscode insiders.
Ok, thanks. Yes I still see this when clicking on the light-bulb. When trigging quick fixes with + the cursor stays in place. Seems like a generic quick fix ui problem
Change:
for (let fileName in fileNames) { let selectors = []; let segments = fileName.toLowerCase().split('.'); <del> if (segments[0]) { selectors.push(`.${escapeCSS(segments[0])}-name-file-icon`); } </del> <ins> selectors.push(`.${escapeCSS(fileName.toLowerCase())}-name-file-icon`); </ins> for (let i = 1; i < segments.length; i++) { selectors.push(`.${escapeCSS(segments.slice(i).join('.'))}-ext-file-icon`); }

Discussion:
VSCode Version: version 1.8.1 OS Version: Windows 10 Steps to Reproduce: an icon theme. a filename that has no extension. e.g. license a file called and it will work as expected a file called and instead of the expected icon, you will see the icon. It seems that filename associations are created by taking the extension of the file as a separated style, thus providing side-effects with without extension. In my opinion, filenames shouldn't have to take into account the extension as a separate css class. The whole file name should be css parsed and used as a class name instead. This would avoid the described issue. See
Another effect is that filenames starting with a dot, like '.gitignore' are being treated as file extensions. This usually works but I have detected what seems to be another bug. In the docs it says: For what I've seen this is not the case and takes precedence in front a : ! As you can see in the image, is being matched as a extension and if a language id is provided (json in this case), the language id prevails against what the docs claims.
I've submitted a PR for this