jiebi/CodeConvo huggingface dataset:
Change:
this.instantiationService.createInstance(ReloadAction), this.instantiationService.createInstance(ExtensionStatusLabelAction), this.instantiationService.createInstance(ActionWithDropDownAction, 'extensions.updateActions', '', <del> [[this.instantiationService.createInstance(UpdateAction)], [this.instantiationService.createInstance(SkipUpdateAction)]]), </del> <ins> [[this.instantiationService.createInstance(UpdateAction, true)], [this.instantiationService.createInstance(SkipUpdateAction)]]), </ins> this.instantiationService.createInstance(SetColorThemeAction), this.instantiationService.createInstance(SetFileIconThemeAction), this.instantiationService.createInstance(SetProductIconThemeAction),

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.
Latest version is now shown in the hover. Update button in the extension editor shows the version.
Change:
const supportedLinkFormats: LinkFormatInfo[] = [ { urlFormat: '{0}' }, <del> // { urlFormat: '{0} on line {1}', line: '5' }, // { urlFormat: '{0} on line {1}, column {2}', line: '5', column: '3' }, // { urlFormat: '{0}:line {1}', line: '5' }, // { urlFormat: '{0}:line {1}, column {2}', line: '5', column: '3' }, </del> <ins> { urlFormat: '{0} on line {1}', line: '5' }, { urlFormat: '{0} on line {1}, column {2}', line: '5', column: '3' }, { urlFormat: '{0}:line {1}', line: '5' }, { urlFormat: '{0}:line {1}, column {2}', line: '5', column: '3' }, </ins> { urlFormat: '{0}({1})', line: '5' }, { urlFormat: '{0} ({1})', line: '5' }, { urlFormat: '{0}({1},{2})', line: '5', column: '3' },

Discussion:
Disabled in
In order to fix a VS Code crash caused by a regex catastrophic backtracking case, I changed the unix link link regex (). I had to disable some of the terminal link line/column Unix cases ( in ) as I don't totally understand what's happening. For some reason doesn't seem to work for all the anymore, specifically these ones: See this change which gets 2/4 cases working: Any insights would be great :smiley:
just saw this issue and fix. will have a detailed look in this on weekend, will update you on any findings.
did you get a chance to look at this?
got new machine, i have just started setup. Will update soon.
I tried running test from terminal using , but it seems to be stuck, shows nothing on terminal. Is there any way to run specific test or something i am missing. Thanks
Hmm... I'm sure there is a way as it uses mocha, I'm not sure what it is though as the tests always run so fast for me.
I have updated the tests and ts file, now tests are working fine. Please review. Thanks
Change:
constructor(private repository: Repository) { repository.onDidRunGitStatus(this.onModelChange, this, this.disposables); repository.onDidChangeOperations(this.onOperationsChange, this, this.disposables); <ins> const onEnablementChange = filterEvent(workspace.onDidChangeConfiguration, e => e.affectsConfiguration('git.statusBarSync.enabled')); onEnablementChange(this.updateEnablement, this, this.disposables); </ins> this._onDidChange.fire(); } <ins> private updateEnablement(): void { const isEnabled = workspace.getConfiguration('git').get('statusBarSync.enabled'); if (isEnabled) { this.state = { ... this.state, isEnabled: true }; } else { this.state = { ... this.state, isEnabled: false }; } } </ins> private onOperationsChange(): void { const isSyncRunning = this.repository.operations.isRunning(Operation.Sync) || this.repository.operations.isRunning(Operation.Push) ||

Discussion:
There doesn't appear to be an option to hide the git sync icon that appears in the status bar. It's not really a big deal but it would be nice to hide the git sync icon. Personally, coming from Vim I prefer working with the VCS outside of the editor, yet I would still like to see the current branch that is being worked on. This is why I'd like to hide just the sync button and not hide both git status bar items or disable the git extension entirely.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.561 --<!-- potentialduplicatescomment --
I believe this is resolved via
No, hard to revert that change.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Change:
white-space: nowrap; } <del> .monaco-select-box-dropdown-container > .select-box-dropdown-list-container .monaco-list .monaco-list-row > .option-text-description { display: none; </del> <ins> /* Accepted CSS hiding technique for accessibility reader text  */ /* https://webaim.org/techniques/css/invisiblecontent/ */ .monaco-select-box-dropdown-container > .select-box-dropdown-list-container .monaco-list .monaco-list-row > .visually-hidden { position: absolute; left: -10000px; top: auto; width: 1px; height: 1px; overflow: hidden; </ins> } .monaco-select-box-dropdown-container > .select-box-dropdown-container-width-control {

Discussion:
Voiceover does not read new option details because of describedby issue. May require the new ARIA combo box model.
Any problem with me creating new tags for NVDA and voiceover like there is already a tag for jaws? Accessibility-NVDA Accessibility-Voiceover I will also volunteer to do triage on accessibility issues if I can identify them.
Change:
paths = new Array(originalPaths.length); for (let i = 0; i < originalPaths.length; i++) { if (typeof originalPaths[i] === 'string') { <del> paths[i] = originalPaths[i]; </del> <ins> paths[i] = resolved[i]; </ins> } else { paths[i] = { path: resolved[i],

Discussion:
Type: <bBug</bVSCode Insiders does not recognize the "Command Prompt" profile or any other user defined profiles. I had Cmder set up as well. Now, setting will not recognize "Command Prompt" or my user defined "Cmder" profile. It will report the following error: ! In addition, I do not see either "Command Prompt" or "Cmder" in the "launch terminal" drop down either: ! NOTE: VSCode still opens previous integrated terminal sessions that had Cmder open. I run VS Code Insiders on two machines, one for work & one on my personal machine. I had both open at the same time, one with the latest update to VS Code Insiders, other not. I was able to see "Command Prompt" and "Cmder" on the one not updated & not the other. Once I updated the working one and re-opened, both profiles were missing. VS Code version: Code - Insiders 1.75.0-insider (, 2023-01-03T10:03:31.107Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
I'm having this same issue why was it closed?
At first, I think the issue was considered user error. Now that more people are reporting same issue I'm sure it will get looked into.
More info I installed VS-Code 1.74.2 stable side by side with Insiders. I copied my file into the VS-Code 1.74.2 stable build and the Command Prompt/Cmder options appear just fine and load fine, but the same settings file in VS-Code-Insiders 1.75 it says Cmder and Command Prompt are not valid options and doesn't have them appear. Here is the section that works in 1.74.2 but not in insiders 1.75.

This really hoses my build tools capability "terminal.integrated.defaultProfile.windows": "cmd", "terminal.integrated.profiles.windows": { "PowerShell": { "source": "PowerShell", "icon": "terminal-powershell" }, "Command Prompt": { "path": [ "${env:windir}Sysnative", "${env:windir}System32" ], "args": [], "icon": "terminal-cmd" }, "Git Bash": { "source": "Git Bash" }, "cmd": { "path": [ "${env:windir}Sysnative", "${env:windir}System32" ], "args": ["/k C:cmdervendor"], "icon": "terminal-cmd" } },
I see a warning about invalid value when I set and it's not appearing in the profile dropdown
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
This doesn't seem to work for me: ! Let me know if there are additional steps needed.
I think that's failing because the profile isn't valid ( isn't a real path)
Ah, yea. Kinda a subtle way to show that error, but fixing that worked...
Change:
if (gettingStartedList.itemCount) { this.container.classList.remove('noWalkthroughs'); if (videoList?.itemCount > 0) { <ins> this.container.classList.remove('noVideos'); </ins> reset(rightColumn, videoList?.getDomElement(), gettingStartedList.getDomElement()); } else { <ins> this.container.classList.add('noVideos'); </ins> reset(rightColumn, gettingStartedList.getDomElement()); } } else { this.container.classList.add('noWalkthroughs'); if (videoList?.itemCount > 0) { <ins> this.container.classList.remove('noVideos'); </ins> reset(rightColumn, videoList?.getDomElement()); } else { <ins> this.container.classList.add('noVideos'); </ins> reset(rightColumn); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.0 OS Version: Linux x64 6.5.13-7-MANJARO Steps to Reproduce: the welcome page. all the walkthough suggestions. a lot of empty space on the right: ! Normally after closing all walkthroughs the "recent" list moves to the second column, to have a more balanced layout. This was broken a few versions ago, then fixed, and now it's broken again.
same here, it was discussed for example in
Looks the same to me, is that right? <img width="1218" alt="image" src=""
Change:
} public getCwd(): Promise<string> { <del> if (platform.isWindows) { </del> <ins> if (platform.isMacintosh) { </ins> return new Promise<string>(resolve => { <del> resolve(this._initialCwd); </del> <ins> exec('lsof -p ' + this._ptyProcess.pid + ' | grep cwd', (error, stdout, stderr) => { if (stdout !== '') { resolve(stdout.substring(stdout.indexOf('/'), stdout.length - 1)); } }); </ins> }); } <del> return new Promise<string>(resolve => { exec('lsof -p ' + this._ptyProcess.pid + ' | grep cwd', (error, stdout, stderr) => { if (stdout !== '') { resolve(stdout.substring(stdout.indexOf('/'), stdout.length - 1)); } </del> <ins> if (platform.isLinux) { return new Promise<string>(resolve => { fs.readlink('/proc/' + this._ptyProcess.pid + '/cwd', (err, linkedstr) => { if (err) { resolve(this._initialCwd); } resolve(linkedstr); }); </ins> }); <ins> } return new Promise<string>(resolve => { resolve(this._initialCwd); </ins> }); } }

Discussion:
Version: 1.31.1 Commit: OS: Linux x64 4.15.0-29deepin-generic Does this issue occur when all extensions are disabled?: Yes I can't split my terminal by clicking Split Terminal icon on terminal. When I click nothing happens. Instead I click new terminal icon, choose from drop-down menu and switch the other terminal which is not so handy.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.559 --- <!-- score: 0.531 --- <!-- score: 0.509 --- <!-- score: 0.501 --- <!-- score: 0.477 --<!-- potentialduplicates_comment --
are there any errors in the console (Help Toggle Developer Tools) when you try split? How wide is the terminal you're trying to split?
there's no error in the console while clicking split terminal. It looks like the icon is just an UI element with no further functionalities. All I want is to have an equal terminal.
how wide is the terminal when you're trying to split? Can you show a screenshot of the terminal immediately after it failed to split?
recorded !
There's an older open issue (and many closed ones) that this is a duplicate of: , and mentions a fix: Install or add to options (not sure what that means). Can confirm installing works. Version: v1.31.1 (and v1.31.0) Commit: Electron: 3.1.3 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Linux x64 4.20.8-arch1-1-ARCH
Thanks for help, it worked. Not sure I should close the issue, because it was solved by installing third-party dependency
thanks for finding this! We should fallback to when doesn't exist here:
Change:
} .scm-view .scm-editor-container .monaco-editor { <del> border-radius: 2px !important; </del> <ins> border-radius: 2px; </ins> } .scm-view .scm-editor-container .monaco-editor .focused .selected-text {

Discussion:
Perhaps due to semi-opaque color being applied to multiple layers within the input: <img width="210" alt="CleanShot 2022-12-15 at 11 28 11 src="https://user-"<img width="289" alt="CleanShot 2022-12-15 at 11 28 23 src="https://user-"
The source control message input background does not seem to use color customization at all.
I saw it in there, but it's a fairly complex component under the hood and (I think) multiple layers of the component use it. Because the color is semi-opaque it's appearing brighter than it should be after mixing with one layer with another.
You can reproduce & verify that the colour is not applied to this particular input by setting color customization in your settings JSON to a bright red: Observe all other inputs having bright red backgrounds but the commit message input background still having the same background as the surrounding panel's background.
This is what I am seeing with the built-in theme, it looks like it completely blends with the panel's background. For me this is happening with all themes, built-in & third-party - the input's background inherits the panel's background and cannot be customised at all. !
It works for me. I don't see the behavior you do with a transparent background. I'm also noting that you have a different typeface used for the placeholder. That leads me to believe there is something else going on. Are you using any extensions that manipulate VS Code e.g. customize UI? <img width="314" alt="CleanShot 2022-12-15 at 13 26 22 src="https://user-"In any case this will be fixed by . I'd recommend opening up a separate issue for your specific problem.
It works for me too when I place SCM panel to the left sidebar, but when SCM panel is placed to the right sidebar then background colour theming is ignored on the input. I do not see this problem mentioned in . ! !
That one I can indeed repro. Can you file a new issue for that?
Done! Submitted as .
Change:
Platform::DarwinARM64 => "server-darwin-arm64", Platform::WindowsX64 => "server-win32-x64", Platform::WindowsX86 => "server-win32", <del> Platform::WindowsARM64 => "server-win32-arm64", </del> <ins> Platform::WindowsARM64 => "server-win32-x64", // we don't publish an arm64 server build yet </ins> } .to_owned() }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Visual Studio Code CLI 1.74.3 OS Version: Microsoft Windows [Version 10.0..963] (Windows/ARM64) Steps to Reproduce: through device code authentication to the device in VS Code's remote explorer the CLI side, observe: , seems not to be pointing to anything that can be found.
Note that everything works splendidly if replacing with in this URL. Then the server is found and the connection succeeds.
Change:
this._workingCopyListeners.add(this._workingCopy.onDidChangeOrphaned(() => this._onDidChangeOrphaned.fire())); this._workingCopyListeners.add(this._workingCopy.onDidChangeReadonly(() => this._onDidChangeReadonly.fire())); } <del> this._workingCopy.onDidChangeDirty(() => this._onDidChangeDirty.fire(), undefined, this._workingCopyListeners); </del> <ins> this._workingCopyListeners.add(this._workingCopy.onDidChangeDirty(() => this._onDidChangeDirty.fire(), undefined, this._workingCopyListeners)); </ins> this._workingCopyListeners.add(this._workingCopy.onWillDispose(() => { this._workingCopyListeners.clear();

Discussion:
Set auto save: afterDelay Edit a notebook See the dirty indicator briefly appear after editing
I guess this is
We never did that for custom editors because it requires code to ensure that an editor that is closed but pending to be saved via auto save is really waited upon on shutdown. To further explain: the behaviour is driven by method if you return from that method no dirty indicator will show up this means a user can close an editor with dirty changes as such, components have to ensure that the save continues in the background and even on shutdown Files implement this here: I think the reason we never adopted this for notebooks as that notebooks have a dual model: complex and simple. With simple (which is based on file working copies), we can probably implement this now similar to what files do, but it needs careful testing what happens when you close a notebook quickly enough before auto save finished.
We could revisit this once we remove complex notebook model and friends but the saving of notebooks is more complex than files and I wonder if it's worth it to implement this. Also the dirty indicator is also an indicator that saving is not done yet, which is valuable as saving notebooks is not necessarily instant. what do you think ?
I think it's ok to close if this is complicated. It's also a bit odd that if I edit and immediately close the tab, it asks me whether I want to save, when I've enabled autosave.
with your recent changes in and please take note of Specifically: being able to close an editor that is now not dirty because of auto-save may result in data loss if closing the editor disposes state that is needed for saving. Filed as planned for July. Nevertheless, I appreciate that you are willing to look into this issue
Change:
const extHostEditorInsets = rpcProtocol.set(ExtHostContext.ExtHostEditorInsets, new ExtHostEditorInsets(rpcProtocol.getProxy(MainContext.MainThreadEditorInsets), extHostEditors, initData.environment)); const extHostDiagnostics = rpcProtocol.set(ExtHostContext.ExtHostDiagnostics, new ExtHostDiagnostics(rpcProtocol, extHostLogService)); const extHostLanguageFeatures = rpcProtocol.set(ExtHostContext.ExtHostLanguageFeatures, new ExtHostLanguageFeatures(rpcProtocol, uriTransformer, extHostDocuments, extHostCommands, extHostDiagnostics, extHostLogService, extHostApiDeprecation)); <del> const extHostFileSystem = rpcProtocol.set(ExtHostContext.ExtHostFileSystem, new ExtHostFileSystem(rpcProtocol, extHostLanguageFeatures)); </del> <ins> const extHostFileSystem = rpcProtocol.set(ExtHostContext.ExtHostFileSystem, new ExtHostFileSystem(rpcProtocol, extHostLanguageFeatures, extHostConsumerFileSystem)); </ins> const extHostFileSystemEvent = rpcProtocol.set(ExtHostContext.ExtHostFileSystemEventService, new ExtHostFileSystemEventService(rpcProtocol, extHostLogService, extHostDocumentsAndEditors)); const extHostQuickOpen = rpcProtocol.set(ExtHostContext.ExtHostQuickOpen, new ExtHostQuickOpen(rpcProtocol, extHostWorkspace, extHostCommands)); const extHostSCM = rpcProtocol.set(ExtHostContext.ExtHostSCM, new ExtHostSCM(rpcProtocol, extHostCommands, extHostLogService));

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
import { Color } from 'vs/base/common/color'; import { KeyCode } from 'vs/base/common/keyCodes'; import { Disposable } from 'vs/base/common/lifecycle'; <del> import { escape } from 'vs/base/common/strings'; </del> import { ContentWidgetPositionPreference, IActiveCodeEditor, ICodeEditor, IContentWidget, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser'; import { EditorAction, ServicesAccessor, registerEditorAction, registerEditorContribution } from 'vs/editor/browser/editorExtensions'; import { Position } from 'vs/editor/common/core/position';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . Simirarly to , it aims to replace construction of HTML elements by string concatenation in file. The code contains mainly a table construction by concatenating strings of . The goal is to replace them all with function calls.
I verified by running the monaco editor from source and testing the inspect token hover
To verify, open the hover and verify it looks all proper.