jiebi/CodeConvo huggingface dataset:
Change:
} // 1.file.txt=>2.file.txt <del> let prefixFileRegex = RegExp('(d+)(' + separators + '.*)(..*)$'); </del> <ins> let prefixFileRegex = RegExp('^(d+)(' + separators + '.*)(..*)$'); </ins> if (!isFolder && name.match(prefixFileRegex)) { return name.replace(prefixFileRegex, (match, g1?, g2?, g3?) => { let number = parseInt(g1);

Discussion:
Issue Type: <bBug</bI have a file named F1000-v117.au3. When copying/pasting the file, it creates a file named F1001-v117.au3. This is not the expected result. F1000 is the name of the file and not a version number that should be incremented. Changing the regex within the incrementFileName function fixes the issue. Basically, make sure the first section of the file name is numeric only. to VS Code version: Code 1.25.1 (, 2018-07-11T15:43:11.471Z) OS version: WindowsNT ia32 6.1.7601 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
PR for this is welcome It would be great if the PR contains a unit test fyi
I'll take a look tomorrow.
is the expected result right?
Actually it seems like other cases are broken now. Have a file , copy and paste it The new file is , in 1.26 it was
Thanks for finding that Due to that I had to revert the original fix. So now copying gives However this issue is now not fixed, but it was like that in previous stable so nothing urgent -removing mielstone let me know if you want to fix your fix and provide a working PR. Thanks
Hey guys, I took a crack at fixing this regex have some questions on how the naming / number schema works and I want to make sure I have an understanding of the naming schema. We have our cases here: suffix: prefix: single number: no number: ends with number: mixed (new case / why the above PR broke): prefixed with number: The issue is that mixing letters and numbers triggers the prefix regex which incorrectly increments the number. But all the different variations of prefix / suffix and single number / mixed with letters make this particularly tricky. It seems like edits need to be made to existing regexes to ensure that they are matching digit only groups. However, the above PR regex edits and the edits I've made consistently break other regexes. Any ideas or considerations here?

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details . If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our and guidelines. Thanks for your understanding and happy coding!
Change:
getCellExecutionsByHandleForNotebook(notebook: URI): Map<number, INotebookCellExecution> | undefined { const exeMap = this._executions.get(notebook); <del> return exeMap ?? undefined; </del> <ins> return exeMap ? new Map(exeMap.entries()) : undefined; </ins> } private _onCellExecutionDidChange(notebookUri: URI, cellHandle: number, exe: CellExecution): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: a breakpoint in a cell the cell the cell out of view the cell the run button is rendered, other than the stop button Digging into this a bit and I found that the context key service/update is correct, the problem is we receive an execution message from the extension host right after initializing the debug session so the cell execution state is instead of or . That's why when we re-render the cell, the run button is rendered.
Change:
"scm/outgoingChanges/allChanges/context": [ { "command": "git.viewAllChanges", <del> "when": "scmProvider == git && config.multiDiffEditor.experimental.enabled", </del> <ins> "when": "scmProvider == git && scmHistoryItemFileCount != 0 && config.multiDiffEditor.experimental.enabled", </ins> "group": "inline@1" } ], "scm/outgoingChanges/historyItem/context": [ { "command": "git.viewCommit", <del> "when": "scmProvider == git && config.multiDiffEditor.experimental.enabled", </del> <ins> "when": "scmProvider == git && scmHistoryItemFileCount != 0 && config.multiDiffEditor.experimental.enabled", </ins> "group": "inline@1" } ],

Discussion:
Testing an empty commit Notice the action still appears even though it's a no-op. We should either hide it (preferable) or disable it. <img width="568" alt="image" src=""
Change:
import { IStatusbarEntry, IStatusbarEntryAccessor, IStatusbarService, StatusbarAlignment } from 'vs/platform/statusbar/common/statusbar'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <ins> import { ITheme, registerThemingParticipant, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; import { IMAGE_PREVIEW_BORDER } from 'vs/workbench/common/theme'; </ins> export interface IResourceDescriptor { readonly resource: URI;

Discussion:
See for context
, I will take a look at this. Adding border to image as suggested in the other issue.
Change:
dependencies: vscode-languageserver-protocol "3.17.2" <del> vscode-markdown-languageservice@^0.2.0-alpha.7: version "0.2.0-alpha.7" resolved "https://registry.yarnpkg.com/vscode-markdown-languageservice/-/vscode-markdown-languageservice-0.2.0-alpha.7.tgz#1f5fd345630e9d0d585cb00155d433c2320fa9c2" integrity sha512-5QYz1+LpvazK21Hphx8wZiZIXE9cQ9R3jzhQr+I89xNHJi+NWTEBA555ZFkaaYR68B7SI7OQ4jihjkGLZTUTnw== </del> <ins> vscode-markdown-languageservice@^0.2.0-alpha.8: version "0.2.0-alpha.8" resolved "https://registry.yarnpkg.com/vscode-markdown-languageservice/-/vscode-markdown-languageservice-0.2.0-alpha.8.tgz#f77c20adea2ddafdad88b99b09be1778c358ca42" integrity sha512-kydgGkSarjFk71culFover7lBym82wmJdvuqCzS3IPZV+fhW1l0poca/Dt4bDku3ioda0kNH9xdmi0fiHkIDUQ== </ins> dependencies: picomatch "^2.3.1" vscode-languageserver-textdocument "^1.0.5"

Discussion:
Type: <bBug</bworkspace: : to top level of workspace bug The link is incorrectly rewritten to include the file name VS Code version: Code - Insiders 1.73.0-insider (Universal) (, 2022-10-27T21:41:11.954Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
themeId = validateThemeId(themeId); // migrate theme ids <del> if (this.themingParticipantChangeListener) { this.themingParticipantChangeListener.dispose(); this.themingParticipantChangeListener = null; } </del> return this.findThemeData(themeId, DEFAULT_THEME_ID).then(themeData => { if (themeData) {

Discussion:
<!-- Do you have a question? Please ask it on --I am building a component that is lazily loaded (and therefore lazily calls ). The callback passed in to registerThemingParticipant is never getting called though and it seems like this is because disposes any previous and does not add it back for some code paths. It looks like assumes that will add back the listener , but there are multiple code paths in that neither call nor add back the listener. The specific case I am hitting is When this case is hit, the listener is never re-registered, so subsequent calls to will have no effect.
I do not see this is an extension API.. are there any steps to verify this?
No, its just in code, no need to verify
Adding verified tag so that it wont be seen in the to verify list
Change:
id: item.id, label, ariaLabel, <ins> keybinding: keybindingService.lookupKeybinding(item.id, contextKeyService), </ins> buttons: !item.useButtons ? undefined : [ { alwaysVisible: false,

Discussion:
Testing F1 Customize Layout Some of the entries have keybindinding with the same effect, like to show/hide the side bar, for the panel, or for zen mode The corresponding commands should show those keybinding so that I can learn how to achieve my goal faster
This can be easily done: <img width="633" alt="image" src=""PR:
Verification: open the layout picker ("Customize Layout") verify some of the entries show their keybindings
Change:
import { MarkdownPreviewConfigurationManager } from './previewConfig'; import { scrollEditorToLine, StartingScrollFragment } from './scrolling'; import { TopmostLineMonitor } from './topmostLineMonitor'; <ins> import * as nls from 'vscode-nls'; const localize = nls.loadMessageBundle(); </ins> export interface DynamicPreviewSettings { readonly resourceColumn: vscode.ViewColumn;

Discussion:
https://vscode- Deminified Stack TypeError: Cannot read properties of undefined (reading 'resource') at deserializeWebviewPanel in /vscode/bin/linux-x64//extensions/markdown-language- at (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at (node:internal/streams/readable:228:10) at TCP.onStreamRead (node:internal/streambase_commons:199:23)
Change:
}); await this.repository.clean(toClean); <del> await this.repository.checkout('', toCheckout); </del> <ins> try { await this.repository.checkout('', toCheckout); } catch (err) { if (err.gitErrorCode !== GitErrorCodes.BranchNotYetBorn) { throw err; } } </ins> await this.repository.updateSubmodules(submodulesToUpdate); this.closeDiffEditors([], [...toClean, ...toCheckout]);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Steps to Reproduce: a existing folder in vscode sure the folder has files "init repository" buttun in vscode a change (delete a file) in vscode source control the error: ! I would suggest popping up a dialog asking the user if he/she wants to create a branch first.
Change:
env, cols, rows, <del> experimentalUseConpty: useConpty, </del> <ins> useConpty, </ins> // This option will force conpty to not redraw the whole viewport on launch conptyInheritCursor: useConpty && !!shellLaunchConfig.initialText };

Discussion:
An issue with the node-pty update caused the conpty setting to not do anything, instead reverting to the node-pty default for conpty (always when Windows + is being used). Since I've recommended using that setting as a workaround for certain ConPTY issues (like ), this feels like it meets the bar for 1.40.
To verify on a Window 10 build + machine (run ver to check build number): to true and verify that a conpty process gets created. Check the process explorer for conpty process. it to false and verify a winpty process gets created. conpty processes look like the ones in red under the window, winpty are in blue: !
Closing to make sure this shows up in our verification query. Testing now
Moved to recovery as we didn't want to push the release out another day.
Change:
private readonly machineId: string, protected readonly configurationService: IConfigurationService, protected readonly productService: IProductService, <ins> protected readonly environmentService: IEnvironmentService, </ins> protected telemetry: IExperimentationTelemetry, private keyValueStorage?: IKeyValueStorage ) { <del> if (productService.tasConfig && this.experimentsEnabled && getTelemetryLevel(this.configurationService) === TelemetryLevel.USAGE) { </del> <ins> const isTesting = environmentService.extensionTestsLocationURI !== undefined; if (!isTesting && productService.tasConfig && this.experimentsEnabled && getTelemetryLevel(this.configurationService) === TelemetryLevel.USAGE) { </ins> this.tasClient = this.setupTASClient(); }

Discussion:
We have learnt (the hard way) that when running extension/integration tests that EXP is enabled. This means some build (and user) machines might behave different to how they run locally. Also, it seems wasteful to contact the service when running tests
Change:
} try { <ins> // We must expand the nest to have it be populated in the tree if (item.nestedParent) { await this.tree.expand(item.nestedParent); } </ins> if (reveal === true && this.tree.getRelativeTop(item) === null) { // Don't scroll to the item if it's already visible, or if set not to. this.tree.reveal(item, 0.5);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.0-insider (user setup) Commit: OS Version: Windows_NT x64 10.0. Steps to Reproduce: file nesting two files, and the editor tab open the "Reveal in Explorer View" command file is not revealed in the explorer view Once you manually expand the nesting to reveal the command will start working, even if you collapse the tree under again. It will stop working again if any change to the tree view is made (creating, deleting, or renaming a file) while the nested tree is collapsed. Maybe related:
This is most likely caused by the tree being async. It does not know that node exists because it has not been resolved yet. You having the file open is not a guarantee that the file is in the explorer (think outside files).
Nested files option in VS code is great to automatically declutter explorer view, but this bug is extremely annoying. When you open some file, VS code automatically shows its location in explorer view, so that you can orient yourself and see what are neighboring files. This prevents that sync from happening, and this slowdown forces the decision to stop using nested files until it's fixed.
Change:
// Remember widget this.inputWidgets.set(input, templateData.inputWidget); <del> templateData.elementDisposables.add({ dispose: () => this.inputWidgets.delete(input) }); </del> <ins> templateData.elementDisposables.add({ dispose: () => { this.inputWidgets.delete(input); this.contentHeights.delete(input); } }); </ins> // Widget cursor selections const selections = this.editorSelections.get(input);

Discussion:
Type a multiline commit message Scroll away Scroll back When the row gets rerendered (I assume) it is sized to one line. If I type a newline in this box, the size gets fixed !
Possibly a regression introduced with
Change:
} function evalBrowserEntry(browsers: string) { <del> var browserEntry : Browsers = { all: false, FF: '', S: '', C: '', IE: '', O: '', count: 0}; </del> <ins> var browserEntry : Browsers = { all: false, E: '', FF: '', S: '', C: '', IE: '', O: '', count: 0}; </ins> var count = 0; if (browsers) { browsers.split(',').forEach(

Discussion:
The auto-complete lacks MS Edge info. Presumably it needs to be at the line above. I can make the PR request myself if needed, but I'm not sure if it needs plumbed in in other locations too?
Needs to be to browserEntry too
Change:
"filenames": [ "babel.config.json", ".babelrc.json", <del> ".ember-cli" </del> <ins> ".ember-cli", "typedoc.json" </ins> ], "configuration": "./language-configuration.json" }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --since version 0.23 released about a month ago, TypeDoc supports jsonc in its configuration file. VSCode should allow comments without errors without additional user configuration, much like it does for files.
This feature is powered by the TypeScript project. Please
this doesn't seem to be correct, given that the PR linked above adds it to a list of other jsonc files. Note: != TypeScript shouldn't have anything to do with this.
Oh ok, you just want a file called to be automatically. I'll reopen but this should be a very simply PR if you want to take a look
Yes, I think I did it in , then opened this issue when the PR template asked me for an issue.
Change:
// Build the file filter by using our known languages const ext: string | undefined = defaultUri ? resources.extname(defaultUri) : undefined; let matchingFilter: IFilter | undefined; <del> const registeredLanguageFilters: IFilter[] = coalesce(this.modeService.getRegisteredLanguageNames().map(languageName => { </del> <ins> const registeredLanguageNames = this.modeService.getRegisteredLanguageNames().sort((a, b) => compareIgnoreCase(a, b)); const registeredLanguageFilters: IFilter[] = coalesce(registeredLanguageNames.map(languageName => { </ins> const extensions = this.modeService.getExtensions(languageName); if (!extensions || !extensions.length) { return null;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.52.1 (user setup) OS Version: Windows_NTx64 10.0. Steps to Reproduce: some custom languages, examples that it definitely works for are "Caddlefile Syntax", "Graphviz language", "Hjson", "Better TOML", "Svelte for VS Code". a new blank file. --Save as and expect to find it in the alphabetically sorted list (e.g. Toml from Better TOML between Swift and TypeScript) , instead find it at the bottom. It appears to be in the order 'inbuilt languages sorted alphabetically' followed by 'other languages sorted somewhat randomly'. ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No
They are sorted on macOS, so it maybe Windows doing something weird. But we also dont sort the list explicitly:
Up for grab, I think we should sort the languages by name. We still have to make sure that: "All Files" appears first the current language appears second and selected "No Extension" is last
If you sort "registeredLanguageFilters" that should solve the problem no? "All files" appearing first, current language appearing second and "No Extension" appearing last is handled by these lines: Still getting the hang of all this, so please correct me if I am wrong.
Can we have this discussion in a Pull Request?
Two things I notice. as with untitled files defaults to not . Save as on a file with a pre-existing extension leads to an out of order list. I.e. here's a picture of .CSS !
It is intentional that the language mode picked for a file is the second most entry in the list, we have explicit code to change the order there. As for untitled: did you have the language mode configured to ".bat"? I suggest we follow up in a new issue here as it is independent from the sorting fix. Verification: create an untitled file save it in the picker verify that the languages are sorted by name, specifically check for languages contributed by extensions such as JSONC
Change:
// Explorer if (list instanceof AsyncDataTree && list.getFocus().every(item => item instanceof ExplorerItem)) { // Explorer <del> const context = explorerService.getContext(true); </del> <ins> const context = explorerService.getContext(true, true); </ins> if (context.length) { return context.map(c => c.resource); }

Discussion:
https://user-
This issue may be same with When run the command on file which using file nesting, passed multiple file paths.

Type: <bBug</b https://user- VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-20T05:16:19.460Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (71)</summaryExtensionVersion ------ better-comments3.0.0 extendscript-debug2.0.3 tsl-problem-matcher0.6.2 file-nesting1.0.0 color-info0.7.0 github-markdown-preview0.3.0 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.3.0 markdown-footnotes0.0.7 markdown-mermaid1.14.2 markdown-preview-github-styles1.0.1 markdown-yaml-preamble0.1.0 file-browser0.2.10 vscode-translation2.0.6 vscode-url-title-resolver1.1.1 compare-view0.7.0 vscode-opennewinstance0.0.12 gitignore0.8.0 vscode-markdownlint0.47.0 vscode-eslint2.2.6 githistory0.6.19 tsimportsorter7.4.19 css-flexbox-cheatsheet3.3.1 css-initial-value0.2.6 gitlens-insiders2022.7.2005 vscode-html-css1.13.0 prettier-vscode9.5.0 code-runner0.11.8 shell-format7.2.2 todo-tree0.0.215 vscode-nginx-conf-hint0.3.0 path-autocomplete1.19.1 vscode-env0.1.0 markdown-kbd0.4.2 svg1.4.19 vscode-gutter-preview0.30.0 template-string-converter0.6.0 hexeditor1.9.7 js-debug-nightly2022.7.1117 live-server0.2.12 test-adapter-converter0.1.6 vscode-js-profile-flame1.0.4 vscode-typescript-next4.8.

vetur0.35.0 vscode-twoslash-queries1.0.2 vscode-versionlens1.0.10 git-file-history1.0.1 text-power-tools1.34.0 vscode-xml0.21.0 vscode-yaml1.9.1 vue-vscode-snippets3.1.1 vscode-fileutils3.5.0 code-spell-checker2.3.1 vscode-stylelint1.2.2 markdowntable0.10.0 hosts1.2.0 vscode-choosealicense0.7.0 vscodeintellicode1.2.22 vscode-icons11.13.0 snippet-generator0.3.2 modify-file-warning0.0.2 open-in-external-app0.5.0 regexp-tools0.0.1 scripting-listener0.0.3 view-github-repository1.1.0 vscode-archive0.1.2 vscode-fe-helper0.2.1 ytj-snippets0.0.5 markdown-all-in-one3.4.3 node-modules1.4.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Mine reveals but it reveals the child and not the parent so definitely a bug
if you ensure that no item in the explorer view has focus, then right click the parent, nothing will happen when you reveal in explorer/finder edit: actually that isn't consistent, in some cases nothing happens and sometimes it does what you said, I do not know the exact repro