jiebi/CodeConvo huggingface dataset:
Change:
private readonly _containsEmbeddedLanguages: boolean; private readonly _seenLanguages: boolean[]; private readonly _initialState: StackElement; <ins> private _maxTokenizationLineLength: number; </ins> private _tokenizationWarningAlreadyShown: boolean; <del> constructor(scopeRegistry: TMScopeRegistry, languageId: LanguageId, grammar: IGrammar, initialState: StackElement, containsEmbeddedLanguages: boolean, @INotificationService private readonly notificationService: INotificationService) { </del> <ins> constructor(scopeRegistry: TMScopeRegistry, languageId: LanguageId, grammar: IGrammar, initialState: StackElement, containsEmbeddedLanguages: boolean, @INotificationService private readonly notificationService: INotificationService, @IConfigurationService readonly configurationService: IConfigurationService) { </ins> this._scopeRegistry = scopeRegistry; this._languageId = languageId; this._grammar = grammar; this._initialState = initialState; this._containsEmbeddedLanguages = containsEmbeddedLanguages; this._seenLanguages = []; <ins> this._maxTokenizationLineLength = configurationService.getValue<number>('editor.maxTokenizationLineLength'); </ins> } public getInitialState(): IState {

Discussion:
Found no duplicated for this one Currently it's hardcoded I propose a config entry for long line length If you're object, I'd like to create pull request for this feature Your thoughts?
I think this makes sense as a workspace setting that defaults to the current value. Feel free to make a PR!
Change:
import { Color, RGBA } from 'vs/base/common/color'; import { localize } from 'vs/nls'; <del> import { badgeBackground, badgeForeground, contrastBorder, foreground, registerColor } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { badgeBackground, badgeForeground, contrastBorder, editorBackground, editorWidgetBackground, foreground, registerColor } from 'vs/platform/theme/common/colorRegistry'; </ins> export const chatRequestBorder = registerColor( 'chat.requestBorder',

Discussion:
Magnification users often zoom out to decide what they will zoom in to read. For HC themes, we should make sure there's a difference in color between requests and responses.
good idea!
There's a slight difference on high contrast dark, but there appears to be no difference with high contrast light: ! !
This is by design as the light theme is completely flat and doesn't use a secondary background colour anywhere . The main differentiator in the HC themes is the bars on the side.
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.2", "xterm-addon-canvas": "0.4.0-beta.1", "xterm-addon-search": "0.11.0-beta.7", </del> <ins> "xterm": "5.2.0-beta.10", "xterm-addon-canvas": "0.4.0-beta.6", "xterm-addon-search": "0.11.0", </ins> "xterm-addon-serialize": "0.9.0", <del> "xterm-addon-unicode11": "0.5.0-beta.5", "xterm-addon-webgl": "0.15.0-beta.1", "xterm-headless": "5.2.0-beta.2", </del> <ins> "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.15.0-beta.4", "xterm-headless": "5.2.0-beta.10", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
! Only seems to appear if I resize the terminal such that a is on its own line.
Cannot repro: !
I can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.
Couldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)
In tried on my mac and I still can't reproduce: !
Still able to reproduce this, have passed repo steps regarding the private repo offline.
Still struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width="852" alt="Screenshot 2022-12-22 at 5 08 03 pm" src="https://user-"
This happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width="866" alt="Screenshot 2022-12-22 at 5 12 44 pm" src="https://user-"
That one repro's upstream: <img width="793" alt="Screenshot 2022-12-27 at 6 24 10 am" src="https://user-"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.
Can still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.
Update cannot repro when debugging. So odd
Update again, I can repro this again in insiders. Not sure why debugging is different.
Still can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width="632" alt="Screenshot 2023-05-08 at 6 43 07 am" src="https://user-"OSS: <img width="637" alt="Screenshot 2023-05-08 at 6 44 55 am" src="https://user-"OSS debugging: <img width="633" alt="Screenshot 2023-05-08 at 6 46 16 am" src="https://user-"cat this file:
Change:
} }; <del> const execMain = path.basename(process.execPath); const script = URI.parse(require.toUrl('vs/base/node/ps-win.ps1')).fsPath; const commandLine = `& {& '${script}' -ProcessName '${execMain}' -MaxSamples 3}`; const cmd = spawn('powershell.exe', ['-NoProfile', '-ExecutionPolicy', 'Bypass', '-Command', commandLine]); let stdout = ''; let stderr = ''; cmd.stdout.on('data', data => { stdout += data.toString(); }); </del> <ins> (import('windows-process-tree')).then(windowsProcessTree => { windowsProcessTree.getProcessList(rootPid, (processList) => { windowsProcessTree.getProcessCpuUsage(processList, (completeProcessList) => { const processItems: Map<number, ProcessItem> = new Map(); completeProcessList.forEach(process => { const commandLine = cleanUNCPrefix(process.commandLine); processItems.set(process.pid, { name: findName(commandLine), cmd: commandLine, pid: process.pid, ppid: process.ppid, load: process.cpu, mem: process.memory }); }); </ins> <del> cmd.stderr.on('data', data => { stderr += data.toString(); }); </del> <ins> rootItem = processItems.get(rootPid); if (rootItem) { processItems.forEach(item => { let parent = processItems.get(item.ppid); if (parent) { if (!parent.children) { parent.children = []; } parent.children.push(item); } }); </ins> <del> cmd.on('exit', () => { if (stderr.length > 0) { reject(new Error(stderr)); return; } let processItems: Map<number, ProcessItem> = new Map(); try { const items: Item[] = JSON.parse(stdout); for (const item of items) { if (item.type === 'processInfo') { let load = 0; if (item.cpuLoad) { for (let value of item.cpuLoad) { load += value; </del> <ins> processItems.forEach(item => { if (item.children) { item.children = item.children.sort((a, b) => a.pid - b.pid); </ins> } <del> load = load / item.cpuLoad.length; } else { load = -1; } let commandLine = cleanUNCPrefix(item.commandLine); processItems.set(item.processId, { name: findName(commandLine), cmd: commandLine, pid: item.processId, ppid: item.parentProcessId, load: load, mem: item.workingSetSize </del> }); <ins> resolve(rootItem); } else { reject(new Error(`Root process ${rootPid} not found`)); </ins> } <del> } rootItem = processItems.get(rootPid); if (rootItem) { processItems.forEach(item => { let parent = processItems.get(item.ppid); if (parent) { if (!parent.children) { parent.children = []; } parent.children.push(item); } }); processItems.forEach(item => { if (item.children) { item.children = item.children.sort((a, b) => a.pid - b.pid); } }); resolve(rootItem); } else { reject(new Error(`Root process ${rootPid} not found`)); } } catch (error) { console.log(stdout); reject(error); } </del> <ins> }); }, windowsProcessTree.ProcessDataFlag.CommandLine | windowsProcessTree.ProcessDataFlag.Memory); </ins> }); } else {	// OS X & Linux

Discussion:
After updating the module to support getting memory, cpu, and command line for each process on windows (), the module can be used in more places within VSCode [x] Update existing version of the module that's being used in the terminal [x] Use the module in place of the PowerShell script in
Change:
// Get a single link candidate if the cwd of the line is known const linkCandidates: string[] = []; <del> if (osPathModule(this._os).isAbsolute(link)) { </del> <ins> if (osPathModule(this._os).isAbsolute(link) || link.startsWith('~')) { </ins> linkCandidates.push(link); } else { if (this._capabilities.has(TerminalCapability.CommandDetection)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 Local OS Version: Windows 10 Pro for Workstations 21H2 .1889 Remote OS Version: WSL1 - Debian 11 / SSH - Debian 9 Steps to Reproduce: -WSL/SSH to a server. the integrated terminal and type a path start with like then left click to the path in terminal. VSCode shows that no matching results. if we type an absolute path like then it works. Considering that there may be files or directories starting with in the current directory, VSCode has changed the file path parsing method since v1.69 (If I remember correctly). But can we continue to parse as home directory(like as , as ) after judging that the files or directories in the current directory does not exist?
I see 2 problems with ~ in links, first is files aren't resolving and auto-selecting the first entry if there is only one: ! Second is folder aren't recognized: !
This actually happens on local workspaces as well, at least on Windows
It's being treated as a search link because of this: !
Change:
this._domNode.setLineHeight(this._lineHeight); this._domNode.setHeight(this._lineHeight); <ins> if (this._cursorStyle !== TextEditorCursorStyle.Line) { let desiredWidth = '1ch'; if (this._characterWidth > 0) { desiredWidth = `${this._characterWidth}px`; } if (this._domNode.domNode.style.width !== desiredWidth) { this._domNode.domNode.style.width = desiredWidth; } } </ins> return { position: this._position, contentTop: top,

Discussion:
VSCode Version: 1.5.0 OS Version: OSX Originally posted in but later we found it's a Code issue. Repro steps cursor to any CJK characters !
Change:
return await this.run(Operation.Stash, () => this.repository.popStash(index)); } <ins> async applyStash(index?: number): Promise<void> { return await this.run(Operation.Stash, () => this.repository.applyStash(index)); } </ins> async getCommitTemplate(): Promise<string> { return await this.run(Operation.GetCommitTemplate, async () => this.repository.getCommitTemplate()); }

Discussion:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!
Change:
} private async _activate(link: string) { <ins> // Normalize the link and remove any leading ./ or ../ since quick access doesn't understand // that format link = normalize(link).replace(/^(.+/)+/, ''); </ins> const results = await this._searchService.fileSearch( this._fileQueryBuilder.file(this._workspaceContextService.getWorkspace().folders, { filePattern: link,

Discussion:
You could resolve these so it would search for the right file. Or do you not want to make assumptions about the format of the thing? ! !
Started a discussion in , if that's no good I can just normalize the path which isn't super smart but it will find results.
Open to PRs, more detailed repro in
I would like to work on this issue. We only want to normalize the path in the filter string, right? So: - a/../b/./c -b/c
yes, but just for the
I have raised a PR for this issue. Please review it.
Change:
const isAllowed = chatAgentNameService.getAgentNameRestriction(agent); let name = `${isAllowed ? agent.name : getFullyQualifiedId(agent)}`; <del> const isDupe = isAllowed && chatAgentService.getAgentsByName(agent.name).length > 1; </del> <ins> const isDupe = isAllowed && chatAgentService.agentHasDupeName(agent.id); </ins> if (isDupe) { name += ` (${agent.publisherDisplayName})`; }

Discussion:
I removed this to move over to using the agent, which required setting . Chatted with and I should add another agent to support the agent in both places, only making it the default for the terminal location. fyi
Verified that is available in panel chat.
Change:
async setPassword(windowId: number | undefined, service: string, account: string, password: string): Promise<void> { const keytar = await this.withKeytar(); <ins> const MAX_SET_ATTEMPTS = 3; // Sometimes Keytar has a problem talking to the keychain on the OS. To be more resilient, we retry a few times. const setPasswordWithRetry = async (service: string, account: string, password: string) => { let attempts = 0; let error: any; while (attempts < MAX_SET_ATTEMPTS) { try { await keytar.setPassword(service, account, password); return; } catch (e) { error = e; this.logService.warn('Error attempting to set a password: ', e); attempts++; await new Promise(resolve => setTimeout(resolve, 200)); } } // throw last error throw error; }; </ins> if (isWindows && password.length > NativeHostMainService.MAX_PASSWORD_LENGTH) { let index = 0;

Discussion:
testing I signed into two accounts (cdias @ and chris @ ), and then signed out of the account. The result: !
I'm getting this error on Ubuntu 20.04 with my GitHub sign-in. I've only used the single account on this machine, so no idea why this started occurring.
Using Ubuntu 20.04 with the latest VS code build. Although the error is slightly different. !
Hi I'm in the same situation Any help will be apreciated King regards Version: 1.50.1 Commit: Date: 2020-10-13T14:44:48.716Z Electron: 9.2.1 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Linux x64 5.4.0-52-generic snap (Ubuntu 20.04.1 LTS)
Try
it's already installed. I have Ubuntu 20.04.1 LTS !
I UPDATE... Magically solved for me. The way... first I login into official addon Github Pull Request and after enable sync for Github
I think the best we can do here is just add some retry logic as I've seen this every once and a while and reloading the window seems to work.
verification steps: Turn on settings sync and log in with your Microsoft account... then log out... then log in... then log out... (repeat until you don't wanna do it anymore). You shouldn't see the error above.
Change:
import { basename, joinPath } from 'vs/base/common/resources'; import { URI } from 'vs/base/common/uri'; import { ILanguageService } from 'vs/editor/common/languages/language'; <ins> import { getIconClassesForLanguageId } from 'vs/editor/common/services/getIconClasses'; </ins> import * as nls from 'vs/nls'; import { MenuId } from 'vs/platform/actions/common/actions'; import { IFileService } from 'vs/platform/files/common/files';

Discussion:
Type: <bBug</bSteps to Reproduce: Visual Studio Code. to and select . the language for any selected file by running the command (). the dropdown list from step 2 with the dropdown list from step 3. Expected Behavior: Both dropdown lists should appear consistent, as they serve a similar purpose. Specifically, the list should include icons for the language identifiers, just as the list does. Here's what it looks like: VS Code version: Code 1.90.2 (, 2024-06-18T22:33:48.698Z), Code - Insiders 1.91.0-insider (, 2024-06-19T05:51:22.778Z) OS version: Linux x64 6.5.0-41-generic snap Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
constructor( @IThreadService threadService: IThreadService, @IPluginService pluginService: IPluginService, <del> @IWorkspaceContextService contextService: IWorkspaceContextService </del> <ins> @IWorkspaceContextService contextService: IWorkspaceContextService, @ITelemetryService telemetryService: ITelemetryService </ins> ) { this._pluginService = pluginService; this._threadService = threadService; <ins> this._telemetryService = telemetryService; </ins> this._proxy = threadService.getRemotable(MainProcessVSCodeAPIHelper); this.version = contextService.getConfiguration().env.version; <ins> this._telemetryService.getTelemetryInfo().then((info) => { this.env = { machineId: info.machineId, sessionId: info.sessionId, locale: null } }); </ins> this.Uri = URI; this.Location = extHostTypes.Location; this.Diagnostic = <any> extHostTypes.Diagnostic;

Discussion:
I'm not sure if this is an issue in vscode, or typescript, or a DT package, but vscode is complaining about the "funding" field requiring 2 properties, which is incorrect (the other one is "type", and it's optional). <img width="440" alt="Screen Shot 2022-03-14 at 2 36 39 PM" src="https://user-"If this is the wrong place to file it, please point me to the right one :-) Thanks!
(happy to do the work to fix it, too, if someone can point me to where they're defined)
Most likely this is provided by SchemaStore and was just recently UPD. Documentation doesn't have any examples of objects only with field so it's unclear from docs if it's possible to omit field unless you check implementation (or do the implementation ). Maybe it make sense to have at least one object without field in npm docs?
Yes, this needs to be adopted in the SchemaStore. Marking as duplicate of
The docs are irrelevant; to document the types for something, you need to check the actual behavior. Thanks, I’ll follow it there.
Change:
} } <del> this.check = append(this.item, $('span.menu-item-check.' + menuSelectionIcon.cssSelector)); </del> <ins> this.check = append(this.item, $('span.menu-item-check' + menuSelectionIcon.cssSelector)); </ins> this.check.setAttribute('role', 'none'); this.label = append(this.item, $('span.action-label'));

Discussion:
Issue Type: <bBug</bThe preference icon in File option is not correct. It should be , not √. ! VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T08:44:55.510Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Actually duplicate of

Issue Type: <bBug</bafter the latest update observed tick marks in the menu instead of the "" sign to indicate there is a submenu. is this expected change? i have pinned the menu in the sidebar. ! VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T06:26:58.340Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.15.0-96-generic <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ remote-containers0.112.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.2 vscode-remote-extensionpack0.20.0 debugger-for-chrome4.12.6 ng-template0.901.2 vscode-eslint2.1.5 gitlens10.2.1 EditorConfig0.14.5 prettier-vscode4.4.0 node-debug21.42.2 typescript-javascript-grammar0.0.53 vscode-typescript-tslint-plugin1.2.3 vsliveshare1.0.2000 vscode-xml0.11.0 vscode-yaml0.7.2 LiveServer5.6.1 sonarlint-vscode1.15.0 vscodeintellicode1.2.6 </details<!-- generated by issue reporter --
I don't think that this one is intended. /cc May be something with codicons or styles. I noticed that I have sometimes spinning instead of because former overrides styles of loader. Haven't noticed this problem before
related to product icon overrides?
sorry for mention, I was not aware about changes in approach to use Codicons and thought that it might be unintentional font update. Yes, looks like it was part of . PR with fix is available
Change:
return (documentVersion: number) => { if (!cachedElements || documentVersion !== cachedVersion) { cachedVersion = documentVersion; <del> cachedElements = [{ element: document.body, line: -1 }]; </del> <ins> cachedElements = [new CodeLineElement(document.body, -1)]; </ins> for (const element of document.getElementsByClassName(codeLineClass)) { <ins> if (!(element instanceof HTMLElement)) { continue; } </ins> const line = +element.getAttribute('data-line')!; if (isNaN(line)) { continue; } if (element.tagName === 'CODE' && element.parentElement && element.parentElement.tagName === 'PRE') { // Fenced code blocks are a special case since the `code-line` can only be marked on // the `<code>` element and not the parent `<pre>` element. <del> cachedElements.push({ element: element.parentElement as HTMLElement, line: line, codeElement: element as HTMLElement }); </del> <ins> cachedElements.push(new CodeLineElement(element.parentElement, line, element)); </ins> } else if (element.tagName === 'UL' || element.tagName === 'OL') { // Skip adding list elements since the first child has the same code line (and should be preferred) } else { <del> cachedElements.push({ element: element as HTMLElement, line }); </del> <ins> cachedElements.push(new CodeLineElement(element, line)); </ins> } } }

Discussion:
Thanks for the quick turnaround on preserving the open attribute! I'm still a little curious about the scrolling sync: I don't see anything in that looks like it would address the issue I'm seeing "scrolling past" a collapsed block where the code cursor makes the preview act as if it's much further down, seemingly by about as much as the length of the expanded . I can now leave my expanded to re-enable sync'd scrolling, but I was wondering if the intent was to not change the behavior when they're closed? Or, would it be helpful if I broke that part out into a new issue? Originally posted by in
Thanks. I've extracted this to it's own issue and will push a fix shortly
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
return; } <del> let outputFocus: { id: string } | undefined = undefined; for (const node of event.composedPath()) { if (node instanceof HTMLElement && node.classList.contains('output')) { outputFocus = { id: node.id }; break; } } </del> <ins> const outputFocus = lastFocusedOutput = getOutputContainer(event); </ins> for (const node of event.composedPath()) { if (node instanceof HTMLAnchorElement && node.href) { if (node.href.startsWith('blob:')) {

Discussion:
Repro: 3 cells the middle one the empty space at the bottom of the notebook undo it doesn't work, clicking in between cells does work though
Specifically, undo only works when focused on a cell container. Focus within a cell (code or markdown) editor and in the notebook editor both do not handle the undo.