jiebi/CodeConvo huggingface dataset:
Change:
} if (selectedExtension?.command?.uri) { <del> issueUrl = selectedExtension.command.uri; </del> <ins> const uri = URI.revive(selectedExtension.command.uri); issueUrl = uri.toString(); </ins> } const gitHubDetails = this.parseGitHubUrl(issueUrl);

Discussion:
Testing It seems weird to pass in string when you could just pass in a Uri. Better yet, consider
I think when I was testing, URI wasn't serializable so it wouldn't be passed thru the command properly - will double check this soon though
you may need to turn it into a and then that on the other end. It's possible. We do it with other processes.
Change:
} } <ins> /** * Notify that an output may have been swapped out without the model getting rendered. */ flagAsStale() { this._hasStaleOutputs = true; } </ins> private _doRender() { if (this.viewCell.outputsViewModels.length > 0) { if (this.viewCell.layoutInfo.outputTotalHeight !== 0) {

Discussion:
Type: <bBug</bWhen a notebook updates text in a collapsed cells unexpected things happen. The Jupyter Notebook renders the output while still showing that the output is collapsed. Node.JS Notebooks and httpBook show empty cells and will only show the output again when expanded, collapsed, expanded again In the the result looks like this: ! Issue created to hopefully follow up Extension version: 2023.9. VS Code version: Code 1.83.1 (Universal) (, 2023-10-10T23:46:55.789Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
return this._statusBar.hoverElement; } <ins> get actions(): HoverAction[] { return this._statusBar.actions; } </ins> dispose() { this._statusBar.dispose(); }

Discussion:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!
Change:
} } <del> private variables: ITitleVariable[] = []; </del> <ins> private readonly variables = new Map<string, ITitleVariable>(); </ins> registerVariables(variables: ITitleVariable[]): void { <del> this.variables.push(...variables); </del> <ins> const newVariables: ITitleVariable[] = []; for (const variable of variables) { if (!this.variables.has(variable.name)) { this.variables.set(variable.name, variable); newVariables.push(variable); } } </ins> for (const part of this.parts) { <del> part.registerVariables(variables); </del> <ins> part.registerVariables(newVariables); </ins> } }

Discussion:
Currently, allows several variables. It would be awesome for extensibility, if would be supported, with being an arbitrary context variable. Then extensions could contribute to the window title (candidates would be or ). I'd be up to create a PR! Related:
Sounds interesting, feel free to give it a try. The variables are substituted from here:
anyone assign me pls
Verification steps: an extension, create a contxt key and register a title variable to in settings and add the newly created title variable (for example ) sure the window title correctly renders the value of the variable in the command center / window title area
Change:
"resolved": "https://registry.npmjs.org/semver/-/semver-4.3.6.tgz" }, "typescript": { <del> "version": "2.1.4", "from": "typescript@2.1.4", "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.1.4.tgz" </del> <ins> "version": "2.1.5-insiders.20161213", "from": "typescript@2.1.5-insiders.20161213", "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.1.5-insiders.20161213.tgz" </ins> }, "vscode-extension-telemetry": { "version": "0.0.5",

Discussion:
VSCode Version: 1.7.2 OS Version: Ubuntu 16.04 I have yet to find out how to reproduce this, but VS Code creates a Microsoft/TypeScript/node_modules/ directory with the types-registry npm module in it in the home directory. The package readme says This is the source code for the types-publisher service, which publishes the contents of DefinitelyTyped to npm. I never set anything to be shared or published. So what exactly is this and what does it do?
Steps to reproduce: VS Code any JavaScript file It only happens for the first JS file that is opened. Could be a bug, too.
I guess this is from the automatic typings acquisition in recent versions of TypeScript. Are you saying the folder is under ?
is correct - this is location of global cache for acquired type declarations. These files are downloaded on user machine to power JavaScript intelligence and never uploaded anywhere.
What are the paths that are used for this cache on the different platforms? I think on Linux it might make sense to used a folder name with a leading '.' to hide it from default and file explorer behavior - like other tools do. /cc
Now that you mention this I have this too. We should absolutely not be putting the types in . would probably make the most sense, where defaulting to if it is not defined as per the . I'm proposing instead of to prevent potential future conflicts. this is actually quite bad imo, is this a purely upstream problem?
This issue was moved to Microsoft/TypeScript
Let's keep this open on vscode to track it. I'd like to mention the fix in release notes when it comes.
This is going into TypeScript 2.2, so we will not be picking it up in VSCode 1.8. You can install a TS 2.2 insiders build to your workspace to work around this for now.
Change:
} private getCharCountText(charCount: number): string { <del> let remaining = FeedbackDropdown.MAX_FEEDBACK_CHARS - charCount; </del> <ins> let remaining = this.maxFeedbackCharacters - charCount; </ins> let text = (remaining === 1) ? nls.localize("character left", "character left") : nls.localize("characters left", "characters left");

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?
Change:
function deleteWordEndRight(editor: ICodeEditor): void { runEditorCommand(editor, _deleteWordEndRight); } <ins> function deleteInsideWord(editor: ICodeEditor): void { runEditorCommand(editor, _deleteInsideWord); } </ins> test('cursorWordLeft - simple', () => { const EXPECTED = [

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The 'deleteWordLeft' command cannot delete letters on right side of the cursor. We want new function which can delete the whole word. (We submit this issue formally. Sorry.)
To verify, please look for a "Delete Word" action that you can bind to a keybinding if you wish to. The action will delete the current word under the cursor (both to the left and to the right of the cursor) and will delete any trailing whitespace.
I've checked. I could find the "Delete Word" action and bind a keybinding to it. The function works properly. Thank you!
Change:
this.element.style.setProperty('--zoom-factor', zoomFactor.toString()); this.rootContainer.classList.toggle('counter-zoom', this.useCounterZoom); <del> runAtThisOrScheduleAtNextAnimationFrame(() => this.adjustTitleMarginToCenter()); </del> if (this.customMenubar) { const menubarDimension = new Dimension(0, dimension.height); this.customMenubar.layout(menubarDimension); } <ins> runAtThisOrScheduleAtNextAnimationFrame(() => this.adjustTitleMarginToCenter()); </ins> } }

Discussion:
Not too sure what caused this, but I reloaded my window and it seemed to show an overlap on the title bar ]() Feel free to close if this isn't enough info to file a bug.
Thanks for filing, I couldn't repro myself, but I'm going to leave this open in case others see the same and can provide more info. Also DENDRON!
Thanks for creating this issue! We figured it's missing some basic information, such as a version number, or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
I think I have more info about the bug? Seems that I can reproduce it when I'm really zoomed in and going from window to maximized. I also seem to recreate it easier when I'm on an extension page. !
yep, 100% repro, thanks a ton!
this is a regression, so adding as candidate
This happens because before maximizing, the hamburger is shown and after, the menu should have enough space, but title section does not get the memo and doesn't get out of the way
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I was not able to reproduce the original issue.
I can reprouce this on 1.70.1 stable (). Is it supposed to be fixed on Insiders?
Change:
} */ this._telemetryReporter?.sendTelemetryEvent('login', { <del> scopes: JSON.stringify(sortedScopes), </del> <ins> scopes: JSON.stringify(scopes), </ins> }); const scopeString = sortedScopes.join(' '); const token = await this._githubServer.login(scopeString); <del> const session = await this.tokenToSession(token, sortedScopes); </del> <ins> const session = await this.tokenToSession(token, scopes); </ins> this.afterSessionLoad(session); const sessions = await this._sessionsPromise;

Discussion:
Issue Type: <bBug</bThe Avatar badge always shows <img width="351" alt="image (7)" src="https://user-"Clicking the action to authenticate doesn't dismiss it. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-20T05:16:17.334Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (39)</summaryExtensionVersion ------ vscode-eslint2.2.2 kusto0.3.8 gitlens-insiders2022.5.1705 prettier-vscode9.5.0 codespaces1.8.1 copilot1.22.5957 vscode-pull-request-github0.42.0 go0.33.0 vscode-language-pack-zh-hans1.68.0 python2022.7. vscode-pylance2022.5.2 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 vscode-ai0.11. vscode-ai-remote0.13. remote-containers0.236.1 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.3 azure-account0.10.1 hexeditor1.9.6 js-debug-nightly2022.5.1817 live-server0.2.12 vscode-github-issue-notebooks0.0.119 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.9 vsliveshare1.0.5561 vetur0.35.0 colab-keymap0.0.4 github-issue-notebook-enhancement0.0.1 vscode-code-renderer0.0.2 vscode-jupyter-checkpoint0.0.1 notification-tester2.5.1 rest-book6.0.1 tldraw-vscode1.13.3 shell-runner-notebooks0.0.2 luna-paint0.14.0 vscode-todo-highlight1.0.5 (3 theme extensions excluded) </details<!-- generated by issue reporter --
after reloading, does the go away?
Reloading fixes the issue for me
Change:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService'; import { INativeEnvironmentService } from 'vs/platform/environment/common/environment'; <del> import { ExtensionVerificationStatus } from 'vs/platform/extensionManagement/common/abstractExtensionManagementService'; import { ExtensionManagementError, ExtensionManagementErrorCode, getTargetPlatform, IExtensionGalleryService, IGalleryExtension, IGalleryExtensionAssets, ILocalExtension } from 'vs/platform/extensionManagement/common/extensionManagement'; </del> <ins> import { getTargetPlatform, IExtensionGalleryService, IGalleryExtension, IGalleryExtensionAssets, ILocalExtension } from 'vs/platform/extensionManagement/common/extensionManagement'; </ins> import { getGalleryExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil'; import { IExtensionsProfileScannerService } from 'vs/platform/extensionManagement/common/extensionsProfileScannerService'; import { IExtensionsScannerService } from 'vs/platform/extensionManagement/common/extensionsScannerService';

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log
Change:
primaryAction = actions.find(a => a.id === lastActionId) ?? actions[0]; } <ins> if (primaryAction && primaryAction.id !== SCMInputCommandId.CancelAction && contextKeyService.getContextKeyValue(SCMInputContextKeys.ActionIsEnabled.key) === false) { primaryAction.enabled = false; } </ins> this._ctxActionCount.set(actions.length); this._dropdownActions = actions.length === 1 ? [] : actions; container.classList.toggle('has-no-actions', actions.length === 0); <del> container.classList.toggle('disabled', contextKeyService.getContextKeyValue(SCMInputContextKeys.ActionIsEnabled.key) !== true); </del> super.setActions(primaryAction ? [primaryAction] : [], []); };

Discussion:
keyboard focus to SCM generate commit message button the nice blue outline being rendered hover over the button. The outline is no longer visible
Is the button enabled or disabled? I am asking as from what I can tell the pattern is that for enabled buttons the focus outline is not persisted when the button is hovered over. Disabled buttons persist the focus outline as they do not have a hover.
Reopening as I implemented the wrong fix.
The button is enabled. I noticed that in the Find Widget for example the focus outline is persisted on hover. Which imho is the natural thing to do.
With the PR linked above, the behaviour will be consistent with the rest of the actions. We can start a separate conversation whether we want to update all actions to keep the focus border on hover.
Change:
private fetchWorkspaceRecommendations(): TPromise<void> { this._workspaceIgnoredRecommendations = []; <del> this._allWorkspaceRecommendedExtensions = []; </del> <ins> const tmpAllWorkspaceRecommendations = []; </ins> if (!this.isEnabled) { return TPromise.as(null); }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --In most recent insiders. <!-- Use Help Report Issue to prefill these. --Steps to Reproduce: " a few times, sometimes extensions will show up, but not have their badge. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
This may only be an issue in multi-root workspaces
Change:
let context = createContext({ 'a': true, 'b': false, <del> 'c': '5' </del> <ins> 'c': '5', 'd': 'd' </ins> }); function testExpression(expr: string, expected: boolean): void { <ins> console.log(expr + ' ' + expected); </ins> let rules = ContextKeyExpr.deserialize(expr); assert.equal(rules.evaluate(context), expected, expr); }

Discussion:
VSCode Version: 1.12.0 OS Version: MacOS Sierra 10.12.4 In , we'd like to be able to provide context menus for all gradle files. The current clause is limited to language types () or a single file name (). It would be helpful if there was support for glob pattern matching, as mentioned in
Hi, Any update on this?
I will push an additional change that expands this to support normal regular expressions instead of just glob-patterns. We figured that's more powerful and closer to ST
Will this be usable in matching any when clause value? Can you give an example?
You write , so will execute this . A sample from my dummy extensions (matches filenames ending in )
This is AWESOME! Should reduce the number of duplicate menu items I need to define
Slight update on this: The value must be enclosed in slashes, so . I have updated above sample
FYI: I tried to apply this feature to the "loaded script view" by following the entry in the release notes: ! But without much success. After looking into the test item and the corresponding feature item, I noticed that the latest syntax uses regular regexp syntax. I've taken the liberty to change the release notes to this: ! I did not attempt to clarify why actually matches "Docker files".
Hmm, I am writing a simple extension, and would like to copy any resourceName. It works without any when clause, but the menu item also shows up, when r-clicking inside the empty space. I would like to prevent it. Is there something like this ?
Ok I found . And its actually what I was looking for. But I did not found it in the docs, but code base.
Change:
} } <del> if (!opts) { opts = { all: noStagedChanges }; } else if (!opts.all && noStagedChanges && !opts.empty) { opts = { ...opts, all: true }; } </del> // no changes, and the user has not configured to commit all in this case <del> if (!noUnstagedChanges && noStagedChanges && !enableSmartCommit && !opts.empty) { </del> <ins> if (!noUnstagedChanges && noStagedChanges && !enableSmartCommit && !opts.empty && !opts.all) { </ins> const suggestSmartCommit = config.get<boolean>('suggestSmartCommit') === true; if (!suggestSmartCommit) {

Discussion:
Issue Type: <bBug</bWhen I drill down into the git menu and choose the option to , I really don't need the same confirmation dialog as when I just hit the top-level check mark in the source control pane. The dialog tells me ; this is an incorrect warning at this stage, since I clearly invoked it by choosing . I certainly don't want to choose the option in response to this warning, since it's a good warning to have when I accidentally hit the checkmark without staging any changes. VS Code version: Code 1.67.0 (, 2022-05-04T12:14:47.100Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Change:
"command.compare": "Compare Current Conflict", "config.title": "Merge Conflict", "config.autoNavigateNextConflictEnabled": "Whether to automatically navigate to the next merge conflict after resolving a merge conflict.", <del> "config.codeLensEnabled": "Create a Code Lens for merge conflict blocks within editor.", </del> <ins> "config.codeLensEnabled": "Create a CodeLens for merge conflict blocks within editor.", </ins> "config.decoratorsEnabled": "Create decorators for merge conflict blocks within editor.", "config.diffViewPosition": "Controls where the diff view should be opened when comparing changes in merge conflicts.", "config.diffViewPosition.current": "Open the diff view in the current editor group.", "config.diffViewPosition.beside": "Open the diff view next to the current editor group.", "config.diffViewPosition.below": "Open the diff view below the current editor group." <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --- VSCode Version: 1.44 Insiders OS Version: Windows 10 CodeLens should be one word. The new command display name should be changed from: "Show Code Lens Commands For Current Line" to: "Show CodeLens Commands For Current Line"
Change:
abstract class BaseResizeViewAction extends Action2 { <del> protected static readonly RESIZE_INCREMENT = 6.5; // This is a media-size percentage </del> <ins> protected static readonly RESIZE_INCREMENT = 60; // This is a css pixel size </ins> protected resizePart(widthChange: number, heightChange: number, layoutService: IWorkbenchLayoutService, partToResize?: Parts): void {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The resize steps when using the / commands / shortcuts are pretty heavy. Being a keyboard driven navigator through the editor I would love to have an option to determine the step size for those commands, because I think this way no users would need to compromise. If it's needed, I would put my bit of work into that if you would like to have such an option. Even if there shall not be an option, it would be marvelous of you to reduce the current default step size by just 1 percent. This keeps it still fairly big if someone prefers those step sizes but already allows more precise resizing with the keyboard so the view / splits can fit one's needs. Basically: to Imho even smaller step sizes would be better
seems like a fair request
After thinking about this, I decided to move away from using view percentage increments. Instead, we now use css px units so that the resize increments are consistent. The newly chosen increment size is ~equivalent to 5.5% of a 1080px width monitor.
Great to read. Thank you!
I run vscode on a 27" 1440p monitor in vertical orientation, and after a recent vs code upgrade now my command is increasing the terminal height by only 1 line, instead of ~10 lines like before. Is that expected from this change? The size increase now feels very small, and I'm retraining my fingers to expand the terminal directly to full-screen (Ctrl+Shift+Q) instead of expanding the terminal 4 or 5 times (Ctrl+Cmd+Up). Now, to use (Ctrl+Cmd+Up) I'd have to press ~40 to ~50 times (or hold) to get it to a mostly-expanded size.
I'm not a vscode maintainer but what I can tell: To meet your needs with the current implementation, you could map the keybinding you used to use to a multi-command or macro. Using the corresponding vscode extension / .That way you could control the exact resize step amount. that make it sounds like a tough thing to do ‍. As far as I could tell until now a human brain should be able to do it in a few minutes or a handful of repetitions .
Change:
import { ITypeScriptServiceClient } from '../typescriptService'; import { Delayer } from '../utils/async'; import * as languageModeIds from '../utils/languageModeIds'; <ins> import * as fileSchemes from '../utils/fileSchemes'; </ins> interface IDiagnosticRequestor { requestDiagnostic(filepath: string): void;

Discussion:
VSCode Version: Code 1.19.1 (, 2017-12-19T09:46:02.926Z) OS Version: Windows_NT ia32 10.0. Extensions: Extensions are disabled Steps to Reproduce: / Interactive Playground Under heading IntelliSense, the text reads: It it unclear what error underline means, I don't see any underline or error.
I can reproduce on the 2nd time: playground tab playground No errors shown & IntelliSense not working & rename & code formatting & // ts-check ...
Yes, opening playground a second time seems to be key to all the problems I was having with it. Thanks.
VSCode Version: Code - Insiders 1.20.0-insider (, 2017-12-22T06:14:07.615Z) OS Version: Linux x64 4.9.72-1-lts Extensions: none Also happens every time for me in Interactive Playground with no extensions loaded w/ insiders on linux. If restarting vscode repeatedly, sometimes syntax highlight also fails. EDIT: As I continued on down through the document, some other instructions are failing too.
VSCode Version: Code 1.19.1 (, 2017-12-19T09:35:14.671Z) OS Version: Darwin x64 16.7.0 Extensions: none I just got VSCode for the first time, fresh install on macOS, and experienced the same issue with different features in the Interactive Playground described here by the peeps above. Don't have much to add in terms of describing/reproducing the issue, just posting here for completeness that the issue affects 1.19.1 on OSX as well.
I see this when opening without a folder. The missing errors also reproduce in an untitled file in JavaScript mode (code actions seem to work in this case). Code actions do not work in the interactive playground when the workbench is not open on a folder. Could you take a look?
Note that this still requires this upstream fix from TS ()