jiebi/CodeConvo huggingface dataset:
Change:
viewController.emitKeyDown(standardKeyboardEvent); })); this._register(addDisposableListener(this.domNode.domNode, 'beforeinput', async (e) => { <del> if (e.inputType === 'insertParagraph') { </del> <ins> if (e.inputType === 'insertParagraph' || e.inputType === 'insertLineBreak') { </ins> this._onType(viewController, { text: 'n', replacePrevCharCnt: 0, replaceNextCharCnt: 0, positionDelta: 0 }); } }));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.95.0-insider OS Version: Windows 11 Steps to Reproduce: : window to message and use <kbdShift</kbd+<kbdEnter</kbd<kbdShift</kbd+<kbdEnter</kbddoes not work in Source control message text area if option is enabled. It seems that it occurs not only in but also when I edit any file. <hrMaybe related to
I see thank you for filing this issue. I will look into it.
Hi may I ask you what you were expecting to see? I turned the setting on and off and press when I have no commits to make and a notification pops up mentioning that I have no changes to commit. Thank you.
Hi, thank you for checking it out. I expect that a new line will be , the same as with just pressing <kbdEnter</kbd. By the way, the same issue occurs when I edit a file.
Hi thank you for clarifying the question, yes I am able to reproduce this behavior. This happens because we don't send a new line event when we receive the event. I will make a PR to fix this.
Change:
// not a failure case } } <del> if (typeof extensionManifest.activationEvents === 'undefined') { validations.push([Severity.Error, nls.localize('extensionDescription.main3', "properties `{0}` and `{1}` must both be specified or must both be omitted", 'activationEvents', 'main')]); return validations; } </del> } if (typeof extensionManifest.browser !== 'undefined') { if (typeof extensionManifest.browser !== 'string') {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.77.0-insider (Universal) Commit: Date: 2023-03-09T05:22:33.512Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin arm64 22.3.0 Sandboxed: Yes Steps to Reproduce: . ! Other Notes: fine in v1.76.0, seems like a regression bug. fix this ASAP, as it could break many extensions in the next stable release.
Same happening on some of my extensions, as I embraced (released in v1.74) and the fix in (), but now, are not enabled in Insiders.. Any ETA for the fix, or should I revert my extensions and bring back in the meantime? Thank you
Change:
}); suite('Code block renderer', () => { <del> const simpleCodeBlockRenderer = (code: string): Promise<HTMLElement> => { </del> <ins> const simpleCodeBlockRenderer = (lang: string, code: string): Promise<HTMLElement> => { </ins> const element = document.createElement('code'); element.textContent = code; return Promise.resolve(element);

Discussion:
In the it says: It then gives : Although the spec does not mandate it, it would be nice if VS Code supported this format. Currently, adding more than just the language identifier after the backticks results in the code note rendering as code: ts const a = new MyClass(); ts foo const a = new MyClass(); <img width="473" alt="Screenshot 2022-08-10 at 15 32 18" src="https://user-"
This already is supported for Markdown highlighting and in markdown previews: ! Is this about support in too?
I don't know what's being used internally by the TS integration above, but I think it should work anywhere that VS Code is already handling these code blocks (my example above was hovers, but things like code completion documentation and other places that support code blocks should be the same - a lot of this content comes from external sources so there's benefit in VS Code being as compatible with what they may use as possible).
Change:
return encodeURI(attr).replaceAll('"', '&quot;'); } <del> function escapeMarkdownLinkPath(mdPath: string): string { </del> <ins> function escapeMarkdownLinkPath(mdPath: string, isExternalLink: boolean): string { </ins> if (needsBracketLink(mdPath)) { return '<' + mdPath.replaceAll('<', '<').replaceAll('>', '>') + '>'; } <del> return encodeURI(mdPath); </del> <ins> return isExternalLink ? mdPath : encodeURI(mdPath); </ins> } function escapeBrackets(value: string): string {

Discussion:
Type: <bBug</b( it into a markdown file Bug The inserted markdown link is not valid because of the mismatched parens In cases like this, we can either escape the with or wrap the entire url in : VS Code version: Code - Insiders 1.81.0-insider (Universal) (, 2023-07-25T08:15:40.243Z) OS version: Darwin x64 22.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
! looks correct in that it displays with but the rightmost parenthesis is still highlighted red. Is this the desired behavior
Can you please open a new issue for that? I think bracket pair colorization isn't working properly in this case (the markdown grammar seems to get it right)
Change:
export type VariableResolver = (str: string) => string; <del> export function createVariableResolver(lastActiveWorkspace: IWorkspaceFolder | undefined, configurationResolverService: IConfigurationResolverService | undefined): VariableResolver | undefined { </del> <ins> export function createVariableResolver(lastActiveWorkspace: IWorkspaceFolder | undefined, env: IProcessEnvironment, configurationResolverService: IConfigurationResolverService | undefined): VariableResolver | undefined { </ins> if (!configurationResolverService) { return undefined; } <del> return (str) => configurationResolverService.resolve(lastActiveWorkspace, str); </del> <ins> return (str) => configurationResolverService.resolveWithEnvironment(env, lastActiveWorkspace, str); </ins> } /**

Discussion:
With we are trying to remove from the configuration resolver service. The new way to get the environment is async and requires that the all the configuration resolver methods be async. I have started the adoption of the new async methods in , but there's one use in terminal that looks like it will require more work: Option 1: Convert that use of to use . Option 2: I provide a new method on the configuration resolver service that is sync, but requires you to pass in your own . Which option makes the most sense here?
I think the usage of in must remain sync since it's used as part of the extension API. Is this a problem there since is fine to use? The main purpose of this type was to share code between variable processes.
Sounds like Option 2 is the way to go then. I will add a new method that is sync and lets you pass in your own .
Added: will that let you keep your code reuse?
Change:
type: AccessibleViewType; } <del> export const accessibilityHelpIsShown = new RawContextKey<boolean>('accessibilityHelpIsShown', false, true); export const accessibleViewIsShown = new RawContextKey<boolean>('accessibleViewIsShown', false, true); </del> class AccessibleView extends Disposable { private _editorWidget: CodeEditorWidget; private _accessiblityHelpIsShown: IContextKey<boolean>;

Discussion:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
resolveConfigurationByProviders(folderUri: uri | undefined, type: string | undefined, debugConfiguration: any, token: CancellationToken): Promise<any>; } <del> export enum DebuggerUiMessage { </del> <ins> export enum DebuggerString { </ins> UnverifiedBreakpoints = 'unverifiedBreakpoints' }

Discussion:
Continuing This is just a flag in Example: In this case, vscode is in control of when and where to show this message.
Is a good name? Drop the ?
If I see some "messages" related to a debugger, I first think of something like DAP messages. I would only use this property to drive some feature in the UI and it feels good to tie it to that. But if feels awkward I don't have a strong opinion.
Change:
return Promise.resolve<Task[]>([]); } <del> return this._getGroupedTasks(filter, false).then((map) => this.applyFilterToTaskMap(filter, map)); </del> <ins> return this._getGroupedTasks(filter, true).then((map) => this.applyFilterToTaskMap(filter, map)); </ins> } public taskTypes(): string[] {

Discussion:
a repo in :bug: see this !
This is expected if the repo that you open has tasks that run on . Could you pls provide me with a repo for which this happens that doesn't have those?
seeing this dialog when I just open a folder, so wondering if something with workspace trust has changed recently. No changes with tasks recently could explain this. !
Doesn't repro in , repros in : Bad: Good:
found these task PRs in that time frame: ,
found it also happens in an empty window on desktop
Still seeing this in (and also RemoteHub on desktop) with the changes in !
This is coming from -here. perhaps we don't want to do that for the or only do that in trusted workspaces? !
Change:
} } <del> export class CollapseAllAction extends TreeCollapseAction { </del> <ins> export class CollapseDeepestExpandedLevelAction extends Action { private viewer: ITree; </ins> <del> constructor(viewlet: SearchViewlet) { super(viewlet.getControl(), false); </del> <ins> constructor(viewlet: SearchViewlet, enabled: boolean = false) { super('vs.tree.collapse', nls.localize('collapse', "Collapse"), 'monaco-tree-action collapse-all', enabled); this.viewer = viewlet.getControl(); </ins> this.class = 'search-action collapse'; } <ins> public run(context?: any): TPromise<any> { if (this.viewer.getHighlight()) { return TPromise.as(null); // Global action disabled if user is in edit mode from another action } this.viewer.collapseDeepestExpandedLevel(); this.viewer.clearSelection(); this.viewer.clearFocus(); this.viewer.DOMFocus(); this.viewer.focusFirst(); return TPromise.as(null); } </ins> } export class ClearSearchResultsAction extends Action {

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
import * as typeConverters from './utils/typeConverters'; import TypingsStatus, { AtaProgressReporter } from './utils/typingsStatus'; import VersionStatus from './utils/versionStatus'; <ins> import { flatten } from './utils/arrays'; </ins> // Style check diagnostics that can be reported as warnings const styleCheckDiagnostics = [

Discussion:
tsserver could provide a list of languages so that when a document other than and is opened, the plugins would be notified. Angular language service relies on this to parse files in Angular templates. There seems to be a regression whereby languages provided by tsserver plugins are no longer synced (does not have buffer sync support). This was brought to light by in For potential fix, please see cc:
Related We only prototyped the support for external languages in TypeScript so this is not really an official API. You'd have to check with the TS team to see if this is still something they are interested in properly supporting as there is other work required beyond this
I merged a pr that fixes this so you can test it and provide feedback, but you must not ship anything to customers that relies on this API. It is not official and may be changed or be removed at any point in the future
Thanks for the update. I'll test it out locally. I'd like to organize a meeting to finalize the design with the Typescript team, so that we can move on with the implementation.
Change:
// Exclude some very common files from the dock/taskbar private static readonly COMMON_FILES_FILTER = [ 'COMMIT_EDITMSG', <del> 'MERGE_MSG' </del> <ins> 'MERGE_MSG', 'git-rebase-todo' </ins> ]; private readonly macOSRecentDocumentsUpdater = this._register(new ThrottledDelayer<void>(800));

Discussion:
Originally posted by in Currently, and don't work for : ! Please add support.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
I think this feature request is pretty basic, from my past experience, issues moved to the backlog candidate most likely get closed, could you please consider moving it to the backlog?
Hello, and I would like to start working in this. If moved to the backlog, could this issue be assigned to us? Thank you!
I wonder if the example above falls into the category of this filter which we maintain already: The idea here being to not automatically add git related files to the history. Is your case any special in terms of git operations?
I use a lot, should also be filtered out from , since they are only temporary files: !
Yeah that sounds reasonable to me, feel free to add it as PR.
duplicate of ?
related:
this FR is for the "File" "Open Recent" "More..." picker. I actually think can be closed as fixed for March already, I commented.
See
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Is this released in 1.90.2? If it is, I think the PR didn't solve this issue.
Yes, this was part of the 1.90.x release.
Thanks, perhaps reopen this issue? I just tried, the issue still exists.
It works for me:
Can you please try , then the rest?
Same
Change:
export const notebookRendererExtensionPoint = ExtensionsRegistry.registerExtensionPoint<INotebookRendererContribution[]>({ extensionPoint: 'notebookRenderer', <del> jsonSchema: notebookRendererContribution </del> <ins> jsonSchema: notebookRendererContribution, activationEventsGenerator: (contribs: INotebookRendererContribution[], result: { push(item: string): void }) => { for (const contrib of contribs) { if (contrib.id) { result.push(`onRenderer:${contrib.id}`); } } } </ins> }); export const notebookPreloadExtensionPoint = ExtensionsRegistry.registerExtensionPoint<INotebookPreloadContribution[]>({

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Extensions which contribute notebook renderers must declare in , this can be inferred for extension authors by specifying the . See also (Note, this would require adoption in the notebook renderers extension as well, which currently activates : )
Change:
import { IMenuService, IMenu } from 'vs/platform/actions/common/actions'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import sinon = require('sinon'); </del> import { timeout } from 'vs/base/common/async'; import { DisposableStore } from 'vs/base/common/lifecycle'; import { CompletionItemKind, CompletionItemProvider, CompletionProviderRegistry } from 'vs/editor/common/modes';

Discussion:
I used blame to find the owner of inline completions. Who should this be assigned to?
Looks like you did that wrong <img width="826" alt="Screen Shot 2021-07-12 at 12 53 21" src="https://user-"
From slack: I found the real issue of the flaky unit test. Apparently, some test that runs before the inline suggestion test (which fakes /) calls . spawns a (5 seconds) that calls itself (basically an endless loop over time). When the time is faked, my inline completion test waits for all scheduled timers to finish until the queue of scheduled timers is empty (assuming I am in control of all scheduled timers when my test is run). However, the loop in then causes an endless loop. My test gives up after running 1000 scheduled timers and I guess then things are in an inconsistent state. This only happens when my tests are run right before is about to run. If my tests a run in the 5s interval in which is not called, nothing bad happens. As a quick fix, I will change my tests to not wait for the timer queue to get empty. As a long term fix, I think tests should be isolated better - at least they should make really sure they clean up everything (such as disposables/timers/global handlers/etc.). Joh tracked this down to this leaking disposable:
Change:
// Configure static command line arguments const argvConfig = configureCommandlineSwitchesSync(args); <ins> // Remove env set by snap https://github.com/microsoft/vscode/issues/85344 if (process.env['SNAP']) { delete process.env['GDK_PIXBUF_MODULE_FILE']; delete process.env['GDK_PIXBUF_MODULEDIR']; } </ins> /** * Support user defined locale: load it early before app('ready') * to have more things running in parallel.

Discussion:
Issue Type: <bBug</bnew Ubuntu 19.10 install. Comes with firefox installed and set as default browser. VSCode from "ubuntu software". any link inside of VSCode, for example HelpTips and Tricks. crashes. VS Code version: Code 1.40.1 (, 2019-11-13T16:49:30.162Z) OS version: Linux x64 5.3.0-23-generic snap <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
I followed ctaggart's workaround () and was able to resolve this issue. and purge the current installation and install the deb package from
Had same issue with code installed with a . Installed it as deb package fixed issue too.
This is the same underlying cause as has pointed out the root cause in Crash is gone after unsetting the following env:
I have a LDPRELOAD related solution I can share (which wouldn't touch code's code), but if on launch those can be unset if code or code-insiders is in "SNAPNAME", that should solve the problem too.
On Ubuntu 19.10 uninstalling the "Firefox Web Browser" pre-installed deb package and installing the package named as just "Firefox" (packaged as a snap by Mozilla itself) on the Ubuntu Software store did the trick.
Advice from snapcraft team: this should be fixed by removing the following environment variables after start up:
Change:
@ILifecycleService private readonly lifecycleService: ILifecycleService, @IStorageService private readonly storageService: IStorageService, @IActivityService private readonly activityService: IActivityService, <ins> @IEditorService private readonly editorService: IEditorService, </ins> ) { super();

Discussion:
Testing I wonder if we should run the command to save all files (not untitled files) before triggering the "Continue on" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?
I am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !
Should we say here? !