jiebi/CodeConvo huggingface dataset:
Change:
border-spacing: 13px 17px; } <del> @keyframes watermarkfadein { 0% { opacity: 0; } 33% { opacity: 0; } 100% { opacity: 1; } } </del> @media (min-height: 501px) { .monaco-workbench > .part.editor.empty > .watermark { <del> animation: watermarkfadein 2s; opacity: 1; transition: opacity 1s; </del> <ins> display: block; </ins> } } @media (max-height: 500px) { .monaco-workbench > .part.editor.empty > .watermark { <del> opacity: 0; </del> <ins> display: none; </ins> } <del> .monaco-workbench .part.editor.empty { </del> <ins> .monaco-workbench .part.editor.empty.has-watermark { </ins> background-position-y: 50%; } }

Discussion:
The empty document well animations (infinity icon motion, text fade in) make the tool feel slow, as if it can't keep up with me resizing the window. If i make the windows smaller, the text disappears and then the icon catches up with me. When i make the window larger, the icon motion is behind my resizing gesture, and eventually the text fades in. All of these visuals happen after i make a resize gesture, which makes me feel like the tool can't keep up, like something is happening in the background, and I should wait for it. it is distracting too, it always catches my eye and then I lose my context. VS Code is lightweight and fast. The UI should feel snappy, not delayed. We don't animate in search results or when we open a file. Quick Open is instantaneous. Async queries in the Extensions viewlet show me a progress bar immediately. Why then does our desktop resize animate behind my gestures? CC
I have exactly the same feeling.
Remove animation completely (make it snap in/out instantly with no transition) Reduce the latency and duration of the animation by say 75% (.25 seconds vs. 1 second) Make the tips dismissible with an affordance for people who don't like it (thus animation would not apply) Remove logo entirely and center the tips at all times. One other thing we discussed in UX sync today was that the tips seem more important than the logo (function over form). So why are we hiding the tips and not the logo at small window heights? Since we don't want to invalidate Sean's experiment, we will not attempt to change anything in product in October iteration, but we can figure out what our next move is and make the change in November.
Removed all animations/transitions in my PR linked above.
Change:
} // the actual key <del> result.push(key); </del> <ins> if (key !== '') { result.push(key); } </ins> return result.join(labels.separator); }

Discussion:
Issue Type: <bBug</bWhen using screencast mode, if you press a sequence of keys such as "Ctrl" + "Alt", Visual Studio Code adds an extra + at the end of the sequence. ! VS Code version: Code 1.42.1 (, 2020-02-11T14:45:59.656Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ 30-seconds-of-code1.0.0 better-comments2.0.5 Bookmarks11.0.0 vscode-color0.4.5 bracket-pair-colorizer1.0.61 javascript-ejs-support1.3.1 vscode-npm-script0.3.11 vsc-material-theme32.5.0 vsc-material-theme-icons1.1.4 php-intellisense2.3.14 vscode-mocha-test-adapter2.2.2 vscode-test-explorer2.17.0 python2020.2. remote-wsl0.42.3 vsliveshare1.0.1653 material-icon-theme3.9.3 java0.57.0 vscode-xml0.10.1 code-settings-sync3.4.3 vscode-spotify3.1.0 java-generate-setters-getters5.3.0 code-spell-checker1.7.24 vscodeintellicode1.2.5 vscode-java-debug0.25.0 vscode-java-dependency0.9.0 vscode-java-pack0.8.1 vscode-java-test0.22.1 vscode-maven0.21.0 change-case1.0.0 vscode-wpilib2020.2.2 viml0.0.2 material-theme3.2.3 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Isn't this an expected behavior? As it only happens with keys that can be used in combinations (Alt, Ctrl, Shift, Win ecc;)
Well I felt like that if I just press Ctrl and Alt it should say Ctrl+Alt instead of Ctrl+Alt+ as if some other letter had been pressed
Also, I can work on this issue if necessary
Verification: (Windows only) Enable Press and confirm that is displayed on the screen and not . Press and confirm that is displayed on the screen.
Change:
maxHeight = Math.min(maxHeight, this._hover.containerDomNode.clientHeight); this._hover.containerDomNode.style.maxHeight = `${maxHeight}px`; <ins> if (this._hover.contentsDomNode.clientHeight > maxHeight) { this._hover.contentsDomNode.style.height = `${maxHeight}px`; } if (this._hover.contentsDomNode.clientHeight < this._hover.contentsDomNode.scrollHeight) { // Add padding for a vertical scrollbar const extraRightPadding = `${this._hover.scrollbar.options.verticalScrollbarSize}px`; if (this._hover.contentsDomNode.style.paddingRight !== extraRightPadding) { this._hover.contentsDomNode.style.paddingRight = extraRightPadding; } } </ins> } private setHoverPointerPosition(target: TargetRect): void {

Discussion:
Does this issue occur when all extensions are disabled?: No VS Code Version: 1.73.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: ! to the extension bar. to hover some items. Some one may not show the default scroll bar, but the problem is exists. ! I have tried to fix it. It seems caused by the visual bug from the issue . The scroll bar will show when the content is too long. This solution is great, but it causes another little bug in the screenshot. I think it's unwise to remove the tag, so I tried another way, just add to the tag : ! I'll make a PR after this issue has submitted.
I can't reproduce this srollbar for all extensions in the list: !
This bug is not 100% recurring. Some extensions' descriptions may just exceed the calculated.
What's ur testing extension id?
These extensions have the problem on my machine.
! !
Maybe it's related to high-resolution screen. I'm sure it's an accidental problem, but it still exists. If you have the conditions, try adjusting the screen resolution scale to 150%.
there should be some bugs when doing sub pixel sampling whether it's related to windows DPI settings. can you reproduce this regularly without changing DPI?
Caused by can you please have a look at this?
Change:
} } <ins> async function openVscodeDevLink(gitAPI: GitAPI): Promise<vscode.Uri | undefined> { try { const permalink = getPermalink(gitAPI, true, 'https://vscode.dev/github'); return permalink ? vscode.Uri.parse(permalink) : undefined; } catch (err) { vscode.window.showErrorMessage(err.message); return undefined; } } </ins> export function registerCommands(gitAPI: GitAPI): vscode.Disposable { const disposables = new DisposableStore();

Discussion:
Testing Clone a git repository Open git repository in VS Code desktop Make a change to one or more files Invoke the command You are presented with an empty picker <img width="736" alt="image" src="https://user-"
Change:
padding: 0; } <ins> .monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-container >  .tab.sizing-shrink:focus > .tab-label::after { opacity: 0; /* when tab has the focus this shade breaks the tab border (fixes https://github.com/Microsoft/vscode/issues/57819) */ } </ins> .monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-fit .monaco-icon-label, .monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-fit .monaco-icon-label > .monaco-icon-label-description-container { overflow: visible; /* fixes https://github.com/Microsoft/vscode/issues/20182 */

Discussion:
Issue Type: <bBug</b==<kbdCtrl</kbd+<kbdM</kbd<kbdTab</kbduntil get to tab (no pun intended) ! VS Code version: Code 1.26.1 (, 2018-08-16T18:38:57.434Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

non-dirty file (New Untitled will do) to "close editor" border is set, which is nice, but it's invisible Shown only on hover: !
I cannot reproduce, can you reproduce with our default dark theme?
it's related to config. Reproduces with:
It's related to this piece:
thanks I can reproduce, but the fix is not good. I commented.
I think it would be easy to do in chromium 60 where is working.
Change:
); }); }) <del> : command(localize('remove', "$(error) Remove {0}", inputData.title), async () => { </del> <ins> : command(localize('remove', "Remove {0}", inputData.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,

Discussion:
Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used—not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width="269" alt="CleanShot 2022-09-27 at 11 42 19 src="https://user-"<img width="244" alt="CleanShot 2022-09-27 at 11 43 33 src="https://user-"
I can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.
Why don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.
Change:
} protected override getPublishBranchActionButton(): SourceControlActionButton | undefined { <del> const scmConfig = workspace.getConfiguration('scm'); if (scmConfig.get<boolean>('experimental.showSyncView', false)) { return undefined; } </del> const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ publish: boolean }>('showActionButton', { publish: true });

Discussion:
Testing I don't seem to have the sync changes button available to me, unless you're referring to the small icons in the status bars. !
I was able to get the Sync Changes button with the node-spdlog repository on my mac. It could be because my Windows machine and/or the vscode repository I tested with both have
that should not be the case. In your screenshot, I see that you have both incoming and outgoing changes, and no pending changes so the "Sync Changes" button should be shown instead of the disabled "Commit" button. Could you please share the exact steps that got you into this state? Also what is the value of the setting?
The has the default value. I seemed to repro it again, so here are some steps: the microsoft/vscode repository, switch to a new branch off of the main branch a file and push to establish the remote version of the branch , edit a separate file on that (remote) branch and commit the change directly to that branch. , edit yet another file and commit the change. Do not push. the git fetch command. :bug: There are both incoming and outgoing changes but the sync button does not appear.
Thanks for the steps. I will keep trying but for now I am unable to reproduce the issue: !
Change:
installSelectionListener(); const options: IWorkbenchDataTreeOptions<OutlineEntry, FuzzyScore> = { <del> collapseByDefault: _target === OutlineTarget.Breadcrumbs, </del> <ins> collapseByDefault: _target === OutlineTarget.Breadcrumbs || (_target === OutlineTarget.OutlinePane && _configurationService.getValue(OutlineConfigKeys.collapseItems) === OutlineConfigCollapseItemsValues.Collapsed), </ins> expandOnlyOnTwistieClick: true, multipleSelectionSupport: false, accessibilityProvider: new NotebookOutlineAccessibility(),

Discussion:
Testing Setting Open a github issue notebook You get: <img width="283" alt="image" src="https://user-"
Change:
} private updateSplitviewEdgeSnappingEnablement(): void { <del> this.splitview.startSnappingEnabled = this._edgeSnapping || this.absoluteOrthogonalOffset > 0; this.splitview.endSnappingEnabled = this._edgeSnapping || this.absoluteOrthogonalOffset + this._size < this.absoluteOrthogonalSize; </del> <ins> this.splitview.startSnappingEnabled = this._edgeSnapping || this._absoluteOrthogonalOffset > 0; this.splitview.endSnappingEnabled = this._edgeSnapping || this._absoluteOrthogonalOffset + this._size < this.absoluteOrthogonalSize; </ins> } dispose(): void {

Discussion:
Was finally able to repo this but not reliably. It seems to rely on a new being created, but this doesn't always happen. The most reliable repo for me: with a notebook and text editor in a single editor group the notebook editor down to create a new group below the text editor grab the notebook editor and drag it right to move the bottom editor to the right I think the root cause is that the notebook widget is passed the wrong position. I'm going to work around this by making the notebook editor ignore the position it is given, however this will also undo the performance fixes we made this iteration for notebook layout I don't fully understand the grid layout code but it seems that is being set incorrectly in cases where a new BranchNode/SplitView is created. Here's what I see happening after step 3 of the repo above: setter is called calls which creates a new the constructor, a new Split View is created is called on it. At this point, of the split view is: the time layout is called on the notebook editor widget, is computed as zero. This results in the wrong layout. Looking at the code, we can see that is passed in as the absolute offset in step 4: <img width="1104" alt="Screenshot 2022-11-30 at 12 48 54 PM" src="https://user-"If I then slightly resize the window, here's what happens: call on the split View for the new group now is: we layout the notebook editor, is now correctly computed as Originally posted by in
Change:
* *Note:* The range must be a {@link Range.isSingleLine single line} and it must * {@link Range.contains contain} the position at which completion has been {@link CompletionItemProvider.provideCompletionItems requested}. */ <del> range: IRange | { insert: IRange; replace: IRange; }; </del> <ins> range: IRange | CompletionItemRanges; </ins> /** * An optional set of characters that when pressed while this completion is active will accept it first and * then type that character. *Note* that all commit characters should have `length=1` and that superfluous

Discussion:
Issue Type: <bBug</bI would like the prefix to trigger only when there is a leading whitespace in front of the prefix (it is supposed to be substituted with an explicit non-breaking space character ). The example of the snippet: --The prefix behaves as if there is no leading space, meaning the remains one extra whitespace before the expanded body, resulting in a double space: . VS Code version: Code 1.55.2 (, 2021-04-13T09:35:57.887Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (37)</summaryExtensionVersion ------ html-snippets0.2.1 Handlebars0.4.1 rc-beautify1.2.0 git-temporal-vscode1.0.0 insert-unicode0.10.0 i30.0.1 vscode-generate-getter-setter0.5.0 gitlens11.4.1 vscode-html-css1.10.2 vscode-npm-script0.3.21 carbon-now-sh1.2.0 vscode-angular-html1.7.0 beautify1.5.0 latex-workshop8.18.0 polacode-.5.2 svg1.4.6 Angular211.0.0 solidity0.0.113 Kotlin1.7.1 rainbow-csv1.8.1 vscode-docker1.12.1 python2021.5. vscode-pylance2021.5.2 jupyter2021.5. remote-containers0.166.1 postscript1.0.1 java0.79.1 LiveServer5.6.1 bash-debug0.3.9 scala0.5.3 bash-beautify0.1.1 code-settings-sync3.4.3 code-spell-checker1.10.2 sass-indented1.8.16 html-preview-vscode0.2.5 vscode-ruby0.28.0 markdown-all-in-one3.4.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I have a fix for this but it makes bigger changes in how snippet completion are computed. Pushing out to November to get more Insider usage for it, changes are in
Change:
import { ITerminalConfiguration, ITerminalConfigHelper, ITerminalFont, IShellLaunchConfig, IS_WORKSPACE_SHELL_ALLOWED_STORAGE_KEY } from 'vs/workbench/parts/terminal/common/terminal'; import { TPromise } from 'vs/base/common/winjs.base'; import Severity from 'vs/base/common/severity'; <ins> import { isFedora } from 'vs/workbench/parts/terminal/electron-browser/terminal'; </ins> interface IEditorConfiguration { editor: IEditorOptions;

Discussion:
VSCode Version: Code 1.17.0 (, 2017-10-04T23:33:45.303Z) OS Version: Linux x64 4.12.0-2-amd64 Extensions: Extensions are disabled Steps to Reproduce: window doesn't look well ! <!-- Launch with to check. --Reproduces without extensions: Yes/No
Here is how my integrated terminal looks like !
what distro are you using? I've seen Fedora acts a little odd with font rendering both in the editor and the terminal. see
I'm experiencing the same issue on Fedora 26 / Gnome 3.24.2 / VSCode version 1.17.0. The only affected component is the terminal so far, other fonts look good. The issue is not present in VSCode 1.16.1.
i am using debian 9 / xfce4 / VSCode version 1.17.0
For Fedora right now the workaround is to use a different font:
it works like a charm. Thanks a lot :)
Thks now looks very well.
Pushed to master and release/1.17
Not sure I've got issue right, but looks like custom fonts such as are not working after last update. Before update everything worked fine. Wouldn't say it is too important, but would be nice to get it back. Linux Mint 18.2 x64. !
Same issue here with Fira Code font Ubuntu 17.04 x64
yes also here FiraCode looks weird now. macOS 10.13
same here as after 1.17.1 update it looks weird now with SF Mono on macOS. ! it looks weird, because before 1.17.1 it was awesome
This is the issue tracking the blurry text in 1.17.1
Change:
* @event */ export function onLanguageEncountered(languageId: string, callback: () => void): IDisposable { <del> const languageService = StandaloneServices.get(ILanguageService); const disposable = languageService.onDidRequestBasicLanguageFeatures((encounteredLanguageId) => { if (encounteredLanguageId === languageId) { // stop listening disposable.dispose(); // invoke actual listener callback(); } </del> <ins> return StandaloneServices.withServices(() => { const languageService = StandaloneServices.get(ILanguageService); const disposable = languageService.onDidRequestBasicLanguageFeatures((encounteredLanguageId) => { if (encounteredLanguageId === languageId) { // stop listening disposable.dispose(); // invoke actual listener callback(); } }); return disposable; </ins> }); <del> return disposable; </del> } /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Monaco Editor OS Version: macOS 13.0 (22A380) Steps to Reproduce: in the some logs in in vscode. any Monaco editor test page. the output of the consoleeach call to will re-register all registered languages. <img width="763" alt="image" src="https://user-"
Can you look into why this is the case, maybe even providing a PR?
Sorry for the late reply, I would be happy to submit a PR.
Change:
this.iconWidgetFor(category), $('.category-description-container', {}, $('h2.category-title.max-lines-3', { 'x-category-title-for': category.id }, category.title), <del> $('.category-description.description.max-lines-3', { 'x-category-description-for': category.id }, category.description))); </del> <ins> $('.category-description.description.max-lines-3', { 'x-category-description-for': category.id }, ...renderLabelWithIcons(category.description)))); </ins> const stepListContainer = $('.step-list-container');

Discussion:
This is a bug in the . In general, the extension API allows icons to be embedded in text by referencing them inside of . This functionality does not work consistently in the walkthroughs API. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A; this is a bug in the extension API VS Code Version: 1.69 OS Version: macOS 12.4 Steps to Reproduce: a walkthrough step in your extension, e.g. "walkthroughs": [ { "id": "welcome", "title": "Example $(github)", "description": "See? The icon looks nice, doesn't it?", "steps": [ { "id": "example-step", "title": "Example step", "description": "Example description", "media": { "image": "", "altText": "" } } ] } ] 2 Observe that the icon in the title ( in the example above) renders correctly in the Open Walkthrough… quickpick list: <img width="372" alt="Screen Shot 2022-07-12 at 10 21 08 AM" src="https://user-"up the walkthrough and observe that the icon is not rendered, and instead you see the literal string : <img width="508" alt="Screen Shot 2022-07-12 at 10 22 09 AM" src="https://user-"
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Yes, it still exists in 1.69.1.
Thanks for the remarkably fast turnaround time, appreciate you.

Still see this in Version: 1.70.0-insider (user setup) Commit: Date: 2022-07-27T05:16:37.759Z OS: Windows_NT x64 10.0. ! ! ! generate a new TypeScript extension with add the snippet from the issue description to the
I only fixed the icon in the place that it didn't work in the issue description, sound like I have a few more places to fix :)
LGTM in the menu, in the walkthrough title, and in a step. <img width="984" alt="image" src="https://user-"
Change:
// if (data.message) { // 	progress({ kind: 'progressMessage', content: new MarkdownString(data.message) }); // } <del> if (data.slashCommand) { </del> <ins> // TODO@ulugbekna,jrieken should we only send data.slashCommand when having detected one? if (data.slashCommand && !inlineRequest.prompt.startsWith('/')) { </ins> const command = this._data.slashCommands.find(c => c.name === data.slashCommand); progress({ kind: 'agentDetection', agentId: this._data.id, command }); }

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
return liveRepository; } <del> if (hint === repository.mergeGroup || hint === repository.indexGroup || hint === repository.workingTreeGroup) { </del> <ins> if (hint === repository.mergeGroup || hint === repository.indexGroup || hint === repository.workingTreeGroup || hint === repository.untrackedGroup) { </ins> return liveRepository; } }

Discussion:
I am doing Remote Development, and have a few Source Control Repositories. In the Source Control pane, I have all the repositories listed in the Source Control section. One of the repositories has a file that I want to discard. It is listed under "Untracked Changes", under the repository it is in. If I click the "Discard Changes" button on the line with the file, I am prompted for confirmation, as I expect. But, if I click the same button on the line above the file -- the "Discard All Untracked Changes" button on the "Untracked Changes" header line under the repository I want -- then I am first shown a "Choose a repository" dropdown that lists all the repositories. I don't understand why this choice is needed, since I clicked the "Discard All Untracked Changes" button on the Untracked Changes for a specific repository -- why must I select this repository again? If I choose the repository, I am still shown the same (or similar) confirmation dialog as I was before, so the selection does not seem to be needed for confirmation. Clicking the plus ("+") button (i.e., Stage All Untracked Changes) on the Untracked Changes line seems to have the same issue.
Thank you!