jiebi/CodeConvo huggingface dataset:
Change:
for (const edits of allEdits) { modified.applyEdits(edits, false); } <ins> const diff = await this._editorWorkerService.computeDiff(textModel0.uri, modified.uri, { ignoreTrimWhitespace: false, maxComputationTimeMs: 5000, computeMoves: false }, 'advanced'); if (!diff || diff.changes.length === 0) { this.hideEditsPreview(); return; } </ins> this._previewDiffEditor.value.setModel({ original: textModel0, modified }); // joined ranges

Discussion:
Enable screen reader mode or use preview mode Create a code error Invoke inline chat and use The response doesn't get shown in the diff editor and sometimes doesn't come back at all. The console shows the error below
I see:
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
screen reader mode a code error inline that and use /fix response doesn't get shown in the diff editor and sometimes doesn't come back at all.
Maybe related
Change:
} export class ExtHostTelemetryLogger { <del> private _appender: vscode.TelemetrySender; </del> <ins> static validateSender(sender: vscode.TelemetrySender): void { if (typeof sender !== 'object') { throw new TypeError('TelemetrySender argument is invalid'); } if (typeof sender.sendEventData !== 'function') { throw new TypeError('TelemetrySender.sendEventData must be a function'); } if (typeof sender.sendErrorData !== 'function') { throw new TypeError('TelemetrySender.sendErrorData must be a function'); } if (typeof sender.flush !== 'undefined' && typeof sender.flush !== 'function') { throw new TypeError('TelemetrySender.flush must be a function or undefined'); } } private readonly _sender: vscode.TelemetrySender; </ins> private readonly _onDidChangeEnableStates = new Emitter<vscode.TelemetryLogger>(); <del> private _telemetryEnablements: { isUsageEnabled: boolean; isErrorsEnabled: boolean }; private _apiObject: vscode.TelemetryLogger | undefined; </del> private readonly _ignoreBuiltinCommonProperties: boolean; private readonly _additionalCommonProperties: Record<string, any> | undefined; public readonly ignoreUnhandledExtHostErrors: boolean; <ins> private _telemetryEnablements: { isUsageEnabled: boolean; isErrorsEnabled: boolean }; private _apiObject: vscode.TelemetryLogger | undefined; </ins> constructor( sender: vscode.TelemetrySender, options: vscode.TelemetryLoggerOptions | undefined,

Discussion:
This looks like we have telemetry loggers without appenders. Can we add a strict check or in the API impl?
Change:
import { WorkbenchList } from 'vs/platform/list/browser/listService'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IViewDescriptorService } from 'vs/workbench/common/views'; <del> import { SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme'; </del> import { IOpenerService } from 'vs/platform/opener/common/opener'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { RepositoryActionRunner, RepositoryRenderer } from 'vs/workbench/contrib/scm/browser/scmRepositoryRenderer';

Discussion:
Sometimes the tree sticky show shadow does not show. Make sure they use the proper overrides and that there is a default color if none is provided
are there any validation steps here?
verified- the scm sticky scroll showed on insiders, but not stable.
Change:
return this.handleDirtyBeforeShutdown(remainingDirtyWorkingCopies, reason); } <del> return false; // no veto (there are no remaining dirty working copies) </del> <ins> return this.noVeto([...dirtyWorkingCopies]); // no veto (dirty auto-saved) </ins> } // Auto save is not enabled

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: Windows_NT x64 10.0. Auto Save by onFocusChange does not sync internal cache when direct quitting by 'X' button. Steps to Reproduce: settings: "Files: Auto Save" =onFocusChange a text file and save it somewhere. the file a little more. But this time, do not save or change focus and just press 'X' button directly to quit. the text file again with vscode. to save the file. Now you can see this error message: "Failed to save '...': The content of the file is newer." <img width="341" alt="image" src="https://user-"
That is weird, we trigger auto save on shutdown unless auto save is turned off: Does this still reproduce in all projects?
Oh nice I can reproduce, looks really like a bug.
Great catch!
Thank you for your response and effort on this issue!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
): Promise<ITerminalAction[] | undefined> { const fixes: ITerminalAction[] = []; const newCommand = terminalCommand.command; <del> const expectedCommands = []; </del> for (const options of quickFixOptions.values()) { for (const option of options) { if (option.exitStatus === (terminalCommand.exitCode !== 0)) {

Discussion:
Testing For built-in quick fixes, the command is automatically run after selecting it. However, for custom ones, it just emits a ctrl+c and writes out the command without actually running it !
Cannot reproduce on Windows
!
can you reproduce only w the contributed fix or also the builtin ones IE ?
The built-in git one works fine, only the contributed one doesn't. The command being returned is the string . There's no new line at the end of that string, which might(?) be triggering the automatic entering if that's being returned in built-in matchers...
Updated my original comment. It's not an OS thing, just built-in vs contributed
This was working at one pt. Probably a regression when I removed as a property. thanks for the info
Change:
/* Drag and Drop */ <del> .monaco-workbench .part.editor > .content .editor-group-container > .title { cursor: grab; } </del> .monaco-editor-group-drag-image { display: inline-block; padding: 1px 7px;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Windows 11 Steps to Reproduce: custom cursor theme (such as a large version of Windows 11 colored vector cursor theme) over tab bar (not tab) Expected behavior: Colored/custom mouse pointer Observed behavior: "Grabby hand" cursor icon. Clicking and dragging the tab bar does nothing, so it doesn't make sense. Fix: Since clicking and dragging the bar does nothing, change it to the default arrow cursor. Screenshots: ! !
Duplicate of
This can't just be fixed by changing the CSS to something else? As I said, dragging the bar does nothing: this is about the UI of VScode implying something can be grabbed and dragged, not just that the cursor is ugly.
Yeah good point, lets ditch this ugly cursor, at least on platforms where not supported nicely.
Opening up for help wanted, to find a better, native cursor on Windows.
Lets just not use it and use cursor instead, same as tabs.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
@IInlineChatSessionService inlineChatSessionService: IInlineChatSessionService, @IInlineChatService protected readonly inlineChatService: IInlineChatService, @ITelemetryService private readonly telemetryService: ITelemetryService, <del> @IProductService private readonly productService: IProductService, </del> <ins> @IProductService protected readonly productService: IProductService, </ins> ) { this.toDispose = []; this.toDispose.push(this.editor.onDidChangeModel(() => this.update()));

Discussion:
Testing 1 Create New Jupyter Notebook what I see (image below). There is only one line visible and it is covered by the hint, the notebook does not have focus. do not have any space where I can click just to pass focus inside the notebook to start typing If I click below, the focus is passed to this weird mini status bar (image 2) imho this is a ux bug. The point of the hint is not to be in your way. It works better in the regular VS Code editor because there are more lines visible. If there is only one line, it is very much in user's face. ! ! fyi
Makes good sense to me. I pushed a change to disable this for Stable first. I'd like to provide a non-clickable editor hint in empty cell once the main is open for business/Insiders again.
We disabled mouse clicking now <img width="1187" alt="image" src=""
Change:
"action": { "indent": "outdent" } <del> } </del> <ins> }, { "beforeText": "^s*(var|const|let)s+w+s*=s*(.*)s*=>s*$", "action": { "indent": "indent" } }, </ins> ] }

Discussion:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have:
Change:
discardHunk: () => void; toggleDiff?: () => any; remove(): void; <ins> move: (next: boolean) => void; </ins> };

Discussion:
open inline chat have it make multiple hunks (hint: ask it to use a util that needs to be imported) there is no gesture to visit all hunks except for accepting/discarding them... This can also help with accessibility when using the move
To verify let inline chat make multiple changes, e.g ask it to import a util or let is change the label of two actions make sure the inline chat status says "N changes" (n=2) select and to navigate between the changes
Change:
color: var(--vscode-descriptionForeground); } <ins> /* for input1|2 -> align details to the left  */ .monaco-workbench .merge-editor .code-view.input>.title>SPAN.detail::before { content: '•'; opacity: .5; padding-right: 3px; } .monaco-workbench .merge-editor .code-view.input>.title>SPAN.detail { margin-left: 0; } .monaco-workbench .merge-editor .code-view.input>.title>SPAN.toolbar { margin-left: auto; } </ins> .monaco-workbench .merge-editor .code-view>.title>SPAN.detail .codicon { font-size: 13px; }

Discussion:
Ref Thinking about various ways to reduce clutter and noise. Not sure if there's any reason to keep the branch aligned right and the commit to the left. Especially since we're looking at adding more actions via . What if we just combined them with a separator e.g. <img width="1148" alt="CleanShot 2022-09-07 at 15 18 17 src="https://user-"cc
It would also be nice if we could show more information about the commits somehow (maybe a hover or a clickable label). The hash doesn't really help, unless I have a different tool to look it up.
Here's what we explored in earlier design iterations: <img width="542" alt="CleanShot 2022-09-08 at 08 36 49 src="https://user-"
Change:
import { IHostService } from 'vs/workbench/services/host/browser/host'; import Severity from 'vs/base/common/severity'; import { coalesce, distinct } from 'vs/base/common/arrays'; <del> import { trim } from 'vs/base/common/strings'; </del> <ins> import { compareIgnoreCase, trim } from 'vs/base/common/strings'; </ins> import { IModeService } from 'vs/editor/common/services/modeService'; import { ILabelService } from 'vs/platform/label/common/label'; import { IPathService } from 'vs/workbench/services/path/common/pathService';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.52.1 (user setup) OS Version: Windows_NTx64 10.0. Steps to Reproduce: some custom languages, examples that it definitely works for are "Caddlefile Syntax", "Graphviz language", "Hjson", "Better TOML", "Svelte for VS Code". a new blank file. --Save as and expect to find it in the alphabetically sorted list (e.g. Toml from Better TOML between Swift and TypeScript) , instead find it at the bottom. It appears to be in the order 'inbuilt languages sorted alphabetically' followed by 'other languages sorted somewhat randomly'. ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No
They are sorted on macOS, so it maybe Windows doing something weird. But we also dont sort the list explicitly:
Up for grab, I think we should sort the languages by name. We still have to make sure that: "All Files" appears first the current language appears second and selected "No Extension" is last
If you sort "registeredLanguageFilters" that should solve the problem no? "All files" appearing first, current language appearing second and "No Extension" appearing last is handled by these lines: Still getting the hang of all this, so please correct me if I am wrong.
Can we have this discussion in a Pull Request?
Two things I notice. as with untitled files defaults to not . Save as on a file with a pre-existing extension leads to an out of order list. I.e. here's a picture of .CSS !
It is intentional that the language mode picked for a file is the second most entry in the list, we have explicit code to change the order there. As for untitled: did you have the language mode configured to ".bat"? I suggest we follow up in a new issue here as it is independent from the sorting fix. Verification: create an untitled file save it in the picker verify that the languages are sorted by name, specifically check for languages contributed by extensions such as JSONC
Change:
return this.tryRevealLine(vscode.window.activeTextEditor, args.fragment); } } <ins> const config = vscode.workspace.getConfiguration('markdown', resource); const openLinks = config.get<string>('editor.openMarkdownLinks', 'currentGroup'); let column: vscode.ViewColumn; switch (openLinks) { case 'openToSide': column = vscode.ViewColumn.Beside; break; case 'currentGroup': default: column = vscode.ViewColumn.Active; } </ins> return vscode.workspace.openTextDocument(resource) <del> .then(vscode.window.showTextDocument) </del> <ins> .then(document => vscode.window.showTextDocument(document, column)) </ins> .then(editor => this.tryRevealLine(editor, args.fragment)); }

Discussion:
Scenario: Markdown file is open in left editor group. This file has a lot of links to other .md files that I want to preview in the right editor group. But Markdown links can currently only be opened into the same editor. Please consider. Thanks!
Adding per our discussion about this one
Do you mean that you would like an option to make the command to open the preview to the left instead of to the right of the current editor?
No, sorry, I should have been more specific. Here's what I mean: -click to open a .md file in a persistent editor in Code, preferably a file with many links to other local .md files. the file, Ctrl+click a link to another .md file. other file opens in a new editor, in the same editor group. Desired: open the link as a raw .md file in a new or existing (separate) editor group. Then, when I go back to the original file and ctrl+click another .md link, open that raw .md into the same editor group the previous one opened into. So I can quickly ctrl+click through a bunch of links and see the raw .md while my original file (the one with all the links) stays in view.
Ok, thanks for explaining the expected behavior in more detail. Marking as help wanted if anyone wants to investigate this. To get started, look at: This is where we map markdown links to command links This is where we convert the command into an editor action. Instead of opening in the current editor, we would want to open in a new editor group here
For verification: new setting was called are two options: (the default) and links in md text files (not the preview) should respect this option default behavior should be to open links in the current group
Can't verify because of
I can verify this on Mac.
Thanks for adding this!
Change:
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-label.profile-activity-item { height: 20px; <del> width: 28px; margin: 14px 10px; </del> <ins> width: 32px; margin: 14px 8px; </ins> padding: 0px; justify-content: center; align-items: center; <del> font-size: 12px; </del> <ins> font-size: 14px; </ins> line-height: 16px; <del> border: 2px solid; </del> <ins> border-radius: 8px; </ins> } /* Right aligned */

Discussion:
The original designs had something closer to this for the default background color. IMO it isn't trying to be an icon like the other items and the border makes it feel like an icon vs. a unique element. I also think the background and foreground should be the only customizable elements to start. I think I saw a foreground token, but not sure it was possible to do background yet. <img width="247" alt="CleanShot 2022-09-26 at 16 29 09 src="https://user-"
I also like this more over the border For example here this looks not too different from the actions above even though it is about profiles: <img width="297" alt="image" src="https://user-"
!
I like it but maybe with smaller font size? Here is with for example: !
Current font size goes well with all (emoji, codicons) and also symmetric with activity bar icons.
Change:
*--------------------------------------------------------------------------------------------*/ .codeActionMenuWidget { <del> padding: 10px 0px 10px 0px; </del> <ins> padding: 8px 0px 8px 0px; </ins> overflow: auto; font-size: 13px; border-radius: 5px;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Type: Bug Using editor.experimental.useCustomCodeActionMenu, the menu doesn't match up with the colors of enabled/disabled options or the background of the other context menus

Type: <bBug</bmenu the window Bug The widget ends up being incorrectly positioned: <img width="672" alt="Screen Shot 2022-07-21 at 1 24 17 PM" src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-21T05:17:20.056Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
return; } <del> if (this._dimension) { </del> <ins> if (this._dimension && this._isVisible) { </ins> if (sizeDelta > 0) { // delta > 0 ==> sticky is growing, cell list shrinking this.layout(this._dimension); this.setScrollTop(this.scrollTop + sizeDelta);

Discussion:
I had multiple editors open, one of them was a notebook. At some point when I saved the file I was in the notebook suddenly appeared over the typescript file. This happened twice, once when in the typescript file and once in the multi diff editor. <img width="1921" alt="Code-Insiders_G5CU0Db9YP" src=""
Maybe a regression from the work to support notebooks in floating windows?
Change:
})); } <ins> updateEnabled(): void { // override on submenu entry // native menus do not observe enablement on sumbenus // we mimic that behavior } </ins> open(selectFirst?: boolean): void { this.cleanupExistingSubmenu(false); this.createSubmenu(selectFirst);

Discussion:
Related to If you have a command in an action bar (say in ) that is a submenu with no items (or no visible items), there is no visible indication -- the icon is there, but does nothing if you click on it. I would expect similar behavior to
Change:
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-canvas@0.3.0-beta.1: version "0.3.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.1.tgz#17a65f5da65416b01d620ddef6247ff5013ffc15" integrity sha512-34PKhrkvK1RtlOOmni4i5GUIyoFKGMph8fWFvA2d52IDTKmX9YoLzZfU73D/sUAx+/GKobCE8sr14CuBZctgNw== </del> <ins> xterm-addon-canvas@0.3.0-beta.8: version "0.3.0-beta.8" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.8.tgz#1848d54091e864cf6aa7310e5d883203fe09247a" integrity sha512-NGaPADoh4/out6pCgfwh6lVDpJQtQXMRBXpvHB2rMcJqAZ0KHJalQXbjBmwSL9/WiHvYLhmqvGJ3+Pd9aE8hoA== </ins> <del> xterm-addon-search@0.11.0-beta.1: version "0.11.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.1.tgz#fe7178d70246cde73550447c5524672575467499" integrity sha512-fKj8KnnhH1nC4oZpKsgnhtgxkTctoa9kGLMpTJjsNzFu0VvXvLGIRezTPI75UEIQdEdaxcwB7/aKelQTO+72LA== </del> <ins> xterm-addon-search@0.11.0-beta.3: version "0.11.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.3.tgz#ee466425b83c74b69cbf71903c3781895beea5ab" integrity sha512-Fc9VuQn31JNnD2gZUEFMUYLpz6kPw5LMLp7YTB5iDv43JklEJL/14v6C4dFZkAo95MPi7yr3CUefYXz0dt+O7Q== </ins> xterm-addon-serialize@0.9.0-beta.2: version "0.9.0-beta.2"

Discussion:
Testing using canvas render. ! Should the line be continuous even though it overlaps the characters? vs "on": ! I'm talking about characters like and .
I didn't bother adding this to the canvas renderer as it's the fallback which is primarily for iPad atm, nothing stopping it from working there too though. Should really consolidate the rendering code for webgl and canvas as they mostly do the same thing when drawing the actual characters.
The wavy underline looks off with gpu enabled (first example in the attached screenshot). With the canvas setting, it's not rendered at all. !
The look of curly was going to be revisited in