jiebi/CodeConvo huggingface dataset:
Change:
assert.deepStrictEqual(colors, [ '#000000', '#cd3131', <del> '#00bc00', </del> <ins> '#107c10', </ins> '#949800', '#0451a5', '#bc05bc',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Mac Sonoma 14.3 Steps to Reproduce: Note: the following is just one way to easily reproduce, but this really is an issue with the CSS variable that affects more than just the Jupyter extension (hence why the issue is opened in this repository). the Jupyter extension a cell, execute code that in the cell output, the green color is using the theme variable <img width="263" alt="image" src=""the following in the terminal that the green ANSI styling is different in light themes: <img width="280" alt="image" src=""<img width="427" alt="image" src=""<img width="419" alt="image" src=""Works as expected in dark themes: <img width="377" alt="image" src=""<img width="290" alt="image" src=""This is a problem because in light theme, the contrast ratio requirement is not met. This means that when the CSS variable is used there will be an accessibility bug. Thanks!
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!

Confirmed reproing on 1.86.1 as well
Github Tags: #BM-VisualStudioCodeClient-Win32-Jan2024; #Visual Studio Code Client; #A11yMAS; #WCAG1.4.3; #AILimited; #A11yTCS; #ColorContrast; #A11ySev2;
the terminal has the minimum contrast ratio feature that fixes the contrast ratio, anywhere else that piggy backs on that color might not meet contrast.
Assigned to April as it comes from s360
so no matter what color we use, terminal will automatically adjust it? I can change the default color used to solve the contrast issue outside of terminal. Just not sure how to keep them aligned.
yes the terminal will by default slide the color to be 4.5:1 (). It's fine if their luminosity is a little inconsistent imo, we just need to make sure the color meets contrast elsewhere.
Tweaked colors for light and light hc themes in !
thanks a lot. I think we can close this bug as fixed now, right?
Build failing, will auto close when it merges
Change:
// No child after this child in the requested window, don't recurse node = child; level++; <ins> nestingLevelOfEqualBracketType = levelPerBracket + 1; </ins> continue whileLoop; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Arch Linux x64 6.0.7-zen1-1-zen Steps to Reproduce: bracket pairs on last line of the file expected result: all bracket pairs colorized with same color actual result: last closing bracket is white ! if there is at least one line after last bracket, it works correcty ! ! !
Having the same issue on WSL2 under Windows 11. Also, I'd like to add that sometimes pair bracket becomes white even in the middle of the file, but after placing cursor on it, it becomes normal.
you are right, it has something to do with scrolling through file https://user-
Unfortunately, I cannot reproduce. Did you try with default settings, ideally in VS Code insiders?
I tried it in VS Code insiders, i found parameter in my config that cause this issue, (bug is visible in config file on 3rd line, when i uncomment this parameter) ! ! and i noticed that with this config vscode has small delay before coloring braces (in dark+ color theme). This might be the reason why vscode does not color braces with custom color themes (i tried Material and Darcula) https://user-
I have exact same issue. From a ubuntu laptop running 20.04 and a window 10 laptop running ubuntu 20.04 wsl 2.
Change:
} } }); <ins> KeybindingsRegistry.registerCommandAndKeybindingRule({ id: 'list.focusParent', weight: KeybindingWeight.WorkbenchContrib, when: WorkbenchListFocusContextKey, primary: KeyCode.Shift | KeyCode.LeftArrow, handler: (accessor) => { const focused = accessor.get(IListService).lastFocusedList; // Tree only if (focused && !(focused instanceof List || focused instanceof PagedList)) { if (focused instanceof ObjectTree || focused instanceof DataTree || focused instanceof AsyncDataTree) { const tree = focused; const focusedElements = tree.getFocus(); if (focusedElements.length === 0) { return; } const focus = focusedElements[0]; const parent = tree.getParentElement(focus); if (parent) { const fakeKeyboardEvent = new KeyboardEvent('keydown'); tree.setFocus([parent], fakeKeyboardEvent); tree.reveal(parent); } } else { const tree = focused; tree.focusParent({ origin: 'keyboard' }); } } } }); </ins>  No newline at end of file

Discussion:
Are there any commands in VScode to navigate "up" or "down" (a folder, directly) in a selection in breadcrumbs? <img width="659" alt="Screen Shot 2019-07-13 at 7 04 55 PM" src="https://user-"
for what the command id is but pressing ArrowLeft does the job for me
The command is actually . It will collapse a node. If already collapsed, it will select the parent. Should we implement a command to simply select the parent?
I can do this and have a try
i make a PR but not very clear about how primary work.
Command is , you'll be able to configure a custom key binding when it's out.
Change:
override focus() { super.focus(); <del> this._editorInput?.terminalInstance?.focus(); </del> <ins> this._editorInput?.terminalInstance?.focus(true); </ins> } // eslint-disable-next-line @typescript-eslint/naming-convention

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.0 OS Version: MacOS Sonoma, 14.3.1 (23D60). Steps to Reproduce: VSCode with one editor group. a new empty document and enter some text. a new terminal in the editor area ("Terminal: Create New Terminal in Editor Area"). the terminal to the editor group on the right ("View: Move Editor into Right Group") some text in the editor (left group). on the second editor group ("" or CMD+2 on MacOS). Screencast: ! Additional notes: bug showed up a few months ago. It is not new to 1.87. gets focus just fine. The problem is only with the terminal. terminal in the panel (CMD+J) works fine. my settings:
We rely on being implemented properly on the editor pane.
Seems we do that here
Thank you!
Change:
import * as dom from 'vs/base/browser/dom'; import { Toggle } from 'vs/base/browser/ui/toggle/toggle'; <ins> import { ToolBar } from 'vs/base/browser/ui/toolbar/toolbar'; </ins> import { Action, IAction, Separator } from 'vs/base/common/actions'; import { Codicon } from 'vs/base/common/codicons'; import { Disposable } from 'vs/base/common/lifecycle';

Discussion:
Theirs / Yours title area is currently quite empty. We should consider to add an action bar for "Compare with Base" action. The title area should also have additional Git information in the future fyi !
I don't see a branch or commit id in your screenshot. Is that configured somehow? <img width="533" alt="CleanShot 2022-06-28 at 10 00 52 src="https://user-"In any case, we could introduce a toolbar somewhat like the editor. Icons are placeholder, but an example could look like: <img width="1032" alt="CleanShot 2022-06-28 at 10 05 06 src="https://user-"
Unsure what was seeing there but with the normal git flow we do show the branch names and commits in question. There is also different issue for the toolbar and since today an icon in front of the commit it
To verify open a merge editor verify that it has menus with yours/theirs
Change:
const uri = URI.parse(settingRenderer.settingToUriString('example.stringSetting', 'three')); const verifyOriginalState = (actions: IAction[] | undefined): actions is IAction[] => { <del> assert.strictEqual(actions?.length, 2); </del> <ins> assert.strictEqual(actions?.length, 3); </ins> assert.strictEqual(actions[0].label, 'Set "Example: String Setting" to "three"'); assert.strictEqual(actions[1].label, 'View in Settings'); assert.strictEqual(configurationService.getValue('example.stringSetting'), 'two');

Discussion:
Testing Click on a setting link in the release notes Get a tooltip "View '<title' in Settings" context menu It seems strange to open a context menu on left-click and to open one with only a single menu item. Can we skip doing this if "View" is the only action?
My preference would be to keep it consistent so that a context menu always opens when the button is clicked. There was some discussion of adding a "copy setting id" item in there too, which would fix the only-one-item issue.
Will be fixed by , which adds a "copy" action to the menu.
Another option is to open the context menu when the "gear" icon is hit, but go directly to the setting if the text is clicked (or vise versa)
Change:
<rect width="115.654" height="39.2998" fill="var(--vscode-activityBar-activeBorder, #FFFFFF)" /> </clipPath> </defs> <del> </svg> </del>  No newline at end of file <ins> </svg> </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 OS Version:MacOS Big Sur Steps to Reproduce: the in repo and Run on any step that shows a PNG image, like ! the image is vertically aligned on Top on the step ! the image is vertically aligned on Center I know SVGs are better alternatives, and its support were to allow themes (), but even PNG images should be properly aligned. Thank you
Change:
this._accessor.clear(); return; } <del> const indentSize = cellOptions?.indentSize; const tabSize = cellOptions?.tabSize; const insertSpaces = cellOptions?.insertSpaces; </del> <ins> const cellEditorOverridesRaw = editor.notebookOptions.getDisplayOptions().editorOptionsCustomizations; const indentSize = cellEditorOverridesRaw['editor.indentSize'] ?? cellOptions?.indentSize; const insertSpaces = cellEditorOverridesRaw['editor.insertSpaces'] ?? cellOptions?.tabSize; const tabSize = cellEditorOverridesRaw['editor.tabSize'] ?? cellOptions?.insertSpaces; </ins> const width = typeof indentSize === 'number' ? indentSize : tabSize;

Discussion:
to repro: click notebook indentations statusbar entry run "indent using spaces/tabs" and select a new number entry will not update, however indentations work correctly given the selection that the user made and the current settings.

No a "choose intentation type" entry in status bar when editing in a notebook. I have a notebook with tab indentation but it seems theres some global spaces setting that overrides it... even pasting a literal tab charachter inserts spaces :/ !
False alarm. The status bar entry just moved so much that I didn't see it right away, and it has a different name in the status bar entries context menu.
Actually, looks like the status bar is really slow to update. I saw it update eventually, but I'm not sure what caused it to finally show the correct thing. !
Change:
primaryAction = actions.find(a => a.id === lastActionId) ?? actions[0]; } <ins> this._ctxActionCount.set(actions.length); </ins> this._dropdownActions = actions.length === 1 ? [] : actions; container.classList.toggle('has-no-actions', actions.length === 0);

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!
Change:
return undefined; } <del> this.element.style.width = `${dimension.width}px`; </del> <ins> this.element.style.width = `${dimension.width - 32}px`; </ins> return this.element.clientHeight; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.92.0 (Universal) Commit: Date: 2024-07-31T23:26:45.634Z Electron: 30.1.2 ElectronBuildId: Chromium: 124.0.6367.243 20.14.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.5.0 Steps to Reproduce: this snippet in the test-provider-sample project running the test, both the editor peek view and test result view do not render correctly. !
Sorry, this got lost in the shuffle of the call stack UI :(
Verification steps: out the of vscode-extension-samples into and F5 the "easy math" test in Open the error messages for all the tests that fail and verify they're all visible
Change:
localize('chat.requestBorder', 'The border color of a chat request.') ); <ins> export const chatRequestBackground = registerColor( 'chat.requestBackground', { dark: editorBackground, light: editorBackground, hcDark: editorWidgetBackground, hcLight: null }, localize('chat.requestBackground', 'The background color of a chat request.') ); </ins> export const chatSlashCommandBackground = registerColor( 'chat.slashCommandBackground', { dark: '#34414B', light: '#D2ECFF', hcDark: Color.white, hcLight: badgeBackground },

Discussion:
Magnification users often zoom out to decide what they will zoom in to read. For HC themes, we should make sure there's a difference in color between requests and responses.
good idea!
There's a slight difference on high contrast dark, but there appears to be no difference with high contrast light: ! !
This is by design as the light theme is completely flat and doesn't use a secondary background colour anywhere . The main differentiator in the HC themes is the bars on the side.
Change:
processManager: ITerminalProcessManager, widgetManager: TerminalWidgetManager, @IInstantiationService private readonly _instantiationService: IInstantiationService, <del> @IConfigurationService configurationService: IConfigurationService, @IAccessibilityService accessibilityService: IAccessibilityService </del> <ins> @IConfigurationService configurationService: IConfigurationService </ins> ) { super(); this.add(_instance.onDidRunText(() => { const focusAfterRun = configurationService.getValue(TerminalSettingId.FocusAfterRun); <del> const focusTerminal = focusAfterRun === 'terminal' || (focusAfterRun === 'auto' && accessibilityService.isScreenReaderOptimized()); if (focusTerminal) { </del> <ins> if (focusAfterRun === 'terminal') { </ins> _instance.focus(true); } else if (focusAfterRun === 'accessible-buffer') { this.show();

Discussion:
Changing this behavior could be jarring, so instead, we will set it to by default and include a hint about this in the terminal accessibility help dialog.
To verify, enable screen reader mode, run the command . The terminal shouldn't be focused and the accessible buffer shouldn't be opened. Change the setting and repeat and verify that it works per the setting descriptions.
So that is u - who spoiled the terminal focus in user-input scenarios. Would be awesome if auto-focus worked only on pending user input to the terminal, so everybody would be happy. But I have no clue if such a functionality is even possible.
not sure what you mean, but you can set it to to have the terminal focused automatically !
Yes, thank you, I know. I mean next cases at the same time: only prints to the console - no focus to the waits for user input - terminal receives auto-focus
Change:
static selectorMatches(selector: CustomEditorSelector, resource: URI): boolean { if (selector.filenamePattern) { <del> if (glob.match(selector.filenamePattern.toLowerCase(), basename(resource).toLowerCase())) { </del> <ins> const matchOnPath = selector.filenamePattern.indexOf(posix.sep) >= 0; const target = matchOnPath ? resource.path : basename(resource); if (glob.match(selector.filenamePattern.toLowerCase(), target.toLowerCase())) { </ins> return true; } }

Discussion:
have a custom editor that is registered for -files play with it change its selector to :bug: still open all JSON files... <img width="1044" alt="Screenshot 2020-04-03 at 16 12 20" src="https://user-"
Yes for the contribution, looks like we handle that contain a slash specially: We should do the same here
Change:
builtin return fi <del> __vsc_initialized="0" </del> __vsc_in_command_execution="1" <del> __vsc_last_history_id=0 </del> <ins> __vsc_current_command="" </ins> __vsc_prompt_start() { builtin printf "033]633;A007"

Discussion:
This is a follow up from which worked around the majority case of an issue. See the workaround: The proper fix will involve sending both the exit code and the history ID over to VS Code which will then do what's happening now but also have the correct exit code to set, instead of assuming it's the last command's exit code. We should write a little script as part of this that alternates exit codes by setting/unsetting an environment variable so it's easier to test and verify.
The issue being worked around is actually caused by or being included in .
Good test case from
To verify: some commands , they should all show up in current session ctrl+c in between some commands, including typing out a command and hitting ctrl+c to abandon it , the lines with ctrl+c shouldn't show up several times, failed and success should match whether the exception was thrown.
Change:
"native-watchdog": "1.3.0", "node-pty": "0.11.0-beta11", "spdlog": "^0.13.0", <del> "sudo-prompt": "9.2.1", </del> "tas-client-umd": "0.1.4", "v8-inspect-profiler": "^0.0.22", "vscode-nsfw": "2.1.8",

Discussion:
To recreate: Edit a file requiring sudo (eg ) When saving, VSCode will request sudo permissions and, after granting, gives the following error: I do NOT have Rosetta installed but understand VS Code is supposed to be M1 compatible. Here is the version info:
I cannot reproduce and I am on a M1 as well. thoughts? did you install the universal app?
For triggering we use a 3rd-party module which on macOS uses osascript saved as application bundle As a quick check, trigger a sudo prompt from vscode and open the OS temp directory and check for , following is the executable architecture So unless the user has rosetta installed this application will not be launched on M1 as reported here. you might have rosetta installed hence the failure was not seen, can be confirmed with
Not sure if that applet can be converted to universal, might also be worth looking at alternatives for sudo-prompt given that repo is now archived.
I would suggest to fork the module and convert that applet to universal if that is straightforward.
I don't see the source for the applet under the user repositories, will have to reach out to the author.
Maybe:
would you be able to test this scenario again from the following build that includes a potential fix:
Thanks for all your efforts on this (and . I discovered this on a new M1 Mac where I had not yet installed Rosetta but eventually caved in and installed it. Unfortunately it doesn't appear Rosetta can be easily uninstalled for testing. Happy to give this another go the next time I have a fresh Mac install but don't foresee that in the immediate future...
Verification on a mac with ARM chip without Rosetta 2 installed ([1]) use open try to edit (in the comment area!!!) from the error retry as sudo verify you get a prompt and save works [1] The presence of these files are a good indicator that you have Rosetta2 installed:
I take it you just re-compiled the applet for universal & updated the package with the base64 encoded string (is that right?)
yes! Here is what I did: decode the base64 encoded value unzip it open the apple script in apple script editor export it as application bundle (I have Rosetta 2 installed so it seems to export as universal bundle by default) zip it base64 encode it release as fork from
Change:
const isPanelChat = typeof response !== 'string'; this._responsePendingAudioCue?.dispose(); this._runOnceScheduler?.cancel(); <ins> if (this._lastResponse === response?.toString()) { return; } this._lastResponse = response?.toString(); </ins> this._audioCueService.playAudioCue(AudioCue.chatResponseReceived, true); this._hasReceivedRequest = false; if (!response) {

Discussion:
all chat audio cues enabled, run something in the inline chat that takes more than 4 seconds to come back that the chat response received cue doesn't play - in the console, there's an error about how a user gesture is required. this is expected to a different tab, leaving the chat widget still open to the tab with the chat widget visible hear the chat response received cue going between tabs and notice the cue gets played every time
so this happens even when it doesn't take that long !
this is because is called when the editor tab changes
that happens here !
looks like we need to move this to before is deleted so we can call it like
I have a different approach that will work. Ideally we would fix this at the root - so pls feel free to do so as you're more familiar with the state code.
This still repros for me with the steps from
So switching tabs plays an audio cue for you ?
This does not repro for me with the steps in this issue or the steps in the other one