jiebi/CodeConvo huggingface dataset:
Change:
import { IWorker, IWorkerCallback, IWorkerFactory, logOnceWebWorkerWarning } from 'vs/base/common/worker/simpleWorker'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; <del> const ttPolicy = createTrustedTypesPolicy('defaultWorkerFactory', { createScriptURL: value => value }); </del> <ins> // Reuse the trusted types policy defined from worker bootstrap // when available. // Refs https://github.com/microsoft/vscode/issues/222193 let ttPolicy: ReturnType<typeof createTrustedTypesPolicy>; if (typeof self === 'object' && self.constructor && self.constructor.name === 'DedicatedWorkerGlobalScope' && (globalThis as any).workerttPolicy !== undefined) { ttPolicy = (globalThis as any).workerttPolicy; } else { ttPolicy = createTrustedTypesPolicy('defaultWorkerFactory', { createScriptURL: value => value }); } </ins> export function createBlobWorker(blobUrl: string, options?: WorkerOptions): Worker { if (!blobUrl.startsWith('blob:')) {

Discussion:
I see this error a lot in the VS Code insider dev tools: ! !
Bisect points to the following, which was only effective with cross-origin scripts previously now is used in all scenarios to bootstrap NLS configs, some worker scripts like the renderer auto profiler end up loading the inside the worker which leads to double creation of the same name policy. Fun fact the duplicate policy creation is not raised when performing the same actions in a nested worker, possibly a bug in Chrome. Simple repro,
Thanks for fixing!
Change:
return undefined; } <del> const pid = this._cache.add(result.items); </del> <ins> const normalizedResult: vscode.InlineCompletionList = isArray(result) ? { items: result } : result; const pid = this._cache.add(normalizedResult.items); </ins> let disposableStore: DisposableStore | undefined = undefined; return { pid, <del> items: result.items.map<extHostProtocol.IdentifiableInlineCompletion>((item, idx) => { </del> <ins> items: normalizedResult.items.map<extHostProtocol.IdentifiableInlineCompletion>((item, idx) => { </ins> let command: modes.Command | undefined = undefined; if (item.command) { if (!disposableStore) {

Discussion:
Testing The existing API has , which returns . The new , API has , which returns . To better match the existing API, the version could return
That's a good idea! I've opened a PR for this, feel free to have a look if you like.
Change:
const disposables = new DisposableStore(); const auxiliaryWindow = disposables.add(await this.auxiliaryWindowService.open(options)); <del> disposables.add(Event.once(auxiliaryWindow.onDidClose)(() => disposables.dispose())); </del> const partContainer = document.createElement('div'); partContainer.classList.add('part', 'editor');

Discussion:
Testing It would be great if we can have a command to bring back those editors to the main window.
I think that should actually be the default behaviour when you just close the window. That will prevent ugly confirmation dialogs for dirty editors when you attempt to close the floating window.
Verification: open a floating window with some editors (e.g. by dragging an editor tab out of the window) close the floating window, e.g. from the X window button verify all editors of the floating window are moved back to the main window
Change:
import { VSBuffer } from 'vs/base/common/buffer'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; import { IExtHostRpcService } from 'vs/workbench/api/common/extHostRpcService'; <ins> import { IDisposable, toDisposable } from 'vs/base/common/lifecycle'; </ins> export class ExtHostConsumerFileSystem implements vscode.FileSystem {

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
const result = await quickPickService.pick( options, <del> { title: nls.localize('unicodeHighlight.configureUnicodeHighlightOptions', 'Configure Unicode Highlight Options') } </del> <ins> { title: configureUnicodeHighlightOptionsStr } </ins> ); if (result) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No When I hover over the command in the Unicode Highlighted character I get a very long tooltip message (most of it isn't in the demo): ! Version: 1.64.0-insider (user setup) Commit: Date: 2022-01-21T13:25:29.978Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ // file generated from css-schema.xml using css-exclude_generate_browserjs.js <del> define(["require", "exports"], function(require, exports) { </del> <ins> define(["require", "exports"], function(require, exports) { </ins> exports.data ={ "css": {

Discussion:
typing gives intellisense for colors, not for text-decoration. typing non will not show 'none' in Intellisense. The problem occurs in any css, less and scss file in any place, with any selector. Problem also occurs without extensions. I am running Windows 7 32bit with all updates possible. ! !
Colours are valid values for text-decoration, as it is a shorthand which includes text-decoration-color
Change:
} } <del> private getWindowTitle(): string { let title = this.doGetWindowTitle() || this.productService.nameLong; </del> <ins> private getFullWindowTitle(): string { let title = this.getWindowTitle() || this.productService.nameLong; </ins> const { prefix, suffix } = this.getTitleDecorations(); if (prefix) { title = `${prefix} ${title}`;

Discussion:
Testing I think we will soon turn command center on by default. What is the impact on then? I see we are only showing the full title in the hover now, but I wonder if we need another setting (?) so that users still can configure what we show in the command center? ! Or maybe we should find a way to show the even in the command center with ellipsis if overflowing. //cc
Seems reasonable to me
Enabling the command centre removes my custom window title, showing the full path of the currently focussed editor. I find this very useful especially when there are files with the same name but in different directories. Can't the command centre show the full custom window title (without having to hover over it)? Without this, I would permanently disable it.
We can say the default is different but a customisation is honoured
To verify enable command center configure and/or validate that any customization is picked up by the CC reset above settings validate that the CC uses a default
Any reason we wouldn't also apply this with the default setting? My worry is that when we eventually make command center on by default, the setting would basically not work until you change it? I think it looks good when enabled even with default setting: !
The idea is that the CC shows an affordance to do something, like "Search vscode" - we replaced "search" with the icon which watered this down a bit. The worry is that the more title-stuff we put here the less likely it is that folks understand this as affordance
Change:
return; } <del> await choice.run(repository); </del> <ins> await choice.run(); </ins> } @command('git.mergeAbort', { repository: true })

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-29T02:35:06.500Z) OS version: Windows_NT x64 10.0. Modes:
I will prepare a PR. Ideas for what to put in description: Commit ID (short format) ! Nothing, which is what Rebase does for most of its entries (exception being the upstream entry): ! Last commit timestamp: !
Change:
}, { "name": "CSS Property Name", <del> "scope": "support.type.property-name.css", </del> <ins> "scope": "support.type.property-name", </ins> "settings": { "fontStyle": "", "foreground": "#676867"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0 OS Version: macOS 14.2.1 Steps to Reproduce: the Monokai Dimmed theme a .less file that the syntax higlighting colors are very different to the previous release This is what the less syntax highlighting looked like in v1.85.2 with the Monokai Dimmed theme enabled: ! And this is what it looks like in 1.86.0: ! The main problem is that property names are now the same color as property values that are keywords - e.g. , & - but it's also a bit annoying that LESS variables are no longer a uniform color. I've checked a few other color themes and they don't seem to have this problem. This is a bit of a guess but maybe Monokai Dimmed needs to be updated following the changes introduced in ?
Yes, agree, this needs an update here:
Change:
**/*.ts !typescript/**/*.d.ts <del> jschardet/dist/** </del> <ins> jschardet/index.js jschardet/src/** jschardet/dist/jschardet.js </ins> es6-promise/lib/**

Discussion:
We use for encoding detection. This library itself ships a minified distribution: We seem to tell our loader to use that distribution: However, we also tell our build machine to exclude the folder: do you have an idea why we still successfully load , do we fallback to loading it normally through if the file is missing? I think you did implement some logic to automatically generate loader configuration based on the modules we ship in web, is that true? Are we configuring the web to load from folder? I actually wonder how this works in web, where we also seem to exclude the folder //cc
Oh I was wrong: in web we explicitly include and that seems to work just fine. Trying now to do the same for desktop:
Missing dependency: jschardet
63 svn Missing dependency: jschardet svn
Change:
"function-parameters": { "patterns": [ { <ins> "include": "#attribute" }, { </ins> "include": "#comments" }, {

Discussion:
VS Code Version: 1.52.1 Steps to Reproduce: !
at line number 20-23 syntax is wrong
That code runs correctly in PHP 8 ().
The syntax highlight is broken when you use an attribute and write code in the same line (method1) but also is incorrect when you write code in a param (method2) or you use line break (method3).
Noticed that this is better in the latest version of vscode, but they are missing tokens to be fully colored. Filed
Change:
// Verify edit session was correctly applied assert.equal((await fileService.readFile(fileUri)).value.toString(), fileContents); }); <ins> test('Edit session not stored if there are no edits', async function () { const writeStub = sandbox.stub(); instantiationService.stub(ISessionSyncWorkbenchService, 'write', writeStub); // Create root folder await fileService.createFolder(folderUri); await sessionSyncContribution.storeEditSession(true); // Verify that we did not attempt to write the edit session assert.equal(writeStub.called, false); }); </ins> });

Discussion:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.
Change:
addStyle('italic'); addStyle('underline'); if (fontStyleLabels.length) { <del> result += `<tr><td class="tiw-metadata-key">font style</td><td class="tiw-metadata-value">${fontStyleLabels.join(' ')}</td></tr>`; </del> <ins> elements.push($('tr', undefined, $('td.tiw-metadata-key', undefined, 'font style' as string), $('td.tiw-metadata-value', undefined, fontStyleLabels.join(' ')) )); </ins> } <del> return result; </del> <ins> return elements; </ins> } private _decodeMetadata(metadata: number): IDecodedMetadata {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . Simirarly to , it aims to replace construction of HTML elements by string concatenation in file. The code contains mainly a table construction by concatenating strings of . The goal is to replace them all with function calls.
I verified by running the monaco editor from source and testing the inspect token hover
To verify, open the hover and verify it looks all proper.
Change:
import { IStateService } from 'vs/platform/state/node/state'; import { ILogService } from 'vs/platform/log/common/log'; <del> type StorageDatebase = { [key: string]: any; }; </del> <ins> type StorageDatabase = { [key: string]: any; }; </ins> export class FileStorage { <del> private _database: StorageDatebase | null = null; </del> <ins> private _database: StorageDatabase | null = null; </ins> private lastFlushedSerializedDatabase: string | null = null; constructor(private dbPath: string, private onError: (error: Error) => void) { } <del> private get database(): StorageDatebase { </del> <ins> private get database(): StorageDatabase { </ins> if (!this._database) { this._database = this.loadSync(); }

Discussion:
there is a typo wrong spelled, which you can see here: hope this can be corrected :)
Change:
if (intersectedChange !== null) { // Each change needs to be disjoint so we check if we already added this line. if (lastLineAdded !== intersectedChange.modifiedStartLineNumber) { <del> result.push(intersectedChange); </del> <ins> result.push(new SelectedChange(intersectedChange, changes[i])); </ins> lastLineAdded = intersectedChange.modifiedEndLineNumber; } else { // Update change such that we do not add same line twice. intersectedChange.modifiedStartLineNumber++; if (intersectedChange.modifiedStartLineNumber <= intersectedChange.modifiedEndLineNumber) { <del> result.push(intersectedChange); </del> <ins> result.push(new SelectedChange(intersectedChange, changes[i])); </ins> lastLineAdded = intersectedChange.modifiedEndLineNumber; } }

Discussion:
There's probably already a feature request for this but I can't find it. I want to be able to select a change in the diff editor and revert it, same as how I can stage it. In SourceTree this is called "discard selected lines" although "revert" seems better, unless it's "discard selected changes". I'm working on a PR for this.
I think it is connected with
Change:
"7zip": "0.0.6", "@playwright/test": "1.27.1", "@swc/cli": "0.1.57", <del> "@swc/core": "1.2.245", </del> <ins> "@swc/core": "1.3.32", </ins> "@types/cookie": "^0.3.3", "@types/copy-webpack-plugin": "^6.0.3", "@types/cssnano": "^4.0.0",

Discussion:
In this build output, there's some error in SWC, but it's not emitted I'm guessing_ it's because I use the operation and they don't support that yet, or our version of TS doesn't.
Please don't use for the time being
will also update to latest SWC so that satisfies is supported
This will now print SWC errors as they are <img width="687" alt="Screenshot 2023-02-02 at 11 59 36" src="https://user-"
Change:
} .monaco-workbench.web { <del> touch-action: initial; /* reenable touch events on workbench */ </del> <ins> touch-action: none; /* Disable browser handling of all panning and zooming gestures. Removes 300ms touch delay. */ </ins> } @keyframes fadeIn { from { opacity: 0; } to { opacity: 1; } }

Discussion:
I recently came across CSS rule. According to the : I do not think we want the panning and zooming, but the removal of the 300ms delay sounds great to get a more snappy UI when using touch for e.g. action bars. Maybe worth a try?
I wonder if would even be the right thing, but not sure it removes the 300ms delay:
Interesting, I see we use this property already, e.g. in the list:
Worth experimenting with. do you remember why you that css property for the list? For now assigning to June, might push out due to lack of time.
Did not have time, pushing out to August, since in July I am on vacation
Probably for the 300ms removal.
Adding bug, so we get this verified. Steps: ipad. sure the touch behaves as expected in the editor and some views touch triggers context menu
feels pretty snappy to me!
Change:
private async getGalleryExtensions(extensions: InstallExtensionInfo[]): Promise<Map<string, IGalleryExtension>> { const galleryExtensions = new Map<string, IGalleryExtension>(); const preRelease = extensions.some(e => e.installOptions.installPreReleaseVersion); <del> const result = await this.extensionGalleryService.getExtensions(extensions.map(e => ({ ...e, preRelease })), CancellationToken.None); </del> <ins> const targetPlatform = await this.extensionManagementService.getTargetPlatform(); const result = await this.extensionGalleryService.getExtensions(extensions.map(e => ({ ...e, preRelease })), { targetPlatform }, CancellationToken.None); </ins> for (const extension of result) { galleryExtensions.set(extension.identifier.id.toLowerCase(), extension); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.3 OS Version: linux Steps to Reproduce: a codespace on github in Web (browser), and uninstall extension if it installed. in terminal. It will be fail. (What I expect is success.) in terminal. It will be success.
<img width="762" alt="image" src="https://user-"
It works for me - I mean I can install the extension in codespace . Can you please provide a sample codespace where I can repro this?
Thanks for your reply! I going to provide 2 ways to reproduce this bug. in browser. . . It will be fail. <img width="1447" alt="image" src="https://user-"<img width="665" alt="image" src="https://user-"We can reproduce by running this , because this repo is fork from vscode. in the terminal of your computer. in your browser. . It will be fail. <img width="697" alt="image" src="https://user-"
If begins with , such as , it will be fail. If not begins with , such as , it will be success. <img width="686" alt="image" src="https://user-"
This seems to happen when you open codespace in web
Change:
height: calc(100% - 36px); position: relative; overflow: hidden; <ins> user-select: text; </ins> } .extension-editor > .body > .content.loading {

Discussion:
VSCode Version: Code 1.15.0 (, 2017-08-09T20:06:21.685Z) OS Version: Darwin x64 16.7.0 Extensions: ExtensionVersion ------ vscode-generate-getter-setter0.4.2 bazel-code0.1.8 path-intellisense1.4.2 vscode-svgviewer1.4.2 vscode-eslint1.2.11 gitlens4.3.3 tslint0.17.0 git-project-manager1.3.2 auto-rename-tag0.0.14 docthis0.4.7 contextualduplicate0.2.0 debugger-for-chrome3.1.7 vscode-subword-navigation1.1.5 Align0.2.0 rewrap1.4.2 clang-format1.5.0 vscode-proto30.1.2 (3 theme extensions excluded) Steps to Reproduce: an extension to its Contributions tab to copy its command, e.g. Expected Results: Adding keybindings for an extension should be really easy; at the very least, copy/paste should work. Actual Results: I can't select text, so I can't copy it.
Change:
import { isWindows } from 'vs/base/common/platform'; import URI from 'vs/base/common/uri'; import { Selection } from 'vs/editor/common/core/selection'; <del> import { SelectionBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, ClipboardBasedVariableResolver } from 'vs/editor/contrib/snippet/snippetVariables'; </del> <ins> import { SelectionBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, ClipboardBasedVariableResolver, TimeBasedVariableResolver } from 'vs/editor/contrib/snippet/snippetVariables'; </ins> import { SnippetParser, Variable, VariableResolver } from 'vs/editor/contrib/snippet/snippetParser'; import { TextModel } from 'vs/editor/common/model/textModel'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';

Discussion:
Edit: Sorry if this is a terrible issue... The current list of variables available when writing a snippet can be found . Existing variables expose great contextual information - such as current file, directory, line number, word, etc. Development happens so fast that information can become outdated, so knowing when some custom snippets were inserted could be useful. For example, when creating files or adding comments. My current use case is a snippet that inserts copyright headers. The key binding inserts the header: It would help to include the date: and could also apply to updates or comments: Doing so could mean a simple variable like , but that may not work for non-US users who's date format is different i/e not month/day/year. Perhaps exposing the variables separately such as , etc or localization can help? I'd like to know if there is any interest in this. I know an extension could do this but it seems like overkill, but that could depend on potential use cases. Thanks for any feedback.
Hm, this is dupe of many requests we have gotten around this but made a valid point. Adding variables for year, month, day and hour, minute, second makes sense. That will allow anyone to compose it's own date. So, yeah feel free to drop a PR
Good to hear. Thanks for the PR!