jiebi/CodeConvo huggingface dataset:
Change:
contextKey.set(true); this.compositeBar.addComposite({ id: viewContainer.id, name: viewContainer.title, order: viewContainer.order, requestedIndex: viewContainer.requestedIndex }); <del> const activeComposite = this.getActiveComposite(); if (activeComposite === undefined || activeComposite.getId() === viewContainer.id) { this.compositeBar.activateComposite(viewContainer.id); </del> <ins> if (this.layoutService.isVisible(this.partId)) { const activeComposite = this.getActiveComposite(); if (activeComposite === undefined || activeComposite.getId() === viewContainer.id) { this.compositeBar.activateComposite(viewContainer.id); } </ins> } this.layoutCompositeBar();

Discussion:
Issue Type: <bBug</bWhen closing the Python interactive window the Terminal panel shows itself. ! VS Code version: Code 1.67.0 (, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <details<summaryExtensions (8)</summaryExtensionVersion ------ remotehub0.32.0 python2022.6.0 vscode-pylance2022.4.3 jupyter2022.4. jupyter-keymap1.0.0 jupyter-renderers1.0.6 remote-repositories0.6.0 markdown-all-in-one3.4.3 </details<!-- generated by issue reporter --
what's the recommended approach to debug this? I'm not sure who is opening the terminal (but I know it's not notebook or iw as it's the editor tab close button)
I debugged this, and determined that when the interactive window is closed, it updates a context key which hide a view container in the panel. this incorrectly triggers the panel to show.
Change:
renderTemplate(container: HTMLElement): ResourceTemplate { const element = append(container, $('.resource')); const name = append(element, $('.name')); <del> const fileLabel = this.labels.create(name, { supportHighlights: true }); </del> <ins> const fileLabel = this.labels.create(name, { supportDescriptionHighlights: true, supportHighlights: true }); </ins> const actionsContainer = append(fileLabel.element, $('.actions')); const actionBar = new ActionBar(actionsContainer, { actionViewItemProvider: this.actionViewItemProvider,

Discussion:
I often make a lot of changes at once, and then need to commit them. Some changes don't belong together in the same commit, and some aren't ready to be committed at all. The current UI allows me to select some files to be staged for commit and exclude others, but it requires me to carefully select my changes from a potentially very long list. It would be incredibly useful if I could search or filter files by path pattern and stage/unstage all search results. Even better would be if I could search for lines of code and either stage files containing those lines or just the matched lines. This would streamline my git workflow by a lot.
I guess my ideal UI would allow me to: search files by path, and stage/unstage all matched files stage/unstage individually selected files search code in files, and stage/unstage all matched lines stage/unstage individually selected lines stage/unstage all matched files stage/unstage individually selected files
Since last month, SCM supports fancy keyboard navigation and filtering. Simply start typing when focused on the view. A widget will appear which you can use to toggle between simple highlighting and filtering. Currently filtering is done only on file names though, not paths or even code, so I can leave this open for additional filtering fields.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
position: relative; } <del> .code-active-line:before { </del> <ins> .code-active-line:before, .code-line:hover:before { </ins> content: ""; display: block; position: absolute; top: 0; left: -12px; height: 100%; <ins> } .code-active-line:before { </ins> border-left: 3px solid rgba(0, 122, 204, 0.5); } .code-line:hover:before { <del> content: ""; display: block; position: absolute; top: 0; left: -12px; height: 100%; </del> border-left: 3px solid #4080D0; }

Discussion:
The current behaviour of Code's Markdown previewer when clicking a relative link is actually a bit cryptic: it attempts to open the file relative to the user's home path with the system's application of choice. This will commonly lead to errors being dispatched because the file cannot be found. If I have the following Markdown: Clicking the link will make my system attempt to open . Given that even , I strongly believe that they should be supported here. Such links should instead be relative to the markdown file's directory and open the linked file using the Code editor.
+1; opening markdown files by clicking a (relative) link in the preview would be a very powerful feature both for writing developer documentation (split into individual files by topic) for a project, but also for viewing that documentation.
Related: Is this behavior something vscode could change for its markdown preview?
Change:
readOnly: false, renderIndicators: false, diffAlgorithm: 'advanced', <ins> ignoreTrimWhitespace: false, </ins> stickyScroll: { enabled: false } };

Discussion:
This diff confused me for a bit. ! There's a trailing space at the end of the line but it's not highlighted. This would be even more confusing if you have non-visible whitespace (I think that's the default).
I bet you disabled whitespace diffing. Why should this setting be ignored now?
I have set, which means whitespace should show right? Setting to true doesn't show it either. Am I looking at the wrong setting? The why even if it's ignored is I click for more info and it shows nothing which confused me, I can understand why you wouldn't want to handle it specially though.
Change:
} private _delayedUpdateHistory() { <del> this._updateHistoryDelayer.trigger(this._updateHistory.bind(this)); </del> <ins> this._updateHistoryDelayer.trigger(this._updateHistory.bind(this)).then(undefined, onUnexpectedError); </ins> } private _updateHistory() {

Discussion:
The find widget's update history is wrapped in a delayer promise which can cause an unhandled promise rejection when the widget is getting disposed of if the delayer's completion promise hasn't been cleanup up. This can happen if the editor is closed before the find widget has time to finish closing. This change addressed the issue by handling the rejected promise returned by . <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.51.1 OS Version: macOS Steps to Reproduce: new editor. -F to open the find widget. to close the find widget and quickly close the editor before the widget has time to close.
Change:
const classNames = toRender[lineIndex]; let lineOutput = ''; for (let i = 0, len = classNames.length; i < len; i++) { <del> lineOutput += '<div class="cldr ' + classNames[i] + common; </del> <ins> lineOutput += '<div class="cldr ' + classNames[i][0] + common; </ins> } output[lineIndex] = lineOutput; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --On (), folding icon is invisible in the gutter, but clicking it works: https://user- Version: 1.78.0-insider Commit: Date: 2023-04-17T05:16:14.521Z Browser: Chrome/112.0.0.0 Safari/537.36
I am also seeing this in desktop Insiders today: Version: 1.78.0-insider Commit: Date: 2023-04-17T05:26:43.771Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.78.0-insider Chrome/108.0.5359.215 Electron/22.4.5 Safari/537.36 Maybe related to
Caused by
Change:
}, { "command": "git.revealFileInOS.linux", <del> "when": "scmProvider == git && scmResourceGroup == index && resourceScheme == file && isLinux", </del> <ins> "when": "scmProvider == git && scmResourceGroup == index && remoteName == '' && isLinux", </ins> "group": "2_view@2" }, { "command": "git.revealFileInOS.mac", <del> "when": "scmProvider == git && scmResourceGroup == index && resourceScheme == file && isMac", </del> <ins> "when": "scmProvider == git && scmResourceGroup == index && remoteName == '' && isMac", </ins> "group": "2_view@2" }, { "command": "git.revealFileInOS.windows", <del> "when": "scmProvider == git && scmResourceGroup == index && resourceScheme == file && isWindows", </del> <ins> "when": "scmProvider == git && scmResourceGroup == index && remoteName == '' && isWindows", </ins> "group": "2_view@2" }, {

Discussion:
Testing Open a git repository from WSL Modify files and save Go to SCM view, right click on a change Click on "Reveal in File Explorer" Nothing happens
The latest Insiders has been updated, so that the new menu item does not appear when connected to a remote.
<img width="307" alt="image" src="https://user-"Reveal in File Explorer is gone . However Open Containing Folder is there and it does do anything either.
Change:
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <ins> import { IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput'; </ins> import { themeColorFromId } from 'vs/platform/theme/common/themeService'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; import { EditorLineNumberContextMenu, GutterActionsRegistry } from 'vs/workbench/contrib/codeEditor/browser/editorLineNumberMenu';

Discussion:
the setup of microsoft/vscode-python click the Test gutter decoration Numbers appear in random order: <img width="485" alt="image" src=""Also, if you change to , you'll get a very slow opening menu. cc
Maybe we should have a "X more tests..." item that opens a quickpick after like 10. What do you think
yeah agreed that its not worth displaying more than 10 tests in a quick pick and I think the "X more tests..." will be a good way to tell users
Change:
} private async autoStoreEditSession() { <del> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown' && !isWeb) { const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('store working changes', 'Storing working changes...') }, async () => this.storeEditSession(false, cancellationTokenSource.token), () => { cancellationTokenSource.cancel(); cancellationTokenSource.dispose(); }); } </del> <ins> const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('store working changes', 'Storing working changes...') }, async () => this.storeEditSession(false, cancellationTokenSource.token), () => { cancellationTokenSource.cancel(); cancellationTokenSource.dispose(); }); </ins> } private registerViews() {

Discussion:
Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width="955" alt="image" src="https://user-"
In web we probably cannot support the value.
This is still on
I cannot reproduce this, just to be sure this is on the latest
Yes, reproduces even with caches disabled: !
Change:
when: ContextKeyExpr.and(ContextKeyExpr.equals('extensionStatus', 'installed'), ContextKeyExpr.has('isDefaultApplicationScopedExtension').negate(), ContextKeyExpr.has('isBuiltinExtension').negate(), ContextKeyExpr.equals('isWorkspaceScopedExtension', false)), order: 3 }, <del> run: async (accessor: ServicesAccessor, id: string) => { const extension = this.extensionsWorkbenchService.local.find(e => areSameExtensions({ id }, e.identifier)); </del> <ins> run: async (accessor: ServicesAccessor, _: string, extensionArg: IExtensionArg) => { const uriIdentityService = accessor.get(IUriIdentityService); const extension = extensionArg.location ? this.extensionsWorkbenchService.installed.find(e => uriIdentityService.extUri.isEqual(e.local?.location, extensionArg.location)) : undefined; </ins> if (extension) { return this.extensionsWorkbenchService.toggleApplyExtensionToAllProfiles(extension); }

Discussion:
For reference: I have found some peculiar things with the implementation, which I am not sure is by design or not. But here comes one: When working with remotes, such as remote ssh, I can see an extension in the "local" windows (greyed out) and in the remote window (not greyed out) in case it prefers to run on the remote extension host. But when I right-click on the local extension and select "Apply Extension to all Profiles" it does nothing. If I click it in the remote extension window and do the same, it gets the check mark. (But still not in the local window). As I suspect the intention behind "Apply Extension to all Profiles" is to actually apply it to all profiles, I should be able to right click and select it, so it gets selected, in all views under "Extensions". ( was also something I found needed.)
Thanks for the feedback. First request is a valid request. Can you please give more details about the second request? I would suggest to extract it into a new issue and provide exact steps to reproduce the issue.
I broke up the second item to a new issue: Let me know if still is not clear enough, and possibly which part.
is this an easy fix? I think it will clear up some confusion. I am surprised more people have not noticed and upvoted this, as local team members found this by themselves. It is causing quite a bit of confusion UX wise.
To verify: Open a remote window (WSL or Dev Container or SSH) Have an extension installed locally and remotely In Local Installed Extensions Section, Right click on the extension and apply it to all profiles. Verify that it also applies for the extension is remote installed extensions section. Verify vice-versa
Change:
} }; <del> this._register(_editor.onDidChangeModel(() => { </del> <ins> this._dispoables.add(_editor.onDidChangeModel(() => { </ins> this._recomputeState(); installSelectionListener(); })); <del> this._register(_configurationService.onDidChangeConfiguration(e => { </del> <ins> this._dispoables.add(_configurationService.onDidChangeConfiguration(e => { </ins> if (e.affectsConfiguration('notebook.outline.showCodeCells')) { this._recomputeState(); } })); <del> this._register(themeService.onDidFileIconThemeChange(() => { </del> <ins> this._dispoables.add(themeService.onDidFileIconThemeChange(() => { </ins> this._onDidChange.fire({}); })); <del> this._register(_notebookExecutionStateService.onDidChangeCellExecution(e => { </del> <ins> this._dispoables.add(_notebookExecutionStateService.onDidChangeCellExecution(e => { </ins> if (!!this._editor.textModel && e.affectsNotebook(this._editor.textModel?.uri)) { this._recomputeState(); }

Discussion:
Testing Setting Open a github issue notebook You get: <img width="283" alt="image" src="https://user-"
Change:
} private checkForMaliciousExtensions(): Promise<void> { <del> return this.extensionsManagementService.getExtensionsControlManifest().then(report => { const maliciousSet = getMaliciousExtensionsSet(report); </del> <ins> return this.extensionsManagementService.getExtensionsControlManifest().then(extensionsControlManifest => { </ins> return this.extensionsManagementService.getInstalled(ExtensionType.User).then(installed => { const maliciousExtensions = installed <del> .filter(e => maliciousSet.has(e.identifier.id)); </del> <ins> .filter(e => extensionsControlManifest.malicious.some(identifier => areSameExtensions(e.identifier, identifier))); </ins> if (maliciousExtensions.length) { return Promises.settled(maliciousExtensions.map(e => this.extensionsManagementService.uninstall(e).then(() => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --When installing an extensions with , users can freely install extensions which are malicious, which is not possible from the UI. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0 OS Version: macOS 13 Steps to Reproduce: your 's to . a terminal inside of VS Code The CLI either refuses to install these extensions or warns the user.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Sorry, mistyped the version by one patch release, all fixed now.
Can you please let me know which extension you are trying to install that is malicious and VS Code allows it from CLI?
that would be any extension list that I tried and exists in the Marketplace, for example installs just fine although not allowing me to install via the UI <img width="725" alt="image" src="https://user-"
Change:
set(_target: T, p: PropertyKey, value: any): boolean { idle.value[p] = value; return true; <ins> }, getPrototypeOf(_target: T) { return ctor.prototype; </ins> } }); }

Discussion:
In this state: <img width="418" alt="image" src="https://user-"I expect to be able to hit the up arrow to loop around to the last refactor action, but I cannot
I think this may have been introduced by the refactoring
the actions are getting registered and the context key looks correct, but never happens of the action
that's because the key input isn't getting sent to the workbench https://user-
Change:
wordWrap: 'off', diffWordWrap: 'off', diffAlgorithm: 'advanced', <ins> renderSideBySide: true, useInlineViewWhenSpaceIsLimited: false </ins> };

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest Insiders OS Version: N/A Steps to Reproduce: Open a Jupyter Notebook Make changes changes to the cell and view the diff (scm or timeline) issues left padding in the first code cell. (on the left of there is no padding unlike the one on right) centers of code and metadata are not aligned ceneters of code and metadata have different styles (code cells have a gap, but metadata have a gap with some shadow effect) VS Code (or the diff editor) You'll notice that metadata diff view resizes and finally collapses into one But this is not the case with the code cells, i think the width is hard coded for code cells On wide screens there's a lot of white space on the far right of the right most code cell) !
What are actionables I should look into? I think the top thing is not a diff editor. The gutter comes from
Closing this for now, as this can no longer be replicated.
Change:
type: TerminalBuiltinLinkType.Search }); deepStrictEqual(activationResult, { <del> link: 'file:///space%20folder/foo/bar.txt', </del> <ins> link: 'file:///c%3A/space%20folder/foo/bar.txt', </ins> source: 'editor', selection: { startColumn: 5,

Discussion:
My project is under https://user- Reproduce steps: vscode open a folder which file path contains space, for example: an integrated terminal the path link Versions:
nice I can repro with the space in the name, thanks for following up
I can still repro with Windows.
I looked into this, and it will be tricky because we currently use space as one of the characters which indicates the end of a path. One idea would be to check if such a link exists (using our original regex) and if not, use regex on the subsequent sequence - then concatenating the two results for First result would be doesn't exist process exists
https://user- Look the above video, I have several questions. path is not a existed path in the disk, but also clickable. I click the , it open a file which is not why the whole string is recogonized to a path? the real path is:
this is actually about when the parents of the link have a space, it's expected currently that an absolute path with a space won't work.
is it expected that a local link with a space somewhere within the path is not detected? that is the case currently - verified via adding a test to
absolute paths (eg. ) won't work because of Relative paths without spaces with absolute ancestors that have spaces (eg. inside ) should work but don't in some cases.
When verifying, make sure to test both on a Windows machine and a non-Windows machine.
Doesn't work for me on a Mac, I guess thats probably because I still haven't got the fix in the latest insider build.
are you on ?
Worked for me on macOS. Don't have a Windows machine to try this out so someone else will need to verify on Windows.
Yes, I'm on that same version. Here's what it looks like for me on a Mac with spaces !
still not work in latest version: https://user-
For absolute paths, see I wasn't able to get to work, though. It'd open the file, but place the cursor at the beginning.
please provide some more details, it works for me: !
This is the behaviour with version 1.70.0 After ctrl+clik a popup appears at the top of the screen and I have to hit enter to go to the suggested file:line.
I can repro that on Windows, Remote-WSL and macOS.

The file must not be in the root directory for this to happen. !
let's track that problem in and as this issue is becoming quite unwieldy/unfocused.
created to track the problem related to quotes you're seeing. Could you re-verify this if all good outside of these 3 issues I created? It's difficult to manage this issue as it's so general.