jiebi/CodeConvo huggingface dataset:
Change:
const target = editorGroupService.activeGroup; for (const group of editorGroupService.getGroups(GroupsOrder.MOST_RECENTLY_ACTIVE)) { if (group === target) { <del> return; // keep target </del> <ins> continue; // keep target </ins> } editorGroupService.mergeGroup(group, target);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --Version: 1.54.1 Commit: Date: 2021-03-04T22:42:18.719Z Electron: 11.3.0 Chrome: 87.0.4280.141 12.18.3 V8: 8.7.220.31-electron.0 OS: Darwin x64 20.3.0 Steps to Reproduce: multiple editor groups Command Pallette "View: Join all editor groups" enter I expect that the editors groups would be joined into a single editor group. But nothing happens. If I use an alternative command "View: Join editor group with Next Group" it works as expected, joining the current editor with the next group. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.517 --- <!-- score: 0.463 --- <!-- score: 0.461 --<!-- potentialduplicatescomment --
Same here.
Change:
}); return editorAttachedPromise.then(() => { <del> this._revealRangeCommon(viewIndex, range, true, upwards); </del> <ins> this._revealRangeCommon(viewIndex, range, alignHint); </ins> }); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: a new notebook a code cell a markdown cell with a few lines such as follows Go into preview mode in markdown Edit first cell to get into notebook mode Arrow down to select markdown cell and hit enter Watch how the mardown cell scrolls up in the notebook view Go back to preview mode Scroll the notebook to view the first cell again and edit it Now select the markdown cell using the mouse Double click the mardown cell to edit it and wathc how it does not scroll!! I.e. using keyboard vs mouse results in different behaviour with scrolliing of the notebook. Ideally I would expect there to be no automatic scrolling when editing using keyboard, just as with mouse given the md cell is already in view we should not scroll this cell !
When pressing enter, we try to reveal the cursor selection in the cell editor into view by calling which uses the reveal type My expectation is it only scrolls the cell if it's out of the viewport but currently it always reveals the cell to the top of the viewport. Changing the reveal type to does fix the problem (as it should behave, here I'm not necessarily suggesting we change the reveal type in ).
Assigning to Feb milestone as the experience is quite bad. What surprised me is we didn't get user reports for this, which made me wonder how many users edit markdown cells after they are initially created.
Change:
import { DEFAULT_EDITOR_ASSOCIATION } from 'vs/workbench/common/editor'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; <del> import { NOTEBOOK_DIFF_EDITOR_ID } from 'vs/workbench/contrib/notebook/common/notebookCommon'; </del> <ins> import { CellEditType, NOTEBOOK_DIFF_EDITOR_ID } from 'vs/workbench/contrib/notebook/common/notebookCommon'; </ins> // ActiveEditorContext.isEqualTo(SearchEditorConstants.SearchEditorID)

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66 OS Version: Windows 11 Steps to Reproduce: diff view to revert the output changes :bug: after reverting the diff view still says there are deletions/additions output changes using the diff view :bug: stage the file and reopen the diff view, all the changes I reverted are back
Change:
const selectTheme = (theme, applyTheme: boolean) => { if (typeof theme.id === 'undefined') { // 'pick in marketplace' entry if (applyTheme) { <del> openExtensionViewlet(this.viewletService, 'tag:icon-theme'); </del> <ins> openExtensionViewlet(this.viewletService, 'tag:icon-theme '); </ins> } theme = currentTheme; }

Discussion:
Press , . Choose from the quick pick. The extension viewlet opens with pre-populated in the search box and the caret is at the end of the line, after the : ! If I start typing now (e.g. start looking for a theme) I don't get any results because I need a space between and whatever I'm searching for, in this case : ! It would be nice to add the space automatically so that I can just start typing, not having to remember to press space first.
Change:
if (isLocal) { items.push({ <ins> accelerator: 'Alt+E', </ins> label: localize('killProcess', "Kill Process"), click: () => { this.nativeHostService.killProcess(pid, 'SIGTERM');

Discussion:
re open process explorer open context menu for an entry :bug: no keybindings are rendered, tho some are bound <img width="421" alt="Screenshot 2023-01-25 at 14 33 33" src="https://user-"
Change:
override layout(width: number, height: number): void { super.layout(width, height); <del> if (useWindowControlsOverlay(this.configurationService, this.environmentService) || </del> <ins> if (useWindowControlsOverlay(this.configurationService) || </ins> (isMacintosh && isNative && getTitleBarStyle(this.configurationService) === 'custom')) { // When the user goes into full screen mode, the height of the title bar becomes 0. // Instead, set it back to the default titlebar height for Catalina users

Discussion:
I tried enabling it in my Code-OSS settings but it didn't seem to work. The sentence from that I quoted make me think it had been hardwired off in Code-OSS. I haven't searched the codebase yet though. Originally posted by in
OSS does seem to have the WCO disabled. says that WCO was disabled in OSS due to upstream issues, but there's been a bunch of fixes recently, so it's probably OK to enable it again.
Verification steps: the WCO in OSS by enabling the setting. VS Code when prompted and change the colour theme. Windows 11, one can verify the WCO has been enabled by checking that the snap layout UX is available. On Windows 10, one can verify the WCO has been enabled by switching through colour themes and checking that the area with the minimize/maximize/close buttons updates its colours before the rest of the titlebar does.
Change:
} async cherryPick(commitHash: string): Promise<void> { <del> const args = ['cherry-pick', commitHash]; await this.exec(args); </del> <ins> try { await this.exec(['cherry-pick', commitHash]); } catch (err) { if (/The previous cherry-pick is now empty, possibly due to conflict resolution./.test(err.stderr ?? '')) { // Abort the cherry-pick operation await this.exec(['cherry-pick', '--abort']); err.gitErrorCode = GitErrorCodes.CherryPickEmpty; } throw err; } </ins> } async blame(path: string): Promise<string> {

Discussion:
Testing ! After pressing "Cancel" here I would have expected my changes view to be clean, but I was still in cherry-pick mode and had to run
I am still left in a state that is not clean: !
Can you please click on "Show Command Output" and share the output. Cannot pause the git to actually read it...
There are two distinct scenarios that may result in a cherry pick failing: are already present. In this case we will abort the cherry-pick operation. conflict (second scenario that you have shared). In this case VS Code will show a notification and users will have to manually resolve the merge conflict (code lens or merge editor) before committing. This aligns with the merge/rebase flows already present.
Change:
const lineNumber = position.lineNumber <= 1 ? 1 : 1 + position.lineNumber; <ins> const scrollTop = this.editor.getScrollTop(); </ins> const lineTop = this.editor.getTopForLineNumber(lineNumber); const zoneTop = lineTop - height.pixelsValue; const editorHeight = this.editor.getLayoutInfo().height; <del> const newLineBottom = this.editor.getBottomForLineNumber(lineNumber); </del> <ins> const lineBottom = this.editor.getBottomForLineNumber(lineNumber); </ins> <del> let newTop: number; if (newLineBottom > editorHeight) { newTop = newLineBottom - editorHeight; } else { newTop = zoneTop; } const currentTop = this.editor.getScrollTop(); </del> <ins> let newScrollTop = zoneTop; let forceScrollTop = false; </ins> <del> // console.log('REVEAL ZONE TOP', { zoneTop, newLineBottom, editorHeight, currentTop, newTop }); </del> <ins> if (lineBottom >= (scrollTop + editorHeight)) { // revealing the top of the zone would pust out the line we are interested it and // therefore we keep the line in the view port newScrollTop = lineBottom - editorHeight; forceScrollTop = true; } </ins> <del> if (newTop < currentTop) { this.editor.setScrollTop(newTop, ScrollType.Immediate); </del> <ins> if (newScrollTop < scrollTop || forceScrollTop) { this._logService.trace('[IE] REVEAL zone', { zoneTop, lineTop, lineBottom, scrollTop, newScrollTop, forceScrollTop }); this.editor.setScrollTop(newScrollTop, ScrollType.Immediate); </ins> } }

Discussion:
start inline on a line in the middle of the view port :bug: when the zone shows, the "focus line" is scrolls towards the bottom
Change:
BranchAlreadyExists: 'BranchAlreadyExists', NoLocalChanges: 'NoLocalChanges', NoStashFound: 'NoStashFound', <del> LocalChangesOverwritten: 'LocalChangesOverwritten' </del> <ins> LocalChangesOverwritten: 'LocalChangesOverwritten', NoUpstreamBranch: 'NoUpstreamBranch' </ins> }; function getGitErrorCode(stderr: string): string | undefined {

Discussion:
VSCode Version: Code 1.14.0 (, 2017-07-10T18:24:22.120Z) OS Version: Darwin x64 16.6.0 When working on a new branch and trying to when no upstream branch has been set, an error pops up stating: It would be nice if it could ask for the user to input a branch name to set as an upstream branch for the local one.
We should instead ask the user if he wants to the branch instead. Want to attempt a PR?
I'm in the beginning, but I would like to contribute. Can you give me some initial help? To define the problem... I could check if the upstream is set and If I did not set, call up the "push to ..." function?
You don't need to check if the upstream is set. You can actually try to figure out which error comes from git (). If you detect that the error is related to the fact that there is no upstream branch configured, you can ask the user whether he wants to publish the current branch in a message. If so, just run the command.
[ the link is broken. I try to debug the git extension but the breakpoint, It does not work because source map not present... how to ? system osx sierra 10.12.5 (16F73) vscode 1.14.1 (1.14.1)]
Fixed the link. Debugging is currently not set up. Sorry.
right link ok. So i add the if condition, in try catch block related to ?
It seems to me this message: git remote -v pipop /Users/userpippo/Desktop/progetti/remote/ (fetch) pipop /Users/userpippo/Desktop/progetti/remote/ (push) git push fatal: No configured push destination. .... or this ? git push pipop fatal: The current branch master has no upstream branch. To push the current branch and set the remote as upstream, use git push --set-upstream pipop master
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .suggest-input-container { padding: 3px 4px 5px; } .suggest-input-container .monaco-editor-background, .suggest-input-container .monaco-editor, .suggest-input-container .mtk1 { /* allow the embedded monaco to be styled from the outer context */ background-color: transparent; color: inherit; } .suggest-input-container .suggest-input-placeholder { position: absolute; z-index: 1; overflow: hidden; white-space: nowrap; text-overflow: ellipsis; pointer-events: none; margin-top: 2px; margin-left: 1px; } .suggest-input-container .monaco-editor .suggest-widget.no-icons .monaco-list .icon { display: none; } </del>

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.2 OS Version: kubuntu 18.04 Steps to Reproduce: some text to extension search bar it (by the way I can only select whole text, not part of it) isn't copied to the second clipboard (this is linux specific, middle button clipboard) ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.481 --<!-- potentialduplicatescomment --
Does this work as expected when you select text from other search boxes? For example: The find widget in the editor?
As you see on gif, it works as expected on search box
What about from the editor? Open a file and try the same on the text in the file.
It works everywhere except extension search field. I'm sure it occurred after intellisence in this bar was introduced
If that tiny editor would include the contribution, it would begin to work.
The problem is that the editor lives in the layer and uses the clipboard from electron. Do you recall the need to have the in the layer and not in the layer? Note: This issue will also affect the search in the new Settings editor
I think electron-browser is fine
Change:
return; } <del> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.options.orientation ?? Orientation.VERTICAL, this.themeService); </del> <ins> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.orientation ?? Orientation.VERTICAL, this.themeService); </ins> } if (dropData.type === 'composite' && dropData.id !== this.viewContainer.id) {

Discussion:
see: ! //cc
Good catch
To Verify: Panel to Right/Left dropping a view into the panel. feedback is horizontally split instead of vertically.
Change:
import 'mocha'; import * as os from 'os'; import * as vscode from 'vscode'; <del> import { closeAllEditors, delay, disposeAll } from '../utils'; </del> <ins> import { closeAllEditors, delay, disposeAll, flakySuite } from '../utils'; </ins> const webviewId = 'myWebview';

Discussion:
Couple of milestones ago I have skipped these tests becuase they were failing. I am not sure if I created the issue at the moment but I am doing that now. Sorry if I did not ping sooner. Code pointer
I had to revert this change: I think they cause our browser integration tests to hang/fail:
Change:
const next = displayParts[i + 1]; // Skip optional parameters const nameIsFollowedByOptionalIndicator = next && next.text === '?'; <del> if (!nameIsFollowedByOptionalIndicator) { </del> <ins> // Skip this parameter const nameIsThis = part.text === 'this'; if (!nameIsFollowedByOptionalIndicator && !nameIsThis) { </ins> parts.push(part); } hasOptionalParameters = hasOptionalParameters || nameIsFollowedByOptionalIndicator;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.3 OS Version: Darwin x64 18.7.0 Steps to Reproduce: completeFunctionCall new tyepscript file, ype cursor at <kbdTAB</kbdExpected: Actual: Does this issue occur when all extensions are disabled?: Yes/No
Change:
} )) as WorkbenchTable<IDisassembledInstructionEntry>; <ins> this._disassembledInstructions.domNode.classList.add('disassembly-view'); </ins> if (this.focusedInstructionReference) { this.reloadDisassembly(this.focusedInstructionReference, 0); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.91.1 Commit: Date: 2024-07-09T22:06:49.809Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView with an TreeItem the TreeItem's iconPath to the extension. The TreeItem's icon will still be yellow same as in debugging. After inspecting developer tools, this is likely due to how the icon debug-stackframe's color rule is set to !important. The ThemeColor fails to overwrite it due to low specificity. This may not only happen with the icon "debug-stackframe" and is affecting customisations of treeitems. Why is some icons' color rules given the !important flag et al? There might not be any easy fix due to this flag's present. I hope the team could look into it, and if possible fix this selector specificity issue (if it won't break vscode, somehow).
Edit: This not only occurs on special icons like debug-stackframe, but also on very ordinary ones like circle-filled.

style attribute { color: rgb(204, 204, 204); } .monaco-workbench .codicon { } Adding !important to the color flag of .monaco-workbench .codicon will fix the issue though.. The problem is worse :C
I think the best solution would be to get rid of that . it's coming from here. Can it be removed? The css you shared is correct. The rbg value is the one you set in your ThemeIcon. !
Yea, we should scope these rules better (and also move them to css now that we have variables there)
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
import { TaskTerminalStatus } from 'vs/workbench/contrib/tasks/browser/taskTerminalStatus'; import { ProblemCollectorEventKind, ProblemHandlingStrategy, StartStopProblemCollector, WatchingProblemCollector } from 'vs/workbench/contrib/tasks/common/problemCollectors'; import { GroupKind } from 'vs/workbench/contrib/tasks/common/taskConfiguration'; <del> import { CommandOptions, CommandString, ContributedTask, CustomTask, DependsOrder, ICommandConfiguration, IConfigurationProperties, IExtensionTaskSource, InMemoryTask, IPresentationOptions, IShellConfiguration, IShellQuotingOptions, ITaskEvent, PanelKind, RevealKind, RevealProblemKind, RuntimeType, ShellQuoting, Task, TaskEvent, TaskEventKind, TaskScope, TaskSettingId, TaskSourceKind } from 'vs/workbench/contrib/tasks/common/tasks'; </del> <ins> import { CommandOptions, CommandString, ContributedTask, CustomTask, DependsOrder, ICommandConfiguration, IConfigurationProperties, IExtensionTaskSource, InMemoryTask, IPresentationOptions, IShellConfiguration, IShellQuotingOptions, ITaskEvent, PanelKind, RevealKind, RevealProblemKind, RuntimeType, ShellQuoting, Task, TaskEvent, TaskEventKind, TaskScope, TaskSourceKind } from 'vs/workbench/contrib/tasks/common/tasks'; </ins> import { ITaskService } from 'vs/workbench/contrib/tasks/common/taskService'; import { IResolvedVariables, IResolveSet, ITaskExecuteResult, ITaskResolver, ITaskSummary, ITaskSystem, ITaskSystemInfo, ITaskSystemInfoResolver, ITaskTerminateResponse, TaskError, TaskErrors, TaskExecuteKind, Triggers } from 'vs/workbench/contrib/tasks/common/taskSystem'; import { ITerminalGroupService, ITerminalInstance, ITerminalService } from 'vs/workbench/contrib/terminal/browser/terminal';

Discussion:
I noticed this: We always want to add the sequences as it enabled command navigation, the decorations showing is purely a visual thing that hides the decoration button. So I suggest we remove the ShowDecorations check there and instead call into the terminal addon to disable the decoration.
To verify: repo (or any repo with a task that exits) the default build task to some file the test task it the test task it /ctrl+up should take you to the start of the task in step 6, not the very top of the terminal
I actually think we should remove the setting outright as we already have which essentially does the same thing. This would save us from exposing outside of the terminal part the ability to configure decoration visibility. Timeline: The terminal setting was as a boolean in Feb The task setting was in June The terminal setting was made more granular in July The interaction between the 2 settings confused someone in I'll leave the decision up to you whether we remove it, it feels like too much granularity to me as the user must like the terminal ones but not the task ones.
Let's remove it