jiebi/CodeConvo huggingface dataset:
Change:
"sql": "_db", "swift": "_swift", "typescript": "_typescript", <del> "typescriptreact": "_typescript", </del> <ins> "typescriptreact": "_react", </ins> "xml": "_xml", "dockercompose": "_docker_3", "yaml": "_yml",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Can the default file icon theme be updated in VS Code (seems just need to follow the to run the script) files should by now have the Maven (mvnw) icon but are still showing regular XML icon.
Verify that the files now have the Maven (mvnw) icon
Change:
return { id, label: lang, <ins> iconClasses: getIconClasses(this.modelService, this.modeService, this.getResource(lang)), </ins> description: (id === currentAssociation) ? nls.localize('currentAssociation', "Current Association") : undefined }; });

Discussion:
if you just want to 'Select Language Mode', languages has icons. but if you want to 'Configure File Association', languages has no icons
True, up for grab if someone wants to do it.
I'm going to work on it.
Change:
this.history = new HistoryNavigator(JSON.parse(this.storageService.get(HISTORY_STORAGE_KEY, StorageScope.WORKSPACE, '[]')), 50); this.filter = new ReplFilter(); this.filterState = new ReplFilterState(this); <ins> this.filter.filterQuery = this.filterState.filterText = this.storageService.get(FILTER_VALUE_STORAGE_KEY, StorageScope.WORKSPACE, ''); </ins> this.multiSessionRepl = CONTEXT_MULTI_SESSION_REPL.bindTo(contextKeyService); this.multiSessionRepl.set(this.isMultiSessionView);

Discussion:
I frequently use the debug console in VS Code to get output from my application but it's often cluttered with various log messages from services that I cannot control. These unwanted entries are easily filtered in the text field "Filter (e.g. text, !exclude)" box. I would like a setting to configure this default filter text per workspace. Currently I have to manually configure this filter each time I start VS Code. I could not find this in either default settings or through an extension.
This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks I would actually prefer if we would just preserve the filter across vscode reloads. I am open to Pull Requests that solve this. Code pointer
Great. I would be fine with it being preserved through reloads
Created PR fixing this
thanks a lot for that I have commented on the PR.
I am trying to verify this feature right now, but it isn't persisting upon reload on my side (running off of latest commit on main). Steps: extension filter to debug console debugging command palette to reload console's filter is empty again. Is my flow correct?
thanks for trying to verify this. However this fix is not yet released. Sorry for not specifying. Though we have this label that should help with that. So I will close this issue, and it would be great if you can try it out again tomorrow. Thank you!
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { assertNever } from 'vs/base/common/assert'; </ins> import { CancelablePromise, createCancelablePromise, RunOnceScheduler } from 'vs/base/common/async'; import { CancellationToken } from 'vs/base/common/cancellation'; import { onUnexpectedError, onUnexpectedExternalError } from 'vs/base/common/errors'; import { Emitter } from 'vs/base/common/event'; <ins> import { matchesSubString } from 'vs/base/common/filters'; </ins> import { Disposable, IDisposable, MutableDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { CoreEditingCommands } from 'vs/editor/browser/coreCommands'; import { IActiveCodeEditor } from 'vs/editor/browser/editorBrowser';

Discussion:
Testing when accepting the next word in a python file, the entire line is accepted, whereas typescript will only accept the next word.
Change:
private editor: ICodeEditor, @IDebugService private readonly debugService: IDebugService, @IInstantiationService private readonly instantiationService: IInstantiationService, <ins> @IMenuService private readonly menuService: IMenuService, @IContextKeyService private readonly contextKeyService: IContextKeyService, @IContextMenuService private readonly contextMenuService: IContextMenuService, </ins> ) { this.toDispose = [];

Discussion:
This is the debug hover: ! I think it would be great if each value has a context menu (or inline buttons) to trigger (contributable) actions. Built-in actions could be: copy value copy expression watch Actions contributed by extensions could be: visualize This is already supported in the sidebar: !
good overall idea and I like it. I think we could implement it fairly easily by adding a new menu type to the hover tree. We can even open it for extensions as you suggested. However I would be interested in what other apps do you know that have a context menu on the hover? Might this be a sort of an anti pattern? I know that the debug hover is a bit heavy and a context menu might fit well there, but I would be interested in how other products do it. Maybe try out Visual Studio, Chrome Dev Tools and others... fyi
I do believe that's using the tree widget, which supports inline actions: <img width="334" alt="CleanShot 2021-06-08 at 10 46 42 src="https://user-"I'd assume either a (though there is quite a bit already in these views) or: <img width="652" alt="CleanShot 2021-06-08 at 10 48 01 src="https://user-"<img width="659" alt="CleanShot 2021-06-08 at 10 48 46 src="https://user-"
VS has quite a few nested context menus :D 
I think that would be possible since it's a toolbar, we do show more inline actions in peek/diff views: <img width="157" alt="CleanShot 2021-06-08 at 10 57 38 src="https://user-"
Cool ideas. Maybe just a right click context menu might work best. But an additional gear on the end to make it discoverable will help. Ellipsis look good in the example you provided but in practice we have a lost of overflowing text and it is all shown with ellipsis, so I think it would be very confusing, as some ellipsis would be clickable and some not... is right, it can be made possible if we make it a toolbar, however I would be worried about opening inline actions to extensions since horizontal space is already limited. I would first only open secondary actions - the one behind a context menu. Though I am flexible.
can you verify this one?
Change:
/** * One or many menu items. */ <del> menu?: OneOrN<{ id: MenuId } & Omit<IMenuItem, 'command'>>; </del> <ins> menu?: OneOrN<{ id: MenuId; precondition?: null } & Omit<IMenuItem, 'command'>>; </ins> /** * One keybinding.

Discussion:
Type: <bBug</b- VS Code Version: 1.74.1 OS Version: Windows NT x64 10.0. Issue appeared just after upgrading VSCode to ver. 1.74.1 Currently, it is impossible to go to the function definition by clicking Ctrl+Click on the function name or using the F12 button. Also, the Go to definition option in Top Menu-Go-Go to Definition is disabled. VS Code version: Code 1.74.1 (, 2022-12-14T10:30:51.966Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
What code language? Is the option also disabled in the context menu? was a previous issue about this and related options not getting enabled in the top-level Go menu. Maybe this has come back. Do you think this didn't happen in 1.74.0?
- maybe caused by
Yeah, looks like the precondition for the command is too strong
Javascript I don't have such an option in the context menu I'm not 100% sure, which version I had previously installed, but I'm using VSCode almost every day, so I'm pretty sure I was using 1.74.0 or 1.73.1, and that behavior has occurred after auto-upgrade to 1.74.1. I've never noticed anything like it before.
After a clean uninstall (Uninstalled and deleted %APPDATA%Code and %USERPROFILE%.vscode), and installing 1.74.1 again, the problem does not occur anymore.
Change:
.monaco-editor .detected-link, .monaco-editor .detected-link-active { text-decoration: underline; <ins> text-underline-position: under; </ins> } .monaco-editor .detected-link-active {

Discussion:
when a link, src or url... contains an underscore character ( _ ) , you can't distinguish it from a misplaced space character because of the default underline below the links.
Appears to be impractical to solve using in Chromium until it fully adopts the full CSS 3 spec on . What I'll do is use a instead. Tested locally, and it looks good to me: <img width="454" alt="screen shot 2016-03-30 at 6 04 54 pm" src=""
Fixed via
Change:
semver "^5.3.0" tar "^4" <del> node-pty@0.7.7: version "0.7.7" resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.7.7.tgz#919a9de7f0462ee72b260a6e4d5459d28fde2d25" </del> <ins> node-pty@0.7.8: version "0.7.8" resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.7.8.tgz#9ed2f01f84263acc96982876e734aa75490bf3d8" </ins> dependencies: nan "2.10.0"

Discussion:
Issue Type: <bBug</bThe arguments of my task command are merely ignored whenever there are quotes inside them. Steps to reproduce an executable script that shows the number of arguments that are passed to it. I called it some task in the task the output Even the hello argument is ignored. Remove the quotes around world and the script will work: This bug makes the task feature unusable when quotes are required VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-25T05:31:33.193Z) OS version: WindowsNT x64 10.0. <!-- generated by issue reporter --
which shell (bash) are you using? WSL?
if the default task shell is the same as the default integrated terminal shell, then I am using Git Bash. I have this in
I am able to reproduce this using the following setup: Using ' around world works as expected. here is the shell launch config I use to start the terminal: <img width="1190" alt="capture" src="https://user-"Any advice you can give to make this work for " as quotes. In general the data looks good to me.
recently made a change in this area and might have an idea what's going on with this case.
Possible candidate, marking with September.
Change:
this._updateWidgetWidth(); } })); <del> this._register(this._editor.onDidChangeModel(() => updateScrollLeftPosition())); </del> <ins> this._register(this._editor.onDidChangeModel(() => { updateScrollLeftPosition(); this._updateWidgetWidth(); })); </ins> updateScrollLeftPosition(); this._register(this._editor.onDidLayoutChange((e) => {

Discussion:
This is a regression due to the work done on making sticky scroll sideways scrollable
Hi, what are some verification steps for this issue?
Hi ! Apologies for the lack of steps. So previously when you would sideways scroll, jump from file to file, this would cause the sticky widget to not have lines. It would be blank. So some verifications steps are: sticky scroll with several files which create sticky lines sideways in these files using the editor horizontal scrollbar. You may have to enable from file to file that the sticky lines are rendered correctly
Change:
import { Codicon } from 'vs/base/common/codicons'; import { URI, UriComponents } from 'vs/base/common/uri'; <ins> import { localize } from 'vs/nls'; </ins> import { IExtensionTerminalProfile, ITerminalProfile, TerminalIcon } from 'vs/platform/terminal/common/terminal'; import { ThemeIcon } from 'vs/platform/theme/common/themeService'; export function createProfileSchemaEnums(detectedProfiles: ITerminalProfile[], extensionProfiles?: readonly IExtensionTerminalProfile[]): { <del> values: string[] | undefined; </del> <ins> values: (string | null)[] | undefined; </ins> markdownDescriptions: string[] | undefined; } { <del> const result = detectedProfiles.map(e => { </del> <ins> const result: { name: string | null; description: string }[] = [{ name: null, description: localize('terminalAutomaticProfile', 'Automatically detect the default') }]; result.push(...detectedProfiles.map(e => { </ins> return { name: e.profileName, description: createProfileDescription(e) }; <del> }); </del> <ins> })); </ins> if (extensionProfiles) { result.push(...extensionProfiles.map(extensionProfile => { return {

Discussion:
Open default settings JSON: ! Version: 1.67.0-insider (user setup) Commit: Date: 2022-03-31T11:00:49.798Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Windows_NT x64 10.0.
windows and linux issue only - works on mac <img width="481" alt="Screen Shot 2022-03-31 at 11 16 55 AM" src="https://user-"
but not in the settings editor actually
I think it happens on mac too, was originally reported for .osx
any idea why null is not accepted here? We set null as a valid type along side enum/string:
any thoughts as I know you did some work related to enum settings?
Not sure, but I get a mysterious result in the suggestions: !
yeah that should be
If enums are defined, you need to add as a valid value to the enums as well
I believe null is already one of the enum values
The completion values are composed of enum, default and more. The validation only looks at at enum values. So I'm quite sure the num values don't contain null, as the hover shows: !
Change:
this.bodyContainer.classList.add('welcome'); this.viewWelcomeContainer.innerText = ''; <del> let buttonIndex = 0; </del> for (const { content, preconditions } of contents) { <ins> let buttonIndex = 0; </ins> const lines = content.split('n'); for (let line of lines) {

Discussion:
Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual "NO FOLDER OPEN" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.
Similarly on the Source Control view, it starts with a message saying "No source control providers registered" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like "Please wait while we look for source control providers". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display "No source control providers registered".
This will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.
On this, we could potentially add a message.
That might help.
Closing this until we get actual user feedback that it's needed, sorry
Change:
} fn privacy_to_tunnel_acl(privacy: PortPrivacy) -> TunnelAccessControl { <del> let mut acl = TunnelAccessControl { entries: vec![] }; if privacy == PortPrivacy::Public { acl.entries .push(tunnels::contracts::TunnelAccessControlEntry { </del> <ins> TunnelAccessControl { entries: vec![match privacy { PortPrivacy::Public => tunnels::contracts::TunnelAccessControlEntry { </ins> kind: tunnels::contracts::TunnelAccessControlEntryType::Anonymous, provider: None, is_inherited: false,

Discussion:
Testing It shows the error's message, but doesn't make explicit that there was an error thrown. ! This is from:
Change:
return; } <del> // Expand all stats in the parent chain let item: ExplorerItem | undefined = this.explorerService.roots.filter(i => isEqualOrParent(resource, i.resource))[0]; </del> <ins> // Expand all stats in the parent chain. let item: ExplorerItem | undefined = this.explorerService.roots.filter(i => isEqualOrParent(resource, i.resource)) // Take the root that is the closest to the stat #72299 .sort((first, second) => second.resource.path.length - first.resource.path.length)[0]; </ins> while (item && item.resource.toString() !== resource.toString()) { await this.tree.expand(item);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33.1 OS Version: Ubuntu 18.04 Steps to Reproduce: It should be noted that this behavior (bug?) was introduced during the latest version. the following structure tree view of these workspaces is correct. When everything is folded it shows like this: the files then , located under app (workspaceFolder). The tree view become like this. open in the editor, click on tab. The tree view become like this. While it should stay the same it was in step 3. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Oh the item is reveald in every root, except just in one. Is that what you are tying to say?
When I click a tab of an opened file, the treeview unfolds the root workspace (outermost) to show the file. Instead, it should show the file in the innermost workspace (the closest one to the file).
I rolled back to an old version. It was still working perfectly well up to version 1.32.3. This bug was introduced from version 1.33.0 onwards.
Why it feature-request if it's a bug?
Change:
this.disposables.add(this.configurationManager); this.debugStorage = this.instantiationService.createInstance(DebugStorage); <del> contextKeyService.bufferChangeEvents(() => { this.debugType = CONTEXT_DEBUG_TYPE.bindTo(contextKeyService); this.debugState = CONTEXT_DEBUG_STATE.bindTo(contextKeyService); this.inDebugMode = CONTEXT_IN_DEBUG_MODE.bindTo(contextKeyService); this.debugUx = CONTEXT_DEBUG_UX.bindTo(contextKeyService); this.debugUx.set(this.debugStorage.loadDebugUxState()); this.breakpointsExist = CONTEXT_BREAKPOINTS_EXIST.bindTo(contextKeyService); // Need to set disassemblyViewFocus here to make it in the same context as the debug event handlers this.disassemblyViewFocus = CONTEXT_DISASSEMBLY_VIEW_FOCUS.bindTo(contextKeyService); }); </del> this.chosenEnvironments = this.debugStorage.loadChosenEnvironments(); this.model = this.instantiationService.createInstance(DebugModel, this.debugStorage); this.telemetry = this.instantiationService.createInstance(DebugTelemetry, this.model); <del> const setBreakpointsExistContext = () => this.breakpointsExist.set(!!(this.model.getBreakpoints().length || this.model.getDataBreakpoints().length || this.model.getFunctionBreakpoints().length)); setBreakpointsExistContext(); </del> this.viewModel = new ViewModel(contextKeyService); this.taskRunner = this.instantiationService.createInstance(DebugTaskRunner);

Discussion:
The debug viewlet breaks and does not load when the window is loaded with that viewlet visible Reload window with debug viewlet visible DebugActionViewItem is created, requires DebugService DebugService is instantiated, sets some context keys The context keys cause the debug view to refresh, the toolbar in the view header wants to refresh its actions, this leads to creating DebugActionViewItem again DebugService is not done being instantiated, so we try to instantiate a second one Repeat The context keys maybe should not be owned by the service, but could be a separate contribution
I think this was technically caused by , causing the DebugService to be created a little later than it was before. FYI My PR makes it happen a little more often, since otherwise the editor contribs might cause DebugService to be instantiated early, but I can repro this without my PR. I think the context keys can live in a separate workbench contrib that depends on DebugService, and listens to its events to update the keys.
The stack
That or don't set them from within the ctor but after your object/services is initialized (and cached)
Change:
import { clamp } from 'vs/base/common/numbers'; import { ScrollEvent } from 'vs/base/common/scrollable'; import { SetMap } from 'vs/base/common/collections'; <del> import { Codicon, registerIcon } from 'vs/base/common/codicons'; const treeItemExpandedIcon = registerIcon('tree-item-expanded', Codicon.chevronDown); // collapsed is done with rotation const treeFilterOnTypeOnIcon = registerIcon('tree-filter-on-type-on', Codicon.listFilter); const treeFilterOnTypeOffIcon = registerIcon('tree-filter-on-type-off', Codicon.listSelection); const treeFilterClearIcon = registerIcon('tree-filter-clear', Codicon.close); </del> <ins> import { treeItemExpandedIcon, treeFilterOnTypeOnIcon, treeFilterOnTypeOffIcon, treeFilterClearIcon } from 'vs/base/browser/ui/tree/treeIcons'; </ins> class TreeElementsDragAndDropData<T, TFilterData, TContext> extends ElementsDragAndDropData<T, TContext> {

Discussion:
Issue Type: <bBug</bIn latest Insiders build instead of loading icon I see spinning chevron for some tree nodes. It's mostly noticeable in GitHub Pull Request extension tree, however I was able to reproduce it in Call Hierarchy while expanding some nested trees. Looks like has lower priority than which prevents icon change. /cc VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T08:44:55.510Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Change:
const cueArray = cues.map(c => 'cue' in c ? c.cue : c); const alerts = cueArray.filter(cue => this.isAlertEnabled(cue)).map(c => c.alertMessage); if (alerts.length) { <del> this.accessibilityService.alert(alerts.join(', ')); </del> <ins> this.accessibilityService.status(alerts.join(', ')); </ins> } // Some audio cues might reuse sounds. Don't play the same sound twice.

Discussion:
Testing While testing I noticed that when I moved my cursor on a line with an error, the word was read, but the contents of that line were no longer read. I was wondering if this is intended? I noticed that sometimes the beginning of the text on the line is read, before it breaks off and reads the alerts.
I noticed that sometimes when I put my cursor on a line with a breakpoint, it does not read the word . Is the alert only supposed to sound at specific moments? Ie, for example the first time the cursor is placed on an active line with a breakpoint?
alerts interrupt whatever else might be read by design. And yes, it looks like in your case, you're using mouse clicks vs arrow keys to navigate between the lines. We listen to arrow keys, thus it's expected that you wouldn't hear the cues.
Additionally, I have checked with our power SR users and the alerts are working as expected in the editor.
I am going to open an issue to get more feedback on this.
Hi thank you for the clarification, that makes sense.
We are going to use instead here because editor content is the priority.