jiebi/CodeConvo huggingface dataset:
Change:
}); } <del> MenuRegistry.appendMenuItem(MenuId.TitleMenu, { command: { id: NavigateBackwardsAction.ID, title: NavigateBackwardsAction.LABEL, icon: Codicon.arrowLeft } }); MenuRegistry.appendMenuItem(MenuId.TitleMenu, { command: { id: NavigateForwardAction.ID, title: NavigateForwardAction.LABEL, icon: Codicon.arrowRight } }); </del> <ins> MenuRegistry.appendMenuItem(MenuId.TitleMenu, { order: 1, command: { id: NavigateBackwardsAction.ID, title: NavigateBackwardsAction.LABEL, icon: Codicon.arrowLeft } }); MenuRegistry.appendMenuItem(MenuId.TitleMenu, { order: 2, command: { id: NavigateForwardAction.ID, title: NavigateForwardAction.LABEL, icon: Codicon.arrowRight } }); </ins> // Empty Editor Group Toolbar MenuRegistry.appendMenuItem(MenuId.EmptyEditorGroup, { command: { id: UNLOCK_GROUP_COMMAND_ID, title: localize('unlockGroupAction', "Unlock Group"), icon: Codicon.lock }, group: 'navigation', order: 10, when: ActiveEditorGroupLockedContext });

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Love the new title control: ! My only problem is that I would often drag the window around by clicking and dragging the title bar. Since this takes up a large chunk of the title bar, I have less real estate to drag... but there's no reason the drag experience can't also apply to the area covered by the title control. Can the drag of the title control bubble up to the title bar so that dragging the window works?
There is a technical reason... Marking things as drag-region () swallows all events and you won't be able to click onto things anymore... I can try adding the style while dragging but it might not be possible <img width="113" alt="Screenshot 2022-05-24 at 09 15 34" src="https://user-" that's more concerning here...
Yeah, I have tried to set the style during mouse down (with a delay) but that doesn't seem to have an effect Plan was to mark the element as app region drag when holding for 200ms
related issue (which caused this)
and more context - seems like a hard problem
Can the top 1-2 pixels not be part of the drag element/target?
yeah, it already should be like that, there is another PR in the works that increases the title bar height. with that merged, dragging be simpler again
The title bar height is now aligned with the height of editor tabs. This allows to drag the window when clicking on the space above/below the CC. https://user- That's the best I can do (and aligns with Slack etc). Set/unsetting the property while dragging isn't supported...
To verify: enable CC via make sure you can drag the app window with the regions above/below the CC (see )
Change:
enum: enumToUse, enumDescriptions: enumDescriptions, enumDescriptionsAreMarkdown: enumDescriptionsAreMarkdown, <ins> enumItemLabels: prop.enumItemLabels, </ins> uniqueItems: prop.uniqueItems, tags: prop.tags, disallowSyncIgnore: prop.disallowSyncIgnore,

Discussion:
I don't have precise repro steps, but maybe: search for something scroll all the way down clear search searching animation persists
I'm unable to repro the issue. Let me know if there's any devtools errors next time it occurs.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
just reproduced this and will give us the logs
In the case of JooYoung, the search wasn't performed at all.
just reproduced myself
The error likely means there's an array that's undefined, but I'll probably have to reproduce the issue on OSS to actually see what's going on Example REPL run
it takes much longer than expected to stop - is there a long happening for input change or... ?
I'm unable to repro on the latest Insiders on Windows or macOS. For me, clearing the search stops it immediately.
Change:
@IEditorService private readonly editorService: IEditorService, @IUriIdentityService private readonly uriIdentityService: IUriIdentityService ) { <del> this.hiddenExpressionPerRoot = new Map<string, CachedParsedExpression>(); </del> this.toDispose.push(this.contextService.onDidChangeWorkspaceFolders(() => this.updateConfiguration())); this.toDispose.push(this.configurationService.onDidChangeConfiguration((e) => { if (e.affectsConfiguration('files.exclude')) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --Related Issues: <!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Linux x64 5.8.0-44-generic Steps to Reproduce: a root folder (files-exclude-sample) that folder create two nested folders (child1, child2) root folder (files-exclude-sample), create a workspace definition file (files-exclude-) root folder (files-exclude-sample), create a .vscode folder .vscode folder create a file to previous steps, just clone this GitHub repo: VSCode, open the workspace (files-exclude-) looks ok. You have tree root folders (files-exclude-sample, child1 and child2) ! you expand all three folder you can see something like ! specified in root folder , child1 and child2 are excluded from child1 folder child1 folder is collapsed (not removed from explorer tree) and it appears inside root folder (files-exclude-sample) folder ! expected behavior is that child1 is not collapsed and it does not appear inside root folder <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
the owner of the file explorer is
I acknowledge this issue. MR workspace support with when one root folder is a subfolder of another root folder has some issues. If somebody is passionate about fixing this let me know and I can provide pointers
Created fixing this
Thanks to a great pr by this is now fixed
Change:
const currentIndex = this.visibleComposites.indexOf(compositeId); if (newIndex !== currentIndex) { if (currentIndex !== -1) { <del> const actionViewItem = compositeSwitcherBar.viewItems[currentIndex]; </del> compositeSwitcherBar.pull(currentIndex); <del> actionViewItem.dispose(); </del> this.visibleComposites.splice(currentIndex, 1); }

Discussion:
Explorer focused: ! It's only working for debug: !
It seems to working for me <img width="370" alt="image" src=""Do you have any special theme, or customisations or set up? Probably try trouble shooting?
Also the state can be frozen: ! ! Same thing in dark modern. No errors in console
Here's a repro that seems reliable: the side bar narrow enough to make some of your activity icons get displaced into the ... menu. an option from that menu. Its icon appears and get selected with the underline correct. drag that icon left to position it nearer the start of the set of tabs in order for it not to get displaced onto the ... menu again. It loses its underline and even when you switch to another icon and back to this one it doesn't get underlined.
To reset, move activity bar to side, then back to top again.
Thanks for repro steps
OFF TOPIC. May I ask how to move the activity bar from left to top? Tried searching for settings and Googling, but didn't get any results.
if you're on the Insiders build you can right click the activity bar to change the position
To verify: Move activity bar to top Reduce the width of sidebar so that activity bar actions are exactly fit Switch to Debug view container. All activity bar actions moved to overflow action From overflow action, select explorer Make sure explorer is shown active
Change:
) { super(); <del> this._register(this.editor.onContextMenu((e: IEditorMouseEvent) => this.show(e))); </del> <ins> this._register(this.editor.onMouseDown((e: IEditorMouseEvent) => this.show(e))); </ins> } public show(e: IEditorMouseEvent) { <ins> // on macOS ctrl+click is interpreted as right click if (!e.event.rightButton && !(isMacintosh && e.event.leftButton && e.event.ctrlKey)) { return; } </ins> const menu = this.menuService.createMenu(MenuId.EditorLineNumberContext, this.contextKeyService); const model = this.editor.getModel();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: Mac OS Ventura 13.2.1 +click on the "play" icon next to a test (e.g. in ). Screenshot: <img width="583" alt="image" src="https://user-"Will bring up the context menu, like ctrl+clicking on a file tab header will. Executes the primary left-click action, which is to run the test with defaults.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
It reproduces exactly the same in 1.76.0. I have edited the bug description.
sending this your way since you're redoing the context menus here
Seems like ctrl+click in the gutter shows the context menu everywhere except for test decorations so I think this was just never implemented, therefore marking as feature request.
Wow, thanks for the super quick turnaround!
Change:
} .monaco-editor .find-widget .button { <del> width: 20px; height: 20px; </del> <ins> width: 16px; height: 16px; padding: 3px; border-radius: 5px; </ins> display: flex; flex: initial; margin-left: 3px;

Discussion:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"
Change:
try { this._verificationStatus = verificationStatus; this.validateManifest(location.fsPath); <del> const local = await this.extractExtension({ zipPath: location.fsPath, key: ExtensionKey.create(this.gallery), metadata }, token); </del> <ins> const local = await this.extractExtension({ zipPath: location.fsPath, key: ExtensionKey.create(this.gallery), metadata }, false, token); </ins> return [local, metadata]; } catch (error) { try {

Discussion:
Type: <bBug</bI already filed this bug in the Pylance repository (microsoft/pylance-release), but it got closed because the Pylance devs think it's a problem with VSCode rather than with Pylance. Both files contain only Pylance + all its dependencies. the files , and . the VSCode profile from . This should work as expected. the Python file in VSCode and wait till Pylance is loaded (you might need to "trust" the window). the VSCode profile from . Here the error appears! The second VSCode profile should load and activate itself. The Pylance extension should be installed correctly and no error should appear. When the second VSCode profile is imported the following error notification appears: Unable to delete the existing folder 'c:Users<username.vscodeextensionsms-' while installing the extension 'ms-'. Please delete the folder manually and try again The profile is imported, but without Pylance. Additionally, Pylance is removed from the first profile as well! VS Code version: Code 1.77.3 (, 2023-04-12T09:16:02.548Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I tried it and I cannot repro. May I know if you can reproduce this consistently?
I can still reproduce consistently on every try. I a minimal Python file to the repro.
I can repro while there are some exts depend on c#
I tried again with the same steps and provided profiles and I cannot repro. If you are able to repro consistently, can you please share following logs F1 Open View... Shared F1 Open View... Window
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Sorry, I was on vacation. Here are the logs: <details<summaryShared</summary</details<details<summaryWindow</summary</details
Same issue here. Basically makes Python unusable in more than one Profile.
reopen
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
const baseLocalLinkClause = _platform === platform.Platform.Windows ? winLocalLinkClause : unixLocalLinkClause; // Append line and column number regex this._localLinkPattern = new RegExp(`${baseLocalLinkClause}(${lineAndColumnClause})`); <ins> // Matches '--- a/src/file1', capturing 'src/file1' in group 1 this._gitDiffPreImagePattern = /^--- a/(S*)/; // Matches '+++ b/src/file1', capturing 'src/file1' in group 1 this._gitDiffPostImagePattern = /^+++ b/(S*)/; this._tooltipCallback = (e: MouseEvent) => { if (this._terminalService && this._terminalService.configHelper.config.rendererType === 'dom') { const target = (e.target as HTMLElement); this._widgetManager.showMessage(target.offsetLeft, target.offsetTop, this._getLinkHoverString()); } else { this._widgetManager.showMessage(e.offsetX, e.offsetY, this._getLinkHoverString()); } }; </ins> this.registerWebLinkHandler(); this.registerLocalLinkHandler(); <ins> this.registerGitDiffLinkHandlers(); </ins> } public setWidgetManager(widgetManager: TerminalWidgetManager): void {

Discussion:
Example:
Do you mind if I take on this issue? I assume the request is to make and Ctrl-clickable such that the links open the correct versions of the files.
sounds good. The link registration is done here and it's based on regexs: We basically want the and parts to be matched, but ignored as part of the link.
I'm having a bit of trouble with getting the two git blob IDs and , which are necessary to get the correct versions of the files. I tried to write a multi-line regex for that captures the blob IDs in groups, along with the paths we want to link, but currently only runs the regex on a per line basis (by iterating through the buffer), not on the whole content of the terminal. So the regex didn't find any matches. I also tried to get the blob IDs by parsing the contents of the terminal manually, but doesn't seem to offer a public interface to retrieve the contents. I do see but I don't want to rely on an internal implementation to do something like this. How do you suggest I proceed? Should I submit a PR to to allow multi-line regex in ?
I'm having a bit of trouble with getting the two git blob IDs and , which are necessary to get the correct versions of the files. Oh I wouldn't go that far, just pointing both links to the current version of the file would be good enough start with.
Ah I see, that's a lot simpler to do. Will open a PR soon.
Change:
import { IProductService } from 'vs/platform/product/common/productService'; import { SeverityIcon } from 'vs/platform/severityIcon/browser/severityIcon'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <del> import { SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme'; </del> import { IViewDescriptorService, ViewContainerLocation } from 'vs/workbench/common/views'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences';

Discussion:
Sometimes the tree sticky show shadow does not show. Make sure they use the proper overrides and that there is a default color if none is provided
are there any validation steps here?
verified- the scm sticky scroll showed on insiders, but not stable.
Change:
} // Run Extension Host as fork of current process <del> this._extensionHostProcess = fork(FileAccess.asFileUri('bootstrap-fork', require).fsPath, ['--type=extensionHost'], opts); </del> <ins> this._extensionHostProcess = fork(FileAccess.asFileUri('bootstrap-fork', require).fsPath, ['--type=extensionHost', '--skipWorkspaceStorageLock'], opts); </ins> // Catch all output coming from the extension host process type Output = { data: string, format: string[] };

Discussion:
In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.
To verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says
The remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .
Change:
import { TelemetryLevel } from 'vs/platform/telemetry/common/telemetry'; import { IProductService } from 'vs/platform/product/common/productService'; import { ILogService } from 'vs/platform/log/common/log'; <ins> import { INotificationService } from 'vs/platform/notification/common/notification'; import { localize } from 'vs/nls'; </ins> export const restoreWalkthroughsConfigurationKey = 'workbench.welcomePage.restorableWalkthroughs'; export type RestoreWalkthroughsConfigurationValue = { folder: string; category?: string; step?: string };

Discussion:
/ This is likely caused by testing/startup page code triggering this command on machines that have disabled the built-in markdown extension
Change:
linkAllowedByRules('https://github.com/microsoft/vscode/issues/new', ['https://github.com/microsoft']); linkAllowedByRules('https://github.com/microsoft/vscode/issues/new', ['https://github.com/microsoft']); }); <ins> test('ignore query & fragment - https://github.com/microsoft/vscode/issues/156839', () => { linkAllowedByRules('https://github.com/login/oauth/authorize?foo=4', ['https://github.com/login/oauth/authorize']); linkAllowedByRules('https://github.com/login/oauth/authorize#foo', ['https://github.com/login/oauth/authorize']); }); </ins> });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: out of GitHub if you are logged in a trusted domain rule for GitHub Repos extension or something else, start a Login for GitHub Notice that you get prompted to allow this URL as a trusted domain No prompt This is because () doesn't handle query parameters well... and thinks they are part of the path when validating. You can see this behavior by adding a at the end of in the Trusted Domains. We should really ignore query parameters and fragments here.
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "5.1.0-beta.13", </del> <ins> "xterm": "5.1.0-beta.15", </ins> "xterm-addon-canvas": "0.3.0-beta.1", "xterm-addon-search": "0.11.0-beta.1", "xterm-addon-unicode11": "0.5.0-beta.1",

Discussion:
Testing with EDIT or https://user-
!
!
weird behavior on too !
also happens with
also lines aren't resizing !
did some change happen around trusted types? The dynamically loaded script needs to set inline attributes/innerHTML
No, nothing that I am aware of. Tho, the assignment () should have never worked with trusted types enabled because it's a bare string, not If you have to use assignment (which should be the exception) you need to use a trusted types policy and create trusted html through that. This is a sample: However, you should try to avoid that and keep things more simple, e.g use and/or
Ah you're right, this was a coding error introduced with underlines:
Change:
// label: just workspace name and optional decorations const { prefix, suffix } = windowTitle.getTitleDecorations(); let label = windowTitle.workspaceName; <ins> if (!label) { label = localize('label.dfl', "Search"); } </ins> if (prefix) { label = localize('label1', "{0} {1}", prefix, label); }

Discussion:
Testing I am not sure if that is intentional, but in an empty window you only see the search icon: !
At the minimum we should show a placeholder like "Search": <img width="1024" alt="CleanShot 2022-05-31 at 12 51 37 src="https://user-"