jiebi/CodeConvo huggingface dataset:
Change:
.monaco-workbench .pane-composite-part > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus .active-item-indicator:before, .monaco-workbench .pane-composite-part > .header-or-footer > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus .active-item-indicator:before { border-top-color: var(--vscode-focusBorder) !important; <ins> border-top-width: 2px; </ins> } .monaco-workbench .pane-composite-part > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked .action-label,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.1 OS Version: macOS Sonoma(14.0) Steps to Reproduce: the color theme to high contrast theme will see the activity bar icon size and the border is weird !
pinging
Change:
quickPick.items = []; quickPick.busy = true; quickPick.placeholder = nls.localize('remote.startActions.installingExtension', 'Installing extension... '); <del> await this.installAndRunStartCommand(remoteExtension); </del> <ins> await this.installExtension(remoteExtension.id); quickPick.hide(); await this.runRemoteStartCommand(remoteExtension.id, remoteExtension.startCommand); </ins> } else { this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', {

Discussion:
Testing After clicking the "Install" entry in the quick pick, there's progress for a few moments, then the quick pick flashes back to showing all the previous entries again, before finally landing on the setup options for the remote extension. !
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { getZoomFactor } from 'vs/base/browser/browser'; </del> <ins> import { getZoomFactor, isWCOVisible } from 'vs/base/browser/browser'; </ins> import { $, addDisposableListener, append, EventType, hide, show } from 'vs/base/browser/dom'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IConfigurationService, IConfigurationChangeEvent } from 'vs/platform/configuration/common/configuration';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0-insider (user setup) Commit: Date: 2022-11-03T05:36:55.498Z Electron: 19.1.3 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !
It affects as well other distributions:
fixes it for me.
Change:
return this._marketplaceThemes; } <del> public get isSearching(): boolean { return this._searchOngoing; } </del> public get onDidChange() { return this._onDidChange.event; }

Discussion:
Testing When browsing themes while offline, I didn't get any message that I could not connect to the marketplace and/or could not retrieve themes, with the only visible feedback being that the theme search would instantly return with an empty quickpick. It would be nice if this information could be surfaced somehow.
Verified: !
Change:
weight: weight + 100000, primary: KeyCode.DownArrow, secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow], <ins> mac: { primary: KeyCode.DownArrow, secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow, KeyMod.WinCtrl | KeyCode.KeyN] } </ins> } }));

Discussion:
Type: <bBug</bWith the previous native menu on macOS, Ctrl+N and Ctrl+P could be used to select code actions. This doesn't seem to work with the new custom one. I tried setting / , but that breaks Ctrl+N/P in the Command Palette. VS Code version: Code 1.71.0 (Universal) (, 2022-09-01T07:25:38.437Z) OS version: Darwin arm64 21.6.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Did you add a when-clause to your keybindings?
Is correct for how you can add your own keybindings I'll add them by default too since they also exist for the suggest widget
Change:
* Applies realpath to file-uris and returns all others uris unmodified */ private async _realPathExtensionUri(uri: URI): Promise<URI> { <del> if (uri.scheme !== Schemas.file) { return uri; </del> <ins> if (uri.scheme === Schemas.file && this._hostUtils.fsRealpath) { const realpathValue = await this._hostUtils.fsRealpath(uri.fsPath); return URI.file(realpathValue); </ins> } <del> const realpathValue = await this._hostUtils.realpath(uri.fsPath); return URI.file(realpathValue); </del> <ins> return uri; </ins> } // create trie to enable fast 'filename -> extension id' look up

Discussion:
Steps to repro: (prereq) make sure Python is installed in or (also repros with stable , does not repo in Desktop) open or wait a bit see that Python gets activated even though this repo has nothing python-y in it (just XML files) ! informed me of which gave me a very curious output: What’s interesting about this is that this repo has no , no , no … so this takes me to the original question. Why is this causing activation? After chatting a bit, pointed out: as suspicious.
I think these host methods are not implemented correctly and they might be the root cause:
Yeah, the function isn't really implemented. Tho, I could change the default to to but the bigger challenge is that the interface assumes local file access - it talks about paths, not uris and therefore this will be hard to implement. And by extension I also think this is buggy for the node EH with workspace not hosted on local disk
NVM - I found the magic and will use that for web EH
Change:
*  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import 'vs/css!./output'; </ins> import * as nls from 'vs/nls'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { IEditorOptions as ICodeEditorOptions } from 'vs/editor/common/config/editorOptions';

Discussion:
Repro: Use a theme that has the editor as a different color to the panel Print a json object to an output channel !
Hi thank you for posting this issue. It is a bit unclear from the screen-shot what the expected output should be. Are you referring to what looks like the terminal sticky scroll?
that's output (monaco) sticky scroll, not terminal. The bottom has a dark sticky scroll color and looks odd when the panel background is different to the editor.
I see better now thanks. I'll look into setting a different background color depending on if the editor is a simple one or inside of the output view.
I am investigating how to detect if a specific editor is the editor in the output view. I was initially considering looking at the classList to find if or is there, but the editor dom node class list appears to be undefined for the output view. I was wondering if there is perhaps another way to detect this?
I am not aware of a method to get the editor of the output view, but it should be easy to add: Is that what you need?
Ah maybe I can directly access the editor of the output view pane and verify that the current editor is equal to this editor maybe?
But you are inside an editor contribution or? Not sure how that would work given layering violations.
Yes that's right the change would be inside of the file which is a contribution. I'll think more about how to detect the type of the current editor
Not sure if it helps, but we can control the options we pass in to the editor for output and do so here:
It's a bit of a tricky problem if you want this to work well across all themes. You probably need to support null or transparent values for the bg and hover bg keys and then resolve the colors manually into opaque colors by combining them with the bg color underneath. This might be the right internal API to do that?
I was investigating the uri of the output editor, and noticed it has a scheme equal to 'output'. I can just use it in order to detect if the current editor is an output view editor and change the background accordingly.
Change:
@IKeybindingService private readonly keybindingService: IKeybindingService, @ILabelService private readonly labelService: ILabelService, @ILogService private readonly logService: ILogService <del> ) { } </del> <ins> ) { } </ins> convertParsedRequestToMarkdown(parsedRequest: IParsedChatRequest): string { let result = '';

Discussion:
We still have the check in place to disable these in the stable build...
Can be verified by code review, or once we have a stable build.
Verifying on 0.11.1 Edit: I see the suggestion is enabled, but the behaviour is off to me. Discussing offline. Edit 2: Discussed. Marking as verified.
Change:
} } <ins> private areRangesIntersectingOrTouchingByLine(a: Range, b: Range) { // Check if `a` is before `b` if (a.endLineNumber < b.startLineNumber) { return false; } // Check if `b` is before `a` if (b.endLineNumber < a.startLineNumber) { return false; } // These ranges must intersect return true; } </ins> public getMatchedCommentAction(commentRange: Range | undefined): CommentRangeAction[] { if (commentRange === undefined) { const foundInfos = this._infos?.filter(info => info.commentingRanges.fileComments);

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW
Change:
import { ThrottledDelayer } from '../../../../../base/common/async.js'; import { ILanguageDetectionService } from '../../../../services/languageDetection/common/languageDetectionWorkerService.js'; import { toFormattedString } from '../../../../../base/common/jsonFormatter.js'; <ins> import { IModelContentChangedEvent } from '../../../../../editor/common/textModelEvents.js'; </ins> export class NotebookCellTextModel extends Disposable implements ICell { private readonly _onDidChangeOutputs = this._register(new Emitter<NotebookCellOutputsSplice>());

Discussion:
Testing 1) I started with 2) I ran the first two cells and then committed 3) I reran cell 1 4) I changed cell 3 to use different file names 5) I opened the notebook diff from the SCM view -(a) cell metadata changes were shown -(b) changes to cell 3 where hidden -(c) toggling the "Toggle Collapse Unchanged Regions" didn't do anything !
I was unable to reproduce (b) reliably.
Verifier: Make the workbench small enough so when opening only the first cells show up Run the first two cells Commit/stage the file Scroll to the last cell, make changes, save (if you don't have auto save) Open the diff view, the change in the last cell should be rendered.
cannot test this due to
Change:
// thisIsACamelCaseWithOneLetterWords if (column + 1 < maxColumn) { const rightRight = lineContent.charCodeAt(column); <del> if (strings.isLowerAsciiLetter(rightRight)) { </del> <ins> if (strings.isLowerAsciiLetter(rightRight) || strings.isAsciiDigit(rightRight)) { </ins> return new Position(lineNumber, column); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 OS Version: Windows/Linux Steps to Reproduce: there is a keybinding to . a camel case word with a number immediately preceding an upper case character and leave the cursor at the end of the word, e.g. "foo1Bar|". via keybinding in (1). the cursor to end up before the upper case character (i.e. ), but cursor is observed to be at the beginning of the camel case word (i.e. ).
Will like to request for a review on the issue/MR please. /cc
Still an issue in version 1.67.1. Linked MR is ready for review.
Similar issues: ("Feature 1")
Change:
diff = objects.distinct(base, obj); assert.deepEqual(diff, obj); }); <del> }); </del>  No newline at end of file <ins> test('getCaseInsensitive', () => { const obj1 = { lowercase: 123, mIxEdCaSe: 456 }; assert.equal(obj1.lowercase, objects.getCaseInsensitive(obj1, 'lowercase')); assert.equal(obj1.lowercase, objects.getCaseInsensitive(obj1, 'lOwErCaSe')); assert.equal(obj1.mIxEdCaSe, objects.getCaseInsensitive(obj1, 'MIXEDCASE')); assert.equal(obj1.mIxEdCaSe, objects.getCaseInsensitive(obj1, 'mixedcase')); }); }); </ins>

Discussion:
Connect a mac-windows SSH remote Open terminal See this popup ! So fails here because it checks ".PATH" on the environment when this is actually "Path" on windows. has special behavior where it resolves property accesses in a case-insensitive way on Windows. We changed many accesses from using to a constructed environment object, and need the same behavior there.
is this a mac-specific issue or are there steps to repro/verify on Windows?
Can't be verified on windows. Thanks
Change:
this._bufferEditor.focus(); } <del> private async _getTextModel(resource: URI): Promise<ITextModel | null> { const existing = this._modelService.getModel(resource); if (existing && !existing.isDisposed()) { return existing; } return this._modelService.createModel(resource.fragment, null, resource, false); } private _getContent(lastBufferIndex?: boolean): string { const buffer = this._xterm?.raw.buffer.active; </del> <ins> private _getContent(startIndex?: number): string { const buffer = this._xterm.raw.buffer.active; </ins> if (!buffer) { return ''; }

Discussion:
Using here, I cannot enter the accessible buffer https://user-
The issue is that here, the default tab behavior is to focus the terminal tabs element edit: hard to repro, that's not the cause
ok this happens when is not applied to . See here that the buffer editor does get focused here, but you cannot see it https://user-
Repro: run some commands - - - Try to wasn't applied to so the accessible buffer isn't visible
https://user-

Currently when you use navigate accessible buffer you get a quick pick with the options, I expected changing these to scroll to the position without accepting it, and escape to revert to the original scroll position.
As part of this, providing ~1/3 of the viewport of context above would also be good
We'd need to think about how we to communicate the preview information to a screen reader user, as a pre"view" is usually visual
I don't think making this available to the screen reader makes sense, it would just complicate navigating the list. It is useful for sighted users though.
Oh I understand now - you mean on change of the active quick pick item, reveal the line and on enter, focus that line (as it already does)
Yep
To verify, in a terminal with shell integration, run some commands. to enter the accessible buffer. to . Without pressing , use the arrow keys to go between the options. It should scroll to the command if it is outside of the viewport.
Works but I opened
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.58", </del> <ins> "xterm": "4.19.0-beta.60", </ins> "xterm-addon-search": "0.9.0-beta.39", "xterm-addon-serialize": "0.7.0-beta.12", "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.12.0-beta.37", "xterm-headless": "4.19.0-beta.58", </del> <ins> "xterm-addon-webgl": "0.12.0-beta.38", "xterm-headless": "4.19.0-beta.60", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Upstream issue: Repro: Alt+click and drag in the terminal Moving right on the same line does not make a selection Moving to top-right or bottom-left doesn't make a selection (this works in canvas renderer only?) Cursor isn't correct ! Correct behavior in 1.67: !
When verifying make sure that copy works as expected for column selection in each quadrant as well.
Change:
import { ActionRunner, IAction, WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification } from 'vs/base/common/actions'; import { hash } from 'vs/base/common/hash'; import { firstOrDefault } from 'vs/base/common/arrays'; <ins> import { AccessibleNotificationEvent, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> // Center export const SHOW_NOTIFICATIONS_CENTER = 'notifications.showList';

Discussion:
Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
*/ export class WorkspaceTrustUXHandler extends Disposable implements IWorkbenchContribution { <del> private readonly entryId = `status.workspaceTrust.${this.workspaceContextService.getWorkspace().id}`; </del> <ins> private readonly entryId = `status.workspaceTrust`; </ins> private readonly statusbarEntryAccessor: MutableDisposable<IStatusbarEntryAccessor>;

Discussion:
While investigating the issue - - I figured out that entry is of size 46 KB and has around 1K properties. We should revisit this and understand why there are that many workspaceTrust entries and minimise it.
Workspace trust status bar entry does 2 things that are questionable: each entry gets a random identifier [0] the entry is programmatically hidden even if not created [1] If as a user I decide to hide the entry, I would hide it everywhere. [0] [1]
could you please chime in on this as I remember you working on this. Thanks!
This was the relevant message for what we were trying to achieve with the current design
Would it at least be possible to only create the entry when visible and if not, do not create and thus hiding is not needed? The underlying issue here is large amount of state accumulating for hidden trust entries. Typically only a user gesture would set the visibility to hidden, not programmatic as its done here.
I realize that justification talks about unspecified trust state, that is no longer a concept. We also have the banner now. Ok so we can: Only create an entry (unique id), if the entry will be visible (i.e. untrusted). User can hide with status bar UX. Con: User cannot make the entry visible in a trusted workspace if it was never loaded untrusted. We could go to a single entry id, so that visibility is linked across workspaces. Con: trusted workspaces would show if the user wanted to see when untrusted workspace. Single entry id, but dispose the entry when the workspace is trusted. Con: Can't manage the entry when in a trusted window (who cares, right?) I opened a PR for the last one
Yes, thats a great change, even though it causes a slight regression for people in untrusted workspaces that have explicitly hidden the indicator. It will now come back, but then its also easy to hide it again. Given the status bar entry ID is now no longer dynamic, we could actually now clean up the very large state in by removing all entries that are dynamic. I will see to make such a change. Thanks!
Change:
} return { <del> isPure: isPure, </del> <ins> isPure, </ins> proof: allResults }; }

Discussion:
Originally posted by in
This is a great idea: !
Previously, extensions that patched VSCode like would occasionally result in a notification only after VSCode was updated. After this change, this banner appears every time VSCode is opened, even if it was previously dismissed for the same version. This feels very obtrusive. Was that an intended part of this change? !
Banner will be removed again in , I think it will cause more harm than being useful.