jiebi/CodeConvo huggingface dataset:
Change:
this.ui.count.setCount(this.ui.list.getCheckedCount()); switch (this._itemActivation) { case ItemActivation.NONE: <ins> // Handle the case where we had active items (i.e. someone chose an item) // but the initial item activation is set to none. Calling clearFocus will // not trigger the onDidFocus event because when the tree receives new elements, // it sets the focus to no elements. So we need to set & fire the active items // accordingly to reflect the state change after setting the items. if (currentActiveItems.length > 0) { this._activeItems = new Array<T>(); this.onDidChangeActiveEmitter.fire(this._activeItems); } </ins> this._itemActivation = ItemActivation.FIRST; // only valid once, then unset break; case ItemActivation.SECOND:

Discussion:
Steps to Reproduce: the web UI "Open Folder" in a path that exists on disk and enter <img width="791" alt="image" src=""
This is weird. The in the quick pick don't appear to be getting updated.
Also, not just in web.
Git bisect points to
I don't see anything super obvious in , but here's the behavior I can observe: simple file picker sets the does not get reset. The old behavior is that it would get reset.
Clearing here fixes things, but I don't think that's the right fix:
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { getActiveWindow } from '../../../../../base/browser/dom.js'; </del> <ins> import { getActiveWindow, isHTMLElement } from '../../../../../base/browser/dom.js'; </ins> import { FastDomNode } from '../../../../../base/browser/fastDomNode.js'; import { AccessibilitySupport } from '../../../../../platform/accessibility/common/accessibility.js'; import { IKeybindingService } from '../../../../../platform/keybinding/common/keybinding.js';

Discussion:
Enable the setting Open the editor Open the find widget Type several letters The editor is focused as soon as there is a match for the find result It is no longer possible to continue typing in the find widget without retriggering the focusing of the find widget
Change:
import { ITextModel } from 'vs/editor/common/model'; import { registerEditorAction, registerEditorContribution, ServicesAccessor, EditorAction, registerInstantiatedEditorAction } from 'vs/editor/browser/editorExtensions'; import { ICodeEditor, IEditorMouseEvent, MouseTargetType } from 'vs/editor/browser/editorBrowser'; <del> import { FoldingModel, setCollapseStateAtLevel, CollapseMemento, setCollapseStateLevelsDown, setCollapseStateLevelsUp, setCollapseStateForMatchingLines, setCollapseStateForType, setCollapseStateForRest, toggleCollapseState, setCollapseStateUp } from 'vs/editor/contrib/folding/foldingModel'; </del> <ins> import { FoldingModel, setCollapseStateAtLevel, CollapseMemento, setCollapseStateLevelsDown, setCollapseStateLevelsUp, setCollapseStateForMatchingLines, setCollapseStateForType, setCollapseStateForRest, toggleCollapseState, setCollapseStateUp, getJumpToParentFoldLine, getJumpToPreviousFoldLine, getJumpToNextFoldLine } from 'vs/editor/contrib/folding/foldingModel'; </ins> import { FoldingDecorationProvider, foldingCollapsedIcon, foldingExpandedIcon } from './foldingDecorations'; import { FoldingRegions, FoldingRegion } from './foldingRanges'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys';

Discussion:
It would be useful for navigating code to have a command to jump to previous/next foldable line. This would allow me to easily jump to the lines that I can either fold/unfold.
Awesome! Do I need to update my version to add this? I'm on macos Version: 1.58.2 currently and tried to my shortcuts, but didn't get it to work.
to get it you need to install Insiders.
Ahh I see the tag now, thanks.
Change:
if (this.workspace) { const previousData = this._configuration.toData(); const change = this._configuration.compareAndUpdateDefaultConfiguration(configurationModel, properties); <ins> if (this.applicationConfiguration) { this._configuration.updateApplicationConfiguration(this.applicationConfiguration.reparse()); } </ins> if (this.remoteUserConfiguration) { this._configuration.updateLocalUserConfiguration(this.localUserConfiguration.reparse()); this._configuration.updateRemoteUserConfiguration(this.remoteUserConfiguration.reparse());

Discussion:
I'm not sure if this only applies when debugging or not, but here is the setup when this happens: a setting, e.g. in the default profile a new <whateverprofile, and ensure that the above setting doesn't exist in it the code to an extension (that will call ) in a window on the default profile debugging the extension a launch config with :bug: see that globalValuetruefalse:bug: see that truefalse Things seem to work fine as long as the default profile doesn't have the value set, but once it does you get the behavior above. /cc
Based on what I could notice, it doesn’t seem to be a debug only issue. It isn’t a problem for most of my extensions (at least no user complained up until now) but I noticed such behavior while working with my Project Manager extension, because the value doesn’t respect the current profile. Then, looking a bit more, I noticed such conflict too, which blocks me from use different settings for each profile, unfortunately. BTW, I created to report the issue
Wondering if you tried insiders to see if this issue still exists?
yes, insiders is my daily driver. And this issue has been around since the beginning of profiles just finally dug more into it to get a better idea of what was happening to report it.
Sorry about this. It is specifically happening for settings contributed by extensions. I am not updating the model after they are registered. Fixed it. To Verify: Create a sample extension with following setting and extension codeInstall this extension in default profile and open update the setting to in user settings Create a new profile from the default profile Reload the window Make sure you see in the console.
thanks -- it fixed the issues I've been seeing.
marking as verified because of comment.
Change:
} export interface INotebookSourceActionChangeEvent { <del> notebook: URI; </del> <ins> notebook?: URI; viewType: string; </ins> } export interface IKernelSourceActionProvider {

Discussion:
When we only have a couple of notebook controllers created for a notebook type, without any kernel detection task or kernel source commands, the "Select Another Kernel" should not show.
I have no kernels in the MRU, clicking Select Kernel brings me to this quickpick, and clicking the back button here does nothing--I think it shouldn't be shown in this scenario ! I have the Jupyter extension installed but not the Python extension installed, with the MRU picker enabled, the Select Kernel dropdown spins forever like this: !
Change:
import { joinPath } from 'vs/base/common/resources'; import { URI } from 'vs/base/common/uri'; import { Range } from 'vs/workbench/services/search/node/ripgrepSearchUtils'; <del> import { fixRegexCRMatchingNonWordClass, fixRegexCRMatchingWhitespaceClass, fixRegexEndingPattern, fixRegexNewline, IRgMatch, IRgMessage, RipgrepParser, unicodeEscapesToPCRE2 } from 'vs/workbench/services/search/node/ripgrepTextSearchEngine'; </del> <ins> import { fixRegexCRMatchingNonWordClass, fixRegexCRMatchingWhitespaceClass, fixRegexEndingPattern, fixRegexNewline, IRgMatch, IRgMessage, RipgrepParser, unicodeEscapesToPCRE2, fixNewline } from 'vs/workbench/services/search/node/ripgrepTextSearchEngine'; </ins> import { TextSearchResult } from 'vscode'; suite('RipgrepTextSearchEngine', () => {

Discussion:
Open folder containing CRLF files (typically on windows) Copy multiple lines of text, paste into search viewlet Close that file Do multiline search The file is not found cc Candidate because the feature is essentially completely broken on windows.
Change:
propertySchema.patternErrorMessage = nls.localize('transparecyRequired', 'This color must be transparent or it will obscure content'); } this.colorSchema.properties[id] = { <ins> description, </ins> oneOf: [ propertySchema, { type: 'string', const: DEFAULT_COLOR_CONFIG_VALUE, description: nls.localize('useDefault', 'Use the default color.') }

Discussion:
Testing See detail should be showing here but it's not: <img width="637" alt="Screenshot 2024-08-27 at 9 51 25 AM" src=""
Change:
import { TestUriType, buildTestUri, parseTestUri } from 'vs/workbench/contrib/testing/common/testingUri'; const MAX_INLINE_MESSAGE_LENGTH = 128; <ins> const MAX_TESTS_IN_SUBMENU = 30; </ins> function isOriginalInDiffEditor(codeEditorService: ICodeEditorService, codeEditor: ICodeEditor): boolean { const diffEditors = codeEditorService.listDiffEditors();

Discussion:
the setup of microsoft/vscode-python click the Test gutter decoration Numbers appear in random order: <img width="485" alt="image" src=""Also, if you change to , you'll get a very slow opening menu. cc
Maybe we should have a "X more tests..." item that opens a quickpick after like 10. What do you think
yeah agreed that its not worth displaying more than 10 tests in a quick pick and I think the "X more tests..." will be a good way to tell users
Change:
} @command('git.openFile') <del> async openFile(arg?: Resource | Uri): Promise<void> { let uri: Uri | undefined; </del> <ins> async openFile(arg?: Resource | Uri, ...resourceStates: SourceControlResourceState[]): Promise<void> { let uris: Uri[] | undefined; </ins> if (arg instanceof Uri) { if (arg.scheme === 'git') { <del> uri = Uri.file(fromGitUri(arg).path); </del> <ins> uris = [Uri.file(fromGitUri(arg).path)]; </ins> } else if (arg.scheme === 'file') { <del> uri = arg; </del> <ins> uris = [arg]; </ins> } } else { let resource = arg;

Discussion:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.
Change:
title: { value: localize('workbench.action.terminal.runRecentCommand', "Run Recent Command..."), original: 'Run Recent Command...' }, f1: true, category, <del> precondition: ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated) </del> <ins> precondition: ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), keybinding: [ { primary: KeyMod.CtrlCmd | KeyCode.KeyR, mac: { primary: KeyMod.WinCtrl | KeyCode.KeyR }, when: ContextKeyExpr.and(TerminalContextKeys.focus, CONTEXT_ACCESSIBILITY_MODE_ENABLED), weight: KeybindingWeight.WorkbenchContrib }, { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KeyR, mac: { primary: KeyMod.WinCtrl | KeyMod.Alt | KeyCode.KeyR }, when: ContextKeyExpr.and(TerminalContextKeys.focus, CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate()), weight: KeybindingWeight.WorkbenchContrib } ] </ins> }); } async run(accessor: ServicesAccessor): Promise<void> {

Discussion:
Forking off from Basic idea is have something similar to alt+f1 in the editor, but in the terminal and explain it in the textarea's aria-label
This will be testable on Monday. On Windows/Linux: On macOS:
/closedWith
Change:
shortTitle: localize('mergeEditor.resetResultToBaseAndAutoMerge.short', 'Reset'), f1: true, precondition: ctxIsMergeEditor, <del> menu: { id: MenuId.MergeInputResultToolbar } </del> <ins> menu: { id: MenuId.MergeInputResultToolbar, group: 'primary' }, icon: Codicon.discard, </ins> }); }

Discussion:
! I personally find it a bit strange to have no primary action and only secondary actions hidden behind "...". What is the rationale? //cc
We are looking at pulling these out as primary actions like so. See . <img width="1015" alt="CleanShot 2022-10-03 at 09 11 23 src="https://user-"
!
!
Change:
} } <del> const command = prepareCommand(shell, args.args, !!args.argsCanBeInterpretedByShell, cwdForPrepareCommand); </del> <ins> const command = prepareCommand(shell, args.args, !!args.argsCanBeInterpretedByShell, cwdForPrepareCommand, args.env); </ins> terminal.sendText(command); // Mark terminal as unused when its session ends, see #112055

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
if (markerIndex < 0) { this._currentMarker = Boundary.Top; this._terminal.scrollToTop(); <ins> this.clearMarker(); </ins> return; }

Discussion:
Testing When I use cmd+up/down to navigate between POIs in task output, the blue box renders for a second on the item I have selected, but then disappears. I didn't understand what was happening to the focus border.
that is by design.
This has come up before, I think you had an idea to improve this?
I had the same experience in where I was on a slow machine. I think I had suggested just using a line on the side (like our activity bar) that remains until your focus changes: <img src="https://user-"
To the left of the command decorations? ! I like how visible the outline is when jumping between commands, so we could keep that as is and just also show the persistent line? !
yea I'd be open to trying that out, I think using both might be a bit overkill but just having the single line can also be hard to notice.
Change:
} hello_world();`.replace(/^s+/gm, '')); assertSelection(editor, new Selection(14, 1, 17, 15)); <ins> editor.setSelection(new Selection(18, 1, 18, 13)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(18), `'java_script'`); assertSelection(editor, new Selection(18, 1, 18, 14)); editor.setSelection(new Selection(19, 1, 19, 17)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(19), 'parse_html4_string'); assertSelection(editor, new Selection(19, 1, 19, 19)); editor.setSelection(new Selection(20, 1, 20, 28)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(20), '_accessor: services_accessor'); assertSelection(editor, new Selection(20, 1, 20, 29)); </ins> } );

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --
This is about
Yeah see pull request sorry. I just lumped it into something else.
Change:
} else if (response instanceof EditResponse) { // edit response -> complex... this._zone.value.widget.updateMarkdownMessage(undefined); <del> this._zone.value.widget.updateToolbar(true); </del> const canContinue = this._strategy.checkChanges(response); if (!canContinue) {

Discussion:
generate an answer tweak it press Send again (by accident) press Stop generating the Accept button is no longer visible !
Change:
"vscode-oniguruma": "1.7.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.3", </del> <ins> "xterm": "5.3.0-beta.7", </ins> "xterm-addon-canvas": "0.5.0-beta.2", <del> "xterm-addon-image": "0.4.1", </del> <ins> "xterm-addon-image": "0.4.2", </ins> "xterm-addon-search": "0.13.0-beta.2", "xterm-addon-serialize": "0.11.0-beta.2", "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.16.0-beta.2", <del> "xterm-headless": "5.3.0-beta.3", </del> <ins> "xterm-headless": "5.3.0-beta.7", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
On the latest insiders I can't click and drag the terminal scroll bar: !
Same here - but at least the terminal can actually be resized now!
I the same problem. In my case, all scrollbars (editor, explorer, ...) were. I tried and it was the same. Not sure if this is related, but Google Chrome and Slack App do not have this issue.
Same issue here, cannot scroll the terminal window. The cursor changes to text selector and is unable to scroll for the entire life of the terminal window. !
I completely shut down macOS and restarted it and it fixed it. It's strange.
Restarting vscode fixes it for me. It only happens when my cursor either hovers over a link in the terminal or I select some text from the terminal, it gets forever stuck in text selection/link click mode.
This is because of the image addon: ! cc
Upstream:
Saw that you released v1.80. In there is still 0.4.1 mentioned as version for xterm-addon-image. The patch version fixing this issue at hand is 0.4.2 - did that not work for you? Note that I was not able to repro the issue with vscode 1.79, so there is a chance that my attempt did not address it. Or did just the package update slip through?
I'm seeing this in Insiders. Restarting VSCode doesn't fix it and it only happens when I have multiple terminals open and the terminal tab sidebar is showing. Version: 1.81.0-insider (Universal) Commit: Date: 2023-07-07T19:50:58.701Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
it came in a bit late for the release and didn't think it met the bar. I'll be updating soon
Change:
c(request.result); } }; <del> transaction.onerror = () => e(transaction.error); transaction.onabort = () => e(transaction.error); </del> <ins> transaction.onerror = () => e(transaction.error ? ErrorNoTelemetry.fromError(transaction.error) : new ErrorNoTelemetry('unknown error')); transaction.onabort = () => e(transaction.error ? ErrorNoTelemetry.fromError(transaction.error) : new ErrorNoTelemetry('unknown error')); </ins> const request = dbRequestFn(transaction.objectStore(store)); }).finally(() => this.pendingTransactions.splice(this.pendingTransactions.indexOf(transaction), 1)); }

Discussion:
https://vscode- Deminified Stack Error: Failed to execute 'transaction' on 'IDBDatabase': The database connection is closing.
This could be upstream and suggests it could be from running out of disk space. Should we maybe not log these indexed DB errors to telemetry ?
if we expect the failure we should either catch the error and handle or catch and rethrow as
Change:
const connection = createConnection(messageReader, messageWriter); <del> startServer(connection); </del> <ins> startVsCodeServer(connection); </ins>

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was testing the server on neovim. I noticed the requires a lot from the client. Would it be possible to bundle default implementations of and all other custom requests to make the server self-contained?
I'd take a PR that does this (likely using service injection) but the current design is deliberate lets the client bring their own parser versionThe custom file messages means the server is not restricted to working with local files. Ideally the LSP would also include this functionality but right now it does not
I can make a PR. Wouldn't it be simpler to add a setting for a custom tokenizer? Then call with or make a request?
makes this easier to use the server as a library. For a client that doesn't want to implement the custom messages we use, you'd instead want to use the new version of which lets you pass in your own parser and workspace implementations
Change:
// Eslint: //   /some/file //     16:5  error ... <del> / *(?<link>(?<line>d+):(?<col>d+)?)/ </del> <ins> /^ *(?<link>(?<line>d+):(?<col>d+)?)/ </ins> ]; const gitDiffMatchers = [

Discussion:
Hi, similar to this issue but in my case the line numbers are within parenthesis and are not recognized. ! Current behavior: The file is recognized and I can click on it to open it but will not consider the linenumber Expected behavior: When the file is opened after click, it takes me to the right line number <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.2 <-- LATEST OS Version: Win 10 Steps to Reproduce: a cpp file with some syntax error that cpp file with FastBuild Note: reopening this issue after updating to latest version and verifying the bug is still there.
any more info on reproducing this? ! Do you get an underline when you hover it without holding ctrl? Is there something special about the path, like is it a remote mounted path or using symlinks?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Yes there is an underline on hover. No special paths, no mounted path, no symlinks.
Is the line number included in the underline? If you hover it without holding ctrl or cmd do you get a hover appearing?
I notice 2 cases: hover the entire line is underlined including the text to the right of the line number, and on click it takes me to a random line ! hover only the filepath and number are underlined (not including text to the right of line number), and on click it works fine !

I also noticed that the filepath slashes are forward slashes in normal prints and backward slashes in error prints, not sure if that is relevant so mentioning just in case.
I think I can reproduce: ! This is only on the prompt line of , the line with (5) works fine. It's weird that it happens sometimes but not others.
Pretty hard to reproduce consistently
On Windows sometimes weird stuff happens with line wrapping due to pty emulation, when the line is wrapped, it ends up matching this regex for an eslint-style multi-line link: !
Ok got the repro: Open pwsh Run (or some other file that exists) Run This makes the upwards scan succeed as it found which matches eslint's link format.
Change:
private async doSearch(): TPromise<any> { const value = this.searchBox.value || ''; this.searchExtensionsContextKey.set(!!value); <del> this.searchInstalledExtensionsContextKey.set(InstalledExtensionsView.isInsalledExtensionsQuery(value)); </del> <ins> this.searchInstalledExtensionsContextKey.set(InstalledExtensionsView.isInstalledExtensionsQuery(value)); </ins> this.searchBuiltInExtensionsContextKey.set(ExtensionsListView.isBuiltInExtensionsQuery(value)); this.recommendedExtensionsContextKey.set(ExtensionsListView.isRecommendedExtensionsQuery(value)); this.nonEmptyWorkspaceContextKey.set(this.contextService.getWorkbenchState() !== WorkbenchState.EMPTY);

Discussion:
Issue Type: <bSource Defect</bis missing a 't' for . I'll send a PR; looks like this isn't a public versioned API?