jiebi/CodeConvo huggingface dataset:
Change:
} // Check if chars before and after the two positions are equal <del> // For the chars before, `<` and `/` are consiered equal to handle the case of `<|></|>` function isCharBeforeAndAfterPositionsRoughtlyEqual(document: TextDocument, firstPos: Position, secondPos: Position) { </del> <ins> // For the chars before, `<` and `/` are considered equal to handle the case of `<|></|>` function isCharBeforeAndAfterPositionsRoughlyEqual(document: TextDocument, firstPos: Position, secondPos: Position) { </ins> const charBeforePrimarySelection = getCharBefore(document, firstPos); const charAfterPrimarySelection = getCharAfter(document, firstPos); const charBeforeSecondarySelection = getCharBefore(document, secondPos);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: macOS Steps to Reproduce: See the following gif: ! I first enter the tag which activates multicursor, then I use the key combi to select and jump to the end of the line, go one back and use "Backspace" to delete the attribute. This is a common operation, but now with mirror cursors it might break the HTML as seen in the gif above. Moreover, if the opening & closing tag are further apart, one might not even notice the HTML is broken. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Also this quite a lot as this is a very common operation. Related to this is ctrl+shift selecting out of the element tag name. I'd like to work on. The fix would be to exit mirror mode if the selection is not empty and we reach a none-matching state.
This also brings up an issue when you try to add an attribute to multiple tags that have none. ! If you click the open tag, it'll select the opening and closing, and usually when you're at the end and you press space to type in the attribute it doesn't add the attributes to the closing tag, but when you're adding more cursors to the tags in other lines, it doesn't act like that anymore and adds the attributes to both tags. I went crazy trying to find this to disable it.
Yeah looking at the current implementation, there's no support at all for multiple cursors. That's gonna take some work for the behavior to work correctly.
This feature doesn't work well with extension vim too, have to shut it down.
The fix will be available in until next month's release.
Change:
comment: ['The task command line or label'] }, 'Executing task: {0}', `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`), { excludeLeadingNewLine: true }) + taskShellIntegrationOutputSequence; } <ins> } else { shellLaunchConfig.initialText = taskShellIntegrationStartSequence + taskShellIntegrationOutputSequence; </ins> } }

Discussion:
!
works in OSS !
also works for me in insider's
works for that exact task for me !
It's because of this: Here's the I was using:
This works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !
Change:
break; } <del> child = this.parseChild(openedBracketIds); </del> <ins> child = this.parseChild(openedBracketIds, level + 1); </ins> } if (child.kind === AstNodeKind.List && child.childrenLength === 0) {

Discussion:
copy the contents of paste into a untitled editor it takes seconds for me before the content appears, sometimes not at all !
Oh, there is this in the console:
Change:
keepNotebookModelStoreInSync(context); const notebookSerializerOptions: OptionsWithCellContentMetadata = { transientOutputs: false, <ins> transientDocumentMetadata: { cells: true, indentAmount: true }, </ins> transientCellMetadata: { breakpointMargin: true, id: false,

Discussion:
I believe the property is to the notebook metadata only for internal usage, hence this should probably be marked as transient. !
Change:
} const code = dom.append(this.domNodes.signature, $('.code')); <del> const fontInfo = this.editor.getOption(EditorOption.fontInfo); code.style.fontSize = `${fontInfo.fontSize}px`; code.style.fontFamily = fontInfo.fontFamily; </del> const hasParameters = signature.parameters.length > 0; const activeParameterIndex = signature.activeParameter ?? hints.activeParameter;

Discussion:
I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi
I haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Yes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks
Change:
return; } <del> const primarySelection = this.templateData.editor.getSelection(); </del> <ins> const selections = this.templateData.editor.getSelections(); </ins> <del> if (primarySelection) { this.notebookEditor.revealLineInViewAsync(this.viewCell, primarySelection.positionLineNumber); </del> <ins> if (selections?.length) { const lastSelection = selections[selections.length - 1]; this.notebookEditor.revealLineInViewAsync(this.viewCell, lastSelection.positionLineNumber); </ins> } }));

Discussion:
Steps to reproduce: a large cell with height more than your screen. same word at the beginning and end of the cell. the word and use <kbdCtrl</kbd<kbdd</kbd(add selection to next find match) The new cursor is now outside viewport which contradicts with its behavior in normal editor (which centers new cursor if outside viewport). Does this issue occur when all extensions are disabled?: Yes VS Code version: Code 1.63.2 (, 2021-12-15T09:39:46.686Z) OS version: Linux x64 5.13.0-22-generic snap Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
exitCodeMessage = nls.localize('terminal.integrated.exitedWithInvalidPath', 'The terminal shell path "{0}" does not exist', this._shellLaunchConfig.executable); } else if (exitCode === SHELL_PATH_DIRECTORY_EXIT_CODE) { exitCodeMessage = nls.localize('terminal.integrated.exitedWithInvalidPathDirectory', 'The terminal shell path "{0}" is a directory', this._shellLaunchConfig.executable); <ins> } else if (exitCode === SHELL_CWD_INVALID_EXIT_CODE && this._shellLaunchConfig.cwd) { exitCodeMessage = nls.localize('terminal.integrated.exitedWithInvalidCWD', 'The terminal shell CWD "{0}" does not exist', this._shellLaunchConfig.cwd.toString()); </ins> } else if (this._processManager && this._processManager.processState === ProcessState.KILLED_DURING_LAUNCH) { let args = ''; if (typeof this._shellLaunchConfig.args === 'string') {

Discussion:
Invalid paths will cause the terminal to start at ' dir.
Is a variable a valid option to ? If so what variables? eg the directory of the current active document. This would replace the need for addin.
created
Would you suggest me to work on this thing and
Sorry for the delay, anything with the help wanted label is up for grabs
I'm sorry if it's not the correct issue to post this. I came here from following a bunch of now closed issues. So in case it could help you figure out what's wrong with this: I am having the very same error as described by . It started just after I upgraded budgie 17.10 (based on ubuntu) to 18.04 It happens only if all 3 of these conditions are met: have no terminal opened in the current instance of vscode. have several folders opened in the workspace have no specified (more on this below). If I use the command instead of the command , it prompts me to chose one of the opened folders in the workspace, and the terminal always starts successfully in this case. When trying to toggle the terminal (without any currently opened): The terminal fails to start with: set to either or . But the terminal starts successfully with a static value such as .
I have the same issue as , is there any solution to do this ? Split Terminal used to work, but now just trows 'chdir(2) failed' and 'The terminal process command '/bin/bash -l' failed to launch (exit code: 1)'
I noticed this problem for the first time today. I get the same error when I try to split the terminal. The issue occurs whenever I use the "Split Terminal" command. Using the "New Terminal" command does not throw this error.
After investigating a little further, the problem in my case is being caused by a unicode character in my file path. One of the folders in my file path is , and the apostrophe (right single quote) is the root of the problem. Removing that character from the folder name fixes it. I'm not sure why this only shows up with the "Split Terminal" command, though.
the cwd in split terminal is driven by this: ! It sounds like inherited (likely) breaks when it contains a ? Can you create a new issue for this?
Change:
override setActions(_primary: readonly IAction[], _secondary: readonly IAction[] = [], menuIds?: readonly MenuId[]): void { this._sessionDisposables.clear(); <del> const primary = _primary.slice(); </del> <ins> const primary: Array<IAction | undefined> = _primary.slice(); // for hiding and overflow we set some items to undefined </ins> const secondary = _secondary.slice(); const toggleActions: IAction[] = []; let toggleActionsCheckedCount: number = 0; <del> const extraSecondary: IAction[] = []; </del> <ins> const extraSecondary: Array<IAction | undefined> = []; </ins> let someAreHidden = false; // unless disabled, move all hidden items to secondary group or ignore them

Discussion:
open a file from a pull request get an error saying id cannot be read from undefined
this is a regression from
Yes, I too saw this when testing day before yesterday, but as soon as I updated this went away.
Change:
constructor(id: string, private _name: string, folders: vscode.WorkspaceFolder[], transient: boolean, configuration: URI | null, private _isUntitled: boolean, ignorePathCasing: (key: URI) => boolean) { super(id, folders.map(f => new WorkspaceFolder(f)), transient, configuration, ignorePathCasing); <del> this._structure = TernarySearchTree.forUris<vscode.WorkspaceFolder>(ignorePathCasing); </del> <ins> this._structure = TernarySearchTree.forUris<vscode.WorkspaceFolder>(ignorePathCasing, () => true); </ins> // setup the workspace folder data structure folders.forEach(folder => {

Discussion:
Type: <bBug</bSuppose I have the following workspace open: If a command calls on a URI with a string value of , I would expect to receive the workspace folder. Instead, I receive . However, if I remove the query parameter and reload the workspace, the call to with URI returns the workspace folder. VS Code version: Code - Insiders 1.90.0-insider (, 2024-06-04T01:35:33.174Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "5.1.0-beta.15", "xterm-addon-canvas": "0.3.0-beta.1", "xterm-addon-search": "0.11.0-beta.1", </del> <ins> "xterm": "5.1.0-beta.25", "xterm-addon-canvas": "0.3.0-beta.8", "xterm-addon-search": "0.11.0-beta.3", </ins> "xterm-addon-serialize": "0.9.0-beta.2", "xterm-addon-unicode11": "0.5.0-beta.1", <del> "xterm-addon-webgl": "0.14.0-beta.8", "xterm-headless": "5.1.0-beta.15", </del> <ins> "xterm-addon-webgl": "0.14.0-beta.16", "xterm-headless": "5.1.0-beta.25", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Testing using canvas render. ! Should the line be continuous even though it overlaps the characters? vs "on": ! I'm talking about characters like and .
I didn't bother adding this to the canvas renderer as it's the fallback which is primarily for iPad atm, nothing stopping it from working there too though. Should really consolidate the rendering code for webgl and canvas as they mostly do the same thing when drawing the actual characters.
The wavy underline looks off with gpu enabled (first example in the attached screenshot). With the canvas setting, it's not rendered at all. !
The look of curly was going to be revisited in
Change:
x = pos.x; y = pos.y; } <ins> let zoom = webFrame.getZoomFactor(); x *= zoom; y *= zoom; </ins> menu.popup(remote.getCurrentWindow(), Math.floor(x), Math.floor(y));

Discussion:
I can confirm this happens for me as well. I am using Mac OS X. The operating system's display scaling is off (i.e. 1:1). I have been experimenting and it seems as though the bug is that the right click menu is displayed according to the cursor position, but this calculation is not adjusted to take into account zoom. The reason I say this is because if I right click near the top left of the editor, the cursor is quite close to the top left of the menu. But if I right click near the bottom right of the editor, the cursor is much further away from the top left of the menu. The misalignment is proportional to the distance from the top left of the editor.
Change:
); } }, errors.onUnexpectedError); <del> }, Repl.REFRESH_DELAY); </del> <ins> }, delay); </ins> } }

Discussion:
When clicking the clear output action, the output is only cleared after 1 second. !
Every console update is done with a 0.5s delay to not kill the tree with too many updates Closing this as designed as this is the limitation we will have to live with as long as we use the tree. In the next couple of milestones I plan to investigate into using the editor instead of the tree.
...
Created a PR with a fix.
Great fix - thanks!
Change:
) { super(); <del> this.updateEnabled(); </del> <ins> if (cell.viewType !== 'interactive') { this.updateEnabled(); </ins> <del> this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled())); this._register(configurationService.onDidChangeConfiguration((e) => { if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) { this.updateEnabled(); } })); </del> <ins> this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled())); this._register(configurationService.onDidChangeConfiguration((e) => { if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) { this.updateEnabled(); } })); } </ins> } private updateEnabled() {

Discussion:
and interactive window and run a cell that will cause thow an error eg the line that errored in the cell is underlined and an unfixable problem is to the problems window can't even delete the cell to remove the error
edit: didn't realize this was for interactive windows. verifying that this is okay in the problems panel though? !
yeah, that's from pylance, different issue I guess verification should be to run this in the IW, since it won't fail a static check
Change:
} async show(query: string): TPromise<IPagedModel<IExtension>> { <del> if (InstalledExtensionsView.isInsalledExtensionsQuery(query)) { </del> <ins> if (InstalledExtensionsView.isInstalledExtensionsQuery(query)) { </ins> return super.show(query); } let searchInstalledQuery = '@installed';

Discussion:
Issue Type: <bSource Defect</bis missing a 't' for . I'll send a PR; looks like this isn't a public versioned API?
Change:
}); }); <ins> test('snippet completions - simple 2', function () { const provider = new SnippetCompletionProvider(modeService, snippetService); const model = disposables.add(createTextModel('hello ', undefined, 'fooLang')); return provider.provideCompletionItems(model, new Position(1, 6), context)!.then(result => { assert.strictEqual(result.incomplete, undefined); assert.strictEqual(result.suggestions.length, 2); }); }); </ins> test('snippet completions - with prefix', function () { const provider = new SnippetCompletionProvider(modeService, snippetService);

Discussion:
Issue Type: <bBug</bI would like the prefix to trigger only when there is a leading whitespace in front of the prefix (it is supposed to be substituted with an explicit non-breaking space character ). The example of the snippet: --The prefix behaves as if there is no leading space, meaning the remains one extra whitespace before the expanded body, resulting in a double space: . VS Code version: Code 1.55.2 (, 2021-04-13T09:35:57.887Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (37)</summaryExtensionVersion ------ html-snippets0.2.1 Handlebars0.4.1 rc-beautify1.2.0 git-temporal-vscode1.0.0 insert-unicode0.10.0 i30.0.1 vscode-generate-getter-setter0.5.0 gitlens11.4.1 vscode-html-css1.10.2 vscode-npm-script0.3.21 carbon-now-sh1.2.0 vscode-angular-html1.7.0 beautify1.5.0 latex-workshop8.18.0 polacode-.5.2 svg1.4.6 Angular211.0.0 solidity0.0.113 Kotlin1.7.1 rainbow-csv1.8.1 vscode-docker1.12.1 python2021.5. vscode-pylance2021.5.2 jupyter2021.5. remote-containers0.166.1 postscript1.0.1 java0.79.1 LiveServer5.6.1 bash-debug0.3.9 scala0.5.3 bash-beautify0.1.1 code-settings-sync3.4.3 code-spell-checker1.10.2 sass-indented1.8.16 html-preview-vscode0.2.5 vscode-ruby0.28.0 markdown-all-in-one3.4.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I have a fix for this but it makes bigger changes in how snippet completion are computed. Pushing out to November to get more Insider usage for it, changes are in
Change:
deprecationMessage: prop.markdownDeprecationMessage || prop.deprecationMessage, deprecationMessageIsMarkdown: !!prop.markdownDeprecationMessage, validator: createValidator(prop), <del> enumItemLabels: prop.enumItemLabels, </del> allKeysAreBoolean, editPresentation: prop.editPresentation, order: prop.order,

Discussion:
I don't have precise repro steps, but maybe: search for something scroll all the way down clear search searching animation persists
I'm unable to repro the issue. Let me know if there's any devtools errors next time it occurs.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
just reproduced this and will give us the logs
In the case of JooYoung, the search wasn't performed at all.
just reproduced myself
The error likely means there's an array that's undefined, but I'll probably have to reproduce the issue on OSS to actually see what's going on Example REPL run
it takes much longer than expected to stop - is there a long happening for input change or... ?
I'm unable to repro on the latest Insiders on Windows or macOS. For me, clearing the search stops it immediately.
Change:
"version.txt": "_clock", "version": "_clock", "mvnw": "_maven", <ins> "pom.xml": "_maven", </ins> "tsconfig.json": "_tsconfig", "swagger.json": "_json_1", "swagger.yml": "_json_1",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Can the default file icon theme be updated in VS Code (seems just need to follow the to run the script) files should by now have the Maven (mvnw) icon but are still showing regular XML icon.
Verify that the files now have the Maven (mvnw) icon
Change:
if (cell && cell.cellKind === CellKind.Markup) { const foundContentMatch = contentMatches.find(m => m.cell.handle === cell.handle && m.contentMatches.length > 0); const targetState = foundContentMatch ? CellEditState.Editing : CellEditState.Preview; <del> if (cell.getEditState() !== targetState) { </del> <ins> const currentEditingState = cell.getEditState(); if (currentEditingState === CellEditState.Editing && cell.editStateSource !== 'find') { // it's already in editing mode, we should not update continue; } if (currentEditingState !== targetState) { </ins> cell.updateEditState(targetState, 'find'); } }

Discussion:
Testing a notebook markdown cell in edit mode the find widget with a string that isn't in the markdown cell markdown cell is rendered !
Change:
*--------------------------------------------------------------------------------------------*/ // NOTE: VSCode's copy of nodejs path library to be usable in common (non-node) namespace <del> // Copied from: https://github.com/nodejs/node/blob/v14.16.0/lib/path.js </del> <ins> // Copied from: https://github.com/nodejs/node/blob/v16.14.2/lib/path.js </ins> /** * Copyright Joyent, Inc. and other Node contributors.

Discussion:
We will ship Electron with to stable soon so we should also look into bringing our copy of library to the same version. Checking for the diff, it seems to be a few commits after and up until //cc
Hm, the first change is already pretty bad for us: Because it seems to depend on a new thing which is maybe defined globally and probably optimised / cached / snapshotted. Maybe we should rather look out for actual bug fixes and focus on those... Changes: I think only the 2 fix commits stand out from the others
I assume you skipped over right?
Reopening given unit test failures, I had to revert the change for now.
yes I skipped the primordials. I didn't dig into why they do this, but it seemed easy enough to just call the string functions instead. As for the test failures, new PR
Primordials are only meant for Nodejs internal code usage, external users should just replace them with corresponding JavaScript builtins. You can read more about why Nodejs does it
Change:
this.view = new ListView(container, virtualDelegate, renderers, viewOptions); <del> if (typeof _options.ariaRole !== 'string') { this.view.domNode.setAttribute('role', ListAriaRootRole.TREE); } else { this.view.domNode.setAttribute('role', _options.ariaRole); } </del> <ins> this.updateAriaRole(); </ins> this.styleElement = DOM.createStyleSheet(this.view.domNode);

Discussion:
Environment Details: Application Name: Visual Studio Code Application Version: 1.38.1 (user setup) Commit: Electron: 4.2.10 10.11.0 OS: Windows_NT x64 10.0. Steps to Reproduce: any workspace with Extensions recommendations notification pops up Accessibility insights and track the control type for toast notification. type is tree when it is expected to be a dialog. Accessibility Impact: the control is called out as tree by screen reader which might be confusing.
It is true that each notification toast is a tree itself because that is the underlying widget we are using. We can possible change that if there is API from the tree level.
There is already a  in the AriaProvider which should be exposed in the . Not sure if you can use that one, or you need to introduce a new one or the current one will be enough? can you try it out?
this was not possible without tree changes (and also a bugfix where the tree would always set the aria role "tree", even if options were provided). Please review
I was able to verify this change, the toast now has a dialog role. One thing I noticed is that the contained still has . This doesn't cause issues with OS X voiceover, but we should keep an eye out on whether it confuses other screen readers.
Yeah, to change that would need additional support from the tree widget I think.
Please note that this should now be fixed properly via So the parent is a and each toast is a