jiebi/CodeConvo huggingface dataset:
Change:
dependencies: object-keys "~0.4.0" <del> xterm-addon-search@0.9.0-beta.22: version "0.9.0-beta.22" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.22.tgz#18f2eabda82709cdd64dee003879b586869e28a3" integrity sha512-1I8W0bwjg6bUoNaESKHSkS9BN3Z9Xe44/zbUb6Un+pbb5Nun4LQvFwSLkAIdRrslxcbcHYIU/2Q7F1wCOWLbaA== </del> <ins> xterm-addon-search@0.9.0-beta.23: version "0.9.0-beta.23" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.23.tgz#3f568afaddbb2cb9bb13a80deada6a3715a10172" integrity sha512-kKOyOf+9ERam6IGjV5LTQJTIL6HaiecZkMcrckMY9fUyH53+kknNMfGoBmMgDXWTe8WjBdyTtiqr120koDUKVQ== </ins> xterm-addon-serialize@0.7.0-beta.12: version "0.7.0-beta.12"

Discussion:
Testing macOS, zsh Do a couple of ls calls for something that has multiple matches in the terminal using the Down or Up arrow -notice how the count is always wrong !

Testing Notice how the "no results" is grey in the editor when the find input is empty. In the terminal it is red !

Refs: macOS, zsh shell Search for something in the terminal that does not exist -"no results" is not rendered. !

Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification

Testing a query which results in matches the terminal (e.g. expand or collapse explorer) :bug: match decorations remain !
Change:
weight: weight + 100000, primary: KeyCode.UpArrow, secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow], <ins> mac: { primary: KeyCode.UpArrow, secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow, KeyMod.WinCtrl | KeyCode.KeyP] }, </ins> } }));

Discussion:
Type: <bBug</bWith the previous native menu on macOS, Ctrl+N and Ctrl+P could be used to select code actions. This doesn't seem to work with the new custom one. I tried setting / , but that breaks Ctrl+N/P in the Command Palette. VS Code version: Code 1.71.0 (Universal) (, 2022-09-01T07:25:38.437Z) OS version: Darwin arm64 21.6.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Did you add a when-clause to your keybindings?
Is correct for how you can add your own keybindings I'll add them by default too since they also exist for the suggest widget
Change:
} async onWillCreateEditSessionIdentity(workspaceFolder: IWorkspaceFolder, cancellationToken: CancellationToken): Promise<void> { <ins> this._logService.debug('Running onWillCreateEditSessionIdentity participants...'); // TODO@joyceerhl show progress notification? </ins> for (const participant of this._participants) { await participant.participate(workspaceFolder, cancellationToken); } <ins> this._logService.debug(`Done running ${this._participants.length} onWillCreateEditSessionIdentity participants.`); </ins> } private _participants: IEditSessionIdentityCreateParticipant[] = [];

Discussion:
Testing on Windows 11, latest Insiders When I selected in the publish warning, the same notification toasted again. ! ! I hit Cancel again, and I was then prompted to sign into GitHub, which I already did in the browser before getting the branch toast: ! Perhaps tied to
I realize I'm now getting duplicate toasts after any option. When I selected Allow, I got the same toast again: !

Testing Choosing Never failed: <img width="458" alt="image" src="https://user-"
Choosing Always also failed: <img width="453" alt="image" src="https://user-"
I was using a public repo:
I experience the same on Windows 11 with the repo:
Create New Codespace still fails with ContinueOn
The original issue reported here was due to the fact that we weren't properly awaiting the branch publish before invoking the codespace creation. based on our offline discussion I think you're encountering a different issue because the publish completes but the codespace creation doesn't start, and only if you aren't signed into the GitHub Codespaces extension, so I'm going to close this issue and we can file a new one to investigate the scenario you've uncovered since I can't reproduce it at the moment:

Testing I can't choose to publish and ask again next time: <img width="264" alt="image" src="https://user-"
Also: The text doesn't indicate that the Always/Never choice only applies to the current workspace folder (as I just discovered) and not to all repositories.
+1, I was about to file the same issue.
Great feedback, this leads me to think we should just have 'Yes' and 'Cancel' as the options here, because choosing 'Never' will break the Continue On flow (i.e. it's not an option that we can actually support, and per we should actually throw a and bail out of the whole flow here).
'Publish Branch' might be clearer than 'Yes'. The PR extension uses this dialog: <img width="261" alt="image" src="https://user-"
The "fix" for this is more problematic for me. I used to have this in my settings: Now every time I quit VS Code (I'm on Mac if it makes a difference), I see the dialog and I have to press "Cancel". Even worse, pressing "Cancel" seems to only close the dialog and reopen it again. can we reopen this issue and restore the setting at least? That'd be highly appreciated. Thanks.
Change:
import { NotImplementedError } from 'vs/base/common/errors'; import { Emitter, Event } from 'vs/base/common/event'; import { DisposableStore } from 'vs/base/common/lifecycle'; <ins> import { ResourceMap } from 'vs/base/common/map'; </ins> import { Mimes } from 'vs/base/common/mime'; import { URI } from 'vs/base/common/uri'; import { mock } from 'vs/base/test/common/mock'; <del> import { ILanguageConfigurationService } from 'vs/editor/common/languages/languageConfigurationRegistry'; </del> import { ILanguageService } from 'vs/editor/common/languages/language'; <ins> import { ILanguageConfigurationService } from 'vs/editor/common/languages/languageConfigurationRegistry'; </ins> import { LanguageService } from 'vs/editor/common/services/languageService'; import { IModelService } from 'vs/editor/common/services/model'; import { ModelService } from 'vs/editor/common/services/modelService'; import { ITextModelService } from 'vs/editor/common/services/resolverService'; import { TestLanguageConfigurationService } from 'vs/editor/test/common/modes/testLanguageConfigurationService'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <ins> import { TestClipboardService } from 'vs/platform/clipboard/test/common/testClipboardService'; </ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService'; import { ContextKeyService } from 'vs/platform/contextkey/browser/contextKeyService'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; <ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { MockKeybindingService } from 'vs/platform/keybinding/test/common/mockKeybindingService'; </ins> import { ILayoutService } from 'vs/platform/layout/browser/layoutService'; import { IListService, ListService } from 'vs/platform/list/browser/listService'; import { ILogService, NullLogService } from 'vs/platform/log/common/log';

Discussion:
From
The core might have heuristics of if/when should be called, maybe this test can be turned into a unit test first?
Was just looking at this. That might make sense too, but it also seems to make sense to test this as an API contract.
Is it going to make a difference if I move off the deprecated WorkspaceEdit api?
The issue you have mentioned with the editor service, I wonder if that could be in play here because this failure is just implying that the cell did not get rendered and initially request statusbar items. This test also doesn't make sense because it's just awaiting the same promise twice
Change:
* The HTML element containing the hover status bar. */ hoverElement: HTMLElement; <ins> /** * The actions of the hover status bar. */ actions: HoverAction[]; </ins> } type IRenderedContentHoverPartOrStatusBar = IRenderedContentHoverPart | IRenderedContentStatusBar;

Discussion:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!
Change:
} /** <ins> * Migrate old configuration(string) for extensionsPath to new type(string[]) * https://github.com/microsoft/vscode/issues/117517 */ export function migrateEmmetExtensionsPath() { // Get the detail info of emmet.extensionsPath setting let config = vscode.workspace.getConfiguration().inspect('emmet.extensionsPath'); // Update Global setting if the value type is string or the value is null if (typeof config?.globalValue === 'string') { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [config.globalValue], true); } else if (config?.globalValue === null) { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [], true); } // Update Workspace setting if the value type is string or the value is null if (typeof config?.workspaceValue === 'string') { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [config.workspaceValue], false); } else if (config?.workspaceValue === null) { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [], false); } // Update WorkspaceFolder setting if the value type is string or the value is null if (typeof config?.workspaceFolderValue === 'string') { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [config.workspaceFolderValue]); } else if (config?.workspaceFolderValue === null) { vscode.workspace.getConfiguration().update('emmet.extensionsPath', []); } } /** </ins> * Mapping between languages that support Emmet and completion trigger characters */ export const LANGUAGE_MODES: { [id: string]: string[] } = {

Discussion:
Testing Bug Currently the setting can only be configured by editing the file. It would be nice if you could configure it using our settings UI as well
It'd make sense to me to deprecate the string/null potential values in favor of an array of strings. You could declare the settings as (which settings editor can handle, see ), then transform existing 's to the empty array and existing single string values to .
Change:
mds.appendMarkdown(`[$(zap)-link](#link)`); let result: HTMLElement = renderMarkdown(mds).element; <del> assert.strictEqual(result.innerHTML, `<p><a href="" data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></p>`); </del> <ins> assert.strictEqual(result.innerHTML, `<p><a data-href="#link" href="" title="#link"><span class="codicon codicon-zap"></span>-link</a></p>`); </ins> }); test('render icon in table', () => {

Discussion:
Issue Type: <bBug</bHello, Regarding the , in Markdown this: Renders a link. In a VS Code Extension, this is also possible: Creating a link to run a command. One would think creating an actual anchor link like this: Would work but the click does not execute the command. VS Code version: Code 1.63.0 (, 2021-12-07T05:18:59.299Z) OS version: Linux arm64 5.15.7-1-MANJARO-ARM Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ vscode-eslint2.2.2 gitlens11.7.0 vscode-drawio1.6.4 vsliveshare1.0.5242 </details<!-- generated by issue reporter --
can i take this?
I think they'd be happy if you created a PR. For completeness: works: but the cursor does not change to a hand icon like if was populated.
Thanks, will take a look
This is what I found. In markdown links are detected at two places: detects anything starting with http:// or https:// or file:// checks for and returns anything inside () as URI That's why is detected as a link but isn't. I couldn't get to work. I tried holding ctrl while clicking it and tried in preview as well. Can you tell me how to reproduce it?
You'll need to for it to take an action. The example in the link is probably the easiest. After registration create a MarkdownString containing the registered command. In regards to the linked example: You should be able to click on it and see the console log. Note that the cursor doesn't change to a hand icon.
Have you found any solution? For me even doesn't work. :( I've used a registered and available command.
The way I implemented Markdown and executing a registered command (through ) was by adding a . The structure is very particular because it is an implementation of the and is something like this: Make sure you are using the correct VS Code version too.
Command links in should now also work for normal elements included in the markdown (you have to set and on the to enable this)
where should links work? I tried this in a completion item and neither link syntaxes work: !
Sorry for not adding verification details. The markdown string needs to both trusted and have html enabled:
Change:
menu: { id: MenuId.ExtensionContext, group: '2_configure', <del> when: ContextKeyExpr.and(ContextKeyExpr.equals('extensionStatus', 'installed'), ContextKeyExpr.has('isDefaultApplicationScopedExtension').negate()), </del> <ins> when: ContextKeyExpr.and(ContextKeyExpr.equals('extensionStatus', 'installed'), ContextKeyExpr.has('isDefaultApplicationScopedExtension').negate(), ContextKeyExpr.has('isBuiltinExtension').negate()), </ins> order: 3 }, run: async (accessor: ServicesAccessor, id: string) => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --I have multiple profiles in VS Code and I disable everything I don't need in each of them, including built-in extensions that I will never use with a particular profile. After the successful installation of the latest version I wanted to try the new option; while it works for user-installed extensions, it fails for built-in extensions, read more below. Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: , 22H2 (.2070) Steps to Reproduce: the extensions view built-in extensions only the cog icon on any (enabled) extension on error will occur (see attached screenshot) <div align="center"<img src="" alt="Error in VS Code"</div<brNote: all extensions are present at the provided folder shown in the error message.
Same for me but on MacOS Ventura 13.5 (22G74)
Can you see if the extension is maybe uninstalled when you follow your steps? That could hint to
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
Unfortunately the latest patch release: and the mentioned didn't fix it, here's the error screenshot again, in the latest version. Also, I've opened the folder itself where the extension is located, while VS Code complains it doesn't exist. <div align="center"<img src="" alt="Error in VS Code"</div
This action should not be shown on builtin extensions because they are available for all profiles by default.
Change:
return; } <del> const outputSeverity = event.body.category === 'stderr' ? Severity.Error : event.body.category === 'console' ? Severity.Warning : Severity.Info; </del> if (event.body.category === 'telemetry') { // only log telemetry events from debug adapter if the debug extension provided the telemetry key // and the user opted in telemetry

Discussion:
on macOS ventura, using Angular 12. See screenshot. ! The line of code below is what causes the above error to be logged: But the text is grey, and there doesn't seem to be a way around this, which is a problem.
Seems like the class is not applied to stderr output with variablesReferences
I think there is an issue for this, I can't find it right now. Started working on it but needs a little refactor
Going to steal this since involves fixing that todo
Change:
} }); <del> this.customMenus[menuIndex].buttonElement.on(EventType.CLICK, () => { </del> <ins> this.customMenus[menuIndex].buttonElement.on(EventType.CLICK, (e) => { </ins> if (this._modifierKeyStatus && (this._modifierKeyStatus.shiftKey || this._modifierKeyStatus.ctrlKey)) { return; // supress keyboard shortcuts that shouldn't conflict } if (this.isOpen) { if (this.isCurrentMenu(menuIndex)) { <del> this.focusState = this.currentMenubarVisibility === 'toggle' ? MenubarState.HIDDEN : MenubarState.VISIBLE; </del> <ins> this.setUnfocusedState(); </ins> } else { this.cleanupCustomMenu(); this.showCustomMenu(menuIndex);

Discussion:
Issue Type: <bBug</bWhen using the custom title bar and the toggled menu bar setting, the menu bar becomes stuck in the toggled on state. This primarily occurs when the active VS Code window becomes inactive while the menu bar is toggled on. When using multiple VS Code windows this makes it difficult to identify the correct window because the title bar's filename information is hidden. Steps to reproduce: the setting to , and setting to VS Code is the active window, hold down the key to show the menu bar the key while still holding the key to switch to another application. The active VS Code window becomes inactive and the menu bar is visible. Alternatively you can click outside of the active VS Code window while the menu bar is being displayed. VS Code version: Code 1.25.0 (, 2018-07-05T13:11:58.697Z) OS version: Windows_NT x64 10.0. <details<summaryExtensions (4)</summaryExtensionVersion ------ classic-asp0.0.4 vscode-icon-theme1.6.2 csharp1.15.2 PowerShell1.8.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.538 --- <!-- score: 0.491 --- <!-- score: 0.483 --- <!-- score: 0.482 --- <!-- score: 0.48 --<!-- potentialduplicatescomment --
Change:
renderElement(node: ITreeNode<FolderMatch, any>, index: number, templateData: IFolderMatchTemplate): void { const folderMatch = node.element; <ins> folderMatch.compressionStartParent = undefined; </ins> if (folderMatch.resource) { const workspaceFolder = this.contextService.getWorkspaceFolder(folderMatch.resource); if (workspaceFolder && isEqual(workspaceFolder.uri, folderMatch.resource)) {

Discussion:
Testing Open in VS Code Insiders Search for "containers" Exploring results and collapsing/uncollapsing works for a while :bug: Then "Collapse All" does nothing !
It seems I'm able to repro by: Reload window from above state Search for "containers" again, works correctly "Collapse All," works correctly Uncollapse, works correctly Try "Collapse All" again, stuck in unresponsive state above
Actually seems I misread the button - I guess it's always "Collapse All" and doesn't become an option to uncollapse. I was confused since hitting collapse two times in a row changes the search results, so I assumed it was collapsing and then uncollapsing. Not sure if this is expected: ! I've renamed the issue to be reflective of what I actually experienced. If this is expected, please feel free to close. Sorry for confusion!
No, that's totally a bug , it shouldn't get stuck like that. Thanks for catching that!
Change:
return false; } <ins> if (!isCopy && items.every((source) => source.isReadonly)) { return false; // Cannot move readonly items unless we copy } </ins> if (items.some((source) => { if (source.isRoot && target instanceof ExplorerItem && !target.isRoot) { return true; // Root folder can not be moved to a non root file stat.

Discussion:
Noticed how readonly files indicate that move is possible, but I would have only expected drop feedback when doing copy. !
PR:
What are some verification steps for this issue? On Windows, I made a file read-only, and I was able to drag and drop it without any issues.
open the repo and try to drag and drop a file of the folder.
Change:
} // Add default override indicator text <del> if (element.setting.defaultValueSource) { const defaultValueSource = element.setting.defaultValueSource; </del> <ins> if (element.defaultValueSource) { const defaultValueSource = element.defaultValueSource; </ins> if (typeof defaultValueSource !== 'string' && defaultValueSource.id !== element.setting.extensionInfo?.id) { const extensionSource = defaultValueSource.displayName ?? defaultValueSource.id; ariaLabelSections.push(localize('defaultOverriddenDetails', "Default setting value overridden by {0}", extensionSource));

Discussion:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.
Change:
import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { workbenchConfigurationNodeBase, Extensions as WorkbenchExtensions, IConfigurationMigrationRegistry, ConfigurationKeyValuePairs } from 'vs/workbench/common/configuration'; import { AccessibilityAlertSettingId, AccessibilitySignal } from 'vs/platform/accessibilitySignal/browser/accessibilitySignalService'; <del> import { ISpeechService } from 'vs/workbench/contrib/speech/common/speechService'; </del> <ins> import { ISpeechService, SPEECH_LANGUAGES, SPEECH_LANGUAGE_CONFIG } from 'vs/workbench/contrib/speech/common/speechService'; </ins> import { Disposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Event } from 'vs/base/common/event';

Discussion:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked