jiebi/CodeConvo huggingface dataset:
Change:
const cmdArgs = ['/c', 'start', '/wait']; if (exec.indexOf(' ') >= 0) { // The "" argument is the window title. Without this, exec doesn't work when the path <del> // contains spaces cmdArgs.push('""'); </del> <ins> // contains spaces. #6590 // Title is Execution Path. #220129 cmdArgs.push(exec); </ins> } cmdArgs.push(exec); // Add starting directory parameter for Windows Terminal (see #90734)

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0 OS Version: WindowsNTx64 10.0. Steps to Reproduce: powershell 7.x external terminal by the terminal title showing Additional Info: this happens not only with powershell 7.x it may happen with all terminal which path contains space I found relate code: , the code converted to node command is the comment for said used to solve something, but now it cause showing,
To verify make sure you can still open a pwsh+cmd external terminal on Windows
Change:
*--------------------------------------------------------------------------------------------*/ .suggest-input-container { <del> padding: 2px 4px; </del> <ins> padding: 2px 6px; border-radius: 2px; </ins> } .suggest-input-container .monaco-editor-background,

Discussion:
Looking at ways to make VS Code feel ever so slightly more approachable. A subtle 2px border radius on our common input components could be one way to make the UI feel more inviting and less harsh: <img width="361" alt="CleanShot 2022-04-08 at 14 48 52 src="https://user-"<img width="522" alt="CleanShot 2022-04-08 at 14 55 52 src="https://user-"<img width="494" alt="CleanShot 2022-04-08 at 14 58 01 src="https://user-"<img width="437" alt="CleanShot 2022-04-08 at 14 49 46 src="https://user-"<img width="500" alt="CleanShot 2022-04-08 at 15 01 55 src="https://user-"! FWIW, we already use a border radius on our icon buttons: <img width="300" alt="CleanShot 2022-04-08 at 15 03 36 src="https://user-"cc
I like this idea for buttons. I am not so sure about input/combo boxes.
I'm a +1 on this one, I think the inputs might need a bit of spacing from the side to feel more natural. We should also make sure that our labels are distinguishable as they start looking similar. Maybe we update the labels to be more pill-like?
As in padding L/R? I think they are indeed a bit different from our dropdowns if memory serves. Good call on the labels/tags.
Border-radius on buttons was merged but inputs is still under discussion so I'll keep this one open.
Good job
Change:
constructor( public readonly range: LineRange, public readonly lines: string[], <ins> public readonly source: LineRangeMapping, </ins> ) { let counter = 0; for (let i = range.startLineNumber - 1; i < range.endLineNumberExclusive - 1; i++) {

Discussion:
When a code fragment of at least 3 lines of code is deleted somewhere in inserted somewhere else without modifications, this move should be detected. . (select latest -dev version to verify)
Change:
}, dispose(): void { disposables.dispose(); <ins> outputChannel.dispose(); </ins> } }; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.
Thanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like "command was already registered" or "notebook controller already exists". I am currently commenting out my line in my extension. It's not ideal though.
PR fixing it
Change:
import { getInstanceFromResource, parseTerminalUri } from 'vs/workbench/contrib/terminal/browser/terminalUri'; import { ILocalTerminalService, IOffProcessTerminalService } from 'vs/workbench/contrib/terminal/common/terminal'; import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; <del> import { IEditorService, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService'; </del> <ins> import { IEditorService, ACTIVE_GROUP, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService'; </ins> import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
<key>controlWords</key> <dict> <key>match</key> <del> <string>(b(?&lt;!-|$)(?i:begin|exit|break|return|catch|finally|for|continue|foreach|throw|from|trap|try|do|if|until|in|using|else|elseif|while|end|where)b(?!-|.))</string> </del> <ins> <string>(b(?&lt;!-|$)(?i:begin|process|exit|break|return|catch|finally|for|continue|foreach|throw|from|trap|try|do|if|until|in|using|else|elseif|while|end|where)b(?!-|.))</string> </ins> <key>name</key> <string>keyword.control.powershell</string> </dict>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
const relativeResourcePath: AppResourcePath = `vs/workbench/contrib/webview/browser/pre/${entry}`; const url = FileAccess.asFileUri(relativeResourcePath); return callback({ <del> path: decodeURIComponent(url.fsPath), </del> <ins> path: url.fsPath, </ins> headers: { ...COI.getHeadersFromQuery(request.url), 'Cross-Origin-Resource-Policy': 'cross-origin'

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0 (Universal) OS Version: Darwin arm64 21.5.0 (macOS 12.4) Steps to Reproduce: a ".md" file command "Markdown: Open Preview" an blank window I've tried following methods, but the issues persist: VSC via "code --no-sandbox" VSC via "code --disable-extensions" a "Visual Studio Code - " (use it for the first time) Below is my VSC <img width="1800" alt="image" src="https://user-"Below is my newly downloaded VSC-insiders <img width="1800" alt="image" src="https://user-"
Do the release notes and other webview still work?
Release notes, as well as other webview, do not work. They just show a blank window. <img width="1444" alt="image" src="https://user-"
Any further suggestions on solving this problem?
If you run , you see any errors in the developer console?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
It seems that there isn't any helpful information. <img width="1444" alt="image" src="https://user-"
It seems that I have found the cause of this bug: something to do with the "%" in the app path.

When path is "/Applications/Visual Studio ": <img width="1105" alt="Snipaste2022-08-2911-53-27" src="https://user-"- When path is "/Applications/%IDEs/Visual Studio ": <img width="1146" alt="Snipaste2022-08-2911-54-56" src="https://user-"
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
} private doTrigger(): void { <del> provideSignatureHelp(this.editor.getModel(), this.editor.getPosition()) </del> <ins> if (this.provideSignatureHelpRequest) { this.provideSignatureHelpRequest.cancel(); } this.provideSignatureHelpRequest = provideSignatureHelp(this.editor.getModel(), this.editor.getPosition()) </ins> .then(null, onUnexpectedError) .then(result => { if (!result || !result.signatures || result.signatures.length === 0) {

Discussion:
From Steps to Reproduce: top of , add: code dev so that the modified ts extension is running a ts file in the dev instance of code: signature help in but then move the cursor up or down a line Bug Even though we likely no longer need the signature help result, it appears that we never actually cancel SignatureHelpProvider request
Cases where we may want to cancel the request: Selection change Document contents change Active document changes Suggestions requested
Should be fixed for the following cases: Document changes Request cancelled by user Mouse selection Re-trigger hints
Change:
return format(noKbMsg, commandId); } <del> export async function runAccessibilityHelpAction(accessor: ServicesAccessor, editor: ICodeEditor): Promise<void> { </del> <ins> export async function runAccessibilityHelpAction(accessor: ServicesAccessor, editor: ICodeEditor | IVisibleEditorPane): Promise<void> { </ins> const accessibleViewService = accessor.get(IAccessibleViewService); const helpText = getAccessibilityHelpText(accessor); accessibleViewService.show({

Discussion:
a markdown cell in preview mode like Accessibility Help :bug: accessibility help does not appear If I focus a code cell I get the help view
IMO, this should not be working at all for github issue notebooks
Why is that? The notebooks UI and keybindings/commands are generic (though can be overridden by extensions)
Change:
result: string; initialResult?: string; } <ins> export const StorageCloseWithConflicts = 'mergeEditorCloseWithConflicts'; </ins>

Discussion:
a conflict file in 3 way merge the 3 way merge editor Notice dialog ! I do not think we have a need for this dialog any more since we are no longer removing the conflict markers. Thus the user can just close this dialog, there is no data loss? Similarly when the user closes the old editor with conflict markers we do not prompt. fyi
I don't have an opinion about this.
I would leave it for the clarity it creates, however I am open for a "don't ask again" option
"Don't ask again" works for me, especially since I just noticed that when some conflicts get resolved the dialog is "smarter". Would don't ask again write in storage or a setting? I am fine going loco and writing to storage (so users can not revert). Though if all the other "don't ask again" write in settings then I guess I am fine with that.
+1 for "Don't ask again"
Fyi there is a very practical use case for the dialog: if you run with and use VSCode as Git merge editor, you may actually want to resolve the conflicts before closing the editor because Git somewhat expects you to do so. On top of that, given , we currently cannot pass back an exit code to Git, so it helps showing a dialog to avoid returning back to Git with merge conflicts still in the file. Besides, we show a similar dialog when you try to stage a file that has merge conflicts from the SCM view: !
thanks for providing more info, I missed that case. Though I think it does not conflict with our idea to add "Don't Ask Again".
Can we tell the merge editor if it was opened in a modal context (like with --wait)?
Currently not, an editor has no knowledge that it is being utilised for . There is plumbing around the editor where we observe the opened editor for being closed and then delete the wait marker file. Can we get more user feedback on this before jumping onto a conclusion?
Verify that there is an option to not be asked again there is a "Reset Choice for Close with Conflicts" commands in the F1 list <img width="1405" alt="Screenshot 2022-11-25 at 15 24 27" src="https://user-"
Adding verified since this works as expected. Noticed one minor "glitch".

"Don't ask again" Cancel The "Don't ask again" choice will be preserved. It should probably be only preserved if I click on "Close with Conflicts". I am not supper passionate about this, but let me know if you would like me to file an issue
Change:
) )); <del> gulp.task('vscode-translations-pull', function () { return es.merge([...i18n.defaultLanguages, ...i18n.extraLanguages].map(language => { const includeDefault = !!innoSetupConfig[language.id].defaultInfo; return i18n.pullSetupXlfFiles(apiHostname, apiName, apiToken, language, includeDefault).pipe(vfs.dest(`../vscode-translations-import/${language.id}/setup`)); })); }); </del> gulp.task('vscode-translations-import', function () { const options = minimist(process.argv.slice(2), { string: 'location',

Discussion:
Testing in Firefox, with Spanish (es-es) set Open "Get Started with VS Code in the Web" walkthrough Select last step (open up your code), then first command ("Open Folder" in English, "Abrir carpeta" in Spanish) Modal is in English: ! It isn't a new string, and I didn't think getting started or this command would be from an extension, but perhaps that is the case.
I also see this on modals on the overall welcome page when I try opening a file or folder: !
Thank you for your feedback. We are currently reviewing it (reference ).
This is an odd one. The string looks good here: but the file that that comes from doesn't show up at all in our Spanish files: I'll have to dig into why this is... any ideas?
might be a bug in the tool so that the localize call is not detected. When you generate the export is the string included.
Ok the web strings are now bundled in language packs. It may take a minute for all these new strings to make their way through the translation system... but by end game it should be good.
Change:
.monaco-workbench .notifications-list-container .notification-list-item .notification-list-item-buttons-container .monaco-button { max-width: fit-content; padding: 5px 10px; <del> margin-left: 10px; </del> <ins> margin: 4px 5px; /* allows button focus outline to be visible */ </ins> font-size: 12px; overflow: hidden; text-overflow: ellipsis;

Discussion:
Environment Details: VSCode Version : 1.24.0 OS Version : Win10 Additional Details: MAS Violated : MAS 2.4.7 Repro Steps: to Status Bar at the bottom and move to notifications. to any notification that appears at the screen. to any button inside the notification. Actual: The focus is not marked using dotted-lines/rectangle to indicate the focus on the buttons. Only color changes to mark the focus on the buttons. Expected: The focus should be visible using dotted-lines/rectangle to indicate the focus on the buttons. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: Low vision/visually impaired users should be able to distinguish the focused element. MAS Reference: MAS2.4.7 - {-4fab-4d3e-81af-} Attachment For Reference: Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.664 --- <!-- score: 0.545 --- <!-- score: 0.481 --<!-- potentialduplicates_comment --
we have a high contrast theme for people that want a much stronger focus indication, isn't that sufficient? !
Agreed focus visibility is working for High contrast theme. But all low vision users may not be comfortable in using only one theme(here High Contrast). Other users using "Light Visual Studio" will again face issues in focus visibility. Switching themes may not be always a good option. Dotted-lines/rectangle to indicate focus can serve purpose for all of the themes listed.
There is a border around the button when it gets focus but the border (blue) color collides with the blue background of the button. It may work better in other themes.
do we plan to do something here? If no we should close as invalid and explain why fyi since it is a contrast issue
I am happy for suggestions.

we did start showing the outline with an offset in the extension viewlet: <img width="420" alt="image" src="https://user-"We could try the same thing with our primary buttons: <img width="477" alt="image" src="https://user-"
I actually like that if we can make it so that it really only shows up on focus but e.g. not when clicking (this might be a bit tricky to get right).
Gives me a bit of a blurry effect. Definetly would not like to get it on click. THough might be one of those things that I need to really try out to get a complete impression
Change:
}); suite('appendToLinkSnippet', () => { <ins> test('Should create auto link when pasted link has an mismatched parentheses', () => { const uriString = 'https://www.mic(rosoft.com'; const snippet = appendToLinkSnippet(new vscode.SnippetString(''), false, 'https:/www.microsoft.com', '', uriString, 0, true); assert.strictEqual(snippet?.value, '<https://www.mic(rosoft.com>'); }); test('Should create snippet with < > when pasted link has an mismatched parentheses', () => { const uriString = 'https://www.mic(rosoft.com'; const snippet = appendToLinkSnippet(new vscode.SnippetString(''), true, 'https:/www.microsoft.com', 'abc', uriString, 0, true); assert.strictEqual(snippet?.value, '[${0:abc}](<https://www.mic(rosoft.com>)'); }); </ins> test('Should not create Markdown link snippet when pasteAsMarkdownLink is false', () => { const uriString = 'https://www.microsoft.com'; const snippet = appendToLinkSnippet(new vscode.SnippetString(''), false, 'https:/www.microsoft.com', '', uriString, 0, true);

Discussion:
Type: <bBug</b( it into a markdown file Bug The inserted markdown link is not valid because of the mismatched parens In cases like this, we can either escape the with or wrap the entire url in : VS Code version: Code - Insiders 1.81.0-insider (Universal) (, 2023-07-25T08:15:40.243Z) OS version: Darwin x64 22.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
! looks correct in that it displays with but the rightmost parenthesis is still highlighted red. Is this the desired behavior
Can you please open a new issue for that? I think bracket pair colorization isn't working properly in this case (the markdown grammar seems to get it right)
Change:
private _search(filterOwnerId: number, filterOutValidation: boolean, overviewRulerOnly: boolean, cachedVersionId: number, onlyMarginDecorations: boolean): IntervalNode[] { if (overviewRulerOnly) { return this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); <del> } else if (onlyMarginDecorations) { const r0 = this._decorationsTree0.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); const r1 = this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); return r0.concat(r1); </del> } else { const r0 = this._decorationsTree0.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); const r1 = this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);

Discussion:
an active debug session a bookmark to one line a breakpoint to the same line where the breakpoint ends up being an inline breakpoint :bug: the margin resizes so that the bookmark on the line in step 2 is also gone Debugging this in devtools, this appears to be because the breakpoint does not appear in the result of . Therefore it's not taken into account when calculating the size of the margin. When we actually go to render the decorations, we use a different source of information , where the breakpoint does show up, so we end up rendering it even though no lane space was allocated for it. ! Those inline breakpoints appear by using injected text: I think the problem is that the fast path for getting just margin decorations doesn't search the injected text interval tree for margin decorations (because I didn't realize that margin decorations could appear in the injected text interval tree when implementing ). Only caught this now because inline breakpoints only show up when there are active debug sessions, and I didn't have a case where I set a breakpoint on a line with another decoration in a debug session till today :/