jiebi/CodeConvo huggingface dataset:
Change:
cursor: pointer; } <ins> .monaco-button-dropdown.disabled { cursor: default; } </ins> .monaco-button-dropdown > .monaco-button:focus { outline-offset: -1px !important; } <ins> .monaco-button-dropdown.disabled .monaco-button-dropdown-separator { opacity: 0.4; } </ins> .monaco-button-dropdown .monaco-button-dropdown-separator { padding: 4px 0; }

Discussion:
Separator background is incorrect Separator cursor is incorrect <img width="620" alt="image" src="https://user-"
Change:
flex: 1; padding-left: 20px; overflow: hidden; <ins> user-select: text; </ins> } .extension-editor > .header > .details > .title {

Discussion:
Bug Click on any extension in the extensions view to open the extensions editor Triple click on the extension id (next to the extension name) -the whole id gets selected Ctrl+C to copy and them paste elsewhere Expected: The extension id gets copy pasted Actual: The extension id along with everything that follows it gets copy pasted For eg: In the case of , the below gets copied to the clipboard ms- Preview Microsoft40,119RepositoryLicense An Azure Functions extension for Visual Studio Code. Install Details Contributions Changelog Dependencies VS Code version: Code - Insiders 1.20.0-insider (, 2018-02-06T15:20:43.871Z) OS version: Windows_NT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ Go0.6.73 vsliveshare0.2.66 debugger-for-chrome4.1.0 vscode-versionlens0.19.1 sass-indented1.4.6 language-stylus1.8.0 </detailsReproduces only with extensions
I would suggest to add and label to this one
This is a weird one . From my investigation if you give - to the element next to the tag ( which is the tag in this case ), it fixes selection for the . But this in-turn breaks again if you select tag. Any to suggestions on this? Attaching screenshot for the css - <img width="655" alt="screen shot 2018-02-10 at 3 03 48 pm" src="https://user-"
No idea :) You will have to play around with values for and understand how it behaves in different scenarios
Change:
private static _moveIndex(fwd: boolean, model: CompletionModel, index: number): number { let newIndex = index; <del> while (true) { </del> <ins> for (let rounds = model.items.length; rounds > 0; rounds--) { </ins> newIndex = (newIndex + model.items.length + (fwd ? +1 : -1)) % model.items.length; if (newIndex === index) { break;

Discussion:
Version: 1.77.0-insider (Universal) Commit: Date: 2023-03-03T05:23:13.637Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin arm64 20.6.0 Sandboxed: Yes ProductName: macOS ProductVersion: 11.7.4 BuildVersion: 20G1120 <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: the following extension sample: a text document. and type falls into an infinite loop https://user-
I can reproduce. Thanks for reporting this, looking into this asap
To reproduce use completion provider from above have a text file with  type  after the existing  and select the second option The issue is computing alternative suggestions (for tab complete). That trips on an invalid state because the chosen (start) index doesn't exist anymore. That's because the model updated in response to applying the additional edits.
Change:
"when": "config.git.enabled && scmProvider == git && gitState == idle" }, { <ins> "command": "git.commitAllAmend", "group": "3_commit", "when": "config.git.enabled && scmProvider == git && gitState == idle" }, { </ins> "command": "git.undoCommit", "group": "3_commit", "when": "config.git.enabled && scmProvider == git && gitState == idle"

Discussion:
Like: git commit --amend
Are you referring to the out of the box git behavior or any particular git extension?
I would guess the out of the box behaviour, because it seems to be missing? I can see there is an "undo last commit", but this unstages everything from the last commit, which is not the same thing as amending the current commit. git-gui and atom have a simple checkbox which then amends the current commit instead of creating a new one - would it be possible to have the same in vscode? It's the one thing that stops me using vscode's built in git interface. In other words, you should be able to check and then uncheck the checkbox and be left in the original state. With the "undo last commit", this isn't possible.
Yes, out of the box
command was some time ago by
Should there be something in the menu? Please can you tell me where the option is?
Hmmm.... looks like it has disappeared for some reason, probably was omitted when git integration was ported to new API... will probably know if it was by-design, or just someone missed one command while porting git integration.
I believe we simply missed it... sorry for that.
I'll add it again.
Change:
import { isMacintosh } from 'vs/base/common/platform'; import { getMachineId } from 'vs/base/node/id'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> import { IStateReadService } from 'vs/platform/state/node/state'; import { machineIdKey } from 'vs/platform/telemetry/common/telemetry'; <del> export async function resolveMachineId(stateService: IStateReadService) { </del> <ins> export async function resolveMachineId(stateService: IStateReadService, logService: ILogService) { </ins> // We cache the machineId for faster lookups // and resolve it only once initially if not cached or we need to replace the macOS iBridge device let machineId = stateService.getItem<string>(machineIdKey); if (typeof machineId !== 'string' || (isMacintosh && machineId === '6c9d2bc8f91b89624add29c0abeae7fb42bf539fa1cdb2e3e57cd668fa9bcead')) { <del> machineId = await getMachineId(); </del> <ins> machineId = await getMachineId(logService.error.bind(logService)); </ins> } return machineId;

Discussion:
When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to
if you support the idea I can provide a PR
that all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.
Change:
const extension = result.firstPage[0]; return this.windowService.focusWindow().then(() => { <del> return this.open(extension).then(() => { this.notificationService.prompt( Severity.Info, nls.localize('installConfirmation', "Would you like to install the '{0}' extension?", extension.displayName, extension.publisher), [{ label: nls.localize('install', "Install"), run: () => this.install(extension).then(undefined, error => this.onError(error)) }], { sticky: true } ); }); </del> <ins> return this.open(extension); </ins> }); }); }).then(undefined, error => this.onError(error));

Discussion:
Issue Type: <bBug</bI noticed when I install extension by clicking on the green "Install" button from within the VScode extension page, as opposed to the "Would you like to install..." notification/chat bubble in the lower right corner of the editor, the chat bubble stays there, asking me if I want to install the extension I just installed. Would be great if the state was in sync and the bubble would be dismissed when I installed the extension, no matter how. <details<summaryScreenshot after installation</summary<img width="2032" alt="Screen Shot 2019-05-06 at 17 54 50" src="https://user-"</detailsVS Code version: Code 1.33.1 (, 2019-04-11T08:22:55.268Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ project-manager10.5.1 solargraph0.19.6 bracket-pair-colorizer1.0.61 vscode-eslint1.8.2 es7-react-js-snippets2.2.2 gitlens9.7.1 prettier-vscode1.9.0 rails-snippets1.0.8 rest-client0.21.2 vscode-codemetrics1.18.0 vscode-language-babel0.0.22 ruby-rubocop0.8.0 sublime-keybindings4.0.0 debugger-for-chrome4.11.3 JavaScriptSnippets0.2.0 ruby0.22.3 code-settings-sync3.2.9 change-case1.0.0 JavaScriptSnippets1.7.2 </details<!-- generated by issue reporter --
, I would like to try this , Some starter and code pointers would be helpful :)
It depends on how got this notification. can you please let us know how you got this?
It shouldn't depend on that. I got it by clicking install button in VS Code Extension Marketplace website, in the browser.
This notification comes from here -
, I checked the code but just wanted to discuss on one thing .

Is that notification needed in the first place , clicking on install button on top will do the same job , Also removing that notification will keep the two scenarios consistent and same (Normally opening that extension page and opening the extension page from browser) We can remove the notification prompt to fix the inconsistency .
, were you able to look into this ? I can remove the notification bubble and send a PR, please confirm :)
Yeah it look unnecessary for me. Please remove it.
Change:
import { getTelemetryLevel } from 'vs/platform/telemetry/common/telemetryUtils'; import { AssignmentFilterProvider, ASSIGNMENT_REFETCH_INTERVAL, ASSIGNMENT_STORAGE_KEY, IAssignmentService, TargetPopulation } from 'vs/platform/assignment/common/assignment'; import { importAMDNodeModule } from 'vs/amdX'; <ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </ins> export abstract class BaseAssignmentService implements IAssignmentService { _serviceBrand: undefined;

Discussion:
We have learnt (the hard way) that when running extension/integration tests that EXP is enabled. This means some build (and user) machines might behave different to how they run locally. Also, it seems wasteful to contact the service when running tests
Change:
} findGroup(scope: IFindGroupScope, source?: IEditorGroupView | GroupIdentifier, wrap?: boolean): IEditorGroupView | undefined { <ins> if (scope.location === GroupLocation.FIRST || scope.location === GroupLocation.LAST) { // TODO implement support for all scopes with multiple editor parts // https://github.com/microsoft/vscode/issues/198651 return scope.location === GroupLocation.FIRST ? this.groups[0] : this.groups[this.groups.length - 1]; } </ins> if (source) { return this.getPart(source).findGroup(scope, source, wrap); }

Discussion:
Type: <bBug</bFirst of all, thank you for adding floating editor windows! Super useful feature that has already improved my productivity using VS code. I'm experiencing a weird issue where I am unable to navigate to the first editor group (located in my original window) from a newly opened window. I am able to navigate to any other editor group, but just not the first one. Steps to repro: Open vs code window with two editor groups (this is the "original window") Open new vscode window From the new window, press ctrl + 1 () to try to go to the first editor group in the original window Observe that nothing happens (expected to change focus to first editor group in the original window) From the new window, press ctrl + 2 () and observe that you can change focus to the second editor group as expected Current workaround if I want to change focus to the first editor group from the new window is I do ctrl + 2 to go to the second editor group, and then I can press ctrl + 1 to focus on the first editor group. If I'm in the original window I have no issue switching between the first and any other editor group in that window VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-17T10:49:40.914Z) OS version: Windows_NT x64 10.0. Modes: Remote OS version: Linux x64 5.15.0-1026-aws <details<summaryExtensions (13)</summaryExtensionVersion ------ remote-containers0.324.0 remote-ssh0.107.0 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 remote-explorer0.4.1 remote-server1.5.0 vim1.27.0 copilot1.137.556 copilot-chat0.11. autopep82023.9. python2023.20.0 vscode-pylance2023.11.10 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks, good catch. Fixing this case is relatively easy, but there are other navigational commands across editor groups that will need special care for when multiple windows are opened:
Change:
validationMessage: string | undefined; inputHasFocus(): boolean; <ins> focusOnInput(): void; </ins> } export interface IInputBox extends IQuickInput {

Discussion:
We have a temporary fix for the release for but we need to do something better long term.
while working on quick access for tasks I noticed that we seem to be having 2 pickers for the same thing (?): Task quick open: ! "Run Task" picker: ! Is that intentional? Should the one be merged into the other?
Yes, they do not share much code :( as part of improving the quick pick I will converge them.
sounds good, please only change  and leave the other one because I plan to delete those old ones soon.
Change:
config.wordWrap = 'off'; config.scrollbar.vertical = 'hidden'; config.ariaLabel = ariaLabel || ''; <ins> config.renderIndentGuides = false; </ins> config.cursorWidth = 1; config.snippetSuggestions = 'none'; config.suggest = { filterGraceful: false };

Discussion:
Tested in Windows with Insiders for 8/1 Add a couple of spaces in the extension search box Move focus to any of the open editors Come back to the extension search box and enter a letter !
Change:
* This will trigger the view to update the changed element/root and its children recursively (if shown). * To signal that root has changed, do not pass any argument or pass `undefined` or `null`. */ <del> onDidChangeTreeData?: Event<T | undefined | null>; </del> <ins> onDidChangeTreeData?: Event<T | undefined | null | void>; </ins> /** * Get [TreeItem](#TreeItem) representation of the `element`

Discussion:
Issue Type: <bBug</bWith the change from , the data fired from an event emitter is no longer optional. For extensions using the API, firing an emitter for without any arguments is now a compilation error. We should add to the type list here. VS Code version: Code - Insiders 1.45.0-insider (, 2020-05-04T09:21:17.770Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --
Hi, has this been implemented? I am on VSCode 1.45.1 and I still get this error when trying to compile. !
Yes, but the EventEmitter still needs to be defined with type ,
Change:
import { createWaitMarkerFileSync } from 'vs/platform/environment/node/wait'; import { PipeCommand } from 'vs/workbench/api/node/extHostCLIServer'; import { hasStdinWithoutTty, getStdinFilePath, readFromStdin } from 'vs/platform/environment/node/stdin'; <ins> import { DeferredPromise } from 'vs/base/common/async'; </ins> /* * Implements a standalone CLI app that opens VS Code from a remote terminal.

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (WSL depends on some dependencies) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0 OS Version: Windows 11 23H2 Steps to Reproduce: In a WSL shell run . does not return until the editor tab is closed again. This is no longer intended behaviour since was solved. In PowerShell on the Windows host, the command does work as intended, when running .
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified with VSCode 1.89.0 stable
Change:
this._instanceId = TerminalInstance._instanceIdCounter++; this.hasHadInput = false; this._titleReadyPromise = new Promise<string>(c => { this._titleReadyComplete = c; });

Discussion:
We should adopt An easy fix is to just fallback when this happens, we need to make sure we don't save suggested renderer type if the webgl renderer is good though.
Can you add verification steps?
To verify: Context loss is achieved at a diff't limit for each computer. Using VS code stable - create as many terminals as needed to trigger context loss. When you reach that state, you'll see ! Now in Insider's, create the same number of terminals. You shouldn't see any of those context loss images.
very nice, I like how the fallback magically works
Change:
resultTextModel, diffComputer, { <del> resetResult: false </del> <ins> resetResult: options.resetResult || false </ins> }, new MergeEditorTelemetry(NullTelemetryService), ));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: WindowsNT x64 10.0. Steps to Reproduce: a struct with some fields and functions in one branch the same struct in another branch, with a minor difference in one of the fields. the branches and open the merge editor. Accept Combination. On this example, is on the left side and on the right side. I'd expect "Accept Combination" to have only a single copy for the matching lines, and duplicate only the different line (and then I'd choose which one to keep), but it duplicates the entire struct. !
I also see that deleted/deleted is considered a conflict. I see no reason why. !
I also had duplicated code on two occasions when rebasing after the new VSCode update (and that's why I searched for this issue here). It seems that it kept the old code and the new code and didn't complain or considered a change/conflict. I still haven't used , so this duplication happened without using this new feature. In both situations, I had to manually remove the old code. If I find this situation again I will add here its screenshots.
Thanks,
Thank you!
Verification steps: Use the command to open that JSON and notice that conflicts with equal changes on both sides are auto-resolved.
Change:
*  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> export function equals<T>(one: ReadonlyArray<T>, other: ReadonlyArray<T>, itemEquals: (a: T, b: T) => boolean = (a, b) => a === b): boolean { if (one.length !== other.length) { return false; } for (let i = 0, len = one.length; i < len; i++) { if (!itemEquals(one[i], other[i])) { return false; } } </del> <ins> export const empty = Object.freeze([]); </ins> <del> return true; </del> <ins> export function equals<T>( a: ReadonlyArray<T>, b: ReadonlyArray<T>, itemEquals: (a: T, b: T) => boolean = (a, b) => a === b ): boolean { if (a === b) { return true; } if (a.length !== b.length) { return false; } return a.every((x, i) => itemEquals(x, b[i])); </ins> } export function flatten<T>(arr: ReadonlyArray<T>[]): T[] { <del> return ([] as T[]).concat.apply([], arr); </del> <ins> return Array.prototype.concat.apply([], arr); </ins> }  No newline at end of file

Discussion:
! Open Put the cursor on a tslint warning Get a lightbulb with quick fix suggestions, but it blinks Seems to be related to cursor blink I think this is a regression from 1.34 but can't be sure because it doesn't happen totally consistently.
Repos for me in that specific file around line 90. Weird Looks like something is causing loops of refactoring requests
Looks like a real js/ts bug but not a regression. Too risky to fix this iteration as it involves scheduling and how we manage errors for TypeScript
The cause: Code requests diagnostics (it doesn't matter why, but it has to happen in a state where there is a pending request against the TSServer for the current file) our js/ts refactoring provider, we tell TS server to cancel its current work computing diagnostics (because we want to service the code actions request as soon as possible) we cancel the current request to the tsserver, trigger a new request, and then reschedules a new request with the current file in it refactor response is returned so we show the lightbulb then we get back part of the geterr response (but not the full response). This partial response updates diagnostics in the current file after a short delay (even if they have not changed) diagnostic change cause VS code to request code actions again while we still have pending diagnostics for the current file to step 1 I don't understand why this doesn't happen all the time
Change:
resolved "https://registry.yarnpkg.com/jsonc-parser/-/jsonc-parser-2.3.1.tgz#59549150b133f2efacca48fe9ce1ec0659af2342" integrity sha512-H8jvkz1O50L3dMZCsLqiuB2tA7muqbSg1AtGEkN0leAqGjsUzDJir3Zwr02BhqdcITPg3ei3mZ+HjMocAknhhg== <del> vscode-emmet-helper@2.2.4-2: version "2.2.4-2" resolved "https://registry.yarnpkg.com/vscode-emmet-helper/-/vscode-emmet-helper-2.2.4-2.tgz#8019188077a91dbe9a8d8c10c0b79369bb5c24d6" integrity sha512-7UTZXwt9M1xwaV72o2YgSBVoghtDtscTgYTOl1kiPkXN9OKiM4N52hcHFA1LlRtdTvIQd4PEkgaz57F9ZT/4kg== </del> <ins> vscode-emmet-helper@2.2.4: version "2.2.4" resolved "https://registry.yarnpkg.com/vscode-emmet-helper/-/vscode-emmet-helper-2.2.4.tgz#8ab86d2b7fe9e6270b4c77c9fd8d1eb8f3f4c401" integrity sha512-1N6bMzP1ZzkDGzamvsKxQ/lOmBc4+OQdj0dA2C9A5PSeYV9gh5xbJ061sm+VyFHOGZE+VyUQq5m/WFmFsLbKnA== </ins> dependencies: emmet "https://github.com/rzhao271/emmet.git#1b2df677d8925ef5ea6da9df8845968403979a0a" jsonc-parser "^2.3.0"

Discussion:
Issue Type: <bBug</bSince the latest update, I am seeing really weird Emmet suggestions in SASS files (not SCSS) with a higher priority than my SASS suggestions. For example I have got used to writing with . But now if I hit tab with it will give me rather than the expected like it used to. ! VS Code version: Code 1.53.0 (, 2021-02-03T16:01:04.046Z) OS version: Darwin x64 19.4.0 <details<summaryExtensions (15)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 project-manager12.0.1 save-as-snippet0.0.1 vscode-icontheme-nomo-dark1.3.6 glsl-canvas0.2.11 vs-code-xml-format0.1.5 discord-vscode4.1.0 vscode-peacock3.9.1 vsliveshare1.0.3629 vsliveshare-audio0.1.91 vsliveshare-pack0.4.0 vscode-extension-auto-import1.4.3 shader1.1.4 sass-indented1.8.15 better-align1.1.6 </details<!-- generated by issue reporter --
The current Emmet snippet for background-color is . definitely shouldn't be suggested, though. I also confirmed that I'm only able to reproduce the issue with SASS files. Also, I just realized the other suggestions that show up aren't part of Emmet. However, I don't see the other suggestions (such as background-color) when I try typing in into a SASS file, even though I do see them on CSS and SCSS files. Wondering if I have a setting misconfigured.
Verifier: First, install the extension for SASS support. Then, set up a .sass document with the following content: Within the braces, type . Confirm that there is no suggestion of the form Edit: just realized SASS documents don't need braces. Least it helped with verification.