jiebi/CodeConvo huggingface dataset:
Change:
}, "scope": "resource" }, <ins> "css.completion.triggerPropertyValueCompletion": { "type": "boolean", "scope": "resource", "default": true, "description": "%css.completion.triggerPropertyValueCompletion.desc%" }, </ins> "css.validate": { "type": "boolean", "scope": "resource",

Discussion:
I can't find how to disable CSS property value autocomplete, I'm using these settings: it works perfectly in JavaScript, TypeScript, etc. But in CSS if I press tab I will get full autocomplete of property and then value. How I can disable autocomplete of value and keep only autocomplete of property? Gif below shows the issue. ! As you can see it autocompleted almost perfectly except it automatically opened suggestion for value which I don't need since I want to go through all based suggestions with and I even in settings which CSS should respect. In my opinion, if is it should autocomplete only with and then you can go through properties by pressing and then you add which results to you can write a single letter and go through suggestions again with . So to summarize it should autocomplete with only and do not show suggestion list of values for that prop.
How does that work? Can't you use arrow keys to select prev/next item?
No, only or . I proposed this suggestion , if any member of your team agrees on that proposal, then this can be closed, because I really miss suggestions list, but it's too noisy and distracting. Since there are a really small group of devs who disable suggestions and uses only tab to autocomplete, also in CSS, chances this will be re-created by someone else is very very small.
The problem is: He want to use tab/S-tab to go prev/next Some CSS completion items and trap the tab/S-tab Do you think we should add the setting?
Maybe I can help somehow to make this happen?
Sure, a PR that adds a new setting is welcome.
So this is related to ?
Sure, thanks! Here are some pointers: Dev setup is here: Add a boolean setting to toggle this behavior on/off Here's the logic for re-triggering value completion after property completion: Update the test suite
Thank you!
Change:
@IConfigurationService private readonly configurationService: IConfigurationService, @IContextKeyService contextKeyService: IContextKeyService, @IEditorService private readonly editorService: IEditorService, <del> @IKeybindingService private readonly keybindingService: IKeybindingService </del> <ins> @IKeybindingService private readonly keybindingService: IKeybindingService, @IAccessibilityService private readonly accessibilityService: IAccessibilityService </ins> ) { this._commentInfos = []; this._commentWidgets = [];

Discussion:
cc something we should do as a result of discussion with
i think we should use or to indicate this when going to next range since this info is otherwise just strictly visual.
so the idea is the following: command go to next/previous commenting range : "Commenting range lines 4-10" And: on a comment widget : "Comment on lines 3-7" or "Comment on line 3"
I think the latter works well enough already. It's the former that I think we need. !
Actually, I wonder if the precise line number is important. Given a user isn't told what line number they're on when they move their cursor, perhaps instead we could say "spans 4 lines". Since a user has invoked this command, they know that it's a comment range, so we probably want to leave out "comment/commentable" to decrease noise
IMO, the line reference could be useful when users want to backtrace later.
shall we leave out the term 'Comment' here and just say 'lines 730-736' to reduce verbosity?
Or "Lines 1 to 5 can be commented on" as a screen reader user can disrupt it mid message via escape?
I am leaning toward just "Lines 1 to 5" given the user invoked the command so knows it's a comment range already.
Thanks for making the change!
open an editor that has some commentable ranges. Turn on a screen reader. use the command jump to next /previous commenting range. verify you hear the range like "lines 123 to 128" as the cursor's position gets updated.
nothing is being announced for me with that command, I have screen reader optimized and commenting verbosity on
depending on what you have going on otherwise, it will wait to say that since we're using instead of here.
are you seeing it jump to the commenting ranges?
works on my desktop, does not work on my surface laptop - neither the speech viewer nor through volume, nothing is read at all when running that command by NVDA. It is successfully navigating between commentable regions.
sounds like you've verified this works on your desktop. I'm curious to know if other aria alerts are working on your surface laptop - for example, in the chat input, accept a slash command completion. press backspace -you should hear that the state was cleared.
Change:
const searchInProgress = this.searchInProgress = new CancellationTokenSource(); return this.localSearchDelayer.trigger(async () => { if (searchInProgress && !searchInProgress.token.isCancellationRequested) { <del> const progressRunner = this.editorProgressService.show(true); </del> const result = await this.localFilterPreferences(query); if (result && !result.exactMatch) { this.remoteSearchThrottle.trigger(async () => { if (searchInProgress && !searchInProgress.token.isCancellationRequested) { <del> await this.remoteSearchPreferences(query, this.searchInProgress!.token); </del> <ins> await this.remoteSearchPreferences(query, this.searchInProgress?.token); </ins> } <del> progressRunner.done(); </del> }); <del> } else { progressRunner.done(); </del> } } });

Discussion:
I don't have precise repro steps, but maybe: search for something scroll all the way down clear search searching animation persists
I'm unable to repro the issue. Let me know if there's any devtools errors next time it occurs.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
just reproduced this and will give us the logs
In the case of JooYoung, the search wasn't performed at all.
just reproduced myself
The error likely means there's an array that's undefined, but I'll probably have to reproduce the issue on OSS to actually see what's going on Example REPL run
it takes much longer than expected to stop - is there a long happening for input change or... ?
I'm unable to repro on the latest Insiders on Windows or macOS. For me, clearing the search stops it immediately.
Change:
this.context.controller.onClick(this.context.tree, item.model.getElement(), event); } <ins> private onMouseMiddleClick(e: MouseEvent): void { if (!this.context.controller.onMouseMiddleClick) { return; } var event = new Mouse.StandardMouseEvent(e); var item = this.getItemAround(event.target); if (!item) { return; } this.context.controller.onMouseMiddleClick(this.context.tree, item.model.getElement(), event); } </ins> private onMouseDown(e: MouseEvent): void { this.didJustPressContextMenuKey = false;

Discussion:
VSCode Version: Version: 1.27.1 (user setup) Commit: Date: 2018-09-06T09:21:18.328Z Electron: 2.0.7 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 Architecture: x64 OS Version: Windows 10 Pro 64-bit (10.0, Build ) Steps to Reproduce: click item in explorer icon appear ! If you open developers tools works as expected Does this issue occur when all extensions are disabled?: Yes/No Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.478 --- <!-- score: 0.463 --<!-- potentialduplicatescomment --
Hmm strangely I am no longer getting a event when I do a middle mouse click This nicely works in stable. I see we use a different electron 2.0.9 compared to 2.0.7 but not sure if that update includes something which would influence this. Also the middle click nicely works in the tabs title area - how are you handling it there? did we change something in the tree which might effect this?
yeah see I removed  to prepare for Electron 3.0.x. We should probably wire this into the tree so that people can react to it ("onMiddleClick"). Simply forwarding the was resulting in other issues.
ok so the tree should still listen on events but bobble them up in a different way ? I can create a PR for this and you review?
yeah, the thing is, middle-click should not trigger the click, otherwise we might get wrong behaviour where people do not expect middle-click to do anything. Instead we can check clients of the tree (and list?) that want to do something on middle click and update them accordingly. Otherwise every client has to do an extra check for which mouse button was used for click.
currently the only clients of the tree that check something on middle click are explorer and quick open . For the list they are open editors view and the breakpoints view, however this still works for the breakpoints view and does not work for the open editors due to
Change:
private _lastHoverHideTime: number = 0; readonly showHover = (options: IHoverDelegateOptions) => { <del> options.hoverPosition = HoverPosition.ABOVE; </del> <ins> options.position = options.position ?? {}; options.position.hoverPosition = HoverPosition.ABOVE; </ins> return hoverService.showHover(options); };

Discussion:
Type: <bBug</bTooltip position changed VSCode insiders and also see the right pointer is also missing Insiders release ! Stable release ! VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-24T15:21:39.004Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ ng-template17.0.2 multi-cursor-case-preserve1.0.5 codeium1.4.20 codium0.7.19 svg-gallery2.1.0 console-log0.6.2 gitlens2023.11.2404 vscode-test-explorer2.21.1 angular2-switcher0.4.0 vscode-jest-test-adapter0.8.1 template-string-converter0.6.1 test-adapter-converter0.1.8 gitpatch0.2.1 material-icon-theme4.32.0 pretty-ts-errors0.5.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Assuming this could be a bug in Hover infrastructure. Please let me know if it is otherwise.
Change:
} await this.repository.rebaseContinue(); <del> await this.commitOperationCleanup(message, opts); </del> <ins> await this.commitOperationCleanup(message, indexResources, workingGroupResources); </ins> }, () => this.commitOperationGetOptimisticResourceGroups(opts)); } else {

Discussion:
Type: <bBug</bI have the setting: "Git: Close Diff On Operation" enabled. Staging a change will close the diff. Committing a staged change will close the diff. But if I just click the Commit button, the changes will commit but the diff won't close. Reproduction steps: & save a file the file in "Source Control" to open a diff Commit Expected behavior: The "(Working Tree)" tab closes Actual behavior: It stays open VS Code version: Code 1.77.3 (Universal) (, 2023-04-12T09:19:37.325Z) OS version: Darwin x64 22.4.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ tailwind-documentation0.1.6 ng-template15.2.1 tailwind-docs2.0.0 docs-view0.0.11 vscode-tailwindcss0.9.11 language-postcss1.1.0 vscode-deno3.17.0 vscode-axe-linter4.7.0 nasc-touchbar1.12.0 copilot1.84.51 vscode-test-explorer2.21.1 tasks-statusbar0.1.0 git-graph1.30.0 dotenv1.0.1 csharp1.25.4 test-adapter-converter0.1.7 vsliveshare1.0.5864 vscode-yaml1.12.2 snyk-vulnerability-scanner1.18.2 code-spell-checker2.20.4 vscode-todo-highlight1.0.5 pretty-ts-errors0.4.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
} .panel > .title .monaco-action-bar .action-item.repl-panel-filter-container { <del> min-width: 200px; </del> <ins> min-width: 300px; </ins> margin-right: 10px; } <ins> .repl-panel-filter-container .repl-panel-filter-controls { position: absolute; top: 0px; bottom: 0; right: 0px; display: flex; align-items: center; } .repl-panel-filter-container .repl-panel-filter-controls > .repl-panel-filter-badge { margin: 4px; padding: 0px 8px; border-radius: 2px; } .repl-panel-filter-container .repl-panel-filter-controls > .repl-panel-filter-badge.hidden { display: none; } </ins>

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
} } <ins> private adjustHoverMaxHeight(target: TargetRect): void { let maxHeight = window.innerHeight / 2; // When force position is enabled, restrict max height if (this._forcePosition) { const padding = (this._hoverPointer ? Constants.PointerSize : 0) + Constants.HoverBorderWidth; if (this._hoverPosition === HoverPosition.ABOVE) { maxHeight = Math.min(maxHeight, target.top - padding); } else if (this._hoverPosition === HoverPosition.BELOW) { maxHeight = Math.min(maxHeight, window.innerHeight - target.bottom - padding); } } // Make sure not to accidentally enlarge the hover when setting a maxHeight for it maxHeight = Math.min(maxHeight, this._hover.containerDomNode.clientHeight); this._hover.containerDomNode.style.maxHeight = `${maxHeight}px`; } </ins> private setHoverPointerPosition(target: TargetRect): void { if (!this._hoverPointer) { return;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: MacOS Monterey 12.5, chrome v 104.0.5112.101 Steps to Reproduce: language specific setting e.g. for a large number of languages Settings Editor, Check and hover on to show the hover view. Expected: All the overridden languages are visible and overflowing content can be scrolled to. Actual: The hover view is clipped at the screen height and not all languages are visible unless zooming out. !
this is working now, but there is some room for improvement as it does not use the maximum available space and sometimes has weird behavior with the beak. See below where the hovered text is just below the top of the widget which has a beak pointing down. <img width="272" alt="image" src="https://user-"
Change:
for (const item of items) { if (this._contextKeyService.contextMatchesRules(item.when)) { const isMenuItem = isIMenuItem(item); <ins> if (isMenuItem) { this._hiddenStates.setDefaultState(this._id, item.command.id, !!item.isHiddenByDefault); } </ins> const menuHide = createMenuHide(this._id, isMenuItem ? item.command : item, this._hiddenStates); if (isMenuItem) { // MenuItemAction

Discussion:
Type: <bBug</bIn the most recent insiders, opening the command palette seems to take around a second: ! There is also a large delay when filtering VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-11T16:46:25.875Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
All the little calls at the bottom of the chart are to Possibly caused by
Confirmed that this does seem caused by In main right now, it is slow but not as painfully slow: ! After a revert though it becomes very fast: !
Change:
const linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|([^s()]*?))+)s*(".*?")?)/g; /** <ins> * Matches `[text](<link>)` */ const linkPatternAngle = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*<)(([^<>]|([^s()]*?))+)>s*(".*?")?)/g; /** </ins> * Matches `[text][ref]` or `[shorthand]` */ const referenceLinkPattern = /(^|[^]])(?:(?:([((?:]|[^]])+)][s*?)([^s]]*?)]|[s*?([^s]]*?)])(?![:(]))/gm;

Discussion:
Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.61.2 OS Version: macOS Big Sur Steps to Reproduce: a new markdown file. ! But according to it isn't necessary to escape spaces when the text is enclosed in :
Removing help wanted since this is a bit more complicated than anticipated
Thanks!
Change:
MenuId.SCMOutgoingChangesHistoryItemContext; } <del> result = this.menuService.createMenu(menuId, this.contextKeyService); </del> <ins> const contextKeyService = this.contextKeyService.createOverlay([ ['scmHistoryItemFileCount', historyItem.statistics?.files ?? 0], ]); result = this.menuService.createMenu(menuId, contextKeyService); </ins> this.historyItemMenus.set(historyItem, result); }

Discussion:
Testing an empty commit Notice the action still appears even though it's a no-op. We should either hide it (preferable) or disable it. <img width="568" alt="image" src=""
Change:
import { commonPrefixLength } from 'vs/base/common/strings'; import { CharCode } from 'vs/base/common/charCode'; import { VSBuffer } from 'vs/base/common/buffer'; <ins> import { IExtHostConsumerFileSystem } from 'vs/workbench/api/common/extHostFileSystemConsumer'; </ins> class FsLinkProvider {

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
const position = this.getWindowPosition(this._issueParentWindow, 700, 800); this._issueWindow = new BrowserWindow({ <ins> fullscreen: false, </ins> width: position.width, height: position.height, minWidth: 300,

Discussion:
macOS run in fullscreen mode open the process explorer the prices explorer window also opens in fullscreen mode...
Hi Gonna take a look at this. It seems to be happening for 'Report issue' also.
Hi Can I help you somehow to get this merged?
Yep! Sorry for the delay, your change looks good. I'll merge it now. Thanks!
Change:
"input.border": "#ffffff17", "input.foreground": "#ffffffc5", "input.placeholderForeground": "#ffffff79", <ins> "inputOption.activeBackground": "#2489db82", "inputOption.activeBorder": "#2488db", </ins> "keybindingLabel.foreground": "#ffffffc5", "list.activeSelectionBackground": "#ffffff0f", "list.activeSelectionIconForeground": "#ffffff",

Discussion:
Notice how the is supposed to draw a border over an active checked toggle, for example find widget. The default colors all use a opacity of it seems from the change in I do not understand the intent, but with that opacity I see the color not being applied at all. Here is how the color compares today vs. how it was intended to be when I remove the trailing : <img width="541" alt="image" src="https://user-"<img width="527" alt="image" src="https://user-"
Actually found this from the feedback widget where the selected sentiment does not indicate anymore: <img width="328" alt="image" src="https://user-"vs <img width="347" alt="image" src="https://user-"
Change:
return undefined; } <del> const resource = joinPath(parentResource, entry.name); // Confirm overwrite as needed if (target && target.getChild(entry.name)) { const { confirmed } = await this.dialogService.confirm(getFileOverwriteConfirm(resource.path)); if (!confirmed) { return undefined; } } if (token.isCancellationRequested) { return undefined; } </del> // Report progress let totalBytesUploaded = 0; const reportProgress = (fileSize: number, bytesUploaded: number): void => {

Discussion:
Refs: have a folder with a few files drag and drop into web file explorer drag and drop the folder again Observe: Multiple dialogs appear that ask whether to replace the existing files/folder: first for the folder then for the individual files From this behaviour I assume that the drag and drop is not a "replace" but a "merge". This is confirmed by adding another file into the original folder and then dnd it again. Or empty the original folder and then dnd it only asks for the folder but leaves the existing containing files alone. But this "Merge" semantics needs a completely different UI than "Replace": it is not necessary to ask for replacing the folder because there will be more questions for the individual files inside anyways. the dialog needs three buttons: "replace", "do not replace", and "cancel" Alternatively you could implement the "Replace" logic. In this case there is no need to ask for the individual files inside a folder if the whole folder is replaced anyway. A third option is to ask initially whether to "Replace" or to "Merge" and then have different UI for the two strategies.
Will check how the explorer does this, we may behave the same already for native drops.
The simplest solution is to implement the "Replace" strategy. That's what macOS Finder does. IIRC Windows implements the "Merge" strategy.
Yes this is also how our non web explorer behaves. So we will show a dialog for each conflict. We do not allow to bulk cancel. Since this can be handled in the Explorer, unassigning from and renaming I am opening this up for PRs. Code pointer
via the solution is to ask for each thing that gets uploaded and then delete it upfront. This means, when you are being asked to replace a folder, you will not be asked for each file within. It will be a "Replace" and not "Merge".
Change:
this.label = undefined; this.options = undefined; <del> this.lastKnownConfiguredLangId = undefined; </del> <ins> this.lastKnownDetectedModeId = undefined; </ins> this.computedIconClasses = undefined; this.computedPathLabel = undefined; }

Discussion:
Issue Type: <bBug</bto something like . a new tab. The tab should have the Markdown icon, but it has the Plain Text icon. If you move to another tab then back, the icon will be updated. This only started happening when I updated to 1.3, and it's still happening in Insiders. I've got no extensions or settings (other than ) set. VS Code version: Code - Insiders 1.31.0-insider (, 2018-12-21T06:14:53.023Z) OS version: Darwin x64 18.2.0 <!-- generated by issue reporter --
This is a consequence of adopting : When the tab opens we immediately render the icon, but the resource only gets the mode associated after a on the end of the tick.
via