jiebi/CodeConvo huggingface dataset:
Change:
} export interface IGrammar { <del> language: string; </del> <ins> language?: string; </ins> } export interface IJSONValidation {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 89.1 x64 OS Version: Edition Windows 11 Pro Version 23H2 Installed on ‎2023-‎11-‎28 OS build .3593 Experience Windows Feature Experience Pack 1000..1003.0 Steps to Reproduce: the VS Code the introduction page of buildin plugin the FEATURES page 's Empty
I am seeing following !
Yes, I see the same. There should be details about supported languages like other built-in plugins.
Can you point me to the place I need to fix this?
Here it is
Change:
readonly id: ExtensionIdentifier; } <ins> export interface IDataLinkClickEvent { dataURL: string; downloadName?: string; } </ins> export interface Webview extends IDisposable { html: string; contentOptions: WebviewContentOptions;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Python Notebook implementation has special code to handle click events of links containing an ObjectUrl (href=blob:....). I'm hoping VS Code would handle this natively as these links allow users to save blobs as files. This is generic enough that it need not be something special to the Python implementation. Would benefit anyone using the new VSC API to display HTML that allows saving images. Current Python Notebook implementation: We handle all click events in document If target element === and starts with . Then we get the blob contents and send it to extension On extension side we prompt user to save the file using . /cc
what is the use case for this?
Sure, a user could render a plotly plot and such plots can contain links to save images, and those hrefs have a ref to object urls. This isn't specific to Python extension, any HTML could have markup that allows users to save images . Also, opening such a plot in other notebook viewer, user is able to click such links and save the images. If this isn't address, then VSCode displays an empty page in notebook with an error message (see below). I think this is due to the fact that href results in nativigating the current page to url=blob://. & again, we can address this with a custom renderer, however I believe this is generic enough for VSC to handle. ! !
TIL about the API. Should this also work for URLs?
Good pick. I would say yes. At the end of the day someone could render a link with a download attribute
To do this for blob ULIs, I have to download the contents of the URL in the context of the webview, and pipe it back to vscode to write to a file. Data URLs are easier, I can just open it in a browser. Maybe an experience in vscode would be nicer though. Where are these urls coming from in your case, some 3rd party renderer code or your extension code?
3rd party That's exactly what we have in our python extension when using the webview.

I thought this would be generic enough for VSCode to handle, as others could end up with similar scenarios, at the end of the day it's from a 3rd party package.
Yeah, I think it makes sense for us to handle this as well.
Do you have an example of a notebook that has this button? Is this from ipywidgets?
Also can you link me to the code that handles this in your extension?
No, its plot generated by plotly. Here's the code required to generate such a plot:
I thought this was working on Wednesday, but now I get a CORS error when I fetch any blob URL from the webview code. Did you do anything to handle this? I don't understand why it's working in your webview and not mine. Maybe we are making webview changes right now that might affect this.
U might have to setup the csp (for data and blobs), this here's what we have:
Change:
if (options.originalAriaLabel) { result.ariaLabel = options.originalAriaLabel; } <ins> result.ariaLabel += ariaNavigationTip; </ins> result.readOnly = !this._options.originalEditable; result.dropIntoEditor = { enabled: !result.readOnly }; result.extraEditorClassName = 'original-in-monaco-diff-editor';

Discussion:
Diff editor is not accessible unless the user uses the F7 / Shift + F7 experience. We should make this more discoverable to the users. For example the aria label of a diff editor should at the end append "use F7 / shift + F7 to navigate changes" fyi
assigning to you and removing the milestone since this might be a good win and something that is within our reach. Namely the diff editor is not that accessible unless users use the experience to navigate between changes. So we should make this more discoverable by potentially mentioning it in the aria label of the diff editor.
Verify that when you are using a screen reader and enter a diff editor, you're informed about using shift + F7 navigation
Change:
protocol: attributes?.get(tunnel.tunnelRemotePort)?.protocol ?? TunnelProtocol.Http, localUri: await this.makeLocalUri(tunnel.localAddress, attributes?.get(tunnel.tunnelRemotePort)), localPort: tunnel.tunnelLocalPort, <ins> name: attributes?.get(tunnel.tunnelRemotePort)?.label, </ins> runningProcess: matchingCandidate?.detail, hasRunningProcess: !!matchingCandidate, pid: matchingCandidate?.pid,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: stable and from sources OS Version: Steps to Reproduce: Forward a port using port label from settings is not applied
Change:
readonly label: string = ''; readonly tooltip: string = ''; <del> readonly class: string = ''; </del> <ins> readonly class: string = 'separator'; </ins> readonly enabled: boolean = false; readonly checked: boolean = false; async run() { }

Discussion:
Type: <bBug</bLight+ on Insiders ! Light+ on Stable ! Dark+ on Insiders: ! Dark+ on Stable: ! VS Code version: Code - Insiders 1.72.0-insider (, 2022-09-23T15:06:00.185Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
regression from
Change:
) ); // TODO@jrieken make this proper: add menu id and allow extensions to contribute const toolbarMenu = this._menuService.createMenu(MenuId.MergeToolbar, this._contextKeyService); const toolbarMenuDisposables = new DisposableStore();

Discussion:
It was weird when I toggled word wrap in the merge editor yet only the editor I was focused on had it toggled. I kind of expected all editors to have it toggled. My rationale is that toggling word wrap is usually a symptom of having long lines and the chances that all three editors have long lines is high if a single editor has long lines.
I agree. Until recently word wrap only toggled one side of the diff editor. See
Change:
this.shouldShowViewsContext = EDIT_SESSIONS_SHOW_VIEW.bindTo(this.contextKeyService); this._register(this.fileService.registerProvider(EditSessionsFileSystemProvider.SCHEMA, new EditSessionsFileSystemProvider(this.editSessionsStorageService))); <del> this.lifecycleService.onWillShutdown((e) => e.join(this.autoStoreEditSession(), { id: 'autoStoreWorkingChanges', label: localize('autoStoreWorkingChanges', 'Storing current working changes...') })); </del> <ins> this.lifecycleService.onWillShutdown((e) => { if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown' && !isWeb) { e.join(this.autoStoreEditSession(), { id: 'autoStoreWorkingChanges', label: localize('autoStoreWorkingChanges', 'Storing current working changes...') }); } }); </ins> this._register(this.editSessionsStorageService.onDidSignIn(() => this.updateAccountsMenuBadge())); this._register(this.editSessionsStorageService.onDidSignOut(() => this.updateAccountsMenuBadge())); }

Discussion:
Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width="955" alt="image" src="https://user-"
In web we probably cannot support the value.
This is still on
I cannot reproduce this, just to be sure this is on the latest
Yes, reproduces even with caches disabled: !
Change:
} public async $OnDidEndTask(execution: tasks.ITaskExecutionDTO): Promise<void> { <ins> if (!this._taskExecutionPromises.has(execution.id)) { // Event already fired by the main thread // See https://github.com/microsoft/vscode/commit/aaf73920aeae171096d205efb2c58804a32b6846 return; } </ins> const _execution = await this.getTaskExecution(execution); this._taskExecutionPromises.delete(execution.id); this._taskExecutions.delete(execution.id);

Discussion:
Type: <bBug</bclone repro from and open project folder run the repro extension from vscode open two folders in the workspace (these will not be touched by the repro code, the problem was encounterd in multi-folder workspace and this just reproduces that environment) run command after some time popup with error will appear Expected beahvior: the loop running the dummy task will keep running indefinitely This seems to be caused by using in combination with changes of the workspace folders. When the loop in the repro is changed to only keep writing the file and running the tasks the problem never appears VS Code version: Code - Insiders 1.82.0-insider (, 2023-09-01T11:05:38.381Z) OS version: Linux x64 4.19.0-18-amd64 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (0)</summaryExtensionVersion ------ </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I'm not seeing the task you said to run in that folder !
The repro steps say to run command , not a task. The command runs the task itself via the API. Here is the command in the command pallette ! And here is the error it produces ! Please try the repro steps again and let me know if you still can't see what I show in the screenshots
I get this error, which is interesting because the workspace contains two folders. !
From the screenshot it seems like you have one workspace folder containing two file system folders - that still means the workspace is a single root workspace You need to have a multi-root workspace by calling I hope the terminology I use is correct, it is taken from this doc
PR fixing it
Change:
} // if we are here, the cell is a code cell. <del> // check next cell, if markdown, that means this is the end of the section const nextCell = this.notebookEditor.cellAt(i + 1); if (nextCell) { if (nextCell.cellKind === CellKind.Markup) { </del> <ins> // check next visible cell, if markdown, that means this is the end of the section const nextVisibleCell = this.notebookEditor.cellAt(i + 1); if (nextVisibleCell && i + 1 < visibleRange.end) { if (nextVisibleCell.cellKind === CellKind.Markup) { </ins> // this is the end of the section // store the bottom scroll position of this cell sectionBottom = this.notebookCellList.getCellViewScrollBottom(cell);

Discussion:
Tested on Windows 11. Yep, I also found it confusing as to when a sticky header would appear. Scrolling through in the testing repo, I had to scroll several times past before it would appear in the sticky scroll UI. I would have expected the header to be displayed right after it scrolled out the top of the view port. I also saw that headers higher in the hierarchy such as would disappear and reappear. Shouldn't the H2s remain as the H3s change? Originally posted by in
Somewhat related to visible range issues and multiple md cells with headers in a row.
Change:
tags, } = data; <ins> if (unsupportedSchemas.has(resource.scheme)) { return undefined; } </ins> if (!message) { return undefined; }

Discussion:
Testing <img width="1617" alt="image" src="https://user-"
I can't get squiggles to show up for the commit input box at all, even after following the steps from the linked TPI. What are some steps to verify this, or maybe someone else can verify?
Thanks Reopening the bug as the fix for this has introduced a regression.
Checked in a better fix for this issue. Should be included in tomorrow's Insiders release (2022-08-26).
closedWith
Verified, but the actions in the hover don't do anything: !
Thanks I have filed to track the issue with the actions.
Change:
import { fetchSelectItem } from './selectItem'; import { evaluateMathExpression } from './evaluateMathExpression'; import { incrementDecrement } from './incrementDecrement'; <del> import { LANGUAGE_MODES, getMappingForIncludedLanguages, updateEmmetExtensionsPath, getPathBaseName, getSyntaxes, getEmmetMode } from './util'; </del> <ins> import { LANGUAGE_MODES, getMappingForIncludedLanguages, updateEmmetExtensionsPath, migrateEmmetExtensionsPath, getPathBaseName, getSyntaxes, getEmmetMode } from './util'; </ins> import { reflectCssValue } from './reflectCssValue'; import { addFileToParseCache, removeFileFromParseCache } from './parseDocument'; export function activateEmmetExtension(context: vscode.ExtensionContext) { <ins> migrateEmmetExtensionsPath(); </ins> registerCompletionProviders(context); updateEmmetExtensionsPath();

Discussion:
Testing Bug Currently the setting can only be configured by editing the file. It would be nice if you could configure it using our settings UI as well
It'd make sense to me to deprecate the string/null potential values in favor of an array of strings. You could declare the settings as (which settings editor can handle, see ), then transform existing 's to the empty array and existing single string values to .
Change:
executeResult.promise.then(summary => { this._lastTask = this._currentTask; }); <del> if (InMemoryTask.is(task) || !this._isTaskEmpty(task)) { if (!this._instances[recentTaskKey]) { this._instances[recentTaskKey] = new InstanceManager(); } this._instances[recentTaskKey].addInstance(); } </del> return executeResult; } catch (error) { if (error instanceof TaskError) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 and older and (with slightly different behavior) insiders as of 5/4/2023 OS Version: MacOS 13.3.1 (a) Steps to Reproduce: Use these commands to produce and launch a suitable project: First bug: in either 1.78.0 or the nightly, use to launch , then hit Cmd-Shift-B to launch . You end up with two copies of running, when it should have an implicit of 1. Hit Cmd-Shift-B again, and it will tell you you've hit the instance limit. The problem here is that dependent tasks don't count towards the instance limit. Second bug: Now add to , and repeat the above. There is no change in the nightly (as you might expect), but surprisingly 1.78.0 now reports that it can't start a second copy. But thats just a bug; if you change it to and repeat, 1.78.0, still tells you it can't launch a second copy. This bug was fixed by , so I'm just including it for completeness. Third bug: Add to . Now hit Cmd-Shift-B to launch , then use to launch . will (correctly) re-use the already running task, rather than launching a new one. Now kill all the terminals (to make the next step less confusing). Hit Cmd-Shift-B to launch sleeper, wait 5 seconds, and hit Cmd-Shift-B again, wait another 5 seconds for the first task to finish, and then run .

Now, although the second task is still running, starts a new one. The issue here is that when looking for an existing dependent task, uses the task's , which only matches the first instance of a task with greater than 1 (and here, that task has already finished).
Change:
this.userHome = remoteEnv.userHome.path; this.os = remoteEnv.os; <del> const activeWorkspaceRootUri = this._historyService.getLastActiveWorkspaceRoot(); </del> // this is a copy of what the merged environment collection is on the remote side <del> await this._setupEnvVariableInfo(activeWorkspaceRootUri, shellLaunchConfig); </del> <ins> await this._setupEnvVariableInfo(variableResolver, shellLaunchConfig); </ins> const shouldPersist = !shellLaunchConfig.isFeatureTerminal && this._configHelper.config.enablePersistentSessions; if (shellLaunchConfig.attachPersistentProcess) {

Discussion:
With we are trying to remove from the configuration resolver service. The new way to get the environment is async and requires that the all the configuration resolver methods be async. I have started the adoption of the new async methods in , but there's one use in terminal that looks like it will require more work: Option 1: Convert that use of to use . Option 2: I provide a new method on the configuration resolver service that is sync, but requires you to pass in your own . Which option makes the most sense here?
I think the usage of in must remain sync since it's used as part of the extension API. Is this a problem there since is fine to use? The main purpose of this type was to share code between variable processes.
Sounds like Option 2 is the way to go then. I will add a new method that is sync and lets you pass in your own .
Added: will that let you keep your code reuse?
Change:
const span = DOM.append(this._outputEmptyElement, DOM.$('span')); span.innerText = 'No outputs to render'; <del> if (this.cell.original!.outputs.length === 0) { </del> <ins> if (!this.cell.original?.outputs.length) { </ins> this._outputEmptyElement.style.display = 'block'; } else { this._outputEmptyElement.style.display = 'none';

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --If outputs are cleared from a jupyter notebook, attempting to view a diff in source control view displays the error in the subject. Search for related issues brings up a different issue related to filesystem sync. VS Code version: 1.80.1 Jupyter Extension version (available under the Extensions sidebar): v2023.6. Python Extension version (available under the Extensions sidebar): v2023.12.0 OS (Windows Linux distro) and version: Windows 11 Python and/or Anaconda version: 3.9.16 Type of virtual environment used (N/A ...): conda Jupyter server running: Local Display the diff, don't display an error, even if outputs are undefined in a version of the diff. Error is displayed and the diff can't be viewed. Open a notebook in jupyter server (not VS Code) Click Cell -All Output -Clear Save the notebook Go to VS Code -Source Control View -click on the notebook. <details<summaryOutput for <codeJupyter</codein the <codeOutput</codepanel (<codeView</code→<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codeJupyter</code) </summary<p</p</details
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
the editor opens successfully, though it does not show the change unless you click the switch output rendering button !
Tracked here
Change:
} private async autoStoreEditSession() { <del> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown') { </del> <ins> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown' && !isWeb) { </ins> const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window,

Discussion:
Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width="955" alt="image" src="https://user-"
In web we probably cannot support the value.
This is still on
I cannot reproduce this, just to be sure this is on the latest
Yes, reproduces even with caches disabled: !
Change:
import { Schemas } from 'vs/base/common/network'; import { INativeEnvironmentService } from 'vs/platform/environment/node/environmentService'; import { rimraf } from 'vs/base/node/pfs'; <ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </ins> export class ExtensionsLifecycle extends Disposable { private processesLimiter: Limiter<void> = new Limiter(5); // Run max 5 processes in parallel constructor( <del> private environmentService: INativeEnvironmentService, private logService: ILogService </del> <ins> @IEnvironmentService private environmentService: INativeEnvironmentService, @ILogService private readonly logService: ILogService </ins> ) { super(); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.46.0 OS Version: Windows 10/macOS Catalina 10.15.4 VS Code 1.46 no longer executes the Attached test extension (rename file extension to .vsix) which creates a file on uninstall in the user's home directory. Using VS Code 1.45.1 the file is created on both Windows and macOS. Using VS Code 1.46 no file is created. Steps to Reproduce: attached extension extension VS Code VS Code again file is created <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: This is an extension management problem