jiebi/CodeConvo huggingface dataset:
Change:
electron: string; chrome: string; } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Issue Type: <bBug</bThe first Mac native tab has its top row cut off: ! The second one has the statusbar below the visible window: ! Resizing the window is a workaround. VS Code version: Code - Insiders 1.38.0-insider (, 2019-08-15T05:23:00.986Z) OS version: Darwin x64 18.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ unique-lines1.0.0 ssh0.0.4 ghlink1.1.0 remotehub0.5.0 EditorConfig0.13.0 tslint1.0.44 git-project-manager1.7.1 rest-client0.22.0 solidity0.0.58 theme-karyfoundation-themes18.2.1 graphql-for-vscode1.15.1 vscode-docker0.7.0 remote-containers0.67.4 remote-ssh-edit-nightly2019.8. remote-ssh-explorer-nightly2019.8. remote-ssh-nightly2019.8. azure-account0.8.4 azurecli0.4.6 github-issues-prs0.9.1 debugger-for-chrome4.11.7 vetur0.22.1 vscode-versionlens0.24.0 vscode-yaml0.4.1 vscode-workspacecontains-canary0.0.2 vscode-open-in-github1.12.0 ayu0.18.0 vscodeintellicode1.1.9 </details<!-- generated by issue reporter --
does this reproduce when you disable grid layout?
Yes, it's the same with grid layout disabled.
I cannot reproduce using Electron 4.2.7
!
Fix is up at , should be available with next electron release.
we will take the new build and will push it via a PR.
Change:
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-markdown * { margin: 0px; } <ins> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-markdown *:not(:last-child) { margin-bottom: 8px; } </ins> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .edit-in-settings-button { opacity: 0.9;

Discussion:
Type: <bBug</bPython installed settings and look at the setting Bug The setting description is hard to read because there is no space between the paragraph elements and code blocks ! VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-25T05:23:34.922Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
import { IPartService } from 'vs/workbench/services/part/common/partService'; import { alert } from 'vs/base/browser/ui/aria/aria'; import { coalesce } from 'vs/base/common/arrays'; <ins> import { IWorkbenchThemeService } from 'vs/workbench/services/themes/common/workbenchThemeService'; </ins> function toExtensionDescription(local: ILocalExtension): IExtensionDescription { return {

Discussion:
Improve user experience while installing themes
!
It would be cool if you could preview themes in the store, maybe with a split view hosting some example code, or even with the files you have open.
Please open a feature request for it
Change:
viewStates[handle] = { visible: input === group.activeEditor, active: input === activeInput, <del> position: editorGroupToViewColumn(this._editorGroupService, group.id || 0), </del> <ins> position: editorGroupToViewColumn(this._editorGroupService, group.id), </ins> }; } }

Discussion:
VSCode Version: 1.37.1 OS Version: Fedora 30 I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE). I noticed that if I start the CSS-LS without passing a element to initialization, the LS will fail because of . One of the important lines in the stack trace is .
Submitted PR for this issue.
Fixed by .
Verified in master by removing the dataPaths
Change:
return extHostLanguageFeatures.registerCompletionItemProvider(extension, checkSelector(selector), provider, triggerCharacters); }, registerInlineCompletionItemProvider(selector: vscode.DocumentSelector, provider: vscode.InlineCompletionItemProvider): vscode.Disposable { <del> checkProposedApiEnabled(extension, 'inlineCompletions'); </del> if (provider.handleDidShowCompletionItem) { checkProposedApiEnabled(extension, 'inlineCompletionsAdditions'); }

Discussion:
(edited by We use this issue to track the progress of the Inline Completions API. The currently proposed API can be found in . There is a sample extension . Before this API can be finalized, we need to figure out these items at least: [x] How can inline completions interact with completions? (Currently, inline completions are hidden when autocomplete shows up and if there is an inline completion, autocomplete does not show up automatically)
why is this proposal not still open? Normally for proposals, we keep them open until the api is finalized and shipped. So that users/extension authors can track the proposal more easily.
Trying to copy and get 404. Is this link dead? This makes the sample in vscode: useless as well. Can you please help?
They have an updated way to get the file. First you have to change the to in the file. Then run to download the latest version of and then run . See more (if the link doesn't scroll down to the "updated api proposal structure" you have to control f it).
Hi folks! Is the API still likely to be released in April as mentioned in ?
it is currently assigned to April and that is our plan. It might slip to May depending on how testing and feedback from Extensions that use this proposed API goes. I suggest to follow this issue for more details. Thanks!
Hello! While trying out the sample package (). I receive the following errors. I also attempted the method you specified and the methods mentioned in the readme. In addition, I also tried the following npm commands: Npm install Npm run postinstall Is this sample still up to date?
good catch. I have tackled the outdated extension via this PR Once we get it approved I will merge it in and then the sample should be up to date. Thanks
Looks like this is on mainline? Any idea when it will be released beyond insiders?
this is assigned to the May milestone. Which means it is part of our May release which usually gets shipped first 10 days of the following month. So this one should be available on Thursday.
amazing! Thanks so much for getting back to me, I'll be deving accordingly :)
I have opened this discussion for any follow up questions since we have done the finalization
Change:
item.tooltip = item.label ? `${item.label} - ${element.item.detail}` : element.item.detail; item.contextValue = 'call-item'; item.iconPath = getThemeIcon(element.item.kind); <ins> type OpenArgs = [vscode.Uri, vscode.TextDocumentShowOptions]; let openArgs: OpenArgs; if (element.model.direction === CallsDirection.Outgoing) { openArgs = [element.item.uri, { selection: element.item.selectionRange.with({ end: element.item.selectionRange.start }) }]; } else { // incoming call -> reveal first call instead of caller let firstLoctionStart: vscode.Position | undefined; if (element.locations) { for (const loc of element.locations) { if (loc.uri.toString() === element.item.uri.toString()) { firstLoctionStart = firstLoctionStart?.isBefore(loc.range.start) ? firstLoctionStart : loc.range.start; } } } if (!firstLoctionStart) { firstLoctionStart = element.item.selectionRange.start; } openArgs = [element.item.uri, { selection: new vscode.Range(firstLoctionStart, firstLoctionStart) }]; } </ins> item.command = { command: 'vscode.open', title: vscode.l10n.t('Open Call'), <del> arguments: [ element.item.uri, <vscode.TextDocumentShowOptions>{ selection: element.item.selectionRange.with({ end: element.item.selectionRange.start }) } ] </del> <ins> arguments: openArgs </ins> }; item.collapsibleState = vscode.TreeItemCollapsibleState.Collapsed; return item;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No, because feature isn't available without TS extension. I don't know which language has this feature with extensions disabled. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.2 OS Version: WIN Steps to Reproduce: some TS code call hierarchy (outgoing calls) an item the place of the call (source) is revealed call hierarchy for the originally peeked word an item the definition of the call (target) is revealed It is easy to get lost when using both, and not clear in the API documentation which one to provide in an extension.
When there are cross-document links, preferences view shows clicked items' document correctly either if I provide source or target uri. However peek view tries to show the provided range in the parent document of the selected item if I provide the source uri. Double-clicking an item opens the correct document. Based on this it might be a bug that peek shows the range in parent document. Is there any restriction whether a provider should provide source or target Uris?
Hi should be already fixed? Has it been released yet? Thanks :)
Change:
import 'vs/workbench/parts/git/browser/gitViewlet'; // can be packaged separately import 'vs/workbench/parts/debug/electron-browser/debug.contribution'; <ins> import 'vs/workbench/parts/debug/browser/debugQuickOpen'; </ins> import 'vs/workbench/parts/debug/electron-browser/repl'; import 'vs/workbench/parts/debug/browser/debugEditorActions'; import 'vs/workbench/parts/debug/browser/debugViewlet'; // can be packaged separately

Discussion:
Testing Version 1.10.0-insider Commit Date 2017-02-22T07:09:05.746Z Linux In the VSCode workspace, open VSCode on the 'extensions/html' folder. press Ctrl + E, type: debug with space at the end an empty dialog shows up click the dialog away error message shows up: Unable to instantiate quick open handler vs/workbench/parts/debug/browser/debugQuickOpen - QuickOpenHandler: {"errorCode":"load","moduleId":"vs/workbench/parts/debug/browser/debugQuickOpen","neededBy":["===anonymous10==="],"detail":{"errno":-2,"code":"ENOENT","syscall":"open","path":"/usr/share/code-"}}
! !
This has been fixed and awaiting pull request review before merge in.
Change:
@IQuickInputService private readonly _quickInputService: IQuickInputService, @IWorkspaceContextService private readonly _workspaceContextService: IWorkspaceContextService, @ISearchService private readonly _searchService: ISearchService, <del> @IEditorService private readonly _editorService: IEditorService </del> <ins> @IEditorService private readonly _editorService: IEditorService, @IFileService private readonly _fileService: IFileService, @IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService </ins> ) { super(); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: "Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)
+1
duplicate of
Can we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.
Can reproduce the problem, it should say folder not file: ! !
Repros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:
So the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !
let's wait until is back for that. I'm considering this verified for now
Problem is back, looks a little different though: !
I think the new problem is Windows only
Change:
} else { that.excludedExtensions.add(e.identifier.id.toLowerCase()); } <del> } </del> <ins> }, tooltip: localize('exclude', "Select {0} Extension", e.displayName || e.identifier.id) </ins> } : undefined, command: { id: 'extension.open',

Discussion:
Type: <bBug</bcc: Steps to reproduce: VSCode press ctrl+shift+p, choose 'profiles: show content' and press the enter key. navigating the displayed screen using the tab and shift+tab keys. In my environment, every time I press tab or shift+tab, orca just reads something like checked check box. Orca cannot inform what is associated with the checkbox. The problem also happens in version 1.76. VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-15T05:21:59.212Z) OS version: Linux x64 6.1.15-200.fc37.x8664 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (39)</summaryExtensionVersion ------ doxdocgen1.4.0 vscode-markdownlint0.49.0 vscode-chatgpt3.9.5 rest-client0.25.1 better-cpp-syntax1.17.2 azure-pipelines1.208.0 vscode-docker1.24.0 csharp1.25.4 vscode-dotnet-runtime1.6.0 vscode-kubernetes-tools1.3.11 remote-containers0.284.0 remote-ssh0.99. remote-ssh-edit0.84.0 azure-account0.11.3 cmake-tools1.13.45 cpptools1.14.4 cpptools-extension-pack1.3.0 makefile-tools0.6.0 powershell-preview2023.3.0 remote-explorer0.3. vsliveshare1.0.5834 oracledevtools21.5.0 fabric8-analytics0.3.6 java1.16. vscode-xml0.25. vscode-yaml1.12.1 sonarlint-vscode3.15.1 cmake0.0.17 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-boot-dev-pack0.2.1 vscode-spring-boot1.45.0 vscode-java-debug0.49. vscode-java-dependency0.21. vscode-java-pack0.25. vscode-java-test0.38. vscode-maven0.40.

vscode-spring-boot-dashboard0.11.1 vscode-spring-initializr0.11.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
great catch! And thanks for trying out profiles! we should invest into making sure the profile import flow is accessible. It might be as easy as adding aria-labels. We can also sit down together for this.
Tree uses up and down arrows for navigation and I am using the custom tree view underneath. I also see the same behaviour in the PR view. So I assume this has to be fixed in the custom tree view.
is this in ? The checkbox has a that you can set. You can set the and then that should be read by screen readers. The checkbox is still proposed extension API, so before we finalize we would need to also add an aria label:
It turned out perfect, great job. I would like to add two small suggestions that I think would improve accessibility. could be moved to the first field on the page once the page is displayed. Currently, you have to press the tab key a few times to find the beginning of the page. could also have shortcut keys associated with the close and export buttons.
thanks! Could you create a new issue with these suggestions please :)
Change:
import { Emitter, Event } from 'vs/base/common/event'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; import { isWeb } from 'vs/base/common/platform'; <ins> import { isDefined } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import * as nls from 'vs/nls'; import {

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log
Change:
import * as dom from 'vs/base/browser/dom'; import { Action, IAction, Separator } from 'vs/base/common/actions'; import { CancellationToken } from 'vs/base/common/cancellation'; <ins> import { generateUuid } from 'vs/base/common/uuid'; </ins> import { IActiveCodeEditor, ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; import { Range } from 'vs/editor/common/core/range';

Discussion:
I'm trying to navigate to here from an Inlay Hint, but nothing happens when I click the "Go to Definition" option: ! The LSP traffic for this hint looks like this: The looks correct to me (Code is zero-based, so it says 1195 here but the line is 1196 in the editor): <img width="743" alt="Screenshot 2023-02-21 at 11 16 08" src="https://user-"The text for says: But it's not very clear to me what this means. The location provide here definitely has a symbol defined at the location, which can be navigated to from the breadcrumb/symbol list: <img width="778" alt="Screenshot 2023-02-21 at 11 21 55" src="https://user-"
So, when invoking go to definition at you get the desired result?
I believe so. The request returns the same symbol, so VS code then falls back to request and shows references (I believe there's a setting for this, and it's intended functionality, so you can just use F12 on a declaration to get references easily?).
Please try with column and not with
Sorry, not sure how I did that. But the result appears to be exactly the same:
Oh, I just did some more testing and it seems like the request VS Code is sending is using the current cursor position and not where I clicked? !
I can reproduce, funnily only from the context menu but not from the link gesture.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Works great now, thanks ! /verified
Change:
}).then(undefined, onUnexpectedError); } <del> private getPreviewValue(textEditorModel: ITextModel, startLineNumber: number) { let rangeToUse = this.getPreviewRangeBasedOnBrackets(textEditorModel, startLineNumber); </del> <ins> private getPreviewValue(textEditorModel: ITextModel, startLineNumber: number, result: LocationLink) { let rangeToUse = result.targetSelectionRange ? result.range : this.getPreviewRangeBasedOnBrackets(textEditorModel, startLineNumber); </ins> const numberOfLinesInRange = rangeToUse.endLineNumber - rangeToUse.startLineNumber; if (numberOfLinesInRange >= GotoDefinitionWithMouseEditorContribution.MAX_SOURCE_PREVIEW_LINES) { rangeToUse = this.getPreviewRangeBasedOnIndentation(textEditorModel, startLineNumber);

Discussion:
Issue Type: <bBug</bGitHub Pull Request extension repo Hover on Press CMD key ! Ideally we should be able to implementation of at the top and definition at the bottom, but :( VS Code version: Code - Insiders 1.34.0-insider (, 2019-04-09T05:14:40.620Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (50)</summaryExtensionVersion ------ vscode-apollo1.5.2 markdown-emoji0.0.7 solargraph0.19.6 npm-intellisense1.3.0 vscode-svgviewer2.0.0 vscode-markdownlint0.26.0 vscode-eslint1.8.2 xml2.4.0 gitlens9.6.0 remotehub0.2.0 tsl-problem-matcher0.0.4 EditorConfig0.13.0 tslint1.0.43 vscode-npm-script0.3.5 vsc-material-theme2.8.2 prettier-vscode1.8.1 flow-for-vscode1.1.1 vscode-pull-request-github-insiders1.98.0 ocaml0.6.43 beautify1.4.11 references-plusplus0.0.5 graphql-for-vscode1.13.0 dotenv1.0.1 theme-monokai-pro-vscode1.1.12 vscode-azurefunctions0.16.0 vscode-language-pack-zh-hans1.33.2 python2019.3.6558 azure-account0.8.1 cpptools0.22.1 Go0.9.2 powershell1.12.0 vscode-typescript-tslint-plugin1.0.0 wordcount0.1.0 vsliveshare1.0.18 debugger-for-chrome4.11.3 debugger-for-ios-web0.1.2 vetur0.18.1 subtitles-editor1.0.2 vscode-versionlens0.22.0 material-icon-theme3.7.0 seti-icons0.1.3 ruby0.22.3 smartpaste0.0.3 toggle0.0.1 vscode-fuzzsymbols0.0.1 sass-indented1.5.1 rust0.6.1 sourcekit-lsp0.0.

1 vscode-lldb1.2.2 vscode-intelli-nav0.0.6 (12 theme extensions excluded) </details<!-- generated by issue reporter --
adding since I believe the implementation peak when holding CMD is determined by VS Code
Yeah, today we count matching bracket (up to a low maximum of lines) to compute the preview. not sure if TypeScript provides  but that would certainly help here
Ok, we do set the but it is just the range of the identifier (). I've opened to track having this information returned from TypeScript
Planning to do work to support API proposed by in June. We would not actually ship this until TS 3.6 however
To verify, please make sure you are using TS 3.6 in your workspace and follow original instructions in the github PR extension's codebase
Change:
}, activationEventsGenerator: (languageContributions, result) => { for (const languageContribution of languageContributions) { <del> if (languageContribution.id) { </del> <ins> if (languageContribution.id && languageContribution.configuration) { </ins> result.push(`onLanguage:${languageContribution.id}`); } }

Discussion:
Bug The the following entry in its : This seems to cause the python extension to be activated whenever a json file is opened, even though the extension does not provide any json language support This was possibly caused by the move to automatic activation events
I think my initial implementation of implicit activation was perhaps too naive. There seem to be a few issues: It's possible to have a language configuration extension that doesn't contribute any code, and we would now attempt to activate such an extension (this is a noop if there is no main/browser entrypoint in , but results in unnecessary activation if all that's required is a language configuration) the bigger issue is that an extension which contributes extensions, filenames, filenamePatterns, firstLine, or mimeTypes for a language will now get activated anytime the language appears I think it's maybe reasonable to preserve the existing implicit activation behavior if an alias is defined for all of the others, we shouldn't infer , or we should perhaps keep track of the filenames/filenamePatterns etc and activate the extension with the language contribution matching the specified pattern? I know of at least two extensions which are impacted by the current behavior MakeCode Python
:+1: This makes good sense to me. We will infer only for the one which is the "main" language definition, and the best evidence of that is the alias property. I wouldn't do anything beyond that (i.e. tracking filenames, patterns, etc.)
Would the presence of the property be better evidence of a contribution being the main language definition?
injection based syntax highlighting can still have a configuration file