jiebi/CodeConvo huggingface dataset:
Change:
@IThemeService private readonly _themeService: IThemeService, @IWorkbenchLayoutService private readonly _layoutService: IWorkbenchLayoutService, @IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService, <del> @IEditorGroupsService editorGroupsService: IEditorGroupsService, </del> @IConfigurationService private readonly _configService: IConfigurationService, <del> @ISplashStorageService private readonly _partSplashService: ISplashStorageService </del> <ins> @ISplashStorageService private readonly _partSplashService: ISplashStorageService, @IEditorGroupsService editorGroupsService: IEditorGroupsService, @ILifecycleService lifecycleService: ILifecycleService, </ins> ) { Event.once(_layoutService.onDidLayoutMainContainer)(() => { this._removePartsSplash(); perf.mark('code/didRemovePartsSplash'); }, undefined, this._disposables); <del> let lastIdleSchedule: IDisposable | undefined; Event.any(onDidChangeFullscreen, editorGroupsService.mainPart.onDidLayout, _themeService.onDidColorThemeChange)(() => { lastIdleSchedule?.dispose(); lastIdleSchedule = dom.runWhenWindowIdle(mainWindow, () => this._savePartsSplash(), 800); }, undefined, this._disposables); </del> <ins> const lastIdleSchedule = this._disposables.add(new MutableDisposable()); const savePartsSplashSoon = () => { lastIdleSchedule.value = dom.runWhenWindowIdle(mainWindow, () => this._savePartsSplash(), 2500); }; lifecycleService.when(LifecyclePhase.Restored).then(() => { Event.any(onDidChangeFullscreen, editorGroupsService.mainPart.onDidLayout, _themeService.onDidColorThemeChange)(savePartsSplashSoon, undefined, this._disposables); savePartsSplashSoon(); }); </ins> _configService.onDidChangeConfiguration(e => { if (e.affectsConfiguration('window.titleBarStyle')) {

Discussion:
I noticed that saving parts splash occurs during startup, even though delayed: ! I am not sure we need that, maybe we can put that on the phase. The following profile: was taken on Windows with a non-minified / non-mangled build to aid reading has the event at
Moved it out a bit further but the overall timing is a lottery because it depends on the current state (destruction) of the dom and how long measuring will take
Change:
function removeEmbeddedSVGs(documentContent: string): string { return insane(documentContent, { <ins> allowedTags: [ 'h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'h7', 'h8', 'br', 'b', 'i', 'strong', 'em', 'a', 'pre', 'code', 'img', 'tt', 'div', 'ins', 'del', 'sup', 'sub', 'p', 'ol', 'ul', 'table', 'thead', 'tbody', 'tfoot', 'blockquote', 'dl', 'dt', 'dd', 'kbd', 'q', 'samp', 'var', 'hr', 'ruby', 'rt', 'rp', 'li', 'tr', 'td', 'th', 's', 'strike', 'summary', 'details', 'caption', 'figure', 'figcaption', 'abbr', 'bdo', 'cite', 'dfn', 'mark', 'small', 'span', 'time', 'wbr' ], allowedAttributes: { '*': [ 'align', ] }, </ins> filter(token: { tag: string, attrs: { readonly [key: string]: string } }): boolean { return token.tag !== 'svg'; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: macOS Big Sur (Version ) Steps to Reproduce: an extension from the Extensions view. For example, this is what the extension README looks like: <img width="1277" alt="Debugger for Chrome README" src="https://user-"The README for this extension specifies for the image and the heading, however, that is not reflected when displaying the README in the Extensions panel. Does this issue occur when all extensions are disabled?: Yes
Fixed by
closedWith
/verified
The issue has been fixed, but there's another issue related to extension READMEs not correctly displaying HTML content. When an img tag specifies the attribute, it seems like that attribute is ignored and the true width of the image is used. Here's an example: <img width="1193" alt="Screen Shot 2021-02-27 at 2 07 49 PM" src="https://user-"The attribute of the image is 200, however the real width of the image is larger, and it seems that the real width is used rather than the attribute. Any help on this issue would be great!
We'll consider allowing specific attributes on a case-by–case basis. If you want to see width and heigh also supported (and they already work in the marketplace) please open a new issue
New issue opened:
Change:
const query = queryBuilder.file(folders, { _reason: 'checkExists', includePattern: includes.join(', '), <ins> expandPatterns: true, </ins> exists: true });

Discussion:
Use this code in an extension, run the command In 1.31, it returns no results because takes a single glob pattern In 1.32, it returns results because the include and exclude patterns for are split on the comma
This is a candidate because it would be an API change. If we want to support multiple glob patterns we should use an array like we discussed in Parsing a comma-delimited string in this API feels wrong.

1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the ´Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for
Would be fixed by .
Change:
const activeEditorGroup = this.editorGroupService.activeGroup; const sideEditorGroup = this.editorGroupService.addGroup(activeEditorGroup.id, GroupDirection.RIGHT); await Promise.all([ <del> this.editorService.openEditor({ resource: this.defaultKeybindingsResource, options: { pinned: true, preserveFocus: true, revealIfOpened: true }, label: nls.localize('defaultKeybindings', "Default Keybindings"), description: '' }), </del> <ins> this.editorService.openEditor({ resource: this.defaultKeybindingsResource, options: { pinned: true, preserveFocus: true, revealIfOpened: true, override: EditorOverride.DISABLED }, label: nls.localize('defaultKeybindings', "Default Keybindings"), description: '' }), </ins> this.editorService.openEditor({ resource: editableKeybindings, options }, sideEditorGroup.id) ]); } else {

Discussion:
Steps to Reproduce: workbench editor associations to open *.json with a custom editor (e.g. HEX) to change this setting later = you cannot because in order to edit the values, you need to go to the JSON but it will open the custom editor always: ! Imho we should have a way to prevent the override from happening fro built in files such as settings. Only workaround is to entirely reset the setting. //cc
I've made a PR to fix this issue. I'm not sure why it is showing so many changes, it might be due to it being based off of the openWith PR that we had open before it got merged.
Change:
constructor() { super({ id: CLEAR_ALL_CELLS_OUTPUTS_COMMAND_ID, <del> title: localize('clearAllCellsOutputs', 'Clear Outputs of All Cells'), </del> <ins> title: localize('clearAllCellsOutputs', 'Clear All Outputs'), </ins> precondition: NOTEBOOK_HAS_OUTPUTS, menu: [ {

Discussion:
I've noticed that the notebook toolbar has a lot of actions that can make it hard to scan. I also noticed that some actions appear to be disabled when not available (like the interrupt action). Here are some minor proposals. <img width="985" alt="CleanShot 2022-07-12 at 14 04 05 src="https://user-"<img width="987" alt="CleanShot 2022-07-12 at 14 05 11 src="https://user-""Clear Outputs of All Cells" to "Clear All Outputs" the "Interrupt" action when not available
both makes sense to me. "Clear All Outputs" is much easier to read. A disabled action on the toolbar is not great, since users can't really do anything about it. Not sure if we hide it or merge it with "Restart" (making it a dropdown like what we did for the Run button on cells)
Related to this is sticking to the principle of only showing actions when they are available instead of showing them as enabled/disabled
Change:
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae" integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w== <del> "@vscode/l10n@^0.0.13": version "0.0.13" resolved "https://registry.yarnpkg.com/@vscode/l10n/-/l10n-0.0.13.tgz#f51ff130b8c98f189476c5f812d214b8efb09590" integrity sha512-A3uY356uOU9nGa+TQIT/i3ziWUgJjVMUrGGXSrtRiTwklyCFjGVWIOHoEIHbJpiyhDkJd9kvIWUOfXK1IkK8XQ== </del> "@vscode/l10n@^0.0.14": version "0.0.14" resolved "https://registry.yarnpkg.com/@vscode/l10n/-/l10n-0.0.14.tgz#431e5814c35c3cb11ee21873bc70a4b0fbf90fcf"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.3 () OS Version: 10.0. Steps to Reproduce: the file the file containing a with a attribute and attempt to use URL autocompletion (as with the attribute of elements) to set its value to . The same issue occurs with a element (and there may be others I'm unaware of).
I don't see any smart suggestions, only word-based, when I type in here , is that how it's supposed to work?
Change:
* ------------------------------------------------------------------------------------------ */ 'use strict'; <del> import { env, languages, commands, workspace, window, Uri, ExtensionContext, Memento, IndentAction, Diagnostic, DiagnosticCollection, Range, DocumentFilter, Disposable } from 'vscode'; </del> <ins> import { env, languages, commands, workspace, window, Uri, ExtensionContext, Memento, IndentAction, Diagnostic, DiagnosticCollection, Range, DocumentFilter, Disposable, Position } from 'vscode'; </ins> // This must be the first statement otherwise modules might got loaded with // the wrong locale.

Discussion:
VSCode Version: Code 1.8.1 (, 2016-12-19T14:49:23.350Z) OS Version: Windows_NT ia32 10.0. Extensions: Steps to Reproduce: from npm with typings to import a relative path downwards( import Person from '../person' for instance ). The import will suggest "" as it includes a '.' character or something.
in general please include snippets and screenshots that illustrate the problem and provide precise steps with snippets, screenshots that illustrates a problem (see our ).
Sorry, i provided a video now, it includes full editor and you can see the structure there. The is standard, so is with saved and Steps to reproduce is: init install --init in a folder, () containing a class: in a subfolder () to import a relative path to File1. When you're going to type a relative step back (../), it will autocorrect to "" instead of ".." as shown in the video. If anything more is needed, please let me know. hope this make things a bit clearer
thanks for the additional info.
Short update, it does not seem to happen when running js. i thought it might due to the automatic type acquisition, but it works as intended, for me at least.
me too
this looks like an issue we've seen before...
Fix reverted ,
Picked up improved fix with
Change:
display: none; } <del> .monaco-workbench .part > .title > .title-actions .action-label.codicon { color: inherit; } </del> .monaco-workbench .part > .content { font-size: 13px; }

Discussion:
To reproduce: install GitLens setopen an editor ! Originally posted by in
is an example how to apply a color to an icon from URL
Sorry for sending back, but there are many things to report here and I feel that doing a one-off fix in editor toolbar is wrong and just a band aid. Inconsistencies It looks like is not applied consistently everywhere. Notice how the view toolbars do not change, while the editor toolbar does change (these 2 are essentially the same part toolbars): <img width="1008" alt="Screenshot 2023-08-22 at 11 10 35" src=""I think the underlying reason is this CSS rule: Missing Adoptions The editor header really just uses a standard and imho should not be responsible for making this color work for entries, rather the component should do that: You can see that the same issue applies to other toolbars, such as the view toolbars, which is not surprising. Code Duplication There seems to be code involved to make the color work for SVG icons, but that code is heavily duplicated and should be reused:
I don't think assigning this issue to me and David is useful. I'm not familiar with toolbars.
I hear about this issue quite often from extension authors. They want to either add the CSS vars to the SVG code itself and have it respond to themes, or just have us do it automatically.
its unlikely a thing to fix in toolbars but more a thing to fix where we allow icons from extensions to enter our world, because in the end we only use Codicons and nothing else. I believe this is happening from where menus are being created based on : Which I think is the place to add the mask, but might know better.
I can help to get this working with the MenuEntryActionItem things. Those are created for contributed commands/menus and we do support SVG via this path.
thanks for the mask trick <img width="1139" alt="Screenshot 2023-08-31 at 12 10 56" src=""
I just updated to 1.83.0 and found this update has broken the ability for versionlens to show if its enabled or disabled via its icon. With previous versions of vscode it showed as enabled ! in 1.83.0 when the icon is enabled it is now masked !

I understand that theming icons is preferable but how can we specify enableddisable state with theme styles? For instance the icon for showing diff whitespaces has the ability to be enabled or disabled ! How do we implement the same behaviour for extensions?
Change:
function accessSetting(config: any, path: string[]): any { let current = config; for (let i = 0; i < path.length; i++) { <del> current = current[path[i]]; if (typeof current === 'undefined' || current === null) { </del> <ins> if (typeof current !== 'object' || current === null) { </ins> return undefined; } <ins> current = current[path[i]]; </ins> } return <T>current; }

Discussion:
'null' is a valid value for a setting, but turns it into 'undefined'. have the following workspace settings:set a breakpoint in '' at the value is 'undefined' should indicate that the setting has not been set in the workspace (luckily it is not a valid configuration value as we only support valid JSON data types)
Same problem with the default and user value. It's always 'undefined' instead of 'null'. The bug is in
I created a PR with a
Change:
"default": true, "description": "%config.decorations.enabled%" }, <ins> "git.statusBarSync.enabled": { "type": "boolean", "default": true, "description": "%config.statusBarSync.enabled%" }, </ins> "git.promptToSaveFilesBeforeCommit": { "type": "boolean", "scope": "resource",

Discussion:
There doesn't appear to be an option to hide the git sync icon that appears in the status bar. It's not really a big deal but it would be nice to hide the git sync icon. Personally, coming from Vim I prefer working with the VCS outside of the editor, yet I would still like to see the current branch that is being worked on. This is why I'd like to hide just the sync button and not hide both git status bar items or disable the git extension entirely.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.561 --<!-- potentialduplicatescomment --
I believe this is resolved via
No, hard to revert that change.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Change:
searchValue = searchValue.trim(); const normalizedSearchValueLowercase = strings.stripWildcards(searchValue).toLowerCase(); <del> const terminalEntries = this.getTerminals(); </del> <ins> const terminalEntries: QuickOpenEntry[] = this.getTerminals(); terminalEntries.push(new CreateTerminal(nls.localize("'workbench.action.terminal.newplus", "$(plus) Create New Integrated Terminal"), this.terminalService)); </ins> const entries = terminalEntries.filter(e => { if (!searchValue) {

Discussion:
VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-04T17:43:56.658Z) OS Version: Darwin x64 16.7.0 After having used the terminal switcher for a few days, I realize that I'm always assuming that the keyboard focus moves when I change the active terminal, same what happens when using from the command pallet. As it doesn't I often end up doing the wrong thing, i.e. type shell commands in the open editor, etc. Steps to Reproduce: two terminals and one editor the keyboard focus in the editor to change the visible terminal typing -the editor content is being modified <!-- Launch with to check. --Reproduces without extensions: Yes
Change:
// // However, we never want to discard backups that we know // were not restored in the session. try { if (Array.isArray(arg1)) { await Promises.settled(arg1.map(workingCopy => this.workingCopyBackupService.discardBackup(workingCopy)));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: Windows_NT x64 10.0. Auto Save by onFocusChange does not sync internal cache when direct quitting by 'X' button. Steps to Reproduce: settings: "Files: Auto Save" =onFocusChange a text file and save it somewhere. the file a little more. But this time, do not save or change focus and just press 'X' button directly to quit. the text file again with vscode. to save the file. Now you can see this error message: "Failed to save '...': The content of the file is newer." <img width="341" alt="image" src="https://user-"
That is weird, we trigger auto save on shutdown unless auto save is turned off: Does this still reproduce in all projects?
Oh nice I can reproduce, looks really like a bug.
Great catch!
Thank you for your response and effort on this issue!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
} } <del> let result = ''; </del> let lineContent = this._model.getLineContent(position.lineNumber); let tokenText = ''; if (token1Index < data.tokens1.length) {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . It aims to replace construction of HTML elements by string concatenation in file. The code contains mainly a table construction by concatenating strings of . The goal is to replace them all with function calls.
Change:
import { CommentThreadRangeDecorator } from 'vs/workbench/contrib/comments/browser/commentThreadRangeDecorator'; import { ICursorSelectionChangedEvent } from 'vs/editor/common/cursorEvents'; import { CommentsPanel } from 'vs/workbench/contrib/comments/browser/commentsView'; <ins> import { status } from 'vs/base/browser/ui/aria/aria'; </ins> export const ID = 'editor.contrib.review';

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.49", </del> <ins> "xterm": "4.19.0-beta.52", </ins> "xterm-addon-search": "0.9.0-beta.37", "xterm-addon-serialize": "0.7.0-beta.12", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.36", <del> "xterm-headless": "4.19.0-beta.49", </del> <ins> "xterm-headless": "4.19.0-beta.52", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Issue Type: <bBug</bIn the regular MacOS terminal (outside Visual Studio Code), option+click will move the cursor to a given point in the text. This is nice for editing the middle of a long command line, or for moving around vim. However, when the MacOS Terminal is being run inside Visual Studio Code, when I option+click text, the cursor moves close to where I clicked, but it's off by about 3 characters. VS Code version: Code 1.63.2 (, 2021-12-15T09:38:17.605Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No Remote OS version: Linux x64 5.4.0-105-generic <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ remote-ssh0.70.0 python2022.4.1 vscode-pylance2022.4.2 references-view0.0.89 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Guessing this is related to padding on
Does not reproduce in the demo
VS Code uses padding but the demo doesn't, try adding to
shouldn't the padding be on the cursor layer? nvm made the change in the wrong
I think this rule is the problem but haven't looked into it: ! We recently moved the padding from to I think which would explain the regression