jiebi/CodeConvo huggingface dataset:
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { createWriteStream } from 'fs'; </del> import { tmpdir } from 'os'; <ins> import { Queue } from 'vs/base/common/async'; </ins> import { randomPath } from 'vs/base/common/extpath'; <ins> import { Promises } from 'vs/base/node/pfs'; </ins> import { resolveTerminalEncoding } from 'vs/base/node/terminalEncoding'; export function hasStdinWithoutTty() {

Discussion:
Issue Type: <bBug</bany command line run or pipe another process that runs indefinitely to that a window does not open and the command does not return. The file should open and update as new data is piped to the code cli command. This works on the Mac when you run but does not work on Windows. This is not a 1.67.0 regression VS Code version: Code 1.67.0 (, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --
This is probably related to the file watcher not recognizing changes to the file on Windows, have to debug why that is the case but might be a limitation of the single file watcher.
The underlying reason seems to be that writing to a file via stream API where the file handle is not closed does not trigger file events on Windows at least. Maybe as a workaround we have to use the less efficient method that opens a file handle each time and closes it.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I am still experiencing this issue on the version of insiders below. Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-24T06:32:08.615Z (13 hrs ago) Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
Here is how to verify: ensure you are on latest insiders from a terminal on Windows run verify output is updated
I tried on the latest insiders with that command and vscode-insiders still does not not open for me. If I run it hangs and never opens vscode-insiders If I run without the -t flag, it will open after the command completes.

Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-27T07:59:47.622Z (10 hrs ago) Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
This works for me on Windows 11 with both Powershell and , but may need further investigation
Change:
registerDebugToolBarItem(RESTART_SESSION_ID, RESTART_LABEL, 60, icons.debugRestart); registerDebugToolBarItem(STEP_BACK_ID, localize('stepBackDebug', "Step Back"), 50, icons.debugStepBack, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_DEBUG_STATE.isEqualTo('stopped')); registerDebugToolBarItem(REVERSE_CONTINUE_ID, localize('reverseContinue', "Reverse"), 55, icons.debugReverseContinue, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_DEBUG_STATE.isEqualTo('stopped')); <del> registerDebugToolBarItem(FOCUS_SESSION_ID, FOCUS_SESSION_LABEL, 100, Codicon.listTree, CONTEXT_MULTI_SESSION_DEBUG); </del> <ins> registerDebugToolBarItem(FOCUS_SESSION_ID, FOCUS_SESSION_LABEL, 100, Codicon.listTree, ContextKeyExpr.and(CONTEXT_MULTI_SESSION_DEBUG, CONTEXT_TOOLBAR_COMMAND_CENTER.negate())); </ins> MenuRegistry.appendMenuItem(MenuId.DebugToolBarStop, { group: 'navigation',

Discussion:
When there are multiple debug sessions, the dropdown action item shows in the debug toolbar here as a button that doesn't do anything. You can see it in the gif in We could just hide that item when this setting is set
I believe it focuses the Call Stack view but only when paused and when having the view active. Tho, I do agree that we shouldn't have it there to begin with.

Testing Followed the steps to turn on the debug toolbar with commandCenter options. However, when the debugging started, clicking the area around the directory name did not trigger 'search files'. (the blank space at the right side of 'vscode-python' in terms of the attached screenshot. I was able to trigger 'search files' only when pressing specifically on the directory name, in this case, 'vscode-python. ++ Nice feature by the way! <img width="983" alt="Screenshot 2023-09-26 at 10 42 11 AM" src=""<img width="512" alt="Screenshot 2023-09-26 at 11 02 46 AM" src=""
Change:
nls.localize('window.confirmBeforeClose.never', "Never explicitly ask for confirmation unless data loss is imminent.") ], 'default': isWeb && !isStandalone ? 'keyboardOnly' : 'never', // on by default in web, unless PWA <del> 'description': nls.localize('confirmBeforeCloseWeb', "Controls wether to show a confirmation dialog before closing the browser tab or window. Note that even if enabled, browsers may still decide to close a tab or window without confirmation and that this setting is only a hint that may not work in all cases."), </del> <ins> 'description': nls.localize('confirmBeforeCloseWeb', "Controls whether to show a confirmation dialog before closing the browser tab or window. Note that even if enabled, browsers may still decide to close a tab or window without confirmation and that this setting is only a hint that may not work in all cases."), </ins> 'scope': ConfigurationScope.APPLICATION, 'included': isWeb }

Discussion:
nls.localize() generally involves human visible output. Technically there are 2-3 arguments and the main human facing one is the second. The first argument is often treated as an "opaque" string, but in most systems, it's used to communicate to localizers, so, to some extent, there is value in not having misspellings there either. I can split out the identifiers if requested... Does this issue occur when all extensions are disabled?: Yes
can you provide me with more details about this. We use Transifex to translate our strings and the system contains both the value and the key.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
return; } <del> const stashFiles = await repository.showStash(stash.index); </del> <ins> const stashChanges = await repository.showStash(stash.index); </ins> <del> if (!stashFiles || stashFiles.length === 0) { </del> <ins> if (!stashChanges || stashChanges.length === 0) { </ins> return; } const title = `Git Stash #${stash.index}: ${stash.description}`; const multiDiffSourceUri = toGitUri(Uri.file(repository.root), `stash@{${stash.index}}`, { scheme: 'git-stash' }); <del> const resources: { originalUri: Uri; modifiedUri: Uri }[] = []; for (const file of stashFiles) { const fileUri = Uri.file(path.join(repository.root, file)); resources.push({ originalUri: fileUri, modifiedUri: toGitUri(fileUri, `stash@{${stash.index}}`) }); </del> <ins> const resources: { originalUri: Uri | undefined; modifiedUri: Uri | undefined }[] = []; for (const change of stashChanges) { if (change.status === Status.INDEX_ADDED) { resources.push({ originalUri: undefined, modifiedUri: toGitUri(change.uri, `stash@{${stash.index}}`) }); } else if (change.status === Status.DELETED) { resources.push({ originalUri: change.uri, modifiedUri: undefined }); } else if (change.status === Status.INDEX_RENAMED) { resources.push({ originalUri: change.originalUri, modifiedUri: toGitUri(change.uri, `stash@{${stash.index}}`) }); } else { resources.push({ originalUri: change.uri, modifiedUri: toGitUri(change.uri, `stash@{${stash.index}}`) }); } </ins> } commands.executeCommand('_workbench.openMultiDiffEditor', { multiDiffSourceUri, title, resources });

Discussion:
Testing Create a git stash that includes a new file, or a renamed file "View stash" The editor only shows modified files, and there is no indication that some content is missing <img width="442" alt="image" src=""<img width="305" alt="image" src=""<img width="887" alt="image" src=""
Maybe the pattern is that it only shows files that currently exist in the workspace. If I delete , then "View stash", I don't see that file either.
could you please take a look at this. I have checked and the git extensions is passing all files but it does look like the multi-file diff editor does not display all of them. Let me know if I need to change anything in the git extension. Thanks!
still seeing this, <img width="1725" alt="Screenshot 2024-01-25 at 8 31 59 AM" src=""<img width="1728" alt="Screenshot 2024-01-25 at 8 31 44 AM" src=""<img width="650" alt="Screenshot 2024-01-25 at 8 32 13 AM" src=""
when you have untracked filed you have to use the "Git: Stash (Include Untracked)" command otherwise the untracked files are not being included in the stash.
Change:
import * as nls from 'vs/nls'; import { URI } from 'vs/base/common/uri'; import { IStateService } from 'vs/platform/state/common/state'; <del> import { screen, BrowserWindow, systemPreferences, app, TouchBar, nativeImage } from 'electron'; </del> <ins> import { screen, BrowserWindow, systemPreferences, app, TouchBar, nativeImage, Rectangle, Display } from 'electron'; </ins> import { IEnvironmentService, ParsedArgs } from 'vs/platform/environment/common/environment'; import { ILogService } from 'vs/platform/log/common/log'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

Discussion:
A fresh install of Code - stable, insiders and code-oss - will spawn a floating window relative to the top of the screen, not to the work area. Code stores the window position, so moving the window makes it spawn in the new location next time. ! Issue Type: <bBug</bSteps to reproduce: Taskbar at top of screen Display resolution: 1366x768 Install fresh copy of Code. Run Code (with or without extensions disabled) VS Code version: Code 1.23.1+ OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
via
Change:
import { LineRange } from 'vs/workbench/contrib/mergeEditor/browser/model/lineRange'; import { applyObservableDecorations, join } from 'vs/workbench/contrib/mergeEditor/browser/utils'; import { handledConflictMinimapOverViewRulerColor, unhandledConflictMinimapOverViewRulerColor } from 'vs/workbench/contrib/mergeEditor/browser/view/colors'; <ins> import { EditorGutter } from 'vs/workbench/contrib/mergeEditor/browser/view/editorGutter'; </ins> import { CodeEditorView } from './codeEditorView'; export class ResultCodeEditorView extends CodeEditorView {

Discussion:
Note the shadow clipping on the left: <img width="256" alt="CleanShot 2022-07-25 at 09 57 06 src="https://user-"
Change:
case ProcessPropertyType.InitialCwd: this._initialCwd = value; this._cwd = this._initialCwd; <del> this.refreshTabLabels(this.title, TitleEventSource.Api); </del> <ins> this.refreshTabLabels(this.title, TitleEventSource.Config); </ins> break; case ProcessPropertyType.Title: this.refreshTabLabels(value ? value : '', TitleEventSource.Process);

Discussion:
With the following settings: I'm not seeing show up: ! Changing to also doesn't show the (), but it does when I add that to description. Creating a new terminal will have it applied though: !
/verified
Change:
readonly onWatchFail = this._onDidWatchFail.event; <ins> protected override getUpdateWatchersDelay(): number { return 0; } </ins> protected override async doWatch(requests: INonRecursiveWatchRequest[]): Promise<void> { await super.doWatch(requests); for (const watcher of this.watchers) {

Discussion:
With TS 5.5 we are seeing a lot more requests to watch paths such as which in the end makes the file watcher consume 100% CPU for at least a minute on my machine. Need to understand why this is so slow on startup, probably some complexity somewhere trying to handle these requests.
Change:
import { AccessibleViewAction } from '../../accessibility/browser/accessibleViewActions.js'; import type { ITreeElement } from '../../../../base/browser/ui/tree/tree.js'; import { IPathService } from '../../../services/path/common/pathService.js'; <ins> import { isCodeEditor } from '../../../../editor/browser/editorBrowser.js'; </ins> export const CONTEXT_KEY_HAS_COMMENTS = new RawContextKey<boolean>('commentsView.hasComments', false); export const CONTEXT_KEY_SOME_COMMENTS_EXPANDED = new RawContextKey<boolean>('commentsView.someCommentsExpanded', false);

Discussion:
Type: <bFeature Request</bCC I appreciate the current implementation of Accessible View (alt+F2) in the Comment Thread. However, I would like to suggest a few improvements to make it more accessible for screen reader users. [Easy navigation]: by separating the comment from the line number, screen reader users can easily navigate the comment text. [Improved discoverability]: providing the corresponding content of the comment can help screen reader users to understand the context of the comment. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
and press alt+f2 was focused but blank a11y view is shown ! the comment content and press alt+f2 11y view shows with just the comment content ! Is the content of the a11y view supposed to match the request in the issue? Am I focusing on the wrong thing?
your focus needs to be on a comment for this to work.
Secondly, you need to have a selection of code associated with the comment to see that in the accessible view.
I notice I can focus on the comment in the Comments view and then press Alt+F2 to show the comment in the accessible view. However, it adds the word "undefined". I'm not sure whether that word comes from the line range or date. !
thanks , i'll make a new issue to track that bug
Change:
this._disposables.push( vscode.commands.registerCommand('references-view.next', () => this.next(false)), vscode.commands.registerCommand('references-view.prev', () => this.previous(false)), <ins> _view.onDidChangeSelection(() => this._ensureSelectedElementIsVisible()), </ins> ); }

Discussion:
Very often I loose the yellow markers in the editor for references, see here for example: ! Here I find references of  and quickly dismiss the results of the one file before clicking on the other. Both files were opened before.
Didn't reproduce for me. Please update with repro steps
steps be in a multi root workspace with and close all editors open click on  of (at the end of the file) run (I have it bound to command) expand by clicking it once in the references view click the first result remove the 2 references by clicking on the X starting from the first click on the last result from no more highlights in the editor at all Full video: !
When removing the -entry (all together or all by removing all its children) I am not (always) getting the selection change event.
anything special for reproing this? I haven't been able to hit it.
Selection change event should be fixed now.
Thanks
fyi noticing a few behavioural differences now, which maybe we tolerate but users might not: clicking on a file name now opens the first reference, previously I believe it was not navigating but just expanding/collapsing (see video 1) triggering find references seems to reveal a reference in another file in some cases (see video 2) ! !
Change:
private readonly _messageWidget = new MutableDisposable<MessageWidget>(); private readonly _messageListeners = new DisposableStore(); private _message: { element: HTMLElement; dispose: () => void } | undefined; <del> private _focus: boolean = false; </del> <ins> private _mouseOverMessage: boolean = false; </ins> constructor( editor: ICodeEditor,

Discussion:
Testing Tiniest of nits, and perhaps this is inherited from all hovers, but I felt like the hover disappeared too quickly. If I was reading particularly slowly or looked away and then back at the message, I might've missed it.
felt the same, I think using the workbench hover infra would help.
Also, it disappears when you still hover on it: !
I think given the new complexity of this hover and the actions we should do a tactical fix here. I suggest to remove the timer that removes the message automatically after 3 seconds: There are still other listeners in place to hide the message, so I think we are good.
makes sense.
trying to verify: "readonly hover" means "hover in readonly files" ?
best to verify would be in repo open a file from folder and try to edit in such a file. You should see a hover with a link.

Testing This would benefit from an underline instead of the bold treatment to match the rendering we use in the workspace banner links (e.g. restricted mode) <img width="490" alt="CleanShot 2023-06-26 at 21 53 54 src=""
I also think its hard to discover, but I think we are not using underline for links in hovers so far?
We also do not show underlines in other places we show markdown in hovers: <img width="485" alt="image" src=""I used bold because the blue background of the hover made the contrast poor with our usual blue link color. We could use another color instead though.
I think the intent of the blue color in the message widget is to draw more attention, i.e. giving the signal of an information message vs. just being a normal tooltip. But maybe we can make the background color of the widget the same as hovers and then user blue color for links. I think that way we can still keep the blue border but it will not collide with the links.
Sample with a mix of hover colors and info colors for border: <img width="764" alt="image" src=""
And in dark theme: ! Changes I did: use hover colors use the same border radius of as in editor hovers allow to tab into the message with keyboard to invoke the link within
Change:
constructor() { super({ <del> id: NotebookIndentUsingSpaces.ID, </del> <ins> id: NotebookChangeTabDisplaySize.ID, </ins> title: nls.localize('changeTabDisplaySize', "Change Tab Display Size"), precondition: undefined, });

Discussion:
to repro: click notebook indentations statusbar entry run "indent using spaces/tabs" and select a new number entry will not update, however indentations work correctly given the selection that the user made and the current settings.

No a "choose intentation type" entry in status bar when editing in a notebook. I have a notebook with tab indentation but it seems theres some global spaces setting that overrides it... even pasting a literal tab charachter inserts spaces :/ !
False alarm. The status bar entry just moved so much that I didn't see it right away, and it has a different name in the status bar entries context menu.
Actually, looks like the status bar is really slow to update. I saw it update eventually, but I'm not sure what caused it to finally show the correct thing. !
Change:
private readonly _onDidChangeExpansionState = this._register(new Emitter<boolean>()); readonly onDidChangeExpansionState: Event<boolean> = this._onDidChangeExpansionState.event; <ins> get ariaHeaderLabel(): string { return this._ariaHeaderLabel; } set ariaHeaderLabel(newLabel: string) { this._ariaHeaderLabel = newLabel; this.header.setAttribute('aria-label', this.ariaHeaderLabel); } </ins> get draggableElement(): HTMLElement { return this.header; }

Discussion:
GitHub Tags:#A11yMAS;#A11yTCS;#A11ySev2;#DesktopApp;#Win32;#Visual Studio Code Client;#BM-VisualStudioCodeClient-Win32-Aug2022;#WCAG1.3.1;#NVDA; #ScreenReader;#JAWS;#AILimited;#Element:Button; Application Name: Visual Studio Live Share Application version: 1.56.2 (user setup) Windows Version: Win10 VS Code a project (e.g., vsls-guestbook) in VSCode. till “sign in” button. till "Live share" under Extensions and hit enter on the NVDA and tab to drop down 'Visual Studio live share work' screen. The label of the 'Visual Studio live share work….' is being read as 'folder section button' when the screen reader focus moves to it using tab key. Similar issue is observed with JAWS. The screen reader should read it as 'Visual Studio live share work button' when screen reader focus moves to it. People who uses screen reader may face difficulty while activating an object when the accessible label is different than that of the visible labels. https://user-
logged for primary bug
I think this issue makes sense. In short - aria label of the explorer view should contain the name of the top folder. Currently it is just "Folders". So it should be dynamic. Assigning to
Actually not too sure how to fix this one. The section being read out is the static section name of the view pane We do have an aria label within that section header with the name of the folder which dynamically updates but that never gets focused. The pane registration is static and we don't know the folder name at that time
there's the  method in the . Update header should set the aria label of the header. And the explorer should call updateHeader every time the content of the header changes (which it might do already).

could you please the bug in open state the bug can be closed only by trusted tester after verification right now the fix is not present in the app Version: 1.72.0-insider (user setup) Commit: Date: 2022-09-23T05:17:37.024Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !
please look at the label that the VS Code bot has to the issue. It says "unreleased". Once the bot adds the label "released" that means the fix is present. We can not leave the issue open for the tester to close this since this does not align with the rest of our VS Code processes. In case the bug is not fixed after it is released, just comment on the issue and we will reopen it. Thanks!
GitHubTags:#Closed;
Change:
display: none; } <del> .monaco-workbench .inline-chat .status .label A { color: var(--vscode-textLink-foreground); cursor: pointer; } .monaco-workbench .inline-chat .status .label.error { color: var(--vscode-errorForeground); } .monaco-workbench .inline-chat .status .label.warn { color: var(--vscode-editorWarning-foreground); } </del> .monaco-workbench .inline-chat .status .actions { display: flex; }

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
import 'vs/css!./media/extensionActions'; import { localize } from 'vs/nls'; import { IAction, Action } from 'vs/base/common/actions'; <del> import { Throttler } from 'vs/base/common/async'; </del> <ins> import { Throttler, Delayer } from 'vs/base/common/async'; </ins> import * as DOM from 'vs/base/browser/dom'; import * as paths from 'vs/base/common/paths'; import { Event } from 'vs/base/common/event';

Discussion:
Improve user experience while installing themes
!
It would be cool if you could preview themes in the store, maybe with a split view hosting some example code, or even with the files you have open.
Please open a feature request for it
Change:
} } <ins> private handleStickyScrollMouseEvent(e: IListMouseEvent<ITreeNode<T, TFilterData>>, node: ITreeNode<T, TFilterData>): void { if (isMonacoCustomToggle(e.browserEvent.target as HTMLElement) || isActionItem(e.browserEvent.target as HTMLElement)) { return; } const stickyScrollController = this.stickyScrollProvider(); if (!stickyScrollController) { throw new Error('Sticky scroll controller not found'); } const nodeIndex = this.list.indexOf(node); const elementScrollTop = this.list.getElementTop(nodeIndex); const elementTargetViewTop = stickyScrollController.nodePositionTopBelowWidget(node); this.tree.scrollTop = elementScrollTop - elementTargetViewTop; this.list.setFocus([nodeIndex]); this.list.setSelection([nodeIndex]); } </ins> protected override onDoubleClick(e: IListMouseEvent<ITreeNode<T, TFilterData>>): void { const onTwistie = (e.browserEvent.target as HTMLElement).classList.contains('monaco-tl-twistie');

Discussion:
Testing Repro: a node in a tree that is fairly deep. a parent node. that there's a slight flicker. Consecutive collapse/expands don't have that, only the first. ]()