jiebi/CodeConvo huggingface dataset:
Change:
"vscode-proxy-agent": "0.4.0", "vscode-ripgrep": "^1.2.5", "vscode-textmate": "^4.1.1", <del> "yauzl": "^2.9.1", </del> <ins> "yauzl": "^2.9.2", </ins> "yazl": "^2.4.3" }, "optionalDependencies": {

Discussion:
Issue Type: <bBug</b! VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-30T06:17:39.118Z) OS version: Darwin x64 18.0.0 <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ unique-lines1.0.0 ssh0.0.4 vscode-eslint1.8.0 Spot0.4.0 ghlink1.0.2 remotehub0.2.0 EditorConfig0.12.7 tslint1.0.42 git-project-manager1.7.1 vscode-pull-request-github0.3.2 rest-client0.21.1 solidity0.0.49 theme-karyfoundation-themes18.2.1 graphql-for-vscode1.13.0 vscode-azureappservice0.11.0 vscode-azurefunctions0.13.1 vscode-cosmosdb0.9.1 azure-account0.8.0 azurecli0.4.2 cpptools0.21.0 github-issues-prs0.9.1 debugger-for-chrome4.11.1 vscode-docker0.5.1 vscode-versionlens0.22.0 vscode-workspacecontains-canary0.0.2 vscode-open-in-github1.10.1 ayu0.17.0 vscodeintellicode1.1.2 azure-iot-toolkit2.2.0 </details<!-- generated by issue reporter --
This is coming as deprecation from our Electron update. If its unclear where this deprecation is coming from, I can help to print a stack from the place where it happens (this requires Electron 4 though from our exploration builds).
The stack trace would be helpful to know.
to this: open command line use Exploration: macOS: Linux: Windows:
DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the (), Buffer.allocUnsafe(), or () methods instead. at showFlaggedDeprecation () at new Buffer () at fromRandomAccessReader (/Applications/Visual Studio Code - ) at /Applications/Visual Studio Code - at FSReqWrap.oncomplete ()
This is coming from lib. Will this gets fixed upstream?
I suggest you check if there is a newer version of yauzl lib that has this fixed.

It should get fixed if a popular node lib wants to support node 10
I do not see this warning when running from sources? How can I repro this on dev?
it should show up, I saw it in devtools at least, but never from the comand line.
I can confirm that this is still happening for me when using on Windows to install latest versions of following extensions: ms-azure-, ms-vscode.powershell, ms-, ms-, ms-, ms-, , , eamodio.gitlens, qezhu.gitlink, yzhang.markdown-all-in-one. In case this is needed, here's my environment info: nodejs 8.9.3 npm 5.5.1 windows server 1607 10.0..2791 vscode system installer 1.33.1
I too can confirm the existence of the issue nodejs 10.9.0 npm 6.2.0 vscode system installer 1.33.1
When I install extensions on the command line in Fedora 30:
On WIndows 10:
FWIW I see this showing up inside Code in the developer tools now during normal use, if I installed from a VSIX (through the command palette). That is, the error is occurring during extension usage, not just during installation. <img width="769" alt="Screenshot 2019-05-23 at 11 43 56 am" src="https://user-"In the packed version of my extension, there is no instance of "Buffer()" in the code, so I don't think it's my code directly triggering it.
Change:
); } }); <ins> Gesture.addTarget(this._domNode.domNode); this._sliderTouchStartListener = dom.addDisposableListener(this._domNode.domNode, EventType.Start, (e: GestureEvent) => { e.preventDefault(); e.stopPropagation(); if (this._lastRenderData) { this._slider.toggleClassName('active', true); this._gestureInProgress = true; this.scrollDueToTouchEvent(e); } }); this._sliderTouchMoveListener = dom.addStandardDisposableListener(this._domNode.domNode, EventType.Change, (e: GestureEvent) => { e.preventDefault(); e.stopPropagation(); if (this._lastRenderData && this._gestureInProgress) { this.scrollDueToTouchEvent(e); } }); this._sliderTouchEndListener = dom.addStandardDisposableListener(this._domNode.domNode, EventType.End, (e: GestureEvent) => { e.preventDefault(); e.stopPropagation(); this._gestureInProgress = false; this._slider.toggleClassName('active', false); }); } private scrollDueToTouchEvent(touch: GestureEvent) { const startY = this._domNode.domNode.getBoundingClientRect().top; const scrollTop = this._lastRenderData!.renderedLayout.getDesiredScrollTopFromTouchLocation(touch.pageY - startY); this._context.viewLayout.setScrollPositionNow({ scrollTop: scrollTop }); </ins> } public dispose(): void { this._mouseDownListener.dispose(); this._sliderMouseMoveMonitor.dispose(); this._sliderMouseDownListener.dispose(); <ins> this._sliderTouchStartListener.dispose(); this._sliderTouchMoveListener.dispose(); this._sliderTouchEndListener.dispose(); </ins> super.dispose(); }

Discussion:
Issue Type: <bFeature Request</bWhen using a touch screen, I want to be able to interact with VSCode in an intuitive manner. When I touch the minimap, I expect the document to scroll immediately on touch-down, not on touch-up. Mouse-up makes sense for a mouse, but not for a touch. When I touch and drag the minimap, I expect the minimap to scroll with my finger. VS Code version: Code 1.22.1 (, 2018-04-06T02:26:57.615Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.487 --- <!-- score: 0.464 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --
I haven't PR'd vscode before, if anyone who cares about this issue has tips on getting my PR ^^ merged and released I'm happy to put more work into it. I find it very frustrating not having touch-scrolling on the minimap, as I'm so used to it working in old-school Visual Studio!
Change:
ContextKeyExpr.has('a1'), ContextKeyExpr.and(ContextKeyExpr.has('and.a')), ContextKeyExpr.has('a2'), <ins> ContextKeyExpr.glob('d3', '**/d*'), ContextKeyExpr.glob('d4', '**/3*'), </ins> ContextKeyExpr.equals('b1', 'bb1'), ContextKeyExpr.equals('b2', 'bb2'), ContextKeyExpr.notEquals('c1', 'cc1'),

Discussion:
VSCode Version: 1.12.0 OS Version: MacOS Sierra 10.12.4 In , we'd like to be able to provide context menus for all gradle files. The current clause is limited to language types () or a single file name (). It would be helpful if there was support for glob pattern matching, as mentioned in
Hi, Any update on this?
I will push an additional change that expands this to support normal regular expressions instead of just glob-patterns. We figured that's more powerful and closer to ST
Will this be usable in matching any when clause value? Can you give an example?
You write , so will execute this . A sample from my dummy extensions (matches filenames ending in )
This is AWESOME! Should reduce the number of duplicate menu items I need to define
Slight update on this: The value must be enclosed in slashes, so . I have updated above sample
FYI: I tried to apply this feature to the "loaded script view" by following the entry in the release notes: ! But without much success. After looking into the test item and the corresponding feature item, I noticed that the latest syntax uses regular regexp syntax. I've taken the liberty to change the release notes to this: ! I did not attempt to clarify why actually matches "Docker files".
Hmm, I am writing a simple extension, and would like to copy any resourceName. It works without any when clause, but the menu item also shows up, when r-clicking inside the empty space. I would like to prevent it. Is there something like this ?
Ok I found . And its actually what I was looking for. But I did not found it in the docs, but code base.
Change:
if (resource) { await this._editorService.openEditor({ resource, <ins> description: instance.shellLaunchConfig.description, </ins> options: { pinned: true, forceReload: true, preserveFocus: editorOptions?.preserveFocus } <del> }, editorOptions?.viewColumn); </del> <ins> }, editorOptions?.viewColumn || ACTIVE_GROUP); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
export const enum AccessibilityVoiceSettingId { SpeechTimeout = 'accessibility.voice.speechTimeout', <del> SpeechLanguage = 'accessibility.voice.speechLanguage' </del> <ins> SpeechLanguage = SPEECH_LANGUAGE_CONFIG </ins> } export const SpeechTimeoutDefault = 1200; <del> const SpeechLanguageDefault = 'en-US'; </del> export class DynamicSpeechAccessibilityConfiguration extends Disposable implements IWorkbenchContribution {

Discussion:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked
Change:
this.relayoutCell(); } <del> this.applyDecorations(); </del> this.viewUpdate(); this.layoutCellParts();

Discussion:
Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width="981" alt="image" src=""I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width="980" alt="image" src=""It appears that the Code cells lost their yellow highlight.
Change:
Package: @@NAME@@ Version: @@VERSION@@ Section: devel <del> Depends: libnotify4, libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libgconf-2-4, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1 </del> <ins> Depends: libnotify4, libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1 </ins> Priority: optional Architecture: @@ARCHITECTURE@@ Maintainer: Microsoft Corporation <vscode-linux@microsoft.com>

Discussion:
Afaik, electron should build with dconf instead of gconf.
See also
Please report here:
electron now (3.x) works without gconf. All you have to do is
I can confirm that Insiders 1.31 works without gconf. Can gconf be dropped for insiders?
Change:
import { Event, Emitter } from 'vs/base/common/event'; import { getWindowsBuildNumber } from 'vs/workbench/contrib/terminal/node/terminal'; import { IDisposable } from 'vs/base/common/lifecycle'; <del> import { IShellLaunchConfig, ITerminalChildProcess, SHELL_PATH_INVALID_EXIT_CODE, SHELL_PATH_DIRECTORY_EXIT_CODE } from 'vs/workbench/contrib/terminal/common/terminal'; </del> <ins> import { IShellLaunchConfig, ITerminalChildProcess, SHELL_PATH_INVALID_EXIT_CODE, SHELL_PATH_DIRECTORY_EXIT_CODE, SHELL_CWD_INVALID_EXIT_CODE } from 'vs/workbench/contrib/terminal/common/terminal'; </ins> import { exec } from 'child_process'; import { ILogService } from 'vs/platform/log/common/log'; import { stat } from 'vs/base/node/pfs';

Discussion:
Invalid paths will cause the terminal to start at ' dir.
Is a variable a valid option to ? If so what variables? eg the directory of the current active document. This would replace the need for addin.
created
Would you suggest me to work on this thing and
Sorry for the delay, anything with the help wanted label is up for grabs
I'm sorry if it's not the correct issue to post this. I came here from following a bunch of now closed issues. So in case it could help you figure out what's wrong with this: I am having the very same error as described by . It started just after I upgraded budgie 17.10 (based on ubuntu) to 18.04 It happens only if all 3 of these conditions are met: have no terminal opened in the current instance of vscode. have several folders opened in the workspace have no specified (more on this below). If I use the command instead of the command , it prompts me to chose one of the opened folders in the workspace, and the terminal always starts successfully in this case. When trying to toggle the terminal (without any currently opened): The terminal fails to start with: set to either or . But the terminal starts successfully with a static value such as .
I have the same issue as , is there any solution to do this ? Split Terminal used to work, but now just trows 'chdir(2) failed' and 'The terminal process command '/bin/bash -l' failed to launch (exit code: 1)'
I noticed this problem for the first time today. I get the same error when I try to split the terminal. The issue occurs whenever I use the "Split Terminal" command. Using the "New Terminal" command does not throw this error.
After investigating a little further, the problem in my case is being caused by a unicode character in my file path. One of the folders in my file path is , and the apostrophe (right single quote) is the root of the problem. Removing that character from the folder name fixes it. I'm not sure why this only shows up with the "Split Terminal" command, though.
the cwd in split terminal is driven by this: ! It sounds like inherited (likely) breaks when it contains a ? Can you create a new issue for this?
Change:
} } <ins> private didActiveControlChange() { return this.activeControl === (this.model.activeEditor ? this.getEditorTabsController(this.model.activeEditor) : undefined); } </ins> private getEditorTabsController(editor: EditorInput): IEditorTabsControl { return this.model.isSticky(editor) ? this.stickyEditorTabsControl : this.unstickyEditorTabsControl; } openEditor(editor: EditorInput, options: IInternalEditorOpenOptions): boolean { <del> const didChange = this.getEditorTabsController(editor).openEditor(editor, options); </del> <ins> const didActiveControlChange = this.didActiveControlChange(); const didOpenEditorChange = this.getEditorTabsController(editor).openEditor(editor, options); const didChange = didOpenEditorChange || didActiveControlChange; </ins> if (didChange) { this.handleOpenedEditors(); }

Discussion:
Type: <bBug</bfile A from EXPLORER tab with file A file B from EXPLORER -breadcrumb shows file B path (correct) on the pinned tab with file A -breadcrumb shows file B path but should file A This is the minimal case. When I have multiple pinned tabs and open other files, the breadcrump gets more random. UPDATE: Looks like the bug only comes out if this setting is set to true: VS Code version: Code 1.92.2 (, 2024-08-14T17:29:30.058Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ macos-modern-theme2.3.19 better-cpp-syntax1.27.1 remote-containers0.380.0 remote-ssh0.113.1 remote-ssh-edit0.86.0 remote-wsl0.88.2 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.2 vscode-clangd0.1.29 regionfolder1.0.22 cmake-tools1.18.44 cpptools1.21.6 workspace-include-what-you-use0.0.3 cmake0.0.17 (4 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This doesn't reproduce for me. Please try without extensions enabled and without custom settings
I turned off extensions and custom settings. I nailed it down to this setting in It appears that the bug is reproducible only if is true.
can you help here? It seems that pinned, extra-row items don't make the call to the breadcrumbs controls, like how it is done for instance for the
Thanks for steps. could you take a look?
Thanks for reporting. When switching to the last previous active tab of the other tab bar it wasn't updating the breadcrumbs. Made a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Still doesn't work correctly on current insiders version. Version: 1.93.0-insider (user setup) Commit: Date: 2024-08-23T06:45:56.108Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.
Change:
"@microsoft/1ds-post-js": "^3.2.2", "@parcel/watcher": "2.1.0", "@vscode/iconv-lite-umd": "0.7.0", <del> "@vscode/proxy-agent": "^0.13.1", </del> <ins> "@vscode/proxy-agent": "^0.13.2", </ins> "@vscode/ripgrep": "^1.15.2", "@vscode/spdlog": "^0.13.10", "@vscode/vscode-languagedetection": "1.0.21",

Discussion:
Copied from
By based on the error from , looks like this commit was not released and consumed in VSCode
I assume this change was done in March and therefore it also exists in 1.77.0 ?
Not sure why you're assuming the change was done in March. The change was done in April: It's new in 1.78.0. This breaks automatic proxy discovery in the extension host on Windows platforms only. I don't think it's a stop ship because: affects extension host on Windows only. affects users who rely on automatic proxy discovery. There is a workaround: manually configure the proxy on VS Code. were seemingly no reports of breakage the entire month of April on Insiders. I suggest merging the fix in as a candidate of an April recovery milestone. Leaving it to you as endgame champ, to chime in.
Because I saw the dependency on was in March - May be this is nothing to do with this change. I agree to take this as a candidate for next recovery
Just to clarify: This breaks loading of OS certificates on Windows (not proxy discovery). This will affect users relying on self-signed certificates for development and those requiring a CA certificate from their network proxy. Only HTTP/S requests made by extensions using the Node API are affected.
Can a test get to prevent this from happening again?
This is also affecting remote-containers extension. I'm trying to open a folder in my remote linux machine using remote-containers extension in vscode(windows workstation). It just silently fails with the following error:
Thanks Manually setting the proxy in remote settings worked for me !
Verification: VS Code on Windows the output channel that there's no exception regarding <img width="1026" alt="image" src=""
Change:
const apiProposalNotListed = l10n.t("This proposal cannot be used because for this extension the product defines a fixed set of API proposals. You can test your extension but before publishing you MUST reach out to the VS Code team."); const implicitActivationEvent = l10n.t("This activation event cannot be explicitly listed by your extension."); const redundantImplicitActivationEvent = l10n.t("This activation event can be removed as VS Code generates these automatically from your package.json contribution declarations."); <ins> const bumpEngineForImplicitActivationEvents = l10n.t("This activation event can be removed for extensions targeting engine version ^1.75 as VS Code will generate these automatically from your package.json contribution declarations."); </ins> const starActivation = l10n.t("Using '*' activation is usually a bad idea as it impacts performance."); enum Context {

Discussion:
When developing extension the warning in : is wrong because it doesn't check if the extension is supported on older VSCode versions:
Change:
const codeMatches = filterData && filterData.codeMatches || []; code.set(marker.code, codeMatches); } else { <del> // TODO@sandeep: these widgets should be disposed </del> const container = dom.$('.marker-code'); const code = new HighlightedLabel(container); <del> new Link(parent, { href: marker.code.target.toString(), label: container, title: marker.code.target.toString() }, undefined, this._openerService); </del> <ins> const link = marker.code.target.toString(true); this.disposables.add(new Link(parent, { href: link, label: container, title: link }, undefined, this._openerService)); </ins> const codeMatches = filterData && filterData.codeMatches || []; code.set(marker.code.value, codeMatches); }

Discussion:
Type: <bBug</bI'm attempting to add CodeDescription support to diagnostics in my Language Server, it appears as if the 'query' part of the URI the language server returns is encoded before being displayed in the Problems window. This is resulting in incorrect navigation when clicking on the link. Raw data returned by the Language Server to VsCode: ! Actual link provided within the Problems window: ! This is the full diagnostic data that's returned. "diagnostics": [ { "range": { "start": { "line": 38, "character": 14 }, "end": { "line": 38, "character": 20 } }, "severity": 1, "code": "ERROR01", "source": "MyLang", "message": "Custom Error 01", "codeDescription": { "href": "https://a-custom-" } VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (8)</summaryExtensionVersion ------ vscode-eslint2.4.0 mfcobol1.0.44 mfenterprise1.0.44 csharp1.25.4 remote-ssh0.96.0 remote-ssh-edit0.84.0 remote-wsl0.75.2 remote-explorer0.2.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This seems to be an issue with the language client, how it is creating the vscode diagnostic and code href uri - What is the recommendation here for creating the vscode Uri from the url -
Users can create uris via but when opening them externally, e.g outside of VS Code, you should use - that skips encoding and works better with 3rd parties
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!