jiebi/CodeConvo huggingface dataset:
Change:
import * as os from 'os'; import * as minimist from 'minimist'; <del> import pkg from 'vs/platform/package'; </del> import { localize } from 'vs/nls'; export interface ParsedArgs extends minimist.ParsedArgs {

Discussion:
cc Standard sized (80 width) terminal: ! This is what is was like before: !
do you have any reason against using a community lib for this if I get the deps approved?
Not at all... I just think that the hard 80 column wrap is an unnecessary remnant of the past, given the resizing capabilities of terminal emulators of today.
yeah, I believe the community libs like yargs size the column dynamically but keep formatting similar to what it was like before.
Change:
this.hideHoverWidget(); } <del> this.updateInlineDecorations(sf); </del> <ins> this.updateInlineValueDecorations(sf); </ins> } private hideHoverWidget(): void {

Discussion:
Right now we expose an API to cells, and to webviews, but we don't publish types for this. The webview API is very simple, but the renderer will be somewhat more complex. We should consider either publishing these in or in a separate package.
This would be helpful for I think a or something would be a good place for it. Aside, it'd be cool if ts s could be contributed to... Right now we'd need a whole separate NPM scope to have separate I believe.
We can just PR a package called The naming of packages is only constrained by the maintainers' policy, and there are types that don't correspond to single packages, e.g.
Poor wording, I mean the project would need a different and for the client code vs the extension host code. (Or just know not call acquireApi outside of the client context of course. )
Oh, yea. In the sample renderer/code generator I'm using project references to keep things separated -- that also lets us use only in the renderer and output es6 modules (only) for webpack.
PR submitted

Bug Set "debug.inlineValues": true. Set breakpoint somewhere. After paused on the step, goto the end of the line and hit enter. Before After VS Code version: Code 1.20.0 (, 2018-02-07T17:02:34.244Z) OS version: Darwin x64 16.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ EditorConfig0.12.0 vscode-eslint1.4.5 vscode-great-icons2.1.24 auto-rename-tag0.0.15 code-beautifier1.7.2 vscode-scss0.6.2 mssql1.3.0 cpptools0.14.6 licenser1.1.1 (1 theme extensions excluded) </detailsReproduces only with extensions
I acknowledge the bug. This is just how decoartions are behaving, unfortunetly the inline decorations do not seem to have an option to not grow beyond the line. maybe you have an idea how to solve this? fyi in case you are interested into looking for a fix
debugger.inlineValues uses the editor's decorator api. A fix we can do is that if the editor is edited , then we re-sync the inlineValue decorators I'm not sure how this works but would love it if the bug was assigned to me so I can see it in my issues list
that's a good idea. can you please add to our project so we can assign some issues to him?
Change:
workspaceDiagnostics: false, }, codeActionProvider: { resolveProvider: true }, <del> completionProvider: { triggerCharacters: ['.', '/', '#'] }, </del> definitionProvider: true, documentLinkProvider: { resolveProvider: true }, <del> documentHighlightProvider: true, </del> documentSymbolProvider: true, foldingRangeProvider: true, referencesProvider: true,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: macOS 12.1 21C52 x86_64 Recently upgraded to 1.73 and no longer seeing selection highlighting. <img width="1728" alt="Screen Shot 2022-11-09 at 8 44 07 AM" src="https://user-"Default setting still and set on the user level as well to no avail. <img width="1728" alt="Screen Shot 2022-11-09 at 8 41 34 AM" src="https://user-"<img width="803" alt="Screen Shot 2022-11-09 at 8 41 56 AM" src="https://user-"
I am only seeing this in Markdown (including code blocks) but not source code.
The problem seems to be that previously you'd get a match if the cursor was at the start of the word but now only if you select/highlight the entire word (or subset). If this is a change in functionality, any way to update settings to restore previous out-of-box behavior?
I believe this might be caused by markdown now registering a document highlight provider. When a language registers a document highlight provider, the non-semantic based, text editor word highlight takes a back seat. I think you can turn this down via , or maybe . Let me loop in , maybe he has more ideas.
Change:
white-space: pre; /* Preserve whitespace but don't wrap */ } <del> .monaco-workbench.mac .repl .repl-tree .monaco-tl-twistie.collapsible + .monaco-tl-contents, .monaco-workbench.mac .repl .repl-tree .monaco-tl-twistie { </del> <ins> .monaco-workbench .repl .repl-tree .monaco-tl-twistie.collapsible + .monaco-tl-contents, .monaco-workbench .repl .repl-tree .monaco-tl-twistie { </ins> cursor: pointer; }

Discussion:
Testing ! Version: 1.68.0-insider (user setup) Commit: Date: 2022-06-01T05:16:24.411Z Electron: 17.4.6 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0.
Hm, for me I get a pointer on the entire row, on OSX. Don't have access to a Windows machine easily right now, however.
do you know why this rule is only for mac? Is that on purpose?
not sure. Looks like a copy paste error from the selector below. So I suggest to simply remove .
Change:
enumItemLabels?: string[]; allKeysAreBoolean?: boolean; editPresentation?: EditPresentationTypes; <del> defaultValueSource?: string | IExtensionInfo; </del> <ins> nonLanguageSpecificDefaultValueSource?: string | IExtensionInfo; </ins> isLanguageTagSetting?: boolean; categoryOrder?: number; categoryLabel?: string;

Discussion:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.
Change:
"command.cleanAllTracked": "Discard All Tracked Changes", "command.cleanAllUntracked": "Discard All Untracked Changes", "command.closeAllDiffEditors": "Close All Diff Editors", <ins> "command.closeAllUnmodifiedEditors": "Close All Unmodified Editors", </ins> "command.commit": "Commit", "command.commitAmend": "Commit (Amend)", "command.commitSigned": "Commit (Signed Off)",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Quite often I want to have open only the files that are modified from source control. It would be handy to have a "Close all Unmodified" option that would close any open files that are not modified according to source control.
I would like to contribute on this.
Verification steps: a folder/workspace that contains a git repository auto-save using the setting multiple files, make changes, and save them multiple files but do not make any changes a file, make changes, but do not save it the "Git: Close All Unmodified Editors" command Confirm that all modified files remain open Confirm that the dirty editor remains open Confirm that all unmodified editors are closed
Change:
this.focusTerminal(); } })); <ins> this.toDispose.push(DOM.addDisposableListener(this.parentDomElement, 'keyup', (event: KeyboardEvent) => { // Keep terminal open on escape if (event.keyCode === 27) { event.stopPropagation(); } })); </ins> this.toDispose.push(this.themeService.onDidThemeChange((themeId) => { <del> this.setTerminalTheme(themeId); </del> <ins> this.setTerminalTheme(); })); this.toDispose.push(this.configurationService.onDidUpdateConfiguration((e) => { this.setTerminalFont(); </ins> })); this.terminal.open(this.terminalDomElement); this.parentDomElement.appendChild(terminalScrollbar.getDomNode()); <del> let config = this.configurationService.getConfiguration<ITerminalConfiguration>(); this.terminalDomElement.style.fontFamily = config.terminal.integrated.fontFamily; this.setTerminalTheme(this.themeService.getTheme()); </del> <ins> this.setTerminalFont(); this.setTerminalTheme(); </ins> resolve(void 0); }); } <del> private setTerminalTheme(themeId: string) { </del> <ins> private setTerminalTheme() { </ins> if (!this.terminal) { return; } <del> let baseThemeId = getBaseThemeId(themeId); </del> <ins> let baseThemeId = getBaseThemeId(this.themeService.getTheme()); </ins> this.terminal.colors = DEFAULT_ANSI_COLORS[baseThemeId]; this.terminal.refresh(0, this.terminal.rows); } <ins> private setTerminalFont() { let config = this.configurationService.getConfiguration<ITerminalConfiguration>(); this.terminalDomElement.style.fontFamily = config.terminal.integrated.fontFamily; } </ins> public focus(): void { this.focusTerminal(true); }

Discussion:
Testing Open the integrated terminal Change the setting Observe: setting is not applied until a restart of VSCode

I've seen this a few times: ! It seems to disappear after a while, maybe it's to do with .local desktop entry or bin command running instead of real command?

Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?
Thinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.
Marked as candidate as it's a very simple change that's been reported a bunch of times.
Cherry picked to release/1.2
Change:
public static readonly SETTING_KEY_ATTR = 'data-key'; <ins> private readonly _onDidClickOverrideElement: Emitter<ISettingOverrideClickEvent> = new Emitter<ISettingOverrideClickEvent>(); public readonly onDidClickOverrideElement: Event<ISettingOverrideClickEvent> = this._onDidClickOverrideElement.event; </ins> private readonly _onDidChangeSetting: Emitter<ISettingChangeEvent> = new Emitter<ISettingChangeEvent>(); public readonly onDidChangeSetting: Event<ISettingChangeEvent> = this._onDidChangeSetting.event;

Discussion:
Issue Type: <bFeature Request</bTesting Just a thought: When I see "Modified in: Workspace" I might want to go there and check. I'd keep font and color as they are and add an underline and pointer cursor to "Workspace" on hover. VS Code version: Code - Insiders 1.27.0-insider (, 2018-08-29T05:12:15.247Z) OS version: Darwin x64 17.7.0 <!-- generated by issue reporter --
Good idea!
I would take a PR for this "Modified in: Workspace" - the word Workspace is underlined When clicked, it switches to the Workspace scope, and copies the setting key into the search bar, so the view is filtered to just that one setting
I'm interested in looking into this if that is alright.
Change:
// Trim whitespaces path = strings.trim(strings.trim(path, ' '), 't'); <del> // Remove trailing dots path = strings.rtrim(path, '.'); </del> return path; }

Discussion:
opens the current directory, also opens the current directory - not the parent
Repros on master. Also: opens opens etc.
i see the bug and the fix is in - i guess a short term work around is opens the parent directory
yes the fix should be in the next release, adding a slash is a good work around in the meantime.
I hope something good happens here. cause the way things are going. pretty much saying microsoft has lost all control of windows
Change:
"onLanguage:markdown", "onCommand:markdown.showPreview", "onCommand:markdown.showPreviewToSide", <del> "onCommand:markdown.showSource" </del> <ins> "onCommand:markdown.showSource", "onLanguage:markdown" </ins> ], "contributes": { "languages": [

Discussion:
It is possible to follow local links for the markdown? For example, I have two splits for a markdown file: one for editing, and the other one for previewing. If I have a local link . When clicking this link in the preview split, is it possible for both the two splits automatically switch to Further, is it possible to sync two scroll bars for the preview split and the edit split?
That would be nice for docs written in Markdown.
VSCODE 1.7.1 on Windown 8.1 Currently the links are working in the preview Pane, but can not be followed from editor with like it is possible for normal links !
I just checked in a fix to support identifying links in the markdown editor . will tackle clicking local links in the preview itself. Please give it a try in the next insiders build
Tried the insiders build, works as expected. Great work, thanks Update: Spaces in the file names are not recognized
Change:
} return { <del> validateFileLinks: convertDiagnosticLevel(settings.markdown.experimental.validate.fileLinks.enabled), validateReferences: convertDiagnosticLevel(settings.markdown.experimental.validate.referenceLinks.enabled), validateFragmentLinks: convertDiagnosticLevel(settings.markdown.experimental.validate.fragmentLinks.enabled), validateMarkdownFileLinkFragments: convertDiagnosticLevel(settings.markdown.experimental.validate.fileLinks.markdownFragmentLinks), ignoreLinks: settings.markdown.experimental.validate.ignoreLinks, </del> <ins> validateFileLinks: convertDiagnosticLevel(settings.markdown.validate.fileLinks.enabled), validateReferences: convertDiagnosticLevel(settings.markdown.validate.referenceLinks.enabled), validateFragmentLinks: convertDiagnosticLevel(settings.markdown.validate.fragmentLinks.enabled), validateMarkdownFileLinkFragments: convertDiagnosticLevel(settings.markdown.validate.fileLinks.markdownFragmentLinks), ignoreLinks: settings.markdown.validate.ignoredLinks, </ins> }; }

Discussion:
Add some form of error reporting for links in markdown files where we are confident that link is incorrect. Example: We should also have a setting to disable this error reporting since we will not be able to understand every flavor of markdown link
Bad references (seems like this should almost always be a reasonable error to report) Missing files (false positive if users rely on different logic to resolve markdown paths) - Missing headers (false positive if users rely on custom slugifier or are linking to something besides headers, such as html elements) -Checking links to external resources () Checking html in markdown
Re-opening as we will likely keep this as experimental this iteration
Change:
const FOCUS_IN_OUTPUT_COMMAND_ID = 'notebook.cell.focusInOutput'; const FOCUS_OUT_OUTPUT_COMMAND_ID = 'notebook.cell.focusOutOutput'; export const CENTER_ACTIVE_CELL = 'notebook.centerActiveCell'; <ins> const NOTEBOOK_CURSOR_PAGEUP_COMMAND_ID = 'notebook.cell.cursorPageUp'; const NOTEBOOK_CURSOR_PAGEUP_SELECT_COMMAND_ID = 'notebook.cell.cursorPageUpSelect'; const NOTEBOOK_CURSOR_PAGEDOWN_COMMAND_ID = 'notebook.cell.cursorPageDown'; const NOTEBOOK_CURSOR_PAGEDOWN_SELECT_COMMAND_ID = 'notebook.cell.cursorPageDownSelect'; </ins> registerAction2(class extends NotebookCellAction {

Discussion:
Issue Type: <bBug</ba notebook file. a cell which is large enough to overflow screen. <kbdPgDown</kbdand <kbdPgUp</kbdInstead of going one page down in PgDown, cursor goes to end of cell ! Does this issue occur when all extensions are disabled?: Yes VS Code version: Code 1.63.2 (, 2021-12-15T09:39:46.686Z) OS version: Linux x64 5.13.0-22-generic snap Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
import { IResourceEditorInput } from 'vs/platform/editor/common/editor'; import { NotebookDiffEditorInput } from 'vs/workbench/contrib/notebook/browser/notebookDiffEditorInput'; import { NotebookEditorInput } from 'vs/workbench/contrib/notebook/common/notebookEditorInput'; <del> import { ContributedEditorPriority, IEditorAssociationsRegistry, IEditorOverrideService, IEditorType, IEditorTypesHandler } from 'vs/workbench/services/editor/common/editorOverrideService'; import { EditorExtensions } from 'vs/workbench/common/editor'; </del> <ins> import { ContributedEditorPriority, DiffEditorInputFactoryFunction, EditorInputFactoryFunction, IEditorAssociationsRegistry, IEditorOverrideService, IEditorType, IEditorTypesHandler } from 'vs/workbench/services/editor/common/editorOverrideService'; import { EditorExtensions, IEditorInput } from 'vs/workbench/common/editor'; </ins> import { IFileService } from 'vs/platform/files/common/files'; <ins> import { DiffEditorInput } from 'vs/workbench/common/editor/diffEditorInput'; </ins> export class NotebookProviderInfoStore extends Disposable {

Discussion:
install "markdown notebook" extension make sure the default editor for MD files is the text editor open a MD file (opens as text) re-open with markdown notebook select an entry from outline or breadcrumbs :bug: a text editor opens
It looks like our editor contribution point isn't called
The same happens with the "references view" and the "problems panel" (use GH issue notebooks and make text editor default for its type)
Debugged this a little: everything works nice up to the point where the user setting is read and . That "steels" the resource from notebooks and re-routes it into the "normal" editor land... This code is novel to me so I might not have the best suggestions how to fix it. One idea is that my contribution marks a scheme as "winner scheme" and resources with that scheme will always use that contribution. Tho, I don't know what side effects that will have
Change:
}); /** <ins> * A context key that is set when the active cursor is in the range of an existing comment. */ export const activeCursorHasComment = new RawContextKey<boolean>('activeCursorHasComment', false, { description: nls.localize('hasComment', "Whether the position at the active cursor has a comment"), type: 'boolean' }); /** </ins> * A context key that is set when the active editor has commenting ranges. */ export const activeEditorHasCommentingRange = new RawContextKey<boolean>('activeEditorHasCommentingRange', false, {

Discussion:
Type: <bFeature Request</bCC any file containing comment thread editor, move your cursor to any line having comment your cursor is on the line, press ctrl+K ctrl+I to see if the comment tolltip opens Screen reader users cannot open comment tooltip on the current line via ctrl+K ctrl+I ctrl+K ctrl+I needs to work for the comment tooltip just like other tooltips. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
the comment widget is not a tooltip. We cannot reuse this keybinding to focus the comment widget because it's possible that line will have hover info. pls lmk if you disagree. I do wonder if we should have a focus closest comment widget command/keybinding.
Aw, I see. Please then consider adding a keybinding to focus the closest comment widget. Currently, alt+F9 and shift+alt+F9 go to the next and previous comment widget, but there is no action available to focus the comment on the current line.
It does make sense to have an "Expand and focus comment at current line" command.
The new command is "Focus Comment on Current Line" with no default keybinding.
To verify: Install an extension that provides comments GitHub Pull Requests can be used for this Sign in Open the Pull Requests view Open a file diff for a PR. If there aren't any comments in the file, add a comment on one of the changed lines and collapse the comment Put your cursor on a line in a file with a collapsed comment Open the command palette and run the command "Focus Comment on Current Line" Verify that the comment has focus
This should probably be to the comments and/or the editor accessibility help dialog for discoverability.
Change:
const all = this.repositories.map(r => getProviderStorageKey(r.provider)); const visible = this.visibleRepositories.map(r => all.indexOf(getProviderStorageKey(r.provider))); <del> const raw = JSON.stringify({ all, sortKey: this._repositoriesSortKey, visible }); </del> <ins> this.previousState = { all, sortKey: this._repositoriesSortKey, visible }; </ins> <del> this.storageService.store('scm:view:visibleRepositories', raw, StorageScope.WORKSPACE, StorageTarget.MACHINE); </del> <ins> this.storageService.store('scm:view:visibleRepositories', JSON.stringify(this.previousState), StorageScope.WORKSPACE, StorageTarget.MACHINE); </ins> } @debounce(5000)

Discussion:
I end up with all my repositories selected when going into an empty profile and out again: !
we figured out together that this reproduces easily by running the command to restart the extension host while having 1 repository selected. The underlying issue is that there are events fired from the extension host being disposed. This somehow has an impact on the state of the selected repositories and should probably be ignored or handled differently.
Change:
const editorLineHeight = this._editor.getOption(EditorOption.lineHeight); const widgetHeight: number = this._lineNumbers.length * editorLineHeight + this._lastLineRelativePosition; <del> this._rootDomNode.style.display = widgetHeight > 0 ? 'block' : 'none'; </del> <ins> if (widgetHeight === 0) { this._clearStickyWidget(); return; } this._rootDomNode.style.display = 'block'; </ins> this._lineNumbersDomNode.style.height = `${widgetHeight}px`; this._linesDomNodeScrollable.style.height = `${widgetHeight}px`; this._rootDomNode.style.height = `${widgetHeight}px`;

Discussion:
Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !
After delete and undo: !