jiebi/CodeConvo huggingface dataset:
Change:
import 'vs/css!./media/extensionEditor'; import { localize } from 'vs/nls'; import * as arrays from 'vs/base/common/arrays'; <del> import { OS } from 'vs/base/common/platform'; </del> <ins> import { OS, locale } from 'vs/base/common/platform'; </ins> import { Event, Emitter } from 'vs/base/common/event'; import { Cache, CacheResult } from 'vs/base/common/cache'; import { Action, IAction } from 'vs/base/common/actions';

Discussion:
The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)
I am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.
I think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.
is this issue closed? or still needs help?
Its still open and there is a PR which has to be reviewed.
Hello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?
Thanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/
Change:
private disposePastResults: () => void = () => { }; private _isDirty = false; private _onWillChangeModelListener: IDisposable | undefined; <ins> private _onDidChangeModelListener: IDisposable | undefined; </ins> constructor( private _searchModel: SearchModel,

Discussion:
Type: <bBug</ba jupyter notebook, create a python cell the cell the notebook two earch results the notebook bug One of the search results goes away <img width="1179" alt="Screenshot 2023-04-25 at 11 09 04 AM" src="https://user-"Making any changes to the search term makes both search results show again VS Code version: Code - Insiders 1.78.0-insider (Universal) (, 2023-04-25T05:41:22.331Z) OS version: Darwin x64 22.4.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
import { IURLHandler, IURLService } from 'vs/platform/url/common/url'; import { asText, IRequestService } from 'vs/platform/request/common/request'; import { IProductService } from 'vs/platform/product/common/productService'; <ins> import { isUndefined } from 'vs/base/common/types'; </ins> interface IUserDataProfileTemplate { readonly name: string;

Discussion:
Testing Try to import this profile file: Restart VS Code. Observe that VS Code does not load anymore.
Change:
} this.didFinishLoading = true; <del> this.previousState = undefined; </del> } dispose(): void {

Discussion:
I end up with all my repositories selected when going into an empty profile and out again: !
we figured out together that this reproduces easily by running the command to restart the extension host while having 1 repository selected. The underlying issue is that there are events fired from the extension host being disposed. This somehow has an impact on the state of the selected repositories and should probably be ignored or handled differently.
Change:
export const listDropBackground = registerColor('list.dropBackground', { dark: listFocusBackground, light: listFocusBackground, hc: null }, nls.localize('listDropBackground', "List/Tree drag and drop background when moving items around using the mouse.")); export const listHighlightForeground = registerColor('list.highlightForeground', { dark: '#0097fb', light: '#007acc', hc: focusBorder }, nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.')); export const listInvalidItemForeground = registerColor('list.invalidItemForeground', { dark: '#B89500', light: '#B89500', hc: '#B89500' }, nls.localize('invalidItemForeground', 'List/Tree foreground color for invalid items, for example an unresolved root in explorer.')); <ins> export const listErrorForeground = registerColor('list.errorForeground', { dark: '#ea4646', light: '#d60a0a', hc: null }, nls.localize('listErrorForeground', 'Foreground color of list items containing errors.')); export const listWarningForeground = registerColor('list.warningForeground', { dark: '#4d9e4d', light: '#117711', hc: null }, nls.localize('listWarningForeground', 'Foreground color of list items containing warnings.')); </ins> export const pickerGroupForeground = registerColor('pickerGroup.foreground', { dark: Color.fromHex('#0097FB').transparent(0.6), light: Color.fromHex('#007ACC').transparent(0.6), hc: Color.white }, nls.localize('pickerGroupForeground', "Quick picker color for grouping labels.")); export const pickerGroupBorder = registerColor('pickerGroup.border', { dark: '#3F3F46', light: '#CCCEDB', hc: Color.white }, nls.localize('pickerGroupBorder', "Quick picker color for grouping borders."));

Discussion:
The new error highlight in the explorer window is great, but for some reason the colours are all black for me. I've tried different themes, but it doesn't make any difference: !
Ah - I've figured it out. It's using the colour from 'editorError.foreground' from 'workbench.colorCustomizations'. I can see the logic in doing this, but I have the foreground colour set to black to hide the squigglies and use the border colour instead to show a double underline, which makes the stand out more. The theme has different colours for the editor area and the explorer area, so is it sensible to use the same colours? Maybe there should be a separate setting?
It's especially bad when you have transparent editor warnings and errors.
didn't you tweak the colors in the last endgame? is this still the same symbolic color?
This is what I've done:
Alright
I'd like to take this as my first issue. Can you point me where I can start?
Sure - here is the code that adds the decorations (using the squiggle colors): You can use the -function to define new colors, like here: I'd define two colors, for errors and for warnings.
Change:
<ins> { "name": "toml", "displayName": "%displayName%", "description": "%description%", "version": "1.0.0", "publisher": "vscode", "engines": { "vscode": "*" }, "scripts": { "update-grammar": "node ../../build/npm/update-grammar.js textmate/toml.tmbundle Syntaxes/TOML.tmLanguage ./syntaxes/toml.tmLanguage.json" }, "contributes": { "languages": [{ "id": "toml", "aliases": ["Toml", "toml"], "extensions": [".toml"], "configuration": "./language-configuration.json" }], "grammars": [{ "language": "toml", "scopeName": "source.toml", "path": "./syntaxes/toml.tmLanguage.json" }] } } </ins>

Discussion:
I have found as a related issue, but that seems to only tackle support in markdown files. I am suggesting that VSCode support the file extension. It should be very similar to the syntax, and is something I would be willing to tackle in a PR.
Yes, we would take a PR for this. Look at the or the extensions for examples. We pull in the grammars used in these extension from existing repos so that we don't have to maintain them in the VS Code repo. Both the or the extensions provide examples of this in their npm script
Perfect. I have found: , and will submit a PR later today. Thanks for the tip
After further discussion with the VS Code team, we have decided to revert this addition with See that commit for an explanation of why we feel this is the correct decision for guiding users to a better toml experience and for maintaining VS Code itself
Change:
EditorWarningDecoration = 'squiggly-warning', EditorErrorDecoration = 'squiggly-error', EditorUnnecessaryDecoration = 'squiggly-unnecessary', <del> EditorUnnecessaryInlineDecoration = 'squiggly-inline-unnecessary' </del> <ins> EditorUnnecessaryInlineDecoration = 'squiggly-inline-unnecessary', EditorDeprecatedInlineDecoration = 'squiggly-inline-deprecated' </ins> } export const enum NodeColor {

Discussion:
Now that has been to the API, I would like to support the proposal from to use it for tagging deprecated items. I figure the associated styling might be a strikethrough as proposed in but you guys can work that out separately.
I would be interested in helping out here with this and perhaps even . Without a lot of context, I assume this issue is specifically to add a new enum member here: I could open a PR that adds a member, if that's the case. edit: Looks like more applicable location would be and then opening a similar PR to
Yes, is the way to go. Find your way along usages/implementations of
Thanks, I'll work on that today.
Leaving this open so that we discuss this in the API sync
API has been finalised.
Change:
import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences'; import { IHostService } from 'vs/workbench/services/host/browser/host'; import { IEditorOptions as ICodeEditorOptions } from 'vs/editor/common/config/editorOptions'; <ins> import { IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService'; </ins> /** * An implementation of editor for file system resources.

Discussion:
Type: <bBug</ba readonly file system opening a file that does not exist. You can use the command for this bug A diaglogdialog shows that includes an option for <img width="345" alt="Screenshot 2024-01-23 at 10 38 49 AM" src=""Clicking on this option shows a second dialog that says the file cannot be created: <img width="312" alt="Screenshot 2024-01-23 at 10 39 02 AM" src=""I think it would be better not to show file in the first dialog VS Code version: Code - Insiders 1.86.0-insider (Universal) (, 2024-01-23T06:13:09.134Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
this._processExplorerWindow = new BrowserWindow({ skipTaskbar: true, resizable: true, <ins> fullscreen: false, </ins> width: position.width, height: position.height, minWidth: 300,

Discussion:
macOS run in fullscreen mode open the process explorer the prices explorer window also opens in fullscreen mode...
Hi Gonna take a look at this. It seems to be happening for 'Report issue' also.
Hi Can I help you somehow to get this merged?
Yep! Sorry for the delay, your change looks good. I'll merge it now. Thanks!
Change:
const didTitleChange = title !== this._title; this._title = title; if (didTitleChange) { <ins> this._setAriaLabel(this._xterm, this._id, this._title); </ins> if (this._titleReadyComplete) { this._titleReadyComplete(title); this._titleReadyComplete = undefined;

Discussion:
Currently focusing the terminal reads something like "Terminal 1", "Terminal 2". It should read "Terminal 1, bash", "Terminal 2, (custom title)", etc. Context:
Or simply the title you set... Maybe the title, then "Terminal 1" in brackets?
Or maybe go absolutely wild, and have it as a configurable string. Something like "i)", where i is the index.
I can look into fixing this issue if it is still open, although I do see it has been to the backlog.
please do , the backlog for us essentially means we want to do this eventually.
On it. Quick clarification, but what was meant by "custom title" in the issue description above? I guess more specifically, with , is the (custom) the user's choice? How will that terminal name be determined? (looking at the context linked above, it seems it should be what was set for the action) Additionally, before I delve into the source code, can you briefly clarify "focusing" on the textarea Can't seem to recreate that on the development version or released version.
by custom I mean when you rename a terminal via this command: ! The label is set here: You'll need a screen reader to verify whether it's read correctly but I expect the change to be on that line.
Not sure what the image says, but when you rename the terminal with the "Terminal: Rename" command. Thanks so much for dealing with it. Take care, Chris Norman
I anticipate changing this line: to this: Though prior to setting this attribute I anticipate I will need to add a check to see if the title was set or not, along with ensuring this attribute is updated on title changes (renamed instances). Although the latter should already be accounted for.
To get localization to work it will need to be , and yes good thinking we should have an if in there are 2 separate calls, one with and one without the title.
Will submit a PR shortly.
Where should I see this? When I focus the terminal, voiceover reads "Terminal 1, edit text, complentary" !
I'm also not getting what I'd expect from this issue. What's read: Terminal 2 edit blank Red dot where I clicked: !

What I'd expect that to read: "Terminal 2 powershell"
I'm going to take a shot at this for Grace Hopper's Open Source Day!
Here's a code poitner (not specific enough though)
I see that this issue hasn't been fully resolved as of now. I would like to try to fix it if it is still available to work on. As I am completely new to this project, I would appreciate some code pointers. With the pointers above I have already found out where the string "said by the narrator" is set. But could someone point me to the entry point for ? Thank you, looking forward to making my first contribution.
I found the entry point of and have resolved the issue. A pull request has been created at . If anyone is searching for the entry point, see
Thanks a lot for creating a PR!
Change:
const line = firstPart.lines[0]; const langId = this.editor.getModel()!.getLanguageIdAtPosition(ghostText.lineNumber, 1); const config = this.languageConfigurationService.getLanguageConfiguration(langId); <del> const m = line.match(config.wordDefinition); </del> <ins> const r = new RegExp(config.wordDefinition, config.wordDefinition.flags.replace('g', '')); const m = line.match(r); </ins> let acceptUntilIndexExclusive = 0; if (m && m.index !== undefined) { if (m.index === 0) {

Discussion:
Testing when accepting the next word in a python file, the entire line is accepted, whereas typescript will only accept the next word.
Change:
} function Global:Prompt() { <ins> $FakeCode = [int]!$global:? </ins> # NOTE: We disable strict mode for the scope of this function because it unhelpfully throws an # error when $LastHistoryEntry is null, and is not otherwise useful. Set-StrictMode -Off <del> $FakeCode = [int]!$global:? </del> $LastHistoryEntry = Get-History -Count 1 # Skip finishing the command if the first command has not yet started if ($Global:__LastHistoryId -ne -1) {

Discussion:
I noticed this starting yesterday: <img width="343" alt="image" src="https://user-"Create PR one works fine though: <img width="425" alt="image" src="https://user-"
This is happening because it exits with success <img width="379" alt="image" src="https://user-"
Was caused by the Windows pwsh strict mode change FYI
Change:
const ADD_COMMENT_COMMAND = 'workbench.action.addComment'; CommandsRegistry.registerCommand({ id: ADD_COMMENT_COMMAND, <del> handler: (accessor, args: { range: IRange; fileComment: boolean }) => { </del> <ins> handler: (accessor, args?: { range: IRange; fileComment: boolean }) => { </ins> const activeEditor = getActiveEditor(accessor); if (!activeEditor) { return Promise.resolve();

Discussion:
Type: <bBug</bSteps to reproduce: the comment-sample demo extension adding a comment by invoking ("Add Comment on Current Selection") from Command Palette (or programmatically, it behaves the same) Expected behavior: a new comment thread is created and a new comment can be edited; Actual behavior: Error is thrown: "Cannot read properties of undefined (reading 'range')"; As far as I know, this used to work 2-3 weeks ago in the Insiders builds. ! VS Code version: Code - Insiders 1.78.0-insider (, 2023-04-07T05:20:50.322Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ remote-ssh0.98.0 </details<!-- generated by issue reporter --
Change:
// If any candidates end with special characters that are likely to not be part of the // link, add a candidate excluding them. <del> const specialEndCharRegex = /[[]"']$/; </del> <ins> const specialEndCharRegex = /[[]"'.]$/; </ins> const trimRangeMap: Map<string, number> = new Map(); const specialEndLinkCandidates: string[] = []; for (const candidate of linkCandidates) {

Discussion:
<img width="1440" alt="image" src=""path:
thanks again for all these reports, these are great!
we had a similar issue with outputs in Jupyter extension, still looking for that. Looks like we've fixed the same issue in terminals, as well.
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-web-links/-/xterm-addon-web-links-0.2.1.tgz#6d1f2ce613e09870badf17615e7a1170a31542b2" integrity sha512-2KnHtiq0IG7hfwv3jw2/jQeH1RBk2d5CH4zvgwQe00rLofSJqSfgnJ7gwowxxpGHrpbPr6Lv4AmH/joaNw2+HQ== <del> xterm-addon-webgl@0.4.0-beta.11: version "0.4.0-beta.11" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.4.0-beta.11.tgz#0e4a7242e2353cf74aba55e5a5bdc0b4ec87ad10" integrity sha512-AteDxm1RFy1WnjY9r5iJSETozLebvUkR+jextdZk/ASsK21vsYK0DuVWwRI8afgiN2hUVhxcxuHEJUOV+CJDQA== xterm@4.3.0-beta.28.vscode.1: version "4.3.0-beta.28.vscode.1" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.3.0-beta.28.vscode.1.tgz#89b85398b5801708e833d08bf92b2124fa128943" integrity sha512-JNHNZyDtAWnybJTrenPzD6g/yXpHOvPqmjau91Up4onRbjQYMSNlth17SqaES68DKn/+4kcIl2c/RG5SXJjvGw== </del> <ins> xterm-addon-webgl@0.5.0-beta.7: version "0.5.0-beta.7" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.5.0-beta.7.tgz#b7b95a362e942ad6f86fa286d7b7bd8ee3e7cf67" integrity sha512-v6aCvhm1C6mvaurGwUYQfyhb2cAUyuVnzf3Ob/hy5ebtyzUj4wW0N9NbqDEJk67UeMi1lV2xZqrO5gNeTpVqFA== xterm@4.4.0-beta.13: version "4.4.0-beta.13" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.4.0-beta.13.tgz#f7c5fa0d2b098ce0dd8b7c96d3d5fcaee22b86ed" integrity sha512-ZoDOVO3w84CXekBveGw1H2lcvM4HkJG5suXesE/3S+N4DnBhBcK/vw4kdooALGoorJV2GtgA1XEA6+m4N5Sgnw== </ins> y18n@^3.2.1: version "3.2.1"

Discussion:
Re macOS zsh with oh my zsh Run scripts described in Open with Canvas rendering and select all ! Open with WebGL rendering ! !
Upstream: I think the problem with inverse is the only issue there? Let me know if I'm wrong.
yup, that's the only issue I saw.
Change:
} /* Find widget when replace is toggled on */ <del> .monaco-editor .find-widget.replaceToggled { top: -74px; /* find input height + replace input height + shadow (10px) */ } </del> .monaco-editor .find-widget.replaceToggled > .replace-part { display: flex; display: -webkit-flex; } <del> .monaco-editor .find-widget.visible, .monaco-editor .find-widget.replaceToggled.visible { top: 0; } /* Multiple line find widget */ .monaco-editor .find-widget.multipleline { top: unset; bottom: 10px; } .monaco-editor .find-widget.multipleline.visible, .monaco-editor .find-widget.multipleline.replaceToggled.visible { top: 0px; bottom: unset; </del> <ins> .monaco-editor .find-widget.visible  { transform: translateY(0); </ins> } .monaco-editor .find-widget .monaco-inputbox.synthetic-focus {

Discussion:
Issue Type: <bBug</bSteps to Reproduce: any file to open the Search and Replace bar the Replace field, hit to add a line return the bar --The bottom of the bar is visible while closed. ! VS Code version: Code 1.39.2 (, 2019-10-15T15:33:40.634Z) OS version: Linux x64 5.0.0-32-generic <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ vscode-intelephense-client1.2.3 vscode-tailwindcss0.2.0 gitlens10.1.1 auto-rename-tag0.1.0 gc-excelviewer2.1.32 todo-tree0.0.160 graphql-for-vscode1.15.1 rainbow-csv1.3.1 git-graph1.17.0 dotenv1.0.1 language-gettext0.1.1 vscode-typescript-tslint-plugin1.2.2 vsliveshare1.0.988 debugger-for-chrome4.12.0 material-icon-theme3.9.1 partial-diff1.4.0 ayu0.18.0 change-case1.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.467 --<!-- potentialduplicatescomment --
This is not a duplicate.
I hope you don't mind but I had a look into this and I've fixed it. Should I bother with a PR or leave it to you? It only adds if the contains , it doesn't check . However, I noticed that if is , you don't get the animation (slide down/up). I think a better solution may be to animate on transform.
not at all, feel free to send out your work and thanks for your contribution!
Change:
if (item.isDisposed) { return this.onSelectResource(resource, reveal, retry + 1); } <del> this.tree.reveal(item, 0.5); </del> <ins> // Don't scroll to the item if it's already visible if (this.tree.getRelativeTop(item) === null) { this.tree.reveal(item, 0.5); } </ins> } this.tree.setFocus([item]);

Discussion:
! ! Version: 1.39.2 autoReveal always moves the filename entry to the middle in file explorer window when we select a file on tab. if the filename is not visible in the explorer, this is ok. if the filename is visible in explorer, it should not move the filename to the middle in explorer, just highlight the filename where it is, right there in explorer. thanks!
I've taken a stab at this in as it's something that annoys me, hope that's alright
Change:
this.updateHeader(); if (expanded) { <ins> if (!this._bodyRendered) { this.renderBody(this.body); this._bodyRendered = true; } </ins> if (typeof this.animationTimer === 'number') { clearTimeout(this.animationTimer); }

Discussion:
Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible
would you be willing to verify for completeness?
Works great!
Change:
export class InstalledExtensionsView extends ExtensionsListView { <del> public static isInsalledExtensionsQuery(query: string): boolean { </del> <ins> public static isInstalledExtensionsQuery(query: string): boolean { </ins> return ExtensionsListView.isInstalledExtensionsQuery(query) || ExtensionsListView.isOutdatedExtensionsQuery(query) || ExtensionsListView.isDisabledExtensionsQuery(query)

Discussion:
Issue Type: <bSource Defect</bis missing a 't' for . I'll send a PR; looks like this isn't a public versioned API?
Change:
@IKeybindingService keybindingService: IKeybindingService, ) { super(parent, options, contextViewService, instantiationService, contextKeyService, keybindingService); this._register(toDisposable(() => this.stopRecordingKeys())); this._chords = null; this._inputValue = ''; <del> this._reset(); </del> } override clear(): void { <del> this._reset(); </del> <ins> this._chords = null; </ins> super.clear(); }

Discussion:
Type: <bBug</bPreviously pressing escape while "Record Keys" was active in the keybindings UI would disable key recording and leave the search query intact. Now it disables key recording and clears the search query which makes it much harder to use. I traced this regression to 1.78. I'm guessing this is an issue with keybindings. The binding for is being processed in addition to the (hard-coded?) binding to stop recording. ! VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-04T22:11:08.187Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --