jiebi/CodeConvo huggingface dataset:
Change:
} public restoreRelativeVerticalPositionOfCursor(editor: ICodeEditor): void { <ins> if (this._initialContentHeight === editor.getContentHeight() && this._initialScrollTop === editor.getScrollTop()) { // The editor's content height and scroll top haven't changed, so we don't need to do anything return; } </ins> const currentCursorPosition = editor.getPosition(); if (!this._cursorPosition || !currentCursorPosition) {

Discussion:
Type: <bBug</bI found this problem in Vim extension when using half page scroll with centered view and smoothScrolling, and reproduce this bug in test clean extension. Without smoothScrolling it works fine. When executing command two times with ~150ms delay second action dont trigger (view stay in position by first ). U can see it on this video, when view in some cases not returned to 31 line from 39. https://user- Reproduce: reproducing i set interval with two timeouts to create delay between two executions and set smoothScrolling. ! VS Code version: Code 1.76.2 (, 2023-03-14T17:55:54.936Z) OS version: WindowsNT x64 10.0.

Modes: Unsupported Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (35)</summaryExtensionVersion ------ better-comments3.0.2 astro-vscode0.28.2 vscode-tailwindcss0.9.11 path-intellisense2.8.4 vscode-css-modules0.4.2 vscode-database-client26.3.4 vscode-eslint2.4.0 es7-react-js-snippets4.4.3 vsc-material-theme-icons2.7.4 prettier-vscode9.10.4 auto-close-tag0.5.14 auto-rename-tag0.1.10 code-runner0.12.0 geril-vim1.25.2 go0.38.0 vscode-graphql0.8.7 vscode-graphql-syntax1.1.0 code-background2.5.4 vscode-docker1.24.0 remote-wsl0.76.1 remote-explorer0.4.0 remote-server1.0.0 material-icon-theme4.25.0 prisma4.12.0 LiveServer5.7.9 rust-analyzer0.3.1463 vscode-styled-components1.7.8 svelte-vscode107.3.0 errorlens3.8.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-icons12.2.0 JavaScriptSnippets1.8.0 material-theme3.15.8 vscode-proto30.5.5 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.77.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
After update to 1.77.1 bug still exists
Thank you for the repro! The root cause is this particular call - introduced via cc That code runs even when the inlayHintsController doesn't do anything and it ends up interrupting the current editor scroll animation.
Change:
if (line < 0) { line = 0; <ins> character = 0; </ins> hasChanged = true; } <del> if (line >= this._lines.length) { </del> <ins> else if (line >= this._lines.length) { </ins> line = this._lines.length - 1; <ins> character = this._lines[line].length; </ins> hasChanged = true; } <del> if (character < 0) { character = 0; hasChanged = true; } let maxCharacter = this._lines[line].length; if (character > maxCharacter) { character = maxCharacter; hasChanged = true; </del> <ins> else { let maxCharacter = this._lines[line].length; if (character < 0) { character = 0; hasChanged = true; } else if (character > maxCharacter) { character = maxCharacter; hasChanged = true; } </ins> } if (!hasChanged) {

Discussion:
Issue Type: <bBug</bctrl-shift-p, "Debug: Start Debugging" leads to this error. I saw that this error was previously mentioned and fixed in a recent update, but the error persists. VS Code version: Code 1.46.1 (, 2020-06-17T21:13:20.174Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.19.104-microsoft-standard <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ regex0.2.0 gitlens10.2.2 vscode-pull-request-github0.17.0 vscode-codemetrics1.24.0 cpptools0.28.3 vscode-versionlens1.0.8 java0.63.0 vscodeintellicode1.2.8 application-insights0.4.2 vscode-java-debug0.26.0 vscode-java-dependency0.10.2 vscode-java-pack0.9.1 vscode-java-test0.23.0 vscode-maven0.22.0 code-lens-roundup1.0.0 remote-containers0.122.1 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.3 vscode-remote-extensionpack0.20.0 </details<!-- generated by issue reporter --
Same problem vscode v1.47.3. any update on this issue?
The issue was fixed in this insiders release:
what debugger are you using?
Dotnet Core.
thanks. That debugger is a separate extension (C#). Please file an issue against that. We have fixed a similar problem with the debugger (which is built into VS Code). But that fix does not cover the C# debugger.
Change:
"license": "MIT", "description": "Dependencies shared by all extensions", "dependencies": { <del> "typescript": "4.9.4" </del> <ins> "typescript": "4.9.5" </ins> }, "scripts": { "postinstall": "node ./postinstall.mjs"

Discussion:
Tracks picking up the Ts 4.9.5 recovery build Includes:
To verify, open a TS file and check the TS version in the language status item
Change:
@ILifecycleService lifecycleService: ILifecycleService, @ICommandService private readonly _commandService: ICommandService, @IInstantiationService instantiationService: IInstantiationService, <del> @IAudioCueService private readonly _audioCueService: IAudioCueService </del> <ins> @IAudioCueService private readonly _audioCueService: IAudioCueService, @INotificationService private readonly _notificationService: INotificationService </ins> ) { super(); this._register(toDisposable(() => this._dispose()));

Discussion:
VS Code Shell Integration vulnerability when re-running a command Escape sequences implemented by VS Code to support shell integration allow for a previously run command line to be replaced.
Change:
export class StickyScrollWidget extends Disposable implements IOverlayWidget { private readonly _layoutInfo: EditorLayoutInfo; <ins> private readonly _scrollbar: DomScrollableElement; private readonly _scrollableDomNode: HTMLElement = document.createElement('div'); </ins> private readonly _rootDomNode: HTMLElement = document.createElement('div'); private readonly _disposableStore = this._register(new DisposableStore());

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello So I have noticed when using Sticky Scroll, any line which is too long (for example the screenshot below), it would block off the rest of the code. A feature I was thinking would be a good adition is sideways scrolling (like what happens already in the main editor) so that people can see what else is in that line. <kbd<img src="https://user-"/</kbd
Change:
"id": "shellscript", "aliases": ["Shell Script", "shellscript", "bash", "sh", "zsh", "ksh"], "extensions": [".sh", ".bash", ".bashrc", ".bash_aliases", ".bash_profile", ".bash_login", ".ebuild", ".install", ".profile", ".bash_logout", ".zsh", ".zshrc", ".zprofile", ".zlogin", ".zlogout", ".zshenv", ".zsh-theme", ".ksh"], <del> "filenames": ["APKBUILD", "PKGBUILD"], </del> <ins> "filenames": [ "APKBUILD", "PKGBUILD", ".envrc" ], </ins> "firstLine": "^#!.*b(bash|zsh|sh|tcsh|ksh|ash|qsh).*|^#s*-*-[^*]*mode:s*shell-script[^*]*-*-", "configuration": "./language-configuration.json", "mimetypes": ["text/x-shellscript"]

Discussion:
is a utility which is used for augmenting a shell with directory-specific environment variables. The main configuration file for direnv, , should be treated as a Shell Script by default.
Change:
})); const body = $('.body'); <del> const scrollbar = new DomScrollableElement(body, {}); </del> <ins> const scrollbar = new DomScrollableElement(body, { alwaysConsumeMouseWheel: true, }); </ins> this._register(scrollbar); wrapper.appendChild(scrollbar.getDomNode());

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version:1.68.1 OS Version:windows 10 Steps to Reproduce: the cursor is in parentheses, press ctrl+shift+space. the popup panel to top or end. ! And is there any way to scroll the hints popup panel with the keyboard? When using the up and down keys, it only moves the cursor in editor.
Also seeing this for the suggest details. Looks similar to
Change:
export const gettingStartedInputTypeId = 'workbench.editors.gettingStartedInput'; export interface GettingStartedEditorOptions extends IEditorOptions { <del> selectedCategory?: string; selectedStep?: string; showTelemetryNotice?: boolean; </del> <ins> selectedCategory?: string; selectedStep?: string; showTelemetryNotice?: boolean; showWelcome?: boolean; </ins> } export class GettingStartedInput extends EditorInput {

Discussion:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.
Change:
this._matchesCount.className = 'matchesCount'; } this._matchesCount.innerText = ''; <del> let label; if (count?.resultCount === -1) { label = ''; } else { label = count === undefined || count.resultCount === 0 ? NLS_NO_RESULTS : strings.format(NLS_MATCHES_LOCATION, count.resultIndex + 1, count?.resultCount); </del> <ins> let label = ''; this._matchesCount.classList.toggle('no-results', false); if (count?.resultCount && count?.resultCount <= 0) { label = NLS_NO_RESULTS; if (!!this.inputValue) { this._matchesCount.classList.toggle('no-results', true); } } else if (count?.resultCount) { label = strings.format(NLS_MATCHES_LOCATION, count.resultIndex + 1, count?.resultCount); </ins> } this._matchesCount.appendChild(document.createTextNode(label)); <del> this._matchesCount.classList.toggle('no-results', !count || count.resultCount === 0); </del> this._findInput?.domNode.insertAdjacentElement('afterend', this._matchesCount); this._foundMatch = !!count && count.resultCount > 0; }

Discussion:
Testing macOS, zsh Do a couple of ls calls for something that has multiple matches in the terminal using the Down or Up arrow -notice how the count is always wrong !

Testing Notice how the "no results" is grey in the editor when the find input is empty. In the terminal it is red !

Refs: macOS, zsh shell Search for something in the terminal that does not exist -"no results" is not rendered. !

Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification

Testing a query which results in matches the terminal (e.g. expand or collapse explorer) :bug: match decorations remain !
Change:
range: new Range(1, 1, 1, selection.startColumn), text: null }]); <ins> // Announce the deletion this._accessibilityService.alert(localize('exited slash command mode', 'Exited {0} mode', this._lastSlashCommandText)); </ins> } }

Discussion:
on a screen reader on Windows (JAWS/NVDA) in the chat view backspace hear "space' said this is typical of a screen reader. We discussed using an audio cue to indicate deletion. We have concluded it would be better and simpler to just disable this feature for screen reader users. !
-- After this meeting, something came to mind. What if I love the current command deletion behavior and would like to keep it? would you like to add a user setting to toggle this behavior for some advanced users?
We try to add settings sparingly because we want the default experience to be very nice. I will leave this with to decide. We could keep this behavior and mention it in the chat's accessibility help menu so a screen reader user is aware of what's happening.
do you personally anticipate that you would use this setting to preserve the command deletion behavior? Do you know why the screenreader reads 'space' on a deletion? If we can avoid that, would it be more reasonable that hitting backspace results in the screenreader announcing 'exiting mode'?
JooYoung and I discussed that approach and agreed it would be too verbose. We should either use an audio cue, disable the feature, or provide a setting.
Or mention it in the chat's accessibility help?
After thinking about this issue for a day, I think we can add an alert "input cleared" when the command is entirely deleted. I found that character-by-character deletion works after when you move your cursor to the left.
This is great
Change:
import { isWindows } from 'vs/base/common/platform'; import { URI } from 'vs/base/common/uri'; import { Selection } from 'vs/editor/common/core/selection'; <del> import { SelectionBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, ClipboardBasedVariableResolver, TimeBasedVariableResolver } from 'vs/editor/contrib/snippet/snippetVariables'; </del> <ins> import { SelectionBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, ClipboardBasedVariableResolver, TimeBasedVariableResolver, WorkspaceBasedVariableResolver } from 'vs/editor/contrib/snippet/snippetVariables'; </ins> import { SnippetParser, Variable, VariableResolver } from 'vs/editor/contrib/snippet/snippetParser'; import { TextModel } from 'vs/editor/common/model/textModel'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <ins> import { Workspace, toWorkspaceFolders, IWorkspace, IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; </ins> suite('Snippet Variables Resolver', function () {

Discussion:
It would be really helpful if a variable with the repository name (workspace name or opened folder) that was available to use in the snippets. In my case, i use the snippets to create copyright messages, and i am using the project name (the same of the repository) as part of this message.
Hey I'd like to work on this. Can I give it a shot? I appreciate if you have any quick guidance.
Snippet variables are implemented and instantiated . add a variable resolver that uses the (like the and ) add a test here
Thanks :)
Change:
export interface IFileLabelOptions extends IResourceLabelOptions { hideLabel?: boolean; hidePath?: boolean; <del> range?: IRange; </del> } export interface IResourceLabel extends IDisposable {

Discussion:
Type: <bBug</bis used as delimiter instead of <img width="499" alt="image" src=""VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-23T05:35:37.619Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ project-manager12.7.0 vscode-eslint2.4.2 gitlens14.4.0 EditorConfig0.16.4 vscode-todo-plus4.19.1 code-runner0.12.1 vscode-pull-request-github0.74.0 gitlab-workflow3.81.0 vscode-peacock4.2.2 vscode-random1.11.0 rainbow-csv3.8.0 dotenv1.0.1 remote-containers0.318.0 remote-ssh0.107. remote-explorer0.5. material-icon-theme4.31.0 partial-diff1.4.3 code-spell-checker3.0.1 sort-lines1.11.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please use the command to investigate possible cause.
I am seeing it in Explorer too, in today's Insider, with all extensions disabled: !
I am bisecting now...
Hmm, nothing found. Maybe I am doing it wrong.
From
Change:
constructor() { super(); this._register(AccessibilityHelpAction.addImplementation(105, 'notebook', async accessor => { <del> const codeEditor = accessor.get(ICodeEditorService).getActiveCodeEditor() || accessor.get(ICodeEditorService).getFocusedCodeEditor(); if (!codeEditor) { return; </del> <ins> const activeEditor = accessor.get(ICodeEditorService).getActiveCodeEditor() || accessor.get(ICodeEditorService).getFocusedCodeEditor() || accessor.get(IEditorService).activeEditorPane; if (activeEditor) { runAccessibilityHelpAction(accessor, activeEditor); </ins> } <del> runAccessibilityHelpAction(accessor, codeEditor); </del> }, NOTEBOOK_IS_ACTIVE_EDITOR)); } }

Discussion:
a markdown cell in preview mode like Accessibility Help :bug: accessibility help does not appear If I focus a code cell I get the help view
IMO, this should not be working at all for github issue notebooks
Why is that? The notebooks UI and keybindings/commands are generic (though can be overridden by extensions)
Change:
const index = viewCell.outputs.indexOf(key); if (index >= 0) { const top = this.viewCell.getOutputOffsetInContainer(index); <del> value.style.top = `${top}px`; </del> <ins> value.element.style.top = `${top}px`; </ins> } });

Discussion:
Notice the cell goes beyond the right margin. Seems to happen for all cells
is it related to the indentation change?
I don't think there's an issue here anymore? I did push a change to ensure that a line of text with no whitespace will break and not overflow. But I don't see any other issues with overflowing horizontally. I do see plain text outputs overflowing if I resize the editor to be narrower...
Change:
} hasInMemoryDoc(): boolean { <del> return !this.inMemoryDoc; </del> <ins> return !!this.inMemoryDoc; </ins> } isDetached(): boolean {

Discussion:
Type: <bBug</bworkspace: : to top level of workspace bug The link is incorrectly rewritten to include the file name VS Code version: Code - Insiders 1.73.0-insider (Universal) (, 2022-10-27T21:41:11.954Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
} public resolveConfigurationByProviders(folderUri: uri | undefined, type: string | undefined, debugConfiguration: IConfig): TPromise<IConfig> { <del> return this.extensionService.activateByEvent(`onDebugResolve:${type}`).then(() => { </del> <ins> return this.activateDebuggers(`onDebugResolve:${type}`).then(() => { </ins> // pipe the config through the promises sequentially. append at the end the '*' types const providers = this.providers.filter(p => p.type === type && p.resolveDebugConfiguration) .concat(this.providers.filter(p => p.type === '*' && p.resolveDebugConfiguration));

Discussion:
Problem: install Java debugger open a folder with no switch to debug view and press gear button Observe: it looks like nothing is happening but in reality Java is initialising and starting Java language server. After a long time the debug env drop down appears. Analysis: Building the debug env drop down seems to activate all debug extensions. Solution: We should try to build the debug env drop down list only from declarative information found in the No debugger extensions should be activated for this. /cc
I acknowledge the bug, however due to how the code is structured on my side this would require a refactoring in the method which I am not so keen on doing because we have better fine grained events as a workaround. Thus pushing this to the backlog
Fixed in latest via
My mistake, acutally this is not fixed via that commit
How's going on for this bug? One more customer reported that they still see Java language server running on the bottom when developing a python file. It is strange. Thank you.
I have cleaned up the activation events and this is now fixed via However since this change is a bit delicate I would prefer to have the whole milestone to self host on it in insiders before we release it in stable. Due to that I will merge the PR in 4 days, so it is included in the next week insider, however it will be only in the october stable release (in a month).
Using our process explorer, I still see the java debugger extension being activated in this case. There is also a slight delay when clicking on the gear
After looking deeper into this, it is fine since the java debugger is activating onDebugInitialConfigurations since it is providing the initial configurations dynamically. Thus we have to activate it since we do not know which debugger the user will chose. Closing as designed. To verify: debug a node program, and verify that the java extension does not get activated
Change:
} // word wrap special case - sync transient state from result model to input[1|2] models <del> const mirrorWordWrapTransientState = () => { const state = readTransientState(model.resultTextModel, this._codeEditorService); writeTransientState(model.input2.textModel, state, this._codeEditorService); writeTransientState(model.input1.textModel, state, this._codeEditorService); </del> <ins> const mirrorWordWrapTransientState = (candidate: ITextModel) => { const candidateState = readTransientState(candidate, this._codeEditorService); writeTransientState(model.input2.textModel, candidateState, this._codeEditorService); writeTransientState(model.input1.textModel, candidateState, this._codeEditorService); writeTransientState(model.resultTextModel, candidateState, this._codeEditorService); const baseTextModel = this.baseView.get()?.editor.getModel(); if (baseTextModel) { writeTransientState(baseTextModel, candidateState, this._codeEditorService); } </ins> }; this._sessionDisposables.add(this._codeEditorService.onDidChangeTransientModelProperty(candidate => { <del> if (candidate === this.inputResultView.editor.getModel()) { mirrorWordWrapTransientState(); } </del> <ins> mirrorWordWrapTransientState(candidate); </ins> })); <del> mirrorWordWrapTransientState(); </del> <ins> mirrorWordWrapTransientState(this.inputResultView.editor.getModel()!); </ins> // detect when base, input1, and input2 become empty and replace THIS editor with its result editor // TODO@jrieken@hediet this needs a better/cleaner solution

Discussion:
Does this issue occur when all extensions are disabled?: Yes Word wrap doesn't affect the text of the base in the merge editor, regardless of whether the base is displayed in the center or at the top. Steps to reproduce: a branch with a conflict the merge editor word wrap Base in the center ! Base at the top ! Version: 1.76.0-insider (system setup) Commit: Date: 2023-02-09T05:23:28.458Z OS: Windows_NT x64 10.0. Sandboxed: Yes
I'll pick this up