jiebi/CodeConvo huggingface dataset:
Change:
*--------------------------------------------------------------------------------------------*/ import { localize } from 'vs/nls'; <del> import { EditorGroupLayout, GroupDirection, GroupOrientation, GroupsArrangement, GroupsOrder, IAuxiliaryEditorPart, IEditorDropTargetDelegate, IEditorGroupsService, IEditorSideGroup, IFindGroupScope, IMergeGroupOptions } from 'vs/workbench/services/editor/common/editorGroupsService'; </del> <ins> import { EditorGroupLayout, GroupDirection, GroupLocation, GroupOrientation, GroupsArrangement, GroupsOrder, IAuxiliaryEditorPart, IEditorDropTargetDelegate, IEditorGroupsService, IEditorSideGroup, IFindGroupScope, IMergeGroupOptions } from 'vs/workbench/services/editor/common/editorGroupsService'; </ins> import { Event, Emitter } from 'vs/base/common/event'; import { getActiveDocument } from 'vs/base/browser/dom'; import { Disposable, DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle';

Discussion:
Type: <bBug</bFirst of all, thank you for adding floating editor windows! Super useful feature that has already improved my productivity using VS code. I'm experiencing a weird issue where I am unable to navigate to the first editor group (located in my original window) from a newly opened window. I am able to navigate to any other editor group, but just not the first one. Steps to repro: Open vs code window with two editor groups (this is the "original window") Open new vscode window From the new window, press ctrl + 1 () to try to go to the first editor group in the original window Observe that nothing happens (expected to change focus to first editor group in the original window) From the new window, press ctrl + 2 () and observe that you can change focus to the second editor group as expected Current workaround if I want to change focus to the first editor group from the new window is I do ctrl + 2 to go to the second editor group, and then I can press ctrl + 1 to focus on the first editor group. If I'm in the original window I have no issue switching between the first and any other editor group in that window VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-17T10:49:40.914Z) OS version: Windows_NT x64 10.0. Modes: Remote OS version: Linux x64 5.15.0-1026-aws <details<summaryExtensions (13)</summaryExtensionVersion ------ remote-containers0.324.0 remote-ssh0.107.0 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 remote-explorer0.4.1 remote-server1.5.0 vim1.27.0 copilot1.137.556 copilot-chat0.11. autopep82023.9. python2023.20.0 vscode-pylance2023.11.10 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks, good catch. Fixing this case is relatively easy, but there are other navigational commands across editor groups that will need special care for when multiple windows are opened:
Change:
}; // Stub sync service to return edit session data <del> const sandbox = sinon.createSandbox(); </del> const readStub = sandbox.stub().returns({ editSession, ref: '0' }); instantiationService.stub(ISessionSyncWorkbenchService, 'read', readStub); <del> // Stub repositories instantiationService.stub(ISCMService, '_repositories', new Map()); </del> // Create root folder await fileService.createFolder(folderUri);

Discussion:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.
Change:
{ "comments": { "lineComment": "#", <del> "blockComment": [ "''", "''" ] </del> <ins> "blockComment": [ "'''", "'''" ] </ins> }, "brackets": [ ["{", "}"],

Discussion:
Testing !
The binary is indeed available in the server folder but the libc library it is linked with does not exist on the image.
Ripgrep should also build for rust target in to support alpine images so that it is uses the musl c library.
I can add that, thanks
Ripgrep couldn't build under that target. My understanding is… when building with musl, it uses jemalloc, jemalloc uses backgroundthreadsruntime_support, and that doesn’t support our target. If we can figure out how to un set that flag on jemalloc that might work around it but i don’t know what consequences that would have
from it is not sure whether the bug is in jemalloc config or cargo, but the immediate working solution is to build the crate with I will see if that works.
May I know if there is some workaround for this bug for users? If not, I do not think its good to ship Alpine ARM 64 builds with broken experience.
It will require users to install package that will include the required libraries for the executable built using glibc.
Not with your PR, right And thanks for the PR!
Yup is not needed with the musl binary produced from the PR.
I didn't put up a PR to adjust to download for alpine. Can you take care of it ? Thanks!

When using the block comment feature, only 2 single quotes are put in, instead of three.
Python block comments are triple quotes, not double. Check if that works.
It does! Thanks the bug is then that only 2 quotes are put in.
Fixed, see , reviewed by Alex

Type if ( expected =closing ) actual =nothing
Fixed by me, reviewed by Alex, see ,
Change:
import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { registerEditorAction, EditorAction, IActionOptions, EditorAction2 } from 'vs/editor/browser/editorExtensions'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; <del> import { IDebugService, CONTEXT_IN_DEBUG_MODE, CONTEXT_DEBUG_STATE, State, IDebugEditorContribution, EDITOR_CONTRIBUTION_ID, BreakpointWidgetContext, IBreakpoint, BREAKPOINT_EDITOR_CONTRIBUTION_ID, IBreakpointEditorContribution, REPL_VIEW_ID, CONTEXT_STEP_INTO_TARGETS_SUPPORTED, WATCH_VIEW_ID, CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_EXCEPTION_WIDGET_VISIBLE, CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED, CONTEXT_LANGUAGE_SUPPORTS_DISASSEMBLE_REQUEST } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import { IDebugService, CONTEXT_IN_DEBUG_MODE, CONTEXT_DEBUG_STATE, State, IDebugEditorContribution, EDITOR_CONTRIBUTION_ID, BreakpointWidgetContext, IBreakpoint, BREAKPOINT_EDITOR_CONTRIBUTION_ID, IBreakpointEditorContribution, REPL_VIEW_ID, CONTEXT_STEP_INTO_TARGETS_SUPPORTED, WATCH_VIEW_ID, CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_EXCEPTION_WIDGET_VISIBLE, CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED, CONTEXT_LANGUAGE_SUPPORTS_DISASSEMBLE_REQUEST, CONTEXT_FOCUSED_STACK_FRAME_HAS_INSTRUCTION_POINTER_REFERENCE, CONTEXT_CALLSTACK_ITEM_TYPE } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { openBreakpointSource } from 'vs/workbench/contrib/debug/browser/breakpointsView';

Discussion:
Testing As already pointed out The "Open Disassembly View" command is now only visible when the active stackframe has a instructionPointerReference property. This makes it hard to discover. I suggest to have the context menu's "Open Disassembly View" command always visible if a debug adapter has the supportsDisassembleRequest capability. But the command should only be enabled if the active stackframe has a instructionPointerReference property. That results in a more stable user experience. Apart from that we should have the Open Disassembly View command in the command palette.
That's a fair suggestion. However, we are not sure how to disable a command...
commands have clauses and . clause determines if the command is present at all and if it is disabled. So please use the when registering the editor command for disablement.
Also we should consider to introduce a call stack context menu action for the Open Disassembly View.
will fix this.
Change:
} return this.viewZones.shouldSuppressMouseDownOnViewZone(viewZoneId); }, <ins> shouldSuppressMouseDownOnWidget: (widgetId: string) => { if (this._isDisposed) { throw new Error('ViewImpl.pointerHandler.shouldSuppressMouseDownOnWidget: View is disposed'); } return this.contentWidgets.shouldSuppressMouseDownOnWidget(widgetId); }, </ins> getPositionFromDOMInfo: (spanNode: HTMLElement, offset: number) => { if (this._isDisposed) { throw new Error('ViewImpl.pointerHandler.getPositionFromDOMInfo: View is disposed');

Discussion:
VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.
I'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)
PR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.
Change:
"ports.iconRunningProcessForeground": "#369432", "activityBar.background": "#221a0f", "activityBar.foreground": "#d3af86", <ins> "activityBarItem.settingsProfilesBackground": "#47351d", </ins> "sideBar.background": "#362712", "menu.background": "#362712", "menu.foreground": "#CCCCCC",

Discussion:
The original designs had something closer to this for the default background color. IMO it isn't trying to be an icon like the other items and the border makes it feel like an icon vs. a unique element. I also think the background and foreground should be the only customizable elements to start. I think I saw a foreground token, but not sure it was possible to do background yet. <img width="247" alt="CleanShot 2022-09-26 at 16 29 09 src="https://user-"
I also like this more over the border For example here this looks not too different from the actions above even though it is about profiles: <img width="297" alt="image" src="https://user-"
!
I like it but maybe with smaller font size? Here is with for example: !
Current font size goes well with all (emoji, codicons) and also symmetric with activity bar icons.
Change:
/** * Remove all falsy values from `array`. The original array IS modified. */ <del> export function coalesceInPlace<T>(array: Array<T | undefined | null>): void { </del> <ins> export function coalesceInPlace<T>(array: Array<T | undefined | null>): asserts array is Array<T> { </ins> let to = 0; for (let i = 0; i < array.length; i++) { if (!!array[i]) {

Discussion:
open a file from a pull request get an error saying id cannot be read from undefined
this is a regression from
Yes, I too saw this when testing day before yesterday, but as soon as I updated this went away.
Change:
} } <ins> private _writeInitialText(xterm: XtermTerminal, callback?: () => void): void { if (!this._shellLaunchConfig.initialText) { callback?.(); return; } const text = typeof this._shellLaunchConfig.initialText === 'string' ? this._shellLaunchConfig.initialText : this._shellLaunchConfig.initialText?.text; if (typeof this._shellLaunchConfig.initialText === 'string') { xterm.raw.writeln(text, callback); } else { if (this._shellLaunchConfig.initialText.trailingNewLine) { xterm.raw.writeln(text, callback); } else { xterm.raw.write(text, callback); } } } </ins> async reuseTerminal(shell: IShellLaunchConfig, reset: boolean = false): Promise<void> { // Unsubscribe any key listener we may have. this._pressAnyKeyToCloseListener?.dispose(); this._pressAnyKeyToCloseListener = undefined; <del> if (this.xterm) { </del> <ins> const xterm = this.xterm; if (xterm) { </ins> if (!reset) { // Ensure new processes' output starts at start of new line <del> await new Promise<void>(r => this.xterm!.raw.write('nx1b[G', r)); </del> <ins> await new Promise<void>(r => xterm.raw.write('nx1b[G', r)); </ins> } // Print initialText if specified if (shell.initialText) { <del> await new Promise<void>(r => this.xterm!.raw.writeln(shell.initialText!, r)); </del> <ins> await new Promise<void>(r => this._writeInitialText(xterm, r)); </ins> } // Clean up waitOnExit state if (this._isExiting && this._shellLaunchConfig.waitOnExit) { <del> this.xterm.raw.options.disableStdin = false; </del> <ins> xterm.raw.options.disableStdin = false; </ins> this._isExiting = false; } if (reset) { <del> this.xterm.clearDecorations(); </del> <ins> xterm.clearDecorations(); </ins> } }

Discussion:
!
works in OSS !
also works for me in insider's
works for that exact task for me !
It's because of this: Here's the I was using:
This works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !
Change:
}); } <ins> public hasPendingScrollAnimation(): boolean { return Boolean(this._smoothScrolling); } </ins> private _performSmoothScrolling(): void { if (!this._smoothScrolling) { return;

Discussion:
Type: <bBug</bI found this problem in Vim extension when using half page scroll with centered view and smoothScrolling, and reproduce this bug in test clean extension. Without smoothScrolling it works fine. When executing command two times with ~150ms delay second action dont trigger (view stay in position by first ). U can see it on this video, when view in some cases not returned to 31 line from 39. https://user- Reproduce: reproducing i set interval with two timeouts to create delay between two executions and set smoothScrolling. ! VS Code version: Code 1.76.2 (, 2023-03-14T17:55:54.936Z) OS version: WindowsNT x64 10.0.

Modes: Unsupported Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (35)</summaryExtensionVersion ------ better-comments3.0.2 astro-vscode0.28.2 vscode-tailwindcss0.9.11 path-intellisense2.8.4 vscode-css-modules0.4.2 vscode-database-client26.3.4 vscode-eslint2.4.0 es7-react-js-snippets4.4.3 vsc-material-theme-icons2.7.4 prettier-vscode9.10.4 auto-close-tag0.5.14 auto-rename-tag0.1.10 code-runner0.12.0 geril-vim1.25.2 go0.38.0 vscode-graphql0.8.7 vscode-graphql-syntax1.1.0 code-background2.5.4 vscode-docker1.24.0 remote-wsl0.76.1 remote-explorer0.4.0 remote-server1.0.0 material-icon-theme4.25.0 prisma4.12.0 LiveServer5.7.9 rust-analyzer0.3.1463 vscode-styled-components1.7.8 svelte-vscode107.3.0 errorlens3.8.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-icons12.2.0 JavaScriptSnippets1.8.0 material-theme3.15.8 vscode-proto30.5.5 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.77.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
After update to 1.77.1 bug still exists
Thank you for the repro! The root cause is this particular call - introduced via cc That code runs even when the inlayHintsController doesn't do anything and it ends up interrupting the current editor scroll animation.
Change:
const target = e.event.target as HTMLElement; <del> if (target.classList.contains('codicon-notebook-collapsed') || target.classList.contains('codicon-notebook-expanded')) { const parent = target.parentElement as HTMLElement; if (!parent) { return; } if (!parent.classList.contains(this.accessor.prefix)) { return; } if (!parent.classList.contains('property-folding-indicator')) { return; } // folding icon </del> <ins> if (target === this.propertyHeaderContainer || target === this._foldingIndicator || this._foldingIndicator.contains(target) || target === metadataStatus || metadataStatus.contains(target) ) { </ins> const cellViewModel = e.target; if (cellViewModel === this.cell) {

Discussion:
Testing These: ! Look similar, but not quite the same, as these other tree/accordion elements we have ! ! ! Off the top of my head, it probably makes the most sense to align to the tree view both from a styling and interaction POV. For example, the collapsible sections in the notebook diff and only be expanded/collapsed by clicking on the chevron. In tree views/views/settings TOC, you can click anywhere on the containing element. It also looks like I can't focus on the element to expand/collapse with just the keyboard.
Duplicate of
looks good to me (I can click anywhere to expand), but maybe should take another look since I don't see much inconsistency in those screenshots.
Change:
"native-is-elevated": "^0.2.1", "native-keymap": "1.2.5", "native-watchdog": "1.0.0", <del> "node-pty": "0.7.7", </del> <ins> "node-pty": "0.7.8", </ins> "semver": "^5.5.0", "spdlog": "0.7.2", "sudo-prompt": "8.2.0",

Discussion:
Issue Type: <bBug</bThe arguments of my task command are merely ignored whenever there are quotes inside them. Steps to reproduce an executable script that shows the number of arguments that are passed to it. I called it some task in the task the output Even the hello argument is ignored. Remove the quotes around world and the script will work: This bug makes the task feature unusable when quotes are required VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-25T05:31:33.193Z) OS version: WindowsNT x64 10.0. <!-- generated by issue reporter --
which shell (bash) are you using? WSL?
if the default task shell is the same as the default integrated terminal shell, then I am using Git Bash. I have this in
I am able to reproduce this using the following setup: Using ' around world works as expected. here is the shell launch config I use to start the terminal: <img width="1190" alt="capture" src="https://user-"Any advice you can give to make this work for " as quotes. In general the data looks good to me.
recently made a change in this area and might have an idea what's going on with this case.
Possible candidate, marking with September.
Change:
"command": "git.openChange", "title": "%command.openChange%", "category": "Git", <ins> "icon": "$(compare-changes)" }, { "command": "git.openChangeEditor", "title": "%command.openChange%", "category": "Git", </ins> "icon": "$(compare-changes)", "enablement": "scmActiveResourceHasChanges" },

Discussion:
Steps to Reproduce: to a git repository in VS Code a change to a file the SCM viewlet and notice that the Open Changes command is disabled <img width="456" alt="image" src="https://user-"
Change:
editor?: { accessibilitySupport?: 'on' | 'off' | 'auto' }; security?: { workspace?: { trust?: { enabled?: boolean } } }; window: IWindowSettings & { experimental?: { windowControlsOverlay?: { enabled?: boolean }; useSandbox?: boolean } }; <del> workbench?: { experimental?: { settingsProfiles?: { enabled?: boolean } } }; </del> <ins> workbench?: { experimental?: { settingsProfiles?: { enabled?: boolean } }; enableExperiments?: boolean }; </ins> } export class SettingsChangeRelauncher extends Disposable implements IWorkbenchContribution {

Discussion:
a session which was opted into an experiment (eg Control Center) experiments Experiment is still running. (eg Control Center is still rendered) ! !
I think reload is required for the experiment to be disabled. Have you?
If reload is required, we should leverage the mechanism that prompts the user to reload, whenever the setting changes.
Change:
return label; }, getWidgetAriaLabel: () => localize({ key: 'selectBox', comment: ['Behave like native select dropdown element.'] }, "Select Box"), <del> getRole: () => 'option', </del> <ins> getRole: () => isMacintosh ? '' : 'option', </ins> getWidgetRole: () => 'listbox' } });

Discussion:
GitHub Tags: #A11yMAS; #A11yTCS; #A11ySev2; #Device; #Visual Studio Code Client; #BM-VisualStudioCodeClient-MAC-Oct2022; WCAG1.3.1; #Voiceover; #Screenreader; #Info and Relationships; Visual Studio Code Insiders Screenreader: Voiceover Visual studio code editor the command Pallet and type "setting". down-arrow key select user setting. the word "Auto " and select one of the suggestion given by the vs code editor. the "Tab size" and select the option from the auto suggestion. that Voiceover is not announcing the message which appears when focus comes on "Auto". Voiceover is not announcing the message (Remove adjacent quotes ....) which appears when focus comes on "Auto". Voiceover should announce the message (Remove adjacent quotes ....) which appears when focus comes on "Auto". ! !
Reference bug:
I noticed that on macOS on Chromium-based browsers, VoiceOver doesn't read the aria-label of a div if the role of the div is set to "option". I'm wondering whether we could remove the "option" role of the div elements for this specific case, i.e. custom selectboxes on macOS, as a workaround? I can also file an upstream issue with Chromium in the meantime.
I have filed an upstream issue with a min repro (minimal reproducible case)
Verified the bug in the environment: Version: 1.45.0-insider (Universal) Commit: Date: 2023-05-22T05:32:52.588Z VS Code: 1.70.0 Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.4.0 Bug is not fixed and still repro'ing. Could you please reopen this issue.
please try again with today's Insiders.
Tried to download latest insiders but still we get the same version.

Version: 1.45.0-insider (Universal) Commit: Date: 2023-05-26T05:31:07.551Z VS Code: 1.70.0 Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.4.0 Issue is still repro'ing. PFA for reference Could you please share the downloading link for the latest insiders where fixes are available for this issue.
regressed:05-29-23;
Hi that doesn't look like the right version of Insiders to me. Please try again after downloading the latest Insiders from
GithubTags:#Regressed:05-31-23;#Closed; Verified the bug in the environment: Version: 1.79.0-insider (Universal) Commit: Date: 2023-05-31T03:12:18.068Z Electron: 22.5.4 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 22.5.0 Bug is fixed and does not repro. Hence closing the bug. PFA for reference.
Change:
if (pick !== currIndex) { // user chooses another mimetype let index = this.viewCell.outputs.indexOf(output); <del> let nextElement = index + 1 < this.viewCell.outputs.length ? this.outputElements.get(this.viewCell.outputs[index + 1]) : undefined; </del> <ins> let nextElement = index + 1 < this.viewCell.outputs.length ? this.outputElements.get(this.viewCell.outputs[index + 1])?.element : undefined; </ins> this.outputResizeListeners.get(output)?.clear(); <del> let element = this.outputElements.get(output); </del> <ins> let element = this.outputElements.get(output)?.element; </ins> if (element) { this.templateData?.outputContainer?.removeChild(element); this.notebookEditor.removeInset(output);

Discussion:
Notice the cell goes beyond the right margin. Seems to happen for all cells
is it related to the indentation change?
I don't think there's an issue here anymore? I did push a change to ensure that a line of text with no whitespace will break and not overflow. But I don't see any other issues with overflowing horizontally. I do see plain text outputs overflowing if I resize the editor to be narrower...
Change:
@IThemeService themeService: IThemeService, @IContextViewService contextViewService: IContextViewService ) { <del> super(null, action, [], 0, contextViewService, { ariaLabel: nls.localize('outputs', 'Outputs') }); </del> <ins> super(null, action, [], 0, contextViewService, { ariaLabel: nls.localize('outputChannels', 'Output Channels.') }); </ins> let outputChannelRegistry = Registry.as<IOutputChannelRegistry>(OutputExt.OutputChannels); this.toDispose.push(outputChannelRegistry.onDidRegisterChannel(() => this.updateOtions(this.outputService.getActiveChannel().id)));

Discussion:
Tweak label option for outputs action bar select box as "Output Channels." for better readability.
Fixed with PR