jiebi/CodeConvo huggingface dataset:
Change:
fi __vsc_preexec() { <ins> __vsc_status="$?" </ins> eval ${__vsc_original_trap} PS1="$__vsc_prior_prompt" if [ -z "${__vsc_in_command_execution-}" ]; then

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.2 OS Version: WSL, 'regular' Linux, Mac Steps to Reproduce: Turn on experimental shell integration () bash as the shell, and have a prompt command that uses "$?" as part of the prompt text. the command 'true' the command 'false' that the prompts should have had '0' and '1' as the replacement. it is always '0' with shell integration. OK. In the function , consider this loop: And perhaps something like this might fix it: is probably a really hacky way to set $? - but it's what I've used over the years. Note: This all goes away if were to be accepted.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Since I think we have already actioned this may not be a problem anymore
I suspect it will still be a problem. would only have addressed the issue if were adopted as it goes to great lengths to preserve state variables. Since the fix in was to bascially push/pop the trap DEBUG state, it probably doesn't help the exit $? status retention around the wrapped prompt.
good to know, thanks
to verify: add to your and with shell integration enabled, ensure that it is correct. for ex, run a command which fails (has an exit code). the status should reflect that.
Yes.

This bug, as reported - without a DEBUG trap is fixed. So this can probably be closed. It still seems to be incorrect if there is a DEBUG trap in place. I have details to
Change:
import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { Range } from 'vs/editor/common/core/range'; import { IEditorContribution } from 'vs/editor/common/editorCommon'; <del> import { IModelDecorationOptions, IModelDeltaDecoration, OverviewRulerLane, TrackedRangeStickiness } from 'vs/editor/common/model'; </del> <ins> import { GlyphMarginLane, IModelDecorationOptions, IModelDeltaDecoration, OverviewRulerLane, TrackedRangeStickiness } from 'vs/editor/common/model'; </ins> import { localize } from 'vs/nls'; import { ILogService } from 'vs/platform/log/common/log'; import { registerColor } from 'vs/platform/theme/common/colorRegistry';

Discussion:
<img width="288" alt="image" src="https://user-"This leads to the editor shifting to the right every time I pause, because it's adding an editor gutter. We actually already have a combo decoration that shows the two things together. I don't actually know exactly how that works but can look it up if you need it. Actually this combo decoration doesn't exist for all breakpoint types, which is annoying, but that's an issue for me
If you have a code pointer that would be awesome, I wasn't aware we had a notion of combined decorations today. As far as I know in the past we merged the classnames for any decorations that wanted to appear in the glyph margin
So when I see this <img width="76" alt="image" src="https://user-"there is a and an , that is where the different colors come from I think the comes from the normal decoration, then we set the content here and color here It seems like we are hacking editor decorations with css a bit
Maybe the solution is just making sure that whatever logic puts breakpoints in their own lane applies to all debug decorations though, so these all get their own lane and its the same, if that makes sense
The actual stackframe decorations come from here
The trouble is now we also have this notion of a to ensure e.g. that testing decorations always render atop other decorations, so if there are multiple decorations in the same lane we pick the first one and discard the rest. To show those decorations together, I think I have to restore the old behavior so that decorations with the same get the classnames combined like in the previous stable. But as you said that only works because of some CSS hackery, maybe we also want a more formalized way to combine decorations.
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.1.0-beta.82", "xterm-addon-canvas": "0.3.0-beta.33", </del> <ins> "xterm": "5.1.0-beta.87", "xterm-addon-canvas": "0.3.0-beta.35", </ins> "xterm-addon-search": "0.11.0-beta.7", "xterm-addon-unicode11": "0.5.0-beta.5", <del> "xterm-addon-webgl": "0.14.0-beta.46" </del> <ins> "xterm-addon-webgl": "0.14.0-beta.50" </ins> } }

Discussion:
Testing Code insiders, set how the inactive selection colour is stronger than the active selection colour I can only reproduce this with "canvas", all other gpu acceleration options work fine. Terminal focused ! Terminal not focused !
Upstream:
Change:
window.document.body.addEventListener('click', handleInnerClick); window.document.body.addEventListener('focusin', checkOutputInputFocus); <ins> window.document.body.addEventListener('focusout', handleOutputFocusOut); </ins> interface RendererContext extends rendererApi.RendererContext<unknown> { readonly onDidChangeSettings: Event<RenderOptions>;

Discussion:
Repro: 3 cells the middle one the empty space at the bottom of the notebook undo it doesn't work, clicking in between cells does work though
Specifically, undo only works when focused on a cell container. Focus within a cell (code or markdown) editor and in the notebook editor both do not handle the undo.
Change:
}); const allowedTooltips = isProposedApiEnabled(this.extension, 'quickPickItemTooltip'); <del> const allowedIcons = isProposedApiEnabled(this.extension, 'quickPickItemIcon'); </del> const pickItems: TransferQuickPickItemOrSeparator[] = []; for (let handle = 0; handle < items.length; handle++) {

Discussion:
Would it be possible to allow for extensions to provide icons in s? At the moment we can use via the syntax, but if we want to provide a custom icon that is more complex (perhaps we can do that be providing a font and a partial product icon theme?). With a , we can pass in an optional icon path: Could we add this to QuickPickItem too? Based on the quick open input, there is already space afforded in the UI for the icon, so it would be useful if extensions to provide one.
Related to which asks for the ability to specify filetype icons.
Proposal: It looks a bit off using squares: !
Example with circles for reference: !
For anyone curious, circles are possible by using data URIs: Example and copied here for reference:
Change:
if (this._currentChoice !== activeChoice.choice) { this._currentChoice = activeChoice.choice; <ins> this._choiceCompletions.enable(); </ins> // trigger suggest with the special choice completion provider queueMicrotask(() => { <del> showSimpleSuggestions(this._editor, this._choiceCompletionItemProvider!); </del> <ins> showSimpleSuggestions(this._editor, this._choiceCompletions!.provider); </ins> }); } }

Discussion:
This problem still occurs even if you disable all extensions. This problem was confirmed in Markdown file. below the snippet (it contains a snippet choice) below the code in Markdown file snippet in Markdown file I expected to see link label suggestion, but it does not display link label suggestion... Included by snippet choice reproduces the issue. It is not displayed even if is pressed. Gif demo: ! VS Code Windows 11
Sorry but I am unaware of link label suggestions. What are those and where do they usually come from?
I'm sorry, I had my own way of saying it. I don't know the correct terminology, but I'll show you an example in action. the following markdown your cursor inside the second ! I haven't been able to find any release notes for this feature, but it's a feature in VS Code and not coming from an Installed extension. This feature doesn't work within certain snippets.
I can reproduce. Looks like the choice suggest provider is staying active despite its placeholder not being active anymore
Using a snippet seems to break label suggestions until the editor is reloaded. Even reopening the file doesn't fix it:
repro steps please
the snippet from the original issue in your global snippets a new markdown file with the contents as in the video, you can get completions until the moment you use the snippet
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
]; assertDiff(original, modified, expected, false, false, false); }); <ins> test('issue #169552: Assertion error when having both leading and trailing whitespace diffs', () => { const original = [ 'if True:', '    print(2)', ]; const modified = [ 'if True:', 'tprint(2) ', ]; const expected = [ createLineChange( 2, 2, 2, 2, [ createCharChange(2, 1, 2, 5, 2, 1, 2, 2), createCharChange(2, 13, 2, 13, 2, 10, 2, 11), ] ), ]; assertDiff(original, modified, expected, true, false, false); }); </ins> });

Discussion:
Version: 1.75.0 from main set "diffEditor.ignoreTrimWhitespace": falseFile 1, using 4 spaces as indentationFile 2, using tab as indentationSelect both files and invoke Dev tools pop up on debugger statement `
I'm having trouble reproducing. Have you customized other settings? <img width="866" alt="image" src="https://user-"
Blocks
I can reproduce when typing a in one of the sides: <img width="865" alt="image" src="https://user-"
It looks like there's an assertion checking that these produced diffs should be reported in a different shape (introduced via )
You are correct, there needs to be additional spaces in file 2 after . Sorry for that. I fixed the description
Change:
return new Range(this.startLineNumber, 1, this.endLineNumberExclusive - 1, Number.MAX_SAFE_INTEGER); } <ins> /** * @deprecated Using this function is discouraged because it might lead to bugs: The end position is not guaranteed to be a valid position! */ </ins> public toExclusiveRange(): Range { return new Range(this.startLineNumber, 1, this.endLineNumberExclusive, 1); }

Discussion:
Type: <bBug</bStep 1: Create a file named with this content: Step 2: create an empty file named Step 3: Move with a terminal in the folder containing the files and run Step 4: Click on the arrow button and see that it doesn't work ! VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (38)</summaryExtensionVersion ------ vscode-nginx-conf0.3.5 swagger-viewer3.1.2 freezed0.9.6 ccs-flutter-color1.2.4 dart-code3.86.0 flutter3.86.0 jquerysnippets0.0.1 es7-react-js-snippets4.4.3 vscode-html-css2.0.9 copilot1.180.0 copilot-chat0.14.1 vscode-github-actions0.26.2 vscode-pull-request-github0.86.1 gc-excelviewer4.2.59 todo-tree0.0.226 vscode-nginx-conf-hint0.3.1 latex-workshop9.20.0 vscode-edit-csv0.9.1 plantuml2.18.1 vscode-peacock4.2.2 dotenv1.0.1 vscode-docker1.29.0 debugpy2024.5. isort2023.13. python2024.5. vscode-pylance2024.4.102 remote-containers0.354.0 cpptools1.19.9 vscode-thunder-client2.21.11 nginx-formatter0.0.13 vscode-xml0.26.1 vscode-yaml1.14.0 scala0.5.7 markdown-preview-enhanced0.8.13 even-better-toml0.19.2 vscode-icons12.7.0 vscode-nginx0.7.2 txt-syntax0.2.2 </details
working on this
Oh wow I did not realize this was fixed. I've been working on it and just submitted a PR for a similar issue.
My solution was also very similar.
sorry! It was tricky to fix though.
Change:
} .monaco-editor .monaco-editor-overlaymessage .message { <del> padding: 1px 4px; color: var(--vscode-inputValidation-infoForeground); background-color: var(--vscode-inputValidation-infoBackground); </del> <ins> padding: 2px 4px; color: var(--vscode-editorHoverWidget-foreground); background-color: var(--vscode-editorHoverWidget-background); </ins> border: 1px solid var(--vscode-inputValidation-infoBorder); <ins> border-radius: 3px; </ins> } .monaco-editor .monaco-editor-overlaymessage .message p {

Discussion:
Testing Tiniest of nits, and perhaps this is inherited from all hovers, but I felt like the hover disappeared too quickly. If I was reading particularly slowly or looked away and then back at the message, I might've missed it.
felt the same, I think using the workbench hover infra would help.
Also, it disappears when you still hover on it: !
I think given the new complexity of this hover and the actions we should do a tactical fix here. I suggest to remove the timer that removes the message automatically after 3 seconds: There are still other listeners in place to hide the message, so I think we are good.
makes sense.
trying to verify: "readonly hover" means "hover in readonly files" ?
best to verify would be in repo open a file from folder and try to edit in such a file. You should see a hover with a link.

Testing This would benefit from an underline instead of the bold treatment to match the rendering we use in the workspace banner links (e.g. restricted mode) <img width="490" alt="CleanShot 2023-06-26 at 21 53 54 src=""
I also think its hard to discover, but I think we are not using underline for links in hovers so far?
We also do not show underlines in other places we show markdown in hovers: <img width="485" alt="image" src=""I used bold because the blue background of the hover made the contrast poor with our usual blue link color. We could use another color instead though.
I think the intent of the blue color in the message widget is to draw more attention, i.e. giving the signal of an information message vs. just being a normal tooltip. But maybe we can make the background color of the widget the same as hovers and then user blue color for links. I think that way we can still keep the blue border but it will not collide with the links.
Sample with a mix of hover colors and info colors for border: <img width="764" alt="image" src=""
And in dark theme: ! Changes I did: use hover colors use the same border radius of as in editor hovers allow to tab into the message with keyboard to invoke the link within
Change:
return this.model.findClosest(resource); } <ins> findClosestRoot(resource: URI): ExplorerItem | null { const parentRoots = this.model.roots.filter(r => this.uriIdentityService.extUri.isEqualOrParent(resource, r.resource)) .sort((first, second) => second.resource.path.length - first.resource.path.length); return parentRoots.length ? parentRoots[0] : null; } </ins> async setEditable(stat: ExplorerItem, data: IEditableData | null): Promise<void> { if (!this.view) { return;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --Related Issues: <!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Linux x64 5.8.0-44-generic Steps to Reproduce: a root folder (files-exclude-sample) that folder create two nested folders (child1, child2) root folder (files-exclude-sample), create a workspace definition file (files-exclude-) root folder (files-exclude-sample), create a .vscode folder .vscode folder create a file to previous steps, just clone this GitHub repo: VSCode, open the workspace (files-exclude-) looks ok. You have tree root folders (files-exclude-sample, child1 and child2) ! you expand all three folder you can see something like ! specified in root folder , child1 and child2 are excluded from child1 folder child1 folder is collapsed (not removed from explorer tree) and it appears inside root folder (files-exclude-sample) folder ! expected behavior is that child1 is not collapsed and it does not appear inside root folder <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
the owner of the file explorer is
I acknowledge this issue. MR workspace support with when one root folder is a subfolder of another root folder has some issues. If somebody is passionate about fixing this let me know and I can provide pointers
Created fixing this
Thanks to a great pr by this is now fixed
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> .monaco-workbench .merge-editor .code-view>.title { </del> <ins> .monaco-workbench .merge-editor .code-view > .header { </ins> padding: 0 10px; height: 30px; display: flex; align-content: center; <ins> overflow: hidden; </ins> } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span { </ins> align-self: center; text-overflow: ellipsis; overflow: hidden;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !
Change:
})); if (this._dimension) { <del> this._list.layout(this._dimension.height, this._dimension.width); </del> <ins> this._list.layout(this.getBodyHeight(this._dimension.height), this._dimension.width); </ins> } else { this._list.layout(); }

Discussion:
a notebook where two cells take up more than the scrollable region between the two cells, note how far down the region scrolls the panel off/on between the two cells again the scroll placement is different because returns a different value. !
Change:
} } <ins> if (!enumToUse && (prop.enumItemLabels || enumDescriptions || enumDescriptionsAreMarkdown)) { console.error(`The setting ${key} has enum-related fields, but doesn't have an enum field. This setting may render improperly in the Settings editor.`); } </ins> result.push({ key, value,

Discussion:
I don't have precise repro steps, but maybe: search for something scroll all the way down clear search searching animation persists
I'm unable to repro the issue. Let me know if there's any devtools errors next time it occurs.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
just reproduced this and will give us the logs
In the case of JooYoung, the search wasn't performed at all.
just reproduced myself
The error likely means there's an array that's undefined, but I'll probably have to reproduce the issue on OSS to actually see what's going on Example REPL run
it takes much longer than expected to stop - is there a long happening for input change or... ?
I'm unable to repro on the latest Insiders on Windows or macOS. For me, clearing the search stops it immediately.
Change:
if (marker.tags.indexOf(MarkerTag.Unnecessary) !== -1) { inlineClassName = ClassName.EditorUnnecessaryInlineDecoration; } <ins> if (marker.tags.indexOf(MarkerTag.Deprecated) !== -1) { inlineClassName = ClassName.EditorDeprecatedInlineDecoration; } </ins> } return {

Discussion:
Now that has been to the API, I would like to support the proposal from to use it for tagging deprecated items. I figure the associated styling might be a strikethrough as proposed in but you guys can work that out separately.
I would be interested in helping out here with this and perhaps even . Without a lot of context, I assume this issue is specifically to add a new enum member here: I could open a PR that adds a member, if that's the case. edit: Looks like more applicable location would be and then opening a similar PR to
Yes, is the way to go. Find your way along usages/implementations of
Thanks, I'll work on that today.
Leaving this open so that we discuss this in the API sync
API has been finalised.
Change:
export const DEFAULT_COMMANDS_TO_SKIP_SHELL: string[] = [ TerminalCommandId.ClearSelection, TerminalCommandId.Clear, <ins> TerminalCommandId.CopyAndClearSelection, </ins> TerminalCommandId.CopySelection, TerminalCommandId.CopySelectionAsHtml, TerminalCommandId.CopyLastCommand,

Discussion:
This has bugged me for years but wasn't sure how we should handle it. I think we should do this: ctrl+shift+c: works as it does now, when there is a selection this will copy the selection and retain it ctrl+c: if this is bound to copy when there is a selection (Windows), it should copy the selection and clear it, such that the next ctrl+c will send an interrupt.
On Unix (MacOS and Linux), is used alongside to control the run sending intetrupt signal to the process for the first and suspend for the other. I ended up on this ticket because Ctrl-C was not working to stop the Python debugger with CTRL-C in vscode. Windows version of the debugger uses Ctrl-D for that, but don't be confused that is only for Windows. Clearly something wrong is happening with Ctrl-C on vscode terminal for sure. While looking at this bug may it be possible to address the Ctrl-C not being send to the terminal?
ctrl+c does send SIGINT, it works a little differently on Windows though; if there is a selection it will copy. The proposal here is to copy and clear the selection, such that the next ctrl+ sends SIGINT. You can verify that ctrl+c is sending SIGINT by running the toggle escape sequence logging command as that will show what gets sent to the process.
This is a minor feature that would be good to call out in the release notes.