jiebi/CodeConvo huggingface dataset:
Change:
import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider, IAccessibleViewService } from 'vs/platform/accessibility/browser/accessibleView'; import { AccessibilityVerbositySettingId } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; <del> import { IDebugService, IReplElement } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import { IReplElement } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { IAccessibleViewImplentation } from 'vs/platform/accessibility/browser/accessibleViewRegistry'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { getReplView, Repl } from 'vs/workbench/contrib/debug/browser/repl';

Discussion:
Testing a js file at the root that something. a launch config to run it using node like: it and see the logs persist in the debug console.] to use alt+f2 to read it 'no debug session is active' !
is there a way to get the from an inactive session?
Reviewing the code some more I think the more reliable way to get the displayed session is to use . Currently it uses viewModel.focusedSession which won't include ended sessions as Andrea found
I think that will be a little involved, so deferring
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
.terminal-scroll-highlight { left: 0; right: 0; <ins> border-left: 5px solid #ffffff; border-left-width: 5px !important; } .terminal-scroll-highlight-outline { </ins> border: 1px solid #ffffff; }

Discussion:
Testing When I use cmd+up/down to navigate between POIs in task output, the blue box renders for a second on the item I have selected, but then disappears. I didn't understand what was happening to the focus border.
that is by design.
This has come up before, I think you had an idea to improve this?
I had the same experience in where I was on a slow machine. I think I had suggested just using a line on the side (like our activity bar) that remains until your focus changes: <img src="https://user-"
To the left of the command decorations? ! I like how visible the outline is when jumping between commands, so we could keep that as is and just also show the persistent line? !
yea I'd be open to trying that out, I think using both might be a bit overkill but just having the single line can also be hard to notice.
Change:
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import { IWorkspaceTagsService } from 'vs/workbench/contrib/tags/common/workspaceTags'; <ins> import { getErrorMessage } from 'vs/base/common/errors'; </ins> export class UserDataProfilesWorkbenchContribution extends Disposable implements IWorkbenchContribution {

Discussion:
Testing an invalid profile file (for example, by deleting a closing ) importing it Bug We show the error notification: ! This doesn't mention anything about profiles. I suggest showing an error that says the profile cannot be read
A similar error shows when you mistype the url for a profile (or are offline). In this case though you see failed: !
Change:
* Info if the link looks like it is for an anchor: `[](#header)` */ readonly anchorInfo?: AnchorContext; <ins> /** * Indicates that the completion does not require encoding. */ readonly skipEncoding?: boolean; </ins> } function tryDecodeUriComponent(str: string): string {

Discussion:
Issue Type: <bBug</bTrigger path suggestions inside a markdown link that uses angle brackets: Bug No suggestions show up VS Code version: Code - Insiders 1.69.0-insider (Universal) (, 2022-06-17T05:16:27.373Z) OS version: Darwin x64 21.5.0 Restricted Mode: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Relevant code:
So I'm new to this project. Do I ask if I can be assigned this bug? Or is it whoever submits an solution first makes the pull request?
You can ask, I am currently working on this now - but you can try as well.
Alright thanks. So in general I can just work on a problem that catches my attention and ask/answer questions when appropriate?
Yes pretty much, you can work on any problem or issue that you would like.
What specifically is the bug here? Is the desired behavior where when you type a list of path links should appear?
Yes, it should work the same way it does if you remove the from the link One extra note: spaces should not be encoded inside links so for extra points make accepting a file suggestion with spaces in the name inserts a real space instead of
How do I recompile typescript files so vscode reflects the changes I made? Is it or ?
Is this the behavior you were looking for?
Change:
return this.doReadFile(provider, resource, options, token); } <del> private async doReadFileAtomic(provider: IFileSystemProviderWithFileReadWriteCapability | IFileSystemProviderWithOpenReadWriteCloseCapability | IFileSystemProviderWithFileReadStreamCapability | IFileSystemProviderWithFileReadCapability, resource: URI, options?: IReadFileOptions, token?: CancellationToken): Promise<IFileContent> { </del> <ins> private async doReadFileAtomic(provider: IFileSystemProviderWithFileReadWriteCapability | IFileSystemProviderWithOpenReadWriteCloseCapability | IFileSystemProviderWithFileReadStreamCapability, resource: URI, options?: IReadFileOptions, token?: CancellationToken): Promise<IFileContent> { </ins> return new Promise<IFileContent>((resolve, reject) => { this.writeQueue.queueFor(resource, this.getExtUri(provider).providerExtUri).queue(async () => { try {

Discussion:
Refs: I do not understand this condition: How does that make sure a method exists? The only check for this that is valid currently is , the is just a detail of the file system and not a capability.
This looks like an actual typo to me or missing code review, not sure the consequences, as it could lead to errors when wrongly asserting, so maybe moving to August for investigation.
TLDR I misunderstood how the declared capabilities relate to the actual declared methods and the meaning of . For context, this change came in through and the intention of this change was to support the scenario where an has declared but not : since is optional in the interface and the capability requires both and to be implemented: I made this change because when implementing a with but not , this would result in throwing here: I see how it's possible that a which has check does not have a method implemented. Additionally I see that we have other examples of how to handle the requirement of a readonly filesystem which implements both and , e.g.: I am reverting Apologies for the incorrect code change and thank you for pointing this out.
Change:
import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Extensions, IViewContainersRegistry, IViewsRegistry, ViewContainer, ViewContainerLocation } from 'vs/workbench/common/views'; <del> import { Attributes, AutoTunnelSource, IRemoteExplorerService, makeAddress, mapHasAddressLocalhostOrAllInterfaces, OnPortForward, PORT_AUTO_FORWARD_SETTING, PORT_AUTO_SOURCE_SETTING, PORT_AUTO_SOURCE_SETTING_HYBRID, PORT_AUTO_SOURCE_SETTING_OUTPUT, PORT_AUTO_SOURCE_SETTING_PROCESS, TUNNEL_VIEW_CONTAINER_ID, TUNNEL_VIEW_ID, TunnelSource } from 'vs/workbench/services/remote/common/remoteExplorerService'; </del> <ins> import { Attributes, AutoTunnelSource, IRemoteExplorerService, makeAddress, mapHasAddressLocalhostOrAllInterfaces, OnPortForward, PORT_AUTO_FORWARD_SETTING, PORT_AUTO_SOURCE_SETTING, PORT_AUTO_SOURCE_SETTING_HYBRID, PORT_AUTO_SOURCE_SETTING_OUTPUT, PORT_AUTO_SOURCE_SETTING_PROCESS, Tunnel, TUNNEL_VIEW_CONTAINER_ID, TUNNEL_VIEW_ID, TunnelSource } from 'vs/workbench/services/remote/common/remoteExplorerService'; </ins> import { forwardedPortsViewEnabled, ForwardPortAction, OpenPortInBrowserAction, TunnelPanel, TunnelPanelDescriptor, TunnelViewModel, OpenPortInPreviewAction, openPreviewEnabledContext } from 'vs/workbench/contrib/remote/browser/tunnelView'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';

Discussion:
Testing I'm not clear on what unforwarding a port means so this maybe expected, but we do detect that the process is no longer running but it still appears in the list: !
can you please provide the steps you used to get here? If port forwarding is properly set (setting + reload) then yes, the port should be unforwarded and no longer appear in the list.
Run the above Python script in integrated terminal when using Remote-SSH, it should start appearing in the list along with process ID under "Running process" column. Kill process using in a separate terminal.
Also confirming I made sure this was done as well.
Thank you for the steps!
When verifying, please test that the port is unforwarded with both and are used.
The port is not unforwarded when is used. It is however unforwarded when is used. I'm testing with the vscode-remote-try-node repo and the default launch config.
The fix works for me though, with the original Python script I provided.
I'm not able to reproduce this. It's possible for what you describe to occur if the process is terminated before we have a chance notice that it's running. If you see this again can you please set the log level to debug, repro, and share logs from Remote Extension Host and Window? Closing again for testing.
I am unable to reproduce the issue with vscode-remote-try-node on Codespaces or Dev Containers, though it did take a bit longer for the port to close on Codespaces. Marking as verified.
Change:
/* NOTE: height is also used in searchWidget.ts as a constant*/ .search-editor .search-widget .monaco-inputbox > .ibwrapper > textarea.input { overflow: initial; <del> height: 24px; /* set initial height before measure */ </del> <ins> height: 26px; /* set initial height before measure */ </ins> } .search-editor .monaco-inputbox > .ibwrapper > textarea.input {

Discussion:
Perhaps due to semi-opaque color being applied to multiple layers within the input: <img width="210" alt="CleanShot 2022-12-15 at 11 28 11 src="https://user-"<img width="289" alt="CleanShot 2022-12-15 at 11 28 23 src="https://user-"
The source control message input background does not seem to use color customization at all.
I saw it in there, but it's a fairly complex component under the hood and (I think) multiple layers of the component use it. Because the color is semi-opaque it's appearing brighter than it should be after mixing with one layer with another.
You can reproduce & verify that the colour is not applied to this particular input by setting color customization in your settings JSON to a bright red: Observe all other inputs having bright red backgrounds but the commit message input background still having the same background as the surrounding panel's background.
This is what I am seeing with the built-in theme, it looks like it completely blends with the panel's background. For me this is happening with all themes, built-in & third-party - the input's background inherits the panel's background and cannot be customised at all. !
It works for me. I don't see the behavior you do with a transparent background. I'm also noting that you have a different typeface used for the placeholder. That leads me to believe there is something else going on. Are you using any extensions that manipulate VS Code e.g. customize UI? <img width="314" alt="CleanShot 2022-12-15 at 13 26 22 src="https://user-"In any case this will be fixed by . I'd recommend opening up a separate issue for your specific problem.
It works for me too when I place SCM panel to the left sidebar, but when SCM panel is placed to the right sidebar then background colour theming is ignored on the input. I do not see this problem mentioned in . ! !
That one I can indeed repro. Can you file a new issue for that?
Done! Submitted as .
Change:
const session = await this._inlineChatSessionService.createSession( editor, <del> { editMode: EditMode.LivePreview }, </del> <ins> { editMode: EditMode.Live }, </ins> token );

Discussion:
We believe is better than livePreview and therefore the default should change. Also we want to retire livePreview gracefully, e.g remove the option and then the implementation
Verify that defaults to
Change:
Registry.as<IConfigurationMigrationRegistry>(WorkbenchExtensions.ConfigurationMigration) .registerConfigurationMigrations([{ <ins> key: AccessibilityVoiceSettingId.AutoSynthesize, migrateFn: (value: boolean) => { let newValue: string | undefined; if (value === true) { newValue = 'on'; } else if (value === false) { newValue = 'off'; } return [ [AccessibilityVoiceSettingId.AutoSynthesize, { value: newValue }], ]; } }]); Registry.as<IConfigurationMigrationRegistry>(WorkbenchExtensions.ConfigurationMigration) .registerConfigurationMigrations([{ </ins> key: 'accessibility.signals.chatResponsePending', migrateFn: (value, accessor) => { return [

Discussion:
Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Makes sense cc
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
would you, yourself, enable this? I worry about turning off regions.
I don’t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).
That makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,
Yes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.
do you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.
That happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.
I use a separate sound card for my screen reader.
what are some verification steps for this issue?

enable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response
I am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.
Sorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.
Change:
this._workspace = setup[4]; } <del> protected _showOutput(runSource: TaskRunSource = TaskRunSource.User): void { </del> <ins> protected _showOutput(runSource: TaskRunSource = TaskRunSource.User, userRequested?: boolean): void { </ins> if (!VirtualWorkspaceContext.getValue(this._contextKeyService) && ((runSource === TaskRunSource.User) || (runSource === TaskRunSource.ConfigurationChange))) { <del> this._notificationService.prompt(Severity.Warning, nls.localize('taskServiceOutputPrompt', 'There are task errors. See the output for details.'), [{ label: nls.localize('showOutput', "Show output"), run: () => { this._outputService.showChannel(this._outputChannel.id, true); } }]); </del> <ins> if (userRequested) { this._outputService.showChannel(this._outputChannel.id, true); } else { this._notificationService.prompt(Severity.Warning, nls.localize('taskServiceOutputPrompt', 'There are task errors. See the output for details.'), [{ label: nls.localize('showOutput', "Show output"), run: () => { this._outputService.showChannel(this._outputChannel.id, true); } }]); } </ins> } }

Discussion:
Run "Show task log" command Get a notification, "there are task errors", click "show output" I don't see any log or errors ! Heard something about task logging during standup and noticed this.
Oh actually, the task changes didn't make it into insider's today. So not convinced this is a bug or related to the changes. Will investigate
Anything interesting with your task config/ had you made changes to it?
No, I see this in every window currently. for example, in a single-folder window with the vscode repo
My task changes went in 10 hrs ago and the latest build was 18 hrs ago.
I can reproduce in an old stable
Change:
} focusList(); list.focusPrevious(); <ins> alertFocusChange(notificationIndex, length, 'previous'); </ins> renderAccessibleView(); }, verbositySettingKey: AccessibilityVerbositySettingId.Notification,

Discussion:
Testing Press alt+F2, VoiceOver starts reading the response Press alt+], the view shows the next response but VoiceOver is still reading that response and it never reads the next response Maybe related, but sometimes, it also doesn't read the response when I press alt+F2. It will say "you are now on a text area" and just sit there. Then, it only wants to read the text a single character at a time when I move the cursor.
Actually, I believe this might be working as expected - I have to move the cursor for the screen reader to move on to the next content. and could you pls let us know if this is a bug or working as expected?
Unfortunately, this is a voiceover issue, but I believe last time we something like this it was resolved my slightly increasing the wait time for certain focus event. I don't remember the full context and cannot find the issue right now. does it sound familiar? It was related to the opening and closing of the contextual help I believe.
Great recall the issue you are talking about is
Correct. I believe it could be the same underlying cause. By the way, having to move the cursor to read content is totally fine as you described. the real issue is that Voiceover is not announcing the change of context.
Makes sense - because without that announcement, you wouldn't know to move your cursor
I wonder if we have a way to calculate the total number of responses. if we do, we could issue an alert announcing position information when we move back and forth. This would resolve the lack of context for macOs and improve the experience in the other platforms. Thoughts?
Yes that makes sense to me - I linked an issue where this is a request for the notification a11y view and we could also support this for the responses
It might have to be an August thing - I'll investigate.
this is also an issue for notifications
I think we have to go with what you suggested i tried a bunch of hacks and setTimeouts and it didn't work
I think it could make the feature more helpful for all platforms. Moving between suggestions is right now a bit confusing because I can't tell for sure if the one on focus is the last one, or if it truly moved to a different one after pressing the command.

In the copilot chat panel, for example, I find much more practical and easier to simply move to the list of responses and go on from there. In addition, hacking assistive technology rarely justifies the effort, and often leads to undesirable outcomes that are not easy to anticipate.
it seems focus still gets trapped initially - even alert isn't taking precedent. i'm hoping it's just what I'm experiencing. about to make a PR with a change that does this for notifications and chat responses
What do you mean it gets trapped? Do you want me to review something. I have half an hour until next meeting.
yes, the linked PR please sorry I have been doing a lot atm
Verified by with the follow up item of to be addressed in August
Change:
const options = { base: mergeUris.base, <del> input1: isRebasing ? ours : theirs, input2: isRebasing ? theirs : ours, </del> <ins> input1: isRebasing ? current : incoming, input2: isRebasing ? incoming : current, </ins> output: uri };

Discussion:
Currently in merge conflict and in the SCM view we talk about and changes, but the new Merge Editor talks about and -- IMO we should align to the and terms.
The opener of the merge editor is in control of the labels. Thus, this can easily be changed in the git extension. Incoming and Current makes sense for conflicts when merging in a remote branch, but not when applying stashes (though in that case "Theirs" and "Mine" also doesn't make much sense).
I always just think of it as there are always changes (from a merge, stash, etc) that are being incorporated (incoming) into the current state.
Change:
resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-7.0.1.tgz#8118a32b02735dccd14f893b495fa5389ad7de79" integrity sha512-zQ5U/nuXAAMsh691FtV0wPz89nSkHbs+IQV8FDk+wew9BlSDhf4UmWGlWJfTR2Ti6xZv87Tj5fENzKf6Qk7aLw== <del> xterm-addon-search@0.9.0-beta.37: version "0.9.0-beta.37" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.37.tgz#84a020f03b2cacc5afac78ca6ff2f1eb86fb6710" integrity sha512-bfeFgKJkDYyIgqpWiV1oWYqDiTo+SHTeIPEbpOfxDr97pc3PtDF1Tyd79PrvJNfoxaV3VMUo//UEOy4D+KY9OQ== </del> <ins> xterm-addon-search@0.9.0-beta.39: version "0.9.0-beta.39" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.39.tgz#e8376e1485ee7d763c07d1a8f1354114f65b3e3e" integrity sha512-h45wkecgfqXXoAUqgNytAfSd6g0xNT6rZy/enVaEU0aes7QoL9pxHUKkCry8PP6hs03Slk0VxQ4AGsbSZGvK/w== </ins> xterm-addon-unicode11@0.4.0-beta.3: version "0.4.0-beta.3"

Discussion:
Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification