jiebi/CodeConvo huggingface dataset:
Change:
} else { this._workingCopy = await this._workingCopyManager.resolve({ untitledResource: this.resource, isScratchpad: this.scratchPad }); } <ins> this._workingCopy.onDidRevert(() => this._onDidRevertUntitled.fire()); </ins> } else { this._workingCopy = await this._workingCopyManager.resolve(this.resource, options?.forceReadFromFile ? { reload: { async: false, force: true } } : undefined); this._workingCopyListeners.add(this._workingCopy.onDidSave(e => this._onDidSave.fire(e)));

Discussion:
a new notebook (or new image with Luna editor) and also a new text file all the editors dirty hotexit is off the window, selecting "don't save" when prompted to revert all working copies -open the window - the text editor is gone (closed during shut down), but the other editors are open and blank.
This is why I thought the revert behavior was broken in I think it would be much better if an interactive window closed when it was reverted.
this is really up to the editor itself to decide whether to close the editor when the underlying working copy is reverted or not. Generally working copies try to stay as agnostic as possible to editors. There is only very few exceptions when it comes to restoring backups. Untitled editors listen to working copies getting reverted to self-dispose: This in turn, will close the editor. I suggest you go down a similar path. fyi for custom editors
fixed for notebook/Interactive window editor. - did you want another issue to track this for custom editors?
Yes that would be great
Change:
size: 0 }; } <del> return Promise.reject(new FileSystemError(resource, FileSystemProviderErrorCode.FileNotFound)); </del> <ins> return Promise.reject(FileSystemError.FileNotFound(resource)); </ins> } async readdir(resource: URI): Promise<[string, FileType][]> { const hasKey = await this.hasKey(resource.path); if (hasKey) { <del> return Promise.reject(new FileSystemError(resource, FileSystemProviderErrorCode.FileNotADirectory)); </del> <ins> return Promise.reject(FileSystemError.FileNotADirectory(resource)); </ins> } const keys = await this.getAllKeys(); const files: Map<string, [string, FileType]> = new Map<string, [string, FileType]>();

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Add an method to the interface. The current options are: trying to stat the and seeing if it fails — we have no way to tell why it failed; reading a parent directory — we may not have read access to the parent directory; using node's — only works for the local filesystem.
I see s are spec'd to thow on when the file doesn't exist, but does not spec such errors.
We have no plans for adding and instead should be used (this goes along the deprecated to NodeJS's -deprecation). Still, I do agree that we should spec the error
Would be a passable solution?
Re-open for API proposal/finalization. Proposal is to add a field to the -class
should I rename the issue to better reflect the proposal?
Reactions during the API meeting were positive, so I am confident that we can finalize this during the current milestone. One feedback item was to always have a value for , e.g. let its default value be something like or
I did a quick search of the codebase, and it looks like is usually used for such cases in the various error code enums.
This is now in and will be stable API with the next relase. thanks for the help
Change:
return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const focus = e.index; if (typeof focus === 'undefined') {

Discussion:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Promises } from 'vs/base/common/async'; </del> import { Emitter, Event } from 'vs/base/common/event'; import { Disposable } from 'vs/base/common/lifecycle'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation';

Discussion:
This here: Is strange to me because while this call is , it will not prolong the shutdown on the main process which is sync: Since the user of this event does not seem to use , I suggest to make the not support promises.
Change:
// } } <del> // Inside word upper case bonus (camel case) else if (isUpper(target.charCodeAt(targetIndex))) { </del> <ins> // Inside word upper case bonus (camel case). We only give this bonus if we're not in a contiguous sequence. // For example: // NPE => NullPointerException = boost // HTTP => HTTP = not boost else if (isUpper(target.charCodeAt(targetIndex)) && matchesSequenceLength === 0) { </ins> score += 2; // if (DEBUG) {

Discussion:
Issue Type: <bBug</bI have two files in my project in different locations. and . The 'search in files' popup always shows first, event when searching for the latter: ! please include case-sensitivity in the sort function for this. VS Code version: Code 1.60.2 (, 2021-09-22T12:00:31.514Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2 Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2 Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2 Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (5)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-ssh0.65.8 remote-ssh-edit0.65.8 remote-wsl0.58.2 hexeditor1.8.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
"textCodeBlock.background": "#6e768166", "textLink.activeForeground": "#40A6FF", "textLink.foreground": "#40A6FF", <del> "textPreformat.foreground": "#8b949e", </del> <ins> "textPreformat.foreground": "#f85149", </ins> "textSeparator.foreground": "#21262d", "titleBar.activeBackground": "#181818", "titleBar.activeForeground": "#ffffffc5",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 (Universal) OS Version: macOS 13.2 About Window Contents: Steps to Reproduce: new v2 themes. a rendered HTML file with Code segments in it (e.g. the Releases notes for 1.75.0) markdown segments have a poor contrast compared to the other text. The contrast was a lot better in the old dark/light themes. <img width="905" alt="dark mode" src="https://user-"<img width="899" alt="light mode" src="https://user-"
I wanted to report the exact same issue
Change:
if (unnecessaryBorder) { collector.addRule(`.${SHOW_UNUSED_ENABLED_CLASS} .monaco-editor .${ClassName.EditorUnnecessaryDecoration} { border-bottom: 2px dashed ${unnecessaryBorder}; }`); } <ins> collector.addRule(`.monaco-editor .${ClassName.EditorDeprecatedInlineDecoration} { text-decoration: strikethrough; }`); </ins> });

Discussion:
Now that has been to the API, I would like to support the proposal from to use it for tagging deprecated items. I figure the associated styling might be a strikethrough as proposed in but you guys can work that out separately.
I would be interested in helping out here with this and perhaps even . Without a lot of context, I assume this issue is specifically to add a new enum member here: I could open a PR that adds a member, if that's the case. edit: Looks like more applicable location would be and then opening a similar PR to
Yes, is the way to go. Find your way along usages/implementations of
Thanks, I'll work on that today.
Leaving this open so that we discuss this in the API sync
API has been finalised.
Change:
} toStorage(storageService: IStorageService) { <ins> const iconDefinitions = []; const iconFontDefinitions: { [id: string]: IconFontDefinition } = {}; for (const entry of this.iconThemeDocument.iconDefinitions.entries()) { const font = entry[1].font; iconDefinitions.push({ id: entry[0], fontCharacter: entry[1].fontCharacter, fontId: font?.id }); if (font && iconFontDefinitions[font.id] === undefined) { iconFontDefinitions[font.id] = IconFontDefinition.toJSONObject(font.definition); } } </ins> const data = JSON.stringify({ id: this.id, label: this.label,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.0 OS Version: Windows 11 21H2 Steps to Reproduce: a window another window with and observe that product icon themes don't load immediately and you are shown the default ones for a short while. https://user- The video above contains an example of this issue happening. If it matters, I am using the Fluent Icons product icon theme.
Why does this have the feature request label? This is a bug.
Change:
description: nls.localize('JsonSchema.version', 'The config's version number') }, _runner: { <del> deprecationMessage: nls.localize('JsonSchema._runner', 'The runner has graduated. Use the offical runner property') </del> <ins> deprecationMessage: nls.localize('JsonSchema._runner', 'The runner has graduated. Use the official runner property') </ins> }, runner: { type: 'string',

Discussion:
nls.localize() generally involves human visible output. Technically there are 2-3 arguments and the main human facing one is the second. The first argument is often treated as an "opaque" string, but in most systems, it's used to communicate to localizers, so, to some extent, there is value in not having misspellings there either. I can split out the identifiers if requested... Does this issue occur when all extensions are disabled?: Yes
can you provide me with more details about this. We use Transifex to translate our strings and the system contains both the value and the key.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
} logError(eventNameOrException: Error | string, data?: Record<string, any>): void { <del> if (!this._telemetryEnablements.isErrorsEnabled) { </del> <ins> if (!this._telemetryEnablements.isErrorsEnabled || !this._sender) { </ins> return; } if (typeof eventNameOrException === 'string') {

Discussion:
Testing Given this code: I was expecting my event handlers not to fire since the logger is disposed, but they still fire.
This still repros for me <img width="1210" alt="image" src="https://user-"
Change:
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-search@0.9.0-beta.37: version "0.9.0-beta.37" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.37.tgz#84a020f03b2cacc5afac78ca6ff2f1eb86fb6710" integrity sha512-bfeFgKJkDYyIgqpWiV1oWYqDiTo+SHTeIPEbpOfxDr97pc3PtDF1Tyd79PrvJNfoxaV3VMUo//UEOy4D+KY9OQ== </del> <ins> xterm-addon-search@0.9.0-beta.39: version "0.9.0-beta.39" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.39.tgz#e8376e1485ee7d763c07d1a8f1354114f65b3e3e" integrity sha512-h45wkecgfqXXoAUqgNytAfSd6g0xNT6rZy/enVaEU0aes7QoL9pxHUKkCry8PP6hs03Slk0VxQ4AGsbSZGvK/w== </ins> xterm-addon-serialize@0.7.0-beta.12: version "0.7.0-beta.12"

Discussion:
Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification
Change:
} const editorOrModel = findEditor(textEditorModel, this.codeEditorService) || textEditorModel; <del> const mode = this.configurationService.getValue<'file' | 'modifications'>('editor.formatOnSaveMode', overrides); if (mode === 'modifications') { // format modifications </del> <ins> const mode = this.configurationService.getValue<'file' | 'modifications' | 'modificationsIfAvailable'>('editor.formatOnSaveMode', overrides); // keeping things DRY :) const formatWholeFile = async () => { await this.instantiationService.invokeFunction(formatDocumentWithSelectedProvider, editorOrModel, FormattingMode.Silent, nestedProgress, token); } if (mode === 'modifications' || mode === 'modificationsIfAvailable') { // try formatting modifications </ins> const ranges = await this.instantiationService.invokeFunction(getModifiedRanges, isCodeEditor(editorOrModel) ? editorOrModel.getModel() : editorOrModel); if (ranges) { <ins> // version control reports changes </ins> await this.instantiationService.invokeFunction(formatDocumentRangesWithSelectedProvider, editorOrModel, ranges, FormattingMode.Silent, nestedProgress, token); <ins> } else if (ranges === null) { // version control not found formatWholeFile(); </ins> } } else { <del> // format the whole file await this.instantiationService.invokeFunction(formatDocumentWithSelectedProvider, editorOrModel, FormattingMode.Silent, nestedProgress, token); </del> <ins> formatWholeFile(); </ins> } } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --It would be nice to have either a toggle or a third option (or even just have this as default behavior for "modifications" mode of format on save) that tells VS Code to format the entire file on save if version control is unavailable. I find it annoying to have to configure every new repository workspace I make to use modifications instead of my User setting of file. Perhaps there is already an extension for this that I've not found yet. Either way, code for thought.
Actually, I've had a look into the code-base and it looks fairly easy to do, so I'll add the third option approach myself and create a PR. Up to you legends what you do with it tho
Change:
"dropdown.foreground": "#3b3b3b", "dropdown.listBackground": "#ffffff", "editor.background": "#ffffff", <del> "editor.findMatchBackground": "#9e6a03", </del> "editor.foreground": "#3b3b3b", "editor.inactiveSelectionBackground": "#E5EBF1", "editor.selectionHighlightBackground": "#ADD6FF80",

Discussion:
Type: <bBug</bIn addition to , , these elements are also hard to see in the Light+ V2 theme. [ ] Active (focused) workspace search results on methods: ! [x] Fixed ! ! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-06T05:24:21.999Z) OS version: Linux x64 5.15.0-58-generic Modes: Sandboxed: Yes
do you know what the notebook output token would be? I don't think I changed anything specific to notebooks in these new themes.
I checked it with the webview developer tool and it was , so I think it was fixed in
Perfect, thanks for checking. Feel free to close if it looks all good in the next Insiders update.
as pointed out we are using terminal colors.
Even worse for unsued python imports !
The variable for the active workspace search results is , and its opacity or saturation should be reduced to something like . (The current value is .)
Yep, this ended up just being a bad color assignment. Should be fixed now.
Change:
'libc6 (>= 2.17)', 'libc6 (>= 2.2.5)', 'libcairo2 (>= 1.6.0)', <del> 'libcups2 (>= 1.6.0)', </del> 'libcurl3-gnutls | libcurl3-nss | libcurl4 | libcurl3', 'libdbus-1-3 (>= 1.5.12)', 'libdrm2 (>= 2.4.38)',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Gentoo Linux Starting with 1.72, vscode has a hard dependency on a printing library, otherwise it refuses to even start. CUPS is quite a heavy dependency and not all Linux installations have it. This is a bug for two reasons: does not even support printing () then, such heavy libraries shall be only loaded on demand.
So, can you arrange with electron to not include the dependency on a heavy printing library? Nobody has printers these days.
Do you know which vscode release is going to start using Electron 22?
Verified with
Change:
lineNumber?: number; } <del> function shouldHide(event: KeyboardEvent, keybindingService: IKeybindingService): boolean { </del> <ins> function shouldHide(event: KeyboardEvent, keybindingService: IKeybindingService, configurationService: IConfigurationService): boolean { if (!configurationService.getValue(AccessibilityWorkbenchSettingId.AccessibleViewCloseOnKeyPress)) { return false; } </ins> const standardKeyboardEvent = new StandardKeyboardEvent(event); const resolveResult = keybindingService.softDispatch(standardKeyboardEvent, standardKeyboardEvent.target);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In previous versions, with the use of and the extension, I could easily select and copy terminal output content in the "Accessible View" via Vi mode. However, in the update, I noticed a change that "The Accessible View now closes when a user starts typing and focuses the prior element for a smoother work flow.". This change prevents me from using Vi mode to select content in the "Accessible View." Could you please consider providing an option that allows users to choose whether or not this feature is enabled? Alternatively, are there any other solutions to this issue?
Related to
can you take a look at this one? Thanks!
To verify, disable and make sure the view does not close on key press.
Fixed now! Thanks for the quick resolution!