jiebi/CodeConvo huggingface dataset:
Change:
*--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; <del> import { Emitter } from 'vs/base/common/event'; </del> <ins> import { Emitter, Event } from 'vs/base/common/event'; </ins> import { ISettableObservable, autorun, derived, ITransaction, observableFromEvent, observableValue, transaction, keepAlive } from 'vs/base/common/observable'; import { BaseObservable, IObservable, IObserver } from 'vs/base/common/observableImpl/base';

Discussion:
Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.
I cannot find your reversed P, nonetheless, with diff version 2 and removed "ignore leading/trailing whitespace", I get this: <img width="1384" alt="image" src=""and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width="551" alt="image" src=""
Change:
*/ setScrollPosition(position: INewScrollPosition, scrollType?: ScrollType): void; /** <ins> * Check if the editor is currently scrolling towards a different scroll position. */ hasPendingScrollAnimation(): boolean; /** </ins> * Get an action that is a contribution to this editor. * @id Unique identifier of the contribution. * @return The action or null if action not found.

Discussion:
Type: <bBug</bI found this problem in Vim extension when using half page scroll with centered view and smoothScrolling, and reproduce this bug in test clean extension. Without smoothScrolling it works fine. When executing command two times with ~150ms delay second action dont trigger (view stay in position by first ). U can see it on this video, when view in some cases not returned to 31 line from 39. https://user- Reproduce: reproducing i set interval with two timeouts to create delay between two executions and set smoothScrolling. ! VS Code version: Code 1.76.2 (, 2023-03-14T17:55:54.936Z) OS version: WindowsNT x64 10.0.

Modes: Unsupported Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (35)</summaryExtensionVersion ------ better-comments3.0.2 astro-vscode0.28.2 vscode-tailwindcss0.9.11 path-intellisense2.8.4 vscode-css-modules0.4.2 vscode-database-client26.3.4 vscode-eslint2.4.0 es7-react-js-snippets4.4.3 vsc-material-theme-icons2.7.4 prettier-vscode9.10.4 auto-close-tag0.5.14 auto-rename-tag0.1.10 code-runner0.12.0 geril-vim1.25.2 go0.38.0 vscode-graphql0.8.7 vscode-graphql-syntax1.1.0 code-background2.5.4 vscode-docker1.24.0 remote-wsl0.76.1 remote-explorer0.4.0 remote-server1.0.0 material-icon-theme4.25.0 prisma4.12.0 LiveServer5.7.9 rust-analyzer0.3.1463 vscode-styled-components1.7.8 svelte-vscode107.3.0 errorlens3.8.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-icons12.2.0 JavaScriptSnippets1.8.0 material-theme3.15.8 vscode-proto30.5.5 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.77.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
After update to 1.77.1 bug still exists
Thank you for the repro! The root cause is this particular call - introduced via cc That code runs even when the inlayHintsController doesn't do anything and it ends up interrupting the current editor scroll animation.
Change:
.monaco-workbench .interactive-input-part .monaco-action-bar .action-label.codicon-loading.codicon-modifier-spin:not(.disabled)::before, .monaco-workbench .inline-chat .monaco-action-bar .action-label.codicon-loading.codicon-modifier-spin:not(.disabled)::before { content: "ec1c"; <ins> font-family: 'codicon'; </ins> } /*

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Windows 10 / macOS Sonoma Steps to Reproduce: at least three windows the command least one of the windows will show a strange close icon, instead of the regular one, like the image below ! I reproduced the same error on Windows, and it also presented a strange icon, but it was a different one. A small vertical rectangle, like that missing unicode chars. I tested the on Insiders release, at least on MacOS, and didn't notice the error. I didn't have the opportunity to test in Insiders on Windows yet. I'll update the issue later with more details. Thank you
are you using a product icon extension?
Nevermind, a regression from , fyi
Hi , Glad to know you could find the fix. Let me know if you need me to verify it when released. Thank you
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
const exclusionsUsePattern = this.viewletSettings['query.exclusionsUsePattern']; const includesUsePattern = this.viewletSettings['query.includesUsePattern']; const patternIncludes = this.viewletSettings['query.folderIncludes'] || ''; <ins> const queryDetailsExpanded = this.viewletSettings['query.queryDetailsExpanded'] || ''; </ins> const useIgnoreFiles = typeof this.viewletSettings['query.useIgnoreFiles'] === 'boolean' ? this.viewletSettings['query.useIgnoreFiles'] : this.configurationService.getConfiguration<ISearchConfiguration>().search.useIgnoreFilesByDefault;

Discussion:
I find myself expanding this option nearly every time I use VSCode, would it be possible to have a setting that allows the search details to be open by default? !
It could be persisted as open, same as the button states are persisted.
Change:
import { Action } from 'vs/base/common/actions'; import { distinct } from 'vs/base/common/arrays'; <del> import { illegalArgument } from 'vs/base/common/errors'; </del> <ins> import { illegalArgument, onUnexpectedError } from 'vs/base/common/errors'; </ins> import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import * as objects from 'vs/base/common/objects'; import * as platform from 'vs/base/common/platform';

Discussion:
Being able to interact with the files that appear in would be useful. A few examples that come to mind: file matched by search. Clicking the file in the search result and then pressing does not work. Right-clicking the file does not show the command. Right-clicking the file does not show (where the file could be renamed). The only option I've found is to click one of the matches to open the file, right click the tab, select and rename the file using the side bar ( or right-click). file matched by search. multiple files matched by search. multiple files from the search result. two files matched by search. When right-clicking a file in , I think all the options that are shown when right-clicking a file in should be shown. Then any options by extensions would also be available. The keyboard shortcuts and should probably keep their current behavior. Also, it should be possible to select multiple files, similar to in .
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.47 --<!-- potentialduplicatescomment --
, can we take this up separately ? ( Like rename , delete etc ) I would like to work on that if that is the case. Please let me know , Thanks :)
I think a "reveal in explorer" command for search results would be really useful and I would take a PR for that. But I don't want to replicate all the the other commands and functionality of the explorer.
Just adding "Reveal in Explorer" goes a long way :) I've created a different feature request for allowing selecting multiple files:
To be consistent the command should be called ! Also I do not understand the logic why it is at the top. Is not this after copy commands?
, The command was called "Reveal in Side Bar" but preferred "Reveal in Explorer". Also i can change the position and add it where ever you both suggest, Thanks :)
You're already looking at the side bar, so I don't think "Reveal in side bar" makes sense. I don't really like it for the tab context menu either, I think we should be more specific. Also I agree, I think it should be at the bottom, not the top
Change:
return { extension: compatibleExtension, manifest }; } <del> protected async getCompatibleVersion(extension: IGalleryExtension, fetchCompatibleVersion: boolean, includePreRelease: boolean): Promise<IGalleryExtension | null> { </del> <ins> protected async getCompatibleVersion(extension: IGalleryExtension, sameVersion: boolean, includePreRelease: boolean): Promise<IGalleryExtension | null> { </ins> const targetPlatform = await this.getTargetPlatform(); let compatibleExtension: IGalleryExtension | null = null; <del> if (fetchCompatibleVersion && extension.hasPreReleaseVersion && extension.properties.isPreReleaseVersion !== includePreRelease) { </del> <ins> if (!sameVersion && extension.hasPreReleaseVersion && extension.properties.isPreReleaseVersion !== includePreRelease) { </ins> compatibleExtension = (await this.galleryService.getExtensions([{ ...extension.identifier, preRelease: includePreRelease }], { targetPlatform, compatible: true }, CancellationToken.None))[0] || null; }

Discussion:
Version: 1.65.0-insider (user setup) Commit: Date: 2022-02-11T05:19:13.554Z Electron: 16.0.8 Chromium: 96.0.4664.110 16.9.1 V8: 9.6.180.21-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: an extension (such as the C/C++ extension) that uses platform-specific VSIX's in the marketplace. a Remote WSL workspace. Install that extension into the remote. the extension UI for the instance installed remotely, try to select "Install Another Version..." or "Install Another Prerelease Version..." This results in an error: ! (There is a similar error in latest non-insider version, 1.64.2)
Can you please enable the log level to trace and provide following logs while performing this action? Log (Shared) Log (Window) Log (Remote)
When this repro's, I see the following in (with and is set to . I do not see any such setting as ) : is similar: was not logged to for this repro.
You can use following command to set log level to trace
Log (Shared): Log (Windows): Log (Remote Server): Log (Remote Extension Host): Please re-open. Please don't block waiting for me to provide information. This bug is extremely easy to reproduce.
Please re-open.
To verify: Open a remote window (make sure local and remote are on different Operating Systems) Install C++ extension Install another version of C++ extension (right click on the extension and you will see this action) Make sure another version is installed.
Change:
} async clone(url: string, parentPath: string, cancellationToken?: CancellationToken): Promise<string> { <del> let baseFolderName = decodeURI(url).replace(/^.*//, '').replace(/.git$/, '') || 'repository'; </del> <ins> let baseFolderName = decodeURI(url).replace(/[/]+$/, '').replace(/^.*//, '').replace(/.git$/, '') || 'repository'; </ins> let folderName = baseFolderName; let folderPath = path.join(parentPath, folderName); let count = 1;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.35.1 OS Version: macOS Very weird issue, open a new VS Code instance and do with this repo: . Instead of keeping the name it was renamed to
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.447 --<!-- potentialduplicatescomment --
I know how to reproduce it: new VS Code instance and as fast as possible open Command Palette and use you should see it opens Command Palette with and closes it immediately. this repo: would be cloned as instead of . I believe it's related because of that flicker and automatically closing Command Palette because I did it pretty fast so I guess initialization didn't happen properly. EDIT: Shit I can't reproduce it again
Reproduces if the URL has a trailing slash.
Thanks for looking into this and I'm very happy you were able to reproduce it.
Change:
data.entry.classList.remove('has-actions'); } } <ins> renderTwistie(element: IQuickPickElement, twistieElement: HTMLElement): boolean { // Force the twistie to be hidden twistieElement.setAttribute('style', 'display:none !important'); return false; } </ins> disposeElement?(_element: ITreeNode<IQuickPickElement, void>, _index: number, data: IQuickInputItemTemplateData): void { data.toDisposeElement.clear(); data.actionBar.clear();

Discussion:
! I can click on them
Took a different approach with this... instead they are clickable, but they cause the list to scroll that separator up to the top (and they also clear focus).
Fixed in
Change:
return localize('date.fromNow.in', 'in {0}', fromNow(new Date().getTime() + seconds * 1000, false)); } <del> if (seconds < 30) { </del> <ins> if (!disallowNow && seconds < 30) { </ins> return localize('date.fromNow.now', 'now'); }

Discussion:
Version: 1.44.0-insider (user setup) Commit: Date: 2020-03-31T08:23:56.446Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. This: ! Reminds me of this in onenote: ! The latter of which drives me crazy as it always lies to me and a restart to re-sync onenote is needed sometimes. Can we get the local time down to the second when you hover the last synced text?
what are the current setup steps for Sync in OSS? I have the setting set to whatever I tested it with a couple months ago but I don't see any Sync commands in the command palette. I can't remember where this is written down.
Could just put the real time in a tooltip, if that helps
I think just the change is needed to get it going in Code OSS. would solve my problem.
Change:
// Create workbench container and apply classes const container = document.createElement('div'); container.setAttribute('role', 'application'); <ins> position(container, 0, 0, 0, 0, 'relative'); container.style.display = 'flex'; container.style.height = '100%'; container.style.flexDirection = 'column'; </ins> auxiliaryWindow.document.body.append(container); // Track attributes

Discussion:
Testing a workspace a tab into a new floating window in a couple times using keyboard shortcuts the zoom status bar item to zoom out. When the zoom out happens, the status bar item will move further right, as expected because everything is getting small. However, the hover itself moved further left. I would expect it to either stay under my cursor (ideal) or move with the status bar item. !
It also moves around unexpectedly when I zoom in.
My cursor isn't showing properly in this gif, but I think you can get the idea. !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
@IWorkbenchEnvironmentService workbenchEnvironmentService: IWorkbenchEnvironmentService, @IWorkspaceContextService private readonly _workspaceContextService: IWorkspaceContextService, @IEditorService private readonly _editorService: IEditorService, <del> @IWorkspaceTrustRequestService private readonly _workspaceTrustRequestService: IWorkspaceTrustRequestService, @ICommandService private readonly _commandService: ICommandService </del> <ins> @IWorkspaceTrustRequestService private readonly _workspaceTrustRequestService: IWorkspaceTrustRequestService </ins> ) { super();

Discussion:
Testing I feel like I would mostly open output as a "one-off" editor to inspect test failures, for example. Having the prompt whenever I want to close the editor, since it's marked as untitled, is annoying. Instead, should it be opened as an ordinary read-only file which allows the user to if they want to keep it?
do you know how to do this in core? I also want to know how to do it in extensions for a similar problem in luna paint.
You can register an , I do that for test output: Alternatively (and in extensions) you can register a readonly FileSystemProvider.
Thanks, I'm a little surprised there's no option for extensions in as it seems like a common thing people would want to do.
Change:
background-color: rgba(130, 130, 130, 0.04); } <del> .settings-editor > .settings-body .settings-tree-container .setting-item.setting-item-list .setting-list-row:focus { outline: none; } </del> .settings-editor > .settings-body .settings-tree-container .setting-item.setting-item-list .setting-list-row:hover .monaco-action-bar, .settings-editor > .settings-body .settings-tree-container .setting-item.setting-item-list .setting-list-row.selected .monaco-action-bar { display: block;

Discussion:
the Settings editor. the dark high contrast theme. for the setting. until keyboard focus goes to the listview. the down and up keys. The pencil and close icons on the right side should move. :bug: There's no background colour change accompanying the keyboard focus. This problem does not occur with the high contrast light theme.
Change:
{ "name": "code-oss-dev", "version": "1.94.0", <del> "distro": "2560b0e8d341a0b6734d28ef71b08e1920ff2501", </del> <ins> "distro": "3617bc772b253b9c3ffd60d2e7165c4d945ac7c7", </ins> "author": { "name": "Microsoft Corporation" },

Discussion:
We'd like to have a safety net if we ever break Insiders users once more to the point of them not being able to update.
Implementation is done. Requires
Change:
if (this.state.type !== LightBulbState.Type.Showing) { return; } <del> const updateAutoFixLightbulbTitle = () => { if (this._preferredKbLabel) { this.title = nls.localize('preferredcodeActionWithKb', "Show Code Actions. Preferred Quick Fix Available ({0})", this._preferredKbLabel); } }; const updateLightbulbTitle = () => { if (this._quickFixKbLabel) { this.title = nls.localize('codeActionWithKb', "Show Code Actions ({0})", this._quickFixKbLabel); } else { this.title = nls.localize('codeAction', "Show Code Actions"); } }; </del> let icon: ThemeIcon; <ins> let autoRun = false; </ins> const option = this._editor.getOption(EditorOption.lightbulb).experimental.showAiIcon; if (option === ShowAiIconMode.On || option === ShowAiIconMode.OnCode) { if (option === ShowAiIconMode.On && this.state.actions.allAIFixes) { icon = Codicon.sparkleFilled; if (this.state.actions.validActions.length === 1) { <del> if (this.state.actions.validActions[0].action.command?.id === `inlineChat.start`) { const keybinding = this._keybindingService.lookupKeybinding('inlineChat.start')?.getLabel() ?? undefined; this.title = keybinding ? nls.localize('codeActionStartInlineChatWithKb', 'Start Inline Chat ({0})', keybinding) : nls.localize('codeActionStartInlineChat', 'Start Inline Chat',); } else { this.title = nls.localize('codeActionTriggerAiAction', "Trigger AI Action"); } } else { updateLightbulbTitle(); </del> <ins> autoRun = true; </ins> } } else if (this.state.actions.hasAutoFix) { if (this.state.actions.hasAIFix) {

Discussion:
Testing For this line, presumably there is only one AI action available. ! But I have no idea what that action is... and what will be executed when I open inline chat. It opens with : ! I think this should be more clear that this will happen as it's a bit jarring. Also will help here I think
Yes that's a very good point, if an action is auto-ran I will put the action title in the hover message. I am just wondering how that would work with localization since the hover message would be dynamic and would depend on the command inside of the menu? I guess I'll just write the following code in the localized string and prepend the action title with 'run':
We probably should turn off autorun when inline chat was invoked by clicking on the sparkle.
Is there a way to override the autorun from the code action?
I am working on changing the arguments if the command ID is . I will create a new args object but set autoSend to false, the other properties will be the same
So I have one PR to show the action title in the sparkle hover: And one PR which disables autoSend when invoking :
Change:
'libgbm1 (>= 17.1.0~rc2)', 'libglib2.0-0 (>= 2.16.0)', 'libglib2.0-0 (>= 2.39.4)', <del> 'libgssapi-krb5-2 (>= 1.17)', </del> <ins> 'libgssapi-krb5-2', </ins> 'libgtk-3-0 (>= 3.9.10)', 'libgtk-3-0 (>= 3.9.10) | libgtk-4-1', <del> 'libkrb5-3 (>= 1.6.dfsg.2)', </del> <ins> 'libkrb5-3', </ins> 'libnspr4 (>= 2:4.9-2~)', 'libnss3 (>= 2:3.22)', 'libnss3 (>= 3.26)',

Discussion:
On Ubuntu 16.04 <img width="571" alt="image" src=""Originally posted by in
On ubuntu 18.04 and using apt, almost the same error
Steps for verification: In Ubuntu 18.04 VM or Ubuntu 16.04 VM Install insiders debian package from Verify that error seen in is not shown and update completes successfully
Closing for verification.
Change:
</tbody></table> `); }); <ins> test('render icon in <a> without href (#152170)', () => { const mds = new MarkdownString(undefined, { supportThemeIcons: true, supportHtml: true }); mds.appendMarkdown(`<a>$(sync)</a>`); const result: HTMLElement = renderMarkdown(mds).element; assert.strictEqual(result.innerHTML, `<p><span class="codicon codicon-sync"></span></p>`); }); </ins> }); suite('ThemeIcons Support Off', () => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Linux x64 5.18.3-zen1-1-zen Steps to Reproduce: code display nothing.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Actually this is already enabled, you just need to set as well as . The bug is that theme icons gets stripped from an without an href
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified