jiebi/CodeConvo huggingface dataset:
Change:
sourceGroup.removeInstance(instance); } } <ins> const resolvedResource = this._terminalEditorService.resolveResource(instance || resource); const editor = this._terminalEditorService.getInputFromResource(resolvedResource) || { editor: URI.revive(resolvedResource) }; </ins> return { <del> editor: this._terminalEditorService.getOrCreateEditorInput(instance || resource), </del> <ins> editor, </ins> options: { ...options, pinned: true, forceReload: true } }; <del> } ); </del> <ins> }); </ins> this._forwardInstanceHostEvents(this._terminalGroupService); this._forwardInstanceHostEvents(this._terminalEditorService);

Discussion:
Context: Essentially instead of creating s we will assign URIs to the shell launch configs and only create the terminals when the input is created.
This should also include the fix for splitCwd support in terminal editors:
Change:
})); this._taskRunningState = TASK_RUNNING_STATE.bindTo(_contextKeyService); this._onDidStateChange = this._register(new Emitter()); <del> this._registerCommands(); </del> <ins> this._registerCommands().then(() => { TaskCommandsRegistered.bindTo(this._contextKeyService).set(true); }); </ins> this._configurationResolverService.contributeVariable('defaultBuildTask', async (): Promise<string | undefined> => { let tasks = await this._getTasksForGroup(TaskGroup.Build); if (tasks.length > 0) {

Discussion:
a folder try to run task Says task command not found !
What commit is that insiders based on? I believe I fixed this yesterday.
It says there is no updates for me but this is
Is that in oss? Hard to tell
No this is just todays insiders. I can test again on monday if you'd like
Thanks can you repro in oss?
Can repro when running the task command but not ctrl+shift+b. so this is a diff't bug
Reopen due to revert:
Change:
precondition: TerminalContextKeys.processSupported }); } <del> async run(accessor: ServicesAccessor) { return accessor.get(ITerminalService).activeInstance?.changeIcon(); </del> <ins> async run(accessor: ServicesAccessor, resource: unknown) { const terminalService = accessor.get(ITerminalService); const castedResource = URI.isUri(resource) ? resource : undefined; const instance = terminalService.getInstanceFromResource(castedResource) || terminalService.activeInstance; instance?.changeIcon(); </ins> } }); registerAction2(class extends Action2 {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
this._sequencer.queue(key, async () => { await this.resolvedStorageService; <del> if (this.type !== 'persisted') { </del> <ins> if (this.type !== 'persisted' && !this._environmentService.disableKeytar) { </ins> this._logService.trace('[NativeSecretStorageService] Notifying user that secrets are not being stored on disk.'); await this.notifyOfNoEncryptionOnce(); }

Discussion:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as
Change:
export function registerValidateSupport( connection: Connection, <del> workspace: VsCodeClientWorkspace, </del> <ins> workspace: md.IWorkspace, </ins> ls: md.IMdLanguageService, config: ConfigurationManager, logger: md.ILogger,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was testing the server on neovim. I noticed the requires a lot from the client. Would it be possible to bundle default implementations of and all other custom requests to make the server self-contained?
I'd take a PR that does this (likely using service injection) but the current design is deliberate lets the client bring their own parser versionThe custom file messages means the server is not restricted to working with local files. Ideally the LSP would also include this functionality but right now it does not
I can make a PR. Wouldn't it be simpler to add a setting for a custom tokenizer? Then call with or make a request?
makes this easier to use the server as a library. For a client that doesn't want to implement the custom messages we use, you'd instead want to use the new version of which lets you pass in your own parser and workspace implementations
Change:
await commands.executeCommand('vscode.open', uri); assert.strictEqual(window.tabGroups.all.length, 1); assert.strictEqual(window.tabGroups.all[0].activeTab?.group.viewColumn, ViewColumn.One); <del> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One); </del> await commands.executeCommand('vscode.open', uri, ViewColumn.Two); assert.strictEqual(window.tabGroups.all.length, 2); assert.strictEqual(window.tabGroups.all[1].activeTab?.group.viewColumn, ViewColumn.Two); <del> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.Two); </del> await commands.executeCommand('vscode.open', uri, ViewColumn.One); assert.strictEqual(window.tabGroups.all.length, 2); assert.strictEqual(window.tabGroups.all[0].activeTab?.group.viewColumn, ViewColumn.One); <del> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One); </del> let e1: Error | undefined = undefined; try {

Discussion:
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
Change:
testInput2.capabilities = EditorInputCapabilities.None; const sideBySideInput = instantiationService.createInstance(SideBySideEditorInput, 'name', undefined, testInput1, testInput2); <del> assert.strictEqual(sideBySideInput.hasCapability(EditorInputCapabilities.None), true); </del> <ins> assert.strictEqual(sideBySideInput.hasCapability(EditorInputCapabilities.MultipleEditors), true); </ins> assert.strictEqual(sideBySideInput.hasCapability(EditorInputCapabilities.Readonly), false); assert.strictEqual(sideBySideInput.hasCapability(EditorInputCapabilities.Untitled), false); assert.strictEqual(sideBySideInput.hasCapability(EditorInputCapabilities.RequiresTrust), false);

Discussion:
Just came across this code that conditionally leaves zen mode when side by side or diff editors are opened: We probably want something similar when a merge editor is opened.
enable centered editor layout open a merge editor verify centered editor layout exits
Verified
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as path from 'path'; <del> import { TabInputText, Uri, window, workspace } from 'vscode'; </del> <ins> import { CancellationToken, DocumentLink, DocumentLinkProvider, l10n, Range, TabInputText, TextDocument, Uri, window, workspace } from 'vscode'; </ins> import { IIPCHandler, IIPCServer } from './ipc/ipcServer'; import { ITerminalEnvironmentProvider } from './terminal'; import { EmptyDisposable, IDisposable } from './util'; <ins> import { Model } from './model'; import { Repository } from './repository'; </ins> interface GitEditorRequest { commitMessagePath?: string;

Discussion:
Testing I'd love it if these were clickable and brought me to the file it's talking about. ! Should be able to use a link provider, right?
Change:
overrideName: true }; deepStrictEqual(createProfileSchemaEnums([profile]), { <del> values: ['name'], markdownDescriptions: [`$(zap) namen- path: pathn- args: ['a','b']n- overrideName: truen- color: terminal.ansiRedn- env: {"c":"d","e":"f"}`] </del> <ins> values: [ null, 'name' ], markdownDescriptions: [ 'Automatically detect the default', `$(zap) namen- path: pathn- args: ['a','b']n- overrideName: truen- color: terminal.ansiRedn- env: {"c":"d","e":"f"}` ] </ins> }); }); test('should return a multiple entries when there are multiple profiles', () => {

Discussion:
Open default settings JSON: ! Version: 1.67.0-insider (user setup) Commit: Date: 2022-03-31T11:00:49.798Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Windows_NT x64 10.0.
windows and linux issue only - works on mac <img width="481" alt="Screen Shot 2022-03-31 at 11 16 55 AM" src="https://user-"
but not in the settings editor actually
I think it happens on mac too, was originally reported for .osx
any idea why null is not accepted here? We set null as a valid type along side enum/string:
any thoughts as I know you did some work related to enum settings?
Not sure, but I get a mysterious result in the suggestions: !
yeah that should be
If enums are defined, you need to add as a valid value to the enums as well
I believe null is already one of the enum values
The completion values are composed of enum, default and more. The validation only looks at at enum values. So I'm quite sure the num values don't contain null, as the hover shows: !
Change:
testIds: string[]; } <del> export const isStartControllerTests = (t: ICallProfileRunHandler | IStartControllerTests): t is IStartControllerTests => 'runIn' in t; </del> <ins> export const isStartControllerTests = (t: ICallProfileRunHandler | IStartControllerTests): t is IStartControllerTests => ('runId' as keyof IStartControllerTests) in t; </ins> /** * Request from the main thread to run tests for a single controller.

Discussion:
When I run all tests, the label resets back to after all tests were run. This is very confusing. !
This was a result of a bad filter function that caused all test runs to be treated extension-triggered. The "real" test run would then never have results, or get any output. More importantly, this results in "show test output" usually showing nothing. Taking this as a candidate. Essentially the sequence is: is triggered from the UI, so we prepare TestResults for incoming data and send the TestRunRequest precursor over to the EH EH doesn't associate that request with the existing run calls from its , which gets treated as a brand new run, so we make new TestResults for that run run and states get updated... 's resolves automatically marks the UI-triggered run as complete since the runHandler returned and there are no ongoing TestRuns latest completed TestResults is now the empty one that core created and was never updated so things that use the last result, like "show test output", are empty The code path in is meant to only be taken by the new Continuous Test runs, where the request is long-lived and doesn't have a single associated set of TestResults.
Change:
errorTelemetry.dispose(); service.dispose(); <ins> sinon.restore(); </ins> })); test('Unexpected Error Telemetry removes PII but preserves No Such File error message', sinonTestFn(function (this: any) {

Discussion:
In short, if you use without calling you are leaking memory. See for the details. I'm seeing a lot of memory used in unit tests and it appears to be coming from sinon. This may be contributing to our unit test OOM issue on Windows 32 bit. Let's see if fixing this lets us run the unit tests again. To fix I have made disposable, and there were some places where tests failed or the refactor seemed larger:
The biggest gain would be from fixing the leak from as it is used many places.
I don't know if you own , but I am looking into a fix for it since it will have the biggest impact.
I've reopened this.
Thanks. I should be careful to not do and instead as that will prevent GitHub from auto closing it
With , I have made disposable and handled disposing it in most tests. There are several places where the way to handle this isn't clear or made test fail when I just naively disposed it. I have them in the issue above.
the instance in is already restored at , but the others should be fixed in Let me know if I miss any! Edit: I ended up making changes in both files.
For those tests where I am just using , should I have to still call or I should wait for your change to dispose the ?
You can wait for my change to dispose the .
FYI Windows ia32 started turning green again
and the only files left are yours. The is now disposable and should be disposed in these test files to properly restore and prevent a memory leak.
Thank you for the fast response everyone!
need help
Change:
<key>uuid</key> <string>f8f5ffb0-503e-11df-9879-0800200c9a66</string> </dict> <del> </plist> </del>  No newline at end of file <ins> </plist> </ins>

Discussion:
Support rendering text decorations in the minimap, beginning with search results. We can add a new option to decorations, similar to in : The new optional property could look like: The find widget can then set this property for its decorations, and the minimap can read the decorations from its text model.
Change:
<key>uuid</key> <string>f8f5ffb0-503e-11df-9879-0800200c9a66</string> </dict> <del> </plist> </del>  No newline at end of file <ins> </plist> </ins>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
}); const viewNextCommitCommand = { <del> description: { description: localize('scm view next commit', "SCM: View Next Commit"), args: [] }, </del> <ins> description: { description: localize('scm view next commit', "Source Control: View Next Commit"), args: [] }, </ins> weight: KeybindingWeight.WorkbenchContrib, handler: (accessor: ServicesAccessor) => { const contextKeyService = accessor.get(IContextKeyService);

Discussion:
Within the UI in VS Code there are differing names for the SCM view depending on whereabouts you are in the UI. Under the "View Menu" there is an entry from "SCM" but everywhere else it is referred to as Source Control. (Hovering over the icon in the activity bar names it Source Control, the view container title says Source Control and in the command palette, the command is listed as "Source Control: Focus on Source Control View".) Then under settings there is a group "Features SCM" For consistency, it would be better to keep with a single (user facing) name that is used in all places.
I don't like using of abbreviations in the program GUI, especially if they are not as much popular and known. It took me a while to understand what is that SCM thing.
fixing this makes sense to me, though I might be missing some historical context.
Yeah the correct term is Source Control. SCM is just an internal name, should not be surfaced.
I've pushed a small PR that should rename this in all the places I could find.
Merged! thank you very much for the contribution!
Change:
if (event.keyCode === KeyCode.UpArrow) { const toExpand = category.steps.filter((step, index) => index < currentStepIndex() && this.contextService.contextMatchesRules(step.when)); if (toExpand.length) { <del> this.selectStep(toExpand[toExpand.length - 1].id, false, false); </del> <ins> this.selectStep(toExpand[toExpand.length - 1].id, false); </ins> } } if (event.keyCode === KeyCode.DownArrow) { const toExpand = category.steps.find((step, index) => index > currentStepIndex() && this.contextService.contextMatchesRules(step.when)); if (toExpand) { <del> this.selectStep(toExpand.id, false, false); </del> <ins> this.selectStep(toExpand.id, false); </ins> } } }));

Discussion:
Type: <bBug</bContext changes causes images to flicker and, worse, quick picks to close. Run Open walkthrough Open step or Hit the button Quick pick closes right after clicking and image flashes. VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-08T05:22:25.379Z) OS version: Darwin x64 22.3.0 Modes: Sandboxed: Yes <!-- generated by issue reporter --
Seems as the context changes, which changes focus and closes the quick picks.
I can't repo this on OSS. But used the developer tools on insiders to debug it. fires the context changed event too many times which causes us to reload the media I removed rebuilding step if the step is already open which should fix the issue for the walkthroughs. But there is likely a larger issue to be fixed with the being fired too many times. You can turn off settings sync and try the steps described above - no repro.
Change:
} if (node.collapsible) { <del> const model = this.tree.model; // internal const location = model.getNodeLocation(node); </del> <ins> const location = this.tree.getNodeLocation(node); </ins> const recursive = e.browserEvent.altKey; this.tree.setFocus([location]); <del> model.setCollapsed(location, undefined, recursive); </del> <ins> this.tree.toggleCollapsed(location, recursive); </ins> if (expandOnlyOnTwistieClick && onTwistie) { return;

Discussion:
This is a follow-up on and where I simply make the model-property of the tree public. Tho, a better fix might be needed here
Change:
@IUserDataSyncAccountService private readonly userDataSyncAccountService: IUserDataSyncAccountService, @ILifecycleService private readonly lifecycleService: ILifecycleService, @INotificationService private readonly notificationService: INotificationService, <del> @IInstantiationService instantiationService: IInstantiationService, </del> <ins> @IHostService hostService: IHostService, </ins> ) { super(); this.storageManger = this._register(new StorageManager(storageService));

Discussion:
Steps to Reproduce: = workbench does not open From: Workaround:
I think depending on is logically correct. But, in web is depending on other workbench services like --and causing cycle. Not having consistent base services in desktop and web is causing confusion and debt and it might add up as we evolve. I think fixing in is just a patch. To unblock for now, I removed the dependency on and used . Assigning back to you for fixing this in .
Change:
services.set(ISignService, new SyncDescriptor(SignService, undefined, false /* proxied to other processes */)); // Tunnel <ins> const remoteSocketFactoryService = new RemoteSocketFactoryService(); services.set(IRemoteSocketFactoryService, remoteSocketFactoryService); remoteSocketFactoryService.register(RemoteConnectionType.WebSocket, nodeSocketFactory); </ins> services.set(ISharedTunnelsService, new SyncDescriptor(SharedTunnelsService)); services.set(ISharedProcessTunnelService, new SyncDescriptor(SharedProcessTunnelService));

Discussion:
Type: <bBug</b[Window Title] Visual Studio Code - Insiders [Content] Unable to launch browser: "Timed out waiting for browser connection" The above worked fine till last update and it works fine in current stable release. A browser window opens but then i get the above timeout message. Output of console output: VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-17T05:27:38.052Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux arm64 5.15.0-1030-oracle Remote OS version: Linux arm64 5.15.0-1030-oracle <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ helium-icon-theme1.0.0 vscode-edge-devtools2.1.1 remote-ssh0.103. remote-ssh-edit0.86.0 remote-explorer0.4.0 ayu1.0.5 python-extended-snippets0.0.1 vscode-django1.10.0 vscode-tailwindcss0.9.11 ruff2023.16.0 rescript-vscode1.16.0 vscode-eslint2.4.0 gitlens13.6.0 copilot-chat0.1. copilot-labs0.14.884 copilot-nightly1.86.92 svg1.5.2 i18n-ally2.9.1 MagicPython1.1.0 ts-error-translator0.8.0 git-graph1.30.0 black-formatter2023.2.0 python2023.8.0 vscode-pylance2023.5.20 vsliveshare1.0.5864 vscode-thunder-client2.6.2 LiveServer5.7.9 vs-code-prettier-eslint5.1.0 sonarlint-vscode3.17.0 vscode-pets1.22.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Seems like forwarded ports are not working at all. None of my manually forwarded ports work.

I get the above error message in output window whenever I try to access any forwarded port. When i manually forward port and try to access it:
Seems like is undefined which is causing this error to be caught and displayed
Temporary workaround: Use older version of vscode insider - Then turn off auto updates and background updates.
Facing the same issue on my VSCode Insiders as well. Was working fine on 16th May 2023, and the problem started yesterday (17th May 2023). For me, this occurs when I am trying to port-forward a webpage loaded on my virtual machine to my local machine. Below is a sample of the logs from the "Shared" Output tab. The same error related to the is .
I believe this is the issue I am encountering.
The latest work version: 1.79.0. SystemSetup: UserSetup:
Range of commits where this occurred:
or I think this is related to , though I'm not sure how. This comment is correct about where the error is coming from:
Thanks for the detailed issue!
Change:
.monaco-workbench .part.panel > .content .pane-body.output-view .monaco-editor, .monaco-workbench .part.panel > .content .pane-body.output-view .monaco-editor .margin, .monaco-workbench .part.panel > .content .pane-body.output-view .monaco-editor .monaco-editor-background { <del> background-color: var(--vscode-outputEditor-background); </del> <ins> background-color: var(--vscode-outputView-background); </ins> } .monaco-workbench .part.panel > .content .pane-body.output-view .sticky-widget { <del> background-color: var(--vscode-outputEditorStickyScroll-background, var(--vscode-panel-background)); </del> <ins> background-color: var(--vscode-outputViewStickyScroll-background, var(--vscode-panel-background)); </ins> }

Discussion:
Followup from I wouldn't call the color . For the user it is not an editor, just a view. Either or