jiebi/CodeConvo huggingface dataset:
Change:
import { collapseAll, expandAll } from 'vs/base/parts/tree/browser/treeUtils'; import 'vs/css!./media/settingsEditor2'; import { localize } from 'vs/nls'; <del> import { ConfigurationTarget, IConfigurationOverrides, IConfigurationService } from 'vs/platform/configuration/common/configuration'; </del> <ins> import { ConfigurationTarget, IConfigurationOverrides, IConfigurationService, ConfigurationTargetToString } from 'vs/platform/configuration/common/configuration'; </ins> import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { IEnvironmentService } from 'vs/platform/environment/common/environment';

Discussion:
Issue Type: <bFeature Request</bTesting Just a thought: When I see "Modified in: Workspace" I might want to go there and check. I'd keep font and color as they are and add an underline and pointer cursor to "Workspace" on hover. VS Code version: Code - Insiders 1.27.0-insider (, 2018-08-29T05:12:15.247Z) OS version: Darwin x64 17.7.0 <!-- generated by issue reporter --
Good idea!
I would take a PR for this "Modified in: Workspace" - the word Workspace is underlined When clicked, it switches to the Workspace scope, and copies the setting key into the search bar, so the view is filtered to just that one setting
I'm interested in looking into this if that is alright.
Change:
hcLight: ACTIVITY_BAR_FOREGROUND }, localize('activityBarItem.settingsProfilesHoverForeground', "Foreground color for the settings profile entry on the activity bar when hovering.")); <ins> export const ACTIVITY_BAR_SETTINGS_PROFILE_BACKGROUND = registerColor('activityBarItem.settingsProfilesBackground', { dark: lighten(ACTIVITY_BAR_BACKGROUND, 0.5), light: darken(ACTIVITY_BAR_BACKGROUND, 0.12), hcDark: null, hcLight: null }, localize('statusBarItemSettingsProfileBackground', "Background color for the settings profile entry on the activity bar.")); </ins> // < --- Remote --- > export const STATUS_BAR_HOST_NAME_BACKGROUND = registerColor('statusBarItem.remoteBackground', {

Discussion:
The original designs had something closer to this for the default background color. IMO it isn't trying to be an icon like the other items and the border makes it feel like an icon vs. a unique element. I also think the background and foreground should be the only customizable elements to start. I think I saw a foreground token, but not sure it was possible to do background yet. <img width="247" alt="CleanShot 2022-09-26 at 16 29 09 src="https://user-"
I also like this more over the border For example here this looks not too different from the actions above even though it is about profiles: <img width="297" alt="image" src="https://user-"
!
I like it but maybe with smaller font size? Here is with for example: !
Current font size goes well with all (emoji, codicons) and also symmetric with activity bar icons.
Change:
enqueueExitBlocker( (async () => { const stackInfo = await deriveStackLocations(store, rawErr, tcase!); <del> let message: vscode.TestMessage2; </del> <ins> let message: vscode.TestMessage; </ins> if (hasDiff) { message = new vscode.TestMessage(tryMakeMarkdown(err));

Discussion:
Currently, messages that are shown when tests fail can only be shown at a single . Often (, , among others) folks want to see the full call stack of the test failure. I propose some API to add this information:
does this track that not only the stack but stack + any stdout would show in same UX? /cc
Yes, output is already trackable and associable to a test case via the API
We are using to record all stdout written by tests. In addition, the is used to record the failure message and stack for each test failure.
UI:
Just check with Joh and this looks good to move into finalized!
do we want to bundle this with any of the other testing proposals (, )?
Change:
export const defaultEditorId = 'default'; <ins> const builtinProviderDisplayName = nls.localize('builtinProviderDisplayName', "Built-in"); </ins> const defaultEditorInfo = new CustomEditorInfo({ id: defaultEditorId, <del> displayName: nls.localize('promptOpenWith.defaultEditor', "VS Code's standard text editor"), </del> <ins> displayName: nls.localize('promptOpenWith.defaultEditor.displayName', "Text Editor"), providerDisplayName: builtinProviderDisplayName, </ins> selector: [ { filenamePattern: '*' } ],

Discussion:
re This uses VS Code as hard-coded name, not the product name This reads a little cumbersome, why not "Text Editor" and as description (built-in) <img width="361" alt="Screenshot 2020-04-03 at 13 46 27" src="https://user-"
Fixed by
Change:
public getEditOperations(model: ITextModel, builder: IEditOperationBuilder): void { <ins> const getLanguageId = () => { return model.getLanguageId(); }; const getLanguageIdAtPosition = (lineNumber: number, column: number) => { return model.getLanguageIdAtPosition(lineNumber, column); }; </ins> const modelLineCount = model.getLineCount(); if (this._isMovingDown && this._selection.endLineNumber === modelLineCount) {

Discussion:
Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.
See and for similar/duplicates.
should be fixed by
Thanks for the fix!

Start with the following code: select the first method move it down
This reproduces for very simple examples:
See also and
Should be fixed with

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.0 OS Version: Windows 10 Home 22H2 build .4412 (+ WSL2 inside Win10) Steps to Reproduce: (similar to this issue: ) code: cursor at line 5 and perform 3 times. moved line is misplaced: In a vscode window opened in WSL this also happens: 1-WSL. Sample code: 2-WSL. Set cursor at line 2 and perform 3 times. 3-WSL. The last bracked is misplaced:
should be fixed by

<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When writing Lua code in VSCode, using Alt + Up/Down to move a line of code no longer automatically aligns the context of the code. Before the update, it would automatically align.
could you please help triage this issue? Thank you!
Hi yes thanks for the ping, this appears to be related to some recent auto-indentation changes I have made.
should be fixed with
Change:
import { KeybindingLabel } from 'vs/base/browser/ui/keybindingLabel/keybindingLabel'; import { IListRenderer, IListVirtualDelegate } from 'vs/base/browser/ui/list/list'; import { IListAccessibilityProvider, IListOptions, IListStyles, List } from 'vs/base/browser/ui/list/listWidget'; <del> import { IAction } from 'vs/base/common/actions'; </del> import { range } from 'vs/base/common/arrays'; import { ThrottledDelayer } from 'vs/base/common/async'; import { compareAnything } from 'vs/base/common/comparers';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Ubuntu 23.04 Steps to Reproduce: the command palette using ctrl+shift+p (or cmd+shift+p on mac) the escape key, closing the command palette 7 times that instance count has increased by 7, instance count has increased by 211, instance count has increased by 240 and instance count has increased by 302. The total disposable count has increased by 1137 from to . One class that has increased the most in the above test was . Looking where relates to the quick input I found this code in where actions are created: Perhaps it could be this code that causes the to be created. It seems the actions aren't registered/disposed like other disposables.
Thanks for reporting this! I think I've cleaned up the ... now we use the simpler non-disposable kind... I'll chip away at the rest over time.
Thanks a lot, I see now: No more Actions are leaked (211 -0) Disposable stores are 211 less leaked (240 -29) Emitter are 211 less leaked (302 -91) MutableDisposable instance count still increases (7 -7) I'll try to find more information for the MutableDisposables and DisposableStores where exactly they are created! Thanks again! Edit: The MutableDisposables are created in : They are kept alive by a 200ms timeout and disposed after 200ms so it's no problem: Just the test executing too fast / finishing before the MutableDisposables were disposed. :)
Change:
return; } <del> async changeColor(color?: string): Promise<string | undefined> { </del> <ins> async changeColor(color?: string, skipQuickPick?: boolean): Promise<string | undefined> { </ins> if (color) { this.shellLaunchConfig.color = color; this._onIconChanged.fire({ instance: this, userInitiated: true }); return color; <ins> } else if (skipQuickPick) { // Reset this tab's color this.shellLaunchConfig.color = ''; this._onIconChanged.fire({ instance: this, userInitiated: true }); return; </ins> } const icon = this._getIcon(); if (!icon) {

Discussion:
From testing Steps to Reproduce: multiple terminals multiple terminals in the terminal view to change their color to red the terminals still select, select again time run instead Bug Only a single terminal at a time is reset
Change:
terminal.focus(); } } else if (event.which === 3) { <del> if (this._terminalService.configHelper.config.rightClickBehavior === 'copyPaste') { </del> <ins> const rightClickBehavior = this._terminalService.configHelper.config.rightClickBehavior; if (rightClickBehavior === 'copyPaste' || rightClickBehavior === 'paste') { </ins> const terminal = this._terminalService.getActiveInstance(); if (!terminal) { return; } <del> if (terminal.hasSelection()) { </del> <ins> if (rightClickBehavior === 'copyPaste' && terminal.hasSelection()) { </ins> await terminal.copySelection(); terminal.clearSelection(); } else {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --With being merged, I'd now like to be able to directly paste after selection. The current behaviour with copyOnSelection = true and rightClickBehavior = copyPaste: text (text is then copied into clipboard) or left click, this clears the selection click again to paste With the proposed mode, copyOnSelection = true and rightClickBehavior = paste: text (text is then copied into clipboard) click, and text is pasted Why do I want this? Simple: it removes an extra click when pasting. This mirrors how PuTTY's pastes. The new Windows Terminal recently got support for this feature, too -
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.5 --- <!-- score: 0.483 --- <!-- score: 0.457 --<!-- potentialduplicatescomment --
To verify test on Windows and make sure that acts correct (as opposed to the default )
Change:
const fileBased = Object.keys(this._fileBasedRecommendations) .filter(recommendation => allRecomendations.indexOf(recommendation) !== -1); <del> const exeBased = distinct(this._suggestBasedOnExecutables()); </del> <ins> const exeBased = distinct(this._exeBasedRecommendations); </ins> this.telemetryService.publicLog('extensionRecommendations:unfiltered', { fileBased, exeBased });

Discussion:
In the renderer we want to stay away from sync fs API calls to because each call will stop the VM from doing anything. We should try to use the async fs APIs. The code in question is:
What about ?
yes, I reported those at the same time I reported this one via
There about 20 files that I need to run the checks on (this will definitely grow). Assuming there are about 20 paths in the PATH env variable, that is about 400 file checks to make in the worst case scenario If I do all of this async, thats about 400 async calls made at the same time. This can have an adverse affect as well correct? Or it doesnt matter at all?
anything is better than doing it sync, especially if you are stat'ing 400 files which probably means that the user cannot do anything for a couple of 100ms. We have  that allows to batch resolve. my 2 cents: having to stat 400 files for a feature seems wrong to me, especially if this blocks a piece of UI from working properly. At the very minimum this should run in the background, maybe buffered and not block any UI from showing up.
Change:
const TOP_STACK_FRAME_MARGIN: IModelDecorationOptions = { description: 'top-stack-frame-margin', glyphMarginClassName: ThemeIcon.asClassName(debugStackframe), <ins> glyphMargin: { position: GlyphMarginLane.Right }, zIndex: 9999, </ins> stickiness, overviewRuler: { position: OverviewRulerLane.Full,

Discussion:
<img width="288" alt="image" src="https://user-"This leads to the editor shifting to the right every time I pause, because it's adding an editor gutter. We actually already have a combo decoration that shows the two things together. I don't actually know exactly how that works but can look it up if you need it. Actually this combo decoration doesn't exist for all breakpoint types, which is annoying, but that's an issue for me
If you have a code pointer that would be awesome, I wasn't aware we had a notion of combined decorations today. As far as I know in the past we merged the classnames for any decorations that wanted to appear in the glyph margin
So when I see this <img width="76" alt="image" src="https://user-"there is a and an , that is where the different colors come from I think the comes from the normal decoration, then we set the content here and color here It seems like we are hacking editor decorations with css a bit
Maybe the solution is just making sure that whatever logic puts breakpoints in their own lane applies to all debug decorations though, so these all get their own lane and its the same, if that makes sense
The actual stackframe decorations come from here
The trouble is now we also have this notion of a to ensure e.g. that testing decorations always render atop other decorations, so if there are multiple decorations in the same lane we pick the first one and discard the rest. To show those decorations together, I think I have to restore the old behavior so that decorations with the same get the classnames combined like in the previous stable. But as you said that only works because of some CSS hackery, maybe we also want a more formalized way to combine decorations.
Change:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { SEMANTIC_HIGHLIGHTING_SETTING_ID, IEditorSemanticHighlightingOptions } from 'vs/editor/common/services/modelServiceImpl'; <ins> const $ = dom.$; </ins> class InspectEditorTokensController extends Disposable implements IEditorContribution { public static readonly ID = 'editor.contrib.inspectEditorTokens';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . Simirarly to , it aims to replace construction of HTML elements by string concatenation in file. The code contains mainly a table construction by concatenating strings of . The goal is to replace them all with function calls.
I verified by running the monaco editor from source and testing the inspect token hover
To verify, open the hover and verify it looks all proper.
Change:
"vscode-languageserver": "^8.0.2", "vscode-languageserver-textdocument": "^1.0.5", "vscode-languageserver-types": "^3.17.1", <del> "vscode-markdown-languageservice": "^0.2.0-alpha.7", </del> <ins> "vscode-markdown-languageservice": "^0.2.0-alpha.8", </ins> "vscode-nls": "^5.2.0", "vscode-uri": "^3.0.3" },

Discussion:
Type: <bBug</bworkspace: : to top level of workspace bug The link is incorrectly rewritten to include the file name VS Code version: Code - Insiders 1.73.0-insider (Universal) (, 2022-10-27T21:41:11.954Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
const onKeyDown = Event.chain(domEvent(this.view.getHTMLElement(), 'keydown')) .filter(e => !isInputElement(e.target as HTMLElement) || e.target === this.filterOnTypeDomNode) <ins> .filter(e => e.key !== 'Dead') </ins> .map(e => new StandardKeyboardEvent(e)) .filter(this.keyboardNavigationEventFilter || (() => true)) .filter(() => this.automaticKeyboardNavigation || this.triggered)

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.38.0 OS Version: Linux x64 4.15.0-29deepin-generic Steps to Reproduce: focus on explorer section BracketLeft, key code 219 ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Cannot reproduce VSCode Version: 1.38.0 OS Version: macOS 10.14.6 (18G95)
Cannot reproduce either VSCode Version: 1.39.0 OS Version: macOS 10.14.2
Do you maybe have a special keyboard layout?
No, i have a Dell Inspiron 14 5480 and i use his keyboard, i check again and the error stills here. Not just for BracketLeft, but shows the same error when i press . I tested with external keyboard and i have same results. Keys: !
Ok, I can reproduce it now on MacOS & Windows with english and german layout, but BracketLeft works. What kind of keyboard layout do you use Portuguese layout? Maybe this is related: When pressing a modifier key, the key event listener returns 'DEAD', this is normal, but should not be printed to the user. The modifier key is applied. So when I press ' ^ ' then ' a', it shows ' â '. vscode should check the return value of the key event listener and filter out 'DEAD'. Modifier keys that result in 'DEAD' : ^ ´
Yeah, i use portuguese layout keyboard. With layout doesn't have a problem. ^ ´ All ocurrencies prints
I'm using portuguese layout keyboard as well. ^ ´ ` ~ All of these keys prints
I'm using portuguese layout keyboard as well. ^´
I'd be interested in taking a look at this if that's okay. I've found The obvious fix here is to amend L699 to include a check for dead keys, however, this seems a bit hacky as will still be called. Is there somewhere else that this could be handled?

EDIT: Could instead modify (a bit nicer) But this still isn't ideal, as it doesn't behave the same as all other inputs. Bit lost here to be honest and would appreciate any pointers.
I think the best we can do is exactly what you've done with . Feel free to submit a PR!
Change:
} else if (originalArgs === shellIntegrationArgs.get(ShellIntegrationExecutable.Zsh) || originalArgs === shellIntegrationArgs.get(ShellIntegrationExecutable.ZshLogin)) { newArgs = originalArgs; } <del> // Set the ZDOTDIR to be the dir of the shell integration script so that it runs // as a .zshrc file and the autoload hook will work and set precmd and preexec correctly env['ZDOTDIR'] = '${execInstallFolder}/out/vs/workbench/contrib/terminal/browser/media'; </del> <ins> // Set _ZDOTDIR which will defer setting ZDOTDIR to the pty host env['_ZDOTDIR'] = '1'; </ins> const showWelcome = configurationService.getValue(TerminalSettingId.ShellIntegrationShowWelcome); if (!showWelcome) { env['VSCODE_SHELL_HIDE_WELCOME'] = '1';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider OS Version: MacOS12.2.2 Steps to Reproduce: with setting new terminal <img width="1440" alt="image" src="https://user-"
Thanks, we're aware of this issue and have been working toward its resolution
Change:
private _processId: number; private _skipTerminalCommands: string[]; private _title: string; <del> private _toDispose: lifecycle.IDisposable[]; </del> <ins> private _instanceDisposables: lifecycle.IDisposable[]; private _processDisposables: lifecycle.IDisposable[]; </ins> private _wrapperElement: HTMLDivElement; private _xterm: any; private _xtermElement: HTMLDivElement;

Discussion:
From
For January we decided to keep the task in the core. So there is no need to make this 'public' API now. May be it would be good to first experiment a little with the new API.
just to make sure, were you thinking of using a prompt (press any key to close) that can be reused? Or a terminal that executes something, the pty process dies and just sits there ("dead") until another task command is sent?
I would like to achieve the following: create a new terminal and allow terminal reuse (could be an additional option) without actually running a terminal right away (if necessary we could run it as well) run a command in the terminal. This will create the actual shell process. Usually the shell would be started with /c receive an exit event when the shell exists reuse the terminal to run another command in the terminal which creates a new shell process. Use case if for a build task: if the user runs the build tasks 3 times in a row I would like to have one terminal (e.g. on entry in the drop down in the terminal pane) which contains the output of all three task runs.
I have one additional question. Does the terminal require to run a shell or would the terminal be able to run any other arbitrary process (for example a ).
I got it working to run an arbitrary program. Only drawback is that I needed to specify the full path to the program (e.g. ). Any idea why this is the case?
do you mean the shell path you're using is and it's not working like that? I guess the resolution stuff is contained within , I would think it would probably be safest to always wrap the command within or . Wrapping the command means the process will die when it finishes so I don't see a downside?
the only problem is argument passing with spaces contained. If you call node directly then you pass the args as a string[]. If you call the for example you need to construct a single string with proper arg quoting to ensure everything works when for example the command to call contains spaces. And you save a process :-)
could this be useful for Python terminal execution?