jiebi/CodeConvo huggingface dataset:
Change:
// now actually create on disk let stat: IFileStatWithMetadata; try { <del> stat = await this.fileService.createFile(resource, contents, { overwrite: options?.overwrite }); </del> <ins> if (isFile) { stat = await this.fileService.createFile(resource, contents, { overwrite: options?.overwrite }); } else { stat = await this.fileService.createFolder(resource); } </ins> } catch (error) { // error event

Discussion:
It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.
Some background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.
We currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.
I don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both
Verification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.
Thanks for fixing!
Change:
import { RangeMap, shift } from 'vs/base/browser/ui/list/rangeMap'; import { IRow, RowCache } from 'vs/base/browser/ui/list/rowCache'; import { IObservableValue } from 'vs/base/common/observableValue'; <ins> import { BugIndicatingError } from 'vs/base/common/errors'; </ins> interface IItem<T> { readonly id: string;

Discussion:
Open a text editor and settings editor side by side and resize the sash in between and notice a lot of lag: ! A lot of time spend in : !
Sadly, this is the cost of having dynamic heights. This is why dynamic height is disabled for all lists but is enabled (and actually created for) the settings editor. Will investigate and see if there's low hanging fruit.
Actually, this is the culprit: cc It broke what achieved. That statement was made sure we reused DOM nodes for this computation if they were already in the DOM tree. But that commit broke this for the Settings Editor, making recomputing heights based on wrap a lot more expensive.
Before, each frame takes 60ms: ! After, each frame takes 12ms: !
Change:
let issueUrl = hasUri ? this.getExtensionBugsUrl() : this.getIssueUrl(); if (!issueUrl) { <ins> console.error('No issue url found'); </ins> return false; }

Discussion:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Application, Terminal, SettingsEditor, TerminalCommandIdWithValue } from '../../../../automation'; </del> <ins> import { Application, Terminal, SettingsEditor, TerminalCommandIdWithValue, TerminalCommandId } from '../../../../automation'; </ins> import { setTerminalTestSettings } from './terminal-helpers'; export function setup() {

Discussion:
With support for for Electron tests, we should enable terminal tests: I eagerly had enabled them but since we don't know whether Electron smoke tests with are stable, I moved back to only running them in web. We should not enable these tests until we are sure, smoke tests are stable, so maybe this should only happen in May.
Failing macOS run for reference: !
Still not passing, deferring to a debt week
Change:
const resolvedCommentBorder = registerColor('editorCommentsWidget.resolvedBorder', { dark: resolvedCommentViewIcon, light: resolvedCommentViewIcon, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('resolvedCommentBorder', 'Color of borders and arrow for resolved comments.')); const unresolvedCommentBorder = registerColor('editorCommentsWidget.unresolvedBorder', { dark: unresolvedCommentViewIcon, light: unresolvedCommentViewIcon, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('unresolvedCommentBorder', 'Color of borders and arrow for unresolved comments.')); export const commentThreadRangeBackground = registerColor('editorCommentsWidget.rangeBackground', { dark: transparent(unresolvedCommentBorder, .1), light: transparent(unresolvedCommentBorder, .1), hcDark: transparent(unresolvedCommentBorder, .1), hcLight: transparent(unresolvedCommentBorder, .1) }, nls.localize('commentThreadRangeBackground', 'Color of background for comment ranges.')); <del> export const commentThreadRangeBorder = registerColor('editorCommentsWidget.rangeBorder', { dark: transparent(unresolvedCommentBorder, .4), light: transparent(unresolvedCommentBorder, .4), hcDark: transparent(unresolvedCommentBorder, .4), hcLight: transparent(unresolvedCommentBorder, .4) }, nls.localize('commentThreadRangeBorder', 'Color of border for comment ranges.')); </del> export const commentThreadRangeActiveBackground = registerColor('editorCommentsWidget.rangeActiveBackground', { dark: transparent(unresolvedCommentBorder, .1), light: transparent(unresolvedCommentBorder, .1), hcDark: transparent(unresolvedCommentBorder, .1), hcLight: transparent(unresolvedCommentBorder, .1) }, nls.localize('commentThreadActiveRangeBackground', 'Color of background for currently selected or hovered comment range.')); <del> export const commentThreadRangeActiveBorder = registerColor('editorCommentsWidget.rangeActiveBorder', { dark: transparent(unresolvedCommentBorder, .4), light: transparent(unresolvedCommentBorder, .4), hcDark: transparent(unresolvedCommentBorder, .4), hcLight: transparent(unresolvedCommentBorder, .2) }, nls.localize('commentThreadActiveRangeBorder', 'Color of border for currently selected or hovered comment range.')); </del> const commentThreadStateBorderColors = new Map([ [languages.CommentThreadState.Unresolved, unresolvedCommentBorder],

Discussion:
I think a full range decoration would look nicer here: ! You can also use :
Last time I looked at this I didn't know about . With , I like this much more.
I this last milestone!
Is there any way to make the border only go around the outside of the selected area? Here's an example with the border as it currently is:
Unfortunately not, and it would be very complex to do that. I would just not use a border.
Change:
logger.info('Got account info!'); return { id: json.id, accountName: json.login }; } else { <del> logger.error(`Getting account info failed: ${result.statusText}`); throw new Error(result.statusText); </del> <ins> // either display the response message or the http status text let errorMessage = result.statusText; try { const json = await result.json(); if (json.message) { errorMessage = json.message; } } catch (err) { // noop } logger.error(`Getting account info failed: ${errorMessage}`); throw new Error(errorMessage); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 This issue addresses an issue, where the error message of the function of the github-authentication extension is not properly displayed to end users, but instead only the HTTP status is been displayed. This is not really a bug, but would have been really helpful to be in place, when I ran into this issue. Steps to Reproduce: a lot of requests from your GitHub account until the account is rate limited. to do any GitHub API related action in VSCode, for example running Github Copilot. the following Error displayed: the same error in the output of the github-authentication extension: Since this error message is not really helpful, the full message returned from the API would be good.
Change:
'comments.visible': { type: 'boolean', default: true, <del> description: nls.localize('comments.visible', "Controls the visibility of the comments bar and comment threads in editors that have commenting ranges and comments.") </del> <ins> description: nls.localize('comments.visible', "Controls the visibility of the comments bar and comment threads in editors that have commenting ranges and comments. Comments are still accessible via the Comments view and will cause commenting to be toggled on in the same way running the command "Comments: Toggle Editor Commenting" toggles comments.") </ins> } } });

Discussion:
Testing Steps: vscode PR with comments comments.visible to false :bug: =Comments view, comment ranges, plus icon, peek comment widget all seem to be present, even after reloading
I am seeing similar behavior, when I add to my settings and hover over it, it says so I am not sure if I am doing it incorrectly or if it is what SteVen is seeing.
it looks like you have a typo in "visible" making it unknown
yep that was my mistake Thanks for the fix, I got the setting working and found some different behavior from you. The comments disappeared for me after I switched the setting and so it hid PR comments I had in a python file.
I'm not able to reproduce this. Are there any other details of your setup that might be relevant? Worth noting: does not disable the Comments view. If you open the comments view then click on a comment then comment visibility will be toggled back on.
thanks for the explanation, that was my confusion. can we repurpose this issue to address the confusion in the setting description. Perhaps an additional sentence: You can still access comments via the comments view and this setting will be ignored for the remainder of the session if so.
Change:
}); <del> return this._sequencer.queue(key, () => super.set(key, value)); </del> <ins> return super.set(key, value); </ins> } private notifyOfNoEncryptionOnce = once(() => this.notifyOfNoEncryption());

Discussion:
Hi thank you for your reply. After start VSCode Insider with the parameters , when I try to authorize the Github Copilot the message returned at terminal is: ExtensionUrlTrustService#isExtensionUrlTrusted There are no configured trusted keys and the authentication process never ends. Originally posted by in
Can you follow these steps so that we can get more information on what's going on? Open the Command Palette Run the command To the right of , click the double check mark button. (enables trace logging as the default) Start the login, wait for the issue to happen... Open the Output pane (cmd+shift+u) drop in this issue he contents of the following: Output channel Output channel Output channel Open the Command Palette Run the command To the right of , click the double check mark button. (to set the default back to info)
same here
can you follow the steps?
You know what, this is likely fixed in this ^^ PR. Let's see what tomorrow's Insider build has
Cool! Thanks! Waiting for the next version.
I will try with the updated version and return here.
Confirm the latest version released today fixed everything!
Problem solved!!! Thank you guys.
Change:
localize('addWorkspaceFolderMessage', "Do you trust the authors of the files in this folder?"), [localize('yes', 'Yes'), localize('no', 'No')], { <del> detail: localize('addWorkspaceFolderDetail', "You are adding files to a trusted workspace that are not currently trusted. Do you trust the authors of these new files?"), </del> <ins> detail: localize('addWorkspaceFolderDetail', "You are adding files that are not currently trusted to a trusted workspace. Do you trust the authors of these new files?"), </ins> cancelId: 1, custom: { icon: Codicon.shield } }

Discussion:
The sentence sounds to me like the trusted workspace isn't currently trusted rather than the file. Maybe reorganising it to can make it clearer? Source:
Change:
return this.currentColorTheme; } <del> public getColorThemes(): Promise<IColorTheme[]> { return this.colorThemeStore.getColorThemes(); </del> <ins> public async getColorThemes(extensionId?: ExtensionIdentifier): Promise<IColorTheme[]> { const colorThemes = await this.colorThemeStore.getColorThemes(); return extensionId ? colorThemes.filter(c => ExtensionIdentifier.equals(new ExtensionIdentifier(c.extensionData.extensionId), extensionId)) : colorThemes; </ins> } public getTheme(): ITheme {

Discussion:
Improve user experience while installing themes
!
It would be cool if you could preview themes in the store, maybe with a split view hosting some example code, or even with the files you have open.
Please open a feature request for it
Change:
} }, styleController: new DefaultStyleController(DOM.createStyleSheet(container), treeClass), <del> accessibilityProvider: instantiationService.createInstance(SettingsAccessibilityProvider) </del> <ins> accessibilityProvider: instantiationService.createInstance(SettingsAccessibilityProvider), collapseByDefault: true </ins> }; super(container,

Discussion:
Issue Type: <bBug</bTesting Repo settings editor to the section click to switch to instead of Bug TOC is collapsed. Any scrolling causes the TOC to be expanded at the correctly again VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-29T06:13:57.866Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Probably another case of The TOC tree sometimes maintains its selection/expansion state, sometimes not.
Hey should expansion state be preserved using the string identity? was for focus/selection, this is for expansion state.
Adding myself so I don't forget about this.
Let's merge this early June:
Thanks
Change:
}); } } <ins> export class CheckForVSCodeUpdateAction extends Action { static readonly ID = CheckForVSCodeUpdateActionId; static LABEL = nls.localize('checkForVSCodeUpdate', "Check for VS Code Update"); constructor( id: string, label: string, @IWorkbenchEnvironmentService private readonly environmentService: IWorkbenchEnvironmentService, @IUpdateService private readonly updateService: IUpdateService, ) { super(id, label, undefined, true); } run(): Promise<void> { return this.updateService.checkForUpdates({ windowId: this.environmentService.configuration.windowId }); } } </ins>

Discussion:
Ability to update VS Code from the command palette as I have disabled activity bar and have to reenable it to update VS Code. Also, there is a palette option to check for extensions updates, but not for the whole app Steps: Command palette VS Code
First timer here. Could I give this one a shot?
I can do this work.
Hello there, I'm experienced developer and would like to contribute.
Hello there, I am a developer and I have gone through the whole code base and I think that I can add this feature without much problem. Can I please give it a shot?
Please do, you can check the
I have implemented this feature in . Kindly review it.
Works nicely, for downloading updates, but a command doesn't show to Restart To Update.
Change:
return message; } <ins> const getPreviousCommitMessage = async () => { //Only return the previous commit message if it's an amend commit and the repo already has a commit if (opts && opts.amend && repository.HEAD && repository.HEAD.commit) { return (await repository.getCommit('HEAD')).message; } }; </ins> return await window.showInputBox({ placeHolder: localize('commit message', "Commit message"), prompt: localize('provide commit message', "Please provide a commit message"), <ins> value: await getPreviousCommitMessage(), </ins> ignoreFocusOut: true }); };

Discussion:
VSCode Version: Code - Insiders 1.17.0-insider (, 2017-09-26T05:24:48.911Z) OS Version: Windows_NT x64 10.0. Extensions: none Testing Steps to Reproduce: some change Staged (Amend) I'm asked for a new commit message without the existing one as the default. I usually want to keep the existing one.
yeah may be we can add an option to keep the older message. I mean prefill the text box with the latest commit message..
I'm assuming this is not in version 1.18.1. Can I expect this in 1.18.2? Because I'm looking for this to amend the commit properly (both the diff and the message). I keep having to go back to the command line and issue because VSCode's Commit Staged (Amend) option shows a blank message.
No, this will be in 1.19.
I upgrade to 1.19, and this works, however we use gerrit which has a Change-Id in the commit message, and the newline is removed when to the commit message box. Which means when I upload the change to gerrit, it becomes a new patchset. Can this please not remove the newlines.
I see... I created this to track that issue:
Change:
} async function main(arch = process.arch): Promise<void> { <del> const version = product.electronRepository ? '19.1.10' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '19.1.11' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith
Change:
const actual3 = snippet3.toString(); assert.strictEqual(actual3, '.two.one.two.one <> .one.two.one.two'); }); <ins> test('Snippet choices are incorrectly escaped/applied #180132', function () { assertTextAndMarker('${1|aaa$aaa|}bbb$bbb', 'aaa$aaabbb$bbb', Placeholder, Text); }); </ins> });

Discussion:
This code inserts a snippet with some dollars but no backslashes: But it shows up with backslashes: !
Change:
box-sizing: border-box; border-width: 1px; border-color: transparent; <ins> } #container div.output .scrollable div { </ins> cursor: text; } <del> #container div.output .scrollable a { </del> <ins> #container div.output .scrollable div a { </ins> cursor: pointer; } #container div.output .scrollable.more-above {

Discussion:
create a notebook with a cell that produces long output: hover over the scrollbar within the output, it should be the pointer, but it is text
The scrollbar inherits the cursor style from this container and a override in doesn't seem to work.
Change:
} let child: ChildProcess; <del> if (!isMacintosh) { </del> <ins> if (!isBigSur) { </ins> // We spawn process.execPath directly child = spawn(process.execPath, argv.slice(2), options); } else { <del> // On mac, we spawn using the open command to obtain behavior </del> <ins> // On Big Sur, we spawn using the open command to obtain behavior </ins> // similar to if the app was launched from the dock // https://github.com/microsoft/vscode/issues/102975

Discussion:
Testing macOS Mojave 10.14.6 Version: 1.61.0-insider (Universal) Commit: Date: 2021-09-28T05:14:06.244Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 18.7.0 open terminal run
Same with
Nice catch! Two things to be done: 1) Rewire the cli to use old code path for macOS <= 10.15 for the endgame 2) Write wrapper around to be used instead of as follow-up.
Can someone explain what is different in Big Sur compared to older versions?
from the error above the following 3 std pipe arguments are not available on older distros. tool is not public, so I couldn't find the exact release notes where this behavior was changed. For now, the safer change is to not use the path pre Big Sur while we explore alternatives using for these versions in upcoming milestone.
Ok thanks, do we have an issue for that?
Tracked in
Change:
"include": [ "src/**/*", "../../src/vscode-dts/vscode.d.ts", <del> "../../src/vscode-dts/vscode.proposed.resolvers.d.ts", </del> "../../src/vscode-dts/vscode.proposed.workspaceTrust.d.ts", ] }

Discussion:
I don't think this should be lumped into the resolvers proposal. The JS/TS extension currently depends on resolvers just for this one property
Unsure, we really don't want anyone to use this and it only exists for complex reconnection explainers. Once such cases are more properly modelled it should go away again
What is JS/TS using this for? The normal modals should really be enough
looked this which doesn't seem to justify the use of a custom modal. So, I'd suggest to let TS use a normal modal dialog instead
Change:
padding: 0; } <del> .simple-fr-find-part .find-filter-button > .monaco-action-bar .action-label.notebook-filters { padding: 2px; } .simple-fr-find-part .find-filter-button > .monaco-action-bar .action-label.notebook-filters.checked { border-color: var(--vscode-inputOption-activeBorder); color: var(--vscode-inputOption-activeForeground); background-color: var(--vscode-inputOption-activeBackground); } </del> .monaco-workbench .simple-fr-find-part .monaco-inputbox > .ibwrapper > .input, .monaco-workbench .simple-fr-replace-part .monaco-inputbox > .ibwrapper > .input { height: 24px;

Discussion:
! When I enable the other toggles like match word, it has a small border, but the filter doesn't have that.
Change:
weight: KeybindingWeight.WorkbenchContrib }, { <del> when: NOTEBOOK_EDITOR_FOCUSED, primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, }, weight: KeybindingWeight.WorkbenchContrib </del> <ins> when: ContextKeyExpr.and(NOTEBOOK_CELL_EDITOR_FOCUSED, CONTEXT_ACCESSIBILITY_MODE_ENABLED), primary: KeyMod.CtrlCmd | KeyCode.PageDown, mac: { primary: KeyMod.WinCtrl | KeyCode.PageUp, }, weight: KeybindingWeight.WorkbenchContrib + 1 </ins> }, ] });

Discussion:
mentioned that the current keybinding for this controls speech rate for jaws users on windows should be used for code chat next code block and go to next /previous cell
related ctrl+pagedown/pageup are currently bound to next/previous editor
shouldn't those have context keys though that will mean this can still work for notebook cells?
next/previous editor don't have context keys for those keybindings, so it will be a behavior change. We could add the bindings just for SR mode if you don't think those users would be annoyed by it.
what do you think? I also don't want to surprise users with this behavior change.
I don’t think this is a surprise change. If we weigh the tradeoff, going with the new keybindings avoiding SR keys might be more beneficial in the long run.