jiebi/CodeConvo huggingface dataset:
Change:
} class ServerInitializingIndicator extends Disposable { <del> private _task?: { project: string | undefined, resolve: () => void, reject: () => void }; </del> <ins> private _task?: { project: string | undefined, resolve: () => void, reject: (error: Error) => void }; </ins> public reset(): void { if (this._task) { <del> this._task.reject(); </del> <ins> const error = new Error('Canceled'); error.name = error.message; this._task.reject(error); </ins> this._task = undefined; } }

Discussion:
Running insiders with the insiders extension looking at devtools I see: Version:
could this be coming from vscode-extension-telemetry? When I debug, I see as one of the frames. When I remove vscode-extension-telemetry the error comes from c:Usersalros.vscode-insidersextensionsnodemodulesvscode-extension-telemetrylib Does this mean that the error doesn't come from vscode-extension-telemetry and that vscode-extension-telemetry is just surfacing the error?
I'm not sure. There was a bug with warnings being spammed to the console but this seems different. Looking at the minified code doesn't seem to have anything super special in it just publishing to a channel. Is there any sort of message with the error or just that a promise rejected?
No message, the reason is always as in Ben's example. I didn't find any better stack or message.
This is very hard to track down as we have to do some pretty hacky things with bundling and app insights for the telemetry module. I could provide you with a module without minification if that helps.
Trying it without minification is a reasonable next step if it isn't too much work for you to build it.
Let me know if this works for you, it's a but GitHub only allows so you will have to rename it
Any update?
Not yet, I've been focusing on issue grooming. I expect to get back to this issue next week!
No luck getting a better error or stack without minification. I'll keep digging.
Build a version of VSCode without minify locally maybe?
Even with everything unminified the error is still undefined.
Did it happen to give you a better line number for the telemetry module error? It's a bit difficult to see where this promise originates from in the minified code.
no, I didn't find anything else there. However, I've just found the source. I have no idea why this gets attributed to the telemetry module or to GHPRI, but the rejection is coming from here:
there's a promise getting rejected in the the typescript extension: It keeps getting attributed to other extensions and modules (maybe because GHPRI opens the file that causes the typescript extension to activate?). Can we add a rejection reason to this and/or stop it from happening?

To easily repro the rejection: GHPRI pre-release a folder with a GitHub repository and PRs, where the first file in the PR is ts or js. all files (not sure if this is needed). . the Pull Requests view click on a PR and Checkout the PR.
Discussed a bit with and adding a "Canceled" reason is what is done in other places like this. I've confirmed that with with "Canceled" reason it no longer gets logged to the console and I've opened a PR for this.
Change:
contribMergeEditorMenus: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribMergeEditorMenus.d.ts', contribRemoteHelp: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribRemoteHelp.d.ts', contribShareMenu: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribShareMenu.d.ts', <del> contribViewSize: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribViewSize.d.ts', </del> contribViewsRemote: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribViewsRemote.d.ts', contribViewsWelcome: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribViewsWelcome.d.ts', customEditorMove: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.customEditorMove.d.ts',

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As you can see, the 'open editors' view has dynamic height according to its content. Can we customize our view( which in inside custom view container) height like that? !
Open editors has some custom code for doing this I believe this is not possible with custom views, and I think is a feature request against custom views thus forwarding to
Notes about proposal: Example
Example with the latest proposal
Change:
}); return; } // Fallback to searching quick access <del> this._quickInputService.quickAccess.show(link); </del> <ins> return this._quickInputService.quickAccess.show(link); } private async _getExactMatch(sanitizedLink: string, link: string): Promise<URI | undefined> { let exactResource: URI | undefined; if (isAbsolute(sanitizedLink)) { const scheme = this._environmentService.remoteAuthority ? Schemas.vscodeRemote : Schemas.file; const resource = URI.from({ scheme, path: sanitizedLink }); const fileStat = await this._fileService.resolve(resource); if (fileStat.isFile) { exactResource = resource; } } if (!exactResource) { const results = await this._searchService.fileSearch( this._fileQueryBuilder.file(this._workspaceContextService.getWorkspace().folders, { // Remove optional :row:col from the link as openEditor supports it filePattern: sanitizedLink, maxResults: 2 }) ); if (results.results.length === 1) { exactResource = results.results[0].resource; } } return exactResource; </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: "Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)
+1
duplicate of
Can we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.
Can reproduce the problem, it should say folder not file: ! !
Repros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:
So the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !
let's wait until is back for that. I'm considering this verified for now
Problem is back, looks a little different though: !
I think the new problem is Windows only
Change:
return result; } <del> // function extractState </del> function testTokensAdjustment(rawInitialState: string[], edits: ISingleEditOperation[], rawFinalState: string[]) { const initialState = parseTokensState(rawInitialState); const model = createTextModel(initialState.text);

Discussion:
This was filed at , but I believe the crash is a VS Code issue. I can reproduce the issue by doing the following: Set up a Dart SDK and install the Dart extension Open an empty folder and create a file with the following contents (and no trailing newline): Run the "Organize Imports" command VS Code immediately hangs and the cursor stops flashing, eventually reporting the crash and asking to reopen/close I ran the Dart language server from source and stripped out a lot of the capabilities to reduce the traffic. When removing the Semantic Tokens capability, the issue stops occurring, so it may be related to semantic tokens but I'm not certain. Here is the LSP log (the version running the reduced set of Dart server capabilities): Here is the crash-dump folder: Symbolicated: , though (mentioned at ) is a 404 so these may be incomplete. I've not had any luck reproducing this without the Dart extension/server by writing extension code that just applies the same edits (possibly because it requires semantic tokens) nor have I spotted anything unusual in the LSP traffic, but I'll have another go through these and post back if I figure anything out. Hopefully the crash log will help though. VS Code version:
I was able to reproduce this in an isolated test extension by just hard-coding semantic tokens and the edits: The complete code looks like this (though you'll need to contribute the "danny" language or change it.. I didn't want to reuse an existing language incase it had its own semantic tokens):
Doesn't seem to reproduce in the . However, I can observe in VS Code that LineTokens is created with unsorted offsets:
Thank you for the clean repro!
Fix LGTM, thanks! /verified
Change:
default: DEFAULT_LOCAL_ECHO_EXCLUDE, }, [TerminalSettingId.LocalEchoStyle]: { <del> description: localize('terminal.integrated.localEchoStyle', "Experimental: terminal style of locally echoed text; either a font style or an RGB color."), </del> <ins> description: localize('terminal.integrated.localEchoStyle', "Terminal style of locally echoed text; either a font style or an RGB color."), </ins> default: 'dim', oneOf: [ {

Discussion:
Are all these settings still "experimental"? This seems like a mature feature !
This is a good point. I believe the wording is used to indicate the functionality has some quirks. We will see if thinks it's fine to remove it.
Yep let's do it, I think we just didn't remember to remove
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ // empty placeholder for view size // https://github.com/microsoft/vscode/issues/122283 @alexr00 /** * View contributions can include a `size`, which can be a number. A number works similar to the css flex property. * * For example, if you have 3 views, with sizes 1, 1, and 2, the views of size 1 will together take up the same amount of space as the view of size 2. * * A number value will only be used as an initial size. After a user has changed the size of the view, the user's choice will be restored. */ </del>

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As you can see, the 'open editors' view has dynamic height according to its content. Can we customize our view( which in inside custom view container) height like that? !
Open editors has some custom code for doing this I believe this is not possible with custom views, and I think is a feature request against custom views thus forwarding to
Notes about proposal: Example
Example with the latest proposal
Change:
resolved "https://registry.yarnpkg.com/@vscode/iconv-lite-umd/-/iconv-lite-umd-0.7.0.tgz#d2f1e0664ee6036408f9743fee264ea0699b0e48" integrity sha512-bRRFxLfg5dtAyl5XyiVWz/ZBPahpOpPrNYnnHpOpUZvam4tKH35wdhP4Kj6PbM0+KdliOsPzbGWpkxcdpNB/sg== <del> "@vscode/l10n-dev@0.0.21": version "0.0.21" resolved "https://registry.yarnpkg.com/@vscode/l10n-dev/-/l10n-dev-0.0.21.tgz#c25a29c7d1484b1dacf4ba98fbd16c1b32a0087e" integrity sha512-KR3OvvLs8AGCWM3LHAAKUfltltANdGjX4fn2jfY13Eb5z4c6smR81p7a9yTo6Kr///zSZuBHQ/hXMmMRtuPTBw== </del> <ins> "@vscode/l10n-dev@0.0.30": version "0.0.30" resolved "https://registry.yarnpkg.com/@vscode/l10n-dev/-/l10n-dev-0.0.30.tgz#0d49ed3411cb145047167a2b4b6767ed6478a42f" integrity sha512-m/5voX3NtGCVQ/UjKajvwW9PPvjjvcuvEKiKRkf7dS8Q/JT+Sa5XJK70JrVuuwbfGwZktrBBhF25Eu9SXv4Q6A== </ins> dependencies: <ins> debug "^4.3.4" </ins> deepmerge-json "^1.5.0" <del> glob "^8.0.3" </del> <ins> glob "^10.0.0" </ins> pseudo-localization "^2.4.0" <del> web-tree-sitter "^0.20.7" xml2js "^0.4.23" yargs "^17.5.1" </del> <ins> web-tree-sitter "^0.20.8" xml2js "^0.5.0" yargs "^17.7.1" </ins> "@vscode/policy-watcher@^1.1.4": version "1.1.6"

Discussion:
<img width="415" alt="image" src=""Looks localized here though, and hasn't changed in 13 months
language pack looks ok too... Looking into this some more... it seems that the new lines aren't being handled properly.
This still repros :/ is the loc pipeline maybe not running?
it is the newlines... which I thought I fixed... sigh... They are being escaped in the language pack: if I manually delete these extra slashes locally, the problem goes away.
Update... the text has change: Now it's using when it should use and I think I know why. So exporting looks find: is turned in to (we do this manually and it's the XML way to say ) but what we get from the translators... they replace with actual new lines That's not what I was expecting. I would expect them to use the encoded characters but they're not. hacky quick fix that fixes likely most of the scenarios: more accurate longer fix: now that I think about it, this is probably the correct workaround for extensions as well
<img alt="image" src=""Looks like it works now
Change:
// For single logged variables, try to use the output if we can so // present a better (i.e. ANSI-aware) representation of the output if (resolved.length === 1) { <del> this.appendToRepl({ output: event.body.output, expression: resolved[0], sev: Severity.Info, source }, event.body.category === 'important'); </del> <ins> this.appendToRepl({ output: event.body.output, expression: resolved[0], sev: outputSeverity, source }, event.body.category === 'important'); </ins> return; } resolved.forEach((child) => { // Since we can not display multiple trees in a row, we are displaying these variables one after the other (ignoring their names) (<any>child).name = null; <del> this.appendToRepl({ output: '', expression: child, sev: Severity.Info, source }, event.body.category === 'important'); </del> <ins> this.appendToRepl({ output: '', expression: child, sev: outputSeverity, source }, event.body.category === 'important'); </ins> }); }); return;

Discussion:
on macOS ventura, using Angular 12. See screenshot. ! The line of code below is what causes the above error to be logged: But the text is grey, and there doesn't seem to be a way around this, which is a problem.
Seems like the class is not applied to stderr output with variablesReferences
I think there is an issue for this, I can't find it right now. Started working on it but needs a little refactor
Going to steal this since involves fixing that todo
Change:
return withUndefinedAsNull(cachedState); } <ins> override getViewState(): object | undefined { return this.viewState; } </ins> override setOptions(options: ISettingsEditorOptions | undefined): void { super.setOptions(options);

Discussion:
Issue Type: <bBug</bthe settings UI. for a setting (e.g. "inlay"). the settings tab to a new editor group. Note that the search you entered previously has been cleared. https://user- VS Code version: Code 1.60.0 (, 2021-09-01T10:54:53.442Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 vscode-nginx-conf0.1.3 reorder-lines-by-length1.0.2 docs-view0.0.9 pgformatter1.17.0 vscode-eslint2.1.25 gitlens11.6.0 vscode-diff1.4.2 shell-format7.1.0 go0.27.2 postgresql0.0.2 rainbow-csv1.9.1 render-crlf1.5.21 template-string-converter0.5.3 python2021.9. vscode-pylance2021.9.2 jupyter2021.8. jupyter-keymap1.0.0 debugger-for-chrome4.13.0 nbsp-vscode0.0.1 vscode-commons0.0.6 vscode-yaml0.22.0 final-newline0.3.2 vscode-hexdump1.8.1 change-case1.0.0 markdown-all-in-one3.4.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
A function called in is being called after the drop, which is correct. But, the function in the same file name isn't being called when the user does step 3 above. Another repro is to use the "move editor to X group" commands. Therefore, the fix doesn't have to do directly with dnd.
Change:
}, "outputCapture": "std", "args": [ <del> "--delay", "--timeout", "2000" </del> <ins> "--remote-debugging-port=9222" </ins> ], "cwd": "${workspaceFolder}", <del> "env": { "ELECTRON_RUN_AS_NODE": "true" }, </del> "outFiles": [ "${workspaceFolder}/out/**/*.js" ]

Discussion:
Issue Type: <bBug</bRepo VS Code code base launch the debug configuration Bug In the debug console, see the following error: I've tried a clean and rebuild but haven't been able to get this working VS Code version: Code - Insiders 1.30.0-insider (, 2018-11-19T19:59:44.607Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
After disabling the uri check temporarily, I now get:
Not my launch-config. TBH - I have never used our debugger for tests, I use
I didn't know about the --debug option. I've never understood why the debug config setup is totally different than the typical running setup. Why don't we launch in the same way as --debug but attach the vscode debugger? I'll take a look when I get a chance.
Change:
const ext = URI.Utils.extname(uri).toLowerCase().replace('.', ''); const insertAsImage = typeof options?.insertAsImage === 'undefined' ? imageFileExtensions.has(ext) : !!options.insertAsImage; <ins> const insertAsVideo = videoFileExtensions.has(ext); </ins> <del> snippet.appendText(insertAsImage ? '![' : '['); </del> <ins> if (insertAsVideo) { snippet.appendText(`<video src="${mdPath}" controls title="`); snippet.appendPlaceholder('Title'); snippet.appendText('"></video>'); } else { snippet.appendText(insertAsImage ? '![' : '['); </ins> <del> const placeholderText = options?.placeholderText ?? (insertAsImage ? 'Alt text' : 'label'); const placeholderIndex = typeof options?.placeholderStartIndex !== 'undefined' ? options?.placeholderStartIndex + i : undefined; snippet.appendPlaceholder(placeholderText, placeholderIndex); </del> <ins> const placeholderText = options?.placeholderText ?? (insertAsImage ? 'Alt text' : 'label'); const placeholderIndex = typeof options?.placeholderStartIndex !== 'undefined' ? options?.placeholderStartIndex + i : undefined; snippet.appendPlaceholder(placeholderText, placeholderIndex); </ins> <del> snippet.appendText(`](${mdPath})`); </del> <ins> snippet.appendText(`](${mdPath})`); } </ins> if (i < uris.length - 1 && uris.length > 1) { snippet.appendText(options?.separator ?? ' ');

Discussion:
Testing https://user-
I think this should rather generate tags instead of the relative link syntax for mp4 files?
Verified. Can't play the video in the preview, but not sure I should be able to. https://user-
It may be because you're in an untitled file, so we can't actually resolve that video path (since it is a relative path). Could you please try again having saved the text file to disk?
oh indeed works like magic <img width="1233" alt="image" src="https://user-"
Change:
when: ContextKeyExpr.and( ContextKeyExpr.has(HistoryNavigationWidgetFocusContext), ContextKeyExpr.equals(HistoryNavigationForwardsEnablementContext, true), <ins> ContextKeyExpr.not('isComposing'), </ins> historyNavigationVisible.isEqualTo(false), ), primary: KeyCode.DownArrow,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: code -v: 1.78.0 arm64 OS Version: macOS monterey 12.4 Steps to Reproduce: i use macOS origin input to type chinese in left sider search input, when i want to use arrow down to select target chinese word. the input content changed by arrow down. there is a reproduce video. https://user-
Change:
if (connectionInfo) { const linkToOpen = that.getLinkToOpen(connectionInfo); const remoteExtension = that.serverConfiguration.extension; <del> const linkToOpenForMarkdown = linkToOpen.toString().replace(/)/g, '%29'); </del> <ins> const linkToOpenForMarkdown = linkToOpen.toString(false).replace(/)/g, '%29'); </ins> await notificationService.notify({ severity: Severity.Info, message:

Discussion:
copies a url-encoded filepath copies a url-encoded filepath, e.g. becomes , which also yields a "Workspace does not exist" warning message. Originally posted by in
Candidate PR for 1.76:
Change:
"json.tracing.desc": "Traces the communication between VS Code and the JSON language server.", "json.colorDecorators.enable.desc": "Enables or disables color decorators", "json.colorDecorators.enable.deprecationMessage": "The setting `json.colorDecorators.enable` has been deprecated in favor of `editor.colorDecorators`.", <ins> "json.schemaResolutionErrorMessage": "Unable to resolve schema.", </ins> "json.clickToRetry": "Click to retry." }

Discussion:
testing : Yes, there is now a warning icon in the status bar, but it is difficult to understand its purpose: For a json scheme url with a non-existing hostname the hover message shows this: ! For a json scheme url with a non-existing version number the hover message shows this: ! In both cases the error shown is too low-level and the message does not explain that the status refers to the json scheme of the current editor contents.
FYI
Looks like I misinterpreted what kind of messages I'd get from the backend, sorry for that! We could resort to showing a generic message like 'Unable to resolve JSON schema from (url)', which would probably be sufficient for most issues. I also considered logging the error to console (don't know your policy on that), but if we get whole pages in the error message, that's not an option. Displaying a generic message with the URL only would also Otherwise I guess we'd need to parse the error message to find out which kind and display a meaningful message, but that doesn't seem right. Another implication of this is that we'll probably have to re-add at least one layer of error description to vscode-languageservice-json - I always had a prefix with something like "Unable to resolve (something)", but that might have been a code reloading issue or specific to the way I was testing, by cutting the Internet connection and blocking DNS resolutions. Let me know if a generic error message defined only in the client would work.
That's fine. Users don't really see logs.
I can repro with this setting: