jiebi/CodeConvo huggingface dataset:
Change:
jsonfile "^4.0.0" universalify "^0.1.0" <del> fsevents@~2.1.2: version "2.1.3" resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.1.3.tgz#fb738703ae8d2f9fe900c33836ddebee8b97f23e" integrity sha512-Auw9a4AxqWpa9GUfj370BMPzzyncfBABW8Mab7BGWBYDj4Isgq+cDKtx0i6u9jcX9pQDnswsaaOTgTmA5pEjuQ== </del> <ins> fsevents@~2.3.1: version "2.3.1" resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.3.1.tgz#b209ab14c61012636c8863507edf7fb68cc54e9f" integrity sha512-YR47Eg4hChJGAB1O3yEAOkGO+rlzutoICGqGo9EZ4lKWokzZRSyIW1QmTzqjtw8MJdj9srP869CuWw/hyzSiBw== </ins> glob-parent@~5.1.0: version "5.1.0"

Discussion:
Steps to Reproduce: on Apple SI a folder in devtools:
Related failing unit test:
Chokidar v3.5.0 was just released that takes in fsevents universal build , we can update to it.
yep this required compiling fsevents as universal binary
Change:
if (viewModel.model.unhandledConflictsCount.get() > 0) { const confirmResult = await dialogService.confirm({ type: 'info', <del> message: localize('mergeEditor.acceptMerge.unhandledConflicts', "There are still unhandled conflicts. Are you sure you want to accept the merge?"), primaryButton: localize('mergeEditor.acceptMerge.unhandledConflicts.accept', "Complete merge with unhandled conflicts"), </del> <ins> message: localize('mergeEditor.acceptMerge.unhandledConflicts.message', "Do you want to complete the merge of {0}?", basename(inputModel.resultUri)), detail: localize('mergeEditor.acceptMerge.unhandledConflicts.detail', "The file contains unhandled conflicts."), primaryButton: localize('mergeEditor.acceptMerge.unhandledConflicts.accept', "Complete with Conflicts"), </ins> secondaryButton: localize('mergeEditor.acceptMerge.unhandledConflicts.cancel', "Cancel"), });

Discussion:
<img width="364" alt="image" src="https://user-"I think this dialog could get some UX love. If we want to keep the very long primary button label, I would use title casing to be consistent with other dialog buttons. But I also think just having "Accept Merge" is fine, given the message in the dialog points out about the conflicts. //cc
Now that I see this dialog: <img width="291" alt="image" src="https://user-"I think we can align both How about: "Accept with Conflicts" using in the dialog "The file contains unhandled conflicts"
PR:
Change:
localize('storeEditSessionTitle', 'Store Edit Session') ) ), <del> when: ContextKeyExpr.and(ContextKeyExpr.equals(EDIT_SESSIONS_SIGNED_IN_KEY, true), ContextKeyExpr.equals(EDIT_SESSIONS_COUNT_KEY, 0)), </del> <ins> when: ContextKeyExpr.equals(EDIT_SESSIONS_COUNT_KEY, 0), </ins> order: 1 });

Discussion:
Testing I would expect that this action always appears in the command palette. Today, it only appears after running or first.
Change:
KeybindingsRegistry.registerCommandAndKeybindingRule({ id: 'list.find', weight: KeybindingWeight.WorkbenchContrib, <del> when: ContextKeyExpr.and(RawWorkbenchListFocusContextKey, WorkbenchTreeSupportsFind), </del> <ins> when: ContextKeyExpr.and(RawWorkbenchListFocusContextKey, WorkbenchListSupportsFind), </ins> primary: KeyMod.CtrlCmd | KeyCode.KeyF, secondary: [KeyCode.F3], handler: (accessor) => {

Discussion:
I think this came up during the standup today, why is the context key called and not ? //cc
This context key came in quite late via a fix -- . I noticed this standing out because of the default keybindings which seem to mix things up: Giving this a candidate in case we want to align the context key before shipping stable
From
Change:
import { SimpleButton, findPreviousMatchIcon, findNextMatchIcon, NLS_NO_RESULTS, NLS_MATCHES_LOCATION } from 'vs/editor/contrib/find/browser/findWidget'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextViewService } from 'vs/platform/contextview/browser/contextView'; <del> import { editorWidgetBackground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, errorForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { editorWidgetBackground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, errorForeground, toolbarHoverBackground, toolbarHoverOutline } from 'vs/platform/theme/common/colorRegistry'; </ins> import { IColorTheme, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { ContextScopedFindInput } from 'vs/platform/history/browser/contextScopedHistoryWidget'; import { widgetClose } from 'vs/platform/theme/common/iconRegistry'; import * as strings from 'vs/base/common/strings'; <ins> import { TerminalCommandId } from 'vs/workbench/contrib/terminal/common/terminal'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; </ins> const NLS_FIND_INPUT_LABEL = nls.localize('label.find', "Find"); <del> const NLS_FIND_INPUT_" = nls.localize('placeholder.find', "Find"); </del> <ins> const NLS_FIND_INPUT_" = nls.localize('placeholder.find', "Find (u21C5 for history)"); </ins> const NLS_PREVIOUS_MATCH_BTN_LABEL = nls.localize('label.previousMatchButton', "Previous Match"); const NLS_NEXT_MATCH_BTN_LABEL = nls.localize('label.nextMatchButton', "Next Match"); const NLS_CLOSE_BTN_LABEL = nls.localize('label.closeButton', "Close");

Discussion:
And instead pass in (or don't) a new option for the type
so the complexity here is that we can't reference the keybinding service within the super call to the constructor and need to do that to provide the options to the find input object that's read only.
the alternative would be to pass in the options from both the terminal view and terminal editor (redundant)
going to pass in an options object and handle the keybinding in simple find widget
Spent awhile on this, don't think we will get to it
Change:
name.textContent = localize('auto', "Auto"); } else if (this._historyItemsFilter.length === 1) { name.textContent = this._historyItemsFilter[0].name; <del> reset(this.label, ...renderLabelWithIcons(`$(git-branch) ${this._historyItemsFilter[0].name}`)); </del> } else { name.textContent = localize('items', "{0} Items", this._historyItemsFilter.length); }

Discussion:
Type: <bBug</b! I expected an upstream/main badge on the tree, and that badge on the hover tip to have a colour. VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-10T05:04:21.546Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
/assign
Nice catch! Fix should be in tomorrow's Insiders release.
Change:
import * as vscode from 'vscode'; import { CommandManager } from './commandManager'; import * as commands from './commands/index'; <ins> import { MdDefinitionProvider } from './languageFeatures/definitionProvider'; </ins> import { MdLinkProvider } from './languageFeatures/documentLinkProvider'; import { MdDocumentSymbolProvider } from './languageFeatures/documentSymbolProvider'; import { registerDropIntoEditor } from './languageFeatures/dropIntoEditor';

Discussion:
Enable triggering go to definition on a markdown reference link to jump to the link definition Go to def should jump to the definition at the end of the file
Related
Created a PR fixing this
Works well, I was a bit confused to see this tooltip with 'Execute command' though, is there a way to make that more context-specific? !
Change:
dom.clearNode(this._outputNode); dom.clearNode(this._showExistingKeybindingsNode); const firstLabel = new KeybindingLabel(this._outputNode, OS, defaultKeybindingLabelStyles); firstLabel.set(withNullAsUndefined(this._chords?.[0])); if (this._chords) { for (let i = 1; i < this._chords.length; i++) { this._outputNode.appendChild(document.createTextNode(nls.localize('defineKeybinding.chordsTo', "chord to"))); const chordLabel = new KeybindingLabel(this._outputNode, OS, defaultKeybindingLabelStyles); chordLabel.set(this._chords[i]); } } const label = this.getUserSettingsLabel();

Discussion:
Type: <bBug</bPreviously pressing escape while "Record Keys" was active in the keybindings UI would disable key recording and leave the search query intact. Now it disables key recording and clears the search query which makes it much harder to use. I traced this regression to 1.78. I'm guessing this is an issue with keybindings. The binding for is being processed in addition to the (hard-coded?) binding to stop recording. ! VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-04T22:11:08.187Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
id: SelectionToWatchExpressionsAction.ID, label: SelectionToWatchExpressionsAction.LABEL, alias: 'Debug: Add to Watch', <del> precondition: ContextKeyExpr.and(EditorContextKeys.hasNonEmptySelection, CONTEXT_IN_DEBUG_MODE, EditorContextKeys.editorTextFocus), </del> <ins> precondition: ContextKeyExpr.and(EditorContextKeys.hasNonEmptySelection, EditorContextKeys.editorTextFocus), </ins> contextMenuOpts: { group: 'debug', order: 1

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This action doesn't require debug mode. A user can optionally add it as a precondition to a keyboard shortcut if they so choose.
Can I work on this?
Yes please!
I see that there is already a before, that pr modification is not quite right?
I hadn't seen that, are you looking at it
hi , will solve the problem?
Change:
} const pathChars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'; <ins> const windowsSafePathFirstChars = 'BDEFGHIJKMOQRSTUVWXYZbdefghijkmoqrstuvwxyz0123456789'; </ins> export function randomPath(parent?: string, prefix?: string, randomLength = 8): string { let suffix = ''; for (let i = 0; i < randomLength; i++) { <del> suffix += pathChars.charAt(Math.floor(Math.random() * pathChars.length)); </del> <ins> let pathCharsTouse: string; if (i === 0 && isWindows && !prefix && (randomLength === 3 || randomLength === 4)) { // Windows has certain reserved file names that cannot be used, such // as AUX, CON, PRN, etc. We want to avoid generating a random name // that matches that pattern, so we use a different set of characters // for the first character of the name that does not include any of // the reserved names first characters. pathCharsTouse = windowsSafePathFirstChars; } else { pathCharsTouse = pathChars; } suffix += pathCharsTouse.charAt(Math.floor(Math.random() * pathCharsTouse.length)); </ins> } let randomFileName: string;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.1 OS Version: Windows 10 Steps to Reproduce: Can't really provide some simple instructions to reproduce because random values generated by vscode during runtime are the actual issue. After regular use I ended up with a file named "LPt4" in AppDataRoamingCodeUserHistory. The filename is a reserved filename on windows like CON, COM1, LPT1 etc. The file can't be deleted by the user using windows explorer or accessed by normal tools which broke my backup software. Solution is to use del command in and provide a complete UNC path to delete the file. Source of bug probably is in doAddEntry() The file generated has a random 4 character prefix which by accident can be a reserved filename. I propose to just extend the length of the history filename so it is impossible to be a reserved filename on windows. At least would also need to be changed.
Good catch, I think we need a random file path generator that also calls into this validator: I wonder if we have other places where this can happen. We should probably check.
Change:
import { disposableTimeout, Throttler } from 'vs/base/common/async'; import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; <del> import { ICellVisibilityChangeEvent, NotebookVisibleCellObserver } from 'vs/workbench/contrib/notebook/browser/contrib/statusBar/notebookVisibleCellObserver'; </del> <ins> import { NotebookVisibleCellObserver } from 'vs/workbench/contrib/notebook/browser/contrib/statusBar/notebookVisibleCellObserver'; </ins> import { ICellViewModel, INotebookEditor, INotebookEditorContribution } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; import { registerNotebookContribution } from 'vs/workbench/contrib/notebook/browser/notebookEditorExtensions'; <del> import { NotebookViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel'; </del> <ins> import { CellViewModel, NotebookViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel'; </ins> import { INotebookCellStatusBarService } from 'vs/workbench/contrib/notebook/common/notebookCellStatusBarService'; import { INotebookCellStatusBarItemList } from 'vs/workbench/contrib/notebook/common/notebookCommon';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Basically when i have a statusbar item (extension that contributes statusbar items), VS Code re-creates all of the statusbar items for all cells. This causes ALL statubar items in all cells to flicker (as its destroyed and re-created) & we also end up with duplicates. /cc Flickering UI Duplicate statusbar items See below (from latest VS Code Insiders, can also replicate in latest main branch) Note how we end up with two language pickers in statusbar. ! After the fix (re-use instead of re-creating & only create what we need): !
Thought I had squashed all of these. Thanks for the PR!
The power tools don't seem to provide line numbers anymore so I tried switching the language mode around to repro and couldn't so I'm not sure if that's good enough for verification
I think it's sufficient to mess around with it and not see any dupes. And there were random reports of dupes earlier and I haven't heard that in awhile.
Change:
type: AccessibleViewType; } <ins> export const accessibilityHelpIsShown = new RawContextKey<boolean>('accessibilityHelpIsShown', false, true); </ins> class AccessibleView extends Disposable { private _editorWidget: CodeEditorWidget; <ins> private _accessiblityHelpIsShown: IContextKey<boolean>; </ins> get editorWidget() { return this._editorWidget; } private _editorContainer: HTMLElement; private _keyListener: IDisposable | undefined; constructor( @IOpenerService private readonly _openerService: IOpenerService, @IInstantiationService private readonly _instantiationService: IInstantiationService, @IConfigurationService private readonly _configurationService: IConfigurationService, @IModelService private readonly _modelService: IModelService, <del> @IContextViewService private readonly _contextViewService: IContextViewService </del> <ins> @IContextViewService private readonly _contextViewService: IContextViewService, @IContextKeyService private readonly _contextKeyService: IContextKeyService </ins> ) { super(); <ins> this._accessiblityHelpIsShown = accessibilityHelpIsShown.bindTo(this._contextKeyService); </ins> this._editorContainer = document.createElement('div'); this._editorContainer.classList.add('accessible-view'); const codeEditorWidgetOptions: ICodeEditorWidgetOptions = {

Discussion:
Testing ! Shows Ctrl + e , but that is mapped to "Go to file"
your image didn't work
Updated the image.
Verified with Windows.
Verified that this is now working with Linux and Orca
Change:
// Menu registration - open editors <ins> const isFileOrUntitledResourceContextKey = ContextKeyExpr.or(ResourceContextKey.IsFileSystemResource, ResourceContextKey.Scheme.isEqualTo(Schemas.untitled)); </ins> const openToSideCommand = { id: OPEN_TO_SIDE_COMMAND_ID, title: nls.localize('openToSide', "Open to the Side")

Discussion:
VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select "Select for Compare". click on any other item and select "Compare with Selected". ! Does this issue occur when all extensions are disabled?: Yes
//cc not sure we have a context key to use here already
Code pointer We would need to use that context key for all the compare context menu actions in the Open Editors view
isn't this just a matter of using for this command? We seem to be using this also to limit commands such as "Copy"?
you are correct, I checked and this is indeed the context key we needed here.
Will have to revert this due to
PR:
/verified
Change:
return Color.Format.CSS.parseHex(hex) || Color.red; } <ins> static equals(a: Color | null, b: Color | null): boolean { if (!a && !b) { return true; } if (!a || !b) { return false; } return a.equals(b); } </ins> readonly rgba: RGBA; private _hsla?: HSLA; get hsla(): HSLA {

Discussion:
Ruler background is set to black with 50% transparency, but vscode shows solid black! ! ! Description for editorOverviewRuler.background also says: , but vscode use this background if minimap is enabled or not!
The color description is out of date. We changed the behavior of via so we now always respect . However, it never supported transparency, so we could add support for that.
Change:
], "scm/resourceGroup/context": [ { <del> "command": "git.stageAll", </del> <ins> "command": "git.stageAllMerge", </ins> "when": "scmProvider == git && scmResourceGroup == merge", "group": "1_modification" }, { <del> "command": "git.stageAll", </del> <ins> "command": "git.stageAllMerge", </ins> "when": "scmProvider == git && scmResourceGroup == merge", "group": "inline" },

Discussion:
Issue Type: <bBug</bDuring a rebase (not sure if that's the only scenario), my SOURCE CONTROL tab display three sections, MERGE CHANGES, STAGED CHANGES and CHANGES. If I click the + button on the CHANGES section, in order to stage all items below CHANGES, VS Code also adds everything on MERGE CHANGES. VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-29T05:33:59.143Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ markdown-mermaid1.5.0 better-toml0.3.2 vscode-eslint2.1.5 gitlens10.2.1 plantuml2.13.8 svg1.1.8 vscode-peacock3.7.0 chat0.33.0 rust-analyzer0.2.151 vscode-todo-parser1.9.1 remote-wsl0.44.2 vsliveshare1.0.2104 vsliveshare-audio0.1.85 vsliveshare-pack0.3.4 vscode-xml0.11.0 vscode-yaml0.7.2 crates0.4.9 vscode-hexdump1.7.2 markdown-all-in-one2.8.0 </details<!-- generated by issue reporter --
Hello I would like to work on this issue if no one else is. Regards.
hey could you please review the pr that I have opened and also could you please suggest any changes if required.
Hi I'm also working on this issue. You can check my PR
I have gone through your PR also left a comment.
Change:
'terminal.ansiGreen': { index: 2, defaults: { <del> light: '#00BC00', </del> <ins> light: '#107C10', </ins> dark: '#0DBC79', hcDark: '#00cd00', <del> hcLight: '#00bc00' </del> <ins> hcLight: '#136C13' </ins> } }, 'terminal.ansiYellow': {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Mac Sonoma 14.3 Steps to Reproduce: Note: the following is just one way to easily reproduce, but this really is an issue with the CSS variable that affects more than just the Jupyter extension (hence why the issue is opened in this repository). the Jupyter extension a cell, execute code that in the cell output, the green color is using the theme variable <img width="263" alt="image" src=""the following in the terminal that the green ANSI styling is different in light themes: <img width="280" alt="image" src=""<img width="427" alt="image" src=""<img width="419" alt="image" src=""Works as expected in dark themes: <img width="377" alt="image" src=""<img width="290" alt="image" src=""This is a problem because in light theme, the contrast ratio requirement is not met. This means that when the CSS variable is used there will be an accessibility bug. Thanks!
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!

Confirmed reproing on 1.86.1 as well
Github Tags: #BM-VisualStudioCodeClient-Win32-Jan2024; #Visual Studio Code Client; #A11yMAS; #WCAG1.4.3; #AILimited; #A11yTCS; #ColorContrast; #A11ySev2;
the terminal has the minimum contrast ratio feature that fixes the contrast ratio, anywhere else that piggy backs on that color might not meet contrast.
Assigned to April as it comes from s360
so no matter what color we use, terminal will automatically adjust it? I can change the default color used to solve the contrast issue outside of terminal. Just not sure how to keep them aligned.
yes the terminal will by default slide the color to be 4.5:1 (). It's fine if their luminosity is a little inconsistent imo, we just need to make sure the color meets contrast elsewhere.
Tweaked colors for light and light hc themes in !
thanks a lot. I think we can close this bug as fixed now, right?
Build failing, will auto close when it merges