jiebi/CodeConvo huggingface dataset:
Change:
return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const focus = this.list.getFocus(); this.list.setSelection(focus, e.browserEvent); <del> e.browserEvent.preventDefault(); </del> } private changeSelection(e: IListMouseEvent<T> | IListTouchEvent<T>): void {

Discussion:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies
Change:
"displayName": "Emmet", "description": "%description%", "version": "1.0.0", <del> "publisher": "vscode", "license": "MIT", </del> <ins> "publisher": "vscode", "license": "MIT", </ins> "engines": { "vscode": "^1.13.0" },

Discussion:
Issue Type: <bFeature Request</bI'm not talking about the editor's horizontal scroll is a very thin scroll bar between the tabs and editor,that's what i'm talking about. When you open too many tabs,some tabs are invisible so you need scrolling horizontally. There's a scrollbar to scroll the tabs,but it's too thin. Of course,this wasn't a big bug or what,and I can use "Ctrl+Tab" to switch tabs. maybe this bar should be bigger or even disappear considering it's not helpful. VS Code version: Code 1.32.3 (, 2019-03-14T23:43:35.476Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.49 --<!-- potentialduplicatescomment --
Duplicate of
Oops, tagged wrong issue.
Change:
} }); <del> const viewKey = new Set<string>(); viewKey.add('focusedView'); </del> TabFocus.setTabFocusMode(configurationService.getValue('editor.tabFocusMode'), TabFocusContext.Editor); TabFocus.setTabFocusMode(configurationService.getValue(TerminalSettingId.TabFocusMode), TabFocusContext.Terminal); <del> this._register(contextKeyService.onDidChangeContext((c) => { if (c.affectsSome(viewKey)) { if (contextKeyService.getContextKeyValue('focusedView') === 'terminal') { TabFocus.setTabFocusMode(configurationService.getValue(TerminalSettingId.TabFocusMode), TabFocusContext.Terminal); } else { TabFocus.setTabFocusMode(configurationService.getValue('editor.tabFocusMode'), TabFocusContext.Editor); } } })); </del> } }

Discussion:
Testing into the editor. status bar still says "Tab Moves Focus". I think I'd only expect it to say that when I'm focused in the terminal.
If you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this
I never toggled it at all, this was just using the settings.

Testing an editor and write something in it. tab until you reach the terminal. Type something in the terminal. . Realize that tab is correctly not moving focus in the terminal. command "Toggle Tab Key Moves Focus" out of the terminal and keep tabbing until you get back to your editor. something in the editor. again until you reach the terminal. something in the terminal. to tab out of the terminal. It looks like tab moves focus as toggled itself off. Tab moves focus seems to be off for both terminal and editor at this point until reload.
I can also cause similar behavior if I flip the settings.
what is supposed to happen now? What I think I expect to happen (and isn't happening): If I run "Toggle tab key moves focus" while in a place where it doesn't move focus via setting, then it now globally moves focus. If I run "Toggle tab key moves focus" while in a place where it does move focus, then it now globally does not move focus. However, I'm not a "tab moves focus" user, so maybe my expectations are bogus.
Thank you for testing. Those expectations are correct, except that the toggling does not apply globally - it is per area. So, if I have in settings: terminal tab focus mode: on editor tab focus mode: off where: = status bar indicator = no status bar indicator focus the terminal focus the editor focus the terminal and toggle it off focus the editor and toggle it on focus the terminal focus the editor reload the window and focus the terminal focus the editor I see that this is not working atm because I'm not reacting to configuration changes
fyi for easier testing since the command palette can cause the terminal to no longer be focused, I'd suggest using the keybinding to toggle tab focus mode
Change:
constructor(line: number, character: number); /** <del> * Check if `other` is before this position. </del> <ins> * Check if this position is before `other`. </ins> * * @param other A position. * @return `true` if position is on a smaller line

Discussion:
In , the comparison functions , , , and have misleading descriptions. For example, says "Check if is before this position." I think it would be more clear to say something like "Check if this position is before ", as that is when is returned. Likewise for the other three.
Change:
} const withReporter = (function () { <del> const reporterPath = path.join(path.dirname(require.resolve('mocha')), 'lib', 'reporters', argv.reporter); let ctor; </del> <ins> if (argv.tfs) { { return (browserType, runner) => { new mocha.reporters.Spec(runner); new MochaJUnitReporter(runner, { reporterOptions: { testsuitesTitle: `${argv.tfs} ${process.platform}`, mochaFile: process.env.BUILD_ARTIFACTSTAGINGDIRECTORY ? path.join(process.env.BUILD_ARTIFACTSTAGINGDIRECTORY, `test-results/${process.platform}-${browserType}-${argv.tfs.toLowerCase().replace(/[^w]/g, '-')}-results.xml`) : undefined } }); } } } else { const reporterPath = path.join(path.dirname(require.resolve('mocha')), 'lib', 'reporters', argv.reporter); let ctor; </ins> <del> try { ctor = require(reporterPath); } catch (err) { </del> try { <del> ctor = require(argv.reporter); </del> <ins> ctor = require(reporterPath); </ins> } catch (err) { <del> ctor = process.platform === 'win32' ? mocha.reporters.List : mocha.reporters.Spec; console.warn(`could not load reporter: ${argv.reporter}, using ${ctor.name}`); </del> <ins> try { ctor = require(argv.reporter); } catch (err) { ctor = process.platform === 'win32' ? mocha.reporters.List : mocha.reporters.Spec; console.warn(`could not load reporter: ${argv.reporter}, using ${ctor.name}`); } </ins> } <del> } function parseReporterOption(value) { let r = /^([^=]+)=(.*)$/.exec(value); return r ? { [r[1]]: r[2] } : {}; } </del> <ins> function parseReporterOption(value) { let r = /^([^=]+)=(.*)$/.exec(value); return r ? { [r[1]]: r[2] } : {}; } </ins> <del> let reporterOptions = argv['reporter-options']; reporterOptions = typeof reporterOptions === 'string' ? [reporterOptions] : reporterOptions; reporterOptions = reporterOptions.reduce((r, o) => Object.assign(r, parseReporterOption(o)), {}); </del> <ins> let reporterOptions = argv['reporter-options']; reporterOptions = typeof reporterOptions === 'string' ? [reporterOptions] : reporterOptions; reporterOptions = reporterOptions.reduce((r, o) => Object.assign(r, parseReporterOption(o)), {}); </ins> <del> return (runner) => new ctor(runner, { reporterOptions }) </del> <ins> return (_, runner) => new ctor(runner, { reporterOptions }) } </ins> })() const outdir = argv.build ? 'out-build' : 'out';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --- [x] Adopt a multi-stage pipeline for better visibility into dependencies [x] Review all test suites and ensure that they emit XML test results [x] Add pipeline task to publish the test results
Change:
'libgbm1 (>= 17.1.0~rc2)', 'libglib2.0-0 (>= 2.12.0)', 'libglib2.0-0 (>= 2.39.4)', <del> 'libgssapi-krb5-2 (>= 1.17)', </del> <ins> 'libgssapi-krb5-2', </ins> 'libgtk-3-0 (>= 3.9.10)', 'libgtk-3-0 (>= 3.9.10) | libgtk-4-1', <del> 'libkrb5-3 (>= 1.6.dfsg.2)', </del> <ins> 'libkrb5-3', </ins> 'libnspr4 (>= 2:4.9-2~)', 'libnss3 (>= 2:3.22)', 'libnss3 (>= 3.26)',

Discussion:
On Ubuntu 16.04 <img width="571" alt="image" src=""Originally posted by in
On ubuntu 18.04 and using apt, almost the same error
Steps for verification: In Ubuntu 18.04 VM or Ubuntu 16.04 VM Install insiders debian package from Verify that error seen in is not shown and update completes successfully
Closing for verification.
Change:
import * as vscode from 'vscode'; import * as utils from '../utils'; <del> (vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite)('Notebook Editor', function () { </del> <ins> (vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite.skip)('Notebook Editor', function () { </ins> const contentSerializer = new class implements vscode.NotebookSerializer { deserializeNotebook() {

Discussion:
Another one:
Another one:
This is actually preventing a bunch of PRs to make it into . !
Skipped this test:
Decided to comment out the entire test suite:
Thanks for reverting it, this failure is what I was expecting to see but didn't realize it's so common. Previously we often have NPE for as after , we guarantee the model is a . is not undefined, however our check previously only checked for instead of . Not we fixed condition, it starts to fail when we do the type assert can you help take a look at this?
This might actually be interesting for your. AFAIK we simply call resolve on the working copy manager but working copy actually isn't resolved. This is all happening here The working copy doc says that the model is defined once resolve is called but it seems not so (at times)
Maybe running with in that flaky test gives more info, we print a good amount of details for what is going on in the working copy when resolving or saving: <img width="796" alt="image" src="https://user-"
brings the tests back and sets verbose logging for the failing one (I am not sure why the entire suite was disabled). There is cases where can return early and maybe that happens here in this case. For example, when a disposed working copy is resolved: Or when providing contents for resolving but the working copy is dirty with user changes: Anyway, any of these cases should appear in the logs now with verbose logging enabled.
Does not seem to fail anymore <img width="1549" alt="image" src="https://user-"
Change:
controller = new QuickInputController({ container: fixture, idPrefix: 'testQuickInput', <del> ignoreFocusOut() { return false; }, </del> <ins> ignoreFocusOut() { return true; }, </ins> isScreenReaderOptimized() { return false; }, returnFocus() { }, backKeybindingLabel() { return undefined; },

Discussion:
all out of ideas on this one. I'm not relying on setTimeouts or anything. It's a totally responsive test:
Maybe add some logging that only prints if the event does not fire in 4 seconds.
Ok I've better logging in the form of... if takes too long, the test failure will be different. Additionally, just in case this is a weird focus artifact, I have set ignoreFocusOut
I've not heard any reports of this failing recently... once it fails again, I'll revisit now that I have extra logging. With that said, it's possible that because of I have fixed the test failure.
Change:
} .menubar.compact .toolbar-toggle-more { <ins> position: absolute; left: 0px; top: 0px; </ins> background-position: center; background-repeat: no-repeat; background-size: 16px; cursor: pointer; width: 100%; <del> height: 100%; </del> } .menubar .toolbar-toggle-more {

Discussion:
Steps to Reproduce: web in Safari on compact menu = it moves !
I diagnosed this and see 2 issues: the menu items are not removed from the DOM when menu is not showing () you seem to be using instead of to hide the menu items, is there any particular reason? using the issue is not as bad anymore (I only see one initial jump) I suggest we use / (our helper), but I am not sure if you rely on the behavior of visibility?
I mentioned the reasoning in the linked issue, but in the compact case we can remove them from the DOM safely so patching that should help here.
Change:
resolved "https://registry.yarnpkg.com/just-debounce/-/just-debounce-1.0.0.tgz#87fccfaeffc0b68cd19d55f6722943f929ea35ea" integrity sha1-h/zPrv/AtozRnVX2cilD+SnqNeo= <del> keytar@^7.1.0: version "7.1.0" resolved "https://registry.yarnpkg.com/keytar/-/keytar-7.1.0.tgz#961e6c5cf0615f2c184a48752d3265063e492925" integrity sha512-ciDrtCcvhKpmVfPMVAiKSeKKQd+8S2VWOIcJP0Rdwz/ezSxHxYrycpwufDGpEHJqLyi/F7C7iwoz0eKGllzcMw== </del> <ins> keytar@7.2.0: version "7.2.0" resolved "https://registry.yarnpkg.com/keytar/-/keytar-7.2.0.tgz#4db2bec4f9700743ffd9eda22eebb658965c8440" integrity sha512-ECSaWvoLKI5SI0pGpZQeUV1/lpBYfkaxvoSp3zkiPOz05VavwSfLi8DdEaa9N2ekQZv3Chy+o7aP6n9mairBgw== </ins> dependencies: <del> "@shiftkey/prebuild-install" "6.0.1-pre2" </del> node-addon-api "^3.0.0" <ins> prebuild-install "^6.0.0" </ins> keyv@^3.0.0: version "3.1.0"

Discussion:
Captured by Symbolicated trace:
Crash in keytar module due to missing handlescope in callbacks when reentering javascript thread
Change:
private _modelVersionId: number = -1; private _currentChoice?: Choice; <del> private _choiceCompletionItemProvider?: CompletionItemProvider; </del> <ins> private _choiceCompletions?: { provider: CompletionItemProvider; enable(): void; disable(): void }; </ins> constructor( private readonly _editor: ICodeEditor,

Discussion:
This problem still occurs even if you disable all extensions. This problem was confirmed in Markdown file. below the snippet (it contains a snippet choice) below the code in Markdown file snippet in Markdown file I expected to see link label suggestion, but it does not display link label suggestion... Included by snippet choice reproduces the issue. It is not displayed even if is pressed. Gif demo: ! VS Code Windows 11
Sorry but I am unaware of link label suggestions. What are those and where do they usually come from?
I'm sorry, I had my own way of saying it. I don't know the correct terminology, but I'll show you an example in action. the following markdown your cursor inside the second ! I haven't been able to find any release notes for this feature, but it's a feature in VS Code and not coming from an Installed extension. This feature doesn't work within certain snippets.
I can reproduce. Looks like the choice suggest provider is staying active despite its placeholder not being active anymore
Using a snippet seems to break label suggestions until the editor is reloaded. Even reopening the file doesn't fix it:
repro steps please
the snippet from the original issue in your global snippets a new markdown file with the contents as in the video, you can get completions until the moment you use the snippet
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
if (!sanitizedRepo) { quickpick.items = []; } else { <del> quickpick.items = [{ label: `$(repo) Publish to GitHub private repository`, description: `$(github) ${owner}/${sanitizedRepo}`, alwaysShow: true, repo: sanitizedRepo }]; </del> <ins> quickpick.items = [ { label: `$(repo) Publish to GitHub private repository`, description: `$(github) ${owner}/${sanitizedRepo}`, alwaysShow: true, repo: sanitizedRepo, isPrivate: true }, { label: `$(repo) Publish to GitHub public repository`, description: `$(github) ${owner}/${sanitizedRepo}`, alwaysShow: true, repo: sanitizedRepo, isPrivate: false }, ]; </ins> } };

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As noted in , the lack of an option to create a public repository is by design rather than a bug. In that issue, gave the following reason for omitting the option: I would argue that: two quickpick options instead of one would not significantly complicate the UI. process of making a private repository public is not straightforward, especially when the alternative is to just create it as public in the first place. For reference, here are the required steps: Select "Publish to GitHub private repository" from quickpick and open the repo when finished. <img width="643" alt="Screen Shot 2020-07-12 at 11 26 12 AM" src="https://user-"- <img width="471" alt="Screen Shot 2020-07-12 at 11 27 26 AM" src="https://user-"- Open repository settings on GitHub. <img width="988" alt="Screen Shot 2020-07-12 at 11 34 14 AM" src="https://user-"- Scroll all the way to the bottom of the page (to the "Danger Zone") and click "Change visibility." <img width="942" alt="Screen Shot 2020-07-12 at 11 28 27 AM" src="https://user-"- In the modal, select the "Make public" radio option. Type the full repo name and click "I understand, change repository visibility." <img width="488" alt="Screen Shot 2020-07-12 at 11 28 51 AM" src="https://user-"For me and many others whose primary work is done in public repos, these steps would be completely eliminated if there were an option to create the repo as public in the first place. I don't believe it would be very difficult to implement this feature. Here's a simple solution:
OK sure, feel free to submit a PR.
Will do, thanks!
Change:
- `.mp3` - `.wav` <del> - `.ogg` </del> <ins> - `.ogg`, `.oga` </ins> ### Supported video formats <del> - `.mp4` (does not support `aac` audio track) </del> <ins> - `.mp4` (does not support `aac` audio tracks) </ins> - `.webm` (vp8 only)

Discussion:
Type: <bBug</bOkay this is not actually an error but... I was working with a video file and it's name is ".ogg" is a video and audio file format/extension. In the explorer's tab the VS Code app says its an audio file, but it is not. The working of the file is proper in the browser but when you try to open it from VS Code itself it shows an error as "An error occurred while loading the audio file. Open file using VS Code standard text/binary editor?". According to me the app VS Code is not able to distinguish between if the file is an audio file of a video one. Lookng forward to this conversation, and hoping it gets fixed in the next VS Code update. Thank You in advance. Vishnu Soni VS Code version: Code 1.75.0 (, 2023-02-01T15:23:45.584Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ LiveServer5.7.9 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Although is a general container file format, I think is now recommended for audio content (or the more explicit ). If you want though, you can configure so that opens with the video preview instead of the audio one:
But what if want it to open both (audio and video) simultaneously
Reply
Change:
import { exec } from 'child_process'; import * as resources from 'vs/base/common/resources'; import * as fs from 'fs'; <ins> import * as pfs from 'vs/base/node/pfs'; </ins> import { isLinux } from 'vs/base/common/platform'; import { IExtHostTunnelService, TunnelDto } from 'vs/workbench/api/common/extHostTunnelService'; import { asPromise } from 'vs/base/common/async'; import { Event, Emitter } from 'vs/base/common/event'; import { TunnelOptions, TunnelCreationOptions } from 'vs/platform/remote/common/tunnel'; import { IExtensionDescription } from 'vs/platform/extensions/common/extensions'; <ins> import { promisify } from 'util'; import { MovingAverage } from 'vs/base/common/numbers'; </ins> class ExtensionTunnel implements vscode.Tunnel { private _onDispose: Emitter<void> = new Emitter();

Discussion:
We have been seeing a bunch of remote issues where the remote extension host burns a lot of CPU. I think it is caused by our port scanning code, which executes even if the setting is false. See Possible issues: / Other: ? ? ? *
Looks like we need to work on our indentation and ensuring that we break lines once they go past the edge of the screen for the sake of readability
I could reproduce some increased CPU usage of the remote extension host using the project linked to i.e.
In insiders, you can now temporarily disable the port scanning code by adding this line to your .bashrc file, then restarting the VS Code server on your remote:
Once we have an insiders build I'll start commenting in each of the issues asking folks to try out the workaround in insiders.
Keeping open for now so that the issue can be found more easily.
Closing since the fix is available in insiders.
Verified that cpu usage was reasonable when running the petclinic app
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.55", </del> <ins> "xterm": "4.19.0-beta.56", </ins> "xterm-addon-search": "0.9.0-beta.39", "xterm-addon-serialize": "0.7.0-beta.12", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.36", <del> "xterm-headless": "4.19.0-beta.55", </del> <ins> "xterm-headless": "4.19.0-beta.56", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Testing Have the same content in the editor and in the terminal. Search for something. Notice how the occurrence are fat and visible in the editor scrollbar. Notice how they are not fat and sparse in terminal. They seem to be incorrectly placed since my match is almost on every line and that is not the feeling I get from the terminal scroll bar ! !
How many lines do you have in the editor for this example? It looks like there are a bunch of empty lines near the bottom? The way we calculate the position of terminal scroll bar decorations is line / number of lines in the buffer.
I had the same number of lines as the terminal which is 23. If I had more lines in the editor I think that would mean that the decorations are smaller in the editor, not larger and that seems to be happening :)
to me, it looks like the decorations are closer together and not taking up as much vertical space in the scrollbar see how the lower half is just empty? !
Good point. Now I have disabled scrolling beyond last line in the editor. And they render the equal height. But look at the decorations - they are very different. Do you also see this on your machine? !
The ones in the editor are double the height - likely because of device pixel ratio on a mac that's getting taken into account there and probably should be also for the terminal. ! !
Strange because we are doing the right thing here, but is 1 here for me on a mac . !
We can make these heights different based on the number of lines in the buffer similar to what the editor does
Upstream issue: