jiebi/CodeConvo huggingface dataset:
Change:
dependencies: is-number "^7.0.0" <del> typescript@4.9.4: version "4.9.4" resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.4.tgz#a2a3d2756c079abda241d75f149df9d561091e78" integrity sha512-Uz+dTXYzxXXbsFpM86Wh3dKCxrQqUcVMxwU54orwlJjOpO3ao8L7j5lH+dWfTwgCwIuM9GQ2kvVotzYJMXTBZg== </del> <ins> typescript@4.9.5: version "4.9.5" resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz#095979f9bcc0d09da324d58d03ce8f8374cbe65a" integrity sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g== </ins> vscode-grammar-updater@^1.1.0: version "1.1.0"

Discussion:
Tracks picking up the Ts 4.9.5 recovery build Includes:
To verify, open a TS file and check the TS version in the language status item
Change:
const embeddedSvgsNotValid = l10n.t("Embedded SVGs are not a valid image source."); const dataUrlsNotValid = l10n.t("Data URLs are not a valid image source."); const relativeUrlRequiresHttpsRepository = l10n.t("Relative image URLs require a repository with HTTPS protocol to be specified in the package.json."); <del> const relativeIconUrlRequiresHttpsRepository = l10n.t("An icon requires a repository with HTTPS protocol to be specified in this package.json."); </del> const relativeBadgeUrlRequiresHttpsRepository = l10n.t("Relative badge URLs require a repository with HTTPS protocol to be specified in this package.json."); const apiProposalNotListed = l10n.t("This proposal cannot be used because for this extension the product defines a fixed set of API proposals. You can test your extension but before publishing you MUST reach out to the VS Code team."); const implicitActivationEvent = l10n.t("This activation event cannot be explicitly listed by your extension.");

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: macOS 12.6.2 Steps to Reproduce: an extension and specify a relative path to an in the in png format, and specify repository as . (Our repository is private) get a warning , despite the icon showing correctly in the marketplace and the VS Code extension manager (We also have images in our that we hosted externally. Our repository is private after all). Extension:
I get the same warning ! despite my fields being defined as Source: Interestingly the icon shows up in the marketplace just fine. !
I see the icon is served from the CDN now and we can remove the warning about the relative icon path. What about badges in the and images in the README markdown, are these also served from CDN?
Those are all served from the raw GitHub routes, this is why vsce needs to know what repository hosts the sources.
But the icon isn't, not anymore at least... Our repo is private, the icon works just fine and is uploaded along with the vsix and hosted in some CDN. Images in the readme are indeed served directly so will require this check or an absolute URLs.
Ah! This is just the workbench linter. I also forgot that we actually show the icons served directly from the MP, not GH. Sorry about the confusion, thanks for following up This warning is unnecessary by now, let's remove it.
Change:
constructor( public readonly inputNumber: 1 | 2, <ins> titleMenuId: MenuId, </ins> @IInstantiationService instantiationService: IInstantiationService, @IContextMenuService contextMenuService: IContextMenuService, @IThemeService themeService: IThemeService, <ins> @IMenuService menuService: IMenuService, @IContextKeyService contextKeyService: IContextKeyService, </ins> ) { super(instantiationService);

Discussion:
Theirs / Yours title area is currently quite empty. We should consider to add an action bar for "Compare with Base" action. The title area should also have additional Git information in the future fyi !
I don't see a branch or commit id in your screenshot. Is that configured somehow? <img width="533" alt="CleanShot 2022-06-28 at 10 00 52 src="https://user-"In any case, we could introduce a toolbar somewhat like the editor. Icons are placeholder, but an example could look like: <img width="1032" alt="CleanShot 2022-06-28 at 10 05 06 src="https://user-"
Unsure what was seeing there but with the normal git flow we do show the branch names and commits in question. There is also different issue for the toolbar and since today an icon in front of the commit it
To verify open a merge editor verify that it has menus with yours/theirs
Change:
export class CommentThreadWidget<T extends IRange | ICellRange = IRange> extends Disposable implements ICommentThreadWidget { private _header!: CommentThreadHeader<T>; <del> private _body!: CommentThreadBody<T>; </del> <ins> private _body: CommentThreadBody<T>; </ins> private _commentReply?: CommentReply<T>; private _additionalActions?: CommentThreadAdditionalActions<T>; private _commentMenus: CommentMenus;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Our users want to see which comments need to be worked on next. During a review round there might be some comments which are not actionable anymore as their threads got resolved. For better overview we think it is valuable to be able to expand only all unresolved (and therefore actionable) comments. Since we can't use anymore to do this from our extension. Reading there is no intention in bringing back this functionality. Introducing commands like (and probably also ) could be a way bring back some control over comment collapsed state to the extension without the need for extension to directly. cc
Tentatively adding for February.
The new command is "Comments: Expand Unresolved Comments".
To verify: Open a workspace with unresolved comments (a PR with comments using the GitHub Pull Requests and Issues extension works well for this). Collapse some comments in the editor. Run "Comments: Expand Unresolved Comments" and verify that all unresolved comments are expanded.
If a comment is already collapsed when I open the file, the command "Expand Unresolved Comments" doesn't work repro: an unresolved comment the current tab the tab again run the command - the comment is not expanded https://user-
good find! Will be fixed in the next insiders build.
Change:
"vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", "xterm": "4.19.0-beta.25", <del> "xterm-addon-search": "0.9.0-beta.22", </del> <ins> "xterm-addon-search": "0.9.0-beta.23", </ins> "xterm-addon-serialize": "0.7.0-beta.12", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.29",

Discussion:
Testing macOS, zsh Do a couple of ls calls for something that has multiple matches in the terminal using the Down or Up arrow -notice how the count is always wrong !

Testing Notice how the "no results" is grey in the editor when the find input is empty. In the terminal it is red !

Refs: macOS, zsh shell Search for something in the terminal that does not exist -"no results" is not rendered. !

Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification

Testing a query which results in matches the terminal (e.g. expand or collapse explorer) :bug: match decorations remain !
Change:
private _currentReleaseNotes: WebviewInput | undefined = undefined; private _lastText: string | undefined; <ins> private disposables = new DisposableStore(); </ins> public constructor( @IEnvironmentService private readonly _environmentService: IEnvironmentService,

Discussion:
Since we open release notes (by default) on each release, there should be a visible way to opt-out. Either a checkbox similar to the Welcome experience, or a markdown command link. re:
I think having a setting to toggle this would be best. The release notes is just a markdown preview so we can't add any UI elements to it, unlike the Welcome page which is different.
We do have a setting already , but we have LOTS of settings. Even though it is markdown, we could still add a command link to the text that would run a new command to toggle the setting.
I don't know, this seems pretty obvious: !
Its friction -- if the release notes pops up and aggravates me, I have to take much extra energy to go looking for the setting (even though it is an easy one to find)
I could see maybe adding a menu item in the ... in the top right, but doubt that is discoverable. Placing it inside of the preview feels a bit odd like an unsubscribe link.
On the constrain of adding UI to the notes: The relnotes manager output already has a patch that runs to and handles . Might the same be used to inject an opt-out checkbox or link inside the header? A common UX to test would be a "Don't show again" link/button we have in notifications (and elsewhere?).
One heuristic could be that if we see the release notes are closed within 5 seconds of them opening, we show a notification asking the user whether they want to see them in the future. The downside is that it trades release note fatigue for notification fatigue
I totally agree. Just not sure of the right UX here.
Here a few different ideas: ! ! This would take some engineering effort as it's not easily supported in plain markdown, but placing a small navigation bar at the bottom so that it's always visible. Downside is if you want to see the release notes it's annoying to see !
I like the checkbox since it's a pretty standard way of doing this... Maybe at the top (2) is best?
When lands, a wording could be "Show release notes for monthly updates." to indicate the monthly frequency to set expectations.
I prefer # 2
Another tweet about this: I prefer because it aligns with how we show the checkbox for the welcome page too.

I prefer # 3 too because it does not interrupt the flow for people reading the release notes Another possible wording based on 's could be "Show release notes for major updates"
Currently is of "application" scope (), meaning that I cannot set it to "false" in section of a file. Can it be scope? It's slightly different from the original topic. Let me know if you want me to open a separate issue for it.
!
Do we want to show it at the top so prominently? Feels like it breaks the layout and we would like users at least glancing at the release notes.
IMO it should at least be under the or under the first paragraph. Agreed that it feels like it breaks the layout.
!
This looks better to me. Thanks
Change:
* Controls whether the terminal is cleared before executing the task. */ clear?: boolean; <ins> /** * Controls whether the terminal is closed after executing the task. */ close?: boolean; </ins> } /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Linux JD 5.13.10-arch1-1 Although there is an option to close terminal after task completes running in , the option doesn't exist in interface TaskPresntationOptions Steps to Reproduce: VS Code extension a task in extension to set presentation field with close: ! Steps to Fix: close field to interface TaskPresntationOptions in ! TypeScript error: ! as expected, task closes after run: ! Adding this issue for a pull request
can you please describe why having the presentation options is important to have as extension API? We do not like to add API just for the sake of having it, so I want to understand that it will be useful for multiple extension authors before adding it.
Hi
sounds like you have a real use case for it. Thanks for the details!
Reopening for finalization
Change:
this.applyStyles(); <del> this.element.setAttribute('aria-label', this.message); </del> <ins> this.element.setAttribute('aria-label', this.getAriaLabel()); </ins> show(this.element); // Focus first element

Discussion:
From Get a modal dialog in the web Notice how you can nicely focus any of the buttons, however the content of the dialog message is never read out, thus the dialog is not accessible. How this should work: Dialog should have an aria label and have focus It shuld use active descendent to let the screen reader know that focus is passed to one of the buttons
I am using the button widgets, are notifications not accessible either or are they doing something special?
Can you clarify what you mean exactly? Notifications announce themselves as ARIA alert when they open:
I misread the initial issue, I thought the bug was that the buttons were not read, not the actual message.
Thanks for fixing, let's add a bug label so we get this verified.
Change:
declare _serviceBrand: undefined; private _webExtensionContributedProfileContextKey: IContextKey<boolean>; <del> private _profilesReadyBarrier: AutoOpenBarrier; </del> <ins> private _profilesReadyBarrier: AutoOpenBarrier | undefined; private _profilesReadyPromise: Promise<void>; </ins> private _availableProfiles: ITerminalProfile[] | undefined; private _contributedProfiles: IExtensionTerminalProfile[] = []; private _defaultProfileName?: string;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 OS Version: Mac OS 13.3.1 Steps to Reproduce: a new VSCode window using Codespaces. initial terminal window opens a terminal. If I kill that terminal and open a new terminal, I get as expected. I have in my I believe this is a duplicate of these closed issues:
I was expecting this would get fixed as part of , cc
It got , but it only repros using codespaces extension now, before I was able to repro with test resovler extension and remote ssh extension which works as expected now, not sure what's special about codespaces extension as the remote connection logic is the same :thinking:
Ah I can repro now, will take a look, it's because codespaces takes 20s to resolve the remote Edit: There's a :laughing:
PR
/duplicate
Change:
"scope": "resource", "markdownDescription": "%ipynb.pasteImagesAsAttachments.enabled%", "default": true <del> }, "ipynb.experimental.serialization": { "type": "boolean", "scope": "resource", "markdownDescription": "%ipynb.experimental.serialization%", "default": false </del> } } }

Discussion:
This seems to be caused by following change which brought module and Webpack failed compiling this. Therefore I am reverting this commit.
The associated PR is
Change:
.monaco-editor .dim-configuration { color: #b1b1b1; } <ins> .codicon-settings-edit:hover { cursor: pointer; } </ins>

Discussion:
! Version: 1.68.0-insider (user setup) Commit: Date: 2022-05-19T05:16:03.853Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0.
Change:
})); } <del> private showHover(skipFadeInAnimation: boolean = false): void { </del> <ins> showHover(skipFadeInAnimation: boolean = false): void { </ins> if (this.lastHover && !this.lastHover.isDisposed) { return; }

Discussion:
This ask is from the Copilot team in response to feedback they've received. When something is represented via only an icon, and is focused via keyboard, we should automatically focus the tooltip.
cc
related
we would also want to do this for all toolbars <img width="202" alt="Screenshot 2023-11-01 at 10 12 16 AM" src=""
Just out of curiosity, what does "focus the tooltip mean"? Does it mean "make the tooltip visible"? (sorry- the language is a bit confusing. tooltips are not actually focusable, right?)
yes I think meant to show the hover, not focus it as that would break left/right navigation.
Yep, it just shows the hover, doesn't focus it.
Change:
const cellHandlers = new Set<NotebookCellTextModel>(); const addCellContentChangeHandler = (cell: NotebookCellTextModel) => { <del> if (!cellHandlers.has(cell) && cell.textModel) { cellHandlers.add(cell); toDispose.add(cell.textModel.onDidChangeContent((e) => this._proxy.$acceptCellModelChanged(modelUrl, cell.handle, e))); } </del> <ins> cellHandlers.add(cell); toDispose.add(cell.onDidChangeContent((e) => { if (typeof e === 'object' && e.type === 'model') { this._proxy.$acceptCellModelChanged(modelUrl, cell.handle, e.event); } })); </ins> }; model.cells.forEach(cell => addCellContentChangeHandler(cell));

Discussion:
Testing 1) I started with 2) I ran the first two cells and then committed 3) I reran cell 1 4) I changed cell 3 to use different file names 5) I opened the notebook diff from the SCM view -(a) cell metadata changes were shown -(b) changes to cell 3 where hidden -(c) toggling the "Toggle Collapse Unchanged Regions" didn't do anything !
I was unable to reproduce (b) reliably.
Verifier: Make the workbench small enough so when opening only the first cells show up Run the first two cells Commit/stage the file Scroll to the last cell, make changes, save (if you don't have auto save) Open the diff view, the change in the last cell should be rendered.
cannot test this due to
Change:
for (const item of keys) { tst.set(item, true); <del> assert.ok(tst._isBalanced()); </del> <ins> assert.ok(tst._isBalanced(), `SET${item}|${keys.map(String).join()}`); </ins> } for (const item of keys) { tst.delete(item); <del> assert.ok(tst._isBalanced()); </del> <ins> assert.ok(tst._isBalanced(), `DEL${item}|${keys.map(String).join()}`); </ins> } } });

Discussion:
Another instance:
I have logging to see with what values the test fails - the test input is randomly generated. I ran it times locally and didn't see a failure... I you come across this then please point to the failing build
Something is weird: <img width="1000" alt="image" src="https://user-"This looks somewhat like Why is there no stack trace on what the assertion is that failed? And why does the task timeout? This is also Windows, so maybe its platform specific and an issue with the unit test runner?
link to CI run?
oh I was just clicking on the first one from this issue:
Oh, super old one without my logging yet
This didn't happen again
Change:
private _widgetManager: TerminalWidgetManager; private _processCwd: string; private _localLinkPattern: RegExp; <ins> private _gitDiffPreImagePattern: RegExp; private _gitDiffPostImagePattern: RegExp; private readonly _tooltipCallback: (event: MouseEvent, uri: string) => boolean | void; </ins> constructor( private _xterm: any,

Discussion:
Example:
Do you mind if I take on this issue? I assume the request is to make and Ctrl-clickable such that the links open the correct versions of the files.
sounds good. The link registration is done here and it's based on regexs: We basically want the and parts to be matched, but ignored as part of the link.
I'm having a bit of trouble with getting the two git blob IDs and , which are necessary to get the correct versions of the files. I tried to write a multi-line regex for that captures the blob IDs in groups, along with the paths we want to link, but currently only runs the regex on a per line basis (by iterating through the buffer), not on the whole content of the terminal. So the regex didn't find any matches. I also tried to get the blob IDs by parsing the contents of the terminal manually, but doesn't seem to offer a public interface to retrieve the contents. I do see but I don't want to rely on an internal implementation to do something like this. How do you suggest I proceed? Should I submit a PR to to allow multi-line regex in ?
I'm having a bit of trouble with getting the two git blob IDs and , which are necessary to get the correct versions of the files. Oh I wouldn't go that far, just pointing both links to the current version of the file would be good enough start with.
Ah I see, that's a lot simpler to do. Will open a PR soon.