jiebi/CodeConvo huggingface dataset:
Change:
if (!this._hoverController) { return; } <ins> if (this._focusedHoverPartIndex === -1) { this._hoverController.focus(); } else { this._hoverController.focusHoverPartWithIndex(this._focusedHoverPartIndex); } </ins> this._focusedHoverPartIndex = -1; <del> this._hoverController.focus(); </del> this._hoverController.shouldKeepOpenOnEditorMouseMoveOrLeave = false; this.dispose(); }

Discussion:
Testing on Linux Open a hover with multiple parts Tab to focus one of the hover parts Open accessible view/help Esc to close it Now the whole hover is focused, instead of the individual part I'd focused
Verified with GitLens's editor hover
Change:
} private async _branch(repository: Repository, defaultName?: string, from = false): Promise<void> { <del> const branchName = await this.promptForBranchName(repository, defaultName); if (!branchName) { return; } </del> let target = 'HEAD'; if (from) {

Discussion:
create new branch from... from ref picker on desktop git repo :bug: I'm asked to provide a branch name, I would expect to first be asked to pick a ref to create my branch from since the suggests additional prompts that are contextual to that action
Change:
stage-packages: - libasound2 - libc++1 <del> - libgconf2-4 </del> - libnotify4 - libnspr4 - libnss3

Discussion:
Afaik, electron should build with dconf instead of gconf.
See also
Please report here:
electron now (3.x) works without gconf. All you have to do is
I can confirm that Insiders 1.31 works without gconf. Can gconf be dropped for insiders?
Change:
Visible = 'visible' } <ins> const enum Constants { StickyScrollPercentageCap = 0.4 } </ins> export class TerminalStickyScrollOverlay extends Disposable { private _stickyScrollOverlay?: RawXtermTerminal; private _serializeAddon?: SerializeAddonType;

Discussion:
Testing I ran the following command which is a powershell command that spans 8 lines. In this case sticky scroll can fill the entire terminal. One thing we do for sticky scroll in the tree is we allow sticky scroll to take a maximum of 40% of the view height. If the widget takes more than 40% of the height, we start dropping some of the sticky lines. In that case you could possibly have a at the end of the last line to indicate to the user that there is more to the command than can be shown. powershell command: (is new line) used setting !
I was a little torn on this, I was thinking if a user says they want 10 lines then maybe we should respect that (up a maximum of rows - 1 which isn't the case now). I see there is some logic here in the editor: ! Though it only updates on scroll, not resize: ! Do you also use a max of 40% there?
Your case might be a bit different to the tree. Trees appear in many different locations. One tree might fill the entire height of the editor in one view and another tree view might be much smaller. This would lead the user to have a large max sticky item value to be able to see many nodes in the large tree but he would probably not want it to fill the entire view in the smaller tree view cases. This is maybe a bit different to the terminal where a users usually only has one terminal. I think you should at least guarantee that one line of the terminal is visible.
Hey we do not have such a logic in the editor sticky scroll although it is a very interesting idea and it may be worthwhile to look into it.
Change:
} runEditorCommand(_accessor: ServicesAccessor, editor: ICodeEditor) { <del> const stickyScrollController = StickyScrollController.get(editor); if (stickyScrollController) { stickyScrollController.focusPrevious(); } </del> <ins> StickyScrollController.get(editor)?.focusPrevious(); </ins> } }

Discussion:
Testing around an open file in the editor with Stick Scroll enabled. Sticky Scroll Try to move focus out of Sticky Scroll. Tried pressing . Tried running "Focus Sticky Scroll" command a second time. Only way to get focus back to the editor is to select a level and press . I think should put you back into the editor
Change:
title: command.title }; <del> if (!isFalsyOrEmpty(command.arguments)) { </del> <ins> if (command.command && !isFalsyOrEmpty(command.arguments)) { </ins> // we have a contributed command with arguments. that // means we don't want to send the arguments around

Discussion:
Testing in this setup Get this Code lense with '0 References' in ! Clicking the references link just shows an empty peek, it is not clear what is being search for. !
Now I understand what is going on: ! The reference in the template isn't found by the Angular Language Service extension.
Do you suggest we don't show the peek view from zero references code lens? Or should the peek view have more info on what would normally be displayed?
since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.
Change:
} // If asked to always update the setting then update it even if the gear isn't clicked <del> if (alwaysUpdateSetting && result?.item.id) { </del> <ins> if (showDefaultPicker && result?.item.id) { </ins> this.updateUserAssociations(`*${extname(resource)}`, result.item.id,); }

Discussion:
When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a "Configure Default Formatter..." that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc
Change:
"panelTitle.activeBorder": "#005FB8", "panelTitle.activeForeground": "#000000e4", "panelTitle.inactiveForeground": "#000000e4", <del> "peekViewEditor.background": "#6e76811a", </del> "peekViewEditor.matchHighlightBackground": "#bb800966", "peekViewResult.background": "#ffffff", "peekViewResult.matchHighlightBackground": "#bb800966",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75 Insiders OS Version: macOS https://user-
It seems we have a transparent background when using the v2 dark theme. Though there should always be a bg color fallback.
The relevant color here is . There are two problems: this should be defined opaque if this isn't opaque, maybe we should force it to be opaque in code
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
this is
I'm still seeing this with Peek View. The problems listed by is not being fixed it seems. <img width="1330" alt="image" src="https://user-"
Not for me. Please provide repro info like the theme you are using and/or customisations you are doing <img width="1103" alt="Screenshot 2022-12-13 at 08 34 25" src="https://user-"
I'm using Dark+ V2 (experimental) theme.
Likely just a theme bug then. I'll take a look.
Change:
workbench.registerWorkbenchContribution(UpdateContribution, LifecyclePhase.Restored); <ins> const actionRegistry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions); </ins> // Editor <del> Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions) </del> <ins> actionRegistry </ins> .registerWorkbenchAction(new SyncActionDescriptor(ShowCurrentReleaseNotesAction, ShowCurrentReleaseNotesAction.ID, ShowCurrentReleaseNotesAction.LABEL), 'Show Release Notes'); <ins> actionRegistry .registerWorkbenchAction(new SyncActionDescriptor(CheckForVSCodeUpdateAction, CheckForVSCodeUpdateAction.ID, CheckForVSCodeUpdateAction.LABEL), 'Check for VS Code Update'); </ins>

Discussion:
Ability to update VS Code from the command palette as I have disabled activity bar and have to reenable it to update VS Code. Also, there is a palette option to check for extensions updates, but not for the whole app Steps: Command palette VS Code
First timer here. Could I give this one a shot?
I can do this work.
Hello there, I'm experienced developer and would like to contribute.
Hello there, I am a developer and I have gone through the whole code base and I think that I can add this feature without much problem. Can I please give it a shot?
Please do, you can check the
I have implemented this feature in . Kindly review it.
Works nicely, for downloading updates, but a command doesn't show to Restart To Update.
Change:
import { IModelDeltaDecoration, MinimapPosition, OverviewRulerLane } from 'vs/editor/common/model'; import { CodeLensContribution } from 'vs/editor/contrib/codelens/browser/codelensController'; import { localize } from 'vs/nls'; <ins> import { createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { IMenuService, MenuId } from 'vs/platform/actions/common/actions'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { attachToggleStyler } from 'vs/platform/theme/common/styler';

Discussion:
Theirs / Yours title area is currently quite empty. We should consider to add an action bar for "Compare with Base" action. The title area should also have additional Git information in the future fyi !
I don't see a branch or commit id in your screenshot. Is that configured somehow? <img width="533" alt="CleanShot 2022-06-28 at 10 00 52 src="https://user-"In any case, we could introduce a toolbar somewhat like the editor. Icons are placeholder, but an example could look like: <img width="1032" alt="CleanShot 2022-06-28 at 10 05 06 src="https://user-"
Unsure what was seeing there but with the normal git flow we do show the branch names and commits in question. There is also different issue for the toolbar and since today an icon in front of the commit it
To verify open a merge editor verify that it has menus with yours/theirs
Change:
this._protocolPromise = this._startOutsideIframe(); } } else { <del> this._protocolPromise = this._startOutsideIframe(); </del> <ins> const fileExtensionHostIframeSrc = FileAccess.asBrowserUri('../worker/httpsWebWorkerExtensionHostIframe.html', require); this._protocolPromise = this._startInsideIframe(`${fileExtensionHostIframeSrc.toString(true)}?`); </ins> } this._protocolPromise.then(protocol => this._protocol = protocol); }

Discussion:
Issue Type: <bBug</bWhen attempting to launch a web-compatible extension with entry point under node VS Code host, following error is thrown:  When entry point is specified (in addition to ), the error is not thrown, but I need the extension to run in browser environment to access API (it uses .NET Blazor, which doesn't work with node's module). Here is the sample extension sources: VS Code version: Code 1.62.3 (, 2021-11-17T08:11:14.551Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ dotnetjs1.0.6 naninovel1.6.1 vscode-dotnet-runtime1.5.0 code-spell-checker2.0.13 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
And here is the published extension in question, in case you'd like to test it: It works fine in browser (via ), but throws the error in standalone VS Code.
VS Code uses as additional measure to protect from XSS. This is defined per document(-header). When running in web, e.g or , we isolate the web-worker running extensions in a separate iframe and that iframe doesn't inherit nor use trusted types. In contrast, when running in desktop we don't further isolate the web worker and therefore trusted types restrictions apply to extensions too
Thanks for the response! I've checked the linked article, but still not sure how to solve the issue. Should I add a trusted type policy before the extension is activated? If that's the case, what exactly should be inside the policy object for it to work in VS Code? It complains about evaluating a string as JavaScript code, so I guess it's about , but the extension doesn't use eval, nor does it use any of the DOM APIs, which are governed by the trusted types.
Yeah, I guess it's about , likely inside library or generated code. We don't allow that in our code and in the web_worker+desktop case that's a restriction that you are inheriting. I believe that's unwanted strictness from our side and something we should relax.
There are indeed 3 eval calls in the generated code, but they're not executed.

Just to make sure, I've replaced all of them with , but the same error is still thrown in VS Code.
Thanks for fixing this so quickly! Can you please clarify if there are still some limitations on using API in web extensions running in standalone? I can't connect to local websocket server () in standalone mode, while in browser it works fine.
Even locally we are strict and want (note the secure )
Ah, I see. Thought about it, but the fact that unsecure connection is working in browser and in standalone with .NET runtime gave me hope that you could allow it in this case as well. Thanks for the quick response!
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.37: version "0.12.0-beta.37" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.37.tgz#e465100041a7e0b1d32b01cd0b0ba5a516ac13c2" integrity sha512-d4GfKlMrWZGzsMfMHd2siG+QiOvwikhwiu+JQlIhlnAShT/wU5BOGbNfDDA1tHmkW7G1UCFgucBuVxrs5wjuBQ== xterm-headless@4.19.0-beta.58: version "4.19.0-beta.58" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.58.tgz#3a38cf3b9cd2606fb342a5cf8f2a0cfb963a62e8" integrity sha512-wKQW8VzkFjyYDvcaM26gulo+YghyocfkZnKMH7gc/+/mFn3YXUPBPuOcX6e0M7NibyMlewpQpZjHQUPLBjkzfw== xterm@4.19.0-beta.58: version "4.19.0-beta.58" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.58.tgz#cbe535b0b85bc7f8ae3cc242df006bea04cdf541" integrity sha512-fr3QC2qS2NBab8X7kwA/3QZELzQqhAKsngvK8NkhsrFN1DAuyEETkzqXuKbO7OKpCB6VqGDN6GPkNlUB9VrIDA== </del> <ins> xterm-addon-webgl@0.12.0-beta.38: version "0.12.0-beta.38" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.38.tgz#59fc8f3711e38b9a238fd460cd070007b7904e7a" integrity sha512-fqRhfwUx/WZlDLFsZX26irLYTdRGMf1xuRwoqfr4KiFoQvHye55U8VJ4WLHdWglN2Kzh8PbINk5HfMhIwYHe9Q== xterm-headless@4.19.0-beta.60: version "4.19.0-beta.60" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.60.tgz#ccd09a7c69ba487d3fd87d6a8d159f1a6a10e9b2" integrity sha512-mJ24BRnEDCASJDTGFZysZxiXkCmed3eMFiWCPvIF48LVrqxt1cImoVKBlxqkdgUkHKjfF2c92S1TTBL5aT1I0w== xterm@4.19.0-beta.60: version "4.19.0-beta.60" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.60.tgz#de89d93153ae3ec17b53f3e5d03b8ea859126081" integrity sha512-YQjvp4xtSAyNm9+gF4OA5+QzkSWdKMCy4WABETpe7CsrEGx+mJVoXCZ9wgopmvwRXz7DeJvKM5dWz1HPjVLDtA== </ins> y18n@^3.2.1: version "3.2.2"

Discussion:
Upstream issue: Repro: Alt+click and drag in the terminal Moving right on the same line does not make a selection Moving to top-right or bottom-left doesn't make a selection (this works in canvas renderer only?) Cursor isn't correct ! Correct behavior in 1.67: !
When verifying make sure that copy works as expected for column selection in each quadrant as well.
Change:
this.workspace = workspace; } <del> await this.initializeConfiguration(); </del> <ins> await this.initializeConfiguration(trigger); </ins> // Trigger changes after configuration initialization so that configuration is up to date. if (hasWorkspaceBefore) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Windows 11 x64 Steps to Reproduce: an extension that implements a FileSystemProvider and serves a file containing a setting. a workspace that uses this FSP. that the setting has no effect until the workspace is reloaded. I will prepare a branch of fsprovider-sample to demonstrate the issue.
Repro steps: project () and VSIX (). an empty profile and install the VSIX into it. no folder or workspace open, run . Explorer find and open that though this specifies a font size of 24 it is displayed in the default font size. and observe that the font size is now correct. !
/assign I will submit a PR to fix this.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
["{", "}"], ["[", "]"], ["(", ")"] <ins> ], "autoClosingPairs": [ ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] ], "surroundingPairs": [ ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] </ins> ] }  No newline at end of file

Discussion:
I have editor.autoClosingBrackets set to true but it seems it works stricly with brackets. I guess autoclosing single/double quotes is not implemented yet? If not, please do it. I think it is a common feature for every editor.
What language is missing them?
Closing after a number of days without a reply.
Change:
const terminalName = args.title || nls.localize('debug.terminal.title', "Debug Process"); const termKey = createKeyForShell(shell, shellArgs, args); <del> let terminal = await this._integratedTerminalInstances.checkout(termKey, terminalName); </del> <ins> let terminal = await this._integratedTerminalInstances.checkout(termKey, terminalName, true); </ins> let cwdForPrepareCommand: string | undefined; let giveShellTimeToInitialize = false;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --It's the second time it happened. First time was a fresh project so as I didn't investigate further. I thought I messed up somehow. Second time I lost some datasets and got close to lose some code. I found the culprit so I hope it won't to me a third time. <!-- Use Help Report Issue to prefill these. --Version: 1.48.2 (system setup) Electron: 7.3.2 V8: 7.8.279.23-electron.0 OS: WindowsNT x64 10.0. Steps to Reproduce: a debugging session, that open a fresh python debug console terminal debugging session terminate in python debug console terminal: pressing enter, so the command don't execute but sit there a new debugging session VS code will then reuse the 'python debug console terminal' previously open, with my un-executed command still sitting there. It do its business as usually and inputting: resulting the command: and Poof my whole project is gone <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No
We should clear any input before executing a command.
I agree, I'm quite suprise it was not the case already. Waiting for the fix. There is the possibility of setting the debug console to be spawn in the debug output tab. In ’’ ’"console": "internalConsole"’
I'm now cancelling the input with Control-C. This should work on all platforms and for all shells.
Perfect, thanks for your work
The fix for this causes Reverting for the release.
Same thing happens with the C++/CMake extension when pressing F5.
Change:
"vscode-ripgrep": "^1.2.5", "vscode-sqlite3": "4.0.7", "vscode-textmate": "^4.0.1", <del> "vscode-xterm": "3.11.0-beta2", </del> <ins> "vscode-xterm": "3.11.0-beta4", </ins> "winreg": "^1.2.4", "yauzl": "^2.9.1", "yazl": "^2.4.3"

Discussion:
Fixed in master, needs to be pulled into release branch
Verification: Open a terminal Resize the sidebar to be 50% of the screen size Type out a long line in the terminal that wraps several times and press enter (this needs to be able to unwrap when you close the sidebar) Resize the terminal larger, keep moving the cursor and hit cmd/ctrl+b to hide sidebar before you let go. The resize call is debounced every 50ms and you're trying to resize both dimensions larger in a single call. You know you've done the right thing if the text doesn't move/reflow until after you have resized both.
Change:
const folders: Folder[] = []; let hasEdits = false; <ins> // Save all saveable editors before building edit session contents await this.editorService.saveAll(); </ins> for (const repository of this.scmService.repositories) { // Look through all resource groups and compute which files were added/modified/deleted const trackedUris = this.getChangedResources(repository); // A URI might appear in more than one resource group

Discussion:
Testing I wonder if we should run the command to save all files (not untitled files) before triggering the "Continue on" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?
I am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !
Should we say here? !