jiebi/CodeConvo huggingface dataset:
Change:
HashObject: { kind: OperationKind.HashObject, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as HashObjectOperation, Ignore: { kind: OperationKind.Ignore, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as IgnoreOperation, Log: { kind: OperationKind.Log, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as LogOperation, <del> LogFile: { kind: OperationKind.LogFile, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as LogFileOperation, </del> <ins> LogFile: { kind: OperationKind.LogFile, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as LogFileOperation, </ins> Merge: { kind: OperationKind.Merge, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as MergeOperation, MergeAbort: { kind: OperationKind.MergeAbort, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as MergeAbortOperation, MergeBase: { kind: OperationKind.MergeBase, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as MergeBaseOperation,

Discussion:
Timeline view to under the SCM view the SCM view the SCM view refreshes The Timeline view refreshes as well Then, the SCM view refreshes again !
VS Code Will execute the command when clicking the refresh button. and Then, it will go into here which causes it refresh twice. After method is executed, will be notified to update. This means that the method will be executed again.
Here is the sequence of events: the SCM viewlet will call status - show progress in SCM viewlet listens to status operations and emit event provides the timeline items - show progress in Timeline view While providing timeline items it calls - show progress on the SCM viewlet
I have made a tactical change so that no progress is being shown while running the operation. By doing so, we will not be showing progress in the "Source Control" view while the Timeline is refreshing. This however does not fix the fact that when the Timeline is shown, it refreshes every time is being executed which is excessive. one approach that would be valuable in multiple scenarios would be for the event to pass the name of the "Operation" that was executed. This would enable listeners of the event to decide whether they want to do something or not based on the operation that was just executed. what do you think?
Love it.
Change:
try { await main.run(argv); // Flush the remaining data in AI adapter. <del> await combinedAppender(...appenders).flush(); </del> <ins> // If it does not complete in 1 second, exit the process. await raceTimeout(combinedAppender(...appenders).flush(), 1000); </ins> } finally { disposables.dispose(); }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.35, 1.36 OS Version: Ubuntu 18.04 Steps to Reproduce: lists all extensions takes 30 seconds to return, even if no extensions are installed I tried uninstalling all extensions, uninstalling VSCode (also deleting) and upgrading to the newest version, the behavior persists. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A
Is there a way to profile the cli? It could be also that launching the cli might be taking time? Can you please check if it is taking same time in the UI? (Listing installed extensions)
Hi sandy081, listing extensions in the UI seems not to take longer than normally. At least when I click on the extensions icon I see all installed extensions without much delay.
Thanks. May I know the experience when you are launching VS Code from CLI?
Of course. I am automating the provisioning of development environments using chef and serverspec. Recently I noticed that verifying our setups using serverspec took significantly longer than it used to and identified vscode as being the reason.
Assigning to you since is not available. Looks spawning CLI is slow.
Spawning CLI is fast. Shutting it down seems to be slow. did I get it right that printing the extensions is instant... just that the process doesn't die immediately?
This is correct, it pretty much instantly prints all installed extensions (or none if none are installed) and then takes up to 30 seconds to return.
Is the time pretty constant? If you measure it a couple times using , are the numbers consistent?
Not really, here are a few times I called it. It seems to be consistently a multiple of ~ 5 sec though:
Interesting, I'm really out of ideas here...
Anything I can do to dig deeper into the issue?
Is it could be due to our telemetry flush while exiting?
Interesting . Can you edit the file distributed with code and change to and see if that helps?
That one change reduced the time from 20 - 30 seconds down to ~0.5 seconds!
Have you seen this before?
No. Based on the info here I suspected.

Also I was in that code recently.
Is there anything special about your network setup that you can think of which could delay reaching out to our telemetry service?
hm... not that I know of, all outgoing ports are open, incoming connections are blocked (unless connected via vpn). But until a few weeks ago there wasn't any issue.
Is it a work network, or a simple home network? Could you use Wireshark and detect that network connection to the telemetry service?
Simple workaround that doesn't involve modifying any files or settings: command line flag.
Verified that this is reasonable fast on my machine.
Change:
}] } ], <ins> [ '../', <ISearchPathsResult>{ searchPaths: [{ searchPath: getUri('foo/') }] } ] </ins> ]; cases.forEach(testIncludesDataItem); });

Discussion:
VSCode Version: 1.17.2 OS Version: Win 7 SP 1 Steps to Reproduce: Access search tab Type a word to search for Under "files to include", type ..siblingPath Hit enter Expected: any files under ..siblingPath containing word/pattern are shown. Actual: get "No results found in ..siblingPath". Works fine if absolute path used, or relative path below the current directory. This is very useful when you have a test project open but the interesting source files are in a sibling directory.
will probably work for now.
Indeed it does, thanks for that.
Change:
assertVariableResolve3(resolver, 'CURRENT_SECONDS_UNIX'); }); <ins> test('Time-based snippet variables resolve to the same values even as time progresses', async function () { const snippetText = ` $CURRENT_YEAR $CURRENT_YEAR_SHORT $CURRENT_MONTH $CURRENT_DATE $CURRENT_HOUR $CURRENT_MINUTE $CURRENT_SECOND $CURRENT_DAY_NAME $CURRENT_DAY_NAME_SHORT $CURRENT_MONTH_NAME $CURRENT_MONTH_NAME_SHORT $CURRENT_SECONDS_UNIX `; const clock = sinon.useFakeTimers(); try { const resolver = new TimeBasedVariableResolver; const firstResolve = new SnippetParser().parse(snippetText).resolveVariables(resolver); clock.tick((365 * 24 * 3600 * 1000) + (24 * 3600 * 1000) + (3661 * 1000));  // 1 year + 1 day + 1 hour + 1 minute + 1 second const secondResolve = new SnippetParser().parse(snippetText).resolveVariables(resolver); assert.strictEqual(firstResolve.toString(), secondResolve.toString(), `Time-based snippet variables resolved differently`); } finally { clock.restore(); } }); </ins> test('creating snippet - format-condition doesn't work #53617', function () { const snippet = new SnippetParser().parse('${TM_LINE_NUMBER/(10)/${1:?It is:It is not}/} line 10', true);

Discussion:
Issue Type: <bBug</bDoes this issue occur when all extensions are disabled?: Yes Snippets with multiple references to time-based snippet variables (eg. , , ) are not guaranteed to resolve to the same values due to the passage of time during the resolving process. a snippet with with multiple references to the snippet. There is a chance that the first will resolve to a different value than the second . I would expect that VSCode would save the time at the start of the resolution process and use it for the resolution of all time-based snippet variables. This is a time-based issue, so it helps to slow your CPU with heavy load. For example, I ran across this issue while running Folding on my machine. I'll submit a PR momentarily to fix this. VS Code version: Code - Insiders 1.59.0-insider (Universal) (, 2021-07-13T09:15:26.467Z) OS version: Darwin x64 20.5.0 Restricted Mode: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.8.0.tgz#4bc6bb4dbfea5b0d2d7978d6c5cef922d584fb4f" integrity sha512-dlpYPsv0C9S6v6+T/h/d/otSbdUTizMJdxvSoS34tUpMOHev6iW7Zqt5KRFqYxl4vCqpDk9Wmhb3fKL3kwX5fQ== <del> xterm@4.9.0-beta.8: version "4.9.0-beta.8" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.8.tgz#ca121934d63f88668d2d5b11d9b2fc3bde7bd805" integrity sha512-EEonYBLANDUBfEeEnHG632bZdgBaAUWst8LFr6oC6f2uLFfJGHQvVJuLaEkPtRvS+jOeoorEXZRPmso1/ANHXA== </del> <ins> xterm@4.9.0-beta.24: version "4.9.0-beta.24" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.24.tgz#48f0990c6d32ad3a9bcc4fb49531d7effdaccea5" integrity sha512-CIVxxxbBiSw1WOMkIjjivaiIC9jNgih4klfWsRGx0qiDF5nbzHuLXkPTt+yAQUu9FCyTUwECm9Pkl3gUsSaGKg== </ins> yauzl@^2.9.2: version "2.10.0"

Discussion:
Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:
Change:
webview: vscode.WebviewPanel, resource: vscode.Uri, locked: boolean, <ins> private readonly _resourceColumn: vscode.ViewColumn, </ins> private readonly _contentProvider: MarkdownContentProvider, private readonly _previewConfigurations: MarkdownPreviewConfigurationManager, private readonly _logger: Logger,

Discussion:
Issue Type: <bBug</b! When using the Markdown preview, the "Show Source" action should be smart enough to know that the source is open and go to that tab. Same applies to the preview tab, if there is already a preview tab open switch focus there. Otherwise you're in this endless loop of creating duplicate tabs. VS Code version: Code - Insiders 1.35.0-insider (, 2019-05-20T05:15:57.974Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (30)</summaryExtensionVersion ------ vscode-browser-preview0.5.4 vscode-opennewinstance0.0.6 bracket-pair-colorizer1.0.61 vscode-svgviewer2.0.0 vscode-eslint1.9.0 gitlens9.7.4 vsc-material-theme2.8.2 prettier-vscode1.9.0 azure-virtual-machine-explorer0.0.2 vscode-pull-request-github-insiders1.137.0 vscode-colorize0.8.10 theme-monokai-pro-vscode1.1.13 vscode-azureappservice0.14.0 python2019.4. remote-containers0.53.0 remote-ssh0.37.0 remote-ssh-edit0.37.0 remote-ssh-explorer0.37.0 remote-wsl0.36.0 azure-account0.8.4 azurecli0.4.5 vscode-typescript-tslint-plugin1.0.0 debugger-for-chrome4.11.3 vetur0.21.0 vscode-docker0.6.2 vscode-yaml0.4.0 code-settings-sync3.2.9 ayu0.18.0 WebTemplateStudio-dev-nightly0.0. markdown-all-in-one2.3.1 (17 theme extensions excluded) </details<!-- generated by issue reporter --
I'd like to give this a try
Ok, I could use some help on this issue. I traced the click call to the function , but am not sure if I should be making any changes here since it will very likely affect other functionalities as well.

I also noticed that if I have the file already open in the same split window pane, it will open that instead of creating a new split pane, but it is even when it opens a new pane with a new tab. So I am confused how calling the same function with the same parameter exhibits different behaviors (opening a new pane with a new tab vs opening an already open tab in the same pane). ! Some pointers around this would be very helpful, thanks
sorry for tagging you, not sure if you got a chance to see my previous comment. Can you please help out?
The api you linked to is a good starting point but that is part of core VS Code. You want the caller of that api, which in the case is the markdown extension. How I think this feature should work: the markdown extension, we maintain a . These should track which column created the preview. This is likely already passed in with , we just don't store the resourceColumn anywhere as far as I remember. the is invoked, use the preview's column information to decide which column to show the preview in
Change:
'Data Science', 'Debuggers', 'Extension Packs', <ins> 'Education', </ins> 'Formatters', 'Keymaps', 'Language Packs',

Discussion:
[x] Add category to marketplace [x] Update completions for [x] Update completions for extensions view [x] Update completions for cli [x] Update documentation
VSCE doesn't hardcode categories, removed that checkbox from the initial post.
Thanks I wasn't sure so figured I'd cover it just in case. :) I opened an issue with the marketplace team to get this onto the sprint plan.
Reopening for the last 2 tasks
I think we can check off 4th item right?
Ah I didn't test this but if the constants fix this too then sounds good!
Reference is updated here:
Change:
} } } catch (error) { <del> notificationService.error(error); </del> <ins> notificationService.error(localize('profile import error', "Error while importing profile: {0}", getErrorMessage(error))); </ins> } })); disposables.add(quickPick.onDidHide(() => disposables.dispose()));

Discussion:
Testing an invalid profile file (for example, by deleting a closing ) importing it Bug We show the error notification: ! This doesn't mention anything about profiles. I suggest showing an error that says the profile cannot be read
A similar error shows when you mistype the url for a profile (or are offline). In this case though you see failed: !
Change:
import { Schemas } from 'vs/base/common/network'; import { TabFocus, TabFocusContext } from 'vs/editor/browser/config/tabFocus'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; <del> import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </del> import { ILabelService } from 'vs/platform/label/common/label'; import { TerminalSettingId } from 'vs/platform/terminal/common/terminal'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions';

Discussion:
Testing into the editor. status bar still says "Tab Moves Focus". I think I'd only expect it to say that when I'm focused in the terminal.
If you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this
I never toggled it at all, this was just using the settings.

Testing an editor and write something in it. tab until you reach the terminal. Type something in the terminal. . Realize that tab is correctly not moving focus in the terminal. command "Toggle Tab Key Moves Focus" out of the terminal and keep tabbing until you get back to your editor. something in the editor. again until you reach the terminal. something in the terminal. to tab out of the terminal. It looks like tab moves focus as toggled itself off. Tab moves focus seems to be off for both terminal and editor at this point until reload.
I can also cause similar behavior if I flip the settings.
what is supposed to happen now? What I think I expect to happen (and isn't happening): If I run "Toggle tab key moves focus" while in a place where it doesn't move focus via setting, then it now globally moves focus. If I run "Toggle tab key moves focus" while in a place where it does move focus, then it now globally does not move focus. However, I'm not a "tab moves focus" user, so maybe my expectations are bogus.
Thank you for testing. Those expectations are correct, except that the toggling does not apply globally - it is per area. So, if I have in settings: terminal tab focus mode: on editor tab focus mode: off where: = status bar indicator = no status bar indicator focus the terminal focus the editor focus the terminal and toggle it off focus the editor and toggle it on focus the terminal focus the editor reload the window and focus the terminal focus the editor I see that this is not working atm because I'm not reacting to configuration changes
fyi for easier testing since the command palette can cause the terminal to no longer be focused, I'd suggest using the keybinding to toggle tab focus mode
Change:
return engine.parse(text.replace(UNICODE_NEWLINE_REGEX, ''), {}); } public resetSlugCount(): void { this._slugCount = new Map<string, number>(); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi! I want to solve this issue as a good-first-issue. Please help me if you can :) In Github there was a problem that README and issues don't work for RTL languages. () Then on November 16, 2021, Github announced that we fixed this problem: () But vscode does not support it yet. For example we see ) in github like this: ! But in vscode, we see the markdown preview like this: ! Feature or improvement request: Providing support for correctly previewing RTL languages texts.
Hi! Can you help me to solve this issue? (as a good-first-issue) I opened a pull request here:
/verified
Change:
title: terminalStrings.changeIcon, f1: false, precondition: ContextKeyExpr.and(ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), TerminalContextKeys.tabsSingularSelection), <del> run: (c, accessor) => getSelectedInstances(accessor)?.[0].changeIcon() </del> <ins> run: async (c, accessor) => { let icon: TerminalIcon | undefined; for (const terminal of getSelectedInstances(accessor) ?? []) { icon = await terminal.changeIcon(icon); } } </ins> }); registerTerminalAction({

Discussion:
Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:
/duplicate
Tracking each action separately
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.
you might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.

Repro: Open multiple terminals Select multiple terminal tabs Right click and change icon Change icon only a single terminal is changed Real context stored with the action was done recently as part of Related:
Change:
AutoReplies = 'terminal.integrated.autoReplies', ShellIntegrationEnabled = 'terminal.integrated.shellIntegration.enabled', ShellIntegrationShowWelcome = 'terminal.integrated.shellIntegration.showWelcome', <del> ShellIntegrationCommandIcon = 'terminal.integrated.shellIntegration.commandIcon', ShellIntegrationCommandIconError = 'terminal.integrated.shellIntegration.commandIconError', ShellIntegrationCommandIconDefault = 'terminal.integrated.shellIntegration.commandIconDefault', </del> <ins> ShellIntegrationDecorationsEnabled = 'terminal.integrated.shellIntegration.decorationsEnabled', ShellIntegrationDecorationIcon = 'terminal.integrated.shellIntegration.decorationIcon', ShellIntegrationDecorationIconError = 'terminal.integrated.shellIntegration.decorationIconError', ShellIntegrationDecorationIconSuccess = 'terminal.integrated.shellIntegration.decorationIconSuccess', </ins> ShellIntegrationCommandHistory = 'terminal.integrated.shellIntegration.history' }

Discussion:
Currently you can disable them via: But this is not particularly easy and the decorations still end up rendering. We should have a switch that disables them outright, including adding them to xterm.
<img width="1111" alt="Screen Shot 2022-02-23 at 5 04 01 PM" src="https://user-"It is enabled even though shell integration is off... But thanks for the fix, now i can go back to using the integrated terminal! EDIT: the fix doesn't work, guess i'm stuck with iterm2 for now...
they're rectangles so you're probably on a pretty old build (1 week+?), updating will probably fix it for you.
are there any verification steps?
It's still unreleased, but use to disable them.
Change:
*--------------------------------------------------------------------------------------------*/ import { disposableTimeout, RunOnceScheduler } from 'vs/base/common/async'; <del> import { Disposable, dispose, IDisposable } from 'vs/base/common/lifecycle'; </del> <ins> import { Disposable, dispose, IDisposable, MutableDisposable } from 'vs/base/common/lifecycle'; </ins> import { localize } from 'vs/nls'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { themeColorFromId, ThemeIcon } from 'vs/platform/theme/common/themeService';

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) When a cell successfully executes, I get a little green check mark to indicate success. Sometimes these marks keep getting instead of just re-using the first one. So I end up with 15+ checks across the bottom of my cell. This looks weird. ! Version: 1.70.1 (user setup) Commit: Date: 2022-08-10T06:08:33.642Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: WindowsNT x64 10.0. 2022.7.110 (12 Aug 2022) No response No response No response_ Local
Thanks for filing this. Have not seen something like this before. I'll look at reproing it. Anything in particular that triggers this behavior? Or just something that shows up to you relatively often?
I've just started noticing it recently. I have not recognized a pattern yet. But I do frequently have exceptions, so maybe having something around it fail and then succeed gets it in a weird state? I'll try to pay more attention to when it starts happening.
I also restart my kernel a lot, which may have something to do with it too.
Hm, we had these issues in the past, but I thought all the bugs were squashed Edited - actually, I was just able to repro this by scrolling around while executing a cell. Not a recent regression
Change:
const identifier = this._getTaskIdentifier(arg); const type = arg && typeof arg !== 'string' && 'type' in arg ? arg.type : undefined; const task = arg && typeof arg !== 'string' && 'task' in arg ? arg.task : arg === 'string' ? arg : undefined; <ins> if (!identifier && !task && !type) { return this._doRunTaskCommand(); } </ins> this._getGroupedTasks().then(async (grouped) => { const tasks = grouped.all(); const resolver = this._createResolver(grouped);

Discussion:
! Here is me triggering run task, it pops up very slowly in todays insiders.
This is most likely because we have to wait for many things before we can provide tasks. Do you see in the status bar an extensions loading spinner?
No the spinner only flashes for like one millisecond. I notice it's slow only when in a repo with just NPM tasks.
which repo are you in there?
this has started happening recently for you, correct?
Yeah, within this iteration. I was on vacation so don't have a better time estimate
I am also experiencing this since updating to the latest VS code version (1.72)
can you share your file?