jiebi/CodeConvo huggingface dataset:
Change:
private renderMarkerStatusbar(context: IEditorHoverRenderContext, markerHover: MarkerHover, disposables: DisposableStore): void { if (markerHover.marker.severity === MarkerSeverity.Error || markerHover.marker.severity === MarkerSeverity.Warning || markerHover.marker.severity === MarkerSeverity.Info) { <del> context.statusBar.addAction({ label: nls.localize('view problem', "View Problem"), commandId: NextMarkerAction.ID, run: () => { context.hide(); MarkerController.get(this._editor)?.showAtMarker(markerHover.marker); this._editor.focus(); } }); </del> <ins> const markerController = MarkerController.get(this._editor); if (markerController) { context.statusBar.addAction({ label: nls.localize('view problem', "View Problem"), commandId: NextMarkerAction.ID, run: () => { context.hide(); markerController.showAtMarker(markerHover.marker); this._editor.focus(); } }); } </ins> } if (!this._editor.getOption(EditorOption.readOnly)) {

Discussion:
Enable Write a long commit message that triggers validation Hover over the diagnostic squiggle <img width="405" alt="image" src=""
Change:
KeybindingsRegistry.registerCommandAndKeybindingRule({ id: PASTE_FILE_ID, weight: KeybindingWeight.WorkbenchContrib + explorerCommandsWeightBonus, <del> when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerResourceNotReadonlyContext, FileCopiedContext), </del> <ins> when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerResourceNotReadonlyContext), </ins> primary: KeyMod.CtrlCmd | KeyCode.KEY_V, handler: pasteFileHandler });

Discussion:
<!-- Use Help Report Issue to prefill these. --- VSCode Version: Confirmed in 1.31 and the latest insider. Version: 1.32.0-insider Commit: Version: 1.31.0 (system setup) Commit: OS Version:Windows_NT x64 10.0. Steps to Reproduce: an arbitrary folder in vscode (call it vscode 1) a new vscode window (call it vscode 2) and open another arbitrary folder. a file in vscode 1. +C or select copy from the right-click menu of the file in vscode 1. to paste the file in vscode 2 with Ctrl+V doesn't work. The "paste" menu item in the right-click menu is also grayed out. This used to work in 1.30.2. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Even dragging the files instead of and it will only move files, not folders. Open all the directories (which is a nice new feature). Drag over to the 2nd windows workspace, and all you'll get is files, not folders. OS Version: 4.20.5-arch1-1-ARCH
PR:
Change:
"peekViewResult.background": "#F2F8FC", "peekView.border": "#705697", "peekViewResult.matchHighlightBackground": "#93C6D6", <del> "tab.lastPinnedBorder": "#C9D0D988", </del> <ins> "tab.lastPinnedBorder": "#c9d0d9", </ins> "statusBar.background": "#705697", "statusBar.noFolderBackground": "#705697", "statusBar.debuggingBackground": "#705697",

Discussion:
The grey used as the pinned tab separator could be a bit stronger and I suggest it is the same grey as for the View separators. !
Yeah, this color is pretty much randomly selected. would you be interested in picking colors for our default themes? Just today I pushed to add the color to our default themes but I did not really spend a lot of time thinking about which color fits best. Most often I picked the border color of the peek view inside the editor. The color key is
Are we sure we don't want to push this as a default for all themes? Because out of the box it's nearly impossible to tell the difference in other themes. Like below, can you tell which files are pinned? !
yeah if you can find a good base color and rule for it, I am all up for it
Change:
return iconClass; } <ins> export function quickInputButtonToAction(button: IQuickInputButton, id: string, run: () => unknown): IAction { let cssClasses = button.iconClass || getIconClass(button.iconPath); if (button.alwaysVisible) { cssClasses = cssClasses ? `${cssClasses} always-visible` : 'always-visible'; } return { id, label: '', tooltip: button.tooltip || '', class: cssClasses, enabled: true, run }; } </ins> export function renderQuickInputDescription(description: string, container: HTMLElement, actionHandler: { callback: (content: string) => void; disposables: DisposableStore }) { dom.reset(container); const parsed = parseLinkedText(description);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Ubuntu 23.04 Steps to Reproduce: the command palette using ctrl+shift+p (or cmd+shift+p on mac) the escape key, closing the command palette 7 times that instance count has increased by 7, instance count has increased by 211, instance count has increased by 240 and instance count has increased by 302. The total disposable count has increased by 1137 from to . One class that has increased the most in the above test was . Looking where relates to the quick input I found this code in where actions are created: Perhaps it could be this code that causes the to be created. It seems the actions aren't registered/disposed like other disposables.
Thanks for reporting this! I think I've cleaned up the ... now we use the simpler non-disposable kind... I'll chip away at the rest over time.
Thanks a lot, I see now: No more Actions are leaked (211 -0) Disposable stores are 211 less leaked (240 -29) Emitter are 211 less leaked (302 -91) MutableDisposable instance count still increases (7 -7) I'll try to find more information for the MutableDisposables and DisposableStores where exactly they are created! Thanks again! Edit: The MutableDisposables are created in : They are kept alive by a 200ms timeout and disposed after 200ms so it's no problem: Just the test executing too fast / finishing before the MutableDisposables were disposed. :)
Change:
import { KeyMod, KeyChord, KeyCode } from 'vs/base/common/keyCodes'; import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'; import { PreferencesEditor } from 'vs/workbench/parts/preferences/browser/preferencesEditor'; <del> import { SettingsEditor2 } from 'vs/workbench/parts/preferences/browser/settingsEditor2'; </del> <ins> import { SettingsEditor2 } from 'vs/workbench/parts/preferences/electron-browser/settingsEditor2'; </ins> import { DefaultPreferencesEditorInput, PreferencesEditorInput, KeybindingsEditorInput, SettingsEditor2Input } from 'vs/workbench/services/preferences/common/preferencesEditorInput'; import { KeybindingsEditor } from 'vs/workbench/parts/preferences/browser/keybindingsEditor'; import { OpenDefaultKeybindingsFileAction, OpenRawDefaultSettingsAction, OpenSettingsAction, OpenGlobalSettingsAction, OpenGlobalKeybindingsFileAction, OpenWorkspaceSettingsAction, OpenFolderSettingsAction, ConfigureLanguageBasedSettingsAction, OPEN_FOLDER_SETTINGS_COMMAND, OpenGlobalKeybindingsAction, OpenSettings2Action, OpenSettingsJsonAction } from 'vs/workbench/parts/preferences/browser/preferencesActions';

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.2 OS Version: kubuntu 18.04 Steps to Reproduce: some text to extension search bar it (by the way I can only select whole text, not part of it) isn't copied to the second clipboard (this is linux specific, middle button clipboard) ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.481 --<!-- potentialduplicatescomment --
Does this work as expected when you select text from other search boxes? For example: The find widget in the editor?
As you see on gif, it works as expected on search box
What about from the editor? Open a file and try the same on the text in the file.
It works everywhere except extension search field. I'm sure it occurred after intellisence in this bar was introduced
If that tiny editor would include the contribution, it would begin to work.
The problem is that the editor lives in the layer and uses the clipboard from electron. Do you recall the need to have the in the layer and not in the layer? Note: This issue will also affect the search in the new Settings editor
I think electron-browser is fine
Change:
margin: 5px; cursor: pointer; } <ins> checkbox > img { margin-bottom: 4px; } </ins> checkbox.checked > img { box-sizing: border-box; <del> margin-bottom: 4px; </del> } checkbox.checked > img { outline: 2px solid var(--vscode-focusBorder);

Discussion:
There's a gap that appears when a theme is selected, turns out there is a margin that is applied to the selected theme: https://user-
Change:
} private _layout(): void { <del> this._editorWidget.layout({ width: DIMENSION_DEFAULT.WIDTH, height: this._editorWidget.getContentHeight() }); </del> <ins> this._editorWidget.layout({ width: DEFAULT.WIDTH, height: this._editorWidget.getContentHeight() }); </ins> } private async _getTextModel(resource: URI): Promise<ITextModel | null> {

Discussion:
Repro: Alt+F1 ! If should be in the center as that's the most obvious location Version: 1.80.0-insider (user setup) Commit: Date: 2023-06-28T08:01:04.380Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.
Putting it here makes the most sense to me because that's where we put other components - like the quick pick. I want to get feedback from low vision users
That's fine, but if you're styling like the command palette we should position it in a similar way ! So below the title bar and not quite and maybe a little less wide
Re , we should also size the height similar to quick pick
But shouldn't the height be determined by the contents?
yes, but have a similar height cap to the quick pick
We should also use the same font as the quick pick
I think you've convinced me - this should be in the center.
Personally I preferred the top position, I'd just render it as the quick pick: Same position and same style. VS Code does not have many vertically centered dialogs. If you want to make it vertically centered, I'd suggest to align it with other vertically centered dialogs, like the trust dialog (notice the background shadow): ! ! Generally, I think, if there is no particular reason to be different, we should try to have a consistent UI throughout the entire product. I'm still in favor of the top position, as the workspace trust dialog is the only vertically centered dialog I know of and it is strongly modal (you have to click one of the buttons to make it disappear). FYI
Fading the background like the trust dialog is good imo, I like centered as it's a very special mode and it's modal as in clicking outside will always dismiss it, unlike the quick pick which may not dismiss when clicking outside. In the end the visual appearance isn't that important really, I just want it to be very obvious when the accessible view is up.
I agree that we should try to align with existing design. My personal preference is to have it positioned like the quick pick.

But in the end, it is not super important as pointed out.
One issue with doing it as the quick pick is it would look wrong being so narrow, and making is narrow would make it less accessible, say if a low vision user was using it.
Not sure it needs to be as narrow as quick pick. I just think the positioning of the quick pick is fitting. So the top and center. It could be wider or longer.
Now that we have the focus border, it is more obvious, so fine to be at the top IMO.
This is still not fixed imo, it should follow quick pick and look like this (native title bar): ! Not this (custom title bar): !
Verified off main :+1:
Change:
}, [TerminalSettingId.FocusAfterRun]: { markdownDescription: localize('terminal.integrated.focusAfterRun', "Controls whether the terminal, accessible buffer, or neither will be focused after `Terminal: Run Selected Text In Active Terminal` has been run."), <del> enum: ['auto', 'terminal', 'accessible-buffer', 'none'], default: 'auto', </del> <ins> enum: ['terminal', 'accessible-buffer', 'none'], default: 'none', </ins> tags: ['accessibility'], markdownEnumDescriptions: [ <del> localize('terminal.integrated.focusAfterRun.auto', "Set to `terminal` when in screen reader optimized mode and `none` otherwise."), </del> localize('terminal.integrated.focusAfterRun.terminal', "Always focus the terminal."), localize('terminal.integrated.focusAfterRun.accessible-buffer', "Always focus the accessible buffer."), localize('terminal.integrated.focusAfterRun.none', "Do nothing."),

Discussion:
Changing this behavior could be jarring, so instead, we will set it to by default and include a hint about this in the terminal accessibility help dialog.
To verify, enable screen reader mode, run the command . The terminal shouldn't be focused and the accessible buffer shouldn't be opened. Change the setting and repeat and verify that it works per the setting descriptions.
So that is u - who spoiled the terminal focus in user-input scenarios. Would be awesome if auto-focus worked only on pending user input to the terminal, so everybody would be happy. But I have no clue if such a functionality is even possible.
not sure what you mean, but you can set it to to have the terminal focused automatically !
Yes, thank you, I know. I mean next cases at the same time: only prints to the console - no focus to the waits for user input - terminal receives auto-focus
Change:
assertNoGlobMatch(p, '/DNXConsoleApp/foo/Program.cs'); } }); <ins> test('URI match', () => { let p = 'scheme:/**/*.md'; assertGlobMatch(p, URI.file('super/duper/long/some/file.md').with({ scheme: 'scheme' }).toString()); }); </ins> });

Discussion:
install "markdown notebook" extension make sure the default editor for MD files is the text editor open a MD file (opens as text) re-open with markdown notebook select an entry from outline or breadcrumbs :bug: a text editor opens
It looks like our editor contribution point isn't called
The same happens with the "references view" and the "problems panel" (use GH issue notebooks and make text editor default for its type)
Debugged this a little: everything works nice up to the point where the user setting is read and . That "steels" the resource from notebooks and re-routes it into the "normal" editor land... This code is novel to me so I might not have the best suggestions how to fix it. One idea is that my contribution marks a scheme as "winner scheme" and resources with that scheme will always use that contribution. Tho, I don't know what side effects that will have
Change:
weight: CORE_WEIGHT, kbExpr: EditorContextKeys.textInputFocus, primary: KeyMod.Shift | KeyCode.UpArrow, <del> secondary: [KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.UpArrow], </del> mac: { primary: KeyMod.Shift | KeyCode.UpArrow }, linux: { primary: KeyMod.Shift | KeyCode.UpArrow } }

Discussion:
VSCode Version: Code 1.17.1 (, 2017-10-10T14:24:50.851Z) OS Version: Windows_NT x64 10.0. Current default keybindings on Windows: has two key bindings, which seems unnecessary. On Linux the default key bindings are (IIRC): Which makes a lot more sense IMHO. Also using this default on Windows would also align Windows/Linux key bindings and maybe even avoid complications like . (same for of course)
We will not change this. See
Change:
.monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.action-label.search>.search-icon { font-size: 14px; opacity: .8; <del> padding: 0 3px; </del> <ins> margin: auto 3px; </ins> } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.action-label.search>.search-label {

Discussion:
Testing ! I expected to be vertically centered. Version: 1.68.0-insider Commit: Date: 2022-05-31T05:17:17.091Z Electron: 17.4.6 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 5.13.0-44-generic snap I'm on Ubuntu
Change:
description?: string; main?: string; browser?: string; <ins> preview?: boolean; </ins> // For now this only supports pointing to l10n bundle files // but it will be used for package.l10n.json files in the future l10n?: string;

Discussion:
Steps to Reproduce: an extension on Marketplace. its to add and to increment so it is semantically greater than the version you published in the previous step. this version as a pre-release. VS Code, view the extension's tab. By default you see the earlier version (not the pre-release). It displays the Preview badge even though its doesn't set this. this version. The Preview badge still shows. I would only expect to see the Preview badge when viewing details of a version in which the preview property is set true. For example: ! It looks like the badge uses a boolean fetched from Marketplace (aka gallery). I guess it is taking the preview flag of the newest Marketplace version, not the version actually being displayed.
does this scenario now work as expected for you?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I don't currently have any extensions in this state, and I'd rather not pollute my Marketplace to verify it. The code change looks good though, so /verified
Change:
import { Registry } from 'vs/platform/registry/common/platform'; import { TreeView, TreeViewPane } from 'vs/workbench/browser/parts/views/treeView'; import { Extensions, ITreeItem, ITreeViewDataProvider, ITreeViewDescriptor, IViewsRegistry, TreeItemCollapsibleState, TreeViewItemHandleArg, ViewContainer } from 'vs/workbench/common/views'; <del> import { EDIT_SESSIONS_DATA_VIEW_ID, EDIT_SESSIONS_SCHEME, EDIT_SESSIONS_SHOW_VIEW, EDIT_SESSIONS_TITLE, IEditSessionsStorageService } from 'vs/workbench/contrib/editSessions/common/editSessions'; </del> <ins> import { ChangeType, EDIT_SESSIONS_DATA_VIEW_ID, EDIT_SESSIONS_SCHEME, EDIT_SESSIONS_SHOW_VIEW, EDIT_SESSIONS_TITLE, IEditSessionsStorageService } from 'vs/workbench/contrib/editSessions/common/editSessions'; </ins> import { URI } from 'vs/base/common/uri'; import { fromNow } from 'vs/base/common/date'; import { Codicon } from 'vs/base/common/codicons';

Discussion:
! In the edit sessions when I click on the file it should show the compare view in between changes with the current head change Right now I have explicitly have to hit the refresh button to show all edit sessions and also the syntax highlighting is missing. It is just showing the white text. I think it would be much better if you provide git stash similar functionality for edit sessions ! Thank you! Appreciate your work
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding!
Verification steps: vscode repo some changes to a file command from command palette changes the node corresponding to the changes you just stored on the tree item for the file you changed in step 2 should open a diff for the file
Change:
errorTelemetry.dispose(); service.dispose(); <ins> sinon.restore(); </ins> } finally { Errors.setUnexpectedErrorHandler(origErrorHandler); }

Discussion:
In short, if you use without calling you are leaking memory. See for the details. I'm seeing a lot of memory used in unit tests and it appears to be coming from sinon. This may be contributing to our unit test OOM issue on Windows 32 bit. Let's see if fixing this lets us run the unit tests again. To fix I have made disposable, and there were some places where tests failed or the refactor seemed larger:
The biggest gain would be from fixing the leak from as it is used many places.
I don't know if you own , but I am looking into a fix for it since it will have the biggest impact.
I've reopened this.
Thanks. I should be careful to not do and instead as that will prevent GitHub from auto closing it
With , I have made disposable and handled disposing it in most tests. There are several places where the way to handle this isn't clear or made test fail when I just naively disposed it. I have them in the issue above.
the instance in is already restored at , but the others should be fixed in Let me know if I miss any! Edit: I ended up making changes in both files.
For those tests where I am just using , should I have to still call or I should wait for your change to dispose the ?
You can wait for my change to dispose the .
FYI Windows ia32 started turning green again
and the only files left are yours. The is now disposable and should be disposed in these test files to properly restore and prevent a memory leak.
Thank you for the fast response everyone!
need help
Change:
].join('n'); } <del> export function getAccessibilityHelpProvider(accessor: ServicesAccessor, editor: ICodeEditor | IVisibleEditorPane) { </del> <ins> function getAccessibilityHelpProvider(accessor: ServicesAccessor, editor: ICodeEditor | IVisibleEditorPane) { </ins> const helpText = getAccessibilityHelpText(); return new AccessibleContentProvider( AccessibleViewProviderId.Notebook,

Discussion:
verification steps: get the latest pre-release for python extension run while focused in the REPL editor, press alt+F1 to open the a11y help view press escape to return focus to the editor
Change:
"Launch VS Code", "Attach to Extension Host" ] <del> } </del> <ins> }, { "name": "Debug Unit Tests", "configurations": [ "Attach to VS Code", "Run Unit Tests" ] }, </ins> ] }

Discussion:
Issue Type: <bBug</bRepo VS Code code base launch the debug configuration Bug In the debug console, see the following error: I've tried a clean and rebuild but haven't been able to get this working VS Code version: Code - Insiders 1.30.0-insider (, 2018-11-19T19:59:44.607Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
After disabling the uri check temporarily, I now get:
Not my launch-config. TBH - I have never used our debugger for tests, I use
I didn't know about the --debug option. I've never understood why the debug config setup is totally different than the typical running setup. Why don't we launch in the same way as --debug but attach the vscode debugger? I'll take a look when I get a chance.