jiebi/CodeConvo huggingface dataset:
Change:
markdownDescription: nls.localize('notebook.textOutputLineLimit', "Controls how many lines of text are displayed in a text output. If {0} is enabled, this setting is used to determine the scroll height of the output.", '`#notebook.output.scrolling#`'), type: 'number', default: 30, <del> tags: ['notebookLayout', 'notebookOutputLayout'] </del> <ins> tags: ['notebookLayout', 'notebookOutputLayout'], minimum: 1, </ins> }, [NotebookSetting.markupFontSize]: { markdownDescription: nls.localize('notebook.markup.fontSize', "Controls the font size in pixels of rendered markup in notebooks. When set to {0}, 120% of {1} is used.", '`0`', '`#editor.fontSize#`'),

Discussion:
Testing ! Is this expected?
it looks like 8 should still be a multiplier from the description. good catch
! now I have ALL THE SPACE... I think this is verified
Change:
async handleURL(uri: URI): Promise<boolean> { if (this.isProfileURL(uri)) { <del> await this.importProfile(uri); </del> <ins> try { await this.importProfile(uri); } catch (error) { this.notificationService.error(localize('profile import error', "Error while importing profile: {0}", getErrorMessage(error))); } </ins> return true; } return false;

Discussion:
Testing an invalid profile file (for example, by deleting a closing ) importing it Bug We show the error notification: ! This doesn't mention anything about profiles. I suggest showing an error that says the profile cannot be read
A similar error shows when you mistype the url for a profile (or are offline). In this case though you see failed: !
Change:
- `suggest` - `paths` - `enabled` — Enable/disable path suggestions. <del> - `experimental` - `validate` - `enabled` — Enable/disable all validation. - `referenceLinks` - `enabled` — Enable/disable validation of reference links: `[text][ref]` - `fragmentLinks` - `enabled` — Enable/disable validation of links to fragments in the current files: `[text](#head)` - `fileLinks` - `enabled` — Enable/disable validation of links to file in the workspace. - `markdownFragmentLinks` — Enable/disable validation of links to headers in other Markdown files. - `ignoreLinks` — Array of glob patterns for files that should not be validated. </del> <ins> - `validate` - `enabled` — Enable/disable all validation. - `referenceLinks` - `enabled` — Enable/disable validation of reference links: `[text][ref]` - `fragmentLinks` - `enabled` — Enable/disable validation of links to fragments in the current files: `[text](#head)` - `fileLinks` - `enabled` — Enable/disable validation of links to file in the workspace. - `markdownFragmentLinks` — Enable/disable validation of links to headers in other Markdown files. - `ignoredLinks` — Array of glob patterns for files that should not be validated. </ins> ### Custom requests

Discussion:
Add some form of error reporting for links in markdown files where we are confident that link is incorrect. Example: We should also have a setting to disable this error reporting since we will not be able to understand every flavor of markdown link
Bad references (seems like this should almost always be a reasonable error to report) Missing files (false positive if users rely on different logic to resolve markdown paths) - Missing headers (false positive if users rely on custom slugifier or are linking to something besides headers, such as html elements) -Checking links to external resources () Checking html in markdown
Re-opening as we will likely keep this as experimental this iteration
Change:
"vscode-oniguruma": "1.7.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.3", </del> <ins> "xterm": "5.3.0-beta.7", </ins> "xterm-addon-canvas": "0.5.0-beta.2", <del> "xterm-addon-image": "0.4.1", </del> <ins> "xterm-addon-image": "0.4.2", </ins> "xterm-addon-search": "0.13.0-beta.2", "xterm-addon-serialize": "0.11.0-beta.2", "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.16.0-beta.2", <del> "xterm-headless": "5.3.0-beta.3", </del> <ins> "xterm-headless": "5.3.0-beta.7", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" }

Discussion:
On the latest insiders I can't click and drag the terminal scroll bar: !
Same here - but at least the terminal can actually be resized now!
I the same problem. In my case, all scrollbars (editor, explorer, ...) were. I tried and it was the same. Not sure if this is related, but Google Chrome and Slack App do not have this issue.
Same issue here, cannot scroll the terminal window. The cursor changes to text selector and is unable to scroll for the entire life of the terminal window. !
I completely shut down macOS and restarted it and it fixed it. It's strange.
Restarting vscode fixes it for me. It only happens when my cursor either hovers over a link in the terminal or I select some text from the terminal, it gets forever stuck in text selection/link click mode.
This is because of the image addon: ! cc
Upstream:
Saw that you released v1.80. In there is still 0.4.1 mentioned as version for xterm-addon-image. The patch version fixing this issue at hand is 0.4.2 - did that not work for you? Note that I was not able to repro the issue with vscode 1.79, so there is a chance that my attempt did not address it. Or did just the package update slip through?
I'm seeing this in Insiders. Restarting VSCode doesn't fix it and it only happens when I have multiple terminals open and the terminal tab sidebar is showing. Version: 1.81.0-insider (Universal) Commit: Date: 2023-07-07T19:50:58.701Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
it came in a bit late for the release and didn't think it met the bar. I'll be updating soon
Change:
"url": "https://schemastore.azurewebsites.net/schemas/json/babelrc.json" }, { <ins> "fileMatch": "babel.config.json", "url": "https://schemastore.azurewebsites.net/schemas/json/babelrc.json" }, { </ins> "fileMatch": "jsconfig.json", "url": "https://schemastore.azurewebsites.net/schemas/json/jsconfig.json" },

Discussion:
Babel 7.7 introduces a : , which shares the schema with . When editing a , one expect to see JSON validations same as . I tag it as feature request as Babel 7.7 is not yet released.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.92 --<!-- potentialduplicatescomment --
Change:
return; } <del> let link = linkDetector.getLinkOccurrence(editor.getPosition()); if (link) { linkDetector.openLinkOccurrence(link, false); </del> <ins> let selections = editor.getSelections(); for (let sel of selections) { let link = linkDetector.getLinkOccurrence(sel.getEndPosition()); if (link) { linkDetector.openLinkOccurrence(link, false); } </ins> } } }

Discussion:
VSCode Version: 1.19.1 OS Version: Windows 10.0. Steps to Reproduce: a markdown with two URLs in two lines, for example: two (collapsed) selections in the middle of each URL, say: Where denotes caret position. "Open Link" command (). Does this issue occur when all extensions are disabled?: Yes ~I'm willing to contribute a PR if that's something you'd like to see in the editor.~ I made a PR with fix in .
Change:
private versionId = 0; private bufferSavedVersionId: number | undefined; private ignoreDirtyOnModelContentChange = false; <ins> private ignoreSaveFromSaveParticipants = false; </ins> private static readonly UNDO_REDO_SAVE_PARTICIPANTS_AUTO_SAVE_THROTTLE_THRESHOLD = 500; private lastModelContentChangeFromUndoRedo: number | undefined = undefined;

Discussion:
This is a follow-up from and describes the problem that save participants causing a save operation
reproduced when undoing some fixes (applying the fix below)
fyi
Change:
shellLaunchConfig.env = shellLaunchConfig.env || {} as IProcessEnvironment; shellLaunchConfig.env['VSCODE_SHELL_LOGIN'] = '1'; } <del> if (env?.['ZDOTDIR']) { </del> <ins> if (env?.['_ZDOTDIR']) { </ins> shellLaunchConfig.env = shellLaunchConfig.env || {} as IProcessEnvironment; <del> shellLaunchConfig.env['ZDOTDIR'] = env['ZDOTDIR'].replace('${execInstallFolder}', remoteEnv.appRoot.fsPath); </del> <ins> shellLaunchConfig.env['_ZDOTDIR'] = '1'; </ins> } newProcess = await backend.createProcess(

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider OS Version: MacOS12.2.2 Steps to Reproduce: with setting new terminal <img width="1440" alt="image" src="https://user-"
Thanks, we're aware of this issue and have been working toward its resolution
Change:
import { Disposable, DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { ResourceMap } from 'vs/base/common/map'; import { Schemas } from 'vs/base/common/network'; <del> import { isEqual } from 'vs/base/common/resources'; </del> <ins> import { basename, isEqual } from 'vs/base/common/resources'; </ins> import { isDefined } from 'vs/base/common/types'; import { URI } from 'vs/base/common/uri'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility';

Discussion:
Locally I have an empty cell at the bottom of my notebook because I executed the last cell When I try to merge in a change that has new cells, I get a merge conflict that requires I open the ipynb in a text editor to resolve. !
We can explore how to handle this gracefully in the serializer.
not sure what needs to be done in the serializer here. can you provide more information, i would have thought this was purely an issue with merge conflicts.
Can this please be solved? It's hard to work collaboratively within a team using Jupyter notebooks and VS Code if we can't sort out merge conflicts.
I suggest there be an option to disable the notebook renderer temporarily in all editors. git operates at the text level and when merge conflict happens, it will likely produce a malformed JSON file. We now have an error message to notify users to fallback to text editor, but "resolve in merge editor" button still don't work. !
Note: When there are merge conflicts, one will always have to open a plain text (json) editor to resolve the merge confligs I.e. its not possible to use Notebook UI to resolve merge conflicts (at least not yet) Steps to test Ensure you have merge conflicts in a Notebook document Open the SCM view, and click on the IPYNB file, and verify you can see the merge conflicts in plain text editor view Click on the button and verify you get the merge editor (again plain text), see here When you have merge conflicts, try opening the ipynb file from the explorer view, if this fails verify you are displayed with an error message with the option to open the file in plain text view
Change:
padding: 3px; margin-left: 12px; text-decoration: underline; <ins> cursor: pointer; </ins> } .monaco-workbench .part.banner .message-container a { text-decoration: underline; <ins> cursor: pointer; </ins> } .monaco-workbench .part.banner .action-container {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.2 OS Version: Web Steps to Reproduce: a banner set up with a link in it. over the link still uses the arrow cursor, rather than switching to the pointer which is more commonly associated with links.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
can you please provide a screen shot. Which banner do you mean?
Change:
focusNext?: boolean; } <ins> export interface IClickedDataUrlMessage { __vscode_notebook_message: string; type: 'clicked-data-url'; data: string; downloadName?: string; } </ins> export interface IClearMessage { type: 'clear'; }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Python Notebook implementation has special code to handle click events of links containing an ObjectUrl (href=blob:....). I'm hoping VS Code would handle this natively as these links allow users to save blobs as files. This is generic enough that it need not be something special to the Python implementation. Would benefit anyone using the new VSC API to display HTML that allows saving images. Current Python Notebook implementation: We handle all click events in document If target element === and starts with . Then we get the blob contents and send it to extension On extension side we prompt user to save the file using . /cc
what is the use case for this?
Sure, a user could render a plotly plot and such plots can contain links to save images, and those hrefs have a ref to object urls. This isn't specific to Python extension, any HTML could have markup that allows users to save images . Also, opening such a plot in other notebook viewer, user is able to click such links and save the images. If this isn't address, then VSCode displays an empty page in notebook with an error message (see below). I think this is due to the fact that href results in nativigating the current page to url=blob://. & again, we can address this with a custom renderer, however I believe this is generic enough for VSC to handle. ! !
TIL about the API. Should this also work for URLs?
Good pick. I would say yes. At the end of the day someone could render a link with a download attribute
To do this for blob ULIs, I have to download the contents of the URL in the context of the webview, and pipe it back to vscode to write to a file. Data URLs are easier, I can just open it in a browser. Maybe an experience in vscode would be nicer though. Where are these urls coming from in your case, some 3rd party renderer code or your extension code?
3rd party That's exactly what we have in our python extension when using the webview.

I thought this would be generic enough for VSCode to handle, as others could end up with similar scenarios, at the end of the day it's from a 3rd party package.
Yeah, I think it makes sense for us to handle this as well.
Do you have an example of a notebook that has this button? Is this from ipywidgets?
Also can you link me to the code that handles this in your extension?
No, its plot generated by plotly. Here's the code required to generate such a plot:
I thought this was working on Wednesday, but now I get a CORS error when I fetch any blob URL from the webview code. Did you do anything to handle this? I don't understand why it's working in your webview and not mine. Maybe we are making webview changes right now that might affect this.
U might have to setup the csp (for data and blobs), this here's what we have:
Change:
sessionStore.clear(); })); linkGestureStore.add(gesture.onExecute(async e => { <del> if (this._hoverOnLine !== -1) { if (e.hasTriggerModifier) { // Control click this._instaService.invokeFunction(goToDefinitionWithLocation, e, this._editor as IActiveCodeEditor, { uri: this._editor.getModel()!.uri, range: this._stickyRangeProjectedOnEditor } as Location); } else { // Normal click </del> <ins> if ((e.target as unknown as CustomMouseEvent).detail !== this.getId()) { return; } if (e.hasTriggerModifier) { // Control click if (this._candidateDefinitionsLength > 1) { </ins> this._editor.revealPosition({ lineNumber: this._hoverOnLine, column: 1 }); } <ins> this._instaService.invokeFunction(goToDefinitionWithLocation, e, this._editor as IActiveCodeEditor, { uri: this._editor.getModel()!.uri, range: this._stickyRangeProjectedOnEditor } as Location); } else { // Normal click this._editor.revealPosition({ lineNumber: this._hoverOnLine, column: 1 }); </ins> } })); return linkGestureStore; }

Discussion:
Testing Unexpected behavior here: It seems to be scrolling to the right spot but the peek view is partially out of view: ! The file Code - OSS @ : Version: 1.71.0 Commit: Unknown Date: Unknown Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No
This can happen when a symbol has multiple definition locations. In that case we use peek to show all definitions and we need to make sure that revealing works nicer.
This seems like it's still present on today's Insiders https://user- If it helps to test, this is the file I was using:
Hi Connor, thanks for your bug. This should be solved with the PR: that was created today. The new behavior is: !
The cursor position is still wrong when I try verify on the same file: !
Nvm, tested the wrong version due to delayed insiders today
Change:
const config = workspace.getConfiguration('git'); const shouldIgnore = config.get<boolean>('ignoreLimitWarning') === true; const useIcons = !config.get<boolean>('decorations.enabled', true); <ins> const sortBranchListByCommitterDate = config.get<string>('sortOrderForBranch') === 'committerdate'; </ins> this.isRepositoryHuge = didHitLimit; if (didHitLimit && !shouldIgnore && !this.didWarnAboutLimit) {

Discussion:
I agree that sometimes it is more useful to but I often feel that it makes it hard to find branches when a naming scheme like "user/feature" is used and I want to quickly find all branches of a user. Even without that scheme there are good reasons why having an alphabetical sort option makes sense, if only for personal preference. To avoid a religious discussion, could the sort order be made into a config option?
, working on this :)
Change:
# Copyright (c) Microsoft Corporation. All rights reserved. # Licensed under the MIT License. See License.txt in the project root for license information. <del> function realpath() { /usr/bin/python -c "import os,sys; print(os.path.realpath(sys.argv[1]))" "$0"; } </del> <ins> function realpath() { python -c "import os,sys; print(os.path.realpath(sys.argv[1]))" "$0"; } </ins> CONTENTS="$(dirname "$(dirname "$(dirname "$(dirname "$(realpath "$0")")")")")" ELECTRON="$CONTENTS/MacOS/Electron" CLI="$CONTENTS/Resources/app/out/cli.js"

Discussion:
Issue Type: <bBug</bInside the shell command script python is used (using it's full path) to infer the path for the actual script file (rather than the link used to run it): function realpath() { /usr/bin/python -c "import os,sys; print(([1]))" "$0"; } This doesn't work when a non-default python exists in the path along wiht a matching PYTHONPATH variable In my case, anaconda with python3 and PYTHONPATH=/usr/local/lib:/usr/local/lib/python3.6/site-packages The script exists with an error: Your PYTHONPATH points to a site-packages dir for Python 3.x but you are running Python 2.x! I edited the script file to use python instead of /usr/bin/python, but this gets overwritten with every minor update, requiring redoing the edit every couple of days. Script should either not get overwritten with every update if it has not changed or to use relative path (just python instead of /usr/bin/python) VS Code version: Code - Insiders 1.22.0-insider (, 2018-03-14T06:08:15.960Z) OS version: Darwin x64 17.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ markdown-toc1.5.6 vscode-markdownlint0.14.0 matlab0.8.0 cmake-clangd-helper0.1.0 code-gnu-global0.2.2 togglehs0.1.2 codecpp-minimum0.0.1 jupyter1.1.4 code-runner0.9.3 CppSnippets0.0.13 cmake-tools-helper0.1.1 vscode-clang0.2.2 python2018.2.1 cpptools0.15.0 markdown-preview-enhanced0.3.4 cmake0.0.17 cmake-tools0.10.4 markdown-all-in-one1.1.0 (3 theme extensions excluded) </detailsReproduces without extensions <!-- generated by issue reporter --
This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the for VS Code. See also our guidelines. Happy Coding!

No, this has absolutely nothing to do with the python extension or any other extension I’m talking about the script installed into /usr/local/bin/code-insiders (which I guess is also the same one installed by the non insiders version) by running: Shell Command: Install ‘code-insider’ command in path The script contains the following, where using /usr/bin/python instead of just python is incorrect and causing the issue #!/usr/bin/env bash function realpath() { /usr/bin/python -c "import os,sys; print(([1]))" "$0"; } CONTENTS="(dirname "(dirname "0")")")")")" ELECTRON="$CONTENTS/MacOS/Electron" CLI="$" ELECTRONRUNAS_NODE=1 "CLI" "$ exit $?
caused by , I think we may be able to go back to just now after
Removed the hardcoded path for python. Please review.
Change:
if (tokenizationSupport && tokenizationSupport.createBackgroundTokenizer && !tokenizationSupport.backgroundTokenizerShouldOnlyVerifyTokens) { this._backgroundTokenizer.value = tokenizationSupport.createBackgroundTokenizer(this._textModel, b); } <del> if (!this._backgroundTokenizer.value) { </del> <ins> if (!this._backgroundTokenizer.value && !this._textModel.isTooLargeForTokenization()) { </ins> this._backgroundTokenizer.value = this._defaultBackgroundTokenizer = new DefaultBackgroundTokenizer(this._tokenizer, b); this._defaultBackgroundTokenizer.handleChanges();

Discussion:
I think we used to do this. The below profile was generated by opening a ~100mb typescript file and copy and pasting its contents. The editor locked up for about 2-3 minutes before tokenization finished. After it finished it was reasonably fast but a slower computer may crash from this and waiting minutes for something to finish is not reasonable. ! Version: 1.82.0-insider (user setup) Commit: Date: 2023-08-21T05:32:43.957Z Electron: 25.5.0 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
I had set, even though it's async we still shouldn't be doing it for files this large unless the user force enables it.
As in freezed? In the profile it looks it just reacts on the onmessage event, the UI shouldn't freeze.
You can see the task in the screenshot takes ~600ms, so the editor dropped to ~2 fps for 3 minutes or less fps when other things were happening in the same task.