jiebi/CodeConvo huggingface dataset:
Change:
return; } <ins> // Prevent middle clicks opening a broken link in the browser if (event.button == 1) { event.preventDefault(); } </ins> let baseElement = event.view.document.getElementsByTagName('base')[0]; /** @type {any} */ let node = event.target;

Discussion:
When middle clicking any of the links in the image, it opens the browser with a broken url For example for the remote development link, the url is: ! I'm Using Ubuntu 18.04
Hi I'm not sure I understand the scenario here. Why would you want to open to a section of the in-product release notes in an external browser? Left click will navigate to the section staying in-product. We had expected people to read the release notes either in-product or on the website at We didn't think people would want to use both at the same time.
Habit! problem is it took me several seconds to realize that I was not suppose to do that, so maybe middle-clicking should be disabled, or just not open in a browser, in fact, I was just expecting it to open in a new tab
Here's where we handle clicks inside of webviews:
Change:
["{", "}"], ["[", "]"], ["(", ")"], <ins> { "open": "@'", "close": "n'@", "notIn": ["string", "comment"]}, { "open": "@"", "close": "n"@", "notIn": ["string", "comment"]}, </ins> { "open": """, "close": """, "notIn": ["string"]}, { "open": "'", "close": "'", "notIn": ["string", "comment"]}, ["<#", "#>"]

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I'll have a PR out for this in a sec. Wanted to get an issue tracking it. These and should autoclose. NOTE: PowerShell syntax says that the here string open () should be the last characters on a line so we should include a newline in the close.
Change:
if (result) { this._icon = result.icon; this._onIconChanged.fire({ instance: this, userInitiated: true }); <ins> return this._icon; </ins> } <ins> return; </ins> } <del> async changeColor() { </del> <ins> async changeColor(color?: string): Promise<string | undefined> { if (color) { this.shellLaunchConfig.color = color; this._onIconChanged.fire({ instance: this, userInitiated: true }); return color; } </ins> const icon = this._getIcon(); if (!icon) { return;

Discussion:
Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:
/duplicate
Tracking each action separately
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.
you might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.

Repro: Open multiple terminals Select multiple terminal tabs Right click and change icon Change icon only a single terminal is changed Real context stored with the action was done recently as part of Related:
Change:
if (e === TerminalCapability.CwdDetection) { this.capabilities.get(TerminalCapability.CwdDetection)?.onDidChangeCwd((e) => { this._cwd = e; <ins> if (this._linkManager) { this._linkManager.processCwd = this._cwd; } this._xtermOnKey?.dispose(); </ins> this.refreshTabLabels(this.title, TitleEventSource.Api); }); }

Discussion:
Testing vscode open to folder , and another folder . Have the files , , and , to folder enter in the terminal and click on it. opens in the folder. opens https://user-
Maybe I'm doing something wrong, but I can't reproduce. I have a workspace with a . It opens that before I into a new directory. I into a new directory with a and when I click on it, that one opens. !
did it look like shell integration was enabled on hover ?
Can repro, we need to also make validated local link provider aware of command detection.
this should already work as preprocessPath uses the cwd Guessing this is a windows only issue, as I'm not encountering it on mac
I think _processCwd is hooked up to the old system:
<img width="1648" alt="image" src="https://user-" is this as expected, I'm in folder and clicking on opens the quick pick other than directly opening .
if you create another terminal and hover the tab, what capabilities do you see?
hadn't enabled shell integration. he did and does see the capabilities, the run recent command works, but he said that this does not.
issue above is with word links whereas this original issue was not
Can repro, the following screenshot tries to open a link in vscode: ! !
Change:
const file = this.extHostFileSystemInfo.extUri.joinPath(extensionLogDir, `${fileName}.log`); const id = `${extension.identifier.value}.${fileName}`; const logger = this.loggerService.createLogger(file, { id, name, logLevel, extensionId: extension.identifier.value }); <del> return new ExtHostLogOutputChannel(id, name, logger, this.proxy, extension); </del> <ins> return new ExtHostLogOutputChannel(id, name, file, logger, this.proxy, extension); </ins> } private createExtensionLogDirectory(extension: IExtensionDescription): Thenable<URI> {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.
Thanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like "command was already registered" or "notebook controller already exists". I am currently commenting out my line in my extension. It's not ideal though.
PR fixing it
Change:
getTopStackFrame(): IStackFrame | undefined { const callStack = this.getCallStack(); // Allow stack frame without source and with instructionReferencePointer as top stack frame when using disassembly view. <del> const firstAvailableStackFrame = callStack.find(sf => !!(sf && </del> <ins> const firstAvailableStackFrame = callStack.find(sf => !!( </ins> ((this.stoppedDetails?.reason === 'instruction breakpoint' || (this.stoppedDetails?.reason === 'step' && this.lastSteppingGranularity === 'instruction')) && sf.instructionPointerReference) || <del> (sf.source && sf.source.available && sf.source.presentationHint !== 'deemphasize'))); </del> <ins> (sf.source && sf.source.available && !isFrameDeemphasized(sf)))); </ins> return firstAvailableStackFrame; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No - debugging requires plugins. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.1 OS Version: MacOS Steps to Reproduce: a debug adapter that applies a presentation hint to the top of a thread. that VSCode still selects that frame for focus if a stop event is issued for that thread. Although it isn't part of the DAP, envisions the possibility that a stack frame could have a presentation hint , in which case it treats that frame the same as if its had the presentation hint , where that value is part of the DAP. However, in of a given thread, only the is checked for the presentation hint, leading to the possibility that a frame that is 'deemphasized' according to the is nevertheless selected for highlighting, and its source focused, when the debugger signals a stop on that thread.
Change:
this._hoverDelegate = { showHover: (options: IHoverDelegateOptions): IDisposable | undefined => { return this.hoverService.showHover(options); <ins> }, hideHover: () => { return this.hoverService.hideHover(); </ins> } }; }

Discussion:
Issue Type: <bBug</bIn the past, if the tree item was falsy, the would be used instead on hover. makes it so that if the tree item's is falsy after calling , then instead of following the old behavior and using , it will stick as 'Loading...' forever. Instead, if is falsy, it should fall back to to most closely resemble prior behavior. VS Code version: Code - Insiders 1.53.0-insider (, 2021-01-27T08:59:32.031Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ vscode-eslint2.1.14 vscode-docker1.9.1 csharp1.23.8 python2021.1. jupyter2020.12. remote-containers0.156.0 remote-ssh0.63.0 remote-ssh-edit0.63.0 remote-wsl0.53.2 vscode-remote-extensionpack0.20.0 azure-account0.9.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
FYI
this fix is out in the latest insiders, can you please let us know when you've verified, thanks
everything seems to be working nicely, thanks!
Change:
let terminalDescription = localize('terminalDescription', "Controls the terminal description, which appears to the right of the title. Variables are substituted based on the context:"); terminalDescription += terminalDescriptors; <ins> export const defaultTerminalFontSize = isMacintosh ? 12 : 14; </ins> const terminalConfiguration: IConfigurationNode = { id: 'terminal', order: 100,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The new January 2024 (version 1.86) updates allows you to change the terminal font size with the mouse wheel. This is mouse users. Why were us keyboard users left out?? Can we please get commands to increase, decrease and reset the terminal font to be used for custom hotkeys. Cheers
Our zoom in / out keybindings do this for me... and
that's for the whole workbench, not just the terminal. This is also lacking in the editor afaict. I'm going to close this as out of scope as it's very easy for an extension to implement this type of behavior. Correct me if I'm wrong about the editor missing the behavior though as we want to align there.
We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the . Just in case, in a few simple steps you can get started . See also our . Happy Coding!
it does exist for the editor ! !
Thanks, I was searching for "zoom"
sweeeeet! Thank you. Looking forward to this.
Change:
this.migrateInputValidationSettings() .then(() => { mapEvent(filterEvent(workspace.onDidChangeTextDocument, e => e.document.uri.scheme === 'vscode-scm'), e => e.document)(this.onDidChangeTextDocument, this, this.disposables); <del> filterEvent(workspace.onDidChangeConfiguration, e => e.affectsConfiguration('git.inputValidation'))(this.onDidChangeConfiguration, this, this.disposables); </del> <ins> filterEvent(workspace.onDidChangeConfiguration, e => e.affectsConfiguration('git.inputValidation') || e.affectsConfiguration('git.inputValidationLength') || e.affectsConfiguration('git.inputValidationSubjectLength'))(this.onDidChangeConfiguration, this, this.disposables); </ins> }); }

Discussion:
Testing a commit message with more than 50 characters on the first line, notice the warning. the settings editor and change to 100. The warning is still there.
Change:
this.dragCancellationToken = new CancellationTokenSource(); this.treeViewsDragAndDropService.addDragOperationTransfer(uuid, this.handleDragAndLog(this.dndController, itemHandles, uuid, this.dragCancellationToken.token)); this.treeItemsTransfer.setData([new DraggedTreeItemsIdentifier(uuid)], DraggedTreeItemsIdentifier.prototype); <ins> originalEvent.dataTransfer.clearData(Mimes.text); </ins> if (this.dndController.dragMimeTypes.find((element) => element === Mimes.uriList)) { // Add the type that the editor knows originalEvent.dataTransfer?.setData(DataTransfers.RESOURCES, '');

Discussion:
Testing have the code below drag a item of the tree onto the tree itself two dnd items are being dropped: and the value of the latter is the internal tree id () and I am unsure how useful that is. Maybe the label of the tree item is a better value?
console output
This is set by the internal list view. I'm not sure it makes sense to change this, since we would then open the door to changing other items too. If an extension wants the label, then can use to add it.
Yeah, maybe not change but drop/filter it. I feel that we should curate the items that extensions see - once for clarity and for not "leaking" internals to them
Change:
} }); <ins> // #region nls </ins> const innoSetupConfig = { 'zh-cn': { codePage: 'CP936', defaultInfo: { name: 'Simplified Chinese', id: '$0804', } }, 'zh-tw': { codePage: 'CP950', defaultInfo: { name: 'Traditional Chinese', id: '$0404' } },

Discussion:
Testing in Firefox, with Spanish (es-es) set Open "Get Started with VS Code in the Web" walkthrough Select last step (open up your code), then first command ("Open Folder" in English, "Abrir carpeta" in Spanish) Modal is in English: ! It isn't a new string, and I didn't think getting started or this command would be from an extension, but perhaps that is the case.
I also see this on modals on the overall welcome page when I try opening a file or folder: !
Thank you for your feedback. We are currently reviewing it (reference ).
This is an odd one. The string looks good here: but the file that that comes from doesn't show up at all in our Spanish files: I'll have to dig into why this is... any ideas?
might be a bug in the tool so that the localize call is not detected. When you generate the export is the string included.
Ok the web strings are now bundled in language packs. It may take a minute for all these new strings to make their way through the translation system... but by end game it should be good.
Change:
this._zone.value.widget.updateInfo(''); this._zone.value.widget.updateToolbar(true); this._log('request took', requestClock.elapsed(), this._activeSession.provider.debugName); <del> this._chatAccessibilityService.acceptResponse(a11yResponse); </del> <ins> this._chatAccessibilityService.acceptResponse(a11yResponse, requestId); </ins> } progressiveEditsCts.dispose(true);

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.
Change:
display: none; } <del> img { width: 16px; margin-right: 4px; </del> <ins> .header { display: flex; </ins> }

Discussion:
Noticed how the process explorer is bundling and still. Can we not use Codicons for this? //cc
Oh this seems to be used in the issue reporter, not process explorer. But not sure how to actually see it...
are we actually using these icons? I'm not seeing it: !
it looks like these are only used when VSCode is connected to a remote to show the remote processes as well. I didn't even know we had that, pretty cool: ! Anyhow, my request still seems valid.
PR up at !
Change:
} this.playingSounds.add(sound); const url = FileAccess.asBrowserUri( `vs/platform/audioCues/browser/media/${sound.fileName}` ).toString(); <del> const audio = new Audio(url); audio.volume = this.getVolumeInPercent() / 100; audio.addEventListener('ended', () => { this.playingSounds.delete(sound); }); </del> try { <del> try { // Don't play when loading takes more than 1s, due to loading, decoding or playing issues. // Delayed sounds are very confusing. await raceTimeout(audio.play(), 1000); } catch (e) { console.error('Error while playing sound', e); } </del> <ins> await playAudio(url, this.getVolumeInPercent() / 100); } catch (e) { console.error('Error while playing sound', e); </ins> } finally { <del> audio.remove(); </del> <ins> this.playingSounds.delete(sound); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.7.2 OS Version: windows Steps to Reproduce: a file with error on `cue: line has an error" settings the cursor to there
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
it still occurs with 1.73.1
yeah I can reproduce this issue. is this expected?
This is not expected. Sounds should be played when cursor is navigated to the error line. worked on this initially and might have more details
I also have the same problem, but this only occurs in the insider version, I have the latest version and no sound is played Issue:
They play in OSS, but not insider's. any idea why that would be?
if that is the case then it is probably related to code bundling. Does that sound play when you F1 list audio cues?
It does play when I list audio cues in both OSS and insider's.
It also plays for terminal quick fixes - suggesting there's a bug in because I can also repro it not playing for other line feature types
This has been working for me lately, though it was definitely broken at one pt.
I have set to I navigate to a line with an error-squiggle but there is no sound being played
Change:
suite('vscode API - commands', () => { <del> teardown(assertNoRpc); </del> <ins> teardown(async function () { assertNoRpc(); await closeAllEditors(); }); </ins> test('getCommands', function (done) {

Discussion:
from
A possible regression from
No, actually was reported before:
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
Change:
"tab.inactiveBackground": "#10192c", // "tab.activeForeground": "", // "tab.inactiveForeground": "", <del> "tab.lastPinnedBorder": "#596F99", </del> <ins> "tab.lastPinnedBorder": "#2b3c5d", </ins> // Workbench: Activity Bar "activityBar.background": "#051336",

Discussion:
The grey used as the pinned tab separator could be a bit stronger and I suggest it is the same grey as for the View separators. !
Yeah, this color is pretty much randomly selected. would you be interested in picking colors for our default themes? Just today I pushed to add the color to our default themes but I did not really spend a lot of time thinking about which color fits best. Most often I picked the border color of the peek view inside the editor. The color key is
Are we sure we don't want to push this as a default for all themes? Because out of the box it's nearly impossible to tell the difference in other themes. Like below, can you tell which files are pinned? !
yeah if you can find a good base color and rule for it, I am all up for it
Change:
if (_classifier === null) { _classifier = new CharacterClassifier<CharacterClass>(CharacterClass.None); <del> const FORCE_TERMINATION_CHARACTERS = ' t<>'"、。｡､，．：；‘“〈《「『【〔（［｛｢｣｝］）〕】』」》〉”’｀～…'; </del> <ins> const FORCE_TERMINATION_CHARACTERS = ' t<>'"、。｡､，．：；‘〈「『〔（［｛｢｣｝］）〕』」〉’｀～…'; </ins> for (let i = 0; i < FORCE_TERMINATION_CHARACTERS.length; i++) { _classifier.set(FORCE_TERMINATION_CHARACTERS.charCodeAt(i), CharacterClass.ForceTermination); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.2 OS Version: Windows 10 .1440 Steps to Reproduce: a URL containing or , for example: VSCode usually can recognize URLs with non-alphanumeric characters, for example, the URL can be properly recognized and you can ctrl+click to open it. However, URLs containing or , like the above example I gave, cannot be properly recognized in VSCode. I assume this is a bug or an oversight rather than a design decision, as I can't see any reason to exclude or in URLs. While I write this issue I notice that Github actually recognizes such URLs with no problem, so I guess it's not outrageous to ask VSCode to support them too. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
in "" was explicitly marked as url termination character. I don't know why though. Shall I just remove it?
Thanks for pointing out the place! This list seems to contain a lot of punctuation marks and many of them may be a little questionable. For instance are all just variations of parentheses or quotation marks. They are often used as part of an URL rather than to terminate an URL. But since there are so many of them I don't know what is the best way to handle it. Some people may have been relying on this behavior and removing some characters could break it. Maybe you can make it customizable but then that would add to your workload.
I think it's fine to change things and remove "" / "" as force termination characters. Especially if there are things like wikipedia links with them.

Actually, the best change would be to do some logic similar as we do for "(" / ")", where we actually tweak behavior for ")" based on the presence of "(" inside the link or not.
Let's do that if or ever collides with something! Afaik these characters aren't markdown control characters.
Thanks for the quick move. While we are at it, some other characters are in a similar situation. Can you do the same to them too? At least the following two pairs are quite common: “ ” “”
These links should work now too!