jiebi/CodeConvo huggingface dataset:
Change:
if (shouldAlignBase && baseViewZoneAccessor) { baseViewZoneIds.push(baseViewZoneAccessor.addZone({ <del> afterLineNumber, </del> <ins> afterLineNumber: m.left.baseRange.startLineNumber - 1, </ins> heightInPx: 16, domNode: $('div.conflict-actions-placeholder'), }));

Discussion:
<img width="869" alt="image" src="https://user-"
Is the issue the codelens column? That is still what I see <img width="305" alt="image" src="https://user-"
The issue is the missing space in base.
Like this: <img width="1483" alt="image" src="https://user-"
Change:
} terminalToReuse.terminal.scrollToBottom(); <ins> launchConfigs.reconnectionProperties = { ownerId: ReconnectionType, data: { lastTask: task.getCommonTaskId(), group, label: task._label, id: task._id } }; </ins> await terminalToReuse.terminal.reuseTerminal(launchConfigs); if (task.command.presentation && task.command.presentation.clear) {

Discussion:
Steps to reproduce: in repo run the default build task and wait for it to finish reveal terminal once, hide it again restart the build task (see keyboard config below) via wait for the "Loading..." to show in status bar reload window the loading indicator and the build task indicator are gone Keybinding: !
I bet this is happening because there's still so it's returning here before the can occur which is what we listen to for
This works for me in Insider's now that I fixed the issue with rerunning tasks /duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I can still reproduce it with:
this was fixed yesterday, so should be fixed in today's build. It appears you're using the build from a day ago. Pls reopen if not
This still reproduces for me with the steps outlined in my first comment: open folder only have explorer and editor visible, no terminal our any panel have no build task running close open run default build task (no terminal or panel visible still) wait for that to finish drag the panel area visible from status bar so that it reveals terminals close panel rerun default build task, wait for "building..." reload window notice how the status bar does not show the tasks Video below, this is after I had started a build task that completed: !
returns here when the terminal is reused and likely doesn't have the reconnection properties as a result
after reuse happens, they're deleted in !
If that doesn't fix it, then it's a timing issue because reuseTerminal disposes of the process
I still see this in: ! Steps: open window (no build task running yet) wait for "Loading..." reload window Can you maybe add more logging and I can try to find the reason from the logs?
that commit is from two days ago - the fix was merged yesterday. not sure why this is labeled insider's released by the bot !
Hm ok, weird, will try again then with the next insiders, thanks!
Yes this seems to be working a lot better now . I think I had 1 case without reconnection but that was really quickly triggering a window reload right after , I think that is a corner case not worth pursuing. I will report back when I ever hit this during selfhosting over the next days.
Change:
class NoUnexternalizedStringsRuleWalker extends Lint.RuleWalker { <del> private static ImportFailureMessage = 'Do not use double qoutes for imports.'; </del> <ins> private static ImportFailureMessage = 'Do not use double quotes for imports.'; </ins> private static DOUBLE_QUOTE: string = '"';

Discussion:
when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose "compare with clipboard".
An extension would be ideal for a feature like this.
fyi
It would be great too if also is allowed to compare selection with clipboard.
It would be great if we could compare unsaved files...
I would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to
Has someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?
not yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.
Change:
"scopeName": "source.regexp.python", "path": "./syntaxes/MagicRegExp.tmLanguage.json" } <del> ] </del> <ins> ], "configurationDefaults": { "[python]": { "diffEditor.ignoreTrimWhitespace": false } } </ins> }, "scripts": { "update-grammar": "node ../node_modules/vscode-grammar-updater/bin MagicStack/MagicPython grammars/MagicPython.tmLanguage ./syntaxes/MagicPython.tmLanguage.json grammars/MagicRegExp.tmLanguage ./syntaxes/MagicRegExp.tmLanguage.json"

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
"group": "inline@2" }, { <del> "command": "git.revealInExplorer", "when": "scmProvider == git && scmResourceGroup == index", "group": "2_view@1" }, { </del> "command": "git.revealFileInOS.linux", "when": "scmProvider == git && scmResourceGroup == index && remoteName == '' && isLinux", <del> "group": "2_view@2" </del> <ins> "group": "2_view@1" </ins> }, { "command": "git.revealFileInOS.mac", "when": "scmProvider == git && scmResourceGroup == index && remoteName == '' && isMac", <del> "group": "2_view@2" </del> <ins> "group": "2_view@1" </ins> }, { "command": "git.revealFileInOS.windows", "when": "scmProvider == git && scmResourceGroup == index && remoteName == '' && isWindows", <ins> "group": "2_view@1" }, { "command": "git.revealInExplorer", "when": "scmProvider == git && scmResourceGroup == index", </ins> "group": "2_view@2" }, {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In the Source Control panel, "Reveal in Explorer View" of context menu is above "Reveal in File Explorer". <img src="" width="300"But context menu of the tabs, "Reveal in Explorer View" is below "Reveal in File Explorer". <img src="" width="300"It's not consistent. It will occur mis-clicking.
Could you triage the issue?
would you be up to swap the order you contribute from the git extension?
Change:
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { getCurrentAuthenticationSessionInfo } from 'vs/workbench/services/authentication/browser/authenticationService'; <del> import { AuthenticationSession, IAuthenticationService } from 'vs/workbench/services/authentication/common/authentication'; </del> <ins> import { AuthenticationSessionAccount, IAuthenticationService } from 'vs/workbench/services/authentication/common/authentication'; </ins> import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IProductService } from 'vs/platform/product/common/productService';

Discussion:
Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !
This still reproduces
does this still repro? maybe its imperceptible to me?
Yeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?
looks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately
Yeah that seems like a reasonable ask since it goes to the extension host and back, today.
This issue has existed since 2 years! But only recently have I encountered this.
Change:
width: 100%; height: 35px; } <ins> .monaco-workbench .activitybar .menubar.compact .toolbar-toggle-more { width: 100%; height: 35px; } </ins>

Discussion:
Steps to Reproduce: web in Safari on compact menu = it moves !
I diagnosed this and see 2 issues: the menu items are not removed from the DOM when menu is not showing () you seem to be using instead of to hide the menu items, is there any particular reason? using the issue is not as bad anymore (I only see one initial jump) I suggest we use / (our helper), but I am not sure if you rely on the behavior of visibility?
I mentioned the reasoning in the linked issue, but in the compact case we can remove them from the DOM safely so patching that should help here.
Change:
const shellIntegration = terminalEnvironment.injectShellIntegrationArgs(this._logService, this._configurationService, env, this._configHelper.config.shellIntegration?.enabled || false, shellLaunchConfig, OS); if (shellIntegration.enableShellIntegration) { shellLaunchConfig.args = shellIntegration.args; <del> if (env?.['ZDOTDIR']) { </del> <ins> if (env?.['_ZDOTDIR']) { </ins> shellLaunchConfig.env = shellLaunchConfig.env || {} as IProcessEnvironment; <del> const activeWorkspaceRootUri = this._historyService.getLastActiveWorkspaceRoot(Schemas.file); const lastActiveWorkspaceRoot = activeWorkspaceRootUri ? withNullAsUndefined(this._workspaceContextService.getWorkspaceFolder(activeWorkspaceRootUri)) : undefined; const resolved = await this._configurationResolverService.resolveAsync(lastActiveWorkspaceRoot, env['ZDOTDIR']); env['ZDOTDIR'] = resolved; </del> <ins> shellLaunchConfig.env['_ZDOTDIR'] = '1'; </ins> } // Always resolve the injected arguments on local processes await this._terminalProfileResolverService.resolveShellLaunchConfig(shellLaunchConfig, {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider OS Version: MacOS12.2.2 Steps to Reproduce: with setting new terminal <img width="1440" alt="image" src="https://user-"
Thanks, we're aware of this issue and have been working toward its resolution
Change:
private readonly historyItemMenus = new Map<SCMHistoryItemTreeElement, IMenu>(); private readonly disposables = new DisposableStore(); <del> private _incomingHistoryItemGroupMenu: IMenu; get incomingHistoryItemGroupMenu(): IMenu { return this._incomingHistoryItemGroupMenu; } private _incomingHistoryItemGroupContextMenu: IMenu; get incomingHistoryItemGroupContextMenu(): IMenu { return this._incomingHistoryItemGroupContextMenu; } private _outgoingHistoryItemGroupMenu: IMenu; get outgoingHistoryItemGroupMenu(): IMenu { return this._outgoingHistoryItemGroupMenu; } private _outgoingHistoryItemGroupContextMenu: IMenu; get outgoingHistoryItemGroupContextMenu(): IMenu { return this._outgoingHistoryItemGroupContextMenu; } </del> constructor( @IContextKeyService private readonly contextKeyService: IContextKeyService, <del> @IMenuService private readonly menuService: IMenuService) { this._incomingHistoryItemGroupMenu = this.menuService.createMenu(MenuId.SCMIncomingChanges, this.contextKeyService); this.disposables.add(this._incomingHistoryItemGroupMenu); </del> <ins> @IMenuService private readonly menuService: IMenuService) { } </ins> <del> this._incomingHistoryItemGroupContextMenu = this.menuService.createMenu(MenuId.SCMIncomingChangesContext, this.contextKeyService); this.disposables.add(this._incomingHistoryItemGroupContextMenu); this._outgoingHistoryItemGroupMenu = this.menuService.createMenu(MenuId.SCMOutgoingChanges, this.contextKeyService); this.disposables.add(this._outgoingHistoryItemGroupMenu); </del> <ins> getHistoryItemMenu(historyItem: SCMHistoryItemTreeElement): IMenu { return this.getOrCreateHistoryItemMenu(historyItem); } </ins> <del> this._outgoingHistoryItemGroupContextMenu = this.menuService.createMenu(MenuId.SCMOutgoingChangesContext, this.contextKeyService); this.disposables.add(this._outgoingHistoryItemGroupContextMenu); </del> <ins> getHistoryItemGroupMenu(historyItemGroup: SCMHistoryItemGroupTreeElement): IMenu { return historyItemGroup.direction === 'incoming' ? this.menuService.createMenu(MenuId.SCMIncomingChanges, this.contextKeyService) : this.getOutgoingHistoryItemGroupMenu(MenuId.SCMOutgoingChanges, historyItemGroup); </ins> } <del> getHistoryItemMenu(historyItem: SCMHistoryItemTreeElement): IMenu { return this.getOrCreateHistoryItemMenu(historyItem); </del> <ins> getHistoryItemGroupContextMenu(historyItemGroup: SCMHistoryItemGroupTreeElement): IMenu { return historyItemGroup.direction === 'incoming' ? this.menuService.createMenu(MenuId.SCMIncomingChangesContext, this.contextKeyService) : this.getOutgoingHistoryItemGroupMenu(MenuId.SCMOutgoingChangesContext, historyItemGroup); </ins> } private getOrCreateHistoryItemMenu(historyItem: SCMHistoryItemTreeElement): IMenu {

Discussion:
Testing I expected the action to appear on an unpublished branch, not the action. I am aware they both do the same. <img width="647" alt="Screenshot 2024-01-24 at 11 37 40" src=""
Change:
this.getUI().inputBox.enabled = enabled; this.getUI().ok.enabled = enabled; this.getUI().list.enabled = enabled; <del> if (!enabled) { this.getUI().container.focus(); } </del> } }

Discussion:
enabled: <img width="662" alt="image" src="https://user-"disabled: <img width="683" alt="image" src="https://user-"The fix in asks the following follow up questions: "being disabled" be styled differently than "being enabled"? Right now they are rendered identically. the event of disablement, it looks like the only valid thing that can take focus is the entire quick pick container which asks the following questions: does it look right? is it accessible? what do you think?
What are the use cases for a disabled quick pick?
Yeah it's a good question... I'm not entirely sure. I think maybe when you have server-side validation... so: "Enter the name of the Azure Static Web App you want to create" type in 'foo' and hit Enter quick pick sets the property and the property to signal that the input is being processed got a result from slow API saying 'foo already exists'... surface that to the user and reenable input
Seems like we should be dimming the value text and setting the input use a attribute to start. I assume we're showing progress via a notification or some other indicator? <img width="581" alt="CleanShot 2022-12-06 at 10 53 05 src="https://user-"
Our azure extension friends are hitting this - the actual user issue for them is that focus is not preserved. So the quick pick shows up first as disabled, and then later they enable it (once API request comes back). And the focus is not there - so the user can not hit enter. Can we look into making sure that on quick pick enablement we pass focus into the input box (if the focus is already anywhere in the big quick pick element)? Please correct me if needed
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
Verification: a new extension with this code in inside the callback of the hello world command F5 the Hello World command from the command palette The focus should still be in the input box (and not on the outer area like the screenshot above shows) and you should not be able to change the contents of the input box.
Change:
default: return lang; } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0.0 OS Version: Windows 10 build .4598 Steps to Reproduce: a header with a raw HTML element HTML is included in markdown header anchors ( is included!)
Note: links without the HTML tag work in editor mode only
This is for path completions, right? Seems to work fine for me ! Does this reproduce in the with all ?
I'm not referring to autocompletion, but what I mean is for the anchor links to work in preview mode (editor mode is fine) they have to include raw HTML tags I.e., the attribute values generated for headers include raw HTML tags I tested it in with all extensions disabled and same result, but still I will test it in insiders build
tested at (clean), same results
Change:
return; } <del> if (item.action.edit) { </del> <ins> if (item.action.edit?.edits.length) { </ins> const result = await bulkEditService.apply(item.action.edit, { editor: options?.editor, label: item.action.title,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.1, commit VS Code Insiders Version: 1.75.0, commit . I discovered the following bug while investigating (and fixing) To summarize, the issue is that if a code action has both the and properties set, then the command isn't executed. I created the following repo with a minimal reproduction:
I'm not sure this is accurate on the VS Code side since JS/TS uses edits + commands without issue Made code actions skip running commands if applying the edit fails. Are you perhaps supplying an empty or invalid edit?
Is an empty edit considered invalid? Because that's what the Rust language service does: It provides an empty edit so that the editor doesn't resolve the code action and ask for the missing property.
When you say empty, do you mean the edit is or do you return an edit object without any edits?
I mean a .
likely fixes that but returning empty edits to force a resolve seems suspicious. On the VS Code side, should only be called . If LSP is doing something different, please file an issue against them
Yep the Rust issue is now fixed in Insiders. Note that it's the other way around: The Rust client returns empty edits so that VS Code doesn't invoke .
Change:
dispose(): void { if (this._sender?.flush) { <del> this._sender.flush(); </del> <ins> // Disposed of so now we set it to undefined Promise.resolve(this._sender.flush()).then(this._sender = undefined); this._apiObject = undefined; </ins> } } }

Discussion:
Testing Given this code: I was expecting my event handlers not to fire since the logger is disposed, but they still fire.
This still repros for me <img width="1210" alt="image" src="https://user-"
Change:
} public removeBreakpoints(breakpoints0: vscode.Breakpoint[]): Promise<void> { <del> this.startBreakpoints(); </del> // remove from array const breakpoints = breakpoints0.filter(b => this._breakpoints.delete(b.id));

Discussion:
Set some breakpoints Access from an extension- it's an empty array Try again - it's full Seems that we don't sync breakpoint into to the EH until the first call to one of the breakpoint properties do you have some context on this? It's a little confusing because I wouldn't expect sending breakpoint infos to be expensive, and I would expect to be able to access the breakpoints array immediately.
I do not have more context. I believe is the author of this code. I like your suggestion that we change this and actively sync the breakpoints into the EH (since it should not be expensive).
The observed behavior is by design: we want to avoid that all breakpoints get transferred to all active extensions all the time. But the API doc doesn't explain this...
Thanks is the worry that it's too much data/too expensive? What's the solution for extensions that need to access the list of breakpoints?
yes, potentially too much data and traffic for all extensions. What's the solution for extensions that need to access the list of breakpoints? adding a to the function of an extension will register the extension to receive live updates for . With this will always reflect the current set of breakpoints.
Thanks, I don't really understand that though, it doesn't seem like that much traffic/data, compared to something like the full text of open documents. If it's going to work this way, I should document it in But I might try doing some testing to remove this restriction because I think it's unexpected.
Verification steps: Create an extension that can log the value of Set a breakpoint in any file Then trigger your extension to check the length of the breakpoints array It should log the correct value on the first try- previously it would have been 0 on the first access, then the correct value afterwards
Change:
{ "command": "github.copyVscodeDevLinkFile", "when": "false" <ins> }, { "command": "github.openOnVscodeDev", "when": "false" </ins> } ], "file/share": [

Discussion:
Testing Clone a git repository Open git repository in VS Code desktop Make a change to one or more files Invoke the command You are presented with an empty picker <img width="736" alt="image" src="https://user-"