jiebi/CodeConvo huggingface dataset:
Change:
resourceProvider: WebviewResourceProvider, ): Promise<MarkdownContentProviderOutput> { const rendered = await this.engine.render(markdownDocument, resourceProvider); <del> const html = `<div class="markdown-body">${rendered.html}<div class="code-line" data-line="${markdownDocument.lineCount}"></div></div>`; </del> <ins> const html = `<div class="markdown-body" dir="auto">${rendered.html}<div class="code-line" data-line="${markdownDocument.lineCount}"></div></div>`; </ins> return { html, containingImages: rendered.containingImages

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi! I want to solve this issue as a good-first-issue. Please help me if you can :) In Github there was a problem that README and issues don't work for RTL languages. () Then on November 16, 2021, Github announced that we fixed this problem: () But vscode does not support it yet. For example we see ) in github like this: ! But in vscode, we see the markdown preview like this: ! Feature or improvement request: Providing support for correctly previewing RTL languages texts.
Hi! Can you help me to solve this issue? (as a good-first-issue) I opened a pull request here:
/verified
Change:
const btn = store.add(new RevertButton( m.lineRangeMapping.modified.startLineNumber, this._widget, <del> m.lineRangeMapping.innerChanges, </del> <ins> m.lineRangeMapping, </ins> false )); this._editors.modified.addGlyphMarginWidget(btn);

Discussion:
a change it using the gutter arrow :bug: indentation is lost
Can you share a screenshot/screenrecording and provide context on the document you have? Thanks!
Cannot reproduce: ! Please always try to include as much context as you can.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Hi Henning I think I can also reproduce this in 1.84.0-insider (MacOS). I believe the preconditions to reproduce is to set (which is also the default) and revert a deleted code chunk. See attached gif. !
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
Change:
content.push(localize('inlineChat.explain', "When a request is prefixed with /explain, a response will explain the code in the current selection and the chat view will be focused.")); content.push(localize('inlineChat.toolbar', "Use tab to reach conditional parts like commands, status, message responses and more.")); } <del> content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat.")); </del> <ins> content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat. By default, if a request takes more than 5 seconds, you will hear an audio cue indicating that progress is still occurring.")); </ins> return content.join('n'); }

Discussion:
cc Now that we have audio cues for the chat experience, all of which are off by default, we should think about what the best experience would be for most SR users and proceed with that once the final audio cues have been provided.
My choice here would be to only enable audioCues.chatResponsePending since it is the only one that provides information that is not redundant, however, this is an area in which I believe user research would be beneficial. for example, do people feel like these audio cues complement the screen reader feedback? are they distracting? Wen the chat is done generating the answer, do they prefer to receive screen reader feedback, the audio cue or both?
Yeah, that was my feeling as well Having all off by default would decrease discoverability, so I'm in favor of setting just that one to true until we have data that suggests otherwise
Just wanted to rule out any ambiguity here, does "audioCues.chatResponsePending" = the "progress" or "response" sound?
I believe he means progress because the response sound is redundant since the response gets read by the screen reader
Change:
} as IObjectDataItem; } <del> const defaultValue = elementDefaultValue[key]; </del> const valueEnumOptions = getEnumOptionsFromSchema(objectProperties[key]); return { key: {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No Problem with default extension settings. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.2 OS Version: Windows 10 Pro x64 Steps to Reproduce: Behavior before updating to 1.64 version (and it's an expected result) I create extension settings in in contributes section (according to ) user opens Settings -Extensions -~someExtension~Settings user cannot delete default settings Behavior after updating to 1.64 version (and it's an actual result) I create extension settings in in contributes section (according to ) user opens Settings -Extensions -~someExtension~Settings user can delete default settings (it's a 1st issue) if get all settings by vscode.workspace.getConfiguration() - we get these deleted default settings (it's a 2nd issue) As result, the user deleted default settings, but it's still there, but not visible Video:
I think it is fine for the user to delete default settings to change the setting value away from the default. That change comes from But, the deleted settings still showing up when we fetch the configuration doesn't seem correct.
It is because of merging strategy of object value settings. For eg merging following objects results to So, this is expected. Not sure what changed in UI so leaving to you
Verification steps: and run the extension to the JSON Settings editor. the following: over to the GUI Settings editor. for the setting . that a row with the key still shows up.
Change:
"SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE." ], "isOnlyProductionDependency": true, <del> "version": "102.0.5005.194" </del> <ins> "version": "102.0.5005.196" </ins> }, { "component": {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith
Change:
box-sizing: border-box; overflow: hidden; display: flex; <del> height: 100%; </del> padding: 0 6px; }

Discussion:
<img width="472" alt="capture" src="https://user-"
I think they look nice centered in the quick pick item. Any particular reason for this feedback?
I think they don't look nice :-), especially since the second line is rendered slightly dimmed.
This suggestion looks like it's in line with the documented design intent from in the VS Code design toolkit. The actions and shortcuts should be aligned with the primary text of the option. This makes the position stable whether the second line of supporting text is shown or not :) !
Yeah top aligned looks like it fits more imo
I think another reason for top right alignment is that when hovering over items, the action will always be in a consistent spot.
I think I'm use to seeing them center aligned because of Teams: !
Another example where we have multi-lines and actions shown is in notifications: <img width="466" alt="CleanShot 2021-09-01 at 12 04 53 src="https://user-"
LGTM
Change:
resource = (input as IResourceInput).resource; } <ins> // Cannot compare file with self - exclude active file if (!!resource && resource.toString() === globalResourceToCompare.toString()) { return void 0; } </ins> if (!resource) { return void 0; // only support to compare with files and untitled }

Discussion:
Code 1.14.2 Since it does not make sense and Code prevents comparing a file with itself, it would make sense to exclude the current file from the file picklist for comparing files.
Fixed with PR
Change:
await wait; controller.accept(); <del> const value = await inputPromise; </del> <ins> const value = await raceTimeout(inputPromise, 2000); </ins> assert.strictEqual(value, 'foo'); });

Discussion:
all out of ideas on this one. I'm not relying on setTimeouts or anything. It's a totally responsive test:
Maybe add some logging that only prints if the event does not fire in 4 seconds.
Ok I've better logging in the form of... if takes too long, the test failure will be different. Additionally, just in case this is a weird focus artifact, I have set ignoreFocusOut
I've not heard any reports of this failing recently... once it fails again, I'll revisit now that I have extra logging. With that said, it's possible that because of I have fixed the test failure.
Change:
openExtensionViewlet(this.paneCompositeService, `${this.options.marketplaceTag} ${quickpick.value}`); } } <del> }); </del> <ins> })); </ins> quickpick.show(); <ins> }).finally(() => { disposables.dispose(); </ins> }); }; await pickInstalledThemes(currentTheme.id);

Discussion:
Quick pickers are itself disposables, as well as the events they provide. Noticed a few leaks around picker instances and/or events: //cc
There's already a that is called when the picker hides. Isn't that good enough?
see the various events (those beginning with ) and how they are not getting disposed.
But they are going to an emitter that is owned by the quickpick. Disposing the quickpick is also disposed all its emitters. There's no real leak here.
my understanding is that an that gets disposed (when you dispose the quick picker) does not dispose the -functions it had returned, i.e. this code is not running: But maybe or can also chime in.
Yes - an emitter doesn't dispose its listeners. you basically rely on GC'ing here and I am uncertain if that actually works (e.g some disposables are tracked centrally for later blaming). I understand your motives but we generally dispose all the things
Change:
const newFrame = document.createElement('iframe'); newFrame.setAttribute('id', 'pending-frame'); newFrame.setAttribute('frameborder', '0'); <del> newFrame.setAttribute('sandbox', options.allowScripts ? 'allow-scripts allow-forms allow-same-origin allow-pointer-lock' : 'allow-same-origin allow-pointer-lock'); </del> <ins> newFrame.setAttribute('sandbox', options.allowScripts ? 'allow-scripts allow-forms allow-same-origin allow-pointer-lock allow-downloads' : 'allow-same-origin allow-pointer-lock'); </ins> if (host.fakeLoad) { // We should just be able to use srcdoc, but I wasn't // seeing the service worker applying properly.

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2 to latest insiders OS Version: linux kernel 4.18 Steps to Reproduce: an extension, create a webview which uses FileSaver js library , to save something in a file from a "save" button within the webview sure you load the webview with the extension. In VSCode before 1.48, there was no problem The extension where I discovered the problem is , in the WarpScript . <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No It seems Chrome engine another layer to sandbox default security in the meantime, now allow-downloads is necessary within the iframe sandbox settings. PR coming soon.
PS: Reverting VSCode back to 1.47 make the same extension working great. That's what I did during a few weeks before digging into the problem.
Change:
constructor(private readonly repository: Repository) { this.disposables.push(window.registerFileDecorationProvider(this)); <del> repository.historyProvider.onDidChangeCurrentHistoryItemGroupBase(this.onDidChangeCurrentHistoryItemGroupBase, this, this.disposables); </del> <ins> repository.historyProvider.onDidChangeCurrentHistoryItemGroup(this.onDidChangeCurrentHistoryItemGroup, this, this.disposables); </ins> } <del> private async onDidChangeCurrentHistoryItemGroupBase(): Promise<void> { </del> <ins> private async onDidChangeCurrentHistoryItemGroup(): Promise<void> { </ins> const newDecorations = new Map<string, FileDecoration>(); await this.collectIncomingChangesFileDecorations(newDecorations); const uris = new Set([...this.decorations.keys()].concat([...newDecorations.keys()]));

Discussion:
No steps yet, but it happened twice today that I have seen stale decorations, e.g after pull <img width="1367" alt="Screenshot 2024-02-14 at 12 26 08" src=""
Change:
}); info.actions = sourceActions; this._kernelSources.set(id, info); <del> this._onDidChangeSourceActions.fire({ notebook: notebook.uri }); </del> <ins> this._onDidChangeSourceActions.fire({ notebook: notebook.uri, viewType: notebook.viewType }); </ins> }; this._register(sourceMenu.onDidChange(() => {

Discussion:
When we only have a couple of notebook controllers created for a notebook type, without any kernel detection task or kernel source commands, the "Select Another Kernel" should not show.
I have no kernels in the MRU, clicking Select Kernel brings me to this quickpick, and clicking the back button here does nothing--I think it shouldn't be shown in this scenario ! I have the Jupyter extension installed but not the Python extension installed, with the MRU picker enabled, the Select Kernel dropdown spins forever like this: !
Change:
private _orthogonalSize: number; get orthogonalSize(): number { return this._orthogonalSize; } <del> private absoluteOffset: number = 0; private absoluteOrthogonalOffset: number = 0; </del> <ins> private _absoluteOffset: number = 0; get absoluteOffset(): number { return this._absoluteOffset; } private _absoluteOrthogonalOffset: number = 0; get absoluteOrthogonalOffset(): number { return this._absoluteOrthogonalOffset; } </ins> private absoluteOrthogonalSize: number = 0; private _styles: IGridViewStyles;

Discussion:
Was finally able to repo this but not reliably. It seems to rely on a new being created, but this doesn't always happen. The most reliable repo for me: with a notebook and text editor in a single editor group the notebook editor down to create a new group below the text editor grab the notebook editor and drag it right to move the bottom editor to the right I think the root cause is that the notebook widget is passed the wrong position. I'm going to work around this by making the notebook editor ignore the position it is given, however this will also undo the performance fixes we made this iteration for notebook layout I don't fully understand the grid layout code but it seems that is being set incorrectly in cases where a new BranchNode/SplitView is created. Here's what I see happening after step 3 of the repo above: setter is called calls which creates a new the constructor, a new Split View is created is called on it. At this point, of the split view is: the time layout is called on the notebook editor widget, is computed as zero. This results in the wrong layout. Looking at the code, we can see that is passed in as the absolute offset in step 4: <img width="1104" alt="Screenshot 2022-11-30 at 12 48 54 PM" src="https://user-"If I then slightly resize the window, here's what happens: call on the split View for the new group now is: we layout the notebook editor, is now correctly computed as Originally posted by in
Change:
} if (terminalService.isProcessSupportRegistered) { <ins> eventOrOptions = !eventOrOptions || eventOrOptions instanceof MouseEvent ? {} : eventOrOptions; eventOrOptions.target = eventOrOptions.target || terminalService.configHelper.config.defaultLocation; </ins> let instance: ITerminalInstance | undefined; if (folders.length <= 1) { // Allow terminal service to handle the path when there is only a // single root <del> instance = terminalService.createTerminal(); </del> <ins> instance = terminalService.createTerminal(eventOrOptions); </ins> } else { const options: IPickOptions<IQuickPickItem> = { placeHolder: localize('workbench.action.terminal.newWorkspacePlaceholder', "Select current working directory for new terminal")

Discussion:
The terminal commands and are used for both the panel buttons and the commands in the CP (that we do want to use the defaultLocation for). Not sure how to differentiate between them - don't think we want to duplicate the actions. let me know what you think
Let's wait until after is done since that will likely add target support to the create commands
Other reproes: Ctrl / Cmd J to open the panel - terminal editor is created focus the terminal editor, click the trash can on the panel , close the editor tab - a bunch of errors in the console
Change:
.scm-view .scm-editor-container { position: relative; box-sizing: border-box; <del> padding: 1px; outline-offset: -1px; outline: 1px solid var(--vscode-input-border); </del> <ins> background-color: var(--vscode-input-background); border: 1px solid var(--vscode-input-border, transparent); </ins> border-radius: 2px; }

Discussion:
Perhaps due to semi-opaque color being applied to multiple layers within the input: <img width="210" alt="CleanShot 2022-12-15 at 11 28 11 src="https://user-"<img width="289" alt="CleanShot 2022-12-15 at 11 28 23 src="https://user-"
The source control message input background does not seem to use color customization at all.
I saw it in there, but it's a fairly complex component under the hood and (I think) multiple layers of the component use it. Because the color is semi-opaque it's appearing brighter than it should be after mixing with one layer with another.
You can reproduce & verify that the colour is not applied to this particular input by setting color customization in your settings JSON to a bright red: Observe all other inputs having bright red backgrounds but the commit message input background still having the same background as the surrounding panel's background.
This is what I am seeing with the built-in theme, it looks like it completely blends with the panel's background. For me this is happening with all themes, built-in & third-party - the input's background inherits the panel's background and cannot be customised at all. !
It works for me. I don't see the behavior you do with a transparent background. I'm also noting that you have a different typeface used for the placeholder. That leads me to believe there is something else going on. Are you using any extensions that manipulate VS Code e.g. customize UI? <img width="314" alt="CleanShot 2022-12-15 at 13 26 22 src="https://user-"In any case this will be fixed by . I'd recommend opening up a separate issue for your specific problem.
It works for me too when I place SCM panel to the left sidebar, but when SCM panel is placed to the right sidebar then background colour theming is ignored on the input. I do not see this problem mentioned in . ! !
That one I can indeed repro. Can you file a new issue for that?
Done! Submitted as .
Change:
h('span.title@title'), h('span.description@description'), h('span.detail@detail'), <ins> h('span.toolbar@toolbar'), </ins> ]), h('div.container', [ h('div.gutter@gutterDiv'),

Discussion:
Theirs / Yours title area is currently quite empty. We should consider to add an action bar for "Compare with Base" action. The title area should also have additional Git information in the future fyi !
I don't see a branch or commit id in your screenshot. Is that configured somehow? <img width="533" alt="CleanShot 2022-06-28 at 10 00 52 src="https://user-"In any case, we could introduce a toolbar somewhat like the editor. Icons are placeholder, but an example could look like: <img width="1032" alt="CleanShot 2022-06-28 at 10 05 06 src="https://user-"
Unsure what was seeing there but with the normal git flow we do show the branch names and commits in question. There is also different issue for the toolbar and since today an icon in front of the commit it
To verify open a merge editor verify that it has menus with yours/theirs
Change:
// Remember widget this.inputWidgets.set(input, templateData.inputWidget); templateData.elementDisposables.add({ <del> dispose: () => { this.inputWidgets.delete(input); this.contentHeights.delete(input); } </del> <ins> dispose: () => this.inputWidgets.delete(input) </ins> }); // Widget cursor selections

Discussion:
I'm seeing some flickering here, just Write a multi-line commit message cmd+enter to commit !
Change:
import MDDocumentSymbolProvider from './features/documentSymbolProvider'; import { MarkdownContentProvider } from './features/previewContentProvider'; import { MarkdownPreviewManager } from './features/previewManager'; <ins> import MarkdownFoldingProvider from './features/foldingProvider'; </ins> export function activate(context: vscode.ExtensionContext) {

Discussion:
:+1:
+1
Why is this essential feature still not a thing?
because it relies on which is non-trivial and it needs to be prioritized against other work.
+1
+1
+1 or adding a heading list view(TOC view) on the right side, it's really convenient for editing a large markdown file.
Please refer to the org-mode tab feature to implement, it's powerful.
+1
duplicate of
Reopening to track the markdown specific work of
I noticed that this is already implemented in the latest insider build, thanks a lot. One more request, would you please preserve the last blank line of a folded region? I mean becomes instead of One reason is that currently
Can anyone update the status on this?
it's coming to the next stable release.
Change:
}); } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Issue Type: <bBug</bctrl-shift-p, "Debug: Start Debugging" leads to this error. I saw that this error was previously mentioned and fixed in a recent update, but the error persists. VS Code version: Code 1.46.1 (, 2020-06-17T21:13:20.174Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.19.104-microsoft-standard <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ regex0.2.0 gitlens10.2.2 vscode-pull-request-github0.17.0 vscode-codemetrics1.24.0 cpptools0.28.3 vscode-versionlens1.0.8 java0.63.0 vscodeintellicode1.2.8 application-insights0.4.2 vscode-java-debug0.26.0 vscode-java-dependency0.10.2 vscode-java-pack0.9.1 vscode-java-test0.23.0 vscode-maven0.22.0 code-lens-roundup1.0.0 remote-containers0.122.1 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.3 vscode-remote-extensionpack0.20.0 </details<!-- generated by issue reporter --
Same problem vscode v1.47.3. any update on this issue?
The issue was fixed in this insiders release:
what debugger are you using?
Dotnet Core.
thanks. That debugger is a separate extension (C#). Please file an issue against that. We have fixed a similar problem with the debugger (which is built into VS Code). But that fix does not cover the C# debugger.