jiebi/CodeConvo huggingface dataset:
Change:
order: { type: 'integer', description: nls.localize('scope.order', 'When specified, gives the order of this setting relative to other settings within the same category. Settings with an order property will be placed before settings without this property set.') <del> } </del> <ins> }, ignoreSync: { type: 'boolean', description: nls.localize('scope.ignoreSync', 'When enabled, Settings Sync will not sync the user value of this configuration by default.') }, </ins> } } ]

Discussion:
Create UI extension with a 'machine' scoped setting Load that UI extension in a remote window See a message in local settings that this setting can only be set on the remote If I understand correctly, since the extension is local, the setting should be set locally, right?
Irrespective of where extension is running, machine scoped settings are always ignored from local settings and can be applied only from remote settings. Closing this as designed. If there is a reason or use case to allow in local settings, let me know.
Ok, the scope description needs to be fixed then: I guess it should say "in a remote/local window" instead of referencing where the extension is running. My use case was that there are remote resolver settings which should not be synced because they reference local paths, and I don't think there is a way to do that.
Yup, you are right. Description needs to be fixed.
Should this be a feature request?
I see.. you cannot tag them as machine settings because in the remote window they are not respected. I will reopen this as a feature request for this use case.
You can already do this by setting property on the setting. This is not shown in the intellisense though - it.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
targetKey: string; } <ins> export interface ISettingOverrideClickEvent { scope: string; targetKey: string; } </ins> export class SettingsRenderer implements ITreeRenderer { public static readonly CONTROL_CLASS = 'setting-control-focus-target';

Discussion:
Issue Type: <bFeature Request</bTesting Just a thought: When I see "Modified in: Workspace" I might want to go there and check. I'd keep font and color as they are and add an underline and pointer cursor to "Workspace" on hover. VS Code version: Code - Insiders 1.27.0-insider (, 2018-08-29T05:12:15.247Z) OS version: Darwin x64 17.7.0 <!-- generated by issue reporter --
Good idea!
I would take a PR for this "Modified in: Workspace" - the word Workspace is underlined When clicked, it switches to the Workspace scope, and copies the setting key into the search bar, so the view is filtered to just that one setting
I'm interested in looking into this if that is alright.
Change:
if (this.canSelectMany) { this.ui.list.domFocus(); } <del> event.preventDefault(); </del> <ins> dom.EventHelper.stop(event, true); </ins> break; case KeyCode.PageDown: this.ui.list.focus(QuickInputListFocus.NextPage); if (this.canSelectMany) { this.ui.list.domFocus(); } <del> event.preventDefault(); </del> <ins> dom.EventHelper.stop(event, true); </ins> break; case KeyCode.PageUp: this.ui.list.focus(QuickInputListFocus.PreviousPage); if (this.canSelectMany) { this.ui.list.domFocus(); } <del> event.preventDefault(); </del> <ins> dom.EventHelper.stop(event, true); </ins> break; case KeyCode.RightArrow: if (!this._canAcceptInBackground) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.44.2 OS Version: Ubuntu 19.10 Steps to Reproduce: navigate editors through QuickOpen "navigate next" and "navigate previous" work as "navigate next after next" and "navigate previous of previous". So simply said it skip next/previous editor. Here are keybindings I use ` works ok, but and don't <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
PR: The issue is that we are listening to keys within the quick input control to do certain things but we do not prevent bubbling. This means our keybinding service will also receive these keys and check for actions to perform. In the old quick open widget we always prevented bubbling for that reason.
Change:
owner: match[1], repositoryName: match[2] }; <ins> } else { console.error('No GitHub match'); </ins> } return undefined;

Discussion:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid
Change:
this._register(this.storageService.onDidChangeValue(e => this.onDidChangeStorage(e))); } private _reportTelemetry() { const extensionIds = this.installed.filter(extension => !extension.isBuiltin &&

Discussion:
re The automatic perf monitoring has shown a high number of calls to . This means the call/function itself is slow or it is called at a very high rate (so that the profiler always sees it running) The most common stacktrace via which this is reported comes through .
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I don't think this is a dupe because the callstack comes in via which I don't see in the other trace
But I think the root cause is same for both that is slow as mentioned in the summary of the other issue. Hence I marked it as duplicate.
Pfff - that would mean it is catastrophically slow. My suspicion is that it is just slow but that comes in combination with being over eagerly called? Maybe some event leakage or some over eager calling through some other means. This symptom might disappear when has become fast but I think we need to understand why it ends up on a hot code path in the first place
Will investigate why this is being eagerly called too.
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.46: version "0.14.0-beta.46" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.46.tgz#d25cbdf18f67e45b60782c5abe4accf2ddaf0c0f" integrity sha512-kULKDY2toIjgI8GlM0AEmi8wcBJxhv+b49tBJFYpgTV338gGD5cFfFl4zunOwO7+N0de8G5a5P16MVRjHp5ARg== </del> <ins> xterm-addon-webgl@0.14.0-beta.50: version "0.14.0-beta.50" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </ins> <del> xterm-headless@5.1.0-beta.82: version "5.1.0-beta.82" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.82.tgz#980348b9a2d53b307b538891fb2cb35dbfab2598" integrity sha512-h7D7IStH5LpXqL4IvGU5nE13LNHc6OrOQZm8GtJgKh2PZhHfQ2vLdDnW0SfeiIBtNvr4Hg8CX0uFYuSlBUA0GQ== </del> <ins> xterm-headless@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.87.tgz#6eb3114bbe006088ce1aab063f14ce87b93c1001" integrity sha512-/LEyLBkyAMy5r2iGur1CW0UsCGu1oEuskAccokbwOGS5Ad/uPZUDQUAuCmfSSX3gauz5TBqBPLYIRdY0u0DEJg== </ins> <del> xterm@5.1.0-beta.82: version "5.1.0-beta.82" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.82.tgz#e1e4c7db5547e0b9f8a381ed59c266269363c21e" integrity sha512-/s6ueCDOmgJpLS2P5uttQLvy9Pg9uE+R0G9rnXC2e7bxks0ljnc2V4w2PMd2Iidk4oR4F/4K/rFhCPlX+cVZ3A== </del> <ins> xterm@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </ins> y18n@^3.2.1: version "3.2.2"

Discussion:
Testing Code insiders, set how the inactive selection colour is stronger than the active selection colour I can only reproduce this with "canvas", all other gpu acceleration options work fine. Terminal focused ! Terminal not focused !
Upstream:
Change:
const fontFamily = this._generateFontFamily(); styleSheets.push(` <del> :root { --notebook-cell-output-font-size: ${fontSize}px; --notebook-cell-output-font-family: ${fontFamily}; </del> <ins> .notebook-editor { --notebook-cell-output-font-size: ${outputFontSize}px; </ins> --notebook-cell-input-preview-font-size: ${fontSize}px; --notebook-cell-input-preview-font-family: ${fontFamily}; }

Discussion:
I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:
Change:
.replace(/>/g, '&gt;') .replace(/"/g, '&quot;') .replace(/'/g, '&#39;'); <del> return `<a data-href="${href}" title="${title || href}">${text}</a>`; </del> <ins> return `<a href="" data-href="${href}" title="${title || href}">${text}</a>`; </ins> } }; renderer.paragraph = (text): string => {

Discussion:
This message right here: <img width="474" alt="image" src="https://user-"When i click on "Don't show again", it doesn't really work: as soon as i navigate to that input field again, it shows the same message again. Version: 1.66.2 Commit: User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.88 Safari/537.36 Embedder:
says this regressed with
Change:
- use the `--debug` to see an electron window with dev tools which allows for debugging - to run only a subset of tests use the `--run` or `--glob` options <ins> - use `yarn watch` to automatically compile changes </ins> For instance, `./scripts/test.sh --debug --glob **/extHost*.test.js` runs all tests from `extHost`-files and enables you to debug them.

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --
This is about
Yeah see pull request sorry. I just lumped it into something else.
Change:
<del> <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="-0.994 0 16 16" enable-background="new -0.994 0 16 16"><path fill="#424242" d="M13 6c0 1.461-.636 2.846-1.746 3.797l-5.584 4.951-1.324-1.496 5.595-4.962c.678-.582 1.061-1.413 1.061-2.29 0-1.654-1.345-3-2.997-3-.71 0-1.399.253-1.938.713l-1.521 1.287h2.448l-1.998 2h-3.996v-4l1.998-2v2.692l1.775-1.504c.899-.766 2.047-1.188 3.232-1.188 2.754 0 4.995 2.243 4.995 5z"/></svg> </del>  No newline at end of file <ins> <svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="-0.994 0 16 16" enable-background="new -0.994 0 16 16"><path fill="#424242" d="M13 6c0 1.461-.636 2.846-1.746 3.797l-5.584 4.951-1.324-1.496 5.595-4.962c.678-.582 1.061-1.413 1.061-2.29 0-1.654-1.345-3-2.997-3-.71 0-1.399.253-1.938.713l-1.521 1.287h2.448l-1.998 2h-3.996v-4l1.998-2v2.692l1.775-1.504c.899-.766 2.047-1.188 3.232-1.188 2.754 0 4.995 2.243 4.995 5z"/></svg> </ins>  No newline at end of file

Discussion:
Looks unbalanced (especially the discard again vs. the stage action): !
While this might have fixed the icon issue in the quick diff area, now I find it uneven in the changes view where icons are typically 16px: !
This is the before/after. The after does look better: !
Yeah looks good for you. Might be my zoom level of 2 then.
Change:
import * as dom from 'vs/base/browser/dom'; import { Color } from 'vs/base/common/color'; import { Event } from 'vs/base/common/event'; <del> import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle'; </del> <ins> import { DisposableStore, MutableDisposable } from 'vs/base/common/lifecycle'; </ins> import { editorBackground, foreground } from 'vs/platform/theme/common/colorRegistry'; import { getThemeTypeSelector, IThemeService } from 'vs/platform/theme/common/themeService'; import { DEFAULT_EDITOR_MIN_DIMENSIONS } from 'vs/workbench/browser/parts/editor/editor';

Discussion:
I noticed that saving parts splash occurs during startup, even though delayed: ! I am not sure we need that, maybe we can put that on the phase. The following profile: was taken on Windows with a non-minified / non-mangled build to aid reading has the event at
Moved it out a bit further but the overall timing is a lottery because it depends on the current state (destruction) of the dom and how long measuring will take
Change:
const service = new ConfigurationService(new SettingsTestEnvironmentService(parseArgs(process.argv), process.execPath, testFile)); let res = service.lookup('something.missing'); <del> assert.ok(!res.value); assert.ok(!res.default); assert.ok(!res.user); </del> <ins> assert.strictEqual(res.value, void 0); assert.strictEqual(res.default, void 0); assert.strictEqual(res.user, void 0); </ins> res = service.lookup('lookup.service.testSetting'); <del> assert.equal(res.default, 'isSet'); assert.equal(res.value, 'isSet'); assert.ok(!res.user); </del> <ins> assert.strictEqual(res.default, 'isSet'); assert.strictEqual(res.value, 'isSet'); assert.strictEqual(res.user, void 0); </ins> fs.writeFileSync(testFile, '{ "lookup.service.testSetting": "bar" }'); return service.reloadConfiguration().then(() => { res = service.lookup('lookup.service.testSetting'); <del> assert.equal(res.default, 'isSet'); assert.equal(res.user, 'bar'); assert.equal(res.value, 'bar'); </del> <ins> assert.strictEqual(res.default, 'isSet'); assert.strictEqual(res.user, 'bar'); assert.strictEqual(res.value, 'bar'); </ins> service.dispose();

Discussion:
'null' is a valid value for a setting, but turns it into 'undefined'. have the following workspace settings:set a breakpoint in '' at the value is 'undefined' should indicate that the setting has not been set in the workspace (luckily it is not a valid configuration value as we only support valid JSON data types)
Same problem with the default and user value. It's always 'undefined' instead of 'null'. The bug is in
I created a PR with a
Change:
} } <del> provideShare(item: vscode.ShareableItem, _token: vscode.CancellationToken): vscode.ProviderResult<vscode.Uri> { </del> <ins> async provideShare(item: vscode.ShareableItem, _token: vscode.CancellationToken): Promise<vscode.Uri | undefined> { </ins> const repository = getRepositoryForFile(this.gitAPI, item.resourceUri); if (!repository) { return; } <ins> await ensurePublished(repository, item.resourceUri); </ins> let repo: { owner: string; repo: string } | undefined; repository.state.remotes.find(remote => { if (remote.fetchUrl) {

Discussion:
Testing One can copy links to & github & azure repos even though I just created the file and copying such a link will result in empty or 404 on GH. Seeing links to just created file : <img width="451" alt="image" src="https://user-"
No progress on this one yet, but would you expect the actions to be hidden, or would you want to be prompted to commit the file to the remote when the command is invoked?
I think users could be confused if the actions wouldn't appear (eg they might've forgotten the file isn't pushed), so the latter sounds better. But I wonder whether checking whether the file is available on remote would be slow
Change:
import { isResponseVM } from 'vs/workbench/contrib/chat/common/chatViewModel'; import { CONTEXT_IN_CHAT_SESSION } from 'vs/workbench/contrib/chat/common/chatContextKeys'; import { ChatAccessibilityService } from 'vs/workbench/contrib/chat/browser/chatAccessibilityService'; <ins> import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; </ins> // Register configuration const configurationRegistry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration);

Discussion:
chat the whole view 1 accessibility view. Nothing happens Only if I move focus to be on one exact element the command will work. We should make the command more flexibly, so it is not so strict with regards to focus. It should also work if I am on the Chat input, or on the whole Chat view. In those cases it should probably act as if the focus was on the last item.
also mentioned this, makes sense
AFAIK, one cannot focus the chat view without focusing either the list (item) or the input. So, to verify: focus the chat input that the accessible view shows the most recent response repeat the steps but with focus on an item - it should show that item
Thanks for fixing it, it is better than before. However now the help view always has the content of the last chat. Ideally it would respect the focused chat element, if none of the chat elements are focused then we should show the content of the last one in the accessibility help editor. Reopening this to hear what you think about this proposal. Thanks
that is working for me - could you pls attach a gif of what you're seeing?
Here's what I am seeing. It looks like the accessibility help always gets the content from the editor. Here's a gif: I might be doing something wrong !
Thanks - that's a bug, but different from this issue - to test this issue, you'll want to use . I'll make a new one to cover that
Thanks! Here's the alt+f2 behaviour. It always show the last content. So it also seems to be off !
Hm, that's very strange - I cannot reproduce but will try again
I see you are focusing a request - in that case, it will just show the last response by design
ok I can repro now, thanks!
I tried with latest insiders and now I see the following: When the focus is on the last element or on the input box works as expected If the focus is anywhere else, is a no-op looks like we still have one case that we did not cover. Should we reopen? Can you repro? Thanks
Thanks for testing Where is your focus when you are seeing a ? I cannot repro unless my focus is on a request, which is expected.
You are correct, the focus is on the request.

Why is that an expected no-op? Why do we treat request and response differently?
I consulted with JooYoung about this and he agreed that since the user entered the request, they don't need to inspect it closely.
It would be great if you could verify this particular issue - happy to make a new one if you disagree about the request no-op
I have the verified label. As for request and response behaving differently, I will open a new issue.
Change:
import type * as vscode from 'vscode'; import { ExtHostConfigProvider, IExtHostConfiguration } from '../common/extHostConfiguration'; import { IExtHostCommands } from 'vs/workbench/api/common/extHostCommands'; <del> import { createHash } from 'crypto'; </del> export class ExtHostDebugService extends ExtHostDebugServiceBase {

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
@command('git.stageAll', { repository: true }) async stageAll(repository: Repository): Promise<void> { <del> const resources = repository.mergeGroup.resourceStates.filter(s => s instanceof Resource) as Resource[]; const { merge, unresolved, deletionConflicts } = await categorizeResourceByResolution(resources); try { for (const deletionConflict of deletionConflicts) { await this._stageDeletionConflict(repository, deletionConflict.resourceUri); } } catch (err) { if (/Cancelled/.test(err.message)) { return; } throw err; } if (unresolved.length > 0) { const message = unresolved.length > 1 ? localize('confirm stage files with merge conflicts', "Are you sure you want to stage {0} files with merge conflicts?", merge.length) : localize('confirm stage file with merge conflicts', "Are you sure you want to stage {0} with merge conflicts?", path.basename(merge[0].resourceUri.fsPath)); const yes = localize('yes', "Yes"); const pick = await window.showWarningMessage(message, { modal: true }, yes); </del> <ins> const resources = [...repository.workingTreeGroup.resourceStates, ...repository.untrackedGroup.resourceStates]; const uris = resources.map(r => r.resourceUri); </ins> <del> if (pick !== yes) { return; } </del> <ins> if (uris.length > 0) { const config = workspace.getConfiguration('git', Uri.file(repository.root)); const untrackedChanges = config.get<'mixed' | 'separate' | 'hidden'>('untrackedChanges'); await repository.add(uris, untrackedChanges === 'mixed' ? undefined : { update: true }); </ins> } <del> const config = workspace.getConfiguration('git', Uri.file(repository.root)); const untrackedChanges = config.get<'mixed' | 'separate' | 'hidden'>('untrackedChanges'); await repository.add([], untrackedChanges === 'mixed' ? undefined : { update: true }); </del> } private async _stageDeletionConflict(repository: Repository, uri: Uri): Promise<void> {

Discussion:
Issue Type: <bBug</bDuring a rebase (not sure if that's the only scenario), my SOURCE CONTROL tab display three sections, MERGE CHANGES, STAGED CHANGES and CHANGES. If I click the + button on the CHANGES section, in order to stage all items below CHANGES, VS Code also adds everything on MERGE CHANGES. VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-29T05:33:59.143Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ markdown-mermaid1.5.0 better-toml0.3.2 vscode-eslint2.1.5 gitlens10.2.1 plantuml2.13.8 svg1.1.8 vscode-peacock3.7.0 chat0.33.0 rust-analyzer0.2.151 vscode-todo-parser1.9.1 remote-wsl0.44.2 vsliveshare1.0.2104 vsliveshare-audio0.1.85 vsliveshare-pack0.3.4 vscode-xml0.11.0 vscode-yaml0.7.2 crates0.4.9 vscode-hexdump1.7.2 markdown-all-in-one2.8.0 </details<!-- generated by issue reporter --
Hello I would like to work on this issue if no one else is. Regards.
hey could you please review the pr that I have opened and also could you please suggest any changes if required.
Hi I'm also working on this issue. You can check my PR
I have gone through your PR also left a comment.