jiebi/CodeConvo huggingface dataset:
Change:
mds.appendMarkdown(`[$(zap)-link](#link)`); const result: HTMLElement = renderMarkdown(mds).element; <del> assert.strictEqual(result.innerHTML, `<p><a data-href="#link" href="" title="#link"><span class="codicon codicon-zap"></span>-link</a></p>`); </del> <ins> assert.strictEqual(result.innerHTML, `<p><a data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></p>`); </ins> }); test('render icon in table', () => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: macOS 12.0.1 Steps to Reproduce: a markdown and add a link on the link, drag the link rendered in hover widget to the editor https://user- It seems that markdown renderer removes property and uses instead. I'm glad if I can help but I don't know if it's by design. Can we keep both and on links?
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!
Fix actually seems pretty easy here so reopening
Change:
security import $(agent.tempdirectory)/cert.p12 -k $(agent.tempdirectory)/buildagent.keychain -P "$(macos-developer-certificate-key)" -T /usr/bin/codesign security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k pwd $(agent.tempdirectory)/buildagent.keychain codesign -s 99FM488X57 --deep --force --options runtime --entitlements build/azure-pipelines/darwin/entitlements.plist "$APP_ROOT"/*.app <ins> codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper.app" </ins> codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-gpu-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper (GPU).app" codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-plugin-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper (Plugin).app" codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-renderer-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper (Renderer).app"

Discussion:
This started only with todays build: Start it and be greeted with:
Exception seems to indicate an issue with code signing? Could this be related to the recent entitlements change? //cc
Change:
import { debounce } from 'vs/base/common/decorators'; import { MouseWheelClassifier } from 'vs/base/browser/ui/scrollbar/scrollableElement'; import { IMouseWheelEvent, StandardWheelEvent } from 'vs/base/browser/mouseEvent'; <ins> import { alert } from 'vs/base/browser/ui/aria/aria'; </ins> const enum RenderConstants { /**

Discussion:
Reported by Use or as a SR user. there's no indication that that has succeeded. We could alert with info or use an audio cue
I don't see the chat clear history action in core, so we'd need to do this in the extension. There's a clear input history, though I don't think we want to alert for that case.
Actually, found it
Change:
this._commentEditContainer!.remove(); } <del> layout() { this._commentEditor?.layout({ width: this._commentEditor.getLayoutInfo().width, height: this._editorHeight }); </del> <ins> layout(widthInPixel?: number) { const editorWidth = widthInPixel !== undefined ? widthInPixel - 72 /* - margin and scrollbar*/ : (this._commentEditor?.getLayoutInfo().width ?? 0); this._commentEditor?.layout({ width: editorWidth, height: this._editorHeight }); </ins> const scrollWidth = this._body.scrollWidth; const width = dom.getContentWidth(this._body); const scrollHeight = this._body.scrollHeight;

Discussion:
I have created a vscode extension which uses the comment thread and the comment thread width is too small after the update. This was working fine in version 1.79, here's a screenshot of the bug. <img width="1259" alt="Screenshot 2023-11-09 at 8 51 25 AM" src=""
Why are you still on 1.81 when the current release is 1.84.1?
sorry,I meant 1.84.1 I typed incorrectly.
I'm not able to reproduce this. Are there any more steps you took to arrive in this state?
create a comment thread in ur extension as shown below.
use the below code to create a comment thread in ur extension, edit the code to give dummy comments instead of reading it from a file. make sure the comment thread is Collapsed and in Edit mode.
This is the key. I can repo.
Change:
//https://github.com/microsoft/vscode/issues/93831 assertJoined('file:///c:/foo/bar', './other/foo.img', 'file:///c:/foo/bar/other/foo.img', false); }); <ins> test('vscode-uri: URI.toString() wrongly encode IPv6 literals #154048', function () { assert.strictEqual(URI.parse('http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html').toString(), 'http://[fedc:ba98:7654:3210:fedc:ba98:7654:3210]:80/index.html'); assert.strictEqual(URI.parse('http://user@[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html').toString(), 'http://user@[fedc:ba98:7654:3210:fedc:ba98:7654:3210]:80/index.html'); assert.strictEqual(URI.parse('http://us[er@[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html').toString(), 'http://us%5Ber@[fedc:ba98:7654:3210:fedc:ba98:7654:3210]:80/index.html'); }); </ins> });

Discussion:
wrongly encode IPv6 literals ( This is an issue with but if I understand correctly issues should be reported here ) can parse IPv6 literal address fine (examples are using node REPL) but will encode the : This string representation of the URI cannot be used for example by a web browser. This encoding seems to happen here <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: main ( ) OS Version: linux Steps to Reproduce: actual: expected:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Looks similar to:
Change:
import { generateUuid } from 'vs/base/common/uuid'; import { DebugStorage } from 'vs/workbench/contrib/debug/common/debugStorage'; import { DebugTelemetry } from 'vs/workbench/contrib/debug/common/debugTelemetry'; <ins> import { DebugCompoundRoot } from 'vs/workbench/contrib/debug/common/debugCompoundRoot'; </ins> export class DebugService implements IDebugService { _serviceBrand: undefined;

Discussion:
Ever since I started using the new JS debugger, when running our top level target and then manually closing the code-oss window, the and targets remain: ! Eventually, maybe 1 minute later, the goes away, but the other one stays, I always have to manually disconnect from it. ! cc
This is because is set for the shared process and extension host, which allows them to reconnect when vscode is reloaded. Eventually js-debug in extension host gives up, but the shared process is using the previous Node debugger which doesn't give up. Both these are working as designed, this is kind of a downside of the compound launch configs in that there's no "compound stop".
Yeah, would actually LOVE a compound stop. Could this be a feature of compounds, & Meaning, if something like was set in the compound, all targets would share the same action, and I would see no actions.
We could add a attribute to the compound, however how would that work? Clicking stop on any of the compound sessions would send stop to all sessions? And it would never be rendered as dicsonnect?
Maybe compound launch configs could have a pseudo-root, which has a "stop" action that affects all individual configs? ` The compound config could have an option whether sessions can be stopped individually, or whether stopping one session is treated as stopping the whole set of configuration.
ok makes somewhat sense, the flaw of my proposel is that once compound starts 4 sessions those sessions are not related in any way. So adding a pseudo root might be smart. The pseudo root would not be rendered, and the pseudo root would remember the attribute. Here are code pointers for a PR. We should add the attribute and to the schema . Code pointer for the debug session to add the pseudo root stopAll smartness
I like both options.
This bug has been fixed in to the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command pallette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Please let's have the bot not do this for ourselves.
BTW, the bot's wording sounds wrong: in to the latest...
Much better, and I this attribute to our compound config. But the behavior partly confuses me and I opened
Change:
private updateBadge(): void { if (this.filterBadge) { const { total, filtered } = this.filterController.getFilterStats(); <del> this.filterBadge.classList.toggle('hidden', total === filtered || filtered === 0); </del> <ins> this.filterBadge.classList.toggle('hidden', total === filtered || total === 0); </ins> this.filterBadge.textContent = localize('showing filtered problems', "Showing {0} of {1}", filtered, total); this.adjustInputBox(); }

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
// ------ text preformat export const textPreformatForeground = registerColor('textPreformat.foreground', <del> { light: '#A31515', dark: '#D7BA7D', hcDark: '#000000', hcLight: '#FFFFFF' }, </del> <ins> { light: '#A31515', dark: '#D7BA7D', hcDark: '#FFFFFF', hcLight: '#000000' }, </ins> nls.localize('textPreformatForeground', "Foreground color for preformatted text segments.")); export const textPreformatBackground = registerColor('textPreformat.background',

Discussion:
Type: <bBug</btheme to "Dark High Contrast" to Editor Playground Formatting several dark texts on dark background where Keyboard Shortcuts should be. : search for other places with dark text on dark background in this theme. ! VS Code version: Code 1.89.1 (, 2024-05-07T05:13:33.891Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
this._generateFontInfo(); } <del> const fontFamily = this._fontInfo?.fontFamily ?? `"SF Mono", Monaco, Menlo, Consolas, "Ubuntu Mono", "Liberation Mono", "DejaVu Sans Mono", "Courier New", monospace`; </del> <ins> const fontFamily = this._generateFontFamily(); </ins> styleSheets.push(` :root {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider (Universal) Commit: OS Version: Mac OS Monterey 12.2.1 Follow up issue to as this is a degradation in UX compared to the non-Insider version. Any input on that ? Current: ! Expected: Different columns should be aligned !
thank you for the bug report!
Change:
// If a single setting is being refreshed, it's ok to refresh now if that is not the focused setting if (key) { const focusedKey = focusedSetting.getAttribute(AbstractSettingRenderer.SETTING_KEY_ATTR); <del> /** * Update `list`s live if focused item is whole list or list item, * as they have a separate "submit edit" step built in before this */ if ( focusedKey === key && !DOM.hasClass(focusedSetting, 'setting-item-list') && !DOM.hasClass(focusedSetting, 'setting-item-contents') </del> <ins> if (focusedKey === key && // update `list`s live, as they have a separate "submit edit" step built in before this (focusedSetting.parentElement && !DOM.hasClass(focusedSetting.parentElement, 'setting-item-list')) </ins> ) { this.updateModifiedLabelForKey(key);

Discussion:
Type in an input box setting, like Font Family Wait a couple seconds Focus is lost From
I used the wrong check. is parent of : !
Verifier: Verify both this bug and are fixed.

Testing Please see the attached recording ! Notice how 'bb' is only shown after adding 'ccc'
Good catch. The "fast update" only applied when list DOM element is in focus but not when list item is in focus.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; <del> import { FoldingModel, setCollapseStateAtLevel, setCollapseStateLevelsDown, setCollapseStateLevelsUp, setCollapseStateForMatchingLines, setCollapseStateUp, setCollapseStateForRest } from 'vs/editor/contrib/folding/foldingModel'; </del> <ins> import { FoldingModel, setCollapseStateAtLevel, setCollapseStateLevelsDown, setCollapseStateLevelsUp, setCollapseStateForMatchingLines, setCollapseStateUp, setCollapseStateForRest, getJumpToParentFoldLine, getJumpToPreviousFoldLine, getJumpToNextFoldLine } from 'vs/editor/contrib/folding/foldingModel'; </ins> import { ModelDecorationOptions } from 'vs/editor/common/model/textModel'; import { createTextModel } from 'vs/editor/test/common/editorTestUtils'; import { computeRanges } from 'vs/editor/contrib/folding/indentRangeProvider';

Discussion:
It would be useful for navigating code to have a command to jump to previous/next foldable line. This would allow me to easily jump to the lines that I can either fold/unfold.
Awesome! Do I need to update my version to add this? I'm on macos Version: 1.58.2 currently and tried to my shortcuts, but didn't get it to work.
to get it you need to install Insiders.
Ahh I see the tag now, thanks.
Change:
return Promise.resolve(); } <del> const toUpdate = this.outdated.filter(e => !this.isAutoUpdateIgnored(new ExtensionIdentifierWithVersion(e.identifier, e.version))); </del> <ins> const toUpdate = this.outdated.filter(e => !this.isAutoUpdateIgnored(new ExtensionIdentifierWithVersion(e.identifier, e.version)) && (this.getAutoUpdateValue() === true || (e.local && this.extensionEnablementService.isEnabled(e.local))) ); </ins> return Promises.settled(toUpdate.map(e => this.install(e))); }

Discussion:
Today I noticed that VSCode updates and installs extensions even if they are disabled. In fact, I was reminded of a couple of extensions I no longer use by the hundreds of megabytes downloaded in the background. Could you consider adding this as a toggle in settings or disabling this behavior altogether?
I see your point. But what is the reason behind having such extension installed and disabled, instead of uninstalling it?
So that they don't update in the background and waste traffic on my metered connection ;) I switch between a lot of languages and runtimes regularly. I use VSCode for C++, C#, F#, PHP, Python, JS/Flow, Processing, GLSL/HLSL, Arduino and others, but I like to keep a "working set" of supporting extensions, depending on the project I'm working on. This comes down to the question "what does disabling extensions actually do", besides declutter the list? Initially I thought this would help with memory usage and startup time, but I don't believe that's really the case. If there's no practical use for disabling, maybe that option should be deprecated in favor of just uninstalling them.
Yes, Disabling helps you in creating a working set. But I see your point and agreed that not auto updating a disabled extension makes sense.
Know that disabled extension can also still popup a notification as well. I'm sure the C++ extension (ms-vscode.cpptools) occasionally (not sure when exactly) asks you to enter a survey even when the extension is disabled.
This should not happen. Please file a separate issue with steps to repro.
I will take a look at this one and follow up with a pull request.
I was wondering about the current status of this issue? If this issue still persists, I would love to contribute and try to resolve it. If this is the case, I would highly appreciate a code pointer to the update procedure, as I am fairly new to this project.
I have not had the chance to look into this. is this something that we still want to pursue?
It looks to me like you have already implemented the desired changes a few days ago?
This is not yet supported and contribution is very much appreciated. Code pointer: Auto update of extensions happen here
Thank you I will look into it. I would say, we just out the disabled extensions and do not return them.

Do you have something different / more elaborate in mind? And do you happen to know an easy way to test this function (i.e. forcing an auto-update)?
I was able to implement this feature and also a configuration to let users decide on whether disabled extensions should be updated. The PR can be found at .
Change:
} override runWithViewModel(viewModel: MergeEditorViewModel): void { <del> viewModel.goToPreviousModifiedBaseRange(true); </del> <ins> viewModel.goToPreviousModifiedBaseRange(r => !viewModel.model.isHandled(r).get()); </ins> } }

Discussion:
Testing Clone Use the command and select the folder Select in the quick pick It looks like the file has 4 conflict Pressing "Go to Next Conflict" highlights the first conflict Pressing "Go to Next Conflict" again does not do anything Also interesting that the editor minimap only has one conflict marker
I also saw this. It seemed to happen when both inputs make the same change.
On , once it moves past the first conflict and try to go back to it, it doesn't go back to it properly. !
This is weird, I cannot reproduce this. Also, for , I only have 2 conflicts. And this checkbox is also very weird: !
I'm on commit , not the latest commit. Does that make a difference?
If you can reproduce on the latest commit, can you try to give me a call?
yup, things look good on the latest on master for diff-merge-datasets for demo1. :) One thing I noticed, though, is that, if you're focused on the result and try to skip to next conflict, it's hard to tell by looking at the two inputs where the conflict is (seems that the two inputs aren't telling me anything in this screenshot): ! When I make the input editors a little bigger, then it starts making a little more sense. ! Not too big of a deal though, just wanted to bring your attention to it!
Change:
} stopRecordingKeys(): void { <del> this._reset(); </del> <ins> this._chords = null; </ins> this.recordDisposables.clear(); }

Discussion:
Type: <bBug</bPreviously pressing escape while "Record Keys" was active in the keybindings UI would disable key recording and leave the search query intact. Now it disables key recording and clears the search query which makes it much harder to use. I traced this regression to 1.78. I'm guessing this is an issue with keybindings. The binding for is being processed in addition to the (hard-coded?) binding to stop recording. ! VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-04T22:11:08.187Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
export const editorBracketMatchBorder = registerColor('editorBracketMatch.border', { dark: '#888', light: '#B9B9B9', hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('editorBracketMatchBorder', 'Color for matching brackets boxes')); export const editorOverviewRulerBorder = registerColor('editorOverviewRuler.border', { dark: '#7f7f7f4d', light: '#7f7f7f4d', hcDark: '#7f7f7f4d', hcLight: '#666666' }, nls.localize('editorOverviewRulerBorder', 'Color of the overview ruler border.')); <del> export const editorOverviewRulerBackground = registerColor('editorOverviewRuler.background', null, nls.localize('editorOverviewRulerBackground', 'Background color of the editor overview ruler. Only used when the minimap is enabled and placed on the right side of the editor.')); </del> <ins> export const editorOverviewRulerBackground = registerColor('editorOverviewRuler.background', null, nls.localize('editorOverviewRulerBackground', 'Background color of the editor overview ruler.')); </ins> export const editorGutter = registerColor('editorGutter.background', { dark: editorBackground, light: editorBackground, hcDark: editorBackground, hcLight: editorBackground }, nls.localize('editorGutter', 'Background color of the editor gutter. The gutter contains the glyph margins and the line numbers.'));

Discussion:
Ruler background is set to black with 50% transparency, but vscode shows solid black! ! ! Description for editorOverviewRuler.background also says: , but vscode use this background if minimap is enabled or not!
The color description is out of date. We changed the behavior of via so we now always respect . However, it never supported transparency, so we could add support for that.