jiebi/CodeConvo huggingface dataset:
Change:
this.view = contextProvider; } <del> getContext(respectMultiSelection: boolean): ExplorerItem[] { </del> <ins> getContext(respectMultiSelection: boolean, ignoreNestedChildren: boolean = false): ExplorerItem[] { </ins> if (!this.view) { return []; }

Discussion:
https://user-
This issue may be same with When run the command on file which using file nesting, passed multiple file paths.

Type: <bBug</b https://user- VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-20T05:16:19.460Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (71)</summaryExtensionVersion ------ better-comments3.0.0 extendscript-debug2.0.3 tsl-problem-matcher0.6.2 file-nesting1.0.0 color-info0.7.0 github-markdown-preview0.3.0 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.3.0 markdown-footnotes0.0.7 markdown-mermaid1.14.2 markdown-preview-github-styles1.0.1 markdown-yaml-preamble0.1.0 file-browser0.2.10 vscode-translation2.0.6 vscode-url-title-resolver1.1.1 compare-view0.7.0 vscode-opennewinstance0.0.12 gitignore0.8.0 vscode-markdownlint0.47.0 vscode-eslint2.2.6 githistory0.6.19 tsimportsorter7.4.19 css-flexbox-cheatsheet3.3.1 css-initial-value0.2.6 gitlens-insiders2022.7.2005 vscode-html-css1.13.0 prettier-vscode9.5.0 code-runner0.11.8 shell-format7.2.2 todo-tree0.0.215 vscode-nginx-conf-hint0.3.0 path-autocomplete1.19.1 vscode-env0.1.0 markdown-kbd0.4.2 svg1.4.19 vscode-gutter-preview0.30.0 template-string-converter0.6.0 hexeditor1.9.7 js-debug-nightly2022.7.1117 live-server0.2.12 test-adapter-converter0.1.6 vscode-js-profile-flame1.0.4 vscode-typescript-next4.8.

vetur0.35.0 vscode-twoslash-queries1.0.2 vscode-versionlens1.0.10 git-file-history1.0.1 text-power-tools1.34.0 vscode-xml0.21.0 vscode-yaml1.9.1 vue-vscode-snippets3.1.1 vscode-fileutils3.5.0 code-spell-checker2.3.1 vscode-stylelint1.2.2 markdowntable0.10.0 hosts1.2.0 vscode-choosealicense0.7.0 vscodeintellicode1.2.22 vscode-icons11.13.0 snippet-generator0.3.2 modify-file-warning0.0.2 open-in-external-app0.5.0 regexp-tools0.0.1 scripting-listener0.0.3 view-github-repository1.1.0 vscode-archive0.1.2 vscode-fe-helper0.2.1 ytj-snippets0.0.5 markdown-all-in-one3.4.3 node-modules1.4.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Mine reveals but it reveals the child and not the parent so definitely a bug
if you ensure that no item in the explorer view has focus, then right click the parent, nothing will happen when you reveal in explorer/finder edit: actually that isn't consistent, in some cases nothing happens and sometimes it does what you said, I do not know the exact repro
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { URI } from 'vs/base/common/uri'; </del> <ins> import { URI, UriComponents } from 'vs/base/common/uri'; </ins> import { ISandboxConfiguration } from 'vs/base/parts/sandbox/common/sandboxTypes'; import { PerformanceInfo, SystemInfo } from 'vs/platform/diagnostics/common/diagnostics'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation';

Discussion:
Testing It seems weird to pass in string when you could just pass in a Uri. Better yet, consider
I think when I was testing, URI wasn't serializable so it wouldn't be passed thru the command properly - will double check this soon though
you may need to turn it into a and then that on the other end. It's possible. We do it with other processes.
Change:
"If you want to provide a fix or improvement, please create a pull request against the original repository.", "Once accepted there, we are happy to receive an update request." ], <del> "version": "https://github.com/atom/language-coffee-script/commit/3f0b6b0e28d64cd6d5a720bf7a25c969be636e7b", </del> <ins> "version": "https://github.com/atom/language-coffee-script/commit/c0dbeede971ff5391ec1d94d4ea5d94e60d7e3e3", </ins> "scopeName": "source.coffee", "name": "CoffeeScript", "fileTypes": [

Discussion:
VSCode Version: Code 1.17.2 (, 2017-10-16T13:59:48.528Z) OS Version: Windows_NT ia32 10.0. Extensions: ExtensionVersion ------ vscode-caniuse0.5.3 Bookmarks0.17.0 project-manager0.22.0 vscode-custom-css2.5.0 markdown-preview-github-styles0.1.0 npm-intellisense1.3.0 path-intellisense1.4.2 gitignore0.5.0 vscode-eslint1.4.0 vscode-coffeescript-snippets0.0.2 gitlens5.7.1 EditorConfig0.11.1 vscode-nginx-conf-hint0.0.4 beautify1.1.1 docthis0.5.0 svgpreview0.2.0 coffeelinter1.1.0 vscode-less0.6.3 debugger-for-chrome3.4.0 live-server-preview0.0.4 material-icon-theme2.2.3 vscode-paste-and-indent0.0.8 code-settings-sync2.8.3 vscode-nginx0.4.1 stylelint0.30.0 open-in-browser1.1.0 code-navigation0.2.0 highlight-matching-tag0.4.4 JavaScriptSnippets1.5.0 markdown-all-in-one0.11.0 When a class name contains "class" in its beginning, syntax hightlighting of it is broken. For example: ! Steps to Reproduce: /create a CoffeeScript file; a class name that have "class" in its name + any parameter. This way, "class*" will appear as if were the reserved word , but it isn't. Reproduces without extensions: Yes
In VS Code we use the syntaxes from Atom. Please create an issue . I've tested, in Atom is of course the same behaviour.
This issue was moved to atom/language-coffee-script
Change:
if (typeof args.triggerSearch === 'boolean' && args.triggerSearch) { this.triggerQueryChange(); } <ins> if (typeof args.preserveCase === 'boolean') { this.searchWidget.replaceInput.setPreserveCase(args.preserveCase); } if (typeof args.excludeSettingAndIgnoreFiles === 'boolean') { this.inputPatternExcludes.setUseExcludesAndIgnoreFiles(args.excludeSettingAndIgnoreFiles); } </ins> } toggleQueryDetails(moveFocus = true, show?: boolean, skipLayout?: boolean, reverse?: boolean): void {

Discussion:
When executing search from extension api 2 checkboxes are not exposed: Preserve Case Use Exclude Settings and Ignore Files !
Hey , Can you please explain a little more about the issue?
It's possible to trigger a search from extension by using this api: And it has a good amount of options: But 2 of them are missing:
Thank got the idea. I will raise a PR to fix the issue ASAP :)
I have raised the . If you get time please review :)
genuinely didn't notice the existing PR, apologies
Thanks :). No problem
It great now that it's possible to control it but why does it called ? Would it possible to have the same name as in label:
Updated to as per suggestion and for consistency with search editor post . Also these to the keybindings intellisense registry.
Change:
threadService: threadService, modeService: modeService, pluginService: pluginService, <del> telemetryService: ExtHostTelemetryService </del> <ins> telemetryService: telemetryService </ins> }; let instantiationService = InstantiationService.create(_services); threadService.setInstantiationService(instantiationService);

Discussion:
I'm not sure if this is an issue in vscode, or typescript, or a DT package, but vscode is complaining about the "funding" field requiring 2 properties, which is incorrect (the other one is "type", and it's optional). <img width="440" alt="Screen Shot 2022-03-14 at 2 36 39 PM" src="https://user-"If this is the wrong place to file it, please point me to the right one :-) Thanks!
(happy to do the work to fix it, too, if someone can point me to where they're defined)
Most likely this is provided by SchemaStore and was just recently UPD. Documentation doesn't have any examples of objects only with field so it's unclear from docs if it's possible to omit field unless you check implementation (or do the implementation ). Maybe it make sense to have at least one object without field in npm docs?
Yes, this needs to be adopted in the SchemaStore. Marking as duplicate of
The docs are irrelevant; to document the types for something, you need to check the actual behavior. Thanks, I’ll follow it there.
Change:
} async function tryNavigateToFragmentInActiveEditor(tocProvider: MdTableOfContentsProvider, resource: vscode.Uri): Promise<boolean> { <ins> const notebookEditor = vscode.window.activeNotebookEditor; if (notebookEditor?.notebook.uri.fsPath === resource.fsPath) { if (await tryRevealLineInNotebook(tocProvider, notebookEditor, resource.fragment)) { return true; } } </ins> const activeEditor = vscode.window.activeTextEditor; if (activeEditor?.document.uri.fsPath === resource.fsPath) { if (isMarkdownFile(activeEditor.document)) {

Discussion:
Repro a notebook with the following markdown cells: still in edit mode, Try clicking on Bug Nothing happens Clicking on works since the header is within the same cell
Change:
import { CommentContextKeys } from 'vs/workbench/contrib/comments/common/commentContextKeys'; import { ILanguageConfigurationService } from 'vs/editor/common/languages/languageConfigurationRegistry'; import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> export const ctxCommentEditorFocused = new RawContextKey<boolean>('commentEditorFocused', false);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When replying to a code review comment, the reply editor unconditionally auto-closes brackets. We have had complaints from users about not affecting this behavior (when set to ). We are not 100% convinced that should apply here, since conceptually, editing comments is different from editing code, so a separate setting for comments could be more flexible, but maybe also unnecessarily complex. discusses specifying a on to control other behavior like syntax highlighting (mainly plaintext vs Markdown). Since already supports using per-language settings, it might work well enough to just make also take effect in the comment reply editor.
it seems that only applies to the main editor and not also other editors. Is this expected? I took a look and from what I can see all will respect language configurations for auto closing pairs. It's only when you try to set it something other than that it get's ignored.
I don't know much about that setting, I'd need to debug too.
do you know the answer to
To allow for most flexibility, the code editor doesn't listen to the by itself. That job is always left to the place which instantiates editors. For example, the workbench listens to the and forwards all values to the editor instaces.
Change:
import { Categories } from 'vs/platform/action/common/actionCommonCategories'; import { IExtensionRecommendationNotificationService } from 'vs/platform/extensionRecommendations/common/extensionRecommendations'; import { ExtensionRecommendationNotificationService } from 'vs/workbench/contrib/extensions/browser/extensionRecommendationNotificationService'; <del> import { IExtensionService, toExtensionDescription } from 'vs/workbench/services/extensions/common/extensions'; </del> import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { IHostService } from 'vs/workbench/services/host/browser/host'; import { ResourceContextKey, WorkbenchStateContext } from 'vs/workbench/common/contextkeys';

Discussion:
Type: <bBug</ban activated extension. Extensions view to see it. a newer VSIX of this extension onto the view. a "Restart Extension" button on the view but also a notification advising a reload of VS Code and offering a "Reload Now" button. ! VS Code version: Code 1.89.0 (, 2024-05-01T02:09:22.859Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Yes, it still happens in 1.89.1
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
<key>comment</key> <string>${var}, ${script:var}</string> <key>match</key> <del> <string>($)({)((?i:global|local|script|private|using|env|function|alias|cert|variable|hkcu|hklm|wsman):)?(.+)(})</string> </del> <ins> <string>($)({)((?i:global|local|script|private|using|env|function|alias|cert|variable|hkcu|hklm|wsman):)?(.+?)(})</string> </ins> </dict> <dict> <key>captures</key>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
FileDirnameBasename = 'fileDirnameBasename', ExecPath = 'execPath', ExecInstallFolder = 'execInstallFolder', <del> PathSeparator = 'pathSeparator' </del> <ins> PathSeparator = 'pathSeparator', PathSeparatorAlias = '/' </ins> } export class VariableError extends Error {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --. However, it is very long and explicit and thus decreases readability: I would like to request a new variable, , that would be its shorter alias that also stands out visually due to no alphanumeric characters: This is inspired by .
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.1.tgz#8a9e9356018e082318abbe2be1f9599fcc6b46a2" integrity sha512-uAErX4gwhW6N524stLG6oZR3yBGgPnFmZ2Tv4vyYy7tcgDuHRoc22xYSCDgO1ohz1FLlOm8JGXRjXliwO9ic3A== <del> xterm-addon-webgl@0.14.0-beta.8: version "0.14.0-beta.8" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.8.tgz#486ae22b2eb88a12ebded366c4019ee26409cbb8" integrity sha512-G0F70f6zGWtXuZxKiTn9BQswaVz85wcCuadnWRdPFDBlgdEfcboCvVZgQetklOIkluVpt8tYYK013/25iMRKTA== </del> <ins> xterm-addon-webgl@0.14.0-beta.16: version "0.14.0-beta.16" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.16.tgz#161d5329e8b82fb80cb333f3b957d9c1fb735b63" integrity sha512-W985IS9RTwcwaVlmw8UOxqHur7YSP+EoaYHLvxyj5Flih0tZgJdWjlXs6Om2PmT5VifB+c88AUjL5SeZTjRgqQ== </ins> <del> xterm-headless@5.1.0-beta.15: version "5.1.0-beta.15" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.15.tgz#fba76c8e95b552e922354409864c0f55d3b499f7" integrity sha512-LVtB+KkHs1R2RG8ug3IfOOU0J+qEGttfXagGxfzNq8zxxoSsgoY4D0YvLpM7M/5FK6eGK5K8/yol9XAK63ENog== </del> <ins> xterm-headless@5.1.0-beta.25: version "5.1.0-beta.25" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.25.tgz#9c9e117caa7c5fb56e4518e6ca14549c3d64d974" integrity sha512-NsEsf/tGdIuoi7Ey/jIPFbRVWgNFhlmw9PKibW8GsudfAZkbbgggLe/gCHFlOYXpa+vYNGr8cDmDqGT86mFvvw== </ins> <del> xterm@5.1.0-beta.15: version "5.1.0-beta.15" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.15.tgz#146b70c81fd286dbb003d18449918326fa355b6b" integrity sha512-fO87pEPFMr+h7eo51+6+ew3OhzLm2wwSYz6w/y5lH986rD1lgAeEqFuzjr64pjBzwAihnoaTpumYg5lTZDQpSA== </del> <ins> xterm@5.1.0-beta.25: version "5.1.0-beta.25" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.25.tgz#e926e1bbfe64deee5138dbde4e233963fe9baa9c" integrity sha512-bX1XJcFWcAvkEoDSGsJa/2hcgHFdLcF9/QnfgsRyePJniTOYuXSK3Z4JK4h+2myUyHMeXjqUehMsfzQ/hA8k9w== </ins> y18n@^3.2.1: version "3.2.2"

Discussion:
Testing using canvas render. ! Should the line be continuous even though it overlaps the characters? vs "on": ! I'm talking about characters like and .
I didn't bother adding this to the canvas renderer as it's the fallback which is primarily for iPad atm, nothing stopping it from working there too though. Should really consolidate the rendering code for webgl and canvas as they mostly do the same thing when drawing the actual characters.
The wavy underline looks off with gpu enabled (first example in the attached screenshot). With the canvas setting, it's not rendered at all. !
The look of curly was going to be revisited in
Change:
terminalSelection: { proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.terminalSelection.d.ts', }, <del> testMessageStackTrace: { proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.testMessageStackTrace.d.ts', }, </del> testObserver: { proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.testObserver.d.ts', },

Discussion:
Currently, messages that are shown when tests fail can only be shown at a single . Often (, , among others) folks want to see the full call stack of the test failure. I propose some API to add this information:
does this track that not only the stack but stack + any stdout would show in same UX? /cc
Yes, output is already trackable and associable to a test case via the API
We are using to record all stdout written by tests. In addition, the is used to record the failure message and stack for each test failure.
UI:
Just check with Joh and this looks good to move into finalized!
do we want to bundle this with any of the other testing proposals (, )?
Change:
const inserted = outputElement.firstChild as HTMLElement; assert.ok(inserted, `nothing appended to output element: ${outputElement.innerHTML}`); assert.ok(outputElement.classList.contains('remove-padding'), 'Padding should be removed for scrollable outputs'); <del> assert.ok(inserted.classList.contains('word-wrap') && inserted.classList.contains('scrollable'), </del> <ins> assert.ok(outputElement.classList.contains('word-wrap') && inserted.classList.contains('scrollable'), </ins> `output content classList should contain word-wrap and scrollable ${inserted.classList}`); assert.ok(inserted.innerHTML.indexOf('>Expected type `str`, but received type') > -1, `Content was not added to output element:n ${outputElement.innerHTML}`); assert.ok(inserted.textContent!.indexOf('Expected type `str`, but received type `<class 'int'>`') > -1, `Content was not added to output element:n ${outputElement.textContent}`);

Discussion:
[ ] Notebooks (.ipynb files) [X] Interactive Window and/or Cell Scripts (.py files with #%% markers)Turn on in Turn on in Open an interactive window and run the following code snippet Version: 1.89.0 Commit: Date: 2024-05-01T02:08:25.066Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Linux x64 6.8.0-76060800daily20240311-generic v2024.4.0 Python v3.12.1 No response No response Local
Change:
export interface IModel extends ITreeElement { getSessions(): ReadonlyArray<ISession>; <del> getBreakpoints(filter?: { uri?: uri, lineNumber?: number, column?: number }): ReadonlyArray<IBreakpoint>; </del> <ins> getBreakpoints(filter?: { uri?: uri, lineNumber?: number, column?: number, enabledOnly?: boolean }): ReadonlyArray<IBreakpoint>; </ins> areBreakpointsActivated(): boolean; getFunctionBreakpoints(): ReadonlyArray<IFunctionBreakpoint>; getExceptionBreakpoints(): ReadonlyArray<IExceptionBreakpoint>;

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: 1.14.2 OS Version: MacOS Sierra Steps to Reproduce: some breakpoints. to find shortcut to navigate between breakpoints without running the file. <!-- Launch with to check. --Reproduces without extensions: Yes
We accept PRs that fix this - especaially if more users ask for this feature request
Hi, I'm working on this. Will submit a PR soon.
Having this feature could remove the need for bookmarks, fixing
Does not work for me: set breakpoints in various files. run "Go To Next Breakpoint" action Observe: completely random behaviour. Sometimes I can only go through the breakpoints in one file, sometimes I can switch back and forth between two files. But I'm not able to step through all breakpoints in all files in deterministic order.
Dup of
Verified . Marking this as verified as well.
Change:
(emergencyAlert.platform && emergencyAlert.platform !== platform) ||	// platform mismatch (emergencyAlert.arch && emergencyAlert.arch !== arch)					// arch mismatch ) { <del> return; // skip versions we are not on </del> <ins> return; </ins> } this.bannerService.show({

Discussion:
We'd like to have a safety net if we ever break Insiders users once more to the point of them not being able to update.
Implementation is done. Requires
Change:
} } <ins> if (this._attachedContext.size === 0) { this.focus(); } </ins> this._onDidChangeHeight.fire(); this._onDidChangeContext.fire({ removed: [attachment] }); });

Discussion:
Testing an image to the "remove" button enter the focus is kind of hidden. Hitting tab brings me to the footer actions. I would instead expect focus is moved back to the input box when the last attachment is removed
This applies to quick chat as well
Change:
private _dropdownActions: IAction[] = []; get dropdownActions(): IAction[] { return this._dropdownActions; } <ins> private readonly _ctxActionCount: IContextKey<number>; </ins> constructor( container: HTMLElement, menuId: MenuId,

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!