jiebi/CodeConvo huggingface dataset:
Change:
this.textArea.setAttribute('aria-label', this._getAriaLabel(options)); this.textArea.setAttribute('tabindex', String(options.get(EditorOption.tabIndex))); <del> if (platform.isWeb && e.hasChanged(EditorOption.readOnly)) { if (options.get(EditorOption.readOnly)) { </del> <ins> if (e.hasChanged(EditorOption.domReadOnly)) { if (options.get(EditorOption.domReadOnly)) { </ins> this.textArea.setAttribute('readonly', 'true'); } else { this.textArea.removeAttribute('readonly');

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: Steps to Reproduce: a browser version vscode a editor with readonly mode extension who use the API would be invalid This issue won't be occured on desktop version. Follow code show more details: the attribute is used to disable keyboard popping in mobile devices, but it break the event too. Change the to may be better <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Can you please give an example of how behaves differently? I am not 100% convinced that there is a bug here. I would expect that is never called, not in desktop and also not in web.
There is a way that are relatively easy to reproduce this bug, when someone use GitHub CodeSpaces (because the bug only occured in browser version): the extension and the Extension. (the extension require the API for basic cursor motion, and the GitLens extension will provide can readonly mode editor) any file which has at least two commit, click in the editor menu title. ! we will get a readonly editor, but extension can not move cursor by pressing key here. The readonly attribute was in this commit: As the message describe, it used to disable keyboard popping up on mobile devices, and there is no condition at the earliest time. and then add the condition at this commit by you , I guess that's the readonly attribute cause some bug at desktop version at that time? Another thing, I think when we need consider the mobile devices, I think change the to may be better, but there is not a option named in , so I just change it to at .
To verify, install vim in the browser and use it in a readonly editor (e.g. left side of a diff editor).
Change:
}); } <ins> // send ctrl+c to the iPad when the terminal is focused and ctrl+c is pressed to kill the process if (isIPad) { registerSendSequenceKeybinding(String.fromCharCode('C'.charCodeAt(0) - CTRL_LETTER_OFFSET), { // ctrl+c when: ContextKeyExpr.and(KEYBINDING_CONTEXT_TERMINAL_FOCUS, KEYBINDING_CONTEXT_IPAD), primary: KeyMod.CtrlCmd | KeyCode.KEY_C }); } </ins> // Delete word left: ctrl+w registerSendSequenceKeybinding(String.fromCharCode('W'.charCodeAt(0) - CTRL_LETTER_OFFSET), { primary: KeyMod.CtrlCmd | KeyCode.Backspace,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --Hitting + with the terminal focused and a process running (i.e. in a React app) does not kill the process. If someone is able to provide a good starting point, I would be willing to take a stab at this. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.53.0-insider OS Version: iPadOS 14.1 (18A8395) Commit: Date: 2021-01-07T05:25:51.740Z (16 hrs ago) Browser: Mozilla/5.0 (iPad; CPU OS 14_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/87.0.4280.77 Mobile/15E148 Safari/604.1 iPad, open Codespaces environment in Chrome integrated Terminal application (i.e. like a create-react-app - ) terminal and hit + Process () should stop running Terminal receives new line https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Related:
Perhaps that is not the right sigint.
One other piece of insight: this may not be limited to VSCode. has a product which includes a terminal in the browser. I’m able to reproduce the same issue (see line breaks at the bottom). !
As a temporary workaround, it works if you manually define the shortcut like so: Command Palette for "Preferences: Open Keyboard Shortcuts (JSON)" this: Source:
I found the root reason was iPad Safari report keyCode of ctrl-c as 13, which is not correct, reference from MDN, keyCode is a deprecated property; The key and code property is right, so I suggest just use key property, not keyCode, on the whole html page not just terminal.
I'm still seeing this in codespace, am I testing the right environment?
fixed w
as another workaround, use shortcut instead of , it will interrupt the process as well
Change:
import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { ITextModel } from 'vs/editor/common/model'; import * as nls from 'vs/nls'; <del> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; </del> <ins> import { IConfirmationResult, IDialogService } from 'vs/platform/dialogs/common/dialogs'; </ins> const ignoreUnusualLineTerminators = 'ignoreUnusualLineTerminators';

Discussion:
Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
could you post some steps to verify?
I could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.
Verified by code review
unfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D
Change:
} this.debuggerInterestedContext.set(false); }; <del> this._register(editorService.onDidActiveEditorChange(setContextKey)); </del> <ins> const disposables = new DisposableStore(); this._register(disposables); this._register(editorService.onDidActiveEditorChange(() => { disposables.clear(); const editorControl = this.editorService.activeTextEditorControl; if (isCodeEditor(editorControl)) { disposables.add(editorControl.onDidChangeModelLanguage(setContextKey)); } setContextKey(); })); </ins> this._register(this.debugService.getConfigurationManager().onDidRegisterDebugger(setContextKey)); this._register(this.onDidChangeBodyVisibility(visible => { if (visible) {

Discussion:
the debug view and a .js file the window that the debug view doesn't seem to recognize a file is open to another file and back again fixes it
I can not reproduce this with latest VS Code out of source. I can reproduce in vscode insiders. Thus it seems like I fixed the issue. Let me know if you can repro out of source and I will reopen. Potentially a candidate. Let me know if you think it is and I can search for the exact fix and port it to the release branch if we do a recovery release.
I don't think this is candidate worthy. Thanks for looking into it!
I can actually still reproduce this, though it seems racey. Create a brand new folder Create some in it, and open it. Open the debug view Reload the window Run and Debug button is greyed out
Pushed a potential fix. Can not really verify if it fixes since can not repro out of source.
This still repro's. I'll move this to next month and debug on my machine since it doesn't repro for you.
thanks for moving it. No need to debug on your machine since now I can reproduce it. But I can only reproduce it in the built version which makes debugging it a bit harder.
I got a fix for this though I couldn't actually verify it since I cannot repro out of source but it does happen in stable and insiders. I'll create a PR so you can try it out.
As mentioned in the PR I fully built VS Code from your changes and the issue is fixed. Great fix and thanks for help
Change:
import { Extensions as ViewContainerExtensions, IViewContainersRegistry, ViewContainerLocation, IViewsRegistry } from 'vs/workbench/common/views'; import { registerTerminalActions, terminalSendSequenceCommand } from 'vs/workbench/contrib/terminal/browser/terminalActions'; import { TerminalViewPane } from 'vs/workbench/contrib/terminal/browser/terminalView'; <del> import { KEYBINDING_CONTEXT_TERMINAL_SHELL_TYPE_KEY, KEYBINDING_CONTEXT_TERMINAL_FOCUS, TERMINAL_VIEW_ID, TERMINAL_COMMAND_ID } from 'vs/workbench/contrib/terminal/common/terminal'; </del> <ins> import { KEYBINDING_CONTEXT_TERMINAL_SHELL_TYPE_KEY, KEYBINDING_CONTEXT_TERMINAL_FOCUS, TERMINAL_VIEW_ID, TERMINAL_COMMAND_ID, KEYBINDING_CONTEXT_IPAD } from 'vs/workbench/contrib/terminal/common/terminal'; </ins> import { registerColors } from 'vs/workbench/contrib/terminal/common/terminalColorRegistry'; import { setupTerminalCommands } from 'vs/workbench/contrib/terminal/browser/terminalCommands'; import { setupTerminalMenu } from 'vs/workbench/contrib/terminal/common/terminalMenu';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --Hitting + with the terminal focused and a process running (i.e. in a React app) does not kill the process. If someone is able to provide a good starting point, I would be willing to take a stab at this. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.53.0-insider OS Version: iPadOS 14.1 (18A8395) Commit: Date: 2021-01-07T05:25:51.740Z (16 hrs ago) Browser: Mozilla/5.0 (iPad; CPU OS 14_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/87.0.4280.77 Mobile/15E148 Safari/604.1 iPad, open Codespaces environment in Chrome integrated Terminal application (i.e. like a create-react-app - ) terminal and hit + Process () should stop running Terminal receives new line https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Related:
Perhaps that is not the right sigint.
One other piece of insight: this may not be limited to VSCode. has a product which includes a terminal in the browser. I’m able to reproduce the same issue (see line breaks at the bottom). !
As a temporary workaround, it works if you manually define the shortcut like so: Command Palette for "Preferences: Open Keyboard Shortcuts (JSON)" this: Source:
I found the root reason was iPad Safari report keyCode of ctrl-c as 13, which is not correct, reference from MDN, keyCode is a deprecated property; The key and code property is right, so I suggest just use key property, not keyCode, on the whole html page not just terminal.
I'm still seeing this in codespace, am I testing the right environment?
fixed w
as another workaround, use shortcut instead of , it will interrupt the process as well
Change:
return this.dnd.onDragOver(data, targetElement, targetIndex, originalEvent); } <ins> onDragLeave(data: IDragAndDropData, targetElement: T, targetIndex: number, originalEvent: DragEvent): void { this.dnd.onDragLeave?.(data, targetElement, targetIndex, originalEvent); } </ins> onDragEnd(originalEvent: DragEvent): void { if (this.dnd.onDragEnd) { this.dnd.onDragEnd(originalEvent);

Discussion:
Repro: 2 terminals dragging one it into the actual terminal and pass over the other tab briefly, it will get focused even though the mouse didn't stay there for long enough !
Change:
if (readmes.length) { const isMarkDown = (readme: URI) => readme.path.toLowerCase().endsWith('.md'); await Promise.all([ <del> this.commandService.executeCommand('markdown.showPreview', null, readmes.filter(isMarkDown), { locked: true }), </del> <ins> this.commandService.executeCommand('markdown.showPreview', null, readmes.filter(isMarkDown), { locked: true }).catch(error => { this.notificationService.error(localize('startupPage.markdownPreviewError', 'Could not open markdown preview: {0}.nnPlease make sure the markdown extension is enabled.', error.message)); }), </ins> this.editorService.openEditors(readmes.filter(readme => !isMarkDown(readme)).map(readme => ({ resource: readme }))), ]); }

Discussion:
/ This is likely caused by testing/startup page code triggering this command on machines that have disabled the built-in markdown extension
Change:
super.updateStyles(); // WCO styles only supported on Windows currently <del> if (useWindowControlsOverlay(this.configurationService, this.environmentService)) { </del> <ins> if (useWindowControlsOverlay(this.configurationService)) { </ins> if (!this.cachedWindowControlStyles || this.cachedWindowControlStyles.bgColor !== this.element.style.backgroundColor || this.cachedWindowControlStyles.fgColor !== this.element.style.color) {

Discussion:
I tried enabling it in my Code-OSS settings but it didn't seem to work. The sentence from that I quoted make me think it had been hardwired off in Code-OSS. I haven't searched the codebase yet though. Originally posted by in
OSS does seem to have the WCO disabled. says that WCO was disabled in OSS due to upstream issues, but there's been a bunch of fixes recently, so it's probably OK to enable it again.
Verification steps: the WCO in OSS by enabling the setting. VS Code when prompted and change the colour theme. Windows 11, one can verify the WCO has been enabled by checking that the snap layout UX is available. On Windows 10, one can verify the WCO has been enabled by switching through colour themes and checking that the area with the minimize/maximize/close buttons updates its colours before the rest of the titlebar does.
Change:
} } <del> export function openBreakpointSource(breakpoint: Breakpoint, sideBySide: boolean, preserveFocus: boolean, debugService: IDebugService, editorService: IEditorService): TPromise<IEditor> { </del> <ins> export function openBreakpointSource(breakpoint: IBreakpoint, sideBySide: boolean, preserveFocus: boolean, debugService: IDebugService, editorService: IEditorService): TPromise<IEditor> { </ins> if (breakpoint.uri.scheme === DEBUG_SCHEME && debugService.state === State.Inactive) { return TPromise.as(null); }

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: 1.14.2 OS Version: MacOS Sierra Steps to Reproduce: some breakpoints. to find shortcut to navigate between breakpoints without running the file. <!-- Launch with to check. --Reproduces without extensions: Yes
We accept PRs that fix this - especaially if more users ask for this feature request
Hi, I'm working on this. Will submit a PR soon.
Having this feature could remove the need for bookmarks, fixing
Does not work for me: set breakpoints in various files. run "Go To Next Breakpoint" action Observe: completely random behaviour. Sometimes I can only go through the breakpoints in one file, sometimes I can switch back and forth between two files. But I'm not able to step through all breakpoints in all files in deterministic order.
Dup of
Verified . Marking this as verified as well.
Change:
compressionEnabled: true, horizontalScrolling: false, autoExpandSingleChildren: true, <ins> multipleSelectionSupport: false, </ins> collapseByDefault: (e) => !ResourceTree.isResourceNode(e), accessibilityProvider: this.instantiationService.createInstance(SCMSyncViewPaneAccessibilityProvider), identityProvider: this.instantiationService.createInstance(SCMSyncViewPaneTreeIdentityProvider),

Discussion:
Testing It seems like multiple selection is enabled in this list/tree, though without any value. Let's disable it for now.
Change:
export const CTX_INLINE_CHAT_CHANGE_HAS_DIFF = new RawContextKey<boolean>('inlineChatChangeHasDiff', false, localize('inlineChatChangeHasDiff', "Whether the current change supports showing a diff")); export const CTX_INLINE_CHAT_CHANGE_SHOWS_DIFF = new RawContextKey<boolean>('inlineChatChangeShowsDiff', false, localize('inlineChatChangeShowsDiff', "Whether the current change showing a diff")); export const CTX_INLINE_CHAT_EDIT_MODE = new RawContextKey<EditMode>('config.inlineChat.mode', EditMode.Live); <del> export const CTX_INLINE_CHAT_TOOLBAR_ICON_ENABLED = new RawContextKey<boolean>('inlineChatToolbarIconEnabled', false, localize('inlineChatToolbarIconEnabled', "Whether the toolbar icon spawning inline chat is enabled.")); </del> <ins> export const CTX_INLINE_CHAT_TOOLBAR_ICON_ENABLED = new RawContextKey<boolean>('config.inlineChat.showToolbarIcon', false); </ins> // --- (select) action identifier

Discussion:
We have as explicit context key which is driven with the . This is all fine but actually not needed. Any configuration is automatically a context key when prefixed with - , the setting is and you can use as context key
That's useful, thank you I didn't know
Change:
"id": "gitDecoration.untrackedResourceForeground", "description": "%colors.untracked%", "defaults": { <del> "light": "#018101", </del> <ins> "light": "#007100", </ins> "dark": "#73C991", "highContrast": "#73C991" }

Discussion:
This appears in the list, outline, breadcrumb, quick pick, and suggest widget. We could update this color to use which is what uses. !
Other places that this needs to work in: !
Change:
"activityBarBadge.background": "#3655b5", "sideBar.background": "#272727", "sideBarSectionHeader.background": "#505050", <ins> "menu.background": "#272727", "menu.foreground": "#CCCCCC", </ins> "pickerGroup.foreground": "#b0b0b0", "terminal.ansiWhite": "#ffffff", "inputOption.activeBorder": "#3655b5",

Discussion:
Issue Type: <bBug</bI think this change appeared in VS Code Insiders couple builds ago. New background for dropdowns in title menu bar and context menus ( is set to ) now have brighter background, which has to much contrast with editor background and makes it harder to read text on it. Also it appears much brighter than backgrounds for auto-suggestions dropdown and peek view. Is it intended change in Dark+ color theme or is it possible to revert it back to the same color as in current stable version (1.27)? Insider (left) and stable (right) ! VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-19T09:34:25.276Z) OS version: Windows_NT x64 10.0. Issue is reproducible without extensions. <details<summaryExtensions (26)</summaryExtensionVersion ------ markdown-toc1.5.6 vscode-css-modules1.0.1 spellright2.5.32 markdown-preview-github-styles0.1.3 vscode-css-modules0.2.3 bracket-pair-colorizer1.0.60 vscode-eslint1.6.0 gitlens8.5.6 remotehub0.2.0 EditorConfig0.12.4 tslint1.0.39 vscode-pull-request-github0.1.5 beautify1.4.3 rest-client0.19.1 code-fragments1.2.0 vsliveshare0.3.709 debugger-for-chrome4.10.1 debugger-for-edge1.0.5 vscode-docker0.2.0 material-icon-theme3.6.0 quicktype12.0.42 gi0.2.11 code-settings-sync3.1.2 dot0.0.1 quokka-vscode1.0.149 markdown-pdf1.2.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.459 --<!-- potentialduplicatescomment --
Change:
this.restoreListViewState(viewState); } <ins> this._restoreSelectedKernel(viewState); </ins> // load preloads for matching kernel this._loadKernelPreloads();

Discussion:
Testing microsoft/vscode-jupyter untitled ipynb cells export commands are available in command palette the untitled notebook as ipynb and give it a title command palette :bug: all the export commands are now hidden
I think this is because technically the cells were run in the context of the previous notebook, so I now need to run them again after saving the notebook, which is a rather nasty limitation...
I think this is because after saving we don't have a kernel connected to the newly saved notebook. There is no kernel session transfer (from untitled to saved notebook) currently.
Save As is handled by core. Need to transfer current controller to new ipynb.
Seems related to
Not sure - we are handling this the same way we persist selection and other view state. But the editor still gets reopened with a new model. Dunno how this concept works in custom editors.
Custom editors have one the untitled editor closed and a new one with another URI open, I want a signal that a custom editor can handle to upgrade it so no close/open needs to happen
Steps: Open an untitled jupyter notebook Select a kernel Save the notebook The same kernel should be selected The "Set kernel as default" gear icon in the kernel picker was also removed.
Verified with this "kernel"
Change:
padding-left: 20px; white-space: nowrap; } <ins> .monaco-scrollable-element .scrollbar > .slider { background: #64646457 !important; } .monaco-scrollable-element .scrollbar > .slider:hover { background: highlight !important; } .monaco-scrollable-element .scrollbar > .slider.active { background: highlight !important; } </ins>

Discussion:
! The process explorer has both the window scrolling and list view scrolling. When window resizes, the list/tree view is not laid out properly and it's then impossible to view some rows.
Should be fixed now.
This was part of
Change:
] }] } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
It looks like Code is using 0.52.0 of to generate its Sass syntax — 0.62.0 was released today. It would be great to have the new fixes & features included. I'm happy to submit a PR with the re-generated syntax.
Thanks for the update! Just a heads-up though, the updated SCSS syntax references a separate file for SassDoc comment blocks. I updated the build script to account for the extra file in my PR:
Change:
"type": "boolean", "default": false, "description": "%emmetPreferencesOutputReverseAttributes%" <ins> }, "css.color.short": { "type": "boolean", "default": true, "description": "%emmetPreferencesCssColorShort%" </ins> } } },

Discussion:
"emmet.preferences": { "": true } Why not working?
Does the new modular emmet support this feature?
yes, it should be passed as option:
Looks like it is enabled by default. Since VS Code doesnt change that particular property, we will need to debug why this doesnt work.
I'm having the same problem, using the latest VS Code version: 1.35.0. After adding the setting as mentioned above, Emmet in VS Code still expands to instead of . Hope this could get some love, because small color values are just way more sexy!
I updated the Emmet dependency, and now is enabled by default in the latest Insiders. I still have to add the setting to VS Code if one wants to disable it for whatever reason, so I'll leave this issue open.