jiebi/CodeConvo huggingface dataset:
Change:
constructor() { super({ id: 'merge.goToPreviousConflict', <del> title: localize('merge.goToPreviousConflict', "Merge Editor: Go to Previous Conflict"), </del> <ins> category: localize('mergeEditor', "Merge Editor"), title: localize('merge.goToPreviousConflict', "Go to Previous Conflict"), </ins> icon: Codicon.arrowUp, menu: [{ id: MenuId.EditorTitle,

Discussion:
While working on I noticed that some of the UI elements (and maybe other things?) are not registered as disposable, and thus may leak when the merge editor is freed from an editor group that closes. For example the and all input views seem to not dispose.
Hm, I think also the merge model, I suggest to do a pass and register as appropiate.
Change:
if (!fakeProviders.has(agent.id)) { fakeProviders.set(agent.id, _inlineChatService.addProvider(_instaService.createInstance(AgentInlineChatProvider, agent))); <del> this._logService.info(`ADDED inline chat provider for agent ${agent.id}`); </del> <ins> this._logService.debug(`ADDED inline chat provider for agent ${agent.id}`); </ins> } } for (const [id] of fakeProviders) { if (!providersNow.has(id)) { fakeProviders.deleteAndDispose(id); <del> this._logService.info(`REMOVED inline chat provider for agent ${id}`); </del> <ins> this._logService.debug(`REMOVED inline chat provider for agent ${id}`); </ins> } } }));

Discussion:
Can these not be trace: <img width="1046" alt="image" src=""
Change:
"button.secondaryForeground": "#3b3b3b", "button.secondaryHoverBackground": "#00000034", "checkbox.background": "#f8f8f8", <del> "checkbox.border": "#0000001a", </del> <ins> "checkbox.border": "#CECECE", </ins> "descriptionForeground": "#3b3b3b", "diffEditor.insertedLineBackground": "#23863633", "diffEditor.insertedTextBackground": "#2386364d", "diffEditor.removedLineBackground": "#da363333", "diffEditor.removedTextBackground": "#da36334d", "dropdown.background": "#ffffff", <del> "dropdown.border": "#0000001a", </del> <ins> "dropdown.border": "#CECECE", </ins> "dropdown.foreground": "#3b3b3b", "dropdown.listBackground": "#ffffff", "editor.background": "#ffffff",

Discussion:
Ref Unchecked and unfocused checkboxes in the Settings editor currently do not have much contrast between the checkbox background colour and the checkbox border colour for both Light+ v2 and Dark+ v2 themes. !
Change:
limited: number | false; } <del> export type FoldingRangeProviderSelector = (formatter: FoldingRangeProvider[], document: ITextModel) => FoldingRangeProvider[] | undefined; </del> <ins> export type FoldingRangeProviderSelector = (provider: FoldingRangeProvider[], document: ITextModel) => FoldingRangeProvider[] | undefined; </ins> export class FoldingController extends Disposable implements IEditorContribution {

Discussion:
a folding range provider that conditionally contributes ranges or undefined and ensure no other is contributing any ranges. a file for which the custom will return undefined so that the default folding regions are shown. another file for which the custom does return ranges. -open the first file :bug: folding regions are not shown !
Change:
font-size: 11px; padding: 0 6px; display: flex; <del> height: 27.5px; </del> <ins> height: 25px; </ins> align-items: center; }

Discussion:
Device pixel ratio = 1, zoom level = 0 ! Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-19T05:17:14.894Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes
Can I work for this
go for it
hi , this problem seems to be due to the fact that the button is set to 27.5 height, but the search input is 25 height, I also found in another function that the button will be a little bit down because of the height. <img width="642" alt="image" src="https://user-"<img width="367" alt="image" src="https://user-"But according to the screenshot of , the difference is not as big as between 25 and 27.5, I didn't find the exact value of the input control to set the height, maybe it is set dynamically? And I found a place where the height of the input might be updated, so I feel like I need to refresh the height of the button here too
The decimal height seems suspicious. The pixels in my screenshot are actually 28, so the 27.5 is getting rounded up.
Introduced here: I think we can start with the tactical fix of just lowering that height to 26 or 27... whatever looks correct. I don't expect the input of the quick pick to change at all especially since it doesn't support multi-line. wanna give it a go?

I experimented with the result that setting it to 25 is appropriate, omewhat surprisingly, I initially also feel that maybe 26, 27 is about the same This is with a setting of 26: <img width="610" alt="image" src="https://user-"The height of the input box is 26, but the height of the button, if set to 26, will look slightly more <img width="524" alt="image" src="https://user-"This is with a setting of 25: <img width="630" alt="image" src="https://user-"From the code, it should be 26, but I don't know why 25 works best, and the input box has no border, some strange
Change:
}), result => !!result && arrays.isNonEmptyArray(result?.ranges)); } <ins> export const editorOnTypeRenameBackground = registerColor('editor.onTypeRenameBackground', { dark: Color.fromHex('#f00').transparent(0.3), light: Color.fromHex('#f00').transparent(0.3), hc: Color.fromHex('#f00').transparent(0.3) }, nls.localize('editorOnTypeRenameBackground', 'Background color when the editor auto renames on type.')); registerThemingParticipant((theme, collector) => { const editorOnTypeRenameBackgroundColor = theme.getColor(editorOnTypeRenameBackground); if (editorOnTypeRenameBackgroundColor) { collector.addRule(`.monaco-editor .on-type-rename-decoration { background: ${editorOnTypeRenameBackgroundColor}; border-left-color: ${editorOnTypeRenameBackgroundColor}; }`); } }); </ins> registerModelAndPositionCommand('_executeRenameOnTypeProvider', (model, position) => getOnTypeRenameRanges(model, position, CancellationToken.None));

Discussion:
! Most likely an oversight, we should create a color token for this so that it's themeable. Found .
Change:
keybinding: { weight: KeybindingWeight.WorkbenchContrib, primary: KeyMod.CtrlCmd | KeyCode.Escape, <ins> win: { primary: KeyMod.Alt | KeyCode.Backspace }, </ins> } }); }

Discussion:
Testing text buttons some code and ask "What does this do?" starts, and the "ctrl+esc to stop" button shows. . actually opens the Windows start menu and streaming continues. It seems like this is a default Windows shortcut.
This is the default keybinding (the one we use in all chat boxes) and it looks like we need something else on windows...
They have a whole keyboard button for that, why are they taking ctrl+esc too...
Going with alt+backspace. Would like ctrl+backspace, but you might start typing while the previous request is running, and still want to use ctrl+backspace to delete a word.
Works great!
Change:
* @param pattern A file glob pattern like `*.{ts,js}` that will be matched on file paths * relative to the base path. */ <del> constructor(base: WorkspaceFolder | string, pattern: string) </del> <ins> constructor(base: Uri | WorkspaceFolder | string, pattern: string) </ins> } /**

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --This would prevent needing to convert the to a string only for it to be parsed back into a later on, and is friendlier to developers.
proposed or finalized?
Change:
this.actions = options.actions || []; this.actionProvider = options.actionProvider; this.menuClassName = options.menuClassName || ''; <ins> this.menuAsChild = !!options.menuAsChild; </ins> } set menuOptions(options: IMenuOptions | undefined) {

Discussion:
!
Reproduces in an insiders build from 3 days ago. Maybe related to context view changes?
closedWith
Change:
assert.strictEqual(count, 0); }); <ins> test('correct cell selection on undo/redo of cell creation', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest'); await vscode.commands.executeCommand('notebook.cell.insertCodeCellBelow'); await vscode.commands.executeCommand('undo'); const selectionUndo = [...vscode.window.activeNotebookEditor!.selections]; await vscode.commands.executeCommand('redo'); const selectionRedo = vscode.window.activeNotebookEditor!.selections; // On undo, the selected cell must be the upper cell, ie the first one assert.strictEqual(selectionUndo.length, 1); assert.strictEqual(selectionUndo[0].start, 0); assert.strictEqual(selectionUndo[0].end, 1); // On redo, the selected cell must be the new cell, ie the second one assert.strictEqual(selectionRedo.length, 1); assert.strictEqual(selectionRedo[0].start, 1); assert.strictEqual(selectionRedo[0].end, 2); }); </ins> test('editor editing event 2', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.
Change:
} } <del> const newWindowProfile = (options?.forceProfile </del> <ins> const newWindowProfile = options?.forceProfile </ins> ? this.userDataProfilesService.profiles.find(profile => profile.name === options?.forceProfile) <del> : undefined) ?? this.userDataProfileService.currentProfile; if (!newWindowProfile.isDefault) { </del> <ins> : undefined; if (newWindowProfile && !newWindowProfile.isDefault) { </ins> newPayload.push(['profile', newWindowProfile.name]); }

Discussion:
When using vscode through a , if I switch profiles and then open an existing project (ctrl+r, left click), the url then updates with some url parameters (). The window loaded with that payload doesn't work correctly. For example, code search only works on the already opened files, and not the entire folder. A workaround is to remove the payload from the url. Version: 1.93.1 Commit: User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36 Embedder: <!-- generated by web issue reporter --
Change:
private readonly stickyEditorTabsControl: IEditorTabsControl; private readonly unstickyEditorTabsControl: IEditorTabsControl; <ins> private activeControl: IEditorTabsControl | undefined; </ins> constructor( private readonly parent: HTMLElement, editorPartsView: IEditorPartsView,

Discussion:
Type: <bBug</bfile A from EXPLORER tab with file A file B from EXPLORER -breadcrumb shows file B path (correct) on the pinned tab with file A -breadcrumb shows file B path but should file A This is the minimal case. When I have multiple pinned tabs and open other files, the breadcrump gets more random. UPDATE: Looks like the bug only comes out if this setting is set to true: VS Code version: Code 1.92.2 (, 2024-08-14T17:29:30.058Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ macos-modern-theme2.3.19 better-cpp-syntax1.27.1 remote-containers0.380.0 remote-ssh0.113.1 remote-ssh-edit0.86.0 remote-wsl0.88.2 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.2 vscode-clangd0.1.29 regionfolder1.0.22 cmake-tools1.18.44 cpptools1.21.6 workspace-include-what-you-use0.0.3 cmake0.0.17 (4 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This doesn't reproduce for me. Please try without extensions enabled and without custom settings
I turned off extensions and custom settings. I nailed it down to this setting in It appears that the bug is reproducible only if is true.
can you help here? It seems that pinned, extra-row items don't make the call to the breadcrumbs controls, like how it is done for instance for the
Thanks for steps. could you take a look?
Thanks for reporting. When switching to the last previous active tab of the other tab bar it wasn't updating the breadcrumbs. Made a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Still doesn't work correctly on current insiders version. Version: 1.93.0-insider (user setup) Commit: Date: 2024-08-23T06:45:56.108Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.
Change:
} async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext | INotebookCellToolbarActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> if (context.ui) { await context.notebookEditor.focusNotebookCell(context.cell, 'container', { skipReveal: true }); } <del> return runCell(accessor, context); </del> <ins> return runCell(editorGroupsService, context); </ins> } });

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem
Change:
})); const disposeListeners = [ <del> instance.onExit(() => this.dispose()), </del> <ins> instance.onExit((e) => { if (!instance.waitOnExit) { this.dispose(); } }), </ins> instance.onDisposed(() => this.dispose()), instance.onTitleChanged(() => this._onDidChangeLabel.fire()), instance.onIconChanged(() => this._onDidChangeLabel.fire()),

Discussion:
. a folder and add this task: that task The task runs, but there is an error that shows in a notification:
shouldn't be getting used in the stack trace
when I set default location to editor and run the build task, terminals are appearing in the panel. is that by design ?
Currently that is by design as tasks + terminals in the editor don't work.
that might just be a matter of removing location here?
I the location to work around the issue:
is here when the terminal is in the editor, so we must be listening to somewhere in terminal editor code and disposing of the terminal !
yep, here
active instance does get updated for me, but could repro an issue where wasn't respected - fix for that incoming https://user-
Change:
let lexerMin: monarchCommon.ILexerMin = <any>json; lexerMin.languageId = languageId; lexerMin.ignoreCase = lexer.ignoreCase; <ins> lexerMin.unicode = lexer.unicode; </ins> lexerMin.noThrow = lexer.noThrow; lexerMin.usesEmbedded = lexer.usesEmbedded; lexerMin.stateNames = json.tokenizer;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Feature request for the Monaco Editor. Create an optional flag for Monaco Monarch language definitions to indicate the usage of unicode-aware regular expressions. An example of one such regular expression is , matching the '' character.
What exactly does not work? Since you can pass in regular expressions directly e.g.
Hi, What's currently not working is the unicode-aware regular expressions supported by ES2015. Even though you're able to write a RegExp including unicode-aware characters (in the format ), and even set the unicode flag for that RegExp, they don't work in Monaco Monarch at the moment. Below is the monaco-language file for ABAP, edited to support the character in identifiers. ! This is how it shows up in the editor: ! That happens precisely because the unicode flag is stripped away by compileRegExp, causing the match to fail for that character: If we change that line to, say it works as expected: ! The proposed solution is a way for the developer to tell Monaco Monarch that, instead of stripping away the unicode flag from all the regular expressions, it should instead add it to all the regular expressions if a flag is set in the language definition, just like it's the current behavior for the option. Another option I've considered was to instead use the unicode flag if, and only if, it is set in the regular expression itself, but from what I could gather, that would force us to compile the RegExp an extra time just for testing the flag, or to parse the RegExp manually. Let me know if you need more information.
:+1: Thank you, this makes good sense!
Change:
message = localize('confirm delete', "Are you sure you want to DELETE {0}?", path.basename(scmResources[0].resourceUri.fsPath)); yes = localize('delete file', "Delete file"); } else { <del> message = localize('confirm discard', "Are you sure you want to discard changes in {0}?", path.basename(scmResources[0].resourceUri.fsPath)); </del> <ins> if (scmResources[0].type === Status.DELETED) { yes = localize('restore file', "Restore file"); message = localize('confirm restore', "Are you sure you want to restore {0}?", path.basename(scmResources[0].resourceUri.fsPath)); } else { message = localize('confirm discard', "Are you sure you want to discard changes in {0}?", path.basename(scmResources[0].resourceUri.fsPath)); } </ins> } } else { <del> message = localize('confirm discard multiple', "Are you sure you want to discard changes in {0} files?", scmResources.length); </del> <ins> if (scmResources.every(resource => resource.type === Status.DELETED)) { yes = localize('restore files', "Restore files"); message = localize('confirm restore multiple', "Are you sure you want to restore {0} files?", scmResources.length); } else { message = localize('confirm discard multiple', "Are you sure you want to discard changes in {0} files?", scmResources.length); } </ins> if (untrackedCount > 0) { message = `${message}nn${localize('warn untracked', "This will DELETE {0} untracked files!", untrackedCount)}`;

Discussion:
Delete a file. Attempt to undo the deletion. See error message: ! This could stand to be more clear. It makes sense on the technical side, but some git novices might be confused. I personally had to double check I was reverting the right change.
I think changing the message to is ok when discarding the changes in a deleted file.
Change:
const logService = accessor.get(ILogService); const viewletService = accessor.get(IViewletService); <del> let editor; if (context !== undefined) { if ('notebookEditorId' in context) { const editorId = context.notebookEditorId; const matchingEditor = editorService.visibleEditorPanes.find((editorPane) => { const notebookEditor = getNotebookEditorFromEditorPane(editorPane); return notebookEditor?.getId() === editorId; }); editor = getNotebookEditorFromEditorPane(matchingEditor); } else if ('notebookEditor' in context) { editor = context?.notebookEditor; } else { editor = getNotebookEditorFromEditorPane(editorService.activeEditorPane); } </del> <ins> let editor: INotebookEditor | undefined; if (context !== undefined && 'notebookEditorId' in context) { const editorId = context.notebookEditorId; const matchingEditor = editorService.visibleEditorPanes.find((editorPane) => { const notebookEditor = getNotebookEditorFromEditorPane(editorPane); return notebookEditor?.getId() === editorId; }); editor = getNotebookEditorFromEditorPane(matchingEditor); } else if (context !== undefined && 'notebookEditor' in context) { editor = context?.notebookEditor; } else { editor = getNotebookEditorFromEditorPane(editorService.activeEditorPane); </ins> } if (!editor || !editor.hasModel()) {

Discussion:
Issue Type: <bBug</bWasn't sure who to file this issue on so please redirect as needed. I open an existing python notebook and click run, nothing happens. I can see, by perusing around the UI that I probably need to select a kernel, but I get no feedback from the run button. In the gif below I am clicking run, but I did not click select kernel. ! VS Code version: Code - Insiders 1.61.0-insider (, 2021-09-16T08:31:28.161Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Hey it looks like you changed the kernel select command, now it doesn't work in this scenario, can you check? It is called from here I think the problem is not calling it with a context. Actually I don't know why we call this with rather than just putting the real work in some method somewhere.
Sorry, this was me, looking into a fix