jiebi/CodeConvo huggingface dataset:
Change:
context: options.context, actionRunner: options.actionRunner, ariaLabel: options.ariaLabel, <ins> ariaRole: 'menu', </ins> focusOnlyEnabledItems: true, triggerKeys: { keys: [KeyCode.Enter, ...(isMacintosh || isLinux ? [KeyCode.Space] : [])], keyDown: true } }); this.menuElement = menuElement; <del> this.actionsList.setAttribute('role', 'menu'); </del> this.actionsList.tabIndex = 0; this.menuDisposables = this._register(new DisposableStore());

Discussion:
/CC Issue Type: <bBug</ba menu to appear either by e.g, pressing alt+f or by pressing the applications key in the explorer tree view. says "tool bar" instead of menu. More importantly, focus is no longer being automatically placed on the first menu item as it normally would be. VS Code version: Code - Insiders 1.65.0-insider (, 2022-02-21T05:15:17.930Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.10.60.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (14)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.223.0 remote-ssh0.74.0 remote-ssh-edit0.74.0 remote-wsl0.64.2 vscode-remote-extensionpack0.21.0 dendron0.83.0 dendron-markdown-links0.6.20 dendron-markdown-preview-enhanced0.10.57 dendron-markdown-shortcuts0.12.1 dendron-paste-image1.1.0 dendron-snippet-maker0.1.6 prettier-vscode9.3.0 shellcheck0.18.8 </details<!-- generated by issue reporter --
I know changed some defaults of menus in insiders to tryout layout changes. This might be related can you also reproduce with VS Code stable?
it looks like you are using windows, but can you confirm if you are using the titlebar style or titlebar style
I don't get this odd reading of a "toolbar" when opening menus on stable, v1.63.2. how do I check which style I'm using?
Just to add, I realized that even on stable, pressing the applications key to open a context menu does not automatically place focus on the first item, so this is not new behaviour. Specifically, the new behaviour I'm noticing here is the fact that its reading a toolbar which is confusing.
please check the setting
Custom, which is the default.
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
Verified that the custom menu is correctly read with Narrator (Windows)
Change:
const enum ReuseOrder { PreviouslySelected = 1 << 8, SameExtensionAsNotebook = 2 << 8, <del> BuiltIn = 3 << 8, OtherRenderer = 4 << 8, </del> <ins> OtherRenderer = 3 << 8, BuiltIn = 4 << 8, </ins> } const preferred = notebookProviderInfo && this.preferredMimetype.getValue()[notebookProviderInfo.id]?.[mimeType];

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0-insider OS Version: Windows 10 Steps to Reproduce: a new VS Code Notebook Renderer using the to the description , it should be possible to override MIME types with built-in renderers, e.g.: tried to create a renderer replacing the renderer, but didn't realize it was buried under the following UI interface: ! ! For the output renderer I am authoring, I am mainly looking to augment the existing HTML renderer (ie. add a button above the existing output) so it wouldn't make sense to have users manually select it as a renderer option. Would it be possible to either make the renderer more discoverable or add some API to allow for the scenario I'm describing where it's mostly an augmentation and therefore should be shown by default? Thanks!
Verifier: when following to create a renderer extension, type in for the mimetype.
Change:
choices.push(addToWorkspace); } <del> const result = await window.showInformationMessage(message, ...choices); </del> <ins> const result = await window.showInformationMessage(message, { modal: true }, ...choices); </ins> action = result === open ? PostCloneAction.Open : result === openNewWindow ? PostCloneAction.OpenNewWindow

Discussion:
Testing clone a repo from within VS Code when done a notification is shown IMO a modal is the better choice of UI because this something I am awaiting and wanting to take action on <img width="1527" alt="Screenshot 2022-09-27 at 11 15 02" src="https://user-"
it makes sense to me. please let me know if you have any concerns. Thanks!
, as having notifications snoozed always, I was missing this notification but I think it should be modal as it is part of a flow that I triggered.
No concerns with using a modal
Change:
//#region Test Coverage export class TestCoverageCount implements vscode.TestCoverageCount { constructor(public covered: number, public total: number) { <ins> validateTestCoverageCount(this); </ins> } } <del> const validateCC = (cc?: vscode.TestCoverageCount) => { if (cc && cc.covered > cc.total) { </del> <ins> export function validateTestCoverageCount(cc?: vscode.TestCoverageCount) { if (!cc) { return; } if (cc.covered > cc.total) { </ins> throw new Error(`The total number of covered items (${cc.covered}) cannot be greater than the total (${cc.total})`); } <del> }; </del> <ins> if (cc.total < 0) { throw new Error(`The number of covered items (${cc.total}) cannot be negative`); } } </ins> export class FileCoverage implements vscode.FileCoverage { public static fromDetails(uri: vscode.Uri, details: vscode.FileCoverageDetail[]): vscode.FileCoverage {

Discussion:
Refs: [x] anyOS [x] anyOS Complexity: 4 We have at long last finalized the test coverage API. Implementing an extension that produces data for the API from scratch is challenging, and requires domain-specific knowledge, so you might find playing with the selfhost test provider to be the most effective way to test it The new types in the API include: - - - Please: Do some testing that the API and UI functions as you would expect Read through the API and verify that its documentation makes sense to you See that UI interactions work nicely as you would expect (you can use any extension that produces coverage to test this part)
Change:
return this.hide(); } <ins> const hasTextFocus = this._editor.hasTextFocus(); if (!hasTextFocus) { this.gutterHide(); return this.hide(); } </ins> const options = this._editor.getOptions(); if (!options.get(EditorOption.lightbulb).enabled) { this.gutterHide();

Discussion:
This was unexpected for me where I open a file (not focus the editor) and the light bulb shows up randomly depending on where the cursor happened to have been restored: !
cc
Change:
this._ctxLastFeedbackKind.reset(); this._zone.hide(); <del> this._editor.focus(); </del> <ins> // Return focus to the editor only if the current focus is within the editor widget if (this._editor.hasWidgetFocus()) { this._editor.focus(); } </ins> this._sessionStore?.dispose(); this._sessionStore = undefined;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Steps to Reproduce: a notebook cell one, cmd+i cell two, cmd+i Inline chat gets disposed in cell one, a new one is created in cell two, and lastly, cell editor one gets focused automatically
Change:
private model: IndexTreeModel<T | null, TFilterData>; private nodes = new Map<T | null, ITreeNode<T, TFilterData>>(); <ins> private readonly nodesByIdentity = new Map<string, ITreeNode<T, TFilterData>>(); private readonly identityProvider?: IIdentityProvider<T>; </ins> private sorter?: ITreeSorter<{ element: T; }>; readonly onDidSplice: Event<ITreeModelSpliceEvent<T | null, TFilterData>>;

Discussion:
Issue Type: <bBug</bTesting Repo settings editor to the section click to switch to instead of Bug TOC is collapsed. Any scrolling causes the TOC to be expanded at the correctly again VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-29T06:13:57.866Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Probably another case of The TOC tree sometimes maintains its selection/expansion state, sometimes not.
Hey should expansion state be preserved using the string identity? was for focus/selection, this is for expansion state.
Adding myself so I don't forget about this.
Let's merge this early June:
Thanks
Change:
margin: 0 0 8px 0; } <ins> .interactive-item-container .interactive-result-code-block .monaco-toolbar .monaco-action-bar .actions-container { padding-inline-start: unset; } </ins> .interactive-response .interactive-response-error-details { display: flex;

Discussion:
! ! : 1.84.0-insider (user setup) : : 2023-10-19T05:34:47.214Z Electron: 25.9.1 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
Change:
'extensions-download-dir': { type: 'string' }, 'builtin-extensions-dir': { type: 'string' }, 'list-extensions': { type: 'boolean', cat: 'e', description: localize('listExtensions', "List the installed extensions.") }, <del> 'show-versions': { type: 'boolean', cat: 'e', description: localize('showVersions', "Show versions of installed extensions, when using --list-extension.") }, 'category': { type: 'string', cat: 'e', description: localize('category', "Filters installed extensions by provided category, when using --list-extension.") }, </del> <ins> 'show-versions': { type: 'boolean', cat: 'e', description: localize('showVersions', "Show versions of installed extensions, when using --list-extensions.") }, 'category': { type: 'string', cat: 'e', description: localize('category', "Filters installed extensions by provided category, when using --list-extensions.") }, </ins> 'install-extension': { type: 'string[]', cat: 'e', args: 'extension-id[@version] | path-to-vsix', description: localize('installExtension', "Installs or updates the extension. The identifier of an extension is always `${publisher}.${name}`. Use `--force` argument to update to latest version. To install a specific version provide `@${version}`. For example: 'vscode.csharp@1.2.3'.") }, 'uninstall-extension': { type: 'string[]', cat: 'e', args: 'extension-id', description: localize('uninstallExtension', "Uninstalls an extension.") }, 'enable-proposed-api': { type: 'string[]', cat: 'e', args: 'extension-id', description: localize('experimentalApis', "Enables proposed API features for extensions. Can receive one or more extension IDs to enable individually.") },

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --VS Code version: Code 1.52.0 (, 2020-12-10T22:46:53.673Z) OS version: Darwin x64 19.6.0 Steps to Reproduce: this section contains a reference to instead of the correct option : Extensions Management --extensions-dir <dirSet the root path for extensions. --list-extensions List the installed extensions. --show-versions Show versions of installed extensions, when using --list-extension. --category Filters installed extensions by provided category, when using --list-extension. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes PR submitted with the fix.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.6 --- <!-- score: 0.507 --<!-- potentialduplicatescomment --
Change:
} else if (choice === stash) { await this.stash(repository); await item.run(opts); <del> await this.stashPopLatest(repository); </del> } } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Setting up the problem scenario: At this stage, there are two branches. One has changes committed, one has changes to the working directory that can be discarded, stashed, or committed. If you try to use the VSCode interface to simply switch to newbranch, you get a popup alerting you that local changes would be overwritten by checkout. It gives the options "Stash & Checkout", "Cancel", and "Force Checkout". The Cancel and Force Checkout buttons work as one would expect, cancelling the process or forcing it to proceed with destructive side effects respectively. The Stash & Checkout button is problematic. Based on the presented information, I would expect a call to followed by a call to . End of process. This would leave me in a very sensible position where I am looking at a clean working tree reflecting new_branch, and a stash on master containing the working tree changes associated with that branch. Instead, VSCode attempts to apply the stash to the current working tree, resulting in conflicts that have to be resolved before anything else can happen. I think either the behavior should be modified to do exactly as described, or the prompts should better reflect what will happen. Perhaps "Migrate Working Tree Edits" would be appropriate. Personally I think changing the behavior is the better solution, as I encounter many more instances of "oh I need to see what was done in that other branch real quick" vs "I'm on the wrong branch and should blindly migrate my edits to a different branch via a stash".
would love to get your thoughts on this one. Thank you!
Yeah that seems wrong. I think we should just remove the pop after checkout behavior.
I have looked into this a bit further and I see that for the action was "Smart Checkout". I do agree that if we were to use "Stash & Checkout" as the label, we should remove the code that pops the most recent stash.
Will this change of behaviour be obvious to someone who previously took advantage of how it used to conclude by popping the stash? Or should suggested "Migrate Working Tree Edits" button be to the dialog?

Yes, this will a change in behaviour, though I would prefer not adding a third option to the dialog. thoughts?
Up to you
Without an extra button I predict at least one complaint from a person who didn't spot a release notes announcement and doesn't notice that their stashed changes now remain stashed.
I have a button "Migrate Changes". Opted to use the "Changes" terminology to be consistent I have moved the "Force Checkout" button to the end so that it is not not the primary button in the dialog. <img width="274" alt="image" src="https://user-"
Change:
// Clear the current marker so successive focus/selection actions are performed from the // bottom of the buffer this._currentMarker = Boundary.Bottom; <ins> this._navigationDecoration?.dispose(); this._navigationDecoration = undefined; </ins> this._selectionStart = null; }

Discussion:
Testing When I use cmd+up/down to navigate between POIs in task output, the blue box renders for a second on the item I have selected, but then disappears. I didn't understand what was happening to the focus border.
that is by design.
This has come up before, I think you had an idea to improve this?
I had the same experience in where I was on a slow machine. I think I had suggested just using a line on the side (like our activity bar) that remains until your focus changes: <img src="https://user-"
To the left of the command decorations? ! I like how visible the outline is when jumping between commands, so we could keep that as is and just also show the persistent line? !
yea I'd be open to trying that out, I think using both might be a bit overkill but just having the single line can also be hard to notice.
Change:
return true; } <del> private async openExternalBrowser(url: string, defaultApplication?: string) { </del> <ins> private async openExternalBrowser(url: string, defaultApplication?: string): Promise<void> { </ins> const configuredBrowser = defaultApplication ?? this.configurationService.getValue<string>('workbench.externalBrowser'); if (!configuredBrowser) { return shell.openExternal(url);

Discussion:
Testing Not sure if this is possible, but I set the to even though I don't have Firefox... then I tried to open something and nothing happened. I was confused because I thought I had Firefox installed, but I guess I remembered incorrectly! I think something like this is increasingly important in the workspace-setting level. Sure, the protection of this is behind Workspace Trust... but I don't seem to get any notification or indication that there's a setting applied that influences how VS Code opens the browser or if it's going to no-op. Considering this setting influences things like user auth flows, I think we should try to do something here. I was surprised that no browser was opened when I attempted to log in to a GitHub extension... which makes sense if this setting is set to something invalid.
I think this might be reported as and misses a fix or workaround. If someone has an idea, either by contributing to or seeing what we can do here:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
It appears that this is fixed by opening the default instead of what is configured. That makes sense to me.
Change:
color: var(--vscode-descriptionForeground); font-size: 11px; align-self: baseline; <del> display: inline-flex; </del> <ins> padding-left: 10px; margin-left: auto; </ins> } .monaco-workbench .inline-chat .status .label.hidden { display: none; } <del> .monaco-workbench .inline-chat .status .label.info { margin-right: auto; padding-left: 2px; </del> <ins> .monaco-workbench .inline-chat .status .label.error { color: var(--vscode-errorForeground); </ins> } <del> .monaco-workbench .inline-chat .status .label.info > .codicon { </del> <ins> .monaco-workbench .inline-chat .status .label.warn { color: var(--vscode-editorWarning-foreground); } .monaco-workbench .inline-chat .status .label > .codicon { </ins> padding: 0 5px; font-size: 12px; line-height: 18px; } <del> .monaco-workbench .inline-chat .status .label.status { padding-left: 10px; padding-right: 4px; margin-left: auto; } .monaco-workbench .inline-chat .status .label .slash-command-pill CODE { border-radius: 3px; padding: 0 1px; background-color: var(--vscode-chat-slashCommandBackground); color: var(--vscode-chat-slashCommandForeground); } .monaco-workbench .inline-chat .detectedIntent { color: var(--vscode-descriptionForeground); padding: 5px 0px 5px 5px; } .monaco-workbench .inline-chat .detectedIntent.hidden { display: none; } .monaco-workbench .inline-chat .detectedIntent .slash-command-pill CODE { border-radius: 3px; padding: 0 1px; background-color: var(--vscode-chat-slashCommandBackground); color: var(--vscode-chat-slashCommandForeground); } .monaco-workbench .inline-chat .detectedIntent .slash-command-pill a { color: var(--vscode-textLink-foreground); cursor: pointer; } </del> .monaco-workbench .inline-chat .chatMessage .chatMessageContent .value { overflow: hidden; -webkit-user-select: text;

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
export interface ITerminalLinkActivationResult { source: 'editor' | 'search'; link: string; <ins> selection?: ITextEditorSelection; </ins> } class TestCommandDetectionCapability extends CommandDetectionCapability {

Discussion:
My project is under https://user- Reproduce steps: vscode open a folder which file path contains space, for example: an integrated terminal the path link Versions:
nice I can repro with the space in the name, thanks for following up
I can still repro with Windows.
I looked into this, and it will be tricky because we currently use space as one of the characters which indicates the end of a path. One idea would be to check if such a link exists (using our original regex) and if not, use regex on the subsequent sequence - then concatenating the two results for First result would be doesn't exist process exists
https://user- Look the above video, I have several questions. path is not a existed path in the disk, but also clickable. I click the , it open a file which is not why the whole string is recogonized to a path? the real path is:
this is actually about when the parents of the link have a space, it's expected currently that an absolute path with a space won't work.
is it expected that a local link with a space somewhere within the path is not detected? that is the case currently - verified via adding a test to
absolute paths (eg. ) won't work because of Relative paths without spaces with absolute ancestors that have spaces (eg. inside ) should work but don't in some cases.
When verifying, make sure to test both on a Windows machine and a non-Windows machine.
Doesn't work for me on a Mac, I guess thats probably because I still haven't got the fix in the latest insider build.
are you on ?
Worked for me on macOS. Don't have a Windows machine to try this out so someone else will need to verify on Windows.
Yes, I'm on that same version. Here's what it looks like for me on a Mac with spaces !
still not work in latest version: https://user-
For absolute paths, see I wasn't able to get to work, though. It'd open the file, but place the cursor at the beginning.
please provide some more details, it works for me: !
This is the behaviour with version 1.70.0 After ctrl+clik a popup appears at the top of the screen and I have to hit enter to go to the suggested file:line.
I can repro that on Windows, Remote-WSL and macOS.

The file must not be in the root directory for this to happen. !
let's track that problem in and as this issue is becoming quite unwieldy/unfocused.
created to track the problem related to quotes you're seeing. Could you re-verify this if all good outside of these 3 issues I created? It's difficult to manage this issue as it's so general.