jiebi/CodeConvo huggingface dataset:
Change:
import { GLOBAL_ACTIVITY_ID, ACCOUNTS_ACTIVITY_ID } from 'vs/workbench/common/activity'; import { Emitter, Event } from 'vs/base/common/event'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <ins> import { isUndefined } from 'vs/base/common/types'; </ins> class ViewContainerActivityByView extends Disposable {

Discussion:
Type: <bBug</bAn extension I maintain creates multiple SourceControl objects and implements a command to refresh them all in parallel. When an object has completed its refresh (adding/removing/updating its SourceControlResourceGroups) it updates its count property. When this happens for the first object the progress (clock) badge on the SCM icon in the activity bar gets replaced by that count, thus giving the user the impression that the refresh has completed if they have switched to a different activity and so don't see the ongoing progress bar animation across the top of the SOURCE CONTROL pane. When ProgressService adds the clock badge using ActivityService it specifies , which sounds like it is supposed to give this badge priority over a count badge: But it doesn't seem to have that effect. I will try to prepare a sample extension that demonstrates the issue. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-26T21:24:03.029Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Adding as he seems to have recently changed the referenced line.
Would be waiting for the sample extension. Thanks in advance for doing so. Can you also please check the behaviour in older version of VS Code?
For the repro: the source-control-sample folder. and run. EDH window, close any already-open folder/workspace, and optionally create an empty profile to rule out other extensions and odd settings. palette run . Accept the default (demo), then in the local folder dialog create/choose a scratch folder, and trust it if prompted. to SCM view. and watch the SCM side bar and activity bar icon badge: ! Notice how the first SourceControl completes its withProgress refresh after 4 seconds, updates the input box placeholder to report this, and sets its count property. At this point the second SourceControl is half way through its 8-second refresh, and the progress bar animation continues, but the clock badge on the activity bar icon has been displaced by the count badge (4) of the first one. Behaviour on 1.83.1 is correct: !
do you now have the info you need? Seeing how this is apparently a 1.84 regression, will it be treated as a Candidate for the milestone?
Thanks a lot for info and repro.

This is indeed a regression and caused by the wrong prioritising of the badges. Tagged this as candidate.
/verified
Adding verified label as verified it
Change:
if (!scopes.includes('profile')) { scopes.push('profile'); } <ins> if (!scopes.includes('offline_access')) { scopes.push('offline_access'); } </ins> scopes = scopes.sort(); const scopeData: IScopeData = { scopes,

Discussion:
Similar to add to get refresh tokens by default when using
verification steps: in an extension, ask for: run the extension and sign in when asked as a result of ^^^ Restart vscode Expected to not get asked for sign in again because was automatically.
I get this in my browser: The request is blocked. <long string of characters
I am also unable to complete the sign in flow in my browser.
I had a typo in my code snippet above so when you verify this again, please make sure you copy the code snippet fresh. I had instead of
Change:
} async run(accessor: ServicesAccessor) { const terminalService = accessor.get(ITerminalService); <del> const instance = terminalService.getActiveOrCreateInstance(); </del> <ins> const instance = terminalService.activeInstance || terminalService.createTerminal({ target: TerminalLocation.TerminalView }); </ins> if (!instance) { return; }

Discussion:
The terminal commands and are used for both the panel buttons and the commands in the CP (that we do want to use the defaultLocation for). Not sure how to differentiate between them - don't think we want to duplicate the actions. let me know what you think
Let's wait until after is done since that will likely add target support to the create commands
Other reproes: Ctrl / Cmd J to open the panel - terminal editor is created focus the terminal editor, click the trash can on the panel , close the editor tab - a bunch of errors in the console
Change:
this.registerNotebookEditorListeners(); this.registerViewCellLayoutChange(); this.registerCellEditorEventListeners(); <del> this.registerDecorations(); </del> this.registerMouseListener(); this._register(Event.any(this.viewCell.onDidStartExecution, this.viewCell.onDidStopExecution)((e) => {

Discussion:
Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width="981" alt="image" src=""I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width="980" alt="image" src=""It appears that the Code cells lost their yellow highlight.
Change:
if (typeof value === 'boolean') { if (value === true) { <del> vetoReasons.push(reason); </del> <ins> vetoReasons.add(reason); </ins> } } else { value.then(value => { if (value) { <del> vetoReasons.push(reason); </del> <ins> vetoReasons.add(reason); </ins> } <ins> }).catch(error => { vetoReasons.add(nls.localize('extensionStopVetoError', "{0} (Error: {1})", reason, toErrorMessage(error))); </ins> }); } }

Discussion:
Testing Open a folder that has a image in an empty profile Install Luna Paint Extension Edit the image using Luna Paint and do not save Switch the profile to another profile Reason is empty <img width="573" alt="image" src=""
Good catch, there is an error thrown but I fail to remember the reason in that case. It should be: !
Change:
lineLimit: 30, ...settings } as RenderOptions, <del> onDidChangeSettings<T>(_listener: (e: T) => any, _thisArgs?: any, _disposables?: any) { </del> <ins> onDidChangeSettings(listener: handler, _thisArgs?: any, disposables?: IDisposable[]) { settingsChangedHandlers.push(listener); const dispose = () => { settingsChangedHandlers.splice(settingsChangedHandlers.indexOf(listener), 1); }; disposables?.push({ dispose }); </ins> return { <del> dispose(): void { } </del> <ins> dispose </ins> }; }, workspace: {

Discussion:
a cell with enough output to truncate scroll the link to view as a scrollable element :bug: output height is stretched to show entire output without scrollable region
Change:
}, icon: icons.splitCellIcon, keybinding: { <del> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_EDITOR_EDITABLE, NOTEBOOK_CELL_EDITABLE), </del> <ins> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_EDITOR_EDITABLE, NOTEBOOK_CELL_EDITABLE, EditorContextKeys.editorTextFocus), </ins> primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KeyK, KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.Backslash), weight: KeybindingWeight.WorkbenchContrib },

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --: 1.61.0-insider (system setup) : : 2021-09-24T09:00:59.405Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: <kbdctrl+k ctrl+shft+<kbd! <kbdctrl+shft+-<kbd!
One of these is contributed by the Jupyter keybindings extension. But, I'm not sure why they show differently between these two menus.
It seems we don't have these actions in menu anymore.
Change:
// regster completion item provider when there is any choice element if (this._session?.hasChoice) { <del> this._choiceCompletionItemProvider = { </del> <ins> const provider = { </ins> provideCompletionItems: (model: ITextModel, position: Position) => { if (!this._session || model !== this._editor.getModel() || !Position.equals(this._editor.getPosition(), position)) { return undefined;

Discussion:
This problem still occurs even if you disable all extensions. This problem was confirmed in Markdown file. below the snippet (it contains a snippet choice) below the code in Markdown file snippet in Markdown file I expected to see link label suggestion, but it does not display link label suggestion... Included by snippet choice reproduces the issue. It is not displayed even if is pressed. Gif demo: ! VS Code Windows 11
Sorry but I am unaware of link label suggestions. What are those and where do they usually come from?
I'm sorry, I had my own way of saying it. I don't know the correct terminology, but I'll show you an example in action. the following markdown your cursor inside the second ! I haven't been able to find any release notes for this feature, but it's a feature in VS Code and not coming from an Installed extension. This feature doesn't work within certain snippets.
I can reproduce. Looks like the choice suggest provider is staying active despite its placeholder not being active anymore
Using a snippet seems to break label suggestions until the editor is reloaded. Even reopening the file doesn't fix it:
repro steps please
the snippet from the original issue in your global snippets a new markdown file with the contents as in the video, you can get completions until the moment you use the snippet
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
<string>#222218</string> <key>activeGuide</key> <string>#9D550FB0</string> <ins> <key>guide</key> <string>#48473E</string> </ins> <key>bracketsForeground</key> <string>#F8F8F2A5</string>

Discussion:
Testing on a MacBook Pro Retina display with brightness 2 steps below max while using a power adapter. This is my usual setting a regularly lit environments. In the following themes the indentation guides should be changed to improve their visibility: [x]  Abyss [x]  High Contrast [x]  Monokai In the following themes the indentation guides are subtle and easy to miss. However, changing those is optional. [x]  Dark (and Dark+)
I am using the color from the theme, 100% the same as . owns the Dark and Dark+ themes (including the color):
Assigning to the UX team to decide on changes to the default colors.
Some of the reported themes (Dark, Dark+, High Contrast) are owned by us. Others (Abyss, Monokai) are cloned and packaged along with VS Code. It means indirectly we own them and have to maintain them. So we should provide proper color for indent guides for all these themes. Can you please go through all our default packaged themes and come with a nice indentation guides color ? Note: TM theme setting to use for identation guides is . Also, as mentioned in description, except reported themes others look good to me Abyss Dark Dark+ HighContrast Monokai
Reopening until PR is merged in
Moving this to September milestone, since it is too late to make into August
Change:
if (beforeCommandExecution && !this._placeholderDecoration) { this._placeholderDecoration = decoration; this._placeholderDecoration.onDispose(() => this._placeholderDecoration = undefined); <del> } else { </del> <ins> } else if (!this._decorations.get(decoration.marker.id)) { </ins> decoration.onDispose(() => this._decorations.delete(decoration.marker.id)); this._decorations.set(decoration.marker.id, {

Discussion:
Many of these onDispose listeners get created:
we fixed this at one pt. !
They were in and
here's when we lost it
want to fix it since you're working on that PR?
Let's hold off until it's done, this PR is complicated enough without merge problems
it's a simple fix - literally adding to the conditional on line 218
Did another review and haven't seen this issue since
Change:
tree.reveal(focus[0]); } } <ins> // Ensure DOM Focus ensureDOMFocus(focused); </ins> } KeybindingsRegistry.registerCommandAndKeybindingRule({

Discussion:
I like the up / down keyboard navigation over notebook cells, but when you try to use to navigate the order is very unexpected. a notebook. I am using my- my work cell -Focus is on GitHub issues label -focus seems lost -focus is on the start of the document, even though I did not traverse until the end of the docuemnt Ideally tab should go in visual order. If that is not possible should move focus out of the notebook. Similarly tree tab is not used to move focus so users use up / down, but pressing tab focuses out of the tree and does not lead to unexpected jumping of focus.
Fixed in this change Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell (step 3 in OP) Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in )
Much better now. Thanks for fixing this.
Change:
@IInstantiationService private readonly instantiationService: IInstantiationService, @IModelService private readonly modelService: IModelService, @ICodeEditorService private readonly codeEditorService: ICodeEditorService, <ins> @IConfigurationService private readonly _configurationService: IConfigurationService </ins> ) { super(editor, { showFrame: true, showArrow: false, frameWidth: 1 });

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: -- isn't fixed <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.37.0 OS Version: Windows 10 !
This works just fine for me on OS X and Win10 with vscode insiders. Can you reproduce with latest vscode insiders !
Thanks. I tried and it is indeed fixed in the insider build. However, I can reproduce it for sure on the stable version. The fix should have been included in June update. (seems it was)
There might be some extension which you are using that is modiyfing css and is breaking this. Sorry but I can not reproduce this, either in stable and in insiders. Also no other user seems to be hitting this. Due to that I will close this issue. And yes the fix was included in the June update.
I find the key to reproduction now. Just put in the and you will see the bug.
Yes I acknowledge the bug. The issue is that the breakpoint widget is not updating as the editor font updates. The size of the widget updates, but the font should update as well. I am open to PR that fix this issue Code pointer
Will have a try
Things look more complicated than we expected.  doesn't feel right. The is of 40px height (with font size set to 16) ! It looks more reasonable if setting the height to 20px ! centering thing. The is centred by the styles of (its parent dom) while gets a hardcoded 8px ... !
yes I acknowledge it is not the nicest. Any improvements in that area would be appreciated.
I have gone too deep down the rabbit hole . Leaving it to whoever interested...
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details . If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our and guidelines. Thanks for your understanding and happy coding!

I understand this issue is not that important. But I don't agree this is out of scope . IMHO, it is at least a bug (although with very low priority).
Agree, let's reopen.
Attempted a PR () for this. Please have a look.
Verifier: Change the editor.fontSize, add a conditional breakpoint and make sure the text in the breakpoint widget is centered. Or can just try in VS COde insiders from Thursday and let us know how it behaves for him
Thank you! I confirm it is fixed in the insider build.
Thanks for letting us know. Adding verified label.
Change:
const currentTextEntry: NewFileItem = { commandID: 'workbench.action.files.newFile', commandArgs: { languageId: undefined, viewType: undefined, fileName: val }, <del> title: localize('miNewFileWithName', "New File ({0})", val), </del> <ins> title: localize('miNewFileWithName', "Create New File ({0})", val), </ins> group: 'file', from: builtInSource, };

Discussion:
Testing <img width="728" alt="image" src="https://user-"- I would suggest that we update the placeholder to indicate that you can type in a name to create a new file Is there any reason why we have description for the capabilities that are included in VS Code? <img width="728" alt="image" src="https://user-"- I would suggest that we update the quick pick item to something like "Create New File" and remove the "Built-In" description <img width="728" alt="image" src="https://user-"- I would suggest to place the "New File" quick pick item at the end of the list separated from the file types
It's just been the precedent whenever we have some features that are contributed in a list with built-in features there as well. The Reopen With... picker does the same thing. I think the division here is built-in vs non built-in and not necessarily file types vs not file types. The New File (name) will actually choose a file type based off of the file extension
Change:
private hoverWidget: DebugHoverWidget; private showHoverScheduler: RunOnceScheduler; private hideHoverScheduler: RunOnceScheduler; <del> private removeInlineValuesScheduler: RunOnceScheduler; </del> <ins> private updateInlineValueDecorationsScheduler: RunOnceScheduler; private removeInlineValueDecorationsScheduler: RunOnceScheduler; </ins> private hoverRange: Range; private breakpointHintDecoration: string[];

Discussion:
Right now we expose an API to cells, and to webviews, but we don't publish types for this. The webview API is very simple, but the renderer will be somewhat more complex. We should consider either publishing these in or in a separate package.
This would be helpful for I think a or something would be a good place for it. Aside, it'd be cool if ts s could be contributed to... Right now we'd need a whole separate NPM scope to have separate I believe.
We can just PR a package called The naming of packages is only constrained by the maintainers' policy, and there are types that don't correspond to single packages, e.g.
Poor wording, I mean the project would need a different and for the client code vs the extension host code. (Or just know not call acquireApi outside of the client context of course. )
Oh, yea. In the sample renderer/code generator I'm using project references to keep things separated -- that also lets us use only in the renderer and output es6 modules (only) for webpack.
PR submitted

Bug Set "debug.inlineValues": true. Set breakpoint somewhere. After paused on the step, goto the end of the line and hit enter. Before After VS Code version: Code 1.20.0 (, 2018-02-07T17:02:34.244Z) OS version: Darwin x64 16.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ EditorConfig0.12.0 vscode-eslint1.4.5 vscode-great-icons2.1.24 auto-rename-tag0.0.15 code-beautifier1.7.2 vscode-scss0.6.2 mssql1.3.0 cpptools0.14.6 licenser1.1.1 (1 theme extensions excluded) </detailsReproduces only with extensions
I acknowledge the bug. This is just how decoartions are behaving, unfortunetly the inline decorations do not seem to have an option to not grow beyond the line. maybe you have an idea how to solve this? fyi in case you are interested into looking for a fix
debugger.inlineValues uses the editor's decorator api. A fix we can do is that if the editor is edited , then we re-sync the inlineValue decorators I'm not sure how this works but would love it if the bug was assigned to me so I can see it in my issues list
that's a good idea. can you please add to our project so we can assign some issues to him?
Change:
// If HEAD is not published, make sure it is && !repository?.state.HEAD?.upstream ) { <del> const publishBranch = vscode.l10n.t('Publish Branch'); </del> <ins> const publishBranch = vscode.l10n.t('Publish Branch & Copy Link'); </ins> const selection = await vscode.window.showInformationMessage( vscode.l10n.t('The current branch is not published to the remote. Would you like to publish your branch before copying a link?'), { modal: true },

Discussion:
Testing I am currently one commit behind the remote branch and I am able to successfully create a link without seeing any dialog. The way the test plan item is written it implies that in this scenario, I should see a dialog. Is that the case or did I misunderstood the test plan item?
Testing with while being a few commits behind, I get the following dialog: <img width="264" alt="image" src=""When I Cancel, I don't get a link. When I Pull & Copy I get a link that is seemingly unaffected by the pull. Why then require the pull? (I tested with incoming commits affecting the file I copy a link from.)
The link that is copied might point to a range that is invalidated by incoming commits, so we notify in order to avoid you copying a link that points to a different area in the file. But perhaps we should also offer a Copy Anyway option here.

Testing When one tries to copy a link on a branch that has not been published we display a dialog asking the user whether they want to publish the branch. Based on my tests, the branch is getting published and the linked is being copied to the clipboard. I think that it makes sense to be explicit about what happens and change the label of the button to "Publish Branch & Copy Link". I also noticed that when trying to create a link for uncommited changes, the dialog contains an action to "Copy Anyways". I think actions should be consistent so we should add that action to this dialog as well.