jiebi/CodeConvo huggingface dataset:
Change:
}); // In case the debug session of interest was never caught anyhow. <del> this.lateDisposables.add(listener); this.lateDisposables.add(cancellationListener); </del> <ins> this.disposables.add(listener); this.disposables.add(cancellationListener); </ins> }); } }

Discussion:
I'm trying to use the configuration from website, but I'm facing a problem with the third option. I would like to use like these: and . But I can't find a way to achieve this with : Is it something possible? Thanks a lot
That launch config works for me and does what's expected. Note that the "serverReadyAction" in the latter config does not call the " debug client-side" launch config. For that you would want to use the and put in " debug client-side" for the .
Yes, I agree with you, both configurations are working as expected. I wasn't very clear in my first message, I will try to explain better. On my NextJs project, I can have the following configurations: The first one start the project and enables debugging on server side, the second one open chrome and enables debugging on client side. If I put on the second configuration, it will work just fine: What I want, is using the third configurations only to : start the project, enable debugging on server/client side and open chrome with my . Is it possible to achieve something like this ? I can't find any option in that case to make my working.
serverReadyAction doesn't accept additional configuration properties to pass to the launch config. The reason for this is mostly that intellisense doesn't work in that action (under the hood it's provided by a different extension) so writing configuration in the nested object is hard. The way to do this is define the separate launch config and reference it. Copying your original configuration set:
Your configuration plus two small additions almost give the result I'm looking for! I still have too issues with this: If I kill the (by clicking on the icon), is not automatically killed dispite the option. When I start , is automatically started, but I can see both elements here: !. Is it possible to hide the last one (wich should be automatically killed when is stopped)? I clearly saw that you explained to me why it was not possible to do this (use on a ) in a single configuration, but is there a "hacky" way the achieve my main goal? Or is something planned in the futur? Or maybe there is a way to fix my remaining concerns with the current configuration?

No, this is not possible and is not something we'd do, since you would not be able to control the debug session in that case. That's a bug, will put in a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
constructor() { super({ id: 'workbench.editSessions.actions.resetAuth', <del> title: localize('reset auth', 'Sign Out'), </del> <ins> title: localize('reset auth.v2', 'Sign Out of Edit Sessions'), </ins> category: EDIT_SESSION_SYNC_CATEGORY, precondition: ContextKeyExpr.equals(EDIT_SESSIONS_SIGNED_IN_KEY, true), menu: [{

Discussion:
Steps: some changes on the "continue working on..." command and open in desktop :bug: VS Code opens but nothing loads https://user- Desktop Version: 1.70.0-insider (Universal) Commit: Date: 2022-07-26T05:17:37.262Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Darwin arm64 21.6.0 Web Version: 1.70.0-insider Commit: Date: 2022-07-26T05:17:04.193Z Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.5060.114 Safari/537.36
This action should be disabled in since we cannot access the local filesystem from the browser.
I'm still able to run the command from insiders vscode dev in Firefox. My Desktop Insiders then opens the repo using remote repositories but on the main branch instead of the branch I was working on. I'm not sure if this is the expected behaviour
I verified that this now works as expected https://user-
Change:
public layout(width: number) { this.input.layout(new dom.Dimension( width - /* horizontal padding */ 24 - /* editor padding */ 8 - /* filter button padding */ 22, <del> /* line height */ 27 - /* editor padding */ 4, </del> <ins> 20, // line height from suggestEnabledInput.ts </ins> )); }

Discussion:
Two small UI issues with the filter input box in the test explorer: 's not enough right margin on the button cursor isn't aligned to center (oh, screenshot below can't capture it but basically the cursor isn't in the center vertically of the input box). <img width="647" alt="image" src=""
Fixed in
Seems better but not fixed? <img width="1090" alt="image" src=""I propose that we move this to next milestone, I can take a stab at fixing this For comparison, search input : <img width="1064" alt="image" src=""
I'm sorry to do this again, but the cursor is still not centered I think this is because the input widget has height of 20px while the container has height 23
Change:
const matchedRecommendations: IStringDictionary<IFileOpenCondition[]> = {}; const unmatchedRecommendations: IStringDictionary<IFileOpenCondition[]> = {}; let listenOnLanguageChange = false; <ins> const languageId = model.getLanguageId(); </ins> for (const [extensionId, conditions] of extensionRecommendationEntries) { const conditionsByPattern: IFileOpenCondition[] = [];

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Current behavior: If a user opens a Python file (.py) or saves a file with a .py extension and does not have the Python extension installed, VS Code suggests installing the Python extension for Python support using the prompt below: <img width="236" alt="image" src=""Proposed behavior: It would be nice if we could have an installation trigger/prompt to install the Python extension before a user saves the file with the appropriate file extension. In this case, if the user creates a new untitled file --selects Python from the language dropdown --the user is prompted to install the Python extension (flow depicted in the gif below) ! In user studies, we have observed users struggle to find where to install the Python extension (or do not realize they need an extension for Python support) and do not think to save the file in this case causing them to get stuck at this point.
I remember this used to be supported and would have broken sometime back.
Another scenario I don't believe has been supported but could be useful is when users do not select Python as the language but instead just start typing Python code and the language model is able to detect it. Thoughts on enabling a prompt for this scenario as well?
Is not the other scenario same as this - At the end of both scenarios, the language mode of the file has changed to python. Language mode change will trigger the recommendation.
In the second scenario, the user has to click the lightbulb in order to get the language mode to change (or have the setting to automatically switch the language mode to the detected language enabled). The idea there was to prompt the user if the model detects their code to be Python, without the user having to click on the small lightbulb in the bottom corner. We haven't observed users engaging with or noticing the status bar much which was the motivator for this scenario.
I see. I will reopen the other issue for that scenario. Can you please update the issue and mention the use case clearly. Thanks.
Change:
ui.progressBar.getContainer().style.display = visibilities.progressBar ? '' : 'none'; ui.list.display(!!visibilities.list); ui.container.classList.toggle('show-checkboxes', !!visibilities.checkBox); <ins> ui.container.classList.toggle('hidden-input', !visibilities.inputBox && !visibilities.description); </ins> this.updateLayout(); // TODO }

Discussion:
Testing Quick pick flickers ! First screen (is only visible for ~100 ms on my machine): ! Second screen: !
This looks like
I do not think so, this is different than other issue. I think the flickering is coming from loading the quick pick options. I am showing the quick pick and loading the options by setting the busy flag of quick pick to true. May be I can load the options and show the quick pick, but there might be a delay between clicking the export button and seeing the quick pick
Transferring this to you because, I am loading and showing the check box items async mean while I am using the busy indicator. I assume all quick picks have same issue if the items are shown async.
Looks like the input box is the problem here. Settings Sync likes to hide it and it should really just be hidden before showing.
Change:
return MergeEditorInput.ID; } <ins> override get capabilities(): EditorInputCapabilities { return super.capabilities | EditorInputCapabilities.MultipleEditors; } </ins> override getName(): string { return localize('name', "Merging: {0}", super.getName()); }

Discussion:
Just came across this code that conditionally leaves zen mode when side by side or diff editors are opened: We probably want something similar when a merge editor is opened.
enable centered editor layout open a merge editor verify centered editor layout exits
Verified
Change:
$null,$product,$os,$arch,$type = $artifactName -split '_' $asset = Get-ChildItem -rec "$env:AGENT_TEMPDIRECTORY/$artifactName" <ins> if ($asset.Size -ne $_.resource.properties.artifactsize) { Write-Warning "Artifact size mismatch for '$artifactName'. Expected: $($_.resource.properties.artifactsize). Actual: $($asset.Size)" $set.Remove($artifactName) | Out-Null continue } </ins> Write-Host "Processing artifact with the following values:" # turning in into an object just to log nicely @{

Discussion:
Something went very wrong with the asset of the build: , exact size: 111,116,638 bytes. Manually downloading that confirms the app is OK. , exact size: 4,751,360 bytes. This is what got published to the CDN and is completely broken. This blob shares much of the same bytes as the correct full asset, but looking closer around the end of the 4MB I found the bytes are actually different (as in corrupted). I suspect something went wrong in the , after downloading the asset. There's a chance something went wrong in the but the likelihood of that happening and still producing a valid ZIP archive that wouldn't trip on is very low. What's ugly about this failure is that it wasn't a failure at all, the build was full green and happily pushed that thing to the CDN.
So bizarre. So the it's really The doesn't actually do what it's supposed to do and fails silently The stores some corrupted/incorrect data in and the is convinced it's ok and 'unzips' it Both of the bullet points All of these seem incredibly unlikely... I wonder how we could be "better at failing" here... docs: Ok trying out the API it looks like we have something here: ! namely . I'll try comparing the value of that with the actual asset downloaded. Also what's nice about this check is that is the size of the thing inside of the zip. In otherwords, it's the size of thing after we Expand-Archive.
To fix this, I'll have this check the artifact size: I'm waiting on this build to confirm this warning doesn't show up when it shouldn't
Yup it was some Twilight Zone stuff. Very cool, I was hoping there would be some metadata like this we could check against! Good job!
Change:
} commit(message: string, opts?: CommitOptions): Promise<void> { <del> return this.repository.commit(message, opts); </del> <ins> return this.repository.commit(message, { ...opts, postCommitCommand: null }); </ins> } merge(ref: string): Promise<void> {

Discussion:
The git extension API for commit appears to be following what the action button does. Example: last git SCM view thing I did was use the action button to Commit & Push an extension uses the git extension API to tries to commit and push.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
if (location.isAtPropertyKey) { let addValue = !location.previousNode || !location.previousNode.columnOffset; <del> let scanner = createScanner(document.getText(), true); scanner.setPosition(offset); scanner.scan(); let isLast = scanner.getToken() === SyntaxKind.CloseBraceToken || scanner.getToken() === SyntaxKind.EOF; </del> <ins> let isLast = this.isLast(document, position); </ins> collectPromise = this.jsonContribution.collectPropertySuggestions(fileName, location, currentWord, addValue, isLast, collector); } else { if (location.path.length === 0) {

Discussion:
VSCode Version: 1.1.0-alpha OS Version: Mac Steps to Reproduce: Regarding test plan Just found this very small bug (not an urgent one—ok to delay if necessary). just a package name in with no leading quotation mark (so it autocompletes the quotes for you) try adding a package with a leading quotation mark. Note that in the first case a comma is not , but in the second case a comma is . Not a huge deal, but consistency would be nice. Preferably, if it knows that it's on the last line of properties (i.e. the next line is a closing brace), then it would not insert a comma. But if it's in the middle of the list (i.e. the next line is another property in the JSON), then it would add a comma.
I always get a comma: Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Let me know if you saw another issue.
yes, that's what I was seeing. Thanks for checking!
Change:
#[dbus_proxy(name = "StopUnit")] fn stop_unit(&self, name: String, mode: String) -> zbus::Result<zvariant::OwnedObjectPath>; <ins> #[dbus_proxy(name = "Reload")] fn reload(&self) -> zbus::Result<()>; </ins> }

Discussion:
This used to work on the same machine however. Not sure when it stopped. Or why.
Please run
that worked! Wonder if the CLI should do it automatically?
BTW I also noticed how it returns exit code 0 (success) even when it failed like that. Perhaps you should avoid just issuing a warning in case some of these operations fails.
Thanks a ton,
Change:
export class BreadcrumbsOutlinePicker extends BreadcrumbsPicker { protected readonly _symbolSortOrder: BreadcrumbsConfig<'position' | 'name' | 'type'>; <ins> protected _outlineComparator: OutlineItemComparator; </ins> constructor( parent: HTMLElement,

Discussion:
The setting "breadcrumbs.symbolSortOrder" cannot be enabled for a specific language, i.e. "[markdown]": { "breadcrumbs.symbolSortOrder": "position" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Actually not a duplicate but should be straight forward to implement as filter-options can already be defined per language
Could you point me towards how to get the current resource from the editor model inside ?
The  has a reference to the text model
to verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position
Change:
@IContextMenuService contextMenuService: IContextMenuService, @IKeybindingService private readonly _keybindingService: IKeybindingService, @ITextModelService private readonly _textModelService: ITextModelService, <del> @IFileService private _fileService: IFileService </del> <ins> @optional(IFileService) private _fileService: IFileService </ins> ) { this._editor = editor; this._model = new QuickFixModel(this._editor, markerService);

Discussion:
Editor contrib should not depend on file service, which is not available in browser.
Leave it to for merging, marking it as optional can avoid dependency on file server in standalone editor.
Change:
// Name & Extension(s) if (name) { classes.push(`${name}-name-file-icon`); <del> const dotSegments = name.split('.'); for (let i = 1; i < dotSegments.length; i++) { classes.push(`${dotSegments.slice(i).join('.')}-ext-file-icon`); // add each combination of all found extensions if more than one </del> <ins> // Avoid doing an explosive combination of extensions for very long filenames // (most file systems do not allow files > 255 length) with lots of `.` characters // https://github.com/microsoft/vscode/issues/116199 if (name.length <= 255) { const dotSegments = name.split('.'); for (let i = 1; i < dotSegments.length; i++) { classes.push(`${dotSegments.slice(i).join('.')}-ext-file-icon`); // add each combination of all found extensions if more than one } </ins> } classes.push(`ext-file-icon`); // extra segment to increase file-ext score }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.53.0 (commit id: ) OS Version: Ubuntu 20.04.2 LTS (Kernel: Linux 5.4.0-65-generic) I stumbled upon this bug by accident when I had the contents of some large file in my clipboard and (not realizing I had these file contents in the clipboard) when I pasted it in the filename of the file explorer of VSCode, it became unresponsive to the point I had to force kill it. In my opinion it is not very critical, not many people with encounter this issue, it was just surprising that my vscode became unresponsive due to this. I tried to locate the source of the issue in the code, but I couldn't find it myself. Steps to Reproduce: a directory in VSCode such that you have some file existing in the Explorer some filename with many dots to the clipboard. I use for this the file and click rename , followed by to paste the string vscode is unresponsive for more than 30 seconds, after which I force kill it. I found out that when you would paste 100.000 characters without using dots (i.e. ), then VSCode responds very quickly and lets me know the filename is invalid. Since the maximum allowed length of a filename is 255 characters, I think it would suffice to limit the filename to 255 characters before any further parsing is done. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes /
I can reproduce. Looks like the -function is causing this. <img width="734" alt="Screenshot 2021-02-09 at 16 17 22" src="https://user-"
my "fill clipboard snippet" is this . Open dev-tools, paste and run, and within the 3sec focus the content window
Since it happens inside the method, like something that was around here:
I'll take a look at this
Still quite slow but not freezing anymore
Change:
})); this._register(this._editor.onMouseDown(async (e: IEditorMouseEvent) => { <del> const lightbulbClasses = [ 'codicon-' + GUTTER_LIGHTBULB_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_ICON.id, 'codicon-' + GUTTER_SPARKLE_FILLED_ICON.id ]; if (!e.target.element || !lightbulbClasses.some(cls => e.target.element && e.target.element.classList.contains(cls))) { </del> <ins> if (!e.target.element || !this.lightbulbClasses.some(cls => e.target.element && e.target.element.classList.contains(cls))) { </ins> return; }

Discussion:
The icon should be right above line 2, but it's all the way up at the beginning of line 1. !
this should be fixed with the new lightbulb changes!
Still able to reproduce this. long text and enable word wrap the cursor on line 2 and press Ctrl + . ! ESC Ctrl + . again !
Still able to repro. If I repeat steps 3 and 4, I notice that the sparkle alternates between the two lines. Edit: might have to wait for new Insiders.
I see similar to what saw, but the second time it didn't show at all: ! ! I'll push this to September as it doesn't meet the bar to fix at this point imo.
not sure why it removed the unreleased since this commit hasn't been released yet
It's good now
Change:
private _terminals: ExtHostTerminal[] = []; private _terminalProcesses: { [id: number]: TerminalProcess } = {}; private _terminalRenderers: ExtHostTerminalRenderer[] = []; <ins> private _getTerminalPromises: { [id: number]: Promise<ExtHostTerminal> } = {}; </ins> public get activeTerminal(): ExtHostTerminal { return this._activeTerminal; } public get terminals(): ExtHostTerminal[] { return this._terminals; }

Discussion:
Verification steps?
Verification Steps: Create an extension with this command: (vscode.commands.registerCommand('terminalTest.createAndSend', () ={ const terminal = (); if((<anyterminal).onDidWriteData) { (<anyterminal).onDidWriteData(data ={('Hello World!');}); } terminal.sendText("echo 'Sent text immediately after creating'"); })); When you execute the command, confirm that the 'Hello World!' info message shows. Do this five or so more times since this is a race condition.
Change:
decreaseIndentPattern: /^((?!.*?/*).**/)?s*[}]].*$/, increaseIndentPattern: /^((?!//).)*({([^}"'`]*|(t|[ ])*//.*)|([^)"'`]*|[[^]"'`]*)$/, // e.g.  * ...| or */| or *-----*/| <del> unIndentedLinePattern: /^(t|[ ])*[ ]*[^/]**/s*$|^(t|[ ])*[ ]*/s*$|^(t|[ ])*[ ]*([ ]([^*]|*(?!/))*)?$/ </del> <ins> unIndentedLinePattern: /^(t|[ ])*[ ]*[^/]**/s*$|^(t|[ ])*[ ]*/s*$|^(t|[ ])*[ ]*([ ]([^*]|*(?!/))*)?$/, indentNextLinePattern: /^.*=>s*$/, </ins> };

Discussion:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have: