jiebi/CodeConvo huggingface dataset:
Change:
onKeyUp(tree: ITree, event: Keyboard.IKeyboardEvent): boolean; /** <ins> * Called when a mouse middle button is pressed down on an element. */ onMouseMiddleClick?(tree: ITree, element: any, event: Mouse.IMouseEvent): boolean; /** </ins> * Called when a mouse button is pressed down on an element. */ onMouseDown?(tree: ITree, element: any, event: Mouse.IMouseEvent): boolean;

Discussion:
VSCode Version: Version: 1.27.1 (user setup) Commit: Date: 2018-09-06T09:21:18.328Z Electron: 2.0.7 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 Architecture: x64 OS Version: Windows 10 Pro 64-bit (10.0, Build ) Steps to Reproduce: click item in explorer icon appear ! If you open developers tools works as expected Does this issue occur when all extensions are disabled?: Yes/No Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.478 --- <!-- score: 0.463 --<!-- potentialduplicatescomment --
Hmm strangely I am no longer getting a event when I do a middle mouse click This nicely works in stable. I see we use a different electron 2.0.9 compared to 2.0.7 but not sure if that update includes something which would influence this. Also the middle click nicely works in the tabs title area - how are you handling it there? did we change something in the tree which might effect this?
yeah see I removed  to prepare for Electron 3.0.x. We should probably wire this into the tree so that people can react to it ("onMiddleClick"). Simply forwarding the was resulting in other issues.
ok so the tree should still listen on events but bobble them up in a different way ? I can create a PR for this and you review?
yeah, the thing is, middle-click should not trigger the click, otherwise we might get wrong behaviour where people do not expect middle-click to do anything. Instead we can check clients of the tree (and list?) that want to do something on middle click and update them accordingly. Otherwise every client has to do an extra check for which mouse button was used for click.
currently the only clients of the tree that check something on middle click are explorer and quick open . For the list they are open editors view and the breakpoints view, however this still works for the breakpoints view and does not work for the open editors due to
Change:
return -1; } else if (!a.action.isPreferred && b.action.isPreferred) { return 1; <ins> } else if (a.action.isAI && !b.action.isAI) { return 1; } else if (!a.action.isAI && b.action.isAI) { return -1; </ins> } else { return 0; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Have multiple quick fixes in a line, enabled. that AI quick fixes are above other quick fixes. !
Change:
<key>comment</key> <string>Automatic variables - read-only.</string> <key>match</key> <del> <string>($)(?i:(_|args|consolefilename|error|event|eventsubscriber|executioncontext|false|foreach|home|host|input|lastexitcode|matches|myinvocation|nestedpromptlevel|null|pid|psboundparameters|pscmdlet|psculture|psdebugcontext|pshome|psitem|psscriptroot|psuiculture|psversiontable|pwd|sender|shellid|sourceargs|sourceeventargs|switch|this|true))b((.[w"']+)*)</string> </del> <ins> <string>($)(?i:(_|args|consolefilename|error|event|eventsubscriber|executioncontext|false|foreach|home|host|input|lastexitcode|matches|myinvocation|nestedpromptlevel|null|pid|psboundparameters|pscmdlet|psculture|psdebugcontext|pshome|psitem|psscriptroot|psuiculture|psversiontable|pwd|sender|shellid|sourceargs|sourceeventargs|switch|this|true))b((.[w"'- @#]+)*)</string> </ins> </dict> <dict> <key>captures</key>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
} function compareVisibleRanges(a: EditorBrowser.IVisibleRange, b: EditorBrowser.IVisibleRange): number { <del> if (a.top === b.top) { return a.left - b.left; } return a.top - b.top; </del> <ins> return a.left - b.left; </ins> } function findIndexInArrayWithMax(lineParts:ILineParts, desiredIndex: number, maxResult:number): number {

Discussion:
open a markdown file with bold markup, e.g. abc text xyz try to select the line with the mouse starting at 'abc' and slowly extending to 'xyz' Observe: if you reach the second '', the selection of 'text**' disappears. In the end you have two disconnected selection ranges. in addition I see lots of flashing selection changes while dragging the mouse
Change:
left: 45px; } <ins> .monaco-workbench > .welcomeOverlay > .key.notifications { position: absolute; bottom: 25px; right: 16px; } </ins> .monaco-workbench > .welcomeOverlay > .key.problems > .label, <del> .monaco-workbench > .welcomeOverlay > .key.problems > .shortcut { </del> <ins> .monaco-workbench > .welcomeOverlay > .key.problems > .shortcut, .monaco-workbench > .welcomeOverlay > .key.notifications > .label, .monaco-workbench > .welcomeOverlay > .key.notifications > .shortcut { </ins> vertical-align: super; }

Discussion:
On this one: ! Could put another arrow bottom right to point to notifications location.
PR via
Great, thanks!
Change:
} public getColor(colorId: ColorIdentifier, useDefault?: boolean): Color | undefined { <del> let color: Color | undefined = this.customColorMap[colorId]; if (color) { return color; </del> <ins> const customColor = this.customColorMap[colorId]; if (customColor instanceof Color) { return customColor; } if (customColor === undefined) { /* !== DEFAULT_COLOR_CONFIG_VALUE */ const color = this.colorMap[colorId]; if (color !== undefined) { return color; } </ins> } <del> color = this.colorMap[colorId]; if (useDefault !== false && types.isUndefined(color)) { color = this.getDefault(colorId); </del> <ins> if (useDefault !== false) { return this.getDefault(colorId); </ins> } <del> return color; </del> <ins> return undefined; </ins> } private getTokenStyle(type: string, modifiers: string[], language: string, useDefault = true, definitions: TokenStyleDefinitions = {}): TokenStyle | undefined {

Discussion:
From Add to setting See that the editor background changes to the 'default' gray color Comment or delete the setting The background color doesn't change back to the theme color, and I can't make it go back until reloading the window
Change:
protected _onDidDynamicOutputRendered = new Emitter<{ cell: IGenericCellViewModel, output: ICellOutputViewModel }>(); onDidDynamicOutputRendered = this._onDidDynamicOutputRendered.event; <del> private _localStore: DisposableStore = this._register(new DisposableStore()); </del> <ins> private readonly _localStore = this._register(new DisposableStore()); </ins> private _isDisposed: boolean = false;

Discussion:
Issue Type: <bBug</bRepro a notebook in the diff view (tested with the github issues notebook) down to another file bug In dev tools, see: VS Code version: Code - OSS Dev 1.55.0 (Commit unknown, Date unknown) OS version: Darwin x64 20.3.0 <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ docs-view0.0.9 vscode-eslint2.1.14 EditorConfig0.16.4 vscode-pull-request-github0.23.1 svg1.4.5 template-string-converter0.4.7 git-graph1.29.0 vscode-language-pack-de1.54.1 vscode-dotnet-runtime1.0.0 vscode-edge-devtools1.1.3 python2021.2. jupyter2021.3. remote-containers0.163.0 remote-ssh0.64.0 remote-ssh-edit0.64.0 azure-account0.9.6 cpptools1.2.2 hexeditor1.4.0 vscode-github-issue-notebooks0.0.68 vscode-markdown-notebook0.0.14 debugger-for-chrome4.12.12 debugger-for-edge1.0.15 shader-toy0.10.15 </details<!-- generated by issue reporter --
I believe that webviews in diff editors are being leaked at the moment. For normal notebooks, I see the webview disposed of in the method: However I don't see the same in notebookTextDiffEditor
Hm, now I'm just more confused. It seems the webviews are not disposed of when the diff editor is closed (and is not fired on the either). However they are disposed of when another notebook diff editor is opened The root cause of this issue is that the webview is no longer in the dom but it also isn't disposed. We then try posting a message to it which causes an exception. Here's the call stack that triggers this error: !
I started to see leaks of recently, which is likely a regression, and probably in the logic.
Change:
protected _getFormattingEdits(editor: ICodeEditor, token: CancellationToken): Promise<ISingleEditOperation[]> { const model = editor.getModel(); <ins> let selection = editor.getSelection(); if (selection.isEmpty()) { const maxColumn = model.getLineMaxColumn(selection.startLineNumber); selection = selection.setStartPosition(selection.startLineNumber, 1); selection = selection.setEndPosition(selection.endLineNumber, maxColumn); } </ins> const { tabSize, insertSpaces } = model.getOptions(); <del> return getDocumentRangeFormattingEdits(model, editor.getSelection(), { tabSize, insertSpaces }, token); </del> <ins> return getDocumentRangeFormattingEdits(model, selection, { tabSize, insertSpaces }, token); </ins> } protected _notifyNoProviderError(notificationService: INotificationService, language: string): void {

Discussion:
VSCode Version: 1.7.1 OS Version: 10.12.1 Steps to Reproduce: cursor on a line without selecting a range Format Selection with keyboard shortcut It would be nice if the current line is formatted instead of having to select the whole current line first.
I like the feature (format line) but I am not so sure if this should be automagic or explicit.
Change:
} else { // let user pick a snippet <del> resolve(this._pickSnippet(snippetService, quickInputService, languageId)); </del> <ins> resolve(instaService.invokeFunction(pickSnippet, languageId)); </ins> } });

Discussion:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.
Change:
resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-7.0.1.tgz#8118a32b02735dccd14f893b495fa5389ad7de79" integrity sha512-zQ5U/nuXAAMsh691FtV0wPz89nSkHbs+IQV8FDk+wew9BlSDhf4UmWGlWJfTR2Ti6xZv87Tj5fENzKf6Qk7aLw== <del> xterm-addon-search@0.10.0-beta.1: version "0.10.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.1.tgz#ee15b954b6f78585cd3a212ec662018263470266" integrity sha512-rp68SwoYHIQ1SY4MoILNK+0HcN8OR4hzczHOYCFdeKYZFvH/16vgqg0OJT6t6WlL1cq971rLsEDXT1SKcpoJqA== </del> <ins> xterm-addon-search@0.10.0-beta.2: version "0.10.0-beta.2" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.2.tgz#a937d1e9a70fde8eeb7d1df485039b2d5fc1d707" integrity sha512-ybafAbX9V4sfkzmUsWmtfEYExG8jj73bTF9pEa/Lhd5q4bviW4LcFaw/n3lKHn/1tSgSVgzoD13u1ZaZR78SfQ== </ins> xterm-addon-unicode11@0.4.0-beta.3: version "0.4.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.13.0-beta.3: version "0.13.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.3.tgz#2b456c3105238e64b40a30787d6335f5f6f85abb" integrity sha512-DFGcXAolA0VTsOLIKcORxUOp/FTJdD/YiRzKVLARjgOycwVRKvW2L5Tge8Z7ysZ16sKfnV2vCXyonXYfUWozXw== </del> <ins> xterm-addon-webgl@0.13.0-beta.6: version "0.13.0-beta.6" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.6.tgz#44eceb1e15a711159bdf1c2a779422aa11becabc" integrity sha512-83bo12rqYU04agC6rn+drEui8tarN5Ev66sdu86aGzxM+Ylr8wFqIb/Px/caX9qTqO79TN80ID7EC5P5QyL8XA== </ins> <del> xterm@4.20.0-beta.6: version "4.20.0-beta.6" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.20.0-beta.6.tgz#3ed87ba383a5cf44284098278f714df7113e3e3c" integrity sha512-xJd6vyOuYo4Ht/hTY3DyXGIj0U6kHjr2vWQ1lRmearo3t7QKf7uqOAAfTLeWt/g1P8qe/r0DnsNTeag6vI9RVw== </del> <ins> xterm@4.20.0-beta.12: version "4.20.0-beta.12" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.20.0-beta.12.tgz#02751473b307d6795e6f47abf6798993128a84b7" integrity sha512-6bqZshNOJsghzQ5f52JIPrZL8MPGW+caQkeQ3aoAPleGvZz775LDQAQH2KzdR9XxOJI5wnJcxx+dk7IjulCsnw== </ins>

Discussion:
issue This bad overlapping can occur sometimes: <img width="84" alt="Screen Shot 2022-07-07 at 10 58 29 am" src="https://user-"I think this is because the white pixels don't match the background exactly but are close enough to it that they should be treated as transparent. cc Related:
can you verify?
Not a problem.
Change:
import { compare } from '../../../../base/common/strings.js'; import { IClipboardService } from '../../../../platform/clipboard/common/clipboardService.js'; import { getDefaultHoverDelegate } from '../../../../base/browser/ui/hover/hoverDelegateFactory.js'; <ins> import { IStorageService, StorageScope, StorageTarget } from '../../../../platform/storage/common/storage.js'; </ins> const PICK_REPOSITORY_ACTION_ID = 'workbench.scm.action.graph.pickRepository'; const PICK_HISTORY_ITEM_REFS_ACTION_ID = 'workbench.scm.action.graph.pickHistoryItemRefs';

Discussion:
Type: <bBug</bspecific branches to display on the graph (in my case main, origin/main and upstream/main). VS Code, or close and reopen the workspace. has reverted to 'Auto' VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-11T05:04:03.124Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
even if you move away from the source control tab and come back it is changed back to auto.
I'm not seeing that happen on today's Insiders.
ohh, may be i am on different version than you. (i do not see a pending update though) Version: 1.94.0-insider Commit: Date: 2024-09-11T05:04:03.124Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
Change:
} constructor(id: string, label: string, private _actions: IAction[], cssClass?: string) { <del> super(id, label, cssClass, true); </del> <ins> super(id, label, cssClass, !!_actions?.length); </ins> } }

Discussion:
Related to If you have a command in an action bar (say in ) that is a submenu with no items (or no visible items), there is no visible indication -- the icon is there, but does nothing if you click on it. I would expect similar behavior to
Change:
} } <del> private _onDidChangeExtensions(added: ReadonlyArray<IExtension>, removed: ReadonlyArray<IExtension>): void { </del> <ins> private _onDidChangeExtensions(added: ReadonlyArray<IExtension>, removed: ReadonlyArray<IExtension>, isProfileSwitch: boolean): void { </ins> const disabledExtensions = added.filter(e => !this.isEnabledEnablementState(this.getEnablementState(e))); if (disabledExtensions.length) { this._onEnablementChanged.fire(disabledExtensions); } <del> removed.forEach(({ identifier }) => this._reset(identifier)); </del> <ins> if (!isProfileSwitch) { removed.forEach(({ identifier }) => this._reset(identifier)); } </ins> } public async updateExtensionsEnablementsWhenWorkspaceTrustChanges(): Promise<void> {

Discussion:
VS Code Version: stable 1.74.0 OS Version: Windows 11 Build .900 Feature: Settings Profiles (Profiles) When certain Extensions that I had disabled for the active profile automatically update, they get re-inserted (re-enabled) in my Extensions list for that profile, and will remain there from that point onwards. I've noticed this with all the "C++" extensions from Microsoft, as well as the "Remote Explorer", and "Remote - SSH" also from Microsoft, but this might be happening with other extensions as well. Even if I disable them again for that profile, they'll come back the next time they update Steps to Reproduce: Profiles feature by setting the to true. the C++ from Microsoft on the default profile. a new profile "A" other than default, disable the C++ extension. a second profile "B" but enable the C++ extension. a third profile "C" following step 2. to either A or C profile. vscode, reopen it on the same folder, and wait for the C++ extension to update (I'm not aware of any means to force an extension update besides creating one myself). You'll notice that once the C++ extension update, it will re-enable automatically on both profiles A and C, and will remain there even after re-starting vscode, until you disable it again. In which case it will reappear again once it updates.
How did you force the extension update? Can you please share your profiles (you can use profile export feature) so that I can reproduce?
Hi as mentioned in the issue, I did not force the update since I'm not aware of any means to do that, I just waited for extensions to update. By the way I also noticed this happening with a non-Microsoft extension called "Better C++ Syntax" How can I share the profiles with you in a non-public manner?
You can export the profile to a file or github gist and share it with me via email -
Done. Hope that can solve it since it keeps happening. Thank you
Why is this still labelled as info-needed?
is there a way to simulate the extension update that is needed to reproduce the issue?

Yeah there is, but its a lengthy one: Please open extensions installation folder and the folder where profiles are stored that is user data folder/User/profiles Quit VS Code Change the name of the extension in the extensions installation folder and also the version in the Update the name and version in file in all profiles include the file in extension installation folder.
Change:
import 'vs/css!./bulkEdit'; import { WorkbenchAsyncDataTree, IOpenEvent } from 'vs/platform/list/browser/listService'; <del> import { BulkEditElement, BulkEditDelegate, TextEditElementRenderer, FileElementRenderer, BulkEditDataSource, BulkEditIdentityProvider, FileElement, TextEditElement, BulkEditAccessibilityProvider, CategoryElementRenderer, BulkEditNaviLabelProvider, CategoryElement, BulkEditSorter } from 'vs/workbench/contrib/bulkEdit/browser/preview/bulkEditTree'; </del> <ins> import { BulkEditElement, BulkEditDelegate, TextEditElementRenderer, FileElementRenderer, BulkEditDataSource, BulkEditIdentityProvider, FileElement, TextEditElement, BulkEditAccessibilityProvider, CategoryElementRenderer, BulkEditNaviLabelProvider, CategoryElement, BulkEditSorter, compareBulkFileOperations } from 'vs/workbench/contrib/bulkEdit/browser/preview/bulkEditTree'; </ins> import { FuzzyScore } from 'vs/base/common/filters'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IThemeService } from 'vs/platform/theme/common/themeService';

Discussion:
Testing With all the files in the multi-diff editor collapsed to make it easy to see: ! To repro, try to rename this:
I see, that's a good point thanks!
To verify: Do a rename but do not accept rename Click on The refactor preview should open Open the multi diff editor from there by clicking on any change in the refactor preveiw Check that the order of the files in the refactor preview matches the order of the files in the multi diff editor
Change:
private readonly _cache: MdDocumentInfoCache<TableOfContents>; constructor( <del> parser: IMdParser, </del> <ins> private readonly parser: IMdParser, </ins> workspace: IMdWorkspace, private readonly logger: ILogger, ) {

Discussion:
Repro a notebook with the following markdown cells: still in edit mode, Try clicking on Bug Nothing happens Clicking on works since the header is within the same cell
Change:
} private onConfigurationChanged(e: ConfigurationChangeEvent) { <del> if (e.affectsConfiguration('git.timeline.date') || e.affectsConfiguration('git.timeline.showAuthor')) { </del> <ins> if (e.affectsConfiguration('git.timeline.date') || e.affectsConfiguration('git.timeline.showAuthor') || e.affectsConfiguration('git.timeline.showUncommitted')) { </ins> this.fireChanged(); } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --A feature called Local History has been to show entries such as "File Saved" and "Undo/Redo" in the timeline of a file. Simultaneously, an item called "Uncommitted changes" has been removed apparently in I found the "Uncommitted changes" item very useful to quickly see the changes of a file since the last version. Current implementation with the local history feels unconvenient and does not reveal the same information as the previous Uncommited changes item did. It also compares the file with the current version on the disk and not the changes between the two versions (version in previous commit vs. saved version). So I would like to have a possibility to configure the timeline so that the previous behaviour showing the Uncommitted changes is restored.
cc I think it is reasonable to bring back the uncommitted changes when local history is disabled.
I second this!
Opened PR to have a setting for this. I do not think making this conditional on which timeline provider is showing is clever.
A new setting allows to enable this starting in tomorrows insider build.
Wow! That's great, thanks
/verified