jiebi/CodeConvo huggingface dataset:
Change:
id: 'workbench.action.toggleSharedProcess', title: { value: localize('toggleSharedProcess', "Toggle Shared Process"), original: 'Toggle Shared Process' }, category: Categories.Developer, <ins> precondition: ContextKeyExpr.has('config.window.experimental.sharedProcessUseUtilityProcess').negate(), </ins> f1: true }); }

Discussion:
Testing nothing in the dev tools console indicates there's an issue though
I think a good fix would be to not show the action when utility process is used. But there is no counter part unfortunately.
Change:
import { ICredentialsService } from 'vs/platform/credentials/common/credentials'; import { IUserDataProfileService } from 'vs/workbench/services/userDataProfile/common/userDataProfile'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> export class ViewContainerActivityAction extends ActivityAction {

Discussion:
Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !
This still reproduces
does this still repro? maybe its imperceptible to me?
Yeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?
looks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately
Yeah that seems like a reasonable ask since it goes to the extension host and back, today.
This issue has existed since 2 years! But only recently have I encountered this.
Change:
value: localize('selectEditor.title', "Select Editor"), original: 'Select Editor' }, <del> precondition: ContextKeyExpr.has('config.editor.stickyScroll.enabled'), </del> <ins> precondition: EditorContextKeys.stickyScrollFocused.isEqualTo(true), </ins> keybinding: { weight, primary: KeyCode.Escape

Discussion:
enable sticky scroll select something in the editor select :bug: the selection isn't cleared enable keybindings debug mode (F1 Toggle Keyboard Shortcuts Troubleshooting) see that sticky scroll is consuming ESC
Change:
if (uri instanceof URI && iconClasses && iconClasses.length > 1) { css += ( `.monaco-workbench .terminal-tab.${iconClasses[0]}::before` + <del> `{background-image: ${dom.asCSSUrl(uri)};}` </del> <ins> `{content: ''; background-image: ${dom.asCSSUrl(uri)};}` </ins> ); } if (ThemeIcon.isThemeIcon(icon)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.1 OS Version: Steps to Reproduce: the icon theme a terminal with the function from the VS Code API, setting the to a file. the terminal into the editor area Example: ! The extension defined (!).
Change:
.map(([ref]) => ({ name: ref, type: RefType.Head } as Branch)); } <del> async getRefs(): Promise<Ref[]> { const result = await this.run(['for-each-ref', '--format', '%(refname) %(objectname)', '--sort', '-committerdate']); </del> <ins> async getRefs(sortBranchListByCommitterDate?: Boolean): Promise<Ref[]> { const args = ['for-each-ref', '--format', '%(refname) %(objectname)']; if (sortBranchListByCommitterDate) { args.push('--sort'); args.push('-committerdate'); } const result = await this.run(args); </ins> const fn = (line: string): Ref | null => { let match: RegExpExecArray | null;

Discussion:
I agree that sometimes it is more useful to but I often feel that it makes it hard to find branches when a naming scheme like "user/feature" is used and I want to quickly find all branches of a user. Even without that scheme there are good reasons why having an alphabetical sort option makes sense, if only for personal preference. To avoid a religious discussion, could the sort order be made into a config option?
, working on this :)
Change:
<key>function</key> <dict> <key>begin</key> <del> <string>((?i:function|filter|configuration|workflow))s+((?:p{L}|d|_|-|.)+)</string> </del> <ins> <string>(?&lt;!S)(?i)(function|filter|configuration|workflow)s+(?:(global|local|script|private):)?((?:p{L}|d|_|-|.)+)</string> </ins> <key>beginCaptures</key> <dict> <key>0</key>

Discussion:
Support rendering text decorations in the minimap, beginning with search results. We can add a new option to decorations, similar to in : The new optional property could look like: The find widget can then set this property for its decorations, and the minimap can read the decorations from its text model.
Change:
export interface IInteractiveHistoryService { readonly _serviceBrand: undefined; <ins> matchesCurrent(uri: URI, value: string): boolean; </ins> addToHistory(uri: URI, value: string): void; getPreviousValue(uri: URI): string | null; getNextValue(uri: URI): string | null;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --four cells from the interactive window input box, e.g. , , , reexecute multiple commands from earlier in your history, e.g. and use via the up arrow executing an entry from earlier in the history e.g. , scroll position resets to the bottom of the history, and you have to start over and scroll up from the most recent command (4 -3 - 2 -1). This can be frustrating for users who are trying to reexecute multiple commands. Note also that the original interactive window used to preserve your scroll history in the interactive window so that you didn't have to scroll back up through the entire history, and users have complained about this behavior change:
The expectation is that the interactive window input behaves just like a REPL. would address this. Per discussion with we should have shared logic for handing history traversal.
Any news on that? I agree with the PR that the current behavior is quite frustrating and deserves further attention.
Yes this is one of my main frustrations with the IW still. At minimum I just want the up arrow to go to the last executed code, not have cycle through like 20 cells every time I need to re-run something. And it did used to work this way ~1.5 yrs ago.
Change:
{ "name": "code-oss-dev", "version": "1.75.0", <del> "distro": "a5977ac9b92626eb2c6b237b3ca477340f1b0041", </del> <ins> "distro": "3c5c71a67992945ba1fe6235d907efcd65303f6b", </ins> "author": { "name": "Microsoft Corporation" },

Discussion:
OS Version: Ubuntu 22.04 LTS + Xfce 4.16 When create desktop icon, it shows generic icon instead of VSCode icon. ! When I tried to dig deeper, I observed that, the icon file is saved with name inside directory. The issue is occurring because of the file name. If I simply rename the file name to , then it works. So, adding multiple extension causes the issue. !
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
This works in most desktop managers, we'd want to verify it still works in ubuntu + gnome
Seems an easily fixable bug which hits xfce4 specifically: it can't handle 's in path.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
if (focus) { const selection: Array<IEditorIdentifier | IEditorGroup> = list.getSelectedElements().filter(onlyEditorGroupAndEditor); <del> if (selection.length > 0) { </del> <ins> if (selection.length > 1) { </ins> return selection.map(elementToContext); }

Discussion:
Type: <bBug</bOn the right panel, where the opened files are listed, when you have a file selected and hover on another file it appears a close(x) icon, if you click that (x) the editor window that is closed is the file that is selected and not the file where you clicked (x). I keep repoen closed editor because of this recent issue. VS Code version: Code 1.82.2 (Universal) (, 2023-09-14T05:59:47.790Z) OS version: Darwin arm64 22.1.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (61)</summaryExtensionVersion ------ better-comments3.0.2 alpine-js-intellisense1.2.0 laravel-extra-intellisense0.6.3 sidebar-markdown-notes1.2.0 laravel-blade-spacer2.1.3 laravel-docs1.10.0 tailwind-docs2.1.0 vscode-intelephense-client1.9.5 vscode-tailwindcss0.10.0 vscode-coloured-status-bar-problems0.2.0 vscode-better-align1.4.2 laravel-goto-view1.3.9 save-commands0.5.1 vscode-notes1.1.0 githistory0.6.20 gitlens14.3.0 vscode-html-css1.13.1 prettier-vscode10.1.0 restore-terminals1.1.8 php-intellisense2.3.14 auto-rename-tag0.1.10 code-runner0.12.0 vscode-google-translate1.4.13 html-preview-vscode0.2.5 copilot1.113.423 copilot-chat0.7.1 copilot-labs0.15.1019 gitlab-workflow3.77.1 githd2.3.3 vscode-peacock4.2.2 vscode-inline-svg0.9.4 rainbow-csv3.7.1 php-namespace-resolver1.1.9 git-graph1.30.0 dotenv1.0.1 theme-monokai-pro-vscode1.2.1 empty-directory-extension0.0.6 test-adapter-converter0.1.8 resourcemonitor1.0.

7 laravel-goto-components1.2.0 sftp1.16.3 vscode-configurable-shortcuts1.0.3 laravel-blade1.34.0 laravel5-snippets1.17.0 material-icon-theme4.30.1 vscode-thunder-client2.12.0 vscode-yaml1.14.0 laravel-artisan0.0.31 vue-vscode-snippets3.1.1 vscode-blade-formatter0.23.1 svg-preview2.8.3 vscode-fileutils3.10.3 git-prefix1.3.1 workspace-explorer2.3.0 luna-paint0.16.0 remove-empty-lines1.0.1 vscode-icons12.5.0 volar1.8.11 vscode-typescript-vue-plugin1.8.11 vuetify-vscode0.2.0 php-debug1.33.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/gifPlease
Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, files are preferred as they are displayed inline on GitHub. You may find helpful as a browser-based gif recording tool. If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording ( in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue. Happy coding!
Sure. !
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from:
Bisecting shows that is the trouble. It reproduces easily when you have focus in an open editor and click X on another editor.
Change:
const searchChangeEvent = new Emitter<string>(); this.onSearchChange = searchChangeEvent.event; <ins> let existingContent = this.searchBox.getValue().trim(); </ins> this.disposables.push(this.searchBox.getModel().onDidChangeContent(() => { <ins> this.placeholderText.style.visibility = this.searchBox.getValue() ? 'hidden' : 'visible'; let content = this.searchBox.getValue().trim(); if (existingContent === content) { return; } </ins> this.triggerSearch(); <del> const content = this.searchBox.getValue(); </del> searchChangeEvent.fire(content); <del> this.placeholderText.style.visibility = content ? 'hidden' : 'visible'; </del> <ins> existingContent = content; </ins> })); return super.create(this.extensionsBox)

Discussion:
Steps to Reproduce: issue reporter extension view. spaces in the extension search box, one ever half second or so. Make sure the progress bar is showing when you type the next space switch focus back to issue reporter and click on an input box Bug Issue reporter freaks out and starts inserting endless spaces (almost like it has a stuck key) ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No

Testing Issue Type: <bBug</bextension search box. type every half second or so (make sure the progress bar is showing when you type the next space) Bug After five or more spaces, the entire VS Code UI starts hanging for a few seconds VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:12:08.688Z) OS version: Darwin x64 17.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Are you able to reproduce this reliably? I've never gotten it on Windows but I did manage once on macOS, even then it only stalled the extensions viewlet UI, rest was fine. Its just pressing space as the search triggers right?
Can we not skip the search if () === () ?
We can do that. But what if they hit 'a' a bunch? can you repro this in stable?
No, I didn’t see this in stable when typing spaces. I also don’t remember being able to reproduce this with other characters, such as typing “a” many times
Then we can probably get away with just debouncing the trimmed value
Let's do that to begin with
Change:
// Delete any existing backups completely and then re-create it. await pfs.rimraf(backupHome, pfs.RimRafMode.MOVE); await pfs.mkdirp(backupHome); <ins> await pfs.mkdirp(workspaceBackupPath); </ins> return pfs.writeFile(workspacesJsonPath, ''); });

Discussion:
This is not a failure but error output when running the tests: I feel this could be a result from the environment service change you did. Bounce back to me if not.
I investigated and do not understand how the environment service changes caused this, but it seems there is no error handling while writing into back up as a result above uncaught errors are shown. Digging more deeper, backup tracker test is not waiting until back up task is finished which is triggered by the test and removing the backup folder in tear down. Created a PR that takes care of error handling in backup tracker - If there is a better fix, please ignore the PR and push the fix.
Change:
if (noLinkRanges.contains(hrefRange.start)) { continue; } <del> const target = parseLink(document, text); </del> <ins> const target = resolveLink(document, text); </ins> if (target) { yield { kind: 'definition',

Discussion:
while testing a markdown file with a header a notebook with a markdown cell and link to that header the link in the rendered markdown result: vscode attempts to navigate to a file named note that both auto-complete and find references for the header work correctly for that link.
Change:
super({ id: 'workbench.action.increaseViewWidth', title: { value: localize('increaseEditorWidth', "Increase Editor Width"), original: 'Increase Editor Width' }, <del> f1: true </del> <ins> f1: true, precondition: IsAuxiliaryWindowFocusedContext.toNegated() </ins> }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 x64 OS Version: Steps to Reproduce: a new floating window with (or any of the other ones) a few split editors in the main view and the floating view a split in floating window the floating view, execute floating window editor size doesn't change, it happens in the main one
Good catch, these commands should not be available in floating windows.
Change:
), primary: KeyCode.DownArrow, weight: KeybindingWeight.EditorCore <del> } </del> <ins> }, { when: NOTEBOOK_EDITOR_FOCUSED, primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, }, weight: KeybindingWeight.WorkbenchContrib }, </ins> ] }); }

Discussion:
suggested would be good for this
FYI, I have customized like below:
feel free to close if we already support this now.
We do not have a default keybinding that works along with the screen reader being enabled, though ctrl+pagedown/pageup are currently bound to next/previous editor, so I don't think we can use that one without breaking current workflows.
Maybe ctrl+alt+pagedown/pageup?
Change:
CommandsRegistry.registerCommand({ id: SELECT_AND_START_ID, <del> handler: async (accessor: ServicesAccessor) => { </del> <ins> handler: async (accessor: ServicesAccessor, debugType: string | unknown) => { </ins> const quickInputService = accessor.get(IQuickInputService); <ins> const debugService = accessor.get(IDebugService); if (debugType) { const configManager = debugService.getConfigurationManager(); const dynamicProviders = await configManager.getDynamicProviders(); for (const provider of dynamicProviders) { if (provider.type === debugType) { const pick = await provider.pick(); if (pick) { await configManager.selectConfiguration(pick.launch, pick.config.name, pick.config, { type: provider.type }); debugService.startDebugging(pick.launch, pick.config, { startedByUser: true }); return; } } } } </ins> quickInputService.quickAccess.show(DEBUG_QUICK_ACCESS_PREFIX); } });

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Running will prompt the dialog and prompt for all dynamic configuration debuggers. ! It will be helpful for extensions if we can run the command with an arg so it will call into a specific debugger's dynamic configuration provider. E.g. This just jump directly to !
This works well if there's one launch config, but if there's multiple with the same type, it seems to go back to the view with all the options instead of filtering to that type.
What do you mean by "multiple with the same type"? The first level is debuggers, not launch configs
Change:
"displayName": "Grunt support for VS Code", "config.grunt.autoDetect": "Controls whether auto detection of Grunt tasks is on or off. Default is on.", "grunt.taskDefinition.type.description": "The Grunt task to customize.", <ins> "grunt.taskDefinition.args.description": "Command line arguments to pass to the grunt task", </ins> "grunt.taskDefinition.file.description": "The Grunt file that provides the task. Can be omitted." <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --I'd like to provide my grunt tasks with a single argument but the VSCode task system doesn't support arguments for grunt tasks. I was shocked to discover this because I rarely have grunt tasks without arguments. I can of course work around this issue by using the "shell" task type to run grunt with arguments. Here's . <!-- Describe the feature you'd like. --
Starting pointer:
I would like to work on this. Can I start if no one else is on it ?
thank you, go for it! If you could make a sample repo to test out your change and link it here when you make a PR that would help me review your PR faster :)
To verify, use the from the PR to test.
Change:
}; } <ins> private createCopyCommandLabelAction(keybinding: IKeybindingItemEntry): IAction { return <IAction>{ label: localize('copyCommandLabelLabel', "Copy Command Label"), enabled: true, id: KEYBINDINGS_EDITOR_COMMAND_COPY_COMMAND_LABEL, run: () => this.copyKeybindingCommandLabel(keybinding) }; } </ins> private reportFilteringUsed(filter: string): void { if (filter) { const data = {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently, for copying a command like on the "Keyboard Shortcuts" page, there're two options: Copies Command ID Copies But really, quite often, we just want to copy , and there's no option for that. Therefore, I'm making a feature request for it.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.526 --- <!-- score: 0.46 --- <!-- score: 0.447 --<!-- potentialduplicatescomment --
Hey I see this is assigned to you, I opened a PR to address this. It is my 1st PR so any constructive feedback would be appreciated ;-)
I hope this works for you? :smile_cat:
Sorry for the late response, but I don't know how to test this though.
Planning to look at this PR in July milestone.
Thanks for the PR - I did some small fine tunings after. !
To verify: Open Keyboard Shortcuts editor Right click on an entry and make sure you have an action to copy the command title Make sure this action works as expected
Change:
const lineAndColumnClause = [ '((S*) on line ((d+)(, column (d+))?))', // (file path) on line 8, column 13 '((S*):line ((d+)(, column (d+))?))', // (file path):line 8, column 13 <del> '(([^s()]*)(s?((d+)(,(d+))?)))', // (file path)(45), (file path) (45), (file path)(45,18), (file path) (45,18) </del> <ins> '(([^s()]*)(s?[([](d+)(,(d+))?)[)]])', // (file path)(45), (file path) (45), (file path)(45,18), (file path) (45,18) </ins> '(([^:s()<>'"[]]*)(:(d+))?(:(d+))?)' // (file path):336, (file path):336:9 ].join('|').replace(/ /g, `[${'u00A0'} ]`);

Discussion:
tslint outputs errors in this format: /cc Related:
Doesn't work for me when there's a space between line and col, it looks like tslint is outputting it that way Top goes to correct line/col, bottom just goes to the file !
do you have an example program that outputs like this?
tslint apparently does, from the example above?
I actually can't click at all in this example !
Change:
.filter(session => session.requests.length)); allSessions.sort((a, b) => (b.creationDate ?? 0) - (a.creationDate ?? 0)); allSessions = allSessions.slice(0, maxPersistedSessions); <del> this.trace('onWillSaveState', `Persisting ${allSessions.length} sessions`); </del> <ins> if (allSessions.length) { this.trace('onWillSaveState', `Persisting ${allSessions.length} sessions`); } </ins> const serialized = JSON.stringify(allSessions); <del> this.trace('onWillSaveState', `Persisting ${serialized.length} chars`); </del> <ins> if (allSessions.length) { this.trace('onWillSaveState', `Persisting ${serialized.length} chars`); } </ins> this.storageService.store(serializedChatKey, serialized, StorageScope.WORKSPACE, StorageTarget.MACHINE); }

Discussion:
Repro: OSS trace logs window ! I don't have copilot installs in OSS so I wouldn't expect anything to happen here. Not sure what the 2 chars are.
Probably
Change:
const fs = require('fs'); const events = require('events'); const mocha = require('mocha'); <ins> const MochaJUnitReporter = require('mocha-junit-reporter'); </ins> const url = require('url'); const minimatch = require('minimatch'); const playwright = require('playwright');

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --- [x] Adopt a multi-stage pipeline for better visibility into dependencies [x] Review all test suites and ensure that they emit XML test results [x] Add pipeline task to publish the test results