jiebi/CodeConvo huggingface dataset:
Change:
} hasFocus(): boolean { <del> if (!this.isVisible || !this.listContainer) { return false; // hidden </del> <ins> if (!this.listContainer) { return false; // not created yet </ins> } return isAncestor(document.activeElement, this.listContainer);

Discussion:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated
Change:
this._addon?.dispose(); })); <ins> const inputModel = commandDetectionCapability.promptInputModel; if (inputModel) { this._register(inputModel.onDidChangeInput(() => { if (inputModel.value) { this._decoration?.dispose(); this._addon?.dispose(); } })); } </ins> if (!this._decoration) { return; }

Discussion:
I see this, but I think I've seen it correct in the past? But right now it's reproable in new terminals <img width="708" alt="image" src=""
Maybe related to my zsh prompt config, I can share the zsh config if it helps
I see the same, since I use the same setup <img width="1434" alt="Screenshot 2024-05-07 at 21 49 41" src=""
Yes can you pls share your zsh config?
Steps are: zsh oh-my-zsh a terminal in a workspace that has a git repo Let me know if that doesn't work for you.
Disabled by default in for now
also mentioned he thinks it should use the terminal's font
using your steps and I am still not seeing it . Can you share your configuration? <img width="986" alt="Screenshot 2024-05-13 at 9 50 51 AM" src=""
Also, any terminal settings would help - do you set the font / letter spacing for example?
I see that for the first prompt, the prompt start marker occurs before the (see the status bar). <img width="900" alt="Screenshot 2024-05-13 at 10 55 04 AM" src=""
Handle prompt start happens before the is by the program.
We should be disposing of the decoration when there's input, even for this case, when that's happening via a shell script.
In the case of the specific theme can be used without this issue if one removes from the prompt in Also note that the prompt is correct when a user hits enter. It's only the first prompt that is wrongly interpreted.
Change:
} // Otherwise try in previous group that has editors <ins> const handledGroups = new Set<number>(); </ins> let currentGroup: IEditorGroup | undefined = this.editorGroupService.activeGroup; <del> while (currentGroup) { </del> <ins> while (currentGroup && !handledGroups.has(currentGroup.id)) { </ins> currentGroup = this.editorGroupService.findGroup({ location: GroupLocation.PREVIOUS }, currentGroup, true); if (currentGroup) { <ins> handledGroups.add(currentGroup.id); </ins> const groupEditors = currentGroup.getEditors(EditorsOrder.SEQUENTIAL); if (groupEditors.length > 0) { return { editor: groupEditors[groupEditors.length - 1], groupId: currentGroup.id };

Discussion:
Steps: open 2 empty groups pick "Open Previous Editor" or "Open Next Editor" Endless loop.
Change:
private static readonly COLLAPSED_VISUAL_DECORATION = ModelDecorationOptions.register({ stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges, afterContentClassName: 'inline-folded', <del> linesDecorationsClassName: 'codicon codicon-chevron-right' </del> <ins> isWholeLine: true, firstLineDecorationClassName: 'codicon codicon-chevron-right' </ins> }); private static readonly COLLAPSED_HIGHLIGHTED_VISUAL_DECORATION = ModelDecorationOptions.register({

Discussion:
When a section is wrapped after folding. Fold its parent with itself unfolded will display several wrong fold indicators.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.724 --- <!-- score: 0.616 --- <!-- score: 0.606 --- <!-- score: 0.575 --- <!-- score: 0.569 --<!-- potentialduplicatescomment --
!
Change:
applyStyles(filterChecked: boolean): void { const toggleStyles = this._toggleStyles; <ins> this._filterButtonContainer.style.border = '1px solid transparent'; this._filterButtonContainer.style.borderRadius = '3px'; </ins> this._filterButtonContainer.style.borderColor = (filterChecked && toggleStyles.inputActiveOptionBorder) || ''; this._filterButtonContainer.style.color = (filterChecked && toggleStyles.inputActiveOptionForeground) || 'inherit'; this._filterButtonContainer.style.backgroundColor = (filterChecked && toggleStyles.inputActiveOptionBackground) || '';

Discussion:
! When I enable the other toggles like match word, it has a small border, but the filter doesn't have that.
Change:
index, item, saneLabel, <ins> saneSortLabel, </ins> saneMeta, saneAriaLabel, saneDescription,

Discussion:
Create or Checkout a PR Click on the branch indicator in the status bar Type Observe that doesn't show in top position Not sure what changed, but this used to work reliably until today, this was the main way I used to go back to the branch: <img width="1078" alt="image" src="https://user-"
We have an icon to the quick pick items but I would like to think that this did not break search. Will investigate.
Change:
.terminal-command-decoration.default { pointer-events: none; } <ins> .terminal-scroll-highlight { left: 0; right: 0; border: 1px solid #ffffff; } </ins>

Discussion:
Follow up for cmd+up/down on macOS should show some indication of the line that was scrolled to. This will need some upstream changes.
testing if i have a few empty lines such as this: ! pressing appears to do nothing, so having some indication of where I am would be great.
yeah I would have liked to get this in but was a bit randomized this iteration.
Blocked on
Brought this to UX sync with a focus border outline that fades to 0 opacity over 2 seconds. But after it occurred to me that navigating the a symbol in the editor is the exact idea we're trying to get across which flashes a focus border briefly without animating. So going with that to align, we can change both if we want to tweak it: !
Using 350ms:
!
Change:
export type RebaseContinueOperation = BaseOperation & { kind: OperationKind.RebaseContinue }; export type RevertFilesOperation = BaseOperation & { kind: OperationKind.RevertFiles }; export type RevListOperation = BaseOperation & { kind: OperationKind.RevList }; <ins> export type RevParseOperation = BaseOperation & { kind: OperationKind.RevParse }; </ins> export type SetBranchUpstreamOperation = BaseOperation & { kind: OperationKind.SetBranchUpstream }; export type ShowOperation = BaseOperation & { kind: OperationKind.Show }; export type StageOperation = BaseOperation & { kind: OperationKind.Stage };

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !
Change:
(function () { if (typeof globalThis.requestIdleCallback !== 'function' || typeof globalThis.cancelIdleCallback !== 'function') { <del> _runWhenIdle = (_targetWindow, runner) => { </del> <ins> _runWhenIdle = (_targetWindow, runner, timeout?) => { </ins> setTimeout0(() => { if (disposed) { return;

Discussion:
See It appears to timeout
I cannot explain this, we hang here: Which would suggest that we were unable to complete creating all workbench contributions. But I do not find anything in the logs that would hint into a direction
Change:
renderElement(node: ITreeNode<ISCMActionButton, FuzzyScore>, index: number, templateData: ActionButtonTemplate, height: number | undefined): void { templateData.disposable.dispose(); <ins> const disposables = new DisposableStore(); const actionButton = node.element; </ins> templateData.actionButton.setButton(node.element.button); <ins> // Remember action button this.actionButtons.set(actionButton, templateData.actionButton); disposables.add({ dispose: () => this.actionButtons.delete(actionButton) }); templateData.disposable = disposables; </ins> } renderCompressedElements(): void { throw new Error('Should never happen since node is incompressible'); } <ins> focusActionButton(actionButton: ISCMActionButton): void { this.actionButtons.get(actionButton)?.focus(); } </ins> disposeElement(node: ITreeNode<ISCMActionButton, FuzzyScore>, index: number, template: ActionButtonTemplate): void { template.disposable.dispose(); }

Discussion:
This should not be a valid state: ! It should automatically switch to this: ! is how the SCM Input does it.
I am seeing this state when I am navigating using up/down buttons. Is it expected? ! !
That is probably unexpected, but I will let confirm that.
Yeah, just like the text box. The list doesn't support completely disabling it at the model layer. We can only disable it at the click operation.
Change:
if (standardKeyboardEvent.keyCode === KeyCode.KEY_IN_COMPOSITION) { standardKeyboardEvent.stopPropagation(); } <del> // Enter key presses are not sent as text update events, hence we need to handle them outside of the text update event // The beforeinput and input events send `insertParagraph` and `insertLineBreak` events but only on input elements // Hence we handle the enter key press in the keydown event if (standardKeyboardEvent.keyCode === KeyCode.Enter) { </del> <ins> viewController.emitKeyDown(standardKeyboardEvent); })); this._register(addDisposableListener(this.domNode.domNode, 'beforeinput', async (e) => { if (e.inputType === 'insertParagraph') { </ins> this._onType(viewController, { text: 'n', replacePrevCharCnt: 0, replaceNextCharCnt: 0, positionDelta: 0 }); } <del> viewController.emitKeyDown(standardKeyboardEvent); </del> })); // Edit context events

Discussion:
Version: 1.94.0-insider Commit: Date: 2024-09-09T17:10:54.809Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 22.6.0 If , typing doesn't accept the selected suggestion even when . Steps to Reproduce: as follows: a TypeScript file, show suggestions, and type . The selected suggestion is not accepted.
Hi thank you for filing this issue. I have traced the source of the issue and this should be fixed by: Thanks a lot for filing the issue, this code is in an experimental stage and contains certain bugs that need to be fixed as we go on.
Change:
new ApiCommand( 'vscode.prepareCallHierarchy', '_executePrepareCallHierarchy', 'Prepare call hierarchy at a position inside a document', [ApiCommandArgument.Uri, ApiCommandArgument.Position], <del> new ApiCommandResult<ICallHierarchyItemDto[], types.CallHierarchyItem[]>('A CallHierarchyItem or undefined', v => v.map(typeConverters.CallHierarchyItem.to)) </del> <ins> new ApiCommandResult<ICallHierarchyItemDto[], types.CallHierarchyItem[]>('A promise that resolves to an array of CallHierarchyItem-instances', v => v.map(typeConverters.CallHierarchyItem.to)) </ins> ), new ApiCommand( 'vscode.provideIncomingCalls', '_executeProvideIncomingCalls', 'Compute incoming calls for an item', [ApiCommandArgument.CallHierarchyItem], <del> new ApiCommandResult<IIncomingCallDto[], types.CallHierarchyIncomingCall[]>('A CallHierarchyItem or undefined', v => v.map(typeConverters.CallHierarchyIncomingCall.to)) </del> <ins> new ApiCommandResult<IIncomingCallDto[], types.CallHierarchyIncomingCall[]>('A promise that resolves to an array of CallHierarchyIncomingCall-instances', v => v.map(typeConverters.CallHierarchyIncomingCall.to)) </ins> ), new ApiCommand( 'vscode.provideOutgoingCalls', '_executeProvideOutgoingCalls', 'Compute outgoing calls for an item', [ApiCommandArgument.CallHierarchyItem], <del> new ApiCommandResult<IOutgoingCallDto[], types.CallHierarchyOutgoingCall[]>('A CallHierarchyItem or undefined', v => v.map(typeConverters.CallHierarchyOutgoingCall.to)) </del> <ins> new ApiCommandResult<IOutgoingCallDto[], types.CallHierarchyOutgoingCall[]>('A promise that resolves to an array of CallHierarchyOutgoingCall-instances', v => v.map(typeConverters.CallHierarchyOutgoingCall.to)) </ins> ), // --- rename new ApiCommand(

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: windows 11 Hi, I am an extension developer, I found that the built-in call hierarchy api description is incorrect in , this makes me confused all day! ! The first api should return an array of . This confused me a lot. The second and third api should return array of and .
Change:
} else if (pick === configurePick) { // config default const langName = modeService.getLanguageName(model.getModeId()) || model.getModeId(); <del> const pick = await quickPickService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for {0}-files", DefaultFormatter._maybeQuotes(langName)) }); </del> <ins> const pick = await quickPickService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for '{0}' files", DefaultFormatter._maybeQuotes(langName)) }); </ins> if (pick && formatters[pick.index].extensionId) { configService.updateValue(DefaultFormatter.configName, formatters[pick.index].extensionId!.value, overrides); }

Discussion:
Steps to Reproduce: Format Document from command palette when there are multiple formatters placeholder for the box to choose which formatter to use says "Select a default formatter for Flow-files" (in my case, the language is set to "Flow") "Flow-files" is weird, I don't think there should be a hyphen: Also here, but I don't know how to repro this one:
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.537 --- <!-- score: 0.485 --- <!-- score: 0.47 --<!-- potentialduplicatescomment --
I will prepare a PR.
Change:
"language": "coffeescript", "path": "./snippets/coffeescript.code-snippets" } <del> ] </del> <ins> ], "configurationDefaults": { "[coffeescript]": { "diffEditor.ignoreTrimWhitespace": false } } </ins> }, "repository": { "type": "git",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
} } }); <ins> const profileScopedActionDisposables = this._register(new DisposableStore()); const registerProfileScopedActions = () => { profileScopedActionDisposables.clear(); profileScopedActionDisposables.add(registerAction2(class DefineKeybindingAction extends Action2 { constructor() { const when = ResourceContextKey.Resource.isEqualTo(that.userDataProfileService.currentProfile.keybindingsResource.toString()); super({ id: 'editor.action.defineKeybinding', title: { value: nls.localize('defineKeybinding.start', "Define Keybinding"), original: 'Define Keybinding' }, f1: true, precondition: when, menu: { id: MenuId.EditorContent, when, } }); } async run(accessor: ServicesAccessor): Promise<void> { const codeEditor = accessor.get(IEditorService).activeTextEditorControl; if (isCodeEditor(codeEditor)) { codeEditor.getContribution<IDefineKeybindingEditorContribution>(DEFINE_KEYBINDING_EDITOR_CONTRIB_ID)?.showDefineKeybindingWidget(); } } })); }; registerProfileScopedActions(); this._register(this.userDataProfileService.onDidChangeCurrentProfile(() => registerProfileScopedActions())); </ins> } private updatePreferencesEditorMenuItem() {

Discussion:
With there is a new -menu which a big blue buttons. This is used in the merge editor and to hint to open the merge editor. This new menu should be used for: [x] [ ] ~~ / [x] [ ]
Other potential adoptors [ ] [ ] [ ] [ ]
Digging into it, I don't think can be adopted for the diff editor, as the button should be for both editors, not only the right side ( is a , but is ).
Change:
'!extensions/configuration-editing/build/inline-allOf.ts', '!extensions/markdown-language-features/media/highlight.css', '!extensions/markdown-math/notebook-out/**', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/html-language-features/server/src/modes/typescript/*', '!extensions/*/server/bin/*', '!src/vs/editor/test/node/classification/typescript-test.ts',

Discussion:
Running on main:
Am I missing something on how to run this? An ignore rule is in :
Change:
readonly contextKeyService: IContextKeyService, readonly cellContainer: HTMLElement, readonly runButtonContainer: HTMLElement, <ins> primaryMenuId: MenuId, secondaryMenuId: MenuId, </ins> @IMenuService menuService: IMenuService, @IKeybindingService private readonly keybindingService: IKeybindingService, @IContextMenuService private readonly contextMenuService: IContextMenuService,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (only the jupyter and python extensions enabled) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.94.0-insider (user setup) Commit: Date: 2024-09-16T05:03:40.122Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: I restarted VSCode to install the latest update (above), and now python interactive sessions do not print output of cells in the interactive window. After running a cell in a interactive session: Using the jupyter extension, one can see that the variables are created in memory, but there is no output in the interactive window. Tested with a jupyter notebook, output is correctly printed below the cells: ! Output of "window" after running a single cell in an interactive session: <details<summaryShow output (large)</summary</details
As clarification: nothing is shown in the interactive window, not just output "input" cells are not shown either Only the "Connected to kernel", "restarting kernel" or "kernel restarted" messages
likely a regression from
Same thing happened to me. Though the jupyter panel shows the variables created by running the code, the interactive window shows nothing. (see image below) !
actually caused by , but only because we are creating a menu with an undefined ID by overriding a type restriction here:
Change:
return; } <del> consumeClick = false; </del> <ins> ctrlPressed = e.ctrlKey; altPressed = e.altKey; consumeClick = !isActive; </ins> }); container.addEventListener('click', (/** @type {MouseEvent} */ e) => {

Discussion:
Repo an image to the side of a text editor with the text editor focused click into the image editor to focus it Bug The first click ends up zooming the image. Clicking should only zoom when the editor is already focused
Here's the relevant code about click handling in the image preview:
If focus is required for zoom, then the cursor when hovering over the image preview should be the default arrow cursor when unfocused, currently it is the zoom-in cursor. Also zooming with the mouse wheel should not be allowed when unfocused. Thoughts?
Fixed by
I'm still seeing the first click zoom. Steps: a typescript file. a gif gif to the right so that both typescript and gif are visible and side by side in typescript. in gif Expected: no zoom Actual: it zooms on the click in the gif in (5).
I'm not able to reproduce. Have tried on both insiders 1.40.0 and OSS. Does this only occur with gifs for you?
I can repo this. You may need to click back and forth multiple times trigger the error
I'm still not able to. Will try more tomorrow. A possible cause might be that the event is fired before the event on the first click. This could be tested by checking the order of execution for the corresponding event handlers in . I'll do it if I manage to reproduce the bug.
Change:
}, ] ], <del> enabled: this.state.repositoryHasChanges && !this.state.isCommitInProgress </del> <ins> enabled: this.state.repositoryHasChanges && !this.state.isCommitInProgress && !this.state.isMergeInProgress </ins> }; }

Discussion:
a folder/workspace that contains a git repository a topic branch changes to main and the topic branch that would result in a merge conflict main into the topic branch to get a conflict Expected: commit action button is disabled Actual: commit action button is enabled
The button is now disabled while merging is in progress, but the button and the dropdown both take on a background color when clicked, which was confusing to me: !
Also, while the commit action button is disabled, the commit button above the input box is not: !
That is expected. At the moment the enablement is only toggled for the commit action button and not the commit action in the toolbar.
This is currently being tracked as