jiebi/CodeConvo huggingface dataset:
Change:
this.editor.trigger('keyboard', 'type', { text }); } <ins> public cursorUp(): void { CoreNavigationCommands.CursorUp.runEditorCommand(null, this.editor, null); } public cursorRight(): void { CoreNavigationCommands.CursorRight.runEditorCommand(null, this.editor, null); } public cursorLeft(): void { CoreNavigationCommands.CursorLeft.runEditorCommand(null, this.editor, null); } public cursorDown(): void { CoreNavigationCommands.CursorDown.runEditorCommand(null, this.editor, null); } public cursorLineEnd(): void { CoreNavigationCommands.CursorLineEnd.runEditorCommand(null, this.editor, null); } </ins> public leftDelete(): void { CoreEditingCommands.DeleteLeft.runEditorCommand(null, this.editor, null); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !
Please let me know soon if we should release this with our Recovery Release tomorrow!
Thanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!
can you verify that the issue is fixed in todays insider build?
As he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!
Change:
LocalEchoExcludePrograms = 'terminal.integrated.localEchoExcludePrograms', LocalEchoStyle = 'terminal.integrated.localEchoStyle', EnablePersistentSessions = 'terminal.integrated.enablePersistentSessions', <del> InheritEnv = 'terminal.integrated.inheritEnv' </del> <ins> InheritEnv = 'terminal.integrated.inheritEnv', ShowLinkHover = 'terminal.integrated.showLinkHover', </ins> } export enum WindowsShellType {

Discussion:
Forking off the setting part off from PR:
Hello, is this issue is still open. I am new to open source and wanted to contribute.
there's a PR open already for this one
Change:
*/ async function guessEncodingByBuffer(buffer: VSBuffer, candidateGuessEncodings?: string[]): Promise<string | null> { <del> // TODO@bpasero ESM: this used to be `dist/jschardet.min.js`, but we are running into an issue that </del> <ins> // TODO@bpasero TODO@esm: this used to be `dist/jschardet.min.js`, but we are running into an issue that </ins> // https://github.com/aadsm/jschardet/pull/96 mitigates. Long-term we should just add minification // of dependencies into our build process so that we do not depend on how others are doing it. const jschardet = await importAMDNodeModule<typeof import('jschardet')>('jschardet', isESM ? 'dist/jschardet.js' : 'dist/jschardet.min.js');

Discussion:
We lost changes that where ESM relevant. I am trying to fix it in our ESM branch, maybe backport it from there: The old code also had this line, which I am not sure is needed: cc
Sorry about that. Is this for Monaco or the esm work? I'd love to get a point where we can just have this as a normal dependency instead of copying it into our sources. Marked now publishes both a commonjs and esm builds too. Is there some way VS Code could use Marked as a normal dependency in a way that would also work for Monaco? If I recall we've tried to avoid adding real dependencies to Monaco
I only noticed for our work, not sure about Monaco ESM. Would be great to get it working again on .
I think the ESM work will unblock this. esbuild will be able to bring in and include node modules into our bundle, the AMD bundler we currently use can only bundle AMD modules and not commonjs modules.
I would have hoped that the Monaco Editor checks would have caught this. Is there something we should improve there?
For monaco-editor-core, these are the only tests: It does not test markdown features.
Change:
} else if (task.command.presentation && (task.command.presentation.focus || task.command.presentation.reveal === RevealKind.Always)) { this._terminalService.setActiveInstance(terminal); await this._terminalService.revealActiveTerminal(); <ins> if (task.command.presentation.focus) { this._terminalService.focusActiveInstance(); } </ins> } this._activeTasks[task.getMapKey()].terminal = terminal; this._fireTaskEvent(TaskEvent.changed());

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.84.0 (Universal) Commit: Date: 2023-11-01T11:30:19.406Z Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.1.0 OS Version: macOS Sonoma 14.1 Steps to Reproduce: a task in with this format an editor window if not already open the task that the cursor stays in the editor so the terminal must be clicked on to press enter and dismiss the task
I have the same fault in the same version of VSCode.
Same problem with: My task looks like this:
Exactly the same here.
Same issue here.
Same here: In the 1.83 version it worked perfectly.
The same for me:
Change:
await testObject.run(); <del> assert.strictEqual(testObject.verificationStatus, ExtensionVerificationStatus.Unverified); </del> <ins> assert.strictEqual(testObject.verificationStatus, errorCode); </ins> assert.strictEqual(testObject.installed, true); }); <del> test('if verification fails, the task throws', async () => { </del> <ins> test('if verification fails', async () => { </ins> const errorCode = 'IntegrityCheckFailed'; const testObject = new TestInstallGalleryExtensionTask(aGalleryExtension('a', { isSigned: true }), anExtensionsDownloader({ isSignatureVerificationEnabled: true, verificationResult: errorCode, didExecute: true })); <del> try { await testObject.run(); } catch (e) { assert.ok(e instanceof ExtensionManagementError); assert.strictEqual(e.code, ExtensionManagementErrorCode.Signature); assert.strictEqual(e.message, errorCode); assert.strictEqual(testObject.verificationStatus, ExtensionVerificationStatus.Unverified); assert.strictEqual(testObject.installed, false); return; } </del> <ins> await testObject.run(); </ins> <del> assert.fail('It should have thrown.'); </del> <ins> assert.strictEqual(testObject.verificationStatus, errorCode); assert.strictEqual(testObject.installed, true); </ins> }); test('if verification succeeds, the task completes', async () => {

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log
Change:
// (or, if the task has no group, a terminal used by a task without group). for (const taskId of this.idleTaskTerminals.keys()) { const idleTerminalId = this.idleTaskTerminals.get(taskId)!; <del> if (this.terminals[idleTerminalId].group === group) { </del> <ins> if (idleTerminalId && this.terminals[idleTerminalId].group === group) { </ins> terminalId = this.idleTaskTerminals.remove(taskId); break; }

Discussion:
Issue Type: <bBug</bLatest insider build, no extensions installed. Same issue on january 2019 update. No issue on december 2018 update. Once I have run a build task once, and closed the "build terminal" any subsequent builds will fail with the error "Failed to create terminal for task clean". If I do not close the build terminal I can run the build again. I get no output anywhere explaining what went wrong. The issue is on a dotnet core Azure functions app. tasks relevant if I comment out the I can build (without cleaning first), then remove the comment and build again, the clean task runs fine (because the terminal is now already spawned) output from developer tools console: VS Code version: Code - Insiders 1.32.0-insider (, 2019-02-06T21:10:41.427Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Fix:
I found this problem too. (But for C++, though) Really hope a new release can come out soon. Thanks you guys.
I just updated the latest release and it contains this bug. Do you have stable tree or something that ensures that this kind of fresh bugs does not pop?
I just updated the latest release and it contains this bug. Do you have stable tree or something that ensures that this kind of fresh bugs does not pop?
what version do you have? This should be fixed starting with 1.31.1.
1.32.1
can you create a new issue with your repro steps? Since this issue was caused by a value not getting checked for existence it can't be the same root cause.
Change:
test('compareFileNames', () => { <ins> assert(compareFileNames(null, null) === 0, 'null should be equal'); assert(compareFileNames(null, 'abc') < 0, 'null should be come before real values'); </ins> assert(compareFileNames('', '') === 0, 'empty should be equal'); assert(compareFileNames('abc', 'abc') === 0, 'equal names should be equal'); assert(compareFileNames('.abc', '.abc') === 0, 'equal full names should be equal'); <del> assert(compareFileNames('.env', '.env.example') < 0); assert(compareFileNames('.env.example', '.gitattributes') < 0); </del> <ins> assert(compareFileNames('.env', '.env.example') < 0, 'filenames with extensions should come after those without'); assert(compareFileNames('.env.example', '.gitattributes') < 0, 'filenames starting with dots and with extensions should still sort properly'); assert(compareFileNames('1', '1') === 0, 'numerically equal full names should be equal'); assert(compareFileNames('abc1.txt', 'abc1.txt') === 0, 'equal filenames with numbers should be equal'); assert(compareFileNames('abc1.txt', 'abc2.txt') < 0, 'filenames with numbers should be in numerical order, not alphabetical order'); assert(compareFileNames('abc2.txt', 'abc10.txt') < 0, 'filenames with numbers should be in numerical order even when they are multiple digits long'); </ins> }); });

Discussion:
VSCode Version: Code 1.8.0 (, 2016-12-13T17:45:32.595Z) OS Version: Windows_NT ia32 10.0. Extensions: Steps to Reproduce: 3 folders called "Folder 1" , "Folder 2" and "Folder 10" 10 appears in between Folder 1 and Folder 2. !
The macOS Finder, for example, handles this case correctly.
do you recall any reason why we are not using the for folders in ?
This actually happens for files and folders. A good area for a PR
As related, can also be included in February Milestone?
Unlikely.
Change:
const filter = new SCMTreeFilter(); const sorter = new SCMTreeSorter(() => this.viewModel); <del> const keyboardNavigationLabelProvider = new SCMTreeKeyboardNavigationLabelProvider(); </del> <ins> const keyboardNavigationLabelProvider = this.instantiationService.createInstance(SCMTreeKeyboardNavigationLabelProvider); </ins> const identityProvider = new SCMResourceIdentityProvider(); this.tree = this.instantiationService.createInstance(

Discussion:
I often make a lot of changes at once, and then need to commit them. Some changes don't belong together in the same commit, and some aren't ready to be committed at all. The current UI allows me to select some files to be staged for commit and exclude others, but it requires me to carefully select my changes from a potentially very long list. It would be incredibly useful if I could search or filter files by path pattern and stage/unstage all search results. Even better would be if I could search for lines of code and either stage files containing those lines or just the matched lines. This would streamline my git workflow by a lot.
I guess my ideal UI would allow me to: search files by path, and stage/unstage all matched files stage/unstage individually selected files search code in files, and stage/unstage all matched lines stage/unstage individually selected lines stage/unstage all matched files stage/unstage individually selected files
Since last month, SCM supports fancy keyboard navigation and filtering. Simply start typing when focused on the view. A widget will appear which you can use to toggle between simple highlighting and filtering. Currently filtering is done only on file names though, not paths or even code, so I can leave this open for additional filtering fields.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
private _scheduleRender(): void { if (this._renderAnimationFrame === null) { <del> this._renderAnimationFrame = DOM.runAtThisOrScheduleAtNextAnimationFrame(this._onRenderScheduled.bind(this), 100); </del> <ins> this._renderAnimationFrame = DOM.runAtThisOrScheduleAtNextAnimationFrame(this._onRenderScheduled.bind(this), 16); </ins> } }

Discussion:
Testing Scroll a bit in the notebook diff. Notice that the current location rectangle is not always right. Notice that the first and last line are not straight. !
I can still get a tiny misalignment in the text diff scrollbars, not sure if it's the same scenario: <img width="115" alt="image" src="https://user-"
<img width="985" alt="image" src="https://user-"How do I get that custom scrollbar in the notebook diff editor? I see a regular scrollbar
Change:
outline: 0; } <ins> .menubar.compact { flex-shrink: 0; } </ins> .menubar.compact > .menubar-menu-button { width: 100%; height: 100%;

Discussion:
Steps to Reproduce: web in Safari on compact menu = it moves !
I diagnosed this and see 2 issues: the menu items are not removed from the DOM when menu is not showing () you seem to be using instead of to hide the menu items, is there any particular reason? using the issue is not as bad anymore (I only see one initial jump) I suggest we use / (our helper), but I am not sure if you rely on the behavior of visibility?
I mentioned the reasoning in the linked issue, but in the compact case we can remove them from the DOM safely so patching that should help here.
Change:
this._register(Event.runAndSubscribe(webviewThemeDataProvider.onThemeDataChanged, () => this.style())); this._register(_accessibilityService.onDidChangeReducedMotion(() => this.style())); this._register(_accessibilityService.onDidChangeScreenReaderOptimized(() => this.style())); <ins> this._register(contextMenuService.onDidShowContextMenu(() => this._send('set-context-menu-visible', { visible: true }))); this._register(contextMenuService.onDidHideContextMenu(() => this._send('set-context-menu-visible', { visible: false }))); </ins> this._confirmBeforeClose = configurationService.getValue<string>('window.confirmBeforeClose');

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/a <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.77.3 Commit: Date: 2023-04-12T09:16:02.548Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.77.3 Chrome/102.0.5005.196 Electron/19.1.11 Safari/537.36 OS Version: Steps to Reproduce: click a file in the Explorer. The background color of the row changes from blue to grey. Esc to close the context menu. The background color changes back. is not possible to emulate with an extension using a webview context menu. Fixed by my PR
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I'll verify this.
<img width="320" alt="image" src=""<img width="334" alt="image" src=""I can confirm that on that there is a style change when right-clicking a file in the Explorer. But it's not the one described, the text colour changes slightly (this may be a theme difference). What's an extension that uses a file list in a web view that I can verify?

I think any webview context menu should work for this, not necessarily a file list.
They would need to add a CSS rule with the new class name to make an actual change in visual appearance. You can verify the class is applied on the body element using the Webview Developer Tools.
this could probably be edited
Here's a snippet from my project, the selector doesn't work while the context menu is up, so I repeat the same rules with
Oh, and the original issue was reported with the previous default theme.
Thanks
Change:
this.createOverlayContainer(keybindingsEditorElement); this.createHeader(keybindingsEditorElement); this.createBody(keybindingsEditorElement); <del> const focusTracker = this._register(DOM.trackFocus(parent)); this._register(focusTracker.onDidFocus(() => this.keybindingsEditorContextKey.set(true))); this._register(focusTracker.onDidBlur(() => this.keybindingsEditorContextKey.reset())); </del> } setInput(input: KeybindingsEditorInput, options: EditorOptions, token: CancellationToken): Promise<void> { <ins> this.keybindingsEditorContextKey.set(true); </ins> return super.setInput(input, options, token) .then(() => this.render(options && options.preserveFocus, token)); }

Discussion:
Issue Type: <bBug</b! VS Code version: Code - Insiders 1.31.0-insider (, 2018-12-17T10:06:30.031Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Adding to makes it focusable and fixes the issue. In , line 108 needs to be changed to: Is this an acceptable fix? Shall I raise a PR?
Yeah it is acceptable. Please create a PR.
there's a yellow border in that case and it breaks <kbdShift</kbd+<kbdTab</kbdwhen focus is inside input.
Where is that yellow border? And what exactly is breaking in <kbdShift</kbd+<kbdTab</kbd? Works fine for me.
!
<kbdShift</kbd+<kbdTab</kbd(when focus is on input) should focus editor menu (three dots). And the icon should remain in place.
Oh I see it now. I am getting a blue border that is barely noticeable. I will fix that. Thanks! When focus is on input, I believe <kbdShift</kbd+<kbdTab</kbdshould move focus to the "Record keys" button (on the far right of the input box) and so on. That's how it is happening in the latest release version too.
That's what pressing <kbdTab</kbdshould do. <kbdShift</kbd+<kbdTab</kbdis a reverse command of that and should move focus in the opposite side - in this case to editor actions menu (and the icon should be in place to be available for pressing by <kbdEnter</kbd).
Oh! My bad! Will look into it.
I think you should do the same as in and set the key to true in the setInput method and remove this listeners
Thanks That works! I have updated my PR .
Change:
return new UriList(uris.map(uri => ({ uri, str: uri.toString(true) }))); } <del> private async createUriListSnippet(uriList: UriList): Promise<{ readonly snippet: vscode.SnippetString; readonly label: string } | undefined> { </del> <ins> private async createUriListSnippet(docUri: vscode.Uri, uriList: UriList): Promise<{ readonly snippet: vscode.SnippetString; readonly label: string } | undefined> { </ins> if (!uriList.entries.length) { return; }

Discussion:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch