jiebi/CodeConvo huggingface dataset:
Change:
set -e # package Remote Extension Host <del> pushd .. && mv vscode-reh-darwin-$(VSCODE_ARCH) vscode-server-darwin && zip -Xry vscode-server-darwin-$(VSCODE_ARCH).zip vscode-server-darwin && popd </del> <ins> pushd .. && mv vscode-reh-darwin-$(VSCODE_ARCH) vscode-server-darwin-$(VSCODE_ARCH) && zip -Xry vscode-server-darwin-$(VSCODE_ARCH).zip vscode-server-darwin-$(VSCODE_ARCH) && popd </ins> # package Remote Extension Host (Web) <del> pushd .. && mv vscode-reh-web-darwin-$(VSCODE_ARCH) vscode-server-darwin-web && zip -Xry vscode-server-darwin-$(VSCODE_ARCH)-web.zip vscode-server-darwin-web && popd </del> <ins> pushd .. && mv vscode-reh-web-darwin-$(VSCODE_ARCH) vscode-server-darwin-$(VSCODE_ARCH)-web && zip -Xry vscode-server-darwin-$(VSCODE_ARCH)-web.zip vscode-server-darwin-$(VSCODE_ARCH)-web && popd </ins> displayName: Prepare to publish servers condition: and(succeeded(), ne(variables['VSCODE_PUBLISH'], 'false'), ne(variables['VSCODE_ARCH'], 'universal'))

Discussion:
I noticed in the launcher that today's Darwin server has a nested subdirectory, . This broke our launcher (I initially assumed we changed something), and after checking I noticed that it also causes remote ssh to fail since the binaries are no longer in the expected locations: On the launcher side I can verify that pulling in yesterday's version by adding to the URL fixes the issue
The SSH issue was a separate local problem. Looking at the directories, the contents seem mostly the same structure wise. Not sure why it's extracting differently, since it does not seem to affect remote SSH. Looking into it.
Okay, that was a fun investigation. Yesterday's server's download path was But today's was We would only pop off the first segment of the path when unzipping if it matched the zip name. While the zip was renamed, its nested directory was not, and therefore we would end up with an extra segment in the path. I'll change our logic to just always pop off the first segment, though I think having the zip name match any nested directory is pretty standard so I'll leave this open in case this is worth a tweak.
Related to and
Change:
const treeDataSource = this.instantiationService.createInstance(SCMTreeDataSource, () => this.viewMode, () => this.alwaysShowRepositories, () => this.showActionButton, () => this.showIncomingChanges, () => this.showOutgoingChanges); this.disposables.add(treeDataSource); <del> this.treeIdentityProvider = new SCMResourceIdentityProvider(); </del> this.tree = this.instantiationService.createInstance( WorkbenchCompressibleAsyncDataTree, 'SCM Tree Repo',

Discussion:
Steps to Reproduce: a folder/workspace that contains a git repository change to a file "Commit & Push" from the action button Actual command not found Commit from the action button Actual command not found
Change:
const processExplorerWindowConfigUrl = processExplorerDisposables.add(this.protocolMainService.createIPCObjectUrl<ProcessExplorerWindowConfiguration>()); <del> const savedPosition = this.safeParseJson(this.applicationStorageMainService.get(processExplorerWindowState, StorageScope.APPLICATION), undefined); </del> <ins> const savedPosition = this.stateMainService.getItem<IWindowState>(processExplorerWindowState, undefined); </ins> const position = isStrictWindowState(savedPosition) ? savedPosition : this.getWindowPosition(this.processExplorerParentWindow, 800, 500); // Correct dimensions to take scale/dpr into account

Discussion:
This is a follow up from I would suggest to not use the storage service for process explorer state but . That is the same service we also use to store window state for workbench windows. Using storage service from the main process requires you to await the event because unlike state service, the storage service is not ready when you use it: State service is always available and can be used as a drop-in replacement. Here is where its used for windows and the key we use is , so maybe it should be .
Change:
const viewsToMove = this.viewDescriptorService.getViewDescriptors(container).allViewDescriptors; if (viewsToMove.length === 1 && viewsToMove[0].canMoveView) { <del> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.options.orientation ?? Orientation.VERTICAL, this.themeService); </del> <ins> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.orientation ?? Orientation.VERTICAL, this.themeService); </ins> } }

Discussion:
see: ! //cc
Good catch
To Verify: Panel to Right/Left dropping a view into the panel. feedback is horizontally split instead of vertically.
Change:
'CURRENT_DAY_NAME_SHORT': true, 'CURRENT_MONTH_NAME': true, 'CURRENT_MONTH_NAME_SHORT': true, <ins> 'CURRENT_SECONDS_UNIX': true, </ins> 'SELECTION': true, 'CLIPBOARD': true, 'TM_SELECTED_TEXT': true,

Discussion:
I would like a new Snippet Variable for time to be to the variables listed here. Something like or Number of seconds since the unix epoch.
Nice. I would like to work on that
I've got a commit here that works on my local build. Does this look good to you? I just get the milliseconds since epoch using and divide by 1,000. However I use to round to the nearest integer so there aren't a bunch of decimals. If that's what you wanted, I'll go ahead and open the PR, but just wanted to share it for discussion before I go ahead and do that.
I thought was the normal way of doing that? PS: just occurred, would be better since could go upwards
Ah you are right, completely forgot about . Definitely a cleaner look, and I've also changed round to floor. The new commit is and local build works perfect. Was there anything else that crossed your mind?
tested this is a Snippet in Insiders edition today. Works as expected. Thank you very much.
Change:
return this._renderedHoverParts.focusedHoverPartIndex; } <ins> public focusHoverPartWithIndex(index: number): void { this._renderedHoverParts.focusHoverPartWithIndex(index); } </ins> public getAccessibleWidgetContent(): string { return this._renderedHoverParts.getAccessibleContent(); }

Discussion:
Testing on Linux Open a hover with multiple parts Tab to focus one of the hover parts Open accessible view/help Esc to close it Now the whole hover is focused, instead of the individual part I'd focused
Verified with GitLens's editor hover
Change:
this._undoStack.push(this._prevState); if (this._undoStack.length > 50) { // keep the cursor undo stack bounded <del> this._undoStack = this._undoStack.splice(0, this._undoStack.length - 50); </del> <ins> this._undoStack.shift(); </ins> } }

Discussion:
VSCode Version: Code 1.15.0 (, 2017-08-09T20:16:06.988Z) OS Version: Windows_NT ia32 10.0. Extensions: ExtensionVersion ------ html-snippets0.1.0 vscode-javascript-snippet-pack0.1.5 path-intellisense1.4.2 vscode-weapp-api0.1.8 vscode-wxml0.1.9 githistory0.2.3 vscode-html-css0.1.7 vue-snippets0.1.2 beautify1.1.1 output-colorizer0.1.2 path-autocomplete1.6.1 vue0.1.5 vetur0.9.3 vue-beautify2.0.4 java0.8.0 code-settings-sync2.8.2 stylelint0.28.0 JavaScriptSnippets1.4.1
Does this issue occur when launching VS Code with extensions disabled () ?
My extensions are enable. I had recorded the steps with screenshots. , the cursor in line 480 ! , the curson in line 177 ! , I click and the cursor in the previous line 480, but the scroll bar had not scroll. !
And the don't support cross editor tab
cursorUndo is designed to not cross-tab. Go Back/Go Forward will cross tabs, but it will omit small selection changes.
Change:
if (jsFlags) { app.commandLine.appendSwitch('--js-flags', jsFlags); } <ins> // Disable smooth scrolling for Webviews if (cliArgs['disable-smooth-scrolling']) { app.commandLine.appendSwitch('disable-smooth-scrolling'); } </ins> } /**

Discussion:
VS Code version: Code 1.30.1 (, 2018-12-18T18:12:07.165Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
This was discussed previously in
Added with a in
Change:
const edits = state.edits; const selections = getEndPositionsAfterApplying(edits).map(p => Selection.fromPositions(p)); editor.executeEdits('inlineSuggestion.accept', [ <del> ...edits.map(edit => EditOperation.replaceMove(edit.range, edit.text)), </del> <ins> ...edits.map(edit => EditOperation.replace(edit.range, edit.text)), </ins> ...completion.additionalTextEdits ]); editor.setSelections(selections, 'inlineCompletionAccept');

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Not relevant <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.2 OS Version: MacOS Sonoma 14.3 (23D56) Steps to Reproduce: Use word-by-word/line-by-line accepts for an . I re-serve the same completion from cache after word-by-word accepts (with already accepted text filtered out). The completion suggestion flashes even though the ghost text did not change. This did not use to happen on VSCode 1.86 (downgraded and tested with the same VSIX). Example of text flashing on VSCode 1.87 gif: ! mov:
Can you give me reproduction steps? Cannot reproduce with copilot. Would be awesome if it reproduces .
Yeah let me try to figure this out and see if I can reproduce it with this! Unfortunately I wasn't able to reproduce it for CoPilot too, but with my organization's extension the behaviour changed after 1.87. The expected implementation for word-by-word/line-by-line completion is to re-serve the text from the old completion (with matching prefix removed) as a new right? Thanks for your help!
Yes
I created a mock example where I can still reproduce this on 1.87, and confirm that the text does not flash on 1.86. Still trying to investigate further if there's any link with other extensions or anything that could conflict, but a bit perplexed since it's very much reproducible with 1.87
On another interesting note, if I replace the full line (i.e including the prefix in the suggestion), it does not flash.

Maybe it's not reproducible with CoPilot if that's the approach they're taking?
Can you translate this example into a ? That way, if it is really a bug, it will significantly reduce the time I need to fix this (and for other team members to verify a bug-fix).
here's a repro on . If you type and then select code word-by-word, the text flashes. On this doesn't occur. I can repro the bug on 0.47.0 too. Hope this helps! Edit: Looks like it broke between v0.46.0-dev- and v0.46.0-dev-
Change:
recognizeKeyword(token: CancellationToken): Promise<KeywordRecognitionStatus>; } <del> export const SPEECH_LANGUAGE_CONFIG = 'accessibility.voice.speechLanguage'; </del> <ins> export const enum AccessibilityVoiceSettingId { SpeechTimeout = 'accessibility.voice.speechTimeout', AutoSynthesize = 'accessibility.voice.autoSynthesize', SpeechLanguage = 'accessibility.voice.speechLanguage', } export const SPEECH_LANGUAGE_CONFIG = AccessibilityVoiceSettingId.SpeechLanguage; </ins> export const SPEECH_LANGUAGES = { ['da-DK']: {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:
We reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See
Change:
const accessibleViewService = accessor.get(IAccessibleViewService); accessibleViewService.next(); return true; <del> }, accessibleViewIsShown)); </del> <ins> })); </ins> this._register(AccessibleViewPreviousAction.addImplementation(95, 'previous', accessor => { const accessibleViewService = accessor.get(IAccessibleViewService); accessibleViewService.previous(); return true; <del> }, accessibleViewIsShown)); </del> <ins> })); </ins> } }

Discussion:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
quickPick.matchOnLabel = false; quickPick.matchOnDescription = false; disposables.add(quickPick.onDidAccept(async () => { <del> quickPick.hide(); const profile = quickPick.selectedItems[0].description ? await this.getProfileFromURL(quickPick.value, requestService) : await this.getProfileFromFileSystem(fileDialogService, fileService); if (profile) { if (isSettingProfilesEnabled) { await userDataProfileImportExportService.importProfile(profile); } else { await userDataProfileImportExportService.setProfile(profile); </del> <ins> try { quickPick.hide(); const profile = quickPick.selectedItems[0].description ? await this.getProfileFromURL(quickPick.value, requestService) : await this.getProfileFromFileSystem(fileDialogService, fileService); if (profile) { if (isSettingProfilesEnabled) { await userDataProfileImportExportService.importProfile(profile); } else { await userDataProfileImportExportService.setProfile(profile); } </ins> } <ins> } catch (error) { notificationService.error(error); </ins> } })); disposables.add(quickPick.onDidHide(() => disposables.dispose()));

Discussion:
Testing When importing a profile from a file and giving a name of an existing profile, nothing happens. I would suggest to see an error when typing the name of an existing profile.
Change:
"git": { "name": "chromium", "repositoryUrl": "https://chromium.googlesource.com/chromium/src", <del> "commitHash": "a8a8309404d39efa9c624d7aee0e27562721e522" </del> <ins> "commitHash": "61305fe71c4357662f161ba689fd9a1828d5e4f7" </ins> } }, "licenseDetail": [

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith
Change:
'                                                                                                                                                 https://msdn.microsoft.com/en-us/library/windows/desktop/ms687414(v=vs.85).aspx                                  ' ); }); <ins> test('issue #62278: "Ctrl + click to follow link" for IPv6 URLs', () => { assertLink( 'let x = "http://[::1]:5000/connect/token"', '         http://[::1]:5000/connect/token  ' ); }); </ins> });

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.2 OS Version: Microsoft Windows 10 Pro, 10.0. Build Steps to Reproduce (2 problems): a source code file over an IPv6 URL and notice the faulty incomplete underline: ! Click the link: the default browser opens without accessing the URL <!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.463 --<!-- potentialduplicatescomment --
Change:
"textCodeBlock.background": "#6e768166", "textLink.activeForeground": "#005FB8", "textLink.foreground": "#005FB8", <del> "textPreformat.foreground": "#8b949e", </del> "textSeparator.foreground": "#21262d", "titleBar.activeBackground": "#f8f8f8", "titleBar.activeForeground": "#1e1e1e",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 (Universal) OS Version: macOS 13.2 About Window Contents: Steps to Reproduce: new v2 themes. a rendered HTML file with Code segments in it (e.g. the Releases notes for 1.75.0) markdown segments have a poor contrast compared to the other text. The contrast was a lot better in the old dark/light themes. <img width="905" alt="dark mode" src="https://user-"<img width="899" alt="light mode" src="https://user-"
I wanted to report the exact same issue
Change:
getAnchor: () => anchor, menuId: MenuId.EditorTitleContext, menuActionOptions: { shouldForwardArgs: true, arg: this.resourceContext.get() }, <del> contextKeyService: this.contextKeyService, </del> <ins> contextKeyService: this.contextMenuContextKeyService, </ins> getActionsContext: () => ({ groupId: this.groupView.id, editorIndex: this.groupView.getIndexOfEditor(editor) }), <del> getKeyBinding: action => this.getKeybinding(action), onHide: () => { // restore previous contexts this.resourceContext.set(currentResourceContext || null); this.editorPinnedContext.set(currentPinnedContext); this.editorIsFirstContext.set(currentEditorIsFirstContext); this.editorIsLastContext.set(currentEditorIsLastContext); this.editorStickyContext.set(currentStickyContext); this.groupLockedContext.set(currentGroupLockedContext); this.editorCanSplitInGroupContext.set(currentEditorCanSplitContext); this.sideBySideEditorContext.set(currentSideBySideEditorContext); this.editorAvailableEditorIds.set(currentEditorAvailableEditorIds); // restore focus to active group this.groupsView.activeGroup.focus(); } </del> <ins> getKeyBinding: action => this.keybindingService.lookupKeybinding(action.id, this.contextMenuContextKeyService), onHide: () => this.groupsView.activeGroup.focus() // restore focus to active group </ins> }); }

Discussion:
Version: 1.85.0 Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows x64 10.0. ( I am using a Python interpter ) Steps to Reproduce: Have at least 1 tab/file open the tab ( at the top ) : The run button disappears It's a very very minor bug and simply you just open another file to have it reappear. !
Thanks for reporting this! It lead to fixing this and other bugs we had :)
I am glad to hear!
Change:
lastReplaceTextLength = 0; } <ins> this.editor.revealPositionInCenterIfOutsideViewport(endPosition); </ins> this.widget.layout(); };

Discussion:
Testing I'm not sure what the correct fix is but if the text was generated outside of the view, I would image the editor would scroll horizontally as text gets inserted. (same as typing in the editor). !
Yes, very good catch.
Change:
this._contextKeyService.createKey(EditorContextKeys.inMultiDiffEditor.key, true); <ins> const ctxAllCollapsed = this._parentContextKeyService.createKey<boolean>(EditorContextKeys.multiDiffEditorAllCollapsed.key, false); this._register(autorun((reader) => { const viewModel = this._viewModel.read(reader); if (viewModel) { const allCollapsed = viewModel.items.read(reader).every(item => item.collapsed.read(reader)); ctxAllCollapsed.set(allCollapsed); } })); </ins> this._register(autorun((reader) => { const lastActiveDiffItem = this.lastActiveDiffItem.read(reader); transaction(tx => {

Discussion:
We have a "collapse all" button: And other places in vscode this typically toggles to an "expand all". Would make sense to have it here as well
PR is now available for review
Change:
} }, required: [ <del> 'settings', 'scope' </del> <ins> 'settings' </ins> ], additionalProperties: false }

Discussion:
! Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-23T05:16:43.681Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
It's actually allowed to have no scope (for the default fore/background), but the schema is too strict