jiebi/CodeConvo huggingface dataset:
Change:
disturl "https://electronjs.org/headers" <del> target "17.4.1" </del> <ins> target "17.4.3" </ins> runtime "electron" build_from_source "true"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.1 OS Version: Win 7 x64 Steps to Reproduce: update Electron to 17.4.3
Does this fix the high CPU usage on OSX? (introduced in 1.67.0)
Change:
*--------------------------------------------------------------------------------------------*/ 'use strict'; <del> import {Location, getLocation, createScanner, SyntaxKind} from 'jsonc-parser'; </del> <ins> import {Location, getLocation, createScanner, SyntaxKind, ScanError} from 'jsonc-parser'; </ins> import {basename} from 'path'; import {BowerJSONContribution} from './bowerJSONContribution'; import {PackageJSONContribution} from './packageJSONContribution';

Discussion:
VSCode Version: 1.1.0-alpha OS Version: Mac Steps to Reproduce: Regarding test plan Just found this very small bug (not an urgent one—ok to delay if necessary). just a package name in with no leading quotation mark (so it autocompletes the quotes for you) try adding a package with a leading quotation mark. Note that in the first case a comma is not , but in the second case a comma is . Not a huge deal, but consistency would be nice. Preferably, if it knows that it's on the last line of properties (i.e. the next line is a closing brace), then it would not insert a comma. But if it's in the middle of the list (i.e. the next line is another property in the JSON), then it would add a comma.
I always get a comma: Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Let me know if you saw another issue.
yes, that's what I was seeing. Thanks for checking!
Change:
// Intercept mouse events to override normal select actions on parents this.toDispose.push(dom.addDisposableListener(this.selectElement, dom.EventType.CLICK, (e) => { <del> this.showSelectDropDown(); </del> dom.EventHelper.stop(e); <ins> if (this._isVisible) { this.hideSelectDropDown(); } else { this.showSelectDropDown(); } </ins> })); this.toDispose.push(dom.addDisposableListener(this.selectElement, dom.EventType.MOUSE_UP, (e) => {

Discussion:
VSCode Version: Code - Insiders 1.20.0-insider (, 2017-12-19T07:32:34.862Z) OS Version: Windows_NT x64 10.0. Extensions: none Steps to Reproduce: Debug panel the top SelectBox [SelectBox expands] again at the same spot Expected result: SelectBox closes. Actual result: It stays expanded. It affects SelectBox on Debug and Output panels. Terminal panel SelectBox closes as expected.
thanks for the nice bug report, forwarding to fyi
Thanks, good bug find!
Fixed With:
thanks. the verified label should not be until our endgame where we verify all the bugs we had during a milestone. I will remove it so that we can have someone else verify the bug.
Thanks
Change:
*--------------------------------------------------------------------------------------------*/ import { Event } from 'vs/base/common/event'; <ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </ins> import { IURLService } from 'vs/platform/url/common/url'; import product from 'vs/platform/product/common/product'; import { app, Event as ElectronEvent } from 'electron';

Discussion:
Issue Type: <bBug</bcode-oss on windows into the browser and click "Open" in resulting dialog ! Works on Mac still, haven't tried Linux VS Code version: Code - OSS Dev 1.41.0 (Commit unknown, Date unknown) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Hi, I have tracked this down to ! It seems that when you run Code - , the command is missing: ! By hardcoding my vscode folder location in: ! The app is able to open: ! Is there a command/utility function that will give this location?
Bingo! You should add this to the array only if not .
Verification: This is a Windows only issue.
Change:
} renderElement(keybindingItemEntry: IKeybindingItemEntry, index: number, templateData: ISourceColumnTemplateData, height: number | undefined): void { <ins> templateData.disposables.clear(); </ins> if (isString(keybindingItemEntry.keybindingItem.source)) { templateData.extensionContainer.classList.add('hide'); templateData.sourceLabel.element.classList.remove('hide');

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Ubuntu 23.04 Steps to Reproduce: the keybindings editor () the keybindings editor opening and closing the keybindings editor a few more times that the number of , , event listeners increases each time: ~The in doesn't seem to be registered like other disposables:~ ~Disposing the ActionBar could perhaps fix the memory leak / the leaking event listeners.~ Edit: The ActionBar is actually properly disposed 40 lines below in the function.
Thank for you the issue and proposed fix! Very much appreciated!
Change:
.monaco-workbench .pane-composite-part > .title.has-composite-bar > .title-actions .monaco-action-bar .action-item, .monaco-workbench .pane-composite-part > .title.has-composite-bar > .global-actions .monaco-action-bar .action-item { <del> padding-right: 4px; /* Use padding instead of margin for width computation to be correct #200515 */ </del> <ins> margin-right: 4px; </ins> } .monaco-workbench .pane-composite-part > .title.has-composite-bar > .title-actions .monaco-action-bar .action-item .action-label {

Discussion:
extra padding right to the dropdown in terminal in insider release as shown in image below ! in stable release I don't see it !
also the terminal action also not work when I open the insiders window if create a one more terminal and then these actions start working !
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
Looks like regression by
Thanks for reporting these issues I created a separate issue for the second bug you mentioned here:
Change:
category: EDIT_SESSION_SYNC_CATEGORY, precondition: IsWebContext }; <ins> const showOutputChannelCommand: IAction2Options = { id: 'workbench.experimental.editSessions.actions.showOutputChannel', title: { value: localize('show log', 'Show Log'), original: 'Show Log' }, category: EDIT_SESSION_SYNC_CATEGORY }; const resumingProgressOptions = { location: ProgressLocation.Window, type: 'syncing', title: `[${localize('resuming edit session window', 'Resuming edit session...')}](command:${showOutputChannelCommand.id})` }; </ins> const queryParamName = 'editSessionId'; const experimentalSettingName = 'workbench.experimental.editSessions.enabled';

Discussion:
Testing ! It would be nice if that text is a hyperlink which opens the output channel, similar to above: !
/verified
Change:
if (event.selections[0].isEmpty) { matchingTagPositionProvider(event.textEditor.document, event.selections[0].active).then(matchingTagPosition => { if (matchingTagPosition && window.activeTextEditor) { <del> const charBeforeAndAfterPositionsRoughtlyEqual = isCharBeforeAndAfterPositionsRoughtlyEqual( </del> <ins> const charBeforeAndAfterPositionsRoughlyEqual = isCharBeforeAndAfterPositionsRoughlyEqual( </ins> event.textEditor.document, event.selections[0].anchor, new Position(matchingTagPosition.line, matchingTagPosition.character) ); <del> if (charBeforeAndAfterPositionsRoughtlyEqual) { </del> <ins> if (charBeforeAndAfterPositionsRoughlyEqual) { </ins> inMirrorMode = true; const newCursor = new Selection( matchingTagPosition.line,

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: macOS Steps to Reproduce: See the following gif: ! I first enter the tag which activates multicursor, then I use the key combi to select and jump to the end of the line, go one back and use "Backspace" to delete the attribute. This is a common operation, but now with mirror cursors it might break the HTML as seen in the gif above. Moreover, if the opening & closing tag are further apart, one might not even notice the HTML is broken. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Also this quite a lot as this is a very common operation. Related to this is ctrl+shift selecting out of the element tag name. I'd like to work on. The fix would be to exit mirror mode if the selection is not empty and we reach a none-matching state.
This also brings up an issue when you try to add an attribute to multiple tags that have none. ! If you click the open tag, it'll select the opening and closing, and usually when you're at the end and you press space to type in the attribute it doesn't add the attributes to the closing tag, but when you're adding more cursors to the tags in other lines, it doesn't act like that anymore and adds the attributes to both tags. I went crazy trying to find this to disable it.
Yeah looking at the current implementation, there's no support at all for multiple cursors. That's gonna take some work for the behavior to work correctly.
This feature doesn't work well with extension vim too, have to shut it down.
The fix will be available in until next month's release.
Change:
import { Event, EventMultiplexer } from 'vs/base/common/event'; import { <del> ILocalExtension, IGalleryExtension, IExtensionIdentifier, IExtensionsControlManifest, IExtensionGalleryService, InstallOptions, UninstallOptions, InstallVSIXOptions, InstallExtensionResult, ExtensionManagementError, ExtensionManagementErrorCode, Metadata, InstallOperation </del> <ins> ILocalExtension, IGalleryExtension, IExtensionIdentifier, IExtensionsControlManifest, IExtensionGalleryService, InstallOptions, UninstallOptions, InstallVSIXOptions, InstallExtensionResult, ExtensionManagementError, ExtensionManagementErrorCode, Metadata, InstallOperation, EXTENSION_INSTALL_SYNC_CONTEXT </ins> } from 'vs/platform/extensionManagement/common/extensionManagement'; import { DidChangeProfileForServerEvent, DidUninstallExtensionOnServerEvent, IExtensionManagementServer, IExtensionManagementServerService, InstallExtensionOnServerEvent, IWorkbenchExtensionManagementService, UninstallExtensionOnServerEvent } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; import { ExtensionType, isLanguagePackExtension, IExtensionManifest, getWorkspaceSupportTypeMessage, TargetPlatform } from 'vs/platform/extensions/common/extensions';

Discussion:
an extension that requires workspace trust to be installed/enabled synced to settings sync on settings sync from a new VS Code instance that doesn't have that extension installed/enabled already :bug: get this modal dialog that doesn't specify which extension requires workspace trust to be installed/enabled (I do not know which extension causes this to repro because the dialog doesn't say) !
since the install is not triggered explicitly by the user, the dialog does not make sense. Do you need anything from the workspace trust side to avoid this dialog, or vice versa, do you provide something to let us know that this is from settings sync?
I assume this is happening on the web client, because in Desktop Settings Sync install extensions on the shared process.
Change:
connection.languages.diagnostics.on(async (params, token): Promise<FullDocumentDiagnosticReport | UnchangedDocumentDiagnosticReport> => { logger.log(md.LogLevel.Trace, 'Server: connection.languages.diagnostics.on', params.textDocument.uri); <del> if (!config.getSettings()?.markdown.experimental.validate.enabled) { </del> <ins> if (!config.getSettings()?.markdown.validate.enabled) { </ins> return emptyDiagnosticsResponse; }

Discussion:
Add some form of error reporting for links in markdown files where we are confident that link is incorrect. Example: We should also have a setting to disable this error reporting since we will not be able to understand every flavor of markdown link
Bad references (seems like this should almost always be a reasonable error to report) Missing files (false positive if users rely on different logic to resolve markdown paths) - Missing headers (false positive if users rely on custom slugifier or are linking to something besides headers, such as html elements) -Checking links to external resources () Checking html in markdown
Re-opening as we will likely keep this as experimental this iteration
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Emitter } from 'vs/base/common/event'; </del> <ins> import { Emitter, Event } from 'vs/base/common/event'; </ins> import { splitName } from 'vs/base/common/labels'; import { Disposable, IDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { LinkedList } from 'vs/base/common/linkedList';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version:1.58.0 OS Version:MacOS Big Sur Steps to Reproduce: an untrusted folder (in my case, containing a VS Code Extension repo) command dialog appears, saying that "Listing and running tasks requires that some of the files in this workspace be executed as code...." the button banner is removed from VS Code window, but the dialog remains the button again the dialog closes, and the Task starts If instead of clicking the button twice (step 6), you simply close the dialog (click the X button), the build task starts normally (as it should, because I already trusted the folder) Thank you
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.531 --- <!-- score: 0.467 --- <!-- score: 0.457 --- <!-- score: 0.453 --<!-- potentialduplicatescomment --
The command hits two task entry points where I check for , but I thought that when I call on the second one it would just return . should I be checking if the workspace is already trusted before calling ?
I have looked into this and the issue is in the workspace trust service. Due to a regression introduced last milestone, we resolve the promise for before the workspace has fully transitioned from untrusted to trusted. I am working on a fix now.
Fix has been merged to the release branch.
Change:
(this.showOutgoingChanges() === 'auto' && (historyItemGroupDetails.outgoing.count ?? 0) > 0))) { children.push({ ...historyItemGroupDetails.outgoing, <ins> ariaLabel: localize('outgoingChangesAriaLabel', "Outgoing changes from {0}", historyItemGroupDetails.outgoing.label), </ins> repository: element, type: 'historyItemGroup' });

Discussion:
Testing a screenreader. to the Incoming/Outgoing part of the SCM viewlet. Actual: "Incoming/Outgoing". Expected: something like "Incoming and outgoing changes" screenreader reads origin/some-branch-name for the incoming changes. Expected: "origin/some-branch-name incoming" or "incoming changes from origin/some-branch-name" screenreader reads some-branch-name for the outgoing changes. Expected: "some-branch-name outgoing" or "outgoing changes from some-branch-name" CC for alternative suggestions
Great point, we should lead with the info, so place "outgoing" or "incoming" before the branch name in this case.
I have confirmed that the titles show up upon hovering over the entries, but that NVDA still reads the text as-is rather than reading the title text. Reopening.
That's interesting given that I am using the IconLabel widget's property to set the aria label.
Change:
"jschardet": "3.0.0", "keytar": "7.9.0", "minimist": "^1.2.6", <del> "native-is-elevated": "0.6.0", </del> <ins> "native-is-elevated": "0.7.0", </ins> "native-keymap": "^3.3.2", "native-watchdog": "^1.4.1", "node-pty": "1.1.0-beta1",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 (user setup) OS Version: Windows 10 22H2 To fix the issue please update the native-is-elevated package. It was fixed two months ago.
Could you maybe verify using our insiders? You can give our preview releases a try from:
It seems working properly now. Thanks!
Change:
// Verify edit session was correctly applied assert.equal((await fileService.readFile(fileUri)).value.toString(), fileContents); <ins> assert.equal(dialogServiceShowStub.called, false); </ins> }); test('Edit session not stored if there are no edits', async function () {

Discussion:
Testing Continue from web inside desktop Let the window sit Install update (which restarts the App) you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code) Ideas don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus don't show this when my local changes are no different to those on the server <img width="1391" alt="Screenshot 2022-08-24 at 09 26 13" src="https://user-"
Is the custom modal overlay the same thing as the custom modal dialog, i.e. :+1: I filed for this.
Change:
} export const config = { <del> version: product.electronRepository ? '19.1.10' : util.getElectronVersion(), </del> <ins> version: product.electronRepository ? '19.1.11' : util.getElectronVersion(), </ins> productAppName: product.nameLong, companyName: 'Microsoft Corporation', copyright: 'Copyright (C) 2022 Microsoft. All rights reserved',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith
Change:
private toggleDropdownMenu: () => void; constructor(toggleDropdownMenu: () => void) { <del> super(ToggleMenuAction.ID, nls.localize('more', "More"), null, true); </del> <ins> super(ToggleMenuAction.ID, nls.localize('moreActions', "More Actions..."), null, true); </ins> this.toggleDropdownMenu = toggleDropdownMenu; }

Discussion:
Environment Details: VSCode Version : 1.24.1 OS Version : WIN10 Additional Details: ScreenReaderNVDA[2018.2],JAWS[18.0.5038]MAS1.3.1,Voceover[MACOS High Sierra 10.13.5 Beta (17F70a)] Repro Steps: VS Code when NVDA is ON. to View(Alt+V) menu option and select "Extensions" from dropdown. to more button. what Screenreader reads. Actual: Screenreader reads as More button.It does not give extra information about the button what is inside the button. Same issue observed in Jaws and Voiceover also. Expected: Screenreader should give extra information about the button. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: User unable to get the information about the button. MAS Reference: Does this issue occur when all extensions are disabled?: Yes Attachment For Reference
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.69 --- <!-- score: 0.59 --- <!-- score: 0.509 --- <!-- score: 0.484 --- <!-- score: 0.476 --<!-- potentialduplicates_comment --
We should make the title of the more action more descriptive. Feels like low hanging fruit -july
that "More" text is the same "More" used throughout the application's secondary actions, would we create a bespoke label for all of them, or find some way to generate it?
let's try to use the same label for all of them. Consistency.
Oh so just "More Actions" or something?
More Actions works for me.
I verified the bug on below environment and the issue is no longer reproduced hence close this bug. Version: 1.27.0-insider Commit: Date: 2018-08-27T07:36:47.732Z Electron: 2.0.7 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 Architecture: x64
the issue is already closed, but thanks