jiebi/CodeConvo huggingface dataset:
Change:
"sideBarTitle.foreground": "#BBBBBB", "input.placeholderForeground": "#A6A6A6", "settings.textInputBackground": "#292929", <del> "settings.numberInputBackground": "#292929" </del> <ins> "settings.numberInputBackground": "#292929", "menu.background": "#252526", "menu.foreground": "#CCCCCC" </ins> } }  No newline at end of file

Discussion:
Issue Type: <bBug</bI think this change appeared in VS Code Insiders couple builds ago. New background for dropdowns in title menu bar and context menus ( is set to ) now have brighter background, which has to much contrast with editor background and makes it harder to read text on it. Also it appears much brighter than backgrounds for auto-suggestions dropdown and peek view. Is it intended change in Dark+ color theme or is it possible to revert it back to the same color as in current stable version (1.27)? Insider (left) and stable (right) ! VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-19T09:34:25.276Z) OS version: Windows_NT x64 10.0. Issue is reproducible without extensions. <details<summaryExtensions (26)</summaryExtensionVersion ------ markdown-toc1.5.6 vscode-css-modules1.0.1 spellright2.5.32 markdown-preview-github-styles0.1.3 vscode-css-modules0.2.3 bracket-pair-colorizer1.0.60 vscode-eslint1.6.0 gitlens8.5.6 remotehub0.2.0 EditorConfig0.12.4 tslint1.0.39 vscode-pull-request-github0.1.5 beautify1.4.3 rest-client0.19.1 code-fragments1.2.0 vsliveshare0.3.709 debugger-for-chrome4.10.1 debugger-for-edge1.0.5 vscode-docker0.2.0 material-icon-theme3.6.0 quicktype12.0.42 gi0.2.11 code-settings-sync3.1.2 dot0.0.1 quokka-vscode1.0.149 markdown-pdf1.2.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.459 --<!-- potentialduplicatescomment --
Change:
notebookEditorCursorAtBoundaryContext.set('none'); })); <del> this._localDisposableStore.add(this.view.onMouseDblClick(() => { const focus = this.getFocusedElements()[0]; if (focus && focus.cellKind === CellKind.Markup && !focus.isInputCollapsed && !this._viewModel?.options.isReadOnly) { // scroll the cell into view if out of viewport const focusedCellIndex = this._getViewIndexUpperBound(focus); if (focusedCellIndex >= 0) { this._revealInViewWithMinimalScrolling(focusedCellIndex); } focus.updateEditState(CellEditState.Editing, 'dbclick'); focus.focusMode = CellFocusMode.Editor; } })); </del> // update visibleRanges const updateVisibleRanges = () => { if (!this.view.length) {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --- Version: 1.94.0-insider (user setup) Commit: OS: Windows_NT x64 10.0. Jupyter Extension version (available under the Extensions sidebar): v2024.9. (pre-release) Python Extension version (available under the Extensions sidebar): v2024.15. (pre-release) First part of the video: cursor in a markdown cell, somewhere in the visible area of the screen out of the cell to double click somewhere in the visible area of the screen to highlight text (either same line or not) Cell scrolls to the top so I can't see what I'm trying to highlight (the text is highlighted as intended though) Second part of the video: cursor in markdown cell, somewhere in the NOT visible area of the screen out of the cell to double click somewhere in the visible area of the screen to highlight text Cell scrolls to the previously placed cursor area (which is great if I'm single-clicking into the cell, but in this case, it feels glitchy to me)
I have the same issue!
Change:
import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions'; import { ExtensionActivationReason, MissingExtensionDependency } from 'vs/workbench/services/extensions/common/extensions'; import { ILogService } from 'vs/platform/log/common/log'; <del> const NO_OP_VOID_PROMISE = Promise.resolve<void>(undefined); </del> <ins> import { Barrier } from 'vs/base/common/async'; </ins> /** * Represents the source code (module) of an extension.

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0 OS Version: Fedora 35 Steps to Reproduce: extension (v11.10.0) vscode, git extension is not initialized and restart, git extension works again With vscode-icons disabled With vscode-icons enabled
Reproduces with the following extension: : :
Change:
} private doUpdateTitle(): void { <del> const title = this.getWindowTitle(); </del> <ins> const title = this.getFullWindowTitle(); </ins> if (title !== this.title) { // Always set the native window title to identify us properly to the OS let nativeTitle = title;

Discussion:
Testing I think we will soon turn command center on by default. What is the impact on then? I see we are only showing the full title in the hover now, but I wonder if we need another setting (?) so that users still can configure what we show in the command center? ! Or maybe we should find a way to show the even in the command center with ellipsis if overflowing. //cc
Seems reasonable to me
Enabling the command centre removes my custom window title, showing the full path of the currently focussed editor. I find this very useful especially when there are files with the same name but in different directories. Can't the command centre show the full custom window title (without having to hover over it)? Without this, I would permanently disable it.
We can say the default is different but a customisation is honoured
To verify enable command center configure and/or validate that any customization is picked up by the CC reset above settings validate that the CC uses a default
Any reason we wouldn't also apply this with the default setting? My worry is that when we eventually make command center on by default, the setting would basically not work until you change it? I think it looks good when enabled even with default setting: !
The idea is that the CC shows an affordance to do something, like "Search vscode" - we replaced "search" with the icon which watered this down a bit. The worry is that the more title-stuff we put here the less likely it is that folks understand this as affordance
Change:
return this.writeFileIconConfiguration(settingsTarget); } let onApply = (newIconTheme: FileIconThemeData) => { <ins> this.doSetFileIconTheme(newIconTheme); // remember theme data for a quick restore </ins> if (newIconTheme) { <del> this.currentIconTheme = newIconTheme; </del> <ins> this.storageService.store(PERSISTED_ICON_THEME_STORAGE_KEY, newIconTheme.toStorageData()); </ins> } else { <del> this.currentIconTheme = FileIconThemeData.noIconTheme(); </del> <ins> this.storageService.remove(PERSISTED_ICON_THEME_STORAGE_KEY); </ins> } <del> if (this.container) { if (newIconTheme) { $(this.container).addClass(fileIconsEnabledClass); } else { $(this.container).removeClass(fileIconsEnabledClass); } } if (newIconTheme) { this.sendTelemetry(newIconTheme.id, newIconTheme.extensionData, 'fileIcon'); } this.onFileIconThemeChange.fire(this.currentIconTheme); </del> return this.writeFileIconConfiguration(settingsTarget); };

Discussion:
It would be nice if icons would show up directly after starting the workbench instead of having to wait for the extension host to be ready. Similar to color themes where the data is stored in local storage, the icons data should also be stored so that the overall experience is smooth.
can we consider this for this milestone? I want to mark this "perf-startup" because the fact that the icons only "kick in" later after the UI is already done makes the entire editor appear like a website that needs to load icons later separately which is ugly. It also causes some ugly jumping for opened tabs. ! /cc
PR:
Change:
switch (postCommitCommand) { case 'push': { title = localize('scm button commit and push title', "$(arrow-up) Commit & Push"); <del> tooltip = this.state.isActionRunning ? </del> <ins> tooltip = this.state.isCommitInProgress ? </ins> localize('scm button committing pushing tooltip', "Committing & Pushing Changes...") : localize('scm button commit push tooltip', "Commit & Push Changes"); break; } case 'sync': { title = localize('scm button commit and sync title', "$(sync) Commit & Sync"); <del> tooltip = this.state.isActionRunning ? </del> <ins> tooltip = this.state.isCommitInProgress ? </ins> localize('scm button committing synching tooltip', "Committing & Synching Changes...") : localize('scm button commit sync tooltip', "Commit & Sync Changes"); break; } default: { title = localize('scm button commit title', "$(check) Commit"); <del> tooltip = this.state.isActionRunning ? </del> <ins> tooltip = this.state.isCommitInProgress ? </ins> localize('scm button committing tooltip', "Committing Changes...") : localize('scm button commit tooltip', "Commit Changes"); break;

Discussion:
Create a commit. While the commit runs, the sync button spins as if it's syncing . The one in the statusbar does not. !
Change:
private configurationAttributes: any; public initialConfigurations: any[]; public enableBreakpointsFor: { languageIds: string[] }; <ins> public aiKey: string; </ins> constructor(rawAdapter: debug.IRawAdapter, systemVariables: SystemVariables, extensionFolderPath: string) { if (rawAdapter.windows) {

Discussion:
If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).
this is probably something you want to use...
The functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .
we are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?
yes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?
What we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.
For Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?
previously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.
Change:
const repositoryPath = await window.withProgress( opts, <del> (_, token) => this.git.clone(url!, parentPath, token) </del> <ins> (progress: Progress<{ message?: string, increment: number }>, token) => this.git.clone(url!, parentPath, progress, token) </ins> ); const choices = [];

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --When downloading a GIT repository should indicate the percentage of download. <!-- Describe the feature you'd like. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.484 --<!-- potentialduplicatescomment --
I would like to take this.
Change:
} } <del> if (rebase) { await repository.syncRebase(HEAD); } else { await repository.sync(HEAD); } </del> <ins> await repository.sync(HEAD, rebase); </ins> } @command('git.sync', { repository: true }) async sync(repository: Repository): Promise<void> { <ins> const config = workspace.getConfiguration('git', Uri.file(repository.root)); const rebase = config.get<boolean>('rebaseWhenSync', false) === true; </ins> try { <del> await this._sync(repository, false); </del> <ins> await this._sync(repository, rebase); </ins> } catch (err) { if (/Cancelled/i.test(err && (err.message || err.stderr || ''))) { return;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 10 Steps to Reproduce: .rebaseWhenSync true .postCommitCommand sync git.rebaseWhenSync true works on actionbutton and statusbar but it does not affect git.postCommitCommand sync
Change:
// Indicate as status to ARIA aria.status(message); <del> dom.hide(this.resultsElement); </del> const messageEl = this.clearMessage(); const p = dom.append(messageEl, $('p', undefined, message));

Discussion:
Search view, context menu on empty area -no context menu In this case we should still offer the option to move the search view to the panel. Since it is a "global" action, and it only appears when there are results in the search view
, can i take a look at this or are you working on this ? :)
You can take a look
, I understood how "Toggle Search View Position" works both in and functionality. So when we right click on the search result then only the option comes up , so it is bound to search result. So what is the approach we should take to fix this ? We need to move this whole functionality to somewhere else rite ? ( Like some button next "Refresh","Clear All Search Results".... ? ) Please suggest me the way forward :)
do you know how to add a context menu to an empty tree?
gets fired for every place in the tree, including empty items. Here's an example how I use this in the explorer
I think we should use that for this command, rather than
, I tried doing this and here is what I found. There is already trigger in If we remove this check then it will work on empty tree also ( ) In case of no results , we are showing custom message and here the tree is no longer in the view , so right clicking there would not work. ( ) Ideally if we remove that mentioned in case 2 , then what suggested is already there but as the tree itself is not valid in case of "No Search Results" because of showing some custom message described above. Please let me know the way forward to fix this :)
Good analysis. Can we change it to keep the tree in the DOM when that no results message is shown? Not sure how the tree is sized in css but it would have to be vertically flexible. Also, when I am right clicking on an empty tree, I should not see context menu items that are not valid without a row, like copy, dismiss, etc.
Change:
// Git config try { const mergeBase = await this.getConfig(branchMergeBaseConfigKey); <del> if (mergeBase) { return await this.getBranch(mergeBase); </del> <ins> if (mergeBase !== '') { const mergeBaseBranch = await this.getBranch(mergeBase); return mergeBaseBranch; </ins> } } catch (err) { }

Discussion:
Testing Currently and throw a non-obvious exception when a key is not defined: As discussed with these calls should better return an empty string.
Change:
import { Disposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions, IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Registry } from 'vs/platform/registry/common/platform'; <del> import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; </del> <ins> import { ILifecycleService, LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; </ins> import { Action2, IAction2Options, MenuRegistry, registerAction2 } from 'vs/platform/actions/common/actions'; import { ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { localize } from 'vs/nls';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.
On , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.
Change:
export const tasksSchemaId = 'vscode://schemas/tasks'; export const APPLICATION_SCOPES = [ConfigurationScope.APPLICATION]; <del> export const PROFILE_SCOPES = [ConfigurationScope.MACHINE, ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE]; </del> <ins> export const PROFILE_SCOPES = [ConfigurationScope.MACHINE, ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE, ConfigurationScope.MACHINE_OVERRIDABLE]; </ins> export const LOCAL_MACHINE_PROFILE_SCOPES = [ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE]; export const LOCAL_MACHINE_SCOPES = [ConfigurationScope.APPLICATION, ...LOCAL_MACHINE_PROFILE_SCOPES]; export const REMOTE_MACHINE_SCOPES = [ConfigurationScope.MACHINE, ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE, ConfigurationScope.MACHINE_OVERRIDABLE];

Discussion:
On a non-default profile, settings like , which are machine-overridable, do not have their value read properly by the configurationService even when the user specifies the value in the current profile
It seems to work now. I see the profile specific value being shown in the UI.
It still doesn't seem to work. I have a small extension that inspects the setting. When I run the command, it inspects the setting, and it doesn't pick up the profile setting there. I'll see if I can upload the test extension soon. Edit: I think what's happening is that profile changes aren't being picked up by the VS Code extension API. When I reload the window on a non-default profile and run the command, it gives me the correct globalValue, but if I then change to another non-default profile, it clears out the globalValue key and doesn't give it the new profile's value. !
I tried this with my sample extension (following) and it works as expected for me Edit: Sorry, I can repro it, forgot to set value for the setting in non-default profile.
Change:
for (const { views, from, to } of viewsToMove) { this.moveViewsWithoutSaving(views, from, to); } <ins> this.viewContainersCustomLocations = newViewContainerCustomizations; this.viewDescriptorsCustomLocations = newViewDescriptorCustomizations; </ins> } // Generated Container Id Format

Discussion:
In my default profile with gitlens installed, move 3 gitlens views to a new view container (in secondary side bar) Create an empty profile Switch back to default profile gitlens view are back in SCM instead of in their new view container CC
Works great, thank you!
Change:
disposables.add(part.onDidChangeGroupLocked(group => this._onDidChangeGroupLocked.fire(group))); } <ins> private doUpdateMostRecentActive(part: EditorPart, makeMostRecentlyActive?: boolean): void { const index = this.mostRecentActiveParts.indexOf(part); // Remove from MRU list if (index !== -1) { this.mostRecentActiveParts.splice(index, 1); } // Add to front as needed if (makeMostRecentlyActive) { this.mostRecentActiveParts.unshift(part); } } </ins> private getGroupsLabel(index: number): string { return localize('groupLabel', "Window {0}", index + 1); }

Discussion:
Currently we do not really track MRU of editor groups across windows. Some features rely on this though, so we should see if we can track MRU truly across aux windows.
Change:
state::{LauncherPaths, PersistedState}, trace, util::{ <del> errors::{wrap, AnyError, RefreshTokenNotAvailableError, StatusError, WrappedError}, </del> <ins> errors::{ wrap, AnyError, OAuthError, RefreshTokenNotAvailableError, StatusError, WrappedError, }, </ins> input::prompt_options, }, warning,

Discussion:
Windows 11 Latest Insiders WSL with Ubuntu 20.04.5 LTS I am trying to get and run the insiders code cli on a WSL Ubuntu 20.04 instance. the linux x64 insiders cli from here: and save the file to someplace in your WSL Ubuntu 20.04 folder : the file is the same name as the stable x64 version, so i'm not sure if am really getting insiders. , note the time stamp in the future error disc i see a executable, why is there a code-insiders`? see 2 above the GitHub login dance Result - it hangs in the terminal, no URL is displayed, here's the output from (which repeats):
can you try again with today's Insiders build of the CLI? It should print more detailed information about the error, if any, that's happening.
works great today! i was able to log in, get the URL, and hit it from another machine. still, why is the executable and not ? I see I can use the option but that breaks my flow (always use from the terminal)
That's a to fix, tracked in I'll go ahead and close this issue for now. I have a feeling it was something on GH's end, but at least next time we see this, we should be able to get more info.