jiebi/CodeConvo huggingface dataset:
Change:
protected abstract activate(): void; <del> focus(reveal: boolean = true): void { </del> <ins> focus(reveal: boolean = true, revealItem?: ITreeItem): void { </ins> if (this.tree && this.root.children && this.root.children.length > 0) { // Make sure the current selected element is revealed <del> const selectedElement = this.tree.getSelection()[0]; if (selectedElement && reveal) { this.tree.reveal(selectedElement, 0.5); </del> <ins> const element = revealItem ?? this.tree.getSelection()[0]; if (element && reveal) { this.tree.reveal(element, 0.5); </ins> } // Pass Focus to Viewer

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView. I'm using canSelectMany but this does not appear to make a difference one or more items in the view reveal with focus: true and select: false item will be expanded, but will not be scrolled to; instead one of the selected nodes is still shown. If no node is selected, the focused item is shown as expected. My use case is that I want to allow selecting multiple items in a tree, but the easiest way to navigate the tree is by clicking in a different view. When that happens, I call "reveal". I do not want to select as that would prevent multi-selection. So instead I chose "focus", which would be fine, except that if any selection exists in the tree, the tree will not scroll to the newly revealed node. Instead, it keeps one of the selected nodes visible (always the same one, not necessarily the closest one)
can you try out the latest insider build of VS Code: if the issue is fixed there, can you please respond with so we can mark this issue as verified to be fixed?

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
or maybe if you could provide steps. I tried to follow the original steps but I wasn't quite sure I understood.
/verified
Change:
import { EventEmitter } from 'events'; import * as iconv from '@vscode/iconv-lite-umd'; import * as filetype from 'file-type'; <del> import { assign, groupBy, IDisposable, toDisposable, dispose, mkdirp, readBytes, detectUnicodeEncoding, Encoding, onceEvent, splitInChunks, Limiter, Versions, isWindows, pathEquals } from './util'; </del> <ins> import { assign, groupBy, IDisposable, toDisposable, dispose, mkdirp, readBytes, detectUnicodeEncoding, Encoding, onceEvent, splitInChunks, Limiter, Versions, isWindows, pathEquals, isMacintosh } from './util'; </ins> import { CancellationError, CancellationToken, ConfigurationChangeEvent, LogOutputChannel, Progress, Uri, workspace } from 'vscode'; import { detectEncoding } from './encoding'; import { Ref, RefType, Branch, Remote, ForcePushMode, GitErrorCodes, LogOptions, Change, Status, CommitOptions, RefQuery, InitOptions } from './api/git';

Discussion:
I found issue that when switching to branch beggining from capital letter there is different treated by VS code plugin VS code version: Version: 1.77.1 (user setup) Commit: Date: 2023-04-04T23:21:11.906Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: WindowsNT x64 10.0. Sandboxed: No Git extension version: v1.0.0 and is bulit-in Git version: 40.0.windows.1 Let's describe it: created new branch in project 'feature/case-sensitive-issue' switched to new branch: staged and commited on new branch: could see commit and I was able to undo commit from button or conext menu ! switched to smae branch, but with upper-case in "Feature" path part: could not undo my commit from button: ! After try to undo commit from context menu I had warning: ! tried to undo commit using git api: It laready worked! ! tried to commit last changes again and it worked and was commited to branch "feature/case-sensitive-issue" although I was on branch "Feature/case-sensitive-issue". ! I don't know where is the problem: in git api or in git extension. Please help me with this issue and fix it. Regards, Michal
Branches view on your screenshots is most likely from GitLens extension, not built-in Git. Check if you have GitLens extension and if it's available if you disable it. Most likely this should be reported there first.
thnank you for your suggestion. You was right, screens are from gitlens extension, except one with warning "Can't undo because HEAD doesn't point to any commit". This is from Git built-in extension. After disabling gitlens I successfully reproduced described warning.
The "Can't undo because HEAD doesn't point to any commit" error is caused by the fact that we cannot get the details of the current branch when incorrect casing is used. This is due to the fact that we are not calling with the option. On Windows and macOS branch names are case-insensitive while on Linux and they are case sensitive.

Closing a repository on Windows that contains branch names that only differ by case, will result in only one branch being pulled. One potential solution would be that on Windows and macOS we include the flag.
Change:
Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfiguration({ ...editorConfigurationBaseNode, properties: { <del> 'editor.codeActionWidget.includeNearbyQuickfixes': { </del> <ins> 'editor.codeActionWidget.includeNearbyQuickFixes': { </ins> type: 'boolean', scope: ConfigurationScope.LANGUAGE_OVERRIDABLE, <del> description: nls.localize('includeNearbyQuickfixes', "Enable/disable showing nearest Quick Fix within a line when not currently on a diagnostic."), </del> <ins> description: nls.localize('includeNearbyQuickFixes', "Enable/disable showing nearest Quick Fix within a line when not currently on a diagnostic."), </ins> default: true, }, }

Discussion:
Testing I was expecting quick fixes for the whole line to be included, ranked by distance to the cursor, up to a certain maximum !
Yep! That was one thing I was experimenting with, and atm it does just find the closest one. Played around with allowing all quickfixes as well, but was unsure what would feel better. Will likely work on a version where we show all potential quickfixes in the line.
Change:
match acquire_singleton(&paths.tunnel_lockfile()).await { Ok(SingletonConnection::Client(stream)) => { debug!(log, "starting as client to singleton"); <del> if gateway_args.name.is_none() </del> <ins> if gateway_args.name.is_some() </ins> || !gateway_args.install_extension.is_empty() || gateway_args.tunnel.tunnel_id.is_some() {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (N/A) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.1 OS Version: macOS Steps to Reproduce: the shell, run , UPDATE: the system need to have a existing tunnel already running that the machine name is always inferred from Hostname instead of the machine name set through <img width="931" alt="image" src=""
Update: I noticed the "Connected to an existing tunnel..." line, and if I kill the tunnel first using and run the same command, it would correctly set the machine name. I'll update the issue description to reflect that.
Yea, if there's an existing tunnel we just connect to it and never enter the process in which the name would be set. Renaming a running tunnel is also possible but could lead to unpredictable side effects. We should just log a warning in this case.
I'm not seeing any warning:
still no warning. I made sure I was on the latest !
in your screenshot you can see the warning which is what I for this.
Change:
}); }); <ins> test('issue #148256: Pressing Enter creates line with bad indent with insertSpaces: true', () => { usingCursor({ text: [ '  t' ], }, (editor, model, viewModel) => { moveTo(editor, viewModel, 1, 4, false); viewModel.type('n', 'keyboard'); assert.strictEqual(model.getValue(), '  tn    '); }); }); test('issue #148256: Pressing Enter creates line with bad indent with insertSpaces: false', () => { usingCursor({ text: [ '  t' ] }, (editor, model, viewModel) => { model.updateOptions({ insertSpaces: false }); moveTo(editor, viewModel, 1, 4, false); viewModel.type('n', 'keyboard'); assert.strictEqual(model.getValue(), '  tnt'); }); }); </ins> test('removeAutoWhitespace off', () => { usingCursor({ text: [

Discussion:
Issue Type: <bBug</bPlease look this, ! Line 2: "Text" Line 3: .... This is auto indent line. ? (:, : ) ABC
I update this issue. But, It is automaticaly closed. Why? Please look this updated isuue.
What are the steps to reproduce? What is happening versus what you would expect to happen?
First line is, ( is white space, is Tab code) "Text" + -key Actual input is: (The above procedure removes the white space.) [Tab]-key, "Text", (move coursor position to the beginning of line), [Space][Space], (move coursor position to end of line), [Enter] The next cursor position is invalid. Please look the image of issue. I think, this is not serious but incorrect behavior.
Thank you for the extra information. Here are simplified steps: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain if indentation is configured with spaces, the new line will contain
Thanks.
can we have some verification steps?
Posting again with more explanations: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain . <---- this is a bug, the result should be such that the second line aligns with the first line if indentation is configured with spaces, the new line will contain <--- this is a bug, the result should be such that the second line aligns with the first line
Change:
import { binarySearch } from 'vs/base/common/arrays'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; <ins> import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; </ins> function getProviderStorageKey(provider: ISCMProvider): string { return `${provider.contextValue}:${provider.label}${provider.rootUri ? `:${provider.rootUri.toString()}` : ''}`;

Discussion:
I end up with all my repositories selected when going into an empty profile and out again: !
we figured out together that this reproduces easily by running the command to restart the extension host while having 1 repository selected. The underlying issue is that there are events fired from the extension host being disposed. This somehow has an impact on the state of the selected repositories and should probably be ignored or handled differently.
Change:
<ins> hello world; // new line y </ins>  No newline at end of file

Discussion:
. To verify the bugfix, check that in the newest version of the monaco editor the alignment is as expected. edit from <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.89.1 (user setup) Commit: Date: 2024-05-07T05:13:33.891Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. Searched existing issues by "compare vertical alignment" - no relevant results. Steps to Reproduce: files test2 and test1 them Fact wrong vertical alignment of identical rows after delete-add section ! Expected !
Thanks for sharing the input documents and the screenshot! Unfortunately, it is still not clear what this issue is about - I don't see a big difference in the screenshots. Can you add more details?
difference (expected empty range) is shown on this picture !
Ahh, I see. Can you check the dev console?
No. I want fix in my test. Not in dev console. Can you reproduce my simple test in user interface?
No, I cannot reproduce. But I think VS Code might have logged some errors to the VS Code dev console. You could help me fixing this bug, but sharing if there are any error messages in the VS Code dev console.
Show your comparison result. Here is log from dev console: An iframe which has both allow-scripts and allow-same-origin for its sandbox attribute can escape its sandboxing. !
Change:
readonly runGutter: number; readonly dragAndDropEnabled: boolean; readonly fontSize: number; <ins> readonly fontFamily: string; </ins> readonly markupFontSize: number; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider (Universal) Commit: OS Version: Mac OS Monterey 12.2.1 Follow up issue to as this is a degradation in UX compared to the non-Insider version. Any input on that ? Current: ! Expected: Different columns should be aligned !
thank you for the bug report!
Change:
this.roots = await this.fetchRoots(); for (const root of this.roots) { if (this.canSelect) { <del> root.checkbox = { isChecked: true }; </del> <ins> root.checkbox = { isChecked: true, tooltip: localize('select', "Select {0}", root.label.label) }; </ins> } else { root.checkbox = undefined; }

Discussion:
Type: <bBug</bcc: Steps to reproduce: VSCode press ctrl+shift+p, choose 'profiles: show content' and press the enter key. navigating the displayed screen using the tab and shift+tab keys. In my environment, every time I press tab or shift+tab, orca just reads something like checked check box. Orca cannot inform what is associated with the checkbox. The problem also happens in version 1.76. VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-15T05:21:59.212Z) OS version: Linux x64 6.1.15-200.fc37.x8664 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (39)</summaryExtensionVersion ------ doxdocgen1.4.0 vscode-markdownlint0.49.0 vscode-chatgpt3.9.5 rest-client0.25.1 better-cpp-syntax1.17.2 azure-pipelines1.208.0 vscode-docker1.24.0 csharp1.25.4 vscode-dotnet-runtime1.6.0 vscode-kubernetes-tools1.3.11 remote-containers0.284.0 remote-ssh0.99. remote-ssh-edit0.84.0 azure-account0.11.3 cmake-tools1.13.45 cpptools1.14.4 cpptools-extension-pack1.3.0 makefile-tools0.6.0 powershell-preview2023.3.0 remote-explorer0.3. vsliveshare1.0.5834 oracledevtools21.5.0 fabric8-analytics0.3.6 java1.16. vscode-xml0.25. vscode-yaml1.12.1 sonarlint-vscode3.15.1 cmake0.0.17 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-boot-dev-pack0.2.1 vscode-spring-boot1.45.0 vscode-java-debug0.49. vscode-java-dependency0.21. vscode-java-pack0.25. vscode-java-test0.38. vscode-maven0.40.

vscode-spring-boot-dashboard0.11.1 vscode-spring-initializr0.11.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
great catch! And thanks for trying out profiles! we should invest into making sure the profile import flow is accessible. It might be as easy as adding aria-labels. We can also sit down together for this.
Tree uses up and down arrows for navigation and I am using the custom tree view underneath. I also see the same behaviour in the PR view. So I assume this has to be fixed in the custom tree view.
is this in ? The checkbox has a that you can set. You can set the and then that should be read by screen readers. The checkbox is still proposed extension API, so before we finalize we would need to also add an aria label:
It turned out perfect, great job. I would like to add two small suggestions that I think would improve accessibility. could be moved to the first field on the page once the page is displayed. Currently, you have to press the tab key a few times to find the beginning of the page. could also have shortcut keys associated with the close and export buttons.
thanks! Could you create a new issue with these suggestions please :)
Change:
const decorations: IModelDeltaDecoration[] = action.action.diagnostics.map(diagnostic => ({ range: diagnostic, options: CodeActionController.DECORATION })); currentDecorations.set(decorations); const diagnostic = action.action.diagnostics[0]; <del> const selectionText = this._editor.getModel()?.getWordAtPosition({ lineNumber: diagnostic.startLineNumber, column: diagnostic.startColumn })?.word; aria.status(localize('editingNewSelection', "Context: {0} at line {1} and column {2}.", selectionText, diagnostic.startLineNumber, diagnostic.startColumn)); </del> <ins> if (diagnostic.startLineNumber && diagnostic.startColumn) { const selectionText = this._editor.getModel()?.getWordAtPosition({ lineNumber: diagnostic.startLineNumber, column: diagnostic.startColumn })?.word; aria.status(localize('editingNewSelection', "Context: {0} at line {1} and column {2}.", selectionText, diagnostic.startLineNumber, diagnostic.startColumn)); } </ins> } else { currentDecorations.clear(); }

Discussion:
run code-oss open light bulb menu error below is printed
do you know if this is related to
I looked at the file and the stack trace refers to the method and that the inside of appears to be undefined. I think this is probably not linked to It looks however that the diagnostics array is empty, and the code is trying to access the first non-existent diagnostic.
yep I see that now! looks like some flow from the light bulb widget exposed a bug with which i wrote a few months ago taking a look now ~
I have encountered this today when running code-oss. Find the unminified trace below. I believe the flaw is accessing the array of diagnostics because there is no check that it has any elements. Hence it continues with
yep, realized that the fix I pushed last week was not an actual fix this PR should do it, checking that the array is not empty. just for personal reference, I am curious which code action was giving this error? I wasn't able to see the error on any of the actions or copilot actions
Hard to say but since I am seeing this with insiders and code-oss means it must be an extension that is installed in both and that's either TS or copilot.
gotcha, that makes sense. iirc, it could be both, since code actions from the lightbulb, when there are no errors in the line, shouldn't have diagnostics attached to them. either way, if you could verify the fix that would be great
Change looks good,
makes sense! that was something I in the first PR quickly since I thought that would fix the initial issue, removing now for debt
Change:
exit 1 esac <del> exit $RETVAL </del>  No newline at end of file <ins> exit $RETVAL </ins>

Discussion:
Lately almost every Linux CI build fails on GH in our unit tests. Using your build with debug symbols (from ):
I've been tracking this in browserless, and have narrowed it down to libglapi-mesa or one of their sibling libs. I don't have a solution, but thought I'd help point you in some direction as I'm struggling with this one as well
oh thanks for chiming in, this seems to have started for us since a couple of days ago (). Is this a GH CI issue that should be reported?
I don’t think so, it’s prevalent in any Debian system I’ve encountered unfortunately
I believe I have this fixed by pinning these libs manually: I'll likely discuss this with the headless-dev mail group and see if they have better workarounds as this isn't viable longer term
This is unrelated to Electron 7, it even fails after our revert back to Electron 6 ():
Fixed by passing to (credits to )
Epic!
Change:
), ...commands.map(c => $('tr', undefined, $('td', undefined, $('code', undefined, c.id)), <del> $('td', undefined, c.title), </del> <ins> $('td', undefined, typeof c.title === 'string' ? c.title : c.title.value), </ins> $('td', undefined, ...c.keybindings.map(keybinding => renderKeybinding(keybinding))), $('td', undefined, ...c.menus.map(context => $('code', undefined, context))) ))

Discussion:
Testing in Firefox with de-ch (Swiss German) set. Open command palette and search for Remote Repositories commands :bug: The first command has a partly English, partly de-ch line under it ( and in English, seems to be de-ch translated) !
Hmm yeah it should look like this (Desktop screenshot) with the English strings next to the German strings. I think this is a bug in how I'm applying the translations... !
Just found out about these functions on the desktop side: Which seems to go through the manifest and turn some s into s. I followed up with to understand how this works.
This code was originally written by so I would ask him to know how this works.
Not quite, it was originally written by , but I'm happy to try and help. My understanding is that the code is taking a JSON object that looks like this: Together with another JSON object that looks like this: And produces a JSON object that looks like this by substituting all string values of the shape with their corresponding value:
I still see this on firefox: ! The first option's english translation still looks wrong? (tested on )
The first one is still wrong because of so we'll track that there. However, the rest now have the English string underneath which they use to not have, which means this is fixed and verified