jiebi/CodeConvo huggingface dataset:
Change:
normalize-path "~3.0.0" readdirp "~3.5.0" optionalDependencies: <del> fsevents "~2.1.2" </del> <ins> fsevents "~2.3.1" </ins> cookie@^0.4.0: version "0.4.0"

Discussion:
Steps to Reproduce: on Apple SI a folder in devtools:
Related failing unit test:
Chokidar v3.5.0 was just released that takes in fsevents universal build , we can update to it.
yep this required compiling fsevents as universal binary
Change:
import { Schemas } from 'vs/base/common/network'; import { renderCodicons, markdownEscapeEscapedCodicons } from 'vs/base/common/codicons'; import { resolvePath } from 'vs/base/common/resources'; <ins> import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; </ins> export interface MarkedOptions extends marked.MarkedOptions { baseUrl?: never;

Discussion:
I have muscle memory for middle-clicking on links (to open in a new tab) and it doesn't work in VS Code. ! If I middle-click on the link above, it opens a browser to
are you using VSCode in Electron or Web? Does it work when you click normally and if so what happens then?
This is in Electron (haven't tried on the web). And it works perfectly on a normal click.
OK, making this open for help if someone wants to chime in.
Created a PR to fix this
History shows as the one introducing the handler but I am not sure who the owner is today.
Change:
private disposables: Disposable[] = []; constructor(readonly repository: Repository) { <del> this._state = { HEAD: undefined, isActionRunning: false, repositoryHasChanges: false }; </del> <ins> this._state = { HEAD: undefined, isCommitInProgress: false, isSyncInProgress: false, repositoryHasChanges: false }; </ins> repository.onDidRunGitStatus(this.onDidRunGitStatus, this, this.disposables); repository.onDidChangeOperations(this.onDidChangeOperations, this, this.disposables);

Discussion:
Create a commit. While the commit runs, the sync button spins as if it's syncing . The one in the statusbar does not. !
Change:
this._adjustContentsBottomPadding(); this._adjustHoverHeightForScrollbar(height); } <ins> if (this._visibleData?.showAtPosition) { const widgetHeight = dom.getTotalHeight(this._hover.containerDomNode); this._positionPreference = this._findPositionPreference(widgetHeight, this._visibleData.showAtPosition); } </ins> this._layoutContentWidget(); }

Discussion:
open scroll such that the viewport starts at line 131 hover over the (good) observe that the hover renders above the symbol because it fits hold cmd and slightly move mouse (bug) observe that the hover renders on top of the symbol. It should render below since it doesn't fit above.
An easier reproducible example. Simply hover over :
I have same problem, confirm this bug.
I have reproduced this bug, I will be looking into it.
The bug is caused because the hover placement is not updated when the content changes. A PR with a fix has been made.
Change:
} } <del> private _stopAll(): void { </del> <ins> private _stopAll() { </ins> // Remove any existing decorations <del> // TODO: @Yoyokrazy - this triggers as notebooks scroll, causing highlights to disappear momentarily. </del> <ins> // TODO: @Yoyokrazy -- this triggers as notebooks scroll, causing highlights to disappear momentarily. // maybe a nb type check? </ins> this._removeAllDecorations(); // Cancel any renderDecorationsTimer

Discussion:
There is a strange issue in vs code when i split the window, and click on any code or syntax , it will highlight similar code/syntax but the highlig ht is persistent, it wont go away, it works fine in the first window but when it gets split to the right it doesnt work if i click anywhere else in the window, in the left side the currentCrew is highlighted now, it just wont clear. sys info Version: 1.84.2 (Universal) Commit: Date: 2023-11-09T10:52:33.687Z (1 wk ago) Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 21.6.0 <img width="1680" alt="Screen Shot 2023-11-22 at 9 42 52 AM" src=""
could you help with triaging this issue? Thanks!
Change:
} }, { <del> "name": "Function Call Variable", "scope": "variable.other.property", "settings": { "fontStyle": "n    ttt", "foreground": "#9872A2" } }, { </del> "name": "Keyword Control", "scope": "keyword.control", "settings": {

Discussion:
VSCode Version: 1.13.0 OS Version: Mint 18 Steps to Reproduce: to print `this.someMethod(); You can see, that "this" is colorless. It's so bad, because I need with this highlight when I work with classes. For example comparsion between VS code(left) and Sublime (right). Also highlight for arguments sometimes is in place, sometimes is not. !
You can install extension for this. I recommended or
This is not a bug in the grammar. Other themes colorize just fine: ! Monokai does not however
Change:
return null; })); <del> this.mru = data.mru.map(i => this.editors[i]); </del> <ins> this.mru = coalesce(data.mru.map(i => this.editors[i])); </ins> this.active = this.mru[0];

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --I'm unsure how I got into this state, but I can't close VS Code or reload the window. Stack sohwn when I try to exit:
I cannot explain this, it seems the editor tabs model think there is an editor that does not exist anymore. Needs steps to get any further.
Upon second thought, this can maybe happen if an editor fails to serialize on shutdown. Given we have quite a few new editors, maybe this happens more often now. Marking as candidate to look into and guard against this condition.
Yea, if I recall correctly this happened after I had been playing around with notebooks/custom editors in that window.
if you can try to reproduce, it would still be great to have steps
I have a feeling this could well be notebooks given how the always returns data but the may not. //cc to check if that is a problem. If you know for a fact that you cannot serialize the notebook, please already signal that by returning from the method.
this, I guess we just need to return !(input instanceof NotebookEditorInput)`?
To clarify: it is perfectly valid to return in either of the 2 methods. I pushed a fix to handle this properly on my end. I just wanted to point out that it is always better to return early (from the ) to reduce the data we store in SQLite.
But my that the notebook editor input factory is only called with "my" inputs is valid, right? Or should I assume that it is called with any kind of input and return undefined then?
yeah that assumption is right, you will only be called for inputs you register the factory for.
I don't think anyone has a consistent repro for this, so I will mark it as verified unless I run into it again.
Change:
})); } <del> private showHover(): void { </del> <ins> private showHover(skipFadeInAnimation: boolean = false): void { </ins> if (this.hover.value) { return; }

Discussion:
Native browser tooltips and many custom ones (Figma, Discord, Edge tabs) keep the tooltip element visible when moving between elements. Would be nice to do the same, to make mouse exploration even snappier. Discord icon bar: ! macOS dock: !
cc as this discussion was spawned off cc as owner of the hover widget cc as we talked about this a few times and he brought it up most recently in the team chat
fyi I'm the main hover widget person This seems doable, needs some thinking on how this would be exposed in the API. It's also a feature of native browser tooltips when hovering from one element with to another.
Thanks for confirmation :)
Change:
? Event.map(Event.filter<{ element: IQuickPickElement; checked: boolean }>(this._onChecked.event, e => e.element === this), e => e.checked) : Event.None; <del> this._saneDescription = item.description; </del> this._saneDetail = item.detail; <del> this._saneTooltip = this.item.tooltip; </del> this._labelHighlights = item.highlights?.label; this._descriptionHighlights = item.highlights?.description; this._detailHighlights = item.highlights?.detail;

Discussion:
So that we can add full path to Quick Search
Verification: Open from the command palette search for something Notice the folder paths next to the names of the files - that's the description! <img width="623" alt="image" src=""
Change:
const endOffset = lineTokens.getEndOffset(this.lineTokenOffset); // Is there a bracket token next? Only consume text. <del> if (containsBracketType && isOther && endOffset !== this.lineCharOffset) { </del> <ins> if (containsBracketType && isOther && this.lineCharOffset < endOffset) { </ins> const languageId = lineTokens.getLanguageId(this.lineTokenOffset); const text = this.line.substring(this.lineCharOffset, endOffset);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 11 Steps to Reproduce: a q file, e.g. test.q and press enter freezes I detected this before when I try to use the Bracket Pair Colorization plugin, but this feature is enabled by default, so I have to raise this issue. Also, this happens even if I disable it Look at this weird color. ! works, freezes. Related issue
Thanks for reporting this! Please also report bugs for non-default configuration, as this helps us to improve the quality of the product. I will look into this very soon.
I'm quite sure this is caused by invalid (here: unsorted) semantic tokens reported by the extension. These are the line tokens that bracket pair colorization is working on: ! The value in the array at position 12 is wrong, as it is smaller than the previous one. This causes the endless-loop. However, I only have been able to reproduce this on the latest stable. did you fix something for semantic tokens already this milestone?
I think this got fixed with
Thank you very much. I will take a look semantic highlight on my side as well.
If you investigate, please post here the semantic tokens that you were returning for this line. I would like to double check that does indeed fix this case too.
Sure, I will let you know.
I was also curious so I a breakpoint to investigate.

When the document is empty, there are no semantic tokens (), and then after pasting we get back a document semantic tokens edit with the following data:
My extension returns 3 semantic tokens for in following order 0 10 1 1 0 -2nd x 0 14 1 1 0 -3rd x 0 8 1 1 0 -1st x And the final result is actually (15) [0, 10, 1, 1, 0, 0, 4, 1, 1, 0, 0, -6, 1, 1, 0] I need to sort the semantic tokens and push.
I have fixed semantic tokens on my side, and vscode doesn't freeze anymore. Thank you very much for your help!!
Change:
"#endregion" ], "description": "Folding Region End" <ins> }, "Try Catch Block": { "prefix": "try", "body": [ "try {", "t${1://code...}", "} catch (Exception $$e) {", "t${2://throw $$e;}", "}" ], "description": "Try catch block" </ins> } }  No newline at end of file

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Try catch block to snippets
Change:
"source-map-support": "^0.3.2", "style-loader": "^1.0.0", "ts-loader": "^6.2.1", <del> "tsec": "0.1.1", </del> <ins> "tsec": "0.1.3", </ins> "typescript": "4.2.0-dev.20201207", "typescript-formatter": "7.1.0", "underscore": "^1.8.2",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --See for context the tsec-compile-check action currently has a many outputs, making it difficult to notice when new security-sensitive code is . by listing all of the current violations in the tsec exemption file we can ensure that the output of tsec-compile-check stays empty unless someone adds code with a new violation.
wow. chrismas-clean
Thanks for this. I believe it's again time to enable this in the CI pipelines and to bring back the tsserver integration. The only remaining worry is our aggressive TS adoption strategy which can often mean that tsec is facing TS features is doesn't understand yet.
tsec is part of our CI pipeline I also tried to configure the tsserver plugin but I couldn't get it to accept the exemptions list. I have tried with below snippet in
for visibility on the tssever plugin issue
There is a bug in the plugin. Fix is on the way.
The bug in the plugin should have been fixed in 0.1.4.
Thanks. Adopted and enabled
Change:
let resolvedAbsolute = false; for (let i = pathSegments.length - 1; i >= -1 && !resolvedAbsolute; i--) { <del> const path = i >= 0 ? pathSegments[i] : process.cwd(); </del> <ins> const path = i >= 0 ? pathSegments[i] : posixCwd(); </ins> validateString(path, 'path');

Discussion:
We will ship Electron with to stable soon so we should also look into bringing our copy of library to the same version. Checking for the diff, it seems to be a few commits after and up until //cc
Hm, the first change is already pretty bad for us: Because it seems to depend on a new thing which is maybe defined globally and probably optimised / cached / snapshotted. Maybe we should rather look out for actual bug fixes and focus on those... Changes: I think only the 2 fix commits stand out from the others
I assume you skipped over right?
Reopening given unit test failures, I had to revert the change for now.
yes I skipped the primordials. I didn't dig into why they do this, but it seemed easy enough to just call the string functions instead. As for the test failures, new PR
Primordials are only meant for Nodejs internal code usage, external users should just replace them with corresponding JavaScript builtins. You can read more about why Nodejs does it
Change:
if (action instanceof MenuItemAction && action.menuKeybinding) { primaryActions.push(action.menuKeybinding); } else if (!(action instanceof SubmenuItemAction || action instanceof ToggleMenuAction)) { <del> primaryActions.push(createConfigureKeybindingAction(action.id, undefined, this._commandService, this._keybindingService)); </del> <ins> const isDisabled = action.id.startsWith('statusbaraction'); // We can't support keybinding configuration for scm statusbar actions primaryActions.push(createConfigureKeybindingAction(this._commandService, this._keybindingService, action.id, undefined, !isDisabled)); </ins> } // -- Hide Actions --

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.2 OS Version: Windows 23H2 Steps to Reproduce: sure you have multiple repos click on the commit id/branch of one repro, then select "Configure Keybinding" 't find the command !
as each of these commands is distinct, what would be the right approach to enable this functionality?
We are unable to support the action for status bar actions. Let me disable it.
Looks disabled now !
I think we should completely remove the action as that will never work as far as I understood.
I think it's fine to align with the hide action and disable the action when it's not supported. Each action in that toolbar has the hide and key binding action, so I think it makes more sense to disable these actions when they are not supported compared to just not showing them for some actions
Change:
this.createBody(this.rootElement); this.addCtrlAInterceptor(this.rootElement); this.updateStyles(); <ins> this._register(registerNavigableContainer({ focusNotifiers: [this], focusNextWidget: () => { if (this.searchWidget.inputWidget.hasWidgetFocus()) { this.focusTOC(); } }, focusPreviousWidget: () => { if (!this.searchWidget.inputWidget.hasWidgetFocus()) { this.focusSearch(); } } })); </ins> } override async setInput(input: SettingsEditor2Input, options: ISettingsEditorOptions | undefined, context: IEditorOpenContext, token: CancellationToken): Promise<void> {

Discussion:
Testing Not sure if the settings editor is intended to support this, but it seems very similar to the other places that do support it.
I'll try to fix that, if it should be supported
Change:
layout(width: number, height: number): void; } <del> /* TODO: - NEW: 	add a color to show a border where the sash is, similar to how other widgets have a color (e.g. Button, with applyStyles). Challenge is that this color has to be applied via JS and not CSS to not apply it to all views NOT CSS */ </del> export function orthogonal(orientation: Orientation): Orientation { return orientation === Orientation.VERTICAL ? Orientation.HORIZONTAL : Orientation.VERTICAL; }

Discussion:
Steps to Reproduce: 2x2 grid it again =the layout flips (top right editor ends up bottom left)
Change:
import { IAction, Separator } from 'vs/base/common/actions'; import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; <ins> import { isMacintosh } from 'vs/base/common/platform'; </ins> import { ICodeEditor, IEditorMouseEvent, MouseTargetType } from 'vs/editor/browser/editorBrowser'; import { registerEditorContribution, EditorContributionInstantiation } from 'vs/editor/browser/editorExtensions'; import { IEditorContribution } from 'vs/editor/common/editorCommon';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: Mac OS Ventura 13.2.1 +click on the "play" icon next to a test (e.g. in ). Screenshot: <img width="583" alt="image" src="https://user-"Will bring up the context menu, like ctrl+clicking on a file tab header will. Executes the primary left-click action, which is to run the test with defaults.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
It reproduces exactly the same in 1.76.0. I have edited the bug description.
sending this your way since you're redoing the context menus here
Seems like ctrl+click in the gutter shows the context menu everywhere except for test decorations so I think this was just never implemented, therefore marking as feature request.
Wow, thanks for the super quick turnaround!
Change:
const index = this.viewCell.outputsViewModels.indexOf(this.output); if (this.viewCell.isOutputCollapsed || !this.notebookEditor.hasModel()) { <ins> this.cellOutputContainer.flagAsStale(); </ins> return undefined; }

Discussion:
Type: <bBug</bWhen a notebook updates text in a collapsed cells unexpected things happen. The Jupyter Notebook renders the output while still showing that the output is collapsed. Node.JS Notebooks and httpBook show empty cells and will only show the output again when expanded, collapsed, expanded again In the the result looks like this: ! Issue created to hopefully follow up Extension version: 2023.9. VS Code version: Code 1.83.1 (Universal) (, 2023-10-10T23:46:55.789Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
} protected override createMouseController(options: ITreeNodeListOptions<T, TFilterData, TRef>): MouseController<ITreeNode<T, TFilterData>> { <del> return new TreeNodeListMouseController(this, options.tree); </del> <ins> return new TreeNodeListMouseController(this, options.tree, options.stickyScrollProvider); </ins> } override splice(start: number, deleteCount: number, elements: readonly ITreeNode<T, TFilterData>[] = []): void {

Discussion:
Testing Repro: a node in a tree that is fairly deep. a parent node. that there's a slight flicker. Consecutive collapse/expands don't have that, only the first. ]()
Change:
"tas-client-umd": "0.1.8", "vscode-oniguruma": "1.7.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.7", "xterm-addon-canvas": "0.5.0-beta.2", "xterm-addon-image": "0.4.2", "xterm-addon-search": "0.13.0-beta.2", </del> <ins> "xterm": "5.3.0-beta.17", "xterm-addon-canvas": "0.5.0-beta.5", "xterm-addon-image": "0.4.3", "xterm-addon-search": "0.13.0-beta.4", </ins> "xterm-addon-unicode11": "0.5.0", <del> "xterm-addon-webgl": "0.16.0-beta.2" </del> <ins> "xterm-addon-webgl": "0.16.0-beta.4" </ins> } }

Discussion:
Testing Enabled smooth scrolling, reloaded the window but it looks like smooth scrolling is not working in the following scenarios: page up/page down while jumping between search results
Upstream:
try try