jiebi/CodeConvo huggingface dataset:
Change:
useShadows: true, verticalHasArrows: false, horizontalHasArrows: false, <del> alwaysConsumeMouseWheel: false </del> <ins> alwaysConsumeMouseWheel: true </ins> }, overviewRulerLanes: 2, fixedOverflowWidgets: true,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 OS Version: Windows_NT x64 10.0. Steps to Reproduce: go to references/definitions to open a reference view window to the bottom of the embedded editor scrolling will scroll the outer editor It's quite annoying sometimes, make it behaves like the file tree in the right side would be nice But I saw this, so is this behavior intended? If so may I ask why?
To verify open peek references in embedded editor scroll to the end and make sure scrolling stops
Verified on
Change:
return 0; } <ins> export function isAsciiDigit(code: number): boolean { return code >= CharCode.Digit0 && code <= CharCode.Digit9; } </ins> export function isLowerAsciiLetter(code: number): boolean { return code >= CharCode.a && code <= CharCode.z; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 OS Version: Windows/Linux Steps to Reproduce: there is a keybinding to . a camel case word with a number immediately preceding an upper case character and leave the cursor at the end of the word, e.g. "foo1Bar|". via keybinding in (1). the cursor to end up before the upper case character (i.e. ), but cursor is observed to be at the beginning of the camel case word (i.e. ).
Will like to request for a review on the issue/MR please. /cc
Still an issue in version 1.67.1. Linked MR is ready for review.
Similar issues: ("Feature 1")
Change:
function shouldShowProgress(operation: Operation): boolean { switch (operation) { <del> case Operation.Fetch: </del> <ins> case Operation.FetchNoProgress: </ins> case Operation.CheckIgnore: case Operation.GetObjectDetails: case Operation.Show:

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 (system setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: When i run command, i don't know whether it is complete or not. There is no circle loading animation. !
It looks like, it was not do show progress while the operation is being executed. Thinking about it, I do think that if one has auto-fetch enabled it might be quite distracting to show progress every time the fetch operation is being run as part of auto-fetch. Having said that, I do think that it makes sense to show progress when is being executed explicitly. thoughts?
Agree.
Consider adding an option to decide whether to turn on the feature?
this progress indicator during a manual fetch would honour the setting.
Thank you, hope see the feature soon.
Change:
this.textArea.setAttribute('aria-haspopup', 'false'); this.textArea.setAttribute('aria-autocomplete', 'both'); <del> if (platform.isWeb && options.get(EditorOption.readOnly)) { </del> <ins> if (options.get(EditorOption.domReadOnly)) { </ins> this.textArea.setAttribute('readonly', 'true'); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: Steps to Reproduce: a browser version vscode a editor with readonly mode extension who use the API would be invalid This issue won't be occured on desktop version. Follow code show more details: the attribute is used to disable keyboard popping in mobile devices, but it break the event too. Change the to may be better <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Can you please give an example of how behaves differently? I am not 100% convinced that there is a bug here. I would expect that is never called, not in desktop and also not in web.
There is a way that are relatively easy to reproduce this bug, when someone use GitHub CodeSpaces (because the bug only occured in browser version): the extension and the Extension. (the extension require the API for basic cursor motion, and the GitLens extension will provide can readonly mode editor) any file which has at least two commit, click in the editor menu title. ! we will get a readonly editor, but extension can not move cursor by pressing key here. The readonly attribute was in this commit: As the message describe, it used to disable keyboard popping up on mobile devices, and there is no condition at the earliest time. and then add the condition at this commit by you , I guess that's the readonly attribute cause some bug at desktop version at that time? Another thing, I think when we need consider the mobile devices, I think change the to may be better, but there is not a option named in , so I just change it to at .
To verify, install vim in the browser and use it in a readonly editor (e.g. left side of a diff editor).
Change:
onHtmlAttributeValue: ({ tag, attribute, value, range }) => { if (shouldDoPathCompletion(tag, attribute, value)) { <del> let workspaceRoot; if (startsWith(value, '/')) { if (!workspaceFolders || workspaceFolders.length === 0) { return; } workspaceRoot = resolveWorkspaceRoot(document, workspaceFolders); </del> <ins> if (!workspaceFolders || workspaceFolders.length === 0) { return; </ins> } <ins> const workspaceRoot = resolveWorkspaceRoot(document, workspaceFolders); </ins> const suggestions = providePathSuggestions(value, range, URI.parse(document.uri).fsPath, workspaceRoot); result.items = [...suggestions, ...result.items];

Discussion:
Testing Version 1.21.0-insider Commit Date 2018-03-01T06:47:39.037Z create , in a folder in `' have and do code completion after . -should show as a proposal
Change:
const items = new Set<ExplorerItem>(this.view.getContext(respectMultiSelection)); items.forEach(item => { try { <del> if (respectMultiSelection && this.view?.isItemCollapsed(item) && item.nestedChildren) { </del> <ins> if (respectMultiSelection && !ignoreNestedChildren && this.view?.isItemCollapsed(item) && item.nestedChildren) { </ins> for (const child of item.nestedChildren) { items.add(child); }

Discussion:
https://user-
This issue may be same with When run the command on file which using file nesting, passed multiple file paths.

Type: <bBug</b https://user- VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-20T05:16:19.460Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (71)</summaryExtensionVersion ------ better-comments3.0.0 extendscript-debug2.0.3 tsl-problem-matcher0.6.2 file-nesting1.0.0 color-info0.7.0 github-markdown-preview0.3.0 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.3.0 markdown-footnotes0.0.7 markdown-mermaid1.14.2 markdown-preview-github-styles1.0.1 markdown-yaml-preamble0.1.0 file-browser0.2.10 vscode-translation2.0.6 vscode-url-title-resolver1.1.1 compare-view0.7.0 vscode-opennewinstance0.0.12 gitignore0.8.0 vscode-markdownlint0.47.0 vscode-eslint2.2.6 githistory0.6.19 tsimportsorter7.4.19 css-flexbox-cheatsheet3.3.1 css-initial-value0.2.6 gitlens-insiders2022.7.2005 vscode-html-css1.13.0 prettier-vscode9.5.0 code-runner0.11.8 shell-format7.2.2 todo-tree0.0.215 vscode-nginx-conf-hint0.3.0 path-autocomplete1.19.1 vscode-env0.1.0 markdown-kbd0.4.2 svg1.4.19 vscode-gutter-preview0.30.0 template-string-converter0.6.0 hexeditor1.9.7 js-debug-nightly2022.7.1117 live-server0.2.12 test-adapter-converter0.1.6 vscode-js-profile-flame1.0.4 vscode-typescript-next4.8.

vetur0.35.0 vscode-twoslash-queries1.0.2 vscode-versionlens1.0.10 git-file-history1.0.1 text-power-tools1.34.0 vscode-xml0.21.0 vscode-yaml1.9.1 vue-vscode-snippets3.1.1 vscode-fileutils3.5.0 code-spell-checker2.3.1 vscode-stylelint1.2.2 markdowntable0.10.0 hosts1.2.0 vscode-choosealicense0.7.0 vscodeintellicode1.2.22 vscode-icons11.13.0 snippet-generator0.3.2 modify-file-warning0.0.2 open-in-external-app0.5.0 regexp-tools0.0.1 scripting-listener0.0.3 view-github-repository1.1.0 vscode-archive0.1.2 vscode-fe-helper0.2.1 ytj-snippets0.0.5 markdown-all-in-one3.4.3 node-modules1.4.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Mine reveals but it reveals the child and not the parent so definitely a bug
if you ensure that no item in the explorer view has focus, then right click the parent, nothing will happen when you reveal in explorer/finder edit: actually that isn't consistent, in some cases nothing happens and sometimes it does what you said, I do not know the exact repro
Change:
const delegate = new class implements IListVirtualDelegate<IRuntimeExtension>{ getHeight(element: IRuntimeExtension): number { <del> return 62; </del> <ins> return 70; </ins> } getTemplateId(element: IRuntimeExtension): string { return TEMPLATE_ID;

Discussion:
"Running Extensions" tab extensions with uncaught errors 's a barely visible piece of a "report issue" button ! !
I could use some help here. Change it such that the action bar is always shown: The "Report Issue" action label is cut short to be 22x22px : <img width="268" alt="image" src="https://user-"
Looks like the default styling of the action items is icon only (codicon) and that comes with a fixed width... I will look into a fix
I got the message to show in VS Code stable, but I couldn't get it to show in insiders. Maybe I'm holding it wrong though so I will leave someone else to verify.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Nope. The button "Report Issue" is still hidden in .
Well, there was an attempt... While fixing I just patched the aforementioned lines but what kind of error does your extension throw to be reported there? Can you share your sample?
In :
Change:
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { fixedDiffEditorOptions, fixedEditorOptions, fixedEditorPadding } from 'vs/workbench/contrib/notebook/browser/diff/diffCellEditorOptions'; export function getOptimizedNestedCodeEditorWidgetOptions(): ICodeEditorWidgetOptions { return { isSimpleWidget: false,

Discussion:
Testing Notice the white horizontal lines inside the diff decorations. This looks like bad rendering In the editor diff this does not happen. ! !
Fixed via We should be using instead of .
Change:
reg.dispose(); }); <ins> test('Expand selection in words with underscores is inconsistent #90589', async function () { await assertRanges(new WordSelectionRangeProvider(), 'Hel|lo_World', new Range(1, 1, 1, 6), new Range(1, 1, 1, 12), new Range(1, 1, 1, 12), ); await assertRanges(new WordSelectionRangeProvider(), 'Hello_Wo|rld', new Range(1, 7, 1, 12), new Range(1, 1, 1, 12), new Range(1, 1, 1, 12), ); await assertRanges(new WordSelectionRangeProvider(), 'Hello|_World', new Range(1, 1, 1, 6), new Range(1, 1, 1, 12), new Range(1, 1, 1, 12), ); await assertRanges(new WordSelectionRangeProvider(), 'Hello_|World', new Range(1, 7, 1, 12), new Range(1, 1, 1, 12), new Range(1, 1, 1, 12), ); await assertRanges(new WordSelectionRangeProvider(), 'Hello|-World', new Range(1, 1, 1, 6), new Range(1, 1, 1, 12), new Range(1, 1, 1, 12), ); await assertRanges(new WordSelectionRangeProvider(), 'Hello-|World', new Range(1, 7, 1, 12), new Range(1, 1, 1, 12), new Range(1, 1, 1, 12), ); await assertRanges(new WordSelectionRangeProvider(), 'Hello|World', new Range(1, 6, 1, 11), new Range(1, 1, 1, 11), new Range(1, 1, 1, 11), ); }); </ins> });

Discussion:
Issue Type: <bBug</bany file which contains word consisting of letters with underscores (f.e. helloworld). For simplicity let's assume only one underscore is present. cursor in various places of this word and activate expand selection command (either via keyboard shortcut or keybinding) : 3a. cursor is not near underscore (underscore is not immediately to the left or right of cursor) - part of the word selected, bounded by word beginning/end and underscore - OK 3b. underscore is immediately left to the cursor - part of word to the right of cursor is selected - OK 3c. underscore is immediately right to the cursor - the whole word is selected - UNEXPECTED. For 3c I expected only part of the word selected as well, not the whole word. VS Code version: Code 1.42.0 (, 2020-02-06T10:51:34.058Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ quick-open-prefill-selection0.0.1 vscode-eslint2.0.15 gitlens10.2.1 EditorConfig0.14.4 vscode-great-icons2.1.47 intellij-idea-keybindings0.2.37 camelcasenavigation1.1.1 material-icon-theme3.9.3 partial-diff1.4.1 terminal-tabs0.2.0 (5 theme extensions excluded) </details<!-- generated by issue reporter --
Tried to fix this in the PR PS - this is my first PR for a OSS, ever... please forgive me for any mistake or misconduct.
Change:
import { StartupProfiler } from './startupProfiler'; import { StartupTimings } from './startupTimings'; import { RendererProfiling } from 'vs/workbench/contrib/performance/electron-sandbox/rendererAutoProfiler'; <ins> import { IConfigurationRegistry, Extensions as ConfigExt } from 'vs/platform/configuration/common/configurationRegistry'; import { localize } from 'vs/nls'; </ins> Registry.as<IWorkbenchContributionsRegistry>(Extensions.Workbench).registerWorkbenchContribution(

Discussion:
Since long we automatically profile the extension host when it becomes unresponsive. In that cases we send a signal via telemetry and in bad cases we ask users to file issues. During that we ask them to attach the corresponding profile but we have mixed results with that. So, in addition to the existing flow we want to log a richer telemetry event that uploads the heaviest sample trace from the profiling
Change:
} }; const comparator = new DocumentSymbolComparator(); <del> const initialState = textResourceConfigurationService.getValue<DocumentSymbolsOutlineInitialState>(_editor.getModel()?.uri, OutlineConfigKeys.collapseItems); </del> <ins> const initialState = textResourceConfigurationService.getValue<OutlineConfigCollapseItemsValues>(_editor.getModel()?.uri, OutlineConfigKeys.collapseItems); </ins> const options = { <del> collapseByDefault: target === OutlineTarget.Breadcrumbs || (target === OutlineTarget.OutlinePane && initialState === DocumentSymbolsOutlineInitialState.Collapsed), </del> <ins> collapseByDefault: target === OutlineTarget.Breadcrumbs || (target === OutlineTarget.OutlinePane && initialState === OutlineConfigCollapseItemsValues.Collapsed), </ins> expandOnlyOnTwistieClick: true, multipleSelectionSupport: false, identityProvider: new DocumentSymbolIdentityProvider(),

Discussion:
Testing Setting Open a github issue notebook You get: <img width="283" alt="image" src="https://user-"
Change:
case '$getProfiles': return this._getProfiles.apply(this, args); case '$getEnvironment': return this._getEnvironment(); case '$getWslPath': return this._getWslPath(args[0]); <del> case '$getTerminalLayoutInfo': return this._getTerminalLayoutInfo(<IGetTerminalLayoutInfoArgs>args); case '$setTerminalLayoutInfo': return this._setTerminalLayoutInfo(<ISetTerminalLayoutInfoArgs>args); </del> <ins> case '$getTerminalLayoutInfo': return this._ptyService.getTerminalLayoutInfo(<IGetTerminalLayoutInfoArgs>args); case '$setTerminalLayoutInfo': return this._ptyService.setTerminalLayoutInfo(<ISetTerminalLayoutInfoArgs>args); </ins> case '$serializeTerminalState': return this._ptyService.serializeTerminalState.apply(this._ptyService, args); case '$reviveTerminalProcesses': return this._ptyService.reviveTerminalProcesses.apply(this._ptyService, args); case '$setUnicodeVersion': return this._ptyService.setUnicodeVersion.apply(this._ptyService, args);

Discussion:
Also repro's in stable
unsure when this started happening. I don't see any open issues about it, which makes me think this is expected in WSL?
was last working in stable 1.59
and because it was broken in stable 1.60, we can narrow it down - the breaking change happened in August
looks like perhaps a race condition - get layout info is called w the correct workpsaceId, but then set layout info is called so might be wiping out the stored info before the reconnect can occur.
I open a terminal in a Remote-SSH window, reload the window, it is not reconnected
still doesn't work for WSL. based on my investigation, the pty service gets re-created when the window is reloaded, thus losing the and maps
when connected to localhost via ssh, reloading does persist the terminals but I thought this would still be using the ... !
Yep !
Also working for me in codespaces https://user-
It does work in WSL. interestingly, other state isn't persisted that should be though (see the layout change) !
this works on all remote platforms based on my testing. i saw a few times reloading WSL didn't work, but now cannot reproduce
Oh cool, I thought the situation was much worse. I'll reopen to verify on my side since we definitely want to make sure this is working everywhere
All seems to work
verified
Change:
.quick-input-list .monaco-tree-sticky-row .quick-input-list-entry.quick-input-list-separator-as-item.quick-input-list-separator-border { border-top-style: none; } <del> /* TODO: This seems to be the best way to do this... is there a better way? */ .quick-input-list .monaco-tl-twistie { display: none !important; } </del>

Discussion:
! I can click on them
Took a different approach with this... instead they are clickable, but they cause the list to scroll that separator up to the top (and they also clear focus).
Fixed in
Change:
metaKey: false }; <del> this._subscriptions.add(domEvent(document.body, 'keydown', true)(e => { </del> <ins> this._subscriptions.add(domEvent(window, 'keydown', true)(e => { </ins> const event = new StandardKeyboardEvent(e); // If Alt-key keydown event is repeated, ignore it #112347

Discussion:
Issue Type: <bBug</bRelease Notes alt to open the file menu menu dosn't opens. menu opens, focus moves VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-07T11:32:09.993Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ github-markdown-preview0.0.2 markdown-checkbox0.1.3 markdown-emoji0.0.9 markdown-preview-github-styles0.1.6 markdown-yaml-preamble0.0.4 vscode-astyle0.9.0 vscode-markdownlint0.36.2 githistory0.6.9 EditorConfig0.15.1 vscode-pull-request-github0.18.1 vscode-language-pack-ru1.48.2 python2020.7. remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.4 cmake-tools1.4.1 cpptools0.29.0 vsliveshare1.0.2478 vsliveshare-audio0.1.85 vsliveshare-pack0.4.0 code-spell-checker1.9.0 code-spell-checker-russian0.2.4 </details<!-- generated by issue reporter --
I can reproduce this - just open any markdown preview and will not open the file menu. I think we should fix this for this release, as it is a breaking change (in last stable I can nicely press to open the file menu). Due to that I am assigning this to July and can move it out if he would prefer to fix it next milestone Also fyi for custom menus
Has the way the menus handle mnemonics changed this iteration? The webview still seem to be dispatching the events but they aren't being handled by anyone
nope no changes that i know of
should be handled here
is working for me and in insiders on windows.

For just pressing to show the mnemonics, this does not seem like a regression from 1.47 in my testing but it was working in 1.46
I was just testing this out, I see no new behavioral differences between now and 1.46 does not focus the custom menubar with release notes focused. We do not get the alt event +<mnemonicdoes open the resepective menu with release notes focused.
hay can we fix that? because it's really strange in my opinion.
Changing the listeners from using to fixes the initial trigger, but keys like don't clear the focus. Moving out to look into a better fix
is there something webviews need to do to have keys passed back to VS Code? This came up at and I can repro in both stable and insiders. The webview hosts an iframe if that matters. I'm unable to interact with VS Code (eg. to open command palette) when focus is in the web view. I tried loading a non-Flutter page in there to check it wasn't specific to Flutter, but it's happening with other pages too.
If you can avoid it, don't use an iframe. If you absolutely must use an iframe, then you need to dispatch the keypresses back to webviews. See
I don't think there's any way to avoid the iframe really. The linked solution didn't work due to CORS issues, but the comments further down using postMessage to bounce the events over does. I'll see whether we can get something like that in the embedded app. Thanks!
Change:
let errorcode: ExtensionManagementErrorCode | undefined; let errorcodeDetail: string | undefined; <ins> if (isDefined(verificationStatus)) { if (verificationStatus === true) { verificationStatus = 'Verified'; } else if (verificationStatus === false) { verificationStatus = 'Unverified'; } else { errorcode = ExtensionManagementErrorCode.Signature; errorcodeDetail = verificationStatus; verificationStatus = 'Unverified'; } } </ins> if (error) { if (error instanceof ExtensionManagementError) { errorcode = error.code;

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log