jiebi/CodeConvo huggingface dataset:
Change:
function getRecordFromL10nJsonFormat(l10nJsonFormat: l10nJsonFormat): Record<string, string> { const record: Record<string, string> = {}; <del> for (const key of Object.keys(l10nJsonFormat)) { </del> <ins> for (const key of Object.keys(l10nJsonFormat).sort()) { </ins> const value = l10nJsonFormat[key]; record[key] = typeof value === 'string' ? value : value.message; }

Discussion:
I've reviewed/approved a couple update-localization PRs (e.g. ) and observed that there's always a few changes just due to reordered properties. E.g. in Would be great if we can avoid these, to keep the number of changes small and simplify the reviewing.
Fixed in ^^^ keep in mind that this change won't be used until around the 17th of Nov.
Change:
'!extensions/typescript-language-features/test-workspace/**', '!extensions/typescript-language-features/resources/walkthroughs/**', '!extensions/markdown-math/notebook-out/**', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/vscode-api-tests/testWorkspace/**', '!extensions/vscode-api-tests/testWorkspace2/**', '!build/monaco/**',

Discussion:
Running on main:
Am I missing something on how to run this? An ignore rule is in :
Change:
super(icon, label, values, quickInputService, environmentService, remoteExplorerService, workspaceContextService); } <ins> protected override async getActions(): Promise<{ label: string; description: string; extensionDescription: Readonly<IRelaxedExtensionDescription>; }[]> { return Promise.all(this.values.map(async (value) => { return { label: value.extensionDescription.displayName || value.extensionDescription.identifier.value, description: '', extensionDescription: value.extensionDescription }; })); } </ins> protected async takeAction(extensionDescription: IExtensionDescription): Promise<void> { await this.commandService.executeCommand('workbench.action.openIssueReporter', [extensionDescription.identifier.value]); }

Discussion:
I ran across this while trying to create report issue markdown links for notebooks. Clicking the report issue item in the help section of the remote explorer does nothing and I believe its because of improper arguments format for the report issue command here: The correct argument is an object with an extensionId property.
this works fine for me on desktop. Were you on web? It looks like that command is implemented differently for web. This seems unexpected. do you own and
Looks like might own this. These are the parts that I would expect to be the same:
It was me all along I will change Web to be more like Desktop.
I just debugged this and my issue reporter command is never fired. I think is an issue somewhere in this: The repro steps: don't have a remote workspace open or any workspace open for that matter open the remote explorer -help and feedback -Report Issue nothing happens.
To verify: Install at least 2 remote extension Reload, and make sure you don't have a remote or virtual workspace open Click "Report Issue" from the Remote "Help & Feedback" Verify that you get a quick pick.
Sorry for the false alarm there !
where is this?
! In the Remote Explorer at the bottom.
Change:
} else { this.modelService.setMode(textModel, this.languageService.createById(candidateLanguage.id)); } <ins> const opts = this.modelService.getCreationOptions(textModel.getLanguageId(), textModel.uri, textModel.isForSimpleWidget); textModel.detectIndentation(opts.insertSpaces, opts.tabSize); </ins> } } }

Discussion:
Issue Type: <bBug</bEditor: Insert Spaces and Editor: Detect Indentation on a new file, the indent mode is "Spaces: 4" some codes with tab as indentation language is automatically detected, but the indent mode is still "Spaces: 4" VS Code version: Code 1.67.2 (, 2022-05-17T18:15:52.058Z) OS version: Windows_NT x64 6.1.7601 Restricted Mode: No <details<summaryExtensions (3)</summaryExtensionVersion ------ vscode-css-formatter1.0.2 copilot1.25.6056 format-html-in-php1.7.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I'm having trouble reproducing: https://user-
I mean, the indent mode should be detected automatically on pasting to a blank file, at the same time as detecting language
The feature request here is that would also invoke (given the setting is set to true).
, opening up for help wanted if someone wants to contribute a PR for this.
Change:
}); } <ins> // If we only have one history item that contains all the // labels (current, remote, base), we don't need to show it if (historyItemsElement.length === 1) { const currentHistoryItemGroupLabels = [ currentHistoryItemGroup.name, ...currentHistoryItemGroup.remote ? [currentHistoryItemGroup.remote.name] : [], ...currentHistoryItemGroup.base ? [currentHistoryItemGroup.base.name] : [], ]; const labels = (historyItemsElement[0].labels ?? []) .map(l => l.title); if (equals(currentHistoryItemGroupLabels.sort(), labels.sort())) { return []; } } </ins> // Create the color map const colorMap = new Map<string, ColorIdentifier>([ [currentHistoryItemGroup.name, historyItemGroupLocal]

Discussion:
Testing Confirm that there is a ticked item for the remote branch (ex: origin/main) See repro below: !
Change:
"sql": "_db_light", "swift": "_swift_light", "typescript": "_typescript_light", <del> "typescriptreact": "_react_light", </del> <ins> "typescriptreact": "_typescript_light", </ins> "xml": "_xml_light", "yaml": "_yml_light", "argdown": "_argdown_light",

Discussion:
accepted a couple of update PRs recently. Can you please sync extensions/theme-seti/icons? Meanwhile, I noticed that file was falsely classified as type file. I am not sure if that's a real issue in the latest vscode release candidate, or just a non-reproducible problem caused by some peculiarity in my vscode dev env. Can you please take a look?
Also something worth mentioning is that WebP images lack the image icon whereas WebM videos does indeed have the video icon. Adding lines: and does indeed solves the issue.
can you please file a separate issue? Thanks.
NP sir .
thanks! While testing your PR, can you also please check the icon for file? There shouldn't be no icon assigned to it. Otherwise, that's a regression and I am happy to file an issue.
we don't have any references to files in our seti-ui directory and nearly all of our code is pulled directly from the seti repo, so i'm unsure where this is coming from. Please file a separate issue and can look into it. EDIT: after looking into this, it appears that files are : ! And we have refs for mod files in our built-in xml extension: So there is a clash there. I'd suggest you make a request on the seti-ui theme to set files to a go icon so there are no conflicts.
Verification steps: ensure that the following updates are reflected in the file explorer for file icons: use the new logo files point to the R icon files point to the TypeScript icon !
Change:
"diffEditor.removedLineBackground": "#da363333", "diffEditor.removedTextBackground": "#da36334d", "dropdown.background": "#313131", <del> "dropdown.border": "#ffffff17", </del> <ins> "dropdown.border": "#ffffff1f", </ins> "dropdown.foreground": "#cccccc", "dropdown.listBackground": "#313131", "editor.background": "#1f1f1f",

Discussion:
Ref Unchecked and unfocused checkboxes in the Settings editor currently do not have much contrast between the checkbox background colour and the checkbox border colour for both Light+ v2 and Dark+ v2 themes. !
Change:
} }); <del> if (modifiedBaseRange.isConflicting || !model.isHandled(modifiedBaseRange).read(reader)) { </del> <ins> if (!useSimplifiedDecorations && (modifiedBaseRange.isConflicting || !model.isHandled(modifiedBaseRange).read(reader))) { </ins> const inputDiffs = modifiedBaseRange.getInputDiffs(this.inputNumber); for (const diff of inputDiffs) { const range = diff.outputRange.toInclusiveRange();

Discussion:
Note all three lines highlighted with background color <img width="262" alt="CleanShot 2022-09-08 at 16 01 57 src="https://user-"We only highlight the changed line and specific word. <img width="184" alt="CleanShot 2022-09-08 at 16 02 04 src="https://user-"If we followed the inline style and still rendered a word diff, wouldn't we be able to get away without using the borders to indicate the region? cc
The inline style does this because it has no clue about the actual conflict, it just sees the conflict markers. We do this to show the actual change in that side.
I a hidden setting (default false) so we can play with idea. Personally, I think it hides many important decorations, but I'm open to exploring it. Enabled: ! Disabled: ! The background color disappears when the conflict is handled.
Change:
// preferred scheme handling private installPreferredSchemeListener() { <del> this._register(this.hostColorService.onDidChangeColorScheme(() => this.restoreColorTheme())); </del> <ins> this._register(this.hostColorService.onDidChangeColorScheme(() => { if (this.settings.isDetectingColorScheme()) { this.restoreColorTheme(); } })); </ins> } public hasUpdatedDefaultThemes(): boolean {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.0-insider () OS Version: macOS Sonoma 14.5 Steps to Reproduce: the setting to . "Preferences: Color Theme" in the command palette. a dark theme is enabled, previews for light themes aren't working and vice versa. The preview for the selected theme is shown for a fraction of a second and immediately changed back to the enabled theme (see the video below).
Change:
* Scheme used for output panel resources */ export const outputChannel = 'output'; <ins> /** * Scheme used for the accessible view */ export const accessibleView = 'accessible-view'; </ins> } export function matchesScheme(target: URI | string, scheme: string): boolean {

Discussion:
Testing Repro: "getting started with accessiblity features" second step click on blue button to "open accessible view" results in an error in dev console says that "the editor is not accessible at this time" and advises to turn on screen optimized view, but I already have that on as you can see in status bar item. Version: 1.94.0-insider Commit: Date: 2024-09-24T05:04:12.797Z Electron: 30.5.1 ElectronBuildId: Chromium: 124.0.6367.243 20.16.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0
As part of this flow - I was also confused why a new file is opened after I close the Accessible View: !
I'm getting "the editor is not accessible at this time" messages while moving focus to the Python REPL input box or the Copilot Chat input box !
seems like an issue with the walkthrough accessible view?
this looks an issue with the accessible view editor. I'm seeing a similar issue when I open the chat-panel and request the accessible view.
Change:
const snippetSchemaProperties: IJSONSchemaMap = { prefix: { <del> description: nls.localize('snippetSchema.json.prefix', 'The prefix to used when selecting the snippet in intellisense'), </del> <ins> description: nls.localize('snippetSchema.json.prefix', 'The prefix to use when selecting the snippet in intellisense'), </ins> type: ['string', 'array'] }, body: {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version: 1.46.0-insider (system setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: : Configure User Snippets .json example code block 'Print to console' over "prefix" element for tooltip "The prefix to used..." should say "The prefix to use..." <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Change:
private styleList() { const background = this.styles.selectBackground ?? ''; <del> const listBackground = this.styles.selectListBackground ? this.styles.selectListBackground : background; </del> <ins> const listBackground = dom.asCssValueWithDefault(this.styles.selectListBackground, background); </ins> this.selectDropDownListContainer.style.backgroundColor = listBackground; this.selectionDetailsPane.style.backgroundColor = listBackground; const optionsBorder = this.styles.focusBorder ? this.styles.focusBorder : '';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 Insiders OS Version: Win 10 Steps to Reproduce: Initially discovered in The VSCode Settings show select dropdowns having seemingly transparent background, so the options' texts are mixing with the document flow beneath the dropdown. It is probably a CSS regression in 1.75.0 Insiders because 1.74.3 doesn't exhibit this problem !
See already
Change:
import { AccessibilityVerbositySettingId, AccessibleViewProviderId } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { getNotebookEditorFromEditorPane } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; <ins> import { IVisibleEditorPane } from 'vs/workbench/common/editor'; </ins> export function getAccessibilityHelpText(accessor: ServicesAccessor): string { const keybindingService = accessor.get(IKeybindingService);

Discussion:
a markdown cell in preview mode like Accessibility Help :bug: accessibility help does not appear If I focus a code cell I get the help view
IMO, this should not be working at all for github issue notebooks
Why is that? The notebooks UI and keybindings/commands are generic (though can be overridden by extensions)
Change:
let lastModLineNumber = c.modified.startLineNumber; let lastOrigLineNumber = c.original.startLineNumber; <del> function emitAlignment(origLineNumberExclusive: number, modLineNumberExclusive: number) { </del> <ins> function emitAlignment(origLineNumberExclusive: number, modLineNumberExclusive: number, forceAlignment = false) { </ins> if (origLineNumberExclusive < lastOrigLineNumber || modLineNumberExclusive < lastModLineNumber) { return; } if (first) { first = false; <del> } else if (origLineNumberExclusive === lastOrigLineNumber || modLineNumberExclusive === lastModLineNumber) { </del> <ins> } else if (!forceAlignment && (origLineNumberExclusive === lastOrigLineNumber || modLineNumberExclusive === lastModLineNumber)) { // This causes a re-alignment of an already aligned line. // However, we don't care for the final alignment. </ins> return; } const originalRange = new LineRange(lastOrigLineNumber, origLineNumberExclusive);

Discussion:
. To verify the bugfix, check that in the newest version of the monaco editor the alignment is as expected. edit from <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.89.1 (user setup) Commit: Date: 2024-05-07T05:13:33.891Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. Searched existing issues by "compare vertical alignment" - no relevant results. Steps to Reproduce: files test2 and test1 them Fact wrong vertical alignment of identical rows after delete-add section ! Expected !
Thanks for sharing the input documents and the screenshot! Unfortunately, it is still not clear what this issue is about - I don't see a big difference in the screenshots. Can you add more details?
difference (expected empty range) is shown on this picture !
Ahh, I see. Can you check the dev console?
No. I want fix in my test. Not in dev console. Can you reproduce my simple test in user interface?
No, I cannot reproduce. But I think VS Code might have logged some errors to the VS Code dev console. You could help me fixing this bug, but sharing if there are any error messages in the VS Code dev console.
Show your comparison result. Here is log from dev console: An iframe which has both allow-scripts and allow-same-origin for its sandbox attribute can escape its sandboxing. !
Change:
// Ask the user to pick a preferred account const session = await this.getAccountPreference(); if (session !== undefined) { <del> this.#authenticationInfo = { sessionId: session.id, token: session.accessToken, providerId: session.providerId }; </del> <ins> this.#authenticationInfo = { sessionId: session.id, token: session.idToken ?? session.accessToken, providerId: session.providerId }; </ins> this.storeClient.setAuthToken(this.#authenticationInfo.token, this.#authenticationInfo.providerId); this.existingSessionId = session.id; this.logService.trace(`Saving authentication session preference for ID ${session.id}.`);

Discussion:
Reported by Possibly related to already being signed into settings sync with GitHub auth
Lmk if you need anything from me
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Seems to be because I need to use the idToken instead of the accessToken?
Yep. Settings Sync uses the and not the . Sorry I should have told you that
how can I verify this / what was the repro?
steps are just "use Microsoft account with edit sessions" and it works. Verified!
Change:
})); } <del> private notifyNoSaveNeeded() { if (!this.storageService.getBoolean(SETTINGS_AUTOSAVE_NOTIFIED_KEY, StorageScope.GLOBAL, false)) { this.storageService.store(SETTINGS_AUTOSAVE_NOTIFIED_KEY, true, StorageScope.GLOBAL, StorageTarget.USER); this.notificationService.info(localize('settingsNoSaveNeeded', "Changes to settings are saved automatically.")); } } </del> private onDidChangeSetting(key: string, value: any, type: SettingValueType | SettingValueType[]): void { <del> this.notifyNoSaveNeeded(); </del> if (this.pendingSettingUpdate && this.pendingSettingUpdate.key !== key) { this.updateChangedSetting(key, value); }

Discussion:
I am sure by now everyone got this: !
I used to get issues about people not sure whether settings were saved, now I don't. You should only see it once in a new user data dir. I think it's useful, I'd prefer to keep it.
I think given our latest move to reduce notifications we should revisit this. //cc
Agree. would you be open to remove this notification now? This only happens in JSON settings? This one is advanced and maybe those users do not need help?
This happens with our standard settings editor: !
Oh I misunderstood, then I would definitely remove this notification. Most UI now days do not have an Apply button and none of the notify that you do not have to click apply for the setting to be applied. did we run some user studies where participants would get confused if their settings get saved? Could we maybe remove this notification and run a short study to gather some impressions. Reopening this issue for discussion
As I remember, this came directly from user studies. But that was 3 years ago and maybe we can just assume that people are used to it now? You will also only get it once.
I don't remember the details from the user study but I think it would be fine to remove this and then also follow up with a short study.
cool. do you mind if we remove this in May debt week, so we have the whole May milestone to gather feedback and maybe do a short study?
Since I noticed this again now in endgame week with fresh installs, decided to put up a PR with the notification removed in
Awesome, thanks for doing that
verified
Change:
const actions = breakpointEditorContribution.getContextMenuActionsAtPosition(lineNumber, model); for (const action of actions) { <del> result.push(action); </del> <ins> result.push(action, '2_debug'); </ins> } });

Discussion:
configure "testing.defaultGutterClickAction": "contextMenu", open a test file and click on a test icon a context menu opens but the test commands aren't atop <img width="356" alt="Screenshot 2023-03-31 at 15 41 37" src="https://user-"
Change:
} if (this._session.isAtLastPlaceholder || !this._session.isSelectionWithinPlaceholders()) { <ins> this._editor.getModel().pushStackElement(); </ins> return this.cancel(); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Curently there's no undo/redo stop at end of snippet (when the snippet reaches its last placeholder). In my opinion, having an undo/redo stop at end of snippet is better. See the following comparison. Current: ! Expected: !
This is already handled on a per-case basis: Please add the exact steps in which you expect undo stop, no GIF please
if I understand correctly, the line that you linked inserts a stop just after inserting a snippet. I am talking about adding a stop when the snippet reaches its end / last placeholder. More precisely speaking, here:
Understood. Thanks for helping me. Sounds reasonable tho needs a little thinking if this affects some use-case.
Change:
) { super(); this._findInput = this._register(new FindInput(null, this._contextViewService, { <del> width: 155, </del> label: NLS_FIND_INPUT_LABEL, placeholder: NLS_FIND_INPUT_", }));

Discussion:
Testing Steps to Reproduce: integrated terminal and open the find widget the integrated terminal area very skinny bug The find widget starts overflowing into the explorer area: <img width="420" alt="screen shot 2017-06-28 at 1 25 51 pm" src="https://user-"
After , no more overflow but we now clip the find box: !
I guess we want it to be tiny like in the editor: <img width="221" alt="screen shot 2017-07-07 at 3 02 45 pm" src="https://user-"