jiebi/CodeConvo huggingface dataset:
Change:
await repository.checkout(treeish); return true; } <del> const config = workspace.getConfiguration('git'); const checkoutType = config.get<string>('checkoutType') || 'all'; const includeTags = checkoutType === 'all' || checkoutType === 'tags'; const includeRemotes = checkoutType === 'all' || checkoutType === 'remote'; </del> const createBranch = new CreateBranchItem(this); <del> const heads = repository.refs.filter(ref => ref.type === RefType.Head) .map(ref => new CheckoutItem(ref)); const tags = (includeTags ? repository.refs.filter(ref => ref.type === RefType.Tag) : []) .map(ref => new CheckoutTagItem(ref)); const remoteHeads = (includeRemotes ? repository.refs.filter(ref => ref.type === RefType.RemoteHead) : []) .map(ref => new CheckoutRemoteHeadItem(ref)); const picks = [createBranch, ...heads, ...tags, ...remoteHeads]; </del> <ins> const picks = [createBranch, ...repositoryRefsToItems(repository)]; </ins> const placeHolder = localize('select a ref to checkout', 'Select a ref to checkout'); const choice = await window.showQuickPick(picks, { placeHolder });

Discussion:
Similar to the visual-studio feature: Right now the way to do this would be to checkout the remote branch and then create a branch from there !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.678 --- <!-- score: 0.631 --- <!-- score: 0.585 --- <!-- score: 0.58 --- <!-- score: 0.53 --<!-- potentialduplicatescomment --
The command will show you a list of branches. If you pick a remote branch, it will create a local branch and set it to track the remote one. Isn't that enough?
this would require me to first checkout the remote branch
Please try <kbdF1</kbd, , pick a remote branch and let me know if that doesn't create a local branch.
it does create a local branch. I think I didn't explain the feature request correctly for example: When working on a new feature you create a branch from the remote master into your own local branch you have no need to actually create a local version of the branch. I never create a local branch tracking the remote branch
So, you want to create a branch based off a specific remote branch?
Exactly
I don't see a "Create Branch From" command, what happened to it?
The standard command now asks you where the branch should be created.
hey is there a way to set this branch to be the current branch by default?
What does that mean? When running the command, that branch will be checked out.
Sorry for not being very clear! Right now when I run this command I'm prompted to choose which branch to branch off every time. I quite liked it when the command would use the current branch as the branch to branch off of, without me having to specify it. I can see how the new behaviour is useful, but is there a way to set the old behaviour as the default behaviour, so that I don't have to confirm that I want to branch off the current branch when making a new branch?
The current experience auto selects ... so all you have to do is press <kbdEnter</kbdwhen asked which ref the branch should be created from. That is the equivalent of the old behaviour.
Change:
} private onEditorChangeCursorPosition(e: Position | null) { <del> const decorations = e ? this.editor?.getDecorationsInRange(Range.fromPositions(e, { column: -1, lineNumber: e.lineNumber })) : undefined; </del> <ins> if (!e) { return; } const range = Range.fromPositions(e, { column: -1, lineNumber: e.lineNumber }); const decorations = this.editor?.getDecorationsInRange(range); </ins> let hasCommentingRange = false; if (decorations) { for (const decoration of decorations) {

Discussion:
Type: <bFeature Request</bCC any file containing comment thread editor, move your cursor to any line having comment your cursor is on the line, press ctrl+K ctrl+I to see if the comment tolltip opens Screen reader users cannot open comment tooltip on the current line via ctrl+K ctrl+I ctrl+K ctrl+I needs to work for the comment tooltip just like other tooltips. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
the comment widget is not a tooltip. We cannot reuse this keybinding to focus the comment widget because it's possible that line will have hover info. pls lmk if you disagree. I do wonder if we should have a focus closest comment widget command/keybinding.
Aw, I see. Please then consider adding a keybinding to focus the closest comment widget. Currently, alt+F9 and shift+alt+F9 go to the next and previous comment widget, but there is no action available to focus the comment on the current line.
It does make sense to have an "Expand and focus comment at current line" command.
The new command is "Focus Comment on Current Line" with no default keybinding.
To verify: Install an extension that provides comments GitHub Pull Requests can be used for this Sign in Open the Pull Requests view Open a file diff for a PR. If there aren't any comments in the file, add a comment on one of the changed lines and collapse the comment Put your cursor on a line in a file with a collapsed comment Open the command palette and run the command "Focus Comment on Current Line" Verify that the comment has focus
This should probably be to the comments and/or the editor accessibility help dialog for discoverability.
Change:
} .xterm-dim { <del> opacity: 0.5; </del> <ins> /* Dim should not apply to background, so the opacity of the foreground color is applied * explicitly in the generated class and reset to 1 here */ opacity: 1 !important; </ins> } .xterm-underline-1 {

Discussion:
WT completed feature request: issue:
PR
To verify, for each value of , run the following: Verify the "overlined" text has an overline and " normal" does not.
With gpuAcceleration "off", I don't see an overline <img width="437" alt="image" src=""
Good find, I didn't update
After adding the styles, depending on the font it can still be cut off unfortunately due to the cell size in the dom renderer being strict. Captured that issue in
When verifying again, if you don't see an overline, inspect the DOM and verify shows on the children of
Not working still.
the remaining problem is tracked in
Not working on Latest Insiders.
Change:
if (!this.storageService.getBoolean(donotAskUpdateKey) && e.local && e.operation === InstallOperation.Install && e.local.manifest.contributes && e.local.manifest.contributes.localizations && e.local.manifest.contributes.localizations.length) { const locale = e.local.manifest.contributes.localizations[0].languageId; if (platform.language !== locale) { <ins> const updateAndRestart = platform.locale !== locale; </ins> this.notificationService.prompt( Severity.Info, <del> localize('updateLocale', "Would you like to change VS Code's UI language to {0} and restart?", e.local.manifest.contributes.localizations[0].languageName || e.local.manifest.contributes.localizations[0].languageId), </del> <ins> updateAndRestart ? localize('updateLocale', "Would you like to change VS Code's UI language to {0} and restart?", e.local.manifest.contributes.localizations[0].languageName || e.local.manifest.contributes.localizations[0].languageId) : localize('activateLanguagePack', "Would you like to restart VS Code to activate the language pack that was just installed?"), </ins> [{ label: localize('yes', "Yes"), run: () => { const file = URI.file(join(this.environmentService.appSettingsHome, 'locale.json')); <del> this.jsonEditingService.write(file, { key: 'locale', value: locale }, true) .then(() => this.windowsService.relaunch({}), e => this.notificationService.error(e)); </del> <ins> const updatePromise = updateAndRestart ? this.jsonEditingService.write(file, { key: 'locale', value: locale }, true) : TPromise.as(null); updatePromise.then(() => this.windowsService.relaunch({}), e => this.notificationService.error(e)); </ins> } }, { label: localize('no', "No"),

Discussion:
The prompt as part of , looks like the below: ! If the user's locale was Hungarian to begin with, then all they need to do is restart VS Code to activate the language pack. Setting the file is not necessary. I propose as a fix cc
Change:
} else { taskResult = encounteredTasks.get(commonKey); if (!taskResult) { <del> const key = dependencyTask.getMapKey(); taskResult = this._activeTasks[key] ? this._getDependencyPromise(this._activeTasks[key]) : undefined; </del> <ins> const activeTask = this._activeTasks[dependencyTask.getMapKey()] ?? this._getInstances(dependencyTask).pop(); taskResult = activeTask && this._getDependencyPromise(activeTask); </ins> } } if (!taskResult) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 and older and (with slightly different behavior) insiders as of 5/4/2023 OS Version: MacOS 13.3.1 (a) Steps to Reproduce: Use these commands to produce and launch a suitable project: First bug: in either 1.78.0 or the nightly, use to launch , then hit Cmd-Shift-B to launch . You end up with two copies of running, when it should have an implicit of 1. Hit Cmd-Shift-B again, and it will tell you you've hit the instance limit. The problem here is that dependent tasks don't count towards the instance limit. Second bug: Now add to , and repeat the above. There is no change in the nightly (as you might expect), but surprisingly 1.78.0 now reports that it can't start a second copy. But thats just a bug; if you change it to and repeat, 1.78.0, still tells you it can't launch a second copy. This bug was fixed by , so I'm just including it for completeness. Third bug: Add to . Now hit Cmd-Shift-B to launch , then use to launch . will (correctly) re-use the already running task, rather than launching a new one. Now kill all the terminals (to make the next step less confusing). Hit Cmd-Shift-B to launch sleeper, wait 5 seconds, and hit Cmd-Shift-B again, wait another 5 seconds for the first task to finish, and then run .

Now, although the second task is still running, starts a new one. The issue here is that when looking for an existing dependent task, uses the task's , which only matches the first instance of a task with greater than 1 (and here, that task has already finished).
Change:
inputSideToolbar?: MenuId; telemetrySource?: string; }; <ins> defaultElementHeight?: number; </ins> editorOverflowWidgetsDomNode?: HTMLElement; }

Discussion:
See how the padding is ~double that on top than on the side ! It looks particularly bad imo when a response is in progress: ! It's also ~half on bottom: ! Could we make the padding consistent on all sides?
Padding also looks pretty bad in terminal: !
When showing a result the chat widget height is off by 3px, e.g its reported content height is small then the height takes... <img width="1411" alt="Screenshot 2024-03-22 at 16 22 35" src=""
Should be looking better now <img width="1277" alt="Screenshot 2024-03-26 at 20 58 39" src=""
Much better Does it look wrong with this part gone too? !
Yeah, I had played with that and wasn't happy. The different radii (from the input and zone) get close enough to make it look weird. Also, the focus border makes it appear as too narrow
Change:
const bufferToDecrypt = Buffer.from(parsedValue.data); this.logService.trace('[EncryptionMainService] Decrypting value.'); <del> return safeStorage.decryptString(bufferToDecrypt); </del> <ins> try { const result = safeStorage.decryptString(bufferToDecrypt); this.logService.trace('[EncryptionMainService] Decrypted value.'); return result; } catch (e) { this.logService.error(e); throw e; } </ins> } isEncryptionAvailable(): Promise<boolean> {

Discussion:
Hi thank you for your reply. After start VSCode Insider with the parameters , when I try to authorize the Github Copilot the message returned at terminal is: ExtensionUrlTrustService#isExtensionUrlTrusted There are no configured trusted keys and the authentication process never ends. Originally posted by in
Can you follow these steps so that we can get more information on what's going on? Open the Command Palette Run the command To the right of , click the double check mark button. (enables trace logging as the default) Start the login, wait for the issue to happen... Open the Output pane (cmd+shift+u) drop in this issue he contents of the following: Output channel Output channel Output channel Open the Command Palette Run the command To the right of , click the double check mark button. (to set the default back to info)
same here
can you follow the steps?
You know what, this is likely fixed in this ^^ PR. Let's see what tomorrow's Insider build has
Cool! Thanks! Waiting for the next version.
I will try with the updated version and return here.
Confirm the latest version released today fixed everything!
Problem solved!!! Thank you guys.
Change:
this.tree?.collapseAll(); } <ins> getDebugSession(): IDebugSession | undefined { return this.tree?.getInput(); } </ins> getReplInput(): CodeEditorWidget { return this.replInput; }

Discussion:
Testing a js file at the root that something. a launch config to run it using node like: it and see the logs persist in the debug console.] to use alt+f2 to read it 'no debug session is active' !
is there a way to get the from an inactive session?
Reviewing the code some more I think the more reliable way to get the displayed session is to use . Currently it uses viewModel.focusedSession which won't include ended sessions as Andrea found
I think that will be a little involved, so deferring
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
import 'vs/editor/contrib/inPlaceReplace/common/inPlaceReplace'; import 'vs/editor/contrib/iPadShowKeyboard/browser/iPadShowKeyboard'; import 'vs/editor/contrib/linesOperations/common/linesOperations'; <ins> import 'vs/editor/contrib/carretOperations/common/carretOperations'; </ins> import 'vs/editor/contrib/links/browser/links'; import 'vs/editor/contrib/multicursor/common/multicursor'; import 'vs/editor/contrib/outlineMarker/browser/outlineMarker';

Discussion:
Atom 1.8 will introduce two new commands to move text selections left and right. A description of the feature is available in It would be great to have these commands on VSCode. !
Thanks for bringing this feature to our attention fyi
That looks so cool
Could we use the <kbdAlt</kbd+<kbd←</kbd(respectively <kbdAlt</kbd+<kbd→</kbd) as the keyboard shortcut? That would match perfectly the actions to move lines up or down.
I think <kbdcontrol</kbd+ <kbdcmd</kbd+ <kbd←/→</kbdis better(Atom 1.8). <kbdAlt</kbd+ <kbd←/→</kbdis to move the cursor around the word.
Change:
registerThemingParticipant((theme, collector) => { <del> const editorHoverHighlightColor = theme.getColor(editorHoverHighlight); </del> <ins> let editorHoverHighlightColor = theme.getColor(editorHoverHighlight); </ins> if (editorHoverHighlightColor) { <ins> if (editorHoverHighlightColor.isOpaque()) { editorHoverHighlightColor = editorHoverHighlightColor.transparent(0.5); } </ins> collector.addRule(`.integrated-terminal .hoverHighlight { background-color: ${editorHoverHighlightColor}; }`); } const hoverBackground = theme.getColor(editorHoverBackground);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.46.0-Insider OS Version: Ubuntu 20.04 Steps to Reproduce: any folder or workspace terminal to any nested directories. over the path in the terminal. path becomes black. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No ! !
I'm guessing you have a non-transparent color set as in your theme.
How can I override it ?
This setting:
Thank you
Following the instructions you provided I still cannot reproduce this.
The proper fix for this to draw the highlight under the text probably needs to happen. We could do a workaround to make the color partially transparent if it's detected as opaque.
Cool, thanks for the update Just went ahead and merged workaround in dracula theme for the time being. I was finally able to repro on my end :+1:
Can I work on this?
I'll have to do a quick fix on this to squeeze it in for this release.
I have made a quick fix myself. I can push it now and you can take a look.
if it's ready now, sure!
Change:
"semver-umd": "^5.5.7", "vscode-oniguruma": "1.3.1", "vscode-textmate": "5.2.0", <del> "xterm": "4.9.0-beta.8", </del> <ins> "xterm": "4.9.0-beta.24", </ins> "xterm-addon-search": "0.7.0", "xterm-addon-unicode11": "0.2.0", "xterm-addon-webgl": "0.8.0"

Discussion:
Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:
Change:
findState: FindReplaceState, @IContextViewService _contextViewService: IContextViewService, @IContextKeyService private readonly _contextKeyService: IContextKeyService, <del> @ITerminalService private readonly _terminalService: ITerminalService </del> <ins> @ITerminalService private readonly _terminalService: ITerminalService, @ITerminalGroupService private readonly _terminalGroupService: ITerminalGroupService </ins> ) { super(_contextViewService, _contextKeyService, findState, true); this._register(findState.onFindReplaceStateChange(() => {

Discussion:
Testing <img width="1445" alt="image" src="https://user-"
The widget is open in your screenshot
!
Wrong screenshot again. Here you go <img width="1419" alt="image" src="https://user-"
Thanks, but I cannot repro this - could you pls attach a gif?
Have a split terminal Focus in second terminal and open find widget and search for some text to show highlights Focus in first terminal and press escape
Change:
hide(): void { this.widget.setVisible(false); <ins> // Maintain scroll position for a short time so that if the user re-shows the chat // the same scroll position will be used. this.maintainScrollTimer.value = disposableTimeout(() => { // At this point, clear this mutable disposable which will be our signal that // the timer has expired and we should stop maintaining scroll position this.maintainScrollTimer.clear(); }, 30 * 1000); // 30 seconds </ins> } show(): void { this.widget.setVisible(true); <ins> // If the mutable disposable is set, then we are keeping the existing scroll position // so we should not update the layout. if (!this.maintainScrollTimer.value) { this.widget.layoutDynamicChatTreeItemMode(); } </ins> } render(parent: HTMLElement): void {

Discussion:
Testing I think that growing quick chat when you scroll is an interesting idea, but I would reset the size back to how it was when you reopen quick chat because its harder to manage the size to make it small again. You cannot just scroll to get back where you were.
Ahhh I struggle with this one because it might be that you wanna: scroll back to a former question switch to your editor switch back to that former question which you get with the current behavior. You can get back to the original size if you double click the sash... but that's maybe not obvious.
cc would love your thoughts.
Actually had forgotten that a double click on the sash quickly restores the size, so maybe its not as bad...
I think we'd want some other way to reset as double clicking the sash isn't widely known. Do we reset the height when the question session times out? If so I think it's fine as is.
We no longer do the session time out thing (aka Spotlight inspired timeout). Though, maybe I could introduce a timeout that will, after a few minutes, revert to the dynamic grow behavior?
I guess something like 30 seconds before revert would work alright, either that or some button shows up which lets the user go back to auto.
What are some verification steps for this issue? Here's what I see so far: If I ask a question, it starts from the top and starts growing downwards again If I close the chat and then reopen it a minute later, the answer is still there, and the chat is still expanded. If I ask another question, it starts from the top again, but that's true even if I don't wait 30 seconds If I manually move the sash, it seems like it's just stuck at that size
Verification steps: Ask a question like Get a long answer: ! scroll down to make it bigger ! hide it and show it again quickly. It should still look like screenshot 2 where you see everything hide it and wait 1min and show it again. It should look like screenshot 1 where you only see the last q&a
Change:
return path.replace(/^([a-z]):/i, (_, letter) => `${letter.toUpperCase()}:`); } <del> const COMMIT_FORMAT = '%Hn%aNn%aEn%atn%Pn%B'; </del> <ins> const COMMIT_FORMAT = '%H%n%aN%n%aE%n%at%n%P%n%B'; </ins> export class Git {

Discussion:
VSCode Version: 1.42.0 OS Version: Darwin x64 19.2.0 Git version: 2.24.1 Steps to Reproduce: and Debug extension git api commands, specifically Results in This format option was introduced here, and seems to be the change causing the issues I'm experiencing:
Reopening as it is not merged yet.