jiebi/CodeConvo huggingface dataset:
Change:
{ "open": "`", "close": "`", "notIn": ["string", "comment"] } ], "indentationRules": { <del> "increaseIndentPattern": "({+(?=([^"]*"[^"]*")*[^"}]*$))|([+(?=([^"]*"[^"]*")*[^"]]*$))", </del> <ins> "increaseIndentPattern": "({+(?=((.|[^"])*"(.|[^"])*")*[^"}]*)$)|([+(?=((.|[^"])*"(.|[^"])*")*[^"]]*)$)", </ins> "decreaseIndentPattern": "^s*[}]],?s*$" } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: a JSON file in which values including , with a pair of escaped double quotes like below. lines between and by + /, then these lines are indented incorrectly. ! [Edited] This issue still remains in 1.68.1 (the latest version at 2022/6/17).
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Change:
.codeActionMenuWidget .monaco-list .monaco-list-row:hover:not(.option-disabled), .codeActionMenuWidget .monaco-list .monaco-list-row.focused:not(.option-disabled) { background-color: var(--vscode-list-hoverBackground) !important; <ins> color: var(--vscode-list-activeSelectionForeground) !important; </ins> } .codeActionMenuWidget .monaco-list .monaco-list-row.focused:not(.option-disabled)  {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: In some color themes, like the Default Light themes, the selected object's text is hard to read in the code action widget. !
Change:
import { IAiRelatedInformationService, RelatedInformationType, SettingInformationResult } from 'vs/workbench/services/aiRelatedInformation/common/aiRelatedInformation'; import { TfIdfCalculator, TfIdfDocument } from 'vs/base/common/tfIdf'; import { IStringDictionary } from 'vs/base/common/collections'; <ins> import { nullRange } from 'vs/workbench/services/preferences/common/preferencesModels'; </ins> export interface IEndpointDetails { urlBase?: string;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.2 OS Version: macOS Sonoma 14.1 M1/arm64 Steps to Reproduce: VSC with extensions disabled settings panel 'a' or 'ai' or 'smart ai' in search field hangs and throws below error Logs:
Change:
"license": "MIT", "description": "Dependencies shared by all extensions", "dependencies": { <del> "typescript": "5.1.3" </del> <ins> "typescript": "5.1.6" </ins> }, "scripts": { "postinstall": "node ./postinstall.mjs"

Discussion:
Track picking up
To verify, just open a TS file and click on the language status to check that the bundled TS version is 5.1.6
Change:
* Mark the end of the animation frame performing the rendering. */ function markRenderEnd() { <del> performance.mark('render/end'); state.render = EventPhase.Finished; </del> <ins> if (state.render === EventPhase.InProgress) { performance.mark('render/end'); state.render = EventPhase.Finished; } </ins> } function scheduleRecordIfFinishedTask() {

Discussion:
I suspect this comes from
You're right, this is: Right now, the module assumes that it will be called in the following order: It is possible that if a is skipped by the browser that we don't mark and that would cause an error at
Good morning I'm having trouble logging into the app. I get the following error. Uncaught SyntaxError: Failed to execute 'measure' on 'Performance': The mark '<REDACTED: user-file-path' does not exist. I hope you can help me with the solution. thank you.
Change:
private showValidationMessage: boolean; private state = 'idle'; private cachedHeight: number; <ins> private disposables: IDisposable[] = []; </ins> private _onDidChange = this._register(new Emitter<string>()); public onDidChange: Event<string> = this._onDidChange.event;

Discussion:
Right now, this sort of ruins the feeling of an input with options -- it becomes more like an input followed by some toggles ! -- if you have the time
! there you go
I made you a reviewer
Nice solution. Merged.
Change:
} }); }); <ins> test('quickSuggestions', () => { assert.deepStrictEqual(migrate({ quickSuggestions: true }), { quickSuggestions: { comments: 'on', strings: 'on', other: 'on' } }); assert.deepStrictEqual(migrate({ quickSuggestions: false }), { quickSuggestions: { comments: 'off', strings: 'off', other: 'off' } }); assert.deepStrictEqual(migrate({ quickSuggestions: { comments: 'on', strings: 'off' } }), { quickSuggestions: { comments: 'on', strings: 'off' } }); }); </ins> test('hover', () => { assert.deepStrictEqual(migrate({ hover: true }), { hover: { enabled: true } }); assert.deepStrictEqual(migrate({ hover: false }), { hover: { enabled: false } });

Discussion:
Currently, the setting doesn't render in the Settings editor, because the Settings editor cannot handle settings with types. The current accepted values are of the form Questions: is the difference between and or and for each field? just a shorthand for setting each field to ? If we can change the setting configuration so that it is just an object with fields "strings", "comments", and "other", and the value for each field is an enum of options , then the setting can render in the Settings editor UI. Along with changing the type over, we'll have to migrate the setting value for users still using the old setting value. I believe Emmet has example code for this process for the setting .
Yeah, there is a lot of history: it started with a simple boolean, become an object with booleans, and it now an object with enum values. When working on I tried to simplify the setting but without success, I couldn't get the editor to render this... I'll try to simplify the setting to be a simple object with just (string) enum values
I have started on this, the setting is now just an but the settings editor still doesn't show it. What is missing?
I don't believe we currently support anyOf bool string, still. Are you expecting it to render as an enum like true, false, "on", "inline", "off"? Also, needs to be set to .
Cool. Thanks! That did make the difference here <img width="562" alt="Screenshot 2022-05-05 at 09 22 08" src="https://user-"
Change:
border-top: 0px !important; } <ins> #issue-reporter .system-info { margin-bottom: 10px; } </ins> input[type="checkbox"] { width: auto;

Discussion:
!
is this in OSS or in insiders?
This was oss
yep, this is a known issue in OSS with the css bundling. it ends up fine in Insiders and stable, but unsure why this has been the case for a while now. same as i believe
They still happen in insiders, just the button width isn't the same for some reason (you could inspect the element in devtools to diff the styles): !
Change:
...options, ...overrideOptions, persistence: { <del> hideOnHover: true, </del> hideOnKeyDown: true, ...overrideOptions.persistence },

Discussion:
a status bar contribution with an actionable tooltip, like Rust Analyzer's contribution in a repo with Rust code (like vscode) or Joh's PR pinger over the status bar entry and try to move your mouse to interact with it disappears !
This seems like a recent regression to me because for the window zoom status entry this used to work recently. can you see if its maybe something you changed?
Unless it's explicitly indicated as not hoverable any hover with markdown will allow it. I do notice is set to true in the new workbench hover delegate which is surprising to me, not sure why it wouldn't be using the default which is dynamically selected: has been making a lot of hover changes recently.
please cc me on workbench hover-related PRs so I can track changes going in. It's good you're taking some ownership but I just want to make sure I'm kept up to date
So this is a bug. I noticed it a while ago and just got used to pressing and keeping pressed (using Windows) to be able to click on things inside the hover.
some hovers intentionally cannot be moused over so I'm glad you discovered alt
Initially the new was introduced to have a simple way to replace the native hover. Due to this it made sense to set to make sure the behaviour is similar to the native one. It afterwards turned out that using the was a nice way to clean up some of the existing custom hover code such as the one in the status bar. It makes sense to switch back to the default behaviour for .
Change:
import * as nls from 'vs/nls'; import 'vs/css!./media/update.contribution'; import { Registry } from 'vs/platform/registry/common/platform'; <del> import { isMacintosh } from 'vs/base/common/platform'; import product from 'vs/platform/node/product'; </del> import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from 'vs/workbench/common/contributions'; import { ReleaseNotesEditor } from 'vs/workbench/parts/update/electron-browser/releaseNotesEditor'; import { ReleaseNotesInput } from 'vs/workbench/parts/update/electron-browser/releaseNotesInput';

Discussion:
We should push the update UI we were running on insiders to stable. Since the new update notification UI is less invasive, there is the concern that users might forget to update and ignore the notification. Therefore we should add an update reminder, when a user did not update after a period of time. The proposal is to show the existing Update Available message box, when the user did not update after 5 days since the notification has appeared.
Will be fixed by
Fixed.
Change:
import 'vs/workbench/contrib/snippets/browser/snippets.contribution'; import 'vs/workbench/contrib/snippets/browser/snippetsService'; import 'vs/workbench/contrib/snippets/browser/insertSnippet'; <ins> import 'vs/workbench/contrib/snippets/browser/surroundWithSnippet'; </ins> import 'vs/workbench/contrib/snippets/browser/configureSnippets'; import 'vs/workbench/contrib/snippets/browser/tabCompletion';

Discussion:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.
Change:
const someAudioCueFeatureIsEnabled = derived( (reader) => /** @description someAudioCueFeatureIsEnabled */ this.features.some((feature) => <del> this.isEnabledCache.get(feature.audioCue).read(reader) </del> <ins> this.isEnabledCache.get(feature.audioCue).read(reader) || this.isAlertEnabledCache.get(feature.audioCue).read(reader) </ins> ) );

Discussion:
Testing "Audio Cues: Line Has Warning" is set to false. "Accessibility Alert: Warning" is set to true. I generated a warning by using the Markdown Lint extension and writing text into a new Markdown file without an h1 header. When I turn on the audio cue, the accessibility alert also alerts me that there's a warning. When I turn off the audio cue but leave the accessibility alert on, the accessibility alert does not alert me that there's a warning.
I cannot seem to trigger a warning - can you pls give more specific instructions about how to do so? !
Install the extension. Then create a .md file and paste in the following The extension should already generate a warning.
Note this issue when verifying . When I tested using a screen reader, the warning only appeared once. Based on debugging (the call happens), I believe when using a braille device, this works.
Change:
constructor( initial: string | string[], @IURLService private readonly urlService: IURLService, <del> @IWindowsMainService windowsMainService: IWindowsMainService </del> <ins> @IWindowsMainService windowsMainService: IWindowsMainService, @IEnvironmentService environmentService: IEnvironmentService </ins> ) { const globalBuffer = ((<any>global).getOpenUrls() || []) as string[]; const rawBuffer = [

Discussion:
Issue Type: <bBug</bcode-oss on windows into the browser and click "Open" in resulting dialog ! Works on Mac still, haven't tried Linux VS Code version: Code - OSS Dev 1.41.0 (Commit unknown, Date unknown) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Hi, I have tracked this down to ! It seems that when you run Code - , the command is missing: ! By hardcoding my vscode folder location in: ! The app is able to open: ! Is there a command/utility function that will give this location?
Bingo! You should add this to the array only if not .
Verification: This is a Windows only issue.
Change:
"settings": { "foreground": "#b267e6" } <ins> }, { "name": "this.self", "scope": "variable.language", "settings": { "foreground": "#FD971F" } </ins> } ] }  No newline at end of file

Discussion:
VSCode Version: 1.13.0 OS Version: Mint 18 Steps to Reproduce: to print `this.someMethod(); You can see, that "this" is colorless. It's so bad, because I need with this highlight when I work with classes. For example comparsion between VS code(left) and Sublime (right). Also highlight for arguments sometimes is in place, sometimes is not. !
You can install extension for this. I recommended or
This is not a bug in the grammar. Other themes colorize just fine: ! Monokai does not however
Change:
this._widgetDisposableStore.add(editorModel.onDidChangeContent(() => { const value = editorModel.getValue(); <del> if (this.input?.resource && value !== '') { (this.input as InteractiveEditorInput).historyService.replaceLast(this.input.resource, value); </del> <ins> if (this.input?.resource) { const historyService = (this.input as InteractiveEditorInput).historyService; if (!historyService.matchesCurrent(this.input.resource, value)) { historyService.replaceLast(this.input.resource, value); } </ins> } }));

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --four cells from the interactive window input box, e.g. , , , reexecute multiple commands from earlier in your history, e.g. and use via the up arrow executing an entry from earlier in the history e.g. , scroll position resets to the bottom of the history, and you have to start over and scroll up from the most recent command (4 -3 - 2 -1). This can be frustrating for users who are trying to reexecute multiple commands. Note also that the original interactive window used to preserve your scroll history in the interactive window so that you didn't have to scroll back up through the entire history, and users have complained about this behavior change:
The expectation is that the interactive window input behaves just like a REPL. would address this. Per discussion with we should have shared logic for handing history traversal.
Any news on that? I agree with the PR that the current behavior is quite frustrating and deserves further attention.
Yes this is one of my main frustrations with the IW still. At minimum I just want the up arrow to go to the last executed code, not have cycle through like 20 cells every time I need to re-run something. And it did used to work this way ~1.5 yrs ago.
Change:
this.activeRepositoryNameContextKey.set(repository?.provider.name ?? ''); this.activeRepositoryBranchNameContextKey.set(repository?.provider.historyProvider?.currentHistoryItemGroup?.label ?? ''); } <ins> dispose(): void { this.focusDisposable.dispose(); this.disposables.dispose(); } </ins> } export class SCMActiveResourceContextKeyController implements IWorkbenchContribution {

Discussion:
Testing a multi folder workspace with 1 repository each the branch name updates in the statusbar, but not in the title bar until the user switches to a new tab/file
I don't repro this on Windows with a custom titlebar, but it does take a few seconds for the titlebar to change the title in my case.
Pushing a fix to for this issue. I do want to call out that the status bar item is being updated "optimistically" so that we can show a "loading" indicator while the checkout is in progress. Due to this there might be a delay in the title bar being updated as the title bar only updates when the checkout completed.
I'm seeing the same behaviour, meaning I might not have encountered the actual issue in the first place. could you verify this issue?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Pinging about verification
Change:
'!build/win32/**', '!extensions/markdown-language-features/notebook-out/*.js', '!extensions/markdown-math/notebook-out/**', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/notebook-renderers/renderer-out/**', '!extensions/php-language-features/src/features/phpGlobalFunctions.ts', '!extensions/typescript-language-features/test-workspace/**',

Discussion:
Running on main:
Am I missing something on how to run this? An ignore rule is in :
Change:
"default": 50, "minimum": 0, "maximum": 100, <del> "description": "%config.similarityThreshold%", </del> <ins> "markdownDescription": "%config.similarityThreshold%", </ins> "scope": "resource" } }

Discussion:
Type: <bBug</bGo to 'Source control' and click 'Initialize Repository'. An error message shows "Git:unknown switch 'b'". VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ LiveServer5.7.9 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Having the same issue after a recent update this morning. Version: 1.79.2 Date: 2023-06-14T08:58:52.392Z (1 day ago) Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
Could you please share the contents of the ? Thanks!
I encountered the same issue.... Output from GIT: 2023-06-16 10:31:06.946 [info] git init -b main [4ms] 2023-06-16 10:31:06.946 [info] error: unknown switch `b' usage: git init [-q | --quiet] [--bare] [--template=<template-directory] [--shared[=<permissions]] [<directory] --template <template-directorydirectory from which templates will be used --bare create a bare repository --shared[=<permissions] specify that the git repository is to be shared amongst several users -q, --quiet be quiet --separate-git-dir <gitdirseparate git dir from working tree 2023-06-16 10:33:13.422 [info] git rev-parse --show-toplevel [1ms] 2023-06-16 10:33:13.422 [info] fatal: not a git repository (or any of the parent directories): .git
Yes, that's the exact same Output received.
Could you please share the version of git that you are using? Thank you!
!
Change:
} collapseAll(): void { <ins> const treeInput = this.tree.getInput(); if (Array.isArray(treeInput)) { if (this.hasExpandedItemInsideFolder(treeInput)) { treeInput.forEach(folder => { folder.children.forEach(child => this.tree.hasNode(child) && this.tree.collapse(child)); }); return; } } </ins> this.tree.collapseAll(); } <ins> private hasExpandedItemInsideFolder(treeInput: ExplorerItem[]): boolean { for (const folder of treeInput) { if (this.tree.hasNode(folder) && !this.tree.isCollapsed(folder)) { for (const [, child] of folder.children.entries()) { if (this.tree.hasNode(child) && !this.tree.isCollapsed(child)) { return true; } } } } return false; } </ins> previousCompressedStat(): void { const focused = this.tree.getFocus(); if (!focused.length) {

Discussion:
Originally to search in I swear there is an issue for having this in the explorer somewhere but I can't find it. Possible that it was closed as out of scope at some point, but I've always wanted this and I am trying to implement it. I will also add a setting to disable this. I don't know whether we would want it on by default or not.
We can't really do a common implementation for this because the tree doesn't give a way to examine the tree structure of the data. The Navigator is not sufficient because we don't know the depth of nodes as we visit them. We could have a common helper utility that would take some delegate to give info about the model's tree structure with an API like the old IDataSource, or the depth of nodes + navigator, but it seems like overkill given that the utility of this is limited. I think search+explorer are the only places where this is useful. If there is a third, maybe we try for a common implementation...
Adding verified label since this works great :)