jiebi/CodeConvo huggingface dataset:
Change:
import { Registry } from 'vs/platform/registry/common/platform'; import { IAccessibleViewService, AccessibleViewService } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; import { UnfocusedViewDimmingContribution } from 'vs/workbench/contrib/accessibility/browser/unfocusedViewDimmingContribution'; <del> import { EditorAccessibilityHelpContribution, HoverAccessibleViewContribution, InlineCompletionsAccessibleViewContribution, NotificationAccessibleViewContribution } from 'vs/workbench/contrib/accessibility/browser/accessibilityContributions'; </del> <ins> import { HoverAccessibleViewContribution, InlineCompletionsAccessibleViewContribution, NotificationAccessibleViewContribution } from 'vs/workbench/contrib/accessibility/browser/accessibilityContributions'; </ins> import { AccessibilityStatus } from 'vs/workbench/contrib/accessibility/browser/accessibilityStatus'; import { CommentsAccessibilityHelpContribution } from 'vs/workbench/contrib/comments/browser/comments.contribution'; import { IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; import { AccessibleNotificationService } from 'vs/workbench/contrib/accessibility/browser/accessibleNotificationService'; <ins> import { EditorAccessibilityHelpContribution } from 'vs/workbench/contrib/accessibility/browser/editorAccessibilityHelp'; </ins> registerAccessibilityConfiguration(); registerSingleton(IAccessibleViewService, AccessibleViewService, InstantiationType.Delayed);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In previous versions, with the use of and the extension, I could easily select and copy terminal output content in the "Accessible View" via Vi mode. However, in the update, I noticed a change that "The Accessible View now closes when a user starts typing and focuses the prior element for a smoother work flow.". This change prevents me from using Vi mode to select content in the "Accessible View." Could you please consider providing an option that allows users to choose whether or not this feature is enabled? Alternatively, are there any other solutions to this issue?
Related to
can you take a look at this one? Thanks!
To verify, disable and make sure the view does not close on key press.
Fixed now! Thanks for the quick resolution!
Change:
}); } } <ins> const before = this._tree.getFocus().length; </ins> this._tree.setChildren(null, elements); <ins> // Temporary fix until we figure out why the tree doesn't fire an event when focus & selection // get changed to empty arrays. if (before > 0 && elements.length === 0) { this._onTriggerEmptySelectionOrFocus.fire({ elements: [] }); } </ins> this._tree.layout(); this._onChangedAllVisibleChecked.fire(this.getAllVisibleChecked());

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0-insider OS Version: MacOs Steps to Reproduce: In the python and python debugger extension we use the QuickPick, we add an option to accept the value in the input. It was working in stable, but in insiders it doesn't work. Steps: a picker some text in the input box, make sure that it match with one option at first. enter, to select the text in the input box. last value that appeared in the list is the one that is selected. You can check the implementation . I was debugging the code a little bit, and found that in stable when you press enter, the function is called. But in insider when you press enter instead of call that function, the function is called.
Verification: Install Python extension Open a python workspace with no Open the debug pane and click the "create a file" Choose Python Debugger Choose Django Type ONLY 'b' and notice that "Browse Files" becomes the active item Type then, 'z' and notice that the list is empty hit ENTER and notice that the gets created with "bz" in the
The fix fully resolves as well!
Resolves my issue as well.
Change:
if (!notification.hasProgress) { notification.close(); } <ins> this.accessibleNotificationService.notify(AccessibleNotificationEvent.Clear); </ins> } } }

Discussion:
Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
return; } <del> await repository.push(); </del> <ins> if (!repository.HEAD || !repository.HEAD.name) { window.showWarningMessage(localize('nobranch', "Please check out a branch to push to a remote.")); return; } try { await repository.push(); } catch (err) { if (err.gitErrorCode !== GitErrorCodes.NoUpstreamBranch) { throw err; } const branchName = repository.HEAD.name; const message = localize('confirm publish branch', "The branch '{0}' has no upstream branch. Would you like to publish this branch?", branchName); const yes = localize('ok', "OK"); const pick = await window.showWarningMessage(message, { modal: true }, yes); if (pick === yes) { await this.publish(repository); } } </ins> } @command('git.pushWithTags', { repository: true })

Discussion:
VSCode Version: Code 1.14.0 (, 2017-07-10T18:24:22.120Z) OS Version: Darwin x64 16.6.0 When working on a new branch and trying to when no upstream branch has been set, an error pops up stating: It would be nice if it could ask for the user to input a branch name to set as an upstream branch for the local one.
We should instead ask the user if he wants to the branch instead. Want to attempt a PR?
I'm in the beginning, but I would like to contribute. Can you give me some initial help? To define the problem... I could check if the upstream is set and If I did not set, call up the "push to ..." function?
You don't need to check if the upstream is set. You can actually try to figure out which error comes from git (). If you detect that the error is related to the fact that there is no upstream branch configured, you can ask the user whether he wants to publish the current branch in a message. If so, just run the command.
[ the link is broken. I try to debug the git extension but the breakpoint, It does not work because source map not present... how to ? system osx sierra 10.12.5 (16F73) vscode 1.14.1 (1.14.1)]
Fixed the link. Debugging is currently not set up. Sorry.
right link ok. So i add the if condition, in try catch block related to ?
It seems to me this message: git remote -v pipop /Users/userpippo/Desktop/progetti/remote/ (fetch) pipop /Users/userpippo/Desktop/progetti/remote/ (push) git push fatal: No configured push destination. .... or this ? git push pipop fatal: The current branch master has no upstream branch. To push the current branch and set the remote as upstream, use git push --set-upstream pipop master
Change:
hc: null }, nls.localize('editorDragAndDropBackground', "Background color when dragging editors around. The color should have transparency so that the editor contents can still shine through.")); <ins> // < --- Resource Viewer --- > export const IMAGE_PREVIEW_BORDER = registerColor('imagePreview.border', { dark: Color.fromHex('#808080').transparent(0.35), light: Color.fromHex('#808080').transparent(0.35), hc: contrastBorder }, nls.localize('imagePreviewBorder', "Border color for image in image preview.")); </ins> // < --- Panels --- >

Discussion:
See for context
, I will take a look at this. Adding border to image as suggested in the other issue.
Change:
import { ThemeIcon } from 'vs/platform/theme/common/themeService'; import { IOutputService } from 'vs/workbench/services/output/common/output'; import * as Constants from 'vs/workbench/contrib/logs/common/logConstants'; <ins> import { sha1Hex } from 'vs/base/browser/hash'; </ins> registerSingleton(IEditSessionsLogService, EditSessionsLogService, false); registerSingleton(IEditSessionsStorageService, EditSessionsWorkbenchService, false);

Discussion:
Testing Continue from web inside desktop Let the window sit Install update (which restarts the App) you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code) Ideas don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus don't show this when my local changes are no different to those on the server <img width="1391" alt="Screenshot 2022-08-24 at 09 26 13" src="https://user-"
Is the custom modal overlay the same thing as the custom modal dialog, i.e. :+1: I filed for this.
Change:
super({ id: NOTEBOOK_FOCUS_PREVIOUS_EDITOR, title: localize('cursorMoveUp', 'Focus Previous Cell Editor'), <del> keybinding: { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), ContextKeyExpr.or( </del> <ins> keybinding: [ { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), </ins> ContextKeyExpr.and( ContextKeyExpr.has(InputFocusedContextKey), EditorContextKeys.editorTextFocus, NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('bottom'), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('none'), ), <ins> ), primary: KeyCode.UpArrow, weight: NOTEBOOK_EDITOR_WIDGET_ACTION_WEIGHT, // code cell keybinding, focus inside editor: lower weight to not override suggest widget }, { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), </ins> ContextKeyExpr.and( NOTEBOOK_CELL_TYPE.isEqualTo('markup'), NOTEBOOK_CELL_MARKDOWN_EDIT_MODE.isEqualTo(false), NOTEBOOK_CURSOR_NAVIGATION_MODE ) <del> ) ), primary: KeyCode.UpArrow, weight: KeybindingWeight.WorkbenchContrib, }, </del> <ins> ), primary: KeyCode.UpArrow, weight: KeybindingWeight.WorkbenchContrib, // markdown keybinding, focus on list: higher weight to override list.focusDown } ], </ins> }); }

Discussion:
Issue Type: <bBug</bWhen using intellisense prompts inside a .ipynb file, I am unable to use the arrow keys to navigate the given prompt. tested by just typing "impo" and then trying to navigate the import autocomplete prompts Unable to repro in the stable release, seems to be just the pre-release version Extension version: 2022.6. VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-21T05:16:12.334Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This sounds like an issue in the editor? Transferring to VS code. This isn't handled by the Jupyter extension.
It happens when there is only a single line in the cell.
Change:
const preview = MarkdownPreview.create( resource, previewSettings.previewColumn, <ins> previewSettings.resourceColumn, </ins> previewSettings.locked, this._contentProvider, this._previewConfigurations,

Discussion:
Issue Type: <bBug</b! When using the Markdown preview, the "Show Source" action should be smart enough to know that the source is open and go to that tab. Same applies to the preview tab, if there is already a preview tab open switch focus there. Otherwise you're in this endless loop of creating duplicate tabs. VS Code version: Code - Insiders 1.35.0-insider (, 2019-05-20T05:15:57.974Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (30)</summaryExtensionVersion ------ vscode-browser-preview0.5.4 vscode-opennewinstance0.0.6 bracket-pair-colorizer1.0.61 vscode-svgviewer2.0.0 vscode-eslint1.9.0 gitlens9.7.4 vsc-material-theme2.8.2 prettier-vscode1.9.0 azure-virtual-machine-explorer0.0.2 vscode-pull-request-github-insiders1.137.0 vscode-colorize0.8.10 theme-monokai-pro-vscode1.1.13 vscode-azureappservice0.14.0 python2019.4. remote-containers0.53.0 remote-ssh0.37.0 remote-ssh-edit0.37.0 remote-ssh-explorer0.37.0 remote-wsl0.36.0 azure-account0.8.4 azurecli0.4.5 vscode-typescript-tslint-plugin1.0.0 debugger-for-chrome4.11.3 vetur0.21.0 vscode-docker0.6.2 vscode-yaml0.4.0 code-settings-sync3.2.9 ayu0.18.0 WebTemplateStudio-dev-nightly0.0. markdown-all-in-one2.3.1 (17 theme extensions excluded) </details<!-- generated by issue reporter --
I'd like to give this a try
Ok, I could use some help on this issue. I traced the click call to the function , but am not sure if I should be making any changes here since it will very likely affect other functionalities as well.

I also noticed that if I have the file already open in the same split window pane, it will open that instead of creating a new split pane, but it is even when it opens a new pane with a new tab. So I am confused how calling the same function with the same parameter exhibits different behaviors (opening a new pane with a new tab vs opening an already open tab in the same pane). ! Some pointers around this would be very helpful, thanks
sorry for tagging you, not sure if you got a chance to see my previous comment. Can you please help out?
The api you linked to is a good starting point but that is part of core VS Code. You want the caller of that api, which in the case is the markdown extension. How I think this feature should work: the markdown extension, we maintain a . These should track which column created the preview. This is likely already passed in with , we just don't store the resourceColumn anywhere as far as I remember. the is invoked, use the preview's column information to decide which column to show the preview in
Change:
createInstance(shell?: IShellLaunchConfig, wasNewTerminalAction?: boolean): ITerminalInstance; getInstanceFromId(terminalId: number): ITerminalInstance; <ins> getInstanceFromIndex(terminalIndex: number): ITerminalInstance; </ins> getInstanceLabels(): string[]; getActiveInstance(): ITerminalInstance; setActiveInstance(terminalInstance: ITerminalInstance): void;

Discussion:
testing Version 1.15.0-insider Commit Date 2017-08-01T05:10:12.703Z Shell 1.6.6 Renderer 56.0.2924.87 Node 7.4.0 Architecture x64 Linux Testing "Rename some terminals through the gear icon on the right." Start VS Code Open a new terminal with ctrl+backtick Press , then type in Click on the gear, you can rename Delete the terminal Open a new terminal with ctrl+backtick Press , type in Click on the gear Result: Can no longer rename.
Change:
Add = 'workbench.action.addComment', NextThread = 'editor.action.nextCommentThreadAction', PreviousThread = 'editor.action.previousCommentThreadAction', <ins> NextCommentedRange = 'editor.action.nextCommentedRangeAction', PreviousCommentedRange = 'editor.action.previousCommentedRangeAction', </ins> NextRange = 'editor.action.nextCommentingRange', PreviousRange = 'editor.action.previousCommentingRange', ToggleCommenting = 'workbench.action.toggleCommenting',

Discussion:
Screen reader users like want to navigate between editor ranges that have comments. I think this makes sense. the recording I will share describes this in more detail.
I just realized that these already exist, and .
I respectfully think that we have miscommunication here. I am requesting a feature going to the next commented area. The commands that you are referring to are moving between commentable range, instead of commented area. The closest commands are alt+F9 () and alt+shift+F9 (). However, these commands directly and automatically opens the comment widget. I just want to jump to the next commented lines and manually open the applied comments manually if I need to review.
Ah, yes makes sense thanks for reminding me!
Change:
const result = renderMarkdown(mds).element; assert.strictEqual(result.innerHTML, `<p>a&lt;b&gt;b&lt;/b&gt;c</p>`); }); <ins> test('Should render html images', () => { const mds = new MarkdownString(undefined, { supportHtml: true }); mds.appendMarkdown(`<img src="http://example.com/cat.gif">`); const result = renderMarkdown(mds).element; assert.strictEqual(result.innerHTML, `<img src="http://example.com/cat.gif">`); }); test('Should render html images with file uri as same origin uri', () => { const mds = new MarkdownString(undefined, { supportHtml: true }); mds.appendMarkdown(`<img src="file:///images/cat.gif">`); const result = renderMarkdown(mds).element; assert.strictEqual(result.innerHTML, `<img src="vscode-file://vscode-app/images/cat.gif">`); }); </ins> }); });

Discussion:
Version: 1.62.0-insider (Universal) Commit: Date: 2021-10-28T05:14:00.367Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin arm64 20.6.0 Setting , on the markdown document of a completion item, an tag cannot load a PNG file if the path given as a URI with . If the path given as the path of a local filesystem, it can load the file. Steps to Reproduce: one of images cannot be loaded. !
Can I pick this up?
Sure, the relevant code where we fix image paths is:
For the markdown syntax images, if the URI schema is , that's being changed to . For the HTML tag images, the file URI remains as is. The HTML image with URI doesn't load due to CSP violation.
Yes uris are blocked for security reasons. The problem is that raw html tags don't go through the transform that I linked to One thing to try would be to look for image nodes in the rendered markdown and then transform their uris instead of relying on the markdown parser to handle the transform. Try looking at for that
/verified
Change:
'libgtk-3-0 (>= 3.9.10) | libgtk-4-1', 'libnss3 (>= 3.26)', 'libcurl3-gnutls | libcurl3-nss | libcurl4 | libcurl3', <del> 'xdg-utils (>= 1.0.2)' // OS integration </del> <ins> 'xdg-utils (>= 1.0.2)', 'libgssapi-krb5-2', 'libkrb5-3', </ins> ]; // Based on https://source.chromium.org/chromium/chromium/src/+/main:chrome/installer/linux/debian/manual_recommends // Dependencies that we can only recommend

Discussion:
On Ubuntu 16.04 <img width="571" alt="image" src=""Originally posted by in
On ubuntu 18.04 and using apt, almost the same error
Steps for verification: In Ubuntu 18.04 VM or Ubuntu 16.04 VM Install insiders debian package from Verify that error seen in is not shown and update completes successfully
Closing for verification.
Change:
return TPromise.join( Object.keys(desiredFilesMap).map( <del> (fileName) => pfs.fileExistsWithResult(paths.join(folderPath, fileName), fileName) </del> <ins> (fileName) => pfs.existsWithResult(paths.join(folderPath, fileName), fileName) </ins> ) ).then((fileNames: string[]) => { fileNames.forEach((existingFileName) => {

Discussion:
I'm currently creating an extension for Meteor. I only want to activate it if the workspace contains a Meteor project. For that I would like to check for the presence of a directory.
In around: should accept folders not only files
This will be very helpful. Been stuck playing with with no luck whatsoever. All the commands are activated even when the dont match. E.g. I've put only in there and the commands still got activated. Not sure how this works. If none of the criteria matches, then the commands shouldn't be activated, right?
Change:
weight: KeybindingWeight.EditorContrib - 1000, handler(accessor: ServicesAccessor) { const layoutService = accessor.get(IWorkbenchLayoutService); <del> layoutService.toggleZenMode(); </del> <ins> const contextKeyService = accessor.get(IContextKeyService); if (InEditorZenModeContext.getValue(contextKeyService)) { layoutService.toggleZenMode(); } </ins> }, when: InEditorZenModeContext, primary: KeyChord(KeyCode.Escape, KeyCode.Escape)

Discussion:
Issue Type: <bBug</ba shortcut like not in ZenMode the shortcut "alt+e alt+w" ZenMode would be turned on i.e. behaves just like ... Does this issue occur when all extensions are disabled?: Yes VS Code version: Code 1.63.2 (, 2021-12-15T09:40:02.816Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ dendron0.76.0 dendron-paste-image1.1.0 githistory0.6.19 todo-tree0.0.214 vscode-wordcount-cjk1.3.1 vscode-settings-cycler1.0.1 path-autocomplete1.18.0 python2021.12. wordcount0.1.0 markdown-checkbox1.7.2 vscode-yaml1.2.2 multi-command1.5.1 cjk-word-handler0.1.1 pdf1.2.0 markdown-all-in-one3.4.0 material-theme3.13.10 writing-extension-pack-for-binly0.0.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --usage scenario: Since the config setting (after toggled) would not be effective until re-enter the ZenMode (if already in ZenMode), and I only need for few scenario, the command would help for command macros. workaround: define multiple shortcuts depending on the when clause "inZenMode" and "!inZenMode", which may be very troublesome when combined with another when clauses ... (especially without paranthesis...
Hello! Can I take a look at this issue? Thanks!
sure! let me know if you need a pointer. Searching the codebase for 'exitZenMode' should get you started.
Thanks! Searching for did the trick. Fix for the issue above, although no worries if it's in your backlog. In the interim, you could use for keyboard shortcuts, although I understand the issue is mostly for automation and scripts.
, Can I please have a look at this if this has not been fixed yet? , hope it's fine with you, please let me know.