jiebi/CodeConvo huggingface dataset:
Change:
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { IEditorProgressService } from 'vs/platform/progress/common/progress'; <del> import { DelegatingEditor } from './delegatingEditorImpl'; </del> import { DiffEditorEditors } from './components/diffEditorEditors'; <ins> import { DelegatingEditor } from './delegatingEditorImpl'; </ins> import { DiffEditorOptions } from './diffEditorOptions'; import { DiffEditorViewModel, DiffMapping, DiffState } from './diffEditorViewModel'; <del> import { RevertButtonsFeature } from 'vs/editor/browser/widget/diffEditor/features/revertButtonsFeature'; </del> export interface IDiffCodeEditorWidgetOptions { originalEditor?: ICodeEditorWidgetOptions;

Discussion:
a change it using the gutter arrow :bug: indentation is lost
Can you share a screenshot/screenrecording and provide context on the document you have? Thanks!
Cannot reproduce: ! Please always try to include as much context as you can.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Hi Henning I think I can also reproduce this in 1.84.0-insider (MacOS). I believe the preconditions to reproduce is to set (which is also the default) and revert a deleted code chunk. See attached gif. !
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
Change:
}; } const originalError: undefined | nbformat.IError = output.metadata?.originalError; <del> const value: Error = JSON.parse(new TextDecoder().decode(firstItem.data.buffer.slice(firstItem.data.byteOffset))); </del> <ins> const value: Error = JSON.parse(textDecoder.decode(firstItem.data.buffer.slice(firstItem.data.byteOffset))); </ins> return { output_type: 'error', ename: value.name,

Discussion:
Issue Type: <bBug</bI was working on a notebook with lots of print output for debugging. 10min in, I could not save and got a notification of "Maximum call stack size exceeded". ! The kernel script was still running and printing hefty objects in a loop. I remember once crashing VS Code with long notebook output, so maybe this is related. Console log: Extension version: 2021.8. VS Code version: Code - Insiders 1.59.0-insider (, 2021-07-22T05:13:00.851Z) OS version: Darwin x64 20.5.0 Restricted Mode: No Remote OS version: Linux x64 5.10.25-linuxkit Fetching remote diagnostics for 'dev-container+7b22686f737450617468223a222f55736572732f64696769746172616c642f7265706f732f6465766469762d6d6574726963732d616e642d616e616c79736573222c2273657474696e6773223a7b22636f6e74657874223a226465736b746f702d6c696e7578227d7d' timed out. <details<summarySystem Info</summary Fetching remote diagnostics for 'dev-container+7b22686f737450617468223a222f55736572732f64696769746172616c642f7265706f732f6465766469762d6d6574726963732d616e642d616e616c79736573222c2273657474696e6773223a7b22636f6e74657874223a226465736b746f702d6c696e7578227d7d' timed out. </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Saving while logging long print statements worked fine now.
Change:
import { ITextEditorOptions } from 'vs/platform/editor/common/editor'; import { CancelablePromise, createCancelablePromise } from 'vs/base/common/async'; import { IFileService } from 'vs/platform/files/common/files'; <ins> import { ResourceContextKey } from 'vs/workbench/common/contextkeys'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; </ins> export class OutputViewPane extends ViewPane {

Discussion:
! Observed by
Do you have special steps for this? Do you see this with all output channels or only the MySQL one? Can you do the following when this happens: F1 Inspect Context Keys and then share what's printed on dev tools console
No specific repro steps - this happened immediately after upgrading in a test session - will try to repo on desktop doing it and report back!
Hi there, I think I received this email erroneously? I'm Nick Carver, but it looks like the original msg was from a Nick Craver. Cheers, Nick.
any new insights here?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Apologies I was on vacation for a bit - haven't been able to repro this since the latest update landed (but also have to unfortunately rebuild the machine we saw it on for terribad Windows reasons). Recommend we close this and if I can repro, will poke with more info :)
Leaving this open since saw this once but forgot to inspect context keys ()
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
steps: empty profile have a file under merge-conflict open the output view open the merge editor for the conflict file :bug: output view shows the merge overlay button
Change:
position: absolute; } <del> .xterm-decoration-overview-ruler { </del> <ins> .xterm-screen .xterm-decoration-container .xterm-decoration.xterm-decoration-top-layer { </ins> z-index: 7; <ins> } .xterm-decoration-overview-ruler { z-index: 8; </ins> position: absolute; top: 0; right: 0;

Discussion:
WT completed feature request: issue:
PR
To verify, for each value of , run the following: Verify the "overlined" text has an overline and " normal" does not.
With gpuAcceleration "off", I don't see an overline <img width="437" alt="image" src=""
Good find, I didn't update
After adding the styles, depending on the font it can still be cut off unfortunately due to the cell size in the dom renderer being strict. Captured that issue in
When verifying again, if you don't see an overline, inspect the DOM and verify shows on the children of
Not working still.
the remaining problem is tracked in
Not working on Latest Insiders.
Change:
// nothing ignored resolve(new Set<string>()); } else if (exitCode === 0) { <del> // paths are separated by the null-character resolve(new Set<string>(data.split('0'))); </del> <ins> resolve(new Set<string>(this.parseIgnoreCheck(data))); </ins> } else { if (/ is in submodule /.test(stderr)) { reject(new GitError({ stdout: data, stderr, exitCode, gitErrorCode: GitErrorCodes.IsInSubmodule }));

Discussion:
<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version 1.31.1 OS Version: Majove 10.14.3 Steps to Reproduce: the following files: /test/.gitkeep the following rules to .gitignore In the explorer file is grayed out even though git recognises it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
Just wanted to report this issue. The changes in the file will be reported in the git tab but it will be greyed out as well. On the explorer tab, there would be a letter indicating the change but still greyed out.
This issue is related: . According to it is caused by a bug in .
fixed via
Change:
return action; }); } <del> override dispose(): void { super.dispose(); if (this.actions) { this.actions = disposeIfDisposable(this.actions); } } </del> } class ManageExtensionAction extends Action {

Discussion:
Explorer focused: ! It's only working for debug: !
It seems to working for me <img width="370" alt="image" src=""Do you have any special theme, or customisations or set up? Probably try trouble shooting?
Also the state can be frozen: ! ! Same thing in dark modern. No errors in console
Here's a repro that seems reliable: the side bar narrow enough to make some of your activity icons get displaced into the ... menu. an option from that menu. Its icon appears and get selected with the underline correct. drag that icon left to position it nearer the start of the set of tabs in order for it not to get displaced onto the ... menu again. It loses its underline and even when you switch to another icon and back to this one it doesn't get underlined.
To reset, move activity bar to side, then back to top again.
Thanks for repro steps
OFF TOPIC. May I ask how to move the activity bar from left to top? Tried searching for settings and Googling, but didn't get any results.
if you're on the Insiders build you can right click the activity bar to change the position
To verify: Move activity bar to top Reduce the width of sidebar so that activity bar actions are exactly fit Switch to Debug view container. All activity bar actions moved to overflow action From overflow action, select explorer Make sure explorer is shown active
Change:
} } <del> return editors; </del> <ins> // Prevent duplicates: it is possible that we end up with the same // dragged editor multiple times because multiple data transfers // are being used (https://github.com/microsoft/vscode/issues/128925) const coalescedEditors: IDraggedResourceEditorInput[] = []; const seen = new ResourceMap<boolean>(); for (const editor of editors) { if (!editor.resource) { coalescedEditors.push(editor); } else if (!seen.has(editor.resource)) { coalescedEditors.push(editor); seen.set(editor.resource, true); } } return coalescedEditors; </ins> } export async function extractEditorsAndFilesDropData(accessor: ServicesAccessor, e: DragEvent): Promise<Array<IDraggedResourceEditorInput>> {

Discussion:
Type: <bBug</bSame steps as with . VS Code version: Code - Insiders 1.74.0-insider (, 2022-11-11T05:19:14.666Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
this.inputRenderer = this.instantiationService.createInstance(InputRenderer, this.layoutCache, overflowWidgetsDomNode, (input, height) => this.tree.updateElementHeight(input, height)); const delegate = new ListDelegate(this.inputRenderer); <ins> this.actionButtonRenderer = this.instantiationService.createInstance(ActionButtonRenderer); </ins> this.listLabels = this.instantiationService.createInstance(ResourceLabels, { onDidChangeVisibility: this.onDidChangeBodyVisibility }); this._register(this.listLabels);

Discussion:
This should not be a valid state: ! It should automatically switch to this: ! is how the SCM Input does it.
I am seeing this state when I am navigating using up/down buttons. Is it expected? ! !
That is probably unexpected, but I will let confirm that.
Yeah, just like the text box. The list doesn't support completely disabling it at the model layer. We can only disable it at the click operation.
Change:
.monaco-editor.inline-comment .margin-view-overlays .codicon-folding-expanded, .monaco-editor.inline-comment .margin-view-overlays .codicon-folding-collapsed { <del> margin-left: 14px; </del> <ins> margin-left: 11px; </ins> } .monaco-editor.inline-comment .margin-view-overlays .dirty-diff-glyph { <del> margin-left: 24px; </del> <ins> margin-left: 25px; </ins> }

Discussion:
Not sure if this was intentional but it's very small now: ! They are invisible when zooming out once: ! Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-16T05:18:32.502Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: WindowsNT x64 10.0. Sandboxed: Yes I preferred the old style: ! Version: 1.69.2 (user setup) Commit: Date: 2022-07-18T16:12:52.460Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: WindowsNT x64 10.0.
The mouse target is also 1 pixel wide now
Deleted lines are much harder to see and use now !
do you have any repro steps? I can't seem to see that, assume it was unintentional: ! !
This is in a PR so likely related to the comments changes
Still an issue after and fixes: !
This does seem likely to be related to the comments changes. I'm looking into it.
I have set, it works fine when I enable folding again
Change:
export const syncIgnored = new Codicon('sync-ignored', { character: 'eb9f' }); export const pinned = new Codicon('pinned', { character: 'eba0' }); export const githubInverted = new Codicon('github-inverted', { character: 'eba1' }); <del> export const debugAlt = new Codicon('debug-alt', { character: 'f102' }); </del> <ins> export const debugAlt = new Codicon('debug-alt', { character: 'eb91' }); </ins> export const serverProcess = new Codicon('server-process', { character: 'eba2' }); export const serverEnvironment = new Codicon('server-environment', { character: 'eba3' }); export const pass = new Codicon('pass', { character: 'eba4' });

Discussion:
Today I see no debug icon in the activity bar.
Yeah, I also can't see !
Removed in Looks like not longer in font and has different character code but it's actually in font
Sorry about that, I must've copied the wrong unicode character when I was cleaning up the unused debug icons. Looking into PR right now.
Change:
private _configHelper: TerminalConfigHelper; private _remoteTerminalsInitPromise: Promise<void> | undefined; private _localTerminalsInitPromise: Promise<void> | undefined; <del> private _connectionState: TerminalConnectionState; </del> <ins> private _connectionState: TerminalConnectionState = TerminalConnectionState.Connecting; </ins> private _nativeDelegate?: ITerminalServiceNativeDelegate; private _shutdownWindowCount?: number;

Discussion:
Also repro's in stable
unsure when this started happening. I don't see any open issues about it, which makes me think this is expected in WSL?
was last working in stable 1.59
and because it was broken in stable 1.60, we can narrow it down - the breaking change happened in August
looks like perhaps a race condition - get layout info is called w the correct workpsaceId, but then set layout info is called so might be wiping out the stored info before the reconnect can occur.
I open a terminal in a Remote-SSH window, reload the window, it is not reconnected
still doesn't work for WSL. based on my investigation, the pty service gets re-created when the window is reloaded, thus losing the and maps
when connected to localhost via ssh, reloading does persist the terminals but I thought this would still be using the ... !
Yep !
Also working for me in codespaces https://user-
It does work in WSL. interestingly, other state isn't persisted that should be though (see the layout change) !
this works on all remote platforms based on my testing. i saw a few times reloading WSL didn't work, but now cannot reproduce
Oh cool, I thought the situation was much worse. I'll reopen to verify on my side since we definitely want to make sure this is working everywhere
All seems to work
verified
Change:
if (!above.hasModel()) { return null; } <del> const insertContent = cell.getText(); </del> <ins> const insertContent = (cell.textModel?.getEOL() ?? '') + cell.getText(); </ins> const aboveCellLineCount = above.textModel.getLineCount(); const aboveCellLastLineEndColumn = above.textModel.getLineLength(aboveCellLineCount); above.textModel.applyEdits([

Discussion:
Testing I wouldn't expect joining a cell with the next cell to put the next cells first line on the same line at this cells last line. I think in most cases people wont leave trailing newlines, but they would expect joined cells to not mangle themselves. Similarly for splitting, I think we should remove dangling newlines.
Change:
resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-8.0.0.tgz#2c7a3b1163ef0441097e0b5d6389cd5504b59e5d" integrity sha512-AFbieoL7a5LMqcnOF04ji+rpXadgOXnZsxQr//r83kLPr7biP7am3g9zbaZIaBGwBRWeSvoMD4mgPdX3e4NWBg== <del> xterm-addon-canvas@0.3.0-beta.33: version "0.3.0-beta.33" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.33.tgz#5f6f673df9f8e9ea82d980a93adb8f0fe1ec5f0f" integrity sha512-nKZ3ieluM6GthY4LCOMF2uWtrHASz6efm9pekgeEmLz5DOINyCBSm2SsPp3s9edLTWMGHp8oe+diSk/+sz65cA== </del> <ins> xterm-addon-canvas@0.3.0-beta.35: version "0.3.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7"

Discussion:
Testing Code insiders, set how the inactive selection colour is stronger than the active selection colour I can only reproduce this with "canvas", all other gpu acceleration options work fine. Terminal focused ! Terminal not focused !
Upstream:
Change:
if (tasks.length > 0) { let { defaults, users } = this.splitPerGroupType(tasks); if (defaults.length === 1) { <del> this.run(defaults[0]).then(undefined, reason => { </del> <ins> this.run(defaults[0], undefined, TaskRunSource.User).then(undefined, reason => { </ins> // eat the error, it has already been surfaced to the user and we don't care about it here }); return;

Discussion:
Issue Type: <bBug</bRecent update to 1.48.0 seems to have killed sorting the Run Build Task list by most recently used. In fact, the list doesn't appear to change order at all (not sorting lexicographically, either). VS Code version: Code 1.48.0 (, 2020-08-13T07:50:42.600Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ vscode-open-in-application1.0.5 cortex-debug0.3.7 cpptools0.29.0 cmake0.0.17 vscodeintellicode1.2.10 clang-format1.9.0 linkerscript1.0.1 </details<!-- generated by issue reporter --
To verify: Open a folder with build tasks, such as the VS Code repo. If you use the VS Code repo, in the change the of the task to simply be (no ). Run the Tasks: Run Build Task command Choose a build task and run it from that quick pick Run the Tasks: Run Build Task command again. Verify that the task you just ran shows at the top of the list in the recently used section. Repeat with another build task.
Verified in Version: 1.48.1 Commit: Date: 2020-08-18T17:06:48.722Z
Change:
return []; } <del> // Deduplicate refNames and truncate them to 10 characters const refNames = Array.from(new Set<string>(options.historyItemRefs)) .map(ref => ref.substring(0, 10)); </del> <ins> // Deduplicate refNames const refNames = Array.from(new Set<string>(options.historyItemRefs)); </ins> let logOptions: LogOptions = { refNames, shortStats: true };

Discussion:
SCM Graph Filter from to (There are no results, is this a bug?) the view the view =results are shown for filter state but pill shows the state
Related
Keeping this issue scoped to the following as that is a great find that has to be addressed:
Pushed a change that should improve things, but will continue to look for a long-term fix.
Change:
*--------------------------------------------------------------------------------------------*/ import * as vscode from 'vscode'; <del> import { localize } from '../tsServer/versionProvider'; </del> <ins> import * as nls from 'vscode-nls'; </ins> import { TsServerLogLevel } from './configuration'; import { Disposable } from './dispose'; <ins> const localize = nls.loadMessageBundle(); </ins> export class LogLevelMonitor extends Disposable { private static readonly logLevelConfigKey = 'typescript.tsserver.log';

Discussion:
devtools. the vscode repo and open a TS file. . over an expression while the TS extension loads. hover appears. :bug: In the devtools console, the "didn't get externalized correctly" warning shows up.
Any ideas what would cause this?
This would happen if the call wasn't rewritten by the webpack loader defined here: can you look at the built version of typescript-language-features and tell me what the call looks like?
Ah looks like we're incorrectly importing from another file. Here's the compiled call (which doesn't appear to be rewritten): Will push a PR with a fix
That'll do it. loadMessageBundle is actually responsible for giving you your strings for that specific file so you need to have one of those everywhere you have a localize call
Change:
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import { optional } from 'vs/platform/instantiation/common/instantiation'; import { Choice, Placeholder, SnippetParser, Text, TextmateSnippet, Marker } from './snippetParser'; <del> import { ClipboardBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, SelectionBasedVariableResolver, TimeBasedVariableResolver, CommentBasedVariableResolver, WorkspaceBasedVariableResolver } from './snippetVariables'; </del> <ins> import { ClipboardBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, SelectionBasedVariableResolver, TimeBasedVariableResolver, CommentBasedVariableResolver, WorkspaceBasedVariableResolver, RandomBasedVariableResolver } from './snippetVariables'; </ins> import { registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import * as colors from 'vs/platform/theme/common/colorRegistry'; import { withNullAsUndefined } from 'vs/base/common/types';

Discussion:
[use case] generate a simple random string as a quick debug flag [feature request] add a $RANDOM varible to snippet or support JS expression as ES6 did e.g. ${().toString(36).slice(-6)}`
, I can take this up but need some starter and code pointers for this :) I just need some more understanding as we can do something like this (,$1);
Is this still open? Can I take this?
Go for it. Code pointer:
Duplicate of Alka
Change:
import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; namespace HoverAccessibilityHelpNLS { <del> export const intro = localize('intro', "The hover widget is focused. Press the Tab key to cycle through the hover parts."); </del> <ins> export const intro = localize('intro', "Focus on the hover widget to cycle through the hover parts with the Tab key."); </ins> export const increaseVerbosity = localize('increaseVerbosity', "- The focused hover part verbosity level can be increased with the Increase Hover Verbosity command<keybinding:{0}>.", INCREASE_HOVER_VERBOSITY_ACTION_ID); export const decreaseVerbosity = localize('decreaseVerbosity', "- The focused hover part verbosity level can be decreased with the Decrease Hover Verbosity command<keybinding:{0}>.", DECREASE_HOVER_VERBOSITY_ACTION_ID); export const hoverContent = localize('contentHover', "The last focused hover content is the following.");

Discussion:
Follow the setup in to trigger hover to focus into hover to focus a hover part to trigger accessibility help wording makes it sound like I can use from within the accessible view to cycle through the hover parts, but in reality I need to be focused on the hover first. !
Hi yes you are absolutely right. I will change the wording of that string.
Change:
} command += `cd ${quote(cwd)}; `; } <ins> if (env) { for (const key in env) { const value = env[key]; if (value === null) { command += `Remove-Item env:${key}; `; } else { command += `${env:${key}}='${value}'; `; } } } </ins> if (args.length > 0) { const arg = args.shift()!; const cmd = argsCanBeInterpretedByShell ? arg : quote(arg);

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
export const enum EditMode { Live = 'live', <ins> Preview = 'preview', /** @deprecated */ </ins> LivePreview = 'livePreview', <del> Preview = 'preview' </del> } Registry.as<IConfigurationMigrationRegistry>(ExtensionsMigration.ConfigurationMigration).registerConfigurationMigrations(

Discussion:
We believe is better than livePreview and therefore the default should change. Also we want to retire livePreview gracefully, e.g remove the option and then the implementation
Verify that defaults to