jiebi/CodeConvo huggingface dataset:
Change:
} if (!this.isBuilt) { this.isBuilt = true; <del> this.layoutService.mainContainer.appendChild(this.$el); </del> <ins> this.layoutService.activeContainer.appendChild(this.$el); </ins> } this.isVisible = true;

Discussion:
So that you know that you are debugging. //cc
I'm not sure on this, personally I would find it kind of annoying to have the toolbar on all windows. Maybe it's a setting, or can be dragged between windows? (Is there reusable cross-window drag logic yet?)
To clarify: not visible on all windows at the same time, but visible on the window that has focus maybe? Otherwise, it will be quite hard to step through a file using mouse in floating windows?
I think having it appear in the active window (when in floating mode) is good.
We solved this issue for quick open where we also want to appear it at the window that has focus. For that, there is which will always be the right container to put global UI elements and is derived from the currently active window. There is a event that can be used to reparent the UI element live.
Thanks!!!
Verification: Start debugging, and drag an editor out to an aux window Make sure the debug toolbar appears on whichever window has focus The debug toolbar should reappear in the same place per-window as you focus it
Change:
const position = this.validatePosition(_position); const lineContent = this.getLineContent(position.lineNumber); const lineTokens = this._getLineTokens(position.lineNumber); <del> const offset = position.column - 1; const tokenIndex = lineTokens.findTokenIndexAtOffset(offset); </del> <ins> const tokenIndex = lineTokens.findTokenIndexAtOffset(position.column - 1); // (1). First try checking right biased word const [rbStartOffset, rbEndOffset] = TextModel._findLanguageBoundaries(lineTokens, tokenIndex); const rightBiasedWord = getWordAtText( position.column, LanguageConfigurationRegistry.getWordDefinition(lineTokens.getLanguageId(tokenIndex)), lineContent.substring(rbStartOffset, rbEndOffset), rbStartOffset ); if (rightBiasedWord) { return rightBiasedWord; } // (2). Else, if we were at a language boundary, check the left biased word if (tokenIndex > 0 && rbStartOffset === position.column - 1) { // edge case, where `position` sits between two tokens belonging to two different languages const [lbStartOffset, lbEndOffset] = TextModel._findLanguageBoundaries(lineTokens, tokenIndex - 1); const leftBiasedWord = getWordAtText( position.column, LanguageConfigurationRegistry.getWordDefinition(lineTokens.getLanguageId(tokenIndex - 1)), lineContent.substring(lbStartOffset, lbEndOffset), lbStartOffset ); if (leftBiasedWord) { return leftBiasedWord; } } return null; } private static _findLanguageBoundaries(lineTokens: LineTokens, tokenIndex: number): [number, number] { </ins> const languageId = lineTokens.getLanguageId(tokenIndex); // go left until a different language is hit

Discussion:
VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.
For the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns
Any update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.
Have the same problem, but wonder about: "... autocomplete options for props ...". Is VS Code capable to autocomplete my custom from an imported component?
Change:
}); registerActiveXtermAction({ <del> id: TerminalChatCommandId.FocusResponse, title: localize2('focusTerminalResponse', 'Focus Terminal Response'), keybinding: { primary: KeyMod.CtrlCmd | KeyCode.DownArrow, when: TerminalChatContextKeys.focused, weight: KeybindingWeight.WorkbenchContrib, }, f1: true, category: AbstractInlineChatAction.category, precondition: ContextKeyExpr.and( TerminalChatContextKeys.focused ), run: (_xterm, _accessor, activeInstance) => { if (isDetachedTerminalInstance(activeInstance)) { return; } const contr = TerminalChatController.activeChatController || TerminalChatController.get(activeInstance); contr?.chatWidget?.focusLastMessage(); } }); registerActiveXtermAction({ id: TerminalChatCommandId.FocusInput, title: localize2('focusTerminalInput', 'Focus Terminal Input'), keybinding: { primary: KeyMod.CtrlCmd | KeyCode.UpArrow, secondary: [KeyMod.CtrlCmd | KeyCode.KeyI], when: ContextKeyExpr.and(TerminalChatContextKeys.focused, CTX_INLINE_CHAT_FOCUSED.toNegated()), weight: KeybindingWeight.WorkbenchContrib, }, f1: true, category: AbstractInlineChatAction.category, precondition: ContextKeyExpr.and( TerminalChatContextKeys.focused ), run: (_xterm, _accessor, activeInstance) => { if (isDetachedTerminalInstance(activeInstance)) { return; } const contr = TerminalChatController.activeChatController || TerminalChatController.get(activeInstance); contr?.terminalChatWidget?.focus(); } }); registerActiveXtermAction({ </del> id: TerminalChatCommandId.Discard, title: localize2('discard', 'Discard'), metadata: {

Discussion:
Originally posted by in
this is working AFAICT
On Windows, have to use Ctrl+Up to both go to the list and to go back down to the inputbox. after I focus the list, when I press Up again, it goes back in the input history and changes the inputbox, instead of moving up the list. !
Only tested on mac. Strange that they're different. does that reproduce in the panel chat?
No. It only occurs in terminal chat
Change:
import { distinct, flatten } from 'vs/base/common/arrays'; import { Emitter, Event } from 'vs/base/common/event'; <del> import { parse } from 'vs/base/common/json'; </del> <ins> import { JSONPath, parse } from 'vs/base/common/json'; </ins> import { Disposable } from 'vs/base/common/lifecycle'; import { getIconClasses } from 'vs/editor/common/services/getIconClasses'; import { FileKind, IFileService } from 'vs/platform/files/common/files';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.84.0 (system setup) OS: WindowsNT x64 10.0. Steps to Reproduce: "Add to Workspace Recommendations" any extension and select whichever place you like (i.e. among workspace & workspace folder) the or some comments inside_ the array once step 1. the comment from step 3. got erased. <!-- -- Titles & summaries: "add to rec" removes comments from extensions-recommendations array in the configuration file "add to rec" rewrites & hence erases any comments in extensions-recommendations array "add to rec" rewrites & hence erases any comments in Sample file:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.84.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
i wish there were patch updates if i have to update that frequently
p.s.: wow, never tried doing it from command palette pps: i think that no longer exists now
thanks all a lot
Change:
} else if (enterAction.indentAction === IndentAction.Indent) { // Indent once <del> executeCommand = TypeOperations.typeCommand(range, beforeText + 'n' + config.normalizeIndentation(indentation + 't' + enterAction.appendText), keepPosition); </del> <ins> executeCommand = TypeOperations.typeCommand(range, beforeText + 'n' + config.normalizeIndentation(indentation + enterAction.appendText), keepPosition); </ins> } else if (enterAction.indentAction === IndentAction.IndentOutdent) { // Ultra special let normalIndent = config.normalizeIndentation(indentation); <del> let increasedIndent = config.normalizeIndentation(indentation + 't' + enterAction.appendText); </del> <ins> let increasedIndent = config.normalizeIndentation(indentation + enterAction.appendText); </ins> let typeText = beforeText + 'n' + increasedIndent + 'n' + normalIndent;

Discussion:
VSCode Version: Code - Insiders 1.9.0-insider (, 2017-01-20T14:58:38.006Z) OS Version: Linux x64 4.8.0-34-generic Extensions: TypeScript file: ! Press enter: !
verified.
Change:
} } <del> declare const process: undefined | { readonly platform: string }; function isMac(): boolean { if (typeof process === 'undefined') { return false; } return process.platform === 'darwin'; } </del> function escapeAttribute(value: string | vscode.Uri): string { return value.toString().replace(/"/g, '&quot;'); }

Discussion:
Extension version: v0.29.2 VSCode Version: 1.59.0 OS: GitHub editor / mac Steps to Reproduce: "" on the right side image, it zooms in ctrl down and the icon turns into a "zoom out" icon Expected outcome: Zoom out Actual outcome: You see a menu with "Cut", "Copy", "Paste"
The image preview editor is provided by VS Code core (instead of this extension), so moving this issue to VS Code.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.509 --- <!-- score: 0.493 --<!-- potentialduplicatescomment --
maybe a safari issue?
In Chrome, ctrl-click only shows the menu In Safari, ctrl-click zooms out and also shows the menu
Thanks for the additional details. In Edge, I get only the zoom out.
Working fine in firefox.
Issue exists in Safari browser, how can I fix this
yes it works in safari , but the the cursor remains zoom out cursor even when I don't press control, it doesn't change back to + symbol
Can i work on this??
if you didn't work to zoom in or zoom out you use simply method on keybord key ctrl + or ctrl - .
I really want to be VS Code contributor. I try to working on this task since yesterday. I hope I will find the fix and my first meeting with VSC will end with success ;)
Zoom in Works fine in Safari, however zoom out works but the magnifying glass disappears and I had to double click (not sure if this is intentional) to get the image to properly zoom out while zoom in only take one click.
Change:
const commandReg = commandManager.register({ id: AddToIgnoreLinksQuickFixProvider._addToIgnoreLinksCommandId, execute(resource: vscode.Uri, path: string) { <del> const settingId = 'experimental.validate.ignoreLinks'; </del> <ins> const settingId = 'validate.ignoredLinks'; </ins> const config = vscode.workspace.getConfiguration('markdown', resource); const paths = new Set(config.get<string[]>(settingId, [])); paths.add(path);

Discussion:
Add some form of error reporting for links in markdown files where we are confident that link is incorrect. Example: We should also have a setting to disable this error reporting since we will not be able to understand every flavor of markdown link
Bad references (seems like this should almost always be a reasonable error to report) Missing files (false positive if users rely on different logic to resolve markdown paths) - Missing headers (false positive if users rely on custom slugifier or are linking to something besides headers, such as html elements) -Checking links to external resources () Checking html in markdown
Re-opening as we will likely keep this as experimental this iteration
Change:
*--------------------------------------------------------------------------------------------*/ import { Connection, createConnection } from 'vscode-languageserver/node'; <del> import { startServer } from '../server'; </del> <ins> import { startVsCodeServer } from '../server'; </ins> // Create a connection for the server. const connection: Connection = createConnection();

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was testing the server on neovim. I noticed the requires a lot from the client. Would it be possible to bundle default implementations of and all other custom requests to make the server self-contained?
I'd take a PR that does this (likely using service injection) but the current design is deliberate lets the client bring their own parser versionThe custom file messages means the server is not restricted to working with local files. Ideally the LSP would also include this functionality but right now it does not
I can make a PR. Wouldn't it be simpler to add a setting for a custom tokenizer? Then call with or make a request?
makes this easier to use the server as a library. For a client that doesn't want to implement the custom messages we use, you'd instead want to use the new version of which lets you pass in your own parser and workspace implementations
Change:
super({ id: 'workbench.action.decreaseViewWidth', title: { value: localize('decreaseEditorWidth', "Decrease Editor Width"), original: 'Decrease Editor Width' }, <del> f1: true </del> <ins> f1: true, precondition: IsAuxiliaryWindowFocusedContext.toNegated() </ins> }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 x64 OS Version: Steps to Reproduce: a new floating window with (or any of the other ones) a few split editors in the main view and the floating view a split in floating window the floating view, execute floating window editor size doesn't change, it happens in the main one
Good catch, these commands should not be available in floating windows.
Change:
.find(notebook => notebook.getCells().some(cell => cell.document === document)); if (notebook) { <del> const entries: TocEntry[] = []; </del> <ins> return TableOfContents.createForNotebook(parser, notebook); } } </ins> <del> for (const cell of notebook.getCells()) { if (cell.kind === vscode.NotebookCellKind.Markup && isMarkdownFile(cell.document)) { entries.push(...(await this.buildToc(parser, cell.document))); } } </del> <ins> return this.create(parser, document); } </ins> <del> return new TableOfContents(entries, parser.slugifier); </del> <ins> public static async createForNotebook(parser: IMdParser, notebook: vscode.NotebookDocument): Promise<TableOfContents> { const entries: TocEntry[] = []; for (const cell of notebook.getCells()) { if (cell.kind === vscode.NotebookCellKind.Markup && isMarkdownFile(cell.document)) { entries.push(...(await this.buildToc(parser, cell.document))); </ins> } } <del> return this.create(parser, document); </del> <ins> return new TableOfContents(entries, parser.slugifier); </ins> } private static async buildToc(parser: IMdParser, document: ITextDocument): Promise<TocEntry[]> {

Discussion:
Repro a notebook with the following markdown cells: still in edit mode, Try clicking on Bug Nothing happens Clicking on works since the header is within the same cell
Change:
initialActivationEvents: string[], @IInstantiationService private readonly _instantiationService: IInstantiationService, @IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService, <ins> @ITelemetryService private readonly _telemetryService: ITelemetryService </ins> ) { super(); this._cachedActivationEvents = new Map<string, Promise<void>>();

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Add telemetry at the startup of an extension host to know that the startup was begun. Add telemetry when the extension host is successfully started. Add telemetry when the extension host failed to start. This enables determining the success/failure rate of extension host startup as well as grouping of failure reasons to debug issues in the field.
Change:
"markdown.styles": { "type": ["array"], "default": [], <del> "description": "A list of URLs or local paths to CSS style sheets to use from the markdown preview. Relative paths are interpreted relative to the folder open in the explorer. If there is no open folder, they are interpreted relative to the location of the markdown file. All '' need to be written as ''." </del> <ins> "description": "%markdown.styles.dec%" </ins> }, "markdown.previewFrontMatter": { "type": ["string"], "default": "hide", <del> "description": "Sets how YAML front matter should be rendered in the markdown preview. 'hide' removes the front matter. Otherwise, the front matter is treated as markdown content" </del> <ins> "description": "%markdown.previewFrontMatter.dec%" </ins> } } }

Discussion:
VSCode Version:1.6 insiders OS Version: doesn't matter All settings related to css, sass, less, html, json and markdown. This might be because these come from extensions that are built in?
I've gone through the builtin extensions and opened new issues for each one that is missing setting localization. Please met me know if I missed any
Change:
multipleDefinitions: 'peek', multipleTypeDefinitions: 'peek', multipleDeclarations: 'peek', <del> multipleImplemenations: 'peek', </del> <ins> multipleImplementations: 'peek', </ins> multipleReferences: 'peek', }; const jsonSubset: IJSONSchema = {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.41.0-insider OS Version: Windows_NT x64 10.0. Steps to Reproduce: to settings for "Implemenations" "Editor Goto Location: Multiple Implemenations" appears instead of "Editor Goto Location: Multiple Implementations" This also shows up as "editor.gotoLocation.multipleImplemenations" in "" instead of as "editor.gotoLocation.multipleImplementations" <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Change:
target = element.isDirectory ? element : element.parent!; } <del> const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove }, incrementalNaming); </del> <ins> const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming); </ins> return { source: fileToPaste, target: targetFile }; }));

Discussion:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file
Change:
import { Iterable } from 'vs/base/common/iterator'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; <del> import { UriComponents } from 'vs/base/common/uri'; </del> <ins> import { URI, UriComponents } from 'vs/base/common/uri'; </ins> import { ILanguageService } from 'vs/editor/common/languages/language'; import { localize } from 'vs/nls'; import { MenuId, registerAction2 } from 'vs/platform/actions/common/actions';

Discussion:
It's easy to lose track of the debugged cell in notebooks, especially when you've stepped into a cell which is different from the cell that is "running". Some improvements we could make: The "Go To" button should go to the cell at the top of the callstack, not the cell where the user clicked Run We should show overview ruler decorations for the top stackframe, as in the editor And overview ruler decorations for the currently running cell And for breakpoints (behind a setting, ) cc
To verify, just try everything listed at the top. For I mean, have two cells, like and a second cell that calls . Set a breakpoint in the function definition, click run on the second cell, and make sure "Go To" goes to that first cell where the instruction pointer is.
Change:
} if (body) { <del> body.classList.remove('vscode-light', 'vscode-dark', 'vscode-high-contrast', 'vscode-reduce-motion', 'vscode-using-screen-reader'); </del> <ins> body.classList.remove('vscode-light', 'vscode-dark', 'vscode-high-contrast', 'vscode-high-contrast-light', 'vscode-reduce-motion', 'vscode-using-screen-reader'); </ins> if (initData.activeTheme) { body.classList.add(initData.activeTheme); <ins> if (initData.activeTheme === 'vscode-high-contrast-light') { // backwards compatibility body.classList.add('vscode-high-contrast'); } </ins> } if (initData.reduceMotion) {

Discussion:
As discussed in , we should let webviews make decisions based on the high contrast theme type. Proposed by cc
How should this be verified?
I think this can be verified by checking the style of the body in a webview? Here's one in stable with high-contrast light theme enabled: ! Here's the same one in insiders with same theme enabled: ! It would allow CSS rules based on the body having that class.
So something like so?
/verified Yeah that works for me. I used the webview-view-sample.
Yeah, in the webview ui toolkit so, hopefully, the vscode-high-contrast-light theme would be reflected there as well.
Which actually now that I look at screenshots more closely, it already is being reflected on the attribute
Also confirmed this works when working on a fix for the webview toolkit last week