jiebi/CodeConvo huggingface dataset:
Change:
import { testingCoverageMissingBranch } from 'vs/workbench/contrib/testing/browser/icons'; import { FileCoverage } from 'vs/workbench/contrib/testing/common/testCoverage'; import { ITestCoverageService } from 'vs/workbench/contrib/testing/common/testCoverageService'; <del> import { CoverageDetails, DetailType, IStatementCoverage } from 'vs/workbench/contrib/testing/common/testTypes'; </del> <ins> import { CoverageDetails, DetailType, IDeclarationCoverage, IStatementCoverage } from 'vs/workbench/contrib/testing/common/testTypes'; </ins> import { TestingContextKeys } from 'vs/workbench/contrib/testing/common/testingContextKeys'; const MAX_HOVERED_LINES = 30;

Discussion:
Refs: [x] anyOS [x] anyOS Complexity: 4 We have at long last finalized the test coverage API. Implementing an extension that produces data for the API from scratch is challenging, and requires domain-specific knowledge, so you might find playing with the selfhost test provider to be the most effective way to test it The new types in the API include: - - - Please: Do some testing that the API and UI functions as you would expect Read through the API and verify that its documentation makes sense to you See that UI interactions work nicely as you would expect (you can use any extension that produces coverage to test this part)
Change:
margin-top: -40px; } <ins> .ports-view .monaco-list .monaco-list-row .ports-view-actionbar-cell .ports-view-actionbar-cell-localaddress { color: var(--vscode-textLink-foreground); text-decoration: var(--text-link-decoration); } </ins> .ports-view .monaco-list .monaco-list-row .ports-view-actionbar-cell .ports-view-actionbar-cell-localaddress:hover { text-decoration: underline; }

Discussion:
Testing Forwarded ports links are not formatted correctly. The tooltip respects the underline setting, but the overall link does not ( is not blue nor does the underline setting affect the appearance). !
Change:
renderElement(element: IChatContentReference, index: number, templateData: IChatContentReferenceListTemplate, height: number | undefined): void { templateData.label.element.style.display = 'flex'; <del> const uri = 'uri' in element.reference ? element.reference.uri : element.reference; templateData.label.setFile(uri, { </del> <ins> templateData.label.setFile('uri' in element.reference ? element.reference.uri : element.reference, { </ins> fileKind: FileKind.FILE, // Should not have this live-updating data on a historical reference fileDecorations: { badges: false, colors: false }, <del> range: 'range' in element.reference ? element.reference.range : undefined </del> }); }

Discussion:
Type: <bBug</bis used as delimiter instead of <img width="499" alt="image" src=""VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-23T05:35:37.619Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ project-manager12.7.0 vscode-eslint2.4.2 gitlens14.4.0 EditorConfig0.16.4 vscode-todo-plus4.19.1 code-runner0.12.1 vscode-pull-request-github0.74.0 gitlab-workflow3.81.0 vscode-peacock4.2.2 vscode-random1.11.0 rainbow-csv3.8.0 dotenv1.0.1 remote-containers0.318.0 remote-ssh0.107. remote-explorer0.5. material-icon-theme4.31.0 partial-diff1.4.3 code-spell-checker3.0.1 sort-lines1.11.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please use the command to investigate possible cause.
I am seeing it in Explorer too, in today's Insider, with all extensions disabled: !
I am bisecting now...
Hmm, nothing found. Maybe I am doing it wrong.
From
Change:
return this._scrollBeyondLastLine && !this.isEmbedded; } <ins> private getBodyHeight(dimensionHeight: number) { return Math.max(dimensionHeight - (this._notebookTopToolbar?.useGlobalToolbar ? /** Toolbar height */ 26 : 0), 0); } </ins> layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, position?: DOM.IDomPosition): void { if (!shadowElement && this._shadowElementViewInfo === null) { this._dimension = dimension;

Discussion:
a notebook where two cells take up more than the scrollable region between the two cells, note how far down the region scrolls the panel off/on between the two cells again the scroll placement is different because returns a different value. !
Change:
'type': 'string', 'tags': ['experimental', 'usesOnlineServices'], 'default': 'off', <del> 'markdownDescription': localize('autoStoreWorkingChangesDescription', "Controls whether to automatically store available working changes in the cloud for the current workspace."), </del> <ins> 'markdownDescription': localize('autoStoreWorkingChangesDescription', "Controls whether to automatically store available working changes in the cloud for the current workspace. This setting has no effect in the web."), </ins> }, 'workbench.cloudChanges.autoResume': { enum: ['onReload', 'off'],

Discussion:
Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width="955" alt="image" src="https://user-"
In web we probably cannot support the value.
This is still on
I cannot reproduce this, just to be sure this is on the latest
Yes, reproduces even with caches disabled: !
Change:
assert.strictEqual(model.normalizeIndentation('  '), '  '); assert.strictEqual(model.normalizeIndentation(' '), ' '); assert.strictEqual(model.normalizeIndentation(''), ''); <del> assert.strictEqual(model.normalizeIndentation(' t   '), 'tt'); assert.strictEqual(model.normalizeIndentation(' t  '), 't   '); assert.strictEqual(model.normalizeIndentation(' t '), 't  '); assert.strictEqual(model.normalizeIndentation(' t'), 't '); </del> <ins> assert.strictEqual(model.normalizeIndentation(' t    '), 'tt'); assert.strictEqual(model.normalizeIndentation(' t   '), 't   '); assert.strictEqual(model.normalizeIndentation(' t  '), 't  '); assert.strictEqual(model.normalizeIndentation(' t '), 't '); assert.strictEqual(model.normalizeIndentation(' t'), 't'); </ins> assert.strictEqual(model.normalizeIndentation('ta'), 'ta'); assert.strictEqual(model.normalizeIndentation('    a'), 'ta');

Discussion:
Issue Type: <bBug</bPlease look this, ! Line 2: "Text" Line 3: .... This is auto indent line. ? (:, : ) ABC
I update this issue. But, It is automaticaly closed. Why? Please look this updated isuue.
What are the steps to reproduce? What is happening versus what you would expect to happen?
First line is, ( is white space, is Tab code) "Text" + -key Actual input is: (The above procedure removes the white space.) [Tab]-key, "Text", (move coursor position to the beginning of line), [Space][Space], (move coursor position to end of line), [Enter] The next cursor position is invalid. Please look the image of issue. I think, this is not serious but incorrect behavior.
Thank you for the extra information. Here are simplified steps: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain if indentation is configured with spaces, the new line will contain
Thanks.
can we have some verification steps?
Posting again with more explanations: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain . <---- this is a bug, the result should be such that the second line aligns with the first line if indentation is configured with spaces, the new line will contain <--- this is a bug, the result should be such that the second line aligns with the first line
Change:
kbOpts: { weight: CORE_WEIGHT, kbExpr: EditorContextKeys.textInputFocus, <del> primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyMod.Alt | KeyCode.UpArrow, </del> <ins> primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.UpArrow, </ins> linux: { primary: 0 } } }));

Discussion:
VSCode Version: Code 1.17.1 (, 2017-10-10T14:24:50.851Z) OS Version: Windows_NT x64 10.0. Current default keybindings on Windows: has two key bindings, which seems unnecessary. On Linux the default key bindings are (IIRC): Which makes a lot more sense IMHO. Also using this default on Windows would also align Windows/Linux key bindings and maybe even avoid complications like . (same for of course)
We will not change this. See
Change:
languageId?: string; } <del> export class AccessibleView extends Disposable { </del> <ins> export class AccessibleView extends Disposable implements ITextModelContentProvider { </ins> private _editorWidget: CodeEditorWidget; private _accessiblityHelpIsShown: IContextKey<boolean>;

Discussion:
Testing Repro: "getting started with accessiblity features" second step click on blue button to "open accessible view" results in an error in dev console says that "the editor is not accessible at this time" and advises to turn on screen optimized view, but I already have that on as you can see in status bar item. Version: 1.94.0-insider Commit: Date: 2024-09-24T05:04:12.797Z Electron: 30.5.1 ElectronBuildId: Chromium: 124.0.6367.243 20.16.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0
As part of this flow - I was also confused why a new file is opened after I close the Accessible View: !
I'm getting "the editor is not accessible at this time" messages while moving focus to the Python REPL input box or the Copilot Chat input box !
seems like an issue with the walkthrough accessible view?
this looks an issue with the accessible view editor. I'm seeing a similar issue when I open the chat-panel and request the accessible view.
Change:
import * as dom from 'vs/base/browser/dom'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; import { createTrustedTypesPolicy } from 'vs/base/browser/trustedTypes'; <ins> import { DomScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement'; </ins> import { Disposable, DisposableStore } from 'vs/base/common/lifecycle'; <ins> import { ScrollbarVisibility } from 'vs/base/common/scrollable'; </ins> import 'vs/css!./stickyScroll'; import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition } from 'vs/editor/browser/editorBrowser'; import { EmbeddedCodeEditorWidget } from 'vs/editor/browser/widget/embeddedCodeEditorWidget';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello So I have noticed when using Sticky Scroll, any line which is too long (for example the screenshot below), it would block off the rest of the code. A feature I was thinking would be a good adition is sideways scrolling (like what happens already in the main editor) so that people can see what else is in that line. <kbd<img src="https://user-"/</kbd
Change:
@IInstantiationService private instantiationService: IInstantiationService ) { this.stacks = editorGroupService.getStacksModel(); <ins> this.toDispose = []; </ins> this.parent = parent; this.dimension = new Dimension(0, 0);

Discussion:
For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.
I merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !
I can verify
LGTM - will push the revert revert commit
Verified via
Change:
import { CancellationToken } from 'vs/base/common/cancellation'; import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; <ins> import { Schemas } from 'vs/base/common/network'; </ins> /** * This interface represents a single command line argument split into a "prefix" and a "path" half.

Discussion:
Issue Type: <bBug</bDebug adapters have long been able to provide uris along with error responses, and these uris add buttons to the error dialog. Now that my PR has merged these can be command uris. However it is not currently possible to prevent an extra 'Open ' button being to the error dialog. In some situations there may be no point in the user opening Instead they should use a button that the error response . would it be reasonable for us to suppress addition of the 'Open ' button when the error is adding its own command-type button(s)? Limiting the change in this way should minimize the chance of upsetting existing DAs which return uris with their errors. It's unlikely they have been returning command-type uris because until now these haven't been actionable. VS Code version: Code - Insiders 1.57.0-insider (, 2021-05-14T20:13:58.234Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
this sounds reasonable. What is your exact use case? Just to check if other debug adapters might also profit here. fyi
my specific use case is that our implementation of launchRequest may determine that there is no debugging license for the target server. In this situation we want to help the user run the command which submits a request for a license. There is no point in suggesting that they edit their file. Are you happy for me to submit a PR?
Let's best wait and see feedback before you create a PR. Thanks
Yes, this request makes sense - feel free to submit a PR.
friendly ping for this, just to check if you are interested in tackling this. If not I might move out of this milestone. Thanks!
thanks for the ping. I still plan to get a PR in for August.
PR submitted
Lovely, thanks! Let me review it.
Would also be great if you double check with you debugger once we have a new Insiders on Monday. Thanks!
/verified
can you maybe also create a PR for the release notes for this feature? Here's the document And Andre and me left a TODO for you. Let me know if you do not have time and I can cover this. Thanks!
Submitted as You are welcome to edit it if you think the text needs improving.
Change:
} .monaco-workbench .repl .repl-tree .output.expression.value-and-source .source { <del> margin-left: 4px; </del> <ins> margin-left: auto; </ins> margin-right: 8px; cursor: pointer; text-decoration: underline; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; <del> max-width: 150px; </del> <ins> text-align: right; </ins> } .monaco-workbench .repl .repl-tree .output.expression > .value,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47 OS Version: MacOS Steps to Reproduce: a local project server (f.ex angular) with a long filename (some 16+ characters) <filename.<extension. a debug session (f.ex firefox), and check the debug console output. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes !
I don't understand what the screenshot is showing. Please show the whole debug console. I do not understand what gets concatenated in the screenshot. What exactly are you expecting and what is the erroneous behavior?
attached photo of whole debug console - error occurs on last line. Behavior: supposedly filenames (some 16+ characters) will be shortened with (...) instead of showing the whole filename and line number. Expecting: the whole filename and line number where a console log is being outputted. !
Yes, I agree this is an issue. The problem is that we set a to 150 . The ideal solution would be that the elements gets shrinked first, and that it has unlimited size. Adding help wanted as I am open to review a PR which fixes this. If nobody tackles this I can also look into this in the future.
Hi I can give this a try.
great, thanks!
Change:
} private synchronizeWebviewContainerDimensions(webview: IOverlayWebview, dimension?: DOM.Dimension) { <del> if (!this._element) { </del> <ins> if (!this._element?.isConnected) { </ins> return; } const rootContainer = this._workbenchLayoutService.getContainer(Parts.EDITOR_PART);

Discussion:
Repro: Get in this state: <img width="869" alt="image" src="https://user-"Close the right editor group: <img width="864" alt="image" src="https://user-"Version: 1.76.0-insider (user setup) Commit: Date: 2023-02-08T12:47:14.528Z Electron: 19.1.9 Chromium: 102.0.5005.194 16.14.2 V8: 10.2.154.23-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes
Actually seems like a generic webview issue
Fixed webview layout issue but now it seems like we also need a fix to the markdown extension
Actually not a bug. If you have two editors and side but side with a preview below , closing switches focus to the preview tab. However the preview stays for the content of This is now a duplicate of . To verify this issue: two editors and side by side a markdown preview below the entire group and confirm that the preview still shows its contents
Change:
. ~/.zshrc fi <ins> # Shell integration was disabled by the shell, exit without warning assuming either the shell has # explicitly disabled shell integration as it's incompatible or it implements the protocol. </ins> if [ -z "$VSCODE_SHELL_INTEGRATION" ]; then <del> echo -e "033[1;32mShell integration was disabled by the shell033[0m" </del> return fi

Discussion:
VSCode launch very slow (about 30-60 seconds) from the terminal (running ), but launches regularly from Spotlight (on Mac). Same long wait when running . Thanks! Code: 1.65.0 () OS: darwin(19.6.0) CPUs: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz(12 x 2600) Memory(System): 16.00 GB(1.67GB free) Memory(Process): NaN MB working set(179.85MB private, 0.16MB shared) VM(likelihood): 0% Initial Startup: true Has 0 other windows Screen Reader Active: false Empty Workspace: false
Closing - restarting the computer resolve the issue (still weird though..).
Change:
this.toDispose = []; this.showHoverScheduler = new RunOnceScheduler(() => this.showHover(this.hoverRange, false), HOVER_DELAY); this.hideHoverScheduler = new RunOnceScheduler(() => this.hoverWidget.hide(), HOVER_DELAY); <del> this.removeInlineValuesScheduler = new RunOnceScheduler(() => this.editor.removeDecorations(INLINE_VALUE_DECORATION_KEY), REMOVE_INLINE_VALUES_DELAY); </del> <ins> this.updateInlineValueDecorationsScheduler = new RunOnceScheduler( () => { this.wordToLineNumbersMap = null; this.updateInlineValueDecorations(this.debugService.getViewModel().focusedStackFrame); }, UPDATE_INLINE_VALUE_DECORATIONS_DELAY ); this.removeInlineValueDecorationsScheduler = new RunOnceScheduler( () => this.editor.removeDecorations(INLINE_VALUE_DECORATION_KEY), REMOVE_INLINE_VALUE_DECORATIONS_DELAY ); </ins> this.registerListeners(); this.breakpointWidgetVisible = CONTEXT_BREAKPOINT_WIDGET_VISIBLE.bindTo(contextKeyService); this.updateConfigurationWidgetVisibility();

Discussion:
Right now we expose an API to cells, and to webviews, but we don't publish types for this. The webview API is very simple, but the renderer will be somewhat more complex. We should consider either publishing these in or in a separate package.
This would be helpful for I think a or something would be a good place for it. Aside, it'd be cool if ts s could be contributed to... Right now we'd need a whole separate NPM scope to have separate I believe.
We can just PR a package called The naming of packages is only constrained by the maintainers' policy, and there are types that don't correspond to single packages, e.g.
Poor wording, I mean the project would need a different and for the client code vs the extension host code. (Or just know not call acquireApi outside of the client context of course. )
Oh, yea. In the sample renderer/code generator I'm using project references to keep things separated -- that also lets us use only in the renderer and output es6 modules (only) for webpack.
PR submitted

Bug Set "debug.inlineValues": true. Set breakpoint somewhere. After paused on the step, goto the end of the line and hit enter. Before After VS Code version: Code 1.20.0 (, 2018-02-07T17:02:34.244Z) OS version: Darwin x64 16.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ EditorConfig0.12.0 vscode-eslint1.4.5 vscode-great-icons2.1.24 auto-rename-tag0.0.15 code-beautifier1.7.2 vscode-scss0.6.2 mssql1.3.0 cpptools0.14.6 licenser1.1.1 (1 theme extensions excluded) </detailsReproduces only with extensions
I acknowledge the bug. This is just how decoartions are behaving, unfortunetly the inline decorations do not seem to have an option to not grow beyond the line. maybe you have an idea how to solve this? fyi in case you are interested into looking for a fix
debugger.inlineValues uses the editor's decorator api. A fix we can do is that if the editor is edited , then we re-sync the inlineValue decorators I'm not sure how this works but would love it if the bug was assigned to me so I can see it in my issues list
that's a good idea. can you please add to our project so we can assign some issues to him?
Change:
})); this._onModelChange(); <del> this._styleClassName = hash(this._editor.getId()).toString(16); </del> <ins> this._styleClassName = '_' + hash(this._editor.getId()).toString(16); </ins> this._styleElement = dom.createStyleSheet( dom.isInShadowDOM(this._editor.getContainerDomNode()) ? this._editor.getContainerDomNode()

Discussion:
In the , there is an issue when the class name for the codeLens span element gets generated on line 70. This hashing operation can on occasions result in a numerical character (0-9) being the first character in the class name. By CSS syntax rules, a CSS identifier is not allowed to start with a numerical value (without using the escaped character code sequence). This results in the codeLens not changing size to match the editor font size and can result in overlapping and mis-sized code lenses. Later on in line 94, we can see the class name get applied to a style sheet A simple fix would be to add an Underscore before the hashed editor id. Something like this: I was running into this issue in the monaco-editor by creating 10+ editors and noticed that after ~8 different editors, the code lens would not render correctly.
Nice find!