jiebi/CodeConvo huggingface dataset:
Change:
private disposables: Disposable[] = []; constructor(readonly repository: Repository) { <del> this._state = { HEAD: undefined, isCommitInProgress: false, isSyncInProgress: false, repositoryHasChanges: false }; </del> <ins> this._state = { HEAD: undefined, isCommitInProgress: false, isMergeInProgress: false, isSyncInProgress: false, repositoryHasChanges: false }; </ins> repository.onDidRunGitStatus(this.onDidRunGitStatus, this, this.disposables); repository.onDidChangeOperations(this.onDidChangeOperations, this, this.disposables);

Discussion:
a folder/workspace that contains a git repository a topic branch changes to main and the topic branch that would result in a merge conflict main into the topic branch to get a conflict Expected: commit action button is disabled Actual: commit action button is enabled
The button is now disabled while merging is in progress, but the button and the dropdown both take on a background color when clicked, which was confusing to me: !
Also, while the commit action button is disabled, the commit button above the input box is not: !
That is expected. At the moment the enablement is only toggled for the commit action button and not the commit action in the toolbar.
This is currently being tracked as
Change:
process.env['GTK_IM_MODULE_FILE'] = gtkIMModuleFile; process.env['GDK_BACKEND'] = gdkBackend; process.env['GIO_MODULE_DIR'] = gioModuleDir; <ins> process.env['GTK_EXE_PREFIX'] = gtkExePrefix; </ins> } moveItemToTrash(windowId: number | undefined, fullPath: string): Promise<void> {

Discussion:
Ubuntu 22.10, Gnome 43.1, fresh VM - The errors are not shown the second time I call and also VS Code seems to start and work I saw , but that should be in by now.
Change:
const editorViewState = this.cell.getSourceEditorViewState() as editorCommon.IDiffEditorViewState | null; if (editorViewState) { <del> console.log('restore view state', this.cell.modified.handle, editorViewState); </del> this._editor!.restoreViewState(editorViewState); }

Discussion:
a change to the file and save, do not commit the diff view from the SCM view up and down in the notebook diff view :cheese: see cell metadata area skittering on screen (the recording below does not capture how frequently the skittering actually happens) https://user-
Just ran into this again: https://user-
I opened for that, I think we can actually just reopen this one
This issue should be gone now since we fixed the horizontal bar issue.
Change:
}); } <del> async runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, arg: any) { </del> <ins> async runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any[]) { </ins> const languageService = accessor.get(ILanguageService); const snippetService = accessor.get(ISnippetsService);

Discussion:
Type: <bBug</bIf I bind a snippet like so: before the last update, it would insert the snippet when I press the shortcut, but now it brings up the Snippet Selector. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-19T05:21:29.044Z) OS version: Darwin arm64 21.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (24)</summaryExtensionVersion ------ vscode-apollo1.19.11 vscode-tailwindcss0.8.6 better-toml0.3.2 npm-intellisense1.4.2 vscode-eslint2.2.6 vscode-quick-select0.2.9 prettier-vscode9.5.0 auto-rename-tag0.1.10 shell-format7.2.2 bash-ide-vscode1.14.0 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.22.1 remote-ssh0.85. remote-ssh-edit0.80.0 vscode-typescript-next4.8. prisma4.0.0 vscode-yaml1.9.1 rust-analyzer0.4.1132 vs-code-prettier-eslint5.0.3 code-settings-sync3.4.3 shellcheck0.19.5 vscode-lldb1.7.2 vscode-import-cost3.3.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
verified using the parameter. didn't try with one by , but imagine it works the same way ?
Change:
this.selectEntry(keybinding); this.reportKeybindingAction(KEYBINDINGS_EDITOR_COMMAND_COPY, keybinding.keybindingItem.command, keybinding.keybindingItem.keybinding); const userFriendlyKeybinding: IUserFriendlyKeybinding = { <del> command: keybinding.keybindingItem.command, key: keybinding.keybindingItem.keybinding ? keybinding.keybindingItem.keybinding.getUserSettingsLabel() : '' </del> <ins> key: keybinding.keybindingItem.keybinding ? keybinding.keybindingItem.keybinding.getUserSettingsLabel() : '', command: keybinding.keybindingItem.command </ins> }; if (keybinding.keybindingItem.when) { userFriendlyKeybinding.when = keybinding.keybindingItem.when;

Discussion:
Default order in keybindings (default keybindings and intelliSense) is: ==When you copy from keybindings view and paste: ==
Change:
-ms-user-select: text; cursor: auto; } <ins> .output-plaintext, .output-stream { white-space: pre-wrap; } </ins> output-plaintext, .traceback { word-wrap: break-word;

Discussion:
Type: <bBug</bThere seems to be some issue with the Jupyter notebook output, recently the output is not formatted and there are no line breaks. ! VS Code version: Code - Insiders 1.75.0-insider (, 2023-01-06T05:21:40.528Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (31)</summaryExtensionVersion ------ path-intellisense2.8.4 gitignore0.9.0 python-preview0.0.4 githistory0.6.19 gitlens13.2.0 vandelay4.5.0 geniebuilder0.2.6 geniebuilder-insider0.2.6 gc-excelviewer4.2.56 h2o-wave0.24.2 RelativePath1.5.0 data-workspace-vscode0.3.0 mssql1.16.0 sql-bindings-vscode0.3.0 sql-database-projects-vscode0.19.0 isort2022.9. python2023.1. vscode-pylance2023.1.11 jupyter2023.1. jupyter-keymap1.0.0 jupyter-renderers1.0.12 vscode-jupyter-cell-tags0.1.6 vscode-jupyter-slideshow0.1.5 reload0.0.6 git-config-user-profiles1.2.0 vscode-workspace-switcher1.15.3 sourcery1.0.2 vscode-workspace-explorer1.5.0 vscodeintellicode-completions1.0.20 vscode-icons12.0.1 vscode-open-in-github1.3.6 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for the report, pushing a fix now!
Hi, is there an ETA for the patch? I am still seeing the same issue as in the same version and can confirm that the issue is present with other kernels as well. If it's any help, this is the current output from running ; it displays as in cell outputs (no line breaks).

I can get the expected output by manually changing the outputs to the following: Version: 1.75.0-insider (system setup) Commit: Date: 2023-01-06T05:21:40.528Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes
Change:
'target', 'title', 'width', <ins> 'start', </ins> ]; function getSanitizerOptions(options: { readonly isTrusted?: boolean | MarkdownStringTrustedOptions }): { config: dompurify.Config; allowedSchemes: string[] } {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Use Help Report Issue to prefill these. --- Extension version: v0.58.0 VSCode Version: 1.75.0 (system setup) OS: Windows_NT x64 10.0. Steps to Reproduce: a comment during a review with the contents "2." (as in: please do the second option among your suggestions) the comment in the extension and it will show "1." (probably because it is rendered as a markdown list) This small/simple issue would have lead to a huge misunderstanding if I would not have been suspicious of the answer and not checked the comment on the web UI.
can you share a screen shot of what you're describing?
Hey thanks for looking into this. Here are the screenshots you have requested. View within GitHub Web ! View within the Extension ! Hope it helps.
I looked at the markdown renderer options but I don't see a way to prevent this behavior. Does this seem like a bug in to you?
Change:
// update `list`s live, as they have a separate "submit edit" step built in before this (focusedSetting.parentElement && !focusedSetting.parentElement.classList.contains('setting-item-list')) ) { this.updateModifiedLabelForKey(key); this.scheduleRefresh(focusedSetting, key); return;

Discussion:
Regression from I haven't identified when the issue started happening again. Repro steps: to the Settings editor down on a checkbox or edit an inputbox on an unmodified setting, and wait for the setting to become modified, or click another nearby setting. :bug: The Settings editor settings tree jumps.
I noticed the following: Not rendering the Settings indicator labels does not fix the issue After a setting value changes, is called. Then, when is called during , the setting tree elements are all smushed together. That behaviour is even more dramatic when a setting has a multi-line description. calls , which sets the top of the DOM node to an incorrect value. It looks like the value that is used is an estimate. I believe this estimation process is what causes the settings tree elements to shift upwards and smush together.
Note, the jittering is on the right side, not the tree on the left. Regardless, this looks good to me. I could only repro in Stable on checkboxes, other types of settings didn't show the "jump".
Change:
export interface IOverrides<T> { contents: T; identifiers: string[]; <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
'null' is a valid value for a setting, but turns it into 'undefined'. have the following workspace settings:set a breakpoint in '' at the value is 'undefined' should indicate that the setting has not been set in the workspace (luckily it is not a valid configuration value as we only support valid JSON data types)
Same problem with the default and user value. It's always 'undefined' instead of 'null'. The bug is in
I created a PR with a
Change:
switch (theme.type) { case ColorScheme.LIGHT: return ApiThemeClassName.light; case ColorScheme.DARK: return ApiThemeClassName.dark; <del> default: return ApiThemeClassName.highContrast; </del> <ins> case ColorScheme.HIGH_CONTRAST_DARK: return ApiThemeClassName.highContrast; case ColorScheme.HIGH_CONTRAST_LIGHT: return ApiThemeClassName.highContrastLight; </ins> } } }

Discussion:
As discussed in , we should let webviews make decisions based on the high contrast theme type. Proposed by cc
How should this be verified?
I think this can be verified by checking the style of the body in a webview? Here's one in stable with high-contrast light theme enabled: ! Here's the same one in insiders with same theme enabled: ! It would allow CSS rules based on the body having that class.
So something like so?
/verified Yeah that works for me. I used the webview-view-sample.
Yeah, in the webview ui toolkit so, hopefully, the vscode-high-contrast-light theme would be reflected there as well.
Which actually now that I look at screenshots more closely, it already is being reflected on the attribute
Also confirmed this works when working on a fix for the webview toolkit last week
Change:
import { IStoredWorkspace } from 'vs/platform/workspaces/common/workspaces'; import { UserDataProfileInitializer } from 'vs/workbench/services/userDataProfile/browser/userDataProfileInit'; import { UserDataSyncInitializer } from 'vs/workbench/services/userDataSync/browser/userDataSyncInit'; <ins> import { BufferLogger } from 'vs/platform/log/common/bufferLog'; import { FileLoggerService } from 'vs/platform/log/common/fileLog'; </ins> export class BrowserMain extends Disposable {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the "Developer: Set Log Level..." command and set it to "Trace" there's no "Telemetry" channel there, only Extension Telemetry: !
Do you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.
Where do you register Telemetry logger in codespaces, is it in server or on client side?
It's registered client side.
May I know where it is registered in sources?
Can you please check if this code is being executed in the codespace?
It seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.
Can you please provide me steps to enable this locally from sources?
Sent instructions offline
Still not seeing the telemetry output channel in Codespaces (on desktop if it matters)
Actually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.
Change:
private async updateIssueReporterUri(extension: IssueReporterExtensionData): Promise<void> { try { if (extension.command?.uri) { <del> extension.bugsUrl = extension.command.uri; </del> <ins> const uri = URI.revive(extension.command.uri); extension.bugsUrl = uri.toString(); </ins> } else { const uri = await this.issueMainService.$getIssueReporterUri(extension.id); extension.bugsUrl = uri.toString(true);

Discussion:
Testing It seems weird to pass in string when you could just pass in a Uri. Better yet, consider
I think when I was testing, URI wasn't serializable so it wouldn't be passed thru the command properly - will double check this soon though
you may need to turn it into a and then that on the other end. It's possible. We do it with other processes.
Change:
onConfigListener(updateIndexGroupVisibility, this, this.disposables); updateIndexGroupVisibility(); <ins> const onConfigListenerForBranchSortOrder = filterEvent(workspace.onDidChangeConfiguration, e => e.affectsConfiguration('git.sortOrderForBranch', root)); onConfigListenerForBranchSortOrder(this.updateModelState, this, this.disposables); </ins> this.mergeGroup.hideWhenEmpty = true; this.disposables.push(this.mergeGroup);

Discussion:
I agree that sometimes it is more useful to but I often feel that it makes it hard to find branches when a naming scheme like "user/feature" is used and I want to quickly find all branches of a user. Even without that scheme there are good reasons why having an alphabetical sort option makes sense, if only for personal preference. To avoid a religious discussion, could the sort order be made into a config option?
, working on this :)
Change:
return result; } <del> export class LazyCallStackEditorContribution extends Disposable { constructor(editor: ICodeEditor, @IInstantiationService instantiationService: IInstantiationService) { super(); const listener = editor.onDidChangeModel(() => { if (editor.hasModel()) { listener.dispose(); this._register(instantiationService.createInstance(CallStackEditorContribution, editor)); } }); } } class CallStackEditorContribution extends Disposable implements IEditorContribution { </del> <ins> export class CallStackEditorContribution extends Disposable implements IEditorContribution { </ins> private decorations = this.editor.createDecorationsCollection(); constructor(

Discussion:
With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:
Replacing me with who took over quick pick.
Change:
goToFocused(): void; findScrollWidgetState(): StickyScrollWidgetState; dispose(): void; <ins> selectEditor(): void; </ins> } export class StickyScrollController extends Disposable implements IEditorContribution, IStickyScrollController {

Discussion:
Testing around an open file in the editor with Stick Scroll enabled. Sticky Scroll Try to move focus out of Sticky Scroll. Tried pressing . Tried running "Focus Sticky Scroll" command a second time. Only way to get focus back to the editor is to select a level and press . I think should put you back into the editor
Change:
Name=@@NAME_LONG@@ Comment=Code Editing. Redefined. GenericName=Text Editor <del> Exec=/usr/bin/@@NAME@@ %U </del> <ins> Exec=/usr/share/@@NAME@@/@@NAME@@ %U </ins> Icon=@@NAME@@ Type=Application StartupNotify=true <del> StartupWMClass=@@NAME@@ </del> <ins> StartupWMClass=@@NAME_SHORT@@ </ins> Categories=Utility;TextEditor;Development;IDE; MimeType=text/plain; Actions=new-window;

Discussion:
Testing Open the integrated terminal Change the setting Observe: setting is not applied until a restart of VSCode

I've seen this a few times: ! It seems to disappear after a while, maybe it's to do with .local desktop entry or bin command running instead of real command?

Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?
Thinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.
Marked as candidate as it's a very simple change that's been reported a bunch of times.
Cherry picked to release/1.2
Change:
import { ICommandService } from 'vs/platform/commands/common/commands'; import { NEW_UNTITLED_FILE_COMMAND_ID } from 'vs/workbench/contrib/files/browser/fileConstants'; import { ModesHoverController } from 'vs/editor/contrib/hover/browser/hover'; <del> import { withNullAsUndefined } from 'vs/base/common/types'; </del> <ins> import { IContextViewService } from 'vs/platform/contextview/browser/contextView'; </ins> import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; registerAccessibilityConfiguration();

Discussion:
Testing GitHub Pull Request extension. Open GitHub view on the side. Hover over an issue, and put focus in it F2 to open Accessibility View. Nothing happens I could not get the Accessibility View to work with any hover. What am I missing here?
Hm, any errors in the dev tools console?
Yeah they're not working in the scm view for me
This still does not work for me for the GitHub issues view. can you reproduce with the GitHub issues view? You should just install the GH PR extension and you should get the issues view and you can try out this there. Thanks
Here's what I see in the GH PR view - I'll try issues
it's also working for me in the github issues view - I'm using the keyboard shortcut of . are you? also works for me if I hover and click.
Works now. I was doing something wrong. Thank you. Adding verified.
Change:
// Distance 1: Swap Editors if (Math.abs(from - to) === 1) { <del> // Move editors to new position let editorPos1 = this.visibleEditors[from]; editorPos1.getContainer().offDOM().build(this.silos[to].child()); editorPos1.changePosition(to); </del> <ins> // Move containers to new position const containerFrom = this.silos[from].child(); containerFrom.appendTo(this.silos[to]); const containerTo = this.silos[to].child(); containerTo.appendTo(this.silos[from]); </ins> <del> let editorPos2 = this.visibleEditors[to]; editorPos2.getContainer().offDOM().build(this.silos[from].child()); editorPos2.changePosition(from); </del> <ins> // Inform Editors this.visibleEditors[from].changePosition(to); this.visibleEditors[to].changePosition(from); </ins> // Update last active position accordingly if (this.lastActivePosition === from) {

Discussion:
For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.
I merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !
I can verify
LGTM - will push the revert revert commit
Verified via
Change:
.monaco-workbench .part > .title > .title-actions .start-debug-action-item .codicon { line-height: inherit; <del> outline-offset: 0px; </del> flex-shrink: 0; transition: transform 50ms ease; } <del> .monaco-workbench .monaco-action-bar .start-debug-action-item .configuration.select-container { margin-left: 1px; } </del> .monaco-workbench .monaco-action-bar .start-debug-action-item .configuration .monaco-select-box { border: none; margin-top: 0px; cursor: pointer; <del> font-size: inherit; </del> line-height: inherit; <del> outline-offset: 0px; </del> } .monaco-workbench .monaco-action-bar .start-debug-action-item .configuration.disabled .monaco-select-box {

Discussion:
I played around with to set the background color of the dropdown widget. It works fine in the panel area but e.g. not for the debug dropdown. That makes me wonder if we possibly have code in debug land that overrides this because the debug view is in the side bar. That is probably not a good idea given you can move views around. !
Same for remote explorer, so it is maybe more generic: ! //cc
You are correct we use the sidebar_background for the debug I thought the issue is that we also have a green play button which is part of this and we did not want to custmoise it becuase the Green play might not look good on the customised background. As for the remote explorer I have no clue.
I think the remote one is covered via
That one was probably a copy paste mistake from debug land :)
last milestone and I saw this differentiation and assumed it was intentional that all sidebar dropdowns do not honor the theme color. this meant that if you drag terminal or output to the sidebar (in their own viewlet), they will also skip using the theme color for dropdown
I am opening this for a PR. Code pointer The debug select box should listen to style changes and also style the background of the Green Play button.
Adding lable bug so we get this verified.