jiebi/CodeConvo huggingface dataset:
Change:
DOM.hide(this.templateData.runButtonContainer); DOM.show(this.templateData.collapsedPart); DOM.hide(this.templateData.outputContainer); <del> this.templateData.container.classList.toggle('collapsed', true); </del> this.templateData.container.classList.toggle('output-collapsed', true); this._outputContainerRenderer.viewUpdateHideOuputs(); <del> this.updateInputCollaseElement(); </del> <ins> this.updateInputCollapseElement(); </ins> this.relayoutCell(); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59-Insider OS Version: Windows 10 Steps to Reproduce: a notebook a cell cells are rotated 270 degrees. Seems to be because we use the 'collapsed' classname for cell collapse, and loads a stylesheet which applies to the classname. This stylesheet is not loaded in desktop VS Code so the problem seems to only impact Codespaces This is particularly unfortunate for the interactive window because all code cell inputs are collapsed by default, but it also impacts any collapsed cell in native notebooks all up. !
I filed this a long time ago, but this is pretty bad, I will just change the styles to work around it in the meantime
fix proposal from
Change:
expiration: None, subjects: vec![], scopes: vec![TUNNEL_ACCESS_SCOPES_CONNECT.to_string()], <del> }); </del> <ins> }, // Ensure private ports are actually private and do not inherit any // default visibility that may be set on the tunnel: PortPrivacy::Private => tunnels::contracts::TunnelAccessControlEntry { kind: tunnels::contracts::TunnelAccessControlEntryType::Anonymous, provider: None, is_inherited: false, is_deny: true, is_inverse: false, organization: None, expiration: None, subjects: vec![], scopes: vec![TUNNEL_ACCESS_SCOPES_CONNECT.to_string()], }, }], </ins> } <del> acl </del> } #[cfg(test)]

Discussion:
Testing It shows the error's message, but doesn't make explicit that there was an error thrown. ! This is from:
Change:
if (profilesChanged || contributedProfilesChanged) { this._availableProfiles = profiles; this._onDidChangeAvailableProfiles.fire(this._availableProfiles); <del> this._profilesReadyBarrier.open(); </del> <ins> this._profilesReadyBarrier!.open(); </ins> this._updateWebContextKey(); await this._refreshPlatformConfig(this._availableProfiles); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 OS Version: Mac OS 13.3.1 Steps to Reproduce: a new VSCode window using Codespaces. initial terminal window opens a terminal. If I kill that terminal and open a new terminal, I get as expected. I have in my I believe this is a duplicate of these closed issues:
I was expecting this would get fixed as part of , cc
It got , but it only repros using codespaces extension now, before I was able to repro with test resovler extension and remote ssh extension which works as expected now, not sure what's special about codespaces extension as the remote connection logic is the same :thinking:
Ah I can repro now, will take a look, it's because codespaces takes 20s to resolve the remote Edit: There's a :laughing:
PR
/duplicate
Change:
const line = this._getTargetScrollLine(this._terminal, marker, position); this._terminal.scrollToLine(line); } <ins> this._navigationDecoration?.dispose(); const decoration = this._terminal.registerDecoration({ marker, width: this._terminal.cols }); this._navigationDecoration = decoration; if (decoration) { let isRendered = false; decoration.onRender(element => { if (!isRendered) { // TODO: Remove when https://github.com/xtermjs/xterm.js/issues/3686 is fixed if (!element.classList.contains('xterm-decoration-overview-ruler')) { element.classList.add('terminal-scroll-highlight'); } } }); decoration.onDispose(() => { if (decoration === this._navigationDecoration) { this._navigationDecoration = undefined; } }); // Number picked to align with symbol highlight in the editor timeout(350).then(() => { decoration.dispose(); }); } </ins> } private _getTargetScrollLine(terminal: Terminal, marker: IMarker, position: ScrollPosition) {

Discussion:
Follow up for cmd+up/down on macOS should show some indication of the line that was scrolled to. This will need some upstream changes.
testing if i have a few empty lines such as this: ! pressing appears to do nothing, so having some indication of where I am would be great.
yeah I would have liked to get this in but was a bit randomized this iteration.
Blocked on
Brought this to UX sync with a focus border outline that fades to 0 opacity over 2 seconds. But after it occurred to me that navigating the a symbol in the editor is the exact idea we're trying to get across which flashes a focus border briefly without animating. So going with that to align, we can change both if we want to tweak it: !
Using 350ms:
!
Change:
const modelService = accessor.get(IModelService); const quickInputService = accessor.get(IQuickInputService); const languageDetectionService = accessor.get(ILanguageDetectionService); <ins> const kernelService = accessor.get(INotebookKernelService); let languages = context.notebookEditor.activeKernel?.supportedLanguages; if (!languages) { const matchResult = kernelService.getMatchingKernel(context.notebookEditor.textModel); const allSupportedLanguages = matchResult.all.flatMap(kernel => kernel.supportedLanguages); languages = allSupportedLanguages.length > 0 ? allSupportedLanguages : languageService.getRegisteredLanguageIds(); } </ins> const providerLanguages = new Set([ <del> ...(context.notebookEditor.activeKernel?.supportedLanguages ?? languageService.getRegisteredLanguageIds()), </del> <ins> ...languages, </ins> 'markdown' ]);

Discussion:
Had a quick chat with on the new built-in getting started flow for notebooks. When starting off with a new notebook the user will have the ability to either change kernel or change the language. If they decide to change the language first, a drop down list with all supported languages appears. ! However, a user may not have the required kernels to use certain languages and may lead to confusion when they cannot use one they have selected. We were thinking it would be good to limit the languages in the list to just those that would be supported based on the kernels on a user's machine/extensions installed that provide kernels. We do something similar with the kernel selector today - If user selects a kernel, we only show the languages supported by the kernel. Below is example if user selects .NET kernel. ! The idea is to have a "global" version of the above experience.
I implemented this, but in reality I think that we almost always auto-select a kernel now. And also, the list is still pretty long since so many languages can be supported in Jupyter.
Change:
} export const enum VSCodeOscProperty { <del> Task = 'Task' </del> <ins> Task = 'Task', Cwd = 'Cwd' </ins> } /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: Windows 10 Steps to Reproduce: file structure like this: ! a task like this: the task and you can see the output. Press ctrl+click the file path. It should jump to the "test.c" file. But actually, I need to choose which file should be opened. ! I think VSCode should open the file according to the file path in the output. or report error if the file dosen't exist.
After testing, 1.68 worked. But 1.69 and 1.70 don't work anymore.
I have same problem in 1.69
Hi, Any progress? Do you have a plan to fix it? Which version can this issue be fixed? Some extensions need the latest VSCode, but can not jump by clicking the output error is very inconvenient.
I believe this is fixed in , let me know if not
This issue still exists in 1.72.2.
It will jump to the file and line if I click the output in terminal. Like this: ! But it will ask me to choose the file if I click the output of tasks.
Hi, any progress?
Hi It still can not jump by ctrl+click the output of tasks. Can you reproduce following my step?
Hi still can reproduce on 1.73.1.
please stop pinging, it got reopened. This is one issue among hundreds assigned to me.
Note to self: Do task terminals assume the cwd is the workspace root, not the actually cwd?

It's happening because the task doesn't have shell integration's cwd coming through, as such it can't ensure it's folder is the starting cwd and falls back to search links. ! Maybe tasks should have their cwd fixed for link resolution, the only downside of this is if the task changes the cwd during execution in which case the link would be off. That seems like a minor edge case though.
I can click on the file link to open it in the editor, but the shell output that I get in pwsh is different from the output in the original report which seems to be bash or similar--for pwsh the parentheses seem to be getting stripped and the is on a newline. Is that expected? <img width="514" alt="image" src="https://user-"
does this one work? <img width="177" alt="image" src="https://user-"Outputting onto a different line is just something related to the shell which won't impact link detection.
yeah that one works, just wanted to make sure that the newlines weren't a behavior change <img width="522" alt="image" src="https://user-"
Change:
} else { this.storageService.remove(FILTER_HISTORY_STORAGE_KEY, StorageScope.WORKSPACE); } <ins> const filterValue = this.filterState.filterText; if (filterValue) { this.storageService.store(FILTER_VALUE_STORAGE_KEY, filterValue, StorageScope.WORKSPACE, StorageTarget.USER); } else { this.storageService.remove(FILTER_VALUE_STORAGE_KEY, StorageScope.WORKSPACE); } </ins> } super.saveState();

Discussion:
I frequently use the debug console in VS Code to get output from my application but it's often cluttered with various log messages from services that I cannot control. These unwanted entries are easily filtered in the text field "Filter (e.g. text, !exclude)" box. I would like a setting to configure this default filter text per workspace. Currently I have to manually configure this filter each time I start VS Code. I could not find this in either default settings or through an extension.
This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks I would actually prefer if we would just preserve the filter across vscode reloads. I am open to Pull Requests that solve this. Code pointer
Great. I would be fine with it being preserved through reloads
Created PR fixing this
thanks a lot for that I have commented on the PR.
I am trying to verify this feature right now, but it isn't persisting upon reload on my side (running off of latest commit on main). Steps: extension filter to debug console debugging command palette to reload console's filter is empty again. Is my flow correct?
thanks for trying to verify this. However this fix is not yet released. Sorry for not specifying. Though we have this label that should help with that. So I will close this issue, and it would be great if you can try it out again tomorrow. Thank you!
Change:
@INotebookExecutionService private readonly notebookExecutionService: INotebookExecutionService, @INotebookExecutionStateService notebookExecutionStateService: INotebookExecutionStateService, @IEditorProgressService private readonly editorProgressService: IEditorProgressService, <del> @IWorkbenchLayoutService private readonly workbenchLayoutService: IWorkbenchLayoutService, </del> ) { super(); this.isEmbedded = creationOptions.isEmbedded ?? false;

Discussion:
<img width="726" alt="image" src="https://user-"
zindex ftw
Actually not zindex, it was introduced via is the necessary here and could we not enforce that for notebook editor? When we have clip, the widgets in code editor will be cut off on the boundries.
We do need the clip to for notebooks. Otherwise when you scroll the editor area, the notebook widget will render on top of the sidebars Not sure how the fix this though. We've want to clip everything except the editor widgets. Off the top of my head I'm not sure how to do that I think for now we should revert the clip since it's less important than widgets rendering properly. I'll create a PR that does that but also open a new issue tracking the notebook's overlaying incorrectly when the editor area is scrolled
Change:
title: locations.length === 1 ? localize('oneImplementationLabel', '1 implementation') : localize('manyImplementationLabel', '{0} implementations', locations.length), <del> command: 'editor.action.showReferences', </del> <ins> command: locations.length ? 'editor.action.showReferences' : '', </ins> arguments: [codeLens.document, codeLens.range.start, locations] }; return codeLens;

Discussion:
Testing in this setup Get this Code lense with '0 References' in ! Clicking the references link just shows an empty peek, it is not clear what is being search for. !
Now I understand what is going on: ! The reference in the template isn't found by the Angular Language Service extension.
Do you suggest we don't show the peek view from zero references code lens? Or should the peek view have more info on what would normally be displayed?
since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.
Change:
import { onUnexpectedError } from 'vs/base/common/errors'; import { Emitter, Event } from 'vs/base/common/event'; import { KeyCode } from 'vs/base/common/keyCodes'; <del> import { Disposable, DisposableStore, dispose } from 'vs/base/common/lifecycle'; </del> <ins> import { Disposable, DisposableStore, dispose, toDisposable } from 'vs/base/common/lifecycle'; </ins> import { isIOS } from 'vs/base/common/platform'; import { escapeRegExpCharacters } from 'vs/base/common/strings'; import { isArray, isDefined, isUndefinedOrNull } from 'vs/base/common/types';

Discussion:
On Linux: the settings editor type out "cellToolbarLocation" way through, when the setting comes up, focus is stolen by the "item" in the table !
Yikes. I wonder if you could look at this
I'm unable to repro this on both Windows and Mac. It takes me a double-click to manually change the first row of that setting into edit mode, after it shows up. Do we have any OS-specific code for the settings editor If not, I wonder if this might be an Electron issue.
I did not repro on Windows either, only in Linux
I can on mac, if I have multiple rows on the setting. Or maybe I had to interact with the setting in that editor previously. I can't remember whether there is some code on the list setting widget that tries to restore focus after a change. I just called you out because I thought you might have seen that recently
Ok, reproduced the issue on Mac but not Windows with your hint there: -click the first item in the cell toolbar location setting to get it into edit mode. of pressing the OK or Cancel button, close the setting editor. the setting editor again, and slowly type . :bug: The setting shows up with the first item in edit mode, and that seems to steal focus away.
In , there are some areas where gets called. I think a solution to this approach would be to call whenever the user focuses back onto the main search bar, or if the settings editor tab is closed. Otherwise, on all OSes, when the user focuses back onto the search bar, and tries to search a new setting, the focus is stolen back to the item in edit mode.
Change:
this._coordinatedRenderings.splice(renderingIndex, 1); if (this._coordinatedRenderings.length === 0) { <del> // There are no more renderings to coordinate => cancel animation frame if (this._animationFrameRunner !== null) { this._animationFrameRunner.dispose(); this._animationFrameRunner = null; </del> <ins> // There are no more renderings to coordinate => cancel animation frames for (const [_, disposable] of this._animationFrameRunners) { disposable.dispose(); </ins> } <ins> this._animationFrameRunners.clear(); </ins> } } }; } private _scheduleRender(window: CodeWindow): void { <del> if (this._animationFrameRunner === null) { </del> <ins> if (!this._animationFrameRunners.has(window)) { </ins> const runner = () => { <del> this._animationFrameRunner = null; </del> <ins> this._animationFrameRunners.delete(window); </ins> this._onRenderScheduled(); }; <del> this._animationFrameRunner = dom.runAtThisOrScheduleAtNextAnimationFrame(window, runner, 100); </del> <ins> this._animationFrameRunners.set(window, dom.runAtThisOrScheduleAtNextAnimationFrame(window, runner, 100)); </ins> } }

Discussion:
Repro: an editor to a new window (or as many as you want) the original window that still contains the editor that all windows with the copied editor have input lag ! Version: 1.85.0-insider (user setup) Commit: Date: 2023-12-01T19:00:37.339Z Electron: 25.9.6 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0.
A regression from
Change:
assert.strictEqual(Math.round(secondResponse.value), 100); }); <del> test('webviews with retainContextWhenHidden should be able to recive messages while hidden', async () => { </del> <ins> test('webviews with retainContextWhenHidden should be able to receive messages while hidden', async () => { </ins> const webview = _register(vscode.window.createWebviewPanel(webviewId, 'title', { viewColumn: vscode.ViewColumn.One }, { enableScripts: true, retainContextWhenHidden: true })); const ready = getMesssage(webview);

Discussion:
Couple of milestones ago I have skipped these tests becuase they were failing. I am not sure if I created the issue at the moment but I am doing that now. Sorry if I did not ping sooner. Code pointer
I had to revert this change: I think they cause our browser integration tests to hang/fail:
Change:
document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken <del> ): Promise<vscode.Range | null> { </del> <ins> ): Promise<vscode.Range | undefined> { </ins> if (this.client.apiVersion.lt(API.v310)) { <del> return null; </del> <ins> return undefined; </ins> } const response = await this.execRename(document, position, token); <del> if (response?.type !== 'response' || !response.body) { return null; </del> <ins> if (!response) { return undefined; </ins> } <del> const renameInfo = response.body.info; if (!renameInfo.canRename) { return Promise.reject<vscode.Range>(renameInfo.localizedErrorMessage); </del> <ins> switch (response.type) { case 'rename': { const renameInfo = response.body.info; if (!renameInfo.canRename) { return Promise.reject<vscode.Range>(renameInfo.localizedErrorMessage); } return typeConverters.Range.fromTextSpan(renameInfo.triggerSpan); } case 'jsxLinkedEditing': { return response.spans .map(typeConverters.Range.fromTextSpan) .find(range => range.contains(position)); } </ins> } <del> return typeConverters.Range.fromTextSpan(renameInfo.triggerSpan); </del> } public async provideRenameEdits(

Discussion:
!
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Why has this been marked out of scope? This is a feature that was .
facing the same
Same problem here. This IS crucial for big projects.
To verify: renames should rename matching tags now. Test on both html tag names () and custom components () you change , then renaming custom components should instead renaming all references to that component
Change:
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideDetails .gettingStartedDetailsContent.image>.getting-started-media { grid-area: title-start / media-start / steps-end / media-end; align-self: unset; <ins> display: flex; justify-content: center; </ins> } .monaco-workbench .part.editor>.content .gettingStartedContainer.width-semi-constrained .gettingStartedSlideDetails .gettingStartedDetailsContent.image>.getting-started-media {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 OS Version:MacOS Big Sur Steps to Reproduce: the in repo and Run on any step that shows a PNG image, like ! the image is vertically aligned on Top on the step ! the image is vertically aligned on Center I know SVGs are better alternatives, and its support were to allow themes (), but even PNG images should be properly aligned. Thank you