jiebi/CodeConvo huggingface dataset:
Change:
padding-left: 1px; } <del> .monaco-editor .comment-range-glyph.comment-thread { </del> <ins> .monaco-editor .comment-range-glyph.comment-thread, .monaco-editor .comment-range-glyph.comment-thread-unresolved { </ins> z-index: 20; } <del> .monaco-editor .comment-range-glyph.comment-thread:before { content: "ea6b"; </del> <ins> .monaco-editor .comment-range-glyph.comment-thread:before, .monaco-editor .comment-range-glyph.comment-thread-unresolved:before { </ins> font-family: "codicon"; font-size: 13px; width: 18px !important;

Discussion:
Comments in the editor have a different color based on their resolved status. We could do something similar for the icon in the gutter, and make obvious which comment is resolved even when comments are folded. Maybe change the icon color? Or use a different icon? (also related to )
Example of how it currently looks: ! Example with adjusted colours: ! Note that colour alone is not a full solution since it is not that accessible, but I think it should be included in the final solution.
A different icon/unicode character for resolved would be good here.
Let's get done first.
Change:
*--------------------------------------------------------------------------------------------*/ import * as strings from 'vs/base/common/strings'; <ins> import { CursorColumns } from 'vs/editor/common/core/cursorColumns'; </ins> function _normalizeIndentationFromWhitespace(str: string, indentSize: number, insertSpaces: boolean): string { let spacesCnt = 0; for (let i = 0; i < str.length; i++) { if (str.charAt(i) === 't') { <del> spacesCnt += indentSize; </del> <ins> spacesCnt = CursorColumns.nextIndentTabStop(spacesCnt, indentSize); </ins> } else { spacesCnt++; }

Discussion:
Issue Type: <bBug</bPlease look this, ! Line 2: "Text" Line 3: .... This is auto indent line. ? (:, : ) ABC
I update this issue. But, It is automaticaly closed. Why? Please look this updated isuue.
What are the steps to reproduce? What is happening versus what you would expect to happen?
First line is, ( is white space, is Tab code) "Text" + -key Actual input is: (The above procedure removes the white space.) [Tab]-key, "Text", (move coursor position to the beginning of line), [Space][Space], (move coursor position to end of line), [Enter] The next cursor position is invalid. Please look the image of issue. I think, this is not serious but incorrect behavior.
Thank you for the extra information. Here are simplified steps: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain if indentation is configured with spaces, the new line will contain
Thanks.
can we have some verification steps?
Posting again with more explanations: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain . <---- this is a bug, the result should be such that the second line aligns with the first line if indentation is configured with spaces, the new line will contain <--- this is a bug, the result should be such that the second line aligns with the first line
Change:
import { NEW_UNTITLED_FILE_COMMAND_ID } from 'vs/workbench/contrib/files/browser/fileConstants'; import { ModesHoverController } from 'vs/editor/contrib/hover/browser/hover'; import { withNullAsUndefined } from 'vs/base/common/types'; <ins> import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; </ins> registerAccessibilityConfiguration(); registerSingleton(IAccessibleViewService, AccessibleViewService, InstantiationType.Delayed);

Discussion:
Running the open accessible view command doesn't do anything for me. It doesn't work regardless of whether screen reader mode is on Version: 1.80.0-insider (user setup) Commit: Date: 2023-06-28T08:01:04.380Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.
It won't do anything unless you have a hover or a chat response focused
what is focused when you tried?
That was with focus in terminal, editor and sidebar. I tried just now with the terminal focused (chat visible) and it showed some very unexpected text: !
With focus in a hover or chat response, it should show. Otherwise, it shouldn't.
this one doesn't seem too critical so could move to July?
Well, it could be disorienting for SR users if it's showing content unexpectedly. But yeah probably risky at this point
actual fix will be in the linked PR, but a related issue will need to be resolved before this works fully
Works generally now, I found this edge case though
Change:
const prefix = matchesPrefix(word, labelStr); const fuzzy = matchesFuzzy2(word, labelStr); <del> // ensures that when fuzzy matching, it doesn't clash with prefix matching (1 input vs 1+ should be prefix and fuzzy respecitvely) const fuzzyScore = fuzzy ? fuzzy[0].end - fuzzy[0].start : 0; if (prefix || fuzzyScore > 1) { this.previouslyFocused = start; this.list.setFocus([index]); this.list.reveal(index); return; </del> <ins> if (fuzzy) { const fuzzyScore = fuzzy[0].end - fuzzy[0].start; // ensures that when fuzzy matching, doesn't clash with prefix matching (1 input vs 1+ should be prefix and fuzzy respecitvely). Also makes sure that exact matches are prioritized. if (prefix || (fuzzyScore > 1 && fuzzy.length === 1)) { this.previouslyFocused = start; this.list.setFocus([index]); this.list.reveal(index); return; } </ins> } } } else {

Discussion:
Testing Searching for always takes to the action with term
Strange. I believe it's an issue with how fuzzy matching is giving the score and since both have f, i, l, e, in it so it might be getting confused. Good catch thank you.
Change:
private _generateTabId(editor: EditorInput, groupId: number) { let resourceString: string | undefined; // Properly get the resource and account for side by side editors <del> const resource = EditorResourceAccessor.getOriginalUri(editor, { supportSideBySide: SideBySideEditor.BOTH }); </del> <ins> const resource = EditorResourceAccessor.getCanonicalUri(editor, { supportSideBySide: SideBySideEditor.BOTH }); </ins> if (resource instanceof URI) { resourceString = resource.toString(); } else {

Discussion:
For me on macOS: open a folder with 1 file right click rename to =console prints
This is interesting, the reason this is happening is because the label change doesn't trigger and open and close if it's the same URI with different casing, but our IDs are case sensitive so when we go to look up this tab to update it's label we go "hey we can't find it, it must not exist". Is there a case insensitive version of the URI that I should be using? Right now I use
Ah, canonical URIs is what I want. A bit weird that uppercase to lowercase triggers a label change, but not the other way around
Change:
} })); <del> this.delayRecomputeActive(); </del> <ins> this._recomputeActive(); </ins> } private _recomputeActive(): { changeEventTriggered: boolean } {

Discussion:
Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro
a notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese
!
Thanks I can replicate this issue.
Giving the issue back to Aaron to verify. My Python install's a bit broken.

Testing open show outline and have sticky scroll enabled scroll the cell with "# Header " into view delete the cell :bug: the sticky scroll breaks, the error below is printed <img width="1482" alt="Screenshot 2024-04-23 at 08 51 18" src=""
I'm unable to repro this. Please can you share a screen recording of the steps. Perhaps recoding from opehning the notebook to selecting and deleting. Thanks.
Looking at the stacktrace tells me this is coming here which means the model had been already
following the steps above (empty profile) always reproduce the error (console) for me. The screen cheese shows in sticky scroll and/or other paces of the outline tree
Change:
} }); } <del> for (const commandSelector of this._terminalContributionService.quickFixes) { this.registerCommandSelector(commandSelector); } </del> this._quickFixService.onDidRegisterProvider(result => this.registerCommandFinishedListener(convertToQuickFixOptions(result))); this._quickFixService.onDidUnregisterProvider(id => this._commandListeners.delete(id)); }

Discussion:
Running out of sources I see this:
This means that the contribution isn't getting evaluated before is called. Not too familiar with how / when is handled, but we call when the is created
I think perhaps moving that to the top of the constructor (before registering the command handlers) will fix this
This happens on window open
and the quick fix does work for that extension !
Seeing this in error telemetry for Insiders from 12/23:
This is the 6th error by machines in telemetry https://vscode-
I cannot reproduce this in Insider's. did you notice this after doing anything in particular?
I got this error when using remote dev container <details<summaryWindow</summary</details
Fixed in
Actually still found it in my devtools today:
I can't reproduce, but I can simulate the race by adding to 's promise in
HI, im having the same problem here 2023-02-16 17:10:14.453 [error] Error: No registered selector for ID: ms- at R.registerQuickFixProvider (vscode-file://vscode-) at r.$registerQuickFixProvider (vscode-file://vscode-) at m.N (vscode-file://vscode-) at m.M (vscode-file://vscode-) at m.H (vscode-file://vscode-) at m.G (vscode-file://vscode-) at vscode-file://vscode- at g.invoke (vscode-file://vscode-) at n.deliver (vscode-file://vscode-) at a.fire (vscode-file://vscode-) at r.fire (vscode-file://vscode-) at Z.onmessage (vscode-file://vscode-) I got vs code 1.71.1 running on W11 21H2 How i am supposed to fix this, or it's not a problem and vs code is working normally? Thank you!
Update your VS code version, where this is fixed
Sorry, i typed incorrectly mi vs code version. It is the latest one 1.75.1, i reinstalled it today.
I can still reproduce in latest stabel 1.75.1 https://user-
Change:
if (!this.current || !equalsSubject(this.current, opts.subject)) { this.current = opts.subject; <del> await Promise.all(this.contentProviders.map(p => p.update(opts.subject))); </del> <ins> await this.contentProvidersUpdateLimiter.queue(() => Promise.all( this.contentProviders.map(p => p.update(opts.subject)))); </ins> } }

Discussion:
Type: Bug Version: 1.81.0 Commit: Date: 2023-08-02T12:36:11.334Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 5.15.0-76-generic Steps to Reproduce: the "Test Results" Panel command "Test: Run Tests in Current File" very quickly for several times "Test Results" Panel now displays two terminals, with the top one acting like phantom, and the bottom one displaying the real messages. After some investigation, I found the culprit to be that is not concurrently safe. Under certain cases, multiple calls to may happen concurrently within a short time period, which further leads to concurrent calls to , in which multiple instances of terminal are created and attached to the panel. This bug was largely improved by commit introduced by , which changed into This change reduces the possibility of concurrently calling to some extent and thus this bug may be harder to reproduce in the latest main branch. That being said, there's still a chance for this to happen. To thoroughly eliminate the risk, I fix it in PR .
Change:
if (index === -1) { index = 0; } <ins> if (this.model.state === State.Idle) { // selecting an item can "pump" out selection/cursor change events // which can cancel suggest halfway through this function. therefore // we need to check again and bail if the session has been canceled return; } </ins> let noFocus = false; if (e.triggerOptions.auto) { // don't "focus" item when configured to do

Discussion:
Type: <bBug</ba funtion name in fileA. the the fileA variable and use "." operator for suggention then paste the copied funtion name. Expected: the suggestion should disapper when I click enter. Actual: it's not disappearing. I have to close the tab and reopen the file. VS Code version: Code 1.83.0 (, 2023-10-03T16:12:16.321Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ project-manager12.7.0 cucumberautocomplete2.15.2 aws-toolkit-vscode1.93.0 folder-source-actions0.2.1 gitignore0.9.0 vscode-deno3.26.0 git-extension-pack0.1.3 githistory0.6.20 gitlens14.3.0 vscode-great-icons2.1.102 vsc-material-theme33.10.5 vsc-material-theme-icons3.1.4 vs-code-xml-format0.1.5 vscode-pull-request-github0.74.0 open-in-browser1.0.2 csharp2.6.24 vscode-dotnet-runtime1.8.1 python2023.18.0 vscode-pylance2023.10.20 remote-wsl0.81.8 powershell2023.8.0 open-in-gitup1.0.0 LiveServer5.7.9 es7-react-js-snippets1.9.3 sonarlint-vscode3.22.0 code-spell-checker3.0.1 vscode-open-in-github1.3.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Better workaround: press
Change:
const cellExecutions: [NotebookCellTextModel, INotebookCellExecution][] = []; for (const cell of cellsArr) { const cellExe = this._notebookExecutionStateService.getCellExecution(cell.uri); <del> if (cell.cellKind !== CellKind.Code || !!cellExe) { </del> <ins> if (!!cellExe) { </ins> continue; } cellExecutions.push([cell, this._notebookExecutionStateService.createCellExecution(notebook.uri, cell.handle)]);

Discussion:
Testing microsoft/vscode-jupyter 1) Open 1) Install Jupyter and Python extensions 1) Create a new untitled jupyter notebook 1) Create a markdown cell 1) Paste image 1) <kbdCtrl</kbd+<kbdEnter</kbd-I get a prompt for installing kernels from the market place. <img width="925" alt="image" src="https://user-"This is wrong for two reasons: 1) Since the Jupyter extension is installed I should be able to connect the notebook to a kernel on a remote server. Also see 1) This is a markdown cell. No kernel needed for rendering a markdown cell.
I'm not seeing this locally but I can reproduce with Not sure where is the best place to check whether the cells are markdown cells.
Change:
protected pull(rebase = false): Promise { return this.gitService.pull(rebase).then(null, (err) => { if (err.gitErrorCode === GitErrorCodes.DirtyWorkTree) { <del> return Promise.wrapError(errors.create(nls.localize('dirtyTreePull', "Can't pull. Please commit or stage your work first."), { severity: Severity.Warning })); </del> <ins> return Promise.wrapError(errors.create(nls.localize('dirtyTreePull', "Can't pull. Please commit or stash your work first."), { severity: Severity.Warning })); </ins> } else if (err.gitErrorCode === GitErrorCodes.AuthenticationFailed) { return Promise.wrapError(errors.create(nls.localize('authFailed', "Authentication failed on the git remote."))); }

Discussion:
VSCode Version: 1.7.2 OS Version: 10.12.1 Steps to Reproduce: a project that is linked to remote a git repositoty. a clone in another dir or ask a friend to modify a file, commit, and push. the same file locally and try to pull. You will get an error saying (emphasis mine): Meanwhile, in the git console you see a different and correct error: The error is that "stash" is the correct action, staging won't help. Here is the line
Fixed by
Change:
this.container.classList.toggle('height-constrained', size.height <= 600); this.container.classList.toggle('width-constrained', size.width <= 400); this.container.classList.toggle('width-semi-constrained', size.width <= 800); <ins> this.categoriesPageScrollbar?.scanDomNode(); this.detailsPageScrollbar?.scanDomNode(); this.detailsScrollbar?.scanDomNode(); </ins> } private updateCategoryProgress() {

Discussion:
Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width="679" alt="Screen Shot 2021-08-23 at 11 19 37 PM" src="https://user-"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I would like to contribute to this. Can I help you with the issue?
Change:
this.smileyInput.attr('aria-checked', 'false'); } this.sentiment = smile ? 1 : 0; <ins> this.maxFeedbackCharacters = this.feedbackService.getCharacterLimit(this.sentiment); this.updateCharCountText(); </ins> } protected invoke(element: Builder, callback: () => void): Builder {

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?
Change:
const filePath = this._context.getFilePath(); if (filePath) { <del> return filePath; </del> <ins> return normalizeDriveLetter(filePath); </ins> } throw new VariableError(variableKind, (localize('canNotResolveFile', "Variable {0} can not be resolved. Please open an editor.", match))); };

Discussion:
Sorry for asking questions in the issue tracker. Reading I originally assumed vscode was normalizing the drive letter casing. uses upper case drive letter. However, I noticed that variables like , , on my Windows are resolved to file paths with lower case drive name, e.g. . is not consistently applied from this part of the code but I am not sure if they are supposed to be handled elsewhere. Is there a documentation on what is normalized or not normalized, and if normalized, it will be upper case or lower case. (It's not clear to me what's the final conclusion of length discussions like ) And, for debugging requests, can we assume all requests that carry the absolute file paths use normalized file path?
Another fun finding is, normalizes the drive casing to lower-case As a result, our extension ends up normalizing a path to use upper case drive letter, converting it to which uses lower-case in fsPath, and at some point, translating fsPath to upper case, ...
I think the conclusion is that we should try to be consistent with URIs coming from vscode, but remember that we can't control the whole environment- e.g. the runtime may do something different than URIs that come from DAP. I don't know why would have a different drive letter case than . Seems wrong. Do you know anything about that
I think it's just an oversight that the drive letter isn't always normalized. I'm happy to make this change during the next debt week so that it has plenty of time in insiders for folks to notice if it breaks anything.
Change:
killOnServerStop?: boolean; } <ins> // Escape codes // http://en.wikipedia.org/wiki/ANSI_escape_code const EL = /x1Bx5B[12]?K/g; // Erase in line const COLOR_START = /x1b[d+m/g; // Color const COLOR_END = /x1b[0?m/g; // Color /** * Froms vs/base/common/strings.ts in core * @see https://github.com/microsoft/vscode/blob/22a2a0e833175c32a2005b977d7fbd355582e416/src/vs/base/common/strings.ts#L736 */ function removeAnsiEscapeCodes(str: string): string { if (str) { str = str.replace(EL, ''); str = str.replace(COLOR_START, ''); str = str.replace(COLOR_END, ''); } return str; } </ins> class Trigger { private _fired = false;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: 12.15.1 Steps to Reproduce: to define a for Vite. Vite prints colors, which unlike problems matchers, are not stripped while matching the output. This makes it difficult to define a proper pattern for it.
Please provide a screenshot or illustrating the problem (attaching images won't work via email, you need to go to ). See for more general info on how to report actionable terminal issues. /label info-needed terminal
Sorry for the zip. The gif came out 1MiB bigger than GitHub will like to allow to upload.
Thanks - based on the gif, the problem is that is not taking effect - in your case, the property
It is taking effect. I'm purposefully disabling it by commenting it at first. At the start I run without it to show that is not working with colors enabled. I then uncomment it which disables colors and show that without colors does work.
Change:
} if (this.label) { <del> const configuredLangId = this.label.resource ? withNullAsUndefined(getConfiguredLangId(this.modelService, this.modeService, this.label.resource)) : undefined; if (this.lastKnownConfiguredLangId !== configuredLangId) { </del> <ins> const detectedModeId = this.label.resource ? withNullAsUndefined(detectModeId(this.modelService, this.modeService, this.label.resource)) : undefined; if (this.lastKnownDetectedModeId !== detectedModeId) { </ins> clearIconCache = true; <del> this.lastKnownConfiguredLangId = configuredLangId; </del> <ins> this.lastKnownDetectedModeId = detectedModeId; </ins> } }

Discussion:
Issue Type: <bBug</bto something like . a new tab. The tab should have the Markdown icon, but it has the Plain Text icon. If you move to another tab then back, the icon will be updated. This only started happening when I updated to 1.3, and it's still happening in Insiders. I've got no extensions or settings (other than ) set. VS Code version: Code - Insiders 1.31.0-insider (, 2018-12-21T06:14:53.023Z) OS version: Darwin x64 18.2.0 <!-- generated by issue reporter --
This is a consequence of adopting : When the tab opens we immediately render the icon, but the resource only gets the mode associated after a on the end of the tick.
via