jiebi/CodeConvo huggingface dataset:
Change:
this._spliceNotebookCells(rawEvent.changes, false, result.contentChanges); } else if (rawEvent.kind === notebookCommon.NotebookCellsChangeType.Move) { <del> this._moveCell(rawEvent.index, rawEvent.newIdx, result.contentChanges); </del> <ins> this._moveCells(rawEvent.index, rawEvent.length, rawEvent.newIdx, result.contentChanges); </ins> } else if (rawEvent.kind === notebookCommon.NotebookCellsChangeType.Output) { this._setCellOutputs(rawEvent.index, rawEvent.outputs);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No -- I'm not sure how to demonstrate the behavior of with all extensions disabled <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.1 OS Version: Windows 10.0. Build Steps to Reproduce: "Create: New Jupyter Notebook" the following in the cell that is created automatically: two more code cells below the first both containing: ! -select the second and third cells. them above the first cell. Expected: Both cells that were moved show a red squiggly complaining that is not defined. Actual: Only the new topmost cell (which was topmost in the dragged selection) shows the error. Just based on that behavior this could easily be an LSP or Pylance bug. However, I have tracked this down to not handling the field in . It always reports that a single cell was moved. So, although the UI shows that both cells moved, the language server still thinks that the cell with no errors is at the bottom of the notebook. I'll create a PR with a fix soon. !
Change:
private getTerminals(): TerminalEntry[] { const terminals = this.terminalService.getInstanceLabels(); const terminalEntries = terminals.map(terminal => { <del> return new TerminalEntry(terminal, () => { this.terminalService.showPanel(true).done(() => { this.terminalService.setActiveInstanceByIndex(parseInt(terminal.split(':')[0], 10) - 1); }, errors.onUnexpectedError); }); </del> <ins> return new TerminalEntry(terminal, this.terminalService); </ins> }); return terminalEntries; }

Discussion:
VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-04T17:43:56.658Z) OS Version: Darwin x64 16.7.0 After having used the terminal switcher for a few days, I realize that I'm always assuming that the keyboard focus moves when I change the active terminal, same what happens when using from the command pallet. As it doesn't I often end up doing the wrong thing, i.e. type shell commands in the open editor, etc. Steps to Reproduce: two terminals and one editor the keyboard focus in the editor to change the visible terminal typing -the editor content is being modified <!-- Launch with to check. --Reproduces without extensions: Yes
Change:
import { extract, ExtractError } from 'vs/base/node/zip'; import { isWindows } from 'vs/base/common/platform'; import { flatten } from 'vs/base/common/arrays'; <del> import { Emitter } from 'vs/base/common/event'; </del> import { assign } from 'vs/base/common/objects'; const ERROR_SCANNING_SYS_EXTENSIONS = 'scanningSystem';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.46.0 OS Version: Windows 10/macOS Catalina 10.15.4 VS Code 1.46 no longer executes the Attached test extension (rename file extension to .vsix) which creates a file on uninstall in the user's home directory. Using VS Code 1.45.1 the file is created on both Windows and macOS. Using VS Code 1.46 no file is created. Steps to Reproduce: attached extension extension VS Code VS Code again file is created <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: This is an extension management problem
Change:
import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; import { URI } from 'vs/base/common/uri'; import * as resources from 'vs/base/common/resources'; <del> import * as path from 'vs/base/common/path'; </del> <ins> import { isAbsolute as localPathIsAbsolute, normalize as localPathNormalize } from 'vs/base/common/path'; </ins> import { IInstantiationService, } from 'vs/platform/instantiation/common/instantiation'; import { ISimpleFileDialog, SimpleFileDialog } from 'vs/workbench/services/dialogs/browser/simpleFileDialog'; import { IWorkspacesService } from 'vs/platform/workspaces/common/workspaces';

Discussion:
I pushed this: And the build error from is:
Relies on structural equivalence, e.g the shape of all exported properties of the -modules happens to match that of the interface. Mangling renames the exported properties and hence breaks this equivalence. Technically this happens with any rename and the difference with mangling is just that renaming happens implicitly during build. Did you encounter similar situation before and how did you deal with them?
Yes I fixed a handful of cases where an entire module's shape was taken as API: There were so few instances of this, and it was so easy to work around, that I decided it didn't block merging Not sure there's a smarter way to handle this. To fix the error, simply list the specific properties you need from the module. Take a look at what the example above with does as an example
Change:
display: none; } <ins> /* single install */ .extension-editor > .header > .details > .actions-status-container > .monaco-action-bar > .actions-container > .action-item > .extension-action.label { border-radius: 2px; } /* split install */ .extension-editor > .header > .details > .actions-status-container > .monaco-action-bar > .actions-container > .action-item.action-dropdown-item > .extension-action.label { border-radius: 2px 0 0 2px; } </ins> .extension-editor > .header > .details > .actions-status-container > .monaco-action-bar > .actions-container > .action-item.action-dropdown-item > .monaco-dropdown .extension-action.label { border-left-width: 0; <ins> border-radius: 0 2px 2px 0; </ins> } .extension-editor > .header > .details > .actions-status-container > .monaco-action-bar > .actions-container > .action-item > .action-label.extension-status {

Discussion:
Looking at ways to make VS Code feel ever so slightly more approachable. A subtle 2px border radius on our common input components could be one way to make the UI feel more inviting and less harsh: <img width="361" alt="CleanShot 2022-04-08 at 14 48 52 src="https://user-"<img width="522" alt="CleanShot 2022-04-08 at 14 55 52 src="https://user-"<img width="494" alt="CleanShot 2022-04-08 at 14 58 01 src="https://user-"<img width="437" alt="CleanShot 2022-04-08 at 14 49 46 src="https://user-"<img width="500" alt="CleanShot 2022-04-08 at 15 01 55 src="https://user-"! FWIW, we already use a border radius on our icon buttons: <img width="300" alt="CleanShot 2022-04-08 at 15 03 36 src="https://user-"cc
I like this idea for buttons. I am not so sure about input/combo boxes.
I'm a +1 on this one, I think the inputs might need a bit of spacing from the side to feel more natural. We should also make sure that our labels are distinguishable as they start looking similar. Maybe we update the labels to be more pill-like?
As in padding L/R? I think they are indeed a bit different from our dropdowns if memory serves. Good call on the labels/tags.
Border-radius on buttons was merged but inputs is still under discussion so I'll keep this one open.
Good job
Change:
.monaco-workbench .pane-body.integrated-terminal .xterm { /* All terminals have at least 10px left/right edge padding and 2 padding on the bottom (so underscores on last line are visible */ padding: 0 10px 2px; <del> /* Bottom align the terminal withing the split pane */ </del> <ins> /* Bottom align the terminal within the split pane */ </ins> position: absolute; bottom: 0; left: 0; right: 0; } <ins> .terminal-side-view .terminal.xterm { /* Top align the terminal within the split pane when the panel is vertical */ top: 0; } </ins> .monaco-workbench .editor-instance .terminal-wrapper.fixed-dims .xterm, .monaco-workbench .pane-body.integrated-terminal .terminal-wrapper.fixed-dims .xterm { position: static;

Discussion:
Testing !
We'll need to repro on mac and look at the sequences to verify whether this is an issue or we're going the right thing.
I think this is working as designed since it's just padding on the top, however we could check the location of the terminal view and if it's on either side, top align the terminal instead of bottom aligning it.
Change:
lineMatcher: GitCreatePrOutputRegex, anchor: 'bottom', offset: 0, <del> length: 5 </del> <ins> length: 15 </ins> }, commandExitResult: 'success', getQuickFixes: (matchResult: ITerminalCommandMatchResult) => {

Discussion:
going to keep track of examples here to see if there's a pattern <img width="1112" alt="Screenshot 2023-01-23 at 2 12 18 PM" src="https://user-"
far right terminal <img width="1120" alt="Screenshot 2023-01-23 at 3 07 17 PM" src="https://user-"
middle terminal !
far right terminal !
far right terminal <img width="1076" alt="Screenshot 2023-01-24 at 1 59 40 PM" src="https://user-"
right terminal <img width="1644" alt="Screenshot 2023-01-24 at 2 22 27 PM" src="https://user-"
right terminal !
here are the lines when there's not a quick fix result - it contains after which we don't account for here !
Seeing this frequently: <img width="726" alt="image" src="https://user-"
I think we just need to include the to fix this
or better yet, remove and just look for the link
ok I see the issue. when lines are wrapped a lot, we need to search more lines - setting the length to 10/15 fixes it even when the terminal is quite narrow
I see it on non-wrapped lines, I'm not sure I understand what you mean with the To?
The to comment above was actually wrong. What's happened in the screen shot above is we abort the search early - after looking at only 5 lines. When it's actually on line 9
this goes wrong when we break before reaching the content IE when line count length
I tried pushing up a new branch using pwsh in the integrated terminal on Windows, and the lightbulb did not show. !
you have shell integration disabled, it won't work at all there.
also make sure to not move issues to the next milestone, this one was marked important
Working much better now, but just reproduced !
Just happened and captured the trace log (escape sequence log would be better): <img width="806" alt="image" src="https://user-"
I've seen this not work twice today already for create PR !
even though the lightbulb didn't appear here, there was a match found !

the match always happens, the lightbulb doesn't show up though until I resize the terminal
this happens when the have not yet been resolved by the time occurs ! !
I think we should be calling at the end of
have seen the create PR not show up 3 times today. resizing doesn't cause it to show up, which means our match range is wrong/ there isn't a match
this says unreleased, but was merged before the current version of insider's (5 hours ago) was released. create with PR still failing !
insider's is based on the release branch, so I was confused
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
`); }); <ins> function supportsKeywordActivation(configurationService: IConfigurationService, speechService: ISpeechService): boolean { if (!speechService.hasSpeechProvider) { return false; } const value = configurationService.getValue(KeywordActivationContribution.SETTINGS_ID); return typeof value === 'string' && value !== KeywordActivationContribution.SETTINGS_VALUE.OFF; } </ins> export class KeywordActivationContribution extends Disposable implements IWorkbenchContribution { static SETTINGS_ID = 'accessibility.voice.keywordActivation';

Discussion:
Type: <bBug</bIt's unexpected to switch to editor window and notice micophone appeared in status bar with tooltip "Waiting for voice chat to end" (very strange message for because it looks like it listens everything at this moment) at the end of meeting. ! Clicking on it opens settings with search for , but only result is Extenions Experimental: Deferred Startup Finished Activation (), which adds to confusion. I won't expect to see this status item until I gave explicit approval to use mic. VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-19T05:37:08.195Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
/assign bpasero I think you are latest committer that changed activation
Same here, how do i disable this feature? Cant find it in settings
This is related only to Insiders version and will be gone with today's Insiders build.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
import * as os from 'os'; import * as platform from 'vs/base/common/platform'; import * as processes from 'vs/base/node/processes'; <ins> import { readFile, fileExists } from 'vs/base/node/pfs'; </ins> export const TERMINAL_DEFAULT_SHELL_LINUX = !platform.isWindows ? (process.env.SHELL || 'sh') : 'sh'; export const TERMINAL_DEFAULT_SHELL_OSX = !platform.isWindows ? (process.env.SHELL || 'sh') : 'sh';

Discussion:
VSCode Version: Code 1.17.0 (, 2017-10-04T23:33:45.303Z) OS Version: Linux x64 4.12.0-2-amd64 Extensions: Extensions are disabled Steps to Reproduce: window doesn't look well ! <!-- Launch with to check. --Reproduces without extensions: Yes/No
Here is how my integrated terminal looks like !
what distro are you using? I've seen Fedora acts a little odd with font rendering both in the editor and the terminal. see
I'm experiencing the same issue on Fedora 26 / Gnome 3.24.2 / VSCode version 1.17.0. The only affected component is the terminal so far, other fonts look good. The issue is not present in VSCode 1.16.1.
i am using debian 9 / xfce4 / VSCode version 1.17.0
For Fedora right now the workaround is to use a different font:
it works like a charm. Thanks a lot :)
Thks now looks very well.
Pushed to master and release/1.17
Not sure I've got issue right, but looks like custom fonts such as are not working after last update. Before update everything worked fine. Wouldn't say it is too important, but would be nice to get it back. Linux Mint 18.2 x64. !
Same issue here with Fira Code font Ubuntu 17.04 x64
yes also here FiraCode looks weird now. macOS 10.13
same here as after 1.17.1 update it looks weird now with SF Mono on macOS. ! it looks weird, because before 1.17.1 it was awesome
This is the issue tracking the blurry text in 1.17.1
Change:
} else { use tokio::{time::sleep, io::ReadBuf}; use tokio::net::windows::named_pipe::{ClientOptions, ServerOptions, NamedPipeClient, NamedPipeServer}; <del> use std::{time::Duration, pin::Pin, task::{Context, Poll}, io}; </del> <ins> use std::{time::Duration, io}; </ins> use pin_project::pin_project; #[pin_project(project = AsyncPipeProj)]

Discussion:
It doesn't look like this new CLI supports serving on a UNIX domain socket. Could we please get that in too, like in We're going to need it in order to handle auth in a proxy. (I'm happy to open a new issue for that if you need) Originally posted by in
Nice, thanks!
I can do this what now?
Also is it an issue that the socket file wasn't release/deleted after a ctrl+C? or do I clean that up manually?
We should probably automatically delete the file if it exists You can do a to make sure it's actually working . Without extra stuff you won't be able to open it in the browser, but verifying the connection should be enough.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { join } from 'vs/base/common/path'; </ins> import { ProxyChannel } from 'vs/base/parts/ipc/common/ipc'; import { Server } from 'vs/base/parts/ipc/node/ipc.cp'; <del> import { ConsoleLogger, LogService } from 'vs/platform/log/common/log'; </del> <ins> import { OPTIONS, parseArgs } from 'vs/platform/environment/node/argv'; import { NativeEnvironmentService } from 'vs/platform/environment/node/environmentService'; import { ConsoleLogger, getLogLevel, LogService, MultiplexLogService } from 'vs/platform/log/common/log'; </ins> import { LogLevelChannel } from 'vs/platform/log/common/logIpc'; <del> import { IReconnectConstants, TerminalIpcChannels } from 'vs/platform/terminal/common/terminal'; </del> <ins> import { SpdLogLogger } from 'vs/platform/log/node/spdlogLog'; import product from 'vs/platform/product/common/product'; import { IProductService } from 'vs/platform/product/common/productService'; import { IReconnectConstants, TerminalIpcChannels, TerminalLogConstants } from 'vs/platform/terminal/common/terminal'; </ins> import { HeartbeatService } from 'vs/platform/terminal/node/heartbeatService'; import { PtyService } from 'vs/platform/terminal/node/ptyService';

Discussion:
This doesn't get logged when creating a terminal with trace logging on
I tried to do this like you and Jackson did for the on the branch merogge/remote-inv, but i'm still not seeing the logs anywhere when using remote WSL. Thoughts? Need this to investigate remote terminal reconnection bc when ssh'ing to localhost, I can't repro the issue and don't want to have to setup a vm.
maybe bc it's in platform instead of workbench it's not working? can't be in workbench though for the ptyService
instead of an output channel I think what we're after is something like this: Here: I thought that's what the LogLevelChannel was doing but maybe not? Or maybe that particular log service/channel type doesn't work on the server since it does in the shared process? !
Change:
import 'vs/css!./media/actions'; import { URI } from 'vs/base/common/uri'; import { localize, localize2 } from 'vs/nls'; <del> import { ApplyZoomTarget, applyZoom } from 'vs/platform/window/electron-sandbox/window'; </del> <ins> import { ApplyZoomTarget, MAX_ZOOM_LEVEL, MIN_ZOOM_LEVEL, applyZoom } from 'vs/platform/window/electron-sandbox/window'; </ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { getZoomLevel } from 'vs/base/browser/browser'; import { FileKind } from 'vs/platform/files/common/files';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version Version: 1.68.0 (user setup) Commit: Date: 2022-06-08T11:44:16.822Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: is not in F11 fullscreen mode. the Settings GUI, set window.zoomLevel to a negative value (e.g. -3) add an extra 0 (e.g. -30) setting is automatically applied, which leads to a state where the entire UI disappears. Clicking anywhere in the window minimizes the window. F11 fullscreen mode appears to fix this situation and the UI becomes visible again(albeit very tiny at the -30 zoom level). My initial take is this could be fixed with a sane lower bounds on window.zoomLevel. However, it appears that part of the issue is also that as window.zoomLevel becomes more negative(zooms out), the Menu Bar becomes larger. At high magnitude negative values, the Menu Bar increases in size to the point where it takes up the entire window and prevents user input. Ex.) window.zoomLevel: -20 . ! Ex.) window.zoomLevel: -30. At this level, the Menu Bar minimize "-" icon takes up the whole window.

At this level, the setting input box also de-focuses, preventing the user from pressing backspace to remove the extra 0. !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
} .interactive-session .chat-attached-context { <del> padding: 8px 8px 13px; margin-right: -3px; margin-top: 4px; margin-bottom: -4px; border: 1px solid var(--vscode-input-border, var(--vscode-input-background, transparent)); border-radius: 6px 6px 0px 0px; </del> <ins> padding: 8px 0; border-radius: 6px; </ins> display: flex; gap: 4px; flex-wrap: wrap; } .interactive-session .chat-attached-context .chat-attached-context-attachment { <del> padding: 3px; border: 1px solid var(--vscode-input-border, var(--vscode-input-background, transparent)); </del> <ins> padding: 2px; border: 1px solid var(--vscode-chat-requestBorder, var(--vscode-input-background, transparent)); </ins> border-radius: 5px; <del> height: 20px; </del> <ins> height: 18px; </ins> } .interactive-session-followups {

Discussion:
Personal preference - I do not like the border around the attached context. Does not align with the rest of the UI. Do we really need the border? Have we tried this without the border? ! fyi
Yeah, I've tried this because I don't love the weight it adds either. It does cause some weirdness when there are follow ups and lots of pills. But I'll keep playing with it to see if I can get to a place where we don't need it. !
Thank you David!
Change:
} private toSymbolInformation(item: Proto.NavtoItem): vscode.SymbolInformation | undefined { <del> if (!item.containerName || item.kind === 'alias') { </del> <ins> if (item.kind === 'alias' && !item.containerName) { </ins> return; }

Discussion:
Using the workspace TS version, 5.5.0-dev.: ! ! !
Closing for verification
Change:
const update = () => { clearNode(box); selected.map(entry => { <ins> const keys = this.keybindingService.lookupKeybinding(entry.id); if (!keys) { return; } </ins> const dl = append(box, $('dl')); const dt = append(dl, $('dt')); dt.textContent = entry.text; const dd = append(dl, $('dd')); const keybinding = new KeybindingLabel(dd, OS, { renderUnboundKeybindings: true, ...defaultKeybindingLabelStyles }); <del> keybinding.set(this.keybindingService.lookupKeybinding(entry.id)); </del> <ins> keybinding.set(keys); </ins> }); };

Discussion:
Find in Files and Show Settings provide no value, just noise: ! Not sure who owns this, I remember Christof but maybe not?
Verification Steps: Remove key bindings for "Find in Files" and verify that it does not how up in the editor watermark