jiebi/CodeConvo huggingface dataset:
Change:
return profile; } <del> return this.userDataProfilesService.getOrSetProfileForWorkspace(this.config.workspace ?? 'empty-window', profile ?? this.userDataProfilesService.defaultProfile); </del> <ins> return this.userDataProfilesService.getOrSetProfileForWorkspace(this.config.workspace ?? 'empty-window', this.userDataProfilesService.defaultProfile); </ins> } get remoteAuthority(): string | undefined { return this._config?.remoteAuthority; }

Discussion:
Currently when I open a folder for the first time we use the currently active profile. I believe this can be confusing as the user has not explicitly picked the profile they want to use for the new folder. Based on suggestion let's use the default profile for folders that are opened for the very first time. I believe this with giving users an option to chose which is the default would give users enough options and clarity when interacting with profiles. fyi
I had reported and feel this flow is no longer supported: use a non-default profile to install docker and container remote extension from the docker view open a container as new window it will fail because the new window does not have the extension installed with default profile Maybe we should make a decision based on how the user opened a new window? E.g. if an extension triggers this, always keep the profile? Or check if the extension that triggers the command is installed in the profile of the new window?
good point. And thinking about this more this might have been a bad suggestion on my end. I also think of the following - a new user just installed VS Code, and installed a Python profile. They are opening a new folder - and they get switched back to the default profile I think we should either: go back to the old behaviour and make sure to make it clearer what profile is applied to what folder to decrease confusion the current behaviour but make it easier for users to choose what is the "default profile". And cover cases like brought up what do you think?
Change:
import { areWebviewInputOptionsEqual } from 'vs/workbench/contrib/webview/browser/webviewWorkbenchService'; import { WebviewThemeDataProvider } from 'vs/workbench/contrib/webview/common/themeing'; import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; <ins> import { isLinux } from 'vs/base/common/platform'; </ins> export const enum WebviewMessageChannels { onmessage = 'onmessage',

Discussion:
Issue Type: <bBug</bOpen a new window, close the Untitled tab, open Release notes and press Ctrl+W (or Cmd+W) on macOS. Expected: Release notes tab is closed. Actual: Release notes tab is closed as well as the current window. You can also open a file, open Release notes and press Ctrl+W. Release notes and the last file will close. VS Code version: Code 1.39.2 (, 2019-10-15T15:33:40.634Z) OS version: Linux x64 4.15.0-65-generic
I tried reproducing the issue, seems everything is working fine.
The same happened when closing opened images. Using "Ctrl+W" to close an image would 1)close another file if there is, 2) otherwise close current VSCODE window OS version: Linux Mint 19.2 Tina (Cinnamon)/ XM Linux live(XFCE) image on VM VS Code version: 1.40.0 and the insider version Also I tried to reproduce it on a Windows 7 VM, and it was not there. Is it caused by Electron by any chance? I'd love to try to fix it. However, yet have no clue on where the related lines of codes are located. Any hints or suggestions? Thanks
Reopening since the fix caused regressions and had to be reverted
I confirm this is still happening with vscode v1.44.0 and Ubuntu 18.04. Many similar issues are opened already: ,
Should be fixed by
Change:
</dict> </array> <key>while</key> <del> <!-- seperator    [ ]{0,3}([-*_][ ]{0,2}2){2,}[ t]*$n? --> <!-- list         [ ]{0,3}[*+-]([ ]{1,3}|t) --> <!-- both are folded together in the expression below --> <string>(^|G)(?!s*$|#|[ ]{0,3}((([*_][ ]{0,2}2){2,}[ t]*$n?)|([*+-]([ ]{1,3}|t)))|s*[.+?]:|&gt;)</string> </del> <ins> <string>(^|G)((?=s*[-=]{3,}s*$)|[ ]{4,}(?=S))</string> </ins> </dict> <key>fenced_code_block_css</key> <dict>

Discussion:
For a markdown file like this: text text text . text text text <divhtml </div. text text text The numbered list, html block, and fenced code block elements following the line are nor properly colorized. They are rendered properly in the preview. ! In the case of the html, the text should not be colorized since it is html content, not markdown. Adding a blank line after the paragraph fixes the colorization. !
Change:
"url": "vscode://schemas/snippets" }, { <ins> "fileMatch": "%APP_SETTINGS_HOME%/profiles/*/snippets/.json", "url": "vscode://schemas/snippets" }, { </ins> "fileMatch": "%APP_SETTINGS_HOME%/sync/snippets/preview/*.json", "url": "vscode://schemas/snippets" },

Discussion:
Type: <bBug</ba new profile from empty "Perferences: Open Keyboard Shortcuts (JSON)" command suggestions in opened editor Only word-based suggestions shown. VS Code version: Code - Insiders 1.72.0-insider (, 2022-09-29T08:07:23.017Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes Remote OS version: Linux x64 5.15.62.1-microsoft-standard-WSL2 Remote OS version: Linux x64 5.15.62.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ Bookmarks13.3.1 vscode-eslint2.2.6 gitlens12.2.2 prettier-vscode9.9.0 copilot-nightly1.47.6893 remotehub0.43. rest-client0.25.1 vscode-env0.1.0 search-node-modules1.3.0 fluent-icons0.0.18 vscode-docker1.22.1 vscode-edge-devtools2.1.1 remote-containers0.254.0 remote-ssh0.87. remote-ssh-edit0.84.0 remote-wsl0.72.0 js-debug-nightly2022.9.2717 remote-explorer0.1. remote-repositories0.20.0 vscode-typescript-next4.9. abracadabra6.15.3 material-icon-theme4.20.0 prisma4.4.0 vscode-yaml1.10. reveal1.2.7 code-spell-checker2.8.0 luna-paint0.16.0 markdown-all-in-one3.4.3 material-theme3.15.5 </details<!-- generated by issue reporter --
Works for me !
! It's , not
Looks like the JSON schema is not registered for in profiles (unlike below). has different schema for default profile vs others, not sure what should happen with
Oh, my bad, keybindings, not settings. Got it!
Change:
if (didChange) { // HACK: To render all editor tabs on startup, otherwise only one row gets rendered otherTabController.openEditors([]); <ins> this.handleOpenedEditors(); </ins> } return didChange; }

Discussion:
Testing ! I am still trying to recap how I got there... Update: have some pinned and non-pinned tabs open an empty group to the right drag the entire group to the right by dragging from empty space after the last tab you end up with 2 action bars visible
Change:
paddingOnRow?: boolean; ariaLabel?: string; keyboardSupport?: boolean; <ins> preventRootFocus?: boolean; </ins> } export interface ITreeStyles {

Discussion:
While testing . VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-01T05:07:59.267Z) OS Version: Darwin x64 16.7.0 Steps to Reproduce: 3 terminals from the command palette <kbdArrowDown</kbdto the last terminal in the switcher <kbdTab</kbdto rename the terminal -keyboard focus disappears from the input box (and seems to be nowhere). I need a second <kbdTab</kbdto move the keyboard focus to the rename action in the selected row. A single <kbdTab</kbdshould suffice.
This is also an issue with task configuration
Change:
private initialViewUpdateExpanded(): void { this.templateData.container.classList.toggle('input-collapsed', false); <del> this._showInput(); </del> <ins> DOM.show(this.templateData.editorPart); DOM.hide(this.templateData.cellInputCollapsedContainer); </ins> this.templateData.container.classList.toggle('output-collapsed', false); this._showOutput(true); <del> this.relayoutCell(); </del> } private layoutEditor(dimension: IDimension): void {

Discussion:
Type: <bBug</bAfter updating to the latest VS Code version, I noticed two issues in the jupyter notebook: a) in the output cell, both the content and the text "Outputs are collapsed" overlap. This text disappears once I collapse the output and show it again. ! b) in the code cell, if I'm writing something and then scroll up/down, the content of this cell is no longer visible Thanks VS Code version: Code 1.75.0 (, 2023-02-01T15:23:45.584Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ rainbow-csv3.5.0 isort2022.8.0 python2023.2.0 vscode-pylance2023.2.10 jupyter2023.1. jupyter-keymap1.0.0 jupyter-renderers1.0.14 vscode-jupyter-cell-tags0.1.6 vscode-jupyter-slideshow0.1.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Happens to me all the time, not sure exactly what are the steps to reproduce, it has something to do with collapsing cells and then running them again, or something to do with restarting the kernel... !
Issue "a)" happened to me already before the last update as well, but the issue "b)" happens to me only since the last version and is quite incapacitating.
This issue should be fixed now in latest Insiders and will be released with next Stable recovery build.
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.13.0-beta.2: version "0.13.0-beta.2" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.2.tgz#f58a7a3641ad7c8ac82dd24cfb0165656ed9ac1c" integrity sha512-98tX0BkpD402RoCO6SyikUXpzCn9/OQhlXsRmM/kRFCxMWWofStWTXzCPhN0MjIx2IdGueDjCmnShhidwihErg== xterm-headless@4.20.0-beta.5: version "4.20.0-beta.5" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.20.0-beta.5.tgz#edcff27eb6437d158e6aea2ed7658e783bee5641" integrity sha512-8SnVUsuNUrQ5P0XU/9Iau3uK7Tf8q/p0KHHwkwJXVxZDIlaDH9XKSs91U9BjJJE3sJgRxH4NSiDYR3vFLSFpxw== xterm@4.20.0-beta.5: version "4.20.0-beta.5" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.20.0-beta.5.tgz#d707b0dcb477a554135fb767b24003fced079866" integrity sha512-KBWfk9UPBKRy662DVGGTZEcW1becEjYvlyWbn2hLj9h2gy6Q4EEEEbggJh8I7SGwdFizl+apHQGhEOZmFCA70w== </del> <ins> xterm-addon-webgl@0.13.0-beta.3: version "0.13.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.3.tgz#2b456c3105238e64b40a30787d6335f5f6f85abb" integrity sha512-DFGcXAolA0VTsOLIKcORxUOp/FTJdD/YiRzKVLARjgOycwVRKvW2L5Tge8Z7ysZ16sKfnV2vCXyonXYfUWozXw== xterm-headless@4.20.0-beta.6: version "4.20.0-beta.6" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.20.0-beta.6.tgz#bd016379e9fac47e5b8870d567cdf330cf6f49fc" integrity sha512-EV0V7pxMKI0OEcOCD+6vdXq6rBARr7dSN3PovTsZnDWg5dmvUb2eEmz6BTejJj3UVd/JXNEmEXM+tCh97rDCDg== xterm@4.20.0-beta.6: version "4.20.0-beta.6" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.20.0-beta.6.tgz#3ed87ba383a5cf44284098278f714df7113e3e3c" integrity sha512-xJd6vyOuYo4Ht/hTY3DyXGIj0U6kHjr2vWQ1lRmearo3t7QKf7uqOAAfTLeWt/g1P8qe/r0DnsNTeag6vI9RVw== </ins> y18n@^3.2.1: version "3.2.2"

Discussion:
fixed in Need to update xterm to pull it in: !
What's a way to verify this issue on Windows?
With Powershell on Windows in the integrated terminal without a powerline font enabled: You should get something like this: <img width="62" alt="image" src="https://user-"
They seem a bit clipped to me: !
tracked in
Change:
} registerAction2(ShowSingleEditorTabAction); <ins> // --- Tab Bar Submenu in View Appearance Menu MenuRegistry.appendMenuItem(MenuId.MenubarAppearanceMenu, { submenu: MenuId.EditorTabsBarShowTabsSubmenu, title: localize('tabBar', "Tab Bar"), group: '4_editor', order: 6 }); </ins> // --- Toggle Pinned Tabs On Separate Row registerAction2(class extends Action2 {

Discussion:
I suggest to have the sub-menu with the 3 options also in the view menu "Appearance" <img width="532" alt="image" src=""
Change:
} .customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item>.custom-view-tree-node-item-icon.disabled { <del> opacity: 60%; </del> <ins> opacity: 0.6; </ins> } /* makes spinning icons square */ .customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item > .custom-view-tree-node-item-icon.codicon.codicon-modifier-spin {

Discussion:
Testing When a command is disabled with "enablement": "false", the icon is no longer displayed. ! Here's the tree view item with the icon !
Change:
if (markerIndex >= this._getCommandMarkers().length) { this._currentMarker = Boundary.Bottom; this._terminal.scrollToBottom(); <del> this.clearMarker(); </del> <ins> this._resetNavigationDecoration(); </ins> return; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: vscode built using current branch OS Version: Ubuntu 20.04 LTS When selecting previous/next commands in a terminal with ctr+shift+up/down, if one of the boundaries is reached, the selection disappeared and the current position is moved to the bottom. Current behaviour: ! In the last stable release, the behaviour is: !
Change:
import * as vscode from 'vscode'; import { API as GitAPI, RefType, Repository } from './typings/git'; <del> import { getRepositoryFromUrl } from './util'; </del> <ins> import { getRepositoryFromUrl, repositoryHasGitHubRemote } from './util'; </ins> export function isFileInRepo(repository: Repository, file: vscode.Uri): boolean { return file.path.toLowerCase() === repository.rootUri.path.toLowerCase() ||

Discussion:
Testing Steps: disable Remote Repos, GitHub Repos, Azure Repos. Then I Continue Working in shows up so I picked it nothing happens This might be but I see the same behavior when I disable Codespaces so it might be a different issue.
Ooh I just reproed this in OSS, log says
Change:
termArgs.push(`''${bashCommand}''`);	// wrapping argument in two sets of ' because node is so "friendly" that it removes one set... // merge environment variables into a copy of the process.env <del> const env = extendObject(extendObject({}, process.env), envVars); </del> <ins> const env = assign({}, process.env, envVars); </ins> const options: any = { cwd: dir,

Discussion:
The and should be removed
Sorry for question, but why you don't use native ?
stuff in common is still used in very old browser
Fixed in
Change:
order: 1.4 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 3, }]

Discussion:
Type: <bBug</b- VS Code Version: 1.74.1 OS Version: Windows NT x64 10.0. Issue appeared just after upgrading VSCode to ver. 1.74.1 Currently, it is impossible to go to the function definition by clicking Ctrl+Click on the function name or using the F12 button. Also, the Go to definition option in Top Menu-Go-Go to Definition is disabled. VS Code version: Code 1.74.1 (, 2022-12-14T10:30:51.966Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
What code language? Is the option also disabled in the context menu? was a previous issue about this and related options not getting enabled in the top-level Go menu. Maybe this has come back. Do you think this didn't happen in 1.74.0?
- maybe caused by
Yeah, looks like the precondition for the command is too strong
Javascript I don't have such an option in the context menu I'm not 100% sure, which version I had previously installed, but I'm using VSCode almost every day, so I'm pretty sure I was using 1.74.0 or 1.73.1, and that behavior has occurred after auto-upgrade to 1.74.1. I've never noticed anything like it before.
After a clean uninstall (Uninstalled and deleted %APPDATA%Code and %USERPROFILE%.vscode), and installing 1.74.1 again, the problem does not occur anymore.
Change:
const primaryStatus = instance.statusList.primary; if (primaryStatus && primaryStatus.severity >= Severity.Warning) { label = `${prefix}$(${primaryStatus.icon?.id || instance.icon?.id})`; <del> ariaLabel = ''; </del> } else { label = `${prefix}$(${instance.icon?.id})`; }

Discussion:
Testing Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this: Put for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a and not a Modify aria label of an element in case he is part of a split
We're converting this into a list next iteration , I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.
hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?
oh great that you moving to the list. You should have a correct role then. I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip. Special character is not read out now because it is not part of the aria label.
Good point
Scoped this issue down, conversion to list will be handled in
I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before. I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just
! When I inspect a split terminal tab label, it has the correct aria label.
Oh but you are setting the on the wrong HTML element You should use the so the is properly set on the element. It has to be on that element, since that element has focus and that is what the Screen Reader will read. So I think it should be fixed here
Change:
const baseResource = this.contextService?.getWorkspaceFolder(resource); if (options.relative && baseResource) { <del> const rootName = baseResource?.name ?? basenameOrAuthority(baseResource.uri); </del> <ins> const baseResourceLabel = this.formatUri(baseResource.uri, formatting, options.noPrefix); let relativeLabel = this.formatUri(resource, formatting, options.noPrefix); </ins> <del> let relativeLabel: string; if (isEqual(baseResource.uri, resource)) { relativeLabel = ''; // no label if resources are identical } else { const baseResourceLabel = this.formatUri(baseResource.uri, formatting, options.noPrefix); relativeLabel = this.formatUri(resource, formatting, options.noPrefix).substring(baseResourceLabel.lastIndexOf(formatting.separator) + 1); if (relativeLabel.startsWith(rootName)) { relativeLabel = relativeLabel.substring(rootName.length + (relativeLabel[rootName.length] === formatting.separator ? 1 : 0)); } </del> <ins> let overlap = 0; while (relativeLabel[overlap] && relativeLabel[overlap] === baseResourceLabel[overlap]) { overlap++; } if (!relativeLabel[overlap] || relativeLabel[overlap] === formatting.separator) { relativeLabel = relativeLabel.substring(1 + overlap); </ins> } const hasMultipleRoots = this.contextService.getWorkspace().folders.length > 1; if (hasMultipleRoots && !options.noPrefix) { <ins> const rootName = baseResource?.name ?? basenameOrAuthority(baseResource.uri); </ins> relativeLabel = relativeLabel ? (rootName + ' • ' + relativeLabel) : rootName; // always show root basename if there are multiple }

Discussion:
Issue Type: <bBug</bI have a multi-root workspace with this config: When I open search results in an editor, the part is incorrectly shown as part of the path: And while this looks like just a cosmetic issue , it also breaks opening the file via F12/doubleclick, since the now gets duplicated in the actual path is tries to open. VS Code version: Code - Insiders 1.47.0-insider (, 2020-06-23T09:03:35.861Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.14.83-gentoo Remote OS version: Linux x64 4.14.83-gentoo Remote OS version: Linux x64 5.4.28-gentoo Remote OS version: Linux x64 4.14.83-gentoo <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ systemd-unit-file1.0.6 udev-rules1.0.0 viml0.1.7 tmux0.1.0 remote-containers0.123.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.4 vscode-remote-extensionpack0.20.0 jinjahtml0.13.0 gitconfig2.0.1 mako0.2.0 vscode-icons10.1.1 overtype0.2.0 vscode-module-templates1.3.0 vscode-postgres1.1.11 quick-open-prefill-selection0.0.1 vscode-eslint2.1.5 gitlens10.2.2 EditorConfig0.15.1 prettier-vscode5.1.0 Go0.14.4 search-editor-apply-changes0.1.1 vsc-python-indent1.10.1 restructuredtext128.0.0 MagicPython1.1.0 vscode-github-actions3.0.0 vscode-docker1.3.1 python2020.7.-dev puppet-vscode0.27.3 vscode-yaml0.8.0 vscode-stylelint0.84.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Thanks for submitting this! Should be fixed in the next insiders.