jiebi/CodeConvo huggingface dataset:
Change:
resolved "https://registry.yarnpkg.com/buffer-crc32/-/buffer-crc32-0.2.13.tgz#0d333e3f00eac50aa1454abd30ef8c2a5d9a7242" integrity sha1-DTM+PwDqxQqhRUq9MO+MKl2ackI= <del> chokidar@3.4.3: version "3.4.3" resolved "https://registry.yarnpkg.com/chokidar/-/chokidar-3.4.3.tgz#c1df38231448e45ca4ac588e6c79573ba6a57d5b" integrity sha512-DtM3g7juCXQxFVSNPNByEC2+NImtBuxQQvWlHunpJIS5Ocr0lG306cC7FCi7cEA0fzmybPUIl4txBIobk1gGOQ== </del> <ins> chokidar@3.5.0: version "3.5.0" resolved "https://registry.yarnpkg.com/chokidar/-/chokidar-3.5.0.tgz#458a4816a415e9d3b3caa4faec2b96a6935a9e65" integrity sha512-JgQM9JS92ZbFR4P90EvmzNpSGhpPBGBSj10PILeDyYFwp4h2/D9OM03wsJ4zW1fEp4ka2DGrnUeD7FuvQ2aZ2Q== </ins> dependencies: anymatch "~3.1.1" braces "~3.0.2"

Discussion:
Steps to Reproduce: on Apple SI a folder in devtools:
Related failing unit test:
Chokidar v3.5.0 was just released that takes in fsevents universal build , we can update to it.
yep this required compiling fsevents as universal binary
Change:
const SHOULD_PROMPT_FOR_PROFILE_MIGRATION_KEY = 'terminals.integrated.profile-migration'; <ins> let migrationMessageShown = false; </ins> const enum Constants { /** * The maximum amount of milliseconds to wait for a container before starting to create the

Discussion:
<img width="470" alt="Screen Shot 2021-05-28 at 11 40 58 AM" src="https://user-"This is my only shell/profile setting:
It should also show only once per window reload
Fixed already /duplicate of
Not sure how to get it to only show once per window reload. Custom implementation?
keep a boolean like at the top level of the file to track it.
This still happens because needs to be at the top level, not a member of TerminalInstance in order to be shared.
If we only do this for the first terminal that gets created though, if users change their settings and then create terminals, they won't see this message.
Just tested it and think that's fine
that's fine, they'd eventually hit it again after a restart. The main thing is that we're annoying people as little as possible.
Tried to verify, think this is still unreleased.
I think it should be released already since Alex Dima released a few hours ago an insider's based on release/1.57, which has the changes.
Works after updating
Change:
return this.preferredDescription; } <ins> override getTitle(verbosity?: Verbosity): string { let title = super.getTitle(verbosity); const preferredTitle = this.getPreferredTitle(); if (preferredTitle) { title = `${preferredTitle} (${title})`; } return title; } protected getPreferredTitle(): string | undefined { if (this.preferredName && this.preferredDescription) { return `${this.preferredName} ${this.preferredDescription}`; } if (this.preferredName || this.preferredDescription) { return this.preferredName ?? this.preferredDescription; } return undefined; } </ins> getEncoding(): string | undefined { if (this.model) { return this.model.getEncoding();

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When set to fixed, the title of diff editor which is opened by clicking item in timeline view will only show the title of the editor, and I also need to see all of the editor name: !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
this._themeService.getColorTheme(), viewModel, viewUserInputEvents, <del> this._overflowWidgetsDomNode </del> <ins> this._overflowWidgetsDomNode, this._instantiationService </ins> ); return [view, true];

Discussion:
Type: <bBug</bWhen accessibility mode is off and focus is in the editor, pressing Alt +F1 produces the following announcement to screen reader users: "The editor is not accessible at this time. Press Alt+F1 for options.". If one is a new user of the product and screen reader mode doesn't turn on automatically, pressing the command which is supposed to help one get started just repeats the same announcement inviting the user to use Alt +F1 to obtain help. VS Code version: Code - OSS Dev 1.81.0 (Commit unknown, Date unknown) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I filed the bug while running VS Code from source. That's why version information doesn't reflect that I'm using the latest. Correct version information: Version: 1.81.0-insider (user setup) Commit: Date: 2023-07-18T05:36:41.526Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.
Since the help menu is not accessible with that off, instead of we should say to enable screen reader mode.
Change:
return [...this._repositories.keys()]; } <ins> constructor() { this.onDidChangeRepositories(); } </ins> addRepository(repository: string, path: string): void { this._repositories.set(repository, path); this.onDidChangeRepositories();

Discussion:
Open a folder with no git repo <img width="363" alt="image" src=""in an older version of vscode I see this <img width="414" alt="image" src=""
Change:
} if (this._menuItemAction.alt) { <del> const updateAltState = (keyStatus: IModifierKeyStatus) => { const wantsAltCommand = !!this._commandAction.alt?.enabled && (keyStatus.altKey || ((isWindows || isLinux) && keyStatus.shiftKey)); </del> <ins> let mouseOverOnWindowsOrLinux = false; const updateAltState = () => { const wantsAltCommand = !!this._menuItemAction.alt?.enabled && ( this._altKey.keyStatus.altKey || (this._altKey.keyStatus.shiftKey && mouseOverOnWindowsOrLinux) ); </ins> if (wantsAltCommand !== this._wantsAltCommand) { this._wantsAltCommand = wantsAltCommand;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.0 OS Version: Ubuntu 23.04 the panel a file Shift Terminal icon changes Shift key Terminal icon changes again When pressing in the editor, the terminal icon should stay the same. When pressing in the editor, the terminal icon switches to a different icon. The issue might haven been introduced here
FYI I've removed the prefix to the issue's title, since the observed behavior was actually our intention. I can see how on Windows and Linux, reacting on <kbdShift</kbdmight be too aggressive, so I propose doing the new behavior (no need to hover) only when <kbdAlt</kbdis pressed, while leaving <kbdShift</kbdto behave like before, on Windows and Linux.
Verification: <kbdAlt</kbdshould toggle alt state of commands no matter what On Windows and Linux only: <kbdShift</kbdshould toggle alt state of commands only when hovering them
Change:
private async uninstallExtensionsNotInProfiles(): Promise<void> { const installed = await this.extensionManagementService.getAllUserInstalled(); <del> const toUninstall = installed.filter(installedExtension => !this.allExtensions.has(this.getKey(installedExtension.identifier, installedExtension.manifest.version))); </del> <ins> const toUninstall = installed.filter(installedExtension => installedExtension.installedTimestamp /* Installed by VS Code */ && !this.allExtensions.has(this.getKey(installedExtension.identifier, installedExtension.manifest.version))); </ins> if (toUninstall.length) { await this.extensionManagementService.markAsUninstalled(...toUninstall); }

Discussion:
The folder is now empty on my machine and around 20 extensions I wrote to troubleshoot various issues are gone . If I create a folder at with the contents an extension would have, it is not found by vscode anymore.
steps to reproduce: create an extension at start close vscode start observe how your files get deleted
Change:
private async _doStopExtensionHostsWithVeto(reason: string): Promise<boolean> { const vetos: (boolean | Promise<boolean>)[] = []; <del> const vetoReasons: string[] = []; </del> <ins> const vetoReasons = new Set<string>(); </ins> this._onWillStop.fire({ reason,

Discussion:
Testing Open a folder that has a image in an empty profile Install Luna Paint Extension Edit the image using Luna Paint and do not save Switch the profile to another profile Reason is empty <img width="573" alt="image" src=""
Good catch, there is an error thrown but I fail to remember the reason in that case. It should be: !
Change:
import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; import { IDecoration, ITerminalAddon, Terminal } from 'xterm'; import { AudioCue, IAudioCueService } from 'vs/platform/audioCues/browser/audioCueService'; <ins> import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; </ins> interface IDisposableDecoration { decoration: IDecoration; disposables: IDisposable[]; exitCode?: number; markProperties?: IMarkProperties }

Discussion:
VS Code Shell Integration vulnerability when re-running a command Escape sequences implemented by VS Code to support shell integration allow for a previously run command line to be replaced.
Change:
); } <ins> public static isChildOfOverflowGuard(path: Uint8Array): boolean { return ( path.length >= 1 && path[0] === PartFingerprint.OverflowGuard ); } </ins> public static isChildOfOverflowingContentWidgets(path: Uint8Array): boolean { return ( path.length >= 1

Discussion:
Type: <bBug</bthe blue light bulb the "Update import from ..." quick fix : Quick fix widget closes, but no import updated https://user- VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-22T05:21:47.548Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (34)</summaryExtensionVersion ------ Bookmarks13.3.1 smart-clicks0.1.1 vscode-zipfs3.0.0 vscode-eslint2.3.0 gitlens13.2.0 prettier-vscode9.10.3 copilot-nightly1.65.7761 remotehub0.49. rest-client0.25.1 vscode-env0.1.0 search-node-modules1.3.0 fluent-icons0.0.18 vscode-docker1.23.3 remote-containers0.268.0 remote-ssh0.95. remote-ssh-edit0.84.0 remote-wsl0.72.0 hexeditor1.9.9 js-debug-nightly2022.12.1417 live-server0.5. remote-explorer0.1. remote-repositories0.26.0 vscode-typescript-next5.0. vsliveshare1.0.5788 abracadabra6.17.0 material-icon-theme4.23.0 prisma4.8.0 vscode-yaml1.11. vscode-sort-json1.20.0 reveal1.2.7 code-spell-checker2.12.0 luna-paint0.16.0 markdown-all-in-one3.5.0 material-theme3.15.6 </details<!-- generated by issue reporter --
I can't reproduce this issue. Can you please try putting together a small example project that demonstrates this problem
Did some debugging, this issue triggers when code fix menu item is overlapping with CodeLens. It doesn't matter what the code fix is. For example in a JavaScript file: https://user- The editor intercepts the event because this hit test found a match. Not sure what "view zone" is, but looking at my original reproduce, there is a CodeLens there.

Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
Please try again using the new repro step above. It's still reproducible in latest insiders version.
Thank you I can repo now I believe the root cause is that our editor mouse handlers don't know about context views. In this instance, clicking in the action widget fires here: This code ends up thinking that the user has clicked on an element, which suppresses the event. This means our code action list never receives a event Can you provide some suggestions on how to fix this? I tried adding a new enum value but then realized the context view service can't use because it lives in
I could reproduce the same with Ballerina vscode extension as depicted below. ! When I select an item from the context menu on a code lens it selects the token as depicted above(triggers a event). This prevents the selected item (code action) from executing. However, if I selected the same somewhere else (not on code lens) it does not trigger such a event and the code action executes fine.
I see. The root problem is that via direct DOM APIs and that is unexpected to the mouse handling logic. The foreign dom nodes to the editor have so far been via API (content widgets, overlay widgets, etc.).
Change:
import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; <ins> import { language } from 'vs/base/common/platform'; </ins> export const ISpeechService = createDecorator<ISpeechService>('speechService');

Discussion:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked
Change:
logService.debug(`runCommands: executing ${i}-th command: ${safeStringify(cmd)}`); <del> const r = await this._runCommand(commandService, cmd); </del> <ins> await this._runCommand(commandService, cmd); </ins> <del> logService.debug(`runCommands: executed ${i}-th command with return value: ${safeStringify(r)}`); </del> <ins> logService.debug(`runCommands: executed ${i}-th command`); </ins> } } catch (err) { logService.debug(`runCommands: executing ${i}-th command resulted in an error: ${err instanceof Error ? err.message : safeStringify(err)}`);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: ~1.88.1~ 1.89.0 OS Version: Windows_NT x64 10.0. I am trying to add a hotkey to open the source file and close all diffs when pressed in a diff. When running it, an error is thrown, and execution stops before reaching the second command: ! (from keybinding debugger): [error] Method not found: toJSON: CodeExpectedError: Method not found: toJSON at (..ProgramsMicrosoft VS Coderesourcesappoutvscodeelectron-main) I removed the second command, and found that openSide fails even if no other command exists, and succeeds if not run by runCommands: Works fine: Fails: Steps to Reproduce: this to Open a diff, run keybind, observe it does not work and throws error I am able to workaround this by using the extension.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thank you bot, I have updated to 1.89, issue is still present
Thank you for the issue! This will be fixed in VSCode Insiders released on Monday and VSCode stable May release early June.
Change:
} const originalDataTransfer = toVSDataTransfer(originalEvent.dataTransfer); <del> addExternalEditorsDropData(originalDataTransfer, originalEvent); </del> <ins> addExternalEditorsDropData(originalDataTransfer, originalEvent, true); </ins> const outDataTransfer = new VSDataTransfer(); for (const [type, item] of originalDataTransfer.entries()) {

Discussion:
Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-22T05:17:09.661Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. This is a follow up of Steps to Reproduce: the dnd sample: to the of some logs in : the extension multiple files to the dnd sample view, the uris in the data transfer are not split by line separators. // cc
Are you dragging from the VS Code file explorer view, or your operating system's file explorer?
Sorry forgot to mention, it's from VS Code file explorer
Can you check the actual value, not just the value printed by I debugged this and oddly while just prints: The actual value of is: In this case each file name is separated by a pair
Tested in: Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-23T05:16:43.681Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. It's still stored in one line: https://user- Is there anything I missed?
Thanks. Only happens on windows for me. Taking a look now
I don't see us setting anywhere and suspect chrome is generating it automatically. See in for how this may happen Also we are possibly hitting
Nice find. I couldn't find us setting anywhere either.
Verified on Windows and Linux in 1.69.0-insider (user setup) Commit: , 022-07-01T05:17:04.343Z
Change:
mouseMarker.style.top = `${e.clientY - mouseIndicatorSize / 2}px`; mouseMarker.style.left = `${e.clientX - mouseIndicatorSize / 2}px`; mouseMarker.style.display = 'block'; <ins> mouseMarker.style.transform = `scale(${1})`; mouseMarker.style.transition = 'transform 0.1s'; </ins> const mouseMoveListener = onMouseMove.event(e => { mouseMarker.style.top = `${e.clientY - mouseIndicatorSize / 2}px`; mouseMarker.style.left = `${e.clientX - mouseIndicatorSize / 2}px`; <ins> mouseMarker.style.transform = `scale(${.8})`; </ins> }); Event.once(onMouseUp.event)(() => {

Discussion:
That is, when I click down, it will shrink (88%), which will be more tactile (of course, adding will make it smoother!) https://user-
The effect is like this, I initiated a pr, can you review it for me? https://user-
Change:
webview: vscode.WebviewPanel, state: any ): Promise<void> { <del> const resource = vscode.Uri.parse(state.resource); const locked = state.locked; const line = state.line; const resourceColumn = state.resourceColumn; const preview = await DynamicMarkdownPreview.revive( { resource, locked, line, resourceColumn }, webview, this._contentProvider, this._previewConfigurations, this._workspace, this._logger, this._topmostLineMonitor, this._contributions, this._tocProvider); this.registerDynamicPreview(preview); </del> <ins> try { const resource = vscode.Uri.parse(state.resource); const locked = state.locked; const line = state.line; const resourceColumn = state.resourceColumn; const preview = DynamicMarkdownPreview.revive( { resource, locked, line, resourceColumn }, webview, this._contentProvider, this._previewConfigurations, this._workspace, this._logger, this._topmostLineMonitor, this._contributions, this._tocProvider); this.registerDynamicPreview(preview); } catch (e) { console.error(e); webview.webview.html = /* html */`<!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <!-- Disable pinch zooming --> <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0, user-scalable=no"> <title>Markdown Preview</title> <style> html, body { min-height: 100%; height: 100%; } .error-container { display: flex; justify-content: center; align-items: center; text-align: center; } </style> <meta http-equiv="Content-Security-Policy" content="default-src 'none';"> </head> <body class="error-container"> <p>${localize('preview.restoreError', "An unexpected error occurred while restoring the Markdown preview.")}</p> </body> </html>`; } </ins> } public async resolveCustomTextEditor(

Discussion:
https://vscode- Deminified Stack TypeError: Cannot read properties of undefined (reading 'resource') at deserializeWebviewPanel in /vscode/bin/linux-x64//extensions/markdown-language- at (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at (node:internal/streams/readable:228:10) at TCP.onStreamRead (node:internal/streambase_commons:199:23)
Change:
return this.defaultValue; } if (typeof input === 'string') { <del> if (input === 'false') { </del> <ins> if (input === 'false' || input.length === 0) { </ins> return EditorFontLigatures.OFF; } if (input === 'true') {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- and I discovered that VSCode appears to automatically enable and when passing a string to githubnext/monaspace. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.2 OS Version: macOS 12.7.1 Steps to Reproduce: with an that supports ligatures Workarounds: Explicitly disable either ligature with or Screenshots of : <img width="1680" alt="empty" src=""<img width="1680" alt="'liga' on, 'calt' on" src=""<img width="1680" alt="'liga' off, 'calt' off" src=""
I'd appreciate a confirmation of whether this is a bug or intentional behavior, as it affects documentation for Monaspace.
Sorry for the delay, Nick. I noticed the following line and assigned Alex to this issue for further triaging.
I assume this is a bug then? And thanks, I did find that code, though I'm not sure why this is still happening:
Currently, is , we generate the CSS: is , we generate the CSS: is , we generate the CSS: is , we do not generate any CSS. The behavior of 4. then ends up being the default browser behavior.
Change:
this._transientWatchers[uri] = w; } <del> w.set(key, value); this._onDidChangeTransientModelProperty.fire(model); </del> <ins> const previousValue = w.get(key); if (previousValue !== value) { w.set(key, value); this._onDidChangeTransientModelProperty.fire(model); } </ins> } public getTransientModelProperty(model: ITextModel, key: string): any {

Discussion:
Does this issue occur when all extensions are disabled?: Yes Word wrap doesn't affect the text of the base in the merge editor, regardless of whether the base is displayed in the center or at the top. Steps to reproduce: a branch with a conflict the merge editor word wrap Base in the center ! Base at the top ! Version: 1.76.0-insider (system setup) Commit: Date: 2023-02-09T05:23:28.458Z OS: Windows_NT x64 10.0. Sandboxed: Yes
I'll pick this up