jiebi/CodeConvo huggingface dataset:
Change:
{ "command": "git.acceptMerge", "title": "%command.git.acceptMerge%", <del> "category": "Git" </del> <ins> "category": "Git", "enablement": "isMergeEditor" </ins> } ], "keybindings": [

Discussion:
a merge conflict. Open merge editor not react on any conficts. Click on Accept Merge shows up. The Yours / Theirs editors get empty in the background before I have reacted in the dialog If I click cancel now I am in a broken state. I can repro 100%. ! fyi
The accept command triggers a close of the merge editor and while that happens the confirm logic kicks in...
Problem is that the accept-command ignores that the editor didn't actually close and proceeded with staging the file. That triggers file events which empty input1/2
Looks good now -verified
Change:
/* NOTE: height is also used in searchWidget.ts as a constant*/ .search-view .search-widget .monaco-inputbox > .ibwrapper > textarea.input { overflow: initial; <del> height: 24px; /* set initial height before measure */ </del> <ins> height: 26px; /* set initial height before measure */ </ins> } .search-view .search-widget .monaco-findInput .monaco-scrollable-element .scrollbar {

Discussion:
Perhaps due to semi-opaque color being applied to multiple layers within the input: <img width="210" alt="CleanShot 2022-12-15 at 11 28 11 src="https://user-"<img width="289" alt="CleanShot 2022-12-15 at 11 28 23 src="https://user-"
The source control message input background does not seem to use color customization at all.
I saw it in there, but it's a fairly complex component under the hood and (I think) multiple layers of the component use it. Because the color is semi-opaque it's appearing brighter than it should be after mixing with one layer with another.
You can reproduce & verify that the colour is not applied to this particular input by setting color customization in your settings JSON to a bright red: Observe all other inputs having bright red backgrounds but the commit message input background still having the same background as the surrounding panel's background.
This is what I am seeing with the built-in theme, it looks like it completely blends with the panel's background. For me this is happening with all themes, built-in & third-party - the input's background inherits the panel's background and cannot be customised at all. !
It works for me. I don't see the behavior you do with a transparent background. I'm also noting that you have a different typeface used for the placeholder. That leads me to believe there is something else going on. Are you using any extensions that manipulate VS Code e.g. customize UI? <img width="314" alt="CleanShot 2022-12-15 at 13 26 22 src="https://user-"In any case this will be fixed by . I'd recommend opening up a separate issue for your specific problem.
It works for me too when I place SCM panel to the left sidebar, but when SCM panel is placed to the right sidebar then background colour theming is ignored on the input. I do not see this problem mentioned in . ! !
That one I can indeed repro. Can you file a new issue for that?
Done! Submitted as .
Change:
"prefix": "image", "body": "![${TM_SELECTED_TEXT:${1:alt}}](https://${2:link})$0", "description": "Insert image" <ins> }, "Insert strikethrough": { "prefix": "strikethrough", "body": "~~${1:${TM_SELECTED_TEXT}}~~", "description": "Insert strikethrough" </ins> } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --At the moment, the snippets for markdown cover most of the basic syntax, however there are no snippets for inserting different heading levels. For extended syntaxes, there are no snippets for tables, strikethrough, and task lists. I propose adding the following snippets to : I propose removing the "Insert heading" snippet. "Insert heading level 1" would does the same thing and would be consistent with the other heading levels snippets: I would modify the "Insert code" snippet to include the word "inline" in the name and description: I am happy to make a pull request for this if you wish?
I'd take a PR for the header and strike through snippets, along with the change to insert code Tables and tasklist are probably better for an extension (the built-in markdown preview doesn't support task lists)
Cool. I'll submit a PR for that then
I need to upgrade the RAM on my box to fufil the compile task, I only have 4GB atm It will be a week for me to sort this out.
Change:
try { const permalink = getLink(gitAPI, useSelection, getVscodeDevHost(), 'headlink', context, includeRange); if (permalink) { <del> return vscode.env.clipboard.writeText(encodeURI(permalink)); </del> <ins> return vscode.env.clipboard.writeText(permalink); </ins> } } catch (err) { vscode.window.showErrorMessage(err.message);

Discussion:
Testing Follow steps in but from a branch called . Opening a link puts you on branch.
Above was done using desktop client, seems to work when I do it from

Testing The links is: Steps: clone to local create a branch and push create files and "Copy link" open in browser = file does not open
Above was done using desktop client, seems to work when I do it from
+1 on this with: from VS Code Desktop... note, gave me the correct url:
+1 on this with this file generated from VS Code Desktop AND $,#L5
There is double encoding going on in this file link
Change:
darwinIcon: 'resources/darwin/code.icns', darwinBundleIdentifier: product.darwinBundleIdentifier, darwinApplicationCategoryType: 'public.app-category.developer-tools', <ins> darwinHelpBookFolder: 'VS Code HelpBook', darwinHelpBookName: 'VS Code HelpBook', </ins> darwinBundleDocumentTypes: [{ name: product.nameLong + ' document', role: 'Editor',

Discussion:
If you search in the Help menu, it will show you general Mac help topics: ! None of these are from Code, but could be confused with Code-specific help, especially for certain search terms. Is it possible to disable this feature? !
please report against electron.
Response:
might know if we can add this to our plist
I would like to contribute. But I'm relatively new to OSS/git/VSCode. I might take some time/need help, but can I try fixing this?
Sure.
Found the root cause of the issue. TL;DR: This is blocked and needs to be flagged 'upstream' The build process for VS Code uses the plugin , which unfortunately doesn't expose the ability to alter the See Once the upstream plugin has been patched, it will be trivial to fix this issue. already found the answer; simply adding the keys &lt;keyCFBundleHelpBookFolder&lt;/key&lt;stringSurfWriter.Help&lt;/string&lt;keyCFBundleHelpBookName&lt;/key&lt;/string to the removes the macOS help suggestions. The author of 'gulp-atom-electron', is in this thread, so if I am wrong, please correct me! Until then though, I move to mark this as blocked/upstream and I will move on to something else. Boy was it fun tracking this down though!
Not so sure about that fix... Those keys seem too specific to the SurfWriter application. But don't be afraid of creating a PR for !
Surfwriter specifically isn't necessary (Not quite sure what the best value is, but I feel that creating a useful Help Book is a Story in and of itself!). I have attached a screen shot showing that even garbage values for the keys 'CFBundleHelperBookFolder' and 'CFBundleHelpBookName' produce the desired results, fulfilling this issue's requirements. I'm sure we want something other than garbage values though! Most likely, to point towards an empty HelpBook file in the VSCode src, then another story can be made to fill that with useful info. I'll be sure to take a look at this weekend! !
What values should we put to disable the menu?
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'vscode' { // https://github.com/microsoft/vscode/issues/179213 export class NotebookCodeActionKind { // can only return MULTI CELL workspaceEdits // ex: notebook.organizeImprots static readonly Notebook: CodeActionKind; constructor(value: string); } } </del>

Discussion:
Issue to document the final state of the CodeActionKind. Current proposition is as follows: A new top level kind will be introduced as , referenced as for extension authors and core usage If a notebook CodeAction is called against a notebook, it will ONLY be called against the first cell of the notebook, and will precede the standard source CodeActions that will run against each cell in asynchronously. This is to ensure that all edits involving multiple cells will be addressed before any per cell action is taken. (ex: move all imports to top of notebook, normalize variable names, source.organizeImports, etc.) Extension authors will be recommended via documentation in to use one of the following notations to create their kind: - The following also works, but is less explicit: - Extension authors will be expected to register their provider with an adequate , as well as that contains the field The following will be to : thank you
Change:
import { IViewletService } from 'vs/workbench/services/viewlet/browser/viewlet'; import { normalize } from 'vs/base/common/paths'; import { IEditorGroupsService } from 'vs/workbench/services/group/common/editorGroupsService'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> export function isSearchViewFocused(viewletService: IViewletService, panelService: IPanelService): boolean { let searchView = getSearchView(viewletService, panelService);

Discussion:
I think it should be possible to disable "Replace Preview" in the settings. Currently, whenever I want to replace a word, the "Replace Preview" opens for every file, because I have file preview disabled.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.546 --- <!-- score: 0.535 --- <!-- score: 0.489 --- <!-- score: 0.473 --- <!-- score: 0.46 --<!-- potentialduplicatescomment --
Are you talking about the diff editor that opens when you click a result? What do you expect to see in that case?
Yes that's what I'm talking about. I would like to see just the file without a diff, maybe with the matches highlighted as I navigate through them in the search sidebar. Then when I click on replacing the text it would just replace it directly.
This seems reasonable and I would take a PR that adds a setting to disable the replace preview. FYI Starting point: and
I'd like to take a look at this.
Change:
type = 'information'; options.modal = false; break; <ins> case GitErrorCodes.CherryPickEmpty: message = l10n.t('The changes are already present in the current branch.'); choices.clear(); type = 'information'; options.modal = false; break; </ins> default: { const hint = (err.stderr || err.message || String(err)) .replace(/^error: /mi, '')

Discussion:
Testing ! After pressing "Cancel" here I would have expected my changes view to be clean, but I was still in cherry-pick mode and had to run
I am still left in a state that is not clean: !
Can you please click on "Show Command Output" and share the output. Cannot pause the git to actually read it...
There are two distinct scenarios that may result in a cherry pick failing: are already present. In this case we will abort the cherry-pick operation. conflict (second scenario that you have shared). In this case VS Code will show a notification and users will have to manually resolve the merge conflict (code lens or merge editor) before committing. This aligns with the merge/rebase flows already present.
Change:
index!: number; item!: IQuickPickItem; saneLabel!: string; <ins> saneSortLabel!: string; </ins> saneMeta!: string; saneAriaLabel!: string; saneDescription?: string;

Discussion:
Create or Checkout a PR Click on the branch indicator in the status bar Type Observe that doesn't show in top position Not sure what changed, but this used to work reliably until today, this was the main way I used to go back to the branch: <img width="1078" alt="image" src="https://user-"
We have an icon to the quick pick items but I would like to think that this did not break search. Will investigate.
Change:
super(); this._layoutInfo = this._editor.getLayoutInfo(); this._rootDomNode = document.createElement('div'); <del> this._rootDomNode.className = 'sticky-widget'; </del> this._rootDomNode.classList.toggle('peek', _editor instanceof EmbeddedCodeEditorWidget); this._rootDomNode.style.width = `${this._layoutInfo.width - this._layoutInfo.minimap.minimapCanvasOuterWidth - this._layoutInfo.verticalScrollbarWidth}px`; <ins> this._rootDomNode.className = 'sticky-widget-root'; this._scrollbar = this._register(new DomScrollableElement(this._rootDomNode, { consumeMouseWheelIfScrollbarIsNeeded: true, vertical: ScrollbarVisibility.Hidden, handleMouseWheel: false })); this._scrollableDomNode.appendChild(this._scrollbar.getDomNode()); this._scrollableDomNode.className = 'sticky-widget-scroll'; this._register(dom.addDisposableListener(this._scrollbar.getDomNode(), dom.EventType.MOUSE_OVER, () => { this._scrollbar.scanDomNode(); })); this._register(this._editor.onDidLayoutChange(() => { this._scrollbar.scanDomNode(); })); this._scrollbar.scanDomNode(); </ins> } get hoverOnLine(): number {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello So I have noticed when using Sticky Scroll, any line which is too long (for example the screenshot below), it would block off the rest of the code. A feature I was thinking would be a good adition is sideways scrolling (like what happens already in the main editor) so that people can see what else is in that line. <kbd<img src="https://user-"/</kbd
Change:
import { AccessibilitySupport, IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { Action2, registerAction2 } from 'vs/platform/actions/common/actions'; import { TabFocus, TabFocusContext } from 'vs/editor/browser/config/tabFocus'; <ins> import { accessibilityHelpIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; </ins> const CONTEXT_ACCESSIBILITY_WIDGET_VISIBLE = new RawContextKey<boolean>('accessibilityHelpWidgetVisible', false);

Discussion:
Testing ! Shows Ctrl + e , but that is mapped to "Go to file"
your image didn't work
Updated the image.
Verified with Windows.
Verified that this is now working with Linux and Orca
Change:
// Examples: // - Ruby stack traces: <link>:in ... // - Grep output: <link>:<result line> <del> text = text.replace(/:[^d]+$/, ''); </del> <ins> // This only happens when the colon is _not_ followed by a forward- or back-slash as that // would break absolute Windows paths (eg. `C:/Users/...`). text = text.replace(/:[^/][^d]+$/, ''); </ins> // If any of the names of the folders in the workspace matches // a prefix of the link, remove that prefix and continue

Discussion:
This link: ! Is opening: !
This isn't as bad as I thought and may not be a regression. That file doesn't actually exist. We should still be filling in the whole thing into the quick pick for the search
It is a regression, it's because of changing this from removing to , that breaks absolute Windows paths.
To verify, test these cases on Windows: - -
Change:
env?: { [key: string]: string }; encoding?: string; /** <del> * Whether to use the experimental ConPTY system on Windows. When this is not set, ConPTY will * be used when the Windows build number is >= 18309 (it's available in 17134 and 17692 but is * too unstable to enable by default). </del> <ins> * Whether to use the ConPTY system on Windows. When this is not set, ConPTY will be used when * the Windows build number is >= 18309 (instead of winpty). Note that ConPTY is available from * build 17134 but is too unstable to enable by default. </ins> * * This setting does nothing on non-Windows. */ <del> experimentalUseConpty?: boolean; </del> <ins> useConpty?: boolean; </ins> /** * Whether to use PSEUDOCONSOLE_INHERIT_CURSOR in conpty. * @see https://docs.microsoft.com/en-us/windows/console/createpseudoconsole

Discussion:
An issue with the node-pty update caused the conpty setting to not do anything, instead reverting to the node-pty default for conpty (always when Windows + is being used). Since I've recommended using that setting as a workaround for certain ConPTY issues (like ), this feels like it meets the bar for 1.40.
To verify on a Window 10 build + machine (run ver to check build number): to true and verify that a conpty process gets created. Check the process explorer for conpty process. it to false and verify a winpty process gets created. conpty processes look like the ones in red under the window, winpty are in blue: !
Closing to make sure this shows up in our verification query. Testing now
Moved to recovery as we didn't want to push the release out another day.
Change:
import { ITerminalInstance } from 'vs/workbench/contrib/terminal/browser/terminal'; import { MENU_TERMINAL_CHAT_INPUT, MENU_TERMINAL_CHAT_WIDGET, MENU_TERMINAL_CHAT_WIDGET_FEEDBACK, MENU_TERMINAL_CHAT_WIDGET_STATUS, TerminalChatContextKeys } from 'vs/workbench/contrib/terminalContrib/chat/browser/terminalChat'; <ins> const widgetHeightMargin = 100; const widgetWidthMargin = 40; </ins> export class TerminalChatWidget extends Disposable { private readonly _container: HTMLElement;

Discussion:
Repro: terminal chat "list files in various ways", content is clipped at bottom but scrolling doesn't work !

Repro: terminal chat "list files in various ways" height of terminal !
, we'd need a way to set max height for the chat widget, which there isn't currently AFAICT
You need to call layout with the sizes you want
i tried that and didn't see the height taking effect, only the width.
Change:
workbenchRegistry.registerWorkbenchContribution(ExtensionEnablementWorkspaceTrustTransitionParticipant, LifecyclePhase.Restored); workbenchRegistry.registerWorkbenchContribution(ExtensionsCompletionItemsProvider, LifecyclePhase.Restored); workbenchRegistry.registerWorkbenchContribution(UnsupportedExtensionsMigrationContrib, LifecyclePhase.Eventually); <ins> workbenchRegistry.registerWorkbenchContribution(DeprecatedExtensionsChecker, LifecyclePhase.Eventually); </ins> if (isWeb) { workbenchRegistry.registerWorkbenchContribution(ExtensionStorageCleaner, LifecyclePhase.Eventually); }

Discussion:
Currently if a user has a deprecated extension installed we just render that in the Extensions view. Looking at telemetry we noticed that users this is not a strong signal, and users still have a lot of deprecated extensions installed. Due to that I suggest that we nudge the users more about deprecated extensions. Especially if the deprecated extension has an alternative. As suggests we could show a general depreciation prompt if users have deprecated extensions installed and allowing not to show this prompt again. However I would love if the notification prompt offers the transition to the alternative extension if there is one. So not sure if it would be notification per deprecated extension? What do you think?
I think the notification is a general one guiding users to extensions view to see deprecated extensions. Users can take a necessary action from there.
Ok. It would be nice if the flow is smooth, for example there is an action that opens the correct extension in the Extensions view. But I guess you already have that in mind :)
Yes, there will be an action to list the deprecated extensions.
To verify: Shutdown VS Code Insiders From CLI install extension Open Insiders and wait until you get the prompt <img width="515" alt="image" src="https://user-"
Change:
this.handleActiveEditorChange(activeEditorGroup, activeEditorPane); // Listen to selection changes if the editor pane <del> // is having a selection concept. We use `accumulate` // on the event to reduce the pressure on the editor // to reduce input latency. </del> <ins> // is having a selection concept. </ins> if (isEditorPaneWithSelection(activeEditorPane)) { <del> this.activeEditorListeners.add(Event.accumulate(activeEditorPane.onDidChangeSelection)(e => this.handleActiveEditorSelectionChangeEvents(activeEditorGroup, activeEditorPane, e))); </del> <ins> this.activeEditorListeners.add(activeEditorPane.onDidChangeSelection(e => this.handleActiveEditorSelectionChangeEvent(activeEditorGroup, activeEditorPane, e))); </ins> } // Context keys

Discussion:
Steps: configure close all editors reload window open -click of line 11 -click -click pick "Go back in navigation locations" from commands as long as you can you cannot reach back into
this is caused by
Change:
dependencies: find-up "^4.0.0" <del> playwright@1.12.3: version "1.12.3" resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.12.3.tgz#113afa2cba10fb56e9a5b307377343e32a155a99" integrity sha512-eyhHvZV7dMAUltqjQsgJ9CjZM8dznzN1+rcfCI6W6lfQ7IlPvTFGLuKOCcI4ETbjfbxqaS5FKIkb1WDDzq2Nww== </del> <ins> playwright@1.14.1: version "1.14.1" resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.14.1.tgz#73913d3044a85a58edf13148245279231072532e" integrity sha512-JYNjhwWcfsBkg0FMGLbFO9e58FVdmICE4k97/glIQV7cBULL7oxNjRQC7Ffe+Y70XVNnP0HSJLaA0W5SukyftQ== </ins> dependencies: commander "^6.1.0" debug "^4.1.1"

Discussion:
This code seems to reach into the module: When trying to update to the file is no longer found and seems gone.
Change:
childNodes.push({ kind: 'variable', notebook: parent.notebook, <del> id: parent.id + `${limit + 1}`, </del> <ins> id: parent.id + `${last + 1}`, </ins> extHostId: parent.extHostId, name: localize('notebook.indexedChildrenLimitReached', "Display limit reached"), value: '',

Discussion:
viewing a very long list in the variables viewer will not show all entries. debug variables view handles this with nested groups: <img width="231" alt="image" src=""
verification steps: the notebook variable view with the cell the variable view in the debug sideview check that the children of the variable are accurate