jiebi/CodeConvo huggingface dataset:
Change:
result.responseCompletePromise.then(async () => { const responses = this.viewModel?.getItems().filter(isResponseVM); const lastResponse = responses?.[responses.length - 1]; <del> this._chatAccessibilityService.acceptResponse(lastResponse); </del> <ins> this._chatAccessibilityService.acceptResponse(lastResponse, requestId); </ins> }); } else { <del> this._chatAccessibilityService.acceptResponse(); </del> <ins> this._chatAccessibilityService.acceptResponse(undefined, requestId); </ins> } } }

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.
Change:
if (window.isReady) { this.lifecycleMainService.unload(window, UnloadReason.LOAD).then(async veto => { if (!veto) { <del> await this.doOpenInBrowserWindow(window!, configuration, options); </del> <ins> await this.doOpenInBrowserWindow(window!, configuration, options, defaultProfile); </ins> } }); } else { <del> await this.doOpenInBrowserWindow(window, configuration, options); </del> <ins> await this.doOpenInBrowserWindow(window, configuration, options, defaultProfile); </ins> } return window; } <del> private async doOpenInBrowserWindow(window: ICodeWindow, configuration: INativeWindowConfiguration, options: IOpenBrowserWindowOptions): Promise<void> { </del> <ins> private async doOpenInBrowserWindow(window: ICodeWindow, configuration: INativeWindowConfiguration, options: IOpenBrowserWindowOptions, defaultProfile: IUserDataProfile): Promise<void> { </ins> // Register window for backups unless the window // is for extension development, where we do not

Discussion:
I know I suggested but after trying it out I am convinced that was a wrong suggestion. I think we should just revert it, and whenever we open a new folder it should be using the CURRENT profile. I know and feel the same.
Lets discuss this!
Actually I liked this behaviour too. Reverted this after our discussion. Bringing this back again :)
Awesome - thanks!
Is it possible to associate a workspace (or folder) with a profile? E.g. can I set that if I open a workspace (or folder) "A", current profile will be switched to "Default" and if I open a workspace "B", current profile will be switched to "Work"?
Well, it seems to be already working:
Change:
model, languageConfigurationService ); <ins> // Modify range depending on if brackets are added or removed const diff = insertText.length - item.insertText.length; if (diff !== 0) { range = new Range(range.startLineNumber, range.startColumn, range.endLineNumber, range.endColumn + diff); } </ins> } snippetInfo = undefined;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69 OS Version: Windows_NT x64 10.0. Steps to Reproduce: When the completion contains incomplete bracketPairs, the VS Code API corrects them, but the range is not updated so the tabbing behavior doesn't work as expected. Additionally, the grey text shown is also not shown accurately. Example 1: The code context is React.useEffect(() ={ fetch("/api") .then((res) ()) }) ! In this GIF, the insertText provided is . When the completion is accepted using Tab, the don't get accepted. If the code on the line is , the insertText is and the cursor is marked by , then the completion shows up as ! Example 2: A simpler case is when code on the line is , the completion shown is . When the user hits Tab to accept, their cursor is taken between . If the insertText is at this point, it will be closed by the API. But the range is not updated to match the already existing and so it shows up as grey text. ! cc
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks for the issue and the PR! I'll get it in in the next release, as we already have feature-freeze and focus on fixing bugs in new features.

hmm should this be assigned to the July milestone since i see it is merged to main? And thus it will be part of the upcoming stable release in 10 days? Thanks
https://user-
The autocomplete text no longer has the parentheses, but the description does. Is it expected that they don't get completed ?
You have to try this with the intellicode extension. I suggest to get this validated by
Were you able to repro the bug you found with the Intellicode-Completions extension installed? I cannot repro it on my end.
Change:
// Persist terminal _buffer state_, note that even if this happens the dirty terminal prompt // still shows as that cannot be revived <del> this._shutdownWindowCount = await this._nativeDelegate?.getWindowCount(); const shouldReviveProcesses = this._shouldReviveProcesses(reason); if (shouldReviveProcesses) { await this._primaryOffProcessTerminalService?.persistTerminalState(); } // Persist terminal _processes_ const shouldPersistProcesses = this._configHelper.config.enablePersistentSessions && reason === ShutdownReason.RELOAD; if (!shouldPersistProcesses) { const hasDirtyInstances = ( (this.configHelper.config.confirmOnExit === 'always' && this.instances.length > 0) || (this.configHelper.config.confirmOnExit === 'hasChildProcesses' && this.instances.some(e => e.hasChildProcesses)) ); if (hasDirtyInstances) { return this._onBeforeShutdownConfirmation(reason); </del> <ins> try { this._shutdownWindowCount = await this._nativeDelegate?.getWindowCount(); const shouldReviveProcesses = this._shouldReviveProcesses(reason); if (shouldReviveProcesses) { await this._primaryOffProcessTerminalService?.persistTerminalState(); } // Persist terminal _processes_ const shouldPersistProcesses = this._configHelper.config.enablePersistentSessions && reason === ShutdownReason.RELOAD; if (!shouldPersistProcesses) { const hasDirtyInstances = ( (this.configHelper.config.confirmOnExit === 'always' && this.instances.length > 0) || (this.configHelper.config.confirmOnExit === 'hasChildProcesses' && this.instances.some(e => e.hasChildProcesses)) ); if (hasDirtyInstances) { return this._onBeforeShutdownConfirmation(reason); } </ins> } <ins> } catch (err: unknown) { // Swallow as exceptions should not cause a veto to prevent shutdown this._logService.warn('Exception occurred during terminal shutdown', err); </ins> } this._isShuttingDown = true;

Discussion:
From Run the command Enter: In the eventual modal dialog, press Expecting a window reload, but there is an error instead. You can also call the command I debugged it down to veto from terminal. Exception thrown while serializing the terminal: The veto hander should handle all exceptions and return false, unless it really wants to veto the window close.
Closing for verification as it looks like this has been merged into release/1.62
Remote connection is going in a restarting loop. Restart remote connection is the only thing that we are getting now. Not possible to work at all with vscode.
Change:
.monaco-editor .peekview-widget .head .peekview-title .codicon { margin-right: 4px; <ins> align-self: center; </ins> } .monaco-editor .peekview-widget .monaco-list .monaco-list-row.focused .codicon {

Discussion:
VS Code Version: 1.73.1 OS Version: Win 11 Steps to Reproduce: the PeekViewWidget (eg using Peek Definition, or Show Error) text in the title bar is misaligned Fix: I have a PR, it's trivial. !
Change:
} registerAction2(NotebookIndentUsingSpaces); <ins> registerAction2(NotebookIndentUsingTabs); registerAction2(NotebookChangeTabDisplaySize); registerAction2(NotebookIndentationToSpacesAction); registerAction2(NotebookIndentationToTabsAction); </ins>

Discussion:
to repro: click notebook indentations statusbar entry run "indent using spaces/tabs" and select a new number entry will not update, however indentations work correctly given the selection that the user made and the current settings.

No a "choose intentation type" entry in status bar when editing in a notebook. I have a notebook with tab indentation but it seems theres some global spaces setting that overrides it... even pasting a literal tab charachter inserts spaces :/ !
False alarm. The status bar entry just moved so much that I didn't see it right away, and it has a different name in the status bar entries context menu.
Actually, looks like the status bar is really slow to update. I saw it update eventually, but I'm not sure what caused it to finally show the correct thing. !
Change:
begin CreateMutex('{#AppMutex}-ready'); <ins> Log('Checking whether application is still running...'); </ins> while (CheckForMutexes('{#AppMutex}')) do begin <del> Log('Application is still running, waiting'); </del> Sleep(1000) end; <ins> Log('Application appears not to be running.'); </ins> StopTunnelServiceIfNeeded();

Discussion:
Type: <bBug</bThe VS Code update process appears to write to log files named . It appends a new line once every second as it waits for a running instance of VS Code to be closed. Here's a snippet from a current file on my machine: I basically always have VS Code running, and sometimes don't close it for weeks at a time, and just found that I had over 200MB of log files mostly filled with lines like the above. VS Code version: Code 1.81.1 (, 2023-08-09T22:22:42.175Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Change:
getDragLabel?(elements: T[], originalEvent: DragEvent): string | undefined; onDragStart?(data: IDragAndDropData, originalEvent: DragEvent): void; onDragOver(data: IDragAndDropData, targetElement: T | undefined, targetIndex: number | undefined, originalEvent: DragEvent): boolean | IListDragOverReaction; <ins> onDragLeave?(data: IDragAndDropData, targetElement: T | undefined, targetIndex: number | undefined, originalEvent: DragEvent): void; </ins> drop(data: IDragAndDropData, targetElement: T | undefined, targetIndex: number | undefined, originalEvent: DragEvent): void; onDragEnd?(originalEvent: DragEvent): void; }

Discussion:
Repro: 2 terminals dragging one it into the actual terminal and pass over the other tab briefly, it will get focused even though the mouse didn't stay there for long enough !
Change:
readonly src: IconFontSource[]; } <ins> export namespace IconFontDefinition { export function toJSONObject(iconFont: IconFontDefinition): any { return { weight: iconFont.weight, style: iconFont.style, src: iconFont.src.map(s => ({ format: s.format, location: s.location.toString() })) }; } export function fromJSONObject(json: any): IconFontDefinition | undefined { const stringOrUndef = (s: any) => isString(s) ? s : undefined; if (json && Array.isArray(json.src) && json.src.every((s: any) => isString(s.format) && isString(s.location))) { return { weight: stringOrUndef(json.weight), style: stringOrUndef(json.style), src: json.src.map((s: any) => ({ format: s.format, location: URI.parse(s.location) })) }; } return undefined; } } </ins> export interface IconFontSource { readonly location: URI; readonly format: string;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.0 OS Version: Windows 11 21H2 Steps to Reproduce: a window another window with and observe that product icon themes don't load immediately and you are shown the default ones for a short while. https://user- The video above contains an example of this issue happening. If it matters, I am using the Fluent Icons product icon theme.
Why does this have the feature request label? This is a bug.
Change:
{ "command": "git.timeline.openCommit", "title": "%command.timelineOpenCommit%", <del> "icon": "$(search)", </del> <ins> "icon": "$(tasklist)", </ins> "category": "Git" }, {

Discussion:
I found it confusing that the icon for opening multi-diff editor is a magnifying glass. Should it maybe match GHPR's icon or have some other icon? !
Fixed in , uses this icon now: ! FYI Maybe we should create a new icon for this though
Change:
default: 'fullCell' }, [NotebookSetting.anchorToFocusedCell]: { <del> markdownDescription: nls.localize('notebook.scrolling.anchorToFocusedCell.description', "Keep the focused cell steady while surrounding cells change size"), </del> <ins> markdownDescription: nls.localize('notebook.scrolling.anchorToFocusedCell.description', "Keep the focused cell steady while surrounding cells change size."), </ins> type: 'string', <del> enum: ['auto', 'true', 'false'], </del> <ins> enum: ['auto', 'on', 'off'], </ins> markdownEnumDescriptions: [ <del> nls.localize('notebook.scrolling.anchorToFocusedCell.auto.description', "Anchor to the focused cell when the resized cell is partially visible unless {0} is set to {1}", 'notebook.scrolling.revealCellBehavior', 'none') </del> <ins> nls.localize('notebook.scrolling.anchorToFocusedCell.auto.description', "Anchor the viewport to the focused cell depending on context unless {0} is set to {1}.", 'notebook.scrolling.revealCellBehavior', 'none'), nls.localize('notebook.scrolling.anchorToFocusedCell.on.description', "Always anchor the viewport to the focused cell."), nls.localize('notebook.scrolling.anchorToFocusedCell.off.description', "The focused cell may shift around as cells resize.") </ins> ], default: 'auto' }

Discussion:
Testing This setting seems like overkill to me and there is a good behavior we should be aiming towards which is notebook.scrolling.anchorToFocusedCell = auto. You could also do something clever like disable the anchoring when a user starts scrolling, and when they focus a cell or type it re-enables the anchoring. I rarely use notebooks but to me this seems like a setting that will see very low usage and is not worth the cost of an extra setting imo. Note that anchorToFocusedCell = auto doesn't work as expected currently, the setting only seems to do anything after I scroll: !
I can change the setting to be experimental to give more leniency to change/remove it, but the behaviors are very different, so we'd like to give users a way to both experiment and revert back in case we missed some case of bad behavior
I like the idea of using experimental and seeing how many users change it to see if it's worth a setting

Testing We don't normally use "false" and "true" as strings, so this looks wrong beside all my other settings: !
Change:
private _onDidChangeTaskConfig: Emitter<void> = new Emitter(); public onDidChangeTaskConfig: Event<void> = this._onDidChangeTaskConfig.event; public get isReconnected(): boolean { return this._tasksReconnected; } <ins> private _onDidChangeTaskProviders = this._register(new Emitter<void>()); public onDidChangeTaskProviders = this._onDidChangeTaskProviders.event; </ins> constructor( @IConfigurationService private readonly _configurationService: IConfigurationService,

Discussion:
a repo in :bug: see this !
This is expected if the repo that you open has tasks that run on . Could you pls provide me with a repo for which this happens that doesn't have those?
seeing this dialog when I just open a folder, so wondering if something with workspace trust has changed recently. No changes with tasks recently could explain this. !
Doesn't repro in , repros in : Bad: Good:
found these task PRs in that time frame: ,
found it also happens in an empty window on desktop
Still seeing this in (and also RemoteHub on desktop) with the changes in !
This is coming from -here. perhaps we don't want to do that for the or only do that in trusted workspaces? !
Change:
import { coalesce } from 'vs/base/common/arrays'; import { extractEditorsAndFilesDropData } from 'vs/platform/dnd/browser/dnd'; import { extname } from 'vs/base/common/resources'; <ins> import { areSameExtensions } from 'vs/platform/extensionManagement/common/extensionManagementUtil'; </ins> const SearchMarketplaceExtensionsContext = new RawContextKey<boolean>('searchMarketplaceExtensions', false); const SearchIntalledExtensionsContext = new RawContextKey<boolean>('searchInstalledExtensions', false);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --When installing an extensions with , users can freely install extensions which are malicious, which is not possible from the UI. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0 OS Version: macOS 13 Steps to Reproduce: your 's to . a terminal inside of VS Code The CLI either refuses to install these extensions or warns the user.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Sorry, mistyped the version by one patch release, all fixed now.
Can you please let me know which extension you are trying to install that is malicious and VS Code allows it from CLI?
that would be any extension list that I tried and exists in the Marketplace, for example installs just fine although not allowing me to install via the UI <img width="725" alt="image" src="https://user-"
Change:
const linkStart = document.positionAt(offset); const linkEnd = document.positionAt(offset + link.length); try { <del> const linkTarget = parseLink(document, link); </del> <ins> const linkTarget = resolveLink(document, link); </ins> if (!linkTarget) { return undefined; }

Discussion:
while testing a markdown file with a header a notebook with a markdown cell and link to that header the link in the rendered markdown result: vscode attempts to navigate to a file named note that both auto-complete and find references for the header work correctly for that link.
Change:
export interface IGitHubServer { login(scopes: string): Promise<string>; <ins> logout(session: vscode.AuthenticationSession): Promise<void>; </ins> getUserInfo(token: string): Promise<{ id: string; accountName: string }>; sendAdditionalTelemetryInfo(session: vscode.AuthenticationSession): Promise<void>; friendlyName: string;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Currently signing out of your GitHub account only removes the token from the secret store but the token continues to be valid, which means that if it was leaked the attacker can continue to make use of it. To mitigate this, VS Code should revoke the token on sign out, see this API:
I wish this API didn't require the client secret...
Change:
this.filterText = this.getFilterText(completionContext.line, tsEntry.insertText); if (completionContext.isMemberCompletion && completionContext.dotAccessorContext && !(this.insertText instanceof vscode.SnippetString)) { <del> this.filterText = completionContext.dotAccessorContext.text + (this.insertText || typeof this.label === 'string' ? this.label : this.label.label); </del> <ins> this.filterText = completionContext.dotAccessorContext.text + (this.insertText || this.textLabel); </ins> if (!this.range) { const replacementRange = this.getFuzzyWordRange(); if (replacementRange) {

Discussion:
I took one of the suggested results from intellisense and it inserted a literal star symbol into my code ]()
I also have been seeing this since yesterday, using JS specifically The star has always been present in the intellisense list, but never included in the text filled in.
Also reproduced this behaviour while verifying another issue !
This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the for VS Code. See also our . If you don't know which extension is causing the problem, you can run from the command palette (F1) to help identify the problem extension. Happy Coding!
Caused by IntelliCode:
This issue only occurs in Insiders, and does not occur in Stable. Downgrading to an older version of the extension also does not fix the issue. Therefore, I'm wondering whether the completions API implementation changed. the IntelliCode extension (VisualStudioExptTeam.vscodeintellicode). a new JS file. and wait for the IntelliCode completions to show up. If they don't show up, backspace and try again. The IntelliCode completions will have a star in front of them. one of the IntelliCode completions. :bug: In Insiders, the star character is to the editor.
I've disabled Microsoft Intellicode (AI-assisted development, ID: VisualStudioExptTeam.vscodeintellicode) until they fix it back. All good for know.
This is somehow happening in the TypeScript extension. In the UI, when inserting the completion, we have an insert text with a leading . So, the UI is doing what it is told to do. <img width="1403" alt="Screenshot 2023-01-27 at 09 30 21" src="https://user-"Seemingly, in the TS extension the right data is received but somehow a wrong API completion is generated <img width="628" alt="Screenshot 2023-01-27 at 09 34 39" src="https://user-"
Mostly likely regressed via
Confirmed. This is the faulty statement The OR-statement binds stronger than the ternary operator and therefore the label always replaces the insertText