jiebi/CodeConvo huggingface dataset:
Change:
export class ExtensionsActivator implements IDisposable { <del> private _isDisposed: boolean; </del> private readonly _registry: ExtensionDescriptionRegistry; private readonly _resolvedExtensionsSet: Set<string>; private readonly _externalExtensionsMap: Map<string, ExtensionIdentifier>; private readonly _host: IExtensionsActivatorHost; <del> private readonly _activatingExtensions: Map<string, Promise<void>>; private readonly _activatedExtensions: Map<string, ActivatedExtension>; </del> <ins> private readonly _operations: Map<string, ActivationOperation>; </ins> /** * A map of already activated events to speed things up if the same activation event is triggered multiple times. */

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0 OS Version: Fedora 35 Steps to Reproduce: extension (v11.10.0) vscode, git extension is not initialized and restart, git extension works again With vscode-icons disabled With vscode-icons enabled
Reproduces with the following extension: : :
Change:
}; module.exports.removeGlobalNodeModuleLookupPaths = function () { <ins> if (typeof process?.versions?.electron === 'string') { return; // Electron disables global search paths in https://github.com/electron/electron/blob/3186c2f0efa92d275dc3d57b5a14a60ed3846b0e/shell/common/node_bindings.cc#L653 } // TODO@esm this might not work anymore (https://github.com/microsoft/vscode/issues/226042) </ins> const Module = require('module'); // @ts-ignore const globalPaths = Module.globalPaths;

Discussion:
Today we have a method to reduce global paths for module lookup in We have to revisit if this solution still works when ESM is on by default. Refs:
This actually still seems to work even in ESM for the reason we it. A test with an extension prints (taken from ): vs.
Change:
} } <del> private readonly _dataStore = new DisposableStore(); </del> <ins> private readonly _dataStore = this._register(new DisposableStore()); </ins> private _data: TemplateData | undefined;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Steps to Reproduce: Open VS Code repo in insiders 7 files to add just one a new line anywhere multi-file diff from SCM and ensure all 7 files are visible (if not zoom out until all are visible) diff view multi-file diff view again & the editor pane is blank (with error notification at the bottom
Change:
* @return A {@link Disposable} that unsets this configuration. */ export function setLanguageConfiguration(language: string, configuration: LanguageConfiguration): Disposable; } /**

Discussion:
(edited by We use this issue to track the progress of the Inline Completions API. The currently proposed API can be found in . There is a sample extension . Before this API can be finalized, we need to figure out these items at least: [x] How can inline completions interact with completions? (Currently, inline completions are hidden when autocomplete shows up and if there is an inline completion, autocomplete does not show up automatically)
why is this proposal not still open? Normally for proposals, we keep them open until the api is finalized and shipped. So that users/extension authors can track the proposal more easily.
Trying to copy and get 404. Is this link dead? This makes the sample in vscode: useless as well. Can you please help?
They have an updated way to get the file. First you have to change the to in the file. Then run to download the latest version of and then run . See more (if the link doesn't scroll down to the "updated api proposal structure" you have to control f it).
Hi folks! Is the API still likely to be released in April as mentioned in ?
it is currently assigned to April and that is our plan. It might slip to May depending on how testing and feedback from Extensions that use this proposed API goes. I suggest to follow this issue for more details. Thanks!
Hello! While trying out the sample package (). I receive the following errors. I also attempted the method you specified and the methods mentioned in the readme. In addition, I also tried the following npm commands: Npm install Npm run postinstall Is this sample still up to date?
good catch. I have tackled the outdated extension via this PR Once we get it approved I will merge it in and then the sample should be up to date. Thanks
Looks like this is on mainline? Any idea when it will be released beyond insiders?
this is assigned to the May milestone. Which means it is part of our May release which usually gets shipped first 10 days of the following month. So this one should be available on Thursday.
amazing! Thanks so much for getting back to me, I'll be deving accordingly :)
I have opened this discussion for any follow up questions since we have done the finalization
Change:
constructor() { super({ id: 'workbench.files.action.createFileFromExplorer', <del> title: nls.localize('createNewFile', "New File"), </del> <ins> title: nls.localize('createNewFile', "New File..."), </ins> f1: false, icon: Codicon.newFile, precondition: ExplorerResourceNotReadonlyContext,

Discussion:
Related: Both need additional info: <img width="241" alt="Screen Shot 2021-04-27 at 4 55 10 AM" src="https://user-"
Any change I do in the explorer raises a user revolt. So could do this start of next milestone. Delete does not require additional user input (if I say do not ask again for prompt). So I think only should be However I would wait for the editor to change to be so they are aligned. fyi
Not so sure about the rules <img width="748" alt="Screenshot 2021-04-27 at 14 36 26" src="https://user-"
Finder is inconsistent; "Tags..." opens an inline pop similar to rename, but rename doesn't have the . It might not be the best example.
Using ... on actions when needing user input has been a consistent pattern we've used for named actions. So we should try to keep it consistent.
Will take this in start of next milestone
From a UX perspective it appears is used when a quick input is present but not when an inline edit widget is. So I believe that's why things like and do not have , so is the UX guideline that inline edit widgets also should have ?
I would say that any action that requires user input should use the . I am seeing the same for toolbar actions like new file/folder in the tooltip as well while the quick pick and app menu do show it. <img width="170" alt="CleanShot 2022-08-16 at 08 45 32 src="https://user-"<img width="202" alt="CleanShot 2022-08-16 at 08 45 40 src="https://user-"<img width="303" alt="CleanShot 2022-08-16 at 08 45 47 src="https://user-"
Change:
const theme = this._themeService.getColorTheme(); this._partSplashService.saveWindowSplash({ <ins> zoomLevel: this._configService.getValue<undefined>('window.zoomLevel'), </ins> baseTheme: getThemeTypeSelector(theme.type), colorInfo: { foreground: theme.getColor(foreground)?.toString(),

Discussion:
! cc
is this with latest from main, eg out of source? I believe there is no insiders with the larger titlebar (due to CC)
the activity bar also changes size... there must be more to it. I guess rapid render is getting wrong values. Do you use zoom?
Correct, this is main on OSS. Confirmed that I wasn't zoomed.
is there some conflict of zoom here? Even the watermark renders for a bit slightly enlarged before shrinking?
I can only reproduce with zoom enabled, e.g zoom in once or twice reload workbench rapid render but also water mark are wrongly sized during load
LGTM other than the window controls overlay (WCO), which is being tracked at
Change:
let hoverWidget: UpdatableHoverWidget | undefined; const hideHover = (disposeWidget: boolean, disposePreparation: boolean) => { <ins> const hadHover = hoverWidget !== undefined; </ins> if (disposeWidget) { hoverWidget?.dispose(); hoverWidget = undefined;

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-16T05:23:44.671Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes /assign <!-- generated by issue reporter --
Thanks! This is also a regression because we are only supposed to show it on files with decorations (such as source control) or overflowing text (such as ).
I don't get this custom hover ever. Can you please add steps to verify?
These custom hovers have been removed from product due to being too buggy at the moment. I will just mark this as verified as this feature isn't ready for testing yet.
Change:
import { INotificationService } from 'vs/platform/notification/common/notification'; import { IEditorService, SIDE_GROUP, ACTIVE_GROUP } from 'vs/workbench/services/editor/common/editorService'; import { fillInContextMenuActions } from 'vs/platform/actions/browser/menuItemActionItem'; <ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; </ins> export class FileDataSource implements IDataSource { constructor(

Discussion:
Looks like a regression: ! Compared to stable: !
Interestingly I do not see that in the editor context menu: !
see commit not in master
lgtm, we could merge this to June release via
Change:
return this.downstreamFileMatches().length; } <ins> recursiveMatchCount(): number { return this.downstreamFileMatches().reduce<number>((prev, match) => prev + match.count(), 0); } </ins> get query(): ITextQuery | null { return this._query; }

Discussion:
<img width="288" alt="image" src="https://user-"The search result counts previously showed the number of nodes directly under it, but it would be nice if it actually showed the number of nested matches.
Change:
const media = stepToExpand.media; const mediaElement = $<HTMLImageElement>('img'); <ins> clearNode(this.stepMediaComponent); </ins> this.stepMediaComponent.appendChild(mediaElement); mediaElement.setAttribute('alt', media.altText); this.updateMediaSourceForColorMode(mediaElement, media.path);

Discussion:
Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width="679" alt="Screen Shot 2021-08-23 at 11 19 37 PM" src="https://user-"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I would like to contribute to this. Can I help you with the issue?
Change:
} public onMouseDown(tree: _.ITree, element: any, event: mouse.IMouseEvent, origin: string = 'mouse'): boolean { <del> if (this.options.clickBehavior === ClickBehavior.ON_MOUSE_DOWN && event.leftButton) { </del> <ins> if (this.options.clickBehavior === ClickBehavior.ON_MOUSE_DOWN && (event.leftButton || event.middleButton)) { </ins> if (event.target) { if (event.target.tagName && event.target.tagName.toLowerCase() === 'input') { return false; // Ignore event if target is a form input field (avoids browser specific issues)

Discussion:
VSCode Version:1.6.1 OS Version:Windows 10 Pro x64 Steps to Reproduce: left sidebar on file item with middle mouse button be nice if it opened those files in new tabs
I just tried this with Sublime and it just seems to open the file like a normal left click. Would you expect in this case to not open the file in preview mode but pinned as real tab? Is that the difference to normal left click?
in my case when I click on a file in sidebar in most cases the file that opens reuses the active tab, that's what I'd like to avoid, if possible with middle click.
right, you know that you can configure this via
didm't know that, thanks, and sorry for the noise
I still think we should do something on middle mouse, even if we just open a file. Currently we seem to do nothing.
This actually applies to all our trees, not just the explorer. I think we should be consistent and support this for any tree. I like the idea of pinning the file when opening like that. This is something where contributors could chime in for a PR
I would like to work on this issue. As I am new to the project would appreciate any help. Here are some questions to start with: I've noticed that Search and Changes viewlets use 'selection' event instead of 'click','mousedown' events used by Debug, Explorer to open editor. Is it intented choice or we should try to be consistent across all the Trees? I would expect Expand/Collapse to still happen on middle mouse click. What do you think? Extensions seems to not support pin at all. Don't know if it's only on my version/environment. Opened an issue I've seen a comment in where we do not handle middle button event: "Give contents of the item a chance to handle this (e.g. open link in new tab)". I wonder if it's still a valid comment. I'm on Windows and i'm wondering if we expect the same behavior on Mac or we should have some Mac-specific treatment of middle button (Command button or smth?) Thanks.
I think middle-click should be translated into a selection event from the tree so that down stream components do not have to do anything special. I also think middle click should not opened pinned, but just normal. Can you explain?

I would try to convert it to a selection event and see how that behaves. I am fine with making this work the same on all OS.
: Sorry my comment about Extensions was actually referring . Specifically you cannot open more than one editor tab with extension. Submitter a PR fix for this issue. Thanks.
Change:
*--------------------------------------------------------------------------------------------*/ import * as dom from 'vs/base/browser/dom'; <del> import * as network from 'vs/base/common/network'; </del> import * as paths from 'vs/base/common/path'; import { CountBadge } from 'vs/base/browser/ui/countBadge/countBadge'; import { ResourceLabels, IResourceLabel } from 'vs/workbench/browser/labels';

Discussion:
Type: <bBug</bworkspace a new notebook a syntax or other error in a cell problems view bug There's an extra to the right of the notebook file title ! VS Code version: Code - Insiders 1.88.0-insider (Universal) (, 2024-03-25T05:50:56.142Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
It is also same in Search ! Probably this should be something handled by the CC
Its possible to omit in the label widget for because there we know we are in a file context and is not very meaningful for descriptions (change in ). But for the problems view there is an explicit call to with an explicit description passed in: I am not sure just changing to return or wouldn't break some assumptions we have. I would argue that is a valid relative label for a path that has no parent (as in this case). any reason is not used? Or maybe we need to enlist the cell scheme as well as we do for untitled scheme.
I do not remember why we have two branches here - and . Is there a general suggestion for this? I am looking for this before digging deep. Is there a way to know this?
Yeah I would pick the and see what breaks, but maybe there is something in the history of that change that could explain it? I think schemes are pretty much hardcoded, here unfortunately while the notebook scheme is , the cell schemes are not. is there a way to know if a cell scheme is untitled?
It goes back before we used to have label service. I was also not showing the of the resource if the resource has no file provider. Showing parent was introduced . I believe using is the right way to go. I also see Search doing the same.
Change:
import { EditorActivation } from 'vs/platform/editor/common/editor'; import { IInstantiationService, optional } from 'vs/platform/instantiation/common/instantiation'; import { IShellLaunchConfig, TerminalLocation } from 'vs/platform/terminal/common/terminal'; <del> import { IEditorInput, IEditorPane } from 'vs/workbench/common/editor'; </del> <ins> import { IEditorInput } from 'vs/workbench/common/editor'; </ins> import { IRemoteTerminalService, ITerminalEditorService, ITerminalInstance, ITerminalInstanceService } from 'vs/workbench/contrib/terminal/browser/terminal'; import { TerminalEditor } from 'vs/workbench/contrib/terminal/browser/terminalEditor'; import { TerminalEditorInput } from 'vs/workbench/contrib/terminal/browser/terminalEditorInput';

Discussion:
Context: Essentially instead of creating s we will assign URIs to the shell launch configs and only create the terminals when the input is created.
This should also include the fix for splitCwd support in terminal editors:
Change:
this._handleResourceOpening(data.href); } else { // uri with scheme <del> this._openUri(URI.parse(data.href)); </del> <ins> if (osPath.isAbsolute(data.href)) { this._openUri(URI.file(data.href)); } else { this._openUri(URI.parse(data.href)); } </ins> } break; }

Discussion:
Testing Windows path separator issue? <img width="509" alt="image" src="https://user-"<img width="643" alt="image" src="https://user-"
Change:
} attach(container: HTMLElement): void { <ins> const showLinkHover = this._configurationService.getValue(TerminalSettingId.ShowLinkHover); if (!showLinkHover) { return; } </ins> const target = new CellHoverTarget(container, this._targetOptions); const hover = this._hoverService.showHover({ target,

Discussion:
Forking off the setting part off from PR:
Hello, is this issue is still open. I am new to open source and wanted to contribute.
there's a PR open already for this one
Change:
this.handleAndRegisterCustomViewContainers(); this.handleAndRegisterCustomViews(); <ins> // Abstract tree has it's own implementation of triggering custom hover // TreeView uses it's own implementation due to setting focus inside the (markdown) </ins> let showTreeHoverCancellation = new CancellationTokenSource(); KeybindingsRegistry.registerCommandAndKeybindingRule({ id: 'workbench.action.showTreeHover',

Discussion:
macOS, VS Code Insiders into explorer focus via keyboard hover does not show. There is no command to trigger the custom hover to show Like the activity bar, we have to make sure that the custom hover can be accessed in the tree/list only with the keyboard.
Would you suggest adding a keybinding to toggle the visibility of the custom hover of the html element which has focus?
Yeah, ideally it is . The same shortcut that we use in the editor for showing the hover. So it is consistent and easy for user to understand that there is one shortcut which does the right thing everywhere.
Isn't this a duplicate of ? Btw we seem to be having this support for extension provided trees at least:
I think it's good to have this one separate to .
Solving this for all trees/lists is pretty hard as the tree/list does not know anything about the underlying elements being rendered. For extension trees it is much easier as they all consist of a label which the creates and controls.
One option could be to utilize the to get the tooltip. Currently it already provides
After further discussions we came to the conclusion that we would use the DOM tree to figure out if there is any custom hovers available and trigger the hover by dispatching a mouse event on the HTMLElement. This might seem rather hacky but it ensures the consumers of the tree only have to support hover once and lets the tree handle keyboard triggers. Handling focus is still tricky and a open problem. Until this focus problem is properly fixed the treeview will keep it's own implementation which directly uses the hover service and moves the focus into the hover. The treeview implementation of this has it's own flaws but will b kept for the meantime to not cause regressions.
Change:
minimum: -1, default: 30, }, <ins> [TerminalSettingId.LocalEchoEnabled]: { description: localize('terminal.integrated.localEchoEnabled', "When local echo should be enabled. This will override `terminal.integrated.localEchoLatencyThreshold`"), type: 'string', enum: ['on', 'off', 'auto'], enumDescriptions: [ localize('terminal.integrated.localEchoEnabled.on', "Always enabled"), localize('terminal.integrated.localEchoEnabled.off', "Always disabled"), localize('terminal.integrated.localEchoEnabled.auto', "Enabled only for remote workspaces") ], default: 'auto' }, </ins> [TerminalSettingId.LocalEchoExcludePrograms]: { description: localize('terminal.integrated.localEchoExcludePrograms', "Experimental: local echo will be disabled when any of these program names are found in the terminal title."), type: 'array',

Discussion:
There are too many issues with local echo and can really degrade the experience right now for local workspaces. We should add an on/off/auto setting where auto is disabled in local workspaces, so opt-in ssh in local terminal support is there.
what steps would we take to verify? Looks like there's a new setting?
I tested the setting