jiebi/CodeConvo huggingface dataset:
Change:
} runEditorCommand(_accessor: ServicesAccessor, editor: ICodeEditor) { <del> const stickyScrollController = StickyScrollController.get(editor); if (stickyScrollController) { stickyScrollController.goToFocused(); } </del> <ins> StickyScrollController.get(editor)?.goToFocused(); } } export class SelectEditor extends EditorAction2 { constructor() { super({ id: 'editor.action.selectEditor', title: { value: localize('selectEditor.title', "Select Editor"), original: 'Select Editor' }, precondition: ContextKeyExpr.has('config.editor.stickyScroll.enabled'), keybinding: { weight, primary: KeyCode.Escape } }); } runEditorCommand(_accessor: ServicesAccessor, editor: ICodeEditor) { StickyScrollController.get(editor)?.selectEditor(); </ins> } }

Discussion:
Testing around an open file in the editor with Stick Scroll enabled. Sticky Scroll Try to move focus out of Sticky Scroll. Tried pressing . Tried running "Focus Sticky Scroll" command a second time. Only way to get focus back to the editor is to select a level and press . I think should put you back into the editor
Change:
import { IFileService } from 'vs/platform/files/common/files'; import { IWorkspaceContextService, IWorkspaceFolder, WorkbenchState } from 'vs/platform/workspace/common/workspace'; import { URI } from 'vs/base/common/uri'; <del> import { joinPath, relativePath } from 'vs/base/common/resources'; </del> <ins> import { basename, joinPath, relativePath } from 'vs/base/common/resources'; </ins> import { encodeBase64 } from 'vs/base/common/buffer'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IProgressService, ProgressLocation } from 'vs/platform/progress/common/progress';

Discussion:
Testing Continue from web inside desktop Let the window sit Install update (which restarts the App) you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code) Ideas don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus don't show this when my local changes are no different to those on the server <img width="1391" alt="Screenshot 2022-08-24 at 09 26 13" src="https://user-"
Is the custom modal overlay the same thing as the custom modal dialog, i.e. :+1: I filed for this.
Change:
const startLine = model!.getLineContent(b.lineRange.startLineNumber).substring(0, 20); const endLine = model!.getLineContent(b.lineRange.endLineNumberExclusive - 1).substring(0, 20); <ins> const conflictingLinesCount = b.lineRange.lineCount - 2; </ins> const domNode = h('div', [ h('div.conflict-zone-root', [ h('pre', [startLine]), h('span.dots', ['...']), h('pre', [endLine]), <del> h('span.text', [nls.localize('conflictingLines', "Conflicting Lines")]), </del> <ins> h('span.text', [ conflictingLinesCount === 1 ? nls.localize('conflictingLine', "1 Conflicting Line") : nls.localize('conflictingLines', "{0} Conflicting Lines", conflictingLinesCount) ]), </ins> ]), ]).root; this.viewZoneIds.push(c.addZone({

Discussion:
Testing Clone Use the command and select the folder Select in the quick pick It looks like the file has 4 conflict Pressing "Go to Next Conflict" highlights the first conflict Pressing "Go to Next Conflict" again does not do anything Also interesting that the editor minimap only has one conflict marker
I also saw this. It seemed to happen when both inputs make the same change.
On , once it moves past the first conflict and try to go back to it, it doesn't go back to it properly. !
This is weird, I cannot reproduce this. Also, for , I only have 2 conflicts. And this checkbox is also very weird: !
I'm on commit , not the latest commit. Does that make a difference?
If you can reproduce on the latest commit, can you try to give me a call?
yup, things look good on the latest on master for diff-merge-datasets for demo1. :) One thing I noticed, though, is that, if you're focused on the result and try to skip to next conflict, it's hard to tell by looking at the two inputs where the conflict is (seems that the two inputs aren't telling me anything in this screenshot): ! When I make the input editors a little bigger, then it starts making a little more sense. ! Not too big of a deal though, just wanted to bring your attention to it!
Change:
getDefaultLogLevels(): Promise<DefaultLogLevels>; setDefaultLogLevel(logLevel: LogLevel, extensionId?: string): Promise<void>; <ins> migrateLogLevels(): void; </ins> } class DefaultLogLevelsService implements IDefaultLogLevelsService {

Discussion:
Repro: title bar style from custom -native restart, it shuts down but doesn't start again Version: 1.81.0-insider (user setup) Commit: Date: 2023-07-25T08:12:53.439Z Electron: 22.3.17 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.
I had screen reader mode on if that matters
Following API is used to restart
does this reproduce consistently? I think I have seen this once today when I was also testing to change the title style but now I cannot reproduce anymore. I wonder if a pending update could be part of the reason it fails to restart because I think I had a pending update. //cc for the update part, I wonder if this has come up before
it was yesterday, I just tried again and it also did not start up.
Anything in the logs when you run with ? Does it reproduce running out of sources?
All times I reproduced in Insiders. Logs here, see it terminated instead of relaunching:
No, it seems to do the right thing: This would indicate that Electrons API fails here. any clue? curious if there is possibly a native crash here, can you run with the arg and see if there is a crash dump?
Weird one for you... It works fine when I set a crash reporter dir, but not without it. Running this worked when I restarted 3 times: Running this did not work when I restarted 3 times:
I was not seeing crash dumps before, I do see one which I'll DM to you
Just tried with only one window (vscode repo) open and no pty host and it still happens.
More tests: All builds down to vscode-bisect 1.77 were bad It works fine in stable 1.80.1 It does not work in insiders 1.80.0 It does not work in user install or archive for insiders
I am still not able to reproduce even on my native Windows Surface machine. I am inclined to close this as out of scope given its not something stable users see. curious, how is exploration builds for you?

or can you forward me the crash dump, I am also unable to repro with insiders. Couple more follow-up questions, 1) Is the stable build a user install or system install ? 2) Does it work fine with portable mode for archive insiders ? 3) Does it work with user install insiders when you add to ?
I think it was a red herring as there was only 1 crash dump despite 3 restarts. I'll send regardless Exploration worked , hopefully that means insiders will when Electron is updated
Reopening since issue is present with insiders for
Analysis of the bug is for reference. The root issue is that vscode has URI like arguments when setting log level for extensions which has the format and if additional arguments follow this uri like argument then the runtime will abort early on start due to an RCE fix made a long time back The fix here would be to switch from using uri separator to something like or . Similar kind of arguments can be found in the runtime as well ;l=103-123, which use as separator.
Change:
this._overlayContainer.style.position = 'absolute'; this._overlayContainer.style.overflow = 'hidden'; <del> this.layoutContainerOverShadowElement(dimension, position); </del> <ins> if (this._isVisible) { this.layoutContainerOverShadowElement(dimension, position); } </ins> if (this._webviewTransparentCover) { this._webviewTransparentCover.style.height = `${dimension.height}px`;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.1 OS Version: Pop OS 22.04 Steps to Reproduce: : New Jupyter Notebook from command panel integrated terminal panel with keyboard shortcut or by clicking the "maximize panel size" button in the integrated terminal. This is an issue only since 1.77.0. The issue is not seen in 1.76.2 Expected: Integrated terminal covers the notebook entirely. ! Actual: The jupyter notebook top bar overlaps with the integrated terminal. !
Seeing the same bug with which is just another implementation of the Notebook APIs.
It looks like a fix didn't make it into the latest recovery release. Anything planned to fix it, please Thanks!
A PR with a fix was raised in
meybe , but the insiders version seems normal.. !
It is reproducible to me in Insiders. !
Version: 1.81.0-insider (user setup) Commit: Date: 2023-07-18T05:36:41.526Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. I am verifying.
Reproduced, it should have been caused by something else just now.
yes, I first was assuming a PR of yours was causing it as reverting the change kind of fixed the bug however further investigations have shown that was the culprit and the provided PR proposes a fix for it.

Reopening as the fix was causing
Digging into this a bit, it seems when we maximize the panel, the grid view will layout the editor with height around , thus we still render the notebook editor. Since the notebook editor is rendered out of the grid view (just like webview editor), its zindex will cause this bug.
! Wow, the notebook is on such an outer layer, and now I only found these.
Related on Stack Overflow:
Potentially fixed by
Is this still happening? I 'm not able to reproduce, but I might not have the right repo steps
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
return this.ensureFormatOptions(document, options, token).then(() => { return this.client.execute('formatonkey', args, token).then((response): TextEdit[] => { <del> return response.body.map(this.codeEdit2SingleEditOperation); </del> <ins> let edits = response.body; let result: TextEdit[] = []; for (let edit of edits) { let textEdit = this.codeEdit2SingleEditOperation(edit); let range = textEdit.range; // Work around for https://github.com/Microsoft/TypeScript/issues/6700. // Check if we have an edit at the beginning of the line which only removes white spaces and leaves // an empty line. Drop those edits if (range.start.character === 0 && range.start.line === range.end.line && textEdit.newText === '') { let lText = document.lineAt(range.start.line).text; // If the edit leaves something on the line keep the edit (note that the end character is exclusive). // Keep it also if it removes something else than whitespace if (lText.trim().length > 0 || lText.length > range.end.character) { result.push(textEdit); } } else { result.push(textEdit); } } return result; </ins> }, (err: any) => { return []; });

Discussion:
VSCode Version: alpha OS Version: Windows 10 The workaround will drop edits that only remove whitespace on a line and make the line empty by this edit. The editor or latest save might clean them up.
Fixed by
Change:
} })); } <ins> private getAgentCompletionDetails(agent: IChatAgentData): { label: string; isDupe: boolean } { const isAllowed = this.chatAgentNameService.getAgentNameRestriction(agent); const agentLabel = `${chatAgentLeader}${isAllowed ? agent.name : getFullyQualifiedId(agent)}`; const isDupe = isAllowed && this.chatAgentService.agentHasDupeName(agent.id); return { label: agentLabel, isDupe }; } </ins> } Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench).registerWorkbenchContribution(AgentCompletions, LifecyclePhase.Eventually);

Discussion:
I removed this to move over to using the agent, which required setting . Chatted with and I should add another agent to support the agent in both places, only making it the default for the terminal location. fyi
Verified that is available in panel chat.
Change:
this.value = value.trim(); } <del> static autocompletions(): string[] { </del> <ins> static autocompletions(query: string): string[] { </ins> const commands = ['installed', 'outdated', 'enabled', 'disabled', 'builtin', 'recommended', 'sort', 'category', 'tag', 'ext']; const subcommands = { 'sort': ['installs', 'rating', 'name'],

Discussion:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Change:
} return result; } <ins> private _parseKeyValueAssignment(message: string): { key: string; value: string | undefined } { const [key, ...rawValues] = message.split('='); if (!rawValues.length) { return { key, value: undefined }; // No '=' was found. } const rawValue = rawValues.join('='); const value = this._deserializeMessage(rawValue); return { key, value }; } </ins> }

Discussion:
Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
On Windows Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one () Code pointer:
I'm taking this.
sounds good
I've just submitted the PR. You can check it anytime you want.
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .
Change:
if (!modifiedScopes.includes('profile')) { modifiedScopes.push('profile'); } <ins> if (!modifiedScopes.includes('offline_access')) { modifiedScopes.push('offline_access'); } </ins> modifiedScopes = modifiedScopes.sort(); let modifiedScopesStr = modifiedScopes.join(' ');

Discussion:
Similar to add to get refresh tokens by default when using
verification steps: in an extension, ask for: run the extension and sign in when asked as a result of ^^^ Restart vscode Expected to not get asked for sign in again because was automatically.
I get this in my browser: The request is blocked. <long string of characters
I am also unable to complete the sign in flow in my browser.
I had a typo in my code snippet above so when you verify this again, please make sure you copy the code snippet fresh. I had instead of
Change:
{ "displayName": "Tomorrow Night Blue Theme", "description": "Tomorrow night blue theme for Visual Studio Code", <del> "themeLabel": "Quiet Light" </del> <ins> "themeLabel": "Tomorrow Night Blue" </ins> }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.50.1 OS Version: Steps to Reproduce: vscode/extensions/theme-tomorrow-night- that wrong value for themeLabel is given ("Quiet Light" instead of "Tomorrow Night Blue") <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Incorrect value "Quiet Light" commited in
Change:
"tas-client-umd": "0.1.8", "vscode-oniguruma": "1.7.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.3", </del> <ins> "xterm": "5.3.0-beta.7", </ins> "xterm-addon-canvas": "0.5.0-beta.2", <del> "xterm-addon-image": "0.4.1", </del> <ins> "xterm-addon-image": "0.4.2", </ins> "xterm-addon-search": "0.13.0-beta.2", "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.16.0-beta.2"

Discussion:
On the latest insiders I can't click and drag the terminal scroll bar: !
Same here - but at least the terminal can actually be resized now!
I the same problem. In my case, all scrollbars (editor, explorer, ...) were. I tried and it was the same. Not sure if this is related, but Google Chrome and Slack App do not have this issue.
Same issue here, cannot scroll the terminal window. The cursor changes to text selector and is unable to scroll for the entire life of the terminal window. !
I completely shut down macOS and restarted it and it fixed it. It's strange.
Restarting vscode fixes it for me. It only happens when my cursor either hovers over a link in the terminal or I select some text from the terminal, it gets forever stuck in text selection/link click mode.
This is because of the image addon: ! cc
Upstream:
Saw that you released v1.80. In there is still 0.4.1 mentioned as version for xterm-addon-image. The patch version fixing this issue at hand is 0.4.2 - did that not work for you? Note that I was not able to repro the issue with vscode 1.79, so there is a chance that my attempt did not address it. Or did just the package update slip through?
I'm seeing this in Insiders. Restarting VSCode doesn't fix it and it only happens when I have multiple terminals open and the terminal tab sidebar is showing. Version: 1.81.0-insider (Universal) Commit: Date: 2023-07-07T19:50:58.701Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
it came in a bit late for the release and didn't think it met the bar. I'll be updating soon
Change:
DOM.hide(this.templateData.outputContainer); this.removeInputCollapsePreview(); this._outputContainerRenderer.viewUpdateHideOuputs(); <del> this.templateData.container.classList.toggle('collapsed', false); </del> this.templateData.container.classList.toggle('output-collapsed', true); this.relayoutCell();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59-Insider OS Version: Windows 10 Steps to Reproduce: a notebook a cell cells are rotated 270 degrees. Seems to be because we use the 'collapsed' classname for cell collapse, and loads a stylesheet which applies to the classname. This stylesheet is not loaded in desktop VS Code so the problem seems to only impact Codespaces This is particularly unfortunate for the interactive window because all code cell inputs are collapsed by default, but it also impacts any collapsed cell in native notebooks all up. !
I filed this a long time ago, but this is pretty bad, I will just change the styles to work around it in the meantime
fix proposal from
Change:
DOM.append(parent, this._overflowContainer); } <ins> private _generateFontFamily() { return this._fontInfo?.fontFamily ?? `"SF Mono", Monaco, Menlo, Consolas, "Ubuntu Mono", "Liberation Mono", "DejaVu Sans Mono", "Courier New", monospace`; } </ins> private _createLayoutStyles(): void { this._styleElement = DOM.createStyleSheet(this._body); const {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider (Universal) Commit: OS Version: Mac OS Monterey 12.2.1 Follow up issue to as this is a degradation in UX compared to the non-Insider version. Any input on that ? Current: ! Expected: Different columns should be aligned !
thank you for the bug report!
Change:
@IThemeService themeService: IThemeService, @ITelemetryService telemetryService: ITelemetryService, @INotificationService private readonly _notificationService: INotificationService, <del> @IKeybindingService private readonly _keybindingService: IKeybindingService, </del> @IOpenerService openerService: IOpenerService, @IMenuService private readonly _menuService: IMenuService, @ICommandService private readonly _commandService: ICommandService

Discussion:
For reuse by other code areas
Also polish styling including a hover over the joint buttons
Mockup: !
Fixed in
Change:
} else if (targetIsViewZone) { let viewZoneData = <editorBrowser.IViewZoneData>t.detail; if (this.viewHelper.shouldSuppressMouseDownOnViewZone(viewZoneData.viewZoneId)) { <ins> focus(); this._mouseDownOperation.start(t.type, e); </ins> e.preventDefault(); } <ins> } else if (targetIsWidget && this.viewHelper.shouldSuppressMouseDownOnWidget(<string>t.detail)) { focus(); e.preventDefault(); </ins> } this.viewController.emitMouseDown({

Discussion:
VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.
I'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)
PR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.