jiebi/CodeConvo huggingface dataset:
Change:
if (!link.uri) { throw new Error('Tried to open file link without a resolved URI'); } <del> const lineColumnInfo: ILineColumnInfo = this.extractLineColumnInfo(link.text); </del> <ins> const lineColumnInfo: ILineColumnInfo = this.extractLineColumnInfo(link.text, link.uri); </ins> const selection: ITextEditorSelection = { startLineNumber: lineColumnInfo.lineNumber, startColumn: lineColumnInfo.columnNumber

Discussion:
My project is under https://user- Reproduce steps: vscode open a folder which file path contains space, for example: an integrated terminal the path link Versions:
nice I can repro with the space in the name, thanks for following up
I can still repro with Windows.
I looked into this, and it will be tricky because we currently use space as one of the characters which indicates the end of a path. One idea would be to check if such a link exists (using our original regex) and if not, use regex on the subsequent sequence - then concatenating the two results for First result would be doesn't exist process exists
https://user- Look the above video, I have several questions. path is not a existed path in the disk, but also clickable. I click the , it open a file which is not why the whole string is recogonized to a path? the real path is:
this is actually about when the parents of the link have a space, it's expected currently that an absolute path with a space won't work.
is it expected that a local link with a space somewhere within the path is not detected? that is the case currently - verified via adding a test to
absolute paths (eg. ) won't work because of Relative paths without spaces with absolute ancestors that have spaces (eg. inside ) should work but don't in some cases.
When verifying, make sure to test both on a Windows machine and a non-Windows machine.
Doesn't work for me on a Mac, I guess thats probably because I still haven't got the fix in the latest insider build.
are you on ?
Worked for me on macOS. Don't have a Windows machine to try this out so someone else will need to verify on Windows.
Yes, I'm on that same version. Here's what it looks like for me on a Mac with spaces !
still not work in latest version: https://user-
For absolute paths, see I wasn't able to get to work, though. It'd open the file, but place the cursor at the beginning.
please provide some more details, it works for me: !
This is the behaviour with version 1.70.0 After ctrl+clik a popup appears at the top of the screen and I have to hit enter to go to the suggested file:line.
I can repro that on Windows, Remote-WSL and macOS.

The file must not be in the root directory for this to happen. !
let's track that problem in and as this issue is becoming quite unwieldy/unfocused.
created to track the problem related to quotes you're seeing. Could you re-verify this if all good outside of these 3 issues I created? It's difficult to manage this issue as it's so general.
Change:
/* Must be higher than sash's z-index and terminal canvases */ z-index: 40; overflow: hidden; <ins> overflow-y: auto; </ins> max-width: 700px; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: MacOS Monterey 12.5, chrome v 104.0.5112.101 Steps to Reproduce: language specific setting e.g. for a large number of languages Settings Editor, Check and hover on to show the hover view. Expected: All the overridden languages are visible and overflowing content can be scrolled to. Actual: The hover view is clipped at the screen height and not all languages are visible unless zooming out. !
this is working now, but there is some room for improvement as it does not use the maximum available space and sometimes has weird behavior with the beak. See below where the hovered text is just below the top of the widget which has a beak pointing down. <img width="272" alt="image" src="https://user-"
Change:
import { IOpenerService } from 'vs/platform/opener/common/opener'; import { Action } from 'vs/base/common/actions'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <del> import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; </del> <ins> import { IWorkspaceContextService, isUntitledWorkspace } from 'vs/platform/workspace/common/workspace'; </ins> import { Schemas } from 'vs/base/common/network'; import { URI } from 'vs/base/common/uri'; import { joinPath } from 'vs/base/common/resources';

Discussion:
an untitled workspace (e.g. open and use to add ) browser URI to clipboard <img width="746" alt="image" src="https://user-"url into browser :bug: fails to open workspace <img width="509" alt="image" src="https://user-"Should this command prompt to save the open workspace if it's not saved already (or just point to the user root directory)?
Also, this action always copies a url-encoded filepath, e.g. becomes , which also yields a "Workspace does not exist" warning message.
Change:
protected smileyInput: Builder; protected frownyInput: Builder; protected sendButton: Builder; <ins> protected remainingCharacterCount: Builder; </ins> protected requestFeatureLink: string; protected reportIssueLink: string;

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?
Change:
await this._editorService.openEditor(input, { pinned: true, forceReload: true <del> }); </del> <ins> }, SIDE_GROUP ); </ins> } getOrCreateEditorInput(instance: ITerminalInstance | SerializedTerminalEditorInput, isFutureSplit: boolean = false): TerminalEditorInput {

Discussion:
Repro: terminal move from terminal view to editor the terminal editor to the right side create terminal editor command <img width="1123" alt="Screen Shot 2021-06-16 at 4 35 40 AM" src="https://user-"
One more step needed to repro this - after step 3, focus the left editor.
This works for me now off of main
Original issue still occurring in today's Insiders. !
investigating
Interesting to note - the terminal appears in the blank editor if you: move it to a new group add a terminal editor instance to its group splitting it does not bring it back though unrelated to the move terminal view to editor - can repro by: create terminal in editor area drag and drop it focus anywhere else create terminal in editor area
Removing this line resolves this issue. might cause other problems though, so testing it out
That fix breaks reconnect occasionally
This bug is caused by the terminal instance getting detached from the element when is called again to create another terminal editor. It is clear that we need a conditional within to decide when it's appropriate to . Some things I tried: - check if the is a terminal editor and if not, do not - this fixes the bug, but then that editor does not get re-attached on reload a combo of the above using the for now, the following fixes the bug and does not impact the persistence of the editors: setting within to
I've shared with you offline what I think the right fix is here (removing the pointer to the terminalEditorinput in the old re-used editor pane). As a test, I've verified that even with the SIDE_GROUP fix, you can repro this bug. Repro Steps: 2 side by side untitled editors terminal in panel terminal to editor (will be in the right group) terminal editor to left group focus is in left group terminal editor (will open in right group and left editor will be blank)
Change:
const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ publish: boolean }>('showActionButton', { publish: true }); <del> // Branch does have an upstream or the button is disabled if (this.state.HEAD?.upstream || !showActionButton.publish) { return undefined; } </del> <ins> // Branch does have an upstream, commit is in progress, or the button is disabled if (this.state.HEAD?.upstream || this.state.isCommitInProgress || !showActionButton.publish) { return undefined; } </ins> return { command: { command: 'git.publish', title: localize('scm publish branch action button title', "{0} Publish Branch", '$(cloud-upload)'), <del> tooltip: this.state.isActionRunning ? </del> <ins> tooltip: this.state.isSyncInProgress ? </ins> localize('scm button publish branch running', "Publishing Branch...") : localize('scm button publish branch', "Publish Branch"), arguments: [this.repository.sourceControl], }, <del> enabled: !this.state.isActionRunning </del> <ins> enabled: !this.state.isSyncInProgress </ins> }; }

Discussion:
Create a commit. While the commit runs, the sync button spins as if it's syncing . The one in the statusbar does not. !
Change:
return; } const command = filteredCommands[0]; <del> this._accessibleViewService.setPosition(new Position(command.lineNumber, 1), true); </del> const commandLine = command.command.command; <del> if (commandLine) { </del> <ins> if (!isWindows && commandLine) { this._accessibleViewService.setPosition(new Position(command.lineNumber, 1), true); </ins> alert(commandLine); <ins> } else { this._accessibleViewService.setPosition(new Position(command.lineNumber, 1), true, true); </ins> } if (command.exitCode) { this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalCommandFailed); } else {

Discussion:
reported by
I am calling here on navigating to the command. On macOS, this works beautifully. I haven't tested on Windows, but am not sure why it wouldn't work the same way there. One reason it wouldn't work for you is if shell integration isn't enabled or activated properly. I know we've seen that happen for you before. do you have any thoughts / can you repro the issue on windows: run some commands in the terminal open the accessible view use alt/opt+up/down arrow to navigate between commands you should hear the commands
It has nothing to do with the shell integration because the cursor actually moves, but the aria alert does not work on Windows.
hi If I follow the steps, I only hear command failed / command succeeded for each command with the corresponding audio cue, and these are actually communicated as screen reader alerts. if I do the same on the mac, I hear the command and the corresponding audio cue for success / failure, but not the command succeeded / command failed message. for the sake of troubleshooting, I disabled the signal announcement on Windows for command succeeded / command failed. After doing that I hear the audio cue only, but not announcement. I did a bit of debugging with NVDA, and the screen reader doesn't seem to be receiving any aria live update event. One easy fix here could be to simply select the text for the command when the cursor moves to previous / next command. That would completely eliminate the need for an aria alert, and would likely work consistently across all platforms.
Thanks so much for troubleshooting I love that idea, will try it tomorrow.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
I only hear the command status as "command succeeded" or "command failed" but not the command itself.
do you see the command selected? A gif would help
it is not working for me because of this:
Makes sense - this feature is built on shell integration, so that'll have to work to test this
provided a fix for the shell integration. This is verified with that fix.
Change:
if (this.partService.isCreated() && !errors.isPromiseCanceledError(error)) { const actions: INotificationActions = { primary: [] }; if (errors.isErrorWithActions(error)) { <del> actions.primary = error.actions; </del> <ins> actions.primary = (error as errors.IErrorWithActions).actions; </ins> } const handle = this.notificationService.notify({

Discussion:
In light themes the status bar text changes from white to black, but progress spinners do not so they're hard to see: 
This icon is probably not themable yet. E.g. for the status bar feedback smiley we use trick to allow to change the color of it (). Depending on the outcome of we might move this into the notification area though.
fyi, the fix is to use a font for the icon (in this case our octicons). I found the sync icon fitting because we already use it for SCM sync: ! Alternatively we could use this animation: !
Change:
return this._onDidEndInstallTypings.event; } <ins> get onTypesInstallerInitializationFailed(): Event<Proto.TypesInstallerInitializationFailedEventBody> { return this._onTypesInstallerInitializationFailed.event; } </ins> private get output(): OutputChannel { if (!this._output) { this._output = window.createOutputChannel(localize('channelName', 'TypeScript'));

Discussion:
VSCode Version: Code 1.10.0 (, 2017-03-01T17:09:34.031Z) OS Version: Linux x64 4.5.5-300.fc24.x86_64 Extensions: none Steps to Reproduce: -Does not show type-specific proposals There is a single file in the cache: with just the empty object in it. /cc
The root cause seems to be that is not installed. I'm investigating this on other platforms as well
Two issues are tracking this on the TypeScript side: No error being generated: Add error message to typings install failure:
With TS 2.2.2 insiders we just picked up, an error notification is now generated in this case. It still does not have a good user facing message about not having npm installed. That is being tracked by
We don't handle the new event from the TS Server yet.
Change:
const hasText = !this.shouldHideText(); template.element.classList.toggle('has-text', hasText); <del> let ariaLabel: string = ''; </del> let prefix: string = ''; if (tab.terminalInstances.length > 1) { const terminalIndex = tab.terminalInstances.indexOf(instance); <del> ariaLabel = localize({ key: 'splitTerminalAriaLabel', comment: [ `The terminal's ID`, `The terminal's title`, `The terminal's split number`, `The terminal group's total split number` ] }, "Terminal {0} {1}, split {2} of {3}", instance.instanceId, instance.title, terminalIndex + 1, tab.terminalInstances.length); </del> if (terminalIndex === 0) { prefix = `┌ `; } else if (terminalIndex === tab!.terminalInstances.length - 1) {

Discussion:
Testing Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this: Put for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a and not a Modify aria label of an element in case he is part of a split
We're converting this into a list next iteration , I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.
hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?
oh great that you moving to the list. You should have a correct role then. I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip. Special character is not read out now because it is not part of the aria label.
Good point
Scoped this issue down, conversion to list will be handled in
I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before. I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just
! When I inspect a split terminal tab label, it has the correct aria label.
Oh but you are setting the on the wrong HTML element You should use the so the is properly set on the element. It has to be on that element, since that element has focus and that is what the Screen Reader will read. So I think it should be fixed here
Change:
config = Object.create(null); } const unresolvedConfig = deepClone(config); if (options && options.noDebug) { config!.noDebug = true; <ins> } else { delete config!.noDebug; </ins> } if (!type) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Version: 1.46.0-insider Commit: Date: 2020-06-05T12:27:56.662Z (2 days ago) Electron: 7.3.1 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 18.7.0 Running "Run Start Debugging" after running "Run Start Without Debugging" does not start debugging. Close inspection revealed that of the passed to DebugConfigurationProvider's remains . Steps to Reproduce: the vscode debug adapter sample the mock extension . a breakpoint at  the extension (F5) a in the extension development host. "Run Start Without Debugging" (Ctrl+F5) from the extension development host, and select . the breakpoint hit, and evaluate . ! back to the extension development host, and stop the task. "Run Start Debugging" (F5) from the extension development host this time, and select . the breakpoint hit, and evaluate 'config'. ! You can see (the second row) is set true even though it's requested to debug. Actually, I see that if I start with F5 first, and try Ctrl+F5 later, the second run receives DebugConfiguration without property. So, it seems like the value chosen in the very first run remains unchanged in the subsequent task runs.
great catch! I have pushed a fix for this which will be available in vscode insiders tomorrow.
The fix works for me in Insiders when using . The new seems to ignore the property in launch configs.
Change:
*--------------------------------------------------------------------------------------------*/ import 'vs/css!./media/interactive'; <del> // eslint-disable-next-line local/code-translation-remind </del> import * as nls from 'vs/nls'; import * as DOM from 'vs/base/browser/dom'; import { CancellationToken } from 'vs/base/common/cancellation';

Discussion:
was broken for some time and I re-enabled it today. However eslint failures were reported in and and I disabled them. Please have a look and fix the corresponding errors.
- I'm not sure what that rule is - do you know if it's documented somewhere? Also, when I remove that comment and run locally, I don't see any failures.
Tyler helped me find it. I don't see lint warnings for this for some reason, even though I have the installled and enabled
Change:
import * as dom from 'vs/base/browser/dom'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; import { createTrustedTypesPolicy } from 'vs/base/browser/trustedTypes'; <del> import { equals } from 'vs/base/common/arrays'; </del> import { Disposable, DisposableStore } from 'vs/base/common/lifecycle'; import 'vs/css!./stickyScroll'; import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition } from 'vs/editor/browser/editorBrowser';

Discussion:
enable sticky scroll open a file and scroll such that sticky scroll appears reload the window observe that the sticky scroll lines are not colored until they get rerendered once there is that could be used
Hey thanks for filing the issue. The listener onDidChangeModelTokens already exists inside of the sticky scroll code. I'll investigate the issue.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.
Change:
menu: { ...accessibleViewMenu, <del> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewSupportsNavigation), </del> <ins> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewContainsCodeBlocks), </ins> }, title: localize('editor.action.accessibleViewNextCodeBlock', "Accessible View: Next Code Block") });

Discussion:
a chat request that produces some code blocks the accessible view in screen reader mode the keyboard shortcuts or left/right arrows in the toolbar to verify that go to next/previous code block actions work sometimes the cursor doesn't move to the code block

several chat requests a chat response screen reader mode, use to open the accessible view the up arrow on the toolbar to go to the previous response see native alert dialog. it should instead be a screen reader aria alert. !

a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !