jiebi/CodeConvo huggingface dataset:
Change:
this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', { id: e.action.id, from: 'contextMenu' }); this.contextViewService.hideContextView(false); <del> // Restore focus here this.focusToReturn?.focus(); </del> } private onDidActionRun(e: IRunEvent): void {

Discussion:
click to open context menu in text editor +P to open quick open :bug: both context menu and quick open are dismissed !
re: context menu
This is not a regression so assigning to december
I'm going to pass to you for your take. Here's what I found out. When we show the command palette that causes the editor context menu to trigger the hide: This hide, focuses the editor... but in doing so, that causes the Quick Pick's didBlur to hide: which will hide the quick pick if is set to which is the default. This behavior with context menus seems to repro: Always in context menus of the editor Only with custom menus (not native menus) in the rest of the product (tree views, Account/Gear menu, etc)
Two actions here: needs to be removed or handled better (passing that to or menus should follow the logic: if ESC/selection, focus what was previously focused. If dismissed due to focus lost, don't restore focus (this goes to
my suspicion is that the editor contribution is old and unnecessary as the behavior is built-in to the menu widget. Removing it, we can centralize the logic to the menu widget.
re-opening as we still have some work to do on the custom menu side
Change:
export abstract class SymbolNavigationAction extends EditorAction2 { <del> private static _allSymbolNavigationCommands = new Set<string>(); </del> <ins> private static _allSymbolNavigationCommands = new Map<string, SymbolNavigationAction>(); </ins> private static _activeAlternativeCommands = new Set<string>(); readonly configuration: SymbolNavigationActionConfig;

Discussion:
Commit: Datum: 2022-09-01T07:22:41.992Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 +left mouse click on a declaration moves the cursor to the reference if only one exists: https://user- +left mouse click on a declaration moves the cursor opens the reference menue if only multiple references exist: https://user- Commit: Datum: 2022-09-07T05:15:40.689Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 (Also doesnt work on the Desktop Electron App.) https://user- install the versions I listed above or use and you may use this example code : Maybe it has something to do with this:
Do you have configured?
Its the default: "editor.gotoLocation.alternativeDefinitionCommand": "" ! I used and without any account. So no custom settings or extensions. :) If I use another setting like "editor.gotoLocation.alternativeDefinitionCommand": "" it also doesnt work.
Does "Peek References" or "Go to References" work when invoked on that symbol? btw - this works for me using Safari or FF
yes https://user-
are you using with your account, or in a "private" window? ctrl+mouse also doesnt bring up the references popup in other chromium based browsers, like brave nightly or the Desktop version (also tried it in a new profile). ctrl+click on a reference brings me to the definition, so my ctrl key isnt broken :D
The bug is also happening if I choose english as a language and or keyboard layout.
The same thing is happening to me, I'm on insiders Version: 1.72.0-insider Commit: Date: 2022-09-07T05:18:06.866Z (1 day ago) Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Same here
Same here. This is no longer working with the latest VSCode Insider version.

For me it's not working with Dart code. If the usage is in the same file and there is only one, it will not jump there either.
I managed to reproduce with the steps in
Change:
if (process.platform === 'win32') { <del> console.log(nls.localize('collecting', 'Collecting CPU and memory information. This might take a couple of seconds.')); interface ProcessInfo { type: 'processInfo'; name: string; processId: number; parentProcessId: number; commandLine: string; handles: number; cpuLoad: number[]; workingSetSize: number; } interface TopProcess { type: 'topProcess'; name: string; processId: number; parentProcessId: number; commandLine: string; handles: number; cpuLoad: number[]; workingSetSize: number; } type Item = ProcessInfo | TopProcess; </del> const cleanUNCPrefix = (value: string): string => { if (value.indexOf('?') === 0) { return value.substr(4);

Discussion:
After updating the module to support getting memory, cpu, and command line for each process on windows (), the module can be used in more places within VSCode [x] Update existing version of the module that's being used in the terminal [x] Use the module in place of the PowerShell script in
Change:
export interface FileWillCreateEvent { /** <ins> * A cancellation token. */ readonly token: CancellationToken; /** </ins> * The files that are going to be created. */ readonly files: readonly Uri[];

Discussion:
continues Timeout and user-cancellation applies when calling -events. However, we don't expose that in the API and silently stop async-event delivery and ignore results. We could let extension know via
For some big repo, it is possible for LS to parse more then hundreds files (which takes long time), right now, this can't be cancelled since we (LS) don't get any cancellation token (hence, no cancellation request). vscode side acts like it is cancelled, but only front end (vscode) is cancelled, all the backends (LSP and LS) that are actually doing the work are not cancelled. so even if vscode code send new requests (since vscode side is cancelled), LSP/LS won't be able to respond (not all LS is designed to process concurrent requests especially requests that have potential to change LS states). so only front end cancellation won't help much overall experiences.
fyi - this is now a thing and ready for LSP adoption
Neat, thanks
I verified that the token is available on the events, but it wasn't clear to me how to cause a user cancellation of the save/rename/delete. Can this only be done if there's slow file system provider?
You can call of the event with a promise that never or slowly resolves. Eventually the UI shows a progress notification which allows to cancel. That cancel will propagate to the extension.
I have now also verified that the token properly reflects the cancel status.
Thanks!
Change:
readonly raw: RawXtermTerminal; private _core: IXtermCore; private static _suggestedRendererType: 'canvas' | 'dom' | undefined = undefined; <ins> private static _checkedWebglCompatible = false; </ins> private _attached?: { container: HTMLElement; options: IXtermAttachToElementOptions }; private _isPhysicalMouseWheel = MouseWheelClassifier.INSTANCE.isPhysicalMouseWheel();

Discussion:
Type: <bBug</bOpen terminal. Start typing. Note the noticeable delay in the text rendering on screen even though the cursor advances. In fact some timess the text never renders. Makes the terminal pretty unusable. VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-10T05:33:20.243Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ togglehs0.1.2 vscode-eslint2.4.2 githistory0.6.20 gitlens2023.8.1005 dotnet-test-explorer0.7.8 copilot1.101.325 copilot-chat0.7. vscode-mojom0.1.4 mojom-language0.0.1 vscode-clangd0.1.24 csharp2.0.328 vscode-dotnet-runtime1.6.0 python2023.15. vscode-pylance2023.8.21 remote-wsl0.81.0 cpptools1.17.1 powershell2023.6.0 vscode-jest5.2.3 clang-format1.9.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
does changing help?
Yes. It apparently was set to auto previously. If it turn it to "off" the issue goes away.
repro's for me with set to or . does not repro for or gif: !
I can't reproduce this unfortunately
I still have a consistent repro if you want me to try anything or collect diagnostics.
Findings from looking at it together: It repro'd in Code - OSS It did not repro in xterm demo It did not repro in Code - OSS with symlinked webgl addon It repro'd after running scripts/update-xterm
I'm going to manually look through all the code that went in around rendering ~1-2 weeks ago to see if I can spot something.
Maybe it's related to Chromium.
Upstream bug filed at , thanks to
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verified on Linux
verified on windows
Change:
return new HoverAction(parent, actionOptions, keybindingLabel); } <ins> public readonly actionLabel: string; public readonly actionKeybindingLabel: string | null; </ins> private readonly actionContainer: HTMLElement; private readonly action: HTMLElement; private constructor(parent: HTMLElement, actionOptions: { label: string; iconClass?: string; run: (target: HTMLElement) => void; commandId: string }, keybindingLabel: string | null) { super(); <ins> this.actionLabel = actionOptions.label; this.actionKeybindingLabel = keybindingLabel; </ins> this.actionContainer = dom.append(parent, $('div.action-container')); this.actionContainer.setAttribute('tabindex', '0');

Discussion:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!
Change:
"config.smartCommitChanges.all": "Automatically stage all changes.", "config.smartCommitChanges.tracked": "Automatically stage tracked changes only.", "config.suggestSmartCommit": "Suggests to enable smart commit (commit all changes when there are no staged changes).", <del> "config.enableCommitSigning": "Enables commit signing with GPG.", </del> <ins> "config.enableCommitSigning": "Enables commit signing with GPG or X.509.", </ins> "config.discardAllScope": "Controls what changes are discarded by the `Discard all changes` command. `all` discards all changes. `tracked` discards only tracked files. `prompt` shows a prompt dialog every time the action is run.", "config.decorations.enabled": "Controls whether Git contributes colors and badges to the explorer and the open editors view.", "config.enableStatusBarSync": "Controls whether the Git Sync command appears in the status bar.",

Discussion:
Issue Type: <bFeature Request</bgit supports commit signing using either GPG or X.509. VS Code apparently supports using both methods, since it uses the signing method that git is set to use (probably by just calling ). However, the “Enable Commit Signing” configuration label names explicitly GPG as signing method. If X.509 is set to be used by git, it is also used when commiting using VS Code's git interface, although the user selected “Enable Commit Signing with GPG”. Renaming the “Enable Commit Signing” configuration label to include both GPG and X.509 would solve this inconsistence. VS Code version: Code 1.48.1 (, 2020-08-19T17:09:41.484Z) OS version: Darwin x64 20.0.0 <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.578 --- <!-- score: 0.448 --<!-- potentialduplicatescomment --
I checked on that, this issue is no duplicate, but a different issue.
Change:
this._hoverOnLine = -1; this._hoverOnColumn = -1; this._stickyRangeProjectedOnEditor = null; <ins> this._candidateDefinitionsLength = -1; </ins> this._lineHeight = this._editor.getOption(EditorOption.lineHeight); this._register(this._editor.onDidChangeConfiguration(e => { if (e.hasChanged(EditorOption.lineHeight)) {

Discussion:
Testing Unexpected behavior here: It seems to be scrolling to the right spot but the peek view is partially out of view: ! The file Code - OSS @ : Version: 1.71.0 Commit: Unknown Date: Unknown Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No
This can happen when a symbol has multiple definition locations. In that case we use peek to show all definitions and we need to make sure that revealing works nicer.
This seems like it's still present on today's Insiders https://user- If it helps to test, this is the file I was using:
Hi Connor, thanks for your bug. This should be solved with the PR: that was created today. The new behavior is: !
The cursor position is still wrong when I try verify on the same file: !
Nvm, tested the wrong version due to delayed insiders today
Change:
import { generateUuid } from 'vs/base/common/uuid'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { EditorsOrder } from 'vs/workbench/common/editor'; <del> import { onUnexpectedError } from 'vs/base/common/errors'; </del> <ins> import { getErrorMessage, onUnexpectedError } from 'vs/base/common/errors'; </ins> import { IProgressService, ProgressLocation } from 'vs/platform/progress/common/progress'; import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; import { IQuickInputService, QuickPickItem } from 'vs/platform/quickinput/common/quickInput';

Discussion:
Testing an invalid profile file (for example, by deleting a closing ) importing it Bug We show the error notification: ! This doesn't mention anything about profiles. I suggest showing an error that says the profile cannot be read
A similar error shows when you mistype the url for a profile (or are offline). In this case though you see failed: !
Change:
this._sessionStore.add(this._editor.onDidLayoutChange(() => this._onDidResize())); this._sessionStore.add(this._editor.onDidChangeModelContent(() => this._updateSoon.schedule())); this._sessionStore.add(this._languageFeaturesService.documentSymbolProvider.onDidChange(() => this._update(true))); <ins> const lineNumberOption = this._editor.getOption(EditorOption.lineNumbers); if (lineNumberOption.renderType === RenderLineNumbersType.Relative) { this._sessionStore.add(this._editor.onDidChangeCursorPosition(() => this._update(false))); } </ins> this._update(true); } }

Discussion:
Type: <bBug</bTesting down in a TypeScript function ! Note that, In the screenshot, is actually at line 1344, the gutter doesn't have enough space for 4 numbers. Also, the visual separation between sticky lines and normal lines looks too subtle for me. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-29T10:47:14.408Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ Bookmarks13.3.1 remotehub0.39. remote-containers0.243.0 remote-ssh0.85. remote-ssh-edit0.80.0 remote-wsl0.66.3 remote-repositories0.16.0 material-icon-theme4.19.0 material-theme3.15.2 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 copilot-nightly1.36.6347 js-debug-nightly2022.7.2717 abracadabra6.14.4 vscode-jest4.6.0 prisma4.1.0 code-spell-checker2.3.4 </details<!-- generated by issue reporter --
Change:
replaceData(items: IOutputDto): void; appendData(items: IOutputItemDto[]): void; appendedSinceVersion(versionId: number, mime: string): VSBuffer | undefined; <ins> asDto(): IOutputDto; </ins> bumpVersion(): void; }

Discussion:
After the latest update today, I'm seeing this message printed out while running my unit tests with the VSCode test runner: ! Specifically, these errors are appearing when I'm issuing commands to run notebook cells to test my controller.
Reverting back from to seems to have fixed the issue for Jupyter Notebooks.
To reproduce put a breakpoint here debug integration/API tests (open code from code-oss and debug integration tests) notebook tests hit this error This is triggered because invalid data is send to a worker. The bad worker is the notebook editor simple worker, the call happens here: The problem is that the dto isn't pure, it contains references to live object which cannot be cloned/send. <img width="1426" alt="Screenshot 2023-08-11 at 14 16 29" src=""
I have the same problem. VSCode version 1.81.1. Is there a solution already available?
it should be fixed in insiders and will be released to stable next week
Change:
} } <ins> private isTwoDimensionalGrid(): boolean { const views = this.gridWidget.getViews(); if (isGridBranchNode(views)) { // the grid is 2-dimensional if any children // of the grid is a branch node return views.children.some(child => isGridBranchNode(child)); } return false; } </ins> addGroup(location: IEditorGroupView | GroupIdentifier, direction: GroupDirection, options?: IAddGroupOptions): IEditorGroupView { const locationView = this.assertGroupView(location);

Discussion:
Steps to Reproduce: 2x2 grid it again =the layout flips (top right editor ends up bottom left)
Change:
"css.colorDecorators.enable.deprecationMessage": "The setting `css.colorDecorators.enable` has been deprecated in favor of `editor.colorDecorators`.", "scss.colorDecorators.enable.deprecationMessage": "The setting `scss.colorDecorators.enable` has been deprecated in favor of `editor.colorDecorators`.", "less.colorDecorators.enable.deprecationMessage": "The setting `less.colorDecorators.enable` has been deprecated in favor of `editor.colorDecorators`." <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
I can't find how to disable CSS property value autocomplete, I'm using these settings: it works perfectly in JavaScript, TypeScript, etc. But in CSS if I press tab I will get full autocomplete of property and then value. How I can disable autocomplete of value and keep only autocomplete of property? Gif below shows the issue. ! As you can see it autocompleted almost perfectly except it automatically opened suggestion for value which I don't need since I want to go through all based suggestions with and I even in settings which CSS should respect. In my opinion, if is it should autocomplete only with and then you can go through properties by pressing and then you add which results to you can write a single letter and go through suggestions again with . So to summarize it should autocomplete with only and do not show suggestion list of values for that prop.
How does that work? Can't you use arrow keys to select prev/next item?
No, only or . I proposed this suggestion , if any member of your team agrees on that proposal, then this can be closed, because I really miss suggestions list, but it's too noisy and distracting. Since there are a really small group of devs who disable suggestions and uses only tab to autocomplete, also in CSS, chances this will be re-created by someone else is very very small.
The problem is: He want to use tab/S-tab to go prev/next Some CSS completion items and trap the tab/S-tab Do you think we should add the setting?
Maybe I can help somehow to make this happen?
Sure, a PR that adds a new setting is welcome.
So this is related to ?
Sure, thanks! Here are some pointers: Dev setup is here: Add a boolean setting to toggle this behavior on/off Here's the logic for re-triggering value completion after property completion: Update the test suite
Thank you!
Change:
usePCRE2: boolean; actionsPosition: 'auto' | 'right'; maintainFileSearchCache: boolean; <ins> maxResults: number | null; </ins> collapseResults: 'auto' | 'alwaysCollapse' | 'alwaysExpand'; searchOnType: boolean; seedOnFocus: boolean;

Discussion:
Investigate removing Max results limitation for Search and replace results Currently we set max limit to . We need to investigate on lifting this.
Assigning this to you. I see that you are working on improving the performance for Search results. Currently we have an hard limitation of 2048. But we never measure what is the threshold. Since you are already exercising Search performance this would be a good one to look at. Thanks
I noticed . An improvement may be to not open all files in which terms were found and replaced. As a software engineer myself I sometimes have to make many changes (just today some 33k machine names in 280 XML files). Version 1.3.1 crashed on me, but even if it had worked, I would have stared at many open files. And there's no shortcut to "save all" and "close all" :( I had to revert to Notepad++, which simply makes the changes in-place on disk, without opening all files. Maybe doing something similar is an option?
This would be nice to fix/improve. I have to open Atom just to do find/replace.
There should at least be a warning telling the user that not all the occurrences have been replaced. It is very misleading when "Replace All" only replaces the first items.
Please increase this number or make it configurable
Same here. I'd like you to make the number configurable. I'd like to set this to "No Limit" also, hopefully.
The current upper bound for search in VSCode is occurrences. Is there a way to change it?
Please make this maximum / upper boundary configurable.
I wonder what is measuring? ! Also, when I set it to 2000, I see 4000 results show up when I search a single letter.
You will also get results in open files beyond the limit
This is a bit of a foot gun... Using some ridicules high value freeses VS Code eventually. Will create a separate issue for that
Change:
this.onDidChangeSmartCommitSettings(); } <del> if (e.affectsConfiguration('scm.experimental.showSyncView') || e.affectsConfiguration('git.branchProtectionPrompt', root) || </del> <ins> if (e.affectsConfiguration('git.branchProtectionPrompt', root) || </ins> e.affectsConfiguration('git.postCommitCommand', root) || e.affectsConfiguration('git.rememberPostCommitCommand', root) || e.affectsConfiguration('git.showActionButton', root)) {

Discussion:
Testing I don't seem to have the sync changes button available to me, unless you're referring to the small icons in the status bars. !
I was able to get the Sync Changes button with the node-spdlog repository on my mac. It could be because my Windows machine and/or the vscode repository I tested with both have
that should not be the case. In your screenshot, I see that you have both incoming and outgoing changes, and no pending changes so the "Sync Changes" button should be shown instead of the disabled "Commit" button. Could you please share the exact steps that got you into this state? Also what is the value of the setting?
The has the default value. I seemed to repro it again, so here are some steps: the microsoft/vscode repository, switch to a new branch off of the main branch a file and push to establish the remote version of the branch , edit a separate file on that (remote) branch and commit the change directly to that branch. , edit yet another file and commit the change. Do not push. the git fetch command. :bug: There are both incoming and outgoing changes but the sync button does not appear.
Thanks for the steps. I will keep trying but for now I am unable to reproduce the issue: !
Change:
const titleElement = container.querySelector('.title') as HTMLElement; const setHeader = () => { <del> const workspace = this.contextService.getWorkspace(); const title = workspace.folders.map(folder => folder.name).join(); </del> titleElement.textContent = this.name; <del> this.updateTitle(title); </del> <ins> this.updateTitle(this.name); </ins> this.ariaHeaderLabel = nls.localize('explorerSection', "Explorer Section: {0}", this.name); titleElement.setAttribute('aria-label', this.ariaHeaderLabel); };

Discussion:
This only applies in a multi-root workspace. With just 1 view: ! With N views: ! I think we should use the workspace label here. to you recall why this code is there: