jiebi/CodeConvo huggingface dataset:
Change:
configurationService, ); <del> this.style(getListStyles({ listBackground: editorBackground, listFocusOutline: focusBorder, listActiveSelectionBackground: editorBackground, listActiveSelectionForeground: settingsHeaderForeground, listFocusAndSelectionBackground: editorBackground, listFocusAndSelectionForeground: settingsHeaderForeground, listFocusBackground: editorBackground, listFocusForeground: settingsHeaderHoverForeground, listHoverForeground: settingsHeaderHoverForeground, listHoverBackground: editorBackground, listInactiveSelectionBackground: editorBackground, listInactiveSelectionForeground: settingsHeaderForeground, listInactiveFocusBackground: editorBackground, listInactiveFocusOutline: editorBackground })); </del> <ins> this.style({ ...getListStyles({ listBackground: editorBackground, listFocusOutline: focusBorder, listActiveSelectionBackground: editorBackground, listActiveSelectionForeground: settingsHeaderForeground, listFocusAndSelectionBackground: editorBackground, listFocusAndSelectionForeground: settingsHeaderForeground, listFocusBackground: editorBackground, listFocusForeground: settingsHeaderHoverForeground, listHoverForeground: settingsHeaderHoverForeground, listHoverBackground: editorBackground, listInactiveSelectionBackground: editorBackground, listInactiveSelectionForeground: settingsHeaderForeground, listInactiveFocusBackground: editorBackground, listInactiveFocusOutline: editorBackground, treeIndentGuidesStroke: undefined, treeInactiveIndentGuidesStroke: undefined }), treeIndentGuidesStroke: undefined, treeInactiveIndentGuidesStroke: undefined, }); </ins> } }

Discussion:
I opened the Settings editor, hovered over a setting, and noticed a new grey line appear to the left of the settings. This issue occurs with the default light and dark themes. !
I found that when calling , if we don't pass in the style override anymore, it will be reset to default I put this fix for notebook but I wonder if it's unexpected
Thanks for figuring that out. We shouldn't update options that are not set, that a regression. I fixed that with and updated your code to back what it was. Is different, it's about the indent guides which were disabled previously by not providing any colors. With my change we complete your colors with the default colors, which IMO is the right thing to do. is a simple fix. But I think we should not use the colors for that but the already existing option. I'm working on a follow up PR, but that needs to be reviewed by who is out today.
Change:
public visible: boolean = false; constructor( <del> readonly id: string, readonly name: string, </del> <ins> readonly id: string, readonly name: string, readonly resource: URI, </ins> protected readonly logger: ILogger, protected readonly proxy: MainThreadOutputServiceShape, readonly extension: IExtensionDescription,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.
Thanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like "command was already registered" or "notebook controller already exists". I am currently commenting out my line in my extension. It's not ideal though.
PR fixing it
Change:
"vscode-sqlite3": "4.0.7", "vscode-textmate": "^4.1.1", "vscode-xterm": "3.14.0-beta5", <del> "yauzl": "^2.9.1", </del> <ins> "yauzl": "^2.9.2", </ins> "yazl": "^2.4.3" }, "devDependencies": {

Discussion:
Issue Type: <bBug</b! VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-30T06:17:39.118Z) OS version: Darwin x64 18.0.0 <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ unique-lines1.0.0 ssh0.0.4 vscode-eslint1.8.0 Spot0.4.0 ghlink1.0.2 remotehub0.2.0 EditorConfig0.12.7 tslint1.0.42 git-project-manager1.7.1 vscode-pull-request-github0.3.2 rest-client0.21.1 solidity0.0.49 theme-karyfoundation-themes18.2.1 graphql-for-vscode1.13.0 vscode-azureappservice0.11.0 vscode-azurefunctions0.13.1 vscode-cosmosdb0.9.1 azure-account0.8.0 azurecli0.4.2 cpptools0.21.0 github-issues-prs0.9.1 debugger-for-chrome4.11.1 vscode-docker0.5.1 vscode-versionlens0.22.0 vscode-workspacecontains-canary0.0.2 vscode-open-in-github1.10.1 ayu0.17.0 vscodeintellicode1.1.2 azure-iot-toolkit2.2.0 </details<!-- generated by issue reporter --
This is coming as deprecation from our Electron update. If its unclear where this deprecation is coming from, I can help to print a stack from the place where it happens (this requires Electron 4 though from our exploration builds).
The stack trace would be helpful to know.
to this: open command line use Exploration: macOS: Linux: Windows:
DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the (), Buffer.allocUnsafe(), or () methods instead. at showFlaggedDeprecation () at new Buffer () at fromRandomAccessReader (/Applications/Visual Studio Code - ) at /Applications/Visual Studio Code - at FSReqWrap.oncomplete ()
This is coming from lib. Will this gets fixed upstream?
I suggest you check if there is a newer version of yauzl lib that has this fixed.

It should get fixed if a popular node lib wants to support node 10
I do not see this warning when running from sources? How can I repro this on dev?
it should show up, I saw it in devtools at least, but never from the comand line.
I can confirm that this is still happening for me when using on Windows to install latest versions of following extensions: ms-azure-, ms-vscode.powershell, ms-, ms-, ms-, ms-, , , eamodio.gitlens, qezhu.gitlink, yzhang.markdown-all-in-one. In case this is needed, here's my environment info: nodejs 8.9.3 npm 5.5.1 windows server 1607 10.0..2791 vscode system installer 1.33.1
I too can confirm the existence of the issue nodejs 10.9.0 npm 6.2.0 vscode system installer 1.33.1
When I install extensions on the command line in Fedora 30:
On WIndows 10:
FWIW I see this showing up inside Code in the developer tools now during normal use, if I installed from a VSIX (through the command palette). That is, the error is occurring during extension usage, not just during installation. <img width="769" alt="Screenshot 2019-05-23 at 11 43 56 am" src="https://user-"In the packed version of my extension, there is no instance of "Buffer()" in the code, so I don't think it's my code directly triggering it.
Change:
this._instantiateSome(EditorContributionInstantiation.BeforeFirstInteraction); } <del> public onAfterModelAttached(): void { this._register(runWhenWindowIdle(getWindow(this._editor?.getDomNode()), () => { </del> <ins> public onAfterModelAttached(): IDisposable { return runWhenWindowIdle(getWindow(this._editor?.getDomNode()), () => { </ins> this._instantiateSome(EditorContributionInstantiation.AfterFirstRender); <del> }, 50)); </del> <ins> }, 50); </ins> } private _instantiateSome(instantiation: EditorContributionInstantiation): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!
Change:
enum: ['always', 'never', 'whenTriggerCharacter', 'whenQuickSuggestion'], enumDescriptions: [ nls.localize('suggest.insertMode.always', "Always activate the suggest widget when triggering IntelliSense automatically."), <del> nls.localize('suggest.insertMode.never', "Never activate the suggest when when triggering IntelliSense automatically."), </del> <ins> nls.localize('suggest.insertMode.never', "Never activate the suggest widget when triggering IntelliSense automatically."), </ins> nls.localize('suggest.insertMode.whenTriggerCharacter', "Activate the suggest widget only when triggering IntelliSense from a trigger character."), nls.localize('suggest.insertMode.whenQuickSuggestion', "Activate the suggest widget only when triggering IntelliSense as you type."), ],

Discussion:
Testing <img width="449" alt="image" src="https://user-"
Change:
this.fire(this._isPressed); } <ins> suppressAltKeyUp() { this._suppressAltKeyUp = true; } </ins> static getInstance(contextMenuService: IContextMenuService) { if (!AlternativeKeyEmitter.instance) { AlternativeKeyEmitter.instance = new AlternativeKeyEmitter(contextMenuService);

Discussion:
Issue Type: Bug the Menu Bar to be hidden +Click on one of the editor/title toolbar buttons (for example in GitLens if you Alt+Click on the Blame button it will show the recent changes rather than the blame) :bug: Observe that when you let go of the key the menu bar will toggle back on FYI, I have a PR ready to submit for this VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-26T05:18:08.801Z) OS version: Windows_NT x64 10.0. <details<summarySystem Info</summary </detailsReproduces without extensions <!-- generated by issue reporter --
thanks for your PR, however let's first get the bug straigthend out. explorer. alt key, trigger context menu -notice there is "Delete Permanently" go of the all key -notice there is "Delete Permanently" still there. I just verified on windows. Is this unexpected for you? Becuase it behaves just fine for me. Or is the issue only visible for extensions? Is step 1. really needed to repro? If yes how do you hide the Menu Bar fyi
I can repro my issue on Windows/Linux - but the Menu Bar must be hidden (View -Toggle Menu Bar). Hold down and click on any of these icons (granted only the GitLens one actually has an alternate command) ! When you let go of the key it will cause the Menu Bar to be shown. As for your issue, I can't even get a context menu to show up while holding down -- well it shows for a second and disappears. And that doesn't matter if the menu bar is hidden or not.
This seems to be an issue with the alt key on windows and this feels like a duplicate of
the issue you mentioned, yes -- that is a duplicate of , but the issue I mentioned is not. There is no issue with the key not working. It it just that if you hide the menu bar (on Windows/Linux) you can use the key alone to toggle it on and off. Which is perfectly fine and as-designed.

But if you attempt to on an item in a "toolbar" (see the image in my previous post), the leaks through that click (the command works fine, mind you) so that not only does the command run, but the menu bar toggles (and it drives me NUTS ). There was similar work done to stop this from happening when +clicking in the editor here:
Ok thanks for more info. fyi
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
"type": "node", "request": "launch", "name": "Launch Smoke Test", <del> "program": "${workspaceFolder}/test/smoke/out/main.js", </del> <ins> "program": "${workspaceFolder}/test/smoke/test/index.js", </ins> "cwd": "${workspaceFolder}/test/smoke", "timeout": 240000, <del> "port": 9999, </del> "args": [ "-l", "${workspaceFolder}/.build/electron/Code - OSS.app/Contents/MacOS/Electron"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.1 OS Version: OSX I've cloned the Visual Studio Code repo, and built it (via and ), and from the CLI I can run the smoke tests (via ). However, when I attempt to debug any of the smoke tests, I get the error, Steps to Reproduce: VSC VSC not already open, open the project up the VSC a smoke test file (like ) to the Debug view the configuration to, "Launch Smoke Test" the Debug button Result: The debugger starts, but then quickly exits. In the Debug Console, there is: "Uncaught ReferenceError ReferenceError: before is not defined"
The "Launch Smoke Test" debug config is no longer up-to-date. I'm seeing this: <img width="1040" alt="CleanShot 2022-08-16 at 12 39 49 src="https://user-" for running smoketests please see: I've assigned this item to you because you've created the "Launch Smoke Test" debug config.
Change:
localize('window.systemColorTheme.light', "Enforce a light system color theme."), localize('window.systemColorTheme.dark', "Enforce a dark system color theme."), ], <del> markdownDescription: localize({ key: 'window.systemColorTheme', comment: ['{0} and {1} will become links to other settings.'] }, "Overrides the system color theme that is used for native UI elements such as native dialogs, menus and title bar. Even if your OS is configured in light appearance mode, you can select a dark system color theme for the window. You can also configure to automatically adjust based on the {0} setting. Note: Using this setting will disable {1}", formatSettingAsLink(ThemeSettings.COLOR_THEME), formatSettingAsLink(ThemeSettings.DETECT_COLOR_SCHEME)), </del> <ins> markdownDescription: localize({ key: 'window.systemColorTheme', comment: ['{0} and {1} will become links to other settings.'] }, "Overrides the system color theme that is used for native UI elements such as native dialogs, menus and title bar. Even if your OS is configured in light appearance mode, you can select a dark system color theme for the window. You can also configure to automatically adjust based on the {0} setting. Note: Using this setting will disable {1}.", formatSettingAsLink(ThemeSettings.COLOR_THEME), formatSettingAsLink(ThemeSettings.DETECT_COLOR_SCHEME)), </ins> default: 'default', included: ENABLE_SYSTEM_COLOR_SCHEME_SETTING, scope: ConfigurationScope.APPLICATION,

Discussion:
Testing "Note: Using this setting will disable Window: Auto Detect Color Scheme" should finish with a period.
Change:
this.expandSideOrBelow(); show(this.details.element); <del> this.details.render(this.list.getFocusedElements()[0]); </del> <ins> // Set maxHeight before .render() as Fix for #72587 </ins> this.details.element.style.maxHeight = this.maxWidgetHeight + 'px'; <ins> this.details.render(this.list.getFocusedElements()[0]); </ins> // Reset margin-top that was set as Fix for #26416 this.listElement.style.marginTop = '0px';

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33.1 OS Version: Windows Steps to Reproduce: the C/C++ extension. It's not a C/C++ extension bug, but it doesn't repro with TypeScript. the code below in a .cpp file, and use Ctrl+Space to invoke completion after "test1". // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text int test1; test1 ! Bug: No vertical scroll bar appears so the text isn't viewable. The vertical scrollbar re-appears the 2nd time completion occurs, but the bug starts reproing again after a Reload Window. This is the expected result: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?

: Yes
I was able to reproduce this in a file by changing the comment style to . ~I'd like to try fixing this bug and would appreciate any tips of where to look in the codebase.~ I found the issue in . VSCode version: 1.33.1 OS version: macOS Mojave 10.14.4 Extensions: none Note: the scrollbar does appear for me (unlike the original bug report) but the content appears to be truncated the first time I press . !
Change:
override hide() { super.hide(); this._findWidgetVisible.reset(); <del> this._instance.focus(); </del> <ins> this._instance.focus(true); </ins> this._instance.xterm?.clearSearchDecorations(); }

Discussion:
cmd+F to open find widget Close it with escape cmd+up to navigate to previous command Nothing happens, I have to click or run a command to reset focus in the terminal
I can't reproduce this, if you still can are there any more details on the repro case? The keyboard troubleshooting command output would be helpful if only you can repro.
Sorry it's working now, agreed that it was probably a context key thing so I'll check that next time
I can repro this when the serch input have has text selected, PR
Change:
super(); } <del> public fireOnWillShutdown(): Promise<void> { if (this.pendingWillShutdownPromise) { return this.pendingWillShutdownPromise; // shutdown is already running } </del> <ins> fireOnWillShutdown(): void { </ins> this.logService.trace('Lifecycle#onWillShutdown.fire()'); <del> const joiners: Promise<void>[] = []; this._onWillShutdown.fire({ join(promise) { joiners.push(promise); } }); this.pendingWillShutdownPromise = (async () => { // Settle all shutdown event joiners try { await Promises.settled(joiners); } catch (error) { this.logService.error(error); } })(); return this.pendingWillShutdownPromise; </del> <ins> this._onWillShutdown.fire(); </ins> } }

Discussion:
This here: Is strange to me because while this call is , it will not prolong the shutdown on the main process which is sync: Since the user of this event does not seem to use , I suggest to make the not support promises.
Change:
}); } async run(accessor: ServicesAccessor) { <del> return accessor.get(ITerminalGroupService).activeInstance?.rename(); </del> <ins> return accessor.get(ITerminalGroupService).activeInstance?.rename('triggerQuickpick'); </ins> } }); registerAction2(class extends Action2 {

Discussion:
Testing a terminal tab title setting your terminal to "foo" to set the name to blank string to, but I would expect it to just use my default from 1.
We discussed this and want to require a title.
I don't mean that blank titles should be allowed. I more meant how do I get back to the default I set in settings after I renamed the terminal, I feel I would expect it to let me delete my custom name and then it would use the default
You can reset the setting by clicking on the gear - is that what you mean?
No I meant is there a way to reset the terminal title to be the value of my setting instead of my custom named one?
We currently don't support going backward like that. I'll appropriately rename this issue for more discussion in October because I also wondered about this and discussed it with
Thanks sorry if I wasn't clear . My suggested UX would just be to have that be the default if you were attempt to have a blank name
oh - yes Brigit caught that case and I fixed it. so if it's set to '' or 'any number of spaces', it'll now show the process name. might've misunderstood what you were saying
But shouldn't it show whatever my setting states the default is rather than just the process name?
Sorry, the difference between our issues is she is talking about the setting I'm talking about the terminal title itself and not the setting. I want a blank rename of a terminal to reset to the value of my setting
I thought your setting was set to ''
confused - you can't set it to blank. we don't allow that
!
So my request is if my setting is and I name a terminal "foo". How do I reset "foo" back to the value of . My suggestion was that if you attempted to submit a blank name that would automatically reset to the value of your setting.
yep the name of this issue now reflects that. we'll see what says about that.
and I discussed it and it makes sense to do this
Change:
"languages": [{ "id": "groovy", "aliases": ["Groovy", "groovy"], <del> "extensions": [".groovy", ".gvy", ".gradle"], "filenames": [ "Jenkinsfile" ], </del> <ins> "extensions": [".groovy", ".gvy", ".gradle", ".jenkinsfile"], "filenamePatterns": ["Jenkinsfile.*"], </ins> "firstLine": "^#!.*bgroovyb", "configuration": "./language-configuration.json" }],

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Since you can have multiple s in a project, it would be great if vscode would be able to detect them and apply the right Language Mode (Groovy). The feature is essentially the same how vscode handles s.