jiebi/CodeConvo huggingface dataset:
Change:
"@emmetio/html-matcher": "^0.3.3", "@emmetio/math-expression": "^1.0.4", "image-size": "^0.5.2", <del> "vscode-emmet-helper": "2.2.4-2", </del> <ins> "vscode-emmet-helper": "2.2.4", </ins> "vscode-languageserver-textdocument": "^1.0.1" } }

Discussion:
Issue Type: <bBug</bSince the latest update, I am seeing really weird Emmet suggestions in SASS files (not SCSS) with a higher priority than my SASS suggestions. For example I have got used to writing with . But now if I hit tab with it will give me rather than the expected like it used to. ! VS Code version: Code 1.53.0 (, 2021-02-03T16:01:04.046Z) OS version: Darwin x64 19.4.0 <details<summaryExtensions (15)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 project-manager12.0.1 save-as-snippet0.0.1 vscode-icontheme-nomo-dark1.3.6 glsl-canvas0.2.11 vs-code-xml-format0.1.5 discord-vscode4.1.0 vscode-peacock3.9.1 vsliveshare1.0.3629 vsliveshare-audio0.1.91 vsliveshare-pack0.4.0 vscode-extension-auto-import1.4.3 shader1.1.4 sass-indented1.8.15 better-align1.1.6 </details<!-- generated by issue reporter --
The current Emmet snippet for background-color is . definitely shouldn't be suggested, though. I also confirmed that I'm only able to reproduce the issue with SASS files. Also, I just realized the other suggestions that show up aren't part of Emmet. However, I don't see the other suggestions (such as background-color) when I try typing in into a SASS file, even though I do see them on CSS and SCSS files. Wondering if I have a setting misconfigured.
Verifier: First, install the extension for SASS support. Then, set up a .sass document with the following content: Within the braces, type . Confirm that there is no suggestion of the form Edit: just realized SASS documents don't need braces. Least it helped with verification.
Change:
import { IUserDataProfileService } from 'vs/workbench/services/userDataProfile/common/userDataProfile'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import product from 'vs/platform/product/common/product'; <ins> import { CommandsRegistry } from 'vs/platform/commands/common/commands'; </ins> class InspectContextKeysAction extends Action2 {

Discussion:
Found while verifying
Yeah this has always been the case. I think it's due to registerAction vs registerCommand. Very confusing. We should investigate whether there's another way to get the commands, other than .
Take a look at this PR fixing this. Let me know if you have feedback for how the issue is solved.
Verification: Some commands are still not showing up since they register against the command registry without any description. This needs fixing at each command registration. But the fix makes sure certain commands start getting labels, like pressing <kbdCmd N</kbdto create a new untitled file.
as you mentioned some shortcut like + or + are still not visible - is there issue where that this shortcuts can be reported or progress regarding this fix tracked?
Change:
title: localize('toggle.customTitleBar', 'Custom Title Bar'), toggled: TitleBarVisibleContext, menu: [ <del> { id: MenuId.MenubarAppearanceMenu, order: 6, when: ContextKeyExpr.or(ContextKeyExpr.equals(TitleBarStyleContext.key, TitlebarStyle.NATIVE), IsMainWindowFullscreenContext), group: '2_workbench_layout' }, ] </del> <ins> { id: MenuId.MenubarAppearanceMenu, order: 6, when: ContextKeyExpr.or( ContextKeyExpr.and( ContextKeyExpr.equals(TitleBarStyleContext.key, TitlebarStyle.NATIVE), ContextKeyExpr.and( ContextKeyExpr.equals('config.workbench.layoutControl.enabled', false), ContextKeyExpr.equals('config.window.commandCenter', false), ContextKeyExpr.notEquals('config.workbench.editor.editorActionsLocation', 'titleBar'), ContextKeyExpr.notEquals('config.workbench.activityBar.location', 'top') )?.negate() ), IsMainWindowFullscreenContext ), group: '2_workbench_layout' }, ], </ins> }); }

Discussion:
Testing When both command center and actions are disabled for custom title, clicking this entry does nothing and gives no feedback: !
Change:
showOnStartupLabel, )); <ins> recentList.setLimit(5); </ins> const layoutLists = () => { if (gettingStartedList.itemCount) { this.container.classList.remove('noWalkthroughs'); reset(leftColumn, startList.getDomElement(), recentList.getDomElement()); reset(rightColumn, featuredExtensionList.getDomElement(), gettingStartedList.getDomElement()); <del> recentList.setLimit(5); </del> } else { this.container.classList.add('noWalkthroughs'); <del> reset(leftColumn, startList.getDomElement()); reset(rightColumn, recentList.getDomElement(), featuredExtensionList.getDomElement()); recentList.setLimit(10); </del> <ins> reset(leftColumn, startList.getDomElement(), recentList.getDomElement()); reset(rightColumn, featuredExtensionList.getDomElement()); </ins> } setTimeout(() => this.categoriesPageScrollbar?.scanDomNode(), 50); };

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Extension Bisect does not identify a particular extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.3 OS Version: Windows_NT x64 10.0. (Windows 10 22H2) Whenever I open a new window, I want to quickly open one of my recent folders by clicking an item in the Recent section of the welcome page. And so often, instead, I open a walkthrough by accident because walkthroughs are lazily loaded and cause the Recent section to move to the left. Typically, the walkthroughs take 3 seconds to load after the Recent section is shown. This is a small issue but still impedes my productivity/satisfaction with this awesome product. :-) ! Possible ideas for mitigation: change the layout so that Recent items are always shown on the left (avoid content jumping at all) maintain a cache of walkthrough items? provide a setting to disable the display of walkthroughs on the welcome page
Nice, thank you!
Change:
} else if (request.locationData?.type === ChatAgentLocation.Notebook) { // notebook data <del> const notebook = this._notebooks.getNotebookDocument(request.locationData.sessionInputUri); location2 = new extHostTypes.ChatRequestNotebookData(notebook.apiNotebook); </del> <ins> const cell = this._documents.getDocument(request.locationData.sessionInputUri); location2 = new extHostTypes.ChatRequestNotebookData(cell); </ins> } else if (request.locationData?.type === ChatAgentLocation.Terminal) { // TBD

Discussion:
Today inline chat for editors and notebooks rely on implicit variables, e.g . This isn't proper and we should have real API, e.g some extra property on that encapsulates data about the chat location.
Done, no more implicit variables
Change:
return await asText(context); } else { const message = await asText(context); <del> this.logService.info(`Failed to get profile from URL: ${resource.toString()}. Status code: ${context.res.statusCode}. Message: ${message}`); </del> <ins> throw new Error(`Failed to get profile from URL: ${resource.toString()}. Status code: ${context.res.statusCode}. Message: ${message}`); </ins> } <del> return null; </del> } private async pickProfileContentHandler(name: string): Promise<string | undefined> {

Discussion:
Testing an invalid profile file (for example, by deleting a closing ) importing it Bug We show the error notification: ! This doesn't mention anything about profiles. I suggest showing an error that says the profile cannot be read
A similar error shows when you mistype the url for a profile (or are offline). In this case though you see failed: !
Change:
const defaultDomPurifyConfig = Object.freeze<dompurify.Config & { RETURN_TRUSTED_TYPE: true }>({ ALLOWED_TAGS: ['a', 'button', 'blockquote', 'code', 'div', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'hr', 'input', 'label', 'li', 'p', 'pre', 'select', 'small', 'span', 'strong', 'textarea', 'ul', 'ol'], <del> ALLOWED_ATTR: ['href', 'data-href', 'data-command', 'target', 'title', 'name', 'src', 'alt', 'class', 'id', 'role', 'tabindex', 'style', 'data-code', 'width', 'height', 'align', 'x-dispatch', 'required', 'checked', 'placeholder', 'type'], </del> <ins> ALLOWED_ATTR: ['href', 'data-href', 'data-command', 'target', 'title', 'name', 'src', 'alt', 'class', 'id', 'role', 'tabindex', 'style', 'data-code', 'width', 'height', 'align', 'x-dispatch', 'required', 'checked', 'placeholder', 'type', 'start'], </ins> RETURN_DOM: false, RETURN_DOM_FRAGMENT: false, RETURN_TRUSTED_TYPE: true

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Use Help Report Issue to prefill these. --- Extension version: v0.58.0 VSCode Version: 1.75.0 (system setup) OS: Windows_NT x64 10.0. Steps to Reproduce: a comment during a review with the contents "2." (as in: please do the second option among your suggestions) the comment in the extension and it will show "1." (probably because it is rendered as a markdown list) This small/simple issue would have lead to a huge misunderstanding if I would not have been suspicious of the answer and not checked the comment on the web UI.
can you share a screen shot of what you're describing?
Hey thanks for looking into this. Here are the screenshots you have requested. View within GitHub Web ! View within the Extension ! Hope it helps.
I looked at the markdown renderer options but I don't see a way to prevent this behavior. Does this seem like a bug in to you?
Change:
return; } <del> const options = this.codeEditorService.resolveDecorationOptions(e, true); if (options.afterContentClassName || options.beforeContentClassName) { const cssRules = this.codeEditorService.resolveDecorationCSSRules(e); if (cssRules !== null) { for (let i = 0; i < cssRules.length; i++) { // The following ways to index into the list are equivalent if ( ((cssRules[i] as CSSStyleRule).selectorText.endsWith('::after') || (cssRules[i] as CSSStyleRule).selectorText.endsWith('::after')) && (cssRules[i] as CSSStyleRule).cssText.indexOf('top:') > -1 ) { // there is a `::before` or `::after` text decoration whose position is above or below current line // we at least make sure that the editor top padding is at least one line const editorOptions = this.configurationService.getValue<IEditorOptions>('editor'); updateEditorTopPadding(BareFontInfo.createFromRawSettings(editorOptions, PixelRatio.getInstance(this.targetWindow).value).lineHeight + 2); decorationTriggeredAdjustment = true; break; </del> <ins> try { const options = this.codeEditorService.resolveDecorationOptions(e, true); if (options.afterContentClassName || options.beforeContentClassName) { const cssRules = this.codeEditorService.resolveDecorationCSSRules(e); if (cssRules !== null) { for (let i = 0; i < cssRules.length; i++) { // The following ways to index into the list are equivalent if ( ((cssRules[i] as CSSStyleRule).selectorText.endsWith('::after') || (cssRules[i] as CSSStyleRule).selectorText.endsWith('::after')) && (cssRules[i] as CSSStyleRule).cssText.indexOf('top:') > -1 ) { // there is a `::before` or `::after` text decoration whose position is above or below current line // we at least make sure that the editor top padding is at least one line const editorOptions = this.configurationService.getValue<IEditorOptions>('editor'); updateEditorTopPadding(BareFontInfo.createFromRawSettings(editorOptions, PixelRatio.getInstance(this.targetWindow).value).lineHeight + 2); decorationTriggeredAdjustment = true; break; } </ins> } } } <ins> decorationCheckSet.add(e); } catch (_ex) { // do not throw and break notebook </ins> } <del> decorationCheckSet.add(e); </del> }; this._register(this.codeEditorService.onDecorationTypeRegistered(onDidAddDecorationType)); this.codeEditorService.listDecorationTypes().forEach(onDidAddDecorationType);

Discussion:
I had a notebook opened (just fine), then did some coding and when coming back to the notebook editor it was totally broken <img width="1551" alt="Screenshot 2024-02-15 at 15 30 56" src=""
It's strange that throws. With that said, an exception should not break the whole notebook.
Verified with code review, simple try catch around the problem exception line
Change:
} return this.client.execute('occurrences', args, token).then((response): DocumentHighlight[] => { let data = response.body; <del> if (data) { </del> <ins> if (data && data.length) { // Workaround for https://github.com/Microsoft/TypeScript/issues/12780 // Don't highlight string occurrences const firstOccurrence = data[0]; if (this.client.apiVersion.has213Features() && firstOccurrence.start.offset > 1) { // Check to see if contents around first occurrence are string delimiters const contents = resource.getText(new Range(firstOccurrence.start.line - 1, firstOccurrence.start.offset - 1 - 1, firstOccurrence.end.line - 1, firstOccurrence.end.offset - 1 + 1)); const stringDelimiters = ['"', ''', '`']; if (contents && contents.length > 2 && stringDelimiters.indexOf(contents[0]) >= 0 && contents[0] === contents[contents.length - 1]) { return []; } } </ins> return data.map((item) => { return new DocumentHighlight(new Range(item.start.line - 1, item.start.offset - 1, item.end.line - 1, item.end.offset - 1), item.isWriteAccess ? DocumentHighlightKind.Write : DocumentHighlightKind.Read);

Discussion:
open vscode repo on click inside a test name ! !
Closing as upstream TypeScript issue:
since this is quite disturbing I would suggest to add the following workaround on our end: If the highlight is for the current document we look at the source and filter the match if enclosed in " or '. I know hacky :-). And we pressure for a better fix in the tsserver for the next update. I proposed that they give us a 'type' information for the document highlight request telling us to which SymbolKind the symbol under the cursor resolved.
Another idea to solve this would be as follows: we don't highlight anything if the result only contains one match and contains the current cursor position. This would then convey the information that there aren't any references in the document for that symbol. This might work for most of the strings.
I'm testing the first workaround now, since it seems like the more scoped fix. I agree that we need some additional information back from TypeScript to handle this properly. Highlighting literal string types for example probably makes sense, but not highlighting content strings.
Thank you!
Change:
} private showScreenReaderNotification(): void { <del> if (!this.screenReaderNotification) { this.screenReaderNotification = this.notificationService.prompt( Severity.Info, localize('screenReaderDetectedExplanation.question', "Are you using a screen reader to operate VS Code?"), [{ label: localize('screenReaderDetectedExplanation.answerYes', "Yes"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'on', ConfigurationTarget.USER); } }, { label: localize('screenReaderDetectedExplanation.answerNo', "No"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'off', ConfigurationTarget.USER); } }], { sticky: true, priority: NotificationPriority.URGENT </del> <ins> this.screenReaderNotification = this.notificationService.prompt( Severity.Info, localize('screenReaderDetectedExplanation.question', "Are you using a screen reader to operate VS Code?"), [{ label: localize('screenReaderDetectedExplanation.answerYes', "Yes"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'on', ConfigurationTarget.USER); </ins> } <del> ); </del> <ins> }, { label: localize('screenReaderDetectedExplanation.answerNo', "No"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'off', ConfigurationTarget.USER); } }], { sticky: true, priority: NotificationPriority.URGENT } ); </ins> <del> Event.once(this.screenReaderNotification.onDidClose)(() => this.screenReaderNotification = null); } </del> <ins> Event.once(this.screenReaderNotification.onDidClose)(() => this.screenReaderNotification = null); </ins> } private updateScreenReaderModeElement(visible: boolean): void { if (visible) {

Discussion:
Testing Repro: screen reader mode Screen Reader Optimized status bar item escape Screen Reader Optimized status bar item, nothing happens Instead 4 should either show and focus the hidden notification or show a new one
I'll try to deal with this
Hi Tyriar, I would like to ask what you mean by "Press escape", does it mean clicking "No"? !
by escape I mean the (same as escape if you have the notification focused), so the notification is still there but just hidden in the notification center (via the little bell icon)
Oops, I can't reproduce it here TAT
I reproduced and tried to solve it
Change:
private static SELECT_DROPDOWN_BOTTOM_MARGIN = 10; <ins> private _isVisible: boolean; </ins> private selectElement: HTMLSelectElement; private options: string[]; private selected: number;

Discussion:
VSCode Version: Code - Insiders 1.20.0-insider (, 2017-12-19T07:32:34.862Z) OS Version: Windows_NT x64 10.0. Extensions: none Steps to Reproduce: Debug panel the top SelectBox [SelectBox expands] again at the same spot Expected result: SelectBox closes. Actual result: It stays expanded. It affects SelectBox on Debug and Output panels. Terminal panel SelectBox closes as expected.
thanks for the nice bug report, forwarding to fyi
Thanks, good bug find!
Fixed With:
thanks. the verified label should not be until our endgame where we verify all the bugs we had during a milestone. I will remove it so that we can have someone else verify the bug.
Thanks
Change:
resolved "https://registry.yarnpkg.com/@vscode/l10n/-/l10n-0.0.11.tgz#325d7beb2cfb87162bc624d16c4d546de6a73b72" integrity sha512-ukOMWnCg1tCvT7WnDfsUKQOFDQGsyR5tNgRpwmqi+5/vzU3ghdDXzvIM4IOPdSb3OeSsBNvmSL8nxIVOqi2WXA== <del> vscode-css-languageservice@^6.2.2: version "6.2.2" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-6.2.2.tgz#05f97e937a896b3823c0b13212ab4b39a7b6a8a1" integrity sha512-K3Bl/cYGNlH4MgVtBIYJr9Qj0g3BVMUtioOCc5PJFSlgLPVHpWV5RY5jSDH3hYlldWjokIkXMk1ABMY4bimG7g== </del> <ins> vscode-css-languageservice@^6.2.3: version "6.2.3" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-6.2.3.tgz#6c1e6104e77f1fb729eeea5cd2f81f3b800d87ff" integrity sha512-EAyhyIVHpEaf+GjtI+tVe7SekdoANfG0aubnspsQwak3Qkimn/97FpAufNyXk636ngW05pjNKAR9zyTCzo6avQ== </ins> dependencies: "@vscode/l10n" "^0.0.11" vscode-languageserver-textdocument "^1.0.8"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: Windows 10 Steps to Reproduce: a CSS file suggestion is shown, but is not enough. ! There should be more keywords below: - () () (safe <content-position, like ) (unsafe <content-position, like ) See: Same issue happens for and Thank you.
Tested in but not seeing the suggestions !
Change:
...options, focusSearch: true }; <del> return this.editorService.openEditor(input, options ? SettingsEditorOptions.create(options) : undefined) </del> <ins> return this.editorService.openEditor(input, options ? { ...SettingsEditorOptions.create(options), override: EditorOverride.DISABLED } : { override: EditorOverride.DISABLED }) </ins> .then(() => this.editorGroupService.activeGroup.activeEditorPane!); }

Discussion:
Steps to Reproduce: workbench editor associations to open *.json with a custom editor (e.g. HEX) to change this setting later = you cannot because in order to edit the values, you need to go to the JSON but it will open the custom editor always: ! Imho we should have a way to prevent the override from happening fro built in files such as settings. Only workaround is to entirely reset the setting. //cc
I've made a PR to fix this issue. I'm not sure why it is showing so many changes, it might be due to it being based off of the openWith PR that we had open before it got merged.
Change:
} private _updateFromWindowTitle() { <del> this.workspaceTitle.innerText = windowTitle.workspaceName; </del> <ins> // label: just workspace name and optional decorations const { prefix, suffix } = windowTitle.getTitleDecorations(); let label = windowTitle.workspaceName; if (prefix) { label = localize('label1', "{0} {1}", prefix, label); } if (suffix) { label = localize('label2', "{0} {1}", label, suffix); } this.workspaceTitle.innerText = label; // tooltip: full windowTitle </ins> const kb = keybindingService.lookupKeybinding(action.id)?.getLabel(); const title = kb ? localize('title', "Search {0} ({1}) u2014 {2}", windowTitle.workspaceName, kb, windowTitle.value)

Discussion:
With that setting set, I am missing the "[Extension Development Host]" title on the window, which is helpful for identifying that special window. In general, I guess the whole is missing - is there a plan to show that along with the menu? If not can we keep the [Extension Development Host] hint somewhere?
Today it only shows on hover. I am open for suggestion but it isn't trivial as the static window title can be very long, is configurable. Maybe show the "special decorations", like [Extension Dev..] etc, in the title menu
Change:
} await this._stageChanges(textEditor, [changes[index]]); <ins> const firstStagedLine = changes[index].modifiedStartLineNumber - 1; textEditor.selections = [new Selection(firstStagedLine, 0, firstStagedLine, 0)]; </ins> } @command('git.stageSelectedRanges', { diff: true })

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.
We might just have to set the cursor in that position, should be simple. Would you like to submit a PR?
I can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..
Hi, I would like to work on this issue. I'll submit a PR soon.
Do we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.
Sounds good.