jiebi/CodeConvo huggingface dataset:
Change:
.scm-view .scm-editor-container .monaco-editor, .scm-view .scm-editor-container .monaco-editor .margin { color: inherit; <del> background-color: var(--vscode-input-background); </del> <ins> background-color: unset </ins> } .scm-view .scm-editor-container .mtk1 {

Discussion:
Perhaps due to semi-opaque color being applied to multiple layers within the input: <img width="210" alt="CleanShot 2022-12-15 at 11 28 11 src="https://user-"<img width="289" alt="CleanShot 2022-12-15 at 11 28 23 src="https://user-"
The source control message input background does not seem to use color customization at all.
I saw it in there, but it's a fairly complex component under the hood and (I think) multiple layers of the component use it. Because the color is semi-opaque it's appearing brighter than it should be after mixing with one layer with another.
You can reproduce & verify that the colour is not applied to this particular input by setting color customization in your settings JSON to a bright red: Observe all other inputs having bright red backgrounds but the commit message input background still having the same background as the surrounding panel's background.
This is what I am seeing with the built-in theme, it looks like it completely blends with the panel's background. For me this is happening with all themes, built-in & third-party - the input's background inherits the panel's background and cannot be customised at all. !
It works for me. I don't see the behavior you do with a transparent background. I'm also noting that you have a different typeface used for the placeholder. That leads me to believe there is something else going on. Are you using any extensions that manipulate VS Code e.g. customize UI? <img width="314" alt="CleanShot 2022-12-15 at 13 26 22 src="https://user-"In any case this will be fixed by . I'd recommend opening up a separate issue for your specific problem.
It works for me too when I place SCM panel to the left sidebar, but when SCM panel is placed to the right sidebar then background colour theming is ignored on the input. I do not see this problem mentioned in . ! !
That one I can indeed repro. Can you file a new issue for that?
Done! Submitted as .
Change:
*--------------------------------------------------------------------------------------------*/ import { Event, Emitter } from 'vs/base/common/event'; <del> import { CONTEXT_EXPRESSION_SELECTED, IViewModel, IStackFrame, IDebugSession, IThread, IExpression, CONTEXT_LOADED_SCRIPTS_SUPPORTED, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_FOCUSED_SESSION_IS_ATTACH, CONTEXT_RESTART_FRAME_SUPPORTED, CONTEXT_JUMP_TO_CURSOR_SUPPORTED, CONTEXT_STEP_INTO_TARGETS_SUPPORTED, CONTEXT_SET_VARIABLE_SUPPORTED, CONTEXT_MULTI_SESSION_DEBUG, CONTEXT_TERMINATE_DEBUGGEE_SUPPORTED, CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import { CONTEXT_EXPRESSION_SELECTED, IViewModel, IStackFrame, IDebugSession, IThread, IExpression, CONTEXT_LOADED_SCRIPTS_SUPPORTED, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_FOCUSED_SESSION_IS_ATTACH, CONTEXT_RESTART_FRAME_SUPPORTED, CONTEXT_JUMP_TO_CURSOR_SUPPORTED, CONTEXT_STEP_INTO_TARGETS_SUPPORTED, CONTEXT_SET_VARIABLE_SUPPORTED, CONTEXT_MULTI_SESSION_DEBUG, CONTEXT_TERMINATE_DEBUGGEE_SUPPORTED, CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED, CONTEXT_FOCUSED_STACK_FRAME_HAS_INSTRUCTION_POINTER_REFERENCE } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { IContextKeyService, IContextKey } from 'vs/platform/contextkey/common/contextkey'; import { isSessionAttach } from 'vs/workbench/contrib/debug/common/debugUtils';

Discussion:
Testing As already pointed out The "Open Disassembly View" command is now only visible when the active stackframe has a instructionPointerReference property. This makes it hard to discover. I suggest to have the context menu's "Open Disassembly View" command always visible if a debug adapter has the supportsDisassembleRequest capability. But the command should only be enabled if the active stackframe has a instructionPointerReference property. That results in a more stable user experience. Apart from that we should have the Open Disassembly View command in the command palette.
That's a fair suggestion. However, we are not sure how to disable a command...
commands have clauses and . clause determines if the command is present at all and if it is disabled. So please use the when registering the editor command for disablement.
Also we should consider to introduce a call stack context menu action for the Open Disassembly View.
will fix this.
Change:
command: { id: PASTE_FILE_ID, title: PASTE_FILE_LABEL, <del> precondition: ContextKeyExpr.and(ExplorerResourceNotReadonlyContext, FileCopiedContext) </del> <ins> precondition: ContextKeyExpr.and(ExplorerResourceNotReadonlyContext, FileCopiedContext, WorkbenchTreeFindOpen.toNegated()) </ins> }, when: ExplorerFolderContext });

Discussion:
Sometimes "Paste" fails: The file(s) to paste have been deleted or moved since you copied them. TreeError [FileExplorer] Tree element not found: [object Object] Maybe should be disabled for as long as we do not update properly.
Change:
return new Promise((resolve, reject) => { debugAdapter.sendRequest('initialize', { adapterID: 'test' }, (result) => { resolve(result); <del> }); </del> <ins> }, 3000); </ins> }); }

Discussion:
Just broke again:
Added a timeout to the initialize request which will tell me if that's the part that's timing out, but it's probably not. Any guess
Duplicates
Change:
import { HoverProviderRegistry } from 'vs/editor/common/modes'; import { Schemas } from 'vs/base/common/network'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; <ins> import { NotebookEditorWidget } from 'vs/workbench/contrib/notebook/browser/notebookEditorWidget'; </ins> registerAction2(class extends Action2 { constructor() {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.0-insider OS Version: Windows 10 Steps to Reproduce: a text editor open in editor group 1 a notebook into editor group 2 focus to text editor on kernel selector kernel picker quickpick does not appear focus to notebook editor kernel selector now puts up the kernel picker quickpick This is because clicking on command buttons in the notebook editor does not set focus to the active editor, but the command assumes that focus is on the notebook editor when handling the command. This also affects the interactive window because the interactive toolbar inherits the same action. I suspect this is the reason why the kernel picker sporadically appears 'stuck': ! /cc
Quick update--this is actually because returns undefined when focus is not on the notebook editor. But the run context contains the . We should be using that to resolve the target editor.
Change:
private _requestId: number = 0; <del> constructor(@IAccessibilitySignalService private readonly _accessibilitySignalService: IAccessibilitySignalService, @IInstantiationService private readonly _instantiationService: IInstantiationService) { </del> <ins> constructor( @IAccessibilitySignalService private readonly _accessibilitySignalService: IAccessibilitySignalService, @IInstantiationService private readonly _instantiationService: IInstantiationService, @IConfigurationService private readonly _configurationService: IConfigurationService ) { </ins> super(); } acceptRequest(): number {

Discussion:
Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Makes sense cc
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
would you, yourself, enable this? I worry about turning off regions.
I don’t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).
That makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,
Yes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.
do you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.
That happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.
I use a separate sound card for my screen reader.
what are some verification steps for this issue?

enable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response
I am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.
Sorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.
Change:
"scrollbarSlider.hoverBackground": "#6e768145", "searchEditor.textInputBorder": "#CECECE", "settings.dropdownBackground": "#ffffff", <del> "settings.dropdownBorder": "#0000001a", </del> <ins> "settings.dropdownBorder": "#CECECE", </ins> "settings.headerForeground": "#1f1f1f", "settings.modifiedItemIndicator": "#bb800966", "settings.numberInputBorder": "#CECECE",

Discussion:
Ref Unchecked and unfocused checkboxes in the Settings editor currently do not have much contrast between the checkbox background colour and the checkbox border colour for both Light+ v2 and Dark+ v2 themes. !
Change:
collector.addRule(`.monaco-workbench .part.panel .scm-view .scm-editor-container { outline: 1px solid ${panelInputBorder}; }`); } <ins> const buttonBorderColor = theme.getColor(buttonBorder); collector.addRule(`.scm-view .button-container > .monaco-description-button { height: ${buttonBorderColor ? '32px' : '30px'}; }`); </ins> const focusBorderColor = theme.getColor(focusBorder); if (focusBorderColor) { collector.addRule(`.scm-view .scm-editor-container.synthetic-focus { outline: 1px solid ${focusBorderColor}; }`);

Discussion:
Using the Amethyst theme the label of the "Sync Changes" button is not vertically aligned: <img width="626" alt="image" src="https://user-"//cc
That‘s not an issue for me. The main issue for the "Sync Changes" button is that, it allways shows. It should be hidden when there is no changes to sync. !
that is unrelated to the problem that this issue is tracking. Also the problem that you are describing has already been fixed in the latest Insiders release, and it will be included in the next Stable release.
I think this is the same border issue except in the button we cap the height to so it forces everything to be shifted down by 1-2px: <img width="294" alt="CleanShot 2022-07-21 at 08 43 45 src="https://user-"If you remove the height then it looks better: <img width="234" alt="CleanShot 2022-07-21 at 08 46 01 src="https://user-"
thanks for looking into this. your analysis aligns with my findings. I will try to get a fix for this in next week.
Change:
private readonly _editor: ICodeEditor, @IKeybindingService private readonly _keybindingService: IKeybindingService, @IContextKeyService private readonly _contextKeyService: IContextKeyService, <del> @IConfigurationService private readonly _configurationService: IConfigurationService, @IAccessibilityService private readonly _accessibilityService: IAccessibilityService </del> <ins> @IConfigurationService private readonly _configurationService: IConfigurationService </ins> ) { }

Discussion:
Testing It doesn't seem to matter what I set the new settings to. They are never mentioned in the editor accessbility help. ! !
By design, you have to enable screen reader mode to see this
Maybe we shld also include it when not in screen reader mode?
Might be worth updating the TPI then, since I assumed it should always be there. The language seems backwards: <img width="478" alt="image" src=""
It also doesn't mention the settings, and my understanding is that if the settings are disabled, then the settings will take effect. I have those still turned on.
The reason I didn't mention those here is they're linked to in the ones I do mention, so a user will discover them.
I will use this issue to track making sure these show up in the help dialog regardless of screen reader optimized mode
Change:
event.preventDefault(); event.stopPropagation(); <ins> const altKey = AlternativeKeyEmitter.getInstance(this._contextMenuService); if (altKey.isPressed) { altKey.suppressAltKeyUp(); } </ins> this.actionRunner.run(this._commandAction) .done(undefined, err => this._notificationService.error(err)); }

Discussion:
Issue Type: Bug the Menu Bar to be hidden +Click on one of the editor/title toolbar buttons (for example in GitLens if you Alt+Click on the Blame button it will show the recent changes rather than the blame) :bug: Observe that when you let go of the key the menu bar will toggle back on FYI, I have a PR ready to submit for this VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-26T05:18:08.801Z) OS version: Windows_NT x64 10.0. <details<summarySystem Info</summary </detailsReproduces without extensions <!-- generated by issue reporter --
thanks for your PR, however let's first get the bug straigthend out. explorer. alt key, trigger context menu -notice there is "Delete Permanently" go of the all key -notice there is "Delete Permanently" still there. I just verified on windows. Is this unexpected for you? Becuase it behaves just fine for me. Or is the issue only visible for extensions? Is step 1. really needed to repro? If yes how do you hide the Menu Bar fyi
I can repro my issue on Windows/Linux - but the Menu Bar must be hidden (View -Toggle Menu Bar). Hold down and click on any of these icons (granted only the GitLens one actually has an alternate command) ! When you let go of the key it will cause the Menu Bar to be shown. As for your issue, I can't even get a context menu to show up while holding down -- well it shows for a second and disappears. And that doesn't matter if the menu bar is hidden or not.
This seems to be an issue with the alt key on windows and this feels like a duplicate of
the issue you mentioned, yes -- that is a duplicate of , but the issue I mentioned is not. There is no issue with the key not working. It it just that if you hide the menu bar (on Windows/Linux) you can use the key alone to toggle it on and off. Which is perfectly fine and as-designed.

But if you attempt to on an item in a "toolbar" (see the image in my previous post), the leaks through that click (the command works fine, mind you) so that not only does the command run, but the menu bar toggles (and it drives me NUTS ). There was similar work done to stop this from happening when +clicking in the editor here:
Ok thanks for more info. fyi
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
"name": "punctuation.definition.string.end.html" }, "1": { <del> "name": "source.js-ignored-vscode" </del> <ins> "name": "source.js" </ins> } }, "name": "string.quoted.single.html",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.71.0 Commit: Date: 2022-09-01T07:25:10.472Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.10.7-arch1-1 Sandboxed: No Steps to Reproduce: a file with the contents: a SvelteKit project and open any file. as shown in the video. https://user- Result: Without a space - it doesn't work. With space - it works. Cause: When the cursor is in front of the character, it thinks it is already AFTER , although this is not true. PS The same problem is in the last character, before , in the file.
This also happens in the HTML with where being cursor position. The problem seems to be because the position of the cursor is on the border of the embedded language. Maybe it could be changed to using the previous character, when possible, instead of the next?
Thanks - I can reproduce what you are saying. I don't really know what svelte kit is nor what extension you are using. So, I am focusing on html. Using "F1 Inspect Editor Tokens and Scopes" shows me that the language at position is classified as html, not JavaScript. <img width="728" alt="Screenshot 2022-12-05 at 16 22 35" src="https://user-"Because of that no JS snippets are shown. Passing this on to who maintains the TextMate grammars for this.

An easy workaround on your end would be to configure the snippet to also work for the "outer" language
SvelteKit: SvelteJS is the 4th most popular framework (behind ReactJS Vue Angular), and considered to have the best DX of all frameworks. Extension for SvelteJS: But I hope that solving the problem in html/js, will also solve the problem in SvelteJS.
Related to
what do you think of modifying the solution to so that we don't ignore strings? PR
Change:
suggestOnTriggerCharacters: toBoolean(opts.suggestOnTriggerCharacters), acceptSuggestionOnEnter: toBoolean(opts.acceptSuggestionOnEnter), snippetSuggestions: opts.snippetSuggestions, <ins> emptySelectionClipboard: opts.emptySelectionClipboard, </ins> tabCompletion: opts.tabCompletion, wordBasedSuggestions: opts.wordBasedSuggestions, suggestFontSize: opts.suggestFontSize,

Discussion:
Like the title says, when nothing is selected, copying shouldn't copy a blank character.
As of now, cmd+c without any selection, copies the entire line. Sublime also does the same. Are we suggesting to change this behavior as part of this issue? I really like the current functionality. Or are we suggesting one more option/flag which user can enable to have the new functionality?
Yes, it would be behind an option
Can we have the option for this behavior or disable it? I don't like the auto copy of a blank line and would like to disable that feature. I agree it can be annoying especially in the type of coding I do (debugging).
Was a setting for this?
it is
disables the line copying entirely. Is there a way to have line copying enabled, while simultaneously ignoring the empty lines?
This doesn't disable the copying within my VS Code at all and I can still copy whitespace - anyone else had any luck? fingers crossed
Change:
class NotebookKernelDetection extends Disposable implements IWorkbenchContribution { private _detectionMap = new Map<string, IDisposable>(); <del> private _localDisposableStore = new DisposableStore(); </del> <ins> private _localDisposableStore = this._register(new DisposableStore()); </ins> constructor( @INotebookKernelService private readonly _notebookKernelService: INotebookKernelService, @IExtensionService private readonly _extensionService: IExtensionService,

Discussion:
When we only have a couple of notebook controllers created for a notebook type, without any kernel detection task or kernel source commands, the "Select Another Kernel" should not show.
I have no kernels in the MRU, clicking Select Kernel brings me to this quickpick, and clicking the back button here does nothing--I think it shouldn't be shown in this scenario ! I have the Jupyter extension installed but not the Python extension installed, with the MRU picker enabled, the Select Kernel dropdown spins forever like this: !
Change:
return this.getOrCreateEditableSettingsEditorInput(configurationTarget, resource) .then(editableSettingsEditorInput => { <del> if (!options) { options = { pinned: true }; } else { options = { ...options, pinned: true }; } </del> <ins> options = { ...options, pinned: true }; </ins> if (openDefaultSettings) { const activeEditorGroup = this.editorGroupService.activeGroup; const sideEditorGroup = this.editorGroupService.addGroup(activeEditorGroup.id, GroupDirection.RIGHT); return Promise.all([ <del> this.editorService.openEditor({ resource: this.defaultSettingsRawResource, options: { pinned: true, preserveFocus: true, revealIfOpened: true }, label: nls.localize('defaultSettings', "Default Settings"), description: '' }), this.editorService.openEditor(editableSettingsEditorInput, { pinned: true, revealIfOpened: true }, sideEditorGroup.id) </del> <ins> this.editorService.openEditor({ resource: this.defaultSettingsRawResource, options: { pinned: true, preserveFocus: true, revealIfOpened: true, override: EditorOverride.DISABLED }, label: nls.localize('defaultSettings', "Default Settings"), description: '' }), this.editorService.openEditor(editableSettingsEditorInput, { pinned: true, revealIfOpened: true, override: EditorOverride.DISABLED }, sideEditorGroup.id) </ins> ]).then(([defaultEditor, editor]) => withNullAsUndefined(editor)); } else { <del> return this.editorService.openEditor(editableSettingsEditorInput, SettingsEditorOptions.create(options), group); </del> <ins> return this.editorService.openEditor(editableSettingsEditorInput, { ...SettingsEditorOptions.create(options), override: EditorOverride.DISABLED }, group); </ins> } }); }

Discussion:
Steps to Reproduce: workbench editor associations to open *.json with a custom editor (e.g. HEX) to change this setting later = you cannot because in order to edit the values, you need to go to the JSON but it will open the custom editor always: ! Imho we should have a way to prevent the override from happening fro built in files such as settings. Only workaround is to entirely reset the setting. //cc
I've made a PR to fix this issue. I'm not sure why it is showing so many changes, it might be due to it being based off of the openWith PR that we had open before it got merged.