jiebi/CodeConvo huggingface dataset:
Change:
}, dispose(): void { disposed = true; <del> channelPromise.then(channel => channel.dispose()); </del> <ins> channelPromise.then(channel => { that.channels.delete(channel.id); that.loggerService.deregisterLogger(channel.resource); channel.dispose(); }); </ins> } }; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.
Thanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like "command was already registered" or "notebook controller already exists". I am currently commenting out my line in my extension. It's not ideal though.
PR fixing it
Change:
this.editor.changeViewZones(accessor => { accessor.layoutZone(this._viewZone!.id); }); <ins> this._positionMarkerId.set([{ range: Range.isIRange(rangeOrPos) ? rangeOrPos : Range.fromPositions(rangeOrPos), options: ModelDecorationOptions.EMPTY }]); </ins> } }

Discussion:
open inline chat have it make multiple hunks (hint: ask it to use a util that needs to be imported) there is no gesture to visit all hunks except for accepting/discarding them... This can also help with accessibility when using the move
To verify let inline chat make multiple changes, e.g ask it to import a util or let is change the label of two actions make sure the inline chat status says "N changes" (n=2) select and to navigate between the changes
Change:
} else if (referenceCount === 1 && altAction) { // already at the only result, run alternative SymbolNavigationAction._activeAlternativeCommands.add(this.desc.id); <del> altAction.run().finally(() => { </del> <ins> instaService.invokeFunction((accessor) => altAction!.runEditorCommand(accessor, editor, arg, range).finally(() => { </ins> SymbolNavigationAction._activeAlternativeCommands.delete(this.desc.id); <del> }); </del> <ins> })); </ins> } else { // normal results handling

Discussion:
Commit: Datum: 2022-09-01T07:22:41.992Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 +left mouse click on a declaration moves the cursor to the reference if only one exists: https://user- +left mouse click on a declaration moves the cursor opens the reference menue if only multiple references exist: https://user- Commit: Datum: 2022-09-07T05:15:40.689Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 (Also doesnt work on the Desktop Electron App.) https://user- install the versions I listed above or use and you may use this example code : Maybe it has something to do with this:
Do you have configured?
Its the default: "editor.gotoLocation.alternativeDefinitionCommand": "" ! I used and without any account. So no custom settings or extensions. :) If I use another setting like "editor.gotoLocation.alternativeDefinitionCommand": "" it also doesnt work.
Does "Peek References" or "Go to References" work when invoked on that symbol? btw - this works for me using Safari or FF
yes https://user-
are you using with your account, or in a "private" window? ctrl+mouse also doesnt bring up the references popup in other chromium based browsers, like brave nightly or the Desktop version (also tried it in a new profile). ctrl+click on a reference brings me to the definition, so my ctrl key isnt broken :D
The bug is also happening if I choose english as a language and or keyboard layout.
The same thing is happening to me, I'm on insiders Version: 1.72.0-insider Commit: Date: 2022-09-07T05:18:06.866Z (1 day ago) Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Same here
Same here. This is no longer working with the latest VSCode Insider version.

For me it's not working with Dart code. If the usage is in the same file and there is only one, it will not jump there either.
I managed to reproduce with the steps in
Change:
export interface IDebugConfiguration { allowBreakpointsEverywhere: boolean; <del> openDebug: 'neverOpen' | 'openOnSessionStart' | 'openOnFirstSessionStart'; </del> <ins> openDebug: 'neverOpen' | 'openOnSessionStart' | 'openOnFirstSessionStart' | 'openOnDebugBreak'; </ins> openExplorerOnEnd: boolean; inlineValues: boolean; hideActionBar: boolean;

Discussion:
Currently if I start my App with another View than Debug View open and the debugger breaks because of a break point or an exception I have to manually switch to the debug view. It would be incredible if I could set an option to display the debug view in that cases automatically Thanks for your great Work!
This is a fair feature request. If we get more users asksing for this we would be willing to accept a PR that fixes this. Thanks
Why only as PR? I guess it will be only a very small change but I'm not a Typescript dev and have no idea about the internal structure of VS Code. For your team this should be a quick fix.
Because we encourage people to be invovled in our open source project Code pointer The following setting should be updated to also cover this case  to also have the following option "openOnDebugBreak" No typescript knowledge is needed for this PR fyi
Change:
const uriRegex = /^(([^:/?#]+?):)?(//([^/?#]*))?([^?#]*)(?([^#]*))?(#(.*))?/; let patternRegex: RegExp | undefined; if (typeof prop.pattern === 'string') { <del> patternRegex = new RegExp(prop.pattern); </del> <ins> patternRegex = new RegExp(prop.pattern, 'u'); </ins> } return [

Discussion:
I have a configuration property in my extension's with the following definition: That regex is a valid unicode regex that works in the node REPL, but it doesn't work properly in the VS Code settings editor: <img width="474" alt="Screenshot 2023-08-31 at 9 11 30 AM" src=""Are these patterns evaluated with the unicode flag on? If not, can that feature be or enabled?
The Unicode flag isn't used at this time. Code pointer
Is this something that is going to be picked up in an upcoming release?
Thanks for fixing this so quickly! It works for me on: Version: 1.83.0-insider Commit: Date: 2023-09-25T10:44:46.038Z Electron: 25.8.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 22.6.0
Marking this as verified based on author's comment
Change:
return false; } <del> const context = await this.requestService.request({ url: this.url }, CancellationToken.None); // The update server replies with 204 (No Content) when no // update is available - that's all we want to know. return context.res.statusCode === 204; </del> <ins> try { const context = await this.requestService.request({ url: this.url }, CancellationToken.None); // The update server replies with 204 (No Content) when no // update is available - that's all we want to know. return context.res.statusCode === 204; } catch (error) { this.logService.error('update#isLatestVersion(): failed to check for updates'); this.logService.error(error); return undefined; } </ins> } async _applySpecificUpdate(packagePath: string): Promise<void> {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VS Code version: Code - Insiders 1.46.0-insider (, 2020-06-05T12:27:56.662Z) OS version: Darwin x64 18.7.0 Steps to Reproduce: all network connections. VSCode. "Developer: Startup Performance" from the Command Palette. Expected result: Startup Performance measurements are displayed. Actual result: Startup Performance never finishes "Loading...". Error logged in Dev Tools Console. ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Failing requests are from the extension service, not sure if this is intended during the startup metrics collection. Deferring to
I do not know how the start up perf are recorded and I assume these network requests failures are unrelated to it. Any insights on this?
I don't believe this is specific to the performance editor but must be rooted somewhere lower. The perf editor shows while it the eventually lifecycle phase and extensions being registered. So, I believe the culprit must be somewhere there
Assigning to and for lifecycle phase and extensions being registered steps respectively
Running with and checking logs, the is reached: There are 2 more things the editor awaits on: Maybe Jo could check on the former and Alex on the latter.
The former is again installed extension registered and lifecycle phase awaiting
this call is never returning: But is needed for this barrier to open:
Good digging. Thanks Adding to decide if the update service should eventually error or return false when asked for latest without internet access
I think throwing would make more sense for a service call.
Change:
result.suggestions.push({ label: { label: withSlash, description: command.description ?? '' }, kind: CompletionItemKind.Text, <del> insertText: withSlash, </del> <ins> insertText: `${withSlash} `, </ins> range: Range.fromPositions(new Position(1, 1), position), }); }

Discussion:
open inline chat type , accept suggestion and type :bug: you know have "/explainthis" even tho it isn't rendered as such !
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.67", "xterm-addon-search": "0.9.0-beta.41", "xterm-addon-serialize": "0.7.0-beta.15", </del> <ins> "xterm": "4.19.0", "xterm-addon-search": "0.9.0", "xterm-addon-serialize": "0.7.0", </ins> "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.12.0-beta.43", "xterm-headless": "4.19.0-beta.67", </del> <ins> "xterm-addon-webgl": "0.12.0", "xterm-headless": "4.19.0", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
! cmd+f, do a search clear the text in the find input it says "0 of -1"
was this insiders or code - oss? If the latter can you make sure is updated?
need to see if this reproduces in OSS
doesn't reproduce in the demo... I think I updated before the PR checks had finished maybe so that fix wasn't included?
I tested with my branch of symlinked so that's probably why I wasn't seeing it
yep happens in OSS so the fix is to update in vscode
Change:
private readonly profilesEnabled: boolean; <ins> private readonly keybindingListeners: DisposableStore = new DisposableStore(); private focusedIndex = 0; </ins> constructor( container: HTMLElement, @IConfigurationService private readonly configurationService: IConfigurationService,

Discussion:
Change the key event handling so that the user can tab once into the indicators container, and then use left/right arrows to focus on different indicators.
the Settings editor, search on the setting. tab should focus on the first indicator. again should go to the checkbox. -tabbing twice from there should focus the entire setting again. again to the indicator. The left and right arrow keys, along with the home and end keys should allow the user to focus onto the other indicators. indicators container should keep track of the focused indicator. If the second indicator is focused, and the user tabs to the checkbox and back, the second indicator should be the one focused rather than the first one.
Change:
newRightPosition = Position.LEFT; } <del> // Move editors to new position let editorPos1 = this.visibleEditors[Position.LEFT]; editorPos1.getContainer().offDOM().build(this.silos[newLeftPosition].child()); editorPos1.changePosition(newLeftPosition); </del> <ins> // Move containers to new position const containerPos1 = this.silos[Position.LEFT].child(); containerPos1.appendTo(this.silos[newLeftPosition]); </ins> <del> let editorPos2 = this.visibleEditors[Position.CENTER]; editorPos2.getContainer().offDOM().build(this.silos[newCenterPosition].child()); editorPos2.changePosition(newCenterPosition); </del> <ins> const containerPos2 = this.silos[Position.CENTER].child(); containerPos2.appendTo(this.silos[newCenterPosition]); </ins> <del> const editorPos3 = this.visibleEditors[Position.RIGHT]; editorPos3.getContainer().offDOM().build(this.silos[newRightPosition].child()); editorPos3.changePosition(newRightPosition); </del> <ins> const containerPos3 = this.silos[Position.RIGHT].child(); containerPos3.appendTo(this.silos[newRightPosition]); // Inform Editors this.visibleEditors[Position.LEFT].changePosition(newLeftPosition); this.visibleEditors[Position.CENTER].changePosition(newCenterPosition); this.visibleEditors[Position.RIGHT].changePosition(newRightPosition); </ins> // Update last active position accordingly if (this.lastActivePosition === Position.LEFT) {

Discussion:
For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.
I merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !
I can verify
LGTM - will push the revert revert commit
Verified via
Change:
// Reset await this.code.dispatchKeybinding('Backspace'); } <ins> await this.code.wait(100); </ins> await this.code.dispatchKeybinding(altKey ? 'Alt+Enter' : 'enter'); await this.quickinput.waitForQuickInputClosed(); if (commandId === TerminalCommandIdWithValue.NewWithProfile) {

Discussion:
See
I think it's related to this line not clearing the quick pick: It's meant to hit backspace:
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.8.tgz#486ae22b2eb88a12ebded366c4019ee26409cbb8" integrity sha512-G0F70f6zGWtXuZxKiTn9BQswaVz85wcCuadnWRdPFDBlgdEfcboCvVZgQetklOIkluVpt8tYYK013/25iMRKTA== <del> xterm-headless@5.1.0-beta.13: version "5.1.0-beta.13" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.13.tgz#ff1ae4bf9a9962410fb46dbe19c73f9b93ae4539" integrity sha512-jbCCuJgpnv1Ncda45J08wlEAVEReYQonFx9Nu9YvjQyvnN5h0PkIAztFHHO3bjRPFHCC44fPfcmvJOvA4pZAZA== xterm@5.1.0-beta.13: version "5.1.0-beta.13" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.13.tgz#efbc350a819ec7ff77ff340545178ee48d048e2d" integrity sha512-p2E0XwuuIG6sFLy5/4gkPiesX6BdlR6+3Ew+Tcj+1aTvvum/1jKzmuKprZvQn1RRyCsQTpMrvOB0x5Tj7F9wEw== </del> <ins> xterm-headless@5.1.0-beta.15: version "5.1.0-beta.15" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.15.tgz#fba76c8e95b552e922354409864c0f55d3b499f7" integrity sha512-LVtB+KkHs1R2RG8ug3IfOOU0J+qEGttfXagGxfzNq8zxxoSsgoY4D0YvLpM7M/5FK6eGK5K8/yol9XAK63ENog== xterm@5.1.0-beta.15: version "5.1.0-beta.15" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.15.tgz#146b70c81fd286dbb003d18449918326fa355b6b" integrity sha512-fO87pEPFMr+h7eo51+6+ew3OhzLm2wwSYz6w/y5lH986rD1lgAeEqFuzjr64pjBzwAihnoaTpumYg5lTZDQpSA== </ins> yallist@^4.0.0: version "4.0.0"

Discussion:
Testing with EDIT or https://user-
!
!
weird behavior on too !
also happens with
also lines aren't resizing !
did some change happen around trusted types? The dynamically loaded script needs to set inline attributes/innerHTML
No, nothing that I am aware of. Tho, the assignment () should have never worked with trusted types enabled because it's a bare string, not If you have to use assignment (which should be the exception) you need to use a trusted types policy and create trusted html through that. This is a sample: However, you should try to avoid that and keep things more simple, e.g use and/or
Ah you're right, this was a coding error introduced with underlines:
Change:
super({ id: Constants.ReplaceInFilesActionId, title: { <del> value: nls.localize('replaceInFiles', 'Search: Replace in Files'), original: 'Search: Replace in Files' </del> <ins> value: nls.localize('replaceInFiles', 'Replace in Files'), original: 'Replace in Files' </ins> }, keybinding: [{ primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KeyH, weight: KeybindingWeight.WorkbenchContrib, }], <del> category: category.value, </del> <ins> category: category, f1: true, </ins> menu: [{ id: MenuId.MenubarEditMenu, group: '4_find_global',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Ventura 13.0.1 Steps to Reproduce: shift + p "replace" replace in files command is found
Was there ever such a command? is there.
that's exactly the one I'm talking about. I looked it up in 3 computers and only found the command in the one I update vscode the least. I'm going to see if it's any plugin I have. I recall using it very recently and the only thing I remember adding or updating was vscode itself
is in the Command Palette of both Stable v1.73.1 and Insiders v1.74 for me.
ok, thanks for verifying. I am going to validate, report my findings and close the ticket when I get home
the command i was looking for is a different one. it is like "Search: Replace in files" and what it used to do is switch to the search tab and automatically open the replace box like the following screenshot. the pc that had the command automatically updated, i was going to show the screenshot but it was too late :(. the command was no longer there !
it was this one. found it in another laptop i no longer used. i disabled wifi to prevent auto updating. !
what version is the still visible?
I saw it in the latest version as of two weeks ago. I got the screenshot from 1.71.2
Caused by a regression in , will fix after is merged
this was released in 1.74.0
Change:
// #1 `file:///DANGEROUS/PATH/resources/app/Useful/Information` // #2 // Any other file path that doesn't match the approved form above should be cleaned. // #3 "Error: ENOENT; no such file or directory" is often followed with PII, clean it <del> for (let piiPath of this._piiPaths) { this._cleanupPatterns.push([new RegExp(escapeRegExpCharacters(piiPath), 'gi'), '']); } </del> this._cleanupPatterns.push( [/file:///.*?/resources/app//gi, ''], [/file:///.*/gi, ''], [/ENOENT: no such file or directory.*?'([^']+)'/gi, 'ENOENT: no such file or directory'] ); <ins> for (let piiPath of this._piiPaths) { this._cleanupPatterns.push([new RegExp(escapeRegExpCharacters(piiPath), 'gi'), '']); } </ins> if (this._configurationService) { this._updateUserOptIn(); this._configurationService.onDidUpdateConfiguration(this._updateUserOptIn, this, this._disposables);

Discussion:
Linux/Mac: TypeError: Cannot read property 'length' of null at t.i.getLinesContent ( at t.i.toRawText ( at t.beginModelSync ( at t.esureSyncedResources ( at at then ( at t.withSyncedResources ( at t.computeDirtyDiff ( at at then ( Windows: TypeError: Cannot read property 'length' of null at t.i.getLinesContent () at t.i.toRawText () at t.beginModelSync () at t.esureSyncedResources () at at then () at t.withSyncedResources () at t.computeDirtyDiff () at at then ()
Root cause: The telemetry service strips PII of of callstacks before logging them as a telemetry event. Following regex matches are used in the process the app root (eg: /Users/me/Downloads/Visual Studio ) the extensions folder (eg: ) /file:///.?/resources/app//gi /file:///./gi A sample call stack is as follows: After the first regex replace, we have Second and Third in this case do not have any net change The Fourth regex replace removes the important filepath info leaving us with This doesn't happen in Windows because the first regex never gets any match due to conflicts between forward and back slashes, the third regex does the real job of stripping out PII along with the prefix The unit tests didnt catch this because only the last 2 regex get applied by default. The first 2 are passed as config which is done by production code but not the unit tests. So we just got lucky. Errors from extensions do not have this problem, they don't have the prefix
Change:
} } else { if (this._actionsToolbarContainer.classList.contains('tabfocused') && !this._actionsToolbarContainer.classList.contains('mouseover')) { <del> this._actionsToolbarContainer.classList.add('hidden'); </del> <ins> this.toggleToolbarHidden(true); </ins> this._domNode.tabIndex = -1; } this._actionsToolbarContainer.classList.remove('tabfocused');

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW