jiebi/CodeConvo huggingface dataset:
Change:
function nextWord(word: string, start: number): number { for (let i = start; i < word.length; i++) { const c = word.charCodeAt(i); <del> if (isWhitespace(c) || (i > 0 && isWhitespace(word.charCodeAt(i - 1)))) { </del> <ins> if (isWhitespace(c) || (i > 0 && isWhitespace(word.charCodeAt(i - 1))) || isWordSeparator(c) || (i > 0 && isWordSeparator(word.charCodeAt(i - 1)))) { </ins> return i; } }

Discussion:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-30T05:12:15.312Z) OS Version: Linux x64 4.10.0-21-generic Extensions: ; fyi ! !
The command palette doesn't use the new fuzzyScore-logic. It maybe should tho
Welcome to
I've noticed that it does in fact match characters inside parentheses, but won't match them if they're right next to the parentheses. In my example GIF below you can see the following: to match completely, due to the being next to the parentheses if I actually type the parentheses if I type words inside the parentheses but aren't next to them ! EDIT (2018-11-12): It matches if all of the the characters in inside the parentheses: ! However it won't match if i search two different parts of the text inside: !
Thanks you
Change:
const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ sync: boolean }>('showActionButton', { sync: true }); <del> // Branch does not have an upstream, commit is in progress, or the button is disabled if (!this.state.HEAD?.upstream || this.state.isCommitInProgress || !showActionButton.sync) { return undefined; } </del> <ins> // Branch does not have an upstream, commit/merge is in progress, or the button is disabled if (!this.state.HEAD?.upstream || this.state.isCommitInProgress || this.state.isMergeInProgress || !showActionButton.sync) { return undefined; } </ins> const ahead = this.state.HEAD.ahead ? ` ${this.state.HEAD.ahead}$(arrow-up)` : ''; const behind = this.state.HEAD.behind ? ` ${this.state.HEAD.behind}$(arrow-down)` : '';

Discussion:
a folder/workspace that contains a git repository a topic branch changes to main and the topic branch that would result in a merge conflict main into the topic branch to get a conflict Expected: commit action button is disabled Actual: commit action button is enabled
The button is now disabled while merging is in progress, but the button and the dropdown both take on a background color when clicked, which was confusing to me: !
Also, while the commit action button is disabled, the commit button above the input box is not: !
That is expected. At the moment the enablement is only toggled for the commit action button and not the commit action in the toolbar.
This is currently being tracked as
Change:
</dict> </array> </dict> <ins> <key>fenced_code_block_php</key> <dict> <key>begin</key> <string>(^|G)s*([`~]{3,})s*(php|php3|php4|php5|phpt|phtml|aw|ctp)s*$</string> <key>name</key> <string>markup.fenced_code.block.markdown</string> <key>end</key> <string>(^|G)(2)n</string> <key>patterns</key> <array> <dict> <key>include</key> <string>text.html.php</string> </dict> </array> </dict> </ins> <key>fenced_code_block_sql</key> <dict> <key>begin</key>

Discussion:
VSCode Version:1.1.0-alpha OS Version: Windows 10 Steps to Reproduce: a markdown file and add a code block. a function, string, etc that has an opening bracket or string Regardless of the language specified for the code block, bracket completion is not supported.
Verified that this still does not work with the new markdown extension.
Fixed via
cool! would it not make more sense to push your changes directly to master given that we pushed vscode-markdown into VSCode?
I'll send out my PR real quick (I'd like to have the push privilege after my onboard).
Change:
import { IQuickInputService } from 'vs/platform/quickinput/common/quickInput'; import { Registry } from 'vs/platform/registry/common/platform'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; <del> import { ThemeIcon } from 'vs/base/common/themables'; </del> import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; import { IWorkspaceContextService, IWorkspaceFolder, IWorkspaceFoldersChangeEvent, WorkbenchState } from 'vs/platform/workspace/common/workspace'; import { IEditorPane } from 'vs/workbench/common/editor';

Discussion:
Type: <bBug</bI'm developing an extension for VSCode and found out that I can't enable Dynamic Debug Configurations unless I include in the list of activation events. I have tried not including this activation event but having my extension activated through other means (like activated on language), but the feature doesn't work. Only when I include , this feature works. My extension is now working properly, but I wouldn't be surprised if this prevents other extension developers from using this feature. I have found this very old post of someone who might have had that exact same issue VS Code version: Code 1.84.2 (Universal) (, 2023-11-09T10:52:33.687Z) OS version: Darwin arm64 23.1.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (36)</summaryExtensionVersion ------ vscode-markdownlint0.52.0 gitlens14.5.0 prettier-vscode10.1.0 custom-local-formatters0.0.6 vscode-clangd0.1.24 vscode-mlir0.0.11 rainbow-csv3.8.0 vscode-mojo5.0.4-dev csdevkit1.0.14 csharp2.10.28 vscode-dotnet-runtime2.0.0 vscodeintellicode-csharp0.1.26 black-formatter2023.6.0 isort2023.10.1 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.10.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.321.0 remote-ssh0.107.0 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 cpptools1.18.5 cpptools-extension-pack1.3.0 remote-explorer0.4.1 remote-server1.5.0 reflow-paragraph1.3.0 errorlens3.15.0 vscode-icons12.6.0 vim1.27.0 clang-format1.9.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you explain a bit more what doesn't work?
, thanks for looking into this. I have an extension with a working debugger feature via file. I'm trying to register a DebugConfigurationProvider with kind = that implements . And, unless, I add as an activation event, my new provider doesn't get invoked at all and I don't see an entry for my debugger in the selector of the Debug View. I have confirmed that my extension was initialized right after VSCode is launched. It's as if this kind of provider is only enabled if the activation event is present.
There's some discussion about this in you've touched this too, should this be changed or just documented in
I think changing it is fine. An extension should register an activation for it, but this isn't something we enforce for any other API. Will take care of it.
Change:
"vscode-ripgrep": "^1.8.0", "vscode-sqlite3": "4.0.10", "vscode-textmate": "5.2.0", <del> "xterm": "4.9.0-beta.8", </del> <ins> "xterm": "4.9.0-beta.24", </ins> "xterm-addon-search": "0.7.0", "xterm-addon-unicode11": "0.2.0", "xterm-addon-webgl": "0.8.0",

Discussion:
Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { $, addDisposableListener, append, asCSSUrl, EventType, IModifierKeyStatus, ModifierKeyEmitter, prepend } from 'vs/base/browser/dom'; </del> <ins> import { $, addDisposableListener, append, asCSSUrl, EventType, ModifierKeyEmitter, prepend } from 'vs/base/browser/dom'; </ins> import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { ActionViewItem, BaseActionViewItem, SelectActionViewItem } from 'vs/base/browser/ui/actionbar/actionViewItems'; import { DropdownMenuActionViewItem, IDropdownMenuActionViewItemOptions } from 'vs/base/browser/ui/dropdown/dropdownActionViewItem';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.0 OS Version: Ubuntu 23.04 the panel a file Shift Terminal icon changes Shift key Terminal icon changes again When pressing in the editor, the terminal icon should stay the same. When pressing in the editor, the terminal icon switches to a different icon. The issue might haven been introduced here
FYI I've removed the prefix to the issue's title, since the observed behavior was actually our intention. I can see how on Windows and Linux, reacting on <kbdShift</kbdmight be too aggressive, so I propose doing the new behavior (no need to hover) only when <kbdAlt</kbdis pressed, while leaving <kbdShift</kbdto behave like before, on Windows and Linux.
Verification: <kbdAlt</kbdshould toggle alt state of commands no matter what On Windows and Linux only: <kbdShift</kbdshould toggle alt state of commands only when hovering them
Change:
private throttleTimer: any; private line: number | undefined = undefined; private firstUpdate = true; <del> private currentVersion?: { resource: vscode.Uri, version: number }; </del> <ins> private currentVersion?: PreviewDocumentVersion; </ins> private forceUpdate = false; private isScrolling = false; private _disposed: boolean = false;

Discussion:
Issue Type: <bBug</bSometimes the Markdown preview stops updating when I am typing if the source document is very large. It is not easy to reproduce, but when it happens, it is very annoying. Here is a video clip to describe what happened: ! Notice that at the end, no matter how long I wait, the preview never updates (two s are missing from the preview). It is acceptable if the preview has some delay if the source document is very large, but this seems like some scheduling issue that the final updates from the source document is ignored. The preview should be updated to match the source document if I wait long enough. VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
, Yes this is happening and I think this happens in the case when you change something and then wait for like 2/3 seconds and change something again and similarly repeat it or stop, Just changing once seems to be working but takes some time. , I think the refresh preview calls are getting clogged because of the way the user is updating the markdown document , Can you please confirm any way we can fix this ?
Thanks looking into this. I'm having trouble reproducing this issue but there are two places where I believe that updates to the preview could be getting out of sync: the call to itself: We're currently stabilizing vscode's master branch so I can't check this in but here's a PR that should the problem: the updates to the webview content itself. Here's the code that runs inside the webview that does the update: If you can reproduce this problem, try taking a look the PR and try it out on your local machine to see if it fixes this.
, Not sure exactly how to fix this as the issue is not consistent and when I checked it today, it seems to work ( but surely the preview refresh and sync takes some time, which is considerable for that large file) , So I leave it open for you to take a call on this. I would suggest to check it again and give it some time to update.

Please test this again on the VS Code 1.35 insiders builds that should be coming out at the end of next week
New insiders builds are out. Can you please test this again using them
It seems the problem still exists: ! The last letter is missing from the preview.
I'm closing this given that no one else has reported this issue and no one on the vs code team can reproduce it either Please investigate and submit a fix if you are consistently running into this. I've linked to most of the relevant code locations
Change:
import { registerWorkbenchContribution2, WorkbenchPhase } from '../../../common/contributions.js'; import { CommentsInputContentProvider } from './commentsInputContentProvider.js'; import { AccessibleViewProviderId } from '../../../../platform/accessibility/browser/accessibleView.js'; <ins> import { CommentWidgetFocus } from './commentThreadZoneWidget.js'; </ins> registerEditorContribution(ID, CommentController, EditorContributionInstantiation.AfterFirstRender); registerWorkbenchContribution2(CommentsInputContentProvider.ID, CommentsInputContentProvider, WorkbenchPhase.BlockRestore);

Discussion:
Type: <bFeature Request</bCC any file containing comment thread editor, move your cursor to any line having comment your cursor is on the line, press ctrl+K ctrl+I to see if the comment tolltip opens Screen reader users cannot open comment tooltip on the current line via ctrl+K ctrl+I ctrl+K ctrl+I needs to work for the comment tooltip just like other tooltips. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
the comment widget is not a tooltip. We cannot reuse this keybinding to focus the comment widget because it's possible that line will have hover info. pls lmk if you disagree. I do wonder if we should have a focus closest comment widget command/keybinding.
Aw, I see. Please then consider adding a keybinding to focus the closest comment widget. Currently, alt+F9 and shift+alt+F9 go to the next and previous comment widget, but there is no action available to focus the comment on the current line.
It does make sense to have an "Expand and focus comment at current line" command.
The new command is "Focus Comment on Current Line" with no default keybinding.
To verify: Install an extension that provides comments GitHub Pull Requests can be used for this Sign in Open the Pull Requests view Open a file diff for a PR. If there aren't any comments in the file, add a comment on one of the changed lines and collapse the comment Put your cursor on a line in a file with a collapsed comment Open the command palette and run the command "Focus Comment on Current Line" Verify that the comment has focus
This should probably be to the comments and/or the editor accessibility help dialog for discoverability.
Change:
readonly viewType = '*'; private cache = new ResourceMap<{ <del> lastUpdate: number; lastCellLang: string; lastGuess?: string; </del> <ins> contentVersion: number; updateTimestamp: number; cellLanguage: string; guess?: string; </ins> }>(); constructor(

Discussion:
The candidate fix for was to just disable language detection in notebooks by default. With a bit more time to work on it, a better solution should be derived.
is this fix insider released?
is it now :)
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.2", "xterm-addon-canvas": "0.4.0-beta.1", "xterm-addon-search": "0.11.0-beta.7", "xterm-addon-unicode11": "0.5.0-beta.5", "xterm-addon-webgl": "0.15.0-beta.1" </del> <ins> "xterm": "5.2.0-beta.10", "xterm-addon-canvas": "0.4.0-beta.6", "xterm-addon-search": "0.11.0", "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.15.0-beta.4" </ins> } }

Discussion:
! Only seems to appear if I resize the terminal such that a is on its own line.
Cannot repro: !
I can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.
Couldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)
In tried on my mac and I still can't reproduce: !
Still able to reproduce this, have passed repo steps regarding the private repo offline.
Still struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width="852" alt="Screenshot 2022-12-22 at 5 08 03 pm" src="https://user-"
This happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width="866" alt="Screenshot 2022-12-22 at 5 12 44 pm" src="https://user-"
That one repro's upstream: <img width="793" alt="Screenshot 2022-12-27 at 6 24 10 am" src="https://user-"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.
Can still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.
Update cannot repro when debugging. So odd
Update again, I can repro this again in insiders. Not sure why debugging is different.
Still can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width="632" alt="Screenshot 2023-05-08 at 6 43 07 am" src="https://user-"OSS: <img width="637" alt="Screenshot 2023-05-08 at 6 44 55 am" src="https://user-"OSS debugging: <img width="633" alt="Screenshot 2023-05-08 at 6 46 16 am" src="https://user-"cat this file:
Change:
export type TextMateThemingRuleDefinitions = { [P in keyof TokenStyleData]?: ITextMateThemingRule | undefined; } & { scope?: ProbeScope }; <ins> interface IColorOrDefaultMap { [id: string]: Color | typeof DEFAULT_COLOR_CONFIG_VALUE; } </ins> export class ColorThemeData implements IWorkbenchColorTheme { static readonly STORAGE_KEY = 'colorThemeData';

Discussion:
From Add to setting See that the editor background changes to the 'default' gray color Comment or delete the setting The background color doesn't change back to the theme color, and I can't make it go back until reloading the window
Change:
}); this._xterm.webLinksInit(wrappedHandler, { validationCallback: (uri: string, callback: (isValid: boolean) => void) => this._validateWebLink(uri, callback), <del> tooltipCallback: (e: MouseEvent) => { if (this._terminalService && this._terminalService.configHelper.config.rendererType === 'dom') { const target = (e.target as HTMLElement); this._widgetManager.showMessage(target.offsetLeft, target.offsetTop, this._getLinkHoverString()); } else { this._widgetManager.showMessage(e.offsetX, e.offsetY, this._getLinkHoverString()); } }, </del> <ins> tooltipCallback: this._tooltipCallback, </ins> leaveCallback: () => this._widgetManager.closeMessage(), willLinkActivate: (e: MouseEvent) => this._isLinkActivationModifierDown(e) });

Discussion:
Example:
Do you mind if I take on this issue? I assume the request is to make and Ctrl-clickable such that the links open the correct versions of the files.
sounds good. The link registration is done here and it's based on regexs: We basically want the and parts to be matched, but ignored as part of the link.
I'm having a bit of trouble with getting the two git blob IDs and , which are necessary to get the correct versions of the files. I tried to write a multi-line regex for that captures the blob IDs in groups, along with the paths we want to link, but currently only runs the regex on a per line basis (by iterating through the buffer), not on the whole content of the terminal. So the regex didn't find any matches. I also tried to get the blob IDs by parsing the contents of the terminal manually, but doesn't seem to offer a public interface to retrieve the contents. I do see but I don't want to rely on an internal implementation to do something like this. How do you suggest I proceed? Should I submit a PR to to allow multi-line regex in ?
I'm having a bit of trouble with getting the two git blob IDs and , which are necessary to get the correct versions of the files. Oh I wouldn't go that far, just pointing both links to the current version of the file would be good enough start with.
Ah I see, that's a lot simpler to do. Will open a PR soon.
Change:
return; } <ins> if (!configService.getValue('application.experimental.rendererProfiling')) { logService.debug(`[perf] SLOW task detected (${maxDuration}ms) but renderer profiling is disabled via 'application.experimental.rendererProfiling'`); return; } </ins> const sessionId = generateUuid(); // start heartbeat monitoring logService.warn(`[perf] Renderer reported VERY LONG TASK (${maxDuration}ms), starting profiling session '${sessionId}'`);

Discussion:
Since long we automatically profile the extension host when it becomes unresponsive. In that cases we send a signal via telemetry and in bad cases we ask users to file issues. During that we ask them to attach the corresponding profile but we have mixed results with that. So, in addition to the existing flow we want to log a richer telemetry event that uploads the heaviest sample trace from the profiling
Change:
dnd: this.treeViewDnd, overrideStyles: getLocationBasedViewColors(this.viewLocation).listOverrideStyles }) as WorkbenchAsyncDataTree<ITreeItem, ITreeItem, FuzzyScore>); <ins> this.treeDisposables.add(this.tree.onMouseOver(e => { if (e.element) { this.tree?.rerender(e.element); } })); this.treeDisposables.add(this.tree.contextKeyService.onDidChangeContext(e => { const selection = this.tree?.getSelection(); if (selection?.length) { selection.map(item => this.tree?.rerender(item)); } const focus = this.tree?.getFocus(); if (focus?.length) { focus.map(item => this.tree?.rerender(item)); } })); </ins> this.treeDisposables.add(this.tree); treeMenus.setContextKeyService(this.tree.contextKeyService); aligner.tree = this.tree;

Discussion:
It looks like everything is getting disposed properly and I haven't been able to find a way to repro. It looks like this has only been seen on builds that are 12 days old. Let's see if we see it again.
I can repro if I have a tree with ~145 elements visible, as each one has a listener for whether the inline menu items change base on context key value changes. This listener is also apparently listening for whether a menu item's "hidden state" also changes, which is where the problem occurs. It seems that every menu in the workbench listens for the same "hidden state" event.
The error telemetry should be fixed, but we're still going to listen on tree menus.
Change:
})); this.toUnhook.add(linkGesture.onExecute((mouseEvent: ClickLinkMouseEvent) => { <del> if (!this.isEnabled(mouseEvent)) { return; </del> <ins> if (this.isEnabled(mouseEvent)) { this.gotoDefinition(mouseEvent.target.position!, mouseEvent.hasSideBySideModifier) .catch((error: Error) => { onUnexpectedError(error); }) .finally(() => { this.removeLinkDecorations(); }); </ins> } <del> LinkOpener.get(this.editor)?.openLink( mouseEvent.target.range!, nls.localize('link.label', "Go to Definition"), () => { this.gotoDefinition(mouseEvent.target.position!, mouseEvent.hasSideBySideModifier) .catch((error: Error) => { onUnexpectedError(error); }) .finally(() => { this.removeLinkDecorations(); }); }); </del> })); this.toUnhook.add(linkGesture.onCancel(() => {

Discussion:
The content of the line: Open definition does nothing !
Also happens on Mac with Cmd+Click. Makes it very difficult to navigate my documentation.
I believe this is a result of fixing Markdown has a link provider and a definition provider. However in this case, the definition provider returns since we are not on a reference link
revert of the bad change is up
Change:
*/ readonly uri: string; /** <del> * The format options </del> <ins> * The sort options </ins> */ readonly options: SortOptions; }

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-22T05:24:32.270Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
This part of in-preparation release notes will also need updating: