jiebi/CodeConvo huggingface dataset:
Change:
private registerActionBarListeners(actionsContainer: HTMLElement): void { this._register(dom.addDisposableListener(this._domNode, 'mouseenter', () => { <del> actionsContainer.classList.remove('hidden'); </del> <ins> this.toggleToolbarHidden(false); </ins> actionsContainer.classList.add('mouseover'); })); this._register(dom.addDisposableListener(this._domNode, 'mouseleave', () => { if (actionsContainer.classList.contains('mouseover') && !actionsContainer.classList.contains('tabfocused')) { <del> actionsContainer.classList.add('hidden'); </del> <ins> this.toggleToolbarHidden(true); </ins> } actionsContainer.classList.remove('mouseover'); }));

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW
Change:
const workbenchBackground = WORKBENCH_BACKGROUND(theme); collector.addRule(`.monaco-workbench { background-color: ${workbenchBackground}; }`); <ins> // Selection (do NOT remove - https://github.com/microsoft/vscode/issues/169662) const windowSelectionBackground = theme.getColor(selectionBackground); if (windowSelectionBackground) { collector.addRule(`.monaco-workbench ::selection { background-color: ${windowSelectionBackground}; }`); } </ins> // Update <meta name="theme-color" content=""> based on selected theme if (isWeb) { const titleBackground = theme.getColor(TITLE_BAR_ACTIVE_BACKGROUND);

Discussion:
open quick input or the find widget type and select some text observe that the selection is not rendered (this happened with this insiders update, I'm quite sure it was working in yesterday's insiders) https://user-
So it looks like the use of CSS variables in some cases is dangerous. Here explains a bit more. My fix is to revert back to how it was for
Change:
// Do not crash if spdlog cannot be loaded try { const _spdlog = await import('spdlog'); <del> _spdlog.setFlushOn(LogLevel.Trace); </del> <ins> _spdlog.setFlushOn(SpdLogLevel.Trace); </ins> const logger = await _spdlog.createAsyncRotatingLogger(name, logfilePath, filesize, filecount); if (donotUseFormatters) { logger.clearFormatters();

Discussion:
OSS log level to trace at Telemetry (Logging Only) The bottom entry always seems to be clipped, but once more info is populated it fills in so it's not like the data isn't logged.
Change:
import * as assert from 'assert'; import { $ } from 'vs/base/browser/dom'; <del> import { GridView, IView, Sizing } from 'vs/base/browser/ui/grid/gridview'; </del> <ins> import { GridView, IView, Orientation, Sizing } from 'vs/base/browser/ui/grid/gridview'; </ins> import { nodesToArrays, TestView } from './util'; suite('Gridview', function () {

Discussion:
Was finally able to repo this but not reliably. It seems to rely on a new being created, but this doesn't always happen. The most reliable repo for me: with a notebook and text editor in a single editor group the notebook editor down to create a new group below the text editor grab the notebook editor and drag it right to move the bottom editor to the right I think the root cause is that the notebook widget is passed the wrong position. I'm going to work around this by making the notebook editor ignore the position it is given, however this will also undo the performance fixes we made this iteration for notebook layout I don't fully understand the grid layout code but it seems that is being set incorrectly in cases where a new BranchNode/SplitView is created. Here's what I see happening after step 3 of the repo above: setter is called calls which creates a new the constructor, a new Split View is created is called on it. At this point, of the split view is: the time layout is called on the notebook editor widget, is computed as zero. This results in the wrong layout. Looking at the code, we can see that is passed in as the absolute offset in step 4: <img width="1104" alt="Screenshot 2022-11-30 at 12 48 54 PM" src="https://user-"If I then slightly resize the window, here's what happens: call on the split View for the new group now is: we layout the notebook editor, is now correctly computed as Originally posted by in
Change:
private createPickItems(): ContinueEditSessionItem[] { const items = [...this.continueEditSessionOptions].filter((option) => option.when === undefined || this.contextKeyService.contextMatchesRules(option.when)); <del> if (getVirtualWorkspaceLocation(this.contextService.getWorkspace()) !== undefined) { </del> <ins> if (getVirtualWorkspaceLocation(this.contextService.getWorkspace()) !== undefined && isNative) { </ins> items.push(new ContinueEditSessionItem( localize('continueEditSessionItem.openInLocalFolder', 'Open In Local Folder'), openLocalFolderCommand.id,

Discussion:
Steps: some changes on the "continue working on..." command and open in desktop :bug: VS Code opens but nothing loads https://user- Desktop Version: 1.70.0-insider (Universal) Commit: Date: 2022-07-26T05:17:37.262Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Darwin arm64 21.6.0 Web Version: 1.70.0-insider Commit: Date: 2022-07-26T05:17:04.193Z Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.5060.114 Safari/537.36
This action should be disabled in since we cannot access the local filesystem from the browser.
I'm still able to run the command from insiders vscode dev in Firefox. My Desktop Insiders then opens the repo using remote repositories but on the main branch instead of the branch I was working on. I'm not sure if this is the expected behaviour
I verified that this now works as expected https://user-
Change:
import type { Terminal } from 'xterm'; import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { CodeActionController } from 'vs/editor/contrib/codeAction/browser/codeActionController'; <ins> import { localize } from 'vs/nls'; </ins> const enum ClassName { Active = 'active',

Discussion:
Type: <bBug</bTerminal buffer does not have aria label and currently being read as "Editor content edit" to screen readers. Please add aria-label, such as "terminal buffer." VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-04T05:35:09.023Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (91)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 dscodegpt2.1.15 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.20.0 gitlens14.2.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.14.14 copilot1.100.313 copilot-chat0.7. remotehub0.60.0 vscode-github-actions0.26.1 vscode-pull-request-github0.70.0 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.4 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.14.0 vscode-pylance2023.8.10 jupyter2023.7.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.81.0 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.8.417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.91.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 chatgpt1.1.2 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.53.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.13 vscode-java-test0.39.1 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
return super.installFromGallery(extension, installOptions); } <ins> override async installGalleryExtensions(extensions: InstallExtensionInfo[]): Promise<InstallExtensionResult[]> { const infos: InstallExtensionInfo[] = []; for (const extension of extensions) { infos.push({ ...extension, options: { ...extension.options, profileLocation: extension.options?.profileLocation ? (await this.getProfileLocation(extension.options?.profileLocation)) : undefined } }); } return super.installGalleryExtensions(infos); } </ins> override async uninstall(extension: ILocalExtension, options?: UninstallOptions): Promise<void> { options = { ...options, profileLocation: await this.getProfileLocation(options?.profileLocation) }; return super.uninstall(extension, options);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Settings Sync is broken when trying to access headless code tunnels from the web portal. I have not had this issue in the past and had updates set to manual. Last week I decided to update and that is when Settings Sync broke. I am getting the same results in Edge, Chrome, and Firefox. I am getting the same results in AlmaLinux and Ubuntu Server Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.81.1 OS Version: AlmaLinux 8.8 (also tested with Ubuntu Server 22.04) Steps to Reproduce: code cli and run tunnel: to '{tunnel-name}/tmp' Settings Sync the Settings Sync log output
Are you able to reproduce this when you enable settings sync on ?
No, I don't get these errors when I enable settings sync on , however most of my extensions are not able to install due to "... is not available in Visual Studio Code for the Web" . It seems to be only when I use tunnels on that I get the errors described in OP.
I just tried the new feature, hoping I could use that in the meantime until this issue is resolved, however, even that is giving me the same Settings Sync errors.
I tried and I do not see any issue. Can you please try installing extensions by going to extension view and see if it works?
Yes, I am able to manually install extensions, however, the issue I am having is with Settings Sync as stated in the original post. Also, the cli output logs is getting flooded with these errors when I enable Settings Sync.
I have confirmed your fix solved my issue. Thank you so much! Looking forward to the August release!
Marking as verified based on the message before.
Change:
function onValue(value: any) { if (Array.isArray(currentParent)) { (<any[]>currentParent).push(value); <del> } else if (currentProperty) { </del> <ins> } else if (currentProperty !== null) { </ins> currentParent[currentProperty] = value; } }

Discussion:
Issue Type: <bBug</bI currently store some arbitrary JSON-serializable object using and updating keys. At the top level, my configuration variable is an array, and each element is a dictionary that contains some keys. One of those keys map to a value like this: This sets fine, and I can look in my workspace's to see all keys and values there as expected. However, when I try to get the value from the workspace configuration again, the empty string key and its value are missing, meaning I unable to retrieve the array with in it. So it seems VSCode filters out keys which are blank strings when reading workspace configurations, although it will set/save them. This is currently blocking a project I'm working on and should be a trivial fix. VS Code version: Code 1.57.1 (, 2021-06-17T13:28:07.755Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --
I am sorry that I do not understand the usage of the API here and what is being done. Can you please provide a sample code snippet to reproduce the issue?
Here's a round trip example of me saving an object to the workspace configuration, and retrieving it. It shows all data is stored appropriately, but data is lost when reading it back if a blank string key exists. The message will be shown. If you comment out/remove the key-value pair in , it will instead say . So VSCode is losing data when obtaining data from the workspace configuration if you store an object which has a blank key somewhere (at any level of depth).
There was a fairly quick initial response here, but since then a good amount of time has elapsed. Has there been any progress updates or planning related to this issue? Can you confirm you now understand the issue given the above proof-of-concept? It should be very clear.
Thanks for the info. It is in my list of issues to investigate, I will try it out and get back to you.
Change:
const pick = await window.showWarningMessage(message, { modal: true }, yes, always, never); if (pick === always) { <ins> enableSmartCommit = true; </ins> config.update('enableSmartCommit', true, true); } else if (pick === never) { config.update('suggestSmartCommit', false, true); return; <del> } else if (pick !== yes) { return; // do not commit on cancel </del> <ins> } else if (pick === yes) { enableSmartCommit = true; } else { // Cancel return; </ins> } }

Discussion:
Type: <bBug</b- Make a change to a file in a directory with Git setup Without staging it manually, write a commit message and press the commit button A popup will show up. Confirm that you'd like to stage all files. Observe how you get an error message and no changes get staged VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-05T00:00:00.000Z) OS version: Darwin arm64 23.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (22) - also tested with all extensions disabled and same result</summaryExtensionVersion ------ ruff2024.30.0 gitlens15.1.0 copilot1.211.0 copilot-chat0.17.0 discord-vscode5.8.0 debugpy2024.7. python2024.11. vscode-pylance2024.6.104 jupyter2024.6.0 jupyter-keymap1.1.2 remote-containers0.377.0 remote-ssh0.113. remote-ssh-edit0.86.0 remote-wsl0.88.2 remote-explorer0.5. material-icon-theme5.4.2 run-on-save1.9.0 developer-theme-dark5.0.0 svelte-vscode108.5.4 highlight-matching-tag0.11.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thank you very much for reporting this issue. Fix should be available in tomorrow's VS Code Insiders release.
Change:
assert.strictEqual(generated, label); }); }); <ins> test('relative label with explicit path separator', () => { let generated = labelService.getUriLabel(URI.parse('myscheme://myauthority/some/folder/test.txt'), { relative: true, separator: '/' }); assert.strictEqual(generated, 'some/folder/test.txt'); generated = labelService.getUriLabel(URI.parse('myscheme://myauthority/some/folder/test.txt'), { relative: true, separator: '' }); assert.strictEqual(generated, 'somefoldertest.txt'); }); </ins> });

Discussion:
We only respect the setting when a is found: We should always support the separator.
//cc
Went ahead with a fix myself because I figured it is more involved: without formatting we cannot just add the separator so I ended up using the method that matches the config in that case on the relative path.
Thanks for the proper fix! I had couple of attempts but first failed when list of files in with stopped to work (apparently needed ) Second was but it produced different results for and . Haven't thought about using same normalization as in
what are some verification steps for this issue?
thanks for bringing this up. Steps from : different values for "Copy relative path" for some nested filed - separators should match selection (or system separator for ) I've checked latest version in and looks like fix doesn't work at this moment: apparently won't replace with ! Maybe it make sense to use ?
is a valid character in filenames on POSIX so this is a bit tricky... I don't think we should ever convert it to on a POSIX system as that would represent a totally different resource.
Yep, in name is tricky but is it common case? Anyway: Alternative option will be to "force" path formatting which will work with and I'm assume it will always have as separator that later converted to if needed without causing problem with -that might replace from filenames This will be "similar" to missing formatting as would work with it as with path anyway. But then there will be inconsistency with : - relative as expected, expected separator- relative as expected, expected separator- - not expected but return full path (same as current behavior in ) as it's processed with , separator not supported at all. I'm not sure why returns full path but I guess it's incorrect setup for in web playground, as works OK for files in VS Code desktop.
Reopening with verification steps web on windows .copyRelativePathSeparator: a path from the memfs system that it still uses I can take this as I own label service from Going to push out as products are not affected.
It looks like the code that is typically doing this conversion when a formatting is there is this one: Maybe we can do something similar instead of and replace any of or with the separator.
Change:
import { EditorInput } from 'vs/workbench/common/editor/editorInput'; import { ILanguageSupport } from 'vs/workbench/services/textfile/common/textfiles'; <ins> /* hot-reload:patch-prototype-methods */ </ins> export class MultiDiffEditorInput extends EditorInput implements ILanguageSupport { static readonly ID: string = 'workbench.input.multiDiffEditor';

Discussion:
Type: <bBug</bWhen reviewing outgoing changes for my tracking fork of microsoft/vscode after merging upstream/main into my local copy today. ! Also, based on I was surprised to see the magnifying glass icon still being used for "View Changes". VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-22T05:35:23.085Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
/assign
I'm very sure this is a duplicate of
This sounds like there was no insiders for today. Can you check you are running the build from today? The PR just got merged yesterday.
Yes, this is today's. The new codicon appears in the Timeline view, just not in the incoming/outgoing party of Source Control view: !
It does for me: !
Ah, we're not talking about the same thing. My screenshot is of the feature recently by and controlled by the and settings. It comes from here:
are you able to reproduce this consistently? Could you provide steps that that I should use to try to reproduce the issue? Thanks!
in said it was probably a known issue. Ever since Insiders got that fix I haven't had any problems opening multi-diff for outgoing changes that get listed after I merge from upstream/main into my local main prior to pushing them to origin/main (my tracking repo). So I'm closing this one.
thanks for the update!
Hmm, just happened to me again with today's Insiders: ! Reopening. I'll hold back from pushing the local changes that I merged in from upstream/main in case there are places you'd like me to look for clues while I can repro it.
Devtools console:
It's this one: ! And specifically which is of course binary: ! I guess the multi diff editor needs to handle this case gracefully instead of failing to show the diffs for the other files.
thanks! could you please take a look? Thanks!
Ahh, because it is a binary file...
Change:
} } <ins> public shouldSuppressMouseDownOnWidget(widgetId: string): boolean { if (this._widgets.hasOwnProperty(widgetId)) { let widgetData = this._widgets[widgetId]; return widgetData.widget.suppressMouseDown; } return false; } </ins> private _layoutBoxInViewport(position:Position, domNode:HTMLElement, ctx:IRenderingContext): IBoxLayoutResult { let visibleRange = ctx.visibleRangeForPosition(position);

Discussion:
VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.
I'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)
PR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.
Change:
} const additionalGroups: ISettingsGroup[] = []; <del> const toggleData = await getExperimentalExtensionToggleData(this.extensionGalleryService, this.environmentService, this.productService); </del> <ins> const toggleData = await getExperimentalExtensionToggleData(this.extensionGalleryService, this.productService); </ins> if (toggleData && groups.filter(g => g.extensionInfo).length) { for (const key in toggleData.settingsEditorRecommendedExtensions) { const extension = toggleData.recommendedExtensionsGalleryInfo[key];

Discussion:
On the latest Stable or Insiders, the Copilot setting button does not show up in the Settings editor when the Copilot extension is disabled or not installed. ! removed the dependency on the assignment/experimentation service incorrectly, and ended up making it so that the feature was only available in OSS aka from-source builds. The main branch fix is available in The candidate PR is available in . [x] Set up a candidate PR