jiebi/CodeConvo huggingface dataset:
Change:
}; this._register(this._altKey.event(updateAltState)); <del> updateAltState(this._altKey.keyStatus); </del> <ins> if (isWindows || isLinux) { this._register(addDisposableListener(container, 'mouseleave', _ => { mouseOverOnWindowsOrLinux = false; updateAltState(); })); this._register(addDisposableListener(container, 'mouseenter', _ => { mouseOverOnWindowsOrLinux = true; updateAltState(); })); } updateAltState(); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.0 OS Version: Ubuntu 23.04 the panel a file Shift Terminal icon changes Shift key Terminal icon changes again When pressing in the editor, the terminal icon should stay the same. When pressing in the editor, the terminal icon switches to a different icon. The issue might haven been introduced here
FYI I've removed the prefix to the issue's title, since the observed behavior was actually our intention. I can see how on Windows and Linux, reacting on <kbdShift</kbdmight be too aggressive, so I propose doing the new behavior (no need to hover) only when <kbdAlt</kbdis pressed, while leaving <kbdShift</kbdto behave like before, on Windows and Linux.
Verification: <kbdAlt</kbdshould toggle alt state of commands no matter what On Windows and Linux only: <kbdShift</kbdshould toggle alt state of commands only when hovering them
Change:
[ localize('untrustedTasks', "Tasks are disabled"), localize('untrustedDebugging', "Debugging is disabled"), <del> localize('untrustedExtensions', "[{0} extensions](command:{1}) are disabled or have limited functionality", numExtensions, LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID) </del> <ins> localize('untrustedExtensions', "[{0} extensions]({1}) are disabled or have limited functionality", numExtensions, `command:${LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID}`) </ins> ] : [ localize('untrustedTasks', "Tasks are disabled"), localize('untrustedDebugging', "Debugging is disabled"), <del> numSettings ? localize('untrustedSettings', "[{0} workspace settings](command:{1}) are not applied", numSettings, 'settings.filterUntrusted') : localize('no untrustedSettings', "Workspace settings requiring trust are not applied"), localize('untrustedExtensions', "[{0} extensions](command:{1}) are disabled or have limited functionality", numExtensions, LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID) </del> <ins> numSettings ? localize('untrustedSettings', "[{0} workspace settings]({1}) are not applied", numSettings, 'command:settings.filterUntrusted') : localize('no untrustedSettings', "Workspace settings requiring trust are not applied"), localize('untrustedExtensions', "[{0} extensions]({1}) are disabled or have limited functionality", numExtensions, `command:${LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID}`) </ins> ]; this.renderLimitationsListElement(untrustedContainer, untrustedContainerItems, xListIcon.classNamesArray);

Discussion:
Not sure if this is a German only problem <img width="440" alt="capture" src="https://user-"
This is probably a generic issue. Command should not get translated. Is there a way to ignore a substring of the localization string so that it doesn't get translated? I guess we could use interpolation...
This is a generic problem. Here's pseudo language: !
Any specific verification steps? I tried changing my display language (to German) but the workspace trust page doesn't seem localized yet: !
Verified this by looking at the language packs in the vscode-loc repo. It's currently in English but translations take some time.
Change:
'disable-chromium-sandbox': { type: 'boolean', description: localize('argv.disableChromiumSandbox', "Disables the Chromium sandbox. This is useful when running VS Code as elevated on Linux and running under Applocker on Windows.") <ins> }, 'use-inmemory-secretstorage': { type: 'boolean', description: localize('argv.useInMemorySecretStorage', "Ensures that an in-memory store will be used for secret storage instead of using the OS's credential store. This is often used when running VS Code extension tests or when you're experiencing difficulties with the credential store.") </ins> } } };

Discussion:
Originally posted by in This was mostly an oversight on my part.
Fixed in In the (Configure Runtime Arguments) we have two improvements: both and now show up in completions (they no longer say "not allowed") in is plumbed through properly
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
verification: run: make sure and show up in completions make sure you are currently logged in to any account and have an extension that asks for auth now set to restart VS Code you should be asked to log in because you are now using the inmemory store remote the setting from your now restart VS Code you should be logged in again because you are no longer using the inmemory store
Sorry the completion should only be seen on Linux
Change:
registerTerminalContribution(TerminalChatController.ID, TerminalChatController, false); <ins> registerWorkbenchContribution2(TerminalChatEnabler.Id, TerminalChatEnabler, WorkbenchPhase.AfterRestored); </ins> // #endregion // #region Contributions

Discussion:
The context key used in terminal and notebook chat which is wrong because it signals that there is a chat participant for the editor location and it doesn't know anything about other locations.
It's now removed from the notebook side.
Change:
assert.deepStrictEqual(host.errors[1][0], idA); }); <ins> test('issue #144518: Problem with git extension and vscode-icons', async () => { const extActivationA = new ExtensionActivationPromiseSource(); const extActivationB = new ExtensionActivationPromiseSource(); const extActivationC = new ExtensionActivationPromiseSource(); const host = new PromiseExtensionsActivatorHost([ [idA, extActivationA], [idB, extActivationB], [idC, extActivationC] ]); const activator = createActivator(host, [ desc(idA, [idB]), desc(idB), desc(idC), ]); activator.activateByEvent('*', false); assert.deepStrictEqual(host.activateCalls, [idB, idC]); extActivationB.resolve(); await timeout(0); assert.deepStrictEqual(host.activateCalls, [idB, idC, idA]); extActivationA.resolve(); }); </ins> class SimpleExtensionsActivatorHost implements IExtensionsActivatorHost { public readonly activateCalls: ExtensionIdentifier[] = []; public readonly errors: [ExtensionIdentifier, Error | null, MissingExtensionDependency | null][] = [];

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0 OS Version: Fedora 35 Steps to Reproduce: extension (v11.10.0) vscode, git extension is not initialized and restart, git extension works again With vscode-icons disabled With vscode-icons enabled
Reproduces with the following extension: : :
Change:
displayName: "Skip tests" type: boolean default: false <del> - name: VSCODE_BUILD_ESM # TODO@bpasero remove me once ESM is shipped </del> <ins> - name: VSCODE_BUILD_ESM # TODO@bpasero TODO@esm remove me once ESM is shipped </ins> displayName: "️❗ Build as ESM (!FOR TESTING ONLY!) ️❗" type: boolean default: false

Discussion:
We lost changes that where ESM relevant. I am trying to fix it in our ESM branch, maybe backport it from there: The old code also had this line, which I am not sure is needed: cc
Sorry about that. Is this for Monaco or the esm work? I'd love to get a point where we can just have this as a normal dependency instead of copying it into our sources. Marked now publishes both a commonjs and esm builds too. Is there some way VS Code could use Marked as a normal dependency in a way that would also work for Monaco? If I recall we've tried to avoid adding real dependencies to Monaco
I only noticed for our work, not sure about Monaco ESM. Would be great to get it working again on .
I think the ESM work will unblock this. esbuild will be able to bring in and include node modules into our bundle, the AMD bundler we currently use can only bundle AMD modules and not commonjs modules.
I would have hoped that the Monaco Editor checks would have caught this. Is there something we should improve there?
For monaco-editor-core, these are the only tests: It does not test markdown features.
Change:
return undefined; } <ins> async getActiveWindowPosition(): Promise<IRectangle | undefined> { const activeWindow = this.windowsMainService.getFocusedWindow() || this.windowsMainService.getLastActiveWindow(); if (activeWindow) { return activeWindow.getBounds(); } return undefined; } </ins> openWindow(windowId: number | undefined, options?: IOpenEmptyWindowOptions): Promise<void>; openWindow(windowId: number | undefined, toOpen: IWindowOpenable[], options?: IOpenWindowOptions): Promise<void>; openWindow(windowId: number | undefined, arg1?: IOpenEmptyWindowOptions | IWindowOpenable[], arg2?: IOpenWindowOptions): Promise<void> {

Discussion:
atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor. in these two examples, i have one large curved secondary monitor where vs code is. open an aux window, and it spawns it in my laptop's screen. same thing if full screened on secondary monitor. different when full screen on main screen (see ) wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.
that should be possible if you provide the coordinates for where to open the window via : You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the . Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
if (fragment.hasChildNodes()) { if (highlightRange) { const highlightDecoration = this._editor.createDecorationsCollection(); <del> try { this._isChangingDecorations = true; highlightDecoration.set([{ range: highlightRange, options: ContentHoverController._DECORATION_OPTIONS }]); } finally { this._isChangingDecorations = false; } </del> <ins> highlightDecoration.set([{ range: highlightRange, options: ContentHoverController._DECORATION_OPTIONS }]); </ins> disposables.add(toDisposable(() => { <del> try { this._isChangingDecorations = true; highlightDecoration.clear(); } finally { this._isChangingDecorations = false; } </del> <ins> highlightDecoration.clear(); </ins> })); }

Discussion:
I was trying to copying a new setting in the problems hover and it was extremely painful to do so: https://user-
This is editor hover and hence assigning to
FWIW this works fine for me on Windows.
Change:
.map(e => new StandardKeyboardEvent(e)) .filter(e => e.keyCode === KeyCode.Enter) .event; <del> const onOpen = Event.any(onClick, onEnterPress); </del> <ins> const onOpen = Event.any<EventLike>(onClick, onEnterPress); </ins> <del> this._register(onOpen(_ => openerService.open(link.href))); </del> <ins> this._register(onOpen(e => { EventHelper.stop(e, true); openerService.open(link.href); })); </ins> this.applyStyles(); }

Discussion:
Steps to Reproduce: a breakpoint into debug viewlet on link to create mock debug config = dispose of the workbench is triggered
Change:
button.enabled = action.enabled; button.label = action.label; <del> }); </del> <ins> } </ins> } }

Discussion:
<img width="628" alt="image" src="https://user-"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width="306" alt="image" src="https://user-"
The "Go to Review" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?
Catching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width="423" alt="CleanShot 2022-04-18 at 09 09 03 src="https://user-"
Thanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.
Verified. I assume that Go to Review button is renamed to Start Review !
The Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.
Change:
const originalUri = toGitUri(modifiedUri, '~'); const originalDocument = await workspace.openTextDocument(originalUri); <del> const selectionsBeforeRevert = textEditor.selections; </del> const visibleRangesBeforeRevert = textEditor.visibleRanges; const result = applyLineChanges(originalDocument, modifiedDocument, changes);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.
We might just have to set the cursor in that position, should be simple. Would you like to submit a PR?
I can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..
Hi, I would like to work on this issue. I'll submit a PR soon.
Do we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.
Sounds good.
Change:
let index = (options && typeof options.index === 'number') ? options.index : targetView.count; sourceView.editors.forEach(editor => { const inactive = !sourceView.isActive(editor) || this._activeGroup !== sourceView; <del> const copyOptions: ICopyEditorOptions = { index, inactive, preserveFocus: inactive }; </del> <ins> const sticky = sourceView.isSticky(editor); const copyOptions: ICopyEditorOptions = { index: !sticky ? index : undefined, inactive, preserveFocus: inactive }; </ins> if (options?.mode === MergeGroupMode.COPY_EDITORS) { sourceView.copyEditor(editor, targetView, copyOptions);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: OS Version: Steps to Reproduce: -click one or more tabs and select . or move other tabs to another Editor Group. and select there are no longer any pinned tabs. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?:
can you give a bit more precise steps, in your summary you talk about "Join All Editor Groups" but in your "Steps to reproduce" I see no mention.
Thanks good catch. I've the missing step.
Yeah I can reproduce. Probably a regression from when we decided that pinned tabs should not survive pinned state when splitting, but in this case it would make sense to keep it. Up for grab if someone has cycles.
Wow, that fix was rapid!
Change:
import { Readable } from 'stream'; import { bufferToStream, VSBuffer, VSBufferReadableStream } from 'vs/base/common/buffer'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; <del> import { Schemas } from 'vs/base/common/network'; </del> <ins> import { FileAccess, Schemas } from 'vs/base/common/network'; </ins> import { URI } from 'vs/base/common/uri'; import { FileOperationError, FileOperationResult, IFileService } from 'vs/platform/files/common/files'; import { IRemoteConnectionData } from 'vs/platform/remote/common/remoteAuthorityResolver';

Discussion:
The context is: and the deprecation of I noticed 2 uses of that ideally we can replace with and : I would have done it but wasn't exactly sure, my guess would be to use the variant here since we are in context.
Right now it looks like returns a uri. Will it instead return a uri as part of ?
sorry, forgot to mention: currently on I have just put stubs that do nothing, but in the branch, you will: get a scheme when using get a scheme when using As long as you are in environments, it should be unless you add this to a renderer (e.g. DOM).
Change:
type optionalRenderOptions = { [k in keyof RenderOptions]?: RenderOptions[k] }; <ins> type handler = (e: RenderOptions) => any; const settingsChangedHandlers: handler[] = []; function fireSettingsChange(options: optionalRenderOptions) { settingsChangedHandlers.forEach((handler) => handler(options as RenderOptions)); } </ins> function createContext(settings?: optionalRenderOptions): IRichRenderContext { <ins> settingsChangedHandlers.length = 0; </ins> return { setState(_value: void) { }, getState() { return undefined; },

Discussion:
a cell with enough output to truncate scroll the link to view as a scrollable element :bug: output height is stretched to show entire output without scrollable region
Change:
## Run <del> The best way to run the Code tests is from the terminal. To make development changes to unit tests you need to be running `gulp`. See [Development Workflow](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#incremental-build) for more details. From the `vscode` folder run: </del> <ins> The best way to run the Code tests is from the terminal. To make development changes to unit tests you need to be running `yarn run watch`. See [Development Workflow](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#incremental-build) for more details. From the `vscode` folder run: </ins> **OS X and Linux**

Discussion:
At , there are instructions to have running when making development changes to the tests. In my experience, I did not have gulp installed because it wasn't part of the "How to Contribute" instructions, but the normal was able to build a new test suite. Should this be changed?
Change:
private _readOnly: boolean; private _cursorBlinking: TextEditorCursorBlinkingStyle; private _cursorStyle: TextEditorCursorStyle; <del> private _cursorSmoothCaretAnimation: boolean; </del> <ins> private _cursorSmoothCaretAnimation: 'off' | 'explicit' | 'on'; </ins> private _selectionIsEmpty: boolean; private _isComposingInput: boolean;

Discussion:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting.

See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.