jiebi/CodeConvo huggingface dataset:
Change:
// If auto save is enabled, save all non-untitled working copies // and then check again for dirty copies if (this.filesConfigurationService.getAutoSaveMode() !== AutoSaveMode.OFF) { // Save all dirty working copies

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: Windows_NT x64 10.0. Auto Save by onFocusChange does not sync internal cache when direct quitting by 'X' button. Steps to Reproduce: settings: "Files: Auto Save" =onFocusChange a text file and save it somewhere. the file a little more. But this time, do not save or change focus and just press 'X' button directly to quit. the text file again with vscode. to save the file. Now you can see this error message: "Failed to save '...': The content of the file is newer." <img width="341" alt="image" src="https://user-"
That is weird, we trigger auto save on shutdown unless auto save is turned off: Does this still reproduce in all projects?
Oh nice I can reproduce, looks really like a bug.
Great catch!
Thank you for your response and effort on this issue!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
readonly extension: IExtensionDescription, ) { super(); <ins> this.setLevel(logger.getLevel()); </ins> this._register(logger.onDidChangeLogLevel(level => this.setLevel(level))); } get logLevel(): LogLevel { <del> return this.logger.getLevel(); </del> <ins> return this.getLevel(); </ins> } appendLine(value: string): void {

Discussion:
the command palette, set log level to the window the current log level in the command palette It wrongly indicates . !
Change:
return result.replace(new RegExp('' + this.pathSeparator, 'g'), '/'); } <ins> private get inMemoryResourcePrefix(): string { return this._apiVersion.has270Features() ? '^' : ''; } </ins> public asUrl(filepath: string): Uri { <del> if (filepath.startsWith(TypeScriptServiceClient.WALK_THROUGH_SNIPPET_SCHEME_COLON) || (filepath.startsWith(fileSchemes.untitled + ':') && this._apiVersion.has213Features()) ) { return Uri.parse(filepath); </del> <ins> if (this._apiVersion.has213Features()) { if (filepath.startsWith(TypeScriptServiceClient.WALK_THROUGH_SNIPPET_SCHEME_COLON) || (filepath.startsWith(fileSchemes.untitled + ':')) ) { let resource = Uri.parse(filepath); if (this.inMemoryResourcePrefix) { const dirName = path.dirname(resource.path); const fileName = path.basename(resource.path); if (fileName.startsWith(this.inMemoryResourcePrefix)) { resource = resource.with({ path: path.join(dirName, fileName.slice(this.inMemoryResourcePrefix.length)) }); } } return resource; } </ins> } return Uri.file(filepath); }

Discussion:
VSCode Version: Code 1.19.1 (, 2017-12-19T09:46:02.926Z) OS Version: Windows_NT ia32 10.0. Extensions: Extensions are disabled Steps to Reproduce: / Interactive Playground Under heading IntelliSense, the text reads: It it unclear what error underline means, I don't see any underline or error.
I can reproduce on the 2nd time: playground tab playground No errors shown & IntelliSense not working & rename & code formatting & // ts-check ...
Yes, opening playground a second time seems to be key to all the problems I was having with it. Thanks.
VSCode Version: Code - Insiders 1.20.0-insider (, 2017-12-22T06:14:07.615Z) OS Version: Linux x64 4.9.72-1-lts Extensions: none Also happens every time for me in Interactive Playground with no extensions loaded w/ insiders on linux. If restarting vscode repeatedly, sometimes syntax highlight also fails. EDIT: As I continued on down through the document, some other instructions are failing too.
VSCode Version: Code 1.19.1 (, 2017-12-19T09:35:14.671Z) OS Version: Darwin x64 16.7.0 Extensions: none I just got VSCode for the first time, fresh install on macOS, and experienced the same issue with different features in the Interactive Playground described here by the peeps above. Don't have much to add in terms of describing/reproducing the issue, just posting here for completeness that the issue affects 1.19.1 on OSX as well.
I see this when opening without a folder. The missing errors also reproduce in an untitled file in JavaScript mode (code actions seem to work in this case). Code actions do not work in the interactive playground when the workbench is not open on a folder. Could you take a look?
Note that this still requires this upstream fix from TS ()
Change:
const visibleRanges = editor.getVisibleRanges(); if (visibleRanges.length > 0) { visiblePosition = visibleRanges[0].getStartPosition(); <del> const cursorPos = editor.getPosition(); if (cursorPos) { const isVisible = visibleRanges.some(range => range.containsPosition(cursorPos)); if (isVisible) { // Keep cursor pos fixed if it is visible visiblePosition = cursorPos; } } </del> const visiblePositionScrollTop = editor.getTopForPosition(visiblePosition.lineNumber, visiblePosition.column); visiblePositionScrollDelta = editor.getScrollTop() - visiblePositionScrollTop; }

Discussion:
Reported by Delete lines using cmd+shift+k and notice how the editor scrolls up. !
Change:
- Clone [microsoft/vscode-html-languageservice](https://github.com/microsoft/vscode-html-languageservice) - Run `yarn` in `vscode-html-languageservice` - Run `yarn link` in `vscode-html-languageservice`. This will compile and link `vscode-html-languageservice` <del> - In `html-language-features/server/`, run `npm link vscode-html-languageservice` </del> <ins> - In `html-language-features/server/`, run `yarn link vscode-html-languageservice` </ins> #### Testing the development version of `vscode-html-languageservice`

Discussion:
Issue Type: <bBug</bClone VS Code repo Follow the instructions for linking vscode-html-language-service will fail, as the project/extension has since moved to yarn. works fine. VS Code version: Code 1.62.0 (, 2021-11-03T15:23:01.379Z) OS version: Windows_NT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 4.19.128-microsoft-standard <!-- generated by issue reporter --
Change:
let versionId = this.versionId; this.trace(`doSave(${versionId}) - enter with versionId ${versionId}`); <ins> // Return early if saved from within save participant to break recursion // // Scenario: a save participant triggers a save() on the model if (this.ignoreSaveFromSaveParticipants) { this.trace(`doSave(${versionId}) - exit - refusing to save() recursively from save participant`); return; } </ins> // Lookup any running pending save for this versionId and return it if found // // Scenario: user invoked the save action multiple times quickly for the same contents

Discussion:
This is a follow-up from and describes the problem that save participants causing a save operation
reproduced when undoing some fixes (applying the fix below)
fyi
Change:
}, this); const pick = await new Promise<{ selected: KernelQuickPickItem | undefined; items: KernelQuickPickItem[] }>((resolve, reject) => { <del> quickPick.onDidAccept(() => { </del> <ins> localDisposableStore.add(quickPick.onDidAccept(() => { </ins> const item = quickPick.selectedItems[0]; if (item) { resolve({ selected: item, items: quickPick.items as KernelQuickPickItem[] });

Discussion:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:
Change:
} /** <ins> * A regex that extracts the link suffix which contains line and column information. The link suffix * must terminate at the end of line. */ const linkSuffixRegexEol = new Lazy<RegExp>(() => generateLinkSuffixRegex(true)); /** </ins> * A regex that extracts the link suffix which contains line and column information. */ <del> const linkSuffixRegexEol = new Lazy<RegExp>(() => { </del> <ins> const linkSuffixRegex = new Lazy<RegExp>(() => generateLinkSuffixRegex(false)); function generateLinkSuffixRegex(eolOnly: boolean) { </ins> let ri = 0; let ci = 0; function l(): string {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work!

It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged
Change:
# yarn lockfile v1 <del> typescript@3.4.1: version "3.4.1" resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.1.tgz#b6691be11a881ffa9a05765a205cb7383f3b63c6" integrity sha512-3NSMb2VzDQm8oBTLH6Nj55VVtUEpe/rgkIzMir0qVoLyjDZlnMBva0U6vDiV3IH+sl/Yu6oP5QwsAQtHPmDd2Q== </del> <ins> typescript@3.4.3: version "3.4.3" resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.3.tgz#0eb320e4ace9b10eadf5bc6103286b0f8b7c224f" integrity sha512-FFgHdPt4T/duxx6Ndf7hwgMZZjZpB+U0nMNGVCYPq0rEzWKjEDobm4J6yb3CS7naZ0yURFqdw9Gwc7UOh/P9oQ== </ins>

Discussion:
For This minor release of TypeScript will invalidate the automatic types cache so that upstream fixes to the styled components typings are downloaded
PR has been merged -closing.
Change:
-webkit-user-select: none; -ms-user-select: none; } <ins> /* Use user-select: text for lookup feature on macOS */ /* https://github.com/microsoft/vscode/issues/85632 */ .monaco-editor.mac .lines-content:hover, .monaco-editor.mac .view-line:hover, .monaco-editor.mac .view-lines:hover { user-select: text; -webkit-user-select: text; -ms-user-select: text; } </ins> .monaco-editor.enable-user-select { user-select: initial;

Discussion:
After research some existing issues, I found the closest description of this issue is , however there are some difference. Instead of "behaving strangely", this feature now are not working at all. Instead of macOS Sierra, this issue happened to me with MacOS Catalina. I downloaded the insider version just now and still not working. Mac OS version macOS Catalina 10.15 VS code version Version: 1.40.1 Electron: 6.1.2 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Darwin x64 19.0.0 Issue Look up feature still not working with both "Force click" and "3-fingers tab". Tried to reinstaill, still not working. ! Does this issue occur when all extensions are disabled?: Yes, even when it's brand new
Still does not work w/1.56.2, Big Sur 11.3.1, vanilla vscode install.
Hope to have this fix too
Hope this will be fixed too. It does not work in edit window, but works in preview window. VSCode info as following: Version: 1.61.0 Commit: Date: 2021-10-07T18:11:58.853Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0
Judging from , the "lookup popup" stopped showing up since version 1.21, so it may be a good starting point to look at the changes made between 1.20 and 1.21.
I found out is the root cause for this issue. I will make a PR for this.
Change:
// executed markers. This is done on command finished just in case command executed never // happens (for example PSReadLine tab completion) if (this._isWindowsPty) { <del> this._commandMarkers = this._commandMarkers.sort((a, b) => a.line - b.line); </del> <ins> if (this._commandMarkers.length === 0) { // If the command start timeout doesn't happen before command finished, just use the // current marker. if (!this._currentCommand.commandStartMarker) { this._currentCommand.commandStartMarker = this._terminal.registerMarker(0); } if (this._currentCommand.commandStartMarker) { this._commandMarkers.push(this._currentCommand.commandStartMarker); } } else { this._commandMarkers = this._commandMarkers.sort((a, b) => a.line - b.line); } </ins> this._currentCommand.commandStartMarker = this._commandMarkers[0]; this._currentCommand.commandExecutedMarker = this._commandMarkers[this._commandMarkers.length - 1]; }

Discussion:
Seeing this in today's build: ! Might be related to the fix
Weird that it looks like it reproduces inconsistently. I wonder if that always happens following one of the "empty commands"
The change I had in mind isn't working as I thought, this is too risky for Feb.
I haven't seen this happen for some time.
I have seen this actually
One problem case, notice B (command start) happens before the new line of the prompt: !
Other problem case: ! Notice that a cursor move event is happening on line 50 which is the line above the prompt: !
Change:
const langName = this._modeService.getLanguageName(document.getModeId()) || document.getModeId(); const silent = mode === FormattingMode.Silent; const message = !defaultFormatterId <del> ? nls.localize('config.needed', "There are multiple formatters for {0}-files. Select a default formatter to continue.", DefaultFormatter._maybeQuotes(langName)) </del> <ins> ? nls.localize('config.needed', "There are multiple formatters for '{0}' files. Select a default formatter to continue.", DefaultFormatter._maybeQuotes(langName)) </ins> : nls.localize('config.bad', "Extension '{0}' is configured as formatter but not available. Select a different default formatter to continue.", defaultFormatterId); return new Promise<T | undefined>((resolve, reject) => {

Discussion:
Steps to Reproduce: Format Document from command palette when there are multiple formatters placeholder for the box to choose which formatter to use says "Select a default formatter for Flow-files" (in my case, the language is set to "Flow") "Flow-files" is weird, I don't think there should be a hyphen: Also here, but I don't know how to repro this one:
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.537 --- <!-- score: 0.485 --- <!-- score: 0.47 --<!-- potentialduplicatescomment --
I will prepare a PR.
Change:
* values are updated in the same transaction (or during the initial read of the observable value). */ readonly repository = latestChangedValue(this, [this._firstRepository, this._graphRepository]); <del> readonly historyItemsFilter = observableValue<HistoryItemRefsFilter>(this, 'auto'); </del> <ins> readonly historyItemsFilter: ISettableObservable<HistoryItemRefsFilter>; </ins> private readonly _state = new Map<ISCMRepository, HistoryItemState>(); constructor( @IConfigurationService private readonly _configurationService: IConfigurationService, @ISCMService private readonly _scmService: ISCMService, <del> @ISCMViewService private readonly _scmViewService: ISCMViewService </del> <ins> @ISCMViewService private readonly _scmViewService: ISCMViewService, @IStorageService private readonly _storageService: IStorageService </ins> ) { super(); <ins> try { // Restore references filter from workspace storage const filterData = this._storageService.get('scm.graphView.referencesFiler', StorageScope.WORKSPACE) ?? 'auto'; const filter = filterData === 'auto' || filterData === 'all' ? filterData : JSON.parse(filterData) as ISCMHistoryItemRef[]; this.historyItemsFilter = observableValue<HistoryItemRefsFilter>(this, filter); } catch { // Default to `auto` in case the storage value is invalid this.historyItemsFilter = observableValue<HistoryItemRefsFilter>(this, 'auto'); } </ins> // Closed repository cleanup this._register(autorun(reader => { const repository = this._closedRepository.read(reader);

Discussion:
Type: <bBug</bspecific branches to display on the graph (in my case main, origin/main and upstream/main). VS Code, or close and reopen the workspace. has reverted to 'Auto' VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-11T05:04:03.124Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
even if you move away from the source control tab and come back it is changed back to auto.
I'm not seeing that happen on today's Insiders.
ohh, may be i am on different version than you. (i do not see a pending update though) Version: 1.94.0-insider Commit: Date: 2024-09-11T05:04:03.124Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
Change:
} } if (arrow && arrowLast) { <del> dom.append(div, $('span.arrow')).innerHTML = arrow; </del> <ins> dom.append(div, $('span.arrow', undefined, arrow)); </ins> } }); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . The Trusted Types violation here is setting an HTMLElement’s text content by assigning it to . Because in all of the cases the HTMLElement is already created with function, the idea is to pass the text as its argument. That is to replace: with .
Change:
text += this.repository.syncLabel; } <del> const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const rebaseWhenSync = config.get<string>('rebaseWhenSync'); command = rebaseWhenSync ? 'git.syncRebase' : 'git.sync'; </del> <ins> command = 'git.sync'; </ins> tooltip = this.repository.syncTooltip; } else { icon = '$(cloud-upload)';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 10 Steps to Reproduce: .rebaseWhenSync true .postCommitCommand sync git.rebaseWhenSync true works on actionbutton and statusbar but it does not affect git.postCommitCommand sync
Change:
import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { IPickOptions, IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput'; <del> import { ITerminalProfile, TerminalExitReason, TerminalLocation, TerminalSettingId } from 'vs/platform/terminal/common/terminal'; </del> <ins> import { ITerminalProfile, TerminalExitReason, TerminalIcon, TerminalLocation, TerminalSettingId } from 'vs/platform/terminal/common/terminal'; </ins> import { IWorkspaceContextService, IWorkspaceFolder } from 'vs/platform/workspace/common/workspace'; import { PICK_WORKSPACE_FOLDER_COMMAND_ID } from 'vs/workbench/browser/actions/workspaceCommands'; import { CLOSE_EDITOR_COMMAND_ID } from 'vs/workbench/browser/parts/editor/editorCommands';

Discussion:
Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:
/duplicate
Tracking each action separately
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.
you might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.

Repro: Open multiple terminals Select multiple terminal tabs Right click and change icon Change icon only a single terminal is changed Real context stored with the action was done recently as part of Related:
Change:
<ins> <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16"><g fill="#C5C5C5"><path d="M12.714 9.603c-.07.207-.15.407-.246.601l1.017 2.139c-.335.424-.718.807-1.142 1.143l-2.14-1.018c-.193.097-.394.176-.601.247l-.795 2.235c-.265.03-.534.05-.807.05-.272 0-.541-.02-.806-.05l-.795-2.235c-.207-.071-.408-.15-.602-.247l-2.14 1.017c-.424-.336-.807-.719-1.143-1.143l1.017-2.139c-.094-.193-.175-.393-.245-.6l-2.236-.796c-.03-.265-.05-.534-.05-.807s.02-.542.05-.807l2.236-.795c.07-.207.15-.407.246-.601l-1.016-2.139c.336-.423.719-.807 1.143-1.142l2.14 1.017c.193-.096.394-.176.602-.247l.793-2.236c.265-.03.534-.05.806-.05.273 0 .542.02.808.05l.795 2.236c.207.07.407.15.601.246l2.14-1.017c.424.335.807.719 1.142 1.142l-1.017 2.139c.096.194.176.394.246.601l2.236.795c.029.266.049.535.049.808s-.02.542-.05.807l-2.236.796zm-4.714-4.603c-1.657 0-3 1.343-3 3s1.343 3 3 3 3-1.343 3-3-1.343-3-3-3z"/><circle cx="8" cy="8" r="1.5"/></g></svg> </ins>  No newline at end of file

Discussion:
Needs one for some keybindings
Also should add a rename terminal button to each entry for easy discoverability