jiebi/CodeConvo huggingface dataset:
Change:
const cssProperties: CssProperties = { fontSize: `${fontSize}px`, fontFamily: `var(${fontFamilyVar}), ${EDITOR_FONT_DEFAULTS.fontFamily}`, <del> verticalAlign: 'middle', </del> <ins> verticalAlign: isUniform ? 'baseline' : 'middle', </ins> }; if (isNonEmptyArray(item.hint.textEdits)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: WindowsNT x64 10.0. Steps to Reproduce: Inlay Hints to use 100% of the editor's font size. any extension that provides inlay hints, open a file with inlay hints. a. (I tested this with a very basic TypeScript file, with the TypeScript extension's inlay hints enabled) that the hints are an entire 1px lower than they should be. (Aaa!! Terrifying!) ! Line 496 adds a rule to inlay hints: Disabling the resulting style in the inspector temporarily fixes the problem, aligning the baseline of the inlay hints with the baseline of the surrounding code. ! I've already made (and partially tested) , and I'm making this ticket in order to link it to my pull request. <!-- is this how you do things? --<!-- oops! hash changed because i changed the wording --
Change:
*--------------------------------------------------------------------------------------------*/ import { URI } from 'vs/base/common/uri'; <del> import { IFileSystemProviderWithFileReadWriteCapability, FileSystemProviderCapabilities, IFileChange, IWatchOptions, IStat, FileOverwriteOptions, FileType, FileDeleteOptions, FileWriteOptions, FileChangeType, FileSystemProviderErrorCode } from 'vs/platform/files/common/files'; </del> <ins> import { IFileSystemProviderWithFileReadWriteCapability, FileSystemProviderCapabilities, IFileChange, IWatchOptions, IStat, FileOverwriteOptions, FileType, FileDeleteOptions, FileWriteOptions, FileChangeType } from 'vs/platform/files/common/files'; </ins> import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; import { Event, Emitter } from 'vs/base/common/event'; import { VSBuffer } from 'vs/base/common/buffer';

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Add an method to the interface. The current options are: trying to stat the and seeing if it fails — we have no way to tell why it failed; reading a parent directory — we may not have read access to the parent directory; using node's — only works for the local filesystem.
I see s are spec'd to thow on when the file doesn't exist, but does not spec such errors.
We have no plans for adding and instead should be used (this goes along the deprecated to NodeJS's -deprecation). Still, I do agree that we should spec the error
Would be a passable solution?
Re-open for API proposal/finalization. Proposal is to add a field to the -class
should I rename the issue to better reflect the proposal?
Reactions during the API meeting were positive, so I am confident that we can finalize this during the current milestone. One feedback item was to always have a value for , e.g. let its default value be something like or
I did a quick search of the codebase, and it looks like is usually used for such cases in the various error code enums.
This is now in and will be stable API with the next relase. thanks for the help
Change:
private workbenchGrid!: SerializableGrid<ISerializableView>; <ins> private editorWidgetSet = new Set<IEditor>(); </ins> private disposed: boolean | undefined; private titleBarPartView!: ISerializableView;

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.41.1 (user setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: you have at least one file open in editor Zen Mode on a file in the Source Control tab under the CHANGES sub-heading to open the side-by-side diff Zen Mode on the tab for the file opened in step 1 & observe the area where line numbers should appear ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.648 --- <!-- score: 0.605 --- <!-- score: 0.58 --- <!-- score: 0.523 --- <!-- score: 0.522 --<!-- potentialduplicatescomment --
I acknowledge this issue. The problem is how we reset the line numbers after exiting zen mode Code pointer An elegant PR that fixes this is welcome. We might also look into this in the future.
I took a look at this and to fix this we need not just the but the non-visible ones too. I looked around and it seems there is no method for this in or There is an array in that holds the visible and non-visible editors, would it be fine to expose this variable ?
thanks for looking into this. That sounds reasonable. However let's check with if he wants to expose non visible editors in the or if he has a better suggestion for this. Alternative would be to remember all the editors that we have hidden line numbers for, and then when bringing them back to go through those editors.
gives access to all opened editors.
Ok thanks. so that + should probably give you all the .
gives an array of which doesn't have a method. Is there a way to get a from an ?
I believe the Editor control only exists for the visible editors (thus we create just one editor per Group). To save on resources.

So I believe the correct way to fix this is to remember all the editors that we have hidden line numbers for, and then when bringing them back to go through those editors. can correct me if I am wrong. Thansk
Yes, for performance reasons we only allocate 1 editor control per visible tab, not for each tab that is hidden.
I pushed 2 branches with different fixes for this issue This branch fixes it by using a to remember all the editor we have hidden line numbers as isidorn suggested. Not sure if it's safe to call on disposed editor widgets (this could happen if we have multiple editor groups and we close any of them) This branch fixes it by exposing the array in and updating the and interfaces let me know which approach is preferred to create the corresponding PR
let's go with approach 1. Once you create the PR i can further comment on it. Thanks a lot!
Thanks for fixing this
Change:
import { TerminalMenuBarGroup } from 'vs/workbench/contrib/terminal/browser/terminalMenus'; import { isString } from 'vs/base/common/types'; <del> const SHOW_TASKS_COMMANDS_CONTEXT = ContextKeyExpr.or(ShellExecutionSupportedContext, ProcessExecutionSupportedContext); </del> <ins> const SHOW_TASKS_COMMANDS_CONTEXT = ContextKeyExpr.and(ShellExecutionSupportedContext, ProcessExecutionSupportedContext); </ins> const workbenchRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench); workbenchRegistry.registerWorkbenchContribution(RunAutomaticTasks, LifecyclePhase.Eventually);

Discussion:
a folder try to run task Says task command not found !
What commit is that insiders based on? I believe I fixed this yesterday.
It says there is no updates for me but this is
Is that in oss? Hard to tell
No this is just todays insiders. I can test again on monday if you'd like
Thanks can you repro in oss?
Can repro when running the task command but not ctrl+shift+b. so this is a diff't bug
Reopen due to revert:
Change:
myState = myState.clone(); if (prependModeTransitions.length <= 0 || prependModeTransitions[prependModeTransitions.length-1].mode !== this._mode) { // Avoid transitioning to the same mode (this can happen in case of empty embedded modes) <del> prependModeTransitions.push({ startIndex: deltaOffset, mode: this._mode }); </del> <ins> prependModeTransitions.push(new ModeTransition(deltaOffset,this._mode)); </ins> } var maxPos = Math.min(stopAtOffset - deltaOffset, buffer.length);

Discussion:
VSCode Version: 1.4.0 OS Version: Windows 10 .51 Steps to Reproduce: the sample code from below, set HTML as Language Mode cursor at Line 8, Col 5 Tab message !
Looks like it occurs in emmet's editorAccessor, which calls , that apparently returns null. !
, created a PR for this issue. The issue can also be fixed by removing the optimization at which checks just the first element to be ModeTransition, but other elements are not. Let me know if this fix makes more sense than the PR I submitted, so that I can provide a PR for that as well.
Change:
this._commentsDecorations.set(commentsDecorations); } <ins> setLineNumber(lineNumber: number): void { this._lineNumber = lineNumber; this._updateDecorations(); } </ins> getPosition(): IContentWidgetPosition { const range = (this._commentsDecorations.length > 0 ? this._commentsDecorations.getRange(0) : null);

Discussion:
Comments in the editor have a different color based on their resolved status. We could do something similar for the icon in the gutter, and make obvious which comment is resolved even when comments are folded. Maybe change the icon color? Or use a different icon? (also related to )
Example of how it currently looks: ! Example with adjusted colours: ! Note that colour alone is not a full solution since it is not that accessible, but I think it should be included in the final solution.
A different icon/unicode character for resolved would be good here.
Let's get done first.
Change:
$completionPrefix = $commandLine # Get completions <del> $result = "`e]633;Completions" </del> <ins> $result = "$([char]0x1b)]633;Completions" </ins> if ($completionPrefix.Length -gt 0) { # Get and send completions $completions = TabExpansion2 -inputScript $completionPrefix -cursorColumn $cursorIndex

Discussion:
Testing Steps: Use Windows PowerShell (not PowerShell Core) Turn on the terminal intellisense Type stuff is to the terminal
Change:
} } <ins> private _toPascalCase(value: string): string { return value.match(/[a-z]+/gi) .map(function (word) { return word.charAt(0).toUpperCase() + word.substr(1).toLowerCase(); }) .join(''); } </ins> toTextmateString(): string { let value = '${'; value += this.index;

Discussion:
It would be nice to have additional snippet format options, e.g. kebabCase, camelCase, snakeCase, startCase, pascalCase. For example, for file named and snippet generated code would be .
Not sure yet as we would derive further from what is defined in TextMate
Why didn't you bring auto closing tag features in vs code for html
Code pointer:
FYI, I ended up using plugin.
I'm on it.
But ... but ... the issue had several formats: and PR only 1 (PascalCase)
Change:
'force-color-profile', // disable LCD font rendering, a Chromium flag <del> 'disable-lcd-text' </del> <ins> 'disable-lcd-text', // bypass any specified proxy for the given semi-colon-separated list of hosts 'proxy-bypass-list' </ins> ]; if (process.platform === 'linux') {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Add support for --proxy-bypass-list in the file so that we can provide a default proxy bypass list to VS Code users. Setting NO_PROXY doesn't work as a solution because it would either have to be set as a user / system environment variable thus impacting all applications, or we would have to rely on our VS Code users to explicitly pass --proxy-bypass-list as an argument to code on the command line each time they launch. Having the option to set this in would provide us with a way to package this in our default enterprise installation of VS Code so users would get this setting by default, but just for VS Code.
Could we just in . I was not aware that only a subset of our command line arguments can be configured there actually. fyi
Yes we can expose it Yeah the list of chromium commandline flags in quit large and always changes with version updates it would be a nightmare if we are to support all of them in . At this time we only support those on a case by case basis.
Thanks, makes sense! Should I assign this one to you? If you are busy, I am happy to provide a PR in July if you give me a code pointer?
Here is an example of recent flag addition , feel free to send a PR. I can review it. Thanks!
Thanks for that great example. Here's the PR I verified that adding "proxy-bypass-list" does not produce errors in I did not verify if this list actually gets passed to Chrome. We can ask if we get this out to an insiders build.
FYI: There is a PR in progress for adding a setting for the feature:
Thanks. But unlike that PR, I think this flag just needs to be passed to Chromium and it should get handled. i.e. I did not add any code in VS Code that actually handles the flag.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!
This flag doesn't seem to work for me unfortunately. Using mitmproxy I still see the bypassed domains: !
Can confirm, preparing a fix now.
thanks for the quick fix
verification steps: Setup mitmproxy Start the application with proxy server Check the logs to see requests from the application are intercepted, you should see some domains like or Open and set Restart the application with same proxy server Confirm that requests to these hosts are not seen in the intercepted logs anymore
Change:
private _telemetryEnablements: { isUsageEnabled: boolean; isErrorsEnabled: boolean }; private _apiObject: vscode.TelemetryLogger | undefined; <ins> private _sender: vscode.TelemetrySender | undefined; </ins> constructor( sender: vscode.TelemetrySender,

Discussion:
Testing Given this code: I was expecting my event handlers not to fire since the logger is disposed, but they still fire.
This still repros for me <img width="1210" alt="image" src="https://user-"
Change:
export const checkboxBorder = registerColor('checkbox.border', { dark: selectBorder, light: selectBorder, hcDark: selectBorder, hcLight: selectBorder }, nls.localize('checkbox.border', "Border color of checkbox widget.")); export const buttonForeground = registerColor('button.foreground', { dark: Color.white, light: Color.white, hcDark: Color.white, hcLight: Color.white }, nls.localize('buttonForeground', "Button foreground color.")); <del> export const buttonSeparator = registerColor('button.separator', { dark: transparent(buttonForeground, .4), light: transparent(buttonForeground, .4), hcDark: null, hcLight: transparent(buttonForeground, .4) }, nls.localize('buttonSeparator', "Button separator color.")); </del> <ins> export const buttonSeparator = registerColor('button.separator', { dark: transparent(buttonForeground, .4), light: transparent(buttonForeground, .4), hcDark: transparent(buttonForeground, .4), hcLight: transparent(buttonForeground, .4) }, nls.localize('buttonSeparator', "Button separator color.")); </ins> export const buttonBackground = registerColor('button.background', { dark: '#0E639C', light: '#007ACC', hcDark: null, hcLight: '#0F4A85' }, nls.localize('buttonBackground', "Button background color.")); export const buttonHoverBackground = registerColor('button.hoverBackground', { dark: lighten(buttonBackground, 0.2), light: darken(buttonBackground, 0.2), hcDark: null, hcLight: null }, nls.localize('buttonHoverBackground', "Button background color when hovering.")); export const buttonBorder = registerColor('button.border', { dark: contrastBorder, light: contrastBorder, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('buttonBorder', "Button border color."));

Discussion:
You can see in the image that the split part doesn't look right. FYI my theme is ! /cc
//cc
I think this might be another style issue with the button border since the separator container use the full height: <img width="430" alt="CleanShot 2022-07-20 at 10 56 10 src="https://user-"If you don't set a border it looks normal: <img width="237" alt="CleanShot 2022-07-20 at 10 54 13 src="https://user-"
thanks for tracking this down. I will try to squeeze a fix in this week.
Change:
"storage" ], "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

Discussion:
Environment Details: VSCode Version : 1.25.0 OS Version : Win10 Additional Details: HighContrast,MAS1.4.3 Repro Steps: Visual Studio code desktop application. to "Plain Text" of "Status Bar"-Enter "PowerShell" in "Select Language Mode" combo box-Write the PowerShell Code in plain editor-Save the editor. to Setting button of Activity Bar and select "Color Theme" option. Themes shows number of different colors list apply all that theme on the editor. color contrast analyser and check the color contrast ratio. shows color contrast ratio less than expected color contrast ratio. Actual: After applying color themes to editor it shows color contrast ratio as 3.5:1 eg. Select "QuietLight" theme from color theme list and check for the color contrast ratio. Expected: The expected colorcontrast ratio should be greater than or equals to 7:1 ratio. Recommendations: Refer below link which is repository of bug fixes code  User Impact: User will not able to see the content of the editor. MAS Reference: MAS1.4.3- Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.701 --- <!-- score: 0.617 --- <!-- score: 0.552 --- <!-- score: 0.508 --<!-- potentialduplicatescomment --
I believe you are using the wrong color contrast ratio. From the link you provided: We've only been targeting the minimum contrast ratio, which is Level AA at 4.5:1
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.17", </del> <ins> "xterm": "5.2.0-beta.19", </ins> "xterm-addon-canvas": "0.4.0-beta.7", "xterm-addon-search": "0.11.0", "xterm-addon-unicode11": "0.5.0",

Discussion:
Terminal a11y buffer is not read-only. Since this is contenteditable textbox, unintended delete key can mess up the output content. I confirmed that delete key works inside the buffer. It would be even nicer if this buffer could be marked up with readonly to prevent users from accidentally deleting their output content.
did you notice that when you toggle the mode it comes back as the original? so while it seems like editing of the buffer is possible, it's not actually making any changes.
-- You are correct. If you press tab and come back to the buffer via Shift+Tab, it comes back to the original content. However, the content is editable when it gets focused.
Not sure if it's possible to change this, but will investigate
Looks like this is easy to do - just disabling and setting
-- To give you prompt testing results, I have just built the latest main branch on my end (this issue will also be found tomorrow once insider is released). I have found the following inadvertent regression (tested with NVDA and JAWS on Windows): a11y buffer is not readable via standard arrow keys. input -terminal a11y buffer: only requires one Shift+Tab. However, from terminal a11y back to terminal input requires two tab key press. Note that aria-live is now working!
I have already caught that regression, you can build based on this PR to see that I've fixed it
i'll investigate: when I investigate
As of today's insider build (Commit: ), it appears that the accessibility buffer can still be modified accidentally. Additionally, if the buffer has been altered, tabbing to the shell and then shift-tabbing back does not restore the buffer to its previous state, as it did in previous versions. Furthermore, if the buffer has been modified, subsequent command output will not be reflected in the buffer.
see for why we didn't go with readonly. the actual buffer is never modified - the text area element is. focusing the terminal buffer via mouse click for example and shift+tabbing again will restore the contents to what they were before.
Is there a way to reset the state of the buffer without using the mouse? As of the version on the main branch, I am unable to reset the buffer by tabbing and shift-tabbing back to it.

Just hitting tab works for me
Can you get the buffer to reset after tabbing into it after modifying the buffer? I cannot get the buffer to reset with the NVDA on Windows 11; not sure weather there is something wrong on my ends.
-- I can reproduce your issue. Please file a separate issue and provide minimal reproducible steps so that can fully replicate this issue.
I have created the issue at .
Change:
}); })); <ins> this._register(this.editor.getOriginalEditor().onDidScrollChange(e => { if (this._isSettingScrollTop) { return; } if (!e.scrollTopChanged || !this._data) { return; } const delta = e.scrollTop - this._lastScrollTop; this._data.deltaScrollVertical(delta); })); </ins> this._register(autorun(reader => { const isFocused = this.isFocused.read(reader); this._elements.root.classList.toggle('focused', isFocused);

Discussion:
Multi diff editor issue while expanding the hidden lines VS Code Version: 1.86 insider OS Version: Windows 11 //cc Steps to Reproduce: the multi diff editor on the hidden lines at the bottom ( the blue line) now it will expand the 10 lines now scrolling top doesn't show me the '5 hidden lines' text until I scroll down and then scroll up again
Change:
if (!this.gallery || !this.local) { return false; } <del> if (this.type !== ExtensionType.User) { return false; } </del> if (!this.local.preRelease && this.gallery.properties.isPreReleaseVersion) { return false; }

Discussion:
Ability to update built in extensions
This is a pre-request to enable built-in extension to on-board to
Disabled updating builtin extensions in stable
Change:
import { IEditorGroup } from 'vs/workbench/services/editor/common/editorGroupsService'; import type { IManagedHover } from 'vs/base/browser/ui/hover/hover'; import { IHoverService } from 'vs/platform/hover/browser/hover'; <ins> import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; </ins> const $ = DOM.$;

Discussion:
A11yWCAG2.1; #A11yTCS; #A11ySev4; #Visual Studio Code Client; #BMVisual Studio Code ClientMAC_JULY2024; #DesktopApp; #WCAG4.1.3; #FTP; #A11yMAS; #Status Message; #MAC; #Device; #Voiceover; #A11yUsable; MAC Book Pro MAC OS Sonoma Version 14.5 Visual Studio code Insider version 1.92.0 Visual Studio Code Insiders editor Navigate to setting icon. "Keyboard shortcuts options" and press enter or Press keyboard shortcut as command K, Command S shortcut table gets opened. till "Keyboard Shortcut Edit field". any Text or Key and Observe that Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Voiceover should be announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Screen reader users will face difficulty if Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".
do you know if we have ever had support for this?
Rev:poojanamde;
Decreasing to Sev4 according to Review of Indu Priya Setty. Thanks!!