jiebi/CodeConvo huggingface dataset:
Change:
beforeCloseEditor(editor: EditorInput): void { } <del> closeEditor(editor: EditorInput): void { } </del> <ins> closeEditor(editor: EditorInput): void { this.handleClosedEditors(); } closeEditors(editors: EditorInput[]): void { this.handleClosedEditors(); } </ins> <del> closeEditors(editors: EditorInput[]): void { } </del> <ins> private handleClosedEditors(): void { this.activeEditor = this.tabsModel.activeEditor; } </ins> moveEditor(editor: EditorInput, fromIndex: number, targetIndex: number): void { }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.93.0 OS Version: Steps to Reproduce: to ALL editors. LAST closed editor, no breadcrumbs shown. !
Change:
"displayName": "CSS Language Features", "description": "Provides rich language support for CSS, LESS and SCSS files.", "css.title": "CSS", <ins> "css.completion.triggerPropertyValueCompletion.desc": "By default, VS Code triggers property value completion after selecting a CSS property. Use this setting to disable this behavior.", </ins> "css.lint.argumentsInColorFunction.desc": "Invalid number of parameters.", "css.lint.boxModel.desc": "Do not use `width` or `height` when using `padding` or `border`.", "css.lint.compatibleVendorPrefixes.desc": "When using a vendor-specific prefix make sure to also include all other vendor-specific properties.",

Discussion:
I can't find how to disable CSS property value autocomplete, I'm using these settings: it works perfectly in JavaScript, TypeScript, etc. But in CSS if I press tab I will get full autocomplete of property and then value. How I can disable autocomplete of value and keep only autocomplete of property? Gif below shows the issue. ! As you can see it autocompleted almost perfectly except it automatically opened suggestion for value which I don't need since I want to go through all based suggestions with and I even in settings which CSS should respect. In my opinion, if is it should autocomplete only with and then you can go through properties by pressing and then you add which results to you can write a single letter and go through suggestions again with . So to summarize it should autocomplete with only and do not show suggestion list of values for that prop.
How does that work? Can't you use arrow keys to select prev/next item?
No, only or . I proposed this suggestion , if any member of your team agrees on that proposal, then this can be closed, because I really miss suggestions list, but it's too noisy and distracting. Since there are a really small group of devs who disable suggestions and uses only tab to autocomplete, also in CSS, chances this will be re-created by someone else is very very small.
The problem is: He want to use tab/S-tab to go prev/next Some CSS completion items and trap the tab/S-tab Do you think we should add the setting?
Maybe I can help somehow to make this happen?
Sure, a PR that adds a new setting is welcome.
So this is related to ?
Sure, thanks! Here are some pointers: Dev setup is here: Add a boolean setting to toggle this behavior on/off Here's the logic for re-triggering value completion after property completion: Update the test suite
Thank you!
Change:
migratedArgvValue = 'gnome-libsecret'; } app.commandLine.appendSwitch(argvKey, migratedArgvValue); <ins> } else { app.commandLine.appendSwitch(argvKey, argvValue); </ins> } } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Add support for --proxy-bypass-list in the file so that we can provide a default proxy bypass list to VS Code users. Setting NO_PROXY doesn't work as a solution because it would either have to be set as a user / system environment variable thus impacting all applications, or we would have to rely on our VS Code users to explicitly pass --proxy-bypass-list as an argument to code on the command line each time they launch. Having the option to set this in would provide us with a way to package this in our default enterprise installation of VS Code so users would get this setting by default, but just for VS Code.
Could we just in . I was not aware that only a subset of our command line arguments can be configured there actually. fyi
Yes we can expose it Yeah the list of chromium commandline flags in quit large and always changes with version updates it would be a nightmare if we are to support all of them in . At this time we only support those on a case by case basis.
Thanks, makes sense! Should I assign this one to you? If you are busy, I am happy to provide a PR in July if you give me a code pointer?
Here is an example of recent flag addition , feel free to send a PR. I can review it. Thanks!
Thanks for that great example. Here's the PR I verified that adding "proxy-bypass-list" does not produce errors in I did not verify if this list actually gets passed to Chrome. We can ask if we get this out to an insiders build.
FYI: There is a PR in progress for adding a setting for the feature:
Thanks. But unlike that PR, I think this flag just needs to be passed to Chromium and it should get handled. i.e. I did not add any code in VS Code that actually handles the flag.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!
This flag doesn't seem to work for me unfortunately. Using mitmproxy I still see the bypassed domains: !
Can confirm, preparing a fix now.
thanks for the quick fix
verification steps: Setup mitmproxy Start the application with proxy server Check the logs to see requests from the application are intercepted, you should see some domains like or Open and set Restart the application with same proxy server Confirm that requests to these hosts are not seen in the intercepted logs anymore
Change:
} ], "colors": { <del> "focusBorder": "#A6B39B", </del> <ins> "focusBorder": "#9769dc", </ins> "pickerGroup.foreground": "#A6B39B", "pickerGroup.border": "#749351", "list.activeSelectionForeground": "#6c6c6c",

Discussion:
+F to open the editor find widget. Focus should be on the find input box. case-sensitive search. to the case-sensitive search button. :bug: Keyboard focus is on that element, but it's not clear that keyboard focus is on that element. !
works fine on my machine with Light+ and Dark+ theme, what theme are you using? ! !
Thanks! I guess the problem depends on the theme. The problem seems to occur on at least Quiet Light, Solarized Light, and Monokai.
Can confirm the the issue in those themes on my windows machine. I never sent a pull request to vscode but that seems easy to solve, the question is what highlight color would fit best each theme, i might take a look later unless there are some rules about how to set some of the theme colors... the colors effecting this seem to be "focusBorder" and "inputOption.activeBorder" I would love to offer some new colors later today/tomorrow and pull request them
I propose giving a bit of contrast to the "focusBorder" I think that focus border should have a bit of contrast from background as this is marking elements the user needs to spot quickly, even in themes with less contrast light quiet light i think this is best to increase contrast in those areas, this is only showing for elements put in focus and wont change the feeling of the theme by much. Here are the new colors i propose and will commit and pull request later if those look acceptable For Quiet Light: ! For Solarized Light: ! For Monokai: !
Change:
} .issues-container > .issue > .issue-state { <ins> display: flex; </ins> width: 77px; padding: 3px 6px; margin-right: 5px;

Discussion:
!
is this in OSS or in insiders?
This was oss
yep, this is a known issue in OSS with the css bundling. it ends up fine in Insiders and stable, but unsure why this has been the case for a while now. same as i believe
They still happen in insiders, just the button width isn't the same for some reason (you could inspect the element in devtools to diff the styles): !
Change:
description: localize('symbolSortOrder', "Controls how symbols are sorted in the breadcrumbs outline view."), type: 'string', default: 'position', <ins> overridable: true, </ins> enum: ['position', 'name', 'type'], enumDescriptions: [ localize('symbolSortOrder.position', "Show symbol outline in file position order."),

Discussion:
The setting "breadcrumbs.symbolSortOrder" cannot be enabled for a specific language, i.e. "[markdown]": { "breadcrumbs.symbolSortOrder": "position" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Actually not a duplicate but should be straight forward to implement as filter-options can already be defined per language
Could you point me towards how to get the current resource from the editor model inside ?
The  has a reference to the text model
to verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position
Change:
return result; } <ins> public getChildren(): Item[] { var child = this.firstChild; var results = []; while (child) { results.push(child); child = child.next; } return results; } </ins> private isAncestorOf(item: Item): boolean { while (item) { if (item.id === this.id) {

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
this.queryDetails = dom.append(this.searchWidgetsContainerElement, $('.query-details')); // Toggle query details button <ins> const toggleQueryDetailsLabel = nls.localize('moreSearch', "Toggle Search Details"); </ins> this.toggleQueryDetailsButton = dom.append(this.queryDetails, <del> $('.more' + ThemeIcon.asCSSSelector(searchDetailsIcon), { tabindex: 0, role: 'button' })); this._register(this.hoverService.setupManagedHover(getDefaultHoverDelegate('element'), this.toggleQueryDetailsButton, nls.localize('moreSearch', "Toggle Search Details"))); </del> <ins> $('.more' + ThemeIcon.asCSSSelector(searchDetailsIcon), { tabindex: 0, role: 'button', 'aria-label': toggleQueryDetailsLabel })); this._register(this.hoverService.setupManagedHover(getDefaultHoverDelegate('element'), this.toggleQueryDetailsButton, toggleQueryDetailsLabel)); </ins> this._register(dom.addDisposableListener(this.toggleQueryDetailsButton, dom.EventType.CLICK, e => { dom.EventHelper.stop(e);

Discussion:
Steps to reproduce: any document, press controll+shift+f to open the find all functionality. tab (4 times) until you hear "button" or "button expanded". Issues: does not announce that the button is an expandable one, and that it is in the collapsed state. This appears to be a regression in the insiders build when compared with the latest stable release, where the button is announced as collapsed or expanded. does not have any label for the button. It is just announced as "button".
are you aware of any regressions that could have caused this in the tree view? I don't think that I changed anything in search for this to happen..
I'm not aware of any changes to this. Furthermore, in testing with VoiceOver, this is working as expected. Does this repro with NVDA on Windows? If not, it's possible something changed with JAWS.
This doesn't repro with NVDA, trying JAWS next
doesn't repro for me using JAWS either, has any setting changed for you?
The expand/collapsed state is indicated to me for all screen readers. I can repro the button not having an aria label, which we should fix.
Change:
assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar-newabc'), 'Newfoo-Newbar-Newabc'); actual = ['Foo-Bar-abc']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar'), 'Newfoo-newbar'); <ins> actual = ['foo-Bar']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar'), 'newfoo-Newbar'); actual = ['foo-BAR']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar'), 'newfoo-NEWBAR'); </ins> actual = ['Foo_Bar']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo_newbar'), 'Newfoo_Newbar');

Discussion:
, Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this Example: Replacingto with preserve case turned on replaces correctly to Replacing to with preserve case turned on replaces incorrectly to instead of PS : Additional Info from the code I found out there is a bug in function. The whole idea to call the replacement function again at was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.
Thanks for the PR, can you please phrase this issue in the form of a bug report (ie describe what to do, what happens, what is supposed to happen)
Change:
nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.')); export const listFocusHighlightForeground = registerColor('list.focusHighlightForeground', <del> { dark: listHighlightForeground, light: ifDefinedThenElse(listActiveSelectionBackground, listHighlightForeground, '#BBE7FF'), hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </del> <ins> { dark: listHighlightForeground, light: listHighlightForeground, hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </ins> nls.localize('listFocusHighlightForeground', 'List/Tree foreground color of the match highlights on actively focused items when searching inside the list/tree.')); export const listInvalidItemForeground = registerColor('list.invalidItemForeground',

Discussion:
using Default Light + theme run peek references <img width="978" alt="Screenshot 2024-03-26 at 17 30 37" src=""
Change:
} }); <del> res.stderr?.on('data', (data: Buffer) => { </del> <ins> res.stderr?.once('data', (data: Buffer) => { </ins> this.logService.error(`Error openening external URL '${url}' using browser '${configuredBrowser}': ${data.toString()}`); <ins> return shell.openExternal(url); </ins> }); } catch (error) { this.logService.error(`Unable to open external URL '${url}' using browser '${configuredBrowser}' due to ${error}.`);

Discussion:
Testing Not sure if this is possible, but I set the to even though I don't have Firefox... then I tried to open something and nothing happened. I was confused because I thought I had Firefox installed, but I guess I remembered incorrectly! I think something like this is increasingly important in the workspace-setting level. Sure, the protection of this is behind Workspace Trust... but I don't seem to get any notification or indication that there's a setting applied that influences how VS Code opens the browser or if it's going to no-op. Considering this setting influences things like user auth flows, I think we should try to do something here. I was surprised that no browser was opened when I attempted to log in to a GitHub extension... which makes sense if this setting is set to something invalid.
I think this might be reported as and misses a fix or workaround. If someone has an idea, either by contributing to or seeing what we can do here:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
It appears that this is fixed by opening the default instead of what is configured. That makes sense to me.
Change:
// this method is called when vs code is activated export function activate(context: ExtensionContext) { <del> const serverMain = context.asAbsolutePath('server/dist/browser/htmlServerMain.js'); </del> <ins> const serverMain = Uri.joinPath(context.extensionUri, 'server/dist/browser/htmlServerMain.js'); </ins> try { <del> const worker = new Worker(serverMain); </del> <ins> const worker = new Worker(serverMain.toString()); </ins> const newLanguageClient: LanguageClientConstructor = (id: string, name: string, clientOptions: LanguageClientOptions) => { return new LanguageClient(id, name, clientOptions, worker); };

Discussion:
The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API
fyi
tried to adopt this. When will be available. I can't find it in .
Opened for ESLint
It's in the API since 4 months:
Change:
return notebook.cellAt(notebook.cellCount - 1); } <del> async function addCellAndRun(code: string, notebook: vscode.NotebookDocument) { </del> <ins> async function addCellAndRun(code: string, notebook: vscode.NotebookDocument, i: number) { </ins> const cell = await addCell(code, notebook); <del> await vscode.commands.executeCommand('notebook.execute'); </del> <ins> await vscode.commands.executeCommand('notebook.cell.execute', { start: i, end: i + 1 }); </ins> assert.strictEqual(cell.outputs.length, 1, 'execute failed'); return cell; }

Discussion:
I think we should understand why execution time seems to get slower and slower the more cells there are. Check out this video, it looks as if things get slower and slower: ! Originally posted by in
This test is running the "Run All" command, not the "run one cell" command...
Change:
if (typeof result === 'boolean') { node.filterData = undefined; <del> return TreeVisibility.Visible; </del> <ins> return result ? TreeVisibility.Visible : TreeVisibility.Hidden; </ins> } else if (isFilterResult<TFilterData>(result)) { node.filterData = result.data; return getVisibleState(result.visibility);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.29.2 OS Version: linux Steps to Reproduce: some .cpp files with errors or as suggested in hover from these files are still there My use case: I use gitlens extension. It downloads older versions of files to /tmp/ and of course they produce a lot of errors and warnings. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No
Are you saying errors/warnings are in older versions of files that gitlens is downloading? Or the errors/warnings are occuring in the file that you edited with ?
Also, can you provide an example small cpp file that will have these errors?
Sorry, let me clarify. vscode has warnings and errors pane, it groups all errors from the project. And there is an input bar that lets you exclude some files. Here I want to exclude all ts files, but it doesn't work: !
This seems to be a regression from new tree adoption. It's because tree is marking the parent node as visible always.
Change:
} } <del> return runCell(accessor, context); </del> <ins> return runCell(editorGroupsService, context); </ins> } } });

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem
Change:
Registry.as<IViewsRegistry>(ViewExtensions.ViewsRegistry).registerViews([{ id: REPL_VIEW_ID, name: nls.localize({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, 'Debug Console'), <del> containerIcon: 'codicon-debug-console', </del> <ins> containerIcon: Codicon.debugConsole.classNames, </ins> canToggleVisibility: false, canMoveView: true, ctorDescriptor: new SyncDescriptor(Repl),

Discussion:
Today I see no debug icon in the activity bar.
Yeah, I also can't see !
Removed in Looks like not longer in font and has different character code but it's actually in font
Sorry about that, I must've copied the wrong unicode character when I was cleaning up the unused debug icons. Looking into PR right now.