jiebi/CodeConvo huggingface dataset:
Change:
detail: vscode.l10n.t( "The workspace is using an old version of TypeScript ({0}).nnBefore reporting an issue, please update the workspace to use the latest stable TypeScript release to make sure the bug has not already been fixed.", (previousState.type === ServerState.Type.Errored && previousState.error instanceof TypeScriptServerError ? previousState.error.version.apiVersion?.displayName : undefined) + ''), <del> useCustom: true </del> }); } else { const args = previousState.type === ServerState.Type.Errored && previousState.error instanceof TypeScriptServerError

Discussion:
I don't think this should be lumped into the resolvers proposal. The JS/TS extension currently depends on resolvers just for this one property
Unsure, we really don't want anyone to use this and it only exists for complex reconnection explainers. Once such cases are more properly modelled it should go away again
What is JS/TS using this for? The normal modals should really be enough
looked this which doesn't seem to justify the use of a custom modal. So, I'd suggest to let TS use a normal modal dialog instead
Change:
* text eol=lf <ins> *.exe binary *.dll binary </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.49.2 OS Version: Win10 host using WSL2 docker dev container Steps to Reproduce: the Code - OSS Development Container docker setup instructions, first thing to happen on fresh container checkout <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Change:
this._register(this.fileService.onDidFilesChange(e => this.onDidFilesChange(e))); } <del> private async onDidChangeProfiles(added: readonly IUserDataProfile[], removed: readonly IUserDataProfile[]): Promise<void> { </del> <ins> private async onDidChangeProfiles(added: readonly IUserDataProfile[]): Promise<void> { </ins> try { <del> await Promise.all(removed.map(profile => { this.extensionsProfileWatchDisposables.deleteAndDispose(profile.id); return this.removeExtensionsFromProfile(profile.extensionsResource); })); </del> if (added.length) { await Promise.all(added.map(profile => { this.extensionsProfileWatchDisposables.set(profile.id, combinedDisposable(

Discussion:
I had a "Testing" profile with various remote extensions installed. I deleted it (while being in it) and then recreated it empty. I still found all remote menu contributions even though the profile should have been empty. Maybe switching profiles should ask to reload the window when extensions require so? Steps to Reproduce: fresh user data dir, fresh extensions dir create an empty profile install SSH extension notice how the remote explorer view appears delete the profile notice how the remote explorer view is still there, same as the status bar entry for remote
Another case from is interesting: I do not think using a profile is a good idea for when extensions require a window reload to be disabled. So you need to then probably ask the user to reload the window or do it automatically.
AFAIK every extension requires a window reload after being disabled (except for package-json only extensions). We cannot unload code from extensions and cannot enforce them not doing anything anymore. There we always reload the window or at least the extension host
While switching profiles we restart extension host. You say this is not enough to unload extensions? Also while trusting/untrusting a workspace.
No, only those that are activate with code loaded. Here are steps: fresh user data dir, fresh extensions dir create an empty profile install SSH extension notice how the remote explorer view appears delete the profile notice how the remote explorer view is still there, same as the status bar entry for remote
I see this can be reproduced with above steps. But Remote Explorer view disappears with switching profile. So I think this is a bug (either in views or profiles) when profile is deleted. But status bar entries always appear.
Change:
this.complexValueContainer.hidden = false; return this.tree.setInput(expression).then(() => { <del> this.complexValueTitle.textContent = expression.value; </del> <ins> this.complexValueTitle.textContent = replaceWhitespace(expression.value); </ins> this.complexValueTitle.title = expression.value; this.layoutTreeAndContainer(); this.editor.layoutContentWidget(this);

Discussion:
Issue Type: <bBug</bHi. I am assigning trade.occId = occId; i.e. to a property (in this case it contains 4 spaces. In the JavaScript hover view however, the property on 'trade' reads (only one space) [btw, I copied both these values right out of the IDE view]. I've just been chasing ghosts for some time because of this discrepancy and not expecting the IDE altering assigned values when viewing objects. Update ---Alright, sorry. I am not sure how to submit the first value on GitHub with the 4 spaces between GS and 1 preserved, even when using 'code' quotes (same as the VSC issue...). So the first value is "GD....190517P00155000" when replacing spaces with dots... Thanks for VS Code otherwise :-) VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ vscode-scss0.6.2 debugger-for-chrome4.11.3 vscode-scss-formatter1.4.1 vscodeintellicode1.1.5 </details<!-- generated by issue reporter --
Can you please provide a screenshot of what you see? Also try disabling all extensions. I am not sure if such an hover is provided by out of the box typescript/javascript extension.
Hi. Please see below. I disabled all extensions besides Debugger for Chrome, which I need to set a break-point to be able to inspect values. The issue is in most obvious in the field 'occId', which in fact has 4 spaces after 'GD' and not just one as displayed. Thanks for following up. [image: ] !
Ah I see.. its an hover while debugging.
You did not attach an image. So please attach an image and some reproducable steps so we can investigate more. Thanks
It did, (please check below the quote). Anyway, your question made me come up with a better/simpler example that should make things clear. Here you go: ! Btw, Gruetzi to all you guys in Zuerich.

I'm originally from Basel :)
Thanks for the image. Cheers back to Basel :)
VSCode insiders will have the fix for this on monday. Try it out and let us know if it is ok for you. Though I verified and the fix from looks good
Thanks for the work and update. Unfortunately I can't switch from VSCode stable, so I'll take your word for it until this hits release :-)
Change:
{ "name": "code-oss-dev", "version": "1.39.0", <del> "distro": "31c935c255c1aa77e9be7eb491bb232c05fd61f3", </del> <ins> "distro": "0384a381913bc4775eb0c45632f2e0d66f8b7f1d", </ins> "author": { "name": "Microsoft Corporation" },

Discussion:
For details pls see I've updated the of insider/stable to define the extension as a UI extension Candidate since the bracket pair colorizer is a popular extension and we should also enable users that use the V2 version.
I also previously pinged the extension about fixing this:
Change:
"foreground": "#cccccc", "icon.foreground": "#cccccc", "input.background": "#ffffff0f", <del> "input.border": "#ffffff17", </del> <ins> "input.border": "#ffffff1f", </ins> "input.foreground": "#cccccc", "input.placeholderForeground": "#ffffff79", "inputOption.activeBackground": "#2489db82",

Discussion:
Ref Unchecked and unfocused checkboxes in the Settings editor currently do not have much contrast between the checkbox background colour and the checkbox border colour for both Light+ v2 and Dark+ v2 themes. !
Change:
} }; } <ins> export function gitTwoDashes(): ITerminalQuickFixOptions { return { commandLineMatcher: GitCommandLineRegex, outputMatcher: { lineMatcher: GitTwoDashesRegex, anchor: 'bottom', offset: 0, length: 2 }, exitStatus: false, getQuickFixes: (matchResult: QuickFixMatchResult, command: ITerminalCommand) => { const actions: ITerminalQuickFixAction[] = []; const problemArg = matchResult?.outputMatch?.[1]; if (!problemArg) { return; } const commandToRunInTerminal = command.command.replace(` -${problemArg}`, ` --${problemArg}`); const label = localize("terminal.runCommand", "Run: {0}", commandToRunInTerminal); actions.push({ class: undefined, tooltip: label, id: 'terminal.gitTwoDashes', label, enabled: true, commandToRunInTerminal, addNewLine: true, run: () => { } }); return actions; } }; } </ins> export function freePort(terminalInstance?: Partial<ITerminalInstance>): ITerminalQuickFixOptions { return { commandLineMatcher: AnyCommandLineRegex,

Discussion:
With we're getting some initial terminal quick fixes. We have a bunch more ideas, let's use this issue to track adding more at a later date when we have more information on how the feature is received.
Also want to consider the setting to disable one or more of these
The open URL one (the only one I’ve seen so far) was a really pleasant surprise and I immediately adopted it into my workflow for opening a GitHub PR after pushing a new branch. Another one I would love to see is opening files with merge conflicts: <img width="615" alt="image" src="https://user-"
great idea!
I think this can be closed since we have individual issues tracking ideas
Change:
return copyVscodeDevLink(gitAPI, false); })); <ins> disposables.add(vscode.commands.registerCommand('github.openOnVscodeDev', async () => { return openVscodeDevLink(gitAPI); })); </ins> return disposables; }

Discussion:
Testing Clone a git repository Open git repository in VS Code desktop Make a change to one or more files Invoke the command You are presented with an empty picker <img width="736" alt="image" src="https://user-"
Change:
'codeMovedToWithChanges', 'Code moved with changes to line {0}-{1}', this._move.lineRangeMapping.modified.startLineNumber, <del> this._move.lineRangeMapping.modified.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.modified.endLineNumberExclusive - 1, </ins> ) : localize( 'codeMovedFromWithChanges', 'Code moved with changes from line {0}-{1}', this._move.lineRangeMapping.original.startLineNumber, <del> this._move.lineRangeMapping.original.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.original.endLineNumberExclusive - 1, </ins> ); } else { text = this._kind === 'original' ? localize( 'codeMovedTo', 'Code moved to line {0}-{1}', this._move.lineRangeMapping.modified.startLineNumber, <del> this._move.lineRangeMapping.modified.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.modified.endLineNumberExclusive - 1, </ins> ) : localize( 'codeMovedFrom', 'Code moved from line {0}-{1}', this._move.lineRangeMapping.original.startLineNumber, <del> this._move.lineRangeMapping.original.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.original.endLineNumberExclusive - 1, </ins> ); }

Discussion:
not sure if it a bug report or question, but I notcied that moved lines range is not correct: ! why it is written that lines are moved from 16-21? Shouldn't they be marked as "moved from 16-20"? The same question is about "moved to".
Verification steps: Notice that the line numbers are correct (click on compare with latest-dev).
Change:
} .monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlide .getting-started-category .codicon.hide-category-button { <del> position: absolute; </del> <ins> margin-left: auto; </ins> top: 4px; right: 8px; }

Discussion:
Latest insider. <img width="433" alt="image" src="https://user-"We should make sure the delete action is clearly visible.
Change:
export function revealResourcesInOS(resources: URI[], electronService: IElectronService, notificationService: INotificationService, workspaceContextService: IWorkspaceContextService): void { if (resources.length) { sequence(resources.map(r => async () => { <del> if (r.scheme === Schemas.file) { </del> <ins> if (r.scheme === Schemas.file || r.scheme === Schemas.userData) { </ins> electronService.showItemInFolder(r.fsPath); } }));

Discussion:
Issue Type: <bBug</ba file outside of workspace ( ) to reveal it VS Code version: Code 1.44.0 (, 2020-04-07T23:31:18.860Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Looks like it doesn't work for specific VS Code files. With opened folder in I have no problem to Reveal in Explorer files like , , and . But no luck for User or files
/findDuplicates
Potential duplicates: <!-- score: 0.207 --- <!-- score: 0.193 --- <!-- score: 0.186 --- <!-- score: 0.162 --- <!-- score: 0.159 --<!-- potentialduplicatesreply --
Yes, I think we have this limitation. Here's a code pointer in case you would like to investigate more
Change:
} else if (argv['install-extension']) { const arg = argv['install-extension']; const args: string[] = typeof arg === 'string' ? [arg] : arg; <del> returnPromise = this.installExtension(args); </del> <ins> returnPromise = this.installExtension(args, argv['force']); </ins> } else if (argv['uninstall-extension']) { const arg = argv['uninstall-extension']; const ids: string[] = typeof arg === 'string' ? [arg] : arg;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.1 OS Version: MacOS 10.13.6 I have found that I am unable to reliably install extensions via the command line because of an update prompt that requires user interaction. A flag like or or would be helpful in allowing the command to run non-interactively. Steps to Reproduce: (or any extension that has a newer version than the one you have installed) appears: <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (CLI command)
May I know the use case why do you want to run this non interactively?
Thanks for the reply. I use the VS Code CLI to install extensions in . Managing my extensions in my dotfiles helps keep them in sync between my personal and work computers. You can see the script that uses the CLI .
I agree that the CLI should have a way to run every command, especially extension based commands without interaction. I also have an installer that is installing a list of VS Code extensions, and while I haven't directly seen this issue yet, it would be a major issue if it did.
Use --force to not to show prompts
Based on the code I could see in the pull request, it looks like this may prevent the command from updating already-installed extensions. Is that the case? If so, they will be updated through some other mechanism, correct? edit: I installed VS Code Insiders and will verify that the feature works for me when it arrives in the insiders build.
No, it will not prevent. If there is an update and you pass command, I would skip prompting and install the extension directly.
I was able to verify that the fix is working for me. Thanks for jumping on this!
I opened a related issue when testing this. However, I can actually repro that same issue when taking a previously installed extension and just updating its to be an older version, making this issue broken or at least unverifiable for me.
May I know if you reopened this issue because of or is there something else not working here?
I can reproduce the error you see in and it is happening only in windows.

Not sure if it is necessary to have both issues open. Is it ok to close the other one and track it here?
I think let's have them separate. This issue is for allow installing / updating extension without any prompt and other issue should show the prompt while updating.
Did you try updating the extension using argument here?
argument updates the extension without any prompts on Windows. Closing this. Please do verify. Let's track the prompts related issue in the other one you created ()
Change:
function areLanguageDiagnosticSettingsEqual(currentSettings: LanguageDiagnosticSettings, newSettings: LanguageDiagnosticSettings): boolean { return currentSettings.validate === newSettings.validate <del> && currentSettings.enableSuggestions && currentSettings.enableSuggestions; </del> <ins> && currentSettings.enableSuggestions === newSettings.enableSuggestions; </ins> } class DiagnosticSettings {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.1 OS Version: macOS 13 Steps to Reproduce: the following settings to : suggestions still show up: <img width="766" alt="image" src="https://user-"
what you are looking at is the hover. to disable that use this setting
Hi, I want to remove the three dots, disabling hovering doesn't help, these two settings , now they don't, a recent update broke that, please reopen this and take a look .
Oh, you mean "hint" diagnostics. Forwarding to for comment
Thanks for fowarding, I got the term from the : !
Change:
overflow: hidden; /* let the close button be pushed out of view when sizing is set to shrink to make more room... */ } <ins> .monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-container > .tab.close-button-right.sizing-shrink > .tab-close:focus-within { overflow: visible;/* fix invisible tab close button on focus: (fixes https://github.com/Microsoft/vscode/issues/41459) */ } </ins> .monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-container > .tab.dirty.close-button-right.sizing-shrink > .tab-close, .monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-container > .tab.close-button-right.sizing-shrink:hover > .tab-close { overflow: visible; /* ...but still show the close button on hover and when dirty */

Discussion:
Issue Type: <bBug</b==<kbdCtrl</kbd+<kbdM</kbd<kbdTab</kbduntil get to tab (no pun intended) ! VS Code version: Code 1.26.1 (, 2018-08-16T18:38:57.434Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

non-dirty file (New Untitled will do) to "close editor" border is set, which is nice, but it's invisible Shown only on hover: !
I cannot reproduce, can you reproduce with our default dark theme?
it's related to config. Reproduces with:
It's related to this piece:
thanks I can reproduce, but the fix is not good. I commented.
I think it would be easy to do in chromium 60 where is working.
Change:
} @throttle <del> sync(head: Branch): Promise<void> { return this._sync(head, false); } @throttle async syncRebase(head: Branch): Promise<void> { return this._sync(head, true); </del> <ins> sync(head: Branch, rebase: boolean): Promise<void> { return this._sync(head, rebase); </ins> } private async _sync(head: Branch, rebase: boolean): Promise<void> {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 10 Steps to Reproduce: .rebaseWhenSync true .postCommitCommand sync git.rebaseWhenSync true works on actionbutton and statusbar but it does not affect git.postCommitCommand sync
Change:
private activeActions: IAction[]; private updateScheduler: RunOnceScheduler; private debugToolBarMenu: IMenu; <del> private yCoordinate = 0; </del> private isVisible = false; private isBuilt = false;

Discussion:
a breakpoint or log here or copy a file into a new floating window between them a few times. The event fires a couple times but then stops firing
does it reproduce without having devtools opened in any of the windows?
this one takes me by surprise: in the main process I keep track of auxiliary windows and so far I have been using as identifier, assuming it would always match . But as it turns out, that is actually not always the case: if I open devtools and restart or reload, I see how suddenly of does not match the of anymore. In other words, I see an id of for example for the of the floating window, while its has an of . So I do think that I am doing something wrong and I need a different way how to figure out the window ID of a floating window... I track the creation of floating windows here from the :
Ah, that's the repro. Yes, you must have devtools open when you open the aux window. Opening them after the aux window is already open doesn't cause an issue, but once you do open them then the event won't fire properly until vs code is restarted
That is not the intended contract in the runtime, a BrowserWindow can have multiple WebContents at any point and their ids are independent. WebContent ids are incremental within the same process, so it purely depends on the creation order. You can use to get the owner window and that should give you the right id.
I tried that, but at the time fires, returns . In other words, the web content is being created before the window is there... So essentially, I have no way to find the window for the web contents so early.
I think maintaining a would suit this scenario, you can access the webContents a BrowserWindow owns via and this will be valid even at . Should be reliable than id.
Yeah, an alternative would be to pro-long aux-window handshake between main and renderer until the is there but I think thats overkill. I will see to keep aux windows identified by . Its a bit inconsistent because both aux and main window share the same base class and the one will use and the other ...
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
'problemsColors' = 'outline.problems.colors', 'problemsBadges' = 'outline.problems.badges' } <ins> export const enum OutlineConfigCollapseItemsValues { Collapsed = 'alwaysCollapse', Expanded = 'alwaysExpand' } </ins>

Discussion:
Testing Setting Open a github issue notebook You get: <img width="283" alt="image" src="https://user-"