jiebi/CodeConvo huggingface dataset:
Change:
get label(): string { return localize('create branch', '$(plus) Create new branch'); } get description(): string { return ''; } <ins> get shouldAlwaysShow(): boolean { return true; } </ins> async run(repository: Repository): Promise<void> { await this.cc.branch(repository); }

Discussion:
Problem The time you search for the branch and not find any, there are no other options to proceed. <img width="682" alt="screen shot 2018-09-15 at 11 06 09" src="https://user-"I as a developer would need to delete the search and then click on "create a new branch". Solution Keep "create a new branch" option always. <img width="656" alt="screen shot 2018-09-15 at 11 22 56" src="https://user-"
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.617 --- <!-- score: 0.587 --- <!-- score: 0.552 --- <!-- score: 0.547 --- <!-- score: 0.529 --<!-- potentialduplicatescomment --
Is this supported from an extension? Eg: keep an option always visible.
Dang, just noticed that you already submitted a PR to address this. Closed my PR, feel free to grab the integration test I if you want
since my PR is merged already, feel free to create a PR with tests :)
I a PR to add tests and also fix a small bug (when explicitly settings items on a the field was not properly propagated). Additional thoughts I had (should open another issue for discussion?): In my opinion, items that should always be shown shouldn't display search highlights. The highlights are possibly redundant and IMO it would look more elegant without I feel like after accepting the option, the input text should be preserved. Would a PR to address this be accepted? Also, possibly should this behavior be exposed for user control? (i.e. similarly to a field, a field.)
:+1: Nah, sounds like a very good default value.
Change:
reverseEndianness(uint8Arr); } if (uint8Arr.byteOffset % 4 === 0) { <del> return new Uint32Array(uint8Arr.buffer, uint8Arr.byteOffset); </del> <ins> return new Uint32Array(uint8Arr.buffer, uint8Arr.byteOffset, uint8Arr.length / 4); </ins> } else { // unaligned memory access doesn't work on all platforms const data = new Uint8Array(uint8Arr.byteLength); data.set(uint8Arr); <del> return new Uint32Array(data.buffer, data.byteOffset); </del> <ins> return new Uint32Array(data.buffer, data.byteOffset, data.length / 4); </ins> } }

Discussion:
This was spotted by when working. There are no steps to reproduce because this has to do with how a specific part of an extension host message (the semantic tokens dto) aligns on bytes in the underlying nodejs stream. I can reproduce through unit testing. This can lead to semantic tokens becoming stale and not updating.
The fix is now in and also in
There is a unit test for this case and there are no steps to verify =giving label.
Change:
dimension: { height: 0, width: 0 <del> } </del> <ins> }, renderSideBySide: true, useInlineViewWhenSpaceIsLimited: false </ins> }, { originalEditor: getOptimizedNestedCodeEditorWidgetOptions(), modifiedEditor: getOptimizedNestedCodeEditorWidgetOptions()

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest Insiders OS Version: N/A Steps to Reproduce: Open a Jupyter Notebook Make changes changes to the cell and view the diff (scm or timeline) issues left padding in the first code cell. (on the left of there is no padding unlike the one on right) centers of code and metadata are not aligned ceneters of code and metadata have different styles (code cells have a gap, but metadata have a gap with some shadow effect) VS Code (or the diff editor) You'll notice that metadata diff view resizes and finally collapses into one But this is not the case with the code cells, i think the width is hard coded for code cells On wide screens there's a lot of white space on the far right of the right most code cell) !
What are actionables I should look into? I think the top thing is not a diff editor. The gutter comes from
Closing this for now, as this can no longer be replicated.
Change:
} private _sanitizeInput(data: any) { <del> return typeof data === 'string' ? data.replace(TerminalInstance.EOL_REGEX, os.EOL) : data; </del> <ins> return typeof data === 'string' ? data.replace(TerminalInstance.WINDOWS_EOL_REGEX, 'r') : data; </ins> } protected _getCwd(shell: IShellLaunchConfig, workspace: IWorkspace): string {

Discussion:
VSCode Version: Code - Insiders 1.11.0-insider (, 2017-03-17T08:14:15.805Z) OS Version: Windows_NT ia32 10.0. Extensions: ; Steps to Reproduce: a terminal and run "bash" with a text file containing some lines of text ctrl+v (or right-click) to paste some lines of text What's expected: The text should be appended before the cursor, and the existing text should be there after the cursor. What happens: Existing text disappears, and it seems some extra newlines are when pasting text. Note: there is no such problem when doing the exact same steps with This happens on insider builds, no idea if it happens with standard builds as well.
More information. Here is what happens when I try to paste this text function startagent { echo "Initialising new SSH agent..." /usr/bin/ssh-agent | sed 's/^echo/#echo/' "${SSHENV}" echo succeeded chmod 600 "${SSHENV}" . "${SSHENV}" /dev/null /usr/bin/ssh-add; } In the middle of a file containing this text: existing file with some text Here is what happens with (that's what expected: text is pasted in between existing text): ! Here is what happens with VSCode: text is pasted with extra newlines plus existing text appears in the middle of the pasted text !
Any update on this bug ?
Thanks for the ping. I've validated it's definitely an upstream issue. I tried to fix it a couple of days ago but didn't get anywhere. I'd guess it's related to node-pty or winpty as different shells appeared to handle it differently. It also seemed somewhat inconsistent. No plans to invest further in fixing it just yet.
This is probably a bug with VSCode's JS xterm module, not a node-pty or winpty bug. I placed these two lines in an untitled editor window: I then set the environment variable , started VSCode, and copy-and-pasted the two lines above into VSCode's integrated terminal. This appeared in the winpty trace: The clipboard has CRLF-delimited lines, because we're on Windows. However, in the VT/100 input format, CR means Return, and LF means Ctrl-Return.

Something (probably the JS xterm) is copying the clipboard contents into the pty, and that something should normalize LF and CRLF into CR. I described this bug in detail the last time I saw it:
thanks! This is likely the culprit then which replaces all end of line chars with on Windows:
Yeah, I think your change will fix the issue. The function looks like it might also need a change. Maybe something like this?
FYI I think you may have run into these issues before? It would be a good idea to test these changes in in tomorrow's Insiders build.
I've certainly experienced aspects of this issue from the Python extension when running selections of code in the terminal.
I was unable to reproduce the problem anyway, so have no way of testing this. But thanks for letting me know :-)
Change:
/// Host to listen on, defaults to 'localhost' #[clap(long)] pub host: Option<String>, <ins> // The path to a socket file for the server to listen to. #[clap(long)] pub socket_path: Option<String>, </ins> /// Port to listen on. If 0 is passed a random free port is picked. #[clap(long, default_value_t = 8000)] pub port: u16,

Discussion:
It doesn't look like this new CLI supports serving on a UNIX domain socket. Could we please get that in too, like in We're going to need it in order to handle auth in a proxy. (I'm happy to open a new issue for that if you need) Originally posted by in
Nice, thanks!
I can do this what now?
Also is it an issue that the socket file wasn't release/deleted after a ctrl+C? or do I clean that up manually?
We should probably automatically delete the file if it exists You can do a to make sure it's actually working . Without extra stuff you won't be able to open it in the browser, but verifying the connection should be enough.
Change:
const createCodeActionsAutoSave = (description: string): IJSONSchema => { return { <del> type: ['string', 'boolean'], </del> <ins> type: 'string', </ins> enum: ['always', 'explicit', 'never', true, false], enumDescriptions: [ nls.localize('alwaysSave', 'Triggers Code Actions on explicit saves and auto saves triggered by window or focus changes.'),

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Apple M1 Max Mac 13.6.2 Steps to Reproduce: this snippet to VSCode settings VSCode keeps changing the setting to: If I change the value back to true (a valid value), then force the settings to sync (confirming the sync happened with the new setting), then reopen VSCode again.. the value has reverted it back to "explicit" and a new sync entry (from opening VSCode) happens saying it synced that new value. If I change the value to "always" it does not change back to "explicit".
While is still allowed, I think they're trying to deprecate that and encourage usage of //. It's changing to which is equivalent to had been prior to the September 2023 release aka v1.83, see discussion in release notes and .
Probably the best fix would be actually remove true/false values as valid inputs. Keeping them as valid can/will cause confusion. While it is mentioned in those release notes, not everybody reads every release notes in detail and it still conflicts with VSCode suggesting those values as valid.
We're affected by this as well. We have committed our VS Code settings to over a dozen repositories, so any developer on v1.85 encountered this auto-migration and saw those changes in their . Fortunately, we all update our VS Code version on the same day, so the impact is reduced, but it still means there will be merge conflicts and developers will need to rebase all of their branches.

In the past, whenever a VS Code update changes a setting, the old value continues to be accepted and there's a warning message shown. This gives us ample time to migrate the settings, instead of having to drop everything and fix it like today. Going forward, please follow that old approach and do not auto-migrate the settings.
This is a breaking change, how this even got merged?
Change:
assert.deepStrictEqual(actual, viewsCustomizations); }); <ins> test('storage change also updates locations even if views do not exists and views are registered later', async function () { const storageService = instantiationService.get(IStorageService); const testObject = aViewDescriptorService(); const generateViewContainerId = `workbench.views.service.${ViewContainerLocationToString(ViewContainerLocation.AuxiliaryBar)}.${generateUuid()}`; const viewsCustomizations = { viewContainerLocations: { [generateViewContainerId]: ViewContainerLocation.AuxiliaryBar, }, viewLocations: { 'view1': generateViewContainerId } }; storageService.store('views.customizations', JSON.stringify(viewsCustomizations), StorageScope.PROFILE, StorageTarget.USER); const viewContainer = ViewContainersRegistry.registerViewContainer({ id: `${viewContainerIdPrefix}-${generateUuid()}`, title: 'test', ctorDescriptor: new SyncDescriptor(<any>{}) }, ViewContainerLocation.Sidebar); const viewDescriptors: IViewDescriptor[] = [ { id: 'view1', ctorDescriptor: null!, name: 'Test View 1', canMoveView: true }, { id: 'view2', ctorDescriptor: null!, name: 'Test View 2', canMoveView: true } ]; ViewsRegistry.registerViews(viewDescriptors, viewContainer); testObject.onDidRegisterExtensions(); const viewContainer1Views = testObject.getViewContainerModel(viewContainer); assert.deepStrictEqual(viewContainer1Views.allViewDescriptors.map(v => v.id), ['view2']); const generateViewContainer = testObject.getViewContainerById(generateViewContainerId)!; assert.deepStrictEqual(testObject.getViewContainerLocation(generateViewContainer), ViewContainerLocation.AuxiliaryBar); const generatedViewContainerModel = testObject.getViewContainerModel(generateViewContainer); assert.deepStrictEqual(generatedViewContainerModel.allViewDescriptors.map(v => v.id), ['view1']); }); </ins> });

Discussion:
In my default profile with gitlens installed, move 3 gitlens views to a new view container (in secondary side bar) Create an empty profile Switch back to default profile gitlens view are back in SCM instead of in their new view container CC
Works great, thank you!
Change:
actionRunner?: IActionRunner; ariaLabel?: string; animated?: boolean; <ins> triggerKeys?: ActionTrigger; </ins> } let defaultOptions: IActionBarOptions = { orientation: ActionsOrientation.HORIZONTAL, <del> context: null </del> <ins> context: null, triggerKeys: { keys: [KeyCode.Enter, KeyCode.Space], keyDown: false } </ins> }; export interface IActionOptions extends IActionItemOptions {

Discussion:
Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !
Change:
class CheckoutItem implements QuickPickItem { protected get shortCommit(): string { return (this.ref.commit || '').substr(0, 8); } <del> get label(): string { return this.ref.name ? `${this.ref.name}${this.repository.isBranchProtected(this.ref.name) ? ' $(lock-small)' : ''}` : this.shortCommit; } </del> <ins> get label(): string { return `${this.repository.isBranchProtected(this.ref.name ?? '') ? '$(lock)' : '$(git-branch)'} ${this.ref.name || this.shortCommit}`; } </ins> get description(): string { return this.shortCommit; } constructor(protected repository: Repository, protected ref: Ref) { }

Discussion:
<img width="128" alt="CleanShot 2022-06-24 at 07 47 19 src="https://user-"<img width="230" alt="CleanShot 2022-06-24 at 07 47 05 src="https://user-"<img width="209" alt="CleanShot 2022-06-24 at 07 48 13 src="https://user-"
Added icons to all the entries so that the quick pick items are consistent. <img width="714" alt="image" src="https://user-"
I wouldn't add icons for every entry as it can get busy/repetitive. and I were just discussing about reducing the repetition of icons in quick picks and only showing them for the ones that really warrant it. <img width="488" alt="CleanShot 2022-06-24 at 12 23 12 src="https://user-"
FYI was suggesting removing the regular branch icons which it doesn't look like the change does. That would align closer with how tasks use icons (defaults are hidden) and the new debug console quick access for example.
This particular quick pick contains items of different types (ex: local branch, remote branch, tag). The only was to distinguish the type if to look at the description of the icon. I think that having an icon for each item based on its type is actually helpful here. I would like to keep it and see what the user feedback will be.
Just by looking at the icons, I'm only seeing the "locked" branch as the different one from the others. There is no difference between the local and remote branches here so I'm not seeing the benefit of showing the icon every single time and still feels very noisy: <img width="335" alt="CleanShot 2022-07-11 at 08 19 54 src="https://user-"
Reopening to track discussion
Here is what I am seeing if I am running a search for "release". I can clearly differentiate between tags, locked branches, and branches. if I would have a suitable icon for a remote branch, I would be happy to add it.

I personally still feel that there is value in showing an icon for item, especially that I think the way people interract with the branch picker is that they open it and start typing in the input to filter down to the item that they would like to open. <img width="728" alt="image" src="https://user-"
We could try to add an overlay on the branch icon, similar to VS: <img width="118" alt="CleanShot 2022-07-13 at 07 59 57 src="https://user-"
Love it! If you add this icon, I am happy to place this in the picker to indicate remote branches.
Closing this issue as I have the icon for remote branches.
Change:
export function addDisposableNonBubblingPointerOutListener(node: Element, handler: (event: MouseEvent) => void): IDisposable { return addDisposableListener(node, 'pointerout', (e: MouseEvent) => { // Mouse out bubbles, so this is an attempt to ignore faux mouse outs coming from children elements <del> let toElement: Node | null = <Node>(e.relatedTarget || e.target); </del> <ins> let toElement: Node | null = <Node>(e.relatedTarget); </ins> while (toElement && toElement !== node) { toElement = toElement.parentNode; }

Discussion:
Issue Type: <bBug</bSteps to Reproduce: a project/folder mouse into Editor and then move it out from right edge of the window Activity Bar mouse into Side Bar and then move it out from left edge of the window VS Code version: Code 1.37.1 (, 2019-08-15T16:16:34.800Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --
The issue seems to be in , but I am not sure what the difference is between that edge of the editor and the others. For some reason the mouseLeave event is not being fired on the right-hand side. It seems it thinks the is the same as the initially given - which means the leave event is never fired. I'm happy to keep digging into this if that's ok with you.
Change:
clear(): void { this.label = undefined; this.options = undefined; <del> this.lastKnownConfiguredLangId = undefined; </del> <ins> this.lastKnownDetectedModeId = undefined; </ins> this.computedIconClasses = undefined; this.computedPathLabel = undefined;

Discussion:
Issue Type: <bBug</bto something like . a new tab. The tab should have the Markdown icon, but it has the Plain Text icon. If you move to another tab then back, the icon will be updated. This only started happening when I updated to 1.3, and it's still happening in Insiders. I've got no extensions or settings (other than ) set. VS Code version: Code - Insiders 1.31.0-insider (, 2018-12-21T06:14:53.023Z) OS version: Darwin x64 18.2.0 <!-- generated by issue reporter --
This is a consequence of adopting : When the tab opens we immediately render the icon, but the resource only gets the mode associated after a on the end of the tick.
via
Change:
if (message) { options.input = message; <del> args.push('--file', '-'); </del> <ins> args.push('--allow-empty-message', '--file', '-'); </ins> } if (opts.verbose) {

Discussion:
Issue Type: <bBug</bWhen I try to create an empty commit, this popup in the bottom-right comes up with the message "Commit operation was cancelled due to empty commit message.". This is after the latest Code Insiders update. Steps: 1 whitespace in the commit message box sync (check button in source control) comes This is a feature I use all the time, literally. I kindly request quick fixture of this issue. VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-20T05:17:02.003Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (60)</summaryExtensionVersion ------ html-snippets0.2.1 jbart-studio0.6.8 code-gnu-global0.2.2 vscode-intelephense-client1.8.2 doxdocgen1.4.0 vscode-eslint2.2.2 vscode-html-css1.13.0 vsc-material-theme-icons2.3.1 cshtml0.1.3 cshtml-tm1.0.0 code-runner0.11.8 language-lava1.1.11 ghoul007-puppeteer-snippet1.1.2 vscode-pull-request-github0.44.0 better-cpp-syntax1.15.18 vscode-JS-CSS-HTML-formatter0.2.3 file-downloader1.0.12 vscode-docker1.22.0 csharp1.25.0 data-workspace-vscode0.2.1 mssql1.15.0 sql-bindings-vscode0.2.0 sql-database-projects-vscode0.17.1 jupyter2022.5.

jupyter-renderers1.0.8 remote-containers0.240.0 remote-ssh0.82.1 remote-ssh-edit0.80.0 remote-wsl0.66.3 atom-keybindings3.0.9 cmake-tools1.11.26 cpptools1.11.0 cpptools-extension-pack1.2.0 vsliveshare1.0.5625 vsliveshare-audio0.1.91 sqltools0.23.0 puppeteer-snippets1.6.1 open-html-in-browser2.1.9 material-icon-theme4.18.1 webfocus0.2.3 aspx-html0.0.11 java1.7.0 vscode-yaml1.8.0 sql-snippets0.0.4 spgo1.7.3 sonarlint-vscode3.5.4 codevalet-vscode2.0.1 webfocus0.6.2 html-preview-vscode0.2.5 python0.2.3 pdf1.2.0 cmake0.0.17 vscodeintellicode1.2.21 vscode-arduino0.4.12 vscode-java-debug0.41.0 vscode-java-dependency0.19.1 vscode-java-pack0.23.0 vscode-maven0.35.2 php-debug1.27.0 html-css-class-completion1.20.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I tried clicking on the commit button without typing a message and the viewlet seems to be stuck. I'm able to create a commit with a single space as a message, though.
Change:
readonly currentHistoryItemGroupId = derived<string | undefined>(this, reader => this.currentHistoryItemGroup.read(reader)?.id); readonly currentHistoryItemGroupName = derived<string | undefined>(this, reader => this.currentHistoryItemGroup.read(reader)?.name); <del> private readonly _currentHistoryItemGroup = observableValueOpts<ISCMHistoryItemGroup | undefined>({ owner: this, equalsFn: structuralEquals }, undefined); </del> <ins> private readonly _currentHistoryItemGroup = observableValueOpts<ISCMHistoryItemGroup | undefined>({ owner: this, equalsFn: () => false }, undefined); </ins> get currentHistoryItemGroup() { return this._currentHistoryItemGroup; } constructor(private readonly proxy: ExtHostSCMShape, private readonly handle: number) { }

Discussion:
Steps to Reproduce: a folder/workspace that contains a git repository some commits so that you have some outgoing changes in the history graph the output window, switch to the Git output channel, and clear the contents the "Refresh" action in the "Source Control" viewlet should see a entry int the output channel