jiebi/CodeConvo huggingface dataset:
Change:
export interface IAuxiliaryEditorPart extends IEditorPart { /** <del> * Close this auxiliary editor part and free up associated resources. </del> <ins> * Close this auxiliary editor part after moving all * editors of all groups back to the main editor part. </ins> */ <del> close(): Promise<void>; </del> <ins> close(): void; </ins> } /**

Discussion:
Testing It would be great if we can have a command to bring back those editors to the main window.
I think that should actually be the default behaviour when you just close the window. That will prevent ugly confirmation dialogs for dirty editors when you attempt to close the floating window.
Verification: open a floating window with some editors (e.g. by dragging an editor tab out of the window) close the floating window, e.g. from the X window button verify all editors of the floating window are moved back to the main window
Change:
"license": "MIT", "description": "Dependencies shared by all extensions", "dependencies": { <del> "typescript": "^4.6.1-rc" </del> <ins> "typescript": "4.6.2" </ins> }, "scripts": { "postinstall": "node ./postinstall"

Discussion:
Tracks including TS 4.6 in VS Code See and the TS repo for details on upcoming features
Change:
@INativeHostService private readonly nativeHostService: INativeHostService, @IDialogService dialogService: IDialogService, @IInstantiationService private readonly instantiationService: IInstantiationService, <del> @ITelemetryService telemetryService: ITelemetryService </del> <ins> @ITelemetryService telemetryService: ITelemetryService, @IEnvironmentService private readonly environmentService: IEnvironmentService </ins> ) { super(layoutService, dialogService, configurationService, telemetryService); }

Discussion:
Since the november 2023 update steals window focus. This is really problematic because uses this to run end to end tests and now the development host window pops up for every single test case, which renders all other windows unusable while I’m running tests, as the test window steals focus many times per second. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 (user setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: extension host vscode main window the following code: vscode extension development host window is now focused.
We should add rules to not change focus during extension development tests.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I can reproduce this: an extension that activates : 5, and immediately focus back to the VS Code window you F5'd from When executes, the ext dev host window will regain focus
Sorry, bad description: its only disabled when running extension tests.
Change:
this.remoteMetadataInitialized = true; this._onDidChangeEntries.fire(); <del> showRemoteStartEntry.bindTo(this.contextKeyService).set(true); </del> this.updateRemoteStatusIndicator(); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 (system setup) OS Version: WindowsNT x64 10.0. Commit: Date: 2023-07-12T17:22:07.651Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 vscode a couple of seconds the new "Connect to..." link button on the welcome page is delayed resulting in a really annoying change of the height for the "Start" section and, during the working, a missclick on the wrong recent project. a. remove the button b. fix the height of the "Start" section c. make the button link disable at first, in case something has to load before d. improve the a/b testing expirience, if i am in one of them!!

vsliv368: vsreu685: python383: vspor879: vspor708: vspor363: vswsl492cf: vslsvsres303: vserr242cf: pythontb: vsjup518: pythonptprofiler: vshan820: vstes263: vscod805: binariesv615: bridge0708: bridge0723: vsaa593cf: pythonvs932: py29gd2263cf: vscaat: vsclangdc: c4g48928: dsvsc012cf: pynewext54: azure-devsurveyone: 3biah626: pyind779: : pythonsymbol12: showlangstatbar: vsctsb: pythonms35: : pythonfmttext: pythoncmv: fixshowwlkth: showindicator: pythongtdpath: i26e3531: pythonnosm12tcf: pythonidxpt: pythonnoceb: : dsvsc013:
Change:
// read file contents for undo operation. when a file is too large it won't be restored let fileContent: IFileContent | undefined; <del> if (!edit.undoesCreate && !edit.options.folder) { </del> <ins> if (!edit.undoesCreate && !edit.options.folder && !(typeof edit.options.maxSize === 'number' && fileStat.size > edit.options.maxSize)) { </ins> try { fileContent = await this._fileService.readFile(edit.oldUri); } catch (err) { this._logService.critical(err); } } <del> if (!(typeof edit.options.maxSize === 'number' && fileContent && (fileContent?.size > edit.options.maxSize))) { undoes.push(new CreateEdit(edit.oldUri, edit.options, fileContent?.value)); </del> <ins> if (fileContent !== undefined) { undoes.push(new CreateEdit(edit.oldUri, edit.options, fileContent.value)); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.2 () OS Version: Ubuntu 20.04.3 LTS This issue is acutally discovered in , but I found that the root cause is from the upstream vscode, so I am submitting the issue here. Steps to Reproduce: a vscode window in the browser. to delete a large file (100MB) deletion takes a long time, or the tab is killed by OOM. The cause I found is that when deleting a file, vscode keeps the file content into memory to support undo operation, only if the file is not too large. But in the code, vscode read the file content unconditionally at first and then discards it if exceeds the size limit. Related issues from code-server
Change:
resolved "https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.4.3.tgz#f1071c4a821acc71d43f36ff8051d3816d832e1c" integrity sha512-bHS3sCoh+raqFGIxmL/plER3eBQ+IEBy4RH/4uahhToZneTvqNKQrL0PgOTtnpL55XjBd3dy0pNtZMkCk0J48g== <del> native-keymap@3.0.2: version "3.0.2" resolved "https://registry.yarnpkg.com/native-keymap/-/native-keymap-3.0.2.tgz#eb299a9f1a252be552ee2345ba8a39ff4b2c304a" integrity sha512-1qH2saFkYzwT+c2a1xaawrfgkiT1OJ6H8xZWx9zmhhOkuJto/HaNLSINxCYhSjc7zO0zOydMkoCXehGh3TAWcg== </del> <ins> native-keymap@3.0.3: version "3.0.3" resolved "https://registry.yarnpkg.com/native-keymap/-/native-keymap-3.0.3.tgz#7f846f2136ea31785ac06cd917c84abac1c88bfb" integrity sha512-XBKD3jpRI4GsrVIe5TB1PAk2ZLEJY/HcH4N9ZssnzP3+HD5V+ABqXs37VLQtiUF/EsmQ1xEeWquPyWFFpeeIpg== </ins> native-watchdog@1.3.0: version "1.3.0"

Discussion:
VS Code Version: 1.62.3 OS Version: Linux See Attached a Breakpad minidump here. The important point being here is that our extension has no native code. I don't think plain JavaScript code should be able to make Code crash with or trigger a stack buffer overflow.
for attaching a crash dump right away.
For the segmentation fault here is the symbolicated trace, <details<summaryTrace:</summary</details
The crash thread stacks are correctly symbolicated, but cannot say the same for main thread. Basically, when module tries to call the thread safe function it segfaults when acquiring the lock at I see threads 9, 10 and 11 triggering a fatal error on the node process and waiting on this lock , not sure if this lead to freeing the thread safe function. do you see any logs in the crashed process that starts with basically , this might give some clue as to what is happening.
From the , the fact that we see: Could this indicate that this crash happens in the shutdown phase? One problem that we have in is that the shutdown path is not clean. See where is set to . I think that is set to as part of shutdown and then after that an X event is received which then leads to running with being . I think we should simply add a null check before calling and exit the loop if that happens because it means that nodejs is shutting down. What do you think?
yup we should do that, I was hoping we hit this if the thread safe function was null, that would happen before the function executed. But looking at the macro definitions, looks like node will end up using ;l=35 that eventually will trigger the block I mentioned previously. I think the stack makes sense now based on this assessment.
Thanks for the fix, but the failure in happened on Windows, while looks like X11-specific code. Well, I guess there's more than one issue.
Can you attach crash log from the windows run as a separate issue, I think we can leave this one for verifying the from linux. Thanks!
It might be harder to pull the logs from GHA, but I'll think about it.
Given our green CI history, marking as verified.
Change:
pinned, selection, revealIfVisible: true, <del> indexedCellOptions: element instanceof MatchInNotebook ? { index: element.cellIndex, selection: element.range() } : undefined, </del> }; try {

Discussion:
Testing open enable search for click on a result in observe the selection is set on the input code and not on the output
Seems that navigating to the result also causes it to flicker (~13 seconds in to the sceencap).
Change:
if (this.options.length === 0) { this.options.push({ label: nls.localize('noConfigurations', "No Configurations"), handler: () => false }); <ins> } else { this.options.push({ label: StartDebugActionItem.SEPARATOR, handler: undefined }); </ins> } <del> this.options.push({ label: StartDebugActionItem.SEPARATOR, handler: undefined }); </del> const disabledIdx = this.options.length - 1; launches.filter(l => !l.hidden).forEach(l => {

Discussion:
Separator after single entry (No Configurations) should not appear If no objections, I will PR. !
Change:
touch-action: none; /* Disable browser handling of all panning and zooming gestures. Removes 300ms touch delay. */ } <del> .monaco-workbench ::selection { background-color: var(--vscode-selection-background); } </del> .monaco-workbench.border:not(.fullscreen) { box-sizing: border-box; border: 1px solid var(--window-border-color);

Discussion:
open quick input or the find widget type and select some text observe that the selection is not rendered (this happened with this insiders update, I'm quite sure it was working in yesterday's insiders) https://user-
So it looks like the use of CSS variables in some cases is dangerous. Here explains a bit more. My fix is to revert back to how it was for
Change:
private updateRecommendationStatus(extension: IExtension, data: ITemplateData) { const extRecommendations = this.extensionTipsService.getAllRecommendationsWithReason(); <ins> let ariaLabel = extension.displayName + '. '; </ins> if (!extRecommendations[extension.id.toLowerCase()]) { <del> data.root.setAttribute('aria-label', extension.displayName); data.root.title = ''; </del> removeClass(data.root, 'recommended'); <ins> data.root.title = ''; </ins> } else { <del> data.root.setAttribute('aria-label', extension.displayName + '. ' + extRecommendations[extension.id]); data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText; </del> addClass(data.root, 'recommended'); <ins> ariaLabel += extRecommendations[extension.id.toLowerCase()].reasonText + ' '; data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText; </ins> } <ins> ariaLabel += localize('viewExtensionDetailsAria', "Press enter for extension details."); data.root.setAttribute('aria-label', ariaLabel); </ins> } disposeTemplate(data: ITemplateData): void {

Discussion:
Learnings from NVAccess testing: I'm not sure how to get to the "details". Steps: Visual studio code editor. "Ctrl+Shift+X" key navigate to the extension side view bar option. Tab key navigate to the "More" option and select different options( "Show installed Extension, Show outdated extension, Show popular Extension,Etc") an extension and using "Tab" and "Arrow" keys navigate through the extension details window on the RHS
What do you think of a "Read more" button for each item? It will get a little noisy. Any other ideas?
Or just update the aria label on the extension item with "Click to read more" ? Because hitting Enter when the list item has focus, does open the details
definitely prefer making changes on the code side. The label should probably read like “View extension details” so it’s a little more explicit.
Change:
"name": "overline" }, { <ins> "name": "none", "desc": "Produces no text decoration." }, { </ins> "name": "solid" }, {

Discussion:
typing gives intellisense for colors, not for text-decoration. typing non will not show 'none' in Intellisense. The problem occurs in any css, less and scss file in any place, with any selector. Problem also occurs without extensions. I am running Windows 7 32bit with all updates possible. ! !
Colours are valid values for text-decoration, as it is a shorthand which includes text-decoration-color
Change:
append_dir GTK_PATH "$SNAP/usr/lib/$ARCH/gtk-3.0" append_dir GTK_PATH "$SNAP/usr/lib/gtk-3.0" <ins> # We don't have gtk libraries in this path but # enforcing this environment variable will disallow # gtk binaries like `gtk-query-immodules` to not search # in system default library paths. # Based on https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkmodules.c#L104-136 export GTK_EXE_PREFIX="$SNAP/usr" </ins> # ibus and fcitx integration GTK_IM_MODULE_DIR="$SNAP_USER_COMMON/.cache/immodules"

Discussion:
Ubuntu 22.10, Gnome 43.1, fresh VM - The errors are not shown the second time I call and also VS Code seems to start and work I saw , but that should be in by now.
Change:
"minimatch": "^5.1.6", "request-light": "^0.7.0", "which": "^4.0.0", <del> "which-pm": "^2.1.1" </del> <ins> "which-pm": "^2.1.1", "vscode-uri": "^3.0.8" </ins> }, "devDependencies": { "@types/minimatch": "^5.1.2",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: NA <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: NA OS Version: NA extensions/npm does depend on vscode-uri (tasks.?s import it), but doesn't declare it in , which results in following build failure of vscode: Please add into dependencies. I'd love to submit a PR myself, but unfortunately .
how are you building VS Code? I don't see this error.
As per instructions in this repository. step fails with the error I mentioned. , in dependencies.
Can you share a link to the instructions?
Here is my build script: And it fails: Unless
Can you reproduce the problem you're seeing with just the repo?
It is already so. I don't use any other repos.
your build script isn't in Does this issue occur when you use the build scripts in
is exactly from this repository. Well, after of course.
Any news on this?
Was this issue fixed?
what should we do here?
I think you just need to submit a PR adding this dependency
Exactly, I confirm.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified Built from successfully without needing to remove
Change:
const editorProject: string = 'vscode-editor', workbenchProject: string = 'vscode-workbench', extensionsProject: string = 'vscode-extensions', <del> setupProject: string = 'vscode-setup'; </del> <ins> setupProject: string = 'vscode-setup', serverProject: string = 'vscode-server'; </ins> export function getResource(sourceFile: string): Resource { let resource: string;

Discussion:
Testing in Firefox, with Spanish (es-es) set Open "Get Started with VS Code in the Web" walkthrough Select last step (open up your code), then first command ("Open Folder" in English, "Abrir carpeta" in Spanish) Modal is in English: ! It isn't a new string, and I didn't think getting started or this command would be from an extension, but perhaps that is the case.
I also see this on modals on the overall welcome page when I try opening a file or folder: !
Thank you for your feedback. We are currently reviewing it (reference ).
This is an odd one. The string looks good here: but the file that that comes from doesn't show up at all in our Spanish files: I'll have to dig into why this is... any ideas?
might be a bug in the tool so that the localize call is not detected. When you generate the export is the string included.
Ok the web strings are now bundled in language packs. It may take a minute for all these new strings to make their way through the translation system... but by end game it should be good.
Change:
hoverPreparation?.dispose(); hoverPreparation = undefined; } <del> hoverDelegate.onDidHideHover?.(); </del> <ins> if (hadHover) { hoverDelegate.onDidHideHover?.(); } </ins> }; const triggerShowHover = (delay: number, focus?: boolean, target?: IHoverDelegateTarget) => {

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-16T05:23:44.671Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes /assign <!-- generated by issue reporter --
Thanks! This is also a regression because we are only supposed to show it on files with decorations (such as source control) or overflowing text (such as ).
I don't get this custom hover ever. Can you please add steps to verify?
These custom hovers have been removed from product due to being too buggy at the moment. I will just mark this as verified as this feature isn't ready for testing yet.
Change:
} .action-widget .monaco-list-row.action.option-disabled, <ins> .action-widget .monaco-list:focus .monaco-list-row.focused.action.option-disabled, </ins> .action-widget .monaco-list-row.action.option-disabled .codicon { color: var(--vscode-disabledForeground); } .action-widget .monaco-list-row.action:not(.option-disabled) .codicon { color: inherit; }

Discussion:
Settings: !
How it should be: <img width="442" alt="image" src=""
Hm, strange. I haven't made any changes here lately. I'm noting that is not having an effect on the foreground color used on the tree within Explorer. It does however affect other lists like the one used in the quick pick. I also noticed the terminal tabs tree flicker to use that red before being stomped on again. Not sure what's going on here yet.
Looks like this is from
Gotcha I might just revert the change and switch it to something more specific - I didn't consider all the other applications of the list widget and checking other themes (it was okay in a couple of the themes I checked)

Repro: a in an import and run the refactor command via command palette the items !
Similar to
Change:
* Record the start of the input event. */ export function onInput() { <ins> if (state.input === EventPhase.Before) { // it looks like we didn't receive a `beforeinput` onBeforeInput(); } </ins> queueMicrotask(markInputEnd); } function markInputEnd() { <del> performance.mark('input/end'); state.input = EventPhase.Finished; </del> <ins> if (state.input === EventPhase.InProgress) { performance.mark('input/end'); state.input = EventPhase.Finished; } </ins> } /**

Discussion:
I suspect this comes from
You're right, this is: Right now, the module assumes that it will be called in the following order: It is possible that if a is skipped by the browser that we don't mark and that would cause an error at
Good morning I'm having trouble logging into the app. I get the following error. Uncaught SyntaxError: Failed to execute 'measure' on 'Performance': The mark '<REDACTED: user-file-path' does not exist. I hope you can help me with the solution. thank you.
Change:
} #[derive(Debug)] <ins> pub struct OAuthError { pub error: String, pub error_description: Option<String>, } impl std::fmt::Display for OAuthError { fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { write!( f, "Error getting authorization: {} {}", self.error, self.error_description.as_deref().unwrap_or("") ) } } #[derive(Debug)] </ins> pub struct CommandFailed { pub output: std::process::Output, pub command: String,

Discussion:
Windows 11 Latest Insiders WSL with Ubuntu 20.04.5 LTS I am trying to get and run the insiders code cli on a WSL Ubuntu 20.04 instance. the linux x64 insiders cli from here: and save the file to someplace in your WSL Ubuntu 20.04 folder : the file is the same name as the stable x64 version, so i'm not sure if am really getting insiders. , note the time stamp in the future error disc i see a executable, why is there a code-insiders`? see 2 above the GitHub login dance Result - it hangs in the terminal, no URL is displayed, here's the output from (which repeats):
can you try again with today's Insiders build of the CLI? It should print more detailed information about the error, if any, that's happening.
works great today! i was able to log in, get the URL, and hit it from another machine. still, why is the executable and not ? I see I can use the option but that breaks my flow (always use from the terminal)
That's a to fix, tracked in I'll go ahead and close this issue for now. I have a feeling it was something on GH's end, but at least next time we see this, we should be able to get more info.