jiebi/CodeConvo huggingface dataset:
Change:
navigator.serviceWorker.addEventListener('controllerchange', onControllerChange); } }).catch(error => { <del> reject(new Error(`Could not register service workers: ${error}.`)); </del> <ins> if (!onElectron && error instanceof Error && error.message.includes('user denied permission')) { return reject(new Error(`Could not register service worker. Please make sure third party cookies are enabled: ${error}`)); } return reject(new Error(`Could not register service worker: ${error}.`)); </ins> }); });

Discussion:
I just tried Codespaces for the first time. I clicked on Codespaces, and then I started my first Jupyter template. Then I opened one of the included notebooks (). The window opened is empty and it loops forever (small moving blue line moving from left to right on top of window). It also opens the following notifications: " Error loading webview: Error: Could not register service workers: NotSupportedError: Failed to register a ServiceWorker for scope ('') with script (''): The user denied permission to use Service Worker.. " There seems to be an option for "Insiders Version". I tried that as well, but to no avail, same error. I also tried the latest version of the Jupyter extension plugin by Microsoft, still the same error. The demo/jupyter template seems to be broken. Also any advise on how to try it out ? cheers ADD ISSUE DESCRIPTION HERE Version: 1.76.0 Commit: User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36 Embedder: codespaces <!-- generated by web issue reporter --
What browser are you using? Are you in private mode?
hi thanks for the follow up. I'm not sure what "private mode" means, but I was using a standard Chrome browser in a linux laptop. chrome://version ==110.0.5481.177 (Official Build) (64-bit)
In chrome it's called incognito mode. Are you using it or any other privacy type settings, specifically around cookies?
Oh, apologies. No, I was not using incognito mode. I don't have any special cookies settings, or using any extension in that direction. Pretty vanilla set up, as far as I know.
Also I tried from 2 different computers, both using Chrome, and Linux 22.04.
Oh, ok, today I tried once again. And this time I noticed that Chrome is configured to block third-party cookies -- I hadn't noticed before because that only kicks in later, once I open the jupyter notebooks. Once I clicked on the little icon to enable it, it works!
Maybe worth finding a way to communicate this to the user ?
Thanks for confirming. Discussed in AFAIk we can't actually track that this setting is causing the error, but I'll see if we can add some suggestion text to the error message we show
Change:
let path: string; const resources = e.dataTransfer.getData(DataTransfers.RESOURCES); if (resources) { <del> path = URI.parse(JSON.parse(resources)[0]).path; </del> <ins> path = URI.parse(JSON.parse(resources)[0]).fsPath; </ins> } else if (e.dataTransfer.files.length > 0) { // Check if the file was dragged from the filesystem path = URI.file(e.dataTransfer.files[0].path).fsPath;

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: Insider OS Version: Windows 10 64 bit Steps to Reproduce: and drop a tab from the editor onto the integrated terminal What happens? A unix-like path is copied, like: . This path is invalid and cannot be used into the terminal without replacing the slashes with backslashes and removing the first slash. What should happen? This should copy a Windows path:
The path should also be compatible with other shells, such as bash under WSL or Git Bash. This would require another setting though, unless it is assumed the executable names are never changed by people.
Question is, how do you know which environment you're running on? I'm not sure this can be properly guessed. The could be used but nothing stops the user from running bash even though integrated shell is set to on Windows for example.
Good point. I'm not sure either. The only way may be to analyze prompt strings / prefixes, unless there is a way to get the most nested process running in the shell.
In the meantime maybe it could be fixed so that it works in at least one environment (I would suggest ), because right now, the path's that's returned () isn't valid in any environment (cmd/bash).
It turns out there is a way to query child processes of the shell, and I created a PR () that does this. The querying does add some latency though, so keeping the path always Windows-formatted could be a better way to go.
Nice work I'd vote for simply formatting paths as Windows by default, and have an option to use your method.
it looks like you've stumbled onto something I've been wanting for a while in . I made a note in :beers:
It's supposed to be fixed according to the VSCode 1.15 release notes but it still returns an invalid path on Windows 10 with (Creators Update)
I just fixed this today (before I saw this issue). it was happening because we were getting the URI path, not the file path. change to get different shells formatting the path differently is blocked on which is actively being worked on.
I'll keep it open until other shell paths are handled correctly
Change:
} } <del> fn handle_secret_mint(ctx: HandleContext, req: Request<Body>) -> Response<Body> { </del> <ins> fn handle_secret_mint(ctx: &HandleContext, req: Request<Body>) -> Response<Body> { </ins> use sha2::{Digest, Sha256}; let mut hasher = Sha256::new();

Discussion:
The command was augmented with the argument here in Because the does not include the , any attempts to mint a key will result in a 404 if the server-base-path is set. I think this is the reason why I am experiencing an issue that any sign-in attempt in the browser (e.g., Github Copilot, Settings Sync) do not persist between page refreshes. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.1 OS Version: x64 Steps to Reproduce: the browser, observe 404s to
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
assigned to you since you approved the original PR
Change:
import { DocumentationExtensionPoint, documentationExtensionPointDescriptor } from 'vs/workbench/contrib/codeActions/common/documentationExtensionPoint'; import { ExtensionsRegistry } from 'vs/workbench/services/extensions/common/extensionsRegistry'; import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; <del> import { CodeActionsContribution, editorConfiguration } from './codeActionsContribution'; </del> <ins> import { CodeActionsContribution, editorConfiguration, notebookEditorConfiguration } from './codeActionsContribution'; </ins> import { CodeActionDocumentationContribution } from './documentationContribution'; const codeActionsExtensionPoint = ExtensionsRegistry.registerExtensionPoint<CodeActionsExtensionPoint[]>(codeActionsExtensionPointDescriptor);

Discussion:
Testing I have the following set: When using the sample extension at I expect this to not trigger the code action on save but it does do it. Because there is no auto-complete I tried a bunch of other things also to no avail.
Change:
import { TPromise } from 'vs/base/common/winjs.base'; import editor = require('vs/editor/common/editorCommon'); import aria = require('vs/base/browser/ui/aria/aria'); <ins> import { AIAdapter } from 'vs/base/node/aiAdapter'; </ins> import editorbrowser = require('vs/editor/browser/editorBrowser'); import { IKeybindingService, IKeybindingContextKey } from 'vs/platform/keybinding/common/keybindingService'; import {IMarkerService} from 'vs/platform/markers/common/markers';

Discussion:
If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).
this is probably something you want to use...
The functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .
we are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?
yes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?
What we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.
For Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?
previously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.
Change:
title: { value: localize( 'mergeEditor.acceptMerge', <del> 'Accept Merge' </del> <ins> 'Complete Merge' </ins> ), <del> original: 'Accept Merge', </del> <ins> original: 'Complete Merge', </ins> }, f1: false, precondition: ctxIsMergeEditor

Discussion:
Testing This was feedback I heard from others too—"Accept Merge" is a bit strange since you aren't really accepting a merge so much as the individual changes. I think "Complete Merge" would make more sense here. <img width="265" alt="CleanShot 2022-09-27 at 11 50 56 src="https://user-"
Or maybe "Confirm Merge".
More ideas: I like this - I think "confirm" is usually used to approve an already stated intention and does not fully fit here. ideas?
"Complete Merge" and "Accept Merge" are the best options. I am leaning towards "Complete Merge". fyi
for "Complete Merge"
Change:
isBeforeOrEqual(other: Position): boolean; /** <del> * Check if `other` is after this position. </del> <ins> * Check if this position is after `other`. </ins> * * @param other A position. * @return `true` if position is on a greater line

Discussion:
In , the comparison functions , , , and have misleading descriptions. For example, says "Check if is before this position." I think it would be more clear to say something like "Check if this position is before ", as that is when is returned. Likewise for the other three.
Change:
import { registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { UserDataSyncErrorCode, UserDataSyncStoreError } from 'vs/platform/userDataSync/common/userDataSync'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import { INotificationService } from 'vs/platform/notification/common/notification'; import { IDialogService, IFileDialogService } from 'vs/platform/dialogs/common/dialogs'; </del> <ins> import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { getFileNamesMessage, IDialogService, IFileDialogService } from 'vs/platform/dialogs/common/dialogs'; </ins> import { IProductService } from 'vs/platform/product/common/productService'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { IEnvironmentService } from 'vs/platform/environment/common/environment';

Discussion:
Testing Continue from web inside desktop Let the window sit Install update (which restarts the App) you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code) Ideas don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus don't show this when my local changes are no different to those on the server <img width="1391" alt="Screenshot 2022-08-24 at 09 26 13" src="https://user-"
Is the custom modal overlay the same thing as the custom modal dialog, i.e. :+1: I filed for this.
Change:
CheckoutTracking: (refLabel: string) => ({ kind: OperationKind.CheckoutTracking, blocking: true, readOnly: false, remote: false, retry: false, showProgress: true, refLabel } as CheckoutTrackingOperation), Clean: (showProgress: boolean) => ({ kind: OperationKind.Clean, blocking: false, readOnly: false, remote: false, retry: false, showProgress } as CleanOperation), Commit: { kind: OperationKind.Commit, blocking: true, readOnly: false, remote: false, retry: false, showProgress: true } as CommitOperation, <del> Config: (readOnly: boolean) => ({ kind: OperationKind.Config, blocking: false, readOnly, remote: false, retry: false, showProgress: true } as ConfigOperation), </del> <ins> Config: (readOnly: boolean) => ({ kind: OperationKind.Config, blocking: false, readOnly, remote: false, retry: false, showProgress: false } as ConfigOperation), </ins> DeleteBranch: { kind: OperationKind.DeleteBranch, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as DeleteBranchOperation, DeleteRef: { kind: OperationKind.DeleteRef, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as DeleteRefOperation, DeleteRemoteTag: { kind: OperationKind.DeleteRemoteTag, blocking: false, readOnly: false, remote: true, retry: false, showProgress: true } as DeleteRemoteTagOperation,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0 (user setup) Commit: Date: 2024-07-01T18:52:22.949Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Steps to Reproduce: to to at the icon I'm not sure if it's a new feature or a bug, but it wasn't like that in previous version (1.90).
Thanks for reporting this issue. This will be fixed in tomorrow's VS Code Insiders release and the next VS Code Stable release.
Thank you for checking and fixing it.
Change:
); }); }) <del> : command(localize('acceptBoth', "$(pass) Accept Both"), async () => { </del> <ins> : command(localize('acceptBoth', "Accept Both"), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,

Discussion:
Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used—not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width="269" alt="CleanShot 2022-09-27 at 11 42 19 src="https://user-"<img width="244" alt="CleanShot 2022-09-27 at 11 43 33 src="https://user-"
I can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.
Why don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.
Change:
/** * Checks if this code action kind intersects `other`. * <del> * The kind `"refactor.extract"` for example intersects `refactor`, `"refactor.extract"` and ``"refactor.extract.function"`, </del> <ins> * The kind `"refactor.extract"` for example intersects `refactor`, `"refactor.extract"` and `"refactor.extract.function"`, </ins> * but not `"unicorn.refactor.extract"`, or `"refactor.extractAll"`. * * @param other Kind to check.

Discussion:
Testing I cloned the vscode-extension-samples repository and tried to return two edits instead of one. Only the first one appears to take effect. I am wondering if this is expected? I guess I was expecting both edits to be applied since it is possible to return an array from the method.
The thought occurred to me that the edits would appear in the paste widget, and I verified this was indeed the case. I guess, by reading the TS docs I didn't catch on that this would happen
Aside from the above comment, on reading the JS Docs, the following thoughts came to mind: For the class , I was looking at the method . Consider the following code: Do the kinds and intersect here? Or is the intersection evaluated per part, so that the above do not intersect but the below kinds do? I noticed the refers to file dropping in its JS Doc. I was wondering if this is intended? The JS Doc above the field says . The same line more-or-less can be found under .
This is expected. Each is one potential way of applying the paste. We only apply one at a time and the first one is auto applied , the kinds are scoped hierarchies of parts. When we talk about intersection, only the second example would return true. The first one would not as the two top level parts and are not the same. I'll add an example in the docs to make this more clear it applies but for pasting files. I'll change the word
Change:
const scope = OVERRIDE_PROPERTY_PATTERN.test(key) ? ConfigurationScope.RESOURCE : this._configurationScopes.get(key); const extensionIdText = extensionId ? `[${extensionId.value}] ` : ''; if (ConfigurationScope.RESOURCE === scope) { <del> if (overrides?.resource) { </del> <ins> if (typeof overrides?.resource === 'undefined') { </ins> this._logService.warn(`${extensionIdText}Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '${key}', provide the URI of a resource or 'null' for any resource.`); } return;

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --When developing an extension with vscode-insiders, the extension host prints many warnings like: The warnings are printed for the following extensions: The built-in extension The built-in extension (when opening a markdown file) The built-in extension (when opening a html file) The built-in extension (when opening a ts file and typing something) ! When developing an extension with vscode, no warnings are printed. ! <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: Ubuntu 19.10 Steps to Reproduce: an extension warnings are printed inside <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I believe these should be fixed now. Let me know if you notice any additional ones
Change:
test('Notebook Editor Event - onDidChangeVisibleNotebookEditors on open/close', async function () { const openedEditor = utils.asPromise(vscode.window.onDidChangeVisibleNotebookEditors); const resource = await utils.createRandomFile(undefined, undefined, '.nbdtest'); <del> await vscode.window.showNotebookDocument(resource); </del> <ins> const document = await vscode.workspace.openNotebookDocument(resource); await vscode.window.showNotebookDocument(document); </ins> assert.ok(await openedEditor); const firstEditorClose = utils.asPromise(vscode.window.onDidChangeVisibleNotebookEditors);

Discussion:
The has been finalized with VS Code 1.68 (). If your extension was using the proposal, you should now switch to the finalized version of this API. In the majority of cases, this switch is as simple as: your extension to target VS Code in the new from your list of enabled API proposal. However there are few small bumps to be aware of: has been renamed . Please make sure to switch over to the new property name as part of this migrationWe did not finalize the version of that takes a uri. Instead you can use Here's a list of all current consumers of the old API proposal: [x] ms-vsliveshare.vsliveshare — [X] ms- — [x] Dot net interactive — [x] GitHub.codespaces — [x] ms- — If you own one of these extensions, please migrate to the finalized notebook editor API. Let me know once the new version of your extension is published and I will remove your extension from the list of api consumers
I am actually fine in ESLint. The dependency was because of notebook support in LSP and LSP already converted to the final version for the 8.x release of the LSP libs.
Thank you everyone who's checked off their extension so far! If you have, I plan to remove your extension from the list of API consumers in July. This will only start effecting the insiders builds of VS Code at first, but please let me know if you notice any issues
I'm working on the change for Codespaces and expect it to be in our next extension release (1.10.0) in a few days. I'll reply back once it's on the marketplace.
We just published GitHub Codespaces 1.10.0 with this change, so you should be able to remove our extension from the list of proposed API consumers.
Change:
return true; } <del> private loadReleaseNotes(version: string): Promise<string> { </del> <ins> private async loadReleaseNotes(version: string): Promise<string> { </ins> const match = /^(d+.d+)./.exec(version); if (!match) { <del> return Promise.reject(new Error('not found')); </del> <ins> throw new Error('not found'); </ins> } const versionLabel = match[1].replace(/./g, '_');

Discussion:
Issue Type: <bBug</bIf you try to open the release notes while offline, then if a release notes url is configured then vscode will open it in a browser, otherwise it will do nothing, not even show an error. Later, if you go online and try opening the release notes again, the same will happen - vscode will never attempt to open the release notes webview again. This state is preserved until you reload the window. Steps to Reproduce: offline (you can also open devtools in vscode and go to the network tab and change the "online" at the top to "offline") to open the release notes using from the command palette. on whether you are on an official vscode build or a local build, the release notes page will be opened in your default browser. On a local build nothing happens. back online to open the release notes again same thing will happen the window using from the command palette to open the release notes again release notes open in a webview inside vscode VS Code version: Code - Insiders 1.47.0-insider (, 2020-06-26T06:20:06.931Z) OS version: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes