jiebi/CodeConvo huggingface dataset:
Change:
const index = model.findNextClosestChange(lineNumber, false); const change = model.changes[index].change; await playAudioCueForChange(change, audioCueService); <del> // The audio cue can take up to a second to load. Give it a chance to play before we read the line content await setTimeout(() => setPositionAndSelection(change, outerEditor, accessibilityService, codeEditorService), 500); </del> <ins> setPositionAndSelection(change, outerEditor, accessibilityService, codeEditorService); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 OS Version: Windows 10 Steps to Reproduce: a project in VSCode that's versioned by git. a change. , (<kbdAlt</kbd+<kbdF5</kbd). the time it takes to move your cursor to the next change. You should notice a significant delay in version 1.75 compared to version 1.74. I've only tested this in a single repository with ~30k LoC and a few hundred commits.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
is this something that falls under your area of ownership?
Can confirm. In 1.74 it was instant, whereas now it takes 1sec even in a new project of a single file. Affects Windows 10 and MacOS 12, so not OS-specific. More context: still reproduces in stable 1.75.0 without extensions () doesn't reproduce in 1.75.0-insider () reproduces in Version: 1.76.0-insider ()
I'm also seeing this perf regression with 1.75. Side observation: as noted, alt+f5 is slow in 1.75. However, alt+f3 (related functionality -- 'Show Next Change') still feels instant. (Not sure if this is relevant or helpful.)
For me both and is slow.

It doesn't matter which key combination I bind this command to. Repository size seems to have no (noticeable) effect. Disabling GitLens has no effect either.
I'm seeing this issue too, with both and . I noticed you assigned the label. It's worth noting that the comparable commands for the diff editor ( and ) do not seem to be exhibiting the same slowness, so this issue seems to only be happening in the editor, not the diff editor.
I only just noticed this myself after switching my keybindings because & stopped working since 1.76.0. It's frustrating having to open up the diff editor every time to see things quickly.
Change:
}, "$a <=> $b": { "prefix": "spaceship", <del> "body": "(${1:$$a} <=> ${2:$$b} === ${3|0,1,-1|})", </del> <ins> "body": "(${1:$a} <=> ${2:$b} === ${3|0,1,-1|})", </ins> "description": "Spaceship equality check" }, "attribute": {

Discussion:
Code-OSS dev tools this message
From , cc do you want to look at this?
I'm in the middle of moving otherwise I would. If it can wait until next weekend I don't mind
From
sorry about the late response. I just returned from moving and a wedding and can sort this out tomorrow if you are not already working on it?
Sure, I haven't looked closely, thanks
After reviewing I can say this is not from our changes. This is prehistoric to us and . For my changes I just did the same thing for continuity. Additionally using vscode I can not see these warnings in dev console or any of the output channels. So this may be specific to code-oss, could be wrong though. Either way, perhaps the solution is to correctly escape the prefixes in all instances where needed Since I don't use code-oss and can't reproduce in vscode I can't verify if that change sufficiently satisfies the code-oss warning
That's a different pattern, in those the second fixes it
Change:
registerEditorCommand(new SuggestCommand({ id: 'selectFirstSuggestion', <del> precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.MultipleSuggestions), </del> <ins> precondition: ContextKeyExpr.and(SuggestContext.Visible, ContextKeyExpr.or(SuggestContext.MultipleSuggestions, SuggestContext.HasFocusedSuggestion.negate())), </ins> handler: c => c.selectFirstSuggestion() }));

Discussion:
Type: <bBug</bOpen new document. Set . Type now start typing the editor will show suggestion (with only one in the list). Now pressing should select the available suggestion, but it can not be done. On the other hand if you type and then start typing the list will contain two items and selection works as expected - when you press the first item is selected and you can navigate the list with and VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
with the setting set to "never" is it expected that there is one selected by default? I didn't have to arrow down for this to happen !
Change:
"(", ")" ] <ins> ], "autoClosingPairs": [ [ "{", "}" ], [ "[", "]" ], [ "(", ")" ] </ins> ] }  No newline at end of file

Discussion:
VSCode Version:1.1.0-alpha OS Version: Windows 10 Steps to Reproduce: a markdown file and add a code block. a function, string, etc that has an opening bracket or string Regardless of the language specified for the code block, bracket completion is not supported.
Verified that this still does not work with the new markdown extension.
Fixed via
cool! would it not make more sense to push your changes directly to master given that we pushed vscode-markdown into VSCode?
I'll send out my PR real quick (I'd like to have the push privilege after my onboard).
Change:
import { ICellRange } from 'vs/workbench/contrib/notebook/common/notebookRange'; import { FontInfo } from 'vs/editor/common/config/fontInfo'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; <ins> import { registerNavigableContainer } from 'vs/workbench/browser/actions/widgetNavigationCommands'; </ins> export const COMMENTEDITOR_DECORATION_KEY = 'commenteditordecoration';

Discussion:
Testing a file in a PR that has comments focus to the comment widget input :bug: can't ctrl+up/ctrl+down to move focus to the comments within that thread
Author of here. I would like to solve this.
Change:
import { IListAccessibilityProvider } from 'vs/base/browser/ui/list/listWidget'; import { DomScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement'; import { AsyncDataTree } from 'vs/base/browser/ui/tree/asyncDataTree'; <del> import { IAsyncDataSource } from 'vs/base/browser/ui/tree/tree'; </del> <ins> import { IAsyncDataSource, ITreeContextMenuEvent } from 'vs/base/browser/ui/tree/tree'; </ins> import { coalesce } from 'vs/base/common/arrays'; import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation'; import { KeyCode } from 'vs/base/common/keyCodes';

Discussion:
This is the debug hover: ! I think it would be great if each value has a context menu (or inline buttons) to trigger (contributable) actions. Built-in actions could be: copy value copy expression watch Actions contributed by extensions could be: visualize This is already supported in the sidebar: !
good overall idea and I like it. I think we could implement it fairly easily by adding a new menu type to the hover tree. We can even open it for extensions as you suggested. However I would be interested in what other apps do you know that have a context menu on the hover? Might this be a sort of an anti pattern? I know that the debug hover is a bit heavy and a context menu might fit well there, but I would be interested in how other products do it. Maybe try out Visual Studio, Chrome Dev Tools and others... fyi
I do believe that's using the tree widget, which supports inline actions: <img width="334" alt="CleanShot 2021-06-08 at 10 46 42 src="https://user-"I'd assume either a (though there is quite a bit already in these views) or: <img width="652" alt="CleanShot 2021-06-08 at 10 48 01 src="https://user-"<img width="659" alt="CleanShot 2021-06-08 at 10 48 46 src="https://user-"
VS has quite a few nested context menus :D 
I think that would be possible since it's a toolbar, we do show more inline actions in peek/diff views: <img width="157" alt="CleanShot 2021-06-08 at 10 57 38 src="https://user-"
Cool ideas. Maybe just a right click context menu might work best. But an additional gear on the end to make it discoverable will help. Ellipsis look good in the example you provided but in practice we have a lost of overflowing text and it is all shown with ellipsis, so I think it would be very confusing, as some ellipsis would be clickable and some not... is right, it can be made possible if we make it a toolbar, however I would be worried about opening inline actions to extensions since horizontal space is already limited. I would first only open secondary actions - the one behind a context menu. Though I am flexible.
can you verify this one?
Change:
} }, "wordPattern": { <del> "pattern": "(-?d*.dw*)|([^`~!%^&*()-=+[{]}|;:'",.<>/?s]+)", </del> <ins> "pattern": "(-?d*.dw*)|([^`@~!%^&*()-=+[{]}|;:'",.<>/?s]+)", </ins> }, "indentationRules": { "decreaseIndentPattern": {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In Visual Studio, the symbol is considered a trigger character inside JSDocs, and so the appropriate completions are displayed without having to use ctrl + Space. ! It would be great if this was also offered by VS Code :)
Are trigger characters supposed to override the setting? We disable quick suggestions in comments by default
It seems like VS Code already has some smarts to know that things are a little different within a JSDoc tag's . How does that work?
We treat the parts inside of as being code again. This is done using some textmate grammar tricks (there's a special scope that tells VS Code to treat this part of the comment as code) This doesn't apply when you type though as it still looks like we're in a normal comment at that point
Yes, trigger characters are "stronger" than quick suggest and work independent of the setting. However, a trigger character that's also a word character is considered a quick suggest case (hand the setting will apply).
Quick update: If I set , then I get completions after typing inside JSDocs. This isn't great though because then I also get snippet completions (e.g. after typing a ). It would be great if JSDocs could be treated as special comments where just a subset of completions is valid (not sure if this involves changes from VS Code or TypeScript).
This is the current experience in Visual Studio BTW.
This works if I revert . Since this seems more important, I'll do that and reopen
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
this._setInactive(); if (send) { this._acceptTranscriptionScheduler!.cancel(); <del> this._terminalService.activeInstance?.sendText(this._input, false); </del> <ins> this._sendText(); </ins> } this._marker?.dispose(); this._ghostTextMarker?.dispose();

Discussion:
Sighted users see preview text as a voice recording occurs and they see the resultant output, which could be drastically different from what they might expect. To make this clear for SR users, after the recording has stopped, we should alert with the content that was inserted in at least the terminal. Unclear if this would also be desirable to do in the chat input boxes
Do you move over to using braille when using the speech functionality Otherwise, doesn't the mic pick up on what the screen reader is saying?

It seems that the mic icon requires at least one line above the prompt to show: ! It does not appear for me in the above case.
Thanks for the issue. Should be an easy fix and in this case the mic will have to go on the cursor line
Change:
ChatAgentLocation.Editor, { resource: true }, { <ins> defaultElementHeight: 32, </ins> editorOverflowWidgetsDomNode: _editor.getOverflowWidgetsDomNode(), renderStyle: 'compact', renderInputOnTop: true,

Discussion:
See how the padding is ~double that on top than on the side ! It looks particularly bad imo when a response is in progress: ! It's also ~half on bottom: ! Could we make the padding consistent on all sides?
Padding also looks pretty bad in terminal: !
When showing a result the chat widget height is off by 3px, e.g its reported content height is small then the height takes... <img width="1411" alt="Screenshot 2024-03-22 at 16 22 35" src=""
Should be looking better now <img width="1277" alt="Screenshot 2024-03-26 at 20 58 39" src=""
Much better Does it look wrong with this part gone too? !
Yeah, I had played with that and wasn't happy. The different radii (from the input and zone) get close enough to make it look weird. Also, the focus border makes it appear as too narrow
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'vscode' { export class TestMessage2 extends TestMessage { /** * The stack trace associated with the message or failure. */ stackTrace?: TestMessageStackFrame[]; } export class TestMessageStackFrame { /** * The location of this stack frame. This should be provided as a URI if the * location of the call frame can be accessed by the editor. */ uri?: Uri; /** * Position of the stack frame within the file. */ position?: Position; /** * The name of the stack frame, typically a method or function name. */ label: string; /** * @param label The name of the stack frame * @param file The file URI of the stack frame * @param position The position of the stack frame within the file */ constructor(label: string, uri?: Uri, position?: Position); } } </del>

Discussion:
Currently, messages that are shown when tests fail can only be shown at a single . Often (, , among others) folks want to see the full call stack of the test failure. I propose some API to add this information:
does this track that not only the stack but stack + any stdout would show in same UX? /cc
Yes, output is already trackable and associable to a test case via the API
We are using to record all stdout written by tests. In addition, the is used to record the failure message and stack for each test failure.
UI:
Just check with Joh and this looks good to move into finalized!
do we want to bundle this with any of the other testing proposals (, )?
Change:
markdownCellDragEnd(cellId: string, position: { clientY: number }): void { throw new Error('Method not implemented.'); } <ins> updateMarkdownPreviewSelectionState(cell: ICellViewModel, isSelected: boolean): Promise<void> { throw new Error('Method not implemented.'); } </ins> async beginComputeContributedKernels(): Promise<INotebookKernel[]> { return []; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --

Verifying in the vscode repo across some of the markdown headers ! If I put them into edit mode, then I see the background change on multiselect
I guess you don't see this issue when commenting out from the workspace setting?
Yeah, that's correct! I see everything get highlighted as expected when that setting is off
The root cause is that the for webview backed markdown cells has a height of zero. This element gets the correct background color during selection, but is not visible due to the height. We have zero height so that you can click through to the webview instead of to the cell I will prototype telling the cell in the webview if it is selected or not. Then we can add styling inside the webview to show selection state
Change:
{ transformOptimization: false, identityProvider, <ins> dnd, </ins> horizontalScrolling: false, setRowLineHeight: false, filter,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I frequently use the drag-and-drop feature from the Explorer view to open files into specific panes. It would be really nice if this functionality was supported in the Source Control panel as well. I imagine it working like: Drag from filename into pane opens diff in that pane Drag from file icon into pane opens original file in that pane with reversed behavior if .
Not sure if this belongs here, or would be better a new feature request: If I have already two panels open next to each other, opening the git diff in one panel is pretty small and no fun to read, e.g.: ! For me it would be nice, if the first two panels would be used for the diff In IntelliJ the diffs opens in a detached popup, which I can move around and resize individually. I also like this feature a lot
please open a new issue -- although note, that the behavior you describe is unlikely to change, as that is how tab management works in VS Code.
One additional use case: I just enabled drag and drop into the SCM input box. It would be nice if we could drag and drop files from the SCM panel into the box to insert this file path (this already works with files from the explorer)
Change:
throw new ExtensionManagementError(error.message, ExtensionManagementErrorCode.Download); } <del> let verificationStatus: ExtensionVerificationStatus = ExtensionVerificationStatus.Unverified; </del> <ins> let verificationStatus: ExtensionVerificationStatus = false; </ins> if (verifySignature && this.shouldVerifySignature(extension)) { const signatureArchiveLocation = await this.downloadSignatureArchive(extension); try { <del> const verified = await this.extensionSignatureVerificationService.verify(location.fsPath, signatureArchiveLocation.fsPath, this.logService.getLevel() === LogLevel.Trace); if (verified) { verificationStatus = ExtensionVerificationStatus.Verified; } this.logService.info(`Extension signature verification: ${extension.identifier.id}. Verification status: ${verificationStatus}.`); </del> <ins> verificationStatus = await this.extensionSignatureVerificationService.verify(location.fsPath, signatureArchiveLocation.fsPath, this.logService.getLevel() === LogLevel.Trace); </ins> } catch (error) { const sigError = error as ExtensionSignatureVerificationError; <del> const code: string = sigError.code; </del> <ins> verificationStatus = sigError.code; </ins> if (sigError.output) { this.logService.trace(`Extension signature verification details for ${extension.identifier.id} ${extension.version}:n${sigError.output}`); } <del> if (code === ExtensionSignaturetErrorCode.UnknownError) { verificationStatus = ExtensionVerificationStatus.UnknownError; this.logService.warn(`Extension signature verification: ${extension.identifier.id}. Verification status: ${verificationStatus}.`); } else if (code === ExtensionSignaturetErrorCode.PackageIsInvalidZip || code === ExtensionSignaturetErrorCode.SignatureArchiveIsInvalidZip) { </del> <ins> if (verificationStatus === ExtensionSignaturetErrorCode.PackageIsInvalidZip || verificationStatus === ExtensionSignaturetErrorCode.SignatureArchiveIsInvalidZip) { </ins> throw new ExtensionManagementError(CorruptZipMessage, ExtensionManagementErrorCode.CorruptZip); <del> } else if (!sigError.didExecute) { this.logService.warn(`Extension signature verification: ${extension.identifier.id}. Verification status: ${verificationStatus} (${code})`); } else { await this.delete(location); throw new ExtensionManagementError(code, ExtensionManagementErrorCode.Signature); </del> } } finally { try {

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log