jiebi/CodeConvo huggingface dataset:
Change:
@IHoverService hoverService: IHoverService, @IUriIdentityService private readonly uriIdentityService: IUriIdentityService, @IStorageService storageService: IStorageService, <del> @IPathService private readonly pathService: IPathService </del> <ins> @IPathService private readonly pathService: IPathService, </ins> ) { const stateMemento = new Memento(VIEW_STORAGE_ID, storageService); const viewState = stateMemento.getMemento(StorageScope.WORKSPACE, StorageTarget.MACHINE);

Discussion:
Type: <bFeature Request</bCC I appreciate the current implementation of Accessible View (alt+F2) in the Comment Thread. However, I would like to suggest a few improvements to make it more accessible for screen reader users. [Easy navigation]: by separating the comment from the line number, screen reader users can easily navigate the comment text. [Improved discoverability]: providing the corresponding content of the comment can help screen reader users to understand the context of the comment. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
and press alt+f2 was focused but blank a11y view is shown ! the comment content and press alt+f2 11y view shows with just the comment content ! Is the content of the a11y view supposed to match the request in the issue? Am I focusing on the wrong thing?
your focus needs to be on a comment for this to work.
Secondly, you need to have a selection of code associated with the comment to see that in the accessible view.
I notice I can focus on the comment in the Comments view and then press Alt+F2 to show the comment in the accessible view. However, it adds the word "undefined". I'm not sure whether that word comes from the line range or date. !
thanks , i'll make a new issue to track that bug
Change:
interface Response { readonly _serverType?: ServerType; } <del> //#region MapCode export interface MapCodeRequestArgs extends FileRequestArgs { /** * The files and changes to try and apply/map. */ mapping: MapCodeRequestDocumentMapping; } export interface MapCodeRequestDocumentMapping { /** * The specific code to map/insert/replace in the file. */ contents: string[]; /** * Areas of "focus" to inform the code mapper with. For example, cursor * location, current selection, viewport, etc. Nested arrays denote * priority: toplevel arrays are more important than inner arrays, and * inner array priorities are based on items within that array. Items * earlier in the arrays have higher priority. */ focusLocations?: TextSpan[][]; } export interface MapCodeRequest extends FileRequest { command: 'mapCode'; arguments: MapCodeRequestArgs; } export interface MapCodeResponse extends Response { body: FileCodeEdits[] } //#endregion //#region Paste export interface GetPasteEditsRequest extends Request { command: 'getPasteEdits'; arguments: GetPasteEditsRequestArgs; } export interface GetPasteEditsRequestArgs extends FileRequestArgs { /** The text that gets pasted in a file.  */ pastedText: string[]; /** Locations of where the `pastedText` gets added in a file. If the length of the `pastedText` and `pastedLocations` are not the same, *  then the `pastedText` is combined into one and added at all the `pastedLocations`. */ pasteLocations: TextSpan[]; /** The source location of each `pastedText`. If present, the length of `spans` must be equal to the length of `pastedText`. */ copiedFrom?: { file: string; spans: TextSpan[]; }; } export interface GetPasteEditsResponse extends Response { body: PasteEditsAction; } export interface PasteEditsAction { edits: FileCodeEdits[]; fixId?: {}; } //#endregion </del> } }

Discussion:
Tracks shipping TypeScript 5.5 as the bundled version of ts:
Picked up 5.5.2 To verify: Open a TS file In the language status item, confirm that TS 5.5.2 is used (make sure you are using VSCode's version of typescript, not the workspace version)
Change:
class MergeItem implements QuickPickItem { <del> get label(): string { return this.ref.name || ''; } get description(): string { return this.ref.name || ''; } </del> <ins> private shortCommit: string; </ins> <del> constructor(protected ref: Ref) { } </del> <ins> get label(): string { return this.ref.type === RefType.RemoteHead ? `$(cloud) ${this.ref.name ?? this.shortCommit}` : `${this.repository.isBranchProtected(this.ref) ? '$(lock)' : '$(git-branch)'} ${this.ref.name ?? this.shortCommit}`; } </ins> <del> async run(repository: Repository): Promise<void> { await repository.merge(this.ref.name! || this.ref.commit!); </del> <ins> get description(): string { return this.ref.type === RefType.RemoteHead ? l10n.t('Remote branch at {0}', this.shortCommit) : this.shortCommit; } constructor(private readonly repository: Repository, private readonly ref: Ref) { this.shortCommit = (this.ref.commit ?? '').substring(0, 8); } async run(): Promise<void> { await this.repository.merge(this.ref.name ?? this.ref.commit!); </ins> } }

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-29T02:35:06.500Z) OS version: Windows_NT x64 10.0. Modes:
I will prepare a PR. Ideas for what to put in description: Commit ID (short format) ! Nothing, which is what Rebase does for most of its entries (exception being the upstream entry): ! Last commit timestamp: !
Change:
location: string | undefined; }; 'set-confirm-before-close': string; <ins> 'set-context-menu-visible': { visible: boolean }; </ins> 'initial-scroll-position': number; 'content': UpdateContentEvent; 'set-title': string | undefined;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/a <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.77.3 Commit: Date: 2023-04-12T09:16:02.548Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.77.3 Chrome/102.0.5005.196 Electron/19.1.11 Safari/537.36 OS Version: Steps to Reproduce: click a file in the Explorer. The background color of the row changes from blue to grey. Esc to close the context menu. The background color changes back. is not possible to emulate with an extension using a webview context menu. Fixed by my PR
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I'll verify this.
<img width="320" alt="image" src=""<img width="334" alt="image" src=""I can confirm that on that there is a style change when right-clicking a file in the Explorer. But it's not the one described, the text colour changes slightly (this may be a theme difference). What's an extension that uses a file list in a web view that I can verify?

I think any webview context menu should work for this, not necessarily a file list.
They would need to add a CSS rule with the new class name to make an actual change in visual appearance. You can verify the class is applied on the body element using the Webview Developer Tools.
this could probably be edited
Here's a snippet from my project, the selector doesn't work while the context menu is up, so I repeat the same rules with
Oh, and the original issue was reported with the previous default theme.
Thanks
Change:
// Register search default location to sidebar Registry.as<IViewsRegistry>(ViewExtensions.ViewsRegistry).registerViews([viewDescriptor], viewContainer); <del> // Migrate search location setting to new model class RegisterSearchViewContribution implements IWorkbenchContribution { static readonly ID = 'workbench.contrib.registerSearchView'; constructor( @IConfigurationService configurationService: IConfigurationService, @IViewDescriptorService viewDescriptorService: IViewDescriptorService ) { const data = configurationService.inspect('search.location'); if (data.value === 'panel') { viewDescriptorService.moveViewToLocation(viewDescriptor, ViewContainerLocation.Panel, 'search.location'); } Registry.as<IConfigurationMigrationRegistry>(Extensions.ConfigurationMigration) .registerConfigurationMigrations([{ key: 'search.location', migrateFn: (value: any) => ({ value: undefined }) }]); } } registerWorkbenchContribution2(RegisterSearchViewContribution.ID, RegisterSearchViewContribution, WorkbenchPhase.BlockStartup); </del> // Register Quick Access Handler const quickAccessRegistry = Registry.as<IQuickAccessRegistry>(QuickAccessExtensions.Quickaccess);

Discussion:
I came across this: Can we by now remove it? Seems quite old:
Yes, this can be removed!
Change:
async function assertLimit(maxEntries: number, expectedRanges: IndentRange[], message: string) { let reported: number | false = false; const foldingRangesLimit: FoldingLimitReporter = { limit: maxEntries, report: r => reported = r.limited }; <del> const indentRanges = await new SyntaxRangeProvider(model, providers, () => { }, foldingRangesLimit).compute(CancellationToken.None); </del> <ins> const indentRanges = await new SyntaxRangeProvider(model, providers, () => { }, foldingRangesLimit, undefined).compute(CancellationToken.None); </ins> const actual: IndentRange[] = []; if (indentRanges) { for (let i = 0; i < indentRanges.length; i++) {

Discussion:
a folding range provider that conditionally contributes ranges or undefined and ensure no other is contributing any ranges. a file for which the custom will return undefined so that the default folding regions are shown. another file for which the custom does return ranges. -open the first file :bug: folding regions are not shown !
Change:
*--------------------------------------------------------------------------------------------*/ import { Codicon } from 'vs/base/common/codicons'; <ins> import { basename } from 'vs/base/common/resources'; </ins> import { URI, UriComponents } from 'vs/base/common/uri'; import { localize } from 'vs/nls'; import { ILocalizedString } from 'vs/platform/action/common/action';

Discussion:
<img width="364" alt="image" src="https://user-"I think this dialog could get some UX love. If we want to keep the very long primary button label, I would use title casing to be consistent with other dialog buttons. But I also think just having "Accept Merge" is fine, given the message in the dialog points out about the conflicts. //cc
Now that I see this dialog: <img width="291" alt="image" src="https://user-"I think we can align both How about: "Accept with Conflicts" using in the dialog "The file contains unhandled conflicts"
PR:
Change:
const isPanelChat = typeof response !== 'string'; this._responsePendingAudioCue?.dispose(); this._runOnceScheduler?.cancel(); <del> if (this._lastResponse === response?.toString()) { </del> <ins> const responseContent = typeof response === 'string' ? response : response?.response.value; if (this._lastResponse === responseContent) { </ins> return; } <del> this._lastResponse = response?.toString(); </del> this._audioCueService.playAudioCue(AudioCue.chatResponseReceived, true); this._hasReceivedRequest = false; if (!response) { return; } const errorDetails = isPanelChat && response.errorDetails ? ` ${response.errorDetails.message}` : ''; <del> const content = isPanelChat ? response.response.value : response; status(content + errorDetails); </del> <ins> this._lastResponse = responseContent; status(responseContent + errorDetails); </ins> } }

Discussion:
Testing Type a request, press enter Nothing from the response is ever read I think it's supposed to do this?
Are you in screen reader optimized mode?
also any errors in dev tools console?
I can reproduce now not sure what changed
here's the problem
cc and this is the error you were encountering. should be fixed in insider's tomorrow
regression caused by the fix for
Change:
}; } async function main(arch = process.arch) { <del> const version = product.electronRepository ? '22.4.4' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '22.4.5' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

Discussion:
The Angular language service extension spawns a child process using and listens for the and events. The current version works as expected. Without any changes to the project, simply updating to results in the forked child process acting differently (never erroring and never closing). I'm using Mac 13.3.1 but we also had a report that the forked process isn't working in WindowsNT x64 10.0. either. There was a similar issue (though not entirely the same) a while back: Apologies for the rather involved reproduction... Here's how I'm able to reproduce and compare the behavior between the versions: our the repository with vscode insider version 1.78.0-insiders out the branch (we're actually removing this in the next version so it doesn't exist on ) dependencies with debugging, put a debugger statement before and one in the . The project is built with bazel so breakpoints would have to be put in the compiled JS files. the build script with the extension development host (Dev Client + Server run configuration) In the extension host, open the and then open the template file -- debugger should stop on the fork and if you continue, you will see that the debugger stops in the stderr data listener but never in the or . The output of the stderr also indicates that it is listening for a debugger and that it gets attached. The fork used which should have prevented this. The process also never produces any results or completes. You can have the fork retry by running the Angular: Restart Angular Language server command in the extension host. I've also verified that the spawn args are the same between versions and both include "--ms-enable-electron-run-as-node".
Issue was caused by the allocator changes to processes which now schedule delayed tasks to purge memory cache ;l=1183 and that revealed a bug in the causing the process to hang.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import { debounce } from 'vs/base/common/decorators'; import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; <del> import { compareFileNames } from 'vs/base/common/comparers'; </del> <ins> import { compareFileNames, comparePaths } from 'vs/base/common/comparers'; </ins> import { basename } from 'vs/base/common/resources'; import { binarySearch } from 'vs/base/common/arrays';

Discussion:
Issue Type: <bBug</bWith the recent update 1.66, where the release note mentions that repositories are listed in alphabetical order in source control tab. But, this created another bug where if we have 2 repros with same name under a folder, one of them will miss in the list. Steps to reproduce: 1) Create root folder and project1 and project2 as sub folder under it 2) Create a git repo name with 'test' under each project1/2 3) Now add root folder to the project explorer. And you will notice only one test git repo listed under source control tab VS Code version: Code 1.66.0 (, 2022-03-30T05:50:14.623Z) OS version: Windows_NT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-90-generic <!-- generated by issue reporter --
/assign
I've already pointed one duplicate to this. I think a fix needs to be considered for recovery.
yeah, I am currently looking at this and I will make sure that it is in the next recovery release.
The fix for this has been checked into main and it will be fixed in tomorrow's Insiders release. I am also porting this fix to to the release branch and it will be part of the next recovery release.
Change:
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils'; import { request } from 'vs/base/parts/request/browser/request'; import { streamToBuffer } from 'vs/base/common/buffer'; <ins> import { flakySuite } from 'vs/base/test/common/testUtils'; </ins> <del> suite('Request', () => { </del> <ins> flakySuite('Request', () => { </ins> let port: number; let server: http.Server;

Discussion:
We lost changes that where ESM relevant. I am trying to fix it in our ESM branch, maybe backport it from there: The old code also had this line, which I am not sure is needed: cc
Sorry about that. Is this for Monaco or the esm work? I'd love to get a point where we can just have this as a normal dependency instead of copying it into our sources. Marked now publishes both a commonjs and esm builds too. Is there some way VS Code could use Marked as a normal dependency in a way that would also work for Monaco? If I recall we've tried to avoid adding real dependencies to Monaco
I only noticed for our work, not sure about Monaco ESM. Would be great to get it working again on .
I think the ESM work will unblock this. esbuild will be able to bring in and include node modules into our bundle, the AMD bundler we currently use can only bundle AMD modules and not commonjs modules.
I would have hoped that the Monaco Editor checks would have caught this. Is there something we should improve there?
For monaco-editor-core, these are the only tests: It does not test markdown features.
Change:
}); } <ins> // 1.txt=>2.txt let prefixFileNoNameRegex = RegExp('(d+)(..*)$'); if (!isFolder && name.match(prefixFileNoNameRegex)) { return name.replace(prefixFileNoNameRegex, (match, g1?, g2?) => { let number = parseInt(g1); return number < maxNumber ? strings.pad(number + 1, g1.length) + g2 : strings.format('{0}.1{1}', g1, g2); }); } </ins> // file.txt=>file.1.txt const lastIndexOfDot = name.lastIndexOf('.'); if (!isFolder && lastIndexOfDot >= 0) {

Discussion:
Extending Have 1.txt Copy/paste it in the file explorer Get
fyi
I’ll fix it.
Change:
import * as colorRegistry from 'vs/platform/theme/common/colorRegistry'; import { registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; <del> import { EditorInput, EditorOptions, Extensions as EditorInputExtensions, GroupIdentifier, IEditorInput, IEditorInputFactoryRegistry, IEditorPane } from 'vs/workbench/common/editor'; </del> <ins> import { EditorInput, EditorOptions, Extensions as EditorInputExtensions, GroupIdentifier, IEditorInput, IEditorInputFactoryRegistry, IEditorPane, SaveReason } from 'vs/workbench/common/editor'; </ins> import { DiffEditorInput } from 'vs/workbench/common/editor/diffEditorInput'; import { CONTEXT_CUSTOM_EDITORS, CONTEXT_FOCUSED_CUSTOM_EDITOR_IS_EDITABLE, CustomEditorCapabilities, CustomEditorInfo, CustomEditorInfoCollection, CustomEditorPriority, ICustomEditorService } from 'vs/workbench/contrib/customEditor/common/customEditor'; import { CustomEditorModelManager } from 'vs/workbench/contrib/customEditor/common/customEditorModelManager';

Discussion:
Testing new untitled file and add some text. Editor: Open File The original untitled file is left open and changes in the Hex Editor are not reflected in that original file. !
This will be fixed by
Change:
.extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry { font-size: 90%; <del> display: flex; } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry :first-child { width: 40%; } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry :last-child { width: 60%; </del> <ins> display: grid; grid-template-columns: 40% 60%; gap: 4px; </ins> } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry code {

Discussion:
Type: <bBug</b! padding (see "Last released" running directly onto the date. hanging indent (see "Last", "updated" and "Identifier" all with same left start position) VS Code version: Code - Insiders 1.73.0-insider (, 2022-11-01T15:30:14.729Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Reopening as I have a PR for the first issue at least
Issue closed
Rendered like table with bg color for alternate colors !
! ! ! When the insiders comes out is there a particular theme to test this with. I don't see this even without the fix.
I see the fix. Before: <img width="147" alt="image" src=""After: <img width="138" alt="image" src=""
Change:
return value.content; } } catch (parseError) { <ins> // We may not be able to parse it, but we keep the secret in the keychain anyway just in case // it decrypts correctly in the future. </ins> this.logService.error(parseError); <del> // If we can't parse the decrypted value, then it's not a valid secret so we should try to delete it try { await this.credentialsService.deletePassword(fullKey, key); } catch (e) { this.logService.error(e); } </del> throw new Error('Unable to parse decrypted password'); } }

Discussion:
Yesterday I ran VS Code Insiders from the Downloads folder, and I used . And today, after updating to latest Insiders I had to log in again. Here's what I noticed in one of the logs: I often also use which downloads various versions of VS Code Insiders and uses a custom user data dir. Often I end up being signed out . cc
I have seen this error before and I had a time when I had to log in all the time, but not for a while anymore.
Now again I hit this almost daily that I have to re-login.
After 1on1, learned that this is caused simply by launching VS Code from a different path. A suggested fix is to not destroy existing credentials on startup when we fail to decrypt but only do so when we actually need to write new credentials to the store.
What are some verif steps? I'm a little confused on what you mean by "launching VS Code from a different path".
verification: Launch VS Code insiders, make sure you're logged in to something Close VS Code Insiders Open a terminal (not in VS Code Insiders) and run (This will spin up old insiders builds): Note that you are not logged in to anything (expected) in the terminal say or doesn't matter Now once is done open your VS Code Insiders You should still be logged in to your stuff
Change:
"version": "2.0.0", "tasks": [ { <del> "label": "npm", "command": "npm", "args": ["run", "compile"], </del> <ins> "label": "yarn", "command": "yarn", "args": ["compile"], </ins> "type": "shell", "presentation": { "reveal": "silent",

Discussion:
Issue Type: <bBug</bClone VS Code repo Follow the instructions for linking vscode-html-language-service will fail, as the project/extension has since moved to yarn. works fine. VS Code version: Code 1.62.0 (, 2021-11-03T15:23:01.379Z) OS version: Windows_NT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 4.19.128-microsoft-standard <!-- generated by issue reporter --