jiebi/CodeConvo huggingface dataset:
Change:
height: verticalRange.length - this._outerEditorHeight, }); }); <del> this.editor.getOriginalEditor().setScrollTop(editorScroll); </del> <ins> try { this._isSettingScrollTop = true; this._lastScrollTop = editorScroll; this.editor.getOriginalEditor().setScrollTop(editorScroll); } finally { this._isSettingScrollTop = false; } </ins> this._elements.header.classList.toggle('shadow', delta > 0 || editorScroll > 0); this._elements.header.classList.toggle('collapsed', delta === maxDelta);

Discussion:
Multi diff editor issue while expanding the hidden lines VS Code Version: 1.86 insider OS Version: Windows 11 //cc Steps to Reproduce: the multi diff editor on the hidden lines at the bottom ( the blue line) now it will expand the 10 lines now scrolling top doesn't show me the '5 hidden lines' text until I scroll down and then scroll up again
Change:
this.previousHiddenAreas = mergedRanges; <ins> const stableViewport = this._captureStableViewport(); </ins> let lineMappingChanged = false; try { const eventsCollector = this._eventDispatcher.beginEmitViewEvents();

Discussion:
use autofolding of imports . use a type that is not imported in a TS file use quick fix to add the import the editor scrolls to an incorrect position. I think this is a recent regression, because I've been using both import folding and quick fix for imports since quite a while... maybe starting with the last stable. https://user- Version: 1.72.0-insider Commit: Date: 2022-09-21T05:40:07.654Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Un-assigning myself as I don't think this cause by something the JS/TS extension itself is doing
who owns the quick fix UI now?
I own the UI. However it looks like scrolling here happen when the edit from the quick fix is applied. That's why I unassigned myself
It also unfolds if you do "Organize Imports", so seems like any action related with imports unfolds even though setting is
The root cause appears to be the folding ranges change and end up calling . That one does not attempt to maintain the viewport stable in any way.
this issue still exists:
Change:
private expandedSize: number | undefined = undefined; private _headerVisible = true; <ins> private _bodyRendered = false; </ins> private _minimumBodySize: number; private _maximumBodySize: number; private _ariaHeaderLabel: string;

Discussion:
Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible
would you be willing to verify for completeness?
Works great!
Change:
return extHostTerminalService.getDefaultShell(false); }, get isTelemetryEnabled() { <del> return extHostTelemetry.getTelemetryEnabled(); </del> <ins> return extHostTelemetry.getTelemetryConfiguration(); </ins> }, get onDidChangeTelemetryEnabled(): Event<boolean> { return extHostTelemetry.onDidChangeTelemetryEnabled; }, <ins> get telemetryConfiguration(): vscode.TelemetryConfiguration { checkProposedApiEnabled(extension, 'telemetry'); return extHostTelemetry.getTelemetryDetails(); }, get onDidChangeTelemetryConfiguration(): Event<vscode.TelemetryConfiguration> { checkProposedApiEnabled(extension, 'telemetry'); return extHostTelemetry.onDidChangeTelemetryConfiguration; }, </ins> get isNewAppInstall() { const installAge = Date.now() - new Date(initData.telemetryInfo.firstSessionDate).getTime(); return isNaN(installAge) ? false : installAge < 1000 * 60 * 60 * 24; // install age is less than a day

Discussion:
The current API does not expose the same level of internal granularity as the user setting allows. This proposal is to expose the telemetry levels. The current and can still be used a simpler API and this one can be considered more advanced and granular. Extension authors cannot just observe the user setting as this will lead to doing the wrong thing.
Another possibility is that we could collect an array of acceptable levels if we're worried about the possibility that the levels will not continue to be progressive but a permissions system instead. I.e. collecting errors and crashes would have be an array . None wouldn't really make sense in this context and would probably go away in favor of an empty array.
This is implemented but will remain in the proposed state for awhile for testing
Closing in favor of
Change:
.monaco-workbench .monaco-list-row .expression .lazy-button { margin-left: 3px; <ins> display: none; border-radius: 5px; align-self: center; } .monaco-workbench .monaco-list-row .expression.lazy .lazy-button { display: inline; </ins> } /* Links */

Discussion:
The new lazy variable evaluation button line-height or dimensions appear to be too large. The button creates frequent gaps in-between node items and creates unsightly misalignment. This is not a settings font issue because the issue appeared with the change to the lazy evaluation button in version 1.67.1. This new button does not improve JavaScript debugging. The ellipsis button did not do this. Version: 1.67.1 (user setup) Commit: Date: 2022-05-06T12:37:03.389Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: JavaScript object to console window the gaps between expandable nodes any collapsed variable to evaluate. The item will jump and become misaligned. !
Hey is there a reason that the variables view tree is 22px tall while the hover variables rows are 18px tall? I just noticed this.
I think the idea is to make the debugHover tree smaller, while the other trees in views should be larger. The problem here seems to be that the debugHover reuses the and by that the height of the hover items is 22. So the height should be configurable, and debugHover should be able to say to the variableDelagate that the height is 18 in this case.
The variables tree in the debug hover is correctly sized. It's just a CSS issue on that one button. I guess it's intentional, and that's fine, so I'll just fix the css.
okey. Thanks for fixing
This broke the alignment of the lazy button in the debug console because the text wraps there
Change:
// Map matches back to offsets with octicons and trimming if (matches) { for (let i = 0; i < matches.length; i++) { <del> const octiconOffset = octiconOffsets[matches[i].start] /* octicon offsets at index */ + leadingWhitespaceOffset /* overall leading whitespace offset */; </del> <ins> const octiconOffset = octiconOffsets[matches[i].start + leadingWhitespaceOffset] /* octicon offsets at index */ + leadingWhitespaceOffset /* overall leading whitespace offset */; </ins> matches[i].start += octiconOffset; matches[i].end += octiconOffset; }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.2(lang:ja), 1.28(insider, lang:en) OS Version: Windows, Mac Steps to Reproduce: this code in extension ! ! Result: The display of octicon will be broken and the wrong place will be selected and displayed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No( this problem is at api for extensions )
I have encountered this problem with .
I am quite sure I fixed this a while back for normal quick open, maybe it is a regression from the new quick input widget?
My change was:
Change:
mouseStyle?: 'text' | 'default' | 'copy'; /** * Enable smooth caret animation. <del> * Defaults to false. </del> <ins> * Defaults to 'off'. </ins> */ <del> cursorSmoothCaretAnimation?: boolean; </del> <ins> cursorSmoothCaretAnimation?: 'off' | 'explicit' | 'on'; </ins> /** * Control the cursor style, either 'block' or 'line'. * Defaults to 'line'.

Discussion:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting.

See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.
Change:
id: 'editor.action.formatSelection', label: nls.localize('formatSelection.label', "Format Selection"), alias: 'Format Code', <del> precondition: ContextKeyExpr.and(EditorContextKeys.writable, EditorContextKeys.hasNonEmptySelection), </del> <ins> precondition: ContextKeyExpr.and(EditorContextKeys.writable), </ins> kbOpts: { kbExpr: EditorContextKeys.editorTextFocus, primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyMod.CtrlCmd | KeyCode.KEY_F),

Discussion:
VSCode Version: 1.7.1 OS Version: 10.12.1 Steps to Reproduce: cursor on a line without selecting a range Format Selection with keyboard shortcut It would be nice if the current line is formatted instead of having to select the whole current line first.
I like the feature (format line) but I am not so sure if this should be automagic or explicit.
Change:
/* flex-direction: column; flex: 0 1 auto; */ width: 100%; <del> border-style: solid; border-width: 1px; border-color: var(--vscode-editorSuggestWidget-border); background-color: var(--vscode-editorSuggestWidget-background); </del> <ins> border-width: 0px; border-color: none; background-color: var(--vscode-menu-background); color: var(--vscode-menu-foreground); </ins> } .codeActionMenuWidget .monaco-list:not(.element-focused):focus:before {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Type: Bug Using editor.experimental.useCustomCodeActionMenu, the menu doesn't match up with the colors of enabled/disabled options or the background of the other context menus

Type: <bBug</bmenu the window Bug The widget ends up being incorrectly positioned: <img width="672" alt="Screen Shot 2022-07-21 at 1 24 17 PM" src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-21T05:17:20.056Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
private readonly _progressiveEditingDecorations: IEditorDecorationsCollection; override acceptHunk: () => Promise<void> = () => super.acceptHunk(); override discardHunk: () => Promise<void> = () => super.discardHunk();

Discussion:
open inline chat have it make multiple hunks (hint: ask it to use a util that needs to be imported) there is no gesture to visit all hunks except for accepting/discarding them... This can also help with accessibility when using the move
To verify let inline chat make multiple changes, e.g ask it to import a util or let is change the label of two actions make sure the inline chat status says "N changes" (n=2) select and to navigate between the changes
Change:
__vsc_restore_exit_code "${__vsc_status}" # Evaluate the original PROMPT_COMMAND similarly to how bash would normally # See https://unix.stackexchange.com/a/672843 for technique <ins> local cmd </ins> for cmd in "${__vsc_original_prompt_command[@]}"; do eval "${cmd:-}" done

Discussion:
Type: <bBug</bSteps to reproduce: a non-empty PROMPTCOMMAND string or array in a new terminal in vs-code , observe that this variable has a value Details: On l. 278 of , a loop is run as , but has not been declared local to the function. As a result, the shell environment retains the variable containing the last element of the original PROMPTCOMMAND array. Fix: Line 278 could be prepended with a declaration so that the variable doesn't leak out of the function scope. VS Code version: Code 1.86.1 (, 2024-02-07T09:07:19.849Z) OS version: Linux x64 6.1.60--g03a802b9a072 Modes: Unsupported <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ increment-selection0.2.0 Bookmarks13.4.2 insert-unicode0.15.1 systemd-unit-file1.0.6 markdown-table-prettify3.6.0 vscode-edit-csv0.8.3 markdown-shortcuts0.12.0 debugpy2024.0.0 isort2023.10.1 python2024.0.1 vscode-pylance2024.2.1 jupyter2024.1.1 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 adwaita-theme1.1.0 regex-text-gen0.14.0 snippets-ranger1.8.0 edit-with-shell1.3.0 markdown-preview-enhanced0.8.11 rewrap1.16.3 system-viewer1.1.1 pdf1.2.2 change-case1.0.0 markdown-all-in-one3.6.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
verified that is not defined here !
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm@4.19.0-beta.52: version "4.19.0-beta.52" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.52.tgz#21c7ad0bd905f3fddaa0583951514c8271dcd822" integrity sha512-2itY6dyiimOEkgVwc31TngYQ6npHt7or1wxU0Flbv4PjH4ke8K26NDB7KAi0YYkn2g0/qzIjQc7ykdrrTaEgMg== </del> <ins> xterm@4.19.0-beta.53: version "4.19.0-beta.53" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.53.tgz#ddb555e032d5ff3a1450d9c4b0250bc3e3ccac99" integrity sha512-WoJAux1FawCpgDBP9Gr5H+RQUY8H7djr+ZQTpD+D2A3nJTXmoHH5Q1lnu8XCsuPscjRAgqFSQCG+5oHQwBQIdA== </ins>

Discussion:
Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification
Change:
*--------------------------------------------------------------------------------------------*/ import { CompareResult } from 'vs/base/common/arrays'; <ins> import { BugIndicatingError } from 'vs/base/common/errors'; </ins> import { autorun, derived } from 'vs/base/common/observable'; import { IModelDeltaDecoration, MinimapPosition, OverviewRulerLane } from 'vs/editor/common/model'; import { localize } from 'vs/nls';

Discussion:
Note the shadow clipping on the left: <img width="256" alt="CleanShot 2022-07-25 at 09 57 06 src="https://user-"
Change:
servers.push(this.extensionManagementServerService.localExtensionManagementServer); } } <del> await this.checkForWorkspaceTrust(manifest); </del> <ins> if (!installOptions.context?.[EXTENSION_INSTALL_SYNC_CONTEXT]) { await this.checkForWorkspaceTrust(manifest); } </ins> if (!installOptions.donotIncludePackAndDependencies) { await this.checkInstallingExtensionOnWeb(gallery, manifest); }

Discussion:
an extension that requires workspace trust to be installed/enabled synced to settings sync on settings sync from a new VS Code instance that doesn't have that extension installed/enabled already :bug: get this modal dialog that doesn't specify which extension requires workspace trust to be installed/enabled (I do not know which extension causes this to repro because the dialog doesn't say) !
since the install is not triggered explicitly by the user, the dialog does not make sense. Do you need anything from the workspace trust side to avoid this dialog, or vice versa, do you provide something to let us know that this is from settings sync?
I assume this is happening on the web client, because in Desktop Settings Sync install extensions on the shared process.
Change:
}); }); <ins> test('collapseDeepestExpandedLevel', (done) => { model.setInput(SAMPLE.DEEP2).done(() => { model.expand(SAMPLE.DEEP2.children[0]).done(() => { model.expand(SAMPLE.DEEP2.children[0].children[0]).done(() => { assert(model.isExpanded(SAMPLE.DEEP2.children[0])); assert(model.isExpanded(SAMPLE.DEEP2.children[0].children[0])); model.collapseDeepestExpandedLevel().done(() => { assert(model.isExpanded(SAMPLE.DEEP2.children[0])); assert(!model.isExpanded(SAMPLE.DEEP2.children[0].children[0])); done(); }); }); }); }); }); </ins> test('auto expand single child folders', (done) => { model.setInput(SAMPLE.DEEP).done(() => { model.expand(SAMPLE.DEEP.children[0]).done(() => {

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
import {IEditorStacksModel, IStacksModelChangeEvent, IEditorGroup} from 'vs/workbench/common/editor'; import {SaveAllAction} from 'vs/workbench/parts/files/browser/fileActions'; import {AdaptiveCollapsibleViewletView} from 'vs/workbench/browser/viewlet'; <del> import {ITextFileService, IFilesConfiguration, VIEWLET_ID, AutoSaveMode} from 'vs/workbench/parts/files/common/files'; </del> <ins> import {ITextFileService, IFilesConfiguration, VIEWLET_ID, AutoSaveMode, EventType as FileEventType} from 'vs/workbench/parts/files/common/files'; </ins> import {IViewletService} from 'vs/workbench/services/viewlet/common/viewletService'; import {Renderer, DataSource, Controller, AccessibilityProvider,  ActionProvider, OpenEditor, DragAndDrop} from 'vs/workbench/parts/files/browser/views/openEditorsViewer'; import {IUntitledEditorService} from 'vs/workbench/services/untitled/common/untitledEditorService'; import {CloseAllEditorsAction} from 'vs/workbench/browser/parts/editor/editorActions'; <ins> import {IEventService} from 'vs/platform/event/common/event'; </ins> const $ = dom.emmet;

Discussion:
VSCode Version: 1.4 OS Version: Windows 10 Steps to Reproduce: a file a symbol that is used in other files Other files that referenced it are opened and show as dirty in tabs, the file list and the count on the explorer badge, but it still says "1 unsaved" next to the "open editors" heading. !
can you look into this?
Hi guys, submitted a PR for this issue. Please let me know if there are any issues.
I think any unread indicator needs to react to events from the text file service and not the stacks model to find out that something got dirty. You might want to revisit this in
Thanks!
Change:
return ''; } if (renderedPart.type === 'statusBar') { <del> return localize('hoverAccessibilityStatusBar', "This is a hover status bar."); </del> <ins> const statusBarDescription = [localize('hoverAccessibilityStatusBar', "This is a hover status bar.")]; for (const action of renderedPart.actions) { const keybinding = action.actionKeybindingLabel; if (keybinding) { statusBarDescription.push(localize('hoverAccessibilityStatusBarActionWithKeybinding', "It has an action with label {0} and keybinding {1}.", action.actionLabel, keybinding)); } else { statusBarDescription.push(localize('hoverAccessibilityStatusBarActionWithoutKeybinding', "It has an action with label {0}.", action.actionLabel)); } } return statusBarDescription.join('n'); </ins> } return renderedPart.participant.getAccessibleContent(renderedPart.hoverPart); }

Discussion:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!