jiebi/CodeConvo huggingface dataset:
Change:
} } // Hover on the left is going beyond window. <del> if (target.left - this._hover.containerDomNode.clientWidth <= this._targetDocumentElement.clientLeft) { </del> <ins> if (target.left - this._hover.containerDomNode.clientWidth - hoverPointerOffset <= this._targetDocumentElement.clientLeft) { </ins> this._hoverPosition = HoverPosition.RIGHT; } }

Discussion:
a project with some kind of debugging and make sure the Breakpoints view is near the bottom of the screen over the pencil icon on the second-to-bottom list item. It works over the bottom list icon. The tooltip seems to appear and disappear very quickly causing the mouse to flicker (the FPS on the gif doesn't capture it very well but you can see that it doesn't render correctly) !
cc , this might have always been a bug but is probably now more exposed given its a custom hover now.
I haven't made any changes to the computation of where the hover should be placed in relation to the target, so a bug that we have had for a while, but should definitely look into. After testing a bit it seems to me that this only happens for ().
This also definitely used to work on language features and recently regressed (works fine in 1.87 stable): ! Reported the styling problem in
Change:
enum ApiThemeClassName { light = 'vscode-light', dark = 'vscode-dark', <del> highContrast = 'vscode-high-contrast' </del> <ins> highContrast = 'vscode-high-contrast', highContrastLight = 'vscode-high-contrast-light', </ins> } namespace ApiThemeClassName {

Discussion:
As discussed in , we should let webviews make decisions based on the high contrast theme type. Proposed by cc
How should this be verified?
I think this can be verified by checking the style of the body in a webview? Here's one in stable with high-contrast light theme enabled: ! Here's the same one in insiders with same theme enabled: ! It would allow CSS rules based on the body having that class.
So something like so?
/verified Yeah that works for me. I used the webview-view-sample.
Yeah, in the webview ui toolkit so, hopefully, the vscode-high-contrast-light theme would be reflected there as well.
Which actually now that I look at screenshots more closely, it already is being reflected on the attribute
Also confirmed this works when working on a fix for the webview toolkit last week
Change:
if (this._isDisposed) { return; } <ins> if (typeof cols !== 'number' || typeof rows !== 'number' || isNaN(cols) || isNaN(rows)) { return; } </ins> // Ensure that cols and rows are always >= 1, this prevents a native // exception in winpty. if (this._ptyProcess) {

Discussion:
Version: 1.34.0 (user setup) Commit: Date: 2019-05-15T21:59:37.030Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0. Steps to Reproduce: there is no terminal opened, quickly press ctrl+` twice pop up(maybe at the back of the vs code window). Whatever which button I choose, vs code window would tell me there was a crash and need to restart window ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Does this happen consistently for you? I can't reproduce it. This check is meant to prevent this exception from occurring: Unless the process crashes or something?
Yes It crashes every time on my computer. Maybe you didn't press keyboard quick enough? XD I looks like terminal cannot initialize if the intergrated terminal is not visible. I think I can send a screen record later
I had failed to record a meaningful capture.... Just simply press the keyboard as quick as possible
Video of making it crash with extensions enabled or disabled: Logs from these sessions:
I can confirm this is with user setup version only on my machine. I installed the system installer and removed the user setup. I cannot duplicate this issue anymore.
thanks for the video
could you enable trace logging (F1 "log level" "trace"), then repro the issue again and check the logs if there is a entry at the end? These will be located in your user data directory, something like this: You might also be able to see the log if you open dev tools (via help menu) and open the console there, which would be easier if it gets there before the crash happens.
Related
Did the trace and find this entry and the end of the
perfect! You found the bug
Can add an extra defensive check in too
I can't reproduce the original issue using 1.34 user install so I'm not sure how to verify. Any repro/verification steps?
Verify via code review, I could not reproduce the issue either.
Change:
} async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> const idx = context.notebookEditor.getCellIndex(context.cell); if (typeof idx !== 'number') { return;

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem
Change:
this._proxy.$acceptStackFrameFocus(dto); } })); <ins> this.sendBreakpointsAndListen(); } private sendBreakpointsAndListen(): void { // set up a handler to send more this._toDispose.add(this.debugService.getModel().onDidChangeBreakpoints(e => { // Ignore session only breakpoint events since they should only reflect in the UI if (e && !e.sessionOnly) { const delta: IBreakpointsDeltaDto = {}; if (e.added) { delta.added = this.convertToDto(e.added); } if (e.removed) { delta.removed = e.removed.map(x => x.getId()); } if (e.changed) { delta.changed = this.convertToDto(e.changed); } if (delta.added || delta.removed || delta.changed) { this._proxy.$acceptBreakpointsDelta(delta); } } })); // send all breakpoints const bps = this.debugService.getModel().getBreakpoints(); const fbps = this.debugService.getModel().getFunctionBreakpoints(); const dbps = this.debugService.getModel().getDataBreakpoints(); if (bps.length > 0 || fbps.length > 0) { this._proxy.$acceptBreakpointsDelta({ added: this.convertToDto(bps).concat(this.convertToDto(fbps)).concat(this.convertToDto(dbps)) }); } </ins> } public dispose(): void {

Discussion:
Set some breakpoints Access from an extension- it's an empty array Try again - it's full Seems that we don't sync breakpoint into to the EH until the first call to one of the breakpoint properties do you have some context on this? It's a little confusing because I wouldn't expect sending breakpoint infos to be expensive, and I would expect to be able to access the breakpoints array immediately.
I do not have more context. I believe is the author of this code. I like your suggestion that we change this and actively sync the breakpoints into the EH (since it should not be expensive).
The observed behavior is by design: we want to avoid that all breakpoints get transferred to all active extensions all the time. But the API doc doesn't explain this...
Thanks is the worry that it's too much data/too expensive? What's the solution for extensions that need to access the list of breakpoints?
yes, potentially too much data and traffic for all extensions. What's the solution for extensions that need to access the list of breakpoints? adding a to the function of an extension will register the extension to receive live updates for . With this will always reflect the current set of breakpoints.
Thanks, I don't really understand that though, it doesn't seem like that much traffic/data, compared to something like the full text of open documents. If it's going to work this way, I should document it in But I might try doing some testing to remove this restriction because I think it's unexpected.
Verification steps: Create an extension that can log the value of Set a breakpoint in any file Then trigger your extension to check the length of the breakpoints array It should log the correct value on the first try- previously it would have been 0 on the first access, then the correct value afterwards
Change:
suite('Configuration Resolver Service', () => { let configurationResolverService: IConfigurationResolverService; <del> let envVariables: { [key: string]: string } = { key1: 'Value for Key1', key2: 'Value for Key2' }; </del> <ins> let envVariables: { [key: string]: string } = { key1: 'Value for key1', key2: 'Value for key2' }; </ins> let mockCommandService: MockCommandService; let editorService: TestEditorService; let workspace: IWorkspaceFolder;

Discussion:
VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} "command": "echo", "isShellCommand": true, "args": ["${env.PATH}"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is "Path". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue
this is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.
Let's keep it open and if some user is passionate he can tackle it
On linux and macOS environment variables are case sensitive, so "Path" and "PATH" are different variables on linux and macOS (but not on Windows). So your statement from above "IMO env variables on all OSes are case insensitive." is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?
I thought they are always case insensitive. So it should be case insensitive then on Windows only
I'm actually about done with a change for this if you want to take a look.
thanks, I will review the PR.
did you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.
no need to squash, I will add the comments to the PR directly if something is needed. Thanks
Change:
import { find } from 'vs/base/common/arrays'; import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation'; import { IViewsService } from 'vs/workbench/common/views'; <ins> import { ProviderProgressMananger } from 'vs/workbench/contrib/tasks/browser/providerProgressManager'; </ins> const QUICKOPEN_HISTORY_LIMIT_CONFIG = 'task.quickOpen.history'; const QUICKOPEN_DETAIL_CONFIG = 'task.quickOpen.detail';

Discussion:
We have a temporary fix for the release for but we need to do something better long term.
while working on quick access for tasks I noticed that we seem to be having 2 pickers for the same thing (?): Task quick open: ! "Run Task" picker: ! Is that intentional? Should the one be merged into the other?
Yes, they do not share much code :( as part of improving the quick pick I will converge them.
sounds good, please only change  and leave the other one because I plan to delete those old ones soon.
Change:
return path.split('/').map((segment) => encodeURIComponent(segment)).join('/'); } <del> export function getLink(gitAPI: GitAPI, useSelection: boolean, hostPrefix?: string, linkType: 'permalink' | 'headlink' = 'permalink', context?: LinkContext, useRange?: boolean): string | undefined { </del> <ins> export async function getLink(gitAPI: GitAPI, useSelection: boolean, hostPrefix?: string, linkType: 'permalink' | 'headlink' = 'permalink', context?: LinkContext, useRange?: boolean): Promise<string | undefined> { </ins> hostPrefix = hostPrefix ?? 'https://github.com'; const fileAndPosition = getFileAndPosition(context); if (!fileAndPosition) {

Discussion:
Testing One can copy links to & github & azure repos even though I just created the file and copying such a link will result in empty or 404 on GH. Seeing links to just created file : <img width="451" alt="image" src="https://user-"
No progress on this one yet, but would you expect the actions to be hidden, or would you want to be prompted to commit the file to the remote when the command is invoked?
I think users could be confused if the actions wouldn't appear (eg they might've forgotten the file isn't pushed), so the latter sounds better. But I wonder whether checking whether the file is available on remote would be slow
Change:
'c:/foo', '.foo', './foo', <ins> './$foo', </ins> '..foo', '~foo', '~/foo',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --There's currently an issue on the terminal of the VSCode that slows down the refactoring process of files specially on frameworks that relies heavily on the dollar sign for file structure like or . Any tool or place that spells out the path + filename containing $ is ignored by the cmd + click. Folders are even worse because it breaks their children. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: macOS Big Sur 11.5 (20G71) Steps to Reproduce: a file or a folder with the dollar sign on it it out using any tool or just run: !
Code pointer:
Change:
order: 1.3 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 3, }],

Discussion:
Type: <bBug</b- VS Code Version: 1.74.1 OS Version: Windows NT x64 10.0. Issue appeared just after upgrading VSCode to ver. 1.74.1 Currently, it is impossible to go to the function definition by clicking Ctrl+Click on the function name or using the F12 button. Also, the Go to definition option in Top Menu-Go-Go to Definition is disabled. VS Code version: Code 1.74.1 (, 2022-12-14T10:30:51.966Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
What code language? Is the option also disabled in the context menu? was a previous issue about this and related options not getting enabled in the top-level Go menu. Maybe this has come back. Do you think this didn't happen in 1.74.0?
- maybe caused by
Yeah, looks like the precondition for the command is too strong
Javascript I don't have such an option in the context menu I'm not 100% sure, which version I had previously installed, but I'm using VSCode almost every day, so I'm pretty sure I was using 1.74.0 or 1.73.1, and that behavior has occurred after auto-upgrade to 1.74.1. I've never noticed anything like it before.
After a clean uninstall (Uninstalled and deleted %APPDATA%Code and %USERPROFILE%.vscode), and installing 1.74.1 again, the problem does not occur anymore.
Change:
layout(dimension: DOM.Dimension): void { this.#rootElement.classList.toggle('mid-width', dimension.width < 1000 && dimension.width >= 600); this.#rootElement.classList.toggle('narrow-width', dimension.width < 600); <ins> const editorHeightChanged = dimension.height !== this.#dimension?.height; </ins> this.#dimension = dimension; if (!this.#notebookWidget.value) { return; } <ins> if (editorHeightChanged && this.#codeEditorWidget) { SuggestController.get(this.#codeEditorWidget)?.cancelSuggestWidget(); } </ins> this.#notebookEditorContainer.style.height = `${this.#dimension.height - this.#inputCellContainerHeight}px`; this.#layoutWidgets(dimension); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.0-insiders OS Version: macOS Monterey Steps to Reproduce: the input box of the interactive window type something like and to bring up the completion hover shrink down the size of the interactive window, the hover will not move with it ! .
What was the fix here? I seem to just be no longer to adjust the interactive window height but it could also be because my interactive window is still not fully working.
the interactive window height can be adjusted by open and hide the panel. Verifier: please test that when open/hide the panel through keybindings, the suggest widget is dismissed.
This mostly works, except for this issue when I show the hover using the keyboard ! I'll still call it verified, this is an unusual case, lmk if I should open an issue for this.
Change:
// Position hover below the target else if (this._hoverPosition === HoverPosition.BELOW) { // Hover on bottom is going beyond window <del> if (target.bottom + this._hover.containerDomNode.clientHeight > this._targetWindow.innerHeight) { </del> <ins> if (target.bottom + this._hover.containerDomNode.clientHeight + hoverPointerOffset > this._targetWindow.innerHeight) { </ins> this._hoverPosition = HoverPosition.ABOVE; } }

Discussion:
a project with some kind of debugging and make sure the Breakpoints view is near the bottom of the screen over the pencil icon on the second-to-bottom list item. It works over the bottom list icon. The tooltip seems to appear and disappear very quickly causing the mouse to flicker (the FPS on the gif doesn't capture it very well but you can see that it doesn't render correctly) !
cc , this might have always been a bug but is probably now more exposed given its a custom hover now.
I haven't made any changes to the computation of where the hover should be placed in relation to the target, so a bug that we have had for a while, but should definitely look into. After testing a bit it seems to me that this only happens for ().
This also definitely used to work on language features and recently regressed (works fine in 1.87 stable): ! Reported the styling problem in
Change:
(<IQuickOpenRegistry>Registry.as(QuickOpenExtensions.Quickopen)).registerQuickOpenHandler( new QuickOpenHandlerDescriptor( 'vs/workbench/parts/debug/browser/debugQuickOpen', <del> 'QuickOpenHandler', </del> <ins> 'DebugQuickOpenHandler', </ins> 'debug ', <del> nls.localize('debugCommands', "Debug XXX") </del> <ins> nls.localize('debugCommands', "Debug Configuration") </ins> ) );

Discussion:
Testing Version 1.10.0-insider Commit Date 2017-02-22T07:09:05.746Z Linux In the VSCode workspace, open VSCode on the 'extensions/html' folder. press Ctrl + E, type: debug with space at the end an empty dialog shows up click the dialog away error message shows up: Unable to instantiate quick open handler vs/workbench/parts/debug/browser/debugQuickOpen - QuickOpenHandler: {"errorCode":"load","moduleId":"vs/workbench/parts/debug/browser/debugQuickOpen","neededBy":["===anonymous10==="],"detail":{"errno":-2,"code":"ENOENT","syscall":"open","path":"/usr/share/code-"}}
! !
This has been fixed and awaiting pull request review before merge in.
Change:
const allowedBadgeProvidersRegex: RegExp[] = (product.extensionAllowedBadgeProvidersRegex || []).map((r: string) => new RegExp(r)); const extensionEnabledApiProposals: Record<string, string[]> = product.extensionEnabledApiProposals ?? {}; const reservedImplicitActivationEventPrefixes = ['onNotebookSerializer:']; <ins> const redundantImplicitActivationEventPrefixes = ['onLanguage:', 'onView:', 'onAuthenticationRequest:', 'onCommand:', 'onCustomEditor:']; </ins> function isTrustedSVGSource(uri: Uri): boolean { return allowedBadgeProviders.includes(uri.authority.toLowerCase()) || allowedBadgeProvidersRegex.some(r => r.test(uri.toString()));

Discussion:
Following the addition of implicit activation events in the November release, we'd like to provide lint warnings via the extension-editing extension when an extension declares activation events which are already implied by its declared contributions.
cc as a heads up--we previously discussed this in and at the time agreed that a simple warning for the reserved/internal event was sufficient. We've since updated the docs and extension samples to mention that you don't need to explicitly list many events anymore. In discussion with Kai, the next step to round out this work and make extension authors aware of the new behavior is to provide lint warnings for all redundant events in the extension-editing extension. Let me know if you have any questions or concerns.
Change:
import { INotificationService } from 'vs/platform/notification/common/notification'; import { ThemeIcon } from 'vs/platform/theme/common/themeService'; import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings'; <ins> import { GroupKind } from 'vs/workbench/contrib/tasks/common/taskConfiguration'; import { Codicon } from 'vs/base/common/codicons'; </ins> interface ITerminalData { terminal: ITerminalInstance;

Discussion:
This is the main thing I wanted from the task icons, if tasks of of kind to use the beaker: ! I think this makes sense over a setting since we can now override them via the property and the beaker icon aligns with our testing pane
I like it!