jiebi/CodeConvo huggingface dataset:
Change:
let terminal: ITerminalInstance | undefined = undefined; let error: TaskError | undefined = undefined; let promise: Promise<ITaskSummary> | undefined = undefined; <del> const problemMatchers = await this._resolveMatchers(resolver, task.configurationProperties.problemMatchers); if (task.configurationProperties.isBackground && problemMatchers.length) { </del> <ins> if (task.configurationProperties.isBackground) { const problemMatchers = await this._resolveMatchers(resolver, task.configurationProperties.problemMatchers); </ins> const watchingProblemMatcher = new WatchingProblemCollector(problemMatchers, this._markerService, this._modelService, this._fileService); if ((problemMatchers.length > 0) && !watchingProblemMatcher.isWatching()) { this._appendOutput(nls.localize('TerminalTaskSystem.nonWatchingMatcher', 'Task {0} is a background task but uses a problem matcher without a background pattern', task._label));

Discussion:
When having a launch config for debugging extensions which uses a task which uses a missing problem matcher (like ), the extension host development window no longer pops up. This used to work in the past. This apparently used to work until recently. cc
I'm not sure what a missing problem matcher is - if you mean as the problem matcher, we used to create the even when there was no problem matcher provided and that changed here wasn't around for that change, so it's possible I broke this then
I think means that if your task refers to a problem matcher that isn't installed.
In our case it was:
thanks for that info. Pretty sure the cause is . Did this repro in insider's for you?
Not sure what you mean here. I haven't installed the mentioned extension (watcher), used insiders, our run stoped working.
I can reproduce - have a with a that's either invalid or non-existent IE and . Debug and the window doesn't open
Thanks a lot!
Change:
return (a instanceof TestTreeErrorMessage ? -1 : 0) + (b instanceof TestTreeErrorMessage ? 1 : 0); } <ins> const durationDelta = (b.duration || 0) - (a.duration || 0); if (this.viewModel.viewSorting === TestExplorerViewSorting.ByDuration && durationDelta !== 0) { return durationDelta; } </ins> const stateDelta = cmpPriority(a.state, b.state); if (this.viewModel.viewSorting === TestExplorerViewSorting.ByStatus && stateDelta !== 0) { return stateDelta;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --It would be ideal if the Testing user interface would allow to sort/filter based on duration. Use case: I have a large number of tests in my project and they're slow, I want to sort by duration to identify long running tests. !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.595 --- <!-- score: 0.493 --<!-- potentialduplicatescomment --
I want to work on this shall I give it a try ?
Can I get a little help here ? I think I am not able to find the UI in the app. Is this screen capture same as above ? (Left panel) ! I made two tests locally, but I am not seeing the time it took to run the tests ?
You'll need to use to make the Test Explorer use the native experience.
Hey admin, i have just started my open source contribution journey. Can you assign this task to me? so that i can start working on it.
Feel free to submit a PR
Hey Conor, can I work on this issue
, I found that following changes will be needed adding a class to adding to export const enum TestExplorerViewSorting { ByLocation = 'location', ByStatus = 'status', } inside the file
The TestExplorerView is where it happens. You can do a "find all references" on and that'll give you a good indication of places to update
There is such a line for sort ByLocation , but not there for ByStatus , why is it so
What changes should be made to this file , please help me out
Have a pull request for this:
Change:
} .monaco-workbench .repl .repl-tree .output.expression.value-and-source .value { <del> flex: 1; </del> <ins> margin-right: 4px; </ins> } .monaco-workbench .repl .repl-tree .monaco-tl-contents .arrow {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47 OS Version: MacOS Steps to Reproduce: a local project server (f.ex angular) with a long filename (some 16+ characters) <filename.<extension. a debug session (f.ex firefox), and check the debug console output. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes !
I don't understand what the screenshot is showing. Please show the whole debug console. I do not understand what gets concatenated in the screenshot. What exactly are you expecting and what is the erroneous behavior?
attached photo of whole debug console - error occurs on last line. Behavior: supposedly filenames (some 16+ characters) will be shortened with (...) instead of showing the whole filename and line number. Expecting: the whole filename and line number where a console log is being outputted. !
Yes, I agree this is an issue. The problem is that we set a to 150 . The ideal solution would be that the elements gets shrinked first, and that it has unlimited size. Adding help wanted as I am open to review a PR which fixes this. If nobody tackles this I can also look into this in the future.
Hi I can give this a try.
great, thanks!
Change:
import { deepStrictEqual, ok, strictEqual } from 'assert'; import { OperatingSystem } from 'vs/base/common/platform'; <del> import { detectLinks, detectLinkSuffixes, getLinkSuffix, IParsedLink, removeLinkSuffix } from 'vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing'; </del> <ins> import { detectLinks, detectLinkSuffixes, getLinkSuffix, IParsedLink, removeLinkQueryString, removeLinkSuffix } from 'vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing'; </ins> interface ITestLink { link: string;

Discussion:
<img width="1440" alt="image" src="https://user-"path: Versions:
I have one question wish can get help: how vscode terminal detect the path cwd? why can the path correctlly go to the file with a releative path? <img width="1440" alt="image" src="https://user-"I guess it may use the But seems I can get the cwd in TerminalLinkProvider now: <img width="1440" alt="image" src="https://user-"
We check a few things to determine which to use
vite become more and more popular recent days, I think it would be convinient to support the path with query string: !
When I click, it opens the right file, but it underlines the first query argument when I hover, is that an issue? <img width="539" alt="image" src=""
not much of an issue but it would look more polished by just underlining the whole thing
Change:
hr { border: 0; <del> height: 2px; border-bottom: 2px solid; </del> <ins> height: 1px; border-bottom: 1px solid; </ins> } h1 { <ins> font-size: 2em; margin-top: 0; </ins> padding-bottom: 0.3em; <del> line-height: 1.2; </del> border-bottom-width: 1px; border-bottom-style: solid; <del> font-weight: normal; </del> <ins> } h2 { font-size: 1.5em; padding-bottom: 0.3em; border-bottom-width: 1px; border-bottom-style: solid; } h3 { font-size: 1.25em; } h4 { font-size: 1em; } h5 { font-size: 0.875em; } h6 { font-size: 0.85em; </ins> } table {

Discussion:
Here are our headers (left) compared with GitHub's (right): <img width="649" alt="image" src=""Things to note: H2 still has a bottom border in GitHub, looks great Our H4 feels very much like plain text, GitHub is definitely larger than plain Our H5 is even smaller than plain text, GitHub is at least in bold cc
Agreed. I've wanted to update these for a while now.
Change:
// Add default items const productLabel = this.productService.nameLong; const marketPlaceLabel = localize("reportExtensionMarketplace", "Extension Marketplace"); <del> issuePicksConst.push( { label: productLabel, ariaLabel: productLabel, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.VSCode }) }, { label: marketPlaceLabel, ariaLabel: marketPlaceLabel, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.Marketplace }) }, { type: 'separator', label: localize('extensions', "Extensions") } ); </del> <ins> const productFilter = matchesFuzzy(filter, productLabel, true); const marketPlaceFilter = matchesFuzzy(filter, marketPlaceLabel, true); // Add product pick if product filter matches if (productFilter) { issuePicksConst.push({ label: productLabel, ariaLabel: productLabel, highlights: { label: productFilter }, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.VSCode }) }); } // Add marketplace pick if marketplace filter matches if (marketPlaceFilter) { issuePicksConst.push({ label: marketPlaceLabel, ariaLabel: marketPlaceLabel, highlights: { label: marketPlaceFilter }, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.Marketplace }) }); } issuePicksConst.push({ type: 'separator', label: localize('extensions', "Extensions") }); </ins> // creates menu from contributed const menu = this.menuService.createMenu(MenuId.IssueReporter, this.contextKeyService);

Discussion:
Testing to filter e.g. Python Notice the non-extension entries remain at top Maybe this was by design, but I don't understand it. If I type python, don't I want to quickly select a python related entry?
Change:
GetBranches = 'GetBranches', GetCommitTemplate = 'GetCommitTemplate', GetObjectDetails = 'GetObjectDetails', <ins> GetObjectFiles = 'GetObjectFiles', </ins> GetRefs = 'GetRefs', GetRemoteRefs = 'GetRemoteRefs', HashObject = 'HashObject',

Discussion:
Verification steps: Open a folder/workspace that contains a git repository Modify an existing file, and save it Add a new file, add some contents to it, and save it Invoke the "Git: Stash (Include Untracked)" command, and create a new stash Invoke the "Git: View Stash", and pick the stash that you have created Confirm that all files from the stash have the correct content
Change:
{ "id": "html", "extensions": [ <ins> ".rhtml", </ins> ".html", ".htm", ".shtml",

Discussion:
VSCode Version: Code 1.12.2 (, 2017-05-10T13:16:25.899Z) OS Version: Linux x64 4.4.0-78-generic Extensions: ; Steps to Reproduce:
I had created a pr. which should fix it.
Change:
clone.textContent = globalStylesheet.textContent; })); <del> let clonedGlobalStylesheets = globalStylesheets.get(globalStylesheet); if (!clonedGlobalStylesheets) { clonedGlobalStylesheets = new Set<HTMLStyleElement>(); globalStylesheets.set(globalStylesheet, clonedGlobalStylesheets); } clonedGlobalStylesheets.add(clone); disposables.add(toDisposable(() => clonedGlobalStylesheets?.delete(clone))); </del> <ins> globalStylesheetClones.add(clone); disposables.add(toDisposable(() => globalStylesheetClones.delete(clone))); </ins> return disposables; }

Discussion:
Type: <bBug</bThe fix for seems to have stopped working in the latest Insiders build. VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-06T05:34:22.485Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Range:
Really a bad bug: none of the global styles would get copied properly, a lot of other CSS related things must have been broken. Fix tomorrow!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
type: AccessibleViewType = AccessibleViewType.View; getProvider(accessor: ServicesAccessor) { const viewsService = accessor.get(IViewsService); <del> const debugService = accessor.get(IDebugService); </del> const accessibleViewService = accessor.get(IAccessibleViewService); const replView = getReplView(viewsService); if (!replView) { return undefined; } const focusedElement = replView.getFocusedElement(); <del> return new ReplOutputAccessibleViewProvider(replView, focusedElement, debugService, accessibleViewService); </del> <ins> return new ReplOutputAccessibleViewProvider(replView, focusedElement, accessibleViewService); </ins> } }

Discussion:
Testing a js file at the root that something. a launch config to run it using node like: it and see the logs persist in the debug console.] to use alt+f2 to read it 'no debug session is active' !
is there a way to get the from an inactive session?
Reviewing the code some more I think the more reliable way to get the displayed session is to use . Currently it uses viewModel.focusedSession which won't include ended sessions as Andrea found
I think that will be a little involved, so deferring
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
if (this.accessor.partOptions.wrapTabs) { const visibleTabsWidth = tabsContainer.offsetWidth; const allTabsWidth = tabsContainer.scrollWidth; <ins> const lastTabFitsWrapped = () => { const lastTab = this.getLastTab(); if (!lastTab) { return true; // no tab always fits } return lastTab.offsetWidth <= (dimensions.available.width - editorToolbarContainer.offsetWidth); }; </ins> // If tabs wrap or should start to wrap (when width exceeds visible width) // we must trigger `updateWrapping` to set the `last-tab-margin-right` // accordingly based on the number of actions. The margin is important to // properly position the last tab apart from the actions <del> if (tabsWrapMultiLine || allTabsWidth > visibleTabsWidth) { </del> <ins> // // We already check here if the last tab would fit when wrapped given the // editor toolbar will also show right next to it. This ensures we are not // enabling wrapping only to disable it again in the code below (this fixes // flickering issue https://github.com/microsoft/vscode/issues/115050) if (tabsWrapMultiLine || (allTabsWidth > visibleTabsWidth && lastTabFitsWrapped())) { </ins> updateTabsWrapping(true); } // Tabs wrap multiline: remove wrapping under certain size constraint conditions if (tabsWrapMultiLine) { <del> const lastTab = this.getLastTab(); </del> if ( (tabsContainer.offsetHeight > dimensions.available.height) ||											// if height exceeds available height (allTabsWidth === visibleTabsWidth && tabsContainer.offsetHeight === TabsTitleControl.TAB_HEIGHT) ||	// if wrapping is not needed anymore <del> (lastTab && lastTab.offsetWidth > (dimensions.available.width - editorToolbarContainer.offsetWidth))	// if editor actions occupy too much space </del> <ins> (!lastTabFitsWrapped())																					// if last tab does not fit anymore </ins> ) { updateTabsWrapping(false); }

Discussion:
Testing Create multiple editor groups Ensure that the selected tab is not the first one in the editor group Start dragging the sash so that there is not enough room to wrap tabs Notice how the name of the tab that is visible jitters as it switches between the name of the first tab, and the name of the selected tab !
Yeah I was not able to figure out what triggers this and was even suspecting a browser bug (though didn't follow up). //cc
I see this being related to: is called we enable wrapping we disable wrapping right after because we figure out the space is too limited somehow the scrollbar is now in a bad spot and needs a proper reset to avoid flicker
I was able to find the origin of the bug in : wrapping is activated even when there is no space due to the actions right to the last tab. In the next call, it is disabled again, because the action's size is considered in that case. Constantly switching between wrapping and not wrapping makes it behave weird. I'll make a PR.
Change:
provideCompletionItems(document, position, _token) { const location = getLocation(document.getText(), document.offsetAt(position)); if (isCompletingInsidePropertyStringValue(document, location, position)) { <ins> if (document.fileName.endsWith('.code-workspace') && !isLocationInsideTopLevelProperty(location, ['launch', 'tasks'])) { return []; } </ins> let range = document.getWordRangeAtPosition(position, /${[^"}]*}?/); if (!range || range.start.isEqual(position) || range.end.isEqual(position) && document.getText(range).endsWith('}')) { range = new vscode.Range(position, position);

Discussion:
Type: <bBug</bThere are missing completions inside files which do appear inside the folder. For example, here are the completions in a file: ! Versus the one in a file: ! VS Code version: Code - Insiders 1.73.0-insider (, 2022-10-24T05:31:12.081Z) OS version: WindowsNT x64 10.0. Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ vscode-eslint2.2.6 todo-tree0.0.219 reg1.1.0 csharp1.25.0 material-icon-theme4.21.0 msbuild-project-tools0.4.9 intellicode-api-usage-examples0.2.6 vscodeintellicode1.2.29 volar1.0.9 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
do you know where these variable completions come from? I think they are sort of generic for every string in and I think they should show up in the workspace config too.
they come from here: Makes sense to me to add them in .code-workspace.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Was there any information you wanted me to provide? It seems like a solution was proposed by
Change:
"@parcel/watcher": "2.1.0", "@vscode/iconv-lite-umd": "0.7.0", "@vscode/policy-watcher": "^1.1.4", <del> "@vscode/proxy-agent": "^0.13.1", </del> <ins> "@vscode/proxy-agent": "^0.13.2", </ins> "@vscode/ripgrep": "^1.15.2", "@vscode/spdlog": "^0.13.10", "@vscode/sqlite3": "5.1.4-vscode",

Discussion:
Copied from
By based on the error from , looks like this commit was not released and consumed in VSCode
I assume this change was done in March and therefore it also exists in 1.77.0 ?
Not sure why you're assuming the change was done in March. The change was done in April: It's new in 1.78.0. This breaks automatic proxy discovery in the extension host on Windows platforms only. I don't think it's a stop ship because: affects extension host on Windows only. affects users who rely on automatic proxy discovery. There is a workaround: manually configure the proxy on VS Code. were seemingly no reports of breakage the entire month of April on Insiders. I suggest merging the fix in as a candidate of an April recovery milestone. Leaving it to you as endgame champ, to chime in.
Because I saw the dependency on was in March - May be this is nothing to do with this change. I agree to take this as a candidate for next recovery
Just to clarify: This breaks loading of OS certificates on Windows (not proxy discovery). This will affect users relying on self-signed certificates for development and those requiring a CA certificate from their network proxy. Only HTTP/S requests made by extensions using the Node API are affected.
Can a test get to prevent this from happening again?
This is also affecting remote-containers extension. I'm trying to open a folder in my remote linux machine using remote-containers extension in vscode(windows workstation). It just silently fails with the following error:
Thanks Manually setting the proxy in remote settings worked for me !
Verification: VS Code on Windows the output channel that there's no exception regarding <img width="1026" alt="image" src=""
Change:
top: INPUT_EDITOR_PADDING, bottom: INPUT_EDITOR_PADDING }, <ins> hover: { enabled: true } </ins> } }, { ...{

Discussion:
Issue Type: <bBug</bpython file with # %% comments a cell over something like 'print' in the interactive window Expected: Hover window shows up Actual: No hover messages are sent to the LS. I suspect hovering over the IW notebook just isn't hooked up. VS Code version: Code - Insiders 1.63.0-insider (, 2021-11-09T15:23:39.737Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-eslint2.2.2 prettier-vscode9.0.0 remotehub0.18.0 better-cpp-syntax1.15.10 vscode-position1.0.3 regexp-preview0.1.5 python2021.12.-dev vscode-pylance9999.0.0-dev jupyter2021.10. jupyter-keymap1.0.0 jupyter-renderers1.0.3 remote-containers0.205.1 remote-ssh0.66.0 remote-ssh-edit0.66.0 remote-ssh-edit-nightly2021.11.3789 remote-ssh-nightly2021.11.3793 remote-wsl0.58.5 vscode-remote-extensionpack0.21.0 cpptools1.7.1 cpptools-extension-pack1.0.0 live-server0.2.9 vscode-github-issue-notebooks0.0.112 vscode-selfhost-test-provider0.3.8 vscode-typescript-next4.6. rpa-eslint-snippets0.0.2 rest-book4.2.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This used to work in the webview implementation
This might be because the uri is not what we expect? Meaning the language service registered for a document filter doesn't match.
/verified. Although not sure if I should be verifying as I submitted the fix
Change:
} }); <del> const mtw: MainThreadWorkspace = instantiationService.createInstance(<any>MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); </del> <ins> const mtw = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); </ins> return mtw.$startFileSearch('foo', null, null, 10, new CancellationTokenSource().token); });

Discussion:
Due to an oversight, does not enforce arguments or its return type. Fixing this exposes around 80 typings errors in our codebase that should be addressed To fix this issue in your code: , comment out the . (Do not check in this change. I will check in the change to the signature once all error have been fixed) look at the file assigned to you and fix the type error (you may need to restart the compile since we are changing such a core type) [x] — [x] — [x] — [x] — [x] — [x] — [x] — [ ] — [ ] — [ ] — [ ] — [x] — [x] — [x] — [x] — [x] — [x] — [ ] — [x] —
Change:
return true; } <ins> public modelRangeIsVisible(modelRange: Range): boolean { const lineCount = this._lines.model.getLineCount(); if (modelRange.startLineNumber < 1 || modelRange.startLineNumber > lineCount) { // invalid arguments return false; } if (modelRange.endLineNumber < 1 || modelRange.endLineNumber > lineCount) { // invalid arguments return false; } return true; } </ins> public getModelLineViewLineCount(modelLineNumber: number): number { return 1; }

Discussion:
As you can see, the positioning does not folding into account: ! This breaks the revert arrows in the diff editor, as I adopted glyph widgets for them.
We're deciding whether to render widgets based on and here but these are the viewport and not the model line numbers