jiebi/CodeConvo huggingface dataset:
Change:
import { IPosition } from 'vs/editor/common/core/position'; import { groupBy } from 'vs/base/common/arrays'; import { dispose } from 'vs/base/common/lifecycle'; <del> import { SelectionBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, ClipboardBasedVariableResolver } from './snippetVariables'; </del> <ins> import { SelectionBasedVariableResolver, CompositeSnippetVariableResolver, ModelBasedVariableResolver, ClipboardBasedVariableResolver, TimeBasedVariableResolver } from './snippetVariables'; </ins> import { ModelDecorationOptions } from 'vs/editor/common/model/textModel'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';

Discussion:
Edit: Sorry if this is a terrible issue... The current list of variables available when writing a snippet can be found . Existing variables expose great contextual information - such as current file, directory, line number, word, etc. Development happens so fast that information can become outdated, so knowing when some custom snippets were inserted could be useful. For example, when creating files or adding comments. My current use case is a snippet that inserts copyright headers. The key binding inserts the header: It would help to include the date: and could also apply to updates or comments: Doing so could mean a simple variable like , but that may not work for non-US users who's date format is different i/e not month/day/year. Perhaps exposing the variables separately such as , etc or localization can help? I'd like to know if there is any interest in this. I know an extension could do this but it seems like overkill, but that could depend on potential use cases. Thanks for any feedback.
Hm, this is dupe of many requests we have gotten around this but made a valid point. Adding variables for year, month, day and hour, minute, second makes sense. That will allow anyone to compose it's own date. So, yeah feel free to drop a PR
Good to hear. Thanks for the PR!
Change:
TreeSitterTokenizationRegistry.getOrCreate(languageId); } } <ins> const languagesToUnregister = [...this._tokenizersRegistrations.keys()].filter(languageId => !setting.includes(languageId)); for (const languageId of languagesToUnregister) { this._tokenizersRegistrations.deleteAndDispose(languageId); } </ins> } private async _fetchQueries(newLanguage: string): Promise<TreeSitterQueries> {

Discussion:
Currently: If it's disabled and I enable it, nothing changes. I must reload the window. If it's enabled and I disable it, all colors are gone. Enabling it back again does nothing. I must reload the window. Let's make this setting work dynamically at runtime, so ease experimentation. Bonus: remove the from the setting name. Related:
This should already be working, and I do see it working. The colors being gone is not related to disabling it, it's actually still running but you've hit the bug where the tree is getting messed up. I removed disabling without reload as part of some structural changes. I'll see if it can be re-.
I am not sure this works, is it setting?
Looks like I need this:
Was just adding steps, yes that's it. Thanks for verifying!
Can I ask what languages treesister supports now? Or just only support typescript
Just typescript, and it's a work in progress: it is not yet performant, we don't support injected languages, and its missing a lot of the tricks we do to make syntax highlighting for the viewport fast. We're starting with typescript for selfhosting purposes.
Change:
} // ... on a different composite bar else { <del> const viewsToMove = this.viewDescriptorService.getViewContainerModel(currentContainer)!.allViewDescriptors; if (viewsToMove.some(v => !v.canMoveView)) { return; } </del> this.viewDescriptorService.moveViewContainerToLocation(currentContainer, this.targetContainerLocation, this.getTargetIndex(targetCompositeId, before)); } }

Discussion:
Support moving debug and extensions viewlets to other locations. At present these cannot be moved because the views contained in them are not movable. But that should not stop moving the complete view container. CC
Figured out that there are issues moving Remote container viewlet and it is because the views infrastructure re-create the ViewPaneContainer on move and wrongly assumes itself as a single-ton and adding the remote help ext point handler again which throws an error.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
Change:
private _lastLineRelativePosition: number = 0; private _hoverOnLine: number = -1; private _hoverOnColumn: number = -1; <del> private _state: StickyScrollWidgetState | undefined; </del> constructor( private readonly _editor: ICodeEditor

Discussion:
enable sticky scroll open a file and scroll such that sticky scroll appears reload the window observe that the sticky scroll lines are not colored until they get rerendered once there is that could be used
Hey thanks for filing the issue. The listener onDidChangeModelTokens already exists inside of the sticky scroll code. I'll investigate the issue.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.
Change:
}); async function splitCell(context: INotebookCellActionContext): Promise<void> { <del> if (context.cell.cellKind === CellKind.Code) { const newCells = await context.notebookEditor.splitNotebookCell(context.cell); if (newCells) { context.notebookEditor.focusNotebookCell(newCells[newCells.length - 1], 'editor'); } </del> <ins> const newCells = await context.notebookEditor.splitNotebookCell(context.cell); if (newCells) { context.notebookEditor.focusNotebookCell(newCells[newCells.length - 1], 'editor'); </ins> } }

Discussion:
! Most likely an oversight, we should create a color token for this so that it's themeable. Found .
Change:
@IProductService private readonly productService: IProductService, @IContextKeyService private readonly contextKeyService: IContextKeyService, @IRequestService private readonly requestService: IRequestService, <ins> @IDialogService private readonly dialogService: IDialogService, </ins> ) { super();

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --
Change:
import { IV8Profile } from 'vs/platform/profiling/common/profiling'; import { IAuxiliaryWindowsMainService, isAuxiliaryWindow } from 'vs/platform/auxiliaryWindow/electron-main/auxiliaryWindows'; import { IAuxiliaryWindow } from 'vs/platform/auxiliaryWindow/electron-main/auxiliaryWindow'; <ins> import { CancellationError } from 'vs/base/common/errors'; </ins> export interface INativeHostMainService extends AddFirstParameterToFunctions<ICommonNativeHostService, Promise<unknown> /* only methods, not events */, number | undefined /* window ID */> { }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (It's happening for fresh installation) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Macbook M1 Pro - Sonoma 14.2.1 Steps to Reproduce: VSCode Darwin build from downloads page - (Mac .zip Apple Silicon) Shell command: Install 'code' command in PATH cancel for the below prompt <img width="1136" alt="Screenshot 2024-01-02 at 7 35 58 PM" src=""It should display that shell command was not completed successfully. Instead it shows command successfully <img width="1136" alt="Screenshot 2024-01-02 at 7 38 19 PM" src=""
Change:
await this._withSyncedResources([resource]); const modelId = await (await this._getProxy()).detectLanguage(resource.toString(), langBiases, preferHistory, supportedLangs); <del> const langaugeId = this.getLanguageId(modelId); </del> <ins> const languageId = this.getLanguageId(modelId); </ins> const LanguageDetectionStatsId = 'automaticlanguagedetection.perf';

Discussion:
I found a few places that "Language" is accidentally spelled "Langauge" in the source. See for the corrections.
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.67", "xterm-addon-search": "0.9.0-beta.41", </del> <ins> "xterm": "4.19.0", "xterm-addon-search": "0.9.0", </ins> "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.12.0-beta.43" </del> <ins> "xterm-addon-webgl": "0.12.0" </ins> } }

Discussion:
! cmd+f, do a search clear the text in the find input it says "0 of -1"
was this insiders or code - oss? If the latter can you make sure is updated?
need to see if this reproduces in OSS
doesn't reproduce in the demo... I think I updated before the PR checks had finished maybe so that fix wasn't included?
I tested with my branch of symlinked so that's probably why I wasn't seeing it
yep happens in OSS so the fix is to update in vscode
Change:
isExtension: boolean; hasHttpsRepository: boolean; repository: Uri; <ins> implicitActivationEvents: Set<string> | undefined; </ins> } export class ExtensionLinter {

Discussion:
Following the addition of implicit activation events in the November release, we'd like to provide lint warnings via the extension-editing extension when an extension declares activation events which are already implied by its declared contributions.
cc as a heads up--we previously discussed this in and at the time agreed that a simple warning for the reserved/internal event was sufficient. We've since updated the docs and extension samples to mention that you don't need to explicitly list many events anymore. In discussion with Kai, the next step to round out this work and make extension authors aware of the new behavior is to provide lint warnings for all redundant events in the extension-editing extension. Let me know if you have any questions or concerns.
Change:
}); interface IViewModel { <ins> onDidChangeHelpInformation: Event<void>; </ins> helpInformation: HelpInformation[]; }

Discussion:
Steps to Reproduce: remote explorer and view help links ( etc) under the viewlet for existing remote extensions. additional remote extensions and view the help link options again. Expected: links for the newer extensions show up in the lists. Actual: does not change. and reopening updates the list.
Change:
suite('createProfileSchemaEnums', () => { test('should return an empty array when there are no profiles', () => { deepStrictEqual(createProfileSchemaEnums([]), { <del> values: [], markdownDescriptions: [] </del> <ins> values: [ null ], markdownDescriptions: [ 'Automatically detect the default' ] </ins> }); }); test('should return a single entry when there is one profile', () => {

Discussion:
Open default settings JSON: ! Version: 1.67.0-insider (user setup) Commit: Date: 2022-03-31T11:00:49.798Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Windows_NT x64 10.0.
windows and linux issue only - works on mac <img width="481" alt="Screen Shot 2022-03-31 at 11 16 55 AM" src="https://user-"
but not in the settings editor actually
I think it happens on mac too, was originally reported for .osx
any idea why null is not accepted here? We set null as a valid type along side enum/string:
any thoughts as I know you did some work related to enum settings?
Not sure, but I get a mysterious result in the suggestions: !
yeah that should be
If enums are defined, you need to add as a valid value to the enums as well
I believe null is already one of the enum values
The completion values are composed of enum, default and more. The validation only looks at at enum values. So I'm quite sure the num values don't contain null, as the hover shows: !
Change:
export interface ICommand { command: string; <del> title: string; category?: string; </del> <ins> title: string | ILocalizedString; category?: string | ILocalizedString; </ins> } export interface IConfigurationProperty {

Discussion:
Testing in Firefox with de-ch (Swiss German) set. Open command palette and search for Remote Repositories commands :bug: The first command has a partly English, partly de-ch line under it ( and in English, seems to be de-ch translated) !
Hmm yeah it should look like this (Desktop screenshot) with the English strings next to the German strings. I think this is a bug in how I'm applying the translations... !
Just found out about these functions on the desktop side: Which seems to go through the manifest and turn some s into s. I followed up with to understand how this works.
This code was originally written by so I would ask him to know how this works.
Not quite, it was originally written by , but I'm happy to try and help. My understanding is that the code is taking a JSON object that looks like this: Together with another JSON object that looks like this: And produces a JSON object that looks like this by substituting all string values of the shape with their corresponding value:
I still see this on firefox: ! The first option's english translation still looks wrong? (tested on )
The first one is still wrong because of so we'll track that there. However, the rest now have the English string underneath which they use to not have, which means this is fixed and verified
Change:
const yesButton = nls.localize('TaskQuickPick.changeSettingYes', "Yes"); const changeSettingResult = await this._dialogService.show(Severity.Warning, nls.localize('TaskQuickPick.changeSettingDetails', <del> "Task detection for {0} tasks causes files in any workspace you open to be run as code. Enabling {0} task detection is a user setting and will apply to any workspace you open. Do you want to enable {0} task detection for all workspaces?", selectedType), [noButton, yesButton]); </del> <ins> "Task detection for {0} tasks causes files in any workspace you open to be run as code. Enabling {0} task detection is a user setting and will apply to any workspace you open. nn Do you want to enable {0} task detection for all workspaces?", selectedType), [noButton, yesButton] ); </ins> if (changeSettingResult.choice === 1) { await this._configurationService.updateValue(`${selectedType}.autoDetect`, 'on'); await new Promise<void>(resolve => setTimeout(() => resolve(), 100));

Discussion:
Testing !
I also wonder why none of the buttons are focused by default?
I don't see a way via the to indicate which should be pre-selected
Try setting the option as well.
Change:
import 'vs/css!./media/settingsWidgets'; import { localize } from 'vs/nls'; import { IContextViewService } from 'vs/platform/contextview/browser/contextView'; <del> import { foreground, inputBackground, inputBorder, inputForeground, listActiveSelectionBackground, listActiveSelectionForeground, listHoverBackground, listHoverForeground, listInactiveSelectionBackground, listInactiveSelectionForeground, registerColor, selectBackground, selectBorder, selectForeground, textLinkForeground, textPreformatForeground, editorWidgetBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { foreground, inputBackground, inputBorder, inputForeground, listActiveSelectionBackground, listActiveSelectionForeground, listHoverBackground, listHoverForeground, listInactiveSelectionBackground, listInactiveSelectionForeground, registerColor, selectBackground, selectBorder, selectForeground, textLinkForeground, textPreformatForeground, editorWidgetBorder, textLinkActiveForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { attachButtonStyler, attachInputBoxStyler } from 'vs/platform/theme/common/styler'; import { ICssStyleCollector, ITheme, IThemeService, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { disposableTimeout } from 'vs/base/common/async';

Discussion:
Issue Type: <bBug</b VS Code version: Code 1.28.2 (, 2018-10-17T00:23:51.859Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.504 --- <!-- score: 0.472 --- <!-- score: 0.457 --<!-- potentialduplicatescomment --
Change:
folder = pick.folder.uri; } <del> let quickpick = vscode.window.createQuickPick<vscode.QuickPickItem & { repo?: string, auth?: 'https' | 'ssh' }>(); </del> <ins> let quickpick = vscode.window.createQuickPick<vscode.QuickPickItem & { repo?: string, auth?: 'https' | 'ssh', isPrivate?: boolean }>(); </ins> quickpick.ignoreFocusOut = true; quickpick.placeholder = 'Repository Name';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As noted in , the lack of an option to create a public repository is by design rather than a bug. In that issue, gave the following reason for omitting the option: I would argue that: two quickpick options instead of one would not significantly complicate the UI. process of making a private repository public is not straightforward, especially when the alternative is to just create it as public in the first place. For reference, here are the required steps: Select "Publish to GitHub private repository" from quickpick and open the repo when finished. <img width="643" alt="Screen Shot 2020-07-12 at 11 26 12 AM" src="https://user-"- <img width="471" alt="Screen Shot 2020-07-12 at 11 27 26 AM" src="https://user-"- Open repository settings on GitHub. <img width="988" alt="Screen Shot 2020-07-12 at 11 34 14 AM" src="https://user-"- Scroll all the way to the bottom of the page (to the "Danger Zone") and click "Change visibility." <img width="942" alt="Screen Shot 2020-07-12 at 11 28 27 AM" src="https://user-"- In the modal, select the "Make public" radio option. Type the full repo name and click "I understand, change repository visibility." <img width="488" alt="Screen Shot 2020-07-12 at 11 28 51 AM" src="https://user-"For me and many others whose primary work is done in public repos, these steps would be completely eliminated if there were an option to create the repo as public in the first place. I don't believe it would be very difficult to implement this feature. Here's a simple solution:
OK sure, feel free to submit a PR.
Will do, thanks!
Change:
function isSchemaResolveError(d: Diagnostic) { return d.code === /* SchemaResolveError */ 0x300; } <del> function getOptionsForDocument(document: TextDocument): TextEditorOptions | undefined { for (const editor of window.visibleTextEditors) { if (editor.document.uri.toString() === document.uri.toString()) { return editor.options; } } return; } </del>

Discussion:
Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings
Hey that's a good idea! I'll discuss it with the team. What do you think ?
Yes, makes sense!
Change:
import { IWorkspaceTrustManagementService, IWorkspaceTrustRequestService, workspaceTrustToString } from 'vs/platform/workspace/common/workspaceTrust'; import { Extensions as WorkbenchExtensions, IWorkbenchContribution, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions'; import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; <del> import { Codicon, registerCodicon } from 'vs/base/common/codicons'; </del> <ins> import { Codicon } from 'vs/base/common/codicons'; </ins> import { ThemeColor } from 'vs/workbench/api/common/extHostTypes'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';

Discussion:
The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.
FYI
Change:
} async executeNotebookCells(notebook: INotebookTextModel, cells: Iterable<NotebookCellTextModel>, contextKeyService: IContextKeyService): Promise<void> { <del> const cellsArr = Array.from(cells); </del> <ins> const cellsArr = Array.from(cells) .filter(c => c.cellKind === CellKind.Code); if (!cellsArr.length) { return; } </ins> this._logService.debug(`NotebookExecutionService#executeNotebookCells ${JSON.stringify(cellsArr.map(c => c.handle))}`); const message = nls.localize('notebookRunTrust', "Executing a notebook cell will run code from this workspace."); const trust = await this._workspaceTrustRequestService.requestWorkspaceTrust({ message });

Discussion:
Testing microsoft/vscode-jupyter 1) Open 1) Install Jupyter and Python extensions 1) Create a new untitled jupyter notebook 1) Create a markdown cell 1) Paste image 1) <kbdCtrl</kbd+<kbdEnter</kbd-I get a prompt for installing kernels from the market place. <img width="925" alt="image" src="https://user-"This is wrong for two reasons: 1) Since the Jupyter extension is installed I should be able to connect the notebook to a kernel on a remote server. Also see 1) This is a markdown cell. No kernel needed for rendering a markdown cell.
I'm not seeing this locally but I can reproduce with Not sure where is the best place to check whether the cells are markdown cells.