jiebi/CodeConvo huggingface dataset:
Change:
// first find the detector with a matching pid const pid = await e.terminal.processId; <ins> const str = removeAnsiEscapeCodes(e.data); </ins> for (const [, detector] of this.detectors) { if (detector.shellPid === pid) { <del> detector.detectPattern(e.data); </del> <ins> detector.detectPattern(str); </ins> return; } } // if none found, try all detectors until one matches for (const [, detector] of this.detectors) { <del> if (detector.detectPattern(e.data)) { </del> <ins> if (detector.detectPattern(str)) { </ins> return; } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: 12.15.1 Steps to Reproduce: to define a for Vite. Vite prints colors, which unlike problems matchers, are not stripped while matching the output. This makes it difficult to define a proper pattern for it.
Please provide a screenshot or illustrating the problem (attaching images won't work via email, you need to go to ). See for more general info on how to report actionable terminal issues. /label info-needed terminal
Sorry for the zip. The gif came out 1MiB bigger than GitHub will like to allow to upload.
Thanks - based on the gif, the problem is that is not taking effect - in your case, the property
It is taking effect. I'm purposefully disabling it by commenting it at first. At the start I run without it to show that is not working with colors enabled. I then uncomment it which disables colors and show that without colors does work.
Change:
/* Editor Label */ <ins> .monaco-workbench .part.editor > .content .editor-group-container > .title { cursor: pointer; } </ins> .monaco-workbench .part.editor > .content .editor-group-container > .title .title-label, .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab .tab-label { white-space: nowrap;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Windows 11 Steps to Reproduce: custom cursor theme (such as a large version of Windows 11 colored vector cursor theme) over tab bar (not tab) Expected behavior: Colored/custom mouse pointer Observed behavior: "Grabby hand" cursor icon. Clicking and dragging the tab bar does nothing, so it doesn't make sense. Fix: Since clicking and dragging the bar does nothing, change it to the default arrow cursor. Screenshots: ! !
Duplicate of
This can't just be fixed by changing the CSS to something else? As I said, dragging the bar does nothing: this is about the UI of VScode implying something can be grabbed and dragged, not just that the cursor is ugly.
Yeah good point, lets ditch this ugly cursor, at least on platforms where not supported nicely.
Opening up for help wanted, to find a better, native cursor on Windows.
Lets just not use it and use cursor instead, same as tabs.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
this.handleWorkspaceFolderConfiguration(setting, configuration, markerData); break; } <del> } else if (!OVERRIDE_PROPERTY_REGEX.test(setting.key)) { // Ignore override settings (language specific settings) markerData.push({ severity: MarkerSeverity.Hint, tags: [MarkerTag.Unnecessary], ...setting.range, message: nls.localize('unknown configuration setting', "Unknown Configuration Setting") }); </del> <ins> } else { markerData.push(this.gemerateUnknownConfigurationMarker(setting)); </ins> } } }

Discussion:
Add an unrecognized setting to See that it is correctly dimmed with no warning underline Add it to a language-specific settings block There is a warning, "This setting does not support per-language configuration which is misleading" !
Yeah, this feature is not supported for language specific settings.
To verify: Open and have following snippetMake sure first two settings and are shown dimmed with proper message.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
/// Appends headers to response to maintain the secret storage of the workbench: /// sets the `PATH_COOKIE_VALUE` so workbench.ts knows about the 'mint' endpoint, /// and maintains the http-only cookie the client will use for cookies. <del> fn append_secret_headers(res: &mut Response<Body>, client_key_half: &SecretKeyPart) { </del> <ins> fn append_secret_headers( base_path: &str, res: &mut Response<Body>, client_key_half: &SecretKeyPart, ) { </ins> let headers = res.headers_mut(); headers.append( hyper::header::SET_COOKIE, <del> PATH_COOKIE_VALUE.parse().unwrap(), </del> <ins> format!( "{}={}{}; SameSite=Strict; Path=/", PATH_COOKIE_NAME, base_path, SECRET_KEY_MINT_PATH, ) .parse() .unwrap(), </ins> ); headers.append( hyper::header::SET_COOKIE,

Discussion:
The command was augmented with the argument here in Because the does not include the , any attempts to mint a key will result in a 404 if the server-base-path is set. I think this is the reason why I am experiencing an issue that any sign-in attempt in the browser (e.g., Github Copilot, Settings Sync) do not persist between page refreshes. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.1 OS Version: x64 Steps to Reproduce: the browser, observe 404s to
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
assigned to you since you approved the original PR
Change:
this._logService.debug('CommandDetectionCapability#handleContinuationEnd', this._currentCommand.continuations[this._currentCommand.continuations.length - 1]); } <ins> handleRightPromptStart(): void { this._currentCommand.commandRightPromptStartX = this._terminal.buffer.active.cursorX; this._logService.debug('CommandDetectionCapability#handleRightPromptStart', this._currentCommand.commandRightPromptStartX); } handleRightPromptEnd(): void { this._currentCommand.commandRightPromptEndX = this._terminal.buffer.active.cursorX; this._logService.debug('CommandDetectionCapability#handleRightPromptEnd', this._currentCommand.commandRightPromptEndX); } </ins> handleCommandStart(): void { this._currentCommand.commandStartX = this._terminal.buffer.active.cursorX;

Discussion:
Setup a right prompt in fish/zsh and make sure the command detected is accurate.
zsh uses for this, perhaps we should have a generic ignored ranges mechanism and combine this with the line continuation solution?
Change:
return { location: grammarLocation, <del> language: validLanguageId || undefined, </del> <ins> language: validLanguageId, </ins> scopeName: grammar.scopeName, embeddedLanguages: embeddedLanguages, tokenTypes: tokenTypes,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 89.1 x64 OS Version: Edition Windows 11 Pro Version 23H2 Installed on ‎2023-‎11-‎28 OS build .3593 Experience Windows Feature Experience Pack 1000..1003.0 Steps to Reproduce: the VS Code the introduction page of buildin plugin the FEATURES page 's Empty
I am seeing following !
Yes, I see the same. There should be details about supported languages like other built-in plugins.
Can you point me to the place I need to fix this?
Here it is
Change:
this.lastFocusedSettingElement = element.setting.key; this.settingsTree.reveal(element); })); <ins> this._register(this.settingsTreeRenderer.onDidClickOverrideElement((element: ISettingOverrideClickEvent) => { if (ConfigurationTargetToString(ConfigurationTarget.WORKSPACE) === element.scope.toUpperCase()) { this.settingsTargetsWidget.updateTarget(ConfigurationTarget.WORKSPACE); } else if (ConfigurationTargetToString(ConfigurationTarget.USER) === element.scope.toUpperCase()) { this.settingsTargetsWidget.updateTarget(ConfigurationTarget.USER); } this.searchWidget.setValue(element.targetKey); })); </ins> this.settingsTreeDataSource = this.instantiationService.createInstance(SimplePagedDataSource, this.instantiationService.createInstance(SettingsDataSource, this.viewState));

Discussion:
Issue Type: <bFeature Request</bTesting Just a thought: When I see "Modified in: Workspace" I might want to go there and check. I'd keep font and color as they are and add an underline and pointer cursor to "Workspace" on hover. VS Code version: Code - Insiders 1.27.0-insider (, 2018-08-29T05:12:15.247Z) OS version: Darwin x64 17.7.0 <!-- generated by issue reporter --
Good idea!
I would take a PR for this "Modified in: Workspace" - the word Workspace is underlined When clicked, it switches to the Workspace scope, and copies the setting key into the search bar, so the view is filtered to just that one setting
I'm interested in looking into this if that is alright.
Change:
alert(message: string): void { alert(message); } <ins> status(message: string): void { status(message); } </ins> }

Discussion:
Testing While testing I noticed that when I moved my cursor on a line with an error, the word was read, but the contents of that line were no longer read. I was wondering if this is intended? I noticed that sometimes the beginning of the text on the line is read, before it breaks off and reads the alerts.
I noticed that sometimes when I put my cursor on a line with a breakpoint, it does not read the word . Is the alert only supposed to sound at specific moments? Ie, for example the first time the cursor is placed on an active line with a breakpoint?
alerts interrupt whatever else might be read by design. And yes, it looks like in your case, you're using mouse clicks vs arrow keys to navigate between the lines. We listen to arrow keys, thus it's expected that you wouldn't hear the cues.
Additionally, I have checked with our power SR users and the alerts are working as expected in the editor.
I am going to open an issue to get more feedback on this.
Hi thank you for the clarification, that makes sense.
We are going to use instead here because editor content is the priority.
Change:
dom.clearNode(this._rootDomNode); this._disposableStore.clear(); this._lineNumbers.length = 0; <del> this._lastLineRelativePosition = state.lastLineRelativePosition; this._lineNumbers = state.lineNumbers; </del> <ins> const editorLineHeight = this._editor.getOption(EditorOption.lineHeight); const futureWidgetHeight = state.lineNumbers.length * editorLineHeight + state.lastLineRelativePosition; if (futureWidgetHeight > 0) { this._lastLineRelativePosition = state.lastLineRelativePosition; this._lineNumbers = state.lineNumbers; } else { this._lastLineRelativePosition = 0; this._lineNumbers = []; } </ins> this._renderRootNode(); }

Discussion:
Testing have a couple of lines in sticky scroll Focus sticky scroll scroll inside the file to a place that sticky scroll lines disappear scroll to a place that has sticky scroll lines again Observe: focus is lost. I would have expected that focus is kept.
Closing the issue since this is actually by design. Still I would have expected otherwise.
I am actually reopening it since I think the behavior is not good when scrolling using the scroll bar / minimap
Do the following: focus sticky scroll use the minimap to scroll to the top of the file whithout releasing the mouse Observe: sticky scroll disappears and focus is gone Scroll into the file again Observe: sticky scroll apprears without focus. I would have expected in this case that the focus is preserved since I never released the mouse button.
For the person who will be doing the verification, a regression has been found relating to the incorrect focusing of the sticky scroll which has already been fixed in the following PR: You may track its release through the corresponding issue: Please test once the other PR is released on insiders. In the meantime the label unreleased will be . Alternatively test on Code OSS.
Change:
display: block; padding: 0; box-sizing:	border-box; <ins> border-radius: 2px; </ins> /* Customizable */ font-size: inherit;

Discussion:
Looking at ways to make VS Code feel ever so slightly more approachable. A subtle 2px border radius on our common input components could be one way to make the UI feel more inviting and less harsh: <img width="361" alt="CleanShot 2022-04-08 at 14 48 52 src="https://user-"<img width="522" alt="CleanShot 2022-04-08 at 14 55 52 src="https://user-"<img width="494" alt="CleanShot 2022-04-08 at 14 58 01 src="https://user-"<img width="437" alt="CleanShot 2022-04-08 at 14 49 46 src="https://user-"<img width="500" alt="CleanShot 2022-04-08 at 15 01 55 src="https://user-"! FWIW, we already use a border radius on our icon buttons: <img width="300" alt="CleanShot 2022-04-08 at 15 03 36 src="https://user-"cc
I like this idea for buttons. I am not so sure about input/combo boxes.
I'm a +1 on this one, I think the inputs might need a bit of spacing from the side to feel more natural. We should also make sure that our labels are distinguishable as they start looking similar. Maybe we update the labels to be more pill-like?
As in padding L/R? I think they are indeed a bit different from our dropdowns if memory serves. Good call on the labels/tags.
Border-radius on buttons was merged but inputs is still under discussion so I'll keep this one open.
Good job
Change:
this._buttonElements.forEach(b => b.remove()); const groups = menu.getActions({ shouldForwardArgs: true }); <ins> let isPrimary: boolean = true; </ins> for (const group of groups) { const [, actions] = group; this._actions = actions; <del> actions.forEach(action => { const button = new Button(this.container); </del> <ins> for (const action of actions) { const button = new Button(this.container, { secondary: !isPrimary }); isPrimary = false; </ins> this._buttonElements.push(button.element); this._toDispose.add(button);

Discussion:
<img width="628" alt="image" src="https://user-"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width="306" alt="image" src="https://user-"
The "Go to Review" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?
Catching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width="423" alt="CleanShot 2022-04-18 at 09 09 03 src="https://user-"
Thanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.
Verified. I assume that Go to Review button is renamed to Start Review !
The Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.
Change:
private _commentEditor: SimpleCommentEditor | null = null; private _commentEditorDisposables: IDisposable[] = []; private _commentEditorModel: ITextModel | null = null; <del> private _editorHeight = STARTING_EDITOR_HEIGHT; </del> <ins> private _editorHeight = MIN_EDITOR_HEIGHT; </ins> private _isPendingLabel!: HTMLElement; private _timestamp: HTMLElement | undefined;

Discussion:
window a comment :bug: as you can see from the scrollbar, the comment text doesn't fill the full editor !
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
closedWith
Change:
} async writeElevated(windowId: number | undefined, source: URI, target: URI, options?: { unlock?: boolean }): Promise<void> { <del> const sudoPrompt = await import('sudo-prompt'); </del> <ins> const sudoPrompt = await import('@vscode/sudo-prompt'); </ins> return new Promise<void>((resolve, reject) => { const sudoCommand: string[] = [`"${this.cliPath}"`];

Discussion:
To recreate: Edit a file requiring sudo (eg ) When saving, VSCode will request sudo permissions and, after granting, gives the following error: I do NOT have Rosetta installed but understand VS Code is supposed to be M1 compatible. Here is the version info:
I cannot reproduce and I am on a M1 as well. thoughts? did you install the universal app?
For triggering we use a 3rd-party module which on macOS uses osascript saved as application bundle As a quick check, trigger a sudo prompt from vscode and open the OS temp directory and check for , following is the executable architecture So unless the user has rosetta installed this application will not be launched on M1 as reported here. you might have rosetta installed hence the failure was not seen, can be confirmed with
Not sure if that applet can be converted to universal, might also be worth looking at alternatives for sudo-prompt given that repo is now archived.
I would suggest to fork the module and convert that applet to universal if that is straightforward.
I don't see the source for the applet under the user repositories, will have to reach out to the author.
Maybe:
would you be able to test this scenario again from the following build that includes a potential fix:
Thanks for all your efforts on this (and . I discovered this on a new M1 Mac where I had not yet installed Rosetta but eventually caved in and installed it. Unfortunately it doesn't appear Rosetta can be easily uninstalled for testing. Happy to give this another go the next time I have a fresh Mac install but don't foresee that in the immediate future...
Verification on a mac with ARM chip without Rosetta 2 installed ([1]) use open try to edit (in the comment area!!!) from the error retry as sudo verify you get a prompt and save works [1] The presence of these files are a good indicator that you have Rosetta2 installed:
I take it you just re-compiled the applet for universal & updated the package with the base64 encoded string (is that right?)
yes! Here is what I did: decode the base64 encoded value unzip it open the apple script in apple script editor export it as application bundle (I have Rosetta 2 installed so it seems to export as universal bundle by default) zip it base64 encode it release as fork from
Change:
const stateToggles: IContentWidgetAction[] = []; if (state.input1) { <del> result.push(command(localize('remove', "$(error) Remove {0}", model.input1.title), async () => { </del> <ins> result.push(command(localize('remove', "Remove {0}", model.input1.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,

Discussion:
Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used—not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width="269" alt="CleanShot 2022-09-27 at 11 42 19 src="https://user-"<img width="244" alt="CleanShot 2022-09-27 at 11 43 33 src="https://user-"
I can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.
Why don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.