jiebi/CodeConvo huggingface dataset:
Change:
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-canvas@0.3.0-beta.23: version "0.3.0-beta.23" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.23.tgz#aa67f43114e0bd052311f3f88f842e85006e697f" integrity sha512-xFeuwK1ZuIl+5Go4ZesAWe+pToqjF0LSQfECia3tTZ0emkpzR3c+wU3vWoKPj71A7ZkgCVDmCGyLAWDpTSLgEQ== </del> <ins> xterm-addon-canvas@0.3.0-beta.26: version "0.3.0-beta.26" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.26.tgz#8c5665477d168f0c075960d9d86ae21afb3000c4" integrity sha512-33Btfufs6u8YsU8jmLlQfmmqavKGvP5s4Clxwq+KTT5DIlYDmt0r8GKdBHrB0AwNZiFRXsbPQoLF2XkHnkpTEw== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7"

Discussion:
Issue Type: <bPerformance Issue</bEver since I got this M1 mac with apple silicon, any scrolling I do in VSCode is super choppy and laggy. To reproduce it on my machine I just need to open an editor with a scrollbar or a terminal with some history and scroll quickly up and down. VS Code version: Code 1.69.2 (, 2022-07-18T16:32:39.000Z) OS version: Darwin arm64 21.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryProcess Info</summary</details<details<summaryWorkspace Info</summary</details<details<summaryExtensions (11)</summaryExtensionVersion ------ prettier-vscode9.5.0 go0.35.1 githd2.3.3 vscode-docker1.22.1 python2022.10.1 vscode-pylance2022.8.10 jupyter2022.6. jupyter-keymap1.0.0 jupyter-renderers1.0.9 vsliveshare1.0.5669 vscode-yaml1.9.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you do a performance profile in devtools (Help Toggle Developer Tools) and upload it here? !
Sure, attached.
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
There's an abnormal about of garbage collection in that profile which I've never seen before: !
what sort of monitor are you connected to? Could you also open devtools via the Help menu and run in the console? My guess is your font size is so large that the terminal's texture atlas is thrashing and redrawing all glyphs almost every frame.
Upstream issue tracking the texture cap problem:
This one can only be verified by the
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

I'll mark this issue as verified as part of . Please file a new issue if the bug continues to occur on the latest Stable and/or Insiders versions of VS Code.
Change:
const titleDiv = $('div.title').appendTo(container); const titleSpan = $('span').appendTo(titleDiv); const setHeader = () => { <del> const roots = this.contextService.getWorkspace2().roots; const title = roots.map(root => labels.getPathLabel(root.fsPath, void 0, this.environmentService)).join(); titleSpan.text(roots.length === 1 ? this.name : nls.localize('folders', "Folders")).title(title); </del> <ins> const workspace = this.contextService.getWorkspace2(); const title = workspace.roots.map(root => labels.getPathLabel(root.fsPath, void 0, this.environmentService)).join(); titleSpan.text(workspace.roots.length === 1 ? workspace.name : nls.localize('folders', "Folders")).title(title); </ins> }; this.toDispose.push(this.contextService.onDidChangeWorkspaceRoots(() => setHeader())); setHeader();

Discussion:
Today we show the workspace name it seems.
! What does "title" mean? 1 or 2?
2
It should be FOLDERS in multi root mode, and foldername_ otherwise, right?
Right
It behaves exactly in this way currently. I suppose this issue should be closed.
We should first ask if he can still repro this issue since is not seeing it, are tehre special repro steps
There are no special steps to repro this, so please confirm
!
I still cannot reproduce this. Also, your layout differs from mine - control buttons on the EXPLORER bar. Could you please explain, how I can switch VSCode into such a view?
I have "open editors" section disabled.
Change:
this.cachedHeight = height; this.splitview.layout(width); <del> this.list.layout(height - this.virtualDelegate.headerRowHeight, width); </del> <ins> const listHeight = height - this.virtualDelegate.headerRowHeight; this.list.getHTMLElement().style.height = `${listHeight}px`; this.list.layout(listHeight, width); </ins> } toggleKeyboardNavigation(): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: From sources !
That looks grid related to me.
Web bisect points out this commit range which includes the move to the new table widget: This seems to require the custom menu (Windows, Web) to reproduce.
fyi, not sure if anything within the keybindings editor could have caused this other than adopting the table widget.
Can also be reproduced by focusing the search input and then tabbing until the table is focused Created a PR fixing this.
Tagged this as candidate as the experience is bad with custom menu and it is a regression. As mentioned it can also be reproduced everywhere with following steps: Open Keybindings editor Focus search input Tab until table is focused Editor title bar is not visible
Change:
this._keybindings = keybindings; this._keybindingContext = keybindingContext; this._keybindingWeight = keybindingWeight; <del> this._descriptor = createSyncDescriptor(ctor, this._id, this._label); </del> <ins> this._descriptor = new SyncDescriptor(ctor, [this._id, this._label]) as unknown as SyncDescriptor0<Action>; </ins> } public get syncDescriptor(): SyncDescriptor0<Action> {

Discussion:
I a service injection dependency to some class and ended up with a very confusing TS error from a line that called . It turns out that you can't call it for a service with more than 8 dependencies because of how is defined. It's not a problem for me anymore because that function is barely used anywhere and I just changed to using the SyncDescriptor constructor directly. I wonder whether we should delete it or fix the definition of to have a definition that takes arbitrary #s of arguments, but I don't know what the intent of this code is. You touched this at some point maybe you know something about it.
This should be more or less adding one more of those. Tho, maybe there is newer, fancier ways in TS nowadays
That helper is only used in 1 place though. And we call directly in 200+ places. Just pointing that out too.
Assigning to who is that one user of 
What am I supposed to do?
Read this issue?
tldr; you are the only user of , either remove your usage or take ownership, e.g keep in line with its base class
I do not recall adding this method and it is outside of the history of GH, but it seems it so I let him decide to "either remove your usage or take ownership". The easiest is probably to inline it.
Change:
} } showLastProvider(id: AccessibleViewProviderId): void { if (!this._lastProvider || this._lastProvider.options.id !== id) { return;

Discussion:
!
In the chat view responses, users can hit on the link, so we will do the same here.
to verify: run an command that produces file links open the accessible view by focusing that chat response and using move your cursor to the link and press the file should be opened
Change:
* as normal. */ hideFromUser?: boolean; <ins> /** * A message to write to the terminal on first launch, note that this is not sent to the * process but, rather written directly to the terminal. This supports escape sequences such * a setting text style. */ message?: string; </ins> } /**

Discussion:
Proposal: Example use case: GitLens running a git command and when it fails, create a new terminal which includes the error message in the header and the failed command ready to be run manually. This is generally useful for other applications (eg. welcome to the blah debug terminal, this is how it works, ...) cc
<img width="725" alt="Screen Shot 2021-04-01 at 12 25 57 PM" src="https://user-"
This is in main, very little to do since was already an option internally. Will bring this to next API sync.
alternative names: message, placeholder, placeHolder
Will probably go with to match .
Proposed API TPI:
Code: Result: <img width="398" alt="Screen Shot 2021-05-04 at 6 36 08 AM" src="https://user-"
Change:
this.show(); return true; }, TerminalContextKeys.focus)); <del> this._register(_instance.onDidRunText(() => { </del> <ins> this._register(_instance.onDidExecuteText(() => { </ins> const focusAfterRun = _configurationService.getValue(TerminalSettingId.FocusAfterRun); if (focusAfterRun === 'terminal') { _instance.focus(true);

Discussion:
This configuration is probably pretty obscure (and I just had it due to testing) but: : , : the string into the terminal and shift+enter to get a newline buffer opens :bug:. The desc for says it's only after , so I don't think this is expected behavior (although I did just paste the selected text in the terminal manually).
did you happen to have enabled? that could explain what you describe, if so.
I don't have enabled.
Change:
.codeActionMenuWidget .monaco-list .monaco-list-row:hover:not(.option-disabled), .codeActionMenuWidget .monaco-list .moncao-list-row.focused:not(.option-disabled) { <ins> color: var(--vscode-menu-selectionForeground) !important; </ins> background-color: var(--vscode-menu-selectionBackground) !important; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Type: Bug Using editor.experimental.useCustomCodeActionMenu, the menu doesn't match up with the colors of enabled/disabled options or the background of the other context menus

Type: <bBug</bmenu the window Bug The widget ends up being incorrectly positioned: <img width="672" alt="Screen Shot 2022-07-21 at 1 24 17 PM" src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-21T05:17:20.056Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IMarkerService } from 'vs/platform/markers/common/markers'; import { IThemeService } from 'vs/platform/theme/common/themeService'; <del> import { IActiveNotebookEditor, ICellViewModel, INotebookEditor, type INotebookViewCellsUpdateEvent } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; </del> <ins> import { IActiveNotebookEditor, ICellViewModel, INotebookEditor } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; </ins> import { CellKind, NotebookCellsChangeType, NotebookSetting } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { INotebookExecutionStateService, NotebookExecutionType } from 'vs/workbench/contrib/notebook/common/notebookExecutionStateService'; import { OutlineChangeEvent, OutlineConfigKeys, OutlineTarget } from 'vs/workbench/services/outline/browser/outline';

Discussion:
Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro
a notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese
!
Thanks I can replicate this issue.
Giving the issue back to Aaron to verify. My Python install's a bit broken.

Testing open show outline and have sticky scroll enabled scroll the cell with "# Header " into view delete the cell :bug: the sticky scroll breaks, the error below is printed <img width="1482" alt="Screenshot 2024-04-23 at 08 51 18" src=""
I'm unable to repro this. Please can you share a screen recording of the steps. Perhaps recoding from opehning the notebook to selecting and deleting. Thanks.
Looking at the stacktrace tells me this is coming here which means the model had been already
following the steps above (empty profile) always reproduce the error (console) for me. The screen cheese shows in sticky scroll and/or other paces of the outline tree
Change:
const panelService = accessor.get(IPanelService); const fileService = accessor.get(IFileService); const configurationService = accessor.get(IConfigurationService); <del> const resources = resource && getMultiSelectedResources(resource, listService, accessor.get(IEditorService)); </del> <ins> const resources = getMultiSelectedResources(resource, listService, accessor.get(IEditorService)); </ins> return openSearchView(viewletService, panelService, configurationService, true).then(searchView => { if (resources && resources.length && searchView) {

Discussion:
Issue Type: <bBug</bIf I right-click on a folder in the explorer view and select 'Find in Folder' the search panel appears with the correct folder selected in the 'files to include' input. If I perform the keyboard shortcut to 'Find in Folder' with a folder selected, the search panel appears but the 'files to include' input does not have the selected folder. This is on a MacOS Mojave 10.14.4 VS Code version: Code - Insiders 1.33.0-insider (, 2019-03-29T10:48:35.896Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (56)</summaryExtensionVersion ------ rainbow-brackets0.0.6 html-snippets0.2.1 markdown-toc1.5.6 Bookmarks10.4.1 npm-intellisense1.3.0 sql-formatter1.0.2 vscode-markdownlint0.25.1 vscode-eslint1.8.2 githistory0.4.6 javadebugger0.1.5 gitlens9.5.1 EditorConfig0.13.0 graphviz-preview1.3.1 tslint1.0.43 vscode-npm-script0.3.5 prettier-vscode1.8.1 docker-explorer0.1.6 vscode-yarn1.6.0 vscode-javac0.2.16 vscode-pull-request-github0.5.1 gc-excelviewer2.1.29 docthis0.7.1 vscode-codemetrics1.18.0 javascript-test-runner1.0.0 dotenv1.0.1 python2019.3.6215 azure-account0.8.0 csharp1.18.0 Go0.9.2 debugger-for-chrome4.11.3 sqltools0.17.9 language-liquid0.1.1 printcode3.0.0 vetur0.17.1 vscode-jscpd0.3.4 vscode-docker0.6.1 quicktype12.0.46 java0.42.0 vscode-yaml0.4.0 RustyCode0.19.1 scala0.2.0 metals1.2.7 code-settings-sync3.2.7 dot0.

0.1 Align0.2.0 code-spell-checker1.6.10 unique-window-colors1.0.23 html-preview-vscode0.2.5 shellcheck0.6.0 sort-lines1.8.0 vscode-java-debug0.17.0 vscode-icons8.4.0 vscode-wakatime1.2.13 quokka-vscode1.0.200 vscode-todo-highlight1.0.4 change-case1.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.513 --- <!-- score: 0.509 --- <!-- score: 0.492 --- <!-- score: 0.49 --- <!-- score: 0.483 --<!-- potentialduplicatescomment --
Change:
private storage: StorageDatabase = Object.create(null); private lastSavedStorageContents = ''; <del> private readonly flushDelayer: ThrottledDelayer<void> | undefined; </del> <ins> private readonly flushDelayer = this._register(new ThrottledDelayer<void>(this.saveStrategy === SaveStrategy.IMMEDIATE ? 0 : 100 /* buffer saves over a short time */)); </ins> private initializing: Promise<void> | undefined = undefined; private closing: Promise<void> | undefined = undefined; constructor( private readonly storagePath: URI, <del> saveStrategy: SaveStrategy, </del> <ins> private readonly saveStrategy: SaveStrategy, </ins> private readonly logService: ILogService, private readonly fileService: IFileService, ) { super(); <del> this.flushDelayer = saveStrategy === SaveStrategy.IMMEDIATE ? undefined : this._register(new ThrottledDelayer<void>(100 /* buffer saves over a short time */)); </del> } init(): Promise<void> {

Discussion:
I noticed how we seem to be having a that is only used in : In that case we seem to not be using a for writing. But that will have pretty bad consequences because it can leave calls hanging even after . The unit test failure here actually shows it: I think this might have been introduced via
This strategy was introduced by I do not remember why we need immediate in server. I saw your change and I hope flush delayer for immediate should work.
I think the importance here is to always use the delayer, even when its with a delay of , because it was not only used to delay the saves, but also to aggregate them
Change:
) { super(listUser, container, delegate, renderers, options, contextKeyService, listService, configurationService, instantiationService); NOTEBOOK_CELL_LIST_FOCUSED.bindTo(this.contextKeyService).set(true); <del> this._viewContext = viewContext; </del> this._previousFocusedElements = this.getFocusedElements(); this._localDisposableStore.add(this.onDidChangeFocus((e) => { this._previousFocusedElements.forEach(element => {

Discussion:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.52: version "4.19.0-beta.52" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.52.tgz#87298cb205694cfdd701a9a96dcd06434a9773fe" integrity sha512-9s8VtGa9JUdEWxrNDJpEng2mEFn0KjWM3R9nxezA8mXHsJ/0cMqoK00s/fzhAEXZqHycWASSECMWgFOaT0MrnQ== </del> <ins> xterm-headless@4.19.0-beta.53: version "4.19.0-beta.53" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.53.tgz#bbcf2b9c3853fb96b642df6950d3b8fa37174be7" integrity sha512-o3Hbe9zT918IIfHlREhVQolTdXrdOmQKyHtVsfT9x2CG4Z3TaD6A5koX6P0cIoeVwP/dc3R/WBnbXLYl9B0Jiw== </ins> <del> xterm@4.19.0-beta.52: version "4.19.0-beta.52" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.52.tgz#21c7ad0bd905f3fddaa0583951514c8271dcd822" integrity sha512-2itY6dyiimOEkgVwc31TngYQ6npHt7or1wxU0Flbv4PjH4ke8K26NDB7KAi0YYkn2g0/qzIjQc7ykdrrTaEgMg== </del> <ins> xterm@4.19.0-beta.53: version "4.19.0-beta.53" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.53.tgz#ddb555e032d5ff3a1450d9c4b0250bc3e3ccac99" integrity sha512-WoJAux1FawCpgDBP9Gr5H+RQUY8H7djr+ZQTpD+D2A3nJTXmoHH5Q1lnu8XCsuPscjRAgqFSQCG+5oHQwBQIdA== </ins> y18n@^3.2.1: version "3.2.2"

Discussion:
Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification
Change:
} } <del> private async selectStep(id: string | undefined, delayFocus = true, forceRebuild = false) { if (id && this.editorInput.selectedStep === id && !forceRebuild) { return; } </del> <ins> private async selectStep(id: string | undefined, delayFocus = true) { if (id && this.editorInput.selectedStep === id) { return; } </ins> if (id) { let stepElement = this.container.querySelector<HTMLDivElement>(`[data-step-id="${id}"]`);

Discussion:
Type: <bBug</bContext changes causes images to flicker and, worse, quick picks to close. Run Open walkthrough Open step or Hit the button Quick pick closes right after clicking and image flashes. VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-08T05:22:25.379Z) OS version: Darwin x64 22.3.0 Modes: Sandboxed: Yes <!-- generated by issue reporter --
Seems as the context changes, which changes focus and closes the quick picks.
I can't repo this on OSS. But used the developer tools on insiders to debug it. fires the context changed event too many times which causes us to reload the media I removed rebuilding step if the step is already open which should fix the issue for the walkthroughs. But there is likely a larger issue to be fixed with the being fired too many times. You can turn off settings sync and try the steps described above - no repro.
Change:
TestResultState: extHostTypes.TestResultState, TestRunRequest: extHostTypes.TestRunRequest, TestMessage: extHostTypes.TestMessage, <del> TestMessage2: extHostTypes.TestMessage, </del> TestMessageStackFrame: extHostTypes.TestMessageStackFrame, TestTag: extHostTypes.TestTag, TestRunProfileKind: extHostTypes.TestRunProfileKind,

Discussion:
Currently, messages that are shown when tests fail can only be shown at a single . Often (, , among others) folks want to see the full call stack of the test failure. I propose some API to add this information:
does this track that not only the stack but stack + any stdout would show in same UX? /cc
Yes, output is already trackable and associable to a test case via the API
We are using to record all stdout written by tests. In addition, the is used to record the failure message and stack for each test failure.
UI:
Just check with Joh and this looks good to move into finalized!
do we want to bundle this with any of the other testing proposals (, )?