jiebi/CodeConvo huggingface dataset:
Change:
.quick-input-list .quick-input-list-entry .quick-input-list-entry-action-bar .action-label.always-visible, .quick-input-list .quick-input-list-entry:hover .quick-input-list-entry-action-bar .action-label, <del> .quick-input-list .monaco-list-row.focused .quick-input-list-entry-action-bar .action-label { </del> <ins> .quick-input-list .monaco-list-row.focused .quick-input-list-entry-action-bar .action-label, .quick-input-list .monaco-list-row.passive-focused .quick-input-list-entry-action-bar .action-label { </ins> display: flex; }

Discussion:
! I can click on them
Took a different approach with this... instead they are clickable, but they cause the list to scroll that separator up to the top (and they also clear focus).
Fixed in
Change:
@IInstantiationService private readonly instantiationService: IInstantiationService, @IEditorService private readonly editorService: IEditorService, @IStorageService storageService: IStorageService, <del> @IConfigurationService private readonly configurationService: IConfigurationService </del> <ins> @IConfigurationService private readonly configurationService: IConfigurationService, @IAccessibilityService private readonly accessibilityService: IAccessibilityService </ins> ) { super(KeybindingsEditor.ID, group, telemetryService, themeService, storageService); this.delayedFiltering = new Delayer<void>(300);

Discussion:
A11yWCAG2.1; #A11yTCS; #A11ySev4; #Visual Studio Code Client; #BMVisual Studio Code ClientMAC_JULY2024; #DesktopApp; #WCAG4.1.3; #FTP; #A11yMAS; #Status Message; #MAC; #Device; #Voiceover; #A11yUsable; MAC Book Pro MAC OS Sonoma Version 14.5 Visual Studio code Insider version 1.92.0 Visual Studio Code Insiders editor Navigate to setting icon. "Keyboard shortcuts options" and press enter or Press keyboard shortcut as command K, Command S shortcut table gets opened. till "Keyboard Shortcut Edit field". any Text or Key and Observe that Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Voiceover should be announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Screen reader users will face difficulty if Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".
do you know if we have ever had support for this?
Rev:poojanamde;
Decreasing to Sev4 according to Review of Indu Priya Setty. Thanks!!
Change:
} contentParent.classList.toggle('scrollable', outputScrolling); <del> contentParent.classList.toggle('word-wrap', ctx.settings.outputWordWrap); </del> <ins> outputElement.classList.toggle('word-wrap', ctx.settings.outputWordWrap); </ins> disposableStore.push(ctx.onDidChangeSettings(e => { <del> contentParent!.classList.toggle('word-wrap', e.outputWordWrap); </del> <ins> outputElement.classList.toggle('word-wrap', e.outputWordWrap); </ins> })); initializeScroll(contentParent, disposableStore, scrollTop);

Discussion:
[ ] Notebooks (.ipynb files) [X] Interactive Window and/or Cell Scripts (.py files with #%% markers)Turn on in Turn on in Open an interactive window and run the following code snippet Version: 1.89.0 Commit: Date: 2024-05-01T02:08:25.066Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Linux x64 6.8.0-76060800daily20240311-generic v2024.4.0 Python v3.12.1 No response No response Local
Change:
"cssnano": "^4.1.11", "debounce": "^1.0.0", "deemon": "^1.8.0", <del> "electron": "19.1.3", </del> <ins> "electron": "19.1.6", </ins> "eslint": "8.7.0", "eslint-plugin-header": "3.1.1", "eslint-plugin-jsdoc": "^39.3.2",

Discussion:
As part of chromium a runtime feature called AutoDisableAccessibility and it works like this: We should try out this flag to see how it affects our accessibility detection on macOS.
thanks a lot for this. Just as a refresh, this only affects macOS? fyi this change might affect our telemetry numbers - since now we might auto disable accessibility when chrome decides it is actually not being needed.
I have enabled it for all OS since there is no downside. As part of this, I also redid the accessibility event that gets fired from the runtime to work well with this feature flag. So, in endgame it would be good to have test plan that ensures our accessibility detection continues works fine on all OS.
ok, I can create a test plan item for that today with complexity 3. fyi
Created test plan item Feel free to edit it if you think I did not cover some scenario. Thanks!
Change:
}, }); })); <del> this._register(this.inputPart.onDidChangeHeight(() => this.bodyDimension && this.layout(this.bodyDimension.height, this.bodyDimension.width))); </del> <ins> this._register(this.inputPart.onDidChangeHeight(() => { if (this.bodyDimension) { this.layout(this.bodyDimension.height, this.bodyDimension.width); } this._onDidChangeContentHeight.fire(); })); </ins> this._register(this.inputEditor.onDidChangeModelContent(() => this.updateImplicitContextKinds())); this._register(this.chatAgentService.onDidChangeAgents(() => { if (this.viewModel) {

Discussion:
Repro: in inline chat: !
Oh it's a scroll shadow: !
We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on , where the community has already answered thousands of similar questions. You may find their helpful if your question has not already been asked. See also our . Happy Coding!
I blame it your theme. Inline chat isn't doing anything special here, tho we might wanna tweak the min size
The problem here is that the height of the chat widget inside the inline chat isn't correct and doesn't seem to be updated when the answer is streamed in. There is much more than 40% room available so it should show the full response. Also this is Dark Modern; the theme is fine it's the size: !
That's surprising. Notice how it works here until it reaches the max zone height
Must be related to the code block being replied with. But whatever I do I cannot get it to reply like that...
Ok, I can repro in a TS file with . Looks like the tree reports the wrong content height. Overall we measure 94px (for the input and tree) when in fact only the tree is 107px <img width="1272" alt="Screenshot 2024-03-22 at 16 37 16" src=""
Is editor rendering somehow async and should I ask for content height at some later point?
Change:
return elements.length === 1 ? elements[0].title : undefined; } <ins> onDragLeave() { this._autoFocusInstance = undefined; this._autoFocusDisposable.dispose(); this._autoFocusDisposable = Disposable.None; } </ins> onDragStart(data: IDragAndDropData, originalEvent: DragEvent): void { if (!originalEvent.dataTransfer) { return;

Discussion:
Repro: 2 terminals dragging one it into the actual terminal and pass over the other tab briefly, it will get focused even though the mouse didn't stay there for long enough !
Change:
dark: '#CCCCCC', hc: '#FFFFFF' }, nls.localize('terminal.foreground', 'The foreground color of the terminal.')); <ins> export const TERMINAL_CURSOR_FOREGROUND_COLOR = registerColor('terminalCursor.foreground', null, nls.localize('terminalCursor.foreground', 'The foreground color of the terminal cursor.')); export const TERMINAL_CURSOR_BACKGROUND_COLOR = registerColor('terminalCursor.background', null, nls.localize('terminalCursor.background', 'The background color of the terminal cursor. Allows customizing the color of a character overlapped by a block cursor.')); </ins> // TODO: Reinstate, see #28397 // export const TERMINAL_SELECTION_BACKGROUND_COLOR = registerColor('terminal.selectionBackground', { // 	light: '#000',

Discussion:
This involves adding a new theme key in and setting to right CSS class
We may want this in the recovery build since it's a regression that makes the cursor char unreadable /cc
Change:
/* COLLAPSED (SMALLER THAN NARROW) */ .monaco-editor .find-widget.collapsed-find-widget { <del> max-width: 111px !important; </del> <ins> max-width: 170px !important; </ins> } .monaco-editor .find-widget.collapsed-find-widget .button.previous,

Discussion:
Issue Type: <bBug</ban editor the find widget the editor size so that it is quite narrow Bug Find widget has overlapping elements: <img width="442" alt="screen shot 2018-10-02 at 1 48 52 pm" src="https://user-"VS Code version: Code 1.28.0 (, 2018-10-04T16:40:40.180Z) OS version: Darwin x64 18.0.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I still see this in !
Verified from source
Change:
use async_trait::async_trait; use shell_escape::windows::escape as shell_escape; <ins> use std::os::windows::process::CommandExt; </ins> use std::{ path::PathBuf, process::{Command, Stdio}, }; <ins> use winapi::um::winbase::{CREATE_NEW_PROCESS_GROUP, DETACHED_PROCESS}; </ins> use winreg::{enums::HKEY_CURRENT_USER, RegKey}; use crate::{

Discussion:
opens in a window instead of running in background. I have seen , which introduced this behavior. For me, means . Console window breaks it completely. If the window is closed - service is gone, what shouldn't happen. I understand that there were reasons about changing service behavior to ordinary application. However, I would really like service-like functionality back for my remote development. It's perfectly fine if this would be an additional installation flag. That would keep current easy behavior and allow for unattended installs. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.2 (System) OS Version: Windows 11 22H2 Steps to Reproduce:
Sorry, misread. Will look at that
I believe this issue is only partially fixed, even in . The window does not appear when only or (the cli) is running, however, as soon as a tunnel is connected to, a window appears (as code- is run). If the user closes the window, the tunnel connection is dropped. I believe the fix is to pass to creationflags in as seen here: However, without the proprietary "mixin" , it seems my builds of code cli are not able to properly run code-server, failing with To reproduce the issue, on a windows machine: an arbitrary tunnel to authorize the machine: the tunnel with the code at the tunnel service with connect to the tunnel again a on the desktop, close it and observe the tunnel disconnect on
Change:
}); } exports.config = { <del> version: product.electronRepository ? '22.4.4' : util.getElectronVersion(), </del> <ins> version: product.electronRepository ? '22.4.5' : util.getElectronVersion(), </ins> productAppName: product.nameLong, companyName: 'Microsoft Corporation', copyright: 'Copyright (C) 2023 Microsoft. All rights reserved',

Discussion:
The Angular language service extension spawns a child process using and listens for the and events. The current version works as expected. Without any changes to the project, simply updating to results in the forked child process acting differently (never erroring and never closing). I'm using Mac 13.3.1 but we also had a report that the forked process isn't working in WindowsNT x64 10.0. either. There was a similar issue (though not entirely the same) a while back: Apologies for the rather involved reproduction... Here's how I'm able to reproduce and compare the behavior between the versions: our the repository with vscode insider version 1.78.0-insiders out the branch (we're actually removing this in the next version so it doesn't exist on ) dependencies with debugging, put a debugger statement before and one in the . The project is built with bazel so breakpoints would have to be put in the compiled JS files. the build script with the extension development host (Dev Client + Server run configuration) In the extension host, open the and then open the template file -- debugger should stop on the fork and if you continue, you will see that the debugger stops in the stderr data listener but never in the or . The output of the stderr also indicates that it is listening for a debugger and that it gets attached. The fork used which should have prevented this. The process also never produces any results or completes. You can have the fork retry by running the Angular: Restart Angular Language server command in the extension host. I've also verified that the spawn args are the same between versions and both include "--ms-enable-electron-run-as-node".
Issue was caused by the allocator changes to processes which now schedule delayed tasks to purge memory cache ;l=1183 and that revealed a bug in the causing the process to hang.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
class RemoteViewPaneContainer extends FilterViewPaneContainer implements IViewModel { private helpPanelDescriptor = new HelpPanelDescriptor(this); helpInformation: HelpInformation[] = []; <ins> private _onDidChangeHelpInformation = new Emitter<void>(); public onDidChangeHelpInformation: Event<void> = this._onDidChangeHelpInformation.event; </ins> private hasSetSwitchForConnection: boolean = false; constructor(

Discussion:
Steps to Reproduce: remote explorer and view help links ( etc) under the viewlet for existing remote extensions. additional remote extensions and view the help link options again. Expected: links for the newer extensions show up in the lists. Actual: does not change. and reopening updates the list.
Change:
let regex = rule.regex; let regexSource = rule.regex.source; if (regexSource.substr(0, 4) === '^(?:' && regexSource.substr(regexSource.length - 1, 1) === ')') { <del> regex = new RegExp(regexSource.substr(4, regexSource.length - 5), regex.ignoreCase ? 'i' : ''); </del> <ins> let flags = (regex.ignoreCase ? 'i' : '') + (regex.unicode ? 'u' : ''); regex = new RegExp(regexSource.substr(4, regexSource.length - 5), flags); </ins> } let result = line.search(regex);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Feature request for the Monaco Editor. Create an optional flag for Monaco Monarch language definitions to indicate the usage of unicode-aware regular expressions. An example of one such regular expression is , matching the '' character.
What exactly does not work? Since you can pass in regular expressions directly e.g.
Hi, What's currently not working is the unicode-aware regular expressions supported by ES2015. Even though you're able to write a RegExp including unicode-aware characters (in the format ), and even set the unicode flag for that RegExp, they don't work in Monaco Monarch at the moment. Below is the monaco-language file for ABAP, edited to support the character in identifiers. ! This is how it shows up in the editor: ! That happens precisely because the unicode flag is stripped away by compileRegExp, causing the match to fail for that character: If we change that line to, say it works as expected: ! The proposed solution is a way for the developer to tell Monaco Monarch that, instead of stripping away the unicode flag from all the regular expressions, it should instead add it to all the regular expressions if a flag is set in the language definition, just like it's the current behavior for the option. Another option I've considered was to instead use the unicode flag if, and only if, it is set in the regular expression itself, but from what I could gather, that would force us to compile the RegExp an extra time just for testing the flag, or to parse the RegExp manually. Let me know if you need more information.
:+1: Thank you, this makes good sense!
Change:
@ICommandService private readonly commandService: ICommandService, @IQuickInputService private readonly quickInputService: IQuickInputService, @IWorkspaceTrustRequestService private readonly workspaceTrustRequestService: IWorkspaceTrustRequestService, <del> @IUriIdentityService private readonly uriIdentityService: IUriIdentityService </del> <ins> @IUriIdentityService private readonly uriIdentityService: IUriIdentityService, </ins> ) { this.breakpointsToSendOnResourceSaved = new Set<URI>();

Discussion:
Repro: a (TS) debug session (F5) on "Restart extensions" button in Extensions explorer - :bug: <img width="483" alt="image" src=""Expected behavior options: ideal: resume debug session ask the user if it's okay for them to interrupt debug session and not show error notification ?
We can't generally do this because the debug session can be owned+managed by stateful code in the extension. Resuming the debug session requires starting it anew which would launch any program again, behavior that could be surprising to users.
In core, you can also veto restarting extensions if there is a live debug session
Thanks, I'll have the session gracefully shut down when the extension host is restarted. Will tackle in debt week.
Change:
private logMessageInput = ''; private breakpoint: IBreakpoint | undefined; private context: Context; <ins> private heightInPx: number; </ins> constructor(editor: ICodeEditor, private lineNumber: number, private column: number | undefined, context: Context | undefined, @IContextViewService private readonly contextViewService: IContextViewService,

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: -- isn't fixed <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.37.0 OS Version: Windows 10 !
This works just fine for me on OS X and Win10 with vscode insiders. Can you reproduce with latest vscode insiders !
Thanks. I tried and it is indeed fixed in the insider build. However, I can reproduce it for sure on the stable version. The fix should have been included in June update. (seems it was)
There might be some extension which you are using that is modiyfing css and is breaking this. Sorry but I can not reproduce this, either in stable and in insiders. Also no other user seems to be hitting this. Due to that I will close this issue. And yes the fix was included in the June update.
I find the key to reproduction now. Just put in the and you will see the bug.
Yes I acknowledge the bug. The issue is that the breakpoint widget is not updating as the editor font updates. The size of the widget updates, but the font should update as well. I am open to PR that fix this issue Code pointer
Will have a try
Things look more complicated than we expected.  doesn't feel right. The is of 40px height (with font size set to 16) ! It looks more reasonable if setting the height to 20px ! centering thing. The is centred by the styles of (its parent dom) while gets a hardcoded 8px ... !
yes I acknowledge it is not the nicest. Any improvements in that area would be appreciated.
I have gone too deep down the rabbit hole . Leaving it to whoever interested...
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details . If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our and guidelines. Thanks for your understanding and happy coding!

I understand this issue is not that important. But I don't agree this is out of scope . IMHO, it is at least a bug (although with very low priority).
Agree, let's reopen.
Attempted a PR () for this. Please have a look.
Verifier: Change the editor.fontSize, add a conditional breakpoint and make sure the text in the breakpoint widget is centered. Or can just try in VS COde insiders from Thursday and let us know how it behaves for him
Thank you! I confirm it is fixed in the insider build.
Thanks for letting us know. Adding verified label.
Change:
import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { createDecorator, IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; <del> import { registerColor } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { inputActiveOptionBackground, registerColor } from 'vs/platform/theme/common/colorRegistry'; </ins> registerColor( 'actionBar.toggledBackground', <del> { dark: '#383a49', light: '#dddddd', hcDark: '#383a49', hcLight: '#dddddd', }, </del> <ins> { dark: inputActiveOptionBackground, light: inputActiveOptionBackground, hcDark: inputActiveOptionBackground, hcLight: inputActiveOptionBackground, }, </ins> localize('actionBar.toggledBackground', 'Background color for toggled action items in action bar.') );

Discussion:
Testing <img width="273" alt="image" src=""Should use a toggle state instead, or a new icon. You can see it looks the same as the other disabled action
I agree, but then this also applies to the "toggle whitespace" button. I think we need some pressed state for toolbar buttons. What are your thoughts ?
I'd prefer to have an icon per state. That's how we have done it in other toolbars (like output scroll lock).
<img width="584" alt="image" src=""Mockup with a toggled state. Having an icon per state makes sense for the lock icon, because the reverse icon metaphors make intuitive sense. This is not the case for the whitespace and fold icon here though. cc
We do use toggles elsewhere. One easy example: <img width="472" alt="CleanShot 2023-07-07 at 09 13 11 src=""But I think it depends what you're trying to do. Many boolean settings make sense as a sort of enabled/disabled toggle, while others are more specific metaphors (lock/unlock as Hylke mentioned above).
I'm still in favor of a toggle border as we already use this concept in the find widget and it is a universally understood concept, but has to agree. Alternatively, we can explore other icons. Or we leave it as is.
No, I don't need to agree (but also not to like it). If you wanna explore or something similar go ahead but we should be aware that this is also open to extensions, so we need to deal with every (contributed) button looking like this in the future
I think this approach looks good to me It is more aligned with the vs code current design and should be replaced the current find widget toggle ui
Verification steps: Notice that in the diff editor buttons have a background now to indicate their toggled state: !