jiebi/CodeConvo huggingface dataset:
Change:
this._commentThreadWidget.submitComment(); } <del> _refresh(dimensions?: dom.Dimension) { if (this._isExpanded && dimensions) { </del> <ins> _refresh(dimensions: dom.Dimension) { if (dimensions.height === 0 && dimensions.width === 0) { this.commentThread.collapsibleState = languages.CommentThreadCollapsibleState.Collapsed; return; } if (this._isExpanded) { </ins> this._commentThreadWidget.layout(); const headHeight = Math.ceil(this.editor.getOption(EditorOption.lineHeight) * 1.2);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Our users want to see which comments need to be worked on next. During a review round there might be some comments which are not actionable anymore as their threads got resolved. For better overview we think it is valuable to be able to expand only all unresolved (and therefore actionable) comments. Since we can't use anymore to do this from our extension. Reading there is no intention in bringing back this functionality. Introducing commands like (and probably also ) could be a way bring back some control over comment collapsed state to the extension without the need for extension to directly. cc
Tentatively adding for February.
The new command is "Comments: Expand Unresolved Comments".
To verify: Open a workspace with unresolved comments (a PR with comments using the GitHub Pull Requests and Issues extension works well for this). Collapse some comments in the editor. Run "Comments: Expand Unresolved Comments" and verify that all unresolved comments are expanded.
If a comment is already collapsed when I open the file, the command "Expand Unresolved Comments" doesn't work repro: an unresolved comment the current tab the tab again run the command - the comment is not expanded https://user-
good find! Will be fixed in the next insiders build.
Change:
// Escape codes // http://en.wikipedia.org/wiki/ANSI_escape_code const EL = /x1Bx5B[12]?K/g; // Erase in line <del> const LF = /xA/g; // line feed </del> const COLOR_START = /x1b[d+m/g; // Color const COLOR_END = /x1b[0?m/g; // Color export function removeAnsiEscapeCodes(str: string): string { if (str) { str = str.replace(EL, ''); <del> str = str.replace(LF, 'n'); </del> str = str.replace(COLOR_START, ''); str = str.replace(COLOR_END, ''); }

Discussion:
VSCode Version: 1.5.3 (commit ) OS Version: Ubuntu Linux 14.04 Steps to Reproduce: some code that prints the characters to the output window. are incorrectly turned into a newline. F# Code: Output: This has already been reported as , but that bug was incorrectly closed as "working as designed" because it was assumed that the code in (I couldn't trace it further back than that). The character sequence is not the ANSI escape for a linefeed/newline; in fact, , since ANSI just uses the single character for that purpose. It's pretty clear, looking at the code, that that's what was the regex was intended to be set to in the lines just above the : it is set to . However, is actually an invalid Javascript hex escape. The specifies that must be followed by two hex digits, because otherwise the sequences (U+0007 BELL) and (U+000C FORM FEED) would be ambiguous. So is an invalid sequence, and is instead interpreted by Javascript as the character followed by the character (the backslash is swallowed). So the correct fix to bug is actually to replace that regex with . Then one could notice that the code immediately below is replacing all occurrences of with , which is a no-op since is . So the regex and the line serve no purpose but to slow things down by spending O(N) time doing a no-op regex search. They can safely be removed without affecting any other code, and this would actually speed things up a fraction.
fyi
Yup, we should look into this and fix
might you be interested into doing a PR that fixes this since you have already done this great analysis? If not, we can follow your analysis to do the changes you proposed. Thanks either way!
Sure, why not? Here's the PR. Do you need me to sign a code licensing agreement of some kind before it can be merged in? If so, let me know how. UPDATE: Oh, I see that MSBOT replied on the PR's comment thread. I'm not surprised that no CLA is required for a commit that removed two lines and none.
Change:
import { IEditorWorkerService } from 'vs/editor/common/services/editorWorker'; import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; import { ITextModelService } from 'vs/editor/common/services/resolverService'; <del> import { FormattingMode, formatDocumentWithSelectedProvider, getDocumentFormattingEditsUntilResult } from 'vs/editor/contrib/format/browser/format'; </del> <ins> import { FormattingMode, formatDocumentWithSelectedProvider, getDocumentFormattingEditsWithSelectedProvider } from 'vs/editor/contrib/format/browser/format'; </ins> import { Action2, MenuId, registerAction2 } from 'vs/platform/actions/common/actions'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';

Discussion:
Related: Looking into reports of X formatter being used instead of Y in various flows. Looking at both on save and on execution formatting participants, one common point is that when is specifically being used, the intended formatter is applied as expected. Some early digging is pointing to a use of instead of , so will be working out a fix there. Will update this thread as is relevant.
do you have some minimal verif steps?
Verification Steps: Install Black Formatter + Ruff Create with only the following:create notebook with a single code cell, and contents In Stable () Save Notebook Black formatter runs =nothing changes Ruff formatter runs =Single quotations turned to double quotations () In Insiders () Save Notebook ONLY Black formatter runs =nothing changes

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a "Formatting with autopep8" message in the status bar even though that formatter extension isn't installed! However manually triggering "Format Cell" does use black.
Change:
this._editorContainer.style.height = `${editorHeight}px`; this._register(this._editor.onDidContentSizeChange((e) => { <ins> if (this._editorLayoutInProgress) { return; } </ins> if (e.contentHeightChanged && this.cell.layoutInfo.editorHeight !== e.contentHeight) { this.cell.editorHeight = e.contentHeight; }

Discussion:
a change to the file and save, do not commit the diff view from the SCM view up and down in the notebook diff view :cheese: see cell metadata area skittering on screen (the recording below does not capture how frequently the skittering actually happens) https://user-
Just ran into this again: https://user-
I opened for that, I think we can actually just reopen this one
This issue should be gone now since we fixed the horizontal bar issue.
Change:
import { localize } from 'vs/nls'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; <del> import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; </del> <ins> import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> import { IContextViewDelegate, IContextViewService } from 'vs/platform/contextview/browser/contextView'; import { IInstantiationService, createDecorator } from 'vs/platform/instantiation/common/instantiation'; import { IOpenerService } from 'vs/platform/opener/common/opener';

Discussion:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
], "main": "./client/out/jsonMain", "scripts": { <del> "compile": "gulp compile-extension:json-language-features-client && gulp compile-extension:json-language-features-server", </del> <ins> "compile": "gulp compile-extension:json-language-features-client compile-extension:json-language-features-server", "watch": "gulp watch-extension:json-language-features-client watch-extension:json-language-features-server", </ins> "postinstall": "cd server && yarn install", "install-client-next": "yarn add vscode-languageclient@next" },

Discussion:
testing : Yes, there is now a warning icon in the status bar, but it is difficult to understand its purpose: For a json scheme url with a non-existing hostname the hover message shows this: ! For a json scheme url with a non-existing version number the hover message shows this: ! In both cases the error shown is too low-level and the message does not explain that the status refers to the json scheme of the current editor contents.
FYI
Looks like I misinterpreted what kind of messages I'd get from the backend, sorry for that! We could resort to showing a generic message like 'Unable to resolve JSON schema from (url)', which would probably be sufficient for most issues. I also considered logging the error to console (don't know your policy on that), but if we get whole pages in the error message, that's not an option. Displaying a generic message with the URL only would also Otherwise I guess we'd need to parse the error message to find out which kind and display a meaningful message, but that doesn't seem right. Another implication of this is that we'll probably have to re-add at least one layer of error description to vscode-languageservice-json - I always had a prefix with something like "Unable to resolve (something)", but that might have been a code reloading issue or specific to the way I was testing, by cutting the Internet connection and blocking DNS resolutions. Let me know if a generic error message defined only in the client would work.
That's fine. Users don't really see logs.
I can repro with this setting:
Change:
let viewletRestoreStopWatch: StopWatch; let viewletIdToRestore: string; if (!this.sideBarHidden) { <ins> this.sideBarVisibleContext.set(true); </ins> if (this.shouldRestoreLastOpenedViewlet()) { viewletIdToRestore = this.storageService.get(SidebarPart.activeViewletSettingsKey, StorageScope.WORKSPACE);

Discussion:
Currently there is no way to tell if sidebar is visible. You can get the state only for 2/5 viewlets. Explorer: Search: Source Control: Debug: Extensions: Sidebar (any of the above is visible):
PR that fixes this is welcome. Code pointer Basicaly the part service would need to add new context key and set it when sidebar gets shown / hidden. I propose to call this context key .
Change:
}; }; <del> readonly experimental: { readonly validate: { readonly enabled: true; readonly referenceLinks: { readonly enabled: ValidateEnabled; }; readonly fragmentLinks: { readonly enabled: ValidateEnabled; }; readonly fileLinks: { readonly enabled: ValidateEnabled; readonly markdownFragmentLinks: ValidateEnabled; }; readonly ignoreLinks: readonly string[]; </del> <ins> readonly validate: { readonly enabled: true; readonly referenceLinks: { readonly enabled: ValidateEnabled; </ins> }; <ins> readonly fragmentLinks: { readonly enabled: ValidateEnabled; }; readonly fileLinks: { readonly enabled: ValidateEnabled; readonly markdownFragmentLinks: ValidateEnabled; }; readonly ignoredLinks: readonly string[]; </ins> }; }; }

Discussion:
Add some form of error reporting for links in markdown files where we are confident that link is incorrect. Example: We should also have a setting to disable this error reporting since we will not be able to understand every flavor of markdown link
Bad references (seems like this should almost always be a reasonable error to report) Missing files (false positive if users rely on different logic to resolve markdown paths) - Missing headers (false positive if users rely on custom slugifier or are linking to something besides headers, such as html elements) -Checking links to external resources () Checking html in markdown
Re-opening as we will likely keep this as experimental this iteration
Change:
constructor() { super({ id: 'cursorUndo', <del> label: nls.localize('cursor.undo', "Soft Undo"), alias: 'Soft Undo', </del> <ins> label: nls.localize('cursor.undo', "Cursor Undo"), alias: 'Cursor Undo', </ins> precondition: undefined, kbOpts: { kbExpr: EditorContextKeys.textInputFocus,

Discussion:
There is a command called "cursorUndo", which undo's cursor and selection movements. In the command palette it is called "Soft Undo". I think the name in the command palette should be changed from "Soft Undo" to "Cursor Undo". This will make the command more discoverable, and more intuitive for users to figure out what it does. When I found this command in the command palette, I tried typing "hello" and then using it, but it did nothing, because the cursor hasn't moved since the last edit. I had to google it to figure out what the command does. Even though the command also undo's selection changes and not just cursor movements, I think "cursor" is a general term the refers to both "cursor" and "selection". Also, the command name itself is already "cursorUndo", it makes sense for the name in the command palette to use the same term. Having "cursor" in the command's name will make it clear it undo's things that the cursor does, such as moving and selecting text. A user that will find this command in the command palette will most likely attempt to move the cursor and then use the command, and then will understand what it does. VSCode Version: 1.38.1 OS: Windows
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.552 --<!-- potentialduplicatescomment --
This issue is different than the suggested duplicates.
I have made a PR fixing this.
Even the post and comments when it was named "Soft Undo" agree it should have the word "cursor" or "selection" -
Now that command was merged (PR ) it also should have its label renamed from "Soft Redo" to "Cursor Redo".
Change:
import { combinedDisposable } from 'vs/base/common/lifecycle'; import { checkProposedApiEnabled, ExtensionIdentifierSet, isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; import { DebugConfigurationProviderTriggerKind } from 'vs/workbench/contrib/debug/common/debug'; <del> import { equalsIgnoreCase } from 'vs/base/common/strings'; </del> import { IExtHostTelemetryLogService } from 'vs/workbench/api/common/extHostTelemetryLogService'; export interface IExtensionRegistries {

Discussion:
continues We need to ping extensions that use the old extension id and then remove the workaround we
These are the extensions that use the old extension identfier [ ] byted-ide.gallery - no issue tracker? [ ] Apex- - not in market place [ ] Goldman-Sachs.secview-extension - not in market place [x] - [ ] juliencroain.private-extension-manager - [x] -
Can you help with the first three extensions?
I will email since they are on the marketplace. We have no way to reach the second and third. So I suggest to go ahead and break them, and once things stop working they will ideally reach out to us and we can then advise them on how to update their extensions.
Change:
} })); <ins> // Reset widget height so it's recalculated templateData.inputWidgetHeight = InputRenderer.DEFAULT_HEIGHT; </ins> // Rerender the element whenever the editor content height changes const onDidChangeContentHeight = () => { const contentHeight = templateData.inputWidget.getContentHeight();

Discussion:
Steps to Reproduce: to a folder/workspace with multiple repositories the Source Control viewlet, and in the Source Control Repositories view select one repository to the Explorer viewer back to the Source Control viewlet and in the Source Control Repositories view pick another repository <img width="538" alt="image" src=""the Refresh button renders the input with the correct height
Change:
list.focusNextPage(fakeKeyboardEvent); list.reveal(list.getFocus()[0]); } <ins> // Ensure DOM Focus ensureDOMFocus(focused); </ins> } });

Discussion:
I like the up / down keyboard navigation over notebook cells, but when you try to use to navigate the order is very unexpected. a notebook. I am using my- my work cell -Focus is on GitHub issues label -focus seems lost -focus is on the start of the document, even though I did not traverse until the end of the docuemnt Ideally tab should go in visual order. If that is not possible should move focus out of the notebook. Similarly tree tab is not used to move focus so users use up / down, but pressing tab focuses out of the tree and does not lead to unexpected jumping of focus.
Fixed in this change Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell (step 3 in OP) Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in )
Much better now. Thanks for fixing this.
Change:
unset VSCODE_ENV_APPEND fi <ins> # Shell integration was disabled by the shell, exit without warning assuming either the shell has # explicitly disabled shell integration as it's incompatible or it implements the protocol. if [ -z "$VSCODE_SHELL_INTEGRATION" ]; then builtin return fi </ins> # The property (P) and command (E) codes embed values which require escaping. # Backslashes are doubled. Non-alphanumeric characters are converted to escaped hex. __vsc_escape_value() {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Extension version: 2024.1. VS Code version: Code 1.86.0 (, 2024-01-31T10:27:46.147Z) Opening on behalf of , and Steps to Reproduce: environment variable PATH in environment collection with using options: of in zsh, notice how appears exactly once despite prepending it twice environment variable PATH in environment collection with the same value using options: of in zsh Notice how the value is not prepended, both of them which suggests that automatic shell integration fails to prepend to . Relevant details: <details </summary<p</p</detailsShell integration is activated according to screenshot: !
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Btw, both 633 and 133 shell integration sequences were not reported via the terminal data write event, so automatic shell integration may not be working, despite saying it's activated?
Yes, exactly this is happening on my system!
Since shell integration is getting activated, but the sequences are not coming through, the only thing I can imagine is that somewhere within our script, there's an error getting thrown so it exits before our sequences are put into place. I see that you have powerlevel 10k sourced within your . does commenting out these lines fix it?

reminded me that powerlevel 10k will disable our shell integration script from running by design as there were problems with the interplay of that and our shell integration.
We should be good to move the env stuff above the p10k exit to fix this problem:
Verified via code review
Change:
})); disposables.add(vscode.commands.registerCommand('github.copyVscodeDevLink', async () => { <del> try { const permalink = getPermalink(gitAPI, 'https://vscode.dev/github'); if (permalink) { vscode.env.clipboard.writeText(permalink); } } catch (err) { vscode.window.showErrorMessage(err.message); } </del> <ins> return copyVscodeDevLink(gitAPI, true); })); disposables.add(vscode.commands.registerCommand('github.copyVscodeDevLinkFile', async () => { return copyVscodeDevLink(gitAPI, false); </ins> })); return disposables;

Discussion:
Testing Of course, there may have been discussions and reasons for the current behavior, but I was surprised that the share action in the File menu linked to the line number of the currently opened editor. I was expecting a link to the workspace/repository only.
would you expect the same command from the editor context menu to use file+line number?
yes, my expectation would be the context menu has the "context" and therefore does have the file/line associated with it.