jiebi/CodeConvo huggingface dataset:
Change:
return true; } <del> if (testUrlMatchesGlob(url.toString(), trustedDomains[i])) { </del> <ins> if (testUrlMatchesGlob(url, trustedDomains[i])) { </ins> return true; } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: out of GitHub if you are logged in a trusted domain rule for GitHub Repos extension or something else, start a Login for GitHub Notice that you get prompted to allow this URL as a trusted domain No prompt This is because () doesn't handle query parameters well... and thinks they are part of the path when validating. You can see this behavior by adding a at the end of in the Trusted Domains. We should really ignore query parameters and fragments here.
Change:
Package: @@NAME@@ Version: @@VERSION@@ Section: devel <del> Depends: libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1 </del> <ins> Depends: libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1, libgbm1 </ins> Priority: optional Architecture: @@ARCHITECTURE@@ Maintainer: Microsoft Corporation <vscode-linux@microsoft.com>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2- -1.49.0- OS Version: Ubuntu 20.04.1 LTS Steps to Reproduce: -dev not installed and install code1.48.2- --VSCode works apt update; apt-upgrade VSCode to 1.49.0- --VSCode fails with: /usr/share/code/bin/../code: error while loading shared libraries: cannot open shared object file: No such file or directory install libgbm-dev --VSCode works Expected: upgrade checks for dependency and installs missing library
new Electron 9 dep needs to be declared here?
I didn't know about this dependency configuration in the codebase, yes adding should be sufficient. It is a new dependency for chromium 83 to use memory buffers in gpu code path.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Tested this by upgrading from 1.48.2 to 1.50.1
Change:
data.lensActionsViewZoneIds?.forEach(viewZoneAccessor.removeZone); data.lensActionsViewZoneIds = undefined; <del> lensActions?.dispose(); </del> }); <ins> lensActions?.dispose(); </ins> overlay?.dispose(); };

Discussion:
have a code block in panel chat select Apply in Editor notice accept, discard, toggle lenses switch to another file (in the same editor group) :bug: the lenses are still there
Change:
if (this.isSimpleWidget) { commandDelegate = { paste: (source: string, text: string, pasteOnNewLine: boolean, multicursorText: string[]) => { <del> this.cursor.trigger(source, editorCommon.Handler.Paste, { text, pasteOnNewLine, multicursorText }); </del> <ins> this.trigger(source, editorCommon.Handler.Paste, { text, pasteOnNewLine, multicursorText }); </ins> }, type: (source: string, text: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.Type, { text }); </del> <ins> this.trigger(source, editorCommon.Handler.Type, { text }); </ins> }, replacePreviousChar: (source: string, text: string, replaceCharCnt: number) => { <del> this.cursor.trigger(source, editorCommon.Handler.ReplacePreviousChar, { text, replaceCharCnt }); </del> <ins> this.trigger(source, editorCommon.Handler.ReplacePreviousChar, { text, replaceCharCnt }); </ins> }, compositionStart: (source: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.CompositionStart, undefined); </del> <ins> this.trigger(source, editorCommon.Handler.CompositionStart, undefined); </ins> }, compositionEnd: (source: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.CompositionEnd, undefined); </del> <ins> this.trigger(source, editorCommon.Handler.CompositionEnd, undefined); </ins> }, cut: (source: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.Cut, undefined); </del> <ins> this.trigger(source, editorCommon.Handler.Cut, undefined); </ins> } }; } else {

Discussion:
a debugging session (assume JS for next step) in debug repl widget should appear, but does not.
cc
thanks for fixing this! Works great now, adding verified label
Change:
} } <ins> // Activity bar cannot be hidden // This check must be called after state is set // because canActivityBarBeHidden calls isVisible if (this.stateModel.getRuntimeValue(LayoutStateKeys.ACTIVITYBAR_HIDDEN) && !this.canActivityBarBeHidden()) { this.stateModel.setRuntimeValue(LayoutStateKeys.ACTIVITYBAR_HIDDEN, false); } </ins> // Window border this.updateWindowBorder(true); }

Discussion:
After updating I see this: ! After some investigation with we found that it's cause by this line in : Which calls into: Which calls in to which accesses state. This is only initialized later in the method though. Rough repro based on memory: 1 (Windows): Update client to latest 1: Set activity bar to top 1: Sync 2 (macOS, old client): Sync (pulls in activity bar top setting?) 2: Update to latest 2: Open client
Thanks for the fix. I got report of this bug from some users and I am asking for developer tools console log (thanks
Change:
]; } <ins> public focusTabsView(): void { this._terminalTabsFocusContextKey.set(true); this._tabsWidget.domFocus(); } </ins> public focusFindWidget() { this._findWidgetVisible.set(true); const activeInstance = this._terminalService.getActiveInstance();

Discussion:
This would be useful since we can now navigate the tabs via the keyboard, so you could hit <keybinding, up n times, enter to focus that terminal.
Also it's a little tough to tell which split pane is actually focused right now, perhaps some extra visual hint?
Opening to double check what the ideal keybinding would be on each platform
Let's go with ctrl/cmd+shift+ for this, to align with 's navigate tabs keybinding.
Change:
".hintrc", ".babelrc" ], <ins> "filenames": [ ".ember-cli" ], </ins> "configuration": "./language-configuration.json" } ],

Discussion:
Issue Type: <bBug</bThe file has an incorrect language association by default ( instead of ). The has comments, so there are red squiggly lines when you open this file until you change the language to . VS Code version: Code 1.51.1 (, 2020-11-10T23:34:32.027Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.19.128-microsoft-standard Remote OS version: Linux x64 4.19.128-microsoft-standard Remote OS version: Linux x64 4.19.128-microsoft-standard <details<summarySystem Info</summary </details<details<summaryExtensions (2)</summaryExtensionVersion ------ remote-wsl0.51.3 vscode-eslint2.1.13 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.714 --- <!-- score: 0.534 --- <!-- score: 0.492 --<!-- potentialduplicatescomment --
Change:
} } <del> private _bindCellContentHandler(cell: NotebookCellTextModel, e: 'content' | 'language' | 'mime') { </del> <ins> private _bindCellContentHandler(cell: NotebookCellTextModel, e: 'content' | 'language' | 'mime' | { type: 'model'; event: IModelContentChangedEvent }) { </ins> this._increaseVersionId(e === 'content'); switch (e) { case 'content':

Discussion:
Testing 1) I started with 2) I ran the first two cells and then committed 3) I reran cell 1 4) I changed cell 3 to use different file names 5) I opened the notebook diff from the SCM view -(a) cell metadata changes were shown -(b) changes to cell 3 where hidden -(c) toggling the "Toggle Collapse Unchanged Regions" didn't do anything !
I was unable to reproduce (b) reliably.
Verifier: Make the workbench small enough so when opening only the first cells show up Run the first two cells Commit/stage the file Scroll to the last cell, make changes, save (if you don't have auto save) Open the diff view, the change in the last cell should be rendered.
cannot test this due to
Change:
await this.clipboardService.writeText(keybinding.keybindingItem.command); } <del> private async copyKeybindingCommandTitle(keybinding: IKeybindingItemEntry): Promise<void> { </del> <ins> async copyKeybindingCommandTitle(keybinding: IKeybindingItemEntry): Promise<void> { </ins> this.selectEntry(keybinding); this.reportKeybindingAction(KEYBINDINGS_EDITOR_COMMAND_COPY_COMMAND_TITLE, keybinding.keybindingItem.command, keybinding.keybindingItem.keybinding); await this.clipboardService.writeText(keybinding.keybindingItem.commandLabel);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: v1.60.0-insider OS Version: Windows 10 Steps to Reproduce: "Copy Command Title" in the Keyboard Shortcuts editor. result shows up. Since other menu items for a single command all have an associated command ID, it would be inconsistent to leave "Copy Command Title" out: !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.462 --- <!-- score: 0.45 --<!-- potentialduplicatescomment --
can I work on this feature request?
It might be too early to create this PR as this is a backlog candidate but created it anyway.
Thanks!
Since it's inconsistent with other menu items in the keybindings editor, it could be considered as a bug, I've updated the issue to reflect that. Voting to move to the Backlog is too much trouble for just adding a simple command ID, please just move it, as we know it may never make it into the Backlog by voting, not to mention it has a PR already. !
Change:
// OCaml-style { link: '"foo", line 339, character 12', prefix: '"', suffix: '", line 339, character 12', hasRow: true, hasCol: true }, <del> { link: '"foo", line 339, characters 12-14', prefix: '"', suffix: '", line 339, characters 12-14', hasRow: true, hasCol: true, hasColEnd: true }, </del> <ins> { link: '"foo", line 339, characters 12-789', prefix: '"', suffix: '", line 339, characters 12-789', hasRow: true, hasCol: true, hasColEnd: true }, </ins> { link: '"foo", lines 339-341', prefix: '"', suffix: '", lines 339-341', hasRow: true, hasCol: false, hasRowEnd: true }, <del> { link: '"foo", lines 339-341, characters 12-14', prefix: '"', suffix: '", lines 339-341, characters 12-14', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </del> <ins> { link: '"foo", lines 339-341, characters 12-789', prefix: '"', suffix: '", lines 339-341, characters 12-789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> // Non-breaking space { link: 'foou00A0339:12', prefix: undefined, suffix: 'u00A0339:12', hasRow: true, hasCol: true },

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --When working on Haskell code, may produce error output in the following format: It would be nice to have terminal link detection support for this format (or, to discard the part and just jump to the start column). Currently, this format seems to trip up the parser: it detects the file, line number, and start column correctly, but then it seems to select backwards to near the start of the file. (Note: ghcid seems to treat the end column index as inclusive, i.e. the cursor is before the last notable character.)
Can reproduce: ! Selects from 1:3 to 115 !
What is detected:
Caused by a bad regex match: !
Change:
import { DisposableStore } from 'vs/base/common/lifecycle'; import { isRemoteDiagnosticError, IRemoteDiagnosticError } from 'vs/platform/diagnostics/common/diagnostics'; import { MainProcessService } from 'vs/platform/ipc/electron-sandbox/mainProcessService'; <ins> import { CodiconLabel } from 'vs/base/browser/ui/codicons/codiconLabel'; </ins> const DEBUG_FLAGS_PATTERN = /s--(inspect|debug)(-brk|port)?=(d+)?/; const DEBUG_PORT_PATTERN = /s--(inspect|debug)-port=(d+)/;

Discussion:
Noticed how the process explorer is bundling and still. Can we not use Codicons for this? //cc
Oh this seems to be used in the issue reporter, not process explorer. But not sure how to actually see it...
are we actually using these icons? I'm not seeing it: !
it looks like these are only used when VSCode is connected to a remote to show the remote processes as well. I didn't even know we had that, pretty cool: ! Anyhow, my request still seems valid.
PR up at !
Change:
[/^(t|[ ]{4})[^ ].*$/, markdownTokenTypes.TOKEN_BLOCK], // code block (3 tilde) <del> [/^s*~{3}s*((?:w|[/-])+)?s*$/, { token: markdownTokenTypes.TOKEN_BLOCK, next: '@codeblock' }], </del> <ins> [/^s*~{3}s*((?:w|[/-#])+)?s*$/, { token: markdownTokenTypes.TOKEN_BLOCK, next: '@codeblock' }], </ins> // github style code blocks (with backticks and language) <del> [/^s*```s*((?:w|[/-])+)s*$/, { token: markdownTokenTypes.TOKEN_BLOCK, next: '@codeblockgh', nextEmbedded: '$1' }], </del> <ins> [/^s*```s*((?:w|[/-#])+)s*$/, { token: markdownTokenTypes.TOKEN_BLOCK, next: '@codeblockgh', nextEmbedded: '$1' }], </ins> // github style code blocks (with backticks but no language) [/^s*`{3}s*$/, { token: markdownTokenTypes.TOKEN_BLOCK, next: '@codeblock' }],

Discussion:
Some Markdown dialects support specifying the language when using triple backticks (c# using System; public class Program { private static DateTime Today = DateTime.Now; } Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam eget ante dapibus, egestas leo nec, convallis ligula. Proin tempor augue fermentum ex rhoncus, eget faucibus purus vehicula. Suspendisse cursus auctor quam, non tristique odio lacinia vel. Pellentesque cursus neque posuere vestibulum aliquam. Nam lacus odio, suscipit vel consequat sagittis, auctor nec nisl. Maecenas ac justo nunc. Aenean efficitur aliquam odio, sit amet consequat nisi congue at. Suspendisse pellentesque enim non tortor bibendum, ac posuere justo iaculis. Nullam vulputate diam non justo tempus aliquet vitae non turpis. </preThis is displayed as follows: ! One can clearly see that the parsing breaks down after handling the code section.
Hm, I suspect the issue here is the trailing # for C#, does it work when you pick "csharp" instead?
Yes, that's it. Changing it to "csharp" fixes the problem. edit: PR is a bit over my head at the moment :)
Change:
// Commands can get exeucted from a command pallete, from a context menu or from some list using a keybinding // To cover all these cases we need to properly compute the resource on which the command is being executed <del> export function getResourceForCommand(resource: URI | object, listService: IListService, editorService: IEditorService): URI | null { </del> <ins> export function getResourceForCommand(resource: URI | object | undefined, listService: IListService, editorService: IEditorService): URI | null { </ins> if (URI.isUri(resource)) { return resource; }

Discussion:
Issue Type: <bBug</bIf I right-click on a folder in the explorer view and select 'Find in Folder' the search panel appears with the correct folder selected in the 'files to include' input. If I perform the keyboard shortcut to 'Find in Folder' with a folder selected, the search panel appears but the 'files to include' input does not have the selected folder. This is on a MacOS Mojave 10.14.4 VS Code version: Code - Insiders 1.33.0-insider (, 2019-03-29T10:48:35.896Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (56)</summaryExtensionVersion ------ rainbow-brackets0.0.6 html-snippets0.2.1 markdown-toc1.5.6 Bookmarks10.4.1 npm-intellisense1.3.0 sql-formatter1.0.2 vscode-markdownlint0.25.1 vscode-eslint1.8.2 githistory0.4.6 javadebugger0.1.5 gitlens9.5.1 EditorConfig0.13.0 graphviz-preview1.3.1 tslint1.0.43 vscode-npm-script0.3.5 prettier-vscode1.8.1 docker-explorer0.1.6 vscode-yarn1.6.0 vscode-javac0.2.16 vscode-pull-request-github0.5.1 gc-excelviewer2.1.29 docthis0.7.1 vscode-codemetrics1.18.0 javascript-test-runner1.0.0 dotenv1.0.1 python2019.3.6215 azure-account0.8.0 csharp1.18.0 Go0.9.2 debugger-for-chrome4.11.3 sqltools0.17.9 language-liquid0.1.1 printcode3.0.0 vetur0.17.1 vscode-jscpd0.3.4 vscode-docker0.6.1 quicktype12.0.46 java0.42.0 vscode-yaml0.4.0 RustyCode0.19.1 scala0.2.0 metals1.2.7 code-settings-sync3.2.7 dot0.

0.1 Align0.2.0 code-spell-checker1.6.10 unique-window-colors1.0.23 html-preview-vscode0.2.5 shellcheck0.6.0 sort-lines1.8.0 vscode-java-debug0.17.0 vscode-icons8.4.0 vscode-wakatime1.2.13 quokka-vscode1.0.200 vscode-todo-highlight1.0.4 change-case1.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.513 --- <!-- score: 0.509 --- <!-- score: 0.492 --- <!-- score: 0.49 --- <!-- score: 0.483 --<!-- potentialduplicatescomment --
Change:
"when": "scmProvider == git" }, { <ins> "command": "git.stageAllMerge", "group": "5_stage", "when": "scmProvider == git" }, { </ins> "command": "git.unstageAll", "group": "5_stage", "when": "scmProvider == git"

Discussion:
Issue Type: <bBug</bDuring a rebase (not sure if that's the only scenario), my SOURCE CONTROL tab display three sections, MERGE CHANGES, STAGED CHANGES and CHANGES. If I click the + button on the CHANGES section, in order to stage all items below CHANGES, VS Code also adds everything on MERGE CHANGES. VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-29T05:33:59.143Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ markdown-mermaid1.5.0 better-toml0.3.2 vscode-eslint2.1.5 gitlens10.2.1 plantuml2.13.8 svg1.1.8 vscode-peacock3.7.0 chat0.33.0 rust-analyzer0.2.151 vscode-todo-parser1.9.1 remote-wsl0.44.2 vsliveshare1.0.2104 vsliveshare-audio0.1.85 vsliveshare-pack0.3.4 vscode-xml0.11.0 vscode-yaml0.7.2 crates0.4.9 vscode-hexdump1.7.2 markdown-all-in-one2.8.0 </details<!-- generated by issue reporter --
Hello I would like to work on this issue if no one else is. Regards.
hey could you please review the pr that I have opened and also could you please suggest any changes if required.
Hi I'm also working on this issue. You can check my PR
I have gone through your PR also left a comment.
Change:
// Conpty could have the wrong cursor position at this point. if (!this._cursorOnNextLine() || !prompt) { this._windowsPromptPollingInProcess = true; <del> // Poll for 200ms until the cursor position is correct. </del> <ins> // Poll for 1000ms until the cursor position is correct. </ins> let i = 0; <del> for (; i < 20; i++) { await timeout(10); </del> <ins> for (; i < 50; i++) { await timeout(20); </ins> prompt = this._getWindowsPrompt(); if (this._store.isDisposed || !this._windowsPromptPollingInProcess || this._cursorOnNextLine() && prompt) { if (!this._windowsPromptPollingInProcess) {

Discussion:
Repro: (maybe not needed?) terminal some text, note the cursor location an editor the terminal, the cursor is at the start of the textbox !
Works on mac
It also works for me on Windows
any other steps required?
I think the repro is fill the viewport such that there's a scroll bar, then type
Ctrl+c helps make it happen too
Some other repros too: ! ! !
I'm hitting this: Looking into it
Change:
const diffRemoveIcon = registerIcon('diff-remove', Codicon.remove, nls.localize('diffRemoveIcon', 'Line decoration for removals in the diff editor.')); const ttPolicy = window.trustedTypes?.createPolicy('diffEditorWidget', { createHTML: value => value }); <ins> const ariaNavigationTip = nls.localize('diff-aria-navigation-tip', ' use Shift + F7 to navigate changes'); </ins> export class DiffEditorWidget extends Disposable implements editorBrowser.IDiffEditor { private static readonly ONE_OVERVIEW_WIDTH = 15;

Discussion:
Diff editor is not accessible unless the user uses the F7 / Shift + F7 experience. We should make this more discoverable to the users. For example the aria label of a diff editor should at the end append "use F7 / shift + F7 to navigate changes" fyi
assigning to you and removing the milestone since this might be a good win and something that is within our reach. Namely the diff editor is not that accessible unless users use the experience to navigate between changes. So we should make this more discoverable by potentially mentioning it in the aria label of the diff editor.
Verify that when you are using a screen reader and enter a diff editor, you're informed about using shift + F7 navigation
Change:
}; if (cursors.length === 2 && inMirrorMode) { <ins> /** * Both cursors are positions */ </ins> if (event.selections[0].isEmpty && event.selections[1].isEmpty) { if ( prevCursors.length === 2 &&

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: macOS Steps to Reproduce: See the following gif: ! I first enter the tag which activates multicursor, then I use the key combi to select and jump to the end of the line, go one back and use "Backspace" to delete the attribute. This is a common operation, but now with mirror cursors it might break the HTML as seen in the gif above. Moreover, if the opening & closing tag are further apart, one might not even notice the HTML is broken. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Also this quite a lot as this is a very common operation. Related to this is ctrl+shift selecting out of the element tag name. I'd like to work on. The fix would be to exit mirror mode if the selection is not empty and we reach a none-matching state.
This also brings up an issue when you try to add an attribute to multiple tags that have none. ! If you click the open tag, it'll select the opening and closing, and usually when you're at the end and you press space to type in the attribute it doesn't add the attributes to the closing tag, but when you're adding more cursors to the tags in other lines, it doesn't act like that anymore and adds the attributes to both tags. I went crazy trying to find this to disable it.
Yeah looking at the current implementation, there's no support at all for multiple cursors. That's gonna take some work for the behavior to work correctly.
This feature doesn't work well with extension vim too, have to shut it down.
The fix will be available in until next month's release.