jiebi/CodeConvo huggingface dataset:
Change:
* Actions */ <del> // Configure Workspace Trust </del> <ins> // Configure Workspace Trust Settings </ins> const CONFIGURE_TRUST_COMMAND_ID = 'workbench.trust.configure'; const WORKSPACES_CATEGORY = { value: localize('workspacesCategory', "Workspaces"), original: 'Workspaces' };

Discussion:
<img width="368" alt="CleanShot 2022-07-18 at 08 28 16 src="https://user-""Configure" and "Manage" are really similar to each other and I had a hard time knowing which one opened what, which caused me to open the wrong one. "Configure" opens the settings UI with a query, and "Manage" opens a custom editor. My proposal would be to change "Configure Workspace Trust" to "Workspace Trust Settings" to make it explicit.
I'd actually like to tweak your proposal to "Manage Trusted Workspaces" and "Configure Workspace Trust Settings"
Change:
export const FIND_IDS = { StartFindAction: 'actions.find', <ins> StartFindWithSelection: 'actions.findWithSelection', </ins> NextMatchFindAction: 'editor.action.nextMatchFindAction', PreviousMatchFindAction: 'editor.action.previousMatchFindAction', NextSelectionMatchFindAction: 'editor.action.nextSelectionMatchFindAction',

Discussion:
VSCode Version: Code 1.17.2 (, 2017-10-16T13:47:41.889Z) OS Version: Darwin x64 17.0.0 Extensions: ExtensionVersion ------ unity-tools0.1.9 unity-debug1.2.1 vscode-eslint1.3.2 python0.7.0 cpptools0.14.0 csharp1.12.1 mono-debug0.15.7 vscode-arduino0.2.9 Steps to Reproduce: the user setting "": false, text in a document command-e command-f Expected results: VS Code matches the standard Mac text find behavior, where command-e populates the search pasteboard with the current selection, but doesn't show the find panel. Pressing command-f thereafter shows the find panel, revealing what I put in there with command-e. Actual results: pressing command-e shows the find panel and doesn't populate the search pasteboard Plx to allow me to match the macOS standard behavior! Is my favest! <!-- Launch with to check. --Reproduces without extensions: Yes
Change:
height: 40px; right: 25px; bottom: 25px; <del> background-color:#444444; </del> <ins> background-color:var(--vscode-button-background); </ins> border-radius: 50%; cursor: pointer; box-shadow: 1px 1px 1px rgba(0,0,0,.25);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello Guys, Add a new Feature in the theme to Change the Color of the Scroll to Top while reading any Extension's Readme. Because Default Blue Color Does not match some Theme's. <br<brExample:- "extensionButton.scrolltotop": "#"; !<br<br
We don't need a new theme key specifically for this. Instead it should use one of the existing ones, likely the ones for buttons
hello! Can I work on this issue? Maybe we can using existing one , or create new color setting for these buttons.
Change:
if (modifiedBaseRange.isConflicting) { blockClassNames.push('conflicting'); } <del> const inputClassName = this.inputNumber === 1 ? 'input 1' : 'input 2'; </del> <ins> const inputClassName = this.inputNumber === 1 ? 'input i1' : 'input i2'; </ins> blockClassNames.push(inputClassName); if (!modifiedBaseRange.isConflicting && !showNonConflictingChanges && isHandled) { continue; } <ins> if (useSimplifiedDecorations && !isHandled) { blockClassNames.push('use-simplified-decorations'); } </ins> result.push({ range: range.toInclusiveRangeOrEmpty(), options: {

Discussion:
Note all three lines highlighted with background color <img width="262" alt="CleanShot 2022-09-08 at 16 01 57 src="https://user-"We only highlight the changed line and specific word. <img width="184" alt="CleanShot 2022-09-08 at 16 02 04 src="https://user-"If we followed the inline style and still rendered a word diff, wouldn't we be able to get away without using the borders to indicate the region? cc
The inline style does this because it has no clue about the actual conflict, it just sees the conflict markers. We do this to show the actual change in that side.
I a hidden setting (default false) so we can play with idea. Personally, I think it hides many important decorations, but I'm open to exploring it. Enabled: ! Disabled: ! The background color disappears when the conflict is handled.
Change:
vscode.workspace.textDocuments.forEach(document => { if (document.uri.scheme === 'markdown') { // update all generated md documents <del> provider.update(document.uri); </del> <ins> contentProvider.update(document.uri); </ins> } }); });

Discussion:
It's very hard to navigate a large markdown file, such as our release notes. Outline information would be very helpful, let's do this!
See
Change:
return quickPickItems; } <ins> private _toQuickPick(kernel: INotebookKernel, selected: INotebookKernel | undefined) { const res = <KernelPick>{ kernel, picked: kernel.id === selected?.id, label: kernel.label, description: kernel.description, detail: kernel.detail }; if (kernel.id === selected?.id) { if (!res.description) { res.description = localize('current1', "Currently Selected"); } else { res.description = localize('current2', "{0} - Currently Selected", res.description); } } return res; } private _fillInSuggestions(quickPickItems: QuickPickInput<KernelQuickPickItem>[], suggestions: INotebookKernel[], selected: INotebookKernel | undefined) { if (!suggestions.length) { return; } if (suggestions.length === 1 && suggestions[0].id === selected?.id) { quickPickItems.push({ type: 'separator', label: localize('selectedKernels', "Selected") }); // The title is already set to "Selected" so we don't need to set it again in description, thus passing in `undefined`. quickPickItems.push(this._toQuickPick(suggestions[0], undefined)); return; } quickPickItems.push({ type: 'separator', label: localize('suggestedKernels', "Suggested") }); quickPickItems.push(...suggestions.map(kernel => this._toQuickPick(kernel, selected))); } </ins> private async _showInstallKernelExtensionRecommendation( notebookTextModel: NotebookTextModel, quickPick: IQuickPick<KernelQuickPickItem>,

Discussion:
Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width="601" alt="image" src="https://user-"This can be simplified as a single "Selected" group at the very top <img width="601" alt="image" src="https://user-"
Change:
if (!this.raw.element || this._webglAddon) { return; } <ins> // Check if the the WebGL renderer is compatible with xterm.js: // - https://github.com/microsoft/vscode/issues/190195 // - https://github.com/xtermjs/xterm.js/issues/4665 // - https://bugs.chromium.org/p/chromium/issues/detail?id=1476475 if (!XtermTerminal._checkedWebglCompatible) { XtermTerminal._checkedWebglCompatible = true; const checkCanvas = document.createElement('canvas'); const checkGl = checkCanvas.getContext('webgl2'); const debugInfo = checkGl?.getExtension('WEBGL_debug_renderer_info'); if (checkGl && debugInfo) { const renderer = checkGl.getParameter(debugInfo.UNMASKED_RENDERER_WEBGL); if (renderer.startsWith('ANGLE (Google, Vulkan 1.3.0 (SwiftShader Device (Subzero)')) { this._disableWebglForThisSession(); return; } } } </ins> const Addon = await this._getWebglAddonConstructor(); this._webglAddon = new Addon(); this._disposeOfCanvasRenderer();

Discussion:
Type: <bBug</bOpen terminal. Start typing. Note the noticeable delay in the text rendering on screen even though the cursor advances. In fact some timess the text never renders. Makes the terminal pretty unusable. VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-10T05:33:20.243Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ togglehs0.1.2 vscode-eslint2.4.2 githistory0.6.20 gitlens2023.8.1005 dotnet-test-explorer0.7.8 copilot1.101.325 copilot-chat0.7. vscode-mojom0.1.4 mojom-language0.0.1 vscode-clangd0.1.24 csharp2.0.328 vscode-dotnet-runtime1.6.0 python2023.15. vscode-pylance2023.8.21 remote-wsl0.81.0 cpptools1.17.1 powershell2023.6.0 vscode-jest5.2.3 clang-format1.9.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
does changing help?
Yes. It apparently was set to auto previously. If it turn it to "off" the issue goes away.
repro's for me with set to or . does not repro for or gif: !
I can't reproduce this unfortunately
I still have a consistent repro if you want me to try anything or collect diagnostics.
Findings from looking at it together: It repro'd in Code - OSS It did not repro in xterm demo It did not repro in Code - OSS with symlinked webgl addon It repro'd after running scripts/update-xterm
I'm going to manually look through all the code that went in around rendering ~1-2 weeks ago to see if I can spot something.
Maybe it's related to Chromium.
Upstream bug filed at , thanks to
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verified on Linux
verified on windows
Change:
type InputData = { uri: Uri; title?: string; detail?: string; description?: string }; const mergeUris = toMergeUris(uri); <del> const ours: InputData = { uri: mergeUris.ours, title: localize('Yours', 'Yours') }; const theirs: InputData = { uri: mergeUris.theirs, title: localize('Theirs', 'Theirs') }; </del> <ins> const current: InputData = { uri: mergeUris.ours, title: localize('Current', 'Current') }; const incoming: InputData = { uri: mergeUris.theirs, title: localize('Incoming', 'Incoming') }; </ins> try { const [head, rebaseOrMergeHead] = await Promise.all([

Discussion:
Currently in merge conflict and in the SCM view we talk about and changes, but the new Merge Editor talks about and -- IMO we should align to the and terms.
The opener of the merge editor is in control of the labels. Thus, this can easily be changed in the git extension. Incoming and Current makes sense for conflicts when merging in a remote branch, but not when applying stashes (though in that case "Theirs" and "Mine" also doesn't make much sense).
I always just think of it as there are always changes (from a merge, stash, etc) that are being incorporated (incoming) into the current state.
Change:
content: ')'; } <del> .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code.code-link > .code-label { </del> <ins> .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code > .code-label, .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code > .monaco-link { </ins> display: none; } <del> .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code.code-link > .monaco-link { </del> <ins> .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code.code-label > .code-label { </ins> display: inline; <del> text-decoration: underline; </del> } <del> .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code > .monaco-link { display: none; </del> <ins> .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .code.code-link > .monaco-link { display: inline; text-decoration: underline; </ins> } .markers-panel .markers-table-container .monaco-table .monaco-list-row .monaco-table-tr > .monaco-table-td > .file > .file-position {

Discussion:
Issue Type: <bBug</bTesting I have Code Spell Checker () extension provides diagnostics without error code, and rust-analyzer extension provides diagnostics with error code. When all diagnositcs don't have code, it displays correctly. When some diagnostics have code and some don't, scroll over the Problems value, some code changes randomly. https://user- VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-29T05:20:28.364Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ Bookmarks13.3.0 remotehub0.35. remote-containers0.241.1 remote-ssh0.83. remote-ssh-edit0.80.0 remote-wsl0.66.3 remote-repositories0.12.0 material-icon-theme4.18.1 material-theme3.15.2 toml0.6.0 rust-analyzer0.4.1110 code-spell-checker2.2.5 </details<!-- generated by issue reporter --
Change:
font-size: 14px; line-height: 36px; padding-left: 20px; <del> border-bottom: 1px solid rgba(136, 136, 136, 0.45); box-sizing: border-box; </del> <ins> border-bottom: 1px solid var(--vscode-panelSection-border); </ins> } .extension-editor > .body > .navbar > .monaco-action-bar > .actions-container { justify-content: initial; } <del> .extension-editor > .body > .navbar > .monaco-action-bar > .actions-container > .action-item > .action-label { margin-right: 16px; font-size: inherit; opacity: 0.7; </del> <ins> .extension-editor > .body > .navbar > .monaco-action-bar > .actions-container > .action-item { height: 100%; </ins> } .extension-editor > .body > .navbar > .monaco-action-bar > .actions-container > .action-item > .action-label { <ins> padding: 0 10px; font-size: 11px; font-weight: normal; color: var(--vscode-panelTitle-inactiveForeground); text-transform: uppercase; </ins> background: none !important; <ins> border-radius: 0px !important; </ins> } .extension-editor > .body > .navbar > .monaco-action-bar > .actions-container > .action-item > .action-label.checked { <del> opacity: 1; text-decoration: underline; </del> <ins> border-bottom: 1px solid var(--vscode-panelTitle-activeBorder); color: var(--vscode-panelTitle-activeForeground); </ins> } .extension-editor > .body > .navbar > .monaco-action-bar > .actions-container > .action-item > .action-label:hover { <del> text-decoration: underline; </del> <ins> color: var(--vscode-panelTitle-activeForeground); </ins> } .extension-editor > .body > .content {

Discussion:
On Insiders to an extension detail page to the actionbar that has entries like Details, Feature Contributions, etc. :bug: The focus outline is cut off at the top !
This one-off tab UI drives me a little bit bananas. how possible is it to use the same tab component that we use for the bottom panel to avoid the entropy here?
I'm not sure about the code involved, but it seems like a good idea to reuse the component. The Settings editor also currently has a one-off tab UI.
Change:
__vsc_command_output_start() { builtin printf "033]633;C007" <ins> builtin printf "033]633;E;$__vsc_current_command007" </ins> } __vsc_continuation_start() {

Discussion:
This is a follow up from which worked around the majority case of an issue. See the workaround: The proper fix will involve sending both the exit code and the history ID over to VS Code which will then do what's happening now but also have the correct exit code to set, instead of assuming it's the last command's exit code. We should write a little script as part of this that alternates exit codes by setting/unsetting an environment variable so it's easier to test and verify.
The issue being worked around is actually caused by or being included in .
Good test case from
To verify: some commands , they should all show up in current session ctrl+c in between some commands, including typing out a command and hitting ctrl+c to abandon it , the lines with ctrl+c shouldn't show up several times, failed and success should match whether the exception was thrown.
Change:
disturl "https://nodejs.org/dist" target "18.15.0" <del> ms_build_id "223745" </del> <ins> ms_build_id "229541" </ins> runtime "node" build_from_source "true"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A (remote extensions are needed) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.0 (Universal) and 1.82.0-insider (Universal) OS Version: MacOS 13.3.1 (22E261) [Ventura] Steps to Reproduce: a repository with a devcontainer from GitHub Codespaces (either in browser VS Code, or desktop) at the Source Control tab - it says "Scanning folder for git repositories…" I have seen this issues before months back, and it was fixed in Insiders and subsequently the release version - but it is back again and very frustrating. I have a minimal repo here - you will need to create a Codespace to see the issue (or choose a different devcontainer workflow). The issue could be to do with the docker image used, I think last time there was some suggestion of a problem with Alpine (or Alpine containers), and I believe the Jekyll container is based on Alpine. too.
it looks like has resurfaced. I am able to reproduce with the latest Insiders release.
Very likely candidate , will investigate tomorrow.

Steps for verification: Reopen in a container Verify server launches and integrated terminal works fine
I've checked in the latest Insiders release and the same bug seems to still be present when using GitHub Codespaces (both in web version of VS Code insiders, and desktop version of VS Code insiders when connecting to the Codespace) Version: 1.83.0-insider (Universal) Commit: Date: 2023-09-13T05:34:48.836Z Electron: 25.8.0 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 22.4.0
the alpine servers run fine with the provided container configuration, however the git scm is hanging for a different reason can you please look into it
I have created a new Codespace on the linked repository and I am still able to reproduce the problem. As far as I can tell the extension how is completely busted as running "Show Running Extensions" is empty. In the Window output log I see the following: If I look at the Git extension I see the following: !
Ah missed the logs, is based on whereas our server alpine modules are built on . We don't plan to revert the alpine version as is reaching EOL I am closing this as designed, please update the jekyll container to use
Change:
import { DEFAULT_EDITOR_ASSOCIATION, EditorInputWithOptions, IEditorOpenContext, IResourceMergeEditorInput } from 'vs/workbench/common/editor'; import { EditorInput } from 'vs/workbench/common/editor/editorInput'; import { applyTextEditorOptions } from 'vs/workbench/common/editor/editorOptions'; <ins> import { readTransientState, writeTransientState } from 'vs/workbench/contrib/codeEditor/browser/toggleWordWrap'; </ins> import { MergeEditorInput } from 'vs/workbench/contrib/mergeEditor/browser/mergeEditorInput'; import { DocumentMapping, getOppositeDirection, MappingDirection } from 'vs/workbench/contrib/mergeEditor/browser/model/mapping'; import { MergeEditorModel } from 'vs/workbench/contrib/mergeEditor/browser/model/mergeEditorModel';

Discussion:
It was weird when I toggled word wrap in the merge editor yet only the editor I was focused on had it toggled. I kind of expected all editors to have it toggled. My rationale is that toggling word wrap is usually a symptom of having long lines and the chances that all three editors have long lines is high if a single editor has long lines.
I agree. Until recently word wrap only toggled one side of the diff editor. See
Change:
import { TPromise } from 'vs/base/common/winjs.base'; import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { assign } from 'vs/base/common/objects'; <ins> import URI from 'vs/base/common/uri'; </ins> import { IWindowsService } from 'vs/platform/windows/common/windows'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; import { shell, crashReporter, app } from 'electron';

Discussion:
VSCode Version: 1.9.1 OS Version: Windows 10 Enterprise .693 Steps to Reproduce: VS Code a folder D:/Temp the following URL: vscode://file/d/temp/ Expected result: VS Code launches and opens folder D:/Temp Actual result: VS Code launches and says that folder /d/temp does not exist
I guess this is related to the windows CLI?
Want to ?
Thanks for the fix But actually went ahead with a simpler solution on top of yours. Instead of manipulating the strings we should just explicitly require the colon to be in the URI. So here's how URIs would work for Code: This works correctly now in .
Change:
); }); }); <ins> suite('removeLinkQueryString', () => { test('should remove any query string from the link', () => { strictEqual(removeLinkQueryString('?a=b'), ''); strictEqual(removeLinkQueryString('foo?a=b'), 'foo'); strictEqual(removeLinkQueryString('./foo?a=b'), './foo'); strictEqual(removeLinkQueryString('/foo/bar?a=b'), '/foo/bar'); strictEqual(removeLinkQueryString('foo?a=b?'), 'foo'); strictEqual(removeLinkQueryString('foo?a=b&c=d'), 'foo'); }); test('should respect ? in UNC paths', () => { strictEqual(removeLinkQueryString('?foo?a=b'), '?foo',); }); }); </ins> suite('detectLinks', () => { test('foo(1, 2) bar[3, 4] "baz" on line 5', () => { deepStrictEqual(

Discussion:
<img width="1440" alt="image" src="https://user-"path: Versions:
I have one question wish can get help: how vscode terminal detect the path cwd? why can the path correctlly go to the file with a releative path? <img width="1440" alt="image" src="https://user-"I guess it may use the But seems I can get the cwd in TerminalLinkProvider now: <img width="1440" alt="image" src="https://user-"
We check a few things to determine which to use
vite become more and more popular recent days, I think it would be convinient to support the path with query string: !
When I click, it opens the right file, but it underlines the first query argument when I hover, is that an issue? <img width="539" alt="image" src=""
not much of an issue but it would look more polished by just underlining the whole thing
Change:
import { IMultiDiffSourceResolver, IMultiDiffSourceResolverService, IResolvedMultiDiffSource, MultiDiffEditorItem } from './multiDiffSourceResolverService.js'; import { ISCMRepository, ISCMResourceGroup, ISCMService } from '../../scm/common/scm.js'; import { IEditorService } from '../../../services/editor/common/editorService.js'; <ins> import { IActivityService, ProgressBadge } from '../../../services/activity/common/activity.js'; </ins> export class ScmMultiDiffSourceResolver implements IMultiDiffSourceResolver { private static readonly _scheme = 'scm-multi-diff-source';

Discussion:
open a multifile diff reload window while the diff editor stores and loads it says that there are no changes yet <img width="1178" alt="Screenshot 2024-06-21 at 09 16 43" src=""
Thanks for filing! Briefly looked into it, but fixing it is a little bit more complex than I thought. The model creation is what takes a while, and during that time the multi file diff editor just has no model. It would be better if the model creation is immediate, but it has some property, that the editor could then show.