jiebi/CodeConvo huggingface dataset:
Change:
hoverPosition, text: this.computeTitle(), showPointer: true, <del> compact: true </del> <ins> compact: true, skipFadeInAnimation </ins> }); }

Discussion:
Native browser tooltips and many custom ones (Figma, Discord, Edge tabs) keep the tooltip element visible when moving between elements. Would be nice to do the same, to make mouse exploration even snappier. Discord icon bar: ! macOS dock: !
cc as this discussion was spawned off cc as owner of the hover widget cc as we talked about this a few times and he brought it up most recently in the team chat
fyi I'm the main hover widget person This seems doable, needs some thinking on how this would be exposed in the API. It's also a feature of native browser tooltips when hovering from one element with to another.
Thanks for confirmation :)
Change:
} const blobSegment = gitRepo.state.HEAD ? (`/blob/${linkType === 'headlink' && gitRepo.state.HEAD.name ? encodeURIComponentExceptSlashes(gitRepo.state.HEAD.name) : gitRepo.state.HEAD?.commit}`) : ''; <del> const encodedFilePath = encodeURIComponentExceptSlashes(uri.path.substring(gitRepo.rootUri.path.length)); </del> <ins> const uriWithoutFileSegments = `${hostPrefix}/${repo.owner}/${repo.repo}${blobSegment}`; if (!fileUri) { return uriWithoutFileSegments; } const encodedFilePath = encodeURIComponentExceptSlashes(fileUri.path.substring(gitRepo.rootUri.path.length)); </ins> const fileSegments = fileAndPosition.type === LinkType.File ? (useSelection ? `${encodedFilePath}${useRange ? rangeString(fileAndPosition.range) : ''}` : '') : (useSelection ? `${encodedFilePath}${useRange ? notebookCellRangeString(fileAndPosition.cellIndex, fileAndPosition.range) : ''}` : ''); <del> return `${hostPrefix}/${repo.owner}/${repo.repo}${blobSegment }${fileSegments}`; </del> <ins> return `${uriWithoutFileSegments}${fileSegments}`; </ins> } export function getBranchLink(url: string, branch: string, hostPrefix: string = 'https://github.com') {

Discussion:
Testing Steps: disable Remote Repos, GitHub Repos, Azure Repos. Then I Continue Working in shows up so I picked it nothing happens This might be but I see the same behavior when I disable Codespaces so it might be a different issue.
Ooh I just reproed this in OSS, log says
Change:
"./vs/*" ] }, <ins> "target": "es2022", "useDefineForClassFields": false, </ins> "lib": [ <del> "ES2016", "ES2017.Object", "ES2017.String", "ES2017.Intl", "ES2017.TypedArrays", "ES2018.AsyncIterable", "ES2018.AsyncGenerator", "ES2018.Promise", "ES2018.Regexp", "ES2018.Intl", "ES2019.Array", "ES2019.Object", "ES2019.String", "ES2019.Symbol", "ES2020.BigInt", "ES2020.Promise", "ES2020.String", "ES2020.Symbol.WellKnown", "ES2020.Intl", "ES2021.Promise", "ES2021.String", "ES2021.WeakRef", </del> <ins> "ES2022", </ins> "DOM", "DOM.Iterable", "WebWorker.ImportScripts"

Discussion:
Looks like we have broad support for . Static initialisers are the slight exception as they are only in Safari since ~2months. We might want to special case them, but otherwise we should be good to go:
On native privates: using them will be faster than weak-map-privates but slower than normal properties (much, much slower for Safari):
Some, perf number for some new API native privates - , faster than WeakMap privates but slower than conventional privates slower than []-access needs which need broader adoption because of semantic change.
Upstream issues for private property performance v8 - Webkit -
Change:
text-decoration: none; } <ins> .monaco-workbench.hc-black p > a, .monaco-workbench.hc-light p > a { text-decoration: underline !important; } </ins> .monaco-workbench a:active { color: inherit; background-color: inherit;

Discussion:
We currently distinguish links using only color, no underline in some places. This can make it hard for color blind or low vision users to differentiate between links and regular text. Underlines can also reduce readability though. Thoughts or ? ! !
Hi all, Live Share has a sev2 bug assigned for it. It effects our Accessibility Grade. I filed an extension request for it.
How about we start with enabling this in the High Contrast themes?
This one is trickier than I thought. VS Code uses elements throughout the IDE also for things like tabs and buttons, so we need to find a way to only match the elements that look like text... edit: we can match .
I noticed that we do this in the editor even for non-HC themes. !
After some investigation, matching doesn't work as it's the default role and we can only match it if it's explicitly set in the element. Looking for some other solutions, but we may need to add the role attribute explicitly everywhere.
do you have advice how we might work around this?
We do not have an issue filled for this as is my understanding. LiveShare has it, and filling extension is the right approach (which was already done). So for now I suggest no action here.
I still think this is a good thing to look into. Our links in the HC themes don't look very contrasty in any case: <img width="722" alt="image" src=""I realised we don't need to underline all links, just those that appear in a text. So matching should do the trick.
that's a fair point. So could we fix for High Contast only first?
yes, we'll keep it to HC themes for now. I've managed to get it to match only relevant text links that have surrounding text. As you can see standalone text links won't be underlined. GitHub also does not do this. I think it looks pretty good (ignore the red colour, it's to check we're matching the right things and I will reset it): <img width="1150" alt="image" src=""<img width="421" alt="image" src=""<img width="943" alt="image" src=""
Specially in the light HC theme it's a big improvement: <img width="343" alt="image" src=""
Looking good for the HC theme.

Thank you
Should these have underlines in HC? ! Otherwise, verified in welcome views and chat.
these don't need to be underlined. Only links in a paragraph surrounded by other text.
Adding setting to enable link underlines in
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "4.20.0-beta.5", </del> <ins> "xterm": "4.20.0-beta.6", </ins> "xterm-addon-search": "0.10.0-beta.1", "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.13.0-beta.2" </del> <ins> "xterm-addon-webgl": "0.13.0-beta.3" </ins> } }

Discussion:
fixed in Need to update xterm to pull it in: !
What's a way to verify this issue on Windows?
With Powershell on Windows in the integrated terminal without a powerline font enabled: You should get something like this: <img width="62" alt="image" src="https://user-"
They seem a bit clipped to me: !
tracked in
Change:
macOptionIsMeta: boolean; macOptionClickForcesSelection: boolean; rendererType: 'auto' | 'canvas' | 'dom'; <del> rightClickBehavior: 'default' | 'copyPaste' | 'selectWord'; </del> <ins> rightClickBehavior: 'default' | 'copyPaste' | 'paste' | 'selectWord'; </ins> cursorBlinking: boolean; cursorStyle: string; drawBoldTextInBrightColors: boolean;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --With being merged, I'd now like to be able to directly paste after selection. The current behaviour with copyOnSelection = true and rightClickBehavior = copyPaste: text (text is then copied into clipboard) or left click, this clears the selection click again to paste With the proposed mode, copyOnSelection = true and rightClickBehavior = paste: text (text is then copied into clipboard) click, and text is pasted Why do I want this? Simple: it removes an extra click when pasting. This mirrors how PuTTY's pastes. The new Windows Terminal recently got support for this feature, too -
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.5 --- <!-- score: 0.483 --- <!-- score: 0.457 --<!-- potentialduplicatescomment --
To verify test on Windows and make sure that acts correct (as opposed to the default )
Change:
pre code { line-height: 1.357em; white-space: pre-wrap; <ins> padding: 0; </ins> } li p {

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) Using triple backticks with language specifiers (e.g., "bash") displays two additional lines (before and after the code block) starting with a vertical bar (sort of opening and closing parentheses) For example, the following markdown: It is displayed with the additional markers; see screenshot: <img width="494" alt="image" src=""In Jupyter (or Jupyter-Lab) these markers are not displayed Version: 1.85.1 (user setup) Commit: Date: 2023-12-13T09:49:37.021Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0. v2023.11. No response Python 3.11 python: v2023.22.1 No response Remote
It also doesn't look great with the language removed, those bars are still rendered but on the same lines: !
I believe this has already been fixed in VS Code insiders: !
Oh actually still broken for notebooks but fixed for normal markdown. Will also port fix to notebooks
<img width="733" alt="image" src=""looks good!
Change:
display: inline-flex; text-align: center; font-size: 12px; <del> line-height: 14px; </del> background-color: inherit; justify-content: center; width: calc(100% - 19px);

Discussion:
Testing ! I expected to be vertically centered. Version: 1.68.0-insider Commit: Date: 2022-05-31T05:17:17.091Z Electron: 17.4.6 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 5.13.0-44-generic snap I'm on Ubuntu
Change:
delete this._elements.statusLabel.dataset['state']; } <del> this._elements.statusLabel.dataset['title'] = ops.title; </del> <ins> if (ops.title) { this._elements.statusLabel.dataset['title'] = ops.title; } else { delete this._elements.statusLabel.dataset['title']; } </ins> this._onDidChangeHeight.fire(); }

Discussion:
Testing The action shows the submenu for a fraction of a second before disappearing again when clicked. The submenu correctly shows in panel chat. !
We shouldn't have this drop down menu in inline chat
This is the problem:
caused by
Moving to April for more cleanup
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-web-links/-/xterm-addon-web-links-0.2.1.tgz#6d1f2ce613e09870badf17615e7a1170a31542b2" integrity sha512-2KnHtiq0IG7hfwv3jw2/jQeH1RBk2d5CH4zvgwQe00rLofSJqSfgnJ7gwowxxpGHrpbPr6Lv4AmH/joaNw2+HQ== <del> xterm@4.2.0: version "4.2.0" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.2.0.tgz#b9980b2ae18c64ed31bcc95eace3bcecffebbbd9" integrity sha512-oNfLqt+LmghLPOt5UcskP5Km1fXpTBHsTZ99nxJKY2N0MNFXBKIVXUcNNhHCa74JGZFMGhLT58A/UN3HcPXSfg== </del> <ins> xterm@4.2.0-vscode1: version "4.2.0-vscode1" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.2.0-vscode1.tgz#dbd67e52536578ea6b772d69a97da1487acf29e3" integrity sha512-frw5Kprzkko8+G0vp4jOcwTeOpYFbSb2+QShpeQGJ7l3Hg3MTM7kt1G+nLxBPKnkFAmei/JcJTUGJdp/lldAfA== </ins> y18n@^3.2.1: version "3.2.1"

Discussion:
This increases the amount of work done when typing commands to be significantly more. Upstream:
Can't really verify this issue without debugging into the code, inside (formatted) you will see an function, the args are start/end. Add a breakpoint to that function and verify the args are a range for a single like (eg. 15, 15) after typing a single character into the terminal. Here is the failing case where the terminal is re-rendering lines 0-15: ! Use the canvas renderer to verify.
A better way to verify: to DOM renderer paint flashing: ! you type into the prompt only a single line will flash
Verified in latest (). Can this issue be closed?
Change:
}; }); const langName = this._modeService.getLanguageName(document.getModeId()) || document.getModeId(); <del> const pick = await this._quickInputService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for {0}-files", DefaultFormatter._maybeQuotes(langName)) }); </del> <ins> const pick = await this._quickInputService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for '{0}' files", DefaultFormatter._maybeQuotes(langName)) }); </ins> if (!pick || !formatter[pick.index].extensionId) { return undefined; }

Discussion:
Steps to Reproduce: Format Document from command palette when there are multiple formatters placeholder for the box to choose which formatter to use says "Select a default formatter for Flow-files" (in my case, the language is set to "Flow") "Flow-files" is weird, I don't think there should be a hyphen: Also here, but I don't know how to repro this one:
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.537 --- <!-- score: 0.485 --- <!-- score: 0.47 --<!-- potentialduplicatescomment --
I will prepare a PR.
Change:
import { Extensions, IConfigurationMigrationRegistry } from 'vs/workbench/common/configuration'; import { LOG_MODE_ID, OUTPUT_MODE_ID } from 'vs/workbench/services/output/common/output'; import { SEARCH_RESULT_LANGUAGE_ID } from 'vs/workbench/services/search/common/search'; <del> import { GHOST_TEXT_DESCRIPTION } from 'vs/editor/contrib/inlineCompletions/browser/ghostTextWidget'; </del> const $ = dom.$;

Discussion:
I have linters to ensure files have the right header, when i created the empty ts file, i get the linter error as well as chat prompt However when I add an empty line, you can see the caht prompt does not appear and linter error is in the second line ! !
Change:
const lineText = model.getLineContent(position.lineNumber); // Do not auto-close ' or " after a word character <del> if (chIsQuote && position.column > 1) { </del> <ins> if ((chIsQuote && position.column > 1) && autoCloseConfig !== 'always') { </ins> const wordSeparators = getMapForWordSeparators(config.wordSeparators); const characterBeforeCode = lineText.charCodeAt(position.column - 2); const characterBeforeType = wordSeparators.get(characterBeforeCode);

Discussion:
Issue Type: <bBug</bRelated to Repo a js file with cursor at : ` (backtick) Expected Backtick is closed since we have set the mode to Actual Quote is not closed VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I still have this issue. Applied the setting, and even tried reloading window with extensions disabled. Tried in both "javascript" and "javascriptreact". VS Code: 1.32.3 (1.32.3) OS: MacOS High Sierra 10.13.6
I'm wondering if can you try and replicate this issue on VSCode Insiders?
It seems to autoclose as expected on Insiders However, it'd be helpful to have it auto-indent on enter, since template literals allow expressions, such as in use with graphql. ! VS Code: 1.34.0-insider (1.34.0-insider)
Change:
tests: bestNodes, }); } <ins> else if (bestNodesBefore.length) { await testService.runTests({ group: this.group, tests: bestNodesBefore, }); } </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --- VS Code Version: 1.62.3 OS Version: macOS 11.6.1 For C++ tests using the C++ TestMate extension, "Test: Run Test at Cursor" only works if the cursor is on the first line of the test case at column 0. For python tests, it works if the cursor is anywhere on the first line of the test case, up to column 0 of the next line. This is way too restrictive; if my cursor is on the first line of the test, I can just as well click the green icon that's right next to it. The point of the "Run Test at Cursor" is that it should work when my cursor is anywhere inside the test case (with the beginning of the test case potentially scrolled out of view). And that's how it worked in Test Explorer UI; I'm missing that behavior. Now, you might argue that it's the extension's responsibility to set the range of the TestItem appropriately to cover the whole test case. Yes, the C++ TestMate extension sets the range to , and the Python extension to , hence the behavior described above. However, I'd argue that this is too much of a burden for extension developers. Most underlying test frameworks only report the starting lines of test cases; actually I'm not aware of a single one that reports where a test case ends. This means that all extensions would have to implement the same heuristic to extend a TestItem's range until either the next item in the same file, or the end of the file if there's no next one. I'd argue that this should be done by the testing framework. Long story short: I'm proposing to treat the "no-man's land" between two TestItems (or after the last item) in a file as belonging to the item before it. Does this make sense, (Cc
Sure, we can use the closest test before the cursor if there's no exact range. I'm on vacation for a few weeks but PR's welcome. Code pointer:
Seconded
Here's a PR:
/verified Running test at cursor works no matter where the cursor is (and runs previous test in the no man's land)
Change:
return focusedElement && focusedElement.templateId === KEYBINDING_ENTRY_TEMPLATE_ID ? <IKeybindingItemEntry>focusedElement : null; } <ins> getSecondaryActions(): IAction[] { return <IAction[]>[ <IAction>{ label: localize('showDefaultKeybindings', "Show Default Keybindings"), enabled: true, id: KEYBINDINGS_EDITOR_SHOW_DEFAULT_KEYBINDINGS, run: (): TPromise<any> => { this.searchWidget.setValue('@source: default'); return TPromise.as(null); } }, <IAction>{ label: localize('showUserKeybindings', "Show User Keybindings"), enabled: true, id: KEYBINDINGS_EDITOR_SHOW_USER_KEYBINDINGS, run: (): TPromise<any> => { this.searchWidget.setValue('@source: user'); return TPromise.as(null); } } ]; } </ins> defineKeybinding(keybindingEntry: IKeybindingItemEntry): TPromise<any> { this.selectEntry(keybindingEntry); this.showOverlayContainer();

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.20.0-ins OS Version: win7x64 In we have a column called "Source". How about to create a filter called "source:user", so as "source:default", etc... ? !
any code-pointer to start on this?
Here it is -
hey! are you working on this? If not, I can take this.
I'm already started on this. Thanks for asking though.
sumitted a PR here. Care to comment / review.
Change:
export class BulkEditPane extends ViewPane { static readonly ID = 'refactorPreview'; <ins> static readonly Schema = 'vscode-bulkeditpreview-multieditor'; </ins> static readonly ctxHasCategories = new RawContextKey('refactorPreview.hasCategories', false); static readonly ctxGroupByFile = new RawContextKey('refactorPreview.groupByFile', true);

Discussion:
Make a refactor and open the refactor preview Click on accept/discard The editor showing the refactor preview does not close
Change:
templateDisposables.add(scopedInstaService.createInstance(CellChatPart, this.notebookEditor, cellChatPart)), templateDisposables.add(scopedInstaService.createInstance(CellEditorStatusBar, this.notebookEditor, container, editorPart, editor)), templateDisposables.add(scopedInstaService.createInstance(CellProgressBar, editorPart, cellInputCollapsedContainer)), <del> templateDisposables.add(new CellDecorations(rootContainer, decorationContainer)), </del> <ins> templateDisposables.add(new CellDecorations(this.notebookEditor, rootContainer, decorationContainer)), </ins> templateDisposables.add(scopedInstaService.createInstance(CellComments, this.notebookEditor, cellCommentPartContainer)), templateDisposables.add(scopedInstaService.createInstance(CellExecutionPart, this.notebookEditor, executionOrderLabel)), templateDisposables.add(scopedInstaService.createInstance(CollapsedCellOutput, this.notebookEditor, cellOutputCollapsedContainer)),

Discussion:
Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width="981" alt="image" src=""I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width="980" alt="image" src=""It appears that the Code cells lost their yellow highlight.
Change:
import { CLOSE_EDITORS_AND_GROUP_COMMAND_ID } from 'vs/workbench/browser/parts/editor/editorCommands'; import { coalesce } from 'vs/base/common/arrays'; import { AsyncDataTree } from 'vs/base/browser/ui/tree/asyncDataTree'; <del> import { ExplorerItem } from 'vs/workbench/contrib/files/common/explorerModel'; </del> <ins> import { ExplorerItem, NewExplorerItem } from 'vs/workbench/contrib/files/common/explorerModel'; </ins> import { onUnexpectedError } from 'vs/base/common/errors'; import { sequence } from 'vs/base/common/async';

Discussion:
Issue Type: <bBug</bExplorer asks to input file name for a new file on the wrong level after pressing <kbdEscape</kbdbutton. On the gif file below we have focus on directory, but input field created on the root level of the project. ! asks to create this issue. Related issue is Keyboard navigation: simple. Extension to switching keyboard context is installed. VS Code version: Code - Insiders 1.32.0-insider (, 2019-02-22T08:34:22.116Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ atom-keybindings3.0.6 </details<!-- generated by issue reporter --
My understanding is that this is because keyboard navigation still attempts to select the nearest file beginning with when you press , and that the “create file” action is only triggered secondary to that, so the focus has already shifted when the file is created. Super annoying.
Change:
'properties': { [FILES_EXCLUDE_CONFIG]: { 'type': 'object', <del> 'markdownDescription': nls.localize('exclude', "Configure [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) for excluding files and folders. For example, the File Explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search-specific excludes. Refer to the `#explorer.excludeGitIgnore#` setting for ignorings files based on your `.gitignore`."), </del> <ins> 'markdownDescription': nls.localize('exclude', "Configure [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) for excluding files and folders. For example, the File Explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search-specific excludes. Refer to the `#explorer.excludeGitIgnore#` setting for ignoring files based on your `.gitignore`."), </ins> 'default': { ...{ '**/.git': true, '**/.svn': true, '**/.hg': true, '**/CVS': true, '**/.DS_Store': true, '**/Thumbs.db': true }, ...(isWeb ? { '**/*.crswap': true /* filter out swap files used for local file access */ } : undefined)

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --There is an extra at the end of on L141.
Change:
if (!enterResult) { enterResult = { indentAction: IndentAction.None, appendText: '' }; } else { <ins> // Here we add `t` to appendText first because enterAction is leveraging appendText and removeText to change indentation. </ins> if (!enterResult.appendText) { <del> enterResult.appendText = ''; </del> <ins> if ( (enterResult.indentAction === IndentAction.Indent) || (enterResult.indentAction === IndentAction.IndentOutdent) ) { enterResult.appendText = 't'; } else { enterResult.appendText = ''; } </ins> } }

Discussion:
VSCode Version: Code - Insiders 1.9.0-insider (, 2017-01-20T14:58:38.006Z) OS Version: Linux x64 4.8.0-34-generic Extensions: TypeScript file: ! Press enter: !
verified.