jiebi/CodeConvo huggingface dataset:
Change:
private static readonly READONLY_MESSAGES = { providerReadonly: { value: localize('providerReadonly', "Editor is read-only because the file system of the file is read-only."), isTrusted: true }, sessionReadonly: { value: localize({ key: 'sessionReadonly', comment: ['Please do not translate the word "command", it is part of our internal syntax which must not change', '{Locked="](command:{0})"}'] }, "Editor is read-only because the file was set read-only in this session. [Click here](command:{0}) to set writeable.", 'workbench.action.files.setActiveEditorWriteableInSession'), isTrusted: true }, <del> configuredReadonly: { value: localize({ key: 'configuredReadonly', comment: ['Please do not translate the word "command", it is part of our internal syntax which must not change', '{Locked="](command:{0})"}'] }, "Editor is read-only because the file was set read-only via settings. [Click here](command:{0}) to configure.", `workbench.action.openSettings?${encodeURIComponent('["files.readonly"]')}`), isTrusted: true }, </del> <ins> configuredReadonly: { value: localize({ key: 'configuredReadonly', comment: ['Please do not translate the word "command", it is part of our internal syntax which must not change', '{Locked="](command:{0})"}'] }, "Editor is read-only because the file was set read-only via settings. [Click here](command:{0}) to configure or [toggle for this session](command:{1}).", `workbench.action.openSettings?${encodeURIComponent('["files.readonly"]')}`, 'workbench.action.files.toggleActiveEditorReadonlyInSession'), isTrusted: true }, </ins> fileLocked: { value: localize({ key: 'fileLocked', comment: ['Please do not translate the word "command", it is part of our internal syntax which must not change', '{Locked="](command:{0})"}'] }, "Editor is read-only because of file permissions. [Click here](command:{0}) to set writeable anyway.", 'workbench.action.files.setActiveEditorWriteableInSession'), isTrusted: true }, fileReadonly: { value: localize('fileReadonly', "Editor is read-only because the file is read-only."), isTrusted: true } };

Discussion:
The current read-only message has a link that will take you to settings, but all I ever want to do is immediately toggle the file.
To verify: Open your clone of the this repo Open a file from the folder Try to edit the file Verify that the read-only message offers a one-click way to make the file writeable.
Change:
export interface SCMViewSeparatorElement { readonly label: string; <ins> readonly ariaLabel?: string; </ins> readonly repository: ISCMRepository; readonly type: 'separator'; }

Discussion:
Testing a screenreader. to the Incoming/Outgoing part of the SCM viewlet. Actual: "Incoming/Outgoing". Expected: something like "Incoming and outgoing changes" screenreader reads origin/some-branch-name for the incoming changes. Expected: "origin/some-branch-name incoming" or "incoming changes from origin/some-branch-name" screenreader reads some-branch-name for the outgoing changes. Expected: "some-branch-name outgoing" or "outgoing changes from some-branch-name" CC for alternative suggestions
Great point, we should lead with the info, so place "outgoing" or "incoming" before the branch name in this case.
I have confirmed that the titles show up upon hovering over the entries, but that NVDA still reads the text as-is rather than reading the title text. Reopening.
That's interesting given that I am using the IconLabel widget's property to set the aria label.
Change:
this.filterNonUniversalActions(primaryGroups, result.primary); this.filterNonUniversalActions(secondaryGroups, result.secondary); } <del> if (listen && elements.length === 1) { listen.add(menu.onDidChange(() => this._onDidChange.fire(element))); listen.add(menu); } else { menu.dispose(); } </del> <ins> menu.dispose(); </ins> } return { primary: this.buildMenu(primaryGroups), secondary: this.buildMenu(secondaryGroups) };

Discussion:
It looks like everything is getting disposed properly and I haven't been able to find a way to repro. It looks like this has only been seen on builds that are 12 days old. Let's see if we see it again.
I can repro if I have a tree with ~145 elements visible, as each one has a listener for whether the inline menu items change base on context key value changes. This listener is also apparently listening for whether a menu item's "hidden state" also changes, which is where the problem occurs. It seems that every menu in the workbench listens for the same "hidden state" event.
The error telemetry should be fixed, but we're still going to listen on tree menus.
Change:
return function () { var desktop = gulp.src('resources/linux/code.desktop', { base: '.' }) .pipe(replace('@@NAME_LONG@@', product.nameLong)) <ins> .pipe(replace('@@NAME_SHORT@@', product.nameShort)) </ins> .pipe(replace('@@NAME@@', product.applicationName)) .pipe(rename('BUILD/usr/share/applications/' + product.applicationName + '.desktop'));

Discussion:
Testing Open the integrated terminal Change the setting Observe: setting is not applied until a restart of VSCode

I've seen this a few times: ! It seems to disappear after a while, maybe it's to do with .local desktop entry or bin command running instead of real command?

Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?
Thinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.
Marked as candidate as it's a very simple change that's been reported a bunch of times.
Cherry picked to release/1.2
Change:
import { InstallExtensionQuickAccessProvider, ManageExtensionsQuickAccessProvider } from 'vs/workbench/contrib/extensions/browser/extensionsQuickAccess'; import { ExtensionRecommendationsService } from 'vs/workbench/contrib/extensions/browser/extensionRecommendationsService'; import { CONTEXT_SYNC_ENABLEMENT } from 'vs/workbench/services/userDataSync/common/userDataSync'; <ins> import { CopyAction, CutAction, PasteAction } from 'vs/editor/contrib/clipboard/clipboard'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { MultiCommand } from 'vs/editor/browser/editorExtensions'; import { Webview } from 'vs/workbench/contrib/webview/browser/webview'; </ins> // Singletons registerSingleton(IExtensionsWorkbenchService, ExtensionsWorkbenchService);

Discussion:
A lot of extensions have configuration code. It is extremely annoying that since some version ago we are unable to copy anything from that pane, mouse or keyboard. Steps to reproduce: Go to extension description Try to copy something Video:
See I'm surprised that you can't copy using the keyboard. What key sequence are you using? What command(s) does your Keyboard Shortcuts page show that bound to?
Im using the usual cmd+c which works in other apps. And cmd+c also works in the editor mode, terminal mode - so i think its not my key bindings customization. I recorded video in presenter mode (displaying what i press) showing copying something else + not working for ext description:
Change:
import * as assert from 'assert'; import { IListRenderer, IListVirtualDelegate } from 'vs/base/browser/ui/list/list'; import { IListOptions, List } from 'vs/base/browser/ui/list/listWidget'; <ins> import { raceTimeout } from 'vs/base/common/async'; </ins> import { QuickInputController } from 'vs/base/parts/quickinput/browser/quickInput'; import { IQuickPick, IQuickPickItem } from 'vs/base/parts/quickinput/common/quickInput'; <del> import { flakySuite } from 'vs/base/test/common/testUtils'; // Simple promisify of setTimeout function wait(delayMS: number) { return new Promise(function (resolve) { setTimeout(resolve, delayMS); }); </del> <ins> // Sets up an `onShow` listener to allow us to wait until the quick pick is shown (useful when triggering an `accept()` right after launching a quick pick) // kick this off before you launch the picker and then await the promise returned after you launch the picker. async function setupWaitTilShownListener(controller: QuickInputController): Promise<void> { const result = await raceTimeout(new Promise<boolean>(resolve => { const event = controller.onShow(_ => { event.dispose(); resolve(true); }); }), 2000); if (!result) { throw new Error('Cancelled'); } </ins> } <del> flakySuite('QuickInput', () => { // https://github.com/microsoft/vscode/issues/147543 </del> <ins> suite('QuickInput', () => { // https://github.com/microsoft/vscode/issues/147543 </ins> let fixture: HTMLElement, controller: QuickInputController, quickpick: IQuickPick<IQuickPickItem>; function getScrollTop(): number {

Discussion:
Again: I think these tests need to stop using an arbritrary timeout of 200 ms and find a different way of figuring out.
Change:
} private async[State.PAUSE]() { <del> assertType(this._session); assertType(this._strategy); </del> this._resetWidget(); <del> this._strategy.pause?.(); </del> <ins> this._strategy?.pause?.(); </ins> this._session = undefined; }

Discussion:
Got the trace below, this happens when PAUSE is enter as part of error handling which then also errors...
The error leading up to this is:
To verify start inline chat get it to make changes select ESC to hide inline chat select cmd+i to start inline chat again
Change:
max-width: 20px; max-height: 20px; position: relative; <del> top: 2px; </del> <ins> top: auto; </ins> } .monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideDetails .getting-started-category img.category-icon {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.61.0-insider OS Version: macOS 11.5.2 The tiles showcasing the welcome walkthrough contributions look like they should be vertically centering the content. As of now the icon and close icon are aligned to the bottom and top, respectively. <img width="504" alt="CleanShot 2021-09-24 at 10 49 20 src="https://user-"Icon aligned to the bottom: <img width="126" alt="CleanShot 2021-09-24 at 10 53 40 src="https://user-"Remove icon aligned to the top: <img width="196" alt="CleanShot 2021-09-24 at 10 53 52 src="https://user-"
Change:
} const dirname = paths.dirname(getFilePath()); if (folderUri || argument) { <del> return paths.relative(this.fsPath(getFolderUri()), dirname); </del> <ins> const relative = paths.relative(this.fsPath(getFolderUri()), dirname); return relative.length === 0 ? '.' : relative; </ins> } return dirname;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: OS Version: Version: 1.50.0 Commit: Date: 2020-10-07T06:10:52.432Z Electron: 9.2.1 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: use C++ extension and configured to use task to get my source code compiled. The part of the relatives to this issue is basically like this: now synthesizes this command as , rather than previously in VSCode version 1.49.3, . compiler will get for trying to write to root folder, of course. Should still be under such cases or not? Currently I reverted to 1.49.3.
To verify: Open a folder with some files in VS Code Add the following task:Open a file in from your folder that is at the top level of your folder, not in a subfolder Run the task Verify that the task outputs and not
Change:
"keytar": "7.9.0", "minimist": "^1.2.6", "native-watchdog": "^1.4.1", <del> "node-pty": "0.11.0-beta31", </del> <ins> "node-pty": "0.11.0-beta32", </ins> "spdlog": "^0.13.0", "tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0",

Discussion:
Use insiders-1.78 or run out of source start a terminal the name is "kernel_task" start a long running task, like , press and see it's not terminating https://user-
same question <img width="1024" alt="image" src="https://user-"
Same issue on my brand new Apple M2 Mac Mini. Running latest Insiders. I thought I was going crazy.
Works fine on latest version of insiders.
Yeah fixed now. Thanks everybody!
Not working for me. I am using
Not working for me after updating today (May 09, 2023) Version: 1.78.0 (Universal) Commit: Date: 2023-05-03T20:11:00.813Z Electron: 22.4.8 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 18.7.0 Sandboxed: Yes
That doesn't kill the process. It just suspends it. Just be aware of that (if you do it a lot ;)
same for me, no control-c or any kill commands will work: Version: 1.78.1 Commit: Date: 2023-05-04T09:57:42.343Z (5 days ago) Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 18.7.0 Sandboxed: No
It stopped working for me due to an extension which had created a key binding starting with so I removed the key binding and it started working. helped me.
what extension was causing the issue?
I forgot the name but you can check your keyboard bindings.
I don't have the same extensions as you?
Hi, this "Ctrl+C" (terminate task) feature suddenly stopped working a few days ago for us as well: the "^C" still displays in the terminal but without any effect and there is not a single shortcut associated to Ctrl+C and no way to add one This is a huge pain as we simply cannot work anymore using vs-code, this was such a central feature There is just so much content on the topic online, yet no simple solution: What happened?

Why did vs-code team do this? How is there not a simple option in Keyboard Shortcuts (JSON) to add it back? Thanks in advance to those currently working on a solution
what is shown in the vscode status bar when you press ?
it was a bug we introduced and fixed shortly afterwards, see One of the downsides of using Insiders is occasionally things like this slip in.
Never knew I was on those buggy Insiders builds. Hot damn. You need better wording on your main site. In any case, there is still no fix for this for Insiders and I am not really looking forward to installing and setting everything up from scratch with Universal.
Change:
KeybindingsRegistry.registerCommandAndKeybindingRule({ id: CUT_FILE_ID, weight: KeybindingWeight.WorkbenchContrib + explorerCommandsWeightBonus, <del> when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerRootContext.toNegated(), ExplorerResourceNotReadonlyContext), </del> <ins> when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerRootContext.toNegated(), ExplorerResourceNotReadonlyContext, WorkbenchTreeFindOpen.toNegated()), </ins> primary: KeyMod.CtrlCmd | KeyCode.KeyX, handler: cutFileHandler, });

Discussion:
Sometimes "Paste" fails: The file(s) to paste have been deleted or moved since you copied them. TreeError [FileExplorer] Tree element not found: [object Object] Maybe should be disabled for as long as we do not update properly.
Change:
const newWithProfile = nls.localize('newWithProfile', 'The Create New Terminal (With Profile) ({0}) command allows for easy terminal creation using a specific profile.'); const newWithProfileNoKb = nls.localize('newWithProfileNoKb', 'The Create New Terminal (With Profile) command allows for easy terminal creation using a specific profile and is currently not triggerable by a keybinding.'); const accessibilitySettings = nls.localize('accessibilitySettings', 'Access accessibility settings such as `terminal.integrated.tabFocusMode` via the Preferences: Open Accessibility Settings command.'); <ins> const commandPrompt = nls.localize('commandPromptMigration', "Consider using powershell instead of command prompt for an improved experience"); </ins> class AccessibilityHelpWidget extends Widget implements ITerminalWidget { readonly id = 'help'; private _container: HTMLElement | undefined;

Discussion:
Shell integration offers many improvements to the terminal experience and makes it more accessible via commands like . reported that he and many others use which does not have shell integration. Should we include a hint in the help menu that the experience could be better when we detect a screen reader & ?
I think this will improve the discoverability! Voting for this idea.
On windows, Create a terminal - via for example. run . Verify that you see a message about migrating to use powershell.
Change:
}); }); <del> test.skip('issue #208215: outdented after semicolon detected after arrow function', () => { </del> <ins> test('issue #208215: indent after arrow function 2', () => { </ins> <del> // Notes: we want to outdent after having detected a semi-colon which marks the end of the line, but only when we have detected an arrow function // We could use one outdent pattern corresponding per indent pattern, and not a generic outdent and indent pattern </del> <ins> // https://github.com/microsoft/vscode/issues/208215 </ins> const model = createTextModel([ <del> 'const add1 = (n) =>', '    console.log("hi");', </del> <ins> 'const array = [1, 2, 3, 4, 5];', 'array.map(', '    v =>', </ins> ].join('n'), languageId, {}); disposables.add(model); withTestCodeEditor(model, { autoIndent: "full" }, (editor, viewModel, instantiationService) => { registerLanguage(instantiationService, languageId, Language.TypeScript, disposables); <del> editor.setSelection(new Selection(2, 24, 2, 24)); </del> <ins> editor.setSelection(new Selection(3, 9, 3, 9)); </ins> viewModel.type("n", 'keyboard'); assert.strictEqual(model.getValue(), [ <del> 'const add1 = (n) =>', '    console.log("hi");', '', </del> <ins> 'const array = [1, 2, 3, 4, 5];', 'array.map(', '    v =>', '        ' </ins> ].join('n')); }); }); <del> test.skip('issue #116843: indent after arrow function', () => { </del> <ins> test('issue #116843: indent after arrow function', () => { </ins> // https://github.com/microsoft/vscode/issues/116843

Discussion:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have:
Change:
let overwriteBefore = position.column - suggestion.range.startColumn; let overwriteAfter = suggestion.range.endColumn - position.column; <del> let suffixDelta = this._lineSuffix.value ? this._lineSuffix.value.delta(position) : 0; </del> <ins> let suffixDelta = this._lineSuffix.value ? this._lineSuffix.value.delta(editorPosition) : 0; </ins> let word: IWordAtPosition | null; if (!keepSuffix) { // don't overwrite anything right of the cursor

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.40.0-insider () OS Version: macOSX 10.15 Steps to Reproduce: auto-complete and press tab <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes 40.0-insider () ! 1.38.1 () !
works fine seems to be broken
thanks for bisecting. was authered by thus assigning to him
Yup, this is bad: ! Though it only happens on auto suggest, not manual trigger.
I've merged the fix by thanks a lot for that! We'll get the fixed Insiders build next Monday morning CET. Sorry for the disturbance everyone!
Thanks everyone!
Still seeing this pretty consistently on Version: 1.40.0-insider (user setup) Commit: Date: 2019-10-15T05:26:38.861Z Electron: 6.0.12 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0. ! Unless this is now the correct behavior? In which case, how do I stop it and get it to insert as before, not replace?
I'm seeing weird behavior on quotes as well. if you type inside , the last quote is removed, like in becomes Version: 1.40.0-insider (user setup) Commit: Date: 2019-10-15T05:26:38.861Z Electron: 6.0.12 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.
What language is that?
Oh, I see . Yeah, that's very likely because JSON uses a more than bogous word definition
I have created and I aiming to push a fix today
What's the correct behavior here?

If replacing the text is correct, that's fine, but if the current solution is going to be a whack-a-mole fix for each language maybe there's something else that should be done.
Another example. On this one, the comma is removed: !
We appreciate constructive feedback, if you want to report an issue then please file a new issue, stating the version of vscode, the language, and exact repo steps.
It's not a different issue though, this one just isn't fixed regardless of my preference for replace vs insert. If you'd prefer, I can open a new one.
Things seem to be working in the latest insiders. I'm no longer able to repro issue--can you confirm that this still occurs on the latest build of insiders? 
Yeah I haven't noticed any weird behavior in the past few days. I'll certainly comment here if I see it again.
Change:
} override getName() { <del> return localize('getStarted', "Get Started"); </del> <ins> return localize('getStarted', "Welcome"); </ins> } selectedCategory: string | undefined;

Discussion:
Ref Right now I see: as a menu entry and command name "Get Started" as the tab name when looking at the welcome page "Show welcome page on startup" and "Reset welcome page walkthrough progress" "Getting Started with VS Code" as a walkthrough name There's a mix of "Welcome" and "Get Started" usage that makes it hard to differentiate between concepts. We could either revert back to "Welcome" for the welcome page itself or rename it to differentiate from the first walkthrough. Thoughts <img width="424" alt="CleanShot 2022-11-21 at 10 19 04 src="https://user-"<img width="200" alt="CleanShot 2022-11-21 at 10 19 12 src="https://user-"<img width="516" alt="CleanShot 2022-11-21 at 10 19 20 src="https://user-"<img width="273" alt="CleanShot 2022-11-21 at 10 19 23 src="https://user-"<img width="625" alt="CleanShot 2022-11-21 at 10 19 56 src="https://user-"
for historical context on naming here
Yeap..I believe changing the label in the tab to "Welcome" instead of "Get Started" is a good option - It should say Welcome on the tab here instead of Getting Started: ! When the user navigates away from the welcome page, the tab name should change to the walkthrough's name: It should say Learn the Fundamentals on the tab here instead of Getting Started: ! And this breadcrumb should say Welcome: !
"Welcome" was the old page and we "Get Started" as new name during development. "Get Started" did fit better for the walkthrough style, was a more action-style verb and used in many other apps. Not sure if more thoughts went into it, as the mockups that started in were before my time and already used "Get Started". I haven't many users ever get into Get Started or Welcome as command, so renaming would be low risk.
Is there a user issue mentioning the confusion? Asking to understand if we also need to account for user keyword search behavior in the command pallet when looking for walkthroughs or the Getting Started page after its been closed.

Currently, most walkthroughs use the "Get Started" terminology - Searching for "Get..." in the command palette surfaces the walkthroughs. I wonder if search terms are influenced by the page on which users first saw the walkthroughs and will the naming change have implications on the keywords to find walkthroughs?
No specific issue that I know of, I'm just spotting the issue of the strange overloading myself. might know if we have any hard data on people searching for the command. But I'd also assume it's quite unlikely compared to going to the "Help" menu, for example.