jiebi/CodeConvo huggingface dataset:
Change:
} } <ins> private _restoreSelectedKernel(viewState: INotebookEditorViewState | undefined): void { if (viewState?.selectedKernelId && this.textModel) { const kernel = this.notebookKernelService.getMatchingKernel(this.textModel).all.find(k => k.id === viewState.selectedKernelId); if (kernel) { this.notebookKernelService.selectKernelForNotebook(kernel, this.textModel); } } } </ins> getEditorViewState(): INotebookEditorViewState { const state = this.viewModel?.getEditorViewState(); if (!state) {

Discussion:
Testing microsoft/vscode-jupyter untitled ipynb cells export commands are available in command palette the untitled notebook as ipynb and give it a title command palette :bug: all the export commands are now hidden
I think this is because technically the cells were run in the context of the previous notebook, so I now need to run them again after saving the notebook, which is a rather nasty limitation...
I think this is because after saving we don't have a kernel connected to the newly saved notebook. There is no kernel session transfer (from untitled to saved notebook) currently.
Save As is handled by core. Need to transfer current controller to new ipynb.
Seems related to
Not sure - we are handling this the same way we persist selection and other view state. But the editor still gets reopened with a new model. Dunno how this concept works in custom editors.
Custom editors have one the untitled editor closed and a new one with another URI open, I want a signal that a custom editor can handle to upgrade it so no close/open needs to happen
Steps: Open an untitled jupyter notebook Select a kernel Save the notebook The same kernel should be selected The "Set kernel as default" gear icon in the kernel picker was also removed.
Verified with this "kernel"
Change:
default: true }, [TerminalSettingId.WordSeparators]: { <del> description: localize('terminal.integrated.wordSeparators', "A string containing all characters to be considered word separators by the double-click to select word feature."), </del> <ins> markdownDescription: localize('terminal.integrated.wordSeparators', "A string containing all characters to be considered word separators when double-clicking to select word and in the fallback 'word' link detection. Since this is used for link detection, including characters such as `:` that are used when detecting links will cause the line and column part of links like `file:10:5` to be ignored."), </ins> type: 'string', // allow-any-unicode-next-line default: ' ()[]{}',"`─‘’|'

Discussion:
does this reproduce in insiders? There was a similar issue I looked into recently. To help diagnose, you can set the log level to trace via the command palette, hover the line with the link, then check the "Terminal" channel in the Output panel (this is new to insiders).
Yes, latest insiders version also doesn't work:
I can't reproduce this so the logging requested above might be able to identify the problem.
I found that is caused because I set: which include
As the setting description say, should only affect the word selection, but affect the link detection now.
Change:
const rootUri = e.element.repository.provider.rootUri; const multiDiffSourceUri = rootUri ? <del> rootUri.with({ scheme: 'scm-history-item', path: `${rootUri.path}/${historyItem.id}` }) : { scheme: 'scm-history-item', path: `${e.element.repository.provider.label}/${historyItem.id}` }; </del> <ins> rootUri.with({ scheme: 'scm-history-item', path: `${rootUri.path}/${historyItem.id}..${historyItemParentId}` }) : URI.from({ scheme: 'scm-history-item', path: `${e.element.repository.provider.label}/${historyItem.id}..${historyItemParentId}` }, true); </ins> await this.commandService.executeCommand('_workbench.openMultiDiffEditor', { title, multiDiffSourceUri, resources: historyItemChanges }); }

Discussion:
Testing Have remote commits. Click on a remote commit to view the commit Use the commit menu to view the commit Expected: Focus shifts to the already opened editor Actual: New diff editor opened for the commit. !
Change:
'type': 'string', 'enum': ['text', 'hidden'], 'default': 'text', <del> 'markdownDescription': localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'untitledHint' }, "Controls if the untitled hint should be inline text in the editor or a floating button or hidden.") </del> <ins> 'markdownDescription': localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'untitledHint' }, "Controls if the untitled text hint should be visible in the editor.") </ins> }, 'workbench.editor.languageDetection': { type: 'boolean',

Discussion:
Not a bug really but it's not really a feature request or question either. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: macOS Big Sur 11.6.6 Steps to Reproduce: to Code Preferences Settings Workbench Editor Management description for the Untitled: Hint setting says "Controls if the untitled hint should be inline text in the editor or a floating button or hidden." but there is not an option in the select list for a floating button. If the button feature was removed, then this description should be updated to reflect that.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Issue is still there in 1.68.1.
For reference, the setting ID is , and the setting description does appear to be outdated. Assigning to
Change:
) { super(options, keybindingService, contextMenuService, configurationService, contextKeyService, viewDescriptorService, instantiationService, openerService, themeService, telemetryService); this.scrollLockContextKey = CONTEXT_OUTPUT_SCROLL_LOCK.bindTo(this.contextKeyService); <del> this.editor = instantiationService.createInstance(OutputEditor); </del> <ins> const editorInstantiationService = instantiationService.createChild(new ServiceCollection([IContextKeyService, this.scopedContextKeyService])); this.editor = editorInstantiationService.createInstance(OutputEditor); </ins> this._register(this.editor.onTitleAreaUpdate(() => { this.updateTitle(this.editor.getTitle()); this.updateActions();

Discussion:
! Observed by
Do you have special steps for this? Do you see this with all output channels or only the MySQL one? Can you do the following when this happens: F1 Inspect Context Keys and then share what's printed on dev tools console
No specific repro steps - this happened immediately after upgrading in a test session - will try to repo on desktop doing it and report back!
Hi there, I think I received this email erroneously? I'm Nick Carver, but it looks like the original msg was from a Nick Craver. Cheers, Nick.
any new insights here?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Apologies I was on vacation for a bit - haven't been able to repro this since the latest update landed (but also have to unfortunately rebuild the machine we saw it on for terribad Windows reasons). Recommend we close this and if I can repro, will poke with more info :)
Leaving this open since saw this once but forgot to inspect context keys ()
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
steps: empty profile have a file under merge-conflict open the output view open the merge editor for the conflict file :bug: output view shows the merge overlay button
Change:
} // store the scrollTop before it is reset const scrollTopBefore = this.keepScrollPosition ? this.scrollTop : 0; <del> const hideInput = !!this._hideInput && this._items.length > 0; this.ui.container.classList.toggle('hidden-input', hideInput && !this.description); </del> <ins> const hasDescription = !!this.description; </ins> const visibilities: Visibilities = { title: !!this.title || !!this.step || !!this.buttons.length, <del> description: !!this.description, </del> <ins> description: hasDescription, </ins> checkAll: this.canSelectMany && !this._hideCheckAll, checkBox: this.canSelectMany, <del> inputBox: !hideInput, progressBar: !hideInput, </del> <ins> inputBox: !this._hideInput, progressBar: !this._hideInput || hasDescription, </ins> visibleCount: true, count: this.canSelectMany, ok: this.ok === 'default' ? this.canSelectMany : this.ok,

Discussion:
Testing Quick pick flickers ! First screen (is only visible for ~100 ms on my machine): ! Second screen: !
This looks like
I do not think so, this is different than other issue. I think the flickering is coming from loading the quick pick options. I am showing the quick pick and loading the options by setting the busy flag of quick pick to true. May be I can load the options and show the quick pick, but there might be a delay between clicking the export button and seeing the quick pick
Transferring this to you because, I am loading and showing the check box items async mean while I am using the busy indicator. I assume all quick picks have same issue if the items are shown async.
Looks like the input box is the problem here. Settings Sync likes to hide it and it should really just be hidden before showing.
Change:
return; } delete this._activeTasks[key]; <del> this._removeInstances(taskToRemove.task); </del> } private _fireTaskEvent(event: ITaskEvent) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 and older and (with slightly different behavior) insiders as of 5/4/2023 OS Version: MacOS 13.3.1 (a) Steps to Reproduce: Use these commands to produce and launch a suitable project: First bug: in either 1.78.0 or the nightly, use to launch , then hit Cmd-Shift-B to launch . You end up with two copies of running, when it should have an implicit of 1. Hit Cmd-Shift-B again, and it will tell you you've hit the instance limit. The problem here is that dependent tasks don't count towards the instance limit. Second bug: Now add to , and repeat the above. There is no change in the nightly (as you might expect), but surprisingly 1.78.0 now reports that it can't start a second copy. But thats just a bug; if you change it to and repeat, 1.78.0, still tells you it can't launch a second copy. This bug was fixed by , so I'm just including it for completeness. Third bug: Add to . Now hit Cmd-Shift-B to launch , then use to launch . will (correctly) re-use the already running task, rather than launching a new one. Now kill all the terminals (to make the next step less confusing). Hit Cmd-Shift-B to launch sleeper, wait 5 seconds, and hit Cmd-Shift-B again, wait another 5 seconds for the first task to finish, and then run .

Now, although the second task is still running, starts a new one. The issue here is that when looking for an existing dependent task, uses the task's , which only matches the first instance of a task with greater than 1 (and here, that task has already finished).
Change:
addNewLine?: boolean; } <ins> /** * A matcher that runs on a sub-section of a terminal command's output */ </ins> export interface ITerminalOutputMatcher { <ins> /** * A string or regex to match against the unwrapped line. */ </ins> lineMatcher: string | RegExp; <del> anchor?: 'top' | 'bottom'; offset?: number; length?: number; </del> <ins> /** * Which side of the output to anchor the {@link offset} and {@link length} against. */ anchor: 'top' | 'bottom'; /** * How far from either the top or the bottom of the butter to start matching against. */ offset: number; /** * The number of rows to match against, this should be as small as possible for performance * reasons. */ length: number; </ins> } export interface IXtermTerminal {

Discussion:
Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to
getOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?
The second one: !
Oh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.
Change:
public computeStagedValue(mapping: DetailedLineRangeMapping): string { const c = mapping.innerChanges ?? []; <del> const edit = new TextEdit(c.map(c => new SingleTextEdit(c.originalRange, this._editors.modifiedModel.get()!.getValueInRange(c.modifiedRange)))); const value = edit.apply(new TextModelText(this._editors.original.getModel()!)); </del> <ins> const modified = new TextModelText(this._editors.modifiedModel.get()!); const original = new TextModelText(this._editors.original.getModel()!); const edit = new TextEdit(c.map(c => c.toTextEdit(modified))); const value = edit.apply(original); </ins> return value; }

Discussion:
Type: <bBug</bStep 1: Create a file named with this content: Step 2: create an empty file named Step 3: Move with a terminal in the folder containing the files and run Step 4: Click on the arrow button and see that it doesn't work ! VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (38)</summaryExtensionVersion ------ vscode-nginx-conf0.3.5 swagger-viewer3.1.2 freezed0.9.6 ccs-flutter-color1.2.4 dart-code3.86.0 flutter3.86.0 jquerysnippets0.0.1 es7-react-js-snippets4.4.3 vscode-html-css2.0.9 copilot1.180.0 copilot-chat0.14.1 vscode-github-actions0.26.2 vscode-pull-request-github0.86.1 gc-excelviewer4.2.59 todo-tree0.0.226 vscode-nginx-conf-hint0.3.1 latex-workshop9.20.0 vscode-edit-csv0.9.1 plantuml2.18.1 vscode-peacock4.2.2 dotenv1.0.1 vscode-docker1.29.0 debugpy2024.5. isort2023.13. python2024.5. vscode-pylance2024.4.102 remote-containers0.354.0 cpptools1.19.9 vscode-thunder-client2.21.11 nginx-formatter0.0.13 vscode-xml0.26.1 vscode-yaml1.14.0 scala0.5.7 markdown-preview-enhanced0.8.13 even-better-toml0.19.2 vscode-icons12.7.0 vscode-nginx0.7.2 txt-syntax0.2.2 </details
working on this
Oh wow I did not realize this was fixed. I've been working on it and just submitted a PR for a similar issue.
My solution was also very similar.
sorry! It was tricky to fix though.
Change:
registerDebugViewMenuItem(MenuId.DebugCallStackContext, STEP_OUT_ID, STEP_OUT_LABEL, 40, CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('thread'), CONTEXT_DEBUG_STATE.isEqualTo('stopped')); registerDebugViewMenuItem(MenuId.DebugCallStackContext, TERMINATE_THREAD_ID, nls.localize('terminateThread', "Terminate Thread"), 10, CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('thread'), undefined, 'termination'); registerDebugViewMenuItem(MenuId.DebugCallStackContext, RESTART_FRAME_ID, nls.localize('restartFrame', "Restart Frame"), 10, ContextKeyExpr.and(CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('stackFrame'), CONTEXT_RESTART_FRAME_SUPPORTED), CONTEXT_STACK_FRAME_SUPPORTS_RESTART); <del> registerDebugViewMenuItem(MenuId.DebugCallStackContext, COPY_STACK_TRACE_ID, nls.localize('copyStackTrace', "Copy Call Stack"), 20, CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('stackFrame')); </del> <ins> registerDebugViewMenuItem(MenuId.DebugCallStackContext, COPY_STACK_TRACE_ID, nls.localize('copyStackTrace', "Copy Call Stack"), 20, CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('stackFrame'), undefined, '3_modification'); </ins> registerDebugViewMenuItem(MenuId.DebugVariablesContext, SET_VARIABLE_ID, nls.localize('setValue', "Set Value"), 10, CONTEXT_SET_VARIABLE_SUPPORTED, undefined, '3_modification'); registerDebugViewMenuItem(MenuId.DebugVariablesContext, COPY_VALUE_ID, nls.localize('copyValue', "Copy Value"), 10, undefined, undefined, '5_cutcopypaste');

Discussion:
Testing As already pointed out The "Open Disassembly View" command is now only visible when the active stackframe has a instructionPointerReference property. This makes it hard to discover. I suggest to have the context menu's "Open Disassembly View" command always visible if a debug adapter has the supportsDisassembleRequest capability. But the command should only be enabled if the active stackframe has a instructionPointerReference property. That results in a more stable user experience. Apart from that we should have the Open Disassembly View command in the command palette.
That's a fair suggestion. However, we are not sure how to disable a command...
commands have clauses and . clause determines if the command is present at all and if it is disabled. So please use the when registering the editor command for disablement.
Also we should consider to introduce a call stack context menu action for the Open Disassembly View.
will fix this.
Change:
registerEditorContribution(StickyScrollController.ID, StickyScrollController); <ins> registerAction2(class ToggleStickyScroll extends Action2 { constructor() { super({ id: 'editor.action.toggleStickyScroll', title: { value: localize('toggleStickyScroll', "Toggle Sticky Scroll"), mnemonicTitle: localize('miStickyScroll', "&&Sticky Scroll"), original: 'Toggle Sticky Scroll', }, // Hardcoding due to import violation category: { value: localize('view', "View"), original: 'View' }, toggled: ContextKeyExpr.equals('config.editor.experimental.stickyScroll.enabled', true), menu: [ { id: MenuId.CommandPalette }, { id: MenuId.MenubarViewMenu, group: '5_editor', order: 6 }, ] }); } override async run(accessor: ServicesAccessor): Promise<void> { const configurationService = accessor.get(IConfigurationService); const newValue = !configurationService.getValue('editor.experimental.stickyScroll.enabled'); return configurationService.updateValue('editor.experimental.stickyScroll.enabled', newValue); } }); </ins>

Discussion:
Type: <bFeature Request</bThere is a bit of space at the start of the breadcrumb which could accommodate a pin / pinned codicon with which to toggle the stickyScroll setting. ! When no DocumentSymbolProvider is available the space could either be blank or could show the pin codicon if the setting is currently false and the pinned-dirty if true, with a hover tip explaining why sticky scrolling isn't happening for the current document. /assign VS Code version: Code - Insiders 1.71.0-insider (, 2022-08-10T05:17:53.560Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
Thanks for the idea, I will bring it up in the UX Sync today
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<img width="661" alt="Screenshot 2022-08-16 at 10 40 37" src="https://user-"I would go with the more traditional entry in the "View"-menu first, similar to existing action. The pin/unpin icon in breadcrumbs might be seen as noisy for when you don't want to use sticky scroll (appears like an ad) This is how it is done for the We can also combine this with and add context menu entries for breadcrumbs and sticky-scroll to toggle them in-place
I'll look into this
Change:
} function getStringValidators(prop: IConfigurationPropertySchema) { <ins> const uriRegex = /^(([^:/?#]+?):)?(//([^/?#]*))?([^?#]*)(?([^#]*))?(#(.*))?/; </ins> let patternRegex: RegExp | undefined; if (typeof prop.pattern === 'string') { patternRegex = new RegExp(prop.pattern); } return [ { enabled: prop.maxLength !== undefined,

Discussion:
Found this issue while trying to set 's format to uri (or uri-reference), in order to fix <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider () OS Version: Mac OS 10.14.6 Steps to Reproduce: a "mysetting" setting define "format":"uri" (as documented in ) settings in UI, write then delete some value, no error is shown , see that has a warning: <img width="1155" alt="Screen Shot 2020-01-15 at 7 44 33 PM" src="https://user-"The validation error should be displayed in the UI too (as it does when using a validation pattern) <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Maybe
I guess we are missing that validation, also, the type of that setting should be if the default is "null".
I can try working on this. Any code pointers, though? Not sure where to look.
See for where these validations for the settings editor live. You need to figure out what validation the json language server does for . I assume that lives somewhere in but I don't know where. I can help you if you can't find it.
Verifier: the extension and search in the settings editor different values in the textbox that shows up. The empty string should not be accepted, and a string such as should not be accepted. However, , , and should be accepted.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!