jiebi/CodeConvo huggingface dataset:
Change:
".dsql" ], "aliases": [ <del> "SQL" </del> <ins> "MS SQL", "T-SQL" </ins> ], "configuration": "./language-configuration.json" }

Discussion:
Postgres supports dollar quoted strings as an alternative to regular strings. This is useful when you need to include the character itself but don't want to escape it. The official documentation can be found . Unfortunately, the default SQL highlighter in VSCode does not seem to support this syntax. Steps to Reproduce to a new file the "SQL" language mode the following content: Expected should not start a new string. The content between and should be identified as a string and highlighted as such. Actual ! Additional context Version: 1.91.1 Commit: User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Embedder: Also tested in the desktop version with identical results.
Note that there may be good reason the editor tries to highlight code in the dollar quoted block. Dollar quoted strings are often used to declare function bodies in postgres and there are therefore (perhaps most commonly) instances where the content inside the dollar signs would be better off using "regular" sql highlighting. However, the reported issue is very annoying as it breaks highlighting for the rest of the file. If implementing a full parser with support for these types of "sometimes strings" requires too much effort, a passable alternative would be to at least stop the highlighter from leaking outside the dollar quoted scope.
Th grammar we have is for MS SQL and doesn't support features outside that. Duplicate of
In that case, I think you should rename the user-visible language mode to "MSSQL" rather than "SQL". I find just calling it "SQL" to be a deceptive marketing practice if you are not going to support other SQL dialects in it.
It is fair to say that MS SQL won't work for all SQL flavors. I will discuss renaming it with the team.
Based on some quick digging, MS SQL uses Transact-SQL (T-SQL). The most appropriate thing to rename the built in SQL grammar to would be T-SQL. However, I'm not sure that T-SQL will mean something to most users.
I'm going to wait and try renaming at the very beginning of our next milestone so that I can see if any insiders users are thrown off first.
I think T-SQL is not well known enough and will be confusing.

I'll try renaming to MS SQL.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
To verify: Open a file in VS Code Open the language picker from the status bar Verify that you don't see SQL, but instead see MS SQL
Change:
}, { "name": "CSS Property Value", <del> "scope": "meta.property-group support.constant.property-value.css, meta.property-value support.constant.property-value.css", </del> <ins> "scope": "meta.property-group support.constant.property-value, meta.property-value support.constant.property-value", </ins> "settings": { "fontStyle": "", "foreground": "#C7444A"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0 OS Version: macOS 14.2.1 Steps to Reproduce: the Monokai Dimmed theme a .less file that the syntax higlighting colors are very different to the previous release This is what the less syntax highlighting looked like in v1.85.2 with the Monokai Dimmed theme enabled: ! And this is what it looks like in 1.86.0: ! The main problem is that property names are now the same color as property values that are keywords - e.g. , & - but it's also a bit annoying that LESS variables are no longer a uniform color. I've checked a few other color themes and they don't seem to have this problem. This is a bit of a guess but maybe Monokai Dimmed needs to be updated following the changes introduced in ?
Yes, agree, this needs an update here:
Change:
// this method is called when vs code is activated export function activate(context: ExtensionContext) { <del> const serverMain = context.asAbsolutePath('server/dist/browser/jsonServerMain.js'); </del> <ins> const serverMain = Uri.joinPath(context.extensionUri, 'server/dist/browser/jsonServerMain.js'); </ins> try { <del> const worker = new Worker(serverMain); </del> <ins> const worker = new Worker(serverMain.toString()); </ins> const newLanguageClient: LanguageClientConstructor = (id: string, name: string, clientOptions: LanguageClientOptions) => { return new LanguageClient(id, name, clientOptions, worker); };

Discussion:
The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API
fyi
tried to adopt this. When will be available. I can't find it in .
Opened for ESLint
It's in the API since 4 months:
Change:
const that = this; const originalWindowFocus = auxiliaryWindow.focus.bind(auxiliaryWindow); auxiliaryWindow.focus = function () { <ins> if (that.environmentService.extensionTestsLocationURI) { return; // no focus when we are running tests from CLI } </ins> originalWindowFocus(); if (!auxiliaryWindow.document.hasFocus()) {

Discussion:
Since the november 2023 update steals window focus. This is really problematic because uses this to run end to end tests and now the development host window pops up for every single test case, which renders all other windows unusable while I’m running tests, as the test window steals focus many times per second. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 (user setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: extension host vscode main window the following code: vscode extension development host window is now focused.
We should add rules to not change focus during extension development tests.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I can reproduce this: an extension that activates : 5, and immediately focus back to the VS Code window you F5'd from When executes, the ext dev host window will regain focus
Sorry, bad description: its only disabled when running extension tests.
Change:
/** * Log the given debug message to the channel. * <del> * Messages are only printed when the user has enabled debug logging. </del> <ins> * Messages are only logged when the {@link LogOutputChannel.logLevel log level} is {@link LogLevel.Debug debug} or lower. </ins> * * @param message debug message to log */

Discussion:
Testing the API lacks an explanation of the interaction between channel log levels and app log levels. the comments of the individual log methods all have the form "Messages are only printed when the user has enabled xxx logging" but nowhere is explained how "xxx logging enablement" is related to the log level. I would rather expect something like "xxx messages are only logged when the log level is xxx or lower."
Change:
import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { Position } from 'vs/editor/common/core/position'; <ins> import { Range } from 'vs/editor/common/core/range'; </ins> import { rot } from 'vs/base/common/numbers'; import { KeybindingsRegistry, KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { EmbeddedDiffEditorWidget } from 'vs/editor/browser/widget/embeddedCodeEditorWidget';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (depends on language) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Windows/Linux (does not matter for this bug) The problem is, if you set the to higher value like 10, vscode will starts to scroll the editor if i open a peek editor with the or similar commands (even if the editor would easily fit in the remaining area under the active line). I use 100 as a value for the surrounding lines to keep the cursor vertically in the middle, so i dont need to scroll when i move between lines, but this way when i open any peek editor, vscode will scrolls the active line to the top. If the peek editor can fit under the active line, it should not scroll the editor. I tested this with python, c++, and javascript, so this scrolling issue is not caused by extensions. It works exactly the same way with all of these languages. With javascript it occures even if vscode was started with . Steps to Reproduce: Place this in your (or use the settings editor) a file that has functions in it. the command. active line will be scrolled to the top, no matter what. !
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
The peek widget reveal the line it and that causes the shift. Tho, when we would reveal the line above it would cut off the button of the peek widget. We might need a way to reveal a line without honouring the surrounding lines setting
Change:
} } })); <ins> this._register(this._editorService.onDidActiveEditorChange(() => { const instance = this._editorService.activeEditor instanceof TerminalEditorInput ? this._editorService.activeEditor : undefined; if (!instance) { for (const instance of this.instances) { instance.resetFocusContextKey(); } } })); </ins> } private _getActiveTerminalEditors(): EditorInput[] {

Discussion:
https://user- As shown in the recording, when I tried to paste in the editor The terminal paste command is matched, meaning that the terminal is still "focused" based on the context keys The terminal shows a context menu for paste. We are not seeing this in the editor, the terminal should handle in the same way
As long as the terminal is opened once, I have to reload the window to get it fixed.
I think this means that this isn't happening on safari for some reason
This gets hit even when I click in the editor area !
Still reproduced on latest codespace with VS Code insider bits.
Had a call, we believe it's happening because we set when hiding the panel which caused the blur/focusout events to not fire. We also noticed this happens in terminal editors as well. So to fix we need to reset or refresh the state of the context key when the terminal panel/view is hidden as well as when the terminal editor is hidden. Something to verify when these changes are made is to make sure if you have a single terminal editor and a single terminal in the panel, toggling the panel should still keep because the terminal editor will now be focused (ie. the panel hide context key reset should happen before the terminal editor focus is handled).
Change:
const prevMarkerKeybinding = this._keybindingService.lookupKeybinding(PrevMarkerAction.ID); const nextMarkerKeybinding = this._keybindingService.lookupKeybinding(NextMarkerAction.ID); const actions = [ <del> new Action(PrevMarkerAction.ID, PrevMarkerAction.LABEL + (prevMarkerKeybinding ? ` (${prevMarkerKeybinding.getLabel()})` : ''), 'show-previous-problem codicon-chevron-up', this._model.canNavigate(), async () => { if (this._model) { this._model.move(false, true); } }), new Action(NextMarkerAction.ID, NextMarkerAction.LABEL + (nextMarkerKeybinding ? ` (${nextMarkerKeybinding.getLabel()})` : ''), 'show-next-problem codicon-chevron-down', this._model.canNavigate(), async () => { if (this._model) { this._model.move(true, true); } }) </del> <ins> new Action(NextMarkerAction.ID, NextMarkerAction.LABEL + (nextMarkerKeybinding ? ` (${nextMarkerKeybinding.getLabel()})` : ''), 'show-next-problem codicon-chevron-down', this._model.canNavigate(), async () => { if (this._model) { this._model.move(true, true); } }), new Action(PrevMarkerAction.ID, PrevMarkerAction.LABEL + (prevMarkerKeybinding ? ` (${prevMarkerKeybinding.getLabel()})` : ''), 'show-previous-problem codicon-chevron-up', this._model.canNavigate(), async () => { if (this._model) { this._model.move(false, true); } }) </ins> ]; this._widget = new MarkerNavigationWidget(this._editor, actions, this._themeService); this._widgetVisible.set(true);

Discussion:
have a file with an error press F8 press Ctrl+M to toggle that Tab moves focus press Tab once the focus moves first to the close button, then the up button, and finally the down button. ! <details<summaryOLD DESCRIPTION from Details:​ ​​ ​​ Browser Details: ​​​ Microsoft Edge 44..1.0, Google Chrome 75.0.3770.142​ ​OS: Windows (Version 1903, Build: .113)​​ ​ Repro Steps: ​​​ 1) Hit the URL ""​​ 2) Navigate till "Playground" link and press enter​​ 3) Tab till editor field and type any wrong code. ​ 4) Press F8 or Shift+F8 to open the errors​ 5) Verify the focus order between "Go to next problem, Go to previous problem and close" buttons​ Actual Result: ​​​ Focus order is not proper between "Go to next problem, Go to previous problem and close" buttons. Focus order is given in the wrong sequence as close--Go to previous problem --Go to next problem​ ​​ Expected Result: ​​​ When user press Tab key focus order should in the sequence as ​ Go to next problem--Go to previous problem--close​ ​ User Impact: ​​​ Keyboard users will find difficult to work if focus order is not proper between the controls​ Video Attachment: </details
Change:
return '(' + remaining + ' ' + text + ')'; } <ins> private updateCharCountText(): void { this.remainingCharacterCount.text(this.getCharCountText(this.feedbackDescriptionInput.value.length)); this.feedbackDescriptionInput.value ? this.sendButton.removeAttribute('disabled') : this.sendButton.attr('disabled', ''); } </ins> protected setSentiment(smile: boolean): void { if (smile) { this.smileyInput.addClass('checked');

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?
Change:
) { super(); <del> this.primaryMenu = this._register(menuService.createMenu(this.notebookEditor.creationOptions.menuIds.cellExecutePrimary!, contextKeyService)); this.secondaryMenu = this._register(menuService.createMenu(this.notebookEditor.creationOptions.menuIds.cellExecuteToolbar, contextKeyService)); </del> <ins> this.primaryMenu = this._register(menuService.createMenu(primaryMenuId, contextKeyService)); this.secondaryMenu = this._register(menuService.createMenu(secondaryMenuId, contextKeyService)); </ins> this.createRunCellToolbar(runButtonContainer, cellContainer, contextKeyService); const updateActions = () => { const actions = this.getCellToolbarActions(this.primaryMenu);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (only the jupyter and python extensions enabled) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.94.0-insider (user setup) Commit: Date: 2024-09-16T05:03:40.122Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: I restarted VSCode to install the latest update (above), and now python interactive sessions do not print output of cells in the interactive window. After running a cell in a interactive session: Using the jupyter extension, one can see that the variables are created in memory, but there is no output in the interactive window. Tested with a jupyter notebook, output is correctly printed below the cells: ! Output of "window" after running a single cell in an interactive session: <details<summaryShow output (large)</summary</details
As clarification: nothing is shown in the interactive window, not just output "input" cells are not shown either Only the "Connected to kernel", "restarting kernel" or "kernel restarted" messages
likely a regression from
Same thing happened to me. Though the jupyter panel shows the variables created by running the code, the interactive window shows nothing. (see image below) !
actually caused by , but only because we are creating a menu with an undefined ID by overriding a type restriction here:
Change:
import { defaultButtonStyles, defaultProgressBarStyles } from 'vs/platform/theme/browser/defaultStyles'; import { ICustomHover, setupCustomHover } from 'vs/base/browser/ui/hover/updatableHoverWidget'; import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; <ins> import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; </ins> export enum ViewPaneShowActions { /** Show the actions when the view is hovered. This is the default behavior. */

Discussion:
Reloading a window seems to reset the view state, I think thats not really needed, but not sure how this is triggered? !
This is from here: Arguably that listener should not run when we dispose the workbench, but maybe we cannot address this, will see.
Change:
"markdown.preview.toggleLock.title": "Toggle Preview Locking", "configuration.markdown.preview.openMarkdownLinks.description": "How should clicking on links to markdown files be handled in the preview.", "configuration.markdown.preview.openMarkdownLinks.inEditor": "Try to open links in the editor", <del> "configuration.markdown.preview.openMarkdownLinks.inPreview": "Try to open links in the markdown preview" } </del>  No newline at end of file <ins> "configuration.markdown.preview.openMarkdownLinks.inPreview": "Try to open links in the markdown preview", "configuration.markdown.editor.openMarkdownLinks.description": "How following links to markdown files be handled in the editor.", "configuration.markdown.editor.openMarkdownLinks.inCurrentGroup": "Try to open links in the current editor group", "configuration.markdown.editor.openMarkdownLinks.openToSide": "Try to open links to the Side" } </ins>

Discussion:
Scenario: Markdown file is open in left editor group. This file has a lot of links to other .md files that I want to preview in the right editor group. But Markdown links can currently only be opened into the same editor. Please consider. Thanks!
Adding per our discussion about this one
Do you mean that you would like an option to make the command to open the preview to the left instead of to the right of the current editor?
No, sorry, I should have been more specific. Here's what I mean: -click to open a .md file in a persistent editor in Code, preferably a file with many links to other local .md files. the file, Ctrl+click a link to another .md file. other file opens in a new editor, in the same editor group. Desired: open the link as a raw .md file in a new or existing (separate) editor group. Then, when I go back to the original file and ctrl+click another .md link, open that raw .md into the same editor group the previous one opened into. So I can quickly ctrl+click through a bunch of links and see the raw .md while my original file (the one with all the links) stays in view.
Ok, thanks for explaining the expected behavior in more detail. Marking as help wanted if anyone wants to investigate this. To get started, look at: This is where we map markdown links to command links This is where we convert the command into an editor action. Instead of opening in the current editor, we would want to open in a new editor group here
For verification: new setting was called are two options: (the default) and links in md text files (not the preview) should respect this option default behavior should be to open links in the current group
Can't verify because of
I can verify this on Mac.
Thanks for adding this!