Change:
return; } <del> const result = await this._dialogService.confirm({ title: nls.localize('unusualLineTerminators.title', "Unusual Line Terminators"), message: nls.localize('unusualLineTerminators.message', "Detected unusual line terminators"), detail: nls.localize('unusualLineTerminators.detail', "The file '{0}' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.", basename(model.uri)), primaryButton: nls.localize('unusualLineTerminators.fix', "Remove Unusual Line Terminators"), secondaryButton: nls.localize('unusualLineTerminators.ignore', "Ignore") }); </del> <ins> if (this._isPresentingDialog) { // we're currently showing the dialog, which is async. // avoid spamming the user return; } let result: IConfirmationResult; try { this._isPresentingDialog = true; result = await this._dialogService.confirm({ title: nls.localize('unusualLineTerminators.title', "Unusual Line Terminators"), message: nls.localize('unusualLineTerminators.message', "Detected unusual line terminators"), detail: nls.localize('unusualLineTerminators.detail', "The file '{0}' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.", basename(model.uri)), primaryButton: nls.localize('unusualLineTerminators.fix', "Remove Unusual Line Terminators"), secondaryButton: nls.localize('unusualLineTerminators.ignore', "Ignore") }); } finally { this._isPresentingDialog = false; } </ins> if (!result.confirmed) { // this model should be ignored

Discussion:
Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
could you post some steps to verify?
I could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.
Verified by code review
unfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D