jiebi/CodeConvo huggingface dataset:
Change:
bindings "^1.5.0" node-addon-api "^6.0.0" <del> "@vscode/proxy-agent@^0.13.1": version "0.13.1" resolved "https://registry.yarnpkg.com/@vscode/proxy-agent/-/proxy-agent-0.13.1.tgz#c03e9a9d65b62c762f31fa95bf9d9f52372c4825" integrity sha512-6z/EQ4IrVYJ35f7g/HoDsVIcBjBHJtUOe/msBoTQ6B/LN2TTlxTHH1TWAwMxQgKZkKrjD5JJG2ZJN8qThQlVaQ== </del> <ins> "@vscode/proxy-agent@^0.13.2": version "0.13.2" resolved "https://registry.yarnpkg.com/@vscode/proxy-agent/-/proxy-agent-0.13.2.tgz#0d289826c07faecc4ca07de80a8e5a9459d06119" integrity sha512-BSUd0NTj44WvG4O9A6N+4R1XhxtPqCYltWeHyNkquX9T//a1US+cd8fxzcZCPd3z7dygdYIPkZAKM+CrefWWOA== </ins> dependencies: "@tootallnate/once" "^1.1.2" agent-base "^6.0.2"

Discussion:
Copied from
By based on the error from , looks like this commit was not released and consumed in VSCode
I assume this change was done in March and therefore it also exists in 1.77.0 ?
Not sure why you're assuming the change was done in March. The change was done in April: It's new in 1.78.0. This breaks automatic proxy discovery in the extension host on Windows platforms only. I don't think it's a stop ship because: affects extension host on Windows only. affects users who rely on automatic proxy discovery. There is a workaround: manually configure the proxy on VS Code. were seemingly no reports of breakage the entire month of April on Insiders. I suggest merging the fix in as a candidate of an April recovery milestone. Leaving it to you as endgame champ, to chime in.
Because I saw the dependency on was in March - May be this is nothing to do with this change. I agree to take this as a candidate for next recovery
Just to clarify: This breaks loading of OS certificates on Windows (not proxy discovery). This will affect users relying on self-signed certificates for development and those requiring a CA certificate from their network proxy. Only HTTP/S requests made by extensions using the Node API are affected.
Can a test get to prevent this from happening again?
This is also affecting remote-containers extension. I'm trying to open a folder in my remote linux machine using remote-containers extension in vscode(windows workstation). It just silently fails with the following error:
Thanks Manually setting the proxy in remote settings worked for me !
Verification: VS Code on Windows the output channel that there's no exception regarding <img width="1026" alt="image" src=""
Change:
"optimist": "0.3.5", "p-all": "^1.0.0", "path-browserify": "^1.0.1", <del> "playwright": "1.12.3", </del> <ins> "playwright": "1.14.1", </ins> "pump": "^1.0.1", "queue": "3.0.6", "rcedit": "^1.1.0",

Discussion:
This code seems to reach into the module: When trying to update to the file is no longer found and seems gone.
Change:
const outputChannelLogger = new OutputChannelLogger(); disposables.push(outputChannelLogger); <del> disposables.push(new GitProtocolHandler(outputChannelLogger)); </del> const { name, version, aiKey } = require('../package.json') as { name: string; version: string; aiKey: string }; const telemetryReporter = new TelemetryReporter(name, version, aiKey); deactivateTasks.push(() => telemetryReporter.dispose());

Discussion:
't have a git repo open in desktop VS Code Insiders web, enter the following into the address bar and hit enter :bug: desktop VS Code Insiders reports that git is not installed and fails to clone the url I believe the reason this happens is that as soon as the git extension calls , the API impl immediately tries to flush its buffer of URIs to be handled. Because we are now registering the uri handler early in the extension activation method, the git extension hasn't yet run discovery of the git executable and registered commands appropriately, so the handler gets called before the git extension is ready to handle the clone. The fix is to unconditionally register the uri handler as intended in , but to do it only after we've already attempted to locate git and register commands
Change:
// Resources (Tree), History item changes (Tree) const children: TreeElement[] = []; for (const node of inputOrElement.children) { <del> children.push(node.element ?? node); </del> <ins> children.push(node.element && node.childrenCount === 0 ? node.element : node); </ins> } return children;

Discussion:
Type: <bBug</bObserved with a custom extension on a Clearcase SCM, but can be easily reproduced with SVN too, probably with any SCM that treats directories as versionable entities. How to reproduce: the SVN extension (I wish we could skip this step, but git does not version directories, so we can't reproduce with that) a svn repository a dir a file or more in that dir add dir svn repo in vscode, inspect the SCM view entities in List mode to tree mode Expected result: both the dir and the file are shown, preferably with the right badge; Actual result: dir children are omitted; Sample List mode SCM view: ! Sample Tree mode SCM view (same content of the repo): ! This is most likely a recent regression (possibly starting today's Insiders build, but I'm not 100% sure). VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-10T05:35:29.445Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 Remote OS version: Linux x64 4.4.0-64-generic <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ remote-ssh0.108. remote-explorer0.5. rewrap17.8.0 svn-scm2.17.0 </details<!-- generated by issue reporter --
cc - Sorry for the ping, is it possible this was caused by the recent sticky scroll addition (great feature, btw)?
may be relevant so pinging
thank you very much for reporting this issue and will update the issue with my findings.
the fix for this will be included in Friday's Insiders release. I would really appreciate if you would download that tomorrow and confirm that the issue is resolved. Thanks again, and apologies for the inconveniences.
Hi, I saw the pending PR and that it just got merged, I will definitely test and confirm this asap. Thank you!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
const didChangeOpenEditorsSticky = this.stickyEditorTabsControl.openEditors(stickyEditors); const didChangeOpenEditorsUnSticky = this.unstickyEditorTabsControl.openEditors(unstickyEditors); <del> return didChangeOpenEditorsSticky || didChangeOpenEditorsUnSticky; </del> <ins> const didChange = didChangeOpenEditorsSticky || didChangeOpenEditorsUnSticky; if (didChange) { this.handleOpenedEditors(); } return didChange; } private handleOpenedEditors(): void { this.handlePinnedTabsSeparateRowToolbars(); </ins> } beforeCloseEditor(editor: EditorInput): void {

Discussion:
Testing ! I am still trying to recap how I got there... Update: have some pinned and non-pinned tabs open an empty group to the right drag the entire group to the right by dragging from empty space after the last tab you end up with 2 action bars visible
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import * as dom from 'vs/base/browser/dom'; import { toAction } from 'vs/base/common/actions'; import { coalesceInPlace } from 'vs/base/common/arrays'; </del> import { createCancelablePromise, CancelablePromise, RunOnceScheduler } from 'vs/base/common/async'; import { CancellationToken } from 'vs/base/common/cancellation'; import { onUnexpectedError } from 'vs/base/common/errors'; import { MarkdownString } from 'vs/base/common/htmlContent'; import { Disposable } from 'vs/base/common/lifecycle'; <del> import { LinkedList } from 'vs/base/common/linkedList'; </del> import { Schemas } from 'vs/base/common/network'; import * as platform from 'vs/base/common/platform'; import * as resources from 'vs/base/common/resources'; import { StopWatch } from 'vs/base/common/stopwatch'; <del> import { assertType } from 'vs/base/common/types'; </del> import { URI } from 'vs/base/common/uri'; import 'vs/css!./links'; import { ICodeEditor, MouseTargetType } from 'vs/editor/browser/editorBrowser'; import { EditorAction, EditorContributionInstantiation, registerEditorAction, registerEditorContribution, ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; import { Position } from 'vs/editor/common/core/position'; <del> import { IRange, Range } from 'vs/editor/common/core/range'; </del> import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { LanguageFeatureRegistry } from 'vs/editor/common/languageFeatureRegistry'; import { LinkProvider } from 'vs/editor/common/languages';

Discussion:
The content of the line: Open definition does nothing !
Also happens on Mac with Cmd+Click. Makes it very difficult to navigate my documentation.
I believe this is a result of fixing Markdown has a link provider and a definition provider. However in this case, the definition provider returns since we are not on a reference link
revert of the bad change is up
Change:
"command.timelineCopyCommitId": "Copy Commit ID", "command.timelineCopyCommitMessage": "Copy Commit Message", "config.enabled": "Whether git is enabled.", <del> "config.path": "Path and filename of the git executable, e.g. `C:Program FilesGitbingit.exe` (Windows).", </del> <ins> "config.path": "Path and filename of the git executable, e.g. `C:Program FilesGitbingit.exe` (Windows). This can also be an array of string values containing multiple paths to look up.", </ins> "config.autoRepositoryDetection": "Configures when repositories should be automatically detected.", "config.autoRepositoryDetection.true": "Scan for both subfolders of the current opened folder and parent folders of open files.", "config.autoRepositoryDetection.false": "Disable automatic repository scanning.",

Discussion:
I use VSCode in three different places; my home computer, my work computer, and as a portable version I carry on a drive when I need to use a machine that doesn't have it. I use an extension to keep my settings synced up between editors, and the only issue I've encountered so far is that the git path doesn't match between any of them. On my home machine I have it installed to C of course, work likes to be funny and install it on A, and for the one on my drive I have a relative path set so that no matter what letter my drive gets, that VSCode can always find git. I already attempted to use an array myself just to see if it'd work: But VSCode reads it as one entire value. What I'd like is for it to recognize it as an array and then try each path in order until it finds Git or runs out of paths.
It is better to create an issue in extension repo with requesting the settings ignore feature.
Hy
This is a good feature request, please feel free to submit a PR.
Ah, thanks. I must have just seen the section title and completely glossed over it when I was reading through the docs.
I could help out with this feature-request, if you would like. At a glance, it looks like it would require a modification to the "createModel()" function in the "" file (line 34). We could get the "pathHint" as a string array and then possibly modify the logic inside of the "findGit()" function, or, if possible, iterate through the "pathHint" array until a valid "" value is returned. EDIT: Sorry, didn't realize a PR was already submitted...
Raised PR!
Verification The setting now accepts a list of values. The git extension must go through them one by one until it finds a usable git executable.
Change:
this._createOrGetCommandDetection(this._terminal).handleCommandExecuted(); return true; case VSCodeOscPt.CommandFinished: { <del> const exitCode = args.length === 1 ? parseInt(args[0]) : undefined; </del> <ins> const arg0 = args[0]; const exitCode = arg0 !== undefined ? parseInt(arg0) : undefined; </ins> this._createOrGetCommandDetection(this._terminal).handleCommandFinished(exitCode); return true; } case VSCodeOscPt.CommandLine: { <ins> const arg0 = args[0]; const arg1 = args[1]; </ins> let commandLine: string; <del> if (args.length >= 1 || args.length <= 2) { commandLine = deserializeMessage(args[0]); </del> <ins> if (arg0 !== undefined) { commandLine = deserializeMessage(arg0); </ins> } else { commandLine = ''; } <del> this._createOrGetCommandDetection(this._terminal).setCommandLine(commandLine, args[1] === this._nonce); </del> <ins> this._createOrGetCommandDetection(this._terminal).setCommandLine(commandLine, arg1 === this._nonce); </ins> return true; } case VSCodeOscPt.ContinuationStart: {

Discussion:
Run a command - for example - then and it doesn't exit that command !
Same issue: Versione: 1.78.1 Commit: Data: 2023-05-04T09:57:42.343Z Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 Sistema operativo: Darwin x64 18.7.0 In modalità sandbox: No
insiders-releasecontrl+Cbash: no job control in this shell
me too!
I am also facing the same problem and it is quite frustrating since killing the terminal is not killing the process and every time I have identify the pid and kill it from another terminal. I notice that it is tagged "Closed" but it is not fixed as of yet, atleast in Code-Insiders. Please fix this issue or suggest some sort of solution.
me either
this clearly isn't fixed
The issue this was tracking with the error in console is fixed, let's track any separate problem in
Change:
...this._dynamicWorkspaceRecommendations, ...Object.keys(this._experimentalRecommendations), ]).filter(extensionId => this.isExtensionAllowedToBeRecommended(extensionId)); <del> shuffle(others); </del> <ins> shuffle(others, this.sessionSeed); </ins> return others.map(extensionId => { const sources: ExtensionRecommendationSource[] = []; if (this._exeBasedRecommendations[extensionId]) {

Discussion:
Testing When I open the Extensions Viewlet and choose from the overflow menu, I get a new/different list every time I execute the command. From a user's perspective, I don't understand why I keep getting a new list. I expect that when I issue the command VS Code shows me all of the recommended extensions. Otherwise, I keep clicking the menu to see what else might be recommended.
The ones that change are the tool based recommendations and the one we infer from telemetry. There is no ranking mechanism for these, and so are shuffled to give all a chance to be shown. What we can do is do the shuffle only once for each VS Code session. Sound ok?
yes, for each session sounds good. i can imagine that if we have not yet done the more costly recommendations then the 2nd or 3rd time i invoke that more are to the list.
I didnt follow that. Are you saying that we should keep adding to the list every time is invoked? Why?
Change:
set tabSize(value: number | string) { that._setTabSize(value); }, <del> get indentSize(): number | 'tabSize' { </del> <ins> get indentSize(): number | string { </ins> return that._indentSize; }, <del> set indentSize(value: number | 'tabSize') { </del> <ins> set indentSize(value: number | string) { </ins> that._setIndentSize(value); }, get insertSpaces(): boolean | string {

Discussion:
This API adds as a property to
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
To verify, you would need to write an extension which gets or sets the option on the current active editor. Here is the description: (it has an effect only when and defines the number of spaces that make up an indent)
Setting this is not working for me. I run this code in a command and nothing changes. But it works as a getter <img width="84" alt="image" src=""
This works for me: I the following code to the TS built-in extension: I opened a .js file which was configured with insert spaces: true (it said Spaces: 4) after 2 seconds it changes to: <img width="189" alt="image" src=""Note that indentSize can't be set if insertSpaces:false, it only makes sense when insertSpaces:true
aside from turning , to get this working in a file that already uses tabs, I had to run in the file first
Change:
if (this.options.small) { if (installCount > 1000000) { <del> installLabel = `${Math.floor(installCount / 1000000)}M`; </del> <ins> installLabel = `${Math.floor(installCount / 100000) / 10}M`; </ins> } else if (installCount > 1000) { installLabel = `${Math.floor(installCount / 1000)}K`; }

Discussion:
VSCode Version: 1.8.1 OS Version: Windows 8 UX Improvement for example: 1.5M or 1.560M !
if this feature , developer easy compare between extensions
Care to submit a PR?
just for UX improvement now display 1M for 1.1 and 1.9
Change:
}); } <ins> // Parses output of `git check-ignore -v -z` and returns only those paths // that are actually ignored by git. // Matches to a negative pattern (starting with '!') are filtered out. // See also https://git-scm.com/docs/git-check-ignore#_output. private parseIgnoreCheck(raw: string): string[] { const ignored = []; const elements = raw.split('0'); for (let i = 0; i < elements.length; i += 4) { const pattern = elements[i + 2]; const path = elements[i + 3]; if (pattern && !pattern.startsWith('!')) { ignored.push(path); } } return ignored; } </ins> private async run<T>(operation: Operation, runOperation: () => Promise<T> = () => Promise.resolve<any>(null)): Promise<T> { if (this.state !== RepositoryState.Idle) { throw new Error('Repository not initialized');

Discussion:
<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version 1.31.1 OS Version: Majove 10.14.3 Steps to Reproduce: the following files: /test/.gitkeep the following rules to .gitignore In the explorer file is grayed out even though git recognises it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
Just wanted to report this issue. The changes in the file will be reported in the git tab but it will be greyed out as well. On the explorer tab, there would be a letter indicating the change but still greyed out.
This issue is related: . According to it is caused by a bug in .
fixed via
Change:
'!extensions/markdown-language-features/media/*.js', '!extensions/markdown-language-features/notebook-out/*.js', '!extensions/markdown-math/notebook-out/*.js', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/notebook-renderers/renderer-out/*.js', '!extensions/simple-browser/media/*.js', ];

Discussion:
Running on main:
Am I missing something on how to run this? An ignore rule is in :
Change:
*--------------------------------------------------------------------------------------------*/ import { compareBy, findMaxBy, numberComparator } from 'vs/base/common/arrays'; <del> import { RunOnceScheduler } from 'vs/base/common/async'; </del> import { Emitter, Event } from 'vs/base/common/event'; import { Disposable } from 'vs/base/common/lifecycle'; import { IActiveCodeEditor } from 'vs/editor/browser/editorBrowser';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Windows Steps to Reproduce: Have these internal settings enabled: "editor.inlineSuggest.allowQuickSuggestions": true, "editor.inlineSuggest.allowSuggestOnTriggerCharacters": true The Intellisense interaction with grey text is awesome! But I noticed some flickering. Here is the GIF. ! I grabbed screenshots to make the flickering clear: WLC prediction is in Italics ! When Intellisense is up, Intellisense text is in Italics and wlc prediction is not. ! When .is typed, there is a small latency where wlc prediction disappears. This is because . is a trigger character for Intellisense so first it will process Intellisense and then request the wlc inlineCompletionProvider. ! After that small latency, the wlc prediction shows up again in Italics ! So, the 2 main problems here are 1) When Intellisense pops up while walking the prediction, the prediction goes from Italics to non-Italics. It goes back to Italics when Intellisense is dismissed (either by manual dismissal or item committed). In VS, we keep the font for grey text the same regardless of whether Intellisense is up or not, that would be helpful in VS Code. 2) The small delay that happens when a trigger character is hit and the wlc prediction disappears and comes back again. cc
This is normal, I use Copilot and experience the same thing.

I believe this is not a bug but a slight delay in rendering.
I cannot reproduce: ! Please log all calls from VS Code into your implementation of the inline completions provider and send me that log.
Here are the logs, lmk if you need anything else.
I was able to repro the bug in code-oss. ghostText is indeed when the flickering happens. I captured a GIF of the logs so you can see at what point ghostText becomes undefined. ! Here are the logs
I was also able to repro this bug in the sample extension. I used the extension from here - !
Verified that inline completions do not flicker anymore.
Change:
.monaco-select-box { width: 100%; cursor: pointer; <ins> border-radius: 2px; </ins> } .monaco-select-box-dropdown-container {

Discussion:
Looking at ways to make VS Code feel ever so slightly more approachable. A subtle 2px border radius on our common input components could be one way to make the UI feel more inviting and less harsh: <img width="361" alt="CleanShot 2022-04-08 at 14 48 52 src="https://user-"<img width="522" alt="CleanShot 2022-04-08 at 14 55 52 src="https://user-"<img width="494" alt="CleanShot 2022-04-08 at 14 58 01 src="https://user-"<img width="437" alt="CleanShot 2022-04-08 at 14 49 46 src="https://user-"<img width="500" alt="CleanShot 2022-04-08 at 15 01 55 src="https://user-"! FWIW, we already use a border radius on our icon buttons: <img width="300" alt="CleanShot 2022-04-08 at 15 03 36 src="https://user-"cc
I like this idea for buttons. I am not so sure about input/combo boxes.
I'm a +1 on this one, I think the inputs might need a bit of spacing from the side to feel more natural. We should also make sure that our labels are distinguishable as they start looking similar. Maybe we update the labels to be more pill-like?
As in padding L/R? I think they are indeed a bit different from our dropdowns if memory serves. Good call on the labels/tags.
Border-radius on buttons was merged but inputs is still under discussion so I'll keep this one open.
Good job
Change:
} // Menubar: the menubar part which is responsible for populating both the custom and native menubars <del> this.menubarPart = this.instantiationService.createInstance(MenubarPart, 'workbench.parts.menubar'); </del> <ins> this.menubarPart = this.instantiationService.createInstance(MenubarControl, 'workbench.parts.titlebar.menubar'); </ins> this.menubar = $(this.titleContainer).div({ <del> 'class': ['part', 'menubar'], id: 'workbench.parts.menubar', </del> <ins> 'class': ['menubar'], id: 'workbench.parts.titlebar.menubar', </ins> role: 'menubar' });

Discussion:
I like how menu and title part are now merged, but I feel it could merge even more to reflect the structure in the DOM: move all of into (rename to and merge the CSS into the existing one) rename to something like do not extend from in , since this is no longer a workbench managed part