jiebi/CodeConvo huggingface dataset:
Change:
leftButton: false, middleButton: false, <ins> onInjectedText: target.type === MouseTargetType.CONTENT_TEXT && target.detail.injectedText !== null </ins> }); } }

Discussion:
have an inlay hint with command double click the hint to run the command the current word is selected too
I believe this needs some changes in the editor. Preventing default on the mouse event doesn't seem to fix it.
What should happen when the user clicks on an inlay hint for a single time?
Nothing, unless it's a cmd/ctrl-click on an active label part link
Change:
return; } <del> for (const newCell of e.added) { this._visibleCells.set(newCell.handle, this._itemFactory(vm, newCell)); } </del> for (const oldCell of e.removed) { this._visibleCells.get(oldCell.handle)?.dispose(); this._visibleCells.delete(oldCell.handle); } <ins> for (const newCell of e.added) { this._visibleCells.set(newCell.handle, this._itemFactory(vm, newCell)); } </ins> } override dispose(): void {

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) When a cell successfully executes, I get a little green check mark to indicate success. Sometimes these marks keep getting instead of just re-using the first one. So I end up with 15+ checks across the bottom of my cell. This looks weird. ! Version: 1.70.1 (user setup) Commit: Date: 2022-08-10T06:08:33.642Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: WindowsNT x64 10.0. 2022.7.110 (12 Aug 2022) No response No response No response_ Local
Thanks for filing this. Have not seen something like this before. I'll look at reproing it. Anything in particular that triggers this behavior? Or just something that shows up to you relatively often?
I've just started noticing it recently. I have not recognized a pattern yet. But I do frequently have exceptions, so maybe having something around it fail and then succeed gets it in a weird state? I'll try to pay more attention to when it starts happening.
I also restart my kernel a lot, which may have something to do with it too.
Hm, we had these issues in the past, but I thought all the bugs were squashed Edited - actually, I was just able to repro this by scrolling around while executing a cell. Not a recent regression
Change:
this.cell.editorHeight = contentHeight; } <ins> private _editorLayoutInProgress = false; </ins> layout(state: IDiffElementLayoutState) { DOM.scheduleAtNextAnimationFrame(() => { <ins> this._editorLayoutInProgress = true; </ins> if (state.editorHeight) { this._editorContainer.style.height = `${this.cell.layoutInfo.editorHeight}px`; this._editor!.layout({

Discussion:
a change to the file and save, do not commit the diff view from the SCM view up and down in the notebook diff view :cheese: see cell metadata area skittering on screen (the recording below does not capture how frequently the skittering actually happens) https://user-
Just ran into this again: https://user-
I opened for that, I think we can actually just reopen this one
This issue should be gone now since we fixed the horizontal bar issue.
Change:
private scrollbar!: DomScrollableElement; private debugHoverComputer: DebugHoverComputer; <ins> private expressionToRender: IExpression | undefined; private isUpdatingTree = false; </ins> constructor( private editor: ICodeEditor, @IDebugService private readonly debugService: IDebugService,

Discussion:
an object that has many long property values There is no scrollbar the prototype There is a scrollbar !
Probably only with the horizontalscrolling setting enabled? I know that's a bit tricky
What's the setting for that? I don't have any scroll setting that appears debug related enabled. Just sticky scroll for the editor.
I think you have set, right?
No I do not.
Change:
); // border: active and inactive. defaults to active background export const COMMAND_CENTER_BORDER = registerColor( <del> 'commandCenter.border', { dark: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcDark: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .60), light: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcLight: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .60) }, </del> <ins> 'commandCenter.border', { dark: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcDark: contrastBorder, light: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcLight: contrastBorder }, </ins> localize('commandCenter-border', "Border color of the command center"), false );

Discussion:
Steps: enable one of the HC themes <img width="787" alt="image" src=""I would have expected the turquoise color as border around the command center. I think that one is . //cc
Change:
const editorInput = InteractiveEditorInput.create(accessor.get(IInstantiationService), notebookUri, inputUri); historyService.clearHistory(notebookUri); <del> await editorService.openEditor(editorInput, editorOptions, group); </del> <ins> await editorService.openEditor(editorInput, { ...editorOptions, pinned: true }, group); </ins> // Extensions must retain references to these URIs to manipulate the interactive editor return { notebookUri, inputUri }; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Code-OSS OS Version: Windows 10 Steps to Reproduce: IW from codelens IW is initially not pinned, and becomes pinned after the NotebookDocument is modified (e.g. sys info markdown cell is inserted)
Change:
break; case 'Manage': this.workspaceTrustRequestService.cancelRequest(); <del> await this.commandService.executeCommand('workbench.trust.manage'); </del> <ins> await this.commandService.executeCommand(MANAGE_TRUST_COMMAND_ID); </ins> break; case 'Cancel': this.workspaceTrustRequestService.cancelRequest();

Discussion:
The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.
FYI
Change:
const currPosition = trigger.selection.getPosition(); let trackedPosition = currPosition; let distance = Number.MAX_VALUE; <del> let toBeModified = false; </del> <ins> const currentActions = [...codeActionSet.validActions]; </ins> for (const marker of allMarkers) { const col = marker.endColumn;

Discussion:
Testing I was expecting quick fixes for the whole line to be included, ranked by distance to the cursor, up to a certain maximum !
Yep! That was one thing I was experimenting with, and atm it does just find the closest one. Played around with allowing all quickfixes as well, but was unsure what would feel better. Will likely work on a version where we show all potential quickfixes in the line.
Change:
return langId && dbg.interestedInLanguage(langId); }); <del> if (message && debuggerHasUnverifiedBps?.length) { </del> <ins> if (message && debuggerHasUnverifiedBps?.length && this.debugService.getModel().areBreakpointsActivated()) { </ins> if (delayed) { const mdown = new MarkdownString(undefined, { isTrusted: true }).appendMarkdown(message); this.hintContainer.setLabel('$(warning)', undefined, { title: { markdown: mdown, markdownNotSupportedFallback: message } });

Discussion:
Debug some js code Set a breakpoint Click the toggle button to deactivate all breakpoints The unbound breakpoint warning indicator shows up
<img width="639" alt="image" src="https://user-"
Change:
item = child; break; } <del> item = undefined; </del> <ins> item = null; </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --Related Issues: <!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Linux x64 5.8.0-44-generic Steps to Reproduce: a root folder (files-exclude-sample) that folder create two nested folders (child1, child2) root folder (files-exclude-sample), create a workspace definition file (files-exclude-) root folder (files-exclude-sample), create a .vscode folder .vscode folder create a file to previous steps, just clone this GitHub repo: VSCode, open the workspace (files-exclude-) looks ok. You have tree root folders (files-exclude-sample, child1 and child2) ! you expand all three folder you can see something like ! specified in root folder , child1 and child2 are excluded from child1 folder child1 folder is collapsed (not removed from explorer tree) and it appears inside root folder (files-exclude-sample) folder ! expected behavior is that child1 is not collapsed and it does not appear inside root folder <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
the owner of the file explorer is
I acknowledge this issue. MR workspace support with when one root folder is a subfolder of another root folder has some issues. If somebody is passionate about fixing this let me know and I can provide pointers
Created fixing this
Thanks to a great pr by this is now fixed
Change:
dependencies: object-keys "~0.4.0" <del> xterm-addon-search@0.9.0-beta.37: version "0.9.0-beta.37" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.37.tgz#84a020f03b2cacc5afac78ca6ff2f1eb86fb6710" integrity sha512-bfeFgKJkDYyIgqpWiV1oWYqDiTo+SHTeIPEbpOfxDr97pc3PtDF1Tyd79PrvJNfoxaV3VMUo//UEOy4D+KY9OQ== </del> <ins> xterm-addon-search@0.9.0-beta.39: version "0.9.0-beta.39" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.39.tgz#e8376e1485ee7d763c07d1a8f1354114f65b3e3e" integrity sha512-h45wkecgfqXXoAUqgNytAfSd6g0xNT6rZy/enVaEU0aes7QoL9pxHUKkCry8PP6hs03Slk0VxQ4AGsbSZGvK/w== </ins> xterm-addon-serialize@0.7.0-beta.12: version "0.7.0-beta.12"

Discussion:
Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification
Change:
this.element = document.createElement('div'); <del> this.element.style.width = `calc(100% - ${CODE_CELL_LEFT_MARGIN + CELL_MARGIN + CELL_RUN_GUTTER}px)`; </del> <ins> this.element.style.width = `calc(100% - ${CODE_CELL_LEFT_MARGIN + (CELL_MARGIN * 2) + CELL_RUN_GUTTER}px)`; </ins> this.element.style.height = '1400px'; this.element.style.position = 'absolute'; this.element.style.margin = `0px 0 0px ${CODE_CELL_LEFT_MARGIN + CELL_RUN_GUTTER}px`;

Discussion:
todays insiders run on the right hand side <img width="446" alt="Screenshot 2020-07-03 at 10 28 15" src="https://user-"
Forgot to update the output width when I increased the right side margin. Will create a release candidate PR and will assign this to the recovery milestone when it gets created.
Change:
template.name.textContent = extension.displayName; template.name.classList.toggle('clickable', !!extension.url); <ins> template.name.classList.toggle('deprecated', !!extension.deprecationInfo); </ins> template.preview.style.display = extension.preview ? 'inherit' : 'none'; template.builtin.style.display = extension.isBuiltin ? 'inherit' : 'none';

Discussion:
Testing When I run a search for "deprecated" I see a large list of extensions that are being deprecated. I also see that each extension uses it's own ways to indicate that the extension is deprecated: prefix prefix sufix sufix Given that we control the list of deprecated extensions, and we have several established UI elements I am wondering if we could create a more unified and consistent look for all the deprecated extensions: In the extensions list, add a visual indicator in the upper left hand corner of the icon (similar to pre-release) In the extension details page, have a "deprecated" pill/badge after the name (similar to the pre-release and preview)
Another idea would be strike out the title just like we strike out in code editor.
any suggestions?
I like the strike-through on the title idea, it's simple (even though we already use the warning icon): <img width="1138" alt="CleanShot 2022-05-31 at 12 40 26 src="https://user-"
<img width="1378" alt="image" src="https://user-"
FYI
looks nice :)
Change:
return Promise.all(this.values.map(async (value) => { return { label: value.extensionDescription.displayName || value.extensionDescription.identifier.value, <del> description: '', </del> <ins> description: await value.url, </ins> extensionDescription: value.extensionDescription }; }));

Discussion:
This is pretty nitpicky, but I notice that if I say "Provide Feedback" in the remote explorer, the first entry for codespaces takes me to a github community page. However, since the icon "Provide Feedback" was a twitter icon, I thought that all options would take me to twitter. Is there a more generic icon that we can use? <img width="216" alt="image" src="https://user-"
Good catch, cc as I think we previously discussed not wanting to send users to twitter for feedback anymore. What is the preferred feedback mechanism now? (Relatedly, should we consolidate Provide Feedback and Report Issue?)
If this is for Codespaces, I believe the GH Discussions is still the preferred spot: I also think it makes sense to combine Provide Feedback & Report Issue into one node!
Yeah for all our other remote extensions the Provide Feedback node still goes to twitter, I propose that we deprecate that in favor of Report Issue (for codespaces, their feedback and report issue items both go to the same GH discussions). Any concerns
Sounds good to me!
Tasks: [x] Remove from remote help [x] Remove entries for [x] Codespaces [x] Remote Repos [ ] ~Remote Tunnels~ [ ] ~Remote SSH~ [x] WSL [x] Dev Containers
Slight edit--Codespaces' Provide Feedback and Issues links go to the GH discussions tracker, but Codespaces' Report Issue command opens the builtin issue reporter prefilled to the GitHub Codespaces extension. Clicking the button in the issue reporter then inexplicably opens the Windows file explorer. <img width="387" alt="image" src="https://user-"I believe Codespaces actually wants issues to be reported in GH discussions instead of the VS Code issue tracker, so what I'd suggest is: we introduce a new optional property which Codespaces would point to their GH discussions tracker all other remotes would not provide this property we would not show the Provide Feedback item anymore since Report Issue will do the same thing cc for feedback on the proposed change to the Codespaces extension
those changes sound good to me
Change:
level = Math.round(level); // when reaching smallest zoom, prevent fractional zoom levels <del> if (level > BaseZoomAction.MAX_ZOOM_LEVEL || level < BaseZoomAction.MIN_ZOOM_LEVEL) { </del> <ins> if (level > MAX_ZOOM_LEVEL || level < MIN_ZOOM_LEVEL) { </ins> return; // https://github.com/microsoft/vscode/issues/48357 }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version Version: 1.68.0 (user setup) Commit: Date: 2022-06-08T11:44:16.822Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: is not in F11 fullscreen mode. the Settings GUI, set window.zoomLevel to a negative value (e.g. -3) add an extra 0 (e.g. -30) setting is automatically applied, which leads to a state where the entire UI disappears. Clicking anywhere in the window minimizes the window. F11 fullscreen mode appears to fix this situation and the UI becomes visible again(albeit very tiny at the -30 zoom level). My initial take is this could be fixed with a sane lower bounds on window.zoomLevel. However, it appears that part of the issue is also that as window.zoomLevel becomes more negative(zooms out), the Menu Bar becomes larger. At high magnitude negative values, the Menu Bar increases in size to the point where it takes up the entire window and prevents user input. Ex.) window.zoomLevel: -20 . ! Ex.) window.zoomLevel: -30. At this level, the Menu Bar minimize "-" icon takes up the whole window.

At this level, the setting input box also de-focuses, preventing the user from pressing backspace to remove the extra 0. !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
constructor() { super( { <del> id: 'inlineChat.discard', </del> <ins> id: 'OFF.inlineChat.discard', </ins> title: localize('discard', 'Discard'), icon: Codicon.discard, menu: {

Discussion:
open editor inline chat press ESC nothing happens This is because unconditionally steals/overrides all commands from inline chat and likely others
Change:
IFS=':' read -rA ADDR <<< "$VSCODE_ENV_PREPEND" for ITEM in "${ADDR[@]}"; do VARNAME="$(echo ${ITEM%%=*})" <del> export $VARNAME="$(echo -e {ITEM#*=})${(P)VARNAME}" </del> <ins> export $VARNAME="$(echo -e ${ITEM#*=})${(P)VARNAME}" </ins> done unset VSCODE_ENV_PREPEND fi

Discussion:
Testing seems to fail on zsh shell: !
Moving this to August same as the other issue:
Let me know if we're unable to fix this in time, in which case I'll stop prepending for zsh in Python extension.
Looking into it now
Change:
* @example * // Log all data written to the terminal for a command * const command = term.shellIntegration.executeCommand({ commandLine: 'echo "Hello world"' }); <del> * const stream = command.createDataStream(); </del> <ins> * const stream = command.readData(); </ins> * for await (const data of stream) { *   console.log(data); * } */ <del> createDataStream(): AsyncIterable<string>; </del> <ins> readData(): AsyncIterable<string>; </ins> } export interface Terminal {

Discussion:
Testing The should be a plain property and not a method
I was thinking about this guideline when I switched it to a method as it's creating a new object every call: Can switch it back, is it worth a discussion in the API sync?
I don't think it does create a new object but that's also not the point here. Your data is never sync with an async iterable but the point is the consumer should just have which is still an async iterable (and likely implemented as lazy getter)
I might be doing something wrong as I don't think I've used an async iterable before, but doesn't this need to return a separate iterable per call in order to support multiple extensions? Currently the is a multiplexer for multiple iterators:
Oh, I missed the invocation inside .
Maybe a better name for a method would be or .
Change:
.send() .await?; <del> if !response.status().is_success() { return Err(StatusError::from_res(response).await?.into()); </del> <ins> let status_code = response.status().as_u16(); let body = response.bytes().await?; if let Ok(body) = serde_json::from_slice::<AuthenticationResponse>(&body) { return Ok(StoredCredential::from_response(body, provider)); </ins> } <del> let body = response.json::<AuthenticationResponse>().await?; Ok(StoredCredential::from_response(body, provider)) </del> <ins> if let Ok(res) = serde_json::from_slice::<AuthenticationError>(&body) { return Err(OAuthError { error: res.error, error_description: res.error_description, } .into()); } return Err(StatusError { body: String::from_utf8_lossy(&body).to_string(), status_code, url: provider.grant_uri().to_string(), } .into()); </ins> } /// Implements the device code flow, returning the credentials upon success.

Discussion:
Windows 11 Latest Insiders WSL with Ubuntu 20.04.5 LTS I am trying to get and run the insiders code cli on a WSL Ubuntu 20.04 instance. the linux x64 insiders cli from here: and save the file to someplace in your WSL Ubuntu 20.04 folder : the file is the same name as the stable x64 version, so i'm not sure if am really getting insiders. , note the time stamp in the future error disc i see a executable, why is there a code-insiders`? see 2 above the GitHub login dance Result - it hangs in the terminal, no URL is displayed, here's the output from (which repeats):
can you try again with today's Insiders build of the CLI? It should print more detailed information about the error, if any, that's happening.
works great today! i was able to log in, get the URL, and hit it from another machine. still, why is the executable and not ? I see I can use the option but that breaks my flow (always use from the terminal)
That's a to fix, tracked in I'll go ahead and close this issue for now. I have a feeling it was something on GH's end, but at least next time we see this, we should be able to get more info.