jiebi/CodeConvo huggingface dataset:
Change:
import 'vs/css!./codelensWidget'; import * as dom from 'vs/base/browser/dom'; import { coalesce, isFalsyOrEmpty } from 'vs/base/common/arrays'; <del> import { escape } from 'vs/base/common/strings'; </del> <ins> import { renderOcticons } from 'vs/base/browser/ui/octiconLabel/octiconLabel'; </ins> import * as editorBrowser from 'vs/editor/browser/editorBrowser'; import { Range } from 'vs/editor/common/core/range'; import { IModelDecorationsChangeAccessor, IModelDeltaDecoration, ITextModel } from 'vs/editor/common/model';

Discussion:
VSCode Version: Insiders Add ability to display Octicons in Code Lenses. My plan is to display the results (as done in VS) of unittests against each method. Part of the functionality has been provided through (refreshing code lenses). Now i'd like to display a red "X" or a green "Tick" (what ever the standard Octicons may be).
As a workaround, you may be able to use emoji or regular unicode symbols to achieve a similar effect: <img width="474" alt="screen shot 2017-01-30 at 11 12 59 am" src=""One downside to this is that these will vary somewhat between operating systems
Thanks for the tip
I would like to try fixing it. Would that be ok? Maybe you can think of some pitfalls?
Use the utils from and wire things up here: One thing to consider is that maybe not all users want octicons, e.g one might be using $(zap) and not want but we can consider that later
Change:
import * as nls from 'vs/nls'; import { ContextKeyExpr, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <del> import { KeybindingsRegistry } from 'vs/platform/keybinding/common/keybindingsRegistry'; </del> export class GhostTextController extends Disposable { public static readonly inlineSuggestionVisible = new RawContextKey<boolean>('inlineSuggestionVisible', false, nls.localize('inlineSuggestionVisible', "Whether an inline suggestion is visible")); public static readonly inlineSuggestionHasIndentation = new RawContextKey<boolean>('inlineSuggestionHasIndentation', false, nls.localize('inlineSuggestionHasIndentation', "Whether the inline suggestion starts with whitespace")); public static readonly inlineSuggestionHasIndentationLessThanTabSize = new RawContextKey<boolean>('inlineSuggestionHasIndentationLessThanTabSize', true, nls.localize('inlineSuggestionHasIndentationLessThanTabSize', "Whether the inline suggestion starts with whitespace that is less than what would be inserted by tab")); <del> /** * Enables to use Ctrl+Left to undo fully (partially) accepted inline completions (the completion is no longer visible then). */ public static readonly inlineSuggestionJustCommitted = new RawContextKey<boolean>('inlineSuggestionJustCommitted', false, nls.localize('inlineSuggestionJustCommitted', "Whether an inline suggestion just got committed")); </del> static ID = 'editor.contrib.ghostTextController';

Discussion:
(See attached recording) I have enclose it in new use cmd+left to go to start of line ghost suggestions get accepted https://user-
Change:
const lsDoc = toLSTextDocument(document); position = document.validatePosition(position); <del> if (document.languageId === 'html') { </del> <ins> if (syntax === 'html') { </ins> if (context.triggerKind === vscode.CompletionTriggerKind.TriggerForIncompleteCompletions) { switch (this.lastCompletionType) { case 'html':

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Ubuntu 20.04 Steps to Reproduce: /create a Handlebars file. tag. some Emmet CSS abbreviation and try to expand. . Emmet HTML abbreviations in Handlebars files work fine. See HTML vs Handlebars example: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.606 --<!-- potentialduplicatescomment --
I think I have found the issue. In , we check , we should be checking instead. I will raise a PR.
Change:
}); }); <del> test('splits glob pattern even with expandPatterns disabled', () => { </del> <ins> test('does not split glob pattern when expandPatterns disabled', () => { </ins> assertEqualQueries( queryBuilder.file([ROOT_1_URI], { includePattern: '**/foo, **/bar' }), {

Discussion:
Use this code in an extension, run the command In 1.31, it returns no results because takes a single glob pattern In 1.32, it returns results because the include and exclude patterns for are split on the comma
This is a candidate because it would be an API change. If we want to support multiple glob patterns we should use an array like we discussed in Parsing a comma-delimited string in this API feels wrong.

1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the ´Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for
Would be fixed by .
Change:
if (focus) { const selection: Array<IEditorIdentifier | IEditorGroup> = list.getSelectedElements().filter(onlyEditorGroupAndEditor); <del> // Only respect selection if it contains focused element if (selection?.some(s => { if (isEditorGroup(s)) { return s.id === focus.groupId; } const group = editorGroupService.getGroup(s.groupId); return s.groupId === focus.groupId && (group ? group.getIndexOfEditor(s.editor) : -1) === focus.editorIndex; })) { </del> <ins> if (selection.length > 0) { </ins> return selection.map(elementToContext); }

Discussion:
Type: <bBug</bI have several dozens of file opened in the Explorer / Open editors. I select one, Shift+click on another below, all the range is selected, OK. ! I hit Ctrl+F4, the selected files are closed, perfect. Now, I select a range in the same way, I unselect one (or several files) with Ctrl+click in the selection. The last unselected file has the focus, visible with the blue outline. ! If I hit Ctrl+F4, VSC closes only one file: the one with the focus. ! I expected to close all selected files instead. VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (28)</summaryExtensionVersion ------ vscode-openapi4.18.5 tsl-problem-matcher0.6.2 ng-template16.0.0 vscode-toggle-quotes0.3.6 npm-intellisense1.4.4 path-intellisense2.8.4 package-json-upgrade2.0.0 vscode-eslint2.4.2 css-flexbox-cheatsheet3.3.3 gitlens14.0.1 EditorConfig0.16.4 vscode-jest-runner0.4.60 rest-client0.25.1 batch-rename-extension0.0.6 svg1.5.3 docthis0.7.1 import-sorter3.3.1 vscode-scss0.10.0 console-master1.0.0 git-file-history1.0.1 vscode-commons0.0.6 vscode-yaml1.13.0 vscode-stylelint1.2.4 luna-paint0.16.0 vscode-vlang0.1.14 quokka-vscode1.0.547 change-case1.0.0 markdown-all-in-one3.5.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
if (this.environmentService.editSessionId !== undefined) { await this.resumeEditSession(this.environmentService.editSessionId).finally(() => this.environmentService.editSessionId = undefined); <del> } else if (this.configurationService.getValue('workbench.experimental.editSessions.autoResume') === 'onReload' && this.editSessionsStorageService.isSignedIn) { </del> <ins> } else if ( this.configurationService.getValue('workbench.experimental.editSessions.enabled') === true && this.configurationService.getValue('workbench.experimental.editSessions.autoResume') === 'onReload' && this.editSessionsStorageService.isSignedIn ) { </ins> // Attempt to resume edit session based on edit workspace identifier // Note: at this point if the user is not signed into edit sessions, // we don't want them to be prompted to sign in and should just return early

Discussion:
Trying to test a repo on vscode-dev (for me, ) some changes in the "Continue Edit Session" and "Reopen in Desktop" repository on desktop VS Code opens, but edit session changes are not applied
Update: I see it's actually in the Edit Sessions view, just not continued automatically by the protocol activation. I can manually resume the edit session once desktop opens and the changes appear.
Ah, do you have configured in settings?
I do not
That will be why--the auto resume behavior requires that setting to be configured in the destination workspace for now, otherwise it would still be a manual step.
Tried this and doesn't work for me, do I need a new version of some extension?
you need to have the pre-releases of and installed in the latest VS Code Insiders. If it doesn't work for you, could you please share the contents of the "Log (Edit Sessions)" output channel?
Yes, on pre-release of both of those extensions (in web and desktop). There's nothing in the output, However there are errors in the console window <details<summaryLogs</summary</details
Hm, those errors are all spurious. Do you have the following version of VS Code: Version: 1.71.0-insider (system setup) Commit: Date: 2022-08-25T13:00:37.808Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes Or equivalently do you have the following settings
Yes Yes, <img width="353" alt="Screen Shot 2022-08-26 at 13 58 47" src="https://user-"
Oh--have you run the command on desktop VS Code before? If not, could you try doing that and then checking to see if the following flow works for you? https://user- We probably need some settings sync-ed memento state to communicate that we should ask for auth here.
Change:
"vscode-oniguruma": "1.7.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.46", "xterm-addon-canvas": "0.5.0-beta.9", "xterm-addon-image": "0.6.0-beta.2", "xterm-addon-search": "0.13.0-beta.8", "xterm-addon-serialize": "0.11.0-beta.8", "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.16.0-beta.16", "xterm-headless": "5.3.0-beta.46", </del> <ins> "xterm": "5.3.0-beta.58", "xterm-addon-canvas": "0.5.0-beta.19", "xterm-addon-image": "0.6.0-beta.11", "xterm-addon-search": "0.13.0-beta.17", "xterm-addon-serialize": "0.11.0-beta.17", "xterm-addon-unicode11": "0.6.0-beta.9", "xterm-addon-webgl": "0.16.0-beta.27", "xterm-headless": "5.3.0-beta.58", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" }

Discussion:
<img width="1116" alt="Screenshot 2023-08-04 at 2 35 57 pm" src=""I've been seeing this fairly consistently, when doing the set upstream quick fix it will lock the scrolling, scrolling down manually will do the audio cue for the next quick fix.
diff from 5.2.1:
Possible cause:
I'm guessing this is the issue: , we never want to animate this case.
Is ctrl+. still supposed to trigger the quick fix widget? It doesn't currently for me
yes ctrl/cmd+.
Never mind, I apparently customized it some time ago (likely for another TPI), all good
Change:
], "filenames": [ "composer.lock", <del> ".watchmanconfig", ".ember-cli" </del> <ins> ".watchmanconfig" </ins> ], "mimetypes": [ "application/json",

Discussion:
Issue Type: <bBug</bThe file has an incorrect language association by default ( instead of ). The has comments, so there are red squiggly lines when you open this file until you change the language to . VS Code version: Code 1.51.1 (, 2020-11-10T23:34:32.027Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.19.128-microsoft-standard Remote OS version: Linux x64 4.19.128-microsoft-standard Remote OS version: Linux x64 4.19.128-microsoft-standard <details<summarySystem Info</summary </details<details<summaryExtensions (2)</summaryExtensionVersion ------ remote-wsl0.51.3 vscode-eslint2.1.13 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.714 --- <!-- score: 0.534 --- <!-- score: 0.492 --<!-- potentialduplicatescomment --
Change:
title: { value: localize('updateAll', "Update All Extensions"), original: 'Update All Extensions' }, category: ExtensionsLocalizedLabel, precondition: HasOutdatedExtensionsContext, <del> menu: [{ id: MenuId.CommandPalette, when: ContextKeyExpr.and(CONTEXT_HAS_GALLERY, ContextKeyExpr.or(CONTEXT_HAS_LOCAL_SERVER, CONTEXT_HAS_REMOTE_SERVER, CONTEXT_HAS_WEB_SERVER)) }, { id: MenuId.ViewContainerTitle, when: ContextKeyExpr.and(ContextKeyExpr.equals('viewContainer', VIEWLET_ID), ContextKeyExpr.or(ContextKeyExpr.has(`config.${AutoUpdateConfigurationKey}`).negate(), ContextKeyExpr.equals(`config.${AutoUpdateConfigurationKey}`, 'onlyEnabledExtensions'))), group: '1_updates', order: 2 }], </del> <ins> menu: [ { id: MenuId.CommandPalette, when: ContextKeyExpr.and(CONTEXT_HAS_GALLERY, ContextKeyExpr.or(CONTEXT_HAS_LOCAL_SERVER, CONTEXT_HAS_REMOTE_SERVER, CONTEXT_HAS_WEB_SERVER)) }, { id: MenuId.ViewContainerTitle, when: ContextKeyExpr.and(ContextKeyExpr.equals('viewContainer', VIEWLET_ID), ContextKeyExpr.or(ContextKeyExpr.has(`config.${AutoUpdateConfigurationKey}`).negate(), ContextKeyExpr.equals(`config.${AutoUpdateConfigurationKey}`, 'onlyEnabledExtensions'))), group: '1_updates', order: 2 }, { id: MenuId.ViewTitle, when: ContextKeyExpr.equals('view', OUTDATED_EXTENSIONS_VIEW_ID), group: 'navigation', order: 1 } ], icon: installWorkspaceRecommendedIcon, </ins> run: () => { return Promise.all(this.extensionsWorkbenchService.outdated.map(async extension => { try {

Discussion:
Testing Maybe a button to the right of the view header: !
Lets have action in the view header like below <img width="341" alt="image" src="https://user-"
Change:
/* Icons */ .monaco-workbench > .notifications-center .codicon.codicon-error { <del> color: var(--vscode-notificationsErrorIcon-foreground); </del> <ins> color: var(--vscode-notificationsErrorIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-center .codicon.codicon-warning { <del> color: var(--vscode-notificationsWarningIcon-foreground); </del> <ins> color: var(--vscode-notificationsWarningIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-center .codicon.codicon-info { <del> color: var(--vscode-notificationsInfoIcon-foreground); </del> <ins> color: var(--vscode-notificationsInfoIcon-foreground) !important; </ins> }

Discussion:
an error notification it Error icon goes grey. https://user-
Could this be fallback from list color changes? cc
Similar to
Change:
height: realContentHeight } ); <ins> this.viewCell.outputs.forEach((o, i) => { const renderedOutput = this.outputElements.get(o); if (renderedOutput && !renderedOutput.renderResult.hasDynamicHeight && !renderedOutput.renderResult.shadowContent) { this.viewCell.updateOutputHeight(i, renderedOutput.element.clientHeight); } }); </ins> } private onCellHeightChange(newHeight: number): void {

Discussion:
Notice the cell goes beyond the right margin. Seems to happen for all cells
is it related to the indentation change?
I don't think there's an issue here anymore? I did push a change to ensure that a line of text with no whitespace will break and not overflow. But I don't see any other issues with overflowing horizontally. I do see plain text outputs overflowing if I resize the editor to be narrower...
Change:
when: ScopedChatSynthesisInProgress, group: 'navigation', order: -1 <del> }, { id: MENU_INLINE_CHAT_WIDGET_SECONDARY, when: ScopedChatSynthesisInProgress, group: 'navigation', order: -1 </del> } ] });

Discussion:
I see the speaker icon has moved to the bottom right which is . But when I read out aloud, I now see a progress icon appearing: ! Here is how it looked like in stable: ! Essentially there used to be a stop icon that was not spinning. That stop icon was the mic icon with a little "x".
Change:
} get breakpoints(): vscode.Breakpoint[] { <del> this.startBreakpoints(); </del> const result: vscode.Breakpoint[] = []; this._breakpoints.forEach(bp => result.push(bp)); return result; } public addBreakpoints(breakpoints0: vscode.Breakpoint[]): Promise<void> { <del> this.startBreakpoints(); </del> // filter only new breakpoints const breakpoints = breakpoints0.filter(bp => { const id = bp.id;

Discussion:
Set some breakpoints Access from an extension- it's an empty array Try again - it's full Seems that we don't sync breakpoint into to the EH until the first call to one of the breakpoint properties do you have some context on this? It's a little confusing because I wouldn't expect sending breakpoint infos to be expensive, and I would expect to be able to access the breakpoints array immediately.
I do not have more context. I believe is the author of this code. I like your suggestion that we change this and actively sync the breakpoints into the EH (since it should not be expensive).
The observed behavior is by design: we want to avoid that all breakpoints get transferred to all active extensions all the time. But the API doc doesn't explain this...
Thanks is the worry that it's too much data/too expensive? What's the solution for extensions that need to access the list of breakpoints?
yes, potentially too much data and traffic for all extensions. What's the solution for extensions that need to access the list of breakpoints? adding a to the function of an extension will register the extension to receive live updates for . With this will always reflect the current set of breakpoints.
Thanks, I don't really understand that though, it doesn't seem like that much traffic/data, compared to something like the full text of open documents. If it's going to work this way, I should document it in But I might try doing some testing to remove this restriction because I think it's unexpected.
Verification steps: Create an extension that can log the value of Set a breakpoint in any file Then trigger your extension to check the length of the breakpoints array It should log the correct value on the first try- previously it would have been 0 on the first access, then the correct value afterwards
Change:
return; } <ins> if (this._isHoverSticky && this._contentWidget?.isVisibleFromKeyboard()) { // Sticky mode is on and the hover has been shown via keyboard // so moving the mouse has no effect return; } </ins> if (!this._isHoverEnabled) { this._hideWidgets(); return;

Discussion:
This is a regression of <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.1 arm64 OS Version: macOS 13.0.1 Steps to Reproduce: Set this settings Trigger the hover via keyboard cmd + k, cmd + I The hover disappears on minimal movement. I'm expecting to disable the hover via mouse and use only with keyboard. refs
Change:
@IViewsService private readonly viewsService: IViewsService, @IDialogService private readonly dialogService: IDialogService, @IStorageService private readonly storageService: IStorageService, <del> @ICommandService private readonly commandService: ICommandService </del> <ins> @ICommandService private readonly commandService: ICommandService, @IProgressService private readonly progressService: IProgressService, </ins> ) { } cancel(): void { <del> this.canceled = true; </del> <ins> this.globalCancellation.dispose(true); this.globalCancellation = new CancellationTokenSource(); </ins> } <del> async runTaskAndCheckErrors(root: IWorkspaceFolder | IWorkspace | undefined, taskId: string | ITaskIdentifier | undefined): Promise<TaskRunResult> { </del> <ins> public dispose(): void { this.globalCancellation.dispose(true); } async runTaskAndCheckErrors( root: IWorkspaceFolder | IWorkspace | undefined, taskId: string | ITaskIdentifier | undefined, ): Promise<TaskRunResult> { </ins> try { <del> this.canceled = false; const taskSummary = await this.runTask(root, taskId); if (this.canceled || (taskSummary && taskSummary.exitCode === undefined)) { </del> <ins> const taskSummary = await this.runTask(root, taskId, this.globalCancellation.token); if (taskSummary && (taskSummary.exitCode === undefined || taskSummary.cancelled)) { </ins> // User canceled, either debugging, or the prelaunch task return TaskRunResult.Failure; }

Discussion:
Clone and npm install. Hit F5, it never starts: <img width="484" alt="image" src=""I am on macOS.
This is probably because a prelaunch task is still running / your problem matchers haven't matched anything. Please make sure you have the right problem matchers installed, otherwise I suggest opening issues for them if they don't match correctly.
Would be great if debug could give me a hint.
Will keep open to track it, it's not a rare problem
We should also keep the terminal open if the task fails, currently it closes immediately which can be confusing
Would also be nice if we could cancel the pending launch attempt, e.g. by showing the debug toolbar immediately and disabling all buttons except the stop button. Right now when I get into this state I end up just reloading the whole window and incurring the pain of all extensions reactivating, which takes several seconds on my machine (git, TS etc)
After 10 seconds we'll show !
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased