jiebi/CodeConvo huggingface dataset:
Change:
{ link: 'foo:339', prefix: undefined, suffix: ':339', hasRow: true, hasCol: false }, { link: 'foo:339:12', prefix: undefined, suffix: ':339:12', hasRow: true, hasCol: true }, { link: 'foo:339:12-789', prefix: undefined, suffix: ':339:12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, <del> { link: 'foo:339.12-341.789', prefix: undefined, suffix: ':339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </del> { link: 'foo:339.12', prefix: undefined, suffix: ':339.12', hasRow: true, hasCol: true }, { link: 'foo:339.12-789', prefix: undefined, suffix: ':339.12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo:339.12-341.789', prefix: undefined, suffix: ':339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, <ins> { link: 'foo#339', prefix: undefined, suffix: '#339', hasRow: true, hasCol: false }, { link: 'foo#339:12', prefix: undefined, suffix: '#339:12', hasRow: true, hasCol: true }, { link: 'foo#339:12-789', prefix: undefined, suffix: '#339:12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo#339.12', prefix: undefined, suffix: '#339.12', hasRow: true, hasCol: true }, { link: 'foo#339.12-789', prefix: undefined, suffix: '#339.12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo#339.12-341.789', prefix: undefined, suffix: '#339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> { link: 'foo 339', prefix: undefined, suffix: ' 339', hasRow: true, hasCol: false }, { link: 'foo 339:12', prefix: undefined, suffix: ' 339:12', hasRow: true, hasCol: true }, { link: 'foo 339:12-789', prefix: undefined, suffix: ' 339:12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, <del> { link: 'foo 339:12-341.789', prefix: undefined, suffix: ' 339:12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </del> { link: 'foo 339.12', prefix: undefined, suffix: ' 339.12', hasRow: true, hasCol: true }, { link: 'foo 339.12-789', prefix: undefined, suffix: ' 339.12-789', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo 339.12-341.789', prefix: undefined, suffix: ' 339.12-341.789', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true },

Discussion:
In terminal, ctrl+click at , will open the file without problems, but using an anchor , gives the following error: !
This is actually a request for to indicate line number which we haven't had requested before. Right now it's considered to be part of the file name.
Change:
import { Disposable } from 'vs/base/common/lifecycle'; import { AriaRole } from 'vs/base/browser/ui/aria/aria'; import { NotificationActionRunner } from 'vs/workbench/browser/parts/notifications/notificationsCommands'; <ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> export interface INotificationsListOptions extends IListOptions<INotificationViewItem> { readonly widgetAriaLabel?: string;

Discussion:
Testing Repro: some notifications and focus one. You should hear a hint about opening the notification in the accessible view. !
Oh, this is because it's not focused. I found this a little confusing as the info message doesn't say it's a notification or anything so how would a new user know how to answer the question?
I'm still hitting this sometimes when the notification is focused as well No verbosity settings are set here: !
When this happens alt+f2 doesn't work It might be something off with context keys?
Proof: !
I was also going to report this - I triggered this notification and selected it to focus it, but I didn't get a hint: !
I have occasionally found that this does not work when I have the screen reader text view open. Can you try with that closed and speech on / volume up?
Is that the speech viewer / text box shows in his screenshots? I didn't have that open in my flow afaik.
I need to add to the aria label - currently, it's just to the free floating notification element
It's better now, but the hint still doesn't show up if the notification appears and the user tabs to it. The hint shows up if the user tabs to the button, but then Alt+F2 doesn't work while the user is on the button. Good: the screen reader optimized button. the notification. the show notification command. is properly displayed. Bad notifications from the notifications center. the screen reader optimized button. tab until the focus is on the notification. Enable tab moves focus mode if needed. :bug: The hint doesn't show up, and pressing Alt+F2 doesn't work. tab until the focus is on the Yes button. :bug: The hint shows up, but pressing Alt+F2 doesn't work. Let me know if you're able to reproduce the issue and whether it's worth reopening.
Thanks I'll probably wait to see if this is an issue screen reader users encounter.
Change:
id: MenuId.GlobalActivity, group: '2_configuration', order: 1, <del> when: CONTEXT_ENABLE_NEW_PROFILES_UI, </del> <ins> when: ContextKeyExpr.and(CONTEXT_ENABLE_NEW_PROFILES_UI, HAS_PROFILES_CONTEXT.negate()), </ins> }, { id: MenuId.MenubarPreferencesMenu, group: '2_configuration', order: 1, <del> when: CONTEXT_ENABLE_NEW_PROFILES_UI, </del> <ins> when: ContextKeyExpr.and(CONTEXT_ENABLE_NEW_PROFILES_UI, HAS_PROFILES_CONTEXT.negate()), }, { id: ProfilesMenu, group: '1_manage', when: ContextKeyExpr.and(CONTEXT_ENABLE_NEW_PROFILES_UI, HAS_PROFILES_CONTEXT), </ins> }, ] });

Discussion:
My suggestion would be to always have max 1 entry. Just if the user just has the default profile Otherwise. Just which expands into a list of profiles, and a entry at the end ! !
I prefer entry to be always at the first level because it is consistent with Changing the position of an action will be confusing It is consistent with other actions (Settings, Keyboard Shortcuts...) in that menu. How about changing entry to ?
Then keep Profiles as an entry point and only have that entry in all menus. Maybe only in activity bar menu allow switching profile. For others, make users switch profiles from the profiles view. In another issue you were arguing that switching profiles is not a common action - so why is it this prominent?
In addition to Activity bar menu, we show this profile switcher only in the top menu. May be it is consistent to have these menu items same in activity bar and top menu? Yes, switching a profile is not a common action but it is a very quick accessible location that most of the users got used when they want to switch the profile.
!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Love the change. Verified.
I also think this is a good change, I wonder for the wording: now we have "Profile" ="Profiles". How about something more explicit for the second entry: Similar maybe the command should be renamed then as well: ! Because you are not "opening" profiles, you open a management UI to edit them.
This is continued discussion here - - Please provide your feedback there. Thanks.
Change:
await this._start(); await this.code.waitForElement('.explorer-folders-view'); <ins> if (!this.options.web) { // Dismiss workspace trust dialog await this.code.waitAndClick(`.monaco-workbench .dialog-buttons-row a:nth-child(1)`, 10, 10); } </ins> // https://github.com/microsoft/vscode/issues/118748 // if (expectWalkthroughPart) { // 	await this.code.waitForElement(`.editor-instance > div > div.welcomePageFocusElement[tabIndex="0"]`);

Discussion:
In today Insider build a lot of Mac OS smoke tests failed all with The build is here: I will rerun the test to see if this is a hick-up or a general problem.
Seems related to Assigning some owners.
Change:
snippet.resolveVariables({ resolve() { return '11'; } }); assert.equal(snippet.toString(), 'It is not line 10'); }); <del> }); </del> <ins> test('Add workspace name variable for snippets #68261', function () { let workspace: IWorkspace; let resolver: VariableResolver; const workspaceService = new class implements IWorkspaceContextService { _serviceBrand: any; _throw = () => { throw new Error(); }; onDidChangeWorkbenchState = this._throw; onDidChangeWorkspaceName = this._throw; onDidChangeWorkspaceFolders = this._throw; getCompleteWorkspace = this._throw; getWorkspace(): IWorkspace { return workspace; } getWorkbenchState = this._throw; getWorkspaceFolder = this._throw; isCurrentWorkspace = this._throw; isInsideWorkspace = this._throw; }; resolver = new WorkspaceBasedVariableResolver(workspaceService); // empty workspace workspace = new Workspace(''); assertVariableResolve(resolver, 'WORKSPACE_NAME', undefined); // single folder workspace without config workspace = new Workspace('', toWorkspaceFolders([{ path: '/folderName' }])); assertVariableResolve(resolver, 'WORKSPACE_NAME', 'folderName'); // workspace with config workspace = new Workspace('', toWorkspaceFolders([{ path: 'folderName' }]), URI.file('testWorkspace.code-workspace')); assertVariableResolve(resolver, 'WORKSPACE_NAME', 'testWorkspace'); }); }); </ins>  No newline at end of file

Discussion:
It would be really helpful if a variable with the repository name (workspace name or opened folder) that was available to use in the snippets. In my case, i use the snippets to create copyright messages, and i am using the project name (the same of the repository) as part of this message.
Hey I'd like to work on this. Can I give it a shot? I appreciate if you have any quick guidance.
Snippet variables are implemented and instantiated . add a variable resolver that uses the (like the and ) add a test here
Thanks :)
Change:
index: e.target.selectedIndex, selected: e.target.value }); <ins> if (!!this.options[this.selected] && !!this.options[this.selected].text) { this.selectElement.title = this.options[this.selected].text; } </ins> })); // Have to implement both keyboard and mouse controllers to handle disabled options

Discussion:
DEBUG selectBox, when hover over, can't see title. Checked with latest insider build, has the same issue. While in version ! There is title ! May be caused be
do you have time to look into this?
do you see this for other dropdowns as well. For example the terminal dropdown, or the output channel name dropdown?
Terminal dropdown has no title either.
Ok, so it is a general select box issue. Let's see if has time to look into this
Absolutely. I've been a bit awol... Will look at this tomorrow.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
import { Match, FileMatch, FileMatchOrMatch, FolderMatch, RenderableMatch } from 'vs/workbench/parts/search/common/searchModel'; import { IReplaceService } from 'vs/workbench/parts/search/common/replace'; import * as Constants from 'vs/workbench/parts/search/common/constants'; <del> import { CollapseAllAction as TreeCollapseAction } from 'vs/base/parts/tree/browser/treeDefaults'; </del> import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { ResolvedKeybinding, createKeybinding } from 'vs/base/common/keyCodes';

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
sortText: data.e, filterText: data.f, preselect: data.g, <del> insertText: data.h || data.a, </del> <ins> insertText: typeof data.h === 'undefined' ? data.a : data.h, </ins> insertTextRules: data.i, range: data.j || defaultRange, commitCharacters: data.k,

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --THIS IS NOT A PYTHON EXTENSION ISSUE <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33 OS Version: Windows 10 This issue occurs only in vscode insiders, vscode stable works fine. Steps to Reproduce: Download development version of python extension from . Use -to install it, and reload window. Open a folder containing a python file in workspace. Open a python file to activate the extension. Then add configuration in as demonstrated in the gif, and try to re-add another configuration. ! Current behavior: When re-adding the configuration a second time, upon clicking in gif, a red colored "Python" string appears, and selecting any configuration after that does not work. ! Expected behavior: No such "Python" string appears, and configuration is . ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
FYI - The way i see it, this is a regression. I.e breaks in VSC Insiders and works in stable.
Assigning to April to investigate in the next couple of days
It seems that the interpretation of 'insert nothing' has changed. The suggestion is returned with as insertText (see ). It seems that before we would have actually inserted nothing and that now we insert the default, e.g. the label. We always set and now we can argue if the empty snippet string is falsy or not... So, yeah definitely something that changed on our side but unsure if that change is bad or towards more correctness. May I ask why you need a completion item that doesn't do anything expect showing a picker? Why aren't those pick-options presented as individual suggestions?
This is very likely caused by this like of code ( with , bisect master):
I have created to restore the old, questionable, behaviour. Tho would love to get feedback/explainer from if they are willing to model that fits the suggestion world better, e.g instead of using an empty suggestion as trampoline, have many suggestions with quick pick (basically what quick pick is used for today)
Change:
// responses: AsyncIterable<string>[] // FUTURE responses per N }; <del> promise.finally(() => { this._isDone = true; if (this._responseStreams.size > 0) { for (const [, value] of this._responseStreams) { value.stream.resolve(); } } else { this._defaultStream.resolve(); </del> <ins> promise.then(() => { for (const stream of this._streams()) { stream.resolve(); } }).catch(err => { if (!(err instanceof Error)) { err = new Error(toErrorMessage(err), { cause: err }); } for (const stream of this._streams()) { stream.reject(err); </ins> } <ins> }).finally(() => { this._isDone = true; </ins> }); } <ins> private * _streams() { if (this._responseStreams.size > 0) { for (const [, value] of this._responseStreams) { yield value.stream; } } else { yield this._defaultStream; } } </ins> handleFragment(fragment: IChatResponseFragment): void { if (this._isDone) { return;

Discussion:
Testing I asked a question and noticed this: ! Empty. Further inspection of my logs yielded: My participant is very straightforward: It throws on the: I was expecting to render in the chat
Currently, when there's an error, the stream is just going to be empty. But you can and that will be the actual failed promise with the error. Not sure if that's right or wrong, it looks like you can make the async iterable throw by calling on the , that might help for errors
Yeah, let's make sure to call but also know that this will be a generic error and that only the extension can make this graceful
This the stream and the result error, this is how my sample extension does it It's important to have for-await also inside try-catch
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
"editorGroup.border": "#0000001a", "editorGroupHeader.tabsBackground": "#f8f8f8", "editorGroupHeader.tabsBorder": "#0000001a", <del> "editorGutter.addedBackground": "#2ea04366", "editorGutter.deletedBackground": "#f8514966", "editorGutter.modifiedBackground": "#bb800966", "editorIndentGuide.activeBackground": "#c9d1d93d", </del> <ins> "editorGutter.addedBackground": "#2ea043", "editorGutter.deletedBackground": "#f85149", "editorGutter.modifiedBackground": "#005FB8", </ins> "editorIndentGuide.background": "#D3D3D3", "editorInlayHint.background": "#8b949e33", "editorInlayHint.foreground": "#8b949e",

Discussion:
Current Dark+ v2: ! I also notice we change blue to yellow? Dark+: ! I'm used to it being quite vibrant (Sapphire): !
Change:
return name; } <del> return name.replace(/^.|/.|..|~|^|:|/$|.lock$|.lock/||*|s|^s*$|.|[|]$/g, branchWhitespaceChar); </del> <ins> return name.replace(/^.|/.|..|~|^|:|/$|.lock$|.lock/||*|s|^s*$|.$|[|]$/g, branchWhitespaceChar); </ins> }; const result = await window.showInputBox({

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: ! OS Version: win7 pro Steps to Reproduce: the create branch ! a brunch ! a result, the wrong brunch was created !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.488 --- <!-- score: 0.454 --- <!-- score: 0.45 --- <!-- score: 0.448 --<!-- potentialduplicatescomment --
Change:
this.remoteAuthorityResolverService.resolveAuthority(this.environmentService.remoteAuthority) .then(async result => { this._remoteAuthority = result; <ins> await this.fileService.activateProvider(Schemas.vscodeRemote); </ins> await this.updateWorkspaceTrust(); }) .finally(() => {

Discussion:
I have a window that should be trusted, but is in Restricted mode. When I click "Trust" on the workspace trust management page, nothing happens. Here's what I'm doing, not sure what is important Clone a the windows remote and open in remote-ssh from a mac Debug the extension, open some folder The folder is already in the trusted list: <img width="1427" alt="image" src="https://user-"But when I click "Trust Parent", that works
I've been hitting this quite regularly for the past few months, also with (Windows) SSH remotes. I haven't been able to nail down what triggers it but give me a few attempts at reopening the remote and it'll always get into the bad untrusted state. Clicking Trust does nothing. In order to "re-trust" the workspace, I need to delete one of the bolded entries and then click Trust. ! Windows 11, VS Code 1.72.1 (user).
Okay I could not reproduce this myself, but my hunch is that this is a drive letter capitalization issue. I do not know why this is inconsistent, however. are you able to reproduce the state still? If so, can you help debug this check
Yeah, it's a drive capitalization issue. My workspace has a capital C:, the trust info has lowercase
! I'm experiencing a similar issue with VScode. It's launching in the restricted mode all the time regardless of whether I hit <kbdTrust</kbdin the past or not. This have been happening over the last few monthes or so already. Event though it's convenient that the vscode is prevented from wasting cpu & i/o time upon launching (I've over 3 apps opened daily) by the trust-wall, I'm still considering this an issue.
are you also using remote ssh?
No, I don't. I don't think that the issue with remote SSH connection.
can you provide more information about your setup. e.g. which patch you have trusted and the path that is being considered "untrusted"
Basically every path I work with everyday. There is also a problem with various tabs that are getting opened everytime computer gets started up. These include "Get started" and "Git Lenses" pages. I have to close them everytime code is started.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
minimap: { enabled: false }, <ins> autoClosingBrackets: configurationService.getValue('editor.autoClosingBrackets'), </ins> quickSuggestions: false }; }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When replying to a code review comment, the reply editor unconditionally auto-closes brackets. We have had complaints from users about not affecting this behavior (when set to ). We are not 100% convinced that should apply here, since conceptually, editing comments is different from editing code, so a separate setting for comments could be more flexible, but maybe also unnecessarily complex. discusses specifying a on to control other behavior like syntax highlighting (mainly plaintext vs Markdown). Since already supports using per-language settings, it might work well enough to just make also take effect in the comment reply editor.
it seems that only applies to the main editor and not also other editors. Is this expected? I took a look and from what I can see all will respect language configurations for auto closing pairs. It's only when you try to set it something other than that it get's ignored.
I don't know much about that setting, I'd need to debug too.
do you know the answer to
To allow for most flexibility, the code editor doesn't listen to the by itself. That job is always left to the place which instantiates editors. For example, the workbench listens to the and forwards all values to the editor instaces.
Change:
e.stopPropagation(); this._contextViewService.hideContextView(); this._updateContextKeys(provider, false); <ins> this._lastProvider = undefined; </ins> }; const disposableStore = new DisposableStore(); disposableStore.add(this._editorWidget.onKeyDown((e) => {

Discussion:
Testing It seems like the accessible buffer always open in screen reader accessibility mode after the link quickpick is closed, even if it was not open before. This seems like a bug. Also: it seems like Gitlens uses Ctrl+Shift+G as the start of its chords. With Gitlens installed, it overrides the keybinding, causing the editor to wait for another keypress.
Can you pls provide the exact repro steps?
For the first case: "Open Detected Link" from the command palette escape the accessible buffer is opened For the second issue, try using the Ctrl+Shift+G in the accessible buffer with Gitlens installed (on Windows at least)
Re the gitlens issue, most keybindings are taken, so I don't think I'll do anything about this.
In your steps above, if focus was in the accessible view before step 1, this is as designed. I cannot repro when I first focus the terminal.
Also assuming you pressed escape rather than going to a link
Also assuming you pressed escape rather than going to a link That's right Before step 1, I can have my focus in an editor or a terminal and the accessible view still opens. I noticed this only happens after I open the accessible view once: