jiebi/CodeConvo huggingface dataset:
Change:
import { Codicon, CSSIcon } from 'vs/base/common/codicons'; import { Emitter, Event } from 'vs/base/common/event'; import { IJSONSchema, IJSONSchemaMap } from 'vs/base/common/jsonSchema'; <ins> import { isString } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import { localize } from 'vs/nls'; import { Extensions as JSONExtensions, IJSONContributionRegistry } from 'vs/platform/jsonschemas/common/jsonContributionRegistry';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.0 OS Version: Windows 11 21H2 Steps to Reproduce: a window another window with and observe that product icon themes don't load immediately and you are shown the default ones for a short while. https://user- The video above contains an example of this issue happening. If it matters, I am using the Fluent Icons product icon theme.
Why does this have the feature request label? This is a bug.
Change:
export const editorWhitespaces = registerColor('editorWhitespace.foreground', { dark: '#e3e4e229', light: '#33333333', hc: '#e3e4e229' }, nls.localize('editorWhitespaces', 'Color of whitespace characters in the editor.')); export const editorIndentGuides = registerColor('editorIndentGuide.background', { dark: editorWhitespaces, light: editorWhitespaces, hc: editorWhitespaces }, nls.localize('editorIndentGuides', 'Color of the editor indentation guides.')); export const editorLineNumbers = registerColor('editorLineNumber.foreground', { dark: '#5A5A5A', light: '#2B91AF', hc: Color.white }, nls.localize('editorLineNumbers', 'Color of editor line numbers.')); <ins> export const editorActiveLineNumber = registerColor('editorActiveLineNumber.foreground', { dark: null, light: null, hc: null }, nls.localize('editorActiveLineNumber', 'Color of editor active line number')); </ins> export const editorRuler = registerColor('editorRuler.foreground', { dark: '#5A5A5A', light: Color.lightgrey, hc: Color.white }, nls.localize('editorRuler', 'Color of the editor rulers.')); export const editorCodeLensForeground = registerColor('editorCodeLens.foreground', { dark: '#999999', light: '#999999', hc: '#999999' }, nls.localize('editorCodeLensForeground', 'Foreground color of editor code lenses'));

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.1() and 1.11.0-insider () OS Version: Windows 10 -- Sorry for the English, I used Google Translator -- Allow different color in the line number when the cursor is on that line. Like Atom. !
Is this feature not available for macOS?
Seems like a useful feature (or at least appealing). Now only doable as a hack with extension: ! For this to work highlight should include the gutter (in ) But this should be theme configurable.
Change:
return this.sortExtensions(themesExtensions, options); } <del> const isLangaugeBasicExtension = (e: IExtension): boolean => { </del> <ins> const isLanguageBasicExtension = (e: IExtension): boolean => { </ins> return FORCE_FEATURE_EXTENSIONS.indexOf(e.identifier.id) === -1 && (Array.isArray(e.local?.manifest?.contributes?.grammars) && e.local!.manifest!.contributes!.grammars.length > 0); }; if (showBasicsOnly) { <del> const basics = result.filter(isLangaugeBasicExtension); </del> <ins> const basics = result.filter(isLanguageBasicExtension); </ins> return this.sortExtensions(basics, options); } if (showFeaturesOnly) {

Discussion:
I found a few places that "Language" is accidentally spelled "Langauge" in the source. See for the corrections.
Change:
"name": "Strings: Symbols", "scope": "constant.other.symbol", "settings": { <del> "foreground": "#AB6526" </del> <ins> "foreground": "#9C5D27" </ins> } }, {

Discussion:
Environment Details: VSCode Version : 1.24.0 OS Version : Win10 Additional Details: MAS Violated : MAS 1.4.3 Tools Used : Color Contrast Analyzer Repro Steps: 1)Navigate to Settings--Select color theme --Select Quiet light. 2)Check color contrast ratio for the Explorer content on the screen. Actual: Color contrast ratio is less than 4.5:1 for the black colored content when focused. Similar issue is observed in following themes: Abyss Kimbie dark Monokai Dimmed High contrast Install additional color theme Expected: Color contrast ratio should be more than 4.5:1 for the content on a screen. Recommendations: Refer below link which is repository of bug fixes code snippets:   User Impact: The low vision/visually impaired users will not be able to view the content properly. MAS Reference: MAS 1.4.3 - {-765f-489c-b18f-}  Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.981 --- <!-- score: 0.924 --- <!-- score: 0.875 --- <!-- score: 0.869 --- <!-- score: 0.867 --<!-- potentialduplicates_comment --
Per our agreement, we will not be fixing color contrast issues with third party themes. cc
just a note that we are the authors of this theme (actually I am the original author) Does this mean that we only fix for the Light+ and Dark+?
we're supposed to fix any issues for themes that we own and ship with out of the box (except for third party themes we don't own). I didn't know we own QuietLight so I'll re-open.
Checked and verified in below version i.e 1.27.0-Insiders. The issue still exist in Quite Light theme. Similar issue is observed in following themes: 1)Solarized light:All the text in the page fail in color contrast ratio i.e 4.5:1 2)Light visual studio: Black coloured text fail in color contrast ratio i.e 4.5:1
please see for the unused variable color issues
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'vscode' { /** * Represents an item that can be selected from * a list of items. */ export interface QuickPickItem { /** * The icon path or {@link ThemeIcon} for the QuickPickItem. */ iconPath?: Uri | { light: Uri; dark: Uri } | ThemeIcon; } } </del>

Discussion:
Would it be possible to allow for extensions to provide icons in s? At the moment we can use via the syntax, but if we want to provide a custom icon that is more complex (perhaps we can do that be providing a font and a partial product icon theme?). With a , we can pass in an optional icon path: Could we add this to QuickPickItem too? Based on the quick open input, there is already space afforded in the UI for the icon, so it would be useful if extensions to provide one.
Related to which asks for the ability to specify filetype icons.
Proposal: It looks a bit off using squares: !
Example with circles for reference: !
For anyone curious, circles are possible by using data URIs: Example and copied here for reference:
Change:
const ignoreImportantExtensionRecommendationStorageKey = 'extensionsAssistant/importantRecommendationsIgnore'; const donotShowWorkspaceRecommendationsStorageKey = 'extensionsAssistant/workspaceRecommendationsIgnore'; <del> const choiceNever = localize('neverShowAgain', "Don't Show Again"); </del> type RecommendationsNotificationActions = { onDidInstallRecommendedExtensions(extensions: IExtension[]): void;

Discussion:
Type: <bFeature Request</bThe notification suggesting a plugin has a cog with an option "Don't show again". It's however not clear whether this suppresses suggesting the specific plugin, or any plugin. Either this message should be clarified ("Don't show this plugin again") or a second option should be . VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
<img width="485" alt="image" src=""<img width="478" alt="image" src=""
Thank you.
Change:
run(entry: QuickOpenEntry, mode: Mode, context: IContext): boolean { return entry.run(mode, context); } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
VSCode Version: 1.0.0-alpha OS Version: Windows10 Mouse hove on the truncated path in the command pallete is not displaying full path. User can't dynamically change the command pallete window size so it is hard to identify file path for manual verification. !
Change:
.then(extensions => { for (const extension of extensions) { const requireReload = !(extension.local && this.extensionService.canAddExtension(toExtensionDescription(extension.local))); <del> const message = requireReload ? localize('InstallVSIXAction.successReload', "Please reload Visual Studio Code to complete installing the extension {0}.", extension.identifier.id) : localize('InstallVSIXAction.success', "Completed installing the extension {0}.", extension.identifier.id); </del> <ins> const message = requireReload ? localize('InstallVSIXAction.successReload', "Please reload Visual Studio Code to complete installing the extension {0}.", extension.displayName || extension.name) : localize('InstallVSIXAction.success', "Completed installing the extension {0}.", extension.displayName || extension.name); </ins> const actions = requireReload ? [{ label: localize('InstallVSIXAction.reloadNow', "Reload Now"), run: () => this.windowService.reloadWindow()

Discussion:
When installing the extension completes, the message is shown: "Completed installing the extension <publisher.<name. Instead, the extension displayName should be shown. VSCode Version: 1.36 OS Version: Windows 10 !
Currently, is displayed, it would be better if is shown.
Change:
} protected _getGoToPreference(editor: IActiveCodeEditor): GoToLocationValues { <del> return editor.getOption(EditorOption.gotoLocation).multipleImplemenations; </del> <ins> return editor.getOption(EditorOption.gotoLocation).multipleImplementations; </ins> } }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.41.0-insider OS Version: Windows_NT x64 10.0. Steps to Reproduce: to settings for "Implemenations" "Editor Goto Location: Multiple Implemenations" appears instead of "Editor Goto Location: Multiple Implementations" This also shows up as "editor.gotoLocation.multipleImplemenations" in "" instead of as "editor.gotoLocation.multipleImplementations" <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Change:
* Event triggered by extensions to signal to VS Code that the content of a {@link CustomDocument `CustomDocument`} * has changed. * <del> * @see {@link CustomDocumentProvider.onDidChangeCustomDocument `CustomDocumentProvider.onDidChangeCustomDocument`}. </del> <ins> * @see {@link CustomEditorProvider.onDidChangeCustomDocument `CustomEditorProvider.onDidChangeCustomDocument`}. </ins> */ interface CustomDocumentContentChangeEvent<T extends CustomDocument = CustomDocument> { /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.56.1 OS Version: Windows 10 Prof 64 Bit Steps to Reproduce: CustomDocumentProvider to CustomEditorProvider line 7747 line 7786 TaskProvider line 6697: create a md link from #tasks.registerTaskProvider <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Hi, I would like to look into this issue. Could I be assigned ?
I'm new to this, but I'm eager to learn!
Hello, can I work on this issue ?
This is a very small change so please just submit a PR
Change:
private readonly _openerService: IOpenerService, private readonly _keybindingService: IKeybindingService, private readonly _hoverService: IHoverService, <ins> private readonly _configurationService: IConfigurationService, </ins> private readonly _onFinishedRendering: () => void, ) { super();

Discussion:
Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers
Change:
quickPick.hideInput = true; quickPick.title = localize('customizeLayoutQuickPickTitle', "Customize Layout"); <ins> const closeButton = { alwaysVisible: true, iconClass: Codicon.close.classNames, tooltip: localize('close', "Close") }; const resetButton = { alwaysVisible: true, iconClass: Codicon.discard.classNames, tooltip: localize('restore defaults', "Restore Defaults") }; </ins> quickPick.buttons = [ <del> { alwaysVisible: true, iconClass: Codicon.close.classNames, tooltip: localize('close', "Close") } </del> <ins> resetButton, closeButton </ins> ]; const disposables = new DisposableStore();

Discussion:
Testing While experimenting with the 'customize layout' control, I switched my panel alignment but then wasn't sure what to reset it back to Can we add a indicator that tells users what the default alignment is?
I suppose this feedback should be applied to the other options as well. it isn't the only item with a default value, but I am also a little hesitant as it makes the experience somewhat noisy and the user can select whatever option they like the most. thoughts?
This was the only option that was confusing to me but I can see just adding a default label to one section would be a little weird Another option is to add a entry inside that resets the entire layout. That is pretty much what I was wanted after experimenting with these options
I think reset is quite interesting, I will update this as a feature request for that
To verify: the "Customize Layout" action the layout the reset icon in the top right of the quick pick From the code, here is the list of stuff that I expect to be reset:
Change:
import { ICellDto2, INotebookEditorModel, INotebookLoadOptions, IResolvedNotebookEditorModel, NotebookCellsChangeType, NotebookData } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { INotebookSerializer, INotebookService, SimpleNotebookProviderInfo } from 'vs/workbench/contrib/notebook/common/notebookService'; import { IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService'; <del> import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; </del> import { IFileWorkingCopyManager } from 'vs/workbench/services/workingCopy/common/fileWorkingCopyManager'; import { IStoredFileWorkingCopy, IStoredFileWorkingCopyModel, IStoredFileWorkingCopyModelContentChangedEvent, IStoredFileWorkingCopyModelFactory, IStoredFileWorkingCopySaveEvent, StoredFileWorkingCopyState } from 'vs/workbench/services/workingCopy/common/storedFileWorkingCopy'; import { IUntitledFileWorkingCopy, IUntitledFileWorkingCopyModel, IUntitledFileWorkingCopyModelContentChangedEvent, IUntitledFileWorkingCopyModelFactory } from 'vs/workbench/services/workingCopy/common/untitledFileWorkingCopy';

Discussion:
a new notebook (or new image with Luna editor) and also a new text file all the editors dirty hotexit is off the window, selecting "don't save" when prompted to revert all working copies -open the window - the text editor is gone (closed during shut down), but the other editors are open and blank.
This is why I thought the revert behavior was broken in I think it would be much better if an interactive window closed when it was reverted.
this is really up to the editor itself to decide whether to close the editor when the underlying working copy is reverted or not. Generally working copies try to stay as agnostic as possible to editors. There is only very few exceptions when it comes to restoring backups. Untitled editors listen to working copies getting reverted to self-dispose: This in turn, will close the editor. I suggest you go down a similar path. fyi for custom editors
fixed for notebook/Interactive window editor. - did you want another issue to track this for custom editors?
Yes that would be great
Change:
assert.deepEqual(innerLazy.getValue(), [1, 11]); }); <del> test('map should should handle error values', () => { </del> <ins> test('map should handle error values', () => { </ins> let outer = 0; let inner = 10; const outerLazy = new Lazy(() => { throw new Error(`${++outer}`); });

Discussion:
VSCode Version: 1.41.0 OS Version: Not applicable Steps to Reproduce: to row 50 that the word 'should' is unexpectedly repeated. Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.633 --<!-- potentialduplicatescomment --
Change:
import { ITextModel } from 'vs/editor/common/model'; import { Selection } from 'vs/editor/common/core/selection'; import { VariableResolver, Variable, Text } from 'vs/editor/contrib/snippet/snippetParser'; <del> import { getLeadingWhitespace, commonPrefixLength, isFalsyOrWhitespace } from 'vs/base/common/strings'; </del> <ins> import { getLeadingWhitespace, commonPrefixLength, isFalsyOrWhitespace, pad } from 'vs/base/common/strings'; </ins> import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; export const KnownSnippetVariableNames = Object.freeze({ <ins> 'CURRENT_YEAR': true, 'CURRENT_YEAR_SHORT': true, 'CURRENT_MONTH': true, 'CURRENT_DATE': true, 'CURRENT_HOUR': true, 'CURRENT_MINUTE': true, 'CURRENT_SECOND': true, </ins> 'SELECTION': true, 'CLIPBOARD': true, 'TM_SELECTED_TEXT': true,

Discussion:
Edit: Sorry if this is a terrible issue... The current list of variables available when writing a snippet can be found . Existing variables expose great contextual information - such as current file, directory, line number, word, etc. Development happens so fast that information can become outdated, so knowing when some custom snippets were inserted could be useful. For example, when creating files or adding comments. My current use case is a snippet that inserts copyright headers. The key binding inserts the header: It would help to include the date: and could also apply to updates or comments: Doing so could mean a simple variable like , but that may not work for non-US users who's date format is different i/e not month/day/year. Perhaps exposing the variables separately such as , etc or localization can help? I'd like to know if there is any interest in this. I know an extension could do this but it seems like overkill, but that could depend on potential use cases. Thanks for any feedback.
Hm, this is dupe of many requests we have gotten around this but made a valid point. Adding variables for year, month, day and hour, minute, second makes sense. That will allow anyone to compose it's own date. So, yeah feel free to drop a PR
Good to hear. Thanks for the PR!
Change:
[[package]] name = "inno_updater" <del> version = "0.10.0" </del> <ins> version = "0.10.1" </ins> dependencies = [ "byteorder", "crc",

Discussion:
Type: <bBug</bI get nightly updates on VSCode insiders and I get the crash on whenever I restart the app for updating it. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-13T05:33:32.822Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (21)</summaryExtensionVersion ------ vscode-chromium-vector-icons1.0.2 togglehs0.1.2 gitlens2023.7.1305 copilot1.96.259 copilot-chat0.5. mojom-language0.0.1 vscode-webidl0.0.1 vscode-clangd0.1.24 cpplint0.1.3 autopep82023.7. python2023.13. vscode-pylance2023.7.21 remote-ssh0.103. remote-ssh-edit0.86.0 cpptools1.16.3 remote-explorer0.5. gnls0.1.4 java1.21. code-spell-checker2.20.5 change-case1.0.0 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Any details on the crash? Any error messages? Any logs?
I've attached the Crash Dump. Note: I used 7-zip to compress to 7z and then to zip (to make it smaller that GitHub allowed size and format).
The same thing has been happening to me.
This has been happening to me too.
Thanks guys, I've confirmed the issue!
Got a stack trace:
Caused by , namely: