jiebi/CodeConvo huggingface dataset:
Change:
private _providers: Map<number, ITaskProvider>; private _providerTypes: Map<number, string>; protected _taskSystemInfos: Map<string, TaskSystemInfo>; <ins> private _providerProgressManager: ProviderProgressMananger | undefined; </ins> protected _workspaceTasksPromise?: Promise<Map<string, WorkspaceFolderTaskResult>>; protected _areJsonTasksSupportedPromise: Promise<boolean> = Promise.resolve(false);

Discussion:
We have a temporary fix for the release for but we need to do something better long term.
while working on quick access for tasks I noticed that we seem to be having 2 pickers for the same thing (?): Task quick open: ! "Run Task" picker: ! Is that intentional? Should the one be merged into the other?
Yes, they do not share much code :( as part of improving the quick pick I will converge them.
sounds good, please only change  and leave the other one because I plan to delete those old ones soon.
Change:
readonly suggestOnTriggerCharacters: boolean; readonly acceptSuggestionOnEnter: boolean; readonly snippetSuggestions: 'top' | 'bottom' | 'inline' | 'none'; <ins> readonly emptySelectionClipboard: boolean; </ins> readonly tabCompletion: boolean; readonly wordBasedSuggestions: boolean; readonly suggestFontSize: number;

Discussion:
Like the title says, when nothing is selected, copying shouldn't copy a blank character.
As of now, cmd+c without any selection, copies the entire line. Sublime also does the same. Are we suggesting to change this behavior as part of this issue? I really like the current functionality. Or are we suggesting one more option/flag which user can enable to have the new functionality?
Yes, it would be behind an option
Can we have the option for this behavior or disable it? I don't like the auto copy of a blank line and would like to disable that feature. I agree it can be annoying especially in the type of coding I do (debugging).
Was a setting for this?
it is
disables the line copying entirely. Is there a way to have line copying enabled, while simultaneously ignoring the empty lines?
This doesn't disable the copying within my VS Code at all and I can still copy whitespace - anyone else had any luck? fingers crossed
Change:
import { KeyCode } from 'vs/base/common/keyCodes'; import { ResolvedKeybinding } from 'vs/base/common/keybindings'; import * as dom from 'vs/base/browser/dom'; <ins> import * as aria from 'vs/base/browser/ui/aria/aria'; </ins> import { IKeyboardEvent, StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { FastDomNode, createFastDomNode } from 'vs/base/browser/fastDomNode'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';

Discussion:
A11yMAS; #A11yWCAG2.1; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.3; #NVDA; #ScreenReader; #Narrator; #Closed Visual Studio Code Version: 1.70.2 (user setup) Windows 11 Pro version 21H2 (OS Build .856) on NVDA Visual studio code editor. till setting icon and Select "Keyboard shortcuts options" that Key bending status message "1 existing command has this key bending" is announced by screen reader or not. Key bending status message "1 existing command has this key bending" is not announced by NVDA/Narrator screen readers. NVDA/Narrator should announce the status message "1 existing command has this key bending" ! !
can we just do an aria alert when there are existing keybindings? This issue we have to fix since it is severity 2, though it sounds law hanging.
PO should not close the bug. Only trusted tester closes the bug. This bug is not fixed. So, please provide the reason for closing the bug. Thanks
make sure to use VS Code insiders
Issue is fixed. So,Closing the bug. !
Change:
}); } <del> public run(_accessor: ServicesAccessor, editor: ICodeEditor): void { </del> <ins> public run(accessor: ServicesAccessor, editor: ICodeEditor): void { </ins> const linkDetector = LinkDetector.get(editor); if (!linkDetector) { return;

Discussion:
The content of the line: Open definition does nothing !
Also happens on Mac with Cmd+Click. Makes it very difficult to navigate my documentation.
I believe this is a result of fixing Markdown has a link provider and a definition provider. However in this case, the definition provider returns since we are not on a reference link
revert of the bad change is up
Change:
} } return null; <ins> }).catch((error) => { onUnexpectedError(error); return null; </ins> }); } }

Discussion:
or VS Code Desktop 1) Enable sticky scroll 1) Type 1) Errors should spawn (with delay / debounce) in console Throws aync cancel error No response It IS_ reproducible in also! But I had to check it to be able to submit this form
Hi Anders, I am still having this issue. Lots of errors are generated each time I type something with stickyScroll on. Does closing this issue mean that it has been solved?
you are right! it's still yields a lot of errors - I was too fast when I saw the new version and updated vscode ref.
, are you sure this bug shouldn't be filed at ?
I did - it was moved here by hediet the 13. of April (see "log" on this page).. it seems like it was fixed in vscode and made it to the site - and the monaco vscode ref was update after - but I spose the ref was for an "earlier" version :/
any status on this cool feature? It has been a couple of monaco releases now with out a fix and it seems to have been fixed elsewhere
this is still an issue in version 0.41.0
Hi Is it possible to publish a small fix with a try catch surrounding the ()? Debugging code in combination with this monaco feature is becoming very hard to do because it floods the debugger with a lot of duplicate errors.. If not, we will wait patiently, you will get a lot of kudos for your good work anyhow ;-) !
can you look into this? I think it should be easy to fix.
Will do so now
Change:
resolved "https://registry.yarnpkg.com/arrify/-/arrify-1.0.1.tgz#898508da2226f380df904728456849c1501a4b0d" asap@~2.0.3: <del> version "2.0.5" resolved "https://registry.yarnpkg.com/asap/-/asap-2.0.5.tgz#522765b50c3510490e52d7dcfe085ef9ba96958f" </del> <ins> version "2.0.6" resolved "https://registry.yarnpkg.com/asap/-/asap-2.0.6.tgz#e50347611d7e690943208bbdafebcbc2fb866d46" </ins> asar@^0.14.0: version "0.14.0"

Discussion:
VSCode Version: 1.17.0 () OS Version: Ubuntu 16.04 LTS Steps to Reproduce: "files.useExperimentalFileWatcher": true and close VS Code a symlink to root directory (must be an absolute link, not relative!): directory containing that symlink in VS Code: processes - one of vs code processes takes high CPU Reproduces without extensions: Yes See also:
Just noticed the same thing on osx...
Updating issue with: vs code version 1.17.0 reproduces without extensions ! Also, I found memory usage increasing over time...
Same issue here vs code version 1.17.2 Even after closing the VsCode the Code Helpers is still running with 100% CPU usage.
Reported upstream
Upstream PR
The original PR was closed so I opened one which was merged , just need a release to pull this in.
I have vscode 1.19.2 on Ubuntu. The various nodemodules directories have symbolic links point to each other that form the circular links. The nodemodules is set excluded in "files.watcherExclude". After vscode is started, it uses 100% CPU and memory usage increased dramatically and soon reached the max memory and hang the system. This problem happens whatever useExperimentalFileWatcher is set true or false. The ps shows the problem code process has parameter '--type=watcherService". Attached gdb to the process, it shows the watcher follows through the circular symbolic links in circular. Set "search.followSymlinks": false has no effect,. So this problem still happens in 1.19.2 even with all the right settings in place.
is it possible/easy to patch VS Code to stop this behaviour while waiting for it to hit a release? I have a workspace that causes a 20GB VM to exhaust its memory in about 15 mins because of circular symlinks (it uses lerna).
yeah I'll fork the module to get this in, was hoping I wouldn't need to.
what's the expected behavior after the change? I'm still seeing high CPU on today's insiders version on Ubuntu ! on Mac
the fix is specific to Linux only when you have experimental file watcher set to true in settings (or you have a multi-root workspace open).
If you have this issue, it's not just high CPU usage - your memory will be exhausted within minutes.

With a workspace with circular symlinks in it (it uses lerna and has circular dependencies), I was seeing 20GB of RAM get sucked up in about 15 minutes. Insiders has had the fix for a while now.
thanks, I'll mark as verified since you saw it before :+1:
Change:
constructor() { super({ id: 'cursorRedo', <del> label: nls.localize('cursor.redo', "Soft Redo"), alias: 'Soft Redo', </del> <ins> label: nls.localize('cursor.redo', "Cursor Redo"), alias: 'Cursor Redo', </ins> precondition: undefined }); }

Discussion:
There is a command called "cursorUndo", which undo's cursor and selection movements. In the command palette it is called "Soft Undo". I think the name in the command palette should be changed from "Soft Undo" to "Cursor Undo". This will make the command more discoverable, and more intuitive for users to figure out what it does. When I found this command in the command palette, I tried typing "hello" and then using it, but it did nothing, because the cursor hasn't moved since the last edit. I had to google it to figure out what the command does. Even though the command also undo's selection changes and not just cursor movements, I think "cursor" is a general term the refers to both "cursor" and "selection". Also, the command name itself is already "cursorUndo", it makes sense for the name in the command palette to use the same term. Having "cursor" in the command's name will make it clear it undo's things that the cursor does, such as moving and selecting text. A user that will find this command in the command palette will most likely attempt to move the cursor and then use the command, and then will understand what it does. VSCode Version: 1.38.1 OS: Windows
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.552 --<!-- potentialduplicatescomment --
This issue is different than the suggested duplicates.
I have made a PR fixing this.
Even the post and comments when it was named "Soft Undo" agree it should have the word "cursor" or "selection" -
Now that command was merged (PR ) it also should have its label renamed from "Soft Redo" to "Cursor Redo".
Change:
// keep item in memory this._memoryService.memorize(model, this.editor.getPosition(), item); <ins> const scrollState = StableEditorScrollState.capture(this.editor); </ins> if (Array.isArray(suggestion.additionalTextEdits)) { this.editor.executeEdits('suggestController.additionalTextEdits', suggestion.additionalTextEdits.map(edit => EditOperation.replace(Range.lift(edit.range), edit.text))); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I would like an option to virtually prevent vscode from pushing down the current focused line when new lines are automatically . For example, when I click to automatically add an import, vscode adds the import line and the current focused line is scrolled down. This causes a distraction because the line I'm working on is moved away even tho I didn't want to scroll. Here is a gif showing how IntelliJ behavior when new lines are automatically above the current selected line. Note that after the import statement is the current line is virtually kept the same (the line number do change, of course, but the scroll is set to a new position in order to respect the old position): ! The next gif show how vscode pushes down the code and loses the previous virtual position: ! Would be possible to add an option to vscode behavior like IntelliJ in this situation?
Technically, the editor does not scroll. The scrollTop is maintained. It just happens that everything is pushed down by the auto-import which inserts a line at the top of the file. This can be done from the outside if you know there are edits unrelated to the current cursor position in the suggestion e.g.:
I'd like to help out with this! Any additional pointers would be appreciated.
This is where the first potential edit happens: and this is where it is done: So, those two places should be used to capture and restore the scroll state
to verify: down a bit a typescript suggestion that adds an import sure that the scroll position stays stable (lines aren't pushed down)
Change:
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.45.tgz#cf1144091d6683cbd45a231954a745f02fb24598" integrity sha512-czF9eYVuOmlY/vxyMQz2rGlNSjZpxNQYBe1gmQv7al171qOIhgyO9k7D5AKlgeTCSPKk+LHhj5ZyIdmEub9oNg== <del> electron@18.3.2: version "18.3.2" resolved "https://registry.yarnpkg.com/electron/-/electron-18.3.2.tgz#015a8f4c92c62855d7f33206f2166d3e33b053b7" integrity sha512-Q1ciZ1M90L71WvyLbkD8Iwaq4YCwo8NUpBiLQUsd6M4E7i5vrzsA4g5Ylfzyela8DgRCNVknDVDfj6s+7YVWpA== </del> <ins> electron@18.3.3: version "18.3.3" resolved "https://registry.yarnpkg.com/electron/-/electron-18.3.3.tgz#1c48273c1ad1522b8c18f19575e862c7ccd9f409" integrity sha512-LYxf3uCDc/r0klu7LL0eZLxkseoGIY/vrCfS0Qj4YTU3M7LLjOaIqrajI7icKwaI2dgxiuJJH3n4eqALFpJAFg== </ins> dependencies: "@electron/get" "^1.13.0" "@types/node" "^16.11.26"

Discussion:
Testing When I just launch and then quit VSCode, I see the black dot on the dock for quite some time. I have launched from CLI: !
Yeah, running with :
This is a side effect of how we gracefully shutdown the utility process, previously the extension host was responsible for shutting itself down and we block the main process exit based on it Utility process lifetimes are controlled by the main process, (i-e) on graceful shutdown of the application the main process will first try to quit the main message loop and the applications have a chance to block this exit based on , event listeners and we use that today to provide chance to shutdown our services and once message loop is good to exit, the main process will cleanup C++ handles to the JS objects and only during this phase I also shutdown the running utility processes gracefully which will emit the event, after that the node environments, child process and threads in the main process will get shutdown one after other eventually exiting the main process itself. So what we are currently seeing is a chicken and egg problem, where the main message loop exit is blocked for 6s by the extension host exit, but the extension host exit is blocked on event from the main message loop. Solution: The runtime can only cleanup the utility process once the main message loop is ready to exit, if the exit is blocked on the application end it is not possible to know when to gracefully shutdown the process from the runtime side. Thoughts ? Alternatively, from the runtime side I can move the cleanup of utility process earlier just before the , event listeners get emitted so that the application receives an event.
The extension host processes should exit by themselves when the MessageChannel is closed. My intuition here is that the event might not be firing on the instance, but I need to debug it to confirm.
Ah yeah, I currently don't emit the event when gets disconnected however the process does exit. Will address it.
Change:
} session = await this.authenticationService.createSession(providerId, scopes, true); <del> await this.setTrustedExtensionAndAccountPreference(providerId, session.account.label, extensionId, extensionName, session.id); </del> <ins> await this.authenticationService.updatedAllowedExtension(providerId, session.account.label, extensionId, extensionName, true); this.storageService.store(`${extensionName}-${providerId}-${scopes.join('-')}`, session.id, StorageScope.GLOBAL, StorageTarget.MACHINE); </ins> } else { await this.authenticationService.requestNewSession(providerId, scopes, extensionId, extensionName); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: an extension that does this: 'll notice that is though it should exist because we created it on line 1. This is because we cache the session id based on the provider id & extension name but really we should be caching them based on provider id, extension name, AND SCOPES. This will allow the 3rd time to find the session created in the first line.
Verification steps: The code session3 should not be undefined.
is your solution to this issue the reason that the Insiders builds have started bugging me at least once a day to sign into GitHub? With four windows open, each with two extensions that want a GitHub token (GitLens and GitHub Issues and Pull Requests), I have to generate 8 tokens to make VS Code stop bugging me... at which point it almost always discovers a VS Code update, and often we do the dance again after it restarts.
(And never mind, I see it was, and I see you fixed it!)
Reopening this because I reverted the change that fixed it.
just checking to see if there were any updates on this issue?
haven't had a chance to revisit this. You can take a look at my commit if you'd like. The problem I needed to address is migrating from the old storage keys to the new storage keys and my commit didn't handle that. Unfortunately, I have some other work I'm working on at the moment so I won't be able to look at this this month.
This appears to be fixed. Closing now
verification: original steps to repro. Instead, session3 should be defined.
Change:
this.sideBySidePreferencesWidget.setResultCount(count.target, count.count); } else if (this.searchWidget.getValue()) { if (countValue === 0) { <del> this.searchWidget.showMessage(nls.localize('noSettingsFound', "No Results"), countValue); </del> <ins> this.searchWidget.showMessage(nls.localize('noSettingsFound', "No Settings Found"), countValue); </ins> } else if (countValue === 1) { this.searchWidget.showMessage(nls.localize('oneSettingFound', "1 Setting Found"), countValue); } else {

Discussion:
In approx 1/4 of my installed themes this badge looks awful: ! Having no-results just doesn't feel like an error. Standard badge color (Like white here on github badge) is fine(because it's usually made for it). P.S. no need for a new color, already too many of them. P.P.S. actually new settings editor doing exactly that: ! So, it just needs to be aligned with the GUI version of settings.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.532 --- <!-- score: 0.51 --- <!-- score: 0.491 --<!-- potentialduplicatescomment --
Change:
}); }); <del> (vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite)('statusbar', () => { const emitter = new vscode.EventEmitter<vscode.NotebookCell>(); const onDidCallProvide = emitter.event; const suiteDisposables: vscode.Disposable[] = []; suiteTeardown(async function () { assertNoRpc(); await revertAllDirty(); await closeAllEditors(); disposeAll(suiteDisposables); suiteDisposables.length = 0; }); suiteSetup(() => { suiteDisposables.push(vscode.notebooks.registerNotebookCellStatusBarItemProvider('notebookCoreTest', { async provideCellStatusBarItems(cell: vscode.NotebookCell, _token: vscode.CancellationToken): Promise<vscode.NotebookCellStatusBarItem[]> { emitter.fire(cell); return []; } })); suiteDisposables.push(vscode.workspace.registerNotebookContentProvider('notebookCoreTest', apiTestContentProvider)); }); test('provideCellStatusBarItems called on metadata change', async function () { const provideCalled = asPromise(onDidCallProvide); const notebook = await openRandomNotebookDocument(); await vscode.window.showNotebookDocument(notebook); await provideCalled; const edit = new vscode.WorkspaceEdit(); edit.set(notebook.uri, [vscode.NotebookEdit.updateCellMetadata(0, { inputCollapsed: true })]); await vscode.workspace.applyEdit(edit); await provideCalled; }); }); </del> suite('Notebook & LiveShare', function () { const suiteDisposables: vscode.Disposable[] = [];

Discussion:
From
The core might have heuristics of if/when should be called, maybe this test can be turned into a unit test first?
Was just looking at this. That might make sense too, but it also seems to make sense to test this as an API contract.
Is it going to make a difference if I move off the deprecated WorkspaceEdit api?
The issue you have mentioned with the editor service, I wonder if that could be in play here because this failure is just implying that the cell did not get rendered and initially request statusbar items. This test also doesn't make sense because it's just awaiting the same promise twice
Change:
this.setHover(node.checkbox); this.setAccessibilityInformation(node.checkbox); this.toggle.domNode.classList.add(TreeItemCheckbox.checkboxClass); <ins> this.toggle.domNode.tabIndex = 1; </ins> DOM.append(this.checkboxContainer, this.toggle.domNode); this.registerListener(node); }

Discussion:
When exporting a profile, a SR user has to navigate the whole list to reach the button. We should either move the button to the top or have a keybinding/command which does this. cc <img width="293" alt="Screenshot 2023-07-31 at 11 30 34 AM" src=""
Is not the tab should take to Export button when the complete tree is focused instead of focusing the check box?
I'm not following
Try to get into the state where Tree is focused not any of the elements of the Tree. For eg: <img width="662" alt="image" src=""See the outline focusing the tree. Press <tabnow. This should focus the Export button right?
correct - pressing tab when my screen looks like the above causes focus to be lost rather than going to the button.
Tab at this state is taking focus to the checkbox in the tree. IMO checkbox should be focused when the row is focused and you tab then. Is it possible to change this behaviour?
Change:
justify-content: center; } <ins> /* find in selection button */ .monaco-editor .find-widget .codicon-find-selection { width: 22px; height: 22px; padding: 3px; border-radius: 5px; } </ins> .monaco-editor .find-widget .button.left { margin-left: 0; margin-right: 3px;

Discussion:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"