jiebi/CodeConvo huggingface dataset:
Change:
import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { Snippet, SnippetSource } from 'vs/workbench/contrib/snippets/browser/snippetsFile'; <del> import { IQuickPickItem, IQuickInputService, QuickPickInput } from 'vs/platform/quickinput/common/quickInput'; </del> import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <del> import { Codicon } from 'vs/base/common/codicons'; import { Event } from 'vs/base/common/event'; </del> <ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { pickSnippet } from 'vs/workbench/contrib/snippets/browser/snippetPicker'; </ins> class Args {

Discussion:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.
Change:
localize('commandCenter-background', "Background color of the command center"), false ); <del> const activeBackground = colors.registerColor( </del> <ins> colors.registerColor( </ins> 'commandCenter.activeBackground', { dark: MENUBAR_SELECTION_BACKGROUND, hcDark: MENUBAR_SELECTION_BACKGROUND, light: MENUBAR_SELECTION_BACKGROUND, hcLight: MENUBAR_SELECTION_BACKGROUND }, localize('commandCenter-activeBackground', "Active background color of the command center"),

Discussion:
Testing I believe the border contrast needs to be 3:1 between the border and bg color of the title bar. Something like might be a little closer to what we want: <img width="489" alt="CleanShot 2022-05-31 at 13 02 15 src="https://user-"<img width="520" alt="CleanShot 2022-05-31 at 13 01 04 src="https://user-"
Your suggested colors falls back to which actually aren't defined for for light/dark themes, only for HC themes... I went with variants of the foreground-color. The contrast-ratio tool in devtools seems broken... Do you mind making more directly in this branch:
Change:
return EditorExtensionsRegistry.getEditorActions(); } <del> public static getEditorOptions(): IEditorOptions { </del> <ins> public static getEditorOptions(configurationService: IConfigurationService): IEditorOptions { </ins> return { wordWrap: 'on', glyphMargin: false,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When replying to a code review comment, the reply editor unconditionally auto-closes brackets. We have had complaints from users about not affecting this behavior (when set to ). We are not 100% convinced that should apply here, since conceptually, editing comments is different from editing code, so a separate setting for comments could be more flexible, but maybe also unnecessarily complex. discusses specifying a on to control other behavior like syntax highlighting (mainly plaintext vs Markdown). Since already supports using per-language settings, it might work well enough to just make also take effect in the comment reply editor.
it seems that only applies to the main editor and not also other editors. Is this expected? I took a look and from what I can see all will respect language configurations for auto closing pairs. It's only when you try to set it something other than that it get's ignored.
I don't know much about that setting, I'd need to debug too.
do you know the answer to
To allow for most flexibility, the code editor doesn't listen to the by itself. That job is always left to the place which instantiates editors. For example, the workbench listens to the and forwards all values to the editor instaces.
Change:
return; } <del> this.outputElements.set(currOutput, outputItemDiv); </del> <ins> this.outputElements.set(currOutput, { element: outputItemDiv, renderResult: result }); </ins> if (beforeElement) { this.templateData.outputContainer?.insertBefore(outputItemDiv, beforeElement);

Discussion:
Notice the cell goes beyond the right margin. Seems to happen for all cells
is it related to the indentation change?
I don't think there's an issue here anymore? I did push a change to ensure that a line of text with no whitespace will break and not overflow. But I don't see any other issues with overflowing horizontally. I do see plain text outputs overflowing if I resize the editor to be narrower...
Change:
if (mimeType?.startsWith('image/')) { const editorService = accessor.get(IEditorService); const editor = editorService.activeEditorPane?.getControl() as INotebookEditor; <del> await editor.focusNotebookCell(outputViewModel.cellViewModel as ICellViewModel, 'output'); </del> <ins> await editor.focusNotebookCell(outputViewModel.cellViewModel as ICellViewModel, 'output', { skipReveal: true, outputId: outputViewModel.model.outputId }); </ins> editor.copyOutputImage(outputViewModel); } else { const clipboardService = accessor.get(IClipboardService);

Discussion:
follow up after a notebook cell that displays multiple images down and select 'copy output to clipboard' on the last image :bug: the first image is selected and the notebook scrolls to reveal it
Change:
return this._getCommandMarkers().length; } } <ins> registerThemingParticipant((theme: IColorTheme, collector: ICssStyleCollector) => { const focusBorderColor = theme.getColor(focusBorder); if (focusBorderColor) { collector.addRule(`.terminal-scroll-highlight { border-color: ${focusBorderColor.toString()}; } `); } }); </ins>

Discussion:
Follow up for cmd+up/down on macOS should show some indication of the line that was scrolled to. This will need some upstream changes.
testing if i have a few empty lines such as this: ! pressing appears to do nothing, so having some indication of where I am would be great.
yeah I would have liked to get this in but was a bit randomized this iteration.
Blocked on
Brought this to UX sync with a focus border outline that fades to 0 opacity over 2 seconds. But after it occurred to me that navigating the a symbol in the editor is the exact idea we're trying to get across which flashes a focus border briefly without animating. So going with that to align, we can change both if we want to tweak it: !
Using 350ms:
!
Change:
} const previousInput = this.tree.getInput(); <del> const promise = this.tree.setInput(input, viewState).then(async () => { </del> <ins> const promise = this.setTreeInputPromise = this.tree.setInput(input, viewState).then(async () => { </ins> if (Array.isArray(input)) { if (!viewState || previousInput instanceof ExplorerItem) { // There is no view state for this workspace (we transitioned from a folder workspace?), expand up to five roots.

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --For example when I open a project in v, I expand the folder on the file tree. When I refresh the whole page, the default behavior now is that the folders are collapsed, which means that I need to expand the folders one by one again the last time I opened them. !
If the expansion state of the file tree folder can remember the last expansion like tabs, similar to the gif below, I think this is a better effect. !
I have fixed this problem and will mention a pr later.
The reason for this problem is that there are multiple calls to the function during the rendering of the file tree. The state will be read from the cache for the first time, but before the execution is completed for the first time, the will be executed again. At this time, the tree already has a value. However, because the file tree data is not ready (because the data on the Web side is asynchronous), the state returned by the function is empty, resulting in the final file tree returning to the default collapsed state.
Change:
message, buttons: [ { <del> label: nls.localize({ key: 'debugAnyway', comment: ['&& denotes a mnemonic'] }, "&&Debug Anyway"), </del> <ins> label: DEBUG_ANYWAY_LABEL, </ins> run: () => DebugChoice.DebugAnyway }, {

Discussion:
Clone and npm install. Hit F5, it never starts: <img width="484" alt="image" src=""I am on macOS.
This is probably because a prelaunch task is still running / your problem matchers haven't matched anything. Please make sure you have the right problem matchers installed, otherwise I suggest opening issues for them if they don't match correctly.
Would be great if debug could give me a hint.
Will keep open to track it, it's not a rare problem
We should also keep the terminal open if the task fails, currently it closes immediately which can be confusing
Would also be nice if we could cancel the pending launch attempt, e.g. by showing the debug toolbar immediately and disabling all buttons except the stop button. Right now when I get into this state I end up just reloading the whole window and incurring the pain of all extensions reactivating, which takes several seconds on my machine (git, TS etc)
After 10 seconds we'll show !
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
@ITestingPeekOpener private readonly peekOpener: ITestingPeekOpener, @ITestProfileService private readonly testProfileService: ITestProfileService, @ITestingContinuousRunService private readonly crService: ITestingContinuousRunService, <ins> @ICommandService commandService: ICommandService, </ins> ) { super();

Discussion:
Testing microsoft/vscode-python Here: !
ideas on this? I provided the path to the file so the "Go to test..." works ( confirm if this is not the case). Thanks!
This works fine via double click but for example does not open on macOS. This works in other trees as standard gesture to open. To make this easy to adopt for trees, I think we have a convention in custom trees, not sure if they are used here. do you remember?
Yes, if you set the command of the tree item in extension provided trees to or then we do some magic and respect the arguments to those commands as outlined at and also respect things like double click and ctrl+click. Here is how we pass the click properties to those commands:
Change:
IN_COMMAND_EXECUTION="" PS1="%{$(prompt_start)%}$PREFIX$PS1%{$(prompt_end)%}" PS2="%{$(continuation_start)%}$PS2%{$(continuation_end)%}" <ins> if [ -n "$RPROMPT" ]; then PRIOR_RPROMPT="$RPROMPT" RPROMPT="%{$(right_prompt_start)%}$RPROMPT%{$(right_prompt_end)%}" fi </ins> } precmd() {

Discussion:
Setup a right prompt in fish/zsh and make sure the command detected is accurate.
zsh uses for this, perhaps we should have a generic ignored ranges mechanism and combine this with the line continuation solution?
Change:
const uriIdentityService = accessor.get(IUriIdentityService); const dialogService = accessor.get(IDialogService); <del> const context = explorerService.getContext(true); </del> <ins> const context = explorerService.getContext(false); </ins> const hasNativeFilesToPaste = fileList && fileList.length > 0; const confirmPasteNative = hasNativeFilesToPaste && configurationService.getValue<boolean>('explorer.confirmPasteNative');

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.0-insider () OS Version: Windows_NT x64 10.0. Steps to Reproduce: a directory with 2 files and a directory and , right-click, Copy -click , Paste Expected: and are pasted in Actual: and are pasted in
This issue has existed for a while and it's bitten me a few times. I found in order for copy/paste to work as expected the destination folder must first be selected before right-click.
Change:
super({ id: 'workbench.action.increaseViewSize', title: { value: localize('increaseViewSize', "Increase Current View Size"), original: 'Increase Current View Size' }, <del> f1: true </del> <ins> f1: true, precondition: IsAuxiliaryWindowFocusedContext.toNegated() </ins> }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 x64 OS Version: Steps to Reproduce: a new floating window with (or any of the other ones) a few split editors in the main view and the floating view a split in floating window the floating view, execute floating window editor size doesn't change, it happens in the main one
Good catch, these commands should not be available in floating windows.
Change:
const renderedMarkdown = renderMarkdown(response.raw.message, { inline: true }); this._zone.value.widget.updateStatus(''); this._zone.value.widget.updateMarkdownMessage(renderedMarkdown.element); <del> this._zone.value.widget.updateToolbar(true); </del> const content = renderedMarkdown.element.textContent; if (content) { status = localize('markdownResponseMessage', "{0}", content);

Discussion:
generate an answer tweak it press Send again (by accident) press Stop generating the Accept button is no longer visible !
Change:
}); } <del> public resolveCompletionItem(item: CompletionItem, token: CancellationToken): any | Thenable<any> { </del> <ins> public resolveCompletionItem(item: CompletionItem, token: CancellationToken): ProviderResult<CompletionItem> { </ins> if (item instanceof MyCompletionItem) { const filepath = this.client.asAbsolutePath(item.document.uri); if (!filepath) {

Discussion:
VSCode Version: Code - Insiders 1.8.0-insider (, 2016-12-07T07:05:09.124Z) OS Version: Darwin x64 16.1.0 Steps to Reproduce: ! Enter !
That's a really annoying bug! Not just in .
The TypeScript extension tells the editor to only delete the 2 preceding characters, not the entire word. That might be a problem with the work definition you are using. !
I have extrapolated about snippets to the following piece of code
I think that Typescript needs to be explicit in this case, and provide a range for the completion items. We currently automatically pick up the range from
do you know if this is tracked on TS's side? I want to make sure I have it tracked in the OneNote table appropriately.
I don't think this is an issue on the TypeScript side. The bug was that we were relying on the default VSCode logic for determining what word to replace, and it breaks words that contain or any other non letter or digit characters. The result TypeScript provides to us is correct as far as I know
Change:
templateDisposables.add(scopedInstaService.createInstance(CellEditorStatusBar, this.notebookEditor, container, editorPart, undefined)), templateDisposables.add(new CellFocusIndicator(this.notebookEditor, titleToolbar, focusIndicatorTop, focusIndicatorLeft, focusIndicatorRight, focusIndicatorBottom)), templateDisposables.add(new FoldedCellHint(this.notebookEditor, DOM.append(container, $('.notebook-folded-hint')), this._notebookExecutionStateService)), <del> templateDisposables.add(new CellDecorations(rootContainer, decorationContainer)), </del> <ins> templateDisposables.add(new CellDecorations(this.notebookEditor, rootContainer, decorationContainer)), </ins> templateDisposables.add(scopedInstaService.createInstance(CellComments, this.notebookEditor, cellCommentPartContainer)), templateDisposables.add(new CollapsedCellInput(this.notebookEditor, cellInputCollapsedContainer)), templateDisposables.add(new CellFocusPart(container, undefined, this.notebookEditor)),

Discussion:
Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width="981" alt="image" src=""I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width="980" alt="image" src=""It appears that the Code cells lost their yellow highlight.
Change:
selectedCategory: string | undefined; selectedStep: string | undefined; showTelemetryNotice: boolean; <ins> showWelcome: boolean; </ins> }

Discussion:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.
Change:
return this.removeDuplicateRequests(requests, false /* validate paths skipped for tests */).map(request => request.path); } <ins> protected override getUpdateWatchersDelay(): number { return 0; } </ins> protected override async doWatch(requests: IRecursiveWatchRequest[]): Promise<void> { await super.doWatch(requests); await this.whenReady();

Discussion:
With TS 5.5 we are seeing a lot more requests to watch paths such as which in the end makes the file watcher consume 100% CPU for at least a minute on my machine. Need to understand why this is so slow on startup, probably some complexity somewhere trying to handle these requests.
Change:
} private filterResourceMarkers(resourceMarkers: ResourceMarkers): TreeFilterResult<FilterData> { <del> if (resourceMarkers.resource.scheme === network.Schemas.walkThrough || resourceMarkers.resource.scheme === network.Schemas.walkThroughSnippet || resourceMarkers.resource.scheme === network.Schemas.vscodeSourceControl) { </del> <ins> if (unsupportedSchemas.has(resourceMarkers.resource.scheme)) { </ins> return false; }

Discussion:
Testing <img width="1617" alt="image" src="https://user-"
I can't get squiggles to show up for the commit input box at all, even after following the steps from the linked TPI. What are some steps to verify this, or maybe someone else can verify?
Thanks Reopening the bug as the fix for this has introduced a regression.
Checked in a better fix for this issue. Should be included in tomorrow's Insiders release (2022-08-26).
closedWith
Verified, but the actions in the hover don't do anything: !
Thanks I have filed to track the issue with the actions.
Change:
{ kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move'), icon: Codicon.wrench }, <del> { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With'), icon: Codicon.symbolSnippet }, </del> <ins> { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With'), icon: Codicon.surroundWith }, </ins> { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action'), icon: Codicon.symbolFile }, uncategorizedCodeActionGroup, ]);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The "Surround with...." in the labels are redundant and by removing them, clears up clutter in the action widget, and lets users navigate to specific labels by typing in fewer keys (ie, would go to, will go to ) !
Change:
if (!model) { return; } <ins> const containsOnlyWhitespace = this.rangeContainsOnlyWhitespaceCharacters(model, range); if (containsOnlyWhitespace) { return; } </ins> if (isStartOrEndInString(model, range)) { return; }

Discussion:
create a TS file make sure the file is configured to insert Tabs (from the status bar) place a character in your clipboard paste it at the beginning of the file :bug: observe nothing happens
This seems related to Auto indent. Setting fixes the issue
After investigating, this seems to happen because after pasting a new line character, the code becomes as follows: The method of the is called and it performs automatic re-indentation. In your case, since there is nothing above that line, the indentation level on that line is zero. The inserted indentation is then removed. It is possible to see this in more detail in the following example: I believe this behavior makes sense when the pasted text contains characters other than whitespace characters. Perhaps what I could do is to not trigger the re-indentation when only whitespace characters are pasted. This could be considered then as intended indentation adjustment.