jiebi/CodeConvo huggingface dataset:
Change:
let testSubmenus: IAction[] = testItems.map(({ currentLabel, testItem }) => { const actions = this.getTestContextMenuActions(testItem.test, testItem.resultItem); disposable.add(actions); <del> return new SubmenuAction(testItem.test.item.extId, stripIcons(currentLabel), actions.object); </del> <ins> let label = stripIcons(currentLabel); const lf = label.indexOf('n'); if (lf !== -1) { label = label.slice(0, lf); } return new SubmenuAction(testItem.test.item.extId, label, actions.object); </ins> });

Discussion:
Type: <bBug</bObserved on SCM view: ! VS Code version: Code - Insiders 1.89.0-insider (, 2024-04-05T05:52:23.778Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (52)</summaryExtensionVersion ------ Bookmarks13.5.0 tsl-problem-matcher0.6.2 open-in-github-button0.1.1 vscode-opennewinstance0.0.12 vscode-eslint2.4.4 githistory0.6.20 prettier-vscode10.4.0 vscode-open-in-github2.2.1 intersystems-dxjetpack0.1.2 searchable-debug-console0.0.2 thefoldingstuff0.2.1 codespaces1.16.18 copilot1.178.0 copilot-chat0.15.

vscode-github-actions0.26.2 vscode-pull-request-github0.86.0 vscode-memfs0.0.3- vscode-favorites1.11.0 rest-client0.25.1 vscode-pr-pinger0.0.6 workspace-storage-cleanup1.1.5 vscode-docker1.29.0 debugpy2024.4.0 python2024.4.0 vscode-pylance2024.4.1 jupyter2024.3.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.9 vscode-jupyter-powertoys0.1.1 vscode-jupyter-slideshow0.1.6 remote-containers0.354.0 remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-wsl0.88.0 azure-account0.11.6 extension-test-runner0.0.9 hexeditor1.9.14 live-server0.4.13 remote-explorer0.4.3 remote-server1.5.1 vscode-github-issue-notebooks0.0.130 vscode-js-profile-flame1.0.9 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.8.0 material-icon-theme4.34.0 material-product-icons1.7.0 vscode-thunder-client2.20.3 vscode-xml0.26.1 rest-book6.2.1 luna-paint0.16.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
I used Culprit is by
Change:
}, f1: true, precondition: ctxIsMergeEditor, <del> menu: [ { id: MenuId.MergeInput2Toolbar, } ] </del> <ins> menu: { id: MenuId.MergeInput2Toolbar, group: 'primary' }, icon: Codicon.checkAll, </ins> }); }

Discussion:
! I personally find it a bit strange to have no primary action and only secondary actions hidden behind "...". What is the rationale? //cc
We are looking at pulling these out as primary actions like so. See . <img width="1015" alt="CleanShot 2022-10-03 at 09 11 23 src="https://user-"
!
!
Change:
if (distroOutput) { const regex = new RegExp(/[r?n]/); const distroNames = distroOutput.split(regex).filter(t => t.trim().length > 0 && t !== ''); <del> // don't need the Windows Subsystem for Linux Distributions header distroNames.shift(); </del> for (let distroName of distroNames) { <del> // Remove default from distro name distroName = distroName.replace(/ (Default)$/, ''); </del> // Skip empty lines if (distroName === '') { continue;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.0 OS Version: Windows 10 Home 20H2 .867 Steps to Reproduce: run latest version of VS Code, 1.55.0 the list of default WSL profiles and you will find something like "Ubuntu (predet.)" instead of just "Ubuntu". profile is impossible to launch, because there is NO distro named "Ubuntu (predet.)". This happens because , at line 178 of latest snapshot I'm checking, does this: . It should remove other locales, too. I know this is difficult to do because... well, there's plenty of locales. So, in order to get the distribution name, another way should be used. I think it's safe to remove any last element within parentheses from the distro name as returned by , but really another method is available which I think it's safer, but I'm not sure how to write it in TypeScript. I have the following code already written in Python, for a system maintenance script I use in my own system, where I retrieve the installed distribution names from the registry: It's a partial code but well, I think it's self explanatory, and I can provide further information if needed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Same happens to me with the new version 1.55.0 One temporal solution that I found is to disable the autodetection of the distros and include each one with the profile setting:
hi, at first glance it looks that adding a -q argument to the 'wsl -l' command would be safe... regards
Thanks for the suggestion and the fix.

Still, I'll keep an eye on this, just in case Microsoft decides to change command line interface. But so far, so good, and it's simpler than having to read the registry
Just encountered this issue today (after updating Docker for Desktop, but not sure if this has something to do with the issue).
Verified in
Change:
fastScrollModifier: 'alt', fastScrollSensitivity: editorOptions.fastScrollSensitivity, scrollSensitivity: editorOptions.mouseWheelScrollSensitivity, <del> rendererType: (config.rendererType === 'auto' || config.rendererType === 'experimentalWebgl') ? 'canvas' : config.rendererType, </del> <ins> rendererType: xtermRendererType, </ins> wordSeparator: config.wordSeparators }); this._xterm = xterm;

Discussion:
Part of We should also improve the fallback logic to do this: Try webgl If it threw an exception, try canvas If frame rendering averages 50ms (existing detection), use DOM We will keep the canvas renderer around for now mainly because Safari doesn't support webgl2 and can evaluate again at a later date.
It looks like canvas is still the default for me -- the is present unless I explicitly enable experimentalWebgl. I don't see any notifications of errors that could be causing it.
Change:
registry.registerWorkbenchAction(new SyncActionDescriptor(OpenSettings2Action, OpenSettings2Action.ID, OpenSettings2Action.LABEL), 'Preferences: Open Settings (Preview)', category); registry.registerWorkbenchAction(new SyncActionDescriptor(OpenGlobalSettingsAction, OpenGlobalSettingsAction.ID, OpenGlobalSettingsAction.LABEL), 'Preferences: Open User Settings', category); registry.registerWorkbenchAction(new SyncActionDescriptor(OpenGlobalKeybindingsAction, OpenGlobalKeybindingsAction.ID, OpenGlobalKeybindingsAction.LABEL, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyMod.CtrlCmd | KeyCode.KEY_S) }), 'Preferences: Open Keyboard Shortcuts', category); <ins> registry.registerWorkbenchAction(new SyncActionDescriptor(OpenRawDefaultKeybindingsAction, OpenRawDefaultKeybindingsAction.ID, OpenRawDefaultKeybindingsAction.LABEL), 'Preferences: Open Raw Default Settings', category); </ins> registry.registerWorkbenchAction(new SyncActionDescriptor(OpenGlobalKeybindingsFileAction, OpenGlobalKeybindingsFileAction.ID, OpenGlobalKeybindingsFileAction.LABEL, { primary: null }), 'Preferences: Open Keyboard Shortcuts File', category); registry.registerWorkbenchAction(new SyncActionDescriptor(ConfigureLanguageBasedSettingsAction, ConfigureLanguageBasedSettingsAction.ID, ConfigureLanguageBasedSettingsAction.LABEL), 'Preferences: Configure Language Specific Settings...', category);

Discussion:
New Setting: New Action: Currently, allows users to disable the side-by-side default/user settings view, instead allowing us to view our customized settings file in isolation when using the command. A corresponding option does not yet exist for , although it would be equally useful. Additionally, something like contribution in should be implemented to allow access of the default keybindings if is disabled.
I'd like to take solve this issue. any suggestions? What files will I have to work with for this? This would be my first contribution to VSCode!
References: for Opening raw default for not opening default settings
Hey guys, I got some work around for showing user settings in (GUI) (yet not pushed in my PR), but I had a question. If we set : and open (GUI), it should show only user keybinding settings. But then how should we handle and actions in menu (3 dot at right corner)?
The filtering effects of & seem to be isolated to the UI, so I would expect them to retain their existing functionality. The proposed changes are intended to affect .
Change:
super(); this._register(AccessibilityHelpAction.addImplementation(105, 'panelChat', async accessor => { const codeEditor = accessor.get(ICodeEditorService).getActiveCodeEditor() || accessor.get(ICodeEditorService).getFocusedCodeEditor(); <del> if (!codeEditor) { return; } runAccessibilityHelpAction(accessor, codeEditor, 'panelChat'); }, CONTEXT_IN_CHAT_SESSION)); </del> <ins> runAccessibilityHelpAction(accessor, codeEditor ?? undefined, 'panelChat'); }, ContextKeyExpr.or(CONTEXT_IN_CHAT_SESSION, CONTEXT_RESPONSE, CONTEXT_REQUEST))); </ins> } }

Discussion:
Refs: chat view. Ask some things keyboard focus on the request item (what you typed) -nothing happens This is inconsistent with the behaviour when the focus is on the response. Megan informed me that this behaviour is by design, but I do not see understand what is the benefit of this behaviour. What are we getting with this inconsistency?
cc and for feedback. The thought here was a user has typed the request - thus knows what it says generally and doesn't need to carefully inspect it. Also, the request is typically concise. Open to adding support for this though - we'd have to consider if we want the and to cycle through each list item. IMO, it would be a bit annoying to have to go through one's requests like this.
I discussed this with JooYoung and he agreed we should not do this unless it's requested
Change:
function loadCode(moduleId: string): Promise<SimpleWorkerModule> { // ESM-uncomment-begin <ins> // if (typeof loadAMDLoader === 'function') { /* fixes unused import, remove me */} </ins> // const moduleUrl = new URL(`${moduleId}.js`, globalThis._VSCODE_FILE_ROOT); // return import(moduleUrl.href); // ESM-uncomment-end

Discussion:
We lost changes that where ESM relevant. I am trying to fix it in our ESM branch, maybe backport it from there: The old code also had this line, which I am not sure is needed: cc
Sorry about that. Is this for Monaco or the esm work? I'd love to get a point where we can just have this as a normal dependency instead of copying it into our sources. Marked now publishes both a commonjs and esm builds too. Is there some way VS Code could use Marked as a normal dependency in a way that would also work for Monaco? If I recall we've tried to avoid adding real dependencies to Monaco
I only noticed for our work, not sure about Monaco ESM. Would be great to get it working again on .
I think the ESM work will unblock this. esbuild will be able to bring in and include node modules into our bundle, the AMD bundler we currently use can only bundle AMD modules and not commonjs modules.
I would have hoped that the Monaco Editor checks would have caught this. Is there something we should improve there?
For monaco-editor-core, these are the only tests: It does not test markdown features.
Change:
} public updateManifest(manifest: IExtensionManifest) { <del> if (!Array.isArray(manifest.activationEvents) || !manifest.contributes) { </del> <ins> if (typeof manifest.main === 'undefined' && typeof manifest.browser === 'undefined') { </ins> return; } <del> if (typeof manifest.main === 'undefined' && typeof manifest.browser === 'undefined') { </del> <ins> if (manifest.activationEvents === undefined) { Object.assign(manifest, { activationEvents: [] }); } if (!Array.isArray(manifest.activationEvents) || !manifest.contributes) { </ins> return; }

Discussion:
Testing Clone Open in the latest VS Code Insiders Press F5 to start the extension, and confirm that the "Hello World" command is in the command palette, and the extension gets activated when the command is being invoked. Stop debugging Open and remove the property altogether Press F5 to start the extension The "Hello World" command does not appear in the command palette Is this expected? Adding the back seems to resolve the problem.
Change:
} if (isPrimaryGroup(group)) { <del> const to = Array.isArray<IAction>(target) ? target : target.primary; </del> <ins> const to = Array.isArray(target) ? target : target.primary; </ins> to.unshift(...actions); } else { <del> const to = Array.isArray<IAction>(target) ? target : target.secondary; </del> <ins> const to = Array.isArray(target) ? target : target.secondary; </ins> if (to.length > 0) { to.push(new Separator());

Discussion:
What is the reasoning behind not allowing via the Monaco standalone editor checks? It seems to be valid ES6 when I look at where it is defined:
idk - requires at least edge 14, unsure what our edge minimum version is:
Looking at the compat tables, I think it should be safe to use it. I guess it must have been a left-over from the IE era. I don't remember adding any rule like this, so I don't know where to begin looking to remove it. Leaving it to you .
I opened to do this and it has the advantage that we can get rid of another file in our folder () which actually even seems to have the wrong signature compared to TS. According to , Edge 13 has very low usages and Edge 14 is out since 2016: !
Unsure how and are connected. Or is this two clean-ups in one? I have the latter because for the longest time there was a TS bug which would remove type info from arrays after checking E.g If that's now fixed, I am very happy with removing
ah good to know, I just checked both in our code and the playground and I see that this no longer seems to be the case: ! I will go ahead and merge my PR then.
it
Change:
const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ sync: boolean }>('showActionButton', { sync: true }); <del> // Branch does not have an upstream or the button is disabled if (!this.state.HEAD?.upstream || !showActionButton.sync) { return undefined; } </del> <ins> // Branch does not have an upstream, commit is in progress, or the button is disabled if (!this.state.HEAD?.upstream || this.state.isCommitInProgress || !showActionButton.sync) { return undefined; } </ins> const ahead = this.state.HEAD.ahead ? ` ${this.state.HEAD.ahead}$(arrow-up)` : ''; const behind = this.state.HEAD.behind ? ` ${this.state.HEAD.behind}$(arrow-down)` : ''; <del> const icon = this.state.isActionRunning ? '$(sync~spin)' : '$(sync)'; </del> <ins> const icon = this.state.isSyncInProgress ? '$(sync~spin)' : '$(sync)'; </ins> const rebaseWhenSync = config.get<string>('rebaseWhenSync');

Discussion:
Create a commit. While the commit runs, the sync button spins as if it's syncing . The one in the statusbar does not. !
Change:
const notebook = context.notebookEditor.textModel.uri; const executingCells = notebookExecutionStateService.getCellExecutionsForNotebook(notebook); if (executingCells[0]) { <del> const cell = context.notebookEditor.getCellByHandle(executingCells[0].cellHandle); </del> <ins> const topStackFrameCell = this.findCellAtTopFrame(accessor, notebook); const focusHandle = topStackFrameCell ?? executingCells[0].cellHandle; const cell = context.notebookEditor.getCellByHandle(focusHandle); </ins> if (cell) { context.notebookEditor.focusNotebookCell(cell, 'container'); } } } <ins> private findCellAtTopFrame(accessor: ServicesAccessor, notebook: URI): number | undefined { const debugService = accessor.get(IDebugService); for (const session of debugService.getModel().getSessions()) { for (const thread of session.getAllThreads()) { const sf = thread.getTopStackFrame(); if (sf) { const parsed = CellUri.parse(sf.source.uri); if (parsed && parsed.notebook.toString() === notebook.toString()) { return parsed.handle; } } } } return undefined; } </ins> }); registerAction2(class RevealLastFailedCellAction extends NotebookAction {

Discussion:
It's easy to lose track of the debugged cell in notebooks, especially when you've stepped into a cell which is different from the cell that is "running". Some improvements we could make: The "Go To" button should go to the cell at the top of the callstack, not the cell where the user clicked Run We should show overview ruler decorations for the top stackframe, as in the editor And overview ruler decorations for the currently running cell And for breakpoints (behind a setting, ) cc
To verify, just try everything listed at the top. For I mean, have two cells, like and a second cell that calls . Set a breakpoint in the function definition, click run on the second cell, and make sure "Go To" goes to that first cell where the instruction pointer is.
Change:
"name": "Markup Setext Header", "scope": "markup.heading.setext", "settings": { <del> "fontStyle": "", </del> <ins> "foreground": "#A6E22E", "fontStyle": "bold" } }, { "name": "Markup Headings", "scope": "markup.heading.markdown", "settings": { "fontStyle": "bold" } }, { "name": "Markdown Quote", "scope": "markup.quote.markdown", "settings": { "fontStyle": "italic", "foreground": "#75715E" } }, { "name": "Markdown Bold", "scope": "markup.bold.markdown", "settings": { "fontStyle": "bold" } }, { "name": "Markdown Link Title/Description", "scope": "string.other.link.title.markdown,string.other.link.description.markdown", "settings": { "foreground": "#AE81FF" } }, { "name": "Markdown Underline Link/Image", "scope": "markup.underline.link.markdown,markup.underline.link.image.markdown", "settings": { "foreground": "#E6DB74" } }, { "name": "Markdown Emphasis", "scope": "markup.italic.markdown", "settings": { "fontStyle": "italic" } }, { "name": "Markdown Punctuation Definition Link", "scope": "markup.list.unnumbered.markdown, markup.list.numbered.markdown", "settings": { "foreground": "#f8f8f2" } }, { "name": "Markdown List Punctuation", "scope": [ "punctuation.definition.list.begin.markdown" ], "settings": { </ins> "foreground": "#A6E22E" } },

Discussion:
Markdown rendering in bundled Monokai has following flaws: links in lists don't are not properly coloured headings are not bold quotes are not rendered in italic bold text is not rendered as bold italic text is not rendered in italic font !
Please share the text of the code along with screenshots
Sure! Maybe VS Code team has a more thorough test file for markdown file. Anyway, that's the one I've used for testing. One morning, when Gregor Samsa woke from troubled dreams, he himself transformed in his bed into a horrible vermin. He lay on his armour-like back, and if he lifted his head a little he could see his brown belly, slightly domed and divided by arches into stiff sections. bold bold italic italic ! list list horizontal rule [1]: "Example"
Change:
//#endregion <del> //#region Terminal initial text https://github.com/microsoft/vscode/issues/120368 export interface TerminalOptions { /** * A message to write to the terminal on first launch, note that this is not sent to the * process but, rather written directly to the terminal. This supports escape sequences such * a setting text style. */ readonly message?: string; } //#endregion </del> //#region Terminal icon https://github.com/microsoft/vscode/issues/120538 export interface TerminalOptions {

Discussion:
Proposal: Example use case: GitLens running a git command and when it fails, create a new terminal which includes the error message in the header and the failed command ready to be run manually. This is generally useful for other applications (eg. welcome to the blah debug terminal, this is how it works, ...) cc
<img width="725" alt="Screen Shot 2021-04-01 at 12 25 57 PM" src="https://user-"
This is in main, very little to do since was already an option internally. Will bring this to next API sync.
alternative names: message, placeholder, placeHolder
Will probably go with to match .
Proposed API TPI:
Code: Result: <img width="398" alt="Screen Shot 2021-05-04 at 6 36 08 AM" src="https://user-"
Change:
"@types/webdriverio": "4.6.1", "concurrently": "^3.5.1", "cpx": "^1.5.0", <del> "electron": "4.2.9", </del> <ins> "electron": "4.2.10", </ins> "htmlparser2": "^3.9.2", "mkdirp": "^0.5.1", "mocha": "^5.2.0",

Discussion:
Issue Type: <bBug</bThe first Mac native tab has its top row cut off: ! The second one has the statusbar below the visible window: ! Resizing the window is a workaround. VS Code version: Code - Insiders 1.38.0-insider (, 2019-08-15T05:23:00.986Z) OS version: Darwin x64 18.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ unique-lines1.0.0 ssh0.0.4 ghlink1.1.0 remotehub0.5.0 EditorConfig0.13.0 tslint1.0.44 git-project-manager1.7.1 rest-client0.22.0 solidity0.0.58 theme-karyfoundation-themes18.2.1 graphql-for-vscode1.15.1 vscode-docker0.7.0 remote-containers0.67.4 remote-ssh-edit-nightly2019.8. remote-ssh-explorer-nightly2019.8. remote-ssh-nightly2019.8. azure-account0.8.4 azurecli0.4.6 github-issues-prs0.9.1 debugger-for-chrome4.11.7 vetur0.22.1 vscode-versionlens0.24.0 vscode-yaml0.4.1 vscode-workspacecontains-canary0.0.2 vscode-open-in-github1.12.0 ayu0.18.0 vscodeintellicode1.1.9 </details<!-- generated by issue reporter --
does this reproduce when you disable grid layout?
Yes, it's the same with grid layout disabled.
I cannot reproduce using Electron 4.2.7
!
Fix is up at , should be available with next electron release.
we will take the new build and will push it via a PR.
Change:
const inserted = outputElement.firstChild as HTMLElement; assert.ok(inserted, `nothing appended to output element: ${outputElement.innerHTML}`); assert.ok(outputElement.classList.contains('remove-padding'), `Padding should be removed for non-scrollable outputs: ${outputElement.classList}`); <del> assert.ok(!inserted.classList.contains('word-wrap') && !inserted.classList.contains('scrollable'), </del> <ins> assert.ok(!outputElement.classList.contains('word-wrap') && !inserted.classList.contains('scrollable'), </ins> `output content classList should not contain word-wrap and scrollable ${inserted.classList}`); assert.ok(inserted.innerHTML.indexOf('>content</') > -1, `Content was not added to output element: ${outputElement.innerHTML}`); });

Discussion:
[ ] Notebooks (.ipynb files) [X] Interactive Window and/or Cell Scripts (.py files with #%% markers)Turn on in Turn on in Open an interactive window and run the following code snippet Version: 1.89.0 Commit: Date: 2024-05-01T02:08:25.066Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Linux x64 6.8.0-76060800daily20240311-generic v2024.4.0 Python v3.12.1 No response No response Local
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.47", </del> <ins> "xterm": "4.19.0-beta.49", </ins> "xterm-addon-search": "0.9.0-beta.37", "xterm-addon-serialize": "0.7.0-beta.12", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.36", <del> "xterm-headless": "4.19.0-beta.47", </del> <ins> "xterm-headless": "4.19.0-beta.49", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Theme pictured is Sapphire. ! Possibly related to Code pointer
Blending colors in vscode yields rgba format, so we should add that support to !
issue
Repro for this is to set the following settings and try find in terminal:

Started seeing this yesterday: !
This seems to be related to my theme, probably same root cause as
Repro for this is to set the following settings and try find in terminal: