jiebi/CodeConvo huggingface dataset:
Change:
const application = await this.reloadApplicationConfiguration(true); const { local, remote } = await this.reloadUserConfiguration(); await this.reloadWorkspaceConfiguration(); <del> await this.loadConfiguration(application, local, remote); </del> <ins> await this.loadConfiguration(application, local, remote, true); </ins> return; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Windows 11 x64 Steps to Reproduce: an extension that implements a FileSystemProvider and serves a file containing a setting. a workspace that uses this FSP. that the setting has no effect until the workspace is reloaded. I will prepare a branch of fsprovider-sample to demonstrate the issue.
Repro steps: project () and VSIX (). an empty profile and install the VSIX into it. no folder or workspace open, run . Explorer find and open that though this specifies a font size of 24 it is displayed in the default font size. and observe that the font size is now correct. !
/assign I will submit a PR to fix this.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
this.refreshTOCTree(); this.renderResultCountMessages(); this.refreshTree(); <del> } else { </del> <ins> } else if (!this.tocTreeDisposed) { </ins> // Leaving search mode this.tocTree.collapseAll(); this.refreshTOCTree();

Discussion:
Found this in devtools, I played a bit with settings: <img width="1904" alt="image" src="https://user-"
Let me know if you can repro and find out the issue is deep in the list/tree.
Got you repro steps! the workbench window rather small. into 2x2 editor layout, so you get even smaller editors <kbdCmd ,</kbdto open the Settings Editor in one of the editor groups for <kbdCmd W</kbdto close the Settings Editor That exception shows up!
I just closed two other duplicates of this. There are repro steps since June. Let's see if we can drive this to a fix. Let me know if you believe it's deep down in the list/tree.
Change:
args.push('--'); if (paths && paths.length) { <del> args.push.apply(args, paths.map(sanitizePath)); </del> <ins> for (const chunk of splitInChunks(paths, MAX_CLI_LENGTH)) { await this.run([...args, ...chunk]); } </ins> } else { args.push('.'); <ins> await this.run(args); </ins> } <del> await this.run(args); </del> } async rm(paths: string[]): Promise<void> {

Discussion:
Issue Type: <bBug</ba repo with a large amount of changed files in one folder and use the tree view <kbd+</kbdnext to the folder to stage the changes or <kbd-</kbdto unstage them. : ! This was supposedly fixed in for the discard command but either the other commands or the tree view was forgotten as a potential source of problems. Clicking the button next to "changes" works fine: ! VS Code version: Code 1.40.0 (, 2019-11-06T17:02:13.381Z) OS version: WindowsNT x64 6.1.7601 <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-eslint1.9.1 gitlens10.1.2 toggle-excluded-files1.7.0 EditorConfig0.14.2 RunOnSave0.2.0 prettier-vscode3.3.5 vscode-test-explorer2.14.6 rest-client0.22.2 vscode-docker0.8.2 vscode-language-pack-de1.40.2 vscode-jest3.0.2 project-snippets0.5.0 java0.52.0 vscode-coverage-gutters2.4.2 vscode-icons9.5.0 vscode-todo-highlight1.0.4 </details<!-- generated by issue reporter --
Yup, the same fix as needs to be applied to the stage action.
+1 Same issue here in the latest vs code and latest git Windows 10 home: v10.0. VS Code: 1.44.2 Git version: 2.26.2.windows.1
Change:
} protected renderBody(container: HTMLElement): void { <del> this.viewWelcomeController = this._register(new ViewWelcomeController(container, this, this.instantiationService, this.openerService, this.telemetryService, this.contextKeyService)); </del> <ins> this.viewWelcomeController = this._register(this.instantiationService.createInstance(ViewWelcomeController, container, this)); </ins> } protected layoutBody(height: number, width: number): void {

Discussion:
Reloading a window seems to reset the view state, I think thats not really needed, but not sure how this is triggered? !
This is from here: Arguably that listener should not run when we dispose the workbench, but maybe we cannot address this, will see.
Change:
const fontFamily = this.getInputEditorFontFamily(); const fontSize = this.getInputEditorFontSize(); const lineHeight = this.computeLineHeight(fontSize); <ins> // We respect the configured `editor.accessibilitySupport` setting to be able to have wrapping // even when a screen reader is attached. const accessibilitySupport = this.configurationService.getValue<'auto' | 'off' | 'on'>('editor.accessibilitySupport'); </ins> this.setPlaceholderFontStyles(fontFamily, fontSize, lineHeight);

Discussion:
todays insiders type a long commit message the message doesn't wrap but horizontal scrolling happens <img width="441" alt="Screen Shot 2022-02-11 at 14 59 56" src="https://user-"
Similar report in with 1.64 but a restart fixed it for that user.
I am unable to repro this on Mac. could you please ping me if you still have a repro so that I can take a look?
Looks like view-lines is growing as I type <img width="1187" alt="Screen Shot 2022-02-23 at 18 28 05" src="https://user-"Debugging into this editor instance shows that word wrap () is still <img width="734" alt="Screen Shot 2022-02-23 at 18 29 36" src="https://user-"
After looking at the code which computes the effective wrapping column, I noticed that having a screen reader or forcing accessibility support on can trump the option. So, this reproduces using . See also
Noting I had the same issue, but had . I don't remember changing that, so I wonder if it was set from a prompt . About a month ago, I remember toggling some accessibility features in macOS and seeing some notifications in vscode about this. Anyway, I resolved the issue as by setting the value for to and did a Reload Window to resolve this issue. wasn't an issue since changing back to retained the expected wrapping behavior. Thought it was worth noting here because it seems something else may also cause the unexpected behavior, but that setting alone fixes the issue (with a reload).
I found why still showed the problem for me. Whenever some accessibility settings are enabled in macOS, SCM doesn't wrap lines regardless of the setting. Reloading the window only fixes the issue temporarily: focusing on another app and switching back stops line wrapping again. Example:  Not sure where the best place to mention this is (maybe ). This seems like a bug where still uses the system's accessibility settings to determine if line wrapping is enabled. Also, I would think "auto" would change when settings like "Voice Over" or "Voice Control" are turned on but not change for "Zoom".
You're right! The tiny editor powering the SCM input box does not "receive" the settings configured in user settings, so configuring only helps with the large, regular code editors.
Change:
import { normalizeDriveLetter } from 'vs/base/common/labels'; import { URI } from 'vs/base/common/uri'; import { OvertypingCapturer } from 'vs/editor/contrib/suggest/suggestOvertypingCapturer'; <ins> import { generateUuid } from 'vs/base/common/uuid'; </ins> export const KnownSnippetVariableNames: { [key: string]: true } = Object.freeze({ 'CURRENT_YEAR': true,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Vscode snippets support - e.g. variables related to filepaths, timestamps etc. Could you please add a new variable called something like that will auto-generate a version 4 UUID? (random) e.g. When executing the snippet, the placeholder would be replaced with a value like:
, that's a wrap! Now put it on the backlog, and in the software :D
could the generateUuid function be used with a snippet variable? I don't know how different the uuid and uuidv4 are, or if that matters here. I can submit a PR if that function works, or if you have any input on how to go about this.
Yeah, that function should be OK to be used
To verify make sure that you can have a snippet like this:
Change:
document: TextDocument; position: Position; <del> constructor(entry: CompletionEntry) { </del> <ins> constructor(position: Position, document: TextDocument, entry: CompletionEntry) { </ins> super(entry.name); this.sortText = entry.sortText; this.kind = MyCompletionItem.convertKind(entry.kind); <ins> this.position = position; this.document = document; </ins> if (entry.replacementSpan) { let span: protocol.TextSpan = entry.replacementSpan; // The indexing for the range returned by the server uses 1-based indexing. // We convert to 0-based indexing. this.textEdit = TextEdit.replace(new Range(span.start.line - 1, span.start.offset - 1, span.end.line - 1, span.end.offset - 1), entry.name); <ins> } else { const text = document.getText(new Range(position.line, Math.max(0, position.character - entry.name.length), position.line, position.character)); for (let i = entry.name.length; i >= 0; --i) { if ((text as any).endsWith(entry.name.substr(0, i))) { this.range = new Range(position.line, Math.max(0, position.character - i), position.line, position.character); break; } } </ins> } }

Discussion:
VSCode Version: Code - Insiders 1.8.0-insider (, 2016-12-07T07:05:09.124Z) OS Version: Darwin x64 16.1.0 Steps to Reproduce: ! Enter !
That's a really annoying bug! Not just in .
The TypeScript extension tells the editor to only delete the 2 preceding characters, not the entire word. That might be a problem with the work definition you are using. !
I have extrapolated about snippets to the following piece of code
I think that Typescript needs to be explicit in this case, and provide a range for the completion items. We currently automatically pick up the range from
do you know if this is tracked on TS's side? I want to make sure I have it tracked in the OneNote table appropriately.
I don't think this is an issue on the TypeScript side. The bug was that we were relying on the default VSCode logic for determining what word to replace, and it breaks words that contain or any other non letter or digit characters. The result TypeScript provides to us is correct as far as I know
Change:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { ILogService } from 'vs/platform/log/common/log'; <del> import { Registry } from 'vs/platform/registry/common/platform'; import { IWorkbenchContribution, IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions, WorkbenchPhase, registerWorkbenchContribution2 } from 'vs/workbench/common/contributions'; </del> <ins> import { IWorkbenchContribution, WorkbenchPhase, registerWorkbenchContribution2 } from 'vs/workbench/common/contributions'; </ins> import { CENTER_ACTIVE_CELL } from 'vs/workbench/contrib/notebook/browser/contrib/navigation/arrow'; import { SELECT_KERNEL_ID } from 'vs/workbench/contrib/notebook/browser/controller/coreActions'; import { SELECT_NOTEBOOK_INDENTATION_ID } from 'vs/workbench/contrib/notebook/browser/controller/editActions';

Discussion:
This is a missing adoption when notebooks became floating window capable. Notice how the status bar entry appears in the main window and not the floating window: ! We have had a similar issue with the text editor status bar and solved it by instantiating it per-window: I think a similar approach would work for notebooks too. The key for this to work is that you get a scoped in the that allows you to listen only to editor change events in the respective window. Consequently, you use a main-window scoped editor service for the main-window status bar: Let me know if you have questions, but I think its easy to copy what we do for editor status here.
When I reload the window with a floating notebook, the status bar does not appear (macOS): !
This is my attempt to fix this issue The problem here is if we register the contrib , we won't get the event. The event is the only place where we get the window's unique instantiationService (which gives us the right statusbarservice). Without the right statusbarservice, we can't register notebook status bar items to the right place.
Not very happy about that, filed
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
super({ id: 'workbench.action.decreaseViewHeight', title: { value: localize('decreaseEditorHeight', "Decrease Editor Height"), original: 'Decrease Editor Height' }, <del> f1: true </del> <ins> f1: true, precondition: IsAuxiliaryWindowFocusedContext.toNegated() </ins> }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 x64 OS Version: Steps to Reproduce: a new floating window with (or any of the other ones) a few split editors in the main view and the floating view a split in floating window the floating view, execute floating window editor size doesn't change, it happens in the main one
Good catch, these commands should not be available in floating windows.
Change:
}, hiddenItemStrategy: HiddenItemStrategy.Ignore, // keep it lean when hiding items and avoid a "..." overflow menu actionViewItemProvider: (action, options) => { <del> if ((action.id === SubmitAction.ID || action.id === CancelAction.ID) && action instanceof MenuItemAction) { const dropdownAction = this.instantiationService.createInstance(MenuItemAction, { id: 'chat.moreExecuteActions', title: localize('notebook.moreExecuteActionsLabel', "More..."), icon: Codicon.chevronDown }, undefined, undefined, undefined); return this.instantiationService.createInstance(ChatSubmitDropdownActionItem, action, dropdownAction); </del> <ins> if (this.location === ChatAgentLocation.Panel) { if ((action.id === SubmitAction.ID || action.id === CancelAction.ID) && action instanceof MenuItemAction) { const dropdownAction = this.instantiationService.createInstance(MenuItemAction, { id: 'chat.moreExecuteActions', title: localize('notebook.moreExecuteActionsLabel', "More..."), icon: Codicon.chevronDown }, undefined, undefined, undefined); return this.instantiationService.createInstance(ChatSubmitDropdownActionItem, action, dropdownAction); } </ins> } return undefined;

Discussion:
Testing The action shows the submenu for a fraction of a second before disappearing again when clicked. The submenu correctly shows in panel chat. !
We shouldn't have this drop down menu in inline chat
This is the problem:
caused by
Moving to April for more cleanup
Change:
import { IHoverService } from 'vs/platform/hover/browser/hover'; import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { HoverVerbosityAction } from 'vs/editor/common/languages'; <del> import { DECREASE_HOVER_VERBOSITY_ACCESSIBLE_ACTION_ID, DECREASE_HOVER_VERBOSITY_ACTION_ID, DECREASE_HOVER_VERBOSITY_ACTION_LABEL, INCREASE_HOVER_VERBOSITY_ACCESSIBLE_ACTION_ID, INCREASE_HOVER_VERBOSITY_ACTION_ID, INCREASE_HOVER_VERBOSITY_ACTION_LABEL } from 'vs/editor/contrib/hover/browser/hoverActionIds'; </del> <ins> import { DECREASE_HOVER_VERBOSITY_ACCESSIBLE_ACTION_ID, DECREASE_HOVER_VERBOSITY_ACTION_ID, INCREASE_HOVER_VERBOSITY_ACCESSIBLE_ACTION_ID, INCREASE_HOVER_VERBOSITY_ACTION_ID } from 'vs/editor/contrib/hover/browser/hoverActionIds'; </ins> import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; import { Action, IAction } from 'vs/base/common/actions';

Discussion:
Testing the keybinding for verbosity hover over =Shows the keybinding accessibility view of the hover focus to the by clicking A hover for the action shows without the keybinding !
Change:
<key>comment</key> <string>Reserved words within [( )]</string> <key>match</key> <del> <string>b(?i)(mandatory|valuefrompipeline|valuefrompipelinebypropertyname|valuefromremainingarguments|position|parametersetname|defaultparametersetname|supportsshouldprocess|positionalbinding|helpuri|confirmimpact)b</string> </del> <ins> <string>b(?i)(mandatory|valuefrompipeline|valuefrompipelinebypropertyname|valuefromremainingarguments|position|parametersetname|defaultparametersetname|supportsshouldprocess|positionalbinding|helpuri|confirmimpact|helpmessage)b</string> </ins> <key>name</key> <string>entity.other.attribute-name.powershell</string> </dict>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
if (options.codeBlockRenderer) { renderer.code = (code, lang) => { const id = defaultGenerator.nextId(); <del> const value = options.codeBlockRenderer!(lang ?? '', code); </del> <ins> const value = options.codeBlockRenderer!(postProcessCodeBlockLanguageId(lang), code); </ins> codeBlocks.push(value.then(element => [id, element])); return `<div class="code" data-code="${id}">${escape(code)}</div>`; };

Discussion:
In the it says: It then gives : Although the spec does not mandate it, it would be nice if VS Code supported this format. Currently, adding more than just the language identifier after the backticks results in the code note rendering as code: ts const a = new MyClass(); ts foo const a = new MyClass(); <img width="473" alt="Screenshot 2022-08-10 at 15 32 18" src="https://user-"
This already is supported for Markdown highlighting and in markdown previews: ! Is this about support in too?
I don't know what's being used internally by the TS integration above, but I think it should work anywhere that VS Code is already handling these code blocks (my example above was hovers, but things like code completion documentation and other places that support code blocks should be the same - a lot of this content comes from external sources so there's benefit in VS Code being as compatible with what they may use as possible).
Change:
alias: { './node/authServer': path.resolve(__dirname, 'src/browser/authServer'), './node/buffer': path.resolve(__dirname, 'src/browser/buffer'), <ins> './node/fetch': path.resolve(__dirname, 'src/browser/fetch'), </ins> './node/authProvider': path.resolve(__dirname, 'src/browser/authProvider'), } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information
will be exploring fixing this type of issue transparently.
This will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?
that fixed the issue. Thanks so much for the quick response to our problem!
Change:
export const editorRuler = registerColor('editorRuler.foreground', { dark: '#5A5A5A', light: Color.lightgrey, hc: Color.white }, nls.localize('editorRuler', 'Color of the editor rulers.')); <del> export const editorCodeLensForeground = registerColor('editorCodeLens.foreground', { dark: '#999999', light: '#999999', hc: '#999999' }, nls.localize('editorCodeLensForeground', 'Foreground color of editor code lenses')); </del> <ins> export const editorCodeLensForeground = registerColor('editorCodeLens.foreground', { dark: '#999999', light: '#999999', hc: '#999999' }, nls.localize('editorCodeLensForeground', 'Foreground color of editor CodeLens')); </ins> export const editorBracketMatchBackground = registerColor('editorBracketMatch.background', { dark: '#0064001a', light: '#0064001a', hc: '#0064001a' }, nls.localize('editorBracketMatchBackground', 'Background color behind matching brackets')); export const editorBracketMatchBorder = registerColor('editorBracketMatch.border', { dark: '#888', light: '#B9B9B9', hc: contrastBorder }, nls.localize('editorBracketMatchBorder', 'Color for matching brackets boxes'));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --- VSCode Version: 1.44 Insiders OS Version: Windows 10 CodeLens should be one word. The new command display name should be changed from: "Show Code Lens Commands For Current Line" to: "Show CodeLens Commands For Current Line"