jiebi/CodeConvo huggingface dataset:
Change:
if (this.rangeProvider) { return this.rangeProvider; } <del> this.rangeProvider = new IndentRangeProvider(editorModel, this.languageConfigurationService, this._foldingLimitReporter); // fallback </del> <ins> const indentRangeProvider = new IndentRangeProvider(editorModel, this.languageConfigurationService, this._foldingLimitReporter); this.rangeProvider = indentRangeProvider; // fallback </ins> if (this._useFoldingProviders && this.foldingModel) { const foldingProviders = this.languageFeaturesService.foldingRangeProvider.ordered(this.foldingModel.textModel); const selectedProviders = (FoldingController._foldingRangeSelector?.(foldingProviders, editorModel)) ?? foldingProviders; if (selectedProviders.length > 0) { <del> this.rangeProvider = new SyntaxRangeProvider(editorModel, selectedProviders, () => this.triggerFoldingModelChanged(), this._foldingLimitReporter); </del> <ins> this.rangeProvider = new SyntaxRangeProvider(editorModel, selectedProviders, () => this.triggerFoldingModelChanged(), this._foldingLimitReporter, indentRangeProvider); </ins> } } return this.rangeProvider;

Discussion:
a folding range provider that conditionally contributes ranges or undefined and ensure no other is contributing any ranges. a file for which the custom will return undefined so that the default folding regions are shown. another file for which the custom does return ranges. -open the first file :bug: folding regions are not shown !
Change:
) { super(); <ins> const minimumHeight = this._editor.getOption(EditorOption.lineHeight) + 8; const minimumWidth = 4 / 3 * minimumHeight; const minimumSize = new dom.Dimension(minimumWidth, minimumHeight); this._widget = this._register(this._instantiationService.createInstance(ContentHoverWidget, this._editor, minimumSize)); </ins> // Instantiate participants and sort them by `hoverOrdinal` which is relevant for rendering order. this._participants = []; for (const participant of HoverParticipantRegistry.getAll()) {

Discussion:
Testing !
I think the minimum size should me much bigger: !
Currently the minimum height is the line height plus 8 pixels, and the minimum width is 4/3 times the minimum height. Do you think the minimum width should be larger or perhaps dynamic and depending on the current width?
I think a min width of 150px could work
To verify: a hover and make sure that the hover can be sized down to a minimum width of 150px provided that the hover width is naturally above 150px a small hover with a natural width smaller than 150px, verify it can not be sized down to a smaller width than its initial width
Change:
} // TODO@joaomoreno TODO@TylerLeonhardt <ins> private _isNoCorsEnvironment: boolean | undefined; </ins> private async isNoCorsEnvironment(): Promise<boolean> { <ins> if (this._isNoCorsEnvironment !== undefined) { return this._isNoCorsEnvironment; } </ins> const uri = await vscode.env.asExternalUri(vscode.Uri.parse(`${vscode.env.uriScheme}://vscode.github-authentication/dummy`)); <del> return (uri.scheme === 'https' && /^((insiders.)?vscode|github)./.test(uri.authority)) || (uri.scheme === 'http' && /^localhost/.test(uri.authority)); </del> <ins> this._isNoCorsEnvironment = (uri.scheme === 'https' && /^((insiders.)?vscode|github)./.test(uri.authority)) || (uri.scheme === 'http' && /^localhost/.test(uri.authority)); return this._isNoCorsEnvironment; </ins> } public async login(scopes: string): Promise<string> {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Currently signing out of your GitHub account only removes the token from the secret store but the token continues to be valid, which means that if it was leaked the attacker can continue to make use of it. To mitigate this, VS Code should revoke the token on sign out, see this API:
I wish this API didn't require the client secret...
Change:
runHandler: (request: TestRunRequest, token: CancellationToken) => Thenable<void> | void; /** <del> * A function that provides detailed statement and function-level coverage for a file. </del> <ins> * An extension-provided function that provides detailed statement and * function-level coverage for a file. The editor will call this when more * detail is needed for a file, such as when it's opened in an editor or * expanded in the **Test Coverage** view. </ins> * * The {@link FileCoverage} object passed to this function is the same instance * emitted on {@link TestRun.addCoverage} calls associated with this profile.

Discussion:
Refs: [x] anyOS [x] anyOS Complexity: 4 We have at long last finalized the test coverage API. Implementing an extension that produces data for the API from scratch is challenging, and requires domain-specific knowledge, so you might find playing with the selfhost test provider to be the most effective way to test it The new types in the API include: - - - Please: Do some testing that the API and UI functions as you would expect Read through the API and verify that its documentation makes sense to you See that UI interactions work nicely as you would expect (you can use any extension that produces coverage to test this part)
Change:
export class InlayHintsFragments { <ins> private static _emptyInlayHintList: InlayHintList = Object.freeze({ dispose() { }, hints: [] }); </ins> static async create(registry: LanguageFeatureRegistry<InlayHintsProvider>, model: ITextModel, ranges: Range[], token: CancellationToken): Promise<InlayHintsFragments> { const data: [InlayHintList, InlayHintsProvider][] = [];

Discussion:
Does this issue occur when all extensions are disabled?: Yes Version: 1.80.0-insider (Universal) Commit: Date: 2023-06-29T07:48:55.355Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 20.6.0 ProductName: macOS ProductVersion: 11.7.8 BuildVersion: 20G1351 not triggering when returns empty array on initial call and non-empty array thereafter. Steps to Reproduce: the following extension sample. Open a TypeScript file. inlay hint at the first line. you resize the window, the inlay hint appears.
Change:
}; } <ins> override dispose() { super.dispose(); this.clear(); } </ins> }

Discussion:
and interactive window and run a cell that will cause thow an error eg the line that errored in the cell is underlined and an unfixable problem is to the problems window can't even delete the cell to remove the error
edit: didn't realize this was for interactive windows. verifying that this is okay in the problems panel though? !
yeah, that's from pylance, different issue I guess verification should be to run this in the IW, since it won't fail a static check
Change:
} } <del> this.layout({ metadataHeight: metadataLayoutChange, outputTotalHeight: outputLayoutChange }); </del> <ins> if (metadataLayoutChange || outputLayoutChange) { this.layout({ metadataHeight: metadataLayoutChange, outputTotalHeight: outputLayoutChange }); } </ins> })); }

Discussion:
These 2 methods are called when any setting changes: I would have expected an early return if no related setting changed.
Change:
return undefined; } <ins> export async function getDocumentFormattingEditsWithSelectedProvider( workerService: IEditorWorkerService, languageFeaturesService: ILanguageFeaturesService, editorOrModel: ITextModel | IActiveCodeEditor, mode: FormattingMode, token: CancellationToken, ): Promise<TextEdit[] | undefined> { const model = isCodeEditor(editorOrModel) ? editorOrModel.getModel() : editorOrModel; const provider = getRealAndSyntheticDocumentFormattersOrdered(languageFeaturesService.documentFormattingEditProvider, languageFeaturesService.documentRangeFormattingEditProvider, model); const selected = await FormattingConflicts.select(provider, model, mode, FormattingKind.File); if (selected) { const rawEdits = await Promise.resolve(selected.provideDocumentFormattingEdits(model, model.getOptions(), token)).catch(onUnexpectedExternalError); return await workerService.computeMoreMinimalEdits(model.uri, rawEdits); } return undefined; } </ins> export function getOnTypeFormattingEdits( workerService: IEditorWorkerService, languageFeaturesService: ILanguageFeaturesService,

Discussion:
Related: Looking into reports of X formatter being used instead of Y in various flows. Looking at both on save and on execution formatting participants, one common point is that when is specifically being used, the intended formatter is applied as expected. Some early digging is pointing to a use of instead of , so will be working out a fix there. Will update this thread as is relevant.
do you have some minimal verif steps?
Verification Steps: Install Black Formatter + Ruff Create with only the following:create notebook with a single code cell, and contents In Stable () Save Notebook Black formatter runs =nothing changes Ruff formatter runs =Single quotations turned to double quotations () In Insiders () Save Notebook ONLY Black formatter runs =nothing changes

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a "Formatting with autopep8" message in the status bar even though that formatter extension isn't installed! However manually triggering "Format Cell" does use black.
Change:
} None => SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), args.port), }; <ins> let builder = Server::try_bind(&addr).map_err(CodeError::CouldNotListenOnInterface)?; </ins> let mut listening = format!("Web UI available at http://{}", addr); if let Some(ct) = args.connection_token {

Discussion:
Probably should print an error message instead of panicking, and maybe do that before printing the URL to connect to.
If I use port 8000 in another process, then run , it still says but it's not actually available on that port. I would expect it to pick 8001 or something.
Make sure you're binding to the same interface. serve-web always binds to 127.0.0.1. Depending on your OS and network, that may not conflict with a service listening on if localhost is ipv6.
Change:
export interface ICommentsConfiguration { openView: 'never' | 'file' | 'firstFile'; useRelativeTime: boolean; <ins> visible: boolean; </ins> } export const COMMENTS_SECTION = 'comments';

Discussion:
See related issue that was closed by user who opened it: I think it'd be fantastic to hide the discussion/comment bar for those of us that like to keep our interface really minimal. Part of it is how it's distracting to see the + sign moving all over the document with the cursor. I'd like to be able to turn it off in the settings for all circumstances. <img width="115" alt="image" src="https://user-"
I second that! VSCode already has a reputation of being an angry fruit salad. A car radio with a full color display in demo-mode, and then 50 of them built into a store display, scream less than VSCode. Ok I might be exaggerating a bit here.. but I am for from exaggerating when I say that I have about 180 lines in my file just to tone it down. Today I would like to make that a 181 lines. Cheerio!
Have you tried the command "Comments: Toggle Editor Commenting"? If that's not enough then I can also add a setting.
While the "Comments: Toggle Editor Commenting" command is useful, it doesn't persist and doesn't completely solve the issue: if I enable Zen mode and then disable Zen mode, then this gutter will reappear and I will need to toggle again. after running the toggle, the gutter is still wider than it would be without this extension enabled. I just disable this extension until I need it and then enable it temporarily when I need it.
I'll make some updates to better persist the disablement.
Hello! I'm also looking forward to hiding this button. Actually I just need to make commits in vs code, and I don't use review even when a pull request is open But of course someday I will use it, it's just that this good function is not for every day
Incoming change does the following: Persists your pre-zen mode comment toggled state when exiting zen mode Introduces the setting Still let you quickly toggle commenting on an off irrespective of , similar to how toggle word wrap works.
Thanks for the progress!! It seems like the new settings don't do anything about the double-wide gutter. That's a pretty big deal because I'm losing a decent chunk of screen real estate even when commenting is turned off.
I was going to address that in a separate PR to keep my changes smaller. I'm planning to fix it today!
Oh hurray!! So exciting!!
Change:
"name": "Markup Lists", "scope": "markup.list", "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

Discussion:
Environment Details: VSCode Version : 1.25.0 OS Version : Win10 Additional Details: HighContrast,MAS1.4.3 Repro Steps: Visual Studio code desktop application. to "Plain Text" of "Status Bar"-Enter "PowerShell" in "Select Language Mode" combo box-Write the PowerShell Code in plain editor-Save the editor. to Setting button of Activity Bar and select "Color Theme" option. Themes shows number of different colors list apply all that theme on the editor. color contrast analyser and check the color contrast ratio. shows color contrast ratio less than expected color contrast ratio. Actual: After applying color themes to editor it shows color contrast ratio as 3.5:1 eg. Select "QuietLight" theme from color theme list and check for the color contrast ratio. Expected: The expected colorcontrast ratio should be greater than or equals to 7:1 ratio. Recommendations: Refer below link which is repository of bug fixes code  User Impact: User will not able to see the content of the editor. MAS Reference: MAS1.4.3- Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.701 --- <!-- score: 0.617 --- <!-- score: 0.552 --- <!-- score: 0.508 --<!-- potentialduplicatescomment --
I believe you are using the wrong color contrast ratio. From the link you provided: We've only been targeting the minimum contrast ratio, which is Level AA at 4.5:1
Change:
import * as icons from 'vs/workbench/contrib/notebook/browser/notebookIcons'; import { CellEditType, CellKind } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { INotificationService } from 'vs/platform/notification/common/notification'; <ins> import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; </ins> //#region Move/Copy cells const MOVE_CELL_UP_COMMAND_ID = 'notebook.cell.moveUp';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --: 1.61.0-insider (system setup) : : 2021-09-24T09:00:59.405Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: <kbdctrl+k ctrl+shft+<kbd! <kbdctrl+shft+-<kbd!
One of these is contributed by the Jupyter keybindings extension. But, I'm not sure why they show differently between these two menus.
It seems we don't have these actions in menu anymore.
Change:
const tabActionBarDisposable = combinedDisposable(tabActionBar, tabActionListener, toDisposable(insert(this.tabActionBars, tabActionBar))); <ins> // Tab Fade Hider // Hides the tab fade to the right when tab action left and sizing shrink/fixed, ::after, ::before are already used const tabShadowHider = document.createElement('div'); tabShadowHider.classList.add('tab-fade-hider'); tabContainer.appendChild(tabShadowHider); </ins> // Tab Border Bottom const tabBorderBottomContainer = document.createElement('div'); tabBorderBottomContainer.classList.add('tab-border-bottom-container');

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As introduced in version 1.87.0 () drag&drop tabs now features a border indicator. It would be nice to have an option to disable this indicator. (Indicator also makes tabs width change and subsequent unwanted jump effect but that's perhaps a bug issue.) !
If you are not interested in seeing the indicator you can change it's colour to be transparent the following way: Regarding the jumping of the tabs, this is definitely a bug, however, I am not able to reproduce it so it seems like it might be related to some none default setting. Could you share the none default tab related settings you are using?
Of course, I believe jumping of the tabs is related to:
I've tried this but I do not see any jumping ! Possibly related to zooming, what are you using?
I've debugged my a bit and it seems combination of these settings is the culprit:
I have tried the combination of these two settings and it doesn't lead to any jumping in my case.
That's odd. I've tried my installation only with these two settings active (1.87.1 on latest macOS) and I can reproduce the bug. !
I tested it on windows, will try it out on a mac next week.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
I tried the drag and drop on a macos and was also not able to reproduce your bug. Will leave the issue closes for the moment.
Are you sure you've tried the settings above? I was able to reproduce the bug on different MacBook as well as on Windows machine.
I'm able to reproduce now. Looking into it.
In this specific scenario (actions left and shrink tab) we set an ::after element of width 5 for the shadow effect, however, we also use the ::before and ::after elements for drag and drop. Will try to fix next week. Could be a bit tricky
Change:
private layoutFoldingIndicator() { switch (this.foldingState) { case CellFoldingState.None: <ins> this.templateData.foldingIndicator.style.display = 'none'; </ins> this.templateData.foldingIndicator.innerText = ''; break; case CellFoldingState.Collapsed: <ins> this.templateData.foldingIndicator.style.display = ''; </ins> DOM.reset(this.templateData.foldingIndicator, renderIcon(collapsedIcon)); break; case CellFoldingState.Expanded: <ins> this.templateData.foldingIndicator.style.display = ''; </ins> DOM.reset(this.templateData.foldingIndicator, renderIcon(expandedIcon)); break;

Discussion:
Testing The drag cursor shows up in markdown cell gutters, but you can only actually drag on the contents
Works for me
Video: 
Oh, I think it's just the spot where the folding button would go, the DOM is weird there I remember fighting this in the past
Thanks Yes we previously had this for I think it's fine to not support dragging and dropping on the folding indicator itself, but in this case it looks like the folding indicator is hidden so we should allow dragging
Change:
let weight: number | undefined = undefined; if (typeof item.initialSize === 'number') { <del> checkProposedApiEnabled(extension.description, 'contribViewSize'); </del> if (container.extensionId?.value === extension.description.identifier.value) { weight = item.initialSize; } else {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As you can see, the 'open editors' view has dynamic height according to its content. Can we customize our view( which in inside custom view container) height like that? !
Open editors has some custom code for doing this I believe this is not possible with custom views, and I think is a feature request against custom views thus forwarding to
Notes about proposal: Example
Example with the latest proposal
Change:
} } <del> export class QuickOpenHandler extends Quickopen.QuickOpenHandler { </del> <ins> export class DebugQuickOpenHandler extends Quickopen.QuickOpenHandler { </ins> constructor( @IQuickOpenService private quickOpenService: IQuickOpenService,

Discussion:
Testing Version 1.10.0-insider Commit Date 2017-02-22T07:09:05.746Z Linux In the VSCode workspace, open VSCode on the 'extensions/html' folder. press Ctrl + E, type: debug with space at the end an empty dialog shows up click the dialog away error message shows up: Unable to instantiate quick open handler vs/workbench/parts/debug/browser/debugQuickOpen - QuickOpenHandler: {"errorCode":"load","moduleId":"vs/workbench/parts/debug/browser/debugQuickOpen","neededBy":["===anonymous10==="],"detail":{"errno":-2,"code":"ENOENT","syscall":"open","path":"/usr/share/code-"}}
! !
This has been fixed and awaiting pull request review before merge in.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import * as resources from 'vs/base/common/resources'; </ins> import * as assert from 'assert'; import { TestEnvironmentService, TestPathService } from 'vs/workbench/test/browser/workbenchTestServices'; import { URI } from 'vs/base/common/uri'; import { LabelService } from 'vs/workbench/services/label/common/labelService'; import { TestContextService } from 'vs/workbench/test/common/workbenchTestServices'; <ins> import { Workspace, WorkspaceFolder } from 'vs/platform/workspace/common/workspace'; </ins> suite('URI Label', () => { let labelService: LabelService; setup(() => {

Discussion:
Issue Type: <bBug</bI have a multi-root workspace with this config: When I open search results in an editor, the part is incorrectly shown as part of the path: And while this looks like just a cosmetic issue , it also breaks opening the file via F12/doubleclick, since the now gets duplicated in the actual path is tries to open. VS Code version: Code - Insiders 1.47.0-insider (, 2020-06-23T09:03:35.861Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.14.83-gentoo Remote OS version: Linux x64 4.14.83-gentoo Remote OS version: Linux x64 5.4.28-gentoo Remote OS version: Linux x64 4.14.83-gentoo <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ systemd-unit-file1.0.6 udev-rules1.0.0 viml0.1.7 tmux0.1.0 remote-containers0.123.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.4 vscode-remote-extensionpack0.20.0 jinjahtml0.13.0 gitconfig2.0.1 mako0.2.0 vscode-icons10.1.1 overtype0.2.0 vscode-module-templates1.3.0 vscode-postgres1.1.11 quick-open-prefill-selection0.0.1 vscode-eslint2.1.5 gitlens10.2.2 EditorConfig0.15.1 prettier-vscode5.1.0 Go0.14.4 search-editor-apply-changes0.1.1 vsc-python-indent1.10.1 restructuredtext128.0.0 MagicPython1.1.0 vscode-github-actions3.0.0 vscode-docker1.3.1 python2020.7.-dev puppet-vscode0.27.3 vscode-yaml0.8.0 vscode-stylelint0.84.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Thanks for submitting this! Should be fixed in the next insiders.