jiebi/CodeConvo huggingface dataset:
Change:
for (const originalPlaceHolder of this.placeHolders) { let resultOccurences = []; <del> for (let {startLineNumber, startColumn, endLineNumber, endColumn} of originalPlaceHolder.occurences) { </del> <ins> for (let { startLineNumber, startColumn, endLineNumber, endColumn } of originalPlaceHolder.occurences) { </ins> if (startColumn > 1 || startLineNumber === 1) { // placeholders that aren't at the beginning of new snippet lines

Discussion:
Test item VSCode Version: Code - Insiders 1.9.0-insider (, 2017-01-24T10:29:13.076Z) OS Version: Darwin x64 15.6.0 Extensions: None Steps to Reproduce: with: after in some size : : Same goes for single line expansions, although there it is not as bad because it is just one arrow-left key to correct.
Another CSS example is . Pressing when done should land the caret at the end of the line.
This is due to the way snippets get expanded. Take the below example of a snippet When you use the above in any file and after you enter the placeholder followed by ENTER, the cursor remains where the entry was made and does not go to end of line Is there any way to get the cursor to the end of the snippet after completion?
Yes, is the final cursor position which default to the end of the snippet. The sample above it is used to place the cursor elsewhere. Changing above to should do it.
! So the being the final cursor position is a standard behavior for snippets in general or is this VS Code specific rule? The reason I ask is, in order to fix this bug if I make an update to then I wonder if I will be breaking any other editor that uses emmet If it is vscode specific, then I'll make the fix on our end
That's a good question. It is default Textmate behaviour but I don't know if emmet is also Textmate...
emmet does borrow from text mate
Very cool!
Change:
var ShouldRestartTunnelService: Boolean; <ins> function StopTunnelProcesses(); var WaitCounter: Integer; TaskKilled: Integer; begin Log('Stopping all tunnel services with taskkill'); Exec('taskkill.exe', '/f /im "' + ExpandConstant('"{app}bin{#TunnelApplicationName}.exe"') + '"', '', SW_HIDE, ewWaitUntilTerminated, TaskKilled); WaitCounter := 10; while (WaitCounter > 0) and CheckForMutexes('{#TunnelMutex}') do begin Log('Tunnel process is is still running, waiting'); Sleep(500); WaitCounter := WaitCounter - 1 end; if CheckForMutexes('{#TunnelMutex}') then Log('Unable to stop tunnel processes') exit(False) else exit(True) end end; </ins> procedure StopTunnelServiceIfNeeded(); var StopServiceResultCode: Integer;

Discussion:
Type: <bBug</bVS Code version: Code - Insiders 1.80.0-insider (, 2023-06-19T05:35:37.388Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
same here
Made a fix but didn't create a PR apparently. Fixed in next Insiders.
Reopening due to
Change:
this._zone.value.setWidgetMargins(widgetPosition); this._zone.value.show(widgetPosition); } else { <ins> this._zone.value.setWidgetMargins(widgetPosition); </ins> this._zone.value.updatePositionAndHeight(widgetPosition); } }

Discussion:
Inline chat is typically nicely aligned to the line it covers but when I jump to another editor and then back, that alignment is lost: !
Change:
} } } export abstract class MatchFindAction extends EditorAction { public run(accessor: ServicesAccessor, editor: ICodeEditor): void { let controller = CommonFindController.get(editor); if (controller && !this._run(controller)) { controller.start({ forceRevealReplace: false, <del> seedSearchStringFromSelection: (controller.getState().searchString.length === 0), </del> <ins> seedSearchStringFromSelection: (controller.getState().searchString.length === 0) && editor.getConfiguration().contribInfo.find.seedSearchStringFromSelection, </ins> shouldFocus: FindStartFocusAction.NoFocusChange, shouldAnimate: true });

Discussion:
VSCode Version: Code 1.17.2 (, 2017-10-16T13:47:41.889Z) OS Version: Darwin x64 17.0.0 Extensions: ExtensionVersion ------ unity-tools0.1.9 unity-debug1.2.1 vscode-eslint1.3.2 python0.7.0 cpptools0.14.0 csharp1.12.1 mono-debug0.15.7 vscode-arduino0.2.9 Steps to Reproduce: the user setting "": false, text in a document command-e command-f Expected results: VS Code matches the standard Mac text find behavior, where command-e populates the search pasteboard with the current selection, but doesn't show the find panel. Pressing command-f thereafter shows the find panel, revealing what I put in there with command-e. Actual results: pressing command-e shows the find panel and doesn't populate the search pasteboard Plx to allow me to match the macOS standard behavior! Is my favest! <!-- Launch with to check. --Reproduces without extensions: Yes
Change:
"libX11.so.6()(64bit)", "libXss.so.1()(64bit)", "libXtst.so.6()(64bit)", <del> "libgconf-2.so.4()(64bit)", </del> "libgmodule-2.0.so.0()(64bit)", "librt.so.1()(64bit)", "libglib-2.0.so.0()(64bit)",

Discussion:
Afaik, electron should build with dconf instead of gconf.
See also
Please report here:
electron now (3.x) works without gconf. All you have to do is
I can confirm that Insiders 1.31 works without gconf. Can gconf be dropped for insiders?
Change:
assert.strictEqual(res?.range.startColumn, 20); }); <del> test('unless', async function () { const res = extractRangeFromFilter('@/some/path/file.txt (19,20)', ['@']); assert.ok(!res); </del> <ins> suite('unless', async function () { const testSpecs = [ // alpha-only symbol after unless { filter: '/some/path/file.txt@alphasymbol', unless: ['@'], result: undefined }, // unless as first char { filter: '@/some/path/file.txt (19,20)', unless: ['@'], result: undefined }, // unless as last char { filter: '/some/path/file.txt (19,20)@', unless: ['@'], result: undefined }, // unless before , { filter: '/some/@path/file.txt (19,20)', unless: ['@'], result: { filter: '/some/@path/file.txt', range: { endColumn: 20, endLineNumber: 19, startColumn: 20, startLineNumber: 19 } } }, // unless before : { filter: '/some/@path/file.txt:19:20', unless: ['@'], result: { filter: '/some/@path/file.txt', range: { endColumn: 20, endLineNumber: 19, startColumn: 20, startLineNumber: 19 } } }, // unless before # { filter: '/some/@path/file.txt#19', unless: ['@'], result: { filter: '/some/@path/file.txt', range: { endColumn: 1, endLineNumber: 19, startColumn: 1, startLineNumber: 19 } } }, ]; for (const { filter, unless, result } of testSpecs) { test(`${filter} - ${JSON.stringify(unless)}`, () => { assert.deepStrictEqual(extractRangeFromFilter(filter, unless), result); }); } </ins> }); });

Discussion:
open a file open an empty group to the side and focus it open quick open for files type a typescript file name add @ to enable symbol search :bug: the editor in group 1 changes, not the active group
Caused by , TIL about adding @ after a filename
I had seen your PR and actually thought you would fix an issue associated with that feature
I was fixing specifically in a folder/file name before a line/col match
To clarify the feature: typing in a file search allows to ad-hoc flip into a "go to symbol" without having to first open the file. I think I limit this to having at the end of the thing you search for. I.e. if you paste a path with a somewhere it would not trigger. I wonder why I am not doing this when you type for goto line
before it was only checking for the existence of @ and disabling line/col filter extraction if so
I am more arguing that when you search for a file and then type for a line/col pattern, we should automatically open the file in the background and initiate "Go to line", same as we do now for when you type for symbols.
that would be awesome . This was just a drive by fix from me, not sure if is tracking this
Change:
} command += `cd ${quote(cwd)} && `; } <ins> if (env) { command += 'cmd /C "'; for (const key in env) { let value = env[key]; if (value === null) { command += `set "${key}=" && `; } else { value = value.replace(/[&^|<>]/g, s => `^${s}`); command += `set "${key}=${value}" && `; } } } </ins> for (const a of args) { command += (a === '<' || a === '>' || argsCanBeInterpretedByShell) ? a : quote(a); command += ' '; } <ins> if (env) { command += '"'; } </ins> break; case ShellType.bash: {

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
import { Codicon } from 'vs/base/common/codicons'; import { ThemeIcon } from 'vs/base/common/themables'; import { onUnexpectedExternalError } from 'vs/base/common/errors'; <del> import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; </del> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; <del> import { ClickAction, KeyDownAction } from 'vs/base/browser/ui/hover/hoverWidget'; </del> <ins> import { ClickAction, HoverPosition, KeyDownAction } from 'vs/base/browser/ui/hover/hoverWidget'; </ins> import { KeyCode } from 'vs/base/common/keyCodes'; <del> import { IHoverService } from 'vs/platform/hover/browser/hover'; </del> <ins> import { IHoverService, WorkbenchHoverDelegate } from 'vs/platform/hover/browser/hover'; </ins> import { AsyncIterableObject } from 'vs/base/common/async'; import { LanguageFeatureRegistry } from 'vs/editor/common/languageFeatureRegistry'; import { getHoverProviderResultsAsAsyncIterable } from 'vs/editor/contrib/hover/browser/getHover';

Discussion:
Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers
Change:
} else { dependencyTask.configurationProperties.icon = task.configurationProperties.icon; } <del> if (dependencyTask.configurationProperties.hide) { dependencyTask.configurationProperties.hide ||= task.configurationProperties.hide; } else { dependencyTask.configurationProperties.hide = task.configurationProperties.hide; } </del> } private async _getDependencyPromise(task: IActiveTerminalData): Promise<ITaskSummary> {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.0 OS Version: Windows 22H2 When a hidden task that has a "dependson" with a non-hidden task, it will hide that task too after being ran. Steps to Reproduce: example "Tasks: Run Task" in the command pallet "nonhidden task" and "Run hidden task" are available to run "Run hidden task" "Tasks: Run Task" in the command pallet Observe "nonhidden task" is now missing. Only "Run hidden task" is available
Change:
} private handleOpenedEditors(): void { <del> this.handlePinnedTabsLayoutChange(); </del> <ins> this.handleTabBarsStateChange(); </ins> } beforeCloseEditor(editor: EditorInput): void {

Discussion:
Type: <bBug</bfile A from EXPLORER tab with file A file B from EXPLORER -breadcrumb shows file B path (correct) on the pinned tab with file A -breadcrumb shows file B path but should file A This is the minimal case. When I have multiple pinned tabs and open other files, the breadcrump gets more random. UPDATE: Looks like the bug only comes out if this setting is set to true: VS Code version: Code 1.92.2 (, 2024-08-14T17:29:30.058Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ macos-modern-theme2.3.19 better-cpp-syntax1.27.1 remote-containers0.380.0 remote-ssh0.113.1 remote-ssh-edit0.86.0 remote-wsl0.88.2 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.2 vscode-clangd0.1.29 regionfolder1.0.22 cmake-tools1.18.44 cpptools1.21.6 workspace-include-what-you-use0.0.3 cmake0.0.17 (4 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This doesn't reproduce for me. Please try without extensions enabled and without custom settings
I turned off extensions and custom settings. I nailed it down to this setting in It appears that the bug is reproducible only if is true.
can you help here? It seems that pinned, extra-row items don't make the call to the breadcrumbs controls, like how it is done for instance for the
Thanks for steps. could you take a look?
Thanks for reporting. When switching to the last previous active tab of the other tab bar it wasn't updating the breadcrumbs. Made a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Still doesn't work correctly on current insiders version. Version: 1.93.0-insider (user setup) Commit: Date: 2024-08-23T06:45:56.108Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.
Change:
public render(container: HTMLElement): void { container.appendChild(this._hoverContainer); <del> const accessibleViewHint = getHoverAccessibleViewHint(this._configurationService.getValue('accessibility.verbosity.hover') === true && this._accessibilityService.isScreenReaderOptimized(), this._keybindingService.lookupKeybinding('editor.action.accessibleView')?.getAriaLabel()); </del> <ins> const hoverFocused = this._hoverContainer.contains(this._hoverContainer.ownerDocument.activeElement); const accessibleViewHint = hoverFocused && getHoverAccessibleViewHint(this._configurationService.getValue('accessibility.verbosity.hover') === true && this._accessibilityService.isScreenReaderOptimized(), this._keybindingService.lookupKeybinding('editor.action.accessibleView')?.getAriaLabel()); </ins> if (accessibleViewHint) { status(accessibleViewHint);

Discussion:
Type: <bBug</bWhen navigating the UI using the keyboard, NVDA reads the announcement related to the accessible view before the controls that receives focus. I'm finding this to be quite a bad experience, and potentially a big issue for more beginner users of the editor. An easy way to reproduce the problem is by pressing F6 from the editor to focus the status bar and use the arrow keys to move between elements. The issue only seems to affect NVDA at the moment. It may be good to give some time to fire these updates after the control receives focus, especially if the user is navigating quickly through nearby controls like in the status bar. In fact, I wonder what is the benefit of showing just the name of controls and potentially some descriptive text in the accessible view. VS Code version: Code - Insiders 1.85.0-insider (, 2023-12-01T19:00:32.802Z) OS version: WindowsNT arm64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for the report. It shouldn't be reading info about the accessible view in this case.
last iteration, for keyboard only users, we support for showing the tooltip on keyboard focus of status bar items. I had only tested this with a screen reader on macOS. I'll be curious to see why this is causing an issue on windows.
I'm debugging with NVDA. Each time an element in the status bar gains focus, NVDA reports a liveRegionChange associated with the announcement "Inspect this in the accessible view with Alt+F2". If I press alt +F2, the name of that control appears in the accessible view.The live region update is taking precedence over the focus changed event. The same announcement is present on the mac, but over their voiceover is prioritizing the focus event over the live region update, so the control that receives focus is announced first. The same happens with JAWS in windows.
To verify, on windows, enable NVDA. Focus the status bar / activity bar. Use arrow keys. Verify that there's no message about opening the accessible view. Focus a hover in the editor using only the keyboard. Verify that you do hear a message about opening the accessible view.
This was verified in insider's by Will leave it without the label to also verify in the stable build.
Change:
private hide(): void { this.suggestWidgetVisible.reset(); <ins> this.suggestWidgetMultipleSuggestions.reset(); </ins> removeClass(this.element, 'visible'); }

Discussion:
VSCode Version: 1.7.2 or insiders as of today OS Version: win10 x64 There seems to be an issue with suggestWidgetMultipleSuggestions. I am trying to use the following: { "key": "down", "command": "extension.vim_down", "when": "editorTextFocus && !suggestWidgetMultipleSuggestions" } The key is registered correctly up until a suggestion is shown, then it is not correct until vscode is restarted. I tried it without only suggestWidgetMultipleSuggestions and the issue still occurred so I believe that suggestWidgetMultipleSuggestions is the problem. If I had to make a guess, I would guess that it needs the value to be changed back to 0 in hide() here This is causing an issue in Vim where we are using it
Want to submit a PR for it? At the same time, you should probably use instead.
I will try to build from source tonight, we also use suggest widget visible but it is important for us to have both for a few reasons
Change:
} else if (firstAction === CodeActionMenu.documentationID) { totalActionEntries.push(...entry); <ins> } else { // Takes and flattens all the `other` actions menuEntriesToPush(localize('codeAction.widget.id.more', 'More Actions...'), entry); </ins> } } else { // case for separator - not a code action action

Discussion:
Type: <bBug</bWhen I click the light bulb instead of getting a menu I see a thin, dark gray, horizontal bar. I have tried restarting the application. VS Code version: Code - Insiders 1.71.0-insider (, 2022-08-12T05:17:00.323Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ code-gnu-global0.2.2 vscode-markdownlint0.47.0 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 dotnet-test-explorer0.7.7 vscode-guid1.4.20 vscode-azurefunctions1.7.4 vscode-azureresourcegroups0.5.5 csharp1.25.0 python2022.12.0 vscode-pylance2022.8.20 jupyter2022.7. remote-wsl0.66.3 azure-account0.11.1 cmake-tools1.11.26 cpptools1.11.5 powershell2022.7.2 test-adapter-converter0.1.6 rust0.7.8 code-spell-checker2.5.4 cmake0.0.17 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
! Here is an image of what I am seeing.
Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.
Related to: This is most likely because of an extension which uses non-VS Code specific code actions. PR for this is out rn!
Confirming fixed on: Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-18T05:15:52.904Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes Thank you!

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Describe the bug The refactor options like "Wrap with...", "Remove this widget", etc. do not show up in the new code action menu. To Reproduce Steps to reproduce the behavior: editor.experimental.useCustomCodeActionMenu the refactor menu somewhere Expected behavior The refactor options should appear in the new menu. From
For me too, I'll have to migrate to normal vscode... !
Thanks! :)
Change:
*--------------------------------------------------------------------------------------------*/ import * as vscode from 'vscode'; <del> import { parseDocument, validate, getHtmlNode } from './util'; import { HtmlNode } from 'EmmetNode'; </del> <ins> import { validate, getHtmlNodeLS, toLSTextDocument, offsetRangeToVsRange } from './util'; </ins> export function removeTag() { if (!validate(false) || !vscode.window.activeTextEditor) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.46 OS Version: Win 8.1 Steps to Reproduce: a HTML file with the following content the cursor after the command tag is removed but also everything is unindented 1 step If you do the process by hand: <kbdCtrl</kbd+<kbdX</kbd<kbdCtrl</kbd+<kbdV</kbdresult is correct <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I am interested in this and would be working on it.
VsCode implementation just removes an indent/tag (exactly one indent i.e a tab or x spaces) at the start of the line for the lines in between the tags opening and closing(if there is enough blank space) Testing the behavior here , it is clear that the content should be adjusted for indentation if the indentation of content is more than that of tags. Also, if there is an adjustment needed, the adjustment should be the difference in the indent levels not just plainly one indent.
I have configured VSC to not create any indent for any tag. Also this is inside a pre tag so no indentation modification should be done. It could also be a span tag that changes the color of the code in the pre tag. a code tag is not a tag that modifies indentation.
I'm not very familiar with this part of Emmet functionality yet. Will take a look at the PR after patching up some other parts of Emmet.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!