jiebi/CodeConvo huggingface dataset:
Change:
private sortOrder: SortOrder; constructor( <del> @IConfigurationService private configurationService: IConfigurationService </del> <ins> @IConfigurationService private configurationService: IConfigurationService, @IWorkspaceContextService private contextService: IWorkspaceContextService </ins> ) { this.toDispose = [];

Discussion:
VSCode Version: Code - Insiders 1.17.0-insider (, 2017-09-08T10:13:13.694Z) OS Version: Darwin x64 16.7.0 Extensions: Extensions are disabled Steps to Reproduce: a workspace file with the following order of root folders in the multi root workspace is not as expected: ! With more root folders, the order is completely unpredictable, but always consistent. Reproduces without extensions: Yes
This appears to be an issue with how v8 implements as an unstable sort. Preliminary fix at
Change:
const extension = result.get(extensionKey); if (extension) { if (extension.isBuiltin) { <ins> if (semver.gt(extension.version, userExtension.version)) { logService.warn(`Skipping extension ${userExtension.extensionLocation.path} with lower version ${userExtension.version}.`); return; } </ins> // Overwriting a builtin extension inherits the `isBuiltin` property and it doesn't show a warning (<IRelaxedExtensionDescription>userExtension).isBuiltin = true; } else {

Discussion:
<img width="1440" alt="image" src="https://user-"version:
cc not sure why this would be
Let me investigate
There seems to be a older version of this extension in the extensions installation folder. Deleting it will fix it. It seems to be a bug in VS Code for showing reload in this case.
Would be helpful to provide a command to remove all old extensions cache
This is a bug in VS Code that it is not removing the obsolete extensions. So you do not need a command. Manually deleting is just a workaround for now.
To verify: Download and install with version from Version History tab. Reload window and go to extensions view and search for extension and make sure you do not see Reload Required button
Change:
this._defaultShell ?? getSystemShellSync(platform.OS, process.env as platform.IProcessEnvironment), process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432'), process.env.windir, <del> terminalEnvironment.createVariableResolver(this._lastActiveWorkspace, this._variableResolver), </del> <ins> terminalEnvironment.createVariableResolver(this._lastActiveWorkspace, process.env, this._variableResolver), </ins> this._logService, useAutomationShell );

Discussion:
With we are trying to remove from the configuration resolver service. The new way to get the environment is async and requires that the all the configuration resolver methods be async. I have started the adoption of the new async methods in , but there's one use in terminal that looks like it will require more work: Option 1: Convert that use of to use . Option 2: I provide a new method on the configuration resolver service that is sync, but requires you to pass in your own . Which option makes the most sense here?
I think the usage of in must remain sync since it's used as part of the extension API. Is this a problem there since is fine to use? The main purpose of this type was to share code between variable processes.
Sounds like Option 2 is the way to go then. I will add a new method that is sync and lets you pass in your own .
Added: will that let you keep your code reuse?
Change:
} public onContentsChanged(): void { <ins> this._editor.layoutContentWidget(this); </ins> this._hover.onContentsChanged(); const scrollDimensions = this._hover.scrollbar.getScrollDimensions();

Discussion:
! I see this sometimes, but it often gets fixed if I try again, or close and reopen the editor, etc. Right now it keeps happening and it's just impossible to click the hover. I don't know how this API works but I assume this is on vscode's side. Happy to set breakpoints and debug
I couldn't reproduce this so I'm not sure what's the root problem. However, I'm saving here a patch which simulates a hover very similar to the one in the gif: <img width="1141" alt="image" src="https://user-"diffn- editor.focusNotebookCell(newCell, newFocusMode, { focusEditorLine: 1 });n+ await editor.focusNotebookCell(newCell, newFocusMode, { focusEditorLine: 1 });n
I tried for quite a while but couldn't repro. I think there might be some settings that cause the issue reproduce. Does this reproduce when you comment out all your user settings?
Yeah, it reproes with all settings commented out
Thanks to via we could find a repro. Reproduces consistently when hovering at the end of the line: It turns out it has to do with the range the hover provider returns. If the hover provider returns a range that spans one line above the hover request, the hover will render one line above. If the hover provider returns a range that spans two lines above the hover request, the hover will render two lines above, etc. Here's a simplified patch: https://user-
To verify, use gitlens and hover over the end of the line at
Works great but raises the question, why does gitlens return a hover with a multiline range? And I get a highlight in this region, but it blinks and disappears on line 919, and on other lines, no highlight. !
PR to improve the highlight range at
I'm still seeing the original issue at
Change:
registerEditorCommand(new SuggestCommand({ id: 'selectNextSuggestion', <del> precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.MultipleSuggestions), </del> <ins> precondition: ContextKeyExpr.and(SuggestContext.Visible, ContextKeyExpr.or(SuggestContext.MultipleSuggestions, SuggestContext.HasFocusedSuggestion.negate())), </ins> handler: c => c.selectNextSuggestion(), kbOpts: { weight: weight,

Discussion:
Type: <bBug</bOpen new document. Set . Type now start typing the editor will show suggestion (with only one in the list). Now pressing should select the available suggestion, but it can not be done. On the other hand if you type and then start typing the list will contain two items and selection works as expected - when you press the first item is selected and you can navigate the list with and VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
with the setting set to "never" is it expected that there is one selected by default? I didn't have to arrow down for this to happen !
Change:
private _availableSpaceGivenIndentation(): number { const info = this.editor.getLayoutInfo(); <del> return info.contentWidth - (info.glyphMarginWidth + info.decorationsWidth + this._indentationWidth); </del> <ins> return info.contentWidth - (info.glyphMarginWidth + info.decorationsWidth + (this._indentationWidth ?? 0)); </ins> } private _computeHeightInLines(): number {

Discussion:
Ever since the recent changes to the indentation of inline chat, when running Code OSS from the main branch, the indentation is not correct on initial render. By looking at the code this appears to be due to the fact that the initialIndentation is now set to have a value of 0 while previously it was undefined. <img width="654" alt="Screenshot 2023-06-15 at 14 13 10" src=""
Change:
} else { prefix = `├ `; } <del> } else { ariaLabel = localize({ key: 'terminalAriaLabel', comment: [ `The terminal's ID`, `The terminal's title` ] }, "Terminal {0} {1}", instance.instanceId, instance.title); </del> } let title = instance.title;

Discussion:
Testing Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this: Put for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a and not a Modify aria label of an element in case he is part of a split
We're converting this into a list next iteration , I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.
hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?
oh great that you moving to the list. You should have a correct role then. I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip. Special character is not read out now because it is not part of the aria label.
Good point
Scoped this issue down, conversion to list will be handled in
I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before. I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just
! When I inspect a split terminal tab label, it has the correct aria label.
Oh but you are setting the on the wrong HTML element You should use the so the is properly set on the element. It has to be on that element, since that element has focus and that is what the Screen Reader will read. So I think it should be fixed here
Change:
this.suggestOnTriggerCharacters = Boolean(source.suggestOnTriggerCharacters); this.acceptSuggestionOnEnter = Boolean(source.acceptSuggestionOnEnter); this.snippetSuggestions = source.snippetSuggestions; <ins> this.emptySelectionClipboard = source.emptySelectionClipboard; </ins> this.tabCompletion = source.tabCompletion; this.wordBasedSuggestions = source.wordBasedSuggestions; this.suggestFontSize = source.suggestFontSize;

Discussion:
Like the title says, when nothing is selected, copying shouldn't copy a blank character.
As of now, cmd+c without any selection, copies the entire line. Sublime also does the same. Are we suggesting to change this behavior as part of this issue? I really like the current functionality. Or are we suggesting one more option/flag which user can enable to have the new functionality?
Yes, it would be behind an option
Can we have the option for this behavior or disable it? I don't like the auto copy of a blank line and would like to disable that feature. I agree it can be annoying especially in the type of coding I do (debugging).
Was a setting for this?
it is
disables the line copying entirely. Is there a way to have line copying enabled, while simultaneously ignoring the empty lines?
This doesn't disable the copying within my VS Code at all and I can still copy whitespace - anyone else had any luck? fingers crossed
Change:
if (result) { templateData.value.appendChild(result.element); templateData.elementDisposables.add(result); <ins> if ('codeBlockCount' in result) { codeBlockIndex += (result as IChatMarkdownRenderResult).codeBlockCount; } </ins> } });

Discussion:
Steps to Reproduce: multiple markdown strings with code blocks interleaved with commands/warnings. (see sample chat extension ) progressive streaming of chat content. The markdown code blocks at the beginning of the stream are replaced with the last streamed code block content. See below gif: !
Change:
version "2.7.0" resolved "https://registry.yarnpkg.com/nan/-/nan-2.7.0.tgz#d95bf721ec877e08db276ed3fc6eb78f9083ad46" <ins> nan@^2.6.2: version "2.6.2" resolved "https://registry.yarnpkg.com/nan/-/nan-2.6.2.tgz#e4ff34e6c95fdfb5aecc08de6596f43605a7db45" </ins> nan@^2.8.0: version "2.8.0" resolved "https://registry.yarnpkg.com/nan/-/nan-2.8.0.tgz#ed715f3fe9de02b57a5e6252d90a96675e1f085a"

Discussion:
VSCode Version: 1.17.0 () OS Version: Ubuntu 16.04 LTS Steps to Reproduce: "files.useExperimentalFileWatcher": true and close VS Code a symlink to root directory (must be an absolute link, not relative!): directory containing that symlink in VS Code: processes - one of vs code processes takes high CPU Reproduces without extensions: Yes See also:
Just noticed the same thing on osx...
Updating issue with: vs code version 1.17.0 reproduces without extensions ! Also, I found memory usage increasing over time...
Same issue here vs code version 1.17.2 Even after closing the VsCode the Code Helpers is still running with 100% CPU usage.
Reported upstream
Upstream PR
The original PR was closed so I opened one which was merged , just need a release to pull this in.
I have vscode 1.19.2 on Ubuntu. The various nodemodules directories have symbolic links point to each other that form the circular links. The nodemodules is set excluded in "files.watcherExclude". After vscode is started, it uses 100% CPU and memory usage increased dramatically and soon reached the max memory and hang the system. This problem happens whatever useExperimentalFileWatcher is set true or false. The ps shows the problem code process has parameter '--type=watcherService". Attached gdb to the process, it shows the watcher follows through the circular symbolic links in circular. Set "search.followSymlinks": false has no effect,. So this problem still happens in 1.19.2 even with all the right settings in place.
is it possible/easy to patch VS Code to stop this behaviour while waiting for it to hit a release? I have a workspace that causes a 20GB VM to exhaust its memory in about 15 mins because of circular symlinks (it uses lerna).
yeah I'll fork the module to get this in, was hoping I wouldn't need to.
what's the expected behavior after the change? I'm still seeing high CPU on today's insiders version on Ubuntu ! on Mac
the fix is specific to Linux only when you have experimental file watcher set to true in settings (or you have a multi-root workspace open).
If you have this issue, it's not just high CPU usage - your memory will be exhausted within minutes.

With a workspace with circular symlinks in it (it uses lerna and has circular dependencies), I was seeing 20GB of RAM get sucked up in about 15 minutes. Insiders has had the fix for a while now.
thanks, I'll mark as verified since you saw it before :+1:
Change:
// group controllers by extension for (const group of groupBy(others, (a, b) => a.extension.value === b.extension.value ? 0 : 1)) { const extension = this._extensionService.extensions.find(extension => extension.identifier.value === group[0].extension.value); <del> const source = extension?.description ?? group[0].extension.value; </del> <ins> const source = extension?.displayName ?? extension?.description ?? group[0].extension.value; </ins> if (group.length > 1) { quickPickItems.push({ label: source,

Discussion:
It seems the extension's raw is used for the text here. To combat this I had to restate my extension's name in the extension description, which probably isn't the desired approach. I think ideally the extension name would be featured prominently, and the extension description would be below it or something. <img width="1040" alt="image" src="https://user-"<img width="777" alt="image" src="https://user-"Demo:
Change:
supportedPlatforms?: PlatformName[]; } <del> export const showRemoteStartEntry = new RawContextKey<boolean>('showRemoteStartEntry', false); </del> export class RemoteStatusIndicator extends Disposable implements IWorkbenchContribution { private static readonly REMOTE_ACTIONS_COMMAND_ID = 'workbench.action.remote.showMenu';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 (system setup) OS Version: WindowsNT x64 10.0. Commit: Date: 2023-07-12T17:22:07.651Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 vscode a couple of seconds the new "Connect to..." link button on the welcome page is delayed resulting in a really annoying change of the height for the "Start" section and, during the working, a missclick on the wrong recent project. a. remove the button b. fix the height of the "Start" section c. make the button link disable at first, in case something has to load before d. improve the a/b testing expirience, if i am in one of them!!

vsliv368: vsreu685: python383: vspor879: vspor708: vspor363: vswsl492cf: vslsvsres303: vserr242cf: pythontb: vsjup518: pythonptprofiler: vshan820: vstes263: vscod805: binariesv615: bridge0708: bridge0723: vsaa593cf: pythonvs932: py29gd2263cf: vscaat: vsclangdc: c4g48928: dsvsc012cf: pynewext54: azure-devsurveyone: 3biah626: pyind779: : pythonsymbol12: showlangstatbar: vsctsb: pythonms35: : pythonfmttext: pythoncmv: fixshowwlkth: showindicator: pythongtdpath: i26e3531: pythonnosm12tcf: pythonidxpt: pythonnoceb: : dsvsc013:
Change:
*--------------------------------------------------------------------------------------------*/ Object.defineProperty(exports, "__esModule", { value: true }); const retry_1 = require("./retry"); <del> const { installBrowsersWithProgressBar } = require('playwright/lib/install/installer'); </del> <ins> const { installDefaultBrowsersForNpmInstall } = require('playwright/lib/utils/registry'); </ins> async function install() { <del> await (0, retry_1.retry)(() => installBrowsersWithProgressBar()); </del> <ins> await (0, retry_1.retry)(() => installDefaultBrowsersForNpmInstall()); </ins> } install();

Discussion:
This code seems to reach into the module: When trying to update to the file is no longer found and seems gone.
Change:
assertRangeEqual(link1.range, new vscode.Range(0, 10, 0, 14)); assertRangeEqual(link2.range, new vscode.Range(0, 23, 0, 28)); }); <ins> // #49238 test('should handle hyperlinked images', () => { { const links = getLinksForFile('[![alt text](image.jpg)](https://example.com)'); assert.strictEqual(links.length, 2); const [link1, link2] = links; assertRangeEqual(link1.range, new vscode.Range(0,13,0,22)); assertRangeEqual(link2.range, new vscode.Range(0,25,0,44)); } { const links = getLinksForFile('[![a]( whitespace.jpg )]( https://whitespace.com )'); assert.strictEqual(links.length, 2); const [link1, link2] = links; assertRangeEqual(link1.range, new vscode.Range(0,7,0,21)); assertRangeEqual(link2.range, new vscode.Range(0,26,0,48)); } { const links = getLinksForFile('[![a](img1.jpg)](file1.txt) text [![a](img2.jpg)](file2.txt)'); assert.strictEqual(links.length, 4); const [link1, link2, link3, link4] = links; assertRangeEqual(link1.range, new vscode.Range(0,6,0,14)); assertRangeEqual(link2.range, new vscode.Range(0,17,0,26)); assertRangeEqual(link3.range, new vscode.Range(0,39,0,47)); assertRangeEqual(link4.range, new vscode.Range(0,50,0,59)); } }); </ins> });

Discussion:
Steps to Reproduce: the markdown: Bug Only is detected as a clickable link.
Hey can I try working on this one?
Sure, here's the relevant regular expression that matches links: And the related tests: You can run the tests by opening VS Code and selecting the from the debug target menu. The regexp is rather complex so let me know if you have any questions
Could you please tell me what is the expected behaviour?
In the example, it should underline and as clickable links that open files and
Change:
private create(): void { this.domNode = $('.debug-hover-widget'); this.complexValueContainer = dom.append(this.domNode, $('.complex-value')); <ins> this.complexValueContainer.style.visibility = 'hidden'; </ins> this.complexValueTitle = dom.append(this.complexValueContainer, $('.title')); this.treeContainer = dom.append(this.complexValueContainer, $('.debug-hover-tree')); this.treeContainer.setAttribute('role', 'tree');

Discussion:
an object that has many long property values There is no scrollbar the prototype There is a scrollbar !
Probably only with the horizontalscrolling setting enabled? I know that's a bit tricky
What's the setting for that? I don't have any scroll setting that appears debug related enabled. Just sticky scroll for the editor.
I think you have set, right?
No I do not.
Change:
RebaseContinue: { kind: OperationKind.RebaseContinue, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as RebaseContinueOperation, RevertFiles: (showProgress: boolean) => ({ kind: OperationKind.RevertFiles, blocking: false, readOnly: false, remote: false, retry: false, showProgress } as RevertFilesOperation), RevList: { kind: OperationKind.RevList, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as RevListOperation, <ins> RevParse: { kind: OperationKind.RevParse, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as RevParseOperation, </ins> SetBranchUpstream: { kind: OperationKind.SetBranchUpstream, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as SetBranchUpstreamOperation, Show: { kind: OperationKind.Show, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as ShowOperation, Stage: { kind: OperationKind.Stage, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as StageOperation,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !
Change:
import { IWorkbenchThemeService } from 'vs/workbench/services/themes/common/workbenchThemeService'; import { WorkbenchThemeService } from 'vs/workbench/services/themes/electron-browser/workbenchThemeService'; import { registerThemingParticipant, ITheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; <del> import { foreground, focusBorder, scrollbarShadow, scrollbarSliderActiveBackground, scrollbarSliderBackground, scrollbarSliderHoverBackground, listHighlightForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { foreground, selectionBackground, focusBorder, scrollbarShadow, scrollbarSliderActiveBackground, scrollbarSliderBackground, scrollbarSliderHoverBackground, listHighlightForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> /** * Services that we require for the Shell

Discussion:
All input box based widgets (find, file search, etc) need text selection foreground/background UI colors. Have to decide if there should be a global ::selection color or any individual ones are needed. !
Added via for May.