jiebi/CodeConvo huggingface dataset:
Change:
}); }); <ins> test('issue #94521: unusual backing array buffer', () => { function wrapAndSliceUint8Arry(buff: Uint8Array, prefixLength: number, suffixLength: number): Uint8Array { const wrapped = new Uint8Array(prefixLength + buff.byteLength + suffixLength); wrapped.set(buff, prefixLength); return wrapped.subarray(prefixLength, prefixLength + buff.byteLength); } function wrapAndSlice(buff: VSBuffer, prefixLength: number, suffixLength: number): VSBuffer { return VSBuffer.wrap(wrapAndSliceUint8Arry(buff.buffer, prefixLength, suffixLength)); } const dto: ISemanticTokensDto = { id: 5, type: 'full', data: new Uint32Array([1, 2, 3, 4, 5]) }; const encoded = encodeSemanticTokensDto(dto); // with misaligned prefix and misaligned suffix assertEqualFull(<IFullSemanticTokensDto>decodeSemanticTokensDto(wrapAndSlice(encoded, 1, 1)), dto); // with misaligned prefix and aligned suffix assertEqualFull(<IFullSemanticTokensDto>decodeSemanticTokensDto(wrapAndSlice(encoded, 1, 4)), dto); // with aligned prefix and misaligned suffix assertEqualFull(<IFullSemanticTokensDto>decodeSemanticTokensDto(wrapAndSlice(encoded, 4, 1)), dto); // with aligned prefix and aligned suffix assertEqualFull(<IFullSemanticTokensDto>decodeSemanticTokensDto(wrapAndSlice(encoded, 4, 4)), dto); }); </ins> });

Discussion:
This was spotted by when working. There are no steps to reproduce because this has to do with how a specific part of an extension host message (the semantic tokens dto) aligns on bytes in the underlying nodejs stream. I can reproduce through unit testing. This can lead to semantic tokens becoming stale and not updating.
The fix is now in and also in
There is a unit test for this case and there are no steps to verify =giving label.
Change:
findTextInFiles: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.findTextInFiles.d.ts', fsChunks: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.fsChunks.d.ts', idToken: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.idToken.d.ts', <del> inlineCompletions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.inlineCompletions.d.ts', </del> inlineCompletionsAdditions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.inlineCompletionsAdditions.d.ts', inlineCompletionsNew: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.inlineCompletionsNew.d.ts', ipc: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.ipc.d.ts',

Discussion:
(edited by We use this issue to track the progress of the Inline Completions API. The currently proposed API can be found in . There is a sample extension . Before this API can be finalized, we need to figure out these items at least: [x] How can inline completions interact with completions? (Currently, inline completions are hidden when autocomplete shows up and if there is an inline completion, autocomplete does not show up automatically)
why is this proposal not still open? Normally for proposals, we keep them open until the api is finalized and shipped. So that users/extension authors can track the proposal more easily.
Trying to copy and get 404. Is this link dead? This makes the sample in vscode: useless as well. Can you please help?
They have an updated way to get the file. First you have to change the to in the file. Then run to download the latest version of and then run . See more (if the link doesn't scroll down to the "updated api proposal structure" you have to control f it).
Hi folks! Is the API still likely to be released in April as mentioned in ?
it is currently assigned to April and that is our plan. It might slip to May depending on how testing and feedback from Extensions that use this proposed API goes. I suggest to follow this issue for more details. Thanks!
Hello! While trying out the sample package (). I receive the following errors. I also attempted the method you specified and the methods mentioned in the readme. In addition, I also tried the following npm commands: Npm install Npm run postinstall Is this sample still up to date?
good catch. I have tackled the outdated extension via this PR Once we get it approved I will merge it in and then the sample should be up to date. Thanks
Looks like this is on mainline? Any idea when it will be released beyond insiders?
this is assigned to the May milestone. Which means it is part of our May release which usually gets shipped first 10 days of the following month. So this one should be available on Thursday.
amazing! Thanks so much for getting back to me, I'll be deving accordingly :)
I have opened this discussion for any follow up questions since we have done the finalization
Change:
"config.publishBeforeContinueOn.always": "Always publish unpublished git state when using Continue Working On from a git repository", "config.publishBeforeContinueOn.never": "Never publish unpublished git state when using Continue Working On from a git repository", "config.publishBeforeContinueOn.prompt": "Prompt to publish unpublished git state when using Continue Working On from a git repository", <del> "config.similarityThreshold": "Controls the threshold of the similarity index (i.e. amount of additions/deletions compared to the file's size) for changes in a pair of added/deleted files to be considered a rename.", </del> <ins> "config.similarityThreshold": "Controls the threshold of the similarity index (i.e. amount of additions/deletions compared to the file's size) for changes in a pair of added/deleted files to be considered a rename. **Note:** Requires git version `2.18.0` or later.", </ins> "submenu.explorer": "Git", "submenu.commit": "Commit", "submenu.commit.amend": "Amend",

Discussion:
Type: <bBug</bGo to 'Source control' and click 'Initialize Repository'. An error message shows "Git:unknown switch 'b'". VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ LiveServer5.7.9 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Having the same issue after a recent update this morning. Version: 1.79.2 Date: 2023-06-14T08:58:52.392Z (1 day ago) Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
Could you please share the contents of the ? Thanks!
I encountered the same issue.... Output from GIT: 2023-06-16 10:31:06.946 [info] git init -b main [4ms] 2023-06-16 10:31:06.946 [info] error: unknown switch `b' usage: git init [-q | --quiet] [--bare] [--template=<template-directory] [--shared[=<permissions]] [<directory] --template <template-directorydirectory from which templates will be used --bare create a bare repository --shared[=<permissions] specify that the git repository is to be shared amongst several users -q, --quiet be quiet --separate-git-dir <gitdirseparate git dir from working tree 2023-06-16 10:33:13.422 [info] git rev-parse --show-toplevel [1ms] 2023-06-16 10:33:13.422 [info] fatal: not a git repository (or any of the parent directories): .git
Yes, that's the exact same Output received.
Could you please share the version of git that you are using? Thank you!
!
Change:
private readonly _markdownRenderer: MarkdownRenderer; constructor( <del> instance: ITerminalInstance, </del> <ins> private readonly _instance: ITerminalInstance, </ins> @IKeybindingService private readonly _keybindingService: IKeybindingService, @IInstantiationService instantiationService: IInstantiationService, @IOpenerService private readonly _openerService: IOpenerService ) { super(); <del> this._hasShellIntegration = instance.xterm?.shellIntegration.status === ShellIntegrationStatus.VSCode; </del> <ins> this._hasShellIntegration = _instance.xterm?.shellIntegration.status === ShellIntegrationStatus.VSCode; </ins> this._domNode = createFastDomNode(document.createElement('div')); this._contentDomNode = createFastDomNode(document.createElement('div')); this._contentDomNode.setClassName('terminal-accessibility-help');

Discussion:
Shell integration offers many improvements to the terminal experience and makes it more accessible via commands like . reported that he and many others use which does not have shell integration. Should we include a hint in the help menu that the experience could be better when we detect a screen reader & ?
I think this will improve the discoverability! Voting for this idea.
On windows, Create a terminal - via for example. run . Verify that you see a message about migrating to use powershell.
Change:
onDidChangeLogLevel.fire(newLogLevel); } channelPromise.then(channel => { <del> disposables.add(channel); </del> if (channel.logLevel !== logLevel) { setLogLevel(channel.logLevel); } disposables.add(channel.onDidChangeLogLevel(e => setLogLevel(e))); }); <ins> const outputChannel = this.createExtHostOutputChannel(name, channelPromise); </ins> return { <del> ...this.createExtHostOutputChannel(name, channelPromise), </del> <ins> ...outputChannel, </ins> get logLevel() { return logLevel; }, onDidChangeLogLevel: onDidChangeLogLevel.event, trace(value: string, ...args: any[]): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.
Thanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like "command was already registered" or "notebook controller already exists". I am currently commenting out my line in my extension. It's not ideal though.
PR fixing it
Change:
'properties': { 'explorer.openEditors.visible': { 'type': 'number', <del> 'description': nls.localize({ key: 'openEditorsVisible', comment: ['Open is an adjective'] }, "Number of editors shown in the Open Editors pane. Setting this to 0 hides the Open Editors pane."), </del> <ins> 'description': nls.localize({ key: 'openEditorsVisible', comment: ['Open is an adjective'] }, "The maximum number of editors shown in the Open Editors pane. Setting this to 0 hides the Open Editors pane."), </ins> 'default': 9, 'minimum': 0 }, <ins> 'explorer.openEditors.minVisible': { 'type': 'number', 'description': nls.localize({ key: 'openEditorsVisibleMin', comment: ['Open is an adjective'] }, "The minimum number of editor slots shown in the Open Editors pane. If set to 0 the Open Editors pane will dynamically resize based on the number of editors."), 'default': 0, 'minimum': 0 }, </ins> 'explorer.openEditors.sortOrder': { 'type': 'string', 'enum': ['editorOrder', 'alphabetical', 'fullPath'],

Discussion:
Issue Type: <bBug</bthe "OPEN EDITORS" section of the explorer open, and above the explorer's main section. -click one of the files in the main section, but delay the second click slightly. The file opens on the first click and gets to the OPEN EDITORS section. This moves everything below it down by the height of one line, so if that happens before the second click, you're clicking on a different file. Often, instead of opening the second file, it opens a text entry field near the bottom of the explorer's main section (not necessarily anywhere near the mouse cursor) as if I'm trying to create a new file at the top-level of my project. VS Code version: Code 1.57.1 (, 2021-06-17T13:26:56.255Z) OS version: Linux x64 5.12.14-arch1-1 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ vscode-styled-jsx2.0.0 vscode-modelines2.0.5 vscode-eslint2.1.23 vscode-html-css1.10.2 tslint1.0.47 auto-close-tag0.5.11 dotenv1.0.1 vscode-language-pack-en-GB1.54.1 python2021.6. vscode-pylance2021.7.2 jupyter2021.6. remote-containers0.183.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 remote-wsl0.56.5 vscode-remote-extensionpack0.21.0 cpptools1.5.1 lit-plugin1.2.1 sourcekit-lsp0.0.1 vim1.21.5 viml1.0.1 html-css-class-completion1.20.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This is a known limitation. However I could not find the duplicate so let's keep this one open.
I did subsequently find the issue that this duplicates, but it had been closed by a bot: .
The limit is at currently but in theory can be changed to a higher value:
Change:
// Lexer helpers /** <del> * Compiles a regular expression string, adding the 'i' flag if 'ignoreCase' is set. </del> <ins> * Compiles a regular expression string, adding the 'i' flag if 'ignoreCase' is set, and the 'u' flag if 'unicode' is set. </ins> * Also replaces @w+ or sequences with the content of the specified attribute */ function compileRegExp(lexer: monarchCommon.ILexerMin, str: string): RegExp {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Feature request for the Monaco Editor. Create an optional flag for Monaco Monarch language definitions to indicate the usage of unicode-aware regular expressions. An example of one such regular expression is , matching the '' character.
What exactly does not work? Since you can pass in regular expressions directly e.g.
Hi, What's currently not working is the unicode-aware regular expressions supported by ES2015. Even though you're able to write a RegExp including unicode-aware characters (in the format ), and even set the unicode flag for that RegExp, they don't work in Monaco Monarch at the moment. Below is the monaco-language file for ABAP, edited to support the character in identifiers. ! This is how it shows up in the editor: ! That happens precisely because the unicode flag is stripped away by compileRegExp, causing the match to fail for that character: If we change that line to, say it works as expected: ! The proposed solution is a way for the developer to tell Monaco Monarch that, instead of stripping away the unicode flag from all the regular expressions, it should instead add it to all the regular expressions if a flag is set in the language definition, just like it's the current behavior for the option. Another option I've considered was to instead use the unicode flag if, and only if, it is set in the regular expression itself, but from what I could gather, that would force us to compile the RegExp an extra time just for testing the flag, or to parse the RegExp manually. Let me know if you need more information.
:+1: Thank you, this makes good sense!
Change:
"name": "Markup: Link", "scope": "meta.link", "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

Discussion:
Environment Details: VSCode Version : 1.25.0 OS Version : Win10 Additional Details: HighContrast,MAS1.4.3 Repro Steps: Visual Studio code desktop application. to "Plain Text" of "Status Bar"-Enter "PowerShell" in "Select Language Mode" combo box-Write the PowerShell Code in plain editor-Save the editor. to Setting button of Activity Bar and select "Color Theme" option. Themes shows number of different colors list apply all that theme on the editor. color contrast analyser and check the color contrast ratio. shows color contrast ratio less than expected color contrast ratio. Actual: After applying color themes to editor it shows color contrast ratio as 3.5:1 eg. Select "QuietLight" theme from color theme list and check for the color contrast ratio. Expected: The expected colorcontrast ratio should be greater than or equals to 7:1 ratio. Recommendations: Refer below link which is repository of bug fixes code  User Impact: User will not able to see the content of the editor. MAS Reference: MAS1.4.3- Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.701 --- <!-- score: 0.617 --- <!-- score: 0.552 --- <!-- score: 0.508 --<!-- potentialduplicatescomment --
I believe you are using the wrong color contrast ratio. From the link you provided: We've only been targeting the minimum contrast ratio, which is Level AA at 4.5:1
Change:
private readonly _onDidChangeTextEditorSelection = new Emitter<vscode.TextEditorSelectionChangeEvent>(); private readonly _onDidChangeTextEditorOptions = new Emitter<vscode.TextEditorOptionsChangeEvent>(); private readonly _onDidChangeTextEditorViewColumn = new Emitter<vscode.TextEditorViewColumnChangeEvent>(); <del> private readonly _onDidChangeActiveTextEditor = new Emitter<vscode.TextEditor>(); </del> <ins> private readonly _onDidChangeActiveTextEditor = new Emitter<vscode.TextEditor | undefined>(); </ins> private readonly _onDidChangeVisibleTextEditors = new Emitter<vscode.TextEditor[]>(); readonly onDidChangeTextEditorSelection: Event<vscode.TextEditorSelectionChangeEvent> = this._onDidChangeTextEditorSelection.event; readonly onDidChangeTextEditorOptions: Event<vscode.TextEditorOptionsChangeEvent> = this._onDidChangeTextEditorOptions.event; readonly onDidChangeTextEditorViewColumn: Event<vscode.TextEditorViewColumnChangeEvent> = this._onDidChangeTextEditorViewColumn.event; <del> readonly onDidChangeActiveTextEditor: Event<vscode.TextEditor> = this._onDidChangeActiveTextEditor.event; </del> <ins> readonly onDidChangeActiveTextEditor: Event<vscode.TextEditor | undefined> = this._onDidChangeActiveTextEditor.event; </ins> readonly onDidChangeVisibleTextEditors: Event<vscode.TextEditor[]> = this._onDidChangeVisibleTextEditors.event;

Discussion:
I just had "preview" enabled and clicked on many typescript files rapidly so that they changed a lot. The console shows:
Change:
hideOnHover: true, hideOnKeyDown: true, }, <ins> appearance: { compact: true, }, </ins> ...overrideOptions }, focus); }

Discussion:
With the custom hover now making appearance everywhere in the workbench UI, I think we should try to make it a bit more compact. Previously I had reported as but I think is still too large and there is a lot of empty space as well. I suggest to find the sweet spot between native hover size and custom hover size. <img width="213" alt="image" src=""
Change:
this.treeElementHasChild = WorkbenchTreeElementHasChild.bindTo(this.contextKeyService); this.treeFindOpen = WorkbenchTreeFindOpen.bindTo(this.contextKeyService); <del> this.treeSupportFindWidget = WorkbenchTreeSupportsFind.bindTo(this.contextKeyService); this.treeSupportFindWidget.set(options.findWidgetEnabled ?? true); </del> this._useAltAsMultipleSelectionModifier = useAltAsMultipleSelectionModifier(configurationService);

Discussion:
I think this came up during the standup today, why is the context key called and not ? //cc
This context key came in quite late via a fix -- . I noticed this standing out because of the default keybindings which seem to mix things up: Giving this a candidate in case we want to align the context key before shipping stable
From
Change:
/** * Helper to convert a file path to a URI. * <del> * TODO@bpasero check for removal once ESM has landed. </del> <ins> * TODO@bpasero TODO@esm check for removal once ESM has landed. </ins> * * @param {string} path * @param {{ isWindows?: boolean, scheme?: string, fallbackAuthority?: string }} config

Discussion:
We lost changes that where ESM relevant. I am trying to fix it in our ESM branch, maybe backport it from there: The old code also had this line, which I am not sure is needed: cc
Sorry about that. Is this for Monaco or the esm work? I'd love to get a point where we can just have this as a normal dependency instead of copying it into our sources. Marked now publishes both a commonjs and esm builds too. Is there some way VS Code could use Marked as a normal dependency in a way that would also work for Monaco? If I recall we've tried to avoid adding real dependencies to Monaco
I only noticed for our work, not sure about Monaco ESM. Would be great to get it working again on .
I think the ESM work will unblock this. esbuild will be able to bring in and include node modules into our bundle, the AMD bundler we currently use can only bundle AMD modules and not commonjs modules.
I would have hoped that the Monaco Editor checks would have caught this. Is there something we should improve there?
For monaco-editor-core, these are the only tests: It does not test markdown features.
Change:
this.toDispose.push(dom.addDisposableListener(this.start, dom.EventType.KEY_DOWN, (e: KeyboardEvent) => { const event = new StandardKeyboardEvent(e); <del> if (event.equals(KeyCode.Enter) && this.debugService.state !== State.Initializing) { this.actionRunner.run(this.action, this.context); } </del> if (event.equals(KeyCode.RightArrow)) { this.start.tabIndex = -1; this.selectBox.focus();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: I was also able to reproduce the issue in the latest Insiders build as of 6 Sept 2022 OS Version: RHEL 8.6, kernel 4.18.0, using Gnome 3 with X11 Steps to Reproduce: a folder with a VS Code debug configuration (I used redhat-developer/vscode-xml) Ctrl+Shift+D to focus the "Start Debugging" button Enter debug task is launched twice In my case, I have a warning "no problem matchers defined" that I manually select "launch anyways" for. I know the debug task is being launched twice since the warning appears twice, and two instances of the I've defined are started in the terminal.
This should be reproducible on Windows as well
Quick analysis - seems like the debug service status checks in are supposed to prevent this, but the keydown handlers must happen in a different order now. do you know why the Enter handler in is needed since the ActionBar handles enter? It all seems to work for me if I just delete that block
maybe in the past ActionBar did not handle enter for . If it seems to work fine if we delete it then I suggest we just remove that code :) Thanks