jiebi/CodeConvo huggingface dataset:
Change:
if (optionDisabled) { dom.addClass((<HTMLElement>data.root), 'option-disabled'); } else { <del> // TODO: verify if there is a list issue with old classes on rows // This class removal should not be necessary </del> <ins> // Make sure we do class removal from prior template rendering </ins> dom.removeClass((<HTMLElement>data.root), 'option-disabled'); } }

Discussion:
VSCode Version: 1.21.0 OS Version: Windows 10 Redstone 4 Steps to Reproduce: create a configuration type: { "type": "node", "request": "launch", "name": "Stuff", "program": "${workspaceFolder}Stuff" }, Save correct behavior in drop down where you can select that item. the exact same item (change only the program path, leave name the same) as a second configuration. { "type": "node", "request": "launch", "name": "Stuff", "program": "${workspaceFolder}Stuff2" }, your new item missing in drop down because you used same name. same name, by changing "Stuff" to "Stuff2" { "type": "node", "request": "launch", "name": "Stuff2", "program": "${workspaceFolder}Stuff2" }, your new config shows up but you can not select it. (Hover over does not highlight item, clicking does not select item) VSCode correct behavior. Does this issue occur when all extensions are disabled?: Yes
working on this. fairly certain it's related to terminal disposal and issue drop-down options get updated before the instance count is changed. non- atomic from select box view. It would be very helpful for your review once I have something finalized , I think the order of execution is very critical here.
thanks for looking into this. I can review the PR once it is ready. We can verify if that is the same issue by opening F1 developer tools and checking the debug console for potential errors.
I was able to partially reproduce your issue. While I did not have a problem with two debug configurations with the same name, I did see the hover issue. It it appears that you can still select the item with the keyboard so it's actually probably a misplaced disable class within the CSS. It is also still possibly related to another index problem with a twist on the results. StayTuned. !
One thing I left out that I should have mentioned is I also have configurations spanning mutiple workspaces. This issue was in a single workspace, however I have multiple configs which it merges together.
cc: I can reproduce this in several ways. It appears to be an odd "sticky" class label within the list. I have a fix , I would consider the work around.

I will commit tomorrow with comments to at least avoid the problem for now. do you use insiders to check after I merge?
I do not currently, but I can, I'll check it after the merge and let you know.
Merged into master. Should be a next insiders. I am not closing this issue as I still think this is a workaround.
Change:
import { IPanelService } from 'vs/workbench/services/panel/common/panelService'; import { IViewletService } from 'vs/workbench/services/viewlet/browser/viewlet'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; <ins> import { IEditorService } from 'vs/platform/editor/common/editor'; import { openBreakpointSource } from 'vs/workbench/parts/debug/browser/breakpointsView'; </ins> class ToggleBreakpointAction extends EditorAction { constructor() {

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: 1.14.2 OS Version: MacOS Sierra Steps to Reproduce: some breakpoints. to find shortcut to navigate between breakpoints without running the file. <!-- Launch with to check. --Reproduces without extensions: Yes
We accept PRs that fix this - especaially if more users ask for this feature request
Hi, I'm working on this. Will submit a PR soon.
Having this feature could remove the need for bookmarks, fixing
Does not work for me: set breakpoints in various files. run "Go To Next Breakpoint" action Observe: completely random behaviour. Sometimes I can only go through the breakpoints in one file, sometimes I can switch back and forth between two files. But I'm not able to step through all breakpoints in all files in deterministic order.
Dup of
Verified . Marking this as verified as well.
Change:
"test.tsx": "_react_2_light", "re": "_reasonml_light", "r": "_R_light", <del> "rmd": "_rmd_light", </del> <ins> "rmd": "_R_light", </ins> "erb": "_html_erb_light", "erb.html": "_html_erb_light", "html.erb": "_html_erb_light",

Discussion:
accepted a couple of update PRs recently. Can you please sync extensions/theme-seti/icons? Meanwhile, I noticed that file was falsely classified as type file. I am not sure if that's a real issue in the latest vscode release candidate, or just a non-reproducible problem caused by some peculiarity in my vscode dev env. Can you please take a look?
Also something worth mentioning is that WebP images lack the image icon whereas WebM videos does indeed have the video icon. Adding lines: and does indeed solves the issue.
can you please file a separate issue? Thanks.
NP sir .
thanks! While testing your PR, can you also please check the icon for file? There shouldn't be no icon assigned to it. Otherwise, that's a regression and I am happy to file an issue.
we don't have any references to files in our seti-ui directory and nearly all of our code is pulled directly from the seti repo, so i'm unsure where this is coming from. Please file a separate issue and can look into it. EDIT: after looking into this, it appears that files are : ! And we have refs for mod files in our built-in xml extension: So there is a clash there. I'd suggest you make a request on the seti-ui theme to set files to a go icon so there are no conflicts.
Verification steps: ensure that the following updates are reflected in the file explorer for file icons: use the new logo files point to the R icon files point to the TypeScript icon !
Change:
let mut rx = tailf(read_file, 32); assert!(rx.try_recv().is_err()); <del> let mut append_file = OpenOptions::new() .write(true) .append(true) .open(&file_path) .unwrap(); </del> <ins> let mut append_file = OpenOptions::new().append(true).open(&file_path).unwrap(); </ins> writeln!(&mut append_file, "some line").unwrap(); let recv = rx.recv().await;

Discussion:
This used to work on the same machine however. Not sure when it stopped. Or why.
Please run
that worked! Wonder if the CLI should do it automatically?
BTW I also noticed how it returns exit code 0 (success) even when it failed like that. Perhaps you should avoid just issuing a warning in case some of these operations fails.
Thanks a ton,
Change:
} return { <del> value: element.checked, </del> <ins> get value() { return element.checked; }, </ins> onDidChange: e => element.onChecked(() => e()), }; }

Discussion:
a screen reader the command. are always read as "unchecked"
bisected this to can you take a look?
Oops, next time we meet I owe you a drink! ;)
Change:
padding: 0 26px; line-height: var(--markdown-line-height, 22px); word-wrap: break-word; <ins> overscroll-behavior-x: none; </ins> } body {

Discussion:
Type: <bBug</bGot the June update this morning. Noticed this stopped working: markdown.preview.markEditorSelection Looking at the HTML in dev tools the body tag looks malformed: I copied this with extensions disabled. VS Code version: Code 1.80.0 (, 2023-07-04T15:06:02.407Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (66)</summaryExtensionVersion ------ increment-selection0.2.0 Bookmarks13.3.1 rtf2.7.0 vscode-unfancy-file-icons3.15.0 html-end-tag-labels1.0.0 icons-carbon0.2.6 vscode-open-file-folder0.0.4 markdown-footnotes0.1.1 insert-unicode0.14.0 markdown-toc1.5.6 reverse-search2.0.2 vscode-markdownlint0.51.0 vscode-simpler-icons1.6.5 vscode-eslint2.4.2 vscode-quick-select0.2.9 githistory0.6.20 xml2.5.1 overtype0.5.0 vsc-material-theme-icons2.8.0 prettier-vscode9.19.0 font-switcher4.1.0 auto-close-tag0.5.14 dotnet-test-explorer0.7.8 macros1.2.1 html-preview-vscode0.2.5 live-sass6.0.5 todo-tree0.0.226 vscode-htmlhint1.0.5 docomment1.0.0 vscode-autohotkey-plus-plus3.3.2 markdown-shortcuts0.12.0 render-crlf1.6.1 fluent-icons0.0.18 .8.0 csharp1.26.0 vscode-dotnet-runtime1.6.0 powershell2023.6.0 vscode-paste-image1.0.4 fix-json0.1.2 subtitles-editor1.1.7 material-icon-theme4.28.0 material-product-icons1.5.0 word-counter0.0.1 toggle0.0.2 vscode-sort-json1.20.0 partial-diff1.4.3 block-travel0.0.2 MDTools1.0.1 vscode-table-formatter1.

2.1 vscode-fileutils3.10.2 uridecode0.3.6 character-count0.1.1 code-spell-checker2.20.5 code-spell-checker-british-english1.1.4 code-spell-checker-french0.3.1 code-spell-checker-german2.2.1 code-spell-checker-greek1.0.4 code-spell-checker-italian1.0.2 code-spell-checker-medical-terms2.0.3 code-spell-checker-scientific-terms0.1.9 code-spell-checker-spanish2.1.9 duplicate-finder0.0.6 vscode-w3cvalidation2.9.1 vscode-icons12.4.0 copyrawvalue1.0.0 markdown-all-in-one3.5.1 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Introduced by Should just move the style to the css file instead
Closing as this looks to be merged.
Change:
const currLineEmptyOrIndented = isLineEmptyOrIndented(lineNumber); const notEmpty = !nextLineEmptyOrIndented && !prevLineEmptyOrIndented; <del> let hasDecoration = false; </del> const currLineDecorations = this._editor.getLineDecorations(lineNumber); <del> if (currLineDecorations) { for (const decoration of currLineDecorations) { if (decoration.options.glyphMarginClassName?.includes(Codicon.debugBreakpoint.id)) { hasDecoration = true; } } } </del> <ins> const hasDecoration = !!(currLineDecorations?.length); </ins> // check above and below. if both are blocked, display lightbulb in the gutter. if (!nextLineEmptyOrIndented && !prevLineEmptyOrIndented && !hasDecoration) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Do you have a solution to prevent the window from shaking when I hover the cursor over a line? An icon appears in the scrollbar, which shifts the entire code window. This is very annoying. Is it possible to position this tooltip absolutely above the lines of code? Or add extra gutter space for handle 2 icon ? <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version : 1.92.1 (user setup) Validation : Date : 2024-08-07T20:16:39.455Z Electron : 30.1.2 ElectronBuildId : Chromium : 124.0.6367.243 : 20.14.0 V8 : 12.4.254.20-electron.0 Système d’exploitation : Windows_NT x64 10.0. Steps to Reproduce: click on line with glutter filled with icon the new icon decale de window !
Related to
Also
Pinging because of which extension is adding those warning triangle glyphs to your gutter?
But I really can’t do without it, it's one of the most productive extensions for VSCode.
good catch thanks! this is because my check only accounts for the built in codicon. will be fixed in the above PR to not shift the code (will follow normal lightbulb behavior)
Thank you for your quick response. Do you know when there will be an update? This behavior is really very unpleasant. In some situations, I find myself working with a flickering window; it makes me dizzy
For those wondering, I just discovered that the dates for future updates are displayed. So here is the answer to my question: September 05, 2024 !
Change:
return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const node = e.element; if (!node) {

Discussion:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies
Change:
* Must be disposed as soon as the model detaches from the editor. */ export class ActiveGhostTextController extends Disposable { <del> public readonly contextKeys = new GhostTextContextKeys(this.contextKeyService); </del> <ins> private readonly contextKeys = new GhostTextContextKeys(this.contextKeyService); </ins> public readonly model = this._register(this.instantiationService.createInstance(GhostTextModel, this.editor)); public readonly widget = this._register(this.instantiationService.createInstance(GhostTextWidget, this.editor, this.model));

Discussion:
(See attached recording) I have enclose it in new use cmd+left to go to start of line ghost suggestions get accepted https://user-
Change:
resolved "https://registry.yarnpkg.com/@istanbuljs/schema/-/schema-0.1.2.tgz#26520bf09abe4a5644cd5414e37125a8954241dd" integrity sha512-tsAQNx32a8CoFhjhijUIhI4kccIAgmGhy8LZMZgGfmXcpMbPRUqn5LWmgRttILi6yeGmBJd2xsPkFMs0PzgPCw== <del> "@shiftkey/node-abi@2.19.2-pre": version "2.19.2-pre" resolved "https://registry.yarnpkg.com/@shiftkey/node-abi/-/node-abi-2.19.2-pre.tgz#02599b37253e414f8f6ef3c67ea704e37da640a9" integrity sha512-+LfXo6nd2uZ8cGSJ66zL3OuddvG2oMWMc9GzpDoX2ZNMLmYpu+ReoEKXtmoKVwd6JSavDymldebCxSJh9NQ9cg== dependencies: semver "^5.4.1" "@shiftkey/prebuild-install@6.0.1-pre2": version "6.0.1-pre2" resolved "https://registry.yarnpkg.com/@shiftkey/prebuild-install/-/prebuild-install-6.0.1-pre2.tgz#8cea022dd9aa0eb064164987b6ab12539efb892e" integrity sha512-wDV1DgFxi0F+kTpyGNdnDctdw3Rb9aP8RBAGFE2wXr1+pXSCJRRA+Qh5ko5dKc0LeNIBZzjEECjmtAykajv+Xw== dependencies: "@shiftkey/node-abi" "2.19.2-pre" detect-libc "^1.0.3" expand-template "^2.0.3" github-from-package "0.0.0" minimist "^1.2.3" mkdirp-classic "^0.5.3" napi-build-utils "^1.0.1" noop-logger "^0.1.1" npmlog "^4.0.1" pump "^3.0.0" rc "^1.2.7" simple-get "^3.0.3" tar-fs "^2.0.0" tunnel-agent "^0.6.0" which-pm-runs "^1.0.0" </del> "@sindresorhus/is@^0.14.0": version "0.14.0" resolved "https://registry.yarnpkg.com/@sindresorhus/is/-/is-0.14.0.tgz#9fb3a3cf3132328151f353de4632e01e52102bea"

Discussion:
Captured by Symbolicated trace:
Crash in keytar module due to missing handlescope in callbacks when reentering javascript thread
Change:
repeat: e.repeat }); }; <ins> /** * @param {KeyboardEvent} e */ const handleInnerUp = (e) => { host.postMessage('did-keyup', { key: e.key, keyCode: e.keyCode, code: e.code, shiftKey: e.shiftKey, altKey: e.altKey, ctrlKey: e.ctrlKey, metaKey: e.metaKey, repeat: e.repeat }); }; </ins> /** * @param {KeyboardEvent} e

Discussion:
Issue Type: <bBug</bRelease Notes alt to open the file menu menu dosn't opens. menu opens, focus moves VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-07T11:32:09.993Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ github-markdown-preview0.0.2 markdown-checkbox0.1.3 markdown-emoji0.0.9 markdown-preview-github-styles0.1.6 markdown-yaml-preamble0.0.4 vscode-astyle0.9.0 vscode-markdownlint0.36.2 githistory0.6.9 EditorConfig0.15.1 vscode-pull-request-github0.18.1 vscode-language-pack-ru1.48.2 python2020.7. remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.4 cmake-tools1.4.1 cpptools0.29.0 vsliveshare1.0.2478 vsliveshare-audio0.1.85 vsliveshare-pack0.4.0 code-spell-checker1.9.0 code-spell-checker-russian0.2.4 </details<!-- generated by issue reporter --
I can reproduce this - just open any markdown preview and will not open the file menu. I think we should fix this for this release, as it is a breaking change (in last stable I can nicely press to open the file menu). Due to that I am assigning this to July and can move it out if he would prefer to fix it next milestone Also fyi for custom menus
Has the way the menus handle mnemonics changed this iteration? The webview still seem to be dispatching the events but they aren't being handled by anyone
nope no changes that i know of
should be handled here
is working for me and in insiders on windows.

For just pressing to show the mnemonics, this does not seem like a regression from 1.47 in my testing but it was working in 1.46
I was just testing this out, I see no new behavioral differences between now and 1.46 does not focus the custom menubar with release notes focused. We do not get the alt event +<mnemonicdoes open the resepective menu with release notes focused.
hay can we fix that? because it's really strange in my opinion.
Changing the listeners from using to fixes the initial trigger, but keys like don't clear the focus. Moving out to look into a better fix
is there something webviews need to do to have keys passed back to VS Code? This came up at and I can repro in both stable and insiders. The webview hosts an iframe if that matters. I'm unable to interact with VS Code (eg. to open command palette) when focus is in the web view. I tried loading a non-Flutter page in there to check it wasn't specific to Flutter, but it's happening with other pages too.
If you can avoid it, don't use an iframe. If you absolutely must use an iframe, then you need to dispatch the keypresses back to webviews. See
I don't think there's any way to avoid the iframe really. The linked solution didn't work due to CORS issues, but the comments further down using postMessage to bounce the events over does. I'll see whether we can get something like that in the embedded app. Thanks!
Change:
} await repository.push(); <ins> } else if (repository.state.HEAD?.behind) { const pull = vscode.l10n.t('Pull Changes & Copy Link'); const selection = await vscode.window.showInformationMessage( vscode.l10n.t('The current branch is not up to date. Would you like to pull before copying a link?'), { modal: true }, pull ); if (selection !== pull) { throw new vscode.CancellationError(); } await repository.pull(); </ins> } await repository.status();

Discussion:
Testing I am currently one commit behind the remote branch and I am able to successfully create a link without seeing any dialog. The way the test plan item is written it implies that in this scenario, I should see a dialog. Is that the case or did I misunderstood the test plan item?
Testing with while being a few commits behind, I get the following dialog: <img width="264" alt="image" src=""When I Cancel, I don't get a link. When I Pull & Copy I get a link that is seemingly unaffected by the pull. Why then require the pull? (I tested with incoming commits affecting the file I copy a link from.)
The link that is copied might point to a range that is invalidated by incoming commits, so we notify in order to avoid you copying a link that points to a different area in the file. But perhaps we should also offer a Copy Anyway option here.

Testing When one tries to copy a link on a branch that has not been published we display a dialog asking the user whether they want to publish the branch. Based on my tests, the branch is getting published and the linked is being copied to the clipboard. I think that it makes sense to be explicit about what happens and change the label of the button to "Publish Branch & Copy Link". I also noticed that when trying to create a link for uncommited changes, the dialog contains an action to "Copy Anyways". I think actions should be consistent so we should add that action to this dialog as well.
Change:
app.commandLine.appendSwitch(argvKey); } } else if (argvValue) { <del> if (argvKey === 'force-color-profile') { // Color profile app.commandLine.appendSwitch(argvKey, argvValue); } else if (argvKey === 'password-store') { </del> <ins> if (argvKey === 'password-store') { </ins> // Password store // TODO@TylerLeonhardt: Remove this migration in 3 months let migratedArgvValue = argvValue;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Add support for --proxy-bypass-list in the file so that we can provide a default proxy bypass list to VS Code users. Setting NO_PROXY doesn't work as a solution because it would either have to be set as a user / system environment variable thus impacting all applications, or we would have to rely on our VS Code users to explicitly pass --proxy-bypass-list as an argument to code on the command line each time they launch. Having the option to set this in would provide us with a way to package this in our default enterprise installation of VS Code so users would get this setting by default, but just for VS Code.
Could we just in . I was not aware that only a subset of our command line arguments can be configured there actually. fyi
Yes we can expose it Yeah the list of chromium commandline flags in quit large and always changes with version updates it would be a nightmare if we are to support all of them in . At this time we only support those on a case by case basis.
Thanks, makes sense! Should I assign this one to you? If you are busy, I am happy to provide a PR in July if you give me a code pointer?
Here is an example of recent flag addition , feel free to send a PR. I can review it. Thanks!
Thanks for that great example. Here's the PR I verified that adding "proxy-bypass-list" does not produce errors in I did not verify if this list actually gets passed to Chrome. We can ask if we get this out to an insiders build.
FYI: There is a PR in progress for adding a setting for the feature:
Thanks. But unlike that PR, I think this flag just needs to be passed to Chromium and it should get handled. i.e. I did not add any code in VS Code that actually handles the flag.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!
This flag doesn't seem to work for me unfortunately. Using mitmproxy I still see the bypassed domains: !
Can confirm, preparing a fix now.
thanks for the quick fix
verification steps: Setup mitmproxy Start the application with proxy server Check the logs to see requests from the application are intercepted, you should see some domains like or Open and set Restart the application with same proxy server Confirm that requests to these hosts are not seen in the intercepted logs anymore