jiebi/CodeConvo huggingface dataset:
Change:
return; } <ins> this._set(nodes, false, browserEvent); } private _set(nodes: ITreeNode<T, any>[], silent: boolean, browserEvent?: UIEvent): void { </ins> this.nodes = [...nodes]; this.elements = undefined; this._nodeSet = undefined; <del> const that = this; this._onDidChange.fire({ get elements() { return that.get(); }, browserEvent }); </del> <ins> if (!silent) { const that = this; this._onDidChange.fire({ get elements() { return that.get(); }, browserEvent }); } </ins> } get(): T[] {

Discussion:
a TypeScript file open (with some code in it) the outline to jump to the beginning of a method something somewhere the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds Yes (both in insiders & stable) Version: 1.34.0-insider (user setup) Commit: Date: 2019-04-26T13:39:29.623Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.
It seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g being but it seems like a tree issue <img width="777" alt="Screenshot 2019-04-29 at 10 33 24" src="https://user-"
Change:
export interface IWalkthrough { readonly id: string; readonly title: string; <ins> readonly icon?: string; </ins> readonly description: string; readonly steps: IWalkthroughStep[]; readonly featuredFor: string[] | undefined;

Discussion:
Is there a way to use a codicon instead of an extension PNG? It feels out of place amongst built-in walkthroughs that can use a codicon. <img width="539" alt="CleanShot 2022-10-07 at 14 27 23 src="https://user-"cc since we chatted about this before
Conversation over at
Change:
} if (options?.refNames) { <del> if (options.refNames.length === 0) { args.push('--all'); } </del> args.push('--topo-order'); args.push('--decorate=full'); <del> args.push(...options.refNames); </del> <ins> // In order to avoid hitting the command line limit due to large number of reference // names (can happen when the `all` filter is used in the Source Control Graph view), // we are passing the reference names via stdin. spawnOptions.input = options.refNames.join('n'); args.push('--stdin'); </ins> } if (options?.path) { args.push('--', options.path); } <del> const result = await this.exec(args); </del> <ins> const result = await this.exec(args, spawnOptions); </ins> if (result.exitCode) { // An empty repo return [];

Discussion:
SCM Graph Filter from to (There are no results, is this a bug?) the view the view =results are shown for filter state but pill shows the state
Related
Keeping this issue scoped to the following as that is a great find that has to be addressed:
Pushed a change that should improve things, but will continue to look for a long-term fix.
Change:
return; } <ins> const selectionsBeforeRevert = textEditor.selections; </ins> await this._revertChanges(textEditor, selectedChanges); <ins> textEditor.selections = selectionsBeforeRevert; </ins> } private async _revertChanges(textEditor: TextEditor, changes: LineChange[]): Promise<void> {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.
We might just have to set the cursor in that position, should be simple. Would you like to submit a PR?
I can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..
Hi, I would like to work on this issue. I'll submit a PR soon.
Do we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.
Sounds good.
Change:
} private storeCachedViewContainersState(cachedViewContainers: ICachedViewContainer[]): void { <del> this.setPinnedViewContainers(cachedViewContainers.map(({ id, pinned, visible, order }) => (<IPinnedViewContainer>{ </del> <ins> this.setPinnedViewContainers(cachedViewContainers.map(({ id, pinned, badgeEnabled, visible, order }) => (<IPinnedViewContainer>{ </ins> id, pinned, <ins> badgeEnabled, </ins> visible, order })));

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --PR the ability to right-click on an activity-bar item to hide its "badge" of items needing attention (a source-control activity-bar item might display a count of changed files in a badge, for example). However this hiding does not persist across launches of VS Code. The state of this toggle should be persisted somehow - presumably in user settings.
Change:
} if (buildTasks.length === 1) { this.tryResolveTask(buildTasks[0]).then(resolvedTask => { <del> this.run(resolvedTask).then(undefined, reason => { </del> <ins> this.run(resolvedTask, undefined, TaskRunSource.User).then(undefined, reason => { </ins> // eat the error, it has already been surfaced to the user and we don't care about it here }); });

Discussion:
Issue Type: <bBug</bRecent update to 1.48.0 seems to have killed sorting the Run Build Task list by most recently used. In fact, the list doesn't appear to change order at all (not sorting lexicographically, either). VS Code version: Code 1.48.0 (, 2020-08-13T07:50:42.600Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ vscode-open-in-application1.0.5 cortex-debug0.3.7 cpptools0.29.0 cmake0.0.17 vscodeintellicode1.2.10 clang-format1.9.0 linkerscript1.0.1 </details<!-- generated by issue reporter --
To verify: Open a folder with build tasks, such as the VS Code repo. If you use the VS Code repo, in the change the of the task to simply be (no ). Run the Tasks: Run Build Task command Choose a build task and run it from that quick pick Run the Tasks: Run Build Task command again. Verify that the task you just ran shows at the top of the list in the recently used section. Repeat with another build task.
Verified in Version: 1.48.1 Commit: Date: 2020-08-18T17:06:48.722Z
Change:
ELECTRON="$VSCODE_PATH/@@NAME@@" CLI="$VSCODE_PATH/resources/app/out/cli.js" <del> ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@" exit $? </del>  No newline at end of file <ins> ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" $ARGS exit $? </ins>

Discussion:
As per, issue (closed), the command line arguments such as -h, should work with the current version of VS Code. But does not work as expected in normal ubuntu installation. Binary being used: /usr/bin/code -/usr/share/code/bin/code VSCode Version: Version 1.7.1 Commit Date 2016-11-03T13:46:46.244Z Shell 1.3.8 Renderer 52.0.2743.82 Node 6.5.0 OS Version: Distributor ID: Ubuntu Description: Ubuntu 16.04.1 LTS Release: 16.04 Codename: xenial Steps to Reproduce: code --user-data-dir=/ws/linux/config/vscode/ code --user-data-dir=/ws/linux/config/vscode/ --help code --user-data-dir=/ws/linux/config/vscode/ /var/logs None of the above shows any help or open path as expected.
Updates: After a short digging around, either the main executable at is ignoring other arguments, including --user-data-dir when is present. Or is supressing or not using the other args. When the bash startup script, is used, there is no effect of arguments including path to open as well as other args like --help. The user-data-dir is not created when is passed. Whereas, when the main executable () is used, it looks like the arguments are passed and processed correctly. path to open, --new-window, -r are working as expected. But i guess the absence of , is causing causing the writing back to starting shell fail. Following errors are shown when using main executable.
Strange. I just tried, but failed to reproduce. We'd need to debug the CLI code on your machine. Any chance that it's a VM you could send us?
Not a vm. But if there are switches or edits that i can do to enable trace, i can run with trace on and share the output. I also tried and used the version, same problem. Any chances that there might be a conflict with existing electron installation ?
Interesting. Could be. Try the insiders version, since it's a completely separate product:
I think i found the root cause, can you share your startup script, may be we are using different version that it is working on your end.

The script is shifting and throwing away all args when used as root to check --user-data-dir. Just submitted a pull request with changes that retains and passes the commandline args.
Great to know. Moving this to he should know the details of that script. Great work, thanks for the effort!
Fixed in
Verified: ignores . does not ignore it.
Change:
*--------------------------------------------------------------------------------------------*/ import { deepStrictEqual, ok, strictEqual } from 'assert'; <ins> import { userInfo } from 'os'; </ins> import { NullLogService } from 'vs/platform/log/common/log'; import { ITerminalProcessOptions } from 'vs/platform/terminal/common/terminal'; import { getShellIntegrationInjection, IShellIntegrationConfigInjection } from 'vs/platform/terminal/node/terminalEnvironment';

Discussion:
Type: <bBug</bThe terminal cannot be opened when multiple users use remote-ssh When I used Remote-SSH today, I found that the terminal could not be opened. After checking the log, I found the following error output: Since the terminal I use is , vscode-server copies my to , and the permission of this file belongs to me. As a result, the other users who use as the terminal cannot open the terminal when using Remote-SSH for no permission to overwrite this file. And I find that when the user uses bash, vscode-server does not copy to . Therefore, this bug does not exist when is used by all users VS Code version: Code 1.70.0 (, 2022-08-04T04:38:55.829Z) OS version: Darwin x64 20.6.0 Modes: Remote OS version: Linux x64 5.4.0-122-generic Remote OS version: Linux x64 5.4.0-122-generic <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ pythonsnippets1.0.2 vscode-language-pack-zh-hans1.70. jupyter-keymap1.0.0 remote-containers0.241.3 remote-ssh0.84.0 remote-ssh-edit0.80.0 material-icon-theme4.19.0 svg-preview2.8.3 jinja0.0.8 material-theme3.15.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
EDIT: I found the log... I encountered the same problem. When upgrading to 1.70 the zsh shell only opens for the first remote user...
You can find the error log in of , as shown below. <img width="1099" alt="" src="https://user-"After I rolled the software back to the previous version, the issue was solved.
Thx, I found the log also now.

Rolling back to 1.69.2 and disabling auto update of VSCode solves the problem currently... I hope the VSCode team will take care of this issue, for the next release
I tried also to find the line which is copying the file in the script, but was not really able to find it... I believe the command is hidden somewhere in the method
Thanks for the report, you can workaround this by disabling shell integration automatic injection with and then in your :
thanks, your workaround works!
yes thanks, I was having to go back to the previous release until sent me here!
This is fixed in that it will no longer block the terminal from being created, as called out in though we need to make sure that multiple users are able to write the same file. We could perhaps solve this by moving the zsh shell integration files into their own folder in the bundle and just use that?
is this workaround still valid or should we be waiting for an update in vs code?
it's fixed in insider's it's reopened bc of some complications that the fix has caused
Change:
} return themeData; } <ins> static fromStorageData(input: string): FileIconThemeData { try { let data = JSON.parse(input); let theme = new FileIconThemeData(); for (let key in data) { switch (key) { case 'id': case 'label': case 'description': case 'settingsId': case 'extensionData': case 'path': theme[key] = data[key]; break; } } return theme; } catch (e) { return null; } } toStorageData() { return JSON.stringify({ id: this.id, label: this.label, description: this.description, settingsId: this.settingsId, path: this.path, extensionData: this.extensionData }); } </ins> } interface IconDefinition {

Discussion:
It would be nice if icons would show up directly after starting the workbench instead of having to wait for the extension host to be ready. Similar to color themes where the data is stored in local storage, the icons data should also be stored so that the overall experience is smooth.
can we consider this for this milestone? I want to mark this "perf-startup" because the fact that the icons only "kick in" later after the UI is already done makes the entire editor appear like a website that needs to load icons later separately which is ugly. It also causes some ugly jumping for opened tabs. ! /cc
PR:
Change:
import { IConfigurationChangeEvent, IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { DEFAULT_EDITOR_MIN_DIMENSIONS } from 'vs/workbench/browser/parts/editor/editor'; import { DisposableStore } from 'vs/base/common/lifecycle'; <del> import { SIDE_BY_SIDE_EDITOR_BORDER } from 'vs/workbench/common/theme'; </del> <ins> import { SIDE_BY_SIDE_EDITOR_HORIZONTAL_BORDER, SIDE_BY_SIDE_EDITOR_VERTICAL_BORDER } from 'vs/workbench/common/theme'; </ins> import { AbstractEditorWithViewState } from 'vs/workbench/browser/parts/editor/editorWithViewState'; import { ITextResourceConfigurationService } from 'vs/editor/common/services/textResourceConfigurationService'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --There is a new color which can be used when we split an editor in group. The layout can be horizontal or vertical. Please support different border color settings for vertical and horizontal layouts. For example in the following vertical layout I don't need/want any border. It is easy to distinguish each editor. ! But it is hard to distinguish editors in horizontal layout without a border. !
Sounds reasonable, open for help for a meaningful small PR.
Verification: configure colors for the new theme colors and and verify they apply properly as advertised depending on the split in group layout
Change:
@IOpenerService private readonly _openerService: IOpenerService, @IEditorService private readonly _editorService: IEditorService, @IConfigurationService private readonly _configurationService: IConfigurationService, <del> @ITerminalService private readonly _terminalService: ITerminalService </del> <ins> @ITerminalService private readonly _terminalService: ITerminalService, </ins> ) { const baseLocalLinkClause = _platform === platform.Platform.Windows ? winLocalLinkClause : unixLocalLinkClause; // Append line and column number regex

Discussion:
The underline also isn't appearing <img width="676" alt="screen shot 2018-05-18 at 12 12 49 pm" src="https://user-"
I also encountered this problem on Ubuntu 16.04, underline is not displayed on std input , and std output for Terminal. Hope can be fixed. Version 1.24.1 Commit Date 2018-06-13T17:47:35.732Z Shell 1.7.12 Renderer 58.0.3029.110 Node 7.9.0 Architecture x64
Hi! After some testing I found that the problem (regarding tooltip location) seems to be that, when emits the event, the and properties of the fired instance are zero: ! I believe this is because the DOM element which fires the event is the rendering the character instead of some element with the size of the entire terminal (like the in the default renderer). In order to solve it, I  to and styles so the event don't target those objects and the becomes the , provider. do you think it is a good solution? I can make a PR, if you want. Edit: Those changes should be made on the package (And maybe this issue should be there also?)
Regarding the underline don't appearing I'm trying this solution , and it seems to work (I'm going to sleep right now, but tomorrow I'll make some testing). Do you think it's a feasible solution?
, we probably don't want to handle the tooltip location in since should just be providing all the info it has in the mouse event without making specific assumptions about how that info will be used. I'll let comment on the underline
I made some comments on the underline in that commit , looks pretty close to what we're after. I created to track this, a PR would be fantastic! You would also want to remove the line in that says link underlines are not supported.
Underline don't appearing was fixed in We should wait for 's 3.8.0 release in order to update and close this issue, right?
I've already pulled in your changes, we'll close this off when is merged.

Hmm, something is still a bit off, mousing over and pausing on the bottom few pixels will show the tooltip in the correct position but the pixels above will show the tooltip where it should be for the line above ! !
I still have no idea why this is happening but this is what I got so far: Target of the event in the expected behavior scenario: Target of the event in the unexpected behavior scenario:
PR out upstream which should fix this:
I can no longer reproduce.
Change:
import { IStringDictionary } from 'vs/base/common/collections'; import { IExtensionRecommendations } from 'vs/base/common/product'; import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; <del> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </del> import { IExtensionGalleryService, IGalleryExtension } from 'vs/platform/extensionManagement/common/extensionManagement'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; import { IProductService } from 'vs/platform/product/common/productService';

Discussion:
On the latest Stable or Insiders, the Copilot setting button does not show up in the Settings editor when the Copilot extension is disabled or not installed. ! removed the dependency on the assignment/experimentation service incorrectly, and ended up making it so that the feature was only available in OSS aka from-source builds. The main branch fix is available in The candidate PR is available in . [x] Set up a candidate PR
Change:
await terminal.assertEditorGroupCount(2); }); <del> it('should create new terminals in the active editor group via command', async () => { </del> <ins> it.skip('should create new terminals in the active editor group via command', async () => { </ins> await terminal.runCommand(TerminalCommandId.CreateNewEditor); await terminal.runCommand(TerminalCommandId.CreateNewEditor); await terminal.assertEditorGroupCount(1); }); <del> it('should create new terminals in the active editor group via plus button', async () => { </del> <ins> it.skip('should create new terminals in the active editor group via plus button', async () => { </ins> await terminal.runCommand(TerminalCommandId.CreateNewEditor); await terminal.clickPlusButton(); await terminal.assertEditorGroupCount(1); }); <del> it('should create a terminal in the editor area by default', async () => { </del> <ins> it.skip('should create a terminal in the editor area by default', async () => { </ins> await app.workbench.settingsEditor.addUserSetting('terminal.integrated.defaultLocation', '"editor"'); // Close the settings editor await app.workbench.quickaccess.runCommand('workbench.action.closeAllEditors');

Discussion:
See the 2nd attempt for Linux x64:
Ended up disabling these:
More of them are failing: 1st attempt here: and also 1st attempt here: Will start by disabling three tests as it looks like the tests just got stuck at that point.
Tracking in /duplicate
Change:
} ); <del> widget.onDidChangeModel( (model) => { if (model) { this.onNotebookEditorWidgetAdded(widget, model?.uri); </del> <ins> this._onDidChangeModelListener?.dispose(); // listen to view model change as we are searching on both inputs and outputs this._onDidChangeModelListener = widget.onDidAttachViewModel( () => { if (widget.hasModel()) { this.onNotebookEditorWidgetAdded(widget, widget.textModel.uri); </ins> } } ); } private onModelAdded(model: ITextModel): void {

Discussion:
Type: <bBug</ba jupyter notebook, create a python cell the cell the notebook two earch results the notebook bug One of the search results goes away <img width="1179" alt="Screenshot 2023-04-25 at 11 09 04 AM" src="https://user-"Making any changes to the search term makes both search results show again VS Code version: Code - Insiders 1.78.0-insider (Universal) (, 2023-04-25T05:41:22.331Z) OS version: Darwin x64 22.4.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
readonly index: number; readonly item: IQuickPickItem; readonly saneLabel: string; <ins> readonly saneSortLabel: string; </ins> readonly saneMeta?: string; readonly saneAriaLabel: string; readonly saneDescription?: string;

Discussion:
Create or Checkout a PR Click on the branch indicator in the status bar Type Observe that doesn't show in top position Not sure what changed, but this used to work reliably until today, this was the main way I used to go back to the branch: <img width="1078" alt="image" src="https://user-"
We have an icon to the quick pick items but I would like to think that this did not break search. Will investigate.