jiebi/CodeConvo huggingface dataset:
Change:
remoteSaving: 'notebook.experimental.remoteSave', gotoSymbolsAllSymbols: 'notebook.gotoSymbols.showAllSymbols', scrollToRevealCell: 'notebook.scrolling.revealCellBehavior', <del> anchorToFocusedCell: 'notebook.scrolling.anchorToFocusedCell' </del> <ins> anchorToFocusedCell: 'notebook.scrolling.experimental.anchorToFocusedCell' </ins> } as const; export const enum CellStatusbarAlignment {

Discussion:
Testing This setting seems like overkill to me and there is a good behavior we should be aiming towards which is notebook.scrolling.anchorToFocusedCell = auto. You could also do something clever like disable the anchoring when a user starts scrolling, and when they focus a cell or type it re-enables the anchoring. I rarely use notebooks but to me this seems like a setting that will see very low usage and is not worth the cost of an extra setting imo. Note that anchorToFocusedCell = auto doesn't work as expected currently, the setting only seems to do anything after I scroll: !
I can change the setting to be experimental to give more leniency to change/remove it, but the behaviors are very different, so we'd like to give users a way to both experiment and revert back in case we missed some case of bad behavior
I like the idea of using experimental and seeing how many users change it to see if it's worth a setting

Testing We don't normally use "false" and "true" as strings, so this looks wrong beside all my other settings: !
Change:
import { IAccessibleViewService } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; import { InlineCompletionsController } from 'vs/editor/contrib/inlineCompletions/browser/inlineCompletionsController'; <del> import { alert } from 'vs/base/browser/ui/aria/aria'; </del> const accessibleViewMenu = { id: MenuId.AccessibleView,

Discussion:
cc and got some feedback that it could be useful to alert when a completion is accepted. I can imagine why this would be helpful, but also, the user has taken the action and knows what the completion is, so wonder if this would just add noise.
IMO, this is not necessary b/c users take the accept gesture; thus, the event result is very obvious.
Agree, it's also clear because the user's focus is in the editor right where the suggestion was inserted.
Will wait for more feedback, but seems likely we'll close this.
I agree, however that announcement is currently present if I accept a suggestion from the accessible view. I wonder if it should be removed there for consistency. There is a change of context that happens because the accessible view closes and focus goes to the editor, which I believe serves as a confirmation.
it seems like I should verify that a screen reader alert does not happen when accepting a completion in the "accessible view". Which accessible view is this?
Correct, the inline completions accessible view, so trigger an inline completion, then use alt+f2
Change:
} onClose(): void { <del> this._gettingStartedPage.focus(); </del> <ins> if (this._currentStepIndex > -1) { const currentStep = this._activeWalkthroughSteps[this._currentStepIndex]; this._gettingStartedPage.makeCategoryVisibleWhenAvailable(this._focusedItem.id, currentStep.id); } </ins> } }

Discussion:
Testing a walkthrough view through steps with arrow keys the a11y view with alt+F2 then close with escape :bug: focus goes to default starting point instead of back to the step
you should be able to use the parameter to accomplish this as long as you know how to set the focus correctly
Change:
diagnostics.push(new Diagnostic(range, dataUrlsNotValid, DiagnosticSeverity.Warning)); } <del> if (!hasScheme && !info.hasHttpsRepository) { </del> <ins> if (!hasScheme && !info.hasHttpsRepository && context !== Context.ICON) { </ins> const range = new Range(document.positionAt(begin), document.positionAt(end)); const message = (() => { switch (context) { <del> case Context.ICON: return relativeIconUrlRequiresHttpsRepository; </del> case Context.BADGE: return relativeBadgeUrlRequiresHttpsRepository; default: return relativeUrlRequiresHttpsRepository; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: macOS 12.6.2 Steps to Reproduce: an extension and specify a relative path to an in the in png format, and specify repository as . (Our repository is private) get a warning , despite the icon showing correctly in the marketplace and the VS Code extension manager (We also have images in our that we hosted externally. Our repository is private after all). Extension:
I get the same warning ! despite my fields being defined as Source: Interestingly the icon shows up in the marketplace just fine. !
I see the icon is served from the CDN now and we can remove the warning about the relative icon path. What about badges in the and images in the README markdown, are these also served from CDN?
Those are all served from the raw GitHub routes, this is why vsce needs to know what repository hosts the sources.
But the icon isn't, not anymore at least... Our repo is private, the icon works just fine and is uploaded along with the vsix and hosted in some CDN. Images in the readme are indeed served directly so will require this check or an absolute URLs.
Ah! This is just the workbench linter. I also forgot that we actually show the icons served directly from the MP, not GH. Sorry about the confusion, thanks for following up This warning is unnecessary by now, let's remove it.
Change:
import * as collections from 'vs/base/common/collections'; import * as glob from 'vs/base/common/glob'; import * as paths from 'vs/base/common/paths'; <del> import * as strings from 'vs/base/common/strings'; </del> import uri from 'vs/base/common/uri'; import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace'; import { IPatternInfo, IQueryOptions, IFolderQuery, ISearchQuery, QueryType, ISearchConfiguration, getExcludes, pathIncludedInQuery } from 'vs/platform/search/common/search';

Discussion:
VSCode Version: 1.17.2 OS Version: Win 7 SP 1 Steps to Reproduce: Access search tab Type a word to search for Under "files to include", type ..siblingPath Hit enter Expected: any files under ..siblingPath containing word/pattern are shown. Actual: get "No results found in ..siblingPath". Works fine if absolute path used, or relative path below the current directory. This is very useful when you have a test project open but the interesting source files are in a sibling directory.
will probably work for now.
Indeed it does, thanks for that.
Change:
public commitPartially(): void { this.activeModel?.commitInlineCompletionPartially(); <del> this.activeController?.value?.contextKeys.inlineSuggestionJustCommitted.set(true); </del> } public commit(): void { this.activeModel?.commitInlineCompletion(); <del> this.activeController?.value?.contextKeys.inlineSuggestionJustCommitted.set(true); </del> } public hide(): void {

Discussion:
(See attached recording) I have enclose it in new use cmd+left to go to start of line ghost suggestions get accepted https://user-
Change:
import { VIEWLET_ID as REMOTE } from 'vs/workbench/contrib/remote/browser/remoteExplorer'; import { VIEWLET_ID as SCM } from 'vs/workbench/contrib/scm/common/scm'; import { WebviewViewPane } from 'vs/workbench/contrib/webviewView/browser/webviewViewPane'; <del> import { checkProposedApiEnabled, isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; </del> <ins> import { isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; </ins> import { ExtensionMessageCollector, ExtensionsRegistry, IExtensionPoint, IExtensionPointUser } from 'vs/workbench/services/extensions/common/extensionsRegistry'; import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; import { KeybindingsRegistry, KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As you can see, the 'open editors' view has dynamic height according to its content. Can we customize our view( which in inside custom view container) height like that? !
Open editors has some custom code for doing this I believe this is not possible with custom views, and I think is a feature request against custom views thus forwarding to
Notes about proposal: Example
Example with the latest proposal
Change:
}; disposeOnDone.add(token.onCancellationRequested(() => this.cancelInput(true))); <del> disposeOnDone.add(this._editor.onDidBlurEditorWidget(() => this.cancelInput(false))); </del> <ins> disposeOnDone.add(this._editor.onDidBlurEditorWidget(() => this.cancelInput(!document.hasFocus()))); </ins> this._show();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.0-insider OS Version: Windows_NT x64 10.0. Steps to Reproduce: this snippet into a fresh VS Code buffer and make sure it's recognized as JavaScript: "use strict"; const foo = "abc"; (foo); the cursor onto an occurence of the identifier. F2 to rename and type . Don't hit Enter. Alt+Tab twice to switch to another window and back to VS Code. (Practical use case: Look for information in browser helping with deciding on the new name.) input focus of the text buffer is now lost. To regain the ability to continue typing into the buffer or to initiate a second renaming attempt with F2, I have to click on the buffer's tab. Furthermore, the text I entered into the little overlayed renaming textbox is gone. Suggestion: Keep overlayed renaming textbox alive when switching windows. If unwanted, at least make the buffer regain focus.
The rename box is designed to hide on focus lost but the editor should regain then
Change:
export class Extension implements IExtension { public enablementState: EnablementState = EnablementState.EnabledGlobally; <del> public readonly resourceExtension: IResourceExtension | undefined; </del> private galleryResourcesCache = new Map<string, any>();

Discussion:
the vscode repo extensions the Selfhost Test Runner extension, Install it the window extensions See the Selfhost Test Runner extension is not visible
I cannot reproduce the issue. I also tried on fresh user data directory. Can you please share more specific details of the steps you followed to reproduce the issue?
Oh, I see, workspace extensions don't show under if they're already installed, unlike other extensions. Maybe a slight oddity to fix if easy, will let you close it if not.
Hmm, that's not what I expected too. They should be shown always. I will fix that.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
Change:
// Wait the end of the ctor when all listeners have been hooked up. const element = document.createElement('iframe'); element.className = `webview ${options.customClasses || ''}`; <del> element.sandbox.add('allow-scripts', 'allow-same-origin', 'allow-forms', 'allow-pointer-lock'); </del> <ins> element.sandbox.add('allow-scripts', 'allow-same-origin', 'allow-forms', 'allow-pointer-lock', 'allow-downloads'); </ins> element.style.border = 'none'; element.style.width = '100%'; element.style.height = '100%';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2 to latest insiders OS Version: linux kernel 4.18 Steps to Reproduce: an extension, create a webview which uses FileSaver js library , to save something in a file from a "save" button within the webview sure you load the webview with the extension. In VSCode before 1.48, there was no problem The extension where I discovered the problem is , in the WarpScript . <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No It seems Chrome engine another layer to sandbox default security in the meantime, now allow-downloads is necessary within the iframe sandbox settings. PR coming soon.
PS: Reverting VSCode back to 1.47 make the same extension working great. That's what I did during a few weeks before digging into the problem.
Change:
ShellIntegrationCommandHistory = 'terminal.integrated.shellIntegration.history' } <ins> export const enum TerminalLogConstants { FileName = 'ptyhost' } </ins> export const enum PosixShellType { PowerShell = 'pwsh', Bash = 'bash',

Discussion:
This doesn't get logged when creating a terminal with trace logging on
I tried to do this like you and Jackson did for the on the branch merogge/remote-inv, but i'm still not seeing the logs anywhere when using remote WSL. Thoughts? Need this to investigate remote terminal reconnection bc when ssh'ing to localhost, I can't repro the issue and don't want to have to setup a vm.
maybe bc it's in platform instead of workbench it's not working? can't be in workbench though for the ptyService
instead of an output channel I think what we're after is something like this: Here: I thought that's what the LogLevelChannel was doing but maybe not? Or maybe that particular log service/channel type doesn't work on the server since it does in the shared process? !
Change:
copy(source: vscode.Uri, destination: vscode.Uri, options?: { overwrite?: boolean; }): Promise<void> { return this._proxy.$copy(source, destination, { ...{ overwrite: false }, ...options }).catch(ExtHostConsumerFileSystem._handleError); } <ins> isWritableFileSystem(scheme: string): boolean | undefined { const entry = this._schemes.get(scheme); if (entry) { return !entry.isReadonly; } return undefined; } </ins> private static _handleError(err: any): never { // generic error if (!(err instanceof Error)) {

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
const isPanelChat = typeof response !== 'string'; const responseContent = typeof response === 'string' ? response : response?.response.asString(); this._accessibilitySignalService.playSignal(AccessibilitySignal.chatResponseReceived, { allowManyInParallel: true }); <del> if (!response) { </del> <ins> if (!response || !responseContent) { </ins> return; } const errorDetails = isPanelChat && response.errorDetails ? ` ${response.errorDetails.message}` : ''; <del> status(responseContent + errorDetails); </del> <ins> status(renderStringAsPlaintext(responseContent) + errorDetails); </ins> } }

Discussion:
Have a response that contains references to code, e.g. : ! Start screen reader and click on the response. Notice how the full URLs are being read out aloud which are very long. Verbatim text: I think this stems from the fact that we just take the response as string here:
Btw I have a similar challenge for the text-to-speech integration where I am thinking about converting the markdown string to a plain text string using : But I did notice that this would remove some text, such as ordered list.
made a good point in our standup today: why are we not leveraging the HTML screen reader support for chat items but use ?
The HTML screen reader support requires users to enter different modes to navigate - browse/focus mode. Feedback from screen reader users suggested this is not user friendly. Users will examine content in detail in the chat accessible view, not here. Providing an overview of the response with aria alert is desired. This is similar to how sighted users see the response streaming in. Screen reader users press escape if they don't wish to hear the content.
I agree it's not good that it's reading the full URLs. A similar problem is here and my solution to that will be to remove those links and provide an alternate way of setting any keybindings which are undefined.
Potential verification found: I asked for the location of some code, and after Copilot finished typing out the response, it announced the entire response, including all the link text and full command IDs.
LGTM now. I might've forgotten to update something.
A screenshot of the text that was announced would help to know if this was fixed or not
nvm. The symbols are good but the URLs still expand !
unclear how this could be happening as I'm using
figured it out
It is still reading the complete path for me.
and the complete path is expected. what's not expected is these chars
going to see if I can repro on windows
does not reproduce for me on windows either . It makes no sense that this would happen - , we literally parse that stuff out. could you pls debug in oss here? !
I believe the issue is fixed now. I notice that when the announcement is read out that the links are now announced correctly. When I click on the response, the links are read with the Markdown formatting again, but I believe that this behaviour is out of scope of the issue.
Change:
*--------------------------------------------------------------------------------------------*/ import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; <del> import { extname } from 'vs/base/common/resources'; </del> <ins> import { extname, isEqual } from 'vs/base/common/resources'; </ins> import { URI } from 'vs/base/common/uri'; import { ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { Range } from 'vs/editor/common/core/range';

Discussion:
When I select "Open with..." on a code search file, I would have expected to see our search editor in there as well: ! Slightly related, I would probably expect an entry "Settings Editor" when opening a file with...
Change:
DataTransfers.RESOURCES, ]); <del> export function addExternalEditorsDropData(dataTransfer: VSDataTransfer, dragEvent: DragEvent) { if (dragEvent.dataTransfer && !dataTransfer.has(Mimes.uriList)) { </del> <ins> export function addExternalEditorsDropData(dataTransfer: VSDataTransfer, dragEvent: DragEvent, overwriteUriList = false) { if (dragEvent.dataTransfer && (overwriteUriList || !dataTransfer.has(Mimes.uriList))) { </ins> const editorData = extractEditorsDropData(dragEvent) .filter(input => input.resource) .map(input => input.resource!.toString());

Discussion:
Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-22T05:17:09.661Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. This is a follow up of Steps to Reproduce: the dnd sample: to the of some logs in : the extension multiple files to the dnd sample view, the uris in the data transfer are not split by line separators. // cc
Are you dragging from the VS Code file explorer view, or your operating system's file explorer?
Sorry forgot to mention, it's from VS Code file explorer
Can you check the actual value, not just the value printed by I debugged this and oddly while just prints: The actual value of is: In this case each file name is separated by a pair
Tested in: Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-23T05:16:43.681Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. It's still stored in one line: https://user- Is there anything I missed?
Thanks. Only happens on windows for me. Taking a look now
I don't see us setting anywhere and suspect chrome is generating it automatically. See in for how this may happen Also we are possibly hitting
Nice find. I couldn't find us setting anywhere either.
Verified on Windows and Linux in 1.69.0-insider (user setup) Commit: , 022-07-01T05:17:04.343Z
Change:
readonly onRequestAddInstanceToGroup = this._onRequestAddInstanceToGroup.event; private readonly _onDidChangeHasChildProcesses = this._register(new Emitter<boolean>()); readonly onDidChangeHasChildProcesses = this._onDidChangeHasChildProcesses.event; <del> private readonly _onDidRunText = this._register(new Emitter<void>()); readonly onDidRunText = this._onDidRunText.event; </del> <ins> private readonly _onDidExecuteText = this._register(new Emitter<void>()); readonly onDidExecuteText = this._onDidExecuteText.event; </ins> private readonly _onDidChangeTarget = this._register(new Emitter<TerminalLocation | undefined>()); readonly onDidChangeTarget = this._onDidChangeTarget.event; private readonly _onDidSendText = this._register(new Emitter<string>());

Discussion:
This configuration is probably pretty obscure (and I just had it due to testing) but: : , : the string into the terminal and shift+enter to get a newline buffer opens :bug:. The desc for says it's only after , so I don't think this is expected behavior (although I did just paste the selected text in the terminal manually).
did you happen to have enabled? that could explain what you describe, if so.
I don't have enabled.
Change:
}); } async run(accessor: ServicesAccessor, ...args: any[]) { <ins> announceChatCleared(accessor); </ins> await clearChatEditor(accessor); } });

Discussion:
Reported by Use or as a SR user. there's no indication that that has succeeded. We could alert with info or use an audio cue
I don't see the chat clear history action in core, so we'd need to do this in the extension. There's a clear input history, though I don't think we want to alert for that case.
Actually, found it
Change:
{ markdown: new MarkdownString(localize('immediateTrustRequestLearnMore', "If you don't trust the authors of these files, we do not recommend continuing as the files may be malicious. See [our docs](https://aka.ms/vscode-workspace-trust) to learn more.")) } ] }, <del> buttons: buttons.map(button => { </del> <ins> buttons: buttons.filter(b => b.type !== 'Cancel').map(button => { </ins> return { label: button.label, run: () => button.type

Discussion:
Testing Testing with the native dialog on mac and seeing two cancel buttons when I am asked for workspace trust. This occurred when I did the following steps a trusted workspace the command palette to change to change that workspace to untrusted the window <img width="1521" alt="Screenshot 2023-02-21 at 10 59 05 AM" src="https://user-"after clicking "cancel" it then showed this error prompt: <img width="1728" alt="Screenshot 2023-02-21 at 10 59 21 AM" src="https://user-"
Ok I tried to reproduce this issue again following the steps I outlined above and it didn't work so feel free to close the issue if it doesn't come up for you.
Good catch, looking at the code I see that this might happen.