jiebi/CodeConvo huggingface dataset:
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'vscode' { // https://github.com/microsoft/vscode/issues/193077 @alexdima /** * Represents a {@link TextEditor text editor}'s {@link TextEditor.options options}. */ export interface TextEditorOptions { /** * The size in spaces a tab takes. This is used for two purposes: *  - the rendering width of a tab character; *  - the number of spaces to insert when {@link TextEditorOptions.insertSpaces insertSpaces} is true *    and `indentSize` is set to `"tabSize"`. * * When getting a text editor's options, this property will always be a number (resolved). * When setting a text editor's options, this property is optional and it can be a number or `"auto"`. */ tabSize?: number | string; /** * The number of spaces to insert when [insertSpaces](#TextEditorOptions.insertSpaces) is true. * * When getting a text editor's options, this property will always be a number (resolved). * When setting a text editor's options, this property is optional and it can be a number or `"tabSize"`. */ indentSize?: number | 'tabSize'; } } </del>

Discussion:
This API adds as a property to
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
To verify, you would need to write an extension which gets or sets the option on the current active editor. Here is the description: (it has an effect only when and defines the number of spaces that make up an indent)
Setting this is not working for me. I run this code in a command and nothing changes. But it works as a getter <img width="84" alt="image" src=""
This works for me: I the following code to the TS built-in extension: I opened a .js file which was configured with insert spaces: true (it said Spaces: 4) after 2 seconds it changes to: <img width="189" alt="image" src=""Note that indentSize can't be set if insertSpaces:false, it only makes sense when insertSpaces:true
aside from turning , to get this working in a file that already uses tabs, I had to run in the file first
Change:
includeCompletionsWithClassMemberSnippets: config.get<boolean>('suggest.classMemberSnippets.enabled', true), includeCompletionsWithObjectLiteralMethodSnippets: config.get<boolean>('suggest.objectLiteralMethodSnippets.enabled', true), autoImportFileExcludePatterns: this.getAutoImportFileExcludePatternsPreference(preferencesConfig, vscode.workspace.getWorkspaceFolder(document.uri)?.uri), <del> // @ts-expect-error until 5.3 #56090 </del> preferTypeOnlyAutoImports: preferencesConfig.get<boolean>('preferTypeOnlyAutoImports', false), useLabelDetailsInCompletionEntries: true, allowIncompleteCompletions: true,

Discussion:
Tracks shipping TypeScript 5.5 as the bundled version of ts:
Picked up 5.5.2 To verify: Open a TS file In the language status item, confirm that TS 5.5.2 is used (make sure you are using VSCode's version of typescript, not the workspace version)
Change:
} override matches(otherInput: EditorInput | IUntypedEditorInput): boolean { <del> return super.matches(otherInput) || otherInput instanceof KeybindingsEditorInput; </del> <ins> return otherInput instanceof KeybindingsEditorInput; </ins> } override dispose(): void {

Discussion:
set up two panes open a diff editor in the left pane open the keybindings UI in the left pane open another file in the right pane click on a modified file in the SCM ui the diff editor doesn't get opened or revealed, making the click appear to be a no-op ( this doesn't repro in stable ) https://user-
Change:
public get title(): string { let title = this.terminalInstances[0].title; for (let i = 1; i < this.terminalInstances.length; i++) { <del> title += `, ${this.terminalInstances[i].title}`; </del> <ins> if (this.terminalInstances[i].title) { title += `, ${this.terminalInstances[i].title}`; } </ins> } return title; }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.29.0-insider () OS Version: Windows 10 October 2018 update (x64) Steps to Reproduce: the terminal panel on the split icon to split the terminal panel The tab terminal select widget briefly shows before showing : ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Change:
white-space: pre; } /* When wordwrap turned on, force it to pre-wrap */ <del> #container div.output_container .word-wrap span { </del> <ins> #container div.output_container .word-wrap { </ins> white-space: pre-wrap; } #container div.output>div {

Discussion:
[ ] Notebooks (.ipynb files) [X] Interactive Window and/or Cell Scripts (.py files with #%% markers)Turn on in Turn on in Open an interactive window and run the following code snippet Version: 1.89.0 Commit: Date: 2024-05-01T02:08:25.066Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Linux x64 6.8.0-76060800daily20240311-generic v2024.4.0 Python v3.12.1 No response No response Local
Change:
if (modifiedBaseRange.canBeCombined && state.isEmpty) { result.push( state.input1 && state.input2 <del> ? command(localize('removeBoth', "$(error) Remove Both"), async () => { </del> <ins> ? command(localize('removeBoth', "Remove Both"), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,

Discussion:
Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used—not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width="269" alt="CleanShot 2022-09-27 at 11 42 19 src="https://user-"<img width="244" alt="CleanShot 2022-09-27 at 11 43 33 src="https://user-"
I can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.
Why don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.
Change:
precondition: TerminalContextKeys.processSupported }); } <del> async run(accessor: ServicesAccessor) { return accessor.get(ITerminalService).activeInstance?.changeColor(); </del> <ins> async run(accessor: ServicesAccessor, resource: unknown) { const terminalService = accessor.get(ITerminalService); const castedResource = URI.isUri(resource) ? resource : undefined; const instance = terminalService.getInstanceFromResource(castedResource) || terminalService.activeInstance; instance?.changeColor(); </ins> } }); registerAction2(class extends Action2 {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
previewStart = assertIsDefined(this.editor.getPosition()); } <ins> const endPosition = new Position(previewStart.lineNumber, previewStart.column + text.length); </ins> this.editor.executeEdits(EditorDictation.ID, [ EditOperation.replace(Range.fromPositions(previewStart, previewStart.with(undefined, previewStart.column + lastReplaceTextLength)), text) ], [ <del> Selection.fromPositions(new Position(previewStart.lineNumber, previewStart.column + text.length)) </del> <ins> Selection.fromPositions(endPosition) </ins> ]); if (isPreview) {

Discussion:
Testing I'm not sure what the correct fix is but if the text was generated outside of the view, I would image the editor would scroll horizontally as text gets inserted. (same as typing in the editor). !
Yes, very good catch.
Change:
private async getWebviewContents(): Promise<string> { const version = Date.now().toString(); const settings = { <del> isMac: isMac(), </del> src: await this.getResourcePath(this.webviewEditor, this.resource, version), };

Discussion:
Extension version: v0.29.2 VSCode Version: 1.59.0 OS: GitHub editor / mac Steps to Reproduce: "" on the right side image, it zooms in ctrl down and the icon turns into a "zoom out" icon Expected outcome: Zoom out Actual outcome: You see a menu with "Cut", "Copy", "Paste"
The image preview editor is provided by VS Code core (instead of this extension), so moving this issue to VS Code.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.509 --- <!-- score: 0.493 --<!-- potentialduplicatescomment --
maybe a safari issue?
In Chrome, ctrl-click only shows the menu In Safari, ctrl-click zooms out and also shows the menu
Thanks for the additional details. In Edge, I get only the zoom out.
Working fine in firefox.
Issue exists in Safari browser, how can I fix this
yes it works in safari , but the the cursor remains zoom out cursor even when I don't press control, it doesn't change back to + symbol
Can i work on this??
if you didn't work to zoom in or zoom out you use simply method on keybord key ctrl + or ctrl - .
I really want to be VS Code contributor. I try to working on this task since yesterday. I hope I will find the fix and my first meeting with VSC will end with success ;)
Zoom in Works fine in Safari, however zoom out works but the magnifying glass disappears and I had to double click (not sure if this is intentional) to get the image to properly zoom out while zoom in only take one click.
Change:
assert.deepStrictEqual(single.collectDiff(), [ { op: TestDiffOpType.Update, <del> item: { extId: new TestId(['ctrlId', 'id-a']).toString(), expand: TestItemExpandState.Expanded }, }, { op: TestDiffOpType.Update, </del> item: { extId: TestId.fromExtHostTestItem(oldAB, 'ctrlId').toString(), item: { label: 'Hello world' } }, }, {

Discussion:
My extension's has a that replaces all root items whenever it is called. It calls the same function that creates the items upon extension activation. After the is run, I've verified that the correct root items have been created with set to . However, when the user tries to expand the item, the is not called on that item and no children are created. This simple extension demonstrates the bug: Steps to Reproduce: the extension above. It should immediately activate after the window refresh. the text explorer and observe the root item. Expand it to reveal two children. the Output channel to see that the resolve handler was called. the refresh icon and verify that "Refreshing" was written to the Output channel. to expand the new root. Verify that the resolve handler was never called. VS Code Version: 1.87.2
Thanks for triaging this Do you anticipate this being resolved before the next release? If not, do you have a recommended workaround I should try to implement in my extension?
A fix for this would be highly appreciated. This bug is a major annoyance for my daily work I started creating a new issue for , but googled first and found this one instead I even "fixed" the issue by adding the following line into the refreshHandler Like so: testController.refreshHandler = () ={ replaceRootTestItems(testController); ((item) =testController.resolveHandler(item)); };
Thanks for the tip I'll give that a try as a workaround.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Thanks!
Thanks for fixing this!
Change:
import * as assert from 'assert'; import { Platform } from 'vs/base/common/platform'; import { TerminalLinkHandler } from 'vs/workbench/parts/terminal/electron-browser/terminalLinkHandler'; <ins> import { IWorkspace, WorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import URI from 'vs/base/common/uri'; import * as path from 'path'; import * as sinon from 'sinon'; </ins> class TestTerminalLinkHandler extends TerminalLinkHandler { public get localLinkRegex(): RegExp { return this._localLinkRegex; } <ins> public preprocessPath(link: string): string { return this._preprocessPath(link); } </ins> } class TestXterm {

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with "./". Many build systems and tools output file paths relative to the directory the command was run, without the leading "./", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in "" Is there a reason why relative paths of this form (e.g. no leading "./") are not included?
The reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.
I'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:
Nice. I'll write a PR...
That would be awesome :+1:
Fixed in
Change:
private getCachedRecommendations(): IStringDictionary<number> { let storedRecommendations = JSON.parse(this.storageService.get(recommendationsStorageKey, StorageScope.GLOBAL, '[]')); <del> if (Array.isArray<string>(storedRecommendations)) { </del> <ins> if (Array.isArray(storedRecommendations)) { </ins> storedRecommendations = storedRecommendations.reduce((result, id) => { result[id] = Date.now(); return result; }, <IStringDictionary<number>>{}); } const result: IStringDictionary<number> = {};

Discussion:
What is the reasoning behind not allowing via the Monaco standalone editor checks? It seems to be valid ES6 when I look at where it is defined:
idk - requires at least edge 14, unsure what our edge minimum version is:
Looking at the compat tables, I think it should be safe to use it. I guess it must have been a left-over from the IE era. I don't remember adding any rule like this, so I don't know where to begin looking to remove it. Leaving it to you .
I opened to do this and it has the advantage that we can get rid of another file in our folder () which actually even seems to have the wrong signature compared to TS. According to , Edge 13 has very low usages and Edge 14 is out since 2016: !
Unsure how and are connected. Or is this two clean-ups in one? I have the latter because for the longest time there was a TS bug which would remove type info from arrays after checking E.g If that's now fixed, I am very happy with removing
ah good to know, I just checked both in our code and the playground and I see that this no longer seems to be the case: ! I will go ahead and merge my PR then.
it
Change:
if (this.isBodyVisible()) { this.updateSize(); if (this.list) { <ins> const lastFocusIndex = this.list.getFocus()[0]; // Check whether focused element was removed const needsRefocus = lastFocusIndex && !this.elements.includes(this.list.element(lastFocusIndex)); </ins> this.list.splice(0, this.list.length, this.elements); this.needsRefresh = false; <ins> if (needsRefocus) { this.list.focusNth(Math.min(lastFocusIndex, this.list.length - 1)); } </ins> } } else { this.needsRefresh = true;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When doing a 'remove breakpoint' from the 'Breakpoints' pane, interactively, or via cmd-backspace/debug.removeBreakpoint, the list UI selection is emptied, or left at the top. PLEASE PLEASE select the item right after the breakpoint that was just deleted so it's reasonably easy to delete a series of breakpoints but not all of them. Extra credit: It would be great if I could multi select that list and just do a 'remove breakpoint' command to apply all at once.
This is a fair request. We accept PRs that fix this. Code pointer In case nobody tackles this in the near future I can also look into this. Thanks!
, I created PR . With this change, the cursor should now move to the next breakpoint after removing the focused breakpoint. About multi-select, right now the focused breakpoint is removed, the one you see when you press up/down arrow keys, not the selected, the one you click on. Therefore, if something like this were implemented, "Remove Breakpoint" should remove selected breakpoints. But what would happen with the focused breakpoint?
To verify: Have multiple breakpoints in the breakpoint view Remove a breakpoint via keboard (delete button) Make sure the focus is now on the neighbor breakpoint and you can remove it also via keyboard.
Change:
//#region ISerializableView <del> private _onDidChange = this._register(new Emitter<IViewSize | undefined>()); </del> <ins> protected _onDidChange = this._register(new Emitter<IViewSize | undefined>()); </ins> get onDidChange(): Event<IViewSize | undefined> { return this._onDidChange.event; } element!: HTMLElement;

Discussion:
Code mac, have custom title bar in bar is not zooming in like the rest of the workbench To make the custom title bar accessible it needs to be zoomable. fyi
in general we've never done this. in fact on Windows we don't zoom in if the menubar is not present since the native title bar would not zoom. its up to the OS to decide the scale of the title bar. however, I do see a case to update the conditions if the new command center is present. what are your thoughts? further thing to consider. we can zoom in, but zooming out (below 1 zoom level) is not an option because the window controls have a minimum size.
I agree with you, and as we put more VS Code items in the title area I see a clear case to support zoom. Since the title area will feel more and more like an integral part of VS Code - and thus it should behave like the rest. Not being able to zoom out is fine imho. I feel that is the corner case. might also have thoughts, since we both noticed this bug when I was demoing the title bar search yesterday.
I think we need to work with Electron to also then zoom the native window controls, otherwise it looks like this: !
we can zoom in the controls, we just cannot zoom out, so that can be updated though the black bar is a separate issue that makes it look worse
1.67.2 TitleBar ! 1.68 TitleBar ! The new version is so small that it's hard to click
Agreed. Noticed this too after updating to v1.68. I use zoom : -1 but the title bar is still big and not zoomed out like the rest of the content
I have verified that the custom title bar can now we zoomable - thanks for that As you said zoom out is not supported which is fine, however on zoom out, the title bar does not change size but gets blurry. Like the browser anti aliasing rendering gets broken. Let me know if you would like me to file a new issue for this.
hmm yes, probably the way we implement counter zooming gives us this behavior, I don't think this is new however, nor do I think there is an easy fix for that. Would you mind verifying on stable for your machine?

If it is new, I would like a separate issue to investigate.
I can reproduce on stable. So I will not file an issue. If you still need one just let me know. Thanks!
Change:
this.modal = this.container.appendChild($(`.monaco-dialog-modal-block${options.type === 'pending' ? '.dimmed' : ''}`)); this.shadowElement = this.modal.appendChild($('.dialog-shadow')); this.element = this.shadowElement.appendChild($('.monaco-dialog-box')); <ins> this.element.setAttribute('role', 'dialog'); </ins> hide(this.element); // If no button is provided, default to OK

Discussion:
From Get a modal dialog in the web Notice how you can nicely focus any of the buttons, however the content of the dialog message is never read out, thus the dialog is not accessible. How this should work: Dialog should have an aria label and have focus It shuld use active descendent to let the screen reader know that focus is passed to one of the buttons
I am using the button widgets, are notifications not accessible either or are they doing something special?
Can you clarify what you mean exactly? Notifications announce themselves as ARIA alert when they open:
I misread the initial issue, I thought the bug was that the buttons were not read, not the actual message.
Thanks for fixing, let's add a bug label so we get this verified.