jiebi/CodeConvo huggingface dataset:
Change:
templateDisposables.add(new CellFocusPart(container, focusSinkElement, this.notebookEditor)), templateDisposables.add(new CellDragAndDropPart(container)), templateDisposables.add(scopedInstaService.createInstance(CellContextKeyPart, this.notebookEditor)), <del> ], [ </del> <ins> ]; const { cellExecutePrimary, cellExecuteToolbar } = this.notebookEditor.creationOptions.menuIds; if (cellExecutePrimary && cellExecuteToolbar) { contentParts.push(templateDisposables.add( scopedInstaService.createInstance(RunToolbar, this.notebookEditor, contextKeyService, container, runButtonContainer, cellExecutePrimary, cellExecuteToolbar) )); } const cellParts = new CellPartsCollection(DOM.getWindow(rootContainer), contentParts, [ </ins> titleToolbar, templateDisposables.add(scopedInstaService.createInstance(BetweenCellToolbar, this.notebookEditor, titleToolbarContainer, bottomCellToolbarContainer)) ]);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (only the jupyter and python extensions enabled) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.94.0-insider (user setup) Commit: Date: 2024-09-16T05:03:40.122Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: I restarted VSCode to install the latest update (above), and now python interactive sessions do not print output of cells in the interactive window. After running a cell in a interactive session: Using the jupyter extension, one can see that the variables are created in memory, but there is no output in the interactive window. Tested with a jupyter notebook, output is correctly printed below the cells: ! Output of "window" after running a single cell in an interactive session: <details<summaryShow output (large)</summary</details
As clarification: nothing is shown in the interactive window, not just output "input" cells are not shown either Only the "Connected to kernel", "restarting kernel" or "kernel restarted" messages
likely a regression from
Same thing happened to me. Though the jupyter panel shows the variables created by running the code, the interactive window shows nothing. (see image below) !
actually caused by , but only because we are creating a menu with an undefined ID by overriding a type restriction here:
Change:
// loop through all variables occurrences in 'value' const replaced = value.replace(AbstractVariableResolverService.VARIABLE_REGEXP, (match: string, variable: string) => { <ins> // disallow attempted nesting, see #77289 if (variable.includes(AbstractVariableResolverService.VARIABLE_LHS)) { return match; } </ins> let resolvedValue = this.evaluateSingleVariable(match, variable, folderUri, commandValueMapping);

Discussion:
Apparently resolving a string like will work but it will leave the last curly brace. We should disallow this case or throw an error, etc. See
Still seeing some odd behavior (although this may be expected) Repro MacOs : new terminal Bug In the terminal, see: This does not happen if I use a setting such as
Looks like that's a side effect of 'breaking' the path. Nested variables are just no longer interpolated, it's left as:
are those side effects you listed above intended side effects of the change? If so, I see the same thing on codespaces and we can just leave this issue verified. Otherwise, should the issue be moved to the next milestone?
Yes, it's intended that variables that have nested segments are no longer replace. Previously it would have resulted in a malformed string.
Change:
// links [/{[^}]+}/, 'string.target'], <del> [/(!?[)((?:[^]]|@escapes)+)(]([^)]+))/, ['string.link', '', 'string.link']], [/(!?[)((?:[^]]|@escapes)+)(])/, 'string.link'], </del> <ins> [/(!?[)((?:[^]]|@escapes)*)(]([^)]+))/, ['string.link', '', 'string.link']], [/(!?[)((?:[^]]|@escapes)*)(])/, 'string.link'], </ins> // or html { include: 'html' },

Discussion:
Empty alt text on images is valid markdown, however it doesn't get highlighted correctly: !
Change:
data.extensionDisposables = dispose(data.extensionDisposables); const updateEnablement = async () => { <del> let isDisabled = false; </del> <ins> let disabled = false; let deprecated = !!extension.deprecationInfo; </ins> if (extension.state === ExtensionState.Uninstalled) { <del> isDisabled = !!extension.deprecationInfo || !(await this.extensionsWorkbenchService.canInstall(extension)); </del> <ins> disabled = deprecated || !(await this.extensionsWorkbenchService.canInstall(extension)); </ins> } else if (extension.local && !isLanguagePackExtension(extension.local.manifest)) { const runningExtensions = await this.extensionService.getExtensions(); const runningExtension = runningExtensions.filter(e => areSameExtensions({ id: e.identifier.value, uuid: e.uuid }, extension.identifier))[0]; <del> isDisabled = !(runningExtension && extension.server === this.extensionManagementServerService.getExtensionManagementServer(toExtension(runningExtension))); </del> <ins> disabled = !(runningExtension && extension.server === this.extensionManagementServerService.getExtensionManagementServer(toExtension(runningExtension))); </ins> } <del> data.root.classList.toggle('disabled', isDisabled); </del> <ins> data.element.classList.toggle('deprecated', deprecated); data.root.classList.toggle('disabled', disabled); </ins> }; updateEnablement(); this.extensionService.onDidChangeExtensions(() => updateEnablement(), this, data.extensionDisposables);

Discussion:
Testing When I run a search for "deprecated" I see a large list of extensions that are being deprecated. I also see that each extension uses it's own ways to indicate that the extension is deprecated: prefix prefix sufix sufix Given that we control the list of deprecated extensions, and we have several established UI elements I am wondering if we could create a more unified and consistent look for all the deprecated extensions: In the extensions list, add a visual indicator in the upper left hand corner of the icon (similar to pre-release) In the extension details page, have a "deprecated" pill/badge after the name (similar to the pre-release and preview)
Another idea would be strike out the title just like we strike out in code editor.
any suggestions?
I like the strike-through on the title idea, it's simple (even though we already use the warning icon): <img width="1138" alt="CleanShot 2022-05-31 at 12 40 26 src="https://user-"
<img width="1378" alt="image" src="https://user-"
FYI
looks nice :)
Change:
import * as assert from 'assert'; import { Range } from 'vs/editor/common/core/range'; import { RangeMapping } from 'vs/editor/common/diff/rangeMapping'; <del> import { LinesSliceCharSequence, getLineRangeMapping } from 'vs/editor/common/diff/defaultLinesDiffComputer/defaultLinesDiffComputer'; </del> <ins> import { getLineRangeMapping } from 'vs/editor/common/diff/defaultLinesDiffComputer/defaultLinesDiffComputer'; </ins> import { OffsetRange } from 'vs/editor/common/core/offsetRange'; <ins> import { LinesSliceCharSequence } from 'vs/editor/common/diff/defaultLinesDiffComputer/linesSliceCharSequence'; </ins> suite('lineRangeMapping', () => { test('1', () => {

Discussion:
These moves could be one: ! And this move could be bigger: ! (click on "use latest dev" to verify a future bug-fix)
Change:
import { CommentCommandId } from 'vs/workbench/contrib/comments/common/commentCommandIds'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { AudioCue } from 'vs/platform/audioCues/browser/audioCueService'; <del> import { AccessibleNotificationEvent, IAccessibilityService, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </del> <ins> import { AccessibleNotificationEvent, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> export class EditorAccessibilityHelpContribution extends Disposable { static ID: 'editorAccessibilityHelpContribution';

Discussion:
Testing It doesn't seem to matter what I set the new settings to. They are never mentioned in the editor accessbility help. ! !
By design, you have to enable screen reader mode to see this
Maybe we shld also include it when not in screen reader mode?
Might be worth updating the TPI then, since I assumed it should always be there. The language seems backwards: <img width="478" alt="image" src=""
It also doesn't mention the settings, and my understanding is that if the settings are disabled, then the settings will take effect. I have those still turned on.
The reason I didn't mention those here is they're linked to in the ones I do mention, so a user will discover them.
I will use this issue to track making sure these show up in the help dialog regardless of screen reader optimized mode
Change:
// set the selection to the clicked line number if (e.target.type === MouseTargetType.GUTTER_LINE_NUMBERS) { const currentSelections = this.editor.getSelections(); <del> const containsSelection = currentSelections?.some(selection => selection.containsPosition({ lineNumber, column: 1 })); </del> <ins> const lineRange = { startLineNumber: lineNumber, endLineNumber: lineNumber, startColumn: 1, endColumn: model.getLineLength(lineNumber) + 1 }; const containsSelection = currentSelections?.some(selection => !selection.isEmpty() && selection.intersectRanges(lineRange) !== null); </ins> if (!containsSelection) { <del> const selection = { startLineNumber: lineNumber, endLineNumber: lineNumber, startColumn: 1, endColumn: model.getLineLength(lineNumber) + 1 }; this.editor.setSelection(selection, TextEditorSelectionSource.PROGRAMMATIC); </del> <ins> this.editor.setSelection(lineRange, TextEditorSelectionSource.PROGRAMMATIC); </ins> } }

Discussion:
a word on a line Markdown permalink from gutter :bug: editor selection updates to whole line This makes it impossible to generate a Markdown link with a specific word selection from right clicking on an editor line number.
Change:
this.contextLinesInput = new InputBox(searchInputContainer, this.contextViewService, { type: 'number' }); this.contextLinesInput.element.classList.add('context-lines-input'); this.contextLinesInput.value = '' + (this.configurationService.getValue<ISearchConfigurationProperties>('search').searchEditor.defaultNumberOfContextLines ?? 1); <del> this._register(this.contextLinesInput.onDidChange(() => this.onContextLinesChanged())); </del> <ins> this._register(this.contextLinesInput.onDidChange((value: string) => { if (value !== '0') { this.showContextToggle.checked = true; } this.onContextLinesChanged(); })); </ins> this._register(attachInputBoxStyler(this.contextLinesInput, this.themeService)); dom.append(searchInputContainer, this.showContextToggle.domNode); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: to search tab. Click "Open new search editor" some text. context lines to 2. It takes effect. context lines to 0. It take effect. context lines to 2. It doesn't take effect.
I can see this too (in Insiders). It is as if decreasing the context lines value to 0 toggles off the context lines for some reason. In fact, I can see the option being automatically disabled when you hit 0, but it does not reenable upon increasing the value. Toggling the context lines option icon does temporarily fix the issue.
When the context line number decrease to zero, toggle button is unchecked. However if you increase the number again, the toggle button is not checked automatically which result in this issue.
Change:
if (waitMarkerFilePath) { waitForFileDeleted(waitMarkerFilePath); } <ins> if (readFromStdinPromise) { await readFromStdinPromise; } </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (WSL depends on some dependencies) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0 OS Version: Windows 11 23H2 Steps to Reproduce: In a WSL shell run . does not return until the editor tab is closed again. This is no longer intended behaviour since was solved. In PowerShell on the Windows host, the command does work as intended, when running .
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified with VSCode 1.89.0 stable
Change:
new TextSearchMatch('preview 1', new OneLineRange(1, 4, 11))), aRawMatch('/2', new TextSearchMatch('preview 2', lineOneRange))]; <del> instantiationService.stub(ISearchService, searchServiceWithResults(results)); </del> <ins> instantiationService.stub(ISearchService, searchServiceWithResults(results, { limitHit: false, messages: [], results })); </ins> instantiationService.stub(INotebookSearchService, notebookSearchServiceWithInfo([], undefined)); const testObject: SearchModel = instantiationService.createInstance(SearchModel);

Discussion:
to , run a text search search is running, hit cancel on the "downloading repository index..." notification in the bottom right corner :bug: search view should show two messages (see below) but only the first one shows up !
Saw the notification about indexing but it was before I clicked search and now whenever I click search I don't see the notification come up.
I believe that you can try to do this with a larger repo (like ), and there should be enough time to cancel the index. Not too sure how to remove the index once it's downloaded, but you can try that first!
You can delete the downloaded index with the Delete All Repository Indexes command
The search result message changed but I see two messages at least !
Change:
import { IFileService } from 'vs/platform/files/common/files'; import { INativeWorkbenchEnvironmentService } from 'vs/workbench/services/environment/electron-sandbox/environmentService'; import { URI } from 'vs/base/common/uri'; <ins> import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; </ins> export class ToggleDevToolsAction extends Action2 {

Discussion:
Testing nothing in the dev tools console indicates there's an issue though
I think a good fix would be to not show the action when utility process is used. But there is no counter part unfortunately.
Change:
} } <ins> /** * Play the given audio url. * @volume value between 0 and 1 */ function playAudio(url: string, volume: number): Promise<void> { return new Promise((resolve, reject) => { const audio = new Audio(url); audio.volume = volume; audio.addEventListener('ended', () => { resolve(); }); audio.addEventListener('error', (e) => { // When the error event fires, ended might not be called reject(e.error); }); audio.play().catch(e => { // When play fails, the error event is not fired. reject(e); }); }); } </ins> function eventFromObservable(observable: IObservable<any>): Event<void> { return (listener) => { let count = 0;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.7.2 OS Version: windows Steps to Reproduce: a file with error on `cue: line has an error" settings the cursor to there
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
it still occurs with 1.73.1
yeah I can reproduce this issue. is this expected?
This is not expected. Sounds should be played when cursor is navigated to the error line. worked on this initially and might have more details
I also have the same problem, but this only occurs in the insider version, I have the latest version and no sound is played Issue:
They play in OSS, but not insider's. any idea why that would be?
if that is the case then it is probably related to code bundling. Does that sound play when you F1 list audio cues?
It does play when I list audio cues in both OSS and insider's.
It also plays for terminal quick fixes - suggesting there's a bug in because I can also repro it not playing for other line feature types
This has been working for me lately, though it was definitely broken at one pt.
I have set to I navigate to a line with an error-squiggle but there is no sound being played
Change:
struct StorageWithLastRead { storage: Box<dyn StorageImplementation>, <ins> fallback_storage: Option<FileStorage>, </ins> last_read: Cell<Result<Option<StoredCredential>, WrappedError>>, }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Not sure. I run "code tunnel" without opening the UI. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.0 OS Version: Ubuntu 22.04 LTS Steps to Reproduce: Install VSCode or Code Cli on Ubuntu Desktop 22.04 "code tunnel" on Ubuntu. server license terms and login to and enter the code. tunnel will show: . VSCode tunnel and rerun "code tunnel". It will ask for GitHub authentication again, because it failed to update keyring.
Seems to duplicate the upstream issue on To work around this, you can set the environment variable (e.g. by running and reconnecting). But this seems fairly common, we should automatically use a file keychain if we get this error.
Hi Connor, Thanks for your help! It would be wonderful if the error can be automatically dealt with since many people don't know the environment variable.
yes,
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Putting in a new line in does the trick for me. (putting the env var in a global file ensures that it will be defined regardless of where it's running or who is running it; note that on some systems this may be a massive security hole)
I now see this in insiders: and then when I restart: looks verified to me.
Change:
import { ExtensionIdentifier, IExtensionDescription, IRelaxedExtensionDescription } from 'vs/platform/extensions/common/extensions'; import { localize } from 'vs/nls'; import { ILogService } from 'vs/platform/log/common/log'; <ins> import * as semver from 'vs/base/common/semver/semver'; // TODO: @sandy081 merge this with deduping in extensionsScannerService.ts </ins> export function dedupExtensions(system: IExtensionDescription[], user: IExtensionDescription[], development: IExtensionDescription[], logService: ILogService): IExtensionDescription[] { let result = new Map<string, IExtensionDescription>(); system.forEach((systemExtension) => {

Discussion:
<img width="1440" alt="image" src="https://user-"version:
cc not sure why this would be
Let me investigate
There seems to be a older version of this extension in the extensions installation folder. Deleting it will fix it. It seems to be a bug in VS Code for showing reload in this case.
Would be helpful to provide a command to remove all old extensions cache
This is a bug in VS Code that it is not removing the obsolete extensions. So you do not need a command. Manually deleting is just a workaround for now.
To verify: Download and install with version from Version History tab. Reload window and go to extensions view and search for extension and make sure you do not see Reload Required button
Change:
export class AuxiliaryWindow extends BaseWindow implements IAuxiliaryWindow { <ins> private readonly _onWillLayout = this._register(new Emitter<Dimension>()); readonly onWillLayout = this._onWillLayout.event; </ins> private readonly _onDidLayout = this._register(new Emitter<Dimension>()); readonly onDidLayout = this._onDidLayout.event;

Discussion:
Testing a workspace a tab into a new floating window in a couple times using keyboard shortcuts the zoom status bar item to zoom out. When the zoom out happens, the status bar item will move further right, as expected because everything is getting small. However, the hover itself moved further left. I would expect it to either stay under my cursor (ideal) or move with the status bar item. !
It also moves around unexpectedly when I zoom in.
My cursor isn't showing properly in this gif, but I think you can get the idea. !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!