jiebi/CodeConvo huggingface dataset:
Change:
} this._childProcessIdStack = [this._rootProcessId]; <ins> this._isDisposed = false; </ins> this._onCheckShell = new Emitter<TPromise<string>>(); // The debounce is necessary to prevent multiple processes from spawning when // the enter key or output is spammed

Discussion:
Steps to reproduce: and kill terminal very quickly This can likely happen when the terminal is killed during a call.
I can still repro this with the same stack, I don't think the PR fixes the right issue. It fails on this line, because is null: A null xterm object is passed into the constructor, which implies that the terminal instance was disposed, so I think the problem is the terminalInstance being disposed while is running:
Change:
case 'extends': case 'param': case 'template': { <del> const body = (convertLinkTags(tag.text, filePathConverter)).split(/^(S+)s*-?s*/); </del> <ins> const body = getTagBody(tag, filePathConverter); </ins> if (body?.length === 3) { const param = body[1]; const doc = body[2];

Discussion:
<img width="957" alt="image" src="https://user-"Version info:
I think the issue is this line. From what I understand the regex matches the first word causing split to return 3 element array 0: empty string(cause there is nothing before the first word) 1: the first word 2: rest of the string. However, seems to have the same effect. What am I missing?
nvm got it. It is not the same for strings like 'iterable' and 'iterable -'
Change:
} // Window Controls (Native Windows/Linux) <del> const hasWindowControlsOverlay = typeof (navigator as any).windowControlsOverlay !== 'undefined'; if (!isMacintosh && getTitleBarStyle(this.configurationService) !== 'native' && !hasWindowControlsOverlay && this.windowControls) { </del> <ins> if (!isMacintosh && getTitleBarStyle(this.configurationService) !== 'native' && !isWCOVisible() && this.windowControls) { </ins> // Minimize const minimizeIcon = append(this.windowControls, $('div.window-icon.window-minimize' + Codicon.chromeMinimize.cssSelector)); this._register(addDisposableListener(minimizeIcon, EventType.CLICK, e => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0-insider (user setup) Commit: Date: 2022-11-03T05:36:55.498Z Electron: 19.1.3 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !
It affects as well other distributions:
fixes it for me.
Change:
const [, , machineId] = await Promise.all([ configurationService.initialize(), userDataProfilesService.init(), <del> getMachineId() </del> <ins> getMachineId(logService.error.bind(logService)) </ins> ]); const extensionHostStatusService = new ExtensionHostStatusService();

Discussion:
When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to
if you support the idea I can provide a PR
that all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "5.1.0-beta.49", "xterm-addon-canvas": "0.3.0-beta.23", </del> <ins> "xterm": "5.1.0-beta.61", "xterm-addon-canvas": "0.3.0-beta.26", </ins> "xterm-addon-search": "0.11.0-beta.7", "xterm-addon-serialize": "0.9.0-beta.3", <del> "xterm-addon-unicode11": "0.5.0-beta.1", "xterm-addon-webgl": "0.14.0-beta.32", "xterm-headless": "5.1.0-beta.49", </del> <ins> "xterm-addon-unicode11": "0.5.0-beta.5", "xterm-addon-webgl": "0.14.0-beta.38", "xterm-headless": "5.1.0-beta.61", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Issue Type: <bPerformance Issue</bEver since I got this M1 mac with apple silicon, any scrolling I do in VSCode is super choppy and laggy. To reproduce it on my machine I just need to open an editor with a scrollbar or a terminal with some history and scroll quickly up and down. VS Code version: Code 1.69.2 (, 2022-07-18T16:32:39.000Z) OS version: Darwin arm64 21.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryProcess Info</summary</details<details<summaryWorkspace Info</summary</details<details<summaryExtensions (11)</summaryExtensionVersion ------ prettier-vscode9.5.0 go0.35.1 githd2.3.3 vscode-docker1.22.1 python2022.10.1 vscode-pylance2022.8.10 jupyter2022.6. jupyter-keymap1.0.0 jupyter-renderers1.0.9 vsliveshare1.0.5669 vscode-yaml1.9.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you do a performance profile in devtools (Help Toggle Developer Tools) and upload it here? !
Sure, attached.
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
There's an abnormal about of garbage collection in that profile which I've never seen before: !
what sort of monitor are you connected to? Could you also open devtools via the Help menu and run in the console? My guess is your font size is so large that the terminal's texture atlas is thrashing and redrawing all glyphs almost every frame.
Upstream issue tracking the texture cap problem:
This one can only be verified by the
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

I'll mark this issue as verified as part of . Please file a new issue if the bug continues to occur on the latest Stable and/or Insiders versions of VS Code.
Change:
break; } actions.push({ <del> title: localize('codeAction', "Surround With: {0}", snippet.name), </del> <ins> title: localize('codeAction', "{0}", snippet.name), </ins> kind: CodeActionKind.SurroundWith.value, edit: asWorkspaceEdit(model, range, snippet) });

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The "Surround with...." in the labels are redundant and by removing them, clears up clutter in the action widget, and lets users navigate to specific labels by typing in fewer keys (ie, would go to, will go to ) !
Change:
this.block.style.height = '100%'; this.block.style.zIndex = '-1'; <del> // TODO@Steven: this is never getting disposed addDisposableListener(this.block, EventType.MOUSE_DOWN, e => e.stopPropagation()); </del> <ins> this.blockDisposable?.dispose(); this.blockDisposable = addDisposableListener(this.block, EventType.MOUSE_DOWN, e => e.stopPropagation()); </ins> } const menuDisposables = new DisposableStore();

Discussion:
click to open context menu in text editor +P to open quick open :bug: both context menu and quick open are dismissed !
re: context menu
This is not a regression so assigning to december
I'm going to pass to you for your take. Here's what I found out. When we show the command palette that causes the editor context menu to trigger the hide: This hide, focuses the editor... but in doing so, that causes the Quick Pick's didBlur to hide: which will hide the quick pick if is set to which is the default. This behavior with context menus seems to repro: Always in context menus of the editor Only with custom menus (not native menus) in the rest of the product (tree views, Account/Gear menu, etc)
Two actions here: needs to be removed or handled better (passing that to or menus should follow the logic: if ESC/selection, focus what was previously focused. If dismissed due to focus lost, don't restore focus (this goes to
my suspicion is that the editor contribution is old and unnecessary as the behavior is built-in to the menu widget. Removing it, we can centralize the logic to the menu widget.
re-opening as we still have some work to do on the custom menu side
Change:
when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerResourceNotReadonlyContext, ExplorerResourceMoveableToTrash), primary: KeyCode.Delete, mac: { <del> primary: KeyMod.CtrlCmd | KeyCode.Backspace </del> <ins> primary: KeyMod.CtrlCmd | KeyCode.Backspace, secondary: [KeyCode.Delete] </ins> }, handler: moveFileToTrashHandler });

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Some MacOS users have full-size keyboards with a forward delete key. Even Apple-provided keyboards have forward delete via the key. This key should delete files by default.
This is a fair feature request, however you can customise this. Let's leave this open for now and if more users request this we might change in the future.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
} run(): TPromise<any> { <ins> alert(localize('updateExtensionStart', "Updating extension {0} to version {1} started.", this.extension.displayName, this.extension.latestVersion)); </ins> return this.install(this.extension); } private install(extension: IExtension): TPromise<void> { <del> return this.extensionsWorkbenchService.install(extension).then(null, err => { </del> <ins> return this.extensionsWorkbenchService.install(extension).then(() => { alert(localize('updateExtensionComplete', "Updating extension {0} to version {1} completed.", this.extension.displayName, this.extension.latestVersion)); }, err => { </ins> if (!extension.gallery) { return this.notificationService.error(err); }

Discussion:
Environment Details: VSCode Version : 1.24.1 OS Version : Win10 Additional Details: ScreenReader Version: NVDA2018.2 Repro Steps: VS Code while NVDA is ON. to View menu and Select Extensions. something in the Search Textbox and tab till install button. Actual: When we Click on install button, the text above the button changes..i.e.(installing) which is not read by the screenreader and after installing, a Reload button appears and also a icon which is not informed by the screenreader and after pressing tab key focus does not move on the text which has installed,it goes somewhere else. Expected: NVDA should announce some information about the reload button and should also read the "installing" when it is getting installed and focus should go on the very first item which has got installed. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: User will not be able to know about the controls which has appeared after installing the particular extensions. Attachment for Reference: Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.588 --- <!-- score: 0.526 --- <!-- score: 0.462 --- <!-- score: 0.458 --- <!-- score: 0.451 --<!-- potentialduplicates_comment --
Makes sense. This sounds as easy as an aria alert based on the state of the installation. I would expect at least a notification once the instalation is done so the user is reminded that a reload is necessery. Feels low hanging, assigning to July
do we plan to tackle this in September? It would be great since we depend on this one for a better accessibility score?
Yes, this is for September
Note to verifier: Also test cases of uninstall and update and ensure that appropriate text is read out. Ensure that the need to reload VS Code is also mentioned
Change:
export const WorkbenchListDoubleSelection = new RawContextKey<boolean>('listDoubleSelection', false); export const WorkbenchListMultiSelection = new RawContextKey<boolean>('listMultiSelection', false); export const WorkbenchListSelectionNavigation = new RawContextKey<boolean>('listSelectionNavigation', false); <ins> export const WorkbenchListSupportsFind = new RawContextKey<boolean>('listSupportsFind', true); </ins> export const WorkbenchTreeElementCanCollapse = new RawContextKey<boolean>('treeElementCanCollapse', false); export const WorkbenchTreeElementHasParent = new RawContextKey<boolean>('treeElementHasParent', false); export const WorkbenchTreeElementCanExpand = new RawContextKey<boolean>('treeElementCanExpand', false); export const WorkbenchTreeElementHasChild = new RawContextKey<boolean>('treeElementHasChild', false); export const WorkbenchTreeFindOpen = new RawContextKey<boolean>('treeFindOpen', false); <del> export const WorkbenchTreeSupportsFind = new RawContextKey<boolean>('treeSupportsFind', true); </del> const WorkbenchListTypeNavigationModeKey = 'listTypeNavigationMode'; /**

Discussion:
I think this came up during the standup today, why is the context key called and not ? //cc
This context key came in quite late via a fix -- . I noticed this standing out because of the default keybindings which seem to mix things up: Giving this a candidate in case we want to align the context key before shipping stable
From
Change:
for (const dependency of task.configurationProperties.dependsOn) { const dependencyTask = await resolver.resolve(dependency.uri, dependency.task!); if (dependencyTask) { <del> dependencyTask.configurationProperties.icon = task.configurationProperties.icon; </del> <ins> dependencyTask.configurationProperties.icon = dependencyTask.configurationProperties.icon || task.configurationProperties.icon; </ins> const key = dependencyTask.getMapKey(); let promise = this._activeTasks[key] ? this._getDependencyPromise(this._activeTasks[key]) : undefined; if (!promise) {

Discussion:
Testing I the following to the "Core - Build" task in this repo: The color shows in the "Run Task" quick pick, but not in the terminal tabs (I tried reloading, but still no color). !
the color will only take effect the next time you run the task - don't think it's worth listening to the config and updating. we don't do that for existing terminals either when an icon or color is set for their profile <img width="1291" alt="Screen Shot 2022-06-28 at 12 06 04 PM" src="https://user-"
Alex mentioned , I actually reproduced the icon and color not applying when testing also
I'm guessing it's just on tasks run via ? It works when running Core - Build explicitly but not ctrl+shift+b: !
should work for dependsOn tasks
works w ctrl+shift+b for other default build tasks () https://user-
works w ctrl+shift+b and the VS Code build task for me https://user-
can you pls send me the exact task config this isn't working for?
it's was just what was shown in the screenshot, the small change to . Might be related to Windows somehow then if you don't see it?
not sure why I can't reproduce it, but could be fixed by
I can still repro this in the latest insiders.
yes so can on Windows. we're going to debug
are there any task load messages in the output channel?
or any way the build task on windows is handled specially?
If there's an issue reading tasks from then an error should be logged to the tasks output channel, and I don't have any. The Run Build Task command shouldn't be handled any differently here, and I confirmed that this isn't build specific by making this keybinding:
to verify: set an icon for a dependency task
If I just set the icon color it now changes the icon away from the tools icon (its still the tools icon in the task quick pick): !
Change:
import { Event } from 'vs/base/common/event'; import * as glob from 'vs/base/common/glob'; import { IDisposable, IReference } from 'vs/base/common/lifecycle'; <ins> import { posix } from 'vs/base/common/path'; </ins> import { basename } from 'vs/base/common/resources'; import { URI } from 'vs/base/common/uri'; import { RawContextKey } from 'vs/platform/contextkey/common/contextkey';

Discussion:
have a custom editor that is registered for -files play with it change its selector to :bug: still open all JSON files... <img width="1044" alt="Screenshot 2020-04-03 at 16 12 20" src="https://user-"
Yes for the contribution, looks like we handle that contain a slash specially: We should do the same here
Change:
registerAction2(class OpenSearchEditorAction extends Action2 { constructor() { super({ <del> id: SearchEditorConstants.OpenNewEditorCommandId, title: localize('search.openNewEditor', "Open New Search Editor"), </del> <ins> id: 'search.action.openNewEditorFromView', title: localize('search.openNewEditor', "Open New Search Editor from View"), </ins> category, icon: searchNewEditorIcon, <del> f1: true, </del> menu: [{ id: MenuId.ViewTitle, group: 'navigation',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --FYI Related to ? Steps to Reproduce: Set up a keybinding for with any Trigger the keybinding, search editor opens but none of the are used Same keybinding works in Stable Demo using a workspace file: Same result: (not involving OneDrive) ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Version: 1.53.0-insider (user setup) Commit: Date: 2021-01-29T21:49:22.151Z Electron: 11.2.1 Chrome: 87.0.4280.141 12.18.3 V8: 8.7.220.31-electron.0 OS: Windows_NT x64 10.0. Log Window) with enabled: [2021-01-31 19:44:09.185] [renderer1] [trace] CommandService#executeCommand [2021-01-31 19:44:15.502] [renderer1] [trace] KeybindingService#dispatch Ctrl+Shift+G [2021-01-31 19:44:15.502] [renderer1] [trace] CommandService#executeCommand
Thanks, I can reproduce.
To verify: Add a keybinding like: Execute it, expect to see the context line input properly filled out.
Works for me (W10). Used this keybinding just to test more args (see below for a comment in the args): I suppose an issue should be filed on not working if it was intended to - it does properly insert the full path, ala but fails silently and button does nothing.
thanks, as far as I'm aware directly putting that absolute path into the entry would fail as well, correct? So not a new issue.
Yes, it fails inserting it directly into the arg (escaped properly) and in the view in the Panel input - although in Search view it does show the error highlight around the query box and hover error message. I will not file an issue on this.
Change:
registerAction2(MoveEditorGroupToNewWindowAction); registerAction2(CopyEditorGroupToNewWindowAction); registerAction2(RestoreEditorsToMainWindowAction); <ins> registerAction2(NewEmptyEditorWindowAction); </ins> const quickAccessNavigateNextInEditorPickerId = 'workbench.action.quickOpenNavigateNextInEditorPicker'; KeybindingsRegistry.registerCommandAndKeybindingRule({

Discussion:
Testing I am wondering if there should be a context menu action for this? !
Yeah, I actually decided to do a bit more: Editor Tab Container Context Menu: <img width="447" alt="image" src=""Empty Editor Group Context Menu: <img width="458" alt="image" src="" to open an empty aux window
Change:
import { Delayer, setImmediate } from '../utils/async'; import { nulToken } from '../utils/cancellation'; import { Disposable } from '../utils/dispose'; <ins> import { vscodeNotebookCell } from '../utils/fileSchemes'; </ins> import * as languageModeIds from '../utils/languageIds'; import { ResourceMap } from '../utils/resourceMap'; import * as typeConverters from '../utils/typeConverters';

Discussion:
Issue Type: <bBug</bMoved off Steps to reproduce: code that generates a linting warning (in this case, should should generate an unused variable warning) the file, and then close it before the diagnostics appear Expected behavior: Diagnostics are not shown when the file is closed. Actual behavior: Diagnostics are sometimes shown when the file is closed, and will not disappear until I reload the window. Please note that I couldn't reproduce this behaviour reliably. Action gif: ! VS Code version: Code 1.46.1 (, 2020-06-17T21:17:14.222Z) OS version: Darwin x64 19.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 gitlens10.2.2 prettier-vscode5.1.3 vscode-pull-request-github0.17.0 vscode-docker1.3.1 python2020.6. vscode-pylance2020.6.1 remote-containers0.122.1 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.4 vscode-remote-extensionpack0.20.0 azure-account0.8.11 vscode-typescript-tslint-plugin1.2.3 vscode-icons10.1.1 (3 theme extensions excluded) </details<!-- generated by issue reporter --
Change:
this.input.dispose(); } await super.setInput(input, options, context, token); <ins> this.resourceContext.set(input.resource); </ins> if (focus) { this.focus(); }

Discussion:
! Observed by
Do you have special steps for this? Do you see this with all output channels or only the MySQL one? Can you do the following when this happens: F1 Inspect Context Keys and then share what's printed on dev tools console
No specific repro steps - this happened immediately after upgrading in a test session - will try to repo on desktop doing it and report back!
Hi there, I think I received this email erroneously? I'm Nick Carver, but it looks like the original msg was from a Nick Craver. Cheers, Nick.
any new insights here?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Apologies I was on vacation for a bit - haven't been able to repro this since the latest update landed (but also have to unfortunately rebuild the machine we saw it on for terribad Windows reasons). Recommend we close this and if I can repro, will poke with more info :)
Leaving this open since saw this once but forgot to inspect context keys ()
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
steps: empty profile have a file under merge-conflict open the output view open the merge editor for the conflict file :bug: output view shows the merge overlay button