jiebi/CodeConvo huggingface dataset:
Change:
} function doScoreFuzzy2Single(target: string, query: IPreparedQueryPiece, patternStart: number, wordStart: number): FuzzyScore2 { <del> const score = fuzzyScore(query.original, query.originalLowercase, patternStart, target, target.toLowerCase(), wordStart); </del> <ins> const score = fuzzyScore(query.original, query.originalLowercase, patternStart, target, target.toLowerCase(), wordStart, { firstMatchCanBeWeak: true, boostFullMatch: true }); </ins> if (!score) { return NO_SCORE2; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 Stable OS Version: Windows 11 Steps to Reproduce: a .md file, add a header ⌘T, type 1.66.2: works fine ! 1.67.0: No matching workspaces symbols !
I confirmed that markdown returns the workspace symbols in this case. They then seem to be filtered out on the VS Code side
https://user-
Did the filtering for quick pick change?
This is a regression from I have changed how is configured and made the wrong adoption here...
Change:
overflowed = width <= childWidth; } <del> const hasDecoration = element.classList.toString().includes('monaco-decoration-iconBadge'); </del> <ins> // Only count decorations that provide additional info, as hover overing decorations such as git excluded isn't helpful const hasDecoration = options.content.toString().includes('•'); </ins> // If it's overflowing or has a decoration show the tooltip overflowed = overflowed || hasDecoration;

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-16T05:23:44.671Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes /assign <!-- generated by issue reporter --
Thanks! This is also a regression because we are only supposed to show it on files with decorations (such as source control) or overflowing text (such as ).
I don't get this custom hover ever. Can you please add steps to verify?
These custom hovers have been removed from product due to being too buggy at the moment. I will just mark this as verified as this feature isn't ready for testing yet.
Change:
clearTimeout(this._incomingAckTimeout); this._incomingAckTimeout = null; } <ins> if (this._keepAliveInterval) { clearInterval(this._keepAliveInterval); this._keepAliveInterval = null; } </ins> this._socketDisposables = dispose(this._socketDisposables); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Background: Modern reverse proxies like nginx or cloudflare use timeouts for dormant websocket connections. For nginx this defaults to 60s and for Cloudflare to 100s. In case of Cloudflare, this is not configurable for non-enterpise users. Due to the fixes in , the management connection is now typically being idle for extended periods of time. If the web-socket connection is being terminated by the reverse proxy, even if it can be reestablished immediately, a modal dialog is being shown, which disturbs the user immensely. For reference see In order to support Cloudflare it is essential, that we either implement a keep-alive ping (my proposal would by every 45s by default), or alternatively, make it so an immediate reconnect does not cause any negative consequences for the user.
any insights here?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Version: 1.71.0-insider Commit: Date: 2022-08-26T23:24:52.456Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36 /verified I do no longer experience regular reconnects every 100 seconds behind cloudflare with the build above.
Change:
const resourceMarkers = node.element; const uriMatches = node.filterData && node.filterData.uriMatches || []; <del> if (this.fileService.hasProvider(resourceMarkers.resource) || resourceMarkers.resource.scheme === network.Schemas.untitled) { templateData.resourceLabel.setFile(resourceMarkers.resource, { matches: uriMatches }); } else { templateData.resourceLabel.setResource({ name: resourceMarkers.name, description: this.labelService.getUriLabel(dirname(resourceMarkers.resource), { relative: true }), resource: resourceMarkers.resource }, { matches: uriMatches }); } </del> <ins> templateData.resourceLabel.setFile(resourceMarkers.resource, { matches: uriMatches }); </ins> this.updateCount(node, templateData); const nodeRenders = this.renderedNodes.get(resourceMarkers) ?? [];

Discussion:
Type: <bBug</bworkspace a new notebook a syntax or other error in a cell problems view bug There's an extra to the right of the notebook file title ! VS Code version: Code - Insiders 1.88.0-insider (Universal) (, 2024-03-25T05:50:56.142Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
It is also same in Search ! Probably this should be something handled by the CC
Its possible to omit in the label widget for because there we know we are in a file context and is not very meaningful for descriptions (change in ). But for the problems view there is an explicit call to with an explicit description passed in: I am not sure just changing to return or wouldn't break some assumptions we have. I would argue that is a valid relative label for a path that has no parent (as in this case). any reason is not used? Or maybe we need to enlist the cell scheme as well as we do for untitled scheme.
I do not remember why we have two branches here - and . Is there a general suggestion for this? I am looking for this before digging deep. Is there a way to know this?
Yeah I would pick the and see what breaks, but maybe there is something in the history of that change that could explain it? I think schemes are pretty much hardcoded, here unfortunately while the notebook scheme is , the cell schemes are not. is there a way to know if a cell scheme is untitled?
It goes back before we used to have label service. I was also not showing the of the resource if the resource has no file provider. Showing parent was introduced . I believe using is the right way to go. I also see Search doing the same.
Change:
/* Must be higher than sash's z-index and terminal canvases */ z-index: 40; overflow: hidden; <del> overflow-y: auto; </del> max-width: 700px; }

Discussion:
Does this issue occur when all extensions are disabled?: No VS Code Version: 1.73.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: ! to the extension bar. to hover some items. Some one may not show the default scroll bar, but the problem is exists. ! I have tried to fix it. It seems caused by the visual bug from the issue . The scroll bar will show when the content is too long. This solution is great, but it causes another little bug in the screenshot. I think it's unwise to remove the tag, so I tried another way, just add to the tag : ! I'll make a PR after this issue has submitted.
I can't reproduce this srollbar for all extensions in the list: !
This bug is not 100% recurring. Some extensions' descriptions may just exceed the calculated.
What's ur testing extension id?
These extensions have the problem on my machine.
! !
Maybe it's related to high-resolution screen. I'm sure it's an accidental problem, but it still exists. If you have the conditions, try adjusting the screen resolution scale to 150%.
there should be some bugs when doing sub pixel sampling whether it's related to windows DPI settings. can you reproduce this regularly without changing DPI?
Caused by can you please have a look at this?
Change:
if (options.get(EditorOption.folding) && options.get(EditorOption.showFoldingControls) !== 'never') { lineDecorationsWidth -= 16; } <del> lineDecorationsWidth += 9; </del> <ins> lineDecorationsWidth += 14; </ins> extraEditorClassName.push('inline-comment'); this.editor.updateOptions({ extraEditorClassName: extraEditorClassName.join(' '),

Discussion:
I was exploring ways to improve the PR experience in VS Code and one of the ideas involved updating the glyph area for comments. Currently we show a gray bar and a unicode and that don't look very pretty. ! A couple of things I explored: Moving glyph area to the left of line numbers. This helps create separation between between the scm indicators and a clear area for adding comments. Adding button for adding and view comments. This follows a similar pattern on GitHub for reviewing changes. Hiding diff chunk areas. This reduces the visual noise and I think most people will be commenting on changed lines in the PR as opposed to lines that are not related Adding color to the and changes to look visually pleasing ! Unsure who should I assign to so assigning to and for now
Some additional feedback from the team: We might still need the indicator for comment areas, particularly when viewing files with changes in review mode where the diffs are not present ! We could also surface the "add comment" button on line hover to increase discoverability
I agree that we will likely still need to show the range, but let's improve the leave-a-comment and there's-a-comment decorations.
Here's what I'm thinking: ! It uses the comment codicon for lines with a comment thread. Keeps the existing + for add Makes them both look a little more clickable but making them more square and giving them rounded corners. and what do you think? I didn't add any color for now and I kept everything to the right of the line numbers still.
this is looking great, love that we can have codicon support in the comments! I know you mentioned you hadn't any color, is that something that you'd be open for us to add? I did a quick mockup that shows an alternate styling: <img width="314" alt="CleanShot 2022-08-08 at 08 57 41 src="https://user-"
I didn't add color because I thought the blue was a bit too strong, but I really like the color in this mock up. I'll add it and merge the change! I also see that you're using the codicon +. I'll switch to that too.
Also updated the multiline add: !
Change:
if (this.countElement && message !== this.countElement.textContent) { this.countElement.textContent = message; this.inputBox.inputElement.setAttribute('aria-label', message); <del> DOM.toggleClass(this.countElement, 'no-results', count === 0); </del> this.inputBox.inputElement.style.paddingRight = this.getControlsWidth() + 'px'; <del> this.styleCountElementForeground(); </del> } } <del> private styleCountElementForeground() { const colorId = DOM.hasClass(this.countElement, 'no-results') ? errorForeground : badgeForeground; const color = this.themeService.getTheme().getColor(colorId); this.countElement.style.color = color ? color.toString() : null; } </del> public layout(dimension: DOM.Dimension) { if (dimension.width < 400) { if (this.countElement) {

Discussion:
In approx 1/4 of my installed themes this badge looks awful: ! Having no-results just doesn't feel like an error. Standard badge color (Like white here on github badge) is fine(because it's usually made for it). P.S. no need for a new color, already too many of them. P.P.S. actually new settings editor doing exactly that: ! So, it just needs to be aligned with the GUI version of settings.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.532 --- <!-- score: 0.51 --- <!-- score: 0.491 --<!-- potentialduplicatescomment --
Change:
private createSyncIgnoredIndicator(): SettingIndicator { const syncIgnoredElement = $('span.setting-indicator.setting-item-ignored'); <del> syncIgnoredElement.tabIndex = 0; </del> const syncIgnoredLabel = new SimpleIconLabel(syncIgnoredElement); syncIgnoredLabel.text = localize('extensionSyncIgnoredLabel', 'Not synced');

Discussion:
Change the key event handling so that the user can tab once into the indicators container, and then use left/right arrows to focus on different indicators.
the Settings editor, search on the setting. tab should focus on the first indicator. again should go to the checkbox. -tabbing twice from there should focus the entire setting again. again to the indicator. The left and right arrow keys, along with the home and end keys should allow the user to focus onto the other indicators. indicators container should keep track of the focused indicator. If the second indicator is focused, and the user tabs to the checkbox and back, the second indicator should be the one focused rather than the first one.
Change:
readonly mainPart = this._register(this.createMainEditorPart()); <ins> private readonly mostRecentActiveParts = [this.mainPart]; </ins> constructor( @IInstantiationService private readonly instantiationService: IInstantiationService ) {

Discussion:
Currently we do not really track MRU of editor groups across windows. Some features rely on this though, so we should see if we can track MRU truly across aux windows.
Change:
'files.autoSaveWhenNoErrors': { 'type': 'boolean', 'default': false, <del> 'markdownDescription': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'autoSaveWhenNoErrors' }, "When enabled, will limit [auto save](https://code.visualstudio.com/docs/editor/codebasics#_save-auto-save) of editors to files that have no errors reported in them. Only applies when `#files.autoSave#` is enabled."), </del> <ins> 'markdownDescription': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'autoSaveWhenNoErrors' }, "When enabled, will limit [auto save](https://code.visualstudio.com/docs/editor/codebasics#_save-auto-save) of editors to files that have no errors reported in them at the time the auto save is triggered. Only applies when `#files.autoSave#` is enabled."), </ins> scope: ConfigurationScope.LANGUAGE_OVERRIDABLE }, 'files.watcherExclude': {

Discussion:
Testing Files are sometimes auto saved even though there is an error. This happens when the language server detects the error after the file has already been saved. Maybe when this feature is used, it should never auto save before the language server has analysed the file? !
I am pushing a change to update the description of the setting: In reality, I am not aware of a way to reliably tell that there is a pending task that might produce error markers. My understanding is that error markers can come in anytime after making changes to the document. I do not think we can prolong auto save artificially without having a clear method that would also have to be adopted by extensions. As such, this setting will do it as best as it can.
Change:
import { registerClearActions } from 'vs/workbench/contrib/chat/browser/actions/chatClearActions'; import { AccessibleViewAction } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution'; import { AccessibleViewType, IAccessibleViewService } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; <del> import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; import { IChatResponseViewModel, isResponseVM } from 'vs/workbench/contrib/chat/common/chatViewModel'; </del> <ins> import { isResponseVM } from 'vs/workbench/contrib/chat/common/chatViewModel'; </ins> import { CONTEXT_IN_CHAT_SESSION } from 'vs/workbench/contrib/chat/common/chatContextKeys'; import { ChatAccessibilityService } from 'vs/workbench/contrib/chat/browser/chatAccessibilityService';

Discussion:
Accessible view should show content of currently focused chat message, of the most recent if the textbox has focus. Currently if I focus some message in the past and hit alt+f2, it brings up the most recent message instead.
This should be working Are you focusing a response? Or a request? It only works for responses since a user will not need to inspect their request more closely.
This didn't come up in testing via the TPI which is surprising if it's not working.
Focusing responses it definitely happens for me: !
Yeah something changed as this used to work. I can repro
Change:
switch (state) { case VoiceChatSessionState.GettingReady: contextVoiceChatGettingReady.set(true); <del> contextVoiceChatInProgress.set(undefined); </del> <ins> contextVoiceChatInProgress.reset(); </ins> break; case VoiceChatSessionState.Started: <del> contextVoiceChatGettingReady.set(false); </del> <ins> contextVoiceChatGettingReady.reset(); </ins> contextVoiceChatInProgress.set(context); break; case VoiceChatSessionState.Stopped: <del> contextVoiceChatGettingReady.set(false); contextVoiceChatInProgress.set(undefined); </del> <ins> contextVoiceChatGettingReady.reset(); contextVoiceChatInProgress.reset(); </ins> break; } };

Discussion:
Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39.

cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
are you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:
Happened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.
I need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)
Change:
} code { <ins> font-family: var(--monaco-monospace-font); </ins> color: var(--vscode-textPreformat-foreground); <ins> font-size: 12px; background-color: var(--vscode-textPreformat-background); padding: 1px 3px; border-radius: 4px; </ins> } blockquote {

Discussion:
From We should fix block styling in Markdown previews in main as well, from discussing with we want to make the styling consistent across chat, settings UI, and extension webviews
The three greys look different to me. I'm unsure whether those are the colours I should be comparing. !
To verify this you just need to confirm that there is a background for blocks, since it used to just be a brownish foreground color.
Change:
}, startLine ); <ins> // Support this product's URL protocol if (matchesScheme(word.text, this._productService.urlProtocol)) { const uri = URI.parse(word.text); if (uri) { links.push({ text: word.text, uri, bufferRange, type: TerminalBuiltinLinkType.Url }); } continue; } // Search links </ins> links.push({ text: word.text, bufferRange,

Discussion:
Type: <bBug</bContext I want to use vscode-URLs to directly drop into a debugging session. My script can be found at Expected behavior When cmd-clicking this link from inside VSCode, I would expect to be dropped into the debugging session <img width="1287" alt="Screenshot 2022-08-22 at 10 25 59" src="https://user-"Actual behavior Instead, the link gets opened in VS Code's search bar <img width="904" alt="Screenshot 2022-08-22 at 10 27 17" src="https://user-"Additional information I am sure the link itself is fine, because when I copy it from the console and paste it into Chrome's address bar, then VSCode opens my debugging session as expected. Also see VS Code version: Code 1.70.2 (, 2022-08-16T05:36:37.829Z) OS version: Darwin x64 21.6.0 Modes: Remote OS version: Linux x64 5.15.0-30-generic Remote OS version: Linux x64 5.15.0-30-generic <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ better-cpp-syntax1.15.19 jupyter-keymap1.0.0 remote-ssh0.84.0 remote-ssh-edit0.80.0 llvm0.1.1 vscode-clangd0.1.21 vscode-lldb1.7.4 </details<!-- generated by issue reporter --
since the url would need to open a JS/browser debug session, would the JavaScript Debugger Companion Extension be of help here?
This is debugging with lldb, so it's not in the domain of js-debug
This is a request to essentially hook up the terminal link detector to whatever handles external custom protocol links. We may be able to just add vscode:// and vscode-insiders:// to the uri detection? This may need changes in the editor's link detector
Change:
export interface IFeedbackService { submitFeedback(feedback: IFeedback): void; <ins> getCharacterLimit(sentiment: number): number; </ins> } export interface IFeedbackDropdownOptions {

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?