jiebi/CodeConvo huggingface dataset:
Change:
if (translated === undefined && originalMessages) { translated = originalMessages[messageKey]; } <del> const message: string | undefined = typeof translated === 'string' ? translated : translated.message; if (message !== undefined) { // This branch returns ILocalizedString's instead of Strings so that the Command Palette can contain both the localized and the original value. const original = originalMessages?.[messageKey]; const originalMessage: string | undefined = typeof original === 'string' ? original : original?.message; if ( // if we are translating the title or category of a command command && (key === 'title' || key === 'category') && // and the original value is not the same as the translated value originalMessage && originalMessage !== message ) { const localizedString: ILocalizedString = { value: message, original: originalMessage }; obj[key] = localizedString; } else { obj[key] = message; </del> <ins> const message: string | undefined = typeof translated === 'string' ? translated : translated?.message; // This branch returns ILocalizedString's instead of Strings so that the Command Palette can contain both the localized and the original value. const original = originalMessages?.[messageKey]; const originalMessage: string | undefined = typeof original === 'string' ? original : original?.message; if (!message) { if (!originalMessage) { console.warn(`[${extensionManifest.name}]: ${localize('missingNLSKey', "Couldn't find message for key {0}.", messageKey)}`); </ins> } <ins> return; } if ( // if we are translating the title or category of a command command && (key === 'title' || key === 'category') && // and the original value is not the same as the translated value originalMessage && originalMessage !== message ) { const localizedString: ILocalizedString = { value: message, original: originalMessage }; obj[key] = localizedString; </ins> } else { <del> console.warn(`[${extensionManifest.name}]: ${localize('missingNLSKey', "Couldn't find message for key {0}.", messageKey)}`); </del> <ins> obj[key] = message; </ins> } } } else if (isObject(value)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.72.2 (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: for example. Have an entry in for a command but misspell the part: of the other localizations load: ! Issue observed in Python extension: and Jupyter: cc/
Change:
return; // ignore transitions in files from no mode to specific mode because this happens each time a model is created } <del> this._widgets.forEach(widget => widget.notifyModelModeChanged(e)); </del> <ins> this._widgets.forEach(widget => widget.notifyModelModeChanged(e.model)); })); // notify when model is added this._register(this.modelService.onModelAdded(model => { if (!model.uri) { return; // we need the resource to compare } this._widgets.forEach(widget => widget.notifyModelAdded(model)); </ins> })); // notify when file decoration changes

Discussion:
Issue Type: <bBug</bto something like . a new tab. The tab should have the Markdown icon, but it has the Plain Text icon. If you move to another tab then back, the icon will be updated. This only started happening when I updated to 1.3, and it's still happening in Insiders. I've got no extensions or settings (other than ) set. VS Code version: Code - Insiders 1.31.0-insider (, 2018-12-21T06:14:53.023Z) OS version: Darwin x64 18.2.0 <!-- generated by issue reporter --
This is a consequence of adopting : When the tab opens we immediately render the icon, but the resource only gets the mode associated after a on the end of the tick.
via
Change:
// Import the effects we need import { Color } from 'vs/base/common/color'; <del> import { registerColor, darken, lighten, ifDefinedThenElse, transparent } from 'vs/platform/theme/common/colorUtils'; </del> <ins> import { registerColor, darken, lighten, transparent } from 'vs/platform/theme/common/colorUtils'; </ins> // Import the colors we need import { foreground, contrastBorder, activeContrastBorder, focusBorder, iconForeground } from 'vs/platform/theme/common/colors/baseColors';

Discussion:
using Default Light + theme run peek references <img width="978" alt="Screenshot 2024-03-26 at 17 30 37" src=""
Change:
description: nls.localize('search.globalFindClipboard', "Controls whether the search view should read or modify the shared find clipboard on macOS."), included: platform.isMacintosh }, <del> 'search.location': { type: 'string', enum: ['sidebar', 'panel'], default: 'sidebar', description: nls.localize('search.location', "Controls whether the search will be shown as a view in the sidebar or as a panel in the panel area for more horizontal space."), }, </del> 'search.collapseResults': { type: 'string', enum: ['auto', 'alwaysCollapse', 'alwaysExpand'],

Discussion:
mentions that it's deprecated, but it still shows up in intellisense: !
Change:
/// Number of bytes for the secret keys. See workbench.ts for their usage. const SECRET_KEY_BYTES: usize = 32; /// Path to mint the key combining server and client parts. <del> const SECRET_KEY_MINT_PATH: &str = "/_vscode-cli/mint-key"; </del> <ins> const SECRET_KEY_MINT_PATH: &str = "_vscode-cli/mint-key"; </ins> /// Cookie set to the `SECRET_KEY_MINT_PATH` const PATH_COOKIE_NAME: &str = "vscode-secret-key-path"; <del> /// Cookie set to the `SECRET_KEY_MINT_PATH` const PATH_COOKIE_VALUE: &str = concatcp!( PATH_COOKIE_NAME, "=", SECRET_KEY_MINT_PATH, "; SameSite=Strict; Path=/" ); </del> /// HTTP-only cookie where the client's secret half is stored. const SECRET_KEY_COOKIE_NAME: &str = "vscode-cli-secret-half";

Discussion:
The command was augmented with the argument here in Because the does not include the , any attempts to mint a key will result in a 404 if the server-base-path is set. I think this is the reason why I am experiencing an issue that any sign-in attempt in the browser (e.g., Github Copilot, Settings Sync) do not persist between page refreshes. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.1 OS Version: x64 Steps to Reproduce: the browser, observe 404s to
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
assigned to you since you approved the original PR
Change:
}, order: 10, group: '2_diff', <del> when: EditorContextKeys.accessibleDiffViewerVisible.negate(), </del> <ins> when: ContextKeyExpr.and( EditorContextKeys.accessibleDiffViewerVisible.negate(), ContextKeyExpr.has('isInDiffEditor'), ), </ins> }); export class AccessibleDiffViewerPrev extends Action2 {

Discussion:
VS Code Version: OS Version: Steps to Reproduce: a Markdown file without pending changes and check the More Actions menu in the upper right of the editor. The Open Accessible Diff Viewer command is visible. Selecting the command has no effect. ! the Markdown preview for the file and check the More Actions menu. The Open Accessible Diff Viewer command is visible. !
Thanks for finding this! I don't know how I missed this.
Fixed by and
Change:
# Register apt repository eval $(apt-config shell APT_SOURCE_PARTS Dir::Etc::sourceparts/d) CODE_SOURCE_PART=${APT_SOURCE_PARTS}vscode.list <ins> CODE_SOURCE_PART_DEB822=${APT_SOURCE_PARTS}vscode.sources </ins> eval $(apt-config shell APT_TRUSTED_PARTS Dir::Etc::trustedparts/d) CODE_TRUSTED_PART=${APT_TRUSTED_PARTS}microsoft.gpg

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0- OS Version: Debian/testing Steps to Reproduce: previous version already installed the (deprecated) /etc/apt/trusted key folders to /etc/apt/keyrings/ and rewrite all ".list" files with the new format ".sources" update dist-upgrade again After step 4 apt complains about a missing directory: After step 5 it will have created a functional duplicate of as ; this is somehow related to in that the root cause is always the same, main difference is that the key file itself will apparently not be duplicated and apt won't complain (too much).
FYI a reasonable workaround is creating an empty file, then making it mode 444 and immutable. No error is reported on upgrade and no unwanted changes to apt sources occur.
Closing in favour of
Change:
this._viewParts = []; // Keyboard handler <del> this._textAreaHandler = new TextAreaHandler(this._context, viewController, this._createTextAreaHandlerHelper()); </del> <ins> this._textAreaHandler = this._instantiationService.createInstance(TextAreaHandler, this._context, viewController, this._createTextAreaHandlerHelper()); </ins> this._viewParts.push(this._textAreaHandler); // These two dom nodes must be constructed up front, since references are needed in the layout provider (scrolling & co.)

Discussion:
Type: <bBug</bWhen accessibility mode is off and focus is in the editor, pressing Alt +F1 produces the following announcement to screen reader users: "The editor is not accessible at this time. Press Alt+F1 for options.". If one is a new user of the product and screen reader mode doesn't turn on automatically, pressing the command which is supposed to help one get started just repeats the same announcement inviting the user to use Alt +F1 to obtain help. VS Code version: Code - OSS Dev 1.81.0 (Commit unknown, Date unknown) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I filed the bug while running VS Code from source. That's why version information doesn't reflect that I'm using the latest. Correct version information: Version: 1.81.0-insider (user setup) Commit: Date: 2023-07-18T05:36:41.526Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.
Since the help menu is not accessible with that off, instead of we should say to enable screen reader mode.
Change:
// Allows focus to switch to next/previous entry after tab into an actionbar item DOM.addDisposableListener(this.treeContainer.getHTMLElement(), DOM.EventType.KEY_DOWN, (e: KeyboardEvent) => { const keyboardEvent: StandardKeyboardEvent = new StandardKeyboardEvent(e); <ins> // Only handle when not in quick navigation mode if (this.quickNavigateConfiguration) { return; } </ins> if (keyboardEvent.keyCode === KeyCode.DownArrow || keyboardEvent.keyCode === KeyCode.UpArrow || keyboardEvent.keyCode === KeyCode.PageDown || keyboardEvent.keyCode === KeyCode.PageUp) { DOM.EventHelper.stop(e, true); this.navigateInTree(keyboardEvent.keyCode, keyboardEvent.shiftKey);

Discussion:
Press ctrl+tab, hold ctrl Use arrow keys The selection moves down two rows on each press ! Probably not related to your change but can you check if your new arrow key handler is involved somehow?
Looks like this is indeed my new arrow key handler's problem. I thought that the would prevent things like this from happening though?
It will keep it from bubbling up to other elements but I don't think it should prevent it from calling other handlers on the same element. So I think the other listener must actually be on the same element.
Change:
result.range = editorRange.Range.isIRange(suggestion.range) ? Range.to(suggestion.range) : undefined; result.range2 = editorRange.Range.isIRange(suggestion.range) ? undefined : { inserting: Range.to(suggestion.range.insert), replacing: Range.to(suggestion.range.replace) }; result.keepWhitespace = typeof suggestion.insertTextRules === 'undefined' ? false : Boolean(suggestion.insertTextRules & modes.CompletionItemInsertTextRule.KeepWhitespace); <del> // 'inserText'-logic </del> <ins> // 'insertText'-logic </ins> if (typeof suggestion.insertTextRules !== 'undefined' && suggestion.insertTextRules & modes.CompletionItemInsertTextRule.InsertAsSnippet) { result.insertText = new types.SnippetString(suggestion.insertText); } else { result.insertText = suggestion.insertText; result.textEdit = result.range instanceof types.Range ? new types.TextEdit(result.range, result.insertText) : undefined; } <del> // TODO additionalEdits, command </del> <ins> if (suggestion.additionalTextEdits && suggestion.additionalTextEdits.length > 0) { result.additionalTextEdits = suggestion.additionalTextEdits.map(e => TextEdit.to(e as modes.TextEdit)); } result.command = converter && suggestion.command ? converter.fromInternal(suggestion.command) : undefined; </ins> return result; }

Discussion:
If you return in a completion item, the property is when calling through . Setup: Test code: Output is: Full repro project is here:
It looks like the conversion is missing. The doc states that additionalTextEdits should not overlap with the main edit range or each other, should that be checked or is that done when the edits are carried out? Adding this: ! works, unless the range intersections need to be checked.
No checks required - this is already the way back from the UX and check should have been carried out already
Change:
} getDimensions() { <del> return this._body?.getDimensions(); </del> <ins> return this._body.getDimensions(); </ins> } layout(widthInPixel?: number) {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Our users want to see which comments need to be worked on next. During a review round there might be some comments which are not actionable anymore as their threads got resolved. For better overview we think it is valuable to be able to expand only all unresolved (and therefore actionable) comments. Since we can't use anymore to do this from our extension. Reading there is no intention in bringing back this functionality. Introducing commands like (and probably also ) could be a way bring back some control over comment collapsed state to the extension without the need for extension to directly. cc
Tentatively adding for February.
The new command is "Comments: Expand Unresolved Comments".
To verify: Open a workspace with unresolved comments (a PR with comments using the GitHub Pull Requests and Issues extension works well for this). Collapse some comments in the editor. Run "Comments: Expand Unresolved Comments" and verify that all unresolved comments are expanded.
If a comment is already collapsed when I open the file, the command "Expand Unresolved Comments" doesn't work repro: an unresolved comment the current tab the tab again run the command - the comment is not expanded https://user-
good find! Will be fixed in the next insiders build.
Change:
const idx = this._notebookEditor.getViewModel().getCellIndex(element); const length = this._notebookEditor.getViewModel().getFoldedLength(idx); <del> DOM.reset(this._container, this.getRunFoldedSectionButton({ start: idx, end: idx + length + 1 }), this.getHiddenCellsLabel(length), this.getHiddenCellHintButton(element)); </del> <ins> const runSectionButton = this.getRunFoldedSectionButton({ start: idx, end: idx + length + 1 }); if (!runSectionButton) { DOM.reset(this._container, this.getHiddenCellsLabel(length), this.getHiddenCellHintButton(element)); } else { DOM.reset(this._container, runSectionButton, this.getHiddenCellsLabel(length), this.getHiddenCellHintButton(element)); } </ins> DOM.show(this._container); const foldHintTop = element.layoutInfo.previewHeight;

Discussion:
When a few cells have been collapsed via markdown cells, a placeholder is displayed The in the placeholder seems to behave like an icon, hence I keep making the assumption that I can click this. However clicking this does nothing, but double clicking will edit the header cell. What I want is the icon to expand the collapsed cells, ! As you can see here, when the mouse is over the icon, it looks like it can be clicked. !
I think there might be some confusion around the purpose of this icon/button. This is the run button for folded sections and doesn't (shouldn't) have any control over the expansion of the folded section. This will execute any code cells within the folded section, and switch to a spinning run indicator (will change in the outline as well if you have code cells visible). The ellipses on the right-hand side of the hint () act as the expand section icon, however there is a bug with the cursor state; it should change to the pointer to more clearly show that you can click it on its own. As for the run button then, I think this a bug more relating to it appearing when there are no code cells within a collapsed section. That should be an easy fix.
Moving to May
Change:
public async createSession(scopes: string[]): Promise<vscode.AuthenticationSession> { try { <del> // For GitHub scope list, order doesn't matter so we immediately sort the scopes const sortedScopes = scopes.sort(); </del> <ins> // For GitHub scope list, order doesn't matter so we use a sorted scope to determine // if we've got a session already. const sortedScopes = [...scopes].sort(); </ins> /* __GDPR__ "login" : {

Discussion:
Issue Type: <bBug</bThe Avatar badge always shows <img width="351" alt="image (7)" src="https://user-"Clicking the action to authenticate doesn't dismiss it. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-20T05:16:17.334Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (39)</summaryExtensionVersion ------ vscode-eslint2.2.2 kusto0.3.8 gitlens-insiders2022.5.1705 prettier-vscode9.5.0 codespaces1.8.1 copilot1.22.5957 vscode-pull-request-github0.42.0 go0.33.0 vscode-language-pack-zh-hans1.68.0 python2022.7. vscode-pylance2022.5.2 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 vscode-ai0.11. vscode-ai-remote0.13. remote-containers0.236.1 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.3 azure-account0.10.1 hexeditor1.9.6 js-debug-nightly2022.5.1817 live-server0.2.12 vscode-github-issue-notebooks0.0.119 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.9 vsliveshare1.0.5561 vetur0.35.0 colab-keymap0.0.4 github-issue-notebook-enhancement0.0.1 vscode-code-renderer0.0.2 vscode-jupyter-checkpoint0.0.1 notification-tester2.5.1 rest-book6.0.1 tldraw-vscode1.13.3 shell-runner-notebooks0.0.2 luna-paint0.14.0 vscode-todo-highlight1.0.5 (3 theme extensions excluded) </details<!-- generated by issue reporter --
after reloading, does the go away?
Reloading fixes the issue for me
Change:
...options, target: indentGuideElement, compact: true, <ins> container: row, </ins> additionalClasses: ['explorer-item-hover'], skipFadeInAnimation: true, showPointer: false,

Discussion:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-16T05:23:44.671Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes /assign <!-- generated by issue reporter --
Thanks! This is also a regression because we are only supposed to show it on files with decorations (such as source control) or overflowing text (such as ).
I don't get this custom hover ever. Can you please add steps to verify?
These custom hovers have been removed from product due to being too buggy at the moment. I will just mark this as verified as this feature isn't ready for testing yet.
Change:
// Failing tests from issues... <del> test.skip('issue #116843: indent after arrow function', () => { </del> <ins> test('issue #208215: indent after arrow function', () => { </ins> <del> // https://github.com/microsoft/vscode/issues/116843 </del> <ins> // https://github.com/microsoft/vscode/issues/208215 </ins> const model = createTextModel("", languageId, {}); disposables.add(model);

Discussion:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have:
Change:
inBlock = true; startLine = i + 1; languageId = line.substring(3).trim(); <del> } else if (inBlock && line.startsWith('```')) { </del> <ins> } else if (inBlock && line.endsWith('```')) { </ins> inBlock = false; const endLine = i; const code = lines.slice(startLine, endLine).join('n');

Discussion:
a chat request that produces some code blocks the accessible view in screen reader mode the keyboard shortcuts or left/right arrows in the toolbar to verify that go to next/previous code block actions work sometimes the cursor doesn't move to the code block

several chat requests a chat response screen reader mode, use to open the accessible view the up arrow on the toolbar to go to the previous response see native alert dialog. it should instead be a screen reader aria alert. !

a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !