jiebi/CodeConvo huggingface dataset:
Change:
"category": "Git" } ], <ins> "keybindings": [ { "command": "git.stageSelectedRanges", "key": "ctrl+k ctrl+alt+s", "mac": "cmd+k cmd+alt+s", "when": "isInDiffEditor" }, { "command": "git.unstageSelectedRanges", "key": "ctrl+k ctrl+u", "mac": "cmd+k cmd+u", "when": "isInDiffEditor" }, { "command": "git.revertSelectedRanges", "key": "ctrl+k ctrl+r", "mac": "cmd+k cmd+r", "when": "isInDiffEditor" } ], </ins> "menus": { "commandPalette": [ {

Discussion:
Git extension needs to use the context and add keybindings only when that context is set. Ctrl/Cmd + K, Cltr/Cmd + S / R / U makes good sense for defaults. fyi
Some shortcut confilcts: <kbdCmd</kbd<kbdK</kbd<kbdCmd</kbd<kbdS</kbdis used by show keyboard shortcuts. <kbdCmd</kbd<kbdK</kbd<kbdCmd</kbd<kbdU</kbdis used by remove line comment.
thanks for pointing out. Yeah we need to find some free keybindings. However this would only be in the diff editor view. So even if we overwrite some like those I think it is fine.
I suppose we could overwrite , but I don't think it'd be best to overwrite, as that's a settings page and we'll probably get an issue or too about that sometime down the road. <kbdCmd</kbd<kbdK</kbd<kbdCmd</kbd<kbdG</kbdis free, perhaps implement another chord? But maybe another accessibility issue for nested chords...
Following discussion at , I would like to work on this issue, too. I also think that we should not override "Open Keyboard Shortcuts". Since staging, is (in my mind) connected with "git add", maybe we could use Ctrl/Cmd + K,Ctrl/Cmd + A While Ctrl/Cmd + K,Ctrl/Cmd + G is also free, but the 'G' key is close to the 'R' key, so it's easier to call the Revert command by mistake.
Forgive my ignorance, but would it be possible to use something like ctrl + k ctrl + shift + s or ctrl + k alt + s? Thanks.
OK, so I am sending a PR with the following keybindings: git: Stage selected ranges ctrl + k, ctrl + shift + s git: Unstage selected ranges ctrl + k, ctrl + u git: Revert selected ranges ctrl + k, ctrl + r
Actually git: Stage selected ranges ctrl + k, ctrl + alt + s is better because ctrl + k, ctrl + shift + s is used for Saving without Formatting.
Great, thanks a lot. I have commented on the PR. As mentioned in the PR is back from vacation and this is not urgent, thus assigning to him and April milestone.
Thanks for the quick review.

However I found another possible conflict with the default keybindings. On my VS Code version which I have downloaded and installed, Ctrl + K Ctrl + R - the keybinding we want to assign to Revert Selected Ranges- is used by the command "Help: Keyboard Shortcuts Reference". However this command is not available on the version of VSCode I built from the source code, that's why I did not notice it at first. For some reason KeybindingsReferenceAction.AVAILABLE is false and the command is not registered: Also I don't understand why the GitHub CI threw an error. Should I worry about it?
Please note that due to conflict with the uncomment line which mentioned I had to change the unstange from to
Change:
export class CellOutputContainer extends CellContentPart { private _outputEntries: OutputEntryViewHandler[] = []; <ins> private _hasStaleOutputs: boolean = false; </ins> get renderedOutputEntries() { return this._outputEntries;

Discussion:
Type: <bBug</bWhen a notebook updates text in a collapsed cells unexpected things happen. The Jupyter Notebook renders the output while still showing that the output is collapsed. Node.JS Notebooks and httpBook show empty cells and will only show the output again when expanded, collapsed, expanded again In the the result looks like this: ! Issue created to hopefully follow up Extension version: 2023.9. VS Code version: Code 1.83.1 (Universal) (, 2023-10-10T23:46:55.789Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
assert.strictEqual(item11.silent, true); }); <ins> test('Items - does not fire changed when message did not change (content, severity)', async () => { const item1 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' })!; let fired = false; item1.onDidChangeContent(() => { fired = true; }); item1.updateMessage('Error Message'); await timeout(0); assert.ok(!fired, 'Expected onDidChangeContent to not be fired'); item1.updateSeverity(Severity.Error); await timeout(0); assert.ok(!fired, 'Expected onDidChangeContent to not be fired'); }); </ins> test('Model', () => { const model = new NotificationsModel();

Discussion:
https://user- a new codespaces using the vscode repo clicking on the logs link :bug: Unable to click on the link Upon inspecting the DOM, it appears that elements are being /removed/updated every second so that may be blocking the link from being clicked on Codespaces Extension: v0.10.2 Version: 1.57.0-insider Commit: Date: 2021-05-20T05:11:47.260Z Electron: 12.0.7 Chrome: 89.0.4389.128 14.16.0 V8: 8.9.255.25-electron.0 OS: Darwin x64 20.3.0
Following up upstream first...
what do you think about not rerendering the notification message if the content didn't change between calls to report? In the codespaces extension I send fake progress updates quickly to smooth out the progress bar, and you can't click a link if it updates at the moment you are clicking it
good catch, indeed we should not update the DOM when contents have not changed. Is this something you would be interested in doing a PR for? I see to locations that could benefit of a check to not emit change events when nothing changed:   I would think for the latter, a simple check for would be sufficient.
Sure
PR:
It looks like "starting codespace" is no longer a link: 
you have to create a new codespace in order for the build logs to appear, connecting to an existing one just resumes the codespace. I can try to reproduce.
Verified <img width="1024" alt="CleanShot 2021-06-07 at 11 29 00 src="https://user-"
Change:
"name": "punctuation.definition.string.end.html" }, "1": { <del> "name": "source.css-ignored-vscode" </del> <ins> "name": "source.css" </ins> } }, "name": "string.quoted.single.html",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.71.0 Commit: Date: 2022-09-01T07:25:10.472Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.10.7-arch1-1 Sandboxed: No Steps to Reproduce: a file with the contents: a SvelteKit project and open any file. as shown in the video. https://user- Result: Without a space - it doesn't work. With space - it works. Cause: When the cursor is in front of the character, it thinks it is already AFTER , although this is not true. PS The same problem is in the last character, before , in the file.
This also happens in the HTML with where being cursor position. The problem seems to be because the position of the cursor is on the border of the embedded language. Maybe it could be changed to using the previous character, when possible, instead of the next?
Thanks - I can reproduce what you are saying. I don't really know what svelte kit is nor what extension you are using. So, I am focusing on html. Using "F1 Inspect Editor Tokens and Scopes" shows me that the language at position is classified as html, not JavaScript. <img width="728" alt="Screenshot 2022-12-05 at 16 22 35" src="https://user-"Because of that no JS snippets are shown. Passing this on to who maintains the TextMate grammars for this.

An easy workaround on your end would be to configure the snippet to also work for the "outer" language
SvelteKit: SvelteJS is the 4th most popular framework (behind ReactJS Vue Angular), and considered to have the best DX of all frameworks. Extension for SvelteJS: But I hope that solving the problem in html/js, will also solve the problem in SvelteJS.
Related to
what do you think of modifying the solution to so that we don't ignore strings? PR
Change:
export class ResolvedAuthority { <ins> public static isResolvedAuthority(resolvedAuthority: any): resolvedAuthority is ResolvedAuthority { return resolvedAuthority && typeof resolvedAuthority === 'object' && typeof resolvedAuthority.host === 'string' && typeof resolvedAuthority.port === 'number' && (resolvedAuthority.connectionToken === undefined || typeof resolvedAuthority.connectionToken === 'string'); } </ins> readonly host: string; readonly port: number; readonly connectionToken: string | undefined;

Discussion:
Version: 1.79.0-insider Commit: Date: 2023-05-16T05:23:57.470Z Electron: 22.5.2 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 5.14.0-1048-oem open a wsl or a dev containers window fails with a notification: Could not fetch remote environment. this.c.makeConnection is not a function
I see the same error, yesterdays version worked fine.
and it is fixed: it seems they rolled back to yesterdays version Version: 1.79.0-insider (user setup) Commit: Date: 2023-05-15T05:20:50.327Z Electron: 22.5.2 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.

ERR this.factory.makeConnection is not a function: TypeError: this.factory.makeConnection is not a function at ExtHostManagedSockets.$openRemoteSocket (c:Usersmartinaeworkspacesvscodeoutvsworkbenchapicommon) at RPCProtocol.doInvokeHandler (c:Usersmartinaeworkspacesvscodeoutvsworkbenchservicesextensionscommon) at RPCProtocol.invokeHandler (c:Usersmartinaeworkspacesvscodeoutvsworkbenchservicesextensionscommon) at RPCProtocol.receiveRequest (c:Usersmartinaeworkspacesvscodeoutvsworkbenchservicesextensionscommon) at RPCProtocol.receiveOneMessage (c:Usersmartinaeworkspacesvscodeoutvsworkbenchservicesextensionscommon) at c:Usersmartinaeworkspacesvscodeoutvsworkbenchservicesextensionscommon at (c:Usersmartinaeworkspacesvscodeoutvsbasecommon) at PrivateEventDeliveryQueue.deliver (c:Usersmartinaeworkspacesvscodeoutvsbasecommon) at (c:Usersmartinaeworkspacesvscodeoutvsbasecommon) at (c:Usersmartinaeworkspacesvscodeoutvsbasepartsipccommon) at c:Usersmartinaeworkspacesvscodeoutvsworkbenchapinode at (c:Usersmartinaeworkspacesvscodeoutvsbasecommon) at PrivateEventDeliveryQueue.deliver (c:Usersmartinaeworkspacesvscodeoutvsbasecommon) at (c:Usersmartinaeworkspacesvscodeoutvsbasecommon) at (c:Usersmartinaeworkspacesvscodeoutvsbasepartsipccommon) at MessagePortMain.<anonymous(c:Usersmartinaeworkspacesvscodeoutvsworkbenchapinode) at (node:events:513:28) at (node:electron/js2c/utilityinit:2:367)
for me now the forwarded ports on remote hosts are broken:
Change:
<del> ## Find in Outputs * Find is no longer **synchronous** * Progress bar in Find Widget * Require all outputs to be rendered first * `window.find` * Shadow DOM nodes are skipped in non-chromium browsers * no builtin css rule for find match color * `hiliteColor` * Modifies DOM * Shadow DOM not supported, we can potentially have our own impl * Find match range serialization `document.getSelection` * `document.getSelection().getRangeAt(0).cloneRange()` not immutable, changed when document active selection changes * range will be invalid after `hiliteColor` executed * require our own serialization/deserialization * Performance * `window.find` can be slow * We currently travese the DOM tree to figure out which cell/output contain the find match belongs to, it's really costly. One idea is checking the absolute position of the find match and compare it with output container positions. * Search only rendered outputs * MutationObserver for output change * Change active selection to the beginning of the new output and then request `window.find` </del>

Discussion:
<img width="980" alt="image" src="https://user-"
I suggest to move the docs into our wiki. PR to remove these files:
Change:
dispose(): void; } <ins> export function dispose<T extends IDisposable>(disposable: T): T { if (disposable) { disposable.dispose(); } return null; } </ins> export function disposeAll<T extends IDisposable>(arr: T[]): T[] { if (arr) { for (let i = 0, len = arr.length; i < len; i++) {

Discussion:
VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) "publ" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: "acceptSelectedSuggestion" without the caret still works
Looking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.
I can confirm it doesn't work on TypeScript due to the context key not being set.
There is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting
Despite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work
the timeout and like breakage happened in
Oh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?
works
Change:
} .extension-editor > .body { <del> height: calc(100% - 168px); </del> <ins> flex: 1; </ins> overflow: hidden; }

Discussion:
Notice the status bar in the bottom of the workbench: !
let me know if investigation suggests you are getting the wrong dimensions somehow
Any reliable repo steps?
This is weird, but surely reproducible. I can reproduce on my Windows 10 VM (running in QEMU/KVM, Linux host), screen resolution set to 1440x1050: Code. Make sure window is full screen. If it isn't, make it fullscreen, close it and launch Code again. to extension viewlet, search for Azure Repos extension and open it. for it to load and close it. it again. !
Not only status bar... <img width="1268" alt="2019-11-2211 45 08" src="https://user-"
My console also disappeared. This only happens when opening extensions with suggestions. <img width="987" alt="normal" src="https://user-"on extension that contains suggestions (Star mark in upper right corner). <img width="987" alt="contains-suggestions" src="https://user-"buttons are overwritten if there is too much suggestions text. <img width="810" alt="console-disappeared" src="https://user-"guess the problem is from div . I open the developer tools. add , can make console buttons reappear. <img width="1445" alt="try-to-fix" src="https://user-"
Reproduced using Visual Studio Code for MacOS System Info:
To repo, just open a recommended extension. This causes the page layout to be off since the recommendation makes the header taller
Change:
const shellIntegration = nls.localize('shellIntegration', "The terminal has a feature called shell integration that offers an enhanced experience and provides useful commands for screen readers such as:"); const runRecentCommand = nls.localize('runRecentCommand', 'Run Recent Command ({0})'); const runRecentCommandNoKb = nls.localize('runRecentCommandNoKb', 'Run Recent Command is currently not triggerable by a keybinding.'); <ins> const goToRecentNoShellIntegration = nls.localize('goToRecentDirectoryNoShellIntegration', 'The Go to Recent Directory command ({0}) enables screen readers to easily navigate to a directory that has been used in the terminal.'); const goToRecentNoKbNoShellIntegration = nls.localize('goToRecentDirectoryNoKbNoShellIntegration', 'The Go to Recent Directory command enables screen readers to easily navigate to a directory that has been used in the terminal and is currently not triggerable by a keybinding.'); </ins> const goToRecent = nls.localize('goToRecentDirectory', 'Go to Recent Directory ({0})'); const goToRecentNoKb = nls.localize('goToRecentDirectoryNoKb', 'Go to Recent Directory is currently not triggerable by a keybinding.'); const readMoreLink = nls.localize('readMore', '[Read more about terminal accessibility](https://code.visualstudio.com/docs/editor/accessibility#_terminal-accessibility)');

Discussion:
CC The terminal help instruction on "Go to Recent Directory (Control+G)" is only available when integrated shell is used. Try Alt+F1 in cmd prompt. You won't see that.
Thank you for the issue and clarification. That is by design because the command isn't supported/doesn't exist without shell integration. This is because we can only have knowledge of cwds via shell integration insights
-- As far as I tested, Ctrl+G works in CMD prompt as well. Please correct me if I am wrong.
Ctrl+R does not work though.
You are correct
To verify, disable shell integration or use a shell without shell integration support like command prompt and check that the terminal accessibility help menu includes info on the go to recent directory command
Change:
@IAccessibilityService private readonly _accessibilityService: IAccessibilityService, @IKeybindingService private readonly _keybindingService: IKeybindingService, @ILayoutService private readonly _layoutService: ILayoutService, <del> @IMenuService private readonly _menuService: IMenuService </del> <ins> @IMenuService private readonly _menuService: IMenuService, @ICommandService private readonly _commandService: ICommandService </ins> ) { super();

Discussion:
!
In the chat view responses, users can hit on the link, so we will do the same here.
to verify: run an command that produces file links open the accessible view by focusing that chat response and using move your cursor to the link and press the file should be opened
Change:
} }, true); }, <del> weight: KeybindingWeight.WorkbenchContrib, </del> <ins> weight: KeybindingWeight.WorkbenchContrib + 1, </ins> primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KeyK, KeyMod.CtrlCmd | KeyCode.KeyI), when: ContextKeyExpr.and(RawCustomTreeViewContextKey, WorkbenchListFocusContextKey) });

Discussion:
macOS, VS Code Insiders into explorer focus via keyboard hover does not show. There is no command to trigger the custom hover to show Like the activity bar, we have to make sure that the custom hover can be accessed in the tree/list only with the keyboard.
Would you suggest adding a keybinding to toggle the visibility of the custom hover of the html element which has focus?
Yeah, ideally it is . The same shortcut that we use in the editor for showing the hover. So it is consistent and easy for user to understand that there is one shortcut which does the right thing everywhere.
Isn't this a duplicate of ? Btw we seem to be having this support for extension provided trees at least:
I think it's good to have this one separate to .
Solving this for all trees/lists is pretty hard as the tree/list does not know anything about the underlying elements being rendered. For extension trees it is much easier as they all consist of a label which the creates and controls.
One option could be to utilize the to get the tooltip. Currently it already provides
After further discussions we came to the conclusion that we would use the DOM tree to figure out if there is any custom hovers available and trigger the hover by dispatching a mouse event on the HTMLElement. This might seem rather hacky but it ensures the consumers of the tree only have to support hover once and lets the tree handle keyboard triggers. Handling focus is still tricky and a open problem. Until this focus problem is properly fixed the treeview will keep it's own implementation which directly uses the hover service and moves the focus into the hover. The treeview implementation of this has it's own flaws but will b kept for the meantime to not cause regressions.
Change:
mkdir -p %{buildroot}%{_bindir} mkdir -p %{buildroot}%{_datadir}/%{name} mkdir -p %{buildroot}%{_datadir}/applications <ins> mkdir -p %{buildroot}%{_datadir}/appdata </ins> mkdir -p %{buildroot}%{_datadir}/mime/packages mkdir -p %{buildroot}%{_datadir}/pixmaps mkdir -p %{buildroot}%{_datadir}/bash-completion/completions

Discussion:
Neither the vscode repository nor the package itself provide any appdata, which is important to have gnome-software working properly. The vscode repository should generate appstream data (xml) and provide them. So the PackageKit can save it into /var/cache/app-info/xmls/. The itself also should install a into /usr/share/metainfo/. Look here:
I believe we include in the root of the package, is that not the case?
Unfortunately, it is not the case. There's no or file. Output from : The preferred place for that appdata file is Then the repository creation should also include generating AppStream repository metadata. The mechanics of doing this is documented here: (Ignore the argument, that should not be used)
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This should be reopened, because it's still broken.
Confirmed that the deb package is good but that the rpm package has this issue.
I have about 200 messages coming a day I don't know what happened how do I unsubscribe from this Microsoft thing vs code please advise
see
Verification steps: the on a Linux distribution with rpm (the link downloads an x64 .rpm file) in a terminal that shows up.
Change:
const syncIgnoredElement = DOM.append(container, $('span.setting-item-ignored')); const syncIgnoredLabel = new SimpleIconLabel(syncIgnoredElement); syncIgnoredLabel.text = `($(sync-ignored) ${localize('extensionSyncIgnoredLabel', 'Sync: Ignored')})`; <ins> syncIgnoredLabel.title = localize('syncIgnoredTitle', "Settings sync does not sync this setting"); </ins> return syncIgnoredElement; }

Discussion:
Testing Focus on a setting that is ignored to sync Voice over does not read that setting is ignored to sync <img width="647" alt="image" src="https://user-"
One setting to check this issue with is . It is one of those settings that settings sync ignores.
I still see Voice Over not reading it <img width="882" alt="image" src="https://user-"<img width="774" alt="Screenshot 2022-02-02 at 16 02 23" src="https://user-"I am reopening it as verification found. Since it is not a blocker moving this to next milestone.
Change:
return Promise.resolve(undefined); } <ins> // Wait for the last execution to complete before executing if (this.setTreeInputPromise) { await this.setTreeInputPromise; } </ins> const initialInputSetup = !this.tree.getInput(); if (initialInputSetup) { perf.mark('code/willResolveExplorer');

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --For example when I open a project in v, I expand the folder on the file tree. When I refresh the whole page, the default behavior now is that the folders are collapsed, which means that I need to expand the folders one by one again the last time I opened them. !
If the expansion state of the file tree folder can remember the last expansion like tabs, similar to the gif below, I think this is a better effect. !
I have fixed this problem and will mention a pr later.
The reason for this problem is that there are multiple calls to the function during the rendering of the file tree. The state will be read from the cache for the first time, but before the execution is completed for the first time, the will be executed again. At this time, the tree already has a value. However, because the file tree data is not ready (because the data on the Web side is asynchronous), the state returned by the function is empty, resulting in the final file tree returning to the default collapsed state.