jiebi/CodeConvo huggingface dataset:
Change:
} }); <del> if (shouldStartDetection) { </del> <ins> if (shouldStartDetection && !this._detectionMap.has(notebookType)) { </ins> const task = this._notebookKernelService.registerNotebookKernelDetectionTask({ notebookType: notebookType });

Discussion:
Testing microsoft/vscode-jupyter Remote-SSH to a remote linux machine, from mac Open a notebook "Detecting Kernels" has been there for minutes
Just as I filed this, it updated to show a kernel name, and still has the spinner. You can see the 10 minute gap in the updated log
Based on the logs Extension loads at 15:44:46 And kernel discovery finishes at 15:44:53 At 15:53:32 the kernel selection changed (either you selected this manually or vscode selected this or other) I.e. i don't see any issues (at least not from the logs()
I updated to get your logs. I see Oddly, when I debugged the extension on the same remote, same folder, I didn't see this issue. But in normal insiders with the latest extension, I see it 100% of the time
based on the logs we start the spinner and dispose the task, we only do this once meaning there aren't multiple tasks created by us, the only one created gets disposed. I.e. i think the cause for an infinite spinner must be in core
Change:
rows: number; } <ins> const shellIntegrationSupportedShellTypes = [PosixShellType.Bash, PosixShellType.Zsh, PosixShellType.PowerShell, WindowsShellType.PowerShell]; </ins> const scrollbarHeight = 5; class TerminalOutputProvider implements ITextModelContentProvider {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows 10 Steps to Reproduce: When I open a terminal in VSCode the following warning is logged within a few seconds: . I take note of that this issue is not a duplicate of.
A warning as in on the window output channel or devtools console? Do you use powerlevel10k or another complex prompt by chance?
It's in the devtools console. Not using any complex prompt. Just plain CMD.
Oh OK, that's unexpected if it's cmd, thanks for the info
we should probably do something like here
Change:
</thead> <tbody><tr> <td><span class="codicon codicon-zap"></span></td> <del> <td><a data-href="#link" href="" title="#link"><span class="codicon codicon-zap"></span>-link</a></td> </del> <ins> <td><a data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></td> </ins> </tr> </tbody></table> `);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: macOS 12.0.1 Steps to Reproduce: a markdown and add a link on the link, drag the link rendered in hover widget to the editor https://user- It seems that markdown renderer removes property and uses instead. I'm glad if I can help but I don't know if it's by design. Can we keep both and on links?
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!
Fix actually seems pretty easy here so reopening
Change:
if (defaultUri && defaultUri.scheme !== Schemas.file) { return Promise.reject(new Error('Not supported - Open-dialogs can only be opened on `file`-uris.')); } <del> const filters = []; if (options.filters) { for (let name in options.filters) { filters.push({ name, extensions: options.filters[name] }); } } </del> const newOptions: OpenDialogOptions = { title: options.title, defaultPath: defaultUri && defaultUri.fsPath, buttonLabel: options.openLabel, <del> filters, </del> <ins> filters: options.filters, </ins> properties: [] }; newOptions.properties.push('createDirectory');

Discussion:
Env: In Insider version, the API doesn't respect the option. The same code works in the normal vscode 1.28.2.
The code here converts the filters from the extension API into the electron API, but the function is supplied with the electron API format so this is not necessary and is causing the break.
I think this is something that we should ship with 1.29
We believe this is a regression, adding candidate label
Change:
${this._getStyles(resourceProvider, sourceUri, config, imageInfo)} <base href="${resourceProvider.asWebviewUri(markdownDocument.uri)}"> </head> <del> <body class="vscode-body style="overscroll-behavior-x: none;" ${config.scrollBeyondLastLine ? 'scrollBeyondLastLine' : ''} ${config.wordWrap ? 'wordWrap' : ''} ${config.markEditorSelection ? 'showEditorSelection' : ''}"> </del> <ins> <body class="vscode-body ${config.scrollBeyondLastLine ? 'scrollBeyondLastLine' : ''} ${config.wordWrap ? 'wordWrap' : ''} ${config.markEditorSelection ? 'showEditorSelection' : ''}"> </ins> ${body.html} ${this._getScripts(resourceProvider, nonce)} </body>

Discussion:
Type: <bBug</bGot the June update this morning. Noticed this stopped working: markdown.preview.markEditorSelection Looking at the HTML in dev tools the body tag looks malformed: I copied this with extensions disabled. VS Code version: Code 1.80.0 (, 2023-07-04T15:06:02.407Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (66)</summaryExtensionVersion ------ increment-selection0.2.0 Bookmarks13.3.1 rtf2.7.0 vscode-unfancy-file-icons3.15.0 html-end-tag-labels1.0.0 icons-carbon0.2.6 vscode-open-file-folder0.0.4 markdown-footnotes0.1.1 insert-unicode0.14.0 markdown-toc1.5.6 reverse-search2.0.2 vscode-markdownlint0.51.0 vscode-simpler-icons1.6.5 vscode-eslint2.4.2 vscode-quick-select0.2.9 githistory0.6.20 xml2.5.1 overtype0.5.0 vsc-material-theme-icons2.8.0 prettier-vscode9.19.0 font-switcher4.1.0 auto-close-tag0.5.14 dotnet-test-explorer0.7.8 macros1.2.1 html-preview-vscode0.2.5 live-sass6.0.5 todo-tree0.0.226 vscode-htmlhint1.0.5 docomment1.0.0 vscode-autohotkey-plus-plus3.3.2 markdown-shortcuts0.12.0 render-crlf1.6.1 fluent-icons0.0.18 .8.0 csharp1.26.0 vscode-dotnet-runtime1.6.0 powershell2023.6.0 vscode-paste-image1.0.4 fix-json0.1.2 subtitles-editor1.1.7 material-icon-theme4.28.0 material-product-icons1.5.0 word-counter0.0.1 toggle0.0.2 vscode-sort-json1.20.0 partial-diff1.4.3 block-travel0.0.2 MDTools1.0.1 vscode-table-formatter1.

2.1 vscode-fileutils3.10.2 uridecode0.3.6 character-count0.1.1 code-spell-checker2.20.5 code-spell-checker-british-english1.1.4 code-spell-checker-french0.3.1 code-spell-checker-german2.2.1 code-spell-checker-greek1.0.4 code-spell-checker-italian1.0.2 code-spell-checker-medical-terms2.0.3 code-spell-checker-scientific-terms0.1.9 code-spell-checker-spanish2.1.9 duplicate-finder0.0.6 vscode-w3cvalidation2.9.1 vscode-icons12.4.0 copyrawvalue1.0.0 markdown-all-in-one3.5.1 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Introduced by Should just move the style to the css file instead
Closing as this looks to be merged.
Change:
registerAction2(InlineChatActions.DiscardToClipboardAction); registerAction2(InlineChatActions.DiscardUndoToNewFileAction); registerAction2(InlineChatActions.CancelSessionAction); <ins> registerAction2(InlineChatActions.MoveToNextHunk); registerAction2(InlineChatActions.MoveToPreviousHunk); </ins> registerAction2(InlineChatActions.ArrowOutUpAction); registerAction2(InlineChatActions.ArrowOutDownAction);

Discussion:
open inline chat have it make multiple hunks (hint: ask it to use a util that needs to be imported) there is no gesture to visit all hunks except for accepting/discarding them... This can also help with accessibility when using the move
To verify let inline chat make multiple changes, e.g ask it to import a util or let is change the label of two actions make sure the inline chat status says "N changes" (n=2) select and to navigate between the changes
Change:
import { Action2, IAction2Options, MenuRegistry, registerAction2 } from 'vs/platform/actions/common/actions'; import { ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { localize } from 'vs/nls'; <del> import { IEditSessionsStorageService, Change, ChangeType, Folder, EditSession, FileType, EDIT_SESSION_SYNC_CATEGORY, EDIT_SESSIONS_CONTAINER_ID, EditSessionSchemaVersion, IEditSessionsLogService, EDIT_SESSIONS_VIEW_ICON, EDIT_SESSIONS_TITLE, EDIT_SESSIONS_SHOW_VIEW, EDIT_SESSIONS_SIGNED_IN, EDIT_SESSIONS_DATA_VIEW_ID, decodeEditSessionFileContent } from 'vs/workbench/contrib/editSessions/common/editSessions'; </del> <ins> import { IEditSessionsStorageService, Change, ChangeType, Folder, EditSession, FileType, EDIT_SESSION_SYNC_CATEGORY, EDIT_SESSIONS_CONTAINER_ID, EditSessionSchemaVersion, IEditSessionsLogService, EDIT_SESSIONS_VIEW_ICON, EDIT_SESSIONS_TITLE, EDIT_SESSIONS_SHOW_VIEW, EDIT_SESSIONS_DATA_VIEW_ID, decodeEditSessionFileContent } from 'vs/workbench/contrib/editSessions/common/editSessions'; </ins> import { ISCMRepository, ISCMService } from 'vs/workbench/contrib/scm/common/scm'; import { IFileService } from 'vs/platform/files/common/files'; import { IWorkspaceContextService, IWorkspaceFolder, WorkbenchState } from 'vs/platform/workspace/common/workspace';

Discussion:
Testing I would expect that this action always appears in the command palette. Today, it only appears after running or first.
Change:
${this.getExtensionVersion()} VS Code version: ${this._data.versionInfo && this._data.versionInfo.vscodeVersion} OS version: ${this._data.versionInfo && this._data.versionInfo.os} <ins> Restricted Mode: ${this._data.restrictedMode ? 'Yes' : 'No'} </ins> ${this.getRemoteOSes()} ${this.getInfos()} <!-- generated by issue reporter -->`;

Discussion:
When I report an issue from our issue reporter from an untrusted workspace, there is no info about this in the GH issue.
Marking as important to make sure we care about this before enabling trust by default to not make our life harder for triaging issues than it needs to be.
Two examples: in an effort to make the smallest change this late in the game, I’ve put it in System Info however when you report a performance issue, we also have a section called “Workspace Info” that shows up that gives details on the workspace (like number of files, etc). I think it should eventually go there
lol jk sent a PR putting it next to the OS which I don't love... but the change is small and it means the user can't not tell us their WT situation which is good.
Change:
const actionHandler = options.actionHandler; if (actionHandler) { <del> actionHandler.disposeables.add(DOM.addStandardDisposableListener(element, 'click', event => { let target: HTMLElement | null = event.target; if (target.tagName !== 'A') { target = target.parentElement; if (!target || target.tagName !== 'A') { </del> <ins> [DOM.EventType.CLICK, DOM.EventType.AUXCLICK].forEach(event => { actionHandler.disposeables.add(DOM.addDisposableListener(element, event, (e: MouseEvent) => { const mouseEvent = new StandardMouseEvent(e); if (!mouseEvent.leftButton && !mouseEvent.middleButton) { </ins> return; } <del> } try { const href = target.dataset['href']; if (href) { actionHandler.callback(href, event); </del> <ins> let target: HTMLElement | null = mouseEvent.target; if (target.tagName !== 'A') { target = target.parentElement; if (!target || target.tagName !== 'A') { return; } </ins> } <del> } catch (err) { onUnexpectedError(err); } finally { event.preventDefault(); } })); </del> <ins> try { const href = target.dataset['href']; if (href) { actionHandler.callback(href, mouseEvent); } } catch (err) { onUnexpectedError(err); } finally { mouseEvent.preventDefault(); } })); }); </ins> } // Use our own sanitizer so that we can let through only spans.

Discussion:
I have muscle memory for middle-clicking on links (to open in a new tab) and it doesn't work in VS Code. ! If I middle-click on the link above, it opens a browser to
are you using VSCode in Electron or Web? Does it work when you click normally and if so what happens then?
This is in Electron (haven't tried on the web). And it works perfectly on a normal click.
OK, making this open for help if someone wants to chime in.
Created a PR to fix this
History shows as the one introducing the handler but I am not sure who the owner is today.
Change:
import { AbstractExtensionService, ExtensionRunningPreference, extensionRunningPreferenceToString } from 'vs/workbench/services/extensions/common/abstractExtensionService'; import { RemoteExtensionHost, IRemoteExtensionHostDataProvider, IRemoteExtensionHostInitData } from 'vs/workbench/services/extensions/common/remoteExtensionHost'; import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; <del> import { IWebWorkerExtensionHostDataProvider, WebWorkerExtensionHost } from 'vs/workbench/services/extensions/browser/webWorkerExtensionHost'; </del> <ins> import { IWebWorkerExtensionHostDataProvider, IWebWorkerExtensionHostInitData, WebWorkerExtensionHost } from 'vs/workbench/services/extensions/browser/webWorkerExtensionHost'; </ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { ExtensionIdentifier, IExtensionDescription, IExtension, ExtensionType } from 'vs/platform/extensions/common/extensions'; import { ExtensionKind } from 'vs/platform/environment/common/environment';

Discussion:
When running a web worker extension on vscode desktop, the error appears. To reproduce, you can use the following extension: : :
Change:
} } <ins> public batchEvents(callback: () => void): void { this._withViewEventsCollector(() => { callback(); }); } </ins> normalizePosition(position: Position, affinity: PositionAffinity): Position { return this._lines.normalizePosition(position, affinity); }

Discussion:
I set a 'placeholder' editor decoration here: I noticed that when the chat input had multiple lines of text in it, then the placeholder doesn't show up. Here I show it not working, then working with a single line of text. ! Maybe it's related somehow to the issue we had in I can't debug this on my own, but it reproes 100% of the time for me, happy to help investigate.
This fixes it, but it sucks. it looks like cannot be used when certain events are fired. Looks like the view fires a scroll change event, which causes the event queue to flush, which causes a content change event, which calls the callback that sets the decoration...
AFAIK nothing changed here in the editor recently, so not sure if this is bad enough to add the workaround Henning found for this release on your side. IMHO we need to add proper placeholder API to the editor instead of doing this from the outside with injected text. We now have something like 3 or 4 places implementing placeholder text via injected text, which doesn't make sense to me.
Created for the placeholder API. Feel free to close this one in favor of
The event stack is quite complicated. Below is the stack of where the decoration is set. The core problem is that fires an event and allows event handlers to run immediately: ! Error at eval at at at at at at at at at at at at at at at at at at at at at at func at safeInvokeNoArg at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at at
Change:
private update(): void { this.localizationService.getLanguageIds() <del> .then(languageIds => registerLocaleDefinitionSchema(languageIds)); </del> <ins> .then(languageIds => { let lowercaseLanguageIds: string[] = []; languageIds.forEach((languageId) => { let lowercaseLanguageId = languageId.toLowerCase(); if (lowercaseLanguageId !== languageId) { lowercaseLanguageIds.push(lowercaseLanguageId); } }); registerLocaleDefinitionSchema([...languageIds, ...lowercaseLanguageIds]); }); </ins> } }

Discussion:
Although "zh-cn" works, but there is a prompt: "value is not accepted". !
Change:
// collect all decoration ids that are affected by the ranges // and only update those decorations const decorationIdsToReplace: string[] = []; <del> for (const range of ranges) { for (const { id } of this._editor.getDecorationsInRange(range) ?? []) { const metadata = this._decorationsMetadata.get(id); if (metadata) { decorationIdsToReplace.push(id); metadata.classNameRef.dispose(); this._decorationsMetadata.delete(id); } </del> <ins> for (const [id, metadata] of this._decorationsMetadata) { const range = this._editor.getModel()?.getDecorationRange(id); if (range && ranges.some(r => r.containsRange(range))) { decorationIdsToReplace.push(id); metadata.classNameRef.dispose(); this._decorationsMetadata.delete(id); </ins> } }

Discussion:
This method: Calls this for loop: ... querying all decorations in the file. Because bracket pair colorization is implemented using decorations, this queries a ton of data for bigger files (for there are decorations). Generally I think should only be called for small ranges.
In this a theoretical problem or something that shows up in the profiler?
The call took ~200ms on my machine when opening I found this when profiling something else.
Is there a way to look up decorations by id? If I could do that I can turn the loop around: look up my decorations by id and check the range with the needs-update-range
There is on
Change:
import product from 'vs/platform/node/product'; import pkg from 'vs/platform/node/package'; import * as path from 'path'; <ins> import * as semver from 'semver'; </ins> import { TPromise } from 'vs/base/common/winjs.base'; import { sequence } from 'vs/base/common/async';

Discussion:
Similar to the in Atom, there should be a way to update Marketplace extensions from the command line. Currently there are and commands, but no command for upgrading extensions.
Hello! I've been checking this issue to make a first contribution, but it seems that already has that functionality! To test it, I installed an out of extension from the vsix file and then did this: So... Maybe we should just alias the command, or is this missing any functionality I'm not noticing? Thanks!
That's what I thought! Good to know. Yeah let's just have an alias for it.
Hmm... Looking at the code, it seems we check if an extension is installed and return if it is.
as I understand the code (very, very limited understanding!), and after the quick test I did, I would think that check for the extension being installed only returns true if the extension is up to date.
I don't think so. There is no checks on version in the above code.
Anyone working on this feature? I am a beginner but would like to work on this issue and contribute.
There's already a PR for it:
This works in a weird way for me - Install old version of extension from vsix Run - If I respond , it cancels the install. I have to respond with which is unusual Is this how it's intended to be used?
Yeah unfortunately that's the current status of the dialog service in the CLI environment. Needs polish, feel free to file an issue for that.
I'm unsure why this issue was closed What is the command to update ALL extensions from CLI (without code opening)? Something like
This issue was about updating a single extension. Feel free to file an issue to support updating all extensions.
Done. See
Change:
import * as dom from 'vs/base/browser/dom'; import { HoverWidget } from 'vs/base/browser/ui/hover/hoverWidget'; import { mapFindFirst } from 'vs/base/common/arraysFind'; <ins> import { assertNever } from 'vs/base/common/assert'; </ins> import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { IMarkdownString, MarkdownString } from 'vs/base/common/htmlContent'; import { KeyChord, KeyCode, KeyMod } from 'vs/base/common/keyCodes';

Discussion:
Refs: [x] anyOS [x] anyOS Complexity: 4 We have at long last finalized the test coverage API. Implementing an extension that produces data for the API from scratch is challenging, and requires domain-specific knowledge, so you might find playing with the selfhost test provider to be the most effective way to test it The new types in the API include: - - - Please: Do some testing that the API and UI functions as you would expect Read through the API and verify that its documentation makes sense to you See that UI interactions work nicely as you would expect (you can use any extension that produces coverage to test this part)
Change:
return value; } <del> function needsBracketLink(mdPath: string) { </del> <ins> function needsBracketLink(mdPath: string): boolean { </ins> // Links with whitespace or control characters must be enclosed in brackets if (mdPath.startsWith('<') || /s|[u007Fu0000-u001f]/.test(mdPath)) { return true;

Discussion:
Type: <bBug</bFile names do not load properly when calling double-byte filenames in Markdown It would be great if Markdown could show double-byte file names when we load them up, just like in VS Code Explorer Markdown file -and-drop to embed double-byte files names do not load properly when calling double-byte filenames in Markdown ! VS Code version: Code 1.84.2 (Universal) (, 2023-11-09T10:52:33.687Z) OS version: Darwin arm64 23.1.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ vscode-django1.14.0 markdown-preview-github-styles2.0.3 python-environment-manager1.2.4 python-extension-pack1.7.0 codespaces1.16.2 copilot1.139.0 copilot-chat0.10.2 vscode-pull-request-github0.76.1 vscode-power-mode3.0.2 vsc-python-indent1.18.0 node-module-intellisense1.5.0 vscode-language-pack-ja1.84. vscode-kubernetes-tools1.3.15 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.10.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.321.0 atom-keybindings3.3.0 vsliveshare1.0.5896 autodocstring0.6.1 vscode-yaml1.14.0 code-spell-checker3.0.1 vscode-pets1.25.1 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 jinja0.0.8 markdown-pdf1.5.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you please share an example file name as text so I can try to easily reproduce this Also is the issue that the file doesn't load in the preview or that the wrong path is inserted when you drop the file into the markdown editor
I'm having the same problem. Below is an example of a Japanese file name: audio.mp3 Below is a quick hack that will get you the desired result. Added decodeURI when creating a link on the editor. I hope you can decide whether it is helpful or not. <img width="1318" alt="image" src=""Version: 1.86.0 Commit: Unknown Date: Unknown Electron: 27.1.3 ElectronBuildId: undefined Chromium: 118.0.5993.159 18.17.1 V8: 11.8.172.18-electron.0 OS: Darwin arm64 23.1.0
Thanks Will check in a fix for the next insiders build
The hover in the preview still shows encoded characters. Let me know if this i under out control and I should file and issue. !