jiebi/CodeConvo huggingface dataset:
Change:
"markdown.previewSide.title" : "Open Preview to the Side", "markdown.showSource.title" : "Show Source", "markdown.styles.dec": "A list of URLs or local paths to CSS style sheets to use from the markdown preview. Relative paths are interpreted relative to the folder open in the explorer. If there is no open folder, they are interpreted relative to the location of the markdown file. All '' need to be written as ''.", <del> "markdown.previewFrontMatter.dec": "Sets how YAML front matter should be rendered in the markdown preview. 'hide' removes the front matter. Otherwise, the front matter is treated as markdown content" </del> <ins> "markdown.previewFrontMatter.dec": "Sets how YAML front matter should be rendered in the markdown preview. 'hide' removes the front matter. Otherwise, the front matter is treated as markdown content.", "markdown.preview.fontFamily.desc": "Controls the font family used in the markdown preview.", "markdown.preview.fontSize.desc": "Controls the font size in pixels used in the markdown preview.", "markdown.preview.lineHeight.desc": "Controls the line height used in the markdown preview. This number is relative to the font size." </ins> }  No newline at end of file

Discussion:
VSCode Version: 0.10.11 OS Version: Windows 7 64bit ! !
I think this should be a separate setting because a font that works for code might not work for reading text.
Correct me if I'm wrong, but isn't this already covered by the markdown styles setting? Result: ! Do we really need a setting to inject a default font?
good point, however enabling this setting for markdown () disables any other style being used for markdown preview. fyi this is a workaround for the problem, you could actually create a CSS file that contains the font style.
Well if we support overriding the default styles piecemeal like suggested wouldn't we end up with settings for many things? Here's a list I can think of off the top of my head: font-family font-size line-spacing background-color ... etc This non-exhaustive list would just start cluttering the configuration, perhaps the default stylesheet should be exposed so minimal tweaking can occur? Perhaps this could be solved with a command / extension to dump the default stylesheet into and add it to the styles? Then anyone can make their minimal tweaks without losing all the default styling?
And I think if we could support this for the command? That means we can add setting for the font family of previewed html?
Change:
.monaco-editor .sticky-widget { width : 100%; <del> box-shadow : var(--vscode-scrollbar-shadow) 0 6px 6px -6px; </del> <ins> box-shadow : var(--vscode-scrollbar-shadow) 0 2px 6px -2px; </ins> z-index : 2; background-color : var(--vscode-editorStickyScroll-background); }

Discussion:
<img width="290" alt="image" src="https://user-"vs <img width="244" alt="image" src="https://user-"
Change:
import * as vscode from 'vscode'; import { Node, Stylesheet } from 'EmmetNode'; import { isValidLocationForEmmetAbbreviation } from './abbreviationActions'; <del> import { getEmmetHelper, getMappingForIncludedLanguages, parsePartialStylesheet, getEmmetConfiguration, getEmmetMode, isStyleSheet, parseDocument, getEmbeddedCssNodeIfAny, isStyleAttribute, getNode } from './util'; </del> <ins> import { getEmmetHelper, getMappingForIncludedLanguages, parsePartialStylesheet, getEmmetConfiguration, getEmmetMode, isStyleSheet, parseDocument, getNode, isStyleAttribute, getEmbeddedCssNodeIfAny } from './util'; import { getLanguageService, TextDocument, TokenType } from 'vscode-html-languageservice'; </ins> export class DefaultCompletionItemProvider implements vscode.CompletionItemProvider { private lastCompletionType: string | undefined; <ins> private htmlLS = getLanguageService(); </ins> public provideCompletionItems(document: vscode.TextDocument, position: vscode.Position, _: vscode.CancellationToken, context: vscode.CompletionContext): Thenable<vscode.CompletionList | undefined> | undefined { const completionResult = this.provideCompletionItemsInternal(document, position, context); if (!completionResult) {

Discussion:
Issue Type: <bFeature Request</bI'm not talking about the editor's horizontal scroll is a very thin scroll bar between the tabs and editor,that's what i'm talking about. When you open too many tabs,some tabs are invisible so you need scrolling horizontally. There's a scrollbar to scroll the tabs,but it's too thin. Of course,this wasn't a big bug or what,and I can use "Ctrl+Tab" to switch tabs. maybe this bar should be bigger or even disappear considering it's not helpful. VS Code version: Code 1.32.3 (, 2019-03-14T23:43:35.476Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.49 --<!-- potentialduplicatescomment --
Duplicate of
Oops, tagged wrong issue.
Change:
declare readonly _serviceBrand: undefined; <del> private _responsePendingAudioCue: IDisposable | undefined; private _hasReceivedRequest: boolean = false; </del> <ins> private _pendingCueMap: Map<number, IDisposable | undefined> = new Map(); </ins> private _runOnceScheduler: RunOnceScheduler; private _lastResponse: string | undefined; <ins> private _requestId: number = 0; </ins> constructor(@IAudioCueService private readonly _audioCueService: IAudioCueService) { super(); this._register(this._runOnceScheduler = new RunOnceScheduler(() => { <del> if (!this._hasReceivedRequest) { this._responsePendingAudioCue = this._audioCueService.playAudioCueLoop(AudioCue.chatResponsePending, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS); } </del> <ins> this._pendingCueMap.set(this._requestId, this._audioCueService.playAudioCueLoop(AudioCue.chatResponsePending, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS)); </ins> }, CHAT_RESPONSE_PENDING_ALLOWANCE_MS)); } <del> acceptRequest(): void { </del> <ins> acceptRequest(): number { this._requestId++; </ins> this._audioCueService.playAudioCue(AudioCue.chatRequestSent, { allowManyInParallel: true }); this._runOnceScheduler.schedule(); <ins> return this._requestId; </ins> } <del> acceptResponse(response?: IChatResponseViewModel | string): void { this._hasReceivedRequest = true; </del> <ins> acceptResponse(response: IChatResponseViewModel | string | undefined, requestId: number): void { this._pendingCueMap.get(requestId)?.dispose(); this._pendingCueMap.delete(requestId); </ins> const isPanelChat = typeof response !== 'string'; <del> this._responsePendingAudioCue?.dispose(); </del> this._runOnceScheduler?.cancel(); const responseContent = typeof response === 'string' ? response : response?.response.asString(); if (this._lastResponse === responseContent) { return; } this._audioCueService.playAudioCue(AudioCue.chatResponseReceived, { allowManyInParallel: true }); <del> this._hasReceivedRequest = false; </del> if (!response) { return; }

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.
Change:
"git": { "name": "seti-ui", "repositoryUrl": "https://github.com/jesseweed/seti-ui", <del> "commitHash": "8f22764c37feb7f706465f5186132111a2401b6b" </del> <ins> "commitHash": "f3b2775662b0075aab56e5f0c03269f21f3f0f30" </ins> } }, "version": "0.1.0"

Discussion:
accepted a couple of update PRs recently. Can you please sync extensions/theme-seti/icons? Meanwhile, I noticed that file was falsely classified as type file. I am not sure if that's a real issue in the latest vscode release candidate, or just a non-reproducible problem caused by some peculiarity in my vscode dev env. Can you please take a look?
Also something worth mentioning is that WebP images lack the image icon whereas WebM videos does indeed have the video icon. Adding lines: and does indeed solves the issue.
can you please file a separate issue? Thanks.
NP sir .
thanks! While testing your PR, can you also please check the icon for file? There shouldn't be no icon assigned to it. Otherwise, that's a regression and I am happy to file an issue.
we don't have any references to files in our seti-ui directory and nearly all of our code is pulled directly from the seti repo, so i'm unsure where this is coming from. Please file a separate issue and can look into it. EDIT: after looking into this, it appears that files are : ! And we have refs for mod files in our built-in xml extension: So there is a clash there. I'd suggest you make a request on the seti-ui theme to set files to a go icon so there are no conflicts.
Verification steps: ensure that the following updates are reflected in the file explorer for file icons: use the new logo files point to the R icon files point to the TypeScript icon !
Change:
const codeActionGroups = Object.freeze<CodeActionGroup[]>([ { kind: CodeActionKind.QuickFix, title: localize('codeAction.widget.id.quickfix', 'Quick Fix...') }, <del> { kind: CodeActionKind.Extract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.Convert, title: localize('codeAction.widget.id.convert', 'Convert...'), icon: { codicon: Codicon.zap, color: 'var(--vscode-editorLightBulbAutoFix-foreground)' } }, { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: { codicon: Codicon.symbolArray } }, { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: { codicon: Codicon.lightBulb, color: 'var(--vscode-editorLightBulb-foreground)' } }, </del> <ins> { kind: CodeActionKind.RefactorExtract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: { codicon: Codicon.symbolSnippet } }, { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: { codicon: Codicon.symbolFile } }, </ins> uncategorizedCodeActionGroup, ]);

Discussion:
Looking into adding additional separators that are more common, so that all the additional refactorings are not just clumped under From comment: I was wondering if you would consider adding 2 code action classes that are I think quite common: (Inline) (Move) This would be super valuable for the extension that I'm developing (P42 JavaScript Assistant), but I think also for other extensions. Afaik the TS language server also has actions for example. Originally posted by in
Hey , the new code action widget looks great, and I really like the new code action grouping, I'm wondering if we can define custom code action groups besides the pre-defined groups. ! you can see the java extension contributes a code action (in the light bulb) named "add Javadoc" and it's now under "More Actions..." menu. If we can define a new group like "Sources" via extension, it would be great and more clear that we can put this action in that group.
We have an extension that publishes some code actions. With the latest VSCode, our actions are grouped under 'More Actions...' which in our context is not ideal. We would prefer to be able to define our own grouping for our actions (in extension parlance, I think this means to be able to create our own ). Thanks!
Change:
super(); } <del> show(focus?: boolean): void { </del> <ins> show(): void { </ins> if (this.isVisible) { <del> if (focus) { const list = assertIsDefined(this.list); list.domFocus(); } </del> return; // already visible }

Discussion:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated
Change:
return { local, remote }; } <del> async reloadLocalUserConfiguration(donotTrigger?: boolean): Promise<ConfigurationModel> { const model = await this.localUserConfiguration.reload(); </del> <ins> async reloadLocalUserConfiguration(donotTrigger?: boolean, settingsConfiguration?: ConfigurationModel): Promise<ConfigurationModel> { const model = await this.localUserConfiguration.reload(settingsConfiguration); </ins> if (!donotTrigger) { this.onLocalUserConfigurationChanged(model); }

Discussion:
apply the patch that logs fs calls which is included below run open a folder and open a single css file don't modify it (i.e. avoid hot exit) and reload the window <details<summaryPatch</summary</detailsObserve the following fs calls that occur before the first editor rendering: IMHO the following fs calls should be postponed: [ ] [ ] [ ] [x] I also noticed that we read the following files twice: [ ]
I have no clue what we use install source for, but lots of digging reveals this commit:
Updating the list - is only read once.
is read twice because First time during initialising configuration without user tasks User tasks is read later when there is an idle time - by reloading user configuration - during which settings and tasks files are read.
Install source is a common telemetry property. It can be set after installing VS Code. It came as an ask from Anaconda, to know how many installations came from them. We decided to go with creating a new file rather than updating existing files, to avoid scenarios where we'd break important files (eg or ). I don't have great ideas to work around this other than refactoring the code until the first telemetry event gets submitted, which is still pretty early. Will ask around to learn whether this common telemetry property is still in use.
is gone!
Tasks and Launches are part of Config and they are accessed sync from config service. In order to prevent reading these files during start up we should loading them until they are needed. (probably workbench restored phase) an assertion to make sure no component is reading them until then
This needs considerable refactoring and I do not think it is worth a change for the gain given that these files are resolved in parallel. Hence marking this as no fix.
Change:
} const focusElementId = options?.outputId ?? cell.id; <del> this._webview.focusOutput(focusElementId, options?.altOutputId, this._webviewFocused); </del> <ins> this._webview.focusOutput(focusElementId, options?.altOutputId, options?.outputWebviewFocused || this._webviewFocused); </ins> cell.updateEditState(CellEditState.Preview, 'focusNotebookCell'); cell.focusMode = CellFocusMode.Output;

Discussion:
a cell with the code the input field in the cell's output :bug: the cell output container will sometimes steal output from the input field !
Change:
} else { const href = node.getAttribute('href'); if (href) { <ins> if (href.startsWith('command:') && outputFocus) { postNotebookMessage<webviewMessages.IOutputFocusMessage>('outputFocus', outputFocus); } </ins> postNotebookMessage<webviewMessages.IClickedLinkMessage>('clicked-link', { href }); } }

Discussion:
a cell that will produce an error a link in the stack trace sometimes focus is not correctly given to the cell !
Change:
dialogService.info(localize('successIn', "Shell command '{0}' successfully installed in PATH.", productService.applicationName)); } catch (error) { <ins> if (isCancellationError(error)) { return; } </ins> dialogService.error(toErrorMessage(error)); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (It's happening for fresh installation) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Macbook M1 Pro - Sonoma 14.2.1 Steps to Reproduce: VSCode Darwin build from downloads page - (Mac .zip Apple Silicon) Shell command: Install 'code' command in PATH cancel for the below prompt <img width="1136" alt="Screenshot 2024-01-02 at 7 35 58 PM" src=""It should display that shell command was not completed successfully. Instead it shows command successfully <img width="1136" alt="Screenshot 2024-01-02 at 7 38 19 PM" src=""
Change:
break; } <del> name = incrementFileName(name, !!fileToPaste.isDirectory, incrementalNaming); </del> <ins> if (incrementalNaming !== 'disabled') { name = incrementFileName(name, !!fileToPaste.isDirectory, incrementalNaming); } </ins> candidate = resources.joinPath(targetFolder.resource, name); }

Discussion:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { URI } from 'vs/base/common/uri'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; </ins> import { Schemas } from 'vs/base/common/network'; <ins> import { localize } from 'vs/nls'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; import { IFileService } from 'vs/platform/files/common/files'; </ins> import { ILabelService } from 'vs/platform/label/common/label'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { ITerminalEditorService, ITerminalGroupService, ITerminalService, terminalEditorId } from 'vs/workbench/contrib/terminal/browser/terminal'; import { terminalStrings } from 'vs/workbench/contrib/terminal/common/terminalStrings'; import { IEditorResolverService, RegisteredEditorPriority } from 'vs/workbench/services/editor/common/editorResolverService'; <ins> import { registerLogChannel } from 'vs/workbench/services/output/common/output'; import { join } from 'vs/base/common/path'; import { TerminalLogConstants } from 'vs/platform/terminal/common/terminal'; </ins> /** * The main contribution for the terminal contrib. This contains calls to other components necessary * to set up the terminal but don't need to be tracked in the long term (where TerminalService would * be more relevant). */ <del> export class TerminalMainContribution implements IWorkbenchContribution { </del> <ins> export class TerminalMainContribution extends Disposable implements IWorkbenchContribution { </ins> constructor( @IEditorResolverService editorResolverService: IEditorResolverService, <ins> @IEnvironmentService environmentService: IEnvironmentService, @IFileService private readonly _fileService: IFileService, </ins> @ILabelService labelService: ILabelService, <ins> @ILogService private readonly _logService: ILogService, </ins> @ITerminalService terminalService: ITerminalService, @ITerminalEditorService terminalEditorService: ITerminalEditorService, @ITerminalGroupService terminalGroupService: ITerminalGroupService ) { <ins> super(); </ins> // Register terminal editors editorResolverService.registerEditor( `${Schemas.vscodeTerminal}:/**`,

Discussion:
This doesn't get logged when creating a terminal with trace logging on
I tried to do this like you and Jackson did for the on the branch merogge/remote-inv, but i'm still not seeing the logs anywhere when using remote WSL. Thoughts? Need this to investigate remote terminal reconnection bc when ssh'ing to localhost, I can't repro the issue and don't want to have to setup a vm.
maybe bc it's in platform instead of workbench it's not working? can't be in workbench though for the ptyService
instead of an output channel I think what we're after is something like this: Here: I thought that's what the LogLevelChannel was doing but maybe not? Or maybe that particular log service/channel type doesn't work on the server since it does in the shared process? !