jiebi/CodeConvo huggingface dataset:
Change:
this.lifecycleService.onWillShutdown((e) => e.join(this.autoStoreEditSession(), { id: 'autoStoreEditSession', label: localize('autoStoreEditSession', 'Storing current edit session...') })); } <del> private async autoResumeEditSession() { if (this.environmentService.editSessionId !== undefined) { // In web, resume edit session based on an edit session GUID that // was explicitly passed into the workbench construction options void this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('resuming edit session dialog', 'Resuming your latest edit session...') }, async () => { performance.mark('code/willResumeEditSessionFromIdentifier'); </del> <ins> private autoResumeEditSession() { void this.progressService.withProgress(resumingProgressOptions, async () => { performance.mark('code/willResumeEditSessionFromIdentifier'); </ins> <del> type ResumeEvent = {}; type ResumeClassification = { owner: 'joyceerhl'; comment: 'Reporting when an action is resumed from an edit session identifier.'; }; this.telemetryService.publicLog2<ResumeEvent, ResumeClassification>('editSessions.continue.resume'); </del> <ins> type ResumeEvent = {}; type ResumeClassification = { owner: 'joyceerhl'; comment: 'Reporting when an action is resumed from an edit session identifier.'; }; this.telemetryService.publicLog2<ResumeEvent, ResumeClassification>('editSessions.continue.resume'); if (this.environmentService.editSessionId !== undefined) { </ins> await this.resumeEditSession(this.environmentService.editSessionId).finally(() => this.environmentService.editSessionId = undefined); <del> performance.mark('code/didResumeEditSessionFromIdentifier'); }); } else if (this.configurationService.getValue('workbench.experimental.editSessions.autoResume') === 'onReload' && this.editSessionsStorageService.isSignedIn) { // Attempt to resume edit session based on edit workspace identifier // Note: at this point if the user is not signed into edit sessions, // we don't want them to be prompted to sign in and should just return early void this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('resuming edit session window', 'Resuming edit session...') }, async () => { </del> <ins> } else if (this.configurationService.getValue('workbench.experimental.editSessions.autoResume') === 'onReload' && this.editSessionsStorageService.isSignedIn) { // Attempt to resume edit session based on edit workspace identifier // Note: at this point if the user is not signed into edit sessions, // we don't want them to be prompted to sign in and should just return early </ins> await this.resumeEditSession(undefined, true); <del> }); } </del> <ins> } performance.mark('code/didResumeEditSessionFromIdentifier'); }); </ins> } private async autoStoreEditSession() {

Discussion:
Testing ! It would be nice if that text is a hyperlink which opens the output channel, similar to above: !
/verified
Change:
* Writes text to the system clipboard. */ writeText(text: string): void; <ins> /** * Reads the content of the clipboard in plain text */ readText(): string; </ins> }  No newline at end of file

Discussion:
when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose "compare with clipboard".
An extension would be ideal for a feature like this.
fyi
It would be great too if also is allowed to compare selection with clipboard.
It would be great if we could compare unsaved files...
I would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to
Has someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?
not yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.
Change:
private toDispose: IDisposable[]; private styles: ISelectBoxStyles; <del> constructor(options: string[], selected: number, styles: ISelectBoxStyles, toDispose: IDisposable[]) { </del> <ins> constructor(options: string[], selected: number, styles: ISelectBoxStyles) { this.toDispose = []; </ins> this.selectElement = document.createElement('select'); this.selectElement.className = 'select-box'; <del> this.toDispose = toDispose; </del> this._onDidSelect = new Emitter<ISelectData>(); this.styles = styles;

Discussion:
New SelectBox custom implementation creates a circular disposal since toDispose is still passed to the select box delegate where the class objects are into the disposable list which is really the parents list. Steps to Reproduce: code, open a terminal (instantiates the drop-down lists) panel (disposes SelectBox) gives a stack err, panel becomes blank and unusable shows an infinite disposal loop. Debug on disposal: [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14",

source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.475:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.475:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.476:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.476:INFO:CONSOLE(85)] "Maximum call stack size exceeded: RangeError: Maximum call stack size exceeded at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-) at SelectBoxList.dispose (file:///C:/VSC Dev/vc-fork-) at file:///C:/VSC Dev/vc-fork- at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-) at SelectBoxList.dispose (file:///C:/VSC Dev/vc-fork-) at file:///C:/VSC Dev/vc-fork- at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-)", source: file:///C:/VSC Dev/vc-fork- (85)
Fixed with
Change:
project.workspaceFolder || vscode.TaskScope.Workspace, localize('buildAndWatchTscLabel', 'watch - {0}', label), 'tsc', <del> new vscode.ShellExecution(command, ['--watch', ...args]), </del> <ins> new vscode.ShellExecution(command, [...args, '--watch']), </ins> '$tsc-watch'); watchTask.group = vscode.TaskGroup.Build; watchTask.isBackground = true;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.30.2 OS Version: macOS X 10.13.6 (17G4015) Steps to Reproduce: a package with in the file to execute the build task the error (pardon my french): <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes The issue appears to be caused by the being at , resulting in an invalid invocation of . A possible solution might be to append at the end instead of prepending.
I have a fix for this in my fork that I should be able to push a PR for pretty soon (waiting for employee to approve the contrib).
Change:
if (pendingEdit) { this.switchToEditMode(); } <ins> this._register(this.accessibilityService.onDidChangeScreenReaderOptimized(() => { this.toggleToolbarHidden(true); })); </ins> } private createScroll(container: HTMLElement, body: HTMLElement) {

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW
Change:
import * as vscode from 'vscode'; import { API } from './typings/git'; import { getRepositoryFromUrl, repositoryHasGitHubRemote } from './util'; <del> import { encodeURIComponentExceptSlashes, getRepositoryForFile, notebookCellRangeString, rangeString } from './links'; </del> <ins> import { encodeURIComponentExceptSlashes, ensurePublished, getRepositoryForFile, notebookCellRangeString, rangeString } from './links'; </ins> export class VscodeDevShareProvider implements vscode.ShareProvider, vscode.Disposable { readonly id: string = 'copyVscodeDevLink';

Discussion:
Testing One can copy links to & github & azure repos even though I just created the file and copying such a link will result in empty or 404 on GH. Seeing links to just created file : <img width="451" alt="image" src="https://user-"
No progress on this one yet, but would you expect the actions to be hidden, or would you want to be prompted to commit the file to the remote when the command is invoked?
I think users could be confused if the actions wouldn't appear (eg they might've forgotten the file isn't pushed), so the latter sounds better. But I wonder whether checking whether the file is available on remote would be slow
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.5.0-beta.2.tgz#1b83c2a9a306766c47a4f80b8c65cc9ee5f5a5c4" integrity sha512-oTb/2krdbHYGxH2X6yiBZzAB/1WB+apUu4nXHdhBnht20bl8E+YVWqg95D4o0Gl+QJI+XOfB3mqmWaBx1x531A== <del> xterm-addon-image@0.4.1: version "0.4.1" resolved "https://registry.yarnpkg.com/xterm-addon-image/-/xterm-addon-image-0.4.1.tgz#ec8f750af48005ad641c1128fa1f551ac198472a" integrity sha512-iJpYyvtbHg4oXSv+D6J73ZfCjnboZpbZ567MLplXDBlYSUknv3kvPTfVMPJATV7Zsx7+bDgyXboCh9vsDf/m/w== </del> <ins> xterm-addon-image@0.4.2: version "0.4.2" resolved "https://registry.yarnpkg.com/xterm-addon-image/-/xterm-addon-image-0.4.2.tgz#d25bb3a8c543d014accbfbbc875927f54d5f43b9" integrity sha512-QVuH5CGlValtFMVorb71TnMV7kQLqc9+V5oyOMNvFqW1NiOBNo/d0WVvMU8qOd2vsAdTbhjvUO8SPptZ5TJHYw== </ins> xterm-addon-search@0.13.0-beta.2: version "0.13.0-beta.2"

Discussion:
On the latest insiders I can't click and drag the terminal scroll bar: !
Same here - but at least the terminal can actually be resized now!
I the same problem. In my case, all scrollbars (editor, explorer, ...) were. I tried and it was the same. Not sure if this is related, but Google Chrome and Slack App do not have this issue.
Same issue here, cannot scroll the terminal window. The cursor changes to text selector and is unable to scroll for the entire life of the terminal window. !
I completely shut down macOS and restarted it and it fixed it. It's strange.
Restarting vscode fixes it for me. It only happens when my cursor either hovers over a link in the terminal or I select some text from the terminal, it gets forever stuck in text selection/link click mode.
This is because of the image addon: ! cc
Upstream:
Saw that you released v1.80. In there is still 0.4.1 mentioned as version for xterm-addon-image. The patch version fixing this issue at hand is 0.4.2 - did that not work for you? Note that I was not able to repro the issue with vscode 1.79, so there is a chance that my attempt did not address it. Or did just the package update slip through?
I'm seeing this in Insiders. Restarting VSCode doesn't fix it and it only happens when I have multiple terminals open and the terminal tab sidebar is showing. Version: 1.81.0-insider (Universal) Commit: Date: 2023-07-07T19:50:58.701Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
it came in a bit late for the release and didn't think it met the bar. I'll be updating soon
Change:
if (options.inlineClassName) { const offset = (outputLineIndex > 0 ? lineBreakData.wrappedTextIndentLength : 0); const start = offset + Math.max(injectedTextStartOffsetInInputWithInjections - lineStartOffsetInInputWithInjections, 0); <del> const end = offset + Math.min(injectedTextEndOffsetInInputWithInjections - lineStartOffsetInInputWithInjections, lineEndOffsetInInputWithInjections); </del> <ins> const end = offset + Math.min(injectedTextEndOffsetInInputWithInjections - lineStartOffsetInInputWithInjections, lineEndOffsetInInputWithInjections - lineStartOffsetInInputWithInjections); </ins> if (start !== end) { inlineDecorations.push(new SingleLineInlineDecoration(start, end, options.inlineClassName, options.inlineClassNameAffectsLetterSpacing!)); }

Discussion:
With &#x60;"editor.wordWrap": "on"&#x60;, the color hints (inline color decorators) may be double-displayed near the wrapped view edges. &#x2D;--- Version: 1.75.1 Commit: User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/ Firefox/111.0 Embedder: <!-- generated by web issue reporter --
Can you share a screenshot?
<img src="https://user-" alt="" /
Hi could you post here the example from the image?
Update
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified <img src="" alt="" /Basically alright. But the early wrapping may be optimized. (see near line 6 "#", "#")
Change:
"windows-mutex": "0.2.1", "windows-process-tree": "0.2.3" } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Fixed in master, needs to be pulled into release branch
Verification: Open a terminal Resize the sidebar to be 50% of the screen size Type out a long line in the terminal that wraps several times and press enter (this needs to be able to unwrap when you close the sidebar) Resize the terminal larger, keep moving the cursor and hit cmd/ctrl+b to hide sidebar before you let go. The resize call is debounced every 50ms and you're trying to resize both dimensions larger in a single call. You know you've done the right thing if the text doesn't move/reflow until after you have resized both.
Change:
if (!veto) { this._doStopExtensionHosts(); } else { <del> this._logService.warn(`Extension host was not stopped because of veto (stop reason: ${reason}, veto reason: ${vetoReasons.join(', ')})`); </del> <ins> const vetoReasonsArray = Array.from(vetoReasons); this._logService.warn(`Extension host was not stopped because of veto (stop reason: ${reason}, veto reason: ${vetoReasonsArray.join(', ')})`); </ins> await this._dialogService.warn( nls.localize('extensionStopVetoMessage', "The following operation was blocked: {0}", reason), <del> vetoReasons.length === 1 ? nls.localize('extensionStopVetoDetailsOne', "The reason for blocking the operation: {0}", vetoReasons[0]) : nls.localize('extensionStopVetoDetailsMany', "The reasons for blocking the operation:n- {0}", vetoReasons.join('n -')), </del> <ins> vetoReasonsArray.length === 1 ? nls.localize('extensionStopVetoDetailsOne', "The reason for blocking the operation: {0}", vetoReasonsArray[0]) : nls.localize('extensionStopVetoDetailsMany', "The reasons for blocking the operation:n- {0}", vetoReasonsArray.join('n -')), </ins> ); }

Discussion:
Testing Open a folder that has a image in an empty profile Install Luna Paint Extension Edit the image using Luna Paint and do not save Switch the profile to another profile Reason is empty <img width="573" alt="image" src=""
Good catch, there is an error thrown but I fail to remember the reason in that case. It should be: !
Change:
const reference = await this.resolveModelReference(resource); try { const formattingOptions = this.getFormattingOptions(reference.object.textEditorModel); <del> if (this.uriIdentityService.extUri.isEqual(resource, this.environmentService.settingsResource)) { </del> <ins> if (!this.textFileService.isDirty(resource) /* go through text model save if the model is dirty */ && this.uriIdentityService.extUri.isEqual(resource, this.environmentService.settingsResource)) { </ins> await this.userConfigurationFileService.updateSettings({ path: operation.jsonPath, value: operation.value }, formattingOptions); } else { await this.updateConfiguration(operation, reference.object.textEditorModel, formattingOptions);

Discussion:
Open Make the file dirty, disable autosave Use the pencil icon to try to change a setting Get an error that the file is dirty Click "Save and retry" Nothing happens Press cmd+s to save Get an error that the 'contents of the file are newer' because the pencil actually wrote to the backing file without updating the editor
Do you still see this on the latest Insiders? I'm unable to reproduce the issue.
I can still repro
Change:
super(); this._gutterDecorationTransparent = this._registerGutterDecoration(true); this._gutterDecorationOpaque = this._registerGutterDecoration(false); <del> this._ctxToolbarIconEnabled = CTX_INLINE_CHAT_TOOLBAR_ICON_ENABLED.bindTo(_contextKeyService); this._setToolbarIconEnablementToSetting(); </del> this._register(this._configurationService.onDidChangeConfiguration((e: IConfigurationChangeEvent) => { <del> if (e.affectsConfiguration(InlineChatDecorationsContribution.TOOLBAR_SETTING_ID)) { this._setToolbarIconEnablementToSetting(); return; } </del> if (!e.affectsConfiguration(InlineChatDecorationsContribution.GUTTER_SETTING_ID)) { return; }

Discussion:
We have as explicit context key which is driven with the . This is all fine but actually not needed. Any configuration is automatically a context key when prefixed with - , the setting is and you can use as context key
That's useful, thank you I didn't know
Change:
export const enum CommentCommandId { Add = 'workbench.action.addComment', <ins> FocusCommentOnCurrentLine = 'workbench.action.focusCommentOnCurrentLine', </ins> NextThread = 'editor.action.nextCommentThreadAction', PreviousThread = 'editor.action.previousCommentThreadAction', NextCommentedRange = 'editor.action.nextCommentedRangeAction',

Discussion:
Type: <bFeature Request</bCC any file containing comment thread editor, move your cursor to any line having comment your cursor is on the line, press ctrl+K ctrl+I to see if the comment tolltip opens Screen reader users cannot open comment tooltip on the current line via ctrl+K ctrl+I ctrl+K ctrl+I needs to work for the comment tooltip just like other tooltips. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
the comment widget is not a tooltip. We cannot reuse this keybinding to focus the comment widget because it's possible that line will have hover info. pls lmk if you disagree. I do wonder if we should have a focus closest comment widget command/keybinding.
Aw, I see. Please then consider adding a keybinding to focus the closest comment widget. Currently, alt+F9 and shift+alt+F9 go to the next and previous comment widget, but there is no action available to focus the comment on the current line.
It does make sense to have an "Expand and focus comment at current line" command.
The new command is "Focus Comment on Current Line" with no default keybinding.
To verify: Install an extension that provides comments GitHub Pull Requests can be used for this Sign in Open the Pull Requests view Open a file diff for a PR. If there aren't any comments in the file, add a comment on one of the changed lines and collapse the comment Put your cursor on a line in a file with a collapsed comment Open the command palette and run the command "Focus Comment on Current Line" Verify that the comment has focus
This should probably be to the comments and/or the editor accessibility help dialog for discoverability.
Change:
} resolve(true); } else { <del> return resolve(this.displaySelectAnotherQuickPick(editor)); </del> <ins> return resolve(this.displaySelectAnotherQuickPick(editor, false)); </ins> } } else if (isKernelPick(quickPick.selectedItems[0])) { await this._selecteKernel(notebook, quickPick.selectedItems[0].kernel);

Discussion:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !
Change:
const editorConfig = (<IEditorConfiguration>config).editor; const terminalConfig = this.config; <del> const fontFamily = terminalConfig.fontFamily || editorConfig.fontFamily; </del> <ins> let fontFamily = terminalConfig.fontFamily || editorConfig.fontFamily; // Work around bad font on Fedora if (!terminalConfig.fontFamily) { if (isFedora) { fontFamily = ''DejaVu Sans Mono''; } } </ins> let fontSize = this._toInteger(terminalConfig.fontSize, 0); if (fontSize <= 0) { fontSize = EDITOR_FONT_DEFAULTS.fontSize;

Discussion:
VSCode Version: Code 1.17.0 (, 2017-10-04T23:33:45.303Z) OS Version: Linux x64 4.12.0-2-amd64 Extensions: Extensions are disabled Steps to Reproduce: window doesn't look well ! <!-- Launch with to check. --Reproduces without extensions: Yes/No
Here is how my integrated terminal looks like !
what distro are you using? I've seen Fedora acts a little odd with font rendering both in the editor and the terminal. see
I'm experiencing the same issue on Fedora 26 / Gnome 3.24.2 / VSCode version 1.17.0. The only affected component is the terminal so far, other fonts look good. The issue is not present in VSCode 1.16.1.
i am using debian 9 / xfce4 / VSCode version 1.17.0
For Fedora right now the workaround is to use a different font:
it works like a charm. Thanks a lot :)
Thks now looks very well.
Pushed to master and release/1.17
Not sure I've got issue right, but looks like custom fonts such as are not working after last update. Before update everything worked fine. Wouldn't say it is too important, but would be nice to get it back. Linux Mint 18.2 x64. !
Same issue here with Fira Code font Ubuntu 17.04 x64
yes also here FiraCode looks weird now. macOS 10.13
same here as after 1.17.1 update it looks weird now with SF Mono on macOS. ! it looks weird, because before 1.17.1 it was awesome
This is the issue tracking the blurry text in 1.17.1