jiebi/CodeConvo huggingface dataset:
Change:
weight: KeybindingWeight.WorkbenchContrib }, { <del> when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate(), ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), ContextKeyExpr.and( ContextKeyExpr.has(InputFocusedContextKey), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('top'), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('none'), ), CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_INNER_CURSOR_LAST, EditorContextKeys.isEmbeddedDiffEditor.negate() ), primary: KeyCode.DownArrow, weight: KeybindingWeight.EditorCore }, { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate(), ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), ContextKeyExpr.and( NOTEBOOK_CELL_TYPE.isEqualTo('markup'), NOTEBOOK_CELL_MARKDOWN_EDIT_MODE.isEqualTo(false), NOTEBOOK_CURSOR_NAVIGATION_MODE), CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_INNER_CURSOR_LAST, EditorContextKeys.isEmbeddedDiffEditor.negate() ), primary: KeyCode.DownArrow, weight: KeybindingWeight.EditorCore }, { </del> when: NOTEBOOK_EDITOR_FOCUSED, primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, },

Discussion:
I'm pretty sure some of these keybindings aren't ever enabled with their context key requirements, e.g. I don't think the inline chat can be focused in a markdown cell that isn't in edit mode. Nor will cursor navigation mode be true while edit mode is false.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { getActiveWindow, isHTMLElement } from '../../../../../base/browser/dom.js'; </del> <ins> import { getActiveWindow } from '../../../../../base/browser/dom.js'; </ins> import { FastDomNode } from '../../../../../base/browser/fastDomNode.js'; import { AccessibilitySupport } from '../../../../../platform/accessibility/common/accessibility.js'; import { IKeybindingService } from '../../../../../platform/keybinding/common/keybinding.js';

Discussion:
Type: <bBug</bSteps to reproduce: window right click in editor area - it's hidden almost immediately (in come cases recording didn't catch it) right click in explorer tree, tabs, status bar - works as expected VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-11T05:04:03.124Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
Seems to happen on Windows but not on MacOS
The source of this bug has been found. After the context menu is shown, the screen reader content of the native edit context is updated, the document range is set. The context menu loses focus and is hidden. This issue happens in Windows but not on MacOS because Windows uses a different context menu logic. A fix will be found.
Works on my machine now Version: 1.94.0-insider Commit: Date: 2024-09-16T05:03:40.122Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
Thank you for verifying
Change:
const rendered = this._register(this.markdown.value.render(message.message, {})); <del> rendered.element.style.height = '100%'; </del> rendered.element.style.userSelect = 'text'; rendered.element.classList.add('preview-text'); this.container.appendChild(rendered.element);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.92.0 (Universal) Commit: Date: 2024-07-31T23:26:45.634Z Electron: 30.1.2 ElectronBuildId: Chromium: 124.0.6367.243 20.14.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.5.0 Steps to Reproduce: this snippet in the test-provider-sample project running the test, both the editor peek view and test result view do not render correctly. !
Sorry, this got lost in the shuffle of the call stack UI :(
Verification steps: out the of vscode-extension-samples into and F5 the "easy math" test in Open the error messages for all the tests that fail and verify they're all visible
Change:
import { ContextKeyExpr, ContextKeyExpression } from 'vs/platform/contextkey/common/contextkey'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { ActiveEditorContext } from 'vs/workbench/common/contextkeys'; <del> import { DiffElementViewModelBase } from 'vs/workbench/contrib/notebook/browser/diff/diffElementViewModel'; </del> <ins> import { DiffElementViewModelBase, SideBySideDiffElementViewModel } from 'vs/workbench/contrib/notebook/browser/diff/diffElementViewModel'; </ins> import { INotebookTextDiffEditor, NOTEBOOK_DIFF_CELL_INPUT, NOTEBOOK_DIFF_CELL_PROPERTY, NOTEBOOK_DIFF_CELL_PROPERTY_EXPANDED } from 'vs/workbench/contrib/notebook/browser/diff/notebookDiffEditorBrowser'; import { NotebookTextDiffEditor } from 'vs/workbench/contrib/notebook/browser/diff/notebookDiffEditor'; import { NotebookDiffEditorInput } from 'vs/workbench/contrib/notebook/common/notebookDiffEditorInput';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66 OS Version: Windows 11 Steps to Reproduce: diff view to revert the output changes :bug: after reverting the diff view still says there are deletions/additions output changes using the diff view :bug: stage the file and reopen the diff view, all the changes I reverted are back
Change:
"when": "scmProvider == git" }, { <ins> "command": "git.stashApply", "group": "5_stash", "when": "scmProvider == git" }, { "command": "git.stashApplyLatest", "group": "5_stash", "when": "scmProvider == git" }, { </ins> "command": "git.showOutput", "group": "7_repository", "when": "scmProvider == git"

Discussion:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!
Change:
group: 'navigation', order: 2, when: ContextKeyExpr.notEquals(`config.${LayoutSettings.ACTIVITY_BAR_LOCATION}`, ActivityBarPosition.TOP) <del> }, { id: MenuId.AuxiliaryBarHeader, group: 'navigation', when: ContextKeyExpr.equals(`config.${LayoutSettings.ACTIVITY_BAR_LOCATION}`, ActivityBarPosition.TOP) </del> }] }); }

Discussion:
Currently only the secondary sidebar has the close button. It should align with when the activity bar is at the top with the primary sidebar.
With the change that's about to land in 1.92 it's now less convenient for a right-side Activity Bar person like me to close the Secondary Side Bar that appears on the left when I use (for example) from a code editor context menu. Either I move my mouse all the way to the right-hand end of the window title and untoggle the relevant WCO button, or I go to the top menubar, choose View, then Appearance, then untoggle Secondary Side Bar there. Personally I think the opposite change would have been preferable, i.e. show an [X] button at the right-hand end of the Primary Side Bar's tabs when Activity Bar is at the top. This would make it consistent with Panel, which always has an [X] top-right.
My god, today I open vscode and I find that the X is not there, and I find that they took it out deliberately, not even a setting to toggle it
do you use the layout controls to hide and show the primary sidebar when the activity bar is at the top?
I know I can do that. In reality I tend to leave my right-positioned top-tabbed primary sidebar visible all the time. It's the secondary sidebar that I typically hide when I don't need it, e.g. after a References search caused it to appear. I didn't mind the inconsistency of there being an [X] on the secondary sidebar but not the primary.
Change:
} filter(element: T, parentVisibility: TreeVisibility): TreeFilterResult<FuzzyScore | LabelFuzzyScore> { <ins> let visibility = TreeVisibility.Visible; </ins> if (this._filter) { const result = this._filter.filter(element, parentVisibility); <del> let visibility: TreeVisibility; </del> if (typeof result === 'boolean') { visibility = result ? TreeVisibility.Visible : TreeVisibility.Hidden; } else if (isFilterResult(result)) {

Discussion:
Type: <bBug</bFilter tests for the current doc is no longer working. is doing nothing in the test explorer. It seems that all filter are broken. For example is also not possible. <img width="344" alt="CleanShot 2022-07-25 at 11 14 38 src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-25T05:27:27.755Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/assign
Change:
// Only focus the terminal if the activeElement has not changed since focus() was called // TODO hack if (document.activeElement === activeElement) { <del> this._focus(); </del> <ins> this._terminalGroupService.showPanel(true); </ins> } })); return; } <del> this._focus(); } private _focus() { this._terminalService.activeInstance?.focusWhenReady(); </del> <ins> this._terminalGroupService.showPanel(true); </ins> } override shouldShowWelcome(): boolean {

Discussion:
According to the documentation, if calling show(true), the terminal will be made visible but it won't capture the keyboard focus. I also remember in the past this worked. For some months already I noticed that regardless of how I call show, the focus is always taken. Anything changed? Is there already an issue that you tracking for this? Am I doing anything wrong? Related to this, if we won't manage to fix this behavior, how can we make key bindings for commands to be recognized even when the terminal has the focus? For example, when having focus in the terminal, if I press F5 debugging will start. The terminal will not try to write something for "F5". But if I run another key combination that I defined for some extension command, the terminal will react to the key combination (will try to write something) and the command will not be triggered (unless focus is somewhere else). We have this issue in the CMake Tools repository and the user would be happy if we fix this problem either way.
Hey, I would like to work on this issue. Could you give me any pointers? Where should I start?
this one's a little involved as it needs an extension to trigger the issue, you'd be better off finding an issue with the help wanted label.
Okay, thanks!
Tried this in an extension after making sure I had a terminal open: And the focus moved into the terminal.
did you have focus in the terminal before running that? preserve focus returns the focus to whatever was focused before. I'm unable to reproduce the problem using the exact code you mention above. Could you please include a gif? !
!
Change:
} }); <ins> markdownHtmlDoc.body.querySelectorAll('a') .forEach(a => { const href = a.getAttribute('href'); // Get the raw 'href' attribute value as text, not the resolved 'href' a.setAttribute('href', ''); // Clear out href. We use the `data-href` for handling clicks instead if ( !href || /^data:|javascript:/i.test(href) || (/^command:/i.test(href) && !markdown.isTrusted) || /^command:(///)?_workbench.downloadResource/i.test(href) ) { // drop the link a.replaceWith(a.textContent ?? ''); } else { let resolvedHref = _href(href, false); if (markdown.baseUri) { resolvedHref = resolveWithBaseUri(URI.from(markdown.baseUri), href); } a.dataset.href = resolvedHref; } }); </ins> element.innerHTML = sanitizeRenderedMarkdown(markdown, markdownHtmlDoc.body.innerHTML) as unknown as string; // signal that async code blocks can be now be inserted

Discussion:
Issue Type: <bBug</bHello, Regarding the , in Markdown this: Renders a link. In a VS Code Extension, this is also possible: Creating a link to run a command. One would think creating an actual anchor link like this: Would work but the click does not execute the command. VS Code version: Code 1.63.0 (, 2021-12-07T05:18:59.299Z) OS version: Linux arm64 5.15.7-1-MANJARO-ARM Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ vscode-eslint2.2.2 gitlens11.7.0 vscode-drawio1.6.4 vsliveshare1.0.5242 </details<!-- generated by issue reporter --
can i take this?
I think they'd be happy if you created a PR. For completeness: works: but the cursor does not change to a hand icon like if was populated.
Thanks, will take a look
This is what I found. In markdown links are detected at two places: detects anything starting with http:// or https:// or file:// checks for and returns anything inside () as URI That's why is detected as a link but isn't. I couldn't get to work. I tried holding ctrl while clicking it and tried in preview as well. Can you tell me how to reproduce it?
You'll need to for it to take an action. The example in the link is probably the easiest. After registration create a MarkdownString containing the registered command. In regards to the linked example: You should be able to click on it and see the console log. Note that the cursor doesn't change to a hand icon.
Have you found any solution? For me even doesn't work. :( I've used a registered and available command.
The way I implemented Markdown and executing a registered command (through ) was by adding a . The structure is very particular because it is an implementation of the and is something like this: Make sure you are using the correct VS Code version too.
Command links in should now also work for normal elements included in the markdown (you have to set and on the to enable this)
where should links work? I tried this in a completion item and neither link syntaxes work: !
Sorry for not adding verification details. The markdown string needs to both trusted and have html enabled:
Change:
"command": "git.close", "title": "%command.close%", "category": "Git", <del> "enablement": "!operationInProgress" </del> <ins> "enablement": "!operationInProgress && gitOpenRepositoryCount > 1" </ins> }, { "command": "git.refresh",

Discussion:
Steps to Reproduce: VS Code and open a folder/workspace that contains one git repository to the "Source Control" viewlet, and open the "Source Control Repositories" view click on the repository and choose "Close Repository" viewlet will be into a weird state Expected: If there is only one repository opened, the "Close Repository" command should be disabled
I still see it being enabled, but there's technically no weird state.
After consideration we have decided that one should be able to close the last repository. In that scenario we will be showing a welcome view with a primary action for the user to reopen the closed repository.
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!
Change:
return cachedExtensionToggleData; } <del> if (!environmentService.isBuilt && productService.extensionRecommendations && productService.commonlyUsedSettings) { </del> <ins> if (productService.extensionRecommendations && productService.commonlyUsedSettings) { </ins> const settingsEditorRecommendedExtensions: IStringDictionary<IExtensionRecommendations> = {}; Object.keys(productService.extensionRecommendations).forEach(extensionId => { const extensionInfo = productService.extensionRecommendations![extensionId];

Discussion:
On the latest Stable or Insiders, the Copilot setting button does not show up in the Settings editor when the Copilot extension is disabled or not installed. ! removed the dependency on the assignment/experimentation service incorrectly, and ended up making it so that the feature was only available in OSS aka from-source builds. The main branch fix is available in The candidate PR is available in . [x] Set up a candidate PR
Change:
readonly hasFocus: boolean; /** <ins> * Find out if the window had the last focus. */ hadLastFocus(): Promise<boolean>; /** </ins> * Attempt to bring the window to the foreground and focus it. */ focus(): Promise<void>;

Discussion:
I would like to see the release notes when there's an update, because there are always useful additions that I want to know about, but currently VS Code: re-opens release notes that I have already read, release notes in EVERY SINGLE WINDOW. ! These have been happening for years. Please fix them before I jump off a bridge! There should never be any reason to automatically open them more than ONE time. Perhaps consider using the OS notification system to send ONE notification. If you can't do that, please open ONE window with the release notes, instead of one tab in every window.
/needsMoreInfo does this reproduce if you run with all extensions disabled?
Since some of the conditions to reproduce it (a new release) are outside of my control, and outside of my knowledge until I see the release notes, that's very hard to answer. Are you trying to tell me that you do not have the release notes appear in every single window when you reopen Visual Studio Code and there's a new release? And that you never have them appear again after you've already read them? Since I've seen this happen SO many times, I guessed it happened quite widely.
This seems to be triggered from update, moving to Joao.
Yes there is a known issue: when opening release notes, every window opens them. It's pretty dramatic in your case since you seem to have ~20 windows open. But release notes should not appear twice, unless there's been a recovery update. There was one yesterday: 1.42.1... so that might explain it?
I could swear this issue had been fixed in the past... and I was right. Original issue is and fix was This got broken by
Muito obrigado João!
De nada! Make sure you let us know when stuff annoys you. Sometimes it seems obvious that an issue would annoy everyone but sometimes it just doesn't. :+1:
is there a good way to verify this? If not, I have already verified by code review.
Code review should be
Change:
private readonly _onDidChangeCurrentHistoryItemGroup = new EventEmitter<void>(); readonly onDidChangeCurrentHistoryItemGroup: Event<void> = this._onDidChangeCurrentHistoryItemGroup.event; <del> private readonly _onDidChangeCurrentHistoryItemGroupBase = new EventEmitter<void>(); readonly onDidChangeCurrentHistoryItemGroupBase: Event<void> = this._onDidChangeCurrentHistoryItemGroupBase.event; </del> private readonly _onDidChangeDecorations = new EventEmitter<Uri[]>(); readonly onDidChangeFileDecorations: Event<Uri[]> = this._onDidChangeDecorations.event;

Discussion:
No steps yet, but it happened twice today that I have seen stale decorations, e.g after pull <img width="1367" alt="Screenshot 2024-02-14 at 12 26 08" src=""
Change:
$('div').append($('a').attr('target', '_blank').attr('href', this.requestFeatureLink).text(nls.localize("request a missing feature", "Request a missing feature")).attr('tabindex', '0')) .appendTo($contactUsContainer); <del> let $charCounter = $('span.char-counter').text(this.getCharCountText(0)); </del> <ins> this.remainingCharacterCount = $('span.char-counter').text(this.getCharCountText(0)); </ins> $('h3').text(nls.localize("tell us why?", "Tell us why?")) <del> .append($charCounter) </del> <ins> .append(this.remainingCharacterCount) </ins> .appendTo($form); this.feedbackDescriptionInput = <HTMLTextAreaElement>$('textarea.feedback-description').attr({ rows: 3, <del> maxlength: FeedbackDropdown.MAX_FEEDBACK_CHARS, </del> <ins> maxlength: this.maxFeedbackCharacters, </ins> 'aria-label': nls.localize("commentsHeader", "Comments") }) .text(this.feedback).attr('required', 'required') .on('keyup', () => { <del> $charCounter.text(this.getCharCountText(this.feedbackDescriptionInput.value.length)); this.feedbackDescriptionInput.value ? this.sendButton.removeAttribute('disabled') : this.sendButton.attr('disabled', ''); </del> <ins> this.updateCharCountText(); </ins> }) .appendTo($form).domFocus().getHTMLElement();

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?
Change:
import * as path from 'path'; import * as vscode from 'vscode'; import { Utils } from 'vscode-uri'; <ins> import { Schemes } from '../util/schemes'; </ins> import { createUriListSnippet, tryGetUriListSnippet } from './dropIntoEditor'; const supportedImageMimes = new Set([

Discussion:
The image paste handler introduced days ago overrides the notebook markdown paste handler The markdown workspace selector is and the notebook markdown one is , both matches the markdown cell in a notebook. The former is faster than the latter often times so most of the time, I got the workspace link instead of the notebook attachment link. Catch here is it's not guaranteed which one will take effect as it's all perf based.