jiebi/CodeConvo huggingface dataset:
Change:
background-color: var(--vscode-editor-hoverHighlightBackground); } <ins> .monaco-editor .monaco-hover-content { padding-right: 2px; box-sizing: border-box; } </ins> .monaco-editor .monaco-hover { color: var(--vscode-editorHoverWidget-foreground); background-color: var(--vscode-editorHoverWidget-background);

Discussion:
! Version: 1.90.0-insider Commit: Date: 2024-05-29T05:50:53.996Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.5.0
hey yes thank you for posting this issue. I am precisely investigating this issue right now, it is likely to be caused by the following PR
Feel free to close if it's a duplicate or something
Change:
} } break; <ins> case 'use-inmemory-secretstorage': if (argvValue) { process.argv.push('--use-inmemory-secretstorage'); } break; </ins> } } });

Discussion:
Originally posted by in This was mostly an oversight on my part.
Fixed in In the (Configure Runtime Arguments) we have two improvements: both and now show up in completions (they no longer say "not allowed") in is plumbed through properly
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
verification: run: make sure and show up in completions make sure you are currently logged in to any account and have an extension that asks for auth now set to restart VS Code you should be asked to log in because you are now using the inmemory store remote the setting from your now restart VS Code you should be logged in again because you are no longer using the inmemory store
Sorry the completion should only be seen on Linux
Change:
"command.commit": "Commit", "command.commitStaged": "Commit Staged", "command.commitStagedSigned": "Commit Staged (Signed Off)", <ins> "command.commitStagedAmend": "Commit Staged (Amend)", </ins> "command.commitAll": "Commit All", "command.commitAllSigned": "Commit All (Signed Off)", <ins> "command.commitAllAmend": "Commit All (Amend)", </ins> "command.undoCommit": "Undo Last Commit", "command.checkout": "Checkout to...", "command.branch": "Create Branch...",

Discussion:
Like: git commit --amend
Are you referring to the out of the box git behavior or any particular git extension?
I would guess the out of the box behaviour, because it seems to be missing? I can see there is an "undo last commit", but this unstages everything from the last commit, which is not the same thing as amending the current commit. git-gui and atom have a simple checkbox which then amends the current commit instead of creating a new one - would it be possible to have the same in vscode? It's the one thing that stops me using vscode's built in git interface. In other words, you should be able to check and then uncheck the checkbox and be left in the original state. With the "undo last commit", this isn't possible.
Yes, out of the box
command was some time ago by
Should there be something in the menu? Please can you tell me where the option is?
Hmmm.... looks like it has disappeared for some reason, probably was omitted when git integration was ported to new API... will probably know if it was by-design, or just someone missed one command while porting git integration.
I believe we simply missed it... sorry for that.
I'll add it again.
Change:
this._chatAccessibilityService.acceptResponse(responseContent, accessibilityRequestId); const containsCode = responseContent.includes('```'); this._chatWidget?.value.inlineChatWidget.updateChatMessage({ message: new MarkdownString(responseContent), requestId: this._currentRequest.id, providerId: 'terminal' }, false, containsCode); <del> // the message grows in height, be sure to update top position so it doesn't go below the terminal this._chatWidget?.value.layoutVertically(); </del> <ins> this._chatWidget?.value.updateHeight(); </ins> this._responseContainsCodeBlockContextKey.set(containsCode); this._chatWidget?.value.inlineChatWidget.updateToolbar(true); this._messages.fire(Message.ACCEPT_INPUT);

Discussion:
Repro: terminal chat "list files in various ways", content is clipped at bottom but scrolling doesn't work !

Repro: terminal chat "list files in various ways" height of terminal !
, we'd need a way to set max height for the chat widget, which there isn't currently AFAICT
You need to call layout with the sizes you want
i tried that and didn't see the height taking effect, only the width.
Change:
).snippet.value, 'foobar(${1:param})$0'); }); <ins> test('Should skip over this parameter', async () => { assert.strictEqual( snippetForFunctionCall( { label: 'foobar', }, [{ "text": "function", "kind": "keyword" }, { "text": " ", "kind": "space" }, { "text": "foobar", "kind": "functionName" }, { "text": "(", "kind": "punctuation" }, { "text": "this", "kind": "parameterName" }, { "text": ":", "kind": "punctuation" }, { "text": " ", "kind": "space" }, { "text": "string", "kind": "keyword" }, { "text": ",", "kind": "punctuation" }, { "text": "param", "kind": "parameterName" }, { "text": ":", "kind": "punctuation" }, { "text": " ", "kind": "space" }, { "text": "string", "kind": "keyword" }, { "text": ")", "kind": "punctuation" }, { "text": ":", "kind": "punctuation" }, { "text": " ", "kind": "space" }, { "text": "void", "kind": "keyword" }] ).snippet.value, 'foobar(${1:param})$0'); }); </ins> });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.3 OS Version: Darwin x64 18.7.0 Steps to Reproduce: completeFunctionCall new tyepscript file, ype cursor at <kbdTAB</kbdExpected: Actual: Does this issue occur when all extensions are disabled?: Yes/No
Change:
import { CommandOptions, ForkOptions, Source, SuccessData, TerminateResponse, TerminateResponseCode } from 'vs/base/common/processes'; import * as Types from 'vs/base/common/types'; import * as pfs from 'vs/base/node/pfs'; <del> export { CommandOptions, ForkOptions, SuccessData, Source, TerminateResponse, TerminateResponseCode }; </del> <ins> export { type CommandOptions, type ForkOptions, type SuccessData, Source, type TerminateResponse, TerminateResponseCode }; </ins> export type ValueCallback<T> = (value: T | Promise<T>) => void; export type ErrorCallback = (error?: any) => void;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:
We reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See
Change:
this._store.add(menu.onDidChange(() => updateToolbar())); const ctxKeys = new Set<string>([SCMInputContextKeys.ActionIsEnabled.key, SCMInputContextKeys.ActionIsRunning.key]); <del> Event.filter(contextKeyService.onDidChangeContext, e => e.affectsSome(ctxKeys))(() => updateToolbar()); </del> <ins> this._store.add(Event.filter(contextKeyService.onDidChangeContext, e => e.affectsSome(ctxKeys))(() => updateToolbar())); </ins> // Delay initial update to finish class initialization setTimeout(() => updateToolbar(), 0);

Discussion:
a change to a file the file another view so that the SCM view isn't visible the window sparkle will be disabled when you open the SCM view
nice catch! Thank you!
Change:
@IEditorGroupsService private readonly editorGroupService: IEditorGroupsService, @IKeybindingService private readonly keybindingService: IKeybindingService, @INotificationService private readonly notificationService: INotificationService, <ins> @IAccessibleNotificationService private readonly accessibleNotificationService: IAccessibleNotificationService </ins> ) { super(themeService);

Discussion:
Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
// Checkbox const label = dom.append(data.entry, $('label.quick-input-list-label')); <ins> data.toDisposeTemplate.push(dom.addStandardDisposableListener(label, dom.EventType.CLICK, e => { if (!data.checkbox.offsetParent) { // If checkbox not visible: e.preventDefault(); // Prevent toggle of checkbox when it is immediately shown afterwards. #91740 } })); </ins> data.checkbox = <HTMLInputElement>dom.append(label, $('input.quick-input-list-checkbox')); data.checkbox.type = 'checkbox'; data.toDisposeTemplate.push(dom.addStandardDisposableListener(data.checkbox, dom.EventType.CHANGE, e => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Configure ! Settings and OK ! Configure again is unchecked ! Logs imply the Settings are synced: <details<summaryLogs</summary<p</p</details
This seems to be a quick pick bug, because I see the state correctly when I run the command `Settings Sync: Configure...'
other mult-selects do not have the same problem... !
What I can say is that configure settings sync options go through same code path Gear -Settings Sync is On -Settings Sync Configure... F1 Settings Sync: Configure You can repro this when you use mouse to choose the option in both cases. So something is wrong with quick pick when using mouse. If you use keyboard it works.
Change:
if (this.extensionManagementServerService.localExtensionManagementServer === this.extension.server) { if (this.extensionManifestPropertiesService.prefersExecuteOnWorkspace(this.extension.local.manifest)) { if (this.extensionManagementServerService.remoteExtensionManagementServer) { <del> message = new MarkdownString(`${localize('Install in remote server to enable', "This extension is disabled in this workspace because it is defined to run in the Remote Extension Host. Please install the extension in '{0}' to enable.", this.extensionManagementServerService.remoteExtensionManagementServer.label)} [${localize('learn more', "Learn More")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`); </del> <ins> message = new MarkdownString(`${localize('Install in remote server to enable', "This extension is disabled in this workspace because it is defined to run in the Remote Extension Host. Please install the extension in '{0}' to enable.", this.extensionManagementServerService.remoteExtensionManagementServer.label)} [${localize('learn more', "Learn More")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`); </ins> } } }

Discussion:
Type: <bBug</bIn the below image, clicking the link Learn More brings you to However, that section (id) does not exist on The link is most likely supposed to go to ! VS Code version: Code 1.87.2 (, 2024-03-08T15:20:17.278Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.4.0-173-generic <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ yang0.1.3 jupyter-keymap1.1.2 remote-containers0.348.0 remote-ssh0.109.0 remote-ssh-edit0.86.0 remote-wsl0.86.0 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.1 vscode-openapi4.25.1 vscode-fish1.0.38 ruff2024.16.0 vale-vscode0.18.5 vscode-markdownlint0.54.0 gitlens14.9.0 prettier-vscode10.1.0 code-runner0.12.1 go0.41.1 restructuredtext189.3.0 direnv0.17.0 vscode-azureresourcegroups0.8.4 vscode-cosmosdb0.20.1 vscode-docker1.29.0 vscode-kubernetes-tools1.3.15 python2024.2.1 azure-account0.11.6 vscode-yaml1.14.0 code-spell-checker3.0.1 even-better-toml0.19.2 shellcheck0.37.0 simple-rst1.5.4 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
} /** <ins> * @param {boolean} disallowReloadKeybinding </ins> * @returns {() => void} */ <del> function registerDeveloperKeybindings() { </del> <ins> function registerDeveloperKeybindings(disallowReloadKeybinding) { </ins> // @ts-ignore const ipc = require('electron').ipcRenderer;

Discussion:
Issue Type: <bBug</bHitting Ctrl+R refresh Issue Report window content and the filled information are lost after refreshing. VS Code version: Code 1.35.1 (, 2019-06-12T14:27:31.086Z) OS version: Linux x64 4.15.0-54-generic <details<summaryExtensions (15)</summaryExtensionVersion ------ githistory0.4.6 es7-react-js-snippets2.3.0 json-tools1.0.2 prettier-vscode1.9.0 composer-support-client0.19.12 golang-tdd0.0.9 solidity0.0.56 vscode-docker0.7.0 python2019.6. cpptools0.24.0 Go0.11.4 sqltools0.19.6 material-icon-theme3.8.0 sass-indented1.5.1 gitblame2.8.1 </details<!-- generated by issue reporter --
Change:
return !value ? '' : (value[0].toLocaleUpperCase() + value.substr(1)); } else if (this.shorthandName === 'pascalcase') { return !value ? '' : this._toPascalCase(value); <ins> } else if (this.shorthandName === 'camelcase') { return !value ? '' : this._toCamelCase(value); </ins> } else if (Boolean(value) && typeof this.ifValue === 'string') { return this.ifValue; } else if (!Boolean(value) && typeof this.elseValue === 'string') {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I see the grammar at only supports , , and for format options. can there be a option that would transform the match text into camelCase? Thanks for the awesome work!
Just FYI, I believe pascalcase is also supported but undocumented.
The docs were updated to include in
To verify: insert a snippet like below type 'Hello_World' press the second line should become
Change:
{ "id": "nodejsWelcome", "title": "%walkthroughs.nodejsWelcome.title%", <ins> "icon": "media/nodejsWalkthroughIcon.png", </ins> "description": "%walkthroughs.nodejsWelcome.description%", "when": "false", "steps": [

Discussion:
Is there a way to use a codicon instead of an extension PNG? It feels out of place amongst built-in walkthroughs that can use a codicon. <img width="539" alt="CleanShot 2022-10-07 at 14 27 23 src="https://user-"cc since we chatted about this before
Conversation over at
Change:
const sound = this.sounds.get(url); if (sound) { sound.volume = this.getVolumeInPercent() / 100; <ins> sound.currentTime = 0; </ins> await sound.play(); } else { const playedSound = await playAudio(url, this.getVolumeInPercent() / 100);

Discussion:
has indicated that the diff inserted / modified audio cues are hard to differentiate and that the sounds are not as fast / singular toned as they should be
what do you think of this?
I agree with the suggestion. At least for me it is very difficult to identify the difference between the sounds used.
Sounds good -- will start on this asap.
I don't hear the cues as often anymore. I also noticed that when using up/down keys on the right diff editor, no audio cue shows up for a deleted section. Example with .gitignore file: Left: Right:
I can reproduce
it's getting to the line I expect it to (see logs) but no sound is produced - thoughts? https://user-
Change:
} private handleClosedEditors(): void { <del> this.handlePinnedTabsLayoutChange(); </del> <ins> this.handleTabBarsStateChange(); </ins> } moveEditor(editor: EditorInput, fromIndex: number, targetIndex: number, stickyStateChange: boolean): void {

Discussion:
Type: <bBug</bfile A from EXPLORER tab with file A file B from EXPLORER -breadcrumb shows file B path (correct) on the pinned tab with file A -breadcrumb shows file B path but should file A This is the minimal case. When I have multiple pinned tabs and open other files, the breadcrump gets more random. UPDATE: Looks like the bug only comes out if this setting is set to true: VS Code version: Code 1.92.2 (, 2024-08-14T17:29:30.058Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ macos-modern-theme2.3.19 better-cpp-syntax1.27.1 remote-containers0.380.0 remote-ssh0.113.1 remote-ssh-edit0.86.0 remote-wsl0.88.2 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.2 vscode-clangd0.1.29 regionfolder1.0.22 cmake-tools1.18.44 cpptools1.21.6 workspace-include-what-you-use0.0.3 cmake0.0.17 (4 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This doesn't reproduce for me. Please try without extensions enabled and without custom settings
I turned off extensions and custom settings. I nailed it down to this setting in It appears that the bug is reproducible only if is true.
can you help here? It seems that pinned, extra-row items don't make the call to the breadcrumbs controls, like how it is done for instance for the
Thanks for steps. could you take a look?
Thanks for reporting. When switching to the last previous active tab of the other tab bar it wasn't updating the breadcrumbs. Made a fix
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Still doesn't work correctly on current insiders version. Version: 1.93.0-insider (user setup) Commit: Date: 2024-08-23T06:45:56.108Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.
Change:
switch (value) { case types.DiagnosticTag.Unnecessary: return MarkerTag.Unnecessary; <ins> case types.DiagnosticTag.Deprecated: return MarkerTag.Deprecated; </ins> } return undefined; }

Discussion:
Now that has been to the API, I would like to support the proposal from to use it for tagging deprecated items. I figure the associated styling might be a strikethrough as proposed in but you guys can work that out separately.
I would be interested in helping out here with this and perhaps even . Without a lot of context, I assume this issue is specifically to add a new enum member here: I could open a PR that adds a member, if that's the case. edit: Looks like more applicable location would be and then opening a similar PR to
Yes, is the way to go. Find your way along usages/implementations of
Thanks, I'll work on that today.
Leaving this open so that we discuss this in the API sync
API has been finalised.
Change:
fixedOverflowWidgets: true, minimap: { enabled: false }, renderSideBySide: false, <del> readOnly: false, ignoreTrimWhitespace: false </del> <ins> readOnly: false </ins> }; this.diffEditor = this.instantiationService.createInstance(EmbeddedDiffEditorWidget, container, options, this.editor);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --With , changes in a diff editor: [![enter image description here][1]][1] With , changes in a diff editor: [![enter image description here][2]][2] With , changes in a normal (non-diff) editor: [![enter image description here][3]][3] How to ignore changes in leading/trailing whitespace in a non-diff editor as well? If such a setting doesn't exist, please consider adding one. [1]: [2]: [3]:
I've removed the label, because this issue is about the hard-coded value . If that line of code would be commented out, I think everything would work as desired (the quick diff would respect the setting).
Maybe I'm misunderstanding, but this doesn't seem to work? ! In case it isn't clear in the picture, I just whitespace
I reproduced as well.
Turns out this isn't true.
Sorry about that!
No worries, I know you were just hinting.
Verification: There's a new setting to control this.