jiebi/CodeConvo huggingface dataset:
Change:
import { ModesGlyphHoverWidget } from 'vs/editor/contrib/hover/modesGlyphHover'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { IOpenerService } from 'vs/platform/opener/common/opener'; <del> import { editorHoverBackground, editorHoverBorder, editorHoverHighlight, textCodeBlockBackground, textLinkForeground, editorHoverStatusBarBackground, editorHoverForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { editorHoverBackground, editorHoverBorder, editorHoverHighlight, textCodeBlockBackground, textLinkForeground, editorHoverStatusBarBackground, editorHoverForeground, textLinkActiveForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { AccessibilitySupport } from 'vs/platform/accessibility/common/accessibility'; import { GotoDefinitionAtPositionEditorContribution } from 'vs/editor/contrib/gotoSymbol/link/goToDefinitionAtPosition';

Discussion:
editor hover over any link correctly uses and ignores ! VS Code version: Code - Insiders 1.56.0-insider (, 2021-04-16T11:25:09.662Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.57 --<!-- potentialduplicatescomment --
can you explain the issue/feature to me a bit more? The way I am understanding it right now, is the behavior I am seeing, so I think I am misunderstanding something. I have this in my settings. This is what I see. Where/when am I expected to see the blue text? <img width="939" alt="Screen Shot 2021-05-07 at 6 43 02 PM" src="https://user-"
when you mouseover the link, like here: !
thanks for clarifying, submitted a PR for this.
Change:
}); } <del> override async run(accessor: ServicesAccessor): Promise<void> { const editorService = accessor.get(IEditorService); </del> <ins> override async run(accessor: ServicesAccessor, resourceOrContext?: URI | IEditorCommandsContext, context?: IEditorCommandsContext) { </ins> const editorGroupService = accessor.get(IEditorGroupsService); <del> const activeEditorPane = editorService.activeEditorPane; if (!activeEditorPane) { return; } </del> <ins> const { group, editor } = resolveCommandsContext(editorGroupService, getCommandsContext(resourceOrContext, context)); if (group && editor) { const auxiliaryEditorPart = await editorGroupService.createAuxiliaryEditorPart(); </ins> <del> const auxiliaryEditorPart = await editorGroupService.createAuxiliaryEditorPart(); </del> <ins> if (this.move) { group.moveEditor(editor, auxiliaryEditorPart.activeGroup); } else { group.copyEditor(editor, auxiliaryEditorPart.activeGroup); } </ins> <del> if (this.move) { activeEditorPane.group.moveEditor(activeEditorPane.input, auxiliaryEditorPart.activeGroup); } else { activeEditorPane.group.copyEditor(activeEditorPane.input, auxiliaryEditorPart.activeGroup); </del> <ins> auxiliaryEditorPart.activeGroup.focus(); </ins> } <del> auxiliaryEditorPart.activeGroup.focus(); </del> } }

Discussion:
Type: <bBug</bPer this is a new issue related to issue . Currently in insiders, the tab with focus will be the one moved or copied into new window via context menu, even when I right-click on a different tab. I can understand the user NOT wanting right-click of non-focused tab to give it focus, but intuitively, it seems you'd want the context menu to act on the tab you right-clicked, regardless if the tab is the one with focus or not. VS Code version: Code - Insiders 1.85.0-insider (, 2023-12-01T14:17:40.644Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ remote-containers0.326.0 remote-ssh0.107.1 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.25.0 remote-explorer0.4.1 remote-server1.5.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
group: 'navigation', order: -1 }, <del> { id: TerminalChatExecute, when: ScopedChatSynthesisInProgress, group: 'navigation', order: -1 } </del> ] }); }

Discussion:
terminal I -notice double microphone icons I do not have the voice extension installed. ! fyi
Caused by:
looks the most relevant
Why does the terminal have its own execute menu?
Is it possible to clean up the parallel execute menu and submit actions? I'm unclear whether I can just move the voice actions to or you need a new parallel menu for terminal customizations.
I did the first one, seems to work, but please clean up the terminal-specific stuff if possible
Can you be more specific?
so I do have a lot of special code for terminal in using stuff like , which maybe now is obsolete? Did something change to consolidate inline chat in terminal?
This isn't actionable without more info. Terminal chat still has a separate widget implementation, it extends inline chat and shares a lot of code, but must be separate as it's not a monaco content widget for example.
Yeah I did a quick attempt to remove my terminal specific code but restored it, as it still seemed to be needed.
That was directed at the terminal widget stuff- it has its own execute menu and execute action, and I only looked briefly but it seemed like it was doing the same thing as the base chat submit action. TerminalChatWidget uses InlineChatWidget which uses the normal ChatWidget, I'd expect that the execute toolbar can be the same regardless of whether it shows up in an editor or a terminal.
did all that stuff so she might be able to comment better than me.
When I last investigated this, , the chat widget's submit action was dependent on an editor, which we don't have in terminal chat, and was defined in a place where the was not accessible. I can look into doing this now though as it seems the code has changed since then.
Change:
this._elements.followUps.tabIndex = 0; this._elements.followUps.ariaLabel = this._accessibleViewService.getOpenAriaHint(AccessibilityVerbositySettingId.InlineChat); this._elements.statusLabel.tabIndex = 0; <ins> // this._elements.status this._store.add(setupCustomHover(getDefaultHoverDelegate('element'), this._elements.statusLabel, () => { return this._elements.statusLabel.dataset['title']; })); </ins> this._store.add(this._chatService.onDidPerformUserAction(e => { if (e.sessionId === this._chatWidget.viewModel?.model.sessionId && e.action.kind === 'vote') { this.updateStatus('Thank you for your feedback!', { resetAfter: 1250 });

Discussion:
When inline chat changes more than one hunk it just shows "N changes". We should make that more explicit, e.g that it is todo-list-like and something that we need to accept explicit per change
I made the message more explicit, the info icon, and a hover message. This is how it now looks <img width="1136" alt="image" src=""
Change:
// Audio Cues import 'vs/workbench/contrib/audioCues/browser/audioCues.contribution'; <ins> // Deprecated Extension Migrator import 'vs/workbench/contrib/deprecatedExtensionMigrator/browser/deprecatedExtensionMigrator.contribution'; </ins> //#endregion

Discussion:
Despite has been removed from the marketplace by the author, telemetry suggests that there are still hundred thousands of active users using the extension. Because the extension causes the extension host to freeze (degrading the entire VS Code experience) and there is both a newer version of the extension and that does not suffer performance problems (which is actually enabled by default), we should try to push users to move away from this unpublished extension. We should disable the Bracket Pair Colorizer 1 extension for all users. This should happen only once per installation, so that users can still re-enable the extension. We should also show a notification that we disabled the extension. When a user disabled the native bracket pair colorization feature, the notification should include an option to enable the native colorization feature.
Verification steps: Install Reload Verify that the extension got disabled and a notification is shown. Try out the various options of the notification. Enable the extension again and reload. Verify that the extension is not disabled again.
Change:
return commandHistory; } <ins> let directoryHistory: ITerminalPersistedHistory<null> | undefined = undefined; export function getDirectoryHistory(accessor: ServicesAccessor): ITerminalPersistedHistory<null> { if (!directoryHistory) { directoryHistory = accessor.get(IInstantiationService).createInstance(TerminalPersistedHistory, 'dirs') as TerminalPersistedHistory<null>; } return directoryHistory; } </ins> export class TerminalPersistedHistory<T> extends Disposable implements ITerminalPersistedHistory<T> { private readonly _entries: LRUCache<string, T>; private _timestamp: number = 0;

Discussion:
We should not sync this Should this be per terminal instance? No We should persist similar to recent commands as well Should persisted entries work across different shells? Probably We should invalidate entries similar to commands Let's support removing entries, using a icon that shows only on active and hovered item Let's not use the x for failed, we can improve visualizing errors later on
Change:
.monaco-workbench .inline-chat .status .actions { display: flex; <ins> padding-top: 4px; </ins> } .monaco-workbench .inline-chat .status .actions > .monaco-button,

Discussion:
See how the padding is ~double that on top than on the side ! It looks particularly bad imo when a response is in progress: ! It's also ~half on bottom: ! Could we make the padding consistent on all sides?
Padding also looks pretty bad in terminal: !
When showing a result the chat widget height is off by 3px, e.g its reported content height is small then the height takes... <img width="1411" alt="Screenshot 2024-03-22 at 16 22 35" src=""
Should be looking better now <img width="1277" alt="Screenshot 2024-03-26 at 20 58 39" src=""
Much better Does it look wrong with this part gone too? !
Yeah, I had played with that and wasn't happy. The different radii (from the input and zone) get close enough to make it look weird. Also, the focus border makes it appear as too narrow
Change:
if (options.includePattern) { includeSearchPathsInfo = options.expandPatterns ? this.parseSearchPaths(options.includePattern) : <del> { pattern: patternListToIExpression(...splitGlobPattern(options.includePattern)) }; </del> <ins> { pattern: patternListToIExpression(options.includePattern) }; </ins> } let excludeSearchPathsInfo: ISearchPathsInfo = {}; if (options.excludePattern) { excludeSearchPathsInfo = options.expandPatterns ? this.parseSearchPaths(options.excludePattern) : <del> { pattern: patternListToIExpression(...splitGlobPattern(options.excludePattern)) }; </del> <ins> { pattern: patternListToIExpression(options.excludePattern) }; </ins> } // Build folderQueries from searchPaths, if given, otherwise folderResources

Discussion:
Use this code in an extension, run the command In 1.31, it returns no results because takes a single glob pattern In 1.32, it returns results because the include and exclude patterns for are split on the comma
This is a candidate because it would be an API change. If we want to support multiple glob patterns we should use an array like we discussed in Parsing a comma-delimited string in this API feels wrong.

1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the ´Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for
Would be fixed by .
Change:
*--------------------------------------------------------------------------------------------*/ import * as vscode from 'vscode'; <ins> import { OpenJsDocLinkCommand, OpenJsDocLinkCommand_Args } from '../../commands/openJsDocLink'; </ins> import type * as Proto from '../../tsServer/protocol/protocol'; <ins> import * as typeConverters from '../../typeConverters'; </ins> export interface IFilePathToResourceConverter { /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: see below, pulled from the "Help About" dialog. Also confirmed in 1.71.2. OS Version: see below, pulled from the "Help About" dialog. Steps to Reproduce: above VSCode Insiders build. (Instructions don't require system path to be updated.) a directory in WSL, say . , where is the distro of your choice. the WSL extension as prompted and reload. the editor and run , where is the distro of your choice. (Steps 2-4 were just to initialize some VSCode state.) a new file in that directory with the following contents: restart editor. (Works either way.) over above. tooltip will appear with "some thing linking Foo" where is hyperlinked. Click the hyperlink in the tooltip. attempts to open a file at the path in the parent Windows OS, outside of any WSL distro. Note that this reproduces both with the WSL extension enabled the whole time (skipping step 5) and with it disabled at step 5.
Did this get missed?
I have the same issue with VSCode running in WSL2 (Ubuntu)
Same issue here, using a remote connection to a VM running on Hyper-V. Host OS is Windows, guest OS is Ubuntu 22.04. It only happens when clicking the link in the tooltip. Using directly in the editor works as expected.
Still seeing this issue. Looking forward to this getting resolved soon.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
this.runAction(this.instantiationService.createInstance(SearchExtensionsAction, searchValue)); } }, { <del> label: choiceNever, </del> <ins> label: donotShowAgainLabel, </ins> isSecondary: true, run: () => { onDidNeverShowRecommendedExtensionsAgain(extensions);

Discussion:
Type: <bFeature Request</bThe notification suggesting a plugin has a cog with an option "Don't show again". It's however not clear whether this suppresses suggesting the specific plugin, or any plugin. Either this message should be clarified ("Don't show this plugin again") or a second option should be . VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
<img width="485" alt="image" src=""<img width="478" alt="image" src=""
Thank you.
Change:
return; } this._inlineChatKeybinding = keybinding; <del> const hoverMessage = new MarkdownString(keybinding ? localize('runWithKeybinding', 'Start Inline Chat [{0}]', keybinding) : LOCALIZED_START_INLINE_CHAT_STRING); </del> <ins> const hoverMessage = new MarkdownString(keybinding ? localize('runWithKeybinding', 'Start Inline Chat ({0})', keybinding) : LOCALIZED_START_INLINE_CHAT_STRING); </ins> this._gutterDecorationTransparent.glyphMarginHoverMessage = hoverMessage; this._gutterDecorationOpaque.glyphMarginHoverMessage = hoverMessage; }

Discussion:
Follow up on Currently we wrap the kb in brackets: <img width="193" alt="image" src=""But we use parentheses in other places where the keybinding is shown, eg hover over problems or terminal pane label, or other icons. <img width="199" alt="image" src=""
Hi thank you for posting this issue. Indeed when I chose the square brackets I was not sure what type of brackets to use. In the editor toolbar menu for example, we appear to be using square brackets. However now that I am looking at the keybindings it appears to me we may be using square brackets for keybinding chords only. I'll ask in the UX channel about this. <img width="423" alt="Screenshot 2023-11-28 at 17 26 10" src=""
Change:
private _incomingMsgLastTime: number; private _incomingAckTimeout: any | null; <ins> private _keepAliveInterval: any | null; </ins> private _lastReplayRequestTime: number; private _lastSocketTimeoutTime: number;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Background: Modern reverse proxies like nginx or cloudflare use timeouts for dormant websocket connections. For nginx this defaults to 60s and for Cloudflare to 100s. In case of Cloudflare, this is not configurable for non-enterpise users. Due to the fixes in , the management connection is now typically being idle for extended periods of time. If the web-socket connection is being terminated by the reverse proxy, even if it can be reestablished immediately, a modal dialog is being shown, which disturbs the user immensely. For reference see In order to support Cloudflare it is essential, that we either implement a keep-alive ping (my proposal would by every 45s by default), or alternatively, make it so an immediate reconnect does not cause any negative consequences for the user.
any insights here?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Version: 1.71.0-insider Commit: Date: 2022-08-26T23:24:52.456Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36 /verified I do no longer experience regular reconnects every 100 seconds behind cloudflare with the build above.
Change:
/** * A symbol tree input is the entry point for populating the references viewlet. <del> * Inputs must be anchored at a code location, they must have a title, and they </del> <ins> * Inputs must be anchored at a code location, they must have a title, and they </ins> * must resolve to a model. */ export interface SymbolTreeInput<T> {

Discussion:
Ah, sorry for the breakage... I believe asking for both is the best option for now but I can also add a "migration" path into the implementation, e.g use when seeing Originally posted by in
Change:
cwd: args.cwd, name: terminalName, iconPath: new ThemeIcon('debug'), <del> env: args.env, </del> }; giveShellTimeToInitialize = true; terminal = this._terminalService.createTerminalFromOptions(options, {

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
%{_datadir}/%{name}/ %{_datadir}/applications/%{name}.desktop %{_datadir}/applications/%{name}-url-handler.desktop <ins> %{_datadir}/appdata/%{name}.appdata.xml </ins> %{_datadir}/mime/packages/%{name}-workspace.xml %{_datadir}/pixmaps/@@ICON@@.png %{_datadir}/bash-completion/completions/%{name}

Discussion:
Neither the vscode repository nor the package itself provide any appdata, which is important to have gnome-software working properly. The vscode repository should generate appstream data (xml) and provide them. So the PackageKit can save it into /var/cache/app-info/xmls/. The itself also should install a into /usr/share/metainfo/. Look here:
I believe we include in the root of the package, is that not the case?
Unfortunately, it is not the case. There's no or file. Output from : The preferred place for that appdata file is Then the repository creation should also include generating AppStream repository metadata. The mechanics of doing this is documented here: (Ignore the argument, that should not be used)
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This should be reopened, because it's still broken.
Confirmed that the deb package is good but that the rpm package has this issue.
I have about 200 messages coming a day I don't know what happened how do I unsubscribe from this Microsoft thing vs code please advise
see
Verification steps: the on a Linux distribution with rpm (the link downloads an x64 .rpm file) in a terminal that shows up.
Change:
} } <del> test('dirty untitled text file model opens as editor', async function () { const accessor = await createTracker(); </del> <ins> test('dirty untitled text file model opens as editor', function () { return testUntitledEditor(false); }); test('dirty untitled text file model opens as editor - autosave ON', function () { return testUntitledEditor(true); }); async function testUntitledEditor(autoSaveEnabled: boolean): Promise<void> { const accessor = await createTracker(autoSaveEnabled); </ins> const untitledTextEditor = await accessor.textEditorService.resolveTextEditor({ resource: undefined, forceUntitled: true }) as UntitledTextEditorInput; const model = disposables.add(await untitledTextEditor.resolve());

Discussion:
A bug in our tracker for dirty models, somehow never reported but obvious in an issue I noticed with Copilot. The end result is that you see a dirty indicator e.g. in the explorer but no editor that is opening and associated with it. Steps:
Tried to look at the steps to repro but seems the link to the copilot issue is broken or at least I am not able to access it.
I'm still getting this with copilot nightly in insiders <img width="652" alt="image" src="https://user-"
Please note that my change does not fix the Copilot issue. The steps to verify are unclear: it is expected when you see an untitled editor opening. You must test with auto save on.
Setting back verified label based on the screenshot.