jiebi/CodeConvo huggingface dataset:
Change:
return `(?<col${ci++}>d+)`; } <ins> const eolSuffix = eolOnly ? '$' : ''; </ins> // The comments in the regex below use real strings/numbers for better readability, here's // the legend: // - Path = foo

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work!

It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged
Change:
: nls.localize('links.command', "Ctrl + click to execute command") ); <del> const HOVER_MESSAGE_GENERAL_ALT = new MarkdownString().appendText(nls.localize('links.navigate.al', "Alt + click to follow link")); const HOVER_MESSAGE_COMMAND_ALT = new MarkdownString().appendText(nls.localize('links.command.al', "Alt + click to execute command")); </del> <ins> const HOVER_MESSAGE_GENERAL_ALT = new MarkdownString().appendText( platform.isMacintosh ? nls.localize('links.navigate.al.mac', "Option + click to follow link") : nls.localize('links.navigate.al', "Alt + click to follow link") ); const HOVER_MESSAGE_COMMAND_ALT = new MarkdownString().appendText( platform.isMacintosh ? nls.localize('links.command.al.mac', "Option + click to execute command") : nls.localize('links.command.al', "Alt + click to execute command") ); </ins> const decoration = { meta: ModelDecorationOptions.register({

Discussion:
VSCode Version: Code - Insiders 1.19.0-insider (, 2017-12-01T06:07:42.474Z) OS Version: Darwin x64 16.5.0 Extensions: ExtensionVersion ------ beautify1.1.1 vscode-caniuse0.5.0 jshint0.10.15 tslint1.0.24 php-debug1.12.1 php-intellisense2.0.4 php-pack1.0.1 plantuml2.3.3 vscode-duplicate1.2.0 sublime-keybindings3.0.3 debugger-for-chrome3.5.0 laravel-blade1.10.0 Steps to Reproduce: a HTML file with references to javascript files over the path of the JS file in any <scripttag 'll get the tooltip "Alt + click to follow link" Well, there isn't an Alt key in my MacOS keyboard (stock Apple keyboard). So saying "Option + click to follow link" will make more sense for Mac users. Not a big deal though. Thought I'll just point out. :) <!-- Launch with to check. --Reproduces without extensions: Yes/No
Change:
} setState(state: StickyScrollWidgetState): void { <del> if (state.equals(this._state)) { return; } this._state = state; </del> dom.clearNode(this._rootDomNode); this._disposableStore.clear(); this._lineNumbers.length = 0;

Discussion:
enable sticky scroll open a file and scroll such that sticky scroll appears reload the window observe that the sticky scroll lines are not colored until they get rerendered once there is that could be used
Hey thanks for filing the issue. The listener onDidChangeModelTokens already exists inside of the sticky scroll code. I'll investigate the issue.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.
Change:
"config.checkoutType.remote": "Remote branches", "config.branchPrefix": "Prefix used when creating a new branch.", "config.branchProtection": "List of protected branches. By default, a prompt is shown before changes are committed to a protected branch. The prompt can be controlled using the `#git.branchProtectionPrompt#`  setting.", <del> "config.branchProtectionPrompt": "Controls whether a prompt is being before changes are committed to a protected branch.", </del> <ins> "config.branchProtectionPrompt": "Controls whether a prompt is being shown before changes are committed to a protected branch.", </ins> "config.branchProtectionPrompt.alwaysCommit": "Always commit changes to the protected branch.", "config.branchProtectionPrompt.alwaysCommitToNewBranch": "Always commit changes to a new branch.", "config.branchProtectionPrompt.alwaysPrompt": "Always prompt before changes are committed to a protected branch.",

Discussion:
Type: <bBug</bView the setting called "Git: Branch Protection Prompt" either using the UI Settings or the JSON settings. The description says: I believe this should say something like: VS Code version: Code 1.72.1 (, 2022-10-10T17:22:48.346Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ material-icon-theme4.21.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
import { $, append } from 'vs/base/browser/dom'; import { IHoverOptions, IManagedHover, IManagedHoverTooltipMarkdownString } from 'vs/base/browser/ui/hover/hover'; import { IHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegate'; <del> import { createInstantHoverDelegate, getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; </del> <ins> import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; </ins> import { IconLabel } from 'vs/base/browser/ui/iconLabel/iconLabel'; import { IIdentityProvider, IKeyboardNavigationLabelProvider, IListVirtualDelegate } from 'vs/base/browser/ui/list/list'; import { LabelFuzzyScore } from 'vs/base/browser/ui/tree/abstractTree';

Discussion:
Testing I think we have another issue discussing a similar issue. This hover and the main item hover can conflict with each other: <img width="579" alt="Screenshot 2024-08-27 at 10 37 49 AM" src=""Instead of having a special hover just for the badges I think the main hover accomplishes the goal just fine as the badge and its description shows up at the bottom: <img width="698" alt="Screenshot 2024-08-27 at 10 39 05 AM" src=""
Change:
let disposables: IDisposable[] = []; setup(() => { <ins> TestEditorInputFactory.disableSerialize = false; TestEditorInputFactory.disableDeserialize = false; </ins> disposables.push(Registry.as<IEditorInputFactoryRegistry>(EditorExtensions.EditorInputFactories).registerEditorInputFactory('testEditorInputForGroups', TestEditorInputFactory)); });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --I'm unsure how I got into this state, but I can't close VS Code or reload the window. Stack sohwn when I try to exit:
I cannot explain this, it seems the editor tabs model think there is an editor that does not exist anymore. Needs steps to get any further.
Upon second thought, this can maybe happen if an editor fails to serialize on shutdown. Given we have quite a few new editors, maybe this happens more often now. Marking as candidate to look into and guard against this condition.
Yea, if I recall correctly this happened after I had been playing around with notebooks/custom editors in that window.
if you can try to reproduce, it would still be great to have steps
I have a feeling this could well be notebooks given how the always returns data but the may not. //cc to check if that is a problem. If you know for a fact that you cannot serialize the notebook, please already signal that by returning from the method.
this, I guess we just need to return !(input instanceof NotebookEditorInput)`?
To clarify: it is perfectly valid to return in either of the 2 methods. I pushed a fix to handle this properly on my end. I just wanted to point out that it is always better to return early (from the ) to reduce the data we store in SQLite.
But my that the notebook editor input factory is only called with "my" inputs is valid, right? Or should I assume that it is called with any kind of input and return undefined then?
yeah that assumption is right, you will only be called for inputs you register the factory for.
I don't think anyone has a consistent repro for this, so I will mark it as verified unless I run into it again.
Change:
} else if (browser.isFirefox) { switch (keyCode) { case 59: return KeyCode.Semicolon; <ins> case 60: if (platform.isLinux) { return KeyCode.IntlBackslash; } break; case 61: return KeyCode.Equal; </ins> // based on: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode#numpad_keys case 107: return KeyCode.NumpadAdd; case 109: return KeyCode.NumpadSubtract; <ins> case 173: return KeyCode.Minus; </ins> case 224: if (platform.isMacintosh) { return KeyCode.Meta; } <ins> break; </ins> } } else if (browser.isWebKit) { if (platform.isMacintosh && keyCode === 93) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: latest master OS Version: Windows 11 Home Browser: Firefox 111 Steps to Reproduce: Visual Studio for the web in Firefox at (this is mainly to get VS Code running in Firefox) Ctrl + K, Ctrl + S to open the keyboard shortcuts page. the button to start "Record keys". press "-" key on a US keyboard (2 keys left of Backspace key). that the keyboard shortcut shows "audiovolumemute". I expect "-" to show. press "=" key (1 key left of the Backspace key), see that "unknown" is shown. I expect "=" to show. If running steps 4 and 6 in MS Edge (Chrome the same), then the keys show properly.
Hi , Thanks for filing the issue. We'll have a look. For devs interested: the key troubleshooting (windows 11, macos ventura, ubuntu 22.04 - all same):- bingo! this actually happens only on windows: we convert the "keyCode" incorrectly (173 -112) for minus and (61 -0) for equal, but that doesn't affect mac & linux because they use , which is actually correct, instead of we assign
Change:
}); } <del> private _removeInstances(task: Task) { const recentTaskKey = task.getRecentlyUsedKey() ?? ''; if (this._instances[recentTaskKey]) { this._instances[recentTaskKey].removeInstance(); if (this._instances[recentTaskKey].instances === 0) { delete this._instances[recentTaskKey]; } } </del> <ins> private _getInstances(task: Task): IActiveTerminalData[] { const recentKey = task.getRecentlyUsedKey(); return Object.values(this._activeTasks).filter( (value) => recentKey && recentKey === value.task.getRecentlyUsedKey()); </ins> } private _removeFromActiveTasks(task: Task | string): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.0 and older and (with slightly different behavior) insiders as of 5/4/2023 OS Version: MacOS 13.3.1 (a) Steps to Reproduce: Use these commands to produce and launch a suitable project: First bug: in either 1.78.0 or the nightly, use to launch , then hit Cmd-Shift-B to launch . You end up with two copies of running, when it should have an implicit of 1. Hit Cmd-Shift-B again, and it will tell you you've hit the instance limit. The problem here is that dependent tasks don't count towards the instance limit. Second bug: Now add to , and repeat the above. There is no change in the nightly (as you might expect), but surprisingly 1.78.0 now reports that it can't start a second copy. But thats just a bug; if you change it to and repeat, 1.78.0, still tells you it can't launch a second copy. This bug was fixed by , so I'm just including it for completeness. Third bug: Add to . Now hit Cmd-Shift-B to launch , then use to launch . will (correctly) re-use the already running task, rather than launching a new one. Now kill all the terminals (to make the next step less confusing). Hit Cmd-Shift-B to launch sleeper, wait 5 seconds, and hit Cmd-Shift-B again, wait another 5 seconds for the first task to finish, and then run .

Now, although the second task is still running, starts a new one. The issue here is that when looking for an existing dependent task, uses the task's , which only matches the first instance of a task with greater than 1 (and here, that task has already finished).
Change:
private readonly _proxy: ExtHostDebugServiceShape; private readonly _toDispose = new DisposableStore(); <del> private _breakpointEventsActive: boolean | undefined; </del> private readonly _debugAdapters: Map<number, ExtensionHostDebugAdapter>; private _debugAdaptersHandleCounter = 1; private readonly _debugConfigurationProviders: Map<number, IDebugConfigurationProvider>;

Discussion:
Set some breakpoints Access from an extension- it's an empty array Try again - it's full Seems that we don't sync breakpoint into to the EH until the first call to one of the breakpoint properties do you have some context on this? It's a little confusing because I wouldn't expect sending breakpoint infos to be expensive, and I would expect to be able to access the breakpoints array immediately.
I do not have more context. I believe is the author of this code. I like your suggestion that we change this and actively sync the breakpoints into the EH (since it should not be expensive).
The observed behavior is by design: we want to avoid that all breakpoints get transferred to all active extensions all the time. But the API doc doesn't explain this...
Thanks is the worry that it's too much data/too expensive? What's the solution for extensions that need to access the list of breakpoints?
yes, potentially too much data and traffic for all extensions. What's the solution for extensions that need to access the list of breakpoints? adding a to the function of an extension will register the extension to receive live updates for . With this will always reflect the current set of breakpoints.
Thanks, I don't really understand that though, it doesn't seem like that much traffic/data, compared to something like the full text of open documents. If it's going to work this way, I should document it in But I might try doing some testing to remove this restriction because I think it's unexpected.
Verification steps: Create an extension that can log the value of Set a breakpoint in any file Then trigger your extension to check the length of the breakpoints array It should log the correct value on the first try- previously it would have been 0 on the first access, then the correct value afterwards
Change:
} } <del> class FoldAllRegionsExceptAction extends FoldingAction<void> { </del> <ins> class FoldAllExceptAction extends FoldingAction<void> { </ins> constructor() { super({ id: 'editor.foldAllExcept', <del> label: nls.localize('foldAllExcept.label', "Fold All Regions Except Selected"), alias: 'Fold All Regions Except Selected', </del> <ins> label: nls.localize('foldAllExcept.label', "Fold All Except Selected"), alias: 'Fold All Except Selected', </ins> precondition: CONTEXT_FOLDING_ENABLED, kbOpts: { kbExpr: EditorContextKeys.editorTextFocus,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 OS Version: Win 10 Pro Steps to Reproduce: some code with several regions and code blocks cursor inside a region, press Ctrl+Shift+P and select "Fold all regions except selected" just the other regions are folded but all code blocks.
Yes, it should fold everything, not just regions. I fix the command label.
Change:
const uri = getResourceForCommand(resource, accessor.get(IListService), accessor.get(IEditorService)); if (uri && contextService.isInsideWorkspace(uri)) { <del> const explorerView = viewService.getViewWithId<ExplorerView>(VIEW_ID); </del> <ins> const explorerView = await viewService.openView<ExplorerView>(VIEW_ID, false); </ins> if (explorerView) { const oldAutoReveal = explorerView.autoReveal; // Disable autoreveal before revealing the explorer to prevent a race betwene auto reveal + selection // Fixes #197268 explorerView.autoReveal = false; <del> await viewService.openView<ExplorerView>(VIEW_ID, false); </del> explorerView.setExpanded(true); await explorerService.select(uri, 'force'); explorerView.focus();

Discussion:
add a keybinding for (see below) open a file open debug viewlet trigger the command :bug: nothing happens Try the same with 1.82 and see it working just fine
This doesn't reproduce all the time but when it does it doesn't seem to be a context key issue but the command failing. See how the right command is invoked but how nothing happens
I'm having a hard time reproducing this one. How often do you hit it? It appears your views are in standard locations. Do you have autoReveal on?
No, autoReveal is off. This reproduces rarely but during normal work.
I was able to debug this and it seems that  return . This is because the view container seems undefined (2nd capture) <img width="1510" alt="Screenshot 2023-12-18 at 09 37 25" src=""<img width="1496" alt="Screenshot 2023-12-18 at 09 40 29" src=""
I am also experiencing this bug. It occurs after I do bunch of shortcut that opens sidebar with other views (e.g. search, reference). Once I open file explorer only then it will work again.
Any ideas? Seems like the container itself is defined but the pane container is not. This doesn't really seem like an explorer issue as I'm using the view service for finding which view to reveal. The view service is chosen as the user could place the file view in any container
This is because the explore view pane container is not yet created. Hence it is returned . You should be opening the view instead of getting the view.
Well I get the view because I need to apply some properties to it such as before opening it. Is this not possible and I must just directly call open?
You cannot get the view because it is not yet created.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
import { joinPath } from 'vs/base/common/resources'; import { join } from 'vs/base/common/path'; import { ITunnelApplicationConfig } from 'vs/base/common/product'; <ins> import { isNumber, isObject, isString } from 'vs/base/common/types'; </ins> export const REMOTE_TUNNEL_CATEGORY: ILocalizedString = { original: 'Remote Tunnels',

Discussion:
I switched from a testing profile to my default profile on my Windows machine, and got a message that my macOS machine turned on remote access, even though it's not even on. !
I didn't think of that, good catch. I use settings sync as a communication channel to learn about other machines connecting to a tunnel. I guess I need to add a timestamp as well.