jiebi/CodeConvo huggingface dataset:
Change:
} private static _undoModelUntil(model: ITextModel, targetAltVersion: number): void { <del> while (targetAltVersion < model.getAlternativeVersionId() && model.canUndo()) { </del> <ins> let actualAltVersion = model.getAlternativeVersionId(); while (targetAltVersion < actualAltVersion && model.canUndo()) { </ins> model.undo(); <ins> const newActualAltVersion = model.getAlternativeVersionId(); if (actualAltVersion === newActualAltVersion) { break; } actualAltVersion = newActualAltVersion; </ins> } }

Discussion:
open notebook make inline chat changes select "Discard" the editor will freeze, stuck in an endless loop in
This doesn't reproduce but I had this with insiders and I could see that would return and wouldn't do anything, e.g it would not change the alternative version id. This is notebook specific and the debugger did show me that parts of undo seems to be async. I wonder if this should be exposed in the undo-method that I am calling and that's the cause for this
I did a quick look at the source code in and that looks OK to me. returns . I notice the loop doesn't await the result in case a promise is returned. Could that be the right fix here?
I missed it returning a promise. Might be the right fix here but I also wasn't able reproduce and only debugged this from insiders once.
Change:
resolved "https://registry.yarnpkg.com/nice-try/-/nice-try-1.0.4.tgz#d93962f6c52f2c1558c0fbda6d512819f1efe1c4" integrity sha512-2NpiFHqC87y/zFke0fC0spBXL3bBsoh/p5H1EFhshxjCR5+0g2d6BiXbUFz9v1sAcxsk2htp2eQnNIci2dIYcA== <ins> node-abi@^2.7.0: version "2.19.3" resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-2.19.3.tgz#252f5dcab12dad1b5503b2d27eddd4733930282d" integrity sha512-9xZrlyfvKhWme2EXFKQhZRp1yNWT/uI1luYPr3sFl+H4keYY4xR+1jO7mvTTijIsHf1M+QDe9uWuKeEpLInIlg== dependencies: semver "^5.4.1" </ins> node-addon-api@1.6.2: version "1.6.2" resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-1.6.2.tgz#d8aad9781a5cfc4132cc2fecdbdd982534265217"

Discussion:
Captured by Symbolicated trace:
Crash in keytar module due to missing handlescope in callbacks when reentering javascript thread
Change:
const progressService = accessor.get(IEditorProgressService); const symbolNavService = accessor.get(ISymbolNavigationService); const languageFeaturesService = accessor.get(ILanguageFeaturesService); <ins> const instaService = accessor.get(IInstantiationService); </ins> const model = editor.getModel(); const position = editor.getPosition();

Discussion:
Commit: Datum: 2022-09-01T07:22:41.992Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 +left mouse click on a declaration moves the cursor to the reference if only one exists: https://user- +left mouse click on a declaration moves the cursor opens the reference menue if only multiple references exist: https://user- Commit: Datum: 2022-09-07T05:15:40.689Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 (Also doesnt work on the Desktop Electron App.) https://user- install the versions I listed above or use and you may use this example code : Maybe it has something to do with this:
Do you have configured?
Its the default: "editor.gotoLocation.alternativeDefinitionCommand": "" ! I used and without any account. So no custom settings or extensions. :) If I use another setting like "editor.gotoLocation.alternativeDefinitionCommand": "" it also doesnt work.
Does "Peek References" or "Go to References" work when invoked on that symbol? btw - this works for me using Safari or FF
yes https://user-
are you using with your account, or in a "private" window? ctrl+mouse also doesnt bring up the references popup in other chromium based browsers, like brave nightly or the Desktop version (also tried it in a new profile). ctrl+click on a reference brings me to the definition, so my ctrl key isnt broken :D
The bug is also happening if I choose english as a language and or keyboard layout.
The same thing is happening to me, I'm on insiders Version: 1.72.0-insider Commit: Date: 2022-09-07T05:18:06.866Z (1 day ago) Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Same here
Same here. This is no longer working with the latest VSCode Insider version.

For me it's not working with Dart code. If the usage is in the same file and there is only one, it will not jump there either.
I managed to reproduce with the steps in
Change:
this._processCwd = processCwd; } <ins> private _clearLinkProviders(): void { dispose(this._linkProvidersDisposables); this._linkProvidersDisposables = []; } </ins> private _registerStandardLinkProviders(): void { <del> dispose(this._standardLinkProvidersDisposables); this._standardLinkProvidersDisposables = []; </del> for (const p of this._standardLinkProviders) { <del> this._standardLinkProvidersDisposables.push(this._xterm.registerLinkProvider(p)); </del> <ins> this._linkProvidersDisposables.push(this._xterm.registerLinkProvider(p)); </ins> } } registerExternalLinkProvider(instance: ITerminalInstance, linkProvider: ITerminalExternalLinkProvider): IDisposable { <ins> // Clear and re-register the standard link providers so they are a lower priority that the new one this._clearLinkProviders(); </ins> const wrappedLinkProvider = this._instantiationService.createInstance(TerminalExternalLinkProviderAdapter, this._xterm, instance, linkProvider, this._wrapLinkHandler.bind(this), this._tooltipCallback.bind(this)); const newLinkProvider = this._xterm.registerLinkProvider(wrappedLinkProvider); <del> // Re-register the standard link providers so they are a lower priority that the new one </del> <ins> this._linkProvidersDisposables.push(newLinkProvider); </ins> this._registerStandardLinkProviders(); return newLinkProvider; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.61.0 Commit: Date: 2021-10-07T18:11:58.853Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Steps to Reproduce: the Terminal Sample from the vscode-extension-sample repository the a task that reuses a terminal. For example, I used a user task like: On the first run of the task the 'link' text will create a hover link correctly. If you re-run the task so the terminal has 2 (or more) runs of the task in the same terminal then the link will fail to detect correctly. Adding a breakpoint to there appears to be 1 call per execution of the task in the terminal. I think when the terminal is re-used it re-registers the link provider and if two link providers have overlapping links they both seem to fail (which is a known issue but due to this bug all link providers start failing if tasks are run multiple times).
Putting a breakpoint in the registerLinkProvider call for xterm (here ) I see multiple copies of all of the link providers: <img width="574" alt="Screen Shot 2021-10-12 at 9 15 30 AM" src="https://user-"
Change:
"punctuation.definition.entity" ], "settings": { <del> "foreground": "#AB6526" </del> <ins> "foreground": "#9C5D27" </ins> } }, {

Discussion:
Environment Details: VSCode Version : 1.24.0 OS Version : Win10 Additional Details: MAS Violated : MAS 1.4.3 Tools Used : Color Contrast Analyzer Repro Steps: 1)Navigate to Settings--Select color theme --Select Quiet light. 2)Check color contrast ratio for the Explorer content on the screen. Actual: Color contrast ratio is less than 4.5:1 for the black colored content when focused. Similar issue is observed in following themes: Abyss Kimbie dark Monokai Dimmed High contrast Install additional color theme Expected: Color contrast ratio should be more than 4.5:1 for the content on a screen. Recommendations: Refer below link which is repository of bug fixes code snippets:   User Impact: The low vision/visually impaired users will not be able to view the content properly. MAS Reference: MAS 1.4.3 - {-765f-489c-b18f-}  Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.981 --- <!-- score: 0.924 --- <!-- score: 0.875 --- <!-- score: 0.869 --- <!-- score: 0.867 --<!-- potentialduplicates_comment --
Per our agreement, we will not be fixing color contrast issues with third party themes. cc
just a note that we are the authors of this theme (actually I am the original author) Does this mean that we only fix for the Light+ and Dark+?
we're supposed to fix any issues for themes that we own and ship with out of the box (except for third party themes we don't own). I didn't know we own QuietLight so I'll re-open.
Checked and verified in below version i.e 1.27.0-Insiders. The issue still exist in Quite Light theme. Similar issue is observed in following themes: 1)Solarized light:All the text in the page fail in color contrast ratio i.e 4.5:1 2)Light visual studio: Black coloured text fail in color contrast ratio i.e 4.5:1
please see for the unused variable color issues
Change:
constructor() { super({ id: HideInlineCompletion.ID, <del> label: nls.localize('action.inlineSuggest.acceptNextWord', "Accept Next Word Of Inline Suggestion"), alias: 'Accept Next Word Of Inline Suggestion', </del> <ins> label: nls.localize('action.inlineSuggest.hide', "Hide Inline Suggestion"), alias: 'Hide Inline Suggestion', </ins> precondition: GhostTextController.inlineSuggestionVisible, kbOpts: { weight: 100,

Discussion:
<img width="960" alt="Screenshot 2023-01-31 at 15 55 04" src="https://user-"It looks like the command has the wrong description.
Change:
- script: | set -e <del> npm config set registry "$NPM_REGISTRY" --location=project npm config set always-auth=true --location=project yarn config set registry "$NPM_REGISTRY" condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM & Yarn - task: npmAuthenticate@0 inputs: workingFile: .npmrc condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM Authentication - script: | set -e </del> for i in {1..3}; do # try 3 times yarn --frozen-lockfile --check-files --check-files && break if [ $i -eq 3 ]; then

Discussion:
Build from last Friday was ignored: This started happening since It only happens on full Product builds, since only those run the Alpine jobs, and whenever the nodemodules cache is warm. The reason for this is due to the Pipeline step which always runs .
Change:
switch (tag.name) { case 'example': <ins> // check for caption tags, fix for #79704 const captionTagMatches = tag.text.match('<caption>(.*?)</caption>r'); if (captionTagMatches && captionTagMatches.index === 0) { tag.text = captionTagMatches[1] + 'rr' + tag.text.substr(captionTagMatches[0].length); } </ins> case 'default': // Convert to markdown code block if it is not already one if (tag.text.match(/^s*[~`]{3}/g)) {

Discussion:
Issue Type: <bFeature Request</bI would like support for the element inside a JSdoc block. See here: Currently it displays the element literally, because VScode (blindly) assumes that everything after is javascript/typescript. VS Code version: Code 1.37.1 (, 2019-08-15T16:17:55.855Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
I am interested in picking this issue up
Here's the relevant code:
I made a PR, I thought it made more sense for the code to be under but please let me know if I am wrong
Change:
import { IModeService } from 'vs/editor/common/services/modeService'; import { TestTextResourcePropertiesService } from 'vs/editor/test/common/services/testTextResourcePropertiesService'; import { TestLanguageConfigurationService } from 'vs/editor/test/common/modes/testLanguageConfigurationService'; <ins> import { getDocumentSemanticTokens } from 'vs/editor/common/services/getSemanticTokens'; </ins> const GENERATE_TESTS = false;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This request is to allow semantic tokens to not just pick the first most provider in the list of providers. But instead pick the provider that actually has tokens to return. The use case for this is to support jupyter notebook token colorization. Right now there are at least 2 language servers returning tokens for python notebooks: 1) Python extension has a language server registered for all 'python' files. There's no way to 'exclude' files from a DocumentFilter so it has a piece that excludes all notebook cells. 2) Jupyter extension has one ore more language servers registered for all notebook cells. One or more is because the language server in use can only support one python interpreter at a time, so one language server is created per python interpreter in use for any notebook (multiple interpreters can be in use in one VS code session). When semantic tokens are requested the middleware piece in the juptyer extension will skip sending token requests to if they're not for the appropriate document. This creates a problem with the current implementation because the first registered language server wins. This can randomly be python's (where no tokens are returned) or one of the jupyter one's (where it might return tokens if the interpreter for the document matches). I believe this could all be accomplished by making a compositing token provider in the VS code source. Something like so:
I'm going to try out the composite idea and submit a PR if it works.
Verified it works with a notebook !
hey, uhh, I opened an feature-request about semantic tokens the other day, just right after 4 hours from you.... I was trying to make a SemanticTokensProvider that overrides or works on top of already registered another one.... 't it be better if there could be multiple SemanticTokensProvider to work alongside, maybe override one another by User-Specified priority levels? I was struggling to override some of SemanticTokens that the C/C++ extension provides, but then I found out its not really possible to have multiple running Provider for SemanticTokens....
This is a different use case than what I had envisioned. My use case was there were multiple providers but only one was actually returning anything.

Combining them sounds like an even better way to handle it. It would handle it for my case and your case. I upvoted your request.
Thank you.... 19 More people and I really dont have any idea how to get there tho, haha.
Change:
primaryActions.push(toAction({ id: 'fileWorkingCopy.saveAs', label: localize('saveAs', "Save As..."), <del> run: () => { </del> <ins> run: async () => { </ins> const editor = this.workingCopyEditorService.findEditor(this); if (editor) { <del> this.editorService.save(editor, { saveAs: true, reason: SaveReason.EXPLICIT }); </del> <ins> const result = await this.editorService.save(editor, { saveAs: true, reason: SaveReason.EXPLICIT }); if (!result.success) { this.doHandleSaveError(error); // show error again given the operation failed } </ins> } } }));

Discussion:
Steps: open a GH issues notebook switch to an empty profile make the notebook dirty save it from the error notification pick "Save As..." nothing happens and the toast closes Best fix here is to simply re-show the toast as it was because it gives the correct hint to install the extension. ! //cc
Change:
.monaco-workbench .pane-body.integrated-terminal .split-view-view { box-sizing: border-box; <ins> overflow: hidden; </ins> } /* border-color is set by theme key terminal.border */

Discussion:
Issue Type: <bBug</bRepro a terminal both terminals, run some kind of script that outputs text that horizontally fills the terminal resize the left terminal to make the right one smaller Bug For a half second during the resize, the content of two terminals end up overlapping https://user- VS Code version: Code - Insiders 1.53.0-insider (, 2021-01-26T05:12:23.287Z) OS version: Darwin x64 20.2.0 Remote OS version: Linux x64 5.4.0-1036-azure <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I think this is just a problem with the dom renderer?
Oh yeah, I had set. There's a slight amount of overlap with canvas renderer (specifically the sash border seems to overlap with a few characters of the terminal for a few hundred ms at most), but it is much better
Should probably use on each pane, that should fix.
Change:
move(_source: URI, _target: URI, _overwrite?: boolean): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } copy(_source: URI, _target: URI, _overwrite?: boolean): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } createFile(_resource: URI, _content?: VSBuffer | VSBufferReadable, _options?: ICreateFileOptions): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } <del> createFolder(_resource: URI): Promise<IFileStatWithMetadata> { throw new Error('not implemented'); } </del> <ins> createFolder(_resource: URI): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } </ins> onDidChangeFileSystemProviderRegistrations = Event.None;

Discussion:
It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.
Some background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.
We currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.
I don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both
Verification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.
Thanks for fixing!
Change:
private async doRefresh(elements: ITreeItem[]): Promise<void> { if (this.tree) { this.refreshing = true; <del> await Promise.all(elements.map(element => this.tree.updateChildren(element, true))); elements.map(element => this.tree.rerender(element)); </del> <ins> const parents: Set<ITreeItem> = new Set<ITreeItem>(); elements.forEach(element => { if (element !== this.root) { const parent = this.tree.getParentElement(element); parents.add(parent); } else { parents.add(element); } }); await Promise.all(Array.from(parents.values()).map(element => this.tree.updateChildren(element, true))); </ins> this.refreshing = false; this.updateContentAreas(); if (this.focused) {

Discussion:
Reported here: Nice example:
Sorry didn't get the chance to get this done, pushing it out to September.
Note to self: remember to revert
Change:
"--vscode-editorInlayHint-typeBackground", "--vscode-editorInlayHint-typeForeground", "--vscode-editorLightBulb-foreground", <ins> "--vscode-editorLightBulbAi-foreground", </ins> "--vscode-editorLightBulbAutoFix-foreground", "--vscode-editorLineNumber-activeForeground", "--vscode-editorLineNumber-dimmedForeground",

Discussion:
I like the AI sparkle but I think its color is too strong. IMO it should be less strong and so that it blends away a little more <img width="192" alt="Screenshot 2023-11-29 at 12 46 12" src=""
for help
Hey thanks for writing about this, this is indeed a good point. I can make the opacity lower (set it for example to 0.5). With such an opacity, the icon looks as follows: ! ! What do you think ?
Looks like an improvement
Change:
Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfiguration({ ...workbenchConfigurationNodeBase, 'properties': { <ins> 'workbench.experimental.editSessions.autoStore': { enum: ['onShutdown', 'off'], enumDescriptions: [ localize('autoStore.onShutdown', "Automatically store current edit session on window close."), localize('autoStore.off', "Never attempt to automatically store an edit session.") ], 'type': 'string', 'tags': ['experimental', 'usesOnlineServices'], 'default': 'off', 'markdownDescription': localize('autoStore', "Controls whether to automatically store an available edit session for the current workspace."), }, </ins> 'workbench.experimental.editSessions.enabled': { 'type': 'boolean', 'tags': ['experimental', 'usesOnlineServices'],

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.
On , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.
Change:
private readonly _languageId: string; private _electricChars: { [key: string]: boolean } | null; <del> public readonly cursorStyle: TextEditorCursorStyle; public get cursorStyleKind(): 'beforeCharacter' | 'onCharacter' { switch (this.cursorStyle) { case TextEditorCursorStyle.Line: case TextEditorCursorStyle.LineThin: return 'beforeCharacter'; case TextEditorCursorStyle.Block: case TextEditorCursorStyle.Underline: case TextEditorCursorStyle.BlockOutline: case TextEditorCursorStyle.UnderlineThin: return 'onCharacter'; } } </del> public static shouldRecreate(e: ConfigurationChangedEvent): boolean { return (

Discussion:
Using copilot completions in the latest VS Code insiders, I see the cursor being pushed to after the suggested text. This makes it very difficult to work with the text while passive completions are suggested. <img width="1126" alt="image" src=""
FYI I didn't think of this.
is it possible to differentiate between an inline completion and inlay hint in the editor? maybe we could have different behavior in different cases?