jiebi/CodeConvo huggingface dataset:
Change:
return Promise.resolve(null); } const current = potentialPaths.shift(); <ins> if (current! === '') { return this._validateShellPaths(label, potentialPaths); } </ins> return this._fileService.exists(URI.file(current!)).then(exists => { if (!exists) { return this._validateShellPaths(label, potentialPaths);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.34.0 OS Version: WindowsNT x64 10.0. I found this issue when I was trying to function in does not work properly when an array include an empty string at the beginning is sent to function. the below to in . ` the Launch VS Code launch configuration from the launch dropdown in the Debug viewlet and press F5. . . Choose Choose an empty string ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I guess we can just special case and not do the file check to catch accidental errors? Code pointer:
I have an idea. It is to add this code between the below into .
, you want to send a PR for this or can I handle this ?
PR for this issue is created by Sorry, I think that I entrust him. I do not know how to best deal with this situation.
, sent the PR after the comment and while I was waiting for your confirmation and maybe to suggest the best approach.
I wrote it here because I was afraid that my suggestion is wrong. My answer to your question is "Of course! You can handle this.".
I just found the first 'good first issue' and submitted a PR. As it was too small, I won't mind even if it gets rejected or be replaced by your PR. Cheers.
, There is nothing wrong in that but it is good to let others know that you are working on the issue. I will leave this PR to you and close my PR :) , i guess your approach is good but i will leave to take the final decision :)
Change:
import { ActivityAction, ActivityActionViewItem, IActivityActionViewItemOptions, IActivityHoverOptions, ICompositeBar, ICompositeBarColors, ToggleCompositePinnedAction } from 'vs/workbench/browser/parts/compositeBarActions'; import { CATEGORIES } from 'vs/workbench/common/actions'; import { IActivity } from 'vs/workbench/common/activity'; <del> import { ACTIVITY_BAR_FOREGROUND, ACTIVITY_BAR_ACTIVE_BORDER, ACTIVITY_BAR_ACTIVE_FOCUS_BORDER, ACTIVITY_BAR_ACTIVE_BACKGROUND, ACTIVITY_BAR_SETTINGS_PROFILE_HOVER_FOREGROUND } from 'vs/workbench/common/theme'; </del> <ins> import { ACTIVITY_BAR_FOREGROUND, ACTIVITY_BAR_ACTIVE_BORDER, ACTIVITY_BAR_ACTIVE_FOCUS_BORDER, ACTIVITY_BAR_ACTIVE_BACKGROUND, ACTIVITY_BAR_SETTINGS_PROFILE_BACKGROUND, ACTIVITY_BAR_SETTINGS_PROFILE_HOVER_FOREGROUND } from 'vs/workbench/common/theme'; </ins> import { IWorkbenchLayoutService, Parts } from 'vs/workbench/services/layout/browser/layoutService'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem';

Discussion:
The original designs had something closer to this for the default background color. IMO it isn't trying to be an icon like the other items and the border makes it feel like an icon vs. a unique element. I also think the background and foreground should be the only customizable elements to start. I think I saw a foreground token, but not sure it was possible to do background yet. <img width="247" alt="CleanShot 2022-09-26 at 16 29 09 src="https://user-"
I also like this more over the border For example here this looks not too different from the actions above even though it is about profiles: <img width="297" alt="image" src="https://user-"
!
I like it but maybe with smaller font size? Here is with for example: !
Current font size goes well with all (emoji, codicons) and also symmetric with activity bar icons.
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.49: version "4.19.0-beta.49" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.49.tgz#8e4178620be9a9dee25a586ef992a6fc621a829a" integrity sha512-uRnHpR2pv1MJPbE3sa7XbP6x0uHubAWVMbiD26e3a5ICtWJQVVpLojkA0t4qU7CoMX85pRL1rIclg9CKY0B0xA== xterm@4.19.0-beta.49: version "4.19.0-beta.49" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.49.tgz#96d0d748c97a2f0cfa4c6112bc4de8b0d5d559fe" integrity sha512-qPhOeGtnB357mZOvfDckVlPDR7EDkSASQrB3aujhjgJlOiBBqcNRJcuSvF7v1DOho7xdEI9UQxiSiT5diHhMlg== </del> <ins> xterm-headless@4.19.0-beta.52: version "4.19.0-beta.52" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.52.tgz#87298cb205694cfdd701a9a96dcd06434a9773fe" integrity sha512-9s8VtGa9JUdEWxrNDJpEng2mEFn0KjWM3R9nxezA8mXHsJ/0cMqoK00s/fzhAEXZqHycWASSECMWgFOaT0MrnQ== xterm@4.19.0-beta.52: version "4.19.0-beta.52" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.52.tgz#21c7ad0bd905f3fddaa0583951514c8271dcd822" integrity sha512-2itY6dyiimOEkgVwc31TngYQ6npHt7or1wxU0Flbv4PjH4ke8K26NDB7KAi0YYkn2g0/qzIjQc7ykdrrTaEgMg== </ins> yallist@^4.0.0: version "4.0.0"

Discussion:
Issue Type: <bBug</bIn the regular MacOS terminal (outside Visual Studio Code), option+click will move the cursor to a given point in the text. This is nice for editing the middle of a long command line, or for moving around vim. However, when the MacOS Terminal is being run inside Visual Studio Code, when I option+click text, the cursor moves close to where I clicked, but it's off by about 3 characters. VS Code version: Code 1.63.2 (, 2021-12-15T09:38:17.605Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No Remote OS version: Linux x64 5.4.0-105-generic <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ remote-ssh0.70.0 python2022.4.1 vscode-pylance2022.4.2 references-view0.0.89 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Guessing this is related to padding on
Does not reproduce in the demo
VS Code uses padding but the demo doesn't, try adding to
shouldn't the padding be on the cursor layer? nvm made the change in the wrong
I think this rule is the problem but haven't looked into it: ! We recently moved the padding from to I think which would explain the regression
Change:
$completions = TabExpansion2 -inputScript $completionPrefix -cursorColumn $cursorIndex if ($null -ne $completions.CompletionMatches) { $result += ";$($completions.ReplacementIndex);$($completions.ReplacementLength);$($cursorIndex);" <del> $result += $completions.CompletionMatches | ConvertTo-Json -Compress </del> <ins> if ($completions.CompletionMatches.Count -gt 0 -and $completions.CompletionMatches.Where({ $_.ResultType -eq 3 -or $_.ResultType -eq 4 })) { $json = [System.Collections.ArrayList]@($completions.CompletionMatches) # Add . and .. to the completions list $json.Add([System.Management.Automation.CompletionResult]::new( '.', '.', [System.Management.Automation.CompletionResultType]::ProviderContainer, (Get-Location).Path) ) $json.Add([System.Management.Automation.CompletionResult]::new( '..', '..', [System.Management.Automation.CompletionResultType]::ProviderContainer, (Split-Path (Get-Location) -Parent)) ) $result += $json | ConvertTo-Json -Compress } else { $result += $completions.CompletionMatches | ConvertTo-Json -Compress } </ins> } } # If there is no space, get completions using CompletionCompleters as it gives us more

Discussion:
Steps to Reproduce: and press :bug: intellisense completion was for the argument instead of running the command I have a pretty strong muscle memory to run that command, so now I need to remember to press escape before pressing enter !
this is bad enough that I've turned the feature off, I can't even use
I also hit these issues particularly with : ! !
one change that would make this much less painful: ctrl+z should undo the auto-complete change as a single action (as is the case with the text editor). I press enter really quickly, after typing what I want, and if auto-complete provides something I didn't want, ctrl+z will undo one character at a time.
Well powershell does support ctrl+z itself. We may be able to undo everything, or nearly everything by using bracketed paste mode, since you can paste something and undo it fine.
Just tried with Posh-Git and while the commands () and aliases ( in mine) work, it still doesn't suggest after checkout: <img width="859" alt="Screenshot 2024-06-14 at 9 56 45 AM" src=""
doesn't show files/folders so we couldn't use that. Maybe using the current completion call, but also providing , , etc. when there are only and entries?
Looks promising <img width="861" alt="Screenshot 2024-06-14 at 10 11 11 AM" src=""
Change:
public static readonly chatResponseReceived2 = Sound.register({ fileName: 'chatResponseReceived2.mp3' }); public static readonly chatResponseReceived3 = Sound.register({ fileName: 'chatResponseReceived3.mp3' }); public static readonly chatResponseReceived4 = Sound.register({ fileName: 'chatResponseReceived4.mp3' }); <del> public static readonly chatResponseReceived5 = Sound.register({ fileName: 'chatResponseReceived5.mp3' }); </del> private constructor(public readonly fileName: string) { } }

Discussion:
cc Now that we have audio cues for the chat experience, all of which are off by default, we should think about what the best experience would be for most SR users and proceed with that once the final audio cues have been provided.
My choice here would be to only enable audioCues.chatResponsePending since it is the only one that provides information that is not redundant, however, this is an area in which I believe user research would be beneficial. for example, do people feel like these audio cues complement the screen reader feedback? are they distracting? Wen the chat is done generating the answer, do they prefer to receive screen reader feedback, the audio cue or both?
Yeah, that was my feeling as well Having all off by default would decrease discoverability, so I'm in favor of setting just that one to true until we have data that suggests otherwise
Just wanted to rule out any ambiguity here, does "audioCues.chatResponsePending" = the "progress" or "response" sound?
I believe he means progress because the response sound is redundant since the response gets read by the screen reader
Change:
version "1.0.0" resolved "https://registry.yarnpkg.com/sparkles/-/sparkles-1.0.0.tgz#1acbbfb592436d10bbe8f785b7cc6f82815012c3" <del> spdlog@0.6.0: version "0.6.0" resolved "https://registry.yarnpkg.com/spdlog/-/spdlog-0.6.0.tgz#20632ed4f1558ffa46e8a5827a5e97c61e0fa9ed" </del> <ins> spdlog@0.7.1: version "0.7.1" resolved "https://registry.yarnpkg.com/spdlog/-/spdlog-0.7.1.tgz#960b8cdced12e8c482d1df9fa65220789f276979" </ins> dependencies: bindings "^1.3.0" mkdirp "^0.5.1"

Discussion:
Steps to Reproduce: reproduces out of sources and open just one window to date settings and go back in time 1 month =this takes 10-20s on my system. When I comment out in the as well as I can no longer reproduce. !
Investigating. Just by changing the month back, the CPU goes crazy: !
We're hitting this all the time, since is negative in this case! So CPU just spins.
wow
Moving to March due to high risk change, and given that no users seem to hit this often. Sorry for taking so long to look at this.
Snowplowed once again...
This mechanism seems to have changed in spdlog 0.17.0. Will create a new build based on that and test.
Yep, that version of spdlog fixes it! :fireworks: Lets just hope it doesn't break other things. :seenoevil:
This can't be reproduced on managed computers as we aren't allowed to change the date. can you change your date?
Never mind, there's a different UI for date changing which isn't blocked.
Change:
* View used for searching outdated extensions */ viewDescriptors.push({ <del> id: 'workbench.views.extensions.searchOutdated', </del> <ins> id: OUTDATED_EXTENSIONS_VIEW_ID, </ins> name: localize('availableUpdates', "Available Updates"), ctorDescriptor: new SyncDescriptor(OutdatedExtensionsView, [{}]), when: ContextKeyExpr.or(SearchExtensionUpdatesContext, ContextKeyExpr.has('searchOutdatedExtensions')),

Discussion:
Testing Maybe a button to the right of the view header: !
Lets have action in the view header like below <img width="341" alt="image" src="https://user-"
Change:
this.renderContentReferencesIfNeeded(element, templateData, templateData.elementDisposables); let fileTreeIndex = 0; <ins> let codeBlockIndex = 0; </ins> value.forEach((data, index) => { const result = data.kind === 'treeData' ? this.renderTreeData(data.treeData, element, templateData, fileTreeIndex++) : data.kind === 'markdownContent' <del> ? this.renderMarkdown(data.content, element, templateData, fillInIncompleteTokens) </del> <ins> ? this.renderMarkdown(data.content, element, templateData, fillInIncompleteTokens, codeBlockIndex) </ins> : data.kind === 'progressMessage' && onlyProgressMessagesAfterI(value, index) ? this.renderProgressMessage(data, false) // TODO render command : data.kind === 'progressTask' ? this.renderProgressTask(data, false, element, templateData) : data.kind === 'command' ? this.renderCommandButton(element, data)

Discussion:
Steps to Reproduce: multiple markdown strings with code blocks interleaved with commands/warnings. (see sample chat extension ) progressive streaming of chat content. The markdown code blocks at the beginning of the stream are replaced with the last streamed code block content. See below gif: !
Change:
export function getMediaMime(path: string): string | undefined { const ext = paths.extname(path); return mapExtToMediaMimes[ext.toLowerCase()]; <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
VSCode Version: 1.26.1 My extension provides syntax highlighting for the following files: <img width="147" alt="screen shot 2018-08-29 at 19 48 37" src="https://user-"When saving a new "Todo" file this will be the suggested name: <img width="368" alt="screen shot 2018-08-29 at 19 47 53" src="https://user-"Which doesn't really make sense, IMHO it should work like this: the first extension that starts with a dot, and suggest no extension starts with a dot pick the first one and suggest instead of
I would accept a reasonably small PR to fix this.
Change:
private _getActionFor(editor: ICodeEditor, action: HoverVerbosityAction): IAction { let actionId: string; let accessibleActionId: string; <del> let actionLabel: string; </del> let actionCodicon: ThemeIcon; switch (action) { case HoverVerbosityAction.Increase: actionId = INCREASE_HOVER_VERBOSITY_ACTION_ID; accessibleActionId = INCREASE_HOVER_VERBOSITY_ACCESSIBLE_ACTION_ID; <del> actionLabel = INCREASE_HOVER_VERBOSITY_ACTION_LABEL; </del> actionCodicon = Codicon.add; break; case HoverVerbosityAction.Decrease: actionId = DECREASE_HOVER_VERBOSITY_ACTION_ID; accessibleActionId = DECREASE_HOVER_VERBOSITY_ACCESSIBLE_ACTION_ID; <del> actionLabel = DECREASE_HOVER_VERBOSITY_ACTION_LABEL; </del> actionCodicon = Codicon.remove; break; } <ins> const actionLabel = labelForHoverVerbosityAction(this._keybindingService, action); </ins> const actionEnabled = this._hoverController.doesMarkdownHoverAtIndexSupportVerbosityAction(this._markdownHoverFocusedIndex, action); return new Action(accessibleActionId, actionLabel, ThemeIcon.asClassName(actionCodicon), actionEnabled, () => { editor.getAction(actionId)?.run({ index: this._markdownHoverFocusedIndex, focus: false });

Discussion:
Testing the keybinding for verbosity hover over =Shows the keybinding accessibility view of the hover focus to the by clicking A hover for the action shows without the keybinding !
Change:
}); <del> export async function getModifiedRanges(accessor: ServicesAccessor, modified: ITextModel): Promise<Range[] | undefined> { </del> <ins> export async function getModifiedRanges(accessor: ServicesAccessor, modified: ITextModel): Promise<Range[] | undefined | null> { </ins> const scmService = accessor.get(ISCMService); const workerService = accessor.get(IEditorWorkerService); const modelService = accessor.get(ITextModelService); const original = await getOriginalResource(scmService, modified.uri); if (!original) { <del> return undefined; </del> <ins> return null; // let undefined signify no changes, null represents no source control (there's probably a better way, but I can't think of one rn) </ins> } const ranges: Range[] = [];

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --It would be nice to have either a toggle or a third option (or even just have this as default behavior for "modifications" mode of format on save) that tells VS Code to format the entire file on save if version control is unavailable. I find it annoying to have to configure every new repository workspace I make to use modifications instead of my User setting of file. Perhaps there is already an extension for this that I've not found yet. Either way, code for thought.
Actually, I've had a look into the code-base and it looks fairly easy to do, so I'll add the third option approach myself and create a PR. Up to you legends what you do with it tho
Change:
} }; <ins> for (const breakpoint of this.model.getBreakpoints({ triggeredOnly: true })) { breakpoint.setSessionDidTrigger(session.getId(), false); } </ins> // For debug sessions spawned by test runs, cancel the test run and stop // the session, then start the test run again; tests have no notion of restarts. if (session.correlatedTestRun) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.93.1 OS Version: Windows 11 Pro Originally from To Reproduce Steps to reproduce the behavior: an empty dart project (can be any language, this is just the one I use of course) the code below breakpoints on both and print calls the breakpoint on the trigger only after the one at (screenshot) the code and make sure the breakpoint stops the program that triggers before Expected behavior For the triggered breakpoint to wait again on restart. Also note that there are two ways to restart a debug session too - a full restart handled by VS Code (which is what happens for Dart above), and a restart that is delegated to the debug adapter (which we use for Flutter to do Hot Restart, so it's faster than a cold restart by VS Code). In both cases, this state should be reset. Screenshots ! <details<summaryRelevant debugging log part </summary</details// CC:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Interestingly, I cannot reproduce this with JavaScript using an equivalent file: Unfortunately I don't think it uses DAP and I don't know if there's a way to get a log of what's happening there. It's not clear to me how it could be working there given the DAP traffic captured for Dart. Someone familiar with the implementation of Triggered Breakpoints or the JS debugger might be able to explain what's going on.

I can on python:
I am also running into this issue
This is probably because the JS debugger has each debugee as its own, child session, and when restarting JS you will retain the parent session (handled by the DA) but get a new child session that doesn't have the data set.
I am debugging Go. I don't remember seeing it with other languages but I also only rarely run anything other than Go.
yea, it's reproducable with Python too. Fixed in Monday's Insiders.
Change:
break; } case 'tokenizedStylesChanged': { <del> if (tokenizationStyleElement) { tokenizationStyleElement.textContent = event.data.css; } </del> <ins> tokenizationStyle.replaceSync(event.data.css); </ins> break; } case 'find': {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.79.1 Jupyter Extension version: 2023.5. Python Extension version: 2023.10.1 OS and version: Windows 11 Home Version 22H2, build .1778 If I change the theme after entering code in a Markdown cell, the code highlighting should change accordingly. Light theme: <img width="51" alt="image" src=""Dark theme: <img width="52" alt="image" src=""The code highlighting in Markdown cells does not change according to the theme. Light theme: <img width="44" alt="image" src=""Dark theme: <img width="48" alt="image" src=""an .ipynb file. a Markdown cell. some text formatted as code, e.g. python a = 5 ` Shift + Enter to render cell. theme (for example, if code was entered when using Light Modern, switch to Dark Modern). The code highlighting in the Markdown cell does not change and is now difficult to read.
Change:
super({ id: 'workbench.action.decreaseViewSize', title: { value: localize('decreaseViewSize', "Decrease Current View Size"), original: 'Decrease Current View Size' }, <del> f1: true </del> <ins> f1: true, precondition: IsAuxiliaryWindowFocusedContext.toNegated() </ins> }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 x64 OS Version: Steps to Reproduce: a new floating window with (or any of the other ones) a few split editors in the main view and the floating view a split in floating window the floating view, execute floating window editor size doesn't change, it happens in the main one
Good catch, these commands should not be available in floating windows.