jiebi/CodeConvo huggingface dataset:
Change:
setting.key === 'search.exclude'; } <ins> function settingTypeEnumRenderable(_type: string | string[]) { const enumRenderableSettingTypes = ['string', 'boolean', 'null', 'integer', 'number']; let type = isArray(_type) ? _type : [_type]; return type.every(type => enumRenderableSettingTypes.indexOf(type) > -1); } </ins> export enum SearchResultIdx { Local = 0, Remote = 1,

Discussion:
: Check whether it's ok to map to : Add 'null' or "None" item to enum : =- : ?? I don't see this in vscode's core settings Also, . Example:
These are the settings explicitly that I could find with a simple search. Of these, the HTML ones are the only concern. For most of them we should probably just get rid of accepting null, as it doesn't make a ton of sense to have just mean either default or some secondary default. But has very different behavior between and so we'll have to decide on something to do there.
[ ] : fix requires API discussion over adding an additional schema parameter [x] : fixes [x] : fixed [ ] : Probably wont fix? Would require some new components and UI/UX discussion. [x] : fixes
can you add some steps for how to verify?
Here are some settings with compound types - Test that they work as you'd expect. I can't remember which extension has the nullable enum but you can test it with a contribution like
seems to work for the first one, but not second. e.g. here I cannot type "null": ! I can only type numbers (I am on Windows).
For the null|number type, an empty input box will correspond to in the json
Change:
"https-proxy-agent": "^2.2.3", "iconv-lite-umd": "0.6.8", "jschardet": "2.2.1", <del> "keytar": "^7.1.0", </del> <ins> "keytar": "7.2.0", </ins> "minimist": "^1.2.5", "native-is-elevated": "0.4.1", "native-keymap": "2.2.1",

Discussion:
Captured by Symbolicated trace:
Crash in keytar module due to missing handlescope in callbacks when reentering javascript thread
Change:
import { NOTEBOOK_CELL_EXECUTING, NOTEBOOK_CELL_EXECUTION_STATE, NOTEBOOK_CELL_LIST_FOCUSED, NOTEBOOK_CELL_TYPE, NOTEBOOK_HAS_RUNNING_CELL, NOTEBOOK_INTERRUPTIBLE_KERNEL, NOTEBOOK_IS_ACTIVE_EDITOR, NOTEBOOK_KERNEL_COUNT, NOTEBOOK_KERNEL_SOURCE_COUNT, NOTEBOOK_LAST_CELL_FAILED, NOTEBOOK_MISSING_KERNEL_EXTENSION } from 'vs/workbench/contrib/notebook/common/notebookContextKeys'; import { CellEditState, CellFocusMode, EXECUTE_CELL_COMMAND_ID } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; import * as icons from 'vs/workbench/contrib/notebook/browser/notebookIcons'; <del> import { CellKind, NotebookSetting } from 'vs/workbench/contrib/notebook/common/notebookCommon'; </del> <ins> import { CellKind, CellUri, NotebookSetting } from 'vs/workbench/contrib/notebook/common/notebookCommon'; </ins> import { NotebookEditorInput } from 'vs/workbench/contrib/notebook/common/notebookEditorInput'; import { INotebookExecutionStateService } from 'vs/workbench/contrib/notebook/common/notebookExecutionStateService'; import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { Schemas } from 'vs/base/common/network'; <ins> import { IDebugService } from 'vs/workbench/contrib/debug/common/debug'; </ins> const EXECUTE_NOTEBOOK_COMMAND_ID = 'notebook.execute'; const CANCEL_NOTEBOOK_COMMAND_ID = 'notebook.cancelExecution';

Discussion:
It's easy to lose track of the debugged cell in notebooks, especially when you've stepped into a cell which is different from the cell that is "running". Some improvements we could make: The "Go To" button should go to the cell at the top of the callstack, not the cell where the user clicked Run We should show overview ruler decorations for the top stackframe, as in the editor And overview ruler decorations for the currently running cell And for breakpoints (behind a setting, ) cc
To verify, just try everything listed at the top. For I mean, have two cells, like and a second cell that calls . Set a breakpoint in the function definition, click run on the second cell, and make sure "Go To" goes to that first cell where the instruction pointer is.
Change:
constructor(private service: ILaunchService) { } call(command: string, arg: any): TPromise<any> { <del> const { args, userEnv } = arg as IStartArguments; </del> switch (command) { <del> case 'start': return this.service.start(args, userEnv); </del> <ins> case 'start': const { args, userEnv } = arg as IStartArguments; return this.service.start(args, userEnv); case 'get-main-process-id': return this.service.getMainProcessId(); </ins> } } }

Discussion:
This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Pushed a workaround.
Reopening, using the () workaround causes issues as it will undock windows it seems.
This happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.
As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Just tried the suggested workaround and it did not work. Using Windows 10 Home
I've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?
Seems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build
Must have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.
I started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build
Update: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.
This is happening to me also since the previous 2 releases. Changing the value of did not help
Change:
<ins> function Create-TmpJson($Obj) { $FileName = [System.IO.Path]::GetTempFileName() ConvertTo-Json -Depth 100 $Obj | Out-File -Encoding UTF8 $FileName return $FileName } $Auth = Create-TmpJson @{ Version = "1.0.0" AuthenticationType = "AAD_CERT" ClientId = $env:ESRPClientId AuthCert = @{ SubjectName = $env:ESRPAuthCertificateSubjectName StoreLocation = "LocalMachine" StoreName = "My" } RequestSigningCert = @{ SubjectName = $env:ESRPCertificateSubjectName StoreLocation = "LocalMachine" StoreName = "My" } } $Policy = Create-TmpJson @{ Version = "1.0.0" } $Input = Create-TmpJson @{ Version = "1.0.0" SignBatches = @( @{ SourceLocationType = "UNC" SignRequestFiles = @( @{ SourceLocation = $args[0] } ) SigningInfo = @{ Operations = @( @{ KeyCode = "CP-229803" OperationCode = "SigntoolSign" Parameters = @{ OpusName = "VS Code" OpusInfo = "https://code.visualstudio.com/" PageHash = "/NPH" TimeStamp = "/t `"http://ts4096.gtm.microsoft.com/TSS/AuthenticodeTS`"" } ToolName = "sign" ToolVersion = "1.0" }, @{ KeyCode = "CP-230012" OperationCode = "SigntoolSign" Parameters = @{ OpusName = "VS Code" OpusInfo = "https://code.visualstudio.com/" Append = "/as" FileDigest = "/fd `"SHA256`"" PageHash = "/NPH" TimeStamp = "/tr `"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer`" /td sha256" } ToolName = "sign" ToolVersion = "1.0" }, @{ KeyCode = "CP-230012" OperationCode = "SigntoolVerify" Parameters = @{ VerifyAll = "/all" } ToolName = "sign" ToolVersion = "1.0" } ) } } ) } $Output = [System.IO.Path]::GetTempFileName() $ScriptPath = Split-Path -Path $MyInvocation.MyCommand.Definition -Parent & "$ScriptPathESRPClientpackagesEsrpClient.1.0.27toolsESRPClient.exe" Sign -a $Auth -p $Policy -i $Input -o $Output </ins>  No newline at end of file

Discussion:
is from an unknown publisher
!
Oh it really seems like you can't uninstall it... Not good.
Related to

Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.
To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!
Change:
announcement = announcement ? 'auto' : 'off'; } } <ins> configurationKeyValuePairs.push([`${item.legacySoundSettingsKey}`, { value: undefined }]); </ins> configurationKeyValuePairs.push([`${item.settingsKey}`, { value: announcement !== undefined ? { announcement, sound } : { sound } }]); return configurationKeyValuePairs; }

Discussion:
have the -setting open settings editor and notice a warning It seems that we are missing a settings migration. That's something we usually do when "breaking" a setting. <img width="715" alt="Screenshot 2024-02-22 at 11 30 06" src=""
This was by design this iteration to be overly cautious with the migration with plans to do that next iteration Now that it's been tested via a TPI, I think it's safe to do this. cc who also requested this during testing.
Verifier: Pls add a bunch of alert and audio cue settings such as: in various orders and combinations. Verify that they're transformed into settings and the deprecated settings are all removed.
It looks like I have to reload the window for the User settings to be migrated. Is that behaviour expected?
Yes because that will happen automatically for users when they download the vs code update
Change:
return this._onDidChange.event; } <ins> private readonly _onDidStatsChange: Emitter<void> = new Emitter<void>(); get onDidStatsChange(): Event<void> { return this._onDidStatsChange.event; } </ins> private _filterText = ''; <ins> private _stats = { total: 0, filtered: 0 }; </ins> get filterText(): string { return this._filterText; } <ins> get filterStats(): { total: number, filtered: number } { return this._stats; } set filterStats(stats: { total: number, filtered: number }) { const { total, filtered } = stats; if (this._stats.total !== total || this._stats.filtered !== filtered) { this._stats = { total, filtered }; this._onDidStatsChange.fire(); } } </ins> set filterText(filterText: string) { if (this._filterText !== filterText) { this._filterText = filterText;

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
return []; } <ins> // Not a branch (tag, detached) if (this.state.HEAD?.type === RefType.Tag || !this.state.HEAD?.name) { return []; } </ins> // Commit const commandGroups: Command[][] = []; for (const commands of this.postCommitCommandCenter.getSecondaryCommands()) {

Discussion:
Testing a specific commit, not a branch, to go to a detached state Notice the SCM button still lets you (among others). None of the "sync" actions make sense in detached state. One can only commit. And an idea for a default button when there are no changes: . <img width="506" alt="image" src=""
Created to track the action button.
Change:
this.disposables.value!.add(attachButtonStyler(this.button, this.themeService)); } <ins> focus(): void { this.button?.focus(); } </ins> private clear(): void { this.disposables.value = new DisposableStore(); this.button = undefined;

Discussion:
This should not be a valid state: ! It should automatically switch to this: ! is how the SCM Input does it.
I am seeing this state when I am navigating using up/down buttons. Is it expected? ! !
That is probably unexpected, but I will let confirm that.
Yeah, just like the text box. The list doesn't support completely disabling it at the model layer. We can only disable it at the click operation.
Change:
const showNonConflictingChanges = viewModel.showNonConflictingChanges.read(reader); const showDeletionMarkers = this.showDeletionMarkers.read(reader); <ins> const diffWithThis = viewModel.baseCodeEditorView.read(reader) !== undefined && viewModel.baseShowDiffAgainst.read(reader) === this.inputNumber; const useSimplifiedDecorations = !diffWithThis && this.useSimplifiedDecorations.read(reader); </ins> for (const modifiedBaseRange of model.modifiedBaseRanges.read(reader)) { const range = modifiedBaseRange.getInputRange(this.inputNumber);

Discussion:
Note all three lines highlighted with background color <img width="262" alt="CleanShot 2022-09-08 at 16 01 57 src="https://user-"We only highlight the changed line and specific word. <img width="184" alt="CleanShot 2022-09-08 at 16 02 04 src="https://user-"If we followed the inline style and still rendered a word diff, wouldn't we be able to get away without using the borders to indicate the region? cc
The inline style does this because it has no clue about the actual conflict, it just sees the conflict markers. We do this to show the actual change in that side.
I a hidden setting (default false) so we can play with idea. Personally, I think it hides many important decorations, but I'm open to exploring it. Enabled: ! Disabled: ! The background color disappears when the conflict is handled.
Change:
<ins> Param( [string]$AuthCertificateBase64, [string]$AuthCertificateKey ) # Import auth certificate $AuthCertificateFileName = [System.IO.Path]::GetTempFileName() $AuthCertificateBytes = [Convert]::FromBase64String($AuthCertificateBase64) [IO.File]::WriteAllBytes($AuthCertificateFileName, $AuthCertificateBytes) $AuthCertificate = Import-PfxCertificate -FilePath $AuthCertificateFileName -CertStoreLocation Cert:LocalMachineMy -Password (ConvertTo-SecureString $AuthCertificateKey -AsPlainText -Force) rm $AuthCertificateFileName $ESRPAuthCertificateSubjectName = $AuthCertificate.Subject Write-Output ("##vso[task.setvariable variable=ESRPAuthCertificateSubjectName;]$ESRPAuthCertificateSubjectName") </ins>  No newline at end of file

Discussion:
is from an unknown publisher
!
Oh it really seems like you can't uninstall it... Not good.
Related to

Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.
To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!
Change:
} else { if (this.paneItems.length === 1) { this.paneItems[0].pane.headerVisible = true; <del> this.paneItems[0].pane.setExpanded(true); </del> <ins> if (this.paneItems[0].pane === this.lastMergedCollapsedPane) { this.paneItems[0].pane.setExpanded(false); } </ins> this.paneItems[0].pane.collapsible = false; } else { this.paneItems.forEach(i => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.84.0 (user setup) Commit: Date: 2023-11-01T11:29:04.398Z Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: VS Code (with an open folder) explorer view if not already visible view will be visible/expanded the Timeline view and relaunch VS Code view is visible/expanded again (expected behavior: it shall remain collapsed)
After a few days of working with it, I find this thing extremely annoying and it has almost become something I despise !
Very annoying!
Same issue
For now I just hide the Timeline completely from the Explorer view (right click on the Timeline bar and de-select it from the menu): !
Related on r/vscode:
I think this was caused by , specifically this code: I can repro it reliably if I first move the Outline view out of the Explorer view container, for example by dragging it onto the Secondary Side Bar. Here's what I see happening. startup the Timeline view initially gets alone to the empty Explorer view container, causing the code above to expand it (and also set it non-collapsible). soon after, the Explorer view (and maybe the Open Editors view) get . Now there's more that one view in the container, so the else-block immediately after the fragment shown above sets them all collapsible, but Timeline remains expanded. pinging
I have submitted a PR.
Related on Stack Overflow:
Change:
this.disposables.add(addDisposableListener(this.domNode, 'dragover', e => this.onDragOver(this.toDragEvent(e)))); this.disposables.add(addDisposableListener(this.domNode, 'drop', e => this.onDrop(this.toDragEvent(e)))); <del> this.disposables.add(addDisposableListener(this.domNode, 'dragleave', _ => this.onDragLeave())); </del> <ins> this.disposables.add(addDisposableListener(this.domNode, 'dragleave', e => this.onDragLeave(this.toDragEvent(e)))); </ins> this.disposables.add(addDisposableListener(this.domNode, 'dragend', e => this.onDragEnd(e))); this.setRowLineHeight = getOrDefault(options, o => o.setRowLineHeight, DefaultOptions.setRowLineHeight);

Discussion:
Repro: 2 terminals dragging one it into the actual terminal and pass over the other tab briefly, it will get focused even though the mouse didn't stay there for long enough !
Change:
} .monaco-hover p, <ins> .monaco-hover .code, </ins> .monaco-hover ul { margin: 8px 0; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.1 commit OS Version: macOS 10.15 Sorry in advance if this is the wrong place for the issue, I'm not sure if this belongs in one of the LSP client library packages. Either way hover boxes, from LSP plugins, seem to render horizontal rules () a bit off: <img width="652" alt="image" src="https://user-"The horizontal rule is slightly cutting through the line beginning with "throw" Steps to Reproduce: a language server that produces a horizontal rule ( uses this) a hover? <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No I'm not sure how to reproduce this without using a language server extension!
the easiest would be if you start with this at the Haskell language server repository. What I would need is the generated markdown of the hover to investigate. You can link to this issue so that the Haskell devs can provide it.
Here's some markdown string we are sending via the hover request haskelln :: SessionException -IO ByteStringnhaskelln :: forall a e. Exception e =e -anhaskellnthrow :: forall a e. Exception e =e -an It looks like there is a blank line between the horizontal rule and where the third markdown block begins
Got a more minimal example <img width="104" alt="image" src="https://user-"from the markdown: haskellnLine 3n
Thanks for the fix!
can you mark the bug as verified since you reviewed and tested the PR.
Change:
return Action.Recurse; } <del> let lhs = node.expression; if (isSkipCall(lhs)) { </del> <ins> const asSuite = identifyCall(node.expression, suiteNames); const asTest = identifyCall(node.expression, testNames); const either = asSuite || asTest; if (either === IdentifiedCall.Skipped) { </ins> return Action.Skip; } <del> if (isPropertyCall(lhs) && lhs.name.text === 'only') { lhs = lhs.expression; </del> <ins> if (either === IdentifiedCall.Nothing) { return Action.Recurse; </ins> } const name = node.arguments[0]; const func = node.arguments[1]; <del> if (!name || !ts.isIdentifier(lhs) || !ts.isStringLiteralLike(name)) { return Action.Recurse; } if (!func) { </del> <ins> if (!name || !ts.isStringLiteralLike(name) || !func) { </ins> return Action.Recurse; }

Discussion:
Guessing this is because of the conditionals? It detects them fine, but doesn't run. They run fine if I add to the suite and !
Yes, we use an to extract tests from files. It doesn't doing any evaluation. Not sure that I want to open that can of worms
but it detects the tests as seen on the left side, so why isn't it able to run it if it knows the test name?
The identity of a test is formed by joining the containing file name and its name with the path of containing suites' names. The extension detects the suite but it does not recognize that it's a child of . When tests are run it's expecting updates to a test named , but it doesn't get that so it's marked as skipped.
I clicked run on though, so can't we run everything matching in that case?
It does run everything, and you should see that in the test output, but it doesn't associate the results with the tests. It expects to get results for but it actually gets , which is not a path to any test the extension knows about.
Could we be a little smarter in matching these up if there's a simple 1:1 match up? Like checking that expected items have matching prefixes and suffixes and there's no ambiguity? I don't expect this to work if we're generating tests with a loop (though that would be nice), if we can exactly match up the amount of tests to that expected then it should be safe?
Eh, I'll just add some logic to identify simple ternary expressions like these