jiebi/CodeConvo huggingface dataset:
Change:
return editorService.activeEditor ? toResource(editorService.activeEditor, { supportSideBySide: true }) : null; } <del> export function getMultiSelectedResources(resource: URI | object, listService: IListService, editorService: IEditorService): Array<URI> { </del> <ins> export function getMultiSelectedResources(resource: URI | object | undefined, listService: IListService, editorService: IEditorService): Array<URI> { </ins> const list = listService.lastFocusedList; if (list && list.getHTMLElement() === document.activeElement) { // Explorer

Discussion:
Issue Type: <bBug</bIf I right-click on a folder in the explorer view and select 'Find in Folder' the search panel appears with the correct folder selected in the 'files to include' input. If I perform the keyboard shortcut to 'Find in Folder' with a folder selected, the search panel appears but the 'files to include' input does not have the selected folder. This is on a MacOS Mojave 10.14.4 VS Code version: Code - Insiders 1.33.0-insider (, 2019-03-29T10:48:35.896Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (56)</summaryExtensionVersion ------ rainbow-brackets0.0.6 html-snippets0.2.1 markdown-toc1.5.6 Bookmarks10.4.1 npm-intellisense1.3.0 sql-formatter1.0.2 vscode-markdownlint0.25.1 vscode-eslint1.8.2 githistory0.4.6 javadebugger0.1.5 gitlens9.5.1 EditorConfig0.13.0 graphviz-preview1.3.1 tslint1.0.43 vscode-npm-script0.3.5 prettier-vscode1.8.1 docker-explorer0.1.6 vscode-yarn1.6.0 vscode-javac0.2.16 vscode-pull-request-github0.5.1 gc-excelviewer2.1.29 docthis0.7.1 vscode-codemetrics1.18.0 javascript-test-runner1.0.0 dotenv1.0.1 python2019.3.6215 azure-account0.8.0 csharp1.18.0 Go0.9.2 debugger-for-chrome4.11.3 sqltools0.17.9 language-liquid0.1.1 printcode3.0.0 vetur0.17.1 vscode-jscpd0.3.4 vscode-docker0.6.1 quicktype12.0.46 java0.42.0 vscode-yaml0.4.0 RustyCode0.19.1 scala0.2.0 metals1.2.7 code-settings-sync3.2.7 dot0.

0.1 Align0.2.0 code-spell-checker1.6.10 unique-window-colors1.0.23 html-preview-vscode0.2.5 shellcheck0.6.0 sort-lines1.8.0 vscode-java-debug0.17.0 vscode-icons8.4.0 vscode-wakatime1.2.13 quokka-vscode1.0.200 vscode-todo-highlight1.0.4 change-case1.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.513 --- <!-- score: 0.509 --- <!-- score: 0.492 --- <!-- score: 0.49 --- <!-- score: 0.483 --<!-- potentialduplicatescomment --
Change:
if (this._hasShellIntegration) { content.push(shellIntegration); content.push('- ' + this._descriptionForCommand(TerminalCommandId.RunRecentCommand, runRecentCommand, runRecentCommandNoKb) + 'n- ' + this._descriptionForCommand(TerminalCommandId.GoToRecentDirectory, goToRecent, goToRecentNoKb)); <ins> } else { content.push(this._descriptionForCommand(TerminalCommandId.GoToRecentDirectory, goToRecentNoShellIntegration, goToRecentNoKbNoShellIntegration)); </ins> } content.push(this._descriptionForCommand(TerminalCommandId.OpenDetectedLink, openDetectedLink, openDetectedLinkNoKb)); content.push(this._descriptionForCommand(TerminalCommandId.NewWithProfile, newWithProfile, newWithProfileNoKb));

Discussion:
CC The terminal help instruction on "Go to Recent Directory (Control+G)" is only available when integrated shell is used. Try Alt+F1 in cmd prompt. You won't see that.
Thank you for the issue and clarification. That is by design because the command isn't supported/doesn't exist without shell integration. This is because we can only have knowledge of cwds via shell integration insights
-- As far as I tested, Ctrl+G works in CMD prompt as well. Please correct me if I am wrong.
Ctrl+R does not work though.
You are correct
To verify, disable shell integration or use a shell without shell integration support like command prompt and check that the terminal accessibility help menu includes info on the go to recent directory command
Change:
?? element.separator?.id ?? element.separator?.label ?? ''; <del> } </del> <ins> }, </ins> }, alwaysConsumeMouseWheel: true }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0-insider OS Version: MacOs Steps to Reproduce: In the python and python debugger extension we use the QuickPick, we add an option to accept the value in the input. It was working in stable, but in insiders it doesn't work. Steps: a picker some text in the input box, make sure that it match with one option at first. enter, to select the text in the input box. last value that appeared in the list is the one that is selected. You can check the implementation . I was debugging the code a little bit, and found that in stable when you press enter, the function is called. But in insider when you press enter instead of call that function, the function is called.
Verification: Install Python extension Open a python workspace with no Open the debug pane and click the "create a file" Choose Python Debugger Choose Django Type ONLY 'b' and notice that "Browse Files" becomes the active item Type then, 'z' and notice that the list is empty hit ENTER and notice that the gets created with "bz" in the
The fix fully resolves as well!
Resolves my issue as well.
Change:
} .monaco-editor.hc-black .sticky-widget, <del> .monaco-editor.hc-white .sticky-widget { </del> <ins> .monaco-editor.hc-light .sticky-widget { </ins> border-bottom: 1px solid var(--vscode-contrastBorder); }

Discussion:
Type: <bBug</bstick scroll to high contrast down in a file Bug There is no contrast between the stick scroll content and the normal editor content: ! Related VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-26T05:22:17.192Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
For verification: sticky scroll, switch to high-contrast and scroll down the file. should see a border on the bottom of the sticky scroll widget
I see it in dark theme but not light high contrast: !
Change:
*--------------------------------------------------------------------------------------------*/ import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; <ins> import { EditorExtensionsRegistry } from 'vs/editor/browser/editorExtensions'; </ins> import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { localize } from 'vs/nls'; import { registerAction2 } from 'vs/platform/actions/common/actions';

Discussion:
Issue Type: <bBug</bWhen using intellisense prompts inside a .ipynb file, I am unable to use the arrow keys to navigate the given prompt. tested by just typing "impo" and then trying to navigate the import autocomplete prompts Unable to repro in the stable release, seems to be just the pre-release version Extension version: 2022.6. VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-21T05:16:12.334Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This sounds like an issue in the editor? Transferring to VS code. This isn't handled by the Jupyter extension.
It happens when there is only a single line in the cell.
Change:
this._currentDocumentRequestCancellationTokenSource.cancel(); this._currentDocumentRequestCancellationTokenSource = null; } <ins> dispose(this._documentProvidersChangeListeners); this._documentProvidersChangeListeners = []; </ins> this._setDocumentSemanticTokens(null, null, null, []); this._isDisposed = true;

Discussion:
Type: <bBug</bup and down in the file a few times Bug In the dev tools see two potential leaks reported: VS Code version: Code - Insiders 1.79.0-insider (Universal) (, 2023-06-06T15:04:36.424Z) OS version: Darwin x64 22.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Notebook is a good place for catching memory leaks.
Change:
}; return this._commands.executeCommand<modes.CompletionList>('_executeCompletionItemProvider', args).then(result => { if (result) { <del> const items = result.suggestions.map(suggestion => typeConverters.CompletionItem.to(suggestion)); </del> <ins> const items = result.suggestions.map(suggestion => typeConverters.CompletionItem.to(suggestion, this._commands.converter)); </ins> return new types.CompletionList(items, result.incomplete); } return undefined;

Discussion:
If you return in a completion item, the property is when calling through . Setup: Test code: Output is: Full repro project is here:
It looks like the conversion is missing. The doc states that additionalTextEdits should not overlap with the main edit range or each other, should that be checked or is that done when the edits are carried out? Adding this: ! works, unless the range intersections need to be checked.
No checks required - this is already the way back from the UX and check should have been carried out already
Change:
const readStub = sandbox.stub().returns({ editSession, ref: '0' }); instantiationService.stub(IEditSessionsStorageService, 'read', readStub); <ins> // Ensure that user does not get prompted here const dialogServiceShowStub = sandbox.stub(); instantiationService.stub(IDialogService, 'show', dialogServiceShowStub); </ins> // Create root folder await fileService.createFolder(folderUri);

Discussion:
Testing Continue from web inside desktop Let the window sit Install update (which restarts the App) you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code) Ideas don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus don't show this when my local changes are no different to those on the server <img width="1391" alt="Screenshot 2022-08-24 at 09 26 13" src="https://user-"
Is the custom modal overlay the same thing as the custom modal dialog, i.e. :+1: I filed for this.
Change:
this.hoverDisposables.clear(); this.updateTitle(); <del> this.hoverDisposables.add(addDisposableListener(this.container, EventType.MOUSE_OVER, () => { </del> <ins> this.hoverDisposables.add(addDisposableListener(this.label, EventType.MOUSE_OVER, () => { </ins> if (!this.showHoverScheduler.isScheduled()) { <del> this.showHoverScheduler.schedule(this.configurationService.getValue<number>('workbench.hover.delay')); </del> <ins> if (Date.now() - ActivityActionViewItem._hoverLeaveTime < 200) { this.showHover(true); } else { this.showHoverScheduler.schedule(this.configurationService.getValue<number>('workbench.hover.delay')); } </ins> } }, true)); <del> this.hoverDisposables.add(addDisposableListener(this.container, EventType.MOUSE_LEAVE, () => { </del> <ins> this.hoverDisposables.add(addDisposableListener(this.label, EventType.MOUSE_LEAVE, () => { ActivityActionViewItem._hoverLeaveTime = Date.now(); </ins> this.hover.value = undefined; this.showHoverScheduler.cancel(); }, true));

Discussion:
Native browser tooltips and many custom ones (Figma, Discord, Edge tabs) keep the tooltip element visible when moving between elements. Would be nice to do the same, to make mouse exploration even snappier. Discord icon bar: ! macOS dock: !
cc as this discussion was spawned off cc as owner of the hover widget cc as we talked about this a few times and he brought it up most recently in the team chat
fyi I'm the main hover widget person This seems doable, needs some thinking on how this would be exposed in the API. It's also a feature of native browser tooltips when hovering from one element with to another.
Thanks for confirmation :)
Change:
import { NativeHostService } from 'vs/platform/native/electron-sandbox/nativeHostService'; import { getIconsStyleSheet } from 'vs/platform/theme/browser/iconsStyleSheet'; import { applyZoom, zoomIn, zoomOut } from 'vs/platform/window/electron-sandbox/window'; <ins> import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { KeyCode } from 'vs/base/common/keyCodes'; </ins> const DEBUG_FLAGS_PATTERN = /s--(inspect|debug)(-brk|port)?=(d+)?/; const DEBUG_PORT_PATTERN = /s--(inspect|debug)-port=(d+)/;

Discussion:
Depends on This is common for process explorers on Windows at least, might also make sense to bring this to Linux.
This should be doable now that has landed via
Change:
isBefore(other: Position): boolean; /** <del> * Check if `other` is before or equal to this position. </del> <ins> * Check if this position is before or equal to `other`. </ins> * * @param other A position. * @return `true` if position is on a smaller line

Discussion:
In , the comparison functions , , , and have misleading descriptions. For example, says "Check if is before this position." I think it would be more clear to say something like "Check if this position is before ", as that is when is returned. Likewise for the other three.
Change:
* Controls whether the task is executed in a specific terminal group using split panes. */ group?: string; <del> /** * Controls whether the terminal is closed after executing the task. */ close?: boolean; </del> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Linux JD 5.13.10-arch1-1 Although there is an option to close terminal after task completes running in , the option doesn't exist in interface TaskPresntationOptions Steps to Reproduce: VS Code extension a task in extension to set presentation field with close: ! Steps to Fix: close field to interface TaskPresntationOptions in ! TypeScript error: ! as expected, task closes after run: ! Adding this issue for a pull request
can you please describe why having the presentation options is important to have as extension API? We do not like to add API just for the sake of having it, so I want to understand that it will be useful for multiple extension authors before adding it.
Hi
sounds like you have a real use case for it. Thanks for the details!
Reopening for finalization
Change:
import { IURITransformer } from 'vs/base/common/uriIpc'; interface ITestRunner { <ins> /** Old test runner API, as exported from `vscode/lib/testrunner` */ </ins> run(testsRoot: string, clb: (error: Error, failures?: number) => void): void; } <ins> interface INewTestRunner { /** New test runner API, as explained in the extension test doc */ run(): Promise<void>; } </ins> export interface IHostUtils { exit(code?: number): void; exists(path: string): Promise<boolean>;

Discussion:
Testing create a TS extension as described in and look at 'runTests' is called with testRunnerPath. The hover of says: ts import as testRunner from 'vscode/lib/testrunner'; module.exports = testRunner; Looking at I don't see a testRunner exported.
Ok, thanks. But now my question is about What is the ? How does the user define it? Is it necessary? Why do we use the style. Our APIs typically use Promises...
So the testRunner is the module name passed to . Did we change the contract? Before it had to export a now it has to export a ?
We didn't. That's what the old test runner does: We use the old API since we don't want to break backwards compat. I'd suggest we come up with a better API (see my comment here: ), but it has to be a different name, such as . Here's the relevant code:
I don't really like us having to have this API, but for people who are still importing from , if they don't migrate we don't want to break them.
Actually, for people who have been importing from , they haven't used the signature directly. So if we do add a better signature with a different name such as , we might not need to expose .
The change is to add a new function signature for : When the function returns a promise, wait for the promise, otherwise use the old logic.
Change:
const fileTree = await this.getFiletree(); for (const [resource, content] of files) { fileTree.add(resource.path, { type: 'file', size: content.byteLength }); <del> this.versions.set(resource.toString(), (this.versions.get(resource.toString()) || 0) + 1); </del> <ins> this.mtimes.set(resource.toString(), Date.now()); </ins> } this.triggerChanges(files.map(([resource]) => ({ resource, type: FileChangeType.UPDATED })));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1/69-insider OS Version: Windows 11 Steps to Reproduce: user file in timeline view :bug: see timeline entries from 52 years ago !
Is this reproducible or a one-off?
Looks like the file system provider that is implemented for is not implementing properly, I see a value of : <img width="851" alt="image" src="https://user-"Moving to
Change:
this.os = OS; this.userHome = pathService.defaultUriScheme === Schemas.file ? this.pathService.userHome({ preferLocal: true }) : undefined; <del> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters', storageService); </del> <ins> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters2', storageService); </ins> this.storedFormatters = memento.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); <del> this.formatters = this.storedFormatters?.formatters || []; </del> <ins> this.formatters = this.storedFormatters?.formatters?.slice() || []; </ins> // Remote environment is potentially long running this.resolveRemoteEnvironment();

Discussion:
Repro: Using Open a Remote - WSL folder !
This would probably not be limited to the title, what about the hover over the tab?
The separators seem to be flipped: !
I wonder if could have regressed this, is this a recent regression?
I cannot reproduce, so this is some setting you have or some configuration most likely.
It might be remnants of the formatted caching bug?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { SuggestWidgetPreviewModel } from 'vs/editor/contrib/inlineCompletions/suggestWidgetPreviewModel'; </del> <ins> import { minimizeInlineCompletion, SuggestWidgetPreviewModel } from 'vs/editor/contrib/inlineCompletions/suggestWidgetPreviewModel'; </ins> import { SuggestController } from 'vs/editor/contrib/suggest/suggestController'; import { SnippetController2 } from 'vs/editor/contrib/snippet/snippetController2'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0-insider (user setup) OS Version: Windows_NT x64 10.0. List of extensions: None, all are disabled Steps to Reproduce: a new typescript file. , the suggestions widget opens and the first suggestion is . gray text however, only shows , it's missing the last character. 've attached a gif. Notice how when I type , the gray text displays but when I type , it shows . !
can you please verify todays insider build fixes this?
Yes, it has been fixed!
Change:
Init = 1 << 12, Show = 1 << 13, Stage = 1 << 14, <del> GetCommitTemplate = 1 << 15 </del> <ins> GetCommitTemplate = 1 << 15, Merge = 1 << 16 </ins> } // function getOperationName(operation: Operation): string {

Discussion:
It does not currently appear possible to merge local git branches in VS Code. Quite a common workflow is to have a "development" branch to develop new features on (or alternatively have feature specific branches). When the development is finished, the development branch is then merged into the "master" branch before release. This can be done via the integrated terminal, but as VS Code's git implementation is so wizzy, it would be great to be able to replicate this workflow using the GUI.
I can't believe there aren't more for this... what are the current alternatives? An extension, or have you guys set up a task for this?
+1, I think that feature might be considered priority for the git extension, it's a really nice implementation and with merging, would be perfect. No news?
It'd be lovely to be able to trigger a merge from the command palette, e.g. cmd + shift + p Select a branch to merge from via search-dropdown Any opportunity to avoid having to dip back into the command line is lovely. Thanks in advance!
Weird it is still not implemented and even weirder since we can create and change branch. It spoils the git integration in Code as if the feature was unfinished. We can still rely on built-in terminal or extension but it is not a consistent Code workflow Same for git stash
I also would like to see a Git Merge implemented eventually without going in the console. you might be interested to know that there's an open PR to which will hopefully land soon. There's actually also a PR for but changes were asked over a month ago and it wasn't done yet, so it might not land.
Fixed in