jiebi/CodeConvo huggingface dataset:
Change:
dependencies: object-keys "~0.4.0" <del> xterm-addon-canvas@0.3.0-beta.1: version "0.3.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.1.tgz#17a65f5da65416b01d620ddef6247ff5013ffc15" integrity sha512-34PKhrkvK1RtlOOmni4i5GUIyoFKGMph8fWFvA2d52IDTKmX9YoLzZfU73D/sUAx+/GKobCE8sr14CuBZctgNw== </del> <ins> xterm-addon-canvas@0.3.0-beta.8: version "0.3.0-beta.8" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.8.tgz#1848d54091e864cf6aa7310e5d883203fe09247a" integrity sha512-NGaPADoh4/out6pCgfwh6lVDpJQtQXMRBXpvHB2rMcJqAZ0KHJalQXbjBmwSL9/WiHvYLhmqvGJ3+Pd9aE8hoA== </ins> <del> xterm-addon-search@0.11.0-beta.1: version "0.11.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.1.tgz#fe7178d70246cde73550447c5524672575467499" integrity sha512-fKj8KnnhH1nC4oZpKsgnhtgxkTctoa9kGLMpTJjsNzFu0VvXvLGIRezTPI75UEIQdEdaxcwB7/aKelQTO+72LA== </del> <ins> xterm-addon-search@0.11.0-beta.3: version "0.11.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.3.tgz#ee466425b83c74b69cbf71903c3781895beea5ab" integrity sha512-Fc9VuQn31JNnD2gZUEFMUYLpz6kPw5LMLp7YTB5iDv43JklEJL/14v6C4dFZkAo95MPi7yr3CUefYXz0dt+O7Q== </ins> xterm-addon-serialize@0.9.0-beta.2: version "0.9.0-beta.2"

Discussion:
Testing using canvas render. ! Should the line be continuous even though it overlaps the characters? vs "on": ! I'm talking about characters like and .
I didn't bother adding this to the canvas renderer as it's the fallback which is primarily for iPad atm, nothing stopping it from working there too though. Should really consolidate the rendering code for webgl and canvas as they mostly do the same thing when drawing the actual characters.
The wavy underline looks off with gpu enabled (first example in the attached screenshot). With the canvas setting, it's not rendered at all. !
The look of curly was going to be revisited in
Change:
*/ export const disabledSchemes = new Set([ git, <del> vsls </del> <ins> vsls, github, </ins> ]);

Discussion:
a TS file Bug The repo index downloads quickly but TS initialization takes a long time From a profile, I noticed that some calls from the TS Server take between 200 and 400ms: ! I also noticed that we seem to be making network requests which invoke for a bunch of repos with names that look like file paths. ! Following this further, I noticed the request on JS/TS sends over two copies of every file: Note that these paths are transformed into URIs that look like: The first one is the correct path AFAIK? Not sure where the second one is coming from, but it seems to be the request that generates the network requests Does remote hub have two file system providers, one for and one for ? If it does, should JS/TS ignore the open documents?
Yes, there are two file system providers, and you can just deal with the URIs.
I consistently see two requests for TS server, is that expected? <img width="966" alt="image" src="https://user-"
Yes, we start two instance of the server: one fast one and one for project wide support. Hopefully with caching though this does not actually result in two network requests
Change:
switch (ref.type) { case RefType.RemoteHead: return { <del> id: `refs/remotes/${ref.remote}/${ref.name}`, </del> <ins> id: `refs/remotes/${ref.name}`, </ins> name: ref.name ?? '', description: ref.commit ? l10n.t('Remote branch at {0}', ref.commit.substring(0, 8)) : undefined, revision: ref.commit,

Discussion:
Type: <bBug</b! I expected an upstream/main badge on the tree, and that badge on the hover tip to have a colour. VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-10T05:04:21.546Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
/assign
Nice catch! Fix should be in tomorrow's Insiders release.
Change:
dependencies: object-visit "^1.0.0" <del> markdown-it-front-matter@^0.1.2: version "0.1.2" resolved "https://registry.yarnpkg.com/markdown-it-front-matter/-/markdown-it-front-matter-0.1.2.tgz#e50bf56e77e6a4f5ac4ffa894d4d45ccd9896b20" integrity sha1-5Qv1bnfmpPWsT/qJTU1FzNmJayA= </del> <ins> markdown-it-front-matter@^0.2.1: version "0.2.1" resolved "https://registry.yarnpkg.com/markdown-it-front-matter/-/markdown-it-front-matter-0.2.1.tgz#dca49a827bb3cebb0528452c1d87dff276eb28dc" integrity sha512-ydUIqlKfDscRpRUTRcA3maeeUKn3Cl5EaKZSA+I/f0KOGCBurW7e+bbz59sxqkC3FA9Q2S2+t4mpkH9T0BCM6A== </ins> markdown-it@^10.0.0: version "10.0.0"

Discussion:
Issue Type: <bBug</bThe outline view showing markdown chapters and subchapters does not show anything if the document yaml frontmatter ends in "...". This works: title: My title # My chapter But this doesn't (the outline does not show anything): title: My title ... # My chapter VS Code version: Code 1.32.2 (, 2019-03-13T02:00:46.035Z) OS version: WindowsNT x64 6.1.7601 <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ markdown-checkbox0.1.1 vscode-markdownlint0.25.0 vscode-pandoc0.0.8 gitlens9.5.1 language-haskell2.5.0 rainbow-csv1.0.0 Go0.9.2 vscode-docker0.6.0 material-icon-theme3.6.3 qub-xml1.2.1 markdown-preview-enhanced0.3.12 vscode-table-formatter1.2.1 vscode-mermaid-preview0.11.1 </details<!-- generated by issue reporter --
I just want to add that the preview is not generated too. I opened a bug report against an , but seems it uses the vscode services. Version: 1.32.3 (user setup) Commit: Date: 2019-03-14T23:43:35.476Z Electron: 3.1.6 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.
To help with this, please look into fixing this upstream:
For fixing this issue, I need to implement this in . And update dependency in , correct?
And updating example on
Yes, that is correct
Ummm it seems isn't maintained anymore... () When like this situation, how can we do?
Let's give it a few more days and see if they respond. Otherwise, we can fork the repo and take your PR into the fork
Change:
this.actionRegistry[action.id] = action; }); <del> if (filePatterns !== '' || patternExclusions !== '' || patternIncludes !== '') { </del> <ins> if (filePatterns !== '' || patternExclusions !== '' || patternIncludes !== '' || queryDetailsExpanded !== '') { </ins> this.toggleQueryDetails(true, true, true); }

Discussion:
I find myself expanding this option nearly every time I use VSCode, would it be possible to have a setting that allows the search details to be open by default? !
It could be persisted as open, same as the button states are persisted.
Change:
} // Show the hover hint if needed <del> if (hideOnHover && options.appearance?.showHoverHint) { </del> <ins> if (options.appearance?.showHoverHint) { </ins> const statusBarElement = $('div.hover-row.status-bar'); const infoElement = $('div.info'); infoElement.textContent = localize('hoverhint', 'Hold {0} key to mouse over', isMacintosh ? 'Option' : 'Alt');

Discussion:
Testing The hover widget of the extension is often dismissed too early and making it hard to move cursor to the hover widget and click on the links. From the recording above you can see that I only get it working 1 out of 3 times.
This is because you hover the scroll bar which dismisses it, currently you need to hold alt to lock the hover. consider adding the option: We can also remove this requirement which I think will be needed to get this to work in your case:
It seems this option is not available for
will merge after we branch off
Another case for scm view. does your fix cover this too?
there you're hovering an element with a different hover which is why it's dismissed, related but different case and i think we're acting as designed there.
in the recording I was attempting to move cursor into the hover so I can click on the button in the rich hover. It seems we don't have a large enough "hit area" in general and the hover is easily dismissed.
Still seeing this. If there's a scrollbar like below I can't move the cursor to the hover without it getting dismissed: ! Holding alt works
Fix here is to show the hint to Hold Alt and it seems not to be shown. I have set the flag while showing the hover and it is still not shown.
Seems to show unless the extension is verified: <img width="733" alt="Screenshot 2024-08-28 at 8 23 38 AM" src=""
Change:
protected view: TreeNodeList<T, TFilterData, TRef>; private renderers: TreeRenderer<T, TFilterData, TRef, any>[]; <del> model: ITreeModel<T, TFilterData, TRef>; // used in MouseController </del> <ins> protected model: ITreeModel<T, TFilterData, TRef>; </ins> private focus: Trait<T>; private selection: Trait<T>; private anchor: Trait<T>;

Discussion:
This is a follow-up on and where I simply make the model-property of the tree public. Tho, a better fix might be needed here
Change:
} .monaco-workbench  > .part.panel > .title > .panel-switcher-container > .monaco-action-bar .badge { <del> margin-left: 4px; </del> <ins> margin-left: 8px; </ins> } .monaco-workbench  > .part.panel > .title > .panel-switcher-container > .monaco-action-bar .badge .badge-content { <del> padding: 0.2em 0.5em; </del> <ins> padding: 0.3em 0.5em; </ins> border-radius: 1em; font-weight: normal; text-align: center; <del> display: inline; } </del> <ins> display: inline-block; min-width: 1.6em; line-height: 1em; box-sizing: border-box; } </ins> /** Actions */

Discussion:
Need to update the css so that this badge becomes a circle (when a single digit) instead of an odd shape. It also doesn't match the badge used in the content area: !
Change:
} } <del> const local = await this.extractExtension({ zipPath: path.resolve(this.location.fsPath), key: extensionKey, metadata }, token); </del> <ins> const local = await this.extractExtension({ zipPath: path.resolve(this.location.fsPath), key: extensionKey, metadata }, true, token); </ins> return [local, metadata]; }

Discussion:
Type: <bBug</bI already filed this bug in the Pylance repository (microsoft/pylance-release), but it got closed because the Pylance devs think it's a problem with VSCode rather than with Pylance. Both files contain only Pylance + all its dependencies. the files , and . the VSCode profile from . This should work as expected. the Python file in VSCode and wait till Pylance is loaded (you might need to "trust" the window). the VSCode profile from . Here the error appears! The second VSCode profile should load and activate itself. The Pylance extension should be installed correctly and no error should appear. When the second VSCode profile is imported the following error notification appears: Unable to delete the existing folder 'c:Users<username.vscodeextensionsms-' while installing the extension 'ms-'. Please delete the folder manually and try again The profile is imported, but without Pylance. Additionally, Pylance is removed from the first profile as well! VS Code version: Code 1.77.3 (, 2023-04-12T09:16:02.548Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I tried it and I cannot repro. May I know if you can reproduce this consistently?
I can still reproduce consistently on every try. I a minimal Python file to the repro.
I can repro while there are some exts depend on c#
I tried again with the same steps and provided profiles and I cannot repro. If you are able to repro consistently, can you please share following logs F1 Open View... Shared F1 Open View... Window
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Sorry, I was on vacation. Here are the logs: <details<summaryShared</summary</details<details<summaryWindow</summary</details
Same issue here. Basically makes Python unusable in more than one Profile.
reopen
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
new ApiCommand( 'vscode.prepareTypeHierarchy', '_executePrepareTypeHierarchy', 'Prepare type hierarchy at a position inside a document', [ApiCommandArgument.Uri, ApiCommandArgument.Position], <del> new ApiCommandResult<ITypeHierarchyItemDto[], types.TypeHierarchyItem[]>('A TypeHierarchyItem or undefined', v => v.map(typeConverters.TypeHierarchyItem.to)) </del> <ins> new ApiCommandResult<ITypeHierarchyItemDto[], types.TypeHierarchyItem[]>('A promise that resolves to an array of TypeHierarchyItem-instances', v => v.map(typeConverters.TypeHierarchyItem.to)) </ins> ), new ApiCommand( 'vscode.provideSupertypes', '_executeProvideSupertypes', 'Compute supertypes for an item', [ApiCommandArgument.TypeHierarchyItem], <del> new ApiCommandResult<ITypeHierarchyItemDto[], types.TypeHierarchyItem[]>('A TypeHierarchyItem or undefined', v => v.map(typeConverters.TypeHierarchyItem.to)) </del> <ins> new ApiCommandResult<ITypeHierarchyItemDto[], types.TypeHierarchyItem[]>('A promise that resolves to an array of TypeHierarchyItem-instances', v => v.map(typeConverters.TypeHierarchyItem.to)) </ins> ), new ApiCommand( 'vscode.provideSubtypes', '_executeProvideSubtypes', 'Compute subtypes for an item', [ApiCommandArgument.TypeHierarchyItem], <del> new ApiCommandResult<ITypeHierarchyItemDto[], types.TypeHierarchyItem[]>('A TypeHierarchyItem or undefined', v => v.map(typeConverters.TypeHierarchyItem.to)) </del> <ins> new ApiCommandResult<ITypeHierarchyItemDto[], types.TypeHierarchyItem[]>('A promise that resolves to an array of TypeHierarchyItem-instances', v => v.map(typeConverters.TypeHierarchyItem.to)) </ins> ), // --- testing new ApiCommand(

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: windows 11 Hi, I am an extension developer, I found that the built-in call hierarchy api description is incorrect in , this makes me confused all day! ! The first api should return an array of . This confused me a lot. The second and third api should return array of and .
Change:
shortTitle: localize('mergeEditor.compareWithBase', 'Compare With Base'), f1: true, precondition: ctxIsMergeEditor, <del> menu: { id: MenuId.MergeInput1Toolbar } </del> <ins> menu: { id: MenuId.MergeInput1Toolbar, group: 'primary' }, icon: Codicon.compareChanges, </ins> }); }

Discussion:
! I personally find it a bit strange to have no primary action and only secondary actions hidden behind "...". What is the rationale? //cc
We are looking at pulling these out as primary actions like so. See . <img width="1015" alt="CleanShot 2022-10-03 at 09 11 23 src="https://user-"
!
!
Change:
import { ICompressibleTreeRenderer } from 'vs/base/browser/ui/tree/objectTree'; import { ITreeContextMenuEvent, ITreeNode } from 'vs/base/browser/ui/tree/tree'; import { Action, IAction, Separator } from 'vs/base/common/actions'; <del> import { Delayer, RunOnceScheduler } from 'vs/base/common/async'; </del> <ins> import { Delayer, Limiter, RunOnceScheduler } from 'vs/base/common/async'; </ins> import { Codicon } from 'vs/base/common/codicons'; import { Color } from 'vs/base/common/color'; import { Emitter, Event } from 'vs/base/common/event';

Discussion:
Type: Bug Version: 1.81.0 Commit: Date: 2023-08-02T12:36:11.334Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 5.15.0-76-generic Steps to Reproduce: the "Test Results" Panel command "Test: Run Tests in Current File" very quickly for several times "Test Results" Panel now displays two terminals, with the top one acting like phantom, and the bottom one displaying the real messages. After some investigation, I found the culprit to be that is not concurrently safe. Under certain cases, multiple calls to may happen concurrently within a short time period, which further leads to concurrent calls to , in which multiple instances of terminal are created and attached to the panel. This bug was largely improved by commit introduced by , which changed into This change reduces the possibility of concurrently calling to some extent and thus this bug may be harder to reproduce in the latest main branch. That being said, there's still a chance for this to happen. To thoroughly eliminate the risk, I fix it in PR .
Change:
export const file: string = 'file'; <ins> export const mailto: string = 'mailto'; </ins> export const untitled: string = 'untitled'; }

Discussion:
VSCode Version: Code 1.17.2 (, 2017-10-16T13:47:41.889Z) OS Version: Darwin x64 17.0.0 Extensions: ExtensionVersion ------ vscode-markdownlint0.10.1 beautify1.1.1 quokka-vscode1.0.72 path-intellisense1.4.2 vscode-svgviewer1.4.3 vscode-eslint1.3.2 python0.7.0 prettier-vscode0.24.0 flow-for-vscode0.7.2 markdown-shortcuts0.8.1 color-highlight2.3.0 javascript-typescript0.0.5 vscode-todo-highlight0.5.11 Steps to Reproduce: a mailto link in markdown file . markdown with and click on link. 't open mail client with email address and error notification pops up . Reproduces without extensions: Yes
I'd like to take a look at this issue if no one is on it yet.
Great! While the error is thrown in Take a look at how http and https links are being handled in there. We should probably handle mailto links similarly to http and https links
Thank you for the heads up! I'll take a look into the code :)
Change:
})); } <ins> private computeFilterStats(): { total: number, filtered: number } { let filtered = 0; let total = 0; if (this.tree) { total = this.tree.getNode().children.length; for (const child of this.tree.getNode().children) { if (child.visible) { ++filtered; } } } return { total, filtered }; } </ins> get isReadonly(): boolean { // Do not allow to edit inactive sessions const session = this.tree.getInput();

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
const editorPart = disposables.add(this.instantiationService.createInstance(AuxiliaryEditorPart, this, this.getGroupsLabel(this._parts.size))); disposables.add(this.registerEditorPart(editorPart)); <ins> editorPart.create(partContainer, { restorePreviousState: false }); disposables.add(this.instantiationService.createInstance(WindowTitle, auxiliaryWindow.window, editorPart)); disposables.add(Event.once(auxiliaryWindow.onWillClose)(() => { if (disposables.isDisposed) { return; // the close happened as part of an earlier dispose call } editorPart.close(); disposables.dispose(); })); </ins> disposables.add(Event.once(editorPart.onDidClose)(() => disposables.dispose())); disposables.add(Event.once(this.lifecycleService.onDidShutdown)(() => disposables.dispose())); <del> editorPart.create(partContainer, { restorePreviousState: false }); disposables.add(this.instantiationService.createInstance(WindowTitle, auxiliaryWindow.window, editorPart)); </del> disposables.add(auxiliaryWindow.onDidLayout(dimension => editorPart.layout(dimension.width, dimension.height, 0, 0))); auxiliaryWindow.layout();

Discussion:
Testing It would be great if we can have a command to bring back those editors to the main window.
I think that should actually be the default behaviour when you just close the window. That will prevent ugly confirmation dialogs for dirty editors when you attempt to close the floating window.
Verification: open a floating window with some editors (e.g. by dragging an editor tab out of the window) close the floating window, e.g. from the X window button verify all editors of the floating window are moved back to the main window
Change:
items.push({ label }); } } <ins> const outputProvider = this._instantiationService.createInstance(TerminalOutputProvider); </ins> const result = await this._quickInputService.pick(items.reverse(), { onDidTriggerItemButton: (async e => { <del> const output = e.item.command?.getOutput(); if (output) { await this._clipboardService.writeText(output); await this._commandService.executeCommand('workbench.action.files.newUntitledFile'); await this._commandService.executeCommand('editor.action.clipboardPasteAction'); </del> <ins> const selectedCommand = e.item.command; const output = selectedCommand?.getOutput(); if (output && selectedCommand?.command) { const textContent = await outputProvider.provideTextContent(URI.from( { scheme: TerminalOutputProvider.scheme, path: `${selectedCommand.command}... ${fromNow(selectedCommand.timestamp, true)}`, fragment: output, query: `terminal-output-${selectedCommand.timestamp}-${this.instanceId}` })); if (textContent) { this._editorService.openEditor({ resource: textContent.uri }); } </ins> } }) });

Discussion:
Testing I feel like I would mostly open output as a "one-off" editor to inspect test failures, for example. Having the prompt whenever I want to close the editor, since it's marked as untitled, is annoying. Instead, should it be opened as an ordinary read-only file which allows the user to if they want to keep it?
do you know how to do this in core? I also want to know how to do it in extensions for a similar problem in luna paint.
You can register an , I do that for test output: Alternatively (and in extensions) you can register a readonly FileSystemProvider.
Thanks, I'm a little surprised there's no option for extensions in as it seems like a common thing people would want to do.
Change:
{ "name": "vs/workbench/contrib/authentication", "project": "vscode-workbench" <ins> }, { "name": "vs/workbench/contrib/replNotebook", "project": "vscode-workbench" </ins> } ] }

Discussion:
was broken for some time and I re-enabled it today. However eslint failures were reported in and and I disabled them. Please have a look and fix the corresponding errors.
- I'm not sure what that rule is - do you know if it's documented somewhere? Also, when I remove that comment and run locally, I don't see any failures.
Tyler helped me find it. I don't see lint warnings for this for some reason, even though I have the installled and enabled
Change:
} .extension-editor > .header > .details { <del> flex: 1; </del> padding-left: 20px; overflow: hidden; user-select: text;

Discussion:
Testing In a zoomed in view <img width="1053" alt="screen shot 2018-06-26 at 11 35 55 am" src="https://user-"
The Ignore button is missing top and bottom padding of 1 px, which you can see on the button <img width="904" alt="screen shot 2018-06-26 at 11 39 29 am" src="https://user-"