jiebi/CodeConvo huggingface dataset:
Change:
} finalMatchedTargets.add(uri); }); <ins> }).catch(err => { // temporary fix for https://github.com/microsoft/vscode/issues/205044: don't show notebook results for remotehub repos. if (err.code === 'ENOENT') { console.warn(`Could not find notebook search results, ignoring notebook results.`); return { limitHit: false, messages: [], }; } else { throw err; } </ins> }); })) ));

Discussion:
Type: <bBug</bAs I typed into the search input, nothing fancy: See screenshot ! VS Code version: Code - Insiders 1.87.0-insider (, 2024-02-01T09:55:21.613Z) OS version: Darwin x64 23.3.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (60)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 docs-view0.1.0 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.21.0 markdown-preview-github-styles2.0.3 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.0 esbuild-problem-matchers0.0.3 kusto0.4.4 prettier-vscode10.1.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.9 copilot1.156.686 copilot-chat0.13. remotehub0.63. vscode-pull-request-github0.81. cortex-debug1.12.1 debug-tracker-vscode0.0.15 memory-view0.0.25 peripheral-viewer1.4.6 rtos-views0.0.7 vscode-azureresourcegroups0.8.3 vscode-dotnet-runtime2.0.1 debugpy2024.0.0 python2023.25. vscode-pylance2024.1.103 jupyter2024.1. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.339.0 remote-ssh0.108. remote-ssh-edit0.86.0 remote-wsl0.86.0 anycode0.0.72 azure-account0.11.6 azure-repos0.38.0 remote-repositories0.40.0 remote-server1.6.

vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.5. vscode-typescript-next5.4. prisma5.9.1 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting1.2.0 svg-preview2.8.3 rest-book6.2.1 pdf1.2.2 vscode-mdx1.7.0 volar1.8.27 vscode-typescript-vue-plugin1.8.27 markdown-all-in-one3.6.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I believe owns this area, assigning it to her.
Hmm, that usually comes with a faulty install. If you keep getting this, can you try re-installing?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
The STR needs a GH remote repo. Still broken for me after updating/re-instaling.
Change:
} item.size = row.domNode!.offsetHeight; <ins> if (this.virtualDelegate.setDynamicHeight) { this.virtualDelegate.setDynamicHeight(item.element, item.size); } </ins> item.lastDynamicHeightWidth = this.renderWidth; this.rowsContainer.removeChild(row.domNode!); this.cache.release(row);

Discussion:
See the GIF directly. ! As shown above, the settings UI always scrolls automatically, so I cannot find the modification because it went away. Marking or deselecting any item may cause this issue. VS Code version: Code 1.31.0 (, 2019-02-05T22:35:56.624Z) OS version: Windows_NT x64 10.0.
Annoyed me so much. Note that it happens with dropdowns and selecting an item, and occasionally by inputting textbox and clicking to defocus it.
Having this exact problem as well. I just installed VS code and am having this problem while giving it a trial run. Sigh....
Maybe related to
This isn't what I thought it was, I have to assign to you I think the ListView renders the setting items with their default heights, then rerenders and saves the offset of the anchor element. Then it fixes the heights of the elements and maintains the offset of the anchor element. But since it measured the anchor element when the elements had default heights, the list will be shifted if the real heights were different from the default heights. Maybe an anchor element should be measured before rendering the items with default heights or something like that. I made the default heights more accurate which helps.
Why is the list re-rendered when a check box is clicked?
When the config service says something changed, we rerender everything. It seems unnecessary in this case but it's hard to tell that the change event came "from" this instance of the settings editor and also, some values can be normalized when they get back to us, and since it should be safe to rerender, I don't put a lot of effort into reducing unneeded renders. Another way to repro this, open two settings editors in two groups, change a setting in Group 1, and see the editor in Group 2 scroll. If this just can't really be fixed there are things I can do like updating the value of a rendered setting row without actually calling setChildren. But that only works for some settings, adds more complexity, etc.
It can definitely be fixed. I was just wondering why the rerender was needed. ;)
cc
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.47: version "4.19.0-beta.47" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.47.tgz#9d5af8145c42b9a6241a040bb244b877c149761b" integrity sha512-chVTURPMNDEerQIsN4lIRotpXCfJsTHioZGQxDBNdktZO1gMXGvNxDjzsbsJg5ikLN5llz/HLDfXZrjCeb3elg== xterm@4.19.0-beta.47: version "4.19.0-beta.47" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.47.tgz#f5931201346a485e3bcb29d24e83583727e55707" integrity sha512-c8EcCSWCHnFYNdRMTnJIpYTV9J2Ze7kdB1GhTcPO2ipMEsqaP/u6Ca8rgBWwV9HeEVfe4rGRqWW2qcSy4U9hMQ== </del> <ins> xterm-headless@4.19.0-beta.49: version "4.19.0-beta.49" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.49.tgz#8e4178620be9a9dee25a586ef992a6fc621a829a" integrity sha512-uRnHpR2pv1MJPbE3sa7XbP6x0uHubAWVMbiD26e3a5ICtWJQVVpLojkA0t4qU7CoMX85pRL1rIclg9CKY0B0xA== xterm@4.19.0-beta.49: version "4.19.0-beta.49" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.49.tgz#96d0d748c97a2f0cfa4c6112bc4de8b0d5d559fe" integrity sha512-qPhOeGtnB357mZOvfDckVlPDR7EDkSASQrB3aujhjgJlOiBBqcNRJcuSvF7v1DOho7xdEI9UQxiSiT5diHhMlg== </ins> y18n@^3.2.1: version "3.2.2"

Discussion:
Theme pictured is Sapphire. ! Possibly related to Code pointer
Blending colors in vscode yields rgba format, so we should add that support to !
issue
Repro for this is to set the following settings and try find in terminal:

Started seeing this yesterday: !
This seems to be related to my theme, probably same root cause as
Repro for this is to set the following settings and try find in terminal:
Change:
'libc6 (>= 2.4)', 'libc6 (>= 2.9)', 'libcairo2 (>= 1.6.0)', <del> 'libcups2 (>= 1.6.0)', </del> 'libcurl3-gnutls | libcurl3-nss | libcurl4 | libcurl3', 'libdbus-1-3 (>= 1.5.12)', 'libdrm2 (>= 2.4.38)',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Gentoo Linux Starting with 1.72, vscode has a hard dependency on a printing library, otherwise it refuses to even start. CUPS is quite a heavy dependency and not all Linux installations have it. This is a bug for two reasons: does not even support printing () then, such heavy libraries shall be only loaded on demand.
So, can you arrange with electron to not include the dependency on a heavy printing library? Nobody has printers these days.
Do you know which vscode release is going to start using Electron 22?
Verified with
Change:
private treeElementCanExpand: IContextKey<boolean>; private treeElementHasChild: IContextKey<boolean>; private treeFindOpen: IContextKey<boolean>; <del> private treeSupportFindWidget: IContextKey<boolean>; </del> private _useAltAsMultipleSelectionModifier: boolean; private disposables: IDisposable[] = []; private styler: IDisposable | undefined;

Discussion:
I think this came up during the standup today, why is the context key called and not ? //cc
This context key came in quite late via a fix -- . I noticed this standing out because of the default keybindings which seem to mix things up: Giving this a candidate in case we want to align the context key before shipping stable
From
Change:
let focusedButton = 0; this.buttonGroup = new ButtonGroup(this.buttonsContainer, this.buttons.length, { title: true }); <ins> const buttonMap = this.rearrangeButtons(this.buttons, this.options.cancelId); </ins> this.buttonGroup.buttons.forEach((button, index) => { <del> button.label = mnemonicButtonLabel(this.buttons[index], true); </del> <ins> button.label = mnemonicButtonLabel(buttonMap[index].label, true); </ins> this._register(button.onDidClick(e => { EventHelper.stop(e); <del> resolve(index); </del> <ins> resolve(buttonMap[index].index); </ins> })); });

Discussion:
Testing Mac, Insiders here's the code from my extension to get a modal dialog: Native: ! Custom: ! I actually like the fact that the button is always rightmost in the custom dialog, not sure why it is like it is in the native one.
I believe the layout is platform dependent. I don't think we need to adopt this behavior. thoughts?
I think we should try to stay close to platform expectations so that people on their OS feel familiar.
Change:
} <del> export function parseMarkSequence(sequence: string[]): { id?: string; hidden?: boolean } { </del> <ins> export function parseMarkSequence(sequence: (string | undefined)[]): { id?: string; hidden?: boolean } { </ins> let id = undefined; let hidden = false; for (const property of sequence) { <ins> // Sanity check, this shouldn't happen in practice if (property === undefined) { continue; } </ins> if (property === 'Hidden') { hidden = true; }

Discussion:
Run a command - for example - then and it doesn't exit that command !
Same issue: Versione: 1.78.1 Commit: Data: 2023-05-04T09:57:42.343Z Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 Sistema operativo: Darwin x64 18.7.0 In modalità sandbox: No
insiders-releasecontrl+Cbash: no job control in this shell
me too!
I am also facing the same problem and it is quite frustrating since killing the terminal is not killing the process and every time I have identify the pid and kill it from another terminal. I notice that it is tagged "Closed" but it is not fixed as of yet, atleast in Code-Insiders. Please fix this issue or suggest some sort of solution.
me either
this clearly isn't fixed
The issue this was tracking with the error in console is fixed, let's track any separate problem in
Change:
`); } <del> const activityBarSettingsProfileHoveFgColor = theme.getColor(ACTIVITY_BAR_SETTINGS_PROFILE_HOVER_FOREGROUND); if (activityBarSettingsProfileHoveFgColor) { </del> <ins> const activityBarSettingsProfileBgColor = theme.getColor(ACTIVITY_BAR_SETTINGS_PROFILE_BACKGROUND); if (activityBarSettingsProfileBgColor) { collector.addRule(` .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item .action-label.profile-activity-item, .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item .action-label.profile-activity-item, .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item .action-label.profile-activity-item { background-color: ${activityBarSettingsProfileBgColor} !important; } `); } const activityBarSettingsProfileHoverFgColor = theme.getColor(ACTIVITY_BAR_SETTINGS_PROFILE_HOVER_FOREGROUND); if (activityBarSettingsProfileHoverFgColor) { </ins> collector.addRule(` .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.active .action-label.profile-activity-item, .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item:focus .action-label.profile-activity-item, .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item:hover .action-label.profile-activity-item { <del> color: ${activityBarSettingsProfileHoveFgColor} !important; </del> <ins> color: ${activityBarSettingsProfileHoverFgColor} !important; </ins> } `); }

Discussion:
The original designs had something closer to this for the default background color. IMO it isn't trying to be an icon like the other items and the border makes it feel like an icon vs. a unique element. I also think the background and foreground should be the only customizable elements to start. I think I saw a foreground token, but not sure it was possible to do background yet. <img width="247" alt="CleanShot 2022-09-26 at 16 29 09 src="https://user-"
I also like this more over the border For example here this looks not too different from the actions above even though it is about profiles: <img width="297" alt="image" src="https://user-"
!
I like it but maybe with smaller font size? Here is with for example: !
Current font size goes well with all (emoji, codicons) and also symmetric with activity bar icons.
Change:
}) .done(null, e => this.messageService.show(severity.Error, e)); } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
I can confirm this happens for me as well. I am using Mac OS X. The operating system's display scaling is off (i.e. 1:1). I have been experimenting and it seems as though the bug is that the right click menu is displayed according to the cursor position, but this calculation is not adjusted to take into account zoom. The reason I say this is because if I right click near the top left of the editor, the cursor is quite close to the top left of the menu. But if I right click near the bottom right of the editor, the cursor is much further away from the top left of the menu. The misalignment is proportional to the distance from the top left of the editor.
Change:
this._lastNotebookEditResource.push(matches[0].cell.uri); matches.forEach(match => { <del> match.matches.forEach(singleMatch => { </del> <ins> match.matches.forEach((singleMatch, index) => { </ins> textEdits.push({ <del> edit: { range: singleMatch.range, text: text }, </del> <ins> edit: { range: singleMatch.range, text: texts[index] }, </ins> resource: match.cell.uri }); });

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In Jupyter Notebooks, finding witrh regex works but replacing with capturing groups doesn't. I'd like if it does. I tried as in the usual editor, but the replacement treats as literal. I had to work around by copying the code section to the usual editor, and then find and replace. This seems like an inconsistent UX, and personally quite inconvinient.
Should I have opened this at ? If so, please close this so I can move on.
Thanks again for the help, it makes the find experience in notebook closer to the normal text editor one.
did you create a test plan item for this? I just the verification needed to it.
Change:
if (this._currentRequest) { return this._currentRequest; } <del> this._currentRequest = new Promise<string>(resolve => { </del> <ins> this._currentRequest = new Promise<string>(async resolve => { if (!windowsProcessTree) { windowsProcessTree = await import('windows-process-tree'); } </ins> windowsProcessTree.getProcessTree(this._rootProcessId, (tree) => { const name = this.traverseTree(tree); this._currentRequest = undefined;

Discussion:
I see that is called very early here: Even though only used in some method later. Can we please move it where it is being used only to ensure we do not block startup?
Sure this can move it further down. It will only save ~5ms on Windows and only if the terminal is restored on start up.
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.1.0-beta.82", "xterm-addon-canvas": "0.3.0-beta.33", </del> <ins> "xterm": "5.1.0-beta.87", "xterm-addon-canvas": "0.3.0-beta.35", </ins> "xterm-addon-search": "0.11.0-beta.7", "xterm-addon-serialize": "0.9.0-beta.3", "xterm-addon-unicode11": "0.5.0-beta.5", <del> "xterm-addon-webgl": "0.14.0-beta.46", "xterm-headless": "5.1.0-beta.82", </del> <ins> "xterm-addon-webgl": "0.14.0-beta.50", "xterm-headless": "5.1.0-beta.87", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Testing Code insiders, set how the inactive selection colour is stronger than the active selection colour I can only reproduce this with "canvas", all other gpu acceleration options work fine. Terminal focused ! Terminal not focused !
Upstream:
Change:
} export interface ExtHostTelemetryShape { <del> $initializeTelemetryEnabled(enabled: boolean): void; $onDidChangeTelemetryEnabled(enabled: boolean): void; </del> <ins> $initializeTelemetryLevel(level: TelemetryLevel): void; $onDidChangeTelemetryLevel(level: TelemetryLevel): void; </ins> } export interface ITerminalLinkDto {

Discussion:
The current API does not expose the same level of internal granularity as the user setting allows. This proposal is to expose the telemetry levels. The current and can still be used a simpler API and this one can be considered more advanced and granular. Extension authors cannot just observe the user setting as this will lead to doing the wrong thing.
Another possibility is that we could collect an array of acceptable levels if we're worried about the possibility that the levels will not continue to be progressive but a permissions system instead. I.e. collecting errors and crashes would have be an array . None wouldn't really make sense in this context and would probably go away in favor of an empty array.
This is implemented but will remain in the proposed state for awhile for testing
Closing in favor of
Change:
quickPick.show(); } <del> function _getPicks(filter: string, selectAndStartID: string, debugService: IDebugService, viewsService: IViewsService, commandService: ICommandService): Array<IPickerDebugItem | IQuickPickSeparator> { </del> <ins> function _getPicksAndActiveItem(filter: string, selectAndStartID: string, debugService: IDebugService, viewsService: IViewsService, commandService: ICommandService): { picks: Array<IPickerDebugItem | IQuickPickSeparator>; activeItems: Array<IPickerDebugItem> } { </ins> const debugConsolePicks: Array<IPickerDebugItem | IQuickPickSeparator> = []; const headerSessions: IDebugSession[] = []; <ins> const currSession = debugService.getViewModel().focusedSession; </ins> const sessions = debugService.getModel().getSessions(false); <ins> const activeItems: Array<IPickerDebugItem> = []; </ins> sessions.forEach((session) => { if (session.compact && session.parentSession) {

Discussion:
Testing Placeholder could be more concise, for example "Search for debug session by name" -"Search debug session by name" !
Would it be better to have "Search debug sessions by name"? I noticed that the loaded script view says "Search loaded scripts by name". <img width="754" alt="image" src="https://user-"
The plural makes sense to me :) Thanks
Change:
continue; } if (count >= maxItems) { <del> primary[i] = undefined!; </del> <ins> primary[i] = undefined; </ins> extraSecondary[i] = action; } } } <ins> // coalesce turns Array<IAction|undefined> into IAction[] </ins> coalesceInPlace(primary); coalesceInPlace(extraSecondary); super.setActions(primary, Separator.join(extraSecondary, secondary));

Discussion:
open a file from a pull request get an error saying id cannot be read from undefined
this is a regression from
Yes, I too saw this when testing day before yesterday, but as soon as I updated this went away.
Change:
private _extensions: IExtension[] = []; get extensions(): readonly IExtension[] { return this._extensions; } <del> private _onDidChangeExtensions = this._register(new Emitter<{ added: readonly IExtension[]; removed: readonly IExtension[] }>()); </del> <ins> private _onDidChangeExtensions = this._register(new Emitter<{ added: readonly IExtension[]; removed: readonly IExtension[]; readonly isProfileSwitch: boolean }>()); </ins> readonly onDidChangeExtensions = this._onDidChangeExtensions.event; private readonly initializePromise;

Discussion:
VS Code Version: stable 1.74.0 OS Version: Windows 11 Build .900 Feature: Settings Profiles (Profiles) When certain Extensions that I had disabled for the active profile automatically update, they get re-inserted (re-enabled) in my Extensions list for that profile, and will remain there from that point onwards. I've noticed this with all the "C++" extensions from Microsoft, as well as the "Remote Explorer", and "Remote - SSH" also from Microsoft, but this might be happening with other extensions as well. Even if I disable them again for that profile, they'll come back the next time they update Steps to Reproduce: Profiles feature by setting the to true. the C++ from Microsoft on the default profile. a new profile "A" other than default, disable the C++ extension. a second profile "B" but enable the C++ extension. a third profile "C" following step 2. to either A or C profile. vscode, reopen it on the same folder, and wait for the C++ extension to update (I'm not aware of any means to force an extension update besides creating one myself). You'll notice that once the C++ extension update, it will re-enable automatically on both profiles A and C, and will remain there even after re-starting vscode, until you disable it again. In which case it will reappear again once it updates.
How did you force the extension update? Can you please share your profiles (you can use profile export feature) so that I can reproduce?
Hi as mentioned in the issue, I did not force the update since I'm not aware of any means to do that, I just waited for extensions to update. By the way I also noticed this happening with a non-Microsoft extension called "Better C++ Syntax" How can I share the profiles with you in a non-public manner?
You can export the profile to a file or github gist and share it with me via email -
Done. Hope that can solve it since it keeps happening. Thank you
Why is this still labelled as info-needed?
is there a way to simulate the extension update that is needed to reproduce the issue?

Yeah there is, but its a lengthy one: Please open extensions installation folder and the folder where profiles are stored that is user data folder/User/profiles Quit VS Code Change the name of the extension in the extensions installation folder and also the version in the Update the name and version in file in all profiles include the file in extension installation folder.
Change:
{ regex: /[.*](.*)/g, isMarkdownLink: true, isInline: true }, // Is a Markdown Link { regex: /![.*](.*)/g, isMarkdownLink: true, isInline: true }, // Is a Markdown Image Link { regex: /[([^]]*)](([^)]*))/g, isMarkdownLink: false, isInline: true }, // In a Markdown link <del> { regex: /^```[sS]*?```$/gm, isMarkdownLink: false, isInline: false }, // In a fenced code block </del> <ins> { regex: /^```[sS]*?```$/gm, isMarkdownLink: false, isInline: false }, // In a backtick fenced code block { regex: /^~~~[sS]*?~~~$/gm, isMarkdownLink: false, isInline: false }, // In a tildefenced code block </ins> { regex: /^$$[sS]*?$$$/gm, isMarkdownLink: false, isInline: false }, // In a fenced math block { regex: /`[^`]*`/g, isMarkdownLink: false, isInline: true }, // In inline code { regex: /$[^$]*$/g, isMarkdownLink: false, isInline: true }, // In inline math

Discussion:
Type: <bBug</ba md file: a url inside the block (this is an alternative way to create a fenced code block) bug The url is incorrectly pasted as a markdown link VS Code version: Code - Insiders 1.81.0-insider (Universal) (, 2023-07-25T08:15:40.243Z) OS version: Darwin x64 22.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --