jiebi/CodeConvo huggingface dataset:
Change:
const linkPrefixMatch = linePrefixText.match(this.linkStartPattern); if (linkPrefixMatch) { <del> const prefix = linkPrefixMatch[2]; </del> <ins> const isAngleBracketLink = linkPrefixMatch[2].startsWith('<'); const prefix = linkPrefixMatch[2].slice(isAngleBracketLink ? 1 : 0); </ins> if (this.refLooksLikeUrl(prefix)) { return undefined; } <del> const suffix = lineSuffixText.match(/^[^)s]*/); </del> <ins> const suffix = lineSuffixText.match(/^[^)s][^)s>]*/); </ins> return { kind: CompletionContextKind.Link, linkPrefix: tryDecodeUriComponent(prefix), linkTextStartPosition: position.translate({ characterDelta: -prefix.length }), linkSuffix: suffix ? suffix[0] : '', anchorInfo: this.getAnchorContext(prefix), <ins> skipEncoding: isAngleBracketLink, </ins> }; }

Discussion:
Issue Type: <bBug</bTrigger path suggestions inside a markdown link that uses angle brackets: Bug No suggestions show up VS Code version: Code - Insiders 1.69.0-insider (Universal) (, 2022-06-17T05:16:27.373Z) OS version: Darwin x64 21.5.0 Restricted Mode: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Relevant code:
So I'm new to this project. Do I ask if I can be assigned this bug? Or is it whoever submits an solution first makes the pull request?
You can ask, I am currently working on this now - but you can try as well.
Alright thanks. So in general I can just work on a problem that catches my attention and ask/answer questions when appropriate?
Yes pretty much, you can work on any problem or issue that you would like.
What specifically is the bug here? Is the desired behavior where when you type a list of path links should appear?
Yes, it should work the same way it does if you remove the from the link One extra note: spaces should not be encoded inside links so for extra points make accepting a file suggestion with spaces in the name inserts a real space instead of
How do I recompile typescript files so vscode reflects the changes I made? Is it or ?
Is this the behavior you were looking for?
Change:
} if (!allowFullscreen) { <del> state.mode = WindowMode.Maximized; </del> <ins> state.mode = WindowMode.Normal; </ins> } }

Discussion:
https://user- Expect: <img width="1440" alt="Snipaste2022-08-2605-17-23" src="https://user-"Actual: <img width="1440" alt="Snipaste2022-08-2605-17-04" src="https://user-"
Yes, this was probably not a good change from me in
Change:
return TPromise.as(true); } <del> return (this.viewModel.isReplaceActive() && !!this.viewModel.replaceString) ? </del> <ins> const useReplacePreview = this.configurationService.getValue<ISearchConfiguration>().search.useReplacePreview; return (useReplacePreview && this.viewModel.isReplaceActive() && !!this.viewModel.replaceString) ? </ins> this.replaceService.openReplacePreview(lineMatch, preserveFocus, sideBySide, pinned) : this.open(lineMatch, preserveFocus, sideBySide, pinned); }

Discussion:
I think it should be possible to disable "Replace Preview" in the settings. Currently, whenever I want to replace a word, the "Replace Preview" opens for every file, because I have file preview disabled.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.546 --- <!-- score: 0.535 --- <!-- score: 0.489 --- <!-- score: 0.473 --- <!-- score: 0.46 --<!-- potentialduplicatescomment --
Are you talking about the diff editor that opens when you click a result? What do you expect to see in that case?
Yes that's what I'm talking about. I would like to see just the file without a diff, maybe with the matches highlighted as I navigate through them in the search sidebar. Then when I click on replacing the text it would just replace it directly.
This seems reasonable and I would take a PR that adds a setting to disable the replace preview. FYI Starting point: and
I'd like to take a look at this.
Change:
private cachedContentHeight: number | undefined; private maxHeight: number = Number.POSITIVE_INFINITY; private scrollableElement: ScrollableElement | undefined; <del> private hover: ICustomHover | undefined; </del> private _onDidChange = this._register(new Emitter<string>()); public readonly onDidChange: Event<string> = this._onDidChange.event;

Discussion:
todays insiders - run F1 or cmd+shift+o a hover shows and doesn't go away
Change:
return undefined; } <del> const actions = this.convertApplicableRefactors(response.body, document, rangeOrSelection); </del> <ins> const actions = this.convertApplicableRefactors(response.body, document, rangeOrSelection).filter(action => { // Don't show 'infer return type' refactoring unless it has been explicitly requested // https://github.com/microsoft/TypeScript/issues/42993 if (!context.only && action.kind?.value === 'refactor.rewrite.function.returnType') { return false; } return true; }); </ins> if (!context.only) { return actions; }

Discussion:
Companion of For the TS: The lightbulb is always shown inside of
The expected behavior is that you now have to go through the refactor menu to trigger this
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { raceTimeout } from 'vs/base/common/async'; </del> import { Disposable } from 'vs/base/common/lifecycle'; import { FileAccess } from 'vs/base/common/network'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.7.2 OS Version: windows Steps to Reproduce: a file with error on `cue: line has an error" settings the cursor to there
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
it still occurs with 1.73.1
yeah I can reproduce this issue. is this expected?
This is not expected. Sounds should be played when cursor is navigated to the error line. worked on this initially and might have more details
I also have the same problem, but this only occurs in the insider version, I have the latest version and no sound is played Issue:
They play in OSS, but not insider's. any idea why that would be?
if that is the case then it is probably related to code bundling. Does that sound play when you F1 list audio cues?
It does play when I list audio cues in both OSS and insider's.
It also plays for terminal quick fixes - suggesting there's a bug in because I can also repro it not playing for other line feature types
This has been working for me lately, though it was definitely broken at one pt.
I have set to I navigate to a line with an error-squiggle but there is no sound being played
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> use bytes::Buf; </ins> use tokio::{ io::{AsyncRead, AsyncReadExt, AsyncWrite, AsyncWriteExt, BufReader}, pin,

Discussion:
As noted by a tunnel something somewhat data intensive. Run a big notebook, or sometimes just opening a large workspace is enough the tunnel will become unresponsive
Change:
this.container.style.lineHeight = `${fontInfo.lineHeight}px`; let title = $('.title'); <del> let msg = $('.message'); const defaultConditionMessage = nls.localize('exceptionThrown', 'Exception has occurred.'); if (this.exceptionInfo.breakMode) { let conditionMessage; switch (this.exceptionInfo.breakMode) { case 'never': conditionMessage = nls.localize('neverException', 'User-handled exception has occurred.'); break; case 'always': conditionMessage = nls.localize('alwaysException', 'Always-breaking exception has occurred.'); break; case 'unhandled': conditionMessage = nls.localize('unhandledException', 'Unhandled exception has occurred.'); break; case 'userUnhandled': conditionMessage = nls.localize('userUnhandledException', 'User-unhandled exception has occurred.'); break; default: conditionMessage = defaultConditionMessage; break; } title.textContent = `${conditionMessage} ${this.exceptionInfo.description}`; msg.textContent = this.exceptionInfo.details.stackTrace; } else { title.textContent = defaultConditionMessage; msg.textContent = this.exceptionInfo.description; </del> <ins> switch (this.exceptionInfo.breakMode) { case 'never': title.textContent = nls.localize('neverException', 'User-handled exception has occurred: {0}', this.exceptionInfo.id); break; case 'always': title.textContent = nls.localize('alwaysException', 'Always-breaking exception has occurred: {0}', this.exceptionInfo.id); break; case 'unhandled': title.textContent = nls.localize('unhandledException', 'Unhandled exception has occurred: {0}', this.exceptionInfo.id); break; case 'userUnhandled': title.textContent = nls.localize('userUnhandledException', 'User-unhandled exception has occurred: {0}', this.exceptionInfo.id); break; default: title.textContent = this.exceptionInfo.id ? nls.localize('exceptionThrownWithId', 'Exception has occurred: {0}', this.exceptionInfo.id) : nls.localize('exceptionThrown', 'Exception has occurred.'); break; </ins> } dom.append(container, title); <del> dom.append(container, msg); </del> <ins> if (this.exceptionInfo.description) { let description = $('.description'); description.textContent = this.exceptionInfo.description; dom.append(container, description); } if (this.exceptionInfo.details && this.exceptionInfo.details.stackTrace) { let stackTrace = $('.stack-trace'); stackTrace.textContent = this.exceptionInfo.details.stackTrace; dom.append(container, stackTrace); } </ins> } protected _doLayout(heightInPixel: number, widthInPixel: number): void {

Discussion:
<!-- Do you have a question? Please ask it on --- Tests: VSCode Version: 1.11.0-insider OS Version: Windows Steps to Reproduce: debug as node app. Observe: exception widget is not showing. It does if I throw new Error ('Hello World')
Change:
margin-left: 10px; padding: 0px 4px; border-radius: 4px; <ins> user-select: none; </ins> } .extension-editor > .header > .details > .subtitle {

Discussion:
Bug Click on any extension in the extensions view to open the extensions editor Triple click on the extension id (next to the extension name) -the whole id gets selected Ctrl+C to copy and them paste elsewhere Expected: The extension id gets copy pasted Actual: The extension id along with everything that follows it gets copy pasted For eg: In the case of , the below gets copied to the clipboard ms- Preview Microsoft40,119RepositoryLicense An Azure Functions extension for Visual Studio Code. Install Details Contributions Changelog Dependencies VS Code version: Code - Insiders 1.20.0-insider (, 2018-02-06T15:20:43.871Z) OS version: Windows_NT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ Go0.6.73 vsliveshare0.2.66 debugger-for-chrome4.1.0 vscode-versionlens0.19.1 sass-indented1.4.6 language-stylus1.8.0 </detailsReproduces only with extensions
I would suggest to add and label to this one
This is a weird one . From my investigation if you give - to the element next to the tag ( which is the tag in this case ), it fixes selection for the . But this in-turn breaks again if you select tag. Any to suggestions on this? Attaching screenshot for the css - <img width="655" alt="screen shot 2018-02-10 at 3 03 48 pm" src="https://user-"
No idea :) You will have to play around with values for and understand how it behaves in different scenarios
Change:
this._history = new ResourceMap<HistoryNavigator2<string>>(); } <ins> matchesCurrent(uri: URI, value: string): boolean { const history = this._history.get(uri); if (!history) { return false; } return history.current() === value; } </ins> addToHistory(uri: URI, value: string): void { <del> if (!this._history.has(uri)) { </del> <ins> const history = this._history.get(uri); if (!history) { </ins> this._history.set(uri, new HistoryNavigator2<string>([value], 50)); return; } <del> const history = this._history.get(uri)!; </del> history.resetCursor(); <del> if (history?.current() !== value) { history?.add(value); } </del> <ins> history.add(value); </ins> } getPreviousValue(uri: URI): string | null { const history = this._history.get(uri); return history?.previous() ?? null;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --four cells from the interactive window input box, e.g. , , , reexecute multiple commands from earlier in your history, e.g. and use via the up arrow executing an entry from earlier in the history e.g. , scroll position resets to the bottom of the history, and you have to start over and scroll up from the most recent command (4 -3 - 2 -1). This can be frustrating for users who are trying to reexecute multiple commands. Note also that the original interactive window used to preserve your scroll history in the interactive window so that you didn't have to scroll back up through the entire history, and users have complained about this behavior change:
The expectation is that the interactive window input behaves just like a REPL. would address this. Per discussion with we should have shared logic for handing history traversal.
Any news on that? I agree with the PR that the current behavior is quite frustrating and deserves further attention.
Yes this is one of my main frustrations with the IW still. At minimum I just want the up arrow to go to the last executed code, not have cycle through like 20 cells every time I need to re-run something. And it did used to work this way ~1.5 yrs ago.
Change:
private createMarkerDatas(diagnostics: Proto.Diagnostic[], source: string): Diagnostic[] { const result: Diagnostic[] = []; for (let diagnostic of diagnostics) { <del> let { start, end, text } = diagnostic; let range = new Range(start.line - 1, start.offset - 1, end.line - 1, end.offset - 1); let converted = new Diagnostic(range, text); converted.source = source; </del> <ins> const { start, end, text } = diagnostic; const range = new Range(start.line - 1, start.offset - 1, end.line - 1, end.offset - 1); const converted = new Diagnostic(range, text); converted.severity = this.getDiagnosticSeverity(diagnostic); converted.source = diagnostic.source || source; </ins> converted.code = '' + diagnostic.code; result.push(converted); } return result; } <ins> private getDiagnosticSeverity(diagnostic: Proto.Diagnostic): DiagnosticSeverity { switch (diagnostic.category) { case PConst.DiagnosticCategory.error: return DiagnosticSeverity.Error; case PConst.DiagnosticCategory.warning: return DiagnosticSeverity.Warning; default: return DiagnosticSeverity.Error; } } </ins> }

Discussion:
The video below demonstrates tslint running as a language server plugin. Notice that the tslint warnings show up as errors. However, in the code the DiagnosticCategory is set to . ! This is the code that creates the diagnostic
Looks like we don't set a severity on the diagnostics which causes them to all be marked as errors. Looking into fixing this
Hmm, I don't see a field on normal objects in the TSServer protocol, only on . Let me see if this field is sent anyways when you explicitly set in the TSLint plugin
I've opened to track adding to the objects that tsserver returns to us. This seems like an oversight in the current protocol
Change:
width: auto; padding: 4px 10px; align-self: flex-end; <del> margin-bottom: 10px; </del> <ins> margin-bottom: 1em; </ins> font-size: 13px; }

Discussion:
!
is this in OSS or in insiders?
This was oss
yep, this is a known issue in OSS with the css bundling. it ends up fine in Insiders and stable, but unsure why this has been the case for a while now. same as i believe
They still happen in insiders, just the button width isn't the same for some reason (you could inspect the element in devtools to diff the styles): !
Change:
getAccessibilitySupport(): AccessibilitySupport; setAccessibilitySupport(accessibilitySupport: AccessibilitySupport): void; alert(message: string): void; <ins> status(message: string): void; </ins> } export const enum AccessibilitySupport {

Discussion:
Testing While testing I noticed that when I moved my cursor on a line with an error, the word was read, but the contents of that line were no longer read. I was wondering if this is intended? I noticed that sometimes the beginning of the text on the line is read, before it breaks off and reads the alerts.
I noticed that sometimes when I put my cursor on a line with a breakpoint, it does not read the word . Is the alert only supposed to sound at specific moments? Ie, for example the first time the cursor is placed on an active line with a breakpoint?
alerts interrupt whatever else might be read by design. And yes, it looks like in your case, you're using mouse clicks vs arrow keys to navigate between the lines. We listen to arrow keys, thus it's expected that you wouldn't hear the cues.
Additionally, I have checked with our power SR users and the alerts are working as expected in the editor.
I am going to open an issue to get more feedback on this.
Hi thank you for the clarification, that makes sense.
We are going to use instead here because editor content is the priority.
Change:
private _onGroupFocusChanged: Emitter<void>; <ins> private onStacksChangeScheduler: RunOnceScheduler; private stacksChangedBuffer: IStacksModelChangeEvent[]; </ins> private toDispose: IDisposable[]; constructor(

Discussion:
For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.
I merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !
I can verify
LGTM - will push the revert revert commit
Verified via
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import * as nls from 'vs/nls'; </del> import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { IDisposable } from 'vs/base/common/lifecycle'; <ins> import * as nls from 'vs/nls'; </ins> import { ICommandService } from 'vs/platform/commands/common/commands'; <ins> import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> import { ILogService } from 'vs/platform/log/common/log'; import { IWorkspaceTrustRequestService } from 'vs/platform/workspace/common/workspaceTrust'; import { SELECT_KERNEL_ID } from 'vs/workbench/contrib/notebook/browser/controller/coreActions';

Discussion:
Testing microsoft/vscode-jupyter 1) Open 1) Install Jupyter and Python extensions 1) Create a new untitled jupyter notebook 1) Create a markdown cell 1) Paste image 1) <kbdCtrl</kbd+<kbdEnter</kbd-I get a prompt for installing kernels from the market place. <img width="925" alt="image" src="https://user-"This is wrong for two reasons: 1) Since the Jupyter extension is installed I should be able to connect the notebook to a kernel on a remote server. Also see 1) This is a markdown cell. No kernel needed for rendering a markdown cell.
I'm not seeing this locally but I can reproduce with Not sure where is the best place to check whether the cells are markdown cells.
Change:
: localize('title2', "Search {0} u2014 {1}", windowTitle.workspaceName, windowTitle.value); this._applyUpdateTooltip(title); } <ins> } return instantiationService.createInstance(InputLikeViewItem, action, { hoverDelegate }); </ins> <del> private _renderAllQuickPickItem(parent: HTMLElement): void { const container = document.createElement('span'); container.classList.add('all-options'); parent.appendChild(container); const action = new Action('all', localize('all', "Show Search Modes..."), Codicon.chevronDown.classNames, true, () => { quickInputService.quickAccess.show('?'); }); const dropdown = new ActionViewItem(undefined, action, { icon: true, label: false, hoverDelegate }); dropdown.render(container); this._store.add(dropdown); this._store.add(action); </del> <ins> } else if (action instanceof MenuItemAction && action.id === 'commandCenter.help') { class ExtraClass extends MenuEntryActionViewItem { override render(container: HTMLElement): void { super.render(container); container.classList.add('quickopen', 'right'); </ins> } } <del> return instantiationService.createInstance(InputLikeViewItem, action, { hoverDelegate }); } return createActionViewItem(instantiationService, action, { hoverDelegate }); </del> <ins> return instantiationService.createInstance(ExtraClass, action, { hoverDelegate }); } else { return createActionViewItem(instantiationService, action, { hoverDelegate }); } </ins> } }); const menu = this._disposables.add(menuService.createMenu(MenuId.CommandCenter, contextKeyService));

Discussion:
hitting tab and shift tab to get to the "command center group" and then arrow keys once in that group. !
Change:
import { DisposableStore } from './util'; import { getPermalink } from './links'; <ins> async function copyVscodeDevLink(gitAPI: GitAPI, useSelection: boolean) { try { const permalink = getPermalink(gitAPI, useSelection, 'https://vscode.dev/github'); if (permalink) { return vscode.env.clipboard.writeText(permalink); } } catch (err) { vscode.window.showErrorMessage(err.message); } } </ins> export function registerCommands(gitAPI: GitAPI): vscode.Disposable { const disposables = new DisposableStore();

Discussion:
Testing Of course, there may have been discussions and reasons for the current behavior, but I was surprised that the share action in the File menu linked to the line number of the currently opened editor. I was expecting a link to the workspace/repository only.
would you expect the same command from the editor context menu to use file+line number?
yes, my expectation would be the context menu has the "context" and therefore does have the file/line associated with it.