jiebi/CodeConvo huggingface dataset:
Change:
.open-editors .monaco-list .monaco-list-row.dirty:not(:hover) > .monaco-action-bar .codicon-pinned::before { content: "ebb2"; /* use `pinned-dirty` icon unicode for sticky-dirty indication */ <ins> font-family: 'codicon'; </ins> } .open-editors .monaco-list .monaco-list-row.dirty:not(:hover) > .monaco-action-bar .codicon-close::before { content: "ea71"; /* use `circle-filled` icon unicode for dirty indication */ <ins> font-family: 'codicon'; </ins> } .open-editors .monaco-list .monaco-list-row > .monaco-action-bar .action-close-all-files,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (N/A) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0 OS Version: Windows 11 (according to VSC, Windows_NT x64 10.0.) In a Product Icon Theme I am developing (), I am observing strange icons appearing where they shouldn't, as a result of some static styles in the application not being aware of custom font glyphs in product icon themes. ! As an example, the icon of a dirty tab renders as a couch icon when my theme is applied. In my theme's font, the couch happens to be the glyph at unicode . This occurs despite my file correctly defining the close icon as: ! In most situations, my product icons appear correctly. But certain cases, many of which appear to be overridden by hard-coded unicode code points in static CSS files associated with the Editor, it does not. I believe this stylesheet below is the culprit in the example above:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
We need to avoid hardcode characters in CSS. So, if possible remove. If not easily possible, add ` rule. It looks like there's a close icon set that is properly themed and that sets the font family.
There is a bit of a trick going on here. We are overwriting the close codicon with the dirty codicon when the file is dirty and the action is not being hovered.

It's rather complex to solve this without hardcoding the value in css. I'll temporarly fix it by adding the font family and I'll try to think of a more elegant solution for this.
Change:
return undefined; } <del> const pickedMimeTypeRenderer = mimeTypes[pick]; const innerContainer = this._generateInnerOutputContainer(previousSibling, pickedMimeTypeRenderer); </del> <ins> const selectedPresentation = mimeTypes[pick]; let renderer = this.notebookService.getRendererInfo(selectedPresentation.rendererId); if (!renderer && selectedPresentation.mimeType.indexOf('text/') > -1) { renderer = this.notebookService.getRendererInfo('vscode.builtin-renderer'); } const innerContainer = this._generateInnerOutputContainer(previousSibling, selectedPresentation); </ins> this._attachToolbar(innerContainer, notebookTextModel, this.notebookEditor.activeKernel, index, mimeTypes); this.renderedOutputContainer = DOM.append(innerContainer, DOM.$('.rendered-output')); <del> const renderer = this.notebookService.getRendererInfo(pickedMimeTypeRenderer.rendererId); </del> this.renderResult = renderer <del> ? { type: RenderOutputType.Extension, renderer, source: this.output, mimeType: pickedMimeTypeRenderer.mimeType } : this._renderMissingRenderer(this.output, pickedMimeTypeRenderer.mimeType); </del> <ins> ? { type: RenderOutputType.Extension, renderer, source: this.output, mimeType: selectedPresentation.mimeType } : this._renderMissingRenderer(this.output, selectedPresentation.mimeType); </ins> <del> this.output.pickedMimeType = pickedMimeTypeRenderer; </del> <ins> this.output.pickedMimeType = selectedPresentation; </ins> if (!this.renderResult) { this.viewCell.updateOutputHeight(index, 0, 'CellOutputElement#renderResultUndefined');

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --Currently, if a notebook kernel outputs or some other mime type for which there is no registered renderer, a message is shown instead of the output. For mime types, the output should be rendered as plain text.
This is a really good idea.
After more than a year, I still think this is a very interesting idea that's worth a try. We might need to add match for mimetypes for the output renderer contribution. I assigned this to you for now.
Change:
quickpick.title = 'Marketplace Themes'; quickpick.placeholder = localize('themes.selectMarketplaceTheme', "Type to Search More. Select to Install. Up/Down Keys to Preview"); quickpick.canSelectMany = false; <del> quickpick.onDidChangeValue(() => this.trigger(quickpick.value)); quickpick.onDidAccept(async _ => { </del> <ins> disposables.add(quickpick.onDidChangeValue(() => this.trigger(quickpick.value))); disposables.add(quickpick.onDidAccept(async _ => { </ins> const themeItem = quickpick.selectedItems[0]; if (themeItem?.galleryExtension) { result = 'selected';

Discussion:
Quick pickers are itself disposables, as well as the events they provide. Noticed a few leaks around picker instances and/or events: //cc
There's already a that is called when the picker hides. Isn't that good enough?
see the various events (those beginning with ) and how they are not getting disposed.
But they are going to an emitter that is owned by the quickpick. Disposing the quickpick is also disposed all its emitters. There's no real leak here.
my understanding is that an that gets disposed (when you dispose the quick picker) does not dispose the -functions it had returned, i.e. this code is not running: But maybe or can also chime in.
Yes - an emitter doesn't dispose its listeners. you basically rely on GC'ing here and I am uncertain if that actually works (e.g some disposables are tracked centrally for later blaming). I understand your motives but we generally dispose all the things
Change:
*/ onDidSelectConfiguration: Event<void>; <ins> /** * Allows to register on change of selected debug configuration. */ onDidChangeConfigurationProviders: Event<void>; </ins> hasDebugConfigurationProvider(debugType: string, triggerKind?: DebugConfigurationProviderTriggerKind): boolean; getDynamicProviders(): Promise<{ label: string; type: string; pick: () => Promise<{ launch: ILaunch; config: IConfig } | undefined> }[]>;

Discussion:
Type: <bBug</bI'm developing an extension for VSCode and found out that I can't enable Dynamic Debug Configurations unless I include in the list of activation events. I have tried not including this activation event but having my extension activated through other means (like activated on language), but the feature doesn't work. Only when I include , this feature works. My extension is now working properly, but I wouldn't be surprised if this prevents other extension developers from using this feature. I have found this very old post of someone who might have had that exact same issue VS Code version: Code 1.84.2 (Universal) (, 2023-11-09T10:52:33.687Z) OS version: Darwin arm64 23.1.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (36)</summaryExtensionVersion ------ vscode-markdownlint0.52.0 gitlens14.5.0 prettier-vscode10.1.0 custom-local-formatters0.0.6 vscode-clangd0.1.24 vscode-mlir0.0.11 rainbow-csv3.8.0 vscode-mojo5.0.4-dev csdevkit1.0.14 csharp2.10.28 vscode-dotnet-runtime2.0.0 vscodeintellicode-csharp0.1.26 black-formatter2023.6.0 isort2023.10.1 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.10.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.321.0 remote-ssh0.107.0 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 cpptools1.18.5 cpptools-extension-pack1.3.0 remote-explorer0.4.1 remote-server1.5.0 reflow-paragraph1.3.0 errorlens3.15.0 vscode-icons12.6.0 vim1.27.0 clang-format1.9.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you explain a bit more what doesn't work?
, thanks for looking into this. I have an extension with a working debugger feature via file. I'm trying to register a DebugConfigurationProvider with kind = that implements . And, unless, I add as an activation event, my new provider doesn't get invoked at all and I don't see an entry for my debugger in the selector of the Debug View. I have confirmed that my extension was initialized right after VSCode is launched. It's as if this kind of provider is only enabled if the activation event is present.
There's some discussion about this in you've touched this too, should this be changed or just documented in
I think changing it is fine. An extension should register an activation for it, but this isn't something we enforce for any other API. Will take care of it.
Change:
} async restoreForwarded() { <ins> this.cleanupExpiredTunnelsForRestore(); </ins> if (this.configurationService.getValue('remote.restoreForwardedPorts')) { const tunnelRestoreValue = await this.tunnelRestoreValue; if (tunnelRestoreValue && (tunnelRestoreValue !== this.knownPortsRestoreValue)) { <del> const tunnels = <Tunnel[] | undefined>JSON.parse(tunnelRestoreValue) ?? []; </del> <ins> const tunnels = <RestorableTunnel[] | undefined>JSON.parse(tunnelRestoreValue) ?? []; </ins> this.logService.trace(`ForwardedPorts: (TunnelModel) restoring ports ${tunnels.map(tunnel => tunnel.remotePort).join(', ')}`); for (const tunnel of tunnels) { const alreadyForwarded = mapHasAddressLocalhostOrAllInterfaces(this.detected, tunnel.remoteHost, tunnel.remotePort);

Discussion:
I had to clear settings sync for an unrelated issue and start fresh, but enabling the "UI State" option causes the error below to be continually thrown. If I disable the "UI State" option in settings sync, it starts working again. Type: <bBug</bsettings sync, check all boxes except "UI State" settings sync log, see that it succeeds settings sync config to include UI State VS Code version: Code 1.85.1 (Universal) (, 2023-12-13T09:48:06.308Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ erb0.0.1 vscode-eslint2.4.2 prettier-vscode10.1.0 codespaces1.16.6 copilot1.148.0 copilot-chat0.11.1 vscode-graphql-syntax1.2.3 endwise1.5.1 remote-containers0.327.0 proto0.0.4 rewrap1.16.3 gitblame10.6.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you please share the UI state using following steps F1 Export Profile... Select only UI state Export the profile and share it
The exported file is 2.3 MB, and it has some things inside that might be considered sensitive, I'm not sure. Is there a way I can share it privately?
You can share it to me by email - 2.3 MB is way under the limits right?
Just emailed the file, thank you!
I just checked the size limits on the server and it is indeed 2MB caps
Thanks for sharing. I figured out that port forwarding state is taking majority of the size. Hence assigning to
Discussed with and there are 3 easy things I can do to quickly reduce the size: Don't save empty values Add an expiry time to values so they don't live forever Save fewer fields per port in . For example, only tunnels should be stored + restored, so should be removed. So should , , , and .
the limit per resource version is 2mb atm
Are there steps to verify this?

To verify: to a Codespace and forward a port the remote connection the steps in to collect a profile the file created in step 3. Check that the port that you just forwarded in step 1 is listed there under a key and that it doesn't have a value.
For the step, does this mean to stop the codespace?
This is verified. The new port forwarded doesn't have , but I did notice some old ports of mine from old codespaces still having . Not sure if that was expected to be covered.
The behavior you see is expected. I didn't add any cleanup of the old state.
Change:
line-height: 0; } <del> ul ul, ul ol, ol ul, ol ol { </del> <ins> ul ul:first-child, ul ol:first-child, ol ul:first-child, ol ol:first-child { </ins> margin-bottom: 0; }

Discussion:
Type: <bBug</bHere's the markdown content. The following are the effects rendered in different software / website Visual Studio Code ! Visual Studio ! Github a Properties: id href Defines a hyperlink form Stackoverflow ! As you can see in Visual Studio Code, there's a big gap before the sub list, but there's a small gap after the sub list. Now it's too ugly, I think they should at least be consistent. BTW, different themes have no impact on this. VS Code version: Code 1.81.1 (, 2023-08-09T22:22:42.175Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Change:
export default class LinkProvider implements vscode.DocumentLinkProvider { private readonly linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|(S*?))+)s*(".*?")?)/g; private readonly referenceLinkPattern = /([((?:]|[^]])+)][s*?)([^s]]*?)]/g; <del> private readonly definitionPattern = /^([t ]*[((?:]|[^]])+)]:s*)(S+)/gm; </del> <ins> private readonly definitionPattern = /^([t ]*[(?!^)((?:]|[^]])+)]:s*)(S+)/gm; </ins> public provideDocumentLinks( document: vscode.TextDocument,

Discussion:
(Apologize in advance if this is the wrong place to file this, I'm having trouble tracking down the right place.) When I make a Markdown footnote, like the first word or letter is underlined and when I right-click it it offers to . <img width="473" alt="image" src="https://user-"
VS Code's built-in markdown extension targets standard markdown, which doesn't include footnote support. As a compromise, we could update the regular expression the built-in markdown extension uses to find clickable links to exclude links starting with Starting point in code:
Yeah, thanks. That's an understandable perspective. I might do a PR for this myself. One question that still confuses me though, why does it say "Execute command" (and not "Follow link" like other links show)? <img width="597" alt="Follow Link" src="https://user-"
First day looking at the code base, so I could be off on this, but looks like the logic for when "Execute Command" is displayed is in this function: Also, are you planning on doing a PR for this still? If not I can do it.
Thanks for the additional info! Please go ahead if you're ready to work on a PR now.
I may be wrong about this, however it seems to me the problem is with how validates a definition link. In the image below notice how the last line is considered valid, and would have a tooltip and underline in the editor. ! The regex produces a valid match since the last capture group ignores everything past the first space after the link. What if we modified the expression to something like this? (tests pass) !
Yes looks like the regular expression may just need to be updated, either to check that there are not multiple words after the references or to check that the definition does not start with
Change:
'tabindex': 0, 'x-dispatch': 'hideCategory:' + category.id, 'title': localize('close', "Hide"), <ins> 'role': 'button', 'aria-label': localize('closeAriaLabel', "Hide"), </ins> }), ), descriptionContent,

Discussion:
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.1; #Parsing Visual Studio Code Windows 11 Pro version 21H2 (OS Build .856) 1)Open Visual studio code editor 2)Using "Alt+H" key navigate to the "Help" menu bar option . 3)Using "Down" arrow key navigate to the "Welcome" item. 4) Make sure you have the following setting in "workbench.startupEditor": "gettingStarted" 5)Using "Alt+H" navigate to "Help" menu bar option and use "down" arrow key to navigate to "Getting started" and observe that the Get started with VS Code button has a link inside it or not. Get started with VS Code button has a link inside it. There should not be any link inside the Get started with VS Code button. !
can we make sure that we set the on the x in the welcome view. I believe it is very low hanging and is affecting our grade thus assigning to November. Thanks!

A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.2; #Name Role Value Visual Studio Code Windows 11 Pro version 21H2 (OS Build .856) 1)Open Visual studio code editor 2)Using "Alt+H" key navigate to the "Help" menu bar option . 3)Using "Down" arrow key navigate to the "Welcome" item. 4) Make sure you have the following setting in "workbench.startupEditor": "gettingStarted" 5)Using "Alt+H" navigate to "Help" menu bar option and use "down" arrow key to navigate to "Getting started" and observe that the correct name is defined for the "cancel" or "hide" button. The Correct name is not defined for the "cancel" or "hide" button. The correct name should be defined for the "cancel" or "hide" button. !
For me the correct title gets read out by VoiceOver or NVDA - it is Hide. can you just make sure to also set the on the element? This is affecting our Accessibility Grade and I think it is a very low hanging fix - thus assigning to November for now.
has planned the accessibility work for the welcome view for the new team member. I'll ask them to verify this fix
Change:
@INativeHostService private readonly nativeHostService: INativeHostService, @IPreferencesService private readonly preferencesService: IPreferencesService, @IExplorerService explorerService: IExplorerService, <del> @IUriIdentityService uriIdentityService: IUriIdentityService </del> <ins> @IUriIdentityService uriIdentityService: IUriIdentityService, @IProductService private readonly productService: IProductService </ins> ) { super(telemetryService, fileService, viewletService, instantiationService, contextService, storageService, textResourceConfigurationService, editorService, themeService, editorGroupService, textFileService, explorerService, uriIdentityService); }

Discussion:
Issue Type: <bBug</bWhat's "it" here? I assume it means VS Code. Should probably be explicit. VS Code version: Code 1.55.2 (, 2021-04-13T09:36:32.643Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ vscode-sqlite0.12.0 rainbow-csv1.8.1 dotenv1.0.1 vscode-js-profile-flame0.0.15 material-icon-theme4.6.0 rewrap1.14.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
.traceback.wordWrap span { white-space: pre-wrap; } <del> .output > .scrollable { </del> <ins> .output .scrollable { </ins> overflow-y: scroll; max-height: var(--notebook-cell-output-max-height); border: var(--vscode-editorWidget-border);

Discussion:
It should be outside of the output region <img width="962" alt="image" src="https://user-"
Change:
const previouslyCutItems = this.cutItems; this.cutItems = cut ? items : undefined; await this.clipboardService.writeResources(items.map(s => s.resource)); <ins> if (items.length === 1) { await this.clipboardService.writeText(items[0].name); } </ins> this.view?.itemsCopied(items, cut, previouslyCutItems); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.85.0 Commit: Date: 2023-12-06T18:17:50.719Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.1.0 macOS Version: macOS Sonoma 14.1.1 Steps to Reproduce: a file(Command-C) in VS Code explorer in VS Code explorer (Command-P) in VS Code explorer Code not respond Gif reproduce steps: !
Can reproduce on Windows 10 22H2: <img width="1308" alt="image" src=""The copied file will be created () and then the application freezes.
I'm unable to get a crash dump, but there are some logs when I run
Change:
@IPathService private readonly pathService: IPathService, @IConfigurationService private readonly configurationService: IConfigurationService, @IPreferencesService protected readonly preferencesService: IPreferencesService, <del> @IHostService private readonly hostService: IHostService </del> <ins> @IHostService private readonly hostService: IHostService, @IFilesConfigurationService private readonly filesConfigurationService: IFilesConfigurationService </ins> ) { super(TextFileEditor.ID, telemetryService, instantiationService, storageService, textResourceConfigurationService, themeService, editorService, editorGroupService, fileService);

Discussion:
Type: <bBug</ba readonly file system opening a file that does not exist. You can use the command for this bug A diaglogdialog shows that includes an option for <img width="345" alt="Screenshot 2024-01-23 at 10 38 49 AM" src=""Clicking on this option shows a second dialog that says the file cannot be created: <img width="312" alt="Screenshot 2024-01-23 at 10 39 02 AM" src=""I think it would be better not to show file in the first dialog VS Code version: Code - Insiders 1.86.0-insider (Universal) (, 2024-01-23T06:13:09.134Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
export enum MarkerTag { <del> Unnecessary = 1 </del> <ins> Unnecessary = 1, Deprecated = 2 </ins> } export enum MarkerSeverity {

Discussion:
Now that has been to the API, I would like to support the proposal from to use it for tagging deprecated items. I figure the associated styling might be a strikethrough as proposed in but you guys can work that out separately.
I would be interested in helping out here with this and perhaps even . Without a lot of context, I assume this issue is specifically to add a new enum member here: I could open a PR that adds a member, if that's the case. edit: Looks like more applicable location would be and then opening a similar PR to
Yes, is the way to go. Find your way along usages/implementations of
Thanks, I'll work on that today.
Leaving this open so that we discuss this in the API sync
API has been finalised.