jiebi/CodeConvo huggingface dataset:
Change:
{ "command": "git.viewChanges", "title": "View Changes", <del> "icon": "$(search)", </del> <ins> "icon": "$(tasklist)", </ins> "category": "Git" }, { "command": "git.viewStagedChanges", "title": "View Staged Changes", <del> "icon": "$(search)", </del> <ins> "icon": "$(tasklist)", </ins> "category": "Git" } ],

Discussion:
I found it confusing that the icon for opening multi-diff editor is a magnifying glass. Should it maybe match GHPR's icon or have some other icon? !
Fixed in , uses this icon now: ! FYI Maybe we should create a new icon for this though
Change:
} }; <del> if (this._state.replaceString.length === 0) { return; } </del> if (e.isReplaceRevealed) { updateEditingState();

Discussion:
Testing I find the current transition very harsh. Can we instead transition to edit mode once the user clicks on the Replace button? That way the transition will not be so rough. It will be triggered later, and by user pressing a button. Not by typing.
Yeah, the thinking behind this having the switch less often if possible, but I agree with you that current behavior can be very unexpected.
Change:
const isUri = URI.isUri(resourceOrContext); const editorCommandsContext = isUri ? context : resourceOrContext ? resourceOrContext : context; <del> if (editorCommandsContext) { </del> <ins> if (editorCommandsContext && isEditorCommandsContext(editorCommandsContext)) { </ins> return editorCommandsContext; }

Discussion:
Type: <bBug</bThe following user task running on stopped working correctly after the update to 1.90. The first task (Open Git Graph) executes correctly, but the second (Pin Active Editor) doesn't do anything. The tab isn't pinned.

VS Code version: Code 1.90.0 (, 2024-06-04T19:34:44.157Z) OS version: Darwin x64 23.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (46)</summaryExtensionVersion ------ better-comments3.0.2 turbo-console-log2.10.4 npm-intellisense1.4.5 vscode-eslint2.4.4 dotfiles-syntax-highlighting0.1.0 antidote1.0.21 gitlens15.0.4 EditorConfig0.16.4 react-native-react-redux2.0.6 prettier-vscode10.4.0 code-runner0.12.2 codespaces1.16.22 vscode-github-actions0.26.3 vscode-pull-request-github0.88.1 vscode-graphql-syntax1.3.6 nix-ide0.3.1 svg1.5.3 md-footer1.0.2 vscode-go-to-mdn1.2.0 caddyfile-support0.4.0 template-string-converter0.6.1 git-graph1.30.0 dotenv1.0.1 debugpy2024.6.0 python2024.8.0 vscode-pylance2024.5.1 remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-explorer0.4.3 color-highlight2.8.0 vscode-versionlens1.13.0 ansible24.5.2 vscode-yaml1.14.0 vscode-fileutils3.10.3 vscode-styled-components1.7.8 even-better-toml0.19.2 d20.8.8 lorem-ipsum1.3.1 ulss1.0.2 vscode-mdx1.8.8 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 vscode-icons12.8.0 vscode-import-cost3.3.0 markdown-all-in-one3.6.2 material-theme3.17.2 (2 theme extensions excluded) </details<!-- generated by issue reporter --
Same here. I have the same script and it is not working anymore on linux ubuntu In Windows 11 it still works apparently (when Vscode does not opens as SSH, but directly in windows instead)
Change:
import { LanguageConfigurationRegistry } from 'vs/editor/common/modes/languageConfigurationRegistry'; import { getLeadingWhitespace, commonPrefixLength, isFalsyOrWhitespace, pad } from 'vs/base/common/strings'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <ins> import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import { isSingleFolderWorkspaceIdentifier, toWorkspaceIdentifier, WORKSPACE_EXTENSION } from 'vs/platform/workspaces/common/workspaces'; </ins> export const KnownSnippetVariableNames = Object.freeze({ 'CURRENT_YEAR': true,

Discussion:
It would be really helpful if a variable with the repository name (workspace name or opened folder) that was available to use in the snippets. In my case, i use the snippets to create copyright messages, and i am using the project name (the same of the repository) as part of this message.
Hey I'd like to work on this. Can I give it a shot? I appreciate if you have any quick guidance.
Snippet variables are implemented and instantiated . add a variable resolver that uses the (like the and ) add a test here
Thanks :)
Change:
function listFocusLast(accessor: ServicesAccessor, options?: { fromFocused: boolean }): void { const focused = accessor.get(IListService).lastFocusedList; <del> // Ensure DOM Focus ensureDOMFocus(focused); </del> // List if (focused instanceof List || focused instanceof PagedList) { const list = focused;

Discussion:
I like the up / down keyboard navigation over notebook cells, but when you try to use to navigate the order is very unexpected. a notebook. I am using my- my work cell -Focus is on GitHub issues label -focus seems lost -focus is on the start of the document, even though I did not traverse until the end of the docuemnt Ideally tab should go in visual order. If that is not possible should move focus out of the notebook. Similarly tree tab is not used to move focus so users use up / down, but pressing tab focuses out of the tree and does not lead to unexpected jumping of focus.
Fixed in this change Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell (step 3 in OP) Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in )
Much better now. Thanks for fixing this.
Change:
constructor( private readonly _replView: Repl, private readonly _focusedElement: IReplElement | undefined, <del> @IDebugService private readonly _debugService: IDebugService, </del> @IAccessibleViewService private readonly _accessibleViewService: IAccessibleViewService) { super(); this._treeHadFocus = !!_focusedElement; } public provideContent(): string { <del> const viewModel = this._debugService.getViewModel(); const focusedDebugSession = viewModel?.focusedSession; if (!focusedDebugSession) { return 'No debug session is active.'; </del> <ins> const debugSession = this._replView.getDebugSession(); if (!debugSession) { return 'No debug session available.'; </ins> } <del> const elements = focusedDebugSession.getReplElements(); </del> <ins> const elements = debugSession.getReplElements(); </ins> if (!elements.length) { return 'No output in the debug console.'; }

Discussion:
Testing a js file at the root that something. a launch config to run it using node like: it and see the logs persist in the debug console.] to use alt+f2 to read it 'no debug session is active' !
is there a way to get the from an inactive session?
Reviewing the code some more I think the more reliable way to get the displayed session is to use . Currently it uses viewModel.focusedSession which won't include ended sessions as Andrea found
I think that will be a little involved, so deferring
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
"dockerfile": "_docker_light", "ignore": "_git_light", "fsharp": "_f-sharp_light", <ins> "git-commit": "_git_light", </ins> "go": "_go2_light", "groovy": "_grails_light", "handlebars": "_mustache_light",

Discussion:
Testing Current: ! Proposal: !
Spoke with and I have submitted to add the file icon association to seti-ui repository.
Change:
public readonly input1CombinedDiff = DetailedLineRangeMapping.join(this.input1Diffs); public readonly input2CombinedDiff = DetailedLineRangeMapping.join(this.input2Diffs); <ins> public readonly isEqualChange = equals(this.input1Diffs, this.input2Diffs, (a, b) => a.getLineEdit().equals(b.getLineEdit())); </ins> constructor( public readonly baseRange: LineRange,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: WindowsNT x64 10.0. Steps to Reproduce: a struct with some fields and functions in one branch the same struct in another branch, with a minor difference in one of the fields. the branches and open the merge editor. Accept Combination. On this example, is on the left side and on the right side. I'd expect "Accept Combination" to have only a single copy for the matching lines, and duplicate only the different line (and then I'd choose which one to keep), but it duplicates the entire struct. !
I also see that deleted/deleted is considered a conflict. I see no reason why. !
I also had duplicated code on two occasions when rebasing after the new VSCode update (and that's why I searched for this issue here). It seems that it kept the old code and the new code and didn't complain or considered a change/conflict. I still haven't used , so this duplication happened without using this new feature. In both situations, I had to manually remove the old code. If I find this situation again I will add here its screenshots.
Thanks,
Thank you!
Verification steps: Use the command to open that JSON and notice that conflicts with equal changes on both sides are auto-resolved.
Change:
if (sessionData) { this._persistedSessions = this.deserializeChats(sessionData); const countsForLog = Object.keys(this._persistedSessions).length; <del> this.trace('constructor', `Restored ${countsForLog} persisted sessions`); </del> <ins> if (countsForLog > 0) { this.trace('constructor', `Restored ${countsForLog} persisted sessions`); } </ins> } else { this._persistedSessions = {}; <del> this.trace('constructor', 'No persisted sessions'); </del> } this._transferred = this.getTransferredSession();

Discussion:
Repro: OSS trace logs window ! I don't have copilot installs in OSS so I wouldn't expect anything to happen here. Not sure what the 2 chars are.
Probably
Change:
lineMatcher: GitPushOutputRegex, anchor: 'bottom', offset: 0, <del> length: 5 </del> <ins> length: 15 </ins> }, commandExitResult: 'error', getQuickFixes: (matchResult: ITerminalCommandMatchResult) => {

Discussion:
going to keep track of examples here to see if there's a pattern <img width="1112" alt="Screenshot 2023-01-23 at 2 12 18 PM" src="https://user-"
far right terminal <img width="1120" alt="Screenshot 2023-01-23 at 3 07 17 PM" src="https://user-"
middle terminal !
far right terminal !
far right terminal <img width="1076" alt="Screenshot 2023-01-24 at 1 59 40 PM" src="https://user-"
right terminal <img width="1644" alt="Screenshot 2023-01-24 at 2 22 27 PM" src="https://user-"
right terminal !
here are the lines when there's not a quick fix result - it contains after which we don't account for here !
Seeing this frequently: <img width="726" alt="image" src="https://user-"
I think we just need to include the to fix this
or better yet, remove and just look for the link
ok I see the issue. when lines are wrapped a lot, we need to search more lines - setting the length to 10/15 fixes it even when the terminal is quite narrow
I see it on non-wrapped lines, I'm not sure I understand what you mean with the To?
The to comment above was actually wrong. What's happened in the screen shot above is we abort the search early - after looking at only 5 lines. When it's actually on line 9
this goes wrong when we break before reaching the content IE when line count length
I tried pushing up a new branch using pwsh in the integrated terminal on Windows, and the lightbulb did not show. !
you have shell integration disabled, it won't work at all there.
also make sure to not move issues to the next milestone, this one was marked important
Working much better now, but just reproduced !
Just happened and captured the trace log (escape sequence log would be better): <img width="806" alt="image" src="https://user-"
I've seen this not work twice today already for create PR !
even though the lightbulb didn't appear here, there was a match found !

the match always happens, the lightbulb doesn't show up though until I resize the terminal
this happens when the have not yet been resolved by the time occurs ! !
I think we should be calling at the end of
have seen the create PR not show up 3 times today. resizing doesn't cause it to show up, which means our match range is wrong/ there isn't a match
this says unreleased, but was merged before the current version of insider's (5 hours ago) was released. create with PR still failing !
insider's is based on the release branch, so I was confused
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
.monaco-editor .rename-box .rename-input { padding: 3px; width: calc(100% - 6px); <ins> border-radius: 2px; </ins> } .monaco-editor .rename-box .rename-label {

Discussion:
Looking at ways to make VS Code feel ever so slightly more approachable. A subtle 2px border radius on our common input components could be one way to make the UI feel more inviting and less harsh: <img width="361" alt="CleanShot 2022-04-08 at 14 48 52 src="https://user-"<img width="522" alt="CleanShot 2022-04-08 at 14 55 52 src="https://user-"<img width="494" alt="CleanShot 2022-04-08 at 14 58 01 src="https://user-"<img width="437" alt="CleanShot 2022-04-08 at 14 49 46 src="https://user-"<img width="500" alt="CleanShot 2022-04-08 at 15 01 55 src="https://user-"! FWIW, we already use a border radius on our icon buttons: <img width="300" alt="CleanShot 2022-04-08 at 15 03 36 src="https://user-"cc
I like this idea for buttons. I am not so sure about input/combo boxes.
I'm a +1 on this one, I think the inputs might need a bit of spacing from the side to feel more natural. We should also make sure that our labels are distinguishable as they start looking similar. Maybe we update the labels to be more pill-like?
As in padding L/R? I think they are indeed a bit different from our dropdowns if memory serves. Good call on the labels/tags.
Border-radius on buttons was merged but inputs is still under discussion so I'll keep this one open.
Good job
Change:
this._pendingEditsCache = {}; this._computePromise = null; this._activeCursorHasCommentingRange = CommentContextKeys.activeCursorHasCommentingRange.bindTo(contextKeyService); <ins> this._activeCursorHasComment = CommentContextKeys.activeCursorHasComment.bindTo(contextKeyService); </ins> this._activeEditorHasCommentingRange = CommentContextKeys.activeEditorHasCommentingRange.bindTo(contextKeyService); if (editor instanceof EmbeddedCodeEditorWidget) {

Discussion:
Type: <bFeature Request</bCC any file containing comment thread editor, move your cursor to any line having comment your cursor is on the line, press ctrl+K ctrl+I to see if the comment tolltip opens Screen reader users cannot open comment tooltip on the current line via ctrl+K ctrl+I ctrl+K ctrl+I needs to work for the comment tooltip just like other tooltips. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
the comment widget is not a tooltip. We cannot reuse this keybinding to focus the comment widget because it's possible that line will have hover info. pls lmk if you disagree. I do wonder if we should have a focus closest comment widget command/keybinding.
Aw, I see. Please then consider adding a keybinding to focus the closest comment widget. Currently, alt+F9 and shift+alt+F9 go to the next and previous comment widget, but there is no action available to focus the comment on the current line.
It does make sense to have an "Expand and focus comment at current line" command.
The new command is "Focus Comment on Current Line" with no default keybinding.
To verify: Install an extension that provides comments GitHub Pull Requests can be used for this Sign in Open the Pull Requests view Open a file diff for a PR. If there aren't any comments in the file, add a comment on one of the changed lines and collapse the comment Put your cursor on a line in a file with a collapsed comment Open the command palette and run the command "Focus Comment on Current Line" Verify that the comment has focus
This should probably be to the comments and/or the editor accessibility help dialog for discoverability.
Change:
this.updateService.checkForUpdates(true)); } } <ins> dispose(): void { this.disposables = dispose(this.disposables); } </ins> }  No newline at end of file

Discussion:
We should push the update UI we were running on insiders to stable. Since the new update notification UI is less invasive, there is the concern that users might forget to update and ignore the notification. Therefore we should add an update reminder, when a user did not update after a period of time. The proposal is to show the existing Update Available message box, when the user did not update after 5 days since the notification has appeared.
Will be fixed by
Fixed.
Change:
async requestWorkspaceTrust(options?: WorkspaceTrustRequestOptions): Promise<boolean> { return this._trusted; } <ins> requestWorkspaceTrustOnStartup(): void { throw new Error('Method not implemented.'); } </ins> }

Discussion:
I created a brand new VM and attached remote-ssh to it, then opened my folder on it. I clicked to trust the folder, then immediately after I was prompted by the terminal to trust the folder again. Every time I open a new folder thereafter I'm again double prompted for trust.
this is how we use the API, is promise for the original prompt not being shared with successive requests or something?
All callers of should be sharing the same promise. I will try to set up a repro today and see if I can reproduce the problem locally.
Here is what is happening: initial workspace trust modal dialog is being displayed there is another workspace trust dialog displayed due to the call the workspace will actually resolve the promise and in the background you can see the terminal is initiated The workspace trust request dialog is not being dismissed. I do have couple of ideas that I will discuss with
The fix will be available in Friday's Insiders release.
Change:
] }, "dependencies": { <del> "@vscode/extension-telemetry": "0.7.2-preview", </del> <ins> "@vscode/extension-telemetry": "^0.7.4-preview", </ins> "vscode-languageclient": "^8.1.0-next.2", "vscode-uri": "^3.0.6" },

Discussion:
Opening a file (running out of sources): Activating extension '' failed: TelemetrySender.sendEventData must be a function.
This isn't fixed in the latest insiders build! I replaced my older .app file with the latest insiders and am now stuck with this error - it's happening for the Python extension, no less! Anyway I can download an older insiders build perhaps?
switching to the "Pre-Release Version" of Python ! solved the issue for me - did you try it?
Confirmed that is right -- switching to pre-release version did fix it for me as well. Thank you!
I don't see the Switch to Pre-Reease Option in here, must I activate something?
My fix to: Activating extension 'ms-' failed: TelemetrySender.sendEventData must be a function. was: pip install pyzmq --upgrade I was working with a remote connection. I also try unistalling everthing in the remote server, switch Jupyter and Python extension to PRE-RELEASE but only updating pyzmq package work. VSCODE version: 1.75.1 JUPYTER extension version: v2023.1. PYTHON extension version: v2023.2.0 Activating extension 'ms-' failed: TelemetrySender.sendEventData must be a function.
Change:
"native-keymap": "1.2.5", "native-watchdog": "0.3.0", "node-pty": "0.7.4", <del> "nsfw": "1.0.16", </del> "semver": "4.3.6", "spdlog": "0.6.0", "sudo-prompt": "^8.0.0", "v8-inspect-profiler": "^0.0.7", "vscode-chokidar": "1.6.2", "vscode-debugprotocol": "1.27.0", <ins> "vscode-nsfw": "1.0.17", </ins> "vscode-ripgrep": "0.7.1-patch.0.1", "vscode-textmate": "^3.2.0", "vscode-xterm": "3.3.0-beta2",

Discussion:
VSCode Version: 1.17.0 () OS Version: Ubuntu 16.04 LTS Steps to Reproduce: "files.useExperimentalFileWatcher": true and close VS Code a symlink to root directory (must be an absolute link, not relative!): directory containing that symlink in VS Code: processes - one of vs code processes takes high CPU Reproduces without extensions: Yes See also:
Just noticed the same thing on osx...
Updating issue with: vs code version 1.17.0 reproduces without extensions ! Also, I found memory usage increasing over time...
Same issue here vs code version 1.17.2 Even after closing the VsCode the Code Helpers is still running with 100% CPU usage.
Reported upstream
Upstream PR
The original PR was closed so I opened one which was merged , just need a release to pull this in.
I have vscode 1.19.2 on Ubuntu. The various nodemodules directories have symbolic links point to each other that form the circular links. The nodemodules is set excluded in "files.watcherExclude". After vscode is started, it uses 100% CPU and memory usage increased dramatically and soon reached the max memory and hang the system. This problem happens whatever useExperimentalFileWatcher is set true or false. The ps shows the problem code process has parameter '--type=watcherService". Attached gdb to the process, it shows the watcher follows through the circular symbolic links in circular. Set "search.followSymlinks": false has no effect,. So this problem still happens in 1.19.2 even with all the right settings in place.
is it possible/easy to patch VS Code to stop this behaviour while waiting for it to hit a release? I have a workspace that causes a 20GB VM to exhaust its memory in about 15 mins because of circular symlinks (it uses lerna).
yeah I'll fork the module to get this in, was hoping I wouldn't need to.
what's the expected behavior after the change? I'm still seeing high CPU on today's insiders version on Ubuntu ! on Mac
the fix is specific to Linux only when you have experimental file watcher set to true in settings (or you have a multi-root workspace open).
If you have this issue, it's not just high CPU usage - your memory will be exhausted within minutes.

With a workspace with circular symlinks in it (it uses lerna and has circular dependencies), I was seeing 20GB of RAM get sucked up in about 15 minutes. Insiders has had the fix for a while now.
thanks, I'll mark as verified since you saw it before :+1: