jiebi/CodeConvo huggingface dataset:
Change:
restricted: true, markdownDescription: localize('terminal.integrated.initialHint', "Controls if the first terminal without input will show a hint about available actions when it is focused."), type: 'boolean', <del> default: false </del> <ins> default: true </ins> } };

Discussion:
I see this, but I think I've seen it correct in the past? But right now it's reproable in new terminals <img width="708" alt="image" src=""
Maybe related to my zsh prompt config, I can share the zsh config if it helps
I see the same, since I use the same setup <img width="1434" alt="Screenshot 2024-05-07 at 21 49 41" src=""
Yes can you pls share your zsh config?
Steps are: zsh oh-my-zsh a terminal in a workspace that has a git repo Let me know if that doesn't work for you.
Disabled by default in for now
also mentioned he thinks it should use the terminal's font
using your steps and I am still not seeing it . Can you share your configuration? <img width="986" alt="Screenshot 2024-05-13 at 9 50 51 AM" src=""
Also, any terminal settings would help - do you set the font / letter spacing for example?
I see that for the first prompt, the prompt start marker occurs before the (see the status bar). <img width="900" alt="Screenshot 2024-05-13 at 10 55 04 AM" src=""
Handle prompt start happens before the is by the program.
We should be disposing of the decoration when there's input, even for this case, when that's happening via a shell script.
In the case of the specific theme can be used without this issue if one removes from the prompt in Also note that the prompt is correct when a user hits enter. It's only the first prompt that is wrongly interpreted.
Change:
const clipboardService = accessor.get(IClipboardService); if (that.connectionInfo) { const linkToOpen = that.getLinkToOpen(that.connectionInfo); <del> clipboardService.writeText(linkToOpen.toString()); </del> <ins> clipboardService.writeText(linkToOpen.toString(true)); </ins> } }

Discussion:
copies a url-encoded filepath copies a url-encoded filepath, e.g. becomes , which also yields a "Workspace does not exist" warning message. Originally posted by in
Candidate PR for 1.76:
Change:
"url": "vscode://schemas/keybindings" }, { <ins> "fileMatch": "%APP_SETTINGS_HOME%/profiles/*/keybindings.json", "url": "vscode://schemas/keybindings" }, { </ins> "fileMatch": "vscode://defaultsettings/*.json", "url": "vscode://schemas/settings/default" },

Discussion:
Type: <bBug</ba new profile from empty "Perferences: Open Keyboard Shortcuts (JSON)" command suggestions in opened editor Only word-based suggestions shown. VS Code version: Code - Insiders 1.72.0-insider (, 2022-09-29T08:07:23.017Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes Remote OS version: Linux x64 5.15.62.1-microsoft-standard-WSL2 Remote OS version: Linux x64 5.15.62.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ Bookmarks13.3.1 vscode-eslint2.2.6 gitlens12.2.2 prettier-vscode9.9.0 copilot-nightly1.47.6893 remotehub0.43. rest-client0.25.1 vscode-env0.1.0 search-node-modules1.3.0 fluent-icons0.0.18 vscode-docker1.22.1 vscode-edge-devtools2.1.1 remote-containers0.254.0 remote-ssh0.87. remote-ssh-edit0.84.0 remote-wsl0.72.0 js-debug-nightly2022.9.2717 remote-explorer0.1. remote-repositories0.20.0 vscode-typescript-next4.9. abracadabra6.15.3 material-icon-theme4.20.0 prisma4.4.0 vscode-yaml1.10. reveal1.2.7 code-spell-checker2.8.0 luna-paint0.16.0 markdown-all-in-one3.4.3 material-theme3.15.5 </details<!-- generated by issue reporter --
Works for me !
! It's , not
Looks like the JSON schema is not registered for in profiles (unlike below). has different schema for default profile vs others, not sure what should happen with
Oh, my bad, keybindings, not settings. Got it!
Change:
handlePromptStart(): void; handleContinuationStart(): void; handleContinuationEnd(): void; <ins> handleRightPromptStart(): void; handleRightPromptEnd(): void; </ins> handleCommandStart(): void; handleCommandExecuted(): void; handleCommandFinished(exitCode: number | undefined): void;

Discussion:
Setup a right prompt in fish/zsh and make sure the command detected is accurate.
zsh uses for this, perhaps we should have a generic ignored ranges mechanism and combine this with the line continuation solution?
Change:
primary: KeyMod.CtrlCmd | KeyCode.Enter, } }));

Discussion:
Type: <bBug</bWith the previous native menu on macOS, Ctrl+N and Ctrl+P could be used to select code actions. This doesn't seem to work with the new custom one. I tried setting / , but that breaks Ctrl+N/P in the Command Palette. VS Code version: Code 1.71.0 (Universal) (, 2022-09-01T07:25:38.437Z) OS version: Darwin arm64 21.6.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Did you add a when-clause to your keybindings?
Is correct for how you can add your own keybindings I'll add them by default too since they also exist for the suggest widget
Change:
SPLIT_IN_ACTIVE_WORKSPACE = 'workbench.action.terminal.splitInActiveWorkspace', RELAUNCH = 'workbench.action.terminal.relaunch', FOCUS_PREVIOUS_PANE = 'workbench.action.terminal.focusPreviousPane', <ins> FOCUS_TABS_VIEW = 'workbench.action.terminal.focusTabsView', </ins> FOCUS_NEXT_PANE = 'workbench.action.terminal.focusNextPane', RESIZE_PANE_LEFT = 'workbench.action.terminal.resizePaneLeft', RESIZE_PANE_RIGHT = 'workbench.action.terminal.resizePaneRight',

Discussion:
This would be useful since we can now navigate the tabs via the keyboard, so you could hit <keybinding, up n times, enter to focus that terminal.
Also it's a little tough to tell which split pane is actually focused right now, perhaps some extra visual hint?
Opening to double check what the ideal keybinding would be on each platform
Let's go with ctrl/cmd+shift+ for this, to align with 's navigate tabs keybinding.
Change:
return; } <ins> const docUri = getParentDocumentUri(document); </ins> const snippet = new vscode.SnippetString(); uris.forEach((uri, i) => { <del> const mdPath = document.uri.scheme === uri.scheme ? encodeURI(path.relative(URI.Utils.dirname(document.uri).fsPath, uri.fsPath).replace(//g, '/')) </del> <ins> const mdPath = docUri.scheme === uri.scheme && docUri.authority === uri.authority ? encodeURI(path.relative(URI.Utils.dirname(docUri).fsPath, uri.fsPath).replace(//g, '/')) </ins> : uri.toString(false); const ext = URI.Utils.extname(uri).toLowerCase();

Discussion:
Type: <bBug</bnotebook an image from the workspace into a markdown cell Bug this inserts the full uri, such as It should insert the relative path instead VS Code version: Code - Insiders 1.71.0-insider (Universal) (, 2022-08-10T05:18:38.020Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
), group: 'navigation', order: -1 <del> }, { id: TerminalChatExecute, when: ContextKeyExpr.and( HasSpeechProvider, ScopedChatSynthesisInProgress.negate(),	// hide when text to speech is in progress AnyScopedVoiceChatInProgress?.negate(),	// hide when voice chat is in progress ), group: 'navigation', order: -1 </del> }] }); }

Discussion:
terminal I -notice double microphone icons I do not have the voice extension installed. ! fyi
Caused by:
looks the most relevant
Why does the terminal have its own execute menu?
Is it possible to clean up the parallel execute menu and submit actions? I'm unclear whether I can just move the voice actions to or you need a new parallel menu for terminal customizations.
I did the first one, seems to work, but please clean up the terminal-specific stuff if possible
Can you be more specific?
so I do have a lot of special code for terminal in using stuff like , which maybe now is obsolete? Did something change to consolidate inline chat in terminal?
This isn't actionable without more info. Terminal chat still has a separate widget implementation, it extends inline chat and shares a lot of code, but must be separate as it's not a monaco content widget for example.
Yeah I did a quick attempt to remove my terminal specific code but restored it, as it still seemed to be needed.
That was directed at the terminal widget stuff- it has its own execute menu and execute action, and I only looked briefly but it seemed like it was doing the same thing as the base chat submit action. TerminalChatWidget uses InlineChatWidget which uses the normal ChatWidget, I'd expect that the execute toolbar can be the same regardless of whether it shows up in an editor or a terminal.
did all that stuff so she might be able to comment better than me.
When I last investigated this, , the chat widget's submit action was dependent on an editor, which we don't have in terminal chat, and was defined in a place where the was not accessible. I can look into doing this now though as it seems the code has changed since then.
Change:
import { IViewDescriptorService } from 'vs/workbench/common/views'; import * as icons from 'vs/workbench/contrib/debug/browser/debugIcons'; import { DisassemblyView } from 'vs/workbench/contrib/debug/browser/disassemblyView'; <del> import { BREAKPOINTS_VIEW_ID, BREAKPOINT_EDITOR_CONTRIBUTION_ID, CONTEXT_BREAKPOINTS_EXIST, CONTEXT_BREAKPOINTS_FOCUSED, CONTEXT_BREAKPOINT_INPUT_FOCUSED, CONTEXT_BREAKPOINT_ITEM_TYPE, CONTEXT_BREAKPOINT_SUPPORTS_CONDITION, CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_IN_DEBUG_MODE, DebuggerUiMessage, DEBUG_SCHEME, IBaseBreakpoint, IBreakpoint, IBreakpointEditorContribution, IDataBreakpoint, IDebugModel, IDebugService, IEnablement, IExceptionBreakpoint, IFunctionBreakpoint, IInstructionBreakpoint, State } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import { BREAKPOINTS_VIEW_ID, BREAKPOINT_EDITOR_CONTRIBUTION_ID, CONTEXT_BREAKPOINTS_EXIST, CONTEXT_BREAKPOINTS_FOCUSED, CONTEXT_BREAKPOINT_INPUT_FOCUSED, CONTEXT_BREAKPOINT_ITEM_TYPE, CONTEXT_BREAKPOINT_SUPPORTS_CONDITION, CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_IN_DEBUG_MODE, DebuggerString, DEBUG_SCHEME, IBaseBreakpoint, IBreakpoint, IBreakpointEditorContribution, IDataBreakpoint, IDebugModel, IDebugService, IEnablement, IExceptionBreakpoint, IFunctionBreakpoint, IInstructionBreakpoint, State } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { Breakpoint, DataBreakpoint, ExceptionBreakpoint, FunctionBreakpoint, InstructionBreakpoint } from 'vs/workbench/contrib/debug/common/debugModel'; import { DisassemblyViewInput } from 'vs/workbench/contrib/debug/common/disassemblyViewInput'; import { ACTIVE_GROUP, IEditorService, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService';

Discussion:
Continuing This is just a flag in Example: In this case, vscode is in control of when and where to show this message.
Is a good name? Drop the ?
If I see some "messages" related to a debugger, I first think of something like DAP messages. I would only use this property to drive some feature in the UI and it feels good to tie it to that. But if feels awkward I don't have a strong opinion.
Change:
</thead> <tbody><tr> <td><span class="codicon codicon-zap"></span></td> <del> <td><a title="#link" data-href="#link" href="#"><span class="codicon codicon-zap"></span>-link</a></td> </del> <ins> <td><a href="#" data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></td> </ins> </tr> </tbody></table> `);

Discussion:
Version: 1.62.0-insider (Universal) Commit: Date: 2021-10-28T05:14:00.367Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin arm64 20.6.0 Setting , on the markdown document of a completion item, an tag cannot load a PNG file if the path given as a URI with . If the path given as the path of a local filesystem, it can load the file. Steps to Reproduce: one of images cannot be loaded. !
Can I pick this up?
Sure, the relevant code where we fix image paths is:
For the markdown syntax images, if the URI schema is , that's being changed to . For the HTML tag images, the file URI remains as is. The HTML image with URI doesn't load due to CSP violation.
Yes uris are blocked for security reasons. The problem is that raw html tags don't go through the transform that I linked to One thing to try would be to look for image nodes in the rendered markdown and then transform their uris instead of relying on the markdown parser to handle the transform. Try looking at for that
/verified
Change:
this._logService.trace(`No terminal found to split for group ${group}`); } // Either no group is used, no terminal with the group exists or splitting an existing terminal failed. <del> const createdTerminal = await this._terminalService.createTerminal({ location: TerminalLocation.Panel, config: launchConfigs }); </del> <ins> const createdTerminal = await this._terminalService.createTerminal({ config: launchConfigs }); </ins> createdTerminal.onDisposed((terminal) => this._fireTaskEvent({ kind: TaskEventKind.Terminated, exitReason: terminal.exitReason, taskId: task.getRecentlyUsedKey() })); return createdTerminal; }

Discussion:
. a folder and add this task: that task The task runs, but there is an error that shows in a notification:
shouldn't be getting used in the stack trace
when I set default location to editor and run the build task, terminals are appearing in the panel. is that by design ?
Currently that is by design as tasks + terminals in the editor don't work.
that might just be a matter of removing location here?
I the location to work around the issue:
is here when the terminal is in the editor, so we must be listening to somewhere in terminal editor code and disposing of the terminal !
yep, here
active instance does get updated for me, but could repro an issue where wasn't respected - fix for that incoming https://user-
Change:
getHeight(element: ChatTreeItem): number { const kind = isRequestVM(element) ? 'request' : 'response'; <del> const height = ('currentRenderedHeight' in element ? element.currentRenderedHeight : undefined) ?? 200; </del> <ins> const height = ('currentRenderedHeight' in element ? element.currentRenderedHeight : undefined) ?? this.defaultElementHeight; </ins> this._traceLayout('getHeight', `${kind}, height=${height}`); return height; }

Discussion:
See how the padding is ~double that on top than on the side ! It looks particularly bad imo when a response is in progress: ! It's also ~half on bottom: ! Could we make the padding consistent on all sides?
Padding also looks pretty bad in terminal: !
When showing a result the chat widget height is off by 3px, e.g its reported content height is small then the height takes... <img width="1411" alt="Screenshot 2024-03-22 at 16 22 35" src=""
Should be looking better now <img width="1277" alt="Screenshot 2024-03-26 at 20 58 39" src=""
Much better Does it look wrong with this part gone too? !
Yeah, I had played with that and wasn't happy. The different radii (from the input and zone) get close enough to make it look weird. Also, the focus border makes it appear as too narrow
Change:
line-height: 18px; } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu:HOVER .quickopen .action-label{ </del> <ins> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu:HOVER .quickopen .action-label { </ins> background-color: transparent !important; <ins> outline-color: transparent !important; </ins> } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu .action-item.quickopen>.action-label.search {

Discussion:
Looking at . Seems like it works fine on all the other themes I have installed. I think the theme tokens ultimately inherit from a null value here: <img width="535" alt="CleanShot 2022-05-13 at 08 31 49 src="https://user-"<img width="567" alt="CleanShot 2022-05-13 at 08 31 56 src="https://user-"
Can you help me to define colors for this?
I think makes the most sense here. <img width="665" alt="CleanShot 2022-05-16 at 08 13 18 src="https://user-"<img width="687" alt="CleanShot 2022-05-16 at 08 13 25 src="https://user-"I'll file a separate issue for this nested contrast border issue on hover: <img width="100" alt="CleanShot 2022-05-16 at 08 14 11 src="https://user-"
Nice catch - squeezed that into
Change:
class StatusBarActionViewItem extends ActionViewItem { constructor(action: StatusBarAction, options: IBaseActionViewItemOptions) { <del> super(null, action, options); </del> <ins> super(null, action, { ...options, icon: false, label: true }); </ins> } protected override updateLabel(): void {

Discussion:
See here: <img width="367" alt="image" src=""When I make the sidebar smaller in a multi-repository view, I see that the "..." appears even when not needed. !
, the checkout and sync actions seem to be missing. Investigating...
Adding as this might be related to the custom hover work...
Change:
alert(references.ariaMessage); <del> let altAction: IEditorAction | null | undefined; </del> <ins> let altAction: SymbolNavigationAction | null | undefined; </ins> if (references.referenceAt(model.uri, position)) { const altActionId = this._getAlternativeCommand(editor); if (!SymbolNavigationAction._activeAlternativeCommands.has(altActionId) && SymbolNavigationAction._allSymbolNavigationCommands.has(altActionId)) { <del> altAction = editor.getAction(altActionId); </del> <ins> altAction = SymbolNavigationAction._allSymbolNavigationCommands.get(altActionId)!; </ins> } }

Discussion:
Commit: Datum: 2022-09-01T07:22:41.992Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 +left mouse click on a declaration moves the cursor to the reference if only one exists: https://user- +left mouse click on a declaration moves the cursor opens the reference menue if only multiple references exist: https://user- Commit: Datum: 2022-09-07T05:15:40.689Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 (Also doesnt work on the Desktop Electron App.) https://user- install the versions I listed above or use and you may use this example code : Maybe it has something to do with this:
Do you have configured?
Its the default: "editor.gotoLocation.alternativeDefinitionCommand": "" ! I used and without any account. So no custom settings or extensions. :) If I use another setting like "editor.gotoLocation.alternativeDefinitionCommand": "" it also doesnt work.
Does "Peek References" or "Go to References" work when invoked on that symbol? btw - this works for me using Safari or FF
yes https://user-
are you using with your account, or in a "private" window? ctrl+mouse also doesnt bring up the references popup in other chromium based browsers, like brave nightly or the Desktop version (also tried it in a new profile). ctrl+click on a reference brings me to the definition, so my ctrl key isnt broken :D
The bug is also happening if I choose english as a language and or keyboard layout.
The same thing is happening to me, I'm on insiders Version: 1.72.0-insider Commit: Date: 2022-09-07T05:18:06.866Z (1 day ago) Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Same here
Same here. This is no longer working with the latest VSCode Insider version.

For me it's not working with Dart code. If the usage is in the same file and there is only one, it will not jump there either.
I managed to reproduce with the steps in
Change:
templateData.labelContainer.textContent = ''; if (historyItem.labels) { <del> const instantHoverDelegate = createInstantHoverDelegate(); templateData.elementDisposables.add(instantHoverDelegate); </del> // Get lits of labels to render (current, remote, base) const labels = this.getLabels(node.element.repository);

Discussion:
Testing I think we have another issue discussing a similar issue. This hover and the main item hover can conflict with each other: <img width="579" alt="Screenshot 2024-08-27 at 10 37 49 AM" src=""Instead of having a special hover just for the badges I think the main hover accomplishes the goal just fine as the badge and its description shows up at the bottom: <img width="698" alt="Screenshot 2024-08-27 at 10 39 05 AM" src=""
Change:
assertType(this._model.value); assertType(this._strategy); <del> const model = this._model.value; this._widget.inlineChatWidget.setChatModel(model); </del> const lastInput = this._widget.inlineChatWidget.value; this._historyUpdate(lastInput);

Discussion:
The context key used in terminal and notebook chat which is wrong because it signals that there is a chat participant for the editor location and it doesn't know anything about other locations.
It's now removed from the notebook side.

todays insiders open a notebook use cell generate and submit a prompt nothing happens, the error below appears
Change:
// not a failure case } } <del> if (typeof extensionManifest.activationEvents === 'undefined') { validations.push([Severity.Error, nls.localize('extensionDescription.browser3', "properties `{0}` and `{1}` must both be specified or must both be omitted", 'activationEvents', 'browser')]); return validations; } </del> } if (!semver.valid(extensionManifest.version)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.77.0-insider (Universal) Commit: Date: 2023-03-09T05:22:33.512Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin arm64 22.3.0 Sandboxed: Yes Steps to Reproduce: . ! Other Notes: fine in v1.76.0, seems like a regression bug. fix this ASAP, as it could break many extensions in the next stable release.
Same happening on some of my extensions, as I embraced (released in v1.74) and the fix in (), but now, are not enabled in Insiders.. Any ETA for the fix, or should I revert my extensions and bring back in the meantime? Thank you
Change:
import { IViewsService } from 'vs/workbench/services/views/common/viewsService'; import { ViewPaneContainer } from 'vs/workbench/browser/parts/views/viewPaneContainer'; import { IConfigurationRegistry, Extensions as ConfigurationExtensions, ConfigurationScope } from 'vs/platform/configuration/common/configurationRegistry'; <del> import { IQuickPickItem, IQuickInputService, IQuickPickSeparator } from 'vs/platform/quickinput/common/quickInput'; </del> <ins> import { IQuickPickItem, IQuickInputService, IQuickPickSeparator, QuickPickInput } from 'vs/platform/quickinput/common/quickInput'; </ins> import { AUX_WINDOW_GROUP, AUX_WINDOW_GROUP_TYPE, IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { assertIsDefined } from 'vs/base/common/types'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';

Discussion:
Type: <bBug</b! I think the log files are listed in the order the LogOutputChannels got created. Unless this is intentional / important I suggest we sort them alphabetically. I also propose adding the contributing extension's ID as the description element of the list item for LogOutputChannels created by extensions. VS Code version: Code - Insiders 1.87.0-insider (, 2024-02-13T05:47:27.450Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Changed it to show in the same way like in the output channel dropdown !
This is a little confusing because a provider that shows in the Output view dropdown might not show in "Developer: Open Log File...". I assume this is because Output has all output channels and "Open Log File" only has log output channels. I specifically noticed this with ESLint.
Thats right. Not all output channels are logs.