jiebi/CodeConvo huggingface dataset:
Change:
getUserEnvironment() .then(userEnv => { assign(process.env, userEnv); <ins> // Make sure the NLS Config travels to the rendered process // See also https://github.com/Microsoft/vscode/issues/4558 userEnv['VSCODE_NLS_CONFIG'] = process.env['VSCODE_NLS_CONFIG']; </ins> return setupIPC() .then(ipcServer => main(ipcServer, userEnv)); })

Discussion:
VSCode Version: 0.10.12-alpha OS Version: Linux Steps to Reproduce: in write to the (see VSCODENLSCONFIG) environment variable will not reach the renderer process
you reviewed. Can you please verify.
Change:
return; } <del> // Update storage, transition workspace, and resolve the promise </del> <ins> // Register one-time event handler to resolve the promise when workspace trust changed Event.once(this.workspaceTrustManagementService.onDidChangeTrust)(trusted => this.resolveWorkspaceTrustRequest(trusted)); // Update storage, transition workspace state </ins> await this.workspaceTrustManagementService.setWorkspaceTrust(trusted); <del> this.resolveWorkspaceTrustRequest(trusted); </del> } async requestWorkspaceTrust(options?: WorkspaceTrustRequestOptions): Promise<boolean | undefined> {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version:1.58.0 OS Version:MacOS Big Sur Steps to Reproduce: an untrusted folder (in my case, containing a VS Code Extension repo) command dialog appears, saying that "Listing and running tasks requires that some of the files in this workspace be executed as code...." the button banner is removed from VS Code window, but the dialog remains the button again the dialog closes, and the Task starts If instead of clicking the button twice (step 6), you simply close the dialog (click the X button), the build task starts normally (as it should, because I already trusted the folder) Thank you
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.531 --- <!-- score: 0.467 --- <!-- score: 0.457 --- <!-- score: 0.453 --<!-- potentialduplicatescomment --
The command hits two task entry points where I check for , but I thought that when I call on the second one it would just return . should I be checking if the workspace is already trusted before calling ?
I have looked into this and the issue is in the workspace trust service. Due to a regression introduced last milestone, we resolve the promise for before the workspace has fully transitioned from untrusted to trusted. I am working on a fix now.
Fix has been merged to the release branch.
Change:
registerEditorCommand(new SuggestCommand({ id: 'selectNextPageSuggestion', <del> precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.MultipleSuggestions), </del> <ins> precondition: ContextKeyExpr.and(SuggestContext.Visible, ContextKeyExpr.or(SuggestContext.MultipleSuggestions, SuggestContext.HasFocusedSuggestion.negate())), </ins> handler: c => c.selectNextPageSuggestion(), kbOpts: { weight: weight,

Discussion:
Type: <bBug</bOpen new document. Set . Type now start typing the editor will show suggestion (with only one in the list). Now pressing should select the available suggestion, but it can not be done. On the other hand if you type and then start typing the list will contain two items and selection works as expected - when you press the first item is selected and you can navigate the list with and VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
with the setting set to "never" is it expected that there is one selected by default? I didn't have to arrow down for this to happen !
Change:
this.setPlaceholderFontStyles(fontFamily, fontSize, lineHeight); <ins> this.toolbarContextKeyService = this.contextKeyService.createScoped(this.toolbarContainer); </ins> const contextKeyService2 = contextKeyService.createScoped(this.element); this.repositoryIdContextKey = contextKeyService2.createKey('scmRepository', undefined);

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!
Change:
} const header = this.renderHeader(); <del> const ITEM_HEIGHT = 24; let listHeight = ITEM_HEIGHT * this.model.items.length; </del> if (header) { <del> listHeight += ITEM_HEIGHT; </del> this.listElement.appendChild(header); } this.rowElements = this.model.items.map((item, i) => this.renderDataOrEditItem(item, i, focused)); this.rowElements.forEach(rowElement => this.listElement.appendChild(rowElement)); <del> this.listElement.style.height = listHeight + 'px'; </del> } protected createBasicSelectBox(value: IObjectEnumData): SelectBox {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Type: Bug Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.81.1 Commit: Date: 2023-08-09T22:18:39.991Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 5.15.0-76-generic Steps to Reproduce: Settings, find a block comprised of a list of items; the column size so that some of the items wrap towards next line, and you can observe the list overflows.
is that u r using some go extension
The screencast did, but it's merely for demostrating the bug. The bug itself is irrelevant to any extension.
Duplicate of
Change:
} private onTitleTap(e: GestureEvent): void { <ins> // We only want to open the quick access picker when // the tap occured over the editor label, so we need // to check on the target // (https://github.com/microsoft/vscode/issues/107543) const target = e.initialTarget; if (!(target instanceof HTMLElement) || !this.editorLabel || !isAncestor(target, this.editorLabel.element)) { return; } </ins> // TODO@rebornix gesture tap should open the quick access // editorGroupView will focus on the editor again when there are mouse/pointer/touch down events // we need to wait a bit as `GesureEvent.Tap` is generated from `touchstart` and then `touchend` evnets, which are not an atom event.

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: Codespaces OS Version: iPadOS 14 Steps to Reproduce: any repo in Codespaces off any file touch (not mouse) to click on any button at the top right corner (git, duplicate tab, close file, dropdown ellipsis) you click or it fires the command, showing the Command Palette (just like when you click on regular tabs when visible) you click it just blinks the dropdown items, and the same command in the Command Palette <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Just to clarify: we currently do not fully support touch devices, so it may well be that the experience is buggy. Other related issues:
no problem, I understand I just wanna report the issue, because Codespaces could be a game changing for me, if iPadOS is fully supported. Thank you
I think this should be fixable, marking as help wanted if someone wants to chime in. The code that opens the command palette is probably doing something wrong: or
looks like this is from the code you : This is registered on the title container here: So it will open whenever you tap anywhere into the title area, including actions. My first idea was to register this listener simply on the same element as we do here: But that somehow was not working. I attempted a fix via
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
} } <del> private async registerIndexedDBFileSystemProviders(environmentService: IWorkbenchEnvironmentService, fileService: IWorkbenchFileService, bufferLogger: BufferLogger, logService: ILogService, loggerService: ILoggerService, logsPath: URI): Promise<void> { </del> <ins> private async registerIndexedDBFileSystemProviders(environmentService: IWorkbenchEnvironmentService, fileService: IWorkbenchFileService, logService: ILogService, loggerService: ILoggerService, logsPath: URI): Promise<void> { </ins> // IndexedDB is used for logging and user data let indexedDB: IndexedDB | undefined; const userDataStore = 'vscode-userdata-store';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the "Developer: Set Log Level..." command and set it to "Trace" there's no "Telemetry" channel there, only Extension Telemetry: !
Do you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.
Where do you register Telemetry logger in codespaces, is it in server or on client side?
It's registered client side.
May I know where it is registered in sources?
Can you please check if this code is being executed in the codespace?
It seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.
Can you please provide me steps to enable this locally from sources?
Sent instructions offline
Still not seeing the telemetry output channel in Codespaces (on desktop if it matters)
Actually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.
Change:
this.countElement.style.borderStyle = border ? 'solid' : null; this.countElement.style.borderColor = border; <del> this.styleCountElementForeground(); </del> <ins> const color = this.themeService.getTheme().getColor(badgeForeground); this.countElement.style.color = color ? color.toString() : null; </ins> })); }

Discussion:
In approx 1/4 of my installed themes this badge looks awful: ! Having no-results just doesn't feel like an error. Standard badge color (Like white here on github badge) is fine(because it's usually made for it). P.S. no need for a new color, already too many of them. P.P.S. actually new settings editor doing exactly that: ! So, it just needs to be aligned with the GUI version of settings.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.532 --- <!-- score: 0.51 --- <!-- score: 0.491 --<!-- potentialduplicatescomment --
Change:
return { changes: [ new LineRangeMapping( <del> new LineRange(1, 1), new LineRange(1, modified.getLineCount()), </del> <ins> new LineRange(1, 2), new LineRange(1, modified.getLineCount() + 1), </ins> [ new RangeMapping( original.getFullModelRange(),

Discussion:
Type: <bBug</bSteps to Reproduce: Setup: Git repository opened in VScode a new file (.txt, .feature, etc) several lines of text to the file to Source Control tab to see files changes the newly created file to see the difference Observe: All lines are highlighted(with green diff color) except the last one If you add only 1 line to the file, you won't see any highlighting in the diff mode ! Expected behavior: All lines in the newly created file should be hightlighted This happens after the updated to v1.79 or maybe v1.79.1 I was able to reproduce the same behavior in GitHub Codespaces and VScode Insider VScode version: v1.79.1 (user setup) OS: Windows 11 Home 64-bit operating system, x64-based processor VS Code version: Code 1.79.1 (, 2023-06-12T16:14:05.102Z) OS version: WindowsNT x64 10.0.

Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (74)</summaryExtensionVersion ------ vscode-javascript-snippet-pack0.1.6 increment-selection0.2.0 vscode-sqlite0.14.1 jsx-html-tags1.0.1 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.18.1 markdown-preview-github-styles2.0.2 markdown-yaml-preamble0.1.0 turbo-console-log2.9.3 npm-intellisense1.4.4 doxdocgen1.4.0 vscode-mysql-client26.5.2 javascript-ejs-support1.3.3 python-preview0.0.4 githistory0.6.20 python-environment-manager1.0.4 python-extension-pack1.7.0 gitlens13.6.0 vscode-html-css1.13.1 auto-close-tag0.5.14 auto-complete-tag0.1.0 auto-rename-tag0.1.10 shell-format7.2.5 vscode-pull-request-github0.66.1 gc-excelviewer4.2.57 vscode-drawio1.6.6 vscode-htmlhint1.0.5 output-colorizer0.1.2 vscode-env0.1.0 svg1.5.2 markdown-table-formatter0.3.0 env-autocomplete1.4.1 vscode-colorize0.11.1 vsc-python-indent1.18.0 bash-ide-vscode1.37.0 MagicPython1.1.0 rainbow-csv3.7.0 python-path0.0.14 git-graph1.30.0 file-downloader1.0.12 autopep82023.4.0 black-formatter2023.2.0 isort2022.8.0 python2023.10.1 vscode-pylance2023.6.10 jupyter2023.5. jupyter-keymap1.1.2 jupyter-renderers1.0.15 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 vscode-typescript-next5.2.

autodocstring0.6.1 vscode-python-typehint1.5.1 inline-html0.3.8 vscode-thunder-client2.7.6 vscode-xml0.25.0 vscode-yaml1.13.0 vs-code-prettier-eslint5.1.0 vscode-javascript-booster14.0.1 markdown-preview-enhanced0.6.8 autoimport1.5.4 markdowntable0.10.4 pdf1.2.2 python-extended-snippets0.0.1 vscode-icons12.4.0 vscode-import-cost3.3.0 autocomplete-english-word0.1.7 JavaScriptSnippets1.8.0 txt-syntax0.2.2 vscode-yseopml1.16.0 json2.0.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for reporting! This broke .
Change:
"version": "0.0.0", "private": true, "dependencies": { <del> "@microsoft/1ds-core-js": "^3.2.2", "@microsoft/1ds-post-js": "^3.2.2", </del> <ins> "@microsoft/1ds-core-js": "^3.2.2", "@microsoft/1ds-post-js": "^3.2.2", </ins> "@microsoft/applicationinsights-web": "^2.8.4", "@vscode/iconv-lite-umd": "0.7.0", "@vscode/vscode-languagedetection": "1.0.21",

Discussion:
Upstream issue: Repro: Alt+click and drag in the terminal Moving right on the same line does not make a selection Moving to top-right or bottom-left doesn't make a selection (this works in canvas renderer only?) Cursor isn't correct ! Correct behavior in 1.67: !
When verifying make sure that copy works as expected for column selection in each quadrant as well.
Change:
} private adjustVerticalHoverPosition(target: TargetRect): void { <del> // Do not adjust vertical hover position if y cordiante is provided if (this._target.y !== undefined) { return; } // When force position is enabled, restrict max height if (this._forcePosition) { const padding = (this._hoverPointer ? Constants.PointerSize : 0) + Constants.HoverBorderWidth; if (this._hoverPosition === HoverPosition.ABOVE) { this._hover.containerDomNode.style.maxHeight = `${target.top - padding}px`; } else if (this._hoverPosition === HoverPosition.BELOW) { this._hover.containerDomNode.style.maxHeight = `${window.innerHeight - target.bottom - padding}px`; } </del> <ins> // Do not adjust vertical hover position if the y coordinate is provided // or the position is forced if (this._target.y !== undefined || this._forcePosition) { </ins> return; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: MacOS Monterey 12.5, chrome v 104.0.5112.101 Steps to Reproduce: language specific setting e.g. for a large number of languages Settings Editor, Check and hover on to show the hover view. Expected: All the overridden languages are visible and overflowing content can be scrolled to. Actual: The hover view is clipped at the screen height and not all languages are visible unless zooming out. !
this is working now, but there is some room for improvement as it does not use the maximum available space and sometimes has weird behavior with the beak. See below where the hovered text is just below the top of the widget which has a beak pointing down. <img width="272" alt="image" src="https://user-"
Change:
import { SaveReason } from 'vs/workbench/common/editor'; import { IUriIdentityService } from 'vs/workbench/services/uriIdentity/common/uriIdentity'; <ins> const UNTITLED_WORKSPACE_FILENAME = `workspace.${WORKSPACE_EXTENSION}`; </ins> export abstract class AbstractWorkspaceEditingService implements IWorkspaceEditingService { declare readonly _serviceBrand: undefined;

Discussion:
In web when I trigger File Save Workspace As, I am seeing an empty picker, but I would expect an experience which is more like this: !
The current behavior is to have not placeholder for the filename+extension. Having no filename is consistent with what Windows does: ! is your screen shot what you see on Mac when doing Save Workspace As in desktop?
yeah it is macOS and I think the challenge here is that the custom file dialog does not provide any dropdown for the file extension to pick. I think I would prefer if the custom file dialog would then do what macOS does.
Sounds good, I will update to add a placeholder filename+extension for save workspace as, which is not web specific.
the code for that use is here: To clarify: you would not implement a one-off solution for the "Save Workspace As..." but pick on the existing property to do so? I guess one question is how that would conflict with the property if that points to a file and not folder.
I think I would change the last line of the method here: Instead of just using the , which is what you are seeing happen, I would give it an untitled filename and the appropriate extension.
yeah works for me
Change:
import { languages, workspace, Disposable, TextDocument, Uri, Diagnostic, Range, DiagnosticSeverity, Position, env, l10n } from 'vscode'; import { INormalizedVersion, normalizeVersion, parseVersion } from './extensionEngineValidation'; <ins> import { TextDecoder } from 'util'; </ins> const product = JSON.parse(fs.readFileSync(path.join(env.appRoot, 'product.json'), { encoding: 'utf-8' })); const allowedBadgeProviders: string[] = (product.extensionAllowedBadgeProviders || []).map((s: string) => s.toLowerCase());

Discussion:
Type: <bBug</bClose all editor windows/processes In any arbitrary directory that does not contain , start vscode to create , e.g. Objserve that an empty tag named is also opened. VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Restricted Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This originates from here: The editor just makes sure that dirty documents are made visible.
Change:
type: 'string', description: localize('walkthroughs.title', "Title of walkthrough.") }, <ins> icon: { type: 'string', description: localize('walkthroughs.icon', "Relative path to the icon of the walkthrough. The path is relative to the extension location. If not specified, the icon defaults to the extension icon if available."), }, </ins> description: { type: 'string', description: localize('walkthroughs.description', "Description of walkthrough.")

Discussion:
Is there a way to use a codicon instead of an extension PNG? It feels out of place amongst built-in walkthroughs that can use a codicon. <img width="539" alt="CleanShot 2022-10-07 at 14 27 23 src="https://user-"cc since we chatted about this before
Conversation over at
Change:
private _gutterDecorationID: string | undefined; private _inlineChatKeybinding: string | undefined; private _hasInlineChatSession: boolean = false; <ins> private _hasActiveDebugSession: boolean = false; private _debugSessions: Set<IDebugSession> = new Set(); </ins> private readonly _localToDispose = new DisposableStore(); private readonly _gutterDecorationOpaque: IModelDecorationOptions; private readonly _gutterDecorationTransparent: IModelDecorationOptions;

Discussion:
Initially noticed by : <img width="780" alt="Screenshot 2023-11-17 at 13 53 45" src=""