jiebi/CodeConvo huggingface dataset:
Change:
return `${label} $(${primaryStatus.icon.id})`; } <del> function getSingleTabTooltip(instance: ITerminalInstance | undefined, separator: string, configurationService: IConfigurationService): string { </del> <ins> function getSingleTabTooltip(instance: ITerminalInstance | undefined, separator: string): string { </ins> if (!instance) { return ''; } <del> const shellIntegrationString = getShellIntegrationTooltip(instance, false, configurationService); </del> <ins> const shellIntegrationString = getShellIntegrationTooltip(instance, false); </ins> const title = getSingleTabTitle(instance, separator); return shellIntegrationString ? title + shellIntegrationString : title; }

Discussion:
Testing It turns out "Run Recent Command" works both with shell integration disabled and enabled, but I wasn't seeing the shell integration prompt on Windows. I'm using pwsh 7. When I disable shell integration, I see the header that tells me I'm using version 7. When I enable shell integration, I see just the prompt. My profile references the following script:
what do you mean that your profile references that script? could you provide the profile you're using?
also what's the value of your ?
PS1: Init script: Screenshot: ! Edit: I just realized the word prompt isn't what I meant. Changed the issue title.
oh you should see it only on hover of the icon in the tab list.
we changed this so no longer show in the buffer
It doesn't seem to be in the tab list icon hover: !
I think this is working as designed since we hid the message? This is also by design, it's just populating that list that only happens when shell integration is enabled.
Oh it should be on the tab hover though.
not seeing it on mac either
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
const behind = this.state.HEAD.behind ? ` ${this.state.HEAD.behind}$(arrow-down)` : ''; const icon = this.state.isSyncInProgress ? '$(sync~spin)' : '$(sync)'; <del> const rebaseWhenSync = config.get<string>('rebaseWhenSync'); </del> return { command: { <del> command: rebaseWhenSync ? 'git.syncRebase' : 'git.sync', </del> <ins> command: 'git.sync', </ins> title: `${icon}${behind}${ahead}`, tooltip: this.state.isSyncInProgress ? localize('syncing changes', "Synchronizing Changes...")

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 10 Steps to Reproduce: .rebaseWhenSync true .postCommitCommand sync git.rebaseWhenSync true works on actionbutton and statusbar but it does not affect git.postCommitCommand sync
Change:
}, { "name": "ms-vscode.node-debug2", <del> "version": "1.31.5", </del> <ins> "version": "1.31.6", </ins> "repo": "https://github.com/Microsoft/vscode-node-debug2", "metadata": { "id": "36d19e17-7569-4841-a001-947eb18602b2",

Discussion:
Forked from Disable smartStep in a node launch config Debug async/await code See that non-sourcemapped frames are still grayed out and labeled as "skipped by smartStep"
Verification steps: Clone Disable smartStep in the launch config Debug and verify that frames are not grayed out as "skipped via smartStep"
I see the changelog of 1.31.1 says is fixed. But this is what I'm seeing. The debugger is doing the exact opposite of desired behavior. It skips my code , while not skipping all library code (e.g. , which is in ). Version: 1.31.1 (system setup) !
I haven't released this for the chrome extension yet, I'll do that now.
Change:
return false; } if (this.element instanceof FileElement && other.element instanceof FileElement) { <del> return isEqual(this.element.uri, other.element.uri); </del> <ins> return isEqual(this.element.uri, other.element.uri, false); </ins> } if (this.element instanceof TreeElement && other.element instanceof TreeElement) { return this.element.id === other.element.id;

Discussion:
1.33.1 macos 10.13.6 Steps to Reproduce: a file named with breadcrumbs open it to how filename in the tab updates but the one in breadcrumbs doesn't Does this issue occur when all extensions are disabled?: Yes
Change:
render(element: HTMLElement): IDisposable { this._element = element; <del> this._label = new OcticonLabel(this._element); </del> this._element.classList.add('progress'); <ins> const container = document.createElement('span'); this._element.appendChild(container); const spinnerContainer = document.createElement('span'); spinnerContainer.classList.add('spinner-container'); container.appendChild(spinnerContainer); const spinner = new OcticonLabel(spinnerContainer); spinner.text = '$(sync~spin)'; const labelContainer = document.createElement('span'); container.appendChild(labelContainer); this._label = new OcticonLabel(labelContainer); </ins> this.hide(); return null; }

Discussion:
In light themes the status bar text changes from white to black, but progress spinners do not so they're hard to see: 
This icon is probably not themable yet. E.g. for the status bar feedback smiley we use trick to allow to change the color of it (). Depending on the outcome of we might move this into the notification area though.
fyi, the fix is to use a font for the icon (in this case our octicons). I found the sync icon fitting because we already use it for SCM sync: ! Alternatively we could use this animation: !
Change:
weight: CORE_WEIGHT, kbExpr: EditorContextKeys.textInputFocus, primary: KeyMod.CtrlCmd | KeyCode.KeyL <del> } </del> <ins> }, menuOpts: [{ menuId: MenuId.CommandPalette, group: '', title: nls.localize('expandLineSelection', "Expand Line Selection"), order: 1 }] </ins> }); }

Discussion:
While verifying I realized that expandLineSelection is not in the command window (F1). Would be good to have it as command to use programmatically.
It can be used programmatically. It doesn't show up in F1, just like moveLeft doesn't show up in F1. I agree it should be a proper action, so :+1:
Change:
top: 0; } <ins> .monaco-workbench .simple-find-part .monaco-findInput { flex: 1; } </ins> /* Temporarily we don't show match numbers */ .monaco-workbench .simple-find-part .monaco-findInput .controls { display: none;

Discussion:
Testing Steps to Reproduce: integrated terminal and open the find widget the integrated terminal area very skinny bug The find widget starts overflowing into the explorer area: <img width="420" alt="screen shot 2017-06-28 at 1 25 51 pm" src="https://user-"
After , no more overflow but we now clip the find box: !
I guess we want it to be tiny like in the editor: <img width="221" alt="screen shot 2017-07-07 at 3 02 45 pm" src="https://user-"
Change:
endOffset: Length, push: (item: BracketInfo) => boolean, level: number, <ins> nestingLevelOfEqualBracketType: number, </ins> levelPerBracketType: Map<string, number> ): boolean { if (level > 200) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: Ubuntu 20.04, Linux x64 5.15.0-46-generic snap Steps to Reproduce: VSC (possibly with extensions disabled) any C++ workspace or any folder with C++ files. "editor.bracketPairColorization.independentColorPoolPerBracketType": true pair colorization stopped working - all brackets are yellow regardless of the nesting level or bracket type. Version: 1.71.0 Commit: Date: 2022-09-01T07:25:10.472Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.15.0-46-generic snap Sandboxed: No
This is weird, we didn't change anything there. It works if you downgrade to the previous version of VS Code?
Yse, I have met the same problem after updating to 1.71.0
Same problem here on 1.71.0 on Windows 10.
Same issue here with both typescript and html templates.... All brackets regardless of nesting are all yellow after auto-updating to 1.71.0 Reverting to 1.70.2 and restoring synced settings from 1wk ago resolved my issue.
On an interesting note for me at least, the bracket colors are all yellow, but if I enable the guide lines they have the correct color !

I'm having the same issue... If I set to all brackets will always have the color defined for regardless of nesting.
Turning on or off doesn't make a difference for me, though it does change how the indentation is colored. I've messed around with , , , setting different brackets, etc, nothing changes the outcome, all brackets are . The indentation lines have the correct color, though. <details<summary"editor.bracketPairColorization.independentColorPoolPerBracketType": true</summary<img width="621" alt="image" src="https://user-"</details<details<summary"editor.bracketPairColorization.independentColorPoolPerBracketType": false</summary<img width="623" alt="image" src="https://user-"</details
Anyone up for a bugfix PR? Unfortunately, I was very busy with the merge editor this milestone.
vscode 1.72 still has this problem
I have the same issue.
same problem in
Sorry for the inconvenience. I fixed the bug and some tests to prevent future regressions. Verification steps: !
Change:
} } catch { } <ins> hasEdits = true; </ins> if (await this.fileService.exists(uri)) { workingChanges.push({ type: ChangeType.Addition, fileType: FileType.File, contents: (await this.fileService.readFile(uri)).value.toString(), relativeFilePath: relativeFilePath }); } else {

Discussion:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.
Change:
transform: rotate(-90deg); } <del> .monaco-tl-twistie.codicon-loading::before { </del> <ins> .monaco-tl-twistie.codicon-tree-item-loading::before { </ins> animation: codicon-spin 1.25s linear infinite; }

Discussion:
Issue Type: <bBug</bIn latest Insiders build instead of loading icon I see spinning chevron for some tree nodes. It's mostly noticeable in GitHub Pull Request extension tree, however I was able to reproduce it in Call Hierarchy while expanding some nested trees. Looks like has lower priority than which prevents icon change. /cc VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T08:44:55.510Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Change:
), primary: KeyCode.UpArrow, weight: KeybindingWeight.WorkbenchContrib, // markdown keybinding, focus on list: higher weight to override list.focusDown <del> } </del> <ins> }, { when: NOTEBOOK_EDITOR_FOCUSED, primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageUp, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageUp }, weight: KeybindingWeight.WorkbenchContrib }, </ins> ], }); }

Discussion:
suggested would be good for this
FYI, I have customized like below:
feel free to close if we already support this now.
We do not have a default keybinding that works along with the screen reader being enabled, though ctrl+pagedown/pageup are currently bound to next/previous editor, so I don't think we can use that one without breaking current workflows.
Maybe ctrl+alt+pagedown/pageup?
Change:
// Only set cwdFolder if detection is on if (templateProperties.cwd && detection && (!this._instance.shellLaunchConfig.isFeatureTerminal || labelType === TerminalLabelType.Title)) { <del> const cwdUri = URI.from({ scheme: this._instance.workspaceFolder?.uri.scheme || Schemas.file, path: this._instance.cwd }); </del> <ins> const cwdUri = URI.from({ scheme: this._instance.workspaceFolder?.uri.scheme || Schemas.file, path: this._instance.cwd ? path.resolve(this._instance.cwd) : undefined }); </ins> // Multi-root workspaces always show cwdFolder to disambiguate them, otherwise only show // when it differs from the workspace folder in which it was launched from let showCwd = false;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.1 OS Version: Ubuntu 22.04 Steps to Reproduce: integrated terminal command I discovered this completely by accident when I mistyped
I will also add that I'm getting the error
Does not repro on macOS, but does on linux (WSL)
stack trace:
The issue is here. Perhaps we should just catch that?
We could also try resolving the path: <img width="715" alt="image" src="https://user-"
Change:
} async commit(message: string | undefined, opts: CommitOptions = Object.create(null)): Promise<void> { <ins> const indexResources = [...this.indexGroup.resourceStates.map(r => r.resourceUri.fsPath)]; const workingGroupResources = opts.all && opts.all !== 'tracked' ? [...this.workingTreeGroup.resourceStates.map(r => r.resourceUri.fsPath)] : []; </ins> if (this.rebaseCommit) { await this.run( Operation.RebaseContinue,

Discussion:
Type: <bBug</bI have the setting: "Git: Close Diff On Operation" enabled. Staging a change will close the diff. Committing a staged change will close the diff. But if I just click the Commit button, the changes will commit but the diff won't close. Reproduction steps: & save a file the file in "Source Control" to open a diff Commit Expected behavior: The "(Working Tree)" tab closes Actual behavior: It stays open VS Code version: Code 1.77.3 (Universal) (, 2023-04-12T09:19:37.325Z) OS version: Darwin x64 22.4.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ tailwind-documentation0.1.6 ng-template15.2.1 tailwind-docs2.0.0 docs-view0.0.11 vscode-tailwindcss0.9.11 language-postcss1.1.0 vscode-deno3.17.0 vscode-axe-linter4.7.0 nasc-touchbar1.12.0 copilot1.84.51 vscode-test-explorer2.21.1 tasks-statusbar0.1.0 git-graph1.30.0 dotenv1.0.1 csharp1.25.4 test-adapter-converter0.1.7 vsliveshare1.0.5864 vscode-yaml1.12.2 snyk-vulnerability-scanner1.18.2 code-spell-checker2.20.4 vscode-todo-highlight1.0.5 pretty-ts-errors0.4.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
title: { value: LOCALIZED_START_INLINE_CHAT_STRING, original: 'Start Inline Chat' }, category: AbstractInlineChatAction.category, f1: true, <del> precondition: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, EditorContextKeys.writable), </del> <ins> precondition: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_VISIBLE.toNegated(), EditorContextKeys.focus), </ins> keybinding: { weight: KeybindingWeight.WorkbenchContrib, primary: KeyMod.CtrlCmd | KeyCode.KeyI,

Discussion:
The editor sparkle shows unconditionally, e.g in any editor, like the extensions editor when a session is already active in the editor <img width="738" alt="Screenshot 2023-11-15 at 16 04 10" src=""
Change:
} private _getTerminalByIdEventually(id: number, retries: number = 5): Promise<ExtHostTerminal> { <ins> if (!this._getTerminalPromises[id]) { this._getTerminalPromises[id] = this._createGetTerminalPromise(id, retries); } else { this._getTerminalPromises[id].then(c => { return this._createGetTerminalPromise(id, retries); }); } return this._getTerminalPromises[id]; } private _delay(timeout: number, result: any) { return new Promise(c => { setTimeout(c(result), timeout); }); } private _createGetTerminalPromise(id: number, retries: number = 5): Promise<ExtHostTerminal> { </ins> return new Promise(c => { if (retries === 0) { c(undefined);

Discussion:
Verification steps?
Verification Steps: Create an extension with this command: (vscode.commands.registerCommand('terminalTest.createAndSend', () ={ const terminal = (); if((<anyterminal).onDidWriteData) { (<anyterminal).onDidWriteData(data ={('Hello World!');}); } terminal.sendText("echo 'Sent text immediately after creating'"); })); When you execute the command, confirm that the 'Hello World!' info message shows. Do this five or so more times since this is a race condition.
Change:
Reset = 'Reset', Remote = 'Remote', Fetch = 'Fetch', <ins> FetchNoProgress = 'FetchNoProgress', </ins> Pull = 'Pull', Push = 'Push', CherryPick = 'CherryPick',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 (system setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: When i run command, i don't know whether it is complete or not. There is no circle loading animation. !
It looks like, it was not do show progress while the operation is being executed. Thinking about it, I do think that if one has auto-fetch enabled it might be quite distracting to show progress every time the fetch operation is being run as part of auto-fetch. Having said that, I do think that it makes sense to show progress when is being executed explicitly. thoughts?
Agree.
Consider adding an option to decide whether to turn on the feature?
this progress indicator during a manual fetch would honour the setting.
Thank you, hope see the feature soon.
Change:
import processes = require('vs/base/node/processes'); import nls = require('vs/nls'); import errors = require('vs/base/common/errors'); <ins> import { assign } from 'vs/base/common/objects'; </ins> import { TPromise } from 'vs/base/common/winjs.base'; import { ITerminalService } from 'vs/workbench/parts/execution/common/execution'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

Discussion:
The and should be removed
Sorry for question, but why you don't use native ?
stuff in common is still used in very old browser
Fixed in
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { ExtensionContext } from 'vscode'; </del> <ins> import { ExtensionContext, Uri } from 'vscode'; </ins> import { LanguageClientOptions } from 'vscode-languageclient'; import { startClient, LanguageClientConstructor } from '../htmlClient'; import { LanguageClient } from 'vscode-languageclient/browser';

Discussion:
The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API
fyi
tried to adopt this. When will be available. I can't find it in .
Opened for ESLint
It's in the API since 4 months:
Change:
} /** @inheritdoc */ <del> public getDecoratedRangeForTest(resource: URI, testId: string) { </del> <ins> public getDecoratedTestPosition(resource: URI, testId: string) { </ins> const model = this.modelService.getModel(resource); if (!model) { return undefined;

Discussion:
Using the test-provider-sample, adding newlines on a line marked as a test duplicates the test icon: ! It sorts itself out on the next update (at least in the sample, I'm still investigating to figure out if there's another issue, or that's in my extension). But it still looks bad - especially if a language is debouncing edits and/or discovery may be slow.. You can make the issue more pronounced (as I did for the GIF) by updating the test-provider-sample to have a delay in its updates:
I was able to repro the full issue I'm seeing in Dart (where the icons never disappear) using the sample too: ! My changes to the sample are here: I changed it so that tests can span multiple lines (since the original code split on lines then searched each line) and use the full range as the for the test. Now when pressing in the test, the original issue (VS Code duplicate the icons) still occurs, but also after the updates, since the range computed by the provider doesn't change from the range VS Code currently has (at least that's my guess), there's no update to the gutter icons so they no longer get cleaned up.
That's correct, we let the editor do its default decoration tracking until an update is received from the extension. for testing decorations, I already set , but is there a similar option to avoid extending the range over lines when edited? Or, alternatively, a way to only apply the glyphMarginClassName to the first line of the range. Reference:
You can create two decorations per test. One which has a range, a hover message, etc. And another one which renders the glyph margin with a collapsed range (perhaps the start position of the range). If you use for the second one, given it begins as a collapsed range, it will never grow, it will always remain a collapsed range.
Change:
} const pos = editor.getPosition(); model.tokenizeIfCheap(pos.lineNumber); const word = model.getWordAtPosition(pos); if (!word) { return false;

Discussion:
VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.
For the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns
Any update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.
Have the same problem, but wonder about: "... autocomplete options for props ...". Is VS Code capable to autocomplete my custom from an imported component?