jiebi/CodeConvo huggingface dataset:
Change:
} catch (e) { // Catch the potential 'disconnect' error - no need to show it to the user since the adapter is shutting down } finally { <del> this.stopAdapter(error); </del> <ins> await this.stopAdapter(error); </ins> } } else { return this.stopAdapter(error);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Commit: Date: 2021-09-01T10:54:53.442Z Electron: 13.1.8 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 OS Version: MacOS big sur 11.5.2 Steps to Reproduce: use this settings follow shortcut any project, press f4 to debug. There should hit confirm restart dialog 2 delay to 500 f4, there aren't confirm restart dialog showing there are same question.
Does this issue has some result?
what is the exact reason that you cannot use "Restart" to do the "Stop"/"Start" sequence?
"Restart" in Rust will use previous binary. But I have changed my codes already, so I want to stop first, then start again, extension(lldb) will first recompile my codes.
It's important for Non-interpreter language. Javascript's "Restart" will re-interpreter codes, so it will always use latest codes. But in others, possibly not
Currently I'm using , executing , sequentially. But shortcuts But after pressed F4, dialog showed. I guess state from one process don't sync to another process. It I delay some second, there no dialog showing. Please see this
In clion(a jetbrains rust IDE), there are option showing that we can disable dialog forever. After clicking , recompile is the first step. !
Does have any progress?

Does have some result?
There is an await missing here: But I'm not sure whether that's enough to fix this issue. Would take a PR for it if someone else has the time to debug and investigate.
Recently made the same fix 2 lines above: I think just adding the await is fine.
I can still reproduce this bug in insider
Works fine for me, debugging in node, even with no delay. If you still see it, it could be an issue on the debug adapter's end? What are you debugging? Consider filing an issue on the debug extension.
For nodejs, If we have the prebuild task take 10s to finished in . Before vscode's toolbar become to yellow(maybe It's BeforeDebuggerSessionStart phase), press F4 will cause confirm restart dialog showing up
Ok but that will be sort of a different issue, if you open another issue I can take a look.
Ok
Change:
readonly value: string; /** <del> * Create a new kind by appending a more specific selector to the current kind. </del> <ins> * Create a new kind by appending additional scopes to the current kind. </ins> * * Does not modify the current kind. */

Discussion:
Testing I cloned the vscode-extension-samples repository and tried to return two edits instead of one. Only the first one appears to take effect. I am wondering if this is expected? I guess I was expecting both edits to be applied since it is possible to return an array from the method.
The thought occurred to me that the edits would appear in the paste widget, and I verified this was indeed the case. I guess, by reading the TS docs I didn't catch on that this would happen
Aside from the above comment, on reading the JS Docs, the following thoughts came to mind: For the class , I was looking at the method . Consider the following code: Do the kinds and intersect here? Or is the intersection evaluated per part, so that the above do not intersect but the below kinds do? I noticed the refers to file dropping in its JS Doc. I was wondering if this is intended? The JS Doc above the field says . The same line more-or-less can be found under .
This is expected. Each is one potential way of applying the paste. We only apply one at a time and the first one is auto applied , the kinds are scoped hierarchies of parts. When we talk about intersection, only the second example would return true. The first one would not as the two top level parts and are not the same. I'll add an example in the docs to make this more clear it applies but for pasting files. I'll change the word
Change:
export const KEYBINDINGS_EDITOR_COMMAND_RESET = 'keybindings.editor.resetKeybinding'; export const KEYBINDINGS_EDITOR_COMMAND_COPY = 'keybindings.editor.copyKeybindingEntry'; export const KEYBINDINGS_EDITOR_COMMAND_COPY_COMMAND = 'keybindings.editor.copyCommandKeybindingEntry'; <ins> export const KEYBINDINGS_EDITOR_COMMAND_COPY_COMMAND_LABEL = 'keybindings.editor.copyCommandKeybindingLabel'; </ins> export const KEYBINDINGS_EDITOR_COMMAND_SHOW_SIMILAR = 'keybindings.editor.showConflicts'; export const KEYBINDINGS_EDITOR_COMMAND_FOCUS_KEYBINDINGS = 'keybindings.editor.focusKeybindings'; export const KEYBINDINGS_EDITOR_SHOW_DEFAULT_KEYBINDINGS = 'keybindings.editor.showDefaultKeybindings';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently, for copying a command like on the "Keyboard Shortcuts" page, there're two options: Copies Command ID Copies But really, quite often, we just want to copy , and there's no option for that. Therefore, I'm making a feature request for it.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.526 --- <!-- score: 0.46 --- <!-- score: 0.447 --<!-- potentialduplicatescomment --
Hey I see this is assigned to you, I opened a PR to address this. It is my 1st PR so any constructive feedback would be appreciated ;-)
I hope this works for you? :smile_cat:
Sorry for the late response, but I don't know how to test this though.
Planning to look at this PR in July milestone.
Thanks for the PR - I did some small fine tunings after. !
To verify: Open Keyboard Shortcuts editor Right click on an entry and make sure you have an action to copy the command title Make sure this action works as expected
Change:
color: var(--vscode-editorCodeLens-foreground) } <del> .merge-editor-conflict-actions>span, .merge-editor-conflict-actions>a { </del> <ins> .merge-editor-conflict-actions > span, .merge-editor-conflict-actions > a { </ins> user-select: none; -webkit-user-select: none; white-space: nowrap; } <del> .merge-editor-conflict-actions>a { </del> <ins> .merge-editor-conflict-actions > a { </ins> text-decoration: none; } <del> .merge-editor-conflict-actions>a:hover { </del> <ins> .merge-editor-conflict-actions > a:hover { </ins> cursor: pointer; color: var(--vscode-editorLink-activeForeground) !important; } <del> .merge-editor-conflict-actions>a:hover .codicon { </del> <ins> .merge-editor-conflict-actions > a:hover .codicon { </ins> color: var(--vscode-editorLink-activeForeground) !important; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !
Change:
// delete if (fileOperation.type & BulkFileOperationType.Delete) { return { <del> original: { resource: undefined }, modified: { resource: URI.revive(previewUri) } </del> <ins> original: { resource: URI.revive(previewUri) }, modified: { resource: undefined } </ins> }; }

Discussion:
an extension with the following code: on the refactoring in the bulk edit pane opens the following multi diff editor: <img width="1093" alt="Screenshot 2024-03-27 at 17 23 56" src=""above is not correct because it looks like the file is . In fact it is deleted.
Change:
// Check that if file has been deleted on disk. // This can happen when directories are renamed / moved. VS Code's file system watcher does not // notify us when this happens. <del> if (await this.statBypassingCache(uri) === undefined) { </del> <ins> if (!(await this.statBypassingCache(uri))) { </ins> if (this._documentCache.get(uri) === doc && !doc.hasInMemoryDoc()) { this.doDeleteDocument(uri); return;

Discussion:
Type: <bBug</bworkspace: : to top level of workspace bug The link is incorrectly rewritten to include the file name VS Code version: Code - Insiders 1.73.0-insider (Universal) (, 2022-10-27T21:41:11.954Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
import { Delayer } from 'vs/base/common/async'; import * as DOM from 'vs/base/browser/dom'; import { isIOS, OS } from 'vs/base/common/platform'; <del> import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle'; </del> <ins> import { Disposable, DisposableStore, IDisposable } from 'vs/base/common/lifecycle'; </ins> import { ToggleActionViewItem } from 'vs/base/browser/ui/toggle/toggle'; import { HighlightedLabel } from 'vs/base/browser/ui/highlightedlabel/highlightedLabel'; import { KeybindingLabel } from 'vs/base/browser/ui/keybindingLabel/keybindingLabel';

Discussion:
Follow up from I have a completion item provider for context keys. For the keybindings UI this isn't working yet and what's needed is the simple editor widget as the input when authoring when-clauses a similar completion item provider (using internal API) that uses the same data source ()
Started using (Code Editor) for when input and I am seeing following issues with the code editor widget is showing far away from the editor. <img width="858" alt="image" src="https://user-"listen on key and accept the when text. This is causing problem when I am accepting an option from suggest list using Enter. Is there a way to prevent this to happen? / Your expertise would be very helpful here. You can find changes here -
Pretty sure that you need to use the keybindings service instead, e.g don't listen to keydown/up event directly ops... that seems very wrong, both widgets are normal content/overlay widgets
Right. I am using keybindings to accept/reject when expression changes. And it fixed the second issue. Thanks. Issue with suggest widget is only pending.
Investigated the issue with overflow content widget misplacement and here is what I found: This seems to be a bug with editor overflowing content widget value set to . According to the docs, when position value is set to fixed then the position of the element will be relative to its containing block, which is In keybindings editor, the table widget (extending list widget) has the ancestor rows element with and css property set. Hence overflowing content widgets are drawn relative to the table rows element. This can be confirmed by disabling the on the table widget that does not set above css properties. This means, embedding a code editor widget inside any node that has these css properties set will break the position of the overflowing content widgets CC / for editor related. CC for table/list related. Can you please let me know what is the right way to proceed here. Does it makes sense to disable for keybindings table? Or this shall has to be fixed in editor?
It seems the trick is to use option in the code editor. But it seems to work only for content widgets but not for overlay widgets - like suggest element details. Using the same for overlay widgets fixes it.

For now disabled table transformations and created a separate PR to fix it in the editor -
Verify that while editing when column in keyboard shortcuts editor shows the list of context key suggestions.
I see this is implemented but it's also mostly broken because it doesn't work with prefixes
Change:
private viewModel: viewmodel.ViewModel; private configurationManager: ConfigurationManager; private debugStringEditorInputs: DebugStringEditorInput[]; <ins> private telemetryAdapter: AIAdapter; </ins> private lastTaskEvent: TaskEvent; private toDispose: lifecycle.IDisposable[]; private inDebugMode: IKeybindingContextKey<boolean>;

Discussion:
If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).
this is probably something you want to use...
The functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .
we are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?
yes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?
What we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.
For Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?
previously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.
Change:
export const editorErrorBorder = registerColor('editorError.border', { dark: null, light: null, hcDark: Color.fromHex('#E47777').transparent(0.8), hcLight: '#B5200D' }, nls.localize('errorBorder', 'Border color of error boxes in the editor.')); export const editorWarningBackground = registerColor('editorWarning.background', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('editorWarning.background', 'Background color of warning text in the editor. The color must not be opaque so as not to hide underlying decorations.'), true); <del> export const editorWarningForeground = registerColor('editorWarning.foreground', { dark: '#CCA700', light: '#BF8803', hcDark: '#FFD37', hcLight: '#895503' }, nls.localize('editorWarning.foreground', 'Foreground color of warning squigglies in the editor.')); </del> <ins> export const editorWarningForeground = registerColor('editorWarning.foreground', { dark: '#CCA700', light: '#BF8803', hcDark: '#FFD370', hcLight: '#895503' }, nls.localize('editorWarning.foreground', 'Foreground color of warning squigglies in the editor.')); </ins> export const editorWarningBorder = registerColor('editorWarning.border', { dark: null, light: null, hcDark: Color.fromHex('#FFCC00').transparent(0.8), hcLight: '#' }, nls.localize('warningBorder', 'Border color of warning boxes in the editor.')); export const editorInfoBackground = registerColor('editorInfo.background', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('editorInfo.background', 'Background color of info text in the editor. The color must not be opaque so as not to hide underlying decorations.'), true);

Discussion:
With Dark High Contrast theme, everything is clear except for warning and errors... Error is shown with an orange x: ! While warnings are exclamation mark in blaring red: ! I mean there's no two ways about it... RED is error, RED+certain amount of yellow(orange is fine) is warning.
Change:
@IBroadcastService private broadcastService: IBroadcastService, @IConfigurationService private configurationService: IConfigurationService, @ITelemetryService private telemetryService: ITelemetryService, <ins> @IWindowService private windowService: IWindowService, </ins> @IInstantiationService private instantiationService: IInstantiationService) { this.container = container;

Discussion:
(Moved from internal Windows Feedback bug database) on High Contrast Black VS Code that inside of the frame, the text shows up normally (not in high contrast). This is an accessibility issue
The current workaround is to manually switch VS Code to the High Contrast Theme via
is there electron API to detect high contrast mode automatically?
Yeah I thought we detect high contrast on Windows, I have to check.
I see that the theme is correctly passed on to the renderer () but then is reset back to the previous one (e.g. ). Can you check why the theme is not applied? To reproduce: enable HC theme on Windows start VS Code expect it to show in HC theme
The hc theme needs to be set in the settings or on the theme service, like (). This will trigger all theming participants that then ally the theming and generate the css rules. Setting the class name just helps with the initial window appearance.
it looks like you removed that code that handles high contrast on Windows and never it back to the renderer ()? I created to prefer the HC theme if we detect high contrast mode. It is a bit ugly though because the settings are still containing the previous theme, not sure we should just blindly overwrite it because the HC theme on Windows could be a temporary thing.
Change:
import { onUnexpectedError } from 'vs/base/common/errors'; import { MarkdownString } from 'vs/base/common/htmlContent'; import { IModeService } from 'vs/editor/common/services/modeService'; <del> import { Range } from 'vs/editor/common/core/range'; </del> <ins> import { Range, IRange } from 'vs/editor/common/core/range'; </ins> import * as editorCommon from 'vs/editor/common/editorCommon'; import { DefinitionProviderRegistry, LocationLink } from 'vs/editor/common/modes'; import { ICodeEditor, IMouseTarget, MouseTargetType } from 'vs/editor/browser/editorBrowser';

Discussion:
Issue Type: <bBug</bGitHub Pull Request extension repo Hover on Press CMD key ! Ideally we should be able to implementation of at the top and definition at the bottom, but :( VS Code version: Code - Insiders 1.34.0-insider (, 2019-04-09T05:14:40.620Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (50)</summaryExtensionVersion ------ vscode-apollo1.5.2 markdown-emoji0.0.7 solargraph0.19.6 npm-intellisense1.3.0 vscode-svgviewer2.0.0 vscode-markdownlint0.26.0 vscode-eslint1.8.2 xml2.4.0 gitlens9.6.0 remotehub0.2.0 tsl-problem-matcher0.0.4 EditorConfig0.13.0 tslint1.0.43 vscode-npm-script0.3.5 vsc-material-theme2.8.2 prettier-vscode1.8.1 flow-for-vscode1.1.1 vscode-pull-request-github-insiders1.98.0 ocaml0.6.43 beautify1.4.11 references-plusplus0.0.5 graphql-for-vscode1.13.0 dotenv1.0.1 theme-monokai-pro-vscode1.1.12 vscode-azurefunctions0.16.0 vscode-language-pack-zh-hans1.33.2 python2019.3.6558 azure-account0.8.1 cpptools0.22.1 Go0.9.2 powershell1.12.0 vscode-typescript-tslint-plugin1.0.0 wordcount0.1.0 vsliveshare1.0.18 debugger-for-chrome4.11.3 debugger-for-ios-web0.1.2 vetur0.18.1 subtitles-editor1.0.2 vscode-versionlens0.22.0 material-icon-theme3.7.0 seti-icons0.1.3 ruby0.22.3 smartpaste0.0.3 toggle0.0.1 vscode-fuzzsymbols0.0.1 sass-indented1.5.1 rust0.6.1 sourcekit-lsp0.0.

1 vscode-lldb1.2.2 vscode-intelli-nav0.0.6 (12 theme extensions excluded) </details<!-- generated by issue reporter --
adding since I believe the implementation peak when holding CMD is determined by VS Code
Yeah, today we count matching bracket (up to a low maximum of lines) to compute the preview. not sure if TypeScript provides  but that would certainly help here
Ok, we do set the but it is just the range of the identifier (). I've opened to track having this information returned from TypeScript
Planning to do work to support API proposed by in June. We would not actually ship this until TS 3.6 however
To verify, please make sure you are using TS 3.6 in your workspace and follow original instructions in the github PR extension's codebase
Change:
title: locations.length === 1 ? localize('oneReferenceLabel', '1 reference') : localize('manyReferenceLabel', '{0} references', locations.length), <del> command: 'editor.action.showReferences', </del> <ins> command: locations.length ? 'editor.action.showReferences' : '', </ins> arguments: [codeLens.document, codeLens.range.start, locations] }; return codeLens;

Discussion:
Testing in this setup Get this Code lense with '0 References' in ! Clicking the references link just shows an empty peek, it is not clear what is being search for. !
Now I understand what is going on: ! The reference in the template isn't found by the Angular Language Service extension.
Do you suggest we don't show the peek view from zero references code lens? Or should the peek view have more info on what would normally be displayed?
since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.
Change:
os, remoteAuthority: this._environmentService.remoteAuthority }); <ins> let icon: URI | ThemeIcon | { light: URI; dark: URI } | undefined; if (task.configurationProperties.icon) { icon = ThemeIcon.fromId(task.configurationProperties.icon); } else { const taskGroupKind = task.configurationProperties.group ? GroupKind.to(task.configurationProperties.group) : undefined; const kindId = typeof taskGroupKind === 'string' ? taskGroupKind : taskGroupKind?.kind; icon = kindId === 'test' ? ThemeIcon.fromId(Codicon.beaker.id) : defaultProfile.icon; } </ins> shellLaunchConfig = { name: terminalName, type, executable: defaultProfile.path, args: defaultProfile.args, env: { ...defaultProfile.env }, <del> icon: task.configurationProperties.icon ? ThemeIcon.fromId(task.configurationProperties.icon) : defaultProfile.icon, </del> <ins> icon, </ins> color: task.configurationProperties.color || defaultProfile.color, waitOnExit };

Discussion:
This is the main thing I wanted from the task icons, if tasks of of kind to use the beaker: ! I think this makes sense over a setting since we can now override them via the property and the beaker icon aligns with our testing pane
I like it!