jiebi/CodeConvo huggingface dataset:
Change:
import { IListService, WorkbenchObjectTree } from 'vs/platform/list/browser/listService'; import { ITreeNode, ITreeRenderer } from 'vs/base/browser/ui/tree/tree'; <del> import { DefaultStyleController } from 'vs/base/browser/ui/list/listWidget'; </del> <ins> import { DefaultStyleController, IListAccessibilityProvider } from 'vs/base/browser/ui/list/listWidget'; </ins> import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey';

Discussion:
Testing Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this: Put for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a and not a Modify aria label of an element in case he is part of a split
We're converting this into a list next iteration , I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.
hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?
oh great that you moving to the list. You should have a correct role then. I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip. Special character is not read out now because it is not part of the aria label.
Good point
Scoped this issue down, conversion to list will be handled in
I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before. I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just
! When I inspect a split terminal tab label, it has the correct aria label.
Oh but you are setting the on the wrong HTML element You should use the so the is properly set on the element. It has to be on that element, since that element has focus and that is what the Screen Reader will read. So I think it should be fixed here
Change:
if (item.tooltip && !allowedTooltips) { console.warn(`Extension '${extension.identifier.value}' uses a tooltip which is proposed API that is only available when running out of dev or with the following command line switch: --enable-proposed-api ${extension.identifier.value}`); } <del> if (item.iconPath && !allowedIcons) { console.warn(`Extension '${extension.identifier.value}' uses an icon which is proposed API that is only available when running out of dev or with the following command line switch: --enable-proposed-api ${extension.identifier.value}`); } const icon = (item.iconPath && allowedIcons) ? getIconPathOrClass(item.iconPath) : undefined; </del> <ins> const icon = (item.iconPath) ? getIconPathOrClass(item.iconPath) : undefined; </ins> pickItems.push({ label: item.label, iconPath: icon?.iconPath,

Discussion:
Would it be possible to allow for extensions to provide icons in s? At the moment we can use via the syntax, but if we want to provide a custom icon that is more complex (perhaps we can do that be providing a font and a partial product icon theme?). With a , we can pass in an optional icon path: Could we add this to QuickPickItem too? Based on the quick open input, there is already space afforded in the UI for the icon, so it would be useful if extensions to provide one.
Related to which asks for the ability to specify filetype icons.
Proposal: It looks a bit off using squares: !
Example with circles for reference: !
For anyone curious, circles are possible by using data URIs: Example and copied here for reference:
Change:
actionRunner, actionViewItemProvider: action => { if (action instanceof MenuItemAction && toolbar.dropdownActions.length > 1) { <del> const scmInputActionIsEnabled = contextKeyService2.getContextKeyValue<boolean>('scmInputActionIsEnabled') === true; </del> <ins> const scmInputActionIsEnabled = this.toolbarContextKeyService.getContextKeyValue<boolean>('scmInputActionIsEnabled') === true; </ins> const dropdownAction = new Action('scmInputMoreActions', localize('scmInputMoreActions', 'More Actions...'), 'codicon-chevron-down', scmInputActionIsEnabled); return instantiationService2.createInstance(DropdownWithPrimaryActionViewItem, action, dropdownAction, toolbar.dropdownActions, '', this.contextMenuService, { actionRunner });

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!
Change:
this._onChange(); } <ins> public addIfNotPresent(t: T) { if (!this._history.contains(t)) { this.add(t); } } </ins> public next(): T { if (this._navigator.next()) { return this._navigator.current();

Discussion:
Search for "foo" Search for "bar" Click the 'clear results' button Use alt+up to get the last history item It should be "bar", but it's "foo"
Change:
private async openInBrowserWindow(options: IOpenBrowserWindowOptions): Promise<ICodeWindow> { const windowConfig = this.configurationService.getValue<IWindowSettings | undefined>('window'); <ins> const lastActiveWindow = this.getLastActiveWindow(); const defaultProfile = lastActiveWindow?.profile ?? this.userDataProfilesMainService.defaultProfile; </ins> let window: ICodeWindow | undefined; if (!options.forceNewWindow && !options.forceNewTabbedWindow) { <del> window = options.windowToUse || this.getLastActiveWindow(); </del> <ins> window = options.windowToUse || lastActiveWindow; </ins> if (window) { window.focus(); }

Discussion:
I know I suggested but after trying it out I am convinced that was a wrong suggestion. I think we should just revert it, and whenever we open a new folder it should be using the CURRENT profile. I know and feel the same.
Lets discuss this!
Actually I liked this behaviour too. Reverted this after our discussion. Bringing this back again :)
Awesome - thanks!
Is it possible to associate a workspace (or folder) with a profile? E.g. can I set that if I open a workspace (or folder) "A", current profile will be switched to "Default" and if I open a workspace "B", current profile will be switched to "Work"?
Well, it seems to be already working:
Change:
let fixedRegexpQuery = fixRegexNewline(query.pattern); fixedRegexpQuery = fixNewline(fixedRegexpQuery); args.push('--regexp', fixedRegexpQuery); <del> args.push('--auto-hybrid-regex'); </del> } else { searchPatternAfterDoubleDashes = query.pattern; args.push('--fixed-strings');

Discussion:
Issue Type: <bBug</bFind in Files Regexp with lookbehind Use Regular Expression and Match Whole Word "Regex parse error" message appear This works fine in Find widget and if manually to regexp. Root cause: is not if is used with . /cc VS Code version: Code - Insiders 1.39.0-insider (, 2019-10-04T09:24:45.690Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.598 --- <!-- score: 0.549 --- <!-- score: 0.5 --<!-- potentialduplicatescomment --
Change:
'const add1 = (n) =>', '    ', ].join('n')); <del> viewModel.type('n + 1;'); </del> <ins> }); }); test.skip('issue #208215: outdented after semicolon detected after arrow function', () => { // Notes: we want to outdent after having detected a semi-colon which marks the end of the line, but only when we have detected an arrow function // We want to have one outdent pattern corresponding to an indent pattern, and not a generic outdent and indent pattern const model = createTextModel([ 'const add1 = (n) =>', '    console.log("hi");', ].join('n'), languageId, {}); disposables.add(model); withTestCodeEditor(model, { autoIndent: "full" }, (editor, viewModel, instantiationService) => { registerLanguage(instantiationService, languageId, Language.TypeScript, disposables); editor.setSelection(new Selection(2, 24, 2, 24)); viewModel.type("n", 'keyboard'); assert.strictEqual(model.getValue(), [ 'const add1 = (n) =>', '    console.log("hi");', '', ].join('n')); }); }); test.skip('issue #116843: indent after arrow function', () => { // https://github.com/microsoft/vscode/issues/116843 const model = createTextModel("", languageId, {}); disposables.add(model); withTestCodeEditor(model, { autoIndent: "full" }, (editor, viewModel, instantiationService) => { registerLanguage(instantiationService, languageId, Language.TypeScript, disposables); viewModel.type([ 'const add1 = (n) =>', '    n + 1;', ].join('n')); </ins> viewModel.type("n", 'keyboard'); assert.strictEqual(model.getValue(), [ 'const add1 = (n) =>', <del> '	n + 1;', </del> <ins> '    n + 1;', </ins> '', ].join('n')); });

Discussion:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have:
Change:
private _threadService: IThreadService; private _proxy: MainProcessVSCodeAPIHelper; private _pluginService: IPluginService; <ins> private _telemetryService: ITelemetryService; </ins> version: typeof vscode.version; <ins> env: typeof vscode.env; </ins> Uri: typeof vscode.Uri; Location: typeof vscode.Location; Diagnostic: typeof vscode.Diagnostic;

Discussion:
I'm not sure if this is an issue in vscode, or typescript, or a DT package, but vscode is complaining about the "funding" field requiring 2 properties, which is incorrect (the other one is "type", and it's optional). <img width="440" alt="Screen Shot 2022-03-14 at 2 36 39 PM" src="https://user-"If this is the wrong place to file it, please point me to the right one :-) Thanks!
(happy to do the work to fix it, too, if someone can point me to where they're defined)
Most likely this is provided by SchemaStore and was just recently UPD. Documentation doesn't have any examples of objects only with field so it's unclear from docs if it's possible to omit field unless you check implementation (or do the implementation ). Maybe it make sense to have at least one object without field in npm docs?
Yes, this needs to be adopted in the SchemaStore. Marking as duplicate of
The docs are irrelevant; to document the types for something, you need to check the actual behavior. Thanks, I’ll follow it there.
Change:
range: new Range(startLineNumber, 1, startLineNumber, oldIndentation.length + 1), text: newIndent }); <del> firstLineText = newIndent + firstLineText.substr(oldIndentation.length); </del> <ins> firstLineText = newIndent + firstLineText.substring(oldIndentation.length); </ins> } else { const indentMetadata = getIndentMetadata(model, startLineNumber, this._languageConfigurationService);

Discussion:
create a TS file make sure the file is configured to insert Tabs (from the status bar) place a character in your clipboard paste it at the beginning of the file :bug: observe nothing happens
This seems related to Auto indent. Setting fixes the issue
After investigating, this seems to happen because after pasting a new line character, the code becomes as follows: The method of the is called and it performs automatic re-indentation. In your case, since there is nothing above that line, the indentation level on that line is zero. The inserted indentation is then removed. It is possible to see this in more detail in the following example: I believe this behavior makes sense when the pasted text contains characters other than whitespace characters. Perhaps what I could do is to not trigger the re-indentation when only whitespace characters are pasted. This could be considered then as intended indentation adjustment.
Change:
private _getLayoutInfo() { const options = this._editor.getOption(EditorOption.inlayHints); <ins> const padding = options.padding; </ins> const editorFontSize = this._editor.getOption(EditorOption.fontSize); <ins> const editorFontFamily = this._editor.getOption(EditorOption.fontFamily); </ins> let fontSize = options.fontSize; if (!fontSize || fontSize < 5 || fontSize > editorFontSize) { fontSize = editorFontSize; } <del> const fontFamily = options.fontFamily || this._editor.getOption(EditorOption.fontFamily); return { fontSize, fontFamily, padding: options.padding }; </del> <ins> const fontFamily = options.fontFamily || editorFontFamily; const isUniform = !padding && fontFamily === editorFontFamily && fontSize === editorFontSize; return { fontSize, fontFamily, padding, isUniform }; </ins> } private _removeAllDecorations(): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: WindowsNT x64 10.0. Steps to Reproduce: Inlay Hints to use 100% of the editor's font size. any extension that provides inlay hints, open a file with inlay hints. a. (I tested this with a very basic TypeScript file, with the TypeScript extension's inlay hints enabled) that the hints are an entire 1px lower than they should be. (Aaa!! Terrifying!) ! Line 496 adds a rule to inlay hints: Disabling the resulting style in the inspector temporarily fixes the problem, aligning the baseline of the inlay hints with the baseline of the surrounding code. ! I've already made (and partially tested) , and I'm making this ticket in order to link it to my pull request. <!-- is this how you do things? --<!-- oops! hash changed because i changed the wording --
Change:
} ); }); <ins> test('minimizeInlineCompletion', async () => { const model = createTextModel('fun'); const result = minimizeInlineCompletion(model, { range: new Range(1, 1, 1, 4), text: 'function' })!; assert.deepStrictEqual({ range: result.range.toString(), text: result.text }, { range: '[1,4 -> 1,4]', text: 'ction' }); }); </ins> }); const provider: CompletionItemProvider = {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0-insider (user setup) OS Version: Windows_NT x64 10.0. List of extensions: None, all are disabled Steps to Reproduce: a new typescript file. , the suggestions widget opens and the first suggestion is . gray text however, only shows , it's missing the last character. 've attached a gif. Notice how when I type , the gray text displays but when I type , it shows . !
can you please verify todays insider build fixes this?
Yes, it has been fixed!
Change:
'out-build/vs/workbench/contrib/debug/**/*.json', 'out-build/vs/workbench/contrib/externalTerminal/**/*.scpt', 'out-build/vs/workbench/contrib/terminal/browser/media/*.ps1', <del> 'out-build/vs/workbench/contrib/terminal/browser/media/.zshrc', </del> 'out-build/vs/workbench/contrib/terminal/browser/media/*.sh', <ins> 'out-build/vs/workbench/contrib/terminal/browser/media/*.zsh', </ins> 'out-build/vs/workbench/contrib/webview/browser/pre/*.js', 'out-build/vs/**/markdown.css', 'out-build/vs/workbench/contrib/tasks/**/*.json',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider OS Version: MacOS12.2.2 Steps to Reproduce: with setting new terminal <img width="1440" alt="image" src="https://user-"
Thanks, we're aware of this issue and have been working toward its resolution
Change:
OutputRendererRegistry.registerOutputTransform(JavaScriptRendererContrib); OutputRendererRegistry.registerOutputTransform(HTMLRendererContrib); <del> OutputRendererRegistry.registerOutputTransform(MdRendererContrib); </del> OutputRendererRegistry.registerOutputTransform(ImgRendererContrib); OutputRendererRegistry.registerOutputTransform(PlainTextRendererContrib); OutputRendererRegistry.registerOutputTransform(JSErrorRendererContrib);

Discussion:
VS Code version: 1.63.0-insider Jupyter Extension version : v2021.10. Python Extension version : v2021.12.-dev OS : Windows 11 Python and/or Anaconda version: 3.9.7 Type of virtual environment used : N/A Jupyter server running: Local Render correctly the Markdown text using the default renderer: ! This is the correct rendering for this: ! a new Jupyter notebook a new cell code with the following Python: Ctrl-Enter to render cell Via "Choose Output Minetype", selecting the "non default" renderer (i.e. the one with "(vscode.markown-language-feature") for Markdown: ! Gives the expected result: ! Also, I could not find a setting allowing me to make the functioning "Output Mimetype" the default... Thanks!
The actual repro attached.
this might be another example of the wrong renderer being chosen.
I get the correct default renderer first time now. text/plain is the only other output option. !
Change:
import { CancellationToken } from 'vs/base/common/cancellation'; import { IDisposable } from 'vs/base/common/lifecycle'; <del> import { IRange } from 'vs/base/common/range'; </del> import { URI } from 'vs/base/common/uri'; <ins> import { Selection } from 'vs/editor/common/core/selection'; </ins> import { LanguageSelector } from 'vs/editor/common/languageSelector'; import { ISubmenuItem } from 'vs/platform/actions/common/actions'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; export interface IShareableItem { resourceUri: URI; <del> location?: IRange; </del> <ins> selection?: Selection; </ins> } export interface IShareProvider {

Discussion:
Testing My extension's provider is not receiving the within the passed to its I think this's caused by this -

Testing takes a but doesn't respect the selector's . I created an extension which uses Share Provider API, but its share contribution wasn't being invoked. It seems the language isn't being passed - see 3rd arg being an empty string .
I observe the same, using: registers the share provider, however as soon as I add a language, this is no longer the case
Change:
if (data) { this._onDidEndInstallTypings.fire(data); } <ins> } else if (event.event === 'typesInstallerInitializationFailed') { const data = (event as Proto.TypesInstallerInitializationFailedEvent).body; if (data) { this._onTypesInstallerInitializationFailed.fire(data); } </ins> } } else { throw new Error('Unknown message type ' + message.type + ' recevied');

Discussion:
VSCode Version: Code 1.10.0 (, 2017-03-01T17:09:34.031Z) OS Version: Linux x64 4.5.5-300.fc24.x86_64 Extensions: none Steps to Reproduce: -Does not show type-specific proposals There is a single file in the cache: with just the empty object in it. /cc
The root cause seems to be that is not installed. I'm investigating this on other platforms as well
Two issues are tracking this on the TypeScript side: No error being generated: Add error message to typings install failure:
With TS 2.2.2 insiders we just picked up, an error notification is now generated in this case. It still does not have a good user facing message about not having npm installed. That is being tracked by
We don't handle the new event from the TS Server yet.
Change:
"vscode-oniguruma": "1.7.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.7", "xterm-addon-canvas": "0.5.0-beta.2", "xterm-addon-image": "0.4.2", "xterm-addon-search": "0.13.0-beta.2", "xterm-addon-serialize": "0.11.0-beta.2", </del> <ins> "xterm": "5.3.0-beta.17", "xterm-addon-canvas": "0.5.0-beta.5", "xterm-addon-image": "0.4.3", "xterm-addon-search": "0.13.0-beta.4", "xterm-addon-serialize": "0.11.0-beta.4", </ins> "xterm-addon-unicode11": "0.5.0", <del> "xterm-addon-webgl": "0.16.0-beta.2", "xterm-headless": "5.3.0-beta.7", </del> <ins> "xterm-addon-webgl": "0.16.0-beta.4", "xterm-headless": "5.3.0-beta.17", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" }

Discussion:
Testing Enabled smooth scrolling, reloaded the window but it looks like smooth scrolling is not working in the following scenarios: page up/page down while jumping between search results
Upstream:
try try