jiebi/CodeConvo huggingface dataset:
Change:
switch (this._countBadgeConfig.read(reader)) { case 'all': { const repositories = this._repositories.read(reader); <del> return [...Iterable.map(repositories, r => ({ ...r.provider, resourceCount: this._getRepositoryResourceCount(r) }))]; </del> <ins> return [...Iterable.map(repositories, r => ({ provider: r.provider, resourceCount: this._getRepositoryResourceCount(r) }))]; </ins> } case 'focused': { const repository = this._activeRepository.read(reader); <del> return repository ? [{ ...repository.provider, resourceCount: this._getRepositoryResourceCount(repository) }] : []; </del> <ins> return repository ? [{ provider: repository.provider, resourceCount: this._getRepositoryResourceCount(repository) }] : []; </ins> } case 'off': return [];

Discussion:
Type: <bBug</bAfter updating for this new version, the Source Control tab is not showing the badge even with the option "Show badge" activated. VS Code version: Code 1.91.0 (Universal) (, 2024-07-01T18:54:18.541Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ flutter-snippets3.0.0 dart-code3.92.0 flutter3.92.0 flutter-find-unused-assets-and-dart-files1.0.2 bloc6.6.6 flutter-coverage0.0.4 kotlin0.2.34 copilot1.212.0 copilot-chat0.17.1 todo-tree0.0.226 live-server0.4.14 material-icon-theme5.4.2 vscode-coverage-gutters2.11.1 lcov-lang1.0.1 vscode-conventional-commits1.25.0 vscode-icons12.8.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I've updated to latest version because of the fix and the problem persists. !
thank you very much for reporting this issue. Fix will be available in Insiders and in the next Stable release.
Change:
tokenSource.dispose(); const searchLength = Date.now() - searchStart; this.logService.trace(`whole search time | ${searchLength}ms`); <del> return notebookResult ? { ...currentResult, ...notebookResult.completeData } : currentResult; </del> <ins> return { results: currentResult.results.concat(notebookResult.completeData.results), messages: currentResult.messages.concat(notebookResult.completeData.messages), limitHit: currentResult.limitHit || notebookResult.completeData.limitHit, exit: currentResult.exit, stats: currentResult.stats, }; </ins> } async search(query: ITextQuery, onProgress?: (result: ISearchProgressItem) => void): Promise<ISearchComplete> {

Discussion:
to , run a text search search is running, hit cancel on the "downloading repository index..." notification in the bottom right corner :bug: search view should show two messages (see below) but only the first one shows up !
Saw the notification about indexing but it was before I clicked search and now whenever I click search I don't see the notification come up.
I believe that you can try to do this with a larger repo (like ), and there should be enough time to cancel the index. Not too sure how to remove the index once it's downloaded, but you can try that first!
You can delete the downloaded index with the Delete All Repository Indexes command
The search result message changed but I see two messages at least !
Change:
.monaco-editor .peekview-widget .head .peekview-title { display: flex; <del> align-items: center; </del> <ins> align-items: baseline; </ins> font-size: 13px; margin-left: 20px; min-width: 0;

Discussion:
VS Code Version: 1.73.1 OS Version: Win 11 Steps to Reproduce: the PeekViewWidget (eg using Peek Definition, or Show Error) text in the title bar is misaligned Fix: I have a PR, it's trivial. !
Change:
if (this.previouslyFocusedItem !== undefined && this.previouslyFocusedItem !== this.focusedItem) { this.viewItems[this.previouslyFocusedItem]?.blur(); } <del> const actionViewItem = this.focusedItem !== undefined && this.viewItems[this.focusedItem]; </del> <ins> const actionViewItem = this.focusedItem !== undefined ? this.viewItems[this.focusedItem] : undefined; </ins> if (actionViewItem) { let focusItem = true;

Discussion:
This ask is from the Copilot team in response to feedback they've received. When something is represented via only an icon, and is focused via keyboard, we should automatically focus the tooltip.
cc
related
we would also want to do this for all toolbars <img width="202" alt="Screenshot 2023-11-01 at 10 12 16 AM" src=""
Just out of curiosity, what does "focus the tooltip mean"? Does it mean "make the tooltip visible"? (sorry- the language is a bit confusing. tooltips are not actually focusable, right?)
yes I think meant to show the hover, not focus it as that would break left/right navigation.
Yep, it just shows the hover, doesn't focus it.
Change:
constructor( private readonly input: ISCMInput, <del> @IContextKeyService private readonly contextKeyService: IContextKeyService, </del> <ins> @IContextKeyService contextKeyService: IContextKeyService, </ins> @IStorageService private readonly storageService: IStorageService ) { super();

Discussion:
a change to a file the file another view so that the SCM view isn't visible the window sparkle will be disabled when you open the SCM view
nice catch! Thank you!
Change:
import * as path from 'path'; import * as platform from 'vs/base/common/platform'; import * as watcher from 'vs/workbench/services/files/node/watcher/common'; <del> import * as nsfw from 'nsfw'; </del> <ins> import * as nsfw from 'vscode-nsfw'; </ins> import { IWatcherService, IWatcherRequest } from 'vs/workbench/services/files/node/watcher/nsfw/watcher'; import { TPromise, ProgressCallback, TValueCallback, ErrorCallback } from 'vs/base/common/winjs.base'; import { ThrottledDelayer } from 'vs/base/common/async';

Discussion:
VSCode Version: 1.17.0 () OS Version: Ubuntu 16.04 LTS Steps to Reproduce: "files.useExperimentalFileWatcher": true and close VS Code a symlink to root directory (must be an absolute link, not relative!): directory containing that symlink in VS Code: processes - one of vs code processes takes high CPU Reproduces without extensions: Yes See also:
Just noticed the same thing on osx...
Updating issue with: vs code version 1.17.0 reproduces without extensions ! Also, I found memory usage increasing over time...
Same issue here vs code version 1.17.2 Even after closing the VsCode the Code Helpers is still running with 100% CPU usage.
Reported upstream
Upstream PR
The original PR was closed so I opened one which was merged , just need a release to pull this in.
I have vscode 1.19.2 on Ubuntu. The various nodemodules directories have symbolic links point to each other that form the circular links. The nodemodules is set excluded in "files.watcherExclude". After vscode is started, it uses 100% CPU and memory usage increased dramatically and soon reached the max memory and hang the system. This problem happens whatever useExperimentalFileWatcher is set true or false. The ps shows the problem code process has parameter '--type=watcherService". Attached gdb to the process, it shows the watcher follows through the circular symbolic links in circular. Set "search.followSymlinks": false has no effect,. So this problem still happens in 1.19.2 even with all the right settings in place.
is it possible/easy to patch VS Code to stop this behaviour while waiting for it to hit a release? I have a workspace that causes a 20GB VM to exhaust its memory in about 15 mins because of circular symlinks (it uses lerna).
yeah I'll fork the module to get this in, was hoping I wouldn't need to.
what's the expected behavior after the change? I'm still seeing high CPU on today's insiders version on Ubuntu ! on Mac
the fix is specific to Linux only when you have experimental file watcher set to true in settings (or you have a multi-root workspace open).
If you have this issue, it's not just high CPU usage - your memory will be exhausted within minutes.

With a workspace with circular symlinks in it (it uses lerna and has circular dependencies), I was seeing 20GB of RAM get sucked up in about 15 minutes. Insiders has had the fix for a while now.
thanks, I'll mark as verified since you saw it before :+1:
Change:
const userDataProfileImportExportService = accessor.get(IUserDataProfileImportExportService); const quickPickItems: QuickPickItem[] = [{ id: CREATE_EMPTY_PROFILE_ACTION_ID, <del> label: CREATE_EMPTY_PROFILE_ACTION_TITLE.value, </del> <ins> label: localize('empty', "Empty Profile"), </ins> }, { id: CREATE_FROM_CURRENT_PROFILE_ACTION_ID, <del> label: CREATE_FROM_CURRENT_PROFILE_ACTION_TITLE.value, </del> <ins> label: localize('using current', "Using Current Profile"), </ins> }]; const profileTemplateQuickPickItems = await that.getProfileTemplatesQuickPickItems(); if (profileTemplateQuickPickItems.length) {

Discussion:
VS Code Version: 1.78 Insiders OS Version: Windows 11 Steps to Reproduce: at the Create Profiles drop down. ! "Create" and "Profile" shown 10 times. Suggestion to remove most instances of "Create" and "Profile". Maybe:
I like this suggestion. what do you think?
<img width="630" alt="image" src="https://user-"Do you think word is a repetition? Is this good or shall I add word to template entries too?
Looks good! I think that is just the right number of "Profile" words since "Empty Profile", "Current Profile", and "Profile Template" are "things" we talk about elsewhere. The profile template list looks clear to me
I also like this! Great improvement.
Change:
import * as os from 'os'; import * as path from 'path'; <del> import { Command, commands, Disposable, LineChange, MessageOptions, Position, ProgressLocation, QuickPickItem, Range, SourceControlResourceState, TextDocumentShowOptions, TextEditor, Uri, ViewColumn, window, workspace, WorkspaceEdit, WorkspaceFolder, TimelineItem, env, Selection, TextDocumentContentProvider, InputBoxValidationSeverity, TabInputText, TabInputTextMerge, QuickPickItemKind, TextDocument, LogOutputChannel, l10n, Memento, UIKind, QuickInputButton, ThemeIcon, SourceControlHistoryItem, SourceControl, InputBoxValidationMessage } from 'vscode'; </del> <ins> import { Command, commands, Disposable, LineChange, MessageOptions, Position, ProgressLocation, QuickPickItem, Range, SourceControlResourceState, TextDocumentShowOptions, TextEditor, Uri, ViewColumn, window, workspace, WorkspaceEdit, WorkspaceFolder, TimelineItem, env, Selection, TextDocumentContentProvider, InputBoxValidationSeverity, TabInputText, TabInputTextMerge, QuickPickItemKind, TextDocument, LogOutputChannel, l10n, Memento, UIKind, QuickInputButton, ThemeIcon, SourceControlHistoryItem, SourceControl, InputBoxValidationMessage, Tab, TabInputNotebook } from 'vscode'; </ins> import TelemetryReporter from '@vscode/extension-telemetry'; import { uniqueNamesGenerator, adjectives, animals, colors, NumberDictionary } from '@joaomoreno/unique-names-generator'; import { ForcePushMode, GitErrorCodes, Ref, RefType, Status, CommitOptions, RemoteSourcePublisher, Remote } from './api/git';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Quite often I want to have open only the files that are modified from source control. It would be handy to have a "Close all Unmodified" option that would close any open files that are not modified according to source control.
I would like to contribute on this.
Verification steps: a folder/workspace that contains a git repository auto-save using the setting multiple files, make changes, and save them multiple files but do not make any changes a file, make changes, but do not save it the "Git: Close All Unmodified Editors" command Confirm that all modified files remain open Confirm that the dirty editor remains open Confirm that all unmodified editors are closed
Change:
return createSymlink().then(null, err => { if (err.code === 'EACCES' || err.code === 'ENOENT') { <del> return this.createBinFolder() .then(() => createSymlink()); </del> <ins> return this.createBinFolderAndSymlink(); </ins> } return TPromise.wrapError(err);

Discussion:
Issue Type: <bBug</bInstalling command line tool changes ownership of away from to . Also, symlink is created as owned by . Please don't do that: not everyone is using Homebrew. VS Code version: Code 1.21.1 (, 2018-03-14T14:39:09.335Z) OS version: Darwin x64 17.4.0 <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ solargraph0.13.0 Ruby0.17.0 slim0.1.2 ayu0.14.0 </detailsReproduces without extensions <!-- generated by issue reporter --
how did you install VS Code ?
Straight from the official , on a fresh new (re)install of macOS. Since I knew about the behaviour beforehand I checked the status at each step so as to open this issue: unzip move to start at this point there are no changes: is still + then a warning dialog shows up about launching an AppleScript through which will need elevated privileges, hence ask for authentication provide authentication when asked at this point, has been installed and ownership has been altered Expected behaviour: preserve ownership install inheriting ownership of
It's a good catch, though I was expecting this issue to come up much much earlier. This has been working this way for 2 years and I believe it's the first time someone has mentioned it. I'll accept a PR to fix it.
Not surprising since I suppose most people use Homebrew on Darwin, and of those who do not, many won't go and randomly check ownership of that folder, which typically occurs only once since as soon as the symlink is there no further operation is required, and the manual fix is thus a one-shot job. I merely happen to care about such things as programs requiring me to enter admin credentials and so have noticed the behaviour some time ago but was only with it due to a reinstall, so thought I might as well bring it up. Anyway, PR opened.
Change:
export class WindowsShellHelper { private _childProcessIdStack: number[]; private _onCheckShell: Emitter<TPromise<string>>; <ins> private _wmicProcess: cp.ChildProcess; private _isDisposed: boolean; </ins> public constructor( private _rootProcessId: number,

Discussion:
Steps to reproduce: and kill terminal very quickly This can likely happen when the terminal is killed during a call.
I can still repro this with the same stack, I don't think the PR fixes the right issue. It fails on this line, because is null: A null xterm object is passed into the constructor, which implies that the terminal instance was disposed, so I think the problem is the terminalInstance being disposed while is running:
Change:
"statusBar.noFolderBackground": "#001126", "statusBar.debuggingBackground": "#001126", "activityBar.background": "#001733", <ins> "activityBarItem.settingsProfilesBackground": "#003271", </ins> "progressBar.background": "#bbdaffcc", "badge.background": "#bbdaffcc", "badge.foreground": "#001733",

Discussion:
The original designs had something closer to this for the default background color. IMO it isn't trying to be an icon like the other items and the border makes it feel like an icon vs. a unique element. I also think the background and foreground should be the only customizable elements to start. I think I saw a foreground token, but not sure it was possible to do background yet. <img width="247" alt="CleanShot 2022-09-26 at 16 29 09 src="https://user-"
I also like this more over the border For example here this looks not too different from the actions above even though it is about profiles: <img width="297" alt="image" src="https://user-"
!
I like it but maybe with smaller font size? Here is with for example: !
Current font size goes well with all (emoji, codicons) and also symmetric with activity bar icons.
Change:
return undefined; } <del> const commitCount = await this.repository.getCommitCount(`${refId1}...${refId2}`); return { id: ancestor, ahead: commitCount.ahead, behind: commitCount.behind }; </del> <ins> try { const commitCount = await this.repository.getCommitCount(`${refId1}...${refId2}`); return { id: ancestor, ahead: commitCount.ahead, behind: commitCount.behind }; } catch (err) { this.logger.error(`Failed to get ahead/behind for '${refId1}...${refId2}': ${err.message}`); } return undefined; </ins> } provideFileDecoration(uri: Uri): FileDecoration | undefined {

Discussion:
Type: <bBug</bI simply switched to a branch, perhaps with a rather long name. On this branch, the source control tree doesn't open and remains in a collapsed state. VS Code version: Code 1.85.1 (, 2023-12-13T09:49:37.021Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-nginx-conf0.3.2 path-intellisense2.8.5 vscode-markdownlint0.53.0 vscode-eslint2.4.2 gitlens14.6.1 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-nginx-conf-hint0.3.0 react-component1.1.0 svg1.5.3 vscode-styled-components1.7.0 vscode-docker1.28.0 csdevkit1.1.16 csharp2.14.8 vscode-dotnet-runtime2.0.0 vscodeintellicode-csharp0.1.26 vscode-kubernetes-tools1.3.15 remote-containers0.327.0 remote-wsl0.81.8 powershell2023.8.0 nginx-formatter0.0.13 vscode-yaml1.14.0 vscode-nginx0.6.0 vscode-asciidoc0.0.3 vscode-styled-components1.7.8 vscode-nginx0.7.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
are you able to reproduce the issue with the latest VS Code Insiders release?
It can still be reproduced withe latest VS Code Insiders Release. I attach a film. My branch name: bugfix-CAR-5045-loading-compositions-component-order-messed-up-when-selecting-lumped-from !
thanks for the recording. Could you also please share the contents of the git output window which you can access by invoking the "Git: Show Git Output" command from the command palette. Thanks!

Also, can you still reproduce the issue if you set the following settings to : scm.showIncomingChanges scm.showOutgoingChanges
2024-01-08 11:34:18.008 [info] fatal: failed to stat 'refs/heads/bugfix-CAR-5045-loading-compositions-component-order-messed-up-when-selecting-lumped-': Filename too long
what version of VS Code are you using? Are you using the latest VS Code Insiders release?
Version: 1.86.0-insider (user setup) Commit: Date: 2024-01-08T05:36:56.355Z Electron: 27.1.3 ElectronBuildId: Chromium: 118.0.5993.159 18.17.1 V8: 11.8.172.18-electron.0 OS: Windows_NT x64 10.0.
are you saying that you are still able to reproduce this issue with the latest VS Code Insiders release? Thanks!
Duplicate of
Change:
description: CommentThreadRangeDecorator.description, isWholeLine: false, zIndex: 20, <del> className: 'comment-thread-range' </del> <ins> className: 'comment-thread-range', shouldFillLineOnLineBreak: true </ins> }; this.decorationOptions = ModelDecorationOptions.createDynamic(decorationOptions);

Discussion:
I think a full range decoration would look nicer here: ! You can also use :
Last time I looked at this I didn't know about . With , I like this much more.
I this last milestone!
Is there any way to make the border only go around the outside of the selected area? Here's an example with the border as it currently is:
Unfortunately not, and it would be very complex to do that. I would just not use a border.
Change:
depth?: number; } <ins> export interface InitOptions { defaultBranch?: string; } </ins> export interface RefQuery { readonly contains?: string; readonly count?: number;

Discussion:
I would have expected that the command creates a repository with a branch 'main'. I was using the latest insider: This is the repository created using 'Publish to Github'
Related to
In this particular scenario we should honor the default branch setting on GitHub rather than the VS Code setting.
Change:
return new Dimension(elDocument.documentElement.clientWidth, elDocument.documentElement.clientHeight); } <ins> if (fallback) { return getClientArea(fallback); } </ins> throw new Error('Unable to figure out browser width and height'); }

Discussion:
In web opening an aux window results in an exception.
Works fine for me now - only thing is that new copied windows don't have codicons. ! Also, was testing behavior vs. what we have on desktop in insiders, and noticed that on web we cannot copy a copied window, but not sure if this is intended or if it's even needed in real life scenarios. !
Yeah you have to disable popup blockers in web. I can see if we get the icon to work.
Change:
"editorGroupHeader.tabsBackground": "#131510", "editorLineNumber.activeForeground": "#adadad", "tab.inactiveBackground": "#131510", <del> "tab.lastPinnedBorder": "#5e452b", </del> <ins> "tab.lastPinnedBorder": "#51412c", </ins> "titleBar.activeBackground": "#423523", "statusBar.background": "#423523", "statusBar.debuggingBackground": "#423523",

Discussion:
The grey used as the pinned tab separator could be a bit stronger and I suggest it is the same grey as for the View separators. !
Yeah, this color is pretty much randomly selected. would you be interested in picking colors for our default themes? Just today I pushed to add the color to our default themes but I did not really spend a lot of time thinking about which color fits best. Most often I picked the border color of the peek view inside the editor. The color key is
Are we sure we don't want to push this as a default for all themes? Because out of the box it's nearly impossible to tell the difference in other themes. Like below, can you tell which files are pinned? !
yeah if you can find a good base color and rule for it, I am all up for it