jiebi/CodeConvo huggingface dataset:
Change:
"list.activeSelectionIconForeground": "#FFF", "list.focusAndSelectionOutline": "#90C2F9", "terminal.inactiveSelectionBackground": "#E5EBF1", <del> "widget.border": "#d4d4d4" </del> <ins> "widget.border": "#d4d4d4", "actionBar.toggledBackground": "#dddddd" </ins> }, "tokenColors": [ {

Discussion:
Testing <img width="273" alt="image" src=""Should use a toggle state instead, or a new icon. You can see it looks the same as the other disabled action
I agree, but then this also applies to the "toggle whitespace" button. I think we need some pressed state for toolbar buttons. What are your thoughts ?
I'd prefer to have an icon per state. That's how we have done it in other toolbars (like output scroll lock).
<img width="584" alt="image" src=""Mockup with a toggled state. Having an icon per state makes sense for the lock icon, because the reverse icon metaphors make intuitive sense. This is not the case for the whitespace and fold icon here though. cc
We do use toggles elsewhere. One easy example: <img width="472" alt="CleanShot 2023-07-07 at 09 13 11 src=""But I think it depends what you're trying to do. Many boolean settings make sense as a sort of enabled/disabled toggle, while others are more specific metaphors (lock/unlock as Hylke mentioned above).
I'm still in favor of a toggle border as we already use this concept in the find widget and it is a universally understood concept, but has to agree. Alternatively, we can explore other icons. Or we leave it as is.
No, I don't need to agree (but also not to like it). If you wanna explore or something similar go ahead but we should be aware that this is also open to extensions, so we need to deal with every (contributed) button looking like this in the future
I think this approach looks good to me It is more aligned with the vs code current design and should be replaced the current find widget toggle ui
Verification steps: Notice that in the diff editor buttons have a background now to indicate their toggled state: !
Change:
import { ExtensionTipsService } from 'vs/platform/extensionManagement/node/extensionTipsService'; import { IMainProcessService, MainProcessService } from 'vs/platform/ipc/common/mainProcessService'; import { RemoteStorageService } from 'vs/platform/storage/common/storageService'; <ins> import { IRemoteSocketFactoryService, RemoteSocketFactoryService } from 'vs/platform/remote/common/remoteSocketFactoryService'; import { RemoteConnectionType } from 'vs/platform/remote/common/remoteAuthorityResolver'; import { nodeSocketFactory } from 'vs/platform/remote/node/nodeSocketFactory'; </ins> class SharedProcessMain extends Disposable {

Discussion:
Type: <bBug</b[Window Title] Visual Studio Code - Insiders [Content] Unable to launch browser: "Timed out waiting for browser connection" The above worked fine till last update and it works fine in current stable release. A browser window opens but then i get the above timeout message. Output of console output: VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-17T05:27:38.052Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux arm64 5.15.0-1030-oracle Remote OS version: Linux arm64 5.15.0-1030-oracle <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ helium-icon-theme1.0.0 vscode-edge-devtools2.1.1 remote-ssh0.103. remote-ssh-edit0.86.0 remote-explorer0.4.0 ayu1.0.5 python-extended-snippets0.0.1 vscode-django1.10.0 vscode-tailwindcss0.9.11 ruff2023.16.0 rescript-vscode1.16.0 vscode-eslint2.4.0 gitlens13.6.0 copilot-chat0.1. copilot-labs0.14.884 copilot-nightly1.86.92 svg1.5.2 i18n-ally2.9.1 MagicPython1.1.0 ts-error-translator0.8.0 git-graph1.30.0 black-formatter2023.2.0 python2023.8.0 vscode-pylance2023.5.20 vsliveshare1.0.5864 vscode-thunder-client2.6.2 LiveServer5.7.9 vs-code-prettier-eslint5.1.0 sonarlint-vscode3.17.0 vscode-pets1.22.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Seems like forwarded ports are not working at all. None of my manually forwarded ports work.

I get the above error message in output window whenever I try to access any forwarded port. When i manually forward port and try to access it:
Seems like is undefined which is causing this error to be caught and displayed
Temporary workaround: Use older version of vscode insider - Then turn off auto updates and background updates.
Facing the same issue on my VSCode Insiders as well. Was working fine on 16th May 2023, and the problem started yesterday (17th May 2023). For me, this occurs when I am trying to port-forward a webpage loaded on my virtual machine to my local machine. Below is a sample of the logs from the "Shared" Output tab. The same error related to the is .
I believe this is the issue I am encountering.
The latest work version: 1.79.0. SystemSetup: UserSetup:
Range of commits where this occurred:
or I think this is related to , though I'm not sure how. This comment is correct about where the error is coming from:
Thanks for the detailed issue!
Change:
assert.ok(!extractRangeFromFilter('')); assert.ok(!extractRangeFromFilter('/some/path')); assert.ok(!extractRangeFromFilter('/some/path/file.txt')); <del> assert.ok(!extractRangeFromFilter('/some/@path'), 'paths like as /node_modules/@types/ should be supported'); </del> for (const lineSep of [':', '#', '(', ':line ']) { for (const colSep of [':', '#', ',']) {

Discussion:
open a file open an empty group to the side and focus it open quick open for files type a typescript file name add @ to enable symbol search :bug: the editor in group 1 changes, not the active group
Caused by , TIL about adding @ after a filename
I had seen your PR and actually thought you would fix an issue associated with that feature
I was fixing specifically in a folder/file name before a line/col match
To clarify the feature: typing in a file search allows to ad-hoc flip into a "go to symbol" without having to first open the file. I think I limit this to having at the end of the thing you search for. I.e. if you paste a path with a somewhere it would not trigger. I wonder why I am not doing this when you type for goto line
before it was only checking for the existence of @ and disabling line/col filter extraction if so
I am more arguing that when you search for a file and then type for a line/col pattern, we should automatically open the file in the background and initiate "Go to line", same as we do now for when you type for symbols.
that would be awesome . This was just a drive by fix from me, not sure if is tracking this
Change:
keybinding: { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, <del> NOTEBOOK_CELL_LIST_FOCUSED, ContextKeyExpr.not(InputFocusedContextKey), </del> NOTEBOOK_EDITOR_EDITABLE, <del> NOTEBOOK_CELL_EDITABLE </del> <ins> ContextKeyExpr.not(InputFocusedContextKey), </ins> ), primary: KeyMod.CtrlCmd | KeyCode.Slash, weight: KeybindingWeight.WorkbenchContrib

Discussion:
Testing 1) select a cell 2) cmd+/ -cell commented 3) ESC 4) cmd+/ -nothing 5) arrow-up 6) Cmd+/ -nothing 7) Shift + arrow-up 8) Cmd+/ -two cells commented I don't really understand in which mode I'm in after step 3 and 5. I would expect Cmd+/ to work in those states.

Testing 1) set a selection within a given cell 2) ESC -cell gets focus 3) Cmd+/ -selection from step 1 is lost and all content of the cell is selected 4) Arrow-up or down 5) Cmd+/ -now you have two cells with fully selected content I would expect that the selection from step 1 is retained/restored. And, if I don't have a selection after step 3, no selection would be visible.
It looks like step 2 still causes the selection to be lost and step 3 still comments out everything.
pair verified with
Change:
assert.ok(data.documentUri.toString().startsWith('file:///c%3A/')); }); <ins> test('Should not render command links by default', () => { const md = new MarkdownString(`[command1](command:doFoo) <a href="command:doFoo">command2</a>`, { supportHtml: true }); const result: HTMLElement = renderMarkdown(md).element; assert.strictEqual(result.innerHTML, `<p>command1 command2</p>`); }); test('Should render command links in trusted strings', () => { const md = new MarkdownString(`[command1](command:doFoo) <a href="command:doFoo">command2</a>`, { isTrusted: true, supportHtml: true, }); const result: HTMLElement = renderMarkdown(md).element; assert.strictEqual(result.innerHTML, `<p><a data-href="command:doFoo" href="" title="command:doFoo">command1</a> <a data-href="command:doFoo" href="">command2</a></p>`); }); </ins> suite('PlaintextMarkdownRender', () => { test('test code, blockquote, heading, list, listitem, paragraph, table, tablerow, tablecell, strong, em, br, del, text are rendered plaintext', () => {

Discussion:
Issue Type: <bBug</bHello, Regarding the , in Markdown this: Renders a link. In a VS Code Extension, this is also possible: Creating a link to run a command. One would think creating an actual anchor link like this: Would work but the click does not execute the command. VS Code version: Code 1.63.0 (, 2021-12-07T05:18:59.299Z) OS version: Linux arm64 5.15.7-1-MANJARO-ARM Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ vscode-eslint2.2.2 gitlens11.7.0 vscode-drawio1.6.4 vsliveshare1.0.5242 </details<!-- generated by issue reporter --
can i take this?
I think they'd be happy if you created a PR. For completeness: works: but the cursor does not change to a hand icon like if was populated.
Thanks, will take a look
This is what I found. In markdown links are detected at two places: detects anything starting with http:// or https:// or file:// checks for and returns anything inside () as URI That's why is detected as a link but isn't. I couldn't get to work. I tried holding ctrl while clicking it and tried in preview as well. Can you tell me how to reproduce it?
You'll need to for it to take an action. The example in the link is probably the easiest. After registration create a MarkdownString containing the registered command. In regards to the linked example: You should be able to click on it and see the console log. Note that the cursor doesn't change to a hand icon.
Have you found any solution? For me even doesn't work. :( I've used a registered and available command.
The way I implemented Markdown and executing a registered command (through ) was by adding a . The structure is very particular because it is an implementation of the and is something like this: Make sure you are using the correct VS Code version too.
Command links in should now also work for normal elements included in the markdown (you have to set and on the to enable this)
where should links work? I tried this in a completion item and neither link syntaxes work: !
Sorry for not adding verification details. The markdown string needs to both trusted and have html enabled:
Change:
args.push('--format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref)'); } <ins> // On Windows and macOS ref names are case insensitive so we add --ignore-case // to handle the scenario where the user switched to a branch with incorrect // casing if (isWindows || isMacintosh) { args.push('--ignore-case'); } </ins> if (/^refs/(head|remotes)//i.test(name)) { args.push(name); } else {

Discussion:
I found issue that when switching to branch beggining from capital letter there is different treated by VS code plugin VS code version: Version: 1.77.1 (user setup) Commit: Date: 2023-04-04T23:21:11.906Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: WindowsNT x64 10.0. Sandboxed: No Git extension version: v1.0.0 and is bulit-in Git version: 40.0.windows.1 Let's describe it: created new branch in project 'feature/case-sensitive-issue' switched to new branch: staged and commited on new branch: could see commit and I was able to undo commit from button or conext menu ! switched to smae branch, but with upper-case in "Feature" path part: could not undo my commit from button: ! After try to undo commit from context menu I had warning: ! tried to undo commit using git api: It laready worked! ! tried to commit last changes again and it worked and was commited to branch "feature/case-sensitive-issue" although I was on branch "Feature/case-sensitive-issue". ! I don't know where is the problem: in git api or in git extension. Please help me with this issue and fix it. Regards, Michal
Branches view on your screenshots is most likely from GitLens extension, not built-in Git. Check if you have GitLens extension and if it's available if you disable it. Most likely this should be reported there first.
thnank you for your suggestion. You was right, screens are from gitlens extension, except one with warning "Can't undo because HEAD doesn't point to any commit". This is from Git built-in extension. After disabling gitlens I successfully reproduced described warning.
The "Can't undo because HEAD doesn't point to any commit" error is caused by the fact that we cannot get the details of the current branch when incorrect casing is used. This is due to the fact that we are not calling with the option. On Windows and macOS branch names are case-insensitive while on Linux and they are case sensitive.

Closing a repository on Windows that contains branch names that only differ by case, will result in only one branch being pulled. One potential solution would be that on Windows and macOS we include the flag.
Change:
} } <del> const validLanguageId = grammar.language && this._languageService.isRegisteredLanguageId(grammar.language) ? grammar.language : null; </del> <ins> const validLanguageId = grammar.language && this._languageService.isRegisteredLanguageId(grammar.language) ? grammar.language : undefined; </ins> function asStringArray(array: unknown, defaultValue: string[]): string[] { if (!Array.isArray(array)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 89.1 x64 OS Version: Edition Windows 11 Pro Version 23H2 Installed on ‎2023-‎11-‎28 OS build .3593 Experience Windows Feature Experience Pack 1000..1003.0 Steps to Reproduce: the VS Code the introduction page of buildin plugin the FEATURES page 's Empty
I am seeing following !
Yes, I see the same. There should be details about supported languages like other built-in plugins.
Can you point me to the place I need to fix this?
Here it is
Change:
public $show(terminalId: number, preserveFocus: boolean): void { this._terminalService.show(!preserveFocus).then((terminalPanel) => { this._terminalService.setActiveTerminalById(terminalId); <ins> if (!preserveFocus) { // If the panel was already showing an explicit focus call is necessary here. terminalPanel.focus(); } </ins> }); }

Discussion:
VSCode Version: 1.5.0 OS Version: OS X 10.11.6 Steps to Reproduce: this snippet to use Then the example Focus is on the newly created terminal and not preserved.
Bug for
Change:
}, handleDiagnostics: (uri: Uri, diagnostics: Diagnostic[], next: HandleDiagnosticsSignature) => { const schemaErrorIndex = diagnostics.findIndex(candidate => candidate.code === /* SchemaResolveError */ 0x300); <del> if (schemaErrorIndex !== -1) { // Show schema resolution errors in status bar only; ref: #51032 const schemaResolveDiagnostic = diagnostics[schemaErrorIndex]; fileSchemaErrors.set(uri.toString(), schemaResolveDiagnostic.message); showStatusBarItem(schemaResolveDiagnostic.message); diagnostics.splice(schemaErrorIndex, 1); } else { statusBarItem.hide(); </del> <ins> if (schemaErrorIndex === -1) { </ins> fileSchemaErrors.delete(uri.toString()); <ins> return next(uri, diagnostics); } const schemaResolveDiagnostic = diagnostics[schemaErrorIndex]; fileSchemaErrors.set(uri.toString(), schemaResolveDiagnostic.message); if (window.activeTextEditor && window.activeTextEditor.document.uri.toString() === uri.toString()) { schemaResolutionErrorStatusBarItem.show(); </ins> } next(uri, diagnostics); } }

Discussion:
testing : Yes, there is now a warning icon in the status bar, but it is difficult to understand its purpose: For a json scheme url with a non-existing hostname the hover message shows this: ! For a json scheme url with a non-existing version number the hover message shows this: ! In both cases the error shown is too low-level and the message does not explain that the status refers to the json scheme of the current editor contents.
FYI
Looks like I misinterpreted what kind of messages I'd get from the backend, sorry for that! We could resort to showing a generic message like 'Unable to resolve JSON schema from (url)', which would probably be sufficient for most issues. I also considered logging the error to console (don't know your policy on that), but if we get whole pages in the error message, that's not an option. Displaying a generic message with the URL only would also Otherwise I guess we'd need to parse the error message to find out which kind and display a meaningful message, but that doesn't seem right. Another implication of this is that we'll probably have to re-add at least one layer of error description to vscode-languageservice-json - I always had a prefix with something like "Unable to resolve (something)", but that might have been a code reloading issue or specific to the way I was testing, by cutting the Internet connection and blocking DNS resolutions. Let me know if a generic error message defined only in the client would work.
That's fine. Users don't really see logs.
I can repro with this setting:
Change:
font-family: var(--monaco-monospace-font); white-space: pre; box-sizing: border-box; <del> opacity: .6; </del> <ins> opacity: .7; </ins> /* Sizing hacks */ bottom: 0px;

Discussion:
Testing There is no hover explaining the sequence counter (I think that's what the block is showing). Being unfamiliar with Notebooks, I didn't know what that UI element was for. It seems to increase as cells are executed. I initially thought it was a result count until I turned on the Notebook status bar. !
There might also be a color contrast issue as the block is small and very faint.
Maybe it could get a tooltip. I'm not sure about color contrast,
You're right in the selected state it doesn't pass the ratio. If we bump the opacity to it will pass: <img width="350" src="https://user-"!
Thanks for fixing it Don't forget the milestone :)
Change:
this._actionbarWidget!.context = [diffEditorModel.modified.uri, providerSpecificChanges, contextIndex]; if (usePosition) { this.show(position, height); <ins> this.editor.setPosition(position); this.editor.focus(); </ins> } <del> this.editor.setPosition(position); this.editor.focus(); </del> } private renderTitle(label: string): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: macos 12.7.3 Steps to Reproduce: Open a file managed by git and split the window by into two parts, A and B. After editing the file on the B side and checking the changes with vscode's git function, and doing other edits on the A side, the cursor will finally jump to the B side.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I upgraded vscode to the latest version 1.86 and the problem is still there
any idea what is happening here? Is the quick diff widget "moving" the focus to the B side?
I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.
It comes from here:
is this something that you can look at? Thank you!
Do I still need to start vscode with --disable-extensions to test it? I have tried this before, disabling all extensions (all extensions are not disabled), and it all comes up with this problem.
no need. I think that we have all the information for now to further investigate the issue.
Yes, I can look at this.
Change:
getGroups(order = GroupsOrder.CREATION_TIME): IEditorGroupView[] { if (this._parts.size > 1) { let parts: EditorPart[]; <del> if (order === GroupsOrder.MOST_RECENTLY_ACTIVE) { parts = distinct([this.activePart, ...this._parts]); // put active part first in this order } else { parts = this.parts; </del> <ins> switch (order) { case GroupsOrder.GRID_APPEARANCE: // we currently do not have a way to compute by appearance over multiple windows case GroupsOrder.CREATION_TIME: parts = this.parts; break; case GroupsOrder.MOST_RECENTLY_ACTIVE: parts = distinct([...this.mostRecentActiveParts, ...this.parts]); // always ensure all parts are included break; </ins> } return parts.map(part => part.getGroups(order)).flat();

Discussion:
Currently we do not really track MRU of editor groups across windows. Some features rely on this though, so we should see if we can track MRU truly across aux windows.
Change:
// Also handle configuration updates this.toDispose.push(this.configurationService.onDidUpdateConfiguration(e => this.onConfigurationUpdated(e.config))); <ins> // Also handle dirty count indicator #10556 this.toDispose.push(this.eventService.addListener2(FileEventType.FILE_DIRTY, (e) => this.updateDirtyIndicator())); </ins> // We are not updating the tree while the viewlet is not visible. Thus refresh when viewlet becomes visible #6702 this.toDispose.push(this.viewletService.onDidViewletOpen(viewlet => { if (viewlet.getId() === VIEWLET_ID) {

Discussion:
VSCode Version: 1.4 OS Version: Windows 10 Steps to Reproduce: a file a symbol that is used in other files Other files that referenced it are opened and show as dirty in tabs, the file list and the count on the explorer badge, but it still says "1 unsaved" next to the "open editors" heading. !
can you look into this?
Hi guys, submitted a PR for this issue. Please let me know if there are any issues.
I think any unread indicator needs to react to events from the text file service and not the stacks model to find out that something got dirty. You might want to revisit this in
Thanks!
Change:
return { command: { command: rebaseWhenSync ? 'git.syncRebase' : 'git.sync', <del> title: localize('scm button sync title', "{0} {1}{2}", icon, behind, ahead), </del> <ins> title: `${icon} ${behind} ${ahead}`, </ins> tooltip: this.state.isActionRunning ? localize('syncing changes', "Synchronizing Changes...") : this.repository.syncTooltip,

Discussion:
The part of the button appears to be getting localized in the pseudo-language extension pack. !
Verified by code review.