jiebi/CodeConvo huggingface dataset:
Change:
@ILanguagePackService private readonly languagePackService: ILanguagePackService, @IPaneCompositePartService private readonly paneCompositePartService: IPaneCompositePartService, @IExtensionManagementService private readonly extensionManagementService: IExtensionManagementService, <ins> @IProgressService private readonly progressService: IProgressService </ins> ) { } private async writeLocaleValue(locale: string | undefined): Promise<void> {

Discussion:
Testing Things I would change: make it clear in the picker that selecting a language from the lower list will install it have a button in the picker that installs and syncs it. don't reveal the extension viewlet don't show that dialog <img width="444" alt="capture" src="https://user-"
is there a way to not show this dialog when installing an extension using the Extension management service? Here's the specific line:
How would you make this clearer? I figured since we had a section called that will always be there on Desktop it's implied that must not be installed. What will the default behavior be then when you accept a quick pick item? That it will install but not sync? That's not what the default is for the button in the extension pane so that seems a bit odd to me. This was to give a progress indication. We do the same thing for the Theme picker. I would like to hide this dialog. I didn't see it locally because Settings Sync isn't available in but I asked Sandeep above.
Yes, you can pass machine scoped flag to avoid this. Passing for this flag will not sync the extension and will sync it.
I thought the main reason for the dialog was to inform the user that something is installed. I can easily live with only the picker Since the dialog offered the option, I thought it is important. I can live with the default without a choice. I found it disturbing. I could live without progress or some window progress.
Change:
import * as DOM from 'vs/base/browser/dom'; import { Disposable, DisposableStore, toDisposable } from 'vs/base/common/lifecycle'; import { Mimes } from 'vs/base/common/mime'; <del> import { dirname } from 'vs/base/common/resources'; </del> import { URI } from 'vs/base/common/uri'; <del> import { MarkdownRenderer } from 'vs/editor/browser/core/markdownRenderer'; </del> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { ILogService } from 'vs/platform/log/common/log';

Discussion:
VS Code version: 1.63.0-insider Jupyter Extension version : v2021.10. Python Extension version : v2021.12.-dev OS : Windows 11 Python and/or Anaconda version: 3.9.7 Type of virtual environment used : N/A Jupyter server running: Local Render correctly the Markdown text using the default renderer: ! This is the correct rendering for this: ! a new Jupyter notebook a new cell code with the following Python: Ctrl-Enter to render cell Via "Choose Output Minetype", selecting the "non default" renderer (i.e. the one with "(vscode.markown-language-feature") for Markdown: ! Gives the expected result: ! Also, I could not find a setting allowing me to make the functioning "Output Mimetype" the default... Thanks!
The actual repro attached.
this might be another example of the wrong renderer being chosen.
I get the correct default renderer first time now. text/plain is the only other output option. !
Change:
unmaximizeWindow(): TPromise<void>; onWindowTitleDoubleClick(): TPromise<void>; show(): TPromise<void>; <del> showMessageBoxSync(options: Electron.MessageBoxOptions): number; showMessageBox(options: Electron.MessageBoxOptions): TPromise<IMessageBoxResult>; showSaveDialog(options: Electron.SaveDialogOptions, callback?: (fileName: string) => void): string; showOpenDialog(options: Electron.OpenDialogOptions, callback?: (fileNames: string[]) => void): string[]; </del> <ins> showMessageBoxSync(options: MessageBoxOptions): number; showMessageBox(options: MessageBoxOptions): TPromise<IMessageBoxResult>; showSaveDialog(options: SaveDialogOptions, callback?: (fileName: string) => void): string; showOpenDialog(options: OpenDialogOptions, callback?: (fileNames: string[]) => void): string[]; </ins> } export type MenuBarVisibility = 'default' | 'visible' | 'toggle' | 'hidden';

Discussion:
There a few usages of in which is against our layering rules. I'd suggest to move the whole file into an folder
Unfortunately this might not be so simple given 62 references of which some would also need to be lifted up... An alternative would be to define similar interfaces that contain the properties we actually need instead of depending on Electron.
Also: and
I'd favour to lift them all instead blowing up our code size
with our current code organisation I cannot express the proper way for these references. Here are the issues: Moving this service into src/workbench This was my first idea, but it doesn't work. There are references from (our main side of things) into the windows service because the main side basically implements that service. We should not depend from to other than the file that we load into a window. The only way out I see here is to have something like for services that are shared between and . Moving the service from common into electron-browser This will not help because we have depending on the windows service and thus we would reach from into . The only option would be to introduce a new layer that contains the service and that can be accessed by and . To unblock your 2-CU scenario and to use ES6 features in workbench I suggest to that will inline the Electron references. However if we ever want to tackle this properly it needs some serious new code-structure layout on disk. Thoughts?
Yeah, makes sense... It's unfortunate but reality...
Change:
new vscode.Range(2, 3, 2, 7),		// Line commented selector new vscode.Range(3, 3, 3, 7),		// Block commented selector new vscode.Range(4, 0, 4, 2),		// dn inside block comment <del> new vscode.Range(6, 1, 6, 2),		// @ inside a rule whose opening brace is commented </del> <ins> new vscode.Range(6, 1, 6, 2),		// bgc inside a rule whose opening brace is commented </ins> new vscode.Range(7, 2, 7, 4)		// bg after ending of badly constructed block ]; rangesNotEmmet.forEach(range => {

Discussion:
Note: char disable tab after it with setting even with custom snippet the not trigger because char disable tab after it.
closedWith
Actually, reopening since I realized the extension isn't allowing the abbreviations outside of surrounding braces. the latest Emmet doesn't allow + in the expansions now, so you'd have to create custom snippets (with names that don't have +) to get that old behaviour back.
"+" Cheats| 1- 2- 3- 4- 5- 6- 7- 8- 9- 10- 11- 12- 13- 14- 15- 16- 17- 18- 19- 20- 21- 22- 23-
I'm aware there were a lot of snippets with +. The Emmet documentation website is currently outdated. See and
Sorry I didn't know that.
Verifier: verify that in an empty stylesheet document (e.g. CSS), , , , and all have an Emmet suggestion showing up.
Change:
let a11yResponse: string | undefined; const a11yVerboseInlineChat = this._configurationService.getValue<boolean>('accessibility.verbosity.inlineChat') === true; <del> this._chatAccessibilityService.acceptRequest(); </del> <ins> const requestId = this._chatAccessibilityService.acceptRequest(); </ins> const task = this._activeSession.provider.provideResponse(this._activeSession.session, request, progress, requestCts.token); this._log('request started', this._activeSession.provider.debugName, this._activeSession.session, request);

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.
Change:
registerEditorCommand(new DeleteWordStartRight()); registerEditorCommand(new DeleteWordEndRight()); registerEditorCommand(new DeleteWordRight()); <ins> registerEditorCommand(new DeleteInsideWord()); </ins>

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The 'deleteWordLeft' command cannot delete letters on right side of the cursor. We want new function which can delete the whole word. (We submit this issue formally. Sorry.)
To verify, please look for a "Delete Word" action that you can bind to a keybinding if you wish to. The action will delete the current word under the cursor (both to the left and to the right of the cursor) and will delete any trailing whitespace.
I've checked. I could find the "Delete Word" action and bind a keybinding to it. The function works properly. Thank you!
Change:
import { Registry } from 'vs/platform/registry/common/platform'; import { defaultButtonStyles } from 'vs/platform/theme/browser/defaultStyles'; import { IProductService } from 'vs/platform/product/common/productService'; <del> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </del> import { registerNavigableContainer } from 'vs/workbench/browser/actions/widgetNavigationCommands'; import { IEditorProgressService } from 'vs/platform/progress/common/progress';

Discussion:
On the latest Stable or Insiders, the Copilot setting button does not show up in the Settings editor when the Copilot extension is disabled or not installed. ! removed the dependency on the assignment/experimentation service incorrectly, and ended up making it so that the feature was only available in OSS aka from-source builds. The main branch fix is available in The candidate PR is available in . [x] Set up a candidate PR
Change:
for (const action of actionsAtMarker.validActions) { action.highlightRange = action.action.isPreferred; } <ins> if (codeActionSet.allActions.length === 0) { allCodeActions.push(...actionsAtMarker.allActions); } </ins> // Already filtered through to only get quickfixes, so no need to filter again. if (Math.abs(currPosition.column - col) < distance) { currentActions.unshift(...actionsAtMarker.validActions);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Python <img width="296" alt="Screenshot 2023-11-07 at 8 00 18 AM" src=""<img width="312" alt="Screenshot 2023-11-07 at 8 00 30 AM" src=""
Change:
// - the launched process terminates (e.g. due to a crash) processCallbacks.push(async child => { let childExitPromise; <del> if (isMacintosh) { // On macOS, we resolve the following promise only when the child, </del> <ins> if (isBigSur) { // On Big Sur, we resolve the following promise only when the child, </ins> // i.e. the open command, exited with a signal or error. Otherwise, we // wait for the marker file to be deleted or for the child to error. childExitPromise = new Promise<void>((resolve) => {

Discussion:
Testing macOS Mojave 10.14.6 Version: 1.61.0-insider (Universal) Commit: Date: 2021-09-28T05:14:06.244Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 18.7.0 open terminal run
Same with
Nice catch! Two things to be done: 1) Rewire the cli to use old code path for macOS <= 10.15 for the endgame 2) Write wrapper around to be used instead of as follow-up.
Can someone explain what is different in Big Sur compared to older versions?
from the error above the following 3 std pipe arguments are not available on older distros. tool is not public, so I couldn't find the exact release notes where this behavior was changed. For now, the safer change is to not use the path pre Big Sur while we explore alternatives using for these versions in upcoming milestone.
Ok thanks, do we have an issue for that?
Tracked in
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> .mac.web.issue-reporter-body { </del> <ins> .web.issue-reporter-body { </ins> position: absolute; overflow-y: scroll; }

Discussion:
Testing ubuntu chromium 125.0.6422.76 (Official Build) snap (64-bit) F1 Report Issue :bug: the initial size is too small, there are no scrollbars :bug: when resizing the input field grows so that I never see a full submit button <img width="1938" alt="Screenshot 2024-05-28 at 12 05 11" src=""
Same issue on Edge on Windows.
noted! realized i styles only for
Change:
assert.strictEqual(model.normalizeIndentation('  a'), '  a'); assert.strictEqual(model.normalizeIndentation(' a'), ' a'); assert.strictEqual(model.normalizeIndentation('a'), 'a'); <del> assert.strictEqual(model.normalizeIndentation(' t   a'), 'tta'); assert.strictEqual(model.normalizeIndentation(' t  a'), 't   a'); assert.strictEqual(model.normalizeIndentation(' t a'), 't  a'); assert.strictEqual(model.normalizeIndentation(' ta'), 't a'); </del> <ins> assert.strictEqual(model.normalizeIndentation(' t    a'), 'tta'); assert.strictEqual(model.normalizeIndentation(' t   a'), 't   a'); assert.strictEqual(model.normalizeIndentation(' t  a'), 't  a'); assert.strictEqual(model.normalizeIndentation(' t a'), 't a'); assert.strictEqual(model.normalizeIndentation(' ta'), 'ta'); </ins> model.dispose(); });

Discussion:
Issue Type: <bBug</bPlease look this, ! Line 2: "Text" Line 3: .... This is auto indent line. ? (:, : ) ABC
I update this issue. But, It is automaticaly closed. Why? Please look this updated isuue.
What are the steps to reproduce? What is happening versus what you would expect to happen?
First line is, ( is white space, is Tab code) "Text" + -key Actual input is: (The above procedure removes the white space.) [Tab]-key, "Text", (move coursor position to the beginning of line), [Space][Space], (move coursor position to end of line), [Enter] The next cursor position is invalid. Please look the image of issue. I think, this is not serious but incorrect behavior.
Thank you for the extra information. Here are simplified steps: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain if indentation is configured with spaces, the new line will contain
Thanks.
can we have some verification steps?
Posting again with more explanations: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain . <---- this is a bug, the result should be such that the second line aligns with the first line if indentation is configured with spaces, the new line will contain <--- this is a bug, the result should be such that the second line aligns with the first line
Change:
import { API as GitAPI } from './typings/git'; import { publishRepository } from './publish'; import { DisposableStore } from './util'; <del> import { getPermalink } from './links'; </del> <ins> import { getLink } from './links'; </ins> function getVscodeDevHost(): string { return `https://${vscode.env.appName.toLowerCase().includes('insiders') ? 'insiders.' : ''}vscode.dev/github`;

Discussion:
a desktop clone open with some uncommitted changes Continue Edit Session open on :bug: edit session is not applied The reason for this is that we are opening a permalink instead of preserving the current branch checkout so the edit session identifier doesn't match up and the edit session doesn't get applied. This used to work and regressed with the edit session identifier API work, which applies stricter checks to edit session identities. Thanks for finding this in !
not seeing a command
sorry, that should have been , not
Change:
type TreeElement = ISCMResourceGroup | IResourceNode<ISCMResource, ISCMResourceGroup> | ISCMResource; <ins> function splitMatches(uri: URI, filterData: FuzzyScore | undefined): [IMatch[] | undefined, IMatch[] | undefined] { let matches: IMatch[] | undefined; let descriptionMatches: IMatch[] | undefined; if (filterData) { matches = []; descriptionMatches = []; const fileName = basename(uri); const allMatches = createMatches(filterData); for (const match of allMatches) { if (match.end <= fileName.length) { matches!.push(match); } else { descriptionMatches!.push( { start: match.start - fileName.length, end: match.end - fileName.length } ); } } } return [matches, descriptionMatches]; } </ins> interface ResourceGroupTemplate { readonly name: HTMLElement; readonly count: CountBadge;

Discussion:
I often make a lot of changes at once, and then need to commit them. Some changes don't belong together in the same commit, and some aren't ready to be committed at all. The current UI allows me to select some files to be staged for commit and exclude others, but it requires me to carefully select my changes from a potentially very long list. It would be incredibly useful if I could search or filter files by path pattern and stage/unstage all search results. Even better would be if I could search for lines of code and either stage files containing those lines or just the matched lines. This would streamline my git workflow by a lot.
I guess my ideal UI would allow me to: search files by path, and stage/unstage all matched files stage/unstage individually selected files search code in files, and stage/unstage all matched lines stage/unstage individually selected lines stage/unstage all matched files stage/unstage individually selected files
Since last month, SCM supports fancy keyboard navigation and filtering. Simply start typing when focused on the view. A widget will appear which you can use to toggle between simple highlighting and filtering. Currently filtering is done only on file names though, not paths or even code, so I can leave this open for additional filtering fields.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
import { combinedDisposable } from 'vs/base/common/lifecycle'; import { checkProposedApiEnabled, ExtensionIdentifierSet, isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; import { DebugConfigurationProviderTriggerKind } from 'vs/workbench/contrib/debug/common/debug'; <ins> import { equalsIgnoreCase } from 'vs/base/common/strings'; </ins> export interface IExtensionRegistries { mine: ExtensionDescriptionRegistry;

Discussion:
Ah, sorry for the breakage... I believe asking for both is the best option for now but I can also add a "migration" path into the implementation, e.g use when seeing Originally posted by in
Change:
export type LinkHref = ExternalHref | InternalHref | ReferenceHref; <del> function parseLink( </del> <ins> function resolveLink( </ins> document: ITextDocument, link: string, ): ExternalHref | InternalHref | undefined {

Discussion:
while testing a markdown file with a header a notebook with a markdown cell and link to that header the link in the rendered markdown result: vscode attempts to navigate to a file named note that both auto-complete and find references for the header work correctly for that link.
Change:
code: 'ControlLeft' }, { <del> label: 'Ctrl+', ariaLabel: 'Control+', </del> <ins> label: 'Ctrl', ariaLabel: 'Control', </ins> electronAccelerator: null, <del> userSettingsLabel: 'ctrl+', </del> <ins> userSettingsLabel: 'ctrl', </ins> isWYSIWYG: true, isChord: false, dispatchParts: [null],

Discussion:
Issue Type: <bBug</bWhen using screencast mode, if you press a sequence of keys such as "Ctrl" + "Alt", Visual Studio Code adds an extra + at the end of the sequence. ! VS Code version: Code 1.42.1 (, 2020-02-11T14:45:59.656Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ 30-seconds-of-code1.0.0 better-comments2.0.5 Bookmarks11.0.0 vscode-color0.4.5 bracket-pair-colorizer1.0.61 javascript-ejs-support1.3.1 vscode-npm-script0.3.11 vsc-material-theme32.5.0 vsc-material-theme-icons1.1.4 php-intellisense2.3.14 vscode-mocha-test-adapter2.2.2 vscode-test-explorer2.17.0 python2020.2. remote-wsl0.42.3 vsliveshare1.0.1653 material-icon-theme3.9.3 java0.57.0 vscode-xml0.10.1 code-settings-sync3.4.3 vscode-spotify3.1.0 java-generate-setters-getters5.3.0 code-spell-checker1.7.24 vscodeintellicode1.2.5 vscode-java-debug0.25.0 vscode-java-dependency0.9.0 vscode-java-pack0.8.1 vscode-java-test0.22.1 vscode-maven0.21.0 change-case1.0.0 vscode-wpilib2020.2.2 viml0.0.2 material-theme3.2.3 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Isn't this an expected behavior? As it only happens with keys that can be used in combinations (Alt, Ctrl, Shift, Win ecc;)
Well I felt like that if I just press Ctrl and Alt it should say Ctrl+Alt instead of Ctrl+Alt+ as if some other letter had been pressed
Also, I can work on this issue if necessary
Verification: (Windows only) Enable Press and confirm that is displayed on the screen and not . Press and confirm that is displayed on the screen.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Emitter, Event, AsyncEmitter, IWaitUntil } from 'vs/base/common/event'; </del> <ins> import { Emitter, Event, AsyncEmitter, IWaitUntil, IWaitUntilData } from 'vs/base/common/event'; </ins> import { IRelativePattern, parse } from 'vs/base/common/glob'; import { URI } from 'vs/base/common/uri'; import { ExtHostDocumentsAndEditors } from 'vs/workbench/api/common/extHostDocumentsAndEditors';

Discussion:
continues Timeout and user-cancellation applies when calling -events. However, we don't expose that in the API and silently stop async-event delivery and ignore results. We could let extension know via
For some big repo, it is possible for LS to parse more then hundreds files (which takes long time), right now, this can't be cancelled since we (LS) don't get any cancellation token (hence, no cancellation request). vscode side acts like it is cancelled, but only front end (vscode) is cancelled, all the backends (LSP and LS) that are actually doing the work are not cancelled. so even if vscode code send new requests (since vscode side is cancelled), LSP/LS won't be able to respond (not all LS is designed to process concurrent requests especially requests that have potential to change LS states). so only front end cancellation won't help much overall experiences.
fyi - this is now a thing and ready for LSP adoption
Neat, thanks
I verified that the token is available on the events, but it wasn't clear to me how to cause a user cancellation of the save/rename/delete. Can this only be done if there's slow file system provider?
You can call of the event with a promise that never or slowly resolves. Eventually the UI shows a progress notification which allows to cancel. That cancel will propagate to the extension.
I have now also verified that the token properly reflects the cancel status.
Thanks!