jiebi/CodeConvo huggingface dataset:
Change:
content.push(AccessibilityHelpNLS.editableEditor); } } <del> const screenReaderOptimized = this._accessibilityService.isScreenReaderOptimized(); if (screenReaderOptimized) { const saveAudioCue = this._configurationService.getValue(AudioCue.save.settingsKey); switch (saveAudioCue) { case 'never': content.push(AccessibilityHelpNLS.saveAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.saveAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.saveAudioCueUserGesture); break; } const formatAudioCue = this._configurationService.getValue(AudioCue.format.settingsKey); switch (formatAudioCue) { case 'never': content.push(AccessibilityHelpNLS.formatAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.formatAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.formatAudioCueUserGesture); break; } </del> <ins> const saveAudioCue = this._configurationService.getValue(AudioCue.save.settingsKey); switch (saveAudioCue) { case 'never': content.push(AccessibilityHelpNLS.saveAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.saveAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.saveAudioCueUserGesture); break; } const formatAudioCue = this._configurationService.getValue(AudioCue.format.settingsKey); switch (formatAudioCue) { case 'never': content.push(AccessibilityHelpNLS.formatAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.formatAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.formatAudioCueUserGesture); break; </ins> } const commentCommandInfo = getCommentCommandInfo(this._keybindingService, this._contextKeyService, this._editor);

Discussion:
Testing It doesn't seem to matter what I set the new settings to. They are never mentioned in the editor accessbility help. ! !
By design, you have to enable screen reader mode to see this
Maybe we shld also include it when not in screen reader mode?
Might be worth updating the TPI then, since I assumed it should always be there. The language seems backwards: <img width="478" alt="image" src=""
It also doesn't mention the settings, and my understanding is that if the settings are disabled, then the settings will take effect. I have those still turned on.
The reason I didn't mention those here is they're linked to in the ones I do mention, so a user will discover them.
I will use this issue to track making sure these show up in the help dialog regardless of screen reader optimized mode
Change:
run: () => this._commandService.executeCommand('extension.bisect.stop') }; <ins> const message = this._extensionBisectService.disabledCount === 1 ? localize('bisect.singular', "Extension Bisect is active and has disabled 1 extension. Check if you can still reproduce the problem and proceed by selecting from these options.") : localize('bisect.plural', "Extension Bisect is active and has disabled {0} extensions. Check if you can still reproduce the problem and proceed by selecting from these options.", this._extensionBisectService.disabledCount); </ins> this._notificationService.prompt( Severity.Info, <del> localize('bisect', "Extension Bisect is active and has disabled {0} extensions. Check if you can still reproduce the problem and proceed by selecting from these options.", this._extensionBisectService.disabledCount), </del> <ins> message, </ins> [goodPrompt, badPrompt, stop], { sticky: true } );

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.62.3 OS Version: 11.6 (20G165) Steps to Reproduce: Extension Bisect until 1 extension remains !
Change:
title: localize('workbench.action.terminal.runSelectedText', "Run Selected Text"), icon: Codicon.selection }, <del> group: 'execute', </del> <ins> group: 'navigation', </ins> order: 6, when: ContextKeyExpr.equals('view', TERMINAL_VIEW_ID), isHiddenByDefault: true

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VS Code has always been able to clear Terminal only by binding shortcuts or shortcut menus. When debugging server logs, we will often need to clear the logs, and Chrome DevTools provides a separate button for that as well. I can submit a PR for this. ! !
This is actually already a feature but recently regressed. Clear Terminal is in the overflow menu, and in the next release you'll be able to right click to show it in the panel again: !
Change:
// "foo" on line 339, col 12 // "foo" on line 339, column 12 // "foo" line 339 column 12 <del> // "foo", line 339, character 12          [#171880] // "foo", line 339, characters 12-14      [#171880] // "foo", lines 339-341                   [#171880] // "foo", lines 339-341, characters 12-14 [#178287] </del> <ins> // "foo", line 339, character 12           [#171880] // "foo", line 339, characters 12-789      [#171880] // "foo", lines 339-341                    [#171880] // "foo", lines 339-341, characters 12-789 [#178287] </ins> `['"]?(?:,? |: ?| on )lines? ${r()}(?:-${re()})?(?:,? (?:col(?:umn)?|characters?) ${c()}(?:-${ce()})?)?` + eolSuffix, // foo(339) // foo(339,12)

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --When working on Haskell code, may produce error output in the following format: It would be nice to have terminal link detection support for this format (or, to discard the part and just jump to the start column). Currently, this format seems to trip up the parser: it detects the file, line number, and start column correctly, but then it seems to select backwards to near the start of the file. (Note: ghcid seems to treat the end column index as inclusive, i.e. the cursor is before the last notable character.)
Can reproduce: ! Selects from 1:3 to 115 !
What is detected:
Caused by a bad regex match: !
Change:
return; } <del> const iframes = getElementsByTagName('iframe'); </del> <ins> // Select both iframes and webviews; internally Electron nests an iframe // in its <webview> component, but this isn't queryable. const iframes = [ ...getElementsByTagName('iframe'), ...getElementsByTagName('webview'), ]; </ins> for (const iframe of iframes) { iframe.style.pointerEvents = 'none'; // disable mouse events on iframes as long as we drag the sash }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version: 1.37.0-insider Commit: Date: 2019-07-08T05:33:31.335Z Electron: 4.2.5 Chrome: 69.0.3497.128 10.11.0 V8: 6.9.427.31-electron.0 OS: Darwin x64 17.7.0 OS Version: macOS High Sierra 10.13.6 (17G7024) Steps to Reproduce: the following sample code of extension. the WebView Panel. is not smooth. ! Does this issue occur when all extensions are disabled?: Yes
Change:
const workbenchWebConfiguration = { remoteAuthority, <del> remoteBaseUrl: this._basePath, </del> <ins> serverBasePath: this._basePath, </ins> _wrapWebWorkerExtHostInIframe, developmentOptions: { enableSmokeTestDriver: this._environmentService.args['enable-smoke-test-driver'] ? true : undefined, logLevel: this._logService.getLevel() }, settingsSyncOptions: !this._environmentService.isBuilt && this._environmentService.args['enable-sync'] ? { enabled: true } : undefined,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.88.0-insider (Universal), Commit: , Date: 2024-03-21T17:26:53.619Z (9 hrs ago) OS Version: OS: Darwin arm64 23.2.0 Steps to Reproduce: the code server URL in the browser that the Activity Bar icons are not visible, it looks like the theme is broken. the is launched without server-base-path option at a given port, for example 8884, and then after accessing it from the browser, if the server is started with , then the issue is masked, perhaps because of browser caching.
This seems to be related to the new feature -
Change:
readonly filter?: ITreeFilter<T, TFilterData>; readonly dnd?: ITreeDragAndDrop<T>; readonly additionalScrollHeight?: number; <ins> readonly findWidgetEnabled?: boolean; </ins> } function dfs<T, TFilterData>(node: ITreeNode<T, TFilterData>, fn: (node: ITreeNode<T, TFilterData>) => void): void {

Discussion:
Type: <bBug</bFilter tests for the current doc is no longer working. is doing nothing in the test explorer. It seems that all filter are broken. For example is also not possible. <img width="344" alt="CleanShot 2022-07-25 at 11 14 38 src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-25T05:27:27.755Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/assign
Change:
shellLaunchConfig.args = windowsShellArgs ? combinedShellArgs.join(' ') : combinedShellArgs; if (task.command.presentation && task.command.presentation.echo) { if (needsFolderQualification && workspaceFolder) { <del> shellLaunchConfig.initialText = formatMessageForTerminal(`Executing task in folder ${workspaceFolder.name}: ${commandLine}`, { excludeLeadingNewLine: true }); </del> <ins> shellLaunchConfig.initialText = formatMessageForTerminal(nls.localize({ key: 'task.executingInFolder', comment: ['The workspace folder the task is running in', 'The task command line or label'] }, 'Executing task in folder {0}: {1}', workspaceFolder.name, commandLine), { excludeLeadingNewLine: true }); </ins> } else { <del> shellLaunchConfig.initialText = formatMessageForTerminal(`Executing task: ${commandLine}`, { excludeLeadingNewLine: true }); </del> <ins> shellLaunchConfig.initialText = formatMessageForTerminal(nls.localize({ key: 'task.executing', comment: ['The task command line or label'] }, 'Executing task: {0}', commandLine), { excludeLeadingNewLine: true }); </ins> } } } else {

Discussion:
I noticed some task messages weren't localized: Terminal support for unicode is pretty great now so if we have issues with other languages here we should fix them.
Seems like a good idea. Changing these would only be an issue if we have extensions that are reading terminal output and looking for these strings.
That's a proposed api that will probably never get finalized, I doubt the few that use this would be checking for task messages like that.
Change:
}); const result: HTMLElement = renderMarkdown(md).element; <del> assert.strictEqual(result.innerHTML, `<p><a data-href="command:doFoo" href="" title="command:doFoo">command1</a> <a data-href="command:doFoo" href="">command2</a></p>`); </del> <ins> assert.strictEqual(result.innerHTML, `<p><a data-href="command:doFoo" title="command:doFoo">command1</a> <a data-href="command:doFoo">command2</a></p>`); </ins> }); suite('PlaintextMarkdownRender', () => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: macOS 12.0.1 Steps to Reproduce: a markdown and add a link on the link, drag the link rendered in hover widget to the editor https://user- It seems that markdown renderer removes property and uses instead. I'm glad if I can help but I don't know if it's by design. Can we keep both and on links?
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!
Fix actually seems pretty easy here so reopening
Change:
if (contribution.scopes) { if ((!Array.isArray(contribution.scopes) || contribution.scopes.some(s => typeof s !== 'string'))) { <del> collector.error(nls.localize('invalid.scopes', "If defined, 'configuration.tokenStyleDefaults.scopes' must must be an array or strings")); </del> <ins> collector.error(nls.localize('invalid.scopes', "If defined, 'configuration.tokenStyleDefaults.scopes' must be an array or strings")); </ins> continue; } tokenStyleDefault.scopesToProbe = [contribution.scopes];

Discussion:
VSCode Version: 1.41.0 OS Version: Not applicable Steps to Reproduce: to row 231 that the word 'must' is unexpectedly repeated. Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.555 --- <!-- score: 0.539 --<!-- potentialduplicatescomment --
Change:
this.replInput.setModel(this.model); this.updateInputDecoration(); this.refreshReplElements(true); <ins> if (this.styleChangedWhenInvisible) { this.styleChangedWhenInvisible = false; this.onDidStyleChange(); } </ins> } })); this._register(this.configurationService.onDidChangeConfiguration(e => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 OS Version: win10 Steps to Reproduce: a C/C++ program. "Ctrl +j" to Toggle Panel invisible. Change the debug console font size, then toggle panel visible. It can be seen the debug console content is cleared is a video demonstration
Weird bug. I can repro it
Still repros
I see that this works sometimes, but sometimes it still clears the debug console content.
I would like to work on this. Can you please assign this to me?
Feel free to send a PR if you'd like
Tried to reproduce this on the latest stable release and it seems like this is already fixed.
The original steps:
I submitted a to fix this problem. But I'm not sure if it is an ideal approach. Any feedback would be helpful .
Change:
const followupsHeight = this.followupsContainer.offsetHeight; const inputPartBorder = 1; <del> const inputPartHorizontalPadding = this.options.renderStyle === 'compact' ? 0 : 40; </del> <ins> const inputPartHorizontalPadding = this.options.renderStyle === 'compact' ? 8 : 40; </ins> const inputPartVerticalPadding = this.options.renderStyle === 'compact' ? 12 : 24; const inputEditorHeight = Math.min(this._inputEditor.getContentHeight(), height - followupsHeight - inputPartHorizontalPadding - inputPartBorder, INPUT_EDITOR_MAX_HEIGHT); const implicitContextHeight = this.implicitContextContainer.offsetHeight;

Discussion:
todays insiders open quick chat the RHS toolbar hangs off the view <img width="171" alt="Screenshot 2024-03-22 at 14 05 50" src=""
Change:
if (!this.tree.expandOnDoubleClick && e.browserEvent.detail === 2) { return super.onViewPointer(e); } <ins> } else { this.handleStickyScrollMouseEvent(e, node); </ins> } if (node.collapsible && (!isStickyElement || onTwistie)) {

Discussion:
Testing Repro: a node in a tree that is fairly deep. a parent node. that there's a slight flicker. Consecutive collapse/expands don't have that, only the first. ]()
Change:
spdlog/*.yml !spdlog/build/Release/*.node <del> jschardet/dist/** </del> windows-foreground-love/binding.gyp windows-foreground-love/build/** windows-foreground-love/src/**

Discussion:
We use for encoding detection. This library itself ships a minified distribution: We seem to tell our loader to use that distribution: However, we also tell our build machine to exclude the folder: do you have an idea why we still successfully load , do we fallback to loading it normally through if the file is missing? I think you did implement some logic to automatically generate loader configuration based on the modules we ship in web, is that true? Are we configuring the web to load from folder? I actually wonder how this works in web, where we also seem to exclude the folder //cc
Oh I was wrong: in web we explicitly include and that seems to work just fine. Trying now to do the same for desktop:
Missing dependency: jschardet
63 svn Missing dependency: jschardet svn
Change:
private formatPath(uri: URI): string { if (uri.scheme === Schemas.file) { <ins> if (hasDriveLetter(uri.fsPath, isWindows)) { return uri.fsPath.charAt(0).toUpperCase() + uri.fsPath.substring(1); } </ins> return uri.fsPath; }

Discussion:
Drive letter on Windows are uppsercase: <img width="393" alt="image" src="https://user-"
we are not using the label service for the path portion because the path needs to be editable by the user. i.e. They should be able to edit the string directly and we should be able save that into our list. In the local case, the default behavior is to use the file picker, but if you are editing a remote path that you are not connected to, you need to be able to edit the string. I consider this change but I'm a little nervous that we might get some UI representation that is not safe for editing. <img width="720" alt="image" src="https://user-"
Fair, we have methods to only fix the drive letter casing, so maybe safer to just do that.
I believe I solved this a part of a separate issue.
Assigning to Jan for verification
I still see lowercase drive letters: <img width="613" alt="image" src="https://user-"
Change:
const userDataProfileImportExportService = accessor.get(IUserDataProfileImportExportService); const dialogService = accessor.get(IDialogService); const contextKeyService = accessor.get(IContextKeyService); <ins> const notificationService = accessor.get(INotificationService); </ins> const isSettingProfilesEnabled = contextKeyService.contextMatchesRules(PROFILES_ENABLEMENT_CONTEXT);

Discussion:
Testing When importing a profile from a file and giving a name of an existing profile, nothing happens. I would suggest to see an error when typing the name of an existing profile.
Change:
return document.uri; } return undefined; <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Scenario: Markdown file is open in left editor group. This file has a lot of links to other .md files that I want to preview in the right editor group. But Markdown links can currently only be opened into the same editor. Please consider. Thanks!
Adding per our discussion about this one
Do you mean that you would like an option to make the command to open the preview to the left instead of to the right of the current editor?
No, sorry, I should have been more specific. Here's what I mean: -click to open a .md file in a persistent editor in Code, preferably a file with many links to other local .md files. the file, Ctrl+click a link to another .md file. other file opens in a new editor, in the same editor group. Desired: open the link as a raw .md file in a new or existing (separate) editor group. Then, when I go back to the original file and ctrl+click another .md link, open that raw .md into the same editor group the previous one opened into. So I can quickly ctrl+click through a bunch of links and see the raw .md while my original file (the one with all the links) stays in view.
Ok, thanks for explaining the expected behavior in more detail. Marking as help wanted if anyone wants to investigate this. To get started, look at: This is where we map markdown links to command links This is where we convert the command into an editor action. Instead of opening in the current editor, we would want to open in a new editor group here
For verification: new setting was called are two options: (the default) and links in md text files (not the preview) should respect this option default behavior should be to open links in the current group
Can't verify because of
I can verify this on Mac.
Thanks for adding this!
Change:
*--------------------------------------------------------------------------------------------*/ import { toErrorMessage } from 'vs/base/common/errorMessage'; <del> import { getErrorMessage } from 'vs/base/common/errors'; </del> <ins> import { ErrorNoTelemetry, getErrorMessage } from 'vs/base/common/errors'; </ins> import { mark } from 'vs/base/common/performance'; class MissingStoresError extends Error {

Discussion:
https://vscode- Deminified Stack Error: Failed to execute 'transaction' on 'IDBDatabase': The database connection is closing.
This could be upstream and suggests it could be from running out of disk space. Should we maybe not log these indexed DB errors to telemetry ?
if we expect the failure we should either catch the error and handle or catch and rethrow as
Change:
registerEditorContribution(CallHierarchyController.Id, CallHierarchyController, EditorContributionInstantiation.Eager); // eager because it needs to define a context key <del> registerAction2(class extends EditorAction2 { </del> <ins> registerAction2(class PeekCallHierarchyAction extends EditorAction2 { </ins> constructor() { super({

Discussion:
Testing <img width="497" alt="image" src=""<img width="667" alt="image" src=""
same is true for "Peek Type Hierarchy"
Hi Rob and Johannes, Would you mind if I took a crack at this issue? I am just starting open source, and I think this would be a great learning experience to do!
I stand in line
Hey have you started working on this issue?
Yes I have! I have already wrote code for this issue, just haven't made a pr yet :)
Hey can you take a little time and help me if you have resolved this issue how you did it? just a brief, also where is your pr I want to take a look at it!
It's been quite a while that no updates about the fix is coming out, so I've committed mine in .
To verify: open a TS file, wait the language service to be ready select F1 and type Peek Call Hierarchy