jiebi/CodeConvo huggingface dataset:
Change:
export interface LanguageMode { getId(): string; <ins> doSelection?: (document: TextDocument, position: Position) => Range[]; </ins> doValidation?: (document: TextDocument, settings?: Settings) => Diagnostic[]; doComplete?: (document: TextDocument, position: Position, settings?: Settings) => CompletionList; doResolve?: (document: TextDocument, item: CompletionItem) => CompletionItem;

Discussion:
Semantic selections: LSP: works CSS/SCSS/LESS: doesn't work, but it works in Atom. Probably need to update our dependencies. The plan now is to use emmet's "balance" commands. The challenge is that HTML/CSS language service need to include emmet. Alternatively, we can implement these commands ourselves.
Please review the animated gifs in the original thread: Seems to me the emmet functionality as it stands is wholly inadequate.
This will be available in tomorrow's insiders: !
is this suppose to work in Javascript? It's not nearly as functional as Webstorm. Also fails dramatically with HTML in .Vue files. Oh well.
Vue — it'll be available once we update the dependencies. JavaScript — we'll need to wait for TypeScript to add the semantic selection. I don't have any estimate.
Change:
return InteractiveEditorInput.ID; } <del> private _initTitle?: string; </del> <ins> private name: string; </ins> get language() { return this._inputModelRef?.object.textEditorModel.getLanguageId() ?? this._initLanguage;

Discussion:
VS Code Version: 1.80.1 OS Version: Win-10 Python extension: v2023.12.0 Steps to Reproduce: an empty file with cell =you will see the interactive window with tab name , ... Please confirm if this is work as designed. I remember it wasn't the case at the beginning of the year. This type of naming causes tremendous confusing when working on more than 2 interactive windows within a Workplace. Please let me know if I should report it to Thanks!
Probably the same error after last update. VS Code Version: 1.80.1 OS Version: Ubuntu 22.04 "jupyter.interactiveWindow.creationMode": "perFile" name of source python file is lost, only tab names 'interactive-1', 'interactive-2'
not intentional, it should still include the python filename in the interactive tab. investigating
Change:
const that = this; const originalWindowFocus = mainWindow.focus.bind(mainWindow); mainWindow.focus = function () { <ins> if (that.environmentService.extensionTestsLocationURI) { return; // no focus when we are running tests from CLI } </ins> originalWindowFocus(); if (!mainWindow.document.hasFocus()) {

Discussion:
Since the november 2023 update steals window focus. This is really problematic because uses this to run end to end tests and now the development host window pops up for every single test case, which renders all other windows unusable while I’m running tests, as the test window steals focus many times per second. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 (user setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: extension host vscode main window the following code: vscode extension development host window is now focused.
We should add rules to not change focus during extension development tests.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I can reproduce this: an extension that activates : 5, and immediately focus back to the VS Code window you F5'd from When executes, the ext dev host window will regain focus
Sorry, bad description: its only disabled when running extension tests.
Change:
const key = extractKey(e); if (key === TOGGLE_DEV_TOOLS_KB || key === TOGGLE_DEV_TOOLS_KB_ALT) { ipc.send('vscode:toggleDevTools'); <del> } else if (key === RELOAD_KB) { </del> <ins> } else if (key === RELOAD_KB && !disallowReloadKeybinding) { </ins> ipc.send('vscode:reloadWindow'); } };

Discussion:
Issue Type: <bBug</bHitting Ctrl+R refresh Issue Report window content and the filled information are lost after refreshing. VS Code version: Code 1.35.1 (, 2019-06-12T14:27:31.086Z) OS version: Linux x64 4.15.0-54-generic <details<summaryExtensions (15)</summaryExtensionVersion ------ githistory0.4.6 es7-react-js-snippets2.3.0 json-tools1.0.2 prettier-vscode1.9.0 composer-support-client0.19.12 golang-tdd0.0.9 solidity0.0.56 vscode-docker0.7.0 python2019.6. cpptools0.24.0 Go0.11.4 sqltools0.19.6 material-icon-theme3.8.0 sass-indented1.5.1 gitblame2.8.1 </details<!-- generated by issue reporter --
Change:
"button.secondaryHoverBackground": "#ffffff15", "checkbox.background": "#313131", "checkbox.border": "#ffffff15", <ins> "debugToolBar.background": "#181818", </ins> "descriptionForeground": "#8b949e", "diffEditor.insertedLineBackground": "#23863633", "diffEditor.insertedTextBackground": "#2386364d",

Discussion:
Not sure if this was intentional or not but the debug toolbar grey seems to be lighter than everything: !
Looks like I had just missed overriding the defaults. Will be fixed via
Change:
import { IQuickInputService } from 'vs/platform/quickinput/common/quickInput'; import * as colors from 'vs/platform/theme/common/colorRegistry'; import { WindowTitle } from 'vs/workbench/browser/parts/titlebar/windowTitle'; <del> import { MENUBAR_SELECTION_BACKGROUND, MENUBAR_SELECTION_FOREGROUND, TITLE_BAR_ACTIVE_FOREGROUND } from 'vs/workbench/common/theme'; </del> <ins> import { MENUBAR_SELECTION_BACKGROUND, MENUBAR_SELECTION_FOREGROUND, PANEL_BORDER, TITLE_BAR_ACTIVE_FOREGROUND } from 'vs/workbench/common/theme'; </ins> import { IHoverService } from 'vs/workbench/services/hover/browser/hover'; export class CommandCenterControl {

Discussion:
Testing I believe the border contrast needs to be 3:1 between the border and bg color of the title bar. Something like might be a little closer to what we want: <img width="489" alt="CleanShot 2022-05-31 at 13 02 15 src="https://user-"<img width="520" alt="CleanShot 2022-05-31 at 13 01 04 src="https://user-"
Your suggested colors falls back to which actually aren't defined for for light/dark themes, only for HC themes... I went with variants of the foreground-color. The contrast-ratio tool in devtools seems broken... Do you mind making more directly in this branch:
Change:
UnknownPath = 'UnknownPath', EmptyCommitMessage = 'EmptyCommitMessage', BranchFastForwardRejected = 'BranchFastForwardRejected', <ins> BranchNotYetBorn = 'BranchNotYetBorn', </ins> TagConflict = 'TagConflict' }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Steps to Reproduce: a existing folder in vscode sure the folder has files "init repository" buttun in vscode a change (delete a file) in vscode source control the error: ! I would suggest popping up a dialog asking the user if he/she wants to create a branch first.
Change:
public readonly options: IAccessibleViewOptions = { type: AccessibleViewType.View }; constructor( <ins> private readonly _keybindingService: IKeybindingService, </ins> private readonly _editor: ICodeEditor, hoverController: HoverController, ) {

Discussion:
Testing the keybinding for verbosity hover over =Shows the keybinding accessibility view of the hover focus to the by clicking A hover for the action shows without the keybinding !
Change:
assert!(rx.try_recv().is_err()); <del> let mut append_file = OpenOptions::new() .write(true) .append(true) .open(&file_path) .unwrap(); </del> <ins> let mut append_file = OpenOptions::new().append(true).open(&file_path).unwrap(); </ins> writeln!(append_file, " is now complete").unwrap(); let recv = rx.recv().await;

Discussion:
This used to work on the same machine however. Not sure when it stopped. Or why.
Please run
that worked! Wonder if the CLI should do it automatically?
BTW I also noticed how it returns exit code 0 (success) even when it failed like that. Perhaps you should avoid just issuing a warning in case some of these operations fails.
Thanks a ton,
Change:
interface ActionButtonState { readonly HEAD: Branch | undefined; <ins> readonly isCheckoutInProgress: boolean; </ins> readonly isCommitInProgress: boolean; readonly isMergeInProgress: boolean; readonly isRebaseInProgress: boolean;

Discussion:
Type: <bBug</bto an existing branch from . Control Side panel then shows Sync Changes button. , clicking on Sync button causes to commits from previous branch to merge into current branch VS Code version: Code 1.74.3 (, 2023-01-09T16:59:02.252Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ laravel-blade1.1.2 jupyter-keymap1.0.0 remote-wsl0.72.0 alignment0.3.0 vscode-log-viewer0.12.2 vscode-intelephense-client1.9.4 gitlens13.2.0 cmake-tools1.13.44 cpptools1.13.9 cpptools-extension-pack1.3.0 laravel-blade1.32.0 cmake0.0.17 php-debug1.30.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
/** * Editor widgets */ <del> export const editorWidgetBackground = registerColor('editorWidget.background', { dark: '#2D2D30', light: '#EFEFF2', hc: '#0C141F' }, nls.localize('editorWidgetBackground', 'Background color of editor widgets, such as find/replace.')); </del> <ins> export const editorWidgetBackground = registerColor('editorWidget.background', { dark: '#252526', light: '#F3F3F3', hc: '#0C141F' }, nls.localize('editorWidgetBackground', 'Background color of editor widgets, such as find/replace.')); </ins> export const editorWidgetBorder = registerColor('editorWidget.border', { dark: '#454545', light: '#C8C8C8', hc: contrastBorder }, nls.localize('editorWidgetBorder', 'Border color of editor widgets. The color is only used if the widget chooses to have a border and if the color is not overridden by a widget.')); export const editorWidgetResizeBorder = registerColor('editorWidget.resizeBorder', { light: null, dark: null, hc: null }, nls.localize('editorWidgetResizeBorder', "Border color of the resize bar of editor widgets. The color is only used if the widget chooses to have a resize border and if the color is not overridden by a widget."));

Discussion:
Has the selection color in the suggestion widget changed? I noticed that I several time picked the wrong suggestion since the currently selected item was difficult to see. Also notice currently selected item is shown in a different color than the currently selected item in a menu. The suggestion widget: ! The menu selection ! Notice that the menu selection is much more clear.
The color was updated to meet the color contrast ratio for when text is highlighted in the list: ! It also appears that the menu selection is using , which is typically used when needing to show both active selection and focus in a list: ! We could look at updating the color so that it's darker and allows more contrast between the selection (would also match the quick pick bg color): !
Change:
/** * Editor widgets */ <del> export const editorWidgetBackground = registerColor('editorWidget.background', { dark: '#2D2D30', light: '#EFEFF2', hc: '#0C141F' }, nls.localize('editorWidgetBackground', 'Background color of editor widgets, such as find/replace.')); </del> <ins> export const editorWidgetBackground = registerColor('editorWidget.background', { dark: '#252526', light: '#F3F3F3', hc: '#0C141F' }, nls.localize('editorWidgetBackground', 'Background color of editor widgets, such as find/replace.')); </ins> export const editorWidgetBorder = registerColor('editorWidget.border', { dark: '#454545', light: '#C8C8C8', hc: contrastBorder }, nls.localize('editorWidgetBorder', 'Border color of editor widgets. The color is only used if the widget chooses to have a border and if the color is not overridden by a widget.')); export const editorWidgetResizeBorder = registerColor('editorWidget.resizeBorder', { light: null, dark: null, hc: null }, nls.localize('editorWidgetResizeBorder', "Border color of the resize bar of editor widgets. The color is only used if the widget chooses to have a resize border and if the color is not overridden by a widget."));

Discussion:
This appears in the list, outline, breadcrumb, quick pick, and suggest widget. We could update this color to use which is what uses. !
Other places that this needs to work in: !
Change:
if (translated === undefined && originalMessages) { translated = originalMessages[messageKey]; } <del> let message: string | undefined = typeof translated === 'string' ? translated : (typeof translated?.message === 'string' ? translated.message : undefined); </del> <ins> let message: string | undefined = typeof translated === 'string' ? translated : translated.message; </ins> if (message !== undefined) { if (pseudo) { // FF3B and FF3D is the Unicode zenkaku representation for [ and ] message = 'uFF3B' + message.replace(/[aouei]/g, '$&$&') + 'uFF3D'; } <del> obj[key] = command && (key === 'title' || key === 'category') && originalMessages ? { value: message, original: originalMessages[messageKey] } : message; </del> <ins> // This branch returns ILocalizedString's instead of Strings so that the Command Palette can contain both the localized and the original value. if (command && originalMessages && (key === 'title' || key === 'category')) { const originalMessage = originalMessages[messageKey]; const localizedString: ILocalizedString = { value: message, original: typeof originalMessage === 'string' ? originalMessage : originalMessage?.message }; obj[key] = localizedString; } else { obj[key] = message; } </ins> } else { this.logService.warn(this.formatMessage(extensionLocation, localize('missingNLSKey', "Couldn't find message for key {0}.", messageKey))); }

Discussion:
Issue Type: <bBug</bChinesenotebookrestart Extension version: 2022.6. VS Code version: Code 1.69.0 (, 2022-07-07T05:28:36.503Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Are these ok ! ! !
thanks for filling this issue please could you upload a screenshot of the issue.
I have a same issue with him. I guess it relates to CJK language pack since restart and interrupt buttons also disappear in Korean. ! !
I also have the same issue. Since updating vscode and jupyter extension to the latest version, when I use the Chinese language pack, the restart and interrupt buttons on the global toolbar will disappear. When I uninstall the Chinese language pack, or downgrade vscode and jupyter extension, these problems will go away. Please check this problem, thanks! <img width="831" alt="image" src="https://user-"
I met this problem since last auto update of vscode. Suffering for days, haven't realized that its a bug for language package.
I'm sorry you are running into this, we'll try to get this resolve asap.
Hello ! We just released a hotfix that re-enables those buttons that you reported missing. Please install and let us know how it goes! Thank you for using our extension. Your time and feedback are appreciated.
It is worked. Thanks:smile: !
It works in Korean, too. Thanks! !
This is actually an issue in vscode core. It looks like an issue with this code: The messages is of type: string: string | { message: string; comment: string[] } when it should really only be string: string. I’ll fix this
calm down bot
Change:
} .settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message { <del> display: block; </del> <ins> display: flex; } .settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message .codicon { margin-right: 4px; </ins> } .settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-description {

Discussion:
<img width="769" alt="CleanShot 2021-10-13 at 14 40 36 src="https://user-"When we show a deprecated message we should use an icon since we shouldn't use color alone to assign meaning for accessibility.
Any suggestions for an icon?
<img src="https://user-"Verification steps: a deprecated setting in the like the settings UI and search for the setting that the deprecated message has an icon and passes color contrast ratio of 3:1 for the icon and 4.5:1 for the text
Change:
if (executeResult) { return this._handleExecuteResult(executeResult); } else { <del> this._doRunTaskCommand(); </del> return Promise.resolve(undefined); } });

Discussion:
Testing any task in VS Code repo, e.g. npm: eslint Rerun Last Task from command palette :bug: get prompted to choose a task to run, I would expect that last task to be automatically selected
this was working in v1.77 - broken in v1.80 so a regression but not this iteration
interesting - this doesn't happen for certain tasks - like
does repro for
Ok so for background / watch tasks that are currently running, like , the command to use instead is . For tasks with start/stop executions, if a user invokes while that task is in progress, it currently shows a quickpick. We should instead do nothing. That command is meant to be used for tasks that have ceased execution.
fyi, I did repro this for specifically
Yes I could ultimately repro when that task was in progress
Change:
return result; } <ins> private getOutgoingHistoryItemGroupMenu(menuId: MenuId, historyItemGroup: SCMHistoryItemGroupTreeElement): IMenu { const contextKeyService = this.contextKeyService.createOverlay([ ['scmHistoryItemGroupHasUpstream', !!historyItemGroup.repository.provider.historyProvider?.currentHistoryItemGroup?.base], ]); return this.menuService.createMenu(menuId, contextKeyService); } </ins> dispose(): void { this.disposables.dispose(); }

Discussion:
Testing I expected the action to appear on an unpublished branch, not the action. I am aware they both do the same. <img width="647" alt="Screenshot 2024-01-24 at 11 37 40" src=""
Change:
allowBreakpointsEverywhere: boolean; openDebug: 'neverOpen' | 'openOnSessionStart' | 'openOnFirstSessionStart' | 'openOnDebugBreak'; openExplorerOnEnd: boolean; <del> inlineValues: boolean | 'auto'; </del> <ins> inlineValues: boolean | 'auto' | 'on' | 'off'; // boolean for back-compat </ins> toolBarLocation: 'floating' | 'docked' | 'hidden'; showInStatusBar: 'never' | 'always' | 'onFirstSessionStart'; internalConsoleOptions: 'neverOpen' | 'openOnSessionStart' | 'openOnFirstSessionStart';

Discussion:
Today the "Debug: Inline Values" setting uses low-level "true" and "false" values (in addition to the more high-level "auto"): <img width="352" alt="CleanShot 2022-02-21 at 14 31 00 src="https://user-"I suggest to support (and surface in the UI) "on" and "off" values and only keep the booleans for backward compatibility.
Hi! Can I work on this issue?
I think this is a "good first issue", do you agree?
Yes, I would take a PR for this. Make sure that it's backwards compatible so that if a user has true or false set, those still work as they did before.
Change:
disableMonospaceOptimizations: register(new EditorBooleanOption( EditorOption.disableMonospaceOptimizations, 'disableMonospaceOptimizations', false )), <ins> domReadOnly: register(new EditorBooleanOption( EditorOption.domReadOnly, 'domReadOnly', false, )), </ins> dragAndDrop: register(new EditorBooleanOption( EditorOption.dragAndDrop, 'dragAndDrop', true, { description: nls.localize('dragAndDrop', "Controls whether the editor should allow moving selections via drag and drop.") }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: Steps to Reproduce: a browser version vscode a editor with readonly mode extension who use the API would be invalid This issue won't be occured on desktop version. Follow code show more details: the attribute is used to disable keyboard popping in mobile devices, but it break the event too. Change the to may be better <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Can you please give an example of how behaves differently? I am not 100% convinced that there is a bug here. I would expect that is never called, not in desktop and also not in web.
There is a way that are relatively easy to reproduce this bug, when someone use GitHub CodeSpaces (because the bug only occured in browser version): the extension and the Extension. (the extension require the API for basic cursor motion, and the GitLens extension will provide can readonly mode editor) any file which has at least two commit, click in the editor menu title. ! we will get a readonly editor, but extension can not move cursor by pressing key here. The readonly attribute was in this commit: As the message describe, it used to disable keyboard popping up on mobile devices, and there is no condition at the earliest time. and then add the condition at this commit by you , I guess that's the readonly attribute cause some bug at desktop version at that time? Another thing, I think when we need consider the mobile devices, I think change the to may be better, but there is not a option named in , so I just change it to at .
To verify, install vim in the browser and use it in a readonly editor (e.g. left side of a diff editor).