jiebi/CodeConvo huggingface dataset:
Change:
private _createLocalExtensionHostDataProvider(isInitialStart: boolean, desiredRunningLocation: ExtensionRunningLocation): ILocalProcessExtensionHostDataProvider & IWebWorkerExtensionHostDataProvider { return { <del> getInitData: async () => { </del> <ins> getInitData: async (): Promise<ILocalProcessExtensionHostInitData & IWebWorkerExtensionHostInitData> => { </ins> if (isInitialStart) { // Here we load even extensions that would be disabled by workspace trust const localExtensions = this._checkEnabledAndProposedAPI(await this._scanAllLocalExtensions(), /* ignore workspace trust */true);

Discussion:
When running a web worker extension on vscode desktop, the error appears. To reproduce, you can use the following extension: : :
Change:
"npm-debug.log": "_npm_ignored_light" } }, <del> "version": "https://github.com/jesseweed/seti-ui/commit/8f22764c37feb7f706465f5186132111a2401b6b" </del> <ins> "version": "https://github.com/jesseweed/seti-ui/commit/f3b2775662b0075aab56e5f0c03269f21f3f0f30" </ins> }  No newline at end of file

Discussion:
accepted a couple of update PRs recently. Can you please sync extensions/theme-seti/icons? Meanwhile, I noticed that file was falsely classified as type file. I am not sure if that's a real issue in the latest vscode release candidate, or just a non-reproducible problem caused by some peculiarity in my vscode dev env. Can you please take a look?
Also something worth mentioning is that WebP images lack the image icon whereas WebM videos does indeed have the video icon. Adding lines: and does indeed solves the issue.
can you please file a separate issue? Thanks.
NP sir .
thanks! While testing your PR, can you also please check the icon for file? There shouldn't be no icon assigned to it. Otherwise, that's a regression and I am happy to file an issue.
we don't have any references to files in our seti-ui directory and nearly all of our code is pulled directly from the seti repo, so i'm unsure where this is coming from. Please file a separate issue and can look into it. EDIT: after looking into this, it appears that files are : ! And we have refs for mod files in our built-in xml extension: So there is a clash there. I'd suggest you make a request on the seti-ui theme to set files to a go icon so there are no conflicts.
Verification steps: ensure that the following updates are reflected in the file explorer for file icons: use the new logo files point to the R icon files point to the TypeScript icon !
Change:
} async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> const idx = context.notebookEditor.getCellIndex(context.cell); const languageService = accessor.get(ILanguageService); const newFocusMode = context.cell.focusMode === CellFocusMode.Editor ? 'editor' : 'container';

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem
Change:
RevertFiles = 'RevertFiles', RevertFilesNoProgress = 'RevertFilesNoProgress', RevList = 'RevList', <ins> RevParse = 'RevParse', </ins> SetBranchUpstream = 'SetBranchUpstream', Show = 'Show', Stage = 'Stage',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !
Change:
private _linkProviderRegistration?: IDisposable; private _handlePool: number = 0; <del> constructor(mainContext: IMainContext, private _extHostLanguageFeatures: ExtHostLanguageFeatures) { </del> <ins> constructor(mainContext: IMainContext, private _extHostLanguageFeatures: ExtHostLanguageFeatures, private readonly _fileSystemConsumer: IExtHostConsumerFileSystem) { </ins> this._proxy = mainContext.getProxy(MainContext.MainThreadFileSystem); // register used schemes

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
if (snippet.needsClipboard) { clipboardText = await clipboardService.readText(); } <ins> editor.focus(); </ins> SnippetController2.get(editor)?.insert(snippet.codeSnippet, { clipboardText }); snippetService.updateUsageTimestamp(snippet); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.71.2 (user setup) Commit: Date: 2022-09-14T21:03:37.738Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: WindowsNT x64 10.0. Sandboxed: No OS Version: Windows 10 Steps to Reproduce: Use a snippet that has repeat placeholder variables, e.g. command palette, select "Insert snippet" the list of available snippets, select using the mouse to left click on it typing to fill in the highlighted/selected placeholder variable text editor does not have focus. (If you manually select the text editor for focus, it is very easy to lose the multiple cursor focus which is essential for efficiently 'filling in' the snippet) This is an accessibility issue, which arose while using eye control for coding, but the issue persists when just using conventional mouse control. This video shows the correct behaviour, with focus immediately moved to the text file with correct cursor selection when keyboard control is used to select a snippet. Note that NumPad2 is being used as a shortcut for 'tabbing' to the next placeholder, to avoid other conflicts: This video shows the bug, with focus lost when mouse control is used to select a snippet.
I will push a change to explicitly set focus back to the editor after having interacted with quick pick.

However, this looks like an issue with quick pick itself, that fact that clicking vs key-down is different seems y and other might be affected by this as well
Thanks for the quick investigation. We are getting on really well with eye control otherwise, and getting snippets working flawlessly is going to be a big win!
since you are out, I'll move this to next iteration.
fixed the actual bug... and the focus stuff is covered by
Cough, cough. IMO is the actual bug and affected folks are implementing workarounds
Agreed
Change:
@IEnvironmentService environmentService: IEnvironmentService, @ILogService logService: ILogService, @ITimerService timerService: ITimerService, <ins> @IConfigurationService configService: IConfigurationService </ins> ) { const devOpts = parseExtensionDevOptions(environmentService);

Discussion:
Since long we automatically profile the extension host when it becomes unresponsive. In that cases we send a signal via telemetry and in bad cases we ask users to file issues. During that we ask them to attach the corresponding profile but we have mixed results with that. So, in addition to the existing flow we want to log a richer telemetry event that uploads the heaviest sample trace from the profiling
Change:
return function () { var desktop = gulp.src('resources/linux/code.desktop', { base: '.' }) .pipe(replace('@@NAME_LONG@@', product.nameLong)) <ins> .pipe(replace('@@NAME_SHORT@@', product.nameShort)) </ins> .pipe(replace('@@NAME@@', product.applicationName)) .pipe(rename('usr/share/applications/' + product.applicationName + '.desktop'));

Discussion:
Testing Open the integrated terminal Change the setting Observe: setting is not applied until a restart of VSCode

I've seen this a few times: ! It seems to disappear after a while, maybe it's to do with .local desktop entry or bin command running instead of real command?

Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?
Thinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.
Marked as candidate as it's a very simple change that's been reported a bunch of times.
Cherry picked to release/1.2
Change:
} } <del> private _getOutlineItemCompareType(): OutlineSortOrder { switch (this._symbolSortOrder.getValue()) { </del> <ins> private _getOutlineItemCompareType(overrideConfiguration?: IConfigurationOverrides): OutlineSortOrder { switch (this._symbolSortOrder.getValue(overrideConfiguration)) { </ins> case 'name': return OutlineSortOrder.ByName; case 'type':

Discussion:
The setting "breadcrumbs.symbolSortOrder" cannot be enabled for a specific language, i.e. "[markdown]": { "breadcrumbs.symbolSortOrder": "position" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Actually not a duplicate but should be straight forward to implement as filter-options can already be defined per language
Could you point me towards how to get the current resource from the editor model inside ?
The  has a reference to the text model
to verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position
Change:
return undefined; } } <ins> export class WorkspaceBasedVariableResolver implements VariableResolver { constructor( private readonly _workspaceService: IWorkspaceContextService, ) { // } resolve(variable: Variable): string | undefined { if (variable.name !== 'WORKSPACE_NAME' || !this._workspaceService) { return undefined; } const workspaceIdentifier = toWorkspaceIdentifier(this._workspaceService.getWorkspace()); if (!workspaceIdentifier) { return undefined; } if (isSingleFolderWorkspaceIdentifier(workspaceIdentifier)) { return basename(workspaceIdentifier.path); } const filename = basename(workspaceIdentifier.configPath.path); return filename.substr(0, filename.length - WORKSPACE_EXTENSION.length - 1); } } </ins>  No newline at end of file

Discussion:
It would be really helpful if a variable with the repository name (workspace name or opened folder) that was available to use in the snippets. In my case, i use the snippets to create copyright messages, and i am using the project name (the same of the repository) as part of this message.
Hey I'd like to work on this. Can I give it a shot? I appreciate if you have any quick guidance.
Snippet variables are implemented and instantiated . add a variable resolver that uses the (like the and ) add a test here
Thanks :)
Change:
this.element = DOM.append(this.container, DOM.$('')); this.element.className = this.class; this.createInput(this.element); <ins> this.createBadge(this.element); </ins> this.updateClass(); }

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
this.canDrop = false; this.teardownDragAndDropScrollTopAnimation(); this.clearDragOverFeedback(); <ins> this.domNode.classList.remove('dragging'); </ins> this.currentDragData = undefined; StaticDND.CurrentDragAndDropData = undefined;

Discussion:
See the grey row that moves up when it scrolls !
I looked into this a bit, but is this something that is within the tree code? Nothing sticks out to be surrounding us registering the drag and drop handlers when it comes to a focus, or hover rendering
The grey row is the CSS state which stays enabled throughout a native DnD, but stuck in the same position the event fired. It's arguably a browser bug. But we can eat it as a list bug. I see no other way than to disable the hover decoration while the list is being dragged from. Having both and labels is a bit confusing. Those are mutually exclusive.
Oh I always used polish to indicate something that is a small change (at least to the user) and then it's a bug because it shouldn't happen . Idk, I guess I'll stick with just bug
Change:
} } <ins> class SCMTreeDragAndDrop implements ITreeDragAndDrop<TreeElement> { constructor(private readonly instantiationService: IInstantiationService) { } getDragURI(element: TreeElement): string | null { if (isSCMResource(element)) { return element.sourceUri.toString(); } return null; } onDragStart(data: IDragAndDropData, originalEvent: DragEvent): void { const items = SCMTreeDragAndDrop.getResourcesFromDragAndDropData(data as ElementsDragAndDropData<TreeElement, TreeElement[]>); if (originalEvent.dataTransfer && items?.length) { this.instantiationService.invokeFunction(accessor => fillEditorsDragData(accessor, items, originalEvent)); const fileResources = items.filter(s => s.scheme === Schemas.file).map(r => r.fsPath); if (fileResources.length) { originalEvent.dataTransfer.setData(CodeDataTransfers.FILES, JSON.stringify(fileResources)); } } } getDragLabel(elements: TreeElement[], originalEvent: DragEvent): string | undefined { if (elements.length === 1) { const element = elements[0]; if (isSCMResource(element)) { return basename(element.sourceUri); } } return String(elements.length); } onDragOver(data: IDragAndDropData, targetElement: TreeElement | undefined, targetIndex: number | undefined, originalEvent: DragEvent): boolean | ITreeDragOverReaction { return true; } drop(data: IDragAndDropData, targetElement: TreeElement | undefined, targetIndex: number | undefined, originalEvent: DragEvent): void { } private static getResourcesFromDragAndDropData(data: ElementsDragAndDropData<TreeElement, TreeElement[]>): URI[] { const uris: URI[] = []; for (const element of [...data.context ?? [], ...data.elements]) { if (isSCMResource(element)) { uris.push(element.sourceUri); } } return uris; } } </ins> interface InputTemplate { readonly inputWidget: SCMInputWidget; readonly elementDisposables: DisposableStore;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I frequently use the drag-and-drop feature from the Explorer view to open files into specific panes. It would be really nice if this functionality was supported in the Source Control panel as well. I imagine it working like: Drag from filename into pane opens diff in that pane Drag from file icon into pane opens original file in that pane with reversed behavior if .
Not sure if this belongs here, or would be better a new feature request: If I have already two panels open next to each other, opening the git diff in one panel is pretty small and no fun to read, e.g.: ! For me it would be nice, if the first two panels would be used for the diff In IntelliJ the diffs opens in a detached popup, which I can move around and resize individually. I also like this feature a lot
please open a new issue -- although note, that the behavior you describe is unlikely to change, as that is how tab management works in VS Code.
One additional use case: I just enabled drag and drop into the SCM input box. It would be nice if we could drag and drop files from the SCM panel into the box to insert this file path (this already works with files from the explorer)
Change:
} } } else if (data.mouseDownCount === 2) { <del> if (this._hasMulticursorModifier(data)) { this._lastCursorWordSelect(data.position); } else { if (data.inSelectionMode) { this._wordSelectDrag(data.position); </del> <ins> if (!data.onInjectedText) { if (this._hasMulticursorModifier(data)) { this._lastCursorWordSelect(data.position); </ins> } else { <del> this._wordSelect(data.position); </del> <ins> if (data.inSelectionMode) { this._wordSelectDrag(data.position); } else { this._wordSelect(data.position); } </ins> } } } else {

Discussion:
have an inlay hint with command double click the hint to run the command the current word is selected too
I believe this needs some changes in the editor. Preventing default on the mouse event doesn't seem to fix it.
What should happen when the user clicks on an inlay hint for a single time?
Nothing, unless it's a cmd/ctrl-click on an active label part link
Change:
compatibleExtension = extension; } <del> if (!compatibleExtension && fetchCompatibleVersion) { compatibleExtension = await this.galleryService.getCompatibleExtension(extension, includePreRelease, targetPlatform); </del> <ins> if (!compatibleExtension) { if (sameVersion) { compatibleExtension = (await this.galleryService.getExtensions([{ ...extension.identifier, version: extension.version }], { targetPlatform, compatible: true }, CancellationToken.None))[0] || null; } else { compatibleExtension = await this.galleryService.getCompatibleExtension(extension, includePreRelease, targetPlatform); } </ins> } return compatibleExtension;

Discussion:
Version: 1.65.0-insider (user setup) Commit: Date: 2022-02-11T05:19:13.554Z Electron: 16.0.8 Chromium: 96.0.4664.110 16.9.1 V8: 9.6.180.21-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: an extension (such as the C/C++ extension) that uses platform-specific VSIX's in the marketplace. a Remote WSL workspace. Install that extension into the remote. the extension UI for the instance installed remotely, try to select "Install Another Version..." or "Install Another Prerelease Version..." This results in an error: ! (There is a similar error in latest non-insider version, 1.64.2)
Can you please enable the log level to trace and provide following logs while performing this action? Log (Shared) Log (Window) Log (Remote)
When this repro's, I see the following in (with and is set to . I do not see any such setting as ) : is similar: was not logged to for this repro.
You can use following command to set log level to trace
Log (Shared): Log (Windows): Log (Remote Server): Log (Remote Extension Host): Please re-open. Please don't block waiting for me to provide information. This bug is extremely easy to reproduce.
Please re-open.
To verify: Open a remote window (make sure local and remote are on different Operating Systems) Install C++ extension Install another version of C++ extension (right click on the extension and you will see this action) Make sure another version is installed.
Change:
let charCode = tokenText.charCodeAt(charIndex); switch (charCode) { case CharCode.Tab: <del> result += '&rarr;'; </del> <ins> result += 'u2192'; // &rarr; </ins> break; case CharCode.Space: <del> result += '&middot;'; break; case CharCode.LessThan: result += '&lt;'; break; case CharCode.GreaterThan: result += '&gt;'; break; case CharCode.Ampersand: result += '&amp;'; </del> <ins> result += 'u00B7'; // &middot; </ins> break; default:

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . It aims to replace construction of HTML elements by string concatenation in file. The code contains mainly a table construction by concatenating strings of . The goal is to replace them all with function calls.