jiebi/CodeConvo huggingface dataset:
Change:
} registerQuickFixProvider(id: string, provider: ITerminalQuickFixProvider): IDisposable { <del> this._providers.set(id, provider); const selector = this._selectors.get(id); if (!selector) { throw new Error(`No registered selector for ID: ${id}`); } this._onDidRegisterProvider.fire({ selector, provider }); </del> <ins> // This is more complicated than it looks like it should be because we need to return an // IDisposable synchronously but we must await ITerminalContributionService.quickFixes // asynchronously before actually registering the provider. let disposed = false; this._terminalContributionService.quickFixes.then(() => { if (disposed) { return; } this._providers.set(id, provider); const selector = this._selectors.get(id); if (!selector) { throw new Error(`No registered selector for ID: ${id}`); } this._onDidRegisterProvider.fire({ selector, provider }); }); </ins> return toDisposable(() => { <del> this._selectors.delete(id); </del> <ins> disposed = true; </ins> this._providers.delete(id); <del> this._onDidUnregisterProvider.fire(selector.id); </del> <ins> const selector = this._selectors.get(id); if (selector) { this._selectors.delete(id); this._onDidUnregisterProvider.fire(selector.id); } </ins> }); } }

Discussion:
Running out of sources I see this:
This means that the contribution isn't getting evaluated before is called. Not too familiar with how / when is handled, but we call when the is created
I think perhaps moving that to the top of the constructor (before registering the command handlers) will fix this
This happens on window open
and the quick fix does work for that extension !
Seeing this in error telemetry for Insiders from 12/23:
This is the 6th error by machines in telemetry https://vscode-
I cannot reproduce this in Insider's. did you notice this after doing anything in particular?
I got this error when using remote dev container <details<summaryWindow</summary</details
Fixed in
Actually still found it in my devtools today:
I can't reproduce, but I can simulate the race by adding to 's promise in
HI, im having the same problem here 2023-02-16 17:10:14.453 [error] Error: No registered selector for ID: ms- at R.registerQuickFixProvider (vscode-file://vscode-) at r.$registerQuickFixProvider (vscode-file://vscode-) at m.N (vscode-file://vscode-) at m.M (vscode-file://vscode-) at m.H (vscode-file://vscode-) at m.G (vscode-file://vscode-) at vscode-file://vscode- at g.invoke (vscode-file://vscode-) at n.deliver (vscode-file://vscode-) at a.fire (vscode-file://vscode-) at r.fire (vscode-file://vscode-) at Z.onmessage (vscode-file://vscode-) I got vs code 1.71.1 running on W11 21H2 How i am supposed to fix this, or it's not a problem and vs code is working normally? Thank you!
Update your VS code version, where this is fixed
Sorry, i typed incorrectly mi vs code version. It is the latest one 1.75.1, i reinstalled it today.
I can still reproduce in latest stabel 1.75.1 https://user-
Change:
const baseLocalLinkClause = _platform === platform.Platform.Windows ? winLocalLinkClause : unixLocalLinkClause; // Append line and column number regex this._localLinkPattern = new RegExp(`${baseLocalLinkClause}(${lineAndColumnClause})`); this._xterm.setHypertextLinkHandler(this._wrapLinkHandler(() => true)); this._xterm.setHypertextValidationCallback((uri: string, element: HTMLElement, callback: (isValid: boolean) => void) => { this._validateWebLink(uri, element, callback);

Discussion:
tslint outputs errors in this format: /cc Related:
Doesn't work for me when there's a space between line and col, it looks like tslint is outputting it that way Top goes to correct line/col, bottom just goes to the file !
do you have an example program that outputs like this?
tslint apparently does, from the example above?
I actually can't click at all in this example !
Change:
return fatal('Missing pipe'); } <del> if (process.env['VSCODE_GIT_COMMAND'] === 'fetch') { return fatal('Skip fetch commands'); } </del> const output = process.env['VSCODE_GIT_ASKPASS_PIPE'] as string; const socketPath = process.env['VSCODE_GIT_ASKPASS_HANDLE'] as string; const request = argv[2];

Discussion:
I'm working with a password protected Git repo in VS Code I open command pallet (F1) and execute a Git command Now most commands like , , etc. correctly asks for a password by showing a UI password prompt. However, certain commands like , etc. do not ask for a password by showing a UI password prompt and fails with error
I see explicitly skips the command. Any particular reason for this?
We skip fetch since it's done automatically behind the scenes, most of the time. We should probably change the check to make sure it is only skipped if the fetch is automatic (vs manually).
I had the same problem. Cannot type my prompt password anymore. Have any workaround without set a credentials? Thanks.
Change:
readonly roots: ExplorerItem[]; readonly sortOrderConfiguration: ISortOrderConfiguration; <del> getContext(respectMultiSelection: boolean): ExplorerItem[]; </del> <ins> getContext(respectMultiSelection: boolean, ignoreNestedChildren?: boolean): ExplorerItem[]; </ins> hasViewFocus(): boolean; setEditable(stat: ExplorerItem, data: IEditableData | null): Promise<void>; getEditable(): { stat: ExplorerItem; data: IEditableData } | undefined;

Discussion:
https://user-
This issue may be same with When run the command on file which using file nesting, passed multiple file paths.

Type: <bBug</b https://user- VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-20T05:16:19.460Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (71)</summaryExtensionVersion ------ better-comments3.0.0 extendscript-debug2.0.3 tsl-problem-matcher0.6.2 file-nesting1.0.0 color-info0.7.0 github-markdown-preview0.3.0 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.3.0 markdown-footnotes0.0.7 markdown-mermaid1.14.2 markdown-preview-github-styles1.0.1 markdown-yaml-preamble0.1.0 file-browser0.2.10 vscode-translation2.0.6 vscode-url-title-resolver1.1.1 compare-view0.7.0 vscode-opennewinstance0.0.12 gitignore0.8.0 vscode-markdownlint0.47.0 vscode-eslint2.2.6 githistory0.6.19 tsimportsorter7.4.19 css-flexbox-cheatsheet3.3.1 css-initial-value0.2.6 gitlens-insiders2022.7.2005 vscode-html-css1.13.0 prettier-vscode9.5.0 code-runner0.11.8 shell-format7.2.2 todo-tree0.0.215 vscode-nginx-conf-hint0.3.0 path-autocomplete1.19.1 vscode-env0.1.0 markdown-kbd0.4.2 svg1.4.19 vscode-gutter-preview0.30.0 template-string-converter0.6.0 hexeditor1.9.7 js-debug-nightly2022.7.1117 live-server0.2.12 test-adapter-converter0.1.6 vscode-js-profile-flame1.0.4 vscode-typescript-next4.8.

vetur0.35.0 vscode-twoslash-queries1.0.2 vscode-versionlens1.0.10 git-file-history1.0.1 text-power-tools1.34.0 vscode-xml0.21.0 vscode-yaml1.9.1 vue-vscode-snippets3.1.1 vscode-fileutils3.5.0 code-spell-checker2.3.1 vscode-stylelint1.2.2 markdowntable0.10.0 hosts1.2.0 vscode-choosealicense0.7.0 vscodeintellicode1.2.22 vscode-icons11.13.0 snippet-generator0.3.2 modify-file-warning0.0.2 open-in-external-app0.5.0 regexp-tools0.0.1 scripting-listener0.0.3 view-github-repository1.1.0 vscode-archive0.1.2 vscode-fe-helper0.2.1 ytj-snippets0.0.5 markdown-all-in-one3.4.3 node-modules1.4.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Mine reveals but it reveals the child and not the parent so definitely a bug
if you ensure that no item in the explorer view has focus, then right click the parent, nothing will happen when you reveal in explorer/finder edit: actually that isn't consistent, in some cases nothing happens and sometimes it does what you said, I do not know the exact repro
Change:
return; } <del> const text = editor.getModel().getValueInRange(editor.getSelection()); </del> <ins> const selection = editor.getSelection(); let text: string; if (selection.isEmpty()) { text = editor.getModel().getLineContent(selection.selectionStartLineNumber).trim(); } else { text = editor.getModel().getValueInRange(selection); } </ins> await session.addReplExpression(viewModel.focusedStackFrame!, text); await viewsService.openView(REPL_VIEW_ID, false); }

Discussion:
I don't see why the "Debug: Evaluate in Debug Console" command can't be a parallel of the "Terminal: Run Selected Text In Active Terminal" command, which, when no text is selected, sends the full current line. This is how most evaluate-and-run environments work (Jupyter notebooks, RStudio, Matlab), and it would be great to have that feature during debugging. As long as someone is updating this command, it would be great to add an called something like so that when you use the command to send a line of code, the editor also advances the current line (again, this is a UX element that Jupyter, RStudio, and Matlab are built around). Originally posted by in
Change:
const outputScrolling = ctx.settings.outputScrolling; const content = createOutputContent(outputInfo.id, [err.stack ?? ''], ctx.settings.lineLimit, outputScrolling, true); <del> content.classList.toggle('word-wrap', ctx.settings.outputWordWrap); </del> <ins> const contentParent = document.createElement('div'); contentParent.classList.toggle('word-wrap', ctx.settings.outputWordWrap); </ins> disposableStore.push(ctx.onDidChangeSettings(e => { <del> content.classList.toggle('word-wrap', e.outputWordWrap); </del> <ins> contentParent.classList.toggle('word-wrap', e.outputWordWrap); </ins> })); <del> content.classList.toggle('scrollable', outputScrolling); </del> <ins> contentParent.classList.toggle('scrollable', outputScrolling); </ins> outputElement.classList.toggle('hide-refresh', !outputScrolling); disposableStore.push(ctx.onDidChangeSettings(e => { outputElement.classList.toggle('hide-refresh', !e.outputScrolling); })); outputElement.classList.toggle('remove-padding', outputScrolling); <del> outputElement.appendChild(content); initializeScroll(content, disposableStore); </del> <ins> contentParent.appendChild(content); outputElement.appendChild(contentParent); initializeScroll(contentParent, disposableStore); </ins> } else { const header = document.createElement('div'); const headerMessage = err.name && err.message ? `${err.name}: ${err.message}` : err.name || err.message;

Discussion:
create a notebook with a cell that produces long output: hover over the scrollbar within the output, it should be the pointer, but it is text
The scrollbar inherits the cursor style from this container and a override in doesn't seem to work.
Change:
return provider.provideDocumentLinks(doc, noopToken); } <ins> function assertLinksEqual(actualLinks: readonly vscode.DocumentLink[], expectedRanges: readonly vscode.Range[]) { assert.strictEqual(actualLinks.length, expectedRanges.length); for (let i = 0; i < actualLinks.length; ++i) { assertRangeEqual(actualLinks[i].range, expectedRanges[i], `Range ${i} to be equal`); } } </ins> suite('markdown.DocumentLinkProvider', () => { test('Should not return anything for empty document', async () => { const links = await getLinksForFile('');

Discussion:
Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.61.2 OS Version: macOS Big Sur Steps to Reproduce: a new markdown file. ! But according to it isn't necessary to escape spaces when the text is enclosed in :
Removing help wanted since this is a bit more complicated than anticipated
Thanks!
Change:
*--------------------------------------------------------------------------------------------*/ import { BrowserMessageReader, BrowserMessageWriter, createConnection } from 'vscode-languageserver/browser'; <del> import { startServer } from '../server'; </del> <ins> import { startVsCodeServer } from '../server'; </ins> declare let self: any;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was testing the server on neovim. I noticed the requires a lot from the client. Would it be possible to bundle default implementations of and all other custom requests to make the server self-contained?
I'd take a PR that does this (likely using service injection) but the current design is deliberate lets the client bring their own parser versionThe custom file messages means the server is not restricted to working with local files. Ideally the LSP would also include this functionality but right now it does not
I can make a PR. Wouldn't it be simpler to add a setting for a custom tokenizer? Then call with or make a request?
makes this easier to use the server as a library. For a client that doesn't want to implement the custom messages we use, you'd instead want to use the new version of which lets you pass in your own parser and workspace implementations
Change:
if (event.relatedTarget) { if (!this.container.getHTMLElement().contains(event.relatedTarget as HTMLElement)) { this.focusToReturn = null; <del> this.focusState = this.currentMenubarVisibility === 'toggle' ? MenubarState.HIDDEN : MenubarState.VISIBLE; </del> <ins> this.setUnfocusedState(); </ins> } } });

Discussion:
Issue Type: <bBug</bWhen using the custom title bar and the toggled menu bar setting, the menu bar becomes stuck in the toggled on state. This primarily occurs when the active VS Code window becomes inactive while the menu bar is toggled on. When using multiple VS Code windows this makes it difficult to identify the correct window because the title bar's filename information is hidden. Steps to reproduce: the setting to , and setting to VS Code is the active window, hold down the key to show the menu bar the key while still holding the key to switch to another application. The active VS Code window becomes inactive and the menu bar is visible. Alternatively you can click outside of the active VS Code window while the menu bar is being displayed. VS Code version: Code 1.25.0 (, 2018-07-05T13:11:58.697Z) OS version: Windows_NT x64 10.0. <details<summaryExtensions (4)</summaryExtensionVersion ------ classic-asp0.0.4 vscode-icon-theme1.6.2 csharp1.15.2 PowerShell1.8.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.538 --- <!-- score: 0.491 --- <!-- score: 0.483 --- <!-- score: 0.482 --- <!-- score: 0.48 --<!-- potentialduplicatescomment --
Change:
readonly detailsLabel: HTMLElement; readonly readMore: HTMLElement; readonly disposables: DisposableStore; <ins> readonly configureFont: () => void; </ins> } export class ItemRenderer implements IListRenderer<CompletionItem, ISuggestionTemplateData> {

Discussion:
or VS Code Desktop something to make the autocompletion menu appear. the dash key (-) multiple times to zoom in a lot. Only the text in the menu gets larger while the html elements stay the same size. ! The html should resize with the text appropriately. Zooming in first and then revealing the menu produces the correct sizes on everything. It's possible that "" is the incorrect command to call in this case. Perhaps a list of commands could be provided?
To verify bind a keybinding to Editor Zoom In/out trigger suggest while it shows, use the editor zoom keybindings
Change:
/* State "badge" displaying the active session's current state. * Only visible when there are more active debug sessions/threads running. */ <del> .debug-pane .debug-call-stack .thread > .state > .label, .debug-pane .debug-call-stack .session > .state > .label, .debug-pane .monaco-list-row.selected .thread > .state > .label, .debug-pane .monaco-list-row.selected .session > .state > .label { </del> <ins> .debug-pane .debug-call-stack .thread > .state.label, .debug-pane .debug-call-stack .session > .state.label, .debug-pane .monaco-list-row.selected .thread > .state.label, .debug-pane .monaco-list-row.selected .session > .state.label { </ins> background-color: ${debugViewStateLabelBackgroundColor}; color: ${debugViewStateLabelForegroundColor}; }

Discussion:
Testing Badge should use text ellipsis when there is not enough room to display the full message: !
Good catch. Yes, we should improve this.
Not for endgame since we always behaved like this. Moving out of milestone and opening up for PRs. Code pointer
Change:
const styler = attachInputBoxStyler(inputBox, this.themeService); const lastDot = value.lastIndexOf('.'); <ins> let currentSelectionState = 'prefix'; </ins> inputBox.value = value; inputBox.focus();

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When I select a file in the left side bar and hit the file prefix is selected. ! I would like to hit a second time to select the whole file name. ! When I press a third time the prefix should be selected again. So pressing should just toggle between "prefix" and "whole name". This is a feature I use very often in Total Commander. It is usefull if you want to copy the complete file name.
Interesting idea. Maybe the second press could select just the suffix, and the third press cycle around to just the prefix.
I like Personally I would think cycling from left to right would be best 1st press =prefix 2nd press =all 3rd press =suffix 4th press =cycles back around to prefix when highlighting the suffix, should it also include the seperating dot?
I think the dot should only be selected, wenn all is selected.
that's actually what I meant. I forgot to count the initial F2 that begins the rename operation.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
! Coming to a VS Code near you. There's still some quirks to work out as right now it is hardcoded to F2 but technically you can set the rename keybinding to anything. It's especially not clear on macOS where the default keybinding is but clicking and having your selection change would be infuriating
Great. But I would still prefer if the dot was not selected in combination with the suffix. When you select the suffix you usually want to change it something else. This means you would have to type the dot again.
To verify ensure that pressing after entering rename mode cycles between different segments of the file name
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ 'use strict'; import * as vscode from 'vscode'; import * as path from 'path'; export default class MarkdownDocumentLinkProvider implements vscode.DocumentLinkProvider { private _linkPattern = /([[^]]*](s*?)(S+?)(s+[^)]*)?)/g; public provideDocumentLinks(document: vscode.TextDocument, token: vscode.CancellationToken): vscode.DocumentLink[] { const results: vscode.DocumentLink[] = []; const base = path.dirname(document.uri.fsPath); const text = document.getText(); this._linkPattern.lastIndex = 0; let match: RegExpMatchArray | null; while ((match = this._linkPattern.exec(text))) { const pre = match[1]; const link = match[2]; const offset = match.index + pre.length; const linkStart = document.positionAt(offset); const linkEnd = document.positionAt(offset + link.length); try { let uri = vscode.Uri.parse(link); if (!uri.scheme) { // assume it must be a file let file; if (uri.path[0] === '/') { file = path.join(vscode.workspace.rootPath, uri.path); } else { file = path.join(base, uri.path); } uri = vscode.Uri.file(file); } results.push(new vscode.DocumentLink( new vscode.Range(linkStart, linkEnd), uri)); } catch (e) { // noop } } return results; } }; </ins>

Discussion:
It is possible to follow local links for the markdown? For example, I have two splits for a markdown file: one for editing, and the other one for previewing. If I have a local link . When clicking this link in the preview split, is it possible for both the two splits automatically switch to Further, is it possible to sync two scroll bars for the preview split and the edit split?
That would be nice for docs written in Markdown.
VSCODE 1.7.1 on Windown 8.1 Currently the links are working in the preview Pane, but can not be followed from editor with like it is possible for normal links !
I just checked in a fix to support identifying links in the markdown editor . will tackle clicking local links in the preview itself. Please give it a try in the next insiders build
Tried the insiders build, works as expected. Great work, thanks Update: Spaces in the file names are not recognized
Change:
EditorOption.gotoLocation, 'gotoLocation', defaults, { 'editor.gotoLocation.multiple': { <del> deprecationMessage: nls.localize('editor.gotoLocation.multiple.deprecated', "This setting is deprecated, please use separate settings like 'editor.editor.gotoLocation.multipleDefinitions' or 'editor.editor.gotoLocation.multipleImplemenations' instead."), </del> <ins> deprecationMessage: nls.localize('editor.gotoLocation.multiple.deprecated', "This setting is deprecated, please use separate settings like 'editor.editor.gotoLocation.multipleDefinitions' or 'editor.editor.gotoLocation.multipleImplementations' instead."), </ins> }, 'editor.gotoLocation.multipleDefinitions': { description: nls.localize('editor.editor.gotoLocation.multipleDefinitions', "Controls the behavior the 'Go to Definition'-command when multiple target locations exist."),

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.41.0-insider OS Version: Windows_NT x64 10.0. Steps to Reproduce: to settings for "Implemenations" "Editor Goto Location: Multiple Implemenations" appears instead of "Editor Goto Location: Multiple Implementations" This also shows up as "editor.gotoLocation.multipleImplemenations" in "" instead of as "editor.gotoLocation.multipleImplementations" <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Change:
} // Auxiliary Panel to restore <del> const auxiliaryBarVisible = this.isVisible(Parts.AUXILIARYBAR_PART); if (auxiliaryBarVisible || (isNewWindow && activityBarNotDefault)) { </del> <ins> if (this.isVisible(Parts.AUXILIARYBAR_PART)) { </ins> const viewContainerToRestore = this.storageService.get(AuxiliaryBarPart.activePanelSettingsKey, StorageScope.WORKSPACE, this.viewDescriptorService.getDefaultViewContainer(ViewContainerLocation.AuxiliaryBar)?.id); if (viewContainerToRestore) { this.state.initialization.views.containerToRestore.auxiliaryBar = viewContainerToRestore; <del> } if (auxiliaryBarVisible !== !!viewContainerToRestore) { this.stateModel.setRuntimeValue(LayoutStateKeys.AUXILIARYBAR_HIDDEN, !auxiliaryBarVisible); </del> <ins> } else { this.stateModel.setRuntimeValue(LayoutStateKeys.AUXILIARYBAR_HIDDEN, true); </ins> } }

Discussion:
Type: <bBug</ba folder open. sure that the Secondary Side Bar is hidden. VS Code Insiders. it again. Secondary Side Bar displays VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-10T05:04:21.546Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
The idea here was that when the activity bar is a the top, we would show the sidebars if they were open when you closed vscode as the activity bar is otherwise not visible. Thoughts? Do you think we should not do it at all or just for the primary side bar?
Is one (the primary) having been open at shutdown causing both (previously-hidden secondary as well as primary) to show on next startup? This doesn't seem right to me.
No, should be individually. We check if primary was open at shutdown, then we open primary and we check if secondary was closed at shutdown, if so, we open secondary
Did you write closed intentionally? That's indeed the behaviour I'm seeing, but I think secondary should only open at startup if it was open at shutdown.