jiebi/CodeConvo huggingface dataset:
Change:
return undefined; } <del> const items = await Promise.all(coalesce(elements || []).map(async element => { const item = await this.dataProvider.getTreeItem(element); return item && !cts.token.isCancellationRequested ? this.createAndRegisterTreeNode(element, item, parentNode) : null; </del> <ins> const coalescedElements = coalesce(elements || []); const treeItems = await Promise.all(coalesce(coalescedElements).map(element => { return this.dataProvider.getTreeItem(element); </ins> })); if (cts.token.isCancellationRequested) { return undefined; } <ins> // createAndRegisterTreeNodes adds the nodes to a cache. This must be done sync so that they get added in the correct order. const items = treeItems.map((item, index) => item ? this.createAndRegisterTreeNode(coalescedElements[index], item, parentNode) : null); </ins> return coalesce(items); } finally { cts.dispose();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.81.1 (user setup) Commit: Date: 2023-08-09T22:22:42.175Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Or today's insiders. Steps to Reproduce: TypeScript or C++, do find all references on the 2nd+ reference with the references view in it's initial or cleared state. Bug: The reference that is used to trigger the operation is placed at the top instead of being sorted by line number as expected/desired. This gets fixed the 2nd time Find All References is invoked, but starts again after the Clear button is used. I initially thought this was a bug with our C++ extension, but the existence of the issue for TypeScript leads me to believe it's a VS Code bug, but I haven't debugged it. See the screenshot: <img width="126" alt="image" src=""
Could this be an issue with the tree API? I have debugged this and see that I am always returning the elements sorted by line
Yes, looks like it's an issue with the tree. The reference view is calling to show the tree item before the item has been rendered (which is fine), but a side effect of that is that the item is first.
Change:
const existingElement = dom.$('span.existingText'); const text = numberOfExisting === 1 ? nls.localize('defineKeybinding.oneExists', "1 existing command has this keybinding", numberOfExisting) : nls.localize('defineKeybinding.existing', "{0} existing commands have this keybinding", numberOfExisting); dom.append(existingElement, document.createTextNode(text)); <ins> aria.alert(text); </ins> this._showExistingKeybindingsNode.appendChild(existingElement); existingElement.onmousedown = (e) => { e.preventDefault(); }; existingElement.onmouseup = (e) => { e.preventDefault(); };

Discussion:
A11yMAS; #A11yWCAG2.1; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.3; #NVDA; #ScreenReader; #Narrator; #Closed Visual Studio Code Version: 1.70.2 (user setup) Windows 11 Pro version 21H2 (OS Build .856) on NVDA Visual studio code editor. till setting icon and Select "Keyboard shortcuts options" that Key bending status message "1 existing command has this key bending" is announced by screen reader or not. Key bending status message "1 existing command has this key bending" is not announced by NVDA/Narrator screen readers. NVDA/Narrator should announce the status message "1 existing command has this key bending" ! !
can we just do an aria alert when there are existing keybindings? This issue we have to fix since it is severity 2, though it sounds law hanging.
PO should not close the bug. Only trusted tester closes the bug. This bug is not fixed. So, please provide the reason for closing the bug. Thanks
make sure to use VS Code insiders
Issue is fixed. So,Closing the bug. !
Change:
} private testTags(element: TestItemTreeElement): FilterResult { <del> if (!this.state.onlyTags.size) { </del> <ins> if (!this.state.includeTags.size && !this.state.excludeTags.size) { </ins> return FilterResult.Include; } <del> return element.test.item.tags.some(t => this.state.onlyTags.has(t)) </del> <ins> return (this.state.includeTags.size ? element.test.item.tags.some(t => this.state.includeTags.has(t)) : true) && element.test.item.tags.every(t => !this.state.excludeTags.has(t)) </ins> ? FilterResult.Include : FilterResult.Inherit; }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Splitting this out from In the Test UI you can filter by text or exclude text using and filter by a . It would be nice if we could also negate tags in the filter like to exclude a specific tag. <!-- Describe the feature you'd like. --
Starting point, this is where tag filtering happens:
Change:
return normalizeIndentation(str, this.indentSize, this.insertSpaces); } <del> private _getShouldAutoClose(languageId: string, autoCloseConfig: EditorAutoClosingStrategy): (ch: string) => boolean { </del> <ins> private _getShouldAutoClose(languageId: string, autoCloseConfig: EditorAutoClosingStrategy, forQuotes: boolean): (ch: string) => boolean { </ins> switch (autoCloseConfig) { case 'beforeWhitespace': return autoCloseBeforeWhitespace; case 'languageDefined': <del> return this._getLanguageDefinedShouldAutoClose(languageId); </del> <ins> return this._getLanguageDefinedShouldAutoClose(languageId, forQuotes); </ins> case 'always': return autoCloseAlways; case 'never':

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Can the addition of the closing curly brace be whenever the opening curly brace is automatically initiated in an f-string in python? currently this doesn't happen and i need to add the closing curly brace when done - this feature would be useful --
Please add more details, e.g. a code sample.
apologies - I actually had but for some reason the main body of text wasn't posted. please see a below a code example - thank you. This is the current way in which the curly brace is interpreted in an f string. As you can see when you enter the opening curly brace, the closing one is not automatically inserted and i have to enter it manually.. it would be incredibly useful if the closing brace was automatically (in the same way automatic closing of brackets and braces is achieved outside of the print statement in the editor) to achieve something like: having said this - this is a trivial feature request, but i find myself using this a lot
is defined as bracket pair, also for when in strings, so I believe it should work.
Thank you for the reply! Hmm this doesn't for me unfortunately, is there a setting that needs to be activated?
does autoclose in strings in general e.g. https://user- But not at the position before the closing e.g. https://user- Relevant code:
ha! thank you, this is really interesting - i can confirm that it works when entering before the closing - funny because i have only ever really required the the braces before the closing comma (because this then creates a whitespace between the statement and the answer which is intended for visual purposes will this be treated as a bug to fix? again this obviously isn't critical. happy to close. thanks
This cannot be fixed at the moment. The behaviour is controlled by the autoCloseBefore property in the language configuration file, but quotes are not appropriate for that property. JavaScript and TypeScript make an exception for backticks.
Change:
bulkEditService.apply(edits, { label: nls.localize('convertIndentation', "Convert Indentation"), code: 'undoredo.convertIndentation', }); <del> })).then((notebookEdits) => { </del> <ins> })).then(() => { </ins> // store the initial values of the configuration const initialConfig = configurationService.getValue(NotebookSetting.cellEditorOptionsCustomizations) as any; const initialIndentSize = initialConfig['editor.indentSize'];

Discussion:
to repro: click notebook indentations statusbar entry run "indent using spaces/tabs" and select a new number entry will not update, however indentations work correctly given the selection that the user made and the current settings.

No a "choose intentation type" entry in status bar when editing in a notebook. I have a notebook with tab indentation but it seems theres some global spaces setting that overrides it... even pasting a literal tab charachter inserts spaces :/ !
False alarm. The status bar entry just moved so much that I didn't see it right away, and it has a different name in the status bar entries context menu.
Actually, looks like the status bar is really slow to update. I saw it update eventually, but I'm not sure what caused it to finally show the correct thing. !
Change:
reader => this._options.couldShowInlineViewBecauseOfSize.read(reader) )); <ins> this._register(bindContextKey(EditorContextKeys.hasChanges, this._contextKeyService, reader => (this._diffModel.read(reader)?.diff.read(reader)?.mappings.length ?? 0) > 0 )); </ins> this._editors = this._register(this._instantiationService.createInstance( DiffEditorEditors, this.elements.original,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Please disable the "Previous Change," "Next Change," and similar buttons in the diff view when there are no differences (both files are equal). This would be a swift way to ensure that no differences exist, especially when cheking between local and remote files. Such clarity can be crucial in certain situations. On the right side, it's also possible to observe the differences on the "file map." However, at times, this map might be cluttered with additional markings, such as code warnings, which can lead to confusion. Typically, I find myself clicking the "Next Change" button when I need to verify the presence of differences. If the file doesn't scroll, I can be confident that none exist. Yet, this workaround is unnecessary. Furthermore, adhering to good UX practices involves displaying buttons as disabled when they lack any action. !
When you are scrolled away from the single diff in a file, you can use these buttons to scroll back again to the diff. If there buttons would be disabled, this does not work anymore. Maybe the feature "Toggle Collapse Unchanged Lines" might help you.
If there are no differences (both files are equal) the buttons are useless (there is no diff to scroll to) and should be disabled to follow good UI practices. Edit: I improved the issue description.
!
Change:
import { IDebugService, IDebugSession, IDebugConfiguration, IConfig, ILaunch } from 'vs/workbench/contrib/debug/common/debug'; import { IThemeService } from 'vs/platform/theme/common/themeService'; import { attachSelectBoxStyler, attachStylerCallback } from 'vs/platform/theme/common/styler'; <del> import { SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme'; import { selectBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { selectBorder, selectBackground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { IContextViewService } from 'vs/platform/contextview/browser/contextView'; import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace'; import { IDisposable, dispose } from 'vs/base/common/lifecycle';

Discussion:
I played around with to set the background color of the dropdown widget. It works fine in the panel area but e.g. not for the debug dropdown. That makes me wonder if we possibly have code in debug land that overrides this because the debug view is in the side bar. That is probably not a good idea given you can move views around. !
Same for remote explorer, so it is maybe more generic: ! //cc
You are correct we use the sidebar_background for the debug I thought the issue is that we also have a green play button which is part of this and we did not want to custmoise it becuase the Green play might not look good on the customised background. As for the remote explorer I have no clue.
I think the remote one is covered via
That one was probably a copy paste mistake from debug land :)
last milestone and I saw this differentiation and assumed it was intentional that all sidebar dropdowns do not honor the theme color. this meant that if you drag terminal or output to the sidebar (in their own viewlet), they will also skip using the theme color for dropdown
I am opening this for a PR. Code pointer The debug select box should listen to style changes and also style the background of the Green Play button.
Adding lable bug so we get this verified.
Change:
export default class TypeScriptServiceClient extends Disposable implements ITypeScriptServiceClient { private readonly pathSeparator: string; <ins> private readonly emptyAuthority = 'ts-nul-authority'; </ins> private readonly inMemoryResourcePrefix = '^'; private readonly workspaceState: vscode.Memento;

Discussion:
Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:
Actually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that "You cannot rename this element" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.
I initially read the last part of the issue title as “thanks, language service” and thought the sarcasm was appropriate.
I may steal that in the future :D
can you transfer this issue to VSCode if appropriate?
Did this just start happening with the latest insiders?
Possible introduced with
Yeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
audioCueService = new TestAudioCueService(); taskTerminalStatus = new TaskTerminalStatus(taskService as any, audioCueService as any); testTerminal = instantiationService.createInstance(TestTerminal) as any; <del> testTask = instantiationService.createInstance(TestTask); </del> <ins> testTask = instantiationService.createInstance(TestTask) as unknown as Task; </ins> problemCollector = instantiationService.createInstance(TestProblemCollector) as any; }); test('Should add failed status when there is an exit code on task end', async () => {

Discussion:
Due to an oversight, does not enforce arguments or its return type. Fixing this exposes around 80 typings errors in our codebase that should be addressed To fix this issue in your code: , comment out the . (Do not check in this change. I will check in the change to the signature once all error have been fixed) look at the file assigned to you and fix the type error (you may need to restart the compile since we are changing such a core type) [x] — [x] — [x] — [x] — [x] — [x] — [x] — [ ] — [ ] — [ ] — [ ] — [x] — [x] — [x] — [x] — [x] — [x] — [ ] — [x] —
Change:
"keyword.operator.relational", "storage.type.function.arrow", "keyword.operator.bitwise.shift", <del> "punctuation.definition.tag" </del> <ins> "punctuation.definition.tag", "keyword.operator.assignment.compound.bitwise.ts" </ins> ], "embeddedLanguages": { "meta.tag.tsx": "jsx-tags",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.1 OS Version: Darwin x64 21.3.0 Steps to Reproduce: Code VSCode <img width="81" alt="Screen Shot 2022-09-04 at 4 35 00 AM" src="https://user-"GitHub color , VSCode color
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
This seems to be working correctly per you may want to see whats the issue with vscode
I think this may be caused by bracket matching
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I still see this: !
Change:
@IMenuService private menuService: IMenuService, @IContextKeyService contextKeyService: IContextKeyService, @IClipboardService private clipboardService: IClipboardService, <ins> @IKeybindingService private keybindingService: IKeybindingService, </ins> @IConfigurationService configurationService: IConfigurationService ) { super({ clickBehavior: ClickBehavior.ON_MOUSE_UP /* do not change to not break DND */ }, configurationService);

Discussion:
Looks like a regression: ! Compared to stable: !
Interestingly I do not see that in the editor context menu: !
see commit not in master
lgtm, we could merge this to June release via
Change:
"enablement": "!operationInProgress" }, { <ins> "command": "git.closeAllUnmodifiedEditors", "title": "%command.closeAllUnmodifiedEditors%", "category": "Git", "enablement": "!operationInProgress" }, { </ins> "command": "git.api.getRepositories", "title": "%command.api.getRepositories%", "category": "Git API"

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Quite often I want to have open only the files that are modified from source control. It would be handy to have a "Close all Unmodified" option that would close any open files that are not modified according to source control.
I would like to contribute on this.
Verification steps: a folder/workspace that contains a git repository auto-save using the setting multiple files, make changes, and save them multiple files but do not make any changes a file, make changes, but do not save it the "Git: Close All Unmodified Editors" command Confirm that all modified files remain open Confirm that the dirty editor remains open Confirm that all unmodified editors are closed
Change:
this.valueContainer.hidden = true; <del> await this.tree.setInput(expression); </del> <ins> this.expressionToRender = expression; </ins> this.complexValueTitle.textContent = expression.value; this.complexValueTitle.title = expression.value; <del> this.layoutTreeAndContainer(true); </del> <ins> this.editor.layoutContentWidget(this); </ins> this.tree.scrollTop = 0; this.tree.scrollLeft = 0; this.complexValueContainer.hidden = false;

Discussion:
an object that has many long property values There is no scrollbar the prototype There is a scrollbar !
Probably only with the horizontalscrolling setting enabled? I know that's a bit tricky
What's the setting for that? I don't have any scroll setting that appears debug related enabled. Just sticky scroll for the editor.
I think you have set, right?
No I do not.
Change:
} return store; } <ins> export function labelForHoverVerbosityAction(keybindingService: IKeybindingService, action: HoverVerbosityAction): string { switch (action) { case HoverVerbosityAction.Increase: { const kb = keybindingService.lookupKeybinding(INCREASE_HOVER_VERBOSITY_ACTION_ID); return kb ? nls.localize('increaseVerbosityWithKb', "Increase Hover Verbosity ({0})", kb.getLabel()) : nls.localize('increaseVerbosity', "Increase Hover Verbosity"); } case HoverVerbosityAction.Decrease: { const kb = keybindingService.lookupKeybinding(DECREASE_HOVER_VERBOSITY_ACTION_ID); return kb ? nls.localize('decreaseVerbosityWithKb', "Decrease Hover Verbosity ({0})", kb.getLabel()) : nls.localize('decreaseVerbosity', "Decrease Hover Verbosity"); } } } </ins>

Discussion:
Testing the keybinding for verbosity hover over =Shows the keybinding accessibility view of the hover focus to the by clicking A hover for the action shows without the keybinding !
Change:
const focusChanged = !this.ui?.container.contains(document.activeElement); this.controller = null; this.onHideEmitter.fire(); <del> const ui = this.getUI(); ui.container.style.display = 'none'; ui.list.setElements([]); </del> <ins> this.getUI().container.style.display = 'none'; </ins> if (!focusChanged) { let currentElement = this.previousFocusElement; while (currentElement && !currentElement.offsetParent) {

Discussion:
Steps to Reproduce: Open theme picker Select any theme Nothing happens
After , I new also get a with empty active
Maybe related?
Yes this appears to have happened yesterday. This change is suspicious:

I think this started for me with the new insiders version today, when I press to open symbol, often focus remains in the editor and is not put into the input box. See video: ! Steps for me are to switch to another editor and then immediately try //cc for a related fix in this area
I can still reproduce in todays insider, but with command palette. !
This seems to happen when the input box is not shown so: ctrl+tab cmd+shift+p
points me to this
thanks a lot for bisecting this and the revert
Change:
} .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.active.tab-border-top > .tab-border-top-container, <del> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.active.tab-border-bottom > .tab-border-bottom-container, </del> <ins> .monaco-workbench .part.editor > .content .editor-group-container > .title:not(.two-tab-bars) .tabs-container > .tab.active.tab-border-bottom > .tab-border-bottom-container, .monaco-workbench .part.editor > .content .editor-group-container > .title.two-tab-bars .tabs-and-actions-container:not(:first-child)  .tabs-container > .tab.active.tab-border-bottom > .tab-border-bottom-container, </ins> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.dirty-border-top > .tab-border-top-container { display: block; position: absolute;

Discussion:
Testing With the default light modern theme and this layout: ! See how the active tab in the first row shows no border to the bottom row. I think I would have expected the border to go through here.