jiebi/CodeConvo huggingface dataset:
Change:
* @returns whether the provided parameter is of type `Buffer` or Uint8Array dervived type */ export function isTypedArray(obj: unknown): obj is Object { <ins> const TypedArray = Object.getPrototypeOf(Uint8Array); </ins> return typeof obj === 'object' <del> && (obj instanceof Uint8Array || obj instanceof Uint16Array || obj instanceof Uint32Array || obj instanceof Float32Array || obj instanceof Float64Array || obj instanceof Int8Array || obj instanceof Int16Array || obj instanceof Int32Array || obj instanceof BigInt64Array || obj instanceof BigUint64Array || obj instanceof Uint8ClampedArray); </del> <ins> && obj instanceof TypedArray; </ins> } /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: =1.66.0 OS Version: iOS 14.3 Steps to Reproduce: Safari on iOS 14.3 to any vscode server (e.g. , or ) The Safari developer tools console shows the following error:
. I see references to in the following commits: (soft reference) Thoughts?
As this has been supported since iOS 15, do we want to change this?
The changes introduced in completely break vs code for all devices below iOS/iPadOS 15, the other occurrences of don't seem to have any negative impact according to my testing (anything below 1.66.0 works). The fix I proposed in is a more elegant solution that supports all browsers and does not break anything.
We are generally only aiming for latest and greatest browser version. The use of seems small enough to justify a special case but we shouldn't target a lower version nor is there any guarantee that other things won't break, e.g "fixing" this might just reveal another bunch of blocker etc pp.
Sounds good, forwarding to to evaluate the PR.
Change:
// dont show autosuggestions if the user has typed something, but hasn't used the trigger character if (alreadyTypedCount > 0 && query[wordStart] !== '@') { return []; } <del> return Query.autocompletions().map(replacement => ({ fullText: replacement, overwrite: alreadyTypedCount })); </del> <ins> return Query.autocompletions(query).map(replacement => ({ fullText: replacement, overwrite: alreadyTypedCount })); </ins> } private count(): number {

Discussion:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Change:
"keybindingLabel.foreground": "#000000e4", "list.activeSelectionBackground": "#e8e8e8", "list.activeSelectionForeground": "#000000", <ins> "list.activeSelectionIconForeground": "#000000", </ins> "list.hoverBackground": "#f2f2f2", "menu.border": "#D4D4D4", "notebook.cellBorderColor": "#E8E8E8",

Discussion:
Type: <bBug</bFound while verifying to light V2 theme extensions view and click on a verified extension Bug The verification checkmark goes white, making it difficult to see ! VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-25T05:23:34.922Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
} // Commit <del> let commandArg = ''; let title = localize('scm button commit title', "{0} Commit", '$(check)'); let tooltip = this.state.isCommitInProgress ? localize('scm button committing tooltip', "Committing Changes...") : localize('scm button commit tooltip', "Commit Changes"); </del> const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const postCommitCommand = config.get<string>('postCommitCommand');

Discussion:
Testing
Fixed with
Verification steps: Launch the latest VS Code Insiders Open a folder/workspace that contains a git repository Ensure that the setting is enabled Ensure that all three properties of the setting are enabled Use the setting to enable branch protection for the current branch Make a change to a file: Confirm that the "Commit" action button is shown and it has the codicon Set the setting to Confirm that the "Commit" action button is shown and it has the codicon
not sure what I'm doing wrong, but this doesn't seem to work for me (not getting the codicon). See below. Version: 1.70.0-insider (Universal) Commit: Date: 2022-07-26T05:17:37.262Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Darwin arm64 21.5.0 !
this looks like a regression. Re-opening the bug.
Change:
}, nls.localize('tabBorder', "Border to separate tabs from each other. Tabs are the containers for editors in the editor area. Multiple tabs can be opened in one editor group. There can be multiple editor groups.")); export const TAB_LAST_PINNED_BORDER = registerColor('tab.lastPinnedBorder', { <del> dark: null, light: null, </del> <ins> dark: treeIndentGuidesStroke, light: treeIndentGuidesStroke, </ins> hc: contrastBorder }, nls.localize('lastPinnedTabBorder', "Border to separate pinned tabs from other tabs. Tabs are the containers for editors in the editor area. Multiple tabs can be opened in one editor group. There can be multiple editor groups."));

Discussion:
The grey used as the pinned tab separator could be a bit stronger and I suggest it is the same grey as for the View separators. !
Yeah, this color is pretty much randomly selected. would you be interested in picking colors for our default themes? Just today I pushed to add the color to our default themes but I did not really spend a lot of time thinking about which color fits best. Most often I picked the border color of the peek view inside the editor. The color key is
Are we sure we don't want to push this as a default for all themes? Because out of the box it's nearly impossible to tell the difference in other themes. Like below, can you tell which files are pinned? !
yeah if you can find a good base color and rule for it, I am all up for it
Change:
["(", ")"] ], "autoClosingPairs": [ <del> ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] </del> <ins> { "open": "[", "close": "]" }, { "open": "{", "close": "}" }, { "open": "(", "close": ")" }, { "open": "'", "close": "'", "notIn": ["string", "comment"] }, { "open": """, "close": """, "notIn": ["string"] } </ins> ], "surroundingPairs": [ ["{", "}"],

Discussion:
VSCode Version: Code 1.11.2 (, 2017-04-13T08:03:11.395Z) OS Version: Windows_NT ia32 6.1.7601 Extensions: ; Steps to Reproduce: " don't " inside a comment. Get " don't' " Should be able to disable auto close inside comments and control auto-close inside and outside comments per bracket type and language type.
What language are you working in? I believe that languages can already restrict this functionality in their language configuration, see for example. Perhaps that language you are working in doesn't use in this configuration
I'm using C and C++. Should I file an issue in the C/C++ extension?
Thanks. We control at least the the basic c/c++ language configuration and I confirmed that it does not use . Would you like to submit a PR with the fix? . Take a look at the for an example of
Unfortunately, I'm not really in the position to submit as I don't have any the tools installed. I don't have git installed (as at work using ClearCase) and I don't know what the other tools are. I'll see if I can work out the settings and paste the configuration in here.
Change:
} })); <del> this._register(this.gettingStartedService.onDidAddBuiltInWalkthrough(rerender)); </del> <ins> this._register(this.gettingStartedService.onDidAddBuiltInWalkthrough(() => { rerender(); const someStepsComplete = this.gettingStartedCategories.some(category => category.steps.find(s => s.done)); if (!this.productService.openToWelcomeMainPage && !someStepsComplete && !this.hasScrolledToFirstCategory) { const firstSessionDateString = this.storageService.get(firstSessionDateStorageKey, StorageScope.APPLICATION) || new Date().toUTCString(); const daysSinceFirstSession = ((+new Date()) - (+new Date(firstSessionDateString))) / 1000 / 60 / 60 / 24; const fistContentBehaviour = daysSinceFirstSession < 1 ? 'openToFirstCategory' : 'index'; if (fistContentBehaviour === 'openToFirstCategory') { const first = this.gettingStartedCategories.filter(c => !c.when || this.contextService.contextMatchesRules(c.when))[0]; this.hasScrolledToFirstCategory = true; if (first) { this.currentWalkthrough = first; this.editorInput.selectedCategory = this.currentWalkthrough?.id; this.buildCategorySlide(this.editorInput.selectedCategory, undefined); this.setSlide('details'); return; } } } })); </ins> this._register(this.gettingStartedService.onDidAddWalkthrough(rerender)); this._register(this.gettingStartedService.onDidRemoveWalkthrough(rerender));

Discussion:
This scenario is flaky due to a timing issue between walkthroughs being registered and check for first open. I can repro this occasionally.
I think this should be on the May milestone?
Verification Steps: VS Code with a clean profile that the Setup walkthrough launches on startup. <img width="766" alt="image" src=""
Didn't work for me Mac OS !
I can repro this on the mac. Works as expected on windows.
Change:
const label = compressed.elements.map(e => e.name).join('/'); const fileKind = FileKind.FOLDER; <ins> const [matches, descriptionMatches] = splitMatches(folder.uri, node.filterData); </ins> template.fileLabel.setResource({ resource: folder.uri, name: label }, { fileDecorations: { colors: false, badges: true }, fileKind, <del> matches: createMatches(node.filterData) </del> <ins> matches, descriptionMatches </ins> }); template.actionBar.clear();

Discussion:
I often make a lot of changes at once, and then need to commit them. Some changes don't belong together in the same commit, and some aren't ready to be committed at all. The current UI allows me to select some files to be staged for commit and exclude others, but it requires me to carefully select my changes from a potentially very long list. It would be incredibly useful if I could search or filter files by path pattern and stage/unstage all search results. Even better would be if I could search for lines of code and either stage files containing those lines or just the matched lines. This would streamline my git workflow by a lot.
I guess my ideal UI would allow me to: search files by path, and stage/unstage all matched files stage/unstage individually selected files search code in files, and stage/unstage all matched lines stage/unstage individually selected lines stage/unstage all matched files stage/unstage individually selected files
Since last month, SCM supports fancy keyboard navigation and filtering. Simply start typing when focused on the view. A widget will appear which you can use to toggle between simple highlighting and filtering. Currently filtering is done only on file names though, not paths or even code, so I can leave this open for additional filtering fields.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
"@typescript-eslint/experimental-utils": "^5.57.0", "@typescript-eslint/parser": "^5.57.0", "@vscode/gulp-electron": "^1.36.0", <del> "@vscode/l10n-dev": "0.0.21", </del> <ins> "@vscode/l10n-dev": "0.0.30", </ins> "@vscode/telemetry-extractor": "^1.10.2", "@vscode/test-cli": "^0.0.3", "@vscode/test-electron": "^2.3.5",

Discussion:
<img width="415" alt="image" src=""Looks localized here though, and hasn't changed in 13 months
language pack looks ok too... Looking into this some more... it seems that the new lines aren't being handled properly.
This still repros :/ is the loc pipeline maybe not running?
it is the newlines... which I thought I fixed... sigh... They are being escaped in the language pack: if I manually delete these extra slashes locally, the problem goes away.
Update... the text has change: Now it's using when it should use and I think I know why. So exporting looks find: is turned in to (we do this manually and it's the XML way to say ) but what we get from the translators... they replace with actual new lines That's not what I was expecting. I would expect them to use the encoded characters but they're not. hacky quick fix that fixes likely most of the scenarios: more accurate longer fix: now that I think about it, this is probably the correct workaround for extensions as well
<img alt="image" src=""Looks like it works now
Change:
const currentHtmlNode = <HtmlFlatNode>currentNode; if (currentHtmlNode && currentHtmlNode.open && currentHtmlNode.close) { const offset = document.offsetAt(position); <del> if (currentHtmlNode.open.end <= offset && offset <= currentHtmlNode.close.start) { if (currentHtmlNode.name === 'style' && currentHtmlNode.open.end < offset && currentHtmlNode.close.start > offset) { </del> <ins> if (currentHtmlNode.open.end < offset && offset <= currentHtmlNode.close.start) { if (currentHtmlNode.name === 'style') { </ins> const buffer = ' '.repeat(currentHtmlNode.open.end) + document.getText().substring(currentHtmlNode.open.end, currentHtmlNode.close.start); return parseStylesheet(buffer); }

Discussion:
Issue Type: <bBug</bwrite as html: "<div class="center"<div<h1<spanВведите имя статьи:</span</h1</div<div<input class="newPageName" type="text" placeholder="Введите имя статьи" /</div</div { padding: 0 auto; } .center h1{ text-align: center; } .center input.newPageName </style" while typing '' we can see emmet help window with 'Nanew...' VS Code version: Code 1.49.2 (, 2020-09-24T16:29:41.983Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ better-comments2.1.0 vscode-standardjs1.3.0 jshint0.10.21 vscode-eslint2.1.8 jquerysnippets0.0.1 xml2.5.1 gitlens10.2.2 LogFileHighlighter2.9.0 vsc-material-theme33.0.0 vsc-material-theme-icons1.2.0 prettier-vscode5.7.1 vscode-firefox-debug2.9.1 vscode-npm3.3.0 vscode-gutter-preview0.26.2 vs-color-picker1.0.0 metago4.2.0 MetaJump1.1.1 MetaWord1.2.1 debugger-for-chrome4.12.11 vscode-css-peek4.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.564 --<!-- potentialduplicatescomment --
Duplicate of
Deduplicating since this only occurs in HTML files
It doesn't suggest now in the latest Insiders, but it's still making a suggestion when it's not supposed to. Leaving this issue open.
can you please give some clarity on this issue. I would like to contribute here.

I have a VS code setup with Version: 1.53.0 and I am not able to repro the Nan issue here Following are the changes that I made to repro the issue - Vs code , created an Html file this code snippet - Did not encounter the Nan issue mentioned in the bug description
the issue is that if you type manually into an HTML file, after typing you'll notice is suggested. That suggestion should not happen, because we're not in an actual CSS body.
closedWith
I see this: ! Is that the issue still?
Not exactly, but I'll reopen it still.
Change:
export const AccessibleViewNextAction = registerCommand(new MultiCommand({ id: 'editor.action.accessibleViewNext', <del> precondition: undefined, </del> <ins> precondition: accessibleViewIsShown, </ins> kbOpts: { primary: KeyMod.Alt | KeyCode.BracketRight, weight: KeybindingWeight.WorkbenchContrib

Discussion:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
export const AccessibleViewPreviousAction = registerCommand(new MultiCommand({ id: 'editor.action.accessibleViewPrevious', <del> precondition: undefined, </del> <ins> precondition: accessibleViewIsShown, </ins> kbOpts: { primary: KeyMod.Alt | KeyCode.BracketLeft, weight: KeybindingWeight.WorkbenchContrib

Discussion:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
setRequestHeaders(xhr, options); xhr.responseType = 'arraybuffer'; <del> xhr.onerror = e => reject(new Error(xhr.statusText && ('XHR failed: ' + xhr.statusText))); </del> <ins> xhr.onerror = e => reject(new Error(xhr.statusText && ('XHR failed: ' + xhr.statusText) || 'XHR failed')); </ins> xhr.onload = (e) => { resolve({ res: {

Discussion:
Issue Type: <bBug</bIf you try to open the release notes while offline, then if a release notes url is configured then vscode will open it in a browser, otherwise it will do nothing, not even show an error. Later, if you go online and try opening the release notes again, the same will happen - vscode will never attempt to open the release notes webview again. This state is preserved until you reload the window. Steps to Reproduce: offline (you can also open devtools in vscode and go to the network tab and change the "online" at the top to "offline") to open the release notes using from the command palette. on whether you are on an official vscode build or a local build, the release notes page will be opened in your default browser. On a local build nothing happens. back online to open the release notes again same thing will happen the window using from the command palette to open the release notes again release notes open in a webview inside vscode VS Code version: Code - Insiders 1.47.0-insider (, 2020-06-26T06:20:06.931Z) OS version: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes
Change:
public branchCoverage?: vscode.TestCoverageCount, public declarationCoverage?: vscode.TestCoverageCount, ) { <del> validateCC(statementCoverage); validateCC(branchCoverage); validateCC(declarationCoverage); </del> } }

Discussion:
Refs: [x] anyOS [x] anyOS Complexity: 4 We have at long last finalized the test coverage API. Implementing an extension that produces data for the API from scratch is challenging, and requires domain-specific knowledge, so you might find playing with the selfhost test provider to be the most effective way to test it The new types in the API include: - - - Please: Do some testing that the API and UI functions as you would expect Read through the API and verify that its documentation makes sense to you See that UI interactions work nicely as you would expect (you can use any extension that produces coverage to test this part)