jiebi/CodeConvo huggingface dataset:
Change:
export interface ITaskService { readonly _serviceBrand: undefined; onDidStateChange: Event<ITaskEvent>; <ins> /** Fired when task providers are registered or unregistered */ onDidChangeTaskProviders: Event<void>; </ins> isReconnected: boolean; onDidReconnectToTasks: Event<void>; supportsMultipleTaskExecutions: boolean;

Discussion:
a repo in :bug: see this !
This is expected if the repo that you open has tasks that run on . Could you pls provide me with a repo for which this happens that doesn't have those?
seeing this dialog when I just open a folder, so wondering if something with workspace trust has changed recently. No changes with tasks recently could explain this. !
Doesn't repro in , repros in : Bad: Good:
found these task PRs in that time frame: ,
found it also happens in an empty window on desktop
Still seeing this in (and also RemoteHub on desktop) with the changes in !
This is coming from -here. perhaps we don't want to do that for the or only do that in trusted workspaces? !
Change:
quickPick.activeItems = activeItems; }, this); <del> const pick = await new Promise<KernelQuickPickItem | undefined>((resolve, reject) => { </del> <ins> const pick = await new Promise<{ selected: KernelQuickPickItem | undefined; items: KernelQuickPickItem[] }>((resolve, reject) => { </ins> quickPick.onDidAccept(() => { const item = quickPick.selectedItems[0]; if (item) { <del> resolve(item); </del> <ins> resolve({ selected: item, items: quickPick.items as KernelQuickPickItem[] }); </ins> } else { <del> resolve(undefined); </del> <ins> resolve({ selected: undefined, items: quickPick.items as KernelQuickPickItem[] }); </ins> } quickPick.hide();

Discussion:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !
Change:
return false; } if ((treeItemThing.iconPath !== undefined) && !isString(treeItemThing.iconPath) && !URI.isUri(treeItemThing.iconPath) && !isString((treeItemThing.iconPath as vscode.ThemeIcon).id)) { <del> console.log('INVALID tree item, invalid iconPath', treeItemThing.iconPath); return false; </del> <ins> const asLightAndDarkThing = treeItemThing.iconPath as { light: string | URI; dark: string | URI }; if (!isString(asLightAndDarkThing.light) && !URI.isUri(asLightAndDarkThing.light) && !isString(asLightAndDarkThing.dark) && !URI.isUri(asLightAndDarkThing.dark)) { console.log('INVALID tree item, invalid iconPath', treeItemThing.iconPath); return false; } </ins> } if ((treeItemThing.description !== undefined) && !isString(treeItemThing.description) && (typeof treeItemThing.description !== 'boolean')) { console.log('INVALID tree item, invalid description', treeItemThing.description);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.0 OS Version: Windows 11 22H2 Steps to Reproduce: Currently I write a vscode extension with a sidebar provider. Inside the provider I set icons in front of the tree. After I updated VSCode today I got the message inside the console: But the tree and the icons are loaded: ! Here is my source of the provider:
thank you for reporting this! I a check for malformed tree items a few weeks ago, and it looks like I made a mistake in the check. This is a harmless log message, but it is annoying. If we have a 1.70.2 release we will include the fix there.
To verify you will need to run an extension that uses a for a tree item and doesn't the tree item. An easy way to verify with this setup is the following: the vscode-extension-samples repository and open the tree-view-sample. this line to create the using instead of : the sample and open the developer tools. a json file with the running sample. that the Json Outline view works. Verify that there are no "INVALID tree item" logs in the developer console.
Verified by
Change:
async getBranch(name: string): Promise<Branch> { if (name === 'HEAD') { return this.getHEAD(); <del> } else if (/^@/.test(name)) { const symbolicFullNameResult = await this.run(['rev-parse', '--symbolic-full-name', name]); const symbolicFullName = symbolicFullNameResult.stdout.trim(); name = symbolicFullName || name; </del> } <del> const result = await this.run(['rev-parse', name]); </del> <ins> let result = await this.run(['rev-parse', name]); if (!result.stdout && /^@/.test(name)) { const symbolicFullNameResult = await this.run(['rev-parse', '--symbolic-full-name', name]); name = symbolicFullNameResult.stdout.trim(); result = await this.run(['rev-parse', name]); } </ins> if (!result.stdout) { return Promise.reject<Branch>(new Error('No such branch'));

Discussion:
VSCode Version: 1.30.1 OS Version: Windows 10 - build 1803 Steps to Reproduce: new branch "git checkout -b Code display branch like below ! on publish icon, which spins and does nothing and produces this log. To [new branch] - fatal: no such branch: 'refs/heads/ Issues: works. I can see my branch on server repo but I also get above error. After publish icon remains same. ! notifications stop working. I don't see any indication if there is any pending commit to push or pull latest changes. I think it was working fine until 1.28 or 1.29 Note: If I create branch with name like "feature1", everything works as expected. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.542 --- <!-- score: 0.484 --<!-- potentialduplicatescomment --
I have reproed this locally and tracked down the issue. receives the branch string, , as an argument, . The first thing it does it compare the branch name to 'HEAD', else tests if the name of the branch begins with an ' using the regex . In the case of the branch beginning with an ' it then replaces the name argument to the function with the symbolic full name. resolved by running . This resolves to . To then compute the rest of the branch information, the upstream/downstream changes, the code then runs which in the case of a symbolic full name branch, , fails to resolve, because the branch does not exist. The code catches the git exception, and throws which the calling code treats as if the upstream doesn't exist, hence showing the publish icon still, even though the branch DOES have an upstream and should show the sync icon. If I remove the initial regex test , the code then works correctly, in this case. This behavior was changed by in commit The simplest workaround is to not use a branch beginning with ' As for a fix, I can't see the context on why the change was made, the description says 'git: getBranch should resolve @ name syntax', but I'm not sure what '@ name syntax' is.

Reverting this commit would fix this issue, but presumably there was another issue somewhere else which warranted the change in the first place. do you have more context?
Change:
"input.background": "#FFFFFF", "input.border": "#CECECE", "input.foreground": "#3B3B3B", <del> "input.placeholderForeground": "#868686", </del> <ins> "input.placeholderForeground": "#767676", </ins> "inputOption.activeBackground": "#BED6ED", "inputOption.activeBorder": "#005FB8", "inputOption.activeForeground": "#000000",

Discussion:
]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.3; #Color Contrast; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise 22H2 Build .3007 Visual Studio Code Insiders editor ctrl+P or Tab till go and press ENTER then TAB till Go to File. that Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Similar issue is also observed throughout the application. Color contrast ratio of the "search files by name" placeholder text should be greater than or equals to 4.5:1. Low vision users will not be able to see the placeholder text if color contrast ratio will be less than 4.5:1. ! !
I can't reproduce this one. With the Dark Modern theme I see a background value for inputs of which passes the 3:1 ratio with the placeholder foreground of .
Misread that the ratio should be 4.5:1. This I can fix.
Verified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is fixed. Hence Closing the bug. please find attachment for reference. !

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: Windows 11 Enterprise (Windows_NT x64 10.0..3007) Description During an accessibility test, we found the contrast ratio between the placeholder text and the background is not high enough under "Default Dark Modern" theme. Placeholder Text Color: Background Color: Contrast Ratio: 3.339:1 Required Contrast Ratio: 4.5:1 !
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #WCAG1.4.3; #Contrast (Minimum);
Change:
const telemetry = new ExperimentServiceTelemetry(this.telemetryService); const tasConfig = this.productService.tasConfig!; <del> const tasClient = new TASClient({ </del> <ins> const tasClient = new (await import('tas-client')).ExperimentationService({ </ins> filterProviders: [filterProvider], telemetry: telemetry, storageKey: storageKey,

Discussion:
It looks like we a new dependency to which adds substantial time to our startup: ! This module should be loaded via only when used. //cc
Yeah, this is a really bulky module since it doesn't seem to be bundled in any way. Ideally, this loaded async and bundled <img width="377" alt="Screenshot 2020-08-25 at 11 09 05" src="https://user-"
On top of this discussion, we also need to think about wether this module should be supported in web and then it should be webpacked accordingly, similar to our UMD variants (, ...).
I have published the umd variant (though i messed up the typings so it needs an update), it just needs adoption.
sounds good. Loading this dependency async would be good in any case, even if you pick up the UMD variant as we avoid having to load the contents right on startup if not needed.
PR is up:
Change:
}); Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench) <del> .registerWorkbenchContribution(StartupPageContribution, LifecyclePhase.Restored); </del> <ins> .registerWorkbenchContribution(StartupPageContribution, LifecyclePhase.Starting); </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No - relates to plugin activation. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.1 (server) OS Version: Ubuntu frontend, Windows frontend Steps to Reproduce: have a plugin that uses the activation event and launches a walkthrough as part of its activation using the command . run with VSCode Server, this will occasionally cause an error like this to appear: ! It seems that what must be happening is that the plugin is executing its command before is run to register the URI handling for the special URI that . That raises a question about the activation event. I would consider startup to be finished only when all have been instantiated, but that condition doesn't seem to be enforced. The error is more frequent when the window in which the editor is running is in the background, presumably because it's allocated fewer resources and getting through fewer of the s that the application activation sequence runs through before the backend declares (unilaterally?) that startup has finished - in fact, it will just declare victory , even if the other (exclusively backend?) events it's waiting for don't complete.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks, but it doesn't appear that any changes have been made in the code in this area since 1.81, so I believe the problem still exists.
I can't repro the original issue, but verified by code review.
Reverted this change due to: Will work on this in February
Change:
padding: 0 1.8em; } <del> .linux .monaco-menu .monaco-action-bar.vertical .submenu-indicator { </del> <ins> .linux .monaco-menu .monaco-action-bar.vertical .submenu-indicator, </ins> :host-context(.linux) .monaco-menu .monaco-action-bar.vertical .submenu-indicator { height: 100%; mask-size: 10px 10px;

Discussion:
The main menu entries have a scrollbar when needed: ! The custom context menu has none, even when needed: ! Looking at the sources, I see that the menu sets it to visible though:
Oh wow, looks like they do appear in other places though, outside the editor: !
This is 100% related to the use of shadow DOM, commenting out this resolves it:
Thanks!!
Change:
} layout(widthInPixel?: number) { <del> this._body.layout(); </del> <ins> this._body.layout(widthInPixel); </ins> if (widthInPixel !== undefined) { this._commentReply?.layout(widthInPixel);

Discussion:
I have created a vscode extension which uses the comment thread and the comment thread width is too small after the update. This was working fine in version 1.79, here's a screenshot of the bug. <img width="1259" alt="Screenshot 2023-11-09 at 8 51 25 AM" src=""
Why are you still on 1.81 when the current release is 1.84.1?
sorry,I meant 1.84.1 I typed incorrectly.
I'm not able to reproduce this. Are there any more steps you took to arrive in this state?
create a comment thread in ur extension as shown below.
use the below code to create a comment thread in ur extension, edit the code to give dummy comments instead of reading it from a file. make sure the comment thread is Collapsed and in Edit mode.
This is the key. I can repo.
Change:
hcLight: Color.black.transparent(0.12) }, localize('statusBarItemHoverBackground', "Status bar item background color when hovering. The status bar is shown in the bottom of the window.")); <ins> export const STATUS_BAR_ITEM_HOVER_FOREGROUND = registerColor('statusBarItem.hoverForeground', { dark: STATUS_BAR_FOREGROUND, light: STATUS_BAR_FOREGROUND, hcDark: STATUS_BAR_FOREGROUND, hcLight: STATUS_BAR_FOREGROUND }, localize('statusBarItemHoverForeground', "Status bar item foreground color when hovering. The status bar is shown in the bottom of the window.")); </ins> export const STATUS_BAR_ITEM_COMPACT_HOVER_BACKGROUND = registerColor('statusBarItem.compactHoverBackground', { dark: Color.white.transparent(0.20), light: Color.white.transparent(0.20),

Discussion:
Hi. i am creating a theme pack for VSCode. I have discovered that there is a to customize the background color of a status bar hovered item but there is no option to customize the color of the hovered item foreground color. Something like !
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Yeah there seems to be colors like but not the relevant foreground colors. //cc
Added with values defaulting to in . You'll be able to set that manually in your or in the theme itself.
nice, but we do have more hover backgrounds: <img width="725" alt="image" src=""I am not sure about the compact one but maybe prominent one needs it too?
Added via
Change:
onDidChangeNotebookEditorVisibleRanges(listener, thisArgs?, disposables?) { return extHostNotebookEditors.onDidChangeNotebookEditorVisibleRanges(listener, thisArgs, disposables); }, <del> showNotebookDocument(uriOrDocument, options?) { if (URI.isUri(uriOrDocument)) { extHostApiDeprecation.report('window.showNotebookDocument(uri)', extension, `Please use 'workspace.openNotebookDocument' and 'window.showNotebookDocument'`); } return extHostNotebook.showNotebookDocument(uriOrDocument, options); </del> <ins> showNotebookDocument(document, options?) { return extHostNotebook.showNotebookDocument(document, options); </ins> }, registerExternalUriOpener(id: string, opener: vscode.ExternalUriOpener, metadata: vscode.ExternalUriOpenerMetadata) { checkProposedApiEnabled(extension, 'externalUriOpener');

Discussion:
The has been finalized with VS Code 1.68 (). If your extension was using the proposal, you should now switch to the finalized version of this API. In the majority of cases, this switch is as simple as: your extension to target VS Code in the new from your list of enabled API proposal. However there are few small bumps to be aware of: has been renamed . Please make sure to switch over to the new property name as part of this migrationWe did not finalize the version of that takes a uri. Instead you can use Here's a list of all current consumers of the old API proposal: [x] ms-vsliveshare.vsliveshare — [X] ms- — [x] Dot net interactive — [x] GitHub.codespaces — [x] ms- — If you own one of these extensions, please migrate to the finalized notebook editor API. Let me know once the new version of your extension is published and I will remove your extension from the list of api consumers
I am actually fine in ESLint. The dependency was because of notebook support in LSP and LSP already converted to the final version for the 8.x release of the LSP libs.
Thank you everyone who's checked off their extension so far! If you have, I plan to remove your extension from the list of API consumers in July. This will only start effecting the insiders builds of VS Code at first, but please let me know if you notice any issues
I'm working on the change for Codespaces and expect it to be in our next extension release (1.10.0) in a few days. I'll reply back once it's on the marketplace.
We just published GitHub Codespaces 1.10.0 with this change, so you should be able to remove our extension from the list of proposed API consumers.
Change:
{ hideInput: true, canPickMany: false, <del> title: localize('create profile title', "{0}: Create...", PROFILES_CATEGORY.value) </del> <ins> title: localize('create profile title', "Create Profile...") </ins> }); if (pick) { if (pick.id) {

Discussion:
VS Code Version: 1.78 Insiders OS Version: Windows 11 Steps to Reproduce: at the Create Profiles drop down. ! "Create" and "Profile" shown 10 times. Suggestion to remove most instances of "Create" and "Profile". Maybe:
I like this suggestion. what do you think?
<img width="630" alt="image" src="https://user-"Do you think word is a repetition? Is this good or shall I add word to template entries too?
Looks good! I think that is just the right number of "Profile" words since "Empty Profile", "Current Profile", and "Profile Template" are "things" we talk about elsewhere. The profile template list looks clear to me
I also like this! Great improvement.
Change:
"category": "Git" }, { <ins> "command": "git.commitAllAmend", "title": "%command.commitAllAmend%", "category": "Git" }, { </ins> "command": "git.undoCommit", "title": "%command.undoCommit%", "category": "Git"

Discussion:
Like: git commit --amend
Are you referring to the out of the box git behavior or any particular git extension?
I would guess the out of the box behaviour, because it seems to be missing? I can see there is an "undo last commit", but this unstages everything from the last commit, which is not the same thing as amending the current commit. git-gui and atom have a simple checkbox which then amends the current commit instead of creating a new one - would it be possible to have the same in vscode? It's the one thing that stops me using vscode's built in git interface. In other words, you should be able to check and then uncheck the checkbox and be left in the original state. With the "undo last commit", this isn't possible.
Yes, out of the box
command was some time ago by
Should there be something in the menu? Please can you tell me where the option is?
Hmmm.... looks like it has disappeared for some reason, probably was omitted when git integration was ported to new API... will probably know if it was by-design, or just someone missed one command while porting git integration.
I believe we simply missed it... sorry for that.
I'll add it again.
Change:
this._onDidChangeHeight.fire(); })); <ins> this._store.add(this.chatWidget.onDidChangeContentHeight(() => { this._onDidChangeHeight.fire(); })); </ins> // context keys this._ctxResponseFocused = CTX_INLINE_CHAT_RESPONSE_FOCUSED.bindTo(this._contextKeyService);

Discussion:
Repro: in inline chat: !
Oh it's a scroll shadow: !
We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on , where the community has already answered thousands of similar questions. You may find their helpful if your question has not already been asked. See also our . Happy Coding!
I blame it your theme. Inline chat isn't doing anything special here, tho we might wanna tweak the min size
The problem here is that the height of the chat widget inside the inline chat isn't correct and doesn't seem to be updated when the answer is streamed in. There is much more than 40% room available so it should show the full response. Also this is Dark Modern; the theme is fine it's the size: !
That's surprising. Notice how it works here until it reaches the max zone height
Must be related to the code block being replied with. But whatever I do I cannot get it to reply like that...
Ok, I can repro in a TS file with . Looks like the tree reports the wrong content height. Overall we measure 94px (for the input and tree) when in fact only the tree is 107px <img width="1272" alt="Screenshot 2024-03-22 at 16 37 16" src=""
Is editor rendering somehow async and should I ask for content height at some later point?