jiebi/CodeConvo huggingface dataset:
Change:
display: none; } <ins> .monaco-workbench .inline-chat-content-widget.interactive-session .interactive-session { max-width: unset; } </ins> .monaco-workbench .inline-chat-content-widget.interactive-session .interactive-input-part .interactive-execute-toolbar { margin-bottom: 1px; }

Discussion:
Repro: vscode on (wide) external monitor inline chat - Additional info: Resizing vscode to half of screen fixes the problem Version: 1.88.0-insider Commit: Date: 2024-03-27T05:51:26.826Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.4.0

Sometimes the default width for inline chat seems very wide: <img width="854" alt="image" src=""Maybe it could grow while typing and or allow to be resized.
decided against dynamic and going with a more reasonable default width of 360px
Change:
override async run(): Promise<void> { if (this.extension) { <del> await this.action.run(this.extension.local ? getExtensionId(this.extension.local.manifest.publisher, this.extension.local.manifest.name) </del> <ins> const id = this.extension.local ? getExtensionId(this.extension.local.manifest.publisher, this.extension.local.manifest.name) </ins> : this.extension.gallery ? getExtensionId(this.extension.gallery.publisher, this.extension.gallery.name) <del> : this.extension.identifier.id); </del> <ins> : this.extension.identifier.id; const extensionArg: IExtensionArg = { id: this.extension.identifier.id, version: this.extension.version, location: this.extension.local?.location }; await this.action.run(id, extensionArg); </ins> } } }

Discussion:
For reference: I have found some peculiar things with the implementation, which I am not sure is by design or not. But here comes one: When working with remotes, such as remote ssh, I can see an extension in the "local" windows (greyed out) and in the remote window (not greyed out) in case it prefers to run on the remote extension host. But when I right-click on the local extension and select "Apply Extension to all Profiles" it does nothing. If I click it in the remote extension window and do the same, it gets the check mark. (But still not in the local window). As I suspect the intention behind "Apply Extension to all Profiles" is to actually apply it to all profiles, I should be able to right click and select it, so it gets selected, in all views under "Extensions". ( was also something I found needed.)
Thanks for the feedback. First request is a valid request. Can you please give more details about the second request? I would suggest to extract it into a new issue and provide exact steps to reproduce the issue.
I broke up the second item to a new issue: Let me know if still is not clear enough, and possibly which part.
is this an easy fix? I think it will clear up some confusion. I am surprised more people have not noticed and upvoted this, as local team members found this by themselves. It is causing quite a bit of confusion UX wise.
To verify: Open a remote window (WSL or Dev Container or SSH) Have an extension installed locally and remotely In Local Installed Extensions Section, Right click on the extension and apply it to all profiles. Verify that it also applies for the extension is remote installed extensions section. Verify vice-versa
Change:
outline: 0 !important; } <del> .action-widget .monaco-list .monaco-scrollable-element .monaco-list-rows { height: 100% !important; } </del> .action-widget .monaco-list .monaco-scrollable-element { overflow: visible; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Helo! I use the code spell checker extension which provides quick fixes for spelling "error"s. Often these are just terms that I've adopted as standard in the repo and don't aim to change. However, with the recent change to use custom context menus instead of the native ones the list of spelling quick fixes causes the refactorings I actually want to use to be out of the window, with no way to scroll them into view. With spell checker extension enabled: <img width="590" alt="image" src="https://user-"Without: <img width="610" alt="image" src="https://user-"Ideally the menu would support scroll. I'd accept an option to use native menus instead (the icons are nice to have but not critical). Alternatively, at minimum perhaps the refactorings could be sorted above quick fixes?
We should also limit the height of the menu. Not very pleasant to have it take up the entire height of the window
Works great, thanks!
Change:
const ext = gallery[i]; if (!installedExtensions.has(ext.identifier.id) && !this._marketplaceExtensions.has(ext.identifier.id)) { this._marketplaceExtensions.add(ext.identifier.id); <del> const themes = await this.getMarketplaceColorThemes(ext.publisher, ext.name, ext.version); for (const theme of themes) { this._marketplaceThemes.push({ id: theme.id, theme: theme, label: theme.label, description: `${ext.displayName} · ${ext.publisherDisplayName}`, galleryExtension: ext, buttons: [configureButton] }); } </del> <ins> promises.push(this.getMarketplaceColorThemes(ext.publisher, ext.name, ext.version)); promisesGalleries.push(ext); } } const allThemes = await Promise.all(promises); for (let i = 0; i < allThemes.length; i++) { const ext = promisesGalleries[i]; for (const theme of allThemes[i]) { this._marketplaceThemes.push({ id: theme.id, theme: theme, label: theme.label, description: `${ext.displayName} · ${ext.publisherDisplayName}`, galleryExtension: ext, buttons: [configureButton] }); </ins> } } if (nThemes !== this._marketplaceThemes.length) { this._marketplaceThemes.sort((t1, t2) => t1.label.localeCompare(t2.label)); this._onDidChange.fire();

Discussion:
Open the color theme picker and select the first option () Observe that it takes around 5 seconds for the results to show. This used to be much snappier
Change:
) { chain(urlService.onOpenURL) .filter(uri => uri.authority === 'file' && !!uri.path) <del> .map(uri => uri.path) </del> <ins> .map(uri => this.parseURIForOpen(uri)) </ins> .on(this.openFileForURI, this, this.disposables); }

Discussion:
VSCode Version: 1.9.1 OS Version: Windows 10 Enterprise .693 Steps to Reproduce: VS Code a folder D:/Temp the following URL: vscode://file/d/temp/ Expected result: VS Code launches and opens folder D:/Temp Actual result: VS Code launches and says that folder /d/temp does not exist
I guess this is related to the windows CLI?
Want to ?
Thanks for the fix But actually went ahead with a simpler solution on top of yours. Instead of manipulating the strings we should just explicitly require the colon to be in the URI. So here's how URIs would work for Code: This works correctly now in .
Change:
import { localize } from 'vs/nls'; export interface ITranslations { <del> [key: string]: string | { message: string; comment: string[] }; </del> <ins> [key: string]: string | { message: string; comment: string[] } | undefined; </ins> } export function localizeManifest(extensionManifest: IExtensionManifest, translations: ITranslations, fallbackTranslations?: ITranslations): IExtensionManifest { try { replaceNLStrings(extensionManifest, translations, fallbackTranslations); } catch (error) { <ins> console.error(error?.message ?? error); </ins> /*Ignore Error*/ } return extensionManifest;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.72.2 (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: for example. Have an entry in for a command but misspell the part: of the other localizations load: ! Issue observed in Python extension: and Jupyter: cc/
Change:
if (this._hoverPosition === HoverPosition.RIGHT) { const roomOnRight = this._targetDocumentElement.clientWidth - target.right; // Hover on the right is going beyond window. <del> if (roomOnRight < this._hover.containerDomNode.clientWidth) { </del> <ins> if (roomOnRight < this._hover.containerDomNode.clientWidth + hoverPointerOffset) { </ins> const roomOnLeft = target.left; // There's enough room on the left, flip the hover position <del> if (roomOnLeft >= this._hover.containerDomNode.clientWidth) { </del> <ins> if (roomOnLeft >= this._hover.containerDomNode.clientWidth + hoverPointerOffset) { </ins> this._hoverPosition = HoverPosition.LEFT; } // Hover on the left would go beyond window too

Discussion:
a project with some kind of debugging and make sure the Breakpoints view is near the bottom of the screen over the pencil icon on the second-to-bottom list item. It works over the bottom list icon. The tooltip seems to appear and disappear very quickly causing the mouse to flicker (the FPS on the gif doesn't capture it very well but you can see that it doesn't render correctly) !
cc , this might have always been a bug but is probably now more exposed given its a custom hover now.
I haven't made any changes to the computation of where the hover should be placed in relation to the target, so a bug that we have had for a while, but should definitely look into. After testing a bit it seems to me that this only happens for ().
This also definitely used to work on language features and recently regressed (works fine in 1.87 stable): ! Reported the styling problem in
Change:
# TODO: Gracefully fallback when PSReadLine is not loaded function Global:PSConsoleHostReadLine { <del> [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine($Host.Runspace, $ExecutionContext) </del> <ins> $lastRunStatus = $? Microsoft.PowerShell.CoreSet-StrictMode -Off $tmp = [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine($host.Runspace, $ExecutionContext, $lastRunStatus) </ins> # Write command executed sequence directly to Console to avoid the new line from Write-Host <del> [Console]::Write("`e]133;C`u{7}") </del> <ins> [Console]::Write("`e]133;C`a") return $tmp </ins> } # Set IsWindows property

Discussion:
VS Code Version: 1.64.0 OS Version: Windows 10 x64 21H1 (Build ) to the shell (pwsh v7.2) My existing PowerShell is setup with module It would look like the following (with listview of history) ! When is configured/enabled and restarted the shell, this is how it looks like ! The history does not show up I do have other modules installed such as and from the looks of it, it seems to be working fine since the theme is showing correctly as before Not sure if any other modules are affected as well
this function should be:
Had to revert, see
! looks fixed to me
Change:
return TPromise.as(this.terminalService.hideFindWidget()); } } <ins> export class QuickOpenActionTermContributor extends ActionBarContributor { constructor( @ITerminalService private terminalService: ITerminalService, @IQuickOpenService private quickOpenService: IQuickOpenService, @IInstantiationService private instantiationService: IInstantiationService ) { super(); } public getActions(context: any): IAction[] { let actions: Action[] = []; if (context.element instanceof TerminalEntry) { actions.push(this.instantiationService.createInstance(RenameTerminalQuickOpenAction, RenameTerminalQuickOpenAction.ID, RenameTerminalQuickOpenAction.LABEL, context.element)); } return actions; } public hasActions(context: any): boolean { return true; } } export class QuickOpenTermAction extends Action { public static ID = 'workbench.action.quickOpenTerm'; public static LABEL = nls.localize('quickOpenTerm', "Switch active terminal"); constructor( id: string, label: string, @IQuickOpenService private quickOpenService: IQuickOpenService ) { super(id, label); } public run(): TPromise<void> { return this.quickOpenService.show(TERMINAL_PICKER_PREFIX, null); } } export class RenameTerminalQuickOpenAction extends RenameTerminalAction { constructor( id: string, label: string, private terminal: TerminalEntry, @IQuickOpenService quickOpenService: IQuickOpenService, @ITerminalService terminalService: ITerminalService, @IInstantiationService private instantiationService: IInstantiationService ) { super(id, label, quickOpenService, terminalService); this.class = 'quick-open-terminal-configure'; } public run(): TPromise<any> { super.run(this.terminal) // This timeout is needed to make sure the previous quickOpen has time to close before we show the next one .then(() => TPromise.timeout(50)) .then(result => this.quickOpenService.show(TERMINAL_PICKER_PREFIX, null)); return TPromise.as(null); } } </ins>  No newline at end of file

Discussion:
Needs one for some keybindings
Also should add a rename terminal button to each entry for easy discoverability
Change:
import { CommandsRegistry } from 'vs/platform/commands/common/commands'; import { Table } from 'vs/base/browser/ui/table/tableWidget'; import { AbstractTree, TreeFindMatchType, TreeFindMode } from 'vs/base/browser/ui/tree/abstractTree'; <del> import { isActiveElement } from 'vs/base/browser/dom'; </del> <ins> import { EventType, getActiveWindow, isActiveElement } from 'vs/base/browser/dom'; </ins> import { Action2, registerAction2 } from 'vs/platform/actions/common/actions'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { localize, localize2 } from 'vs/nls'; <ins> import { IDisposable } from 'vs/base/common/lifecycle'; </ins> function ensureDOMFocus(widget: ListWidget | undefined): void { // it can happen that one of the commands is executed while

Discussion:
macOS, VS Code Insiders into explorer focus via keyboard hover does not show. There is no command to trigger the custom hover to show Like the activity bar, we have to make sure that the custom hover can be accessed in the tree/list only with the keyboard.
Would you suggest adding a keybinding to toggle the visibility of the custom hover of the html element which has focus?
Yeah, ideally it is . The same shortcut that we use in the editor for showing the hover. So it is consistent and easy for user to understand that there is one shortcut which does the right thing everywhere.
Isn't this a duplicate of ? Btw we seem to be having this support for extension provided trees at least:
I think it's good to have this one separate to .
Solving this for all trees/lists is pretty hard as the tree/list does not know anything about the underlying elements being rendered. For extension trees it is much easier as they all consist of a label which the creates and controls.
One option could be to utilize the to get the tooltip. Currently it already provides
After further discussions we came to the conclusion that we would use the DOM tree to figure out if there is any custom hovers available and trigger the hover by dispatching a mouse event on the HTMLElement. This might seem rather hacky but it ensures the consumers of the tree only have to support hover once and lets the tree handle keyboard triggers. Handling focus is still tricky and a open problem. Until this focus problem is properly fixed the treeview will keep it's own implementation which directly uses the hover service and moves the focus into the hover. The treeview implementation of this has it's own flaws but will b kept for the meantime to not cause regressions.
Change:
// Never attempt to update import paths if the file does not contain something the looks like an export const tree = await this.client.execute('navtree', { file: newFile }); const hasExport = (node: Proto.NavigationTree): boolean => { <del> return !!node.kindModifiers.match(/bexportb/g) || !!(node.childItems && node.childItems.some(hasExport)); </del> <ins> return !!node.kindModifiers.match(/bexports?b/g) || !!(node.childItems && node.childItems.some(hasExport)); </ins> }; if (!tree.body || !tree.body || !hasExport(tree.body)) { return;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --Hi folks First of all thank you for your hard work. Each month I'm amazed how Code is becoming an unique awesome piece of software I'm opening a ticket because I encounter an issue with "update path on file move" refactoring. Here's are information about it : <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.25.0 OS Version: MacOS 10.13.4 Steps to Reproduce: to move file from folder1 to another folder or to the root if the require path in is updated <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes If I can do something to help, don't hesitate to ask me. Thank you
This issue was moved to Microsoft/TypeScript
Change:
case ProtocolMessageType.ReplayRequest: return 'ReplayRequest'; case ProtocolMessageType.Pause: return 'PauseWriting'; case ProtocolMessageType.Resume: return 'ResumeWriting'; <ins> case ProtocolMessageType.KeepAlive: return 'KeepAlive'; </ins> } }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Background: Modern reverse proxies like nginx or cloudflare use timeouts for dormant websocket connections. For nginx this defaults to 60s and for Cloudflare to 100s. In case of Cloudflare, this is not configurable for non-enterpise users. Due to the fixes in , the management connection is now typically being idle for extended periods of time. If the web-socket connection is being terminated by the reverse proxy, even if it can be reestablished immediately, a modal dialog is being shown, which disturbs the user immensely. For reference see In order to support Cloudflare it is essential, that we either implement a keep-alive ping (my proposal would by every 45s by default), or alternatively, make it so an immediate reconnect does not cause any negative consequences for the user.
any insights here?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Version: 1.71.0-insider Commit: Date: 2022-08-26T23:24:52.456Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36 /verified I do no longer experience regular reconnects every 100 seconds behind cloudflare with the build above.
Change:
const maxPanelHeight = sidebarSize.height - MIN_EDITOR_PART_HEIGHT; if (isPanelHidden) { panelHeight = 0; <ins> } else if (this.panelHeight === previousMaxPanelHeight) { panelHeight = maxPanelHeight; </ins> } else if (this.panelHeight > 0) { panelHeight = Math.min(maxPanelHeight, Math.max(this.partLayoutInfo.panel.minHeight, this.panelHeight)); } else {

Discussion:
Steps to Reproduce: panel, maximizes the panel out, the panel is no longer maximized but still much larger than usual panel, maximizes the panel
Fixed by
Change:
import { ModelDecorationMinimapOptions } from 'vs/editor/common/model/textModel'; import { Selection } from 'vs/editor/common/core/selection'; import { Color } from 'vs/base/common/color'; <ins> import { GestureEvent, EventType, Gesture } from 'vs/base/browser/touch'; </ins> function getMinimapLineHeight(renderMinimap: RenderMinimap): number { if (renderMinimap === RenderMinimap.Large) {

Discussion:
Issue Type: <bFeature Request</bWhen using a touch screen, I want to be able to interact with VSCode in an intuitive manner. When I touch the minimap, I expect the document to scroll immediately on touch-down, not on touch-up. Mouse-up makes sense for a mouse, but not for a touch. When I touch and drag the minimap, I expect the minimap to scroll with my finger. VS Code version: Code 1.22.1 (, 2018-04-06T02:26:57.615Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.487 --- <!-- score: 0.464 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --
I haven't PR'd vscode before, if anyone who cares about this issue has tips on getting my PR ^^ merged and released I'm happy to put more work into it. I find it very frustrating not having touch-scrolling on the minimap, as I'm so used to it working in old-school Visual Studio!
Change:
public static readonly variable = 'var'; public static readonly warning = 'warning'; } <ins> export class DiagnosticCategory { public static readonly error = 'error'; public static readonly warning = 'warning'; } </ins>  No newline at end of file

Discussion:
The video below demonstrates tslint running as a language server plugin. Notice that the tslint warnings show up as errors. However, in the code the DiagnosticCategory is set to . ! This is the code that creates the diagnostic
Looks like we don't set a severity on the diagnostics which causes them to all be marked as errors. Looking into fixing this
Hmm, I don't see a field on normal objects in the TSServer protocol, only on . Let me see if this field is sent anyways when you explicitly set in the TSLint plugin
I've opened to track adding to the objects that tsserver returns to us. This seems like an oversight in the current protocol