jiebi/CodeConvo huggingface dataset:
Change:
"dependencies": { "highlight.js": "9.15.10", "markdown-it": "^10.0.0", <del> "markdown-it-front-matter": "^0.1.2", </del> <ins> "markdown-it-front-matter": "^0.2.1", </ins> "vscode-extension-telemetry": "0.1.1", "vscode-nls": "^4.0.0" },

Discussion:
Issue Type: <bBug</bThe outline view showing markdown chapters and subchapters does not show anything if the document yaml frontmatter ends in "...". This works: title: My title # My chapter But this doesn't (the outline does not show anything): title: My title ... # My chapter VS Code version: Code 1.32.2 (, 2019-03-13T02:00:46.035Z) OS version: WindowsNT x64 6.1.7601 <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ markdown-checkbox0.1.1 vscode-markdownlint0.25.0 vscode-pandoc0.0.8 gitlens9.5.1 language-haskell2.5.0 rainbow-csv1.0.0 Go0.9.2 vscode-docker0.6.0 material-icon-theme3.6.3 qub-xml1.2.1 markdown-preview-enhanced0.3.12 vscode-table-formatter1.2.1 vscode-mermaid-preview0.11.1 </details<!-- generated by issue reporter --
I just want to add that the preview is not generated too. I opened a bug report against an , but seems it uses the vscode services. Version: 1.32.3 (user setup) Commit: Date: 2019-03-14T23:43:35.476Z Electron: 3.1.6 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.
To help with this, please look into fixing this upstream:
For fixing this issue, I need to implement this in . And update dependency in , correct?
And updating example on
Yes, that is correct
Ummm it seems isn't maintained anymore... () When like this situation, how can we do?
Let's give it a few more days and see if they respond. Otherwise, we can fork the repo and take your PR into the fork
Change:
value?: string; /** <ins> * Whether to preselect the given `value` when the box is first shown. */ noValuePreselect?: boolean; /** </ins> * The text to display underneath the input box. */ prompt?: string;

Discussion:
VSCode Version: 1.5.0-insider OS Version: Windows 10 Steps to Reproduce: value is highlighted/selected Currently we can't put the cursor at the end of the default value when running . In this case, users have to move the cursor manually if we want to keep the default value as prefix always.
That's actually indented use case since the user is likely to accept <kbdEnter</kbdor over write the pre-set value. What is your use-case for this?
This features originally comes from implementing Vim's Ex commands, which support line range as a prefix like represents and represents . When users trigger Ex command by , Vim will help fulfill the line range prefix automatically and then users can type commands directly, eg for replacement. If users don't like the line range Vim puts there automatically, they need to use to delete the range characters. Vim doesn't select those characters it auto-completes but Code does, so I'm asking if it's possible to add this support to .
It would also help if a selection range could be defined. In my case I would like set the whole file path as value but only select the file base name. e.g. /path/to/file/ Users most likely will only change the but should also have the possibility to change the path.
Concurring to what said. I have an open question on Stack overflow:
+1 to this, it is very counterintuitive to do visual block find/replaces with VSCodeVim as noted in the above mentioned issues with this default behavior. If it were configurable like makes it, that would be useful for better emulating vim-style editing for VSCodeVim users like myself!
Change:
} const rating = Math.round(this.extension.rating * 2) / 2; <ins> this.container.title = localize('ratedLabel', "Average rating: {0} out of 5", rating); </ins> if (this.small) { append(this.container, $('span' + ThemeIcon.asCSSSelector(starFullIcon)));

Discussion:
A11yMAS; #A11ySev1; #A11yTCS; #DesktopApp; #BM-PowerShellCore-MAC-Jan21; #PowerShell Core; #MAS1.3.1; #MAC; #AINotInScope; #Info and Relationships; #Voiceover; #Element: Button; #ScreenReader; #Benchmark. Application Name: Visual Studio Code Version: 1.66.2(user setup) PowerShell Verion: v2022.5.0 MAC Version: macOS Monterey 12.2.1 Voiceover with using shortcut key Command+F5. VS Code Space Insiders VS Code Space insiders till Extension in the left navigation and press enter till Search Extensions in Marketplace and type PowerShell and press enter till Rating information check whether Voiceover is reading the rating information such as 4 stars rated for PowerShell or not Voiceover is not announcing about "rating" information about the PowerShell. Voiceover should be announcing about "Rating" information about the PowerShell for the users to understand how much PowerShell is rated !
The rating element should have an aria-label which has the rating in it, so the user can hear the rating. should be pretty straight forward, feel free to assign back to me if you would like me to push this.
Issue is fixed. Adding #Closed; tag.
Change:
import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; import { SnippetParser } from 'vs/editor/contrib/snippet/browser/snippetParser'; import { MainThreadDocuments } from 'vs/workbench/api/browser/mainThreadDocuments'; <ins> import { ISnippetEdit } from 'vs/editor/contrib/snippet/browser/snippetSession'; </ins> export interface IFocusTracker { onGainedFocus(): void;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: MacOS Ventura 13.0 Steps to Reproduce: an extension that adds a command, calling . The call should provide a range to be replaced. e.g. a range selection and then call the snippet-inserting command that change selection is now with the parts that have previously been replaced, instead of the selection pre-insertSnippet
Change:
private createList(listContainer: HTMLElement, options: IChatListItemRendererOptions): void { const scopedInstantiationService = this.instantiationService.createChild(new ServiceCollection([IContextKeyService, this.contextKeyService])); <del> const delegate = scopedInstantiationService.createInstance(ChatListDelegate); </del> <ins> const delegate = scopedInstantiationService.createInstance(ChatListDelegate, this.viewOptions.defaultElementHeight ?? 200); </ins> const rendererDelegate: IChatRendererDelegate = { getListLength: () => this.tree.getNode(null).visibleChildrenCount, onDidScroll: this.onDidScroll,

Discussion:
See how the padding is ~double that on top than on the side ! It looks particularly bad imo when a response is in progress: ! It's also ~half on bottom: ! Could we make the padding consistent on all sides?
Padding also looks pretty bad in terminal: !
When showing a result the chat widget height is off by 3px, e.g its reported content height is small then the height takes... <img width="1411" alt="Screenshot 2024-03-22 at 16 22 35" src=""
Should be looking better now <img width="1277" alt="Screenshot 2024-03-26 at 20 58 39" src=""
Much better Does it look wrong with this part gone too? !
Yeah, I had played with that and wasn't happy. The different radii (from the input and zone) get close enough to make it look weird. Also, the focus border makes it appear as too narrow
Change:
} } <ins> // The user might have added, removed, or modified a language filter, // so we reset the default value source to the non-language-specific default value source for now. this.defaultValueSource = this.setting.nonLanguageSpecificDefaultValueSource; </ins> if (inspected.policyValue) { this.hasPolicyValue = true; isConfigured = false; // The user did not manually configure the setting themselves.

Discussion:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.
Change:
"default": true, "description": "%config.terminalAuthentication%" }, <ins> "git.defaultStashMessage": { "type": "boolean", "scope": "resource", "default": false, "description": "%config.defaultStashMessage%" }, </ins> "git.githubAuthentication": { "deprecationMessage": "This setting is now deprecated, please use `github.gitAuthentication` instead." },

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Current Behavior: I have staged changes and typed a commit message. I choose Stash Stash I am prompted to enter a stash description Desired Behavior: If commit message is entered, automatically use it as the stash description instead of prompting.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.767 --- <!-- score: 0.663 --- <!-- score: 0.586 --- <!-- score: 0.559 --- <!-- score: 0.54 --<!-- potentialduplicatescomment --
Is this issue available to work on?
perhaps the simplest implementation is just to default the stash description prompt to the commit message?
! doesn't work for me
Sorry for the hassle but we decided to go and put this behind a setting instead: .
A little overkill if you ask me. But it works
I know... explanation is here: I guess the PR author didn't want to go with option 2 ;)
Change:
} private onScreenReaderModeChange(): void { <del> // We only support text based editors const screenReaderDetected = this._accessibilityService.isScreenReaderOptimized(); if (screenReaderDetected) { const screenReaderConfiguration = this.configurationService.getValue('editor.accessibilitySupport'); if (screenReaderConfiguration === 'auto') { if (!this.promptedScreenReader) { this.promptedScreenReader = true; setTimeout(() => this.showScreenReaderNotification(), 100); } } } if (this.screenReaderNotification) { this.screenReaderNotification.close(); } </del> this.updateScreenReaderModeElement(this._accessibilityService.isScreenReaderOptimized()); } }

Discussion:
We should not prompt IMO anymore since we detect the screen reader.
let's discuss this on Monday
I like the idea, but I suggest that we leave the prompt for at least one more milestone. After that, we can compare the number of accessibility users we have after changes and see how precise the detection is. We might also see that the detection is more precise on some platforms, in which case we can leave the prompt only for some platforms. Does that make sense? What do you think? fyi who introduced the prompt initially
Safe to remove now?
I suggest to leave it on for at least one more milestone since our accessibility detection got off. I will assign it to March for now. Hope that is ok.
Thanks for fixing this. I just assigned to October and verification-needed. I think the verify steps are the following: On Windows turn on NVDA VS Code insiders (have no settings set). an editor, type some text sure NVDA reads this text as you navigate through it character by character Same on macOS with VoiceOver.
I haven't heard user complaints, so let's just keep this
Change:
default: typeof product.quality === 'string' && product.quality !== 'stable' // only enable as default in insiders }, [NotebookSetting.scrollToRevealCell]: { <del> markdownDescription: nls.localize('notebook.scrolling.revealCellBehavior.description', "How far to scroll when revealing the selected, e.g. when exectuting {0}.", 'notebook.cell.executeAndSelectBelow'), </del> <ins> markdownDescription: nls.localize('notebook.scrolling.revealNextCellOnExecute.description', "How far to scroll when revealing the next cell upon running {0}.", 'notebook.cell.executeAndSelectBelow'), </ins> type: 'string', enum: ['fullCell', 'firstLine', 'none'], markdownEnumDescriptions: [ <del> nls.localize('notebook.scrolling.revealCellBehavior.fullCell.description', 'Scroll to fully reveal the selected cell.'), nls.localize('notebook.scrolling.revealCellBehavior.firstLine.description', 'Scroll to reveal the first line of the selected cell.'), nls.localize('notebook.scrolling.revealCellBehavior.nonedescription', 'Do not scroll to reveal the selected cell.'), </del> <ins> nls.localize('notebook.scrolling.revealNextCellOnExecute.fullCell.description', 'Scroll to fully reveal the next cell.'), nls.localize('notebook.scrolling.revealNextCellOnExecute.firstLine.description', 'Scroll to reveal the first line of the next cell.'), nls.localize('notebook.scrolling.revealNextCellOnExecute.none.description', 'Do not scroll.'), </ins> ], default: 'fullCell' },

Discussion:
Testing The setting description is as follows: I'm not sure what the exhaustive list of actions is, but if it's only on execution the name should include that. For example this does not control revealing when navigating by symbol which always reveals the cell in the center. !

Testing ! Also the use of e.g. there doesn't flow nicely to me. it would be better to spell out imo
Change:
} private refresh(): void { <del> this.enabled = workspace.getConfiguration('git', null).get('githubAuthentication', true); </del> <ins> const config = workspace.getConfiguration('git', null); this.enabled = config.get<boolean>('enabled', true) && config.get('githubAuthentication', true); </ins> } dispose(): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.0 OS Version: Ubuntu 19.10 Steps to Reproduce: add: { "git.enabled": false, "git.terminalAuthentication": false, "git.githubAuthentication": false, } to push from the integrated terminal <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Error text: Missing or invalid credentials. Error: connect ENOENT at PipeConnectWrap.afterConnect [as oncomplete] () { errno: 'ENOENT', code: 'ENOENT', syscall: 'connect', address: '' }
Did you restart the terminal after your disabled it?
Yes, I've both killed the terminal and restarted the VM. Not sure if this is helpful, but before I the two new settings vscode was trying to handle the authentication even though I had set (requesting username and password from the command palette). That's what sent me looking for the new settings in the first place.
Change:
export interface FileWillRenameEvent { /** <ins> * A cancellation token. */ readonly token: CancellationToken; /** </ins> * The files that are going to be renamed. */ readonly files: ReadonlyArray<{ readonly oldUri: Uri, readonly newUri: Uri }>;

Discussion:
continues Timeout and user-cancellation applies when calling -events. However, we don't expose that in the API and silently stop async-event delivery and ignore results. We could let extension know via
For some big repo, it is possible for LS to parse more then hundreds files (which takes long time), right now, this can't be cancelled since we (LS) don't get any cancellation token (hence, no cancellation request). vscode side acts like it is cancelled, but only front end (vscode) is cancelled, all the backends (LSP and LS) that are actually doing the work are not cancelled. so even if vscode code send new requests (since vscode side is cancelled), LSP/LS won't be able to respond (not all LS is designed to process concurrent requests especially requests that have potential to change LS states). so only front end cancellation won't help much overall experiences.
fyi - this is now a thing and ready for LSP adoption
Neat, thanks
I verified that the token is available on the events, but it wasn't clear to me how to cause a user cancellation of the save/rename/delete. Can this only be done if there's slow file system provider?
You can call of the event with a promise that never or slowly resolves. Eventually the UI shows a progress notification which allows to cancel. That cancel will propagate to the extension.
I have now also verified that the token properly reflects the cancel status.
Thanks!
Change:
`script-src 'self' 'unsafe-eval' ${this._getScriptCspHashes(data).join(' ')} 'sha256-fh3TwPMflhsEIpR8g1OYTIMVWhXTLcjQ9kh2tIpmv54=' http://${remoteAuthority};`, // the sha is the same as in src/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html 'child-src 'self';', `frame-src 'self' https://*.vscode-cdn.net data:;`, <del> 'worker-src 'self' data:;', </del> <ins> 'worker-src 'self' data: blob:;', </ins> 'style-src 'self' 'unsafe-inline';', 'connect-src 'self' ws: wss: https:;', 'font-src 'self' blob:;',

Discussion:
Steps: from command line run it stalls We maybe missing a web worker related directive in our HTML files? //cc
Yeah, looks like needs to allow-list
May candidate? But I am unsure when/where/how the CSP are into effect. where do you see this? I have checked CSP allows blob as worker-src codespaces CSP allows blob as worker-src code-tunnels blob also allowed blob also allowed ????
I saw it with our web bits from our server, so basically: download server run it access the web UI I am not sure this would be a candidate for today, but maybe recovery and only if we see an actual issue from it. So far this is only an issue for perf testing, but we do not perf test our server, only atm.
Change:
<del> // Type definitions for Electron 4.2.9 </del> <ins> // Type definitions for Electron 4.2.10 </ins> // Project: http://electronjs.org/ // Definitions by: The Electron Team <https://github.com/electron/electron> // Definitions: https://github.com/electron/electron-typescript-definitions

Discussion:
Issue Type: <bBug</bThe first Mac native tab has its top row cut off: ! The second one has the statusbar below the visible window: ! Resizing the window is a workaround. VS Code version: Code - Insiders 1.38.0-insider (, 2019-08-15T05:23:00.986Z) OS version: Darwin x64 18.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ unique-lines1.0.0 ssh0.0.4 ghlink1.1.0 remotehub0.5.0 EditorConfig0.13.0 tslint1.0.44 git-project-manager1.7.1 rest-client0.22.0 solidity0.0.58 theme-karyfoundation-themes18.2.1 graphql-for-vscode1.15.1 vscode-docker0.7.0 remote-containers0.67.4 remote-ssh-edit-nightly2019.8. remote-ssh-explorer-nightly2019.8. remote-ssh-nightly2019.8. azure-account0.8.4 azurecli0.4.6 github-issues-prs0.9.1 debugger-for-chrome4.11.7 vetur0.22.1 vscode-versionlens0.24.0 vscode-yaml0.4.1 vscode-workspacecontains-canary0.0.2 vscode-open-in-github1.12.0 ayu0.18.0 vscodeintellicode1.1.9 </details<!-- generated by issue reporter --
does this reproduce when you disable grid layout?
Yes, it's the same with grid layout disabled.
I cannot reproduce using Electron 4.2.7
!
Fix is up at , should be available with next electron release.
we will take the new build and will push it via a PR.
Change:
import { ILifecycleMainService, } from 'vs/platform/lifecycle/electron-main/lifecycleMainService'; import { ICodeWindow, LoadReason } from 'vs/platform/window/electron-main/window'; import { IUserDataProfilesMainService } from 'vs/platform/userDataProfile/electron-main/userDataProfile'; <del> import { IAnyWorkspaceIdentifier, isEmptyWorkspaceIdentifier, toWorkspaceIdentifier } from 'vs/platform/workspace/common/workspace'; </del> <ins> import { IAnyWorkspaceIdentifier, toWorkspaceIdentifier } from 'vs/platform/workspace/common/workspace'; </ins> import { RunOnceScheduler } from 'vs/base/common/async'; import { IWindowsMainService } from 'vs/platform/windows/electron-main/windows';

Discussion:
Testing a new profile to the profile VS Code Keeps switching me back to the default profile
Are you on empty window?
Yes
I assume it works for folders/workspaces
It does seem to work with a folder open, yes.
Change:
if (element instanceof CommentNode) { if (element.range) { return nls.localize('resourceWithCommentLabel', <del> "Comment from ${0} at line {1} column {2} in {3}, source: {4}", </del> <ins> "${0} at line {1} column {2} in {3}, source: {4}", </ins> element.comment.userName, element.range.startLineNumber, element.range.startColumn,

Discussion:
Type: <bBug</bCC Screen reader users need to hear redundant information when landed in the comment thread. The following transcript demonstrates what it sounds like: In this message, "Comment from" is redundant because users already know they are interacting with the comment thread. Minimizing the redundant info is cruicial for screen reader users who have to process much information via speech output in a linear fashion. ! Extension version: 0.79. VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-31T03:29:50.526Z) OS version: WindowsNT x64 10.0. Modes: Restricted Connection to 'ssh-remote+' could not be established <details<summarySystem Info</summary Connection to 'ssh-remote+' could not be established </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
}); } <del> async run(accessor: ServicesAccessor, ...args: any[]): Promise<void> { const editorService = accessor.get(IEditorService); const activeEditor = editorService.activeEditor; </del> <ins> async run(accessor: ServicesAccessor, resourceOrContext?: URI | IEditorCommandsContext, context?: IEditorCommandsContext): Promise<void> { const { editor } = resolveCommandsContext(accessor.get(IEditorGroupsService), getCommandsContext(accessor, resourceOrContext, context)); </ins> <del> if (activeEditor instanceof MultiDiffEditorInput) { const viewModel = await activeEditor.getViewModel(); </del> <ins> if (editor instanceof MultiDiffEditorInput) { const viewModel = await editor.getViewModel(); </ins> viewModel.collapseAll(); } }

Discussion:
You should not be assuming that the editor for which the action is being run for is the active editor. Make sure to correctly extract the context from the arguments passed to the script. The run method should be defined the following way: You can get the correct context with and resolve it with Make sure to adopt this for the following MultiDiffActions: - You can test that it works correctly with and 2 editor groups
Change:
* Defaults to `prefix`. */ mode?: 'prefix' | 'subword' | 'subwordSmart'; <del> showToolbar?: 'always' | 'onHover'; </del> <ins> showToolbar?: 'always' | 'onHover' | 'never'; </ins> suppressSuggestions?: boolean; /** * Does not clear active inline suggestions when the editor loses focus.

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src="" alt="drawing" width="600"/Currently, we can control when to show the inline suggestion toolbar by setting to "always" or "onHover", which are defined as follows: "always": show the inline suggestion toolbar whenever an inline suggestion is shown, and "onHover": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option "never" as follows "never": do not show the inline suggestion toolbar.
I think this should be very easy to implement. Up for a PR?
I would like to take this.
Any ideas why this setting isn't in the Settings JSON file? .
Thank you so much for accepting the request and for the contribution!