jiebi/CodeConvo huggingface dataset:
Change:
SelectionClipboardContributionID, ContextMenuController.ID, SuggestController.ID, <ins> ParameterHintsController.ID, </ins> SnippetController2.ID, TabCompletionController.ID, ModesHoverController.ID,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.78.2 Commit: Date: 2023-05-10T14:39:26.248Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.78.2 Chrome/108.0.5359.215 Electron/22.5.2 Safari/537.36 Steps to Reproduce: Jupyter extension a dummy extension and install it: Interactive Window shows up shows up signature help works on new files though, just not in the interactive.
Change:
import * as semver from 'vs/base/common/semver/semver'; // TODO: @sandy081 merge this with deduping in extensionsScannerService.ts <del> export function dedupExtensions(system: IExtensionDescription[], user: IExtensionDescription[], development: IExtensionDescription[], logService: ILogService): IExtensionDescription[] { </del> <ins> export function dedupExtensions(system: IExtensionDescription[], user: IExtensionDescription[], workspace: IExtensionDescription[], development: IExtensionDescription[], logService: ILogService): IExtensionDescription[] { </ins> const result = new ExtensionIdentifierMap<IExtensionDescription>(); system.forEach((systemExtension) => { const extension = result.get(systemExtension.identifier);

Discussion:
This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width="476" alt="image" src=""
Can you please share the following file F1 Open Extensions Folder Share file
What do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?
Installed <img width="470" alt="image" src=""Running view <img width="917" alt="image" src=""Hover of restart <img width="470" alt="image" src=""Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
const HISTORY_STORAGE_KEY = 'debug.repl.history'; const FILTER_HISTORY_STORAGE_KEY = 'debug.repl.filterHistory'; <ins> const FILTER_VALUE_STORAGE_KEY = 'debug.repl.filterValue'; </ins> const DECORATION_KEY = 'replinputdecoration'; const FILTER_ACTION_ID = `workbench.actions.treeView.repl.filter`;

Discussion:
I frequently use the debug console in VS Code to get output from my application but it's often cluttered with various log messages from services that I cannot control. These unwanted entries are easily filtered in the text field "Filter (e.g. text, !exclude)" box. I would like a setting to configure this default filter text per workspace. Currently I have to manually configure this filter each time I start VS Code. I could not find this in either default settings or through an extension.
This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks I would actually prefer if we would just preserve the filter across vscode reloads. I am open to Pull Requests that solve this. Code pointer
Great. I would be fine with it being preserved through reloads
Created PR fixing this
thanks a lot for that I have commented on the PR.
I am trying to verify this feature right now, but it isn't persisting upon reload on my side (running off of latest commit on main). Steps: extension filter to debug console debugging command palette to reload console's filter is empty again. Is my flow correct?
thanks for trying to verify this. However this fix is not yet released. Sorry for not specifying. Though we have this label that should help with that. So I will close this issue, and it would be great if you can try it out again tomorrow. Thank you!
Change:
}; const resource = toResource(this.label); <ins> const label = this.label.name; </ins> if (this.options?.title !== undefined) { iconLabelOptions.title = this.options.title;

Discussion:
Type: <bBug</bis used as delimiter instead of <img width="499" alt="image" src=""VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-23T05:35:37.619Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ project-manager12.7.0 vscode-eslint2.4.2 gitlens14.4.0 EditorConfig0.16.4 vscode-todo-plus4.19.1 code-runner0.12.1 vscode-pull-request-github0.74.0 gitlab-workflow3.81.0 vscode-peacock4.2.2 vscode-random1.11.0 rainbow-csv3.8.0 dotenv1.0.1 remote-containers0.318.0 remote-ssh0.107. remote-explorer0.5. material-icon-theme4.31.0 partial-diff1.4.3 code-spell-checker3.0.1 sort-lines1.11.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please use the command to investigate possible cause.
I am seeing it in Explorer too, in today's Insider, with all extensions disabled: !
I am bisecting now...
Hmm, nothing found. Maybe I am doing it wrong.
From
Change:
webview, resource, locked, <ins> resourceColumn, </ins> contentProvider, previewConfigurations, logger,

Discussion:
Issue Type: <bBug</b! When using the Markdown preview, the "Show Source" action should be smart enough to know that the source is open and go to that tab. Same applies to the preview tab, if there is already a preview tab open switch focus there. Otherwise you're in this endless loop of creating duplicate tabs. VS Code version: Code - Insiders 1.35.0-insider (, 2019-05-20T05:15:57.974Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (30)</summaryExtensionVersion ------ vscode-browser-preview0.5.4 vscode-opennewinstance0.0.6 bracket-pair-colorizer1.0.61 vscode-svgviewer2.0.0 vscode-eslint1.9.0 gitlens9.7.4 vsc-material-theme2.8.2 prettier-vscode1.9.0 azure-virtual-machine-explorer0.0.2 vscode-pull-request-github-insiders1.137.0 vscode-colorize0.8.10 theme-monokai-pro-vscode1.1.13 vscode-azureappservice0.14.0 python2019.4. remote-containers0.53.0 remote-ssh0.37.0 remote-ssh-edit0.37.0 remote-ssh-explorer0.37.0 remote-wsl0.36.0 azure-account0.8.4 azurecli0.4.5 vscode-typescript-tslint-plugin1.0.0 debugger-for-chrome4.11.3 vetur0.21.0 vscode-docker0.6.2 vscode-yaml0.4.0 code-settings-sync3.2.9 ayu0.18.0 WebTemplateStudio-dev-nightly0.0. markdown-all-in-one2.3.1 (17 theme extensions excluded) </details<!-- generated by issue reporter --
I'd like to give this a try
Ok, I could use some help on this issue. I traced the click call to the function , but am not sure if I should be making any changes here since it will very likely affect other functionalities as well.

I also noticed that if I have the file already open in the same split window pane, it will open that instead of creating a new split pane, but it is even when it opens a new pane with a new tab. So I am confused how calling the same function with the same parameter exhibits different behaviors (opening a new pane with a new tab vs opening an already open tab in the same pane). ! Some pointers around this would be very helpful, thanks
sorry for tagging you, not sure if you got a chance to see my previous comment. Can you please help out?
The api you linked to is a good starting point but that is part of core VS Code. You want the caller of that api, which in the case is the markdown extension. How I think this feature should work: the markdown extension, we maintain a . These should track which column created the preview. This is likely already passed in with , we just don't store the resourceColumn anywhere as far as I remember. the is invoked, use the preview's column information to decide which column to show the preview in
Change:
[ "${NETWORKING}" = "no" ] && exit 0 PROG="/usr/bin/Xvfb" <del> PROG_OPTIONS=":10 -ac" </del> <ins> PROG_OPTIONS=":10 -ac -screen 0 1024x768x24" </ins> PROG_OUTPUT="/tmp/Xvfb.out" case "$1" in

Discussion:
Lately almost every Linux CI build fails on GH in our unit tests. Using your build with debug symbols (from ):
I've been tracking this in browserless, and have narrowed it down to libglapi-mesa or one of their sibling libs. I don't have a solution, but thought I'd help point you in some direction as I'm struggling with this one as well
oh thanks for chiming in, this seems to have started for us since a couple of days ago (). Is this a GH CI issue that should be reported?
I don’t think so, it’s prevalent in any Debian system I’ve encountered unfortunately
I believe I have this fixed by pinning these libs manually: I'll likely discuss this with the headless-dev mail group and see if they have better workarounds as this isn't viable longer term
This is unrelated to Electron 7, it even fails after our revert back to Electron 6 ():
Fixed by passing to (credits to )
Epic!
Change:
return new Selection(previousMatch.range.startLineNumber, previousMatch.range.startColumn, previousMatch.range.endLineNumber, previousMatch.range.endColumn); } <del> public selectAll(): FindMatch[] { </del> <ins> public selectAll(searchScope: Range[] | null): FindMatch[] { </ins> if (!this._editor.hasModel()) { return []; } this.findController.highlightFindOptions(); <del> return this._editor.getModel().findMatches(this.searchText, true, false, this.matchCase, this.wholeWord ? this._editor.getOption(EditorOption.wordSeparators) : null, false, Constants.MAX_SAFE_SMALL_INTEGER); </del> <ins> const editorModel = this._editor.getModel(); if (searchScope) { return editorModel.findMatches(this.searchText, searchScope, false, this.matchCase, this.wholeWord ? this._editor.getOption(EditorOption.wordSeparators) : null, false, Constants.MAX_SAFE_SMALL_INTEGER); } return editorModel.findMatches(this.searchText, true, false, this.matchCase, this.wholeWord ? this._editor.getOption(EditorOption.wordSeparators) : null, false, Constants.MAX_SAFE_SMALL_INTEGER); </ins> } }

Discussion:
This is an extension of It's caused by only checking lineNumber in: Steps to reproduce: the following text in your editor: from 2nd abc to last a find in selection, possibly by pressing <kbdAlt</kbd<kbdl</kbd:arrowleft:. Now the cursor is before 2nd a. 'Select all occurences of find match'. Notice that it selects 2nd to 5th abc, instead of 2nd to 4th: ! Does this issue occur when all extensions are disabled?: Yes VS Code version: Code 1.63.2 (, 2021-12-15T09:39:46.686Z) OS version: Linux x64 5.13.0-22-generic snap Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
When you do . Now the cursor is before 2nd a. don't you lose the selection? Then what is the expected result of if there is no selection but the option is still selected?? I think it should really select all 5 occurrences of . And very oddly, when I do the command (via <kbdCtrl</kbd+<kbdShift</kbd+<kbdL</kbd) it is auto-enabling the and options become enabled. And then, since there is no selection, does select those last four occurrences of - as I think it should - the question is why doesn't it select the first . It is as if the setting is not respected when there is no selection but the option is enabled. [Of course, there really is a selection, but it is empty.]
From what I can tell, the feature (select all occurences of find match in search scope) only works when the find widget is made visible.
unfortunately the issue still persists even when find widget is visible. Find scope never respects selection column, only line. It seems like it was designed to be that way:
Change:
import { DebugContentProvider } from 'vs/workbench/contrib/debug/common/debugContentProvider'; import { WelcomeView } from 'vs/workbench/contrib/debug/browser/welcomeView'; import { ThemeIcon, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; <del> import { registerColor, foreground, badgeBackground, badgeForeground, listDeemphasizedForeground, contrastBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { registerColor, foreground, badgeBackground, badgeForeground, listDeemphasizedForeground, contrastBorder, inputBorder, editorWarningForeground, errorForeground, editorInfoForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { DebugViewPaneContainer, OpenDebugConsoleAction } from 'vs/workbench/contrib/debug/browser/debugViewlet'; import { registerEditorContribution } from 'vs/editor/browser/editorExtensions'; import { CallStackEditorContribution } from 'vs/workbench/contrib/debug/browser/callStackEditorContribution';

Discussion:
I stumbled over and saw that there are still many colors hard-coded. Also while at the .css file, it's good practice to qualify all rules with (or ) now that the workbench can be embedded in the web.
Thanks for great feedback. There was some unused CSS, like the .annotation in the repl, so I removed that. I have also now qualifed all with . There is still one hard coded color for in repl, but I believe tackled this with his great PR. Though I might be mistaken?
I did, indeed, add colour contribution points to the REPL as part of but eventually you asked me to defer those until later, I do not remember the reason precisely... So the REPL is still not theme-able, unfortunately.
thanks for refreshing my memory. In case you would like to contribute that part of your PR we are open to accept it now :D From the I only see a need for color, not sure if there is more.
I am working on this now. I am taking it a step further, though, and adding theming to most of the REPL elements (errors, warnings, infos, source filenames etc.). Basically I want the whole REPL view to be fully customisable.
To verify, make sure you can customise the following colors in the debug console. You can use the setting :
Change:
} @command('git.openChange') <ins> @command('git.openChangeEditor') </ins> async openChange(arg?: Resource | Uri, ...resourceStates: SourceControlResourceState[]): Promise<void> { let resources: Resource[] | undefined = undefined;

Discussion:
Steps to Reproduce: to a git repository in VS Code a change to a file the SCM viewlet and notice that the Open Changes command is disabled <img width="456" alt="image" src="https://user-"
Change:
registerAction2(SelectPreviousStickyScrollLine); registerAction2(SelectNextStickyScrollLine); registerAction2(GoToStickyScrollLine); <ins> registerAction2(SelectEditor); </ins>

Discussion:
Testing around an open file in the editor with Stick Scroll enabled. Sticky Scroll Try to move focus out of Sticky Scroll. Tried pressing . Tried running "Focus Sticky Scroll" command a second time. Only way to get focus back to the editor is to select a level and press . I think should put you back into the editor
Change:
public createExtensionTerminal(options: vscode.ExtensionTerminalOptions, internalOptions?: ITerminalInternalOptions): vscode.Terminal { const terminal = new ExtHostTerminal(this._proxy, generateUuid(), options, options.name); const p = new ExtHostPseudoterminal(options.pty); <del> terminal.createExtensionTerminal(internalOptions?.isSplitTerminal, options.iconPath).then(id => { </del> <ins> terminal.createExtensionTerminal(internalOptions?.isSplitTerminal, asTerminalIcon(options.iconPath)).then(id => { </ins> const disposable = this._setupExtHostProcessListeners(id, p); this._terminalProcessDisposables[id] = disposable; });

Discussion:
Testing Ran into this verifying a different issue, the API says that ThemeIcons are assignable in the TerminalOptions but they are not !
Change:
const keybindingLabel = keybinding ? ` (${keybinding})` : ''; this.start.title = this.action.label + keybindingLabel; this.start.setAttribute('role', 'button'); <ins> this.start.ariaLabel = this.start.title; </ins> this.toDispose.push(dom.addDisposableListener(this.start, dom.EventType.CLICK, () => { this.start.blur();

Discussion:
In our accessibility user study testing, a user found that the start debugging button lacked a label. We should fix this even though the property does get read by some screen readers currently - such as VoiceOver.
Change:
isExtension: !!(engine && engine.type === 'string'), hasHttpsRepository: !!(repo && repo.type === 'string' && repo.value && uri && uri.scheme.toLowerCase() === 'https'), repository: uri!, <del> implicitActivationEvents: activationEvents </del> <ins> implicitActivationEvents: activationEvents, engineVersion: parsedEngineVersion </ins> }; const str = folder.toString(); const oldInfo = this.folderToPackageJsonInfo[str];

Discussion:
When developing extension the warning in : is wrong because it doesn't check if the extension is supported on older VSCode versions:
Change:
weight: weight, kbExpr: EditorContextKeys.textInputFocus, primary: KeyMod.CtrlCmd | KeyCode.Space, <del> mac: { primary: KeyMod.WinCtrl | KeyCode.Space } </del> <ins> secondary: [KeyMod.CtrlCmd | KeyCode.KEY_I], mac: { primary: KeyMod.WinCtrl | KeyCode.Space, secondary: [KeyMod.CtrlCmd | KeyCode.KEY_I] } </ins> }, menuOpts: [{ menuId: suggestWidgetStatusbarMenu,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VSCode have add a new keybinding for , so, remenber to add ctrl+i for toggleSuggestionDetails which is usiing the same let add this !
Change:
} private async checkAndGetCompatibleVersion(extension: IGalleryExtension, sameVersion: boolean, installPreRelease: boolean): Promise<{ extension: IGalleryExtension; manifest: IExtensionManifest }> { <del> const report = await this.getExtensionsControlManifest(); if (getMaliciousExtensionsSet(report).has(extension.identifier.id)) { </del> <ins> const extensionsControlManifest = await this.getExtensionsControlManifest(); if (extensionsControlManifest.malicious.some(identifier => areSameExtensions(extension.identifier, identifier))) { </ins> throw new ExtensionManagementError(nls.localize('malicious extension', "Can't install '{0}' extension since it was reported to be problematic.", extension.identifier.id), ExtensionManagementErrorCode.Malicious); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --When installing an extensions with , users can freely install extensions which are malicious, which is not possible from the UI. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0 OS Version: macOS 13 Steps to Reproduce: your 's to . a terminal inside of VS Code The CLI either refuses to install these extensions or warns the user.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Sorry, mistyped the version by one patch release, all fixed now.
Can you please let me know which extension you are trying to install that is malicious and VS Code allows it from CLI?
that would be any extension list that I tried and exists in the Marketplace, for example installs just fine although not allowing me to install via the UI <img width="725" alt="image" src="https://user-"
Change:
}); }); <del> test('Does not trigger automatically by default', async function () { </del> <ins> test('Does trigger automatically if disabled', async function () { </ins> const provider = new MockInlineCompletionsProvider(); await withAsyncTestCodeEditorAndInlineCompletionsModel('', <del> { fakeClock: true, provider }, </del> <ins> { fakeClock: true, provider, inlineSuggest: { enabled: false } }, </ins> async ({ editor, editorViewModel, model, context }) => { model.setActive(true);

Discussion:
Now that the feature has matured in its implementation, consider changing the default to .
I will do this as first action next milestone!
Change:
} }); } else if (e.kind === 'removeRequest') { <del> // TODO@jrieken this currently is buggy when removing not the very last request/response // if (this._session!.lastExchange?.response instanceof ReplyResponse) { // 	try { // 		this._session!.hunkData.ignoreTextModelNChanges = true; // 		await this._strategy!.undoChanges(this._session!.lastExchange.response.modelAltVersionId); // 	} finally { // 		this._session!.hunkData.ignoreTextModelNChanges = false; // 	} // } </del> <ins> // TODO@jrieken this is buggy/weird when having code changes from multiple turns because // logically they are all the same hunks this._strategy?.cancel(); </ins> } }));

Discussion:
make an inline chat request that changes code select the re-generate action :bug: the previous changes aren't undone
Change:
const value = getExcludeDisplayValue(dataElement); template.excludeWidget.setValue(value); template.context = dataElement; <ins> template.elementDisposables.add(toDisposable(() => { template.excludeWidget.cancelEdit(); })); </ins> } }

Discussion:
On Linux: the settings editor type out "cellToolbarLocation" way through, when the setting comes up, focus is stolen by the "item" in the table !
Yikes. I wonder if you could look at this
I'm unable to repro this on both Windows and Mac. It takes me a double-click to manually change the first row of that setting into edit mode, after it shows up. Do we have any OS-specific code for the settings editor If not, I wonder if this might be an Electron issue.
I did not repro on Windows either, only in Linux
I can on mac, if I have multiple rows on the setting. Or maybe I had to interact with the setting in that editor previously. I can't remember whether there is some code on the list setting widget that tries to restore focus after a change. I just called you out because I thought you might have seen that recently
Ok, reproduced the issue on Mac but not Windows with your hint there: -click the first item in the cell toolbar location setting to get it into edit mode. of pressing the OK or Cancel button, close the setting editor. the setting editor again, and slowly type . :bug: The setting shows up with the first item in edit mode, and that seems to steal focus away.
In , there are some areas where gets called. I think a solution to this approach would be to call whenever the user focuses back onto the main search bar, or if the settings editor tab is closed. Otherwise, on all OSes, when the user focuses back onto the search bar, and tries to search a new setting, the focus is stolen back to the item in edit mode.