jiebi/CodeConvo huggingface dataset:
Change:
return []; } try { <del> const response = await this.client.execute('navtree', { file: filepath }, token); </del> <ins> if (!this.cachedResponse.matches(document)) { this.cachedResponse.update(document, this.client.execute('navtree', { file: filepath }, token)); } const response = await this.cachedResponse.response; </ins> if (!response) { return []; } const tree = response.body; const referenceableSpans: Range[] = []; if (tree && tree.childItems) {

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.
Change:
let width: number; if (this._primarySelection.isEmpty()) { <del> const linesVisibleRanges = ctx.visibleRangeForPosition(this._primarySelection.getPosition()); </del> <ins> const linesVisibleRanges = ctx.visibleRangeForPosition(viewStartPosition); </ins> if (linesVisibleRanges) { left += linesVisibleRanges.left; }

Discussion:
Version: 1.94.0-insider Commit: Date: 2024-09-23T05:12:01.964Z Electron: 30.5.0 ElectronBuildId: Chromium: 124.0.6367.243 20.16.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 22.6.0 Steps to Reproduce: a very long line. Google IME for Japanese. at the last of the long line. position of the IME widget is not optimal. ! With , it is worse. !
Hi yes thanks a lot for opening this valuable issue. This is happening because we use the model ranges instead of the view ranges in the control bounds, selection bounds and character bounds positioning. The following PR fixes this:
I try the OSS version from the repository. The issue with is fixed. However, I still see the issue with Version: 1.94.0 Commit: Date: Unknown Electron: 30.5.1 ElectronBuildId: undefined Chromium: 124.0.6367.243 20.16.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 22.6.0 a very long line. Google IME for Japanese. at the last of the long line. position of the IME widget is not optimal. !
Oh I see thanks for letting me know that is curious. I will reopen the issue and have a look.
After investigating the issue, I believe this happens because I didn't remove the editor scroll left position from the bounds set for the selection and character bounds. The following PR should fix this.
Change:
"when": "config.git.enabled && scmProvider == git && gitState == idle" }, { <ins> "command": "git.commitStagedAmend", "when": "config.git.enabled && scmProvider == git && gitState == idle" }, { </ins> "command": "git.commitAll", "when": "config.git.enabled && scmProvider == git && gitState == idle" },

Discussion:
Like: git commit --amend
Are you referring to the out of the box git behavior or any particular git extension?
I would guess the out of the box behaviour, because it seems to be missing? I can see there is an "undo last commit", but this unstages everything from the last commit, which is not the same thing as amending the current commit. git-gui and atom have a simple checkbox which then amends the current commit instead of creating a new one - would it be possible to have the same in vscode? It's the one thing that stops me using vscode's built in git interface. In other words, you should be able to check and then uncheck the checkbox and be left in the original state. With the "undo last commit", this isn't possible.
Yes, out of the box
command was some time ago by
Should there be something in the menu? Please can you tell me where the option is?
Hmmm.... looks like it has disappeared for some reason, probably was omitted when git integration was ported to new API... will probably know if it was by-design, or just someone missed one command while porting git integration.
I believe we simply missed it... sorry for that.
I'll add it again.
Change:
import { TPromise } from 'vs/base/common/winjs.base'; import { TerminalConfigHelper } from 'vs/workbench/parts/terminal/electron-browser/terminalConfigHelper'; import { EDITOR_FONT_DEFAULTS } from 'vs/editor/common/config/editorOptions'; <ins> import { isFedora } from 'vs/workbench/parts/terminal/electron-browser/terminal'; </ins> class MockConfigurationService implements IConfigurationService { public _serviceBrand: any;

Discussion:
VSCode Version: Code 1.17.0 (, 2017-10-04T23:33:45.303Z) OS Version: Linux x64 4.12.0-2-amd64 Extensions: Extensions are disabled Steps to Reproduce: window doesn't look well ! <!-- Launch with to check. --Reproduces without extensions: Yes/No
Here is how my integrated terminal looks like !
what distro are you using? I've seen Fedora acts a little odd with font rendering both in the editor and the terminal. see
I'm experiencing the same issue on Fedora 26 / Gnome 3.24.2 / VSCode version 1.17.0. The only affected component is the terminal so far, other fonts look good. The issue is not present in VSCode 1.16.1.
i am using debian 9 / xfce4 / VSCode version 1.17.0
For Fedora right now the workaround is to use a different font:
it works like a charm. Thanks a lot :)
Thks now looks very well.
Pushed to master and release/1.17
Not sure I've got issue right, but looks like custom fonts such as are not working after last update. Before update everything worked fine. Wouldn't say it is too important, but would be nice to get it back. Linux Mint 18.2 x64. !
Same issue here with Fira Code font Ubuntu 17.04 x64
yes also here FiraCode looks weird now. macOS 10.13
same here as after 1.17.1 update it looks weird now with SF Mono on macOS. ! it looks weird, because before 1.17.1 it was awesome
This is the issue tracking the blurry text in 1.17.1
Change:
ensureNoDisposablesAreLeakedInTestSuite(); <del> // Test added so there is at least one non-ignored test in this suite test('temporary test', () => { assert.ok(true); }); </del> // Failing tests from issues... <del> test.skip('issue #208215: indent after arrow function', () => { </del> <ins> test('issue #208215: indent after arrow function', () => { </ins> // https://github.com/microsoft/vscode/issues/208215 <del> // consider the regex: /^s*(var|const|let)s+w+s*=s*(.*)s*=>s*$/ </del> const model = createTextModel("", languageId, {}); disposables.add(model); withTestCodeEditor(model, { autoIndent: "full" }, (editor, viewModel, instantiationService) => { registerLanguage(instantiationService, languageId, Language.TypeScript, disposables); viewModel.type('const add1 = (n) =>'); viewModel.type("n", 'keyboard'); assert.strictEqual(model.getValue(), [

Discussion:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have:
Change:
.monaco-workbench .part.editor > .content .walkThroughContent code, .monaco-workbench .part.editor > .content .walkThroughContent .shortcut { color: var(--vscode-textPreformat-foreground); <ins> background-color: var(--vscode-textPreformat-background); border-radius: 3px; </ins> } .monaco-workbench .part.editor > .content .walkThroughContent .monaco-editor {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.0 OS Version: Debian GNU/Linux trixie/sid I'm using dark high contrast theme. After updating vscode to 1.90.0 text inside textPreformat by default is the same color as background namely white. Adding this to setting: solves the problem.
One for recovery?
Fix looks good: !
Related on Stack Overflow:
Change:
options.regex || false, options.caseSensitive || false, options.wholeWord ? options.wordSeparators || null : null, <del> false); </del> <ins> options.regex || false); </ins> } else { const lineCount = this.textBuffer.getLineCount(); const fullRange = new Range(1, 1, lineCount, this.textBuffer.getLineLength(lineCount) + 1);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In Jupyter Notebooks, finding witrh regex works but replacing with capturing groups doesn't. I'd like if it does. I tried as in the usual editor, but the replacement treats as literal. I had to work around by copying the code section to the usual editor, and then find and replace. This seems like an inconsistent UX, and personally quite inconvinient.
Should I have opened this at ? If so, please close this so I can move on.
Thanks again for the help, it makes the find experience in notebook closer to the normal text editor one.
did you create a test plan item for this? I just the verification needed to it.
Change:
*--------------------------------------------------------------------------------------------*/ .monaco-editor .parameter-hints-widget { <del> z-index: 10; </del> <ins> /* Must be higher than sash's z-index and terminal canvases */ z-index: 40; </ins> display: flex; flex-direction: column; line-height: 1.5em;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: This is an issue related to the IntelliSense information block and terminal display area. Without any extension almost all code completion is unavailable. So I guess I should answer Yes here. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 OS Version: Windows 10 21H1 And I guess this configuration might also help: Terminal Integrated: Gpu Acceleration: off Steps to Reproduce: the integrated terminal to the right. function IntelliSense at a line long enough so that hint block should float on the right end. should get a wrong overlay at Z direction now. The hint block is hard to see. I've tried Python and C++. Both reproduced. So this should be an issue with VS Code instead of language IntelliSense extensions. !
I can definitely reproduce. The terminal is rendering on top of other stuff !
And the behavior differs with different option. !
Oh this only affects parameter hints, not the regular hover.
<img width="226" alt="image" src="https://user-"Looks good!
Change:
} async createWebview(): Promise<void> { <del> const baseUrl = this.asWebviewUri(dirname(this.documentUri), undefined); </del> <ins> const baseUrl = this.asWebviewUri(this.getNotebookBaseUri(), undefined); </ins> // Python notebooks assume that requirejs is a global. // For all other notebooks, they need to provide their own loader.

Discussion:
When converting a jupyter notebooks to a python code file, images no longer load. VS Code version: 1.60.0 Jupyter Extension version (available under the Extensions sidebar): v2021.8. Python Extension version (available under the Extensions sidebar): v2021.9. OS (Windows Linux distro) and version: Linux 5.8.0-59-generic 20.04.1-Ubuntu Python and/or Anaconda version: 3.9.6 Type of virtual environment used (N/A ...): conda Jupyter server running: Local a python file with the following code a random local image the cell The image should load After opening the dev tools, it seems that vscode is trying to load https://vscode- instead of the local file, using an online image from the web does work, unfortunetly local files does not even when using the protocol.
I can replicate this, for some reason images are not loaded when in interactive window.
hi, could you get any updates?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Still not working, the local images are not loading. Version: 1.71.0-insider Commit: Date: 2022-08-24T05:18:31.474Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.19.3--generic Sandboxed: Yes
Works fine for me: ! Do you have a folder open with both the notebook and image in it?
Thanks for the clarification, yes it only works when the folder is opened. For comparison, if I create a .ipynb file, the images are loaded even though no folder is opened.
Reopening based on the submitter's comment
I believe this is working as intended. The OP confirmed it works when a folder is open.

If you don't have a folder open though, we don't know where the load images from You could argue that in the no folder case we should then use the file's directory, but the interactive window is not linked to a single python file so I'm wary of trying to make this too clever. Better to keep it consistent IMO
Change:
private _hasHadInput: boolean; <ins> // Enables disposal of the xterm onKey // event when the CwdDetection capability // is added private _xtermOnKey: IDisposable | undefined; </ins> readonly statusList: ITerminalStatusList; disableLayout: boolean = false;

Discussion:
Testing vscode open to folder , and another folder . Have the files , , and , to folder enter in the terminal and click on it. opens in the folder. opens https://user-
Maybe I'm doing something wrong, but I can't reproduce. I have a workspace with a . It opens that before I into a new directory. I into a new directory with a and when I click on it, that one opens. !
did it look like shell integration was enabled on hover ?
Can repro, we need to also make validated local link provider aware of command detection.
this should already work as preprocessPath uses the cwd Guessing this is a windows only issue, as I'm not encountering it on mac
I think _processCwd is hooked up to the old system:
<img width="1648" alt="image" src="https://user-" is this as expected, I'm in folder and clicking on opens the quick pick other than directly opening .
if you create another terminal and hover the tab, what capabilities do you see?
hadn't enabled shell integration. he did and does see the capabilities, the run recent command works, but he said that this does not.
issue above is with word links whereas this original issue was not
Can repro, the following screenshot tries to open a link in vscode: ! !
Change:
openFolderSettings(options: IOpenSettingsOptions & { folderUri: IOpenSettingsOptions['folderUri'] }): Promise<IEditorPane | undefined>; openGlobalKeybindingSettings(textual: boolean, options?: IKeybindingsEditorOptions): Promise<void>; openDefaultKeybindingsFile(): Promise<IEditorPane | undefined>; <ins> openLanguageSpecificSettings(language: string, options?: IOpenSettingsOptions): Promise<IEditorPane | undefined>; </ins> getEditableSettingsURI(configurationTarget: ConfigurationTarget, resource?: URI): Promise<URI | null>; createSplitJsonEditorInput(configurationTarget: ConfigurationTarget, resource: URI): EditorInput;

Discussion:
Steps to Reproduce: command a language Settings file is opened. Settings Editor with language filter shall be opened given that the editor supports it.
Change:
} } <del> async changeIcon() { </del> <ins> async changeIcon(icon?: TerminalIcon): Promise<TerminalIcon | undefined> { if (icon) { this._icon = icon; this._onIconChanged.fire({ instance: this, userInitiated: true }); return icon; } </ins> type Item = IQuickPickItem & { icon: TerminalIcon }; const items: Item[] = []; for (const icon of getAllCodicons()) {

Discussion:
Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:
/duplicate
Tracking each action separately
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.
you might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.

Repro: Open multiple terminals Select multiple terminal tabs Right click and change icon Change icon only a single terminal is changed Real context stored with the action was done recently as part of Related:
Change:
this._focusedContextKey.set(true); this._visibleContextKey.set(true); this._inlineChatWidget.focus(); <del> this.layoutVertically(); </del> <ins> this.updateHeight(); </ins> this._updateWidth(); <del> this._register(this._instance.onDimensionsChanged(() => this._updateWidth())); </del> <ins> this._register(this._instance.onDimensionsChanged(() => { this.updateHeight(); this._updateWidth(); })); </ins> } <del> layoutVertically(): void { </del> <ins> private _updateVerticalPosition(): void { </ins> const font = this._instance.xterm?.getFont(); if (!font?.charHeight) { return;

Discussion:
Repro: terminal chat "list files in various ways", content is clipped at bottom but scrolling doesn't work !

Repro: terminal chat "list files in various ways" height of terminal !
, we'd need a way to set max height for the chat widget, which there isn't currently AFAICT
You need to call layout with the sizes you want
i tried that and didn't see the height taking effect, only the width.
Change:
class TwitterFeedbackService implements IFeedbackService { private static TWITTER_URL: string = 'https://twitter.com/intent/tweet'; <ins> private static VIA_NAME: string = 'code'; private static HASHTAGS: string[]  = ['HappyCoding']; private combineHashTagsAsString() : string { return TwitterFeedbackService.HASHTAGS.join(','); } </ins> public submitFeedback(feedback: IFeedback): void { <del> var queryString = `?${feedback.sentiment === 1 ? 'hashtags=HappyCoding&' : null}ref_src=twsrc%5Etfw&related=twitterapi%2Ctwitter&text=${feedback.feedback}&tw_p=tweetbutton&via=code`; </del> <ins> var queryString = `?${feedback.sentiment === 1 ? `hashtags=${this.combineHashTagsAsString()}&` : null}ref_src=twsrc%5Etfw&related=twitterapi%2Ctwitter&text=${feedback.feedback}&tw_p=tweetbutton&via=${TwitterFeedbackService.VIA_NAME}`; </ins> var url = TwitterFeedbackService.TWITTER_URL + queryString; shell.openExternal(url); } <ins> public getCharacterLimit(sentiment: number): number { let length : number = 0; if (sentiment === 1) { TwitterFeedbackService.HASHTAGS.forEach(element => { length += element.length + 2; }); } if (TwitterFeedbackService.VIA_NAME) { length += ` via @${TwitterFeedbackService.VIA_NAME}`.length; } return 140 - length; } </ins> } export class FeedbackStatusbarItem implements IStatusbarItem {

Discussion:
Due to being appended to it !
this looks like a good place to start off, is this something I can help with?
:+1: it's marked help wanted which probably means won't get to it any time soon.
Go for it, this is a great issue to start contributing to Code. Let me know if you need any help.
Awesome, I am on it! :)
Please review :) Couldn't find any unit tests for this, did I miss it?
Change:
export type Operation = AddOperation | ApplyOperation | BlameOperation | BranchOperation | CheckIgnoreOperation | CherryPickOperation | CheckoutOperation | CheckoutTrackingOperation | CleanOperation | CommitOperation | ConfigOperation | DeleteBranchOperation | DeleteRefOperation | DeleteRemoteTagOperation | DeleteTagOperation | DiffOperation | FetchOperation | FindTrackingBranchesOperation | <del> GetBranchOperation | GetBranchesOperation | GetCommitTemplateOperation | GetObjectDetailsOperation | GetRefsOperation | GetRemoteRefsOperation | HashObjectOperation | IgnoreOperation | LogOperation | LogFileOperation | MergeOperation | MergeAbortOperation | MergeBaseOperation | MoveOperation | PostCommitCommandOperation | PullOperation | PushOperation | RemoteOperation | RenameBranchOperation | RemoveOperation | ResetOperation | RebaseOperation | RebaseAbortOperation | RebaseContinueOperation | RefreshOperation | RevertFilesOperation | RevListOperation | RevParseOperation | SetBranchUpstreamOperation | ShowOperation | StageOperation | StatusOperation | StashOperation | SubmoduleUpdateOperation | SyncOperation | TagOperation; </del> <ins> GetBranchOperation | GetBranchesOperation | GetCommitTemplateOperation | GetObjectDetailsOperation | GetObjectFilesOperation | GetRefsOperation | GetRemoteRefsOperation | HashObjectOperation | IgnoreOperation | LogOperation | LogFileOperation | MergeOperation | MergeAbortOperation | MergeBaseOperation | MoveOperation | PostCommitCommandOperation | PullOperation | PushOperation | RemoteOperation | RenameBranchOperation | RemoveOperation | ResetOperation | RebaseOperation | RebaseAbortOperation | RebaseContinueOperation | RefreshOperation | RevertFilesOperation | RevListOperation | RevParseOperation | SetBranchUpstreamOperation | ShowOperation | StageOperation | StatusOperation | StashOperation | SubmoduleUpdateOperation | SyncOperation | TagOperation; </ins> type BaseOperation = { kind: OperationKind; blocking: boolean; readOnly: boolean; remote: boolean; retry: boolean; showProgress: boolean }; export type AddOperation = BaseOperation & { kind: OperationKind.Add };

Discussion:
Verification steps: Open a folder/workspace that contains a git repository Modify an existing file, and save it Add a new file, add some contents to it, and save it Invoke the "Git: Stash (Include Untracked)" command, and create a new stash Invoke the "Git: View Stash", and pick the stash that you have created Confirm that all files from the stash have the correct content
Change:
if (!task) { throw new TaskError(Severity.Info, nls.localize('TaskServer.noTask', 'Task to execute is undefined'), TaskErrors.TaskNotFound); } <ins> if (this._inProgressTasks.has(task._label)) { this._logService.info('Prevented duplicate task from running', task._label); return; } this._inProgressTasks.add(task._label); </ins> const resolver = this._createResolver(); let executeTaskResult: ITaskSummary | undefined; try {

Discussion:
<img width="423" alt="image" src="https://user-"
I am unable to repro this - could you pls provide the steps that you take?
I have not found a pattern so far, might be timing related. It is not happening everytime I reload the window... However, one thing to keep in mind is that I often use and not . That command kills the build task and relaunches it: So that may well be related to the issue.
Thanks for the idea, but seems unrelated to that command as has reproduced this with