jiebi/CodeConvo huggingface dataset:
Change:
private _gutterState: LightBulbState.State = LightBulbState.Hidden; private _iconClasses: string[] = []; <ins> private readonly lightbulbClasses = [ 'codicon-' + GUTTER_LIGHTBULB_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_ICON.id, 'codicon-' + GUTTER_SPARKLE_FILLED_ICON.id ]; </ins> private _preferredKbLabel?: string; private _quickFixKbLabel?: string;

Discussion:
The icon should be right above line 2, but it's all the way up at the beginning of line 1. !
this should be fixed with the new lightbulb changes!
Still able to reproduce this. long text and enable word wrap the cursor on line 2 and press Ctrl + . ! ESC Ctrl + . again !
Still able to repro. If I repeat steps 3 and 4, I notice that the sparkle alternates between the two lines. Edit: might have to wait for new Insiders.
I see similar to what saw, but the second time it didn't show at all: ! ! I'll push this to September as it doesn't meet the bar to fix at this point imo.
not sure why it removed the unreleased since this commit hasn't been released yet
It's good now
Change:
} } <ins> onDidInitialize.fire(); </ins> return instantiationService; } <ins> /** * Executes callback once services are initialized. */ export function withServices(callback: () => IDisposable): IDisposable { if (initialized) { return callback(); } const disposable = new DisposableStore(); const listener = disposable.add(onDidInitialize.event(() => { listener.dispose(); disposable.add(callback()); })); return disposable; } </ins> }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Monaco Editor OS Version: macOS 13.0 (22A380) Steps to Reproduce: in the some logs in in vscode. any Monaco editor test page. the output of the consoleeach call to will re-register all registered languages. <img width="763" alt="image" src="https://user-"
Can you look into why this is the case, maybe even providing a PR?
Sorry for the late reply, I would be happy to submit a PR.
Change:
private gotoDefinition(position: Position, openToSide: boolean): Promise<any> { this.editor.setPosition(position); <del> const openInPeek = this.editor.getOption(EditorOption.definitionLinkOpensInPeek); const action = new DefinitionAction({ openToSide, openInPeek: openInPeek, muteMessage: true }, { alias: '', label: '', id: '', precondition: undefined }); return this.editor.invokeWithinContext(accessor => action.run(accessor, this.editor)); </del> <ins> const definitionLinkOpensInPeek = this.editor.getOption(EditorOption.definitionLinkOpensInPeek); return this.editor.invokeWithinContext((accessor) => { const canPeek = definitionLinkOpensInPeek && !this.isInPeekEditor(accessor); const action = new DefinitionAction({ openToSide, openInPeek: canPeek, muteMessage: true }, { alias: '', label: '', id: '', precondition: undefined }); return action.run(accessor, this.editor); }); } private isInPeekEditor(accessor: ServicesAccessor): boolean | undefined { const contextKeyService = accessor.get(IContextKeyService); return PeekContext.inPeekEditor.getValue(contextKeyService); </ins> } public dispose(): void {

Discussion:
This situation has been discussed on PR . VSCode Version: Code OSS Dev (Insiders hasn't been built since PR ) OS Version: Ubuntu 19.10 Steps to Reproduce: the new setting 'Definition Link Opens in Peek' ! ctrl + click to open definition on Peek Widget that Peek Widget use ctrl + click again on another definition. As can be seen on this image there will be nested peeks which is not a correct behavior. ! I will submit a new PR because I have already fixed this on my fork.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.702 --- <!-- score: 0.646 --- <!-- score: 0.594 --- <!-- score: 0.542 --- <!-- score: 0.541 --<!-- potentialduplicatescomment --
Change:
private knownPortsRestoreValue: string | undefined; private restoreComplete = false; private onRestoreComplete: Emitter<void> = new Emitter(); <del> private unrestoredExtensionTunnels: Map<string, Tunnel> = new Map(); </del> <ins> private unrestoredExtensionTunnels: Map<string, RestorableTunnel> = new Map(); </ins> private sessionCachedProperties: Map<string, Partial<TunnelProperties>> = new Map(); private portAttributesProviders: PortAttributesProvider[] = [];

Discussion:
I had to clear settings sync for an unrelated issue and start fresh, but enabling the "UI State" option causes the error below to be continually thrown. If I disable the "UI State" option in settings sync, it starts working again. Type: <bBug</bsettings sync, check all boxes except "UI State" settings sync log, see that it succeeds settings sync config to include UI State VS Code version: Code 1.85.1 (Universal) (, 2023-12-13T09:48:06.308Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ erb0.0.1 vscode-eslint2.4.2 prettier-vscode10.1.0 codespaces1.16.6 copilot1.148.0 copilot-chat0.11.1 vscode-graphql-syntax1.2.3 endwise1.5.1 remote-containers0.327.0 proto0.0.4 rewrap1.16.3 gitblame10.6.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you please share the UI state using following steps F1 Export Profile... Select only UI state Export the profile and share it
The exported file is 2.3 MB, and it has some things inside that might be considered sensitive, I'm not sure. Is there a way I can share it privately?
You can share it to me by email - 2.3 MB is way under the limits right?
Just emailed the file, thank you!
I just checked the size limits on the server and it is indeed 2MB caps
Thanks for sharing. I figured out that port forwarding state is taking majority of the size. Hence assigning to
Discussed with and there are 3 easy things I can do to quickly reduce the size: Don't save empty values Add an expiry time to values so they don't live forever Save fewer fields per port in . For example, only tunnels should be stored + restored, so should be removed. So should , , , and .
the limit per resource version is 2mb atm
Are there steps to verify this?

To verify: to a Codespace and forward a port the remote connection the steps in to collect a profile the file created in step 3. Check that the port that you just forwarded in step 1 is listed there under a key and that it doesn't have a value.
For the step, does this mean to stop the codespace?
This is verified. The new port forwarded doesn't have , but I did notice some old ports of mine from old codespaces still having . Not sure if that was expected to be covered.
The behavior you see is expected. I didn't add any cleanup of the old state.
Change:
} }, "enabledApiProposals": [ <del> "contribShareMenu" </del> <ins> "contribShareMenu", "contribEditSessions" </ins> ], "contributes": { "commands": [

Discussion:
Testing Clone a git repository Open git repository in VS Code desktop Make a change to one or more files Invoke the command You are presented with an empty picker <img width="736" alt="image" src="https://user-"
Change:
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-search@0.9.0-beta.22: version "0.9.0-beta.22" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.22.tgz#18f2eabda82709cdd64dee003879b586869e28a3" integrity sha512-1I8W0bwjg6bUoNaESKHSkS9BN3Z9Xe44/zbUb6Un+pbb5Nun4LQvFwSLkAIdRrslxcbcHYIU/2Q7F1wCOWLbaA== </del> <ins> xterm-addon-search@0.9.0-beta.23: version "0.9.0-beta.23" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.23.tgz#3f568afaddbb2cb9bb13a80deada6a3715a10172" integrity sha512-kKOyOf+9ERam6IGjV5LTQJTIL6HaiecZkMcrckMY9fUyH53+kknNMfGoBmMgDXWTe8WjBdyTtiqr120koDUKVQ== </ins> xterm-addon-serialize@0.7.0-beta.12: version "0.7.0-beta.12"

Discussion:
Testing macOS, zsh Do a couple of ls calls for something that has multiple matches in the terminal using the Down or Up arrow -notice how the count is always wrong !

Testing Notice how the "no results" is grey in the editor when the find input is empty. In the terminal it is red !

Refs: macOS, zsh shell Search for something in the terminal that does not exist -"no results" is not rendered. !

Testing a new terminal a script which logs the same text 2000 times a query, find widget says there are 2000 matches the terminal (e.g. collapse and expand the side bar) :bug: the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count !
Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.
Still repros for me :(
Can one of you pls provide a gif? it's working for me with the above example as expected and with others
https://user-
You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?
!
from !
Something weird going on here: ! This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.
More weird behavior !
All results aren't getting included when search results get highlighted !
Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace: But in the search algorirthm it's treated as a null character, of length 0, as opposed to .
Still reproing this. Initially: ! After making the terminal panel taller: !
this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.
Pretty sure you were seeing so closing this again for verification

Testing a query which results in matches the terminal (e.g. expand or collapse explorer) :bug: match decorations remain !
Change:
'CURRENT_HOUR': true, 'CURRENT_MINUTE': true, 'CURRENT_SECOND': true, <ins> 'CURRENT_DAY_NAME': true, 'CURRENT_DAY_NAME_SHORT': true, 'CURRENT_MONTH_NAME': true, 'CURRENT_MONTH_NAME_SHORT': true, </ins> 'SELECTION': true, 'CLIPBOARD': true, 'TM_SELECTED_TEXT': true,

Discussion:
I'm happy to see the new date-based snippet variables in v1.20.0. I would love to see some additional ones since I wanted to use this for generating journal templates. Something like this: CURRENTDAYNAME: Monday, Tuesday, ... CURRENTDAYNAMESHORT: Mon, Tue, ... CURRENTMONTHNAME: January, February, ... CURRENTMONTHNAMESHORT: Jan, Feb, ... Thank you.
A little more tricky because you might want to consider localisation settings...
Change:
import { SeverityIcon } from 'vs/platform/severityIcon/browser/severityIcon'; import { CodeActionTriggerType } from 'vs/editor/common/languages'; import { IOpenerService } from 'vs/platform/opener/common/opener'; <del> import { IFileService } from 'vs/platform/files/common/files'; </del> import { Progress } from 'vs/platform/progress/common/progress'; import { ActionViewItem } from 'vs/base/browser/ui/actionbar/actionViewItems'; import { Codicon } from 'vs/base/common/codicons';

Discussion:
Type: <bBug</bworkspace a new notebook a syntax or other error in a cell problems view bug There's an extra to the right of the notebook file title ! VS Code version: Code - Insiders 1.88.0-insider (Universal) (, 2024-03-25T05:50:56.142Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
It is also same in Search ! Probably this should be something handled by the CC
Its possible to omit in the label widget for because there we know we are in a file context and is not very meaningful for descriptions (change in ). But for the problems view there is an explicit call to with an explicit description passed in: I am not sure just changing to return or wouldn't break some assumptions we have. I would argue that is a valid relative label for a path that has no parent (as in this case). any reason is not used? Or maybe we need to enlist the cell scheme as well as we do for untitled scheme.
I do not remember why we have two branches here - and . Is there a general suggestion for this? I am looking for this before digging deep. Is there a way to know this?
Yeah I would pick the and see what breaks, but maybe there is something in the history of that change that could explain it? I think schemes are pretty much hardcoded, here unfortunately while the notebook scheme is , the cell schemes are not. is there a way to know if a cell scheme is untitled?
It goes back before we used to have label service. I was also not showing the of the resource if the resource has no file provider. Showing parent was introduced . I believe using is the right way to go. I also see Search doing the same.
Change:
return; } <ins> const hoverPointerOffset = (this._hoverPointer ? Constants.PointerSize : 0); </ins> // Position hover on top of the target if (this._hoverPosition === HoverPosition.ABOVE) { // Hover on top is going beyond window <del> if (target.top - this._hover.containerDomNode.clientHeight < 0) { </del> <ins> if (target.top - this._hover.containerDomNode.clientHeight - hoverPointerOffset < 0) { </ins> this._hoverPosition = HoverPosition.BELOW; } }

Discussion:
a project with some kind of debugging and make sure the Breakpoints view is near the bottom of the screen over the pencil icon on the second-to-bottom list item. It works over the bottom list icon. The tooltip seems to appear and disappear very quickly causing the mouse to flicker (the FPS on the gif doesn't capture it very well but you can see that it doesn't render correctly) !
cc , this might have always been a bug but is probably now more exposed given its a custom hover now.
I haven't made any changes to the computation of where the hover should be placed in relation to the target, so a bug that we have had for a while, but should definitely look into. After testing a bit it seems to me that this only happens for ().
This also definitely used to work on language features and recently regressed (works fine in 1.87 stable): ! Reported the styling problem in
Change:
return format(noKbMsg, commandId); } <del> export async function runAccessibilityHelpAction(accessor: ServicesAccessor, editor: ICodeEditor, type: 'panelChat' | 'inlineChat'): Promise<void> { </del> <ins> export async function runAccessibilityHelpAction(accessor: ServicesAccessor, editor: ICodeEditor | undefined, type: 'panelChat' | 'inlineChat'): Promise<void> { </ins> const widgetService = accessor.get(IChatWidgetService); const accessibleViewService = accessor.get(IAccessibleViewService); const inputEditor: ICodeEditor | undefined = type === 'panelChat' ? widgetService.lastFocusedWidget?.inputEditor : editor; <del> const editorUri = editor.getModel()?.uri; if (!inputEditor || !editorUri) { </del> <ins> if (!inputEditor) { </ins> return; } const domNode = inputEditor.getDomNode() ?? undefined;

Discussion:
Refs: chat view. Ask some things keyboard focus on the request item (what you typed) -nothing happens This is inconsistent with the behaviour when the focus is on the response. Megan informed me that this behaviour is by design, but I do not see understand what is the benefit of this behaviour. What are we getting with this inconsistency?
cc and for feedback. The thought here was a user has typed the request - thus knows what it says generally and doesn't need to carefully inspect it. Also, the request is typically concise. Open to adding support for this though - we'd have to consider if we want the and to cycle through each list item. IMO, it would be a bit annoying to have to go through one's requests like this.
I discussed this with JooYoung and he agreed we should not do this unless it's requested
Change:
itemActualLength += textlabel.length; <del> const overFixedLength = itemFixedLength !== undefined ? (itemActualLength - itemFixedLength) : 0; if (overFixedLength > 0) { // longer than fixed length, trim itemActualLength -= overFixedLength; textlabel = textlabel.slice(0, -(1 + overFixedLength)) + '…'; tooLong = true; </del> <ins> if (itemFixedLength !== undefined) { const overFixedLength = itemActualLength - itemFixedLength; if (overFixedLength >= 0) { // longer than fixed length, trim itemActualLength -= overFixedLength; textlabel = textlabel.slice(0, -(1 + overFixedLength)) + '…'; tooLong = true; } </ins> } if (padding) {

Discussion:
This works for me when removing characters, but not when adding, example: Keep on typing in the line ! Originally posted by in
Change:
import * as assert from 'assert'; import { basename } from 'path'; import { commands, debug, Disposable, window, workspace } from 'vscode'; <del> import { assertNoRpc, disposeAll } from '../utils'; </del> <ins> import { assertNoRpc, createRandomFile, disposeAll } from '../utils'; </ins> suite('vscode API - debug', function () { teardown(assertNoRpc); <ins> test('breakpoints are available before accessing debug extension API', async () => { const file = await createRandomFile(undefined, undefined, '.js'); const doc = await workspace.openTextDocument(file); await window.showTextDocument(doc); await commands.executeCommand('editor.debug.action.toggleBreakpoint'); assert.strictEqual(debug.breakpoints.length, 1); await commands.executeCommand('editor.debug.action.toggleBreakpoint'); }); </ins> test('breakpoints', async function () { assert.strictEqual(debug.breakpoints.length, 0); let onDidChangeBreakpointsCounter = 0;

Discussion:
Set some breakpoints Access from an extension- it's an empty array Try again - it's full Seems that we don't sync breakpoint into to the EH until the first call to one of the breakpoint properties do you have some context on this? It's a little confusing because I wouldn't expect sending breakpoint infos to be expensive, and I would expect to be able to access the breakpoints array immediately.
I do not have more context. I believe is the author of this code. I like your suggestion that we change this and actively sync the breakpoints into the EH (since it should not be expensive).
The observed behavior is by design: we want to avoid that all breakpoints get transferred to all active extensions all the time. But the API doc doesn't explain this...
Thanks is the worry that it's too much data/too expensive? What's the solution for extensions that need to access the list of breakpoints?
yes, potentially too much data and traffic for all extensions. What's the solution for extensions that need to access the list of breakpoints? adding a to the function of an extension will register the extension to receive live updates for . With this will always reflect the current set of breakpoints.
Thanks, I don't really understand that though, it doesn't seem like that much traffic/data, compared to something like the full text of open documents. If it's going to work this way, I should document it in But I might try doing some testing to remove this restriction because I think it's unexpected.
Verification steps: Create an extension that can log the value of Set a breakpoint in any file Then trigger your extension to check the length of the breakpoints array It should log the correct value on the first try- previously it would have been 0 on the first access, then the correct value afterwards
Change:
// Each line and column clause have 6 groups (ie no. of expressions in round brackets) export const lineAndColumnClauseGroupCount = 6; <ins> const MAX_LENGTH = 2000; </ins> export class TerminalValidatedLocalLinkProvider extends TerminalBaseLinkProvider { constructor( private readonly _xterm: Terminal,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.0-insider OS Version: Win 10 1909 Steps to Reproduce: this link in your terminal: over it. Observe that the UI starts lagging <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: stable and from sources Steps to Reproduce: terminal and run a program that prints a really long line. For example the mouse over the text in the terminal and start scrolling up and down :bug: observe the terminal lags while scrolling
I believe this is already fixed, can you see if you can reproduce in the ? !
it's an issue in the terminal not in the debug console
I see. Could you pls send a gif of this? I tried scrolling in the terminal and wasn't seeing any lag.
Sure, notice int the gif I'm scrolling up ! I created a PR with a fix you can check the root cause is while executing a regex in
I verified that your PR fixes this bug , but will await 's approval of the changes.
/duplicate
Change:
position: absolute; width: 600px; z-index: 2000; <del> padding-bottom: 6px; </del> <ins> padding: 0 1px 6px 1px; </ins> left: 50%; margin-left: -300px; }

Discussion:
Issue Type: <bBug</bRepro the standard dark+ theme the 'select service' UI for setting sync bug This input has a blue boarder around it, however the two input options cut off this boarder on the sides: <img width="1298" alt="Screen Shot 2020-09-29 at 12 01 53 PM" src="https://user-"VS Code version: Code - Insiders 1.50.0-insider (, 2020-09-29T09:05:00.729Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
How do I trigger this UI?
Stop Settings Sync if it is On. Turn on Settings Sync and you will see this UI in the turn on flow. This is available only in insiders
I can't trigger it. When I'm turning on setting sync, I get the 'select an account to sign in' UI, and not the 'select service'. I need to set it to 'stable' so I could sync my settings. Can it be done in another way? !
it looks like the UI for this has changed now so I'm going to close this
Actually, I was able to repro after signing in and clicking on the quick pick
test steps: turn off settings sync if it's on turn on settings sync you may need to log in to settings first click on the title of the quick pick You should see the blue border around the entire quick pick !