jiebi/CodeConvo huggingface dataset:
Change:
} private async queryGallery(query: Query, options: IQueryOptions): Promise<IPagedModel<IExtension>> { <ins> const hasUserDefinedSortOrder = options.sortBy !== undefined; if (!hasUserDefinedSortOrder) { options.sortBy = SortBy.InstallCount; } </ins> let value = query.value; const idRegex = /@id:(([a-z0-9A-Z][a-z0-9-A-Z]*).([a-z0-9A-Z][a-z0-9-A-Z]*))/g;

Discussion:
Issue Type: <bBug</bSee below screenshot, it is not sorted by install count: ! VS Code version: Code 1.28.0 (, 2018-10-05T14:58:53.203Z) OS version: Windows_NT x64 10.0.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.5 --- <!-- score: 0.458 --- <!-- score: 0.446 --<!-- potentialduplicatescomment --
Change:
import { ExtHostUriOpeners } from 'vs/workbench/api/common/extHostUriOpener'; import { IExtHostSecretState } from 'vs/workbench/api/common/extHostSecretState'; import { IExtHostEditorTabs } from 'vs/workbench/api/common/extHostEditorTabs'; <del> import { IExtHostTelemetry, isNewAppInstall } from 'vs/workbench/api/common/extHostTelemetry'; </del> <ins> import { ExtHostTelemetryLogger, IExtHostTelemetry, isNewAppInstall } from 'vs/workbench/api/common/extHostTelemetry'; </ins> import { ExtHostNotebookKernels } from 'vs/workbench/api/common/extHostNotebookKernels'; import { TextSearchCompleteMessageType } from 'vs/workbench/services/search/common/searchExtTypes'; import { ExtHostNotebookRenderers } from 'vs/workbench/api/common/extHostNotebookRenderers';

Discussion:
This looks like we have telemetry loggers without appenders. Can we add a strict check or in the API impl?
Change:
// --- suggest <ins> test('triggerCharacter is null when completion provider is called programmatically #159914', async function () { let actualContext: vscode.CompletionContext | undefined; disposables.push(extHost.registerCompletionItemProvider(nullExtensionDescription, defaultSelector, <vscode.CompletionItemProvider>{ provideCompletionItems(_doc, _pos, _tok, context): any { actualContext = context; return []; } }, [])); await rpcProtocol.sync(); await commands.executeCommand<vscode.CompletionList>('vscode.executeCompletionItemProvider', model.uri, new types.Position(0, 4)); assert.ok(actualContext); assert.deepStrictEqual(actualContext, { triggerKind: types.CompletionTriggerKind.Invoke, triggerCharacter: undefined }); }); </ins> test('Suggest, back and forth', function () { disposables.push(extHost.registerCompletionItemProvider(nullExtensionDescription, defaultSelector, <vscode.CompletionItemProvider>{ provideCompletionItems(): any {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.0-insiders OS Version: mac latest Steps to Reproduce: completion provider like so and then execute command to call it: Execute code above. output log of : However Some devs can rely on that type explicitly by doing checks like . So, there should be no way to get To sum up things:
Good test. Thank you so much!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
} }); <ins> actions.push({ class: undefined, enabled: true, id: 'copySettingId', tooltip: nls.localize('copySettingId', "Copy Setting ID"), label: nls.localize('copySettingId', "Copy Setting ID"), run: () => { this._clipboardService.writeText(settingId); } }); </ins> return actions; }

Discussion:
Testing Click on a setting link in the release notes Get a tooltip "View '<title' in Settings" context menu It seems strange to open a context menu on left-click and to open one with only a single menu item. Can we skip doing this if "View" is the only action?
My preference would be to keep it consistent so that a context menu always opens when the button is clicked. There was some discussion of adding a "copy setting id" item in there too, which would fix the only-one-item issue.
Will be fixed by , which adds a "copy" action to the menu.
Another option is to open the context menu when the "gear" icon is hit, but go directly to the setting if the text is clicked (or vise versa)
Change:
override async run(accessor: ServicesAccessor, offset: number): Promise<void> { const paneCompositeService = accessor.get(IPaneCompositePartService); <del> const pinnedPanels = paneCompositeService.getPinnedPaneCompositeIds(ViewContainerLocation.Panel); </del> <ins> const pinnedPanels = paneCompositeService.getVisiblePaneCompositeIds(ViewContainerLocation.Panel); </ins> const activePanel = paneCompositeService.getActivePaneComposite(ViewContainerLocation.Panel); if (!activePanel) { return;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.1 OS Version: Windows 11 Steps to Reproduce: a hotkey mapped to pressing it until the last panel is displayed once more and it should wrap back around to the first panel of wrapping, it clamps to the last panel In previous versions of vscode (i.e. just a couple months ago) it wrapped around, and this was really useful.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.84.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I reloaded with 1.84.2 and the issue is still there.
Regressed here: Probably:
Thanks!
Yeah, thanks very much for this!
Change:
} protected override getSyncChangesActionButton(): SourceControlActionButton | undefined { <del> const scmConfig = workspace.getConfiguration('scm'); if (scmConfig.get<boolean>('experimental.showSyncView', false)) { return undefined; } </del> const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ sync: boolean }>('showActionButton', { sync: true }); const branchIsAheadOrBehind = (this.state.HEAD?.behind ?? 0) > 0 || (this.state.HEAD?.ahead ?? 0) > 0;

Discussion:
Testing I don't seem to have the sync changes button available to me, unless you're referring to the small icons in the status bars. !
I was able to get the Sync Changes button with the node-spdlog repository on my mac. It could be because my Windows machine and/or the vscode repository I tested with both have
that should not be the case. In your screenshot, I see that you have both incoming and outgoing changes, and no pending changes so the "Sync Changes" button should be shown instead of the disabled "Commit" button. Could you please share the exact steps that got you into this state? Also what is the value of the setting?
The has the default value. I seemed to repro it again, so here are some steps: the microsoft/vscode repository, switch to a new branch off of the main branch a file and push to establish the remote version of the branch , edit a separate file on that (remote) branch and commit the change directly to that branch. , edit yet another file and commit the change. Do not push. the git fetch command. :bug: There are both incoming and outgoing changes but the sync button does not appear.
Thanks for the steps. I will keep trying but for now I am unable to reproduce the issue: !
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ export interface IScrollEvent { vertical: boolean; horizontal: boolean; } export interface IDelegate<T> { getHeight(element: T): number; getTemplateId(element: T): string; } export interface IRenderer<TElement, TTemplateData> { renderTemplate(container: HTMLElement): TTemplateData; renderElement(element: TElement, templateData: TTemplateData): void; disposeTemplate(templateData: TTemplateData): void; } export interface IRendererMap<T> { [templateId: string]: IRenderer<T, any>; } </ins>

Discussion:
VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) "publ" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: "acceptSelectedSuggestion" without the caret still works
Looking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.
I can confirm it doesn't work on TypeScript due to the context key not being set.
There is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting
Despite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work
the timeout and like breakage happened in
Oh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?
works
Change:
export const ToggleCaseSensitiveCommandId = 'toggleSearchCaseSensitive'; export const ToggleWholeWordCommandId = 'toggleSearchWholeWord'; export const ToggleRegexCommandId = 'toggleSearchRegex'; <ins> export const RevealInSideBarForSearchResults = 'search.action.revealInSideBar'; </ins> export const ToggleSearchViewPositionCommandId = 'search.action.toggleSearchViewPosition';

Discussion:
Being able to interact with the files that appear in would be useful. A few examples that come to mind: file matched by search. Clicking the file in the search result and then pressing does not work. Right-clicking the file does not show the command. Right-clicking the file does not show (where the file could be renamed). The only option I've found is to click one of the matches to open the file, right click the tab, select and rename the file using the side bar ( or right-click). file matched by search. multiple files matched by search. multiple files from the search result. two files matched by search. When right-clicking a file in , I think all the options that are shown when right-clicking a file in should be shown. Then any options by extensions would also be available. The keyboard shortcuts and should probably keep their current behavior. Also, it should be possible to select multiple files, similar to in .
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.47 --<!-- potentialduplicatescomment --
, can we take this up separately ? ( Like rename , delete etc ) I would like to work on that if that is the case. Please let me know , Thanks :)
I think a "reveal in explorer" command for search results would be really useful and I would take a PR for that. But I don't want to replicate all the the other commands and functionality of the explorer.
Just adding "Reveal in Explorer" goes a long way :) I've created a different feature request for allowing selecting multiple files:
To be consistent the command should be called ! Also I do not understand the logic why it is at the top. Is not this after copy commands?
, The command was called "Reveal in Side Bar" but preferred "Reveal in Explorer". Also i can change the position and add it where ever you both suggest, Thanks :)
You're already looking at the side bar, so I don't think "Reveal in side bar" makes sense. I don't really like it for the tab context menu either, I think we should be more specific. Also I agree, I think it should be at the bottom, not the top
Change:
import { Color } from 'vs/base/common/color'; import { ITheme, IThemeService, IIconTheme } from 'vs/platform/theme/common/themeService'; import { ConfigurationTarget } from 'vs/platform/configuration/common/configuration'; <ins> import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions'; </ins> export const IWorkbenchThemeService = createDecorator<IWorkbenchThemeService>('themeService');

Discussion:
Improve user experience while installing themes
!
It would be cool if you could preview themes in the store, maybe with a split view hosting some example code, or even with the files you have open.
Please open a feature request for it
Change:
use super::service::{tail_log_file, ServiceContainer, ServiceManager as CliServiceManager}; <ins> const DID_LAUNCH_AS_HIDDEN_PROCESS: &str = "VSCODE_CLI_DID_LAUNCH_AS_HIDDEN_PROCESS"; </ins> pub struct WindowsService { log: log::Logger, tunnel_lock: PathBuf,

Discussion:
opens in a window instead of running in background. I have seen , which introduced this behavior. For me, means . Console window breaks it completely. If the window is closed - service is gone, what shouldn't happen. I understand that there were reasons about changing service behavior to ordinary application. However, I would really like service-like functionality back for my remote development. It's perfectly fine if this would be an additional installation flag. That would keep current easy behavior and allow for unattended installs. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.2 (System) OS Version: Windows 11 22H2 Steps to Reproduce:
Sorry, misread. Will look at that
I believe this issue is only partially fixed, even in . The window does not appear when only or (the cli) is running, however, as soon as a tunnel is connected to, a window appears (as code- is run). If the user closes the window, the tunnel connection is dropped. I believe the fix is to pass to creationflags in as seen here: However, without the proprietary "mixin" , it seems my builds of code cli are not able to properly run code-server, failing with To reproduce the issue, on a windows machine: an arbitrary tunnel to authorize the machine: the tunnel with the code at the tunnel service with connect to the tunnel again a on the desktop, close it and observe the tunnel disconnect on
Change:
import { themeColorFromId } from 'vs/platform/theme/common/themeService'; import { IEditorDecorationsCollection } from 'vs/editor/common/editorCommon'; <del> const overviewRulerDefault = new Color(new RGBA(197, 197, 197, 1)); </del> <ins> const overviewRulerDefault = new Color(new RGBA(65, 70, 80, 1)); </ins> export const overviewRulerCommentingRangeForeground = registerColor('editorGutter.commentRangeForeground', { dark: overviewRulerDefault, light: overviewRulerDefault, hcDark: overviewRulerDefault, hcLight: overviewRulerDefault }, nls.localize('editorGutterCommentRangeForeground', 'Editor gutter decoration color for commenting ranges.'));

Discussion:
I was exploring ways to improve the PR experience in VS Code and one of the ideas involved updating the glyph area for comments. Currently we show a gray bar and a unicode and that don't look very pretty. ! A couple of things I explored: Moving glyph area to the left of line numbers. This helps create separation between between the scm indicators and a clear area for adding comments. Adding button for adding and view comments. This follows a similar pattern on GitHub for reviewing changes. Hiding diff chunk areas. This reduces the visual noise and I think most people will be commenting on changed lines in the PR as opposed to lines that are not related Adding color to the and changes to look visually pleasing ! Unsure who should I assign to so assigning to and for now
Some additional feedback from the team: We might still need the indicator for comment areas, particularly when viewing files with changes in review mode where the diffs are not present ! We could also surface the "add comment" button on line hover to increase discoverability
I agree that we will likely still need to show the range, but let's improve the leave-a-comment and there's-a-comment decorations.
Here's what I'm thinking: ! It uses the comment codicon for lines with a comment thread. Keeps the existing + for add Makes them both look a little more clickable but making them more square and giving them rounded corners. and what do you think? I didn't add any color for now and I kept everything to the right of the line numbers still.
this is looking great, love that we can have codicon support in the comments! I know you mentioned you hadn't any color, is that something that you'd be open for us to add? I did a quick mockup that shows an alternate styling: <img width="314" alt="CleanShot 2022-08-08 at 08 57 41 src="https://user-"
I didn't add color because I thought the blue was a bit too strong, but I really like the color in this mock up. I'll add it and merge the change! I also see that you're using the codicon +. I'll switch to that too.
Also updated the multiline add: !
Change:
// maximize on Windows/Linux would fire an event saying that the terminal was not // visible. if (!!this._canvasAddon) { <del> this._core._renderService?._onIntersectionChange({ intersectionRatio: 1 }); </del> <ins> this._core._renderService?._handleIntersectionChange({ intersectionRatio: 1 }); </ins> // HACK: Force a refresh of the screen to ensure links are refresh corrected. // This can probably be removed when the above hack is fixed in Chromium. this.raw.refresh(0, this.raw.rows - 1);

Discussion:
latest insiders dev tools console :bug: see several of these messages:
called here non-existent in the repo
Think this is fine to wait until November as I don't see this in dev tools - has this repro'd for you?
Yeah I see it as soon as I open the terminal panel. It's an ugly dev tools message but agree it can probably wait
Change:
template.elementDisposables.add(template.button.onDidClick(() => { if (isLanguageTagSetting) { <del> this._onApplyFilter.fire(`@${LANGUAGE_SETTING_TAG}:${plainKey}`); </del> <ins> this._onApplyFilter.fire(`@${LANGUAGE_SETTING_TAG}${plainKey}`); </ins> } else { this._onDidOpenSettings.fire(dataElement.setting.key); }

Discussion:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.
Change:
}, null, `Error while computing folding regions for ${params.textDocument.uri}`, token); }); <ins> connection.onRequest('$/textDocument/selectionRange', async (params) => { const document = documents.get(params.textDocument.uri); const position: Position = params.position; if (document) { const htmlMode = languageModes.getMode('html'); if (htmlMode && htmlMode.doSelection) { return htmlMode.doSelection(document, position); } } return Promise.resolve(null); }); </ins> // Listen on the connection connection.listen();  No newline at end of file

Discussion:
Semantic selections: LSP: works CSS/SCSS/LESS: doesn't work, but it works in Atom. Probably need to update our dependencies. The plan now is to use emmet's "balance" commands. The challenge is that HTML/CSS language service need to include emmet. Alternatively, we can implement these commands ourselves.
Please review the animated gifs in the original thread: Seems to me the emmet functionality as it stands is wholly inadequate.
This will be available in tomorrow's insiders: !
is this suppose to work in Javascript? It's not nearly as functional as Webstorm. Also fails dramatically with HTML in .Vue files. Oh well.
Vue — it'll be available once we update the dependencies. JavaScript — we'll need to wait for TypeScript to add the semantic selection. I don't have any estimate.
Change:
'			if (baseElement && node.href.indexOf(baseElement.href) >= 0 && node.hash) {', '				let scrollTarget = window.document.getElementById(node.hash.substr(1, node.hash.length - 1));', '				if (scrollTarget) {', <del> '					scrollgetTarget().scrollIntoView();', </del> <ins> '					scrollTarget.scrollIntoView();', </ins> '				}', '			} else {', '				window.parent.postMessage({ command: "did-click-link", data: node.href }, "file://");',

Discussion:
VSCode Version:1.7.2 OS Version: Windows Steps to Reproduce: on a Highlight (h3) or section (h2) link at the top of the in-product release notes page. The page goes blank. This will also happen if you do the same with Markdown preview on This is a regression with 1.7.2. 1.7.0 and 1.7.1 don't have the issue. investigated and has a fix.
Change:
'properties': { 'general': { 'type': 'object', <ins> 'description': 'Delays for all signals besides error and warning at position', </ins> 'additionalProperties': false, 'properties': { 'announcement': {

Discussion:
Testing There no documentation on signalOptions: ! There is some documentation on the leaf properties in the JSON, but it is unclear what refers to.
I think the request was to have an overall description for the setting, as right now there's nothing until a user starts to complete properties in the <img width="636" alt="image" src=""