jiebi/CodeConvo huggingface dataset:
Change:
nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.')); export const listFocusHighlightForeground = registerColor('list.focusHighlightForeground', <del> { dark: listHighlightForeground, light: listHighlightForeground, hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </del> <ins> { dark: listHighlightForeground, light: ifDefinedThenElse(listActiveSelectionBackground, listHighlightForeground, '#BBE7FF'), hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </ins> nls.localize('listFocusHighlightForeground', 'List/Tree foreground color of the match highlights on actively focused items when searching inside the list/tree.')); export const listInvalidItemForeground = registerColor('list.invalidItemForeground',

Discussion:
default light theme trigger intellisense and type some matching characters bad colors <img width="1142" alt="Screenshot 2024-03-27 at 18 29 42" src=""

Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-27T05:50:10.528Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. Theme: ! Steps to Reproduce: +Shift+P VSIX !
Caused by:
Change:
import { QuickOpenHandler } from 'vs/workbench/browser/quickopen'; import { ITerminalService } from 'vs/workbench/parts/terminal/common/terminal'; import { IPanelService } from 'vs/workbench/services/panel/common/panelService'; <ins> import { ContributableActionProvider } from 'vs/workbench/browser/actions'; </ins> export class TerminalEntry extends QuickOpenEntryGroup {

Discussion:
Needs one for some keybindings
Also should add a rename terminal button to each entry for easy discoverability
Change:
this.handleActiveEditorChangeInNavigationStacks(group, editorPane); } <del> private handleActiveEditorSelectionChangeEvents(group: IEditorGroup, editorPane: IEditorPaneWithSelection, events: IEditorPaneSelectionChangeEvent[]): void { for (const event of events) { this.handleActiveEditorSelectionChangeInNavigationStacks(group, editorPane, event); } </del> <ins> private handleActiveEditorSelectionChangeEvent(group: IEditorGroup, editorPane: IEditorPaneWithSelection, event: IEditorPaneSelectionChangeEvent): void { this.handleActiveEditorSelectionChangeInNavigationStacks(group, editorPane, event); </ins> } private move(event: FileOperationEvent): void {

Discussion:
Steps: configure close all editors reload window open -click of line 11 -click -click pick "Go back in navigation locations" from commands as long as you can you cannot reach back into
this is caused by
Change:
} return await window.showInputBox({ <ins> value: opts && opts.defaultMsg, </ins> placeHolder: localize('commit message', "Commit message"), prompt: localize('provide commit message', "Please provide a commit message"), ignoreFocusOut: true

Discussion:
VSCode Version: Code - Insiders 1.17.0-insider (, 2017-09-26T05:24:48.911Z) OS Version: Windows_NT x64 10.0. Extensions: none Testing Steps to Reproduce: some change Staged (Amend) I'm asked for a new commit message without the existing one as the default. I usually want to keep the existing one.
yeah may be we can add an option to keep the older message. I mean prefill the text box with the latest commit message..
I'm assuming this is not in version 1.18.1. Can I expect this in 1.18.2? Because I'm looking for this to amend the commit properly (both the diff and the message). I keep having to go back to the command line and issue because VSCode's Commit Staged (Amend) option shows a blank message.
No, this will be in 1.19.
I upgrade to 1.19, and this works, however we use gerrit which has a Change-Id in the commit message, and the newline is removed when to the commit message box. Which means when I upload the change to gerrit, it becomes a new patchset. Can this please not remove the newlines.
I see... I created this to track that issue:
Change:
const notebook = editor.textModel; const scopedContextKeyService = editor.scopedContextKeyService; <del> const matchResult = notebookKernelService.getMatchingKernel(notebook); </del> <ins> const matchResult = this._notebookKernelService.getMatchingKernel(notebook); </ins> const { selected, all } = matchResult; if (selected && controllerId && selected.id === controllerId && ExtensionIdentifier.equals(selected.extension, extensionId)) {

Discussion:
Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width="601" alt="image" src="https://user-"This can be simplified as a single "Selected" group at the very top <img width="601" alt="image" src="https://user-"
Change:
const terminalService = accessor.get(ITerminalService); const terminalEditorService = accessor.get(ITerminalEditorService); const terminalGroupService = accessor.get(ITerminalGroupService); <ins> const terminalProfileService = accessor.get(ITerminalProfileService); </ins> const workspaceContextService = accessor.get(IWorkspaceContextService); const commandService = accessor.get(ICommandService); const folders = workspaceContextService.getWorkspace().folders;

Discussion:
In the recent Edit Sessions UX study we ran, we saw several participants searching in vain for the terminal item in the compact menu on , sometimes for minutes: ! Could we consider bringing it back? I'm guessing we intentionally suppressed it because terminals can't run in the web, but participants were simply confused that it wasn't there without connecting its absence to the fact that was a browser application. Additionally, RemoteHub contributes a welcome view for the terminal which is one of the primary ways we explain that users must continue working elsewhere to run or debug code, and the fact that the terminal is completely suppressed means one less opportunity for users to organically learn the limitations of through our welcome views. ! cc
Yes that is why it was removed. It doesn't do much but if it helps reduce confusion I guess it's worth it?
Not against the idea of having the terminal menu in web but in its current form it's useless and doesn't allow me to actually show a terminal pane, it just deadends all over https://user-
Reverting in
when I enable the menu again and fix up the terminal command, the run/customize task items give this on the scripts/code-web sample-folder: <img width="1229" alt="image" src="https://user-"That does actually run, not sure what it's doing exactly though. Is that a custom execution task running in the web worker ext host? If so you might need a context key on those menu items to only show them when a custom execution task is registered?
Unless I'm missing something, I believe only registered tasks will show there - if they're running when you select them, then I don't think there's an issue.
I think there's a built-in fake task when running code-web is what I mean, when run in actual then running it might do nothing. In that case it should hide similar to how we're changing the behavior of New Terminal depending on whether extension contributed profiles exist
Change:
private triggerCharactersListeners: IDisposable[]; private active: boolean; private throttledDelayer: RunOnceScheduler; <ins> private provideSignatureHelpRequest?: TPromise<boolean, any>; </ins> constructor(editor: ICodeEditor) { super();

Discussion:
From Steps to Reproduce: top of , add: code dev so that the modified ts extension is running a ts file in the dev instance of code: signature help in but then move the cursor up or down a line Bug Even though we likely no longer need the signature help result, it appears that we never actually cancel SignatureHelpProvider request
Cases where we may want to cancel the request: Selection change Document contents change Active document changes Suggestions requested
Should be fixed for the following cases: Document changes Request cancelled by user Mouse selection Re-trigger hints
Change:
super({ id: Constants.FocusPreviousSearchResultActionId, title: { <del> value: nls.localize('FocusPreviousSearchResult.label', 'Search: Focus Previous Search Result'), original: 'Search: Focus Previous Search Result' </del> <ins> value: nls.localize('FocusPreviousSearchResult.label', 'Focus Previous Search Result'), original: 'Focus Previous Search Result' </ins> }, keybinding: [{ primary: KeyMod.Shift | KeyCode.F4, weight: KeybindingWeight.WorkbenchContrib, }], <del> category: category.value, </del> <ins> category: category, f1: true, </ins> precondition: ContextKeyExpr.or(Constants.HasSearchResults, SearchEditorConstants.InSearchEditor), }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Ventura 13.0.1 Steps to Reproduce: shift + p "replace" replace in files command is found
Was there ever such a command? is there.
that's exactly the one I'm talking about. I looked it up in 3 computers and only found the command in the one I update vscode the least. I'm going to see if it's any plugin I have. I recall using it very recently and the only thing I remember adding or updating was vscode itself
is in the Command Palette of both Stable v1.73.1 and Insiders v1.74 for me.
ok, thanks for verifying. I am going to validate, report my findings and close the ticket when I get home
the command i was looking for is a different one. it is like "Search: Replace in files" and what it used to do is switch to the search tab and automatically open the replace box like the following screenshot. the pc that had the command automatically updated, i was going to show the screenshot but it was too late :(. the command was no longer there !
it was this one. found it in another laptop i no longer used. i disabled wifi to prevent auto updating. !
what version is the still visible?
I saw it in the latest version as of two weeks ago. I got the screenshot from 1.71.2
Caused by a regression in , will fix after is merged
this was released in 1.74.0
Change:
line-height: 22px; } <ins> .scm-view .monaco-list-row .monaco-icon-label-container { height: 22px; } </ins> .scm-view .monaco-list-row .history, .scm-view .monaco-list-row .history-item-group, .scm-view .monaco-list-row .resource-group {

Discussion:
Notice the white hair lines between the list rows: ! It turns out that if the IconLabel has a description the height of the row is instead of .
Change:
} private async resolveHEADMergeBase(): Promise<Branch | undefined> { <del> if (this.repository.HEAD?.type !== RefType.Head || !this.repository.HEAD?.name) { </del> <ins> try { if (this.repository.HEAD?.type !== RefType.Head || !this.repository.HEAD?.name) { return undefined; } const mergeBase = await this.repository.getBranchBase(this.repository.HEAD.name); return mergeBase; } catch (err) { this.logger.error(`[GitHistoryProvider][resolveHEADMergeBase] Failed to resolve merge base for ${this.repository.HEAD?.name}: ${err}`); </ins> return undefined; } <del> const mergeBase = await this.repository.getBranchBase(this.repository.HEAD.name); return mergeBase; </del> } dispose(): void {

Discussion:
Getting errors on screenshot below. Not sure of exact repro but I suspect this has to do with my repo being newly created and having no commits yet. ! Version: 1.93.0-insider Commit: Date: 2024-08-27T05:04:20.235Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0
Change:
import { IStatusbarService } from 'vs/workbench/services/statusbar/browser/statusbar'; export class RemoteTerminalBackendContribution implements IWorkbenchContribution { <ins> static ID = 'remoteTerminalBackend'; </ins> constructor( @IInstantiationService instantiationService: IInstantiationService, @IRemoteAgentService remoteAgentService: IRemoteAgentService,

Discussion:
changed to move to but this caused a feature for Codespaces to stop working where the terminal will start streaming in the init logs before the workbench has fully loaded. Ideally we would start it up on Starting only on remote, if we can't do that we need to move it back to Starting in the meantime. cc
We know if we are connected to a remote from the environment service via probing for .
We don't have access to services at workbench contrib registration do we?
no, but you could have 1 eager workbench contrib that depends on the environment service to decide if a second thing should get instantiated or not.
Marked verified, only can properly verify it
this seems to still be failing, the terminal does not show up until the codespace is fully created and the workbench initialized
Verified by
Change:
import { RunOnceScheduler } from 'vs/base/common/async'; import { CharCode } from 'vs/base/common/charCode'; import { Codicon } from 'vs/base/common/codicons'; <del> import { IMarkdownString } from 'vs/base/common/htmlContent'; </del> <ins> import { MarkdownString } from 'vs/base/common/htmlContent'; </ins> import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; import * as platform from 'vs/base/common/platform'; import { InvisibleCharacters } from 'vs/base/common/strings';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.2 OS Version: Darwin x64 20.6.0 Steps to Reproduce: fullwidth right parenthesis the right parenthesis <img width="688" alt="image" src="https://user-"
should be escaped: ,
Thanks a lot for reporting & investigating! Up for a PR?
Change:
return true; } case VSCodeOscPt.Property: { <del> const [key, rawValue] = args[0].split('='); if (rawValue === undefined) { </del> <ins> const { key, value } = this._parseKeyValueAssignment(args[0]); if (value === undefined) { </ins> return true; } <del> const value = this._deserializeMessage(rawValue); </del> switch (key) { case 'Cwd': { <del> // TODO: Ideally we would also support the following to supplement our own: //       - OSC 1337 ; CurrentDir=<Cwd> ST (iTerm) //       - OSC 7 ; scheme://cwd ST        (Unknown origin) //       - OSC 9 ; 9 ; <cwd> ST           (cmder) this._createOrGetCwdDetection().updateCwd(value); const commandDetection = this.capabilities.get(TerminalCapability.CommandDetection); commandDetection?.setCwd(value); </del> <ins> this._updateCwd(value); </ins> return true; } case 'IsWindows': {

Discussion:
Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
On Windows Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one () Code pointer:
I'm taking this.
sounds good
I've just submitted the PR. You can check it anytime you want.
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .
Change:
export namespace Range { export const fromTextSpan = (span: Proto.TextSpan): vscode.Range => <ins> fromLocations(span.start, span.end); export const fromLocations = (start: Proto.Location, end: Proto.Location): vscode.Range => </ins> new vscode.Range( <del> Math.max(0, span.start.line - 1), Math.max(span.start.offset - 1, 0), Math.max(0, span.end.line - 1), Math.max(0, span.end.offset - 1)); </del> <ins> Math.max(0, start.line - 1), Math.max(start.offset - 1, 0), Math.max(0, end.line - 1), Math.max(0, end.offset - 1)); </ins> export const toFileRangeRequestArgs = (file: string, range: vscode.Range): Proto.FileRangeRequestArgs => ({ file,

Discussion:
Issue Type: <bBug</bGitHub Pull Request extension repo Hover on Press CMD key ! Ideally we should be able to implementation of at the top and definition at the bottom, but :( VS Code version: Code - Insiders 1.34.0-insider (, 2019-04-09T05:14:40.620Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (50)</summaryExtensionVersion ------ vscode-apollo1.5.2 markdown-emoji0.0.7 solargraph0.19.6 npm-intellisense1.3.0 vscode-svgviewer2.0.0 vscode-markdownlint0.26.0 vscode-eslint1.8.2 xml2.4.0 gitlens9.6.0 remotehub0.2.0 tsl-problem-matcher0.0.4 EditorConfig0.13.0 tslint1.0.43 vscode-npm-script0.3.5 vsc-material-theme2.8.2 prettier-vscode1.8.1 flow-for-vscode1.1.1 vscode-pull-request-github-insiders1.98.0 ocaml0.6.43 beautify1.4.11 references-plusplus0.0.5 graphql-for-vscode1.13.0 dotenv1.0.1 theme-monokai-pro-vscode1.1.12 vscode-azurefunctions0.16.0 vscode-language-pack-zh-hans1.33.2 python2019.3.6558 azure-account0.8.1 cpptools0.22.1 Go0.9.2 powershell1.12.0 vscode-typescript-tslint-plugin1.0.0 wordcount0.1.0 vsliveshare1.0.18 debugger-for-chrome4.11.3 debugger-for-ios-web0.1.2 vetur0.18.1 subtitles-editor1.0.2 vscode-versionlens0.22.0 material-icon-theme3.7.0 seti-icons0.1.3 ruby0.22.3 smartpaste0.0.3 toggle0.0.1 vscode-fuzzsymbols0.0.1 sass-indented1.5.1 rust0.6.1 sourcekit-lsp0.0.

1 vscode-lldb1.2.2 vscode-intelli-nav0.0.6 (12 theme extensions excluded) </details<!-- generated by issue reporter --
adding since I believe the implementation peak when holding CMD is determined by VS Code
Yeah, today we count matching bracket (up to a low maximum of lines) to compute the preview. not sure if TypeScript provides  but that would certainly help here
Ok, we do set the but it is just the range of the identifier (). I've opened to track having this information returned from TypeScript
Planning to do work to support API proposed by in June. We would not actually ship this until TS 3.6 however
To verify, please make sure you are using TS 3.6 in your workspace and follow original instructions in the github PR extension's codebase
Change:
use std::sync::{Arc, Mutex}; use std::time::{Duration, Instant}; <del> use const_format::concatcp; </del> use hyper::service::{make_service_fn, service_fn}; use hyper::{Body, Request, Response, Server}; use tokio::io::{AsyncBufReadExt, BufReader};

Discussion:
The command was augmented with the argument here in Because the does not include the , any attempts to mint a key will result in a 404 if the server-base-path is set. I think this is the reason why I am experiencing an issue that any sign-in attempt in the browser (e.g., Github Copilot, Settings Sync) do not persist between page refreshes. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.1 OS Version: x64 Steps to Reproduce: the browser, observe 404s to
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
assigned to you since you approved the original PR
Change:
cellList.attachViewModel(viewModel); // render height 210, it can render 3 full cells and 1 partial cell <del> cellList.layout(210 + topInsertToolbarHeight, 100); </del> <ins> cellList.layout(210, 100); </ins> // init scrollTop and scrollBottom assert.deepStrictEqual(cellList.scrollTop, 0);

Discussion:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible
Change:
// LEFT anchor (start) for (; start >= 0; start--) { let ch = word.charCodeAt(start); <del> if (ch === CharCode.Underline || ch === CharCode.Dash) { </del> <ins> if ((start !== offset) && (ch === CharCode.Underline || ch === CharCode.Dash)) { </ins> // foo-bar OR foo_bar break; } else if (isLowerAsciiLetter(ch) && isUpperAsciiLetter(lastCh)) {

Discussion:
Issue Type: <bBug</bany file which contains word consisting of letters with underscores (f.e. helloworld). For simplicity let's assume only one underscore is present. cursor in various places of this word and activate expand selection command (either via keyboard shortcut or keybinding) : 3a. cursor is not near underscore (underscore is not immediately to the left or right of cursor) - part of the word selected, bounded by word beginning/end and underscore - OK 3b. underscore is immediately left to the cursor - part of word to the right of cursor is selected - OK 3c. underscore is immediately right to the cursor - the whole word is selected - UNEXPECTED. For 3c I expected only part of the word selected as well, not the whole word. VS Code version: Code 1.42.0 (, 2020-02-06T10:51:34.058Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ quick-open-prefill-selection0.0.1 vscode-eslint2.0.15 gitlens10.2.1 EditorConfig0.14.4 vscode-great-icons2.1.47 intellij-idea-keybindings0.2.37 camelcasenavigation1.1.1 material-icon-theme3.9.3 partial-diff1.4.1 terminal-tabs0.2.0 (5 theme extensions excluded) </details<!-- generated by issue reporter --
Tried to fix this in the PR PS - this is my first PR for a OSS, ever... please forgive me for any mistake or misconduct.