jiebi/CodeConvo huggingface dataset:
Change:
forceNewWindow: arg?.forceNewWindow, forceReuseWindow: arg?.forceReuseWindow, noRecentEntry: arg?.noRecentEntry, <del> remoteAuthority: arg?.forceLocalWindow ? null : undefined </del> <ins> remoteAuthority: arg?.forceLocalWindow ? null : undefined, forceProfile: arg?.forceProfile, forceTempProfile: arg?.forceTempProfile, </ins> }; const uriToOpen: IWindowOpenable = (hasWorkspaceFileExtension(uri) || uri.scheme === Schemas.untitled) ? { workspaceUri: uri } : { folderUri: uri };

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Today, the command only supports an describing the folder/workspace path to be opened. It would be interesting to allow adding the set of extensions to be used as well, or at least the profile, just like the CLI interface created in . Thank you
To verify: Create a profile Verify passing the profile name as an argument to the command from the extension and make sure the folder is opened in that profile. Eg:
Change:
scopedChatToSpeechInProgress.set(true); break; case TextToSpeechStatus.Stopped: <del> scopedChatToSpeechInProgress.set(false); </del> <ins> scopedChatToSpeechInProgress.reset(); </ins> break; } }));

Discussion:
Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39.

cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
are you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:
Happened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.
I need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)
Change:
'out-build/paths.js', 'out-build/vs/**/*.{svg,png,cur,html}', 'out-build/vs/base/common/performance.js', <del> 'out-build/vs/base/node/{stdForkStart.js,terminateProcess.sh,ps-win.ps1}', </del> <ins> 'out-build/vs/base/node/{stdForkStart.js,terminateProcess.sh}', </ins> 'out-build/vs/base/browser/ui/octiconLabel/octicons/**', 'out-build/vs/workbench/browser/media/*-theme.css', 'out-build/vs/workbench/electron-browser/bootstrap/**',

Discussion:
After updating the module to support getting memory, cpu, and command line for each process on windows (), the module can be used in more places within VSCode [x] Update existing version of the module that's being used in the terminal [x] Use the module in place of the PowerShell script in
Change:
isAfter(other: Position): boolean; /** <del> * Check if `other` is after or equal to this position. </del> <ins> * Check if this position is after or equal to `other`. </ins> * * @param other A position. * @return `true` if position is on a greater line

Discussion:
In , the comparison functions , , , and have misleading descriptions. For example, says "Check if is before this position." I think it would be more clear to say something like "Check if this position is before ", as that is when is returned. Likewise for the other three.
Change:
} } <del> private _revealRangeCommon(viewIndex: number, range: Selection | Range, newlyCreated: boolean, alignToBottom: boolean) { </del> <ins> private _revealRangeCommon(viewIndex: number, range: Selection | Range, alignHint?: 'top' | 'bottom' | undefined) { </ins> const element = this.view.element(viewIndex); const scrollTop = this.getViewScrollTop(); const wrapperBottom = this.getViewScrollBottom();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: a new notebook a code cell a markdown cell with a few lines such as follows Go into preview mode in markdown Edit first cell to get into notebook mode Arrow down to select markdown cell and hit enter Watch how the mardown cell scrolls up in the notebook view Go back to preview mode Scroll the notebook to view the first cell again and edit it Now select the markdown cell using the mouse Double click the mardown cell to edit it and wathc how it does not scroll!! I.e. using keyboard vs mouse results in different behaviour with scrolliing of the notebook. Ideally I would expect there to be no automatic scrolling when editing using keyboard, just as with mouse given the md cell is already in view we should not scroll this cell !
When pressing enter, we try to reveal the cursor selection in the cell editor into view by calling which uses the reveal type My expectation is it only scrolls the cell if it's out of the viewport but currently it always reveals the cell to the top of the viewport. Changing the reveal type to does fix the problem (as it should behave, here I'm not necessarily suggesting we change the reveal type in ).
Assigning to Feb milestone as the experience is quite bad. What surprised me is we didn't get user reports for this, which made me wonder how many users edit markdown cells after they are initially created.
Change:
import 'vs/css!./media/scm'; import { localize } from 'vs/nls'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import { VIEWLET_ID } from 'vs/workbench/contrib/scm/common/scm'; </del> <ins> import { ISCMViewService, VIEWLET_ID } from 'vs/workbench/contrib/scm/common/scm'; </ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { IThemeService } from 'vs/platform/theme/common/themeService';

Discussion:
Type: <bBug</bWhen there is only one instance and the Source Control Providers and Source Control Sync views are not showing, the toolbar moves to the SCM view container titlebar, and the callback of a command contributed to that menu does not receive the instance as a parameter. In other circumstances the command callback does receive the parameter. Repro: source-control-sample, build it and run it. Follow its README steps to get it contributing to the SCM view container. for the zap icon this branch adds to scm/title. it when that menu is not merged to the view container window because another view is visible too. Note the message in the modal information dialog, then dismiss it. the other view(s) and click zap again. The message is different. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-20T05:34:58.027Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Looks like this was previously reported in and subsequently fixed. are you also seeing this regression? For me it's also broken in 1.83, so not a reason to hold up the current iteration.
thank you very much for the detailed repro steps. I am also able to reproduce this the commands that the extension contributes to the menu.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
"--zoom-factor", "--test-bar-width" ] <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Repro: Use a theme that has the editor as a different color to the panel Print a json object to an output channel !
Hi thank you for posting this issue. It is a bit unclear from the screen-shot what the expected output should be. Are you referring to what looks like the terminal sticky scroll?
that's output (monaco) sticky scroll, not terminal. The bottom has a dark sticky scroll color and looks odd when the panel background is different to the editor.
I see better now thanks. I'll look into setting a different background color depending on if the editor is a simple one or inside of the output view.
I am investigating how to detect if a specific editor is the editor in the output view. I was initially considering looking at the classList to find if or is there, but the editor dom node class list appears to be undefined for the output view. I was wondering if there is perhaps another way to detect this?
I am not aware of a method to get the editor of the output view, but it should be easy to add: Is that what you need?
Ah maybe I can directly access the editor of the output view pane and verify that the current editor is equal to this editor maybe?
But you are inside an editor contribution or? Not sure how that would work given layering violations.
Yes that's right the change would be inside of the file which is a contribution. I'll think more about how to detect the type of the current editor
Not sure if it helps, but we can control the options we pass in to the editor for output and do so here:
It's a bit of a tricky problem if you want this to work well across all themes. You probably need to support null or transparent values for the bg and hover bg keys and then resolve the colors manually into opaque colors by combining them with the bg color underneath. This might be the right internal API to do that?
I was investigating the uri of the output editor, and noticed it has a scheme equal to 'output'. I can just use it in order to detect if the current editor is an output view editor and change the background accordingly.
Change:
case ITermOscPt.SetMark: { this._createOrGetCommandDetection(this._terminal).handleGenericCommand({ genericMarkProperties: { disableCommandStorage: true } }); } <ins> default: { // Checking for known `<key>=<value>` pairs. const { key, value } = this._parseKeyValueAssignment(command); if (value === undefined) { // No '=' was found, so it's not a property assignment. return true; } switch (key) { case ITermOscPt.CurrentDir: // Encountered: `OSC 1337 ; CurrentDir=<Cwd> ST` this._updateCwd(value); return true; } } </ins> } <ins> // Unrecognized sequence return false; } private _doHandleSetWindowsFriendlyCwd(data: string): boolean { if (!this._terminal) { return false; } const [command, ...args] = data.split(';'); switch (command) { case '9': // Encountered `OSC 9 ; 9 ; <cwd> ST` if (args.length) { this._updateCwd(args[0]); } return true; } // Unrecognized sequence return false; } /** * Handles the sequence: `OSC 7 ; scheme://cwd ST` */ private _doHandleSetCwd(data: string): boolean { if (!this._terminal) { return false; } const [command] = data.split(';'); // We need to manually make sure the given URI is not merely `file://` because The `URI.parse` handles it // exactly as it handles `file:///` (which is a valid URI for us here). if (command.startsWith('file://') && command.length > 7) { const uri = URI.parse(command); if (uri.path && uri.path.length > 0) { this._updateCwd(uri.path); return true; } } </ins> // Unrecognized sequence return false; }

Discussion:
Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
On Windows Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one ()
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .

Part of We want to support other common shell integration sequences as fallbacks to the VS Code specific one () Code pointer:
I'm taking this.
sounds good
I've just submitted the PR. You can check it anytime you want.
can you add verification steps for this?
Disable shell integration Open pwsh 7+ Run the following: It should change the terminal tab's description to .
Change:
renderedMarkdown = elements.map(e => typeof e === 'string' ? e : e.outerHTML).join(''); } <del> element.innerHTML = sanitizeRenderedMarkdown(markdown, renderedMarkdown) as unknown as string; </del> <ins> const htmlParser = new DOMParser(); const markdownHtmlDoc = htmlParser.parseFromString(sanitizeRenderedMarkdown(markdown, renderedMarkdown) as unknown as string, 'text/html'); markdownHtmlDoc.body.querySelectorAll('img') .forEach(img => { if (img.src) { let href = _href(img.src, true); try { const hrefAsUri = URI.parse(href); if (options.baseUrl && hrefAsUri.scheme === Schemas.file) { // absolute or relative local path, or file: uri href = resolvePath(options.baseUrl, href).toString(); } } catch (err) { } img.src = href; } }); element.innerHTML = sanitizeRenderedMarkdown(markdown, markdownHtmlDoc.body.innerHTML) as unknown as string; </ins> // signal that async code blocks can be now be inserted signalInnerHTML!();

Discussion:
Version: 1.62.0-insider (Universal) Commit: Date: 2021-10-28T05:14:00.367Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin arm64 20.6.0 Setting , on the markdown document of a completion item, an tag cannot load a PNG file if the path given as a URI with . If the path given as the path of a local filesystem, it can load the file. Steps to Reproduce: one of images cannot be loaded. !
Can I pick this up?
Sure, the relevant code where we fix image paths is:
For the markdown syntax images, if the URI schema is , that's being changed to . For the HTML tag images, the file URI remains as is. The HTML image with URI doesn't load due to CSP violation.
Yes uris are blocked for security reasons. The problem is that raw html tags don't go through the transform that I linked to One thing to try would be to look for image nodes in the rendered markdown and then transform their uris instead of relying on the markdown parser to handle the transform. Try looking at for that
/verified
Change:
const model = ref.object.textEditorModel; <del> const formatEdits = await getDocumentFormattingEditsUntilResult( </del> <ins> const formatEdits = await getDocumentFormattingEditsWithSelectedProvider( </ins> editorWorkerService, languageFeaturesService, model, <del> model.getOptions(), </del> <ins> FormattingMode.Explicit, </ins> CancellationToken.None );

Discussion:
Related: Looking into reports of X formatter being used instead of Y in various flows. Looking at both on save and on execution formatting participants, one common point is that when is specifically being used, the intended formatter is applied as expected. Some early digging is pointing to a use of instead of , so will be working out a fix there. Will update this thread as is relevant.
do you have some minimal verif steps?
Verification Steps: Install Black Formatter + Ruff Create with only the following:create notebook with a single code cell, and contents In Stable () Save Notebook Black formatter runs =nothing changes Ruff formatter runs =Single quotations turned to double quotations () In Insiders () Save Notebook ONLY Black formatter runs =nothing changes

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a "Formatting with autopep8" message in the status bar even though that formatter extension isn't installed! However manually triggering "Format Cell" does use black.
Change:
pub mod code_server; pub mod dev_tunnels; pub mod legal; <ins> pub mod local_forwarding; </ins> pub mod paths; pub mod protocol; pub mod shutdown_signal; pub mod singleton_client; pub mod singleton_server; <del> pub mod local_forwarding; mod wsl_detect; </del> mod challenge; mod control_server; mod nosleep;

Discussion:
This used to work on the same machine however. Not sure when it stopped. Or why.
Please run
that worked! Wonder if the CLI should do it automatically?
BTW I also noticed how it returns exit code 0 (success) even when it failed like that. Perhaps you should avoid just issuing a warning in case some of these operations fails.
Thanks a ton,
Change:
if (e.clipboardData) { return true; } <del> if ((<any>window).clipboardData) { return true; } </del> return false; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No --- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: --- OS Version: --- monaco-editor version: 0.28.0 Hi. I have an issue with part of code inside monaco-editor's build code inside this particular file: I opened issue here (rather that monaco-editor's repository) because I found the code inside vscode's source code. There is a code snippet that goes like . (inside as ) Which is probably there because of IE-support reasons. But as you may know there is a security vulnerability reported for that small code snippet. is an alert. My problem arises from the point that I deployed my web application which included monaco-editor. It was all perfect, until I received a message that said the page that includes monaco-editor is not loading. I double checked my website, it was fine everywhere. It worked. For debugging, I went to the organization that I received the message from. It did not work inside the organization. After hours of debugging I found out the IPS of the organization is preventing the file from arriving into the company's network. My issue was resolved with simply removing every usage of from the build code and serving it from my server (instead of using a CDN), because my web application did not need IE support. Later I found that doing simply like this would trick that particular IPS too: That particular IPS may let this code through; but other IPSs may not! So I'm here with this issue maybe you can do something about it to prevent further problems like this for anyone else to happen.

You can gain more information about the security vulnerability by searching this message: HTTP BROWSER Microsoft Internet Explorer improper copy buffer access information disclosure attempt And here is the problematic code inside vscode's source code:
According to this: What about IE 11 support? The Monaco Editor no longer supports IE 11. The last version that was tested on IE 11 is 0.18.1. So I think it would be safe to remove everything that uses . I would be happy to do it if confirmed.
verified in code
Change:
}); } <del> run(accessor: ServicesAccessor, editor: ICodeEditor): void { const outerEditor = getOuterEditorFromDiffEditor(accessor); </del> <ins> run(accessor: ServicesAccessor): void { const outerEditor = this.outerEditor ?? getOuterEditorFromDiffEditor(accessor); </ins> if (!outerEditor) { return;

Discussion:
Found while working on a file tracked by git and make two distinct changes in separate lines the same file on the other side the dirty diff gutter marker on each of the editors to open the dirty diff views the outer editor on the right-hand side the action on the left-hand side dirty diff editor The right-hand side dirty diff editor jumps to the next change !