jiebi/CodeConvo huggingface dataset:
Change:
import { CodeActionKind } from 'vs/editor/contrib/codeAction/common/types'; import * as nls from 'vs/nls'; import { ConfigurationTarget, IConfigurationService } from 'vs/platform/configuration/common/configuration'; <del> import { ConfigurationScope, Extensions as ConfigurationExtensions, IConfigurationPropertySchema, IConfigurationRegistry, overrideIdentifiersFromKey, OVERRIDE_PROPERTY_REGEX } from 'vs/platform/configuration/common/configurationRegistry'; </del> <ins> import { ConfigurationScope, Extensions as ConfigurationExtensions, IConfigurationPropertySchema, IConfigurationRegistry, IRegisteredConfigurationPropertySchema, overrideIdentifiersFromKey, OVERRIDE_PROPERTY_REGEX } from 'vs/platform/configuration/common/configurationRegistry'; </ins> import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IMarkerData, IMarkerService, MarkerSeverity, MarkerTag } from 'vs/platform/markers/common/markers';

Discussion:
Add an unrecognized setting to See that it is correctly dimmed with no warning underline Add it to a language-specific settings block There is a warning, "This setting does not support per-language configuration which is misleading" !
Yeah, this feature is not supported for language specific settings.
To verify: Open and have following snippetMake sure first two settings and are shown dimmed with proper message.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
import { Lazy } from 'vs/base/common/lazy'; import { Disposable, IDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { basename, extname, isEqual } from 'vs/base/common/resources'; <ins> import Severity from 'vs/base/common/severity'; </ins> import { URI } from 'vs/base/common/uri'; import { generateUuid } from 'vs/base/common/uuid'; import { RedoCommand, UndoCommand } from 'vs/editor/browser/editorExtensions'; import * as nls from 'vs/nls'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <ins> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; </ins> import { EditorActivation, IEditorOptions, ITextEditorOptions } from 'vs/platform/editor/common/editor'; import { FileOperation, IFileService } from 'vs/platform/files/common/files'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';

Discussion:
Testing new untitled file and add some text. Editor: Open File The original untitled file is left open and changes in the Hex Editor are not reflected in that original file. !
This will be fixed by
Change:
flex-grow: 0; } <del> .monaco-editor .merge-accept-conflict-glyph { cursor: pointer; } .merge-editor-modified-base-range-input1 { background-color: var(--vscode-mergeEditor-modifiedBaseRange-input1); } .merge-editor-diff-input1 { background-color: var(--vscode-mergeEditor-diff-input1); } .merge-editor-modified-base-range-input2 { background-color: var(--vscode-mergeEditor-modifiedBaseRange-input2); } .merge-editor-diff-input2 { background-color: var(--vscode-mergeEditor-diff-input2); } .merge-editor-modified-base-range-combination { background-color: var(--vscode-mergeEditor-modifiedBaseRange-combination); </del> <ins> .merge-editor-diff { background-color: var(--vscode-mergeEditor-diff); </ins> } <del> .merge-editor-modified-base-range { background-color: var(--vscode-mergeEditor-diff); </del> <ins> .merge-editor-diff-word { background-color: var(--vscode-mergeEditor-diff-word); </ins> } .merge-editor-block { <del> border: 2px solid rgba(255, 166, 0, 0.479); </del> <ins> border: 2px solid var(--vscode-mergeEditor-conflictBorder-unhandledUnfocused); </ins> } <del> .merge-editor-block.active { border: 2px solid orange; </del> <ins> .merge-editor-block.focused { border: 2px solid var(--vscode-mergeEditor-conflictBorder-unhandledFocused); </ins> } .merge-editor-block.handled { <del> border: 2px solid rgba(134, 134, 134, 0.285); </del> <ins> border: 2px solid var(--vscode-mergeEditor-conflictBorder-handledUnfocused); </ins> } <del> .merge-editor-block.handled.active { border: 2px solid rgb(134, 134, 134, 0.8); } .merge-editor-block.handled.active { border: 2px solid rgba(193, 193, 193, 0.8); </del> <ins> .merge-editor-block.handled.focused { border: 2px solid var(--vscode-mergeEditor-conflictBorder-handledFocused); </ins> } .gutter-item {

Discussion:
I really like how I can see the word-level change per line now in the merge editor, but shouldn't the colors be identical to the diff editor? !
I agree the new color needs to be tweaked. Would you also use the green background?
I think making this look as close as a diff editor if possible would be nice because I am so used at looking at diffs with their color coding. //cc
Change:
const lineNumber = this._commentThread.range.endLineNumber; let shouldMoveWidget = false; if (this._commentGlyph) { <ins> this._commentGlyph.setThreadState(commentThread.state); </ins> if (this._commentGlyph.getPosition().position!.lineNumber !== lineNumber) { shouldMoveWidget = true; this._commentGlyph.setLineNumber(lineNumber);

Discussion:
Comments in the editor have a different color based on their resolved status. We could do something similar for the icon in the gutter, and make obvious which comment is resolved even when comments are folded. Maybe change the icon color? Or use a different icon? (also related to )
Example of how it currently looks: ! Example with adjusted colours: ! Note that colour alone is not a full solution since it is not that accessible, but I think it should be included in the final solution.
A different icon/unicode character for resolved would be good here.
Let's get done first.
Change:
} p { <del> margin-bottom: 0.7em; </del> <ins> margin-bottom: 16px; </ins> } ul,

Discussion:
Here are our headers (left) compared with GitHub's (right): <img width="649" alt="image" src=""Things to note: H2 still has a bottom border in GitHub, looks great Our H4 feels very much like plain text, GitHub is definitely larger than plain Our H5 is even smaller than plain text, GitHub is at least in bold cc
Agreed. I've wanted to update these for a while now.
Change:
getResults(input: string): TPromise<IModel<IExtensionEntry>> { if (!this.modelPromise) { <del> this.modelPromise = this.extensionManagementService.getInstalled() .then(extensions => this.instantiationService.createInstance(LocalExtensionsModel, extensions)); </del> <ins> this.modelPromise = TPromise.join<any>([this.extensionManagementService.getInstalled(), getOutdatedExtensions(this.extensionManagementService, this.galleryService)]) .then(result => this.instantiationService.createInstance(LocalExtensionsModel, result[0], result[1])); </ins> } return this.modelPromise.then(model => {

Discussion:
from If you select "Show Installed Extensions" you won't see the update button but if you select "Install Extension" and search for an already installed extension that has a newer version available, the update button is visible. Is this part of this bug or is this something else? Install Extension: ! Show Installed Extensions: !
Change:
firstLineDecorationClassName: ThemeIcon.asClassName(foldingManualCollapsedIcon) }); <del> private static readonly EXPANDED_AUTO_HIDE_VISUAL_DECORATION = ModelDecorationOptions.register({ description: 'folding-expanded-auto-hide-visual-decoration', stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges, isWholeLine: true, firstLineDecorationClassName: ThemeIcon.asClassName(foldingExpandedIcon) </del> <ins> private static readonly NO_CONTROLS_COLLAPSED_RANGE_DECORATION = ModelDecorationOptions.register({ description: 'folding-no-controls-range-decoration', stickiness: TrackedRangeStickiness.AlwaysGrowsWhenTypingAtEdges, afterContentClassName: 'inline-folded', isWholeLine: true }); private static readonly NO_CONTROLS_COLLAPSED_HIGHLIGHTED_RANGE_DECORATION = ModelDecorationOptions.register({ description: 'folding-no-controls-range-decoration', stickiness: TrackedRangeStickiness.AlwaysGrowsWhenTypingAtEdges, afterContentClassName: 'inline-folded', className: 'folded-background', isWholeLine: true </ins> }); private static readonly EXPANDED_VISUAL_DECORATION = ModelDecorationOptions.register({

Discussion:
Expected: only gutter controls are removed, background and ellipsis - preserved Actual: The background color no longer applied & the ellipsis is missing on the folded lines.VS Code Version: 1.70.0 (user setup) OS Version: Windows_NT x64 10.0.
Change:
width: 100%; top: calc(50% + 55px); text-align: center; <ins> white-space: nowrap; </ins> } .monaco-workbench > .part.editor > .watermark > .watermark-box {

Discussion:
!
Could you take a look? Not sure what the best fix is here.
in the parent solves it.
is not a documented value for : seems to do it.
I meant . might work, but it could still overflow.
And still does: !
What are the steps to reproduce that?
Reduce the window size. In dev tools select the element. In the console type . Scroll can be messed around due to unexpected situations, like . Please use .
Not sure how likely that situation is to occur. Should this go into the September release?
No no, not September.
I still can repro this !
It doesn't appear to overflow anymore, though.
Oh I see - I misunderstood what the bug was.
Change:
} public isReadonly(): boolean { <del> return false; </del> <ins> return true; </ins> } public dispose(): void {

Discussion:
Edit a file tracked by Git Stage the file In the SCM viewlet, click the file in the "staged" section to open an editor that says Type in the file In 1.24.1, I can't edit it because it's a read-only editor In 1.25, I can type in the editor, but changes aren't actually written anywhere. If I switch away from the file and switch back, they are gone
please review
thanks for the fix, I will review it now.
Merged pr, closing
Change:
import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; import { IEditorOptions as ICodeEditorOptions } from 'vs/editor/common/config/editorOptions'; import { ICodeEditorViewState, ScrollType } from 'vs/editor/common/editorCommon'; <ins> import { ITextModel } from 'vs/editor/common/model'; </ins> import { ITextResourceConfigurationService } from 'vs/editor/common/services/textResourceConfiguration'; import { localize } from 'vs/nls'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

Discussion:
Does this issue occur when all extensions are disabled?: Yes Word wrap doesn't affect the text of the base in the merge editor, regardless of whether the base is displayed in the center or at the top. Steps to reproduce: a branch with a conflict the merge editor word wrap Base in the center ! Base at the top ! Version: 1.76.0-insider (system setup) Commit: Date: 2023-02-09T05:23:28.458Z OS: Windows_NT x64 10.0. Sandboxed: Yes
I'll pick this up
Change:
for (var i = 0, len = this._secondaryCursors.length; i < len; i++) { this._secondaryCursors[i].render(ctx); } <del> if (this._canUseTranslate3d) { this._domNode.setTransform('translate3d(0px, 0px, 0px)'); } else { this._domNode.setTransform(''); } </del> } }

Discussion:
VSCode Version: 1.3.0-Insider OS Version: MacOSX 10.11.5 Steps to Reproduce: document with long lines (longer then screen width to the right and move the cursor to accordingly -Cursor is invisible
Unless I'm misunderstanding the issue, this is expected behaviour. How would you expect the editor to behave? This happens on every editor. If you'd like your long line to wrap, you can control that by setting the configuration to .
No, this has nothing to do with wrapping long lines. My cursor is literally invisible: !
Interesting, but I still can't reproduce... Can you provide a screencast or similar?
Where is your focus? The cursor blinks/is rendered only when the editor is focused
I tried reproducing it with new files, but I'm unable to. This happens with a few xsl files at work. I'll try to see if I can get a 100% reproducible file. The focus is in the active editor. I'm only moving the cursor to the right. Screencast: ! EDIT: The cursor is only visible for as long as it doesn't surpass the last character that was visible in the initial view region of the editor
Thank you for the gif! I've never seen that before. Do you see any errors in the console () ? I've quickly tried with a file with these contents but could not reproduce: Other things that might be relevant: does this reproduce when running code without extensions (close it completely and launch with ), did you customize the font and/or picked a different theme?
I found a way to reliably reproduce this issue. The missing piece was, that it only happens when you have split the main editor. I can't reproduce it with just one editor visible. Launching with doesn't help. I did try with the default user settings and theme as well, but without success. I managed to nail it down to the following steps to reproduce this issue: vscode random file (doesn't matter) the editor with (this is important) random code/text with long lines in one of the 2 editor panels
Forgot to mention: unfortunately there are no errors in the devtools console.
I'm also seeing this issue. VS Code 1.3.0 commit Windows 10.0.

Edit: Oops, didn't notice that a fix was already committed yesterday.
can you try my solution in ?
Yes, but disabling extensions doesn't help. This issue only occurs when you have more than a single editor view. See:
We decided to fix this by removing the property from the tabs container. The visual impact is that if you use a theme that introduces a custom background color, it will only be picked up for the active tab. E.g. for our themes "red" and "abyss": ! ! To verify: be on windows have 2 groups open at least have enough tabs open to cause scrolling activate a tab that is at the end of the tab list in group one find a long line and arrow right verify the cursor is not lost
can I ask you to verify this on Windows using this 1.3.1 stable build: Thanks!
I verified this.
Change:
this._contentWidget?.goToBottom(); } <del> public escape(): void { this._contentWidget?.escape(); } </del> public isHoverVisible(): boolean | undefined { return this._contentWidget?.isVisible(); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Insiders Version: VS Code Version: OS Version: Ubuntu 22.04.2 LTS Steps to Reproduce: This issue is identical to which was supposedly fixed by . I do not have a windows machine atm, so I cannot test if this is exclusively an issue with the snap-installed version of vscode, but I highly doubt it is. does give focus back to editor, but that's just a workaround.
Hi thanks for filing the issue. It appears this is a regression from the previous work done on making the hover resizable. A fix will be made.
Change:
registerAction2(ResetToBaseAndAutoMergeCommand); registerAction2(AcceptMerge); <ins> registerAction2(ResetCloseWithConflictsChoice); </ins> // Dev Commands registerAction2(MergeEditorCopyContentsToJSON);

Discussion:
a conflict file in 3 way merge the 3 way merge editor Notice dialog ! I do not think we have a need for this dialog any more since we are no longer removing the conflict markers. Thus the user can just close this dialog, there is no data loss? Similarly when the user closes the old editor with conflict markers we do not prompt. fyi
I don't have an opinion about this.
I would leave it for the clarity it creates, however I am open for a "don't ask again" option
"Don't ask again" works for me, especially since I just noticed that when some conflicts get resolved the dialog is "smarter". Would don't ask again write in storage or a setting? I am fine going loco and writing to storage (so users can not revert). Though if all the other "don't ask again" write in settings then I guess I am fine with that.
+1 for "Don't ask again"
Fyi there is a very practical use case for the dialog: if you run with and use VSCode as Git merge editor, you may actually want to resolve the conflicts before closing the editor because Git somewhat expects you to do so. On top of that, given , we currently cannot pass back an exit code to Git, so it helps showing a dialog to avoid returning back to Git with merge conflicts still in the file. Besides, we show a similar dialog when you try to stage a file that has merge conflicts from the SCM view: !
thanks for providing more info, I missed that case. Though I think it does not conflict with our idea to add "Don't Ask Again".
Can we tell the merge editor if it was opened in a modal context (like with --wait)?
Currently not, an editor has no knowledge that it is being utilised for . There is plumbing around the editor where we observe the opened editor for being closed and then delete the wait marker file. Can we get more user feedback on this before jumping onto a conclusion?
Verify that there is an option to not be asked again there is a "Reset Choice for Close with Conflicts" commands in the F1 list <img width="1405" alt="Screenshot 2022-11-25 at 15 24 27" src="https://user-"
Adding verified since this works as expected. Noticed one minor "glitch".

"Don't ask again" Cancel The "Don't ask again" choice will be preserved. It should probably be only preserved if I click on "Close with Conflicts". I am not supper passionate about this, but let me know if you would like me to file an issue
Change:
import { localize } from 'vs/nls'; import { IMenuService, MenuId, IMenu, SubmenuItemAction, registerAction2, Action2, MenuItemAction, MenuRegistry } from 'vs/platform/actions/common/actions'; import { MenuBarVisibility, getTitleBarStyle, IWindowOpenable, getMenuBarVisibility } from 'vs/platform/window/common/window'; <del> import { ContextKeyExpr, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </del> <ins> import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> import { IAction, Action, SubmenuAction, Separator, IActionRunner, ActionRunner, WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification } from 'vs/base/common/actions'; import { addDisposableListener, Dimension, EventType } from 'vs/base/browser/dom'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';

Discussion:
In the recent Edit Sessions UX study we ran, we saw several participants searching in vain for the terminal item in the compact menu on , sometimes for minutes: ! Could we consider bringing it back? I'm guessing we intentionally suppressed it because terminals can't run in the web, but participants were simply confused that it wasn't there without connecting its absence to the fact that was a browser application. Additionally, RemoteHub contributes a welcome view for the terminal which is one of the primary ways we explain that users must continue working elsewhere to run or debug code, and the fact that the terminal is completely suppressed means one less opportunity for users to organically learn the limitations of through our welcome views. ! cc
Yes that is why it was removed. It doesn't do much but if it helps reduce confusion I guess it's worth it?
Not against the idea of having the terminal menu in web but in its current form it's useless and doesn't allow me to actually show a terminal pane, it just deadends all over https://user-
Reverting in
when I enable the menu again and fix up the terminal command, the run/customize task items give this on the scripts/code-web sample-folder: <img width="1229" alt="image" src="https://user-"That does actually run, not sure what it's doing exactly though. Is that a custom execution task running in the web worker ext host? If so you might need a context key on those menu items to only show them when a custom execution task is registered?
Unless I'm missing something, I believe only registered tasks will show there - if they're running when you select them, then I don't think there's an issue.
I think there's a built-in fake task when running code-web is what I mean, when run in actual then running it might do nothing. In that case it should hide similar to how we're changing the behavior of New Terminal depending on whether extension contributed profiles exist
Change:
'libc.so.6()(64bit)', 'libc.so.6(GLIBC_2.17)(64bit)', 'libcairo.so.2()(64bit)', <del> 'libcups.so.2()(64bit)', </del> 'libcurl.so.4()(64bit)', 'libdbus-1.so.3()(64bit)', 'libdbus-1.so.3(LIBDBUS_1_3)(64bit)',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.1 OS Version: Gentoo Linux Starting with 1.72, vscode has a hard dependency on a printing library, otherwise it refuses to even start. CUPS is quite a heavy dependency and not all Linux installations have it. This is a bug for two reasons: does not even support printing () then, such heavy libraries shall be only loaded on demand.
So, can you arrange with electron to not include the dependency on a heavy printing library? Nobody has printers these days.
Do you know which vscode release is going to start using Electron 22?
Verified with
Change:
case PConst.Kind.memberSetAccessor: return vscode.CompletionItemKind.Field; case PConst.Kind.function: <ins> case PConst.Kind.localFunction: </ins> return vscode.CompletionItemKind.Function; case PConst.Kind.memberFunction: case PConst.Kind.constructSignature:

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: Ubuntu 19.10 The is ! The is ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.524 --<!-- potentialduplicatescomment --