jiebi/CodeConvo huggingface dataset:
Change:
// menu if (Array.isArray(menu)) { for (const item of menu) { <del> disposables.add(MenuRegistry.appendMenuItem(item.id, { command, ...item })); </del> <ins> disposables.add(MenuRegistry.appendMenuItem(item.id, { command: { ...command, precondition: item.precondition === null ? undefined : command.precondition }, ...item })); </ins> } } else if (menu) { <del> disposables.add(MenuRegistry.appendMenuItem(menu.id, { command, ...menu })); </del> <ins> disposables.add(MenuRegistry.appendMenuItem(menu.id, { command: { ...command, precondition: menu.precondition === null ? undefined : command.precondition }, ...menu })); </ins> } if (f1) { disposables.add(MenuRegistry.appendMenuItem(MenuId.CommandPalette, { command, when: command.precondition }));

Discussion:
Type: <bBug</b- VS Code Version: 1.74.1 OS Version: Windows NT x64 10.0. Issue appeared just after upgrading VSCode to ver. 1.74.1 Currently, it is impossible to go to the function definition by clicking Ctrl+Click on the function name or using the F12 button. Also, the Go to definition option in Top Menu-Go-Go to Definition is disabled. VS Code version: Code 1.74.1 (, 2022-12-14T10:30:51.966Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
What code language? Is the option also disabled in the context menu? was a previous issue about this and related options not getting enabled in the top-level Go menu. Maybe this has come back. Do you think this didn't happen in 1.74.0?
- maybe caused by
Yeah, looks like the precondition for the command is too strong
Javascript I don't have such an option in the context menu I'm not 100% sure, which version I had previously installed, but I'm using VSCode almost every day, so I'm pretty sure I was using 1.74.0 or 1.73.1, and that behavior has occurred after auto-upgrade to 1.74.1. I've never noticed anything like it before.
After a clean uninstall (Uninstalled and deleted %APPDATA%Code and %USERPROFILE%.vscode), and installing 1.74.1 again, the problem does not occur anymore.
Change:
import { AuthenticationSession, AuthenticationSessionsChangeEvent, IAuthenticationService } from 'vs/workbench/services/authentication/common/authentication'; import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; import { EDIT_SESSIONS_SIGNED_IN, EditSession, EDIT_SESSION_SYNC_CATEGORY, IEditSessionsWorkbenchService, EDIT_SESSIONS_SIGNED_IN_KEY, IEditSessionsLogService } from 'vs/workbench/contrib/editSessions/common/editSessions'; <ins> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; </ins> import { generateUuid } from 'vs/base/common/uuid'; type ExistingSession = IQuickPickItem & { session: AuthenticationSession & { providerId: string } };

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --
Change:
const activeGroup = editorGroupsService.activeGroup; activeGroup.replaceEditors([{ editor: activeEditor, <del> replacement: instantiationService.createInstance(GettingStartedInput, { selectedCategory: selectedCategory, selectedStep: selectedStep }) </del> <ins> replacement: instantiationService.createInstance(GettingStartedInput, { selectedCategory: selectedCategory, selectedStep: selectedStep, showWelcome: false }) </ins> }]); } else { // else open respecting toSide <del> const options: GettingStartedEditorOptions = { selectedCategory: selectedCategory, selectedStep: selectedStep, preserveFocus: toSide ?? false }; </del> <ins> const options: GettingStartedEditorOptions = { selectedCategory: selectedCategory, selectedStep: selectedStep, showWelcome: false, preserveFocus: toSide ?? false }; </ins> editorService.openEditor({ resource: GettingStartedInput.RESOURCE, options

Discussion:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.
Change:
KeybindingsRegistry.registerKeybindingRule({ id: `^${PASTE_FILE_ID}`, // the `^` enables pasting files into the explorer by preventing default bubble up weight: KeybindingWeight.WorkbenchContrib + explorerCommandsWeightBonus, <del> when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerResourceNotReadonlyContext), </del> <ins> when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerResourceNotReadonlyContext, WorkbenchTreeFindOpen.toNegated()), </ins> primary: KeyMod.CtrlCmd | KeyCode.KeyV, });

Discussion:
Sometimes "Paste" fails: The file(s) to paste have been deleted or moved since you copied them. TreeError [FileExplorer] Tree element not found: [object Object] Maybe should be disabled for as long as we do not update properly.
Change:
import { IRemoteAgentService } from 'vs/workbench/services/remote/common/remoteAgentService'; import { ACTIVE_GROUP, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService'; import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> export class TerminalService implements ITerminalService { declare _serviceBrand: undefined;

Discussion:
From Run the command Enter: In the eventual modal dialog, press Expecting a window reload, but there is an error instead. You can also call the command I debugged it down to veto from terminal. Exception thrown while serializing the terminal: The veto hander should handle all exceptions and return false, unless it really wants to veto the window close.
Closing for verification as it looks like this has been merged into release/1.62
Remote connection is going in a restarting loop. Restart remote connection is the only thing that we are getting now. Not possible to work at all with vscode.
Change:
<meta charset="UTF-8"> <meta http-equiv="Content-Security-Policy" <del> content="default-src 'none'; script-src 'sha256-xgIcbQmGjpT42GEj54VFSNh6MI15PZ2D1+DdVehfYBI=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </del> <ins> content="default-src 'none'; script-src 'sha256-v9xEHcwDE5dc/lU7HYs5bG3LpPWGmQe0w/Vz6kmdd60=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </ins> <!-- Disable pinch zooming --> <meta name="viewport"

Discussion:
As discussed in , we should let webviews make decisions based on the high contrast theme type. Proposed by cc
How should this be verified?
I think this can be verified by checking the style of the body in a webview? Here's one in stable with high-contrast light theme enabled: ! Here's the same one in insiders with same theme enabled: ! It would allow CSS rules based on the body having that class.
So something like so?
/verified Yeah that works for me. I used the webview-view-sample.
Yeah, in the webview ui toolkit so, hopefully, the vscode-high-contrast-light theme would be reflected there as well.
Which actually now that I look at screenshots more closely, it already is being reflected on the attribute
Also confirmed this works when working on a fix for the webview toolkit last week
Change:
<key>comment</key> <string>$var, $local:var</string> <key>match</key> <del> <string>($)((?i:global|local|script|private|using|env|function|alias|cert|variable|hkcu|hklm|wsman):)?(w+)(:w+)?((.[w"']+)*)</string> </del> <ins> <string>($)((?i:global|local|script|private|using|env|function|alias|cert|variable|hkcu|hklm|wsman):)?(w+)(:w+)?((.[w"'- @#]+)*)</string> </ins> </dict> <dict> <key>captures</key>

Discussion:
VSCode Version: Code 1.3.0 (, 2016-07-07T16:56:12.476Z) OS Version: Windows_NT ia32 6.3.9600 Steps to Reproduce: a powershell script an object with a property that has a space, such as $obj."Property with space" highlight for the quotes doesn't display properly.
This should be fixed soon I think. CC
That's correct. This bug is fixed in
I noticed a similar effect with this: ! With VSCode Version 1.3.1 on a Windows7 64Bit system.
Similar issue as ! VSCode Version 1.3.1 on Windows10 64Bit
Change:
return this.model.getNode(location); } <ins> getNodeLocation(node: ITreeNode<T, TFilterData>): TRef { return this.model.getNodeLocation(node); } </ins> collapse(location: TRef, recursive: boolean = false): boolean { return this.model.setCollapsed(location, true, recursive); }

Discussion:
This is a follow-up on and where I simply make the model-property of the tree public. Tho, a better fix might be needed here
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Uri, Event, Disposable, ProviderResult, Command, CancellationToken, ThemeIcon } from 'vscode'; </del> <ins> import { Uri, Event, Disposable, ProviderResult, Command, CancellationToken } from 'vscode'; </ins> export { ProviderResult } from 'vscode'; export interface Git {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Unused import from from in
bruh
Change:
renderCompressedElements(node: ITreeNode<ICompressedTreeNode<FolderMatch>, any>, index: number, templateData: IFolderMatchTemplate, height: number | undefined): void { const compressed = node.element; const folder = compressed.elements[compressed.elements.length - 1]; <ins> folder.compressionStartParent = compressed.elements[0]; </ins> const label = compressed.elements.map(e => e.name()); if (folder.resource) {

Discussion:
Testing Open in VS Code Insiders Search for "containers" Exploring results and collapsing/uncollapsing works for a while :bug: Then "Collapse All" does nothing !
It seems I'm able to repro by: Reload window from above state Search for "containers" again, works correctly "Collapse All," works correctly Uncollapse, works correctly Try "Collapse All" again, stuck in unresponsive state above
Actually seems I misread the button - I guess it's always "Collapse All" and doesn't become an option to uncollapse. I was confused since hitting collapse two times in a row changes the search results, so I assumed it was collapsing and then uncollapsing. Not sure if this is expected: ! I've renamed the issue to be reflective of what I actually experienced. If this is expected, please feel free to close. Sorry for confusion!
No, that's totally a bug , it shouldn't get stuck like that. Thanks for catching that!
Change:
], "indentationRules": { "increaseIndentPattern": "^s*((begin|class|(private|protected)s+def|def|else|elsif|ensure|for|if|module|rescue|unless|until|when|in|while|case)|([^#]*sdob)|([^#]*=s*(case|if|unless)))b([^#{;]|("|'|/).*4)*(#.*)?$", <del> "decreaseIndentPattern": "^s*([}]]([,)]?s*(#|$)|.[a-zA-Z_]w*b)|(end|rescue|ensure|else|elsif)b)|((in|when)s)" </del> <ins> "decreaseIndentPattern": "^s*([}]]([,)]?s*(#|$)|.[a-zA-Z_]w*b)|(end|rescue|ensure|else|elsif|when|in)b)" </ins> } }

Discussion:
Originally from
This was originally introduced in and already has a fix via However since the fix is late, we may want to revert the indentation rules change for stable release.
closedWith
Change:
@IExtensionManagementService private readonly extensionManagementService: IExtensionManagementService, @IWorkbenchExtensionEnablementService private readonly extensionEnablementService: IWorkbenchExtensionEnablementService, @INativeWorkbenchEnvironmentService private readonly environmentService: INativeWorkbenchEnvironmentService, <ins> @IWorkspaceTrustManagementService private readonly workspaceTrustManagementService: IWorkspaceTrustManagementService, </ins> @IProductService private readonly productService: IProductService, @ITASExperimentService private readonly experimentService: ITASExperimentService, @IAuthenticationService private readonly authenticationService: IAuthenticationService

Discussion:
When I report an issue from our issue reporter from an untrusted workspace, there is no info about this in the GH issue.
Marking as important to make sure we care about this before enabling trust by default to not make our life harder for triaging issues than it needs to be.
Two examples: in an effort to make the smallest change this late in the game, I’ve put it in System Info however when you report a performance issue, we also have a section called “Workspace Info” that shows up that gives details on the workspace (like number of files, etc). I think it should eventually go there
lol jk sent a PR putting it next to the OS which I don't love... but the change is small and it means the user can't not tell us their WT situation which is good.
Change:
return null; } <del> private _renderTokenStyleDefinition(definition: TokenStyleDefinition | undefined, property: keyof TokenStyleData): string { </del> <ins> private _renderTokenStyleDefinition(definition: TokenStyleDefinition | undefined, property: keyof TokenStyleData): Array<HTMLElement | string> { const elements = new Array<HTMLElement | string>(); </ins> if (definition === undefined) { <del> return ''; </del> <ins> return elements; </ins> } const theme = this._themeService.getColorTheme() as ColorThemeData;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The next step in resolving . Simirarly to , it aims to replace construction of HTML elements by string concatenation in file. The code contains mainly a table construction by concatenating strings of . The goal is to replace them all with function calls.
I verified by running the monaco editor from source and testing the inspect token hover
To verify, open the hover and verify it looks all proper.
Change:
), original: 'Compare Input 1 With Base', }, <ins> shortTitle: localize('mergeEditor.compareWithBase', 'Compare With Base'), </ins> f1: true, precondition: ctxIsMergeEditor, <ins> menu: { id: MenuId.MergeInput1Toolbar } </ins> }); } run(accessor: ServicesAccessor, ...args: unknown[]): void {

Discussion:
Theirs / Yours title area is currently quite empty. We should consider to add an action bar for "Compare with Base" action. The title area should also have additional Git information in the future fyi !
I don't see a branch or commit id in your screenshot. Is that configured somehow? <img width="533" alt="CleanShot 2022-06-28 at 10 00 52 src="https://user-"In any case, we could introduce a toolbar somewhat like the editor. Icons are placeholder, but an example could look like: <img width="1032" alt="CleanShot 2022-06-28 at 10 05 06 src="https://user-"
Unsure what was seeing there but with the normal git flow we do show the branch names and commits in question. There is also different issue for the toolbar and since today an icon in front of the commit it
To verify open a merge editor verify that it has menus with yours/theirs
Change:
import { lstat, Stats } from 'fs'; import * as os from 'os'; import * as path from 'path'; <del> import { commands, Disposable, LineChange, MessageOptions, OutputChannel, Position, ProgressLocation, QuickPickItem, Range, SourceControlResourceState, TextDocumentShowOptions, TextEditor, Uri, ViewColumn, window, workspace, WorkspaceEdit, WorkspaceFolder } from 'vscode'; </del> <ins> import { Selection, commands, Disposable, LineChange, MessageOptions, OutputChannel, Position, ProgressLocation, QuickPickItem, Range, SourceControlResourceState, TextDocumentShowOptions, TextEditor, Uri, ViewColumn, window, workspace, WorkspaceEdit, WorkspaceFolder } from 'vscode'; </ins> import TelemetryReporter from 'vscode-extension-telemetry'; import * as nls from 'vscode-nls'; import { Branch, GitErrorCodes, Ref, RefType, Status } from './api/git';

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.
We might just have to set the cursor in that position, should be simple. Would you like to submit a PR?
I can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..
Hi, I would like to work on this issue. I'll submit a PR soon.
Do we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.
Sounds good.
Change:
protected abstract getTaskSystem(): ITaskSystem; <del> private async provideTasksWithWarning(provider: ITaskProvider, type: string, validTypes: IStringDictionary<boolean>): Promise<TaskSet> { </del> <ins> private async provideTasksWithWarning(provider: ITaskProvider, type: string, validTypes: IStringDictionary<boolean>): Promise<TaskSet | undefined> { </ins> return new Promise<TaskSet>(async (resolve, reject) => { let isDone = false; <del> provider.provideTasks(validTypes).then((value) => { </del> <ins> let disposable: IDisposable | undefined; const providePromise = provider.provideTasks(validTypes); this._providerProgressManager?.addProvider(type, providePromise); disposable = this._providerProgressManager?.canceled.token.onCancellationRequested(() => { if (!isDone) { resolve(); } }); providePromise.then((value) => { </ins> isDone = true; <ins> disposable?.dispose(); </ins> resolve(value); }, (e) => { isDone = true; <ins> disposable?.dispose(); </ins> reject(e); }); <del> let settingValue: boolean | string[] = this.configurationService.getValue('task.slowProviderWarning'); if ((settingValue === true) || (Types.isStringArray(settingValue) && (settingValue.indexOf(type) < 0))) { setTimeout(() => { if (!isDone) { const settings: IPromptChoice = { label: nls.localize('TaskSystem.slowProvider.settings', "Settings"), run: () => this.preferencesService.openSettings(false, undefined) }; const disableAll: IPromptChoice = { label: nls.localize('TaskSystem.slowProvider.disableAll', "Disable All"), run: () => this.configurationService.updateValue('task.autoDetect', 'off') }; const dontShow: IPromptChoice = { label: nls.localize('TaskSystem.slowProvider.dontShow', "Don't warn again for {0} tasks", type), run: () => { if (!Types.isStringArray(settingValue)) { settingValue = []; } settingValue.push(type); return this.configurationService.updateValue('task.slowProviderWarning', settingValue); } }; this.notificationService.prompt(Severity.Warning, nls.localize('TaskSystem.slowProvider', "The {0} task provider is slow. The extension that provides {0} tasks may provide a setting to disable it, or you can disable all tasks providers", type), [settings, disableAll, dontShow]); } }, 4000); } </del> }); }

Discussion:
We have a temporary fix for the release for but we need to do something better long term.
while working on quick access for tasks I noticed that we seem to be having 2 pickers for the same thing (?): Task quick open: ! "Run Task" picker: ! Is that intentional? Should the one be merged into the other?
Yes, they do not share much code :( as part of improving the quick pick I will converge them.
sounds good, please only change  and leave the other one because I plan to delete those old ones soon.
Change:
}); problemMatcher.onDidFindErrors(() => { if (this._marker) { <del> terminal.addGenericMark(this._marker, { hoverMessage: nls.localize('task.watchFirstError', "First error"), disableCommandStorage: true }); </del> <ins> terminal.addGenericMark(this._marker, { hoverMessage: nls.localize('task.watchFirstError', "Beginning of detected errors for this run"), disableCommandStorage: true }); </ins> } }); problemMatcher.onDidRequestInvalidateLastMarker(() => {

Discussion:
Testing
what would you expect it to say?
I'm not sure exactly. something more verbose like "Beginning of list of errors in output"
How about "Beginning of detected errors for this run"? Can't use something more natural like "compile" or "tests" as a watch/background task could be doing anything
yea i think that's better. yea i started to see the challenge when thinking about it and the fact that it needs to be pretty generic
I am a bit late for this, but what is the reason for the first error message label?
it's a marker in the buffer so you can quickly jump to it via ctrl/cmd+up, this is more useful in tests when using verbose assertions.
Example: !
I'm a little confused about the luminance of the decorations I'm seeing for watch tasks, how is it determined? All three of the following decorations for various problems in a watch task got the same label: ! ! !
there are some issues on windows with the decorations when the terminal gets resized. it looks like a few decorations are getting overlaid in your first and last image
Change:
const viewContainer = this.getViewContainer(panelDescriptor.id); if (viewContainer?.hideIfEmpty) { const viewDescriptors = this.viewDescriptorService.getViewDescriptors(viewContainer); <del> if (viewDescriptors.activeViewDescriptors.length === 0) { </del> <ins> if (viewDescriptors.activeViewDescriptors.length === 0 && this.compositeBar.getPinnedComposites().length > 1) { </ins> this.hideComposite(panelDescriptor.id); // Update the composite bar by hiding } }

Discussion:
Issue Type: <bBug</bI moved all views in panel to sidebar and VSCode crashed the first time I pressed ctrl + j to show panel. I can consistently repro this issue. VS Code version: Code - Insiders 1.44.0-insider (, 2020-04-03T23:31:33.481Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
To Verify: all panels to the sidebar (panel will hide) Ctrl+J that the panel opens to an empty view e.g. (empty Terminal View) and that you do not crash. We will iterate on a better UX next milestone.
I made this change as the safest option for now. If you have a better solution that warrants another fix, please take over. Otherwise, will roll with this.
Yah looks the safest fix for now. Seems panel is not ready to handle no active panels. Is there a follow up issue for this created?
but the panel does handle no active panels if you run the command instead of (<kbdCtrl</kbd+<kbdJ</kbd) !
Yeah there are some issues with it and it is not working always. Hence we did a safe fix for now. We are working on this with proper UX for next milestone.
Change:
color: var(--vscode-scm-historyItemDeletionsForeground); } <ins> .scm-view .monaco-list-row .history-item .stats-container.hidden, .scm-view .monaco-list-row .history-item .stats-container > .insertions-label.hidden, .scm-view .monaco-list-row .history-item .stats-container > .deletions-label.hidden { display: none; } </ins> .scm-view .monaco-list-row .history-item-group .monaco-icon-label .icon-container, .scm-view .monaco-list-row .history-item .monaco-icon-label .icon-container { display: flex;

Discussion:
Testing the commit in the outgoing section Notice the empty square in All Changes <img width="429" alt="image" src=""
Diff statistics badge will always contain the number of files: <img width="474" alt="image" src=""