Change:
default: DEFAULT_LINE_HEIGHT }, [TerminalSettingId.MinimumContrastRatio]: { <del> markdownDescription: localize('terminal.integrated.minimumContrastRatio', "When set the foreground color of each cell will change to try meet the contrast ratio specified. Example values:nn- 1: The default, do nothing.n- 4.5: [WCAG AA compliance (minimum)](https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html).n- 7: [WCAG AAA compliance (enhanced)](https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast7.html).n- 21: White on black or black on white."), </del> <ins> markdownDescription: localize('terminal.integrated.minimumContrastRatio', "When set the foreground color of each cell will change to try meet the contrast ratio specified. Example values:nn- 1: Do nothing and use the standard theme colors.n- 4.5: [WCAG AA compliance (minimum)](https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html) (default).n- 7: [WCAG AAA compliance (enhanced)](https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast7.html).n- 21: White on black or black on white."), </ins> type: 'number', <del> default: 1 </del> <ins> default: 4.5 </ins> }, [TerminalSettingId.FastScrollSensitivity]: { markdownDescription: localize('terminal.integrated.fastScrollSensitivity', "Scrolling speed multiplier when pressing `Alt`."),

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0 OS Version: Windows_NT x64 10.0. PowerShell version: 7.2.1 Steps to Reproduce: Change theme to "Solarized Dark" in VS Code the terminal and type for example: ! If you highlight the line you will see that actually everything is there: ! I have tried with other shells (cmd, ubuntu (WSL), debian (WSL), kali-linx (WSL)). There everything is fine. It's just the Powershell that has this bug. This bug appeared when I updated today VS Code to the latest version. In the morning when I worked with the older version everything was fine.
I'm using zsh on my pi4 with latest release and have the same issue with solarized dark. Everything in solarized light works fine though.
I wonder if something changed with the Solarized Dark theme even in the editor itself. Pretty sure that my code now looks way more grey and less white than before: ! !
Can repro, pwsh outputs these as "bright black" () which is , the same as . A similar thing happens in Windows Terminal: ! I'm hesitant to change the colors here because solarized uses a fixed palette. Also this is where the recent changes came from You can set to workaround the problem. FYI I'm thinking of setting this to 4.5 by default this iteration, I was originally worried about performance overhead but I've been running it since it was introduced and never noticed any issues.

Marked as a feature request to remember to add to release notes
Changing the default to be have a good contrast makes good sense to me. I just do not understand how this could affect performance :) I guess you scan colors in some way?
I didn't get that performance concern as well. And changing contrast works totally fine in my case, though I only changed it to 2 instead of 4.5. Powerline fonts and symbols will have some shade if the contrast ratio is too high. For example: ! Here's a screenshot with contrast ratio = 2. !
yeah every cell runs through this function to calculate luminance/contrast: Having said that, some caching would make sense here, I don't think we can do anything about that unfortunately, the same character is used for the black and the blue so we couldn't even be smart to selectively apply it only to the foreground as it would break either the start of the end still.
Ah I see why contrast might affect perforamnce. I understand we cannot do anything about font/symbol rendering smartly enought to fit the situation here, also I don't think it is something we need to do from the user end. Hopefully it will be fixed in next release, now we have a working solution without too much compromise for most use cases.
Just to confirm, the contrast ratio fix is only for terminal, it will not the look of the source code, right? I understand that Solarized is defined with certain fixed colors, but my codebase now looks like it’s all comment and no code, due to being all gray. I suppose there is no other way to go back to the old theme than pull it from Git history and create a custom extension based on the old colors?
yes that's right it this change will only affect the terminal.
Why the hell changing the default value for ?! If a terminal color scheme doesn't have enough contrast, it's the problem of this very color scheme. Please, stop messing our terminal colors.