jiebi/CodeConvo huggingface dataset:
Change:
fontSize: `${fontSize}px`, fontFamily: `var(${fontFamilyVar}), ${EDITOR_FONT_DEFAULTS.fontFamily}`, verticalAlign: isUniform ? 'baseline' : 'middle', <ins> unicodeBidi: 'isolate' </ins> }; if (isNonEmptyArray(item.hint.textEdits)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (though an extension that introduces inlay hints is required) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: Windows_NT x64 10.0. Steps to Reproduce: a new rust project with . a font for VSCode that has a ligature for , install and set the config. the cargo project in VSCode and paste the following snippet into the file: Watch how there is an inlay hint inserted in front of both which merges with the leading . Actual result: ! Note that in my theme, inlay hints are dimmed ! but due to the ligature forming, the inlay hint looks like its part of the default code. Expected result ( apparently this can depend on the theme): ! (Different themes are due to running the rust-analyzer fix in the debugger without a custom theme) This also occurs for when two different inlay hints follow each other, as seen in
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed to also occur on 1.74.2
can a decoration force ligature boundaries?
Turns out even inserting a zero-width non joiner doesn't prevent ligatures from forming (for some reason using a builtin theme prevents the ligature from forming, unsure why)
Btw the assigned label is incorrect, this is not a problem with but with
! An obvious example. expected: !

I think this should be on the May milestone?
could you verify this one as you have a rust setup?
Can confirm it is fixed with the latest release! Thanks
Thanks
Change:
group: 'navigation', order: 10, command: openToSideCommand, <del> when: ResourceContextKey.HasResource </del> <ins> when: ContextKeyExpr.and(ResourceContextKey.HasResource, ResourceContextKey.IsFile) </ins> }); const revealInOsCommand = {

Discussion:
Issue Type: <bBug</ba markdown preview. -click the preview in explorer open to the side happens This button should be removed as per new model. VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-27T09:01:48.555Z) OS version: Windows_NT x64 10.0. Reproduces without extensions <!-- generated by issue reporter --
Change:
this._onKeyDown.fire(event); })); <ins> this.disposables.push(this.list.onMouseDown(e => { if (e.browserEvent.button !== 2) { // Works around / fixes #64350. e.browserEvent.preventDefault(); } })); </ins> this.disposables.push(dom.addDisposableListener(this.container, dom.EventType.CLICK, e => { if (e.x || e.y) { // Avoid 'click' triggered by 'space' on checkbox. this._onLeave.fire();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Configure ! Settings and OK ! Configure again is unchecked ! Logs imply the Settings are synced: <details<summaryLogs</summary<p</p</details
This seems to be a quick pick bug, because I see the state correctly when I run the command `Settings Sync: Configure...'
other mult-selects do not have the same problem... !
What I can say is that configure settings sync options go through same code path Gear -Settings Sync is On -Settings Sync Configure... F1 Settings Sync: Configure You can repro this when you use mouse to choose the option in both cases. So something is wrong with quick pick when using mouse. If you use keyboard it works.
Change:
static equals(first: SingleTextEdit, second: SingleTextEdit) { return first.range.equalsRange(second.range) && first.text === second.text; } <ins> public toSingleEditOperation(): ISingleEditOperation { return { range: this.range, text: this.text, }; } </ins> } function rangeFromPositions(start: Position, end: Position): Range { <del> if (!start.isBeforeOrEqual(end)) { </del> <ins> if (start.lineNumber === end.lineNumber && start.column === Number.MAX_SAFE_INTEGER) { return Range.fromPositions(end, end); } else if (!start.isBeforeOrEqual(end)) { </ins> throw new BugIndicatingError('start must be before end'); } return new Range(start.lineNumber, start.column, end.lineNumber, end.column);

Discussion:
Type: <bBug</bStep 1: Create a file named with this content: Step 2: create an empty file named Step 3: Move with a terminal in the folder containing the files and run Step 4: Click on the arrow button and see that it doesn't work ! VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (38)</summaryExtensionVersion ------ vscode-nginx-conf0.3.5 swagger-viewer3.1.2 freezed0.9.6 ccs-flutter-color1.2.4 dart-code3.86.0 flutter3.86.0 jquerysnippets0.0.1 es7-react-js-snippets4.4.3 vscode-html-css2.0.9 copilot1.180.0 copilot-chat0.14.1 vscode-github-actions0.26.2 vscode-pull-request-github0.86.1 gc-excelviewer4.2.59 todo-tree0.0.226 vscode-nginx-conf-hint0.3.1 latex-workshop9.20.0 vscode-edit-csv0.9.1 plantuml2.18.1 vscode-peacock4.2.2 dotenv1.0.1 vscode-docker1.29.0 debugpy2024.5. isort2023.13. python2024.5. vscode-pylance2024.4.102 remote-containers0.354.0 cpptools1.19.9 vscode-thunder-client2.21.11 nginx-formatter0.0.13 vscode-xml0.26.1 vscode-yaml1.14.0 scala0.5.7 markdown-preview-enhanced0.8.13 even-better-toml0.19.2 vscode-icons12.7.0 vscode-nginx0.7.2 txt-syntax0.2.2 </details
working on this
Oh wow I did not realize this was fixed. I've been working on it and just submitted a PR for a similar issue.
My solution was also very similar.
sorry! It was tricky to fix though.
Change:
opacity: 0.35; } <del> .monaco-workbench .debug-viewlet .monaco-list-row .expression { white-space: pre; } </del> .debug-viewlet .debug-call-stack .error { font-style: italic; text-overflow: ellipsis;

Discussion:
Issue Type: <bBug</bHi. I am assigning trade.occId = occId; i.e. to a property (in this case it contains 4 spaces. In the JavaScript hover view however, the property on 'trade' reads (only one space) [btw, I copied both these values right out of the IDE view]. I've just been chasing ghosts for some time because of this discrepancy and not expecting the IDE altering assigned values when viewing objects. Update ---Alright, sorry. I am not sure how to submit the first value on GitHub with the 4 spaces between GS and 1 preserved, even when using 'code' quotes (same as the VSC issue...). So the first value is "GD....190517P00155000" when replacing spaces with dots... Thanks for VS Code otherwise :-) VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ vscode-scss0.6.2 debugger-for-chrome4.11.3 vscode-scss-formatter1.4.1 vscodeintellicode1.1.5 </details<!-- generated by issue reporter --
Can you please provide a screenshot of what you see? Also try disabling all extensions. I am not sure if such an hover is provided by out of the box typescript/javascript extension.
Hi. Please see below. I disabled all extensions besides Debugger for Chrome, which I need to set a break-point to be able to inspect values. The issue is in most obvious in the field 'occId', which in fact has 4 spaces after 'GD' and not just one as displayed. Thanks for following up. [image: ] !
Ah I see.. its an hover while debugging.
You did not attach an image. So please attach an image and some reproducable steps so we can investigate more. Thanks
It did, (please check below the quote). Anyway, your question made me come up with a better/simpler example that should make things clear. Here you go: ! Btw, Gruetzi to all you guys in Zuerich.

I'm originally from Basel :)
Thanks for the image. Cheers back to Basel :)
VSCode insiders will have the fix for this on monday. Try it out and let us know if it is ok for you. Though I verified and the fix from looks good
Thanks for the work and update. Unfortunately I can't switch from VSCode stable, so I'll take your word for it until this hits release :-)
Change:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IEnvironmentService, INativeEnvironmentService } from 'vs/platform/environment/common/environment'; import { parsePtyHostPort } from 'vs/platform/environment/common/environmentService'; <del> import { getResolvedShellEnv } from 'vs/platform/terminal/node/shellEnv'; </del> <ins> import { getResolvedShellEnv } from 'vs/platform/shell/node/shellEnv'; </ins> import { ILogService } from 'vs/platform/log/common/log'; import { LogLevelChannelClient } from 'vs/platform/log/common/logIpc'; import { RequestStore } from 'vs/platform/terminal/common/requestStore';

Discussion:
Moved in I know there's nothing enforcing this, but the terminal folder should rarely be depended upon outside of debug/tasks. Having in platform/terminal means that platform/request depends on the terminal which creates a weird relationship: platform/request -platform/terminal contrib/terminal -platform/request Terminal only exists in platform so that it can be used in the pty host, I'd prefer to keep it similar to a workbench contrib where nothing else in platform depends on it. If no other folder makes sense I propose creating a as it's a similar theme to what's going on in The original seemed fine but I don't understand the tangle.
Change:
node = navigator.first(); if (node) { do { <del> const immediateParent = node.parent(); </del> <ins> let nodeToTest = node; if (node instanceof FolderMatch) { nodeToTest = node.compressionStartParent ?? node; } const immediateParent = nodeToTest.parent(); </ins> if (immediateParent instanceof FolderMatchWorkspaceRoot || immediateParent instanceof FolderMatchNoRoot) { if (viewer.hasElement(node)) { viewer.collapse(node, true);

Discussion:
Testing Open in VS Code Insiders Search for "containers" Exploring results and collapsing/uncollapsing works for a while :bug: Then "Collapse All" does nothing !
It seems I'm able to repro by: Reload window from above state Search for "containers" again, works correctly "Collapse All," works correctly Uncollapse, works correctly Try "Collapse All" again, stuck in unresponsive state above
Actually seems I misread the button - I guess it's always "Collapse All" and doesn't become an option to uncollapse. I was confused since hitting collapse two times in a row changes the search results, so I assumed it was collapsing and then uncollapsing. Not sure if this is expected: ! I've renamed the issue to be reflective of what I actually experienced. If this is expected, please feel free to close. Sorry for confusion!
No, that's totally a bug , it shouldn't get stuck like that. Thanks for catching that!
Change:
label: localize('copy', "Copy"), click: () => { // Collect the selected pids <del> const selectionPids = this.tree?.getSelection()?.map(e => { if (!e || !('pid' in e)) { return undefined; } return e.pid; }).filter(e => !!e) as number[]; </del> <ins> const selectionPids = this.getSelectedPids(); </ins> // If the selection does not contain the right clicked item, copy the right clicked // item only. if (!selectionPids?.includes(pid)) {

Discussion:
Depends on This is common for process explorers on Windows at least, might also make sense to bring this to Linux.
This should be doable now that has landed via
Change:
const repository = this.model.getRepository(uri); if (!repository) { <del> console.log(`FAILED to accept merge because uri ${uri.toString()} doesn't belong to any repository`); </del> <ins> console.log(`FAILED to complete merge because uri ${uri.toString()} doesn't belong to any repository`); </ins> return; }

Discussion:
Testing This was feedback I heard from others too—"Accept Merge" is a bit strange since you aren't really accepting a merge so much as the individual changes. I think "Complete Merge" would make more sense here. <img width="265" alt="CleanShot 2022-09-27 at 11 50 56 src="https://user-"
Or maybe "Confirm Merge".
More ideas: I like this - I think "confirm" is usually used to approve an already stated intention and does not fully fit here. ideas?
"Complete Merge" and "Accept Merge" are the best options. I am leaning towards "Complete Merge". fyi
for "Complete Merge"
Change:
type VoiceChatSessionContext = 'view' | 'inline' | 'terminal' | 'quick' | 'editor'; const VoiceChatSessionContexts: VoiceChatSessionContext[] = ['view', 'inline', 'terminal', 'quick', 'editor']; <del> const TerminalChatExecute = MenuId.for('terminalChatInput'); // unfortunately, terminal decided to go with their own menu (https://github.com/microsoft/vscode/issues/208789) </del> // Global Context Keys (set on global context key service) const CanVoiceChat = ContextKeyExpr.and(CONTEXT_CHAT_ENABLED, HasSpeechProvider); const FocusInChatInput = ContextKeyExpr.or(CTX_INLINE_CHAT_FOCUSED, CONTEXT_IN_CHAT_INPUT);

Discussion:
terminal I -notice double microphone icons I do not have the voice extension installed. ! fyi
Caused by:
looks the most relevant
Why does the terminal have its own execute menu?
Is it possible to clean up the parallel execute menu and submit actions? I'm unclear whether I can just move the voice actions to or you need a new parallel menu for terminal customizations.
I did the first one, seems to work, but please clean up the terminal-specific stuff if possible
Can you be more specific?
so I do have a lot of special code for terminal in using stuff like , which maybe now is obsolete? Did something change to consolidate inline chat in terminal?
This isn't actionable without more info. Terminal chat still has a separate widget implementation, it extends inline chat and shares a lot of code, but must be separate as it's not a monaco content widget for example.
Yeah I did a quick attempt to remove my terminal specific code but restored it, as it still seemed to be needed.
That was directed at the terminal widget stuff- it has its own execute menu and execute action, and I only looked briefly but it seemed like it was doing the same thing as the base chat submit action. TerminalChatWidget uses InlineChatWidget which uses the normal ChatWidget, I'd expect that the execute toolbar can be the same regardless of whether it shows up in an editor or a terminal.
did all that stuff so she might be able to comment better than me.
When I last investigated this, , the chat widget's submit action was dependent on an editor, which we don't have in terminal chat, and was defined in a place where the was not accessible. I can look into doing this now though as it seems the code has changed since then.
Change:
result.message = true; } return result; <del> }, 200, true)(({ message, elements }) => { </del> <ins> }, 200)(({ message, elements }) => { </ins> if (elements.length) { this.refreshQueue = this.refreshQueue.then(() => { const _promiseCallback = promiseCallback;

Discussion:
Issue Type: <bBug</bGitHub Pull Request Extension and focus the viewlet out a pull request so that the "Changes in Pull Request" view shows up the view the window the "Changes in Pull Request" view, expand "Files" or "Commits" No children are shown under these nodes. From the extension side, I saw that "getChildren" was not being called at all on the tree. This seems to have started happening after I'm not sure if this is the fault of the tree itself - I haven't seen this with other trees. What specifically seems to impact whether "getChildren" is called is this: The view is made visible by the change to the a context key. When this is followed by an event, "getChildren" is called on the context key change, but not when "onDidChange" is fired and expanding/collapsing the nodes does nothing. If the "onDidChange" is removed from there, or put before the context key change, then "getChildren" gets called twice and there is no issue with expanding/collapsing the children. Since changing the context key causes the tree to re-render anyway, I can remove the "onDidChange" being fired there. But I'm worried there's still an underlying timing issue. VS Code version: Code - Insiders 1.42.0-insider (, 2020-02-03T13:59:34.701Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --
Accepted as candidate as it is a regression
Change:
this.updateSoon.schedule(); } else { this._setState(null); } } else { this._update();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Steps to Reproduce: the cursor with arrow keys (no modifiers) onto a word then stop after a moment it will highlight other matches that are visible on screen (or in the whole file, with the scrollbar markers) particular, notice that if you stop on the edge of a word, it will still highlight it. , move around with ctrl+left or ctrl+right. You will only be able to stop on word edges in this case. that in this case, no highlight happens, unlike when you land on a word edge by moving only with arrows. , if you move the cursor more than one character in other ways (f.e. you use VS Code APIs to programmatically move the cursor), no highlight happens. As an effect of this, plugins like (which move the cursor in custom ways) will not show any highlight when moving more than one character (or line) at a time. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
In the following example recording, first I move character by character with the left and right arrows keys, and when I stop moving, you see that highlight works. In the last half of the recording I move with ctrl + arrow keys, in which case no highlight happens when I stop moving: !
Change:
// suffix subpath treated specially as we consider no match 'x' and 'x/...' if (otherPathIndex !== pathIndex && paths[otherPathIndex] && paths[otherPathIndex].indexOf(subpath) > -1) { const isSubpathEnding: boolean = (start + subpathLength === segments.length); <del> const isOtherPathEnding: boolean = endsWith(paths[otherPathIndex], subpath); </del> <ins> // Adding separator as prefix for subpath, such that 'endsWith(src, trgt)' considers subpath as directory name instead of plain string. // prefix is not added when either subpath is root directory or path[otherPathIndex] does not have multiple directories. const subpathWithSep: string = (start > 0 && paths[otherPathIndex].indexOf(nativeSep) > -1) ? nativeSep + subpath : subpath; const isOtherPathEnding: boolean = endsWith(paths[otherPathIndex], subpathWithSep); </ins> match = !isSubpathEnding || isOtherPathEnding; }

Discussion:
/cc Notice the middle tab is truncated as , it should be ! All folders share the same grandparent: !
Change:
type: 'boolean', description: localize('experimentalUseSandbox', "Experimental: When enabled, the window will have sandbox mode enabled via Electron API."), default: false, <ins> 'scope': ConfigurationScope.APPLICATION, </ins> ignoreSync: true }, }

Discussion:
Testing Sandbox is meant to be a global setting, but when setting it in the workplace settings, it doesn't show that it is not allowed and suggests to restart vscode. When it then restarts, it does not start in sandbox mode (No Sandbox message in DevTools). I believe that the setting should actually be showing an error when set in the workplace settings (red squiggly line) and should not prompt to restart.
I guess I am missing
Change:
for (const input of group.editors) { const resource = EditorResourceAccessor.getCanonicalUri(input, { supportSideBySide: SideBySideEditor.PRIMARY }); <del> if (resource?.scheme === BulkEditPreviewProvider.Schema) { </del> <ins> if (resource?.scheme === BulkEditPane.Schema) { </ins> previewEditors.push(input); } }

Discussion:
Make a refactor and open the refactor preview Click on accept/discard The editor showing the refactor preview does not close
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.58", </del> <ins> "xterm": "4.19.0-beta.60", </ins> "xterm-addon-search": "0.9.0-beta.39", "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.12.0-beta.37" </del> <ins> "xterm-addon-webgl": "0.12.0-beta.38" </ins> } }

Discussion:
Upstream issue: Repro: Alt+click and drag in the terminal Moving right on the same line does not make a selection Moving to top-right or bottom-left doesn't make a selection (this works in canvas renderer only?) Cursor isn't correct ! Correct behavior in 1.67: !
When verifying make sure that copy works as expected for column selection in each quadrant as well.
Change:
if (lineNumber < 1) { lineNumber = 1; <ins> column = 1; </ins> } <del> if (lineNumber > this._lines.length) { </del> <ins> else if (lineNumber > this._lines.length) { </ins> lineNumber = this._lines.length; <ins> column = this.getLineMaxColumn(lineNumber); </ins> } <del> if (column < 1) { column = 1; } var maxColumn = this.getLineMaxColumn(lineNumber); if (column > maxColumn) { column = maxColumn; </del> <ins> else { var maxColumn = this.getLineMaxColumn(lineNumber); if (column < 1) { column = 1; } else if (column > maxColumn) { column = maxColumn; } </ins> } return new Position(lineNumber, column);

Discussion:
Issue Type: <bBug</bctrl-shift-p, "Debug: Start Debugging" leads to this error. I saw that this error was previously mentioned and fixed in a recent update, but the error persists. VS Code version: Code 1.46.1 (, 2020-06-17T21:13:20.174Z) OS version: WindowsNT x64 10.0. Remote OS version: Linux x64 4.19.104-microsoft-standard <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ regex0.2.0 gitlens10.2.2 vscode-pull-request-github0.17.0 vscode-codemetrics1.24.0 cpptools0.28.3 vscode-versionlens1.0.8 java0.63.0 vscodeintellicode1.2.8 application-insights0.4.2 vscode-java-debug0.26.0 vscode-java-dependency0.10.2 vscode-java-pack0.9.1 vscode-java-test0.23.0 vscode-maven0.22.0 code-lens-roundup1.0.0 remote-containers0.122.1 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.3 vscode-remote-extensionpack0.20.0 </details<!-- generated by issue reporter --
Same problem vscode v1.47.3. any update on this issue?
The issue was fixed in this insiders release:
what debugger are you using?
Dotnet Core.
thanks. That debugger is a separate extension (C#). Please file an issue against that. We have fixed a similar problem with the debugger (which is built into VS Code). But that fix does not cover the C# debugger.