jiebi/CodeConvo huggingface dataset:
Change:
.quick-input-list { line-height: 22px; margin-top: 6px; <ins> padding: 0px 1px 1px 1px; </ins> } .quick-input-widget.hidden-input .quick-input-list {

Discussion:
! Not sure if this is recent, but shouldn't the title background go all the way?
It should. I didn't change anything recently but I'll take a look
verification (Using tomorrow's build): Using GHPR extension open a PR webview Select the milestone using the default theme you should be able to not see any border on the title bar verification that this didn't break Turn off settings sync if you have it on Turn on settings sync to see: ! Tab to select a Quick pick item row Click with your mouse on the "Please sign in to synchronize..." text which will cause the focus to be entirely around the qp (like in the above screenshot) verify there is still a solid border around the entire qp.
Change:
} interface SyncStatusBarState { <ins> isEnabled: boolean; </ins> isSyncRunning: boolean; hasRemotes: boolean; HEAD: Branch | undefined;

Discussion:
There doesn't appear to be an option to hide the git sync icon that appears in the status bar. It's not really a big deal but it would be nice to hide the git sync icon. Personally, coming from Vim I prefer working with the VCS outside of the editor, yet I would still like to see the current branch that is being worked on. This is why I'd like to hide just the sync button and not hide both git status bar items or disable the git extension entirely.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.561 --<!-- potentialduplicatescomment --
I believe this is resolved via
No, hard to revert that change.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Change:
<del> 2024-05-25T03:29:59.419Z </del> <ins> 2024-07-04T16:31:11.121Z </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0-insider OS Version: MacOS 11 Steps to Reproduce: running tests on macos 11 e.g.
90.0 still works if needed
Can you collect crash dump from the pipeline following the steps at , thanks!
The only available file was generated in the subdirectory The job is , an extra warning message was generated
Symbolicated trace
Crash at following due to incorrect value types, I don't see any recent changes along the crash code path that would explain this. We are pretty much calling into N-API in . A next good step would be to bisect the change, I can only try this next week . If possible, can you help narrow down the commit that introduced the regression ? You can pass commit value to the field of api, ex:
I modified the job definition so it can be started with arbitrary commit, but I have to wait for the macos11 brownout to be over to run the test.
I am also seeing this same crash on
This is the crash dump from commit :
I managed to narrow the commit range to - still works - no longer works This commit is the one that stands out...
This works. Make sure to turn off auto updates as well. This morning, I was confused on why VS Code broke again.
same here 1.91.0-insider on mac os 11.7.10 (20G1427) crashing as soon as started rolling back to 1.90.0
It fails on VsCode insiders.

Here's the stack trace:
This seems to have just started happening on the regular release version of VSCode too, as of 1.91.0[^1]. Downgrading to 1.90.2 works for now ([Universal][], [Intel][], [Apple Silicon][]) - just remember to [turn off updates][] for now, as mentioned in [^1]: Only tested on macOS 10.15.7 Catalina so far, but it seems to be the exact same crash the Insiders version was getting on both 10.15 Catalina and 11 Big Sur. [Universal]: [Intel]: [Apple Silicon]: [turn off updates]:
Yes, I also have the same problem now on stable with macOS 11.7.10. Thanks for all the links , downgrade helped.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
private static readonly _overflowCommandCodeAction: CodeAction = { kind: CodeActionKind.SurroundWith.value, <del> title: SurroundWithSnippetEditorAction.options.title.value, </del> <ins> title: localize('more', "More..."), </ins> command: { id: SurroundWithSnippetEditorAction.options.id, title: SurroundWithSnippetEditorAction.options.title.value,

Discussion:
Type: <bBug</bMy VScode won't run anything. i typed basic java code and nothing shows up no matter how i run it. my code is below. class QuickStart { public static void main (String[] args) { ("Hello, World."); } } VS Code version: Code 1.86.2 (, 2024-02-13T19:40:56.878Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (8)</summaryExtensionVersion ------ java1.28.1 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.56.0 vscode-java-dependency0.23.4 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.44.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/extJava
It looks like this is caused by the Java extension. Please file the issue to the . Make sure to check their and provide relevant information such as the extension version you're using. See also our for more information. Happy Coding!
Change:
container.appendChild(generateViewMoreElement(notebookUri, cellViewModel, outputId, disposables, openerService)); <del> const pre = DOM.$('pre'); container.appendChild(pre); pre.appendChild(handleANSIOutput(buffer.getValueInRange(new Range(1, 1, linesLimit - 5, buffer.getLineLastNonWhitespaceColumn(linesLimit - 5)), EndOfLinePreference.TextDefined), linkDetector, themeService, undefined)); </del> <ins> const div = DOM.$('div'); container.appendChild(div); div.appendChild(handleANSIOutput(buffer.getValueInRange(new Range(1, 1, linesLimit - 5, buffer.getLineLastNonWhitespaceColumn(linesLimit - 5)), EndOfLinePreference.TextDefined), linkDetector, themeService, undefined)); </ins> // view more ... DOM.append(container, DOM.$('span' + Codicon.toolBarMore.cssSelector)); const lineCount = buffer.getLineCount(); <del> const pre2 = DOM.$('div'); container.appendChild(pre2); pre2.appendChild(handleANSIOutput(buffer.getValueInRange(new Range(lineCount - 5, 1, lineCount, buffer.getLineLastNonWhitespaceColumn(lineCount)), EndOfLinePreference.TextDefined), linkDetector, themeService, undefined)); </del> <ins> const div2 = DOM.$('div'); container.appendChild(div2); div2.appendChild(handleANSIOutput(buffer.getValueInRange(new Range(lineCount - 5, 1, lineCount, buffer.getLineLastNonWhitespaceColumn(lineCount)), EndOfLinePreference.TextDefined), linkDetector, themeService, undefined)); </ins> }

Discussion:
Does this issue occur when all extensions are disabled?: Yes As described in the title and the clip below will say the rest, the canvas seems overwhelmed with the output and doesn't wrap it. https://user- The log: Because the lower trimmed part are wrapped, it thinks it don't have to show the scrollbar so we can't view the rest if the line is long enough. This is critical. ! If we put some colors, we will see the lines overflow at the edge: ! Smaller outputs are fine: ! <details<summarySystem info</summaryVersion: 1.62.0-insider Commit: Date: 2021-10-29T07:49:33.336Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Linux x64 5.11.0-38-generic </detailsI haven't got a chance to test on other OSs. This is my test notebook:
this is just a bug, but could probably be considered as part of the discussion about
thanks for the feedback. What are your thoughts on the current behavior, where we supply a link at the top of the output that allows you to open the output in a separate editor tab? This behavior can indirectly essentially solve problems like this.
It's definitely a good design. The issue actually doesn't stop me from doing my job. My opinion is, as you said, it's just a bug - and I just want to let you know.
I'm taking this with the assumption you're not currently looking at it.
Change:
if (!opts) { opts = { all: noStagedChanges }; <ins> } else if ((opts.all === false) && noStagedChanges) { opts = { ...opts, all: noStagedChanges }; </ins> } // enable signing of commits if configurated

Discussion:
VSCode Version: Code - Insiders 1.17.0-insider (, 2017-09-26T05:24:48.911Z) OS Version: Windows_NT x64 10.0. Extensions: none Testing Steps to Reproduce: some unstaged changes, none staged Staged (Amend) asks if I want to stage the changes Yes Message telling me that there are no changes to commit
Hi, I'm working on it. The PR will be ready shortly!
For repro: make sure you have .
Change:
dependencies: path-key "^2.0.0" <del> nsfw@1.0.16: version "1.0.16" resolved "https://registry.yarnpkg.com/nsfw/-/nsfw-1.0.16.tgz#78ba3e7f513b53d160c221b9018e0baf108614cc" dependencies: fs-extra "^0.26.5" lodash.isinteger "^4.0.4" lodash.isundefined "^3.0.1" nan "^2.0.0" promisify-node "^0.3.0" </del> nth-check@~1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/nth-check/-/nth-check-1.0.1.tgz#9929acdf628fc2c41098deab82ac580cf149aae4"

Discussion:
VSCode Version: 1.17.0 () OS Version: Ubuntu 16.04 LTS Steps to Reproduce: "files.useExperimentalFileWatcher": true and close VS Code a symlink to root directory (must be an absolute link, not relative!): directory containing that symlink in VS Code: processes - one of vs code processes takes high CPU Reproduces without extensions: Yes See also:
Just noticed the same thing on osx...
Updating issue with: vs code version 1.17.0 reproduces without extensions ! Also, I found memory usage increasing over time...
Same issue here vs code version 1.17.2 Even after closing the VsCode the Code Helpers is still running with 100% CPU usage.
Reported upstream
Upstream PR
The original PR was closed so I opened one which was merged , just need a release to pull this in.
I have vscode 1.19.2 on Ubuntu. The various nodemodules directories have symbolic links point to each other that form the circular links. The nodemodules is set excluded in "files.watcherExclude". After vscode is started, it uses 100% CPU and memory usage increased dramatically and soon reached the max memory and hang the system. This problem happens whatever useExperimentalFileWatcher is set true or false. The ps shows the problem code process has parameter '--type=watcherService". Attached gdb to the process, it shows the watcher follows through the circular symbolic links in circular. Set "search.followSymlinks": false has no effect,. So this problem still happens in 1.19.2 even with all the right settings in place.
is it possible/easy to patch VS Code to stop this behaviour while waiting for it to hit a release? I have a workspace that causes a 20GB VM to exhaust its memory in about 15 mins because of circular symlinks (it uses lerna).
yeah I'll fork the module to get this in, was hoping I wouldn't need to.
what's the expected behavior after the change? I'm still seeing high CPU on today's insiders version on Ubuntu ! on Mac
the fix is specific to Linux only when you have experimental file watcher set to true in settings (or you have a multi-root workspace open).
If you have this issue, it's not just high CPU usage - your memory will be exhausted within minutes.

With a workspace with circular symlinks in it (it uses lerna and has circular dependencies), I was seeing 20GB of RAM get sucked up in about 15 minutes. Insiders has had the fix for a while now.
thanks, I'll mark as verified since you saw it before :+1:
Change:
} editor.layout(dimensions); <del> const height = Math.min(1000, Math.max(editor.getOriginalEditor().getContentHeight(), editor.getModifiedEditor().getContentHeight())); </del> <ins> const height = Math.min(10000, Math.max(editor.getOriginalEditor().getContentHeight(), editor.getModifiedEditor().getContentHeight())); </ins> editor.layout({ height, width: dimensions.width }); return height; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.92.0 (Universal) Commit: Date: 2024-07-31T23:26:45.634Z Electron: 30.1.2 ElectronBuildId: Chromium: 124.0.6367.243 20.14.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.5.0 Steps to Reproduce: this snippet in the test-provider-sample project running the test, both the editor peek view and test result view do not render correctly. !
Sorry, this got lost in the shuffle of the call stack UI :(
Verification steps: out the of vscode-extension-samples into and F5 the "easy math" test in Open the error messages for all the tests that fail and verify they're all visible
Change:
// Skip if check updates only for builtin extensions and current extension is not builtin. continue; } <del> if (installed.isBuiltin && (installed.type === ExtensionType.System || !installed.local?.identifier.uuid)) { </del> <ins> if (installed.isBuiltin && !installed.pinned && (installed.type === ExtensionType.System || !installed.local?.identifier.uuid)) { </ins> // Skip checking updates for a builtin extension if it is a system extension or if it does not has Marketplace identifier continue; }

Discussion:
extension details page for GitHub Repositories extension in :bug: the marketplace and repository links aren't shown !
Change:
private _inProcessContinueOnComments: Map<string, languages.PendingCommentThread[]> = new Map(); private _editorDisposables: IDisposable[] = []; private _activeCursorHasCommentingRange: IContextKey<boolean>; <ins> private _activeCursorHasComment: IContextKey<boolean>; </ins> private _activeEditorHasCommentingRange: IContextKey<boolean>; private _hasRespondedToEditorChange: boolean = false;

Discussion:
Type: <bFeature Request</bCC any file containing comment thread editor, move your cursor to any line having comment your cursor is on the line, press ctrl+K ctrl+I to see if the comment tolltip opens Screen reader users cannot open comment tooltip on the current line via ctrl+K ctrl+I ctrl+K ctrl+I needs to work for the comment tooltip just like other tooltips. VS Code version: Code - Insiders 1.93.0-insider (, 2024-08-20T08:04:15.567Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
the comment widget is not a tooltip. We cannot reuse this keybinding to focus the comment widget because it's possible that line will have hover info. pls lmk if you disagree. I do wonder if we should have a focus closest comment widget command/keybinding.
Aw, I see. Please then consider adding a keybinding to focus the closest comment widget. Currently, alt+F9 and shift+alt+F9 go to the next and previous comment widget, but there is no action available to focus the comment on the current line.
It does make sense to have an "Expand and focus comment at current line" command.
The new command is "Focus Comment on Current Line" with no default keybinding.
To verify: Install an extension that provides comments GitHub Pull Requests can be used for this Sign in Open the Pull Requests view Open a file diff for a PR. If there aren't any comments in the file, add a comment on one of the changed lines and collapse the comment Put your cursor on a line in a file with a collapsed comment Open the command palette and run the command "Focus Comment on Current Line" Verify that the comment has focus
This should probably be to the comments and/or the editor accessibility help dialog for discoverability.
Change:
assert.deepEqual(labels.shorten(['d/f/a/b/c', 'h/d/b/c']), ['…/a/…', 'h/…']); assert.deepEqual(labels.shorten(['/x/b', '/y/b']), ['/x/…', '/y/…']); <ins> // same name ending assert.deepEqual(labels.shorten(['a/b', 'a/c', 'a/e-b']), ['…/b', '…/c', '…/e-b']); </ins> // same in the middle assert.deepEqual(labels.shorten(['a/b/c', 'd/b/e']), ['…/c', '…/e']);

Discussion:
/cc Notice the middle tab is truncated as , it should be ! All folders share the same grandparent: !
Change:
sha }; } <del> function createCancellationPromise(cancellationToken: vscode.CancellationToken) { return new Promise((resolve, _) => { if (cancellationToken.isCancellationRequested) { resolve(undefined); } cancellationToken.onCancellationRequested(() => { resolve(undefined); }); }); } </del>

Discussion:
Testing on Windows 11, latest Insiders When I selected in the publish warning, the same notification toasted again. ! ! I hit Cancel again, and I was then prompted to sign into GitHub, which I already did in the browser before getting the branch toast: ! Perhaps tied to
I realize I'm now getting duplicate toasts after any option. When I selected Allow, I got the same toast again: !

Testing Choosing Never failed: <img width="458" alt="image" src="https://user-"
Choosing Always also failed: <img width="453" alt="image" src="https://user-"
I was using a public repo:
I experience the same on Windows 11 with the repo:
Create New Codespace still fails with ContinueOn
The original issue reported here was due to the fact that we weren't properly awaiting the branch publish before invoking the codespace creation. based on our offline discussion I think you're encountering a different issue because the publish completes but the codespace creation doesn't start, and only if you aren't signed into the GitHub Codespaces extension, so I'm going to close this issue and we can file a new one to investigate the scenario you've uncovered since I can't reproduce it at the moment:

Testing I can't choose to publish and ask again next time: <img width="264" alt="image" src="https://user-"
Also: The text doesn't indicate that the Always/Never choice only applies to the current workspace folder (as I just discovered) and not to all repositories.
+1, I was about to file the same issue.
Great feedback, this leads me to think we should just have 'Yes' and 'Cancel' as the options here, because choosing 'Never' will break the Continue On flow (i.e. it's not an option that we can actually support, and per we should actually throw a and bail out of the whole flow here).
'Publish Branch' might be clearer than 'Yes'. The PR extension uses this dialog: <img width="261" alt="image" src="https://user-"
The "fix" for this is more problematic for me. I used to have this in my settings: Now every time I quit VS Code (I'm on Mac if it makes a difference), I see the dialog and I have to press "Cancel". Even worse, pressing "Cancel" seems to only close the dialog and reopen it again. can we reopen this issue and restore the setting at least? That'd be highly appreciated. Thanks.
Change:
} /// [...](...| <del> private readonly linkStartPattern = /[([^]]*?)](s*([^s()]*)$/; </del> <ins> private readonly linkStartPattern = /[([^]]*?)](s*(<[^>)]*|[^s()]*)$/; </ins> /// [...][...| private readonly referenceLinkStartPattern = /[([^]]*?)][s*([^s()]*)$/;

Discussion:
Issue Type: <bBug</bTrigger path suggestions inside a markdown link that uses angle brackets: Bug No suggestions show up VS Code version: Code - Insiders 1.69.0-insider (Universal) (, 2022-06-17T05:16:27.373Z) OS version: Darwin x64 21.5.0 Restricted Mode: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Relevant code:
So I'm new to this project. Do I ask if I can be assigned this bug? Or is it whoever submits an solution first makes the pull request?
You can ask, I am currently working on this now - but you can try as well.
Alright thanks. So in general I can just work on a problem that catches my attention and ask/answer questions when appropriate?
Yes pretty much, you can work on any problem or issue that you would like.
What specifically is the bug here? Is the desired behavior where when you type a list of path links should appear?
Yes, it should work the same way it does if you remove the from the link One extra note: spaces should not be encoded inside links so for extra points make accepting a file suggestion with spaces in the name inserts a real space instead of
How do I recompile typescript files so vscode reflects the changes I made? Is it or ?
Is this the behavior you were looking for?
Change:
return this.doReadFileStream(provider, resource, options, token); } <del> private async doReadFileStream(provider: IFileSystemProviderWithFileReadWriteCapability | IFileSystemProviderWithOpenReadWriteCloseCapability | IFileSystemProviderWithFileReadStreamCapability | IFileSystemProviderWithFileReadCapability, resource: URI, options?: IReadFileOptions & IReadFileStreamOptions & { preferUnbuffered?: boolean }, token?: CancellationToken): Promise<IFileStreamContent> { </del> <ins> private async doReadFileStream(provider: IFileSystemProviderWithFileReadWriteCapability | IFileSystemProviderWithOpenReadWriteCloseCapability | IFileSystemProviderWithFileReadStreamCapability, resource: URI, options?: IReadFileOptions & IReadFileStreamOptions & { preferUnbuffered?: boolean }, token?: CancellationToken): Promise<IFileStreamContent> { </ins> // install a cancellation token that gets cancelled // when any error occurs. this allows us to resolve

Discussion:
Refs: I do not understand this condition: How does that make sure a method exists? The only check for this that is valid currently is , the is just a detail of the file system and not a capability.
This looks like an actual typo to me or missing code review, not sure the consequences, as it could lead to errors when wrongly asserting, so maybe moving to August for investigation.
TLDR I misunderstood how the declared capabilities relate to the actual declared methods and the meaning of . For context, this change came in through and the intention of this change was to support the scenario where an has declared but not : since is optional in the interface and the capability requires both and to be implemented: I made this change because when implementing a with but not , this would result in throwing here: I see how it's possible that a which has check does not have a method implemented. Additionally I see that we have other examples of how to handle the requirement of a readonly filesystem which implements both and , e.g.: I am reverting Apologies for the incorrect code change and thank you for pointing this out.