jiebi/CodeConvo huggingface dataset:
Change:
included?: boolean; tags?: string[]; disallowSyncIgnore?: boolean; <ins> enumItemLabels?: string[]; </ins> } export interface IConfigurationExtensionInfo {

Discussion:
Issue Type: <bBug</b! VS Code version: Code - Insiders 1.50.0-insider (, 2020-09-12T00:56:22.923Z) OS version: Darwin x64 19.4.0 Remote OS version: Linux x64 4.19.76-linuxkit <details<summarySystem Info</summary </details<!-- generated by issue reporter --
This is the order that it's contributed in. Do you think that the settings UI should sort them alphabetically like they are in the suggest widget, or leave them in contribution order, in case that is important? Looking through some enum settings, some seem to order the options in an intentional way, like with the default first, or the simpler options first. Some are random or are sorted. I think I am inclined to display them in contributed order to keep this an option (and we can sort the encodings manually), but I'm not sure, what do you think?
It should be this order, same as the picker: ! The encodings are not sorted by name intentionally. But they are grouped by type and I guess that is not very visible in the settings editor.
Oh, got it. I've seen a few of these cases where it would make sense to display the enumDescription in the dropdown instead of the actual value. It doesn't make sense in general but it would be cool to provide an option for settings to opt into that, what do you think?
Yeah I think it would make a lot of sense in this case
I think we should add an option to the schema contribution for this but I have no clue what to call it
If the dropdown list will now display the enumDescriptions, should the description footer on the list show the value to be set? Should the collapsed dropdown control show the selected value or its enumDescription?
Yes, I'd say just swap them I think it should show the enumDescriptioni
I'll start working on this issue. Thanks for your help.
Now this will show with the key in the description area in square brackets. But it would look much nicer to match the editor encoding picker, so I opened for that.
Change:
export function parseAuthorityWithPort(authority: string): { host: string; port: number } { const { host, port } = parseAuthority(authority); if (typeof port === 'undefined') { <del> throw new Error(`Remote authority doesn't contain a port!`); </del> <ins> throw new Error(`Invalid remote authority: ${authority}. It must either be a remote of form <remoteName>+<arg> or a remote host of form <host>:<port>.`); </ins> } return { host, port }; }

Discussion:
Testing Triggered by trying : !
Can you clarify what better message you would have expected?
Probably something telling me how I messed the URL up. Is their an allowlist or some way to know what the valid authorities are so you can tell me how I specified the wrong one? For instance, I specified an HTTP URL that I wanted to open, so being told that some port isn't opened suggested to me that some unspecified port wasn't opened on the GitHub side, not that I have a malformed URL.
Such a URL basically requires you to have an extension installed that can handle the remote authority. There is only very few: SSH, DevContainer, WSL and GH and GH Codespaces I think.
Change:
this.disposables.push(disposable); if (!this.focusedRepository) { <del> this.onDidFocusRepository(repository); </del> <ins> if (this.editorService.activeEditor) { this.onDidActiveEditorChange(); } else { this.onDidFocusRepository(repository); } </ins> } }

Discussion:
Issue Type: <bBug</bWhen you open vscode-insder and you have two folders in the workspace on different branches it is automatically positioned on the first folder git branch also if the active file tab is of another folder. You need to deselect and select the file tab again to see the correct branch/git. This seems to happen only at vscode startup. VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-31T06:15:21.895Z) OS version: Linux x64 4.18.0-13-generic <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.506 --- <!-- score: 0.452 --<!-- potentialduplicatescomment --
Hi, is this taken?
I'm interested in working in this issue but I'm having trouble understanding the bug. Could you give me step by step instructions on how to reproduce it?
I don't know exactly the full perimeter of the bug. But you can reproduce in this way: Create a workspace with two folder (one on a git branch and the second one with a worktree folder on another branch) Open a file from the first folder (in order as you see in the workspace view) Open a file from the second folder (in order as you see in the workspace view) Close vscode Open the application and you are positioned on the file on the second folder but the git branch in the bottom left panel is the one of the first folder. If you change the focus between the two opened file tabs and back the git branch in the panel it is refreshed correctly.
Can I take this?
sure go ahead
same issue on macOS
Are you still working on this issue? Else I would like to give it a try. I could reproduce the bug.
Yeah, I'm close to a fix.
Saw it had been a while since there was progress on this so had a stab in . Haven't found any issues with this fix so far.
Change:
}); } exports.processNlsFiles = processNlsFiles; <del> const editorProject = 'vscode-editor', workbenchProject = 'vscode-workbench', extensionsProject = 'vscode-extensions', setupProject = 'vscode-setup'; </del> <ins> const editorProject = 'vscode-editor', workbenchProject = 'vscode-workbench', extensionsProject = 'vscode-extensions', setupProject = 'vscode-setup', serverProject = 'vscode-server'; </ins> function getResource(sourceFile) { let resource; if (/^vs/platform/.test(sourceFile)) {

Discussion:
Testing in Firefox, with Spanish (es-es) set Open "Get Started with VS Code in the Web" walkthrough Select last step (open up your code), then first command ("Open Folder" in English, "Abrir carpeta" in Spanish) Modal is in English: ! It isn't a new string, and I didn't think getting started or this command would be from an extension, but perhaps that is the case.
I also see this on modals on the overall welcome page when I try opening a file or folder: !
Thank you for your feedback. We are currently reviewing it (reference ).
This is an odd one. The string looks good here: but the file that that comes from doesn't show up at all in our Spanish files: I'll have to dig into why this is... any ideas?
might be a bug in the tool so that the localize call is not detected. When you generate the export is the string included.
Ok the web strings are now bundled in language packs. It may take a minute for all these new strings to make their way through the translation system... but by end game it should be good.
Change:
/** @inheritdoc */ public click(e: IEditorMouseEvent): boolean { <del> if (e.target.type !== MouseTargetType.GUTTER_GLYPH_MARGIN || e.event.rightButton) { </del> <ins> if (e.target.type !== MouseTargetType.GUTTER_GLYPH_MARGIN // handled by editor gutter context menu || e.event.rightButton || isMacintosh && e.event.leftButton && e.event.ctrlKey ) { </ins> return false; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: Mac OS Ventura 13.2.1 +click on the "play" icon next to a test (e.g. in ). Screenshot: <img width="583" alt="image" src="https://user-"Will bring up the context menu, like ctrl+clicking on a file tab header will. Executes the primary left-click action, which is to run the test with defaults.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
It reproduces exactly the same in 1.76.0. I have edited the bug description.
sending this your way since you're redoing the context menus here
Seems like ctrl+click in the gutter shows the context menu everywhere except for test decorations so I think this was just never implemented, therefore marking as feature request.
Wow, thanks for the super quick turnaround!
Change:
for (const l of labels) { const labelStr = l && l.toString(); if (typeof labelStr === 'undefined') { <del> return { data: FuzzyScore.Default, visibility: true }; </del> <ins> return { data: FuzzyScore.Default, visibility }; </ins> } const score = fuzzyScore(this._pattern, this._lowercasePattern, 0, labelStr, labelStr.toLowerCase(), 0, { firstMatchCanBeWeak: true, boostFullMatch: true }); if (score) { this._matchCount++; return labels.length === 1 ? <del> { data: score, visibility: true } : { data: { label: labelStr, score: score }, visibility: true }; </del> <ins> { data: score, visibility } : { data: { label: labelStr, score: score }, visibility }; </ins> } } if (this.tree.findMode === TreeFindMode.Filter) { return TreeVisibility.Recurse; } else { <del> return { data: FuzzyScore.Default, visibility: true }; </del> <ins> return { data: FuzzyScore.Default, visibility }; </ins> } }

Discussion:
Type: <bBug</bFilter tests for the current doc is no longer working. is doing nothing in the test explorer. It seems that all filter are broken. For example is also not possible. <img width="344" alt="CleanShot 2022-07-25 at 11 14 38 src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-25T05:27:27.755Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/assign
Change:
"url": "./schemas/jsconfig.schema.json" }, { <ins> "fileMatch": ".swcrc", "url": "https://swc.rs/schema.json" }, { </ins> "fileMatch": "typedoc.json", "url": "https://typedoc.org/schema.json" }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I'm creator of [SWC][] and I want vscode to use the officla JSON schema introduced by for by default. I'm going to create a PR. [SWC]
Change:
return await this.run(Operation.GetCommitTemplate, async () => this.repository.getCommitTemplate()); } <ins> async cleanUpCommitEditMessage(editMessage: string): Promise<string> { return this.repository.cleanupCommitEditMessage(editMessage); } </ins> async ignore(files: Uri[]): Promise<void> { return await this.run(Operation.Ignore, async () => { const ignoreFile = `${this.repository.root}${path.sep}.gitignore`;

Discussion:
VSCode Version: 1.1.1 OS Version: OS X Steps to Reproduce: into a merge conflict accepting Git's default message. It's equal to is no way to do that!
Will mention that it's also equivalent to and saving the default message that shows up in your editor - hence a very common workflow
My workaround is to invoke from a terminal. Maybe if the commit message field is empty, VSCode could just call as well and leave it up to user's configuration what happens (in my case, it would open a text editor from my system variable, which is fine).
Has the pull request been reviewed yet? Can it be pulled in?
Verification: When having a merge commit, VS Code should now automatically populate the input box with the default git merge commit message, so the user can just accept it.
Change:
let service = new ConfigurationResolverService(envVariables, new TestEditorService(), TestEnvironmentService, configurationService, mockCommandService); if (platform.isWindows) { <del> assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar VSCodeworkspaceLocation - VSCodeworkspaceLocation Value for Key1 - Value for Key2'); </del> <ins> assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar VSCodeworkspaceLocation - VSCodeworkspaceLocation Value for key1 - Value for key2'); </ins> } else { <del> assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar /VSCode/workspaceLocation - /VSCode/workspaceLocation Value for Key1 - Value for Key2'); </del> <ins> assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar /VSCode/workspaceLocation - /VSCode/workspaceLocation Value for key1 - Value for key2'); </ins> } });

Discussion:
VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} "command": "echo", "isShellCommand": true, "args": ["${env.PATH}"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is "Path". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue
this is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.
Let's keep it open and if some user is passionate he can tackle it
On linux and macOS environment variables are case sensitive, so "Path" and "PATH" are different variables on linux and macOS (but not on Windows). So your statement from above "IMO env variables on all OSes are case insensitive." is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?
I thought they are always case insensitive. So it should be case insensitive then on Windows only
I'm actually about done with a change for this if you want to take a look.
thanks, I will review the PR.
did you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.
no need to squash, I will add the comments to the PR directly if something is needed. Thanks
Change:
this.applyStyles(configuration.data.styles); this.handleExtensionData(configuration.data.enabledExtensions); this.updateExperimentsInfo(configuration.data.experiments); <ins> this.updateRestrictedMode(configuration.data.restrictedMode); </ins> } render(): void {

Discussion:
When I report an issue from our issue reporter from an untrusted workspace, there is no info about this in the GH issue.
Marking as important to make sure we care about this before enabling trust by default to not make our life harder for triaging issues than it needs to be.
Two examples: in an effort to make the smallest change this late in the game, I’ve put it in System Info however when you report a performance issue, we also have a section called “Workspace Info” that shows up that gives details on the workspace (like number of files, etc). I think it should eventually go there
lol jk sent a PR putting it next to the OS which I don't love... but the change is small and it means the user can't not tell us their WT situation which is good.
Change:
await this.editors.saveOpenedFile(); } <ins> /** * Write several settings faster than multiple calls to {@link addUserSetting}. * * Warning: You will likely also need to set `editor.wordWrap` to `"on"` if `addUserSetting` is * called after this in the test. */ async addUserSettings(settings: [key: string, value: string][]): Promise<void> { await this.openUserSettingsFile(); await this.code.dispatchKeybinding('right'); await this.editor.waitForTypeInEditor('settings.json', settings.map(v => `"${v[0]}": ${v[1]},`).join('')); await this.editors.saveOpenedFile(); } </ins> async clearUserSettings(): Promise<void> { await this.openUserSettingsFile(); await this.quickaccess.runCommand('editor.action.selectAll');

Discussion:
With support for for Electron tests, we should enable terminal tests: I eagerly had enabled them but since we don't know whether Electron smoke tests with are stable, I moved back to only running them in web. We should not enable these tests until we are sure, smoke tests are stable, so maybe this should only happen in May.
Failing macOS run for reference: !
Still not passing, deferring to a debt week
Change:
registerEditorAction(FoldAllRegionsExceptAction); registerEditorAction(UnfoldAllRegionsExceptAction); registerEditorAction(ToggleFoldAction); <ins> registerEditorAction(JumpToParentFoldAction); registerEditorAction(JumpToPreviousFoldAction); registerEditorAction(JumpToNextFoldAction); </ins> for (let i = 1; i <= 7; i++) { registerInstantiatedEditorAction(

Discussion:
It would be useful for navigating code to have a command to jump to previous/next foldable line. This would allow me to easily jump to the lines that I can either fold/unfold.
Awesome! Do I need to update my version to add this? I'm on macos Version: 1.58.2 currently and tried to my shortcuts, but didn't get it to work.
to get it you need to install Insiders.
Ahh I see the tag now, thanks.
Change:
}, { // e.g.  * ...| beforeText: /^(t|[ ])*[ ]*([ ]([^*]|*(?!/))*)?$/, <del> oneLineAboveText: /^(s*(/**|*)).*/, </del> <ins> oneLineAboveText: /(?=^(s*(/**|*)).*)(?=(?!(s**/)))/, </ins> action: { indentAction: IndentAction.None, appendText: '* ' } }, { // e.g.  */|

Discussion:
VSCode Version: 1.47.0-insider (user setup) Commit: Date: 2020-06-11T13:30:35.121Z (1 day ago) Electron: 7.3.1 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a new TS or JS file a with a generator method that has a leading multiline or JSDoc comment. NOTE: There must be a space between the token and the method name. cursor at the end of the line that starts the generator method body and press enter. Expected: new line is with the correct indentation. Actual: new line is indented to the same level as the method name and an asterisk () is as if this were a line continuation of a multiline or JSDoc comment. ! Notes: This does not occur if the method does not start with a multiline or JSDoc comment. This does not occur if there is no space between the asterisk () and the method name. This does not occur for functions (as there is a leading keyword between the start of the line and the asterisk () This does not occur for generator methods with a leading keyword before the , such as or in JS or , , , , or in TS. Does this issue occur when all extensions are disabled?: Yes
Similar to (the jsdoc comment Is required for this bug)
I am working on this
Change:
} const result = parsedPattern(path, base, name, hasSibling); <del> if (result) { return result; </del> <ins> if (typeof result === 'string') { return result; // immediately return as soon as the first expression matches } // If the result is a promise, we have to keep it for // later processing and await the result properly. if (isThenable(result)) { if (!resultPromises) { resultPromises = []; } resultPromises.push(result); </ins> } } <ins> // With result promises, we have to loop over each and // await the result before we can return any result. if (resultPromises) { return (async () => { for (const resultPromise of resultPromises) { const result = await resultPromise; if (typeof result === 'string') { return result; } } return null; })(); } </ins> return null; };

Discussion:
While reviewing some code in I noticed potential issues: and Will wrongly stop the loop when the result is a even when that result resolves to . Would be good to have a test case for this too.
I think you the support for for the expression matching via , do we really still need this? I feel this makes glob matching overly complicated. Checking on usages, I think search component uses it to lazily resolve children...
PR:
Are you suggesting to resolve children before doing the glob matcher? It would be a lot faster to avoid matching children until you need them. I don't like the flexible typing of this though. It should be explicitly sync or not.
Change:
} @throttle <del> async fetchAll(cancellationToken?: CancellationToken): Promise<void> { await this._fetch({ all: true, cancellationToken }); </del> <ins> async fetchAll(options: { silent?: boolean } = {}, cancellationToken?: CancellationToken): Promise<void> { await this._fetch({ all: true, silent: options.silent, cancellationToken }); </ins> } async fetch(options: FetchOptions): Promise<void> {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 (system setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: When i run command, i don't know whether it is complete or not. There is no circle loading animation. !
It looks like, it was not do show progress while the operation is being executed. Thinking about it, I do think that if one has auto-fetch enabled it might be quite distracting to show progress every time the fetch operation is being run as part of auto-fetch. Having said that, I do think that it makes sense to show progress when is being executed explicitly. thoughts?
Agree.
Consider adding an option to decide whether to turn on the feature?
this progress indicator during a manual fetch would honour the setting.
Thank you, hope see the feature soon.