jiebi/CodeConvo huggingface dataset:
Change:
if (this.contextService.getWorkbenchState() === WorkbenchState.EMPTY) { this.showSearchWithoutFolderMessage(); } <ins> this.reLayout(); </ins> } else { this.viewModel.searchResult.toggleHighlights(this.isVisible()); // show highlights

Discussion:
Search view, context menu on empty area -no context menu In this case we should still offer the option to move the search view to the panel. Since it is a "global" action, and it only appears when there are results in the search view
, can i take a look at this or are you working on this ? :)
You can take a look
, I understood how "Toggle Search View Position" works both in and functionality. So when we right click on the search result then only the option comes up , so it is bound to search result. So what is the approach we should take to fix this ? We need to move this whole functionality to somewhere else rite ? ( Like some button next "Refresh","Clear All Search Results".... ? ) Please suggest me the way forward :)
do you know how to add a context menu to an empty tree?
gets fired for every place in the tree, including empty items. Here's an example how I use this in the explorer
I think we should use that for this command, rather than
, I tried doing this and here is what I found. There is already trigger in If we remove this check then it will work on empty tree also ( ) In case of no results , we are showing custom message and here the tree is no longer in the view , so right clicking there would not work. ( ) Ideally if we remove that mentioned in case 2 , then what suggested is already there but as the tree itself is not valid in case of "No Search Results" because of showing some custom message described above. Please let me know the way forward to fix this :)
Good analysis. Can we change it to keep the tree in the DOM when that no results message is shown? Not sure how the tree is sized in css but it would have to be vertically flexible. Also, when I am right clicking on an empty tree, I should not see context menu items that are not valid without a row, like copy, dismiss, etc.
Change:
return 0; } <del> return compareAnything(elementA.saneLabel, elementB.saneLabel, lookFor); </del> <ins> return compareAnything(elementA.saneSortLabel, elementB.saneSortLabel, lookFor); </ins> } class QuickInputAccessibilityProvider implements IListAccessibilityProvider<ListElement> {

Discussion:
Create or Checkout a PR Click on the branch indicator in the status bar Type Observe that doesn't show in top position Not sure what changed, but this used to work reliably until today, this was the main way I used to go back to the branch: <img width="1078" alt="image" src="https://user-"
We have an icon to the quick pick items but I would like to think that this did not break search. Will investigate.
Change:
const res = sanitizeRanges(ranges, this.foldingRangesLimit); return res; } <del> return null; </del> <ins> return this.fallbackRangeProvider?.compute(cancellationToken) ?? null; </ins> }); } dispose() { <del> this.disposables?.dispose(); </del> <ins> this.disposables.dispose(); </ins> } }

Discussion:
a folding range provider that conditionally contributes ranges or undefined and ensure no other is contributing any ranges. a file for which the custom will return undefined so that the default folding regions are shown. another file for which the custom does return ranges. -open the first file :bug: folding regions are not shown !
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as vscode from 'vscode'; import { Disposable } from '../util/dispose'; import { SkinnyTextDocument } from '../workspaceContents'; import { MdReferencesProvider } from './references'; export class MdDefinitionProvider extends Disposable implements vscode.DefinitionProvider { constructor(private readonly referencesProvider: MdReferencesProvider) { super(); } async provideDefinition(document: SkinnyTextDocument, position: vscode.Position, token: vscode.CancellationToken): Promise<vscode.Definition | undefined> { const allRefs = await this.referencesProvider.getAllReferencesAtPosition(document, position, token); return allRefs.find(ref => ref.kind === 'link' && ref.isDefinition)?.location; } } </ins>

Discussion:
Enable triggering go to definition on a markdown reference link to jump to the link definition Go to def should jump to the definition at the end of the file
Related
Created a PR fixing this
Works well, I was a bit confused to see this tooltip with 'Execute command' though, is there a way to make that more context-specific? !
Change:
}, 'debug.inlineValues': { type: ['boolean', 'string'], <del> 'enum': [true, false, 'auto'], </del> <ins> 'enum': ['on', 'off', 'auto'], </ins> description: nls.localize({ comment: ['This is the description for a setting'], key: 'inlineValues' }, "Show variable values inline in editor while debugging."), 'enumDescriptions': [ nls.localize('inlineValues.on', 'Always show variable values inline in editor while debugging.'),

Discussion:
Today the "Debug: Inline Values" setting uses low-level "true" and "false" values (in addition to the more high-level "auto"): <img width="352" alt="CleanShot 2022-02-21 at 14 31 00 src="https://user-"I suggest to support (and surface in the UI) "on" and "off" values and only keep the booleans for backward compatibility.
Hi! Can I work on this issue?
I think this is a "good first issue", do you agree?
Yes, I would take a PR for this. Make sure that it's backwards compatible so that if a user has true or false set, those still work as they did before.
Change:
interface ActionButtonState { readonly HEAD: Branch | undefined; readonly isCommitInProgress: boolean; <ins> readonly isMergeInProgress: boolean; </ins> readonly isSyncInProgress: boolean; readonly repositoryHasChanges: boolean; }

Discussion:
a folder/workspace that contains a git repository a topic branch changes to main and the topic branch that would result in a merge conflict main into the topic branch to get a conflict Expected: commit action button is disabled Actual: commit action button is enabled
The button is now disabled while merging is in progress, but the button and the dropdown both take on a background color when clicked, which was confusing to me: !
Also, while the commit action button is disabled, the commit button above the input box is not: !
That is expected. At the moment the enablement is only toggled for the commit action button and not the commit action in the toolbar.
This is currently being tracked as
Change:
## Related Projects <del> Many of the core components and extensions to Code live in their own repositories on GitHub. For example, the [node debug adapter](https://github.com/microsoft/vscode-node-debug) and the [mono debug adapter](https://github.com/microsoft/vscode-mono-debug) have their own repositories. For a complete list, please visit the [Related Projects](https://github.com/Microsoft/vscode/wiki/Related-Projects) page on our [wiki](https://github.com/Microsoft/vscode/wiki). </del> <ins> Many of the core components and extensions to VS Code live in their own repositories on GitHub. For example, the [node debug adapter](https://github.com/microsoft/vscode-node-debug) and the [mono debug adapter](https://github.com/microsoft/vscode-mono-debug) have their own repositories. For a complete list, please visit the [Related Projects](https://github.com/Microsoft/vscode/wiki/Related-Projects) page on our [wiki](https://github.com/Microsoft/vscode/wiki). </ins> ## Bundled Extensions <del> Code includes a set of built-in extensions located in the [extensions](extensions) folder, including grammars and snippets for many languages. Extensions that provide rich language support (code completion, Go to Definition) for a language have the suffix `language-features`. For example, the `json` extension provides coloring for `JSON` and the `json-language-features` provides rich language support for `JSON`. </del> <ins> VS Code includes a set of built-in extensions located in the [extensions](extensions) folder, including grammars and snippets for many languages. Extensions that provide rich language support (code completion, Go to Definition) for a language have the suffix `language-features`. For example, the `json` extension provides coloring for `JSON` and the `json-language-features` provides rich language support for `JSON`. </ins> ## Code of Conduct

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was looking through the readme and for Visual Studio Code and noticed how it flip-flops between calling itself Code and alternatively VS Code. The inconsistency is a little confusing and I think Code alone is a little too ambiguous. I believe it would be more clear to consistently refer to itself as VS Code in documentation.
I've updated the How to Contribute wiki page as well. Thanks for pointing this out.
Change:
readonly postCommitCommandCenter: CommitCommandsCenter) { this._state = { HEAD: undefined, <ins> isCheckoutInProgress: false, </ins> isCommitInProgress: false, isMergeInProgress: false, isRebaseInProgress: false,

Discussion:
Type: <bBug</bto an existing branch from . Control Side panel then shows Sync Changes button. , clicking on Sync button causes to commits from previous branch to merge into current branch VS Code version: Code 1.74.3 (, 2023-01-09T16:59:02.252Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ laravel-blade1.1.2 jupyter-keymap1.0.0 remote-wsl0.72.0 alignment0.3.0 vscode-log-viewer0.12.2 vscode-intelephense-client1.9.4 gitlens13.2.0 cmake-tools1.13.44 cpptools1.13.9 cpptools-extension-pack1.3.0 laravel-blade1.32.0 cmake0.0.17 php-debug1.30.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
} editor.removeDecorations(currentDecorationIDs); <del> WordHighlighter.storedDecorations.delete(editor.getModel().uri); </del> <ins> deleteURI.push(editor.getModel().uri); </ins> const editorHighlighterContrib = WordHighlighterContribution.get(editor); if (!editorHighlighterContrib?.wordHighlighter) {

Discussion:
There is a strange issue in vs code when i split the window, and click on any code or syntax , it will highlight similar code/syntax but the highlig ht is persistent, it wont go away, it works fine in the first window but when it gets split to the right it doesnt work if i click anywhere else in the window, in the left side the currentCrew is highlighted now, it just wont clear. sys info Version: 1.84.2 (Universal) Commit: Date: 2023-11-09T10:52:33.687Z (1 wk ago) Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 21.6.0 <img width="1680" alt="Screen Shot 2023-11-22 at 9 42 52 AM" src=""
could you help with triaging this issue? Thanks!
Change:
<del> <svg width="351" height="225" viewBox="0 0 351 225" fill="none" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> </del> <ins> <svg viewBox="0 0 351 225" fill="none" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> </ins> <g clip-path="url(#clip0_1103_9950)"> <rect width="350.625" height="225" fill="#1E1E1E" /> <rect width="350.625" height="225" fill="url(#paint0_radial_1103_9950)" />

Discussion:
It seems something odd is appearing in our builds, specifically for our "video" svgs that has a link. The SVG doesn't contain anything crazy: Which throws the following error in the console: The strangest thing is in OSS everything looks fine but in the builds, the image is small and not centered. <img width="1089" alt="CleanShot 2022-02-23 at 09 01 27 src="https://user-"<img width="1024" alt="CleanShot 2022-02-23 at 09 01 14 src="https://user-"cc
Is this new? cc any recent changes to CSP?
I see this in Stable as well, so we likely never caught it
This is happening because the is being stripped out of this svg at some point during build.
Change:
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { IUserDataProfilesService } from 'vs/platform/userDataProfile/common/userDataProfile'; <del> export const enum ExtensionVerificationStatus { 'Verified' = 'Verified', 'Unverified' = 'Unverified', 'UnknownError' = 'UnknownError', } </del> <ins> export type ExtensionVerificationStatus = boolean | string; </ins> export type InstallExtensionTaskOptions = InstallOptions & InstallVSIXOptions & { readonly profileLocation: URI }; export interface IInstallExtensionTask {

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log
Change:
richEditConfig.onEnterRules = onEnterRules; } <del> LanguageConfigurationRegistry.register(languageIdentifier, richEditConfig); </del> <ins> LanguageConfigurationRegistry.register(languageIdentifier, richEditConfig, 50); </ins> } private _parseRegex(languageIdentifier: LanguageIdentifier, confPath: string, value: string | IRegExp) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --We have started to get reports from users that Toggle Line Comments does the wrong thing: I think this stems from the default Clojure extension which sets to be a single . Calva changes this here: This has been working for years, and still does for many people, but some days ago it stopped working for some. I also notice that the default extension has moved to its own repository, where there is now a PR to fix the line comment configuration: However, I think it is wrong that the default extension sometimes overrides an installed extension here. Then that API can't be trusted at all. I worry about what more configuration is now sometimes being overridden. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.52.1 OS Version: N/A Steps to Reproduce: Calva a file the command Toggle Line Comment on an uncommented line Expected: It gets commented with Actual: It gets commented with Please let me know how I can assist in fixing this issue. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Not applicable
I am surprised that this ever worked reliably, it must have been some amazing timing luck. defines a language configuration at . Language configuration file handling is implemented by waiting for the language to be first used (like embedded in another language like a markdown fence or a file using the language is opened) and then reading async the language configuration file and applying it. This is done . Whenever the language configuration file finishes reading, it will go and configure the in pretty much the exact same way an extension calling configures it . So deep down there is no difference between those two calls and basically those two calls are racing themselves and it is lucky that until now the call reading the descriptive file was always faster than the imperative call from your extension. If you want to be sure to overwrite the builtin language configuration, you can define your own language configuration file using: But I also see how you would expect that the imperative call would "win" over the descriptive way, so maybe we can do something on our side to give a higher priority to the imperative call way of configuring languages.
Thanks !

This is great information. Calva has been relying on this luck for a very long time. And yes, I actually choose to do it the imperative way very consciously, assuming it was the way to be sure I could override the defaults.
Change:
util "^0.11.0" vm-browserify "^1.0.1" <del> node-pty@0.11.0-beta31: version "0.11.0-beta31" resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.11.0-beta31.tgz#f1e7b79d437a96b50c23580475eb7d4bdceb577f" integrity sha512-fqsvKbdP1NuaFxu2zXborL/b5+CDrLruRK7CU0YaTjgbrYUsCR6IITCs1mORb1ZpIZ26ccvcc8TVfstGqwgl9g== </del> <ins> node-pty@0.11.0-beta32: version "0.11.0-beta32" resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.11.0-beta32.tgz#49c0f174f600ac3f54a21df2a41b6f78256ff6ce" integrity sha512-xtzB4/jYH64ksdVatYQnaU3TtCtSaDiiZPsZITmLHnywFSpI2bgfyj/bu6ofOXbe8PTtziL8bDn1U3xkRmx3mg== </ins> dependencies: nan "^2.17.0"

Discussion:
Use insiders-1.78 or run out of source start a terminal the name is "kernel_task" start a long running task, like , press and see it's not terminating https://user-
same question <img width="1024" alt="image" src="https://user-"
Same issue on my brand new Apple M2 Mac Mini. Running latest Insiders. I thought I was going crazy.
Works fine on latest version of insiders.
Yeah fixed now. Thanks everybody!
Not working for me. I am using
Not working for me after updating today (May 09, 2023) Version: 1.78.0 (Universal) Commit: Date: 2023-05-03T20:11:00.813Z Electron: 22.4.8 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 18.7.0 Sandboxed: Yes
That doesn't kill the process. It just suspends it. Just be aware of that (if you do it a lot ;)
same for me, no control-c or any kill commands will work: Version: 1.78.1 Commit: Date: 2023-05-04T09:57:42.343Z (5 days ago) Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 18.7.0 Sandboxed: No
It stopped working for me due to an extension which had created a key binding starting with so I removed the key binding and it started working. helped me.
what extension was causing the issue?
I forgot the name but you can check your keyboard bindings.
I don't have the same extensions as you?
Hi, this "Ctrl+C" (terminate task) feature suddenly stopped working a few days ago for us as well: the "^C" still displays in the terminal but without any effect and there is not a single shortcut associated to Ctrl+C and no way to add one This is a huge pain as we simply cannot work anymore using vs-code, this was such a central feature There is just so much content on the topic online, yet no simple solution: What happened?

Why did vs-code team do this? How is there not a simple option in Keyboard Shortcuts (JSON) to add it back? Thanks in advance to those currently working on a solution
what is shown in the vscode status bar when you press ?
it was a bug we introduced and fixed shortly afterwards, see One of the downsides of using Insiders is occasionally things like this slip in.
Never knew I was on those buggy Insiders builds. Hot damn. You need better wording on your main site. In any case, there is still no fix for this for Insiders and I am not really looking forward to installing and setting everything up from scratch with Universal.
Change:
if [ -n "$RPROMPT" ]; then RPROMPT="$__vsc_prior_rprompt" fi <del> __vsc_initialized="1" </del> __vsc_in_command_execution="1" <ins> __vsc_current_command=$1 </ins> __vsc_command_output_start } add-zsh-hook precmd __vsc_precmd

Discussion:
This is a follow up from which worked around the majority case of an issue. See the workaround: The proper fix will involve sending both the exit code and the history ID over to VS Code which will then do what's happening now but also have the correct exit code to set, instead of assuming it's the last command's exit code. We should write a little script as part of this that alternates exit codes by setting/unsetting an environment variable so it's easier to test and verify.
The issue being worked around is actually caused by or being included in .
Good test case from
To verify: some commands , they should all show up in current session ctrl+c in between some commands, including typing out a command and hitting ctrl+c to abandon it , the lines with ctrl+c shouldn't show up several times, failed and success should match whether the exception was thrown.
Change:
try { await this.doExportProfile(userDataProfilesExportState); } catch (error) { <ins> exportAction.enabled = true; </ins> this.notificationService.error(error); throw error; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0-insider (Universal) OS Version: MacOS 13.1 Steps to Reproduce (see video for details): Command Palette export profile and then press enter Export button on the slide menu a name Github (gist) option from the dropdown on cancel button the Export button in the side menu is still disabled The Export button should not disabled when its a github error , because if the user wants to export profile locally, they can only click on Close button first and then redo the entire step.
Change:
enableBreakpointsFor?: { languageIds: string[] }; configurationAttributes?: any; initialConfigurations?: any[]; <ins> aiKey?: string; </ins> win?: IRawEnvAdapter; winx86?: IRawEnvAdapter; windows?: IRawEnvAdapter;

Discussion:
If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).
this is probably something you want to use...
The functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .
we are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?
yes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?
What we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.
For Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?
previously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.