jiebi/CodeConvo huggingface dataset:
Change:
return this._replaceInput.getValue(); } <ins> protected get replacePattern() { if (this._state.isRegex) { return parseReplaceString(this.replaceValue); } return ReplacePattern.fromStaticValue(this.replaceValue); } </ins> public get focusTracker(): dom.IFocusTracker { return this._focusTracker; }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In Jupyter Notebooks, finding witrh regex works but replacing with capturing groups doesn't. I'd like if it does. I tried as in the usual editor, but the replacement treats as literal. I had to work around by copying the code section to the usual editor, and then find and replace. This seems like an inconsistent UX, and personally quite inconvinient.
Should I have opened this at ? If so, please close this so I can move on.
Thanks again for the help, it makes the find experience in notebook closer to the normal text editor one.
did you create a test plan item for this? I just the verification needed to it.
Change:
...nls.localize2('toggleBreakpointAction', "Debug: Toggle Breakpoint"), mnemonicTitle: nls.localize({ key: 'miToggleBreakpoint', comment: ['&& denotes a mnemonic'] }, "Toggle &&Breakpoint"), }, <ins> f1: true, </ins> precondition: CONTEXT_DEBUGGERS_AVAILABLE, keybinding: { when: ContextKeyExpr.or(EditorContextKeys.editorTextFocus, CONTEXT_DISASSEMBLY_VIEW_FOCUS),

Discussion:
Type: <bFeature Request</bWorkflow example: Currently, (AFAIK) there is no command to add a breakpoint at the cursor, so I have to move my hand over to the mouse (yuck) and click at the space left of the line number to add a breakpoint. It would be nice if there was a "add breakpoint at cursor" command here: ! VS Code version: Code 1.87.0 (, 2024-02-27T23:42:16.599Z) OS version: Linux x64 6.6.10--generic Modes: <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
It's called "Toggle breakpoint", and F9 is bound to it by default
Thanks for providing the hotkey, but the command doesn't show in the command palette. !
Sorry for the slow response but you're right and I will add it to the command palette
Change:
this.element = parent; this.rootContainer = append(parent, $('.titlebar-container')); <del> // Draggable region that we can manipulate for #52522 this.dragRegion = prepend(this.rootContainer, $('div.titlebar-drag-region')); </del> // App Icon (Native Windows/Linux and Web) if (!isMacintosh && !isWeb) { this.appIcon = prepend(this.rootContainer, $('a.window-appicon'));

Discussion:
Hello, Normally when you double click the top left of a Window, the application closes. When you double click vscode, the application maximizes. Can VSCode have this capability as well to close? !
We have logic to detect and handle double click in the custom title to restore / maximize the window but we missed to handle this case where on Windows it indeed seems to close the app. For this to work we probably have to detect a click on the icon and then call a different method to close instead of the current behaviour. Code pointers: //cc
Oh interesting, that code only runs on macOS, then I wonder what triggers this
Yes, very interesting. For other Windows apps, the menu appears when you single left click the top window as well. In VSCode when you Single Click the top left, nothing happens (In windows 10, all versions, latest VSCode)
Yeah that is expected, we draw the title custom entirely. We need to implement those native integrations on top. Maybe you report as separate issue.
I think you want this setting
doesn't seem to work anymore; I had it set for ages (along with to "custom"), but recently it doesn't seem to do anything...
Change:
async freePortKillProcess(port: string): Promise<void> { try { if (this._process?.freePortKillProcess) { <del> const result = await this._process?.freePortKillProcess(port); this._notificationService.notify({ message: localize('killportsuccess', 'Killed process with PID {0} listening on port {1}', result.processId, result.port), severity: Severity.Info }); </del> <ins> await this._process?.freePortKillProcess(port); </ins> } } catch (e) { this._notificationService.notify({ message: localize('killportfailure', 'Could not kill process listening on port {0}, command exited with error {1}', port, e), severity: Severity.Warning });

Discussion:
Testing a process listening on a conflicting port you get a notification that persists until you choose to close it Since terminal prompts often live right on the bottom of the window, this can be particularly annoying as it can get in the way of the prompt, which then requires a click I'm not sure the best fix for this, I think some indicator of success is useful but I don't think the loudness of a notification is appropriate
The notification is just a placeholder until we come up with some good feedback probably through the UX sync. I think removing it outright without an alternative would be a bad idea since we're killing a process. !
Change:
} if (e.affectsConfiguration(LayoutSettings.EDITOR_TABS_MODE) || e.affectsConfiguration(LayoutSettings.COMMAND_CENTER)) { this._yRange = undefined; <del> this.setYCoordinate(); </del> <ins> this.setCoordinates(); </ins> } })); this._register(this.debugToolBarMenu.onDidChange(() => this.updateScheduler.schedule()));

Discussion:
a breakpoint or log here or copy a file into a new floating window between them a few times. The event fires a couple times but then stops firing
does it reproduce without having devtools opened in any of the windows?
this one takes me by surprise: in the main process I keep track of auxiliary windows and so far I have been using as identifier, assuming it would always match . But as it turns out, that is actually not always the case: if I open devtools and restart or reload, I see how suddenly of does not match the of anymore. In other words, I see an id of for example for the of the floating window, while its has an of . So I do think that I am doing something wrong and I need a different way how to figure out the window ID of a floating window... I track the creation of floating windows here from the :
Ah, that's the repro. Yes, you must have devtools open when you open the aux window. Opening them after the aux window is already open doesn't cause an issue, but once you do open them then the event won't fire properly until vs code is restarted
That is not the intended contract in the runtime, a BrowserWindow can have multiple WebContents at any point and their ids are independent. WebContent ids are incremental within the same process, so it purely depends on the creation order. You can use to get the owner window and that should give you the right id.
I tried that, but at the time fires, returns . In other words, the web content is being created before the window is there... So essentially, I have no way to find the window for the web contents so early.
I think maintaining a would suit this scenario, you can access the webContents a BrowserWindow owns via and this will be valid even at . Should be reliable than id.
Yeah, an alternative would be to pro-long aux-window handshake between main and renderer until the is there but I think thats overkill. I will see to keep aux windows identified by . Its a bit inconsistent because both aux and main window share the same base class and the one will use and the other ...
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
editorGroupTemplate.actionBar.push(closeGroupAction, { icon: true, label: false, keybinding: closeGroupActionKey ? closeGroupActionKey.getLabel() : void 0 }); editorGroupTemplate.toDispose = []; <del> editorGroupTemplate.toDispose.push(dom.addDisposableListener(container, dom.EventType.DRAG_OVER, () => { dom.addClass(container, 'focused'); </del> <ins> editorGroupTemplate.toDispose.push(dom.addDisposableListener(container, dom.EventType.DRAG_OVER, (e: DragEvent) => { if (dropOnEditorSupported(e)) { dom.addClass(container, 'focused'); } </ins> })); editorGroupTemplate.toDispose.push(dom.addDisposableListener(container, dom.EventType.DRAG_LEAVE, () => { dom.removeClass(container, 'focused');

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.25.0-insider OS Version: Windows 10 Home - 1803 Steps to Reproduce: the Explorer sidebar tab the Outline or File Hierarchy views as if to rearrange them the cursor over an item in the Open Editors view individual editors will change color along with the entire view, making it seem as if you can drop a sidebar view into an open editor and something will happen. What should actually happen is that the view should highlight (since its location will be replaced; it does do this), but the individual items should not be affected. Screenshot: ! I am holding the File Hierarchy view over the file in that screenshot. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I acknowledge the issue, the problem is that the OpenEditor view is not differentiating between drag events PR to fix this is welcome
I was able to add a check to prevent the hover styling unless the item being dragged is another open editor in the list (see ), however this also means that when tabs are dragged over the Open Editors panel (ie, when there's multiple groups; you can drag a tab into a group and it will duplicate into that group), it doesn't have any styling anymore. I couldn't figure out a way to check if the dragged object is a tab. Is that feasible? Where would I look?
yeah it is not so simple You would need to check the dragged data. If there is an elegent solution to fix this please provide a PR. If too complex or computation intensive I would prefer to leave the issue open for now. Thanks
So just to make sure, the only things that should trigger the class on open editors are the open tabs and the other open editors in the list, correct?
no. Dragging resources from the explorer, adn dragging things outside of vscode should also trigger it
Change:
import { Promises } from 'vs/base/common/async'; import { generateUuid } from 'vs/base/common/uuid'; import { escapeRegExpCharacters } from 'vs/base/common/strings'; <ins> import { isString } from 'vs/base/common/types'; </ins> /** * Flags to indicate whether to use the default profile or not.

Discussion:
Testing Try to import this profile file: Restart VS Code. Observe that VS Code does not load anymore.
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ export function base64Encode(text: string): string { return btoa(text); } </ins>

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Currently signing out of your GitHub account only removes the token from the secret store but the token continues to be valid, which means that if it was leaked the attacker can continue to make use of it. To mitigate this, VS Code should revoke the token on sign out, see this API:
I wish this API didn't require the client secret...
Change:
registerEditorContribution(ModesHoverController.ID, ModesHoverController); registerEditorAction(ShowHoverAction); <del> registerEditorAction(ShowCtrlHoverAction); </del> <ins> registerEditorAction(ShowDefinitionPreviewHoverAction); </ins> // theming registerThemingParticipant((theme, collector) => {

Discussion:
IMHO using the keyboard modifier name in the action is not good, as IMHO the action name should describe what the action does, not one way in which the action is triggered. This gets very confusing when configuring . In this case, the definition preview is rendered in the editor hover with + hover. Perhaps a better name would be "Show Definition Preview Hover".
Thank you!
Release notes still use the old terminology: ! Version: 1.40.0-insider (user setup) Commit: Date: 2019-11-06T16:58:49.777Z Electron: 6.1.2 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.
stable release notes should have the updates, thanks for checking it out
Change:
"kotlin": { extensions: ['kt'] }, "mustache": { extensions: ['mustache', 'mst', 'mu', 'stache'] }, "nunjucks": { extensions: ['nunjucks', 'nunjs', 'nunj', 'nj', 'njk', 'tmpl', 'tpl'] }, <del> "ocaml": { extensions: ['ml', 'mli'] }, </del> <ins> "ocaml": { extensions: ['ml', 'mli', 'mll', 'mly', 'eliom', 'eliomi'] }, </ins> "puppet": { extensions: ['puppet'] }, "r": { extensions: ['r', 'rhistory', 'rprofile', 'rt'] }, "sass": { extensions: ['sass'] },

Discussion:
As the title says. Some extensions haven't been yet, so we need to add them.
this does not really work for me Am I doing something wrong? !
Is it the latest development build? If so, I think you need to wait until the next release.
This is the latest VS Code insiders from 5 hours ago.
Hmm, that's pretty strange... ~I may have forgotten to update this file:
Let's reopen and can comment
Yes, sorry for not paying attention. The file extension list in is used when we generate the vscode-seti theme from the repo. It is used to find an icon for a language () that is not part of our built-in languages, based on the file extension associations defined in You still need to install an extension that defines the language, and its file associations. E.g. Or you define the associations in the settings:
To verify check that our seti theme has a language icon for :
Is there any way to enable all "ocaml. *" as well?
Not sure what you mean. Associate all files that start with to the language?
Change:
description = this.labelService.getUriLabel(dirname(resource), { relative: true }); } <del> this.setResource({ resource, name, description, range: options?.range }, options); </del> <ins> this.setResource({ resource, name, description }, options); </ins> } setResource(label: IResourceLabelProps, options: IResourceLabelOptions = Object.create(null)): void {

Discussion:
Type: <bBug</bis used as delimiter instead of <img width="499" alt="image" src=""VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-23T05:35:37.619Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ project-manager12.7.0 vscode-eslint2.4.2 gitlens14.4.0 EditorConfig0.16.4 vscode-todo-plus4.19.1 code-runner0.12.1 vscode-pull-request-github0.74.0 gitlab-workflow3.81.0 vscode-peacock4.2.2 vscode-random1.11.0 rainbow-csv3.8.0 dotenv1.0.1 remote-containers0.318.0 remote-ssh0.107. remote-explorer0.5. material-icon-theme4.31.0 partial-diff1.4.3 code-spell-checker3.0.1 sort-lines1.11.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please use the command to investigate possible cause.
I am seeing it in Explorer too, in today's Insider, with all extensions disabled: !
I am bisecting now...
Hmm, nothing found. Maybe I am doing it wrong.
From
Change:
const keybinding = this.keybindingService.resolveKeyboardEvent(event); const label = keybinding.getLabel(); <del> if (!event.ctrlKey && !event.altKey && !event.metaKey && !event.shiftKey && this.keybindingService.mightProducePrintableCharacter(event) && label) { </del> <ins> if (!event.ctrlKey && !event.altKey && !event.metaKey && !event.shiftKey && (this.keybindingService.mightProducePrintableCharacter(event) || !keyboardMarker.textContent || keyboardMarker.textContent.length < 15) && label) { </ins> keyboardMarker.textContent += ' ' + label; } else { keyboardMarker.textContent = label;

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --show n characters when typing it scrolls so fast you only see some at a time !
Feel free to submit PR.
Instead of adding a setting, just increased the limit and clipped the screencast less.
Change:
} private get profilesVisibilityPreference(): boolean { <del> return this.userDataProfilesService.isEnabled() && this.storageService.getBoolean(ProfilesActivityActionViewItem.PROFILES_VISIBILITY_PREFERENCE_KEY, StorageScope.PROFILE, this.userDataProfilesService.profiles.length > 1); </del> <ins> return this.userDataProfilesService.isEnabled() && this.storageService.getBoolean(ProfilesActivityActionViewItem.PROFILES_VISIBILITY_PREFERENCE_KEY, StorageScope.PROFILE, true); </ins> } private set profilesVisibilityPreference(value: boolean) {

Discussion:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified
Change:
} export interface ITMSyntaxExtensionPoint { <del> language: string; </del> <ins> language?: string; // undefined if the grammar is only included by other grammars </ins> scopeName: string; path: string; embeddedLanguages: IEmbeddedLanguagesMap;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 89.1 x64 OS Version: Edition Windows 11 Pro Version 23H2 Installed on ‎2023-‎11-‎28 OS build .3593 Experience Windows Feature Experience Pack 1000..1003.0 Steps to Reproduce: the VS Code the introduction page of buildin plugin the FEATURES page 's Empty
I am seeing following !
Yes, I see the same. There should be details about supported languages like other built-in plugins.
Can you point me to the place I need to fix this?
Here it is
Change:
}, { "name": "CSS Property Name", <del> "scope": "support.type.property-name", </del> <ins> "scope": "source.css support.type.property-name", </ins> "settings": { "fontStyle": "", "foreground": "#676867"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0 (Universal) OS Version: Darwin arm64 23.2.0 Version: 1.88.0 (Universal) Steps to Reproduce: now json file color is this: <img width="906" alt="image" src=""it is different with before because i updated, i can't find the before color
Here is how it looks in 1.87: !
The JSON grammar has not changed in the last 4 years: And also the Monokai Dimmed theme has not changed recently:
Please give more inform about what has changed. Make sure you have to customised the theme in the settings.
Can you check the colors of v1.86.0? Perhaps it's a similar issue to this one:
<img width="517" alt="image" src=""
Please give more information about what has changed. The colors look the same to me.
Sorry, I made a mistake. There is also an issue with v1.86.0. Please take a look at v1.85.2
Please provide a screenshot of the version where it worked.
<img width="668" alt="image" src=""Version: 1.85.2
Change:
return commandService.executeCommand('editor.action.formatDocument'); } else { const langName = model.getLanguageIdentifier().language; <del> const message = nls.localize('no.provider', "There is no formatter for '{0}'-files installed.", langName); </del> <ins> const message = nls.localize('no.provider', "There is no formatter for '{0}' files installed.", langName); </ins> const choice = { label: nls.localize('install.formatter', "Install Formatter..."), run: () => showExtensionQuery(viewletService, `category:formatters ${langName}`)

Discussion:
Steps to Reproduce: Format Document from command palette when there are multiple formatters placeholder for the box to choose which formatter to use says "Select a default formatter for Flow-files" (in my case, the language is set to "Flow") "Flow-files" is weird, I don't think there should be a hyphen: Also here, but I don't know how to repro this one:
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.537 --- <!-- score: 0.485 --- <!-- score: 0.47 --<!-- potentialduplicatescomment --
I will prepare a PR.