jiebi/CodeConvo huggingface dataset:
Change:
const roomOnLeft = target.left; // Hover on the left is going beyond window. <del> if (roomOnLeft < this._hover.containerDomNode.clientWidth) { </del> <ins> if (roomOnLeft < this._hover.containerDomNode.clientWidth + hoverPointerOffset) { </ins> const roomOnRight = this._targetDocumentElement.clientWidth - target.right; // There's enough room on the right, flip the hover position <del> if (roomOnRight >= this._hover.containerDomNode.clientWidth) { </del> <ins> if (roomOnRight >= this._hover.containerDomNode.clientWidth + hoverPointerOffset) { </ins> this._hoverPosition = HoverPosition.RIGHT; } // Hover on the right would go beyond window too

Discussion:
a project with some kind of debugging and make sure the Breakpoints view is near the bottom of the screen over the pencil icon on the second-to-bottom list item. It works over the bottom list icon. The tooltip seems to appear and disappear very quickly causing the mouse to flicker (the FPS on the gif doesn't capture it very well but you can see that it doesn't render correctly) !
cc , this might have always been a bug but is probably now more exposed given its a custom hover now.
I haven't made any changes to the computation of where the hover should be placed in relation to the target, so a bug that we have had for a while, but should definitely look into. After testing a bit it seems to me that this only happens for ().
This also definitely used to work on language features and recently regressed (works fine in 1.87 stable): ! Reported the styling problem in
Change:
private fillDefaults(): void { this.add('msCompile', { <del> regexp: /^(?:s+d+>)?(S.*)((d+|d+,d+|d+,d+,d+,d+))s*:s+(error|warning|info)s+(w+d+)s*:s*(.*)$/, </del> <ins> regexp: /^(?:s*d+>)?(S.*)((d+|d+,d+|d+,d+,d+,d+))s*:s+((fatal +)?error|warning|info)s+(w+d+)s*:s*(.*)$/, </ins> kind: ProblemLocationKind.Location, file: 1, location: 2,

Discussion:
Type: <bBug</bIncluding a non-existent file in C++ causes an error that does not get matched. The problem is that the regex will match "error" but not "fatal error" (or "fatal error" with 2 spaces in the case of invoking msbuild instead of cl). VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-24T05:23:09.316Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I have a PR available for this:
I don't get a useful message about the problem in the problems view: <img width="317" alt="image" src=""Test task (for Windows at least):
I took a look at the PR for this to see if the problem matcher ever includes a message, and it does. The PR adds an optional group but doesn't increment the group numbers that each part of the problem is set as. I'm not sure how this would work for an optional group.
Please feel free to mark as verified if this is good enough.
pretty sure you found a bug. changing to will exclude the group from the result and not mess with the group indexes.
I do get a useful message now: <img width="1413" alt="image" src=""However when running Alex's provided task for the first time, I was prompted about which problem matcher I wanted to run on the output, and I don't think I should have to specify that again if my task already included a specific problem matcher
Change:
public setAriaOptions(): void { } public writeScreenReaderContent(): void { <ins> const focusedElement = getActiveWindow().document.activeElement; if (!focusedElement || focusedElement !== this._domNode.domNode) { return; } </ins> this._screenReaderContentState = this._getScreenReaderContentState(); if (!this._screenReaderContentState) { return;

Discussion:
Type: <bBug</bSteps to reproduce: window right click in editor area - it's hidden almost immediately (in come cases recording didn't catch it) right click in explorer tree, tabs, status bar - works as expected VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-11T05:04:03.124Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
Seems to happen on Windows but not on MacOS
The source of this bug has been found. After the context menu is shown, the screen reader content of the native edit context is updated, the document range is set. The context menu loses focus and is hidden. This issue happens in Windows but not on MacOS because Windows uses a different context menu logic. A fix will be found.
Works on my machine now Version: 1.94.0-insider Commit: Date: 2024-09-16T05:03:40.122Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
Thank you for verifying
Change:
} else { this._edits = this._edits <ins> .map(this._transformSnippetStringToInsertText, this) // mixed edits (snippet and normal) -> no snippet mode </ins> .sort((a, b) => Range.compareRangesUsingStarts(a.range, b.range)); this._editor.executeEdits('', this._edits); }

Discussion:
go to / vscode open change 200 to 50 create new branch observe that the closing brackets are replaced with } in inlineCompletionsModel please reassigned to who you think might be able to fix this. Looks like a github issue to me though. !
This looks similar to
Looks like similar thing was already fixed for organize imports and some TS actions in
This doesn't repro for me when using the stable VS Code quality on Confirmed that it still reproduces in the latest Insiders on commit
and this looks similar to
Please retry with latest insiders which should have a fix for this
can actually reproduce with latest insiders...
Change:
const info = suggestController.getOverwriteInfo(item, false); return { text: insertText, <del> range: Range.fromPositions(position.delta(0, -info.overwriteBefore), position.delta(0, info.overwriteAfter)), </del> <ins> range: Range.fromPositions( position.delta(0, -info.overwriteBefore), position.delta(0, Math.max(info.overwriteAfter, 0)) ), </ins> }; }

Discussion:
create a TS file: place cursor after and press wait for inline completions to render press arrow right https://user-
Interesting, I cannot reproduce this on main: !
Can you try to unbind the keybinding that arrow right accepts the completion ? (I think for me arrow right is moving cursor right and for you arrow right might accept the completion)
Oh I misread the issue description. But what should be the expected outcome? ~You can either only position the cursor directly before the decoration or directly after it, but not both. We explicitly want to set the cursor directly before it.~ Oh I see the point. It should properly predict what the suggest widget will do on insert.
I think the problem is that the view model updates only on document content change events and on suggest widget focus events and doesn't re-evaluate the common prefix on cursor position change events. i.e. here is what I would expect: !
Interestingly it works efor arrow left when you trigger the suggest widget at .
Change:
return isLinux ? 'native' : 'custom'; // default to custom on all macOS and Windows } <del> export function useWindowControlsOverlay(configurationService: IConfigurationService, environmentService: IEnvironmentService): boolean { if (!isWindows || isWeb || !environmentService.isBuilt) { return false; // only supported on a built desktop windows instance </del> <ins> export function useWindowControlsOverlay(configurationService: IConfigurationService): boolean { if (!isWindows || isWeb) { return false; // only supported on a desktop Windows instance </ins> } if (getTitleBarStyle(configurationService) === 'native') {

Discussion:
I tried enabling it in my Code-OSS settings but it didn't seem to work. The sentence from that I quoted make me think it had been hardwired off in Code-OSS. I haven't searched the codebase yet though. Originally posted by in
OSS does seem to have the WCO disabled. says that WCO was disabled in OSS due to upstream issues, but there's been a bunch of fixes recently, so it's probably OK to enable it again.
Verification steps: the WCO in OSS by enabling the setting. VS Code when prompted and change the colour theme. Windows 11, one can verify the WCO has been enabled by checking that the snap layout UX is available. On Windows 10, one can verify the WCO has been enabled by switching through colour themes and checking that the area with the minimize/maximize/close buttons updates its colours before the rest of the titlebar does.
Change:
currentLine = model.getLineContent(currentLineNumber); currentLineIsEmptyOrWhitespace = strings.lastNonWhitespaceIndex(currentLine) === -1; } <del> model.pushEditOperations(prevSelection, [EditOperation.delete(new Range(currentLineNumber + 1, 1, lineCount + 1, 1))], edits => prevSelection); </del> <ins> const deletionRange = new Range(currentLineNumber + 1, 1, lineCount + 1, 1); if (!deletionRange.isEmpty()) { model.pushEditOperations(prevSelection, [EditOperation.delete(deletionRange)], edits => prevSelection); } </ins> if (editor) { editor.setSelections(prevSelection);

Discussion:
VSCode Version: 1.18.1 Steps to Reproduce: : { "files.trimFinalNewlines": true } a file. Type something. Undo. Save. that Redo doesn't work, even though no newlines were trimmed. (Even if it did trim newlines, is it friendly to clobber the undo history anyway? Hmm...) trimTrailingWhitespace doesn't have this problem, despite its similar functionality. Note that with "autosave after delay" on, trying to redo anything is effectively toast. <!-- Launch with to check. --Reproduces without extensions: Yes
I'll have a look at this since I was the one who wrote the code in the first place, my bad. Should I look to use instead of ?
Change:
const i18nPackVersion = '1.0.0'; function getRecordFromL10nJsonFormat(l10nJsonFormat) { const record = {}; <del> for (const key of Object.keys(l10nJsonFormat)) { </del> <ins> for (const key of Object.keys(l10nJsonFormat).sort()) { </ins> const value = l10nJsonFormat[key]; record[key] = typeof value === 'string' ? value : value.message; }

Discussion:
I've reviewed/approved a couple update-localization PRs (e.g. ) and observed that there's always a few changes just due to reordered properties. E.g. in Would be great if we can avoid these, to keep the number of changes small and simplify the reviewing.
Fixed in ^^^ keep in mind that this change won't be used until around the 17th of Nov.
Change:
this._viewsService.openView(Markers.MARKERS_VIEW_ID); } else if (task.command.presentation && (task.command.presentation.focus || task.command.presentation.reveal === RevealKind.Always)) { this._terminalService.setActiveInstance(terminal); <del> await this._terminalService.revealActiveTerminal(); </del> <ins> await this._terminalService.revealTerminal(terminal); </ins> if (task.command.presentation.focus) { <del> this._terminalService.focusActiveInstance(); </del> <ins> this._terminalService.focusInstance(terminal); </ins> } } this._activeTasks[task.getMapKey()].terminal = terminal;

Discussion:
Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
In this scenario, focus also fails.
I can confirm that fixes the problem for me. Thanks!
Change:
private treeScrollTop: number | undefined; private treeContainer!: HTMLElement; private tree!: WorkbenchCompressibleAsyncDataTree<ISCMViewService, TreeElement, FuzzyScore>; <del> private treeIdentityProvider!: IIdentityProvider<TreeElement>; </del> private listLabels!: ResourceLabels; private inputRenderer!: InputRenderer;

Discussion:
Steps to Reproduce: a folder/workspace that contains a git repository change to a file "Commit & Push" from the action button Actual command not found Commit from the action button Actual command not found
Change:
type: 'boolean', description: localize('argv.force-renderer-accessibility', 'Forces the renderer to be accessible. ONLY change this if you are using a screen reader on Linux. On other platforms the renderer will automatically be accessible. This flag is automatically set if you have editor.accessibilitySupport: on.'), }; <ins> schema.properties!['password-store'] = { type: 'string', description: localize('argv.passwordStore', "Configures the backend used to store secrets on Linux. This argument is ignored on Windows & macOS.") }; </ins> } jsonRegistry.registerSchema(argvDefinitionFileSchemaId, schema);

Discussion:
Originally posted by in This was mostly an oversight on my part.
Fixed in In the (Configure Runtime Arguments) we have two improvements: both and now show up in completions (they no longer say "not allowed") in is plumbed through properly
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
verification: run: make sure and show up in completions make sure you are currently logged in to any account and have an extension that asks for auth now set to restart VS Code you should be asked to log in because you are now using the inmemory store remote the setting from your now restart VS Code you should be logged in again because you are no longer using the inmemory store
Sorry the completion should only be seen on Linux
Change:
private readonly _hashTable: HashTable; private _hasWarnedOverlappingTokens: boolean; <ins> private _hasWarnedInvalidLengthTokens: boolean; </ins> constructor( private readonly _legend: SemanticTokensLegend,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.2 OS Version: Win11 (but presumably affects all OSs) See , Steps to Reproduce: the Docker extension installed, open the Dockerfile example from , or simply enter this into a Dockerfile: VSCode freezing up We are independently working on the issue where negative-valued semantic tokens are returned, but invalid token data from the language service should not be causing VSCode to freeze up.
/cc
I'm not very familiar with semantic tokens, so if there's more info you can add here feel free!
I've tried reproducing this in a simple VS Code extension but have not had much luck. I do not see anything obvious in the LSP client bridge code so I feel like it should be reproducible in a regular extension also...
Yes, agree. This should be reproducible in a VS Code extension also.
Thanks for the speedy fix!
Change:
color: ${debugViewStateLabelForegroundColor}; } <ins> /* State "badge" displaying the active session's current state. * Only visible when there are more active debug sessions/threads running * and thread paused due to a thrown exception. */ .debug-pane .debug-call-stack .thread > .state.label.exception, .debug-pane .debug-call-stack .session > .state.label.exception, .debug-pane .monaco-list-row.selected .thread > .state.label.exception, .debug-pane .monaco-list-row.selected .session > .state.label.exception { background-color: ${debugViewExceptionLabelBackgroundColor}; color: ${debugViewExceptionLabelForegroundColor}; } </ins> /* Info "badge" shown when the debugger pauses due to a thrown exception. */ <del> .debug-pane .debug-call-stack-title > .pause-message > .label.exception { </del> <ins> .debug-pane .call-stack-state-message > .label.exception { </ins> background-color: ${debugViewExceptionLabelBackgroundColor}; color: ${debugViewExceptionLabelForegroundColor}; }

Discussion:
Issue Type: <bBug</bDebug a program that throws an exception (any language). Hover over the paused message text. Expected: (this screenshot is from v1.49.0) The 'Text' information to be displayed on hover. The color of the pause message background to be 'red'. ! Got: The same name shown on hover. The color of the pause message background was grey. ! VS Code version: Code 1.56.0 (, 2021-05-04T22:06:21.189Z) OS version: Darwin x64 20.4.0 <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ gitlens11.4.1 EditorConfig0.16.4 prettier-vscode6.4.0 vscode-diff1.4.1 go-nightly2021.5.1113 cloudcode1.11.1 vscode-docker1.12.1 python2021.5. vscode-pylance2021.5.1 jupyter2021.6. remote-containers0.177.2 remote-ssh0.65.4 remote-ssh-edit0.65.4 remote-wsl0.56.2 vscode-remote-extensionpack0.21.0 vscode-typescript-tslint-plugin1.3.3 reload0.0.6 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
The information displayed on the hover now seems to be the file name rather than the Python exception type, at least within Codespaces. is this expected behaviour?
/verified
are you hovering over the stopped description? I am getting the correct hover text <img width="462" alt="Screen Shot 2021-06-04 at 9 08 51 PM" src="https://user-"
Change:
const preferredHomeConfig = this.configurationService.inspect<string>('files.dialog.defaultPath'); const preferredHomeCandidate = preferLocal ? preferredHomeConfig.userLocalValue : preferredHomeConfig.userRemoteValue; if (preferredHomeCandidate) { <del> const pathLib = preferLocal ? path : await this.pathService.path; if (pathLib.isAbsolute(preferredHomeCandidate)) { const preferredHomeNormalized = pathLib.normalize(preferredHomeCandidate); </del> <ins> const isPreferredHomeCandidateAbsolute = preferLocal ? localPathIsAbsolute(preferredHomeCandidate) : (await this.pathService.path).isAbsolute(preferredHomeCandidate); if (isPreferredHomeCandidateAbsolute) { const preferredHomeNormalized = preferLocal ? localPathNormalize(preferredHomeCandidate) : (await this.pathService.path).normalize(preferredHomeCandidate); </ins> const preferredHome = resources.toLocalResource(await this.pathService.fileURI(preferredHomeNormalized), this.environmentService.remoteAuthority, this.pathService.defaultUriScheme); if (await this.fileService.exists(preferredHome)) { return preferredHome;

Discussion:
I pushed this: And the build error from is:
Relies on structural equivalence, e.g the shape of all exported properties of the -modules happens to match that of the interface. Mangling renames the exported properties and hence breaks this equivalence. Technically this happens with any rename and the difference with mangling is just that renaming happens implicitly during build. Did you encounter similar situation before and how did you deal with them?
Yes I fixed a handful of cases where an entire module's shape was taken as API: There were so few instances of this, and it was so easy to work around, that I decided it didn't block merging Not sure there's a smarter way to handle this. To fix the error, simply list the specific properties you need from the module. Take a look at what the example above with does as an example
Change:
padding-right: 20px; } <del> .monaco-workbench .editor-instance .terminal-group .monaco-split-view2.horizontal .split-view-view:first-child .xterm .terminal-command-decoration, </del> .monaco-workbench .pane-body.integrated-terminal .terminal-group .monaco-split-view2.horizontal .split-view-view:first-child .xterm .terminal-command-decoration { margin-left: -17px; } <del> .monaco-workbench .editor-instance .terminal-group .monaco-split-view2.horizontal .split-view-view .xterm .terminal-command-decoration, </del> <ins> .monaco-workbench .editor-instance .xterm .terminal-command-decoration, .monaco-split-view2.vertical .split-view-view .xterm .terminal-command-decoration, </ins> .monaco-workbench .pane-body.integrated-terminal .terminal-group .monaco-split-view2.horizontal .split-view-view .xterm .terminal-command-decoration { margin-left: -12px; }

Discussion:
Testing terminal into side panel :bug: decorations render on top of output text, nothing happens when you click on the decorations
same for dragging and dropping into the editor area
related
Their alignment is wrong, but the context menus work for me. !
original issue was a duplicate of Renaming to address the alignment issue
The decorations might benefit from a little padding when in the side panel: ! Versus in the bottom panel: !
I agree that it looks quite cramped there. You'll also see it looking similarly cramped for split terminals (besides the first one). That's because we have of left padding for those vs for the first split. I don't think we plan to change this. Thoughts ? One option would be to decrease the size of the icon so that there's more room.
We could add a dedicated 20px column there when shell integration is on, regardless of split status? Similar to how disabling folding will hide the folding column in the editor. Shall we capture this improvement in another issue?

shell integration some commands and drop the terminal in the editor area a decoration context menu
the inverse is also broken - drag from editor area to panel click a decoration no context menu
The context menu is working for me now, but the alignment is not correct !
original issue was a duplicate of Renaming to address the alignment issue
Change:
this._register(this._cell.model.onDidChangeOutputs(() => this._updateSoon())); } <ins> public update(): void { this._updateSoon(); } </ins> private _updateSoon(): void { // Wait a tick to make sure that the event is fired to the EH before triggering status bar providers this._register(disposableTimeout(() => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Basically when i have a statusbar item (extension that contributes statusbar items), VS Code re-creates all of the statusbar items for all cells. This causes ALL statubar items in all cells to flicker (as its destroyed and re-created) & we also end up with duplicates. /cc Flickering UI Duplicate statusbar items See below (from latest VS Code Insiders, can also replicate in latest main branch) Note how we end up with two language pickers in statusbar. ! After the fix (re-use instead of re-creating & only create what we need): !
Thought I had squashed all of these. Thanks for the PR!
The power tools don't seem to provide line numbers anymore so I tried switching the language mode around to repro and couldn't so I'm not sure if that's good enough for verification
I think it's sufficient to mess around with it and not see any dupes. And there were random reports of dupes earlier and I haven't heard that in awhile.