jiebi/CodeConvo huggingface dataset:
Change:
let preferredResults: string[] = []; if (text) { options = assign(options, { text: text.substr(0, 350), source: 'searchText' }); <del> for (let i = 0; i < this.searchExperiments.length; i++) { if (text.toLowerCase() === this.searchExperiments[i].action.properties['searchText'] && Array.isArray(this.searchExperiments[i].action.properties['preferredResults'])) { preferredResults = this.searchExperiments[i].action.properties['preferredResults']; options.source += `-experiment-${this.searchExperiments[i].id}`; break; </del> <ins> if (!hasUserDefinedSortOrder) { for (let i = 0; i < this.searchExperiments.length; i++) { if (text.toLowerCase() === this.searchExperiments[i].action.properties['searchText'] && Array.isArray(this.searchExperiments[i].action.properties['preferredResults'])) { preferredResults = this.searchExperiments[i].action.properties['preferredResults']; options.source += `-experiment-${this.searchExperiments[i].id}`; break; } </ins> } } } else {

Discussion:
Issue Type: <bBug</bSee below screenshot, it is not sorted by install count: ! VS Code version: Code 1.28.0 (, 2018-10-05T14:58:53.203Z) OS version: Windows_NT x64 10.0.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.5 --- <!-- score: 0.458 --- <!-- score: 0.446 --<!-- potentialduplicatescomment --
Change:
const content = createOutputContent(outputInfo.id, formattedStack, outputOptions); const stackTraceElement = document.createElement('div'); stackTraceElement.appendChild(content); <del> stackTraceElement.classList.toggle('word-wrap', ctx.settings.outputWordWrap); </del> <ins> outputElement.classList.toggle('word-wrap', ctx.settings.outputWordWrap); </ins> disposableStore.push(ctx.onDidChangeSettings(e => { <del> stackTraceElement.classList.toggle('word-wrap', e.outputWordWrap); </del> <ins> outputElement.classList.toggle('word-wrap', e.outputWordWrap); </ins> })); if (minimalError) {

Discussion:
[ ] Notebooks (.ipynb files) [X] Interactive Window and/or Cell Scripts (.py files with #%% markers)Turn on in Turn on in Open an interactive window and run the following code snippet Version: 1.89.0 Commit: Date: 2024-05-01T02:08:25.066Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Linux x64 6.8.0-76060800daily20240311-generic v2024.4.0 Python v3.12.1 No response No response Local
Change:
this.inputBox.value = this._inputValue; } <del> private _reset() { this._chords = null; } </del> private _onKeyDown(keyboardEvent: IKeyboardEvent): void { keyboardEvent.preventDefault(); keyboardEvent.stopPropagation();

Discussion:
Type: <bBug</bPreviously pressing escape while "Record Keys" was active in the keybindings UI would disable key recording and leave the search query intact. Now it disables key recording and clears the search query which makes it much harder to use. I traced this regression to 1.78. I'm guessing this is an issue with keybindings. The binding for is being processed in addition to the (hard-coded?) binding to stop recording. ! VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-04T22:11:08.187Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ interface ArrayConstructor { isArray<T>(arg: ReadonlyArray<T> | null | undefined): arg is ReadonlyArray<T>; isArray<T>(arg: Array<T> | null | undefined): arg is Array<T>; isArray(arg: any): arg is Array<any>; isArray<T>(arg: any): arg is Array<T>; } </del>  No newline at end of file

Discussion:
What is the reasoning behind not allowing via the Monaco standalone editor checks? It seems to be valid ES6 when I look at where it is defined:
idk - requires at least edge 14, unsure what our edge minimum version is:
Looking at the compat tables, I think it should be safe to use it. I guess it must have been a left-over from the IE era. I don't remember adding any rule like this, so I don't know where to begin looking to remove it. Leaving it to you .
I opened to do this and it has the advantage that we can get rid of another file in our folder () which actually even seems to have the wrong signature compared to TS. According to , Edge 13 has very low usages and Edge 14 is out since 2016: !
Unsure how and are connected. Or is this two clean-ups in one? I have the latter because for the longest time there was a TS bug which would remove type info from arrays after checking E.g If that's now fixed, I am very happy with removing
ah good to know, I just checked both in our code and the playground and I see that this no longer seems to be the case: ! I will go ahead and merge my PR then.
it
Change:
export async function parentOriginHash(parentOrigin: string, salt: string): Promise<string> { // This same code is also inlined at `src/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html` if (!crypto.subtle) { <del> throw new Error(`Can't compute sha-256`); </del> <ins> throw new Error(`'crypto.subtle' is not available so webviews will not work. This is likely because the editor is not running in a secure context (https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts).`); </ins> } const strData = JSON.stringify({ parentOrigin, salt }); const encoder = new TextEncoder(); const arrData = encoder.encode(strData);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.2 OS Version: Steps to Reproduce: have developed an extension, the extension has some webview page, then I install on VSCodeit is ok, the webview is shown; I run it on code-server, my ip is 192.168.88.212, then I input http://127.0.0.1:3000, it is also ok, the webview page is shown; I input 192.168.88.212:3000, the webview page is not shown, and the error is "Can't compute sha-256" you help to fix it ? thank you very much
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thank you for reply very much, I have download the vscode-1.71.2, and then I install and run, the problem still exits, Can you help me?
Do other webviews work, such as the built-in markdown preview or release notes page?
It also not works
I investigated this a determined this is a limitation of how our webviews are implemented. To use them, the editor needs to be running in a This includes but would not include an ip such as . That is why works. This feature would also for other ips if you can use instead of Closing since this is by-designed, although I've a more clear error message in
Change:
primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_BACKTICK, mac: { primary: KeyMod.WinCtrl | KeyMod.Shift | KeyCode.US_BACKTICK }, weight: KeybindingWeight.WorkbenchContrib <ins> }, description: { description: 'workbench.action.terminal.new', args: [{ name: 'eventOrOptions', schema: { type: 'object' } }] </ins> } }); } <del> async run(accessor: ServicesAccessor, event: unknown) { </del> <ins> async run(accessor: ServicesAccessor, eventOrOptions: MouseEvent | ICreateTerminalOptions | undefined) { </ins> const terminalService = accessor.get(ITerminalService); const terminalGroupService = accessor.get(ITerminalGroupService); const workspaceContextService = accessor.get(IWorkspaceContextService); const commandService = accessor.get(ICommandService); const folders = workspaceContextService.getWorkspace().folders; <del> if (event instanceof MouseEvent && (event.altKey || event.ctrlKey)) { </del> <ins> if (eventOrOptions && eventOrOptions instanceof MouseEvent && (eventOrOptions.altKey || eventOrOptions.ctrlKey)) { </ins> const activeInstance = terminalService.activeInstance; if (activeInstance) { const cwd = await getCwdForSplit(terminalService.configHelper, activeInstance);

Discussion:
The terminal commands and are used for both the panel buttons and the commands in the CP (that we do want to use the defaultLocation for). Not sure how to differentiate between them - don't think we want to duplicate the actions. let me know what you think
Let's wait until after is done since that will likely add target support to the create commands
Other reproes: Ctrl / Cmd J to open the panel - terminal editor is created focus the terminal editor, click the trash can on the panel , close the editor tab - a bunch of errors in the console
Change:
import { Categories } from 'vs/platform/action/common/actionCommonCategories'; import { IWorkingCopyBackupService } from 'vs/workbench/services/workingCopy/common/workingCopyBackup'; import { ResolutionResult, ResultKind } from 'vs/platform/keybinding/common/keybindingResolver'; <ins> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; import { IOutputService } from 'vs/workbench/services/output/common/output'; import { windowLogId } from 'vs/workbench/services/log/common/logConstants'; </ins> class InspectContextKeysAction extends Action2 {

Discussion:
Run the command . Nothing happens Can we show the dev tools or open an output view that gets focus? From describing a user how to help us debugging an issue with storage:
The action also runs in browsers where we cannot open devtools automatically. We cannot use the output view because we actually show a real table: <img width="1394" alt="image" src=""But we can inform the user via dialog.
For the other action "Log working copies" I will reveal the window log where it is logged to.
Change:
'use strict'; import { Uri, commands, Disposable, window, workspace, QuickPickItem, OutputChannel, Range, WorkspaceEdit, Position, LineChange, SourceControlResourceState, TextDocumentShowOptions, ViewColumn, ProgressLocation, TextEditor, MessageOptions } from 'vscode'; <del> import { Ref, RefType, Git, GitErrorCodes, Branch } from './git'; </del> <ins> import { Ref, RefType, Git, GitErrorCodes, Branch, Stash } from './git'; </ins> import { Repository, Resource, Status, CommitOptions, ResourceGroupType } from './repository'; import { Model } from './model'; import { toGitUri, fromGitUri } from './uri';

Discussion:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!
Change:
// update all decorations const oldDecorationsIds = this._decorationTypeKeysToIds[decorationTypeKey] || []; <del> this._decorationTypeKeysToIds[decorationTypeKey] = this.deltaDecorations(oldDecorationsIds, newModelDecorations); </del> <ins> this.changeDecorations(accessor => this._decorationTypeKeysToIds[decorationTypeKey] = accessor.deltaDecorations(oldDecorationsIds, newModelDecorations)); </ins> } public removeDecorationsByType(decorationTypeKey: string): void { // remove decorations for type and sub type const oldDecorationsIds = this._decorationTypeKeysToIds[decorationTypeKey]; if (oldDecorationsIds) { <del> this.deltaDecorations(oldDecorationsIds, []); </del> <ins> this.changeDecorations(accessor => accessor.deltaDecorations(oldDecorationsIds, [])); </ins> } if (this._decorationTypeKeysToIds.hasOwnProperty(decorationTypeKey)) { delete this._decorationTypeKeysToIds[decorationTypeKey];

Discussion:
Open the chat sidebar Type , pick from suggest widget Pick a file, so it reads eg Delete the full contents of the input with cmd+backspace Get this error I think I understand what's happening here. I have two listeners that each call . The first one runs, and after setting decorations, it calls to continue firing events, so my second listener runs, and also calls . And this is considered recursive because it happens before was decremented but isn't "really" recursive, to me. So is it bad practice to call synchronously inside ? Or is there something else I should be doing differently?
I think the actual problem is that is used here: This should use instead. Feel free to provide a PR.
Change:
import { isAncestor, trackFocus } from 'vs/base/browser/dom'; import { WorkbenchList } from 'vs/platform/list/browser/listService'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <del> import { IListOptions } from 'vs/base/browser/ui/list/listWidget'; </del> <ins> import { IListAccessibilityProvider, IListOptions } from 'vs/base/browser/ui/list/listWidget'; </ins> import { NOTIFICATIONS_BACKGROUND } from 'vs/workbench/common/theme'; import { INotificationViewItem } from 'vs/workbench/common/notifications'; import { NotificationsListDelegate, NotificationRenderer } from 'vs/workbench/browser/parts/notifications/notificationsViewer';

Discussion:
Testing Repro: some notifications and focus one. You should hear a hint about opening the notification in the accessible view. !
Oh, this is because it's not focused. I found this a little confusing as the info message doesn't say it's a notification or anything so how would a new user know how to answer the question?
I'm still hitting this sometimes when the notification is focused as well No verbosity settings are set here: !
When this happens alt+f2 doesn't work It might be something off with context keys?
Proof: !
I was also going to report this - I triggered this notification and selected it to focus it, but I didn't get a hint: !
I have occasionally found that this does not work when I have the screen reader text view open. Can you try with that closed and speech on / volume up?
Is that the speech viewer / text box shows in his screenshots? I didn't have that open in my flow afaik.
I need to add to the aria label - currently, it's just to the free floating notification element
It's better now, but the hint still doesn't show up if the notification appears and the user tabs to it. The hint shows up if the user tabs to the button, but then Alt+F2 doesn't work while the user is on the button. Good: the screen reader optimized button. the notification. the show notification command. is properly displayed. Bad notifications from the notifications center. the screen reader optimized button. tab until the focus is on the notification. Enable tab moves focus mode if needed. :bug: The hint doesn't show up, and pressing Alt+F2 doesn't work. tab until the focus is on the Yes button. :bug: The hint shows up, but pressing Alt+F2 doesn't work. Let me know if you're able to reproduce the issue and whether it's worth reopening.
Thanks I'll probably wait to see if this is an issue screen reader users encounter.
Change:
} private async _startMonitoringShell(): Promise<void> { <del> if (!windowsProcessTree) { windowsProcessTree = await import('windows-process-tree'); } </del> if (this._isDisposed) { return; }

Discussion:
I see that is called very early here: Even though only used in some method later. Can we please move it where it is being used only to ensure we do not block startup?
Sure this can move it further down. It will only save ~5ms on Windows and only if the terminal is restored on start up.
Change:
// align from the bottom so that it lines up with instruction when source code is present. container.style.alignSelf = 'flex-end'; <del> const icon = append(container, $('.disassembly-view')); icon.classList.add('codicon'); </del> <ins> const icon = append(container, $('.codicon')); </ins> icon.style.display = 'flex'; icon.style.alignItems = 'center'; icon.style.justifyContent = 'center';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.91.1 Commit: Date: 2024-07-09T22:06:49.809Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView with an TreeItem the TreeItem's iconPath to the extension. The TreeItem's icon will still be yellow same as in debugging. After inspecting developer tools, this is likely due to how the icon debug-stackframe's color rule is set to !important. The ThemeColor fails to overwrite it due to low specificity. This may not only happen with the icon "debug-stackframe" and is affecting customisations of treeitems. Why is some icons' color rules given the !important flag et al? There might not be any easy fix due to this flag's present. I hope the team could look into it, and if possible fix this selector specificity issue (if it won't break vscode, somehow).
Edit: This not only occurs on special icons like debug-stackframe, but also on very ordinary ones like circle-filled.

style attribute { color: rgb(204, 204, 204); } .monaco-workbench .codicon { } Adding !important to the color flag of .monaco-workbench .codicon will fix the issue though.. The problem is worse :C
I think the best solution would be to get rid of that . it's coming from here. Can it be removed? The css you shared is correct. The rbg value is the one you set in your ThemeIcon. !
Yea, we should scope these rules better (and also move them to css now that we have variables there)
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
registerDocumentRangeFormattingEditProvider(extension: IExtensionDescription, selector: vscode.DocumentSelector, provider: vscode.DocumentRangeFormattingEditProvider): vscode.Disposable { const canFormatMultipleRanges = typeof provider.provideDocumentRangesFormattingEdits === 'function'; <del> if (canFormatMultipleRanges) { checkProposedApiEnabled(extension, 'formatMultipleRanges'); } </del> const handle = this._addNewAdapter(new RangeFormattingAdapter(this._documents, provider), extension); this._proxy.$registerRangeFormattingSupport(handle, this._transformDocumentSelector(selector, extension), extension.identifier, extension.displayName || extension.name, canFormatMultipleRanges); return this._createDisposable(handle);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --With set to , VSCode will sequentially send requests to its provider(s). It'd be nice if the whole list of ranges could be sent at once instead of sequentially, allowing the formatter to handle this batch as it sees fit. This could be achieved by modifying to take an additional optional metadata parameter that the provider can use to express support for this mode.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Would the team be open to PR for this change? I'm happy to provide one.
To give additional context, we've had user reports like this: When a file has lots of modified chunks, we see lots of round-trips to the server. Batching the requests can provide a very important performance improvement in some cases.
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding!
feedback from API sync, have explicit optional function
fyi this is done and LSP adoption is welcome
already provided a PR for LSP.
To verify: make sure API has a new optional function and make sure it's properly documented (extra) write a dummy extension that implements this and make sure it's called
Change:
PathSeparatorClause = '/', // '":; are allowed in paths but they are often separators so ignore them // Also disallow  to prevent a catastropic backtracking case #24795 <del> ExcludedPathCharactersClause = '[^0s!`&*()'":;]', ExcludedStartPathCharactersClause = '[^0s!`&*()[]'":;]', </del> <ins> ExcludedPathCharactersClause = '[^0<>s!`&*()'":;]', ExcludedStartPathCharactersClause = '[^0<>s!`&*()[]'":;]', </ins> WinOtherPathPrefix = '..?|~', WinPathSeparatorClause = '(?:|/)',

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Exclude both at the start and at the end from filepath detection. See this screenshot. <img width="2560" alt="Screenshot 2023-03-25 at 15 01 58" src="https://user-"The file path is detected but includes the surrounding angle brackets. Doing a to go to the file causes it to not be found. If one removes the angle brackets from the search manually, then it finds the file.
This actually works fine for me: ! Is relative to the current working directory?
Weird... No. The actual file I want to go is at but it was compiled as , so my logger used the compiled name as base path. I'm using latest version of vscode (1.76.2) and the integrated terminal is running zsh, on macOS. Looks like the difference is that you are running on Windows Powershell.
Can you try using the Insiders build here?
Sure. Just for completeness, even if I pass the actual relative path, it doesn't work. See the screenshot (still using stable). <img width="2560" alt="Screenshot 2023-03-27 at 16 17 20" src="https://user-"
Tested with insider and same behaviour. <img width="2560" alt="Screenshot 2023-03-27 at 16 21 08" src="https://user-"
Can repro on macOS <img width="226" alt="Screenshot 2023-03-27 at 12 58 16 pm" src="https://user-"