jiebi/CodeConvo huggingface dataset:
Change:
@IWorkbenchExtensionEnablementService private readonly extensionEnablementService: IWorkbenchExtensionEnablementService ) { super(); <ins> this.onServiceChange(); </ins> this._register(Event.debounce(extensionsWorkbenchService.onChange, () => undefined, 100, undefined, undefined, this._store)(this.onServiceChange, this)); }

Discussion:
re The automatic perf monitoring has shown a high number of calls to . This means the call/function itself is slow or it is called at a very high rate (so that the profiler always sees it running) The most common stacktrace via which this is reported comes through .
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I don't think this is a dupe because the callstack comes in via which I don't see in the other trace
But I think the root cause is same for both that is slow as mentioned in the summary of the other issue. Hence I marked it as duplicate.
Pfff - that would mean it is catastrophically slow. My suspicion is that it is just slow but that comes in combination with being over eagerly called? Maybe some event leakage or some over eager calling through some other means. This symptom might disappear when has become fast but I think we need to understand why it ends up on a hot code path in the first place
Will investigate why this is being eagerly called too.
Change:
padding: 4px; text-align: center; cursor: pointer; <ins> outline-offset: 2px !important; </ins> } .monaco-text-button:hover {

Discussion:
Environment Details: VSCode Version : 1.24.0 OS Version : Win10 Additional Details: MAS Violated : MAS 2.4.7 Repro Steps: to Status Bar at the bottom and move to notifications. to any notification that appears at the screen. to any button inside the notification. Actual: The focus is not marked using dotted-lines/rectangle to indicate the focus on the buttons. Only color changes to mark the focus on the buttons. Expected: The focus should be visible using dotted-lines/rectangle to indicate the focus on the buttons. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: Low vision/visually impaired users should be able to distinguish the focused element. MAS Reference: MAS2.4.7 - {-4fab-4d3e-81af-} Attachment For Reference: Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.664 --- <!-- score: 0.545 --- <!-- score: 0.481 --<!-- potentialduplicates_comment --
we have a high contrast theme for people that want a much stronger focus indication, isn't that sufficient? !
Agreed focus visibility is working for High contrast theme. But all low vision users may not be comfortable in using only one theme(here High Contrast). Other users using "Light Visual Studio" will again face issues in focus visibility. Switching themes may not be always a good option. Dotted-lines/rectangle to indicate focus can serve purpose for all of the themes listed.
There is a border around the button when it gets focus but the border (blue) color collides with the blue background of the button. It may work better in other themes.
do we plan to do something here? If no we should close as invalid and explain why fyi since it is a contrast issue
I am happy for suggestions.

we did start showing the outline with an offset in the extension viewlet: <img width="420" alt="image" src="https://user-"We could try the same thing with our primary buttons: <img width="477" alt="image" src="https://user-"
I actually like that if we can make it so that it really only shows up on focus but e.g. not when clicking (this might be a bit tricky to get right).
Gives me a bit of a blurry effect. Definetly would not like to get it on click. THough might be one of those things that I need to really try out to get a complete impression
Change:
} storageService.onWillSaveState(this.onWillSaveState, this, this.disposables); <ins> // Maintain repository selection when the extension host restarts. // Extension host is restarted after installing an extension update // or during a profile switch. extensionService.onWillStop(() => { this.onWillSaveState(); this.didFinishLoading = false; }, this, this.disposables); </ins> } private onDidAddRepository(repository: ISCMRepository): void {

Discussion:
I end up with all my repositories selected when going into an empty profile and out again: !
we figured out together that this reproduces easily by running the command to restart the extension host while having 1 repository selected. The underlying issue is that there are events fired from the extension host being disposed. This somehow has an impact on the state of the selected repositories and should probably be ignored or handled differently.
Change:
export const remoteName: string | undefined; /** <ins> * The detected default shell for the extension host, this is overridden by the * `terminal.integrated.shell` setting for the extension host's platform. */ export const shell: string; /** </ins> * Opens an *external* item, e.g. a http(s) or mailto-link, using the * default application. *

Discussion:
Provided the Python extension uses the API and it works as expected (), we should finalize it in July.
To verify just do a quick test that it seems to be working as expected on any platform, a more thorough test was done in the June milestone.
Change:
} } <ins> public warnInvalidLengthSemanticTokens(lineNumber: number, startColumn: number): void { if (!this._hasWarnedInvalidLengthTokens) { this._hasWarnedInvalidLengthTokens = true; console.warn(`Semantic token with invalid length detected at lineNumber ${lineNumber}, column ${startColumn}`); } } </ins> } const enum SemanticColoringConstants {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.2 OS Version: Win11 (but presumably affects all OSs) See , Steps to Reproduce: the Docker extension installed, open the Dockerfile example from , or simply enter this into a Dockerfile: VSCode freezing up We are independently working on the issue where negative-valued semantic tokens are returned, but invalid token data from the language service should not be causing VSCode to freeze up.
/cc
I'm not very familiar with semantic tokens, so if there's more info you can add here feel free!
I've tried reproducing this in a simple VS Code extension but have not had much luck. I do not see anything obvious in the LSP client bridge code so I feel like it should be reproducible in a regular extension also...
Yes, agree. This should be reproducible in a VS Code extension also.
Thanks for the speedy fix!
Change:
]); mark('code/willInitWorkspaceConfiguration'); <del> await this.loadConfiguration(application, user.local, user.remote); </del> <ins> await this.loadConfiguration(application, user.local, user.remote, trigger); </ins> mark('code/didInitWorkspaceConfiguration'); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Windows 11 x64 Steps to Reproduce: an extension that implements a FileSystemProvider and serves a file containing a setting. a workspace that uses this FSP. that the setting has no effect until the workspace is reloaded. I will prepare a branch of fsprovider-sample to demonstrate the issue.
Repro steps: project () and VSIX (). an empty profile and install the VSIX into it. no folder or workspace open, run . Explorer find and open that though this specifies a font size of 24 it is displayed in the default font size. and observe that the font size is now correct. !
/assign I will submit a PR to fix this.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
registerActiveInstanceAction({ id: TerminalCommandId.StartVoice, <del> title: localize2('workbench.action.terminal.startVoice', "Start Terminal Voice"), </del> <ins> title: localize2('workbench.action.terminal.startDictation', "Start Dictation in Terminal"), </ins> precondition: ContextKeyExpr.and(HasSpeechProvider, sharedWhenClause.terminalAvailable), f1: true, run: (activeInstance, c, accessor) => {

Discussion:
I find these labels hard to figure out: ! I suggest:
i'll probably remove these altogether since they're not useful
Yes
pointed out that since this is called out in the release notes, I should wait to remove it until there's a replacement IE until we have a universal command
but at least align the labels? "Voice: Start / Stop Dictation in Terminal" <img width="718" alt="image" src=""
is the editor one going to become a generic that can be used anywhere? Chatting with the other day, since we announced the terminal feature as a non-preview we were going to wait until your dictation work works in the terminal as well. Unless we're not on the same page?
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0", "xterm-addon-search": "0.9.0", "xterm-addon-serialize": "0.7.0", </del> <ins> "xterm": "4.20.0-beta.5", "xterm-addon-search": "0.10.0-beta.1", "xterm-addon-serialize": "0.8.0-beta.1", </ins> "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.12.0", "xterm-headless": "4.19.0", </del> <ins> "xterm-addon-webgl": "0.13.0-beta.2", "xterm-headless": "4.20.0-beta.5", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Issue Type: <bPerformance Issue</bTerminals doesn't seem to free all GPU memory when closing them, making alt-tabbing from another application to vscode slower over time, there are other tickets around vscode freezing when alt-tabbing back to it and this seems to be one of the reasons as Windows needs to load/unload 1GB+ of GPU memory when alt-tabbing occurs. One way of reproducing this: 20 integrated terminals the terminals again (now only welcome screen open) Windows task manager -Performance tab something covers vscode completely (i.e. task manager is maximized) the GPU memory usage is 500MB+ lower than if vscode is visible (i.e. task manager is not maximized so it doesn't cover vscode completely, forcing Windows to keep vscode GPU memory active). scales linearly if you open more terminals, i.e. 40 terminals keeps 1GB+ of GPU memory even when they are closed I can reproduce it on the insiders build as well, so Electron 18 doesn't seem to solve this issue. vscode visible (2 GB GPU memory usage at the bottom of the screenshot): ! vscode still open but behind other windows (1 GB GPU memory usage at the bottom of the screenshot): ! VS Code version: Code 1.68.1 (, 2022-06-14T12:48:58.283Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I tried to repro with stable, but I wasn't able to. What are the steps for verification?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Hello, I'm waiting for these to cleanup the terminals properly: But as I am the author of those PRs I don't think additional verification is needed from me once they get merged.
fyi I think I noticed a few bugs about alt-tabbing being slow
Change:
createView: (item, target) => new MergeConflictGutterItemView(item, target, contextMenuService, themeService), }) ); <ins> // title menu const titleMenu = menuService.createMenu(titleMenuId, contextKeyService); const toolBar = new ToolBar(this.htmlElements.toolbar, contextMenuService); const toolBarUpdate = () => { const secondary: IAction[] = []; createAndFillInActionBarActions(titleMenu, { renderShortTitle: true }, secondary); toolBar.setActions([], secondary); }; this._store.add(toolBar); this._store.add(titleMenu); this._store.add(titleMenu.onDidChange(toolBarUpdate)); toolBarUpdate(); </ins> } protected override getEditorContributions(): IEditorContributionDescription[] | undefined {

Discussion:
Theirs / Yours title area is currently quite empty. We should consider to add an action bar for "Compare with Base" action. The title area should also have additional Git information in the future fyi !
I don't see a branch or commit id in your screenshot. Is that configured somehow? <img width="533" alt="CleanShot 2022-06-28 at 10 00 52 src="https://user-"In any case, we could introduce a toolbar somewhat like the editor. Icons are placeholder, but an example could look like: <img width="1032" alt="CleanShot 2022-06-28 at 10 05 06 src="https://user-"
Unsure what was seeing there but with the normal git flow we do show the branch names and commits in question. There is also different issue for the toolbar and since today an icon in front of the commit it
To verify open a merge editor verify that it has menus with yours/theirs
Change:
import { registerAPICommands } from './api/api1'; import { TerminalEnvironmentManager, TerminalShellExecutionManager } from './terminal'; import { createIPCServer, IPCServer } from './ipc/ipcServer'; <del> import { GitEditor } from './gitEditor'; </del> <ins> import { GitEditor, GitEditorDocumentLinkProvider } from './gitEditor'; </ins> import { GitPostCommitCommandsProvider } from './postCommitCommands'; import { GitEditSessionIdentityProvider } from './editSessionIdentityProvider'; import { GitCommitInputBoxCodeActionsProvider, GitCommitInputBoxDiagnosticsManager } from './diagnostics';

Discussion:
Testing I'd love it if these were clickable and brought me to the file it's talking about. ! Should be able to use a link provider, right?
Change:
steps, icon: { type: 'image', <del> path: extension.icon ? FileAccess.asBrowserUri(joinPath(extension.extensionLocation, extension.icon)).toString(true) </del> <ins> path: iconStr ? FileAccess.asBrowserUri(joinPath(extension.extensionLocation, iconStr)).toString(true) </ins> : DefaultIconPath }, when: ContextKeyExpr.deserialize(override ?? walkthrough.when) ?? ContextKeyExpr.true(),

Discussion:
Is there a way to use a codicon instead of an extension PNG? It feels out of place amongst built-in walkthroughs that can use a codicon. <img width="539" alt="CleanShot 2022-10-07 at 14 27 23 src="https://user-"cc since we chatted about this before
Conversation over at
Change:
<span id="ext-loading" hidden></span> <span class="ext-parens" hidden>(</span><a href="#" class="showInfo" id="extension-id">${escape(localize('show', "show"))}</a><span class="ext-parens" hidden>)</span> </label> <del> <pre class="block-info" id="extension-data" placeholder="${escape(localize('extensionData', "Extension does not have additional data to include."))}"> </del> <ins> <pre class="block-info" id="extension-data" placeholder="${escape(localize('extensionData', "Extension does not have additional data to include."))}" style="white-space: pre-wrap;"> </ins> <!-- To be dynamically filled --> </pre> </div>

Discussion:
Testing It seems weird to pass in string when you could just pass in a Uri. Better yet, consider
I think when I was testing, URI wasn't serializable so it wouldn't be passed thru the command properly - will double check this soon though
you may need to turn it into a and then that on the other end. It's possible. We do it with other processes.
Change:
"install-service-local": "yarn link vscode-css-languageservice && yarn link vscode-html-languageservice", "install-server-next": "yarn add vscode-languageserver@next", "install-server-local": "yarn link vscode-languageserver", <del> "test": "npm run compile && node ./test/index.js" </del> <ins> "test": "yarn compile && node ./test/index.js" </ins> } }

Discussion:
Issue Type: <bBug</bClone VS Code repo Follow the instructions for linking vscode-html-language-service will fail, as the project/extension has since moved to yarn. works fine. VS Code version: Code 1.62.0 (, 2021-11-03T15:23:01.379Z) OS version: Windows_NT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 4.19.128-microsoft-standard <!-- generated by issue reporter --
Change:
target.classList.add('merge-accept-gutter-marker'); <del> const checkBox = new Toggle({ isChecked: false, title: localize('acceptMerge', "Accept Merge"), icon: Codicon.check }); </del> <ins> const checkBox = new Toggle({ isChecked: false, title: localize('accept', "Accept"), icon: Codicon.check }); </ins> this._register( dom.addDisposableListener(checkBox.domNode, dom.EventType.MOUSE_DOWN, (e) => { if (e.button === 2) {

Discussion:
commands in the merge editor checkbox context menu need to be disabled when they are not applicable. "Take Input1" should be called "Accept Theirs" "Take Input2" should be called "Accept Yours" "Take Both Sides" should be called "Accept Both" Palette actions should also not talk about Input1 and Input2 Also I am not sure if "Yours" and "Theirs" is better than "Current" and "Incoming" what we previously used This way we are aligning with the previous wording our users are already familiar with ! ! fyi
Now it aligns with whatever the title says. The caller of the merge editor can set the title (Theirs/Yours for git) !
Nice. Does git provide yours/theirs or is that us setting that? I thought we used Current/Incoming in our codelens actions.
The git extension, yes. The opener of the merge editor can set it.
Change:
const isTempMessage = typeof ops.resetAfter === 'number'; if (isTempMessage && !this._elements.statusLabel.dataset['state']) { const statusLabel = this._elements.statusLabel.innerText; <ins> const title = this._elements.statusLabel.dataset['title']; </ins> const classes = Array.from(this._elements.statusLabel.classList.values()); setTimeout(() => { <del> this.updateStatus(statusLabel, { classes, keepMessage: true }); </del> <ins> this.updateStatus(statusLabel, { classes, keepMessage: true, title }); </ins> }, ops.resetAfter); } const renderedMessage = renderLabelWithIcons(message);

Discussion:
Testing The action shows the submenu for a fraction of a second before disappearing again when clicked. The submenu correctly shows in panel chat. !
We shouldn't have this drop down menu in inline chat
This is the problem:
caused by
Moving to April for more cleanup
Change:
} get command(): Command | undefined { <del> if (!this.state.hasRemotes) { </del> <ins> if (!this.state.isEnabled || !this.state.hasRemotes) { </ins> return undefined; }

Discussion:
There doesn't appear to be an option to hide the git sync icon that appears in the status bar. It's not really a big deal but it would be nice to hide the git sync icon. Personally, coming from Vim I prefer working with the VCS outside of the editor, yet I would still like to see the current branch that is being worked on. This is why I'd like to hide just the sync button and not hide both git status bar items or disable the git extension entirely.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.561 --<!-- potentialduplicatescomment --
I believe this is resolved via
No, hard to revert that change.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Change:
@IStorageService storageService: IStorageService, @IConfigurationService private readonly configurationService: IConfigurationService, @IEditorService private readonly editorService: IEditorService, <ins> @IDialogService private readonly dialogService: IDialogService, </ins> @IEditorGroupsService private readonly editorGroupService: IEditorGroupsService, @IInstantiationService private readonly instantiationService: IInstantiationService, @IQuickInputService private readonly quickInputService: IQuickInputService,

Discussion:
Testing new untitled file and add some text. Editor: Open File The original untitled file is left open and changes in the Hex Editor are not reflected in that original file. !
This will be fixed by
Change:
titlebarPart.updateProperties(this.properties); } <del> if (this.variables.length) { titlebarPart.registerVariables(this.variables); </del> <ins> if (this.variables.size) { titlebarPart.registerVariables(Array.from(this.variables.values())); </ins> } Event.once(titlebarPart.onWillDispose)(() => disposables.dispose());

Discussion:
Currently, allows several variables. It would be awesome for extensibility, if would be supported, with being an arbitrary context variable. Then extensions could contribute to the window title (candidates would be or ). I'd be up to create a PR! Related:
Sounds interesting, feel free to give it a try. The variables are substituted from here:
anyone assign me pls
Verification steps: an extension, create a contxt key and register a title variable to in settings and add the newly created title variable (for example ) sure the window title correctly renders the value of the variable in the command center / window title area