jiebi/CodeConvo huggingface dataset:
Change:
// Resolve unique machine ID this.logService.trace('Resolving machine identifier...'); <del> const machineId = await resolveMachineId(this.stateService); </del> <ins> const machineId = await resolveMachineId(this.stateService, this.logService); </ins> this.logService.trace(`Resolved machine identifier: ${machineId}`); // Shared process

Discussion:
When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to
if you support the idea I can provide a PR
that all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.
Change:
} layout(): void { <del> this._onDidLayout.fire(getClientArea(this.window.document.body)); </del> <ins> this._onDidLayout.fire(getClientArea(this.window.document.body, this.container)); </ins> } override dispose(): void {

Discussion:
In web opening an aux window results in an exception.
Works fine for me now - only thing is that new copied windows don't have codicons. ! Also, was testing behavior vs. what we have on desktop in insiders, and noticed that on web we cannot copy a copied window, but not sure if this is intended or if it's even needed in real life scenarios. !
Yeah you have to disable popup blockers in web. I can see if we get the icon to work.
Change:
} else if (optionKind === CodeActionMenu.documentationID) { documentationGroup.push(item); } else { <ins> // Pushes all the other actions to the "Other" group </ins> otherGroup.push(item); }

Discussion:
Type: <bBug</bWhen I click the light bulb instead of getting a menu I see a thin, dark gray, horizontal bar. I have tried restarting the application. VS Code version: Code - Insiders 1.71.0-insider (, 2022-08-12T05:17:00.323Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ code-gnu-global0.2.2 vscode-markdownlint0.47.0 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 dotnet-test-explorer0.7.7 vscode-guid1.4.20 vscode-azurefunctions1.7.4 vscode-azureresourcegroups0.5.5 csharp1.25.0 python2022.12.0 vscode-pylance2022.8.20 jupyter2022.7. remote-wsl0.66.3 azure-account0.11.1 cmake-tools1.11.26 cpptools1.11.5 powershell2022.7.2 test-adapter-converter0.1.6 rust0.7.8 code-spell-checker2.5.4 cmake0.0.17 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
! Here is an image of what I am seeing.
Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.
Related to: This is most likely because of an extension which uses non-VS Code specific code actions. PR for this is out rn!
Confirming fixed on: Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-18T05:15:52.904Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes Thank you!

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Describe the bug The refactor options like "Wrap with...", "Remove this widget", etc. do not show up in the new code action menu. To Reproduce Steps to reproduce the behavior: editor.experimental.useCustomCodeActionMenu the refactor menu somewhere Expected behavior The refactor options should appear in the new menu. From
For me too, I'll have to migrate to normal vscode... !
Thanks! :)
Change:
import { IExtensionsProfileScannerService, IScannedProfileExtension } from 'vs/platform/extensionManagement/common/extensionsProfileScannerService'; import { IUserDataProfilesService } from 'vs/platform/userDataProfile/common/userDataProfile'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; <del> import { ILocalizedString } from 'vs/platform/action/common/action'; </del> <ins> import { localizeManifest } from 'vs/platform/extensionManagement/common/extensionNls'; </ins> export type IScannedExtensionManifest = IRelaxedExtensionManifest & { __metadata?: Metadata };

Discussion:
Testing in Firefox with de-ch (Swiss German) set. Open command palette and search for Remote Repositories commands :bug: The first command has a partly English, partly de-ch line under it ( and in English, seems to be de-ch translated) !
Hmm yeah it should look like this (Desktop screenshot) with the English strings next to the German strings. I think this is a bug in how I'm applying the translations... !
Just found out about these functions on the desktop side: Which seems to go through the manifest and turn some s into s. I followed up with to understand how this works.
This code was originally written by so I would ask him to know how this works.
Not quite, it was originally written by , but I'm happy to try and help. My understanding is that the code is taking a JSON object that looks like this: Together with another JSON object that looks like this: And produces a JSON object that looks like this by substituting all string values of the shape with their corresponding value:
I still see this on firefox: ! The first option's english translation still looks wrong? (tested on )
The first one is still wrong because of so we'll track that there. However, the rest now have the English string underneath which they use to not have, which means this is fixed and verified
Change:
"storage.type.function.arrow", "keyword.operator.bitwise.shift", "meta.brace.angle", <del> "punctuation.definition.tag" </del> <ins> "punctuation.definition.tag", "keyword.operator.assignment.compound.bitwise.ts" </ins> ], "tokenTypes": { "meta.template.expression": "other",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.1 OS Version: Darwin x64 21.3.0 Steps to Reproduce: Code VSCode <img width="81" alt="Screen Shot 2022-09-04 at 4 35 00 AM" src="https://user-"GitHub color , VSCode color
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
This seems to be working correctly per you may want to see whats the issue with vscode
I think this may be caused by bracket matching
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I still see this: !
Change:
private delayedFilterUpdate: Delayer<void>; private container!: HTMLElement; <ins> private filterBadge: HTMLElement | null = null; </ins> private filterInputBox!: HistoryInputBox; constructor(

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
'<meta http-equiv="Content-type" content="text/html;charset=UTF-8">', `<link rel="stylesheet" type="text/css" href="${this.getMediaPath('markdown.css')}" >`, `<link rel="stylesheet" type="text/css" href="${this.getMediaPath('tomorrow.css')}" >`, <ins> this.getSettingsOverrideStyles(), </ins> this.computeCustomStyleSheetIncludes(uri), `<base href="${document.uri.toString(true)}">`, '</head>',

Discussion:
VSCode Version: 0.10.11 OS Version: Windows 7 64bit ! !
I think this should be a separate setting because a font that works for code might not work for reading text.
Correct me if I'm wrong, but isn't this already covered by the markdown styles setting? Result: ! Do we really need a setting to inject a default font?
good point, however enabling this setting for markdown () disables any other style being used for markdown preview. fyi this is a workaround for the problem, you could actually create a CSS file that contains the font style.
Well if we support overriding the default styles piecemeal like suggested wouldn't we end up with settings for many things? Here's a list I can think of off the top of my head: font-family font-size line-spacing background-color ... etc This non-exhaustive list would just start cluttering the configuration, perhaps the default stylesheet should be exposed so minimal tweaking can occur? Perhaps this could be solved with a command / extension to dump the default stylesheet into and add it to the styles? Then anyone can make their minimal tweaks without losing all the default styling?
And I think if we could support this for the command? That means we can add setting for the font family of previewed html?
Change:
public setTooltip(tooltip: string): void { this.tooltip = tooltip; <del> if (!this.hover) { this.hover = this._register(setupCustomHover(getDefaultHoverDelegate('element'), this.input, tooltip)); } else { this.hover.update(tooltip); } </del> <ins> this.input.title = tooltip; </ins> } public setAriaLabel(label: string): void {

Discussion:
todays insiders - run F1 or cmd+shift+o a hover shows and doesn't go away
Change:
class ManagedCodeActionSet extends Disposable implements CodeActionSet { private static codeActionsPreferredComparator(a: languages.CodeAction, b: languages.CodeAction): number { <del> if (a.isAI && !b.isAI) { return 1; } else if (!a.isAI && b.isAI) { return -1; } else if (a.isPreferred && !b.isPreferred) { </del> <ins> if (a.isPreferred && !b.isPreferred) { </ins> return -1; } else if (!a.isPreferred && b.isPreferred) { return 1;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: MacOS A case where specific lint/styling quick fixes are still below. Could be something to do with warnings vs actual fixes. Not sure if this is intentional or not, but in cases where it is wrapped by quick fixes above and below, it does seem a little weird. Example: ! Warning for missing semicolon according to linter, activate quickfix: <img width="789" alt="Screenshot 2023-10-10 at 2 26 38 PM" src=""Other warnings with direct fixes is okay: <img width="772" alt="Screenshot 2023-10-10 at 2 29 56 PM" src=""
related to
Hi the reason this is the case is likely because of this part of the code: The code actions you mentioned that appear below the Copilot actions have an empty field, hence they are placed below the copilot ones. You can see this in the image below where the Copilot actions have associated diagnostics, the eslint one does not. <img width="691" alt="Screenshot 2023-10-11 at 09 19 55" src=""<img width="673" alt="Screenshot 2023-10-11 at 09 20 59" src=""I am wondering if we want the Copilot diagnostics to appear at the very bottom of this list? Thoughts
I suggest we have the ai code actions appear always at the end. So, first criteria: isAI, second criteria whether it has diagnostics attached. Ok for you?
Change:
import { TerminalTabbedView } from 'vs/workbench/contrib/terminal/browser/terminalTabbedView'; import { DropdownMenuActionViewItem } from 'vs/base/browser/ui/dropdown/dropdownActionViewItem'; import { Codicon } from 'vs/base/common/codicons'; <del> import { MenuEntryActionViewItem } from 'vs/platform/actions/browser/menuEntryActionViewItem'; </del> import { ICommandService } from 'vs/platform/commands/common/commands'; <ins> import { IContextMenuProvider } from 'vs/base/browser/contextmenu'; </ins> export class TerminalViewPane extends ViewPane { private _actions: IAction[] | undefined;

Discussion:
For reuse by other code areas
Also polish styling including a hover over the joint buttons
Mockup: !
Fixed in
Change:
const anchor = delegate.getAnchor(); let x: number, y: number; <ins> let zoom = webFrame.getZoomFactor(); </ins> if (dom.isHTMLElement(anchor)) { let elementPosition = dom.getDomNodePagePosition(anchor); x = elementPosition.left; y = elementPosition.top + elementPosition.height; <ins> // Shift macOS menus by a few pixels below elements // to account for extra padding on top of native menu // https://github.com/microsoft/vscode/issues/84231 if (isMacintosh) { y += 4 / zoom; } </ins> } else { const pos: { x: number; y: number; } = anchor; x = pos.x + 1; /* prevent first item from being selected automatically under mouse */ y = pos.y; } <del> let zoom = webFrame.getZoomFactor(); </del> x *= zoom; y *= zoom;

Discussion:
pls see the screenshot below, suggest to shift it down so that it doesn't overlap with the filter icon. !
This is shown correctly left to the icon. Menu is rendered according to the given anchor (action element).
typically dropdowns are using an icon that doesn't really extend to the bottom of the anchor element. (usually ...) on macOS, the top position of the menu aligns with the top of the first element, not the top of the full container, giving this alignment. see windows native ! see windows custom ! we could either shift all dropdowns on macOS a few pixels by adding some extra dimension to the anchor, or we could adjust all context menus to account for the top padding of macOS menus. /cc
:+1:
Change:
const allKernels = kernelService.getMatchingKernel({ uri: notebookUri, viewType: 'interactive' }).all; const preferredKernel = allKernels.find(kernel => kernel.id === id); if (preferredKernel) { <del> kernelService.selectKernelForNotebook(preferredKernel, { uri: notebookUri, viewType: 'interactive' }); </del> <ins> kernelService.preselectKernelForNotebook(preferredKernel, { uri: notebookUri, viewType: 'interactive' }); </ins> } }

Discussion:
Error from telemetry. I ran into this as well sometimes when opening a second IW.
Here are some of my findings: We don't have smoke tests for IW Some how the stable version of Jupyter is in the smoke tests Stable version is some how (for some reason) launching IW, hence we see errors Could be because we're testing in stable vs code and requires insiders.
Note: These are messages on the CI server (in our tests). Seems to be in smoke tests.
I believe we get these on CI too: Here's an example from running on main:
I believe this is an issue in core. We might be changing the selected notebook to nothing and it doesn't handle it.
is used only when an issue isn't yet assigned to its rightful owner.
this repros every time an interactive window with a specific name is created for the first time - we haven't created the document for that IW yet. But then the same $acceptNotebookAssociation is fired again after creating that document anyway
Change:
} focusFirst(): void { <del> if (!this.isVisible || !this.list) { return; // hidden </del> <ins> if (!this.list) { return; // not created yet </ins> } this.list.focusFirst();

Discussion:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated
Change:
process.env['VSCODE_CLI'] = '1'; // Load CLI through AMD loader <del> require('./bootstrap-amd').load('vs/code/node/cli/main'); </del> <ins> require('./bootstrap-amd').load('vs/code/node/cli'); </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest Insiders. OS Version: Mac Steps to Reproduce: Run the VS Code-Jupyter tests on CI and it fails. Here are the logs where we use the VS Code test cli to download VS Code and install the Python extension Basically it looks like we cannot install any extension into VS Code I have tried this locally as well and the same code falls over Here is the code used to isntall the extension here are the logs
If i try this manually in the terminal this fails Here is the same CLI with the stable version of VS Code
Thanks, I was not aware that upstream modules depend on the path to our CLI. I will revert that part of the move.
Change:
private registerNewWindowAction(profile: IUserDataProfile): IDisposable { const disposables = new DisposableStore(); <del> const id = `workbench.action.openProfile.${profile.name.toLowerCase().replace('/s+/', '_')}`; </del> <ins> const id = `workbench.action.openProfile.${profile.name.replace('/s+/', '_')}`; </ins> disposables.add(registerAction2(class NewWindowAction extends Action2 {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.92.1 Commit: OS Version: Darwin x64 23.5.0 Steps to Reproduce: Missing profile manager buttons both on and , with the snapshots, missing , and etc. <img width="872" alt="2024-08-13 11 12 22" src=""<img width="872" alt="2024-08-13 11 12 37" src=""The number of optional profiles has decreased. However, when I try to 'Create with profile', I find that there are still plenty of other profiles available. <img width="685" alt="2024-08-13 11 13 31" src=""
I found some message in DevTools Maybe the profile and profile have same id, ,it create from different computer, after sync setting, make workbench manager broken. And the exception not be catched. How could i fix this? The button is missing, and the also not have it.
I have the same issue, but for me the console complains about the profile I have: I have two profiles: one with name and another with name . Feels like having profiles with the same name, but different casing can cause this issue. !
Managed to get back the buttons by deleting the whole folder.
Delete the whole path is not a good idea for me. First of all, I have too many profiles, and it's too much trouble to reconfigure them all. Besides, I've tried deleting these two duplicate environments, but they get synced back by the sync function.
As a workaround, you can use new Profiles UI by enabling the setting
Change:
export interface ITerminalPanel { closeTerminalById(terminalId: number): TPromise<void>; <ins> focus(): void; </ins> sendTextToActiveTerminal(text: string, addNewLine: boolean): void; }

Discussion:
VSCode Version: 1.5.0 OS Version: OS X 10.11.6 Steps to Reproduce: this snippet to use Then the example Focus is on the newly created terminal and not preserved.
Bug for
Change:
} function getEnumOptionsFromSchema(schema: IJSONSchema): IObjectEnumOption[] { <ins> if (schema.anyOf) { return arrays.flatten(schema.anyOf.map(getEnumOptionsFromSchema)); } </ins> const enumDescriptions = schema.enumDescriptions ?? []; return (schema.enum ?? []).map((value, idx) => {

Discussion:
Testing settings gui and search for workbench.externalUriOpeners "Edit in json" ! Not sure where these values are coming from, but was only able to figure out the formatting of the setting by writing something random and then hovering over it
I believe these are the cross-file word based suggestions. Let me see if I can add a snippet or something to improve this
a visual editor for this setting. I don't think there's a way to fix the json side of things here (although there is a default snippet when you first fill in this setting)
For verification, make sure you can use the settings UI to edit