jiebi/CodeConvo huggingface dataset:
Change:
import { IWorkbenchConstructionOptions, IWorkbench, ITunnel } from 'vs/workbench/browser/web.api'; import { BrowserStorageService } from 'vs/workbench/services/storage/browser/storageService'; import { IStorageService } from 'vs/platform/storage/common/storage'; <del> import { BufferLogger } from 'vs/platform/log/common/bufferLog'; import { FileLoggerService } from 'vs/platform/log/common/fileLog'; </del> import { toLocalISOString } from 'vs/base/common/date'; import { isWorkspaceToOpen, isFolderToOpen } from 'vs/platform/window/common/window'; import { getSingleFolderWorkspaceIdentifier, getWorkspaceIdentifier } from 'vs/workbench/services/workspaces/browser/workspaces';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the "Developer: Set Log Level..." command and set it to "Trace" there's no "Telemetry" channel there, only Extension Telemetry: !
Do you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.
Where do you register Telemetry logger in codespaces, is it in server or on client side?
It's registered client side.
May I know where it is registered in sources?
Can you please check if this code is being executed in the codespace?
It seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.
Can you please provide me steps to enable this locally from sources?
Sent instructions offline
Still not seeing the telemetry output channel in Codespaces (on desktop if it matters)
Actually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.
Change:
}); test('filters to tags', () => { <del> t.setText('@hello:world'); </del> <ins> t.setText('@hello:world !@foo:bar'); </ins> assert.deepStrictEqual(t.globList, []); <del> assert.deepStrictEqual(t.onlyTags, new Set(['hello0world'])); </del> <ins> assert.deepStrictEqual(t.includeTags, new Set(['hello0world'])); assert.deepStrictEqual(t.excludeTags, new Set(['foo0bar'])); </ins> assertFilteringFor(termFiltersOff); }); test('filters to mixed terms and tags', () => { <del> t.setText('@hello:world foo, !bar @doc'); </del> <ins> t.setText('@hello:world foo, !bar @doc !@foo:bar'); </ins> assert.deepStrictEqual(t.globList, [{ text: 'foo', include: true }, { text: 'bar', include: false }]); <del> assert.deepStrictEqual(t.onlyTags, new Set(['hello0world'])); </del> <ins> assert.deepStrictEqual(t.includeTags, new Set(['hello0world'])); assert.deepStrictEqual(t.excludeTags, new Set(['foo0bar'])); </ins> assertFilteringFor({ ...termFiltersOff, [TestFilterTerm.CurrentDoc]: true,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Splitting this out from In the Test UI you can filter by text or exclude text using and filter by a . It would be nice if we could also negate tags in the filter like to exclude a specific tag. <!-- Describe the feature you'd like. --
Starting point, this is where tag filtering happens:
Change:
readonly parentPath: string; readonly progress: Progress<{ increment: number }>; readonly recursive?: boolean; <ins> readonly ref?: string; </ins> } export class Git {

Discussion:
Testing According to , we can have git checkout a specific branch as part of the cloning command. That way we can avoid slowness as well as a double progress indicator.
Verification From your browser, enter . This should clone the repo and checkout the branch , and there should only be one progress notification for the clone progress, there shouldn't be a second progress notification for the checkout
I just get messages like Version: 1.73.0-insider (user setup) Commit: Date: 2022-10-26T09:31:30.519Z Edit: It's missing url=. Will try again.
Thanks
Change:
this.addDisposable(this._configurationService.onDidChangeConfiguration(e => { if (e.affectsConfiguration('terminal.integrated')) { this.updateConfig(); <ins> // HACK: Trigger another async layout to ensure xterm's CharMeasure is ready to use, // this hack can be removed when https://github.com/xtermjs/xterm.js/issues/702 is // supported. this.setVisible(this._isVisible); </ins> } if (e.affectsConfiguration('editor.accessibilitySupport')) { this.updateAccessibilitySupport();

Discussion:
Issue Type: <bBug</bI use oh-my-zsh and set integrated terminal /bin/zsh cmd+, to show settings tab terminal(ctrl+shift+`) settings terminal integrated: Font size option. say we have default value 12. . now value is 1 and terminal gets so small 1 so now value is 11. and terminal is gone. expected to see current terminal cursor. i type lots of enters or ctrl+c, then I can see my terminal again. i saw my terminal again, it looks like change font size 11 -1 -12 doesn't make terminal to disappear. VS Code version: Code 1.27.1 (, 2018-09-06T09:14:32.385Z) OS version: Darwin x64 17.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ gitlens8.5.6 code-runner0.9.4 beautify1.4.2 Go0.6.89 vetur0.12.6 vscode-docker0.2.0 java0.30.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.481 --- <!-- score: 0.459 --<!-- potentialduplicatescomment --
also vertical scroll of terminal get somewhat screwed even after I see my terminal again by typing enter or ctrl+c
this seems to be related to the usage of from xterm: a similar problem with an explanation of a solution can be found here: In short, after the fontSize changes, the terminal renders before the xterm field is updated, so the render uses previous values (corresponding to the previous font size values) Related: ,
can some settings only commit the change on blur?
If is an invalid font size for that setting, can the terminal ignore it or set a minimum in the setting schema?
after thinking about this some more I think this is totally on my end as something weird happens when changing the setting frequently. There is already a minimum value which is why VS Code doesn't crash
Change:
"vscode-oniguruma": "1.7.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.73", "xterm-addon-canvas": "0.5.0-beta.34", </del> <ins> "xterm": "5.4.0-beta.17", "xterm-addon-canvas": "0.6.0-beta.16", </ins> "xterm-addon-image": "0.6.0-beta.21", <del> "xterm-addon-search": "0.13.0-beta.27", "xterm-addon-serialize": "0.11.0-beta.27", "xterm-addon-unicode11": "0.6.0-beta.19", "xterm-addon-webgl": "0.16.0-beta.37", "xterm-headless": "5.3.0-beta.73", </del> <ins> "xterm-addon-search": "0.14.0-beta.15", "xterm-addon-serialize": "0.12.0-beta.15", "xterm-addon-unicode11": "0.7.0-beta.15", "xterm-addon-webgl": "0.17.0-beta.15", "xterm-headless": "5.4.0-beta.17", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" }

Discussion:
Upstream: To verify: linux/macOS/wsl various values of (eg. 1, 4.5, 10) first with no selection and second with a selection. You may need to change your theme to see the differences

Upstream: Repro: Linux/macOS/WSL , it should not show invisible in the output

noticed by
Verify that when you have a screen reader on, you hear the output of a command upon pressing enter
Reproduces in the demo. Does not reproduce in stable VS Code
upstream issue:
With a screen reader enabled, run a command that yields short output, such as . Verify that the screen reader reads the output.
Change:
this.notebookEditor.textModel!.transientOptions.transientOutputs ? [] : this.cell.type === 'insert' <del> ? this.cell.modified!.outputs || [] : this.cell.original!.outputs || []); </del> <ins> ? this.cell.modified?.outputs || [] : this.cell.original?.outputs || []); </ins> const outputModel = this.modelService.createModel(originaloutputSource, mode, undefined, true); this._outputEditorDisposeStore.add(outputModel); this._outputEditor.setModel(outputModel);

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --If outputs are cleared from a jupyter notebook, attempting to view a diff in source control view displays the error in the subject. Search for related issues brings up a different issue related to filesystem sync. VS Code version: 1.80.1 Jupyter Extension version (available under the Extensions sidebar): v2023.6. Python Extension version (available under the Extensions sidebar): v2023.12.0 OS (Windows Linux distro) and version: Windows 11 Python and/or Anaconda version: 3.9.16 Type of virtual environment used (N/A ...): conda Jupyter server running: Local Display the diff, don't display an error, even if outputs are undefined in a version of the diff. Error is displayed and the diff can't be viewed. Open a notebook in jupyter server (not VS Code) Click Cell -All Output -Clear Save the notebook Go to VS Code -Source Control View -click on the notebook. <details<summaryOutput for <codeJupyter</codein the <codeOutput</codepanel (<codeView</code→<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codeJupyter</code) </summary<p</p</details
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
the editor opens successfully, though it does not show the change unless you click the switch output rendering button !
Tracked here
Change:
constructor() { super( <del> 'workbench.action.copyEditorGroupToNewWindow', </del> <ins> COPY_EDITOR_GROUP_INTO_NEW_WINDOW_COMMAND_ID, </ins> { value: localize('copyEditorGroupToNewWindow', "Copy Editor Group into New Window"), mnemonicTitle: localize({ key: 'miCopyEditorGroupToNewWindow', comment: ['&& denotes a mnemonic'] }, "&&Copy Editor Group into New Window"),

Discussion:
Testing I am wondering if there should be a context menu action for this? !
Yeah, I actually decided to do a bit more: Editor Tab Container Context Menu: <img width="447" alt="image" src=""Empty Editor Group Context Menu: <img width="458" alt="image" src="" to open an empty aux window
Change:
return getWindow(el).getComputedStyle(el, null); } <del> export function getClientArea(element: HTMLElement): Dimension { const elDocument = element.ownerDocument; const elWindow = elDocument.defaultView?.window; </del> <ins> export function getClientArea(element: HTMLElement, fallback?: HTMLElement): Dimension { const elWindow = getWindow(element); const elDocument = elWindow.document; </ins> // Try with DOM clientWidth / clientHeight if (element !== elDocument.body) {

Discussion:
In web opening an aux window results in an exception.
Works fine for me now - only thing is that new copied windows don't have codicons. ! Also, was testing behavior vs. what we have on desktop in insiders, and noticed that on web we cannot copy a copied window, but not sure if this is intended or if it's even needed in real life scenarios. !
Yeah you have to disable popup blockers in web. I can see if we get the icon to work.
Change:
for (let i = 0; i < cells.length; i++) { const cell = cells[i]; <del> if (cell.cellKind === CellKind.Code) { </del> <ins> if (cell.cellKind !== CellKind.Markup || cell.language !== 'markdown') { </ins> continue; } <del> const content = cell.getText(); const matches = content.match(/^[ t]*(#+) /gm); let min = 7; if (matches && matches.length) { for (let j = 0; j < matches.length; j++) { min = Math.min(min, matches[j].length); } } if (min < 7) { </del> <ins> const minDepth = Math.min(7, ...Array.from(getMarkdownHeadersInCell(cell.getText()), header => header.depth)); if (minDepth < 7) { </ins> // header 1 to 6 <del> stack.push({ index: i, level: min, endIndex: 0 }); </del> <ins> stack.push({ index: i, level: minDepth, endIndex: 0 }); </ins> } } <del> // calcualte folding ranges </del> <ins> // calculate folding ranges </ins> const rawFoldingRanges: IFoldingRangeData[] = stack.map((entry, startIndex) => { let end: number | undefined = undefined; for (let i = startIndex + 1; i < stack.length; ++i) {

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) I expected that folding cells per a markdown header level would collapse all of the markdown and code cells under that header, per the VS Code Outline view of the notebook. In practice though, if there is a markdown cell with a python code block, then the comments in that python code block are considered the next top-level markdown section which interrupts the code folding. a new file and set the interpreter markdown cell with content: markdown cell: code cell: markdown cell: python print('hello world') the cell that cells 2 and 3 are collapsed and hidden, but cell 4 is not Add additional 's to the embedded python comment so that its not at the same level of the makrdown section it is under; e.g., python print('hello world') 70.0 v2022.7. Python 3.8.13 v2022.12.0 conda 4.13.0 Local
still seeing this issue- lmk if my setup is wrong. thanks! <img width="1322" alt="Screenshot 2023-01-25 at 1 11 16 PM" src="https://user-"<img width="1314" alt="Screenshot 2023-01-25 at 1 11 11 PM" src="https://user-"
Can you try finishing editing the cells to put them into render mode: ! I don't think we update the folding until the cell is no longer being edited
was verifying another issue and this works now!
Change:
const isRunning = this.extensionService.extensions.some(e => areSameExtensions({ id: e.identifier.value, uuid: e.uuid }, this.extension!.identifier)); if (isEnabled && isRunning) { <ins> if (this.extension.enablementState === EnablementState.EnabledWorkspace) { this.updateStatus({ message: new MarkdownString(localize('workspace enabled', "This extension is enabled for this workspace by the user.")) }, true); return; } </ins> if (this.extensionManagementServerService.localExtensionManagementServer && this.extensionManagementServerService.remoteExtensionManagementServer) { if (this.extension.server === this.extensionManagementServerService.remoteExtensionManagementServer) { this.updateStatus({ message: new MarkdownString(localize('extension enabled on remote', "Extension is enabled on '{0}'", this.extension.server.label)) }, true);

Discussion:
Type: <bBug</bfolder under WSL. to extension and for some extension chose Enable Enable (Workspace). ! Problem: extension is displayed as enabled in WSL globally ! It must be displayed as enabled in this workspace, see for example how it looks when not using WSL ! VS Code version: Code 1.78.2 (, 2023-05-10T14:39:26.248Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2+ <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ Bookmarks13.3.1 jupyter-keymap1.1.0 remote-containers0.292.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.78.8 remote-explorer0.4.0 vscode-gn1.1.0 ng-template16.0.0 asciidoctor-vscode2.9.8 vscode-fish1.0.33 bitbake1.1.2 cmake-tools1.14.31 cpptools1.15.4 cpptools-extension-pack1.3.0 makefile-tools0.7.0 vscode-xml0.25.0 shader1.1.5 cmake0.0.17 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Seems like a UI bug
Change:
this.setFocus([lastPageIndex], browserEvent); } } else { <ins> this.setFocus([]); </ins> const previousScrollTop = this.view.getScrollTop(); this.view.setScrollTop(previousScrollTop + this.view.renderHeight - this.view.elementHeight(lastPageIndex));

Discussion:
Version: 1.44.0-insider (user setup) Commit: Date: 2020-03-31T08:23:56.446Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. Minor issue obviously but it's would probably feel smoother if the top didn't flash whenever you press page down. This indicates to me that rendering is happening between the selection and scroll values are updated as a result of page down firing. Shouldn't they be done at the same time? Holding page down showing the problem: ! Pressing page down showing the problem: !
It's pretty much the same what happens with the Windows file explorer. We can do better, tho! I suggest to clear focus, scroll, set focus iff there is space left to scroll.
Change:
} <ins> this._editorLayoutInProgress = false; </ins> this.layoutNotebookCell(); }); }

Discussion:
a change to the file and save, do not commit the diff view from the SCM view up and down in the notebook diff view :cheese: see cell metadata area skittering on screen (the recording below does not capture how frequently the skittering actually happens) https://user-
Just ran into this again: https://user-
I opened for that, I think we can actually just reopen this one
This issue should be gone now since we fixed the horizontal bar issue.
Change:
// On Windows track all cursor movements after the command start sequence if (this._isWindowsPty) { this._commandMarkers.length = 0; <del> this._onCursorMoveListener = this._terminal.onCursorMove(() => { if (this._commandMarkers.length === 0 || this._commandMarkers[this._commandMarkers.length - 1].line !== this._terminal.buffer.active.cursorY) { const marker = this._terminal.registerMarker(0); if (marker) { this._commandMarkers.push(marker); } } }); </del> // HACK: Fire command started on the following frame on Windows to allow the cursor // position to update as conpty often prints the sequence on a different line to the // actual line the command started on. timeout(0).then(() => { <ins> if (!this._currentCommand.commandExecutedMarker) { this._onCursorMoveListener = this._terminal.onCursorMove(() => { if (this._commandMarkers.length === 0 || this._commandMarkers[this._commandMarkers.length - 1].line !== this._terminal.buffer.active.cursorY) { const marker = this._terminal.registerMarker(0); if (marker) { this._commandMarkers.push(marker); } } }); } </ins> this._currentCommand.commandStartMarker = this._terminal.registerMarker(0); this._onCommandStarted.fire({ marker: this._currentCommand.commandStartMarker } as ITerminalCommand); });

Discussion:
Seeing this in today's build: ! Might be related to the fix
Weird that it looks like it reproduces inconsistently. I wonder if that always happens following one of the "empty commands"
The change I had in mind isn't working as I thought, this is too risky for Feb.
I haven't seen this happen for some time.
I have seen this actually
One problem case, notice B (command start) happens before the new line of the prompt: !
Other problem case: ! Notice that a cursor move event is happening on line 50 which is the line above the prompt: !
Change:
break; case 'stopped': this.didReceiveStoppedEvent = true;		// telemetry: remember that debugger stopped successfully <ins> this.stoppedSinceLastStep = true; </ins> this._onDidStop.fire(<DebugProtocol.StoppedEvent>event); break; case 'continued':

Discussion:
Stepping using the debug adapter that I helped develop has been broken by a VS Code change between 1.78.2 and 1.79.0. I used a to log the messages sent back and forth using the same extension version, but different VS Code versions. I attached the logs below. After diffing the two files, the only difference is that the "scopes" request isn't sent to the adapter after the "next" request reports a stopped event. The end result is that the debugging UI in VS Code is stuck in "running" mode even though the debug adapter is stopped, and the user has no way to advance. See
I think this is related to the fact that you send the "stopped" event before the "next" response. We should be able to support that but as a workaround you could respond to "next" before stopping the debugger.
Thanks for the quick response I will look into that workaround. In what cases is tit required? Any type of step?
I see the issue but it will be too much of a risky change to get into our next stable release. I will try to address it in July but I'd recommend working around it in your extension.
I understand. I implemented the workaround in my extension and initial tests show that it works, so thanks for making me aware of that.
For my own reference, I think it should be ok to do immediately instead of waiting for the response.
Hi what are some verification steps for this issue?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I verified this by hacking mock-debug, but are you able to verify the change in Insiders, or have you moved on to not rely on that behavior anymore?
I've modified my extension to implement your workaround. I can download an old version of the extension to test this if you want.
It's ok, I think I've got it now
Change:
import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { StopWatch } from 'vs/base/common/stopwatch'; import { VSBuffer } from 'vs/base/common/buffer'; <del> import { IExtensionHost, ExtensionHostKind, ActivationKind } from 'vs/workbench/services/extensions/common/extensions'; </del> <ins> import { IExtensionHost, ExtensionHostKind, ActivationKind, extensionHostKindToString } from 'vs/workbench/services/extensions/common/extensions'; </ins> import { ExtensionActivationReason } from 'vs/workbench/api/common/extHostExtensionActivator'; import { CATEGORIES } from 'vs/workbench/common/actions'; import { Barrier, timeout } from 'vs/base/common/async'; import { URI } from 'vs/base/common/uri'; import { ILogService } from 'vs/platform/log/common/log'; <ins> import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; </ins> // Enable to see detailed message communication between window and extension host const LOG_EXTENSION_HOST_COMMUNICATION = false;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Add telemetry at the startup of an extension host to know that the startup was begun. Add telemetry when the extension host is successfully started. Add telemetry when the extension host failed to start. This enables determining the success/failure rate of extension host startup as well as grouping of failure reasons to debug issues in the field.