jiebi/CodeConvo huggingface dataset:
Change:
<svg width="14px" height="14px" viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"> <del> <rect fill="#4668C5" x="0" y="0" width="100" height="100" rx="35" ry="35"/> </del> <ins> <rect fill="#CC6633" x="0" y="0" width="100" height="100" rx="35" ry="35"/> </ins> <text x="50" y="75" font-size="75" text-anchor="middle" style="font-family: Menlo, Monaco, Consolas, &quot;Droid Sans Mono&quot;, &quot;Inconsolata&quot;, &quot;Courier New&quot;, monospace, &quot;Droid Sans Fallback&quot;;" fill="white"> R </text>

Discussion:
Please use different badge colors for modified and renamed files in the git sidebar to provide better visual distinction, which is important if there are lots of changes - especially upon merging. Right now both use blue color and visually hardly distinguishable. I'd suggest orange color for some of them. :) !
Change:
placeholder: nls.localize('commitMessage', "Message (press {0} to commit)", ChangesView.COMMIT_KEYBINDING), validationOptions: { showMessage: true, <del> validation: (): InputBox.IMessage => null </del> <ins> validation: (value): InputBox.IMessage => { if (Strings.trim(value.split('n')[0]).length > 50) { return { content: ChangesView.LONG_COMMIT, type: InputBox.MessageType.WARNING }; } return null; } </ins> }, ariaLabel: nls.localize('commitMessageAriaLabel', "Git: Type commit message and press {0} to commit", ChangesView.COMMIT_KEYBINDING), flexibleHeight: true

Discussion:
I am using VSCode on Ubuntu 14.04 x64 VSCode About: Version 0.10.10 Commit Date 2016-03-07T10:30:20.458Z Shell 0.35.6 Renderer 45.0.2454.85 Node 4.1.1 Steps to Reproduce: a git repo folder a change the "GIT" tab typing a git message I am thinking of a counter starting with 50 (The number of character that'll be used as the short message appearing in git commits), it helps write meaning full messages, without have a word cut and completed in the description part, the behavior is taken as is from GitKraken
My suggestion would be to, instead of always showing a counter, when the first line's length has surpassed 50 characters. I'd gladly take this as a contribution PR! Wanna give it a try?
It seems easy to implement this, can I give it a try?
Absolutely, looking forward to it.
It unfortunately seems as if is no longer working on this.
Please bring it back!
Change:
} case 'clicked-link': { let linkToOpen: URI | string | undefined; if (matchesScheme(data.href, Schemas.command)) { <del> const ret = /command:workbench.action.openLargeOutput?(.*)/.exec(data.href); if (ret && ret.length === 2) { const outputId = ret[1]; const group = this.editorGroupService.activeGroup; if (group) { if (group.activeEditor) { group.pinEditor(group.activeEditor); </del> <ins> // We allow a very limited set of commands const uri = URI.parse(data.href); switch (uri.path) { case 'workbench.action.openLargeOutput': { const outputId = uri.query; const group = this.editorGroupService.activeGroup; if (group) { if (group.activeEditor) { group.pinEditor(group.activeEditor); } </ins> } <del> } this.openerService.open(CellUri.generateCellOutputUri(this.documentUri, outputId)); return; </del> <ins> this.openerService.open(CellUri.generateCellOutputUri(this.documentUri, outputId)); return; } case 'github-issues.authNow': case 'workbench.extensions.search': case 'workbench.action.openSettings': { this.openerService.open(data.href, { fromUserGesture: true, allowCommands: true, fromWorkspace: true }); return; } </ins> } <ins> return; </ins> } <del> if (matchesSomeScheme(data.href, Schemas.http, Schemas.https, Schemas.mailto, Schemas.command, Schemas.vscodeNotebookCell, Schemas.vscodeNotebook)) { </del> <ins> if (matchesSomeScheme(data.href, Schemas.http, Schemas.https, Schemas.mailto, Schemas.vscodeNotebookCell, Schemas.vscodeNotebook)) { </ins> linkToOpen = data.href; } else if (!/^[w-]+:/.test(data.href)) { const fragmentStartIndex = data.href.lastIndexOf('#');

Discussion:
A remote code execution vulnerability exists in VS Code 1.71 and earlier versions for malicious notebooks. These notebooks could use command uris to execute arbitrary commands, including potentially dangerous commands The fix is available starting with VS Code 1.71.1. The mitigates this attack by performing input validation on the URL pointing to the repository to be cloned. Do not open notebooks from untrusted sources. The patch for this can be found at An advisory for this can be found at MSRC details for this can be found at
the docs and advisories say it's fixed in 1.71.1, but it's only fixed in 1.72.1
Change:
"node": ">= 0.10.0 < 0.11.0" }, "scripts": { <ins> "test": "node node_modules/mocha/bin/_mocha", </ins> "postinstall": "npm --prefix extensions/csharp-o/ install extensions/csharp-o/" }, "dependencies": {

Discussion:
Currently seems to not set the extension tests path properly.
There are two issues: the environment attribute 'extensionTestsPath' needs to be passed properly. when running VS Code in the web UI or in a remote setup, the value of the attribute must be a valid path that exists in the filesystem. This is a problem because for historical reasons the path generated by yeoman is which does not exist in the filesystem (because it lacks the file extension ). When running tests locally, the non-existing path is not an issue because mocha will find the tests anyway. The first problem has been fixed in VS Code. The second problem requires a change in "node-debug2": we have to cope with paths that lack a ".js" extension. I've created to address this. Without the second fix a workaround is needed in order to run extension tests in the Web or remote scenarios successfully: just append the ".js" extension to the path.
Verification: open a hello world extension in the web and run its unit tests.
One issue left: the tab where the VS Code instance runs the tests is not closed automatically at the end. See bug .
I hadn't published node2 with the fix. Doing that now, we can reverify this tomorrow.
Verification is trivial: open a hello world extension in the web and run its unit tests.
Verified using and running the tests.
Change:
align-items: center; } <ins> .scm-view .scm-provider > .actions > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item:nth-child(1) { min-width: 20px; } </ins> .scm-view .scm-provider > .actions > .monaco-toolbar > .monaco-action-bar > .actions-container  > .action-item > .action-label, .scm-view .scm-provider > .actions > .monaco-toolbar > .monaco-action-bar > .actions-container  > .action-item > .monaco-dropdown > .dropdown-label > .action-label { display: flex;

Discussion:
Type: <bBug</bThe actions and the more menu for source control is not always visible. I always have to expand the sidebar to access the settings. Previously, the title of the pull request was cut off. Unfortunately, this no longer happens. ! ! ! Old behaviour on VSCode stable with other extensions): ! VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-11T05:46:26.380Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (83)</summaryExtensionVersion ------ better-comments3.0.2 codesnap1.3.4 vscode-m3u1.0.0 TabOut0.2.2 Bookmarks13.4.2 project-manager12.7.0 flutter-snippets3.0.0 toggle-excluded-files2.0.0 clipboard-history1.0.7 melos-code1.1.1 vscode-intelephense-client1.10.2 ccs-flutter-color1.2.2 gitignore0.9.0 dbclient-jdbc1.3.4 vscode-mysql-client26.9.10 vscode-mac-color-picker1.1.0 markdown-table-prettify3.6.0 dart-code3.81. flutter3.80.0 vscode-markdownlint0.53.0 githistory0.6.20 gitlens14.6.1 bloc6.6.5 mason0.1.11 flutter-coverage0.0.4 shell-format7.2.5 build-runner0.8.0 copilot1.148.0 copilot-chat0.12.

vscode-github-actions0.26.2 vscode-pull-request-github0.78.1 todo-tree0.0.226 terraform2.29.1 json-to-dart3.5.8 rest-client0.25.1 pubspec-assist2.3.2 shortcut-menu-bar3.0.4 intellij-idea-keybindings1.5.12 build-runner2.1.1 chatgpt-helper4.1.0 vscode-gutter-preview0.30.0 indent-to-bracket1.2.2 flutter-intl1.19.3 syntax-project-pbxproj0.1.3 flutter-snippets1.0.5 Kotlin1.7.1 rainbow-csv3.11.0 git-graph1.30.0 dart-barrel-file-generator6.2.1 diff-merge0.7.0 vscode-docker1.28.0 vscode-language-pack-de1.85. remote-containers0.331.0 live-server0.4.13 vsliveshare1.0.5900 vsliveshare-pack0.4.0 vscode-flutter-freezed-helper0.1.0 sqltools0.28.1 sqltools-driver-mysql0.6.0 awesome-flutter-snippets4.0.1 vscode-streamdeck4.1.6 vscode-yaml-sort6.5.10 vscode-versionlens1.9.2 material-icon-theme4.33.0 remove-comments1.2.2 postman-for-vscode0.17.0 vscode-yaml1.14.0 vscode-sort-json1.20.0 command-variable1.61.0 flutter-riverpod-snippets1.2.2 vscode-coverage-gutters2.11.1 lcov-lang1.0.1 swift-lang1.7.2 freezed-model-gen1.0.1 better-search0.0.6 errorlens3.16.0 vscode-lldb1.10.0 vscode-wakatime24.4.0 vscode-todo-highlight1.0.5 php-debug1.34.0 vscode-surround1.5.0 markdown-all-in-one3.6.1 material-theme3.16.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
"$schema": "vscode://schemas/color-theme", "name": "Dark (Visual Studio)", "colors": { <ins> "checkbox.border": "#6B6B6B", </ins> "editor.background": "#1E1E1E", "editor.foreground": "#D4D4D4", "editor.inactiveSelectionBackground": "#3A3D41",

Discussion:
All of our ~input controls~ checkboxes in the dark & light theme need to have a 3:1 contrast ratio between its background and adjacent color in the empty state. So either the border (if it has one) or the container's background. cc
I think dropdown doesn't need 3:1 border if it won't be empty. This rule only applies to controls without text or icon inside. If it has text, then the text will be required to have 4.5:1 CCR from another rule (icon will have 3:1). Either of the content inside will satisfy the overall active indicator rule.
Gửi từ điện thoại thông minh Samsung Galaxy của tôi.
Verified with Light+ and Dark+ themes in the Settings editor. The v2 versions of those themes might have an issue, though.
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.19", </del> <ins> "xterm": "5.2.0-beta.20", </ins> "xterm-addon-canvas": "0.4.0-beta.7", "xterm-addon-search": "0.11.0", "xterm-addon-unicode11": "0.5.0",

Discussion:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.

also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"
Change:
import { IProblemsWidget } from 'vs/workbench/contrib/markers/browser/markersView'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { Range } from 'vs/editor/common/core/range'; <ins> import { unsupportedSchemas } from 'vs/platform/markers/common/markerService'; </ins> const $ = DOM.$;

Discussion:
Testing <img width="1617" alt="image" src="https://user-"
I can't get squiggles to show up for the commit input box at all, even after following the steps from the linked TPI. What are some steps to verify this, or maybe someone else can verify?
Thanks Reopening the bug as the fix for this has introduced a regression.
Checked in a better fix for this issue. Should be included in tomorrow's Insiders release (2022-08-26).
closedWith
Verified, but the actions in the hover don't do anything: !
Thanks I have filed to track the issue with the actions.
Change:
'use strict'; <ins> import * as nls from 'vs/nls'; </ins> import { basename, dirname } from 'vs/base/common/paths'; import { ITextModel } from 'vs/editor/common/model'; import { Selection } from 'vs/editor/common/core/selection';

Discussion:
I'm happy to see the new date-based snippet variables in v1.20.0. I would love to see some additional ones since I wanted to use this for generating journal templates. Something like this: CURRENTDAYNAME: Monday, Tuesday, ... CURRENTDAYNAMESHORT: Mon, Tue, ... CURRENTMONTHNAME: January, February, ... CURRENTMONTHNAMESHORT: Jan, Feb, ... Thank you.
A little more tricky because you might want to consider localisation settings...
Change:
} } <del> private onModeChange(editorWidget: ICodeEditor | undefined): void { </del> <ins> private onModeChange(editorWidget: ICodeEditor | undefined, editorInput: IEditorInput | undefined): void { </ins> let info: StateDelta = { mode: undefined }; // We only support text based editors <del> if (editorWidget) { </del> <ins> if (editorWidget && editorInput && toEditorWithModeSupport(editorInput)) { </ins> const textModel = editorWidget.getModel(); if (textModel) { const modeId = textModel.getLanguageIdentifier().language;

Discussion:
Refs: ! vs ! We probably need some generic way (via ?) to have the classes detect the editor that is opened. Currently that one is probably probing for file editor and untitled editor inputs.
What all should be present? Position makes sense, possibly tab size. I'm not sure if encoding or line ending make sense, and mode probably doesn't make sense (one wouldn't change the mode).
Yeah, likely only a subset - those that make sense.
Added the status bar entries, but no clean way to configure which entries show for a given editor. Currently the "Search Result" mode will show and be clickable, but choosing results doesn't actually do anything. (aborts out at ) put up to fix that.
Change:
} private async doCreateProfile(id: string, name: string, options?: IUserDataProfileOptions): Promise<IUserDataProfile> { <ins> if (!isString(name) || !name) { throw new Error('Name of the profile is mandatory and must be of type `string`'); } </ins> let profileCreationPromise = this.profileCreationPromises.get(name); if (!profileCreationPromise) { profileCreationPromise = (async () => {

Discussion:
Testing Try to import this profile file: Restart VS Code. Observe that VS Code does not load anymore.
Change:
* * @param {string[]} modulePaths * @param {(result, configuration: object) => any} resultCallback <del> * @param {{ forceEnableDeveloperKeybindings?: boolean, removeDeveloperKeybindingsAfterLoad?: boolean, canModifyDOM?: (config: object) => void, beforeLoaderConfig?: (config: object, loaderConfig: object) => void, beforeRequire?: () => void }=} options </del> <ins> * @param {{ forceEnableDeveloperKeybindings?: boolean, disallowReloadKeybinding?: boolean, removeDeveloperKeybindingsAfterLoad?: boolean, canModifyDOM?: (config: object) => void, beforeLoaderConfig?: (config: object, loaderConfig: object) => void, beforeRequire?: () => void }=} options </ins> */ exports.load = function (modulePaths, resultCallback, options) {

Discussion:
Issue Type: <bBug</bHitting Ctrl+R refresh Issue Report window content and the filled information are lost after refreshing. VS Code version: Code 1.35.1 (, 2019-06-12T14:27:31.086Z) OS version: Linux x64 4.15.0-54-generic <details<summaryExtensions (15)</summaryExtensionVersion ------ githistory0.4.6 es7-react-js-snippets2.3.0 json-tools1.0.2 prettier-vscode1.9.0 composer-support-client0.19.12 golang-tdd0.0.9 solidity0.0.56 vscode-docker0.7.0 python2019.6. cpptools0.24.0 Go0.11.4 sqltools0.19.6 material-icon-theme3.8.0 sass-indented1.5.1 gitblame2.8.1 </details<!-- generated by issue reporter --
Change:
// Move .zshrc into $ZDOTDIR as the way to activate the script const zdotdir = path.join(os.tmpdir(), `${os.userInfo().username}-vscode-zsh`); envMixin['ZDOTDIR'] = zdotdir; <del> const userZdotdir = env?.ZDOTDIR ?? os.homedir(); </del> <ins> const userZdotdir = env?.ZDOTDIR ?? os.homedir() ?? `~`; </ins> envMixin['USER_ZDOTDIR'] = userZdotdir; const filesToCopy: IShellIntegrationConfigInjection['filesToCopy'] = []; filesToCopy.push({

Discussion:
shell integration enabled a zshell terminal just exits instantly a zsh terminal now works. However, some shell integration markers are still present, and my .zshrc didn't load -- no theme and no aliases are available <img width="359" alt="image" src="https://user-"vs in iterm: <img width="246" alt="image" src="https://user-"
I have seen issues where this is happening, but haven't been able to reproduce yet myself
a recent change which could've caused this is
does your set your on the machine that you're seeing this on? what's your in the external terminal?
is unset when I'm using zshell in iterm
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
This issue closed? This problem still seems to be occurring. Version: 1.72.0-insider (Universal) Commit: zsh 5.9 (x86_64-apple-darwin21.3.0) and I don't set ZDOTDIR variable
This issue still exists https://user-
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
], "default": "hide", "description": "%markdown.previewFrontMatter.dec%" <ins> }, "markdown.preview.fontFamily": { "type": "string", "default": "'Segoe WPC', 'Segoe UI', 'SFUIText-Light', 'HelveticaNeue-Light'", "description": "%markdown.preview.fontFamily.desc%" }, "markdown.preview.fontSize": { "type": "number", "default": 14, "description": "%markdown.preview.fontSize.desc%" }, "markdown.preview.lineHeight": { "type": "number", "default": 1.6, "description": "%markdown.preview.lineHeight.desc%" </ins> } } }

Discussion:
VSCode Version: 0.10.11 OS Version: Windows 7 64bit ! !
I think this should be a separate setting because a font that works for code might not work for reading text.
Correct me if I'm wrong, but isn't this already covered by the markdown styles setting? Result: ! Do we really need a setting to inject a default font?
good point, however enabling this setting for markdown () disables any other style being used for markdown preview. fyi this is a workaround for the problem, you could actually create a CSS file that contains the font style.
Well if we support overriding the default styles piecemeal like suggested wouldn't we end up with settings for many things? Here's a list I can think of off the top of my head: font-family font-size line-spacing background-color ... etc This non-exhaustive list would just start cluttering the configuration, perhaps the default stylesheet should be exposed so minimal tweaking can occur? Perhaps this could be solved with a command / extension to dump the default stylesheet into and add it to the styles? Then anyone can make their minimal tweaks without losing all the default styling?
And I think if we could support this for the command? That means we can add setting for the font family of previewed html?
Change:
"xterm-addon-search": "0.10.0-beta.5", "xterm-addon-serialize": "0.8.0-beta.5", "xterm-addon-unicode11": "0.4.0-beta.5", <del> "xterm-addon-webgl": "0.13.0-beta.35", </del> <ins> "xterm-addon-webgl": "0.13.0-beta.36", </ins> "xterm-headless": "5.0.0-beta.5", "yauzl": "^2.9.2", "yazl": "^2.4.3"

Discussion:
I've been seeing a lot of this since last week. I assume there's another issue for it but I don't see it !
! Is this related? It keeps happening too
that's because of our improved underlining, it doesn't look at good on your font because it's drawn a bit lower in the cell though. What font is it?
Cascadia Code
With the default, still a bit off <img width="179" alt="image" src="https://user-"
thanks, that's macOS with zoom level 0?
Yeah
Default font on macOS (Menlo): <img width="228" alt="Screen Shot 2022-08-19 at 1 04 24 pm" src="https://user-"
Font size 12: <img width="148" alt="Screen Shot 2022-08-19 at 1 06 40 pm" src="https://user-"Font size 14: <img width="167" alt="Screen Shot 2022-08-19 at 1 07 06 pm" src="https://user-"Font size 16: <img width="191" alt="Screen Shot 2022-08-19 at 1 07 52 pm" src="https://user-"
Can also happen on dpr 1 (Windows 11, Hack): !
Change:
"rimraf": "^2.6.1", "strip-json-comments": "^2.0.1", "tmp": "0.0.33", <del> "typescript": "2.5.2", </del> <ins> "typescript": "2.9.2", </ins> "watch": "^1.0.2" } }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: master commit OS Version: macOS 10.13.6 Steps to Reproduce: clone vscode ouput: how to fix: update typescript version from to will fix it.
Change:
private *getInlineLinks(document: SkinnyTextDocument, noLinkRanges: NoLinkRanges): Iterable<MdLink> { const text = document.getText(); <ins> for (const match of text.matchAll(linkPatternAngle)) { const matchImageData = match[4] && extractDocumentLink(document, match[3].length + 1, match[4], match.index); if (matchImageData && !noLinkRanges.contains(matchImageData.source.hrefRange)) { yield matchImageData; } const matchLinkData = extractDocumentLink(document, match[1].length, match[5], match.index); if (matchLinkData && !noLinkRanges.contains(matchLinkData.source.hrefRange)) { yield matchLinkData; } } </ins> for (const match of text.matchAll(linkPattern)) { const matchImageData = match[4] && extractDocumentLink(document, match[3].length + 1, match[4], match.index); if (matchImageData && !noLinkRanges.contains(matchImageData.source.hrefRange)) { yield matchImageData; } <ins> if (match[5] !== undefined && match[5].startsWith('<')) { continue; } </ins> const matchLinkData = extractDocumentLink(document, match[1].length, match[5], match.index); if (matchLinkData && !noLinkRanges.contains(matchLinkData.source.hrefRange)) { yield matchLinkData;

Discussion:
Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.61.2 OS Version: macOS Big Sur Steps to Reproduce: a new markdown file. ! But according to it isn't necessary to escape spaces when the text is enclosed in :
Removing help wanted since this is a bit more complicated than anticipated
Thanks!