jiebi/CodeConvo huggingface dataset:
Change:
} else { // This should only be needed immediately after createTerminalRenderer is called as // the ExtHostTerminal has not yet been iniitalized <del> setTimeout(() => { c(this._getTerminalByIdEventually(id, retries - 1)); }, 200); </del> <ins> this._delay(200, c(this._getTerminalByIdEventually(id, retries - 1))); </ins> } }); }

Discussion:
Verification steps?
Verification Steps: Create an extension with this command: (vscode.commands.registerCommand('terminalTest.createAndSend', () ={ const terminal = (); if((<anyterminal).onDidWriteData) { (<anyterminal).onDidWriteData(data ={('Hello World!');}); } terminal.sendText("echo 'Sent text immediately after creating'"); })); When you execute the command, confirm that the 'Hello World!' info message shows. Do this five or so more times since this is a race condition.
Change:
source-map "^0.6.1" supports-color "^6.1.0" <ins> prebuild-install@^6.0.0: version "6.0.0" resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-6.0.0.tgz#669022bcde57c710a869e39c5ca6bf9cd207f316" integrity sha512-h2ZJ1PXHKWZpp1caLw0oX9sagVpL2YTk+ZwInQbQ3QqNd4J03O6MpFNmMTJlkfgPENWqe5kP0WjQLqz5OjLfsw== dependencies: detect-libc "^1.0.3" expand-template "^2.0.3" github-from-package "0.0.0" minimist "^1.2.3" mkdirp-classic "^0.5.3" napi-build-utils "^1.0.1" node-abi "^2.7.0" noop-logger "^0.1.1" npmlog "^4.0.1" pump "^3.0.0" rc "^1.2.7" simple-get "^3.0.3" tar-fs "^2.0.0" tunnel-agent "^0.6.0" which-pm-runs "^1.0.0" </ins> prelude-ls@~1.1.2: version "1.1.2" resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.1.2.tgz#21932a549f5e52ffd9a827f570e04be62a97da54"

Discussion:
Captured by Symbolicated trace:
Crash in keytar module due to missing handlescope in callbacks when reentering javascript thread
Change:
for (const [uri, item] of this.items) { for (const editorId of item.keys()) { if (!this.editorService.visibleTextEditorControls.find(editor => isCodeEditor(editor) && editor.getModel()?.uri.toString() === uri.toString() && editor.getId() === editorId)) { <del> dispose(item.values()); this.items.delete(uri); </del> <ins> if (item.has(editorId)) { const dirtyDiffItem = item.get(editorId); dirtyDiffItem?.dispose(); item.delete(editorId); if (item.size === 0) { this.items.delete(uri); } } </ins> } } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: Windows 10 Steps to Reproduce: The "editorGutter" element in the editor has disappeared, and the corresponding colors for Git changes cannot be displayed. normal: ! ! wrong: !
Do you have any settings related to gutters that you've modified?
No, I haven’t modified any related settings. And after suspecting it was a git issue, I’ve upgraded git to the latest version, but the problem still hasn’t been resolved.
I found a stable way to reproduce the problem: Step: 1Open a file 2Click " Ctrl +  " 3Close the split
do you mind taking an initial look at this? Thanks!
thanks for the repro steps!
Change:
} } <ins> private createBadge(container: HTMLElement): void { const controlsContainer = DOM.append(container, DOM.$('.repl-panel-filter-controls')); const filterBadge = this.filterBadge = DOM.append(controlsContainer, DOM.$('.repl-panel-filter-badge')); this._register(attachStylerCallback(this.themeService, { badgeBackground, badgeForeground, contrastBorder }, colors => { const background = colors.badgeBackground ? colors.badgeBackground.toString() : ''; const foreground = colors.badgeForeground ? colors.badgeForeground.toString() : ''; const border = colors.contrastBorder ? colors.contrastBorder.toString() : ''; filterBadge.style.backgroundColor = background; filterBadge.style.borderWidth = border ? '1px' : ''; filterBadge.style.borderStyle = border ? 'solid' : ''; filterBadge.style.borderColor = border; filterBadge.style.color = foreground; })); this.updateBadge(); this._register(this.filters.onDidStatsChange(() => this.updateBadge())); } private updateBadge(): void { if (this.filterBadge) { const { total, filtered } = this.filters.filterStats; const filterBadgeHidden = total === filtered || total === 0; this.filterBadge.classList.toggle('hidden', filterBadgeHidden); this.filterBadge.textContent = localize('showing filtered repl lines', "Showing {0} of {1}", filtered, total); this.filterInputBox.inputElement.style.paddingRight = filterBadgeHidden ? '4px' : '150px'; } } </ins> protected get class(): string { return 'panel-action-tree-filter'; }

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
jsonc-parser "^1.0.0" vscode-languageserver-types "^3.6.0-next.1" <ins> vscode-html-languageservice@^3.0.3: version "3.0.3" resolved "https://registry.yarnpkg.com/vscode-html-languageservice/-/vscode-html-languageservice-3.0.3.tgz#0aeae18a59000e317447ea34965f72680a2140ef" integrity sha512-U+upM3gHp3HaF3wXAnUduA6IDKcz6frWS/dTAju3cZVIyZwOLBBFElQVlLH0ycHyMzqUFrjvdv+kEyPAEWfQ/g== dependencies: vscode-languageserver-types "^3.15.0-next.2" vscode-nls "^4.1.1" vscode-uri "^2.0.3" vscode-languageserver-types@^3.15.0-next.2: version "3.15.0-next.2" resolved "https://registry.yarnpkg.com/vscode-languageserver-types/-/vscode-languageserver-types-3.15.0-next.2.tgz#a0601332cdaafac21931f497bb080cfb8d73f254" integrity sha512-2JkrMWWUi2rlVLSo9OFR2PIGUzdiowEM8NgNYiwLKnXTjpwpjjIrJbNNxDik7Rv4oo9KtikcFQZKXbrKilL/MQ== </ins> vscode-languageserver-types@^3.6.0-next.1: version "3.6.0-next.1" resolved "https://registry.yarnpkg.com/vscode-languageserver-types/-/vscode-languageserver-types-3.6.0-next.1.tgz#98e488d3f87b666b4ee1a3d89f0023e246d358f3" integrity sha512-n4G+hCgZwAhtcJSCkwJP153TLdcEBWwrIrb3Su/SpOkhmU7KjDgxaQBLA45hf+QbhB8uKQb+TVStPvbuYFHSMA== <ins> vscode-nls@^4.1.1: version "4.1.1" resolved "https://registry.yarnpkg.com/vscode-nls/-/vscode-nls-4.1.1.tgz#f9916b64e4947b20322defb1e676a495861f133c" integrity sha512-4R+2UoUUU/LdnMnFjePxfLqNhBS8lrAFyX7pjb2ud/lqDkrUavFUTcG7wR0HBZFakae0Q6KLBFjMS6W93F403A== vscode-uri@^2.0.3: version "2.0.3" resolved "https://registry.yarnpkg.com/vscode-uri/-/vscode-uri-2.0.3.tgz#25e5f37f552fbee3cec7e5f80cef8469cefc6543" integrity sha512-4D3DI3F4uRy09WNtDGD93H9q034OHImxiIcSq664Hq1Y1AScehlP3qqZyTkX/RWxeu0MRMHGkrxYqm2qlDF/aw== </ins> vscode@1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/vscode/-/vscode-1.0.1.tgz#3d161200615fe2af1d92ddc650751159411a513b"

Discussion:
Issue Type: <bFeature Request</bI'm not talking about the editor's horizontal scroll is a very thin scroll bar between the tabs and editor,that's what i'm talking about. When you open too many tabs,some tabs are invisible so you need scrolling horizontally. There's a scrollbar to scroll the tabs,but it's too thin. Of course,this wasn't a big bug or what,and I can use "Ctrl+Tab" to switch tabs. maybe this bar should be bigger or even disappear considering it's not helpful. VS Code version: Code 1.32.3 (, 2019-03-14T23:43:35.476Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.49 --<!-- potentialduplicatescomment --
Duplicate of
Oops, tagged wrong issue.
Change:
]; const settings = getSettings(); <del> const isMac = settings.isMac; </del> <ins> const isMac = navigator.platform.toUpperCase().indexOf('MAC') >= 0; </ins> const vscode = acquireVsCodeApi();

Discussion:
Extension version: v0.29.2 VSCode Version: 1.59.0 OS: GitHub editor / mac Steps to Reproduce: "" on the right side image, it zooms in ctrl down and the icon turns into a "zoom out" icon Expected outcome: Zoom out Actual outcome: You see a menu with "Cut", "Copy", "Paste"
The image preview editor is provided by VS Code core (instead of this extension), so moving this issue to VS Code.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.509 --- <!-- score: 0.493 --<!-- potentialduplicatescomment --
maybe a safari issue?
In Chrome, ctrl-click only shows the menu In Safari, ctrl-click zooms out and also shows the menu
Thanks for the additional details. In Edge, I get only the zoom out.
Working fine in firefox.
Issue exists in Safari browser, how can I fix this
yes it works in safari , but the the cursor remains zoom out cursor even when I don't press control, it doesn't change back to + symbol
Can i work on this??
if you didn't work to zoom in or zoom out you use simply method on keybord key ctrl + or ctrl - .
I really want to be VS Code contributor. I try to working on this task since yesterday. I hope I will find the fix and my first meeting with VSC will end with success ;)
Zoom in Works fine in Safari, however zoom out works but the magnifying glass disappears and I had to double click (not sure if this is intentional) to get the image to properly zoom out while zoom in only take one click.
Change:
} alert(localize('uninstallExtensionStart', "Uninstalling extension {0} started.", this.extension.displayName)); <del> return this.extensionsWorkbenchService.uninstall(this.extension).then(() => { </del> <ins> try { await this.extensionsWorkbenchService.uninstall(this.extension); </ins> alert(localize('uninstallExtensionComplete', "Please reload Visual Studio Code to complete the uninstallation of the extension {0}.", this.extension!.displayName)); <del> }); </del> <ins> } catch (error) { this.dialogService.error(getErrorMessage(error)); } </ins> } }

Discussion:
I clicked to "Uninstall" an extension with dependencies and got an error toast as a result: ! I think since I clicked a button explicitly, I would expect a modal dialog as a result.
Sounds low hanging? Should we close or this milestone to fix?
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Change:
errorTelemetry.dispose(); service.dispose(); <ins> sinon.restore(); </ins> })); test('Unexpected Error Telemetry removes PII but preserves Missing Model error message', sinonTestFn(function (this: any) {

Discussion:
In short, if you use without calling you are leaking memory. See for the details. I'm seeing a lot of memory used in unit tests and it appears to be coming from sinon. This may be contributing to our unit test OOM issue on Windows 32 bit. Let's see if fixing this lets us run the unit tests again. To fix I have made disposable, and there were some places where tests failed or the refactor seemed larger:
The biggest gain would be from fixing the leak from as it is used many places.
I don't know if you own , but I am looking into a fix for it since it will have the biggest impact.
I've reopened this.
Thanks. I should be careful to not do and instead as that will prevent GitHub from auto closing it
With , I have made disposable and handled disposing it in most tests. There are several places where the way to handle this isn't clear or made test fail when I just naively disposed it. I have them in the issue above.
the instance in is already restored at , but the others should be fixed in Let me know if I miss any! Edit: I ended up making changes in both files.
For those tests where I am just using , should I have to still call or I should wait for your change to dispose the ?
You can wait for my change to dispose the .
FYI Windows ia32 started turning green again
and the only files left are yours. The is now disposable and should be disposed in these test files to properly restore and prevent a memory leak.
Thank you for the fast response everyone!
need help
Change:
"kill-watch-webd": "deemon --kill yarn watch-web", "restart-watchd": "deemon --restart yarn watch", "restart-watch-webd": "deemon --restart yarn watch-web", <del> "watch-client": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-client", </del> <ins> "watch-client": "node --max-old-space-size=4095 ./node_modules/gulp/bin/gulp.js watch-client", </ins> "watch-clientd": "deemon yarn watch-client", "kill-watch-clientd": "deemon --kill yarn watch-client", <del> "watch-extensions": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-extensions watch-extension-media", </del> <ins> "watch-extensions": "node --max-old-space-size=4095 ./node_modules/gulp/bin/gulp.js watch-extensions watch-extension-media", </ins> "watch-extensionsd": "deemon yarn watch-extensions", "kill-watch-extensionsd": "deemon --kill yarn watch-extensions", "precommit": "node build/hygiene.js", <del> "gulp": "node --max_old_space_size=8192 ./node_modules/gulp/bin/gulp.js", </del> <ins> "gulp": "node --max-old-space-size=8192 ./node_modules/gulp/bin/gulp.js", </ins> "electron": "node build/lib/electron", "7z": "7z", "update-grammars": "node build/npm/update-all-grammars.mjs",

Discussion:
Builds:
fyi
Attempting a fix by simply doubling the max memory available to V8.
Again in
Then I'm out of ideas. we might need to split all those mangling tasks into independent processes, if memory limits are being hit.
Are we sure that we are on the right track here? According to my counting (below) we have only a tenth of the code in extensions (compare to the src-folder) so I wonder why mangling would eat up so much memory here?
I am not sure OOM is the symptom here actually, just my best hunch, but it seems is indeed the problem: <img width="913" alt="image" src=""
Added a every 1 second log of memory usage to this task: Build running:
Created to log the memory usage after each mangling step
lol - similar idea here:
I think we are on to something here. The memory is growing a lot, maybe some state leaks when mangling the next extension. Each extension is its own tsconfig and mangling context. This shouldn't pile up but memory should be released inbetween
Can you take a look at this? I put my money on this which keeps its mangler around. Looks like we need some webpack hook to dispose that loader
I gave it a stab at for which I have confidence, running locally shows how memory is growing and shrinking! This isn't a webpack change but just some cleanup in the mangler itself
!
Change:
background-color: rgba(255, 255, 255, 0.1); } <del> .monaco-workbench .part.titlebar.light > .window-controls-container > .window-icon:hover { </del> <ins> .monaco-workbench .part.titlebar.light .window-controls-container > .window-icon:hover { </ins> background-color: rgba(0, 0, 0, 0.1); }

Discussion:
Type: <bBug</byour mouse pointer over the minimize, maximize/restore window buttons. the absence of the button hover animation. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-20T06:55:34.457Z) OS version: Linux x64 6.2.0-35-generic snap Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I was not able to reproduce with the latest snap release on ubuntu. please let me know if you continue to reproduce.
I have the same issue as OP and I'm using the PPA install method under KDE Neon (Ubuntu 22.04 based). Please consider reopening the issue. System info below: Version: 1.85.1 Commit: Date: 2023-12-13T09:47:11.635Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Linux x64 6.2.0-39-generic
I can still reproduce the issue, but only using the default "Light Modern" theme. So, it looks like this is the problem of the default "Light Modern" theme. Initially, I thought the animation was missing, but if you look closely it's there. However, the transition states are so subtle, they're barely visible. VS Code Version: VS Code Insiders Version:
True looks like a theming issue and on my end all light mode themes exhibit this issue. All dark mode ones work well.
I couldn't repro this with stable, but I also couldn't repro with insiders, so marking as verified.
The issue still persists as of today and will hopefully be resolved in a future release. Until then, if you're using a light theme, you can add something like this to your file: This will make the title bar a bit darker and the hover animation will show even if slightly.
Change:
registerAction2(OpenMergeEditor); registerAction2(OpenBaseFile); <del> registerAction2(GoToNextConflict); registerAction2(GoToPreviousConflict); </del> <ins> registerAction2(GoToNextUnhandledConflict); registerAction2(GoToPreviousUnhandledConflict); </ins> registerAction2(ToggleActiveConflictInput1); registerAction2(ToggleActiveConflictInput2);

Discussion:
Testing Clone Use the command and select the folder Select in the quick pick It looks like the file has 4 conflict Pressing "Go to Next Conflict" highlights the first conflict Pressing "Go to Next Conflict" again does not do anything Also interesting that the editor minimap only has one conflict marker
I also saw this. It seemed to happen when both inputs make the same change.
On , once it moves past the first conflict and try to go back to it, it doesn't go back to it properly. !
This is weird, I cannot reproduce this. Also, for , I only have 2 conflicts. And this checkbox is also very weird: !
I'm on commit , not the latest commit. Does that make a difference?
If you can reproduce on the latest commit, can you try to give me a call?
yup, things look good on the latest on master for diff-merge-datasets for demo1. :) One thing I noticed, though, is that, if you're focused on the result and try to skip to next conflict, it's hard to tell by looking at the two inputs where the conflict is (seems that the two inputs aren't telling me anything in this screenshot): ! When I make the input editors a little bigger, then it starts making a little more sense. ! Not too big of a deal though, just wanted to bring your attention to it!
Change:
export interface NodeRequestOptions extends IRequestOptions { agent?: Agent; strictSSL?: boolean; <ins> isChromiumNetwork?: boolean; </ins> getRawRequest?(options: IRequestOptions): IRawRequestFunction; }

Discussion:
When requests from shared process are redirected to main, the main request service is throwing errors for some valid requests. The same request is working when using browser XHR in shared process. To reproduce: Start VS Code using fresh user data dir and extensions dir Enable this setting - this is an internal developer setting, so you have to set manually in the file Turn on settings sync using your insiders settings sync service (Disable syncing settings) Extensions Syncing fails because of above error cc
What is the exact request URL and headers? We should be able to reproduce in a Electron fiddle maybe.
is an error from the chromium network stack, it happens when the request contains one of the following forbidden headers ;l=22-48
Here is the request info URL: Headers: Payload:
Are we setting the header ? The runtime will add that during payload upload, but if we override it then it will cause the above error.
Yes, we are
BTW we do the same request also in the renderer for querying extensions, so does removing the impacts the request in the renderer that uses XHR ?
Just tried removing the header and I am getting following error
The header will get by the runtime for payload requests, you should be able to confirm after removing the header. So, I don't think it will impact requests from renderer via XHR Hmm, why is zlib module being involved ? Are we using request API by any chance ?
We are not using request. Request service in main extends Node request service and pass electron net request API to Node request service for making request. See here: While handling the response, Node request service is checking for header and using zlib if it is set to . See here: May be main request service shall not use node request service at all?
Possibly an easier repro that was discovered by is calling the command also fails with the same network error. You should be able to do this via an extension
Can we now also make sure to go back to the Electron solution for maybe insiders to validate it works over some time?
Enabled -
Change:
return { enabled: boolean(input.enabled, this.defaultValue.enabled), mode: stringSet(input.mode, this.defaultValue.mode, ['prefix', 'subword', 'subwordSmart']), <del> showToolbar: stringSet(input.showToolbar, this.defaultValue.showToolbar, ['always', 'onHover']), </del> <ins> showToolbar: stringSet(input.showToolbar, this.defaultValue.showToolbar, ['always', 'onHover', 'never']), </ins> suppressSuggestions: boolean(input.suppressSuggestions, this.defaultValue.suppressSuggestions), keepOnBlur: boolean(input.keepOnBlur, this.defaultValue.keepOnBlur), };

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src="" alt="drawing" width="600"/Currently, we can control when to show the inline suggestion toolbar by setting to "always" or "onHover", which are defined as follows: "always": show the inline suggestion toolbar whenever an inline suggestion is shown, and "onHover": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option "never" as follows "never": do not show the inline suggestion toolbar.
I think this should be very easy to implement. Up for a PR?
I would like to take this.
Any ideas why this setting isn't in the Settings JSON file? .
Thank you so much for accepting the request and for the contribution!