jiebi/CodeConvo huggingface dataset:
Change:
import { Button } from '../../../../base/browser/ui/button/button.js'; import { ITreeElement } from '../../../../base/browser/ui/tree/tree.js'; import { Action } from '../../../../base/common/actions.js'; <del> import { Delayer } from '../../../../base/common/async.js'; </del> <ins> import { Delayer, raceTimeout } from '../../../../base/common/async.js'; </ins> import { CancellationToken, CancellationTokenSource } from '../../../../base/common/cancellation.js'; import { fromNow } from '../../../../base/common/date.js'; import { isCancellationError } from '../../../../base/common/errors.js';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: Linux x64 6.6.26-1-MANJARO Steps to Reproduce: VS Code. Developer Tools and watch Network requests. VS Code, open Settings. that Settings will not display any settings until the requests to are completed. reading the results of the queries, observe that this request is related to the absolutely despicable advertisement for GitHub Copilot_, to detect if it's already installed (or something) in order to show the ad in the Settings UI and that you are now even more incensed that something which should work immediately was taking 7 seconds or longer due to the fact that we are now living through a dystopia. Then quickly get over it and start considering a move to a different editor or a fork. Please choose one of the following suggestions: remove the GitHub Copilot advertisement from the Settings UI. waiting for network requests in order to show the Settings UI. this issue and ignore this unquestionably sane plea to help battle the enfecalization of this beloved product.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
The AUR hasn't been updated with 1.89.1 yet but looking at the resolved issues I don't see any related to this.
I have a 1-second timeout per network request. In other words, the delays should now have an upper limit on their duration.
Change:
import { MenuRegistry, MenuId } from 'vs/platform/actions/common/actions'; import { CommandsRegistry } from 'vs/platform/commands/common/commands'; import { FalseContext } from 'vs/platform/contextkey/common/contextkeys'; <del> import { ShowCurrentReleaseNotesActionId } from 'vs/workbench/contrib/update/common/update'; </del> <ins> import { ShowCurrentReleaseNotesActionId, CheckForVSCodeUpdateActionId } from 'vs/workbench/contrib/update/common/update'; </ins> import { IWindowService, IWindowsService } from 'vs/platform/windows/common/windows'; const CONTEXT_UPDATE_STATE = new RawContextKey<string>('updateState', StateType.Uninitialized); let releaseNotesManager: ReleaseNotesManager | undefined = undefined;

Discussion:
Ability to update VS Code from the command palette as I have disabled activity bar and have to reenable it to update VS Code. Also, there is a palette option to check for extensions updates, but not for the whole app Steps: Command palette VS Code
First timer here. Could I give this one a shot?
I can do this work.
Hello there, I'm experienced developer and would like to contribute.
Hello there, I am a developer and I have gone through the whole code base and I think that I can add this feature without much problem. Can I please give it a shot?
Please do, you can check the
I have implemented this feature in . Kindly review it.
Works nicely, for downloading updates, but a command doesn't show to Restart To Update.
Change:
if (this.options.onFeedbackVisibilityChange) { this.options.onFeedbackVisibilityChange(true); } <ins> this.updateCharCountText(); </ins> } protected onHide(): void {

Discussion:
Issue Type: <bBug</b'Tweet Feedback' button at the right bottom corner of the Visual Studio Code window. some text in the text box in the appeared floating window. Current state: character counter is less than 270, 'Tweet' button is active and clickable. the floating window either using ESC key or by tapping the 'Close' button at the top of the window. 'Tweet Feedback' button again to reopen the window. The state is incorrectly restored: The text is restored, it is in the text box as it should be. The character counter is not restored and is equal to 270 characters. The 'Tweet' button is not active and is not clickable. Any change in the text box or selection of any of the smiles will result in state update to the expected values. ! Also, if you choose 'Happy Feedback Sentiment' at any point, the default value of the character counter on the window reopen would be 257, not 270 (because the 'Happy Feedback Sentiment' mode adds the '#HappyCoding' hashtag to the resulting tweet status), so the Feedback Sentiment selection state persists properly on the window reopen. ! Possible solution The code responsible for the feature is located in . The function does the job of updating the counter & the 'Tweet' button state, so its call in the window reopen function may be sufficient to resolve the issue. I think the function is called on window reopen, so it may be used for that purpose. VS Code version: Code 1.46.1 (, 2020-06-17T21:13:20.174Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
If the possible solution I propose is correct I would like to try to correct the issue on my own then.
Not sure who owns this.
If someone wants to investigate, no plans from my end.
I set up the development environment as described in the repository wiki to try to fix this issue and contribute the code as a PR. However, after a long path of trying to run the Code - OSS I ended up with a version of VS Code with no 'Tweet Feedback' feature at all (no icon in the status bar, no entry in the command palette).

do you know why the 'Tweet Feedback' feature is out of the Code - OSS build and can I fix this somehow to work on the issue?
yeah you will make changes to as follows: Then you should get it.
Change:
import { IExtensionService, IExtensionDescription } from 'vs/workbench/services/extensions/common/extensions'; import { URI } from 'vs/base/common/uri'; import { CommandsRegistry, ICommandService } from 'vs/platform/commands/common/commands'; <del> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </del> <ins> import { IConfigurationService, ConfigurationTarget } from 'vs/platform/configuration/common/configuration'; </ins> import { registerThemingParticipant, ITheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; import { buttonBackground, buttonForeground, buttonHoverBackground, contrastBorder, registerColor, foreground } from 'vs/platform/theme/common/colorRegistry'; import { Color } from 'vs/base/common/color';

Discussion:
Improve user experience while installing themes
!
It would be cool if you could preview themes in the store, maybe with a split view hosting some example code, or even with the files you have open.
Please open a feature request for it
Change:
} this._historyOffset = -1; this._historyCandidate = ''; <ins> this._stashedSession.clear(); </ins> this._onWillStartSession.fire(); this._currentRun = this._nextState(State.CREATE_SESSION, options); await this._currentRun;

Discussion:
Got the trace below, this happens when PAUSE is enter as part of error handling which then also errors...
The error leading up to this is:
To verify start inline chat get it to make changes select ESC to hide inline chat select cmd+i to start inline chat again
Change:
// Single quotes { link: ''foo',339', prefix: ''', suffix: '',339', hasRow: true, hasCol: false }, { link: ''foo',339:12', prefix: ''', suffix: '',339:12', hasRow: true, hasCol: true }, <ins> { link: ''foo',339.12', prefix: ''', suffix: '',339.12', hasRow: true, hasCol: true }, </ins> { link: ''foo', line 339', prefix: ''', suffix: '', line 339', hasRow: true, hasCol: false }, { link: ''foo', line 339, col 12', prefix: ''', suffix: '', line 339, col 12', hasRow: true, hasCol: true }, { link: ''foo', line 339, column 12', prefix: ''', suffix: '', line 339, column 12', hasRow: true, hasCol: true },

Discussion:
The : This doesn't currently work in VSCode. It does support a very wide range of formats and I don't recall ever seeing this format before (even from GNU tools) so I suspect nobody else uses it. Nonetheless it's easy to add support in VSCode. See
Doesn't seem to work, see <img width="825" alt="Screenshot 2023-08-29 at 14 41 05" src=""
The PR intentionally left that out: But it should be easy to add so will leave this open.
Change:
controller.previousCommentThread(); }, weight: KeybindingWeight.EditorContrib, <del> when: EditorContextKeys.focus, </del> primary: KeyMod.Shift | KeyMod.Alt | KeyCode.F9 });

Discussion:
Testing The accessibility help says this should work, but it does not appear to do anything
if you use a different keybinding, does it work ?
I switched it to with no effect
keyboard shortcuts troubleshooting show anything of interest?
Here it is. I ran the keybinding twice, the first time worked when I wasn't on a comment and navigated to a comment. The second time did nothing once I was there.
Change:
registerEditorCommand(new SuggestCommand({ id: 'selectPrevPageSuggestion', <del> precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.MultipleSuggestions), </del> <ins> precondition: ContextKeyExpr.and(SuggestContext.Visible, ContextKeyExpr.or(SuggestContext.MultipleSuggestions, SuggestContext.HasFocusedSuggestion.negate())), </ins> handler: c => c.selectPrevPageSuggestion(), kbOpts: { weight: weight,

Discussion:
Type: <bBug</bOpen new document. Set . Type now start typing the editor will show suggestion (with only one in the list). Now pressing should select the available suggestion, but it can not be done. On the other hand if you type and then start typing the list will contain two items and selection works as expected - when you press the first item is selected and you can navigate the list with and VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
with the setting set to "never" is it expected that there is one selected by default? I didn't have to arrow down for this to happen !
Change:
scopedContextKeyService: IContextKeyService ): QuickPickInput<KernelQuickPickItem>[]; <del> protected async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem) { </del> <ins> protected async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem, quickPickItems: KernelQuickPickItem[]): Promise<boolean> { </ins> if (isKernelPick(pick)) { const newKernel = pick.kernel; this._selecteKernel(editor.textModel, newKernel);

Discussion:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !
Change:
width: 1px; } <ins> .monaco-button-dropdown > .monaco-button.monaco-dropdown-button { border-left-width: 0 !important; } </ins> .monaco-description-button { flex-direction: column; }

Discussion:
You can see in the image that the split part doesn't look right. FYI my theme is ! /cc
//cc
I think this might be another style issue with the button border since the separator container use the full height: <img width="430" alt="CleanShot 2022-07-20 at 10 56 10 src="https://user-"If you don't set a border it looks normal: <img width="237" alt="CleanShot 2022-07-20 at 10 54 13 src="https://user-"
thanks for tracking this down. I will try to squeeze a fix in this week.
Change:
tags?: Set<string>; overriddenScopeList: string[] = []; <ins> /** * For each language that contributes setting values or default overrides, we can see those values here. */ </ins> languageOverrideValues: Map<string, IConfigurationValue<unknown>> = new Map<string, IConfigurationValue<unknown>>(); description!: string; valueType!: SettingValueType;

Discussion:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.
Change:
eventsCollector.emitViewEvent(new viewEvents.ViewConfigurationChangedEvent(e)); this.viewLayout.onConfigurationChanged(e); <del> if (restorePreviousViewportStart && previousViewportStartModelPosition) { const viewPosition = this.coordinatesConverter.convertModelPositionToViewPosition(previousViewportStartModelPosition); const viewPositionTop = this.viewLayout.getVerticalOffsetForLineNumber(viewPosition.lineNumber); this.viewLayout.setScrollPosition({ scrollTop: viewPositionTop + this._viewportStart.startLineDelta }, ScrollType.Immediate); } </del> <ins> stableViewport.recoverViewportStart(this.coordinatesConverter, this.viewLayout); </ins> if (CursorConfiguration.shouldRecreate(e)) { this.cursorConfig = new CursorConfiguration(this.model.getLanguageId(), this.model.getOptions(), this._configuration, this.languageConfigurationService);

Discussion:
use autofolding of imports . use a type that is not imported in a TS file use quick fix to add the import the editor scrolls to an incorrect position. I think this is a recent regression, because I've been using both import folding and quick fix for imports since quite a while... maybe starting with the last stable. https://user- Version: 1.72.0-insider Commit: Date: 2022-09-21T05:40:07.654Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Un-assigning myself as I don't think this cause by something the JS/TS extension itself is doing
who owns the quick fix UI now?
I own the UI. However it looks like scrolling here happen when the edit from the quick fix is applied. That's why I unassigned myself
It also unfolds if you do "Organize Imports", so seems like any action related with imports unfolds even though setting is
The root cause appears to be the folding ranges change and end up calling . That one does not attempt to maintain the viewport stable in any way.
this issue still exists:
Change:
} const entry = { line: lineNumber, element: element }; if (lineNumber === targetLine) { <del> return { before: entry, next: null }; </del> <ins> return { previous: entry, next: null }; </ins> } else if (lineNumber > targetLine) { return { previous, next: entry }; }

Discussion:
The current behaviour of Code's Markdown previewer when clicking a relative link is actually a bit cryptic: it attempts to open the file relative to the user's home path with the system's application of choice. This will commonly lead to errors being dispatched because the file cannot be found. If I have the following Markdown: Clicking the link will make my system attempt to open . Given that even , I strongly believe that they should be supported here. Such links should instead be relative to the markdown file's directory and open the linked file using the Code editor.
+1; opening markdown files by clicking a (relative) link in the preview would be a very powerful feature both for writing developer documentation (split into individual files by topic) for a project, but also for viewing that documentation.
Related: Is this behavior something vscode could change for its markdown preview?
Change:
const existing = firstOrDefault(this.editorService.findEditors(resource, targetGroup)); if (existing) { if (!input.matches(existing)) { <ins> // The current editor needs to be saved before it can be opened in a custom editor if (existing.isDirty()) { const message = nls.localize('promptOpenWith.unsaved', 'This file has unsaved changes and is attempting to be opened in a custom editor.'); const buttonActions: string[] = [ nls.localize('save', 'Save'), nls.localize('discard', 'Discard Changes'), nls.localize('abort', 'Abort') ]; enum UnsavedEditorAction { SAVE = 0, DISCARD = 1, ABORT = 2, } const res = await this.dialogService.show(Severity.Warning, message, buttonActions); if (res.choice === UnsavedEditorAction.SAVE) { await existing.save(this.editorGroupService.activeGroup.id, { reason: SaveReason.EXPLICIT }); } else if (res.choice === UnsavedEditorAction.DISCARD) { await this.editorService.revert({ groupId: this.editorGroupService.activeGroup.id, editor: existing }); } else { return; } } </ins> await this.editorService.replaceEditors([{ editor: existing, replacement: input,

Discussion:
Testing new untitled file and add some text. Editor: Open File The original untitled file is left open and changes in the Hex Editor are not reflected in that original file. !
This will be fixed by
Change:
await writeP(xterm, 'x1b]633;D;7x07'); mock.verify(); }); <ins> test('should pass command line sequence to the capability', async () => { const mock = shellIntegrationAddon.getCommandDetectionMock(xterm); mock.expects('setCommandLine').once().withExactArgs('', false); await writeP(xterm, 'x1b]633;Ex07'); mock.verify(); const mock2 = shellIntegrationAddon.getCommandDetectionMock(xterm); mock2.expects('setCommandLine').twice().withExactArgs('cmd', false); await writeP(xterm, 'x1b]633;E;cmdx07'); await writeP(xterm, 'x1b]633;E;cmd;invalid-noncex07'); mock2.verify(); }); </ins> test('should not activate capability on the cwd sequence (OSC 633 ; P=Cwd=<cwd> ST)', async () => { strictEqual(capabilities.has(TerminalCapability.CommandDetection), false); await writeP(xterm, 'foo');

Discussion:
Run a command - for example - then and it doesn't exit that command !
Same issue: Versione: 1.78.1 Commit: Data: 2023-05-04T09:57:42.343Z Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 Sistema operativo: Darwin x64 18.7.0 In modalità sandbox: No
insiders-releasecontrl+Cbash: no job control in this shell
me too!
I am also facing the same problem and it is quite frustrating since killing the terminal is not killing the process and every time I have identify the pid and kill it from another terminal. I notice that it is tagged "Closed" but it is not fixed as of yet, atleast in Code-Insiders. Please fix this issue or suggest some sort of solution.
me either
this clearly isn't fixed
The issue this was tracking with the error in console is fixed, let's track any separate problem in
Change:
* History item hover color */ export const historyItemHoverDefaultLabelForeground = registerColor('scmGraph.historyItemHoverDefaultLabelForeground', foreground, localize('scmGraphHistoryItemHoverDefaultLabelForeground', "History item hover default label foreground color.")); <del> export const historyItemHoverDefaultLabelBackground = registerColor('scmGraph.historyItemHoverDefaultLabelBackground', transparent(foreground, 0.2), localize('scmGraphHistoryItemHoverDefaultLabelBackground', "History item hover default label background color.")); </del> <ins> export const historyItemHoverDefaultLabelBackground = registerColor('scmGraph.historyItemHoverDefaultLabelBackground', badgeBackground, localize('scmGraphHistoryItemHoverDefaultLabelBackground', "History item hover default label background color.")); </ins> export const historyItemHoverLabelForeground = registerColor('scmGraph.historyItemHoverLabelForeground', buttonForeground, localize('scmGraphHistoryItemHoverLabelForeground', "History item hover label foreground color.")); export const historyItemHoverAdditionsForeground = registerColor('scmGraph.historyItemHoverAdditionsForeground', { light: '#587C0C', dark: '#81B88B', hcDark: '#A1E3AD', hcLight: '#374E06' }, localize('scmGraph.HistoryItemHoverAdditionsForeground', "History item hover additions foreground color.")); export const historyItemHoverDeletionsForeground = registerColor('scmGraph.historyItemHoverDeletionsForeground', { light: '#AD0707', dark: '#C74E39', hcDark: '#C74E39', hcLight: '#AD0707' }, localize('scmGraph.HistoryItemHoverDeletionsForeground', "History item hover deletions foreground color."));

Discussion:
Testing There is a second branch on the same commit, and the icon is dark when selected in light+ theme ! !
Great catch! This should look like the rest of the workbench badges: !
Change:
} @command('git.openChange') <del> async openChange(arg?: Resource | Uri): Promise<void> { let resource: Resource | undefined = undefined; </del> <ins> async openChange(arg?: Resource | Uri, ...resourceStates: SourceControlResourceState[]): Promise<void> { let resources: Resource[] | undefined = undefined; </ins> <del> if (arg instanceof Resource) { resource = arg; } else if (arg instanceof Uri) { resource = this.getSCMResource(arg); } else { resource = this.getSCMResource(); </del> <ins> if (arg instanceof Uri) { const resource = this.getSCMResource(arg); if (resource !== undefined) { resources = [resource]; } </ins> } <ins> else { let resource: Resource | undefined = undefined; if (arg instanceof Resource) { resource = arg; } else { resource = this.getSCMResource(); } </ins> <del> if (!resource) { </del> <ins> if (resource) { resources = [...resourceStates as Resource[], resource]; } } if (!resources) { </ins> return; } <del> return await this._openResource(resource); </del> <ins> const preview = resources.length === 1 ? undefined : false; for (const resource of resources) { await this._openResource(resource, preview); } </ins> } @command('git.stage')

Discussion:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.
Change:
max-width: none; } <del> .testing-filter-wrapper { height: 27px; } </del> .testing-filter-action-item .testing-filter-wrapper { flex-grow: 1; }

Discussion:
Two small UI issues with the filter input box in the test explorer: 's not enough right margin on the button cursor isn't aligned to center (oh, screenshot below can't capture it but basically the cursor isn't in the center vertically of the input box). <img width="647" alt="image" src=""
Fixed in
Seems better but not fixed? <img width="1090" alt="image" src=""I propose that we move this to next milestone, I can take a stab at fixing this For comparison, search input : <img width="1064" alt="image" src=""
I'm sorry to do this again, but the cursor is still not centered I think this is because the input widget has height of 20px while the container has height 23