jiebi/CodeConvo huggingface dataset:
Change:
"displayName": "CSS Language Features", "description": "Provides rich language support for CSS, LESS and SCSS files.", "css.title": "CSS", <del> "css.customData.desc": "A list of relative file paths pointing to JSON files following the [custom data format](https://github.com/microsoft/vscode-css-languageservice/blob/master/docs/customData.md).nnVS Code loads custom data on startup to enhance its CSS support for the custom CSS properties, at directives, pseudo classes and pseudo elements you specify in the JSON files.nnThe file paths are relative to workspace and only workspace folder settings are considered.", </del> <ins> "css.customData.desc": "A list of relative file paths pointing to JSON files following the [custom data format](https://github.com/microsoft/vscode-css-languageservice/blob/master/docs/customData.md).nnVS Code loads custom data on startup to enhance its CSS support for CSS custom properties (variables), at-rules, pseudo-classes, and pseudo-elements you specify in the JSON files.nnThe file paths are relative to workspace and only workspace folder settings are considered.", </ins> "css.completion.triggerPropertyValueCompletion.desc": "By default, VS Code triggers property value completion after selecting a CSS property. Use this setting to disable this behavior.", "css.completion.completePropertyWithSemicolon.desc": "Insert semicolon at end of line when completing CSS properties.", "css.lint.argumentsInColorFunction.desc": "Invalid number of parameters.",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Windows 10 Steps to Reproduce: to Settings UI, then search for "CSS: Custom Data" for this setting needs a few improvements in the CSS terms
Change:
aRawMatch('/1', new TextSearchMatch('preview 1', new OneLineRange(1, 1, 4)), new TextSearchMatch('preview 1', new OneLineRange(1, 4, 11)))]; <del> instantiationService.stub(ISearchService, searchServiceWithResults(results)); </del> <ins> instantiationService.stub(ISearchService, searchServiceWithResults(results, { limitHit: false, messages: [], results })); </ins> instantiationService.stub(INotebookSearchService, notebookSearchServiceWithInfo([], undefined)); const testObject: SearchModel = instantiationService.createInstance(SearchModel);

Discussion:
to , run a text search search is running, hit cancel on the "downloading repository index..." notification in the bottom right corner :bug: search view should show two messages (see below) but only the first one shows up !
Saw the notification about indexing but it was before I clicked search and now whenever I click search I don't see the notification come up.
I believe that you can try to do this with a larger repo (like ), and there should be enough time to cancel the index. Not too sure how to remove the index once it's downloaded, but you can try that first!
You can delete the downloaded index with the Delete All Repository Indexes command
The search result message changed but I see two messages at least !
Change:
import { ExtHostChatAgentsShape2, IChatAgentCompletionItem, IChatAgentHistoryEntryDto, IChatProgressDto, IExtensionChatAgentMetadata, IMainContext, MainContext, MainThreadChatAgentsShape2 } from 'vs/workbench/api/common/extHost.protocol'; import { CommandsConverter, ExtHostCommands } from 'vs/workbench/api/common/extHostCommands'; import { ExtHostDocuments } from 'vs/workbench/api/common/extHostDocuments'; <del> import { ExtHostNotebookController } from 'vs/workbench/api/common/extHostNotebook'; </del> import * as typeConvert from 'vs/workbench/api/common/extHostTypeConverters'; import * as extHostTypes from 'vs/workbench/api/common/extHostTypes'; import { ChatAgentLocation, IChatAgentRequest, IChatAgentResult } from 'vs/workbench/contrib/chat/common/chatAgents';

Discussion:
Today inline chat for editors and notebooks rely on implicit variables, e.g . This isn't proper and we should have real API, e.g some extra property on that encapsulates data about the chat location.
Done, no more implicit variables
Change:
} } <ins> // Profiles if (typeof config.workbench?.experimental?.settingsProfiles?.enabled === 'boolean' && config.workbench.experimental.settingsProfiles.enabled !== this.settingsProfilesEnabled) { this.settingsProfilesEnabled = config.workbench.experimental.settingsProfiles.enabled; changed = true; } </ins> // Notify only when changed and we are the focused window (avoids notification spam across windows) if (notify && changed) { this.doConfirm(

Discussion:
to the Settings editor on the setting . :bug: The user isn't prompted to restart the editor, so they end up encountering glitchy behaviour.
Change:
import { BetterTokenStorage, IDidChangeInOtherWindowEvent } from './betterSecretStorage'; import { LoopbackAuthServer } from './node/authServer'; import { base64Decode } from './node/buffer'; <ins> import fetch from './node/fetch'; </ins> import { UriEventHandler } from './UriEventHandler'; import TelemetryReporter from '@vscode/extension-telemetry'; import { Environment } from '@azure/ms-rest-azure-env';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information
will be exploring fixing this type of issue transparently.
This will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?
that fixed the issue. Thanks so much for the quick response to our problem!
Change:
kbOpts: { weight: CORE_WEIGHT, kbExpr: EditorContextKeys.textInputFocus, <del> primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyMod.Alt | KeyCode.DownArrow, </del> <ins> primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.DownArrow, </ins> linux: { primary: 0 } } }));

Discussion:
VSCode Version: Code 1.17.1 (, 2017-10-10T14:24:50.851Z) OS Version: Windows_NT x64 10.0. Current default keybindings on Windows: has two key bindings, which seems unnecessary. On Linux the default key bindings are (IIRC): Which makes a lot more sense IMHO. Also using this default on Windows would also align Windows/Linux key bindings and maybe even avoid complications like . (same for of course)
We will not change this. See
Change:
}, { "command": "git.close", <del> "when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0" </del> <ins> "when": "config.git.enabled && !git.missing && gitOpenRepositoryCount > 1" </ins> }, { "command": "git.refresh",

Discussion:
Steps to Reproduce: VS Code and open a folder/workspace that contains one git repository to the "Source Control" viewlet, and open the "Source Control Repositories" view click on the repository and choose "Close Repository" viewlet will be into a weird state Expected: If there is only one repository opened, the "Close Repository" command should be disabled
I still see it being enabled, but there's technically no weird state.
After consideration we have decided that one should be able to close the last repository. In that scenario we will be showing a welcome view with a primary action for the user to reopen the closed repository.
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!
Change:
this.contentChangeEventScheduler.schedule(); } <ins> public isReadonly(): boolean { return false; } </ins> public dispose(): void { super.dispose();

Discussion:
Edit a file tracked by Git Stage the file In the SCM viewlet, click the file in the "staged" section to open an editor that says Type in the file In 1.24.1, I can't edit it because it's a read-only editor In 1.25, I can type in the editor, but changes aren't actually written anywhere. If I switch away from the file and switch back, they are gone
please review
thanks for the fix, I will review it now.
Merged pr, closing
Change:
get disableUpdates(): boolean { return !!this.args['disable-updates']; } @memoize <del> get disableKeytar(): boolean { return !!this.args['disable-keytar']; } @memoize </del> get crossOriginIsolated(): boolean { return !!this.args['enable-coi']; } @memoize

Discussion:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as
Change:
} } <del> async openAuxIssueReporter(data: IssueReporterData): Promise<void> { </del> <ins> async openAuxIssueReporter(data: IssueReporterData, bounds?: IRectangle): Promise<void> { let issueReporterBounds: Partial<IRectangle> = { width: 700, height: 800 }; // Center Issue Reporter Window based on bounds from native host service if (bounds && bounds.x && bounds.y) { const centerX = bounds.x + bounds.width / 2; const centerY = bounds.y + bounds.height / 2; issueReporterBounds = { ...issueReporterBounds, x: centerX - 350, y: centerY - 400 }; } </ins> const disposables = new DisposableStore(); // Auxiliary Window <del> const auxiliaryWindow = disposables.add(await this.auxiliaryWindowService.open({ mode: AuxiliaryWindowMode.Custom, bounds: { width: 700, height: 800 } })); </del> <ins> const auxiliaryWindow = disposables.add(await this.auxiliaryWindowService.open({ mode: AuxiliaryWindowMode.Custom, bounds: issueReporterBounds })); </ins> if (auxiliaryWindow) { await auxiliaryWindow.whenStylesHaveLoaded;

Discussion:
atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor. in these two examples, i have one large curved secondary monitor where vs code is. open an aux window, and it spawns it in my laptop's screen. same thing if full screened on secondary monitor. different when full screen on main screen (see ) wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.
that should be possible if you provide the coordinates for where to open the window via : You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the . Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
} } <ins> public selectEditor(): void { this._editor.focus(); } </ins> // True is next, false is previous private _focusNav(direction: boolean): void { this._focusedStickyElementIndex = direction ? this._focusedStickyElementIndex + 1 : this._focusedStickyElementIndex - 1;

Discussion:
Testing around an open file in the editor with Stick Scroll enabled. Sticky Scroll Try to move focus out of Sticky Scroll. Tried pressing . Tried running "Focus Sticky Scroll" command a second time. Only way to get focus back to the editor is to select a level and press . I think should put you back into the editor
Change:
const currentType = this.debugService.getViewModel().focusedSession?.configuration.type; const dbg = currentType ? this.debugService.getAdapterManager().getDebugger(currentType) : undefined; <del> const message = dbg?.uiMessages && dbg.uiMessages[DebuggerUiMessage.UnverifiedBreakpoints]; </del> <ins> const message = dbg?.strings?.[DebuggerString.UnverifiedBreakpoints]; </ins> const debuggerHasUnverifiedBps = message && this.debugService.getModel().getBreakpoints().filter(bp => { if (bp.verified || !bp.enabled) { return false;

Discussion:
Continuing This is just a flag in Example: In this case, vscode is in control of when and where to show this message.
Is a good name? Drop the ?
If I see some "messages" related to a debugger, I first think of something like DAP messages. I would only use this property to drive some feature in the UI and it feels good to tie it to that. But if feels awkward I don't have a strong opinion.
Change:
connection.listen(); } <ins> function registerDynamicClientFeature( config: ConfigurationManager, isEnabled: (settings: Settings | undefined) => boolean, register: () => Promise<Disposable>, ) { let registration: Promise<IDisposable> | undefined; function update() { const settings = config.getSettings(); if (isEnabled(settings)) { if (!registration) { registration = register(); } } else { registration?.then(x => x.dispose()); registration = undefined; } } update(); return config.onDidChangeConfiguration(() => update()); } </ins> function registerCompletionsSupport( connection: Connection,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: macOS 12.1 21C52 x86_64 Recently upgraded to 1.73 and no longer seeing selection highlighting. <img width="1728" alt="Screen Shot 2022-11-09 at 8 44 07 AM" src="https://user-"Default setting still and set on the user level as well to no avail. <img width="1728" alt="Screen Shot 2022-11-09 at 8 41 34 AM" src="https://user-"<img width="803" alt="Screen Shot 2022-11-09 at 8 41 56 AM" src="https://user-"
I am only seeing this in Markdown (including code blocks) but not source code.
The problem seems to be that previously you'd get a match if the cursor was at the start of the word but now only if you select/highlight the entire word (or subset). If this is a change in functionality, any way to update settings to restore previous out-of-box behavior?
I believe this might be caused by markdown now registering a document highlight provider. When a language registers a document highlight provider, the non-semantic based, text editor word highlight takes a back seat. I think you can turn this down via , or maybe . Let me loop in , maybe he has more ideas.
Change:
menu: { id: MenuId.EditorContent, when: ContextKeyExpr.and( <del> ContextKeyExpr.regex(ResourceContextKey.Path.key, /.vscode/launch.json$/), </del> <ins> ContextKeyExpr.regex(ResourceContextKey.Path.key, /.vscode[/]launch.json$/), </ins> ActiveEditorContext.isEqualTo(TEXT_FILE_EDITOR_ID)) } });

Discussion:
OS: Win10 Visual Studio Code Version: 1.73.0-insider (user setup) Repro Steps: a .NET core project with the command "". the project in the Visual Studio Code - Insiders. the file. whether there is an "Add Configuration..." button in the file. Actual: There is no "Add Configuration..." button in the file. Suggestion: It would be better to add an "Add Configuration..." button in the file. More Info: This issue doesn't reproduce when open the file in the Visual Studio Code. !
Works fine for me. Are you opening exactly the same folder in both instances? Do you see any errors in the devtools console? (Help Toggle Developer Tools)
This issue still reproduces on my Windows machine, but it doesn't reproduce on Mac. There is no error in the devtools console as below. !
Oh, got it, Windows. Thanks
Change:
"description": "%markdown.preview.linkify%", "scope": "resource" }, <ins> "markdown.preview.typographer": { "type": "boolean", "default": false, "description": "%markdown.preview.typographer%", "scope": "resource" }, </ins> "markdown.preview.fontFamily": { "type": "string", "default": "-apple-system, BlinkMacSystemFont, 'Segoe WPC', 'Segoe UI', system-ui, 'Ubuntu', 'Droid Sans', sans-serif",

Discussion:
Would it be possible to implement support for Typographer mode in the Markdown preview? has support for a typographer option to "enable some language-neutral replacement + quotes beautification". A live comparison is available on . I've listed some of the most common examples below: Name Typographer -- -- Left single quote Left double quote Right single quote Right double quote Ellipsis En-dash Em-dash Copyright Trademark It'd be ideal to add a config setting such that Typographer replacements are done on-the-fly, similarly to the existing implementation of . Thank you for your time.
Change:
assert.strictEqual(localizedManifest.contributes?.authentication?.[0].label, 'Testauthentifizierung'); assert.strictEqual((localizedManifest.contributes?.configuration as IConfiguration).title, 'Testkonfiguration'); }); <ins> test('replaces template strings - is best effort #164630', function () { const manifestWithTypo: IExtensionManifest = { name: 'test', publisher: 'test', version: '1.0.0', engines: { vscode: '*' }, contributes: { authentication: [ { id: 'test.authentication', // This not existing in the bundle shouldn't cause an error. label: '%doesnotexist%', } ], commands: [ { command: 'test.command', title: '%test.command.title%', category: '%test.command.category%' }, ], } }; const localizedManifest = localizeManifest( deepClone(manifestWithTypo), { 'test.command.title': 'Test Command', 'test.command.category': 'Test Category' }); assert.strictEqual(localizedManifest.contributes?.commands?.[0].title, 'Test Command'); assert.strictEqual(localizedManifest.contributes?.commands?.[0].category, 'Test Category'); assert.strictEqual(localizedManifest.contributes?.authentication?.[0].label, '%doesnotexist%'); }); </ins> });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.72.2 (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: for example. Have an entry in for a command but misspell the part: of the other localizations load: ! Issue observed in Python extension: and Jupyter: cc/
Change:
title: localize2('interactive.execute', 'Execute Code'), category: interactiveWindowCategory, keybinding: [{ <ins> // when: NOTEBOOK_CELL_LIST_FOCUSED, when: ContextKeyExpr.equals('activeEditor', 'workbench.editor.interactive'), primary: KeyMod.CtrlCmd | KeyCode.Enter, weight: NOTEBOOK_EDITOR_WIDGET_ACTION_WEIGHT }, { </ins> when: ContextKeyExpr.and( ContextKeyExpr.equals('activeEditor', 'workbench.editor.interactive'), ContextKeyExpr.equals('config.interactiveWindow.executeWithShiftEnter', true)

Discussion:
Testing From gear icon, enable the setting Switch back to the interactive window and see no hint in the input box Reloading the workspace does not help as well <img width="1031" alt="Screenshot 2024-06-25 at 18 49 24" src=""
does shift+enter work as a keybinding?
Yes the keybinding works, issue is only about the hint UI.
the hint text keeps saying "Press Command+Enter to execute" and doesn't update depending on the setting. I was expecting the hint to display "Enter" or "Shift+Enter" depending on the setting.
- can you enable the shift+enter option, run and try to press enter in the input box? Do you get something like this in the troubleshooting logs?
it looks like you may have a custom keyboard layout that changes the key label to . I don't know how many ways there are to modify key labels, so I'll just rely on the order of the keybinding registration to show shift+enter instead of always showing cmd/ctrl+enter. It might still show cmd+enter when in the python REPL experiment with a custom keyboard layout, but I think this is as close as I can reliably get.
verification: with Jupyter and python extensions installed run The execution hint should show in the input box click the gear, change the setting shift+enter setting the hint should update should at least show in the hint with the setting enabled. When disabled, it will either show or
<img width="1381" alt="Screenshot 2024-06-27 at 10 21 16 AM" src=""still occurring - key bindings come in as Resolving meta+[Enter] and Resolving shift+[Enter]
Change:
end; end; <del> if IsNotBackgroundUpdate() and CheckForMutexes('{#TunnelMutex}') then begin MsgBox('{#NameShort} is still running a tunnel. Please stop the tunnel before installing.', mbInformation, MB_OK); Result := false end; </del> end; function WizardNotSilent(): Boolean;

Discussion:
Running can block the VS Code update on Windows as it prevents deleting the parent folder. The updater needs a way to terminate it, and a mutex to know that it needs to be terminated.