jiebi/CodeConvo huggingface dataset:
Change:
} } <ins> impl AsyncPipeListener { pub fn into_pollable(self) -> PollableAsyncListener { PollableAsyncListener { listener: Some(self), write_fut: tokio_util::sync::ReusableBoxFuture::new(make_accept_fut(None)), } } } pub struct PollableAsyncListener { listener: Option<AsyncPipeListener>, write_fut: tokio_util::sync::ReusableBoxFuture< 'static, (AsyncPipeListener, Result<AsyncPipe, CodeError>), >, } async fn make_accept_fut( data: Option<AsyncPipeListener>, ) -> (AsyncPipeListener, Result<AsyncPipe, CodeError>) { match data { Some(mut l) => { let c = l.accept().await; (l, c) } None => unreachable!("this future should not be pollable in this state"), } } impl hyper::server::accept::Accept for PollableAsyncListener { type Conn = AsyncPipe; type Error = CodeError; fn poll_accept( mut self: Pin<&mut Self>, cx: &mut Context<'_>, ) -> Poll<Option<Result<Self::Conn, Self::Error>>> { if let Some(l) = self.listener.take() { self.write_fut.set(make_accept_fut(Some(l))) } match self.write_fut.poll(cx) { Poll::Ready((l, cnx)) => { self.listener = Some(l); Poll::Ready(Some(cnx)) } Poll::Pending => Poll::Pending, } } } </ins> /// Gets a random name for a pipe/socket on the paltform pub fn get_socket_name() -> PathBuf { cfg_if::cfg_if! {

Discussion:
It doesn't look like this new CLI supports serving on a UNIX domain socket. Could we please get that in too, like in We're going to need it in order to handle auth in a proxy. (I'm happy to open a new issue for that if you need) Originally posted by in
Nice, thanks!
I can do this what now?
Also is it an issue that the socket file wasn't release/deleted after a ctrl+C? or do I clean that up manually?
We should probably automatically delete the file if it exists You can do a to make sure it's actually working . Without extra stuff you won't be able to open it in the browser, but verifying the connection should be enough.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { compareBy, numberComparator, tieBreakComparators } from 'vs/base/common/arrays'; </del> <ins> import { compareBy, equals, numberComparator, tieBreakComparators } from 'vs/base/common/arrays'; </ins> import { BugIndicatingError } from 'vs/base/common/errors'; import { splitLines } from 'vs/base/common/strings'; import { Constants } from 'vs/base/common/uint';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: WindowsNT x64 10.0. Steps to Reproduce: a struct with some fields and functions in one branch the same struct in another branch, with a minor difference in one of the fields. the branches and open the merge editor. Accept Combination. On this example, is on the left side and on the right side. I'd expect "Accept Combination" to have only a single copy for the matching lines, and duplicate only the different line (and then I'd choose which one to keep), but it duplicates the entire struct. !
I also see that deleted/deleted is considered a conflict. I see no reason why. !
I also had duplicated code on two occasions when rebasing after the new VSCode update (and that's why I searched for this issue here). It seems that it kept the old code and the new code and didn't complain or considered a change/conflict. I still haven't used , so this duplication happened without using this new feature. In both situations, I had to manually remove the old code. If I find this situation again I will add here its screenshots.
Thanks,
Thank you!
Verification steps: Use the command to open that JSON and notice that conflicts with equal changes on both sides are auto-resolved.
Change:
} return text.substring(i+1, position.character); } <ins> private isLast(document: TextDocument, position: Position):boolean { let scanner = createScanner(document.getText(), true); scanner.setPosition(document.offsetAt(position)); let nextToken = scanner.scan(); if (nextToken === SyntaxKind.StringLiteral && scanner.getTokenError() === ScanError.UnexpectedEndOfString) { nextToken= scanner.scan(); } return nextToken === SyntaxKind.CloseBraceToken || nextToken === SyntaxKind.EOF; } </ins> }  No newline at end of file

Discussion:
VSCode Version: 1.1.0-alpha OS Version: Mac Steps to Reproduce: Regarding test plan Just found this very small bug (not an urgent one—ok to delay if necessary). just a package name in with no leading quotation mark (so it autocompletes the quotes for you) try adding a package with a leading quotation mark. Note that in the first case a comma is not , but in the second case a comma is . Not a huge deal, but consistency would be nice. Preferably, if it knows that it's on the last line of properties (i.e. the next line is a closing brace), then it would not insert a comma. But if it's in the middle of the list (i.e. the next line is another property in the JSON), then it would add a comma.
I always get a comma: Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Let me know if you saw another issue.
yes, that's what I was seeing. Thanks for checking!
Change:
}, [TaskSettingId.ShowDecorations]: { type: 'boolean', <del> description: nls.localize('task.showDecorations', "Shows decorations at points of interest in the terminal buffer such as the first problem found via a watch task. Note that this will only take effect for future tasks."), </del> <ins> markdownDescription: nls.localize('task.showDecorations', "Shows decorations at points of interest in the terminal buffer such as the first problem found via a watch task. Note that this will only take effect for future tasks. {0} will take precedence over this setting", '`#terminal.integrated.shellIntegration.decorationsEnabled#`'), </ins> default: true }, [TaskSettingId.Reconnection]: {

Discussion:
Version: 1.70.0-insider (Universal) Commit: Date: 2022-07-29T10:50:40.282Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Darwin arm64 20.6.0 Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: Task decoration not enabled when and a task decorations are not shown. ! When ! Ref:
and I discussed it and we will update the setting description to indicate that it will respect .
Change:
quickpick.canSelectMany = false; quickpick.toggles = this.options.toggles; quickpick.toggles?.forEach(toggle => { <del> toggle.onChange(() => this.options.onToggle?.(toggle, quickpick), undefined, disposables); </del> <ins> disposables.add(toggle.onChange(() => this.options.onToggle?.(toggle, quickpick))); </ins> }); quickpick.matchOnDescription = true; <del> quickpick.onDidAccept(async _ => { </del> <ins> disposables.add(quickpick.onDidAccept(async _ => { </ins> isCompleted = true; const theme = quickpick.selectedItems[0]; if (!theme || theme.configureItem) { // 'pick in marketplace' entry

Discussion:
Quick pickers are itself disposables, as well as the events they provide. Noticed a few leaks around picker instances and/or events: //cc
There's already a that is called when the picker hides. Isn't that good enough?
see the various events (those beginning with ) and how they are not getting disposed.
But they are going to an emitter that is owned by the quickpick. Disposing the quickpick is also disposed all its emitters. There's no real leak here.
my understanding is that an that gets disposed (when you dispose the quick picker) does not dispose the -functions it had returned, i.e. this code is not running: But maybe or can also chime in.
Yes - an emitter doesn't dispose its listeners. you basically rely on GC'ing here and I am uncertain if that actually works (e.g some disposables are tracked centrally for later blaming). I understand your motives but we generally dispose all the things
Change:
} } <del> private _restoreState(): void { const serialized = this._storageService.get(NotebookKernelHistoryService.STORAGE_KEY, StorageScope.WORKSPACE); if (serialized) { try { for (const [viewType, kernels] of JSON.parse(serialized)) { const linkedMap = this._mostRecentKernelsMap[viewType] ?? new LinkedMap<string, string>(); for (const entry of kernels.entries) { linkedMap.set(entry, entry, Touch.AsOld); } this._mostRecentKernelsMap[viewType] = linkedMap; } } catch (e) { console.error('Deserialize notebook kernel history failed', e); } } } </del> private _loadState(): void { const serialized = this._storageService.get(NotebookKernelHistoryService.STORAGE_KEY, StorageScope.WORKSPACE); if (serialized) {

Discussion:
Going through the error logs showed the error below . No steps but it is rooted at this line
verification - Perform a few actions in a notebook, add cells, run cells, close/reopen the tab, run more cells Open the dev tools and ensure the error is not in the console
Change:
private updateTextFromSelection({ allowUnselectedWord = true, allowSearchOnType = true }, editor?: IEditor): boolean { const seedSearchStringFromSelection = this.configurationService.getValue<IEditorOptions>('editor').find!.seedSearchStringFromSelection; <del> if (!seedSearchStringFromSelection) { </del> <ins> if (!seedSearchStringFromSelection || seedSearchStringFromSelection === 'never') { </ins> return false; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.1 (Universal) OS Version: MacOS 11.5.2 Steps to Reproduce: any text in an open text document the search panel using (cmd+shift+f) search field is now erroneously updated. This is a recent regression, though not sure exactly when.
Please, fix this since it is really annoying behavior
closing in favor of
This is not the same as Steps to repro this: : a search near a word in the editor. editor will use the selection to seed the search :bug:
What's the best way to verify this? I tried to repro with VS Code stable, and I couldn't. The setting seems to be about the find widget not the search view, which I'm also confused about. My steps: the setting a text document and select a word +shift+f to open the search view view is never populated with the currently selected word from step 2, no matter what the value of the setting is.
This version should include the fix in I can reproduce the issue with: to a text file and selecting a text (shift+left/right arrow key in my case) Next Selection ( key) the cursor to any other different word in the text without selecting it Next Selection ( key) At this point the other different word is searched instead of the one that was searched in step 3 Reproducible also if is set to in step 1
I believe that this is a different bug. Can you file a new issue for this?

This issue seems to concern workspace search (++)
The verification steps shoud be as follows: a workspace search with an arbitrary string in settings. some text in your editor that is different from the string that you searched. for workspace search. that the text in the search input does not update using the selection.
Change:
JSON.parse(decodeURIComponent("${encodeURIComponent(JSON.stringify(ctx))}")) )n//# sourceURL=notebookWebviewPreloads.jsn`; } <del> export function isEditableElement(element: Element): boolean { return element.tagName.toLowerCase() === 'input' || element.tagName.toLowerCase() === 'textarea' || 'editContext' in element; } </del>

Discussion:
today's insiders open GHINB and run a cell see errors (many) on the console
broke
We should also add a custom eslint rule for this. It has been broken for a few weeks and it regresses the output focus context keys.
Change:
const currentSettings = this.get(language); const newSettings = f(currentSettings); this._languageSettings.set(language, newSettings); <del> return areLanguageDiagnosticSettingsEqual(currentSettings, newSettings); </del> <ins> return !areLanguageDiagnosticSettingsEqual(currentSettings, newSettings); </ins> } }

Discussion:
Issue Type: Performance Issue <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.56.2 OS Version: Darwin x64 20.3.0 Steps to Reproduce: task in vscode repo. some TypeScript/JavaScript wrong code. ! () any settings, always called. ! only typescript/javascript file can reproduce this issue.
Change:
// Don't create the instance if the workspace picker was canceled return; } <del> instance = terminalService.createTerminal( { cwd: workspace.uri } ); </del> <ins> eventOrOptions.cwd = workspace.uri; instance = terminalService.createTerminal(eventOrOptions); </ins> } terminalService.setActiveInstance(instance); }

Discussion:
The terminal commands and are used for both the panel buttons and the commands in the CP (that we do want to use the defaultLocation for). Not sure how to differentiate between them - don't think we want to duplicate the actions. let me know what you think
Let's wait until after is done since that will likely add target support to the create commands
Other reproes: Ctrl / Cmd J to open the panel - terminal editor is created focus the terminal editor, click the trash can on the panel , close the editor tab - a bunch of errors in the console
Change:
if (eolReleases.has(majorVersion)) { const message = localize('macoseolmessage', "{0} on {1} will soon stop receiving updates. Consider upgrading your macOS version.", this.productService.nameLong, eolReleases.get(majorVersion)); <del> const actions = [{ label: localize('macoseolBannerLearnMore', "Learn More"), href: 'https://aka.ms/vscode-faq-old-macOS' }]; this.bannerService.show({ id: 'macoseol.banner', message, ariaLabel: localize('macoseolarialabel', "{0}. Use navigation keys to access banner actions.", message), actions, icon: Codicon.warning }); </del> this.notificationService.prompt( Severity.Warning,

Discussion:
I keep pressing the X on this message and it still keeps coming back. Every single time I open a window. I have told it to go away almost 50 times now. I am being driven towards insanity. <img width="826" alt="image" src=""May this bug report stand in evidence that I have gotten the message. Thank you. Version: 1.83.0 (Universal) Commit: Date: 2023-10-03T16:13:15.449Z (3 days ago) Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 18.7.0
Will just remove the banner.
should we mark this as author verification required? I'm assuming those testing internally would have updated their MacOS
how do I remove the banner in windows 8?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
is the issue fixed for you on the latest ?
Feel free to mark as verified via code review.
Change:
return logger; }; <ins> test('Validate sender instances', function () { assert.throws(() => ExtHostTelemetryLogger.validateSender(<any>null)); assert.throws(() => ExtHostTelemetryLogger.validateSender(<any>1)); assert.throws(() => ExtHostTelemetryLogger.validateSender(<any>{})); assert.throws(() => { ExtHostTelemetryLogger.validateSender(<any>{ sendErrorData: () => { }, sendEventData: true }); }); assert.throws(() => { ExtHostTelemetryLogger.validateSender(<any>{ sendErrorData: 123, sendEventData: () => { }, }); }); assert.throws(() => { ExtHostTelemetryLogger.validateSender(<any>{ sendErrorData: () => { }, sendEventData: () => { }, flush: true }); }); }); </ins> test('Ensure logger gets proper telemetry level during initialization', function () { const extensionTelemetry = createExtHostTelemetry(); let config = extensionTelemetry.getTelemetryDetails();

Discussion:
This looks like we have telemetry loggers without appenders. Can we add a strict check or in the API impl?
Change:
quickPick.buttons = [this._quickInputService.backButton]; quickPick.show(); <del> const quickPickItems: QuickPickInput<KernelQuickPickItem>[] = []; </del> disposables.add(quickPick.onDidTriggerButton(button => { if (button === this._quickInputService.backButton) { quickPick.hide();

Discussion:
When we only have a couple of notebook controllers created for a notebook type, without any kernel detection task or kernel source commands, the "Select Another Kernel" should not show.
I have no kernels in the MRU, clicking Select Kernel brings me to this quickpick, and clicking the back button here does nothing--I think it shouldn't be shown in this scenario ! I have the Jupyter extension installed but not the Python extension installed, with the MRU picker enabled, the Select Kernel dropdown spins forever like this: !
Change:
/** * Go to the address provided. If no address is provided, reveal the address of the currently focused stack frame. */ <del> goToAddress(address?: string): void { </del> <ins> goToAddress(address?: string, focus?: boolean): void { </ins> if (!this._disassembledInstructions) { return; }

Discussion:
Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints
Will fix this.
Change:
override async run(accessor: ServicesAccessor, resourceOrContext?: URI | IEditorCommandsContext, context?: IEditorCommandsContext): Promise<void> { const editorGroupsService = accessor.get(IEditorGroupsService); const { group } = resolveCommandsContext(editorGroupsService, getCommandsContext(resourceOrContext, context)); editorGroupsService.toggleMaximizeGroup(group); }

Discussion:
Type: <bBug</bPer this is a new issue related to issue . Currently in insiders, the tab with focus will be the one moved or copied into new window via context menu, even when I right-click on a different tab. I can understand the user NOT wanting right-click of non-focused tab to give it focus, but intuitively, it seems you'd want the context menu to act on the tab you right-clicked, regardless if the tab is the one with focus or not. VS Code version: Code - Insiders 1.85.0-insider (, 2023-12-01T14:17:40.644Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ remote-containers0.326.0 remote-ssh0.107.1 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.25.0 remote-explorer0.4.1 remote-server1.5.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
<key>separator</key> <dict> <key>match</key> <del> <string>(^|G)[ ]{0,3}([-*_])([ ]{0,2}2){2,}[ t]*$n?</string> </del> <ins> <string>(^|G)[ ]{0,3}([*-_])([ ]{0,2}2){2,}[ t]*$n?</string> </ins> <key>name</key> <string>meta.separator.markdown</string> </dict>

Discussion:
! H1 and H2 are not highlighted. The preview is fine. Tested on VS Code 1.3.1 on OS X 10.11.6
I wanna give this one a try. Here is what I have achieved so far. !
Couple of updates on this: to highlight both lines at the same time, the way I was trying above doesn't look practical. It automatically highlights the current line assuming a match of the begin, until it finds a non matching end/while (Basically the line highlights, and if the next line isn't a '-{3,}' then the syntax goes back to normal mode. alt heading 2 syntax (just the -{3,} part) is conflicting with the rule meta.separator.markdown, which takes precedence and hence the issue. Would it be a better option to fix this conflict instead?
It doesn't work with 1.9.0 !
I believe this is as designed. Getting the TM grammar to highlight both the lines is tricky. If you refer to my previous comment, the first point: This would be confusing for the user. In simple terms, it means that as soon as a user starts typing, the line highlights, and goes back to normal syntax if the next line is neither of the alternate H1/H2 (---/===) text. What do you think?
Is it possible to let the line white and if a line starts with --- oder ===, then this one and the previous one switch to blue? That is the same behavior like in other editors.
Change:
})); documents.listen(connection); <del> notebooks.listen(connection); </del> <ins> notebooks?.listen(connection); </ins> connection.listen(); } function registerCompletionsSupport( connection: Connection, <del> documents: TextDocuments<TextDocument>, </del> <ins> documents: TextDocuments<md.ITextDocument>, </ins> ls: md.IMdLanguageService, config: ConfigurationManager, ): IDisposable {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was testing the server on neovim. I noticed the requires a lot from the client. Would it be possible to bundle default implementations of and all other custom requests to make the server self-contained?
I'd take a PR that does this (likely using service injection) but the current design is deliberate lets the client bring their own parser versionThe custom file messages means the server is not restricted to working with local files. Ideally the LSP would also include this functionality but right now it does not
I can make a PR. Wouldn't it be simpler to add a setting for a custom tokenizer? Then call with or make a request?
makes this easier to use the server as a library. For a client that doesn't want to implement the custom messages we use, you'd instead want to use the new version of which lets you pass in your own parser and workspace implementations