jiebi/CodeConvo huggingface dataset:
Change:
], "main": "./out/extension.js", "browser": "./dist/extension.js", <del> "activationEvents": [], </del> <ins> "activationEvents": [ "onLanguage:search-result" ], </ins> "scripts": { "generate-grammar": "node ./syntaxes/generateTMLanguage.js", "vscode:prepublish": "node ../../node_modules/gulp/bin/gulp.js --gulpfile ../../build/gulpfile.extensions.js compile-extension:search-result ./tsconfig.json"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.78.0-insider (system setup) OS Version: Windows 10 This only happen to the latest version of insider (1.78), the current vscode is still working Steps to Reproduce: a keyword open in editor shown in editor but now unable to ctrl click "Follow link" to go to the file or the line of code
is this a regression in link detection? I also notice that I can't ctrl+click on imports in the newest insiders.
double clicking to go to the file also stopped working
I ran and it points to this commit range:
points to I think the no longer activates when opening the search editor because the extension doesn't contribute a language configuration. Do you have any suggestions about what to do here. When I try to add the activation event back to the , I get a squiggle that it isn't necessary and that I should remove it. <img width="346" alt="image" src="https://user-"
I do not see this in the latest insiders, do you still repro? I updated the extension linter to not emit a warning in (the same commit which changes the implicit activation behavior): <img width="403" alt="image" src="https://user-"
Is there any fix for this available? I rely heavily on being able to press to jump to definitions in Search Editor. Don't want to downgrade from insiders but seems I am forced to.
Change:
// from all registered (not active) context menu actions select those // that are a symbol navigation actions const filter = new Set(MenuRegistry.getMenuItems(MenuId.EditorContext) <del> .map(item => isIMenuItem(item) ? item.command.id : '')); </del> <ins> .map(item => isIMenuItem(item) ? item.command.id : generateUuid())); </ins> for (const delegate of SymbolNavigationAction.all()) { if (filter.has(delegate.desc.id)) { menuActions.push(new Action(delegate.desc.id, MenuItemAction.label(delegate.desc, { renderShortTitle: true }), undefined, true, async () => { const ref = await resolverService.createModelReference(location.uri); try { <del> await instaService.invokeFunction(delegate.run.bind(delegate), editor, new SymbolNavigationAnchor(ref.object.textEditorModel, Range.getStartPosition(location.range))); </del> <ins> const symbolAnchor = new SymbolNavigationAnchor(ref.object.textEditorModel, Range.getStartPosition(location.range)); const range = part.item.anchor.range; await instaService.invokeFunction(delegate.runEditorCommand.bind(delegate), editor, symbolAnchor, range); </ins> } finally { ref.dispose();

Discussion:
I'm trying to navigate to here from an Inlay Hint, but nothing happens when I click the "Go to Definition" option: ! The LSP traffic for this hint looks like this: The looks correct to me (Code is zero-based, so it says 1195 here but the line is 1196 in the editor): <img width="743" alt="Screenshot 2023-02-21 at 11 16 08" src="https://user-"The text for says: But it's not very clear to me what this means. The location provide here definitely has a symbol defined at the location, which can be navigated to from the breadcrumb/symbol list: <img width="778" alt="Screenshot 2023-02-21 at 11 21 55" src="https://user-"
So, when invoking go to definition at you get the desired result?
I believe so. The request returns the same symbol, so VS code then falls back to request and shows references (I believe there's a setting for this, and it's intended functionality, so you can just use F12 on a declaration to get references easily?).
Please try with column and not with
Sorry, not sure how I did that. But the result appears to be exactly the same:
Oh, I just did some more testing and it seems like the request VS Code is sending is using the current cursor position and not where I clicked? !
I can reproduce, funnily only from the context menu but not from the link gesture.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Works great now, thanks ! /verified
Change:
} const resultsSelectedBackground = theme.getColor(peekViewResultsSelectionBackground); if (resultsSelectedBackground) { <del> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-tree.focused .monaco-tree-rows > .monaco-tree-row.selected:not(.highlighted) { background-color: ${resultsSelectedBackground}; }`); </del> <ins> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-list:focus .monaco-list-rows > .monaco-list-row.selected:not(.highlighted) { background-color: ${resultsSelectedBackground}; }`); </ins> } const resultsSelectedForeground = theme.getColor(peekViewResultsSelectionForeground); if (resultsSelectedForeground) { <del> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-tree.focused .monaco-tree-rows > .monaco-tree-row.selected:not(.highlighted) { color: ${resultsSelectedForeground} !important; }`); </del> <ins> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-list:focus .monaco-list-rows > .monaco-list-row.selected:not(.highlighted) { color: ${resultsSelectedForeground} !important; }`); </ins> } const editorBackground = theme.getColor(peekViewEditorBackground); if (editorBackground) {

Discussion:
Set color customizations for the peek widget: 29: ! 30: ! Candidate or 1.30.1 maybe?
Grrr, another regression... I am for putting this into 1.30.1
I have pushed a fix to master and I have created we think having for for is good enough, otherwise the PR can be merged for
Change:
import { IDragAndDropData } from 'vs/base/browser/dnd'; import { ElementsDragAndDropData } from 'vs/base/browser/ui/list/listView'; import { isPromiseCanceledError, onUnexpectedError } from 'vs/base/common/errors'; <del> import { toggleClass } from 'vs/base/browser/dom'; </del> <ins> import { removeClasses, addClasses } from 'vs/base/browser/dom'; </ins> import { values } from 'vs/base/common/map'; import { ScrollEvent } from 'vs/base/common/scrollable'; import { ICompressedTreeNode, ICompressedTreeElement } from 'vs/base/browser/ui/tree/compressedObjectTreeModel'; import { IThemable } from 'vs/base/common/styler'; import { isFilterResult, getVisibleState } from 'vs/base/browser/ui/tree/indexTreeModel'; <ins> import { treeItemLoadingIcon } from 'vs/base/browser/ui/tree/treeIcons'; </ins> interface IAsyncDataTreeNode<TInput, T> { element: TInput | T;

Discussion:
Issue Type: <bBug</bIn latest Insiders build instead of loading icon I see spinning chevron for some tree nodes. It's mostly noticeable in GitHub Pull Request extension tree, however I was able to reproduce it in Call Hierarchy while expanding some nested trees. Looks like has lower priority than which prevents icon change. /cc VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T08:44:55.510Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Change:
import { AccessibilityProgressSignalScheduler } from 'vs/platform/accessibilitySignal/browser/progressAccessibilitySignalScheduler'; import { IChatAccessibilityService } from 'vs/workbench/contrib/chat/browser/chat'; import { IChatResponseViewModel } from 'vs/workbench/contrib/chat/common/chatViewModel'; <ins> import { renderStringAsPlaintext } from 'vs/base/browser/markdownRenderer'; </ins> const CHAT_RESPONSE_PENDING_ALLOWANCE_MS = 4000; export class ChatAccessibilityService extends Disposable implements IChatAccessibilityService {

Discussion:
Have a response that contains references to code, e.g. : ! Start screen reader and click on the response. Notice how the full URLs are being read out aloud which are very long. Verbatim text: I think this stems from the fact that we just take the response as string here:
Btw I have a similar challenge for the text-to-speech integration where I am thinking about converting the markdown string to a plain text string using : But I did notice that this would remove some text, such as ordered list.
made a good point in our standup today: why are we not leveraging the HTML screen reader support for chat items but use ?
The HTML screen reader support requires users to enter different modes to navigate - browse/focus mode. Feedback from screen reader users suggested this is not user friendly. Users will examine content in detail in the chat accessible view, not here. Providing an overview of the response with aria alert is desired. This is similar to how sighted users see the response streaming in. Screen reader users press escape if they don't wish to hear the content.
I agree it's not good that it's reading the full URLs. A similar problem is here and my solution to that will be to remove those links and provide an alternate way of setting any keybindings which are undefined.
Potential verification found: I asked for the location of some code, and after Copilot finished typing out the response, it announced the entire response, including all the link text and full command IDs.
LGTM now. I might've forgotten to update something.
A screenshot of the text that was announced would help to know if this was fixed or not
nvm. The symbols are good but the URLs still expand !
unclear how this could be happening as I'm using
figured it out
It is still reading the complete path for me.
and the complete path is expected. what's not expected is these chars
going to see if I can repro on windows
does not reproduce for me on windows either . It makes no sense that this would happen - , we literally parse that stuff out. could you pls debug in oss here? !
I believe the issue is fixed now. I notice that when the announcement is read out that the links are now announced correctly. When I click on the response, the links are read with the Markdown formatting again, but I believe that this behaviour is out of scope of the issue.
Change:
if (useWslProfiles) { const distroOutput = await new Promise<string>((resolve, reject) => { // wsl.exe output is encoded in utf16le (ie. A -> 0x4100) <del> cp.exec('wsl.exe -l', { encoding: 'utf16le' }, (err, stdout) => { </del> <ins> cp.exec('wsl.exe -l -q', { encoding: 'utf16le' }, (err, stdout) => { </ins> if (err) { return reject('Problem occurred when getting wsl distros'); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.0 OS Version: Windows 10 Home 20H2 .867 Steps to Reproduce: run latest version of VS Code, 1.55.0 the list of default WSL profiles and you will find something like "Ubuntu (predet.)" instead of just "Ubuntu". profile is impossible to launch, because there is NO distro named "Ubuntu (predet.)". This happens because , at line 178 of latest snapshot I'm checking, does this: . It should remove other locales, too. I know this is difficult to do because... well, there's plenty of locales. So, in order to get the distribution name, another way should be used. I think it's safe to remove any last element within parentheses from the distro name as returned by , but really another method is available which I think it's safer, but I'm not sure how to write it in TypeScript. I have the following code already written in Python, for a system maintenance script I use in my own system, where I retrieve the installed distribution names from the registry: It's a partial code but well, I think it's self explanatory, and I can provide further information if needed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Same happens to me with the new version 1.55.0 One temporal solution that I found is to disable the autodetection of the distros and include each one with the profile setting:
hi, at first glance it looks that adding a -q argument to the 'wsl -l' command would be safe... regards
Thanks for the suggestion and the fix.

Still, I'll keep an eye on this, just in case Microsoft decides to change command line interface. But so far, so good, and it's simpler than having to read the registry
Just encountered this issue today (after updating Docker for Desktop, but not sure if this has something to do with the issue).
Verified in
Change:
display: flex; padding: 4px; align-items: center; <ins> width: 220px; max-width: calc(100% - 28px - 28px - 8px); </ins> -webkit-transition: top 200ms linear; -o-transition: top 200ms linear;

Discussion:
Testing Steps to Reproduce: integrated terminal and open the find widget the integrated terminal area very skinny bug The find widget starts overflowing into the explorer area: <img width="420" alt="screen shot 2017-06-28 at 1 25 51 pm" src="https://user-"
After , no more overflow but we now clip the find box: !
I guess we want it to be tiny like in the editor: <img width="221" alt="screen shot 2017-07-07 at 3 02 45 pm" src="https://user-"
Change:
} }); compositesToRemove.reverse().forEach(index => { <del> const actionViewItem = compositeSwitcherBar.viewItems[index]; </del> compositeSwitcherBar.pull(index); <del> actionViewItem.dispose(); </del> this.visibleComposites.splice(index, 1); });

Discussion:
Explorer focused: ! It's only working for debug: !
It seems to working for me <img width="370" alt="image" src=""Do you have any special theme, or customisations or set up? Probably try trouble shooting?
Also the state can be frozen: ! ! Same thing in dark modern. No errors in console
Here's a repro that seems reliable: the side bar narrow enough to make some of your activity icons get displaced into the ... menu. an option from that menu. Its icon appears and get selected with the underline correct. drag that icon left to position it nearer the start of the set of tabs in order for it not to get displaced onto the ... menu again. It loses its underline and even when you switch to another icon and back to this one it doesn't get underlined.
To reset, move activity bar to side, then back to top again.
Thanks for repro steps
OFF TOPIC. May I ask how to move the activity bar from left to top? Tried searching for settings and Googling, but didn't get any results.
if you're on the Insiders build you can right click the activity bar to change the position
To verify: Move activity bar to top Reduce the width of sidebar so that activity bar actions are exactly fit Switch to Debug view container. All activity bar actions moved to overflow action From overflow action, select explorer Make sure explorer is shown active
Change:
this.loadDisassembledInstructions(targetAddress, -DisassemblyView.NUM_INSTRUCTIONS_TO_LOAD, DisassemblyView.NUM_INSTRUCTIONS_TO_LOAD * 2).then(() => { // on load, set the target instruction in the middle of the page. if (this._disassembledInstructions!.length > 0) { <del> this._disassembledInstructions!.reveal(Math.floor(this._disassembledInstructions!.length / 2), 0.5); </del> <ins> const targetIndex = Math.floor(this._disassembledInstructions!.length / 2); this._disassembledInstructions!.reveal(targetIndex, 0.5); // Always focus the target address on reload, or arrow key navigation would look terrible this._disassembledInstructions!.domFocus(); this._disassembledInstructions!.setFocus([targetIndex]); </ins> } }); }

Discussion:
Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints
Will fix this.
Change:
{ urlFormat: '{0} [{1}, {2}]', line: '5', column: '3' }, { urlFormat: '{0}: [{1}, {2}]', line: '5', column: '3' }, { urlFormat: '{0}",{1}', line: '5' }, <del> { urlFormat: '{0}',{1}', line: '5' } </del> <ins> { urlFormat: '{0}',{1}', line: '5' }, { urlFormat: '{0}#{1}', line: '5' }, { urlFormat: '{0}#{1}:{2}', line: '5', column: '5' } </ins> ]; const windowsFallbackLinks: (string | { link: string; resource: URI })[] = [

Discussion:
In terminal, ctrl+click at , will open the file without problems, but using an anchor , gives the following error: !
This is actually a request for to indicate line number which we haven't had requested before. Right now it's considered to be part of the file name.
Change:
import 'vs/workbench/contrib/terminalContrib/chat/browser/terminalChatActions'; import { AccessibleViewRegistry } from 'vs/platform/accessibility/browser/accessibleViewRegistry'; import { TerminalChatAccessibilityHelp } from 'vs/workbench/contrib/terminalContrib/chat/browser/terminalChatAccessibilityHelp'; <ins> import { registerWorkbenchContribution2, WorkbenchPhase } from 'vs/workbench/common/contributions'; import { TerminalChatEnabler } from 'vs/workbench/contrib/terminalContrib/chat/browser/terminalChatEnabler'; </ins> // #endregion

Discussion:
The context key used in terminal and notebook chat which is wrong because it signals that there is a chat participant for the editor location and it doesn't know anything about other locations.
It's now removed from the notebook side.
Change:
} else { icon = Codicon.lightbulbAutofix; } <del> updateAutoFixLightbulbTitle(); </del> } else if (this.state.actions.hasAIFix) { icon = Codicon.lightbulbSparkle; <del> updateLightbulbTitle(); </del> } else { icon = Codicon.lightBulb; <del> updateLightbulbTitle(); </del> } } else { if (this.state.actions.hasAutoFix) { icon = Codicon.lightbulbAutofix; <del> updateAutoFixLightbulbTitle(); </del> } else { icon = Codicon.lightBulb; <del> updateLightbulbTitle(); </del> } } <ins> this._updateLightbulbTitle(this.state.actions.hasAutoFix, autoRun); </ins> this._iconClasses = ThemeIcon.asClassNameArray(icon); this._domNode.classList.add(...this._iconClasses); } <ins> private _updateLightbulbTitle(autoFix: boolean, autoRun: boolean): void { if (this.state.type !== LightBulbState.Type.Showing) { return; } if (autoRun) { this.title = nls.localize('codeActionAutoRun', "Run: {0}", this.state.actions.validActions[0].action.title); } else if (autoFix && this._preferredKbLabel) { this.title = nls.localize('preferredcodeActionWithKb', "Show Code Actions. Preferred Quick Fix Available ({0})", this._preferredKbLabel); } else if (!autoFix && this._quickFixKbLabel) { this.title = nls.localize('codeActionWithKb', "Show Code Actions ({0})", this._quickFixKbLabel); } else if (!autoFix) { this.title = nls.localize('codeAction', "Show Code Actions"); } } </ins> private set title(value: string) { this._domNode.title = value; }

Discussion:
Testing For this line, presumably there is only one AI action available. ! But I have no idea what that action is... and what will be executed when I open inline chat. It opens with : ! I think this should be more clear that this will happen as it's a bit jarring. Also will help here I think
Yes that's a very good point, if an action is auto-ran I will put the action title in the hover message. I am just wondering how that would work with localization since the hover message would be dynamic and would depend on the command inside of the menu? I guess I'll just write the following code in the localized string and prepend the action title with 'run':
We probably should turn off autorun when inline chat was invoked by clicking on the sparkle.
Is there a way to override the autorun from the code action?
I am working on changing the arguments if the command ID is . I will create a new args object but set autoSend to false, the other properties will be the same
So I have one PR to show the action title in the sparkle hover: And one PR which disables autoSend when invoking :
Change:
}; updateActions(); this._register(menu.onDidChange(updateActions)); <ins> this._register(secondaryMenu.onDidChange(updateActions)); </ins> this._register(this.notebookEditor.notebookOptions.onDidChangeOptions(updateActions)); }

Discussion:
Open a notebook Sometimes the focused cell doesn't have the dropdown chevron with the "Debug Cell" action Or, after debugging or using RBL, sometimes this button doesn't come back pointed this out and I can repro it
Change:
async performReplace(element: FolderMatch | FileMatch | Match): Promise<any> { // since multiple elements can be selected, we need to check the type of the FolderMatch/FileMatch/Match before we perform the replace. <del> const elementsToReplace = getElementsToOperateOnInfo(this.viewer, element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); </del> <ins> const opInfo = getElementsToOperateOnInfo(this.viewer, element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); const elementsToReplace = opInfo.elements; </ins> await Promise.all(elementsToReplace.map(async (elem) => { const parent = elem.parent();

Discussion:
The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in
Change:
} .scm-view .monaco-list-row.focused .separator-container .label-name, <del> .scm-view .monaco-list-row.selected .separator-container .label-name { </del> <ins> .scm-view .monaco-list-row.selected .separator-container .label-name, .scm-view .monaco-list-row.focused .separator-container .action-label::before, .scm-view .monaco-list-row.selected .separator-container .action-label::before { </ins> color: var(--vscode-foreground); }

Discussion:
Steps to Reproduce: VS Code Insiders the Light (Visual Studio) theme the "Source Control" viewlet on the Incoming/Outgoing separator (actions are white) !
Change:
return result ? new ApiRepository(result) : null; } <del> async init(root: Uri): Promise<Repository | null> { </del> <ins> async init(root: Uri, options?: InitOptions): Promise<Repository | null> { </ins> const path = root.fsPath; <del> await this._model.git.init(path); </del> <ins> await this._model.git.init(path, options); </ins> await this._model.openRepository(path); return this.getRepository(root) || null; }

Discussion:
I would have expected that the command creates a repository with a branch 'main'. I was using the latest insider: This is the repository created using 'Publish to Github'
Related to
In this particular scenario we should honor the default branch setting on GitHub rather than the VS Code setting.
Change:
const snippet = new vscode.SnippetString(); for (let i = 0; i < uriList.entries.length; i++) { const uri = uriList.entries[i]; <del> const relativePath = getRelativePath(uri.uri); </del> <ins> const relativePath = getRelativePath(getDocumentDir(docUri), uri.uri); </ins> const urlText = relativePath ?? uri.str; snippet.appendText(`url(${urlText})`);

Discussion:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch