jiebi/CodeConvo huggingface dataset:
Change:
"command.stash": "Stash", "command.stashPop": "Pop Stash...", "command.stashPopLatest": "Pop Latest Stash", <ins> "command.stashApply": "Apply Stash...", "command.stashApplyLatest": "Apply Latest Stash", </ins> "config.enabled": "Whether git is enabled", "config.path": "Path to the git executable", "config.autoRepositoryDetection": "Configures when repositories should be automatically detected.",

Discussion:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!
Change:
$(this.container).addClass(newTheme.id); } this.currentColorTheme = newTheme; <del> this.themingParticipantChangeListener = themingRegistry.onThemingParticipantAdded(p => this.updateDynamicCSSRules(this.currentColorTheme)); </del> <ins> if (!this.themingParticipantChangeListener) { this.themingParticipantChangeListener = themingRegistry.onThemingParticipantAdded(p => this.updateDynamicCSSRules(this.currentColorTheme)); } </ins> this.sendTelemetry(newTheme.id, newTheme.extensionData, 'color');

Discussion:
<!-- Do you have a question? Please ask it on --I am building a component that is lazily loaded (and therefore lazily calls ). The callback passed in to registerThemingParticipant is never getting called though and it seems like this is because disposes any previous and does not add it back for some code paths. It looks like assumes that will add back the listener , but there are multiple code paths in that neither call nor add back the listener. The specific case I am hitting is When this case is hit, the listener is never re-registered, so subsequent calls to will have no effect.
I do not see this is an extension API.. are there any steps to verify this?
No, its just in code, no need to verify
Adding verified tag so that it wont be seen in the to verify list
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils'; import { speechLanguageConfigToLanguage } from 'vs/workbench/contrib/speech/common/speechService'; suite('SpeechService', () => { test('resolve language', async () => { assert.strictEqual(speechLanguageConfigToLanguage(undefined), 'en-US'); assert.strictEqual(speechLanguageConfigToLanguage(3), 'en-US'); assert.strictEqual(speechLanguageConfigToLanguage('foo'), 'en-US'); assert.strictEqual(speechLanguageConfigToLanguage('foo-bar'), 'en-US'); assert.strictEqual(speechLanguageConfigToLanguage('tr-TR'), 'tr-TR'); assert.strictEqual(speechLanguageConfigToLanguage('zh-TW'), 'zh-TW'); assert.strictEqual(speechLanguageConfigToLanguage('auto', 'en'), 'en-US'); assert.strictEqual(speechLanguageConfigToLanguage('auto', 'tr'), 'tr-TR'); assert.strictEqual(speechLanguageConfigToLanguage('auto', 'zh-tw'), 'zh-TW'); }); ensureNoDisposablesAreLeakedInTestSuite(); }); </ins>

Discussion:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked
Change:
if (!needsMargin) { this._zone.value.setWidgetMargins(widgetPosition, 0); } <ins> } if (this._activeSession) { </ins> this._zone.value.updateBackgroundColor(widgetPosition, this._activeSession.wholeRange.value); } this._zone.value.show(widgetPosition);

Discussion:
open inline chat on a mid sized method/function the whole function gets included (by the chat extension) the background color isn't contiguous <img width="963" alt="Screenshot 2023-09-26 at 16 15 59" src=""

trigger inline chat and send a command press the reload button in the chat press escape notice that it keeps the last result (and does not restore the initial document) When I don't click the reload button, pressing escape restores the initial document. ! Context:
Change:
if (TabFocus.getTabFocusMode() && event.keyCode === 9) { return false; } <ins> // Skip alt+F4 if (platform.isWindows && event.altKey && event.key === 'F4' && !event.ctrlKey) { return false; } </ins> return undefined; });

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: 1.17.0 OS Version: Win10 Pro Steps to Reproduce: integrated terminal the focus to the integrated terminal window Alt+F4 <!-- Launch with to check. --Reproduces without extensions: Yes Expected behaviour: VsCode Window should close. Current behaviour: Nothing happens. Tested terminals: Git Bash and PowerShell I couldn't find a command name to use in commandsToSkipShell.
Confirmed on: VSCode Version: 1.17.2, 1.18 (insiders) OS Version: Windows 7 x64 Works as expected on ubuntu, while in the terminal will close the main vscode window. Any pointers on testing winpty- cc: It should be possible to intercept call before it gets to the terminal, perhaps a quick program to test what the console is receiving. Possibly related to:
There's a program in the directory of a winpty checkout - , which shows that winpty is receiving the for me - it probably shouldn't be receiving it at all, which would be an issue of VSCode not filtering it. The workaround right now is to assign to in your keybindings, and then add to .
Awesome feedback and I agree, shouldn't be received by the terminal at all. Going to look at capturing this from the parent.
is a little too drastic I think. It closes all the visual studio code windows instead of just the current one.
Ok, I see there's a command, so that's probably a better fit. Either way, the real fix for this will just filter from the terminal and then it should just take the default action.
I believe the issue here is that on Windows the terminal eats the alt+f4 keybinding. The only way currently to workaround this is to add commands to the whitelist . I'm not sure alt+f4 is bound to anything though as it's a system thing. I'm thinking just special casing this on Windows to always force skipping? Opening this up for PRs, here is the relevant code
Change:
const range = foldingModel.regions.findRange(index + 1); foldingModel.setCollapsed(range, collapsed); } <ins> export function* getMarkdownHeadersInCell(cellContent: string): Iterable<{ readonly depth: number; readonly text: string }> { for (const token of marked.lexer(cellContent, { gfm: true })) { if (token.type === 'heading') { yield { depth: token.depth, text: renderMarkdownAsPlaintext({ value: token.text }).trim() }; } } } </ins>

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) I expected that folding cells per a markdown header level would collapse all of the markdown and code cells under that header, per the VS Code Outline view of the notebook. In practice though, if there is a markdown cell with a python code block, then the comments in that python code block are considered the next top-level markdown section which interrupts the code folding. a new file and set the interpreter markdown cell with content: markdown cell: code cell: markdown cell: python print('hello world') the cell that cells 2 and 3 are collapsed and hidden, but cell 4 is not Add additional 's to the embedded python comment so that its not at the same level of the makrdown section it is under; e.g., python print('hello world') 70.0 v2022.7. Python 3.8.13 v2022.12.0 conda 4.13.0 Local
still seeing this issue- lmk if my setup is wrong. thanks! <img width="1322" alt="Screenshot 2023-01-25 at 1 11 16 PM" src="https://user-"<img width="1314" alt="Screenshot 2023-01-25 at 1 11 11 PM" src="https://user-"
Can you try finishing editing the cells to put them into render mode: ! I don't think we update the folding until the cell is no longer being edited
was verifying another issue and this works now!
Change:
"src/vs/workbench/workbench.web.main.ts", "src/vs/workbench/api/common/extHostTypes.ts" ], // Temporarily enabled for self-hosting "terminal.integrated.stickyScroll.enabled": true, // Temporarily enabled for self-hosting "scm.showIncomingChanges": "always", <del> "scm.showOutgoingChanges": "always" </del> <ins> "scm.showOutgoingChanges": "always", "workbench.editor.showTabs": "multiple", </ins> }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0-insider (Universal) OS Version: Sonoma 14.0 Description: The setting '' is either listed incorrectly as available under the Folder settings, or is incorrectly showing an error when set under the folder settings. I'm not sure of the expected behavior (personally, I'd prefer it to be settable at the folder level rather than having to create a new profile just to change this setting, but regardless, the setting is confusing) Steps to Reproduce: the setting "" as default (multiple) a folder and include the setting "": "none" (setting can be adjusted in the json file without error, or found in the Settings UI. and reopen VS Code. notification appears: "Unable to write to Folder Settings because does not support the folder resource scope." Note: The change that I made to settings and subsequent changes to the folder do function and are saved correctly, but the error notification continues to appear. As far as I can tell, it's simply a bad error message, but obviously is concerning, since it (incorrectly) indicates I can't save folder settings. <img width="1512" alt="image" src=""
Thank you for reporting this There was an error in the migration of this setting which I've fixed now.
I can still repro this with following steps: Open a folder with file Set the setting in the file Reload window <img width="483" alt="image" src=""
Change:
} } <del> async showStash(index: number): Promise<string[] | undefined> { const args = ['stash', 'show', `stash@{${index}}`, '--name-only']; </del> <ins> async showStash(index: number): Promise<Change[] | undefined> { const args = ['stash', 'show', `stash@{${index}}`, '--name-status', '-z']; </ins> try { const result = await this.exec(args); <ins> if (result.exitCode) { return []; } </ins> <del> return result.stdout.trim() .split('n') .filter(line => !!line); </del> <ins> return parseGitChanges(this.repositoryRoot, result.stdout.trim()); </ins> } catch (err) { if (/No stash found/.test(err.stderr || '')) { return undefined;

Discussion:
Testing Create a git stash that includes a new file, or a renamed file "View stash" The editor only shows modified files, and there is no indication that some content is missing <img width="442" alt="image" src=""<img width="305" alt="image" src=""<img width="887" alt="image" src=""
Maybe the pattern is that it only shows files that currently exist in the workspace. If I delete , then "View stash", I don't see that file either.
could you please take a look at this. I have checked and the git extensions is passing all files but it does look like the multi-file diff editor does not display all of them. Let me know if I need to change anything in the git extension. Thanks!
still seeing this, <img width="1725" alt="Screenshot 2024-01-25 at 8 31 59 AM" src=""<img width="1728" alt="Screenshot 2024-01-25 at 8 31 44 AM" src=""<img width="650" alt="Screenshot 2024-01-25 at 8 32 13 AM" src=""
when you have untracked filed you have to use the "Git: Stash (Include Untracked)" command otherwise the untracked files are not being included in the stash.
Change:
const computedRepresentableSize = Math.max(0, computedAvailableSize - 2 * 0); const computedRatio = scrollHeight > 0 ? (computedRepresentableSize / scrollHeight) : 0; <del> const computedSliderSize = Math.max(0, Math.floor(layoutInfo.height * computedRatio)); const computedSliderPosition = Math.floor(scrollTop * computedRatio); </del> <ins> const computedSliderSize = Math.max(0, Math.round(layoutInfo.height * computedRatio)); const computedSliderPosition = Math.round(scrollTop * computedRatio); </ins> return { height: computedSliderSize,

Discussion:
Testing Scroll a bit in the notebook diff. Notice that the current location rectangle is not always right. Notice that the first and last line are not straight. !
I can still get a tiny misalignment in the text diff scrollbars, not sure if it's the same scenario: <img width="115" alt="image" src="https://user-"
<img width="985" alt="image" src="https://user-"How do I get that custom scrollbar in the notebook diff editor? I see a regular scrollbar
Change:
const element = this.view.element(viewIndex); if (element.editorAttached) { <del> this._revealRangeCommon(viewIndex, range, false, false); </del> <ins> this._revealRangeCommon(viewIndex, range); </ins> } else { const elementHeight = this.view.elementHeight(viewIndex); <del> let upwards = false; </del> <ins> let alignHint: 'top' | 'bottom' | undefined = undefined; </ins> if (elementTop + elementHeight <= scrollTop) { <del> // scroll downwards </del> <ins> // scroll up </ins> this.view.setScrollTop(elementTop); <del> upwards = false; </del> <ins> alignHint = 'top'; </ins> } else if (elementTop >= wrapperBottom) { <del> // scroll upwards </del> <ins> // scroll down </ins> this.view.setScrollTop(elementTop - this.view.renderHeight / 2); <del> upwards = true; </del> <ins> alignHint = 'bottom'; </ins> } const editorAttachedPromise = new Promise<void>((resolve, reject) => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: a new notebook a code cell a markdown cell with a few lines such as follows Go into preview mode in markdown Edit first cell to get into notebook mode Arrow down to select markdown cell and hit enter Watch how the mardown cell scrolls up in the notebook view Go back to preview mode Scroll the notebook to view the first cell again and edit it Now select the markdown cell using the mouse Double click the mardown cell to edit it and wathc how it does not scroll!! I.e. using keyboard vs mouse results in different behaviour with scrolliing of the notebook. Ideally I would expect there to be no automatic scrolling when editing using keyboard, just as with mouse given the md cell is already in view we should not scroll this cell !
When pressing enter, we try to reveal the cursor selection in the cell editor into view by calling which uses the reveal type My expectation is it only scrolls the cell if it's out of the viewport but currently it always reveals the cell to the top of the viewport. Changing the reveal type to does fix the problem (as it should behave, here I'm not necessarily suggesting we change the reveal type in ).
Assigning to Feb milestone as the experience is quite bad. What surprised me is we didn't get user reports for this, which made me wonder how many users edit markdown cells after they are initially created.
Change:
import { Connection, FullDocumentDiagnosticReport, TextDocuments, UnchangedDocumentDiagnosticReport } from 'vscode-languageserver'; import * as md from 'vscode-markdown-languageservice'; <del> import { disposeAll } from 'vscode-markdown-languageservice/out/util/dispose'; </del> import { Disposable } from 'vscode-notebook-renderer/events'; import { URI } from 'vscode-uri'; import { ConfigurationManager, ValidateEnabled } from '../configuration'; <ins> import { disposeAll } from '../util/dispose'; </ins> const defaultDiagnosticOptions: md.DiagnosticOptions = { validateFileLinks: md.DiagnosticLevel.ignore,

Discussion:
Add some form of error reporting for links in markdown files where we are confident that link is incorrect. Example: We should also have a setting to disable this error reporting since we will not be able to understand every flavor of markdown link
Bad references (seems like this should almost always be a reasonable error to report) Missing files (false positive if users rely on different logic to resolve markdown paths) - Missing headers (false positive if users rely on custom slugifier or are linking to something besides headers, such as html elements) -Checking links to external resources () Checking html in markdown
Re-opening as we will likely keep this as experimental this iteration
Change:
import { ISearchHistoryService, SearchHistoryService } from 'vs/workbench/contrib/search/common/searchHistoryService'; import { ISearchViewModelWorkbenchService, SearchViewModelWorkbenchService } from 'vs/workbench/contrib/search/browser/searchModel'; import { SearchSortOrder, SEARCH_EXCLUDE_CONFIG, VIEWLET_ID, ViewMode, VIEW_ID } from 'vs/workbench/services/search/common/search'; <del> import { Extensions, IConfigurationMigrationRegistry } from 'vs/workbench/common/configuration'; </del> import { CommandsRegistry } from 'vs/platform/commands/common/commands'; import { assertType } from 'vs/base/common/types'; import { getWorkspaceSymbols, IWorkspaceSymbol } from 'vs/workbench/contrib/search/common/search';

Discussion:
I came across this: Can we by now remove it? Seems quite old:
Yes, this can be removed!
Change:
} } <del> const scopes = ['repo', 'workflow']; </del> <ins> const scopes = ['repo', 'workflow', 'user:email', 'read:user']; </ins> export async function getSession(): Promise<AuthenticationSession> { return await authentication.getSession('github', scopes, { createIfNone: true });

Discussion:
Because of the alignment we did here: GitHub Repos & GHPRI now have the same scopes... unfortunately, the built-in GitHub extension did not receive the same alignment and as a result, you get 2 sign-ins back to back when using GitHub Repos on Desktop: get the repo picker to load (GH extension) load the remote workspace (GHR extension) We should have the GitHub extension request: so that all of our extensions here are aligned. We need to do this alignment because GitHub doesn't have a mechanism yet for "token downscoping".
Change:
import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { EditorAction, EditorCommand, EditorContributionInstantiation, ServicesAccessor, registerEditorAction, registerEditorCommand, registerEditorContribution } from 'vs/editor/browser/editorExtensions'; <ins> import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; </ins> import { registerEditorFeature } from 'vs/editor/common/editorFeatures'; import { CopyPasteController, changePasteTypeCommandId, pasteWidgetVisibleCtx } from 'vs/editor/contrib/dropOrPasteInto/browser/copyPasteController'; import { DefaultPasteProvidersFeature } from 'vs/editor/contrib/dropOrPasteInto/browser/defaultProviders';

Discussion:
In several applications you can use Ctrl+Shift+V to paste text without formatting. We already have that registered to unfortunately, but it would be great to introduce a dedicated command for the default paste handler that users could perhaps rebind to Ctrl+Shift+V for cases where there are multiple paste handlers and I know I just want the literal text on my clipboard.
Should mostly be possible using: But a dedicated command is a good idea
I must say I find the settings confusing. It took me a long time before I realised that the setting "Editor: Format On Paste" was not the only one affecting this behaviour, but that there is also "Editor: Auto Indent" which "automatically adjusts the indentation when users paste". Edit: The keyboard shortcut works great after all (My VS Code was not up to date)
What VS Code version are you on?
I'm on 1.77.1, which VS Code is telling me corresponds to "Date: 2023-04-04 (5 mos ago)". I guess maybe the behaviour your comment depends on was introduced in the meantime (I haven't given VS Code root privileges, so it can't auto update, I guess I forgot to update manually). If that's the case I'm looking forward to adding the shortcut :¬), thanks for your reply
Yes it was in 1.79. Try updating and that command should then work
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm@4.19.0-beta.47: version "4.19.0-beta.47" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.47.tgz#f5931201346a485e3bcb29d24e83583727e55707" integrity sha512-c8EcCSWCHnFYNdRMTnJIpYTV9J2Ze7kdB1GhTcPO2ipMEsqaP/u6Ca8rgBWwV9HeEVfe4rGRqWW2qcSy4U9hMQ== </del> <ins> xterm@4.19.0-beta.49: version "4.19.0-beta.49" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.49.tgz#96d0d748c97a2f0cfa4c6112bc4de8b0d5d559fe" integrity sha512-qPhOeGtnB357mZOvfDckVlPDR7EDkSASQrB3aujhjgJlOiBBqcNRJcuSvF7v1DOho7xdEI9UQxiSiT5diHhMlg== </ins>

Discussion:
Theme pictured is Sapphire. ! Possibly related to Code pointer
Blending colors in vscode yields rgba format, so we should add that support to !
issue
Repro for this is to set the following settings and try find in terminal:

Started seeing this yesterday: !
This seems to be related to my theme, probably same root cause as
Repro for this is to set the following settings and try find in terminal: