jiebi/CodeConvo huggingface dataset:
Change:
cursorWidth: IEditorOption<EditorOption.cursorWidth, number>; disableLayerHinting: IEditorOption<EditorOption.disableLayerHinting, boolean>; disableMonospaceOptimizations: IEditorOption<EditorOption.disableMonospaceOptimizations, boolean>; <ins> domReadOnly: IEditorOption<EditorOption.domReadOnly, boolean>; </ins> dragAndDrop: IEditorOption<EditorOption.dragAndDrop, boolean>; emptySelectionClipboard: IEditorOption<EditorOption.emptySelectionClipboard, boolean>; extraEditorClassName: IEditorOption<EditorOption.extraEditorClassName, string>;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: Steps to Reproduce: a browser version vscode a editor with readonly mode extension who use the API would be invalid This issue won't be occured on desktop version. Follow code show more details: the attribute is used to disable keyboard popping in mobile devices, but it break the event too. Change the to may be better <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Can you please give an example of how behaves differently? I am not 100% convinced that there is a bug here. I would expect that is never called, not in desktop and also not in web.
There is a way that are relatively easy to reproduce this bug, when someone use GitHub CodeSpaces (because the bug only occured in browser version): the extension and the Extension. (the extension require the API for basic cursor motion, and the GitLens extension will provide can readonly mode editor) any file which has at least two commit, click in the editor menu title. ! we will get a readonly editor, but extension can not move cursor by pressing key here. The readonly attribute was in this commit: As the message describe, it used to disable keyboard popping up on mobile devices, and there is no condition at the earliest time. and then add the condition at this commit by you , I guess that's the readonly attribute cause some bug at desktop version at that time? Another thing, I think when we need consider the mobile devices, I think change the to may be better, but there is not a option named in , so I just change it to at .
To verify, install vim in the browser and use it in a readonly editor (e.g. left side of a diff editor).
Change:
width: 100%; height: 0; z-index: 13; /* Settings editor uses z-index: 12 */ <ins> /* TODO@benibenj temporary solution, all lists should provide their background */ background-color: var(--vscode-sideBar-background); </ins> } .monaco-list .monaco-scrollable-element .monaco-tree-sticky-container .monaco-tree-sticky-row.monaco-list-row{

Discussion:
Type: <bBug</bTree sticky scroll is not showing properly in test explorer Looks like it doesn't have this background color property set to it which is there in Explorer but then I wonder if this is applicable to extensions contributed lists then wouldn't it break the UI for extension list after enabling the tree sticky scroll setting which don't have this property set. ! settings enabled. "": true, "testExplorer.useNativeTesting": true, ! VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-22T05:35:23.085Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ ng-template17.0.2 multi-cursor-case-preserve1.0.5 codeium1.4.20 codium0.7.17 svg-gallery2.1.0 console-log0.6.2 gitlens2023.11.2204 vscode-test-explorer2.21.1 angular2-switcher0.4.0 vscode-jest-test-adapter0.8.1 template-string-converter0.6.1 test-adapter-converter0.1.8 gitpatch0.2.1 material-icon-theme4.32.0 pretty-ts-errors0.5.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Testing tree is not providing it's background which it actually should. Created a temporary solution to ensure sticky scroll works in all trees. Currently working on a long term solution to ensure each tree will have the right background color
Change:
"cssnano": "^4.1.11", "debounce": "^1.0.0", "deemon": "^1.4.0", <del> "electron": "17.4.1", </del> <ins> "electron": "17.4.3", </ins> "eslint": "8.7.0", "eslint-plugin-header": "3.1.1", "eslint-plugin-jsdoc": "^19.1.0",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.1 OS Version: Win 7 x64 Steps to Reproduce: update Electron to 17.4.3
Does this fix the high CPU usage on OSX? (introduced in 1.67.0)
Change:
import { ICommandService } from 'vs/platform/commands/common/commands'; import { TestCommandService } from 'vs/editor/test/browser/editorTestServices'; import { INotebookEditorService } from 'vs/workbench/contrib/notebook/browser/services/notebookEditorService'; <ins> import { RerunAction } from 'vs/workbench/contrib/inlineChat/browser/inlineChatActions'; </ins> suite('InteractiveChatController', function () {

Discussion:
make an inline chat request that changes code select the re-generate action :bug: the previous changes aren't undone
Change:
async rename(from: URI, to: URI, opts: IFileOverwriteOptions): Promise<void> { } async delete(resource: URI, opts: IFileDeleteOptions): Promise<void> { } <ins> async writeFile() { throw new NotSupportedError(); } </ins> //#endregion }

Discussion:
Refs: I do not understand this condition: How does that make sure a method exists? The only check for this that is valid currently is , the is just a detail of the file system and not a capability.
This looks like an actual typo to me or missing code review, not sure the consequences, as it could lead to errors when wrongly asserting, so maybe moving to August for investigation.
TLDR I misunderstood how the declared capabilities relate to the actual declared methods and the meaning of . For context, this change came in through and the intention of this change was to support the scenario where an has declared but not : since is optional in the interface and the capability requires both and to be implemented: I made this change because when implementing a with but not , this would result in throwing here: I see how it's possible that a which has check does not have a method implemented. Additionally I see that we have other examples of how to handle the requirement of a readonly filesystem which implements both and , e.g.: I am reverting Apologies for the incorrect code change and thank you for pointing this out.
Change:
const widget = disposables.add(new ColorPickerWidget(context.fragment, model, editor.getOption(EditorOption.pixelRatio), themeService, participant instanceof StandaloneColorPickerParticipant)); context.setColorPicker(widget); <ins> let editorUpdatedByColorPicker = false; </ins> let range = new Range(colorHover.range.startLineNumber, colorHover.range.startColumn, colorHover.range.endLineNumber, colorHover.range.endColumn); if (participant instanceof StandaloneColorPickerParticipant) { const color = hoverParts[0].model.color;

Discussion:
Construct a file that will be modified when saving (such as by a format-on-save, or other code action set to run on save) Open the color picker Change the color in the color picker (but keeping it open) Press Save to modify the document Change the color again Seems like the original range is being used and not compensating for the changes made in the document. ! If you don't first select a color in the color picker, pressing Save causes it to close. Perhaps that's what should happen in the case where you did pick one too?
Change:
return; } <del> const snippet = await this.createUriListSnippet(uriList); </del> <ins> const snippet = await this.createUriListSnippet(document.uri, uriList); </ins> if (!snippet || token.isCancellationRequested) { return; }

Discussion:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch
Change:
'terminal.integrated.tabs.enabled': { description: localize('terminal.integrated.tabs.enabled', 'Controls whether terminal tabs display as a list to the side of the terminal. When this is disabled a dropdown will display instead.'), type: 'boolean', <del> default: true, </del> <ins> default: false, </ins> }, 'terminal.integrated.tabs.hideCondition': { description: localize('terminal.integrated.tabs.hideCondition', 'Controls whether the terminal tabs view will hide under certain conditions.'),

Discussion:
We decided to turn the feature off by default. While the feature is quite polished at this point, there are a few remaining issues and we'll probably find some more when the feature goes out to a larger group so we'll push the default switch to next month.
Change:
private handleKeywordActivation(): void { const enabled = <del> this.speechService.hasSpeechProvider && this.configurationService.getValue(KeywordActivationContribution.SETTINGS_ID) !== KeywordActivationContribution.SETTINGS_VALUE.OFF && </del> <ins> supportsKeywordActivation(this.configurationService, this.speechService) && </ins> !this.speechService.hasActiveSpeechToTextSession; if ( (enabled && this.activeSession) ||

Discussion:
Type: <bBug</bIt's unexpected to switch to editor window and notice micophone appeared in status bar with tooltip "Waiting for voice chat to end" (very strange message for because it looks like it listens everything at this moment) at the end of meeting. ! Clicking on it opens settings with search for , but only result is Extenions Experimental: Deferred Startup Finished Activation (), which adds to confusion. I won't expect to see this status item until I gave explicit approval to use mic. VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-19T05:37:08.195Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
/assign bpasero I think you are latest committer that changed activation
Same here, how do i disable this feature? Cant find it in settings
This is related only to Insiders version and will be gone with today's Insiders build.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
let result: IInsetRenderOutput | undefined = undefined; const [mimeTypes, pick] = this.output.resolveMimeTypes(this._notebookTextModel, undefined); <del> const pickedMimeTypeRenderer = mimeTypes[pick]; </del> <ins> const pickedMimeTypeRenderer = this.output.pickedMimeType || mimeTypes[pick]; </ins> if (mimeTypes.length > 1) { outputItemDiv.style.position = 'relative'; const mimeTypePicker = DOM.$('.multi-mimetype-output');

Discussion:
Run the following cell Stage the notebook Make changes to the HTML Run again and view the diff Problems Clicking the will display a quick pick, however selecting anything is a noop !
/cc
Change:
); // Apply extension environment variable collections to the environment <del> if (!shellLaunchConfig.strictEnv) { </del> <ins> if (!shellLaunchConfig.strictEnv && !shellLaunchConfig.hideFromUser) { </ins> const mergedCollection = new MergedEnvironmentVariableCollection(this._environmentVariableCollections); mergedCollection.applyToProcessEnvironment(env, variableResolver); }

Discussion:
Run "Remote-SSH: Connect to Host" An empty remote window opens The terminal is shown (We force this for empty remote windows) After a second, the panel is closed Setting a bp shows that this happens because the terminal process died
Any OS info? Curious why this is forced?
Just Ubuntu. I think we did that to help avoid people being confused in an empty remote window. It just shows them what they are connected to.
Enabling trace logs should show how the terminal was created, maybe an invalid launch config is passed in initially before the connectionis ready?
Change:
const rangeHighlightBorder = theme.getColor(editorRangeHighlightBorder); if (rangeHighlightBorder) { <del> collector.addRule(`.monaco-editor .rangeHighlight { border: 1px ${isHighContrast(theme.type) ? 'dotted' : 'solid'} ${rangeHighlightBorder}; }`); </del> <ins> collector.addRule(`.monaco-editor .rangeHighlight { border: 1px ${isHighContrast(theme.type) ? 'dotted' : 'solid'} ${rangeHighlightBorder}; box-sizing: border-box; }`); </ins> } const symbolHighlightBorder = theme.getColor(editorSymbolHighlightBorder);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code version | OS ------------------ | ---- 73.1 | Win 10 x64 pro 21H2 a color like as transparent then to browse through symbol ! A uniform background with no line. This is not a duplicate of other related issues. This is not related to or Not related to fonts either.
Change:
env: GITHUB_TOKEN: "$(github-distro-mixin-password)" displayName: Download Electron and Playwright <ins> retryCountOnTaskFailure: 3 </ins> - ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}: - ${{ if eq(parameters.VSCODE_QUALITY, 'oss') }}:

Discussion:
Build: Changes: This seems to be temporary. Still it would be good if we can retry
Change:
const inputWidget = this.instantiationService.createInstance(SCMInputWidget, inputElement, this.overflowWidgetsDomNode); templateDisposable.add(inputWidget); <del> return { inputWidget, elementDisposables: templateDisposable.add(new DisposableStore()), templateDisposable }; </del> <ins> return { inputWidget, elementDisposables: new DisposableStore(), templateDisposable }; </ins> } renderElement(node: ITreeNode<ISCMInput, FuzzyScore>, index: number, templateData: InputTemplate): void {

Discussion:
Type a multiline commit message Scroll away Scroll back When the row gets rerendered (I assume) it is sized to one line. If I type a newline in this box, the size gets fixed !
Possibly a regression introduced with
Change:
} }); <del> function registerCallStackInlineMenuItem(id: string, title: string, icon: Icon, when: ContextKeyExpression, order: number): void { </del> <ins> function registerCallStackInlineMenuItem(id: string, title: string, icon: Icon, when: ContextKeyExpression, order: number, precondition?: ContextKeyExpression): void { </ins> MenuRegistry.appendMenuItem(MenuId.DebugCallStackContext, { group: 'inline', order, when, <del> command: { id, title, icon } </del> <ins> command: { id, title, icon, precondition } </ins> }); } const threadOrSessionWithOneThread = ContextKeyExpr.or(CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('thread'), ContextKeyExpr.and(CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('session'), CONTEXT_CALLSTACK_SESSION_HAS_ONE_THREAD))!; registerCallStackInlineMenuItem(PAUSE_ID, PAUSE_LABEL, icons.debugPause, ContextKeyExpr.and(threadOrSessionWithOneThread, CONTEXT_CALLSTACK_ITEM_STOPPED.toNegated())!, 10); registerCallStackInlineMenuItem(CONTINUE_ID, CONTINUE_LABEL, icons.debugContinue, ContextKeyExpr.and(threadOrSessionWithOneThread, CONTEXT_CALLSTACK_ITEM_STOPPED)!, 10); <del> registerCallStackInlineMenuItem(STEP_OVER_ID, STEP_OVER_LABEL, icons.debugStepOver, threadOrSessionWithOneThread, 20); registerCallStackInlineMenuItem(STEP_INTO_ID, STEP_INTO_LABEL, icons.debugStepInto, threadOrSessionWithOneThread, 30); registerCallStackInlineMenuItem(STEP_OUT_ID, STEP_OUT_LABEL, icons.debugStepOut, threadOrSessionWithOneThread, 40); </del> <ins> registerCallStackInlineMenuItem(STEP_OVER_ID, STEP_OVER_LABEL, icons.debugStepOver, threadOrSessionWithOneThread, 20, CONTEXT_CALLSTACK_ITEM_STOPPED); registerCallStackInlineMenuItem(STEP_INTO_ID, STEP_INTO_LABEL, icons.debugStepInto, threadOrSessionWithOneThread, 30, CONTEXT_CALLSTACK_ITEM_STOPPED); registerCallStackInlineMenuItem(STEP_OUT_ID, STEP_OUT_LABEL, icons.debugStepOut, threadOrSessionWithOneThread, 40, CONTEXT_CALLSTACK_ITEM_STOPPED); </ins> registerCallStackInlineMenuItem(RESTART_SESSION_ID, RESTART_LABEL, icons.debugRestart, CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('session'), 50); registerCallStackInlineMenuItem(STOP_ID, STOP_LABEL, icons.debugStop, ContextKeyExpr.and(CONTEXT_CALLSTACK_SESSION_IS_ATTACH.toNegated(), CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('session'))!, 60); registerCallStackInlineMenuItem(DISCONNECT_ID, DISCONNECT_LABEL, icons.debugDisconnect, ContextKeyExpr.and(CONTEXT_CALLSTACK_SESSION_IS_ATTACH, CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('session'))!, 60);

Discussion:
Issue Type: <bBug</bCompare the appearance of the step-in/over/out buttons on the main debug toolbar with the same buttons that appear in the call stack. ! The ones in the call stack are enabled even when execution hasn't been suspended. VS Code version: Code - Insiders 1.56.0-insider (, 2021-04-02T05:15:44.248Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
/assign
Great catch, and thanks for the fix
/verified
Change:
</dict> <dict> <key>include</key> <string>#fenced_code_block_css</string> </dict> <dict>

Discussion:
For a markdown file like this: text text text . text text text <divhtml </div. text text text The numbered list, html block, and fenced code block elements following the line are nor properly colorized. They are rendered properly in the preview. ! In the case of the html, the text should not be colorized since it is html content, not markdown. Adding a blank line after the paragraph fixes the colorization. !
Change:
return this._lineNumbers; } <del> setState(state: StickyScrollWidgetState): void { dom.clearNode(this._lineNumbersDomNode); dom.clearNode(this._linesDomNode); </del> <ins> setState(state: StickyScrollWidgetState | undefined): void { this._clearStickyWidget(); if (!state) { return; } </ins> this._stickyLines = []; const editorLineHeight = this._editor.getOption(EditorOption.lineHeight); const futureWidgetHeight = state.startLineNumbers.length * editorLineHeight + state.lastLineRelativePosition;

Discussion:
Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !
After delete and undo: !
Change:
const focused = accessor.get(IListService).lastFocusedList; const count = typeof arg2 === 'number' ? arg2 : 1; <del> // Ensure DOM Focus ensureDOMFocus(focused); </del> // List if (focused instanceof List || focused instanceof PagedList) { const list = focused;

Discussion:
I like the up / down keyboard navigation over notebook cells, but when you try to use to navigate the order is very unexpected. a notebook. I am using my- my work cell -Focus is on GitHub issues label -focus seems lost -focus is on the start of the document, even though I did not traverse until the end of the docuemnt Ideally tab should go in visual order. If that is not possible should move focus out of the notebook. Similarly tree tab is not used to move focus so users use up / down, but pressing tab focuses out of the tree and does not lead to unexpected jumping of focus.
Fixed in this change Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell (step 3 in OP) Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in )
Much better now. Thanks for fixing this.
Change:
return; } <ins> // Do not set focus/selection when the resource is already focused and selected if (this.tree.getFocus().some(e => isSCMResource(e) && this.uriIdentityService.extUri.isEqual(e.sourceUri, uri)) && this.tree.getSelection().some(e => isSCMResource(e) && this.uriIdentityService.extUri.isEqual(e.sourceUri, uri))) { return; } </ins> this.revealResourceThrottler.queue( () => this.treeOperationSequencer.queue( async () => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.2 OS Version: macOS Monterey (12.6) Steps to Reproduce: any SCM extension, e.g. , so you'll have multiple SCM providers. && && vscode select the "" file under Hg, you'll see how the "" under Git is revealed, selected and focused. This feature to reveal the active file in the SCM panel was implemented . It's enabled by default (). The problem is that when using other scm providers and trying to select the files to see the diff, it jumps to the git section instead of staying with the same provider. <img width="572" alt="Screen Shot 2023-09-30 at 12 05 07 AM" src=""In the screenshot above I selected the "" inside the "hg" section, but the one in Git was auto-selected. This is not specific for HG, I implemented an SCM provider in and it has the exact same issue.
The change that I made addresses the issue when an item is being clicked in the Source Control tree. Switching tabs may still highlight the incorrect resource since multiple resources have the same URI. The only way to address that would be to change the URI of the resources displayed in the Source Control view but that is a significant undertaking.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.

If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified