jiebi/CodeConvo huggingface dataset:
Change:
-ms-user-select: none; border: none !important; border-width: 0px !important; <del> color: var(red) !important; </del> } /* .codeActionMenuWidget .monaco-list:not(.element-focus) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Type: Bug Using editor.experimental.useCustomCodeActionMenu, the menu doesn't match up with the colors of enabled/disabled options or the background of the other context menus

Type: <bBug</bmenu the window Bug The widget ends up being incorrectly positioned: <img width="672" alt="Screen Shot 2022-07-21 at 1 24 17 PM" src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-21T05:17:20.056Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
import { Range } from 'vs/editor/common/core/range'; import { CursorChangeReason } from 'vs/editor/common/cursorEvents'; import { IDiffComputationResult, ILineChange } from 'vs/editor/common/diff/legacyLinesDiffComputer'; <del> import { DetailedLineRangeMapping, RangeMapping } from 'vs/editor/common/diff/rangeMapping'; </del> <ins> import { LineRangeMapping, RangeMapping } from 'vs/editor/common/diff/rangeMapping'; </ins> import { EditorType, IDiffEditorModel, IDiffEditorViewModel, IDiffEditorViewState } from 'vs/editor/common/editorCommon'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { IIdentifiedSingleEditOperation } from 'vs/editor/common/model';

Discussion:
a change it using the gutter arrow :bug: indentation is lost
Can you share a screenshot/screenrecording and provide context on the document you have? Thanks!
Cannot reproduce: ! Please always try to include as much context as you can.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Hi Henning I think I can also reproduce this in 1.84.0-insider (MacOS). I believe the preconditions to reproduce is to set (which is also the default) and revert a deleted code chunk. See attached gif. !
Hey this issue might need further attention. you can help us out by closing this issue if the problem no longer exists, or adding more information.
Change:
const font = this._configHelper.getFont(undefined, true); const config = this._configHelper.config; const editorOptions = this._configurationService.getValue<IEditorOptions>('editor'); <ins> let xtermRendererType: RendererType; if (config.rendererType === 'auto') { // Set the builtin renderer to canvas, even when webgl is being used since it's an addon const suggestedRendererType = this._storageService.get(SUGGESTED_RENDERER_TYPE, StorageScope.GLOBAL); xtermRendererType = suggestedRendererType === 'dom' ? 'dom' : 'canvas'; } else { xtermRendererType = config.rendererType === 'experimentalWebgl' ? 'canvas' : config.rendererType; } </ins> const xterm = new Terminal({ altClickMovesCursor: config.altClickMovesCursor && editorOptions.multiCursorModifier === 'alt',

Discussion:
Part of We should also improve the fallback logic to do this: Try webgl If it threw an exception, try canvas If frame rendering averages 50ms (existing detection), use DOM We will keep the canvas renderer around for now mainly because Safari doesn't support webgl2 and can evaluate again at a later date.
It looks like canvas is still the default for me -- the is present unless I explicitly enable experimentalWebgl. I don't see any notifications of errors that could be causing it.
Change:
if (previous) { if (next) { const betweenProgress = (offset - window.scrollY - previous.element.getBoundingClientRect().top) / (next.element.getBoundingClientRect().top - previous.element.getBoundingClientRect().top); <del> return previous.line + betweenProgress * (next.line - previous.line); </del> <ins> const line = previous.line + betweenProgress * (next.line - previous.line); return (0 <= line) ? line : 0; </ins> } else { <del> return previous.line; </del> <ins> return (0 <= previous.line) ? previous.line : 0; </ins> } } return null;

Discussion:
From: Steps to Reproduce: VSCode Version: 1.20.1 OS Version: macOS High Sierra 10.13.3 Steps to Reproduce: markdown file markdown to first line in preview or double click on the first line Does this issue occur when all extensions are disabled?: Yes
Change:
this._register(this.onDidDebuggersExtPointRead(() => { this.debugExtensionsAvailable.set(this.debuggers.length > 0); })); <del> this._register(tasksService.onDidChangeTaskConfig(() => { this.updateTaskLabels(); </del> <ins> // generous debounce since this will end up calling `resolveTask` internally const updateTaskScheduler = this._register(new RunOnceScheduler(() => this.updateTaskLabels(), 5000)); this._register(Event.any(tasksService.onDidChangeTaskConfig, tasksService.onDidChangeTaskProviders)(() => { updateTaskScheduler.cancel(); updateTaskScheduler.schedule(); </ins> })); this.lifecycleService.when(LifecyclePhase.Eventually) .then(() => this.debugExtensionsAvailable.set(this.debuggers.length > 0)); // If no extensions with a debugger contribution are loaded

Discussion:
a repo in :bug: see this !
This is expected if the repo that you open has tasks that run on . Could you pls provide me with a repo for which this happens that doesn't have those?
seeing this dialog when I just open a folder, so wondering if something with workspace trust has changed recently. No changes with tasks recently could explain this. !
Doesn't repro in , repros in : Bad: Good:
found these task PRs in that time frame: ,
found it also happens in an empty window on desktop
Still seeing this in (and also RemoteHub on desktop) with the changes in !
This is coming from -here. perhaps we don't want to do that for the or only do that in trusted workspaces? !
Change:
} private handleCopy(e: ClipboardEvent) { <del> if (!e.clipboardData || !this._editor.hasTextFocus() || !this.isPasteAsEnabled()) { </del> <ins> if (!this._editor.hasTextFocus()) { return; } if (platform.isWeb) { // Explicitly clear the web resources clipboard. // This is needed because on web, the browser clipboard is faked out using an in-memory store. // This means the resources clipboard is not properly updated when copying from the editor. this._clipboardService.writeResources([]); } if (!e.clipboardData || !this.isPasteAsEnabled()) { </ins> return; }

Discussion:
I posted this to StackOverflow, out of the possibility that I might be doing something wrong. however, there's a good chance this is a bug. Version: 1.79.2 Commit: User Agent: Mozilla/5.0 (X11; CrOS x86_64 .0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36 Embedder: <!-- generated by web issue reporter --
/gifPlease
Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, files are preferred as they are displayed inline on GitHub. You may find helpful as a browser-based gif recording tool. If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording ( in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue. Happy coding!
here you go. I came across the same problem: ! After copying a file the file path is retained until one reloads the site. I tested it on a Desktop Version connected to Codespaces and could reproduced it too.
Repo steps: a text file the explorer, copy a file using ctrl+c it into the text file and confirm the file path shows up copy some code in the text file using ctrl+c The file path is pasted instead of the selected text you just copied
Change:
end; end; <del> if IsNotBackgroundUpdate() and CheckForMutexes('{#TunnelMutex}') then </del> <ins> if IsNotBackgroundUpdate() and not StopTunnelProcesses() then </ins> begin MsgBox('{#NameShort} is still running a tunnel. Please stop the tunnel before installing.', mbInformation, MB_OK); Result := false

Discussion:
Type: <bBug</bVS Code version: Code - Insiders 1.80.0-insider (, 2023-06-19T05:35:37.388Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
same here
Made a fix but didn't create a PR apparently. Fixed in next Insiders.
Reopening due to
Change:
} else { this._notebookBindings.delete(key); } <del> this._onDidChangeNotebookKernelBinding.fire({ notebook: notebook.uri, oldKernel, newKernel: kernel.id }); </del> <ins> this._onDidChangeNotebookKernelBinding.fire({ notebook: notebook.uri, oldKernel, newKernel: kernel?.id }); </ins> this._persistMementos(); } }

Discussion:
Testing microsoft/vscode-jupyter untitled ipynb cells export commands are available in command palette the untitled notebook as ipynb and give it a title command palette :bug: all the export commands are now hidden
I think this is because technically the cells were run in the context of the previous notebook, so I now need to run them again after saving the notebook, which is a rather nasty limitation...
I think this is because after saving we don't have a kernel connected to the newly saved notebook. There is no kernel session transfer (from untitled to saved notebook) currently.
Save As is handled by core. Need to transfer current controller to new ipynb.
Seems related to
Not sure - we are handling this the same way we persist selection and other view state. But the editor still gets reopened with a new model. Dunno how this concept works in custom editors.
Custom editors have one the untitled editor closed and a new one with another URI open, I want a signal that a custom editor can handle to upgrade it so no close/open needs to happen
Steps: Open an untitled jupyter notebook Select a kernel Save the notebook The same kernel should be selected The "Set kernel as default" gear icon in the kernel picker was also removed.
Verified with this "kernel"
Change:
} private createToolbar(input: ISCMInput): void { <del> const contextKeyService2 = this.contextKeyService.createScoped(this.toolbarContainer); const services = new ServiceCollection([IContextKeyService, contextKeyService2]); </del> <ins> const services = new ServiceCollection([IContextKeyService, this.toolbarContextKeyService]); </ins> const instantiationService2 = this.instantiationService.createChild(services); <del> const ctxIsActionEnabled = SCMInputContextKeys.ActionIsEnabled.bindTo(contextKeyService2); </del> <ins> const ctxIsActionEnabled = SCMInputContextKeys.ActionIsEnabled.bindTo(this.toolbarContextKeyService); </ins> this.repositoryDisposables.add(input.repository.provider.onDidChangeResources(() => ctxIsActionEnabled.set(input.repository.provider.groups.some(r => r.resources.length > 0)))); const actionRunner = instantiationService2.createInstance(SCMInputWidgetActionRunner, input);

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!
Change:
private readonly suspendedWatchRequests = this._register(new DisposableMap<number /* correlation ID */>()); private readonly suspendedWatchRequestsWithPolling = new Set<number /* correlation ID */>(); <ins> private readonly updateWatchersDelayer = this._register(new ThrottledDelayer<void>(this.getUpdateWatchersDelay())); </ins> protected readonly suspendedWatchRequestPollingInterval: number = 5007; // node.js default private joinWatch = new DeferredPromise<void>();

Discussion:
With TS 5.5 we are seeing a lot more requests to watch paths such as which in the end makes the file watcher consume 100% CPU for at least a minute on my machine. Need to understand why this is so slow on startup, probably some complexity somewhere trying to handle these requests.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { exec } from 'child_process'; import { isWindows } from 'vs/base/common/platform'; const cmdline = { windows: 'getmac.exe', unix: '/sbin/ifconfig -a || /sbin/ip link' }; </del> <ins> import { networkInterfaces } from 'os'; </ins> const invalidMacAddresses = new Set([ '00:00:00:00:00:00',

Discussion:
Issue Type: <bBug</bsomething like Gentoo Linux VSCode in terminal get something like Possible fix: Don't hardcode the path to these :^) VS Code version: Code 1.49.1 (, 2020-09-16T23:23:33.049Z) OS version: Linux x64 5.8.8-gentoo <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ gitlens10.2.2 cpptools1.0.0 vsliveshare1.0.2740 LiveServer5.6.1 vscodeintellicode1.2.10 vscode-icons11.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Change:
readonly globList: readonly { include: boolean; text: string }[]; /** <del> * The user requested to filter for only the specified tags. </del> <ins> * The user requested to filter including tags. </ins> */ <del> readonly onlyTags: ReadonlySet<string>; </del> <ins> readonly includeTags: ReadonlySet<string>; /** * The user requested to filter excluding tags. */ readonly excludeTags: ReadonlySet<string>; </ins> /** * Focuses the filter input in the test explorer view.

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Splitting this out from In the Test UI you can filter by text or exclude text using and filter by a . It would be nice if we could also negate tags in the filter like to exclude a specific tag. <!-- Describe the feature you'd like. --
Starting point, this is where tag filtering happens:
Change:
{ "view": "explorer", "contents": "%view.workbench.cloneRepository%", <del> "when": "config.git.enabled && git.state == initialized && scmRepositoryCount == 0", </del> <ins> "when": "config.git.enabled && git.state == initialized && scm.providerCount == 0", </ins> "group": "5_scm@1" }, { "view": "explorer", "contents": "%view.workbench.learnMore%", <del> "when": "config.git.enabled && git.state == initialized && scmRepositoryCount == 0", </del> <ins> "when": "config.git.enabled && git.state == initialized && scm.providerCount == 0", </ins> "group": "5_scm@10" } ]

Discussion:
Type: <bFeature Request</bNo Clone Git repository option available VS Code version: Code 1.80.1 (, 2023-07-12T17:22:07.651Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Have you followed the instructions at yet?
! The button for the same doesn't show up
At a Windows command prompt please run to confirm what version you installed.
[image: ] It is the latest version
What do you see after you choose the third option on Activity Bar (Source Control view) instead of Explorer view? See the screenshot at
The git extension does indeed contribute welcome views to the "Explorer" view and it uses the context key. The problem is that this particular context key is only set when the "Source Control" view is rendered. So if you switch to the "Source Control" view and then back to the "Explorer" view then the option to clone a repository will appear.
Change:
child.style.lineHeight = `${lineHeight}px`; child.style.width = `${width}px`; child.style.height = `${lineHeight}px`; <del> child.style.zIndex = '0'; </del> <ins> child.style.position = 'absolute'; </ins> // Special case for the last line of sticky scroll if (index === this._lineNumbers.length - 1) { <del> child.style.position = 'relative'; child.style.zIndex = '-1'; child.style.top = this._lastLineRelativePosition + 'px'; </del> <ins> child.style.zIndex = '0'; child.style.top = index * lineHeight + this._lastLineRelativePosition + 'px'; } else { child.style.zIndex = '1'; child.style.top = `${index * lineHeight}px`; </ins> } // Each child has a listener which fires when the mouse hovers over the child

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello So I have noticed when using Sticky Scroll, any line which is too long (for example the screenshot below), it would block off the rest of the code. A feature I was thinking would be a good adition is sideways scrolling (like what happens already in the main editor) so that people can see what else is in that line. <kbd<img src="https://user-"/</kbd
Change:
const overriddenScope = element.overriddenScopeList[0]; const view = DOM.append(this.scopeOverridesIndicator.element, $('a.modified-scope', undefined, this.getInlineScopeDisplayText(overriddenScope))); <ins> this.scopeOverridesIndicator.focusElement = view; </ins> const onClickOrKeydown = (e: UIEvent) => { const [scope, language] = overriddenScope.split(':'); onDidClickOverrideElement.fire({

Discussion:
Change the key event handling so that the user can tab once into the indicators container, and then use left/right arrows to focus on different indicators.
the Settings editor, search on the setting. tab should focus on the first indicator. again should go to the checkbox. -tabbing twice from there should focus the entire setting again. again to the indicator. The left and right arrow keys, along with the home and end keys should allow the user to focus onto the other indicators. indicators container should keep track of the focused indicator. If the second indicator is focused, and the user tabs to the checkbox and back, the second indicator should be the one focused rather than the first one.
Change:
await testObject.run(); <del> assert.strictEqual(testObject.verificationStatus, ExtensionVerificationStatus.Unverified); </del> <ins> assert.strictEqual(testObject.verificationStatus, false); </ins> assert.strictEqual(testObject.installed, true); });

Discussion:
Continue installing the extension when signature verification fails - Report the error in telemetry CC
To verify: Install extension and make sure the extension is installed successfully. Also make sure you see following in the Shared log
Change:
// Prevent native context menus in web this._register(addDisposableListener(this.domElement, EventType.CONTEXT_MENU, (e) => EventHelper.stop(e, true))); <ins> // Prevent default navigation on drop this._register(addDisposableListener(this.domElement, EventType.DROP, (e) => EventHelper.stop(e, true))); </ins> // Workbench Lifecycle this._register(workbench.onBeforeShutdown(event => { if (storageService.hasPendingUpdate) {

Discussion:
Steps to Reproduce: from web (Firefox) a file onto itself =the page navigates ! This may be a general tree issue, not sure.
It's 2013 all over again. !
Up for grab.
Change:
} private onConfigurationChanged(event: IConfigurationChangeEvent): void { <del> if (event.affectsConfiguration('window.title') || event.affectsConfiguration('window.titleSeparator')) { </del> <ins> if (event.affectsConfiguration(WindowSettingNames.title) || event.affectsConfiguration(WindowSettingNames.titleSeparator)) { </ins> this.titleUpdater.schedule(); } }

Discussion:
Testing I think we will soon turn command center on by default. What is the impact on then? I see we are only showing the full title in the hover now, but I wonder if we need another setting (?) so that users still can configure what we show in the command center? ! Or maybe we should find a way to show the even in the command center with ellipsis if overflowing. //cc
Seems reasonable to me
Enabling the command centre removes my custom window title, showing the full path of the currently focussed editor. I find this very useful especially when there are files with the same name but in different directories. Can't the command centre show the full custom window title (without having to hover over it)? Without this, I would permanently disable it.
We can say the default is different but a customisation is honoured
To verify enable command center configure and/or validate that any customization is picked up by the CC reset above settings validate that the CC uses a default
Any reason we wouldn't also apply this with the default setting? My worry is that when we eventually make command center on by default, the setting would basically not work until you change it? I think it looks good when enabled even with default setting: !
The idea is that the CC shows an affordance to do something, like "Search vscode" - we replaced "search" with the icon which watered this down a bit. The worry is that the more title-stuff we put here the less likely it is that folks understand this as affordance
Change:
}; const resolving: Promise<any>[] = []; <del> const completions = await provideSuggestionItems(completionProvider, ref.object.textEditorModel, Position.lift(position), undefined, { triggerCharacter, triggerKind: triggerCharacter ? languages.CompletionTriggerKind.TriggerCharacter : languages.CompletionTriggerKind.Invoke }); </del> <ins> const completions = await provideSuggestionItems(completionProvider, ref.object.textEditorModel, Position.lift(position), undefined, { triggerCharacter: triggerCharacter ?? undefined, triggerKind: triggerCharacter ? languages.CompletionTriggerKind.TriggerCharacter : languages.CompletionTriggerKind.Invoke }); </ins> for (const item of completions.items) { if (resolving.length < (maxItemsToResolve ?? 0)) { resolving.push(item.resolve(CancellationToken.None));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.0-insiders OS Version: mac latest Steps to Reproduce: completion provider like so and then execute command to call it: Execute code above. output log of : However Some devs can rely on that type explicitly by doing checks like . So, there should be no way to get To sum up things:
Good test. Thank you so much!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified