jiebi/CodeConvo huggingface dataset:
Change:
const dismiss = nls.localize('dismiss', "You can dismiss this dialog by pressing Escape or focusing elsewhere."); const openDetectedLink = nls.localize('openDetectedLink', 'The Open Detected Link ({0}) command enables screen readers to easily open links found in the terminal.'); const openDetectedLinkNoKb = nls.localize('openDetectedLinkNoKb', 'The Open Detected Link command enables screen readers to easily open links found in the terminal and is currently not triggerable by a keybinding.'); <ins> const newWithProfile = nls.localize('newWithProfile', 'The Create New Terminal (With Profile) ({0}) command allows for easy terminal creation using a specific profile.'); const newWithProfileNoKb = nls.localize('newWithProfileNoKb', 'The Create New Terminal (With Profile) command command allows for easy terminal creation using a specific profile and is currently not triggerable by a keybinding.'); const accessibilitySettings = nls.localize('accessibilitySettings', 'Access accessibility settings such as `terminal.integrated.tabFocusMode` via the Preferences: Open Accessibility Settings command.'); </ins> class AccessibilityHelpWidget extends Widget implements ITerminalWidget { readonly id = 'help';

Discussion:
In our menu, we should mention setting
I actually think we should more broadly mention how to find accessibility settings here -

This is useful for discovering shell types and creating them. When was sharing his screen, he was going to edit his default profile in his file, which is more involved
Change:
this.extensionsManager = this._register(instantiationService.createInstance(ExtensionsManager)); this.extensionsManager.whenInitialized().then(() => { if (!isDisposed) { <del> this._register(this.extensionsManager.onDidChangeExtensions(({ added, removed }) => this._onDidChangeExtensions(added, removed))); </del> <ins> this._register(this.extensionsManager.onDidChangeExtensions(({ added, removed, isProfileSwitch }) => this._onDidChangeExtensions(added, removed, isProfileSwitch))); </ins> uninstallDisposable.dispose(); } });

Discussion:
VS Code Version: stable 1.74.0 OS Version: Windows 11 Build .900 Feature: Settings Profiles (Profiles) When certain Extensions that I had disabled for the active profile automatically update, they get re-inserted (re-enabled) in my Extensions list for that profile, and will remain there from that point onwards. I've noticed this with all the "C++" extensions from Microsoft, as well as the "Remote Explorer", and "Remote - SSH" also from Microsoft, but this might be happening with other extensions as well. Even if I disable them again for that profile, they'll come back the next time they update Steps to Reproduce: Profiles feature by setting the to true. the C++ from Microsoft on the default profile. a new profile "A" other than default, disable the C++ extension. a second profile "B" but enable the C++ extension. a third profile "C" following step 2. to either A or C profile. vscode, reopen it on the same folder, and wait for the C++ extension to update (I'm not aware of any means to force an extension update besides creating one myself). You'll notice that once the C++ extension update, it will re-enable automatically on both profiles A and C, and will remain there even after re-starting vscode, until you disable it again. In which case it will reappear again once it updates.
How did you force the extension update? Can you please share your profiles (you can use profile export feature) so that I can reproduce?
Hi as mentioned in the issue, I did not force the update since I'm not aware of any means to do that, I just waited for extensions to update. By the way I also noticed this happening with a non-Microsoft extension called "Better C++ Syntax" How can I share the profiles with you in a non-public manner?
You can export the profile to a file or github gist and share it with me via email -
Done. Hope that can solve it since it keeps happening. Thank you
Why is this still labelled as info-needed?
is there a way to simulate the extension update that is needed to reproduce the issue?

Yeah there is, but its a lengthy one: Please open extensions installation folder and the folder where profiles are stored that is user data folder/User/profiles Quit VS Code Change the name of the extension in the extensions installation folder and also the version in the Update the name and version in file in all profiles include the file in extension installation folder.
Change:
import { IChatRequestVariableEntry } from '../common/chatModel.js'; import { ChatInputPart } from './chatInputPart.js'; import { localize } from '../../../../nls.js'; <del> import { hash } from '../../../../base/common/hash.js'; </del> import { IConfigurationService } from '../../../../platform/configuration/common/configuration.js'; export class ChatImageDropAndPaste extends Disposable {

Discussion:
Testing a large image () it into chat window freezes for a few seconds Seems we spent in the !
cc. is there a compromise on what we hash for the ID? ie, maybe half of the bytes instead of the full thing, or something of the sort, since ATM we are just hashing the entire received
It looks like the function is trying to hash the Uint8Array naively as an object (hashing each key and value for each element in the array) which is going to be extraordinarily slow. should complete in millisecond(s) :)
should our detect if it's web and if crypto is available and use that if so? I can see this happening again.
Yea, I think having it check for typed arrays and arraybuffers would make sense. Unfortunately is sync and webcrypto is async, however, so it would not be a drop-in replacement.
perhaps we could have a signature like to catch at compile time and redirect that use to the async version in ?
Change:
} else { disposables.add(model.onColorFlushed(async (color: Color) => { await _updateColorPresentations(editorModel, model, color, range, colorHover); <ins> editorUpdatedByColorPicker = true; </ins> range = _updateEditorModel(editor, range, model, context); })); } <del> disposables.add(model.onDidChangeColor((color: Color) => { _updateColorPresentations(editorModel, model, color, range, colorHover); })); </del> <ins> disposables.add(model.onDidChangeColor((color: Color) => { _updateColorPresentations(editorModel, model, color, range, colorHover); })); disposables.add(editor.onDidChangeModelContent((e) => { if (editorUpdatedByColorPicker) { editorUpdatedByColorPicker = false; } else { context.hide(); editor.focus(); } })); </ins> return disposables; }

Discussion:
Construct a file that will be modified when saving (such as by a format-on-save, or other code action set to run on save) Open the color picker Change the color in the color picker (but keeping it open) Press Save to modify the document Change the color again Seems like the original range is being used and not compensating for the changes made in the document. ! If you don't first select a color in the color picker, pressing Save causes it to close. Perhaps that's what should happen in the case where you did pick one too?
Change:
when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), <del> ContextKeyExpr.or( ContextKeyExpr.and( ContextKeyExpr.has(InputFocusedContextKey), EditorContextKeys.editorTextFocus, NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('top'), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('none'), ), ContextKeyExpr.and( NOTEBOOK_CELL_TYPE.isEqualTo('markup'), NOTEBOOK_CELL_MARKDOWN_EDIT_MODE.isEqualTo(false), NOTEBOOK_CURSOR_NAVIGATION_MODE ) ) </del> <ins> ContextKeyExpr.and( ContextKeyExpr.has(InputFocusedContextKey), EditorContextKeys.editorTextFocus, NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('top'), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('none'), ), </ins> ), primary: KeyCode.DownArrow, <del> weight: KeybindingWeight.WorkbenchContrib, </del> <ins> weight: NOTEBOOK_EDITOR_WIDGET_ACTION_WEIGHT, // code cell keybinding, focus inside editor: lower weight to not override suggest widget }, { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), ContextKeyExpr.and( NOTEBOOK_CELL_TYPE.isEqualTo('markup'), NOTEBOOK_CELL_MARKDOWN_EDIT_MODE.isEqualTo(false), NOTEBOOK_CURSOR_NAVIGATION_MODE) ), primary: KeyCode.DownArrow, weight: KeybindingWeight.WorkbenchContrib, // markdown keybinding, focus on list: higher weight to override list.focusDown </ins> }, { when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_OUTPUT_FOCUSED),

Discussion:
Issue Type: <bBug</bWhen using intellisense prompts inside a .ipynb file, I am unable to use the arrow keys to navigate the given prompt. tested by just typing "impo" and then trying to navigate the import autocomplete prompts Unable to repro in the stable release, seems to be just the pre-release version Extension version: 2022.6. VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-21T05:16:12.334Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This sounds like an issue in the editor? Transferring to VS code. This isn't handled by the Jupyter extension.
It happens when there is only a single line in the cell.
Change:
} } <del> const someStepsComplete = this.gettingStartedCategories.some(category => category.steps.find(s => s.done)); </del> if (this.editorInput.showTelemetryNotice && this.productService.openToWelcomeMainPage) { const telemetryNotice = $('p.telemetry-notice'); this.buildTelemetryFooter(telemetryNotice); footer.appendChild(telemetryNotice); <del> } else if (!this.productService.openToWelcomeMainPage && !someStepsComplete && !this.hasScrolledToFirstCategory) { const firstSessionDateString = this.storageService.get(firstSessionDateStorageKey, StorageScope.APPLICATION) || new Date().toUTCString(); const daysSinceFirstSession = ((+new Date()) - (+new Date(firstSessionDateString))) / 1000 / 60 / 60 / 24; const fistContentBehaviour = daysSinceFirstSession < 1 ? 'openToFirstCategory' : 'index'; if (fistContentBehaviour === 'openToFirstCategory') { const first = this.gettingStartedCategories.filter(c => !c.when || this.contextService.contextMatchesRules(c.when))[0]; this.hasScrolledToFirstCategory = true; if (first) { this.currentWalkthrough = first; this.editorInput.selectedCategory = this.currentWalkthrough?.id; this.buildCategorySlide(this.editorInput.selectedCategory, undefined); this.setSlide('details'); return; } } </del> } this.setSlide('categories'); }

Discussion:
This scenario is flaky due to a timing issue between walkthroughs being registered and check for first open. I can repro this occasionally.
I think this should be on the May milestone?
Verification Steps: VS Code with a clean profile that the Setup walkthrough launches on startup. <img width="766" alt="image" src=""
Didn't work for me Mac OS !
I can repro this on the mac. Works as expected on windows.
Change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "5.1.0-beta.15", "xterm-addon-canvas": "0.3.0-beta.1", "xterm-addon-search": "0.11.0-beta.1", </del> <ins> "xterm": "5.1.0-beta.25", "xterm-addon-canvas": "0.3.0-beta.8", "xterm-addon-search": "0.11.0-beta.3", </ins> "xterm-addon-unicode11": "0.5.0-beta.1", <del> "xterm-addon-webgl": "0.14.0-beta.8" </del> <ins> "xterm-addon-webgl": "0.14.0-beta.16" </ins> } }

Discussion:
Testing using canvas render. ! Should the line be continuous even though it overlaps the characters? vs "on": ! I'm talking about characters like and .
I didn't bother adding this to the canvas renderer as it's the fallback which is primarily for iPad atm, nothing stopping it from working there too though. Should really consolidate the rendering code for webgl and canvas as they mostly do the same thing when drawing the actual characters.
The wavy underline looks off with gpu enabled (first example in the attached screenshot). With the canvas setting, it's not rendered at all. !
The look of curly was going to be revisited in
Change:
import * as types from 'vs/base/common/types'; import { URI } from 'vs/base/common/uri'; import { TokenizationResult, TokenizationResult2 } from 'vs/editor/common/core/token'; <del> import { IState, ITokenizationSupport, LanguageId, TokenMetadata, TokenizationRegistry } from 'vs/editor/common/modes'; </del> <ins> import { IState, ITokenizationSupport, LanguageId, TokenizationRegistry, TokenMetadata } from 'vs/editor/common/modes'; </ins> import { nullTokenize2 } from 'vs/editor/common/modes/nullMode'; import { generateTokensCSSForColorMap } from 'vs/editor/common/modes/supports/tokenization'; import { IModeService } from 'vs/editor/common/services/modeService'; <ins> import * as nls from 'vs/nls'; </ins> import { IFileService } from 'vs/platform/files/common/files'; import { ILogService } from 'vs/platform/log/common/log'; import { INotificationService } from 'vs/platform/notification/common/notification'; import { ExtensionMessageCollector } from 'vs/workbench/services/extensions/common/extensionsRegistry'; <del> import { IEmbeddedLanguagesMap, ITMSyntaxExtensionPoint, TokenTypesContribution, grammarsExtPoint } from 'vs/workbench/services/textMate/electron-browser/TMGrammars'; </del> import { ITextMateService } from 'vs/workbench/services/textMate/electron-browser/textMateService'; <ins> import { grammarsExtPoint, IEmbeddedLanguagesMap, ITMSyntaxExtensionPoint, TokenTypesContribution } from 'vs/workbench/services/textMate/electron-browser/TMGrammars'; </ins> import { ITokenColorizationRule, IWorkbenchThemeService } from 'vs/workbench/services/themes/common/workbenchThemeService'; import { IEmbeddedLanguagesMap as IEmbeddedLanguagesMap2, IGrammar, ITokenTypeMap, Registry, StackElement, StandardTokenType } from 'vscode-textmate'; <ins> import { ConfigurationService } from 'vs/platform/configuration/node/configurationService'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> import { Disposable, IDisposable, dispose } from 'vs/base/common/lifecycle'; export class TMScopeRegistry {

Discussion:
Found no duplicated for this one Currently it's hardcoded I propose a config entry for long line length If you're object, I'd like to create pull request for this feature Your thoughts?
I think this makes sense as a workspace setting that defaults to the current value. Feel free to make a PR!
Change:
return $('tr', undefined, $('td', undefined, $('code', undefined, key)), $('td', undefined, description), <del> $('td', undefined, $('code', undefined, `${isUndefined(properties[key].default) ? getDefaultValue(properties[key].type) : properties[key].default}`))); </del> <ins> $('td', undefined, $('code', undefined, `${isUndefined(properties[key].default) ? getDefaultValue(properties[key].type) : JSON.stringify(properties[key].default)}`))); </ins> }) ) );

Discussion:
Reproduction steps: to the extension panel and search some extensions which have contribution points. outliers displayed: ! Version: 1.83.1 Commit: User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Embedder: <!-- generated by web issue reporter --
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .file-icons-enabled .show-file-icons .webview-vs_code_release_notes-name-file-icon.file-icon::before { content: ' '; background-image: url('../../../../browser/media/code-icon.svg'); } </ins>

Discussion:
Issue Type: <bBug</bRelease Notes from Help menu it Release Notes doesn't show an icon on its normal tab, the pinned one is empty. VS Code version: Code - Insiders 1.46.0-insider (, 2020-05-07T16:19:54.327Z) OS version: Windows_NT x64 10.0. ! Compare its appearance to that of my adjacent pinned tab, which is my file (very handy to be able to pin it, kudos to ) <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.669 --- <!-- score: 0.543 --- <!-- score: 0.532 --- <!-- score: 0.455 --<!-- potentialduplicatescomment --
This actually looks like a bug to me, because release notes should have the product icon. Looking into devtools I see it being referenced: ! However, this file does not exist on disk likely because it gets inlined, as you can see in the welcome tab where the icon appears properly: ! Assigning a couple of people to check this.
I should add that I indeed moved this icon to a new place (we had many copies of it). So it could be a regression from that work.
so this is a regression from my push but I think the way the icon is used in here is not ideal because it prevents the image from being inlined: A better solution would be to have it referenced from CSS like we do e.g. in the welcome page: However this would require some name to appear as part of the label we could override. I am not sure how to pass a resource name to the webview? Currently it looks like we add a UUID: ! Open for ideas. Last resort is to just bring back that icon, but then we have it duplicate as before.
This actually has nothing to do with pinned tabs as it appears blank normally: !
Change:
this.contextMenuService.showContextMenu({ getAnchor: () => anchor, getActions: () => Separator.join(...actions), <del> menuActionOptions: { shouldForwardArgs: true }, getActionsContext: () => ({ lineNumber, uri: model.uri }), </del> onHide: () => menu.dispose(), }); });

Discussion:
Testing I first didn't understand this test instruction: so decided to args passed to my extension's command. Somehow, I see two same arguments being passed to the command: gif: https://user- But I may be doing something wrong. (or just recreate) a bare minimal extension, clonable here - with F5 context menu on line number the array with two elements in the dev console.
I could repro this too.
Change:
dependencies: object-keys "~0.4.0" <del> xterm-addon-canvas@0.3.0-beta.33: version "0.3.0-beta.33" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.33.tgz#5f6f673df9f8e9ea82d980a93adb8f0fe1ec5f0f" integrity sha512-nKZ3ieluM6GthY4LCOMF2uWtrHASz6efm9pekgeEmLz5DOINyCBSm2SsPp3s9edLTWMGHp8oe+diSk/+sz65cA== </del> <ins> xterm-addon-canvas@0.3.0-beta.35: version "0.3.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7"

Discussion:
Testing Code insiders, set how the inactive selection colour is stronger than the active selection colour I can only reproduce this with "canvas", all other gpu acceleration options work fine. Terminal focused ! Terminal not focused !
Upstream:
Change:
import { LogLevel as _MainLogLevel } from 'vs/platform/log/common/log'; import { coalesce, isNonEmptyArray } from 'vs/base/common/arrays'; import { RenderLineNumbersType } from 'vs/editor/common/config/editorOptions'; <ins> import { CommandsConverter } from 'vs/workbench/api/common/extHostCommands'; </ins> export interface PositionLike { line: number;

Discussion:
If you return in a completion item, the property is when calling through . Setup: Test code: Output is: Full repro project is here:
It looks like the conversion is missing. The doc states that additionalTextEdits should not overlap with the main edit range or each other, should that be checked or is that done when the edits are carried out? Adding this: ! works, unless the range intersections need to be checked.
No checks required - this is already the way back from the UX and check should have been carried out already
Change:
static readonly TEMPLATE_ID = 'actionButton'; get templateId(): string { return ActionButtonRenderer.TEMPLATE_ID; } <ins> private actionButtons = new Map<ISCMActionButton, SCMActionButton>(); </ins> constructor( @ICommandService private commandService: ICommandService, @IContextMenuService private contextMenuService: IContextMenuService,

Discussion:
This should not be a valid state: ! It should automatically switch to this: ! is how the SCM Input does it.
I am seeing this state when I am navigating using up/down buttons. Is it expected? ! !
That is probably unexpected, but I will let confirm that.
Yeah, just like the text box. The list doesn't support completely disabling it at the model layer. We can only disable it at the click operation.
Change:
} })); this.toUnhook.add(editor.onDidChangeModelContent((e) => { <del> this._stopAll(); </del> <ins> if (!matchesScheme(this.model.uri, 'output')) { this._stopAll(); } </ins> })); this.toUnhook.add(editor.onDidChangeModel((e) => { if (!e.newModelUrl && e.oldModelUrl) {

Discussion:
Version: 1.85.0-insider (user setup) Commit: Date: 2023-11-27T05:35:23.734Z Electron: 25.9.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0. At first I thought this was a bug in the C/C++ Extension's support for document/reference highlighting. I noticed that when I move my cursor to within in a variable, it would actually very quickly highlight the correct content in the document before immediately clearing the highlight. I managed to narrow down the repro to only occurring if the Output pane tab is selected and when there is output occurring to it as (after?) the highlight occurs. Perhaps something related to drawing content to the Output pane is inadvertently de-selecting the doc-highlight.
Change:
result = await fetching(this.getServerUri('/user').toString(), { headers: { Authorization: `token ${token}`, <del> 'User-Agent': 'Visual-Studio-Code' </del> <ins> 'User-Agent': `${vscode.env.appName} (${vscode.env.appHost})` </ins> } }); } catch (ex) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: NA OS Version: NA Steps to Reproduce: The github education team sees about calls from Visual-studio-code in an hour for api/user. This is quite unusual and since we are rate limiting anyway, it is not an immediate issue. From initial discussions with I understand that the call is made only for telemetry and has no impact on the user. So, raising this bug, if we can find a better way to do telemetry without having to rate limit. This here shows some more details.
, can you please help me understand what is the likelihood of this work getting prioritised and by when can we expect to resolve this issue.
I wasn't able to get to it this week during our allocated debt time so I will try again to make time early April. I'll let you know if anything changes.