jiebi/CodeConvo huggingface dataset:
Change:
} if (this.client.apiVersion.has230Features()) { <del> const root = this.client.getWorkspaceRootForResource(this.document.uri); if (root) { args.projectRootPath = root; } </del> <ins> args.projectRootPath = this.client.getWorkspaceRootForResource(this.document.uri); </ins> } if (this.client.apiVersion.has240Features()) {

Discussion:
VSCode Version: Code 1.19.1 (, 2017-12-19T09:46:02.926Z) OS Version: Windows_NT ia32 10.0. Extensions: Extensions are disabled Steps to Reproduce: / Interactive Playground Under heading IntelliSense, the text reads: It it unclear what error underline means, I don't see any underline or error.
I can reproduce on the 2nd time: playground tab playground No errors shown & IntelliSense not working & rename & code formatting & // ts-check ...
Yes, opening playground a second time seems to be key to all the problems I was having with it. Thanks.
VSCode Version: Code - Insiders 1.20.0-insider (, 2017-12-22T06:14:07.615Z) OS Version: Linux x64 4.9.72-1-lts Extensions: none Also happens every time for me in Interactive Playground with no extensions loaded w/ insiders on linux. If restarting vscode repeatedly, sometimes syntax highlight also fails. EDIT: As I continued on down through the document, some other instructions are failing too.
VSCode Version: Code 1.19.1 (, 2017-12-19T09:35:14.671Z) OS Version: Darwin x64 16.7.0 Extensions: none I just got VSCode for the first time, fresh install on macOS, and experienced the same issue with different features in the Interactive Playground described here by the peeps above. Don't have much to add in terms of describing/reproducing the issue, just posting here for completeness that the issue affects 1.19.1 on OSX as well.
I see this when opening without a folder. The missing errors also reproduce in an untitled file in JavaScript mode (code actions seem to work in this case). Code actions do not work in the interactive playground when the workbench is not open on a folder. Could you take a look?
Note that this still requires this upstream fix from TS ()
Change:
.quick-input-list .quick-input-list-entry.has-actions:hover .quick-input-list-entry-action-bar .action-label.dirty-anything::before { content: "ea76"; /* Close icon flips between black dot and "X" for dirty open editors */ <ins> font-family: 'codicon'; </ins> }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Windows 10 / macOS Sonoma Steps to Reproduce: at least three windows the command least one of the windows will show a strange close icon, instead of the regular one, like the image below ! I reproduced the same error on Windows, and it also presented a strange icon, but it was a different one. A small vertical rectangle, like that missing unicode chars. I tested the on Insiders release, at least on MacOS, and didn't notice the error. I didn't have the opportunity to test in Insiders on Windows yet. I'll update the issue later with more details. Thank you
are you using a product icon extension?
Nevermind, a regression from , fyi
Hi , Glad to know you could find the fix. Let me know if you need me to verify it when released. Thank you
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
} })); <ins> this._register(toDisposable(() => { this.cache.clear(); })); </ins> this._register(this.editor.onDidChangeCursorPosition((e) => { if (this.cache.value) { this.onDidChangeEmitter.fire();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !
Please let me know soon if we should release this with our Recovery Release tomorrow!
Thanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!
can you verify that the issue is fixed in todays insider build?
As he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!
Change:
} } <del> export class NotebookCellOutline extends Disposable implements IOutline<OutlineEntry> { </del> <ins> export class NotebookCellOutline implements IOutline<OutlineEntry> { </ins> <del> private readonly _onDidChange = this._register(new Emitter<OutlineChangeEvent>()); </del> <ins> private readonly _dispoables = new DisposableStore(); private readonly _onDidChange = new Emitter<OutlineChangeEvent>(); </ins> readonly onDidChange: Event<OutlineChangeEvent> = this._onDidChange.event; private _uri: URI | undefined; private _entries: OutlineEntry[] = []; private _activeEntry?: OutlineEntry; <del> private readonly _entriesDisposables = this._register(new DisposableStore()); </del> <ins> private readonly _entriesDisposables = new DisposableStore(); </ins> readonly config: IOutlineListConfig<OutlineEntry>; readonly outlineKind = 'notebookCells';

Discussion:
Testing Setting Open a github issue notebook You get: <img width="283" alt="image" src="https://user-"
Change:
this.emptyPaneMessageElement!.style.backgroundColor = ''; if (this.paneCompositeBar.value) { this.paneCompositeBar.value.dndHandler.drop(e.dragAndDropData, undefined, e.eventData); <ins> } else { // Allow opening views/composites if the composite bar is hidden const dragData = e.dragAndDropData.getData(); if (dragData.type === 'composite') { const currentContainer = this.viewDescriptorService.getViewContainerById(dragData.id)!; this.viewDescriptorService.moveViewContainerToLocation(currentContainer, this.location, undefined, 'dnd'); this.openPaneComposite(currentContainer.id, true); } else if (dragData.type === 'view') { const viewToMove = this.viewDescriptorService.getViewDescriptorById(dragData.id)!; if (viewToMove && viewToMove.canMoveView) { this.viewDescriptorService.moveViewToLocation(viewToMove, this.location, 'dnd'); const newContainer = this.viewDescriptorService.getViewContainerByViewId(viewToMove.id)!; this.openPaneComposite(newContainer.id, true).then(composite => { composite?.openView(viewToMove.id, true); }); } } </ins> } }, }));

Discussion:
Type: <bBug</bWhen the activity bar is hidden () I cannot drag views to the secondary side bar. This occurs in the current version 1.91.1 and 1.92.0-insider build. I am attaching a screen recording as well which clearly demonstrates the issue. VS Code version: Code - Insiders 1.92.0-insider (Universal) (, 2024-07-19T05:03:57.939Z) OS version: Darwin arm64 23.2.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ vscode-eslint3.0.10 vscode-graphql0.11.0 vscode-graphql-syntax1.3.6 vscode-yaml1.15.0 vscode-stylelint1.4.0 shellcheck0.37.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I'm having the same issue with .
Having same issue with "workbench.activityBar.location": "default"
Change:
import { Codicon } from 'vs/base/common/codicons'; import { Emitter, Event } from 'vs/base/common/event'; import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; <ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { labelForHoverVerbosityAction } from 'vs/editor/contrib/hover/browser/markdownHoverParticipant'; </ins> namespace HoverAccessibilityHelpNLS { export const intro = localize('intro', "Focus on the hover widget to cycle through the hover parts with the Tab key.");

Discussion:
Testing the keybinding for verbosity hover over =Shows the keybinding accessibility view of the hover focus to the by clicking A hover for the action shows without the keybinding !
Change:
} } })); <del> this.disposables.add(this.model.onDidChangeBreakpoints(() => setBreakpointsExistContext())); </del> this.disposables.add(editorService.onDidActiveEditorChange(() => { this.contextKeyService.bufferChangeEvents(() => {

Discussion:
The debug viewlet breaks and does not load when the window is loaded with that viewlet visible Reload window with debug viewlet visible DebugActionViewItem is created, requires DebugService DebugService is instantiated, sets some context keys The context keys cause the debug view to refresh, the toolbar in the view header wants to refresh its actions, this leads to creating DebugActionViewItem again DebugService is not done being instantiated, so we try to instantiate a second one Repeat The context keys maybe should not be owned by the service, but could be a separate contribution
I think this was technically caused by , causing the DebugService to be created a little later than it was before. FYI My PR makes it happen a little more often, since otherwise the editor contribs might cause DebugService to be instantiated early, but I can repro this without my PR. I think the context keys can live in a separate workbench contrib that depends on DebugService, and listens to its events to update the keys.
The stack
That or don't set them from within the ctor but after your object/services is initialized (and cached)
Change:
]); userDataProfilesService.setEnablement(!!configurationService.getValue(PROFILES_ENABLEMENT_CONFIG)); <ins> this._register(configurationService.onDidChangeConfiguration(e => { if (e.affectsConfiguration(PROFILES_ENABLEMENT_CONFIG)) { userDataProfilesService.setEnablement(!!configurationService.getValue(PROFILES_ENABLEMENT_CONFIG)); } })); </ins> // !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! //

Discussion:
to the Settings editor on the setting . :bug: The user isn't prompted to restart the editor, so they end up encountering glitchy behaviour.
Change:
} try { <del> await Promise.all(this._getCustomTaskPromises(Array.from(await this.getWorkspaceTasks()), filter, result, contributedTasks, waitToActivate)); </del> <ins> let tasks: [string, IWorkspaceFolderTaskResult][] = []; // prevent workspace trust dialog from being shown in unexpected cases #224881 if (!knownOnlyOrTrusted || this._workspaceTrustManagementService.isWorkspaceTrusted()) { tasks = Array.from(await this.getWorkspaceTasks()); } await Promise.all(this._getCustomTaskPromises(tasks, filter, result, contributedTasks, waitToActivate)); </ins> if (needsRecentTasksMigration) { // At this point we have all the tasks and can migrate the recently used tasks. await this._migrateRecentTasks(result.all());

Discussion:
a repo in :bug: see this !
This is expected if the repo that you open has tasks that run on . Could you pls provide me with a repo for which this happens that doesn't have those?
seeing this dialog when I just open a folder, so wondering if something with workspace trust has changed recently. No changes with tasks recently could explain this. !
Doesn't repro in , repros in : Bad: Good:
found these task PRs in that time frame: ,
found it also happens in an empty window on desktop
Still seeing this in (and also RemoteHub on desktop) with the changes in !
This is coming from -here. perhaps we don't want to do that for the or only do that in trusted workspaces? !
Change:
}, delay); }; <ins> let isMouseDown = false; const mouseDownEmitter = dom.addDisposableListener(htmlElement, dom.EventType.MOUSE_DOWN, () => { isMouseDown = true; hideHover(true, true); }, true); const mouseUpEmitter = dom.addDisposableListener(htmlElement, dom.EventType.MOUSE_UP, () => { isMouseDown = false; }, true); const mouseLeaveEmitter = dom.addDisposableListener(htmlElement, dom.EventType.MOUSE_LEAVE, (e: MouseEvent) => { isMouseDown = false; hideHover(false, (<any>e).fromElement === htmlElement); }, true); </ins> const onMouseOver = () => { if (hoverPreparation) { return;

Discussion:
! It's those 3 options that don't work, until there are multiple shells running. Once you have two or more shells, those options start working, as below I'm showing me renaming successfully the 2nd shell: ! Originally posted by in
I think related to this
PR fixing it
moving the issue with to this issue as it's not a recent regression
Change:
this.repository.operations.isRunning(OperationKind.Push) || this.repository.operations.isRunning(OperationKind.Pull); <del> this.state = { ...this.state, isCommitInProgress, isSyncInProgress }; </del> <ins> this.state = { ...this.state, isCheckoutInProgress, isCommitInProgress, isSyncInProgress }; </ins> } private onDidChangeSmartCommitSettings(): void {

Discussion:
Type: <bBug</bto an existing branch from . Control Side panel then shows Sync Changes button. , clicking on Sync button causes to commits from previous branch to merge into current branch VS Code version: Code 1.74.3 (, 2023-01-09T16:59:02.252Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ laravel-blade1.1.2 jupyter-keymap1.0.0 remote-wsl0.72.0 alignment0.3.0 vscode-log-viewer0.12.2 vscode-intelephense-client1.9.4 gitlens13.2.0 cmake-tools1.13.44 cpptools1.13.9 cpptools-extension-pack1.3.0 laravel-blade1.32.0 cmake0.0.17 php-debug1.30.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
public dispose(): void { this.toDispose = dispose(this.toDispose); super.dispose(); } }  No newline at end of file

Discussion:
New SelectBox custom implementation creates a circular disposal since toDispose is still passed to the select box delegate where the class objects are into the disposable list which is really the parents list. Steps to Reproduce: code, open a terminal (instantiates the drop-down lists) panel (disposes SelectBox) gives a stack err, panel becomes blank and unusable shows an infinite disposal loop. Debug on disposal: [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14",

source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.475:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.475:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.476:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.476:INFO:CONSOLE(85)] "Maximum call stack size exceeded: RangeError: Maximum call stack size exceeded at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-) at SelectBoxList.dispose (file:///C:/VSC Dev/vc-fork-) at file:///C:/VSC Dev/vc-fork- at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-) at SelectBoxList.dispose (file:///C:/VSC Dev/vc-fork-) at file:///C:/VSC Dev/vc-fork- at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-)", source: file:///C:/VSC Dev/vc-fork- (85)
Fixed with
Change:
// Shared before/after handling installAllHandlers(logger); <del> // skipped until translations are available https://github.com/microsoft/vscode/issues/150324 it.skip('starts with "DE" locale and verifies title and viewlets text is in German', async function () { </del> <ins> it('starts with "DE" locale and verifies title and viewlets text is in German', async function () { </ins> const app = this.app as Application; await app.workbench.extensions.openExtensionsViewlet();

Discussion:
I'm building a custom Insiders to test one of the changes. The Linux localization smoke test seems to be failing consistently Edit: This result is likely a false positive. I think I forgot to update the branch.
Change:
|| oldBottomToolbarDimensions.bottomToolbarHeight !== newBottomToolbarDimensions.bottomToolbarHeight) { this._styleElement?.remove(); this._createLayoutStyles(); <del> this._webview?.updateOptions(this.notebookOptions.computeWebviewOptions()); </del> <ins> this._webview?.updateOptions({ ...this.notebookOptions.computeWebviewOptions(), fontFamily: this._generateFontFamily() }); </ins> } type WorkbenchNotebookOpenClassification = { scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider (Universal) Commit: OS Version: Mac OS Monterey 12.2.1 Follow up issue to as this is a degradation in UX compared to the non-Insider version. Any input on that ? Current: ! Expected: Different columns should be aligned !
thank you for the bug report!
Change:
this._extensionHost = extensionHost; this.kind = this._extensionHost.kind; this.onDidExit = this._extensionHost.onExit; <ins> const startingTelemetryEvent: ExtensionHostStartupEvent = { time: Date.now(), action: 'starting', kind: extensionHostKindToString(this.kind) }; this._telemetryService.publicLog2<ExtensionHostStartupEvent, ExtensionHostStartupClassification>('extensionHostStartup', startingTelemetryEvent); </ins> this._proxy = this._extensionHost.start()!.then( (protocol) => { this._hasStarted = true; <ins> // Track healthy extension host startup const successTelemetryEvent: ExtensionHostStartupEvent = { time: Date.now(), action: 'success', kind: extensionHostKindToString(this.kind) }; this._telemetryService.publicLog2<ExtensionHostStartupEvent, ExtensionHostStartupClassification>('extensionHostStartup', successTelemetryEvent); </ins> return { value: this._createExtensionHostCustomers(protocol) }; }, (err) => { console.error(`Error received from starting extension host (kind: ${this.kind})`); console.error(err); <ins> // Track errors during extension host startup const failureTelemetryEvent: ExtensionHostStartupEvent = { time: Date.now(), action: 'error', kind: extensionHostKindToString(this.kind) }; if (err && err.name) { failureTelemetryEvent.errorName = err.name; } if (err && err.message) { failureTelemetryEvent.errorMessage = err.message; } if (err && err.stack) { failureTelemetryEvent.errorStack = err.stack; } this._telemetryService.publicLog2<ExtensionHostStartupEvent, ExtensionHostStartupClassification>('extensionHostStartup', failureTelemetryEvent, true); </ins> return null; } );

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Add telemetry at the startup of an extension host to know that the startup was begun. Add telemetry when the extension host is successfully started. Add telemetry when the extension host failed to start. This enables determining the success/failure rate of extension host startup as well as grouping of failure reasons to debug issues in the field.
Change:
for (const id in colors) { const colorVal = colors[id]; if (colorVal === DEFAULT_COLOR_CONFIG_VALUE) { <del> delete this.colorMap[id]; </del> <ins> this.customColorMap[id] = DEFAULT_COLOR_CONFIG_VALUE; </ins> } else if (typeof colorVal === 'string') { this.customColorMap[id] = Color.fromHex(colorVal); }

Discussion:
From Add to setting See that the editor background changes to the 'default' gray color Comment or delete the setting The background color doesn't change back to the theme color, and I can't make it go back until reloading the window
Change:
{ "command": "git.openChange", "group": "navigation", <del> "when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0 && !isInDiffEditor && resourceScheme == file && scmActiveResourceHasChanges" </del> <ins> "when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0 && !isInDiffEditor && !isMergeEditor && resourceScheme == file && scmActiveResourceHasChanges" </ins> }, { "command": "git.stageSelectedRanges",

Discussion:
We have the extension which highlights git merge markers (using codelens and decorations) and we adds conflict navigation commands. This conflicts with the new merge editor and we should find ways to suppress it when merge is being used, e.g hide commands based on the context key
fyi - we did push some pragmatic changes to the merge-conflict extension to disable itself when the user enables the experimental git merge editor...