jiebi/CodeConvo huggingface dataset:
Change:
} .preferences-editor > .preferences-editors-container.side-by-side-preferences-editor { <del> position: relative; </del> <ins> flex: 1; </ins> } .preferences-editor > .preferences-editors-container.side-by-side-preferences-editor .preferences-header-container {

Discussion:
Issue Type: <bBug</bI believe this just started, but I can no longer resize the split editor via the middle bar. Diff editor still works, and it works fine in stable as well. VS Code version: Code - Insiders 1.39.0-insider (, 2019-09-09T17:00:17.505Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Not sure which editor you mean... what steps are you doing to get to that UI?
From the command palette, Preferences: Open Settings (JSON) !
does that provide what you need?
For some reason I no longer can open that view... it always opens a regular editor, not that old settings editor.
now you have to set . I can reproduce but haven't changed it,
Aha! Couldn't find the name of that setting...
Since I investigated it I ended up just making a fix for it. Not sure why it broke tho.
Change:
for (const extension of extensionsToUninstall) { const dependents = this.getDependents(extension, installed); if (dependents.length) { <del> const remainingDependents = dependents.filter(dependent => extensionsToUninstall.indexOf(dependent) === -1); </del> <ins> const remainingDependents = dependents.filter(dependent => !extensionsToUninstall.some(e => areSameExtensions(e.identifier, dependent.identifier))); </ins> if (remainingDependents.length) { throw new Error(this.getDependentsErrorMessage(extension, remainingDependents, extensionToUninstall)); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --OS version: Darwin x64 20.5.0 This is originally reported on This is a new release issue (1.59) as I have tested on 1.58. Steps to Reproduce: extension to uninstall VSpaceCode I get the following error: !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.531 --- <!-- score: 0.445 --<!-- potentialduplicatescomment --
Related to
Thanks for filing the bug and also providing the fix. I will be pushing the fix to insiders which will be available tomorrow and fix will be included in next stable. Here is a workaround for now to use in stable - To uninstall open extensions folder using command and remove the extension.
Change:
export class ObjectTree<T extends NonNullable<any>, TFilterData = void> extends AbstractTree<T | null, TFilterData, T | null> { <del> declare model: IObjectTreeModel<T, TFilterData>; </del> <ins> protected declare model: IObjectTreeModel<T, TFilterData>; </ins> override get onDidChangeCollapseState(): Event<ICollapseStateChangeEvent<T | null, TFilterData>> { return this.model.onDidChangeCollapseState; }

Discussion:
This is a follow-up on and where I simply make the model-property of the tree public. Tho, a better fix might be needed here
Change:
description: nls.localize('terminal.integrated.experimentalBufferImpl', "Controls the terminal's internal buffer implementation. This setting is picked up on terminal creation and will not apply to existing terminals."), type: 'string', enum: ['JsArray', 'TypedArray'], <del> default: 'JsArray' </del> <ins> default: 'TypedArray' </ins> }, 'terminal.integrated.splitCwd': { description: nls.localize('terminal.integrated.splitCwd', "Controls the working directory a split terminal starts with."),

Discussion:
Testing should focus on resizing the terminal as well as inputting emoji, CJK and "high plane chars" (those with a char code above ).
Been playing with this option. I have to say the perf is quite amazing. I'm very impressed that the vscode terminal is actually faster than than both iTerm and built-in Mac OSX terminal. That's what I love about vscode. It's attention to perf. Thank you!
glad to hear you've been testing it out! Much more in the works This particular one was pretty much all
Thx We still have a few more perf gems to come with the next releases, stay tuned :smiley_cat: And thx for testing, we need every helping hand to cover the edge cases, esp. for those bigger changes.
Btw I used vscode terminal extensively to test v2 of matrix-rain. You can try it at Vscode terminal is the fastest out of iTerm and macOS Terminal app. So looking forward to a super fast terminal (hopefully standalone someday).
nice! will make it even better when that eventually goes in
I removed the JsArray completely as TypedArray is very stable at this point.
Change:
instantiationService.stub(IProgressService, ProgressService); instantiationService.stub(ISCMService, SCMService); instantiationService.stub(IEnvironmentService, TestEnvironmentService); <ins> instantiationService.stub(IDialogService, new class extends mock<IDialogService>() { override async show() { return { choice: 1 }; } }); </ins> instantiationService.stub(IConfigurationService, new TestConfigurationService({ workbench: { experimental: { editSessions: { enabled: true } } } })); instantiationService.stub(IWorkspaceContextService, new class extends mock<IWorkspaceContextService>() { override getWorkspace() {

Discussion:
Testing Continue from web inside desktop Let the window sit Install update (which restarts the App) you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code) Ideas don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus don't show this when my local changes are no different to those on the server <img width="1391" alt="Screenshot 2022-08-24 at 09 26 13" src="https://user-"
Is the custom modal overlay the same thing as the custom modal dialog, i.e. :+1: I filed for this.
Change:
try { await shell.trashItem(filePath); } catch (error) { <del> throw createFileSystemProviderError(isWindows ? localize('binFailed', "Failed to move '{0}' to the recycle bin", basename(filePath)) : localize('trashFailed', "Failed to move '{0}' to the trash", basename(filePath)), FileSystemProviderErrorCode.Unknown); </del> <ins> throw createFileSystemProviderError(isWindows ? localize('binFailed', "Failed to move '{0}' to the recycle bin ({1})", basename(filePath), toErrorMessage(error)) : localize('trashFailed', "Failed to move '{0}' to the trash ({1})", basename(filePath), toErrorMessage(error)), FileSystemProviderErrorCode.Unknown); </ins> } }

Discussion:
Type: <bBug</bSince I've upgraded from Ventura to Sonoma, files must be deleted permanently. They can no longer be moved to trash. I'm seeing the following in the dev console: <img width="498" alt="Screenshot 2024-03-06 at 12 26 09 PM" src=""VS Code version: Code 1.87.0 (, 2024-02-27T23:42:51.279Z) OS version: Darwin arm64 23.3.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ theme-verdandi2.0.1 markdown-preview-github-styles2.0.3 vscode-eslint2.4.4 gitlens14.8.2 prettier-vscode10.1.0 copilot1.172.0 copilot-chat0.13.0 vscode-graphql-syntax1.3.4 vscode-scss0.10.0 debugpy2024.2.0 python2024.2.1 scala0.5.7 errorlens3.16.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
unfortunately we failed to log the actual error, but I have pushed a change for that. Can you test this scenario using latest insiders and report what you get as error? You can give our preview releases a try from:
Gahhh and, of course, now it works fine. I'm unaware of what changed since I logged this bug? I haven't had any system updates or VSCode updates that I'm aware of. Chrome has been updated, and I don't know if Electron shares code with it that might have impacted anything but I doubt it, given this was a file system issue... Thank you so much for trying to run this down, though. I appreciate you adding logging on a quick turnaround into the insiders edition. I'm not sure if there's anything else you might want to explore with this, but I'm happy to call this closed and write it off to the gods.
Change:
@IQuickInputService private readonly quickInputService: IQuickInputService, @ILogService private readonly logService: ILogService, @IProgressService private readonly progressService: IProgressService, <del> @IPaneCompositePartService private readonly paneCompositeService: IPaneCompositePartService </del> <ins> @IPaneCompositePartService private readonly paneCompositeService: IPaneCompositePartService, @IDialogService private readonly dialogService: IDialogService </ins> ) { this._installedExtensions = extensionManagementService.getInstalled().then(installed => { const result = new Set<string>();

Discussion:
Pre-req: Settings Sync on brand new empty profile a theme Settings sync asks this strange question: ! Additionally: this dialog Theme is still applied but not installed
I tried and can't repro. Are there any specific steps you followed?
were there specific steps to repro this?
I can verify that cancelling the dialog no longer leaves the theme applied, thanks I can still reproduce the main issue though. Why would I not want to synchronize the theme I just picked for my brand new profile, given the profile is being synced?
I think is using the general extension install command that will ask user to sync or not before installing. If it is in core, one can use the API directly to install.
I think we still want an install confirmation dialog, but I agree that there should be no question about syncing.
Change:
}], properties: { id: { <del> description: nls.localize('vscode.extension.contributes.terminal.quickFixes.id', "The ID of the quick fix provider."), </del> <ins> description: nls.localize('vscode.extension.contributes.terminal.quickFixes.id', "The ID of the quick fix provider"), </ins> type: 'string', }, commandLineMatcher: { <del> description: nls.localize('vscode.extension.contributes.terminal.quickFixes.commandLineMatcher', "The regular expression to test the command line against."), </del> <ins> description: nls.localize('vscode.extension.contributes.terminal.quickFixes.commandLineMatcher', "A regular expression or string to test the command line against"), </ins> type: 'string', }, outputMatcher: { <del> markdownDescription: nls.localize('vscode.extension.contributes.terminal.quickFixes.outputMatcher', "The regular expression to test the output against, which provides groups to be referenced in terminalCommand and uri.nnFor example:nn `lineMatcher: /git push --set-upstream origin (?<branchName>[^s]+)/;`nn`terminalCommand: 'git push --set-upstream origin ${group:branchName}';`n"), </del> <ins> markdownDescription: nls.localize('vscode.extension.contributes.terminal.quickFixes.outputMatcher', "A regular expression or string to test the output against, which provides groups to be referenced in terminalCommand and uri.nnFor example:nn `lineMatcher: /git push --set-upstream origin (?<branchName>[^s]+)/;`nn`terminalCommand: 'git push --set-upstream origin ${group:branchName}';`n"), </ins> type: 'object', required: ['lineMatcher', 'anchor', 'offset', 'length'], properties: { lineMatcher: { <del> description: 'The command line to match', </del> <ins> description: 'A regular expression or string to test the command line against', </ins> type: 'string' }, anchor: {

Discussion:
Testing <img width="271" alt="image" src="https://user-"
butter <img width="547" alt="image" src="https://user-"and this one ends in a period where others don't
<img width="237" alt="image" src="https://user-"This one isn't clear, I guess if true, it will only match when the exit code is non-zero?
And the "matcher" props should state that they accept regex
id of the provider? <img width="181" alt="image" src="https://user-"
I think this is referring to some outdated names, I don't see , and I don't see the named group in the result that the provider gets <img width="555" alt="image" src="https://user-"
I think shouldn't say it is "the regular expression", and it's not clear what and are referring to here. <img width="565" alt="image" src="https://user-"hasn't changed <img width="225" alt="image" src="https://user-"
Change:
return; } <del> let result: string | undefined; const allChoices = Array.from(choices.keys()); switch (type) { case 'error': result = await window.showErrorMessage(message, options, ...allChoices); break; case 'warning': result = await window.showWarningMessage(message, options, ...allChoices); break; case 'information': result = await window.showInformationMessage(message, options, ...allChoices); break; } if (result) { const resultFn = choices.get(result); resultFn?.(); } </del> <ins> // We explicitly do not await this promise, because we do not // want the command execution to be stuck waiting for the user // to take action on the notification. this.showErrorNotification(type, message, options, choices); </ins> }); };

Discussion:
commit action button is doing “Commit & Sync” is a conflicting change on the remote the file, write a commit message, and CTRL + ENTER succeeded, but the sync operation results in a merge conflict
Change:
"prefix": "forin", "body": [ "for (const ${1:key} in ${2:object}) {", <del> "tif (${2:object}.hasOwnProperty(${1:key})) {", </del> <ins> "tif (Object.hasOwnProperty.call(${2:object}, ${1:key})) {", </ins> "ttconst ${3:element} = ${2:object}[${1:key}];", "tt$0", "t}",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello! I noticed that the current for in snippet uses the object.hasOwnProperty(), which can lead to a security vulnerability described here: I'm proposing a change to Object.hasOwnProperty.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { env, ExtensionContext, workspace, window, Disposable, commands, Uri, version as vscodeVersion, WorkspaceFolder, LogOutputChannel, l10n, LogLevel } from 'vscode'; </del> <ins> import { env, ExtensionContext, workspace, window, Disposable, commands, Uri, version as vscodeVersion, WorkspaceFolder, LogOutputChannel, l10n, LogLevel, languages } from 'vscode'; </ins> import { findGit, Git, IGit } from './git'; import { Model } from './model'; import { CommandCenter } from './commands';

Discussion:
Testing I'd love it if these were clickable and brought me to the file it's talking about. ! Should be able to use a link provider, right?
Change:
import { readFile, exists } from 'vs/base/node/pfs'; import * as path from 'vs/base/common/path'; import { isString } from 'vs/base/common/types'; <ins> import { getCaseInsensitive } from 'vs/base/common/objects'; </ins> let mainProcessParentEnv: IProcessEnvironment | undefined;

Discussion:
Connect a mac-windows SSH remote Open terminal See this popup ! So fails here because it checks ".PATH" on the environment when this is actually "Path" on windows. has special behavior where it resolves property accesses in a case-insensitive way on Windows. We changed many accesses from using to a constructed environment object, and need the same behavior there.
is this a mac-specific issue or are there steps to repro/verify on Windows?
Can't be verified on windows. Thanks
Change:
} async run(accessor: ServicesAccessor, eventOrOptionsOrProfile: MouseEvent | ICreateTerminalOptions | ITerminalProfile | { profileName: string } | undefined, profile?: ITerminalProfile) { const terminalService = accessor.get(ITerminalService); <ins> if (!terminalService.isProcessSupportRegistered) { return; } </ins> const terminalGroupService = accessor.get(ITerminalGroupService); const workspaceContextService = accessor.get(IWorkspaceContextService); const commandService = accessor.get(ICommandService); let event: MouseEvent | PointerEvent | KeyboardEvent | undefined; let options: ICreateTerminalOptions | undefined; <ins> let instance: ITerminalInstance | undefined; let cwd: string | URI | undefined; </ins> if (typeof eventOrOptionsOrProfile === 'object' && eventOrOptionsOrProfile && 'profileName' in eventOrOptionsOrProfile) { const config = terminalService.availableProfiles.find(profile => profile.profileName === eventOrOptionsOrProfile.profileName); if (!config) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
} } <del> private _selectFoldingRangeProvider(providers: FoldingRangeProvider[], document: ITextModel): FoldingRangeProvider[] { </del> <ins> private _selectFoldingRangeProvider(providers: FoldingRangeProvider[], document: ITextModel): FoldingRangeProvider[] | undefined { </ins> const value = this._configurationService.getValue<string>(DefaultFoldingRangeProvider.configName, { overrideIdentifier: document.getLanguageId() }); if (value) { return providers.filter(p => p.id === value); } <del> return providers; </del> <ins> return undefined; </ins> } }

Discussion:
a folding range provider that conditionally contributes ranges or undefined and ensure no other is contributing any ranges. a file for which the custom will return undefined so that the default folding regions are shown. another file for which the custom does return ranges. -open the first file :bug: folding regions are not shown !
Change:
return encodeURI(attr).replaceAll('"', '&quot;'); } <del> function escapeMarkdownLinkPath(mdPath: string, isExternalLink: boolean): string { </del> <ins> function escapeMarkdownLinkPath(mdPath: string): string { </ins> if (needsBracketLink(mdPath)) { return '<' + mdPath.replaceAll('<', '<').replaceAll('>', '>') + '>'; } <del> return isExternalLink ? mdPath : encodeURI(mdPath); </del> <ins> return mdPath; </ins> } function escapeBrackets(value: string): string {

Discussion:
Type: <bBug</bFile names do not load properly when calling double-byte filenames in Markdown It would be great if Markdown could show double-byte file names when we load them up, just like in VS Code Explorer Markdown file -and-drop to embed double-byte files names do not load properly when calling double-byte filenames in Markdown ! VS Code version: Code 1.84.2 (Universal) (, 2023-11-09T10:52:33.687Z) OS version: Darwin arm64 23.1.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ vscode-django1.14.0 markdown-preview-github-styles2.0.3 python-environment-manager1.2.4 python-extension-pack1.7.0 codespaces1.16.2 copilot1.139.0 copilot-chat0.10.2 vscode-pull-request-github0.76.1 vscode-power-mode3.0.2 vsc-python-indent1.18.0 node-module-intellisense1.5.0 vscode-language-pack-ja1.84. vscode-kubernetes-tools1.3.15 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.10.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.321.0 atom-keybindings3.3.0 vsliveshare1.0.5896 autodocstring0.6.1 vscode-yaml1.14.0 code-spell-checker3.0.1 vscode-pets1.25.1 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 jinja0.0.8 markdown-pdf1.5.0 markdown-all-in-one3.5.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you please share an example file name as text so I can try to easily reproduce this Also is the issue that the file doesn't load in the preview or that the wrong path is inserted when you drop the file into the markdown editor
I'm having the same problem. Below is an example of a Japanese file name: audio.mp3 Below is a quick hack that will get you the desired result. Added decodeURI when creating a link on the editor. I hope you can decide whether it is helpful or not. <img width="1318" alt="image" src=""Version: 1.86.0 Commit: Unknown Date: Unknown Electron: 27.1.3 ElectronBuildId: undefined Chromium: 118.0.5993.159 18.17.1 V8: 11.8.172.18-electron.0 OS: Darwin arm64 23.1.0
Thanks Will check in a fix for the next insiders build
The hover in the preview still shows encoded characters. Let me know if this i under out control and I should file and issue. !
Change:
testService.excluded.onTestExclusionsChanged, )(this.tree.refilter, this.tree)); <ins> this._register(this.tree.onMouseDblClick(e => { if (e.element instanceof TestItemTreeElement && !e.element.children.size && e.element.test.item.uri) { commandService.executeCommand('vscode.revealTest', e.element.test.item.extId); } })); </ins> this._register(this.tree); this._register(this.onChangeWelcomeVisibility(e => {

Discussion:
Testing microsoft/vscode-python Here: !
ideas on this? I provided the path to the file so the "Go to test..." works ( confirm if this is not the case). Thanks!
This works fine via double click but for example does not open on macOS. This works in other trees as standard gesture to open. To make this easy to adopt for trees, I think we have a convention in custom trees, not sure if they are used here. do you remember?
Yes, if you set the command of the tree item in extension provided trees to or then we do some magic and respect the arguments to those commands as outlined at and also respect things like double click and ctrl+click. Here is how we pass the click properties to those commands: