jiebi/CodeConvo huggingface dataset:
Change:
DOM.hide(this.templateData.runButtonContainer); DOM.show(this.templateData.collapsedPart); DOM.show(this.templateData.outputContainer); <del> this.templateData.container.classList.toggle('collapsed', true); </del> this._outputContainerRenderer.viewUpdateShowOutputs(); <del> this.updateInputCollaseElement(); </del> <ins> this.updateInputCollapseElement(); </ins> this.relayoutCell(); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59-Insider OS Version: Windows 10 Steps to Reproduce: a notebook a cell cells are rotated 270 degrees. Seems to be because we use the 'collapsed' classname for cell collapse, and loads a stylesheet which applies to the classname. This stylesheet is not loaded in desktop VS Code so the problem seems to only impact Codespaces This is particularly unfortunate for the interactive window because all code cell inputs are collapsed by default, but it also impacts any collapsed cell in native notebooks all up. !
I filed this a long time ago, but this is pretty bad, I will just change the styles to work around it in the meantime
fix proposal from
Change:
}); model.pushStackElement(); <del> editor._getViewModel().setCursorStates('moveWordCommand', CursorChangeReason.NotSet, result.map(r => CursorState.fromModelSelection(r))); </del> <ins> editor._getViewModel().setCursorStates('moveWordCommand', CursorChangeReason.Explicit, result.map(r => CursorState.fromModelSelection(r))); </ins> if (result.length === 1) { const pos = new Position(result[0].positionLineNumber, result[0].positionColumn); editor.revealPosition(pos, ScrollType.Smooth);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Steps to Reproduce: the cursor with arrow keys (no modifiers) onto a word then stop after a moment it will highlight other matches that are visible on screen (or in the whole file, with the scrollbar markers) particular, notice that if you stop on the edge of a word, it will still highlight it. , move around with ctrl+left or ctrl+right. You will only be able to stop on word edges in this case. that in this case, no highlight happens, unlike when you land on a word edge by moving only with arrows. , if you move the cursor more than one character in other ways (f.e. you use VS Code APIs to programmatically move the cursor), no highlight happens. As an effect of this, plugins like (which move the cursor in custom ways) will not show any highlight when moving more than one character (or line) at a time. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
In the following example recording, first I move character by character with the left and right arrows keys, and when I stop moving, you see that highlight works. In the last half of the recording I move with ctrl + arrow keys, in which case no highlight happens when I stop moving: !
Change:
import { ContextKeyExpr, IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IProductService } from 'vs/platform/product/common/productService'; import { Registry } from 'vs/platform/registry/common/platform'; <del> import { IUserDataProfilesService, PROFILES_ENABLEMENT_CONFIG } from 'vs/platform/userDataProfile/common/userDataProfile'; </del> <ins> import { IUserDataProfile, IUserDataProfilesService, PROFILES_ENABLEMENT_CONFIG } from 'vs/platform/userDataProfile/common/userDataProfile'; </ins> import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { RenameProfileAction } from 'vs/workbench/contrib/userDataProfile/browser/userDataProfileActions';

Discussion:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified
Change:
data.thread.title = localize('thread', "Thread"); data.label.set(thread.name, createMatches(element.filterData)); data.stateLabel.textContent = thread.stateLabel; <ins> data.stateLabel.classList.toggle('exception', thread.stoppedDetails?.reason === 'exception'); </ins> data.actionBar.clear(); this.callStackItemType.set('thread');

Discussion:
Issue Type: <bBug</bDebug a program that throws an exception (any language). Hover over the paused message text. Expected: (this screenshot is from v1.49.0) The 'Text' information to be displayed on hover. The color of the pause message background to be 'red'. ! Got: The same name shown on hover. The color of the pause message background was grey. ! VS Code version: Code 1.56.0 (, 2021-05-04T22:06:21.189Z) OS version: Darwin x64 20.4.0 <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ gitlens11.4.1 EditorConfig0.16.4 prettier-vscode6.4.0 vscode-diff1.4.1 go-nightly2021.5.1113 cloudcode1.11.1 vscode-docker1.12.1 python2021.5. vscode-pylance2021.5.1 jupyter2021.6. remote-containers0.177.2 remote-ssh0.65.4 remote-ssh-edit0.65.4 remote-wsl0.56.2 vscode-remote-extensionpack0.21.0 vscode-typescript-tslint-plugin1.3.3 reload0.0.6 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
The information displayed on the hover now seems to be the file name rather than the Python exception type, at least within Codespaces. is this expected behaviour?
/verified
are you hovering over the stopped description? I am getting the correct hover text <img width="462" alt="Screen Shot 2021-06-04 at 9 08 51 PM" src="https://user-"
Change:
} public run(accessor: ServicesAccessor, editor: editorCommon.ICommonCodeEditor): void { <del> if (!browser.enableEmptySelectionClipboard && editor.getSelection().isEmpty()) { </del> <ins> var enableEmptySelectionClipboard = editor.getConfiguration().contribInfo.emptySelectionClipboard && browser.enableEmptySelectionClipboard; if (!enableEmptySelectionClipboard && editor.getSelection().isEmpty()) { </ins> return; }

Discussion:
Like the title says, when nothing is selected, copying shouldn't copy a blank character.
As of now, cmd+c without any selection, copies the entire line. Sublime also does the same. Are we suggesting to change this behavior as part of this issue? I really like the current functionality. Or are we suggesting one more option/flag which user can enable to have the new functionality?
Yes, it would be behind an option
Can we have the option for this behavior or disable it? I don't like the auto copy of a blank line and would like to disable that feature. I agree it can be annoying especially in the type of coding I do (debugging).
Was a setting for this?
it is
disables the line copying entirely. Is there a way to have line copying enabled, while simultaneously ignoring the empty lines?
This doesn't disable the copying within my VS Code at all and I can still copy whitespace - anyone else had any luck? fingers crossed
Change:
}, 0); }; <ins> const isEditableElement = (element: Element) => { return element.tagName.toLowerCase() === 'input' || element.tagName.toLowerCase() === 'textarea' || 'editContext' in element; }; </ins> // check if an input element is focused within the output element const checkOutputInputFocus = (e: FocusEvent) => { lastFocusedOutput = getOutputContainer(e);

Discussion:
today's insiders open GHINB and run a cell see errors (many) on the console
broke
We should also add a custom eslint rule for this. It has been broken for a few weeks and it regresses the output focus context keys.
Change:
import * as vscode from 'vscode'; import * as nls from 'vscode-nls'; import { ITypeScriptServiceClient } from '../typescriptService'; <ins> import API from '../utils/api'; </ins> const localize = nls.loadMessageBundle();

Discussion:
Following up on microsoft/TypeScript, is now a valid completion directive. It should be recommended over in the editor walkthrough that mentions comment directives.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.668 --<!-- potentialduplicatescomment --
Change:
text: [ 'foo'hello'' ], <ins> editorOpts: { autoClosingBrackets: 'beforeWhitespace' }, </ins> languageId: languageId }, (editor, model, viewModel) => { assertType(editor, model, viewModel, 1, 4, '(', '(', `does not auto close @ (1, 4)`);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Can the addition of the closing curly brace be whenever the opening curly brace is automatically initiated in an f-string in python? currently this doesn't happen and i need to add the closing curly brace when done - this feature would be useful --
Please add more details, e.g. a code sample.
apologies - I actually had but for some reason the main body of text wasn't posted. please see a below a code example - thank you. This is the current way in which the curly brace is interpreted in an f string. As you can see when you enter the opening curly brace, the closing one is not automatically inserted and i have to enter it manually.. it would be incredibly useful if the closing brace was automatically (in the same way automatic closing of brackets and braces is achieved outside of the print statement in the editor) to achieve something like: having said this - this is a trivial feature request, but i find myself using this a lot
is defined as bracket pair, also for when in strings, so I believe it should work.
Thank you for the reply! Hmm this doesn't for me unfortunately, is there a setting that needs to be activated?
does autoclose in strings in general e.g. https://user- But not at the position before the closing e.g. https://user- Relevant code:
ha! thank you, this is really interesting - i can confirm that it works when entering before the closing - funny because i have only ever really required the the braces before the closing comma (because this then creates a whitespace between the statement and the answer which is intended for visual purposes will this be treated as a bug to fix? again this obviously isn't critical. happy to close. thanks
This cannot be fixed at the moment. The behaviour is controlled by the autoCloseBefore property in the language configuration file, but quotes are not appropriate for that property. JavaScript and TypeScript make an exception for backticks.
Change:
"input.background": "#313131", "input.border": "#3C3C3C", "input.foreground": "#CCCCCC", <del> "input.placeholderForeground": "#818181", </del> <ins> "input.placeholderForeground": "#989898", </ins> "inputOption.activeBackground": "#2489DB82", "inputOption.activeBorder": "#2488DB", "keybindingLabel.foreground": "#CCCCCC",

Discussion:
]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.3; #Color Contrast; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise 22H2 Build .3007 Visual Studio Code Insiders editor ctrl+P or Tab till go and press ENTER then TAB till Go to File. that Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Similar issue is also observed throughout the application. Color contrast ratio of the "search files by name" placeholder text should be greater than or equals to 4.5:1. Low vision users will not be able to see the placeholder text if color contrast ratio will be less than 4.5:1. ! !
I can't reproduce this one. With the Dark Modern theme I see a background value for inputs of which passes the 3:1 ratio with the placeholder foreground of .
Misread that the ratio should be 4.5:1. This I can fix.
Verified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is fixed. Hence Closing the bug. please find attachment for reference. !

<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: Windows 11 Enterprise (Windows_NT x64 10.0..3007) Description During an accessibility test, we found the contrast ratio between the placeholder text and the background is not high enough under "Default Dark Modern" theme. Placeholder Text Color: Background Color: Contrast Ratio: 3.339:1 Required Contrast Ratio: 4.5:1 !
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #WCAG1.4.3; #Contrast (Minimum);
Change:
@ICodeEditorService private readonly codeEditorService: ICodeEditorService, @IThemeService private readonly themeService: IThemeService, @IChatService private readonly chatService: IChatService, <ins> @IAccessibilityService private readonly accessibilityService: IAccessibilityService, </ins> ) { super();

Discussion:
on a screen reader on Windows (JAWS/NVDA) in the chat view backspace hear "space' said this is typical of a screen reader. We discussed using an audio cue to indicate deletion. We have concluded it would be better and simpler to just disable this feature for screen reader users. !
-- After this meeting, something came to mind. What if I love the current command deletion behavior and would like to keep it? would you like to add a user setting to toggle this behavior for some advanced users?
We try to add settings sparingly because we want the default experience to be very nice. I will leave this with to decide. We could keep this behavior and mention it in the chat's accessibility help menu so a screen reader user is aware of what's happening.
do you personally anticipate that you would use this setting to preserve the command deletion behavior? Do you know why the screenreader reads 'space' on a deletion? If we can avoid that, would it be more reasonable that hitting backspace results in the screenreader announcing 'exiting mode'?
JooYoung and I discussed that approach and agreed it would be too verbose. We should either use an audio cue, disable the feature, or provide a setting.
Or mention it in the chat's accessibility help?
After thinking about this issue for a day, I think we can add an alert "input cleared" when the command is entirely deleted. I found that character-by-character deletion works after when you move your cursor to the left.
This is great
Change:
this.isRepositoryHuge = didHitLimit; if (didHitLimit && !shouldIgnore && !this.didWarnAboutLimit) { <ins> //check for known large folders that should be in .gitignore let knownHugeFolders = ['node_modules']; 	//maybe get from config let knownHugeFolderUris: Uri[] = knownHugeFolders.map(folder => { return Uri.file(`${this.repository.root}${path.sep}${folder}`); }); knownHugeFolderUris = knownHugeFolderUris.filter(folder => { return fs.existsSync(folder.fsPath); }); let alreadyIgnored = await this.checkIgnore(knownHugeFolderUris.map(uri => uri.path)); //filter already ignored knownHugeFolderUris = knownHugeFolderUris.filter(folder => { return !alreadyIgnored.has(folder.path); }); //text const addKnown = localize('add known', "Would you like to add {0} to .gitignore?", knownHugeFolderUris.map(uri => path.basename(uri.fsPath)).join(', ')); const gitWarn = localize('huge', "The git repository at {0} has too many active changes, only a subset of Git features will be enabled.", this.repository.root); //options </ins> const neverAgain = { title: localize('neveragain', "Don't Show Again") }; <ins> const yes = { title: localize('yes', "Yes") }; </ins> <del> window.showWarningMessage(localize('huge', "The git repository at '{0}' has too many active changes, only a subset of Git features will be enabled.", this.repository.root), neverAgain).then(result => { </del> <ins> let warningPromise; if (knownHugeFolderUris.length) { warningPromise = window.showWarningMessage(`${gitWarn} ${addKnown}`, yes, neverAgain); } else { warningPromise = window.showWarningMessage(gitWarn, neverAgain); } warningPromise.then(result => { </ins> if (result === neverAgain) { config.update('ignoreLimitWarning', true, false); } <ins> else if (result === yes) { this.ignore(knownHugeFolderUris); } </ins> }); this.didWarnAboutLimit = true;

Discussion:
Bug Is there any way to automatically add node_modules to .gitignore or ask the user? I see this every time - <img width="454" alt="image" src="https://user-"VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-20T10:16:08.796Z) OS version: Darwin x64 17.4.0 <details<summarySystem Info</summary </details<details<summaryExtensions (3)</summaryExtensionVersion ------ vscode-eslint1.4.6 prettier-vscode1.1.3 python2018.1.0 </detailsReproduces only with extensions <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.604 --- <!-- score: 0.462 --<!-- potentialduplicatescomment --
Negative Mr. Bot
That's a great idea, would you like to submit a PR?
I'll look into it. Can you put some pointers in the bug? What code files to look at?
This is where that message is sent: Here you have some API to add stuff to the ignore file: You can use basic NodeJS fs stuff to find out whether the user has a folder in the root of the workspace folder.
Thank you
Change:
super({ id: 'codelens.showLensesInCurrentLine', precondition: EditorContextKeys.hasCodeLensProvider, <del> label: localize('showLensOnLine', "Show Code Lens Commands For Current Line"), alias: 'Show Code Lens Commands For Current Line', </del> <ins> label: localize('showLensOnLine', "Show CodeLens Commands For Current Line"), alias: 'Show CodeLens Commands For Current Line', </ins> }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --- VSCode Version: 1.44 Insiders OS Version: Windows 10 CodeLens should be one word. The new command display name should be changed from: "Show Code Lens Commands For Current Line" to: "Show CodeLens Commands For Current Line"
Change:
"git": { "name": "seti-ui", "repositoryUrl": "https://github.com/jesseweed/seti-ui", <del> "commitHash": "6b83574de165123583d6d8d5b3b6c91f04b7153d" </del> <ins> "commitHash": "4dd6c27e1f5aed8068c2451dbaf0db3364545937" </ins> } }, "version": "0.1.0"

Discussion:
Testing Current: ! Proposal: !
Spoke with and I have submitted to add the file icon association to seti-ui repository.
Change:
if (this.documents.get(uri)) { return { isDirectory: false }; } <del> return this.connection.sendRequest(protocol.fs_stat, { uri }); </del> <ins> const fsResult = await this.connection.sendRequest(protocol.fs_stat, { uri }); return fsResult ?? undefined; // Force convert null to undefined </ins> } async readDirectory(resource: URI): Promise<[string, md.FileStat][]> {

Discussion:
Type: <bBug</bworkspace: : to top level of workspace bug The link is incorrectly rewritten to include the file name VS Code version: Code - Insiders 1.73.0-insider (Universal) (, 2022-10-27T21:41:11.954Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
disposables.add(quickPick.onDidTriggerButton(button => { if (button === this._quickInputService.backButton) { quickPick.hide(); <del> resolve(this.showQuickPick(editor)); </del> <ins> resolve(this.showQuickPick(editor, undefined, true)); </ins> } })); disposables.add(quickPick.onDidAccept(async () => {

Discussion:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !
Change:
this.telemetryService.publicLog2<GalleryServiceQueryEvent, GalleryServiceQueryClassification>('galleryService:query', { ...query.telemetryData, requestBodySize: String(data.length), <del> duration: new Date().getTime() - startTime, </del> <ins> duration: stopWatch.elapsed(), </ins> success: !!context && isSuccess(context), responseBodySize: context?.res.headers['Content-Length'], statusCode: context ? String(context.res.statusCode) : undefined,

Discussion:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.