jiebi/CodeConvo huggingface dataset:
Change:
*/ public parseSearchPaths(pattern: string): ISearchPathsResult { const isSearchPath = (segment: string) => { <del> // A segment is a search path if it is an absolute path or starts with ./ return paths.isAbsolute(segment) || strings.startsWith(segment, './') || strings.startsWith(segment, '.'); </del> <ins> // A segment is a search path if it is an absolute path or starts with ./, ../, ., or .. return paths.isAbsolute(segment) || /^..?[/]/.test(segment); </ins> }; const segments = splitGlobPattern(pattern);

Discussion:
VSCode Version: 1.17.2 OS Version: Win 7 SP 1 Steps to Reproduce: Access search tab Type a word to search for Under "files to include", type ..siblingPath Hit enter Expected: any files under ..siblingPath containing word/pattern are shown. Actual: get "No results found in ..siblingPath". Works fine if absolute path used, or relative path below the current directory. This is very useful when you have a test project open but the interesting source files are in a sibling directory.
will probably work for now.
Indeed it does, thanks for that.
Change:
registerAction2(class extends Action2 { constructor() { super({ <ins> id: TERMINAL_COMMAND_ID.FOCUS_TABS_VIEW, title: { value: localize('workbench.action.terminal.focus.tabsView', "Focus Terminal Tabs View"), original: 'Focus Terminal Tabs View' }, f1: true, category, keybinding: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KEY_T, weight: KeybindingWeight.WorkbenchContrib, when: ContextKeyExpr.or(KEYBINDING_CONTEXT_TERMINAL_TABS_FOCUS, KEYBINDING_CONTEXT_TERMINAL_FOCUS), }, precondition: KEYBINDING_CONTEXT_TERMINAL_PROCESS_SUPPORTED, }); } async run(accessor: ServicesAccessor) { await accessor.get(ITerminalService).focusTabsView(); } }); registerAction2(class extends Action2 { constructor() { super({ </ins> id: TERMINAL_COMMAND_ID.FOCUS_NEXT, title: { value: localize('workbench.action.terminal.focusNext', "Focus Next Terminal"), original: 'Focus Next Terminal' }, f1: true,

Discussion:
This would be useful since we can now navigate the tabs via the keyboard, so you could hit <keybinding, up n times, enter to focus that terminal.
Also it's a little tough to tell which split pane is actually focused right now, perhaps some extra visual hint?
Opening to double check what the ideal keybinding would be on each platform
Let's go with ctrl/cmd+shift+ for this, to align with 's navigate tabs keybinding.
Change:
}; const detectColorSchemeSettingSchema: IConfigurationPropertySchema = { type: 'boolean', <del> markdownDescription: nls.localize({ key: 'detectColorScheme', comment: ['`#{0}#` and `#{1}#` will become a link to an other setting. Do not remove backtick or #'] }, 'If set, automatically switch to the preferred color theme based on the OS appearance. If the OS appearance is dark, the theme specified at `#{0}#` is used, for light `#{1}#`.', ThemeSettings.PREFERRED_DARK_THEME, ThemeSettings.PREFERRED_LIGHT_THEME), </del> <ins> markdownDescription: nls.localize({ key: 'detectColorScheme', comment: ['{0} and {1} will become links to other settings.'] }, 'If set, automatically switch to the preferred color theme based on the OS appearance. If the OS appearance is dark, the theme specified at {0} is used, for light {1}.', formatSettingAsLink(ThemeSettings.PREFERRED_DARK_THEME), formatSettingAsLink(ThemeSettings.PREFERRED_LIGHT_THEME)), </ins> default: false };

Discussion:
open the settings, in the filter box enter . Check the settings description. It should contain links. The links use a special syntax: that must not be changed. The translated string has a message mentioning that. !
Thank you for your feedback. We are currently reviewing it (reference ).
could you please lock the placeholders with these annotations? I'll fix the local translation meanwhile.
I've got a fix out ^^
Verified in code while the translation is in work.
Change:
} }], [IChatAccessibilityService, new class extends mock<IChatAccessibilityService>() { <del> override acceptResponse(response?: IChatResponseViewModel): void { } override acceptRequest(): void { } </del> <ins> override acceptResponse(response: IChatResponseViewModel | undefined, requestId: number): void { } override acceptRequest(): number { return -1; } </ins> }], [IAccessibleViewService, new class extends mock<IAccessibleViewService>() { override getOpenAriaHint(verbositySettingKey: AccessibilityVerbositySettingId): string | null {

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.
Change:
"panel.background": "#F5F5F5", "sideBar.background": "#F2F2F2", "sideBarSectionHeader.background": "#ede8ef", <del> "editorLineNumber.foreground": "#9DA39A", </del> <ins> "editorLineNumber.foreground": "#6D705B", </ins> "editorCursor.foreground": "#54494B", "inputOption.activeBorder": "#adafb7", "dropdown.background": "#F5F5F5",

Discussion:
Environment Details: VSCode Version : 1.25.0 OS Version : Win10 Additional Details: HighContrast,MAS1.4.3 Repro Steps: Visual Studio code desktop application. to "Plain Text" of "Status Bar"-Enter "PowerShell" in "Select Language Mode" combo box-Write the PowerShell Code in plain editor-Save the editor. to Setting button of Activity Bar and select "Color Theme" option. Themes shows number of different colors list apply all that theme on the editor. color contrast analyser and check the color contrast ratio. shows color contrast ratio less than expected color contrast ratio. Actual: After applying color themes to editor it shows color contrast ratio as 3.5:1 eg. Select "QuietLight" theme from color theme list and check for the color contrast ratio. Expected: The expected colorcontrast ratio should be greater than or equals to 7:1 ratio. Recommendations: Refer below link which is repository of bug fixes code  User Impact: User will not able to see the content of the editor. MAS Reference: MAS1.4.3- Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.701 --- <!-- score: 0.617 --- <!-- score: 0.552 --- <!-- score: 0.508 --<!-- potentialduplicatescomment --
I believe you are using the wrong color contrast ratio. From the link you provided: We've only been targeting the minimum contrast ratio, which is Level AA at 4.5:1
Change:
import * as glob from 'vs/base/common/glob'; import { sep } from 'vs/base/common/path'; import { isWindows } from 'vs/base/common/platform'; <ins> import { URI } from 'vs/base/common/uri'; </ins> suite('Glob', () => {

Discussion:
install "markdown notebook" extension make sure the default editor for MD files is the text editor open a MD file (opens as text) re-open with markdown notebook select an entry from outline or breadcrumbs :bug: a text editor opens
It looks like our editor contribution point isn't called
The same happens with the "references view" and the "problems panel" (use GH issue notebooks and make text editor default for its type)
Debugged this a little: everything works nice up to the point where the user setting is read and . That "steels" the resource from notebooks and re-routes it into the "normal" editor land... This code is novel to me so I might not have the best suggestions how to fix it. One idea is that my contribution marks a scheme as "winner scheme" and resources with that scheme will always use that contribution. Tho, I don't know what side effects that will have
Change:
voiceTimeout = SpeechTimeoutDefault; } this._acceptTranscriptionScheduler = this._disposables.add(new RunOnceScheduler(() => { <del> this._terminalService.activeInstance?.sendText(this._input, false); </del> <ins> this._sendText(); </ins> this.stop(); }, voiceTimeout)); this._cancellationTokenSource = this._register(new CancellationTokenSource());

Discussion:
Sighted users see preview text as a voice recording occurs and they see the resultant output, which could be drastically different from what they might expect. To make this clear for SR users, after the recording has stopped, we should alert with the content that was inserted in at least the terminal. Unclear if this would also be desirable to do in the chat input boxes
Do you move over to using braille when using the speech functionality Otherwise, doesn't the mic pick up on what the screen reader is saying?

It seems that the mic icon requires at least one line above the prompt to show: ! It does not appear for me in the above case.
Thanks for the issue. Should be an easy fix and in this case the mic will have to go on the cursor line
Change:
<div class="section learn"> <h2 class="caption">${escape(localize('welcomePage.learn', "Learn"))}</h2> <ul> <del> <li class="showCommands"><button data-href="command:workbench.action.showCommands"><h3 class="caption">${escape(localize('welcomePage.showCommands', "Find and run all commands"))}</h3> <span class="detail">${escape(localize('welcomePage.showCommandsDescription', "Rapidly access and search commands from the control panel ({0})")).replace('{0}', '<span class="shortcut" data-command="workbench.action.showCommands"></span>')}</span></button></li> </del> <ins> <li class="showCommands"><button data-href="command:workbench.action.showCommands"><h3 class="caption">${escape(localize('welcomePage.showCommands', "Find and run all commands"))}</h3> <span class="detail">${escape(localize('welcomePage.showCommandsDescription', "Rapidly access and search commands from the command palette ({0})")).replace('{0}', '<span class="shortcut" data-command="workbench.action.showCommands"></span>')}</span></button></li> </ins> <li class="showInterfaceOverview"><button data-href="command:workbench.action.showInterfaceOverview"><h3 class="caption">${escape(localize('welcomePage.interfaceOverview', "Interface overview"))}</h3> <span class="detail">${escape(localize('welcomePage.interfaceOverviewDescription', "Get a visual overlay highlighting the major components of the UI"))}</span></button></li> <li class="showInteractivePlayground"><button data-href="command:workbench.action.showInteractivePlayground"><h3 class="caption">${escape(localize('welcomePage.interactivePlayground', "Interactive playground"))}</h3> <span class="detail">${escape(localize('welcomePage.interactivePlaygroundDescription', "Try essential editor features out in a short walkthrough"))}</span></button></li> </ul>

Discussion:
<img width="639" alt="screen shot 2017-06-15 at 4 04 46 pm" src="https://user-"
Change:
export function addDisposableNonBubblingMouseOutListener(node: Element, handler: (event: MouseEvent) => void): IDisposable { return addDisposableListener(node, 'mouseout', (e: MouseEvent) => { // Mouse out bubbles, so this is an attempt to ignore faux mouse outs coming from children elements <del> let toElement: Node | null = <Node>(e.relatedTarget || e.target); </del> <ins> let toElement: Node | null = <Node>(e.relatedTarget); </ins> while (toElement && toElement !== node) { toElement = toElement.parentNode; }

Discussion:
Issue Type: <bBug</bSteps to Reproduce: a project/folder mouse into Editor and then move it out from right edge of the window Activity Bar mouse into Side Bar and then move it out from left edge of the window VS Code version: Code 1.37.1 (, 2019-08-15T16:16:34.800Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --
The issue seems to be in , but I am not sure what the difference is between that edge of the editor and the others. For some reason the mouseLeave event is not being fired on the right-hand side. It seems it thinks the is the same as the initially given - which means the leave event is never fired. I'm happy to keep digging into this if that's ok with you.
Change:
if (sourceTargetPairs.length >= 1) { // Move/Copy File if (pasteShouldMove) { <del> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target)); </del> <ins> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { overwrite: incrementalNaming === 'disabled' })); </ins> const options = { confirmBeforeUndo: configurationService.getValue<IFilesConfiguration>().explorer.confirmUndo === UndoConfirmLevel.Verbose, progressLabel: sourceTargetPairs.length > 1 ? nls.localize({ key: 'movingBulkEdit', comment: ['Placeholder will be replaced by the number of files being moved'] }, "Moving {0} files", sourceTargetPairs.length)

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for "duplicate". "Explorer: Incremental Naming" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the "This window is not responding" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set "Explorer: Incremental Naming" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user "will be prompted to override the existing file". So this might be the expected / intended result.
Change:
this._register(this._logger.onDidChangeLogLevel(l => this._logger.info('Log level changed to ' + LogLevelToString(l)))); <del> this._register(sharedProcessLifecycleService.onWillShutdown(e => { if (this._tunnelProcess) { this._tunnelProcess.cancel(); this._tunnelProcess = undefined; } </del> <ins> this._register(sharedProcessLifecycleService.onWillShutdown(() => { this._tunnelProcess?.cancel(); this._tunnelProcess = undefined; </ins> this.dispose(); }));

Discussion:
This here: Is strange to me because while this call is , it will not prolong the shutdown on the main process which is sync: Since the user of this event does not seem to use , I suggest to make the not support promises.
Change:
controller.nextCommentThread(); }, weight: KeybindingWeight.EditorContrib, <del> when: EditorContextKeys.focus, </del> primary: KeyMod.Alt | KeyCode.F9, });

Discussion:
Testing The accessibility help says this should work, but it does not appear to do anything
if you use a different keybinding, does it work ?
I switched it to with no effect
keyboard shortcuts troubleshooting show anything of interest?
Here it is. I ran the keybinding twice, the first time worked when I wasn't on a comment and navigated to a comment. The second time did nothing once I was there.
Change:
[package] name = "inno_updater" <del> version = "0.10.0" </del> <ins> version = "0.10.1" </ins> authors = ["Microsoft <monacotools@microsoft.com>"] build = "build.rs"

Discussion:
Type: <bBug</bI get nightly updates on VSCode insiders and I get the crash on whenever I restart the app for updating it. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-13T05:33:32.822Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (21)</summaryExtensionVersion ------ vscode-chromium-vector-icons1.0.2 togglehs0.1.2 gitlens2023.7.1305 copilot1.96.259 copilot-chat0.5. mojom-language0.0.1 vscode-webidl0.0.1 vscode-clangd0.1.24 cpplint0.1.3 autopep82023.7. python2023.13. vscode-pylance2023.7.21 remote-ssh0.103. remote-ssh-edit0.86.0 cpptools1.16.3 remote-explorer0.5. gnls0.1.4 java1.21. code-spell-checker2.20.5 change-case1.0.0 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Any details on the crash? Any error messages? Any logs?
I've attached the Crash Dump. Note: I used 7-zip to compress to 7z and then to zip (to make it smaller that GitHub allowed size and format).
The same thing has been happening to me.
This has been happening to me too.
Thanks guys, I've confirmed the issue!
Got a stack trace:
Caused by , namely:
Change:
return this.parentURI(filesToOpenOrCreate[0].fileUri); } else if (filesToDiff && filesToDiff.length) { return this.parentURI(filesToDiff[0].fileUri); <del> } else if (filesToMerge && filesToMerge.length) { </del> <ins> } else if (filesToMerge && filesToMerge.length === 4) { </ins> return this.parentURI(filesToMerge[3].fileUri) /* [3] is the resulting merge file */; } return undefined;

Discussion:
Insiders the terminal, run new file called should be open in the editor. that tab. The command no longer returns
Thanks! I thought that it was some configuration issue on my side when GitLens Rebase editor didn't release file and later text editors did the same.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Worked fine for me for both cases: prompt for commit message update as well as GitLens' Rebase editor. Version: 1.70.0-insider (user setup) Commit: Date: 2022-07-21T05:17:27.580Z OS: Windows_NT x64 10.0.
Change:
async run(accessor: ServicesAccessor) { const themeService = accessor.get(IThemeService); const groupService = accessor.get(ITerminalGroupService); <ins> const notificationService = accessor.get(INotificationService); </ins> const picks: ITerminalQuickPickItem[] = []; <del> if (groupService.instances.length === 1) { </del> <ins> if (groupService.instances.length <= 1) { notificationService.warn(localize('workbench.action.terminal.join.insufficientTerminals', 'Insufficient terminals for the join action')); </ins> return; } const otherInstances = groupService.instances.filter(i => i.instanceId !== groupService.activeInstance?.instanceId);

Discussion:
I got confused because I tried joining terminals when there was only one terminal group. Is there a way to notify the user or to disable the command for that case? Originally posted by in and do the same for the unsplit command
might be overkill because the action was only to the command palette for the purpose of smoke testing
Let's show a notification when it's triggered with <= 1 terminal
What about when it's triggered with 2 terminals that are already split (and thus there are no picks)? Different notification?
Change:
private createTerminal(terminalProcess: ITerminalProcess, terminalFocusContextKey: IKeybindingContextKey<boolean>): TPromise<TerminalInstance> { return new TPromise<TerminalInstance>(resolve => { <del> var terminalInstance = new TerminalInstance(terminalProcess, this.terminalContainer, this.contextService, this.terminalService, this.messageService, terminalFocusContextKey, this.onTerminalInstanceExit.bind(this)); </del> <ins> var terminalInstance = new TerminalInstance(terminalProcess, this.terminalContainer, this.contextMenuService, this.contextService, this.instantiationService, this.keybindingService, this.terminalService, this.messageService, terminalFocusContextKey, this.onTerminalInstanceExit.bind(this)); </ins> this.terminalInstances.push(terminalInstance); this.setActiveTerminal(this.terminalInstances.length - 1); this.toDispose.push(this.themeService.onDidThemeChange(this.updateTheme.bind(this)));

Discussion:
Currently events are handled in each terminal instance, this means that event handlers go off for each terminal instances for an event on the terminal panel.
Change:
return element.element.id === fragment; }); } <ins> function* getParentsWithTagName<T extends HTMLElement>(element: HTMLElement, tagName: string): Iterable<T> { for (let parent = element.parentElement; parent; parent = parent.parentElement) { if (parent.tagName === tagName) { yield parent as T; } } } </ins>

Discussion:
Thanks for the quick turnaround on preserving the open attribute! I'm still a little curious about the scrolling sync: I don't see anything in that looks like it would address the issue I'm seeing "scrolling past" a collapsed block where the code cursor makes the preview act as if it's much further down, seemingly by about as much as the length of the expanded . I can now leave my expanded to re-enable sync'd scrolling, but I was wondering if the intent was to not change the behavior when they're closed? Or, would it be helpful if I broke that part out into a new issue? Originally posted by in
Thanks. I've extracted this to it's own issue and will push a fix shortly
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!