jiebi/CodeConvo huggingface dataset:
Change:
} private onScreenReaderModeChange(): void { <ins> // We only support text based editors const screenReaderDetected = this._accessibilityService.isScreenReaderOptimized(); if (screenReaderDetected) { const screenReaderConfiguration = this.configurationService.getValue('editor.accessibilitySupport'); if (screenReaderConfiguration === 'auto') { if (!this.promptedScreenReader) { this.promptedScreenReader = true; setTimeout(() => this.showScreenReaderNotification(), 100); } } } if (this.screenReaderNotification) { this.screenReaderNotification.close(); } </ins> this.updateScreenReaderModeElement(this._accessibilityService.isScreenReaderOptimized()); } }

Discussion:
Type: <bBug</bRestarted Insiders for an update and Screen Reader mode is suddenly on, including audio cues while typing. I have no idea how to disable it, as the status bar icon is clickable (changes color), but doesn't do anything. (Edit: I eventually found command, but I don't see any logs that I used that command before) cc who recommended as assignee. ! VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-24T05:35:10.309Z) OS version: Darwin x64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
not aware of any changes on your end, so i'm just reverting the only relevant PR
Just launched a fresh Insiders and got this notification: ! I do see it detecting a11y for me in telemetry events …` Version: , 2023-10-25T05:37:06.169Z (9 hrs ago)
Indeed then, it seems an issue with detection , not sure why this would be showing otherwise as nothing's changed on my side.
Or something you're running
No changes have been made in the runtime with respect to a11y detection, on macOS the runtime can enter a11y mode in the following 2 scenarios, 1) Setting attribute on the application which is usually done by screen readers (VoiceOver) 2) Setting attribute on the applications which is usually done by third party window managers are you using any custom window tiling managers ? List under can give a hint
I do run window managers, yes. So, I guess I'll close this for now as it might have been an update, like Bartender 5.
Change:
addToTree(parseInt(matches[1]), parseInt(matches[2]), matches[5], parseFloat(matches[3]), parseFloat(matches[4])); } } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Issue Type: <bBug</ba WSL window ! It looks similar to . A possible fix might be: cc: VS Code version: Code - Insiders 1.46.0-insider (, 2020-05-22T21:13:15.709Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ vscode-eslint2.1.5 gitlens10.2.1 EditorConfig0.15.1 graphql-for-vscode1.15.3 vscode-emacs-friendly0.9.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.2 powershell-preview2020.5.0 debugger-for-chrome4.12.8 material-theme3.7.1 </details<!-- generated by issue reporter --
Seeing this too, trying to attach to a dotnet process in WSL 2 in both insiders and stable: ! Version: 1.46.0-insider (user setup) Commit: Date: 2020-05-26T05:47:43.684Z (9 hrs ago) Electron: 8.3.0 Chrome: 80.0.3987.165 12.13.0 V8: 8.0.426.27-electron.0 OS: WindowsNT x64 10.0. Version: 1.45.1 (system setup) Commit: Date: 2020-05-14T08:27:35.169Z Electron: 7.2.4 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: WindowsNT x64 10.0.
Same problem here, right after upgrading from WSL 1 to WSL 2. Might be the same cause as and :
Also experiencing this with WSL 2 trying to debug using gdb (Attach)
I am reproducing this issue when trying to bring up the prompt textbox to select the process ID of the process to attach. Unfortunately, this PR did not fix the original reported issue My environment: WSL2 with Ubuntu 20.04.

Omnisharp v1.22.1 Visual Studio Code Insiders: ! Is there a workaround? This issue has been around since at least June 2019.
You had a proposed fix for this a while ago that looked good to me, do you want to go ahead and check that in?
Change:
when: CommentContextKeys.activeEditorHasCommentingRange }); <ins> MenuRegistry.appendMenuItem(MenuId.CommandPalette, { command: { id: CommentCommandId.NextCommentedRange, title: nls.localize('comments.NextCommentedRange', "Go to Next Commented Range"), category: 'Comments', }, when: CommentContextKeys.activeEditorHasCommentingRange }); MenuRegistry.appendMenuItem(MenuId.CommandPalette, { command: { id: CommentCommandId.PreviousCommentedRange, title: nls.localize('comments.PreviousCommentedRange', "Go to Previous Commented Range"), category: 'Comments', }, when: CommentContextKeys.activeEditorHasCommentingRange }); </ins> CommandsRegistry.registerCommand({ id: CommentCommandId.ToggleCommenting, handler: (accessor) => {

Discussion:
Screen reader users like want to navigate between editor ranges that have comments. I think this makes sense. the recording I will share describes this in more detail.
I just realized that these already exist, and .
I respectfully think that we have miscommunication here. I am requesting a feature going to the next commented area. The commands that you are referring to are moving between commentable range, instead of commented area. The closest commands are alt+F9 () and alt+shift+F9 (). However, these commands directly and automatically opens the comment widget. I just want to jump to the next commented lines and manually open the applied comments manually if I need to review.
Ah, yes makes sense thanks for reminding me!
Change:
"vscode-oniguruma": "1.7.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.73", "xterm-addon-canvas": "0.5.0-beta.34", </del> <ins> "xterm": "5.4.0-beta.17", "xterm-addon-canvas": "0.6.0-beta.16", </ins> "xterm-addon-image": "0.6.0-beta.21", <del> "xterm-addon-search": "0.13.0-beta.27", "xterm-addon-serialize": "0.11.0-beta.27", "xterm-addon-unicode11": "0.6.0-beta.19", "xterm-addon-webgl": "0.16.0-beta.37", "xterm-headless": "5.3.0-beta.73", </del> <ins> "xterm-addon-search": "0.14.0-beta.15", "xterm-addon-serialize": "0.12.0-beta.15", "xterm-addon-unicode11": "0.7.0-beta.15", "xterm-addon-webgl": "0.17.0-beta.15", "xterm-headless": "5.4.0-beta.17", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
Upstream: To verify: linux/macOS/wsl various values of (eg. 1, 4.5, 10) first with no selection and second with a selection. You may need to change your theme to see the differences

Upstream: Repro: Linux/macOS/WSL , it should not show invisible in the output

noticed by
Verify that when you have a screen reader on, you hear the output of a command upon pressing enter
Reproduces in the demo. Does not reproduce in stable VS Code
upstream issue:
With a screen reader enabled, run a command that yields short output, such as . Verify that the screen reader reads the output.
Change:
this.minimap = options.minimap ? new ModelDecorationMinimapOptions(options.minimap) : null; this.glyphMarginClassName = options.glyphMarginClassName ? cleanClassName(options.glyphMarginClassName) : null; this.linesDecorationsClassName = options.linesDecorationsClassName ? cleanClassName(options.linesDecorationsClassName) : null; <ins> this.firstLineDecorationClassName = options.firstLineDecorationClassName ? cleanClassName(options.firstLineDecorationClassName) : null; </ins> this.marginClassName = options.marginClassName ? cleanClassName(options.marginClassName) : null; this.inlineClassName = options.inlineClassName ? cleanClassName(options.inlineClassName) : null; this.inlineClassNameAffectsLetterSpacing = options.inlineClassNameAffectsLetterSpacing || false;

Discussion:
When a section is wrapped after folding. Fold its parent with itself unfolded will display several wrong fold indicators.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.724 --- <!-- score: 0.616 --- <!-- score: 0.606 --- <!-- score: 0.575 --- <!-- score: 0.569 --<!-- potentialduplicatescomment --
!
Change:
}); } <del> export const enum AccessibilityVoiceSettingId { SpeechTimeout = 'accessibility.voice.speechTimeout', AutoSynthesize = 'accessibility.voice.autoSynthesize', SpeechLanguage = SPEECH_LANGUAGE_CONFIG } </del> <ins> export { AccessibilityVoiceSettingId } </ins> export const SpeechTimeoutDefault = 1200; export class DynamicSpeechAccessibilityConfiguration extends Disposable implements IWorkbenchContribution {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:
We reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See
Change:
* Mark the end of the keydown event. */ function markKeyDownEnd() { <del> performance.mark('keydown/end'); state.keydown = EventPhase.Finished; </del> <ins> if (state.keydown === EventPhase.InProgress) { performance.mark('keydown/end'); state.keydown = EventPhase.Finished; } </ins> } /**

Discussion:
I suspect this comes from
You're right, this is: Right now, the module assumes that it will be called in the following order: It is possible that if a is skipped by the browser that we don't mark and that would cause an error at
Good morning I'm having trouble logging into the app. I get the following error. Uncaught SyntaxError: Failed to execute 'measure' on 'Performance': The mark '<REDACTED: user-file-path' does not exist. I hope you can help me with the solution. thank you.
Change:
public readonly textAreaCover: FastDomNode<HTMLElement>; private readonly _textAreaInput: TextAreaInput; <del> constructor(context: ViewContext, viewController: ViewController, visibleRangeProvider: IVisibleRangeProvider) { </del> <ins> constructor( context: ViewContext, viewController: ViewController, visibleRangeProvider: IVisibleRangeProvider, @IKeybindingService private readonly _keybindingService: IKeybindingService ) { </ins> super(context); this._viewController = viewController;

Discussion:
Type: <bBug</bWhen accessibility mode is off and focus is in the editor, pressing Alt +F1 produces the following announcement to screen reader users: "The editor is not accessible at this time. Press Alt+F1 for options.". If one is a new user of the product and screen reader mode doesn't turn on automatically, pressing the command which is supposed to help one get started just repeats the same announcement inviting the user to use Alt +F1 to obtain help. VS Code version: Code - OSS Dev 1.81.0 (Commit unknown, Date unknown) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I filed the bug while running VS Code from source. That's why version information doesn't reflect that I'm using the latest. Correct version information: Version: 1.81.0-insider (user setup) Commit: Date: 2023-07-18T05:36:41.526Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.
Since the help menu is not accessible with that off, instead of we should say to enable screen reader mode.
Change:
*--------------------------------------------------------------------------------------------*/ import { compareIgnoreCase } from 'vs/base/common/strings'; <del> import { IExtensionIdentifier, IGalleryExtension, ILocalExtension, IExtensionsControlManifest, getTargetPlatform } from 'vs/platform/extensionManagement/common/extensionManagement'; </del> <ins> import { IExtensionIdentifier, IGalleryExtension, ILocalExtension, getTargetPlatform } from 'vs/platform/extensionManagement/common/extensionManagement'; </ins> import { ExtensionIdentifier, IExtension, TargetPlatform } from 'vs/platform/extensions/common/extensions'; import { IFileService } from 'vs/platform/files/common/files'; import { isLinux, platform } from 'vs/base/common/platform';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --When installing an extensions with , users can freely install extensions which are malicious, which is not possible from the UI. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0 OS Version: macOS 13 Steps to Reproduce: your 's to . a terminal inside of VS Code The CLI either refuses to install these extensions or warns the user.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Sorry, mistyped the version by one patch release, all fixed now.
Can you please let me know which extension you are trying to install that is malicious and VS Code allows it from CLI?
that would be any extension list that I tried and exists in the Marketplace, for example installs just fine although not allowing me to install via the UI <img width="725" alt="image" src="https://user-"
Change:
} } <del> function getReplaceRange(valueRange: Range, valueAfterLastSlash: string): Range { </del> <ins> function getFullReplaceRange(valueRange: Range) { const start = Position.create(valueRange.end.line, valueRange.start.character + 1); const end = Position.create(valueRange.end.line, valueRange.end.character - 1); return Range.create(start, end); } function getReplaceRange(valueRange: Range, valueAfterLastSlash: string) { </ins> const start = Position.create(valueRange.end.line, valueRange.end.character - 1 - valueAfterLastSlash.length); const end = Position.create(valueRange.end.line, valueRange.end.character - 1); return Range.create(start, end);

Discussion:
Testing Version 1.21.0-insider Commit Date 2018-03-01T06:47:39.037Z create , in a folder in `' have and do code completion after . -should show as a proposal
Change:
], 'type': 'string', 'tags': ['experimental', 'usesOnlineServices'], <del> 'default': 'off', </del> <ins> 'default': 'onReload', </ins> 'markdownDescription': localize('autoResume', "Controls whether to automatically resume an available edit session for the current workspace."), }, }

Discussion:
Trying to test a repo on vscode-dev (for me, ) some changes in the "Continue Edit Session" and "Reopen in Desktop" repository on desktop VS Code opens, but edit session changes are not applied
Update: I see it's actually in the Edit Sessions view, just not continued automatically by the protocol activation. I can manually resume the edit session once desktop opens and the changes appear.
Ah, do you have configured in settings?
I do not
That will be why--the auto resume behavior requires that setting to be configured in the destination workspace for now, otherwise it would still be a manual step.
Tried this and doesn't work for me, do I need a new version of some extension?
you need to have the pre-releases of and installed in the latest VS Code Insiders. If it doesn't work for you, could you please share the contents of the "Log (Edit Sessions)" output channel?
Yes, on pre-release of both of those extensions (in web and desktop). There's nothing in the output, However there are errors in the console window <details<summaryLogs</summary</details
Hm, those errors are all spurious. Do you have the following version of VS Code: Version: 1.71.0-insider (system setup) Commit: Date: 2022-08-25T13:00:37.808Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes Or equivalently do you have the following settings
Yes Yes, <img width="353" alt="Screen Shot 2022-08-26 at 13 58 47" src="https://user-"
Oh--have you run the command on desktop VS Code before? If not, could you try doing that and then checking to see if the following flow works for you? https://user- We probably need some settings sync-ed memento state to communicate that we should ask for auth here.
Change:
private readonly viewsRegistry: IViewsRegistry; private readonly viewContainersRegistry: IViewContainersRegistry; <del> private readonly viewContainersCustomLocations: Map<string, ViewContainerLocation>; private readonly viewDescriptorsCustomLocations: Map<string, string>; </del> <ins> private viewContainersCustomLocations: Map<string, ViewContainerLocation>; private viewDescriptorsCustomLocations: Map<string, string>; </ins> private readonly _onDidChangeViewContainers = this._register(new Emitter<{ added: ReadonlyArray<{ container: ViewContainer; location: ViewContainerLocation }>; removed: ReadonlyArray<{ container: ViewContainer; location: ViewContainerLocation }> }>()); readonly onDidChangeViewContainers = this._onDidChangeViewContainers.event;

Discussion:
In my default profile with gitlens installed, move 3 gitlens views to a new view container (in secondary side bar) Create an empty profile Switch back to default profile gitlens view are back in SCM instead of in their new view container CC
Works great, thank you!
Change:
super({ id: NOTEBOOK_FOCUS_PREVIOUS_EDITOR, title: localize('cursorMoveUp', 'Focus Previous Cell Editor'), <del> precondition: CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate(), </del> keybinding: [ { when: ContextKeyExpr.and(

Discussion:
I'm pretty sure some of these keybindings aren't ever enabled with their context key requirements, e.g. I don't think the inline chat can be focused in a markdown cell that isn't in edit mode. Nor will cursor navigation mode be true while edit mode is false.
Change:
updateBreadcrumbs(); this._breadcrumbsDisposables.clear(); this._breadcrumbsDisposables.add(listener); <del> this._breadcrumbsDisposables.add(model); </del> <ins> this._breadcrumbsDisposables.add(toDisposable(() => this._model.clear())); </ins> this._breadcrumbsDisposables.add(configListener); this._breadcrumbsDisposables.add(toDisposable(() => this._widget.setItems([])));

Discussion:
profile on startup and have a css file opened the registers a fs provider for this somehow ends up causing a dom layout via the breadcrumbs <img width="606" alt="image" src="https://user-"
The trigger is that registering a file system causes a label service change event which causes breadcrumbs to re-render. Tho, we can likely optimise this
Change:
/** * Checks if `other` is a sub-kind of this `DocumentDropOrPasteEditKind`. * <ins> * The kind `"text.plain"` for example contains `"text.plain"` and `"text.plain.list"`, * but not `"text"` or `"unicorn.text.plain"`. * </ins> * @param other Kind to check. */ contains(other: DocumentDropOrPasteEditKind): boolean;

Discussion:
Testing I cloned the vscode-extension-samples repository and tried to return two edits instead of one. Only the first one appears to take effect. I am wondering if this is expected? I guess I was expecting both edits to be applied since it is possible to return an array from the method.
The thought occurred to me that the edits would appear in the paste widget, and I verified this was indeed the case. I guess, by reading the TS docs I didn't catch on that this would happen
Aside from the above comment, on reading the JS Docs, the following thoughts came to mind: For the class , I was looking at the method . Consider the following code: Do the kinds and intersect here? Or is the intersection evaluated per part, so that the above do not intersect but the below kinds do? I noticed the refers to file dropping in its JS Doc. I was wondering if this is intended? The JS Doc above the field says . The same line more-or-less can be found under .
This is expected. Each is one potential way of applying the paste. We only apply one at a time and the first one is auto applied , the kinds are scoped hierarchies of parts. When we talk about intersection, only the second example would return true. The first one would not as the two top level parts and are not the same. I'll add an example in the docs to make this more clear it applies but for pasting files. I'll change the word
Change:
})); } <del> public reset(processManager: ITerminalProcessManager) { </del> <ins> public reset() { </ins> this.lastRow = undefined; <del> this.processManager = processManager; this._register(this.processManager.onBeforeProcessData(e => this.onBeforeProcessData(e))); </del> } private deferClearingPredictions() {

Discussion:
This started yesterday. I am on Remote WSL. !
Setting to -1 works as a temporary workaround.
any ideas? Could adding the pty host process in remote have caused this somehow? Not sure what other changes could have caused it.
I can't look into this for a few hours, I'm guessing something that it expected was synchronous is now asynchronous.
I wonder... when you hit ENTER, does it run correctly? I wonder if this is more of a cosmetic issue than impacting what is actually run.
Yes it's cosmetic only
Typeahead hasn't changed in several weeks, so I'm guessing pty in the remote is it. I was able to reproduce this in Insiders, but annoyingly could not do so in a dev setup from OSS -- anything that was fixed since the last Insiders? Would any of the pty process work cause to no longer be synchronous? That would be a prime suspect. It seems to only happen when typing somewhat rapidly (i.e. when there's multiple predictions written and one is validated) so the is probably incorrect in these scenarios. I can try to debug Insiders off sourcemaps if we can't get an OSS repro...
I don't repro this on Insiders today. Let me know if you do, or if it comes back
I could reproduce it the other day in WSL but not out of sources, but now can't . Good news I guess, do you see it anymore?
No more repro!