jiebi/CodeConvo huggingface dataset:
Change:
return paths.isAbsolute(segment) || /^..?[/]/.test(segment); }; <del> const segments = splitGlobPattern(pattern); </del> <ins> const segments = splitGlobPattern(pattern) .map(segment => untildify(segment, this.environmentService.userHome)); </ins> const groups = collections.groupBy(segments, segment => isSearchPath(segment) ? 'searchPaths' : 'exprSegments');

Discussion:
Loosely related to ! We can use the 'files to include' box to do a search in an arbitrary folder, but it has to be an absolute path. It should also work when using a ~ to indicate the user's home directory.
Change:
import { withNullAsUndefined } from 'vs/base/common/types'; import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; <ins> import { PeekContext } from 'vs/editor/contrib/peekView/peekView'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; </ins> export class GotoDefinitionAtPositionEditorContribution implements IEditorContribution {

Discussion:
This situation has been discussed on PR . VSCode Version: Code OSS Dev (Insiders hasn't been built since PR ) OS Version: Ubuntu 19.10 Steps to Reproduce: the new setting 'Definition Link Opens in Peek' ! ctrl + click to open definition on Peek Widget that Peek Widget use ctrl + click again on another definition. As can be seen on this image there will be nested peeks which is not a correct behavior. ! I will submit a new PR because I have already fixed this on my fork.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.702 --- <!-- score: 0.646 --- <!-- score: 0.594 --- <!-- score: 0.542 --- <!-- score: 0.541 --<!-- potentialduplicatescomment --
Change:
"git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", <del> "commitHash": "6839dd92b84057e79ddce06f8291cc56a0a51ff6" </del> <ins> "commitHash": "15f3c45fe9292fb80c5b5c4d26a218e825287d07" </ins> } }, "isOnlyProductionDependency": true, "license": "MIT", <del> "version": "18.3.2" </del> <ins> "version": "18.3.3" </ins> }, { "component": {

Discussion:
Testing When I just launch and then quit VSCode, I see the black dot on the dock for quite some time. I have launched from CLI: !
Yeah, running with :
This is a side effect of how we gracefully shutdown the utility process, previously the extension host was responsible for shutting itself down and we block the main process exit based on it Utility process lifetimes are controlled by the main process, (i-e) on graceful shutdown of the application the main process will first try to quit the main message loop and the applications have a chance to block this exit based on , event listeners and we use that today to provide chance to shutdown our services and once message loop is good to exit, the main process will cleanup C++ handles to the JS objects and only during this phase I also shutdown the running utility processes gracefully which will emit the event, after that the node environments, child process and threads in the main process will get shutdown one after other eventually exiting the main process itself. So what we are currently seeing is a chicken and egg problem, where the main message loop exit is blocked for 6s by the extension host exit, but the extension host exit is blocked on event from the main message loop. Solution: The runtime can only cleanup the utility process once the main message loop is ready to exit, if the exit is blocked on the application end it is not possible to know when to gracefully shutdown the process from the runtime side. Thoughts ? Alternatively, from the runtime side I can move the cleanup of utility process earlier just before the , event listeners get emitted so that the application receives an event.
The extension host processes should exit by themselves when the MessageChannel is closed. My intuition here is that the event might not be firing on the instance, but I need to debug it to confirm.
Ah yeah, I currently don't emit the event when gets disconnected however the process does exit. Will address it.
Change:
border-bottom: 1px solid var(--vscode-editorHoverWidget-border); } <ins> .monaco-editor .parameter-hints-widget .code { font-family: var(--vscode-parameterHintsWidget-editorFontFamily), var(--vscode-parameterHintsWidget-editorFontFamilyDefault); } </ins> .monaco-editor .parameter-hints-widget .docs { padding: 0 10px 0 5px; white-space: pre-wrap;

Discussion:
I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi
I haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Yes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks
Change:
private _onDidChangeTaskSystemInfo: Emitter<void> = new Emitter(); private _willRestart: boolean = false; public onDidChangeTaskSystemInfo: Event<void> = this._onDidChangeTaskSystemInfo.event; <ins> private _onDidReconnectToTasks: Emitter<void> = new Emitter(); public onDidReconnectToTasks: Event<void> = this._onDidReconnectToTasks.event; </ins> constructor( @IConfigurationService private readonly _configurationService: IConfigurationService,

Discussion:
Currently, one can have a task that runs on folder open (startup), but if window is reloaded, they get a notification "The task '<myTask' is already active." with options to terminate or restart the task. It would be great to have an option to never see this notification either as a button or within gear-icon context menu on the notification.
Yeah this is happening because of automatic tasks / reconnected tasks each trying to start the same one. We should ignore the request if it's coming from one or the other source (reconnection or automatic) and the task is already running
Workaround for now is to remove the folderOpen property or disable reconnection
I do not see my task getting run either on first open or window reload
found that this does not work in old Codespaces, which we are tracking here .

create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first
Change:
const existing = await this.getExistingSession(); if (existing !== undefined) { this.logService.trace(`Found existing authentication session with ID ${existingSessionId}`); <del> this.#authenticationInfo = { sessionId: existing.session.id, token: existing.session.accessToken, providerId: existing.session.providerId }; </del> <ins> this.#authenticationInfo = { sessionId: existing.session.id, token: existing.session.idToken ?? existing.session.accessToken, providerId: existing.session.providerId }; </ins> this.storeClient.setAuthToken(this.#authenticationInfo.token, this.#authenticationInfo.providerId); return true; }

Discussion:
Reported by Possibly related to already being signed into settings sync with GitHub auth
Lmk if you need anything from me
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Seems to be because I need to use the idToken instead of the accessToken?
Yep. Settings Sync uses the and not the . Sorry I should have told you that
how can I verify this / what was the repro?
steps are just "use Microsoft account with edit sessions" and it works. Verified!
Change:
out.appendMarkdown('nn' + tagsPreview); } } <ins> out.isTrusted = { enabledCommands: [OpenJsDocLinkCommand.id] }; </ins> return out; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: see below, pulled from the "Help About" dialog. Also confirmed in 1.71.2. OS Version: see below, pulled from the "Help About" dialog. Steps to Reproduce: above VSCode Insiders build. (Instructions don't require system path to be updated.) a directory in WSL, say . , where is the distro of your choice. the WSL extension as prompted and reload. the editor and run , where is the distro of your choice. (Steps 2-4 were just to initialize some VSCode state.) a new file in that directory with the following contents: restart editor. (Works either way.) over above. tooltip will appear with "some thing linking Foo" where is hyperlinked. Click the hyperlink in the tooltip. attempts to open a file at the path in the parent Windows OS, outside of any WSL distro. Note that this reproduces both with the WSL extension enabled the whole time (skipping step 5) and with it disabled at step 5.
Did this get missed?
I have the same issue with VSCode running in WSL2 (Ubuntu)
Same issue here, using a remote connection to a VM running on Hyper-V. Host OS is Windows, guest OS is Ubuntu 22.04. It only happens when clicking the link in the tooltip. Using directly in the editor works as expected.
Still seeing this issue. Looking forward to this getting resolved soon.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
const data = this.editorTransfer.getData(DraggedEditorIdentifier.prototype); if (Array.isArray(data)) { const draggedEditor = data[0].identifier; <del> const targetGroup = ensureTargetGroup(); </del> const sourceGroup = this.accessor.getGroup(draggedEditor.groupId); if (sourceGroup) { <del> if (sourceGroup === targetGroup) { return; </del> <ins> const copyEditor = this.isCopyOperation(event, draggedEditor); let targetGroup: IEditorGroupView | undefined = undefined; // Optimization: if we move the last editor of an editor group // and we are configured to close empty editor groups, we can // rather move the entire editor group according to the direction if (this.editorGroupService.partOptions.closeEmptyGroups && sourceGroup.count === 1 && typeof splitDirection === 'number' && !copyEditor) { targetGroup = this.accessor.moveGroup(sourceGroup, this.groupView, splitDirection); </ins> } <del> // Open in target group const options = fillActiveEditorViewState(sourceGroup, draggedEditor.editor, { pinned: true,										// always pin dropped editor sticky: sourceGroup.isSticky(draggedEditor.editor),	// preserve sticky state }); </del> <ins> // In any other case do a normal move/copy operation else { targetGroup = ensureTargetGroup(); if (sourceGroup === targetGroup) { return; } </ins> <del> const copyEditor = this.isCopyOperation(event, draggedEditor); if (!copyEditor) { sourceGroup.moveEditor(draggedEditor.editor, targetGroup, options); } else { sourceGroup.copyEditor(draggedEditor.editor, targetGroup, options); </del> <ins> // Open in target group const options = fillActiveEditorViewState(sourceGroup, draggedEditor.editor, { pinned: true,										// always pin dropped editor sticky: sourceGroup.isSticky(draggedEditor.editor),	// preserve sticky state }); if (!copyEditor) { sourceGroup.moveEditor(draggedEditor.editor, targetGroup, options); } else { sourceGroup.copyEditor(draggedEditor.editor, targetGroup, options); } </ins> } // Ensure target has focus

Discussion:
The steps are simple: settings editor in one group untitled editor in the group next to it sizes are equal drag the untitled editor to the left of the settings editor the sizes end up not to be equal. Insiders ! Stable ! Maybe this is related to the settings editor wanting a larger size? I can reproduce this in a small window size (the default one when you open a fresh user data dir).
Change:
} function _updateEditorModel(editor: ICodeEditor, range: Range, model: ColorPickerModel, context?: IEditorHoverRenderContext) { <del> let textEdits: ISingleEditOperation[]; </del> let newRange: Range; <ins> const textEdits: ISingleEditOperation[] = []; </ins> if (model.presentation.textEdit) { <del> textEdits = [model.presentation.textEdit]; </del> <ins> textEdits.push(model.presentation.textEdit); </ins> newRange = new Range( model.presentation.textEdit.range.startLineNumber, model.presentation.textEdit.range.startColumn,

Discussion:
When a provides multiple ColorPresentations, they can be cycled by clicking on the text in the color picker because dragging the color selector around does not close the color picker: ! However, if the contains , the color picker closes immediately upon clicking anywhere, making it impossible to select any other presentation. Clicking where you'd normally cycle through the presentations also immediately closes the picker. ! Here's an example. Paste this into a newly created VS Code extension, change to and then open a file with at least a few lines.
I have this same problem, its super annoying. ! Whenever I put my mouse on the tiny color box, the color palette opens and when I hover the mouse to select a color, the entire color palette disappears. I need to keep on repeating the above steps until the color palette does not close anymore. Whats the fix to this issue? How can I use a color picker from an extension plugin? Thanks.
Can confirm in vscode insiders it has been fixed
Thanks for picking up on it this issue will be closed
This doesn't seem fixed in Insiders to me. Using the same code provided in my OP above. If anything, it seems to close more aggressively (sometimes just clicking on the colour block toggles it open and closed very quickly):
I see, apologies, I will reopen the issue
So frustrating, I have the same issue with my vs code.
Same here. Started closing on click about a month ago.
same here it is very annoyng. has any1 found a way to fix it<
Facing the same issue
Got the same problem
thanks! what's the release milestone for the fix?
Hey this fix will go into Insiders soon, and then it will land in stable only end of January, which is when our next stable release is.
the colour picker stays open now, but it's not updating the range correctly, it's just inserting on every click. Let me know if I should file a new issue about this (it's not really the same bug, but I suspect it might occur as a result of this fix): I'm using the same code I posted above to repro.
Hi thank you for posting about this and apologies, it looks like the fix has caused a regression. Yes if you could please open an issue that would be great.
I've opened
Change:
return; // TODO support auxiliary editor state } <del> async close(): Promise<void> { // TODO this needs full support for closing all editors, handling vetos and showing dialogs </del> <ins> close(): void { this.doClose(true /* merge all groups to main part */); } private doClose(mergeGroupsToMainPart: boolean): void { if (mergeGroupsToMainPart) { for (const group of this.groups) { this.editorPartsView.mergeGroup(group, this.editorPartsView.mainPart.activeGroup); } } </ins> this._onDidClose.fire(); } }

Discussion:
Testing It would be great if we can have a command to bring back those editors to the main window.
I think that should actually be the default behaviour when you just close the window. That will prevent ugly confirmation dialogs for dirty editors when you attempt to close the floating window.
Verification: open a floating window with some editors (e.g. by dragging an editor tab out of the window) close the floating window, e.g. from the X window button verify all editors of the floating window are moved back to the main window
Change:
return this._view; } <del> const toolbar = this.instantiationService.createInstance(WorkbenchToolBar, this.toolbarContainer, { </del> <ins> const toolbar = this._register(this.instantiationService.createInstance(WorkbenchToolBar, this.toolbarContainer, { </ins> actionViewItemProvider: action => { return createActionViewItem(this.instantiationService, action); }, renderDropdownAsChildElement: true <del> }); </del> <ins> })); </ins> const deleteToolbar = this._register(this.instantiationService.invokeFunction(accessor => createDeleteToolbar(accessor, this.toolbarContainer, 'cell-delete-toolbar'))); if (model.deleteActions.primary.length !== 0 || model.deleteActions.secondary.length !== 0) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: macOS Steps to Reproduce: a notebook it a memory snapshot cell text models are not released <img width="1648" alt="image" src=""
Change:
private updateConfigurationSchema(codeActionContributions: readonly CodeActionsExtensionPoint[]) { const newProperties: IJSONSchemaMap = {}; <ins> const newNotebookProperties: IJSONSchemaMap = {}; </ins> for (const [sourceAction, props] of this.getSourceActions(codeActionContributions)) { this.settings.add(sourceAction); newProperties[sourceAction] = createCodeActionsAutoSave(nls.localize('codeActionsOnSave.generic', "Controls whether '{0}' actions should be run on file save.", props.title)); <ins> newNotebookProperties[sourceAction] = createNotebookCodeActionsAutoSave(nls.localize('codeActionsOnSave.generic', "Controls whether '{0}' actions should be run on file save.", props.title)); </ins> } codeActionsOnSaveSchema.properties = newProperties; <ins> notebookCodeActionsOnSaveSchema.properties = newNotebookProperties; </ins> Registry.as<IConfigurationRegistry>(Extensions.Configuration) .notifyConfigurationSchemaUpdated(editorConfiguration); } private updateConfigurationSchemaFromContribs() { const properties: IJSONSchemaMap = { ...codeActionsOnSaveSchema.properties }; <ins> const notebookProperties: IJSONSchemaMap = { ...notebookCodeActionsOnSaveSchema.properties }; </ins> for (const codeActionKind of this.settings) { if (!properties[codeActionKind]) { properties[codeActionKind] = createCodeActionsAutoSave(nls.localize('codeActionsOnSave.generic', "Controls whether '{0}' actions should be run on file save.", codeActionKind)); <ins> notebookProperties[codeActionKind] = createNotebookCodeActionsAutoSave(nls.localize('codeActionsOnSave.generic', "Controls whether '{0}' actions should be run on file save.", codeActionKind)); </ins> } } codeActionsOnSaveSchema.properties = properties; <ins> notebookCodeActionsOnSaveSchema.properties = notebookProperties; </ins> Registry.as<IConfigurationRegistry>(Extensions.Configuration) .notifyConfigurationSchemaUpdated(editorConfiguration); }

Discussion:
Testing I have the following set: When using the sample extension at I expect this to not trigger the code action on save but it does do it. Because there is no auto-complete I tried a bunch of other things also to no avail.
Change:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": version "4.0.1" <del> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/2e3736e4b916ee64ed92ebfabeaa94643612665a" </del> <ins> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/1e0d09f9174b3ee1537de2586ce8d8a460284ce4" </ins> dependencies: katex "^0.13.0"

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.67.1 (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: following markdown code in jupyter notebook the cell formula wrapped in shows in display style ! ! correct in browser: !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!