jiebi/CodeConvo huggingface dataset:
Change:
const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ publish: boolean }>('showActionButton', { publish: true }); <del> // Branch does have an upstream, commit is in progress, or the button is disabled if (this.state.HEAD?.upstream || this.state.isCommitInProgress || !showActionButton.publish) { return undefined; } </del> <ins> // Branch does have an upstream, commit/merge is in progress, or the button is disabled if (this.state.HEAD?.upstream || this.state.isCommitInProgress || this.state.isMergeInProgress || !showActionButton.publish) { return undefined; } </ins> return { command: {

Discussion:
a folder/workspace that contains a git repository a topic branch changes to main and the topic branch that would result in a merge conflict main into the topic branch to get a conflict Expected: commit action button is disabled Actual: commit action button is enabled
The button is now disabled while merging is in progress, but the button and the dropdown both take on a background color when clicked, which was confusing to me: !
Also, while the commit action button is disabled, the commit button above the input box is not: !
That is expected. At the moment the enablement is only toggled for the commit action button and not the commit action in the toolbar.
This is currently being tracked as
Change:
for (const cell of ref.object.notebook.cells) { if (cell.handle === data.handle) { <ins> if (cell.outputs.length === 1) { // single output const streamOutputData = this._getStreamOutputData(cell.outputs[0].outputs); if (streamOutputData) { result = this._modelService.createModel( streamOutputData, this._modeService.create('plaintext'), resource ); break; } } </ins> const content = JSON.stringify(cell.outputs.map(output => ({ metadata: output.metadata, outputItems: output.outputs.map(opit => ({

Discussion:
Version: 1.59.0-insider (user setup) Commit: Date: 2021-08-04T09:44:34.203Z (1 day ago) Electron: 13.1.7 Chrome: 91.0.4472.124 14.16.0 V8: 9.1.269.36-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: In a Python notebook or interactive session done click on "show more (open the raw output data in a text editor) ..." ! I would have expected to just see a file with numbers from 1 to 1000
Make sense to me. For single mimetype output, we should directly convert that to the right format.
Change:
const jsTsLanguageConfiguration: vscode.LanguageConfiguration = { indentationRules: { decreaseIndentPattern: /^((?!.*?/*).**/)?s*[}]].*$/, <del> increaseIndentPattern: /^((?!//).)*({([^}"'`]*|(t|[ ])*//.*)|([^)"'`]*|[[^]"'`]*)$/, </del> <ins> increaseIndentPattern: /^((?!//).)*({([^}"'`/]*|(t|[ ])*//.*)|([^)"'`/]*|[[^]"'`/]*)$/, </ins> // e.g.  * ...| or */| or *-----*/| unIndentedLinePattern: /^(t|[ ])*[ ]*[^/]**/s*$|^(t|[ ])*[ ]*/s*$|^(t|[ ])*[ ]*([ ]([^*]|*(?!/))*)?$/ },

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 OS Version: MacOS Monterey Steps to Reproduce: a JavaScript file. enter. next line is indented because it doesn't realise the is in a regular expression.
/assign mjbvz -Tyriar
It looks like it is looking for a matching closing bracket. Indent: Indent: No Indent: No Indent:
Change:
static readonly options = { id: 'editor.action.surroundWithSnippet', title: { <del> value: localize('label', 'More...'), original: 'More...' </del> <ins> value: localize('label', 'Surround With Snippet...'), original: 'Surround With Snippet...' </ins> } };

Discussion:
Type: <bBug</bMy VScode won't run anything. i typed basic java code and nothing shows up no matter how i run it. my code is below. class QuickStart { public static void main (String[] args) { ("Hello, World."); } } VS Code version: Code 1.86.2 (, 2024-02-13T19:40:56.878Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (8)</summaryExtensionVersion ------ java1.28.1 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.56.0 vscode-java-dependency0.23.4 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.44.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/extJava
It looks like this is caused by the Java extension. Please file the issue to the . Make sure to check their and provide relevant information such as the extension version you're using. See also our for more information. Happy Coding!
Change:
import { ActivitybarPart } from 'vs/workbench/browser/parts/activitybar/activitybarPart'; import { URI } from 'vs/base/common/uri'; import { IViewDescriptorService, ViewContainerLocation } from 'vs/workbench/common/views'; <ins> import { DiffEditorInput } from 'vs/workbench/common/editor/diffEditorInput'; </ins> export enum Settings { ACTIVITYBAR_VISIBLE = 'workbench.activityBar.visible',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --When in centered layout, opening a diff view in inline mode (as opposed to side-by-side mode) should not force the diff view into full editor width as it does for side-by-side diff views. This is a follow-up from where we discussed this might be a bug. Steps to Reproduce: centered layout a diff view in inline mode diff view now occupies full editor width (as if centered layout was not enabled) Demo: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
how to check if diff is in inline view? would you like to submit a PR to fix this? Code pointer
I'm afraid this is too much for me at this moment. The method is not fired when I switch from inline to side-by-side diff view and I could not figure out how to query the instance for the current display mode. Both of these events would need to be handled so that we can keep the centered layout when an inline diff is opened and we should switch to full-width layout when the diff editor's layout is switched from inline to side-by-side.
no worries, thanks for trying. Peng might give some good tips, and I might also look into this in the future.
Apologies for not mentioning that I was working on this, but I implemented a fix for this in
I was playing around with this too and managed to fix it, so I created a PR. My browser did not update so I didn't see your message, sorry for the duplicate PR :sweat_smile:
No problem! haha both our bads I guess :rofl: Next time I'll comment beforehand
Change:
{ "text": "}", "kind": "link" }, { "text": " b", "kind": "text" } ], noopToResource), <del> 'a [`dog`](file:///path/file.ts#L7%2C5) b'); </del> <ins> 'a [`dog`](command:_typescript.openJsDocLink?%5B%7B%22file%22%3A%7B%22path%22%3A%22%2Fpath%2Ffile.ts%22%2C%22scheme%22%3A%22file%22%7D%2C%22position%22%3A%7B%22line%22%3A6%2C%22character%22%3A4%7D%7D%5D) b'); </ins> }); test('Should render @linkcode text as code', async () => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: see below, pulled from the "Help About" dialog. Also confirmed in 1.71.2. OS Version: see below, pulled from the "Help About" dialog. Steps to Reproduce: above VSCode Insiders build. (Instructions don't require system path to be updated.) a directory in WSL, say . , where is the distro of your choice. the WSL extension as prompted and reload. the editor and run , where is the distro of your choice. (Steps 2-4 were just to initialize some VSCode state.) a new file in that directory with the following contents: restart editor. (Works either way.) over above. tooltip will appear with "some thing linking Foo" where is hyperlinked. Click the hyperlink in the tooltip. attempts to open a file at the path in the parent Windows OS, outside of any WSL distro. Note that this reproduces both with the WSL extension enabled the whole time (skipping step 5) and with it disabled at step 5.
Did this get missed?
I have the same issue with VSCode running in WSL2 (Ubuntu)
Same issue here, using a remote connection to a VM running on Hyper-V. Host OS is Windows, guest OS is Ubuntu 22.04. It only happens when clicking the link in the tooltip. Using directly in the editor works as expected.
Still seeing this issue. Looking forward to this getting resolved soon.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
stickiness: TrackedRangeStickiness.AlwaysGrowsWhenTypingAtEdges, afterContentClassName: 'inline-folded', isWholeLine: true, <del> firstLineDecorationClassName: 'alwaysShowFoldIcons ' + ThemeIcon.asClassName(foldingExpandedIcon) </del> <ins> firstLineDecorationClassName: ThemeIcon.asClassName(foldingManualCollapsedIcon) </ins> }); private static readonly MANUALLY_COLLAPSED_HIGHLIGHTED_VISUAL_DECORATION = ModelDecorationOptions.register({

Discussion:
Expected: only gutter controls are removed, background and ellipsis - preserved Actual: The background color no longer applied & the ellipsis is missing on the folded lines.VS Code Version: 1.70.0 (user setup) OS Version: Windows_NT x64 10.0.
Change:
pane?.terminalTabbedView?.focusHover(); } <ins> async focusInstance(_: ITerminalInstance): Promise<void> { return this.showPanel(true); } </ins> async focusActiveInstance(): Promise<void> { return this.showPanel(true); }

Discussion:
Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
In this scenario, focus also fails.
I can confirm that fixes the problem for me. Thanks!
Change:
const position = new Position(change.modifiedStartLineNumber, 1); outerEditor.setPosition(position); <del> outerEditor.revealPosition(position); </del> <ins> outerEditor.revealPositionInCenter(position); </ins> } } registerEditorAction(MoveToNextChangeAction);

Discussion:
I have these keybinding: Currently it doesn't center the viewport like F3, which makes it less nice.
You mean you want it to center the viewport when the editor needs to be scrolled?
I'm interested to work on this as my first issue. Will you point me in the right direction
Looks like a PR is already out
Change:
return '<img ' + attributes.join(' ') + '>'; }; renderer.link = (href, title, text): string => { <ins> // Remove markdown escapes. Workaround for https://github.com/chjj/marked/issues/829 if (href === text) { // raw link case text = removeMarkdownEscapes(text); } title = removeMarkdownEscapes(title); href = removeMarkdownEscapes(href); </ins> return `<a href="#" data-href="${href}" title="${title || text}">${text}</a>`; }; renderer.paragraph = (text): string => {

Discussion:
According to and . should be used to escape a dot. However, it looks like our hover renderer doesn't unescape the dot when in a link !
Sorry to bother yall but is there an ETA on this? I'm hoping to release/publicize a project soon that relies heavily on json-schemas but I don't want to publicize it until this is fixed (because it will be a bad UX and I want people to have good experience the first time they try the thing). Thanks
From a quick look, the root cause may be the processing we do in the js extension for files: Can you please share an example json file that shows this in the latest builds. Thanks.
Verifying bug on master, latest commit ! See my original ticket for repro steps
Verified in code.
I still see unescaped characters: ! I created
Verified fix on master @ Thanks! Side question: how do changes like this get into release, i.e. when might one expect this change to be deployed to users?
Change:
id: 'multiDiffEditor.collapseAll', title: { value: localize('collapseAllDiffs', "Collapse All Diffs"), original: 'Collapse All Diffs' }, icon: Codicon.collapseAll, <del> precondition: ContextKeyExpr.equals('activeEditor', MultiDiffEditor.ID), </del> <ins> precondition: ContextKeyExpr.and(ContextKeyExpr.equals('activeEditor', MultiDiffEditor.ID), ContextKeyExpr.not('multiDiffEditorAllCollapsed')), </ins> menu: { <del> when: ContextKeyExpr.equals('activeEditor', MultiDiffEditor.ID), </del> <ins> when: ContextKeyExpr.and(ContextKeyExpr.equals('activeEditor', MultiDiffEditor.ID), ContextKeyExpr.not('multiDiffEditorAllCollapsed')), </ins> id: MenuId.EditorTitle, group: 'navigation', },

Discussion:
We have a "collapse all" button: And other places in vscode this typically toggles to an "expand all". Would make sense to have it here as well
PR is now available for review
Change:
"win32RegValueName": "CodeOSS", "win32AppId": "{{E34003BB-9E10-4501-8C11-BE3FAA83F23F}", "win32AppUserModelId": "Microsoft.CodeOSS", <ins> "win32ShellNameShort": "C&ode - OSS", </ins> "darwinBundleIdentifier": "com.visualstudio.code.oss", "reportIssueUrl": "https://github.com/Microsoft/vscode/issues/new", "urlProtocol": "code-oss"

Discussion:
VSCode Version: 1.7.2 OS Version: Windows Server 2008/2012 Steps to Reproduce: No shortcut (underline) for flie right click context menu. ! Such underline shortcut is very useful to fast open the file with VSCode with keyboard.
Are there any recommendations/specifications as to what the shortcut should be for this?
I think the installer is not in the repo ;)
Change:
apply(): void { if (this._edits.length > 0) { this._edits = this._edits <del> .sort((a, b) => Range.compareRangesUsingStarts(a.range, b.range)) .map(edit => ({ ...edit, text: edit.text && SnippetParser.escape(edit.text) })); </del> <ins> .map(this._transformSnippetStringToInsertText, this) // no editor -> no snippet mode .sort((a, b) => Range.compareRangesUsingStarts(a.range, b.range)); </ins> this.model.pushEditOperations(null, this._edits, () => null); } if (this._newEol !== undefined) { this.model.pushEOL(this._newEol); } } <ins> protected _transformSnippetStringToInsertText(edit: ISingleSnippetEditOperation): ISingleSnippetEditOperation { // transform a snippet edit (and only those) into a normal text edit // for that we need to parse the snippet and get its actual text, e.g without placeholder // or variable syntaxes if (!edit.insertAsSnippet) { return edit; } if (!edit.text) { return edit; } const text = new SnippetParser().parse(edit.text, false, false).toString(); return { ...edit, insertAsSnippet: false, text }; } </ins> } class EditorEditTask extends ModelEditTask {

Discussion:
go to / vscode open change 200 to 50 create new branch observe that the closing brackets are replaced with } in inlineCompletionsModel please reassigned to who you think might be able to fix this. Looks like a github issue to me though. !
This looks similar to
Looks like similar thing was already fixed for organize imports and some TS actions in
This doesn't repro for me when using the stable VS Code quality on Confirmed that it still reproduces in the latest Insiders on commit
and this looks similar to
Please retry with latest insiders which should have a fix for this
can actually reproduce with latest insiders...
Change:
} const hostName = hostname(); if (hostName && hostName.match(/^([w-]+)$/)) { <del> return hostName; </del> <ins> return hostName.substring(0, 20); </ins> } return undefined;

Discussion:
Testing Pasting it as text does that.
Same cause as . The parsed hostname also included a
Marking as dup

Testing <img width="445" alt="Screenshot showing notification that the tunnel is ready, but the link to access the tunnel from doesn't render properly due to an extra space in the link." src="https://user-"

Testing using latest Insiders click Turn on Remote Tunnel Access log in using the GitHub flow Unable to turn on remote tunnel
Can you specify a different machine name with the setting ?
:+1: Using worked for me
I'm unable to verify the issue right now because my Ubuntu VM broke. is the issue resolved for you without having to set the setting?
I confirm, the issue is fixed for me
Change:
} }); <ins> // Stub repositories instantiationService.stub(ISCMService, '_repositories', new Map()); </ins> sessionSyncContribution = instantiationService.createInstance(SessionSyncContribution); });

Discussion:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.
Change:
assert.ok(notebookEditor); // Run and add a bunch of cells <del> for (let i = 0; i < 20; i++) { </del> <ins> for (let i = 0; i < 10; i++) { </ins> await addCellAndRun(`print ${i}`, notebookEditor.notebook); }

Discussion:
This test takes 30 seconds for me when running locally . !
Not sure why it takes you so long? It takes 6 seconds for me. ! The test has to execute a number of cells to make sure the output scrolls off the screen. Right now that number is 20. Executing 10 cells is probably enough on most screens, but it's still going to take a bit.
I think we should understand why execution time seems to get slower and slower the more cells there are. Check out this video, it looks as if things get slower and slower: !
Execution might be getting slower but the scrolling doesn't look like it's getting slower? That seems like a different issue.
Yeah, execution slows down, waiting for results.
Closing in favor of new issue.
Change:
}, "git.defaultBranchName": { "type": "string", <del> "description": "%config.defaultBranchName%", </del> <ins> "markdownDescription": "%config.defaultBranchName%", </ins> "default": "main", "scope": "resource" },

Discussion:
Type: <bBug</bGo to 'Source control' and click 'Initialize Repository'. An error message shows "Git:unknown switch 'b'". VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ LiveServer5.7.9 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Having the same issue after a recent update this morning. Version: 1.79.2 Date: 2023-06-14T08:58:52.392Z (1 day ago) Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
Could you please share the contents of the ? Thanks!
I encountered the same issue.... Output from GIT: 2023-06-16 10:31:06.946 [info] git init -b main [4ms] 2023-06-16 10:31:06.946 [info] error: unknown switch `b' usage: git init [-q | --quiet] [--bare] [--template=<template-directory] [--shared[=<permissions]] [<directory] --template <template-directorydirectory from which templates will be used --bare create a bare repository --shared[=<permissions] specify that the git repository is to be shared amongst several users -q, --quiet be quiet --separate-git-dir <gitdirseparate git dir from working tree 2023-06-16 10:33:13.422 [info] git rev-parse --show-toplevel [1ms] 2023-06-16 10:33:13.422 [info] fatal: not a git repository (or any of the parent directories): .git
Yes, that's the exact same Output received.
Could you please share the version of git that you are using? Thank you!
!
Change:
private activeRepositoryNameContextKey: IContextKey<string>; private activeRepositoryBranchNameContextKey: IContextKey<string>; <ins> private focusedRepository: ISCMRepository | undefined = undefined; private focusDisposable: IDisposable = Disposable.None; </ins> private readonly disposables = new DisposableStore(); <del> private readonly focusedRepositoryDisposables = new DisposableStore(); </del> constructor( @IContextKeyService contextKeyService: IContextKeyService,

Discussion:
Testing a multi folder workspace with 1 repository each the branch name updates in the statusbar, but not in the title bar until the user switches to a new tab/file
I don't repro this on Windows with a custom titlebar, but it does take a few seconds for the titlebar to change the title in my case.
Pushing a fix to for this issue. I do want to call out that the status bar item is being updated "optimistically" so that we can show a "loading" indicator while the checkout is in progress. Due to this there might be a delay in the title bar being updated as the title bar only updates when the checkout completed.
I'm seeing the same behaviour, meaning I might not have encountered the actual issue in the first place. could you verify this issue?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Pinging about verification
Change:
// Reveal the newly selected element if (next) { <ins> if (next === selected) { this.tree.setFocus([]); } </ins> this.tree.setFocus([next], getSelectionKeyboardEvent(undefined, false)); this.tree.reveal(next); }

Discussion:
Repro: vscode for "interface ITerminalChild" (or any search with a single result) F4 to some other file F4, nothing happens (presumably because the item is still selected in the search viewlet)
I think this was fixed with but we can verify it separately
Doesn't work still
Change:
public setSideBarHidden(hidden: boolean, skipLayout?: boolean): TPromise<void> { this.sideBarHidden = hidden; <ins> this.sideBarVisibleContext.set(!hidden); </ins> // Adjust CSS if (hidden) {

Discussion:
Currently there is no way to tell if sidebar is visible. You can get the state only for 2/5 viewlets. Explorer: Search: Source Control: Debug: Extensions: Sidebar (any of the above is visible):
PR that fixes this is welcome. Code pointer Basicaly the part service would need to add new context key and set it when sidebar gets shown / hidden. I propose to call this context key .