jiebi/CodeConvo huggingface dataset:
Change:
<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .monaco-workbench .part.menubar { display: flex; flex-shrink: 1; box-sizing: border-box; height: 30px; -webkit-app-region: no-drag; overflow: hidden; flex-wrap: wrap; } .monaco-workbench.fullscreen .part.menubar { margin: 0px; padding: 0px 5px; } .monaco-workbench .part.menubar > .menubar-menu-button { align-items: center; box-sizing: border-box; padding: 0px 8px; cursor: default; -webkit-app-region: no-drag; zoom: 1; white-space: nowrap; } .monaco-workbench .part.menubar .menubar-menu-items-holder { position: absolute; left: 0px; opacity: 1; z-index: 2000; } .monaco-workbench .part.menubar .menubar-menu-items-holder.monaco-menu-container { font-family: "Segoe WPC", "Segoe UI", ".SFNSDisplay-Light", "SFUIText-Light", "HelveticaNeue-Light", sans-serif, "Droid Sans Fallback"; outline: 0; border: none; } .monaco-workbench .part.menubar .menubar-menu-items-holder.monaco-menu-container :focus { outline: 0; } .hc-black .monaco-workbench .part.menubar .menubar-menu-items-holder.monaco-menu-container { border: 2px solid #6FC3DF; } </del>  No newline at end of file

Discussion:
I like how menu and title part are now merged, but I feel it could merge even more to reflect the structure in the DOM: move all of into (rename to and merge the CSS into the existing one) rename to something like do not extend from in , since this is no longer a workbench managed part
Change:
'use strict'; const gulp = require('gulp'); <ins> const merge = require('gulp-merge-json'); </ins> const fs = require('fs'); const os = require('os'); const cp = require('child_process');

Discussion:
Testing in Firefox, with Spanish (es-es) set Open "Get Started with VS Code in the Web" walkthrough Select last step (open up your code), then first command ("Open Folder" in English, "Abrir carpeta" in Spanish) Modal is in English: ! It isn't a new string, and I didn't think getting started or this command would be from an extension, but perhaps that is the case.
I also see this on modals on the overall welcome page when I try opening a file or folder: !
Thank you for your feedback. We are currently reviewing it (reference ).
This is an odd one. The string looks good here: but the file that that comes from doesn't show up at all in our Spanish files: I'll have to dig into why this is... any ideas?
might be a bug in the tool so that the localize call is not detected. When you generate the export is the string included.
Ok the web strings are now bundled in language packs. It may take a minute for all these new strings to make their way through the translation system... but by end game it should be good.
Change:
private registerActions(): void { this.registerManageProfilesSubMenu(); <ins> this.registerSelectProfileSubMenu(); this.registerProfilesActions(); this._register(this.userDataProfilesService.onDidChangeProfiles(() => this.registerProfilesActions())); </ins> this.registerCurrentProfilesActions(); this._register(Event.any(this.userDataProfileService.onDidChangeCurrentProfile, this.userDataProfileService.onDidUpdateCurrentProfile)(() => this.registerCurrentProfilesActions())); } private registerManageProfilesSubMenu(): void { <del> MenuRegistry.appendMenuItem(MenuId.GlobalActivity, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu, group: '5_settings', when: PROFILES_ENABLEMENT_CONTEXT, order: 1 }); </del> MenuRegistry.appendMenuItem(MenuId.MenubarPreferencesMenu, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu,

Discussion:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified
Change:
if (resource) { this._editorService.openEditor({ resource: URI.revive(resource), <ins> description: instance.shellLaunchConfig.description, </ins> options: { pinned: true,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
this._wrapperElement.appendChild(this._xtermElement); this._container.appendChild(this._wrapperElement); xterm.open(this._xtermElement); <del> if (this._configHelper.config.rendererType === 'experimentalWebgl') { </del> <ins> const suggestedRendererType = this._storageService.get(SUGGESTED_RENDERER_TYPE, StorageScope.GLOBAL); if (this._configHelper.config.rendererType === 'auto' && (suggestedRendererType === 'auto' || suggestedRendererType === undefined) || this._configHelper.config.rendererType === 'experimentalWebgl') { </ins> this._enableWebglRenderer(); }

Discussion:
Part of We should also improve the fallback logic to do this: Try webgl If it threw an exception, try canvas If frame rendering averages 50ms (existing detection), use DOM We will keep the canvas renderer around for now mainly because Safari doesn't support webgl2 and can evaluate again at a later date.
It looks like canvas is still the default for me -- the is present unless I explicitly enable experimentalWebgl. I don't see any notifications of errors that could be causing it.
Change:
color: var(--vscode-textPreformat-foreground); } <del> .hc-black .interactive-item-container .value .rendered-markdown a:hover, .hc-black .interactive-item-container .value .rendered-markdown a:active, .hc-light .interactive-item-container .value .rendered-markdown a:hover, .hc-light .interactive-item-container .value .rendered-markdown a:active { color: var(--vscode-textPreformat-foreground); } </del> .interactive-list { overflow: hidden; }

Discussion:
We currently distinguish links using only color, no underline in some places. This can make it hard for color blind or low vision users to differentiate between links and regular text. Underlines can also reduce readability though. Thoughts or ? ! !
Hi all, Live Share has a sev2 bug assigned for it. It effects our Accessibility Grade. I filed an extension request for it.
How about we start with enabling this in the High Contrast themes?
This one is trickier than I thought. VS Code uses elements throughout the IDE also for things like tabs and buttons, so we need to find a way to only match the elements that look like text... edit: we can match .
I noticed that we do this in the editor even for non-HC themes. !
After some investigation, matching doesn't work as it's the default role and we can only match it if it's explicitly set in the element. Looking for some other solutions, but we may need to add the role attribute explicitly everywhere.
do you have advice how we might work around this?
We do not have an issue filled for this as is my understanding. LiveShare has it, and filling extension is the right approach (which was already done). So for now I suggest no action here.
I still think this is a good thing to look into. Our links in the HC themes don't look very contrasty in any case: <img width="722" alt="image" src=""I realised we don't need to underline all links, just those that appear in a text. So matching should do the trick.
that's a fair point. So could we fix for High Contast only first?
yes, we'll keep it to HC themes for now. I've managed to get it to match only relevant text links that have surrounding text. As you can see standalone text links won't be underlined. GitHub also does not do this. I think it looks pretty good (ignore the red colour, it's to check we're matching the right things and I will reset it): <img width="1150" alt="image" src=""<img width="421" alt="image" src=""<img width="943" alt="image" src=""
Specially in the light HC theme it's a big improvement: <img width="343" alt="image" src=""
Looking good for the HC theme.

Thank you
Should these have underlines in HC? ! Otherwise, verified in welcome views and chat.
these don't need to be underlined. Only links in a paragraph surrounded by other text.
Adding setting to enable link underlines in
Change:
const lineHeight = editor.getOption(EditorOption.lineHeight); const contentHeight = (editor.getModel()?.getLineCount()! * lineHeight) ?? editor.getContentHeight(); // Can't just call getContentHeight() because it returns an incorrect, large, value when the editor is first created. if ((contentHeight > layoutInfo.height) || <del> (contentHeight < layoutInfo.height && currentHeight > STARTING_EDITOR_HEIGHT)) { </del> <ins> (contentHeight < layoutInfo.height && currentHeight > MIN_EDITOR_HEIGHT)) { </ins> const linesToAdd = Math.ceil((contentHeight - layoutInfo.height) / lineHeight); <del> const maxCommentEditorHeight = Math.max(Math.min(MAX_EDITOR_HEIGHT, parentEditor.getLayoutInfo().height - 90), STARTING_EDITOR_HEIGHT); const newEditorHeight = Math.min(maxCommentEditorHeight, layoutInfo.height + (lineHeight * linesToAdd)); return newEditorHeight; </del> <ins> const lowerBoundOfMaxEditorHeight = Math.max(parentEditor.getLayoutInfo().height - 90, MIN_EDITOR_HEIGHT); const maxCommentEditorHeightForParentEditor = Math.min(MAX_EDITOR_HEIGHT, lowerBoundOfMaxEditorHeight); const proposedHeight = layoutInfo.height + (lineHeight * linesToAdd); return Math.min(maxCommentEditorHeightForParentEditor, Math.max(MIN_EDITOR_HEIGHT, proposedHeight)); </ins> } return currentHeight; }

Discussion:
window a comment :bug: as you can see from the scrollbar, the comment text doesn't fill the full editor !
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
closedWith
Change:
} } <del> toJSON(): IOutputDto { </del> <ins> asDto(): IOutputDto { </ins> return { // data: this._data, metadata: this._rawOutput.metadata,

Discussion:
After the latest update today, I'm seeing this message printed out while running my unit tests with the VSCode test runner: ! Specifically, these errors are appearing when I'm issuing commands to run notebook cells to test my controller.
Reverting back from to seems to have fixed the issue for Jupyter Notebooks.
To reproduce put a breakpoint here debug integration/API tests (open code from code-oss and debug integration tests) notebook tests hit this error This is triggered because invalid data is send to a worker. The bad worker is the notebook editor simple worker, the call happens here: The problem is that the dto isn't pure, it contains references to live object which cannot be cloned/send. <img width="1426" alt="Screenshot 2023-08-11 at 14 16 29" src=""
I have the same problem. VSCode version 1.81.1. Is there a solution already available?
it should be fixed in insiders and will be released to stable next week
Change:
if (options) { inputOptions.password = options.password; inputOptions.placeHolder = options.placeHolder; <ins> inputOptions.noValuePreselect = options.noValuePreselect; </ins> inputOptions.prompt = options.prompt; inputOptions.value = options.value; inputOptions.ignoreFocusLost = options.ignoreFocusOut;

Discussion:
VSCode Version: 1.5.0-insider OS Version: Windows 10 Steps to Reproduce: value is highlighted/selected Currently we can't put the cursor at the end of the default value when running . In this case, users have to move the cursor manually if we want to keep the default value as prefix always.
That's actually indented use case since the user is likely to accept <kbdEnter</kbdor over write the pre-set value. What is your use-case for this?
This features originally comes from implementing Vim's Ex commands, which support line range as a prefix like represents and represents . When users trigger Ex command by , Vim will help fulfill the line range prefix automatically and then users can type commands directly, eg for replacement. If users don't like the line range Vim puts there automatically, they need to use to delete the range characters. Vim doesn't select those characters it auto-completes but Code does, so I'm asking if it's possible to add this support to .
It would also help if a selection range could be defined. In my case I would like set the whole file path as value but only select the file base name. e.g. /path/to/file/ Users most likely will only change the but should also have the possibility to change the path.
Concurring to what said. I have an open question on Stack overflow:
+1 to this, it is very counterintuitive to do visual block find/replaces with VSCodeVim as noted in the above mentioned issues with this default behavior. If it were configurable like makes it, that would be useful for better emulating vim-style editing for VSCodeVim users like myself!
Change:
if (!this.tree.getFocus().includes(match) || !this.tree.getSelection().includes(match)) { this.tree.setSelection([match], getSelectionKeyboardEvent()); <ins> this.tree.setFocus([match]); </ins> } }

Discussion:
some text in an editor +shift+f and search for that text screen reader will report that the result is on a column that is actual+2 !
pretty sure this is by design, but can answer that
Thinking about it, it seems to not make much sense to start at 2 (although I see this behavior in areas outside of notebooks). do you see why this should be design? If not, I can go ahead and try to make the columns start at 1 like it does in the editor.
Yeah that sounds good to me thanks

repro: in settings notebook search filter to look at outputs all editors for something that only appears in outputs on the result and wait for the results to convert to rich notebook results list focus has shifted !
Hi - I'm attempting to replicate this bug, but cannot generate the output from a notebook because my build (Code - OSS Dev) crashes when I select a kernel for my notebook with the message . I am getting the extension form How were you able to get the Jupyter notebook running in your build?
I installed the Jupyter extension via the vsix that is in the marketplace install page.
Thank you for the reply! I still run into the same error after installing the extensions from vsix when I select the kernel. Console output
Hmm, I'm not sure why this would happen. Since this is not really related to this issue directly, could you file a new issue?
I believe the issue is related to this line in folderMatch.allDownstreamFileMatches() is returning a set of notebook files that excludes the parent file of the current selection.
Change:
return args; } <ins> function stripEmptyPath(argv: string[]): string[] | undefined { const index = firstIndex(argv, a => !/^-/.test(a)); if (index > -1 && argv[index] === '') { argv.splice(index, 1); } return argv; } </ins> function stripAppPath(argv: string[]): string[] | undefined { const index = firstIndex(argv, a => !/^-/.test(a));

Discussion:
VSCode Version: 1.26.0 OS Version: macOS Steps to Reproduce: in command line. Code seems opened a workspace of current directory folder, like Does this issue occur when all extensions are disabled?: Yes When I run some command like (e.g. in Linux), if the inner command failed, it return empty string as argument. VSCode shouldn't open current directory and replace the workspace (which is annoying), but should just open or focus the application instead.
Note: Neither Notepad++ or Sublime Text will open a folder wrongly with empty string argument.
what would you expect to happen, open an empty window?
Yes. Or focus existing window only. Just like running .
Wrong press "close"
Can I be assigned to this? I'd like to take a stab at it.
I've code that should do the trick. I've tested that it removes an empty argument. I wasn't able to test the actual functionality though because both and change the current directory. I couldn't figure out how to mimic production without hacking the startup scripts.
I just edited the main description to add an example usage - - which open a script file in environment PATH by VS Code to edit it. If the argument "$1" (for the script name) have typo, VS Code open a big slow workspace folder annoyingly. The existing behavior has no use, and it put the burden to user to write extra lines of if-else to avoid it, resulting in a big command & more typings.
Change:
this.dropdownMenu.show(); } } <ins> protected updateEnabled(): void { const disabled = !this.getAction().enabled; this.actionItem?.classList.toggle('disabled', disabled); this.element?.classList.toggle('disabled', disabled); } </ins> } export interface IActionWithDropdownActionViewItemOptions extends IActionViewItemOptions {

Discussion:
Related to If you have a command in an action bar (say in ) that is a submenu with no items (or no visible items), there is no visible indication -- the icon is there, but does nothing if you click on it. I would expect similar behavior to
Change:
import { KeyChord, KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { Disposable, DisposableStore, MutableDisposable } from 'vs/base/common/lifecycle'; import { Schemas } from 'vs/base/common/network'; <del> import { isObject } from 'vs/base/common/types'; </del> <ins> import { isBoolean, isObject, isString } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import 'vs/css!./media/preferences'; import { EditorContributionInstantiation, registerEditorContribution } from 'vs/editor/browser/editorExtensions';

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Actions like current only accepts options in . Allowing setting other options from like allows extensions directly open json setting editor with specific setting keys (when the extension is asking user to edit some custon json settings)
Leaving this to you for the action to be taken.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
} private onDidDismissExtensionSetting(extensionId: string): void { <del> if (this.dismissedExtensionSettings.includes(extensionId)) { return; </del> <ins> if (!this.dismissedExtensionSettings.includes(extensionId)) { this.dismissedExtensionSettings.push(extensionId); </ins> } <del> this.dismissedExtensionSettings.push(extensionId); </del> this.storageService.store( this.DISMISSED_EXTENSION_SETTINGS_STORAGE_KEY, this.dismissedExtensionSettings.join(this.DISMISSED_EXTENSION_SETTINGS_DELIMITER),

Discussion:
a new empty profile a new window with that profile for the window to load the Settings editor that a Copilot entry shows up under Commonly Used. If not, try reloading the window the dismiss button :bug: Entry does not dismiss I'm unable to repro this issue locally
Change:
} if (needAllVersions.size) { <del> const startTime = new Date().getTime(); </del> <ins> const stopWatch = new StopWatch(); </ins> const query = new Query() .withFlags(flags & ~Flags.IncludeLatestVersionOnly, Flags.IncludeVersions) .withPage(1, needAllVersions.size) .withFilter(FilterType.ExtensionId, ...needAllVersions.keys()); const { extensions } = await this.queryGalleryExtensions(query, criteria, token); this.telemetryService.publicLog2<GalleryServiceAdditionalQueryEvent, GalleryServiceAdditionalQueryClassification>('galleryService:additionalQuery', { <del> duration: new Date().getTime() - startTime, </del> <ins> duration: stopWatch.elapsed(), </ins> count: needAllVersions.size }); for (const extension of extensions) {

Discussion:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.
Change:
let hasDecoration = false; if (currLineDecorations) { for (const decoration of currLineDecorations) { <del> if (decoration.options.glyphMarginClassName) { </del> <ins> const glyphClass = decoration.options.glyphMarginClassName; if (glyphClass && !this.lightbulbClasses.some(className => glyphClass.includes(className))) { </ins> hasDecoration = true; break; }

Discussion:
The icon should be right above line 2, but it's all the way up at the beginning of line 1. !
this should be fixed with the new lightbulb changes!
Still able to reproduce this. long text and enable word wrap the cursor on line 2 and press Ctrl + . ! ESC Ctrl + . again !
Still able to repro. If I repeat steps 3 and 4, I notice that the sparkle alternates between the two lines. Edit: might have to wait for new Insiders.
I see similar to what saw, but the second time it didn't show at all: ! ! I'll push this to September as it doesn't meet the bar to fix at this point imo.
not sure why it removed the unreleased since this commit hasn't been released yet
It's good now