jiebi/CodeConvo huggingface dataset:
Change:
override getTooltip() { // label: just workspace name and optional decorations const { prefix, suffix } = windowTitle.getTitleDecorations(); <del> let label = windowTitle.workspaceName; </del> <ins> let label = windowTitle.isCustomTitleFormat() ? windowTitle.getWindowTitle() : windowTitle.workspaceName; </ins> if (!label) { label = localize('label.dfl', "Search"); }

Discussion:
Testing I think we will soon turn command center on by default. What is the impact on then? I see we are only showing the full title in the hover now, but I wonder if we need another setting (?) so that users still can configure what we show in the command center? ! Or maybe we should find a way to show the even in the command center with ellipsis if overflowing. //cc
Seems reasonable to me
Enabling the command centre removes my custom window title, showing the full path of the currently focussed editor. I find this very useful especially when there are files with the same name but in different directories. Can't the command centre show the full custom window title (without having to hover over it)? Without this, I would permanently disable it.
We can say the default is different but a customisation is honoured
To verify enable command center configure and/or validate that any customization is picked up by the CC reset above settings validate that the CC uses a default
Any reason we wouldn't also apply this with the default setting? My worry is that when we eventually make command center on by default, the setting would basically not work until you change it? I think it looks good when enabled even with default setting: !
The idea is that the CC shows an affordance to do something, like "Search vscode" - we replaced "search" with the icon which watered this down a bit. The worry is that the more title-stuff we put here the less likely it is that folks understand this as affordance
Change:
} catch (error) { this._handleError(error); return Promise.reject(error); <ins> } finally { this._inProgressTasks.delete(task._label); </ins> } }

Discussion:
<img width="423" alt="image" src="https://user-"
I am unable to repro this - could you pls provide the steps that you take?
I have not found a pattern so far, might be timing related. It is not happening everytime I reload the window... However, one thing to keep in mind is that I often use and not . That command kills the build task and relaunches it: So that may well be related to the issue.
Thanks for the idea, but seems unrelated to that command as has reproduced this with
Change:
workspace.onDidChangeConfiguration(e => { if (e.affectsConfiguration('git.mergeEditor')) { <del> // this.mergeGroup.resourceStates = this.mergeGroup.resourceStates.map(r => r.clone()); this.status(); </del> <ins> this.mergeGroup.resourceStates = this.mergeGroup.resourceStates.map(r => r.clone()); </ins> } }, undefined, this.disposables);

Discussion:
I guess the reload/refresh logic that we isn't working...
This is what I am reproducing enabled -disabled: works disabled -enabled: fails
I will push a workaround, refresh the SCM view when the config changes, because re-setting the merge group () doesn't seem to work reliably. I debugged this in to  but wasn't able to get to the bottom of this. When calling the method it seems that is already updated with what I am expecting to be updating now... fyi
Change:
.codicon-debug-breakpoint-conditional.codicon-debug-stackframe::after, .codicon-debug-breakpoint.codicon-debug-stackframe-focused::after, .codicon-debug-breakpoint.codicon-debug-stackframe::after { <del> content: var(--vscode-icon-circle-small-filled-content); font-family: var(--vscode-icon-circle-small-filled-font-family); </del> <ins> content: var(--vscode-icon-debug-stackframe-dot-content); font-family: var(--vscode-icon-debug-stackframe-dot-font-family); </ins> position: absolute; }

Discussion:
Followup from The icons for a breakpoint with stackframe is . Currently, the code uses . On codicons that's the same icon, on other product icon theme that could be a separate icon.
To verify: download , rename to install, switch to the Product icon theme VS Code 1.0 icons create a python program ` set breakpoint at hello world run to the breakpointthe breakpoint icon should turn into a smiley
fyi
Change:
if (treeInput === undefined) { return; } <del> this.viewHasSomeCollapsibleRootItem.set(hasExpandedRootChild(this.tree, treeInput)); </del> <ins> const treeInputArray = Array.isArray(treeInput) ? treeInput : Array.from(treeInput.children.values()); // Has collapsible root when anything is expanded this.viewHasSomeCollapsibleRootItem.set(hasExpandedNode(this.tree, treeInputArray)); </ins> } styleListDropBackground(styles: IExplorerViewStyles): void {

Discussion:
Lately (since a few days) I see the explorer show an expand all icon even though some folders are expanded (in a multi root workspace): <img width="300" alt="image" src="https://user-"This must be a recent regression, not sure if in explorer or tree widget.
See
This breaks my muscle memory, I always collapse the explorer to start a new task and the new behaviour breaks this. I really see no value of this new behaviour? It is not even expanding all folders, only the ones that can be resolved? What is the use case?
As a suggestion: only show the expand button when really all nodes are collapsed, but keep the collapse button when any node is expanded.
I'm with this is quite different behavior in a multi-root workspace, I have one workspace with 5 root folders and another with 10+, prior to this change clicking the expand/collapse button in explorer would collapse all the folders in each root folder, clicking again would then collapse all the root folders. What I get now is the following: If all root folders are collapsed, clicking the expand/collapse button does nothing If one root folder is open the expand/collapse button expands and collapses folders within that root folder More than one root folder open the same as before for all of the open root folders Perhaps we could have an option to opt-in to this new behavior, I can't think of a single reason why I would want to expand every folder in a project.
Feature got removed.
Change:
private async scrollUp_LoadDisassembledInstructions(instructionCount: number): Promise<boolean> { if (this._disassembledInstructions && this._disassembledInstructions.length > 0) { const address: string | undefined = this._disassembledInstructions?.row(0).instruction.address; <del> return this.loadDisassembledInstructions(address, -instructionCount, instructionCount - 1); </del> <ins> return this.loadDisassembledInstructions(address, -instructionCount, instructionCount); </ins> } return false;

Discussion:
VS Code Version: 1.61.0-insider Steps to Reproduce: This is reproducible in the mock debugger: the disassembly view and scroll up to the address 0xf5 that 0xf4 is skipped. <img width="388" alt="Screen Shot 2021-09-29 at 9 13 10 PM" src="https://user-"The args for the disassemble request are: This skips the address just before .
how do one open the disassembly view?
While debugging, right click the main editor -open disassembly view. It will go to the current stack frame.
Run , stop on the line with the word "disassembly" in it, and right click the stack trace to open the disassembly view.
Change:
} const TEMPLATE_ID = 'codeActionWidget'; <del> const codeActionLineHeight = 27; </del> <ins> const codeActionLineHeight = 26; </ins> class CodeMenuRenderer implements IListRenderer<ICodeActionMenuItem, ICodeActionMenuTemplateData> { get templateId(): string { return TEMPLATE_ID; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Type: Bug Using editor.experimental.useCustomCodeActionMenu, the menu doesn't match up with the colors of enabled/disabled options or the background of the other context menus

Type: <bBug</bmenu the window Bug The widget ends up being incorrectly positioned: <img width="672" alt="Screen Shot 2022-07-21 at 1 24 17 PM" src="https://user-"VS Code version: Code - Insiders 1.70.0-insider (Universal) (, 2022-07-21T05:17:20.056Z) OS version: Darwin x64 21.5.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Change:
throw new Error('Channel has been closed'); } }; <ins> const that = this; </ins> return { get name(): string { return name; }, append(value: string): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.
Thanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like "command was already registered" or "notebook controller already exists". I am currently commenting out my line in my extension. It's not ideal though.
PR fixing it
Change:
) { super(themeService); <del> this.resourceContext = this._register(instantiationService.createInstance(ResourceContextKey)); </del> <ins> this.contextMenuContextKeyService = this._register(this.contextKeyService.createScoped(parent)); const scopedInstantiationService = this.instantiationService.createChild(new ServiceCollection( [IContextKeyService, this.contextMenuContextKeyService], )); </ins> <del> this.editorPinnedContext = ActiveEditorPinnedContext.bindTo(contextKeyService); this.editorIsFirstContext = ActiveEditorFirstInGroupContext.bindTo(contextKeyService); this.editorIsLastContext = ActiveEditorLastInGroupContext.bindTo(contextKeyService); this.editorStickyContext = ActiveEditorStickyContext.bindTo(contextKeyService); this.editorAvailableEditorIds = ActiveEditorAvailableEditorIdsContext.bindTo(this.contextKeyService); </del> <ins> this.resourceContext = this._register(scopedInstantiationService.createInstance(ResourceContextKey)); </ins> <del> this.editorCanSplitInGroupContext = ActiveEditorCanSplitInGroupContext.bindTo(contextKeyService); this.sideBySideEditorContext = SideBySideEditorActiveContext.bindTo(contextKeyService); </del> <ins> this.editorPinnedContext = ActiveEditorPinnedContext.bindTo(this.contextMenuContextKeyService); this.editorIsFirstContext = ActiveEditorFirstInGroupContext.bindTo(this.contextMenuContextKeyService); this.editorIsLastContext = ActiveEditorLastInGroupContext.bindTo(this.contextMenuContextKeyService); this.editorStickyContext = ActiveEditorStickyContext.bindTo(this.contextMenuContextKeyService); this.editorAvailableEditorIds = ActiveEditorAvailableEditorIdsContext.bindTo(this.contextMenuContextKeyService); </ins> <del> this.groupLockedContext = ActiveEditorGroupLockedContext.bindTo(contextKeyService); </del> <ins> this.editorCanSplitInGroupContext = ActiveEditorCanSplitInGroupContext.bindTo(this.contextMenuContextKeyService); this.sideBySideEditorContext = SideBySideEditorActiveContext.bindTo(this.contextMenuContextKeyService); this.groupLockedContext = ActiveEditorGroupLockedContext.bindTo(this.contextMenuContextKeyService); </ins> this.renderDropdownAsChildElement = false;

Discussion:
Version: 1.85.0 Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows x64 10.0. ( I am using a Python interpter ) Steps to Reproduce: Have at least 1 tab/file open the tab ( at the top ) : The run button disappears It's a very very minor bug and simply you just open another file to have it reappear. !
Thanks for reporting this! It lead to fixing this and other bugs we had :)
I am glad to hear!
Change:
], default: 'auto', description: nls.localize('search.collapseAllResults', "Controls whether the search results will be collapsed or expanded."), <ins> }, 'search.useReplacePreview': { type: 'boolean', default: true, description: nls.localize('search.useReplacePreview', "Controls whether to open Replace Preview when selecting or replacing a match."), </ins> } } });

Discussion:
I think it should be possible to disable "Replace Preview" in the settings. Currently, whenever I want to replace a word, the "Replace Preview" opens for every file, because I have file preview disabled.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.546 --- <!-- score: 0.535 --- <!-- score: 0.489 --- <!-- score: 0.473 --- <!-- score: 0.46 --<!-- potentialduplicatescomment --
Are you talking about the diff editor that opens when you click a result? What do you expect to see in that case?
Yes that's what I'm talking about. I would like to see just the file without a diff, maybe with the matches highlighted as I navigate through them in the search sidebar. Then when I click on replacing the text it would just replace it directly.
This seems reasonable and I would take a PR that adds a setting to disable the replace preview. FYI Starting point: and
I'd like to take a look at this.
Change:
import { IOutputService } from 'vs/workbench/services/output/common/output'; import { IPaneCompositePartService } from 'vs/workbench/services/panecomposite/browser/panecomposite'; import { IPathService } from 'vs/workbench/services/path/common/pathService'; <del> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; </del> import { IDisposable } from 'xterm'; interface ITerminalData {

Discussion:
Type: <bBug</b"" on VS Code this task and save: this task ([Terminal] [Run Task] [Throw my error]) Enter The integrated terminal shows an error because of . Pressing Enter closes it because of .The integrated terminal shows an error because of . Pressing Enter inserts a line break into the current opened "", or at least leaves the terminal open. Terminal display: I use Git Bash of Git for Windows as my default terminal (), but I've tried and PowerShell and got the same result. Of cause, if the command is , the terminal doesn't appear because of . "Reload With Extensions Disabled" has no effect. TBH, I know this is a duplicate of . It has already been closed as a "feature-request" that didn't receive enough upvotes. It may be impolite to reopen a closed issue in this way, and I'm very hesitant to do so, but for the life of me, I can't believe that fixing this counter-intuitive behavior is within the scope of feature requests. The current behavior is surprising, not convincing. I'm sorry if there are already other ways to achieve the expected behavior. VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ Bookmarks13.3.1 project-manager12.7.0 laravel-extra-intellisense0.6.3 markdown-preview-github-styles2.0.2 insert-unicode0.14.0 laravel-blade1.1.2 vscode-eslint2.4.0 vscode-deno3.19.1 EditorConfig0.16.4 gc-excelviewer4.2.57 code-eol1.0.12 haml1.4.1 live-stylus-compiler0.0.4 zenkaku0.0.3 vscode-language-pack-ja1.79.

remote-containers0.295.0 live-server0.4.8 laravel-blade1.34.0 laravel5-snippets1.17.0 LiveServer5.7.9 language-stylus1.16.0 vscode-input-sequence0.2.0 markdown-all-in-one3.5.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
So you mean it isn't a bug? The "focus" option doesn't make focus. Is this intended behavior?
You're right - it is a bug
I'll fix that
Change:
#endif Exec(ExpandConstant('{sys}icacls.exe'), ExpandConstant('"{app}" /inheritancelevel:r ') + Permissions, '', SW_HIDE, ewWaitUntilTerminated, ResultCode); <del> end; </del>  No newline at end of file <ins> end; </ins>

Discussion:
Type: <bBug</bVS Code version: Code - Insiders 1.80.0-insider (, 2023-06-19T05:35:37.388Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
same here
Made a fix but didn't create a PR apparently. Fixed in next Insiders.
Reopening due to
Change:
#endif Exec(ExpandConstant('{sys}icacls.exe'), ExpandConstant('"{app}" /inheritancelevel:r ') + Permissions, '', SW_HIDE, ewWaitUntilTerminated, ResultCode); <del> end; </del>  No newline at end of file <ins> end; </ins>

Discussion:
Running can block the VS Code update on Windows as it prevents deleting the parent folder. The updater needs a way to terminate it, and a mutex to know that it needs to be terminated.
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { renderMarkdownAsPlaintext } from 'vs/base/browser/markdownRenderer'; </ins> import { Emitter, Event } from 'vs/base/common/event'; import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle'; <ins> import { marked } from 'vs/base/common/marked/marked'; </ins> import { TrackedRangeStickiness } from 'vs/editor/common/model'; import { FoldingLimitReporter } from 'vs/editor/contrib/folding/browser/folding'; import { FoldingRegion, FoldingRegions } from 'vs/editor/contrib/folding/browser/foldingRanges';

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) I expected that folding cells per a markdown header level would collapse all of the markdown and code cells under that header, per the VS Code Outline view of the notebook. In practice though, if there is a markdown cell with a python code block, then the comments in that python code block are considered the next top-level markdown section which interrupts the code folding. a new file and set the interpreter markdown cell with content: markdown cell: code cell: markdown cell: python print('hello world') the cell that cells 2 and 3 are collapsed and hidden, but cell 4 is not Add additional 's to the embedded python comment so that its not at the same level of the makrdown section it is under; e.g., python print('hello world') 70.0 v2022.7. Python 3.8.13 v2022.12.0 conda 4.13.0 Local
still seeing this issue- lmk if my setup is wrong. thanks! <img width="1322" alt="Screenshot 2023-01-25 at 1 11 16 PM" src="https://user-"<img width="1314" alt="Screenshot 2023-01-25 at 1 11 11 PM" src="https://user-"
Can you try finishing editing the cells to put them into render mode: ! I don't think we update the folding until the cell is no longer being edited
was verifying another issue and this works now!
Change:
import { PreferencesEditor } from 'vs/workbench/parts/preferences/browser/preferencesEditor'; import { SettingsTarget, SettingsTargetsWidget } from 'vs/workbench/parts/preferences/browser/preferencesWidgets'; import { commonlyUsedData, tocData } from 'vs/workbench/parts/preferences/browser/settingsLayout'; <del> import { ISettingLinkClickEvent, resolveExtensionsSettings, resolveSettingsTree, SettingsDataSource, SettingsRenderer, SettingsTree, SimplePagedDataSource } from 'vs/workbench/parts/preferences/browser/settingsTree'; </del> <ins> import { ISettingLinkClickEvent, resolveExtensionsSettings, resolveSettingsTree, SettingsDataSource, SettingsRenderer, SettingsTree, SimplePagedDataSource, ISettingOverrideClickEvent } from 'vs/workbench/parts/preferences/browser/settingsTree'; </ins> import { ISettingsEditorViewState, MODIFIED_SETTING_TAG, ONLINE_SERVICES_SETTING_TAG, parseQuery, SearchResultIdx, SearchResultModel, SettingsTreeGroupElement, SettingsTreeModel, SettingsTreeSettingElement } from 'vs/workbench/parts/preferences/browser/settingsTreeModels'; import { settingsTextInputBorder } from 'vs/workbench/parts/preferences/browser/settingsWidgets'; import { TOCRenderer, TOCTree, TOCTreeModel } from 'vs/workbench/parts/preferences/browser/tocTree';

Discussion:
Issue Type: <bFeature Request</bTesting Just a thought: When I see "Modified in: Workspace" I might want to go there and check. I'd keep font and color as they are and add an underline and pointer cursor to "Workspace" on hover. VS Code version: Code - Insiders 1.27.0-insider (, 2018-08-29T05:12:15.247Z) OS version: Darwin x64 17.7.0 <!-- generated by issue reporter --
Good idea!
I would take a PR for this "Modified in: Workspace" - the word Workspace is underlined When clicked, it switches to the Workspace scope, and copies the setting key into the search bar, so the view is filtered to just that one setting
I'm interested in looking into this if that is alright.
Change:
} } } <del> KeybindingsRegistry.registerKeybindingRule({ id: 'undo', weight: 1000, primary: KeyMod.CtrlCmd | KeyCode.LeftArrow, when: ContextKeyExpr.and(EditorContextKeys.writable, ContextKeyExpr.or(GhostTextController.inlineSuggestionVisible, GhostTextController.inlineSuggestionJustCommitted)), }); </del>

Discussion:
(See attached recording) I have enclose it in new use cmd+left to go to start of line ghost suggestions get accepted https://user-
Change:
} private async activateProvider(scheme: string) { <ins> const transformedScheme = scheme === 'vscode-remote' ? 'file' : scheme; </ins> const provider = this._editSessionIdentifierProviders.get(scheme); if (provider) { return provider; } <del> await this._extensionService.activateByEvent(`onEditSession:${scheme}`); </del> <ins> await this._extensionService.activateByEvent(`onEditSession:${transformedScheme}`); </ins> return this._editSessionIdentifierProviders.get(scheme); } }

Discussion:
exposes a race condition in activating edit session identity providers when the workspace folders have scheme , which results in edit sessions failing to be applied in time in remote windows. Verification: in settings , make some changes Working On Create New Codespace you are not prompted to sign into edit sessions, and your edits created in are applied