jiebi/CodeConvo huggingface dataset:
Change:
* The value callback to complete a promise */ export interface TValueCallback<T> { <del> (value: T): void; </del> <ins> (value: T | Thenable<T>): void; </ins> }

Discussion:
Building VSCode with TS 2.4, we're seeing about 10 errors in async functions around : Steps to reproduce VScode insiders. vscode code base vscode codebase in vscode effected file that TS 2.4.1 is active in your workspace by looking in the lower right status bar for the TS version number
or Can someone on the TS team please take a quick look at these errors? I've investigated but the error don't make much sense to me. I don't know where TS is getting the type from in for example This only started showing up in TS 2.4. My current thought is that we need to stop using for methods
Hi, it looks like you can get rid of the error by changing 's definition to be compatible with 's, as in: That said, the error was complaining about and not , so it took me a while to figure this out! I'll report a bug on TypeScript. The reason you are just getting this error now in TS2.4 is due to Microsoft/TypeScript, since we are now checking the types inside of callbacks covariantly (previously it worked since is a supertype of ).
In 2.4.1 we are stricter about the types for callbacks. It looks like the issue is the definition of in Changing the following definition seems to address the error: In general, we've made a number of improvements in the overall type definitions for the ES6 type that have apparently not made their way into the winjs declarations. While not necessary to fix the above error, in the future I would recommend the following changes: Replace (in ) with a type alias to (for backwards compatibility) Replace all references to to in the vscode code base (the compiler has optimizations in async function code paths for type references to the built in type). Replace , , and in with the following declaration that leverages type parameter defaults: I can submit a PR against VSCode for this if you would like.
Thanks. The suggested change does seem to fix things. I'll take it into vscode. (Not sure of correct owners here. Please add anyone else that may have input) Can you please take a look at a Ron's other suggested changes to see if these are something we want to investigate
This sounds good to me, but I'm sure would like to give his $0.02 about that in the API.
Change:
resolved "https://registry.yarnpkg.com/node-gyp-build/-/node-gyp-build-4.3.0.tgz#9f256b03e5826150be39c764bf51e993946d71a3" integrity sha512-iWjXZvmboq0ja1pUGULQBexmxq8CV4xBhX7VDOTbL7ZR4FOowwY/VOtRxBN/yKxmdGoIp4j5ysNT4u3S2pDQ3Q== <del> typescript@4.7.1-rc: version "4.7.1-rc" resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.7.1-rc.tgz#23a0517d36c56de887b4457f29e2d265647bbd7c" integrity sha512-EQd2NVelDe6ZVc2sO1CSpuSs+RHzY8c2n/kTNQAHw4um/eAXY+ZY4IKoUpNK0wO6C5hN+XcUXR7yqT8VbwwNIQ== </del> <ins> typescript@4.7: version "4.7.2" resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.7.2.tgz#1f9aa2ceb9af87cca227813b4310fff0b51593c4" integrity sha512-Mamb1iX2FDUpcTRzltPxgWMKy3fhg0TN378ylbktPGPK/99KbDtMQ4W1hwgsbPAsG3a0xKa1vmw4VKZQbkvz5A== </ins> vscode-grammar-updater@^1.1.0: version "1.1.0"

Discussion:
Tracks shipping TypeScript 4.7 in VS Code See for details
/verified Insiders shows this for me: !
Change:
const grammars = contributes?.grammars || []; grammars.forEach(grammar => { <ins> if (!isString(grammar.language)) { // ignore the grammars that are only used as includes in other grammars return; } </ins> let language = byId[grammar.language]; if (language) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 89.1 x64 OS Version: Edition Windows 11 Pro Version 23H2 Installed on ‎2023-‎11-‎28 OS build .3593 Experience Windows Feature Experience Pack 1000..1003.0 Steps to Reproduce: the VS Code the introduction page of buildin plugin the FEATURES page 's Empty
I am seeing following !
Yes, I see the same. There should be details about supported languages like other built-in plugins.
Can you point me to the place I need to fix this?
Here it is
Change:
- script: | set -e sudo apt-get update <del> sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 libgconf-2-4 dbus xvfb libgtk-3-0 </del> <ins> sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb libgtk-3-0 </ins> sudo cp build/azure-pipelines/linux/xvfb.init /etc/init.d/xvfb sudo chmod +x /etc/init.d/xvfb sudo update-rc.d xvfb defaults

Discussion:
Afaik, electron should build with dconf instead of gconf.
See also
Please report here:
electron now (3.x) works without gconf. All you have to do is
I can confirm that Insiders 1.31 works without gconf. Can gconf be dropped for insiders?
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version "0.14.0-beta.50" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version "0.15.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version "5.2.0-beta.2" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins>

Discussion:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:
Change:
"command.api.getRepositories": "Get Repositories", "command.api.getRepositoryState": "Get Repository State", "command.api.getRemoteSources": "Get Remote Sources", <del> "command.git.acceptMerge": "Accept Merge", </del> <ins> "command.git.acceptMerge": "Complete Merge", </ins> "command.git.openMergeEditor": "Resolve in Merge Editor", "command.git.runGitMerge": "Compute Conflicts With Git", "command.git.runGitMergeDiff3": "Compute Conflicts With Git (Diff3)",

Discussion:
Testing This was feedback I heard from others too—"Accept Merge" is a bit strange since you aren't really accepting a merge so much as the individual changes. I think "Complete Merge" would make more sense here. <img width="265" alt="CleanShot 2022-09-27 at 11 50 56 src="https://user-"
Or maybe "Confirm Merge".
More ideas: I like this - I think "confirm" is usually used to approve an already stated intention and does not fully fit here. ideas?
"Complete Merge" and "Accept Merge" are the best options. I am leaning towards "Complete Merge". fyi
for "Complete Merge"
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { compareBy, findLastIndex, numberComparator, reverseOrder } from 'vs/base/common/arrays'; </del> <ins> import { compareBy, equals, findLastIndex, numberComparator, reverseOrder } from 'vs/base/common/arrays'; </ins> import { assertFn, checkAdjacentItems } from 'vs/base/common/assert'; import { CharCode } from 'vs/base/common/charCode'; import { SetMap } from 'vs/base/common/collections';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 OS Version: macOS 13.4.1 Steps to Reproduce: two empty file the diff view shows "removed" and "" lines This issue is the same as but happens again
Can you share a screenshot?
An empty file compare to itself <img width="1033" alt="image" src=""
I see, thanks!
To verify: Select latest dev version and notice there is no red/green in this .
The issue is verified. I am wondering if we want to see the commands starting with when there is no active file? I see this command while I have no active text editor.
Change:
private _onStateChanged(e: FindReplaceStateChangedEvent): void { if (e.searchString) { <del> if (this._state.searchString.indexOf('n') >= 0) { dom.addClass(this._domNode, 'multipleline'); } else { dom.removeClass(this._domNode, 'multipleline'); } </del> try { this._ignoreChangeEvent = true; this._findInput.setValue(this._state.searchString);

Discussion:
Issue Type: <bBug</bSteps to Reproduce: any file to open the Search and Replace bar the Replace field, hit to add a line return the bar --The bottom of the bar is visible while closed. ! VS Code version: Code 1.39.2 (, 2019-10-15T15:33:40.634Z) OS version: Linux x64 5.0.0-32-generic <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ vscode-intelephense-client1.2.3 vscode-tailwindcss0.2.0 gitlens10.1.1 auto-rename-tag0.1.0 gc-excelviewer2.1.32 todo-tree0.0.160 graphql-for-vscode1.15.1 rainbow-csv1.3.1 git-graph1.17.0 dotenv1.0.1 language-gettext0.1.1 vscode-typescript-tslint-plugin1.2.2 vsliveshare1.0.988 debugger-for-chrome4.12.0 material-icon-theme3.9.1 partial-diff1.4.0 ayu0.18.0 change-case1.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.467 --<!-- potentialduplicatescomment --
This is not a duplicate.
I hope you don't mind but I had a look into this and I've fixed it. Should I bother with a PR or leave it to you? It only adds if the contains , it doesn't check . However, I noticed that if is , you don't get the animation (slide down/up). I think a better solution may be to animate on transform.
not at all, feel free to send out your work and thanks for your contribution!
Change:
this._register(toDisposable(() => { if (this.syncPromise) { this.syncPromise.cancel(); <del> this.logService.info('Auto sync: Canelled sync that is in progress'); </del> <ins> this.logService.info('Auto sync: Cancelled sync that is in progress'); </ins> this.syncPromise = undefined; } if (this.syncTask) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Issue Type: <bBug</bAppears here in the logs: [userDataSync] [info] Auto sync: Canelled sync that is in progress VS Code version: Code - Insiders 1.48.0-insider (, 2020-07-24T05:57:10.466Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (47)</summaryExtensionVersion ------ user-secrets2.0.1 Bookmarks11.3.1 ng-template0.1000.4 vscode-eslint2.1.8 docs-markdown0.2.76 gitlens10.2.2 EditorConfig0.15.1 prettier-vscode5.1.3 vscode-firefox-debug2.9.0 dotnet-test-explorer0.7.3 todo-tree0.0.178 vscode-edit-csv0.3.0 rainbow-csv1.7.0 git-graph1.24.0 vscode-docker1.3.1 csharp1.22.1 vscode-kubernetes-tools1.2.1 vscode-postgresql0.3.0 anaconda-extension-pack1.0.1 python2020.7.

vscode-pylance2020.7.2 remote-containers0.128.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.4 vscode-remote-extensionpack0.20.0 vscode-typescript-tslint-plugin1.2.3 debugger-for-chrome4.12.9 debugger-for-edge1.0.15 sqltools0.22.10 sqltools-driver-sqlite0.1.0 material-icon-theme4.2.0 polacode0.3.4 java0.64.1 vscode-yaml0.9.1 multi-command1.4.0 scala0.4.1 metals1.9.2 code-spell-checker1.9.0 pdf1.1.0 vscodeintellicode1.2.9 vscode-java-debug0.27.0 vscode-java-dependency0.10.2 vscode-java-pack0.9.1 vscode-java-test0.24.0 vscode-maven0.22.0 vscode-nginx0.7.2 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Change:
} } <del> /** Creates a key that determines how terminals get reused */ function createKeyForShell(shell: string, shellArgs: string | string[], args: DebugProtocol.RunInTerminalRequestArguments) { const hash = createHash('sha256'); hash.update(JSON.stringify({ shell, shellArgs })); hash.update(JSON.stringify(Object.entries(args.env || {}).sort(([k1], [k2]) => k1.localeCompare(k2)))); return hash.digest('base64'); } </del> let externalTerminalService: IExternalTerminalService | undefined = undefined; function runInExternalTerminal(args: DebugProtocol.RunInTerminalRequestArguments, configProvider: ExtHostConfigProvider): Promise<number | undefined> {

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
this.setCountBadge(); // set mergeChanges context <del> commands.executeCommand('setContext', 'git.mergeChanges', merge.map(item => item.resourceUri.toString())); </del> <ins> commands.executeCommand('setContext', 'git.mergeChanges', merge.map(item => item.resourceUri)); </ins> this._onDidChangeStatus.fire();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 Steps to Reproduce: a codespace a merge conflict the conflict file missin the button <img width="1461" alt="image" src="https://user-"missin the button <img width="1535" alt="image" src="https://user-"This is context keys, current file scheme is <img width="673" alt="image" src="https://user-"<img width="703" alt="image" src="https://user-"but the scheme is <img width="316" alt="image" src="https://user-"so the button is missing because is <img width="1148" alt="image" src="https://user-"
I can confirm that "Open in Merge Editor" & "Accept Merge" buttons are missing when VS Code is connected to WSL via Remote - WSL extension.
Thanks for the proper investigation!
Let's make this a 1.70.2 candidate
Fixed in main but keeping this open to cherry-pick things onto release/1.71
Change:
} export const config = { <del> version: product.electronRepository ? '22.4.4' : util.getElectronVersion(), </del> <ins> version: product.electronRepository ? '22.4.5' : util.getElectronVersion(), </ins> productAppName: product.nameLong, companyName: 'Microsoft Corporation', copyright: 'Copyright (C) 2023 Microsoft. All rights reserved',

Discussion:
The Angular language service extension spawns a child process using and listens for the and events. The current version works as expected. Without any changes to the project, simply updating to results in the forked child process acting differently (never erroring and never closing). I'm using Mac 13.3.1 but we also had a report that the forked process isn't working in WindowsNT x64 10.0. either. There was a similar issue (though not entirely the same) a while back: Apologies for the rather involved reproduction... Here's how I'm able to reproduce and compare the behavior between the versions: our the repository with vscode insider version 1.78.0-insiders out the branch (we're actually removing this in the next version so it doesn't exist on ) dependencies with debugging, put a debugger statement before and one in the . The project is built with bazel so breakpoints would have to be put in the compiled JS files. the build script with the extension development host (Dev Client + Server run configuration) In the extension host, open the and then open the template file -- debugger should stop on the fork and if you continue, you will see that the debugger stops in the stderr data listener but never in the or . The output of the stderr also indicates that it is listening for a debugger and that it gets attached. The fork used which should have prevented this. The process also never produces any results or completes. You can have the fork retry by running the Angular: Restart Angular Language server command in the extension host. I've also verified that the spawn args are the same between versions and both include "--ms-enable-electron-run-as-node".
Issue was caused by the allocator changes to processes which now schedule delayed tasks to purge memory cache ;l=1183 and that revealed a bug in the causing the process to hang.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
const { snippet, parameterCount } = snippetForFunctionCall(item, detail.displayParts); item.insertText = snippet; if (parameterCount > 0) { <del> commands.push({ title: 'triggerParameterHints', command: 'editor.action.triggerParameterHints' }); </del> <ins> //Fix for https://github.com/microsoft/vscode/issues/104059 //Don't show parameter hints if "editor.parameterHints.enabled": false if (vscode.workspace.getConfiguration('editor.parameterHints').get('enabled')) { commands.push({ title: 'triggerParameterHints', command: 'editor.action.triggerParameterHints' }); } </ins> } } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.3 OS Version: macOS Steps to Reproduce: and to your settings. JavaScript file and write , press Tab to autocomplete. Actual behavior, parameter hints are visible even though config is false. Expected behavior, parameter hints are invisible. /cc
Same happens for TypeScript.
Hi I am currently attempting to work on this issue and I have a quick question. With "editor.parameterHints.enabled" set to false and "*.suggest.completeFunctionCalls" set to true is the expected behavior to have the parentheses still be inserted but just not have the popup appear or should the parentheses not be inserted?
You just need to disable parameter hints. The problem is they appear even if they are disabled. Imagine this pseudo code:
I know I fixed it. Im gonna submit a PR now.
Change:
.quick-input-list .monaco-highlighted-label .highlight { font-weight: bold; <ins> /* preserve list-like styling instead of tree-like styling */ color: var(--vscode-list-focusHighlightForeground) !important; background-color: transparent; </ins> } .quick-input-list .quick-input-list-entry .quick-input-list-separator {

Discussion:
! I can click on them
Took a different approach with this... instead they are clickable, but they cause the list to scroll that separator up to the top (and they also clear focus).
Fixed in
Change:
if (activationEventsNode?.type === 'array' && activationEventsNode.children) { for (const activationEventNode of activationEventsNode.children) { const activationEvent = getNodeValue(activationEventNode); <ins> const isImplicitActivationSupported = info.engineVersion && info.engineVersion?.majorBase >= 1 && info.engineVersion?.minorBase >= 75; </ins> // Redundant Implicit Activation if (info.implicitActivationEvents?.has(activationEvent) && redundantImplicitActivationEventPrefixes.some((prefix) => activationEvent.startsWith(prefix))) { const start = document.positionAt(activationEventNode.offset); const end = document.positionAt(activationEventNode.offset + activationEventNode.length); <del> diagnostics.push(new Diagnostic(new Range(start, end), redundantImplicitActivationEvent, DiagnosticSeverity.Warning)); </del> <ins> const message = isImplicitActivationSupported ? redundantImplicitActivationEvent : bumpEngineForImplicitActivationEvents; diagnostics.push(new Diagnostic(new Range(start, end), message, isImplicitActivationSupported ? DiagnosticSeverity.Warning : DiagnosticSeverity.Information)); </ins> } // Reserved Implicit Activation for (const implicitActivationEventPrefix of reservedImplicitActivationEventPrefixes) { <del> if (activationEvent.startsWith(implicitActivationEventPrefix)) { </del> <ins> if (isImplicitActivationSupported && activationEvent.startsWith(implicitActivationEventPrefix)) { </ins> const start = document.positionAt(activationEventNode.offset); const end = document.positionAt(activationEventNode.offset + activationEventNode.length); diagnostics.push(new Diagnostic(new Range(start, end), implicitActivationEvent, DiagnosticSeverity.Error));

Discussion:
When developing extension the warning in : is wrong because it doesn't check if the extension is supported on older VSCode versions: