jiebi/CodeConvo huggingface dataset:
Change:
return TPromise.as(void 0); } return this.quickOpenService.input({ <ins> value: terminalInstance.title, </ins> prompt: nls.localize('workbench.action.terminal.rename.prompt', "Enter terminal name"), }).then(name => { if (name) {

Discussion:
While testing . VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-01T05:07:59.267Z) OS Version: Darwin x64 16.7.0 Steps to Reproduce: a terminal from the command palette <kbdArrowDown</kbdto the terminal in the switcher keyboard focus to rename action using 2 <kbdTab</kbds. See . <kbdEnter</kbdto enter rename mode -text box is empty. This is fine if I want to assign a completely new name, but an issue if I only want to correct a typo for example. The input box should contain the old name and the name should be selected so that I can start typing to replace or use Arrow keys to get to the right place to correct the typo.
Change:
this._outputContainerRenderer.render(); this._renderedOutputCollapseState = false; // the output is always rendered initially // Need to do this after the intial renderOutput <del> if (this.viewCell.isOutputCollapsed === undefined && this.viewCell.isInputCollapsed === undefined) { this.initialViewUpdateExpanded(); this.viewCell.layoutChange({}); } </del> <ins> this.initialViewUpdateExpanded(); </ins> this._register(this.viewCell.onLayoutInfoRead(() => { this.cellParts.prepareLayout();

Discussion:
Type: <bBug</bAfter updating to the latest VS Code version, I noticed two issues in the jupyter notebook: a) in the output cell, both the content and the text "Outputs are collapsed" overlap. This text disappears once I collapse the output and show it again. ! b) in the code cell, if I'm writing something and then scroll up/down, the content of this cell is no longer visible Thanks VS Code version: Code 1.75.0 (, 2023-02-01T15:23:45.584Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ rainbow-csv3.5.0 isort2022.8.0 python2023.2.0 vscode-pylance2023.2.10 jupyter2023.1. jupyter-keymap1.0.0 jupyter-renderers1.0.14 vscode-jupyter-cell-tags0.1.6 vscode-jupyter-slideshow0.1.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Happens to me all the time, not sure exactly what are the steps to reproduce, it has something to do with collapsing cells and then running them again, or something to do with restarting the kernel... !
Issue "a)" happened to me already before the last update as well, but the issue "b)" happens to me only since the last version and is quite incapacitating.
This issue should be fixed now in latest Insiders and will be released with next Stable recovery build.
Change:
} private readonly updateThrottler = new Throttler(); <ins> public readonly options: InstallOptions; </ins> constructor( <del> id: string, readonly options: InstallOptions, cssClass: string, </del> <ins> options: InstallOptions, </ins> @IExtensionsWorkbenchService private readonly extensionsWorkbenchService: IExtensionsWorkbenchService, @IInstantiationService private readonly instantiationService: IInstantiationService, @IExtensionService private readonly runtimeExtensionService: IExtensionService,

Discussion:
Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi
Ok was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?
Any suggestions?
We already have the "Sync Extension" check in the Extension context menu when it is installed - this is great. ! And we already have the "Sync Extension" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !
Lets try this in insiders already and see if we get any hit back.
Awesome - thanks!
Change:
private getConfiguredOpenerForUri(openers: Map<string, IExternalUriOpener>, targetUri: URI): IExternalUriOpener | 'default' | undefined { const config = this.configurationService.getValue<ExternalUriOpenersConfiguration>(externalUriOpenersSettingId) || {}; for (const [uriGlob, id] of Object.entries(config)) { <del> if (testUrlMatchesGlob(targetUri.toString(), uriGlob)) { </del> <ins> if (testUrlMatchesGlob(targetUri, uriGlob)) { </ins> if (id === defaultExternalUriOpenerId) { return 'default'; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: out of GitHub if you are logged in a trusted domain rule for GitHub Repos extension or something else, start a Login for GitHub Notice that you get prompted to allow this URL as a trusted domain No prompt This is because () doesn't handle query parameters well... and thinks they are part of the path when validating. You can see this behavior by adding a at the end of in the Trusted Domains. We should really ignore query parameters and fragments here.
Change:
} run(): TPromise<any> { <del> return this.extensionsWorkbenchService.uninstall(this.extension); </del> <ins> alert(localize('uninstallExtensionStart', "Uninstalling extension {0} started.", this.extension.displayName)); return this.extensionsWorkbenchService.uninstall(this.extension).then(() => { alert(localize('uninstallExtensionComplete', "Please reload Visual Studio Code to complete the uninstallation of the extension {0}.", this.extension.displayName)); }); </ins> } dispose(): void {

Discussion:
Environment Details: VSCode Version : 1.24.1 OS Version : Win10 Additional Details: ScreenReader Version: NVDA2018.2 Repro Steps: VS Code while NVDA is ON. to View menu and Select Extensions. something in the Search Textbox and tab till install button. Actual: When we Click on install button, the text above the button changes..i.e.(installing) which is not read by the screenreader and after installing, a Reload button appears and also a icon which is not informed by the screenreader and after pressing tab key focus does not move on the text which has installed,it goes somewhere else. Expected: NVDA should announce some information about the reload button and should also read the "installing" when it is getting installed and focus should go on the very first item which has got installed. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: User will not be able to know about the controls which has appeared after installing the particular extensions. Attachment for Reference: Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.588 --- <!-- score: 0.526 --- <!-- score: 0.462 --- <!-- score: 0.458 --- <!-- score: 0.451 --<!-- potentialduplicates_comment --
Makes sense. This sounds as easy as an aria alert based on the state of the installation. I would expect at least a notification once the instalation is done so the user is reminded that a reload is necessery. Feels low hanging, assigning to July
do we plan to tackle this in September? It would be great since we depend on this one for a better accessibility score?
Yes, this is for September
Note to verifier: Also test cases of uninstall and update and ensure that appropriate text is read out. Ensure that the need to reload VS Code is also mentioned
Change:
} result[id] = <DecorationData>[data.propagate, data.tooltip, data.badge, data.color]; } catch (e) { <del> this._logService.warn(`INVALID decoration from extension '${extensionId}': ${e}`); </del> <ins> this._logService.warn(`INVALID decoration from extension '${extensionId.identifier.value}': ${e}`); </ins> } } catch (err) { this._logService.error(err);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Steps to Reproduce: an invalid decoration in warning in ext host logs that says instead of the extension name:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Change:
} else { command = `'${process.execPath}' ${extraArgs} -p '"${mark}" + JSON.stringify(process.env) + "${mark}"'`; <del> if (name === 'tcsh') { </del> <ins> if (name === 'tcsh' || name === 'csh') { </ins> shellArgs = ['-ic']; } else { shellArgs = ['-i', '-l', '-c'];

Discussion:
I can notice this error in .vscode- files whenever I try to remote connect to my Linux machine <pre[01:38:27] [127.0.0.1][][ExtensionHostConnection] New connection established. Unknown option: `-lc' Usage: csh [ -bcdefilmnqstvVxX ] [ argument ... ]. [01:38:27] getUnixShellEnvironment#error Failed to get environment </preThis error has symptoms that I cannot get latest values of environment variables in launch and tasks files
What version of VS Code are you using? Is this different in vscode Insiders vs Stable?
Seems that csh supports but can't be combined with
I using VS Code with following version info: Version: 1.52.1 (system setup) Commit: Date: 2020-12-16T16:34:46.910Z Electron: 9.3.5 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0. Behavior is the same with insiders version
Only way to work around it for now would be to change your default shell to something else (at the OS level, not using a vscode setting)
You own this A little suspicious that this was reported right after my change in but seems to not be related since it reproes in stable. I don't know that the behavior will be 100% correct without but maybe we have to keep a hardcoded map of shells and flags to use with them.
Isn't this a dupe of
No, in that case users aren't able to connect with ssh at all. Here the user was able to connect but probing the environment failed.
Same as but for csh
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verification steps: Your linux machine probably has present. Run (note your default shell first so you can put it back Open a vscode window on that machine.

A local window or Remote-SSH is fine Previously you would have gotten the popup that complains about failing to determine the environment in your shell. You should not get that error popup now. You can also check the server or main/shared log files and the error shouldn't be there either Use again to restore your preferred shell
Change:
export type ValidateEnabled = 'ignore' | 'warning' | 'error' | 'hint'; <del> interface Settings { </del> <ins> export interface Settings { </ins> readonly markdown: { readonly occurrencesHighlight: { readonly enabled: boolean;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0 OS Version: macOS 12.1 21C52 x86_64 Recently upgraded to 1.73 and no longer seeing selection highlighting. <img width="1728" alt="Screen Shot 2022-11-09 at 8 44 07 AM" src="https://user-"Default setting still and set on the user level as well to no avail. <img width="1728" alt="Screen Shot 2022-11-09 at 8 41 34 AM" src="https://user-"<img width="803" alt="Screen Shot 2022-11-09 at 8 41 56 AM" src="https://user-"
I am only seeing this in Markdown (including code blocks) but not source code.
The problem seems to be that previously you'd get a match if the cursor was at the start of the word but now only if you select/highlight the entire word (or subset). If this is a change in functionality, any way to update settings to restore previous out-of-box behavior?
I believe this might be caused by markdown now registering a document highlight provider. When a language registers a document highlight provider, the non-semantic based, text editor word highlight takes a back seat. I think you can turn this down via , or maybe . Let me loop in , maybe he has more ideas.
Change:
// - Row     = 339 // - Col     = 12 // - RowEnd  = 341 <del> // - ColEnd  = 14 </del> <ins> // - ColEnd  = 789 </ins> // // These all support single quote ' in the place of " and [] in the place of () const lineAndColumnRegexClauses = [ // foo:339 // foo:339:12 <ins> // foo:339:12-789 </ins> // foo:339.12 // foo 339 <del> // foo 339:12                             [#140780] </del> <ins> // foo 339:12                              [#140780] </ins> // foo 339.12 // "foo",339 // "foo",339:12 // "foo",339.12 <del> // "foo",339.12-14 // "foo",339.12-341.14 `(?::| |['"],)${r()}([:.]${c()}(?:-(?:${re()}.)?${ce()})?)?` + eolSuffix, // The quotes below are optional          [#171652] // "foo", line 339                        [#40468] </del> <ins> // "foo",339.12-789 // "foo",339.12-341.789 `(?::| |['"],)${r()}([:.]${c()}(?:-(?:${re()}.)?${ce()})?)?` + eolSuffix, // The quotes below are optional           [#171652] // "foo", line 339                         [#40468] </ins> // "foo", line 339, col 12 // "foo", line 339, column 12 // "foo":line 339

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --When working on Haskell code, may produce error output in the following format: It would be nice to have terminal link detection support for this format (or, to discard the part and just jump to the start column). Currently, this format seems to trip up the parser: it detects the file, line number, and start column correctly, but then it seems to select backwards to near the start of the file. (Note: ghcid seems to treat the end column index as inclusive, i.e. the cursor is before the last notable character.)
Can reproduce: ! Selects from 1:3 to 115 !
What is detected:
Caused by a bad regex match: !
Change:
import { IWorkspaceContextService, Workspace, toWorkspaceFolders } from 'vs/platform/workspace/common/workspace'; import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService'; import { QueryBuilder, ISearchPathsResult } from 'vs/workbench/parts/search/common/queryBuilder'; <del> import { TestContextService } from 'vs/workbench/test/workbenchTestServices'; </del> <ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; import { TestContextService, TestEnvironmentService } from 'vs/workbench/test/workbenchTestServices'; </ins> import { ISearchQuery, QueryType, IPatternInfo, IFolderQuery } from 'vs/platform/search/common/search';

Discussion:
Loosely related to ! We can use the 'files to include' box to do a search in an arbitrary folder, but it has to be an absolute path. It should also work when using a ~ to indicate the user's home directory.
Change:
registerDebugCommandPaletteItem(JUMP_TO_CURSOR_ID, { value: nls.localize('jumpToCursor', "Jump to Cursor"), original: 'Jump to Cursor' }, CONTEXT_JUMP_TO_CURSOR_SUPPORTED); registerDebugCommandPaletteItem(JUMP_TO_CURSOR_ID, { value: nls.localize('SetNextStatement', "Set Next Statement"), original: 'Set Next Statement' }, CONTEXT_JUMP_TO_CURSOR_SUPPORTED); registerDebugCommandPaletteItem(RunToCursorAction.ID, { value: RunToCursorAction.LABEL, original: 'Run to Cursor' }, ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, CONTEXT_DEBUG_STATE.isEqualTo('stopped'))); <del> registerDebugCommandPaletteItem(SelectionToReplAction.ID, { value: SelectionToReplAction.LABEL, original: 'Evaluate in Debug Console' }, ContextKeyExpr.and(EditorContextKeys.hasNonEmptySelection, CONTEXT_IN_DEBUG_MODE)); </del> <ins> registerDebugCommandPaletteItem(SelectionToReplAction.ID, { value: SelectionToReplAction.LABEL, original: 'Evaluate in Debug Console' }, CONTEXT_IN_DEBUG_MODE); </ins> registerDebugCommandPaletteItem(SelectionToWatchExpressionsAction.ID, { value: SelectionToWatchExpressionsAction.LABEL, original: 'Add to Watch' }, ContextKeyExpr.and(EditorContextKeys.hasNonEmptySelection, CONTEXT_IN_DEBUG_MODE)); registerDebugCommandPaletteItem(TOGGLE_INLINE_BREAKPOINT_ID, { value: nls.localize('inlineBreakpoint', "Inline Breakpoint"), original: 'Inline Breakpoint' }); registerDebugCommandPaletteItem(DEBUG_START_COMMAND_ID, DEBUG_START_LABEL, ContextKeyExpr.and(CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_DEBUG_STATE.notEqualsTo(getStateLabel(State.Initializing))));

Discussion:
I don't see why the "Debug: Evaluate in Debug Console" command can't be a parallel of the "Terminal: Run Selected Text In Active Terminal" command, which, when no text is selected, sends the full current line. This is how most evaluate-and-run environments work (Jupyter notebooks, RStudio, Matlab), and it would be great to have that feature during debugging. As long as someone is updating this command, it would be great to add an called something like so that when you use the command to send a line of code, the editor also advances the current line (again, this is a UX element that Jupyter, RStudio, and Matlab are built around). Originally posted by in
Change:
if (this.contextService.getWorkbenchState() === WorkbenchState.WORKSPACE) { projectFolderName = paths.basename(stat.root.resource.fsPath);	// show root folder name in multi-folder project } <del> this.displayCurrentPath(inputBox, initialRelPath, fileKind, projectFolderName); </del> <ins> this.displayCurrentPath(inputBox, initialRelPath, projectFolderName, editableData.action.id); </ins> }), DOM.addDisposableListener(inputBox.inputElement, DOM.EventType.BLUR, () => { done(inputBox.isInputValid(), true);

Discussion:
Testing Have a file in a folder : Like this: ! Right click and rename Type Observe the message: ! That message is wrong, because pressing Enter will create a folder and then move file into it.
I think the message can be improved but the behavior is by design
Yeah, that's what I'm trying to say, that the help message is wrong

Testing Have a folder hierarchy Create a new file and type The help message reads: Pressing Enter will create a file in The help message hints that would be a folder, but will be a file. I suggest something like: in this case ! !
Change:
override hasFocus(): boolean { return super.hasFocus() || this._diffZone.value.hasFocus() || this._previewZone.value.hasFocus(); } <ins> override getWidgetPosition(): Position | undefined { if (this._session.lastTextModelChanges.length) { return this._session.wholeRange.value.getEndPosition(); } return; } </ins> } function showSingleCreateFile(accessor: ServicesAccessor, edit: EditResponse) {

Discussion:
use dummy sample have the file below on line 10 trigger inline chat and get a reply :bug: the input part has the blue background which it shouldn't have
Change:
const host: IExtensionActivationHost = { logService: this._logService, folders: folders.map(folder => folder.uri), <del> forceUsingSearch: localWithRemote, exists: (uri) => this._hostUtils.exists(uri.fsPath), </del> <ins> forceUsingSearch: localWithRemote || !this._hostUtils.fsExists, exists: (uri) => this._hostUtils.fsExists!(uri.fsPath), </ins> checkExists: (folders, includes, token) => this._mainThreadWorkspaceProxy.$checkExists(folders, includes, token) };

Discussion:
Steps to repro: (prereq) make sure Python is installed in or (also repros with stable , does not repo in Desktop) open or wait a bit see that Python gets activated even though this repo has nothing python-y in it (just XML files) ! informed me of which gave me a very curious output: What’s interesting about this is that this repo has no , no , no … so this takes me to the original question. Why is this causing activation? After chatting a bit, pointed out: as suspicious.
I think these host methods are not implemented correctly and they might be the root cause:
Yeah, the function isn't really implemented. Tho, I could change the default to to but the bigger challenge is that the interface assumes local file access - it talks about paths, not uris and therefore this will be hard to implement. And by extension I also think this is buggy for the node EH with workspace not hosted on local disk
NVM - I found the magic and will use that for web EH