jiebi/CodeConvo huggingface dataset:
Change:
if (isWorkspaceFolder(scope)) { return { resource: scope.uri }; } <ins> if (scope === null) { return { resource: null }; } </ins> return undefined; }

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --When developing an extension with vscode-insiders, the extension host prints many warnings like: The warnings are printed for the following extensions: The built-in extension The built-in extension (when opening a markdown file) The built-in extension (when opening a html file) The built-in extension (when opening a ts file and typing something) ! When developing an extension with vscode, no warnings are printed. ! <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: Ubuntu 19.10 Steps to Reproduce: an extension warnings are printed inside <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I believe these should be fixed now. Let me know if you notice any additional ones
Change:
f1: false, keybinding: { primary: KeyMod.Shift | KeyMod.Alt | KeyCode.F3, <del> weight: KeybindingWeight.WorkbenchContrib </del> <ins> weight: KeybindingWeight.WorkbenchContrib, when: ActiveEditorContext.isEqualTo(NotebookTextDiffEditor.ID) </ins> }, menu: { id: MenuId.EditorTitle,

Discussion:
Looks new, this is overriding alt+f3 "show next change" in text editors
very good catch. I also wish to have AI detecting this sort of mistakes. Fix is coming
Change:
case GitErrorCodes.Conflict: message = l10n.t('There are merge conflicts. Resolve them before committing.'); type = 'warning'; <ins> choices.set(l10n.t('Show Changes'), () => commands.executeCommand('workbench.view.scm')); </ins> options.modal = false; break; case GitErrorCodes.StashConflict: message = l10n.t('There were merge conflicts while applying the stash.'); <ins> choices.set(l10n.t('Show Changes'), () => commands.executeCommand('workbench.view.scm')); </ins> type = 'warning'; options.modal = false; break;

Discussion:
Testing Related to , this notification blocks the button. Many users may never close it and will never see the merge editor button. !
Adding because this message isn't something the 3wm editor controls but something that comes out of git itself
With I have another option that allows user to show the SCM view/changes so that they can (1) get rid of the notification and (2) have a way to see all conflicts to handle them
Change:
args = {}; } <del> return { openToSide: args.openToSide, query: args.query </del> <ins> let sanitizedObject: IOpenSettingsActionOptions = { focusSearch: sanitizeBoolean(args?.focusSearch), openToSide: sanitizeBoolean(args?.openToSide), query: sanitizeString(args?.query) </ins> }; <ins> if (isString(args?.revealSetting?.key)) { sanitizedObject = { ...sanitizedObject, revealSetting: { key: args.revealSetting.key, edit: sanitizeBoolean(args.revealSetting?.edit) } }; } return sanitizedObject; </ins> } class PreferencesActionsContribution extends Disposable implements IWorkbenchContribution {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Actions like current only accepts options in . Allowing setting other options from like allows extensions directly open json setting editor with specific setting keys (when the extension is asking user to edit some custon json settings)
Leaving this to you for the action to be taken.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
const DEFAULT_THEME_SETTING_VALUE = 'Default Dark+'; const PERSISTED_THEME_STORAGE_KEY = 'colorThemeData'; <ins> const PERSISTED_ICON_THEME_STORAGE_KEY = 'iconThemeData'; </ins> const defaultThemeExtensionId = 'vscode-theme-defaults'; const oldDefaultThemeExtensionId = 'vscode-theme-colorful-defaults';

Discussion:
It would be nice if icons would show up directly after starting the workbench instead of having to wait for the extension host to be ready. Similar to color themes where the data is stored in local storage, the icons data should also be stored so that the overall experience is smooth.
can we consider this for this milestone? I want to mark this "perf-startup" because the fact that the icons only "kick in" later after the UI is already done makes the entire editor appear like a website that needs to load icons later separately which is ugly. It also causes some ugly jumping for opened tabs. ! /cc
PR:
Change:
if (windowState.uiState.mode === WindowMode.Fullscreen) { if (displaysWithFullScreenWindow.has(windowState.uiState.display)) { if (isMacintosh && windowState.windowId !== currentWindowsState.lastActiveWindow?.windowId && !window.win?.isSimpleFullScreen()) { <del> windowState.uiState.mode = WindowMode.Maximized; </del> <ins> windowState.uiState.mode = WindowMode.Normal; </ins> } } else { displaysWithFullScreenWindow.add(windowState.uiState.display);

Discussion:
https://user- Expect: <img width="1440" alt="Snipaste2022-08-2605-17-23" src="https://user-"Actual: <img width="1440" alt="Snipaste2022-08-2605-17-04" src="https://user-"
Yes, this was probably not a good change from me in
Change:
changed = true; } <ins> // Experiments if (typeof config.workbench?.enableExperiments === 'boolean' && config.workbench.enableExperiments !== this.experimentsEnabled) { this.experimentsEnabled = config.workbench.enableExperiments; changed = true; } </ins> // Notify only when changed and we are the focused window (avoids notification spam across windows) if (notify && changed) { this.doConfirm(

Discussion:
a session which was opted into an experiment (eg Control Center) experiments Experiment is still running. (eg Control Center is still rendered) ! !
I think reload is required for the experiment to be disabled. Have you?
If reload is required, we should leverage the mechanism that prompts the user to reload, whenever the setting changes.
Change:
const newRenderMode = e.altKey && e.ctrlKey ? altMode : defaultMode; if (newRenderMode !== this._activeRenderMode) { this._activeRenderMode = newRenderMode; <del> const ranges = this._getHintsRanges(); const copies = this._copyInlayHintsWithCurrentAnchor(this._editor.getModel()); this._updateHintsDecorators(ranges, copies); </del> <ins> const model = this._editor.getModel(); const copies = this._copyInlayHintsWithCurrentAnchor(model); this._updateHintsDecorators([model.getFullModelRange()], copies); </ins> scheduler.schedule(0); } }));

Discussion:
The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)
I am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.
I think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.
is this issue closed? or still needs help?
Its still open and there is a PR which has to be reviewed.
Hello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?
Thanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/
Change:
} await Promise.all([...galleryExtensionsMap.values()].map(async gallery => { try { <del> const webExtension = cached.find(e => areSameExtensions(e.identifier, gallery.identifier) && e.version === gallery.version) ?? await this.toWebExtensionFromGallery(gallery, { isPreReleaseVersion: gallery.properties.isPreReleaseVersion, preRelease: gallery.properties.isPreReleaseVersion, isBuiltin: true }); </del> <ins> const webExtension = await this.toWebExtensionFromGallery(gallery, { isPreReleaseVersion: gallery.properties.isPreReleaseVersion, preRelease: gallery.properties.isPreReleaseVersion, isBuiltin: true }); </ins> webExtensions.push(webExtension); } catch (error) { this.logService.info(`Ignoring additional builtin extension ${gallery.identifier.id} because there is an error while converting it into web extension`, getErrorMessage(error));

Discussion:
Version : 1.76.1 Commit : Date : 2023-03-08T16:32:15.546Z Navigateur : Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.4985.0 Safari/537.36 Edg/102.0.1235.1 with the extension installed (stable) switch the display language to French, reload VS Code switch the display language to English, reload VS Code open the remote menu, see that there's still a French menu entry in there ! Open the extension view ! I also see it the other way around: !
Ahhh so it looks like this is returning remote-repositories extension: with the old german manifest. What’s odd to me is that remote-repositories is being returned by and ... but even still, I don't know much about this code, but I would expect that the cache would cache the manifest in its raw form with the placeholders and then allow the runtime to translate the manifest (which could be optimized to cache both raw and translated form and only re-compute when language changes)
I'm giving this one to you since it seems like a issue from the caching changes.
It seems we are translating the manifest always even if it is cached. But, I observed that some how (I do not know, may be in the old code), cache is having the already translated manifest. Therefore, while translating nothing gets translated. We do update cache every time but it seems if the version has not changed, we reuse the entry from the cache. There is no reason we have to reuse the entry from the cache. So fixed it by recomputing the cache entry always while updating the cache.
Change:
import { IConfigurationService } from '../../../../../platform/configuration/common/configuration.js'; import { IContextKeyService } from '../../../../../platform/contextkey/common/contextkey.js'; import { IListService, IWorkbenchListOptions, WorkbenchList } from '../../../../../platform/list/browser/listService.js'; <del> import { CursorAtBoundary, ICellViewModel, CellEditState, CellFocusMode, ICellOutputViewModel, CellRevealType, CellRevealRangeType, CursorAtLineBoundary, INotebookViewZoneChangeAccessor } from '../notebookBrowser.js'; </del> <ins> import { CursorAtBoundary, ICellViewModel, CellEditState, ICellOutputViewModel, CellRevealType, CellRevealRangeType, CursorAtLineBoundary, INotebookViewZoneChangeAccessor } from '../notebookBrowser.js'; </ins> import { CellViewModel, NotebookViewModel } from '../viewModel/notebookViewModelImpl.js'; import { diff, NOTEBOOK_EDITOR_CURSOR_BOUNDARY, CellKind, SelectionStateType, NOTEBOOK_EDITOR_CURSOR_LINE_BOUNDARY } from '../../common/notebookCommon.js'; import { ICellRange, cellRangesToIndexes, reduceCellRanges, cellRangesEqual } from '../../common/notebookRange.js';

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --- Version: 1.94.0-insider (user setup) Commit: OS: Windows_NT x64 10.0. Jupyter Extension version (available under the Extensions sidebar): v2024.9. (pre-release) Python Extension version (available under the Extensions sidebar): v2024.15. (pre-release) First part of the video: cursor in a markdown cell, somewhere in the visible area of the screen out of the cell to double click somewhere in the visible area of the screen to highlight text (either same line or not) Cell scrolls to the top so I can't see what I'm trying to highlight (the text is highlighted as intended though) Second part of the video: cursor in markdown cell, somewhere in the NOT visible area of the screen out of the cell to double click somewhere in the visible area of the screen to highlight text Cell scrolls to the previously placed cursor area (which is great if I'm single-clicking into the cell, but in this case, it feels glitchy to me)
I have the same issue!
Change:
const firstChar = this._leadingLineContent.length === 0 ? '' : this._leadingLineContent[0]; // This is a TabExpansion2 result <del> if (this._leadingLineContent.trim().includes(' ') || firstChar === '[') { </del> <ins> if (this._leadingLineContent.includes(' ') || firstChar === '[') { </ins> replacementIndex = parseInt(args[0]); replacementLength = parseInt(args[1]); this._leadingLineContent = this._promptInputModel.value.substring(0, this._promptInputModel.cursorIndex);

Discussion:
Repro: on /pwsh ctrl+space, often completions don't show up but they definitely come in as seen in Pty Host trace log !
Change:
return markdownTooltip; } <del> private async installAndRunStartCommand(metadata: RemoteExtensionMetadata) { const extensionId = metadata.id; </del> <ins> private async installExtension(extensionId: string) { </ins> const galleryExtension = (await this.extensionGalleryService.getExtensions([{ id: extensionId }], CancellationToken.None))[0]; await this.extensionManagementService.installFromGallery(galleryExtension, {

Discussion:
Testing After clicking the "Install" entry in the quick pick, there's progress for a few moments, then the quick pick flashes back to showing all the previous entries again, before finally landing on the setup options for the remote extension. !
Change:
const promises = registry.ordered(model).reverse().map(provider => ranges.map(async range => { try { const result = await provider.provideInlayHints(model, range, token); <del> if (result?.hints.length) { data.push([result, provider]); </del> <ins> if (result?.hints.length || provider.onDidChangeInlayHints) { data.push([result ?? InlayHintsFragments._emptyInlayHintList, provider]); </ins> } } catch (err) { onUnexpectedExternalError(err);

Discussion:
Does this issue occur when all extensions are disabled?: Yes Version: 1.80.0-insider (Universal) Commit: Date: 2023-06-29T07:48:55.355Z Electron: 22.3.14 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 20.6.0 ProductName: macOS ProductVersion: 11.7.8 BuildVersion: 20G1351 not triggering when returns empty array on initial call and non-empty array thereafter. Steps to Reproduce: the following extension sample. Open a TypeScript file. inlay hint at the first line. you resize the window, the inlay hint appears.
Change:
RunRecentCommand = 'workbench.action.terminal.runRecentCommand', CopyLastCommand = 'workbench.action.terminal.copyLastCommand', GoToRecentDirectory = 'workbench.action.terminal.goToRecentDirectory', <ins> CopyAndClearSelection = 'workbench.action.terminal.copyAndClearSelection', </ins> CopySelection = 'workbench.action.terminal.copySelection', CopySelectionAsHtml = 'workbench.action.terminal.copySelectionAsHtml', SelectAll = 'workbench.action.terminal.selectAll',

Discussion:
This has bugged me for years but wasn't sure how we should handle it. I think we should do this: ctrl+shift+c: works as it does now, when there is a selection this will copy the selection and retain it ctrl+c: if this is bound to copy when there is a selection (Windows), it should copy the selection and clear it, such that the next ctrl+c will send an interrupt.
On Unix (MacOS and Linux), is used alongside to control the run sending intetrupt signal to the process for the first and suspend for the other. I ended up on this ticket because Ctrl-C was not working to stop the Python debugger with CTRL-C in vscode. Windows version of the debugger uses Ctrl-D for that, but don't be confused that is only for Windows. Clearly something wrong is happening with Ctrl-C on vscode terminal for sure. While looking at this bug may it be possible to address the Ctrl-C not being send to the terminal?
ctrl+c does send SIGINT, it works a little differently on Windows though; if there is a selection it will copy. The proposal here is to copy and clear the selection, such that the next ctrl+ sends SIGINT. You can verify that ctrl+c is sending SIGINT by running the toggle escape sequence logging command as that will show what gets sent to the process.
This is a minor feature that would be good to call out in the release notes.
Change:
} private async runMigration(migration: ConfigurationMigration, overrides: IConfigurationOverrides, dataKey: keyof IConfigurationValue<any>, data?: IConfigurationValue<any>): Promise<ConfigurationKeyValuePairs | undefined> { <del> const value = (data ?? this.configurationService.inspect(migration.key, overrides))[dataKey]; </del> <ins> const valueAccessor = (key: string) => getInspectValue(this.configurationService.inspect(key, overrides)); const getInspectValue = (data: IConfigurationValue<any>) => { const inspectValue: { value?: any; override?: any } | undefined = data[dataKey]; return overrides.overrideIdentifier ? inspectValue?.override : inspectValue?.value; }; const value = data ? getInspectValue(data) : valueAccessor(migration.key); </ins> if (value === undefined) { return undefined; } <del> const valueAccessor = (key: string) => this.configurationService.inspect(key, overrides)[dataKey]; </del> const result = await migration.migrateFn(value, valueAccessor); return Array.isArray(result) ? result : [[migration.key, result]]; }

Discussion:
Type: <bBug</bThe auto update of code action setting adds additional settings: ! VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-15T09:43:13.091Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ tsl-problem-matcher0.6.2 ruff2023.50.0 vscode-eslint2.4.2 gitlens14.5.0 EditorConfig0.16.4 prettier-vscode10.1.0 copilot1.137.552 copilot-chat0.11. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.77. vscode-docker1.28.0 black-formatter2023.7. python2023.21. vscode-pylance2023.11.12 remote-containers0.321.0 remote-ssh0.107.0 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 azure-account0.11.6 remote-explorer0.4.1 remote-repositories0.40.0 remote-server1.5.0 rust-analyzer0.4.1734 code-spell-checker3.0.1 vscode-lldb1.10.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
cc not sure if this is an issue on my end with the migration from or something from this fix ?
Are there steps to reproduce?
All you need is this in your workspace settings: Add the above setting to your workspace before opening it in VS Code insiders.
So is the following unexpected after migration?
Correct. Expected is this:
I will investigate
Change:
this.toDispose = []; this.selectBox = new SelectBox([], -1, contextViewService, undefined, { ariaLabel: nls.localize('debugLaunchConfigurations', 'Debug Launch Configurations') }); this.toDispose.push(this.selectBox); <del> this.toDispose.push(attachSelectBoxStyler(this.selectBox, themeService, { selectBackground: SIDE_BAR_BACKGROUND })); </del> <ins> this.toDispose.push(attachSelectBoxStyler(this.selectBox, themeService)); </ins> this.registerListeners(); }

Discussion:
I played around with to set the background color of the dropdown widget. It works fine in the panel area but e.g. not for the debug dropdown. That makes me wonder if we possibly have code in debug land that overrides this because the debug view is in the side bar. That is probably not a good idea given you can move views around. !
Same for remote explorer, so it is maybe more generic: ! //cc
You are correct we use the sidebar_background for the debug I thought the issue is that we also have a green play button which is part of this and we did not want to custmoise it becuase the Green play might not look good on the customised background. As for the remote explorer I have no clue.
I think the remote one is covered via
That one was probably a copy paste mistake from debug land :)
last milestone and I saw this differentiation and assumed it was intentional that all sidebar dropdowns do not honor the theme color. this meant that if you drag terminal or output to the sidebar (in their own viewlet), they will also skip using the theme color for dropdown
I am opening this for a PR. Code pointer The debug select box should listen to style changes and also style the background of the Green Play button.
Adding lable bug so we get this verified.
Change:
const element = context.length ? context[0] : explorerService.roots[0]; const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; <ins> const editableItem = explorerService.getEditable(); // If it's an editable item, just do nothing if (editableItem) { return; } </ins> try { // Check if target is ancestor of pasted folder const sourceTargetPairs = coalesce(await Promise.all(toPaste.map(async fileToPaste => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.85.0 Commit: Date: 2023-12-06T18:17:50.719Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.1.0 macOS Version: macOS Sonoma 14.1.1 Steps to Reproduce: a file(Command-C) in VS Code explorer in VS Code explorer (Command-P) in VS Code explorer Code not respond Gif reproduce steps: !
Can reproduce on Windows 10 22H2: <img width="1308" alt="image" src=""The copied file will be created () and then the application freezes.
I'm unable to get a crash dump, but there are some logs when I run