jiebi/CodeConvo huggingface dataset:
Change:
resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-8.0.0.tgz#2c7a3b1163ef0441097e0b5d6389cd5504b59e5d" integrity sha512-AFbieoL7a5LMqcnOF04ji+rpXadgOXnZsxQr//r83kLPr7biP7am3g9zbaZIaBGwBRWeSvoMD4mgPdX3e4NWBg== <del> xterm-addon-canvas@0.3.0-beta.35: version "0.3.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version "0.4.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7"

Discussion:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:
Change:
private checkShell(): void { if (platform.isWindows && this._terminalInstance.isTitleSetByProcess) { <del> this.getShellName().then(title => this._terminalInstance.setTitle(title, true)); </del> <ins> this.getShellName().then(title => { if (!this._isDisposed) { this._terminalInstance.setTitle(title, true); } }); </ins> } } private getChildProcessDetails(pid: number): TPromise<{ executable: string, pid: number }[]> { return new TPromise((resolve, reject) => { <del> cp.execFile('wmic.exe', ['process', 'where', `parentProcessId=${pid}`, 'get', 'ExecutablePath,ProcessId'], (err, stdout, stderr) => { </del> <ins> this._wmicProcess = cp.execFile('wmic.exe', ['process', 'where', `parentProcessId=${pid}`, 'get', 'ExecutablePath,ProcessId'], (err, stdout, stderr) => { this._wmicProcess = null; if (this._isDisposed) { reject(null); } </ins> if (err) { reject(err); } else if (stderr.length > 0) {

Discussion:
Steps to reproduce: and kill terminal very quickly This can likely happen when the terminal is killed during a call.
I can still repro this with the same stack, I don't think the PR fixes the right issue. It fails on this line, because is null: A null xterm object is passed into the constructor, which implies that the terminal instance was disposed, so I think the problem is the terminalInstance being disposed while is running:
Change:
default: true }, [TerminalSettingId.LocalEchoLatencyThreshold]: { <del> description: localize('terminal.integrated.localEchoLatencyThreshold', "Experimental: length of network delay, in milliseconds, where local edits will be echoed on the terminal without waiting for server acknowledgement. If '0', local echo will always be on, and if '-1' it will be disabled."), </del> <ins> description: localize('terminal.integrated.localEchoLatencyThreshold', "Length of network delay, in milliseconds, where local edits will be echoed on the terminal without waiting for server acknowledgement. If '0', local echo will always be on, and if '-1' it will be disabled."), </ins> type: 'integer', minimum: -1, default: 30,

Discussion:
Are all these settings still "experimental"? This seems like a mature feature !
This is a good point. I believe the wording is used to indicate the functionality has some quirks. We will see if thinks it's fine to remove it.
Yep let's do it, I think we just didn't remember to remove
Change:
@@NAME@@: command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ --no-sandbox common-id: @@NAME@@.desktop <del> environment: GTK_USE_PORTAL: 1 </del> url-handler: command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ --open-url --no-sandbox <del> environment: GTK_USE_PORTAL: 1 </del>

Discussion:
Type: <bBug</bnew file file to some location, say, breadcrumb for the same file that you just saved, still open in the editor. The location you saved the file to won't appear, instead, the file appears in VS Code version: Code 1.77.3 (, 2023-04-12T09:16:52.732Z) OS version: Linux x64 5.14.0-1059-oem snap Modes: Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
may be related.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I can't reproduce the original issue in 1.77, so can you tell us whether it's fixed for you in Insiders?
you would need to use Ubuntu <= 21.04 VM for repro'ing the bug on v1.77
I was using Ubuntu 18.04 but also xfce, if it matters
/verified
Reported on StackOverflow:
Change:
didDragMarkupCell: that._didDragMarkupCell.bind(that), didDropMarkupCell: that._didDropMarkupCell.bind(that), didEndDragMarkupCell: that._didEndDragMarkupCell.bind(that) <del> }, id, resource, this._notebookOptions.computeWebviewOptions(), this.notebookRendererMessaging.getScoped(this._uuid)); </del> <ins> }, id, resource, { ...this._notebookOptions.computeWebviewOptions(), fontFamily: this._generateFontFamily() }, this.notebookRendererMessaging.getScoped(this._uuid)); </ins> this._webview.element.style.width = '100%';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider (Universal) Commit: OS Version: Mac OS Monterey 12.2.1 Follow up issue to as this is a degradation in UX compared to the non-Insider version. Any input on that ? Current: ! Expected: Different columns should be aligned !
thank you for the bug report!
Change:
if [ "$__vsc_in_command_execution" = "0" ]; then __vsc_initialized=1 __vsc_in_command_execution="1" <ins> if [[ ! "$BASH_COMMAND" =~ ^__vsc_prompt* ]]; then __vsc_current_command=$BASH_COMMAND else __vsc_current_command="" fi </ins> __vsc_command_output_start fi }

Discussion:
This is a follow up from which worked around the majority case of an issue. See the workaround: The proper fix will involve sending both the exit code and the history ID over to VS Code which will then do what's happening now but also have the correct exit code to set, instead of assuming it's the last command's exit code. We should write a little script as part of this that alternates exit codes by setting/unsetting an environment variable so it's easier to test and verify.
The issue being worked around is actually caused by or being included in .
Good test case from
To verify: some commands , they should all show up in current session ctrl+c in between some commands, including typing out a command and hitting ctrl+c to abandon it , the lines with ctrl+c shouldn't show up several times, failed and success should match whether the exception was thrown.
Change:
export const listInactiveSelectionIconForeground = registerColor('list.inactiveSelectionIconForeground', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('listInactiveSelectionIconForeground', "List/Tree icon foreground color for the selected item when the list/tree is inactive. An active list/tree has keyboard focus, an inactive does not.")); export const listInactiveFocusBackground = registerColor('list.inactiveFocusBackground', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('listInactiveFocusBackground', "List/Tree background color for the focused item when the list/tree is inactive. An active list/tree has keyboard focus, an inactive does not.")); export const listInactiveFocusOutline = registerColor('list.inactiveFocusOutline', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('listInactiveFocusOutline', "List/Tree outline color for the focused item when the list/tree is inactive. An active list/tree has keyboard focus, an inactive does not.")); <del> export const listHoverBackground = registerColor('list.hoverBackground', { dark: '#2A2D2E', light: '#F0F0F0', hcDark: null, hcLight: Color.fromHex('#0F4A85').transparent(0.1) }, nls.localize('listHoverBackground', "List/Tree background when hovering over items using the mouse.")); </del> <ins> export const listHoverBackground = registerColor('list.hoverBackground', { dark: '#2A2D2E', light: '#F0F0F0', hcDark: Color.white.transparent(0.1), hcLight: Color.fromHex('#0F4A85').transparent(0.1) }, nls.localize('listHoverBackground', "List/Tree background when hovering over items using the mouse.")); </ins> export const listHoverForeground = registerColor('list.hoverForeground', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('listHoverForeground', "List/Tree foreground when hovering over items using the mouse.")); export const listDropBackground = registerColor('list.dropBackground', { dark: '#062F4A', light: '#D6EBFF', hcDark: null, hcLight: null }, nls.localize('listDropBackground', "List/Tree drag and drop background when moving items around using the mouse.")); export const listHighlightForeground = registerColor('list.highlightForeground', { dark: '#2AAAFF', light: '#0066BF', hcDark: focusBorder, hcLight: focusBorder }, nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.'));

Discussion:
to the setting in the Settings editor. to the dark high contrast theme. over the list items. :bug: No visual indication appears other than the pencil and close icons showing up on the right. This problem does not occur on the light high contrast theme.
Change:
@IEditorService editorService: IEditorService, @IEditorGroupsService editorGroupService: IEditorGroupsService, @IFileService fileService: IFileService, <ins> @ICodeEditorService private readonly _codeEditorService: ICodeEditorService, </ins> ) { super(MergeEditor.ID, telemetryService, instantiation, storageService, textResourceConfigurationService, themeService, editorService, editorGroupService, fileService);

Discussion:
It was weird when I toggled word wrap in the merge editor yet only the editor I was focused on had it toggled. I kind of expected all editors to have it toggled. My rationale is that toggling word wrap is usually a symptom of having long lines and the chances that all three editors have long lines is high if a single editor has long lines.
I agree. Until recently word wrap only toggled one side of the diff editor. See
Change:
statusBarItem.command = cancelCommandId; statusBarItem.show(); <del> const clonePromise = this.git.clone(url, parentPath, tokenSource.token); </del> <ins> const clonePromise = this.git.clone(url, this.handlePathTilde(parentPath), tokenSource.token); </ins> try { window.withProgress({ location: ProgressLocation.SourceControl, title: localize('cloning', "Cloning git repository...") }, () => clonePromise);

Discussion:
Given , I should be able to Run In parent directory prompt, enter Get popup
Hasn't this issue been solved before ? If it hasn't I'll try to fix it.
Actually it seems the current solution can only handle in the config setting... but not in the input box!
hello I could take a look at the issue if no one is already assigned. It would be my first one. Regards, Pascal.
Hi let me know if you're working on the issue. I think I've found a solution.
go for it !
Change:
} /* gutter decoration */ <del> .monaco-editor .glyph-margin-widgets .cgmr { </del> <ins> .monaco-editor .glyph-margin-widgets .cgmr[class*="codicon-gutter-lightbulb"] { </ins> display: block; cursor: pointer; <del> opacity: 1; transition: opacity .2s ease-in-out; </del> } .monaco-editor .glyph-margin-widgets .cgmr.codicon-gutter-lightbulb,

Discussion:
I notice on the latest insiders now when I start and stop debugging the breakpoints are ending up below the line numbers instead of the gutter !
this CSS rule applies to all glyph margin widgets, maybe you want to scope it more specifically for the lightbulb widget? This is overriding what was the for glyph margin widgets.
Change:
*--------------------------------------------------------------------------------------------*/ import { LazyStatefulPromise, raceTimeout } from 'vs/base/common/async'; <ins> import { onUnexpectedError } from 'vs/base/common/errors'; </ins> import { IDisposable, DisposableStore, toDisposable } from 'vs/base/common/lifecycle'; import { deepClone } from 'vs/base/common/objects'; <del> import { isObject } from 'vs/base/common/types'; </del> <ins> import { isDefined, isObject } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import { ConstLazyPromise, IDocumentDiffItem, IMultiDiffEditorModel } from 'vs/editor/browser/widget/multiDiffEditorWidget/model'; import { MultiDiffEditorViewModel } from 'vs/editor/browser/widget/multiDiffEditorWidget/multiDiffEditorViewModel';

Discussion:
Type: <bBug</bWhen reviewing outgoing changes for my tracking fork of microsoft/vscode after merging upstream/main into my local copy today. ! Also, based on I was surprised to see the magnifying glass icon still being used for "View Changes". VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-22T05:35:23.085Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
/assign
I'm very sure this is a duplicate of
This sounds like there was no insiders for today. Can you check you are running the build from today? The PR just got merged yesterday.
Yes, this is today's. The new codicon appears in the Timeline view, just not in the incoming/outgoing party of Source Control view: !
It does for me: !
Ah, we're not talking about the same thing. My screenshot is of the feature recently by and controlled by the and settings. It comes from here:
are you able to reproduce this consistently? Could you provide steps that that I should use to try to reproduce the issue? Thanks!
in said it was probably a known issue. Ever since Insiders got that fix I haven't had any problems opening multi-diff for outgoing changes that get listed after I merge from upstream/main into my local main prior to pushing them to origin/main (my tracking repo). So I'm closing this one.
thanks for the update!
Hmm, just happened to me again with today's Insiders: ! Reopening. I'll hold back from pushing the local changes that I merged in from upstream/main in case there are places you'd like me to look for clues while I can repro it.
Devtools console:
It's this one: ! And specifically which is of course binary: ! I guess the multi diff editor needs to handle this case gracefully instead of failing to show the diffs for the other files.
thanks! could you please take a look? Thanks!
Ahh, because it is a binary file...
Change:
openExternal(url: string): TPromise<boolean>; // TODO: this is a bit backwards <del> startCrashReporter(config: Electron.CrashReporterStartOptions): TPromise<void>; </del> <ins> startCrashReporter(config: CrashReporterStartOptions): TPromise<void>; </ins> } export const IWindowService = createDecorator<IWindowService>('windowService');

Discussion:
There a few usages of in which is against our layering rules. I'd suggest to move the whole file into an folder
Unfortunately this might not be so simple given 62 references of which some would also need to be lifted up... An alternative would be to define similar interfaces that contain the properties we actually need instead of depending on Electron.
Also: and
I'd favour to lift them all instead blowing up our code size
with our current code organisation I cannot express the proper way for these references. Here are the issues: Moving this service into src/workbench This was my first idea, but it doesn't work. There are references from (our main side of things) into the windows service because the main side basically implements that service. We should not depend from to other than the file that we load into a window. The only way out I see here is to have something like for services that are shared between and . Moving the service from common into electron-browser This will not help because we have depending on the windows service and thus we would reach from into . The only option would be to introduce a new layer that contains the service and that can be accessed by and . To unblock your 2-CU scenario and to use ES6 features in workbench I suggest to that will inline the Electron references. However if we ever want to tackle this properly it needs some serious new code-structure layout on disk. Thoughts?
Yeah, makes sense... It's unfortunate but reality...
Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { strictEqual } from 'assert'; import { fromNow } from 'vs/base/common/date'; suite('Date', () => { suite('fromNow', () => { test('appendAgoLabel', () => { strictEqual(fromNow(Date.now() - 35000), '35 secs'); strictEqual(fromNow(Date.now() - 35000, false), '35 secs'); strictEqual(fromNow(Date.now() - 35000, true), '35 secs ago'); }); test('useFullTimeWords', () => { strictEqual(fromNow(Date.now() - 35000), '35 secs'); strictEqual(fromNow(Date.now() - 35000, undefined, false), '35 secs'); strictEqual(fromNow(Date.now() - 35000, undefined, true), '35 seconds'); }); test('disallowNow', () => { strictEqual(fromNow(Date.now() - 5000), 'now'); strictEqual(fromNow(Date.now() - 5000, undefined, undefined, false), 'now'); strictEqual(fromNow(Date.now() - 5000, undefined, undefined, true), '5 secs'); }); }); }); </ins>

Discussion:
Version: 1.44.0-insider (user setup) Commit: Date: 2020-03-31T08:23:56.446Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. This: ! Reminds me of this in onenote: ! The latter of which drives me crazy as it always lies to me and a restart to re-sync onenote is needed sometimes. Can we get the local time down to the second when you hover the last synced text?
what are the current setup steps for Sync in OSS? I have the setting set to whatever I tested it with a couple months ago but I don't see any Sync commands in the command palette. I can't remember where this is written down.
Could just put the real time in a tooltip, if that helps
I think just the change is needed to get it going in Code OSS. would solve my problem.
Change:
if (!editor.selectedCategory && group) { editor.selectedCategory = selectedCategory; editor.selectedStep = selectedStep; <ins> editor.showWelcome = false; </ins> group.openEditor(editor, { revealIfOpened: true }); return; }

Discussion:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.
Change:
dialogService.info(localize('successFrom', "Shell command '{0}' successfully uninstalled from PATH.", productService.applicationName)); } catch (error) { <ins> if (isCancellationError(error)) { return; } </ins> dialogService.error(toErrorMessage(error)); } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (It's happening for fresh installation) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Macbook M1 Pro - Sonoma 14.2.1 Steps to Reproduce: VSCode Darwin build from downloads page - (Mac .zip Apple Silicon) Shell command: Install 'code' command in PATH cancel for the below prompt <img width="1136" alt="Screenshot 2024-01-02 at 7 35 58 PM" src=""It should display that shell command was not completed successfully. Instead it shows command successfully <img width="1136" alt="Screenshot 2024-01-02 at 7 38 19 PM" src=""
Change:
identityProvider: new SCMResourceIdentityProvider(), sorter: new SCMTreeSorter(() => this.viewMode, () => this.viewSortKey), keyboardNavigationLabelProvider: this.instantiationService.createInstance(SCMTreeKeyboardNavigationLabelProvider, () => this.viewMode), <del> overrideStyles: { listBackground: this.viewDescriptorService.getViewLocationById(this.id) === ViewContainerLocation.Panel ? PANEL_BACKGROUND : SIDE_BAR_BACKGROUND }, </del> <ins> overrideStyles: this.getLocationBasedColors().listOverrideStyles, </ins> collapseByDefault: (e: unknown) => { // Repository, Resource Group, Resource Folder (Tree), History Item Change Folder (Tree) if (isSCMRepository(e) || isSCMResourceGroup(e) || isSCMResourceNode(e) || isSCMHistoryItemChangeNode(e)) {

Discussion:
Sometimes the tree sticky show shadow does not show. Make sure they use the proper overrides and that there is a default color if none is provided
are there any validation steps here?
verified- the scm sticky scroll showed on insiders, but not stable.
Change:
private async initialize(): Promise<IStorageService> { let storageService; if (!this._useInMemoryStorage && await this._encryptionService.isEncryptionAvailable()) { <ins> this._logService.trace(`[SecretStorageService] Encryption is available, using persisted storage`); </ins> this._type = 'persisted'; storageService = this._storageService; } else {

Discussion:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as
Change:
constructor( @ILayoutService private readonly layoutService: ILayoutService, <del> @IEditorService private readonly editorService: IEditorService, </del> @IConfigurationService private readonly configurationService: IConfigurationService, @IFileService private readonly fileService: IFileService, @ILabelService private readonly labelService: ILabelService,

Discussion:
Steps to Reproduce: = workbench does not open From: Workaround:
I think depending on is logically correct. But, in web is depending on other workbench services like --and causing cycle. Not having consistent base services in desktop and web is causing confusion and debt and it might add up as we evolve. I think fixing in is just a patch. To unblock for now, I removed the dependency on and used . Assigning back to you for fixing this in .