jiebi/CodeConvo huggingface dataset:
Change:
await this.beforeRemovingExtension(await this.toLocalExtension(latest)); } })); <del> const toRemove = extensions.filter(e => uninstalled[ExtensionKey.create(e).toString()]); </del> <ins> const toRemove = extensions.filter(e => e.metadata /* Installed by VS Code */ && uninstalled[ExtensionKey.create(e).toString()]); </ins> await Promises.settled(toRemove.map(e => this.removeUninstalledExtension(e))); }

Discussion:
The folder is now empty on my machine and around 20 extensions I wrote to troubleshoot various issues are gone . If I create a folder at with the contents an extension would have, it is not found by vscode anymore.
steps to reproduce: create an extension at start close vscode start observe how your files get deleted
Change:
} // Text editor has the lowest priority because we <del> const editorOverridePicks = this.mapContributionsToQuickPickEntry(resource, group, alwaysUpdateSetting); </del> <ins> const editorOverridePicks = this.mapContributionsToQuickPickEntry(resource, group, showDefaultPicker); </ins> // Create editor override picker const editorOverridePicker = this.quickInputService.createQuickPick<IQuickPickItem>(); <del> const placeHolderMessage = alwaysUpdateSetting ? </del> <ins> const placeHolderMessage = showDefaultPicker ? </ins> localize('prompOpenWith.updateDefaultPlaceHolder', "Select new default editor for '{0}'", basename(resource)) : localize('promptOpenWith.placeHolder', "Select editor for '{0}'", basename(resource)); editorOverridePicker.placeholder = placeHolderMessage;

Discussion:
When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a "Configure Default Formatter..." that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc
Change:
<ins> { "original": { "content": "hello world; ny", "fileName": "./1.txt" }, "modified": { "content": "hello world;n// new lineny", "fileName": "./2.txt" }, "diffs": [ { "originalRange": "[1,2)", "modifiedRange": "[1,3)", "innerChanges": null } ] } </ins>  No newline at end of file

Discussion:
. To verify the bugfix, check that in the newest version of the monaco editor the alignment is as expected. edit from <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.89.1 (user setup) Commit: Date: 2024-05-07T05:13:33.891Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. Searched existing issues by "compare vertical alignment" - no relevant results. Steps to Reproduce: files test2 and test1 them Fact wrong vertical alignment of identical rows after delete-add section ! Expected !
Thanks for sharing the input documents and the screenshot! Unfortunately, it is still not clear what this issue is about - I don't see a big difference in the screenshots. Can you add more details?
difference (expected empty range) is shown on this picture !
Ahh, I see. Can you check the dev console?
No. I want fix in my test. Not in dev console. Can you reproduce my simple test in user interface?
No, I cannot reproduce. But I think VS Code might have logged some errors to the VS Code dev console. You could help me fixing this bug, but sharing if there are any error messages in the VS Code dev console.
Show your comparison result. Here is log from dev console: An iframe which has both allow-scripts and allow-same-origin for its sandbox attribute can escape its sandboxing. !
Change:
<ins> # --------------------------------------------------------------------------------------------- #   Copyright (c) Microsoft Corporation. All rights reserved. #   Licensed under the MIT License. See License.txt in the project root for license information. # --------------------------------------------------------------------------------------------- $Global:__VSCodeOriginalPrompt = (Get-Command Prompt).ScriptBlock function Global:__VSCode-Get-LastExitCode { if ($? -eq $True) { return "0" } # TODO: Should we just return a string instead? return "-1" } function Global:Prompt() { return "`e]133;D;$(__VSCode-Get-LastExitCode)`u{7}`e]133;A`u{7}`e]1337;CurrentDir=$(Get-Location)`u{7}$(Invoke-Command -ScriptBlock $Global:__VSCodeOriginalPrompt)`e]133;B`u{7}" } # TODO: Gracefully fallback when PSReadLine is not loaded function Global:PSConsoleHostReadLine { [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine($Host.Runspace, $ExecutionContext) # Write command executed sequence directly to Console to avoid the new line from Write-Host [Console]::Write("`e]133;C`u{7}") } Write-Output "`e]133;E`u{7}" </ins>

Discussion:
Parent issue Main target is Windows but ideally it would just work on all platforms (might need some tweaking on how the process is launched).
We could cache and and use the latest one whenever is , this would let us get the actual latest exit code or exception.
Done, moved the improved exit code/exception checking to
Change:
"scopeName": "source.clojure", "path": "./syntaxes/clojure.tmLanguage.json" } <del> ] </del> <ins> ], "configurationDefaults": { "[clojure]": { "diffEditor.ignoreTrimWhitespace": false } } </ins> }, "repository": { "type": "git",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
} }, "optionalDependencies": { <ins> "windows-foreground-love": "0.1.0", </ins> "windows-mutex": "^0.2.0", "fsevents": "0.3.8" }

Discussion:
This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Pushed a workaround.
Reopening, using the () workaround causes issues as it will undock windows it seems.
This happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.
As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows
Just tried the suggested workaround and it did not work. Using Windows 10 Home
I've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?
Seems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build
Must have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.
I started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build
Update: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.
This is happening to me also since the previous 2 releases. Changing the value of did not help
Change:
source: 'editor', link: editor.resource?.toString() }; <ins> // Only assert on selection if it's not the default value if (editor.options?.selection && (editor.options.selection.startColumn !== 1 || editor.options.selection.startLineNumber !== 1)) { activationResult.selection = editor.options.selection; } </ins> } } as Partial<IEditorService>); // /*editorServiceSpy = */instantiationService.spy(IEditorService, 'openEditor');

Discussion:
My project is under https://user- Reproduce steps: vscode open a folder which file path contains space, for example: an integrated terminal the path link Versions:
nice I can repro with the space in the name, thanks for following up
I can still repro with Windows.
I looked into this, and it will be tricky because we currently use space as one of the characters which indicates the end of a path. One idea would be to check if such a link exists (using our original regex) and if not, use regex on the subsequent sequence - then concatenating the two results for First result would be doesn't exist process exists
https://user- Look the above video, I have several questions. path is not a existed path in the disk, but also clickable. I click the , it open a file which is not why the whole string is recogonized to a path? the real path is:
this is actually about when the parents of the link have a space, it's expected currently that an absolute path with a space won't work.
is it expected that a local link with a space somewhere within the path is not detected? that is the case currently - verified via adding a test to
absolute paths (eg. ) won't work because of Relative paths without spaces with absolute ancestors that have spaces (eg. inside ) should work but don't in some cases.
When verifying, make sure to test both on a Windows machine and a non-Windows machine.
Doesn't work for me on a Mac, I guess thats probably because I still haven't got the fix in the latest insider build.
are you on ?
Worked for me on macOS. Don't have a Windows machine to try this out so someone else will need to verify on Windows.
Yes, I'm on that same version. Here's what it looks like for me on a Mac with spaces !
still not work in latest version: https://user-
For absolute paths, see I wasn't able to get to work, though. It'd open the file, but place the cursor at the beginning.
please provide some more details, it works for me: !
This is the behaviour with version 1.70.0 After ctrl+clik a popup appears at the top of the screen and I have to hit enter to go to the suggested file:line.
I can repro that on Windows, Remote-WSL and macOS.

The file must not be in the root directory for this to happen. !
let's track that problem in and as this issue is becoming quite unwieldy/unfocused.
created to track the problem related to quotes you're seeing. Could you re-verify this if all good outside of these 3 issues I created? It's difficult to manage this issue as it's so general.
Change:
interface PreloadStyles { readonly outputNodePadding: number; readonly outputNodeLeftPadding: number; <ins> readonly tokenizationCss: string; </ins> } export interface PreloadOptions {

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.79.1 Jupyter Extension version: 2023.5. Python Extension version: 2023.10.1 OS and version: Windows 11 Home Version 22H2, build .1778 If I change the theme after entering code in a Markdown cell, the code highlighting should change accordingly. Light theme: <img width="51" alt="image" src=""Dark theme: <img width="52" alt="image" src=""The code highlighting in Markdown cells does not change according to the theme. Light theme: <img width="44" alt="image" src=""Dark theme: <img width="48" alt="image" src=""an .ipynb file. a Markdown cell. some text formatted as code, e.g. python a = 5 ` Shift + Enter to render cell. theme (for example, if code was entered when using Light Modern, switch to Dark Modern). The code highlighting in the Markdown cell does not change and is now difficult to read.
Change:
this._ctxCanNavigate.set(Boolean(this._delegate)); } <ins> private _ensureSelectedElementIsVisible(): void { if (this._view.selection.length === 0) { return; } const [item] = this._view.selection; const location = this._delegate?.location(item); if (!location) { return; } if (vscode.window.activeTextEditor?.document.uri.toString() !== location.uri.toString()) { this._open(location, true); } } </ins> private _anchor(): undefined | unknown { if (!this._delegate) { return undefined;

Discussion:
Very often I loose the yellow markers in the editor for references, see here for example: ! Here I find references of  and quickly dismiss the results of the one file before clicking on the other. Both files were opened before.
Didn't reproduce for me. Please update with repro steps
steps be in a multi root workspace with and close all editors open click on  of (at the end of the file) run (I have it bound to command) expand by clicking it once in the references view click the first result remove the 2 references by clicking on the X starting from the first click on the last result from no more highlights in the editor at all Full video: !
When removing the -entry (all together or all by removing all its children) I am not (always) getting the selection change event.
anything special for reproing this? I haven't been able to hit it.
Selection change event should be fixed now.
Thanks
fyi noticing a few behavioural differences now, which maybe we tolerate but users might not: clicking on a file name now opens the first reference, previously I believe it was not navigating but just expanding/collapsing (see video 1) triggering find references seems to reveal a reference in another file in some cases (see video 2) ! !
Change:
id: `${providerId}${extensionId}Access`, title: nls.localize({ key: 'accessRequest', <del> comment: ['The placeholder {0} will be replaced with an extension name. (1) is to indicate that this menu item contributes to a badge count'] </del> <ins> comment: [`The placeholder {0} will be replaced with an authentication provider''s label. {1} will be replaced with an extension name. (1) is to indicate that this menu item contributes to a badge count`] </ins> }, <del> "Grant access to {0}... (1)", extensionName) </del> <ins> "Grant access to {0} for {1}... (1)", this.getLabel(providerId), extensionName) </ins> } });

Discussion:
Testing We don't show the provider in the list of extensions that want to sign in: ! In this case, test117290 wants to sign in using the provider and the others I assume want to sign in using GitHub. It would be good to know what I am signing into.
or maybe "sign in with <<< provider " to use ...
Verification steps: Install GHPR extension See: ! Install GitHub Codespaces extension ("Cancel" any modals) Reload VS Code Once GitHub Codespaces activates you should see: !
Change:
...this.chatResponseReceived }); <del> public static readonly chatResponseReceived5 = AudioCue.register({ sound: Sound.chatResponseReceived5, ...this.chatResponseReceived }); </del> public static readonly chatResponsePending = AudioCue.register({ name: localize('audioCues.chatResponsePending', 'Chat Response Pending'), sound: Sound.chatResponsePending,

Discussion:
cc Now that we have audio cues for the chat experience, all of which are off by default, we should think about what the best experience would be for most SR users and proceed with that once the final audio cues have been provided.
My choice here would be to only enable audioCues.chatResponsePending since it is the only one that provides information that is not redundant, however, this is an area in which I believe user research would be beneficial. for example, do people feel like these audio cues complement the screen reader feedback? are they distracting? Wen the chat is done generating the answer, do they prefer to receive screen reader feedback, the audio cue or both?
Yeah, that was my feeling as well Having all off by default would decrease discoverability, so I'm in favor of setting just that one to true until we have data that suggests otherwise
Just wanted to rule out any ambiguity here, does "audioCues.chatResponsePending" = the "progress" or "response" sound?
I believe he means progress because the response sound is redundant since the response gets read by the screen reader
Change:
import { IPosition } from 'vs/editor/common/core/position'; import { IRange, Range as EditorRange } from 'vs/editor/common/core/range'; import { isFalsyOrEmpty, isNonEmptyArray, coalesce, asArray } from 'vs/base/common/arrays'; <del> import { isObject } from 'vs/base/common/types'; </del> <ins> import { isArray, isObject } from 'vs/base/common/types'; </ins> import { ISelection, Selection } from 'vs/editor/common/core/selection'; import { ILogService } from 'vs/platform/log/common/log'; import { CancellationToken } from 'vs/base/common/cancellation';

Discussion:
Testing The existing API has , which returns . The new , API has , which returns . To better match the existing API, the version could return
That's a good idea! I've opened a PR for this, feel free to have a look if you like.
Change:
const fileKind = ResourceTree.isResourceNode(resourceOrFolder) ? FileKind.FOLDER : FileKind.FILE; const viewModel = this.viewModelProvider(); <ins> const [matches, descriptionMatches] = splitMatches(uri, node.filterData); </ins> template.fileLabel.setFile(uri, { fileDecorations: { colors: false, badges: !icon }, hidePath: viewModel.mode === ViewModelMode.Tree, fileKind, <del> matches: createMatches(node.filterData) </del> <ins> matches, descriptionMatches </ins> }); template.actionBar.clear();

Discussion:
I often make a lot of changes at once, and then need to commit them. Some changes don't belong together in the same commit, and some aren't ready to be committed at all. The current UI allows me to select some files to be staged for commit and exclude others, but it requires me to carefully select my changes from a potentially very long list. It would be incredibly useful if I could search or filter files by path pattern and stage/unstage all search results. Even better would be if I could search for lines of code and either stage files containing those lines or just the matched lines. This would streamline my git workflow by a lot.
I guess my ideal UI would allow me to: search files by path, and stage/unstage all matched files stage/unstage individually selected files search code in files, and stage/unstage all matched lines stage/unstage individually selected lines stage/unstage all matched files stage/unstage individually selected files
Since last month, SCM supports fancy keyboard navigation and filtering. Simply start typing when focused on the view. A widget will appear which you can use to toggle between simple highlighting and filtering. Currently filtering is done only on file names though, not paths or even code, so I can leave this open for additional filtering fields.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Change:
<del> <svg width="520" height="238" viewBox="0 0 520 238" fill="none" xmlns="http://www.w3.org/2000/svg"> </del> <ins> <svg viewBox="0 0 520 238" fill="none" xmlns="http://www.w3.org/2000/svg"> </ins> <g> <rect width="520" height="238" fill="var(--vscode-breadcrumb-background, #1E1E1E)" /> <g clip-path="url(#clip0_1_138)">

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 OS Version:MacOS Big Sur Steps to Reproduce: the in repo and Run on any step that shows a PNG image, like ! the image is vertically aligned on Top on the step ! the image is vertically aligned on Center I know SVGs are better alternatives, and its support were to allow themes (), but even PNG images should be properly aligned. Thank you
Change:
} if (process.platform === 'linux') { <del> args.push('--disable-gpu'); // Linux has trouble in VMs to render properly with GPU enabled </del> <ins> // --disable-dev-shm-usage: when run on docker containers where size of /dev/shm // partition < 64MB which causes OOM failure for chromium compositor that uses // this partition for shared memory. // Refs https://github.com/microsoft/vscode/issues/152143 args.push('--disable-dev-shm-usage'); </ins> } if (remote) {

Discussion:
Given crash reports are now enabled in smoke tests, here is a Linux smoke test crash as I had indicated before: This could be an Electron 18 regression? Build:
Another one -
Update on the issue with symbolicating the dump, currently the minidump stacks are corrupted when using the tool. Investigating revealed the symbols generated from the internal build only contain exported symbols because generation happens after stripping the binaries on linux. Currently working on a fix for it.
Symbols are now fixed with , if we can get newer crash dumps with this change, it can help move this issue forward.
The above report was from the build and the original version was from , considering the build environments to be same, here is the symbolicated trace
Crash because the compositor is unable to create shared memory to transfer layout tiles to the gpu, this is usually the case when running under container environment where the default size of is not sufficient. We already disable it for integration and unit tests , not sure why we missed smoke tests. Will send a PR to address it.
Wow
Hm that does not explain the macOS crash though, unfortunately no crash report.
Which CI run has the macOS crash ? Yeah macOS crash would be a different cause if it was present.
nvm I believe you are referring to
Yes,