jiebi/CodeConvo huggingface dataset:
Change:
}); } <del> private mapContributionsToQuickPickEntry(resource: URI, group: IEditorGroup, alwaysUpdateSetting?: boolean) { </del> <ins> private mapContributionsToQuickPickEntry(resource: URI, group: IEditorGroup, showDefaultPicker?: boolean) { </ins> const currentEditor = firstOrDefault(group.findEditors(resource)); // If untitled, we want all contribution points let contributionPoints = resource.scheme === Schemas.untitled ? distinct(flatten(Array.from(this._contributionPoints.values())), (contrib) => contrib.editorInfo.id) : this.findMatchingContributions(resource);

Discussion:
When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a "Configure Default Formatter..." that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc
Change:
}, { // e.g.  * ...| beforeText: /^(t|[ ])*[ ]*([ ]([^*]|*(?!/))*)?$/, <del> oneLineAboveText: /^(s*(/**|*)).*/, </del> <ins> oneLineAboveText: /(?=^(s*(/**|*)).*)(?=(?!(s**/)))/, </ins> action: { indentAction: vscode.IndentAction.None, appendText: '* ' }, }, { // e.g.  */|

Discussion:
VSCode Version: 1.47.0-insider (user setup) Commit: Date: 2020-06-11T13:30:35.121Z (1 day ago) Electron: 7.3.1 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a new TS or JS file a with a generator method that has a leading multiline or JSDoc comment. NOTE: There must be a space between the token and the method name. cursor at the end of the line that starts the generator method body and press enter. Expected: new line is with the correct indentation. Actual: new line is indented to the same level as the method name and an asterisk () is as if this were a line continuation of a multiline or JSDoc comment. ! Notes: This does not occur if the method does not start with a multiline or JSDoc comment. This does not occur if there is no space between the asterisk () and the method name. This does not occur for functions (as there is a leading keyword between the start of the line and the asterisk () This does not occur for generator methods with a leading keyword before the , such as or in JS or , , , , or in TS. Does this issue occur when all extensions are disabled?: Yes
Similar to (the jsdoc comment Is required for this bug)
I am working on this
Change:
if (!crypto.subtle) { // cannot validate, not running in a secure context <del> throw new Error(`Cannot validate in current context!`); </del> <ins> throw new Error(`'crypto.subtle' is not available so webviews will not work. This is likely because the editor is not running in a secure context (https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts).`); </ins> } // Here the `parentOriginHash()` function from `src/vs/workbench/common/webview.ts` is inlined

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.2 OS Version: Steps to Reproduce: have developed an extension, the extension has some webview page, then I install on VSCodeit is ok, the webview is shown; I run it on code-server, my ip is 192.168.88.212, then I input http://127.0.0.1:3000, it is also ok, the webview page is shown; I input 192.168.88.212:3000, the webview page is not shown, and the error is "Can't compute sha-256" you help to fix it ? thank you very much
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thank you for reply very much, I have download the vscode-1.71.2, and then I install and run, the problem still exits, Can you help me?
Do other webviews work, such as the built-in markdown preview or release notes page?
It also not works
I investigated this a determined this is a limitation of how our webviews are implemented. To use them, the editor needs to be running in a This includes but would not include an ip such as . That is why works. This feature would also for other ips if you can use instead of Closing since this is by-designed, although I've a more clear error message in
Change:
icon: Codicon.arrowLeft, menu: { ...accessibleViewMenu, <del> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewSupportsNavigation), </del> <ins> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewContainsCodeBlocks), </ins> }, title: localize('editor.action.accessibleViewPreviousCodeBlock', "Accessible View: Previous Code Block") });

Discussion:
a chat request that produces some code blocks the accessible view in screen reader mode the keyboard shortcuts or left/right arrows in the toolbar to verify that go to next/previous code block actions work sometimes the cursor doesn't move to the code block

several chat requests a chat response screen reader mode, use to open the accessible view the up arrow on the toolbar to go to the previous response see native alert dialog. it should instead be a screen reader aria alert. !

a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !
Change:
return getExtensionApi(onCompletionAccepted.event, pluginManager); }

Discussion:
The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API
fyi
tried to adopt this. When will be available. I can't find it in .
Opened for ESLint
It's in the API since 4 months:
Change:
testObject.$acceptConfigurationChanged(newConfigData, configEventData); }); <ins> test('get return instance of array value', function () { const testObject = createExtHostConfiguration({ 'far': { 'boo': [] } }); const value: string[] = testObject.getConfiguration().get('far.boo', []); value.push('a'); const actual = testObject.getConfiguration().get('far.boo', []); assert.deepStrictEqual(actual, []); }); </ins> function aWorkspaceFolder(uri: URI, index: number, name: string = ''): IWorkspaceFolder { return new WorkspaceFolder({ uri, name, index }); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.1 and 1.72.0-insider OS Version: Windows_NT x64 10.0. Steps to Reproduce: Run the following code from a VSCode extension: The expected behavior would be that the does not contain an entry for "test" since there was no call to . It appears that modifications to the workspaceConfig are stored in memory but are not reflected in The workaround is to use to prevent modification of the This does not repro if the configuration type is a string or an object. For example:
Change:
'workbench.editor.centeredLayoutFixedWidth': { 'type': 'boolean', 'default': false, <del> 'description': localize('centeredLayoutDynamicWidth', "Controls wether the centered layout tries to maintain constant width when the window is resized.") </del> <ins> 'description': localize('centeredLayoutDynamicWidth', "Controls whether the centered layout tries to maintain constant width when the window is resized.") </ins> }, 'workbench.editor.limit.enabled': { 'type': 'boolean',

Discussion:
<img width="425" alt="image" src="https://user-""wether" should be "whether"
Change:
once "^1.3.0" path-is-absolute "^1.0.0" <del> glob@^8.0.3: version "8.0.3" resolved "https://registry.yarnpkg.com/glob/-/glob-8.0.3.tgz#415c6eb2deed9e502c68fa44a272e6da6eeca42e" integrity sha512-ull455NHSHI/Y1FqGaaYFaLGkNMMJbavMrEGFXG/PGrg6y7sutWHUHrz6gy6WEBH6akM1M414dWKCNs+IhKdiQ== dependencies: fs.realpath "^1.0.0" inflight "^1.0.4" inherits "2" minimatch "^5.0.1" once "^1.3.0" </del> global-agent@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/global-agent/-/global-agent-3.0.0.tgz#ae7cd31bd3583b93c5a16437a1afe27cc33a1ab6"

Discussion:
<img width="415" alt="image" src=""Looks localized here though, and hasn't changed in 13 months
language pack looks ok too... Looking into this some more... it seems that the new lines aren't being handled properly.
This still repros :/ is the loc pipeline maybe not running?
it is the newlines... which I thought I fixed... sigh... They are being escaped in the language pack: if I manually delete these extra slashes locally, the problem goes away.
Update... the text has change: Now it's using when it should use and I think I know why. So exporting looks find: is turned in to (we do this manually and it's the XML way to say ) but what we get from the translators... they replace with actual new lines That's not what I was expecting. I would expect them to use the encoded characters but they're not. hacky quick fix that fixes likely most of the scenarios: more accurate longer fix: now that I think about it, this is probably the correct workaround for extensions as well
<img alt="image" src=""Looks like it works now
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { setFullscreen } from 'vs/base/browser/browser'; </del> <ins> import { isSafari, setFullscreen } from 'vs/base/browser/browser'; </ins> import { addDisposableListener, addDisposableThrottledListener, detectFullscreen, EventHelper, EventType, windowOpenNoOpenerWithSuccess, windowOpenNoOpener } from 'vs/base/browser/dom'; import { DomEmitter } from 'vs/base/browser/event'; import { timeout } from 'vs/base/common/async';

Discussion:
In Chrome sometimes opened window is sharing event loop with the original window, in cases like the same origin or the same parent domain. If one tries to debug one of such windows then others are hanging. I was wondering whether it is better to rewrite like that: Updated: i tried with above and it does not help, Chrome blocks new windows besides first by default.
To avoid sharing the same event loop or whatever, I suggest to adopt . But that one does not return true/false if the window opened. I left in this particular place to maintain the existing behavior. I think this returned boolean was as part of the Safari/iPad work.
Yes the returned boolean was as a way for us to know if the window opened successfully. Since Safari sometimes blocks new windows / tabs.
You could invoke different methods based on the browser: the one without a return value in Chrome / the one with a return value in Safari.
this makes sense we are open to a PR which implements this as suggested.
Change:
} async handle({ request, host }: { request: string, host: string }): Promise<string> { <ins> const config = workspace.getConfiguration('git', null); const enabled = config.get<boolean>('enabled'); if (!enabled) { return ''; } </ins> const uri = Uri.parse(host); const authority = uri.authority.replace(/^.*@/, ''); const password = /password/i.test(request);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.0 OS Version: Ubuntu 19.10 Steps to Reproduce: add: { "git.enabled": false, "git.terminalAuthentication": false, "git.githubAuthentication": false, } to push from the integrated terminal <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Error text: Missing or invalid credentials. Error: connect ENOENT at PipeConnectWrap.afterConnect [as oncomplete] () { errno: 'ENOENT', code: 'ENOENT', syscall: 'connect', address: '' }
Did you restart the terminal after your disabled it?
Yes, I've both killed the terminal and restarted the VM. Not sure if this is helpful, but before I the two new settings vscode was trying to handle the authentication even though I had set (requesting username and password from the command palette). That's what sent me looking for the new settings in the first place.
Change:
model ); <del> if (/^[01]/.test(info.version)) { const update = localize('updateGit', "Update Git"); const choice = await window.showWarningMessage(localize('git20', "You seem to have git {0} installed. Code works best with git >= 2", info.version), update); if (choice === update) { commands.executeCommand('vscode.open', Uri.parse('https://git-scm.com/')); </del> <ins> const IgnoreOldGitStorageKey = 'settings.extension.git.ignoreOld'; // Check user setting to show older version message if (!context.globalState.get(IgnoreOldGitStorageKey)) { if (/^[01]/.test(info.version)) { const update = localize('updateGit', "Update Git"); const neverShowAgain = localize('neverShowAgain', "Don't show again"); const choice = await window.showWarningMessage( localize('git20', "You seem to have git {0} installed. Code works best with git >= 2", info.version), update, neverShowAgain ); if (choice === update) { commands.executeCommand('vscode.open', Uri.parse('https://git-scm.com/')); } else if (choice === neverShowAgain) { context.globalState.update(IgnoreOldGitStorageKey, true); } </ins> } } }

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: $ code --version 11.1 OS Version: Ubuntu 14.04 Steps to Reproduce: vscode annoying warning about git version being 1.9 something appears. It is nice information to have, and its a good warning to show once, or twice, but please don't show it every time I open code. That is very annoying. I don't really care that much if the git features in vscode can work better with 2.x. I do not use these features that much and prefer to use other gui and cli tools anyways. Also, I prefer to stick with the version of git that comes with my Os's package manager by default. You should assume that is just what some people are going to want to do and perpetually pestering them to upgrade git is not very nice. So please, give me an easy and obvious way to dismiss the warning once and for all so it doesn't pop back up the next time I open vscode.
Change:
var ShouldRestartTunnelService: Boolean; <ins> function StopTunnelOtherProcesses(): Boolean; var WaitCounter: Integer; TaskKilled: Integer; begin Log('Stopping all tunnel services (at ' + ExpandConstant('"{app}bin{#TunnelApplicationName}.exe"') + ')'); ShellExec('', 'powershell.exe', '-Command "Get-WmiObject Win32_Process | Where-Object { $_.ExecutablePath -eq ' + ExpandConstant('''{app}bin{#TunnelApplicationName}.exe''') + ' } | Select @{Name=''Id''; Expression={$_.ProcessId}} | Stop-Process -Force"', '', SW_HIDE, ewWaitUntilTerminated, TaskKilled) WaitCounter := 10; while (WaitCounter > 0) and CheckForMutexes('{#TunnelMutex}') do begin Log('Tunnel process is is still running, waiting'); Sleep(500); WaitCounter := WaitCounter - 1 end; if CheckForMutexes('{#TunnelMutex}') then begin Log('Unable to stop tunnel processes'); Result := False; end else Result := True; end; </ins> procedure StopTunnelServiceIfNeeded(); var StopServiceResultCode: Integer;

Discussion:
Running can block the VS Code update on Windows as it prevents deleting the parent folder. The updater needs a way to terminate it, and a mutex to know that it needs to be terminated.
Change:
const { hasFileIcons } = this._themeService.getFileIconTheme(); const showSymbols = this._configurationService.getValue<boolean>(NotebookSetting.gotoSymbolsAllSymbols); <ins> const isSymbol = (element: OutlineEntry) => !!element.symbolKind; const isCodeCell = (element: OutlineEntry) => (element.cell.cellKind === CellKind.Code && element.level === NotebookOutlineConstants.NonHeaderOutlineLevel); // code cell entries are exactly level 7 by this constant </ins> for (let i = 0; i < bucket.length; i++) { const element = bucket[i]; <del> const nextElement = bucket[i + 1]; // this logic controls the following for code cells entries in quick pick: if (element.cell.cellKind === CellKind.Code) { // if we are showing all symbols, and // 		- the next entry is a symbol, we DO NOT include the code cell entry (ie continue) //		- the next entry is not a symbol, we DO include the code cell entry (ie push as normal in the loop) if (showSymbols && element.level === NotebookOutlineConstants.NonHeaderOutlineLevel && (nextElement?.level > NotebookOutlineConstants.NonHeaderOutlineLevel)) { continue; } // if we are not showing all symbols, skip all entries with level > NonHeaderOutlineLevel (ie 8+) else if (!showSymbols && element.level > NotebookOutlineConstants.NonHeaderOutlineLevel) { continue; } </del> <ins> const nextElement = bucket[i + 1]; // can be undefined if (!showSymbols && isSymbol(element)) { continue; } if (showSymbols && isCodeCell(element) && nextElement && isSymbol(nextElement)) { continue; </ins> } const useFileIcon = hasFileIcons && !element.symbolKind;

Discussion:
Open notebook with a header, code cell, and symbols in the code cell: # 1: symbols appear as a child of the header md cell, and the code cell is not present in the outline. # 2: changing the filter settings to remove code cells or symbols does not recompute the outline. Fixes: For # 1: an outline provider was being created with the incorrect target (sticky scroll was created with a QuickPick target), and this was being retrieved for the outline pane incorrectly. For # 2: one of the locations an outline change event is fired was shifted and subsequently removed, meaning that the outline did not recompute to reflect the filtered-out cells.
Change:
const _defaultOnError = (err) => console.log(JSON.stringify(err, null, 4)); function create(projectPath, existingOptions, config, onError = _defaultOnError) { function printDiagnostic(diag) { <del> if (!diag.file || !diag.start) { </del> <ins> if (diag instanceof Error) { onError(diag.message); } else if (!diag.file || !diag.start) { </ins> onError(ts.flattenDiagnosticMessageText(diag.messageText, 'n')); } else {

Discussion:
In this build output, there's some error in SWC, but it's not emitted I'm guessing_ it's because I use the operation and they don't support that yet, or our version of TS doesn't.
Please don't use for the time being
will also update to latest SWC so that satisfies is supported
This will now print SWC errors as they are <img width="687" alt="Screenshot 2023-02-02 at 11 59 36" src="https://user-"
Change:
"tas-client-umd": "0.1.8", "vscode-oniguruma": "1.7.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.3.0-beta.73", "xterm-addon-canvas": "0.5.0-beta.34", </del> <ins> "xterm": "5.4.0-beta.17", "xterm-addon-canvas": "0.6.0-beta.16", </ins> "xterm-addon-image": "0.6.0-beta.21", <del> "xterm-addon-search": "0.13.0-beta.27", "xterm-addon-unicode11": "0.6.0-beta.19", "xterm-addon-webgl": "0.16.0-beta.37" </del> <ins> "xterm-addon-search": "0.14.0-beta.15", "xterm-addon-unicode11": "0.7.0-beta.15", "xterm-addon-webgl": "0.17.0-beta.15" </ins> } }

Discussion:
Upstream: To verify: linux/macOS/wsl various values of (eg. 1, 4.5, 10) first with no selection and second with a selection. You may need to change your theme to see the differences

Upstream: Repro: Linux/macOS/WSL , it should not show invisible in the output

noticed by
Verify that when you have a screen reader on, you hear the output of a command upon pressing enter
Reproduces in the demo. Does not reproduce in stable VS Code
upstream issue:
With a screen reader enabled, run a command that yields short output, such as . Verify that the screen reader reads the output.
Change:
"browser": "./dist/browser/cssServerMain", "dependencies": { "@vscode/l10n": "^0.0.11", <del> "vscode-css-languageservice": "^6.2.2", </del> <ins> "vscode-css-languageservice": "^6.2.3", </ins> "vscode-languageserver": "^8.1.0-next.6", "vscode-uri": "^3.0.7" },

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: Windows 10 Steps to Reproduce: a CSS file suggestion is shown, but is not enough. ! There should be more keywords below: - () () (safe <content-position, like ) (unsafe <content-position, like ) See: Same issue happens for and Thank you.
Tested in but not seeing the suggestions !