jiebi/CodeConvo huggingface dataset:
Change:
} } // encode the rest of the path <del> res += encoder(path, true); </del> <ins> res += encoder(path, true, false); </ins> } if (query) { res += '?'; <del> res += encoder(query, false); </del> <ins> res += encoder(query, false, false); </ins> } if (fragment) { res += '#'; <del> res += !skipEncoding ? encodeURIComponentFast(fragment, false) : fragment; </del> <ins> res += !skipEncoding ? encodeURIComponentFast(fragment, false, false) : fragment; </ins> } return res; }

Discussion:
wrongly encode IPv6 literals ( This is an issue with but if I understand correctly issues should be reported here ) can parse IPv6 literal address fine (examples are using node REPL) but will encode the : This string representation of the URI cannot be used for example by a web browser. This encoding seems to happen here <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: main ( ) OS Version: linux Steps to Reproduce: actual: expected:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Looks similar to:
Change:
// https://github.com/microsoft/vscode/issues/149271 // ❗️ Important: The main NotebookEditor api has been finalized. <del> // This file only contains deprecated properties/functions from the proposal. export interface NotebookEditor { /** * The document associated with this notebook editor. * * @deprecated Use {@linkcode NotebookEditor.notebook} instead. */ readonly document: NotebookDocument; } export namespace window { /** * A short-hand for `openNotebookDocument(uri).then(document => showNotebookDocument(document, options))`. * * @deprecated Will not be finalized. * * @see {@link workspace.openNotebookDocument} * * @param uri The resource to open. * @param options {@link NotebookDocumentShowOptions Editor options} to configure the behavior of showing the {@link NotebookEditor notebook editor}. * * @return A promise that resolves to an {@link NotebookEditor notebook editor}. */ export function showNotebookDocument(uri: Uri, options?: NotebookDocumentShowOptions): Thenable<NotebookEditor>; } </del> <ins> // This file only tracks the `notebook/cell/executePrimary` contribution, which will be removed </ins> }

Discussion:
The has been finalized with VS Code 1.68 (). If your extension was using the proposal, you should now switch to the finalized version of this API. In the majority of cases, this switch is as simple as: your extension to target VS Code in the new from your list of enabled API proposal. However there are few small bumps to be aware of: has been renamed . Please make sure to switch over to the new property name as part of this migrationWe did not finalize the version of that takes a uri. Instead you can use Here's a list of all current consumers of the old API proposal: [x] ms-vsliveshare.vsliveshare — [X] ms- — [x] Dot net interactive — [x] GitHub.codespaces — [x] ms- — If you own one of these extensions, please migrate to the finalized notebook editor API. Let me know once the new version of your extension is published and I will remove your extension from the list of api consumers
I am actually fine in ESLint. The dependency was because of notebook support in LSP and LSP already converted to the final version for the 8.x release of the LSP libs.
Thank you everyone who's checked off their extension so far! If you have, I plan to remove your extension from the list of API consumers in July. This will only start effecting the insiders builds of VS Code at first, but please let me know if you notice any issues
I'm working on the change for Codespaces and expect it to be in our next extension release (1.10.0) in a few days. I'll reply back once it's on the marketplace.
We just published GitHub Codespaces 1.10.0 with this change, so you should be able to remove our extension from the list of proposed API consumers.
Change:
} } <del> registerWorkbenchContribution2(NotebookIndentationStatus.ID, NotebookIndentationStatus, WorkbenchPhase.AfterRestored); // TODO@Yoyokrazy -- unsure on the phase </del> <ins> export class NotebookEditorStatusContribution extends Disposable implements IWorkbenchContribution { static readonly ID = 'notebook.contrib.editorStatus'; constructor( @IInstantiationService instantiationService: IInstantiationService, @IEditorGroupsService editorGroupService: IEditorGroupsService, @IEditorService editorService: IEditorService ) { super(); // Main Editor Status const mainInstantiationService = instantiationService.createChild(new ServiceCollection( [IEditorService, editorService.createScoped('main', this._store)] )); this._register(mainInstantiationService.createInstance(KernelStatus)); this._register(mainInstantiationService.createInstance(ActiveCellStatus)); this._register(mainInstantiationService.createInstance(NotebookIndentationStatus)); // Auxiliary Editor Status this._register(editorGroupService.onDidCreateAuxiliaryEditorPart(({ part, instantiationService, disposables }) => { disposables.add(instantiationService.createInstance(KernelStatus)); disposables.add(instantiationService.createInstance(ActiveCellStatus)); disposables.add(instantiationService.createInstance(NotebookIndentationStatus)); })); } } registerWorkbenchContribution2(NotebookEditorStatusContribution.ID, NotebookEditorStatusContribution, WorkbenchPhase.AfterRestored); </ins>

Discussion:
This is a missing adoption when notebooks became floating window capable. Notice how the status bar entry appears in the main window and not the floating window: ! We have had a similar issue with the text editor status bar and solved it by instantiating it per-window: I think a similar approach would work for notebooks too. The key for this to work is that you get a scoped in the that allows you to listen only to editor change events in the respective window. Consequently, you use a main-window scoped editor service for the main-window status bar: Let me know if you have questions, but I think its easy to copy what we do for editor status here.
When I reload the window with a floating notebook, the status bar does not appear (macOS): !
This is my attempt to fix this issue The problem here is if we register the contrib , we won't get the event. The event is the only place where we get the window's unique instantiationService (which gives us the right statusbarservice). Without the right statusbarservice, we can't register notebook status bar items to the right place.
Not very happy about that, filed
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
}, JSON.stringify); public isAlertEnabled(cue: AudioCue, userGesture?: boolean): boolean { <ins> if (!cue.alertSettingsKey) { return false; } </ins> return this.isAlertEnabledCache.get({ cue, userGesture }).get() ?? false; }

Discussion:
When using the command, Roberto did not know there was a configure action available. He said: It works, but in all my time using the editor, it never occurred to me to try using the tab key in that list. I always assumed it was read only. Originally posted by in
also this discoverability issue. Additionally, he found that has to be pressed twice to reach the settings gear when running .
He suggested we use checkboxes instead and combine with .
Need to assess which other actions we need to fix
I think it is possible using the quick pick api to render checkboxes for this. Let me un-assign Tyler and in case you need help with the API feel free to reach out to me and we can find the right usage.
Change:
dependencies: is-number "^7.0.0" <del> vscode-css-languageservice@^4.1.0: version "4.1.0" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-4.1.0.tgz#144c8274e0bf1719fa6f773ca684bd1c7ffd634f" integrity sha512-iTX3dTp0Y0RFWhIux5jasI8r9swdiWVB1Z3OrZ10iDHxzkETjVPxAQ5BEQU4ag0Awc8TTg1C7sJriHQY2LO14g== </del> <ins> vscode-css-languageservice@^4.1.1: version "4.1.1" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-4.1.1.tgz#9131dd465e4b20f3ba78ab9734b2c7cdb9237443" integrity sha512-2r2bYbhscivRu1zqh5kNe8aYpFnfksMYC7wTpKX2HqFsSzSJYXk0sCqPaWsP5ptqz0OFBTXnzx2JlE+Nb5Edgw== </ins> dependencies: vscode-languageserver-textdocument "^1.0.1" vscode-languageserver-types "^3.15.1"

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.43.0 OS Version: macOS 10.15.3 Steps to Reproduce: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Same issue after updating to 1.43.0
I experience the same issue in: Version: 1.44.0-insider Commit: Date: 2020-03-11T09:19:54.444Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Linux x64 5.3.0-40-generic !
Does this have anything to do with the recent change in less?
caused by
PR created, to review (and merge, if ok)
To verify open a 'less' file with content and check that there's a color decorator
Change:
DOM.hide(this.editorPart); this.markdownAccessibilityContainer.ariaHidden = 'true'; <del> this.templateData.container.classList.toggle('collapsed', true); </del> this.viewCell.renderedMarkdownHeight = 0; this.viewCell.layoutChange({}); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59-Insider OS Version: Windows 10 Steps to Reproduce: a notebook a cell cells are rotated 270 degrees. Seems to be because we use the 'collapsed' classname for cell collapse, and loads a stylesheet which applies to the classname. This stylesheet is not loaded in desktop VS Code so the problem seems to only impact Codespaces This is particularly unfortunate for the interactive window because all code cell inputs are collapsed by default, but it also impacts any collapsed cell in native notebooks all up. !
I filed this a long time ago, but this is pretty bad, I will just change the styles to work around it in the meantime
fix proposal from
Change:
} #scroll-to-top:hover { <del> background-color:#007acc; </del> <ins> background-color:var(--vscode-button-hoverBackground); </ins> box-shadow: 2px 2px 2px rgba(0,0,0,.25); }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello Guys, Add a new Feature in the theme to Change the Color of the Scroll to Top while reading any Extension's Readme. Because Default Blue Color Does not match some Theme's. <br<brExample:- "extensionButton.scrolltotop": "#"; !<br<br
We don't need a new theme key specifically for this. Instead it should use one of the existing ones, likely the ones for buttons
hello! Can I work on this issue? Maybe we can using existing one , or create new color setting for these buttons.
Change:
} } <ins> private rangeContainsOnlyWhitespaceCharacters(model: ITextModel, range: Range): boolean { const lineContainsOnlyWhitespace = (content: string): boolean => { return content.trim().length === 0; }; let containsOnlyWhitespace: boolean = true; if (range.startLineNumber === range.endLineNumber) { const lineContent = model.getLineContent(range.startLineNumber); const linePart = lineContent.substring(range.startColumn - 1, range.endColumn - 1); containsOnlyWhitespace = lineContainsOnlyWhitespace(linePart); } else { for (let i = range.startLineNumber; i <= range.endLineNumber; i++) { const lineContent = model.getLineContent(i); if (i === range.startLineNumber) { const linePart = lineContent.substring(range.startColumn - 1); containsOnlyWhitespace = lineContainsOnlyWhitespace(linePart); } else if (i === range.endLineNumber) { const linePart = lineContent.substring(0, range.endColumn - 1); containsOnlyWhitespace = lineContainsOnlyWhitespace(linePart); } else { containsOnlyWhitespace = model.getLineFirstNonWhitespaceColumn(i) === 0; } if (!containsOnlyWhitespace) { break; } } } return containsOnlyWhitespace; } </ins> private shouldIgnoreLine(model: ITextModel, lineNumber: number): boolean { model.tokenization.forceTokenization(lineNumber); const nonWhitespaceColumn = model.getLineFirstNonWhitespaceColumn(lineNumber);

Discussion:
create a TS file make sure the file is configured to insert Tabs (from the status bar) place a character in your clipboard paste it at the beginning of the file :bug: observe nothing happens
This seems related to Auto indent. Setting fixes the issue
After investigating, this seems to happen because after pasting a new line character, the code becomes as follows: The method of the is called and it performs automatic re-indentation. In your case, since there is nothing above that line, the indentation level on that line is zero. The inserted indentation is then removed. It is possible to see this in more detail in the following example: I believe this behavior makes sense when the pasted text contains characters other than whitespace characters. Perhaps what I could do is to not trigger the re-indentation when only whitespace characters are pasted. This could be considered then as intended indentation adjustment.
Change:
const filter: IFilter = { name: languageName, extensions: distinct(extensions).slice(0, 10).map(e => trim(e, '.')) }; <del> if (!matchingFilter && extensions.includes(ext || PLAINTEXT_EXTENSION /* https://github.com/microsoft/vscode/issues/115860 */)) { </del> <ins> // https://github.com/microsoft/vscode/issues/115860 const extOrPlaintext = ext || PLAINTEXT_EXTENSION; if (!matchingFilter && extensions.includes(extOrPlaintext)) { </ins> matchingFilter = filter; <del> const trimmedExt = trim(ext || PLAINTEXT_EXTENSION, '.'); </del> <ins> // The selected extension must be in the set of extensions that are in the filter list that is sent to the save dialog. // If it isn't, add it manually. https://github.com/microsoft/vscode/issues/147657 const trimmedExt = trim(extOrPlaintext, '.'); </ins> if (!filter.extensions.includes(trimmedExt)) { <del> filter.extensions.push(trimmedExt); </del> <ins> filter.extensions.unshift(trimmedExt); </ins> } return null; // first matching filter will be added to the top

Discussion:
the change deserves a small comment with a ref to the issue as to why we add the extension of the file should the extension be the first in the list so that it appears first?
Change:
})), token); const edits = coalesce(results ?? []); <del> sortEditsByYieldTo(edits); return edits; </del> <ins> return sortEditsByYieldTo(edits); </ins> } private async applyDefaultPasteHandler(dataTransfer: VSDataTransfer, metadata: CopyMetadata | undefined, token: CancellationToken) {

Discussion:
Type: <bBug</bWhen I'm copying and pasting text from Onenote into VS Code editor it comes up like this . How do I correct this VS Code version: Code 1.82.0 (, 2023-09-06T22:07:07.438Z) OS version: Windows_NT x64 10.0. Modes: <details<summaryExtensions (59)</summaryExtensionVersion ------ better-comments3.0.2 aws-toolkit-vscode1.89.0 LinkCheckMD0.3.1 excel-to-markdown-table1.3.0 vscode-markdownlint0.51.0 docs-article-templates1.0.3 docs-authoring-pack1.0.0 docs-build0.4.1 docs-images1.0.1 docs-linting0.0.13 docs-markdown1.0.2 docs-metadata1.0.9 docs-preview1.0.3 docs-scaffolding1.0.0 docs-yaml1.0.1 gitlens14.3.0 pythonsnippets1.0.2 codespaces1.15.1 remotehub0.60.0 vscode-github-actions0.26.2 vscode-pull-request-github0.72.0 go0.39.1 terraform2.27.2 vsc-python-indent1.18.0 vscode-docker1.26.0 vscode-kubernetes-tools1.3.13 data-workspace-vscode0.5.0 mssql1.20.1 sql-bindings-vscode0.4.0 sql-database-projects-vscode1.2.0 isort2023.10.1 python2023.16.0 vscode-pylance2023.9.10 jupyter2023.8.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.309.0 remote-ssh0.106.3 remote-ssh-edit0.86.0 remote-wsl0.81.3 vscode-remote-extensionpack0.24.0 powershell2023.6.0 remote-explorer0.4.1 remote-repositories0.38.1 remote-server1.4.3 vscode-markdown-notebook0.0.26 vsliveshare1.0.5883 vsliveshare-pack0.4.0 vscode-sanddance4.1.0 autodocstring0.6.1 vscode-yaml1.14.0 vscode-taskexplorer2.13.2 code-spell-checker3.0.1 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscodeintellicode-completions1.0.22 vscode-icons12.5.0 (7 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can i work on this issue?
Change:
} const extensionId = extension.identifier.id; <ins> // prevent race between extension update handler and this (onConfigUpdate) handler await this.refreshInstalledExtensionsList(); </ins> const extensionInstalled = this.installedExtensionIds.includes(extensionId); // Drill down to see whether the group and setting already exist

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: Linux x64 6.6.26-1-MANJARO Steps to Reproduce: VS Code. Developer Tools and watch Network requests. VS Code, open Settings. that Settings will not display any settings until the requests to are completed. reading the results of the queries, observe that this request is related to the absolutely despicable advertisement for GitHub Copilot_, to detect if it's already installed (or something) in order to show the ad in the Settings UI and that you are now even more incensed that something which should work immediately was taking 7 seconds or longer due to the fact that we are now living through a dystopia. Then quickly get over it and start considering a move to a different editor or a fork. Please choose one of the following suggestions: remove the GitHub Copilot advertisement from the Settings UI. waiting for network requests in order to show the Settings UI. this issue and ignore this unquestionably sane plea to help battle the enfecalization of this beloved product.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
The AUR hasn't been updated with 1.89.1 yet but looking at the resolved issues I don't see any related to this.
I have a 1-second timeout per network request. In other words, the delays should now have an upper limit on their duration.
Change:
} private async _runTaskCommand(filter?: string | ITaskIdentifier): Promise<void> { <ins> if (!this._tasksReconnected) { return; } </ins> if (!filter) { return this._doRunTaskCommand(); }

Discussion:
Testing default build task in VS Code repo running (I also installed the Java extension pack like in ) window Ctrl+Shift+B a few times :bug: get two sets of default build tasks. They are both reconnected, if I edit a file and hit save, both sets of tasks display log updates !
Duplicate
Change:
let config = this.configurationService.getConfiguration(); let newValue = new Function('_', 'try {return _.' + name + ';} catch (ex) { return "";}')(config); if (Types.isString(newValue)) { <del> return newValue; } else { </del> <ins> // Prevent infinite recursion and also support nested references (or tokens) return newValue === originalValue ? '' : this.resolveString(newValue); } else { </ins> return this.resolve(newValue) + ''; } });

Discussion:
VSCode Version:1.4 OS Version:OS X Steps to Reproduce: a simple python file with the following code a virtual environment under "p27" subdirectory of the workspace root. the path to python interpreter as follows the path to the pythonPath in is configured as follows the file created in step 2. Error displayed: Problem: The token ${workspaceRoot} has not been resolved to the workspace root path. The bug is in . The value returned contains the tokens ${workspaceRoot} that needs to be resolved.