jiebi/CodeConvo huggingface dataset:
Change:
nls.localize('workbench.editor.pinnedTabSizing.compact', "A pinned tab will show in a compact form with only icon or first letter of the editor name."), nls.localize('workbench.editor.pinnedTabSizing.shrink', "A pinned tab shrinks to a compact fixed size showing parts of the editor name.") ], <del> 'markdownDescription': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'pinnedTabSizing' }, "Controls the sizing of pinned editor tabs. Pinned tabs are sorted to the begining of all opened tabs and typically do not close until unpinned. This value is ignored when `#workbench.editor.showTabs#` is `false`.") </del> <ins> 'markdownDescription': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'pinnedTabSizing' }, "Controls the sizing of pinned editor tabs. Pinned tabs are sorted to the beginning of all opened tabs and typically do not close until unpinned. This value is ignored when `#workbench.editor.showTabs#` is `false`.") </ins> }, 'workbench.editor.splitSizing': { 'type': 'string',

Discussion:
nls.localize() generally involves human visible output. Technically there are 2-3 arguments and the main human facing one is the second. The first argument is often treated as an "opaque" string, but in most systems, it's used to communicate to localizers, so, to some extent, there is value in not having misspellings there either. I can split out the identifiers if requested... Does this issue occur when all extensions are disabled?: Yes
can you provide me with more details about this. We use Transifex to translate our strings and the system contains both the value and the key.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
default: throw new FileSystemError(err.message, err.name as files.FileSystemProviderErrorCode); } } <ins> /* internal */ _registerScheme(scheme: string, options: { readonly isReadonly?: boolean }): IDisposable { this._schemes.set(scheme, options); return toDisposable(() => { return this._schemes.delete(scheme); }); } </ins> } export interface IExtHostConsumerFileSystem extends ExtHostConsumerFileSystem { }

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
value?: string; /** <ins> * whether to automatically select the first value set */ noValuePreselect?: boolean; /** </ins> * the text to display underneath the input box */ prompt?: string;

Discussion:
VSCode Version: 1.5.0-insider OS Version: Windows 10 Steps to Reproduce: value is highlighted/selected Currently we can't put the cursor at the end of the default value when running . In this case, users have to move the cursor manually if we want to keep the default value as prefix always.
That's actually indented use case since the user is likely to accept <kbdEnter</kbdor over write the pre-set value. What is your use-case for this?
This features originally comes from implementing Vim's Ex commands, which support line range as a prefix like represents and represents . When users trigger Ex command by , Vim will help fulfill the line range prefix automatically and then users can type commands directly, eg for replacement. If users don't like the line range Vim puts there automatically, they need to use to delete the range characters. Vim doesn't select those characters it auto-completes but Code does, so I'm asking if it's possible to add this support to .
It would also help if a selection range could be defined. In my case I would like set the whole file path as value but only select the file base name. e.g. /path/to/file/ Users most likely will only change the but should also have the possibility to change the path.
Concurring to what said. I have an open question on Stack overflow:
+1 to this, it is very counterintuitive to do visual block find/replaces with VSCodeVim as noted in the above mentioned issues with this default behavior. If it were configurable like makes it, that would be useful for better emulating vim-style editing for VSCodeVim users like myself!
Change:
import 'vs/css!./media/quickInput'; import { localize } from 'vs/nls'; import { IQuickInputOptions } from 'vs/platform/quickinput/browser/quickInput'; <del> import { getIconClass } from 'vs/platform/quickinput/browser/quickInputUtils'; </del> <ins> import { quickInputButtonToAction } from 'vs/platform/quickinput/browser/quickInputUtils'; </ins> import { IQuickPickItem, IQuickPickItemButtonEvent, IQuickPickSeparator, IQuickPickSeparatorButtonEvent, QuickPickItem } from 'vs/platform/quickinput/common/quickInput'; import { Lazy } from 'vs/base/common/lazy'; import { URI } from 'vs/base/common/uri';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Ubuntu 23.04 Steps to Reproduce: the command palette using ctrl+shift+p (or cmd+shift+p on mac) the escape key, closing the command palette 7 times that instance count has increased by 7, instance count has increased by 211, instance count has increased by 240 and instance count has increased by 302. The total disposable count has increased by 1137 from to . One class that has increased the most in the above test was . Looking where relates to the quick input I found this code in where actions are created: Perhaps it could be this code that causes the to be created. It seems the actions aren't registered/disposed like other disposables.
Thanks for reporting this! I think I've cleaned up the ... now we use the simpler non-disposable kind... I'll chip away at the rest over time.
Thanks a lot, I see now: No more Actions are leaked (211 -0) Disposable stores are 211 less leaked (240 -29) Emitter are 211 less leaked (302 -91) MutableDisposable instance count still increases (7 -7) I'll try to find more information for the MutableDisposables and DisposableStores where exactly they are created! Thanks again! Edit: The MutableDisposables are created in : They are kept alive by a 200ms timeout and disposed after 200ms so it's no problem: Just the test executing too fast / finishing before the MutableDisposables were disposed. :)
Change:
assert(isMultilineRegexSource('foorn')); assert(isMultilineRegexSource('n')); assert(isMultilineRegexSource('fooW')); <ins> assert(isMultilineRegexSource('foon')); assert(isMultilineRegexSource('foorn')); </ins> }); test('issue #74715. d* finds empty string and stops searching.', () => {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.0-insider (, 2022-07-11T12:20:21.684Z) OS Version: Windows_NT x64 10.0. Suppose we have this text: It can't be matched with original text using regex:  But if we join the first line and second line with a , it can be matched: 
For some background info, see and
Change:
output, __separator__(), fullscreen, <del> platform.isWindows ? toggleMenuBar : void 0, </del> <ins> platform.isWindows || platform.isLinux ? toggleMenuBar : void 0, </ins> __separator__(), splitEditor, toggleSidebar,

Discussion:
Issue was closed with commit . The commit the requested option to add an option for toggling visibility of the main menu, but restricted it to be shown only when running the Windows version. I can see why toggling the menu bar probably would either not work or just not make sense on OS X. Users running Linux window managers that have a menu bar per window would benefit from the setting as much as users of the Windows version though.
Change:
const currLineEmptyOrIndented = isLineEmptyOrIndented(lineNumber); const notEmpty = !nextLineEmptyOrIndented && !prevLineEmptyOrIndented; <del> const currLineDecorations = this._editor.getLineDecorations(lineNumber); const hasDecoration = !!(currLineDecorations?.length); </del> // check above and below. if both are blocked, display lightbulb in the gutter. if (!nextLineEmptyOrIndented && !prevLineEmptyOrIndented && !hasDecoration) {

Discussion:
This was unexpected for me where I open a file (not focus the editor) and the light bulb shows up randomly depending on where the cursor happened to have been restored: !
cc
Change:
return this.userDataProfilesMainService.createTransientProfile(); } <del> return this.userDataProfilesMainService.getProfileForWorkspace(workspace) ?? this.userDataProfilesMainService.defaultProfile; </del> <ins> return this.userDataProfilesMainService.getProfileForWorkspace(workspace) ?? defaultProfile; </ins> } private onWindowClosed(window: ICodeWindow): void {

Discussion:
I know I suggested but after trying it out I am convinced that was a wrong suggestion. I think we should just revert it, and whenever we open a new folder it should be using the CURRENT profile. I know and feel the same.
Lets discuss this!
Actually I liked this behaviour too. Reverted this after our discussion. Bringing this back again :)
Awesome - thanks!
Is it possible to associate a workspace (or folder) with a profile? E.g. can I set that if I open a workspace (or folder) "A", current profile will be switched to "Default" and if I open a workspace "B", current profile will be switched to "Work"?
Well, it seems to be already working:
Change:
export class ChatRequestNotebookData { //TODO@API should be the editor <del> notebook: NotebookDocument; </del> <ins> readonly cell: TextDocument; </ins> <del> constructor(notebook: NotebookDocument); </del> <ins> constructor(cell: TextDocument); </ins> } export interface ChatRequest {

Discussion:
Today inline chat for editors and notebooks rely on implicit variables, e.g . This isn't proper and we should have real API, e.g some extra property on that encapsulates data about the chat location.
Done, no more implicit variables
Change:
export interface IValueWithChangeEvent<T> { readonly onDidChange: Event<void>; <del> readonly value: T; </del> <ins> get value(): T; </ins> } export class ValueWithChangeEvent<T> implements IValueWithChangeEvent<T> {

Discussion:
a screen reader the command. are always read as "unchecked"
bisected this to can you take a look?
Oops, next time we meet I owe you a drink! ;)
Change:
// Update workspace trust this._trustState.isTrusted = trusted; <ins> // Reset acceptsOutOfWorkspaceFiles if (!trusted) { this._trustState.acceptsOutOfWorkspaceFiles = false; } </ins> // Run workspace trust transition participants await this._trustTransitionManager.participate(trusted);

Discussion:
Steps to Reproduce: Workspace and trust it code-insiders from a folder that is not trusted. -Shows the dialog code-insiders from a folder that is not trusted. -No warning dialog the window code-insiders from a folder that is not trusted. Expected: No warning dialog should be shown Actual: A warning dialog is being shown
Pushed a fix for this to main. Fix is low risk so we can take it as a candidate.
Change:
// count for max if (this._options?.overflowBehavior !== undefined) { <del> const exemptedIds = intersection(new Set(this._options.overflowBehavior.exempted), Iterable.map(primary, a => a.id)); </del> <ins> const exemptedIds = intersection(new Set(this._options.overflowBehavior.exempted), Iterable.map(primary, a => a?.id)); </ins> const maxItems = this._options.overflowBehavior.maxItems - exemptedIds.size; let count = 0;

Discussion:
open a file from a pull request get an error saying id cannot be read from undefined
this is a regression from
Yes, I too saw this when testing day before yesterday, but as soon as I updated this went away.
Change:
private placeholderTextContainer: HTMLElement; private inputEditor: CodeEditorWidget; private toolbarContainer: HTMLElement; <ins> private toolbarContextKeyService: IContextKeyService; </ins> private actionBar: ActionBar; private readonly disposables = new DisposableStore();

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!
Change:
// Description data.description.set(entry.getDescription(), descriptionHighlights || []); <ins> data.description.element.title = entry.getDescription(); </ins> } }

Discussion:
VSCode Version: 1.0.0-alpha OS Version: Windows10 Mouse hove on the truncated path in the command pallete is not displaying full path. User can't dynamically change the command pallete window size so it is hard to identify file path for manual verification. !
Change:
variables?: { [key: string]: string }; when?: string; deprecated?: string; <del> uiMessages?: { [key in DebuggerUiMessage]: string }; </del> <ins> strings?: { [key in DebuggerString]: string }; </ins> } export interface IBreakpointContribution {

Discussion:
Continuing This is just a flag in Example: In this case, vscode is in control of when and where to show this message.
Is a good name? Drop the ?
If I see some "messages" related to a debugger, I first think of something like DAP messages. I would only use this property to drive some feature in the UI and it feels good to tie it to that. But if feels awkward I don't have a strong opinion.
Change:
return new Position(lineNumber, column); } <del> if (strings.isLowerAsciiLetter(left) && strings.isUpperAsciiLetter(right)) { </del> <ins> if ((strings.isLowerAsciiLetter(left) || strings.isAsciiDigit(left)) && strings.isUpperAsciiLetter(right)) { </ins> // camelCaseVariables return new Position(lineNumber, column); }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 OS Version: Windows/Linux Steps to Reproduce: there is a keybinding to . a camel case word with a number immediately preceding an upper case character and leave the cursor at the end of the word, e.g. "foo1Bar|". via keybinding in (1). the cursor to end up before the upper case character (i.e. ), but cursor is observed to be at the beginning of the camel case word (i.e. ).
Will like to request for a review on the issue/MR please. /cc
Still an issue in version 1.67.1. Linked MR is ready for review.
Similar issues: ("Feature 1")
Change:
} appendChoice(values: string[], number: number = this._tabstop++): SnippetString { <del> const value = values.map(s => s.replace(/$|}||,/g, '$&')).join(','); </del> <ins> const value = values.map(s => s.replaceAll(/[|,]/g, '$&')).join(','); </ins> this.value += '${'; this.value += number;

Discussion:
This code inserts a snippet with some dollars but no backslashes: But it shows up with backslashes: !
Change:
getId() { return 'html'; }, <ins> doSelection(document: TextDocument, position: Position): Range[] { return htmlLanguageService.getSelectionRanges(document, position); }, </ins> doComplete(document: TextDocument, position: Position, settings = workspace.settings) { let options = settings && settings.html && settings.html.suggest; let doAutoComplete = settings && settings.html && settings.html.autoClosingTags;

Discussion:
Semantic selections: LSP: works CSS/SCSS/LESS: doesn't work, but it works in Atom. Probably need to update our dependencies. The plan now is to use emmet's "balance" commands. The challenge is that HTML/CSS language service need to include emmet. Alternatively, we can implement these commands ourselves.
Please review the animated gifs in the original thread: Seems to me the emmet functionality as it stands is wholly inadequate.
This will be available in tomorrow's insiders: !
is this suppose to work in Javascript? It's not nearly as functional as Webstorm. Also fails dramatically with HTML in .Vue files. Oh well.
Vue — it'll be available once we update the dependencies. JavaScript — we'll need to wait for TypeScript to add the semantic selection. I don't have any estimate.
Change:
private readonly saveSequentializer = new TaskSequentializer(); <ins> private ignoreSaveFromSaveParticipants = false; </ins> async save(options: IStoredFileWorkingCopySaveOptions = Object.create(null)): Promise<boolean> { if (!this.isResolved()) { return false;

Discussion:
This is a follow-up from and describes the problem that save participants causing a save operation
reproduced when undoing some fixes (applying the fix below)
fyi
Change:
display: flex; align-items: center; justify-content: center; <ins> background-color: unset; </ins> } .monaco-workbench .search-view .search-widget .toggle-replace-button:hover {

Discussion:
insiders open search panel the expand/collapse button is wrong That's a regression from me using/adding CSS variables with the default btn style colors <img width="541" alt="Screenshot 2023-06-16 at 09 19 57" src=""
fy
Change:
.pipe(util.skipDirectories()) .pipe(util.fixWin32DirectoryPermissions()) .pipe(filter(['**', '!**/.github/**'], { dot: true })) // https://github.com/microsoft/vscode/issues/116523 <del> .pipe(electron({ ...config, platform, arch: arch === 'armhf' ? 'arm' : arch, ffmpegChromium: true })) </del> <ins> .pipe(electron({ ...config, platform, arch: arch === 'armhf' ? 'arm' : arch, ffmpegChromium: false })) </ins> .pipe(filter(['**', '!LICENSE', '!LICENSES.chromium.html', '!version'], { dot: true })); if (platform === 'linux') {

Discussion:
The Angular language service extension spawns a child process using and listens for the and events. The current version works as expected. Without any changes to the project, simply updating to results in the forked child process acting differently (never erroring and never closing). I'm using Mac 13.3.1 but we also had a report that the forked process isn't working in WindowsNT x64 10.0. either. There was a similar issue (though not entirely the same) a while back: Apologies for the rather involved reproduction... Here's how I'm able to reproduce and compare the behavior between the versions: our the repository with vscode insider version 1.78.0-insiders out the branch (we're actually removing this in the next version so it doesn't exist on ) dependencies with debugging, put a debugger statement before and one in the . The project is built with bazel so breakpoints would have to be put in the compiled JS files. the build script with the extension development host (Dev Client + Server run configuration) In the extension host, open the and then open the template file -- debugger should stop on the fork and if you continue, you will see that the debugger stops in the stderr data listener but never in the or . The output of the stderr also indicates that it is listening for a debugger and that it gets attached. The fork used which should have prevented this. The process also never produces any results or completes. You can have the fork retry by running the Angular: Restart Angular Language server command in the extension host. I've also verified that the spawn args are the same between versions and both include "--ms-enable-electron-run-as-node".
Issue was caused by the allocator changes to processes which now schedule delayed tasks to purge memory cache ;l=1183 and that revealed a bug in the causing the process to hang.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!