jiebi/CodeConvo huggingface dataset:
Change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.20.0-beta.5", </del> <ins> "xterm": "4.20.0-beta.6", </ins> "xterm-addon-search": "0.10.0-beta.1", "xterm-addon-serialize": "0.8.0-beta.1", "xterm-addon-unicode11": "0.4.0-beta.3", <del> "xterm-addon-webgl": "0.13.0-beta.2", "xterm-headless": "4.20.0-beta.5", </del> <ins> "xterm-addon-webgl": "0.13.0-beta.3", "xterm-headless": "4.20.0-beta.6", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

Discussion:
fixed in Need to update xterm to pull it in: !
What's a way to verify this issue on Windows?
With Powershell on Windows in the integrated terminal without a powerline font enabled: You should get something like this: <img width="62" alt="image" src="https://user-"
They seem a bit clipped to me: !
tracked in
Change:
this.editor.setPosition(position); this.editor.revealLineInCenterIfOutsideViewport(position.lineNumber); } <ins> if (this.accessibilityService.isScreenReaderOptimized()) { const commentRangeStart = range?.getStartPosition().lineNumber; const commentRangeEnd = range?.getEndPosition().lineNumber; if (commentRangeStart && commentRangeEnd) { const oneLine = commentRangeStart === commentRangeEnd; oneLine ? status(nls.localize('commentRange', "Line {0}", commentRangeStart)) : status(nls.localize('commentRangeStart', "Lines {0} to {1}", commentRangeStart, commentRangeEnd)); } } </ins> } public nextCommentingRange(): void {

Discussion:
cc something we should do as a result of discussion with
i think we should use or to indicate this when going to next range since this info is otherwise just strictly visual.
so the idea is the following: command go to next/previous commenting range : "Commenting range lines 4-10" And: on a comment widget : "Comment on lines 3-7" or "Comment on line 3"
I think the latter works well enough already. It's the former that I think we need. !
Actually, I wonder if the precise line number is important. Given a user isn't told what line number they're on when they move their cursor, perhaps instead we could say "spans 4 lines". Since a user has invoked this command, they know that it's a comment range, so we probably want to leave out "comment/commentable" to decrease noise
IMO, the line reference could be useful when users want to backtrace later.
shall we leave out the term 'Comment' here and just say 'lines 730-736' to reduce verbosity?
Or "Lines 1 to 5 can be commented on" as a screen reader user can disrupt it mid message via escape?
I am leaning toward just "Lines 1 to 5" given the user invoked the command so knows it's a comment range already.
Thanks for making the change!
open an editor that has some commentable ranges. Turn on a screen reader. use the command jump to next /previous commenting range. verify you hear the range like "lines 123 to 128" as the cursor's position gets updated.
nothing is being announced for me with that command, I have screen reader optimized and commenting verbosity on
depending on what you have going on otherwise, it will wait to say that since we're using instead of here.
are you seeing it jump to the commenting ranges?
works on my desktop, does not work on my surface laptop - neither the speech viewer nor through volume, nothing is read at all when running that command by NVDA. It is successfully navigating between commentable regions.
sounds like you've verified this works on your desktop. I'm curious to know if other aria alerts are working on your surface laptop - for example, in the chat input, accept a slash command completion. press backspace -you should hear that the state was cleared.
Change:
repository.closeDiffEditors(undefined, undefined, true); } <ins> @command('git.closeAllUnmodifiedEditors') closeUnmodifiedEditors(): void { const editorTabsToClose: Tab[] = []; // Collect all modified files const modifiedFiles: string[] = []; for (const repository of this.model.repositories) { modifiedFiles.push(...repository.indexGroup.resourceStates.map(r => r.resourceUri.fsPath)); modifiedFiles.push(...repository.workingTreeGroup.resourceStates.map(r => r.resourceUri.fsPath)); modifiedFiles.push(...repository.untrackedGroup.resourceStates.map(r => r.resourceUri.fsPath)); modifiedFiles.push(...repository.mergeGroup.resourceStates.map(r => r.resourceUri.fsPath)); } // Collect all editor tabs that are not dirty and not modified for (const tab of window.tabGroups.all.map(g => g.tabs).flat()) { if (tab.isDirty) { continue; } if (tab.input instanceof TabInputText || tab.input instanceof TabInputNotebook) { const { uri } = tab.input; if (!modifiedFiles.find(p => pathEquals(p, uri.fsPath))) { editorTabsToClose.push(tab); } } } // Close editors window.tabGroups.close(editorTabsToClose, true); } </ins> @command('git.openRepositoriesInParentFolders') async openRepositoriesInParentFolders(): Promise<void> { const parentRepositories: string[] = [];

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Quite often I want to have open only the files that are modified from source control. It would be handy to have a "Close all Unmodified" option that would close any open files that are not modified according to source control.
I would like to contribute on this.
Verification steps: a folder/workspace that contains a git repository auto-save using the setting multiple files, make changes, and save them multiple files but do not make any changes a file, make changes, but do not save it the "Git: Close All Unmodified Editors" command Confirm that all modified files remain open Confirm that the dirty editor remains open Confirm that all unmodified editors are closed
Change:
throw new Error(`a provider for the scheme '${scheme}' is already registered`); } <ins> const schemeRegistration = this._fileSystemConsumer._registerScheme(scheme, options); </ins> // this._registerLinkProviderIfNotYetRegistered();

Discussion:
Refs: A text document can be readonly if it's underlying file system provider is readonly. I am not sure how a custom editor implementor can figure this out and provide the correct experience.
Could we add a property to ? Does VS Code internally already know if a given textDocument is read only?
We basically ask the file system provider for the resource of the document for being readonly or not. That should be doable.
Change:
private _getHostName(): string | undefined { let name = this.configurationService.getValue<string>(CONFIGURATION_KEY_HOST_NAME) || hostname(); <del> name = name.replace(/[^w-]/g, '').substring(0, 20); </del> <ins> name = _removeLeadingDashes(name).replace(/[^w-]/g, '').substring(0, 20); </ins> return name || undefined; } } <ins> function _removeLeadingDashes(name: string): string { let i = 0; while (i < name.length && name.codePointAt(i) === CharCode.Dash) { i++; } if (i > 0) { return name.substring(i); } return name; } </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: VS Code Version: 1.74 OS Version: Windows 11 Pro Developers Build ! Error Code image attached Passes an invalid argument upon launch using the latest vs code Version 1.74
I can take this... The workaround is to use the setting to pick a name that does not start with a
to something starting with a dash remote tunnel access it comes up successfully
Change:
* Mapping between languages that support Emmet and completion trigger characters */ export const LANGUAGE_MODES: { [id: string]: string[] } = { <del> 'html': ['!', '.', '}', ':', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'jade': ['!', '.', '}', ':', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'slim': ['!', '.', '}', ':', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'haml': ['!', '.', '}', ':', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'xml': ['.', '}', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'xsl': ['!', '.', '}', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], </del> <ins> 'html': ['!', '.', '}', ':', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'jade': ['!', '.', '}', ':', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'slim': ['!', '.', '}', ':', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'haml': ['!', '.', '}', ':', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'xml': ['.', '}', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'xsl': ['!', '.', '}', '*', '$', '/', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], </ins> 'css': [':', '!', '-', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'scss': [':', '!', '-', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'sass': [':', '!', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'less': [':', '!', '-', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'stylus': [':', '!', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], <del> 'javascriptreact': ['!', '.', '}', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'typescriptreact': ['!', '.', '}', '*', '$', ']', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'] </del> <ins> 'javascriptreact': ['!', '.', '}', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'], 'typescriptreact': ['!', '.', '}', '*', '$', ']', '/', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'] </ins> }; export function isStyleSheet(syntax: string): boolean {

Discussion:
From an HTML file, type that suggestions show up to expand , but when is typed, suggestions stop showing up. Potential code pointers: Try adding for relevant languages (everything other than css to stylus) here If that doesn't work, we might need to add to some regexes for
Can you add character to expand suggestions also? For example and to show suggestions list for . !
I don't think that's a common use case, considering works.
+ or + doesn't expand anything. I must write + + to expand this.
can you set to ?
It works perfect, thanks.
Sorry but I have noticed that in file inside tag with extenstion installed doesn't work. Is this from extension implementation or not ? !
please file that issue with Vetur
Change:
return this.resources[1]; } <ins> @memoize </ins> get command(): Command { return this._commandResolver.resolveDefaultCommand(this); }

Discussion:
I guess the reload/refresh logic that we isn't working...
This is what I am reproducing enabled -disabled: works disabled -enabled: fails
I will push a workaround, refresh the SCM view when the config changes, because re-setting the merge group () doesn't seem to work reliably. I debugged this in to  but wasn't able to get to the bottom of this. When calling the method it seems that is already updated with what I am expecting to be updating now... fyi
Change:
result.semanticTokenRules.push(rule); } } catch (e) { <del> return Promise.reject(new Error(nls.localize({ key: 'error.invalidformat.semanticTokenColors', comment: ['{0} will be replaced by a path. Values in quotes should not be translated.'] }, "Problem parsing color theme file: {0}. Property 'semanticTokenColors' conatains a invalid selector", themeLocation.toString()))); </del> <ins> return Promise.reject(new Error(nls.localize({ key: 'error.invalidformat.semanticTokenColors', comment: ['{0} will be replaced by a path. Values in quotes should not be translated.'] }, "Problem parsing color theme file: {0}. Property 'semanticTokenColors' contains a invalid selector", themeLocation.toString()))); </ins> } } }

Discussion:
nls.localize() generally involves human visible output. Technically there are 2-3 arguments and the main human facing one is the second. The first argument is often treated as an "opaque" string, but in most systems, it's used to communicate to localizers, so, to some extent, there is value in not having misspellings there either. I can split out the identifiers if requested... Does this issue occur when all extensions are disabled?: Yes
can you provide me with more details about this. We use Transifex to translate our strings and the system contains both the value and the key.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
leftButton: boolean; middleButton: boolean; <ins> onInjectedText: boolean; </ins> } export interface ICommandDelegate {

Discussion:
have an inlay hint with command double click the hint to run the command the current word is selected too
I believe this needs some changes in the editor. Preventing default on the mouse event doesn't seem to fix it.
What should happen when the user clicks on an inlay hint for a single time?
Nothing, unless it's a cmd/ctrl-click on an active label part link
Change:
export function gitSimilarCommand(): ITerminalContextualActionOptions { return { commandLineMatcher: GitCommandLineRegex, <del> outputMatcher: { lineMatcher: GitSimilarOutputRegex, anchor: 'bottom' }, </del> <ins> outputMatcher: { lineMatcher: GitSimilarOutputRegex, anchor: 'bottom', offset: 0, length: 3 }, </ins> actionName: (matchResult: ContextualMatchResult) => matchResult.outputMatch ? `Run git ${matchResult.outputMatch[1]}` : ``, exitStatus: false, getActions: (matchResult: ContextualMatchResult, command: ITerminalCommand) => {

Discussion:
Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to
getOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?
The second one: !
Oh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.
Change:
interface ITerminalLabelTemplateProperties { cwd?: string | null | undefined; cwdFolder?: string | null | undefined; <ins> workspaceFolderName?: string | null | undefined; </ins> workspaceFolder?: string | null | undefined; local?: string | null | undefined; process?: string | null | undefined;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I usually give a meaningful name to my folders in the workspace config file, like this: It would be very useful if the integrated terminal title could show this name instead of the folder name. Currently these variables can be used in the property: ${cwd} ${cwdFolder} ${workspaceFolder} ${local} ${process} ${separator} ${sequence} ${task} The refers to the property of the folder. There could be a new variable, or something like that. Thank you in advance! Keep up the good work!
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
If this just needs to point at it should be trivial to add:
Is this still in the backlog for a future release? It would be very useful for accessibility platforms like talon voice where we rely on parsing context information out of the window title.
Change:
let visit = function (rule, parent) { if (rule.name === 'source.js' || rule.name === 'source.css') { <del> if (parent.parent && parent.parent.property === 'endCaptures') { </del> <ins> if (parent.node[0].name !== 'punctuation.definition.string.end.html' && parent.parent && parent.parent.property === 'endCaptures') { </ins> rule.name = rule.name + '-ignored-vscode'; patchCount++; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.71.0 Commit: Date: 2022-09-01T07:25:10.472Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.10.7-arch1-1 Sandboxed: No Steps to Reproduce: a file with the contents: a SvelteKit project and open any file. as shown in the video. https://user- Result: Without a space - it doesn't work. With space - it works. Cause: When the cursor is in front of the character, it thinks it is already AFTER , although this is not true. PS The same problem is in the last character, before , in the file.
This also happens in the HTML with where being cursor position. The problem seems to be because the position of the cursor is on the border of the embedded language. Maybe it could be changed to using the previous character, when possible, instead of the next?
Thanks - I can reproduce what you are saying. I don't really know what svelte kit is nor what extension you are using. So, I am focusing on html. Using "F1 Inspect Editor Tokens and Scopes" shows me that the language at position is classified as html, not JavaScript. <img width="728" alt="Screenshot 2022-12-05 at 16 22 35" src="https://user-"Because of that no JS snippets are shown. Passing this on to who maintains the TextMate grammars for this.

An easy workaround on your end would be to configure the snippet to also work for the "outer" language
SvelteKit: SvelteJS is the 4th most popular framework (behind ReactJS Vue Angular), and considered to have the best DX of all frameworks. Extension for SvelteJS: But I hope that solving the problem in html/js, will also solve the problem in SvelteJS.
Related to
what do you think of modifying the solution to so that we don't ignore strings? PR
Change:
insertedNodes.forEach(node => dfs(node, insertedNodesVisitor)); const nodes: ITreeNode<T, any>[] = []; <ins> let silent = true; </ins> for (const node of this.nodes) { const id = this.identityProvider.getId(node.element).toString();

Discussion:
a TypeScript file open (with some code in it) the outline to jump to the beginning of a method something somewhere the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds Yes (both in insiders & stable) Version: 1.34.0-insider (user setup) Commit: Date: 2019-04-26T13:39:29.623Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.
It seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g being but it seems like a tree issue <img width="777" alt="Screenshot 2019-04-29 at 10 33 24" src="https://user-"
Change:
) { } } <del> export class ChatRequestNotebookData { </del> <ins> export class ChatRequestNotebookData implements vscode.ChatRequestNotebookData { </ins> constructor( <del> readonly notebook: vscode.NotebookDocument </del> <ins> readonly cell: vscode.TextDocument </ins> ) { } }

Discussion:
Today inline chat for editors and notebooks rely on implicit variables, e.g . This isn't proper and we should have real API, e.g some extra property on that encapsulates data about the chat location.
Done, no more implicit variables
Change:
startChildIndex = Math.min(max, Math.max(min, startChildIndex)); endChildIndex = Math.min(max, Math.max(min, endChildIndex)); <del> if (startChildIndex === endChildIndex && startOffset === endOffset && startOffset === 0) { </del> <ins> if (startChildIndex === endChildIndex && startOffset === endOffset && startOffset === 0 && !domNode.children[startChildIndex].firstChild) { </ins> // We must find the position at the beginning of a <span> <del> // To cover cases of empty <span>s, aboid using a range and use the <span>'s bounding box </del> <ins> // To cover cases of empty <span>s, avoid using a range and use the <span>'s bounding box </ins> const clientRects = domNode.children[startChildIndex].getClientRects(); return this._createHorizontalRangesFromClientRects(clientRects, clientRectDeltaLeft); }

Discussion:
Issue Type: Bug Steps to Reproduce: an empty document with language set to TypeScript this: To help follow, these are two words, the first is the three vertical bars, and the second is the three circles (btw this is Hebrew text, and these aren't real words) your cursor to the beginning - <kbdHome</kbdResult: Cursor is somewhere in the middle Expected: Cursor should be at the far right (before the first word) your cursor to the end of the first word - <kbdRight</kbd3 Result: Cursor is between the space and the second word Expected: Cursor should be between the space and the first word your cursor to the start of the second word - <kbdRight</kbdResult: Cursor is at the far left Expected: Cursor is between the space and the second word language to "Plain Text" and repeat these experiments, you will now get different cursor positions - WTF? The problem is specifically when the cursor is at the beginning of a syntax token, therefore the difference between document languages. VS Code version: Code - Insiders 1.54.0-insider (, 2021-02-19T05:14:28.632Z) OS version: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes More weirdness: Select the space: <kbdHome</kbd3<kbdRight</kbd<kbdShift+Right</kbd- Select the space from the other side: <kbdHome</kbd4<kbdRight</kbd<kbdShift+Left</kbd- Select the space and the first word: <kbdHome</kbd4<kbdRight</kbd<kbdShift+Home</kbd