jiebi/CodeConvo huggingface dataset:
Change:
args.push('--', uri.fsPath); <del> const result = await this.exec(args); if (result.exitCode) { // No file history, e.g. a new file or untracked return []; } </del> <ins> try { const result = await this.exec(args); if (result.exitCode) { // No file history, e.g. a new file or untracked return []; } </ins> <del> return parseGitCommits(result.stdout); </del> <ins> return parseGitCommits(result.stdout); } catch (err) { // Repository has no commits yet if (/does not have any commits yet/.test(err.stderr)) { return []; } throw err; } </ins> } async reflog(ref: string, pattern: string): Promise<string[]> {

Discussion:
Issue Type: <bBug</bWhen using the timeline on a project with git repository initialized but no commit at all (not even "initial commit"), unchecking Local History (but keeping Git checked) will keep showing the Local History. Only unchecking Git too will refresh the view, showing nothing. a project and initialize .git but do not commit an "initial commit". Generally, repositories created via GitHub automatically commit an "initial commit", while repostiories created manually or via a tool like cargo init (for Rust projects) will not create an initial commit. the project folder in VS Code and open the Timeline view. Make sure that the active filters are "Git" and "Local History". some file and save it. You should see "File Saved" in the Timeline. on Timeline filter icon uncheck Local History. Expected: Since there is no git commit, all Timeline entries disappear Actual: All local history entries stay on place (until you also uncheck Git) VS Code version: Code 1.67.2 (, 2022-05-17T18:23:40.286Z) OS version: Linux x64 5.4.0-113-generic Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (37)</summaryExtensionVersion ------ lua-debug1.58.0 increment-selection0.2.0 numbered-bookmarks8.3.0 better-toml0.3.2 doxdocgen1.4.0 clipboard-manager1.4.2 EditorConfig0.16.4 godot-tools1.3.0 better-cpp-syntax1.15.14 vscode-graphviz0.0.6 syntax-project-pbxproj0.1.3 csharp1.25.0 python2022.6.2 vscode-pylance2022.5.3 jupyter2022.4.

jupyter-keymap1.0.0 jupyter-renderers1.0.7 remote-containers0.234.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.3 cmake-tools1.10.5 cpptools1.9.8 cpptools-extension-pack1.2.0 incrementor1.0.3 cxx-set-next-statement-extension0.0.7 vscode-subword-navigation1.2.0 ravi-debug1.0.2 rust0.7.8 rust-analyzer0.3.1075 vscode-lua0.12.4 cmake0.0.17 unity-debug3.0.2 vscode-lldb1.7.0 debug0.26.0 change-case1.0.0 dictionary-completion1.2.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I think this may be partially caused by the git timeline doing and opening a timeline of a file in the repo you get a console error of . This causes the git timeline to appear to infinitely load
Change:
} //#endregion <ins> //#region https://github.com/microsoft/vscode/issues/90517 export interface FileSystemError { /** * A code that identifies this error. * * Possible values are names of errors, like [`FileNotFound`](#FileSystemError.FileNotFound), * or `undefined` for an unspecified error. */ readonly code?: string; } ////#endregion </ins> }

Discussion:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Add an method to the interface. The current options are: trying to stat the and seeing if it fails — we have no way to tell why it failed; reading a parent directory — we may not have read access to the parent directory; using node's — only works for the local filesystem.
I see s are spec'd to thow on when the file doesn't exist, but does not spec such errors.
We have no plans for adding and instead should be used (this goes along the deprecated to NodeJS's -deprecation). Still, I do agree that we should spec the error
Would be a passable solution?
Re-open for API proposal/finalization. Proposal is to add a field to the -class
should I rename the issue to better reflect the proposal?
Reactions during the API meeting were positive, so I am confident that we can finalize this during the current milestone. One feedback item was to always have a value for , e.g. let its default value be something like or
I did a quick search of the codebase, and it looks like is usually used for such cases in the various error code enums.
This is now in and will be stable API with the next relase. thanks for the help
Change:
import { isLinuxSnap, isMacintosh } from 'vs/base/common/platform'; import { escape } from 'vs/base/common/strings'; import { ThemeIcon } from 'vs/base/common/themables'; <ins> import { URI } from 'vs/base/common/uri'; </ins> import { IssueReporterModel, IssueReporterData as IssueReporterModelData } from 'vs/code/electron-sandbox/issue/issueReporterModel'; import { localize } from 'vs/nls'; import { isRemoteDiagnosticError } from 'vs/platform/diagnostics/common/diagnostics';

Discussion:
Testing It seems weird to pass in string when you could just pass in a Uri. Better yet, consider
I think when I was testing, URI wasn't serializable so it wouldn't be passed thru the command properly - will double check this soon though
you may need to turn it into a and then that on the other end. It's possible. We do it with other processes.
Change:
try { parsedValue = JSON.parse(value); if (!parsedValue.data) { <del> throw new Error(`[EncryptionMainService] Invalid encrypted valu: ${value}`); </del> <ins> throw new Error(`[EncryptionMainService] Invalid encrypted value: ${value}`); </ins> } const bufferToDecrypt = Buffer.from(parsedValue.data);

Discussion:
Describe the bug There's a typo in an error message within the file. To Reproduce Steps to reproduce the behavior: Go to src/vs/platform/encryption/electron- Notice the typo "valu" which should be "value" Expected behavior The error message should read "Invalid encrypted value" instead of "Invalid encrypted valu".
Change:
// Import the effects we need import { Color } from 'vs/base/common/color'; <del> import { registerColor, darken, lighten, transparent } from 'vs/platform/theme/common/colorUtils'; </del> <ins> import { registerColor, darken, lighten, transparent, ifDefinedThenElse } from 'vs/platform/theme/common/colorUtils'; </ins> // Import the colors we need import { foreground, contrastBorder, activeContrastBorder, focusBorder, iconForeground } from 'vs/platform/theme/common/colors/baseColors';

Discussion:
default light theme trigger intellisense and type some matching characters bad colors <img width="1142" alt="Screenshot 2024-03-27 at 18 29 42" src=""

Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-27T05:50:10.528Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. Theme: ! Steps to Reproduce: +Shift+P VSIX !
Caused by:
Change:
} renderTwistie(element: IAsyncDataTreeNode<TInput, T>, twistieElement: HTMLElement): boolean { <del> toggleClass(twistieElement, 'codicon-loading', element.slow); </del> <ins> if (element.slow) { addClasses(twistieElement, treeItemLoadingIcon.classNames); } else { removeClasses(twistieElement, treeItemLoadingIcon.classNames); } </ins> return false; }

Discussion:
Issue Type: <bBug</bIn latest Insiders build instead of loading icon I see spinning chevron for some tree nodes. It's mostly noticeable in GitHub Pull Request extension tree, however I was able to reproduce it in Call Hierarchy while expanding some nested trees. Looks like has lower priority than which prevents icon change. /cc VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-22T08:44:55.510Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Change:
this.container.removeClass('inactive'); } else { this.container.addClass('inactive'); <ins> this.setUnfocusedState(); </ins> } } }

Discussion:
Issue Type: <bBug</bWhen using the custom title bar and the toggled menu bar setting, the menu bar becomes stuck in the toggled on state. This primarily occurs when the active VS Code window becomes inactive while the menu bar is toggled on. When using multiple VS Code windows this makes it difficult to identify the correct window because the title bar's filename information is hidden. Steps to reproduce: the setting to , and setting to VS Code is the active window, hold down the key to show the menu bar the key while still holding the key to switch to another application. The active VS Code window becomes inactive and the menu bar is visible. Alternatively you can click outside of the active VS Code window while the menu bar is being displayed. VS Code version: Code 1.25.0 (, 2018-07-05T13:11:58.697Z) OS version: Windows_NT x64 10.0. <details<summaryExtensions (4)</summaryExtensionVersion ------ classic-asp0.0.4 vscode-icon-theme1.6.2 csharp1.15.2 PowerShell1.8.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.538 --- <!-- score: 0.491 --- <!-- score: 0.483 --- <!-- score: 0.482 --- <!-- score: 0.48 --<!-- potentialduplicatescomment --
Change:
return false; } <del> if (event.middleButton) { return false; // Give contents of the item a chance to handle this (e.g. open link in new tab) } </del> if (event.target && event.target.tagName && event.target.tagName.toLowerCase() === 'input') { return false; // Ignore event if target is a form input field (avoids browser specific issues) } <del> if (this.options.clickBehavior === ClickBehavior.ON_MOUSE_DOWN && event.leftButton) { </del> <ins> if (this.options.clickBehavior === ClickBehavior.ON_MOUSE_DOWN && (event.leftButton || event.middleButton)) { </ins> return false; // Already handled by onMouseDown }

Discussion:
VSCode Version:1.6.1 OS Version:Windows 10 Pro x64 Steps to Reproduce: left sidebar on file item with middle mouse button be nice if it opened those files in new tabs
I just tried this with Sublime and it just seems to open the file like a normal left click. Would you expect in this case to not open the file in preview mode but pinned as real tab? Is that the difference to normal left click?
in my case when I click on a file in sidebar in most cases the file that opens reuses the active tab, that's what I'd like to avoid, if possible with middle click.
right, you know that you can configure this via
didm't know that, thanks, and sorry for the noise
I still think we should do something on middle mouse, even if we just open a file. Currently we seem to do nothing.
This actually applies to all our trees, not just the explorer. I think we should be consistent and support this for any tree. I like the idea of pinning the file when opening like that. This is something where contributors could chime in for a PR
I would like to work on this issue. As I am new to the project would appreciate any help. Here are some questions to start with: I've noticed that Search and Changes viewlets use 'selection' event instead of 'click','mousedown' events used by Debug, Explorer to open editor. Is it intented choice or we should try to be consistent across all the Trees? I would expect Expand/Collapse to still happen on middle mouse click. What do you think? Extensions seems to not support pin at all. Don't know if it's only on my version/environment. Opened an issue I've seen a comment in where we do not handle middle button event: "Give contents of the item a chance to handle this (e.g. open link in new tab)". I wonder if it's still a valid comment. I'm on Windows and i'm wondering if we expect the same behavior on Mac or we should have some Mac-specific treatment of middle button (Command button or smth?) Thanks.
I think middle-click should be translated into a selection event from the tree so that down stream components do not have to do anything special. I also think middle click should not opened pinned, but just normal. Can you explain?

I would try to convert it to a selection event and see how that behaves. I am fine with making this work the same on all OS.
: Sorry my comment about Extensions was actually referring . Specifically you cannot open more than one editor tab with extension. Submitter a PR fix for this issue. Thanks.
Change:
listDropBackground?: Color; } <del> // Accepts a single or multiple workspace folders function hasExpandedRootChild(tree: WorkbenchCompressibleAsyncDataTree<ExplorerItem | ExplorerItem[], ExplorerItem, FuzzyScore>, treeInput: ExplorerItem | ExplorerItem[]): boolean { const inputsToCheck = []; if (Array.isArray(treeInput)) { inputsToCheck.push(...treeInput.filter(folder => tree.hasNode(folder) && !tree.isCollapsed(folder))); } else { inputsToCheck.push(treeInput); } for (const folder of inputsToCheck) { for (const [, child] of folder.children.entries()) { if (tree.hasNode(child) && tree.isCollapsible(child) && !tree.isCollapsed(child)) { return true; </del> <ins> function hasExpandedRootChild(tree: WorkbenchCompressibleAsyncDataTree<ExplorerItem | ExplorerItem[], ExplorerItem, FuzzyScore>, treeInput: ExplorerItem[]): boolean { for (const folder of treeInput) { if (tree.hasNode(folder) && !tree.isCollapsed(folder)) { for (const [, child] of folder.children.entries()) { if (tree.hasNode(child) && tree.isCollapsible(child) && !tree.isCollapsed(child)) { return true; } </ins> } } } <ins> return false; } /** * Whether or not any of the nodes in the tree are expanded */ function hasExpandedNode(tree: WorkbenchCompressibleAsyncDataTree<ExplorerItem | ExplorerItem[], ExplorerItem, FuzzyScore>, treeInput: ExplorerItem[]): boolean { for (const folder of treeInput) { if (tree.hasNode(folder) && !tree.isCollapsed(folder)) { return true; } } </ins> return false; }

Discussion:
Lately (since a few days) I see the explorer show an expand all icon even though some folders are expanded (in a multi root workspace): <img width="300" alt="image" src="https://user-"This must be a recent regression, not sure if in explorer or tree widget.
See
This breaks my muscle memory, I always collapse the explorer to start a new task and the new behaviour breaks this. I really see no value of this new behaviour? It is not even expanding all folders, only the ones that can be resolved? What is the use case?
As a suggestion: only show the expand button when really all nodes are collapsed, but keep the collapse button when any node is expanded.
I'm with this is quite different behavior in a multi-root workspace, I have one workspace with 5 root folders and another with 10+, prior to this change clicking the expand/collapse button in explorer would collapse all the folders in each root folder, clicking again would then collapse all the root folders. What I get now is the following: If all root folders are collapsed, clicking the expand/collapse button does nothing If one root folder is open the expand/collapse button expands and collapses folders within that root folder More than one root folder open the same as before for all of the open root folders Perhaps we could have an option to opt-in to this new behavior, I can't think of a single reason why I would want to expand every folder in a project.
Feature got removed.
Change:
import { createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { WorkbenchToolBar } from 'vs/platform/actions/browser/toolbar'; import { IMenuService, MenuId } from 'vs/platform/actions/common/actions'; <ins> import { ICommandService } from 'vs/platform/commands/common/commands'; </ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextViewDelegate, IContextViewService } from 'vs/platform/contextview/browser/contextView';

Discussion:
!
In the chat view responses, users can hit on the link, so we will do the same here.
to verify: run an command that produces file links open the accessible view by focusing that chat response and using move your cursor to the link and press the file should be opened
Change:
if (typeof size === 'undefined') { if (!this.supportDynamicHeights) { <del> console.warn('Dynamic heights not supported'); </del> <ins> console.warn('Dynamic heights not supported', new Error().stack); </ins> return; }

Discussion:
I see multiple of these in dev console but that's not helpful since it's hard to trace the buggy caller. Should we include in the warning? !
Sure, I'll add the stack trace, however, it's possible that it won't be very helpful as it's likely to stem from a list event. If that is the case we can consider logging more detailed information on the list/node.
verification by code review
Change:
EditorOption.foldingStrategy, 'foldingStrategy', 'auto' as 'auto' | 'indentation', ['auto', 'indentation'] as const, <del> { markdownDescription: nls.localize('foldingStrategy', "Controls the strategy for computing folding ranges. `auto` uses a language specific folding strategy, if available. `indentation` uses the indentation based folding strategy.") } </del> <ins> { enumDescriptions: [ nls.localize('foldingStrategy.auto', "Use a language-specific folding strategy if available, else the indentation-based one."), nls.localize('foldingStrategy.indentation', "Use the indentation-based folding strategy."), ], description: nls.localize('foldingStrategy', "Controls the strategy for computing folding ranges.") } </ins> )), foldingHighlight: register(new EditorBooleanOption( EditorOption.foldingHighlight, 'foldingHighlight', true,

Discussion:
! "strategy". No. Method. "Language specific". Missing hyphen. "indentation based". Missing hyphen. Also "if available" fails to say that if not, indentation method is used.
We're programmers, not spell checkers
Which is why you welcome reports such as this, right?
Change:
@IUriIdentityService private readonly uriIdentityService: IUriIdentityService, @IWorkbenchEnvironmentService private readonly environmentService: IWorkbenchEnvironmentService, @IWorkspaceContextService private readonly workspaceService: IWorkspaceContextService, <del> @IWorkspaceTrustEnablementService private readonly workspaceTrustEnablementService: IWorkspaceTrustEnablementService </del> <ins> @IWorkspaceTrustEnablementService private readonly workspaceTrustEnablementService: IWorkspaceTrustEnablementService, @IFileService private readonly fileService: IFileService </ins> ) { super();

Discussion:
I have a window that should be trusted, but is in Restricted mode. When I click "Trust" on the workspace trust management page, nothing happens. Here's what I'm doing, not sure what is important Clone a the windows remote and open in remote-ssh from a mac Debug the extension, open some folder The folder is already in the trusted list: <img width="1427" alt="image" src="https://user-"But when I click "Trust Parent", that works
I've been hitting this quite regularly for the past few months, also with (Windows) SSH remotes. I haven't been able to nail down what triggers it but give me a few attempts at reopening the remote and it'll always get into the bad untrusted state. Clicking Trust does nothing. In order to "re-trust" the workspace, I need to delete one of the bolded entries and then click Trust. ! Windows 11, VS Code 1.72.1 (user).
Okay I could not reproduce this myself, but my hunch is that this is a drive letter capitalization issue. I do not know why this is inconsistent, however. are you able to reproduce the state still? If so, can you help debug this check
Yeah, it's a drive capitalization issue. My workspace has a capital C:, the trust info has lowercase
! I'm experiencing a similar issue with VScode. It's launching in the restricted mode all the time regardless of whether I hit <kbdTrust</kbdin the past or not. This have been happening over the last few monthes or so already. Event though it's convenient that the vscode is prevented from wasting cpu & i/o time upon launching (I've over 3 apps opened daily) by the trust-wall, I'm still considering this an issue.
are you also using remote ssh?
No, I don't. I don't think that the issue with remote SSH connection.
can you provide more information about your setup. e.g. which patch you have trusted and the path that is being considered "untrusted"
Basically every path I work with everyday. There is also a problem with various tabs that are getting opened everytime computer gets started up. These include "Get started" and "Git Lenses" pages. I have to close them everytime code is started.

<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
query2 = new Query('hello', 'installs', ''); assert(!query1.equals(query2)); }); <ins> test('autocomplete', () => { Query.autocompletions('@sort:in').some(x => x === '@sort:installs '); Query.autocompletions('@sort:installs').every(x => x !== '@sort:rating '); Query.autocompletions('@category:blah').some(x => x === '@category:"extension packs" '); Query.autocompletions('@category:"extension packs"').every(x => x !== '@category:formatters '); }); </ins> });  No newline at end of file

Discussion:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Change:
reset(this.stepsContent, categoryDescriptorComponent, stepListComponent, this.stepMediaComponent, categoryFooter); const toExpand = category.steps.find(step => this.contextService.contextMatchesRules(step.when) && !step.done) ?? category.steps[0]; <del> this.selectStep(selectedStep ?? toExpand.id, !selectedStep, true); </del> <ins> this.selectStep(selectedStep ?? toExpand.id, !selectedStep); </ins> this.detailsScrollbar.scanDomNode(); this.detailsPageScrollbar?.scanDomNode();

Discussion:
Type: <bBug</bContext changes causes images to flicker and, worse, quick picks to close. Run Open walkthrough Open step or Hit the button Quick pick closes right after clicking and image flashes. VS Code version: Code - Insiders 1.77.0-insider (, 2023-03-08T05:22:25.379Z) OS version: Darwin x64 22.3.0 Modes: Sandboxed: Yes <!-- generated by issue reporter --
Seems as the context changes, which changes focus and closes the quick picks.
I can't repo this on OSS. But used the developer tools on insiders to debug it. fires the context changed event too many times which causes us to reload the media I removed rebuilding step if the step is already open which should fix the issue for the walkthroughs. But there is likely a larger issue to be fixed with the being fired too many times. You can turn off settings sync and try the steps described above - no repro.