jiebi/CodeConvo huggingface dataset:
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.37: version "0.12.0-beta.37" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.37.tgz#e465100041a7e0b1d32b01cd0b0ba5a516ac13c2" integrity sha512-d4GfKlMrWZGzsMfMHd2siG+QiOvwikhwiu+JQlIhlnAShT/wU5BOGbNfDDA1tHmkW7G1UCFgucBuVxrs5wjuBQ== xterm-headless@4.19.0-beta.58: version "4.19.0-beta.58" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.58.tgz#3a38cf3b9cd2606fb342a5cf8f2a0cfb963a62e8" integrity sha512-wKQW8VzkFjyYDvcaM26gulo+YghyocfkZnKMH7gc/+/mFn3YXUPBPuOcX6e0M7NibyMlewpQpZjHQUPLBjkzfw== xterm@4.19.0-beta.58: version "4.19.0-beta.58" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.58.tgz#cbe535b0b85bc7f8ae3cc242df006bea04cdf541" integrity sha512-fr3QC2qS2NBab8X7kwA/3QZELzQqhAKsngvK8NkhsrFN1DAuyEETkzqXuKbO7OKpCB6VqGDN6GPkNlUB9VrIDA== </del> <ins> xterm-addon-webgl@0.12.0-beta.38: version "0.12.0-beta.38" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.38.tgz#59fc8f3711e38b9a238fd460cd070007b7904e7a" integrity sha512-fqRhfwUx/WZlDLFsZX26irLYTdRGMf1xuRwoqfr4KiFoQvHye55U8VJ4WLHdWglN2Kzh8PbINk5HfMhIwYHe9Q== xterm-headless@4.19.0-beta.60: version "4.19.0-beta.60" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.60.tgz#ccd09a7c69ba487d3fd87d6a8d159f1a6a10e9b2" integrity sha512-mJ24BRnEDCASJDTGFZysZxiXkCmed3eMFiWCPvIF48LVrqxt1cImoVKBlxqkdgUkHKjfF2c92S1TTBL5aT1I0w== xterm@4.19.0-beta.60: version "4.19.0-beta.60" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.60.tgz#de89d93153ae3ec17b53f3e5d03b8ea859126081" integrity sha512-YQjvp4xtSAyNm9+gF4OA5+QzkSWdKMCy4WABETpe7CsrEGx+mJVoXCZ9wgopmvwRXz7DeJvKM5dWz1HPjVLDtA== </ins> yallist@^4.0.0: version "4.0.0"

Discussion:
Upstream issue: Repro: Alt+click and drag in the terminal Moving right on the same line does not make a selection Moving to top-right or bottom-left doesn't make a selection (this works in canvas renderer only?) Cursor isn't correct ! Correct behavior in 1.67: !
When verifying make sure that copy works as expected for column selection in each quadrant as well.
Change:
## Markdown plus h2 with a custom ID ##   {#id-goes-here} [Link back to H2](#id-goes-here) <ins> ### Alternate heading styles: Alternate Header 1 ================== Alternate Header 2 ------------------ </ins> <!-- html madness --> <div class="custom-class" markdown="1"> <div>

Discussion:
! H1 and H2 are not highlighted. The preview is fine. Tested on VS Code 1.3.1 on OS X 10.11.6
I wanna give this one a try. Here is what I have achieved so far. !
Couple of updates on this: to highlight both lines at the same time, the way I was trying above doesn't look practical. It automatically highlights the current line assuming a match of the begin, until it finds a non matching end/while (Basically the line highlights, and if the next line isn't a '-{3,}' then the syntax goes back to normal mode. alt heading 2 syntax (just the -{3,} part) is conflicting with the rule meta.separator.markdown, which takes precedence and hence the issue. Would it be a better option to fix this conflict instead?
It doesn't work with 1.9.0 !
I believe this is as designed. Getting the TM grammar to highlight both the lines is tricky. If you refer to my previous comment, the first point: This would be confusing for the user. In simple terms, it means that as soon as a user starts typing, the line highlights, and goes back to normal syntax if the next line is neither of the alternate H1/H2 (---/===) text. What do you think?
Is it possible to let the line white and if a line starts with --- oder ===, then this one and the previous one switch to blue? That is the same behavior like in other editors.
Change:
} } else if (isSCMHistoryItemGroupTreeElement(element)) { const menus = this.scmViewService.menus.getRepositoryMenus(element.repository.provider); <del> const menu = element.direction === 'incoming' ? menus.historyProviderMenu?.incomingHistoryItemGroupContextMenu : menus.historyProviderMenu?.outgoingHistoryItemGroupContextMenu; </del> <ins> const menu = menus.historyProviderMenu?.getHistoryItemGroupContextMenu(element); </ins> if (menu) { actionRunner = new HistoryItemGroupActionRunner();

Discussion:
Testing I expected the action to appear on an unpublished branch, not the action. I am aware they both do the same. <img width="647" alt="Screenshot 2024-01-24 at 11 37 40" src=""
Change:
} get top(): number { <del> return this.orientation === Orientation.HORIZONTAL ? this.absoluteOffset : this.absoluteOrthogonalOffset; </del> <ins> return this.orientation === Orientation.HORIZONTAL ? this._absoluteOffset : this._absoluteOrthogonalOffset; </ins> } get left(): number { <del> return this.orientation === Orientation.HORIZONTAL ? this.absoluteOrthogonalOffset : this.absoluteOffset; </del> <ins> return this.orientation === Orientation.HORIZONTAL ? this._absoluteOrthogonalOffset : this._absoluteOffset; </ins> } get minimumSize(): number {

Discussion:
Was finally able to repo this but not reliably. It seems to rely on a new being created, but this doesn't always happen. The most reliable repo for me: with a notebook and text editor in a single editor group the notebook editor down to create a new group below the text editor grab the notebook editor and drag it right to move the bottom editor to the right I think the root cause is that the notebook widget is passed the wrong position. I'm going to work around this by making the notebook editor ignore the position it is given, however this will also undo the performance fixes we made this iteration for notebook layout I don't fully understand the grid layout code but it seems that is being set incorrectly in cases where a new BranchNode/SplitView is created. Here's what I see happening after step 3 of the repo above: setter is called calls which creates a new the constructor, a new Split View is created is called on it. At this point, of the split view is: the time layout is called on the notebook editor widget, is computed as zero. This results in the wrong layout. Looking at the code, we can see that is passed in as the absolute offset in step 4: <img width="1104" alt="Screenshot 2022-11-30 at 12 48 54 PM" src="https://user-"If I then slightly resize the window, here's what happens: call on the split View for the new group now is: we layout the notebook editor, is now correctly computed as Originally posted by in
Change:
languageConfigurationAutoClosingPairs: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.languageConfigurationAutoClosingPairs.d.ts', mappedEditsProvider: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.mappedEditsProvider.d.ts', notebookCellExecutionState: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookCellExecutionState.d.ts', <del> notebookCodeActions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookCodeActions.d.ts', </del> notebookControllerAffinityHidden: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookControllerAffinityHidden.d.ts', notebookDeprecated: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookDeprecated.d.ts', notebookExecution: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookExecution.d.ts',

Discussion:
Issue to document the final state of the CodeActionKind. Current proposition is as follows: A new top level kind will be introduced as , referenced as for extension authors and core usage If a notebook CodeAction is called against a notebook, it will ONLY be called against the first cell of the notebook, and will precede the standard source CodeActions that will run against each cell in asynchronously. This is to ensure that all edits involving multiple cells will be addressed before any per cell action is taken. (ex: move all imports to top of notebook, normalize variable names, source.organizeImports, etc.) Extension authors will be recommended via documentation in to use one of the following notations to create their kind: - The following also works, but is less explicit: - Extension authors will be expected to register their provider with an adequate , as well as that contains the field The following will be to : thank you
Change:
} } <ins> export class OpenRawDefaultKeybindingsAction extends Action { public static readonly ID = 'workbench.action.openRawDefaultKeybindings'; public static readonly LABEL = nls.localize('openRawDefaultKeybindings', "Open Default Keyboard Shortcuts File"); constructor( id: string, label: string, @IPreferencesService private preferencesService: IPreferencesService ) { super(id, label); } public run(event?: any): TPromise<any> { return this.preferencesService.openRawDefaultKeybindings(); } } </ins> export class OpenWorkspaceSettingsAction extends Action { public static readonly ID = 'workbench.action.openWorkspaceSettings';

Discussion:
New Setting: New Action: Currently, allows users to disable the side-by-side default/user settings view, instead allowing us to view our customized settings file in isolation when using the command. A corresponding option does not yet exist for , although it would be equally useful. Additionally, something like contribution in should be implemented to allow access of the default keybindings if is disabled.
I'd like to take solve this issue. any suggestions? What files will I have to work with for this? This would be my first contribution to VSCode!
References: for Opening raw default for not opening default settings
Hey guys, I got some work around for showing user settings in (GUI) (yet not pushed in my PR), but I had a question. If we set : and open (GUI), it should show only user keybinding settings. But then how should we handle and actions in menu (3 dot at right corner)?
The filtering effects of & seem to be isolated to the UI, so I would expect them to retain their existing functionality. The proposed changes are intended to affect .
Change:
errorCodes: Array.from(supportedActions) }; const response = await this.client.execute('getCodeFixes', args, token); <del> return (response.body || []).map(action => this.getCommandForAction(action)); </del> <ins> return (response.body || []).map(action => this.getCommandForAction(action, file)); </ins> } private get supportedCodeActions(): Thenable<NumberSet> {

Discussion:
This would enable Microsoft/TypeScript. I am mostly describing changes to in the TypeScript repository here. we discussed this today. The returned in a code action request may include a list of commands. A code action may even have an empty list and consist of only a command. We could choose specify that must an of commands, although I'm not sure if that's worth bothering with. If the code action is accepted, the editor must send the commands back to the language service to actually be carried out. This means needing a new request type, "applyCodeFixCommand". This looks like: The contents of will just be what was sent to the editor. (Typically this will include a "type" field so the language service can dispatch on the type of action.) The language service should send a response when the action is complete. I'm thinking we can just reuse the field for error reporting and for a successful response. (Currently the field is documented to only be used if is false.) We could put that in the body, but then it seems redundant.
This proposed TS API changes seem good to me. I don't see any issues implementing this on our side. We'll just need to figure out how best to surface the success / failure messages to users Let me know when the TS part lands in a nightly build so that I can try prototyping this
If we put this in a nightly build, people will start seeing codefixes that don't work. Could you check out a branch instead?
Sure, sounds good
You can checkout and build the branch from the TypeScript repository. If you include in a file and it is an unused identifier, we'll give you a code fix that comes with a command to write a file . (It also replaces the file content so you can verify that at least that works.)
Thanks I'll open a PR on our side shortly. A few quick notes: Looks like is currently using instead of for the key. The name makes more sense to me Also, I get this error when I try to run the command:
Here's the PR:
I pushed a quick fix of those two issues -- changed the name from "action" to "command" and remembered to write to a file rather than to a directory.
Ok, the fix looks good.

I see the d.ts file being created now
Any reason this couldn't land in nightly so I can experiment with it? Regular users won't see anything until we actually add something in TypeScript master that uses this.
We're getting ready for release currently but I can check this in once we branch off for the September release. This code in its current state won't compile until we pick up a new * file from TypeScript, but we can sprinkle in some casts to work around this until then
Change:
public onEnabledChanged(cue: AudioCue): Event<void> { return Event.fromObservableLight(this.isCueEnabledCache.get({ cue })); } <ins> public onAlertEnabledChanged(cue: AudioCue): Event<void> { return Event.fromObservableLight(this.isAlertEnabledCache.get({ cue })); } </ins> }

Discussion:
Testing "Audio Cues: Line Has Warning" is set to false. "Accessibility Alert: Warning" is set to true. I generated a warning by using the Markdown Lint extension and writing text into a new Markdown file without an h1 header. When I turn on the audio cue, the accessibility alert also alerts me that there's a warning. When I turn off the audio cue but leave the accessibility alert on, the accessibility alert does not alert me that there's a warning.
I cannot seem to trigger a warning - can you pls give more specific instructions about how to do so? !
Install the extension. Then create a .md file and paste in the following The extension should already generate a warning.
Note this issue when verifying . When I tested using a screen reader, the warning only appeared once. Based on debugging (the call happens), I believe when using a braille device, this works.
Change:
color: var(--vscode-editorLightBulbAutoFix-foreground, var(--vscode-editorLightBulb-foreground)); } <ins> .monaco-editor .lightBulbWidget.codicon-sparkle-filled { color: var(--vscode-editorLightBulbAi-foreground, var(--vscode-icon-foreground)); } </ins> .monaco-editor .lightBulbWidget:before { position: relative; z-index: 2;

Discussion:
I like the AI sparkle but I think its color is too strong. IMO it should be less strong and so that it blends away a little more <img width="192" alt="Screenshot 2023-11-29 at 12 46 12" src=""
for help
Hey thanks for writing about this, this is indeed a good point. I can make the opacity lower (set it for example to 0.5). With such an opacity, the icon looks as follows: ! ! What do you think ?
Looks like an improvement
Change:
override dispose(): void { super.dispose(); this.clear(); <del> this.keybindingLabel?.dispose(); </del> <ins> this.keybindingLabels.forEach(label => label.dispose()); </ins> } }

Discussion:
Version of VS Code: 1.89.0 ! Your operating system: Windows 11 List of extensions that you have installed: Happens with none installed. Reproducible steps: 1 - Open VsCode. 2 - Hover over the Show Settings Ctrl + , Watermark 3 - Hover over Find in Files Ctrl + Shift + F What you expected to see, versus what you actually saw: When hover on Ctrl + , ! When hover on Ctrl + Shift + F and any other !
This is a regression from
Does the cause some other bug?
I think we need to properly keep track of disposables.
Change:
const additionalGroups: ISettingsGroup[] = []; const toggleData = await getExperimentalExtensionToggleData(this.workbenchAssignmentService, this.environmentService, this.productService); <del> if (toggleData && groups.filter(g => g.extensionInfo).length) { </del> <ins> if (this.extensionGalleryService.isEnabled() && toggleData && groups.filter(g => g.extensionInfo).length) { </ins> for (const key in toggleData.settingsEditorRecommendedExtensions) { const extensionId = key; // Recommend prerelease if not on Stable.

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.2 OS Version: Windows 10.0..2361 Steps to Reproduce: !
Any output in the devtools console during the first load? To get to the devtools console, press Ctrl+Shift+P to open the command palette, and then run the "Developer: Toggle Developer" Tools command.
! I've found that this problem occurs when I'm not connected to the internet, and it shows up fine when connected.
I'm unable to reproduce the issue. Does it occur with extensions disabled?
yes
Got it. What must've happened last time was my device reconnected me to the Internet while I was confirming the issue.
Change:
return; } <del> await repository.createStash(message, includeUntracked); </del> <ins> try { await repository.createStash(message, includeUntracked); } catch (err) { if (/You do not have the initial commit yet/.test(err.stderr || '')) { window.showInformationMessage(l10n.t('The repository does not have any commits. Please make an initial commit before creating a stash.')); return; } throw err; } </ins> } @command('git.stash', { repository: true })

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When I don't have any commits, running doesn't do anything, there are no prompts and it can be confusing. In the output, you can see the hint given by Git. <img width="2032" alt="Xnip2022-05-15_02-45-50" src="https://user-"
Instead of a notification maybe add a clause to the command so that it is only enabled when there is an initial commit and there are changes to stash.
Change:
static readonly ACCOUNTS_VISIBILITY_PREFERENCE_KEY = 'workbench.activity.showAccounts'; <ins> private readonly groupedAccounts: Map<string, (AuthenticationSessionAccount & { canSignOut: boolean })[]> = new Map(); private readonly problematicProviders: Set<string> = new Set(); private initialized = false; private sessionFromEmbedder = getCurrentAuthenticationSessionInfo(this.credentialsService, this.productService); </ins> constructor( action: ActivityAction, contextMenuActionsProvider: () => IAction[],

Discussion:
Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !
This still reproduces
does this still repro? maybe its imperceptible to me?
Yeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?
looks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately
Yeah that seems like a reasonable ask since it goes to the extension host and back, today.
This issue has existed since 2 years! But only recently have I encountered this.
Change:
if (typeof raw.sourceReference === 'number' && raw.sourceReference > 0) { return URI.from({ scheme: DEBUG_SCHEME, <del> path, </del> <ins> path: path?.replace(/^/+/g, '/'), // #174054 </ins> query: `session=${sessionId}&ref=${raw.sourceReference}` }); }

Discussion:
This is a legit error about a bad URI that came from a debug adapter but I guess we shouldn't send telemetry
Change:
group: 'navigation/execute', when: ContextKeyExpr.and( executeNotebookCondition, <del> ContextKeyExpr.or(NOTEBOOK_INTERRUPTIBLE_KERNEL.toNegated(), NOTEBOOK_HAS_SOMETHING_RUNNING.toNegated()), </del> <ins> ContextKeyExpr.or( NOTEBOOK_INTERRUPTIBLE_KERNEL.toNegated(), NOTEBOOK_HAS_SOMETHING_RUNNING.toNegated(), ), ContextKeyExpr.and(NOTEBOOK_HAS_SOMETHING_RUNNING, NOTEBOOK_INTERRUPTIBLE_KERNEL.toNegated())?.negate(), </ins> ContextKeyExpr.equals('config.notebook.globalToolbar', true) ) }

Discussion:
On the notebook toolbar we have multiple sections of actions, and the first two are core sections: insert and execution. The Insert section is very stable and it always contains two actions: insert code and insert markdown. However the execution section has actions from both VS Code core and Jupyter extension, and with a mix use of visibility and enablement, it is not user friendly and often leads to mis-clicks. Initial state <img width="811" alt="image" src=""Start execution <img width="884" alt="image" src=""Execution fails <img width="903" alt="image" src=""Execution succeeds <img width="810" alt="image" src=""Initial state <img width="657" alt="image" src=""Start execution <img width="867" alt="image" src=""Execution fails <img width="728" alt="image" src=""Execution succeeds <img width="625" alt="image" src=""As shown above, currently only is using enablement while all others are using visibility, which can lead to change of positions for the actions and often when users want to interrupt or restart the kernel, their position changes and users click on wrong actions. cc
What are users misclicking on? From my memory, I remember Go To vs Restart. I think that "Restart" has a confirm dialog, are there other destructive actions that should also have a confirm dialog? Or, should we use enablement and have all actions always visible?
For Jupyter kernel, I ran into Go To vs Restart and sometimes Restart vs next action on the toolbar (since Go To disappears), and for non Jupyter, it's Interrupt vs Clear all outputs. It might be hard to enforce that but we could probably at least ensure the ones that are always visible won't change their position when the execution state changes. For example, if Go To only shows at the end in this group, and Run All is always replaced by "Interrupt" or "Stop", then it's less likely to mis-click.
Change:
precondition: ContextKeyExpr.and( ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), // TODO: This needs to change to check for a terminal location capable agent <del> CTX_INLINE_CHAT_HAS_AGENT </del> <ins> TerminalChatContextKeys.hasChatAgent </ins> ), run: (_xterm, _accessor, activeInstance, opts?: unknown) => { if (isDetachedTerminalInstance(activeInstance)) {

Discussion:
The context key used in terminal and notebook chat which is wrong because it signals that there is a chat participant for the editor location and it doesn't know anything about other locations.
It's now removed from the notebook side.