Change:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; import * as dom from 'vs/base/browser/dom'; import { generateUuid } from 'vs/base/common/uuid'; import { appendStylizedStringToContainer, handleANSIOutput } from 'vs/workbench/parts/debug/browser/debugANSIHandling'; import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; import { workbenchInstantiationService } from 'vs/workbench/test/workbenchTestServices'; import { LinkDetector } from 'vs/workbench/parts/debug/browser/linkDetector'; suite('Debug - ANSI Handling', () => { let linkDetector: LinkDetector; /** * Instantiate a {@link LinkDetector} for use by the functions being tested. */ setup(() => { const instantiationService: TestInstantiationService = <TestInstantiationService>workbenchInstantiationService(); linkDetector = instantiationService.createInstance(LinkDetector); }); // todo: function here test('appendStylizedStringToContainer', () => { const root: HTMLSpanElement = document.createElement('span'); let child: Node; assert.equal(0, root.children.length); appendStylizedStringToContainer(root, 'content1', ['class1', 'class2'], linkDetector); appendStylizedStringToContainer(root, 'content2', ['class2', 'class3'], linkDetector); assert.equal(2, root.children.length); child = root.firstChild; if (child instanceof HTMLSpanElement) { assert.equal('content1', child.textContent); assert(dom.hasClass(child, 'class1')); assert(dom.hasClass(child, 'class2')); } else { assert.fail(); } child = root.lastChild; if (child instanceof HTMLSpanElement) { assert.equal('content2', child.textContent); assert(dom.hasClass(child, 'class2')); assert(dom.hasClass(child, 'class3')); } else { assert.fail(); } }); /** * Apply an ANSI sequence to {@link #getSequenceOutput}. * * @param sequence The ANSI sequence to stylize. * @returns An {@link HTMLSpanElement} that contains the stylized text. */ function getSequenceOutput(sequence: string): HTMLSpanElement { const root: HTMLSpanElement = handleANSIOutput(sequence, linkDetector); assert.equal(1, root.children.length); const child: Node = root.lastChild; if (child instanceof HTMLSpanElement) { return child; } else { assert.fail(); return null; } } /** * Assert that a given ANSI sequence maintains added content following the ANSI code, and that * the provided {@param assertion} passes. * * @param sequence The ANSI sequence to verify. The provided sequence should contain ANSI codes * only, and should not include actual text content as it is provided by this function. * @param assertion The function used to verify the output. */ function assertSingleSequenceElement(sequence: string, assertion: (child: HTMLSpanElement) => void): void { const child: HTMLSpanElement = getSequenceOutput(sequence + 'content'); assert.equal('content', child.textContent); assertion(child); } test('Expected single sequence operation', () => { // Bold code assertSingleSequenceElement('x1b[1m', (child) => { assert(dom.hasClass(child, 'code-bold')); }); // Underline code assertSingleSequenceElement('x1b[4m', (child) => { assert(dom.hasClass(child, 'code-underline')); }); for (let i = 30; i <= 37; i++) { const style: string = 'code-foreground-' + i; // Foreground colour codes assertSingleSequenceElement('x1b[' + i + 'm', (child) => { assert(dom.hasClass(child, style)); }); // Cancellation code removes colour code assertSingleSequenceElement('x1b[' + i + ';39m', (child) => { assert(dom.hasClass(child, style) === false); }); } // Codes do not interfere assertSingleSequenceElement('x1b[1;4;30;31;32;33;34;35;36;37m', (child) => { assert.equal(10, child.classList.length); assert(dom.hasClass(child, 'code-bold')); assert(dom.hasClass(child, 'code-underline')); for (let i = 30; i <= 37; i++) { assert(dom.hasClass(child, 'code-foreground-' + i)); } }); // Duplicate codes do not change output assertSingleSequenceElement('x1b[1;1;4;1;4;4;1;4m', (child) => { assert(dom.hasClass(child, 'code-bold')); assert(dom.hasClass(child, 'code-underline')); }); // Extra terminating semicolon does not change output assertSingleSequenceElement('x1b[1;4;m', (child) => { assert(dom.hasClass(child, 'code-bold')); assert(dom.hasClass(child, 'code-underline')); }); // Cancellation code removes all codes assertSingleSequenceElement('x1b[1;4;30;31;32;33;34;35;36;37;0m', (child) => { assert.equal(0, child.classList.length); }); }); /** * Assert that a given ANSI sequence produces the expected number of {@link HTMLSpanElement} children. For * each child, run the provided assertion. * * @param sequence The ANSI sequence to verify. * @param assertions A set of assertions to run on the resulting children. */ function assertMultipleSequenceElements(sequence: string, assertions: Array<(child: HTMLSpanElement) => void>): void { const root: HTMLSpanElement = handleANSIOutput(sequence, linkDetector); assert.equal(assertions.length, root.children.length); for (let i = 0; i < assertions.length; i++) { const child: Node = root.children[i]; if (child instanceof HTMLSpanElement) { assertions[i](child); } else { assert.fail(); } } } test('Expected multiple sequence operation', () => { // Multiple codes affect the same text assertSingleSequenceElement('x1b[1mx1b[4mx1b[32m', (child) => { assert(dom.hasClass(child, 'code-bold')); assert(dom.hasClass(child, 'code-underline')); assert(dom.hasClass(child, 'code-foreground-32')); }); // Consecutive codes do not affect previous ones assertMultipleSequenceElements('x1b[1mboldx1b[32mgreenx1b[4munderlinex1b[0mnothing', [ (bold) => { assert.equal(1, bold.classList.length); assert(dom.hasClass(bold, 'code-bold')); }, (green) => { assert.equal(2, green.classList.length); assert(dom.hasClass(green, 'code-bold')); assert(dom.hasClass(green, 'code-foreground-32')); }, (underline) => { assert.equal(3, underline.classList.length); assert(dom.hasClass(underline, 'code-bold')); assert(dom.hasClass(underline, 'code-foreground-32')); assert(dom.hasClass(underline, 'code-underline')); }, (nothing) => { assert.equal(0, nothing.classList.length); }, ]); }); /** * Assert that the provided ANSI sequence exactly matches the text content of the resulting * {@link HTMLSpanElement}. * * @param sequence The ANSI sequence to verify. */ function assertSequenceEqualToContent(sequence: string): void { const child: HTMLSpanElement = getSequenceOutput(sequence); assert(child.textContent === sequence); } test('Invalid codes treated as regular text', () => { // Individual components of ANSI code start are printed assertSequenceEqualToContent('x1b'); assertSequenceEqualToContent('['); // Unsupported sequence prints both characters assertSequenceEqualToContent('x1b['); // Random strings are displayed properly for (let i = 0; i < 50; i++) { const uuid: string = generateUuid(); assertSequenceEqualToContent(uuid); } }); /** * Assert that a given ANSI sequence maintains added content following the ANSI code, and that * the expression itself is thrown away. * * @param sequence The ANSI sequence to verify. The provided sequence should contain ANSI codes * only, and should not include actual text content as it is provided by this function. */ function assertEmptyOutput(sequence: string) { const child: HTMLSpanElement = getSequenceOutput(sequence + 'content'); assert.equal('content', child.textContent); assert.equal(0, child.classList.length); } test('Empty sequence output', () => { const sequences: string[] = [ // No colour codes '', 'x1b[;m', 'x1b[1;;m', 'x1b[m', // Unsupported colour codes 'x1b[30;40m', 'x1b[100m' ]; sequences.forEach(sequence => { assertEmptyOutput(sequence); }); // Check other possible ANSI terminators const terminators: string[] = 'ABCDHIJKfhmpsu'.split(''); terminators.forEach(terminator => { assertEmptyOutput('x1b[content' + terminator); }); }); }); </ins>  No newline at end of file

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issue to prefill these. --- VSCode Version:1.22.1 OS Version:win10 Steps to Reproduce: use package to colorful my output (('hello')+" world") this will output string "hello world" that "hello" with color green(debug console,terminal) this work fine in v1.21.1 upgrade to v.1.22.1,it still work fine in terminal,but not work in debug console, all the text color is green,not only 'hello' terminal: ! debug console: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No yes
I also noticed this after the update. !
this seems to have broke with your pr Would you be interested in fixing this issue?
Yeah I definately can, but not for a little while. If someone else wants to take a crack at it in the mean time go right ahead!
great. Tackle it when you have time then, assigning this to May so we do not hurry.
Hey I'm working on this issue now. While I was looking at the code again, I've noticed discrepencies in the way that various ANSI codes are being handled. This, in combination with the issue that prompted my changes originally, have led to a rewrite of the whole ANSI handling function. It should be much more robust when I'm done, but I have a question regarding your preference for currently unsupported ANSI codes. This code for example is currently unsupported by us: ! Would we like to print out , or hide the code on the debug console entirely? The actions taken currently vary substantially, so I'd like to define a specific way of handling situations like this. Certain codes such as (which is completely invalid) are currently ignored, while the code mentioned above is printed to the console as .
first of all thanks for looking into this. As for what to do in that specific scenario: my preference would be to not show it because that would be consistent with some other places where we However I could also be convinced to show it if you are leaning towards that.
Sound good. Unless you think it really matters, I'm going to match all numbers from 0-107 as valid codes despite certain ranges not really being included as real ANSI codes.

() While I'm at it, I'm adding background colours as they're not currently supported. I'd like to add high-intensity colours too, but the colours all seem a bit off. I wanted to check, are there any sort of guidelines for maximum colour intensity? Certainly on the dark theme, yellow looks more like mud... !
great. Makes sense for ansi code ranges If possible try to split it in two PRs, the second one that adds background colors. As for the guidelines we do not really have them. If the color is exactly specified by ansi then there is not much we can do as we should not change it or make it lighter. fyi our designer
I haven't changed the actual colours at the moment, though I can if it's worth looking into. As stated in , the first commit in the pull request should be ignored, as it just provides the context of the other review.
Am I doing something wrong? Install Run code:No colored output: !
I believe you are doing everything right. Though we stil plan to support some missing colors, but green should probably be supported can comment more
this fails for me in Isiders but works fine when running out of source: light theme: ! dark theme: !
I can try again once there is a new insiders (though none of my changes should affect this behavior)
Probably the code relies on some source workspace detail that differs between the built and packaged product. Does it work for you if you build the packaged product locally?
Works fine out of source. Does not work in insiders and when built locally. The issue is that the output recieved from the adapter when run out of source nicely contains the anssi sequences. When using insiders the ansi characters are stripped. Assigning to also and to investiagte on the adapter side Looking at this file it seems like the same extension version is used in both cases It might be somewhere between the adapter and the UI the ansi sequences get stripped Out of source: ! Insiders: !
When running out of source the adapters are identical to the ones in Insiders (because they are loaded from the Marketplace). So it cannot be something in the adapter. (And when using an integrated or external terminal the colors show up fine too).

It is (again) the environment, stupid... When running Insiders from the command line, the colors work fine because the environment has been configured properly by a preceding login-shell or terminal emulator. And colors fail when running Insiders from the Finder where there is no preceding login-shell (and where VS Code tries to simulate the login behaviour but obviously fails for "color"). And when using an integrated or external terminal colors work fine because both run as login-shells and are terminal emulators. See for more background info in .
great catch and good anlaysis. Thanks! Should we close as duplicate then?
No, has the background info but would not fix this. Leave it open until I understand the problem (and a workaround/fix).
The npm module "colors" () relies on  and some environment variables to figure out whether colors are supported. Since the debug console in VS Code is not based on a TTY, the check fails and becomes a no-op. In addition VS Code does not define any of the environment variables used in "colors" when launched from the Finder. As a workaround we could use an undocumented "FORCECOLOR" environment variable of the "colors" module: However this workaround would only work for the "colors" module and probably not for anything else. So adding this variable to the VS Code environment automatically, doesn't help much (and I'm not planning to fix this issue on the VS Code side). I suggest that the "colors" module documents the use of and the "FORCECOLOR" variable so that the workaround becomes more obvious.