jiebi/CodeConvo huggingface dataset:
Change:
private _runTaskCommand(arg?: any): void { const identifier = this._getTaskIdentifier(arg); const type = arg && typeof arg !== 'string' && 'type' in arg ? arg.type : undefined; <del> const task = arg && typeof arg !== 'string' && 'task' in arg ? arg.task : arg === 'string' ? arg : undefined; </del> <ins> let task = arg && typeof arg !== 'string' && 'task' in arg ? arg.task : arg === 'string' ? arg : undefined; </ins> if (identifier) { this._getGroupedTasks({ task, type }).then(async (grouped) => { const resolver = this._createResolver(grouped); <ins> const tasks = grouped.all(); </ins> const folderURIs: (URI | string)[] = this._contextService.getWorkspace().folders.map(folder => folder.uri); if (this._contextService.getWorkbenchState() === WorkbenchState.WORKSPACE) { folderURIs.push(this._contextService.getWorkspace().configuration!);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: Windows 10 Steps to Reproduce: Configure keybindings with non-existant tasks, for example: configure some tasks in the workspace. press F7 and the tasks are filtered with the text , not showing the actual available tasks. This issue exists since has been . I have shortkeys for some tasks I execute quite often, but some workspaces don't have those tasks, but have other tasks. Now, when I press F7, I need to empty all the text before I can select the desired task. Either this behaviour needs to be reverted to the pre-1.70 behaviour (possibly with an option to the user), or shortkeys per workspace needs to be implemented, but this is very annoying.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I am using version 1.71.0, but the issue was introduced in version 1.70.0
the behavior of filtering with whatever task you've provided is by design, but yes you're right that when there are no results found matching that term, the input should be cleared and show all tasks
Change:
import { IWebview } from 'vs/workbench/contrib/webview/browser/webview'; import { EditorExtensionsRegistry } from 'vs/editor/browser/editorExtensions'; import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; <del> import { IWorkbenchLayoutService, Parts } from 'vs/workbench/services/layout/browser/layoutService'; </del> const $ = DOM.$;

Discussion:
<img width="726" alt="image" src="https://user-"
zindex ftw
Actually not zindex, it was introduced via is the necessary here and could we not enforce that for notebook editor? When we have clip, the widgets in code editor will be cut off on the boundries.
We do need the clip to for notebooks. Otherwise when you scroll the editor area, the notebook widget will render on top of the sidebars Not sure how the fix this though. We've want to clip everything except the editor widgets. Off the top of my head I'm not sure how to do that I think for now we should revert the clip since it's less important than widgets rendering properly. I'll create a PR that does that but also open a new issue tracking the notebook's overlaying incorrectly when the editor area is scrolled
Change:
export const GitCommandLineRegex = /git/; export const GitPushCommandLineRegex = /gits+push/; <ins> export const GitTwoDashesRegex = /error: did you mean `--(.+)` (with two dashes)?/; </ins> export const AnyCommandLineRegex = /.+/; export const GitSimilarOutputRegex = /most similar command iss*ns*([^s]{3,})/m; export const FreePortOutputRegex = /address already in use d+.d+.d+.d+:(d{4,5})|Unable to bind [^ ]*:(d{4,5})|can't listen on port (d{4,5})|listen EADDRINUSE [^ ]*:(d{4,5})/;

Discussion:
With we're getting some initial terminal quick fixes. We have a bunch more ideas, let's use this issue to track adding more at a later date when we have more information on how the feature is received.
Also want to consider the setting to disable one or more of these
The open URL one (the only one I’ve seen so far) was a really pleasant surprise and I immediately adopted it into my workflow for opening a GitHub PR after pushing a new branch. Another one I would love to see is opening files with merge conflicts: <img width="615" alt="image" src="https://user-"
great idea!
I think this can be closed since we have individual issues tracking ideas
Change:
.monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen:HOVER { color: var(--vscode-commandCenter-activeForeground); background-color: var(--vscode-commandCenter-activeBackground); <del> line-height: 18px; </del> } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center:HOVER .quickopen .action-label { background-color: transparent !important; outline-color: transparent !important; </del> <ins> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen.left { /* border,margin tricks */ margin-left: 6px; border-top-left-radius: 6px; border-bottom-left-radius: 6px; border-right: none; /* width */ width: 38vw; max-width: 600px; min-width: 32px; } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen.right { /* border,margin tricks */ margin-right: 6px; border-top-right-radius: 6px; border-bottom-right-radius: 6px; border-left: none; /* width */ width: 16px; </ins> } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.action-label.search { </del> <ins> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.action-label { height: 22px; line-height: 22px; padding: 0; background-color: transparent; </ins> display: inline-flex; text-align: center; font-size: 12px; <del> background-color: inherit; </del> justify-content: center; <del> width: calc(100% - 19px); </del> <ins> width: 100%; </ins> } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.action-label.search>.search-icon { </del> <ins> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen.left>.action-label.search>.search-icon { </ins> font-size: 14px; opacity: .8; margin: auto 3px; } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.action-label.search>.search-label { </del> <ins> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen.left>.action-label.search>.search-label { </ins> overflow: hidden; text-overflow: ellipsis; } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center .action-item.quickopen>.all-options>.action-label { text-align: center; font-size: 12px; width: 16px; border-left: 1px solid transparent; border-radius: 0; padding-right: 0; } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.command-center:HOVER .action-item.quickopen>.all-options>.action-label { border-color: var(--vscode-commandCenter-border); } </del> /* Menubar */ .monaco-workbench .part.titlebar>.titlebar-container>.menubar { /* move menubar above drag region as negative z-index on drag region cause greyscale AA */

Discussion:
hitting tab and shift tab to get to the "command center group" and then arrow keys once in that group. !
Change:
"$schema": "vscode://schemas/color-theme", "name": "Light (Visual Studio)", "colors": { <ins> "checkbox.border": "#919191", </ins> "editor.background": "#FFFFFF", "editor.foreground": "#000000", "editor.inactiveSelectionBackground": "#E5EBF1",

Discussion:
All of our ~input controls~ checkboxes in the dark & light theme need to have a 3:1 contrast ratio between its background and adjacent color in the empty state. So either the border (if it has one) or the container's background. cc
I think dropdown doesn't need 3:1 border if it won't be empty. This rule only applies to controls without text or icon inside. If it has text, then the text will be required to have 4.5:1 CCR from another rule (icon will have 3:1). Either of the content inside will satisfy the overall active indicator rule.
Gửi từ điện thoại thông minh Samsung Galaxy của tôi.
Verified with Light+ and Dark+ themes in the Settings editor. The v2 versions of those themes might have an issue, though.
Change:
1 )); <ins> Registry.as<PanelRegistry>(PanelExtensions.Panels).registerPanel(new PanelDescriptor( SearchPanel, PANEL_ID, nls.localize('name', "Search"), 'search', 10 )); </ins> class RegisterSearchViewContribution implements IWorkbenchContribution { constructor(

Discussion:
Configure search view to show in panel Open Search panel Reload window Search panel is not shown, instead debug panel is shown.
Change:
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { ILogService } from 'vs/platform/log/common/log'; import product from 'vs/platform/product/common/product'; <ins> import { IRectangle } from 'vs/platform/window/common/window'; </ins> import BaseHtml from 'vs/workbench/contrib/issue/browser/issueReporterPage'; import { IssueWebReporter } from 'vs/workbench/contrib/issue/browser/issueReporterService'; import { IIssueFormService, IssueReporterData } from 'vs/workbench/contrib/issue/common/issue';

Discussion:
atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor. in these two examples, i have one large curved secondary monitor where vs code is. open an aux window, and it spawns it in my laptop's screen. same thing if full screened on secondary monitor. different when full screen on main screen (see ) wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.
that should be possible if you provide the coordinates for where to open the window via : You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the . Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Change:
fsChunks: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.fsChunks.d.ts', handleIssueUri: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.handleIssueUri.d.ts', idToken: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.idToken.d.ts', <del> indentSize: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.indentSize.d.ts', </del> inlineCompletionsAdditions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.inlineCompletionsAdditions.d.ts', interactive: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.interactive.d.ts', interactiveUserActions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.interactiveUserActions.d.ts',

Discussion:
This API adds as a property to
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
To verify, you would need to write an extension which gets or sets the option on the current active editor. Here is the description: (it has an effect only when and defines the number of spaces that make up an indent)
Setting this is not working for me. I run this code in a command and nothing changes. But it works as a getter <img width="84" alt="image" src=""
This works for me: I the following code to the TS built-in extension: I opened a .js file which was configured with insert spaces: true (it said Spaces: 4) after 2 seconds it changes to: <img width="189" alt="image" src=""Note that indentSize can't be set if insertSpaces:false, it only makes sense when insertSpaces:true
aside from turning , to get this working in a file that already uses tabs, I had to run in the file first
Change:
for (let i = 0, len = extensionsDescriptions.length; i < len; i++) { const extensionDescription = extensionsDescriptions[i]; <del> let profileInfo: IExtensionProfileInformation | null = null; </del> <ins> let extProfileInfo: IExtensionProfileInformation | null = null; </ins> if (profileInfo) { let extensionSegments = segments[ExtensionIdentifier.toKey(extensionDescription.identifier)] || []; let extensionTotalTime = 0;

Discussion:
Issue Type: <bBug</bAfter clicking "Stop Extensions Host Profile", the profile timings don't appear in the list. VS Code version: Code 1.54.3 (, 2021-03-15T10:55:45.459Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ vscode-eslint2.1.19 EditorConfig0.16.4 go0.23.3 python2021.3. jupyter2021.3. remote-containers0.163.2 cpptools1.2.2 js-debug-nightly2021.3.2417 vs-keybindings0.2.0 vscode-github-issue-notebooks0.0.75 debugger-for-chrome4.12.12 rust0.7.8 vscode-lldb1.6.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
constructor() { super({ id: 'workbench.userDataSync.actions.acceptMerges', <del> title: localize('accept merges title', "Accept Merge"), </del> <ins> title: localize('complete merges title', "Complete Merge"), </ins> menu: [{ id: MenuId.EditorContent, when: ContextKeyExpr.and(ctxIsMergeResultEditor, ContextKeyExpr.regex(ctxMergeBaseUri.key, new RegExp(`^${USER_DATA_SYNC_SCHEME}:`))),

Discussion:
Testing This was feedback I heard from others too—"Accept Merge" is a bit strange since you aren't really accepting a merge so much as the individual changes. I think "Complete Merge" would make more sense here. <img width="265" alt="CleanShot 2022-09-27 at 11 50 56 src="https://user-"
Or maybe "Confirm Merge".
More ideas: I like this - I think "confirm" is usually used to approve an already stated intention and does not fully fit here. ideas?
"Complete Merge" and "Accept Merge" are the best options. I am leaning towards "Complete Merge". fyi
for "Complete Merge"
Change:
const dt = append(dl, $('dt')); dt.textContent = entry.text; const dd = append(dl, $('dd')); <del> this.keybindingLabel?.dispose(); this.keybindingLabel = new KeybindingLabel(dd, OS, { renderUnboundKeybindings: true, ...defaultKeybindingLabelStyles }); this.keybindingLabel.set(keys); </del> <ins> const label = new KeybindingLabel(dd, OS, { renderUnboundKeybindings: true, ...defaultKeybindingLabelStyles }); label.set(keys); this.keybindingLabels.add(label); </ins> } };

Discussion:
Version of VS Code: 1.89.0 ! Your operating system: Windows 11 List of extensions that you have installed: Happens with none installed. Reproducible steps: 1 - Open VsCode. 2 - Hover over the Show Settings Ctrl + , Watermark 3 - Hover over Find in Files Ctrl + Shift + F What you expected to see, versus what you actually saw: When hover on Ctrl + , ! When hover on Ctrl + Shift + F and any other !
This is a regression from
Does the cause some other bug?
I think we need to properly keep track of disposables.
Change:
zoomLevel: getZoomLevel(), enabledExtensions: extensionData, experiments: experiments?.join('n'), <ins> restrictedMode: !this.workspaceTrustManagementService.isWorkpaceTrusted(), </ins> githubAccessToken, }, dataOverrides); return this.issueService.openReporter(issueReporterData);

Discussion:
When I report an issue from our issue reporter from an untrusted workspace, there is no info about this in the GH issue.
Marking as important to make sure we care about this before enabling trust by default to not make our life harder for triaging issues than it needs to be.
Two examples: in an effort to make the smallest change this late in the game, I’ve put it in System Info however when you report a performance issue, we also have a section called “Workspace Info” that shows up that gives details on the workspace (like number of files, etc). I think it should eventually go there
lol jk sent a PR putting it next to the OS which I don't love... but the change is small and it means the user can't not tell us their WT situation which is good.
Change:
return findMatches; } override deltaCellDecorations() { return []; } <ins> override onDidChangeVisibleRanges = Event.None; override visibleRanges: ICellRange[] = [{ start: 0, end: 100 }]; </ins> }; return { editor: notebookEditor, viewModel };

Discussion:
From
The core might have heuristics of if/when should be called, maybe this test can be turned into a unit test first?
Was just looking at this. That might make sense too, but it also seems to make sense to test this as an API contract.
Is it going to make a difference if I move off the deprecated WorkspaceEdit api?
The issue you have mentioned with the editor service, I wonder if that could be in play here because this failure is just implying that the cell did not get rendered and initially request statusbar items. This test also doesn't make sense because it's just awaiting the same promise twice
Change:
testIndentAction(' *', ' * asdfsfagadfg * / * / * /*', '', IndentAction.None, '* '); testIndentAction('', ' */', '', IndentAction.None, null, 1); <ins> testIndentAction(' */', ' * test() {', '', IndentAction.Indent, null, 0); </ins> testIndentAction('', 't */', '', IndentAction.None, null, 1); testIndentAction('', 'tt */', '', IndentAction.None, null, 1); testIndentAction('', '   */', '', IndentAction.None, null, 1);

Discussion:
VSCode Version: 1.47.0-insider (user setup) Commit: Date: 2020-06-11T13:30:35.121Z (1 day ago) Electron: 7.3.1 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a new TS or JS file a with a generator method that has a leading multiline or JSDoc comment. NOTE: There must be a space between the token and the method name. cursor at the end of the line that starts the generator method body and press enter. Expected: new line is with the correct indentation. Actual: new line is indented to the same level as the method name and an asterisk () is as if this were a line continuation of a multiline or JSDoc comment. ! Notes: This does not occur if the method does not start with a multiline or JSDoc comment. This does not occur if there is no space between the asterisk () and the method name. This does not occur for functions (as there is a leading keyword between the start of the line and the asterisk () This does not occur for generator methods with a leading keyword before the , such as or in JS or , , , , or in TS. Does this issue occur when all extensions are disabled?: Yes
Similar to (the jsdoc comment Is required for this bug)
I am working on this
Change:
readonly outlineKind = 'notebookCells'; get activeElement(): OutlineEntry | undefined { <ins> if (this.delayedOutlineRecompute.isTriggered()) { this.delayedOutlineRecompute.cancel(); this._recomputeState(); } </ins> return this._activeEntry; } private readonly _outlineEntryFactory: NotebookOutlineEntryFactory; <del> private readonly delayRecomputeActive: () => void; </del> <ins> private readonly delayedOutlineRecompute: Delayer<void>;; </ins> constructor( private readonly _editor: INotebookEditor, private readonly _target: OutlineTarget,

Discussion:
Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro
a notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese
!
Thanks I can replicate this issue.
Giving the issue back to Aaron to verify. My Python install's a bit broken.

Testing open show outline and have sticky scroll enabled scroll the cell with "# Header " into view delete the cell :bug: the sticky scroll breaks, the error below is printed <img width="1482" alt="Screenshot 2024-04-23 at 08 51 18" src=""
I'm unable to repro this. Please can you share a screen recording of the steps. Perhaps recoding from opehning the notebook to selecting and deleting. Thanks.
Looking at the stacktrace tells me this is coming here which means the model had been already
following the steps above (empty profile) always reproduce the error (console) for me. The screen cheese shows in sticky scroll and/or other paces of the outline tree
Change:
} private async install(extension: IExtension): Promise<IExtension | undefined> { <del> const installOptions = this.getInstallOptions(); </del> try { <del> return await this.extensionsWorkbenchService.install(extension, installOptions); </del> <ins> return await this.extensionsWorkbenchService.install(extension, this.options); </ins> } catch (error) { <del> await this.instantiationService.createInstance(PromptExtensionInstallFailureAction, extension, extension.latestVersion, InstallOperation.Install, installOptions, error).run(); </del> <ins> await this.instantiationService.createInstance(PromptExtensionInstallFailureAction, extension, extension.latestVersion, InstallOperation.Install, this.options, error).run(); </ins> return undefined; } }

Discussion:
Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi
Ok was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?
Any suggestions?
We already have the "Sync Extension" check in the Extension context menu when it is installed - this is great. ! And we already have the "Sync Extension" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !
Lets try this in insiders already and see if we get any hit back.
Awesome - thanks!