jiebi/CodeConvo huggingface dataset:
Change:
} })); <del> // Set aria lable to expose split information to screen reader template.label.element.querySelector('.label-name')?.setAttribute('aria-label', ariaLabel); </del> template.label.setResource({ resource: instance.resource, name: label,

Discussion:
Testing Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this: Put for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a and not a Modify aria label of an element in case he is part of a split
We're converting this into a list next iteration , I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.
hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?
oh great that you moving to the list. You should have a correct role then. I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip. Special character is not read out now because it is not part of the aria label.
Good point
Scoped this issue down, conversion to list will be handled in
I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before. I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just
! When I inspect a split terminal tab label, it has the correct aria label.
Oh but you are setting the on the wrong HTML element You should use the so the is properly set on the element. It has to be on that element, since that element has focus and that is what the Screen Reader will read. So I think it should be fixed here
Change:
comment: "The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.nnHappy Coding!" }, { <ins> type: 'label', name: '*english-please', action: 'close', comment: "This issue is being closed because its description is not in English, that makes it hard for us to work on it. Please open a new issue with an English description. You might find [Bing Translator](https://www.bing.com/translator) useful." }, { </ins> type: 'comment', name: 'duplicate', allowUsers: ['cleidigh', 'usernamehw'],

Discussion:
When I'm tracking inbox I see a lot of issues in foreign languages that doesn't have any reproducible details. The cause might be a combination of the issue opener now knowing English well and thus not reading at all. We should have a *english-please label. When bot sees it it'll close the issue with a message and suggest user to rewrite a new issue using Bing translate. Extra: We can include a translated version of issue reporting guideline. I can do the Chinese version.
You could open a PR for if you like.
Change:
@INativeHostMainService private readonly nativeHostMainService: INativeHostMainService, @IProtocolMainService private readonly protocolMainService: IProtocolMainService, @IProductService private readonly productService: IProductService, <del> @IApplicationStorageMainService private readonly applicationStorageMainService: IApplicationStorageMainService </del> <ins> @IStateMainService private readonly stateMainService: IStateMainService </ins> ) { this.registerListeners(); }

Discussion:
This is a follow up from I would suggest to not use the storage service for process explorer state but . That is the same service we also use to store window state for workbench windows. Using storage service from the main process requires you to await the event because unlike state service, the storage service is not ready when you use it: State service is always available and can be used as a drop-in replacement. Here is where its used for windows and the key we use is , so maybe it should be .
Change:
async resolveDiffSource(uri: URI): Promise<IResolvedMultiDiffSource> { const { repositoryUri, groupId } = ScmMultiDiffSourceResolver.parseUri(uri)!; const repository = await waitForState(observableFromEvent(this, this._scmService.onDidAddRepository, () => [...this._scmService.repositories].find(r => r.provider.rootUri?.toString() === repositoryUri.toString()))

Discussion:
open a multifile diff reload window while the diff editor stores and loads it says that there are no changes yet <img width="1178" alt="Screenshot 2024-06-21 at 09 16 43" src=""
Thanks for filing! Briefly looked into it, but fixing it is a little bit more complex than I thought. The model creation is what takes a while, and during that time the multi file diff editor just has no model. It would be better if the model creation is immediate, but it has some property, that the editor could then show.
Change:
import { assign, groupBy, IDisposable, toDisposable, dispose, mkdirp, readBytes, detectUnicodeEncoding, Encoding, onceEvent, splitInChunks, Limiter, Versions, isWindows, pathEquals } from './util'; import { CancellationError, CancellationToken, ConfigurationChangeEvent, LogOutputChannel, Progress, Uri, workspace } from 'vscode'; import { detectEncoding } from './encoding'; <del> import { Ref, RefType, Branch, Remote, ForcePushMode, GitErrorCodes, LogOptions, Change, Status, CommitOptions, RefQuery } from './api/git'; </del> <ins> import { Ref, RefType, Branch, Remote, ForcePushMode, GitErrorCodes, LogOptions, Change, Status, CommitOptions, RefQuery, InitOptions } from './api/git'; </ins> import * as byline from 'byline'; import { StringDecoder } from 'string_decoder';

Discussion:
I would have expected that the command creates a repository with a branch 'main'. I was using the latest insider: This is the repository created using 'Publish to Github'
Related to
In this particular scenario we should honor the default branch setting on GitHub rather than the VS Code setting.
Change:
this.options.getOnCompositeClickAction, this.options.colors, this.options.activityHoverOptions <del> ); </del> <ins> )); </ins> compositeSwitcherBar.push(this.compositeOverflowAction, { label: false, icon: true }); }

Discussion:
Explorer focused: ! It's only working for debug: !
It seems to working for me <img width="370" alt="image" src=""Do you have any special theme, or customisations or set up? Probably try trouble shooting?
Also the state can be frozen: ! ! Same thing in dark modern. No errors in console
Here's a repro that seems reliable: the side bar narrow enough to make some of your activity icons get displaced into the ... menu. an option from that menu. Its icon appears and get selected with the underline correct. drag that icon left to position it nearer the start of the set of tabs in order for it not to get displaced onto the ... menu again. It loses its underline and even when you switch to another icon and back to this one it doesn't get underlined.
To reset, move activity bar to side, then back to top again.
Thanks for repro steps
OFF TOPIC. May I ask how to move the activity bar from left to top? Tried searching for settings and Googling, but didn't get any results.
if you're on the Insiders build you can right click the activity bar to change the position
To verify: Move activity bar to top Reduce the width of sidebar so that activity bar actions are exactly fit Switch to Debug view container. All activity bar actions moved to overflow action From overflow action, select explorer Make sure explorer is shown active
Change:
private _reconnectedTerminals: ITerminalInstance[] | undefined; taskShellIntegrationStartSequence(cwd: string | URI | undefined): string { <del> if (!this._configurationService.getValue(TaskSettingId.ShowDecorations)) { return ''; } </del> return ( VSCodeSequence(VSCodeOscPt.PromptStart) + VSCodeSequence(VSCodeOscPt.Property, `${VSCodeOscProperty.Task}=True`) +

Discussion:
I noticed this: We always want to add the sequences as it enabled command navigation, the decorations showing is purely a visual thing that hides the decoration button. So I suggest we remove the ShowDecorations check there and instead call into the terminal addon to disable the decoration.
To verify: repo (or any repo with a task that exits) the default build task to some file the test task it the test task it /ctrl+up should take you to the start of the task in step 6, not the very top of the terminal
I actually think we should remove the setting outright as we already have which essentially does the same thing. This would save us from exposing outside of the terminal part the ability to configure decoration visibility. Timeline: The terminal setting was as a boolean in Feb The task setting was in June The terminal setting was made more granular in July The interaction between the 2 settings confused someone in I'll leave the decision up to you whether we remove it, it feels like too much granularity to me as the user must like the terminal ones but not the task ones.
Let's remove it
Change:
// Since a backup did not happen, we have to confirm for // the working copies that did not successfully backup try { return await this.confirmBeforeShutdown(remainingDirtyWorkingCopies); } catch (error) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: Windows_NT x64 10.0. Auto Save by onFocusChange does not sync internal cache when direct quitting by 'X' button. Steps to Reproduce: settings: "Files: Auto Save" =onFocusChange a text file and save it somewhere. the file a little more. But this time, do not save or change focus and just press 'X' button directly to quit. the text file again with vscode. to save the file. Now you can see this error message: "Failed to save '...': The content of the file is newer." <img width="341" alt="image" src="https://user-"
That is weird, we trigger auto save on shutdown unless auto save is turned off: Does this still reproduce in all projects?
Oh nice I can reproduce, looks really like a bug.
Great catch!
Thank you for your response and effort on this issue!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
const fallbackMatchers: RegExp[] = [ // Python style error: File "<path>", line <line> /^ *File (?<link>"(?<path>.+)"(, line (?<line>d+))?)/, <ins> // Unknown tool #200166: FILE  <path>:<line>:<col> /^ +FILE +(?<link>(?<path>.+)(?::(?<line>d+)(?::(?<col>d+))?)?)/, </ins> // Some C++ compile error formats: // C:foobar baz(339) : error ... // C:foobar baz(339,12) : error ...

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.2 (user setup) OS Version: WindowsNT x64 10.0. Copied from VSCode: Version: 1.84.2 (user setup) Commit: Date: 2023-11-09T10:51:52.184Z Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0. Steps to Reproduce: at least one space in the FILE path, in my case, in the username I created... Click doesn't function due to the space. If I remove the space in terminal.integrated.wordSeparators, the beginning of the line, the "FILE " gets copied as well, ruining the entire Ctrl + Click functionality. I've been searching online to change the Windows username, but all the required steps are extremely frustrating (me hincha mucho las pelotas). In the end, the only solution seems to be creating a new user or formatting, which is even more frustrating because I need to work! I can't believe this, all because they didn't implement a Regex in terminal.integrated.wordSeparators instead of "1 character in that configuration string = 1 space". Goodness!
This is a pretty clear violation of the , consider this a warning.
I think you're saying removing space from word separators would fix this but that would not work because then would be part of the .
To verify make sure links in the format above () work correctly
Change:
const frameTimes: number[] = []; const textRenderLayer = this._xtermCore!._renderService._renderer._renderLayers[0]; const originalOnGridChanged = textRenderLayer.onGridChanged; const evaluateCanvasRenderer = () => { // Discard first frame time as it's normal to take longer frameTimes.shift(); const medianTime = frameTimes.sort((a, b) => a - b)[Math.floor(frameTimes.length / 2)]; if (medianTime > SLOW_CANVAS_RENDER_THRESHOLD) { <del> const promptChoices: IPromptChoice[] = [ { label: nls.localize('yes', "Yes"), run: () => this._configurationService.updateValue('terminal.integrated.rendererType', 'dom', ConfigurationTarget.USER) } as IPromptChoice, { label: nls.localize('no', "No"), run: () => { } } as IPromptChoice, { label: nls.localize('dontShowAgain', "Don't Show Again"), isSecondary: true, run: () => this._storageService.store(NEVER_MEASURE_RENDER_TIME_STORAGE_KEY, true, StorageScope.GLOBAL, StorageTarget.MACHINE) } as IPromptChoice ]; this._notificationService.prompt( Severity.Warning, nls.localize('terminal.slowRendering', 'The standard renderer for the integrated terminal appears to be slow on your computer. Would you like to switch to the alternative DOM-based renderer which may improve performance? [Read more about terminal settings](https://code.visualstudio.com/docs/editor/integrated-terminal#_changing-how-the-terminal-is-rendered).'), promptChoices ); </del> <ins> if (this._configHelper.config.rendererType === 'auto') { this._storageService.store(SUGGESTED_RENDERER_TYPE, 'dom', StorageScope.GLOBAL, StorageTarget.MACHINE); this.updateConfig(); } else { const promptChoices: IPromptChoice[] = [ { label: nls.localize('yes', "Yes"), run: () => this._configurationService.updateValue('terminal.integrated.rendererType', 'dom', ConfigurationTarget.USER) } as IPromptChoice, { label: nls.localize('no', "No"), run: () => { } } as IPromptChoice, { label: nls.localize('dontShowAgain', "Don't Show Again"), isSecondary: true, run: () => this._storageService.store(NEVER_MEASURE_RENDER_TIME_STORAGE_KEY, true, StorageScope.GLOBAL, StorageTarget.MACHINE) } as IPromptChoice ]; this._notificationService.prompt( Severity.Warning, nls.localize('terminal.slowRendering', 'The standard renderer for the integrated terminal appears to be slow on your computer. Would you like to switch to the alternative DOM-based renderer which may improve performance? [Read more about terminal settings](https://code.visualstudio.com/docs/editor/integrated-terminal#_changing-how-the-terminal-is-rendered).'), promptChoices ); } </ins> } };

Discussion:
Part of We should also improve the fallback logic to do this: Try webgl If it threw an exception, try canvas If frame rendering averages 50ms (existing detection), use DOM We will keep the canvas renderer around for now mainly because Safari doesn't support webgl2 and can evaluate again at a later date.
It looks like canvas is still the default for me -- the is present unless I explicitly enable experimentalWebgl. I don't see any notifications of errors that could be causing it.
Change:
this._ctxHasActiveRequest.set(false); this._zone.value.widget.updateProgress(false); this._zone.value.widget.updateInfo(''); <ins> this._zone.value.widget.updateToolbar(true); </ins> this._log('request took', sw.elapsed(), this._activeSession.provider.debugName); }

Discussion:
generate an answer tweak it press Send again (by accident) press Stop generating the Accept button is no longer visible !
Change:
assertNormalized(new Position(1, 1), 'foorbar', 'foonbar'); assertNormalized(new Position(1, 1), 'foorbar', 'foonbar'); assertNormalized(new Position(2, 5), 'foortbar', 'foon        bar'); <del> assertNormalized(new Position(2, 3), 'foortbar', 'foon      bar'); </del> <ins> assertNormalized(new Position(2, 3), 'foortbar', 'foon    bar'); </ins> assertNormalized(new Position(2, 5), 'foortbarnfoo', 'foon        barn    foo'); //Indentation issue with choice elements that span multiple lines #46266

Discussion:
Issue Type: <bBug</bPlease look this, ! Line 2: "Text" Line 3: .... This is auto indent line. ? (:, : ) ABC
I update this issue. But, It is automaticaly closed. Why? Please look this updated isuue.
What are the steps to reproduce? What is happening versus what you would expect to happen?
First line is, ( is white space, is Tab code) "Text" + -key Actual input is: (The above procedure removes the white space.) [Tab]-key, "Text", (move coursor position to the beginning of line), [Space][Space], (move coursor position to end of line), [Enter] The next cursor position is invalid. Please look the image of issue. I think, this is not serious but incorrect behavior.
Thank you for the extra information. Here are simplified steps: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain if indentation is configured with spaces, the new line will contain
Thanks.
can we have some verification steps?
Posting again with more explanations: have a file with the contents press <kbdEnter</kbdif indentation is configured with tabs, the new line will contain . <---- this is a bug, the result should be such that the second line aligns with the first line if indentation is configured with spaces, the new line will contain <--- this is a bug, the result should be such that the second line aligns with the first line
Change:
continue; } } <ins> const existing = result.get(identifier.id.toLowerCase()); if (existing?.disabled) { // Remove the duplicate disabled extension result.delete(identifier.id.toLowerCase()); } </ins> const profileExtension: IProfileExtension = { identifier, displayName: extension.manifest.displayName }; if (disabled) { profileExtension.disabled = true;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes, actually this issue has nothing to do with extensions <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.79.1 (user setup) Commit: Date: 2023-06-12T16:14:05.102Z Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: Connect to WSL(Ubuntu ) Profiles =Show Contents... <img width="286" alt="image" src=""As you can see, the extensions of the profile are duplicated. The reason I found is I installed the extensions in WSL again. Maybe It's not a bug. But, the profile should distinguish between extensions installed in the host and WSL. Maybe like this: ESLint - host Disabled ESLint - WSL So that I know which place I install the extension and its enabled/disabled status. When I open the detail page of the duplicated extensions, both of them display an "Extension is enabled on 'WSL: Ubuntu-22.04'" message. What I expect is: The extension is installed and enabled on the host, the message should be "Extension is enabled". The extension is installed and enabled on the WSL, the message should be "Extension is enabled on 'WSL: Ubuntu-22.04'". Does it make sense?
Related on Stack Overflow: .

Let me know if there's any debugging steps or details you'd like be to solicit from people in my answer there.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
what's it a duplicate of?
I am sorry, I remembered this bug and thought there is an issue already, but there is not. Reopened it.
I guess duplicate only shows for extensions installed in both local VS Code and remote hosts. !
Fixed: Contents show only one instance of the extension
Change:
}); // Only retriggers if actually found quickfix on the same line as cursor <del> return { validActions: filteredActions, allActions: codeActionSet.allActions, documentation: codeActionSet.documentation, hasAutoFix: codeActionSet.hasAutoFix, dispose: () => { codeActionSet.dispose(); } }; </del> <ins> return { validActions: filteredActions, allActions: allCodeActions, documentation: codeActionSet.documentation, hasAutoFix: codeActionSet.hasAutoFix, dispose: () => { codeActionSet.dispose(); } }; </ins> } } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Python <img width="296" alt="Screenshot 2023-11-07 at 8 00 18 AM" src=""<img width="312" alt="Screenshot 2023-11-07 at 8 00 30 AM" src=""