jiebi/CodeConvo huggingface dataset:
Change:
if (this._bannerDomNode && this._domElement.contains(this._bannerDomNode)) { this._domElement.removeChild(this._bannerDomNode); } return model; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!
Change:
import { spawn } from 'child_process'; import { TPromise } from 'vs/base/common/winjs.base'; import { assign } from 'vs/base/common/objects'; <del> import { parseArgs, helpMessage, ParsedArgs } from 'vs/code/node/argv'; </del> <ins> import { parseArgs, buildHelpMessage, ParsedArgs } from 'vs/code/node/argv'; </ins> import pkg from 'vs/platform/package'; function shouldSpawnCliProcess(argv: ParsedArgs): boolean {

Discussion:
cc Standard sized (80 width) terminal: ! This is what is was like before: !
do you have any reason against using a community lib for this if I get the deps approved?
Not at all... I just think that the hard 80 column wrap is an unnecessary remnant of the past, given the resizing capabilities of terminal emulators of today.
yeah, I believe the community libs like yargs size the column dynamically but keep formatting similar to what it was like before.
Change:
code: 'ControlRight' }, { <del> label: 'Ctrl+', ariaLabel: 'Control+', </del> <ins> label: 'Ctrl', ariaLabel: 'Control', </ins> electronAccelerator: null, <del> userSettingsLabel: 'ctrl+', </del> <ins> userSettingsLabel: 'ctrl', </ins> isWYSIWYG: true, isChord: false, dispatchParts: [null],

Discussion:
Issue Type: <bBug</bWhen using screencast mode, if you press a sequence of keys such as "Ctrl" + "Alt", Visual Studio Code adds an extra + at the end of the sequence. ! VS Code version: Code 1.42.1 (, 2020-02-11T14:45:59.656Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ 30-seconds-of-code1.0.0 better-comments2.0.5 Bookmarks11.0.0 vscode-color0.4.5 bracket-pair-colorizer1.0.61 javascript-ejs-support1.3.1 vscode-npm-script0.3.11 vsc-material-theme32.5.0 vsc-material-theme-icons1.1.4 php-intellisense2.3.14 vscode-mocha-test-adapter2.2.2 vscode-test-explorer2.17.0 python2020.2. remote-wsl0.42.3 vsliveshare1.0.1653 material-icon-theme3.9.3 java0.57.0 vscode-xml0.10.1 code-settings-sync3.4.3 vscode-spotify3.1.0 java-generate-setters-getters5.3.0 code-spell-checker1.7.24 vscodeintellicode1.2.5 vscode-java-debug0.25.0 vscode-java-dependency0.9.0 vscode-java-pack0.8.1 vscode-java-test0.22.1 vscode-maven0.21.0 change-case1.0.0 vscode-wpilib2020.2.2 viml0.0.2 material-theme3.2.3 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Isn't this an expected behavior? As it only happens with keys that can be used in combinations (Alt, Ctrl, Shift, Win ecc;)
Well I felt like that if I just press Ctrl and Alt it should say Ctrl+Alt instead of Ctrl+Alt+ as if some other letter had been pressed
Also, I can work on this issue if necessary
Verification: (Windows only) Enable Press and confirm that is displayed on the screen and not . Press and confirm that is displayed on the screen.
Change:
// Check for updates this.eventuallyCheckForUpdates(true); <del> // Always auto update builtin extensions in web if (isWeb && !this.isAutoUpdateEnabled()) { this.autoUpdateBuiltinExtensions(); </del> <ins> if (isWeb) { this.syncPinnedBuiltinExtensions(); // Always auto update builtin extensions in web if (!this.isAutoUpdateEnabled()) { this.autoUpdateBuiltinExtensions(); } </ins> } }

Discussion:
extension details page for GitHub Repositories extension in :bug: the marketplace and repository links aren't shown !
Change:
"activityBar.background": "#221a0f", "activityBar.foreground": "#d3af86", "sideBar.background": "#362712", <ins> "menu.background": "#362712", "menu.foreground": "#CCCCCC", </ins> "editor.lineHighlightBackground": "#5e452b", "editorCursor.foreground": "#d3af86", "editorWhitespace.foreground": "#a57a4c",

Discussion:
Issue Type: <bBug</bI think this change appeared in VS Code Insiders couple builds ago. New background for dropdowns in title menu bar and context menus ( is set to ) now have brighter background, which has to much contrast with editor background and makes it harder to read text on it. Also it appears much brighter than backgrounds for auto-suggestions dropdown and peek view. Is it intended change in Dark+ color theme or is it possible to revert it back to the same color as in current stable version (1.27)? Insider (left) and stable (right) ! VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-19T09:34:25.276Z) OS version: Windows_NT x64 10.0. Issue is reproducible without extensions. <details<summaryExtensions (26)</summaryExtensionVersion ------ markdown-toc1.5.6 vscode-css-modules1.0.1 spellright2.5.32 markdown-preview-github-styles0.1.3 vscode-css-modules0.2.3 bracket-pair-colorizer1.0.60 vscode-eslint1.6.0 gitlens8.5.6 remotehub0.2.0 EditorConfig0.12.4 tslint1.0.39 vscode-pull-request-github0.1.5 beautify1.4.3 rest-client0.19.1 code-fragments1.2.0 vsliveshare0.3.709 debugger-for-chrome4.10.1 debugger-for-edge1.0.5 vscode-docker0.2.0 material-icon-theme3.6.0 quicktype12.0.42 gi0.2.11 code-settings-sync3.1.2 dot0.0.1 quokka-vscode1.0.149 markdown-pdf1.2.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.459 --<!-- potentialduplicatescomment --
Change:
export class SCMViewPaneContainer extends ViewPaneContainer { constructor( <ins> @ISCMViewService private readonly scmViewService: ISCMViewService, </ins> @IWorkbenchLayoutService layoutService: IWorkbenchLayoutService, @ITelemetryService telemetryService: ITelemetryService, @IInstantiationService instantiationService: IInstantiationService,

Discussion:
Type: <bBug</bWhen there is only one instance and the Source Control Providers and Source Control Sync views are not showing, the toolbar moves to the SCM view container titlebar, and the callback of a command contributed to that menu does not receive the instance as a parameter. In other circumstances the command callback does receive the parameter. Repro: source-control-sample, build it and run it. Follow its README steps to get it contributing to the SCM view container. for the zap icon this branch adds to scm/title. it when that menu is not merged to the view container window because another view is visible too. Note the message in the modal information dialog, then dismiss it. the other view(s) and click zap again. The message is different. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-20T05:34:58.027Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Looks like this was previously reported in and subsequently fixed. are you also seeing this regression? For me it's also broken in 1.83, so not a reason to hold up the current iteration.
thank you very much for the detailed repro steps. I am also able to reproduce this the commands that the extension contributes to the menu.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
return candidate && resources.dirname(candidate) || undefined; } <del> defaultWorkspacePath(schemeFilter = this.getSchemeFilterForWindow()): URI | undefined { </del> <ins> defaultWorkspacePath(schemeFilter = this.getSchemeFilterForWindow(), filename?: string): URI | undefined { let defaultWorkspacePath: URI | undefined; </ins> // Check for current workspace config file first... if (this.contextService.getWorkbenchState() === WorkbenchState.WORKSPACE) { const configuration = this.contextService.getWorkspace().configuration; if (configuration && configuration.scheme === schemeFilter && !isUntitledWorkspace(configuration, this.environmentService)) { <del> return resources.dirname(configuration) || undefined; </del> <ins> defaultWorkspacePath = resources.dirname(configuration) || undefined; </ins> } } // ...then fallback to default file path <del> return this.defaultFilePath(schemeFilter); </del> <ins> if (!defaultWorkspacePath) { defaultWorkspacePath = this.defaultFilePath(schemeFilter); } if (defaultWorkspacePath && filename) { defaultWorkspacePath = resources.joinPath(defaultWorkspacePath, filename); } return defaultWorkspacePath; </ins> } async showSaveConfirm(fileNamesOrResources: (string | URI)[]): Promise<ConfirmResult> {

Discussion:
In web when I trigger File Save Workspace As, I am seeing an empty picker, but I would expect an experience which is more like this: !
The current behavior is to have not placeholder for the filename+extension. Having no filename is consistent with what Windows does: ! is your screen shot what you see on Mac when doing Save Workspace As in desktop?
yeah it is macOS and I think the challenge here is that the custom file dialog does not provide any dropdown for the file extension to pick. I think I would prefer if the custom file dialog would then do what macOS does.
Sounds good, I will update to add a placeholder filename+extension for save workspace as, which is not web specific.
the code for that use is here: To clarify: you would not implement a one-off solution for the "Save Workspace As..." but pick on the existing property to do so? I guess one question is how that would conflict with the property if that points to a file and not folder.
I think I would change the last line of the method here: Instead of just using the , which is what you are seeing happen, I would give it an untitled filename and the appropriate extension.
yeah works for me
Change:
return <CancelablePromise<T>>new class { cancel() { source.cancel(); <ins> source.dispose(); </ins> } then<TResult1 = T, TResult2 = never>(resolve?: ((value: T) => TResult1 | Promise<TResult1>) | undefined | null, reject?: ((reason: any) => TResult2 | Promise<TResult2>) | undefined | null): Promise<TResult1 | TResult2> { return promise.then(resolve, reject);

Discussion:
The CancelablePromise disposes its CancellationTokenSource inside a onCancellationRequested listener. That means that any other onCancellationRequested listeners that were after that one won't be called, because the EventEmitter has been disposed. In practice that means that any listener that was after an async step inside the callback function is not called. This caused issues in chat, but the function is used in many places and I think it's likely that some of those are affected. My suggested fix is in but I don't think this is safe to check in at the end of the iteration, so I will wait until December. Looks like you guys have touched this code, lmk what you think: Transferred from a private issue. Original issue discussion below <detailsa question such as "Explain recursion in detail to me" hit cancel Watch the copilot chat log, you will see the request continues and even follow ups are computed even though no tokens are shown to the user. This is a bit weird. Order of events is this: Call to get a token Attach some listeners to it, some after async steps Cancel the cancellable promise The cancellable promise disposes the token source The cancellation listeners that were after an async step don't get called because the event emitter is disposed before it can call them The last step is suspicious but I guess that's how EventEmitter works? And the cancellable promise seems like it's doing the right thing. I need to check that the same thing happens with a normal CancellationTokenSource because the logic is the same. Still not sure of the right solution. Essentially has a listener which disposes the . Listeners that were later than that first listener will not be called because the event emitter will be disposed in the middle of emitting, which is by design for EventEmitter. But there is no way to guarantee that all listeners have been called before disposing, besides something like which doesn't seem nice </details
That's a good find and something we shouldn't be doing. Looks like a regression from
Disposables and leaks are tricky... Thanks for finding this! Here is the PR that introduced this: Ironic that I introduced leaks with the goal to reduce leaks...
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.5.tgz#3900e66f10d2e506133b61d7421aab6878d32665" integrity sha512-+g+fuxAd/tkCEJ/jhdnebXKtdPrhsu4VKWNnB/3qM35GbuGQOasmYFYnKL+HYZMpbQ6YqeZcXTVg/wnCTttz0g== <del> xterm-addon-webgl@0.13.0-beta.35: version "0.13.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.35.tgz#98b5dc102583120de25c7c6e0f35cd34ab6bef98" integrity sha512-powgeb3ifEZK7zWwLJuE8YRz/Z0UzDrrVA9NTx9mH7+vWxrGt9ZgroychoeCqZBvKMofiUM5vlf1oWdSmsMfzw== </del> <ins> xterm-addon-webgl@0.13.0-beta.36: version "0.13.0-beta.36" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.36.tgz#94c0f05a1be7fd027e7d5367a623969a656fb97a" integrity sha512-HG86+KCYHNf7Pi9/ksRU9LLrMcfex1e2D6rU1NCK/p2hEiQqTALX2QnLf7BoO0Yl97671GllZvVSZvhA7/bwrA== </ins> xterm-headless@5.0.0-beta.5: version "5.0.0-beta.5"

Discussion:
I've been seeing a lot of this since last week. I assume there's another issue for it but I don't see it !
! Is this related? It keeps happening too
that's because of our improved underlining, it doesn't look at good on your font because it's drawn a bit lower in the cell though. What font is it?
Cascadia Code
With the default, still a bit off <img width="179" alt="image" src="https://user-"
thanks, that's macOS with zoom level 0?
Yeah
Default font on macOS (Menlo): <img width="228" alt="Screen Shot 2022-08-19 at 1 04 24 pm" src="https://user-"
Font size 12: <img width="148" alt="Screen Shot 2022-08-19 at 1 06 40 pm" src="https://user-"Font size 14: <img width="167" alt="Screen Shot 2022-08-19 at 1 07 06 pm" src="https://user-"Font size 16: <img width="191" alt="Screen Shot 2022-08-19 at 1 07 52 pm" src="https://user-"
Can also happen on dpr 1 (Windows 11, Hack): !
Change:
// Number if (badge instanceof NumberBadge) { if (badge.number) { <del> this.$badgeContent.text(badge.number > 99 ? '99+' : badge.number.toString()); </del> <ins> let number = badge.number.toString(); if (badge.number > 9999) { number = nls.localize('largeNumberBadge', '10k+'); } else if (badge.number > 999) { number = number.charAt(0) + 'k'; } this.$badgeContent.text(number); </ins> this.$badge.show(); } }

Discussion:
<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: 1.18.0 OS Version: MacOS 10.12.6 Steps to Reproduce: 100+ file changes in a workspace with SCM. the SCM action item badge. Feature Request: When the badge displays 99+ it's not very helpful and it clearly supports three digits being displayed because the plus is there. If there are hundreds of pending changes, it looks like it could show the exact amount without any display issues and be much more clear for users when they happen to have 100+ pending changes. If there are thousands of pending changes then this could be displayed as 1k, 2k etc.
Want to submit a PR?
can you point where in the source this filtering on count in defined?
cc
Took me a while to find it... turns out I could have just searched for "99+" hardcoded, lol
Change:
} set statusBarCommands(statusBarCommands: vscode.Command[] | undefined) { <del> this.logService.info('ExtHostSourceControl#statusBarCommands', (statusBarCommands ?? []).map(c => c.command).join(', ')); </del> <ins> this.logService.trace('ExtHostSourceControl#statusBarCommands', (statusBarCommands ?? []).map(c => c.command).join(', ')); </ins> if (this._statusBarCommands && statusBarCommands && commandListEquals(this._statusBarCommands, statusBarCommands)) { <del> this.logService.info('ExtHostSourceControl#statusBarCommands are equal'); </del> <ins> this.logService.trace('ExtHostSourceControl#statusBarCommands are equal'); </ins> return; }

Discussion:
Seeing this logged about 100 times at startup. Let's avoid stuff like this in the log level
Change:
*--------------------------------------------------------------------------------------------*/ import { Action, IAction, Separator, SubmenuAction } from 'vs/base/common/actions'; <del> import { SyncDescriptor0, createSyncDescriptor } from 'vs/platform/instantiation/common/descriptors'; </del> <ins> import { SyncDescriptor, SyncDescriptor0 } from 'vs/platform/instantiation/common/descriptors'; </ins> import { IConstructorSignature2, createDecorator, BrandedService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { IKeybindings, KeybindingsRegistry, IKeybindingRule } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { ContextKeyExpr, IContextKeyService, ContextKeyExpression } from 'vs/platform/contextkey/common/contextkey';

Discussion:
I a service injection dependency to some class and ended up with a very confusing TS error from a line that called . It turns out that you can't call it for a service with more than 8 dependencies because of how is defined. It's not a problem for me anymore because that function is barely used anywhere and I just changed to using the SyncDescriptor constructor directly. I wonder whether we should delete it or fix the definition of to have a definition that takes arbitrary #s of arguments, but I don't know what the intent of this code is. You touched this at some point maybe you know something about it.
This should be more or less adding one more of those. Tho, maybe there is newer, fancier ways in TS nowadays
That helper is only used in 1 place though. And we call directly in 200+ places. Just pointing that out too.
Assigning to who is that one user of 
What am I supposed to do?
Read this issue?
tldr; you are the only user of , either remove your usage or take ownership, e.g keep in line with its base class
I do not recall adding this method and it is outside of the history of GH, but it seems it so I let him decide to "either remove your usage or take ownership". The easiest is probably to inline it.
Change:
if (e.compactView || e.focusIndicator || e.insertToolbarPosition || e.cellToolbarLocation || e.dragAndDropEnabled || e.fontSize || e.markupFontSize || e.insertToolbarAlignment) { this._styleElement?.remove(); this._createLayoutStyles(); <del> this._webview?.updateOptions(this.notebookOptions.computeWebviewOptions()); </del> <ins> this._webview?.updateOptions({ ...this.notebookOptions.computeWebviewOptions(), fontFamily: this._generateFontFamily() }); </ins> } if (this._dimension && this._isVisible) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.0-insider (Universal) Commit: OS Version: Mac OS Monterey 12.2.1 Follow up issue to as this is a degradation in UX compared to the non-Insider version. Any input on that ? Current: ! Expected: Different columns should be aligned !
thank you for the bug report!
Change:
return false; } <del> const abbreviation = document.getText(new vscode.Range(abbreviationRange.start.line, abbreviationRange.start.character, abbreviationRange.end.line, abbreviationRange.end.character)); </del> const propertyNode = <Property>currentNode; if (propertyNode.terminatorToken && propertyNode.separator

Discussion:
Note: char disable tab after it with setting even with custom snippet the not trigger because char disable tab after it.
closedWith
Actually, reopening since I realized the extension isn't allowing the abbreviations outside of surrounding braces. the latest Emmet doesn't allow + in the expansions now, so you'd have to create custom snippets (with names that don't have +) to get that old behaviour back.
"+" Cheats| 1- 2- 3- 4- 5- 6- 7- 8- 9- 10- 11- 12- 13- 14- 15- 16- 17- 18- 19- 20- 21- 22- 23-
I'm aware there were a lot of snippets with +. The Emmet documentation website is currently outdated. See and
Sorry I didn't know that.
Verifier: verify that in an empty stylesheet document (e.g. CSS), , , , and all have an Emmet suggestion showing up.