jiebi/CodeConvo huggingface dataset:
Change:
setTimeout(() => document.body.removeChild(dragImage), 0); } <ins> this.domNode.classList.add('dragging'); </ins> this.currentDragData = new ElementsDragAndDropData(elements); StaticDND.CurrentDragAndDropData = new ExternalElementsDragAndDropData(elements);

Discussion:
See the grey row that moves up when it scrolls !
I looked into this a bit, but is this something that is within the tree code? Nothing sticks out to be surrounding us registering the drag and drop handlers when it comes to a focus, or hover rendering
The grey row is the CSS state which stays enabled throughout a native DnD, but stuck in the same position the event fired. It's arguably a browser bug. But we can eat it as a list bug. I see no other way than to disable the hover decoration while the list is being dragged from. Having both and labels is a bit confusing. Those are mutually exclusive.
Oh I always used polish to indicate something that is a small change (at least to the user) and then it's a bug because it shouldn't happen . Idk, I guess I'll stick with just bug
Change:
} .hljs-addition { <del> background-color: #144212; </del> <ins> background-color: var(--vscode-diffEditor-insertedTextBackground, rgba(155, 185, 85, 0.2)); color: rgb(155, 185, 85); </ins> display: inline-block; width: 100%; } .hljs-deletion { <del> background-color: #600; </del> <ins> background: var(--vscode-diffEditor-removedTextBackground, rgba(255, 0, 0, 0.2)); color: rgb(255, 0, 0); </ins> display: inline-block; width: 100%; }

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.0 (1.28.0) OS Version: macOS High Sierra 10.13.6 (17G65) Steps to Reproduce: a markdown file preview to the side ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.721 --- <!-- score: 0.717 --- <!-- score: 0.672 --- <!-- score: 0.651 --- <!-- score: 0.645 --<!-- potentialduplicatescomment --
Change:
icon: START_INLINE_CHAT, menu: [{ id: MenuId.EditorTitle, <del> when: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, EditorContextKeys.writable), </del> <ins> when: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_VISIBLE.toNegated(), EditorContextKeys.focus), </ins> group: 'navigation', order: -1000000, // at the very front }],

Discussion:
The editor sparkle shows unconditionally, e.g in any editor, like the extensions editor when a session is already active in the editor <img width="738" alt="Screenshot 2023-11-15 at 16 04 10" src=""
Change:
let result = [...ALL_EXTENSION_KINDS]; <del> // Extension pack defaults to workspace extensionKind </del> <ins> // Extension pack defaults to workspace, web extensionKind </ins> if (isNonEmptyArray(manifest.extensionPack) || isNonEmptyArray(manifest.extensionDependencies)) { <del> result = ['workspace']; </del> <ins> result = ['workspace', 'web']; </ins> } if (manifest.contributes) {

Discussion:
Allow installing extension packs those without code CC
To verify: Open Go to extensions view Browse for extension pack Make sure you can install this extension pack
Can you please verify this?
Verified on insiders: Version: 1.60.0-insider Commit: Date: 2021-09-01T01:33:58.665Z Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4544.0 Safari/537.36 Edg/93.0.933.1
Change:
); }); <ins> test('issue #179268: a complex edit', () => { testTokensAdjustment( [ `|export| |'interior_material_selector.dart'|;`, `|export| |'mileage_selector.dart'|;`, `|export| |'owners_selector.dart'|;`, `|export| |'price_selector.dart'|;`, `|export| |'seat_count_selector.dart'|;`, `|export| |'year_selector.dart'|;`, `|export| |'winter_options_selector.dart'|;|export| |'camera_selector.dart'|;` ], [ { range: new Range(1, 9, 1, 9), text: `camera_selector.dart';nexport '` }, { range: new Range(6, 9, 7, 9), text: `` }, { range: new Range(7, 39, 7, 39), text: `n` }, { range: new Range(7, 47, 7, 48), text: `ye` }, { range: new Range(7, 49, 7, 51), text: `` }, { range: new Range(7, 52, 7, 53), text: `` }, ], [ `|export| |'|camera_selector.dart';`, `export 'interior_material_selector.dart';`, `|export| |'mileage_selector.dart'|;`, `|export| |'owners_selector.dart'|;`, `|export| |'price_selector.dart'|;`, `|export| |'seat_count_selector.dart'|;`, `|export| |'||winter_options_selector.dart'|;`, `|export| |'year_selector.dart'|;` ] ); }); </ins> test('issue #91936: Semantic token color highlighting fails on line with selected text', () => { const model = createTextModel('                    else if ($s = 08) then 'b''); model.tokenization.setSemanticTokens([

Discussion:
This was filed at , but I believe the crash is a VS Code issue. I can reproduce the issue by doing the following: Set up a Dart SDK and install the Dart extension Open an empty folder and create a file with the following contents (and no trailing newline): Run the "Organize Imports" command VS Code immediately hangs and the cursor stops flashing, eventually reporting the crash and asking to reopen/close I ran the Dart language server from source and stripped out a lot of the capabilities to reduce the traffic. When removing the Semantic Tokens capability, the issue stops occurring, so it may be related to semantic tokens but I'm not certain. Here is the LSP log (the version running the reduced set of Dart server capabilities): Here is the crash-dump folder: Symbolicated: , though (mentioned at ) is a 404 so these may be incomplete. I've not had any luck reproducing this without the Dart extension/server by writing extension code that just applies the same edits (possibly because it requires semantic tokens) nor have I spotted anything unusual in the LSP traffic, but I'll have another go through these and post back if I figure anything out. Hopefully the crash log will help though. VS Code version:
I was able to reproduce this in an isolated test extension by just hard-coding semantic tokens and the edits: The complete code looks like this (though you'll need to contribute the "danny" language or change it.. I didn't want to reuse an existing language incase it had its own semantic tokens):
Doesn't seem to reproduce in the . However, I can observe in VS Code that LineTokens is created with unsorted offsets:
Thank you for the clean repro!
Fix LGTM, thanks! /verified
Change:
import * as vscode from 'vscode'; import * as path from 'path'; import TelemetryReporter from 'vscode-extension-telemetry'; <ins> import { MarkdownEngine } from './markdownEngine'; </ins> import DocumentLinkProvider from './documentLinkProvider'; interface IPackageInfo {

Discussion:
The current behaviour of Code's Markdown previewer when clicking a relative link is actually a bit cryptic: it attempts to open the file relative to the user's home path with the system's application of choice. This will commonly lead to errors being dispatched because the file cannot be found. If I have the following Markdown: Clicking the link will make my system attempt to open . Given that even , I strongly believe that they should be supported here. Such links should instead be relative to the markdown file's directory and open the linked file using the Code editor.
+1; opening markdown files by clicking a (relative) link in the preview would be a very powerful feature both for writing developer documentation (split into individual files by topic) for a project, but also for viewing that documentation.
Related: Is this behavior something vscode could change for its markdown preview?
Change:
const prefixOffset = prefix.length; // split instead of replace to avoid creating a new string object <del> const line = prefix + sourceLine.split(/r?n?$/, 1)[0]; </del> <ins> const line = prefix + (sourceLine.split(/r?n?$/, 1)[0] || ''); </ins> const rangeOnThisLine = ({ start, end }: { start?: number; end?: number; }) => new Range(1, (start ?? 1) + prefixOffset, 1, (end ?? sourceLine.length + 1) + prefixOffset);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes Version: 1.64.0-insider Commit: Date: 2022-01-21T13:26:52.572Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Linux x64 5.13.0-27-generic Steps to Reproduce the microsoft/vscode repository the Search sidebar, click "Open a New Search Editor" a multi-line search query: the results, blank lines are replaced with the word . (Only blank lines within the matched range are affected; blank lines in the surrounding context are rendered correctly.)
Change:
readonly memory: ComputeOptionsMemory | null; readonly outerWidth: number; readonly outerHeight: number; <del> readonly isDominatedByLongLines: boolean </del> <ins> readonly isDominatedByLongLines: boolean; </ins> readonly lineHeight: number; readonly viewLineCount: number; readonly lineNumbersDigitCount: number;

Discussion:
Currently only accepts values from which is convenient to pick from dropdown, however causes problems with fonts when there is noticeable difference between e.g. , , and because is not valid value. Recently was released which provide nicer look for value but marked as invalid. I propose to allow numeric values in addition to current enum values (for backward compatibility) accordind to Draft PR: If this request will be approved - I'll add same support to and options. Only drawback that I see at this point - it's no longer possible to pick value from dropdown in Settings editor, however text values are still suggested in JSON. UPD. As alternative it would be nice to have at least values at the end of the list of values
any chance to get feedback on this issue? Looks like I'm not the only one with similar request -
I will try to set some time aside in August. I didn't look at it because the PR is marked as a draft. I thought that a "draft PR" represents work-in-progress and is not ready for review.
it was marked as draft for 2 reasons: 1) There was no approve on this issue yet, if proposed solution will be considered and mentioned cons aren't blocker for this feature. 2) If approved - I was going to do same for terminal . Since it's not rejected at this point I can finish changes for terminal and move PR out of draft status. UPD. Implementation for is ready at this point.
It seems to accept 350 (as number) or any other number but I think it is very bogous that "300" (as string) is accepted but not "350". There is also no hit in the hover info that a string-enum and any number is OK.
Previously allowed string values etc. are left as is so users won't have problems with their existing settings (ideally there would be great to have something as migration scripts and replace it with as number and don't allow ). (as string) was never allowed before (worked but was a warning) therefore I don't see it as problem. I can check if it's or and treat it as number otherwise if necessary, however not sure how pattern validation will work in this case. Agree with hint.

I guess that text like should do the trick
OK, I guess combination of , , and + + will provide good experience - suggests values from existing enum, allows , and has adequate error message for strings like and . Will submit PR later today. Any suggestions on how to improve are welcome.
I like that. Thanks
Change:
set VSCODE_DEV= set ELECTRON_RUN_AS_NODE=1 "%~dp0..@@NAME@@.exe" "%~dp0..resourcesappoutcli.js" %* <ins> IF %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL% </ins> endlocal

Discussion:
CC <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently vscode will exit 0 if there was a problem using the --install-extension command switch, this makes tools that rely on it forced to parse stderr to verify the result. It should exit 1.
I just tried this and it exits with exit code 1 when there is an error installing extension. Can you please give us more information where it is not happening for you?
!
I clearly see the exit code 1 and installation feature is throwing an error in this case. Hence assigning to to check if he is propagating this error correctly or not
This is running through VS Code's shell scripts, I don't own anything in the pipeline that touches the code here Maybe doesn't propagate Electron's exit code -- I also see the exit code correctly on macOS
I should have clarified this is on Windows and it is in fact using so the problem is likely there. !
thank you! :)
Change:
} suite('SnippetsService', function () { <ins> const disposableStore: DisposableStore = new DisposableStore(); const context: CompletionContext = { triggerKind: CompletionTriggerKind.Invoke }; </ins> suiteSetup(function () { ModesRegistry.registerLanguage({

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Version: 1.49.0-insider Commit: Date: 2020-08-17T17:11:16.078Z (1 day ago) Electron: 9.2.0 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Darwin x64 19.6.0 Steps to Reproduce: Add the following python snippet: or PowerShell snippet: : which will cause auto-closing pair... (at this point you have where is the cursor) add a or and hit TAB or ENTER on the intellisense item NOTE THE TRAILING . Snippets and auto-closing pairs should play nice together so that the whole experience generates valid code. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Here's a javascript example for array destructuring: which gets you: when you type:
better example! A javascript example for : which gets you: when you type:
for verification, this: should get you: on insert mode replace (default is SHIFT + ENTER)
I'll note that it works fine in non-json files, but is reversed in a json file (as are the insert/replace hints in the suggestion box). W10
that seems like a separate issue not related to this fix. Can you open a new issue?
Yes, I'll open another issue.
Change:
let smartActive = active; const activeEditor = this.editorService.activeEditor; <del> if (this.configurationService.getValue('workbench.editor.centeredLayoutAutoResize') && (this.editorGroupService.groups.length > 1 || (activeEditor && activeEditor instanceof SideBySideEditorInput))) { smartActive = false; // Respect the auto resize setting - do not go into centered layout if there is more than 1 group. </del> <ins> const isSideBySideLayout = activeEditor && activeEditor instanceof SideBySideEditorInput // DiffEditorInput inherits from SideBySideEditorInput but can still be functionally an inline editor. && (!(activeEditor instanceof DiffEditorInput) || this.configurationService.getValue('diffEditor.renderSideBySide')); const isCenteredLayoutAutoResizing = this.configurationService.getValue('workbench.editor.centeredLayoutAutoResize'); if ( isCenteredLayoutAutoResizing && (this.editorGroupService.groups.length > 1 || isSideBySideLayout) ) { smartActive = false; </ins> } // Enter Centered Editor Layout

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --When in centered layout, opening a diff view in inline mode (as opposed to side-by-side mode) should not force the diff view into full editor width as it does for side-by-side diff views. This is a follow-up from where we discussed this might be a bug. Steps to Reproduce: centered layout a diff view in inline mode diff view now occupies full editor width (as if centered layout was not enabled) Demo: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
how to check if diff is in inline view? would you like to submit a PR to fix this? Code pointer
I'm afraid this is too much for me at this moment. The method is not fired when I switch from inline to side-by-side diff view and I could not figure out how to query the instance for the current display mode. Both of these events would need to be handled so that we can keep the centered layout when an inline diff is opened and we should switch to full-width layout when the diff editor's layout is switched from inline to side-by-side.
no worries, thanks for trying. Peng might give some good tips, and I might also look into this in the future.
Apologies for not mentioning that I was working on this, but I implemented a fix for this in
I was playing around with this too and managed to fix it, so I created a PR. My browser did not update so I didn't see your message, sorry for the duplicate PR :sweat_smile:
No problem! haha both our bads I guess :rofl: Next time I'll comment beforehand
Change:
return { uri, fallbackUri: uri }; } <ins> if (type === AssetType.Repository) { return { uri: null, fallbackUri: null }; } </ins> return null; }

Discussion:
Issue Id: <-ec5b-f02f-7f98-</b<br /<br /Versions <br /- 1.19.1<br /- <br /- <br /Stack <br /TypeError: Cannot read property 'uri' of null<br /)<br /)<br /)<br /)<br /)<br /)<br /)<br /)<br /)<br /)<br /
also present on 1.19.2, prevented me from installing or even viewing cjsx extension Caused by assuming here: that: is always an object and never or And it is because this has no fallback for case when is not defined. And is optional for because it's of type
Fix is in the same style as special case for default icon if icon asset is missing.
I'm forwarding this and the respective PR to you, I'm sure you'll know immediately how to review it.
Change:
"--vscode-chat-avatarBackground", "--vscode-chat-avatarForeground", "--vscode-chat-requestBorder", <ins> "--vscode-chat-requestBackground", </ins> "--vscode-chat-slashCommandBackground", "--vscode-chat-slashCommandForeground", "--vscode-chat-list-background",

Discussion:
Magnification users often zoom out to decide what they will zoom in to read. For HC themes, we should make sure there's a difference in color between requests and responses.
good idea!
There's a slight difference on high contrast dark, but there appears to be no difference with high contrast light: ! !
This is by design as the light theme is completely flat and doesn't use a secondary background colour anywhere . The main differentiator in the HC themes is the bars on the side.
Change:
const changeListener = repository.onDidChangeRepository(uri => this._onDidChangeRepository.fire({ repository, uri })); const originalResourceChangeListener = repository.onDidChangeOriginalResource(uri => this._onDidChangeOriginalResource.fire({ repository, uri })); <ins> const detectSubmodules = workspace .getConfiguration('git', Uri.file(repository.root)) .get<boolean>('detectSubmodules') as boolean; </ins> const submodulesLimit = workspace .getConfiguration('git', Uri.file(repository.root)) .get<number>('detectSubmodulesLimit') as number; const checkForSubmodules = () => { <del> if (repository.submodules.length > submodulesLimit) { </del> <ins> if (detectSubmodules && repository.submodules.length > submodulesLimit) { </ins> window.showWarningMessage(localize('too many submodules', "The '{0}' repository has {1} submodules which won't be opened automatically. You can still open each one individually by opening a file within.", path.basename(repository.root), repository.submodules.length)); statusListener.dispose(); }

Discussion:
There are some project for which I'm always greeted with a warning like this when opening them:  This is a bit annoying, as there's nothing actually "wrong" - I don't need all submodules to be auto-detected for my workflow. I tried this setting in the hopes that it would get rid of the warning: However, it doesn't actually get rid of the warning, which seems like a bug, or at least counter-intuitive behavior. Increasing does work, but as I said, I don't really need all submodules to be auto-detected, I just want the warning to go away, and I'm concerned that this has a performance impact. __ VSCode version: 
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.48 --<!-- potentialduplicatescomment --
It looks like a possible workaround is to specify both settings: The first one avoids the auto-detection, the second one gets rid of the warning.
Change:
const currentConfiguration = this._configuration; this._configuration = new Configuration(this.defaultConfiguration.configurationModel, this.policyConfiguration.configurationModel, applicationConfigurationModel, userConfigurationModel, remoteUserConfigurationModel, workspaceConfiguration, folderConfigurationModels, new ConfigurationModel(), new ResourceMap<ConfigurationModel>(), this.workspace); <del> if (this.initialized) { </del> <ins> this.initialized = true; if (trigger) { </ins> const change = this._configuration.compare(currentConfiguration); this.triggerConfigurationChange(change, { data: currentConfiguration.toData(), workspace: this.workspace }, ConfigurationTarget.WORKSPACE); <del> } else { this.initialized = true; </del> } this.updateRestrictedSettings();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Windows 11 x64 Steps to Reproduce: an extension that implements a FileSystemProvider and serves a file containing a setting. a workspace that uses this FSP. that the setting has no effect until the workspace is reloaded. I will prepare a branch of fsprovider-sample to demonstrate the issue.
Repro steps: project () and VSIX (). an empty profile and install the VSIX into it. no folder or workspace open, run . Explorer find and open that though this specifies a font size of 24 it is displayed in the default font size. and observe that the font size is now correct. !
/assign I will submit a PR to fix this.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified