jiebi/CodeConvo huggingface dataset:
Change:
export function register( selector: DocumentSelector, <ins> language: LanguageDescription, </ins> client: ITypeScriptServiceClient, fileConfigurationManager: FileConfigurationManager, ) {

Discussion:
!
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Why has this been marked out of scope? This is a feature that was .
facing the same
Same problem here. This IS crucial for big projects.
To verify: renames should rename matching tags now. Test on both html tag names () and custom components () you change , then renaming custom components should instead renaming all references to that component
Change:
private _subscriptions: IDisposable[] = []; private _isPressed: boolean; private static instance: AlternativeKeyEmitter; <ins> private _suppressAltKeyUp: boolean = false; </ins> private constructor(contextMenuService: IContextMenuService) { super();

Discussion:
Issue Type: Bug the Menu Bar to be hidden +Click on one of the editor/title toolbar buttons (for example in GitLens if you Alt+Click on the Blame button it will show the recent changes rather than the blame) :bug: Observe that when you let go of the key the menu bar will toggle back on FYI, I have a PR ready to submit for this VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-26T05:18:08.801Z) OS version: Windows_NT x64 10.0. <details<summarySystem Info</summary </detailsReproduces without extensions <!-- generated by issue reporter --
thanks for your PR, however let's first get the bug straigthend out. explorer. alt key, trigger context menu -notice there is "Delete Permanently" go of the all key -notice there is "Delete Permanently" still there. I just verified on windows. Is this unexpected for you? Becuase it behaves just fine for me. Or is the issue only visible for extensions? Is step 1. really needed to repro? If yes how do you hide the Menu Bar fyi
I can repro my issue on Windows/Linux - but the Menu Bar must be hidden (View -Toggle Menu Bar). Hold down and click on any of these icons (granted only the GitLens one actually has an alternate command) ! When you let go of the key it will cause the Menu Bar to be shown. As for your issue, I can't even get a context menu to show up while holding down -- well it shows for a second and disappears. And that doesn't matter if the menu bar is hidden or not.
This seems to be an issue with the alt key on windows and this feels like a duplicate of
the issue you mentioned, yes -- that is a duplicate of , but the issue I mentioned is not. There is no issue with the key not working. It it just that if you hide the menu bar (on Windows/Linux) you can use the key alone to toggle it on and off. Which is perfectly fine and as-designed.

But if you attempt to on an item in a "toolbar" (see the image in my previous post), the leaks through that click (the command works fine, mind you) so that not only does the command run, but the menu bar toggles (and it drives me NUTS ). There was similar work done to stop this from happening when +clicking in the editor here:
Ok thanks for more info. fyi
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
this.clearDecorations(); } <ins> private _clearPlaceholder(): void { this._placeholderDecoration?.dispose(); this._placeholderDecoration = undefined; } </ins> public clearDecorations(): void { <del> if (this._placeholderDecoration) { this._placeholderDecoration.marker.dispose(); this._placeholderDecoration.dispose(); this._placeholderDecoration = undefined; } </del> <ins> this._placeholderDecoration?.marker.dispose(); this._clearPlaceholder(); </ins> for (const value of this._decorations.values()) { value.decoration.dispose(); dispose(value.disposables);

Discussion:
!
Think I saw this today
that was when I here, which causes other issues so i'm removing
working on it
repro is to create some decorations via commands and then delete the terminal
Change:
} private updateWorkbenchIndicators(trusted: boolean): void { <del> const isInVirtualWorkspace = isVirtualWorkspace(this.workspaceContextService.getWorkspace()); </del> const isEmptyWorkspace = this.workspaceContextService.getWorkbenchState() === WorkbenchState.EMPTY; <del> const bannerItem = this.getBannerItem(isInVirtualWorkspace, !trusted); </del> <ins> const bannerItem = this.getBannerItem(!trusted); </ins> if (!isEmptyWorkspace || this.showIndicatorsInEmptyWindow) { this.updateStatusbarEntry(trusted); if (bannerItem) { <del> if (!isInVirtualWorkspace) { if (!trusted) { this.bannerService.show(bannerItem); } else { this.bannerService.hide(BANNER_RESTRICTED_MODE); } } else { </del> <ins> if (!trusted) { </ins> this.bannerService.show(bannerItem); <ins> } else { this.bannerService.hide(BANNER_RESTRICTED_MODE); </ins> } } }

Discussion:
The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.
FYI
Change:
class CheckoutRemoteHeadItem extends CheckoutItem { <del> override get label(): string { return this.ref.name || this.shortCommit; } </del> <ins> override get label(): string { return `$(git-branch) ${this.ref.name || this.shortCommit}`; } </ins> override get description(): string { return localize('remote branch at', "Remote branch at {0}", this.shortCommit); }

Discussion:
<img width="128" alt="CleanShot 2022-06-24 at 07 47 19 src="https://user-"<img width="230" alt="CleanShot 2022-06-24 at 07 47 05 src="https://user-"<img width="209" alt="CleanShot 2022-06-24 at 07 48 13 src="https://user-"
Added icons to all the entries so that the quick pick items are consistent. <img width="714" alt="image" src="https://user-"
I wouldn't add icons for every entry as it can get busy/repetitive. and I were just discussing about reducing the repetition of icons in quick picks and only showing them for the ones that really warrant it. <img width="488" alt="CleanShot 2022-06-24 at 12 23 12 src="https://user-"
FYI was suggesting removing the regular branch icons which it doesn't look like the change does. That would align closer with how tasks use icons (defaults are hidden) and the new debug console quick access for example.
This particular quick pick contains items of different types (ex: local branch, remote branch, tag). The only was to distinguish the type if to look at the description of the icon. I think that having an icon for each item based on its type is actually helpful here. I would like to keep it and see what the user feedback will be.
Just by looking at the icons, I'm only seeing the "locked" branch as the different one from the others. There is no difference between the local and remote branches here so I'm not seeing the benefit of showing the icon every single time and still feels very noisy: <img width="335" alt="CleanShot 2022-07-11 at 08 19 54 src="https://user-"
Reopening to track discussion
Here is what I am seeing if I am running a search for "release". I can clearly differentiate between tags, locked branches, and branches. if I would have a suitable icon for a remote branch, I would be happy to add it.

I personally still feel that there is value in showing an icon for item, especially that I think the way people interract with the branch picker is that they open it and start typing in the input to filter down to the item that they would like to open. <img width="728" alt="image" src="https://user-"
We could try to add an overlay on the branch icon, similar to VS: <img width="118" alt="CleanShot 2022-07-13 at 07 59 57 src="https://user-"
Love it! If you add this icon, I am happy to place this in the picker to indicate remote branches.
Closing this issue as I have the icon for remote branches.
Change:
} // https://git-scm.com/docs/git-check-ignore#git-check-ignore--z <del> const child = this.repository.stream(['check-ignore', '-z', '--stdin'], { stdio: [null, null, null] }); </del> <ins> const child = this.repository.stream(['check-ignore', '-v', '-z', '--stdin'], { stdio: [null, null, null] }); </ins> child.stdin.end(filePaths.join('0'), 'utf8'); const onExit = (exitCode: number) => {

Discussion:
<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version 1.31.1 OS Version: Majove 10.14.3 Steps to Reproduce: the following files: /test/.gitkeep the following rules to .gitignore In the explorer file is grayed out even though git recognises it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
Just wanted to report this issue. The changes in the file will be reported in the git tab but it will be greyed out as well. On the explorer tab, there would be a letter indicating the change but still greyed out.
This issue is related: . According to it is caused by a bug in .
fixed via
Change:
} } <ins> export class DeleteInsideWord extends EditorCommand { constructor() { super({ id: 'deleteInsideWord', precondition: EditorContextKeys.writable }); } public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void { if (!editor.hasModel()) { return; } const wordSeparators = getMapForWordSeparators(editor.getOption(EditorOption.wordSeparators)); const model = editor.getModel(); const selections = editor.getSelections(); const commands = selections.map((sel) => { const deleteRange = WordOperations.deleteInsideWord(wordSeparators, model, sel); return new ReplaceCommand(deleteRange, ''); }); editor.pushUndoStop(); editor.executeCommands(this.id, commands); editor.pushUndoStop(); } } </ins> registerEditorCommand(new CursorWordStartLeft()); registerEditorCommand(new CursorWordEndLeft()); registerEditorCommand(new CursorWordLeft());

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The 'deleteWordLeft' command cannot delete letters on right side of the cursor. We want new function which can delete the whole word. (We submit this issue formally. Sorry.)
To verify, please look for a "Delete Word" action that you can bind to a keybinding if you wish to. The action will delete the current word under the cursor (both to the left and to the right of the cursor) and will delete any trailing whitespace.
I've checked. I could find the "Delete Word" action and bind a keybinding to it. The function works properly. Thank you!
Change:
import { Registry } from 'vs/platform/registry/common/platform'; import { TreeView, TreeViewPane } from 'vs/workbench/browser/parts/views/treeView'; import { Extensions, ITreeItem, ITreeViewDataProvider, ITreeViewDescriptor, IViewsRegistry, TreeItemCollapsibleState, TreeViewItemHandleArg, ViewContainer } from 'vs/workbench/common/views'; <del> import { EDIT_SESSIONS_DATA_VIEW_ID, EDIT_SESSIONS_SCHEME, EDIT_SESSIONS_SHOW_VIEW, EDIT_SESSIONS_SIGNED_IN, EDIT_SESSIONS_SIGNED_IN_KEY, EDIT_SESSIONS_TITLE, IEditSessionsStorageService } from 'vs/workbench/contrib/editSessions/common/editSessions'; </del> <ins> import { EDIT_SESSIONS_DATA_VIEW_ID, EDIT_SESSIONS_SCHEME, EDIT_SESSIONS_SHOW_VIEW, EDIT_SESSIONS_TITLE, IEditSessionsStorageService } from 'vs/workbench/contrib/editSessions/common/editSessions'; </ins> import { URI } from 'vs/base/common/uri'; import { fromNow } from 'vs/base/common/date'; import { Codicon } from 'vs/base/common/codicons';

Discussion:
Testing I would expect that this action always appears in the command palette. Today, it only appears after running or first.
Change:
} private onEditSettingClicked(editPreferenceWidget: EditPreferenceWidget<IIndexedSetting>, e: IEditorMouseEvent): void { <ins> EventHelper.stop(e.event, true); </ins> const anchor = { x: e.event.posx, y: e.event.posy + 10 }; const actions = this.getSettings(editPreferenceWidget.getLine()).length === 1 ? this.getActions(editPreferenceWidget.preferences[0], this.getConfigurationsMap()[editPreferenceWidget.preferences[0].key]) : editPreferenceWidget.preferences.map(setting => new ContextSubMenu(setting.key, this.getActions(setting, this.getConfigurationsMap()[setting.key])));

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --From but he wasn't willing to open his issue. Left click is broken but right click works. It's introduced in 1.34.0. I can reproduce it by upgrading from 1.33.1 to 1.34.0. Is it by designed that only right click works? <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.34.0 and 1.35.0 OS Version: Windows 10 1903 and Windows 7 and Debian 10 Steps to Reproduce: The same as <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <details</details
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.455 --<!-- potentialduplicatescomment --
Now I can reproduce it. You can disable custom menus with to work around it if that helps
Yes, takes effects.
I pushed a PR to fix this but in a duplicated issue (just found this one sorry about the duplicate)
Tried the latest insider version, works.

Steps to Reproduce: settings JSON editor click on any next to a setting context menu shown If I use right click, context menu does show. Related to
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.624 --- <!-- score: 0.498 --- <!-- score: 0.462 --- <!-- score: 0.447 --<!-- potentialduplicatescomment --
My bad. This is a duplicate of
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
Change:
} // Update the window controls immediately based on cached values <del> if (useCustomTitleStyle && ((isWindows && useWindowControlsOverlay(this.configurationService, this.environmentMainService)) || isMacintosh)) { </del> <ins> if (useCustomTitleStyle && ((isWindows && useWindowControlsOverlay(this.configurationService)) || isMacintosh)) { </ins> const cachedWindowControlHeight = this.stateMainService.getItem<number>((CodeWindow.windowControlHeightStateStorageKey)); if (cachedWindowControlHeight) { this.updateWindowControls({ height: cachedWindowControlHeight });

Discussion:
I tried enabling it in my Code-OSS settings but it didn't seem to work. The sentence from that I quoted make me think it had been hardwired off in Code-OSS. I haven't searched the codebase yet though. Originally posted by in
OSS does seem to have the WCO disabled. says that WCO was disabled in OSS due to upstream issues, but there's been a bunch of fixes recently, so it's probably OK to enable it again.
Verification steps: the WCO in OSS by enabling the setting. VS Code when prompted and change the colour theme. Windows 11, one can verify the WCO has been enabled by checking that the snap layout UX is available. On Windows 10, one can verify the WCO has been enabled by switching through colour themes and checking that the area with the minimize/maximize/close buttons updates its colours before the rest of the titlebar does.
Change:
return instance; } <ins> async revealTerminal(source: ITerminalInstance, preserveFocus?: boolean): Promise<void> { if (source.target === TerminalLocation.Editor) { await this._terminalEditorService.revealActiveEditor(preserveFocus); } else { await this._terminalGroupService.showPanel(); } } </ins> async revealActiveTerminal(preserveFocus?: boolean): Promise<void> { const instance = this.activeInstance; if (!instance) { return; } <del> if (instance.target === TerminalLocation.Editor) { await this._terminalEditorService.revealActiveEditor(preserveFocus); } else { await this._terminalGroupService.showPanel(); } </del> <ins> await this.revealTerminal(instance, preserveFocus); </ins> } setEditable(instance: ITerminalInstance, data?: IEditableData | null): void {

Discussion:
Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
In this scenario, focus also fails.
I can confirm that fixes the problem for me. Thanks!
Change:
} return false; }); <ins> } else if (category === '') { console.log('Possible Categories: '); categories.forEach(category => { console.log(category); }); return; </ins> } extensions.forEach(e => console.log(getId(e.manifest, showVersions))); }

Discussion:
Testing More of a feature request, it would be great if you didn't supply a category when running that it would print out a list of categories available (like below). I could always go to the extension viewlet and run but that's an extra step and would be nice to show the options inline. <img width="276" alt="image" src="https://user-"
Also tried running this for extension packs and tried to guess the format, printing out the category names would've helped here: <img width="604" alt="image" src="https://user-"

Testing When entering a category that does not exists (e.g. 'theme' instead of 'themes') then there is no feedback that the category does not exist.
Change:
folding: { offSide: true } <del> }); </del> <ins> }, 0); </ins>

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --We have started to get reports from users that Toggle Line Comments does the wrong thing: I think this stems from the default Clojure extension which sets to be a single . Calva changes this here: This has been working for years, and still does for many people, but some days ago it stopped working for some. I also notice that the default extension has moved to its own repository, where there is now a PR to fix the line comment configuration: However, I think it is wrong that the default extension sometimes overrides an installed extension here. Then that API can't be trusted at all. I worry about what more configuration is now sometimes being overridden. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.52.1 OS Version: N/A Steps to Reproduce: Calva a file the command Toggle Line Comment on an uncommented line Expected: It gets commented with Actual: It gets commented with Please let me know how I can assist in fixing this issue. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Not applicable
I am surprised that this ever worked reliably, it must have been some amazing timing luck. defines a language configuration at . Language configuration file handling is implemented by waiting for the language to be first used (like embedded in another language like a markdown fence or a file using the language is opened) and then reading async the language configuration file and applying it. This is done . Whenever the language configuration file finishes reading, it will go and configure the in pretty much the exact same way an extension calling configures it . So deep down there is no difference between those two calls and basically those two calls are racing themselves and it is lucky that until now the call reading the descriptive file was always faster than the imperative call from your extension. If you want to be sure to overwrite the builtin language configuration, you can define your own language configuration file using: But I also see how you would expect that the imperative call would "win" over the descriptive way, so maybe we can do something on our side to give a higher priority to the imperative call way of configuring languages.
Thanks !

This is great information. Calva has been relying on this luck for a very long time. And yes, I actually choose to do it the imperative way very consciously, assuming it was the way to be sure I could override the defaults.
Change:
run(): TPromise<any> { this.extensionsWorkbenchService.open(this.extension); <ins> alert(localize('installExtensionStart', "Installing extension {0} started. An editor is now open with more details on this extension", this.extension.displayName)); </ins> return this.install(this.extension); } private install(extension: IExtension): TPromise<void> { <del> return this.extensionsWorkbenchService.install(extension).then(null, err => { </del> <ins> return this.extensionsWorkbenchService.install(extension).then(() => { alert(localize('installExtensionComplete', "Installing extension {0} is completed. Please reload Visual Studio Code to enable it.", this.extension.displayName)); }, err => { </ins> if (!extension.gallery) { return this.notificationService.error(err); }

Discussion:
Environment Details: VSCode Version : 1.24.1 OS Version : Win10 Additional Details: ScreenReader Version: NVDA2018.2 Repro Steps: VS Code while NVDA is ON. to View menu and Select Extensions. something in the Search Textbox and tab till install button. Actual: When we Click on install button, the text above the button changes..i.e.(installing) which is not read by the screenreader and after installing, a Reload button appears and also a icon which is not informed by the screenreader and after pressing tab key focus does not move on the text which has installed,it goes somewhere else. Expected: NVDA should announce some information about the reload button and should also read the "installing" when it is getting installed and focus should go on the very first item which has got installed. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: User will not be able to know about the controls which has appeared after installing the particular extensions. Attachment for Reference: Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.588 --- <!-- score: 0.526 --- <!-- score: 0.462 --- <!-- score: 0.458 --- <!-- score: 0.451 --<!-- potentialduplicates_comment --
Makes sense. This sounds as easy as an aria alert based on the state of the installation. I would expect at least a notification once the instalation is done so the user is reminded that a reload is necessery. Feels low hanging, assigning to July
do we plan to tackle this in September? It would be great since we depend on this one for a better accessibility score?
Yes, this is for September
Note to verifier: Also test cases of uninstall and update and ensure that appropriate text is read out. Ensure that the need to reload VS Code is also mentioned