jiebi/CodeConvo huggingface dataset:
Change:
} } })); <ins> disposables.add(quickPick.onDidHide(() => { quickPick.dispose(); resolve(false); })); </ins> this._calculdateKernelSources(editor).then(quickPickItems => { quickPick.items = quickPickItems; if (quickPick.items.length > 0) {

Discussion:
Steps to repro: a new instance of VS Code (no extension installed) an ipynb file running a cell out of extension installation suggestion Cell is still "running" and cannot stop execution (Expected: Cell execution is stopped or can be stopped by clicking )
Change:
title: localize('notebookActions.splitCell', "Split Cell"), menu: { id: MenuId.NotebookCellTitle, <del> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_CELL_TYPE.isEqualTo('code'), NOTEBOOK_EDITOR_EDITABLE, NOTEBOOK_CELL_EDITABLE, InputFocusedContext), </del> <ins> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_EDITOR_EDITABLE, NOTEBOOK_CELL_EDITABLE, InputFocusedContext), </ins> order: CellToolbarOrder.SplitCell, group: CELL_TITLE_GROUP_ID }, icon: { id: 'codicon/split-vertical' }, keybinding: { <del> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_CELL_TYPE.isEqualTo('code'), NOTEBOOK_EDITOR_EDITABLE, NOTEBOOK_CELL_EDITABLE, InputFocusedContext), </del> <ins> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_EDITOR_EDITABLE, NOTEBOOK_CELL_EDITABLE, InputFocusedContext), </ins> primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_BACKSLASH), weight: KeybindingWeight.WorkbenchContrib },

Discussion:
! Most likely an oversight, we should create a color token for this so that it's themeable. Found .
Change:
await this.createProcessTree(processRoots); } else { this.tree.setInput({ processes: { processRoots } }); <ins> this.tree.layout(window.innerHeight, window.innerWidth); </ins> } this.requestProcessList(0);

Discussion:
! The process explorer has both the window scrolling and list view scrolling. When window resizes, the list/tree view is not laid out properly and it's then impossible to view some rows.
Should be fixed now.
This was part of
Change:
} public getAriaLabel(): string { <del> return nls.localize('entryAriaLabel', "{0}, terminal picker", this.getLabel()); </del> <ins> return nls.localize('termEntryAriaLabel', "{0}, terminal picker", this.getLabel()); </ins> } public run(mode: Mode, context: IEntryRunContext): boolean { if (mode === Mode.OPEN) { <del> return this.runOpen(context); </del> <ins> setTimeout(() => { this.terminalService.setActiveInstanceByIndex(parseInt(this.label.split(':')[0], 10) - 1); this.terminalService.showPanel(true); }, 0); return true; </ins> } return super.run(mode, context); } <ins> } </ins> <del> private runOpen(context: IEntryRunContext): boolean { setTimeout(() => { this.open(); }, 0); </del> <ins> export class CreateTerminal extends QuickOpenEntry { </ins> <del> return true; </del> <ins> constructor( private label: string, private terminalService: ITerminalService ) { super(); } public getLabel(): string { return this.label; } public getAriaLabel(): string { return nls.localize('termCreateEntryAriaLabel', "{0}, create new terminal", this.getLabel()); } public run(mode: Mode, context: IEntryRunContext): boolean { if (mode === Mode.OPEN) { setTimeout(() => { const newTerminal = this.terminalService.createInstance(); this.terminalService.setActiveInstance(newTerminal); this.terminalService.showPanel(true); }, 0); return true; } return super.run(mode, context); </ins> } }

Discussion:
VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-04T17:43:56.658Z) OS Version: Darwin x64 16.7.0 After having used the terminal switcher for a few days, I realize that I'm always assuming that the keyboard focus moves when I change the active terminal, same what happens when using from the command pallet. As it doesn't I often end up doing the wrong thing, i.e. type shell commands in the open editor, etc. Steps to Reproduce: two terminals and one editor the keyboard focus in the editor to change the visible terminal typing -the editor content is being modified <!-- Launch with to check. --Reproduces without extensions: Yes
Change:
if (!prevState.equals(currState)) { this._isCursorUndo = true; this._editor.setSelections(prevState.selections); <ins> this._editor.revealRangeInCenterIfOutsideViewport(prevState.selections[0], ScrollType.Smooth); </ins> this._isCursorUndo = false; return; }

Discussion:
VSCode Version: Code 1.15.0 (, 2017-08-09T20:16:06.988Z) OS Version: Windows_NT ia32 10.0. Extensions: ExtensionVersion ------ html-snippets0.1.0 vscode-javascript-snippet-pack0.1.5 path-intellisense1.4.2 vscode-weapp-api0.1.8 vscode-wxml0.1.9 githistory0.2.3 vscode-html-css0.1.7 vue-snippets0.1.2 beautify1.1.1 output-colorizer0.1.2 path-autocomplete1.6.1 vue0.1.5 vetur0.9.3 vue-beautify2.0.4 java0.8.0 code-settings-sync2.8.2 stylelint0.28.0 JavaScriptSnippets1.4.1
Does this issue occur when launching VS Code with extensions disabled () ?
My extensions are enable. I had recorded the steps with screenshots. , the cursor in line 480 ! , the curson in line 177 ! , I click and the cursor in the previous line 480, but the scroll bar had not scroll. !
And the don't support cross editor tab
cursorUndo is designed to not cross-tab. Go Back/Go Forward will cross tabs, but it will omit small selection changes.
Change:
}, { "view": "scm", <del> "contents": "%view.workbench.scm.missing.guide.windows%", </del> <ins> "contents": "%view.workbench.scm.missing.guide.linux%", </ins> "when": "config.git.enabled && git.missing && config.git.experimental.installGuide == download && isLinux" }, {

Discussion:
Issue Type: <bBug</binstall of VSCode via Ubuntu Software app VSCode Source Control "Download Git for Windows" - expected "Download Git for Linux" VS Code version: Code 1.65.2 (, 2022-03-10T15:36:26.048Z) OS version: Linux x64 5.13.0-37-generic snap Restricted Mode: No <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Attempting to reproduce using https://6080-traversaro-gitpodubuntu2-
could you please post a screenshot/gif? Thank you!
The button in the Source Control menu which says "Download Git for Windows" directs the user to the . However, the popup in the lower-right corner directs the user to the . !
is this something that you could take a look at? Thank you!
Text source appears to be here.
Found the source of the problem.
Bug introduced in
Thanks for submitting a fix.
You're welcome.
The button now says "Download Git for Linux", which is correct, but it links to the page for downloading Git on OS X.
Does it ever end?
Turtles all the way down Looks like fixed this in his commit
Change:
constructor() { super({ id: 'merge.goToNextConflict', <del> title: localize('merge.goToNextConflict', "Merge Editor: Go to Next Conflict"), </del> <ins> category: localize('mergeEditor', "Merge Editor"), title: localize('merge.goToNextConflict', "Go to Next Conflict"), </ins> icon: Codicon.arrowDown, menu: [{ id: MenuId.EditorTitle,

Discussion:
While working on I noticed that some of the UI elements (and maybe other things?) are not registered as disposable, and thus may leak when the merge editor is freed from an editor group that closes. For example the and all input views seem to not dispose.
Hm, I think also the merge model, I suggest to do a pass and register as appropiate.
Change:
linkify: true, highlight: (str: string, lang?: string) => { if (lang) { <del> return `<code class="vscode-code-block" data-vscode-code-block-lang="${markdownIt.utils.escapeHtml(lang)}">${markdownIt.utils.escapeHtml(str)}</code>`; </del> <ins> return `<div class="vscode-code-block" data-vscode-code-block-lang="${markdownIt.utils.escapeHtml(lang)}">${markdownIt.utils.escapeHtml(str)}</div>`; </ins> } <del> return `<code>${markdownIt.utils.escapeHtml(str)}</code>`; </del> <ins> return markdownIt.utils.escapeHtml(str); </ins> } }); markdownIt.linkify.set({ fuzzyLink: false });

Discussion:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) Using triple backticks with language specifiers (e.g., "bash") displays two additional lines (before and after the code block) starting with a vertical bar (sort of opening and closing parentheses) For example, the following markdown: It is displayed with the additional markers; see screenshot: <img width="494" alt="image" src=""In Jupyter (or Jupyter-Lab) these markers are not displayed Version: 1.85.1 (user setup) Commit: Date: 2023-12-13T09:49:37.021Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0. v2023.11. No response Python 3.11 python: v2023.22.1 No response Remote
It also doesn't look great with the language removed, those bars are still rendered but on the same lines: !
I believe this has already been fixed in VS Code insiders: !
Oh actually still broken for notebooks but fixed for normal markdown. Will also port fix to notebooks
<img width="733" alt="image" src=""looks good!
Change:
} resizePart(part: Parts, sizeChangeWidth: number, sizeChangeHeight: number): void { <del> const sizeChangePxWidth = this.workbenchGrid.width * sizeChangeWidth / 100; const sizeChangePxHeight = this.workbenchGrid.height * sizeChangeHeight / 100; </del> <ins> const sizeChangePxWidth = Math.sign(sizeChangeWidth) * computeScreenAwareSize(Math.abs(sizeChangeWidth)); const sizeChangePxHeight = Math.sign(sizeChangeHeight) * computeScreenAwareSize(Math.abs(sizeChangeHeight)); </ins> let viewSize: IViewSize;

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The resize steps when using the / commands / shortcuts are pretty heavy. Being a keyboard driven navigator through the editor I would love to have an option to determine the step size for those commands, because I think this way no users would need to compromise. If it's needed, I would put my bit of work into that if you would like to have such an option. Even if there shall not be an option, it would be marvelous of you to reduce the current default step size by just 1 percent. This keeps it still fairly big if someone prefers those step sizes but already allows more precise resizing with the keyboard so the view / splits can fit one's needs. Basically: to Imho even smaller step sizes would be better
seems like a fair request
After thinking about this, I decided to move away from using view percentage increments. Instead, we now use css px units so that the resize increments are consistent. The newly chosen increment size is ~equivalent to 5.5% of a 1080px width monitor.
Great to read. Thank you!
I run vscode on a 27" 1440p monitor in vertical orientation, and after a recent vs code upgrade now my command is increasing the terminal height by only 1 line, instead of ~10 lines like before. Is that expected from this change? The size increase now feels very small, and I'm retraining my fingers to expand the terminal directly to full-screen (Ctrl+Shift+Q) instead of expanding the terminal 4 or 5 times (Ctrl+Cmd+Up). Now, to use (Ctrl+Cmd+Up) I'd have to press ~40 to ~50 times (or hold) to get it to a mostly-expanded size.
I'm not a vscode maintainer but what I can tell: To meet your needs with the current implementation, you could map the keybinding you used to use to a multi-command or macro. Using the corresponding vscode extension / .That way you could control the exact resize step amount. that make it sounds like a tough thing to do ‍. As far as I could tell until now a human brain should be able to do it in a few minutes or a handful of repetitions .
Change:
}); } <ins> private compareTwoNullableNumbers(a: number | undefined, b: number | undefined): number { const aOrMax = a ?? Number.MAX_SAFE_INTEGER; const bOrMax = b ?? Number.MAX_SAFE_INTEGER; if (aOrMax < bOrMax) { return -1; } else if (aOrMax > bOrMax) { return 1; } else { return 0; } } </ins> filterSettings(filter: string, groupFilter: IGroupFilter, settingMatcher: ISettingMatcher): ISettingMatch[] { const allGroups = this.filterGroups;

Discussion:
Tested on Insiders Build 1.65.0 and Build 1.64.2. If an extension's settings are viewed, the presentation order is respected, but _only if the "Search settings" bar is empty. If the search bar contains anything, including the name of the extension (matching all settings for that extension), the presentation order is alphabetical. Given that the presentation can still be controlled by the selected extension name in the left menu, it would seem logically possible to respect the sort ordering within an extension settings group. Examples: Following ordering (search area blank): ! Not following ordering: !
Verification steps: or write an extension with settings where the settings group and the individual settings use fields to determine the order. An example is at Also make the setting keys similar so that they can show up under the same search query. the extension, navigate to the Settings editor, and clear the search widget. that the settings for that extension are displayed in the expected order. a query to the search widget such that those extension settings still show up. that the filtered settings for that extension show up in the same order as in step 3.
Tested just now on LGTM
Change:
} .monaco-editor .sticky-line-root { <del> background-color: inherit; overflow: hidden; </del> <ins> background-color: var(--vscode-editorStickyScroll-background); </ins> white-space: nowrap; width: 100%; }

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hello So I have noticed when using Sticky Scroll, any line which is too long (for example the screenshot below), it would block off the rest of the code. A feature I was thinking would be a good adition is sideways scrolling (like what happens already in the main editor) so that people can see what else is in that line. <kbd<img src="https://user-"/</kbd
Change:
password: options.password, placeHolder: options.placeHolder, value: lastValue === void 0 ? options.value : lastValue, <del> valueSelect: lastValue === void 0, </del> <ins> valueSelect: options.noValuePreselect ? false : lastValue === void 0, </ins> inputDecoration: currentDecoration, onDidType: (value) => { lastValue = value;

Discussion:
VSCode Version: 1.5.0-insider OS Version: Windows 10 Steps to Reproduce: value is highlighted/selected Currently we can't put the cursor at the end of the default value when running . In this case, users have to move the cursor manually if we want to keep the default value as prefix always.
That's actually indented use case since the user is likely to accept <kbdEnter</kbdor over write the pre-set value. What is your use-case for this?
This features originally comes from implementing Vim's Ex commands, which support line range as a prefix like represents and represents . When users trigger Ex command by , Vim will help fulfill the line range prefix automatically and then users can type commands directly, eg for replacement. If users don't like the line range Vim puts there automatically, they need to use to delete the range characters. Vim doesn't select those characters it auto-completes but Code does, so I'm asking if it's possible to add this support to .
It would also help if a selection range could be defined. In my case I would like set the whole file path as value but only select the file base name. e.g. /path/to/file/ Users most likely will only change the but should also have the possibility to change the path.
Concurring to what said. I have an open question on Stack overflow:
+1 to this, it is very counterintuitive to do visual block find/replaces with VSCodeVim as noted in the above mentioned issues with this default behavior. If it were configurable like makes it, that would be useful for better emulating vim-style editing for VSCodeVim users like myself!
Change:
getDirty(resource: URI): IWorkingCopy[] { return []; } create(resource: URI, contents?: VSBuffer | VSBufferReadable | VSBufferReadableStream, options?: { overwrite?: boolean | undefined; } | undefined): Promise<IFileStatWithMetadata> { throw new Error('Method not implemented.'); } <ins> createFolder(resource: URI): Promise<IFileStatWithMetadata> { throw new Error('Method not implemented.'); } </ins> move(files: { source: URI; target: URI; }[], options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata[]> { throw new Error('Method not implemented.'); }

Discussion:
It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.
Some background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.
We currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.
I don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both
Verification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.
Thanks for fixing!
Change:
// Instantiate select implementation based on platform if (isMacintosh) { <del> this.selectBoxDelegate = new SelectBoxNative(options, selected, styles, this.toDispose); </del> <ins> this.selectBoxDelegate = new SelectBoxNative(options, selected, styles); </ins> } else { <del> this.selectBoxDelegate = new SelectBoxList(options, selected, contextViewProvider, styles, this.toDispose); </del> <ins> this.selectBoxDelegate = new SelectBoxList(options, selected, contextViewProvider, styles); </ins> } this.toDispose.push(this.selectBoxDelegate);

Discussion:
New SelectBox custom implementation creates a circular disposal since toDispose is still passed to the select box delegate where the class objects are into the disposable list which is really the parents list. Steps to Reproduce: code, open a terminal (instantiates the drop-down lists) panel (disposes SelectBox) gives a stack err, panel becomes blank and unusable shows an infinite disposal loop. Debug on disposal: [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.472:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.473:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.474:INFO:CONSOLE(442)] "Dispose 14",

source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.475:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.475:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.476:INFO:CONSOLE(442)] "Dispose 14", source: file:///C:/VSC Dev/vc-fork- (442) [7432:1218/.476:INFO:CONSOLE(85)] "Maximum call stack size exceeded: RangeError: Maximum call stack size exceeded at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-) at SelectBoxList.dispose (file:///C:/VSC Dev/vc-fork-) at file:///C:/VSC Dev/vc-fork- at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-) at SelectBoxList.dispose (file:///C:/VSC Dev/vc-fork-) at file:///C:/VSC Dev/vc-fork- at Array.forEach (native) at Object.dispose (file:///C:/VSC Dev/vc-fork-)", source: file:///C:/VSC Dev/vc-fork- (85)
Fixed with
Change:
return (documentVersion: number) => { if (!cachedElements || documentVersion !== cachedVersion) { cachedVersion = documentVersion; <del> cachedElements = [{ element: document.body, line: 0 }]; </del> <ins> cachedElements = [{ element: document.body, line: -1 }]; </ins> for (const element of document.getElementsByClassName(codeLineClass)) { const line = +element.getAttribute('data-line')!; if (isNaN(line)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 insider OS Version: Windows 11 Version 10.0. Build Steps to Reproduce: perfectly clean VSCode Insider version any folder and create/open .md file like this: Preview to the side ! on the second title (L5) then vertical white line appears on the left ! I click on the secound line, the top title is highlighted normally ! when I directly click on the first line, the vertical line doesn't appear !
Change:
}, { "command": "git.revealFileInOS.linux", <del> "when": "scmProvider == git && scmResourceGroup == workingTree && resourceScheme == file && isLinux", </del> <ins> "when": "scmProvider == git && scmResourceGroup == workingTree && remoteName == '' && isLinux", </ins> "group": "2_view@2" }, { "command": "git.revealFileInOS.mac", <del> "when": "scmProvider == git && scmResourceGroup == workingTree && resourceScheme == file && isMac", </del> <ins> "when": "scmProvider == git && scmResourceGroup == workingTree && remoteName == '' && isMac", </ins> "group": "2_view@2" }, { "command": "git.revealFileInOS.windows", <del> "when": "scmProvider == git && scmResourceGroup == workingTree && resourceScheme == file && isWindows", </del> <ins> "when": "scmProvider == git && scmResourceGroup == workingTree && remoteName == '' && isWindows", </ins> "group": "2_view@2" }, {

Discussion:
Testing Open a git repository from WSL Modify files and save Go to SCM view, right click on a change Click on "Reveal in File Explorer" Nothing happens
The latest Insiders has been updated, so that the new menu item does not appear when connected to a remote.
<img width="307" alt="image" src="https://user-"Reveal in File Explorer is gone . However Open Containing Folder is there and it does do anything either.
Change:
["(", ")"] ], "autoClosingPairs": [ <del> ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] </del> <ins> { "open": "{", "close": "}" }, { "open": "[", "close": "]" }, { "open": "(", "close": ")" }, { "open": """, "close": """, "notIn": ["string"] }, { "open": "'", "close": "'", "notIn": ["string", "comment"] } </ins> ], "surroundingPairs": [ ["{", "}"],

Discussion:
VSCode Version: 1.2.1 OS Version: Windows 10.0. Steps to Reproduce: editing python document typing in a comment a contraction such as isn't that the editor creates a closing apostrophe that is inappropriate in this context.
Not sure if this is inside the extension or core. But I have seen issues with wrong auto closing often in selfhost too.
Well... this has been there since day 1. Does anyone know how JavaScript solves this, since it's solved there?