jiebi/CodeConvo huggingface dataset:
Change:
return this._autoClosingPairs; } <del> public getAutoCloseBeforeSet(): string { return this._autoCloseBefore; </del> <ins> public getAutoCloseBeforeSet(forQuotes: boolean): string { return (forQuotes ? this._autoCloseBeforeForQuotes : this._autoCloseBeforeForBrackets); </ins> } public getSurroundingPairs(): IAutoClosingPair[] {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Can the addition of the closing curly brace be whenever the opening curly brace is automatically initiated in an f-string in python? currently this doesn't happen and i need to add the closing curly brace when done - this feature would be useful --
Please add more details, e.g. a code sample.
apologies - I actually had but for some reason the main body of text wasn't posted. please see a below a code example - thank you. This is the current way in which the curly brace is interpreted in an f string. As you can see when you enter the opening curly brace, the closing one is not automatically inserted and i have to enter it manually.. it would be incredibly useful if the closing brace was automatically (in the same way automatic closing of brackets and braces is achieved outside of the print statement in the editor) to achieve something like: having said this - this is a trivial feature request, but i find myself using this a lot
is defined as bracket pair, also for when in strings, so I believe it should work.
Thank you for the reply! Hmm this doesn't for me unfortunately, is there a setting that needs to be activated?
does autoclose in strings in general e.g. https://user- But not at the position before the closing e.g. https://user- Relevant code:
ha! thank you, this is really interesting - i can confirm that it works when entering before the closing - funny because i have only ever really required the the braces before the closing comma (because this then creates a whitespace between the statement and the answer which is intended for visual purposes will this be treated as a bug to fix? again this obviously isn't critical. happy to close. thanks
This cannot be fixed at the moment. The behaviour is controlled by the autoCloseBefore property in the language configuration file, but quotes are not appropriate for that property. JavaScript and TypeScript make an exception for backticks.
Change:
instantiationService.stub(ITextModelService, new class extends mock<ITextModelService>() { override registerTextModelContentProvider = () => ({ dispose: () => { } }); }); <ins> instantiationService.stub(IEditorService, new class extends mock<IEditorService>() { override saveAll = async (_options: ISaveAllEditorsOptions) => true; }); </ins> editSessionsContribution = instantiationService.createInstance(EditSessionsContribution); });

Discussion:
Testing I wonder if we should run the command to save all files (not untitled files) before triggering the "Continue on" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?
I am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !
Should we say here? !
Change:
const languageId = this.languageService.guessLanguageIdByFilepathOrFirstLine(textEditorModel.uri); this.addDecoration( linkRange, <del> new MarkdownString().appendCodeblock(languageId ? languageId : '', previewValue) </del> <ins> previewValue ? new MarkdownString().appendCodeblock(languageId ? languageId : '', previewValue) : undefined </ins> ); ref.dispose(); });

Discussion:
If I hover over a path in TypeScript and hold Ctrl, and empty line appears at the bottom of the tooltip where the preview would normally be (because presumably, the definition being used to support go-to-definition returns a range of line 0, col 0 to line 0 col 0): https://user- In the case where there's no normal hover text, this can result in an "empty hover" instead, as seen here in Dart (top left of "example"): !
Are you saying that you have a go-to-definition provider for that path but no hover provider (or no hover provider result) Please provide repo steps and a minimal code sample that allows to reproduce this.
the first example above is using TypeScript, but here's some code to repro in an extension: The important thing here is that the definition provider is returning an empty range for the . This is what TypeScript is doing for a definition on an Import filename (because it wants to provide a Cmd+Click, but there is no actual symbol definition). If you hover over something in an untitled file with the code above, hold hold Cmd and move the mouse, you'll see an extra "empty" area to the hover. https://user- If there is no hover at all (comment out the hover provider) then you get just an empty box. when holding Cmd: https://user-
Change:
disposables.add(controller.onDidHideChat(() => this.stop())); const scopedChatToSpeechInProgress = ScopedChatSynthesisInProgress.bindTo(controller.contextKeyService); <del> disposables.add(toDisposable(() => scopedChatToSpeechInProgress.set(false))); </del> <ins> disposables.add(toDisposable(() => scopedChatToSpeechInProgress.reset())); </ins> disposables.add(session.onDidChange(e => { switch (e.status) {

Discussion:
Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39.

cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
are you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:
Happened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.
I need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)
Change:
"command": "git.publish", "title": "%command.publish%", "category": "Git", <ins> "icon": "$(cloud-upload)", </ins> "enablement": "!operationInProgress" }, {

Discussion:
Testing I expected the action to appear on an unpublished branch, not the action. I am aware they both do the same. <img width="647" alt="Screenshot 2024-01-24 at 11 37 40" src=""
Change:
ModelRawLinesDeleted, ModelRawLinesInserted } from 'vs/editor/common/model/textModelEvents'; import { TextModel } from 'vs/editor/common/model/textModel'; <ins> import { LanguageIdentifier, TokenizationRegistry, IState, MetadataConsts } from 'vs/editor/common/modes'; import { MockMode } from 'vs/editor/test/common/mocks/mockMode'; import { LanguageConfigurationRegistry } from 'vs/editor/common/modes/languageConfigurationRegistry'; import { TokenizationResult2 } from 'vs/editor/common/core/token'; import { NULL_STATE } from 'vs/editor/common/modes/nullMode'; import { dispose, Disposable } from 'vs/base/common/lifecycle'; </ins> // --------- utils

Discussion:
VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.
For the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns
Any update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.
Have the same problem, but wonder about: "... autocomplete options for props ...". Is VS Code capable to autocomplete my custom from an imported component?
Change:
}; const adjustSettings = nls.localize('unicodeHighlight.adjustSettings', 'Adjust settings'); <del> const contents: Array<IMarkdownString> = [{ value: `${reason} [${adjustSettings}](command:${ShowExcludeOptions.ID}?${encodeURIComponent(JSON.stringify(adjustSettingsArgs))})`, isTrusted: true, }]; result.push(new MarkdownHover(this, d.range, contents, index++)); </del> <ins> const uri = `command:${ShowExcludeOptions.ID}?${encodeURIComponent(JSON.stringify(adjustSettingsArgs))}`; const markdown = new MarkdownString('', true) .appendMarkdown(reason) .appendText(' ') .appendLink(uri, adjustSettings); result.push(new MarkdownHover(this, d.range, [markdown], index++)); </ins> } return result; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.65.2 OS Version: Darwin x64 20.6.0 Steps to Reproduce: fullwidth right parenthesis the right parenthesis <img width="688" alt="image" src="https://user-"
should be escaped: ,
Thanks a lot for reporting & investigating! Up for a PR?
Change:
item: CodeActionItem, codeActionReason: ApplyCodeActionReason, options?: { preview?: boolean; editor?: ICodeEditor }, <ins> token: CancellationToken = CancellationToken.None, </ins> ): Promise<void> { const bulkEditService = accessor.get(IBulkEditService); const commandService = accessor.get(ICommandService);

Discussion:
re testing select some TS code that can be extracted as const select refactor with preview select extract const select discard :bug: the rename widget still shows... https://user-
I believe fixing this requires some info being returned from the bulk edit service, e.g the service should tell its caller that the change didn't happen so that code actions don't continue the normal flow
Change:
this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'invalidDestination' }); return undefined; } catch (ex) { <del> this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'unknownError' }); </del> <ins> if (ex instanceof CancellationError) { this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'cancelled' }); } else { this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'unknownError' }); } </ins> return undefined; } }

Discussion:
extension suppresses cancellation errors so Create New Codespace errors or cancellations show up as reports all errors as rather than distinguishing cancellation errors
Change:
// give a new terminal some time to initialize the shell await new Promise(resolve => setTimeout(resolve, 1000)); } else { <ins> if (terminal.state.isInteractedWith) { terminal.sendText('u0003'); // Ctrl+C for #106743. Not part of the same command for #107969 } </ins> if (configProvider.getConfiguration('debug.terminal').get<boolean>('clearBeforeReusing')) { // clear terminal before reusing it if (shell.indexOf('powershell') >= 0 || shell.indexOf('pwsh') >= 0 || shell.indexOf('cmd.exe') >= 0) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --It's the second time it happened. First time was a fresh project so as I didn't investigate further. I thought I messed up somehow. Second time I lost some datasets and got close to lose some code. I found the culprit so I hope it won't to me a third time. <!-- Use Help Report Issue to prefill these. --Version: 1.48.2 (system setup) Electron: 7.3.2 V8: 7.8.279.23-electron.0 OS: WindowsNT x64 10.0. Steps to Reproduce: a debugging session, that open a fresh python debug console terminal debugging session terminate in python debug console terminal: pressing enter, so the command don't execute but sit there a new debugging session VS code will then reuse the 'python debug console terminal' previously open, with my un-executed command still sitting there. It do its business as usually and inputting: resulting the command: and Poof my whole project is gone <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No
We should clear any input before executing a command.
I agree, I'm quite suprise it was not the case already. Waiting for the fix. There is the possibility of setting the debug console to be spawn in the debug output tab. In ’’ ’"console": "internalConsole"’
I'm now cancelling the input with Control-C. This should work on all platforms and for all shells.
Perfect, thanks for your work
The fix for this causes Reverting for the release.
Same thing happens with the C++/CMake extension when pressing F5.
Change:
Root: HKCR; Subkey: "{#RegValueName}SourceFileDefaultIcon"; ValueType: string; ValueName: ""; ValueData: "{app}resourcesappresourceswin32code_file.ico" Root: HKCR; Subkey: "{#RegValueName}SourceFileshellopencommand"; ValueType: string; ValueName: ""; ValueData: """{app}{#ExeBasename}.exe"" ""%1""" <ins> Root: HKCR; Subkey: "Applications{#ExeBasename}.exe"; ValueType: none; ValueName: ""; Flags: uninsdeletekey Root: HKCR; Subkey: "Applications{#ExeBasename}.exeDefaultIcon"; ValueType: string; ValueName: ""; ValueData: "{app}resourcesappresourceswin32code_file.ico" Root: HKCR; Subkey: "Applications{#ExeBasename}.exeshellopencommand"; ValueType: string; ValueName: ""; ValueData: """{app}{#ExeBasename}.exe"" ""%1""" </ins> Root: HKCU; Subkey: "Environment"; ValueType: expandsz; ValueName: "Path"; ValueData: "{olddata};{app}bin"; Tasks: addtopath; Check: NeedsAddPath(ExpandConstant('{app}bin')) Root: HKCU; Subkey: "SOFTWAREClasses*shell{#RegValueName}"; ValueType: expandsz; ValueName: ""; ValueData: "Open with {#ShellNameShort}"; Tasks: addcontextmenufiles; Flags: uninsdeletekey

Discussion:
VSCode Version: 0.10.11 OS Version: Windows 10 Steps to Reproduce: click on an unknown file type, like or Open with... VS Code and check always use this app to open files of this type The file gets the app icon of VS Code, not the document icon: !
Change:
} lastSelectedString = selection ? selection.toString() : ''; })); <ins> this._register(this.tree.onDidChangeContentHeight(() => this.refreshReplElements(false))); </ins> // Make sure to select the session if debugging is already active this.selectSession(); this.styleElement = dom.createStyleSheet(this.container);

Discussion:
Testing Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.
Yeah great idea. I think this could be shown in the filter area. This could be a shared experience also in the Problems view I am opening this up for PRs. Code pointer
FYI, problems view already show this like below <img width="458" alt="image" src="https://user-"
Great! Then we should just copy what Problems is doing Assigning to September so I tackle then if no PR's arrive
Hi I can take a look into this if no one else is assigned.
sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.
friendly ping regarding this, since if you are not looking into it I might take a look next week...
Hi sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.
great thanks. Since you are already on this I will remove the label
Thanks to we now have this. Adding verification needed so we get this verified: Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items
Change:
// With <head> as container, the stylesheet becomes global and is tracked // to support auxiliary windows to clone the stylesheet. if (container === document.head) { <ins> const globalStylesheetClones = new Set<HTMLStyleElement>(); globalStylesheets.set(style, globalStylesheetClones); </ins> for (const { window: targetWindow, disposables } of getWindows()) { if (targetWindow === mainWindow) { continue; // main window is already tracked } <del> const cloneDisposable = disposables.add(cloneGlobalStyleSheet(style, targetWindow)); </del> <ins> const cloneDisposable = disposables.add(cloneGlobalStyleSheet(style, globalStylesheetClones, targetWindow)); </ins> disposableStore?.add(cloneDisposable); } } return style; } <del> const globalStylesheets = new Map<HTMLStyleElement /* main stylesheet */, Set<HTMLStyleElement /* aux window clones that track the main stylesheet */>>(); export function isGlobalStylesheet(node: Node): boolean { return globalStylesheets.has(node as HTMLStyleElement); } </del> export function cloneGlobalStylesheets(targetWindow: Window): IDisposable { const disposables = new DisposableStore(); <del> for (const [globalStylesheet] of globalStylesheets) { disposables.add(cloneGlobalStyleSheet(globalStylesheet, targetWindow)); </del> <ins> for (const [globalStylesheet, clonedGlobalStylesheets] of globalStylesheets) { disposables.add(cloneGlobalStyleSheet(globalStylesheet, clonedGlobalStylesheets, targetWindow)); </ins> } return disposables; } <del> function cloneGlobalStyleSheet(globalStylesheet: HTMLStyleElement, targetWindow: Window): IDisposable { </del> <ins> function cloneGlobalStyleSheet(globalStylesheet: HTMLStyleElement, globalStylesheetClones: Set<HTMLStyleElement>, targetWindow: Window): IDisposable { </ins> const disposables = new DisposableStore(); const clone = globalStylesheet.cloneNode(true) as HTMLStyleElement;

Discussion:
Type: <bBug</bThe fix for seems to have stopped working in the latest Insiders build. VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-06T05:34:22.485Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Range:
Really a bad bug: none of the global styles would get copied properly, a lot of other CSS related things must have been broken. Fix tomorrow!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
import { CONTEXT_ACCESSIBILITY_MODE_ENABLED } from 'vs/platform/accessibility/common/accessibility'; import { terminalViewIcon } from 'vs/workbench/contrib/terminal/browser/terminalIcons'; import { RemoteTerminalService } from 'vs/workbench/contrib/terminal/browser/remoteTerminalService'; <ins> import { isIPad } from 'vs/base/browser/browser'; </ins> // Register services registerSingleton(ITerminalService, TerminalService, true);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --Hitting + with the terminal focused and a process running (i.e. in a React app) does not kill the process. If someone is able to provide a good starting point, I would be willing to take a stab at this. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.53.0-insider OS Version: iPadOS 14.1 (18A8395) Commit: Date: 2021-01-07T05:25:51.740Z (16 hrs ago) Browser: Mozilla/5.0 (iPad; CPU OS 14_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/87.0.4280.77 Mobile/15E148 Safari/604.1 iPad, open Codespaces environment in Chrome integrated Terminal application (i.e. like a create-react-app - ) terminal and hit + Process () should stop running Terminal receives new line https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Related:
Perhaps that is not the right sigint.
One other piece of insight: this may not be limited to VSCode. has a product which includes a terminal in the browser. I’m able to reproduce the same issue (see line breaks at the bottom). !
As a temporary workaround, it works if you manually define the shortcut like so: Command Palette for "Preferences: Open Keyboard Shortcuts (JSON)" this: Source:
I found the root reason was iPad Safari report keyCode of ctrl-c as 13, which is not correct, reference from MDN, keyCode is a deprecated property; The key and code property is right, so I suggest just use key property, not keyCode, on the whole html page not just terminal.
I'm still seeing this in codespace, am I testing the right environment?
fixed w
as another workaround, use shortcut instead of , it will interrupt the process as well
Change:
export interface IChatAccessibilityService { readonly _serviceBrand: undefined; <del> acceptRequest(): void; acceptResponse(response?: IChatResponseViewModel | string): void; </del> <ins> acceptRequest(): number; acceptResponse(response: IChatResponseViewModel | string | undefined, requestId: number): void; </ins> } export interface IChatCodeBlockInfo {

Discussion:
The lastResponse property is checked before unsetting the hasReceivedRequest_ field
This won't happen if happens
AFAIK this will still happen: when having two equal responses (which is the default for inline chat), is only played once.