jiebi/CodeConvo huggingface dataset:
Change:
"configuration.markdown.links.openLocation.currentGroup": "Open links in the active editor group.", "configuration.markdown.links.openLocation.beside": "Open links beside the active editor.", "configuration.markdown.suggest.paths.enabled.description": "Enable/disable path suggestions for markdown links", <del> "configuration.markdown.editor.drop.enabled": "Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbenck.experimental.editor.dropIntoEditor.enabled#`.", </del> <ins> "configuration.markdown.editor.drop.enabled": "Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbench.experimental.editor.dropIntoEditor.enabled#`.", </ins> "configuration.markdown.experimental.validate.enabled.description": "Enable/disable all error reporting in Markdown files.", "configuration.markdown.experimental.validate.referenceLinks.enabled.description": "Validate reference links in Markdown files, e.g. `[link][ref]`.  Requires enabling `#markdown.experimental.validate.enabled#`.", "configuration.markdown.experimental.validate.headerLinks.enabled.description": "Validate links to headers in Markdown files, e.g. `[link](#header)`. Requires enabling `#markdown.experimental.validate.enabled#`.",

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version:mac os monterey 12.3.1 Steps to Reproduce: to settings (command+,) for markdown drop <img width="719" alt="Screen Shot 2022-05-20 at 11 55 58 AM" src="https://user-"
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed on latest insiders Version: 1.68.0-insider Commit: Date: 2022-05-16T05:30:27.563Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin arm64 21.4.0 <img width="636" alt="Screen Shot 2022-05-20 at 1 11 00 PM" src="https://user-"
Fixed as of
<img width="967" alt="image" src="https://user-"
Hey I see with the same fixes, already merged.
Yeah but it accidentally got reverted via This just brings your changes back in
Change:
}); this.body = append(this.element, $('.pane-body')); <del> this.renderBody(this.body); </del> <ins> // Only render the body if it will be visible // Otherwise, render it when the pane is expanded if (!this._bodyRendered && this.isExpanded()) { this.renderBody(this.body); this._bodyRendered = true; } </ins> if (!this.isExpanded()) { this.body.remove();

Discussion:
Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible
would you be willing to verify for completeness?
Works great!
Change:
const handle = AbstractTaskService._nextHandle++; this._providers.set(handle, provider); this._providerTypes.set(handle, type); <ins> this._onDidChangeTaskProviders.fire(); </ins> return { dispose: () => { this._providers.delete(handle); this._providerTypes.delete(handle); <ins> this._onDidChangeTaskProviders.fire(); </ins> } }; }

Discussion:
a repo in :bug: see this !
This is expected if the repo that you open has tasks that run on . Could you pls provide me with a repo for which this happens that doesn't have those?
seeing this dialog when I just open a folder, so wondering if something with workspace trust has changed recently. No changes with tasks recently could explain this. !
Doesn't repro in , repros in : Bad: Good:
found these task PRs in that time frame: ,
found it also happens in an empty window on desktop
Still seeing this in (and also RemoteHub on desktop) with the changes in !
This is coming from -here. perhaps we don't want to do that for the or only do that in trusted workspaces? !
Change:
* Gets the range where a test ID is displayed, in the given URI. * Returns undefined if there's no such decoration. */ <del> getDecoratedRangeForTest(resource: URI, testId: string): Range | undefined; </del> <ins> getDecoratedTestPosition(resource: URI, testId: string): Position | undefined; </ins> } export interface ITestDecoration {

Discussion:
Using the test-provider-sample, adding newlines on a line marked as a test duplicates the test icon: ! It sorts itself out on the next update (at least in the sample, I'm still investigating to figure out if there's another issue, or that's in my extension). But it still looks bad - especially if a language is debouncing edits and/or discovery may be slow.. You can make the issue more pronounced (as I did for the GIF) by updating the test-provider-sample to have a delay in its updates:
I was able to repro the full issue I'm seeing in Dart (where the icons never disappear) using the sample too: ! My changes to the sample are here: I changed it so that tests can span multiple lines (since the original code split on lines then searched each line) and use the full range as the for the test. Now when pressing in the test, the original issue (VS Code duplicate the icons) still occurs, but also after the updates, since the range computed by the provider doesn't change from the range VS Code currently has (at least that's my guess), there's no update to the gutter icons so they no longer get cleaned up.
That's correct, we let the editor do its default decoration tracking until an update is received from the extension. for testing decorations, I already set , but is there a similar option to avoid extending the range over lines when edited? Or, alternatively, a way to only apply the glyphMarginClassName to the first line of the range. Reference:
You can create two decorations per test. One which has a range, a hover message, etc. And another one which renders the glyph margin with a collapsed range (perhaps the start position of the range). If you use for the second one, given it begins as a collapsed range, it will never grow, it will always remain a collapsed range.
Change:
import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'; import { index } from 'vs/base/common/arrays'; import { MarkdownString } from 'vs/base/common/htmlContent'; <ins> import { isString } from 'vs/base/common/types'; </ins> export interface IRawLanguageExtensionPoint { id: string;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 89.1 x64 OS Version: Edition Windows 11 Pro Version 23H2 Installed on ‎2023-‎11-‎28 OS build .3593 Experience Windows Feature Experience Pack 1000..1003.0 Steps to Reproduce: the VS Code the introduction page of buildin plugin the FEATURES page 's Empty
I am seeing following !
Yes, I see the same. There should be details about supported languages like other built-in plugins.
Can you point me to the place I need to fix this?
Here it is
Change:
@IWorkbenchEnvironmentService environmentService: IWorkbenchEnvironmentService, @IConfigurationService private readonly configurationService: IConfigurationService, @IMenuService private readonly menuService: IMenuService, <del> @IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService, </del> <ins> @IWorkbenchLayoutService layoutService: IWorkbenchLayoutService, </ins> ) { super({ ...options,

Discussion:
Testing When I dragged one of the icons to the second side bar, I wanted it to be placed before the other icon, however, it was placed behind it even though the bar indicating where it would be placed was in front of the icon. Also I noticed it's not possible to drop an icon on the top part of the side bar when the side bar is empty. It's only possible to drop it on the view part of the side bar. I think it should be possible to drop it everywhere in the second side bar when it is empty. !
I cannot reproduce this. I see it is happening in the recording, but it would be great if you can give me steps you followed to repro. Agreed. This is not new and has been like this before. But, I observed another bug in your recording that dropping the view container is not activating it - this used to be getting activated in older versions. Fixed that.
Change:
warnAboutMissingGit(); return new GitExtensionImpl(); <ins> } finally { disposables.push(new GitProtocolHandler(outputChannelLogger)); </ins> } }

Discussion:
't have a git repo open in desktop VS Code Insiders web, enter the following into the address bar and hit enter :bug: desktop VS Code Insiders reports that git is not installed and fails to clone the url I believe the reason this happens is that as soon as the git extension calls , the API impl immediately tries to flush its buffer of URIs to be handled. Because we are now registering the uri handler early in the extension activation method, the git extension hasn't yet run discovery of the git executable and registered commands appropriately, so the handler gets called before the git extension is ready to handle the clone. The fix is to unconditionally register the uri handler as intended in , but to do it only after we've already attempted to locate git and register commands
Change:
if (workingCopy.isDirty()) { this.logService.trace(`[backup tracker] running backup`, workingCopy.resource.toString()); <del> const backup = await workingCopy.backup(); this.backupFileService.backup(workingCopy.resource, backup.content, this.getContentVersion(workingCopy), backup.meta); </del> <ins> try { const backup = await workingCopy.backup(); await this.backupFileService.backup(workingCopy.resource, backup.content, this.getContentVersion(workingCopy), backup.meta); } catch (error) { this.logService.error(error); } </ins> } }, BackupTracker.BACKUP_FROM_CONTENT_CHANGE_DELAY);

Discussion:
This is not a failure but error output when running the tests: I feel this could be a result from the environment service change you did. Bounce back to me if not.
I investigated and do not understand how the environment service changes caused this, but it seems there is no error handling while writing into back up as a result above uncaught errors are shown. Digging more deeper, backup tracker test is not waiting until back up task is finished which is triggered by the test and removing the backup folder in tear down. Created a PR that takes care of error handling in backup tracker - If there is a better fix, please ignore the PR and push the fix.
Change:
quickpick.busy = false; let repo: string | undefined; <ins> let isPrivate: boolean; </ins> const onDidChangeValue = async () => { const sanitizedRepo = sanitizeRepositoryName(quickpick.value);

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --As noted in , the lack of an option to create a public repository is by design rather than a bug. In that issue, gave the following reason for omitting the option: I would argue that: two quickpick options instead of one would not significantly complicate the UI. process of making a private repository public is not straightforward, especially when the alternative is to just create it as public in the first place. For reference, here are the required steps: Select "Publish to GitHub private repository" from quickpick and open the repo when finished. <img width="643" alt="Screen Shot 2020-07-12 at 11 26 12 AM" src="https://user-"- <img width="471" alt="Screen Shot 2020-07-12 at 11 27 26 AM" src="https://user-"- Open repository settings on GitHub. <img width="988" alt="Screen Shot 2020-07-12 at 11 34 14 AM" src="https://user-"- Scroll all the way to the bottom of the page (to the "Danger Zone") and click "Change visibility." <img width="942" alt="Screen Shot 2020-07-12 at 11 28 27 AM" src="https://user-"- In the modal, select the "Make public" radio option. Type the full repo name and click "I understand, change repository visibility." <img width="488" alt="Screen Shot 2020-07-12 at 11 28 51 AM" src="https://user-"For me and many others whose primary work is done in public repos, these steps would be completely eliminated if there were an option to create the repo as public in the first place. I don't believe it would be very difficult to implement this feature. Here's a simple solution:
OK sure, feel free to submit a PR.
Will do, thanks!
Change:
} else { this._outputEmptyElement!.style.display = 'none'; } <ins> this._decorate(); </ins> })); this._outputLeftContainer = DOM.append(this._outputViewContainer!, DOM.$('.output-view-container-left'));

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66 OS Version: Windows 11 Steps to Reproduce: diff view to revert the output changes :bug: after reverting the diff view still says there are deletions/additions output changes using the diff view :bug: stage the file and reopen the diff view, all the changes I reverted are back
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { raceTimeout } from '../../../../base/common/async.js'; </ins> import { CancellationToken } from '../../../../base/common/cancellation.js'; import { IStringDictionary } from '../../../../base/common/collections.js'; import { IExtensionRecommendations } from '../../../../base/common/product.js';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: Linux x64 6.6.26-1-MANJARO Steps to Reproduce: VS Code. Developer Tools and watch Network requests. VS Code, open Settings. that Settings will not display any settings until the requests to are completed. reading the results of the queries, observe that this request is related to the absolutely despicable advertisement for GitHub Copilot_, to detect if it's already installed (or something) in order to show the ad in the Settings UI and that you are now even more incensed that something which should work immediately was taking 7 seconds or longer due to the fact that we are now living through a dystopia. Then quickly get over it and start considering a move to a different editor or a fork. Please choose one of the following suggestions: remove the GitHub Copilot advertisement from the Settings UI. waiting for network requests in order to show the Settings UI. this issue and ignore this unquestionably sane plea to help battle the enfecalization of this beloved product.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
The AUR hasn't been updated with 1.89.1 yet but looking at the resolved issues I don't see any related to this.
I have a 1-second timeout per network request. In other words, the delays should now have an upper limit on their duration.
Change:
this.instantiationService.invokeFunction(fillResourceDataTransfers, dragged.map(d => d.getResource()), e); } })); <del> editorTemplate.toDispose.push(dom.addDisposableListener(container, dom.EventType.DRAG_OVER, () => { dom.addClass(container, 'focused'); </del> <ins> editorTemplate.toDispose.push(dom.addDisposableListener(container, dom.EventType.DRAG_OVER, (e: DragEvent) => { if (dropOnEditorSupported(e)) { dom.addClass(container, 'focused'); } </ins> })); editorTemplate.toDispose.push(dom.addDisposableListener(container, dom.EventType.DRAG_LEAVE, () => { dom.removeClass(container, 'focused');

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.25.0-insider OS Version: Windows 10 Home - 1803 Steps to Reproduce: the Explorer sidebar tab the Outline or File Hierarchy views as if to rearrange them the cursor over an item in the Open Editors view individual editors will change color along with the entire view, making it seem as if you can drop a sidebar view into an open editor and something will happen. What should actually happen is that the view should highlight (since its location will be replaced; it does do this), but the individual items should not be affected. Screenshot: ! I am holding the File Hierarchy view over the file in that screenshot. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I acknowledge the issue, the problem is that the OpenEditor view is not differentiating between drag events PR to fix this is welcome
I was able to add a check to prevent the hover styling unless the item being dragged is another open editor in the list (see ), however this also means that when tabs are dragged over the Open Editors panel (ie, when there's multiple groups; you can drag a tab into a group and it will duplicate into that group), it doesn't have any styling anymore. I couldn't figure out a way to check if the dragged object is a tab. Is that feasible? Where would I look?
yeah it is not so simple You would need to check the dragged data. If there is an elegent solution to fix this please provide a PR. If too complex or computation intensive I would prefer to leave the issue open for now. Thanks
So just to make sure, the only things that should trigger the class on open editors are the open tabs and the other open editors in the list, correct?
no. Dragging resources from the explorer, adn dragging things outside of vscode should also trigger it
Change:
constructor( @IConfigurationService private configurationService: IConfigurationService, <del> @IWorkspaceContextService private workspaceContextService: IWorkspaceContextService) { } </del> <ins> @IWorkspaceContextService private workspaceContextService: IWorkspaceContextService, @IEnvironmentService private environmentService: IEnvironmentService ) { } </ins> public text(contentPattern: IPatternInfo, folderResources?: uri[], options?: IQueryOptions): ISearchQuery { return this.query(QueryType.Text, contentPattern, folderResources, options);

Discussion:
Loosely related to ! We can use the 'files to include' box to do a search in an arbitrary folder, but it has to be an absolute path. It should also work when using a ~ to indicate the user's home directory.
Change:
return; } <del> matches = this._session.selectAll(); } if (findState.searchScope) { const states = findState.searchScope; let inSelection: FindMatch[] | null = []; matches.forEach((match) => { states.forEach((state) => { if (match.range.endLineNumber <= state.endLineNumber && match.range.startLineNumber >= state.startLineNumber) { inSelection!.push(match); } }); }); matches = inSelection; </del> <ins> matches = this._session.selectAll(findState.searchScope); </ins> } if (matches.length > 0) {

Discussion:
This is an extension of It's caused by only checking lineNumber in: Steps to reproduce: the following text in your editor: from 2nd abc to last a find in selection, possibly by pressing <kbdAlt</kbd<kbdl</kbd:arrowleft:. Now the cursor is before 2nd a. 'Select all occurences of find match'. Notice that it selects 2nd to 5th abc, instead of 2nd to 4th: ! Does this issue occur when all extensions are disabled?: Yes VS Code version: Code 1.63.2 (, 2021-12-15T09:39:46.686Z) OS version: Linux x64 5.13.0-22-generic snap Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
When you do . Now the cursor is before 2nd a. don't you lose the selection? Then what is the expected result of if there is no selection but the option is still selected?? I think it should really select all 5 occurrences of . And very oddly, when I do the command (via <kbdCtrl</kbd+<kbdShift</kbd+<kbdL</kbd) it is auto-enabling the and options become enabled. And then, since there is no selection, does select those last four occurrences of - as I think it should - the question is why doesn't it select the first . It is as if the setting is not respected when there is no selection but the option is enabled. [Of course, there really is a selection, but it is empty.]
From what I can tell, the feature (select all occurences of find match in search scope) only works when the find widget is made visible.
unfortunately the issue still persists even when find widget is visible. Find scope never respects selection column, only line. It seems like it was designed to be that way: