jiebi/CodeConvo huggingface dataset:
Change:
let done = false; const progress: vscode.Progress<vscode.InteractiveEditorProgressItem> = { report: async value => { <del> if (!request.live) { </del> <ins> if (!request.live && value.edits?.length) { </ins> throw new Error('Progress reporting is only supported for live sessions'); } if (done || token.isCancellationRequested) {

Discussion:
Enable screen reader mode or use preview mode Create a code error Invoke inline chat and use The response doesn't get shown in the diff editor and sometimes doesn't come back at all. The console shows the error below
I see:
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
screen reader mode a code error inline that and use /fix response doesn't get shown in the diff editor and sometimes doesn't come back at all.
Maybe related
Change:
"default": false, "description": "%json.format.keepLines.desc%" }, <del> "json.sortOnSave.enable": { "type": "boolean", "scope": "window", "default": false, "description": "%json.sortOnSave.enable.desc%" }, </del> "json.trace.server": { "type": "string", "scope": "window",

Discussion:
Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings
Hey that's a good idea! I'll discuss it with the team. What do you think ?
Yes, makes sense!
Change:
static readonly options = { id: 'editor.action.surroundWithSnippet', title: { <del> value: localize('label', 'Surround With Snippet...'), original: 'Surround With Snippet...' </del> <ins> value: localize('label', 'More...'), original: 'More...' </ins> } };

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The "Surround with...." in the labels are redundant and by removing them, clears up clutter in the action widget, and lets users navigate to specific labels by typing in fewer keys (ie, would go to, will go to ) !
Change:
isRebasing ? repo.getCommit('REBASE_HEAD') : repo.getCommit('MERGE_HEAD') ]); // ours (current branch and commit) <del> ours.detail = head.refNames.map(s => s.replace(/^HEAD ->/, '')).join(', '); ours.description = '$(git-commit) ' + head.hash.substring(0, 7); </del> <ins> current.detail = head.refNames.map(s => s.replace(/^HEAD ->/, '')).join(', '); current.description = '$(git-commit) ' + head.hash.substring(0, 7); </ins> // theirs <del> theirs.detail = rebaseOrMergeHead.refNames.join(', '); theirs.description = '$(git-commit) ' + rebaseOrMergeHead.hash.substring(0, 7); </del> <ins> incoming.detail = rebaseOrMergeHead.refNames.join(', '); incoming.description = '$(git-commit) ' + rebaseOrMergeHead.hash.substring(0, 7); </ins> } catch (error) { // not so bad, can continue with just uris

Discussion:
Currently in merge conflict and in the SCM view we talk about and changes, but the new Merge Editor talks about and -- IMO we should align to the and terms.
The opener of the merge editor is in control of the labels. Thus, this can easily be changed in the git extension. Incoming and Current makes sense for conflicts when merging in a remote branch, but not when applying stashes (though in that case "Theirs" and "Mine" also doesn't make much sense).
I always just think of it as there are always changes (from a merge, stash, etc) that are being incorporated (incoming) into the current state.
Change:
} async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext | INotebookCellToolbarActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> if (context.ui) { await context.notebookEditor.focusNotebookCell(context.cell, 'container', { skipReveal: true }); } else {

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem
Change:
// if we are here, the cell is a code cell. // check next cell, if markdown, that means this is the end of the section <del> const nextCell = this.notebookEditor.cellAt(i + 1); if (nextCell) { if (nextCell.cellKind === CellKind.Markup) { </del> <ins> const nextVisibleCell = this.notebookEditor.cellAt(i + 1); if (nextVisibleCell && i + 1 < visibleRange.end) { if (nextVisibleCell.cellKind === CellKind.Markup) { </ins> // this is the end of the section // store the bottom scroll position of this cell sectionBottom = this.notebookCellList.getCellViewScrollBottom(cell);

Discussion:
Tested on Windows 11. Yep, I also found it confusing as to when a sticky header would appear. Scrolling through in the testing repo, I had to scroll several times past before it would appear in the sticky scroll UI. I would have expected the header to be displayed right after it scrolled out the top of the view port. I also saw that headers higher in the hierarchy such as would disappear and reappear. Shouldn't the H2s remain as the H3s change? Originally posted by in
Somewhat related to visible range issues and multiple md cells with headers in a row.
Change:
assert.strictEqual(result, '2.test.js'); }); <ins> test('Increment file name with just version in name', function () { const name = '1.js'; const result = incrementFileName(name, false); assert.strictEqual(result, '2.js'); }); test('Increment file name with just version in name, too big number', function () { const name = '9007199254740992.js'; const result = incrementFileName(name, false); assert.strictEqual(result, '9007199254740992.1.js'); }); </ins> test('Increment file name with prefix version, trailing zeros', function () { const name = '001.test.js'; const result = incrementFileName(name, false);

Discussion:
Extending Have 1.txt Copy/paste it in the file explorer Get
fyi
I’ll fix it.
Change:
) { this._hashTable = new HashTable(); this._hasWarnedOverlappingTokens = false; <ins> this._hasWarnedInvalidLengthTokens = false; </ins> } public getMetadata(tokenTypeIndex: number, tokenModifierSet: number, languageId: string): number {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.2 OS Version: Win11 (but presumably affects all OSs) See , Steps to Reproduce: the Docker extension installed, open the Dockerfile example from , or simply enter this into a Dockerfile: VSCode freezing up We are independently working on the issue where negative-valued semantic tokens are returned, but invalid token data from the language service should not be causing VSCode to freeze up.
/cc
I'm not very familiar with semantic tokens, so if there's more info you can add here feel free!
I've tried reproducing this in a simple VS Code extension but have not had much luck. I do not see anything obvious in the LSP client bridge code so I feel like it should be reproducible in a regular extension also...
Yes, agree. This should be reproducible in a VS Code extension also.
Thanks for the speedy fix!
Change:
type: 'object', properties: codeActionsOnSaveDefaultProperties, additionalProperties: { <del> type: ['string', 'boolean'] </del> <ins> type: 'string' </ins> }, }, {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.1 OS Version: Apple M1 Max Mac 13.6.2 Steps to Reproduce: this snippet to VSCode settings VSCode keeps changing the setting to: If I change the value back to true (a valid value), then force the settings to sync (confirming the sync happened with the new setting), then reopen VSCode again.. the value has reverted it back to "explicit" and a new sync entry (from opening VSCode) happens saying it synced that new value. If I change the value to "always" it does not change back to "explicit".
While is still allowed, I think they're trying to deprecate that and encourage usage of //. It's changing to which is equivalent to had been prior to the September 2023 release aka v1.83, see discussion in release notes and .
Probably the best fix would be actually remove true/false values as valid inputs. Keeping them as valid can/will cause confusion. While it is mentioned in those release notes, not everybody reads every release notes in detail and it still conflicts with VSCode suggesting those values as valid.
We're affected by this as well. We have committed our VS Code settings to over a dozen repositories, so any developer on v1.85 encountered this auto-migration and saw those changes in their . Fortunately, we all update our VS Code version on the same day, so the impact is reduced, but it still means there will be merge conflicts and developers will need to rebase all of their branches.

In the past, whenever a VS Code update changes a setting, the old value continues to be accepted and there's a warning message shown. This gives us ample time to migrate the settings, instead of having to drop everything and fix it like today. Going forward, please follow that old approach and do not auto-migrate the settings.
This is a breaking change, how this even got merged?
Change:
} // Did this part's content change? <del> else if (!isInteractiveProgressTreeData(part) && !isInteractiveProgressTreeData(renderedPart) && !renderedPart.isFullyRendered) { </del> <ins> else if (!isInteractiveProgressTreeData(part) && !isInteractiveProgressTreeData(renderedPart)) { </ins> const wordCountResult = this.getDataForProgressiveRender(element, part, renderedPart); <del> if (wordCountResult !== undefined) { </del> <ins> // Check if there are any new words to render if (wordCountResult !== undefined && renderedPart.renderedWordCount !== wordCountResult?.actualWordCount) { </ins> partsToRender[index] = { renderedWordCount: wordCountResult.actualWordCount, lastRenderTime: Date.now(),

Discussion:
! I thought I noticed this happening from time to time after we made changes to how rendering works, but in this case with my test extension it's pretty obvious, I will investigate
This is due to losing means that it was fully rendered so far and was reset when we get more content. So now if we render everything in a markdown chunk then get more data, this keeps it from getting rendered. It's a bit more complicated with our new way of not constantly re-rendering. The view model doesn't currently know which chunks changed, so it can't reset that flag. The renderer only knows that the chunk was previously fully rendered but doesn't know that it has different data now. We could go back to rerendering everything all the time (don't really want to do that now that we have the nice optimization) or I think the model has to communicate what changed when it fires , it would have to include which response changed and which chunks of data. Or maybe there is a solution where we always rerender all markdown blocks but keep the rendered tree data?
That seems reasonable, I'll look into a fix
Change:
]; this._hasCustomEditor.set(possibleEditors.length > 0); this._focusedCustomEditorIsEditable.set(activeControl?.input instanceof CustomFileEditorInput); <del> this._webviewHasOwnEditFunctions.set(true); </del> <ins> this._webviewHasOwnEditFunctions.set(possibleEditors.length > 0); </ins> } private handleMovedFileInOpenedFileEditors(oldResource: URI, newResource: URI): void {

Discussion:
VSCode Version: master OS Version: macOS Steps to Reproduce: a normal (non-inline-editor) webview which contains an element into the input to to undo, but it doesn't do anything with to redo. Does this issue occur when all extensions are disabled?: Yes, but you need an extension that provides a webview to repro.
Change:
layout(dimension: Dimension): void { toggleClass(this.root, 'narrow', dimension.width <= 300); <del> this.searchBox.layout({ height: 20, width: dimension.width - 30 }); </del> <ins> this.searchBox.layout({ height: 20, width: dimension.width - 34 }); </ins> this.placeholderText.style.width = '' + (dimension.width - 30) + 'px'; super.layout(new Dimension(dimension.width, dimension.height - 38));

Discussion:
Issue Type: <bBug</b! ! As seen in the image above, the right side of the border has a portion cut off for an unknown reason. This doesn't happen with any of the official themes but does happen with themes installed from the marketplace. VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-27T05:18:38.441Z) OS version: Linux x64 4.17.8-1-ARCH <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ flutter-snippets0.0.2 gitignore0.5.0 transformer1.6.0 dart-code2.16.0 flutter2.16.0 gitlens8.5.3 vsc-material-theme2.3.0 vscode-commands1.2.2 vscode-todo-plus2.2.1 toggler0.0.3 output-colorizer0.1.2 vscode-insertdatestring2.2.2 vscode-commitizen0.5.0 Go0.6.85 vscode-quick-open-create0.6.0 vsnotes0.5.1 vscode-docker0.1.0 java0.28.0 vscode-yaml0.0.14 code-settings-sync3.0.0 gitconfig1.0.1 code-spell-checker1.6.10 vsfire1.3.2 vz-file-templates0.0.3 vscode-java-debug0.10.0 vscode-java-pack0.3.0 vscode-java-test0.7.1 vscode-maven0.10.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Could you specify which theme causes this? In your installed extensions one theme has been redacted, I assume that't the one, as vsc-material-theme doesn't seem to have this issue for me.
Got a repro with dracula
Put up a PR that fixes this in the cases I saw. Thanks for the report!
Thanks for the fix! I originally thought it was just one or two themes using a deprecated api so I closed the issue but I later realized that most marketplace themes were broken.
Change:
private _lineHeight: number; private _availableHeight: number; <del> constructor(parent: HTMLElement, opts: { fontInfo: FontInfo }) { </del> <ins> constructor(parent: HTMLElement, opts: { fontInfo: FontInfo; onSelectionChange: () => void }) { </ins> this._availableHeight = 0;

Discussion:
a symbol in typescript how you nicely offer some Copilot suggested names on one of them -no effect Accepting using the keyboard works.
Change:
* Find files across all {@link workspace.workspaceFolders workspace folders} in the workspace. * * @example <del> * findFiles('**​/*.js', {exclude: '**​/out/**', useIgnoreFiles: true}, 10) </del> <ins> * findFiles('**​/*.js', {exclude: '**​/out/**', useIgnoreFiles: true, maxResults: 10}) </ins> * * @param filePattern A {@link GlobPattern glob pattern} that defines the files to search for. The glob pattern * will be matched against the file paths of resulting matches relative to their workspace. Use a {@link RelativePattern relative pattern}

Discussion:
Testing It is not clear what is the default value.
Good point. The default value is the value in settings.
Change:
} public next(): T | null { <del> return this._navigator.next(); </del> <ins> if (this._currentPosition() !== this._elements.length - 1) { return this._navigator.next(); } return null; </ins> } public previous(): T | null { <del> return this._navigator.previous(); </del> <ins> if (this._currentPosition() !== 0) { return this._navigator.previous(); } return null; </ins> } public current(): T | null {

Discussion:
In the debug console, evaluate something, then 3 times. Press up, get Press up again, get again Press up again, get the previous history entry Seems like it always reduces down to 2 entries, or there might be something else weird going on
Oh wait, this is in vscode right?
We are de-duplicating history entries which makes sense for me. This is designed behavior What is the use case of seeing 3 times in history?
The bug is that I see it twice, when I should see it once
I can not repro. What are you doing differnetly than me in this gif Please note that I pressed up only two times at the end. Thus is only once in history !
Hmm, extra steps Execute things as above Press up to go through history, it works Press down to go back Press down a couple extra times - I did this because I was expecting to get back to an empty input if I press down Then, I press up on and nothing happens, it's still on !
Ok, the issue is when you reach the end of history up / down take an extra hit to get the previous or the next one. Duplication is not related. Renaming this issue. I am open for PRs that fix this Code pointer Probably the has an issue at the end of history
Hello. I would like to contribute on this if you are open. I will submit a PR as soon as I fix it :)
To verify: debugging, open debug console , then evaluate sure pressing up gets you all the way back to the end of history in the debug console input sure pressing down gets you immieadly to the previous history element. Thus no duplicatino happens
Change:
nameElement.style.display = 'none'; valueElement.style.display = 'none'; inputBoxContainer.style.display = 'initial'; <ins> dom.clearNode(inputBoxContainer); </ins> const inputBox = new InputBox(inputBoxContainer, this.contextViewService, { ...options, inputBoxStyles: defaultInputBoxStyles });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.0 OS Version: Mac 12.2.1 intel Steps to Reproduce: the debug activitybar of the local vscode. If the currently opened project does not have , you need to create a new one to activate debug. a test Expression, and watch carefully. problems: end of the text is truncated because of italics. icon container is not vertically centered. !
By the way, there is also a inputbox offset problem. Sometimes there are two border above the expression, which looks like there is a inputbox at the top but it is covered. As well as the vertical center of the inputbox, there are also some small deviations. ! I can't reproduce steadily, but I know that this problem existed before many versions. !
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Change:
"config.timeline.date": "Controls which date to use for items in the Timeline view", "config.timeline.date.committed": "Use the committed date", "config.timeline.date.authored": "Use the authored date", <ins> "config.defaultStashMessage": "Controls whether to use message from commit input box (if populated) as default stash messages", </ins> "submenu.commit": "Commit", "submenu.commit.amend": "Amend", "submenu.commit.signoff": "Sign Off",

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Current Behavior: I have staged changes and typed a commit message. I choose Stash Stash I am prompted to enter a stash description Desired Behavior: If commit message is entered, automatically use it as the stash description instead of prompting.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.767 --- <!-- score: 0.663 --- <!-- score: 0.586 --- <!-- score: 0.559 --- <!-- score: 0.54 --<!-- potentialduplicatescomment --
Is this issue available to work on?
perhaps the simplest implementation is just to default the stash description prompt to the commit message?
! doesn't work for me
Sorry for the hassle but we decided to go and put this behind a setting instead: .
A little overkill if you ask me. But it works
I know... explanation is here: I guess the PR author didn't want to go with option 2 ;)