jiebi/CodeConvo huggingface dataset:
Change:
*/ target: IHoverDelegateTarget | HTMLElement; /** <del> * Position of the hover. The default is to show above the target. This option will be ignored * if there is not enough room to layout the hover in the specified position, unless the * forcePosition option is set. */ hoverPosition?: HoverPosition; /** * Whether to show the hover pointer */ showPointer?: boolean; /** * Whether to skip the fade in animation, this should be used when hovering from one hover to * another in the same group so it looks like the hover is moving from one element to the other. */ skipFadeInAnimation?: boolean; /** </del> * The container to pass to {@link IContextViewProvider.showContextView} which renders the hover * in. This is particularly useful for more natural tab focusing behavior, where the hover is * created as the next tab index after the element being hovered and/or to workaround the * element's container hiding on `focusout`. */ container?: HTMLElement; <ins> /** * Options that defines where the hover is positioned. */ position?: { /** * Position of the hover. The default is to show above the target. This option will be ignored * if there is not enough room to layout the hover in the specified position, unless the * forcePosition option is set. */ hoverPosition?: HoverPosition; }; appearance?: { /** * Whether to show the hover pointer */ showPointer?: boolean; /** * Whether to skip the fade in animation, this should be used when hovering from one hover to * another in the same group so it looks like the hover is moving from one element to the other. */ skipFadeInAnimation?: boolean; }; </ins> } export interface IHoverDelegate {

Discussion:
Type: <bBug</bTooltip position changed VSCode insiders and also see the right pointer is also missing Insiders release ! Stable release ! VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-24T15:21:39.004Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ ng-template17.0.2 multi-cursor-case-preserve1.0.5 codeium1.4.20 codium0.7.19 svg-gallery2.1.0 console-log0.6.2 gitlens2023.11.2404 vscode-test-explorer2.21.1 angular2-switcher0.4.0 vscode-jest-test-adapter0.8.1 template-string-converter0.6.1 test-adapter-converter0.1.8 gitpatch0.2.1 material-icon-theme4.32.0 pretty-ts-errors0.5.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Assuming this could be a bug in Hover infrastructure. Please let me know if it is otherwise.
Change:
} private refresh(): void { <del> this.enabled = workspace.getConfiguration('git', null).get('terminalAuthentication', true); </del> <ins> const config = workspace.getConfiguration('git', null); this.enabled = config.get<boolean>('enabled', true) && config.get('terminalAuthentication', true); </ins> } dispose(): void {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.0 OS Version: Ubuntu 19.10 Steps to Reproduce: add: { "git.enabled": false, "git.terminalAuthentication": false, "git.githubAuthentication": false, } to push from the integrated terminal <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Error text: Missing or invalid credentials. Error: connect ENOENT at PipeConnectWrap.afterConnect [as oncomplete] () { errno: 'ENOENT', code: 'ENOENT', syscall: 'connect', address: '' }
Did you restart the terminal after your disabled it?
Yes, I've both killed the terminal and restarted the VM. Not sure if this is helpful, but before I the two new settings vscode was trying to handle the authentication even though I had set (requesting username and password from the command palette). That's what sent me looking for the new settings in the first place.
Change:
const lineHeight = editor.getOption(EditorOption.lineHeight); const contentHeight = (editor.getModel()?.getLineCount()! * lineHeight) ?? editor.getContentHeight(); // Can't just call getContentHeight() because it returns an incorrect, large, value when the editor is first created. if ((contentHeight > layoutInfo.height) || <del> (contentHeight < layoutInfo.height && currentHeight > STARTING_EDITOR_HEIGHT)) { </del> <ins> (contentHeight < layoutInfo.height && currentHeight > MIN_EDITOR_HEIGHT)) { </ins> const linesToAdd = Math.ceil((contentHeight - layoutInfo.height) / lineHeight); <del> const maxCommentEditorHeight = Math.max(Math.min(MAX_EDITOR_HEIGHT, parentEditor.getLayoutInfo().height - 90), STARTING_EDITOR_HEIGHT); const newEditorHeight = Math.min(maxCommentEditorHeight, layoutInfo.height + (lineHeight * linesToAdd)); return newEditorHeight; </del> <ins> const proposedHeight = layoutInfo.height + (lineHeight * linesToAdd); return clamp(proposedHeight, MIN_EDITOR_HEIGHT, clamp(parentEditor.getLayoutInfo().height - 90, MIN_EDITOR_HEIGHT, MAX_EDITOR_HEIGHT)); </ins> } return currentHeight; }

Discussion:
window a comment :bug: as you can see from the scrollbar, the comment text doesn't fill the full editor !
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
closedWith
Change:
run: () => openerService.open(fix.uri), tooltip: label, uri: fix.uri <del> } as ITerminalAction; </del> <ins> }; </ins> break; } }

Discussion:
Testing For built-in quick fixes, the command is automatically run after selecting it. However, for custom ones, it just emits a ctrl+c and writes out the command without actually running it !
Cannot reproduce on Windows
!
can you reproduce only w the contributed fix or also the builtin ones IE ?
The built-in git one works fine, only the contributed one doesn't. The command being returned is the string . There's no new line at the end of that string, which might(?) be triggering the automatic entering if that's being returned in built-in matchers...
Updated my original comment. It's not an OS thing, just built-in vs contributed
This was working at one pt. Probably a regression when I removed as a property. thanks for the info
Change:
supportsGitHubEnterpriseServer: false, supportsHostedGitHubEnterprise: true, supportsRemoteExtensionHost: true, <del> supportsWebWorkerExtensionHost: true, </del> <ins> // Web worker can't open a port to listen for the redirect supportsWebWorkerExtensionHost: false, </ins> // exchanging a code for a token requires a client secret supportsNoClientSecret: false, supportsSupportedClients: true,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Currently signing out of your GitHub account only removes the token from the secret store but the token continues to be valid, which means that if it was leaked the attacker can continue to make use of it. To mitigate this, VS Code should revoke the token on sign out, see this API:
I wish this API didn't require the client secret...
Change:
super({ ...(options as IViewletPanelOptions), ariaHeaderLabel: options.title }, keybindingService, contextMenuService, configurationService); } <ins> protected renderHeader(container: HTMLElement): void { this.renderHeaderTitle(container); } </ins> renderHeaderTitle(container: HTMLElement): void { super.renderHeaderTitle(container, this.options.title);

Discussion:
on insiders !
Do you know of any recent changes to relevant CSS? If not I'll take a look
Good chance it was this () commit.
I suppose this is a duplicate.
Yes that was part of it
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Uri, commands, Disposable, window, workspace, QuickPickItem, OutputChannel, Range, WorkspaceEdit, Position, LineChange, SourceControlResourceState, TextDocumentShowOptions, ViewColumn, ProgressLocation, TextEditor, MessageOptions, WorkspaceFolder } from 'vscode'; </del> <ins> import { Uri, commands, Disposable, window, workspace, QuickPickItem, OutputChannel, Range, WorkspaceEdit, Position, LineChange, SourceControlResourceState, TextDocumentShowOptions, ViewColumn, ProgressLocation, TextEditor, MessageOptions, WorkspaceFolder, Progress } from 'vscode'; </ins> import { Git, CommitOptions, Stash, ForcePushMode } from './git'; import { Repository, Resource, ResourceGroupType } from './repository'; import { Model } from './model';

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --When downloading a GIT repository should indicate the percentage of download. <!-- Describe the feature you'd like. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.484 --<!-- potentialduplicatescomment --
I would like to take this.
Change:
import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'; import { IMainProcessService } from 'vs/platform/ipc/common/mainProcessService'; <del> import { IssueReporter } from './IssueReporterService'; </del> <ins> import { IssueReporter } from './issueReporterService'; </ins> import { InstantiationService } from 'vs/platform/instantiation/common/instantiationService'; import { getSingletonServiceDescriptors } from 'vs/platform/instantiation/common/extensions'; import { registerMainProcessRemoteService } from 'vs/platform/ipc/electron-sandbox/services';

Discussion:
This file seems to user upper case letter: For this you need to use a command I think so that clients update accordingly.
Change:
if (shouldFire) { this.editorsAffectingFilter.clear(); <del> this.uriVisibilityMap.clear(); </del> this._onDidChange.fire(); } } filter(stat: ExplorerItem, parentVisibility: TreeVisibility): boolean { <del> const cachedVisibility = this.uriVisibilityMap.get(stat.resource); if (typeof cachedVisibility === 'boolean') { return cachedVisibility; } const isVisible = this.isVisible(stat, parentVisibility); this.uriVisibilityMap.set(stat.resource, isVisible); return isVisible; </del> <ins> return this.isVisible(stat, parentVisibility); </ins> } private isVisible(stat: ExplorerItem, parentVisibility: TreeVisibility): boolean {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --Related Issues: <!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Linux x64 5.8.0-44-generic Steps to Reproduce: a root folder (files-exclude-sample) that folder create two nested folders (child1, child2) root folder (files-exclude-sample), create a workspace definition file (files-exclude-) root folder (files-exclude-sample), create a .vscode folder .vscode folder create a file to previous steps, just clone this GitHub repo: VSCode, open the workspace (files-exclude-) looks ok. You have tree root folders (files-exclude-sample, child1 and child2) ! you expand all three folder you can see something like ! specified in root folder , child1 and child2 are excluded from child1 folder child1 folder is collapsed (not removed from explorer tree) and it appears inside root folder (files-exclude-sample) folder ! expected behavior is that child1 is not collapsed and it does not appear inside root folder <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
the owner of the file explorer is
I acknowledge this issue. MR workspace support with when one root folder is a subfolder of another root folder has some issues. If somebody is passionate about fixing this let me know and I can provide pointers
Created fixing this
Thanks to a great pr by this is now fixed
Change:
continue; } <ins> if (!attributes) { attributes = await this.remoteExplorerService.tunnelModel.getAttributes(this.remoteExplorerService.tunnelModel.candidates); } const portAttributes = attributes?.get(value.port); </ins> const address = makeAddress(value.host, value.port); <del> if (this.initialCandidates.has(address)) { </del> <ins> if (this.initialCandidates.has(address) && (portAttributes?.onAutoForward === undefined)) { </ins> continue; } if (this.notifiedOnly.has(address) || this.autoForwarded.has(address)) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Code space VS code OS Version: Codespaces Steps to Reproduce: is the file for initializing docker in codespace: space is not automatically port forwarding or I'm not able to manually add the port forwarding. 've tried with and without --host in
any help here? much appreciated!
since you have in your I would expect Codespaces to forward the port when you connect to the Codespace. For that, I would recommend you report an issue over in If you don't include the property then we should see that something is listening on 3000 and forward it. However, we don't forward ports that already have something listening on them at the time that VS Code connects to the Codespace. I think that your is happing a bit sooner than we expect and then we don't forward the port. Since you do have configured we should still forward the port. I'll make a fix for this. It should be in a VS Code insiders build by the end of the week.
Change:
} } <del> class OpenDisassemblyViewAction extends EditorAction { </del> <ins> class OpenDisassemblyViewAction extends EditorAction2 { </ins> public static readonly ID = 'editor.debug.action.openDisassemblyView'; <del> public static readonly LABEL = nls.localize('openDisassemblyView', "Open Disassembly View"); </del> constructor() { super({ id: OpenDisassemblyViewAction.ID, <del> label: OpenDisassemblyViewAction.LABEL, alias: 'Debug: Go to Disassembly', precondition: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, PanelFocusContext.toNegated(), CONTEXT_DEBUG_STATE.isEqualTo('stopped'), EditorContextKeys.editorTextFocus, CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED, CONTEXT_LANGUAGE_SUPPORTS_DISASSEMBLE_REQUEST), contextMenuOpts: { group: 'debug', order: 5 } </del> <ins> title: { value: nls.localize('openDisassemblyView', "Open Disassembly View"), original: 'Open Disassembly View', mnemonicTitle: nls.localize({ key: 'miDisassemblyView', comment: ['&& denotes a mnemonic'] }, "&&DisassemblyView") }, precondition: CONTEXT_FOCUSED_STACK_FRAME_HAS_INSTRUCTION_POINTER_REFERENCE, menu: [ { id: MenuId.EditorContext, group: 'debug', order: 5, when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, PanelFocusContext.toNegated(), CONTEXT_DEBUG_STATE.isEqualTo('stopped'), EditorContextKeys.editorTextFocus, CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED, CONTEXT_LANGUAGE_SUPPORTS_DISASSEMBLE_REQUEST) }, { id: MenuId.DebugCallStackContext, group: 'z_commands', order: 50, when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, CONTEXT_DEBUG_STATE.isEqualTo('stopped'), CONTEXT_CALLSTACK_ITEM_TYPE.isEqualTo('stackFrame'), CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED) }, { id: MenuId.CommandPalette, when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, CONTEXT_DEBUG_STATE.isEqualTo('stopped'), CONTEXT_DISASSEMBLE_REQUEST_SUPPORTED) } ] </ins> }); } <del> async run(accessor: ServicesAccessor, editor: ICodeEditor, ...args: any[]): Promise<void> { </del> <ins> runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, ...args: any[]): void { </ins> if (editor.hasModel()) { const editorService = accessor.get(IEditorService); editorService.openEditor(DisassemblyViewInput.instance, { pinned: true });

Discussion:
Testing As already pointed out The "Open Disassembly View" command is now only visible when the active stackframe has a instructionPointerReference property. This makes it hard to discover. I suggest to have the context menu's "Open Disassembly View" command always visible if a debug adapter has the supportsDisassembleRequest capability. But the command should only be enabled if the active stackframe has a instructionPointerReference property. That results in a more stable user experience. Apart from that we should have the Open Disassembly View command in the command palette.
That's a fair suggestion. However, we are not sure how to disable a command...
commands have clauses and . clause determines if the command is present at all and if it is disabled. So please use the when registering the editor command for disablement.
Also we should consider to introduce a call stack context menu action for the Open Disassembly View.
will fix this.
Change:
result.partsCount = partsCount; return result; <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
open a markdown file with bold markup, e.g. abc text xyz try to select the line with the mouse starting at 'abc' and slowly extending to 'xyz' Observe: if you reach the second '', the selection of 'text**' disappears. In the end you have two disconnected selection ranges. in addition I see lots of flashing selection changes while dragging the mouse
Change:
const actions = [ this.instantiationService.createInstance(ExtensionStatusLabelAction), this.instantiationService.createInstance(MigrateDeprecatedExtensionAction, true), <del> this.instantiationService.createInstance(UpdateAction), </del> reloadAction, <ins> this.instantiationService.createInstance(UpdateAction), </ins> this.instantiationService.createInstance(InstallDropdownAction), this.instantiationService.createInstance(InstallingLabelAction), this.instantiationService.createInstance(SetLanguageAction),

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (but requires an extension for the repro) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 or the latest Insiders. OS Version: Windows (I assume others too) Steps to Reproduce: some extension. to an older version of the extension. Bug: If the Extensions pane is not wide enough, the "Reload Required" UI is not visible, which makes it easy for users to mistakenly believe that no reload was required and that it's using the downgraded version already, when it is not. ! Suggested fix: Render the "Reload Required" button with higher precedence and/or on the left of the "Upgrade to" button and/or render it below, etc. -- or maybe don't render the "Upgrade to" button yet until the Reload is done.
Change:
import diffei = require('vs/workbench/common/editor/diffEditorInput'); import { IGitService, Status, IFileStatus, StatusType } from 'vs/workbench/parts/git/common/git'; import gitei = require('vs/workbench/parts/git/browser/gitEditorInputs'); <del> import { getSelectedChanges, applyChangesToModel } from 'vs/workbench/parts/git/common/stageRanges'; </del> <ins> import { getSelectedChanges, applyChangesToModel, getChangeRevertEdits } from 'vs/workbench/parts/git/common/stageRanges'; </ins> import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService'; import { IViewletService } from 'vs/workbench/services/viewlet/browser/viewlet'; import { IPartService, Parts } from 'vs/workbench/services/part/common/partService';

Discussion:
There's probably already a feature request for this but I can't find it. I want to be able to select a change in the diff editor and revert it, same as how I can stage it. In SourceTree this is called "discard selected lines" although "revert" seems better, unless it's "discard selected changes". I'm working on a PR for this.
I think it is connected with
Change:
} if (e.button === /* Right */ 2) { <ins> e.stopPropagation(); e.preventDefault(); </ins> contextMenuService.showContextMenu({ getAnchor: () => checkBox.domNode, getActions: item.getContextMenuActions, }); <del> e.stopPropagation(); e.preventDefault(); </del> } else if (e.button === /* Middle */ 1) { <del> item.toggleBothSides(); </del> e.stopPropagation(); e.preventDefault(); <ins> item.toggleBothSides(); </ins> } }) );

Discussion:
!
I heard of this before, but unfortunately, I cannot reproduce this on windows.
I also cannot repro on mac. That to me looks like a custom checkbox implementation, so it should not be platform dependant. maybe you check how we handle clicks to trigger context menu, if there is a bug it should be there. For example, maybe first stop propagating the event before you trigger the context menu here That might fix it. Since context menu show freezes the renderer process, so it might happen that the click event can not get canceled after that and it results in the unexpected click.
This got obsolete by the transition to code-lens actions.
Change:
const testDocument = workspaceFile('bower.json'); <del> suite.skip('vscode API - webview', () => { </del> <ins> flakySuite('vscode API - webview', () => { </ins> const disposables: vscode.Disposable[] = []; function _register<T extends vscode.Disposable>(disposable: T) {

Discussion:
Couple of milestones ago I have skipped these tests becuase they were failing. I am not sure if I created the issue at the moment but I am doing that now. Sorry if I did not ping sooner. Code pointer
I had to revert this change: I think they cause our browser integration tests to hang/fail:
Change:
.monaco-inputbox > .ibwrapper { position: relative; width: 100%; <del> height: 100%; </del> } .monaco-inputbox > .ibwrapper > .input {

Discussion:
move editor into its own window trigger find the input box is cropped, the border isn't fully visible !
I can reproduce and I am puzzled as to why this is. Opening for help wanted for a CSS wizard to step in if possible. Steps: open a text editor in the main window open the find widget and focus it, notice how the blue outline color goes all the way around the input box right click into the editor tab and "Copy into New Window" do the same and notice that the outline is cropped I already see that the wrapper around the is in the main window and in the auxiliary window ! ! CSS is defined from here: and
I can fix this, please assign me this issue if it's still open
we cannot assign issues to non-members of the team, but feel free to open a PR. Thanks!
sure, thanks for letting me know.