jiebi/CodeConvo huggingface dataset:
Change:
*--------------------------------------------------------------------------------------------*/ import * as platform from 'vs/base/common/platform'; <del> import { IKeyValueStorage, IExperimentationTelemetry, IExperimentationFilterProvider, ExperimentationService as TASClient } from 'tas-client'; </del> <ins> import type { IKeyValueStorage, IExperimentationTelemetry, IExperimentationFilterProvider, ExperimentationService as TASClient } from 'tas-client'; </ins> import { MementoObject, Memento } from 'vs/workbench/common/memento'; import { IProductService } from 'vs/platform/product/common/productService'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';

Discussion:
It looks like we a new dependency to which adds substantial time to our startup: ! This module should be loaded via only when used. //cc
Yeah, this is a really bulky module since it doesn't seem to be bundled in any way. Ideally, this loaded async and bundled <img width="377" alt="Screenshot 2020-08-25 at 11 09 05" src="https://user-"
On top of this discussion, we also need to think about wether this module should be supported in web and then it should be webpacked accordingly, similar to our UMD variants (, ...).
I have published the umd variant (though i messed up the typings so it needs an update), it just needs adoption.
sounds good. Loading this dependency async would be good in any case, even if you pick up the UMD variant as we avoid having to load the contents right on startup if not needed.
PR is up:
Change:
// Catch the ProcessEnded event here, which occurs before inactive, and capture the exit code to prevent this. return (e.kind === TaskEventKind.Inactive || (e.kind === TaskEventKind.ProcessEnded && e.exitCode === undefined)) <del> && e.__task?.getMapKey() === taskKey; </del> <ins> && getTaskKey(e.__task) === taskKey; </ins> }, this.taskService.onDidStateChange)(e => { taskStarted = true; c(e.kind === TaskEventKind.ProcessEnded ? { exitCode: e.exitCode } : null); })); const promise: Promise<ITaskSummary | null> = this.taskService.getActiveTasks().then(async (tasks): Promise<ITaskSummary | null> => { <del> if (tasks.find(t => t.getMapKey() === taskKey)) { </del> <ins> if (tasks.find(t => getTaskKey(t) === taskKey)) { </ins> // Check that the task isn't busy and if it is, wait for it const busyTasks = await this.taskService.getBusyTasks(); <del> if (busyTasks.find(t => t.getMapKey() === taskKey)) { </del> <ins> if (busyTasks.find(t => getTaskKey(t) === taskKey)) { </ins> taskStarted = true; return inactivePromise; } // task is already running and isn't busy - nothing to do. return Promise.resolve(null); } <del> once(e => ((e.kind === TaskEventKind.Active) || (e.kind === TaskEventKind.DependsOnStarted)) && e.__task?.getMapKey() === taskKey, this.taskService.onDidStateChange)(() => { </del> <ins> once(e => ((e.kind === TaskEventKind.Active) || (e.kind === TaskEventKind.DependsOnStarted)) && getTaskKey(e.__task) === taskKey, this.taskService.onDidStateChange)(() => { </ins> // Task is active, so everything seems to be fine, no need to prompt after 10 seconds // Use case being a slow running task should not be prompted even though it takes more than 10 seconds taskStarted = true;

Discussion:
a debug config like and a task like F5. You're all good the window. Hit F5 again, and observe the terminal with the task gets restored. get this dialog. I don't really want either of these options, it's already a background task that should be in the 'end' state  or restart the task and try to F5 again. This doesn't work either and you have to reload the window to get debugging work again
Did this work until recently?
Also doesn't a pre launch task get run every time one debugs?
I think so... I honestly don't use preLaunchTask's as much as I should due to a history of papercuts, but I definitely haven't seen this notification before. Yea, but if it's a background task that's already running it shouldn't get run again. I'm not sure how much of this issue is in debug vs tasks
The task stops running on reload of the window because the terminal is killed. That's why it has to run again on window reload. Perhaps the solution is to not reconnect (IE restart) prelaunch tasks.
Currently, we persist any background task that has problem matchers.
Should have been fixed with , pls reopen if not
I can still repro in today's Insiders
are you reproducing using the task above?
I'm using a simpler task following the other issue:
works when I use . So has to do with debugging specifically
Change:
} const query = this.searchWidget.getValue().trim(); <ins> this.viewState.query = query; </ins> this.delayedFilterLogging.cancel(); await this.triggerSearch(query.replace(/u203A/g, ' '));

Discussion:
Issue Type: <bBug</bthe settings UI. for a setting (e.g. "inlay"). the settings tab to a new editor group. Note that the search you entered previously has been cleared. https://user- VS Code version: Code 1.60.0 (, 2021-09-01T10:54:53.442Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 vscode-nginx-conf0.1.3 reorder-lines-by-length1.0.2 docs-view0.0.9 pgformatter1.17.0 vscode-eslint2.1.25 gitlens11.6.0 vscode-diff1.4.2 shell-format7.1.0 go0.27.2 postgresql0.0.2 rainbow-csv1.9.1 render-crlf1.5.21 template-string-converter0.5.3 python2021.9. vscode-pylance2021.9.2 jupyter2021.8. jupyter-keymap1.0.0 debugger-for-chrome4.13.0 nbsp-vscode0.0.1 vscode-commons0.0.6 vscode-yaml0.22.0 final-newline0.3.2 vscode-hexdump1.8.1 change-case1.0.0 markdown-all-in-one3.4.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
A function called in is being called after the drop, which is correct. But, the function in the same file name isn't being called when the user does step 3 above. Another repro is to use the "move editor to X group" commands. Therefore, the fix doesn't have to do directly with dnd.
Change:
this._keybindingInputWidget.startRecordingKeys(); this._register(this._keybindingInputWidget.onKeybinding(keybinding => this.onKeybinding(keybinding))); this._register(this._keybindingInputWidget.onEnter(() => this.hide())); <del> this._register(this._keybindingInputWidget.onEscape(() => this.onEscape())); this._register(this._keybindingInputWidget.onBlur(() => this.onBlur())); </del> <ins> this._register(this._keybindingInputWidget.onEscape(() => this.clearOrHide())); this._register(this._keybindingInputWidget.onBlur(() => this.onCancel())); </ins> this._outputNode = dom.append(this._domNode.domNode, dom.$('.output')); this._showExistingKeybindingsNode = dom.append(this._domNode.domNode, dom.$('.existing'));

Discussion:
Type: <bBug</bPreviously pressing escape while "Record Keys" was active in the keybindings UI would disable key recording and leave the search query intact. Now it disables key recording and clears the search query which makes it much harder to use. I traced this regression to 1.78. I'm guessing this is an issue with keybindings. The binding for is being processed in addition to the (hard-coded?) binding to stop recording. ! VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-04T22:11:08.187Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
import { IJSONSchema } from 'vs/base/common/jsonSchema'; import { textmateColorsSchemaId, registerColorThemeSchemas, textmateColorSettingsSchemaId } from 'vs/workbench/services/themes/common/colorThemeSchema'; import { workbenchColorsSchemaId } from 'vs/platform/theme/common/colorRegistry'; <ins> import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions'; </ins> // implementation

Discussion:
Improve user experience while installing themes
!
It would be cool if you could preview themes in the store, maybe with a split view hosting some example code, or even with the files you have open.
Please open a feature request for it
Change:
"tas-client-umd": "0.1.5", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.55", </del> <ins> "xterm": "4.19.0-beta.56", </ins> "xterm-addon-search": "0.9.0-beta.39", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.36"

Discussion:
Testing Have the same content in the editor and in the terminal. Search for something. Notice how the occurrence are fat and visible in the editor scrollbar. Notice how they are not fat and sparse in terminal. They seem to be incorrectly placed since my match is almost on every line and that is not the feeling I get from the terminal scroll bar ! !
How many lines do you have in the editor for this example? It looks like there are a bunch of empty lines near the bottom? The way we calculate the position of terminal scroll bar decorations is line / number of lines in the buffer.
I had the same number of lines as the terminal which is 23. If I had more lines in the editor I think that would mean that the decorations are smaller in the editor, not larger and that seems to be happening :)
to me, it looks like the decorations are closer together and not taking up as much vertical space in the scrollbar see how the lower half is just empty? !
Good point. Now I have disabled scrolling beyond last line in the editor. And they render the equal height. But look at the decorations - they are very different. Do you also see this on your machine? !
The ones in the editor are double the height - likely because of device pixel ratio on a mac that's getting taken into account there and probably should be also for the terminal. ! !
Strange because we are doing the right thing here, but is 1 here for me on a mac . !
We can make these heights different based on the number of lines in the buffer similar to what the editor does
Upstream issue:
Change:
"end": "^s*#[eE]nd[rR]egionb" } } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I'll have a PR out for this in a sec. Wanted to get an issue tracking it. These and should autoclose. NOTE: PowerShell syntax says that the here string open () should be the last characters on a line so we should include a newline in the close.
Change:
.vscode-dark img[src$=#gh-light-mode-only], .vscode-light img[src$=#gh-dark-mode-only], <del> .vscode-high-contrast img[src$=#gh-light-mode-only], </del> <ins> .vscode-high-contrast:not(.vscode-high-contrast-light) img[src$=#gh-light-mode-only], </ins> .vscode-high-contrast-light img[src$=#gh-dark-mode-only] { display: none; }

Discussion:
High Contrast themes display both dark and light mode markdown content simultaneously. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: MacOS 14.2.1 Steps to Reproduce: a markdown document an image with both a light and dark variant to a high-contrast theme if both light and dark variants are displayed
works, but causes the image to never show.
Change:
if (this.cell.checkIfOutputsModified()) { this.notebookEditor.deltaCellOutputContainerClassNames(DiffSide.Original, this.cell.original.id, ['nb-cellDeleted'], []); this.notebookEditor.deltaCellOutputContainerClassNames(DiffSide.Modified, this.cell.modified.id, ['nb-cellAdded'], []); <ins> } else { this.notebookEditor.deltaCellOutputContainerClassNames(DiffSide.Original, this.cell.original.id, [], ['nb-cellDeleted']); this.notebookEditor.deltaCellOutputContainerClassNames(DiffSide.Modified, this.cell.modified.id, [], ['nb-cellAdded']); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66 OS Version: Windows 11 Steps to Reproduce: diff view to revert the output changes :bug: after reverting the diff view still says there are deletions/additions output changes using the diff view :bug: stage the file and reopen the diff view, all the changes I reverted are back
Change:
this.domNode = document.createElement('div'); this.domNode.className = `monaco-tree no-focused-item monaco-tree-instance-${this.instance}`; <del> this.domNode.tabIndex = 0; </del> <ins> if (!context.options.preventRootFocus) { this.domNode.tabIndex = 0; } </ins> this.styleElement = DOM.createStyleSheet(this.domNode);

Discussion:
While testing . VSCode Version: Code - Insiders 1.15.0-insider (, 2017-08-01T05:07:59.267Z) OS Version: Darwin x64 16.7.0 Steps to Reproduce: 3 terminals from the command palette <kbdArrowDown</kbdto the last terminal in the switcher <kbdTab</kbdto rename the terminal -keyboard focus disappears from the input box (and seems to be nowhere). I need a second <kbdTab</kbdto move the keyboard focus to the rename action in the selected row. A single <kbdTab</kbdshould suffice.
This is also an issue with task configuration
Change:
'description': nls.localize('keybindings.json.key', "Key or key sequence (separated by space)"), }, 'command': { <ins> 'type': 'string', </ins> 'description': nls.localize('keybindings.json.command', "Name of the command to execute"), }, 'when': {

Discussion:
Issue Type: <bBug</bAutocomplete works fine for & (after you accept suggestion) ==Can this be anything else beside string type? actual: =expected: <sCan this be anything else beside object? actual: =expected: </sOk, can be object or string. VS Code version: Code 1.28.2 (, 2018-10-17T00:23:51.859Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Change:
} const fileMatchParentParts: URI[] = []; <del> const normalizedResource = this.uriIdentityService.extUri.normalizePath(this.resource); </del> let uri = this.normalizedUriParent(rawFileMatch.resource); <del> while (!this.uriEquals(normalizedResource, uri)) { </del> <ins> while (!this.uriEquals(this.normalizedResource, uri)) { </ins> fileMatchParentParts.unshift(uri); const prevUri = uri; <del> uri = this.normalizedUriParent(uri); </del> <ins> uri = this.uriIdentityService.extUri.removeTrailingPathSeparator(this.normalizedUriParent(uri)); </ins> if (this.uriEquals(prevUri, uri)) { <del> throw Error(`${rawFileMatch.resource} is not correctly configured as a child of ${normalizedResource}`); </del> <ins> throw Error(`${rawFileMatch.resource} is not correctly configured as a child of ${this.normalizedResource}`); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.2 OS Version: Windows 11 22H2 (.1778) Steps to Reproduce: ! a WSL folder from the command line with the argument --remote, with a trailing forward slash. Example: to search all files for any search term. The files will not appear. ! a WSL folder from the command line with the argument --remote, without a trailing forward slash. Example: to search all files for any search term. The files will appear. !
Change:
.extension-verified-publisher > .extension-verified-publisher-domain { padding-left: 2px; color: var(--vscode-extensionIcon-verifiedForeground); <ins> text-decoration: var(--text-link-decoration); </ins> } .extension-bookmark {

Discussion:
Testing No links in an extension metadata page show links underlined... !
Same as before, fixed and not merged in time via and underlines for the domain and resource section in
Change:
}, 'workbench.editor.enablePreviewFromQuickOpen': { 'type': 'boolean', <del> 'markdownDescription': localize({ comment: ['{0}, {1} will be a setting name rendered as a link'], key: 'enablePreviewFromQuickOpen' }, "Controls whether editors opened from Quick Open show as preview editors. Preview editors do not stay open, and are reused until explicitly set to be kept open (via double-click or editing). When enabled, hold Ctrl before selection to open an editor as a non-preview. This value is ignored when {0} is not set to {1}.", '`#workbench.editor.enablePreview#`', '`multiple`'), </del> <ins> 'markdownDescription': localize({ comment: ['{0}, {1} will be a setting name rendered as a link'], key: 'enablePreviewFromQuickOpen' }, "Controls whether editors opened from Quick Open show as preview editors. Preview editors do not stay open, and are reused until explicitly set to be kept open (via double-click or editing). When enabled, hold Ctrl before selection to open an editor as a non-preview. This value is ignored when {0} is not set to {1}.", '`#workbench.editor.showTabs#`', '`multiple`'), </ins> 'default': false }, 'workbench.editor.enablePreviewFromCodeNavigation': { 'type': 'boolean', <del> 'markdownDescription': localize({ comment: ['{0}, {1} will be a setting name rendered as a link'], key: 'enablePreviewFromCodeNavigation' }, "Controls whether editors remain in preview when a code navigation is started from them. Preview editors do not stay open, and are reused until explicitly set to be kept open (via double-click or editing). This value is ignored when {0} is not set to {1}.", '`#workbench.editor.enablePreview#`', '`multiple`'), </del> <ins> 'markdownDescription': localize({ comment: ['{0}, {1} will be a setting name rendered as a link'], key: 'enablePreviewFromCodeNavigation' }, "Controls whether editors remain in preview when a code navigation is started from them. Preview editors do not stay open, and are reused until explicitly set to be kept open (via double-click or editing). This value is ignored when {0} is not set to {1}.", '`#workbench.editor.showTabs#`', '`multiple`'), </ins> 'default': false }, 'workbench.editor.closeOnFileDelete': {

Discussion:
Testing <img width="822" alt="image" src="""When is not set to "multiple"`, but that setting is only a boolean, what is this referring to?
Change:
const basename = path.basename(file.path); if (basename === 'package.nls.json') { const json: PackageJsonFormat = JSON.parse(buffer.toString('utf8')); <del> const keys = Object.keys(json); const messages = keys.map((key) => { </del> <ins> const keys: Array<string | LocalizeInfo> = []; const messages: string[] = []; Object.keys(json).forEach((key) => { </ins> const value = json[key]; if (Is.string(value)) { <del> return value; </del> <ins> keys.push(key); messages.push(value); </ins> } else if (value) { <del> return value.message; </del> <ins> keys.push({ key, comment: value.comment }); messages.push(value.message); </ins> } else { <del> return `Unknown message for key: ${key}`; </del> <ins> keys.push(key); messages.push(`Unknown message for key: ${key}`); </ins> } }); getXlf().addFile(`extensions/${extensionName}/package`, keys, messages);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68-insider OS Version: Windows 11 Steps to Reproduce: pseudo language pack explorer view in empty window :bug: the Clone Repository command should not be localized here: ! I think the way we deal with this is with a comment to skip localization like this:
Yes, removing the buttons from the string to be translated is a good way to do this... though to be honest, that in the example you gave isn't needed anymore since (with 3 m's lol) was removed from the string :)
As far as I can tell, this issue should have been fixed with am I missing something or should we just nudge the translation team to fix the translation? Thank you!
This is on me. The comments are being dropped for some reason. I will investigate.
Thank you very much Let me know if I can help in any way.
Change:
const registryValues = Registry.as<IConfigurationRegistry>(Extensions.Configuration).getConfigurationDefaultsOverrides(); const overrideValueSource = registryValues.get(`[${languageSelector}]`)?.valuesSources?.get(this.setting.key); if (overrideValueSource) { <del> this.setting.defaultValueSource = overrideValueSource; </del> <ins> this.defaultValueSource = overrideValueSource; </ins> } } else { this.scopeValue = isConfigured && inspected[targetSelector];

Discussion:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.