jiebi/CodeConvo huggingface dataset:
Change:
this.createSearchResultsView(builder); this.actionRegistry = <any>{}; <del> let actions: Action[] = [new CollapseAllAction(this), new RefreshAction(this), new ClearSearchResultsAction(this)]; </del> <ins> let actions: Action[] = [new CollapseDeepestExpandedLevelAction(this), new RefreshAction(this), new ClearSearchResultsAction(this)]; </ins> actions.forEach((action) => { this.actionRegistry[action.id] = action; });

Discussion:
One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root: ! Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
hmmm...
This still annoys me a lot, especially if the results are only coming from one folder: !
Agreed, and there should be an external PR incoming for this. If not I'll fix it...
this behaves very nice now, thanks!
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-web-links/-/xterm-addon-web-links-0.2.1.tgz#6d1f2ce613e09870badf17615e7a1170a31542b2" integrity sha512-2KnHtiq0IG7hfwv3jw2/jQeH1RBk2d5CH4zvgwQe00rLofSJqSfgnJ7gwowxxpGHrpbPr6Lv4AmH/joaNw2+HQ== <del> xterm-addon-webgl@0.4.0-beta.11: version "0.4.0-beta.11" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.4.0-beta.11.tgz#0e4a7242e2353cf74aba55e5a5bdc0b4ec87ad10" integrity sha512-AteDxm1RFy1WnjY9r5iJSETozLebvUkR+jextdZk/ASsK21vsYK0DuVWwRI8afgiN2hUVhxcxuHEJUOV+CJDQA== xterm@4.3.0-beta.28.vscode.1: version "4.3.0-beta.28.vscode.1" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.3.0-beta.28.vscode.1.tgz#89b85398b5801708e833d08bf92b2124fa128943" integrity sha512-JNHNZyDtAWnybJTrenPzD6g/yXpHOvPqmjau91Up4onRbjQYMSNlth17SqaES68DKn/+4kcIl2c/RG5SXJjvGw== </del> <ins> xterm-addon-webgl@0.5.0-beta.7: version "0.5.0-beta.7" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.5.0-beta.7.tgz#b7b95a362e942ad6f86fa286d7b7bd8ee3e7cf67" integrity sha512-v6aCvhm1C6mvaurGwUYQfyhb2cAUyuVnzf3Ob/hy5ebtyzUj4wW0N9NbqDEJk67UeMi1lV2xZqrO5gNeTpVqFA== xterm@4.4.0-beta.13: version "4.4.0-beta.13" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.4.0-beta.13.tgz#f7c5fa0d2b098ce0dd8b7c96d3d5fcaee22b86ed" integrity sha512-ZoDOVO3w84CXekBveGw1H2lcvM4HkJG5suXesE/3S+N4DnBhBcK/vw4kdooALGoorJV2GtgA1XEA6+m4N5Sgnw== </ins> yauzl@^2.9.2: version "2.10.0"

Discussion:
Re macOS zsh with oh my zsh Run scripts described in Open with Canvas rendering and select all ! Open with WebGL rendering ! !
Upstream: I think the problem with inverse is the only issue there? Let me know if I'm wrong.
yup, that's the only issue I saw.
Change:
constructor(configuration: SymbolNavigationActionConfig, opts: IAction2Options) { super(SymbolNavigationAction.aaa(opts)); this.configuration = configuration; <del> SymbolNavigationAction._allSymbolNavigationCommands.add(opts.id); </del> <ins> SymbolNavigationAction._allSymbolNavigationCommands.set(opts.id, this); </ins> } override runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, arg?: SymbolNavigationAnchor | unknown, range?: Range): Promise<void> {

Discussion:
Commit: Datum: 2022-09-01T07:22:41.992Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 +left mouse click on a declaration moves the cursor to the reference if only one exists: https://user- +left mouse click on a declaration moves the cursor opens the reference menue if only multiple references exist: https://user- Commit: Datum: 2022-09-07T05:15:40.689Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/ Firefox/105.0 (Also doesnt work on the Desktop Electron App.) https://user- install the versions I listed above or use and you may use this example code : Maybe it has something to do with this:
Do you have configured?
Its the default: "editor.gotoLocation.alternativeDefinitionCommand": "" ! I used and without any account. So no custom settings or extensions. :) If I use another setting like "editor.gotoLocation.alternativeDefinitionCommand": "" it also doesnt work.
Does "Peek References" or "Go to References" work when invoked on that symbol? btw - this works for me using Safari or FF
yes https://user-
are you using with your account, or in a "private" window? ctrl+mouse also doesnt bring up the references popup in other chromium based browsers, like brave nightly or the Desktop version (also tried it in a new profile). ctrl+click on a reference brings me to the definition, so my ctrl key isnt broken :D
The bug is also happening if I choose english as a language and or keyboard layout.
The same thing is happening to me, I'm on insiders Version: 1.72.0-insider Commit: Date: 2022-09-07T05:18:06.866Z (1 day ago) Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Same here
Same here. This is no longer working with the latest VSCode Insider version.

For me it's not working with Dart code. If the usage is in the same file and there is only one, it will not jump there either.
I managed to reproduce with the steps in
Change:
this.commandKeyboardListener.value = addDisposableListener(this.labelContainer, EventType.KEY_DOWN, e => { const event = new StandardKeyboardEvent(e); if (event.equals(KeyCode.Space) || event.equals(KeyCode.Enter)) { <ins> EventHelper.stop(e); </ins> this.executeCommand(command); } });

Discussion:
Issue Type: <bBug</b<kbdTab</kbdto move focus to status bar. right-arrow to move focus to Settings Profiles item. spacebar to click the item (instead of Enter). :bug: quickpick opens pre-seeded with a single space character, causing the placeholder text not to appear. VS Code version: Code - Insiders 1.69.0-insider (, 2022-07-01T05:17:04.343Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --
/assign
This seems to be coming from status bar as the status bar triggers the command.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Change:
const actions: string[] = [ localize('saveWithConflict', "Save with Conflicts"), <del> localize('discard', "Don't save"), </del> <ins> localize('discard', "Don't Save"), </ins> localize('cancel', "Cancel"), ];

Discussion:
Testing As mentioned in the title it should be in this modal: <img width="405" alt="image" src="https://user-"
Thanks
Change:
errorTelemetry.dispose(); service.dispose(); <ins> sinon.restore(); </ins> })); test('Uncaught Error Telemetry removes PII from filename', sinonTestFn(function (this: any) {

Discussion:
In short, if you use without calling you are leaking memory. See for the details. I'm seeing a lot of memory used in unit tests and it appears to be coming from sinon. This may be contributing to our unit test OOM issue on Windows 32 bit. Let's see if fixing this lets us run the unit tests again. To fix I have made disposable, and there were some places where tests failed or the refactor seemed larger:
The biggest gain would be from fixing the leak from as it is used many places.
I don't know if you own , but I am looking into a fix for it since it will have the biggest impact.
I've reopened this.
Thanks. I should be careful to not do and instead as that will prevent GitHub from auto closing it
With , I have made disposable and handled disposing it in most tests. There are several places where the way to handle this isn't clear or made test fail when I just naively disposed it. I have them in the issue above.
the instance in is already restored at , but the others should be fixed in Let me know if I miss any! Edit: I ended up making changes in both files.
For those tests where I am just using , should I have to still call or I should wait for your change to dispose the ?
You can wait for my change to dispose the .
FYI Windows ia32 started turning green again
and the only files left are yours. The is now disposable and should be disposed in these test files to properly restore and prevent a memory leak.
Thank you for the fast response everyone!
need help
Change:
case KeyCode.Home: if (event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey) { this.ui.list.focus(QuickInputListFocus.First); <del> event.preventDefault(); </del> <ins> dom.EventHelper.stop(event, true); </ins> } break; case KeyCode.End: if (event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey) { this.ui.list.focus(QuickInputListFocus.Last); <del> event.preventDefault(); </del> <ins> dom.EventHelper.stop(event, true); </ins> } break; }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.44.2 OS Version: Ubuntu 19.10 Steps to Reproduce: navigate editors through QuickOpen "navigate next" and "navigate previous" work as "navigate next after next" and "navigate previous of previous". So simply said it skip next/previous editor. Here are keybindings I use ` works ok, but and don't <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
PR: The issue is that we are listening to keys within the quick input control to do certain things but we do not prevent bubbling. This means our keybinding service will also receive these keys and check for actions to perform. In the old quick open widget we always prevented bubbling for that reason.
Change:
'libgtk-3-0 (>= 3.9.10) | libgtk-4-1', 'libnss3 (>= 3.26)', 'libcurl3-gnutls | libcurl3-nss | libcurl4 | libcurl3', // For Breakpad crash reports. <del> 'xdg-utils (>= 1.0.2)' // OS integration </del> <ins> 'xdg-utils (>= 1.0.2)', // OS integration 'libgssapi-krb5-2', 'libkrb5-3', </ins> ]; // Based on https://source.chromium.org/chromium/chromium/src/+/main:chrome/installer/linux/debian/manual_recommends

Discussion:
On Ubuntu 16.04 <img width="571" alt="image" src=""Originally posted by in
On ubuntu 18.04 and using apt, almost the same error
Steps for verification: In Ubuntu 18.04 VM or Ubuntu 16.04 VM Install insiders debian package from Verify that error seen in is not shown and update completes successfully
Closing for verification.
Change:
import { IPosition } from '../../../../../editor/common/core/position.js'; import { Range } from '../../../../../editor/common/core/range.js'; import { SearchParams } from '../../../../../editor/common/model/textModelSearch.js'; <ins> import { IModelContentChangedEvent } from '../../../../../editor/common/textModelEvents.js'; </ins> class StackOperation implements IWorkspaceUndoRedoElement { type: UndoRedoElementType.Workspace;

Discussion:
Testing 1) I started with 2) I ran the first two cells and then committed 3) I reran cell 1 4) I changed cell 3 to use different file names 5) I opened the notebook diff from the SCM view -(a) cell metadata changes were shown -(b) changes to cell 3 where hidden -(c) toggling the "Toggle Collapse Unchanged Regions" didn't do anything !
I was unable to reproduce (b) reliably.
Verifier: Make the workbench small enough so when opening only the first cells show up Run the first two cells Commit/stage the file Scroll to the last cell, make changes, save (if you don't have auto save) Open the diff view, the change in the last cell should be rendered.
cannot test this due to
Change:
builtin return fi <del> # Disable shell integration if HISTCONTROL is set to erase duplicate entries as the exit code # reporting relies on the duplicates existing if [[ "$HISTCONTROL" =~ .*erasedups.* ]]; then builtin unset VSCODE_SHELL_INTEGRATION builtin return fi </del> if [ -z "$VSCODE_SHELL_INTEGRATION" ]; then builtin return fi

Discussion:
This is a follow up from which worked around the majority case of an issue. See the workaround: The proper fix will involve sending both the exit code and the history ID over to VS Code which will then do what's happening now but also have the correct exit code to set, instead of assuming it's the last command's exit code. We should write a little script as part of this that alternates exit codes by setting/unsetting an environment variable so it's easier to test and verify.
The issue being worked around is actually caused by or being included in .
Good test case from
To verify: some commands , they should all show up in current session ctrl+c in between some commands, including typing out a command and hitting ctrl+c to abandon it , the lines with ctrl+c shouldn't show up several times, failed and success should match whether the exception was thrown.
Change:
}, f1: true, keybinding: { <del> when: undefined, </del> <ins> when: ContextKeyExpr.and(accessibleViewIsShown.negate(), accessibilityHelpIsShown.negate()), </ins> weight: KeybindingWeight.WorkbenchContrib, primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KeyO },

Discussion:
Type: <bBug</bPowerShell in editor area NOT type anything in the terminal input alt+F2 to open accessible view for the terminal ctrl+shift+o to open symbol list DownArrow key and you will hear: "No editor symbols" ESC key Note: pressing ESC key also closes the Accessible Buffer View. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-06T05:35:21.061Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.470 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11.

python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.417 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.101.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
The editor's go to symbol is getting invoked in this case. We should prevent that from happening via a context key.
note that this action is disabled when there are not symbols for the current accessible view. good bug find though . The fix will make it such that no quick pick opens.
Change:
this.setFocus([firstPageIndex], browserEvent); } } else { <ins> this.setFocus([]); </ins> const previousScrollTop = scrollTop; this.view.setScrollTop(scrollTop - this.view.renderHeight);

Discussion:
Version: 1.44.0-insider (user setup) Commit: Date: 2020-03-31T08:23:56.446Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. Minor issue obviously but it's would probably feel smoother if the top didn't flash whenever you press page down. This indicates to me that rendering is happening between the selection and scroll values are updated as a result of page down firing. Shouldn't they be done at the same time? Holding page down showing the problem: ! Pressing page down showing the problem: !
It's pretty much the same what happens with the Windows file explorer. We can do better, tho! I suggest to clear focus, scroll, set focus iff there is space left to scroll.
Change:
id: 'workbench.action.compareEditor.nextChange', weight: KeybindingWeight.WorkbenchContrib, when: TextCompareEditorVisibleContext, <del> primary: null, </del> <ins> primary: KeyMod.Alt | KeyCode.F5, </ins> handler: accessor => navigateInDiffEditor(accessor, true) });

Discussion:
I don't use the diff editor much, one of the first things I tried to do when I was learning it better now was to find the command to jump to the next change. I found go to next difference (F7) which is almost what I want: ! F7 goes to the diff chunk: ! I was expecting it to move the cursor/viewport to center around the change in the right editor.
and navigate through the diff hunks, but they do so in an accessible way. i.e. they are the mechanism through which the diff editor is accessible. There are these buttons at the top which allow to jump to the next diff hunk: ! I think we could find out their ID and bind keybindings to them.
Thanks, this is it: They don't have default keybindings.
These keybindings seem to work well for me: Maybe they should default to alt+f5/shift+alt+f5, so it's the same default as when in the diff editor?
^ I would support that. I made a separate issue here, don't know if that was overkill
Btw I'd think that it would be more logical to use modifiers+F7 (next diff change), instead of modifiers+F3 (next search match)
Or.. it's actually more similar to There are so many commands related to the concept of "next change", I'm actually a little confused myself
Alright I have it figured out! These two now have the default shortcuts: The does the exact same thing as , just for diff editor instead of normal editor. So there's absolutely no reason not to overload the and with the same functionality. So all we have to do is add:
Actually the might strictly be unnecessary, but it's good to have there for clarity.
I'd contribute a PR with the above myself, but I have no idea where the default keybindings are in the source
Change:
} } <del> async function runCell(accessor: ServicesAccessor, context: INotebookActionContext): Promise<void> { const editorGroupService = accessor.get(IEditorGroupsService); const group = editorGroupService.activeGroup; </del> <ins> async function runCell(editorGroupsService: IEditorGroupsService, context: INotebookActionContext): Promise<void> { const group = editorGroupsService.activeGroup; </ins> if (group) { if (group.activeEditor) {

Discussion:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.

run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem