jiebi/CodeConvo huggingface dataset:
Change:
filterOk(matchesFuzzyOcticonAware, 'indent', parseOcticons('This $octicon Indent Using Spaces'), [ { start: 14, end: 20 }, ]); <ins> // Testing #59343 filterOk(matchesFuzzyOcticonAware, 'unt', parseOcticons('$(primitive-dot) $(file-text) Untitled-1'), [ { start: 30, end: 33 }, ]); </ins> }); });

Discussion:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.2(lang:ja), 1.28(insider, lang:en) OS Version: Windows, Mac Steps to Reproduce: this code in extension ! ! Result: The display of octicon will be broken and the wrong place will be selected and displayed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No( this problem is at api for extensions )
I have encountered this problem with .
I am quite sure I fixed this a while back for normal quick open, maybe it is a regression from the new quick input widget?
My change was:
Change:
text-overflow: ellipsis; height: 18px; overflow: hidden; <ins> white-space: pre; </ins> border-bottom: 1px solid rgba(128, 128, 128, 0.35); }

Discussion:
Issue Type: <bBug</bHi. I am assigning trade.occId = occId; i.e. to a property (in this case it contains 4 spaces. In the JavaScript hover view however, the property on 'trade' reads (only one space) [btw, I copied both these values right out of the IDE view]. I've just been chasing ghosts for some time because of this discrepancy and not expecting the IDE altering assigned values when viewing objects. Update ---Alright, sorry. I am not sure how to submit the first value on GitHub with the 4 spaces between GS and 1 preserved, even when using 'code' quotes (same as the VSC issue...). So the first value is "GD....190517P00155000" when replacing spaces with dots... Thanks for VS Code otherwise :-) VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ vscode-scss0.6.2 debugger-for-chrome4.11.3 vscode-scss-formatter1.4.1 vscodeintellicode1.1.5 </details<!-- generated by issue reporter --
Can you please provide a screenshot of what you see? Also try disabling all extensions. I am not sure if such an hover is provided by out of the box typescript/javascript extension.
Hi. Please see below. I disabled all extensions besides Debugger for Chrome, which I need to set a break-point to be able to inspect values. The issue is in most obvious in the field 'occId', which in fact has 4 spaces after 'GD' and not just one as displayed. Thanks for following up. [image: ] !
Ah I see.. its an hover while debugging.
You did not attach an image. So please attach an image and some reproducable steps so we can investigate more. Thanks
It did, (please check below the quote). Anyway, your question made me come up with a better/simpler example that should make things clear. Here you go: ! Btw, Gruetzi to all you guys in Zuerich.

I'm originally from Basel :)
Thanks for the image. Cheers back to Basel :)
VSCode insiders will have the fix for this on monday. Try it out and let us know if it is ok for you. Though I verified and the fix from looks good
Thanks for the work and update. Unfortunately I can't switch from VSCode stable, so I'll take your word for it until this hits release :-)
Change:
} return true; } <ins> /** * Maintain a stable viewport by trying to keep the first line in the viewport constant. */ class StableViewport { constructor( public readonly viewportStartModelPosition: Position | null, public readonly startLineDelta: number ) { } public recoverViewportStart(coordinatesConverter: ICoordinatesConverter, viewLayout: ViewLayout): void { if (!this.viewportStartModelPosition) { return; } const viewPosition = coordinatesConverter.convertModelPositionToViewPosition(this.viewportStartModelPosition); const viewPositionTop = viewLayout.getVerticalOffsetForLineNumber(viewPosition.lineNumber); viewLayout.setScrollPosition({ scrollTop: viewPositionTop + this.startLineDelta }, ScrollType.Immediate); } } </ins>

Discussion:
use autofolding of imports . use a type that is not imported in a TS file use quick fix to add the import the editor scrolls to an incorrect position. I think this is a recent regression, because I've been using both import folding and quick fix for imports since quite a while... maybe starting with the last stable. https://user- Version: 1.72.0-insider Commit: Date: 2022-09-21T05:40:07.654Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: Yes
Un-assigning myself as I don't think this cause by something the JS/TS extension itself is doing
who owns the quick fix UI now?
I own the UI. However it looks like scrolling here happen when the edit from the quick fix is applied. That's why I unassigned myself
It also unfolds if you do "Organize Imports", so seems like any action related with imports unfolds even though setting is
The root cause appears to be the folding ranges change and end up calling . That one does not attempt to maintain the viewport stable in any way.
this issue still exists:
Change:
tree.reveal(focus[0]); } } <ins> // Ensure DOM Focus ensureDOMFocus(focused); </ins> }

Discussion:
I like the up / down keyboard navigation over notebook cells, but when you try to use to navigate the order is very unexpected. a notebook. I am using my- my work cell -Focus is on GitHub issues label -focus seems lost -focus is on the start of the document, even though I did not traverse until the end of the docuemnt Ideally tab should go in visual order. If that is not possible should move focus out of the notebook. Similarly tree tab is not used to move focus so users use up / down, but pressing tab focuses out of the tree and does not lead to unexpected jumping of focus.
Fixed in this change Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell (step 3 in OP) Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in )
Much better now. Thanks for fixing this.
Change:
* provided as nothing will be inherited from the process or any configuration. */ strictEnv?: boolean; <ins> /** * Moving forward, conpty will be the default. However, there are cases where conpty is not ready * to be the default. This property will force winpty to be used, even when conpty would normally be used. */ forceWinpty?: boolean; </ins> } export interface ITerminalService {

Discussion:
Steps to reproduce: clone open a terminal Debug viewlet Launch client Observe that building never finishes Now switch the terminal to the npm: watch task Observe: building finished. Looks like the terminal is not delivering any output as long as the view is not visible.
are there any differences on when onLineData occurs in the terminal with conpty?
discovered a new issue
Change:
} private logEvent(eventName: string, data?: Record<string, any>): void { <ins> // No sender means likely disposed of, we should no-op if (!this._sender) { return; } </ins> // If it's a built-in extension (vscode publisher) we don't prefix the publisher and only the ext name if (this._extension.publisher === 'vscode') { eventName = this._extension.name + '/' + eventName;

Discussion:
Testing Given this code: I was expecting my event handlers not to fire since the logger is disposed, but they still fire.
This still repros for me <img width="1210" alt="image" src="https://user-"
Change:
) { return; } <del> await delayer.trigger(async () => { if (e.element) { this.showHover(e.element); </del> <ins> try { await delayer.trigger(async () => { if (e.element) { this.showHover(e.element); } }); } catch (e) { // Ignore cancellation errors due to mouse out if (!isCancellationError(e)) { throw e; </ins> } <del> }); </del> <ins> } </ins> })); this.disposables.push(this.list.onMouseOut(e => { // onMouseOut triggers every time a new element has been moused over

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 Steps to Reproduce: the browser devtools the command palette the items is a lot of errors in the console: !
I'm not seeing this anymore... Can you confirm
Actually I can repro this only in and not odd
Change:
import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; <ins> import { clamp } from 'vs/base/common/numbers'; </ins> export const ctxCommentEditorFocused = new RawContextKey<boolean>('commentEditorFocused', false); <del> export const STARTING_EDITOR_HEIGHT = 5 * 18; </del> <ins> export const MIN_EDITOR_HEIGHT = 5 * 18; </ins> export const MAX_EDITOR_HEIGHT = 25 * 18; export interface LayoutableEditor {

Discussion:
window a comment :bug: as you can see from the scrollbar, the comment text doesn't fill the full editor !
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
closedWith
Change:
return thread.getCallStack().find(sf => sf.getId() === context.frameId); } } <ins> } else { return debugService.getViewModel().focusedStackFrame; </ins> } return undefined;

Discussion:
Issue Type: <bBug</bI wanted to be able to copy the call stack through a keyboard shortcut so I created a binding for but found that it doesn't do anything. I tried different combinations of clauses and ensured that my keystroke was not being captured by something else but still no luck. Invoking the command directly in my extension like so also did not work and the thenable resolved to . The comment and post imply this should work outside of the callstack context so I've filed this as a bug as opposed to a feature request for a keyboard shortcut to copy the call stack. VS Code version: Code 1.63.2 (Universal) (, 2021-12-15T09:37:28.172Z) OS version: Darwin x64 21.2.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ vscode-bazel0.5.0 arm1.5.2 vscode-diff1.4.2 fig0.10.1 misc-additions1.0.2 lldb-vscode0.1.0 jupyter2021.11. remote-ssh0.68.0 remote-ssh-edit0.68.0 vscode-remote-extensionpack0.21.0 cpptools1.7.1 errorlens3.4.1 vim1.21.10 clang-format1.9.0 material-theme3.13.6 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
The comment in code applies to the commands in general but that particular command can't be called globally currently. It copies a callstack from one thread and there can be multiple callstacks available so one has to selected to copy. Do you want the keybinding to work on the focused thread, or does that not help?
Yes, defaulting to the focused thread was my expectation.
Change:
} Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench).registerWorkbenchContribution(VariableCompletions, LifecyclePhase.Eventually); <del> function getAgentCompletionDetails(agent: IChatAgentData, otherAgents: IChatAgentData[], chatAgentNameService: IChatAgentNameService): { label: string; isDupe: boolean } { const isAllowed = chatAgentNameService.getAgentNameRestriction(agent); const agentLabel = `${chatAgentLeader}${isAllowed ? agent.name : getFullyQualifiedId(agent)}`; const isDupe = isAllowed && !!otherAgents.find(other => other.name === agent.name && other.id !== agent.id); return { label: agentLabel, isDupe }; } </del>

Discussion:
I removed this to move over to using the agent, which required setting . Chatted with and I should add another agent to support the agent in both places, only making it the default for the terminal location. fyi
Verified that is available in panel chat.
Change:
GetBranches: { kind: OperationKind.GetBranches, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as GetBranchesOperation, GetCommitTemplate: { kind: OperationKind.GetCommitTemplate, blocking: false, readOnly: true, remote: false, retry: false, showProgress: true } as GetCommitTemplateOperation, GetObjectDetails: { kind: OperationKind.GetObjectDetails, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as GetObjectDetailsOperation, <ins> GetObjectFiles: { kind: OperationKind.GetObjectFiles, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as GetObjectFilesOperation, </ins> GetRefs: { kind: OperationKind.GetRefs, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as GetRefsOperation, GetRemoteRefs: { kind: OperationKind.GetRemoteRefs, blocking: false, readOnly: true, remote: true, retry: false, showProgress: false } as GetRemoteRefsOperation, HashObject: { kind: OperationKind.HashObject, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as HashObjectOperation,

Discussion:
Verification steps: Open a folder/workspace that contains a git repository Modify an existing file, and save it Add a new file, add some contents to it, and save it Invoke the "Git: Stash (Include Untracked)" command, and create a new stash Invoke the "Git: View Stash", and pick the stash that you have created Confirm that all files from the stash have the correct content
Change:
// Add opened files (such as untitled files) const openTextDocumentResults = await Promise.all(vscode.workspace.textDocuments <del> .filter(doc => !foundFiles.has(doc.uri.toString()) && isMarkdownFile(doc))); </del> <ins> .filter(doc => !foundFiles.has(doc.uri.toString()) && this.isRelevantMarkdownDocument(doc))); </ins> return coalesce([...onDiskResults, ...openTextDocumentResults]); }

Discussion:
Testing in VS Code the following content Rename , shift + enter to show preview. Accept the preview Rename the same symbol again, shift + enter to show preview. Preview constantly spins. Clicking on the changes opens an empty side by side editor !
Change:
pickWorkspaceAndOpen(options: IPickAndOpenOptions): Promise<void>; /** <del> * Shows a save file file dialog and save the file at the chosen file URI. </del> <ins> * Shows a save file dialog and save the file at the chosen file URI. </ins> */ pickFileToSave(options: ISaveDialogOptions): Promise<URI | undefined>;

Discussion:
VSCode Version: 1.41 OS Version: Not applicable Steps to Reproduce: to row 233 that the word 'file' is unexpectedly repeated. Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.578 --<!-- potentialduplicatescomment --
Change:
data.root = container; data.optionText = dom.append(container, $('.option-text')); data.optionDescriptionText = dom.append(container, $('.option-text-description')); <ins> dom.addClass(data.optionDescriptionText, 'visually-hidden'); </ins> return data; }

Discussion:
Voiceover does not read new option details because of describedby issue. May require the new ARIA combo box model.
Any problem with me creating new tags for NVDA and voiceover like there is already a tag for jaws? Accessibility-NVDA Accessibility-Voiceover I will also volunteer to do triage on accessibility issues if I can identify them.
Change:
} } <ins> // Draggable region that we can manipulate for #52522 this.dragRegion = prepend(this.rootContainer, $('div.titlebar-drag-region')); </ins> // Menubar: install a custom menu bar depending on configuration // and when not in activity bar if (this.titleBarStyle !== 'native'

Discussion:
Hello, Normally when you double click the top left of a Window, the application closes. When you double click vscode, the application maximizes. Can VSCode have this capability as well to close? !
We have logic to detect and handle double click in the custom title to restore / maximize the window but we missed to handle this case where on Windows it indeed seems to close the app. For this to work we probably have to detect a click on the icon and then call a different method to close instead of the current behaviour. Code pointers: //cc
Oh interesting, that code only runs on macOS, then I wonder what triggers this
Yes, very interesting. For other Windows apps, the menu appears when you single left click the top window as well. In VSCode when you Single Click the top left, nothing happens (In windows 10, all versions, latest VSCode)
Yeah that is expected, we draw the title custom entirely. We need to implement those native integrations on top. Maybe you report as separate issue.
I think you want this setting
doesn't seem to work anymore; I had it set for ages (along with to "custom"), but recently it doesn't seem to do anything...
Change:
} } <del> function extendObject<T>(objectCopy: T, object: T): T { for (let key in object) { if (object.hasOwnProperty(key)) { objectCopy[key] = object[key]; } } return objectCopy; } </del> /** * Quote args if necessary and combine into a space separated string. */

Discussion:
The and should be removed
Sorry for question, but why you don't use native ?
stuff in common is still used in very old browser
Fixed in
Change:
}); } <ins> public expandAll(): void { transaction(tx => { for (const d of this.items.get()) { d.collapsed.set(false, tx); } }); } </ins> constructor( private readonly _model: IMultiDiffEditorModel, private readonly _instantiationService: IInstantiationService,

Discussion:
We have a "collapse all" button: And other places in vscode this typically toggles to an "expand all". Would make sense to have it here as well
PR is now available for review
Change:
return false; } const matchOnPath = typeof globPattern === 'string' && globPattern.indexOf(posix.sep) >= 0; <del> const target = matchOnPath ? resource.path : basename(resource); </del> <ins> const target = matchOnPath ? `${resource.scheme}:${resource.path}` : basename(resource); </ins> return glob.match(globPattern, target.toLowerCase()); } //#endregion

Discussion:
install "markdown notebook" extension make sure the default editor for MD files is the text editor open a MD file (opens as text) re-open with markdown notebook select an entry from outline or breadcrumbs :bug: a text editor opens
It looks like our editor contribution point isn't called
The same happens with the "references view" and the "problems panel" (use GH issue notebooks and make text editor default for its type)
Debugged this a little: everything works nice up to the point where the user setting is read and . That "steels" the resource from notebooks and re-routes it into the "normal" editor land... This code is novel to me so I might not have the best suggestions how to fix it. One idea is that my contribution marks a scheme as "winner scheme" and resources with that scheme will always use that contribution. Tho, I don't know what side effects that will have
Change:
throw new ErrorNoTelemetry('Terminal disposed of during xterm.js creation'); } <del> const disableShellIntegrationReporting = (this.shellLaunchConfig.hideFromUser || this.shellLaunchConfig.executable === undefined || this.shellType === undefined) || !shellIntegrationSupportedShellTypes.includes(this.shellType); </del> <ins> const disableShellIntegrationReporting = (this.shellLaunchConfig.executable === undefined || this.shellType === undefined) || !shellIntegrationSupportedShellTypes.includes(this.shellType); </ins> const xterm = this._scopedInstantiationService.createInstance( XtermTerminal, Terminal,

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No For proposed API: <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.85.0-insider (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: a hidden terminal using to text to terminal, for eg. "echo hello" no events are fired Same is not the case if is set to . cc/
Any idea where the issue could be here? We require this to start leveraging
This is by design according to this: We tweaked the condition in to work properly on remotes, and tried to force shell integration for debug terminals here: I don't see an issue with changing hidden terminals from having shell integration, we just need to watch the incoming issues for problems.
If we have shell integration in hidden terminals is conflicts with but I think the thinking was changed in If you don't want env collections you must pass , which means you need to provide the entire environment.
I still repro this with the following minimum repro: Changing to fires the event. Or maybe there are other steps that should be taken?
Reopening as your steps seem correct
possible that the hidden terminal isn't yet a part of yet, so is not within here? Yes, seems like it
We should include in I think
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
these steps are good
Change:
import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; import { INotificationService } from 'vs/platform/notification/common/notification'; import { TestNotificationService } from 'vs/platform/notification/test/common/testNotificationService'; <ins> import { IHostService } from 'vs/workbench/services/host/browser/host'; </ins> function createStorageService(instantiationService: TestInstantiationService): IStorageService { let service = instantiationService.get(IStorageService);

Discussion:
Steps to Reproduce: = workbench does not open From: Workaround:
I think depending on is logically correct. But, in web is depending on other workbench services like --and causing cycle. Not having consistent base services in desktop and web is causing confusion and debt and it might add up as we evolve. I think fixing in is just a patch. To unblock for now, I removed the dependency on and used . Assigning back to you for fixing this in .