jiebi/CodeConvo huggingface dataset:
Change:
private _createHint(): void { const instance = this._instance instanceof TerminalInstance ? this._instance : undefined; <del> if (!instance || !this._xterm || this._hintWidget || instance?.capabilities.get(TerminalCapability.CommandDetection)?.hasInput) { </del> <ins> const commandDetectionCapability = instance?.capabilities.get(TerminalCapability.CommandDetection); if (!instance || !this._xterm || this._hintWidget || !commandDetectionCapability || !commandDetectionCapability?.hasInput) { </ins> return; }

Discussion:
I see this, but I think I've seen it correct in the past? But right now it's reproable in new terminals <img width="708" alt="image" src=""
Maybe related to my zsh prompt config, I can share the zsh config if it helps
I see the same, since I use the same setup <img width="1434" alt="Screenshot 2024-05-07 at 21 49 41" src=""
Yes can you pls share your zsh config?
Steps are: zsh oh-my-zsh a terminal in a workspace that has a git repo Let me know if that doesn't work for you.
Disabled by default in for now
also mentioned he thinks it should use the terminal's font
using your steps and I am still not seeing it . Can you share your configuration? <img width="986" alt="Screenshot 2024-05-13 at 9 50 51 AM" src=""
Also, any terminal settings would help - do you set the font / letter spacing for example?
I see that for the first prompt, the prompt start marker occurs before the (see the status bar). <img width="900" alt="Screenshot 2024-05-13 at 10 55 04 AM" src=""
Handle prompt start happens before the is by the program.
We should be disposing of the decoration when there's input, even for this case, when that's happening via a shell script.
In the case of the specific theme can be used without this issue if one removes from the prompt in Also note that the prompt is correct when a user hits enter. It's only the first prompt that is wrongly interpreted.
Change:
"when": "config.git.enabled && !git.missing && config.multiDiffEditor.experimental.enabled" }, { <ins> "command": "git.viewChanges", "when": "config.git.enabled && !git.missing && config.multiDiffEditor.experimental.enabled" }, { "command": "git.viewStagedChanges", "when": "config.git.enabled && !git.missing && config.multiDiffEditor.experimental.enabled" }, { "command": "git.viewUntrackedChanges", "when": "config.git.enabled && !git.missing && config.multiDiffEditor.experimental.enabled && config.git.untrackedChanges == separate" }, { </ins> "command": "git.viewCommit", "when": "false" },

Discussion:
Launch VS Code Insiders Set to or Confirm that the "Git: Show Untracked Changes" command is not in the command palette Set to Confirm that the "Git: Show Untracked Changes" command is not in the command palette
Change:
const result = await fetching(this.getServerUri('/meta').toString(), { headers: { Authorization: `token ${token}`, <del> 'User-Agent': 'Visual-Studio-Code' </del> <ins> 'User-Agent': `${vscode.env.appName} (${vscode.env.appHost})` </ins> } });

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: NA OS Version: NA Steps to Reproduce: The github education team sees about calls from Visual-studio-code in an hour for api/user. This is quite unusual and since we are rate limiting anyway, it is not an immediate issue. From initial discussions with I understand that the call is made only for telemetry and has no impact on the user. So, raising this bug, if we can find a better way to do telemetry without having to rate limit. This here shows some more details.
, can you please help me understand what is the likelihood of this work getting prioritised and by when can we expect to resolve this issue.
I wasn't able to get to it this week during our allocated debt time so I will try again to make time early April. I'll let you know if anything changes.
Change:
const newCommentInfos = this._commentingRangeDecorator.getMatchedCommentAction(range); if (!newCommentInfos.length || !this.editor?.hasModel()) { this._addInProgress = false; <ins> if (!newCommentInfos.length) { throw new Error('There are no commenting ranges at the current position.'); } </ins> return Promise.resolve(); }

Discussion:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW
Change:
} // match by label if (!!task) { <del> const taskToRun = grouped.all().find(g => g._label === task); </del> <ins> const taskToRun = tasks.find(g => g._label === task); </ins> if (taskToRun) { this.run(taskToRun).then(undefined, () => { }); return; } } <ins> if (task && !tasks.some(g => g._label.includes(task))) { task = undefined; } </ins> // if task is defined, will be used as a filter <del> this._doRunTaskCommand(grouped.all(), type, task); </del> <ins> this._doRunTaskCommand(tasks, type, task); </ins> }); } this._doRunTaskCommand();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: Windows 10 Steps to Reproduce: Configure keybindings with non-existant tasks, for example: configure some tasks in the workspace. press F7 and the tasks are filtered with the text , not showing the actual available tasks. This issue exists since has been . I have shortkeys for some tasks I execute quite often, but some workspaces don't have those tasks, but have other tasks. Now, when I press F7, I need to empty all the text before I can select the desired task. Either this behaviour needs to be reverted to the pre-1.70 behaviour (possibly with an option to the user), or shortkeys per workspace needs to be implemented, but this is very annoying.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I am using version 1.71.0, but the issue was introduced in version 1.70.0
the behavior of filtering with whatever task you've provided is by design, but yes you're right that when there are no results found matching that term, the input should be cleared and show all tasks
Change:
openExtensionViewlet(this.paneCompositeService, `${this.marketplaceQuery} ${quickpick.value}`); } } <del> }); quickpick.onDidChangeActive(themes => { </del> <ins> })); disposables.add(quickpick.onDidChangeActive(themes => { </ins> if (result === undefined) { selectTheme(themes[0]?.theme, false); } <del> }); </del> <ins> })); </ins> <del> quickpick.onDidHide(() => { </del> <ins> disposables.add(quickpick.onDidHide(() => { </ins> if (result === undefined) { selectTheme(currentTheme, true); result = 'cancelled'; } <del> quickpick.dispose(); </del> s(result); <del> }); </del> <ins> })); </ins> <del> quickpick.onDidTriggerButton(e => { </del> <ins> disposables.add(quickpick.onDidTriggerButton(e => { </ins> if (e === this.quickInputService.backButton) { result = 'back'; quickpick.hide(); } <del> }); </del> <ins> })); </ins> <del> this.onDidChange(() => { </del> <ins> disposables.add(this.onDidChange(() => { </ins> let items = this.themes; if (this._searchOngoing) { items = items.concat({ label: '$(sync~spin) Searching for themes...', id: undefined, alwaysShow: true });

Discussion:
Quick pickers are itself disposables, as well as the events they provide. Noticed a few leaks around picker instances and/or events: //cc
There's already a that is called when the picker hides. Isn't that good enough?
see the various events (those beginning with ) and how they are not getting disposed.
But they are going to an emitter that is owned by the quickpick. Disposing the quickpick is also disposed all its emitters. There's no real leak here.
my understanding is that an that gets disposed (when you dispose the quick picker) does not dispose the -functions it had returned, i.e. this code is not running: But maybe or can also chime in.
Yes - an emitter doesn't dispose its listeners. you basically rely on GC'ing here and I am uncertain if that actually works (e.g some disposables are tracked centrally for later blaming). I understand your motives but we generally dispose all the things
Change:
} renderElement(element: MarkerTableItem, index: number, templateData: IMarkerCodeColumnTemplateData, height: number | undefined): void { <del> if (element.marker.source && element.marker.code) { templateData.codeColumn.classList.toggle('code-link', typeof element.marker.code !== 'string'); DOM.show(templateData.codeLabel.element); </del> <ins> templateData.codeColumn.classList.remove('code-label'); templateData.codeColumn.classList.remove('code-link'); if (element.marker.source && element.marker.code) { </ins> if (typeof element.marker.code === 'string') { <ins> templateData.codeColumn.classList.add('code-label'); </ins> templateData.codeColumn.title = `${element.marker.source} (${element.marker.code})`; templateData.sourceLabel.set(element.marker.source, element.sourceMatches); templateData.codeLabel.set(element.marker.code, element.codeMatches); } else { <ins> templateData.codeColumn.classList.add('code-link'); </ins> templateData.codeColumn.title = `${element.marker.source} (${element.marker.code.value})`; templateData.sourceLabel.set(element.marker.source, element.sourceMatches);

Discussion:
Issue Type: <bBug</bTesting I have Code Spell Checker () extension provides diagnostics without error code, and rust-analyzer extension provides diagnostics with error code. When all diagnositcs don't have code, it displays correctly. When some diagnostics have code and some don't, scroll over the Problems value, some code changes randomly. https://user- VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-29T05:20:28.364Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ Bookmarks13.3.0 remotehub0.35. remote-containers0.241.1 remote-ssh0.83. remote-ssh-edit0.80.0 remote-wsl0.66.3 remote-repositories0.12.0 material-icon-theme4.18.1 material-theme3.15.2 toml0.6.0 rust-analyzer0.4.1110 code-spell-checker2.2.5 </details<!-- generated by issue reporter --
Change:
private _terminalInstances = new Map<vscode.Terminal, { lastUsedAt: number, config: string }>(); <del> public async checkout(config: string) { </del> <ins> public async checkout(config: string, name: string) { </ins> const entries = [...this._terminalInstances.entries()]; const promises = entries.map(([terminal, termInfo]) => createCancelablePromise(async ct => { <ins> // Only allow terminals that match the title.  See #123189 if (terminal.name !== name) { return null; } </ins> if (termInfo.lastUsedAt !== -1 && await hasChildProcesses(await terminal.processId)) { return null; }

Discussion:
See I think the best way for this would be for VS Code core to rename the terminal if gets a new request with a different name -- opened an issue for that Or, at least, try to use a terminal of the same name if one exists (which would be easier and probably more feasible since the is not writable.) Code pointer:
Also fyi
I'm going to take a swing at this. Here is my current understanding of the problem and I would appreciate any feedback or comments. The issue - Launching debug sessions in integrated terminal will open duplicate terminals. Solution - Code can attempt to find a terminal instance that has the same title as the launch request and is not currently in use. If located, it can reuse that instance, otherwise it can use the existing logic to create a new instance. I believe this should also address the concerns in as Code will stop spawning new terminal instances for repeat debug sessions. Please let me know if I have any misunderstandings on the issue.
Sounds good to me
I'm looking over the current code for checking out an integrated terminal and came across the minUseDelay for determining which of the terminals is available for use. It was a fix for . As I understand it, when compound node tasks were run, they would all try to grab the same terminal instance so only the first one to run would actually get the terminal, the others would fail to run. By introducing the minUseDelay, it insured that all of the launch tasks would get a new terminal instance. Once microsoft/vscode-js-debug is merged, each Node launch task will most likely have a unique name and therefore a dedicated terminal instance (ideally) which would mean we could always return the first terminal without a child process that has the same title and get rid of minUseDelay. Right?
Obviously if someone had two launch configurations with the same name (why?) this would fall apart.
We could even enforce name-matching and reopen the terminal if nothing's running in it and the name mismatches
Change:
this.settingsTreeModel.update(resolvedSettingsRoot); this.tocTreeModel.settingsTreeRoot = this.settingsTreeModel.root as SettingsTreeGroupElement; <del> const cachedState = this.restoreCachedState(); if (cachedState && cachedState.searchQuery || !!this.searchWidget.getValue()) { </del> <ins> // Don't restore the cached state if we already have a query value from calling _setOptions(). const cachedState = !this.viewState.query ? this.restoreCachedState() : undefined; if (cachedState?.searchQuery || this.searchWidget.getValue()) { </ins> await this.onSearchInputChanged(); } else { this.refreshTOCTree();

Discussion:
Issue Type: <bBug</bthe settings UI. for a setting (e.g. "inlay"). the settings tab to a new editor group. Note that the search you entered previously has been cleared. https://user- VS Code version: Code 1.60.0 (, 2021-09-01T10:54:53.442Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 vscode-nginx-conf0.1.3 reorder-lines-by-length1.0.2 docs-view0.0.9 pgformatter1.17.0 vscode-eslint2.1.25 gitlens11.6.0 vscode-diff1.4.2 shell-format7.1.0 go0.27.2 postgresql0.0.2 rainbow-csv1.9.1 render-crlf1.5.21 template-string-converter0.5.3 python2021.9. vscode-pylance2021.9.2 jupyter2021.8. jupyter-keymap1.0.0 debugger-for-chrome4.13.0 nbsp-vscode0.0.1 vscode-commons0.0.6 vscode-yaml0.22.0 final-newline0.3.2 vscode-hexdump1.8.1 change-case1.0.0 markdown-all-in-one3.4.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
A function called in is being called after the drop, which is correct. But, the function in the same file name isn't being called when the user does step 3 above. Another repro is to use the "move editor to X group" commands. Therefore, the fix doesn't have to do directly with dnd.
Change:
"config.checkoutType.local": "Local branches", "config.checkoutType.tags": "Tags", "config.checkoutType.remote": "Remote branches", <del> "config.defaultBranchName": "The name of the default branch (ex: main, trunk, development) when initializing a new git repository. When set to empty, the default branch name configured in git will be used.", </del> <ins> "config.defaultBranchName": "The name of the default branch (ex: main, trunk, development) when initializing a new git repository. When set to empty, the default branch name configured in git will be used. **Note:** Requires git version `2.28.0` or later.", </ins> "config.branchPrefix": "Prefix used when creating a new branch.", "config.branchProtection": "List of protected branches. By default, a prompt is shown before changes are committed to a protected branch. The prompt can be controlled using the `#git.branchProtectionPrompt#`  setting.", "config.branchProtectionPrompt": "Controls whether a prompt is being shown before changes are committed to a protected branch.",

Discussion:
Type: <bBug</bGo to 'Source control' and click 'Initialize Repository'. An error message shows "Git:unknown switch 'b'". VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ LiveServer5.7.9 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Having the same issue after a recent update this morning. Version: 1.79.2 Date: 2023-06-14T08:58:52.392Z (1 day ago) Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 22.5.0
Could you please share the contents of the ? Thanks!
I encountered the same issue.... Output from GIT: 2023-06-16 10:31:06.946 [info] git init -b main [4ms] 2023-06-16 10:31:06.946 [info] error: unknown switch `b' usage: git init [-q | --quiet] [--bare] [--template=<template-directory] [--shared[=<permissions]] [<directory] --template <template-directorydirectory from which templates will be used --bare create a bare repository --shared[=<permissions] specify that the git repository is to be shared amongst several users -q, --quiet be quiet --separate-git-dir <gitdirseparate git dir from working tree 2023-06-16 10:33:13.422 [info] git rev-parse --show-toplevel [1ms] 2023-06-16 10:33:13.422 [info] fatal: not a git repository (or any of the parent directories): .git
Yes, that's the exact same Output received.
Could you please share the version of git that you are using? Thank you!
!
Change:
run: (c, accessor) => accessor.get(ICommandService).executeCommand(CLOSE_EDITOR_COMMAND_ID) }); <del> registerContextualInstanceAction({ </del> <ins> registerTerminalAction({ </ins> id: TerminalCommandId.KillActiveTab, title: terminalStrings.kill, f1: false,

Discussion:
Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:
/duplicate
Tracking each action separately
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.
you might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.

Repro: Open multiple terminals Select multiple terminal tabs Right click and change icon Change icon only a single terminal is changed Real context stored with the action was done recently as part of Related:
Change:
}); } exports.config = { <del> version: product.electronRepository ? '19.1.10' : util.getElectronVersion(), </del> <ins> version: product.electronRepository ? '19.1.11' : util.getElectronVersion(), </ins> productAppName: product.nameLong, companyName: 'Microsoft Corporation', copyright: 'Copyright (C) 2022 Microsoft. All rights reserved',

Discussion:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith
Change:
if (webExtension) { result.set(galleryExtension.identifier.id.toLowerCase(), { ...webExtension, <ins> identifier: { id: webExtension.identifier.id, uuid: galleryExtension.identifier.uuid }, </ins> readmeUri: galleryExtension.assets.readme ? URI.parse(galleryExtension.assets.readme.uri) : undefined, changelogUri: galleryExtension.assets.changelog ? URI.parse(galleryExtension.assets.changelog.uri) : undefined, <del> metadata: { isPreReleaseVersion: galleryExtension.properties.isPreReleaseVersion, preRelease: galleryExtension.properties.isPreReleaseVersion, isBuiltin: true } </del> <ins> metadata: { isPreReleaseVersion: galleryExtension.properties.isPreReleaseVersion, preRelease: galleryExtension.properties.isPreReleaseVersion, isBuiltin: true, pinned: true } </ins> }); } }

Discussion:
extension details page for GitHub Repositories extension in :bug: the marketplace and repository links aren't shown !
Change:
"npm-debug.log": "_npm_ignored_light" } }, <del> "version": "https://github.com/jesseweed/seti-ui/commit/fd20793e5a75b350eab8d489165fb9b420df3f62" </del> <ins> "version": "https://github.com/jesseweed/seti-ui/commit/8eec7f2e37cd8fd91a98c61d129468bb49735a94" </ins> }  No newline at end of file

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Can the default file icon theme be updated in VS Code (seems just need to follow the to run the script) files should by now have the Maven (mvnw) icon but are still showing regular XML icon.
Verify that the files now have the Maven (mvnw) icon