jiebi/CodeConvo huggingface dataset:
Change:
} else if (ref !== undefined) { this.notificationService.warn(localize('no edit session content for ref', 'Could not resume edit session contents for ID {0}.', ref)); } <del> this.logService.info(ref !== undefined ? `Aborting resuming edit session as no edit session content is available to be applied from ref ${ref}.` : `Aborting resuming edit session as no edit session content is available to be applied`); </del> <ins> this.logService.info(`Aborting resuming edit session as no edit session content is available to be applied from ref ${ref}.`); </ins> return; } const editSession = data.editSession;

Discussion:
Testing I wonder if we should run the command to save all files (not untitled files) before triggering the "Continue on" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?
I am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !
Should we say here? !
Change:
"windows-mutex": "0.3.0", "windows-process-tree": "0.2.4" } <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
Steps to Reproduce: on Apple SI a folder in devtools:
Related failing unit test:
Chokidar v3.5.0 was just released that takes in fsevents universal build , we can update to it.
yep this required compiling fsevents as universal binary
Change:
return undefined; } <del> private startBreakpoints() { if (!this._breakpointEventsActive) { this._breakpointEventsActive = true; this._debugServiceProxy.$startBreakpointEvents(); } } </del> private fireBreakpointChanges(added: vscode.Breakpoint[], removed: vscode.Breakpoint[], changed: vscode.Breakpoint[]) { if (added.length > 0 || removed.length > 0 || changed.length > 0) { this._onDidChangeBreakpoints.fire(Object.freeze({

Discussion:
Set some breakpoints Access from an extension- it's an empty array Try again - it's full Seems that we don't sync breakpoint into to the EH until the first call to one of the breakpoint properties do you have some context on this? It's a little confusing because I wouldn't expect sending breakpoint infos to be expensive, and I would expect to be able to access the breakpoints array immediately.
I do not have more context. I believe is the author of this code. I like your suggestion that we change this and actively sync the breakpoints into the EH (since it should not be expensive).
The observed behavior is by design: we want to avoid that all breakpoints get transferred to all active extensions all the time. But the API doc doesn't explain this...
Thanks is the worry that it's too much data/too expensive? What's the solution for extensions that need to access the list of breakpoints?
yes, potentially too much data and traffic for all extensions. What's the solution for extensions that need to access the list of breakpoints? adding a to the function of an extension will register the extension to receive live updates for . With this will always reflect the current set of breakpoints.
Thanks, I don't really understand that though, it doesn't seem like that much traffic/data, compared to something like the full text of open documents. If it's going to work this way, I should document it in But I might try doing some testing to remove this restriction because I think it's unexpected.
Verification steps: Create an extension that can log the value of Set a breakpoint in any file Then trigger your extension to check the length of the breakpoints array It should log the correct value on the first try- previously it would have been 0 on the first access, then the correct value afterwards
Change:
//#endregion <del> //#region Joao: SCM Input Box /** * Represents the input box in the Source Control viewlet. */ export interface SourceControlInputBox { /** * Controls whether the input box is visible (default is `true`). */ visible: boolean; } //#endregion </del> //#region Terminal data write event https://github.com/microsoft/vscode/issues/78502 export interface TerminalDataWriteEvent {

Discussion:
my SCM extension has no use for the input box, so after creating its instance using scm.createSourceControl I want to set .inputBox.visible=false But visible is only defined in so I get this error reported when I save my change: It seems the property first got introduced by but that caused a problem and had to be reverted on 24-Oct-2018 by , which in turn was reverted later the same day by It passed testing on 30-Oct-2018 under More recently (4-Oct-2019) (still open) has made use of the visible property despite still only being proposed. Perhaps it can do this because it's the built-in Git SCM rather than an extension. Can this API be finalized soon?
Yeah let's try to move it along.
Sorry, but had to push this forward to March. Will get it done as soon as the milestone starts.
No worries and thanks for the update.
Ufff... I forgot I'll be out in March (paternity leave!) so have to push to April, sorry about that!
no worries. I hope your own personal March endgame goes really well
Change:
this.openerService.setDefaultExternalOpener({ openExternal: async (href: string) => { if (matchesScheme(href, Schemas.http) || matchesScheme(href, Schemas.https)) { <del> const opened = windowOpenNoOpenerWithSuccess(href); if (!opened) { const showResult = await this.dialogService.show( Severity.Warning, localize('unableToOpenExternal', "The browser interrupted the opening of a new tab or window. Press 'Open' to open it anyway."), [ localize('open', "Open"), localize('learnMore', "Learn More"), localize('cancel', "Cancel") ], { cancelId: 2, detail: href </del> <ins> if (isSafari) { const opened = windowOpenNoOpenerWithSuccess(href); if (!opened) { const showResult = await this.dialogService.show( Severity.Warning, localize('unableToOpenExternal', "The browser interrupted the opening of a new tab or window. Press 'Open' to open it anyway."), [ localize('open', "Open"), localize('learnMore', "Learn More"), localize('cancel', "Cancel") ], { cancelId: 2, detail: href } ); if (showResult.choice === 0) { windowOpenNoOpener(href); </ins> } <del> ); if (showResult.choice === 0) { windowOpenNoOpener(href); } if (showResult.choice === 1) { await this.openerService.open(URI.parse('https://aka.ms/allow-vscode-popup')); </del> <ins> if (showResult.choice === 1) { await this.openerService.open(URI.parse('https://aka.ms/allow-vscode-popup')); } </ins> } <ins> } else { windowOpenNoOpener(href); </ins> } } else { this.lifecycleService.withExpectedUnload(() => window.location.href = href);

Discussion:
In Chrome sometimes opened window is sharing event loop with the original window, in cases like the same origin or the same parent domain. If one tries to debug one of such windows then others are hanging. I was wondering whether it is better to rewrite like that: Updated: i tried with above and it does not help, Chrome blocks new windows besides first by default.
To avoid sharing the same event loop or whatever, I suggest to adopt . But that one does not return true/false if the window opened. I left in this particular place to maintain the existing behavior. I think this returned boolean was as part of the Safari/iPad work.
Yes the returned boolean was as a way for us to know if the window opened successfully. Since Safari sometimes blocks new windows / tabs.
You could invoke different methods based on the browser: the one without a return value in Chrome / the one with a return value in Safari.
this makes sense we are open to a PR which implements this as suggested.
Change:
if (configuration.enableTsServerTracing && !isWeb()) { tsServerTraceDirectory = this._logDirectoryProvider.getNewLogDirectory(); if (tsServerTraceDirectory) { <del> args.push('--traceDirectory', tsServerTraceDirectory.fsPath); </del> <ins> args.push('--traceDirectory', `"${tsServerTraceDirectory.fsPath}"`); </ins> } }

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0 OS Version: Darwin x64 23.2.0 Steps to Reproduce: custom node: any ts project. . The log file is not generated actually.
After attaching to the tsserver with , I see a strange error:
I set "typescript.tsserver.nodePath" to be a script which echos its CLI args and it also shows that the spaces aren't be escaped properly in This looks like a bug in ( which will likely be broken for any Mac user, including one that commented on the original PR
This should already be fixed:
I'll double-check when I get a free moment, but I swear I had updated to the latest version of VSCode when I was testing last week.
I've verified my installation is up-to-date and I still am getting a TSServer crash. I can't find any relevant logs that would indicate the cause of failure. What I do know is that using my (TS 5.2.2) works fine. <img width="1198" alt="" src=""
I found another bug, the log file path is also not being escaped if one has enabled. All of my logs are being written to rather than
this is still an issue as of VSCode 1.88.0
Also I just noticed the description of contains Can you update your review process to ensure that someone with a MacOS machine tests changes?
The ts server seems to just crash and attempt to start in a loop forever. nothing is in the log folder from the logs. my settings:
Can confirm this still crashes on windows.

Seems to work fine for me on Mac. Taking a look now
Seems risky to fix given that this areas has caused problems before so moving to June
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
fileService.registerProvider(logsPath.scheme, new InMemoryFileSystemProvider()); } <del> bufferLogger.logger = loggerService.createLogger(environmentService.logFile, { id: windowLogId, name: localize('rendererLog', "Window") }); </del> // User data let userDataProvider; if (indexedDB) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the "Developer: Set Log Level..." command and set it to "Trace" there's no "Telemetry" channel there, only Extension Telemetry: !
Do you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.
Where do you register Telemetry logger in codespaces, is it in server or on client side?
It's registered client side.
May I know where it is registered in sources?
Can you please check if this code is being executed in the codespace?
It seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.
Can you please provide me steps to enable this locally from sources?
Sent instructions offline
Still not seeing the telemetry output channel in Codespaces (on desktop if it matters)
Actually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.
Change:
this.contextMenuService.showContextMenu({ getAnchor: () => e.anchor!, menuId: MenuId.ProblemsPanelContext, <ins> contextKeyService: this.widget.contextKeyService, </ins> getActions: () => this.getMenuActions(element), getActionViewItem: (action) => { const keybinding = this.keybindingService.lookupKeybinding(action.id);

Discussion:
Type: <bBug</bWhen I right click on problem there is no option to copy just error message. VS Code version: Code 1.73.1 (, 2022-11-09T04:27:29.066Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (47)</summaryExtensionVersion ------ rainbow-brackets0.0.6 al-code-outline3.0.39 al-toolbox2.0.24 bracket-pair-colorizer-20.2.4 al-cust-to-events1.2.0 al-codeactions1.0.24 githistory0.6.19 gitlens13.0.4 remotehub0.46.0 gc-excelviewer4.2.56 todo-tree0.0.220 vscode-drawio1.6.4 rest-client0.25.1 al-test-runner0.7.13 jbockle-format-files3.4.0 polacode-.6.1 l13-diff1.0.3 banner-comments-plus0.3.1 git-graph1.30.0 azure-dev0.3.0 vscode-azureappservice0.24.5 vscode-azurefunctions1.8.3 vscode-azureresourcegroups0.5.6 vscode-azurestaticwebapps0.11.3 vscode-azurestorage0.15.0 vscode-azurevirtualmachines0.6.2 vscode-cosmosdb0.19.2 vscode-docker1.22.2 al10.1.

azure-account0.11.2 powershell2022.10.0 remote-repositories0.24.0 vscode-node-azure-pack1.1.1 createGUID0.0.2 al-formatter3.0.0 al-var-helper2.4.0 xliff-sync1.3.0 markdown-preview-enhanced0.6.5 swdc-vscode2.6.35 sparebrained-al-pack1.2.1 errorlens3.6.0 vjeko-al-objid2.9.1 vscode-icons12.0.1 codetour0.0.58 crs-al-language-extension1.5.19 al-navigator0.5.0 markdown-all-in-one3.4.3 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --!
Change:
requireSomeCapability(client, ClientCapability.Semantic), ], () => { return vscode.languages.registerRenameProvider(selector.semantic, <del> new TypeScriptRenameProvider(client, fileConfigurationManager)); </del> <ins> new TypeScriptRenameProvider(language, client, fileConfigurationManager)); </ins> }); }

Discussion:
!
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Why has this been marked out of scope? This is a feature that was .
facing the same
Same problem here. This IS crucial for big projects.
To verify: renames should rename matching tags now. Test on both html tag names () and custom components () you change , then renaming custom components should instead renaming all references to that component
Change:
this._scanDevelopedExtensions(language, extensionDevelopmentPath) ]); <del> return dedupExtensions(builtinExtensions, [...installedExtensions, ...workspaceInstalledExtensions], developedExtensions, this._logService); </del> <ins> return dedupExtensions(builtinExtensions, installedExtensions, workspaceInstalledExtensions, developedExtensions, this._logService); </ins> } private async _scanDevelopedExtensions(language: string, extensionDevelopmentPaths?: string[]): Promise<IExtensionDescription[]> {

Discussion:
This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width="476" alt="image" src=""
Can you please share the following file F1 Open Extensions Folder Share file
What do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?
Installed <img width="470" alt="image" src=""Running view <img width="917" alt="image" src=""Hover of restart <img width="470" alt="image" src=""Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Change:
return; } if (_submenus.has(entry.value.id)) { <del> collector.warn(localize('submenuId.duplicate.id', "The `{0}` submenu was already previously registered.", entry.value.id)); </del> <ins> collector.info(localize('submenuId.duplicate.id', "The `{0}` submenu was already previously registered.", entry.value.id)); </ins> return; } if (!entry.value.label) {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0-insider OS Version: Darwin x64 21.5.0 Based on , I should be able to contribute the same submenu from two extensions and have them merge into one. The behavior works as expected, however these warnings appear. <img width="466" alt="image" src="https://user-"Steps to Reproduce: a submenu to the same location (ex: ) from two extensions. Extension A: Extension B: <details<summaryVS Code version details</summaryVersion: 1.68.0-insider Commit: Date: 2022-05-25T05:16:10.689Z Electron: 17.4.4 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin x64 21.5.0 </details
cc
Follow up: these warnings only seem appear when debugging. Installing from VSIX didn't repro
These warning are coming from and are you saying this only happens when you are debugging? So users will not actually see this? If that is the case then this might be expected behaviour. I think the users should not see this, but while debugging this might be useful to know - even though in your case you are merging the menus on purpose Anyways assigning to since he would best know how useful these warning are.
Yes, I found that it only happens when debugging.
Adding who submenu. I believe this message is fair, maybe we can tweak the severity to be info?
Change:
export class ExtractError extends Error { readonly type?: ExtractErrorType; <del> readonly cause: Error; </del> constructor(type: ExtractErrorType | undefined, cause: Error) { let message = cause.message;

Discussion:
Looks like we have broad support for . Static initialisers are the slight exception as they are only in Safari since ~2months. We might want to special case them, but otherwise we should be good to go:
On native privates: using them will be faster than weak-map-privates but slower than normal properties (much, much slower for Safari):
Some, perf number for some new API native privates - , faster than WeakMap privates but slower than conventional privates slower than []-access needs which need broader adoption because of semantic change.
Upstream issues for private property performance v8 - Webkit -
Change:
} catch (err) { if (/^error: failed to push some refs tob/m.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.PushRejected; <ins> } else if (/Permission.*denied/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.PermissionDenied; </ins> } else if (/Could not read from remote repository/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.RemoteConnectionError; } else if (/^fatal: The current branch .* has no upstream branch/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.NoUpstreamBranch; <del> } else if (/Permission.*denied/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.PermissionDenied; </del> } throw err;

Discussion:
For step 4 of , when I try publishing the branch, I get the error "Git: remote: Permission to joaomoreno/test-pr- denied to rzhao271." There is no option to create a fork: ! Originally posted by in
says: I got the same issue on the latest Insiders <img width="1202" alt="image" src="https://user-"Command output: Remote URL:
Can you give me exact steps?
I think I figured it out:
Verification: and clone a branch a change to and commit to push/publish that branch. Code should tell you that you can't push to that repo and will offer to fork the repository, accept.
Change:
return this._contributedEditors.get(viewType); } <del> add(info: NotebookProviderInfo): IDisposable { </del> <ins> add(info: NotebookProviderInfo, saveMemento = true): IDisposable { </ins> if (this._contributedEditors.has(info.id)) { throw new Error(`notebook type '${info.id}' ALREADY EXISTS`); }

Discussion:
Is this intentional? ! This makes the contribution quite slow on startup, and it feels off that it would save immediately. Would this be needed or could it run deferred?
Thanks!
Change:
"diffContentOptions" ], "activationEvents": [ <del> "*" </del> <ins> "onNotebook:jupyter-notebook", "onCommand:ipynb.newUntitledIpynb" </ins> ], "extensionKind": [ "workspace",

Discussion:
As discussed offline, I'm profiling initial load time, and happened to notice that the ipynb extension is activated as of It doesn't seem like activating should be necessary for the File New File flow to work but I might be missing some additional context.
Change:
} export interface InlineCompletionItemProvider<T extends InlineCompletionItem = InlineCompletionItem> { <del> provideInlineCompletionItems(document: TextDocument, position: Position, context: InlineCompletionContext, token: CancellationToken): ProviderResult<InlineCompletionList<T>>; </del> <ins> provideInlineCompletionItems(document: TextDocument, position: Position, context: InlineCompletionContext, token: CancellationToken): ProviderResult<InlineCompletionList<T> | T[]>; </ins> } export interface InlineCompletionContext {

Discussion:
Testing The existing API has , which returns . The new , API has , which returns . To better match the existing API, the version could return
That's a good idea! I've opened a PR for this, feel free to have a look if you like.