jiebi/CodeConvo huggingface dataset:
Change:
const config = workspace.getConfiguration('git'); let value = config.get<string>('defaultCloneDirectory') || os.homedir(); <del> value = value.replace(/^~/, os.homedir()); </del> const parentPath = await window.showInputBox({ prompt: localize('parent', "Parent Directory"), <del> value, </del> <ins> value: this.handlePathTilde(value), </ins> ignoreFocusOut: true });

Discussion:
Given , I should be able to Run In parent directory prompt, enter Get popup
Hasn't this issue been solved before ? If it hasn't I'll try to fix it.
Actually it seems the current solution can only handle in the config setting... but not in the input box!
hello I could take a look at the issue if no one is already assigned. It would be my first one. Regards, Pascal.
Hi let me know if you're working on the issue. I think I've found a solution.
go for it !
Change:
respectAutoSaveConfig: codeActionReason !== ApplyCodeActionReason.OnSave, showPreview: options?.preview, }); <ins> if (!result.isApplied) { return; } </ins> } if (item.action.command) {

Discussion:
re testing select some TS code that can be extracted as const select refactor with preview select extract const select discard :bug: the rename widget still shows... https://user-
I believe fixing this requires some info being returned from the bulk edit service, e.g the service should tell its caller that the change didn't happen so that code actions don't continue the normal flow
Change:
db_get @@NAME@@/add-microsoft-repo || true fi <del> # Install repository source list </del> <ins> # Determine whether to install the repository source list </ins> WRITE_SOURCE=0 if [ "$RET" = false ]; then <del> # The user does not want to add the microsoft repository </del> <ins> # The user does not want to add the Microsoft repository </ins> WRITE_SOURCE=0 <del> elif grep -q "http://packages.microsoft.com/repos/vscode" $CODE_SOURCE_PART; then </del> <ins> elif [ -f "$CODE_SOURCE_PART_DEB822" ]; then # The user has migrated themselves to the DEB822 format WRITE_SOURCE=0 elif [ -f "$CODE_SOURCE_PART" ] && (grep -q "http://packages.microsoft.com/repos/vscode" $CODE_SOURCE_PART); then </ins> # Migrate from old repository WRITE_SOURCE=2 <del> elif grep -q "http://packages.microsoft.com/repos/code" $CODE_SOURCE_PART; then </del> <ins> elif [ -f "$CODE_SOURCE_PART" ] && (grep -q "http://packages.microsoft.com/repos/code" $CODE_SOURCE_PART); then </ins> # Migrate from old repository WRITE_SOURCE=2 elif apt-cache policy | grep -q "https://packages.microsoft.com/repos/code"; then <del> # Skip following checks if the repo is already known to apt </del> <ins> # The user is already on the new repository </ins> WRITE_SOURCE=0 elif [ ! -f $CODE_SOURCE_PART ] && [ ! -f /etc/rpi-issue ]; then # Write source list if it does not exist and we're not running on Raspberry Pi OS

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.0- OS Version: Debian/testing Steps to Reproduce: previous version already installed the (deprecated) /etc/apt/trusted key folders to /etc/apt/keyrings/ and rewrite all ".list" files with the new format ".sources" update dist-upgrade again After step 4 apt complains about a missing directory: After step 5 it will have created a functional duplicate of as ; this is somehow related to in that the root cause is always the same, main difference is that the key file itself will apparently not be duplicated and apt won't complain (too much).
FYI a reasonable workaround is creating an empty file, then making it mode 444 and immutable. No error is reported on upgrade and no unwanted changes to apt sources occur.
Closing in favour of
Change:
return; } const targetPlatform = await this.extension!.server!.extensionManagementService.getTargetPlatform(); <del> const allVersions = await this.extensionGalleryService.getAllCompatibleVersions(this.extension!.gallery!, this.extension!.local!.isPreReleaseVersion, targetPlatform); </del> <ins> const allVersions = await this.extensionGalleryService.getAllCompatibleVersions(this.extension!.gallery!, this.extension!.local!.preRelease, targetPlatform); </ins> if (!allVersions.length) { await this.dialogService.show(Severity.Info, localize('no versions', "This extension has no other versions.")); return;

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 11 Steps to Reproduce: an extension which has published pre-releases before pre-release of that extension a new stable with a higher number than all the pre-releases Install another version :bug: existing pre-releases are not listed, as though the user never opted into pre-releases for that extension in the first place. There is also no indication that pre-releases exist for this extension anymore. You have to wait for the extension to publish the next pre-release before you can install pre-releases (I verified that this fixes things with the Azure Repos extension) Currently reproducible with the Python extension: !
Change:
@IConfigurationService private readonly _configurationService: IConfigurationService, @INotebookExecutionStateService private readonly _notebookExecutionStateService: INotebookExecutionStateService, ) { <del> super(); const selectionListener = this._register(new MutableDisposable()); </del> <ins> const selectionListener = new MutableDisposable(); this._dispoables.add(selectionListener); </ins> const installSelectionListener = () => { const notebookEditor = _editor.getControl(); if (!notebookEditor?.hasModel()) {

Discussion:
Testing Setting Open a github issue notebook You get: <img width="283" alt="image" src="https://user-"
Change:
'webp', ]); <ins> const videoFileExtensions = new Set<string>([ 'ogg', 'mp4' ]); </ins> export function registerDropIntoEditorSupport(selector: vscode.DocumentSelector) { return vscode.languages.registerDocumentDropEditProvider(selector, new class implements vscode.DocumentDropEditProvider { async provideDocumentDropEdits(document: vscode.TextDocument, _position: vscode.Position, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.DocumentDropEdit | undefined> {

Discussion:
Testing https://user-
I think this should rather generate tags instead of the relative link syntax for mp4 files?
Verified. Can't play the video in the preview, but not sure I should be able to. https://user-
It may be because you're in an untitled file, so we can't actually resolve that video path (since it is a relative path). Could you please try again having saved the text file to disk?
oh indeed works like magic <img width="1233" alt="image" src="https://user-"
Change:
registerAction2(class extends Action2 { constructor() { super({ <ins> id: FocusQueryEditorFilesToIncludeCommandId, title: { value: localize('search.action.focusFilesToInclude', "Focus Search Editor Files to Include"), original: 'Focus Search Editor Files to Include' }, category, f1: true, precondition: SearchEditorConstants.InSearchEditor, }); } async run(accessor: ServicesAccessor) { const editorService = accessor.get(IEditorService); const input = editorService.activeEditor; if (input instanceof SearchEditorInput) { (editorService.activeEditorPane as SearchEditor).focusFilesToIncludeInput(); } } }); registerAction2(class extends Action2 { constructor() { super({ id: FocusQueryEditorFilesToExcludeCommandId, title: { value: localize('search.action.focusFilesToExclude', "Focus Search Editor Files to Exclude"), original: 'Focus Search Editor Files to Exclude' }, category, f1: true, precondition: SearchEditorConstants.InSearchEditor, }); } async run(accessor: ServicesAccessor) { const editorService = accessor.get(IEditorService); const input = editorService.activeEditor; if (input instanceof SearchEditorInput) { (editorService.activeEditorPane as SearchEditor).focusFilesToExcludeInput(); } } }); registerAction2(class extends Action2 { constructor() { super({ </ins> id: ToggleSearchEditorCaseSensitiveCommandId, title: { value: localize('searchEditor.action.toggleSearchEditorCaseSensitive', "Toggle Match Case"), original: 'Toggle Match Case' }, category,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In the search editor, there is to focus on the query. I'd like to be able to set a keyboard shortcut to focus on "files to include" and "files to exclude". I'd be willing to add this. It doesn't seem too difficult.
Change:
setAccessibilitySupport(accessibilitySupport: AccessibilitySupport): void { } getAccessibilitySupport(): AccessibilitySupport { return AccessibilitySupport.Unknown; } alert(message: string): void { } <ins> status(message: string): void { } </ins> }

Discussion:
Testing While testing I noticed that when I moved my cursor on a line with an error, the word was read, but the contents of that line were no longer read. I was wondering if this is intended? I noticed that sometimes the beginning of the text on the line is read, before it breaks off and reads the alerts.
I noticed that sometimes when I put my cursor on a line with a breakpoint, it does not read the word . Is the alert only supposed to sound at specific moments? Ie, for example the first time the cursor is placed on an active line with a breakpoint?
alerts interrupt whatever else might be read by design. And yes, it looks like in your case, you're using mouse clicks vs arrow keys to navigate between the lines. We listen to arrow keys, thus it's expected that you wouldn't hear the cues.
Additionally, I have checked with our power SR users and the alerts are working as expected in the editor.
I am going to open an issue to get more feedback on this.
Hi thank you for the clarification, that makes sense.
We are going to use instead here because editor content is the priority.
Change:
import { timeout } from 'vs/base/common/async'; import { generateUuid } from 'vs/base/common/uuid'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; import { ILogService } from 'vs/platform/log/common/log'; import { INativeHostService } from 'vs/platform/native/electron-sandbox/native';

Discussion:
Since long we automatically profile the extension host when it becomes unresponsive. In that cases we send a signal via telemetry and in bad cases we ask users to file issues. During that we ask them to attach the corresponding profile but we have mixed results with that. So, in addition to the existing flow we want to log a richer telemetry event that uploads the heaviest sample trace from the profiling
Change:
const showProblemPanel = task.command.presentation && (task.command.presentation.revealProblems === RevealProblemKind.Always); if (showProblemPanel) { this._viewsService.openView(Markers.MARKERS_VIEW_ID); <del> } else if (task.command.presentation && (task.command.presentation.reveal === RevealKind.Always)) { </del> <ins> } else if (task.command.presentation && (task.command.presentation.focus || task.command.presentation.reveal === RevealKind.Always)) { </ins> this._terminalService.setActiveInstance(terminal); this._terminalGroupService.showPanel(task.command.presentation.focus); }

Discussion:
Type: <bBug</b"" on VS Code this task and save: this task ([Terminal] [Run Task] [Throw my error]) Enter The integrated terminal shows an error because of . Pressing Enter closes it because of .The integrated terminal shows an error because of . Pressing Enter inserts a line break into the current opened "", or at least leaves the terminal open. Terminal display: I use Git Bash of Git for Windows as my default terminal (), but I've tried and PowerShell and got the same result. Of cause, if the command is , the terminal doesn't appear because of . "Reload With Extensions Disabled" has no effect. TBH, I know this is a duplicate of . It has already been closed as a "feature-request" that didn't receive enough upvotes. It may be impolite to reopen a closed issue in this way, and I'm very hesitant to do so, but for the life of me, I can't believe that fixing this counter-intuitive behavior is within the scope of feature requests. The current behavior is surprising, not convincing. I'm sorry if there are already other ways to achieve the expected behavior. VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ Bookmarks13.3.1 project-manager12.7.0 laravel-extra-intellisense0.6.3 markdown-preview-github-styles2.0.2 insert-unicode0.14.0 laravel-blade1.1.2 vscode-eslint2.4.0 vscode-deno3.19.1 EditorConfig0.16.4 gc-excelviewer4.2.57 code-eol1.0.12 haml1.4.1 live-stylus-compiler0.0.4 zenkaku0.0.3 vscode-language-pack-ja1.79.

remote-containers0.295.0 live-server0.4.8 laravel-blade1.34.0 laravel5-snippets1.17.0 LiveServer5.7.9 language-stylus1.16.0 vscode-input-sequence0.2.0 markdown-all-in-one3.5.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
So you mean it isn't a bug? The "focus" option doesn't make focus. Is this intended behavior?
You're right - it is a bug
I'll fix that
Change:
import { APPLY_ALL_PROFILES_SETTING, IWorkbenchConfigurationService } from 'vs/workbench/services/configuration/common/configuration'; import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; <del> import { ISetting, ISettingsGroup, SettingValueType } from 'vs/workbench/services/preferences/common/preferences'; </del> <ins> import { ISetting, ISettingsGroup, SETTINGS_AUTHORITY, SettingValueType } from 'vs/workbench/services/preferences/common/preferences'; </ins> import { getInvalidTypeError } from 'vs/workbench/services/preferences/common/preferencesValidation'; import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; import { IHoverService } from 'vs/platform/hover/browser/hover'; <ins> import { URI } from 'vs/base/common/uri'; </ins> const $ = DOM.$;

Discussion:
Now that we can handle settings URLs, we could have a "Copy URL" command in the settings editor: ! From
FYI.
Thanks for the ping! "Copy URL" sounds vague. I'd prefer "Copy URL to Setting". Also, is it just the URL that's copied over, or the entire anchor element?
Since we have "Copy Setting as JSON" maybe "Copy Setting as URL". Which would yield (or if copied from insiders)
To verify: Open the settings editor In an individual setting's menu, choose the "Copy Setting as URL" action Verify that a URL to the setting is copied Verify that if you close VS Code and open the URL that VS Code is opened to the setting
Verified. I've used this a ton recently!
Change:
) .await?; <del> unzip_downloaded_release( &archive_path, &target_dir.join(SERVER_FOLDER_NAME), SilentCopyProgress(), )?; </del> <ins> let server_dir = target_dir.join(SERVER_FOLDER_NAME); unzip_downloaded_release(&archive_path, &server_dir, SilentCopyProgress())?; let output = capture_command_and_check_status( server_dir .join("bin") .join(self.server_params.release.quality.server_entrypoint()), &["--version"], ) .await .map_err(|e| wrap(e, "error checking server integrity"))?; trace!( self.logger, "Server integrity verified, version: {}", String::from_utf8_lossy(&output.stdout).replace('n', " / ") ); </ins> Ok(()) })

Discussion:
Type: <bBug</bNote: I was unable to create a bug report after I choose the "An extension" option in the dropdown in the "Help: Report Issue..." window as it does not show any of my extensions (I do have extensions for whatever reason the bug report does not show them) After installing 1.82.0 (insiders), I started to get the following error message: Failed to connect to the remote extension host server (Error: WrappedError(WrappedError { message: "server exited without writing socket", original: "channel closed" })) And Could not fetch remote environment When I use an older version (via regular VsCode) this issue does not happen. VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-28T05:35:52.131Z) OS version: WindowsNT x64 10.0. Modes: Connection to 'SSH: ' could not be established WrappedError(WrappedError { message: "server exited without writing socket", original: "channel closed" }) <details<summarySystem Info</summary Connection to 'SSH: ' could not be established WrappedError(WrappedError { message: "server exited without writing socket", original: "channel closed" }) </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please share the full output of in the Output panel when you get into this state
I captured all the logs below with all of its attempts
Thanks! What happens if you SSH in manually and run the server using this command?
My bash output
It looks like the server perhaps did not get extracted fully. We can add some checks around that. I suspect deleting the directory would fix it
That worked thank you
We should do an integrity check before finalizing the server directory however
Verified that the SSH log contains the message which got by the fix
Change:
"languages": [{ "id": "csharp", "extensions": [ ".cs", ".csx" ], <del> "aliases": [ "C#", "csharp" ] </del> <ins> "aliases": [ "C#", "csharp" ], "configuration": "./csharp.configuration.json" </ins> }], "grammars": [{ "language": "csharp",

Discussion:
Testing !
The binary is indeed available in the server folder but the libc library it is linked with does not exist on the image.
Ripgrep should also build for rust target in to support alpine images so that it is uses the musl c library.
I can add that, thanks
Ripgrep couldn't build under that target. My understanding is… when building with musl, it uses jemalloc, jemalloc uses backgroundthreadsruntime_support, and that doesn’t support our target. If we can figure out how to un set that flag on jemalloc that might work around it but i don’t know what consequences that would have
from it is not sure whether the bug is in jemalloc config or cargo, but the immediate working solution is to build the crate with I will see if that works.
May I know if there is some workaround for this bug for users? If not, I do not think its good to ship Alpine ARM 64 builds with broken experience.
It will require users to install package that will include the required libraries for the executable built using glibc.
Not with your PR, right And thanks for the PR!
Yup is not needed with the musl binary produced from the PR.
I didn't put up a PR to adjust to download for alpine. Can you take care of it ? Thanks!

When using the block comment feature, only 2 single quotes are put in, instead of three.
Python block comments are triple quotes, not double. Check if that works.
It does! Thanks the bug is then that only 2 quotes are put in.
Fixed, see , reviewed by Alex

Type if ( expected =closing ) actual =nothing
Fixed by me, reviewed by Alex, see ,
Change:
return [ baseRange.input1Diffs.length > 0 ? action( <del> 'mergeEditor.takeInput1', localize('mergeEditor.takeInput1', 'Take Input 1'), </del> <ins> 'mergeEditor.acceptInput1', localize('mergeEditor.accept', 'Accept {0}', model.input1Title), </ins> state.toggle(1), state.input1 ) : undefined, baseRange.input2Diffs.length > 0 ? action( <del> 'mergeEditor.takeInput2', localize('mergeEditor.takeInput2', 'Take Input 2'), </del> <ins> 'mergeEditor.acceptInput2', localize('mergeEditor.accept', 'Accept {0}', model.input2Title), </ins> state.toggle(2), state.input2 ) : undefined, baseRange.isConflicting <del> ? action( 'mergeEditor.takeBothSides', localize( 'mergeEditor.takeBothSides', 'Take Both Sides' </del> <ins> ? setFields( action( 'mergeEditor.acceptBoth', localize( 'mergeEditor.acceptBoth', 'Accept Both' ), state.withInput1(!both).withInput2(!both), both </ins> ), <del> state.withInput1(!both).withInput2(!both), both </del> <ins> { enabled: true } // TODO </ins> ) : undefined, baseRange.isConflicting

Discussion:
commands in the merge editor checkbox context menu need to be disabled when they are not applicable. "Take Input1" should be called "Accept Theirs" "Take Input2" should be called "Accept Yours" "Take Both Sides" should be called "Accept Both" Palette actions should also not talk about Input1 and Input2 Also I am not sure if "Yours" and "Theirs" is better than "Current" and "Incoming" what we previously used This way we are aligning with the previous wording our users are already familiar with ! ! fyi
Now it aligns with whatever the title says. The caller of the merge editor can set the title (Theirs/Yours for git) !
Nice. Does git provide yours/theirs or is that us setting that? I thought we used Current/Incoming in our codelens actions.
The git extension, yes. The opener of the merge editor can set it.
Change:
private static readonly showCommandsId = 'workbench.action.showCommands'; private static readonly openSettingsId = 'workbench.action.openGlobalSettings'; private static readonly openKeybindingsId = 'workbench.action.openGlobalKeybindings'; <ins> private static readonly selectColorThemeId = 'workbench.action.selectTheme'; private static readonly selectIconThemeId = 'workbench.action.selectIconTheme'; </ins> get id() { return 'vs.update'; } get name() { return ''; }

Discussion:
Suggest to add the and to the gear menu. !
Would love to see that. Can I provide an pr?
always