jiebi/CodeConvo huggingface dataset:
Change:
precondition: TerminalContextKeys.processSupported }); } <del> async run(accessor: ServicesAccessor) { return accessor.get(ITerminalService).activeInstance?.rename(); </del> <ins> async run(accessor: ServicesAccessor, resource: unknown) { const terminalService = accessor.get(ITerminalService); const castedResource = URI.isUri(resource) ? resource : undefined; const instance = terminalService.getInstanceFromResource(castedResource) || terminalService.activeInstance; instance?.rename(); </ins> } }); registerAction2(class extends Action2 { constructor() { super({

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Arch Linux Steps to Reproduce: two or more terminals in the panel. one or more terminals into the editor area. ! to rename either an unfocused editor area terminal, or if only one terminal remains in the panel, the panel terminal by right clicking when the editor area has had last focus. ! ! ! name of the most recently focused editor terminal (even if none is presently selected) changes, rather than the right-clicked terminal (whether an unfocused editor area terminal or the unfocused panel terminal). ! Expected behaviour: The name of the terminal selected on right click will be changed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.56 --- <!-- score: 0.536 --- <!-- score: 0.526 --- <!-- score: 0.523 --- <!-- score: 0.514 --<!-- potentialduplicatescomment --
Same applies to color and icon
It's still the case that the active editor terminal, rather than the one that was right-clicked on, is the one that the changes get applied to.
Change:
private readonly _focusedContextKey: IContextKey<boolean>; private readonly _focusTracker: dom.IFocusTracker; private _inQuickPick = false; <del> private _prependNewLine = false; private _bufferToEditorIndex: Map<number, number> = new Map(); </del> constructor( private readonly _instance: ITerminalInstance,

Discussion:
Using here, I cannot enter the accessible buffer https://user-
The issue is that here, the default tab behavior is to focus the terminal tabs element edit: hard to repro, that's not the cause
ok this happens when is not applied to . See here that the buffer editor does get focused here, but you cannot see it https://user-
Repro: run some commands - - - Try to wasn't applied to so the accessible buffer isn't visible
https://user-

Currently when you use navigate accessible buffer you get a quick pick with the options, I expected changing these to scroll to the position without accepting it, and escape to revert to the original scroll position.
As part of this, providing ~1/3 of the viewport of context above would also be good
We'd need to think about how we to communicate the preview information to a screen reader user, as a pre"view" is usually visual
I don't think making this available to the screen reader makes sense, it would just complicate navigating the list. It is useful for sighted users though.
Oh I understand now - you mean on change of the active quick pick item, reveal the line and on enter, focus that line (as it already does)
Yep
To verify, in a terminal with shell integration, run some commands. to enter the accessible buffer. to . Without pressing , use the arrow keys to go between the options. It should scroll to the command if it is outside of the viewport.
Works but I opened
Change:
semanticHighlighting: { description: nls.localize('editorColors.semanticHighlighting', 'Whether semantic highlighting should be enabled for this theme.'), deprecationMessage: nls.localize('editorColors.semanticHighlighting.deprecationMessage', 'Use `enabled` in `editor.semanticTokenColorCustomizations` setting instead.'), <del> markdownDeprecationMessage: nls.localize('editorColors.semanticHighlighting.deprecationMessageMarkdown', 'Use `enabled` in `#editor.semanticTokenColorCustomizations#` setting instead.'), </del> <ins> markdownDeprecationMessage: nls.localize({ key: 'editorColors.semanticHighlighting.deprecationMessageMarkdown', comment: ['{0} will become a link to another setting.'] }, 'Use `enabled` in {0} setting instead.', formatSettingAsLink('editor.semanticTokenColorCustomizations')), </ins> type: 'boolean' } },

Discussion:
open the settings, in the filter box enter . Check the settings description. It should contain links. The links use a special syntax: that must not be changed. The translated string has a message mentioning that. !
Thank you for your feedback. We are currently reviewing it (reference ).
could you please lock the placeholders with these annotations? I'll fix the local translation meanwhile.
I've got a fix out ^^
Verified in code while the translation is in work.
Change:
export default class TypeScriptImplementationsCodeLensProvider extends TypeScriptBaseCodeLensProvider { public constructor( client: ITypeScriptServiceClient, <del> private readonly language: string </del> <ins> private readonly language: string, cachedResponse: CachedNavTreeResponse </ins> ) { <del> super(client); </del> <ins> super(client, cachedResponse); </ins> } public updateConfiguration(): void {

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.
Change:
export const listDeemphasizedForeground = registerColor('list.deemphasizedForeground', { dark: '#8C8C8C', light: '#8E8E90', hcDark: '#A7A8A9', hcLight: '#666666' }, nls.localize('listDeemphasizedForeground', "List/Tree foreground color for items that are deemphasized. ")); /** <ins> * Checkboxes */ export const checkboxBackground = registerColor('checkbox.background', { dark: selectBackground, light: selectBackground, hcDark: selectBackground, hcLight: selectBackground }, nls.localize('checkbox.background', "Background color of checkbox widget.")); export const checkboxSelectBackground = registerColor('checkbox.selectBackground', { dark: editorWidgetBackground, light: editorWidgetBackground, hcDark: editorWidgetBackground, hcLight: editorWidgetBackground }, nls.localize('checkbox.select.background', "Background color of checkbox widget when the element it's in is selected.")); export const checkboxForeground = registerColor('checkbox.foreground', { dark: selectForeground, light: selectForeground, hcDark: selectForeground, hcLight: selectForeground }, nls.localize('checkbox.foreground', "Foreground color of checkbox widget.")); export const checkboxBorder = registerColor('checkbox.border', { dark: selectBorder, light: selectBorder, hcDark: selectBorder, hcLight: selectBorder }, nls.localize('checkbox.border', "Border color of checkbox widget.")); export const checkboxSelectBorder = registerColor('checkbox.selectBorder', { dark: editorWidgetBackground, light: editorWidgetBackground, hcDark: editorWidgetBackground, hcLight: editorWidgetBackground }, nls.localize('checkbox.select.border', "Border color of checkbox widget when the element it's in is selected.")); /** </ins> * Quick pick widget (dependent on List and tree colors) */ export const _deprecatedQuickInputListFocusBackground = registerColor('quickInput.list.focusBackground', { dark: null, light: null, hcDark: null, hcLight: null }, '', undefined, nls.localize('quickInput.list.focusBackground deprecation', "Please use quickInputList.focusBackground instead"));

Discussion:
With default Dark+ theme: !
Hi, I want to work on this, and I think is the file that needs to be changed, could you please advise on this? Thanks!
Change:
import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { Action2, registerAction2 } from 'vs/platform/actions/common/actions'; <del> import { accessibilityHelpIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; </del> <ins> import { accessibilityHelpIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution'; </ins> import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { alert } from 'vs/base/browser/ui/aria/aria';

Discussion:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
import * as path from 'vs/base/common/path'; import * as platform from 'vs/base/common/platform'; import * as pty from 'node-pty'; <ins> import * as fs from 'fs'; </ins> import { Event, Emitter } from 'vs/base/common/event'; import { ITerminalChildProcess } from 'vs/workbench/contrib/terminal/node/terminal'; import { IDisposable } from 'vs/base/common/lifecycle';

Discussion:
Version: 1.31.1 Commit: OS: Linux x64 4.15.0-29deepin-generic Does this issue occur when all extensions are disabled?: Yes I can't split my terminal by clicking Split Terminal icon on terminal. When I click nothing happens. Instead I click new terminal icon, choose from drop-down menu and switch the other terminal which is not so handy.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.559 --- <!-- score: 0.531 --- <!-- score: 0.509 --- <!-- score: 0.501 --- <!-- score: 0.477 --<!-- potentialduplicates_comment --
are there any errors in the console (Help Toggle Developer Tools) when you try split? How wide is the terminal you're trying to split?
there's no error in the console while clicking split terminal. It looks like the icon is just an UI element with no further functionalities. All I want is to have an equal terminal.
how wide is the terminal when you're trying to split? Can you show a screenshot of the terminal immediately after it failed to split?
recorded !
There's an older open issue (and many closed ones) that this is a duplicate of: , and mentions a fix: Install or add to options (not sure what that means). Can confirm installing works. Version: v1.31.1 (and v1.31.0) Commit: Electron: 3.1.3 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Linux x64 4.20.8-arch1-1-ARCH
Thanks for help, it worked. Not sure I should close the issue, because it was solved by installing third-party dependency
thanks for finding this! We should fallback to when doesn't exist here:
Change:
private getLanguages(): { [locale: string]: { name: string } } { return { <del> ['da-DK']: { name: localize('speechLanguage.da-DK', "Danish (Denmark)") </del> <ins> ['auto']: { name: localize('speechLanguage.auto', "Auto (Use Display Language)") </ins> }, <del> ['de-DE']: { name: localize('speechLanguage.de-DE', "German (Germany)") }, ['en-AU']: { name: localize('speechLanguage.en-AU', "English (Australia)") }, ['en-CA']: { name: localize('speechLanguage.en-CA', "English (Canada)") }, ['en-GB']: { name: localize('speechLanguage.en-GB', "English (United Kingdom)") }, ['en-IE']: { name: localize('speechLanguage.en-IE', "English (Ireland)") }, ['en-IN']: { name: localize('speechLanguage.en-IN', "English (India)") }, ['en-NZ']: { name: localize('speechLanguage.en-NZ', "English (New Zealand)") }, [SpeechLanguageDefault]: { name: localize('speechLanguage.en-US', "English (United States)") }, ['es-ES']: { name: localize('speechLanguage.es-ES', "Spanish (Spain)") }, ['es-MX']: { name: localize('speechLanguage.es-MX', "Spanish (Mexico)") }, ['fr-CA']: { name: localize('speechLanguage.fr-CA', "French (Canada)") }, ['fr-FR']: { name: localize('speechLanguage.fr-FR', "French (France)") }, ['hi-IN']: { name: localize('speechLanguage.hi-IN', "Hindi (India)") }, ['it-IT']: { name: localize('speechLanguage.it-IT', "Italian (Italy)") }, ['ja-JP']: { name: localize('speechLanguage.ja-JP', "Japanese (Japan)") }, ['ko-KR']: { name: localize('speechLanguage.ko-KR', "Korean (South Korea)") }, ['nl-NL']: { name: localize('speechLanguage.nl-NL', "Dutch (Netherlands)") }, ['pt-PT']: { name: localize('speechLanguage.pt-PT', "Portuguese (Portugal)") }, ['pt-BR']: { name: localize('speechLanguage.pt-BR', "Portuguese (Brazil)") }, ['ru-RU']: { name: localize('speechLanguage.ru-RU', "Russian (Russia)") }, ['sv-SE']: { name: localize('speechLanguage.sv-SE', "Swedish (Sweden)") }, ['tr-TR']: { name: localize('speechLanguage.tr-TR', "Turkish (Turkey)") }, ['zh-CN']: { name: localize('speechLanguage.zh-CN', "Chinese (Simplified, China)") }, ['zh-HK']: { name: localize('speechLanguage.zh-HK', "Chinese (Traditional, Hong Kong)") }, ['zh-TW']: { name: localize('speechLanguage.zh-TW', "Chinese (Traditional, Taiwan)") } </del> <ins> ...SPEECH_LANGUAGES </ins> }; } }

Discussion:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked
Change:
titlebarPart = disposables.add(this.titleService.createAuxiliaryTitlebarPart(auxiliaryWindow.container, editorPart)); titlebarPartVisible = true; <del> disposables.add(titlebarPart.onDidChange(() => updateEditorPartHeight(true))); disposables.add(onDidChangeZoomLevel(targetWindowId => { if (auxiliaryWindow.window.vscodeWindowId === targetWindowId && titlebarPartVisible) { // This is a workaround for https://github.com/microsoft/vscode/issues/202377 // The title bar part prevents zooming in certain cases and when doing so, // adjusts its size accordingly. This is however not reported from the // `onDidchange` event that we listen to above, so we manually update the // editor part height here. updateEditorPartHeight(true); } })); </del> <ins> disposables.add(titlebarPart.onDidChange(() => auxiliaryWindow.layout())); </ins> disposables.add(onDidChangeFullscreen(windowId => { if (windowId !== auxiliaryWindow.window.vscodeWindowId) { return; // ignore all but our window

Discussion:
Testing a workspace a tab into a new floating window in a couple times using keyboard shortcuts the zoom status bar item to zoom out. When the zoom out happens, the status bar item will move further right, as expected because everything is getting small. However, the hover itself moved further left. I would expect it to either stay under my cursor (ideal) or move with the status bar item. !
It also moves around unexpectedly when I zoom in.
My cursor isn't showing properly in this gif, but I think you can get the idea. !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Change:
"--vscode-notificationsErrorIcon-foreground", "--vscode-notificationsInfoIcon-foreground", "--vscode-notificationsWarningIcon-foreground", <del> "--vscode-outputEditor-background", "--vscode-outputEditorStickyScroll-background", </del> <ins> "--vscode-outputView-background", "--vscode-outputViewStickyScroll-background", </ins> "--vscode-panel-background", "--vscode-panel-border", "--vscode-panel-dropBorder",

Discussion:
Followup from I wouldn't call the color . For the user it is not an editor, just a view. Either or
Change:
class TestEditorInputFactory implements IEditorInputFactory { <ins> static disableSerialize = false; static disableDeserialize = false; </ins> canSerialize(editorInput: EditorInput): boolean { return true; } <del> serialize(editorInput: EditorInput): string { </del> <ins> serialize(editorInput: EditorInput): string | undefined { if (TestEditorInputFactory.disableSerialize) { return undefined; } </ins> let testEditorInput = <TestEditorInput>editorInput; let testInput: ISerializedTestInput = { id: testEditorInput.id

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --I'm unsure how I got into this state, but I can't close VS Code or reload the window. Stack sohwn when I try to exit:
I cannot explain this, it seems the editor tabs model think there is an editor that does not exist anymore. Needs steps to get any further.
Upon second thought, this can maybe happen if an editor fails to serialize on shutdown. Given we have quite a few new editors, maybe this happens more often now. Marking as candidate to look into and guard against this condition.
Yea, if I recall correctly this happened after I had been playing around with notebooks/custom editors in that window.
if you can try to reproduce, it would still be great to have steps
I have a feeling this could well be notebooks given how the always returns data but the may not. //cc to check if that is a problem. If you know for a fact that you cannot serialize the notebook, please already signal that by returning from the method.
this, I guess we just need to return !(input instanceof NotebookEditorInput)`?
To clarify: it is perfectly valid to return in either of the 2 methods. I pushed a fix to handle this properly on my end. I just wanted to point out that it is always better to return early (from the ) to reduce the data we store in SQLite.
But my that the notebook editor input factory is only called with "my" inputs is valid, right? Or should I assume that it is called with any kind of input and return undefined then?
yeah that assumption is right, you will only be called for inputs you register the factory for.
I don't think anyone has a consistent repro for this, so I will mark it as verified unless I run into it again.
Change:
return result; } <ins> private _getStreamOutputData(outputs: IOutputItemDto[]) { if (!outputs.length) { return null; } const first = outputs[0]; const mime = first.mime; const sameStream = !outputs.find(op => op.mime !== mime); if (sameStream) { return outputs.map(opit => new TextDecoder().decode(opit.data)).join(''); } else { return null; } } </ins> async provideOutputTextContent(resource: URI): Promise<ITextModel | null> { const existing = this._modelService.getModel(resource); if (existing) {

Discussion:
Version: 1.59.0-insider (user setup) Commit: Date: 2021-08-04T09:44:34.203Z (1 day ago) Electron: 13.1.7 Chrome: 91.0.4472.124 14.16.0 V8: 9.1.269.36-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: In a Python notebook or interactive session done click on "show more (open the raw output data in a text editor) ..." ! I would have expected to just see a file with numbers from 1 to 1000
Make sense to me. For single mimetype output, we should directly convert that to the right format.