jiebi/CodeConvo huggingface dataset:
Change:
// <user>@<auth> const userinfo = authority.substr(0, idx); authority = authority.substr(idx + 1); <del> idx = userinfo.indexOf(':'); </del> <ins> idx = userinfo.lastIndexOf(':'); </ins> if (idx === -1) { <del> res += encoder(userinfo, false); </del> <ins> res += encoder(userinfo, false, false); </ins> } else { // <user>:<pass>@<auth> <del> res += encoder(userinfo.substr(0, idx), false); </del> <ins> res += encoder(userinfo.substr(0, idx), false, false); </ins> res += ':'; <del> res += encoder(userinfo.substr(idx + 1), false); </del> <ins> res += encoder(userinfo.substr(idx + 1), false, true); </ins> } res += '@'; } authority = authority.toLowerCase(); <del> idx = authority.indexOf(':'); </del> <ins> idx = authority.lastIndexOf(':'); </ins> if (idx === -1) { <del> res += encoder(authority, false); </del> <ins> res += encoder(authority, false, true); </ins> } else { // <auth>:<port> <del> res += encoder(authority.substr(0, idx), false); </del> <ins> res += encoder(authority.substr(0, idx), false, true); </ins> res += authority.substr(idx); } }

Discussion:
wrongly encode IPv6 literals ( This is an issue with but if I understand correctly issues should be reported here ) can parse IPv6 literal address fine (examples are using node REPL) but will encode the : This string representation of the URI cannot be used for example by a web browser. This encoding seems to happen here <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: not applicable <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: main ( ) OS Version: linux Steps to Reproduce: actual: expected:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Looks similar to:
Change:
} class SplitPane implements IView { <del> minimumSize: number = SPLIT_PANE_MIN_SIZE; </del> <ins> minimumSize: number = Constants.SplitPaneMinSize; </ins> maximumSize: number = Number.MAX_VALUE; orientation: Orientation | undefined;

Discussion:
Previously the terminal could be resized fairly quickly, to see what's going on and then hide it again (with 2 lines still visible). With the new update however, it can only be resized by one line per keystroke. So in order to use the terminal adequately, there are 10 - 20 keystrokes required, which is unacceptable (in my opinion). It would be great, if you could specify "args" for the command which control how many lines the terminal is resized by. Similar like the cursorMove command: Thanks for consideration, Floyd Haremsa <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -→
I'm not sure what you mean. changing the height of the panel? https://user-
Yes, changing the height of the panel, but with keyboard shortcuts. Previously it worked pretty well (changing the height by lets say 10 lines, I don't quite remember). But now you can only resize by one line at a time (per hitting the keyboard shortcut), like this: https://user- and that is just way too slow and inefficient. This way I'm forced to resize it with the mouse (which is also too slow) or having it open all the time, which is bad on small screen sizes. Sorry for not having it clarified enough earlier.
we think this is related to the increase view size change - thoughts ?
This is indeed caused by The new behavior is actually the intended behavior, but the terminal is in full control if it wants to have a number-of-lines-based resize setting.
I am also affected by this and it is crazy to work mouseless, resizing terminal is not viable with keyboard like this. Any work around?
how many rows would you expect it to change?
3-4 would be nice
I'd say about 7 - 10 lines at a time. But if I can control it my self, that's even better.
Also being affected by this. The terminal now resizes by 1 line at a time.

Previously it was 9 lines (3072×1920 on 16" with terminal.integrated.fontSize = 13) Something in the range of 4-8 lines might be a decent compromise considering the original request that led to the change ()
I think the best approach would be to just have a default of let's say 4 lines, but also a setting that controls this, and/or as I mentioned, arguments to the command for being able to map multiple resize settings to different shortcuts:
I'd rather not add a setting for this as it's pretty obscure and would see hardly any usage. An additional complication here is I'd like to eventually remove the terminal resize commands since we now have the increase/decrease view size commands which weren't around when the terminal resize pane commands got . Seems like 4 rows should work for most people.
Can confirm this is fixed in Insiders. Thanks for the quick response
Change:
if (this._ptyProcess) { await this._throttleKillSpawn(); this._logService.trace('IPty#kill'); <del> this._ptyProcess.kill(!isWindows ? 'SIGKILL' : undefined); </del> <ins> this._ptyProcess.kill(); </ins> } } catch (ex) { // Swallow, the pty has already been killed

Discussion:
Running commands in a normal bash terminal retains the history (of the commands ran) but the same is not true for VS Code. So after closing VSCode all of the command history is deleted and the user has to remember any complex command that they ran. Ideally we would want our history to be stored in .bashhistory or if VS Code doesn't want to touch user files, in .vscodebash_history perhaps?
This works for me
Doesn't work for me either, tried deleting and re-installing, no dice.
Maybe this is a remote issue
More reports here:
This affects me on my MacBook Pro as well. It's a problem 100% of the time, it's not intermittent. I'm guessing it's not a remote issue, as it happens when I'm using a completely local folder without any sort of remote functionality. There are several other reports of this issue in as well. If I type to close the terminal before I quit VS Code, the history is saved like it should be. If I quit VS Code without doing that, the history is lost. This is a recent issue (within the last couple of months or so), it used to work correctly. Happy to provide any other info that can help diagnose this, as I can always reproduce it.
Yes, the history save feature works if I type or to close the terminal. Doing it by any other way (like clicking the trash button to close the terminal) does not save the history.
I think that I have found the issue. In this line, we are sending instead of , hence the process gets killed without the chance to write the history to the file () However it seems that this change was made because the terminal subprocess (running ) couldn't be killed because the are also gobbling up any signal. Hence this issue I think the solution to this can be done by creating a function something like : (relevant discussion in ) That way, the signal can be intercepted and exited as needed.
If it is possible, could you help me to write a patch to fix this issue? :smile: I have tried patching the function in the file to trap however, I am having trouble getting it to work.
Change:
} else if (query.isRegExp) { let fixedRegexpQuery = fixRegexEndingPattern(query.pattern); fixedRegexpQuery = fixRegexNewline(fixedRegexpQuery); <ins> fixedRegexpQuery = fixNewline(fixedRegexpQuery); </ins> fixedRegexpQuery = fixRegexCRMatchingNonWordClass(fixedRegexpQuery, !!query.isMultiline); fixedRegexpQuery = fixRegexCRMatchingWhitespaceClass(fixedRegexpQuery, !!query.isMultiline); args.push('--regexp', fixedRegexpQuery);

Discussion:
Open folder containing CRLF files (typically on windows) Copy multiple lines of text, paste into search viewlet Close that file Do multiline search The file is not found cc Candidate because the feature is essentially completely broken on windows.
Change:
return null; } <del> const insertContent = below.getText(); </del> <ins> const insertContent = (cell.textModel?.getEOL() ?? '') + below.getText(); </ins> const cellLineCount = cell.textModel.getLineCount(); const cellLastLineEndColumn = cell.textModel.getLineLength(cellLineCount);

Discussion:
Testing I wouldn't expect joining a cell with the next cell to put the next cells first line on the same line at this cells last line. I think in most cases people wont leave trailing newlines, but they would expect joined cells to not mangle themselves. Similarly for splitting, I think we should remove dangling newlines.
Change:
import { IHoverTarget, IHoverService } from 'vs/workbench/services/hover/browser/hover'; import { registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { editorHoverHighlight } from 'vs/platform/theme/common/colorRegistry'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { TerminalSettingId } from 'vs/platform/terminal/common/terminal'; </ins> const $ = dom.$;

Discussion:
Forking off the setting part off from PR:
Hello, is this issue is still open. I am new to open source and wanted to contribute.
there's a PR open already for this one
Change:
const withInnerHTML = new Promise<void>(c => signalInnerHTML = c); const renderer = new marked.Renderer(); renderer.image = (href: string, title: string, text: string) => { let dimensions: string[] = []; let attributes: string[] = []; if (href) { ({ href, dimensions } = parseHrefAndDimensions(href)); <del> href = _href(href, true); try { const hrefAsUri = URI.parse(href); if (options.baseUrl && hrefAsUri.scheme === Schemas.file) { // absolute or relative local path, or file: uri href = resolvePath(options.baseUrl, href).toString(); } } catch (err) { } </del> attributes.push(`src="${href}"`); } if (text) {

Discussion:
Version: 1.62.0-insider (Universal) Commit: Date: 2021-10-28T05:14:00.367Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin arm64 20.6.0 Setting , on the markdown document of a completion item, an tag cannot load a PNG file if the path given as a URI with . If the path given as the path of a local filesystem, it can load the file. Steps to Reproduce: one of images cannot be loaded. !
Can I pick this up?
Sure, the relevant code where we fix image paths is:
For the markdown syntax images, if the URI schema is , that's being changed to . For the HTML tag images, the file URI remains as is. The HTML image with URI doesn't load due to CSP violation.
Yes uris are blocked for security reasons. The problem is that raw html tags don't go through the transform that I linked to One thing to try would be to look for image nodes in the rendered markdown and then transform their uris instead of relying on the markdown parser to handle the transform. Try looking at for that
/verified
Change:
"when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0 && isInNotebookTextDiffEditor && resourceScheme =~ /^git$|^file$/" }, { <del> "command": "git.openChange", </del> <ins> "command": "git.openChangeEditor", </ins> "group": "navigation", "when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0 && !isInDiffEditor && resourceScheme == file" },

Discussion:
Steps to Reproduce: to a git repository in VS Code a change to a file the SCM viewlet and notice that the Open Changes command is disabled <img width="456" alt="image" src="https://user-"
Change:
@IUriIdentityService uriIdentityService: IUriIdentityService ) { super(_resource, _id, _index, _query, _parent, _searchModel, _closestRoot, replaceService, instantiationService, labelService, uriIdentityService); <ins> this._normalizedResource = new Lazy(() => this.uriIdentityService.extUri.removeTrailingPathSeparator(this.uriIdentityService.extUri.normalizePath( this.resource))); </ins> } override get resource(): URI { return this._resource!; } <ins> get normalizedResource(): URI { return this._normalizedResource.value; } </ins> } /**

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.78.2 OS Version: Windows 11 22H2 (.1778) Steps to Reproduce: ! a WSL folder from the command line with the argument --remote, with a trailing forward slash. Example: to search all files for any search term. The files will not appear. ! a WSL folder from the command line with the argument --remote, without a trailing forward slash. Example: to search all files for any search term. The files will appear. !
Change:
resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.8.0.tgz#4bc6bb4dbfea5b0d2d7978d6c5cef922d584fb4f" integrity sha512-dlpYPsv0C9S6v6+T/h/d/otSbdUTizMJdxvSoS34tUpMOHev6iW7Zqt5KRFqYxl4vCqpDk9Wmhb3fKL3kwX5fQ== <del> xterm@4.9.0-beta.8: version "4.9.0-beta.8" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.8.tgz#ca121934d63f88668d2d5b11d9b2fc3bde7bd805" integrity sha512-EEonYBLANDUBfEeEnHG632bZdgBaAUWst8LFr6oC6f2uLFfJGHQvVJuLaEkPtRvS+jOeoorEXZRPmso1/ANHXA== </del> <ins> xterm@4.9.0-beta.24: version "4.9.0-beta.24" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.24.tgz#48f0990c6d32ad3a9bcc4fb49531d7effdaccea5" integrity sha512-CIVxxxbBiSw1WOMkIjjivaiIC9jNgih4klfWsRGx0qiDF5nbzHuLXkPTt+yAQUu9FCyTUwECm9Pkl3gUsSaGKg== </ins>

Discussion:
Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:
Change:
getVariableMap(scope: EnvironmentVariableScope | undefined): Map<string, IExtensionOwnedEnvironmentVariableMutator[]> { const result = new Map<string, IExtensionOwnedEnvironmentVariableMutator[]>(); <del> this.map.forEach((mutators, _key) => { </del> <ins> for (const mutators of this.map.values()) { </ins> const filteredMutators = mutators.filter(m => filterScope(m, scope)); if (filteredMutators.length > 0) { // All of these mutators are for the same variable because they are in the same scope, hence choose anyone to form a key. result.set(filteredMutators[0].variable, filteredMutators); } <del> }); </del> <ins> } </ins> return result; } getDescriptionMap(scope: EnvironmentVariableScope | undefined): Map<string, string | undefined> { const result = new Map<string, string | undefined>(); <del> this.descriptionMap.forEach((mutators, _key) => { </del> <ins> for (const mutators of this.descriptionMap.values()) { </ins> const filteredMutators = mutators.filter(m => filterScope(m, scope, true)); <del> if (filteredMutators.length > 0) { // There should be exactly one description per extension per scope. result.set(filteredMutators[0].extensionIdentifier, filteredMutators[0].description); </del> <ins> for (const mutator of filteredMutators) { result.set(mutator.extensionIdentifier, mutator.description); </ins> } <del> }); </del> <ins> } </ins> return result; }

Discussion:
This is the reason js-debug isn't working but git is: This is probably a good candidate for recovery, not a good reason to push 1.80.0 out though.
Fixed in main
Thanks for taking care of it while I was out! Can this be closed?
this one's going into the recovery build, didn't quite make the cut for 1.80.0.
verified that JavaScript debug terminals are getting the expected env - can you pls lmk what the repro steps were here?
You can add the following setting to activate description for Python ext: in User settings and reload. After which, if you select a virtual environment (Python: Select Interpreter), it should use env collection to activate terminal with appropriate description, something like: ! Description is the "Enable Nodejs..." string next to "Javascript debugger:", it appears when hovering over the terminal label.
!
Seems to work
The actual verify steps for this is to ensure 2 list items appear in the same section. Verified below. Insiders: ! Stable: !
Change:
documentation?: string; } <del> function testHtmlCompletionProvider(contents: string, expectedItems: TestCompletionItem[]): Thenable<any> { </del> <ins> function testCompletionProvider(fileExtension: string, contents: string, expectedItems: TestCompletionItem[] | undefined): Thenable<boolean> { </ins> const cursorPos = contents.indexOf('|'); <del> const htmlContents = contents.slice(0, cursorPos) + contents.slice(cursorPos + 1); </del> <ins> const slicedContents = contents.slice(0, cursorPos) + contents.slice(cursorPos + 1); </ins> <del> return withRandomFileEditor(htmlContents, 'html', async (editor, _doc) => { </del> <ins> return withRandomFileEditor(slicedContents, fileExtension, async (editor, _doc) => { </ins> const selection = new Selection(editor.document.positionAt(cursorPos), editor.document.positionAt(cursorPos)); editor.selection = selection; const cancelSrc = new CancellationTokenSource();

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (disabling Emmet) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: - 1.62.3 OS Version: - Ubuntu 21.10 Steps to Reproduce: a .js file which is denoted a React file by VSCode part of the coding implement state for a counter with the following simple line: getting as far as typing I wish to just exit the square brackets however Emmet takes the first position tab results in an HTML string appearing, see pictures Question: How do I move Emmet down the list of suggestions in Autocomplete for a React file, I am using other extensions like TabOut (to get out of the square brackets without any autocomplete) which would be more appropriate. ! ! ! !
This issue heavily affect the react users.
Verification steps: a JSX file. . should not be an Emmet suggestion.
/verified
Change:
EditorOption.ariaLabel, 'ariaLabel', nls.localize('editorViewAccessibleLabel', "Editor content") )), screenReaderAnnounceInlineSuggestion: register(new EditorBooleanOption( <del> EditorOption.screenReaderAnnounceInlineSuggestion, 'screenReaderAnnounceInlineSuggestion', false, </del> <ins> EditorOption.screenReaderAnnounceInlineSuggestion, 'screenReaderAnnounceInlineSuggestion', true, </ins> { description: nls.localize('screenReaderAnnounceInlineSuggestion', "Control whether inline suggestions are announced by a screen reader."), tags: ['accessibility']

Discussion:
Type: <bFeature Request</bDepending on the extension we are using, when code suggestion information appears, it is not read by screen readers. Steps to reproduce. Install the codeium extension. Open any project, and start typing or commenting the code; You will hear a sound when a hint appears, but this hint is not read by screen readers like nvda. I suggest that it is possible to activate a configuration in vscode, so that this type of information can be transmitted to screen readers. VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-20T01:18:53.811Z) OS version: Windows_NT x64 10.0. Modes: Remote OS version: Linux x64 5.15.90.1-microsoft-standard-WSL2 <!-- generated by issue reporter --
I can reproduce. We must not be getting the line content here
I would like to inform you that I also tested it with the copilot and when listening to the sound that a suggestion was given, the screen readers also do not read.
You need to set to and it will work for copilot
do you think we should now set that to by default?
Nice defined it and it actually worked for the copilot. My suggestion is that it would not be possible for these settings to go to the accessibility feature? I know that it makes sense to stay where they are because it has to do with the editor, but they are difficult to find, or maybe we have some dock where all the accessibility features are and their respective paths where they should be activated, you get the idea.
Yes, we actually have help menus now for the copilot chat view / interactive editor session. When you focus those inputs, using reveals/focuses the help menu for each. I think for this case, we should enable inline suggestion by default
Sorry, just found out that by enabling the setting, it also worked for codeium. Should I then close this issue?
I think we should enable this by default, so will use this issue to track that
I agree with the idea setting the inline suggestion announcement to TRUE by default as it is now stable.
Verified the setting default is flipped
Change:
"command.stageAll": "Stage All Changes", "command.stageAllTracked": "Stage All Tracked Changes", "command.stageAllUntracked": "Stage All Untracked Changes", <ins> "command.stageAllMerge": "Stage All Merge Changes", </ins> "command.stageSelectedRanges": "Stage Selected Ranges", "command.revertSelectedRanges": "Revert Selected Ranges", "command.stageChange": "Stage Change",

Discussion:
Issue Type: <bBug</bDuring a rebase (not sure if that's the only scenario), my SOURCE CONTROL tab display three sections, MERGE CHANGES, STAGED CHANGES and CHANGES. If I click the + button on the CHANGES section, in order to stage all items below CHANGES, VS Code also adds everything on MERGE CHANGES. VS Code version: Code - Insiders 1.45.0-insider (, 2020-04-29T05:33:59.143Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ markdown-mermaid1.5.0 better-toml0.3.2 vscode-eslint2.1.5 gitlens10.2.1 plantuml2.13.8 svg1.1.8 vscode-peacock3.7.0 chat0.33.0 rust-analyzer0.2.151 vscode-todo-parser1.9.1 remote-wsl0.44.2 vsliveshare1.0.2104 vsliveshare-audio0.1.85 vsliveshare-pack0.3.4 vscode-xml0.11.0 vscode-yaml0.7.2 crates0.4.9 vscode-hexdump1.7.2 markdown-all-in-one2.8.0 </details<!-- generated by issue reporter --
Hello I would like to work on this issue if no one else is. Regards.
hey could you please review the pr that I have opened and also could you please suggest any changes if required.
Hi I'm also working on this issue. You can check my PR
I have gone through your PR also left a comment.