jiebi/CodeConvo huggingface dataset:
Change:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService'; import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; <ins> import { IProductService } from 'vs/platform/product/common/productService'; </ins> import { ITerminalSimpleLink, TerminalBuiltinLinkType } from 'vs/workbench/contrib/terminal/browser/links/links'; import { TerminalWordLinkDetector } from 'vs/workbench/contrib/terminal/browser/links/terminalWordLinkDetector'; import { assertLinkHelper } from 'vs/workbench/contrib/terminal/test/browser/links/linkTestUtils'; <ins> import { TestProductService } from 'vs/workbench/test/common/workbenchTestServices'; </ins> import { Terminal } from 'xterm'; suite('Workbench - TerminalWordLinkDetector', () => {

Discussion:
Type: <bBug</bContext I want to use vscode-URLs to directly drop into a debugging session. My script can be found at Expected behavior When cmd-clicking this link from inside VSCode, I would expect to be dropped into the debugging session <img width="1287" alt="Screenshot 2022-08-22 at 10 25 59" src="https://user-"Actual behavior Instead, the link gets opened in VS Code's search bar <img width="904" alt="Screenshot 2022-08-22 at 10 27 17" src="https://user-"Additional information I am sure the link itself is fine, because when I copy it from the console and paste it into Chrome's address bar, then VSCode opens my debugging session as expected. Also see VS Code version: Code 1.70.2 (, 2022-08-16T05:36:37.829Z) OS version: Darwin x64 21.6.0 Modes: Remote OS version: Linux x64 5.15.0-30-generic Remote OS version: Linux x64 5.15.0-30-generic <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ better-cpp-syntax1.15.19 jupyter-keymap1.0.0 remote-ssh0.84.0 remote-ssh-edit0.80.0 llvm0.1.1 vscode-clangd0.1.21 vscode-lldb1.7.4 </details<!-- generated by issue reporter --
since the url would need to open a JS/browser debug session, would the JavaScript Debugger Companion Extension be of help here?
This is debugging with lldb, so it's not in the domain of js-debug
This is a request to essentially hook up the terminal link detector to whatever handles external custom protocol links. We may be able to just add vscode:// and vscode-insiders:// to the uri detection? This may need changes in the editor's link detector
Change:
} override get capabilities(): EditorInputCapabilities { <del> return EditorInputCapabilities.Readonly | EditorInputCapabilities.Singleton | EditorInputCapabilities.CanDropIntoEditor; </del> <ins> return EditorInputCapabilities.Readonly | EditorInputCapabilities.Singleton | EditorInputCapabilities.CanDropIntoEditor | EditorInputCapabilities.ForceDescription; </ins> } setTerminalInstance(instance: ITerminalInstance): void {

Discussion:
This new capability allows the terminal to control when the tab description shows, so we can align the description in the terminal editor with how it shows up in a terminal panel tab.
To verify: Run a task, move the terminal to the editor area, check that the description shows up like it did in the panel In a terminal, change the directory, verify you see it in the tab description in the panel Move that to the terminal editor, make sure you see it there as well
Is this tooltip the task description? <img width="486" alt="image" src=""I think I'm a bit confused on how a task would be affected by a different terminal changing directories.
drag the terminal into the editor area and you should still see in the label of the tab.
Change:
if (element && this.tree.hasNode(element)) { // Refresh specific repository <del> await this.tree.updateChildren(element, true, false, { diffDepth: Infinity, diffIdentityProvider: this.treeIdentityProvider }); </del> <ins> await this.tree.updateChildren(element); </ins> } else { // Refresh the entire tree <del> await this.tree.updateChildren(undefined, true, false, { diffDepth: Infinity, diffIdentityProvider: this.treeIdentityProvider }); </del> <ins> await this.tree.updateChildren(undefined); </ins> } if (focusedInput) {

Discussion:
Steps to Reproduce: a folder/workspace that contains a git repository change to a file "Commit & Push" from the action button Actual command not found Commit from the action button Actual command not found
Change:
private _getAdditionalWidth(instance: ITerminalInstance): number { // Size to include padding, icon, status icon (if any), split annotation (if any), + a little more const additionalWidth = 40; <del> const statusIconWidth = instance.statusList.statuses.length > 0 ? STATUS_ICON_WIDTH : 0; const splitAnnotationWidth = (this._terminalGroupService.getGroupForInstance(instance)?.terminalInstances.length || 0) > 1 ? SPLIT_ANNOTATION_WIDTH : 0; </del> <ins> const statusIconWidth = instance.statusList.statuses.length > 0 ? WidthConstants.StatusIcon : 0; const splitAnnotationWidth = (this._terminalGroupService.getGroupForInstance(instance)?.terminalInstances.length || 0) > 1 ? WidthConstants.SplitAnnotation : 0; </ins> return additionalWidth + splitAnnotationWidth + statusIconWidth; }

Discussion:
Testing !
We'll need to repro on mac and look at the sequences to verify whether this is an issue or we're going the right thing.
I think this is working as designed since it's just padding on the top, however we could check the location of the terminal view and if it's on either side, top align the terminal instead of bottom aligning it.
Change:
private readonly myersDiffingAlgorithm = new MyersDiffAlgorithm(); computeDiff(originalLines: string[], modifiedLines: string[], options: ILinesDiffComputerOptions): LinesDiff { <ins> if (originalLines.length <= 1 && equals(originalLines, modifiedLines, (a, b) => a === b)) { return new LinesDiff([], [], false); } </ins> if (originalLines.length === 1 && originalLines[0].length === 0 || modifiedLines.length === 1 && modifiedLines[0].length === 0) { <del> return { changes: [ new LineRangeMapping( new LineRange(1, originalLines.length + 1), new LineRange(1, modifiedLines.length + 1), [ new RangeMapping( new Range(1, 1, originalLines.length, originalLines[0].length + 1), new Range(1, 1, modifiedLines.length, modifiedLines[0].length + 1) ) ] ) ], hitTimeout: false, moves: [], }; </del> <ins> return new LinesDiff([ new LineRangeMapping( new LineRange(1, originalLines.length + 1), new LineRange(1, modifiedLines.length + 1), [ new RangeMapping( new Range(1, 1, originalLines.length, originalLines[0].length + 1), new Range(1, 1, modifiedLines.length, modifiedLines[0].length + 1) ) ] ) ], [], false); </ins> } const timeout = options.maxComputationTimeMs === 0 ? InfiniteTimeout.instance : new DateTimeout(options.maxComputationTimeMs);

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.80.1 OS Version: macOS 13.4.1 Steps to Reproduce: two empty file the diff view shows "removed" and "" lines This issue is the same as but happens again
Can you share a screenshot?
An empty file compare to itself <img width="1033" alt="image" src=""
I see, thanks!
To verify: Select latest dev version and notice there is no red/green in this .
The issue is verified. I am wondering if we want to see the commands starting with when there is no active file? I see this command while I have no active text editor.
Change:
} }); <del> // Only one button, close quickPick.onDidTriggerButton(() => { quickPick.hide(); </del> <ins> quickPick.onDidTriggerButton((button) => { if (button === closeButton) { quickPick.hide(); } else if (button === resetButton) { const resetSetting = (id: string) => { const config = configurationService.inspect(id); configurationService.updateValue(id, config.defaultValue); }; // Reset all layout options resetSetting('workbench.activityBar.visible'); resetSetting('workbench.sideBar.location'); resetSetting('workbench.statusBar.visible'); resetSetting('workbench.panel.defaultLocation'); if (!isMacintosh || !isNative) { resetSetting('window.menuBarVisibility'); } commandService.executeCommand('workbench.action.alignPanelCenter'); } </ins> }); quickPick.onDidHide(() => {

Discussion:
Testing While experimenting with the 'customize layout' control, I switched my panel alignment but then wasn't sure what to reset it back to Can we add a indicator that tells users what the default alignment is?
I suppose this feedback should be applied to the other options as well. it isn't the only item with a default value, but I am also a little hesitant as it makes the experience somewhat noisy and the user can select whatever option they like the most. thoughts?
This was the only option that was confusing to me but I can see just adding a default label to one section would be a little weird Another option is to add a entry inside that resets the entire layout. That is pretty much what I was wanted after experimenting with these options
I think reset is quite interesting, I will update this as a feature request for that
To verify: the "Customize Layout" action the layout the reset icon in the top right of the quick pick From the code, here is the list of stuff that I expect to be reset:
Change:
suite('Editor Model - Words', () => { <del> var thisModel: TextModel; </del> <ins> const OUTER_LANGUAGE_ID = new LanguageIdentifier('outerMode', 3); const INNER_LANGUAGE_ID = new LanguageIdentifier('innerMode', 4); class OuterMode extends MockMode { constructor() { super(OUTER_LANGUAGE_ID); this._register(LanguageConfigurationRegistry.register(this.getLanguageIdentifier(), {})); this._register(TokenizationRegistry.register(this.getLanguageIdentifier().language, { getInitialState: (): IState => NULL_STATE, tokenize: undefined, tokenize2: (line: string, state: IState): TokenizationResult2 => { const tokensArr: number[] = []; let prevLanguageId: LanguageIdentifier = undefined; for (let i = 0; i < line.length; i++) { const languageId = (line.charAt(i) === 'x' ? INNER_LANGUAGE_ID : OUTER_LANGUAGE_ID); if (prevLanguageId !== languageId) { tokensArr.push(i); tokensArr.push((languageId.id << MetadataConsts.LANGUAGEID_OFFSET)); } prevLanguageId = languageId; } const tokens = new Uint32Array(tokensArr.length); for (let i = 0; i < tokens.length; i++) { tokens[i] = tokensArr[i]; } return new TokenizationResult2(tokens, state); } })); } } class InnerMode extends MockMode { constructor() { super(INNER_LANGUAGE_ID); this._register(LanguageConfigurationRegistry.register(this.getLanguageIdentifier(), {})); } } let disposables: Disposable[] = []; </ins> setup(() => { <del> var text = ['This text has some  words. ']; thisModel = TextModel.createFromString(text.join('n')); </del> <ins> disposables = []; </ins> }); teardown(() => { <del> thisModel.dispose(); </del> <ins> dispose(disposables); disposables = []; </ins> }); test('Get word at position', () => { <ins> const text = ['This text has some  words. ']; const thisModel = TextModel.createFromString(text.join('n')); disposables.push(thisModel); </ins> assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 1)), { word: 'This', startColumn: 1, endColumn: 5 }); assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 2)), { word: 'This', startColumn: 1, endColumn: 5 }); assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 4)), { word: 'This', startColumn: 1, endColumn: 5 });

Discussion:
VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.
For the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns
Any update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.
Have the same problem, but wonder about: "... autocomplete options for props ...". Is VS Code capable to autocomplete my custom from an imported component?
Change:
*/ snippetSuggestions?: 'top' | 'bottom' | 'inline' | 'none'; /** <ins> * Copying without a selection copies the current line. */ emptySelectionClipboard?: boolean; /** </ins> * Enable tab completion. Defaults to 'false' */ tabCompletion?: boolean;

Discussion:
Like the title says, when nothing is selected, copying shouldn't copy a blank character.
As of now, cmd+c without any selection, copies the entire line. Sublime also does the same. Are we suggesting to change this behavior as part of this issue? I really like the current functionality. Or are we suggesting one more option/flag which user can enable to have the new functionality?
Yes, it would be behind an option
Can we have the option for this behavior or disable it? I don't like the auto copy of a blank line and would like to disable that feature. I agree it can be annoying especially in the type of coding I do (debugging).
Was a setting for this?
it is
disables the line copying entirely. Is there a way to have line copying enabled, while simultaneously ignoring the empty lines?
This doesn't disable the copying within my VS Code at all and I can still copy whitespace - anyone else had any luck? fingers crossed
Change:
import * as fs from 'fs'; import * as path from 'path'; <del> import { CancellationToken, Command, Disposable, Event, EventEmitter, Memento, OutputChannel, ProgressLocation, ProgressOptions, scm, SourceControl, SourceControlInputBox, SourceControlInputBoxValidation, SourceControlInputBoxValidationType, SourceControlResourceDecorations, SourceControlResourceGroup, SourceControlResourceState, ThemeColor, Uri, window, workspace, WorkspaceEdit, FileDecoration } from 'vscode'; </del> <ins> import { CancellationToken, Command, Disposable, Event, EventEmitter, Memento, OutputChannel, ProgressLocation, ProgressOptions, scm, SourceControl, SourceControlInputBox, SourceControlInputBoxValidation, SourceControlInputBoxValidationType, SourceControlResourceDecorations, SourceControlResourceGroup, SourceControlResourceState, ThemeColor, Uri, window, workspace, WorkspaceEdit, FileDecoration, commands } from 'vscode'; </ins> import * as nls from 'vscode-nls'; import { Branch, Change, GitErrorCodes, LogOptions, Ref, RefType, Remote, Status, CommitOptions, BranchQuery } from './api/git'; import { AutoFetcher } from './autofetch';

Discussion:
Testing Currently the command is always in the command palette. I would expect it to appear only when I am in the middle of a rebase. Not sure if we could introduce some context keys which would be true when we are in the middle of the rebase. And then use those context keys as part of the commands clause
Since triggering it outside of a rebase produces this expected error. Do we polish the message, since it looks a bit strange with the double !
Verification steps: Launch VS Code and close existing folder if needed Verify that command is not available in the command palette Open a Git repository Verify that command is not available in the command palette Switch to the SCM viewlet, and click on --- Verify that an information notification is displayed noting that there is no rebase in progress Use the steps from to rebase a topic branch on top of the main branch Verify that command is available in the command palette Invoke the command from the command palette Verify that command is available in the command palette
Change:
import { createActionViewItem, createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { IAction } from 'vs/base/common/actions'; import { EditorExtensionsRegistry } from 'vs/editor/browser/editorExtensions'; <ins> import { ParameterHintsController } from 'vs/editor/contrib/parameterHints/browser/parameterHints'; </ins> import { MenuPreventer } from 'vs/workbench/contrib/codeEditor/browser/menuPreventer'; import { SelectionClipboardContributionID } from 'vs/workbench/contrib/codeEditor/browser/selectionClipboard'; import { ContextMenuController } from 'vs/editor/contrib/contextmenu/browser/contextmenu';

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.78.2 Commit: Date: 2023-05-10T14:39:26.248Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.78.2 Chrome/108.0.5359.215 Electron/22.5.2 Safari/537.36 Steps to Reproduce: Jupyter extension a dummy extension and install it: Interactive Window shows up shows up signature help works on new files though, just not in the interactive.
Change:
"meta.embedded.block.javascript": "javascript", "meta.embedded.block.json": "json", "meta.embedded.block.jsonc": "jsonc", <ins> "meta.embedded.block.latex": "latex", </ins> "meta.embedded.block.less": "less", "meta.embedded.block.objc": "objc", "meta.embedded.block.scss": "scss",

Discussion:
This problem still occurs even if you disable all extensions and occurs in both stable and insider. Create the following Fenced code blocks for LaTeX in Markdown file. latex documentclass{article} begin{document} Hello, LaTeX{}!! end{document} Then run (&lt;kbdCtrl+/&lt;/kbd) on the line with . You will get the following results: latex documentclass{article} begin{document} &lt;!-- Hello, LaTeX{}!! --end{document} The correct result is: latex documentclass{article} begin{document} % Hello, LaTeX{}!! end{document} ` Execute repeatedly !
Hi Did you save the file? I disabled all my extensions for vscode insider and can't reproduce this issue. Is this still happening for you?
Yes. And all extensions are disabled. Yes. The insider was updated to the following versions because has been available for updating. However, the problem continues to be reproduced.
Sorry I was saving file as latex extension so it worked. I tried with markdown and it doesn't work for me too. This is a verified bug now.
Hi, I'm having the same issue. I'm new to the codebase. Can I try to solve this issue?
I had previously submitted similar issue. It may help to solve this issue. See
thanks for this, It will help me solve this issue. I am working on this.
Hey I made the PR. Could you please check it?
Change:
quickSuggestions: false, renderWhitespace: 'none', dropIntoEditor: { enabled: true }, <del> readOnly: true </del> <ins> readOnly: true, ariaLabel: localize('terminalAccessibleBuffer', "Terminal Buffer") </ins> }; this._editorWidget = this.add(this._instantiationService.createInstance(CodeEditorWidget, this._editorContainer, editorOptions, codeEditorWidgetOptions)); this._element.replaceChildren(this._editorContainer);

Discussion:
Type: <bBug</bTerminal buffer does not have aria label and currently being read as "Editor content edit" to screen readers. Please add aria-label, such as "terminal buffer." VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-04T05:35:09.023Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (91)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 dscodegpt2.1.15 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.20.0 gitlens14.2.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.14.14 copilot1.100.313 copilot-chat0.7. remotehub0.60.0 vscode-github-actions0.26.1 vscode-pull-request-github0.70.0 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.4 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.14.0 vscode-pylance2023.8.10 jupyter2023.7.

jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.81.0 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.8.417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.91.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 chatgpt1.1.2 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.53.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.13 vscode-java-test0.39.1 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Change:
icon: Codicon.debugStop, }, undefined, undefined, undefined, contextKeyService, commandService); <ins> this._ctxActionCount = SCMInputContextKeys.ActionCount.bindTo(contextKeyService); </ins> const updateToolbar = () => { const actions: IAction[] = []; createAndFillInActionBarActions(menu, options?.menuOptions, actions);

Discussion:
<img width="419" alt="image" src=""
While the SCM view is refreshing itself, I still sometimes see the sparkle move outside of the input box, then back in on the next layout
could you verify this again? With the latest Insiders the sparkle should not appear outside the input box.
LGTM now, thank you for the fix!