jiebi/CodeConvo huggingface dataset:
Change:
$trySetDecorations(id: string, key: string, ranges: IDecorationOptions[]): TPromise<any> { if (!this._documentsAndEditors.getEditor(id)) { <del> return TPromise.wrapError(new Error('TextEditor disposed')); </del> <ins> return TPromise.as(null); </ins> } this._documentsAndEditors.getEditor(id).setDecorations(key, ranges); return TPromise.as(null);

Discussion:
Our tests and also often the dev console are full of these errors: I see no value in showing this error other than making it hard to read the test results to find an actual problem. This one seems to be ignored for many releases now so I suggest to remove it. E.g.: ! via https://travis-
This is the merge decorator, add to
It's incredibly hard to read travis logs right now.
There is a check if the editor is in , but that doesn't seem to help. What is the correct way to check if the editor is not disposed?
Using shows that is still false when passing through . This seems to be a timing issue between extension host and main process.
extHostTextEditor already logs a warning in runOnProxy() when the editor is disposed at the time setDecorations() is called. If the editor in the extension host is not disposed, but the one in the renderer process is (and the error is logged), the disposal and the setting of decorations were triggered at a similar time in different processes and it seems best to recover from this silently. I suggest to remove the error. If an error is still desired, I'd suggest to change the warning in extHostTextEditor's runOnProxy() to an error.
could you please look into this since all other participants are on vacation? Or assign it to august if it is not critical for our relase
I don't see it as critical for the release. It is log entries for operations that should not run and also are not run. This is without further side-effects. labelled it as important with regard to the noise in the test runs. I'll postpone it to August if there are no objections.
Nice fix, not. The problem is explained here:
This seems to be a race condition on the API's side. See .
That might well be but the "fix" of this picking this one call is a little lame, isn't it? If we understand this problem why don't we tackle it for all other calls like etc. Why don't we handle this properly in the with a well known error code? This just looks like a shortcut to me
We wanted to make progress on this "important" issue in your absence without devising a general solution without your input.
I understand that, but I would have just removed the "important" label because this is really just debt
Change:
const enum ShellType { cmd, powershell, bash } <del> export function prepareCommand(shell: string, args: string[], argsCanBeInterpretedByShell: boolean, cwd?: string): string { </del> <ins> export function prepareCommand(shell: string, args: string[], argsCanBeInterpretedByShell: boolean, cwd?: string, env?: { [key: string]: string | null }): string { </ins> shell = shell.trim().toLowerCase();

Discussion:
See The change that caused this was a standalone fix for a relatively minor bug, so I will back it out for now.
I'm able to debug a JS file on macOS now with nvm and a launch configuration that contains .
Just a FYI - I don't use nvm but experienced this issue. The recent update fixed it for me, thanks!!
Change:
const templateProperties: ITerminalLabelTemplateProperties = { cwd: instance.cwd || instance.initialCwd || '', cwdFolder: '', <ins> workspaceFolderName: instance.workspaceFolder?.name, </ins> workspaceFolder: instance.workspaceFolder ? path.basename(instance.workspaceFolder.uri.fsPath) : undefined, local: type === 'Local' ? terminalStrings.typeLocal : undefined, process: instance.processName,

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I usually give a meaningful name to my folders in the workspace config file, like this: It would be very useful if the integrated terminal title could show this name instead of the folder name. Currently these variables can be used in the property: ${cwd} ${cwdFolder} ${workspaceFolder} ${local} ${process} ${separator} ${sequence} ${task} The refers to the property of the folder. There could be a new variable, or something like that. Thank you in advance! Keep up the good work!
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
If this just needs to point at it should be trivial to add:
Is this still in the backlog for a future release? It would be very useful for accessibility platforms like talon voice where we rely on parsing context information out of the window title.
Change:
{ "command": "github.copyVscodeDevLink", "when": "false" <ins> }, { "command": "github.copyVscodeDevLinkFile", "when": "false" </ins> } ], "file/share": [ { <del> "command": "github.copyVscodeDevLink", </del> <ins> "command": "github.copyVscodeDevLinkFile", </ins> "when": "github.hasGitHubRepo" } ],

Discussion:
Testing Of course, there may have been discussions and reasons for the current behavior, but I was surprised that the share action in the File menu linked to the line number of the currently opened editor. I was expecting a link to the workspace/repository only.
would you expect the same command from the editor context menu to use file+line number?
yes, my expectation would be the context menu has the "context" and therefore does have the file/line associated with it.
Change:
font-size: 14px; } <del> .extension-editor > .header.recommended, .extension-editor > .header.recommendation-ignored { height: 146px; } </del> .extension-editor > .header > .icon { height: 128px; width: 128px;

Discussion:
Testing In a zoomed in view <img width="1053" alt="screen shot 2018-06-26 at 11 35 55 am" src="https://user-"
The Ignore button is missing top and bottom padding of 1 px, which you can see on the button <img width="904" alt="screen shot 2018-06-26 at 11 39 29 am" src="https://user-"
Change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { asArray } from 'vs/base/common/arrays'; </ins> import * as Async from 'vs/base/common/async'; import { IStringDictionary } from 'vs/base/common/collections'; import { Emitter, Event } from 'vs/base/common/event';

Discussion:
Type: <bBug</b"" on VS Code this task and save: this task ([Terminal] [Run Task] [Throw my error]) Enter The integrated terminal shows an error because of . Pressing Enter closes it because of .The integrated terminal shows an error because of . Pressing Enter inserts a line break into the current opened "", or at least leaves the terminal open. Terminal display: I use Git Bash of Git for Windows as my default terminal (), but I've tried and PowerShell and got the same result. Of cause, if the command is , the terminal doesn't appear because of . "Reload With Extensions Disabled" has no effect. TBH, I know this is a duplicate of . It has already been closed as a "feature-request" that didn't receive enough upvotes. It may be impolite to reopen a closed issue in this way, and I'm very hesitant to do so, but for the life of me, I can't believe that fixing this counter-intuitive behavior is within the scope of feature requests. The current behavior is surprising, not convincing. I'm sorry if there are already other ways to achieve the expected behavior. VS Code version: Code 1.79.2 (, 2023-06-14T08:57:04.379Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ Bookmarks13.3.1 project-manager12.7.0 laravel-extra-intellisense0.6.3 markdown-preview-github-styles2.0.2 insert-unicode0.14.0 laravel-blade1.1.2 vscode-eslint2.4.0 vscode-deno3.19.1 EditorConfig0.16.4 gc-excelviewer4.2.57 code-eol1.0.12 haml1.4.1 live-stylus-compiler0.0.4 zenkaku0.0.3 vscode-language-pack-ja1.79.

remote-containers0.295.0 live-server0.4.8 laravel-blade1.34.0 laravel5-snippets1.17.0 LiveServer5.7.9 language-stylus1.16.0 vscode-input-sequence0.2.0 markdown-all-in-one3.5.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
So you mean it isn't a bug? The "focus" option doesn't make focus. Is this intended behavior?
You're right - it is a bug
I'll fix that
Change:
import * as Proto from '../protocol'; import * as PConst from '../protocol.const'; <del> import { TypeScriptBaseCodeLensProvider, ReferencesCodeLens } from './baseCodeLensProvider'; </del> <ins> import { TypeScriptBaseCodeLensProvider, ReferencesCodeLens, CachedNavTreeResponse } from './baseCodeLensProvider'; </ins> import { ITypeScriptServiceClient } from '../typescriptService'; import { tsTextSpanToVsRange, vsPositionToTsFileLocation } from '../utils/convert';

Discussion:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.
Change:
position: { lineNumber: effectiveLineNumber, column: effectiveColumnNumber }, preference: LightBulbWidget._posPref }); <del> this.renderGutterLightbub(); return this.hide(); </del> <ins> if (hasDecoration) { this.gutterHide(); } else { this.renderGutterLightbub(); return this.hide(); } </ins> } else if ((lineNumber < model.getLineCount()) && !isFolded(lineNumber + 1)) { effectiveLineNumber += 1; } else if (column * fontInfo.spaceWidth < 22) {

Discussion:
This was unexpected for me where I open a file (not focus the editor) and the light bulb shows up randomly depending on where the cursor happened to have been restored: !
cc
Change:
this._saneDetail = value; } <del> protected _saneTooltip?: string | IMarkdownString | HTMLElement; </del> <ins> private _saneTooltip?: string | IMarkdownString | HTMLElement; </ins> get saneTooltip() { return this._saneTooltip; }

Discussion:
So that we can add full path to Quick Search
Verification: Open from the command palette search for something Notice the folder paths next to the names of the files - that's the description! <img width="623" alt="image" src=""
Change:
neverShowAgain: { id: SHOULD_PROMPT_FOR_PROFILE_MIGRATION_KEY, scope: NeverShowAgainScope.WORKSPACE } } ); <del> this.messageShown = true; </del> <ins> migrationMessageShown = true; </ins> } }

Discussion:
<img width="470" alt="Screen Shot 2021-05-28 at 11 40 58 AM" src="https://user-"This is my only shell/profile setting:
It should also show only once per window reload
Fixed already /duplicate of
Not sure how to get it to only show once per window reload. Custom implementation?
keep a boolean like at the top level of the file to track it.
This still happens because needs to be at the top level, not a member of TerminalInstance in order to be shared.
If we only do this for the first terminal that gets created though, if users change their settings and then create terminals, they won't see this message.
Just tested it and think that's fine
that's fine, they'd eventually hit it again after a restart. The main thing is that we're annoying people as little as possible.
Tried to verify, think this is still unreleased.
I think it should be released already since Alex Dima released a few hours ago an insider's based on release/1.57, which has the changes.
Works after updating
Change:
const FOCUSED_STACK_FRAME_MARGIN: IModelDecorationOptions = { description: 'focused-stack-frame-margin', glyphMarginClassName: ThemeIcon.asClassName(debugStackframeFocused), <ins> glyphMargin: { position: GlyphMarginLane.Right }, zIndex: 9999, </ins> stickiness, overviewRuler: { position: OverviewRulerLane.Full,

Discussion:
<img width="288" alt="image" src="https://user-"This leads to the editor shifting to the right every time I pause, because it's adding an editor gutter. We actually already have a combo decoration that shows the two things together. I don't actually know exactly how that works but can look it up if you need it. Actually this combo decoration doesn't exist for all breakpoint types, which is annoying, but that's an issue for me
If you have a code pointer that would be awesome, I wasn't aware we had a notion of combined decorations today. As far as I know in the past we merged the classnames for any decorations that wanted to appear in the glyph margin
So when I see this <img width="76" alt="image" src="https://user-"there is a and an , that is where the different colors come from I think the comes from the normal decoration, then we set the content here and color here It seems like we are hacking editor decorations with css a bit
Maybe the solution is just making sure that whatever logic puts breakpoints in their own lane applies to all debug decorations though, so these all get their own lane and its the same, if that makes sense
The actual stackframe decorations come from here
The trouble is now we also have this notion of a to ensure e.g. that testing decorations always render atop other decorations, so if there are multiple decorations in the same lane we pick the first one and discard the rest. To show those decorations together, I think I have to restore the old behavior so that decorations with the same get the classnames combined like in the previous stable. But as you said that only works because of some CSS hackery, maybe we also want a more formalized way to combine decorations.
Change:
if (category.isFeatured) { reset(featuredBadge, $('.featured', {}, $('span.featured-icon.codicon.codicon-star-empty'))); <del> reset(descriptionContent, category.description); </del> <ins> reset(descriptionContent, ...renderLabelWithIcons(category.description)); </ins> } return $('button.getting-started-category' + (category.isFeatured ? '.featured' : ''),

Discussion:
This is a bug in the . In general, the extension API allows icons to be embedded in text by referencing them inside of . This functionality does not work consistently in the walkthroughs API. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A; this is a bug in the extension API VS Code Version: 1.69 OS Version: macOS 12.4 Steps to Reproduce: a walkthrough step in your extension, e.g. "walkthroughs": [ { "id": "welcome", "title": "Example $(github)", "description": "See? The icon looks nice, doesn't it?", "steps": [ { "id": "example-step", "title": "Example step", "description": "Example description", "media": { "image": "", "altText": "" } } ] } ] 2 Observe that the icon in the title ( in the example above) renders correctly in the Open Walkthrough… quickpick list: <img width="372" alt="Screen Shot 2022-07-12 at 10 21 08 AM" src="https://user-"up the walkthrough and observe that the icon is not rendered, and instead you see the literal string : <img width="508" alt="Screen Shot 2022-07-12 at 10 22 09 AM" src="https://user-"
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Yes, it still exists in 1.69.1.
Thanks for the remarkably fast turnaround time, appreciate you.

Still see this in Version: 1.70.0-insider (user setup) Commit: Date: 2022-07-27T05:16:37.759Z OS: Windows_NT x64 10.0. ! ! ! generate a new TypeScript extension with add the snippet from the issue description to the
I only fixed the icon in the place that it didn't work in the issue description, sound like I have a few more places to fix :)
LGTM in the menu, in the walkthrough title, and in a step. <img width="984" alt="image" src="https://user-"
Change:
import { ICommandHandler } from 'vs/platform/commands/common/commands'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; <del> import { ISearchHistoryService, VIEW_ID } from 'vs/platform/search/common/search'; </del> <ins> import { ISearchHistoryService, VIEW_ID, ISearchConfiguration } from 'vs/platform/search/common/search'; </ins> import { SearchView } from 'vs/workbench/parts/search/browser/searchView'; import * as Constants from 'vs/workbench/parts/search/common/constants'; import { IReplaceService } from 'vs/workbench/parts/search/common/replace';

Discussion:
I think it should be possible to disable "Replace Preview" in the settings. Currently, whenever I want to replace a word, the "Replace Preview" opens for every file, because I have file preview disabled.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.546 --- <!-- score: 0.535 --- <!-- score: 0.489 --- <!-- score: 0.473 --- <!-- score: 0.46 --<!-- potentialduplicatescomment --
Are you talking about the diff editor that opens when you click a result? What do you expect to see in that case?
Yes that's what I'm talking about. I would like to see just the file without a diff, maybe with the matches highlighted as I navigate through them in the search sidebar. Then when I click on replacing the text it would just replace it directly.
This seems reasonable and I would take a PR that adds a setting to disable the replace preview. FYI Starting point: and
I'd like to take a look at this.
Change:
import { LsConfiguration } from '../config'; export function looksLikeMarkdownPath(config: LsConfiguration, resolvedHrefPath: URI) { <del> return config.markdownFileExtensions.includes(Utils.extname(URI.from(resolvedHrefPath)).toLowerCase().replace('.', '')); </del> <ins> return config.markdownFileExtensions.includes(Utils.extname(resolvedHrefPath).toLowerCase().replace('.', '')); </ins> } export function isMarkdownFile(document: TextDocument) {

Discussion:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I was testing the server on neovim. I noticed the requires a lot from the client. Would it be possible to bundle default implementations of and all other custom requests to make the server self-contained?
I'd take a PR that does this (likely using service injection) but the current design is deliberate lets the client bring their own parser versionThe custom file messages means the server is not restricted to working with local files. Ideally the LSP would also include this functionality but right now it does not
I can make a PR. Wouldn't it be simpler to add a setting for a custom tokenizer? Then call with or make a request?
makes this easier to use the server as a library. For a client that doesn't want to implement the custom messages we use, you'd instead want to use the new version of which lets you pass in your own parser and workspace implementations
Change:
}, { "name": "ms-vscode.node-debug2", <del> "version": "1.42.1", </del> <ins> "version": "1.42.2", </ins> "repo": "https://github.com/Microsoft/vscode-node-debug2", "metadata": { "id": "36d19e17-7569-4841-a001-947eb18602b2",

Discussion:
was moved from the node-debug2 extension to node-debug in , but only node-debug was published, so the setting shows up twice in our published list of settings. This breaks gating checks for Bing in processing our builds. VS Code stopped getting search results starting Friday. To fix it we just have to publish node2 with the setting removed. Will also add a check for this on our end, and will look into improving this on Bing's side.
The published is correct - still hasn't been indexed by Bing however.
Change:
const startOffset = model.getOffsetAt(inlineCompletion.range.getStartPosition()) + commonPrefixLength; const start = model.getPositionAt(startOffset); <del> const commonSuffixLength = lengthOfLongestCommonSuffix(valueToReplace, inlineCompletion.text); </del> <ins> const remainingValueToReplace = valueToReplace.substr(commonPrefixLength); const commonSuffixLength = lengthOfLongestCommonSuffix(remainingValueToReplace, inlineCompletion.text); </ins> const end = model.getPositionAt(Math.max(startOffset, model.getOffsetAt(inlineCompletion.range.getEndPosition()) - commonSuffixLength)); return {

Discussion:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0-insider (user setup) OS Version: Windows_NT x64 10.0. List of extensions: None, all are disabled Steps to Reproduce: a new typescript file. , the suggestions widget opens and the first suggestion is . gray text however, only shows , it's missing the last character. 've attached a gif. Notice how when I type , the gray text displays but when I type , it shows . !
can you please verify todays insider build fixes this?
Yes, it has been fixed!
Change:
private _onEnablementOrModelChanged(): void { // cancels the scheduler, removes editor listeners / removes decoration this._localToDispose.clear(); <del> if (!this._editor.hasModel() || this._hasInlineChatSession || this._showGutterIconMode() === ShowGutterIcon.Never || !this._hasProvider()) { </del> <ins> if (!this._editor.hasModel() || this._hasActiveDebugSession || this._hasInlineChatSession || this._showGutterIconMode() === ShowGutterIcon.Never || !this._hasProvider()) { </ins> return; } const editor = this._editor;

Discussion:
Initially noticed by : <img width="780" alt="Screenshot 2023-11-17 at 13 53 45" src=""