Change:
"test_libmix_differences" ]; <del> disabledTestPaths = [ # fails due to https://github.com/NixOS/nixpkgs/issues/256896 # should be removed once that issue is resolved in coreboot or diffoscope "tests/comparators/test_cbfs.py" ] # Flaky tests on Darwin ++ lib.optionals stdenv.isDarwin [ </del> <ins> disabledTestPaths = lib.optionals stdenv.isDarwin [ </ins> "tests/comparators/test_git.py" "tests/comparators/test_java.py" "tests/comparators/test_uimage.py"

Discussion:
Steps to reproduce the behavior: diffoscope Eg: Broken since merged per  I looked into this a bit and I'm not sure if it's a diffoscope bug or a coreboot bug. The failing tests generate test files with (from coreboot) and the files generated by 4.21 are using 4 bytes less space for the "header" (trailer) at the end of the file: As a result, does not match. My first thought was to change the matcher but then the tests still fail... Looking into it looks like the change to the size may have been accidental. (C99 flexible arrays are nice for and but not for fixed size padding...) Anyway, even if this is a coreboot bug, it may still be useful to update diffutils to be able to recognize files produced by coreboot 4.21. Diffoscope: coreboot-utils: Other: Please run and paste the result.
Unless someone is confident that this is a coreboot-utils bug (either by diagnosing it themselves or by getting upstream to acknowledge it as a bug), I'd suggest 1. skipping the test in nixpkgs diffoscope to unbreak the build; 2. filing a bug with upstream diffoscope to let them know of that breakage with the new coreboot-utils version. Any other thoughts?
I won't be able to react in time for this problem for diffoscope, apologies. I would appreciate it if any of the other comaintainer could take care of this. I think we have pending diffoscope upgrades which could mitigate the problem in the meantime.
Diffoscope has opened for this which links here. I have opened which disables the tests as suggested by and I agree that this is a good way forward for now. If my PR gets merged I'd still suggest leaving this issue open until it's fixed and the cbfs tests run again, but closing it would also be fine with me.

Hi Ivan, Please send an email to Thx De : "Ivan Jager" A : "NixOS/nixpkgs" ,"Elyes HAOUAS" ,"Mention" Envoyé: samedi 23 Septembre 2023 15:19 Objet : [NixOS/nixpkgs] Build failure: diffoscobe broken by coreboot-utils 4.21 upgrade (Issue ) Steps To Reproduce Steps to reproduce the behavior: build diffoscope Eg: nix-build -A diffoscope Build log Additional context Broken since merged per git bisect I looked into this a bit and I'm not sure if it's a diffoscope bug or a coreboot bug.

The failing tests generate test files with cbfstool (from coreboot) and the files generated by cbfstool 4.21 are using 4 bytes less space for the "header" (trailer) at the end of the file: $ diffoscope --- +++ -2039,10 +2039,10 : ffff ffff ffff ffff ffff ffff ffff ffff ................ : ffff ffff ffff ffff ffff ffff ffff ffff ................ : ffff ffff ffff ffff ffff ffff ffff ffff ................ : ffff ffff ffff ffff ffff ffff ffff ffff ................ : ffff ffff ffff ffff ffff ffff ffff ffff ................ : ffff ffff ffff ffff ffff ffff ffff ffff ................ : ffff ffff ffff ffff ffff ffff ffff ffff ................ -: ffff ffff ffff ffff ffff ffff 4f52 4243 ............ORBC -: 3131 3132 0000 8000 0000 0000 0000 0040 1112...........@ -: 0000 0000 0000 0001 ffff ffff dcff ffff ................ +: ffff ffff ffff ffff ffff ffff ffff ffff ................ +: 4f52 4243 3131 3132 0000 8000 0000 0000 ORBC1112........ +: 0000 0040 0000 0000 0000 0001 e0ff ffff ... As a result, CbfsFile.recognizes does not match. My first thought was to change the matcher -139,7 +138,7 class CbfsFile(File): reloffset = ("<i", f.read(4))[0] if ( reloffset < 0 and -reloffset CBFSHEADERSIZE and -reloffset = CBFSHEADERSIZE and -reloffset < size ): f.seek(reloffset, io.SEEKEND) but then the rom2 tests still fail... Looking into the relevant change on the coreboot side it looks like the change to the cbfsheader size may have been accidental.

(C99 flexible arrays are nice for filename and data but not for fixed size padding...) Anyway, even if this is a coreboot bug, it may still be useful to update diffutils to be able to recognize files produced by coreboot 4.21. Notify maintainers Diffoscope: coreboot-utils: Other: Metadata Please run nix-shell -p nix-info --run "nix-info -m" and paste the result. nix-shell -p nix-info --run "nix-info -m" system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID:
Hi Thanks, Ivan, for bisecting and also submitting the fix for this: Kyösti
As I understand this issue (I am, alas, not a NixOS user or developer), the root cause of this issue is in rather than . If this is incorrect, please let me know — otherwise, I will assume that no action is needed on 's part. :+1: