jiebi/CodeConvo huggingface dataset:
Change:
<ins> { autoPatchelfHook, copyDesktopItems, fetchzip, lib, libGL, libGLU, libxcrypt-legacy, makeDesktopItem, makeWrapper, stdenv, testers, vulkan-loader, }: let description = "OpenGL and Vulkan Benchmark and Stress Test"; versions = { "x86_64-linux" = "2.3.0.0"; "aarch64-linux" = "2.3.0.0"; "i686-linux" = "2.0.16"; }; sources = { "x86_64-linux" = { url = "https://gpumagick.com/downloads/files/2024/furmark2/FurMark_${versions.x86_64-linux}_linux64.zip"; hash = "sha256-9xwnOo8gh6XlX2uTwvEorXsx9FafaeCyCPPPJLJGeuE="; }; "aarch64-linux" = { url = "https://gpumagick.com/downloads/files/2024/furmark2/FurMark_${versions.x86_64-linux}_rpi64.zip"; hash = "sha256-az4prQbg9I+6rt2y1OTy3t21/VHyZS++57r4Ahe3fcQ="; }; "i686-linux" = { url = "https://gpumagick.com/downloads/files/2024/furmark2/FurMark_${versions.i686-linux}_linux32.zip"; hash = "sha256-yXd90FgL3WbTga5x0mXT40BonA2NQtqLzRVzn4s4lLc="; }; }; in stdenv.mkDerivation (finalAttrs: { pname = "furmark"; version = versions.${stdenv.hostPlatform.system}; src = fetchzip sources.${stdenv.hostPlatform.system}; nativeBuildInputs = [ autoPatchelfHook copyDesktopItems makeWrapper ]; buildInputs = [ libGL libGLU ] ++ lib.optionals stdenv.isAarch64 [ libxcrypt-legacy ]; installPhase = '' runHook preInstall mkdir -p $out/share/furmark cp -rp * $out/share/furmark mkdir -p $out/bin for i in $(find $out/share/furmark -maxdepth 1 -type f -executable); do ln -s "$i" "$out/bin/$(basename "$i")" done runHook postInstall ''; appendRunpaths = [ (lib.makeLibraryPath [ vulkan-loader ]) ]; desktopItems = [ (makeDesktopItem rec { name = "FurMark"; exec = "FurMark_GUI"; comment = description; desktopName = name; genericName = name; categories = [ "System" "Monitor" ]; }) ]; passthru = { tests.version = testers.testVersion { package = finalAttrs.finalPackage; command = "furmark --version"; }; }; meta = { homepage = "https://www.geeks3d.com/furmark/v2/"; license = lib.licenses.unfree; mainProgram = "FurMark_GUI"; maintainers = with lib.maintainers; [ surfaceflinger ]; platforms = [ "aarch64-linux" "i686-linux" "x86_64-linux" ]; sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; inherit description; }; }) </ins>

Discussion:
Project description Metadata homepage URL: source URL: Proprietary license: Proprietary platforms: Windows, Linux I don't know how to package a nix package but here's what i found getting it to run from the .zip download: causes it to launch and works, but crashes with SIGSEGV. works so presumably it's a library issue of some sort but i don't know which. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
url = "https://github.com/OpenSC/OpenSC/commit/0d7967549751b7032f22b437106b41444aff0ba9.patch"; sha256 = "1y42lmz8i9w99hgpakdncnv8f94cqjfabz0v4xg6wfz9akl3ff7d"; }) <ins> (fetchpatch { name = "CVE-2019-15945.patch"; url = "https://github.com/OpenSC/OpenSC/commit/412a6142c27a5973c61ba540e33cdc22d5608e68.patch"; sha256 = "088i2i1fkvdxnywmb54bn4283vhbxx6i2632b34ss5dh7k080hp7"; }) (fetchpatch { name = "CVE-2019-15946.patch"; url = "https://github.com/OpenSC/OpenSC/commit/a3fc7693f3a035a8a7921cffb98432944bb42740.patch"; sha256 = "1qr9n8cbarrdn4kr5z0ys7flq50hfmcbm8584mhw7r39p08qwmvq"; }) </ins> ]; nativeBuildInputs = [ pkgconfig autoreconfHook ];

Discussion:
, (nixos-unstable) (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives.
opensc-0.19.0 already patched on 19.09 (see ) but not on master yet.
Change:
pname = "kwayland-integration"; nativeBuildInputs = [ extra-cmake-modules wayland-scanner ]; buildInputs = [ kguiaddons kidletime kwindowsystem kwayland qtbase wayland-protocols wayland ]; <ins> meta = { description = "Integration plugins for various KDE frameworks for the Wayland windowing system"; homepage = "https://invent.kde.org/plasma/kwayland-integration"; }; </ins> }

Discussion:
When searching on for "plasma integration" there are 2 different packages : and . Looking further to try and find a distinction, there's additionally a requires What are all these packages? Are they related? Aliases? Copies? would probably know more. I don't know if allows adding a description, but that or a comment in the files would be greatly appreciated.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Even if I have plasma-browser-integration in my , it seems that librewolf is not able to connect to the host ! EDIT: seems to work in mainline firefox. So it's a different issue. Sorry.
Old issue, but these all have congruent kde packages: The naming in Nixpkgs is simply mirroring the KDE naming convention.
It would be great if they had descriptions. Maybe I'll find some time to add it unless somebody beats me to the punch :)
Change:
<ins> { lib , stdenv , fetchFromGitHub , substituteAll , lcms , cmake , pkg-config , qt6 , openjpeg , tbb_2021_8 }: stdenv.mkDerivation (finalAttrs: { pname = "pdf4qt"; version = "1.3.7"; src = fetchFromGitHub { owner = "JakubMelka"; repo = "PDF4QT"; rev = "v${finalAttrs.version}"; hash = "sha256-wZJDMLEaHGBPSToQ+ObSfB5tw/fTIX1i5tmNPmIa7Ck="; }; patches = [ # lcms2 cmake module only appears when built with vcpkg. # We directly search for the corresponding libraries and # header files instead. ./find_lcms2_path.patch ]; nativeBuildInputs = [ cmake pkg-config qt6.qttools qt6.wrapQtAppsHook ]; buildInputs = [ qt6.qtbase qt6.qtwayland qt6.qtsvg qt6.qtspeech lcms openjpeg tbb_2021_8 ]; cmakeFlags = [ (lib.cmakeBool "PDF4QT_INSTALL_TO_USR" false) ]; meta = { description = "Open source PDF editor"; longDescription = '' This software is consisting of PDF rendering library, and several applications, such as advanced document viewer, command line tool, and document page manipulator application. Software is implementing PDF functionality based on PDF Reference 2.0. ''; homepage = "https://jakubmelka.github.io"; license = lib.licenses.lgpl3Only; mainProgram = "Pdf4QtViewerLite"; maintainers = with lib.maintainers; [ aleksana ]; platforms = lib.platforms.linux; }; }) </ins>

Discussion:
Package request: A simple and powerful PDF viewer and editor powered by the Qt framework. With a robust C++ library, intuitive PDF viewing/editing applications, and a handy command-line tool, PDF4QT streamlines your PDF interactions.
Change:
maintainers = with maintainers; [ Br1ght0ne ma27 zowoq ]; platforms = platforms.unix; changelog = "https://github.com/junegunn/fzf/blob/${version}/CHANGELOG.md"; <ins> mainProgram = "fzf"; </ins> }; }

Discussion:
Fzf does not have meta.metaProgram. Can anyone add it? Steps to reproduce the behavior: lib.getExe fzf in This is a very small bug, that throws this warning due to fzf not having a metaprogram. ! ! This is my shellAliases in I use home manager and flake. Using lib.getExe shows this warning, if I don't use lib.getExe then it doesn't. Also this is just a warning and not an error. Nix then assumes the metaprogram itself and the alias works just fine. Also this happens only the first time, as the nixos then assumes the package name to be the metaprogram, but for anyone newly installing and seeing these red warning lines can be scary. <!-- --- system: host os: multi-user?: sandbox: version: nixpkgs:
Change:
runHook preInstall mkdir -p $out/bin $out/share <del> cp -R ./sherlock $out/share </del> <ins> cp -R ./sherlock_project $out/share </ins> runHook postInstall '';

Discussion:
Package name: sherlock Latest released version: v0.15.0 <!-- Search your package here: --- Current version on the unstable channel: 0-unstable-2024-06-09 Current version on the stable/release channel: 0-unstable-2024-05-15 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Some extra info: Current version of sherlock may be broken potentially because it's outdated. The link is broken. Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I'll work on updating this. Current sherlock version is also broken for me.
Change:
<ins> diff --git a/src/external/librtprocess/src/include/librtprocess.h b/src/external/librtprocess/src/include/librtprocess.h index 47691a09..b1c63dbd 100644 --- a/src/external/librtprocess/src/include/librtprocess.h +++ b/src/external/librtprocess/src/include/librtprocess.h @@ -21,6 +21,7 @@ #define _LIBRTPROCESS_ #include <functional> +#include <cstddef> enum rpError {RP_NO_ERROR, RP_MEMORY_ERROR, RP_WRONG_CFA, RP_CACORRECT_ERROR}; diff --git a/src/operations/denoise.cc b/src/operations/denoise.cc index 10050f70..16b340c1 100644 --- a/src/operations/denoise.cc +++ b/src/operations/denoise.cc @@ -27,7 +27,7 @@ */ -#include <vips/cimg_funcs.h> +//#include <vips/cimg_funcs.h> #include "../base/new_operation.hh" #include "convert_colorspace.hh" diff --git a/src/operations/gmic/gmic.cc b/src/operations/gmic/gmic.cc index 876e7c20..fc6a8505 100644 --- a/src/operations/gmic/gmic.cc +++ b/src/operations/gmic/gmic.cc @@ -28,13 +28,31 @@ */ //#include <vips/cimg_funcs.h> +#include <vips/vips.h> #include "../../base/processor_imp.hh" #include "../convertformat.hh" #include "gmic.hh" -int vips_gmic(VipsImage **in, VipsImage** out, int n, int padding, double x_scale, double y_scale, const char* command, ...); - +int vips_gmic(VipsImage **in, VipsImage** out, int n, int padding, double x_scale, double y_scale, const char* command, ...) +{ +	VipsArrayImage *array; +	va_list ap; +	int result; + +#ifndef NDEBUG +	printf("vips_gmic(): padding=%dn", padding); +#endif + +	array = vips_array_image_new( in, n ); +	va_start( ap, command ); +	result = vips_call_split( "gmic", ap, array, out, +		padding, x_scale, y_scale, command ); +	va_end( ap ); +	vips_area_unref( VIPS_AREA( array ) ); + +	return( result ); +} PF::GMicPar::GMicPar(): OpParBase(), diff --git a/src/vips/gmic/gmic/src/CImg.h b/src/vips/gmic/gmic/src/CImg.h index 268b9e62..5a79640c 100644 --- a/src/vips/gmic/gmic/src/CImg.h +++ b/src/vips/gmic/gmic/src/CImg.h @@ -32843,7 +32843,7 @@ namespace cimg_library_suffixed { see deriche(), vanvliet(). **/ CImg<T>& blur_box(const float boxsize, const bool boundary_conditions=true) { -      const float nboxsize = boxsize>=0?boxsize:-boxsize*std::max(_width,_height,_depth)/100; +      const float nboxsize = boxsize>=0?boxsize:-boxsize*std::max({_width,_height,_depth})/100; return blur_box(nboxsize,nboxsize,nboxsize,boundary_conditions); } </ins>

Discussion:
Steps to reproduce the behavior: Adding fixes the issue. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Change:
nvim-treesitter = super.nvim-treesitter.overrideAttrs (old: callPackage ./nvim-treesitter/overrides.nix { } self super ); <ins> nvim-treesitter-parsers = lib.recurseIntoAttrs self.nvim-treesitter.grammarPlugins; </ins> nvim-ufo = super.nvim-ufo.overrideAttrs (old: { dependencies = with self; [ promise-async ];

Discussion:
Background: requires specific versions of tree-sitter grammars (see issue ), therefore was split from / in PR . However, while grammars in are built by Hydra, grammars are not. When using a lot of grammars or even , the grammars can take a while to build. Check Hydra status of any grammar (e.g. using hydra-check): They should be built by Hydra, same as grammars in : <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. system: host os: multi-user?: ( did not actually terminate, it's stuck building some derivation, perhaps this is because I have remote builders enabled by default?)
Change:
<link linkend="opt-services.nextcloud.enable">services.nextcloud</link>. A desktop client is packaged at <literal>pkgs.nextcloud-client</literal>. </para> <ins> <para> The current default by NixOS is <package>nextcloud20</package> which is also the latest major version available. </para> </ins> <section xml:id="module-services-nextcloud-basic-usage"> <title>Basic usage</title>

Discussion:
In line of the nextcloud nixos module the current default is nextcloud 19. On the one hand, this is not represented in the documentation. On the other, this yields the error that there are unpatched security issues.
Retroactively changing the default on 20.09 is not just a breaking change, but effectively breaks the upgrade path from 20.03: the problem with Nextcloud (and the main reason for this complex package-selection thing) is that they don't support upgrades across multiple major releases (i.e. you can't go from v18 to v20). The whole point of this option is that one can install an arbitrary Nextcloud version while we (as maintainers) can set "conservative" defaults for working upgrade paths. In your case it would be sufficient to set . Regarding CVE-2020-8259 and CVE-2020-8152: both vulnerabilities affect the encryption module which is turned off by default (IIRC it can only be enabled in the admin UI anyways). It's unfortunate that Nextcloud upstream doesn't care about older yet still active majors and rates security issues as "Low" even though the CVEs are rated as "High" by e.g. NIST, but that's where we are. In other words: if you don't use the affected features it's still OK to use (which can be allowed by setting .
I see your point, thanks. The issue is that I, as a user, install Nextcloud and see a security warning. Given the above, maybe the message could state that you may use the option and use nextcloud20. Would that be feasible? Or given the fact that 21.03 is 'around the corner' would it be worth it?
why did you mark this as security-relevant? Both CVEs in question are disclosed by upstream and will warn about them by default. This is merely an issue with documentation and helpful warnings IMHO.
The issue seems to be about undocumented path towards using nextcloud while staying secure
Yes, it's about documentation, no immediate action is pending to fix a security issue! Nextcloud versions with known vulnerabilities yield an evaluation error, this is primarily about suggesting what to do if one stumbles upon this.
Change:
vivaldi = callPackage ../applications/networking/browsers/vivaldi {}; <ins> vivaldi-ffmpeg-codecs = callPackage ../applications/networking/browsers/vivaldi/ffmpeg-codecs.nix {}; </ins> openmpt123 = callPackage ../applications/audio/openmpt123 {}; opusfile = callPackage ../applications/audio/opusfile { };

Discussion:
H.264 videos and specifically those (WebM and Theora are fine) don't play, which means that videos on Facebook and Twitter (at least) report an error. There are instructions for getting a patched version of the ffmpeg lib installed into your home folder which works, but ideally wouldn't be needed: to that the H.264 video don't work but the others do. System: (NixOS: , Ubuntu/Fedora: , ...) Nix version: (run ) Nixpkgs version: (run ) Sandboxing enabled: (run )
What browser are you using? Works on Chromium, Firefox and qutebrowser (qtwebkit) on master for me.
Vivaldi, hence the title of the issue...
Oh, sorry, didn't know there's a browser called vivaldi.
Change:
preConfigure = '' export NIX_CFLAGS_COMPILE="-I${e18.efl}/include/eo-1 -I${e18.efl}/include/ecore-imf-1 -I${e18.efl}/include/ethumb-client-1 -I${e18.efl}/include/ethumb-1 $NIX_CFLAGS_COMPILE" ''; <ins> # this is a hack and without this cpufreq module is not working: #   when set_freqset_setuid is true and "e18_freqset" is set in setuidPrograms (this is taken care of in e18 NixOS module), #   then this postInstall does the folowing: #   1. moves the "freqset" binary to "e18_freqset", #   2. linkes "e18_freqset" to enlightenment/bin so that, #   3. setuidPrograms detects it and makes appropriate stuff to /var/setuid-wrappers/e18_freqset, #   4. and finaly, linkes /var/setuid-wrappers/e18_freqset to original destination where enlightenment wants it postInstall = if set_freqset_setuid then '' export CPUFREQ_DIRPATH=`readlink -f $out/lib/enlightenment/modules/cpufreq/linux-gnu-*`; mv $CPUFREQ_DIRPATH/freqset $CPUFREQ_DIRPATH/e18_freqset ln -sv $CPUFREQ_DIRPATH/e18_freqset $out/bin/e18_freqset ln -sv /var/setuid-wrappers/e18_freqset $CPUFREQ_DIRPATH/freqset '' else ""; </ins> meta = { description = "The Compositing Window Manager and Desktop Shell"; homepage = http://enlightenment.org/;

Discussion:
When starting the enlightenment version 18 desktop manager on my unstable nixos system, I am getting the following errors regarding the module: and It seems should be a setuid program in the configuration. /cc
Yep it should be, will look into it later. Thanks!
Change:
libc = gcc_multi_sysroot; }; <del> gccForLibs = gcc_multi_sysroot; </del> <ins> gccForLibs = gcc_multi_sysroot // { inherit (glibc_multi) libgcc; langCC = assert (gcc64.cc.langCC != gcc32.cc.langCC) -> throw "(gcc64.cc.langCC=${gcc64.cc.langCC}) != (gcc32.cc.langCC=${gcc32.cc.langCC})"; gcc64.cc.langCC; }; </ins> }; in clangMulti

Discussion:
the error has changed to any ideas? perhaps a issue here
Investigating...
Well this will get you back to where you were before: See if you can nudge it a bit further; if not I can work on this again tomorrow or Monday.
Change:
cat ${gtkrc2} >"$gtkrc2" fi <del> gtk3_settings="''${XDG_CONFIG_HOME:?}/gtk-3.0/settings.ini" </del> <ins> gtk3_settings="''${XDG_CONFIG_HOME}/gtk-3.0/settings.ini" </ins> if ! [ -f "$gtk3_settings" ] then mkdir -p "$(dirname "$gtk3_settings")"

Discussion:
Describe the bug After upgrade to 20.03 nixos-activation.service don't start . Error log: nixos-activation.service - Run user-specific NixOS activation Loaded: loaded (/nix/store/jcv2nvwkdc4hlhfx2dcchw3xgnmgyk8n-unit-nixos-activation.service/nixos-activation.service; static; vendor preset: enabled) Active: failed (Result: exit-code) since Fri 2020-02-21 11:57:14 CET; 8s ago Process: ExecStart=/nix/store/6hls8gx0c7prqf6gc2s1q9kp5w57jnb4-unit-script-nixos-activation-start (code=exited, status=1/FAILURE) Main PID: (code=exited, status=1/FAILURE) lut 21 11:57:14 nixos systemd[1389]: Starting Run user-specific NixOS activation... lut 21 11:57:14 nixos 6hls8gx0c7prqf6gc2s1q9kp5w57jnb4-unit-script-nixos-activation-start[]: /nix/store/6hls8gx0c7prqf6gc2s1q9kp5w57jnb4-unit-script-nixos-activation-start: line 22: XDGCONFIGHOME: parameter null or not set lut 21 11:57:14 nixos systemd[1389]: nixos-activation.service: Main process exited, code=exited, status=1/FAILURE lut 21 11:57:14 nixos systemd[1389]: nixos-activation.service: Failed with result 'exit-code'. lut 21 11:57:14 nixos systemd[1389]: Failed to start Run user-specific NixOS activation. I am using home manager but empty profile without home manager is also broken. After switch channel to 19.09 everything is OK. To Reproduce Steps to reproduce the behavior: to 20.03 Additional context I am using KDE. Adding XDGCONFIGHOME to this file does not solve the problem completely. Service start but for ex. flatpak app not.

Metadata Please run and paste the result. nix-shell -p nix-info --run "nix-info -m" system: host os: multi-user?: sandbox: version: channels(root): channels(piotrek): nixpkgs: Maintainer information:
caused by
I had this issue too, and it can be fixed by enabling this : I am not really sure why, this fix come from another issue that is plasma related.
cc
Yes, it's solve error related to XDGCONFIGHOME but flatpak app still fail to launch. Starting KeePassXC result in error: The name org.freedesktop.Accounts was not provided by any .service files. Unrelated problem? EDIT: Yes, it's
As far as I understand this is actually a workaround and not a real solution. iirc the suggested workaround was for a now fixed problem where plasma wouldn't start due to a hardcoded limit on env vars
It is indeed a workaround, sorry for the bad phrasing. I know this is a workaround for another issue that has been merged, but it has fixed the issue for me.
Change:
gitBase = lib.makeOverridable (import ./git) { inherit fetchurl stdenv curl openssl zlib expat perl python gettext gnugrep asciidoc xmlto docbook2x docbook_xsl docbook_xml_dtd_45 libxslt cpio tcl <del> tk makeWrapper subversionClient gzip libiconv; </del> <ins> tk makeWrapper subversionClient gzip openssh libiconv; </ins> texinfo = texinfo5; svnSupport = false;         # for git-svn support guiSupport = false;         # requires tcl/tk

Discussion:
Running with my still-quite-new nix environment, I get: Installing openssh fixes the problem for me, of course. But this means that git really ought to declare a dependency on openssh, no?
Hmm, currently I see two other alternatives: wrap all to have ssh in path (this seems the cleanest way), add it to , or or leave it as it is.
Or patch git to invoke ssh via an absolute path. (I'm not really fond of wrappers...)
Personally, I'd be very much in favor of patching git to call via an absolute path. At the same time, maintaining that patch over time is tedious and error-prone work, and I'd rather not be responsible for that. IMHO, patching SSH would be a feasible alternative only if we get that patch included upstream.
Has anyone taken a look at patching git to see how hard it will be?
There are two places. One is in connect.c where it reads GIT_SSH and then does Another is in git-gui where it does more or less the same, but in TCL.
I just found out that openssh isn't even a build input of git at the moment. :-)
I've decided to add a wrapper, since maintaining patches for references is going to be a burden. We still need to be able to specify public keys for ssh to pick them up.
your patch broke git-annex:
Reverted
that's an old build, now src is using https for sxiv
Is there a recommended solution for this now?
The recommended solution is to patch git, IMHO. It's not hard, as pointed out.
Triage: this issue does still exist on 16.03-beta:
Patched in
The solution to this issue is now causing a different issue on Fedora: () I'm not sure if we should really hard-code a SSH binary or if we should e.g. just reference a SSH binary as a fallback. Opinions welcome :)
FYI: is about to revert this and I currently believe that this is a good idea.