jiebi/CodeConvo huggingface dataset:
Change:
}; patches = [ <ins> # fix tests with recent versions of git-annex (fetchpatch { url = "https://github.com/alpernebbi/git-annex-adapter/commit/6c210d828e8a57b12c716339ad1bf15c31cd4a55.patch"; sha256 = "17kp7pnm9svq9av4q7hfic95xa1w3z02dnr8nmg14sjck2rlmqsi"; }) </ins> (substituteAll { src = ./git-annex-path.patch; gitAnnex = "${git-annex}/bin/git-annex";

Discussion:
Describe the bug fails to build on latest master. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
It seems like git-annex-metadata-gui is incompatible with the JSON interface of the most recent version of git-annex. You should file an upstream issue and then we could mark the package as broken in Nixpkgs. I doubt this will be fixed since is not working on git-annex-metadata-gui anymore.
Thanks for mentioning me, I wasn't aware. Looks like the tests broke again because they check git-annex behaviour too strictly, but things actually still work. Should be fixed with (pushed to master).
Thanks a lot
Change:
package = mkPackageOption pkgs "redis" { }; vmOverCommit = mkEnableOption '' <del> setting of vm.overcommit_memory to 1 </del> <ins> set `vm.overcommit_memory` sysctl to 1 </ins> (Suggested for Background Saving: <https://redis.io/docs/get-started/faq/>) <del> ''; </del> <ins> '' // { default = true; }; </ins> servers = mkOption { type = with types; attrsOf (submodule ({ config, name, ... }: {

Discussion:
Describe the bug A clear and concise description of what the bug is. To Reproduce Steps to reproduce the behavior: redis via: at the log and observe: Expected behavior No warnings or errors in log. Additional context I thought line was supposed to prevent such a warning... :thinking: Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --ping Metadata Please run and paste the result. Maintainer information:
If the sysctl doesn't work, we can probably also put the suggested line into the script. :thinking: This should be relatively easy to test, given we have a NixOS vm test :-)
As long as another solution does not fail loudly in containers, i.e. reintroduce bug which we fixed by switching to sysctl. I’m game. But my question is: Is the broken since that "fix"? Can others reproduce this issue? Or is maybe running redis in a container where this line doesn’t take effect?
I'm just running on a regular NixOS install which happens to be running on VMWare.
Strange... when I add to the test I don't see the warning :thinking:
I marked this as stale due to inactivity. &rarr;
Change:
ruby_2_6 ruby_2_7; <del> rubyMinimal = ruby.override { # gem support is minimal overhead rubygemsSupport = true; useRailsExpress = false; zlibSupport = false; opensslSupport = false; gdbmSupport = false; cursesSupport = false; docSupport = false; yamlSupport = false; fiddleSupport = false; }; </del> ruby = ruby_2_6; rubyPackages = rubyPackages_2_6;

Discussion:
Describe the bug I'm hunting down packages that reference gcc. One of them is (maintainers: & ). Here's why: The fault is the fact that the build flag doesn't remove all references, as one might expect (EDIT, see: ). I'm up to including this feature, but I was wondering perhaps it'd be legit to disable this feature for the derivation? I opened a PR at (EDIT).
But that would mean gems that require a compiler would no longer work.
The suggestion is for , not . Isn't the derivation that's used to build the gems? According to:
It still has support for gems, so some will fail with gcc. What exactly is the use case for ?
Technically it's not used anywhere, according to .
I'd like to make my - with an overlay. The goal is to make the 1 or 2 pure ruby scripts I have on my system not pull , as they do today.
But what is the reason? You're likely to have a version of ruby that includes gcc on your system anyway, so you don't really save any space. And the use-case would be plain ruby scripts with only the gems that don't require system libraries. We have no users in nixpkgs of presumably because it's rather pointless. And while of course we can strip gcc from rubyMinimal (there's no harm), I'd rather say drop instead.
Not If I'll apply and this overlay: This allows me to not need GCC for for example - which is the only ruby gem I use. For example, run with this PR and that overlay applied: And you should get: And without , (and without the overlay because it would fail) you should get: is the only derivation that needs ruby that I actually use. I've updated the 1st comment in to exemplify this overlay as a possible usecase. Well I tend to agree - even for asciidoctor which should be pretty much a pure ruby gem, it still required and which aren't enabled in current . Hence I tend to agree. OK so I've updated to include a drop to , including release notes and an alias. Waiting for your review :crossed_fingers: .
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Change:
alsa-lib libXdamage libXtst libXrandr libxshmfence expat cups dbus gdk-pixbuf gcc-unwrapped.lib systemd <del> libexif </del> <ins> libexif pciutils </ins> liberation_ttf curl util-linux xdg-utils wget flac harfbuzz icu libpng opusWithCustomModes snappy speechd bzip2 libcap at-spi2-atk at-spi2-core

Discussion:
GPU acceleration: is required to avoid (which results in a software fallback and bad performance). SwiftShader seems to perform fine (and chrome://gpu even displays "Hardware accelerated") but SwiftShader should actually use the CPU instead of the GPU. Unfortunately the Wayland support is completely broken (crashes on startup) but it was basically already broken before: . It's still a regression that makes it worse though. Google Chrome lacks a dedicated maintainer so these issues will unfortunately persist for now. Edit: This was with Mesa's driver btw (Radeon HD 6950 GPU) but it also affects at least the proprietary Nvidia drivers: .
Change:
buildInputs = [ freetype <ins> fluidsynth </ins> SDL2 glib openal

Discussion:
Package name: _86Box Latest released version: 4.0 <!-- Search your package here: --- Current version on the unstable channel: 3.11 Current version on the stable/release channel: 3.11 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
I'm a bit busy but I'll try to get back to this on the weekend. I want to check the build system and deps to make sure there's nothing I should be updating there beyond swapping the version numbers, it looks like a decently large changelog.
Change:
<del> { lib , stdenv , fetchFromGitHub , cmake , curl , gtest , libtorrent , ncurses , jsonRpcSupport ? true, nlohmann_json , xmlRpcSupport ? true, xmlrpc_c }: stdenv.mkDerivation rec { pname = "jesec-rtorrent"; version = "0.9.8-r15"; src = fetchFromGitHub { owner = "jesec"; repo = "rtorrent"; rev = "v${version}"; hash = "sha256-yYOw8wsiQd478JijLgPtEWsw2/ewd46re+t9D705rmk="; }; nativeBuildInputs = [ cmake ]; buildInputs = [ curl libtorrent ncurses ] ++ lib.optional jsonRpcSupport nlohmann_json ++ lib.optional xmlRpcSupport xmlrpc_c; cmakeFlags = [ "-DUSE_RUNTIME_CA_DETECTION=NO" ] ++ lib.optional (!jsonRpcSupport) "-DUSE_JSONRPC=NO" ++ lib.optional (!xmlRpcSupport) "-DUSE_XMLRPC=NO"; doCheck = true; checkInputs = [ gtest ]; prePatch = '' substituteInPlace src/main.cc  --replace "/etc/rtorrent/rtorrent.rc" "${placeholder "out"}/etc/rtorrent/rtorrent.rc" ''; postFixup = '' mkdir -p $out/etc/rtorrent cp $src/doc/rtorrent.rc $out/etc/rtorrent/rtorrent.rc ''; meta = with lib; { description = "An ncurses client for libtorrent, ideal for use with screen, tmux, or dtach (jesec's fork)"; homepage = "https://github.com/jesec/rtorrent"; license = licenses.gpl2Plus; maintainers = with maintainers; [ winter AndersonTorres ]; platforms = platforms.linux; }; } </del>

Discussion:
jesec-libtorrent tests fail, making the build fail. Steps to reproduce the behavior: jesec-libtorrent fails, failing the build I expect it to build succesfully ! ! I'm building the package with the help of morph to deploy on a server, though this shouldn't really have an impact.
This happened between and . I'll bisect later, thanks for the heads up!
The test is expecting to be returned by , but is instead getting . I'm... really not sure how to move forward with this, short of disabling the test.
Next time copy-paste the error message.
Perhaps triggered by upgrading glibc from 2.33 to 2.34? (some change in getaddrinfo() behavior)
I ruled that out initially since I didn't see anything mentioned in the changelog about getaddrinfo. I'll give it a try, though.
This has been fixed by .
Change:
sha256 = "sha256-lfHXutAp06Xr/TSBpDwBUBC/mWI9XuyImoKwA3inqgU="; }; <del> propagatedBuildInputs = [ zlib xz ncompress gzip bzip2 gnutar p7zip cabextract squashfsTools xz pycrypto ] </del> <ins> propagatedBuildInputs = [ zlib xz gzip bzip2 gnutar p7zip cabextract squashfsTools xz pycrypto ] </ins> ++ lib.optionals visualizationSupport [ matplotlib pyqtgraph ] ++ lib.optionals (!stdenv.isDarwin) [ cramfsprogs cramfsswap sasquatch ];

Discussion:
The and packages both provide an implementation of that is incompatible. This is leading to some trouble when having both packages installed and executing shell scripts that expect to be present in the path. Since isn't that widely used I would recommend to either remove from (it is a symbolic link anyway) or to rename it to . Steps to reproduce the behavior: and on a gzip compressed file (example: some ) There might be valid use cases where from is used, for example for very old shell scripts dating back to the early 1990s or earlier. These days the default is expected to be from and other distributions (like Fedora) do not seem to be creating the symlink for .
Change:
./security/oath.nix ./security/pam.nix ./security/pam_mount.nix <del> ./security/pam_usb.nix </del> ./security/please.nix ./security/polkit.nix ./security/rngd.nix

Discussion:
The usb pam module is broken (it requires udisks 1.0, which is not available on DBUS) Add to ; Rebuild the system; Try to run Get the following output: Add a line Rebuild the system; Try to run Get the following output: system: host os: multi-user?: sandbox: version: channels(root): channels(balsoft): nixpkgs:My config (long & dirty):
seems to be unmaintained. The GitHub and SourceForge pages seem to have no activity since 2015. It may be worth considering to deprecate and then remove the module. Cc of the NixOS security group (since this may be a security issue too)
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
Coincidentally ran into this issue today. +1 for removing the package or marking it as broken.
I marked this as stale due to inactivity. &rarr;
Change:
<ins> { config, lib, pkgs, ... }: with lib; let cfg = config.services.preload; in { meta = { maintainers = pkgs.preload.meta.maintainers; }; options.services.preload = { enable = mkEnableOption "preload"; package = mkPackageOption pkgs "preload" { }; }; config = mkIf cfg.enable { systemd.services.preload = { description = "Loads data into ram during idle time of CPU."; wantedBy = [ "multi-user.target" ]; serviceConfig = { EnvironmentFile = "${cfg.package}/etc/conf.d/preload"; ExecStart = "${getExe cfg.package} --foreground $PRELOAD_OPTS"; Type = "simple"; # Only preload data during CPU idle time IOSchedulingClass = 3; DynamicUser = true; StateDirectory = "preload"; }; }; }; } </ins>

Discussion:
Project description Runs as a daemon and records statistics about usage of programs using Markov chains; files of more frequently-used programs are, during a computer's spare time, loaded into memory. Metadata homepage URL: source URL: license: gpl2 platforms: linux
Same here! Preload can really help out when using Linux on older hardware or when using programs that generally take long to start.
Change:
fingerprint = "E576 BFB2 CF6E B13D F571  33B9 E315 A758 4613 1564"; }]; }; <ins> nielsegberts = { email = "nix@nielsegberts.nl"; github = "nielsegberts"; githubId = 368712; name = "Niels Egberts"; }; </ins> nigelgbanks = { name = "Nigel Banks"; email = "nigel.g.banks@gmail.com";

Discussion:
Project description Lightweight nextcloud/seafile/syncthing/ftp alternative to easily share files with mutiple users via HTTP Metadata homepage URL: source URL: license: Apache License platforms: any
I marked this as stale due to inactivity. &rarr;
need this too
I also have a work in progress for a module that wraps FileBrowser
If you submit a PR I can help review or test it
I've not quite sure how stacked PR's work on github as the previous one is still pending, but it would be great if you could test and leave feedback on this commit:
I've opened a new issue to discuss the options:
Change:
}; }; structlog = buildPythonPackage rec { name = "structlog-15.3.0";

Discussion:
with current current unstable channel, the fail2ban package misses its etc path. The package hasn't been updated for some time and the out path is apparently generated by rewriting pathes in its : This suggests that the breakage might be related to the recent python packaging rework, so /cc as well as pkg maintainers
Change:
propagatedUserEnvPkgs = [ gnome3.gnome_themes_standard ]; <del> nativeBuildInputs = [ pkgconfig ]; buildInputs = [ gtk3 glib intltool itstool libxml2 python gnome3.gsettings_desktop_schemas makeWrapper docbook_xsl gdk_pixbuf gnome3.defaultIconTheme librsvg libxslt ]; </del> <ins> nativeBuildInputs = [ pkgconfig intltool itstool makeWrapper docbook_xsl libxslt # reconfiguration autoreconfHook gnome3.gnome_common gnome3.yelp_tools ]; buildInputs = [ gtk3 glib libxml2 python gnome3.gsettings_desktop_schemas gdk_pixbuf gnome3.defaultIconTheme librsvg ]; </ins> enableParallelBuilding = true; <ins> patches = [ # https://bugzilla.gnome.org/show_bug.cgi?id=782161 (fetchurl { url = https://bugzilla.gnome.org/attachment.cgi?id=351054; sha256 = "093wjjj40027pkqqnm14jb2dp2i2m8p1bayqx1lw18pq66c8fahn"; }) ]; </ins> preFixup = '' wrapProgram "$out/bin/glade"  --set GDK_PIXBUF_MODULE_FILE "$GDK_PIXBUF_MODULE_FILE" 

Discussion:
System: 18.03pre118631. (Impala) Nix version: nix-env (Nix) 1.11.15 Nixpkgs version: "18.03pre118631." Sandboxing enabled: build-use-sandbox = true
See, I thought I had fixed it somewhere but cannot find it ATM.
Change:
<ins> { lib , Babel , buildPythonApplication , fetchPypi , fixtures , mock , pbr , pytestCheckHook , pythonOlder , setuptools }: buildPythonApplication rec { pname = "bashate"; version = "2.0.0"; disabled = pythonOlder "3.5"; src = fetchPypi { inherit pname version; sha256 = "05qsaaqfpvr6h4g19prbkpznwb9a4dwzyzivdzh9x80cgkq0r6gb"; }; propagatedBuildInputs = [ Babel pbr setuptools ]; checkInputs = [ fixtures mock pytestCheckHook ]; pythonImportsCheck = [ "bashate" ]; meta = with lib; { description = "Style enforcement for bash programs"; homepage = "https://opendev.org/openstack/bashate"; license = with licenses; [ asl20 ]; maintainers = with maintainers; [ fab ]; }; } </ins>

Discussion:
Project description A pep8 equivalent for bash scripts This program attempts to be an automated style checker for bash scripts to fill the same part of code review that pep8 does in most OpenStack projects. It started from humble beginnings in the DevStack project, and will continue to evolve over time. Metadata homepage URL: source URL: license: Apache2.0 platforms: unix, linux, darwin
Change:
# FIXME: Try enabling this once the default linux kernel is at least 6.7 doCheck = false; # needs bcachefs module loaded on builder <del> patches = [ # code refactoring of bcachefs-tools broke reading passphrases from stdin (vs. terminal) # upstream issue https://github.com/koverstreet/bcachefs-tools/issues/261 ./fix-encrypted-boot.patch # https://github.com/koverstreet/bcachefs-tools/pull/305 (fetchpatch { name = "use-ar-var-in-makefile.patch"; url = "https://github.com/koverstreet/bcachefs-tools/commit/91e67ab2bd48fa135a1f5109b23899a4f1019a03.patch"; sha256 = "sha256-nB4Tgcwa8eeasIDQ4rrYORie/X8LMuCSRi+WJNw+R/U="; }) ]; </del> postPatch = '' substituteInPlace Makefile  --replace-fail "target/release/bcachefs" "target/${stdenv.hostPlatform.rust.rustcTargetSpec}/release/bcachefs"

Discussion:
Package name: bcachefs-tools Latest released version: 1.9.1 <!-- Search your package here: --- Current version on the unstable channel: 1.7.0-unstable-2024-05-09 Current version on the stable/release channel: 1.7.0-unstable-2024-05-09 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
stdenv.mkDerivation rec { pname = "reaper"; <del> version = "6.47"; </del> <ins> version = "6.61"; </ins> src = fetchurl { url = "https://www.reaper.fm/files/${lib.versions.major version}.x/reaper${builtins.replaceStrings ["."] [""] version}_linux_${stdenv.hostPlatform.qemuArch}.tar.xz"; hash = { <del> x86_64-linux = "sha256-31HmIx/ohbrzu5uj8KOOZiHNCmXwng9h+fIGaJfYyqA="; aarch64-linux = "sha256-CMmcBpaZ6BEZJ1144aQhOJ/o2NrGD7/8aq+ObLVMXYE="; </del> <ins> x86_64-linux = "sha256-Lp2EVky1+ruc86LdMmvhZIisoYl0OxdkVnN3h/u09IQ="; aarch64-linux = "sha256-sPLCMA//xAdWXjY7++R6eLWS56Zi0u+9ju7JlICGvVc="; </ins> }.${stdenv.hostPlatform.system}; };

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: reaper <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 6.47 desired version: 6.59 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
wrapProgram "$out/bin/thunar-settings"  --set "THUNARX_MODULE_DIR" "$out/lib/thunarx-3" <del> for file in "lib/systemd/user/thunar.service" "share/dbus-1/services/org.xfce.FileManager.service"  </del> <ins> # NOTE: we need to remove the folder symlink itself and create # a new folder before trying to substitute any file below. rm -f "$out/lib/systemd/user" mkdir -p "$out/lib/systemd/user" # point to wrapped binary in all service files for file in "lib/systemd/user/thunar.service"  "share/dbus-1/services/org.xfce.FileManager.service"  </ins> "share/dbus-1/services/org.xfce.Thunar.FileManager1.service"  "share/dbus-1/services/org.xfce.Thunar.service" do

Discussion:
Describe the bug Cannot install thunar with any plugins enabled. To Reproduce Steps to reproduce the behavior: thunar with a plugin: to install it a permission denied error Expected behavior It should install successfully as it was working until recently. Unfortunately after git blaming xfce/thunar files I haven't found anything that has changed recently that could explain the regression. Additional context The problem seems to be happening while trying to delete the file "lib/systemd/user/thunar.service". I've changed that post build hook to do an on those files and it seems that the file is owned by , whereas the remaining files (for which it works) are owned by . Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Change:
, libXext , libXfixes , libXtst <del> , libxml2 </del> , libxfce4ui , libxfce4util , wayland

Discussion:
Missing dependency on breaks "Open Terminal Here" functionality Steps to reproduce the behavior:  without in that right clicking and selecting "Open Terminal Here" is broken Package should handle so users don't have to manually install Possible to fix by wrapping lines occur in <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<ins> diff --git a/tests/test_trash.py b/tests/test_trash.py index d745cd2..173e3e5 100644 --- a/tests/test_trash.py +++ b/tests/test_trash.py @@ -24,13 +24,6 @@ class TestTrash: def test_version(self, portal_mock): portal_mock.check_version(1) -    def test_trash_file_fails(self, portal_mock): -        trash_intf = portal_mock.get_dbus_interface() -        with open("/proc/cmdline") as fd: -            result = trash_intf.TrashFile(fd.fileno()) - -        assert result == 0 - def test_trash_file(self, portal_mock): trash_intf = portal_mock.get_dbus_interface() </ins>

Discussion:
Steps to reproduce the behavior: xdg-desktop-portal Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Can't repro on ()
I'm rebuilding /nix/store/1md85bcdrifm51lwmvj4qbcfcakbkz9r-xdg-desktop-portal- yet. My config was at As you can see, any override was not here.
I still can't repro, even with rebuilding. Could be a flaky test. Try building the package (not the config) on directly to rule out config issues.
It is caused by reading /proc/cmdline. It's confusing. Maybe it was an unreduciable build.
is the command line passed to your kernel, so... check kernel config? The "file" is world-readable for me though.
I mean we shouldn't read this actually, according to . That was a bug caused by nix. I think the best way is disabling this test. Anyway, I just use linux-zen-6.10.1 without any rebuild just from cache. I do not think It has anything to do with my kernel config.
This is a hilarious test actually: I'm tempted to just disable it entirely.
can you check and reply there if it works for you?
My remote desktop lost connection. Will be tested tonight.
Test are done.