jiebi/CodeConvo huggingface dataset:
Change:
dump = callPackage ../tools/backup/dump { }; dxvk = callPackage ../misc/dxvk { }; <ins> dxvk_1 = callPackage ../misc/dxvk/dxvk.nix { dxvkVersion = "1.10"; }; dxvk_2 = callPackage ../misc/dxvk/dxvk.nix { dxvkVersion = "2.1"; }; </ins> ecdsatool = callPackage ../tools/security/ecdsatool { };

Discussion:
In future releases of dxvk the setup script won't be included anymore so this issue is just to notify so something can be figured out for how the nix package should handle it beforehand. (Hope such an issue is okay) See
CC
Thanks for the heads up. The DLLs are already available via a output, but this will break anyone’s set up that relies on . A short term solution would be to vendor the script. Longer term, it would be ideal if there were a way to declaratively create and manage a Wine prefix.
1 has been released with the script removed
I saw that. It can also build natively on Linux, which is interesting. I need to think about how I want to do things and maybe see what other distributions that package it are doing.
God speed
There is a nix-gaming repository that contains such derivation: It also handles vkd3d-proton:
One approach I’m considering is splitting dxvk into dxvk110 (for Darwin and hardware no longer supported by 2.0) and dxvk2x (or just dxvk_2, not sure). The plain DXVK derivation could continue to provide the script (most likely copied from before upstream removed it) while the versioned ones would be built for the native platform only (Linux and Windows). Well, I guess if it builds on Darwin, I can set the platform to then mark it broken on Darwin. I doubt DXVK 2.0 will work on Darwin any time soon. There are a number of extensions DXVK needs that aren’t implemented yet in MoltenVK, and since DXVK is always adding and using new ones, it’s a moving target.
I created to add the script and bump DXVK. It also exposes native builds on Linux.
Change:
<ins> { lib , stdenv , fetchFromGitHub , cmake , vulkan-headers , glfw , catch2 }: stdenv.mkDerivation rec { pname = "vk-bootstrap"; version = "0.5"; outputs = [ "out" "dev" ]; src = fetchFromGitHub { owner = "charles-lunarg"; repo = "vk-bootstrap"; rev = "v${version}"; sha256 = "sha256-rKyfUWfRYiVNzLWh6y44ASHW4j+yabY0kZTdZi8j2Dc="; }; postPatch = '' # Upstream uses cmake FetchContent to resolve glfw and catch2 # needed for examples and tests sed -iE 's=add_subdirectory(ext)==g' CMakeLists.txt sed -iE 's=Catch2==g' tests/CMakeLists.txt ''; nativeBuildInputs = [ cmake ]; buildInputs = [ vulkan-headers glfw catch2 ]; cmakeFlags = [ "-DVK_BOOTSTRAP_VULKAN_HEADER_DIR=${vulkan-headers}/include" ]; meta = with lib; { description = "Vulkan Bootstrapping Library"; license = licenses.mit; homepage = "https://github.com/charles-lunarg/vk-bootstrap"; maintainers = with maintainers; [ shamilton ]; platforms = platforms.all; }; } </ins>

Discussion:
Project description A utility library that jump starts initialization of Vulkan. Helps writing simple boilerplate when dealing with Vulkan projects, helping beginners get into the ecosystem. Metadata homepage URL: (and possibly ) source URL: license: mit platforms: all (I think)
I didn't notice this but thank you so much for trying to package this for me ! Very much appreciated! :smile:
Change:
for prog in bin/gitk libexec/git-core/git-gui; do notSupported "$out/$prog" done <del> ''); </del> <ins> '') + stdenv.lib.optionalString stdenv.isDarwin '' # enable git-credential-osxkeychain by default if darwin cat > $out/etc/gitconfig << EOF [credential] helper = osxkeychain EOF ''; </ins> enableParallelBuilding = true;

Discussion:
Git includes a number of credential storage systems. On OS X there's a Keychain-based store that uses the encrypted login keychain to keep track of sensitive credentials. https://git- The implementation is written in C, and can be found in . If we could change the git expression to , and install the credential helper on OS X that would be amazing! Install git on OS X. Set your credential helper to use the built-in osxkeychain method included with git. Try pushing or pulling from an HTTPS GitHub repo where authentication is required. System: Darwin 15.4.0 Darwin Kernel Version 15.4.0: Fri Feb 26 22:08:05 PST 2016; root:xnu-3248.40.184~3/RELEASEX8664 x86_64 i386 MacBookPro11,5 Darwin Nix version: nix-env (Nix) 1.11.2 Nixpkgs version: "16.09pre-git"
Change:
stdenv.mkDerivation { pname = targetPrefix + (if name != "" then name else "${bintoolsName}-wrapper"); <del> version = if bintools == null then null else bintoolsVersion; </del> <ins> version = if bintools == null then "" else bintoolsVersion; </ins> preferLocalBuild = true;

Discussion:
Describe the bug I'm getting from some Nix packages. /nix/store/8br3hnwahahpi4m3s9xjd34xn18bf1l4-source/pkgs/stdenv/generic/make- Here -Originated from: Is it because it should be Expected behavior No error nix-env version is 2.11.0 Additional context Add any other context about the problem here.
I ran into the same issue when I tried to use nix-darwin with flakes. The example was using an old version of nixpkgs-darwin. Changing it to use the latest version seemed to fix it. I made a PR to update the readme: LnL7/nix-darwin .
Same problem on OpenBSD The trace
Can be reproduced on linux with: ` Edit: The problem is in cc-native which seems to be rotted over time because we didn't add a new system for a longer time. The problem is that cc-native has not version attr. Trying to find a fix for that right now.
can you move this to nixpkgs?
Change:
in optional (driver != null) ({ inherit name; driverName = name; } // driver)); assertions = <del> [ { assertion = !(config.programs.ssh.startAgent && cfg.startGnuPGAgent); message = '' The OpenSSH agent and GnuPG agent cannot be started both. Please choose between ‘programs.ssh.startAgent’ and ‘services.xserver.startGnuPGAgent’. ''; } { assertion = config.security.polkit.enable; </del> <ins> [ { assertion = config.security.polkit.enable; </ins> message = "X11 requires Polkit to be enabled (‘security.polkit.enable = true’)."; } ];

Discussion:
Commit from updated the default version of the GNU Privacy Guard a.k.a. GPG to version 2.1. Unfortunately, this update broke the gpg-related tests of , , apparently because there is some subtle change in the behavior of the GPG 1.x compatibility layer (git-annex relies on rather than using gpg2 directly). To remedy that issue, I fixed to use version 2.0 in . This is no good solution, unfortunately, because now people who rely on `gnupg1' end up having a version of GnuPG 2.0 in their profile that cannot talk to the gpg-agent from version 2.1, which happens to be the one that's installed in the system by default. In it's current state, gpg1 does not work reliably in NIxOS. To work around this issue, I would suggest that we revert to version 2.0 until we've had time to figure out what exactly has changed between versions 2.1 and 2.0 and why this affects .
FYI: Another thing I came across, due to a broken clawsmail pgp, was that the handling of gpg-agent differs from version 2.0 . GnuPG 2.1 do not use GPGAGENTINFO anymore. Instead it search for the gpg-agent socket in
For now at least, setting GPGAGENTINFO to $ seems to make claws-mail work.
Change:
{ bash , buildFHSUserEnv , cacert <del> , coreutils </del> , git , runCommand , stdenv , lib <del> , fetchurl </del> , alsa-lib , dbus , expat

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: legacyPackages.x86_64-linux.flutter <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 2.2.1 desired version: 2.5.1 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Besides updating it we could setup a to easily auto update it
I opened , it's not easy to create the updateScript though, I can try adding later in another PR
Change:
sha256 = "0ix7xp352bziwz31mw79y7wxxmdn6060p8ry2px243ni1lz1qx1c"; }; <del> buildInputs = [ qtbase qtsvg ] </del> <ins> patches = [ # Cantata wants to check if perl is in the PATH at runtime, but we # patchShebangs the playlists scripts, making that unnecessary (perl will # always be available because it's a dependency) ./dont-check-for-perl-in-PATH.diff ]; postPatch = '' patchShebangs playlists ''; buildInputs = [ qtbase qtsvg perl' ] </ins> ++ lib.optionals withTaglib [ taglib taglib_extras ] ++ lib.optionals withReplaygain [ ffmpeg_3 speex mpg123 ] ++ lib.optional  withHttpStream qtmultimedia

Discussion:
Describe the bug When trying to start a dynamic playlist, the user is greeted by an error banner stating the following: To Reproduce Steps to reproduce the behavior: Cantata dynamic playlist to play dynamic playlist Expected behavior I expected Cantata to start the dynamic playlist. Screenshots ! Additional context This is likely fallout from perl's removal in However, this exposed something impure about Cantata's packaging, so it's a good thing! I tried simply patching the shebang to point to (as well as changing this condition to never return true: ), but to no avail. EDIT: Even adding to my does nothing -- when I click on the play button by the dynamic playlist, it turns to the red stop button, and then back to the play button without ever playing or queuing any songs. Seems like this might need more work. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
If you have the time to give it go, I think this should do the trick: And then add to .
Thanks for the tip. It was slightly more involved than that, but fixed in this PR:
Change:
systemd.services.tailscaled = { wantedBy = [ "multi-user.target" ]; path = [ <ins> (builtins.dirOf config.security.wrapperDir) # for `su` to use taildrive with correct access rights </ins> pkgs.procps     # for collecting running services (opt-in feature) pkgs.getent     # for `getent` to look up user shells pkgs.kmod       # required to pass tailscale's v6nat check

Discussion:
The newer command has a dependency on as can be observed with : In tailscale the relevant code is at An issue of another NixOS user on tailscale might get solved by this too: I would make a PR, but I believe that is a bit special and requires extra care, so I'd like to get a second opinion first.
That IS a special problem. Afaik provides , though it will not have it with the bit. On NixOS this is usually handled by , and on other distros this is usually baked into their package. This poses a problem since we'd need a reference to from outside of the context..
Yeah, so I was thinking of maybe solving this in the module instead. There we could use the wrapper... I would just add it to the PATH of the systemd service.
The su binaries with setuid bit lives in NixOS at `. So we probably want to add that path to the PATh variable.
Correct yeah. I don't think anything can or should be done about using this package on a non-nixos distro for now. It should resolve the PATH fine anyways as long as its FHS compliant
Change:
<del> diff --git a/transcrypt b/transcrypt index a0b562d..7888f5d 100755 --- a/transcrypt +++ b/transcrypt @@ -278,6 +278,7 @@ save_helper_scripts() { cat <<-'EOF' > "${GIT_DIR}/crypt/clean" #!/usr/bin/env bash +		PATH="$(transcrypt-depspathprefix 2>/dev/null)$PATH" filename=$1 # ignore empty files if [[ -s $filename ]]; then @@ -300,6 +301,7 @@ save_helper_scripts() { cat <<-'EOF' > "${GIT_DIR}/crypt/smudge" #!/usr/bin/env bash +		PATH="$(transcrypt-depspathprefix 2>/dev/null)$PATH" tempfile=$(mktemp 2> /dev/null || mktemp -t tmp) trap 'rm -f "$tempfile"' EXIT cipher=$(git config --get --local transcrypt.cipher) @@ -309,6 +311,7 @@ save_helper_scripts() { cat <<-'EOF' > "${GIT_DIR}/crypt/textconv" #!/usr/bin/env bash +		PATH="$(transcrypt-depspathprefix 2>/dev/null)$PATH" filename=$1 # ignore empty files if [[ -s $filename ]]; then @@ -351,7 +354,7 @@ save_configuration() { git config merge.renormalize 'true' # add a git alias for listing encrypted files -	git config alias.ls-crypt "!git ls-files | git check-attr --stdin filter | awk 'BEGIN { FS = ":" }; /crypt$/{ print $1 }'" +	git config alias.ls-crypt "!PATH="$(transcrypt-depspathprefix 2>/dev/null)$PATH"; git ls-files | git check-attr --stdin filter | awk 'BEGIN { FS = ":" }; /crypt$/{ print $1 }'" } # display the current configuration settings </del>

Discussion:
Package name: Latest released version: <!-- Search your package here: --- Current version on the unstable channel: Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR.
Change:
google_apputils = buildPythonPackage rec { name = "google-apputils-0.4.1"; <del> disabled = isPy3k; </del> src = pkgs.fetchurl { url = "mirror://pypi/g/google-apputils/${name}.tar.gz";

Discussion:
disables google apputils for python 3. I can't tell why, and based on a cursory check it seems to work fine on python 3 as well. ?
idk, maybe it was broken with older versions of python3?
fixed in
Change:
<del> { lib, stdenv ,fetchFromGitHub , zig, wayland, pkg-config, scdoc , xwayland, wayland-protocols, wlroots , libxkbcommon, pixman, udev, libevdev, libX11, libGL </del> <ins> { lib , stdenv , fetchFromGitHub , zig , wayland , pkg-config , scdoc , xwayland , wayland-protocols , wlroots , libxkbcommon , pixman , udev , libevdev , libX11 , libGL </ins> }: stdenv.mkDerivation rec {

Discussion:
Describe the bug Running river on nixos unstable results in this error: which is caused by this instruction: It is an , and i'm using AMD FX 6350, which only supports regular AVX It seems that zig basically uses something like by default, which is questionable to say at least. I couldn't find an easy way to fix it, so i will leave this as an issue. All other zig packages are possibly affected too, needs verification. To Reproduce Steps to reproduce the behavior: Expected behavior Doesn't use AVX2, build is reproducible. Notify maintainers Metadata Maintainer information:
What I have to do with it if it's not just river but Zig itself? You can ask zig maintainer (creator itself) about it. I will also ask community and river developers.
This is correct, zig builds for the current host by default. If a cross-compile should be performed, a target triple should be given () for example, assuming glibc/GNU abi is used. This is usually passed by to a build script or via on a normal build command line. The code here only builds for the local machine, so it might not be shared with other machines:
So one person on NixOS discord server suggested one simple solution. To eleminate problems like this, user will build river on own hardware, this will prevent problems like this to happen as pointed above Zig takes everything from host e.g libc, ABI, cpu architecture so building it on user's hardware will use those attrinutes according to their hardware, ABI amd libc. Building river doesn't take more then 20s at least on my old 2 core CPU and I don't think bulding it locally is big problem
This is exactly what the creator of the issue is pointing at as a problem, and the only good solution (at least in the Nix way) is to make all programs compiled with Zig target baseline x86_64 (or ultimately whichever features the Nixpkgs pipeline allows in C/C++ derivations) The idea of packaging with Nix is not just "being able to compile and done" but rather being able to compile deterministically.
Indeed, passing to is the correct solution here, and will produce a binary for baseline x86_64.

After the next zig release (planned for ~2 weeks from now) passing will be an even better way of doing this, allowing the target to be entirely detected from the host system and allowing specific cpu features to be enabled/disabled.
Change:
sha256 = "0rm32zsmxvr6b0jjihfj543skhicbw5kg6shjx312clhlm035w2x"; }; <del> nativeBuildInputs = [ cmake pkg-config ]; </del> <ins> nativeBuildInputs = [ cmake pkg-config wrapQtAppsHook ]; </ins> buildInputs = [ SDL2

Discussion:
Describe the bug It seems the package openmw (morrowind game engine) is missing dependencies, maybe Qt related. To Reproduce Install openmw and run or , you don't need Morrowind asset files to run them. Expected behavior A window is opened. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Change:
pyasn1-modules rsa six <ins> urllib3 </ins> ]; passthru.optional-dependencies = {

Discussion:
Build of failed on x86_64-linux as of . This is currently breaking . maintainers cc: maintainers cc: Other cc: n/a nixpkgs at commit Contents of : This issue was automatically generated by . that created this issue. Internal tags: -
Hmm I'm not quite sure if urllib3 should be to on or on
Change:
buildPythonPackage rec { pname = "sorl-thumbnail"; <del> version = "11.12"; </del> <ins> version = "12.5.0"; </ins> src = fetchPypi { inherit pname version; <del> sha256 = "050b9kzbx7jvs3qwfxxshhis090hk128maasy8pi5wss6nx5kyw4"; </del> <ins> sha256 = "8dfe5fda91a5047d1d35a0b9effe7b000764a01d648e15ca076f44e9c34b6dbd"; </ins> }; # Disabled due to an improper configuration error when tested against django. This looks like something broken in the test cases for sorl.

Discussion:
Ran . For some reason there are pylint tests running for ~8 minutes that eventually end up in a failure. <details<summaryPyLint test failures</summary</detailson pylint (indirectly?); running for ~10 minutes as part of package installation process.
This will need to be backported to 18.09 as the latest version released by Hydra is broken too
The tests still fails even after the above patch applied. <details<summaryHere is the log</summary</detailsHere is the patch I used: Edit: the original patch is working on the python-unstable branch so I guess it's OK
I pushed a fix to the branch: . The fix for is currently in the branch: .
Change:
''; }; <del> graphite-cli = prev."@withgraphite/graphite-cli".override (old: { name = "graphite-cli"; nativeBuildInputs = with pkgs; [ installShellFiles pkg-config ]; buildInputs = with pkgs; [ cairo pango pixman ]; # 'gt completion' auto-detects zshell from environment variables: # https://github.com/yargs/yargs/blob/2b6ba3139396b2e623aed404293f467f16590039/lib/completion.ts#L45 postInstall = '' installShellCompletion --cmd gt  --bash <($out/bin/gt completion)  --zsh <(ZSH_NAME=zsh $out/bin/gt completion) ''; meta = old.meta // { license = lib.licenses.unfree; # no license specified }; }); </del> graphql-language-service-cli = prev.graphql-language-service-cli.override { nativeBuildInputs = [ pkgs.buildPackages.makeWrapper ]; postInstall = ''

Discussion:
Package name: Grahpite-cli Latest released version: 1.1.1 <!-- Search your package here: --- Current version on the unstable channel: 1.0.9 Current version on the stable/release channel: 1.0.9 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. This package has no maintainer because it is a NPM package. might be related? Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hello thanks for the request, I will try to go from node2nix to build from source as the issue linked suggestes
Giving a quick check to the graphite-cli repo linked in the npm package it is archived and "moved to your mono-repo" and also it is built with yarn so nor it can migrated to buildNpmPackage nor to building from source, so my guess is that it will need to still in node2nix
Please make a PR marking the package as unfree since their monorepo isn't publicly available.
As of right now graphite-cli is already unfree
Change:
github = "sei40kr"; githubId = 11665236; }; <ins> seineeloquenz = { name = "Alexander Linder"; github = "SeineEloquenz"; githubId = 34923333; }; </ins> seirl = { name = "Antoine Pietri"; email = "antoine.pietri1@gmail.com";

Discussion:
Project description Televido (“Television” in Esperanto) lets you livestream, search, play and download media from German-language public television services. It is powered by 's API and the API which are both part of the project. <!-- Describe the project a little: --Metadata homepage URL: source URL: license: GPL-3.0 platforms: linux Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
}; pythonRelaxDeps = [ <ins> "flask" </ins> "requests" <ins> "yt-dlp" </ins> ]; nativeBuildInputs = [

Discussion:
Steps to reproduce the behavior: Add any other context about the problem here. There are no maintainers at the moment. touched it last. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Those are not really relevant, since I built it on my clone of nixpkgs on the master branch. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<del> { lib, buildPythonPackage, fetchFromGitHub , pytestCheckHook, pyhamcrest, pytestrunner , six, isodate, tornado, aenum, radish-bdd, mock </del> <ins> { lib , buildPythonPackage , fetchFromGitHub , aenum , importlib-metadata , isodate , six , tornado , pytestCheckHook , mock , pyhamcrest , radish-bdd </ins> }: buildPythonPackage rec {

Discussion:
Describe the bug gremlinpython (a dependency of cassandra-driver, but otherwise no idea how important it is) fails to build. To Reproduce Steps to reproduce the behavior: a recent checkout of nixpkgs -build -I nixpkgs=. -p python3Packages.gremlinpython how attempts to fetch something from the interwebs Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(cmm): nixpkgs: Maintainer information:
Should be fixed by .
Change:
, cudatoolkit , libdrm , ncurses <ins> , nvtop , testers , udev </ins> , addOpenGLRunpath , amd ? true , nvidia ? true <del> , udev </del> }: let pname-suffix = if amd && nvidia then "" else if amd then "-amd" else "-nvidia"; nvidia-postFixup = "addOpenGLRunpath $out/bin/nvtop"; <del> libPath = lib.makeLibraryPath [ libdrm ncurses ]; </del> <ins> libPath = lib.makeLibraryPath [ libdrm ncurses udev ]; </ins> amd-postFixup = '' patchelf  --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" 

Discussion:
When running , I get Restarting the system did not help. Steps to reproduce the behavior: The program should launch without crashing. If applicable, add screenshots to help explain your problem.
Hello Thanks for reporting this issue, and sorry for breaking the nvtop package! I made a pull-request to fix nvtop: What do you think about this fix?
Thank you for your fast reaction ! The PR looks good to me. I hope it will get merged soon :)