jiebi/CodeConvo huggingface dataset:
Change:
attrsToText = attrs: concatStringsSep "n" ( mapAttrsToList (n: v: ''${n}=${escapeIfNeccessary (toString v)}'') attrs <del> ); </del> <ins> ) + "n"; </ins> osReleaseContents = { NAME = "NixOS";

Discussion:
The file generated for nixos is not compatible with the R programming language's interpreter (). On startup, the R interpreter prints the following warning (though it does continue as normal after printing the warning): This could be resolved by adding a trailing newline to . Steps to reproduce the behavior: the R interpreter by running , or if you don't have R installed. No error message should be printed. I'm not entirely sure whether this should be resolved adding the trailing newline to , or whether R should be modified so it doesn't assume a trailing newline. The man page for describes the format of the file as "a newline-separated list of environment-like shell-compatible variable assignments". The existing format (no trailing newline) is indeed newline-separated and shell-compatible (bash and zsh both have no problems with it), so maybe I should bring this up with the R folks instead? On the other hand, all the other distros I've checked (ubuntu, archlinux, and alpine) include a trailing newline, so maybe we should just stick to what they're doing? The fix is trivial: Let me know what you think, and I'd be happy to open a PR wherever we decide the fix should be made. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
This! It shouldn’t be needed and yet here we are. No harm in doing so that though, so I’m all for this. Sounds great!
Change:
<del> { lib , stdenv , buildPythonPackage , fetchFromGitHub , setuptools }: buildPythonPackage rec { pname = "py-tree-sitter"; version = "0.20.4"; format = "pyproject"; src = fetchFromGitHub { owner = "tree-sitter"; repo = "py-tree-sitter"; rev = "refs/tags/v${version}"; hash = "sha256-R97WcsHQMcuEOCg/QQ9YbGTRD30G9PRv0xAbxuoFyC4="; fetchSubmodules = true; }; nativeBuildInputs = [ setuptools ]; pythonImportsCheck = [ "tree_sitter" ]; meta = with lib; { homepage = "https://github.com/tree-sitter/py-tree-sitter"; description = "Python bindings for tree-sitter"; license = licenses.mit; maintainers = with maintainers; [ siraben ]; platforms = platforms.unix; }; } </del>

Discussion:
The packages and are duplicates. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
, qtdeclarative , qtmultimedia , qtsvg <del> , qttools </del> , quazip }:

Discussion:
MediaElch works correctly, except it cannot load StreamDetails. In About/Developer, it complains about not finding Steps to reproduce the behavior: or add it in MediaElch and scan some files to «Stream details» tab and try to «load from files» (3bis) You can also open About/Developer modal to see the message about the missing module. MediaElch should find libmediainfo and be able to use it to get info from media. ! NixOS 21.11 with Gnome/Wayland Thanks in advance !
As found by in it works perfectly with
Change:
sha256 = "0z0jxm6ppbxi9anv2h12nrb5lpwl95f96kw6dx7sn268fhkpad7x"; }; <del> configureFlags = optional stdenv.isFreeBSD ''WARN_CFLAGS=""''; </del> <ins> configureFlags = [ "--with-tcl=no" ] ++ optional stdenv.isFreeBSD ''WARN_CFLAGS=""''; </ins> nativeBuildInputs = [ pkgconfig perl yacc ] # Provides the mig command used by the build scripts

Discussion:
libkrb5 (which is a rather central package in the dependency tree, unfortunately) fails to compile on Debian. That's because the system installation of tcl is (but cannot) be used: (this repeats hundreds of times) E.g. or or System: /etc/debian_version: 8.5 Nix version: nix-env (Nix) 1.11.2 Nixpkgs version: (this command fails to run for me)
triage: does it still fail?
Change:
'' + (if stdenv.hostPlatform.parsed.kernel.execFormat.name == "elf" then '' patchelf --set-soname liblapack${canonicalExtension} $out/lib/liblapack${canonicalExtension} patchelf --set-rpath "$(patchelf --print-rpath $out/lib/liblapack${canonicalExtension}):${lapackProvider}/lib" $out/lib/liblapack${canonicalExtension} <del> '' else if stdenv.hostPlatform.isDarwin then '' install_name_tool -id liblapack${canonicalExtension}  -add_rpath ${lib.getLib lapackProvider}/lib  $out/lib/liblapack${canonicalExtension} </del> '' else "") + '' if [ "$out/lib/liblapack${canonicalExtension}" != "$out/lib/liblapack${stdenv.hostPlatform.extensions.sharedLibrary}" ]; then

Discussion:
Describe the bug See It appears numpy is failing on darwin cc
I believe this one is before was merged. The new failure is: cc
I don't see a .so being explicitly referenced in the nix expression, there's probably something that needs to be patched for darwin to look for the correct shared-library extension.
This was , specifically the installnametool invocations.
Change:
in runCommand "${nameVersion.name}-multi-${nameVersion.version}" # out as the first output is an exception exclusive to glibc <del> { outputs = [ "out" "bin" "dev" ]; } # TODO: no static version here (yet) </del> <ins> { outputs = [ "out" "bin" "dev" ];  # TODO: no static version here (yet) passthru = { libgcc = lib.lists.filter (x: x!=null) [ (glibc64.libgcc or null) (glibc32.libgcc or null) ]; }; } </ins> '' mkdir -p "$out/lib" ln -s '${glibc64.out}'/lib/* "$out/lib"

Discussion:
the error has changed to any ideas? perhaps a issue here
Investigating...
Well this will get you back to where you were before: See if you can nudge it a bit further; if not I can work on this again tomorrow or Monday.
Change:
meta = with lib; { description = "PyDev.Debugger (used in PyDev, PyCharm and VSCode Python)"; <del> mainProgram = "pydevd"; </del> homepage = "https://github.com/fabioz/PyDev.Debugger"; license = licenses.epl10; maintainers = with maintainers; [ onny ]; <ins> mainProgram = "pydevd"; </ins> }; }

Discussion:
Steps to reproduce the behavior: Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I started with but unfortunately there is more to do.
Change:
owner = "renpy"; repo = "renpy"; rev = version; <del> hash = "sha256-07Hj8mJGR0+Pn1DQ+sK5YQ3x3CTMsZ5h5yEoz44b2TM="; </del> <ins> hash = "sha256-k8mcDzaFngRF3Xl9cinUFU0T9sjxNIVrECUguARJVZ4="; </ins> }; nativeBuildInputs = [

Discussion:
Package name: renpy Latest released version: 8.3.2 <!-- Search your package here: --- Current version on the unstable channel: 8.2.1. Current version on the stable/release channel: 8.2.1. <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
exec ${lib.getExe steam-run} bash "$@" ''; }) <ins> # Revert vendored vdf since our vdf includes `appinfo.vdf` v29 support (fetchpatch2 { url = "https://github.com/Matoking/protontricks/commit/4198b7ea82369a91e3084d6e185f9b370f78eaec.patch"; revert = true; hash = "sha256-1U/LiAliKtk3ygbIBsmoavXN0RSykiiegtml+bO8CnI="; }) # Fix test_run_no_args test (fetchpatch2 { url = "https://github.com/Matoking/protontricks/commit/ff2381ad379a612e73f0d4604f1c9c3a012b3355.patch"; hash = "sha256-aiafLbiqS6TBBiQpfTYPVqhQs2OXYg/4yCtbuTv6Ug8="; }) </ins> ]; nativeBuildInputs = [ setuptools-scm ];

Discussion:
Package name: protontricks Latest released version: 1.12.0 <!-- Search your package here: --- Current version on the unstable channel: 1.11.1 Current version on the stable/release channel: 1.11.1 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Solves the following bug / problem Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
''} # Miscellaneous options ignoreip    = 127.0.0.1/8 ${optionalString config.networking.enableIPv6 "::1"} ${concatStringsSep " " cfg.ignoreIP} <del> maxretry    = 3 </del> <ins> maxretry    = ${toString cfg.maxretry} </ins> backend     = systemd # Actions banaction   = ${cfg.banaction}

Discussion:
Describe the bug when configured to use ipset actions fail2ban fails to ban because the action script cannot find the ipset binary. To Reproduce Steps to reproduce the behavior: configure fail2ban to use actions, then cause a ban (eg invalid ssh logins) Expected behavior iptables rules and ipsets for the ban are created. Screenshots Additional context Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
The fail2ban derivation doesn't bring in ipset, it's also going to need some patching of the fail2ban conf files. Need to research if ipset protocol 6 is availble in nixpkgs, ipset v4 does seem to exist.
unstable has ipset 7.11, 20.03 has ipset 7.5, 20.09 has ipset 7.6. all of those should be protocol version 7 and thus work with the v6 actions i think?
fwiw adding ipset to the fail2ban service path in seems sufficient to get this to work.
In ! lets see if the practise matches up! :-) wow, you joined github 2 days ago... welcome to github!
we've applied that setting locally and so far haven't seen any problems across quite a few restarts and ban/unban actions. seems good! :)
what would be a good way to solve this for the next person? there's two things we could think of: add ipset to path when using iptables as the firewall backend (like sshguard does) extend firewallPackage to firewallPackages and let people who want ipset add it there second one sounds cleaner, not least because using nftables already requires changing firewallPackage. that would require deprecating firewallPackage though, and i don't feel qualified to do that
is extra packages the way to go? ipset is needed by fail2ban, so should it be a dependency by default? I've been flat out working so not had time to look at this. These are just questions not demands!
ipset isn't needed by the default configuration of fail2ban, only if you choose a different ban action.

if the default action and ipset were the only options i'd totally agree that ipset should be a dependency, but there's quite a few more actions: some send mail, some call into shorewall, or curl something to cloudflare, or even call into BIND to update a dns zone. since we'd need some extraPackages mechanism to support those properly anyway it didn't feel quite right to elevate one action to default-dependency and leaving out all the others (especially since nftables doesn't even need ipset to provide the same functionality). but i've got no feelings on this. if y'all want ipset to be a default dependency i'm perfectly fine doing that instead. would very much like to keep extraPackages though for the stated reasons.
Change:
<ins> diff --git a/extension.js b/extension.js index 26561f2..01209e7 100644 --- a/extension.js +++ b/extension.js @@ -1,3 +1,5 @@ +imports.gi.GIRepository.Repository.prepend_search_path('@gsound@/lib/girepository-1.0') +imports.gi.GIRepository.Repository.prepend_search_path('@libgda@/lib/girepository-1.0') try { </ins>

Discussion:
Project description Next-gen Clipboard Manager for Gnome Shell Metadata homepage URL: source URL: license: gpl2 platforms: linux
Change:
{ x86_64-linux = fetchurl { url = "${base}/v${version}/ArmCord_${version}_amd64.deb"; <del> hash = "sha256-6zlYm4xuYpG+Bgsq5S+B/Zt9TRB2GZnueKAg2ywYLE4="; </del> <ins> hash = "sha256-9AcxqCxhLAjYclaw6lri06R0PgQQeRHTbLJLEdhDCWU="; </ins> }; aarch64-linux = fetchurl { url = "${base}/v${version}/ArmCord_${version}_arm64.deb"; <del> hash = "sha256-HJu1lRa3zOTohsPMe23puHxg1VMWNR2aOjDQJqc4TqE="; </del> <ins> hash = "sha256-/uk2slpNF1sSTW6z319Yg9yx/s45fJPvJQJpY11ULVw="; </ins> }; }.${stdenv.hostPlatform.system} or (throw "Unsupported system: ${stdenv.hostPlatform.system}");

Discussion:
Package name: Armcord Latest released version: 3.2.6 <!-- Search your package here: --- Current version on the unstable channel: 3.2.5 Current version on the stable/release channel: 3.2.5 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Looks like you submitted it moments before I was about to click send on my PR and came to copy the issue number :smile:
Change:
buildInputs = [ boost cairo freetype gdal harfbuzz icu libjpeg libpng libtiff <del> libwebp libxml2 proj python sqlite zlib </del> <ins> libwebp proj python sqlite zlib </ins> # optional inputs postgresql ]; <ins> propagatedBuildInputs = [ libxml2 ]; </ins> prefixKey = "PREFIX="; preConfigure = '' patchShebangs ./configure ''; <ins> # NOTE: 2021-05-06: # Add -DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1 for backwards compatibility # with major versions 6 and 7 of proj which are otherwise not compatible # with mapnik 3.1.0. Note that: # # 1. Starting with proj version 8, this workaround will no longer be #    supported by the upstream proj project. # # 2. Without the workaround, mapnik configures itself without proj support. # # 3. The master branch of mapnik (after 3.1.0) appears to add native support #    for the proj 6 api, so this workaround is not likely to be needed in #    subsequent mapnik releases. At that point, this block comment and the #    NIX_CFLAGS_COMPILE expression can be removed. NIX_CFLAGS_COMPILE = if version != "3.1.0" && lib.versionAtLeast version "3.1.0" then throw "The mapnik compatibility workaround for proj 6 may no longer be required. Remove workaround after checking." else if lib.versionAtLeast (lib.getVersion proj) "8" then throw ("mapnik currently requires a version of proj less than 8, but proj version is: " + (lib.getVersion proj)) else "-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1"; </ins> configureFlags = [ "BOOST_INCLUDES=${boost.dev}/include" "BOOST_LIBS=${boost.out}/lib"

Discussion:
Describe the bug No Proj support in python-mapnik To Reproduce Steps to reproduce the behavior: Expected behavior It seems that all the Proj machinery is in place, Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Notify maintainers Metadata Maintainer information:
I marked this as stale due to inactivity. &rarr;
Change:
<ins> { corretto11 , fetchFromGitHub , gradle_7 , jdk11 , lib , stdenv , rsync , runCommand , testers }: let corretto = import ./mk-corretto.nix { inherit lib stdenv rsync runCommand testers; jdk = jdk11; gradle = gradle_7; version = "11.0.20.9.1"; src = fetchFromGitHub { owner = "corretto"; repo = "corretto-11"; rev = "b880bdc8397ec3dd6b7cd4b837ce846c9e902783"; sha256 = "sha256-IomJHQn0ZgqsBZ5BrRqVrEOhTq7wjLiIKMQlz53JxsU="; }; }; in corretto.overrideAttrs (oldAttrs: { # jdk11 is built with --disable-warnings-as-errors (see openjdk/11.nix) # because of several compile errors. We need to include this parameter for # Corretto, too. Since the build is invoked via `gradle` build.gradle has to # be adapted. postPatch = oldAttrs.postPatch + '' for file in $(find installers -name "build.gradle"); do substituteInPlace $file --replace "command += archSpecificFlags" "command += archSpecificFlags + ['--disable-warnings-as-errors']" done ''; }) </ins>

Discussion:
Project description <!-- Describe the project a little: --Amazon Coretto JDK Metadata homepage URL: source URL: license: GPL 2.0 platforms: linux (and all else if possible)
Change:
assert withHost._module.args.pkgs.stdenv.buildPlatform.system == "aarch64-linux"; assert withHostAndBuild._module.args.pkgs.stdenv.hostPlatform.system == "aarch64-linux"; assert withHostAndBuild._module.args.pkgs.stdenv.buildPlatform.system == "aarch64-darwin"; <ins> assert withSameHostAndBuild.config.nixpkgs.buildPlatform == withSameHostAndBuild.config.nixpkgs.hostPlatform; assert withSameHostAndBuild._module.args.pkgs.stdenv.buildPlatform == withSameHostAndBuild._module.args.pkgs.stdenv.hostPlatform; </ins> assert builtins.trace (lib.head (getErrors ambiguous)) getErrors ambiguous == [''

Discussion:
A clear and concise description of what the bug is. When a nixos configuration has and both set to the same string, the module defined always determines that the system is cross-compiled, even when it should not be. Steps to reproduce the behavior: a nixos config with the example configuration: building and notice that the entire world gets rebuilt since it tries to build cross-compilation toolchains A clear and concise description of what you expected to happen. I would expect that the module would determine I am not cross-compiling the nixos system and build accordingly. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
maintainers = with maintainers; [ peterhoeg ]; platforms = with platforms; linux; }; <del> } </del> <ins> }) </ins>

Discussion:
Steps to reproduce the behavior: kdiff3 Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
ln -sr '${unwrapped}/share' "$out"/ ln -sr '${unwrapped}/lib'   "$out"/ # useful in NixOS service ln -sr "$out"/{bin,sbin} <ins> '' + lib.optionalString unwrapped.doInstallCheck '' </ins> echo "Checking that 'http' module loads, i.e. lua search paths work:" echo "modules.load('http')" > test-http.lua echo -e 'quit()' | env -i "$out"/bin/kresd -a 127.0.0.1#53535 -c test-http.lua <del> ''; </del> <ins> ''); </ins> in result

Discussion:
: Then: In case you need the : This seems to be caused by the , which is enabled with the . is set so it's probably not just a simple binary incompatibility (I believe it shouldn't be necessary when setting both and but it appears the scripts generating the images expect to be run from the target). (thanks!) system: host os: multi-user?: sandbox: version: channels(root): (flake, see ) nixpkgs:
Yeah, well runtime tests like aren't really what "we" normally want to do when cross-compiling.
This?
Yeah, the image builds and the service starts. Thanks!
Change:
whitesur-icon-theme = callPackage ../data/icons/whitesur-icon-theme { }; <del> whitesur-kde = libsForQt5.callPackage ../data/themes/whitesur-kde { }; </del> <ins> whitesur-kde = kdePackages.callPackage ../data/themes/whitesur-kde { }; </ins> wireless-regdb = callPackage ../data/misc/wireless-regdb { };

Discussion:
When installing the package and rebooting the desktop takes longer to load then usual and then only displays a black screen even without selecting the whitesur theme. Opening applications e.g. via shortcuts still works. I am new to nix so please wirte if further information is needed. Steps to reproduce the behavior: whitesur-kde package in the your nix configuration Desktop works as expected ! My current configuration: <details</summary</details<details</summary</details<details</summary</details<details</summary</detailsjournctl log: <details<summaryjournalctl</summary</details<!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
can you review , please?
Change:
hyena = callPackage ../development/libraries/hyena { }; icu = callPackage ../development/libraries/icu { }; <del> icu_54_1 = callPackage ../development/libraries/icu/54.1.nix { }; </del> id3lib = callPackage ../development/libraries/id3lib { };

Discussion:
The icu541 package fails to compile at the patching step. Some of the patches issue warnings, others fail completely. Install icu541: . The build process will fail. System: NixOS: 16.09 Nix version: 1.11.4 Nixpkgs version: 16.09.1202.
Change:
prefixLength = 24; } ]; }); <del> in { key = "ip-address"; config = </del> <ins> networkConfig = </ins> { networking.hostName = mkDefault m.fst; networking.interfaces = listToAttrs interfaces;

Discussion:
Describe the bug introduced a change that breaks NixOps. When we have a test, something like this will be detected faster and not depend on users running into an issue. That would increase the quality. To Reproduce Steps to reproduce the behavior: nixops complain :grimacing:
I marked this as stale due to inactivity. &rarr;
Tests would still be nice. has been more broken than I expected...
I marked this as stale due to inactivity. &rarr;
Change:
distributed ]; <del> doCheck = false; </del> <ins> doCheck = true; </ins> checkInputs = [ pytestCheckHook

Discussion:
Describe the bug For sandboxed builds on my mac, any python tests which ultimately import will fail with this error: To Reproduce Somewhat tricky to reproduce since it only affects downstream dependees, and a recent commit disabled the dask tests, hiding this issue. See for an example. Additional context Dask.dataframes infers an optimal chunk size using a package to get the amount of available memory and CPUs. This non-determinism breaks the build. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --cc Metadata This is not valid since I am building from master of nixpkgs. system: host os: multi-user?: sandbox: version: channels(noah): nixpkgs: Maintainer information:
That's a clear upstream bug; apparently their value is not given.