jiebi/CodeConvo huggingface dataset:
Change:
-e s,/usr/share/locale,/run/current-system/sw/share/locale,g  {} + <del> sed "s|/usr/share/sounds|/run/current-system/sw/share/sounds|g" -i ./files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py sed "s|'python3'|'${pythonEnv.interpreter}'|g" -i ./files/usr/share/cinnamon/cinnamon-settings/bin/CinnamonGtkSettings.py sed "s|/usr/bin/cinnamon-screensaver-command|/run/current-system/sw/bin/cinnamon-screensaver-command|g"  -i ./files/usr/share/cinnamon/applets/menu@cinnamon.org/applet.js -i ./files/usr/share/cinnamon/applets/user@cinnamon.org/applet.js sed "s|"/usr/lib"|"${cinnamon-control-center}/lib"|g" -i ./files/usr/share/cinnamon/cinnamon-settings/bin/capi.py sed 's|"lspci"|"${pciutils}/bin/lspci"|g' -i ./files/usr/share/cinnamon/cinnamon-settings/modules/cs_info.py </del> <ins> # All optional and may introduce circular dependency. find ./files/usr/share/cinnamon/applets -type f -exec sed -i  -e '/^#/!s,/usr/bin,/run/current-system/sw/bin,g'  {} + </ins> <del> sed "s| cinnamon-session| ${cinnamon-session}/bin/cinnamon-session|g" -i ./files/usr/bin/cinnamon-session-cinnamon  -i ./files/usr/bin/cinnamon-session-cinnamon2d </del> <ins> pushd ./files/usr/share/cinnamon/cinnamon-settings substituteInPlace ./bin/capi.py                     --replace '"/usr/lib"' '"${cinnamon-control-center}/lib"' substituteInPlace ./bin/CinnamonGtkSettings.py      --replace "'python3'" "'${pythonEnv.interpreter}'" substituteInPlace ./bin/SettingsWidgets.py          --replace "/usr/share/sounds" "/run/current-system/sw/share/sounds" substituteInPlace ./bin/Spices.py                   --replace "msgfmt" "${gettext}/bin/msgfmt" substituteInPlace ./modules/cs_info.py              --replace "lspci" "${pciutils}/bin/lspci" popd </ins> <del> sed "s|msgfmt|${gettext}/bin/msgfmt|g" -i ./files/usr/share/cinnamon/cinnamon-settings/bin/Spices.py </del> <ins> sed "s| cinnamon-session| ${cinnamon-session}/bin/cinnamon-session|g" -i ./files/usr/bin/cinnamon-session-{cinnamon,cinnamon2d} </ins> patchShebangs src/data-to-c.pl '';

Discussion:
To reproduce, here is an example: The related code is at Some nice to have: As suggested  should be something that can be accessible by everything and we are likely going to put our "" there and next we are going to import in basically every file. Adding to in is probably not a good idea since this is a desktop shell package you will end up having this variable everywhere, I imagine a treewide will be likely needed.
Change:
# Must match version 4 times to ensure client and server git commits and versions are correct docker.succeed('[ $(docker version | grep ${pkgs.docker.version} | wc -l) = "4" ]') <ins> docker.succeed("systemctl restart systemd-sysctl") docker.succeed("grep 1 /proc/sys/net/ipv4/conf/all/forwarding") docker.succeed("grep 1 /proc/sys/net/ipv4/conf/default/forwarding") </ins> ''; })

Discussion:
Describe the bug Upon enabling docker via sysctl.d is not updated to allow IP forwarding which is required by containers to communicate with outside world. To Reproduce Steps to reproduce the behavior: This will get up and running with set to which in my understanding is set by the itself. to re-apply system-wide sysctl settings and check By now your bridge-mode docker containers lost connectivity. Expected behavior I expect to override relevant values. Something like this: Additional context I discovered this problem when applying other sysctl values on a running system without a reboot. Notify maintainers Metadata
Hi, I stumbled into the same issue. I had to manually run to regain container internet access.
Change:
mutesync = callPackage ../development/python-modules/mutesync { }; <ins> mutf8 = callPackage ../development/python-modules/mutf8 { }; </ins> mwclient = callPackage ../development/python-modules/mwclient { }; mwdblib = callPackage ../development/python-modules/mwdblib { };

Discussion:
Project description A project to process MUTF-8 encoded strings. MUTF-8 is a modification of UTF-8 that allows using Unicode characters, while still being able to manipulate strings as a C-style NULL terminated string. This format is used in Java class files: as well as Android Dalvik: Metadata homepage URL: source URL: license: MIT platforms: Linux, Python
Change:
<del> { lib, fetchurl, appimageTools, pkgs }: </del> <ins> { lib, fetchurl, appimageTools, pkgs, makeWrapper }: </ins> let pname = "beekeeper-studio";

Discussion:
A few electron applications do not use environment variable to change settings. This causes a black screen when using these packages on wayland. Packages I have found not to work: postman beekeeper-studio This was made known to me by on Discord. Steps to reproduce the behavior: Black screen. ! ! A temporary work around is to run the application with the flag. I will work on this myself. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
If any other packages are exhibiting this behavior please let me know on this issue.
Package also seems to not respect the env
Can confirm, I'll create a new pr.
Sorry for taking so long, stuff happened
Ferdium also does not respect the env (and I assume Ferdi and Franz by looking at their sources).
For some reason the following is not working: But this is: I do have both NIXOSOZONEWL and WAYLANDDISPLAY set.
Change:
runHook postInstall ''; <del> outputHashAlgo = "sha256"; outputHashMode = "recursive"; outputHash = "07iv4jangqnzrvjr749vl3x31z7dxds51bq1bhz5acbjbwf25wjf"; </del> meta = with stdenv.lib; { description = "A flat and light theme with a modern look"; homepage = "https://github.com/EliverLara/${themeName}";

Discussion:
Describe the bug While building ant-theme 3.0 with latest master the following error occurs: To Reproduce Steps to reproduce the behavior: ant-theme Expected behavior builds Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata system: host os: multi-user?: sandbox: version: channels(maciej): channels(root): nixpkgs: Maintainer information:
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Change:
for p in $out/dev_bundle/mongodb/bin/mongo{,d}; do patchelf  --set-interpreter $(cat $NIX_CC/nix-support/dynamic-linker)  <del> --set-rpath "$(patchelf --print-rpath $p):${lib.makeLibraryPath [ stdenv.cc.cc zlib ]}"  </del> <ins> --set-rpath "$(patchelf --print-rpath $p):${lib.makeLibraryPath [ stdenv.cc.cc zlib curl xz ]}"  </ins> $p done

Discussion:
For some older project I need to run meteor (was pretty cool back then), which thinks it's extra special and downloads dependencies on it's own, which are not correctly set up in the : Steps to reproduce the behavior: (optional, for reproducibility) set up clean environment inside : example meteor app: meteor: I figured out how to do this manually: (in addition to curl, it needs ) ... this works, but I have no idea how to properly do this :shrug:
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Adding curl and lzma to may fix it
Thanks for the tip! I've tried it, but it doesn't seem to help - until I figured I also need to add it to the patching script's library path - now it works :tada: PR:
Change:
pyfiglet pyperclip pyyaml <del> six </del> urwid wcwidth yamale

Discussion:
python-fx fails at runtime, while doing its initial imports. Steps to reproduce the behavior: (hash is of as-of-writing nixpkgs-unstable) pyfx tui opens. Doesn't happen when e.g. installing current python-fx with pip on arch linux. (I considered packaging instead, but only found more breakage there. Anyway, I wouldn't be terribly sad if the answer to this is "Package abandonned, will be removed".) Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I have not used the TUI as so far only served as dependency for . Looks like
I poked around and I don't think that's the same issue at all. (It's the same cause, an old generated file is lying around, but it's a different old generated file.) The prePatch is pretty fishy, it first removes the antlr-related files and then invokes antlr. Fixing that runs into a few type errors, which can be fixed: Now you'd think those type errors are due to the new antler version, but that's only partially true? Downgrading still requires some patching. If I have time I'll submit a PR fixing this, but just patching out the type checks from the feels wrong, so I might consult with upstream first.
Change:
binwalk = callPackage ../development/python-modules/binwalk { pyqtgraph = null; <ins> matplotlib = null; </ins> }; binwalk-full = appendToName "full" (self.binwalk.override { pyqtgraph = self.pyqtgraph; <ins> matplotlib = self.matplotlib; </ins> }); bitmath = callPackage ../development/python-modules/bitmath { };

Discussion:
To Reproduce Steps to reproduce the behavior: [nix-shell:~/Downloads]$ binwalk -E WARNING: Failed to import matplotlib module, visual entropy graphing will be disabled DECIMAL HEXADECIMAL ENTROPY
0 0x0 Rising entropy edge (0.) [nix-shell:~/Downloads]$ nix-shell -p nix-info --run "nix-info -m" system: host os: multi-user?: sandbox: version: channels(asbachb): channels(root): nixpkgs: yaml attribute: python38Packages.binwalk-full python38Packages.binwalk module:
Opened fixing this, PTAL.
Change:
sha256 = "sha256-0dtLev4JjeHsS259+qOgg19rz4yjkeX4D3ooUgS4RTI="; name = "smartmontools-drivedb.h"; }; <ins> scriptPath = lib.makeBinPath ([ gnused ] ++ lib.optional enableMail [ inetutils mailutils ]); </ins> in stdenv.mkDerivation rec {

Discussion:
I noticed that was failing to run warning scripts after enabling it. This appears to be caused by : Steps to reproduce the behavior: in status of smart with : successfully generated a notification. I tried to fix this in in smartmontools stops hardcoding PATH if you specify . This can be done when is false. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Maybe you need ? I use this config and do get notifications (by email at least -- the machine is now headless so I don't know about the x11 notifications): And I don't have "sed: command not found" in my system log.
Do you have the set to true for  (or , which also overrides it for )? is correctly specified in that case. Is set in ? It should be located in .
I don't have in my (Unless it's being set indirectly via some other option.) I happen to have other smartmontools store paths on this machine (because it's a binary cache for my machines), with different PATH=:
Unfortunately I'm still seeing this after : This is what my looks like (the environment variables are set by overriding : I have set to false. only fixes the script bin path if is true (as far as I can tell).
Sorry I didn't see your comment on the original PR. should fix it for you.
Thanks!
Change:
DateManip DBI DBDmysql LWP SysMmap # run-time dependencies not checked at build-time ClassStdFast DataDump DeviceSerialPort JSONMaybeXS LWPProtocolHttps NumberBytesHuman SysCPU SysMemInfo TimeDate <ins> CryptEksblowfish DataEntropy # zmupdate.pl </ins> ]); nativeBuildInputs = [ cmake makeWrapper pkgconfig ];

Discussion:
Zoneminder, but it seems there is no code that handles upgrades, while that is provided by upstream and for example the Ubuntu packaging. It seems to be more of a developer preview version on NixOS than something that could be used by end-users in a production environment. I would have a flag like that needs to be set to true before it does something for that reason. I welcome the progress that has been made, but it doesn't appear to be in good enough shape to compete with other solutions. I will open another issue for adding declarative camera support (), because there was another user who also wanted to have that, which should also make this issue smaller.
Looking at zoneminder_1.30.4+dfsg- in debian/TODO.Debian it says: and there is no mention of the in the scripts. Are you sure Ubuntu has support for this? My personal opinion is that automatic upgrades are not such a great thing. While there are provided migrations to upgrade the database, there doesn't seem to be an official way to downgrade. This conflicts with the nature of Nix where we expect seamless version changes in any direction. Having user manually run ensures that they are aware of the upgrade and prepared for consequences.
has recently changed, but I have seen it upgrade automatically and there was at some point some code for doing it automatically. The manual part here only seems to be the ppa configuration. The main point is that the effort required on Ubuntu is less than on NixOS.
Yes, I see that this PPA with an unofficial zoneminder package (from Ubuntu standpoint) does indeed run in its zoneminder.postinst script.
I wasn't aware of this issue until just now, hence the rather late reply. That is correct - so far we have only released a single version in nixpkgs but of course it will come back and bite us. Things can break in unstable - nothing new there and unless we hit security issues, new versions will not be back-ported, so that at least gives us to 19.09 to sort out. What other options (packaged for NixOS) do we have? I personally have very strong reservations about the architectural choices the ZM developers have made, but I am not aware of any real alternative ATM. Declarative camera support is definitely a good idea.

I support for ZM because I needed it and it solves my problem right now (until we need to update of course), but any PR would be very much welcome.
The is already part of the package - we just don't do anything with it and according to the comment in the header: But then of course it does have functionality for dealing with a number of changes. So the short version - someone just has to write (and test) how it behaves when upgraded and ensure this runs. I am realistically not going to work on that right now though.
Change:
TMPDIR="''${TMPDIR:-/tmp}"  HOME="$HOME"  XAUTHORITY="''${XAUTHORITY:-$HOME/.Xauthority}"  <del> DISPLAY="$DISPLAY"  </del> <ins> DISPLAY="''${DISPLAY:-}"  </ins> DBUS_SESSION_BUS_ADDRESS="''${DBUS_SESSION_BUS_ADDRESS:-unix:path=$XDG_RUNTIME_DIR/bus}"   XDG_DATA_HOME="$HOME/.local/share" 

Discussion:
On startup, Tor Browser doesn't start if some variables about Wayland aren't set. Steps to reproduce the behavior: and (if set) Tor Browser in a terminal and see the error message. Tor Browser should start. This issue was caused by . currently does not fix the problem. In the meantime, an easy fix would be : <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Notifying peoples from the aforementioned PRs instead. Please run and paste the result.
I can confirm this issue
thanks !
Change:
The <option>services.dnscrypt-proxy</option> module has been removed as it used the deprecated version of dnscrypt-proxy. We've added <xref linkend="opt-services.dnscrypt-proxy2.enable"/> to use the supported version. <ins> This module supports configuration via the Nix attribute set <xref linkend="opt-services.dnscrypt-proxy2.settings" />, or by passing a TOML configuration file via <xref linkend="opt-services.dnscrypt-proxy2.configFile" />. <programlisting> # Example configuration: services.dnscrypt-proxy2.enable = true; services.dnscrypt-proxy2.settings = { listen_addresses = [ "127.0.0.1:43" ]; sources.public-resolvers = { urls = [ "https://download.dnscrypt.info/resolvers-list/v2/public-resolvers.md" ]; cache_file = "public-resolvers.md"; minisign_key = "RWQf6LRCGA9i53mlYecO4IzT51TGPpvWucNSCh1CBM0QTaLn73Y7GFO3"; refresh_delay = 72; }; }; services.dnsmasq.enable = true; services.dnsmasq.servers = [ "127.0.0.1#43" ]; </programlisting> </ins> </para> </listitem> <listitem>

Discussion:
I have read the release notes of 20.03, here are the things i noticed: Linux kernel is updated to branch 5.4 by default (from 4.19). Users of Intel GPUs may prefer to explicitly set branch to 4.19 to avoid some regressions. Can you add a link to an open issue to see when it is fixed? At least link to "more information" e.g.: Not all entries are services. Maybe "Modules" would be more accurate? If we decide to change it, apply it to all NixOS releases. Some services are listed here, but they where just moved. For example: Best would be to update the tooling to exclude moved files and update it. The services.dnscrypt-proxy module has been removed as it used the deprecated version of dnscrypt-proxy. We've services.dnscrypt- to use the supported version. can't it be a drop-in replacement? it would be more user friendly if the new version would just be used with services.dnscrypt-proxy (i don't know the software, so it might makes sense) Update: This seems fine since the options have changed completely. It has option now. Maybe mention that the options have changed. Like "options are now organized using a settings option" or something like that to make it really clear fixed small typo myself (backported in )
I was hoping to do/address all these things :+1:
Change:
# If gnome is installed, build vim for gtk3 too. nixpkgs.config.vim.gui = "gtk3"; <del> # Install gnome-software if flatpak is enabled services.flatpak.guiPackages = [ pkgs.gnome.gnome-software ]; </del> }) (mkIf flashbackEnabled {

Discussion:
Describe the bug Some options for gnome configuration don't work. I have disabled xterm and excluded gnome-software in my configuration but it is still installed in my system. config I am using Xterm shouldn't be installed if it is disabled. If gnome-software is installed by default for flatpak then I think that it should be an option and shouldn't override . Notify maintainers Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
GNOME Software is actually installed by Flatpak module (introduced in ) so does not handle it. Maybe it should. Do not see in your config, maybe double check it is disabled using program. Either way, it should be unrelated to GNOME.
I have enabled it, sorry didn't post the snippet.
GNOME Software consumes a lot of memory even if it is not launched and is quite slow also there are alternatives that are being worked on like . So people in future might want to switch the gui for flatpak. If handling by exclude package doesn't look like a good solution then adding a module for flatpak to choose to install the software center would be better.
I used this . Maybe just add the documentation for this option since it is not present in .
Change:
// lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform) { preInstall = null; # clobber the native hook <del> dontStrip = true; separateDebugInfo = false; # this is currently broken for crossDrv </del> # To avoid a dependency on the build system 'bash'. preFixup = '' rm -f $bin/bin/{ldd,tzselect,catchsegv,xtrace}

Discussion:
building some cross-compiled packages and inspecting their run-time closures: will show that depends on (on master ). this is because the package isn't spliced correctly: The cross compiled packages depend on the folder, but this path also contains x86 binaries in it! (like ). This causes a bunch of other run-time x86 dependencies to be packaged with the cross-compiled binaries. pointed me here: , which is possibly broken. Trying to move the ARM libs into the output caused a cyclic dependency between the lib output and the normal output :( so I'm stuck & posting this issue. build a cross-compiled binary with a cross , notice that it has x86 binaries in it's run-time closure (assuming the build system is x86): system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Change:
cmakeDir = "../drivers/xgl"; <ins> # LTO is disabled in gcc for i686 as of #66528 cmakeFlags = stdenv.lib.optionals stdenv.is32bit ["-DXGL_ENABLE_LTO=OFF"]; postPatch = stdenv.lib.optionalString stdenv.is32bit '' substituteInPlace drivers/pal/cmake/PalCompilerOptions.cmake  --replace "pal_setup_gcc_ipo()" "" ''; </ins> installPhase = '' <del> install -Dm755 -t $out/lib icd/amdvlk64.so install -Dm644 -t $out/share/vulkan/icd.d ../drivers/AMDVLK/json/Redhat/amd_icd64.json </del> <ins> install -Dm755 -t $out/lib icd/amdvlk${suffix}.so install -Dm644 -t $out/share/vulkan/icd.d ../drivers/AMDVLK/json/Redhat/amd_icd${suffix}.json </ins> <del> substituteInPlace $out/share/vulkan/icd.d/amd_icd64.json --replace  </del> <ins> substituteInPlace $out/share/vulkan/icd.d/amd_icd${suffix}.json --replace  </ins> "/usr/lib64" "$out/lib" <ins> substituteInPlace $out/share/vulkan/icd.d/amd_icd${suffix}.json --replace  "/usr/lib" "$out/lib" </ins> <del> patchelf --set-rpath "$rpath" $out/lib/amdvlk64.so </del> <ins> patchelf --set-rpath "$rpath" $out/lib/amdvlk${suffix}.so </ins> ''; # Keep the rpath, otherwise vulkaninfo and vkcube segfault

Discussion:
Project description introduced amdvlk to nixos already, but afaict this only works with 64bit application, but since a lot of especially games are still 32bit it really would be nice to also be able to run those with amdvlk. I currently have this: In my nixos configuration to make sure that if possible amdvlk is used but also to make sure 32bit applications can still run Metadata should be the same
What would be the right way to do this with nix? The possibilities I see are: with the nix i686 toolchain (working amdvlk here: , can be used as ) A disadvantage of 2. is that it does not support lto.
Change:
if md5 != "" then throw "fetchsvn does not support md5 anymore, please use sha256" <ins> else if hash != "" && sha256 != "" then throw "Only one of sha256 or hash can be set" </ins> else stdenvNoCC.mkDerivation { name = name_;

Discussion:
Most of fetchers are using as possible hash parameter, but fetchsvn is not.
See also the discussion in
I marked this as stale due to inactivity. &rarr;
Change:
let script = pkgs.callPackage ./cdi-generate.nix { inherit (config.hardware.nvidia-container-toolkit) mounts; <ins> nvidia-container-toolkit = config.hardware.nvidia-container-toolkit.package; </ins> nvidia-driver = config.hardware.nvidia.package; deviceNameStrategy = config.hardware.nvidia-container-toolkit.device-name-strategy; };

Discussion:
The service will ask docker to mount the binary which is not provided by the Nvidia driver v470. Using NixOS 24.05 with nixpkgs . Steps to reproduce the behavior: should not be mounted when the binary is missing. <img width="1234" alt="image" src=""<img width="854" alt="image" src="" Edited: a workaround Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thank you for the report You can also set in the meantime. I'll open a PR as soon as possible.
Change:
buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.CoreFoundation darwin.apple_sdk.frameworks.CoreServices <ins> libiconv </ins> ]; # Tests have issues at the moment, check with next update

Discussion:
Steps to reproduce the behavior: Run: <details<summaryClick here for logs...</summary</detailsFor some reason, isn't being to the dependencies . No idea why. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Looks like an issue for I only have access to a real Darwin builder beside the community one.
This is , not . Maybe this is the easiest fix (confirmed it works for me)? What do you think is your package:
I opened to add libiconv to ruff-api.
Change:
while [ "$#" -gt 0 ]; do i="$1"; shift 1 case "$i" in <del> -I) given_path="$1"; shift 1 extraBuildFlags+=("$i" "$given_path") </del> <ins> --max-jobs|-j|--cores|-I) j="$1"; shift 1 extraBuildFlags+=("$i" "$j") ;; --option) j="$1"; shift 1 k="$1"; shift 1 extraBuildFlags+=("$i" "$j" "$k") </ins> ;; --root) mountPoint="$1"; shift 1

Discussion:
It would speed up the installation if supported or parameter
Probably best to generalize so anything can be passed to