jiebi/CodeConvo huggingface dataset:
Change:
openjfx19 = callPackage ../development/compilers/openjdk/openjfx/19.nix { }; openjfx20 = callPackage ../development/compilers/openjdk/openjfx/20.nix { }; openjfx21 = callPackage ../development/compilers/openjdk/openjfx/21.nix { }; <ins> openjfx22 = callPackage ../development/compilers/openjdk/openjfx/22.nix { }; </ins> in { <del> inherit openjfx11 openjfx15 openjfx17 openjfx19 openjfx20 openjfx21; </del> <ins> inherit openjfx11 openjfx15 openjfx17 openjfx19 openjfx20 openjfx21 openjfx22; </ins> compiler = let

Discussion:
Project description OpenJDK 22 was released on 19-MAR-2024. The OpenJDK project has been releasing Early Access (EA) binaries for many months now. It would be nice to be able to install OpenJDK 22 as a Nix package and also to begin development of dependent Nix packages (e.g. ) Metadata homepage URL: source URL: (update: is open now) license: GPL with Classpath Exception platforms: unix, linux, darwin, others I'm fairly new to Nix (but loving it so far) so I'm not 100% sure this whether this should be a "new package request" (as Nix keeps multiple versions of OpenJDK available as different packages) or a "package update request" (since jdk22 is an updated version of jdk21.) If I need to change this or anything else in the issue please let me know and I will try to fix it.
Change:
users.users.systemd-network.group = "systemd-network"; systemd.additionalUpstreamSystemUnits = [ <del> "systemd-networkd.service" "systemd-networkd-wait-online.service" </del> <ins> "systemd-networkd-wait-online.service" "systemd-networkd.service" "systemd-networkd.socket" </ins> ]; systemd.network.units = mapAttrs' (n: v: nameValuePair "${n}.netdev" (netdevToUnit n v)) cfg.netdevs // mapAttrs' (n: v: nameValuePair "${n}.network" (networkToUnit n v)) cfg.networks; <ins> # systemd-networkd is socket-activated by kernel netlink route change # messages. It is important to have systemd buffer those on behalf of # networkd. systemd.sockets.systemd-networkd.wantedBy = [ "sockets.target" ]; </ins> systemd.services.systemd-networkd = { wantedBy = [ "multi-user.target" ]; <ins> aliases = [ "dbus-org.freedesktop.network1.service" ]; </ins> restartTriggers = map (x: x.source) (attrValues unitFiles); # prevent race condition with interface renaming (#39069) requires = [ "systemd-udev-settle.service" ];

Discussion:
Describe the bug Systemd ships dbus system services (in ), which are used for dbus system activation (see ) This includes some of the units shipped with systemd itself: We currently don't have the proper tooling ready to make these available in NixOS. Also, we shouldn't blindly enable all. For example, we might not want to enable `share/dbus-1/system-services/org.freedesktop.resolve1.service, if resolved is enabled. Originally discovered in , but it always hasn't worked, so it's not a regression. Notify maintainers
I wonder if that's why every program I have that uses dBus in some way or another, spits from time to time:
Can you tell me which programs those are?
Sure, from , prints: I'm using as my display manager and I'm using as my desktop environment but I don't use . Not sure if that matters.. EDIT: Currently I can't identify another program that spits this message, although IIRC I saw it coming out of other programs as well. This could be an upstream issue as well.
It does seem that somehow picks up the systemd configuration; though I do not fully understand how it's just missing the when is enabled
Ah apparently all applications are loaded into dbus by default? Not sure how I feel about that ... so the only reason why resolved wasn't working is because we didnt included unit file in Easy fix! All the other services already work!
It seems we do, but we shouldn't do that. If we try to not restart , changes in there don't get propagated. It should just use nscd like everything else. can you file a PR removing this?
reopened, as got reverted.
I've found another example for: prints:
Another symptom is:
I'm not sure if that is a symptom of what I am solving here. I recall recently running into the same issue and I think it's a problem with how we set up user environment in certain desktop managers.
Should I open a distinct issue then?
Change:
mustache-go = callPackage ../development/tools/mustache-go { }; <ins> mustache-hpp = callPackage ../development/libraries/mustache-hpp { }; </ins> myrica = callPackage ../data/fonts/myrica { }; nafees = callPackage ../data/fonts/nafees { };

Discussion:
Describe the bug Kiwix fails to build with a C++ code error. To Reproduce Steps to reproduce the behavior: , because the package is marked as insecure, Expected behavior Kiwix builds. Additional context The error: Probably this needs to be solved for . Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: channels(mario): channels(root): nixpkgs: Maintainer information:
I marked this as stale due to inactivity. &rarr;
See
Change:
for each package in a separate file: the call to the function would be almost as much code as the function itself. */ <del> {config, pkgs, fetchurl, fetchpatch, fetchFromGitHub, stdenv, perl, overrides, buildPerl, shortenPerlShebang}: </del> <ins> { config , stdenv, buildPackages, pkgs , fetchurl, fetchpatch, fetchFromGitHub , perl, overrides, buildPerl, shortenPerlShebang }: </ins> # cpan2nix assumes that perl-packages.nix will be used only with perl 5.28.2 or above assert stdenv.lib.versionAtLeast perl.version "5.28.2";

Discussion:
Describe the bug A clear and concise description of what the bug is. To Reproduce Steps to reproduce the behavior: This is a bit annoying, as --.
Uhm, It looks like it's also a problem for i3 users. I'm not a perl programmer so I don't think I can do much to fix the package. For rxvt-unicode, you can temporarily remove bidi from your plugins, see the .
Looks like some tests are failing for . Temporary workaround is to turn off tests for the package.
It is expecting in , but doesn't seem to provide it, so I have no idea what should provide it...
Bisecting showed this to be broken by : can you take a look?
Looking
Change:
singularity-overriden-nixos ; <ins> sfwbar = callPackage ../applications/misc/sfwbar { }; </ins> skate = callPackage ../applications/misc/skate { }; slack = callPackage ../applications/networking/instant-messengers/slack { };

Discussion:
Project description SFWBar (S Floating Window Bar) is a flexible taskbar application for wayland compositors, designed with a stacking layout in mind. Metadata homepage source license: GPL-3.0 platforms: unix, linux
I'll take a look at this.
Would it be possible to get this updated to version 1.0_beta14 Beta 14 has been out since Jan 2, unstable still only has beta 13 Thanks
Please don't bump closed threads for update requests, the correct way would be to open an out of date package report in
Change:
"--enable-nntp" "--enable-256-colors" "--enable-true-color" <ins> "--with-brotli" </ins> "--with-lzma" "--with-libev" "--with-terminfo"

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: elinks <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 0.15.1 desired version: 0.16.0 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers:
Thank you for bringing this to my attention :-) I just submitted a corresponding pull request, .
Change:
, pulseSupport       ? config.pulseaudio or stdenv.isLinux, libpulseaudio ? null , rubberbandSupport  ? stdenv.isLinux, rubberband    ? null , screenSaverSupport ? true,           libXScrnSaver ? null <del> , sambaSupport       ? true,           samba         ? null </del> <ins> , sambaSupport       ? stdenv.isLinux, samba         ? null </ins> , sdl2Support        ? true,           SDL2          ? null , sndioSupport       ? true,           sndio         ? null , speexSupport       ? true,           speex         ? null

Discussion:
Describe the bug crashes with a : This happens regardless of what file I try to play, even a bare invocation without arguments. To Reproduce Steps to reproduce the behavior: from on macOS (or attempt to) with or without arguments. Expected behavior I expected all dependencies, including this to be installed in the nix store. Additional context Running on macOS, using nix-darwin and home-manager. Metadata Please run and paste the result. Will do when I get access to the machine again. Maintainer information:
Change:
--prefix XDG_DATA_DIRS   : "$XDG_ICON_DIRS:$GSETTINGS_SCHEMAS_PATH:${addDriverRunpath.driverLink}/share"  --set CHROME_WRAPPER  "google-chrome-$dist"  --add-flags "''${NIXOS_OZONE_WL:+''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}"  <del> --add-flags ${ lib.concatStringsSep " " [ (lib.escapeShellArg commandLineArgs) # Disables auto updates and browser outdated popup "--simulate-outdated-no-au='Tue, 31 Dec 2099 23:59:59 GMT'" ] } </del> <ins> --add-flags "--simulate-outdated-no-au='Tue, 31 Dec 2099 23:59:59 GMT'"  --add-flags ${lib.escapeShellArg commandLineArgs} </ins> for elf in $out/share/google/$appname/{chrome,chrome-sandbox,chrome_crashpad_handler}; do patchelf --set-rpath $rpath $elf

Discussion:
Steps to reproduce the behavior: (add) google-chrome from nixpkgs/master (the exact commit with problem from this issue ) Add any other context about the problem here. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I tryed both default nix and nix.package = ;
Oops, that's odd, it passed all the eval checks on the original PR I thought. I've created to fix.
Change:
''; homepage = https://thp.io/2010/mygpoclient/; license = with licenses; [ gpl3 ]; <del> platforms = with platforms; [ linux darwin ]; </del> <ins> platforms = with platforms; linux ++ darwin; </ins> maintainers = with maintainers; [ skeidel ]; }; };

Discussion:
ahh, should be
Packages , and in need this fix
I do find it odd that this wasn't enforced on me when building with the 'wrong' platforms.
is not checked when doing
Change:
bwbasic = callPackage ../development/interpreters/bwbasic { }; <ins> bws = callPackage ../tools/security/bws { }; </ins> byobu = callPackage ../tools/misc/byobu { # Choices: [ tmux screen ]; textual-window-manager = tmux;

Discussion:
Project description Secret manager on bitwarden. It is beta version yet. Metadata homepage URL: source URL: license: BITWARDEN SOFTWARE DEVELOPMENT KIT LICENSE AGREEMENT() platforms: linux, darwin, windows
Change:
<ins> diff --git a/connect.c b/connect.c index fd7ffe1..20cd992 100644 --- a/connect.c +++ b/connect.c @@ -768,7 +768,7 @@ struct child_process *git_connect(int fd[2], const char *url, ssh = getenv("GIT_SSH"); if (!ssh) -					ssh = "ssh"; +					ssh = "@ssh@"; ssh_dup = xstrdup(ssh); base = basename(ssh_dup); diff --git a/git-gui/lib/remote_add.tcl b/git-gui/lib/remote_add.tcl index 50029d0..17b9594 100644 --- a/git-gui/lib/remote_add.tcl +++ b/git-gui/lib/remote_add.tcl @@ -139,7 +139,7 @@ method _add {} { # Parse the location if { [regexp {(?:git+)?ssh://([^/]+)(/.+)} $location xx host path] || [regexp {([^:][^:]+):(.+)} $location xx host path]} { -			set ssh ssh +			set ssh @ssh@ if {[info exists env(GIT_SSH)]} { set ssh $env(GIT_SSH) } </ins>

Discussion:
Running with my still-quite-new nix environment, I get: Installing openssh fixes the problem for me, of course. But this means that git really ought to declare a dependency on openssh, no?
Hmm, currently I see two other alternatives: wrap all to have ssh in path (this seems the cleanest way), add it to , or or leave it as it is.
Or patch git to invoke ssh via an absolute path. (I'm not really fond of wrappers...)
Personally, I'd be very much in favor of patching git to call via an absolute path. At the same time, maintaining that patch over time is tedious and error-prone work, and I'd rather not be responsible for that. IMHO, patching SSH would be a feasible alternative only if we get that patch included upstream.
Has anyone taken a look at patching git to see how hard it will be?
There are two places. One is in connect.c where it reads GIT_SSH and then does Another is in git-gui where it does more or less the same, but in TCL.
I just found out that openssh isn't even a build input of git at the moment. :-)
I've decided to add a wrapper, since maintaining patches for references is going to be a burden. We still need to be able to specify public keys for ssh to pick them up.
your patch broke git-annex:
Reverted
that's an old build, now src is using https for sxiv
Is there a recommended solution for this now?
The recommended solution is to patch git, IMHO. It's not hard, as pointed out.
Triage: this issue does still exist on 16.03-beta:
Patched in
The solution to this issue is now causing a different issue on Fedora: () I'm not sure if we should really hard-code a SSH binary or if we should e.g. just reference a SSH binary as a fallback. Opinions welcome :)
FYI: is about to revert this and I currently believe that this is a good idea.
Change:
<del> { lib, stdenv, fetchurl, makeDesktopItem, copyDesktopItems, SDL, SDL_mixer, freepats }: </del> <ins> { lib, stdenv, fetchzip, fetchFromGitHub , makeDesktopItem, copyDesktopItems , cmake , SDL2, SDL2_mixer, freepats }: </ins> stdenv.mkDerivation rec { pname   = "abuse"; <del> version = "0.8"; </del> <ins> version = "0.9.1"; </ins> <del> src = fetchurl { url    = "http://abuse.zoy.org/raw-attachment/wiki/download/${pname}-${version}.tar.gz"; sha256 = "0104db5fd2695c9518583783f7aaa7e5c0355e27c5a803840a05aef97f9d3488"; </del> <ins> src = fetchFromGitHub { owner = "Xenoveritas"; repo = pname; rev = "v${version}"; hash = "sha256-eneu0HxEoM//Ju2XMHnDMZ/igeVMPSLg7IaxR2cnJrk="; </ins> }; <del> configureFlags = [ "--with-x" "--with-assetdir=$(out)/orig" # The "--enable-debug" is to work around a segfault on start, see https://bugs.archlinux.org/task/52915. "--enable-debug" ]; </del> <ins> data = fetchzip { url  = "http://abuse.zoy.org/raw-attachment/wiki/download/abuse-0.8.tar.gz"; hash = "sha256-SOrtBNLWskN7Tqa0B3+KjlZlqPjC64Jp02Pk7to2hFg="; }; preConfigure = '' cp --reflink=auto -r ${data}/data/sfx ${data}/data/music data/ ''; </ins> desktopItems = [ (makeDesktopItem { name = "abuse";

Discussion:
Package name: abuse Latest released version: 0.9.1 () <!-- Search your package here: --- Current version on the unstable channel: 0.8 Current version on the stable/release channel: 0.8 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thank you for pinging me! I prepared a . But I cannot fully test it as I'm currently at a machine without sound. Can you test whether everything works as expected, including gfx effects and music? You can do so with the following incantation:
Yes, works great!
Change:
<del> { buildPackages, fetchurl, perl, buildLinux, nixosTests, stdenv, ... } @ args: buildLinux (args // rec { version = "4.9.332"; extraMeta.branch = "4.9"; extraMeta.broken = stdenv.isAarch64; src = fetchurl { url = "mirror://kernel/linux/kernel/v4.x/linux-${version}.tar.xz"; sha256 = "1kiqa9kw4932n5qglkyymsrak849wbbszw9rnq1aygmdinjz4c8i"; }; } // (args.argsOverride or {})) </del>

Discussion:
The Linux 4.9 LTS release will be EOL after 2023/01 and I hope we can remove it before the 22.11 release, so we don't carry it around until then. via cc kernel maintainer team
Thanks for the heads-up. I'd be fine with doing the removal right now (considering that it's LTS and having that one removed on stable may be an unpleasant surprise), but FWIW: we usually drop kernel releases when they get EOLed (also from stable branches), otherwise we wouldn't be able to provide non-LTS kernels on any stable branch anyways.
Change:
<del> { lib , buildPythonPackage , fetchFromGitHub , geojson , pysocks , pythonOlder , requests , pytestCheckHook , pythonRelaxDepsHook </del> <ins> { lib, buildPythonPackage, fetchFromGitHub, geojson, pysocks, pythonOlder, requests, setuptools, pytestCheckHook, pythonRelaxDepsHook, </ins> }: buildPythonPackage rec { pname = "pyowm"; version = "3.3.0"; <del> format = "setuptools"; </del> <ins> pyproject = true; </ins> disabled = pythonOlder "3.7"; src = fetchFromGitHub { owner = "csparpa"; <del> repo = pname; rev = version; </del> <ins> repo = "pyowm"; rev = "refs/tags/${version}"; </ins> hash = "sha256-cSOhm3aDksLBChZzgw1gjUjLQkElR2/xGFMOb9K9RME="; }; <del> pythonRelaxDeps = [ "geojson" ]; </del> <ins> pythonRelaxDeps = [ "geojson" ]; </ins> <del> nativeBuildInputs = [ pythonRelaxDepsHook ]; </del> <ins> build-system = [ setuptools ]; nativeBuildInputs = [ pythonRelaxDepsHook ]; </ins> <del> propagatedBuildInputs = [ </del> <ins> dependencies = [ </ins> geojson pysocks requests <ins> setuptools </ins> ]; <del> nativeCheckInputs = [ pytestCheckHook ]; </del> <ins> nativeCheckInputs = [ pytestCheckHook ]; </ins> # Run only tests which don't require network access <del> pytestFlagsArray = [ "tests/unit" ]; </del> <ins> pytestFlagsArray = [ "tests/unit" ]; </ins> <del> pythonImportsCheck = [ "pyowm" ]; </del> <ins> pythonImportsCheck = [ "pyowm" ]; </ins> meta = with lib; { description = "Python wrapper around the OpenWeatherMap web API"; homepage = "https://pyowm.readthedocs.io/"; <ins> changelog = "https://github.com/csparpa/pyowm/releases/tag/${version}"; </ins> license = licenses.mit; maintainers = with maintainers; [ fab ]; };

Discussion:
A clear and concise description of what the bug is. The integration seem to require the missing python module and currently fails with this error message: is provided by python . Adding to in the . Maybe this missing dependency could be resolved in pyowm as well. I would appreciate some input from somebody with more experience. Steps to reproduce the behavior: home-assistant with openweathermap component No Error message and working openweathermap component <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
PR
Please post the full stacktrace.
There also was an upstream issue that may be related:
The fix is to add to pyowm's dependencies.
ok. Thanks for your help. I will create another PR later
Change:
./services/hardware/sane_extra_backends/brscan5.nix ./services/hardware/sane_extra_backends/dsseries.nix ./services/hardware/spacenavd.nix <ins> ./services/hardware/supergfxd.nix </ins> ./services/hardware/tcsd.nix ./services/hardware/tlp.nix ./services/hardware/thinkfan.nix

Discussion:
Project description It is a command line utility which adds features for asus laptops. For example graphics card switching, anime matrix control (for g14). fan control, keyboard backlight control, cpu boost control, profiles, fan curves and other stuff. It basically unlocks a lot of functionality for laptops and can be used for non asus laptops as well contrary to the name. Metadata homepage URL:https://asus- source license: Mozilla Public License 2.0 platforms: Linux
I've made a PR to introduce the asusctl package as well as a NixOS module to run asusd. Can someone give this a try, I personally do not have Asus hardware to test it properly. You can find the PR here:
Change:
url = "https://raw.githubusercontent.com/archlinux/svntogit-packages/4250fe8f28c220d883db454cec2b2c76a07473eb/trunk/vlc-3.0.11.1-srt_1.4.2.patch"; sha256 = "53poWjZfwq/6l316sqiCp0AtcGweyXBntcLDFPSokHQ="; }) <ins> # patches to build with recent live555 # upstream issue: https://code.videolan.org/videolan/vlc/-/issues/25473 (fetchpatch { url = "https://code.videolan.org/videolan/vlc/uploads/3c84ea58d7b94d7a8d354eaffe4b7d55/0001-Get-addr-by-ref.-from-getConnectionEndpointAddress.patch"; sha256 = "171d3qjl9a4dm13sqig3ra8s2zcr76wfnqz4ba4asg139cyc1axd"; }) (fetchpatch { url = "https://code.videolan.org/videolan/vlc/uploads/eb1c313d2d499b8a777314f789794f9d/0001-Add-lssl-and-lcrypto-to-liblive555_plugin_la_LIBADD.patch"; sha256 = "0kyi8q2zn2ww148ngbia9c7qjgdrijf4jlvxyxgrj29cb5iy1kda"; }) </ins> ]; postPatch = ''

Discussion:
, CVSSv3=7.5 (nixos-21.05, nixos-unstable) CVSSv3=6.5 (nixos-21.05, nixos-unstable) CVSSv3=6.5 (nixos-21.05, nixos-unstable) Live555 through 1.08 mishandles huge requests for the same MP3 stream, leading to recursion and s stack-based buffer over-read. An attacker can leverage this to launch a DoS attack. Live555 through 1.08 does not handle MPEG-1 or 2 files properly. Sending two successive RTSP SETUP commands for the same track causes a Use-After-Free and daemon crash. Live555 through 1.08 does not handle Matroska and Ogg files properly. Sending two successive RTSP SETUP commands for the same track causes a Use-After-Free and daemon crash. Scanned versions: nixos-21.05: ; nixos-unstable: .
Change:
<del> { stdenv, libXScrnSaver, makeWrapper, fetchurl, wrapGAppsHook, gtk3, unzip, atomEnv, libuuid, at-spi2-atk, at-spi2-core}: </del> <ins> { stdenv, libXScrnSaver, makeWrapper, fetchurl, wrapGAppsHook, glib, gtk3, unzip, atomEnv, libuuid, at-spi2-atk, at-spi2-core}: </ins> version: hashes: let

Discussion:
Describe the bug The electron package tries to wrap in . Because of this the wrapper is completely void of any entries in . It needs to be rewritten in whatever fashion that the call happens in . This is why has needed to be wrapped recently , it's because isn't wrapped correctly itself. A change should be made to stable to revert this to riot-desktop, and to backport this fix instead. Expression: buildInputs should also have for it's setup-hook
I created a PR here:
Change:
++ lib.optional withShibboleth "-DBUILD_SHIBBOLETH_SUPPORT=ON"; qtWrapperArgs = [ <del> "--suffix PATH : ${stdenv.lib.makeBinPath [ ccnet seafile-shared ]}" </del> <ins> "--suffix PATH : ${lib.makeBinPath [ ccnet seafile-shared ]}" </ins> ]; meta = with lib; {

Discussion:
Describe the bug The binary fails to launch in . Output: To Reproduce Steps to reproduce the behavior: to vis CLI Expected behavior The Seafile Applet starts without issues. Additional context This could be related to a missing , however looks like it does include an alternative way of the hook. Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(wucke13): nixpkgs: Maintainer information:
Can you try to see if adding helps?
Fixing this now.
That's a fast response, thank you both! Just wondering: Why didn't this occur earlier?
It was large issue that a lot of qt apps in nixpkgs weren't packaged correctly Hopefully people will read the qt section of the manual now, since it's always been to do
Oh, I'm well aware of the Qt Apps problem in general. What I'm wondering is why I did not run into this issue before 20.03. I'm using seafile since 17.03, and I'm not using a Qt DE that circumvents the problem, so I'm wondering why this problem ocured first in 20.03.
Me trying to run it from nixos-unstable results in That is indeed strange.
I figured out the timeline and why you just now experienced this issue