jiebi/CodeConvo huggingface dataset:
Change:
{ ${pkgs.coreutils}/bin/cat << EOF From: smartd on ${host} <${nm.sender}> <del> To: undisclosed-recipients:; </del> <ins> To: ${nm.recipient} </ins> Subject: $SMARTD_SUBJECT $SMARTD_FULLMESSAGE

Discussion:
will send emails with in the To: field. For me, this causes rspamd to categorize these emails as spam. Notably, rspamd assigns the following symbols to the mails: Steps to reproduce the behavior: test email, can probably be done by setting in the relevant field if email landed in spam folder (dependent on the spam filter and its configuration) The module sets the To: field to the value of . As far as I can tell, this would solve the problem without any downsides. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
can I open a PR changing the line in question to: ? I have tested it locally and it did fix the problem improving the score given by
I forgot this was upstreamed. Feel free to open a PR.
Change:
}; } // (listToAttrs (flip map interfaces (i: let <del> deviceDependency = if config.boot.isContainer </del> <ins> deviceDependency = if (config.boot.isContainer || i.name == "lo") </ins> then [] else [ (subsystemDevice i.name) ]; in

Discussion:
I've tried the following: which should assign an alias ( happily accepts the colon syntax in NixOS). Instead it tells me: "invalid character ‘:’ in name ‘unit-network-addresses-lo:metadata.service'" I also tried: which doesn't throw an error but also doesn't get me an alias. Is it not currently possible to alias the loopback interface via NixOS configuration, or am I missing something?
(triage) any leads?
More than question I think it's a bug that it doesn't work. any thoughts?
Resolved in
Sorry, is this actually resolved? I try this in my config: And I get this: If I run the setup script by hand, it works fine. is this working for you now?
use instead: we cannot support arbitrary device names here due limitation of the script generator. Should be fine with though.
I finally had a chance to follow up on this. Using the config that suggested above, I still get these errors: does actually get the address. However, boot-up and NixOps takes a lot longer, presumably because of the timeouts. So something is still not quite right here.
That device dependency should be not according to this source code: Are you running the latest NixOS 17.09?
Ahh, no, I’m running but from a few weeks ago. I’ll try again once I’ve updated.
I still recommend to people to switch to since the scripted module is just a hack... well.
So with a recent , assigning an IP address to still causes timeouts. However, the IP address does successfully get assigned.
if the service file assign ip addresses contains a dependency, something went wrong.
I see the same:
The bug appears to be here: compared to this:
Testing this patch:
Change:
use Fcntl ':flock'; use Getopt::Long qw(:config gnu_getopt); use Cwd 'abs_path'; <ins> use Time::HiRes; </ins> my $nsenter = "@utillinux@/bin/nsenter"; my $su = "@su@";

Discussion:
When run on my container, the container doesn't shut down properly. It hangs with the following processes: See how there are only , and left in the container, so I suspect it's a problem with what does, as opposed to what I do in my container.
After 90 seconds, systemd kills the container with a SIGKILL, so that way the hang is eventually resolved. This is what the log of looks like:
I further found that when I run directly myself, the container shuts down perfectly fine. But when I first it, and then send the in it a , it doesn't shut down as expected. So myst be doing something that puts systemd in a state where it no longer cares about the signal. This is the of that systemd process inside the container when it's hung (the blank space is when I sent the signal that it ignores):
Also I haven't said that yet: immediately shuts down the machine correctly. It's likely something in that's not doing the right thing. I've re-run the strace with to get more output: This seems to reveal the error: For those not familiar with : , which nixos-containers is , triggers the . But it seems like this target file does not exist in my container at the 4 locations it's trying to find it at, so probably systemd just does nothing when it can't find that file.
Ah, interesting. While the container is running, the file does exist here: Maybe in the container gets unmounted too early in the shutdown sequence, before systemd has the chance to read this file?
OK, I think I've got the reason. In it calls (which does , which runs asynchronously and immediately returns), and then we immediately delete the , , and the . Probably lives in , so we delete it here before systemd actually gets the chance to come by there. This is supported by the observation that when I put a after the line, everything works fine. So I think the solution is the same as the solution to should be: Make block until the container is actually gone. Only after that delete the container's root. For an example of how to poll for the container being down, see . Now we just have to bring that to perl
I guess this can be closed as the PR fixing this has been merged,
Change:
ldap = { configureFlags = [ <del> "--with-ldap" </del> <ins> "--with-ldap=/invalid/path" </ins> "LDAP_DIR=${openldap.dev}" "LDAP_INCDIR=${openldap.dev}/include" "LDAP_LIBDIR=${openldap.out}/lib"

Discussion:
Build PHP on non-NixOS. Both PHP 5.6 and PHP 7 fail to build for the same reason. System: Debian Nixpkgs version: 16.09
Apparently, LDAP_xxx variables are ignored: This is output by Near
Damn, this is because I have LDAP on the host system.
Ok? This also helps PHP forget host and probably other stuff.
Are you building with sandboxing disabled? If so, I think this kind of stuff is to be expected.
I know this is kind of old, but it looks like the Travis build for failed due to this issue. Any reason that patch hasn't been applied? https://travis-
Change:
<ins> { lib, buildPackages, fetchurl, perl, buildLinux, nixosTests, modDirVersionArg ? null, ... } @ args: with lib; buildLinux (args // rec { version = "5.18"; # modDirVersion needs to be x.y.z, will automatically add .0 if needed modDirVersion = if (modDirVersionArg == null) then concatStringsSep "." (take 3 (splitVersion "${version}.0")) else modDirVersionArg; # branchVersion needs to be x.y extraMeta.branch = versions.majorMinor version; src = fetchurl { url = "mirror://kernel/linux/kernel/v5.x/linux-${version}.tar.xz"; sha256 = "1vjwhl4s8qxfg1aabn8xnpjza3qzrjcp5450h9qpjvl999lg3wsi"; }; } // (args.argsOverride or { })) </ins>

Discussion:
Steps to reproduce the behavior: Tail of the build log The build failure seems related to these unused options. I tried removing the corresponding lines (in a local directory - so I changed my url to the filesystem path). in but it didn't fix anything. It seems that kernel 5.18 phased out some options. Instead of warning us, there's an explicit error. I have no idea how to fix this since is great for adding lines to the kernel config, but not great at removing them. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (I'm not exactly sure who to notify about this so I just kind of scanned s of and . Please let me know if there's someone more appropriate to notify.) Please run and paste the result. Not sure how to do this for this specific package (no ).
Can you check if fixes this?
. But, it still fails:
Should be fixed by
I can confirm that fixes this! Thanks !
Change:
<del> { lib, stdenv, fetchurl, cmake, pkg-config, openssl, libxml2, boost, python3, libuuid }: </del> <ins> { lib , stdenv , fetchurl , cmake , pkg-config , openssl , libxml2 , boost , python3 , libuuid , curl , gsoap , enableTools ? true # Build the bundled libcurl # and, if defaultToLibCurl, # use instead of an external one , useEmbeddedLibcurl ? true # Use libcurl instead of libneon # Note that the libneon used is bundled in the project # See https://github.com/cern-fts/davix/issues/23 , defaultToLibcurl ? false , enableIpv6 ? true , enableTcpNodelay ? true # Build davix_copy.so , enableThirdPartyCopy ? false }: let boolToUpper = b: lib.toUpper (lib.boolToString b); in </ins> stdenv.mkDerivation rec { <del> version = "0.7.6"; </del> <ins> version = "0.8.0"; </ins> pname = "davix"; nativeBuildInputs = [ cmake pkg-config python3 ]; <del> buildInputs = [ openssl libxml2 boost libuuid ]; </del> <ins> buildInputs = [ openssl libxml2 boost libuuid ] ++ lib.optional (defaultToLibcurl && !useEmbeddedLibcurl) curl ++ lib.optional (enableThirdPartyCopy) gsoap; </ins> # using the url below since the github release page states # "please ignore the GitHub-generated tarballs, as they are incomplete" <del> # https://github.com/cern-fts/davix/releases/tag/R_0_7_6 </del> <ins> # https://github.com/cern-fts/davix/releases/tag/R_0_8_0 </ins> src = fetchurl { url = "https://github.com/cern-fts/${pname}/releases/download/R_${lib.replaceStrings ["."] ["_"] version}/${pname}-${version}.tar.gz"; <del> sha256 = "0wq66spnr616cns72f9dvr2xfvkdvfqqmc6d7dx29fpp57zzvrx2"; </del> <ins> sha256 = "LxCNoECKg/tbnwxoFQ02C6cz5LOg/imNRbDTLSircSQ="; </ins> }; <ins> preConfigure = '' find . -mindepth 1 -maxdepth 1 -type f -name "patch*.sh" -print0 | while IFS= read -r -d ''' file; do patchShebangs "$file" done ''; cmakeFlags = [ "-DENABLE_TOOLS=${boolToUpper enableTools}" "-DEMBEDDED_LIBCURL=${boolToUpper useEmbeddedLibcurl}" "-DLIBCURL_BACKEND_BY_DEFAULT=${boolToUpper defaultToLibcurl}" "-DENABLE_IPV6=${boolToUpper enableIpv6}" "-DENABLE_TCP_NODELAY=${boolToUpper enableTcpNodelay}" "-DENABLE_THIRD_PARTY_COPY=${boolToUpper enableThirdPartyCopy}" ]; </ins> meta = with lib; { description = "Toolkit for Http-based file management";

Discussion:
Steps to reproduce the behavior: Build the following Nix expression: See error as davixcopy isn't not found Shared library davix_copy (or related symlinks) is in as the Debian package does. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Maintainer information:
Change:
"enaml.workbench" ]; <del> nativeBuildInputs = [ setuptools-scm ]; propagatedBuildInputs = [ atom ply kiwisolver qtpy sip_4 cppy bytecode ]; SETUPTOOLS_SCM_PRETEND_VERSION = version; </del> meta = with lib; { <del> homepage = "https://github.com/nucleic/enaml"; </del> description = "Declarative User Interfaces for Python"; <ins> homepage = "https://github.com/nucleic/enaml"; changelog = "https://github.com/nucleic/enaml/releases/tag/${version}"; </ins> license = licenses.bsd3; maintainers = with maintainers; [ raboof ]; };

Discussion:
Steps to reproduce the behavior: `nix-build '<nixpkgs' -A Fails since /cc
Change:
in buildNodejs { inherit enableNpm; <del> version = "16.20.0"; sha256 = "sha256-4JkPmSI05ApR/hH5LDgWyTp34bCBFF0912LNECY0U0k="; </del> <ins> version = "16.20.1"; sha256 = "sha256-g+AzgeJx8aVhkYjnrqnYXZt+EvW+KijOt41ySe0it/E="; </ins> patches = [ ./disable-darwin-v8-system-instrumentation.patch ./bypass-darwin-xcrun-node16.patch

Discussion:
Package name: NodeJS Latest released version: 16.20.1, 18.16.1, 20.3.1 <!-- Search your package here: --- Current version on the unstable channel: 16.20.0, 18.16.0, 20.3.0 Current version on the stable/release channel: 16.20.0, 18.16.0, 20.3.0 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR.
Change:
cargoDeps = rustPlatform.fetchCargoTarball { src = finalAttrs.src; <del> hash = "sha256-RsRz/nb8L+pL1U4l6RnvqeDFddPvcBFH4wdV7G60pxA="; </del> <ins> hash = "sha256-rabiNqw4hg0Js8VadxfkhNLIsrKfMuoKa5lFIfSMNPY="; </ins> }; makeFlags = [

Discussion:
Package name: bcachefs-tools Latest released version: 1.9.1 <!-- Search your package here: --- Current version on the unstable channel: 1.7.0-unstable-2024-05-09 Current version on the stable/release channel: 1.7.0-unstable-2024-05-09 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
"exampledir=${placeholder "out"}/etc/pkcs11" ]; <ins> postInstall = '' installShellCompletion --bash bash-completion/{p11-kit,trust} ''; </ins> meta = with lib; { description = "Library for loading and sharing PKCS#11 modules"; longDescription = ''

Discussion:
Describe the bug does not provide the binary, while I would expect it to. To Reproduce Steps to reproduce the behavior: in Expected behavior (and ) are installed for operator usage of p11-kit. Screenshots See step 3. Additional context It turns out the binaries are present when I do . Debian ships the binaries as part of the base non-dev package. RHEL/CentOS ship the binary as part of and have separated out into . Notify maintainers (based on git history, there is no meta.maintainers for p11-kit) Metadata Please run and paste the result. Maintainer information:
p11-kit is a library as well, so it makes sense to have headers, library, and binaries in separate outputs. I think we can fixed this by setting: in the derivation.
If we do this we need to fix it in flatpak's patch to hardcode the path to the p11-kit binary.
I marked this as stale due to inactivity. &rarr;
Any updates on this?
I marked this as stale due to inactivity. &rarr;
Change:
''; }; <del> extraFlags = mkOption { type = listOf str; </del> <ins> extraFlags = lib.mkOption { type = lib.types.listOf lib.types.str; </ins> default = [ ]; description = '' Extra flags to pass to {command}`updatedb`. ''; }; <del> output = mkOption { type = path; </del> <ins> output = lib.mkOption { type = lib.types.path; </ins> default = "/var/cache/locatedb"; description = '' The database file to build. ''; }; <del> localuser = mkOption { type = nullOr str; </del> <ins> localuser = lib.mkOption { type = lib.types.nullOr lib.types.str; </ins> default = "nobody"; description = '' The user to search non-network directories as, using

Discussion:
Using more-or-less the default configuration for (with ), the list of results is printed twice whenever running . For example: Steps to reproduce the behavior: the module like so: the job with some file name that exists on the system Matching files should each be printed once. The issue is fixed if I unset the environment variable. plocate deliberately reads from both and the hard coded default path, even if they are the same: The comment claims that this is also the behavior of mlocate, but I do not have an mlocate database installed and haven't wanted to change my running system to use mlocate. It looks like recently started being set in NixOS in . Please run and paste the result.
Sounds to me like an upstream issue. Can you write a mail to the upstream maintainer? ;a=blob;f=README;h=;hb=HEAD#l40
Sure, I have done so. I'll follow up when I get a response.
The plocate maintainer says they do not consider this to be a bug in plocate, and is intentional behavior. Rather than setting the environment variable, could we just make a wrapper script for that uses the NixOS-configured dbpath, if we don't want to re-build itself when the path is changed?
I would be personally fine to just drop support for a custom place for the db. If people really want to have it somewhere else they could symlink it. Then we don't need a wrapper or to worry about the env.
I can confirm the behaviour with .
Could we just take out the variable setting? It isn't needed for or , and just causes this annoying behaviour. If it's needed for , maybe the setting could be made conditional. It would be nice to get something done about it sooner rather than later. This issue has been open for 4 months now.
Please take a look at
I've reviewed the PR and it LGTM. Thanks for doing this! It will be great to have this fixed.
Change:
<ins> { lib , aiosmtpd , buildPythonPackage , fetchFromGitHub , fetchpatch , hypothesis , poetry-core , pytest-asyncio , pytestCheckHook , pythonOlder }: buildPythonPackage rec { pname = "aiosmtplib"; version = "1.1.6"; format = "pyproject"; disabled = pythonOlder "3.7"; src = fetchFromGitHub { owner = "cole"; repo = pname; rev = "v${version}"; hash = "sha256-bo+u3I+ZX95UYkEam2TB6d6rvbYKa5Qu/9oNX5le478="; }; nativeBuildInputs = [ poetry-core ]; checkInputs = [ aiosmtpd hypothesis pytest-asyncio pytestCheckHook ]; patches = [ # Switch to poetry-core, https://github.com/cole/aiosmtplib/pull/183 (fetchpatch { name = "switch-to-poetry-core.patch"; url = "https://github.com/cole/aiosmtplib/commit/3aba1c132d9454e05d4281f4c8aa618b4e1b783d.patch"; hash = "sha256-KlA46gD6swfJ/3OLO3xWZWa66Gx1/izmUMQ60PQy0po="; }) ]; pythonImportsCheck = [ "aiosmtplib" ]; meta = with lib; { description = "Module which provides a SMTP client"; homepage = "https://github.com/cole/aiosmtplib"; license = with licenses; [ mit ]; maintainers = with maintainers; [ fab ]; }; } </ins>

Discussion:
Project description Fastapi-email package is needed for fastapi projects. Metadata homepage URL: source license: mit, bsd, gpl2+ , ... platforms: unix, linux, darwin, ...
Change:
inherit jdk8 jdk11 jdk17; }; gradleGen = gradle-packages.gen; <del> gradle_4 = callPackage gradle-packages.gradle_4 { }; gradle_5 = callPackage gradle-packages.gradle_5 { }; </del> gradle_6 = callPackage gradle-packages.gradle_6 { }; gradle_7 = callPackage gradle-packages.gradle_7 { }; gradle = gradle_7;

Discussion:
The last release of Gradle with major version number 5 was on 2019-11-01, and there seems to be just two dependent packages:  (I'd have to check whether this builds with Gradle 7.)  (I am fairly certain that could be built with Gradle 7. This version is EOL.) Let's remove Gradle 5. /cc
I think we can build with at least. I will try to bump it in . BTW, I already marked as EOL in , however the package is still there. So we need to remove it first before removing .
Done:
Merged , this should be good to go. Remember that is only on right now, so if you want to do it before the changes get to you will need to target .
Thanks. Waiting for to reach , then I will PR removal of Gradle 5.
Change:
, ninja , pkgconfig , gobject-introspection <ins> , gsettings-desktop-schemas , makeWrapper </ins> , dbus , glib

Discussion:
It seems that all nix expressions for gnome3 applications need revision regarding environment variables wrapping. For instance on my unstable NixOS system I have on on my configuration. All of them (except , which I have already fixed), when run outside of gnome3, are giving error messages like I think they may be fixed by replacing uses of to explicitly fix binaries, by , which automatically fixes them wrapping environment variables. EDIT: In some cases it also needs to add a dependency on .
Related: (also includes a few fixes)
cc
I think the last instances of this were fixed by
In the core GNOME, I only came across two not wrapped executables. from package and from . Unfortunately the former cannot be wrapped due to depending on .
Change:
sed -i -e '/install/d' CMakeLists.txt ''; <del> buildInputs = [ cmake zlib libpng bzip2 libusb openssl ]; </del> <ins> buildInputs = [ cmake zlib libpng bzip2 libusb1 openssl ]; </ins> <del> meta = { homepage = "http://planetbeing.lighthouseapp.com/projects/15246-xpwn"; </del> <ins> cmakeFlags = [ "-DCMAKE_OSX_DEPLOYMENT_TARGET=" ]; meta = with stdenv.lib; { homepage    = "http://planetbeing.lighthouseapp.com/projects/15246-xpwn"; </ins> description = "Custom NOR firmware loader/IPSW generator for the iPhone"; <del> license = stdenv.lib.licenses.gpl3Plus; </del> <ins> license     = licenses.gpl3Plus; platforms   = with platforms; linux ++ darwin; </ins> }; }

Discussion:
Trying to build it fails on libusb complaining about '-no-cpp-precomp'. If you replace the libusb dependency with libusb1, it then fails with cmake trouble. Is hydra not building this stuff?
Hydra builds derivation only for the platforms set in meta.platforms. For xpwn meta.platforms is not set, thus hydra does not build it. However I don't have access to a darwin machine so I cannot help with the xpwn problem.
This PR should address similar issues:
Change:
buildPythonPackage rec { pname = "loguru"; <del> version = "0.4.0"; </del> <ins> version = "0.4.1"; </ins> disabled = isPy27; src = fetchPypi { inherit pname version; <del> sha256 = "d5ddf363b7e0e562652f283f74a89bf35601baf16b70f2cd2736a2f8c6638748"; </del> <ins> sha256 = "a6101fd435ac89ba5205a105a26a6ede9e4ddbb4408a6e167852efca47806d11"; </ins> }; checkInputs = [ pytestCheckHook colorama ]; disabledTests = [ "test_time_rotation_reopening" "test_file_buffering" ] <del> ++ stdenv.lib.optionals stdenv.isDarwin [ "test_rotation_and_retention" "test_rotation_and_retention_timed_file" "test_renaming" ]; </del> <ins> ++ stdenv.lib.optionals stdenv.isDarwin [ "test_rotation_and_retention" "test_rotation_and_retention_timed_file" "test_renaming" "test_await_complete_inheritance" ]; </ins> meta = with stdenv.lib; { homepage = https://github.com/Delgan/loguru;

Discussion:
Describe the bug I just tried to update my system today. It updated Flexget from 3.0.31 to 3.1.11. Installation went smooth but flexget ultimatively crashes when running. To Reproduce Steps to reproduce the behavior: flexget it it Expected behavior No crash Actual behavior Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(hyper): channels(root): nixpkgs: Maintainer information: