jiebi/CodeConvo huggingface dataset:
Change:
# - ignore test_ls because impure logic # - ignore test_screen because it assumes vt terminals exist checkPhase = '' <del> pytest -n $NIX_BUILD_CORES .  </del> <ins> pytest .  </ins> ${stdenv.lib.optionalString (stdenv.hostPlatform.isAarch64 || stdenv.hostPlatform.isAarch32) "--ignore=test/t/test_gcc.py"}  --ignore=test/t/test_chsh.py  --ignore=test/t/test_ether_wake.py 

Discussion:
Describe the bug Trying to install the bash-completion package on armv7l fails due to multiple test failures. This seems to be caused by as reverting that commit makes the tests pass. Build log at commit (nixos-unstable when I was testing): Build log at the same commit after : To Reproduce Expected behavior Build succeeds. Screenshots N/A Additional context I'm running this on an Odroid HC2 machine, so native armv7l, not armv7l on AArch64 or something like that. Without xdist the tests take considerably longer to run. Maybe using xdist can be made conditional on the architecture? Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- who introduced the usage of xdist for the tests Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
on IRC pointed out to me that the 8 cores of the HC2 are more than many other armv7l machines, so I ran the tests with instead of . That also fails, but it looks like it's less tests timing out:
I did another run. It's not deterministic. The second try with passed. The original commit already mentions that the tests are flaky. I'm not sure that tests failing gives any meaningful data, at least when the tests are run in parallel.
I'm seeing this as well on the same hardware. I wrote a patch to increase the timeout, but it still fails even if I increase it to 500 seconds if my machine is running other builds. The tests that fail seem pretty much random. If my machine has no load, it succeeds even with the original (30 second) timeout.
I've done some more testing, this time on an x86_64 machine. It's an Intel NUC with an i3-7100U. This is a 2 core/4 thread processor. While the tests usually pass on an unloaded machine, even watching a Youtube video in Chrome at the same time made them fail for me. I also tried with to simulate a heavily loaded system.

With the tests running in parallel they failed more than half the time out of a few runs I did, but having them run serially I couldn't get them to fail at all. I'm sending a pull request to revert the cell that made the tests parallel since I'm a pretty firm believer that flaky tests are worse than no tests.
Change:
<del> { python3Packages, fetchFromGitHub, lib, yubikey-personalization, libu2f-host, libusb1, procps }: </del> <ins> { python3Packages, fetchFromGitHub, lib, yubikey-personalization, libu2f-host, libusb1, procps , stdenv, pyOpenSSLSupport ? !(stdenv.isDarwin && stdenv.isAarch64) }: </ins> python3Packages.buildPythonPackage rec { pname = "yubikey-manager";

Discussion:
on macOS can not include (), but it is used in the derivation: This results in errors like this: Is it possible to use on Darwin and elsewhere? (
Maybe like so: cc
maybe we should just patch the line if we are on non darwin?
Change:
githubId = 568532; name = "Christian Zagrodnick"; }; <ins> zahrun = { email = "zahrun@murena.io"; github = "zahrun"; githubId = 10415894; name = "Zahrun"; }; </ins> zakame = { email = "zakame@zakame.net"; github = "zakame";

Discussion:
Project description An OBS plugin for removing background in portrait images (video), making it easy to replace the background when screen recording. This package was removed in The build might be fixed as of if you don't mind giving it a try Metadata homepage URL: source URL: license: mit platforms: linux, darwin
The maintainer of the project has been active lately and there are a few new releases. Also see And
Change:
<ins> { lib, stdenv, python3, fetchFromGitHub, makeWrapper, schedtool, sysctl, util-linux, fetchpatch }: stdenv.mkDerivation rec { pname = "ananicy"; version = "unstable-2021-11-05"; src = fetchFromGitHub { owner = "nefelim4ag"; repo = "ananicy"; rev = "b8968e9b32b0e4e6a01dc2314e43de8fee9da691"; sha256 = "sha256-tlPY81xdUpZrDYdApXooZ0Mst0n7ARVHyUrmymqg0rk="; }; patches = [ # https://github.com/Nefelim4ag/Ananicy/pull/437 # fix makefile destinations (fetchpatch { url = "https://github.com/Nefelim4ag/Ananicy/commit/dbda0f50670de3f249991706ef1cc107c5197a2f.patch"; sha256 = "sha256-vMcJxekg2QUbm253CLAv3tmo5kedSlw+/PI/LamNWwc="; # only used for debian packaging. lets exclude it so the patch applies even when that file is changed excludes = [ "package.sh" ]; }) # https://github.com/Nefelim4ag/Ananicy/pull/439 # fix syntax error (fetchpatch { url = "https://github.com/Nefelim4ag/Ananicy/commit/0f8b809298ccfd88d0e2ab952d6e4131865246da.patch"; sha256 = "sha256-PWE4F0G97gecgc9HnG7ScA78+QVc8u8aF9u74qVChX0="; }) ]; nativeBuildInputs = [ makeWrapper ]; buildInputs = [ python3 ]; makeFlags = [ "PREFIX=$(out)" "SYSCONFDIR=${placeholder "out"}/etc" ]; dontConfigure = true; dontBuild = true; postInstall = '' wrapProgram $out/bin/ananicy  --prefix PATH : ${lib.makeBinPath [ schedtool util-linux ]} substituteInPlace $out/lib/systemd/system/ananicy.service  --replace "/sbin/sysctl" "${sysctl}/bin/sysctl"  --replace "/usr/bin/ananicy" "$out/bin/ananicy" ''; meta = with lib; { homepage = "https://github.com/Nefelim4ag/Ananicy"; description = "Another auto nice daemon, with community rules support"; license = licenses.gpl3Only; platforms = platforms.linux; maintainers = with maintainers; [ artturin ]; }; } </ins>

Discussion:
Project description Ananicy (ANother Auto NICe daemon) — is a shell daemon created to manage processes' IO and CPU priorities, with community-driven set of rules for popular applications (anyone may add their own rule via github's pull request mechanism). It's mainly for desktop usage. Metadata homepage URL: source URL: license: gpl3 platforms: linux
Change:
<ins> commit c44347b3b813e209fff537b4d46d23430727a5e2 Author: Bernardo Meurer <meurerbernardo@gmail.com> Date:   Tue Feb 25 21:27:39 2020 -0800 makefile: correctly sed paths The default Makefile for tlp makes a mess with catenating `DESTDIR` to everything, but then not actualy using the catenated (_ prefixed) variables to sed it's `.in` files. This patch makes sure that it correctly sets the paths, taking `DESTDIR` in account where it makes sense (e.g. /bin where we want $out/bin) but not where it doesn't (/etc/tlp.conf should be just that). The reason DESTDIR is used at all, as opposed to the more appropriate PREFIX, is covered in the nix formula, and is (also) due to the Makefile being a bit "different." diff --git a/Makefile b/Makefile index b5af74e..95122df 100644 --- a/Makefile +++ b/Makefile @@ -47,17 +47,17 @@ _TPACPIBAT = $(DESTDIR)$(TPACPIBAT) SED = sed  -e "s|@TLPVER@|$(TLPVER)|g"  -	-e "s|@TLP_SBIN@|$(TLP_SBIN)|g"  -	-e "s|@TLP_TLIB@|$(TLP_TLIB)|g"  -	-e "s|@TLP_FLIB@|$(TLP_FLIB)|g"  -	-e "s|@TLP_ULIB@|$(TLP_ULIB)|g"  +	-e "s|@TLP_SBIN@|$(_SBIN)|g"  +	-e "s|@TLP_TLIB@|$(_TLIB)|g"  +	-e "s|@TLP_FLIB@|$(_FLIB)|g"  +	-e "s|@TLP_ULIB@|$(_ULIB)|g"  -e "s|@TLP_CONFUSR@|$(TLP_CONFUSR)|g"  -e "s|@TLP_CONFDIR@|$(TLP_CONFDIR)|g"  -	-e "s|@TLP_CONFDEF@|$(TLP_CONFDEF)|g"  +	-e "s|@TLP_CONFDEF@|$(_CONFDEF)|g"  -e "s|@TLP_CONF@|$(TLP_CONF)|g"  -e "s|@TLP_RUN@|$(TLP_RUN)|g"    -e "s|@TLP_VAR@|$(TLP_VAR)|g"    -	-e "s|@TPACPIBAT@|$(TPACPIBAT)|g" +	-e "s|@TPACPIBAT@|$(_TPACPIBAT)|g" INFILES =  tlp  </ins>

Discussion:
Describe the bug Our current version of tlp, 1.2.1, is ancient and misses the large number of fixes in versions 1.3.0 and 1.3.1. A bump is warranted, but is nontrivial since a lot has changed. Additional context Maintainer information:
cc.
I'm working on this
Change:
preInstall = '' mkdir -p $INCDIR $INSTALLDIR <ins> '' # Workaround for Makefiles.osx not using ?= + lib.optionalString stdenv.isDarwin '' makeFlagsArray+=( "INCDIR=$INCDIR" "INSTALLDIR=$INSTALLDIR" ) </ins> ''; postInstall = lib.optionalString (!stdenv.isDarwin) ''

Discussion:
Describe the bug on current master is broken, but previous version was working. Breakage introduced in , partial fix in To Reproduce Expected behavior Successfully install freeimage. Actual behavior Additional context See comments from onwards. Notify maintainers cc Metadata system: host os: multi-user?: sandbox: version: channels(uri): nixpkgs:
Change:
with self; with super; { attrs = callPackage ../development/python2-modules/attrs { }; <ins> backports-functools-lru-cache = callPackage ../development/python2-modules/backports-functools-lru-cache { }; </ins> bootstrapped-pip = toPythonModule (callPackage ../development/python2-modules/bootstrapped-pip { }); cffi = callPackage ../development/python2-modules/cffi { inherit cffi; };

Discussion:
Steps to reproduce the behavior: I am able to build using July 27's , but not with the more recent s.
I believe this is related to Henceforth, all python2 builds will be broken. I am trying to pin nixpkgs before this commit, and I will report back how it goes.
hey, do you mind giving a try?
I can confirm that pinning python2 to the parent of works for me. I am actually not using fahclient but another python2 package (), but the error message is identical so I didn't bother to open a new issue. Maybe can check?
Change:
{ lib, stdenv, fetchurl, bash, jre }: let mcVersion = "1.16.5"; <del> buildNum = "488"; </del> <ins> buildNum = "771"; </ins> jar = fetchurl { <del> url = "https://papermc.io/api/v1/paper/${mcVersion}/${buildNum}/download"; sha256 = "07zgq6pfgwd9a9daqv1dab0q8cwgidsn6sszn7bpr37y457a4ka8"; </del> <ins> url = "https://papermc.io/api/v1/paper/${mcVersion}/${buildNum}/download"; sha256 = "1lmlfhigbzbkgzfq6knglka0ccf4i32ch25gkny0c5fllmsnm08l"; </ins> }; in stdenv.mkDerivation { pname = "papermc";

Discussion:
Describe the bug Papermc crashes due to an incompatible Java version To Reproduce Steps to reproduce the behavior: Set Log Excerpt Additional context The vanilla package runs without issues. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: channels(johannes): channels(root): nixpkgs: Maintainer information:
I couldn't reproduce with this test driver : <details</details
I also get this. I think papermc starts supporting java 16 with build 668 (at least it seems to start working for me after that build), but the current build in nixpkgs is 488 building the latest build (771) works for me. the test you defined doesn't wait long enough to actually start the server Which I think you need to run with since it requires networking to download the vanilla minecraft jar it will then patch. Now the test fails as expected complaining about the java version. But if you overwrite the papermc package with: the test will succeed. (btw is there a smarter way to overwrite these variables?) Metadata: system: host os: multi-user?: sandbox: version: channels(root): channels(kaine): nixpkgs:
Same thing happens with multimc and the new version
Change:
thirdParty = let inherit (libsForQt5) callPackage; in { plasma-applet-caffeine-plus = callPackage ./3rdparty/addons/caffeine-plus.nix { }; <ins> plasma-applet-virtual-desktop-bar = callPackage ./3rdparty/addons/virtual-desktop-bar.nix { }; </ins> kwin-dynamic-workspaces = callPackage ./3rdparty/kwin/scripts/dynamic-workspaces.nix { }; kwin-tiling = callPackage ./3rdparty/kwin/scripts/tiling.nix { }; krohnkite = callPackage ./3rdparty/kwin/scripts/krohnkite.nix { };

Discussion:
Project description An applet for KDE Plasma panel (or Latte Dock) that lets you switch between virtual desktops and also invoke some actions to dynamically manage them in a convenient way. Metadata homepage URL: source URL: license: gpl3 platforms: linux
Plasma applets are straight forward to do. Do you feel like taking a stab at it? Ping me if you get lost/stuck. Inspiration:
... feel like taking a stab at it? I tried. New to Nix. Don't know Nix language, didn't read Nix pills, got a messy setup to sort out. Long road ahead. Feel free to take over. I tried things and couldn't get it to build the program.
I successfully gave a stab. Please take a look. Note: came out, but was removed eventually. Unsure what to do here, I went for .
Change:
{ stdenv , buildPythonPackage <del> , fetchPypi </del> <ins> , fetchFromGitHub </ins> , mock , nose , pamqp

Discussion:
In current master branch pythonPackages.mysqlclient fails to build. Checkout nixpkgs on revision and run: system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Most likely caused by . Unfortunately, the config-tools are not very configuration friendly. Until is resolved, I would add to the package.
Unfortunately this does not change anything, still failing with the same error message..
Hmm, apparently just hardcodes the path without the ability to override it from the attrset passed to : Is that intentional, Until this is resolved, you can use :
Change:
google-guest-oslogin = callPackage ../tools/virtualization/google-guest-oslogin { }; <del> google-cloud-cpp = callPackage ../development/libraries/google-cloud-cpp { }; </del> <ins> google-cloud-cpp = callPackage ../development/libraries/google-cloud-cpp { abseil-cpp = abseil-cpp.override { cxxStandard = "14"; }; }; </ins> google-java-format = callPackage ../development/tools/google-java-format { };

Discussion:
Build of failed on x86_64-linux as of . This is currently breaking maintainers cc: google-cloud-cpp maintainers cc: Other cc: n/a nixpkgs at commit This issue was automatically generated by . that created this issue. Internal tag:
This has also broken tensorflow-datasets.
Fixed in
Change:
angelfish = libsForQt5.kdeGear.angelfish; # Added 2021-10-06 ansible_2_12 = throw "Ansible 2.12 goes end of life in 2023/05 and can't be supported throughout the 23.05 release cycle"; # Added 2023-05-16 antimicroX = antimicrox; # Added 2021-10-31 <ins> ardour_6 = throw "ardour_6 has been removed in favor of newer versions"; # Added 2023-10-13 </ins> aseprite-unfree = aseprite; # Added 2023-08-26 asls = throw "asls has been removed: abandoned by upstream"; # Added 2023-03-16 asterisk_16 = throw "asterisk_16: Asterisk 16 is end of life and has been removed"; # Added 2023-04-19

Discussion:
is adding ardour 7.0 to the repository. As noted by 7.0 still experiences crashes. Thus we've opted to keep version 6.9 around for a little while for people to optionally use as a more stable base for their projects. Once ardour 7.x (package name ) is deemed stable, ardour 6.x (package name ) should be removed from nixpkgs.
updated to in preparation for 8.0, so this issue should be either closed or updated. Fwiw, maintaining the package of the last stable release of the previous major version seems like a good tradition for Ardour.
Thanks for pointing that out. I agree that keeping (at least) the last version around is helpful for some people who can't update for one reason or another. If someone objects, they can create a new issue.
Change:
} ); in { <del> boost159 = makeBoost ./1.59.nix; boost160 = makeBoost ./1.60.nix; </del> boost165 = makeBoost ./1.65.nix; boost166 = makeBoost ./1.66.nix; boost167 = makeBoost ./1.67.nix;

Discussion:
Steps to reproduce the behavior: Fails on aarch64 `
Is there a use case for boost160? IMHO this will not be fixed as boost 1.60 was released 5 years before M1 existed.
It's currently a dependency of mongodb-34 and mongodb-36. I tried just change that dependency to boost-16x (which currently maps to 1.69), however that breaks the mongodb build. Nothing in nixpkgs seems to depend on those mongodb versions, so maybe remove those as well?
Change:
waybar = callPackage ../applications/misc/waybar {}; <ins> wayshot = callPackage ../tools/misc/wayshot { }; </ins> wbg = callPackage ../applications/misc/wbg { }; hikari = callPackage ../applications/window-managers/hikari {

Discussion:
Project description screenshot tool for wlroots based compositors implementing zwlrscreencopyv1 Metadata homepage URL: source URL: license: bsd platforms: linux
have you looked if any of these packages are not already in ?
yes
Change:
buildPythonPackage rec { pname = "pikepdf"; <del> version = "2.12.2"; </del> <ins> version = "2.16.1"; </ins> disabled = ! isPy3k; src = fetchPypi { inherit pname version; <del> sha256 = "5ff35499b1ae7b181277f78ce5b1bcc8d3009182bb389917791c5dc811fcc8e4"; </del> <ins> sha256 = "sha256-4k3/avMfHrcy/LXbRniDXR8xJkOZb9zZ2+uKylK8Dd4="; </ins> }; buildInputs = [

Discussion:
Steps to reproduce the behavior: Try to install or build the derivation. Successful update. $ sudo nixos-rebuild boot -Q --upgrade Maintainer information:
Can confirm: I see the same on nixpkgs-unstable. Looks like a unicode string representation problem?
Change:
</listitem> <listitem> <para> <ins> <literal>programs.zsh.autosuggestions.strategy</literal> now takes a list of strings instead of a string. </para> </listitem> <listitem> <para> </ins> The <literal>services.unifi.openPorts</literal> option default value of <literal>true</literal> is now deprecated and will be changed to <literal>false</literal> in 22.11. Configurations

Discussion:
From Currently nixpkgs has as an . We should either have as a nix list of enums, or just a string to allow the user to specify a zsh array.
Change:
{ buildGoModule , fetchFromGitHub , lib <ins> , makeWrapper , ncurses </ins> }: buildGoModule rec {

Discussion:
Describe the bug wtf uses the tcell module () for terminal manipulation. For many terminals, this Go module has "terminfo" information build in for most frequently used terminals. For non-supported terminals, it calls out to ncurses' tool and parses it's output. This fails when you happen to use such a terminal. To Reproduce Steps to reproduce the behavior: # official termcap entry Expected behavior It should be able to find and start. Additional context Same as fixed by . Metadata Please run and paste the result.
Change:
in buildGoModule rec { pname = "minio"; <del> version = "2022-03-22T02-05-10Z"; </del> <ins> version = "2022-05-08T23-50-31Z"; </ins> src = fetchFromGitHub { owner = "minio"; repo = "minio"; rev = "RELEASE.${version}"; <del> sha256 = "sha256-N0ua+XHkLr33PElSdOzVQF3POPU+lx4/M6LJzxtkisI="; </del> <ins> sha256 = "sha256-Ssuqk/ax6MWdXtbJqWeTTtsIiTK4FmYSR5rOqxh+IaU="; </ins> }; <del> vendorSha256 = "sha256-Ql3J2r489Hzhy6E9uZwQXJIw/njb5oafCYjOyWGzbXs="; </del> <ins> vendorSha256 = "sha256-JoI3B3rDzlY0lDHF3rjrzv8/Rq+XCFRs35bWVZqfAKA="; </ins> doCheck = false;

Discussion:
, CVSSv3=8.8 (nixos-unstable) MinIO is a High Performance Object Storage released under GNU Affero General Public License v3.0. A security issue was found where an non-admin user is able to create service accounts for root or other admin users and then is able to assume their access policies via the generated credentials. This in turn allows the user to escalate privilege to that of the root user. This vulnerability has been resolved in pull request and is included in . Users unable to upgrade may workaround this issue by explicitly adding a deny policy, however, this, in turn, denies the user the ability to create their own service accounts as well. Scanned versions: nixos-unstable: . Cc Cc Cc
Change:
sha256 = "1bq4733hbh15nwpixpyhqfn3bwkg38amdj2xc0my0pii8l9ln793"; }; <del> patches = [ ./CMakeLists.patch ]; </del> <ins> patches = [ (fetchpatch { name = "fix-compiler-flags.patch"; url = "https://sources.debian.org/data/main/p/photoflow/0.2.8%2Bgit20200114-3/debian/patches/ftbfs"; sha256 = "sha256-DG5yG6M4FsKOykE9Eh5TGd7Z5QURGTTVbO1pIxMAlhc="; }) ./CMakeLists.patch ./fix-build.patch ]; </ins> nativeBuildInputs = [ automake

Discussion:
Steps to reproduce the behavior: Adding fixes the issue. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Change:
ln -s ${pkgs.writeText "sshPublicKey" sshPublicKey} $out/1.0/meta-data/public-keys/0/openssh-key ''; }; <ins> indentLines = str: concatLines (map (s: "  " + s) (splitString "n" str)); </ins> in makeTest { name = "ec2-" + name; nodes = {};

Discussion:
takes an argument that copies source paths into the resulting VM image. It seems to work fine when the sources are files or , but when copying directories, they end up nested inside the target directory named with a nix-store-like path. This is not what I expected, it is hard to use, and I do not think it is the intended behavior. these files: (and additional , see attached ). the VM image with . the VM image, e.g. with . in with credentials literal . that contains a subdirectory with a Nix-store-like path, e.g. instead of . I expected that the source would end up at the target, as happens with contents objects that are files. ! I will have a PR with a test and fix up soon. When changing the behavior of a function that is already widely used, even fixing a bug can cause problems for people. I checked, but I did not find any existing usages of with directories in . And given how broken the directory support seems, I suspect that it is not actually used in the wild, so I think it is okay to fix this behavior. Please run and paste the result.
Change:
}: rustPlatform.buildRustPackage rec { pname = "deno"; <del> version = "1.41.3"; </del> <ins> version = "1.42.3"; </ins> src = fetchFromGitHub { owner = "denoland"; repo = pname; rev = "v${version}"; <del> hash = "sha256-Urcy3kvwBz5Ey0LnoT6/N7V/QJg2SIBHVmWa12WOTKw="; </del> <ins> hash = "sha256-mjMpjbQbj0QyvRU4RRL++zvAxU2ZfMDhDauBC+zIH/g="; </ins> }; <del> cargoHash = "sha256-NhJ3Uldncjx/KHAMVCd6U4Q0fbmc+u4E7JNZHcy/zQY="; </del> <ins> cargoHash = "sha256-xuR7XrcI1O8NB6YY0oGFHxv+eUmt3WX1dXBI9aOOw58="; </ins> postPatch = '' # upstream uses lld on aarch64-darwin for faster builds

Discussion:
Package name: deno Latest released version: 1.42.3 Current version on the unstable channel: 1.41.3 Current version on the stable/release channel: 1.38.2 Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hi I'll look into why there hasn't been a PR opened yet by the bot. The update will probably only go into unstable, just to be clear upfront. There will be a new stable release in the next month or so for . Also I can't edit your issue but your versions for unstable/stable are backwards :)
, in case you didn't find it already. Fixed.
Change:
]; }); <ins> fastapi = super.fastapi.overridePythonAttrs (old: rec { # Flaky test: #     ResourceWarning: Unclosed <MemoryObjectSendStream> # Unclear whether it's flaky in general or only in this overridden package set. doCheck = false; }); </ins> # Ceph does not support `kubernetes` >= 19, see: #     https://github.com/NixOS/nixpkgs/pull/281858#issuecomment-1900324090 kubernetes = super.kubernetes.overridePythonAttrs (old: rec {

Discussion:
Steps to reproduce the behavior: ceph via Happening on current (currently at ), as well as on and . Do note that while this looks like a build failure for , is the one overriding the package version to something incompatible. The unaltered package builds fine. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
See also , which I think should fix this.
Trying to build samba4Full and it errors on the same package. Just for any info for anyone.
I have addressed further review comments in Please somebody review.
Same error today with 'github:nixos/nixpkgs/' (2024-08-18)'