jiebi/CodeConvo huggingface dataset:
Change:
setupHook = ./setup-hook.sh; <del> patches = stdenv.lib.singleton (substituteAll { src = ./absolute_shlib_path.patch; inherit nixStoreDir; }); </del> <ins> patches = [ (substituteAll { src = ./absolute_shlib_path.patch; inherit nixStoreDir; }) # https://github.com/NixOS/nixpkgs/issues/34080 (substituteAll { src = ./absolute_gir_path.patch; cairoLib = "${getLib cairo}/lib"; }) ]; </ins> meta = with stdenv.lib; { description = "A middleware layer between C libraries and language bindings";

Discussion:
The typelib for cairo contains a non-absolute path: This means that the resulting call to will need a correctly set up to succeed. This in turn causes . Other typelibs contain absolute paths into the nix store (tested with the other typelib files from gobject-introspection and with pango 1.40.11). The above fails with . Awesome still tries to continue, but lots of stuff errors out. Sorry, but (a) I don't think this is necessary and (b) I cannot copy&paste from the VM and so this is quite non-trivial for me to provide. But it's x86_64-linux, NixOS 17.09.2799....
This can be actually fixed quite easily: Though there might be a problem with increased closure size?
Is it okay for me to read this as "this stops being broken and now actually depends on its dependencies"? ;-)
The issue is that the is not really needed by , only by the single GIR/typelib file. It would make more sense if the typelib were part of the package but apparently we cannot have nice things.
Libraries should always be hardcoded. What are the sizes with and without the change? I'm not familiar with this code, but maybe we can put it in a separate output.
How do I measure it? ? In that case it is 41M → 56M. That would work but we would need to check all packages depending on if they use the cairo typelib. And could only be found out during runtime.
I suggest merging your fix along with a comment/reference to this issue. Whoever wants to reduce the closure size can then look into multiple-outputs.
I do not really like it but at the moment I do not have time for the effort.
Fix () is in staging.
FYI
Can't we drop the file totally from the package and then patch the package to extract that file from ?
We could but it would make the packages needlessly complex and the different behaviour from upstream might be confusing.
Change:
fetch = { type = "git"; url = "https://go.googlesource.com/sys"; <del> rev = "a43fa875dd82"; sha256 = "0xvwwaqcj02a9n8izs4zrlg8vvz7wffli955i93nc34m1f0w8vyg"; </del> <ins> rev = "19e00faab6ad"; sha256 = "0znjx9xbyjdvk8cafdc1jl22gg29asxl5yl7mi3yz6zx3h39rm8y"; </ins> }; } {

Discussion:
I can't compile on macOS: Metadata system: host os: multi-user?: sandbox: version: channels(eridius): nixpkgs: Maintainer information:
Change:
{ stdenv, lib, fetchurl, fetchpatch, pkg-config, libtool , gtk2-x11, gtk3-x11 , gtkSupport ? null <del> , libpulseaudio, gst_all_1, libvorbis, libcap </del> <ins> , libpulseaudio, gst_all_1, libvorbis, libcap, systemd </ins> , Carbon, CoreServices, AppKit , withAlsa ? stdenv.isLinux, alsa-lib }:

Discussion:
, which is offered by most Linux distributions where is installed, is not present in NixOS. Its systemd services aren't available either. I'd like to be able to have an easy way to play sounds on boot and shutdown and this seems like the usual way to do it on other Linux distributions :grin: Steps to reproduce the behavior: (whether via , option, etc) should be available and executable. systemd services such as , , and should be available to enable. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Probably a NixOS module would be good so it'll be easy to customize.
That doesn't really have a bearing on the PR, as libcanberra would still need to be built with systemd support anyway.
woot! thank you for your work on this! i'm so excited to get this working on my PC
FYI it'll take a couple of weeks to end up in unstable (you can follow for the progress), and you'll then have to add it to as well, but it should work at that point.
Change:
lihop = "Leroy Hopson <nixos@leroy.geek.nz>"; linquize = "Linquize <linquize@yahoo.com.hk>"; linus = "Linus Arver <linusarver@gmail.com>"; <ins> lluchs = "Lukas Werling <lukas.werling@gmail.com>"; </ins> lnl7 = "Daiderd Jordan <daiderd@gmail.com>"; loskutov = "Ignat Loskutov <ignat.loskutov@gmail.com>"; lovek323 = "Jason O'Conal <jason@oconal.id.au>";

Discussion:
H.264 videos and specifically those (WebM and Theora are fine) don't play, which means that videos on Facebook and Twitter (at least) report an error. There are instructions for getting a patched version of the ffmpeg lib installed into your home folder which works, but ideally wouldn't be needed: to that the H.264 video don't work but the others do. System: (NixOS: , Ubuntu/Fedora: , ...) Nix version: (run ) Nixpkgs version: (run ) Sandboxing enabled: (run )
What browser are you using? Works on Chromium, Firefox and qutebrowser (qtwebkit) on master for me.
Vivaldi, hence the title of the issue...
Oh, sorry, didn't know there's a browser called vivaldi.
Change:
<ins> { lib , fetchFromGitHub , buildGoPackage }: # upstream is pretty stale, but it still works, so until they merge module # support we have to use gopath: see sgreben/jp#29 buildGoPackage rec { pname = "json-plot"; version = "1.1.12"; src = fetchFromGitHub { owner = "sgreben"; repo = "jp"; rev = version; hash = "sha256-WWARAh/CF3lGli3VLRzAGaCA8xQyryPi8WcuwvdInjk="; }; goPackagePath = "github.com/sgreben/jp"; meta = with lib; { description = "Dead simple terminal plots from JSON (or CSV) data. Bar charts, line charts, scatter plots, histograms and heatmaps are supported."; homepage = "https://github.com/sgreben/jp"; license = licenses.mit; maintainers = with maintainers; [ urandom ]; mainProgram = "jp"; }; } </ins>

Discussion:
Project description Dead simple terminal plots from JSON (or CSV) data. Bar charts, line charts, scatter plots, histograms and heatmaps are supported. Written in go. Metadata homepage URL: source URL: license: platforms: Issues At the moment ().
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
still import to me
I marked this as stale due to inactivity. &rarr;
Change:
stdenv.mkDerivation rec { pname   = "keycloak"; <del> version = "10.0.2"; </del> <ins> version = "11.0.2"; </ins> src = fetchzip { url    = "https://downloads.jboss.org/keycloak/${version}/keycloak-${version}.zip"; <del> sha256 = "1fn8yd02m0bnvwkbrfxrdnxfab30s0wzm3zxpy63wf3vak7nacma"; </del> <ins> sha256 = "0ayg6cl6mff64qs36djnfs3is4x0pzhk7zwb27cbln77q3icc0j0"; </ins> }; nativeBuildInputs = [ makeWrapper ];

Discussion:
, CVSSv3=8.8 (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives. Cc
Change:
<del> { callPackage, fetchurl }: </del> <ins> { callPackage, fetchurl, fetchpatch }: </ins> callPackage ./generic.nix (rec { version = "1.7";

Discussion:
Trying to install nix-ops on macOS I get the following error (I'm using nixpkgs-unstable) Looking at old issues there were a couple on build being broken on darwin. Is it supposed to work? Using verbose, it seems to be an issue related to libvirt indeed looking at the package definition libvirt59_0 is the package broken on darwin. Perhaps it's impossible to upgrade libvirt in python2 ? I'm not an expert on python, so not sure how to move forward with this one. I'm open to testing ideas for a fix. issue open in nixops as well Metadata Please run and paste the result. Maintainer information:
Change:
assert stdenv.isLinux; # better than `called with unexpected argument 'enableJavaFX'` mavenJdk.buildMavenPackage rec { pname = "cryptomator"; <del> version = "1.9.4"; </del> <ins> version = "1.10.1"; </ins> src = fetchFromGitHub { owner = "cryptomator"; repo = "cryptomator"; rev = version; <del> hash = "sha256-63UXn1ejL/wDx6S2lugwwthu+C+vJovPypgM0iak78I="; </del> <ins> hash = "sha256-xhj7RUurBRq9ZIDAlcq7KyYGnLqc+vTjaf2VMNStpVQ"; </ins> }; mvnParameters = "-Dmaven.test.skip=true"; <del> mvnHash = "sha256-7gv++Pc+wqmVYaAMgHhSy7xwChfVBgpDFxExzu3bXO0="; </del> <ins> mvnHash = "sha256-XAIwKn8wMqILMQbg9wM4kHAaRSGWQaBx9AXQyJuUO5k="; </ins> preBuild = '' VERSION=${version}

Discussion:
Package name: cryptomator Latest released version: 1.10.1Current version on the unstable channel: 1.9.4 Current version on the stable/release channel: 1.8.0 Notify maintainers Note for maintainers: Please tag this issue in your PR.
Change:
$CC -x c code.c -o "$n" ''; <ins> /* concat a list of files to the nix store. * The contents of files are added to the file in the store. * * Examples: * # Writes my-file to /nix/store/<store path> * concatTextFile { *   name = "my-file"; *   files = [ drv1 "${drv2}/path/to/file" ]; * } * # See also the `concatText` helper function below. * * # Writes executable my-file to /nix/store/<store path>/bin/my-file * concatTextFile { *   name = "my-file"; *   files = [ drv1 "${drv2}/path/to/file" ]; *   executable = true; *   destination = "/bin/my-file"; * } */ concatTextFile = { name # the name of the derivation , files , executable ? false # run chmod +x ? , destination ? ""   # relative path appended to $out eg "/bin/foo" , checkPhase ? ""    # syntax checks, e.g. for scripts , meta ? { } }: runCommandLocal name { inherit files executable checkPhase meta destination; } '' file=$out$destination mkdir -p "$(dirname "$file")" cat $files > "$file" (test -n "$executable" && chmod +x "$file") || true eval "$checkPhase" ''; /* * Writes a text file to nix store with no optional parameters available. * * Example: * # Writes contents of files to /nix/store/<store path> * concatText "my-file" [ file1 file2 ] * */ concatText = name: files: concatTextFile { inherit name files; }; /* * Writes a text file to nix store with and mark it as executable. * * Example: * # Writes contents of files to /nix/store/<store path> * concatScript "my-file" [ file1 file2 ] * */ concatScript = name: files: concatTextFile { inherit name files; executable = true; }; </ins> /* * Create a forest of symlinks to the files in `paths'. *

Discussion:
In my config I have and when building it gives me the following error: However if I replace it with it builds without errors. Even weirder, If I do it works without problems. The configuration builds normally system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
Tried surrounding the path in quotes?
wouldn't that make a string and not include the file in the store? As it stands, the files does get included in the store because succeds without problems.
Change:
(stdenv.lib.optionalString stdenv.isDarwin "-framework CoreFoundation") ]; <del> buildInputs = [ fontconfig libffi libtool makeWrapper sqlite gsettings-desktop-schemas gtk3 ] </del> <ins> nativeBuildInputs = [ wrapGAppsHook ]; buildInputs = [ fontconfig libffi libtool sqlite gsettings-desktop-schemas gtk3 ] </ins> ++ stdenv.lib.optionals stdenv.isDarwin [ libiconv CoreFoundation ]; preConfigure = ''

Discussion:
Operations like File -Open crashes DrRacket with the error EDIT: I installed from unstable Install Start Presssystem: host os: multi-user?: sandbox: version: channels(root): channels(simendsjo): nixpkgs:
I strongly suspect it needs . I can take a quick look.
Change:
<ins> { lib , stdenv , fetchFromGitHub , python3 }: stdenv.mkDerivation rec { pname = "dool"; version = "1.2.0"; src = fetchFromGitHub { owner = "scottchiefbaker"; repo = "dool"; rev = "v${version}"; hash = "sha256-e6gLPmxOZBw6htiJ5Ljob2tQ9xB4kjK8vPs/9WMGER4="; }; buildInputs = [ python3 ]; makeFlags = [ "prefix=$(out)" ]; # fix the plugins directory postPatch = '' substituteInPlace dool  --replace  "os.path.abspath(os.path.dirname(sys.argv[0])) + '/plugins/'"  "'$out/share/dool/'" ''; meta = with lib; { description = "Python3 compatible clone of dstat"; homepage = "https://github.com/scottchiefbaker/dool"; changelog = "https://github.com/scottchiefbaker/dool/blob/${src.rev}/ChangeLog"; license = licenses.gpl3Plus; maintainers = with maintainers; [ figsoda ]; platforms = platforms.unix; }; } </ins>

Discussion:
Project description Metadata homepage URL: source URL: license: gpl3 platforms: linux
Change:
aarch64-darwin = "macos-aarch64.dmg"; }; hash = selectSystem { <del> x86_64-linux = "sha256-TQZl5TEAAEeC+/dK4F7nbyPOU3YuXheLwrFY/8eGtoA="; aarch64-linux = "sha256-fnIRQsqg6WxD4ptxJT04jvaqDe7jPJ/zVnBL7k9ph38="; x86_64-darwin = "sha256-gwkCsVdSiWCCd0B3FiSvVnZiPJfWtnAgrAVPZh+nko0="; aarch64-darwin = "sha256-QXG/5AfEQNFDcQhV+oK117bKZnSZ32P4NB4p+qUKQIM="; </del> <ins> x86_64-linux = "sha256-kPpcFkmMzTVo8GYptpp1pyNYsNEFuq6iuEtyewvRA0M="; aarch64-linux = "sha256-hr3TwXIxspgF5my/j7yqPwpcTOTbCcxfd3nVBrEMkJY="; x86_64-darwin = "sha256-pP6BeoSeOzWlsvXLIhMzty4pJ5J1iyokRV191lGM/5w="; aarch64-darwin = "sha256-VjYrq/FyNgLcgMF/eWUmbC9y908qGkMUJ58/rWGXjvs="; </ins> }; in fetchurl {

Discussion:
Package name: dbeaver-bin Latest released version: 24.1.3 <!-- Search your package here: --- Current version on the unstable channel: 24.1.2 Current version on the stable/release channel: 24.0.5 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
} }, "chromedriver": { <del> "version": "98.0.4758.48", "sha256_linux": "1nk3vki803b30mc7ww911l68jfxmpp6mddyq02a3f68893qa2mcf", "sha256_darwin": "09m5vsqfn6qyn3faf2p0dldll6fracjg6z81xzpyp2bh9zp8vk82", "sha256_darwin_aarch64": "04lnbm9wiaz8dlc4qigxakcwghhjc3wvahvl5j80k8agkbv7fdvi" </del> <ins> "version": "98.0.4758.102", "sha256_linux": "054qm8agzj6axvasa7b10cz4jz8zfmmblvvifdnyhn4p3zqx74im", "sha256_darwin": "1m6slaw7lqhlhmjjyaam7c21yyahpi34fv9vldqhra07b5r88dny", "sha256_darwin_aarch64": "0n0lsk75dxv94b2zv25yqysyfbvbqhfql3bbp9abl1jcp00m8s3l" </ins> } }, "beta": {

Discussion:
-To see version with the fixes, 98.0.4758.102 <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
should patch it for and
Thanks. I forgot to push the update yesterday after I got caught up with other stuff... :o (And the source tarball wasn't available for a while - as it sometimes happens)
Change:
nativeBuildInputs = [ patchelf makeWrapper ]; buildInputs = [ cdrkit ] ++ kernel.moduleBuildDependencies; <del> postPatch = '' </del> <ins> prePatch = '' </ins> substituteInPlace src/vboxguest-${version}/vboxvideo/vbox_ttm.c  --replace "<ttm/" "<drm/ttm/" <ins> ${dos2unix}/bin/dos2unix src/vboxguest-${version}/vboxguest/r0drv/linux/mp-r0drv-linux.c </ins> ''; <ins> patchFlags = [ "-p1" "-d" "src/vboxguest-${version}" ]; # Kernel 5.3 fix, should be fixed with VirtualBox 6.0.14 # https://www.virtualbox.org/ticket/18911 patches = [ ./kernel-5.3-fix.patch ]; </ins> unpackPhase = '' ${if stdenv.hostPlatform.system == "i686-linux" || stdenv.hostPlatform.system == "x86_64-linux" then '' isoinfo -J -i $src -x /VBoxLinuxAdditions.run > ./VBoxLinuxAdditions.run

Discussion:
Describe the bug I am no longer able to build VirtualBox with guest additions when switching over to the lastest linux kernel: . The error complains that headers are missing/not found. This bug occurs consistently across all 3 of my machines. I am still able to build VirtualBox without guest additions. To Reproduce Here is the relevant snippet of my Additional context Here is the relevant errors from using Metadata Nix Info: Maintainer information:
Just hit the same thing myself too, very inconvenient to say the least.
Me too, is there any workaround?
No I never found a fix. In the end I had to remove VBox Guest.
It seems the only way to work around this is not to use boot.kernelPackages = pkgs.linuxPackages_latest;
Can you check whether this is still the case on the branch? I was able to build that with the same configuration as above:
I take that back - it's now failing at a later stage: This looks like we're missing a patch similar to the one in
agreed, that looks to be the exact same file that was patched in the host version of a VirtualBox. I did a quick search for an upstream bug for vboxguest but couldn't find anything. Perhaps it gets copied from the same source in the build process. I could try applying the same patch to vboxguest and alter the paths to see what happens. I won't have the opportunity to try that out until tonight (North America, west cost). So if you or someone else want to try it out sooner let me know.
Fix in , please test :-)
Change:
package = mkOption { type = types.path; <del> description = "The Xwayland package"; </del> <ins> default = pkgs.xwayland.override (oldArgs: { inherit (cfg) defaultFontPath; }); defaultText = literalExample '' pkgs.xwayland.override (oldArgs: { inherit (config.programs.xwayland) defaultFontPath; }); ''; description = "The Xwayland package to use."; </ins> }; };

Discussion:
Describe the bug Attempting to override the Wayland package used by with fails with a conflict error: To Reproduce Ensure you have the following channels set up: Add the following to your : Expected behavior XWayland v21.1.2 should be installed. Additional context These are the exact commits I'm on: Notify maintainers Metadata Maintainer information:
you can use as a "workaround" (also requires in ). we should likely apply this change to the XWayland package: Ideally with to provide a nice textual example in , etc.
Thanks! The workaround did the trick.
Change:
containers-ip containers-tmpfs containers-ephemeral <ins> containers-unified-hierarchy </ins> ; }; };

Discussion:
Containers spawned by nixos-container fall back to old cgroup hierarchy, which does not support proper delegation of resource limits to processes running in that container. Steps to reproduce the behavior: will show Tainted: cgroupsv1 will show a mount This will be allowed to consume all memory of the machine until it runs out, the 4G cap is not enforced I expected the container to use a unified cgroup hierarchy, same as on the host, with full delegation and control over its subtree.
This is the log from , using declarative containers: I thought it could be relevant, but after googling around, these seem like errors that happen after systemd decided to use cgroupv1. I'm not sure how to debug its decision to use legacy cgroups inthe first place.
According to , systemd-nspawn tries to detect the systemd-version used in the container by locating a shared library with the version of systemd in the name. you can see the paths searched. The lookup fails on nix-based containers and systemd-nspawn falls back to legacy cgroups. You can test this yourself by symlinking from your Nix store to in your container. After restarting, reports .
Thanks, that was it. I also noticed this in the code But the following is not enough to enable it: Running didn't help either, so I'm not sure how you're supposed to use it. Should we add a symlink as a workaround? I think it'd make sense to fix it for all users of nixos-containers by defining it somewhere around here:
According to , This is not what we want. The environment variable is a good find though. I'm not sure why did not work for you, but adding to the following line worked. Can you reproduce this fix? PS: A PR fixing this issue would ideally include a regression test (almost like ) checking if the container runs with .
That worked! I can see with that the container is no longer tainted. Working on a PR now
Change:
dataDir = mkOption { type = types.path; <ins> defaultText = "/var/lib/postgresql/${config.services.postgresql.package.psqlSchema}"; </ins> example = "/var/lib/postgresql/11"; description = '' <del> Data directory for PostgreSQL. </del> <ins> The data directory for PostgreSQL. If left as the default value this directory will automatically be created before the PostgreSQL server starts, otherwise the sysadmin is responsible for ensuring the directory exists with appropriate ownership and permissions. </ins> ''; };

Discussion:
Describe the bug A clear and concise description of what the bug is. I have The error I got when starting the service is:
The folder is owned by user postgres:
what are the permissions on ?
it's
it works if I set it to but is created by the build/installation. why doesn't it set the right permission?
Looks line should be a one time required step and you're good to go :+1: Looks like with both and together pushes permissions up to all new parent directories. The module is still using (which is deprecated) so the module should be updated to remove that and fix your issue at the same time. Thanks for reporting!
Thank you for your help!
Change:
"test_auto_session_tracking_with_aggregates" # Network requests to public web "test_crumb_capture" <ins> # TypeError: cannot unpack non-iterable TestResponse object "test_rpc_error_page" </ins> ]; disabledTestPaths = [

Discussion:
Build of failed on x86_64-linux as of . This is currently breaking maintainers cc: maintainers cc: Other cc: n/a nixpkgs at commit This issue was automatically generated by . that created this issue. Internal tag:
can confirm for and
I'm trying to bisect this atm, but it's a truly massive undertaking since there's hundreds of commits between current master and the last successful build... plus there's lots of other irrelevant failures :/
I was unable to find the exact commit that caused these failures, since it was interlaced a bunch of other commits that broke dependencies. Created upstream. We'll see what they say. We're not doing any patching of required dependency versions, so the test suite ought to be passing.
I also tried bisecting. Due to the massive rebuilds, I canceled after 8 hours and did a bisect with . The bad commit is from , which is a merge from staging with changes to python and others: <details</detailsLooking at the there is a requirement for werkzeug < 2.1.0. When applied, the test mostly pass. The only failing test is: There is also a requirement for pytest < 7. Since this packaged builds with the latest nixos/unstable, which includes pytest 7.0.1 I am now testing with that version.
The updates usually breaks the package. I guess from 1.5.7 to 1.5.8. Edit: Was part of
Further investigation: When I apply the following two changes: downgrade to downgrade to sentry-sdk builds without issues. How should we go about this? Just disabling the tests could lead to malfunction of the sentry-sdk package (because they did correctly detected a regression in the SDK). Downgrading both packages Adding an override in for those two packages could lead to potential breakages due to dual imports of two different or imports in packages, which import sentry-sdk and one of the two packages. Obviously it would be awesome if upstream update their end of the SDK of werkzeug. This could take some time and sentry-sdk is needed by other packages.
I notified the authors of the breaking commits and
Another breakage is pgadmin (tracked in )
Module can't have overrides. Thus, till the issues are fixed by upstream the failing tests should be disabled.
This issue has been mentioned on NixOS Discourse. There might be relevant details there: