jiebi/CodeConvo huggingface dataset:
Change:
python3Packages.pexpect python3Packages.pytest bashInteractive <del> # use xdist to speed up the test run, just like upstream: # https://github.com/scop/bash-completion/blob/009bf2228c68894629eb6fd17b3dc0f1f6d67615/test/requirements.txt#L4 python3Packages.pytest_xdist </del> ]; # - ignore test_gcc on ARM because it assumes -march=native

Discussion:
Describe the bug Trying to install the bash-completion package on armv7l fails due to multiple test failures. This seems to be caused by as reverting that commit makes the tests pass. Build log at commit (nixos-unstable when I was testing): Build log at the same commit after : To Reproduce Expected behavior Build succeeds. Screenshots N/A Additional context I'm running this on an Odroid HC2 machine, so native armv7l, not armv7l on AArch64 or something like that. Without xdist the tests take considerably longer to run. Maybe using xdist can be made conditional on the architecture? Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- who introduced the usage of xdist for the tests Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
on IRC pointed out to me that the 8 cores of the HC2 are more than many other armv7l machines, so I ran the tests with instead of . That also fails, but it looks like it's less tests timing out:
I did another run. It's not deterministic. The second try with passed. The original commit already mentions that the tests are flaky. I'm not sure that tests failing gives any meaningful data, at least when the tests are run in parallel.
I'm seeing this as well on the same hardware. I wrote a patch to increase the timeout, but it still fails even if I increase it to 500 seconds if my machine is running other builds. The tests that fail seem pretty much random. If my machine has no load, it succeeds even with the original (30 second) timeout.
I've done some more testing, this time on an x86_64 machine. It's an Intel NUC with an i3-7100U. This is a 2 core/4 thread processor. While the tests usually pass on an unloaded machine, even watching a Youtube video in Chrome at the same time made them fail for me. I also tried with to simulate a heavily loaded system.

With the tests running in parallel they failed more than half the time out of a few runs I did, but having them run serially I couldn't get them to fail at all. I'm sending a pull request to revert the cell that made the tests parallel since I'm a pretty firm believer that flaky tests are worse than no tests.
Change:
--replace "psselect" "${psutils}/bin/psselect" '' + stdenv.lib.optionalString (netpbm != null) '' substituteInPlace src/preproc/html/pre-html.cpp  <del> --replace "pnmcut" "${netpbm}/bin/pnmcut"  --replace "pnmcrop" "${netpbm}/bin/pnmcrop"  --replace "pnmtopng" "${netpbm}/bin/pnmtopng" </del> <ins> --replace "pnmcut" "${stdenv.lib.getBin netpbm}/bin/pnmcut"  --replace "pnmcrop" "${stdenv.lib.getBin netpbm}/bin/pnmcrop"  --replace "pnmtopng" "${stdenv.lib.getBin netpbm}/bin/pnmtopng" </ins> substituteInPlace tmac/www.tmac  <del> --replace "pnmcrop" "${netpbm}/bin/pnmcrop"  --replace "pngtopnm" "${netpbm}/bin/pngtopnm"  --replace "@PNMTOPS_NOSETPAGE@" "${netpbm}/bin/pnmtops -nosetpage" </del> <ins> --replace "pnmcrop" "${stdenv.lib.getBin netpbm}/bin/pnmcrop"  --replace "pngtopnm" "${stdenv.lib.getBin netpbm}/bin/pngtopnm"  --replace "@PNMTOPS_NOSETPAGE@" "${stdenv.lib.getBin netpbm}/bin/pnmtops -nosetpage" </ins> ''; buildInputs = [ ghostscript psutils netpbm perl ];

Discussion:
no $ Add to installPhase
For some reason netpbm is installing the symlink to . Will be fixed by

Describe the bug Netpbm misses TIFF converters, such as . To Reproduce Steps to reproduce the behavior: to find some commands. Expected behavior TIFF converters installed with Netpbm. Additional context libtiff is required to build the following Netpbm programs: , , and (). Indeed is input for the , but TIFF converters are missed. Metadata output:
Change:
<del> { lib , rustPlatform , fetchFromGitHub , pkg-config , clang , ffmpeg , openssl , alsa-lib , libclang , opencv </del> <ins> { lib, rustPlatform, fetchFromGitHub, pkg-config, clang, ffmpeg, openssl, alsa-lib, libclang, opencv, makeWrapper, </ins> }: rustPlatform.buildRustPackage rec { pname = "tplay";

Discussion:
I think this is not actually a build failure, but it does make the package unusable without manually specifying an additional dependency. Steps to reproduce the behavior: using the package on a system without a pre-existing ffprobe installation (for example in a ) on a local mp4 or png file To try and solve the problem, I read the error message and tried to install ffprobe, so I searched for in nix packages, and tried re-running with the first result : , and it worked fine. So I hope the fix is trivial and can be done quickly. As I'm a newcomer to nix and NixOS, I prefer not to try and fix it myself, but i'll make sure to read the PR to hopefully by able to make such a simple fix myself next time <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
outputs = [ "bin" "dev" "out" "man" ] ++ optional withDocs "doc"; setOutputFlags = false; <del> separateDebugInfo = !(stdenv.hostPlatform.useLLVM or false) && stdenv.cc.isGNU; </del> <ins> separateDebugInfo = !(stdenv.hostPlatform.useLLVM or false) && stdenv.hostPlatform == stdenv.buildPlatform # unable to fix infinite recursion on stdenv.cc && stdenv.cc.isGNU; </ins> nativeBuildInputs = [ perl ]; buildInputs = stdenv.lib.optional withCryptodev cryptodev;

Discussion:
Describe the bug Cross-compilation is broken since we bumped to glibc 2.30. To Reproduce Maintainer information:
I opened a workaround PR :arrow_up: Cross (boot) is probably best known by &ndash; in case you know pointers how to fix this better. (Possibly later; I don't expect we want to wait long with this PR.)
Change:
<ins> { lib, stdenv, alsa-lib, autoPatchelfHook, fetchFromGitHub, godot_4, godot_4-export-templates, libGL, libpulseaudio, libX11, libXcursor, libXext, libXi, libXrandr, nix-update-script, udev, vulkan-loader, }: let preset = if stdenv.isLinux then if stdenv.is64bit then "Linux/X11 64-bit" else "Linux/X11 32-bit" else if stdenv.isDarwin then "Mac OSX" else throw "unsupported platform"; godot_version_folder = lib.replaceStrings [ "-" ] [ "." ] godot_4.version; in stdenv.mkDerivation (finalAttrs: { pname = "pixelorama"; version = "1.0.1"; src = fetchFromGitHub { owner = "Orama-Interactive"; repo = "Pixelorama"; rev = "v${finalAttrs.version}"; hash = "sha256-lfim5ZiykOhI1kgsu0ni2frUVHPRIPJdrGx6TuUQcSY="; }; strictDeps = true; nativeBuildInputs = [ autoPatchelfHook godot_4 ]; runtimeDependencies = map lib.getLib [ alsa-lib libGL libpulseaudio libX11 libXcursor libXext libXi libXrandr udev vulkan-loader ]; buildPhase = '' runHook preBuild export HOME=$(mktemp -d) mkdir -p $HOME/.local/share/godot/export_templates ln -s "${godot_4-export-templates}" "$HOME/.local/share/godot/export_templates/${godot_version_folder}" mkdir -p build godot4 --headless --export-release "${preset}" ./build/pixelorama runHook postBuild ''; installPhase = '' runHook preInstall install -D -m 755 -t $out/libexec ./build/pixelorama install -D -m 644 -t $out/libexec ./build/pixelorama.pck install -D -m 644 -t $out/share/applications ./Misc/Linux/com.orama_interactive.Pixelorama.desktop install -D -m 644 -T ./assets/graphics/icons/icon.png $out/share/icons/hicolor/256x256/apps/pixelorama.png install -d -m 755 $out/bin ln -s $out/libexec/pixelorama $out/bin/pixelorama runHook postInstall ''; passthru.updateScript = nix-update-script { }; meta = with lib; { homepage = "https://orama-interactive.itch.io/pixelorama"; description = "Free & open-source 2D sprite editor, made with the Godot Engine!"; changelog = "https://github.com/Orama-Interactive/Pixelorama/blob/${finalAttrs.src.rev}/CHANGELOG.md"; license = licenses.mit; platforms = [ "i686-linux" "x86_64-linux" ]; maintainers = with maintainers; [ felschr ]; mainProgram = "pixelorama"; }; }) </ins>

Discussion:
Package name: Pixelorama Latest released version: 1.0 <!-- Search your package here: --- Current version on the unstable channel: 0.11.4 Current version on the stable/release channel: 0.11.4 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<del> { lib, stdenv, fetchurl, pkg-config, wrapGAppsHook, intltool, libgpod, libxml2, curl, flac , gnome, gtk3, gettext, perlPackages, flex, libid3tag, gdl , libvorbis, gdk-pixbuf }: stdenv.mkDerivation rec { version = "2.1.5"; pname = "gtkpod"; src = fetchurl { url = "mirror://sourceforge/gtkpod/${pname}-${version}.tar.gz"; sha256 = "0xisrpx069f7bjkyc8vqxb4k0480jmx1wscqxr6cpq1qj6pchzd5"; }; postPatch = '' sed -i 's/which/type -P/' scripts/*.sh ''; nativeBuildInputs = [ pkg-config wrapGAppsHook intltool ]; buildInputs = [ curl gettext flex libgpod libid3tag flac libvorbis libxml2 gtk3 gdk-pixbuf gdl gnome.adwaita-icon-theme gnome.anjuta ] ++ (with perlPackages; [ perl XMLParser ]); # Workaround build failure on -fno-common toolchains like upstream # gcc-10. Otherwise build fails as: #   ld: .libs/autodetection.o:/build/gtkpod-2.1.5/libgtkpod/gtkpod_app_iface.h:248: multiple definition of #       `gtkpod_app'; .libs/gtkpod_app_iface.o:/build/gtkpod-2.1.5/libgtkpod/gtkpod_app_iface.h:248: first defined here env.NIX_CFLAGS_COMPILE = "-fcommon"; enableParallelBuilding = true; meta = with lib; { description = "GTK Manager for an Apple ipod"; homepage = "https://sourceforge.net/projects/gtkpod/"; license = licenses.gpl2Plus; platforms = platforms.linux; maintainers = [ ]; }; } </del>

Discussion:
If my sources are correct, the Project was archived in 2022 and the link for the Hompage now redirects to an indonesian gambling site. Linking to the could be better, but the Homepage link (on mentioned repo) also links to the gambling site.
The github repo does not look official. That would be But maybe it is time to remove it.
Considering the archived repo also links to the lapsed domain that now redirects to a gambling site, I'd be in favour of removal. However, that will also necessitate the removal of , which hasn't seen any updates since 2015. Neither has any maintainers, so I don't think the removal is likely to be objected to.
Change:
enabled = nvidia_x11 != null; cfg = config.hardware.nvidia; pCfg = cfg.prime; syncCfg = pCfg.sync; offloadCfg = pCfg.offload; primeEnabled = syncCfg.enable || offloadCfg.enable; <ins> nvidiaPersistencedEnabled =  cfg.nvidiaPersistenced; </ins> in {

Discussion:
As described here it would be useful to add an option in to add a systemd entry which forces GPU's to always be online even in headless systems. Here is what the extracted systemd service would look like (taken from )
Change:
<ins> { fetchFromGitHub, fetchurl, lib, rustPlatform }: rustPlatform.buildRustPackage rec { pname = "freshfetch"; version = "0.2.0"; src = fetchFromGitHub { owner = "k4rakara"; repo = pname; rev = "v${version}"; sha256 = "1l9zngr5l12g71j85iyph4jjri3crxc2pi9q0gczrrzvs03439mn"; }; cargoLock = { # update Cargo.lock every new release of freshfetch lockFile = ./Cargo.lock; outputHashes = { "clml_rs-0.3.0" = "0hvd59zh7czk9jd1a2wwcm1acpcfbz32v9ka7ap6f74d638jcc19"; }; }; # freshfetch depends on rust nightly features RUSTC_BOOTSTRAP = 1; meta = with lib; { description = "A fresh take on neofetch"; homepage = "https://github.com/k4rakara/freshfetch"; license = licenses.mit; maintainers = with maintainers; [ figsoda ]; }; } </ins>

Discussion:
Project description Freshfetch is an alternative to Neofetch written in Rust with a focus on customization. Metadata homepage URL: source URL: license: mit platforms: Linux
Change:
<del> { lib, stdenv, fetchFromGitHub, openssl, nss, nspr, libkrb5, gmp, zlib, libpcap, re2 , gcc, python3Packages, perl, perlPackages, makeWrapper, }: </del> <ins> { lib, stdenv, fetchFromGitHub, openssl, nss, nspr, libkrb5, gmp, zlib, libpcap, re2, gcc, python3Packages, perl, perlPackages, withOpenCL ? true, opencl-headers, ocl-icd, substituteAll, makeWrapper, }: </ins> stdenv.mkDerivation rec { pname = "john";

Discussion:
Project description Is it possible to add OpenCL support to ? Details can be found by link below: Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I tried but I'm getting a weird linker error: I have no idea what causes it. Looking at the source, it looks perfectly fine.
CC
Worked around it with . PR:
Change:
}; inherit (callPackages ../development/libraries/libressl { }) <del> libressl_3_4 </del> libressl_3_6 libressl_3_7;

Discussion:
LibreSSL 3.4 is no longer supported upstream. It became unsupported on October 14th 2022, one year after . At the time of writing, 3.5 and 3.6 are both supported. that fixes a serious vulnerability: I suspect (but haven’t verified) that this vulnerability is present in LibreSSL 3.4. It is time to remove it from Nixpkgs. However, there are some packages that still depend on it. all depend on . I tried building against and , but both fail. I don’t see any packages that depend on , so I think we could remove the older versions, if we can first update FoundationDB to a version that is compatible with a more recent LibreSSL release. Maybe will be sufficient for this. Alternatively, we might patch FoundationDB. The compilation errors are about an incomplete type for which only a forward declaration is known. I haven’t looked into it deeply but it may be easy to fix. as the maintainers of , what are your thoughts on this? This has been addressed by . <details<summaryOriginal comment</summaryThe other package that explicitly depends on LibreSSL 3.4 is . This is a proprietary package so I couldn’t test if it is compatible with a more recent LibreSSL release, it might actually be. as the maintainers of , could you try and see if it is compatible with a newer LibreSSL release? </details
The x400Address issue that was patched recently is present in LibreSSL 3.4. The fix is very small and applies to all older versions that have it, so it might be an option [patch it][1] while you sort out the other issues. If you could share build logs for the foundationdb issues I can take a look if you want. [1]:
You can drop this. uses their bundled OpenSSL and drops the dependency since it's incompatible with even this LibreSSL version. It's about to merge.
all of darwin depends on 34 at the moment. You've pinned to 3.4, do you know if by any chance we can upgrade to 3.5 ? maybe ?
I'm quite sure we can't. My history with that package is and . happened, because someone did .

iirc happened, because this package depends on ancient long unsupported openssl APIs that weren't part of anymore.
Small rectification, after a bit more testing, it doesn't appear to be all of darwin that is impacted by that change. So perhaps we don't need to put too much effort into this. I'm still trying to figure out the impact.
I’m working on a fix for , which drops the dependency on from by unconditionally dropping Unbound from the build (instead of only on aarch64-darwin). Apple doesn’t even include Unbound in macOS anymore, and it’s not present in newer source releases. That should remove as a blocker for dropping LibreSSL 3.4.
Change:
<ins> --- a/osdep/mac/input_helper.swift +++ b/osdep/mac/input_helper.swift @@ -18,6 +18,14 @@ import Cocoa import Carbon.HIToolbox +extension NSCondition { +    fileprivate func withLock<T>(_ body: () throws -> T) rethrows -> T { +        self.lock() +        defer { self.unlock() } +        return try body() +    } +} + class InputHelper: NSObject { var option: OptionHelper? var lock = NSCondition() --- a/audio/out/ao_avfoundation.m +++ b/audio/out/ao_avfoundation.m @@ -312,7 +312,8 @@ +    #if __MAC_OS_X_VERSION_MAX_ALLOWED >= 120000 p->observer = [[AVObserver alloc] initWithAO:ao]; NSNotificationCenter *center = [NSNotificationCenter defaultCenter]; [center addObserver:p->observer selector:@selector(handleRestartNotification:) name:AVSampleBufferAudioRendererOutputConfigurationDidChangeNotification object:p->renderer]; [center addObserver:p->observer selector:@selector(handleRestartNotification:) name:AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification object:p->renderer]; - +    #endif return CONTROL_OK; </ins>

Discussion:
Package name: Latest released version: <!-- Search your package here: --- Current version on the unstable channel: Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Yeeessaah!
Change:
{ lib, stdenv, fetchFromGitHub <del> , fetchpatch </del> , addOpenGLRunpath , wrapGAppsHook , cmake

Discussion:
Steps to reproduce the behavior: cemu In ImGui changelog for 1.90.2: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --cc Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Always paste the full log or big parts from it, not just the short log.
my build log failure
apparently decided to ignore this build failure in . Not sure why we even have tests if we just blindly ignore them.
Change:
inherit patches; <del> installFlags = [ "PREFIX=$(out)" ]; </del> <ins> makeFlags = [ "PREFIX=$(out)" ]; </ins> # Add run-time dependencies to PATH. Append them to PATH so the user can # override the dependencies with their own PATH.

Discussion:
Functionality that relies on (vertical/horizontal scrolling for the 2.1 release) does not work with the (unpatched) version in Nixpkgs. surf (built without patches). to a page that requires scrolling to observe all content. that ctrl+j, ctrl+k, etc. does not scroll the page. Confirmed to be working for surf 2.1 (the current version we have in Nixpkgs) on non-NixOS distribution using their own package manager. Will attempt to have a look at this if I can find the cycles, but I am not intimately familiar with WebKit.
The “offending” commit seems to be which introduced pipe-based communication with the WebKitWebExtension.
Change:
inherit lua; inherit (stdenv.lib) maintainers; <ins> # helper functions for dealing with LUA_PATH and LUA_CPATH getPath       = lib : type : "${lib}/lib/lua/${lua.luaversion}/?.${type};${lib}/share/lua/${lua.luaversion}/?.${type}"; getLuaPath    = lib : getPath lib "lua"; getLuaCPath   = lib : getPath lib "so"; </ins> #define build lua package function buildLuaPackage = callPackage ../development/lua-modules/generic lua;

Discussion:
does not build as the dependency is not supported on . With set to true the dependency fails to build. System: OS X Darwin 15.5.0 x8664 Nix version: 1.11.2 Nixpkgs version: 16.09pre-git /cc
Change:
<ins> { lib, stdenvNoCC, fetchFromGitHub, gitUpdater, gnome-themes-extra, gtk-engine-murrine, jdupes, sassc, themeVariants ? [ ], # default: blue colorVariants ? [ ], # default: all sizeVariants ? [ ], # default: standard tweaks ? [ ], }: let pname = "fluent-gtk-theme"; in lib.checkListOfEnum "${pname}: theme variants" [ "default" "purple" "pink" "red" "orange" "yellow" "green" "teal" "grey" "all" ] themeVariants lib.checkListOfEnum "${pname}: color variants" [ "standard" "light" "dark" ] colorVariants lib.checkListOfEnum "${pname}: size variants" [ "standard" "compact" ] sizeVariants lib.checkListOfEnum "${pname}: tweaks" [ "solid" "float" "round" "blur" "noborder" "square" ] tweaks stdenvNoCC.mkDerivation (finalAttrs: { inherit pname; version = "2024-06-12"; src = fetchFromGitHub { owner = "vinceliuice"; repo = "fluent-gtk-theme"; rev = finalAttrs.version; hash = "sha256-ONhW68UUrFiv5hxkR7XI8U/5+qM+tYLIS2OM05pqJi0="; }; nativeBuildInputs = [ jdupes sassc ]; buildInputs = [ gnome-themes-extra ]; propagatedUserEnvPkgs = [ gtk-engine-murrine ]; postPatch = '' patchShebangs install.sh ''; installPhase = '' runHook preInstall name= HOME="$TMPDIR" ./install.sh  ${lib.optionalString (themeVariants != [ ]) "--theme " + builtins.toString themeVariants}  ${lib.optionalString (colorVariants != [ ]) "--color " + builtins.toString colorVariants}  ${lib.optionalString (sizeVariants != [ ]) "--size " + builtins.toString sizeVariants}  ${lib.optionalString (tweaks != [ ]) "--tweaks " + builtins.toString tweaks}  --icon nixos  --dest $out/share/themes jdupes --quiet --link-soft --recurse $out/share runHook postInstall ''; passthru.updateScript = gitUpdater { }; meta = { description = "Fluent design gtk theme"; changelog = "https://github.com/vinceliuice/Fluent-gtk-theme/releases/tag/${finalAttrs.version}"; homepage = "https://github.com/vinceliuice/Fluent-gtk-theme"; license = lib.licenses.gpl3Only; platforms = lib.platforms.unix; maintainers = with lib.maintainers; [ luftmensch-luftmensch romildo ]; }; }) </ins>

Discussion:
Package name: fluent-gtk-theme Latest released version: 2024-06-12 <!-- Search your package here: --- Current version on the unstable channel: 2024-04-28 Current version on the stable/release channel: 2024-04-28 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]: