jiebi/CodeConvo huggingface dataset:
Change:
example = '' BrowsePoll cups.example.com <del> LogLevel debug </del> <ins> MaxCopies 42 </ins> ''; description = '' Extra contents of the configuration file of the CUPS daemon

Discussion:
The documentation for the option suggests that it can b used to set the . However, the initial value of also includes , overriding the value potentially given by the user. Try setting and be surprised when produces no more output than it did previously. Examine and find that in the initial value of appears after the overridden value.
Change:
+ lib.optionalString cudaSupport '' export CC=${cudatoolkit.cc}/bin/cc export CXX=${cudatoolkit.cc}/bin/c++ <del> export TORCH_CUDA_ARCH_LIST="${gpuTargetString}" </del> <ins> export TORCH_CUDA_ARCH_LIST="${lib.concatStringsSep ";" cudaCapabilities}" </ins> export FORCE_CUDA=1 '';

Discussion:
I discovered today that overriding torchvision with does not work. At least not without making corresponding changes to torch. For example, We should either remove this argument and pull from torch or improve the ergonomics here somehow. cc Checkout nixpkgs at a relatively recent master commit, eg , and then run
can you test if fixes the problem? To be honest, including the argument for was a mistake in the first place -- it should (must?) use whatever was built with, so it should be inherit directly.
Maybe assert torch.cudaSupport is more explicit? Idk
I'm not super comfortable with asserts in the derivation because (afaik) they can't be overridden. Thoughts on me updating to ensure either both are compiled with CUDA, or neither are?
I understand it's a compromise. IIRC if we set here, we'll just exclude the broken package from ofborg and nixpkgs-review, contrary to the purpose.
Why do we need to be asserting or marking things as broken depending on ? shouldn't it build fine either way?
So the question is, should use , or should it accept as an argument and then possibly . I think that silently using may be surprising to people, but then again we're discussing some furnish while the thing is broken xD
ohhh i see, yeah that's tricky. i could envision someone creating a nix-shell with both and and then being very surprised to learn that is not built with CUDA support

From a brief look at the updated cuda section in the manual, it would be logical to take as an argument, rather than the compiled string. And to expose that in via gets even further beyond the scope, so let's skip it Originally posted by in
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Change:
preConfigure = '' unset CPP # intereferes with dependency calculation <ins> '' + optionalString stdenv.hostPlatform.isMusl '' NIX_CFLAGS_COMPILE+=" -D_LINUX_SYSINFO_H" </ins> ''; configureFlags =

Discussion:
Qemu 2.12.0 has released today. We need to update package. Please run and paste the results.
Change:
substituteInPlace ddclient  --replace 'in the output of ifconfig' 'in the output of ip addr show'  --replace 'ifconfig -a'               '${iproute}/sbin/ip addr show'  <del> --replace 'ifconfig $arg'             '${iproute}/sbin/ip addr show $arg' </del> <ins> --replace 'ifconfig $arg'             '${iproute}/sbin/ip addr show $arg'  # Until we get the patchShebangs fixed (issue #55786) we need to patch this manually --replace '/usr/bin/perl'		    '${perl}/bin/perl' </ins> ''; installPhase = ''

Discussion:
Right now if you update the unstable tree and install ddclient the shebang patch is not applied properly and the first line of the script starts with: This reference doesn't exist so the actual binary cannot be started. ) Install ddclient ) Attempt to start ddclient
Change:
pytest sphinx flake8 pytestpep8 pytest-flakes pytestcov pytestcache freezegun ]; <del> # ignore tests on the nix wrapped setup.py and don't flake .eggs directory </del> <ins> # ignore tests on the nix wrapped setup.py </ins> checkPhase = '' runHook preCheck <del> ${python.interpreter} setup.py test --addopts "--ignore=.eggs" </del> <ins> ${python.interpreter} setup.py test </ins> runHook postCheck '';

Discussion:
Describe the bug When trying to build the package To Reproduce Any of look at Additional context According to , wasn't changed itself, so probably the python framework changed in a way such that you can't give manually anymore. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(turion): nixpkgs: Maintainer information:
Change:
# https://github.com/kolloch/crate2nix/blame/5b19c1b14e1b0e5522c3e44e300d0b332dc939e7/crate2nix/templates/build.nix.tera#L89 crateBin = lib.filter (bin: !(bin ? name && bin.name == ",")) (crate.crateBin or [ ]); hasCrateBin = crate ? crateBin; <ins> buildCrate = import ./build-crate.nix { inherit lib stdenv mkRustcDepArgs mkRustcFeatureArgs needUnstableCLI; rustc = rust; }; </ins> in stdenv.mkDerivation (rec {

Discussion:
I'm running an issue with overriding the rust toolchain since , I pass the following to crate2nix: to set the toolchain when building something, since I don't want to override the toolchain globally. But after this PR it doesn't work because it uses the toolchain in instead of the one I'm passing in. Now I don't really know how to override the rust toolchain to the version I want. is a nightly version I got from This problem is caused by this optimization: Another issue is that the attribute is missing in rust-overlay:
I'm having this issue as well. I've overridden my input to my flake to as a workaround for now.
Hi, sorry for the delay, I'm back home now from "holiday". Can any of you give me a minimal flake that reproduces the issue so I can experiment and find the best way to fix it?
I'm also hitting this. I don't have a minimal flake but I can at least offer the error message which seems to be missing from the OP.
Let me know if this fixes it.
unfortunately it does not, because it still defaults to for the rustc compiler. I've created a reproduction here: As you can see in I'm overriding rustc and cargo to the specific nightly version I want, but when I run I get the following output: This is the rustc version that's current in nixpkgs, not the nightly I specified. Thanks a lot for looking into this
One problem with your reproducer is that it uses the for which takes an arg called not . I think that still wouldn't have solved it. I made some changes in the PR that would allow passing a custom toolchain via the but also using . I did some refactoring to get rid of the and variables.
Change:
, symlinkJoin , writeTextDir , yt-dlp <ins> # the unwrapped mpv derivation , mpv </ins> }: <del> # the unwrapped mpv derivation - 1st argument to `wrapMpv` mpv: </del> let <del> # arguments to the function (exposed as `wrapMpv` in all-packages.nix) </del> <ins> # arguments to the function (exposed as `mpv-unwrapped.wrapper` in top-level) </ins> wrapper = { <ins> mpv, </ins> extraMakeWrapperArgs ? [], youtubeSupport ? true, <del> # a set of derivations (probably from `mpvScripts`) where each is # expected to have a `scriptName` passthru attribute that points to the # name of the script that would reside in the script's derivation's </del> <ins> # a set of derivations (probably from `mpvScripts`) where each is expected # to have a `scriptName` passthru attribute that points to the name of the # script that would reside in the script's derivation's </ins> # `$out/share/mpv/scripts/`. <del> # A script can optionally also provide an `extraWrapperArgs` passthru attribute. </del> <ins> # # A script can optionally also provide `passthru.extraWrapperArgs` # attribute. </ins> scripts ? [], extraUmpvWrapperArgs ? [] }:

Discussion:
Package name: Latest released version: <!-- Search your package here: --- Current version on the unstable channel: Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Yeeessaah!
Change:
<ins> { fetchzip, lib }: let version = "5.0"; in fetchzip { name = "khmeros-${version}"; url = "mirror://debian/pool/main/f/fonts-khmeros/fonts-khmeros_${version}.orig.tar.xz"; sha256 = "sha256-pS+7RQbGwlBxdCfSVxHmARCAkZrZttwYNlV/CrxqI+w="; postFetch = '' unpackDir="$TMPDIR/unpack" mkdir "$unpackDir" cd "$unpackDir" tar xf "$downloadedFile" --strip-components=1 mkdir -p $out/share/fonts cp *.ttf $out/share/fonts ''; meta = with lib; { description = "KhmerOS Unicode fonts for the Khmer language"; homepage = "http://www.khmeros.info/"; license = licenses.gpl2Plus; maintainers = with lib.maintainers; [ serge ]; platforms = platforms.all; }; } </ins>

Discussion:
Project description Add Khmeros TrueType font for Khmer language. Also, see All issues have attached PRs. Metadata homepage URL: source URL: mirror://debian/pool/main/f/fonts-khmeros/fonts- license: gpl2+ platforms: all
Change:
buildInputs = [ libX11 libXrandr qtbase qtwebchannel qtwebengine qtx11extras libvdpau SDL2 mpv libGL ]; <del> desktopItem = makeDesktopItem { name = "plex-media-player"; exec = "plexmediaplayer"; icon = "plex-media-player"; comment = "View your media"; desktopName = "Plex Media Player"; genericName = "Media Player"; categories = "AudioVideo;Video;Player;TV;"; }; </del> preConfigure = with depSrcs; '' mkdir -p build/dependencies ln -s ${webClient} build/dependencies/buildid-${webClientBuildId}.cmake

Discussion:
This is pretty confusing: ! Install and try to launch it from your DE. Which icon do you click on? They both do the same thing anyway. system: host os: multi-user?: sandbox: version: channels(root): channels(stanislas): nixpkgs:
I can reproduce this issue. I think it is caused by this line Would need to have more of a look but at least one of the desktop items is coming from this line and removing it would likely solve the problem
Thanks! I submitted a PR to remove the custom desktop file.
Change:
, gnused , coreutils , jq <ins> , nix-update-script , gimpPlugins </ins> }: let

Discussion:
Steps to reproduce the behavior: gmic from There are more of those function arity errors, but just a small sample since they're the same. I'm going to assume pull in today has something to do with it. no maintainer? merged and it shows failures for gmic. gmic is used for me in GIMP and darktable. Please run and paste the result.
I will revert this preventively. There are many strange bugs happening.
Change:
description = "A system and service manager for Linux"; license = licenses.lgpl21Plus; platforms = platforms.linux; <del> badPlatforms = [ (plat: plat.isStatic) ]; </del> <ins> badPlatforms = [ lib.systems.inspect.platformPatterns.isStatic ]; </ins> # https://github.com/systemd/systemd/issues/20600#issuecomment-912338965 broken = stdenv.hostPlatform.isStatic; priority = 10;

Discussion:
I am working on this bug. First reported . The root cause of the problem is that there is no "pattern" (see ) representation for . It is special, unlike all the other platform predicates. It is this way because exists, and because ... in other words, "static-ness" is not represented in the triple for a platform. Right now we try to pretend that you can reconstruct all the pattern-representable aspects of a from its . That isn't really true, because of and , and it's getting more untrue as time goes on. The long-term solution is to stop pretending. I have a possible short-term fix that I'm testing.
Change:
rustPlatform.buildRustPackage rec { pname = "broot"; <del> version = "1.6.2"; </del> <ins> version = "1.6.6"; </ins> src = fetchCrate { inherit pname version; <del> sha256 = "sha256-SjfTMBGby2jzmeNEtBVYqumLExhXW8nqxpbaeeaRM3w="; </del> <ins> sha256 = "sha256-Aezi005CKhGwCRZ2HwxFRRORBvVoZEzljTcKQZ8b8XI="; </ins> }; <del> cargoHash = "sha256-BdSqTzXu7Glhr0fQGmnkg5BXYgdQS6jgfH3A9hPpECY="; </del> <ins> cargoHash = "sha256-d06lvS5ajXPY/AwmE2rkya82mAOeEv04EtBElDvX2+I="; </ins> nativeBuildInputs = [ installShellFiles

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: broot <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.6.2 desired version: 1.6.6 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
buildPythonPackage rec { pname = "rich"; <del> version = "13.3.1"; </del> <ins> version = "13.3.5"; </ins> format = "pyproject"; disabled = pythonOlder "3.7";

Discussion:
Package name: textual Latest released version: 0.23.0 <!-- Search your package here: --- Current version on the unstable channel: 0.15.1 Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Does resolve this?
As far as I can tell: yes. Would be great to have it merged into master (so it shows up in nixpkgs-unstable at some point).
And of course there have been two new releases in the meantime....
Was fixed, closing.
Change:
<del> { lib, stdenv, fetchurl </del> <ins> { lib, stdenv, fetchFromSourcehut </ins> , meson, pkg-config, wayland, ninja , cairo, libinput, pango, wayland-protocols, libxkbcommon }:

Discussion:
Describe the bug Sources from archives from fail to download with hash mismatches. To Reproduce Expected behavior The hash should match and the source should download. Additional context It sounds like , causing changes to all generated archives (to come in-line with GNU gzip). I've determined some packages which this affects (listed in "Maintainer information") by . I'm happy to have a go making a PR for all of these packages with the following process: archive from cache (by with subsituters) archive from both and confirm tar files are identical hash according to newly retrieved archive But if there's a better process, please let me know :) Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Sounds good
I think it is preferable to switch all affected derivations to fetchzip. This should prevent this from happening again, if the actual content of the tarball is the same. Even better, you could add a fetchFromSourceHut function which uses fetchzip under the hood, like fetchFromGitHub and fetchFromGitLab. This would encourage people not to use fetchurl to fetch procedurally generated tarballs from sourcehut.
From a quick look at the ticket, this is supposed to be a one-time change to make the hash the same as in other forges though
I think getting the new hashes with e.g. should be enough (fetches securely via HTTPS and we should be able to trust that the contents remain unchanged). +1, that seems like the best (long-term) solution. Edit: And IMO we should keep using archives (e.g. because it's consistent with the GitHub and GitLab fetchers) and should indeed be fine now:
the point is: with fetchzip, we don't have to trust this pinky promise (I mean, I'm sure that they intend to keep it, but it could break unwillingly). That's exactly why fetchzip exists in the first place. So on fixes keeping fetchurl.
oh, my bad, I didn't read your comment carefully enough :o I thought you've meant vs. (which didn't make much sense) but realized now that it was vs. . :+1: for that then :)
Hah, same. too then
is merged now so you could submit a PR to switch the affected attributes/packages to the new (s. ). I can also take care of it if you want.
Change:
<del> diff --git a/src_ext/patches/mccs/build-on-darwin.patch b/src_ext/patches/mccs/build-on-darwin.patch new file mode 100644 index 00000000..157e2094 --- /dev/null +++ b/src_ext/patches/mccs/build-on-darwin.patch @@ -0,0 +1,12 @@ +diff --git a/src/context_flags.ml b/src/context_flags.ml +index 7470030..6e07370 100644 +--- a/src/context_flags.ml ++++ b/src/context_flags.ml +@@ -24,6 +24,7 @@ let ifc c x = if c then x else [] + + let cxxflags = +   let flags = ++    (ifc (Config.system = "macosx") ["-x"; "c++"]) @ +     (ifc (Sys.win32 && Config.ccomp_type = "msvc") ["/EHsc"]) @ +     (ifc useGLPK ["-DUSEGLPK"]) @ +     (ifc useCOIN ["-DUSECOIN"]) @ </del>

Discussion:
Currently nothing compiles from opam env. Need to add this patch for workaround using .
cc
Please don’t hesitate to sent a merge request.
Change:
buildPythonPackage rec { pname = "pipx"; version = "1.4.3"; <del> format = "pyproject"; </del> <ins> pyproject = true; </ins> <del> disabled = pythonOlder "3.6"; </del> <ins> disabled = pythonOlder "3.8"; </ins> src = fetchFromGitHub { <del> owner = "pipxproject"; repo = pname; </del> <ins> owner = "pypa"; repo = "pipx"; </ins> rev = "refs/tags/${version}"; hash = "sha256-NxXOeVXwBhGqi4DUABV8UV+cDER0ROBFdgiyYTzdvuo="; }; <del> nativeBuildInputs = [ </del> <ins> build-system = [ </ins> hatchling hatch-vcs ]; <del> propagatedBuildInputs = [ </del> <ins> dependencies = [ </ins> argcomplete packaging platformdirs userpath <del> ] ++ lib.optionals (pythonOlder "3.8") [ importlib-metadata </del> <ins> ] ++ lib.optionals (pythonOlder "3.11") [ tomli </ins> ]; nativeCheckInputs = [

Discussion:
Attempt to build pipx on nixos unstable Seems newer version of pipx has this new test "testskipmaintenance" that attempts to pip install a package, which fails due to the network-sandboxed build environment. This causes the build to fail altogether. Hence, "testskipmaintenance" should be to the list in Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
its only "testskipmaintenance" that is missing, the build was successful after i figured out how overridePythonAttrs worked, im new to nix.
Change:
rm -rf "$out/lib/python${majorVersion}/test" ln -s $out/lib/python${majorVersion}/pdb.py $out/bin/pdb ln -s $out/lib/python${majorVersion}/pdb.py $out/bin/pdb${majorVersion} <ins> ln -s $out/share/man/man1/{python2.7.1.gz,python.1.gz} </ins> ''; passthru = {

Discussion:
We need to propagate the pth loader so packages using us process our pth files, but it makes no sense to have the pth loader itself in a pth file.
Change:
}: mkDerivation rec { <del> version = "1.1.3"; </del> <ins> version = "1.1.20"; </ins> pname = "syncthingtray"; src = fetchFromGitHub { owner = "Martchus"; repo = "syncthingtray"; rev = "v${version}"; <del> sha256 = "sha256-ovit2XSkxSjcbpqQUv8IzMqfsfItbtXLbx0/Vy0+J0Y="; </del> <ins> sha256 = "sha256-T0ddAROwVSh+IKGZZNDMC7YB2IfQZal2pAQ5ArirtjI="; </ins> }; <del> buildInputs = [ qtbase cpp-utilities qtutilities ] </del> <ins> buildInputs = [ qtbase cpp-utilities qtutilities boost qtforkawesome ] </ins> ++ lib.optionals webviewSupport [ qtwebengine ] ++ lib.optionals jsSupport [ qtdeclarative ] ++ lib.optionals kioPluginSupport [ kio ]

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: syncthingtray <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.1.3 desired version: 1.1.20 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
There's a new dependency now needed for syncthingtray - but there's a problem in the logic upstream here: Here's my packaging attempt:
Change:
in lib.mapAttrs mk (lib.importJSON ./srcs-generated.json) // { <ins> qt3d = { inherit version; src = fetchgit { url = "https://invent.kde.org/qt/qt/qt3d.git"; rev = "c3c7e6ebc29cce466d954f72f340a257d76b5ec2"; sha256 = "sha256-KMWZ4N2OO7TBVpcgvQf/gweZRT62i9XABOnq0x94PY4="; fetchLFS = false; fetchSubmodules = true; deepClone = false; leaveDotGit = false; }; }; </ins> # qtwebkit does not have an official release tarball on the qt mirror and is # mostly maintained by the community. qtwebkit = rec {

Discussion:
First failure in Likely due to
The referenced file is indeed missing from source: Our fetcher should include submodules.
Changed in , where is converted into a submodule.
These qt modules currently include submodules:
Change:
stdenv.mkDerivation rec { pname = "fwup"; <del> version = "1.8.3"; </del> <ins> version = "1.8.4"; </ins> src = fetchFromGitHub { owner = "fhunleth"; repo = "fwup"; rev = "v${version}"; <del> sha256 = "sha256-ayfcnIZ7MuBsCy1giwmY2D2C6AukwS+fevmXqGa4c1w="; </del> <ins> sha256 = "sha256-NaSA3mFWf3C03SAGssMqLT0vr5KMfxD5y/iragGNKjw="; </ins> }; <del> patches = [ ./fix-testrunner-darwin.patch ]; </del> nativeBuildInputs = [ autoreconfHook pkg-config

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: fwup <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.8.3 desired version: 1.8.4 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
could you please give a try?
I'm new to nix but I was able to get the following to work on Ubuntu 20.04 Thanks for the quick turnaround
Change:
homepage = "https://github.com/ralphbean/ansi2html"; license = licenses.lgpl3Plus; maintainers = with maintainers; [ davidtwco ]; <del> platforms = platforms.all; </del> }; }

Discussion:
Describe the bug Installing mdcat/ansi2html fails To Reproduce Expected behavior It installs Additional context Notify maintainers (Removed actual author github handle) Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(andreas): nixpkgs:
I do not maintain this nixpkg; this is not my bug, I don't even know what Nixos is. You need to mention whoever is responsible for this packaging, but please keep me out.
I'm sorry. I was using the github owner field, but nixpkgs maintainer field refers to