jiebi/CodeConvo huggingface dataset:
Change:
<del> --- a/chrome/browser/devtools/devtools_file_system_indexer.cc +++ b/chrome/browser/devtools/devtools_file_system_indexer.cc @@ -34,7 +34,6 @@ using base::TimeDelta; using base::TimeTicks; using content::BrowserThread; using std::map; -using std::set; using std::string; using std::vector; @@ -191,7 +190,7 @@ vector<FilePath> Index::Search(const string& query) { if (trigram != kUndefinedTrigram) trigrams.push_back(trigram); } -  set<FileId> file_ids; +  std::set<FileId> file_ids; bool first = true; vector<Trigram>::const_iterator it = trigrams.begin(); for (; it != trigrams.end(); ++it) { @@ -203,7 +202,7 @@ vector<FilePath> Index::Search(const string& query) { first = false; continue; } -    set<FileId> intersection = base::STLSetIntersection<set<FileId> >( +    std::set<FileId> intersection = base::STLSetIntersection<std::set<FileId> >( file_ids, index_[trigram]); file_ids.swap(intersection); } diff --git a/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.h b/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.h index 94bb9161ec85..e40c6387f72e 100644 --- a/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.h +++ b/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.h @@ -63,7 +63,7 @@ class WTF_EXPORT ArrayBufferContents { allocation_length_(0), data_(data), data_length_(0), -          kind_(AllocationKind::kNormal), +          kind_(WTF::ArrayBufferContents::AllocationKind::kNormal), deleter_(deleter) {} DataHandle(void* allocation_base, size_t allocation_length, @@ -94,11 +94,11 @@ class WTF_EXPORT ArrayBufferContents { reinterpret_cast<uintptr_t>(allocation_base_) + allocation_length_); switch (kind_) { -        case AllocationKind::kNormal: +        case WTF::ArrayBufferContents::AllocationKind::kNormal: DCHECK(deleter_); deleter_(data_); return; -        case AllocationKind::kReservation: +        case WTF::ArrayBufferContents::AllocationKind::kReservation: ReleaseReservedMemory(allocation_base_, allocation_length_); return; } --- a/third_party/webrtc/modules/audio_processing/aec3/aec_state.cc.orig	2017-08-15 12:45:59.433532111 +0000 +++ b/third_party/webrtc/modules/audio_processing/aec3/aec_state.cc	2017-08-15 17:52:59.691328825 +0000 @@ -10,7 +10,7 @@ #include "webrtc/modules/audio_processing/aec3/aec_state.h" -#include <math.h> +#include <cmath> #include <numeric> #include <vector> </del>  No newline at end of file

Discussion:
This probably isn't a strictly NixOS issue, but nevertheless should be mentioned. The hash for vivaldi-stable2.1.1337.51-1 has changed. The old one in nixpkgs is 08x6abyz65vx4ycj8ys8sib9z1adb8ybmnrqjck69b30kbz78rj2, while nix-env reports 00rxp6rardxjg17g2b28y2rj8szqlainp4ga6c58z981zkxvdlls. to unstable channels. -env -i vivaldi system: host os: multi-user?: sandbox: version: channels(void): channels(root): nixpkgs:
unfortunately, sometimes software projects update different package sources with different sha256sums on their website, which will then error during build, until it gets fixed again Can you add a Pull Request, updating the hash in
Change:
fldigi = callPackage ../applications/radio/fldigi { }; flink = callPackage ../applications/networking/cluster/flink { }; <del> flink_1_5 = flink.override { version = "1.5"; }; </del> fllog = callPackage ../applications/radio/fllog { };

Discussion:
, CVSSv3=7.5 (nixos-20.09, nixos-unstable) Scanned versions: nixos-20.09: ; nixos-unstable: . Cc

, CVSSv3=7.5 (nixos-20.09, nixos-unstable) CVSSv3=7.5 (nixos-20.09, nixos-unstable) Scanned versions: nixos-20.09: ; nixos-unstable: . Cc
Change:
cp -r "$$HIGHLIGHTJS/loader.js" highlightjs/ <del> manual-full.xml: ${MD_TARGETS} .version functions/library/locations.xml *.xml **/*.xml **/**/*.xml </del> <ins> manual-full.xml: ${MD_TARGETS} .version functions/library/locations.xml functions/library/generated *.xml **/*.xml **/**/*.xml </ins> xmllint --nonet --xinclude --noxincludenode manual.xml --output manual-full.xml .version: nix-instantiate --eval  -E '(import ../lib).version' > .version <ins> function_locations := $(shell nix-build --no-out-link ./lib-function-locations.nix) </ins> functions/library/locations.xml: <del> nix-build ./lib-function-locations.nix  --out-link ./functions/library/locations.xml </del> <ins> ln -s $(function_locations) ./functions/library/locations.xml functions/library/generated: nix-build ./lib-function-docs.nix  --arg locationsXml $(function_locations) --out-link ./functions/library/generated </ins> %.section.xml: %.section.md pandoc $^ -w docbook+smart 

Discussion:
with new versions of deps - build is broken. Example of error instance: Full log: This creates a blocker for contributors to the manual. To contribute to NixPkgs manual, it is required to build the manual () before creating a pull request. I want to contribute some section. By the process - I need to pass a successful build. The manual on the master branch is currently broken, building it on my setup. Errors ask me to make changes, which doc maintainers probably know what to do about. system: host os: multi-user?: sandbox: version: channels(root): channels(pyro): nixpkgs:
Maybe this is due to manual being built on the current stable branch?
Even on the job builds and most likely will build for you as well but I confirm that in indeed is broken.
BTW, I believe this earlier message is closer to the root of the problem:
Yes, this was to in but the was forgotten. cc
Gonna take a look at this. Edit: PR to fix it is up at
if you are still having issues on master (or a revision where is merged) make sure you before using , and otherwise, re-open with more details.
Change:
<del> { stdenv, makeQtWrapper, fetchFromGitHub, fetchpatch </del> <ins> { stdenv, lib, makeQtWrapper, fetchFromGitHub, fetchpatch </ins> , cmake, extra-cmake-modules, pkgconfig, libxcb, libpthreadstubs, lndir , libXdmcp, libXau, qtbase, qtdeclarative, qttools, pam, systemd , themes

Discussion:
On NixOS 17.03, the in the system configuration with Plasma 5 enabled, has and in its runtime closure, which causes unnecessary bloat. This is because has: then causes the directories of and to be to the wrapper script. (Automatically adding everything with a directory to the wrapper seems pretty drastic BTW.) System: NixOS Nix version: 1.12pre5073_1cf4801
KDE upstream is slightly careless about implicit runtime dependencies. I spent hours trying to figure out which runtime dependencies needed to be in . By the way, you have to guess at this because SDDM doesn't log error messages. Could we drop ? Probably. Can I answer that question for any of the other dependencies? Not a chance. So I nuked it from orbit. Guessing the correct setting would be a good project for a first-time contributor with a lot of free time. At the moment, I'm trying to get rid of entirely. This problem may go away as a happy accident, but that won't help this release. I'm open to other suggestions.
Change:
, fltk13 , gtk2 , gtk3 <ins> , makeWrapper </ins> , pkg-config <ins> , psmisc </ins> }: stdenv.mkDerivation (finalAttrs: {

Discussion:
I use hdajackretask from alsa-tools to reasign my laptop speakers to a certain pin layout. (I need to do this, because those speakers are not used at all by default, in this 4 speaker layout) In order to do this, hdajackretask needs fuser to perform this task. It seems not to be a dependency. Steps to reproduce the behavior: alsa-tools hdajackretask as root this setup, see the tick in the box on the top, then click on apply ! fuser is installed Please run and paste the result.
Note: fuser is part of psmisc and installing it solved this issue. Please add psmisc to alsa-tools as dependency.
Change:
# NOTE: 2018-12-27: Check NixOS HandBrake test if changing NIX_LDFLAGS = [ "-lx265" ]; <ins> # meson/ninja are used only for the subprojects, not the toplevel dontUseMesonConfigure = true; dontUseMesonInstall = true; dontUseNinjaBuild = true; dontUseNinjaInstall = true; </ins> makeFlags = [ "--directory=build" ]; <del> passthru.tests = { basic-conversion = </del> <ins> passthru = { # for convenience inherit ffmpeg-hb x265-hb; tests.basic-conversion = </ins> let # Big Buck Bunny example, licensed under CC Attribution 3.0. testMkv = fetchurl {

Discussion:
Package name: handbrake Latest released version: 1.7.3 Current version on the unstable channel: 1.6.1 Current version on the stable/release channel: 1.6.1 Notify maintainers Note for maintainers: Please tag this issue in your PR.
Revised to 1.7.2 release
Revised to 1.7.3
Change:
- [PeerTube](https://joinpeertube.org/), developed by Framasoft, is the free and decentralized alternative to video platforms. Available at [services.peertube](options.html#opt-services.peertube.enable). <ins> - [maddy](https://maddy.email), a composable all-in-one mail server. Available as [services.maddy](options.html#opt-services.maddy.enable). </ins> - [sourcehut](https://sr.ht), a collection of tools useful for software development. Available as [services.sourcehut](options.html#opt-services.sourcehut.enable). - [ucarp](https://download.pureftpd.org/pub/ucarp/README), an userspace implementation of the Common Address Redundancy Protocol (CARP). Available as [networking.ucarp](options.html#opt-networking.ucarp.enable).

Discussion:
Maddy, a small and compact mail server written in Go, was merged as a package with by . Having a NixOS module to enable and configure it would be really great! If someone is interested in creating a PR, I will be happy to help and test it :+1: Best regards Jonas
Hi, I dont have any sort of way to properly test this within the actual nixos repo but I've got a personal working module/service you can try
I did something very similar to the above, but based my serviceConfig on the example . It contains quite a bit more of the systemd security features, so if you want to make something to include in nixpkgs I think all these things should be on! I also hooked it up to Dovecot, hence the waiting script, not sure if that's the best way of doing it.
How about this: Nice and simple.
Have you tried this? Somehow it doesn't work for me:
- it looks like the units aren't included in the nixpkgs package :man_shrugging:, but I created a PR to fix this in Please review, test, and approve PR. I have never used so I wouldn't want to merge that PR without you (or someone else) testing. Thanks!
Change:
argcomplete, buildPythonPackage, fetchFromGitHub, <ins> fetchpatch2, </ins> httpx, mock, pytestCheckHook, <del> pythonAtLeast, pythonOlder, </del> requests, responses, setuptools,

Discussion:
Steps to reproduce the behavior: -rebuild switch Here is my config for home-assistant: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
rustPlatform.buildRustPackage rec { pname = "starship"; <del> version = "1.11.0"; </del> <ins> version = "1.12.0"; </ins> src = fetchFromGitHub { owner = "starship"; repo = pname; rev = "v${version}"; <del> hash = "sha256-90mh8C52uD68K5o1LE22gkbL1gy6FyMJTiiN9oV/3DE="; </del> <ins> hash = "sha256-HS+vtF+h5M6lbk7TROAXwrHpj92SeC+j0TjmP6ycH2Q="; </ins> }; nativeBuildInputs = [ installShellFiles cmake ];

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: starship <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.11.0 desired version: 1.12.0 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
HOME=$(mktemp -d) py.test --pyargs borg.testsuite ''; <del> # 63 failures, needs pytest-benchmark </del> <ins> # 64 failures, needs pytest-benchmark </ins> doCheck = false; meta = with stdenv.lib; {

Discussion:
Invoking is producing the following error message: is part of the package so it's just failing to locate it. I'm running on NixOS Unstable.
I believe this issue has been fixed and can be closed:

Travis has been giving build failures because of this: commit seems to be at fault here.. The reason I didn't just fix this this bug and push upstream is because there are two different ways to approach this and I'm not sure which the best course of action is. a) jfsrec removal was intentional, remove all references to jfsrec b) restore jfsrec Here is a listing of all current things pointing to jfsrec:
The jfsrec commit has already been reverted.
thanks for the info

nixos/modules/services/x11/display- has code to load ~/.Xdefaults, but not ~/.Xresources, even though ~/.Xdefaults is the deprecated version of ~/.Xresources

In its builder, there's a command saying "Need libgcc until the llvm compiler-rt library is complete". It's from in 2011, so I'm inclined to think it's out of date and that the dependency on gcc is spurious. Is that true?
For context from #llvm on oftc:
covers , covers , the only thing I'm not sure about is the C runtime files (e.g. ), none of those packages seem to come with them (but maybe clang does it another way)
Actually some of the files come from glibc, but these ones come with gcc: crtprec32.o crtendS.o crtbeginS.o crtfastmath.o crtprec64.o crtbeginT.o crtprec80.o crtbegin.o crtend.o
This story is quite old, is this still true?
Closing because no reaction.
Change:
HOME=$(mktemp -d) py.test --pyargs borg.testsuite ''; <del> # 63 failures, needs pytest-benchmark </del> <ins> # 64 failures, needs pytest-benchmark </ins> doCheck = false; meta = with stdenv.lib; {

Discussion:
Invoking is producing the following error message: is part of the package so it's just failing to locate it. I'm running on NixOS Unstable.
I believe this issue has been fixed and can be closed:

Travis has been giving build failures because of this: commit seems to be at fault here.. The reason I didn't just fix this this bug and push upstream is because there are two different ways to approach this and I'm not sure which the best course of action is. a) jfsrec removal was intentional, remove all references to jfsrec b) restore jfsrec Here is a listing of all current things pointing to jfsrec:
The jfsrec commit has already been reverted.
thanks for the info

nixos/modules/services/x11/display- has code to load ~/.Xdefaults, but not ~/.Xresources, even though ~/.Xdefaults is the deprecated version of ~/.Xresources
Change:
, shaderc , lcms2 , libGL <del> , xorg </del> <ins> , libX11 </ins> , libunwind , libdovi <ins> , xxHash </ins> }: stdenv.mkDerivation rec { pname = "libplacebo"; <del> version = "5.264.1"; </del> <ins> version = "6.338.1"; </ins> src = fetchFromGitLab { domain = "code.videolan.org"; owner = "videolan"; repo = pname; rev = "v${version}"; <del> hash = "sha256-YEefuEfJURi5/wswQKskA/J1UGzessQQkBpltJ0Spq8="; </del> <ins> hash = "sha256-NZmwR3+lIC2PF+k+kqCjoMYkMM/PKOJmDwAq7t6YONY="; </ins> }; nativeBuildInputs = [

Discussion:
Package name: Latest released version: <!-- Search your package here: --- Current version on the unstable channel: Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Done here:
Change:
githubId = 3789764; name = "skykanin"; }; <ins> slbtty = { email = "shenlebantongying@gmail.com"; github = "shenlebantongying"; githubId = 20123683; name = "Shenleban Tongying"; }; </ins> sleexyz = { email = "freshdried@gmail.com"; github = "sleexyz";

Discussion:
Project description A fork of Golden Dictionary which fixes many old bugs, provides improvement, and is being actively developed. It might be better to switch to altogether instead of continuing to maintain . Metadata homepage URL: source URL: license: gplv3 platforms: linux
doesn't seem too inactive now: they even had a new release last month (based on Qt WebKit, though).
I think it might be a good idea to have both versions as provides extra features and bug fixes if that's possible.
Change:
<ins> { lib , stdenv , boost , fetchFromGitHub , git , makeWrapper , meson , ninja , pkg-config , python3 , qtbase , qtcharts , tuxclocker-plugins , wrapQtAppsHook }: stdenv.mkDerivation (finalAttrs: { pname = "tuxclocker"; version = "1.4.0"; src = fetchFromGitHub { owner = "Lurkki14"; repo = "tuxclocker"; fetchSubmodules = true; rev = "${finalAttrs.version}"; hash = "sha256-8dtuZXBWftXNQpqYgNQOayPGfvEIu9QfbqDShfkt1qA="; }; # Meson doesn't find boost without these BOOST_INCLUDEDIR = "${lib.getDev boost}/include"; BOOST_LIBRARYDIR = "${lib.getLib boost}/lib"; nativeBuildInputs = [ git makeWrapper meson ninja pkg-config wrapQtAppsHook ]; buildInputs = [ boost qtbase qtcharts ]; postInstall = '' wrapProgram "$out/bin/tuxclockerd"  --prefix "TEXTDOMAINDIR" : "${tuxclocker-plugins}/share/locale"  --prefix "TUXCLOCKER_PLUGIN_PATH" : "${tuxclocker-plugins}/lib/tuxclocker/plugins"  --prefix "PYTHONPATH" : "${python3.pkgs.hwdata}/${python3.sitePackages}" ''; mesonFlags = [ "-Dplugins=false" ]; meta = with lib; { description = "Qt overclocking tool for GNU/Linux"; homepage = "https://github.com/Lurkki14/tuxclocker"; license = licenses.gpl3Only; maintainers = with maintainers; [ lurkki ]; platforms = platforms.linux; }; }) </ins>

Discussion:
Project description TuxClocker is a hardware controlling and monitoring program. TuxClocker consists of a DBus daemon and a Qt GUI that uses the daemon. It allows you to e.g. set a custom fan curve and overclock your CPU and GPU. Metadata homepage URL: source URL: license: gpl3 platforms: linux
Change:
rm -r "$sourceRoot/debug" "$sourceRoot/release" ''; <ins> postPatch = '' substituteInPlace Makefile.am --replace '-Werror' '' ''; </ins> nativeBuildInputs = [ autoreconfHook ];

Discussion:
Describe the bug Trying to build a Windows cross-compiler on Darwin fails at the build of mcfgthreads. To Reproduce On a Darwin host, macOS 10.15.6 (19G2021) in my case: Expected behavior The package should be built using a Windows cross-compiler. Additional context Compiling fails at the package. The phase runs through, but fails: This overlay fixes the problem for me: You can reproduce a successful build like this: However, I am uncertain, whether this is the proper fix or whether I should dig deeper to diagnose the root cause of this diagnostic. Notify maintainers (not listed as maintainer, but introduced and might know how to fix) Metadata system: host os: multi-user?: sandbox: version: channels(Michael): nixpkgs:
I also get this exact same bug. Any ideas on where to start looking?
I just opened pull request to suggest my fix. With this, I can build a Windows cross-compiler on Darwin.
But why does it happen on macos and not Linux? That would still be interesting to know. Someone suggested ASLR might have something to do with it?
It is a warning that happens with precompiled headers on macOS. I deduce from that expects its own text segment to be in the same location when it creates the precompiled header and when it uses it. This is not the case on macOS, due to aggressive ASLR. I think this leads to simply ignoring the precompiled header, which is not a problem. The problem only happens here, because the build system treats all warnings as hard errors. This is what my patch changes.
True, since it just skips using the pch it is not that bad :)
Change:
<ins> { lib , stdenv , fetchFromGitHub , substituteAll , buildGoModule , go , glib , pkg-config , cairo , gtk3 , xcur2png , libX11 , zlib }: buildGoModule rec { pname = "nwg-look"; version = "0.2.4"; src = fetchFromGitHub { owner = "nwg-piotr"; repo = pname; rev = "v${version}"; hash = "sha256-wUI58qYkVYgES87HQ4octciDlOJ10oJldbUkFgxRUd4="; }; vendorHash = "sha256-dev+TV6FITd29EfknwHDNI0gLao7gsC95Mg+3qQs93E="; # Replace /usr/ directories with the packages output location # This means it references the correct path patches = [ ./fix-paths.patch ]; postPatch = '' substituteInPlace main.go tools.go --replace '@out@' $out ''; ldflags = [ "-s" "-w" ]; nativeBuildInputs = [ pkg-config ]; buildInputs = [ cairo xcur2png libX11.dev zlib gtk3 ]; CGO_ENABLED = 1; postInstall = '' mkdir -p $out/share mkdir -p $out/share/nwg-look/langs mkdir -p $out/share/applications mkdir -p $out/share/pixmaps cp stuff/main.glade $out/share/nwg-look/ cp langs/* $out/share/nwg-look/langs cp stuff/nwg-look.desktop $out/share/applications cp stuff/nwg-look.svg $out/share/pixmaps ''; meta = with lib; { homepage = "https://github.com/nwg-piotr/nwg-look"; description = "Nwg-look is a GTK3 settings editor, designed to work properly in wlroots-based Wayland environment."; license = licenses.mit; platforms = platforms.linux; maintainers = with maintainers; [ max-amb ]; mainProgram = "nwg-look"; }; } </ins>

Discussion:
Project description A GTK3 settings editor adapted to work in the wlroots environment, a part of the nwg-shell project. <!-- Describe the project a little: --Metadata homepage URL: https://nwg- source URL: license: MIT platforms: Linux
I am happy to work on this and I am currently working a pr to implement it!
Change:
buildPythonPackage rec { pname = "sphinxcontrib-openapi"; <del> version = "0.3.0"; </del> <ins> version = "0.3.2"; </ins> src = fetchPypi { inherit pname version; <del> sha256 = "0fyniq37nnmhrk4j7mzvg6vfcpb624hb9x70g6mccyw4xrnhadv6"; </del> <ins> sha256 = "411da1819fda0593976a157f1a14ec1cfaef9ee1b4b708e795d0bf3953f0142b"; </ins> }; propagatedBuildInputs = [setuptools_scm pyyaml jsonschema sphinxcontrib_httpdomain];

Discussion:
Ran . For some reason there are pylint tests running for ~8 minutes that eventually end up in a failure. <details<summaryPyLint test failures</summary</detailson pylint (indirectly?); running for ~10 minutes as part of package installation process.
This will need to be backported to 18.09 as the latest version released by Hydra is broken too
The tests still fails even after the above patch applied. <details<summaryHere is the log</summary</detailsHere is the patch I used: Edit: the original patch is working on the python-unstable branch so I guess it's OK
I pushed a fix to the branch: . The fix for is currently in the branch: .
Change:
{ QEMU_OPTS = "-drive file=$bootDiskImage,if=virtio,cache=unsafe,werror=report" + " -drive file=$rootDiskImage,if=virtio,cache=unsafe,werror=report"; <ins> inherit memSize; </ins> preVM = '' PATH=$PATH:${pkgs.qemu_kvm}/bin mkdir $out

Discussion:
Building an Amazon AMI with zfs root fails with inside the vm getting an error trying to allocate memory partway through building the new store. It isn’t surprising that a zfs-using system needs more memory when doing intensive filesystem writes. Unfortunately I don't know how to adjust the config (other than globally in a nixpkgs fork) for how much memory to give the vm. $ nix-build -A amazonImageZfs.x8664-linux … error: reading directory '/nix/store/4l99mg8j2c3bqjlc10ncdfcq5vaazxb9-nixos-22.11pre130979.gfedcba/nixos/pkgs/tools/misc/tagref': Cannot allocate memory (the specific package or failure point varies a little on each run based on random timings and resource usage) system: host os: multi-user?: sandbox: version: channels(root): channels(dan): nixpkgs:
This issue has been mentioned on NixOS Discourse. There might be relevant details there: