jiebi/CodeConvo huggingface dataset:
Change:
<del> { lib, buildGoModule, fetchFromGitHub, testers, kubeswitch }: </del> <ins> { lib, buildGoModule, fetchFromGitHub, testers, kubeswitch, installShellFiles, }: </ins> buildGoModule rec { pname = "kubeswitch";

Discussion:
Kubeswitch requires both the binary and a script Steps to reproduce the behavior: kubeswitch to use Kubeconfig is set as intended only adds the binary, not the script itself. On the other hand, I'm not using nix directly but via fleek.
Hey happy first issue! About the kubeswitch, indeed, I did make this mistake as I am using it on my work machine which is not NixOS and I had done the standard installation in the past, so I got the binary from Nix, but not the script. Honestly, I need time and a little bit of searching on how to handle scripts, as I have only messed with Go or Python packages (which have a nice interface, BTW).
This will help fix it.
I did not test, but thanks. are you willing to do fix it?
Hi, sorry I want to but do not have much time recently.
Change:
sha256 = "sha256-wqdZ/kCjwhoWtaiNAM1m869vByHk6mG2OULfuDotVP0="; }; <del> patchPhase = '' </del> <ins> postPatch = '' </ins> echo -java-home ${jre.home} >>conf/sbtopts '';

Discussion:
Describe the bug As of this commit the package no longer allows overriding the JRE without failing to build. It still worked as of this commit To Reproduce Note that is the content of the in the above commit. note it also fails when overriding with however which is the current java15 version works. Expected behavior Successful build of SBT Additional context Non Debug output Notify maintainers Metadata Maintainer information:
Change:
inherit ruby; name = "${gemName}-${version}"; gemName = "bundler"; <del> version = "2.2.24"; source.sha256 = "1x3czmqhlyb593ap7mxkk47idi2jnbnrpwj8xlsjdpi7iair9y62"; </del> <ins> version = "2.3.6"; source.sha256 = "1531z805j3gls2x0pqp2bp1vv1rf5k7ynjl4qk72h8lpm1skqk9r"; </ins> dontPatchShebangs = true; postFixup = ''

Discussion:
, CVSSv3=7.3 (nixos-21.11, nixos-unstable) is a package for managing application dependencies in Ruby. In versions before 2.2.33, when working with untrusted and apparently harmless 's, it is not expected that they lead to execution of external code, unless that's explicit in the ruby code inside the itself. However, if the includes entries that use the option with invalid, but seemingly harmless, values with a leading dash, this can be false. To handle dependencies that come from a Git repository instead of a registry, Bundler uses various commands, such as . These commands are being constructed using user input (e.g. the repository URL). When building the commands, Bundler versions before 2.2.33 correctly avoid Command Injection vulnerabilities by passing an array of arguments instead of a command string. However, there is the possibility that a user input starts with a dash () and is therefore treated as an optional argument instead of a positional one. This can lead to Code Execution because some of the commands have options that can be leveraged to run arbitrary executables. Since this value comes from the file, it can contain any character, including a leading dash. To exploit this vulnerability, an attacker has to craft a directory containing a file that declares a dependency that is located in a Git repository. This dependency has to have a Git URL in the form of . This URL will be used to construct a Git clone command but will be interpreted as the upload-pack argument. Then this directory needs to be shared with the victim, who then needs to run a command that evaluates the Gemfile, such as , inside. This vulnerability can lead to Arbitrary Code Execution, which could potentially lead to the takeover of the system. However, the exploitability is very low, because it requires a lot of user interaction. Bundler 2.2.33 has patched this problem by inserting as an argument before any positional arguments to those Git commands that were affected by this issue. Regardless of whether users can upgrade or not, they should review any untrustred 's before running any commands that may read them, since they can contain arbitrary ruby code. Scanned versions: nixos-21.11: ; nixos-unstable: .
Actually this still needs a fix for 21.11.
Change:
githubId = 12958979; name = "Mika Naylor"; }; <ins> autrimpo = { email = "michal@koutensky.net"; github = "autrimpo"; githubId = 5968483; name = "Michal Koutenský"; }; </ins> autumnal = { name = "Sven Friedrich"; email = "sven@autumnal.de";

Discussion:
Project description music streaming server / subsonic server API implementation Metadata homepage URL: source URL: license: gpl3 platforms: linux package: The package is already there, maintained by It'd be nice to have a module too!
I can submit a module PR once is merged, as it adds some new options (filesystem watcher).
Change:
sha256 = "0a9bsl2nbnb138lq0h14jfc5xvz7hpb2bcsj4mjn6g1hcsl4ik0y"; }; <ins> env.LDFLAGS = lib.optionalString (!stdenv.isDarwin) "-Wl,-z,muldefs"; # Makefile ignores errors, so the build may silently succeed erroneously postBuild = '' test -e gnushogi/gnushogi || { echo "ERROR: no binary produced"; exit 1; } ''; </ins> meta = with lib; { description = "GNU implementation of Shogi, also known as Japanese Chess"; homepage = "https://www.gnu.org/software/gnushogi/"; license = licenses.gpl3; maintainers = [ maintainers.ciil ]; platforms = platforms.unix; <ins> broken = stdenv.isDarwin; # darwin does not support -z muldefs </ins> }; }

Discussion:
Position: Reproducible on the master branch as well as on nixos-22.11. Steps to reproduce the behavior: build Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Change:
settings_path = Path(f"{XDG_CONFIG_HOME}/@configDirName@/settings.json") settings_path_temp = Path(f"{XDG_CONFIG_HOME}/@configDirName@/settings.json.tmp") <del> try: </del> <ins> if os.path.exists(settings_path): </ins> with settings_path.open(encoding="utf-8") as settings_file: settings = json.load(settings_file) <ins> else: settings = {} </ins> <del> if settings.get("SKIP_HOST_UPDATE"): print("[Nix] Disabling updates already done") else: skip_host_update = {"SKIP_HOST_UPDATE": True} settings.update(skip_host_update) </del> <ins> if settings.get("SKIP_HOST_UPDATE"): print("[Nix] Disabling updates already done") else: skip_host_update = {"SKIP_HOST_UPDATE": True} settings.update(skip_host_update) </ins> <del> with settings_path_temp.open("w", encoding="utf-8") as settings_file_temp: json.dump(settings, settings_file_temp, indent=2) </del> <ins> os.makedirs(os.path.dirname(settings_path), exist_ok=True) </ins> <del> settings_path_temp.rename(settings_path) print("[Nix] Disabled updates") </del> <ins> with settings_path_temp.open("w", encoding="utf-8") as settings_file_temp: json.dump(settings, settings_file_temp, indent=2) </ins> <del> except IOError: print("[Nix] settings.json doesn't yet exist, can't disable it yet") </del> <ins> settings_path_temp.rename(settings_path) print("[Nix] Disabled updates") </ins>

Discussion:
The update-check disabler is not able to work if there is no pre-existing config, making it break when someone installs an "old" version. This can happen when discord updates their version, but the update has not yet been merged or fully propagated through the channels. Steps to reproduce the behavior: the (This will always use a version that is outdated by the time of writing steps) the update dialog A config should be created that is empty besides OR a stronger error/warning should be printed that explains how to mitigate. The current oneliner gets lost in the discord "boot" message noise. It seems as if a preceeding is a sufficient workaround after having identified the problem in the first place (which was the quite longer part) Please run and paste the result.
Discussion on discord revealed that when the user has a read-only (such as when it's installed through home-manager), the wrapper prints some spurious errors. This should probably be fixed at the same time.
I think you misunderstood the discussion there. The wrapper has a simple catch all with a generic oneline error. Discord though likes to fail when it can't write the config. Or in case of a symlink, likes to simply replace the link with a regular file.
Thanks for the workaround, I tried to open discord today for the first time on a new install and it was just telling me I need to upgrade to discord-0.0.25 (0.0.24 is what is packaged) and would offer to let me download a deb or a tarball and then just close. Doing the echo to make an empty config allowed discord to start and for me to get logged in. Hopefully this gets addressed so folks don't have to find this issue in order to get going with a fresh install.
Heads up that this should actually go to on MacOS - happy to make a PR if someone points me in the right direction
Change:
<del> { lib, fetchurl, buildPythonApplication, libjack2, pyqt5, qttools, which }: </del> <ins> { lib, fetchurl, buildPythonApplication, libjack2, pyqt5, qt5, which, bash }: </ins> buildPythonApplication rec { pname = "patchance"; <del> version = "1.0.0"; </del> <ins> version = "1.1.0"; </ins> src = fetchurl { url = "https://github.com/Houston4444/Patchance/releases/download/v${version}/Patchance-${version}-source.tar.gz"; <del> sha256 = "sha256-8Zn6xcDv4hBFXnaXK9xslYEB8uHEfIP+1NKvcPAyHj0="; </del> <ins> sha256 = "sha256-wlkEKkPH2C/y7TQicIVycWbtLUdX2hICcUWi7nFN51w="; </ins> }; format = "other"; nativeBuildInputs = [ pyqt5   # pyuic5 and pyrcc5 to build resources. <del> qttools # lrelease to build translations. </del> <ins> qt5.qttools # lrelease to build translations. </ins> which   # which to find lrelease. <ins> qt5.wrapQtAppsHook </ins> ]; <del> buildInputs = [ libjack2 ]; </del> <ins> buildInputs = [ libjack2 bash ]; </ins> propagatedBuildInputs = [ pyqt5 ]; dontWrapQtApps = true; # The program is a python script.

Discussion:
The new package for fails to start due to an error involving Qt. I have reproduced this behavior on two different computers. Steps to reproduce the behavior: raysession to system configuration raysession Raysession does not open, and produces an error in the terminal. Add any other context about the problem here. Output of .
I'm also experiencing this problem with the package.
Looks like it needs `. You might also have to add that and maybe other qt stuff to the wrapper.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
I made a PR here, you might want to try it a bit more extensively than I did, and also submit a similar fix for the second package mentioned in
Change:
, prefetch-yarn-deps , yarn }: <del> stdenv.mkDerivation rec { </del> <ins> stdenv.mkDerivation (finalAttrs: { </ins> pname = "aws-azure-login"; version = "3.6.1"; src = fetchFromGitHub { owner = "aws-azure-login"; repo = "aws-azure-login"; <del> rev = "v${version}"; </del> <ins> rev = "v${finalAttrs.version}"; </ins> hash = "sha256-PvPnqaKD98h3dCjEOwF+Uc86xCJzn2b9XNHHn13h/2Y="; }; offlineCache = fetchYarnDeps { <del> yarnLock = "${src}/yarn.lock"; </del> <ins> yarnLock = "${finalAttrs.src}/yarn.lock"; </ins> hash = "sha256-SXQPRzF6b1FJl5HkyXNm3kGoNSDXux+0RYXBX93mOts="; }; <del> nativeBuildInputs  = [ </del> <ins> nativeBuildInputs = [ </ins> makeWrapper nodejs prefetch-yarn-deps

Discussion:
consistently fails on 23.11. Steps to reproduce the behavior: to NixOS 23.11 This should work like . Debug output: Installing via or via does not fix this. , but no mention of Chromium itself. It looks like the error message is from . . system: host os: multi-user?: sandbox: version: channels(root): channels(username): nixpkgs: (I'll be tweaking this in case I come up with a working solution.) to a new directory, for example a containing the following: the built package like this: Unfortunately, the override doesn't work as expected: ERROR: Failed to set up Chromium r982053! Set "PUPPETEERSKIP_DOWNLOAD" env variable to skip download. I'm not sure how to proceed. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Unfortunately I'm not using this anymore and should remove myself as maintainer. Any volunteers? Looks like we have a fix now too. Can anyone verify?
I'm still using it for the foreseeable, so I've .
Change:
homepage = "https://gitlab.gnome.org/GNOME/fractal"; license = licenses.gpl3Plus; maintainers = teams.gnome.members ++ (with maintainers; [ anselmschueler dtzWill ]); <ins> platforms = platforms.linux; </ins> mainProgram = "fractal"; }; }

Discussion:
In this commit: Fractal was updated to 5, and the dependency to pipewire was introduced. Pipewire doesn't support macOS. As discussed by upstream, seems that new version of fractal is dropping support for macOS Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Looks like the fractal-next never supports darwin...
Change:
inherit (darwin.apple_sdk.frameworks) Security; }; <del> tig = callPackage ../applications/version-management/git-and-tools/tig { }; </del> <ins> tig = callPackage ../applications/version-management/git-and-tools/tig { readline = readline81; }; </ins> tilemaker = callPackage ../applications/misc/tilemaker { };

Discussion:
tig crash on macOS (m1) Steps to reproduce the behavior: -shell -p tig ANYGITREPO type "/" to enter search mode Don't crash ! Exception Type: EXCBADACCESS (SIGSEGV) Exception Codes: KERNINVALIDADDRESS at 0x082a0d5c00ab0a2b -0x00000d5c00ab0a2b (possible pointer authentication failure) Exception Codes: 0x0000000000000001, 0x082a0d5c00ab0a2b Exception Note: EXCCORPSENOTIFY Termination Reason: Namespace SIGNAL, Code 11 Segmentation fault: 11 Terminating Process: exc handler [] VM Region Info: 0xd5c00ab0a2b is not in any region. Bytes after previous region: Bytes before following region: REGION TYPE START - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL commpage (reserved) - [384.0G] ---/--- SM=NUL ...(unallocated) ---GAP OF 0x5f9000000000 BYTES MALLOCNANO - [128.0M] rw-/rwx SM=PRV Thread 0 Crashed:: Dispatch queue: 0 ??? 0x100b84c6c rlinitterminalio + 272 1 ??? 0x100b84c60 rlinitterminalio + 260 2 ??? 0x100b6fc2c readlineinitializeeverything + 164 3 ??? 0x100b6edd0 rlinitialize + 44 4 ??? 0x100b6ed48 readline + 36 5 ??? 0x100981ce4 readprompt + 80 6 ??? 0x10098aaa0 searchview + 56 7 ??? 0x100971680 main + 2608 8 dyld 0x100d61088 start + 516 <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Change:
# (this should be possible by also taking PREFIX into account). ./patches/git-annex-no-usr-prefix.patch ]; <ins> postPatch = '' substituteInPlace Makefile  --replace-fail 'InstallDesktopFile $(PREFIX)/bin/git-annex'  'InstallDesktopFile git-annex' ''; </ins> }) super.git-annex; # Too strict bounds on servant

Discussion:
& contain a wrong path to the git-annex binary. Steps to reproduce the behavior: the 1st file path mentioned above can see: The desktop files should contain the real path to the git-annex binary. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
''; preFixup = '' <del> gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "${runtimeLibs}" ) </del> <ins> gappsWrapperArgs+=( --prefix LD_LIBRARY_PATH : "${runtimeLibs}"  --set QT_XKB_CONFIG_ROOT "${xkeyboard_config}/share/X11/xkb"  --set QTCOMPOSE "${xorg.libX11.out}/share/X11/locale"  --set QT_QPA_PLATFORM "xcb" # the bundled version of qt does not support wayland ) </ins> ''; passthru.updateScript = ./update.sh;

Discussion:
Describe the bug Trying to launch fails with the message: To Reproduce Steps to reproduce the behavior: : : Expected behavior Onlyoffice should be able to run on Wayland Notify maintainers Metadata Maintainer information:
Could you try with and: Onlyoffice does not start. : Onlyoffice starts and is working fine but :(
Found the upstream issue Maybe we'll leave this issue open until it's fixed upstream?
As already suspected, OnlyOffice does not support Wayland at this point. Here is the upstream bug:
it works with
Change:
linux-manual = callPackage ../data/documentation/linux-manual { }; <ins> lklug-sinhala = callPackage ../data/fonts/lklug-sinhala {}; </ins> lmmath = callPackage ../data/fonts/lmmath {}; lmodern = callPackage ../data/fonts/lmodern { };

Discussion:
Project description describe the project a little Metadata homepage URL: source URL: license: gpl2Plus platforms: all
Change:
"python-mpv" ]; <ins> postPatch = '' sed -i "/--cov/d" setup.cfg sed -i "/--no-cov-on-fail/d" setup.cfg # https://github.com/sublime-music/sublime-music/pull/370 # Can be removed in later versions (probably > 0.11.16) substituteInPlace pyproject.toml  --replace 'python-Levenshtein = "^0.12.0"' 'Levenshtein = ">0.12.0"' ''; </ins> buildInputs = [ gtk3 pango ] <del> ++ lib.optional notifySupport libnotify ++ lib.optional networkSupport networkmanager </del> <ins> ++ lib.optional notifySupport libnotify ++ lib.optional networkSupport networkmanager </ins> ; propagatedBuildInputs = with python3Packages; [

Discussion:
Steps to reproduce the behavior: sublime-music Just the error: Full log: Add any other context about the problem here. Built OK as of rev . I tried bisecting but too many commits required me to build multiple versions of LLVM/GHC/god knows what else. I also tried applying patch from but that didn't change the error. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
Change:
# Reliably fails to generate gedit-file-browser-enum-types.h in time enableParallelBuilding = false; <ins> pythonPath = with python3Packages; [ # https://github.com/NixOS/nixpkgs/issues/298716 pycairo ]; postFixup = '' buildPythonPath "$pythonPath" patchPythonScript $out/lib/gedit/plugins/snippets/document.py ''; </ins> passthru = { updateScript = gnome.updateScript { packageName = "gedit";

Discussion:
Gedit is missing the pycairo dependency (python311Packages.pycairo specifically in my case) I'm on the unstable channel I'm new to nix, so maybe an indirect dependency is missing the pycairo dependency instead a terminal will periodically (~1 per second) print the error message see no errors with: . No error message should be printed. I'm using the Nix package manager on Manjaro Linux. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
sha256 = "0128n7jlshw4bpx0vg8lwj8qwdisjxi7mvniwfafgnkzzrfrpaap"; }; <del> patches = [ ./no-mkdir-localstatedir.patch ]; </del> <ins> patches = [ ./no-mkdir-localstatedir.patch (fetchpatch { name ="CVE-2017-6519-CVE-2018-100084.patch"; url = https://github.com/lathiat/avahi/commit/e111def44a7df4624a4aa3f85fe98054bffb6b4f.patch; sha256 = "06n7b7kz6xcc35c7xjfc1kj3k2llyjgi09nhy0ci32l1bhacjw0q"; }) ]; </ins> buildInputs = [ libdaemon dbus glib expat libiconv ] ++ (with perlPackages; [ perl XMLParser ])

Discussion:
, (nixos-unstable, nixos-19.03, nixos-18.09) Scanned versions: nixos-unstable: ; nixos-19.03: ; nixos-18.09: . May contain false positives.
Change:
}; default = mkOption { <del> default = 0; type = types.int; </del> <ins> default = "0"; type = types.either types.int types.str; apply = toString; </ins> description = '' Index of the default menu item to be booted. '';

Discussion:
only supports signed integers. Using "saved" inplace of the integer is supported by grub to boot the previously booted OS Set in your nixos config Output of
Change:
buildPythonPackage rec { pname = "bdffont"; <del> version = "0.0.20"; </del> <ins> version = "0.0.24"; </ins> disabled = pythonOlder "3.11"; src = fetchPypi { inherit pname version; <del> hash = "sha256-T0gTtudsZmL0VZ3a3+C/v+dWAwbXUgf0PEdNtkxWROw="; </del> <ins> hash = "sha256-3HJwtBV78zsMUlmwJrPj74Vd5cru1zflvies5mNGcy4="; </ins> }; format = "pyproject";

Discussion:
looking over broken python packages for ZHF and pixel-font-builder is missing a python module and needs a dependency relaxed. Steps to reproduce the behavior: *pixel-font-builder" pcffont not part of nixpkgs would add it but no longer a maintainer <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
--- a/create_manpage_completions.py +++ b/create_manpage_completions.py <del> @@ -776,8 +776,6 @@ def parse_manpage_at_path(manpage_path, output_directory): </del> <ins> @@ -844,10 +844,6 @@ def parse_manpage_at_path(manpage_path, output_directory): </ins> built_command_output.insert(0, "# " + CMDNAME) -            # Output the magic word Autogenerated so we can tell if we can overwrite this <del> -            built_command_output.insert(1, "# Autogenerated from man page " + manpage_path) </del> <ins> -            built_command_output.insert( -                1, "# Autogenerated from man page " + manpage_path -            ) </ins> # built_command_output.insert(2, "# using " + parser.__class__.__name__) # XXX MISATTRIBUTES THE CULPABILE PARSER! Was really using Type2 but reporting TypeDeroffManParser for line in built_command_output:

Discussion:
Describe the bug When trying to use the nixos module a patch is applied. This patch however does not match the updated fish package for . To Reproduce Steps to reproduce the behavior: containing: Expected behavior The module should be able to be enabled. Additional context Metadata system: host os: multi-user?: sandbox: version: nixpkgs: master @ Maintainer information:
Sorry about that. Could you see if solves your problem (it should, I hope)? I don't have an easy way to test this on NixOS :grimacing:
Change:
ardour = callPackage ../applications/audio/ardour { }; <del> ardour_5 = lowPrio (callPackage ../applications/audio/ardour/5.nix { }); </del> arelle = with python3Packages; toPythonApplication arelle; argo = callPackage ../applications/networking/cluster/argo { };

Discussion:
fails to build as There is an invasive change that fixed it in newer version: . But maybe it's a good time to remove old version? Maintainer information:
Started with commit
Is there a reason to still keep Ardour 5.x in nixpkgs? Edit: The reads: Is that still the case ?
Yes it is, but I'm not sure it's worth the effort to fix Ardour 5.
I prepared a PR which drops ardour_5 if we decide to go this way: