jiebi/CodeConvo huggingface dataset:
Change:
{ lib <del> , buildGoPackage </del> <ins> , buildGoModule </ins> , fetchFromGitHub }: <del> with builtins; buildGoPackage rec { </del> <ins> buildGoModule rec { </ins> pname = "safe"; <del> version = "1.5.1"; </del> <ins> version = "1.6.1"; </ins> src = fetchFromGitHub { owner = "starkandwayne"; repo = "safe"; rev = "v${version}"; <del> sha256 = "12gzxrnyl890h79z9yx23m1wwgy8ahm74q4qwi8n2nh7ydq6mn2d"; </del> <ins> sha256 = "sha256-ankX4BeMvBEd0e01mQHfaPg4z1z+IZqELaSEJ5deF8Y="; </ins> }; <del> goPackagePath = "github.com/starkandwayne/safe"; </del> <ins> vendorSha256 = "sha256-7hX35FfFxfoiI/dSxWhZH8iJoRWa4slAJF0lULq8KL4="; subPackages = [ "." ]; </ins> ldflags = [ "-X main.Version=${version}"

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: safe <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.5.1 desired version: 1.6.1 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
}: let <del> version = "1.7.2"; </del> <ins> version = "1.8.0"; </ins> # build stimuli file for PGO build and the script to generate it # independently of the foot's build, so we can cache the result

Discussion:
Project description The terminal is already packaged in nixpkgs. As foot uses its own terminfo, this terminfo is needed on any remote servers you connect to using foot. It would be useful to have this terminfo packaged as its own output as with other terminals: alacritty, kitty, rxvt-unicode to name a few. ping foot maintainer for feedback Metadata homepage URL: source URL: license: mit platforms: linux
That is a very good idea! Unfortunately it doesn't seem to be possible to specify a separate install directory for foot's terminfo so far (it is installed to along with the license etc.). I'll open an upstream ticket, they are usually very helpful, and then we'll be hopefully be able to set this pretty soon.
Change:
<ins> lzipUnpackCmdHook() { [[ "$1" = *.tar.lz ]] && tar --lzip -xf "$1" } unpackCmdHooks+=(lzipUnpackCmdHook) </ins>

Discussion:
There seems to be no man page for ed, the standard text editor.
It looks like an issue in how ed installs things:
The target directory is set with: There's another configure flag, , that defaults to . I think nix automatically replaces that by . Resulting in . would default to '$(prefix), but since it was set, the bin files ended up in the right place. Not setting any installFlags results in a correct tree. It basically lets nix figure it out. I noticed very recently replaced by'. Todo: [x] Confirm it's ok to not set the
Yes, removing is usually the correct option.
Fixed by .
Change:
libiconv ]; <ins> qtWrapperArgs = [ "--prefix PATH : ${filterPath}" ]; </ins> # the filters search through ${PATH} using a sh proc 'checkcmds' for the # filtering utils. Short circuit this by replacing the filtering command with # the absolute path to the filtering command.

Discussion:
Steps to reproduce the behavior: Note: is a recoll dependency that previously didn't build (); graciously fixed it but it currently isn't merged. This reflects their fix: (doesn't build on macOS; builds fine elsewhere) tl;dr is <!-- --Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I have something that builds and will show a gui but not sure how much else works. can try with:
Change:
imageJson=$(cat ${baseJson} | jq ". + {"rootfs": {"diff_ids": [], "type": "layers"}}") manifestJson=$(jq -n "[{"RepoTags":["$imageName:$imageTag"]}]") <del> for layerTar in $(cat ./layer-list); do </del> <ins> for layerTar in $(tac ./layer-list); do </ins> layerChecksum=$(sha256sum image/$layerTar | cut -d ' ' -f1) imageJson=$(echo "$imageJson" | jq ".history |= [{"created": "$(jq -r .created ${baseJson})"}] + .") imageJson=$(echo "$imageJson" | jq ".rootfs.diff_ids |= ["sha256:$layerChecksum"] + .")

Discussion:
Using with a doesn't work right anymore after (and the bugfix commit ). I have a simple Docker image I'm using as a , which sets up a user and puts some files in their home directory . (The exact setup doesn't matter.) When I use , the files that are present in the home folder in the base image are lost. This used to work before the commits above. I made this repro derivation: Try running and compare that output to the base image: You will see that the repro image is missing files. CC
(To be clear, it is now broken for a normal , not a layered one.)
Friendly ping , can you tell what broke here?
it seems to be related to the layers ordering. If you both images, you will see layers are reversed. Could you check the associated PR fixes this issue?
Yes, that seems to work! Many thanks :)
Merged so this should be fixed. Thanks !
Oh no, I found another aspect of this which is still broken :(. I think it's still covered under this issue, so I think we should reopen this one rather than file another, is that okay? There's still a problem when you have a command in the command: the layers from the base image aren't present. Here's my repro from above with that addition: If you run and look at the build output, you'll see the output of the command. Because the base image I'm using has an user named "user", you should see a line like this: but due to the regression from you don't see that line. This is preventing me from doing some extra setup that depends on stuff in the base image. Any chance you can see a fix ? :)
Does fix this issue?
Yes , that seems to work! Thanks again
Change:
<ins> { config, lib, pkgs, ... }: let cfg = config.programs.rog-control-center; in { options = { programs.rog-control-center = { enable = lib.mkEnableOption (lib.mdDoc "the rog-control-center application"); autoStart = lib.mkOption { default = false; type = lib.types.bool; description = lib.mdDoc "Whether rog-control-center should be started automatically."; }; }; }; config = lib.mkIf cfg.enable { environment.systemPackages = [ pkgs.asusctl (lib.mkIf cfg.autoStart (pkgs.makeAutostartItem { name = "rog-control-center"; package = pkgs.asusctl; })) ]; services.asusd.enable = true; }; meta.maintainers = pkgs.asusctl.meta.maintainers; } </ins>

Discussion:
Project description It is a command line utility which adds features for asus laptops. For example graphics card switching, anime matrix control (for g14). fan control, keyboard backlight control, cpu boost control, profiles, fan curves and other stuff. It basically unlocks a lot of functionality for laptops and can be used for non asus laptops as well contrary to the name. Metadata homepage URL:https://asus- source license: Mozilla Public License 2.0 platforms: Linux
I've made a PR to introduce the asusctl package as well as a NixOS module to run asusd. Can someone give this a try, I personally do not have Asus hardware to test it properly. You can find the PR here:
Change:
, buildPythonPackage , fetchFromGitHub , substituteAll , cmdstan <ins> , pythonRelaxDepsHook , setuptools </ins> , pandas , numpy , tqdm , stanio , xarray , pytestCheckHook }: buildPythonPackage rec { pname = "cmdstanpy"; version = "1.2.0"; <del> format = "setuptools"; </del> <ins> pyproject = true; </ins> src = fetchFromGitHub { owner = "stan-dev";

Discussion:
Steps to reproduce the behavior: stanio bump caused a build faliure. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
It turns out it's actually an issue with he python package. It looks like the fact that uses the new builder made it so that it even if builds without complaining (probably something to do with the legacy builder), trying to include it as a dependency of will detect the version error. I'll try to open a PR, which updates to use the new builder (and I'll relax the dependency constraint too).
Thank you Toma for fast response and resolution!
Change:
passthru = { updateScript = nix-update-script { }; <del> tests.version = testers.testVersion { package = mold; }; </del> <ins> tests = let helloTest = name: helloMold: let command = "$READELF -p .comment ${lib.getExe helloMold}"; emulator = stdenv.hostPlatform.emulator buildPackages; in runCommandCC "mold-${name}-test" { passthru = { inherit helloMold; }; } '' echo "Testing running the 'hello' binary which should be linked with 'mold'" >&2 ${emulator} ${lib.getExe helloMold} echo "Checking for mold in the '.comment' section" >&2 if output=$(${command} 2>&1); then if grep -Fw -- "mold" - <<< "$output"; then touch $out else echo "No mention of 'mold' detected in the '.comment' section" >&2 echo "The command was:" >&2 echo "${command}" >&2 echo "The output was:" >&2 echo "$output" >&2 exit 1 fi else echo -n "${command}" >&2 echo " returned a non-zero exit code." >&2 echo "$output" >&2 exit 1 fi '' ; in { version = testers.testVersion { package = mold; }; wrapped = helloTest "wrapped" (hello.overrideAttrs (previousAttrs: { nativeBuildInputs = (previousAttrs.nativeBuildInputs or [ ]) ++ [ mold-wrapped ]; NIX_CFLAGS_LINK = toString (previousAttrs.NIX_CFLAGS_LINK or "") + " -fuse-ld=mold"; })); adapter = helloTest "adapter" (hello.override (old: { stdenv = useMoldLinker old.stdenv; })); }; </ins> }; meta = with lib; { <del> description = "A faster drop-in replacement for existing Unix linkers"; </del> <ins> description = "A faster drop-in replacement for existing Unix linkers (unwrapped)"; </ins> longDescription = '' mold is a faster drop-in replacement for existing Unix linkers. It is several times faster than the LLVM lld linker. mold is designed to

Discussion:
is a fast and multi threaded modern linker. We already have it in Nixpkgs, however, unlike , it has not been wrapped in a package so that it can find the libraries to dynamically link against. Hence, dynamic linking in in NixOS fails. This issue is created so that we can wrap mold inside a shell script, like what happens to when it is installed through or even normal . I would be open to helping port such a script for .
I have tried simply replacing the executable with in the wrapper script, but it didn't seem to work. I am not very familiar with how this script works or what I am missing For more information, see
After some discussion on Matrix (thanks !), I was able to get mold working in a dev shell by using the following snippet: Is there any way we can just expose this as a wrapped mold in Nixpkgs so we don't have to add this to every shell we need mold in?
Is this relevant anymore? In addition to , we also have now. Here's a test we have for it in :
Further work is to rename to so users have to choose explicitly
Change:
<ins> From 9a0102fe1da038ebe08107ead991964df11b0271 Mon Sep 17 00:00:00 2001 From: annalee <150648636+a-n-n-a-l-e-e@users.noreply.github.com> Date: Mon, 19 Feb 2024 03:31:20 +0000 Subject: [PATCH] no qtgui darwin bundle --- qtgui/recoll.pro.in | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/qtgui/recoll.pro.in b/qtgui/recoll.pro.in index a0ef314..6dbc3b5 100644 --- a/qtgui/recoll.pro.in +++ b/qtgui/recoll.pro.in @@ -180,7 +180,7 @@ windows { } } -macx: { +if (false) { QCBUILDLOC=Qt_6_4_2_for_macOS # QT += webkit webkitwidgets @@ -375,7 +375,7 @@ macx: { QMAKE_BUNDLE_DATA = APP_EXAMPLES APP_EXAMPLES_MAC APP_FILTERS APP_IMAGES APP_DOC } -unix:!macx { +unix { VPATH = @srcdir@ @@ -400,6 +400,13 @@ VPATH = @srcdir@ SOURCES += crontool.cpp  rtitool.cpp +  macx { +    SOURCES += ../utils/closefrom.cpp  +    ../utils/execmd.cpp  +    ../utils/netcon.cpp  +    ../utils/rclionice.cpp +  } + FORMS  += crontool.ui  rtitool.ui -- 2.43.0 </ins>

Discussion:
Steps to reproduce the behavior: Note: is a recoll dependency that previously didn't build (); graciously fixed it but it currently isn't merged. This reflects their fix: (doesn't build on macOS; builds fine elsewhere) tl;dr is <!-- --Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I have something that builds and will show a gui but not sure how much else works. can try with:
Change:
and the actions to switch to the new system are calculated. This process takes two data sources into account: `/etc/fstab` and the current systemd status. Mounts and swaps are read from `/etc/fstab` and the corresponding actions are <del> generated. If a new mount is added, for example, the proper `.mount` unit is marked to be started. The current systemd state is inspected, the difference </del> <ins> generated. If the options of a mount are modified, for example, the proper `.mount` unit is reloaded (or restarted if anything else changed and it's neither the root mount or the nix store). The current systemd state is inspected, the difference </ins> between the current system and the desired configuration is calculated and actions are generated to get to this state. There are a lot of nuances that can be controlled by the units which are explained here.

Discussion:
The script is apparently trying to stop and start changed .mount units, presumably to cause a ? If that happens the script fails and the new configuration is not activated. Worse, the system is left in a broken state with some of the stopped (as part of the switch) units never restarted. Steps to reproduce the behavior: the value of , for example from to . The unit should probably not be stopped and the switch should succeed. If using remotely also the SSH connection drops. NixOS version: 23.05.1194. (Stoat) The filesystem entry is: cc:
I just ran into this error myself. I am unsure of which configuration change caused this. But I was changing config and I think was saying some setting conflicts with my , which was at . So I updated to and then flashed me this error: before giving me a black screen and send me to the login prompt.
were you ever able to fix your issue?
No fix, I'm pretty sure changing the unit will still trigger a stop.
Unfortunately, you are correct. I do have a fix in the pipeline though. improves the handling of mount units () and I plan to adapt this to fstab mounts as well (). This is currently being blocked by the fstab parser not having any tests but I plan on writing them. Will keep this issue in mind.
Now that I look at the code again… it already looks correct. Can someone with this issue post a diff of their fstab? Something like should do.
Change:
fd = callPackage ../tools/misc/fd { }; <ins> fdroidcl = pkgs.callPackage ../development/mobile/fdroidcl { }; </ins> fdroidserver = python3Packages.callPackage ../development/tools/fdroidserver { }; fetch-scm = callPackage ../tools/misc/fetch-scm { };

Discussion:
Project description <!-- Describe the project a little: --Command-line tool for managing and installing F-Droid APKs on an Android device via ADB. Metadata homepage URL: source URL: license: BSD 3-Clause platforms: unix, linux, darwin
Change:
<del> { lib , stdenv , clangStdenv , darwin , xcbuild , openssl , pkg-config , rustPlatform , fetchFromGitHub }: rustPlatform.buildRustPackage.override { stdenv = clangStdenv; } rec { pname = "crunchy-cli"; version = "3.0.0-dev.10"; src = fetchFromGitHub { owner = "crunchy-labs"; repo = pname; rev = "v${version}"; hash = "sha256-uc19SmVfa5BZYDidlEgV6GNvcm9Dj0mSjdwHP5S+O4A="; }; cargoHash = "sha256-H3D55qMUAF6t45mRbGZl+DORAl1H1a7AOe+lQP0WUUQ="; nativeBuildInputs = [ pkg-config ] ++ lib.optionals stdenv.isDarwin [ xcbuild ]; buildInputs = [ openssl ] ++ lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; meta = with lib; { description = "A pure Rust written Crunchyroll cli client and downloader"; homepage = "https://github.com/crunchy-labs/crunchy-cli"; license = with licenses; [ gpl3 ]; maintainers = with maintainers; [ stepbrobd ]; mainProgram = "crunchy-cli"; }; } </del>

Discussion:
Package name: crunchy-cli Latest released version: 3.2.2 <!-- Search your package here: --- Current version on the unstable channel: 3.0.0-dev.10 Current version on the stable/release channel: 3.0.0-dev.10 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Change:
<del> diff --git a/contrib/ssh-copy-id b/contrib/ssh-copy-id index 392f64f..a769077 100644 --- a/contrib/ssh-copy-id +++ b/contrib/ssh-copy-id @@ -247,7 +247,7 @@ installkeys_sh() { #    the -z `tail ...` checks for a trailing newline. The echo adds one if was missing #    the cat adds the keys we're getting via STDIN #    and if available restorecon is used to restore the SELinux context -  INSTALLKEYS_SH=$(tr 'tn' ' ' <<-EOF) +  INSTALLKEYS_SH=$(tr 'tn' ' ' <<-EOF cd; umask 077; mkdir -p $(dirname "${AUTH_KEY_FILE}") && @@ -258,6 +258,7 @@ installkeys_sh() { restorecon -F .ssh ${AUTH_KEY_FILE}; fi EOF +  ) # to defend against quirky remote shells: use 'exec sh -c' to get POSIX; printf "exec sh -c '%s'" "${INSTALLKEYS_SH}" </del>

Discussion:
, CVSSv3=7.0 (nixos-21.05) CVSSv3=5.3 (nixos-21.05) sshd in OpenSSH 6.2 through 8.x before 8.8, when certain non-default configurations are used, allows privilege escalation because supplemental groups are not initialized as expected. Helper programs for AuthorizedKeysCommand and AuthorizedPrincipalsCommand may run with privileges associated with group memberships of the sshd process, if the configuration specifies running the command as a different user. OpenSSH through 8.7 allows remote attackers, who have a suspicion that a certain combination of username and public key is known to an SSH server, to test whether this suspicion is correct. This occurs because a challenge is sent only when that combination could be valid for a login session. Scanned versions: nixos-21.05: . Cc Cc
Change:
<ins> diff --git a/WORKSPACE b/WORKSPACE index 51273b6..fcf9ffb 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -61,7 +61,7 @@ load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_depe go_rules_dependencies() -go_register_toolchains() +go_register_toolchains(go_version = "host") load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository") </ins>

Discussion:
I can't build bazel-watcher on the latest master <details<summaryShell session</summary</detailsPlease run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): channels(kalbasit): channels(yl): nixpkgs: cc
Change:
s/^s*checkAvahiDaemon$/:/ s/^s*installBundledInstall$/:/ s/`hostname`/""/ <del> ' MathInstaller </del> <ins> ' $INSTALLER </ins> # NOTE: some files placed under HOME may be useful XDG_DATA_HOME="$out/share" HOME="$TMPDIR/home" vernierLink=y  <del> ./MathInstaller -execdir="$out/bin" -targetdir="$out/libexec/Mathematica" -auto -verbose -createdir=y </del> <ins> ./$INSTALLER -execdir="$out/bin" -targetdir="$out/libexec/Mathematica" -auto -verbose -createdir=y </ins> <del> # Check if MathInstaller produced any errors </del> <ins> # Check if Installer produced any errors </ins> errLog="$out/libexec/Mathematica/InstallErrors" if [ -f "$errLog" ]; then echo "Installation errors:"

Discussion:
(Note: this may be a somewhat more complex upgrade, as Wolfram has moved to using the Wolfram Installer for everything. Not sure if that'll affect the actual package, though.) Package name: mathematica Latest released version: 14.1.0 <!-- Search your package here: --- Current version on the unstable channel: 14.0.0 Current version on the stable/release channel: 14.1.0 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers Note for maintainers: Please tag this issue in your PR.
Also, I'm not currently able to find a link with the old installer for 14.0.0. Wolfram may have taken it down, making it seemingly impossible to install this package right now. If anyone knows an archive of it, please let me know.
Found a direct link: If you're signed into your wolfram account, this will work. This works for using mathematica until the package update.
I will take a look at this later in October. I apologize for the delay.
Change:
postFixup = '' wrapPythonPrograms <ins> wrapProgram $out/bin/ceph-mgr --set PYTHONPATH $out/${python2Packages.python.sitePackages} </ins> ''; enableParallelBuilding = true;

Discussion:
Enable and provision ceph and a mgr daemon. Ran on a modified nixos-unstable
Race you. :-)
Hehe, simple fix ;) and the steps to reproduce should include "enable dashboard module" because iirc it isn't enabled by default :)
solves the issue ^^
Oh, I see. I was converting an old cluster, and of course the dashboard was enabled there. Sorry! :-)
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
Iirc this was merged and resolved the 27th of March when merged my commit, so I'm closing this issue so that stalebot is happy
Change:
stdenv.mkDerivation rec { pname = "binaryen"; <del> version = "117"; </del> <ins> version = "118"; </ins> src = fetchFromGitHub { owner = "WebAssembly"; repo = "binaryen"; rev = "version_${version}"; <del> hash = "sha256-QYJkrvwcUWbFV5oQdP11JuVmfOTYaFWGQGksboQ1d58="; </del> <ins> hash = "sha256-akMW3S2/qUyLK8F77EtnaXPDXvIMpkGfNB2jOD6hQho="; </ins> }; nativeBuildInputs = [ cmake python3 ];

Discussion:
Package name: emscripten Latest released version: 3.1.57 <!-- Search your package here: --- Current version on the unstable channel: 3.1.51 Current version on the stable/release channel: 3.1.47 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
tl;dr: 3.1.57 is not currently compatible with the version of llvm in tree (18.1.5). The latest compatible version with llvm 18.1.5 appears to be Emscripten 3.1.54. The emscripten nixpkg (3.1.51) currently uses an LLVM17 environment which needs be migrated to LLVM18. The configuration as it exists today doesn't work in some cases. (Godot4.3dev6 web template builds failed missing in , prompting finding this issue) Emscripten 3.1.51 seems to be compatible with the LLVM 18.1.5 currently in nixpkgs unstable. Emscripten 3.1.59 (current as of this comment) and 3.1.57 are not compatible with that version of LLVM (In my usage, ran into errors with and ). These flags were introduced in Emscripten 3.1.55 making the last compatible version against the current in-tree dependencies 3.1.54. <details<summaryThis override was able to successfully build the godot4.3dev6 web templates using Emscripten 3.1.54</summary<p</p</details