jiebi/CodeConvo huggingface dataset:
Change:
<del> { lib, stdenv, fetchurl, m4, expat , libX11, libXt, libXaw, libXmu, bdftopcf, mkfontdir , fontadobe100dpi, fontadobeutopia100dpi, fontbh100dpi , fontbhlucidatypewriter100dpi, fontbitstream100dpi </del> <ins> { stdenv , darwin , lib , libiconv , fetchurl , m4 , expat , libX11 , libXt , libXaw , libXmu , bdftopcf , mkfontdir , fontadobe100dpi , fontadobeutopia100dpi , fontbh100dpi , fontbhlucidatypewriter100dpi , fontbitstream100dpi </ins> , tcl <del> , ncurses }: </del> <ins> , ncurses }: </ins> let majorVersion = "4"; <del> minorVersion = "0"; versionSuffix = "ga9"; in stdenv.mkDerivation rec { </del> <ins> minorVersion = "3"; versionSuffix = "ga8"; in stdenv.mkDerivation rec { </ins> pname = "x3270"; version = "${majorVersion}.${minorVersion}${versionSuffix}"; src = fetchurl { <del> url = "http://x3270.bgp.nu/download/0${majorVersion}.0${minorVersion}/suite3270-${version}-src.tgz"; sha256 = "0km24rgll0s4ji6iz8lvy5ra76ds162s95y33w5px6697cwqkp9j"; </del> <ins> url = "http://x3270.bgp.nu/download/0${majorVersion}.0${minorVersion}/suite3270-${version}-src.tgz"; sha256 = "sha256-gcC6REfZentIPEDhGznUSYu8mvVfpPeMz/Bks+N43Fk="; </ins> }; <del> buildFlags = [ "unix" ]; </del> <ins> buildFlags = lib.optional stdenv.isLinux "unix"; configureFlags = lib.optionals stdenv.isDarwin [ "--enable-c3270" "--enable-pr3270" "--enable-s3270" "--enable-tcl3270" ]; </ins> <del> postConfigure = '' pushd c3270 ; ./configure ; popd </del> <ins> postBuild = '' make install.man </ins> ''; <ins> pathsToLink = [ "/share/man" ]; </ins> nativeBuildInputs = [ m4 ]; buildInputs = [ expat <del> libX11 libXt libXaw libXmu bdftopcf mkfontdir fontadobe100dpi fontadobeutopia100dpi fontbh100dpi fontbhlucidatypewriter100dpi fontbitstream100dpi </del> <ins> libX11 libXt libXaw libXmu bdftopcf mkfontdir fontadobe100dpi fontadobeutopia100dpi fontbh100dpi fontbhlucidatypewriter100dpi fontbitstream100dpi </ins> tcl ncurses expat <del> ]; </del> <ins> ] ++ lib.optionals stdenv.isDarwin [ libiconv darwin.apple_sdk.frameworks.Security ]; </ins> meta = with lib; { description = "IBM 3270 terminal emulator for the X Window System";

Discussion:
Steps to reproduce the behavior: x3270 on darwin fails due to missing macOs dependencies (libiconv/Security) The are a few things missing that are need to get this to work on macOS use & link iconv use Security package for headers disable x3270 build (the other unix builds are fine) Please run and paste the result. I have a fixed package for this that I can open a PR for
Change:
-e 's,libprotobuf.a,protobuf,g' ''; <del> free = stdenv.mkDerivation { </del> <ins> free = mkDerivation { </ins> pname = "clementine-free"; inherit version; inherit src patches nativeBuildInputs postPatch;

Discussion:
Describe the bug Since some day, clementine refuse to work. I bisected the error to the commit . The error message in the terminal is: realloc(): invalid pointer fish : Tâche , './result/bin/clementine' terminée par le signal SIGABRT (Abandon) To Reproduce go to a nixpkgs git tree Expected behavior clementine start as expected Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(marius): nixpkgs: Maintainer information:
Looks like we are hitting here. cc
I could have sworn I tested this… let me see if I can reproduce this issue.
Yup, and reverting the projectm fix makes it run again. Hm… I was really sure I tested clementine. I don't think I'll have time to look into this properly until the weekend, so as a quick fix, you can revert the projectm update, if you want to.
Change:
<del> { lib, stdenv </del> <ins> { stdenv , lib , substituteAll </ins> , fetchurl , pkg-config , which

Discussion:
Describe the bug Trying to run a nautilus-python extension (syncstate-) fails with ImportError: could not import gobject (error was: ModuleNotFoundError("No module named 'gi'")) To Reproduce gnome3 and install nextcloud-client nautilus from terminal with something like Expected behavior python should find gi. Additional context I think it is part of pygobject3 which is in buildInputs therefore I think it is a problem of a wrong NIXPYTHONPATH Notify maintainers Metadata system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
I am not sure if it ever worked. The shared module links against pygobject but that still does not have to mean the gi module will be available on Python side. Maybe we need something like the following: At least until we have .
Yes this works, thank you!
hmmm I just tried with the new nautilus-python, but the nautilus python extensions still fail due to missing gi. Is there a reason that you tried to load gi in nautilus-python and not add the prefix arg as in your comment?
Did you make sure is updated? It worked for me with gsconnect extension. I chose that method because pygobject is really nautilus-python dependency, not nautilus one.
nevermind it works now (also with nextcloud), I forgot the in the overlay where I overwrote the package from master. Thanks for fixing it!
Change:
mkDerivation rec { pname = "qdigidoc"; <del> version = "4.2.9"; </del> <ins> version = "4.2.11"; </ins> src = fetchurl { url = <del> "https://github.com/open-eid/DigiDoc4-Client/releases/download/v${version}/qdigidoc4-${version}.tar.gz"; sha256 = "1rhd3mvj6ld16zgfscj81f1vhs2nvifsizky509l1av7dsjfbbzr"; </del> <ins> "https://github.com/open-eid/DigiDoc4-Client/releases/download/v${version}/qdigidoc4_${version}.110-1804.tar.xz"; sha256 = "sha256-Sg6lFZeIJn3T/suDc5Z/kNqBf/sIV9c6EJJ0Nr0dwTM="; </ins> }; tsl = fetchurl {

Discussion:
See line 75 of for why this is needed.
So ... does anyone have an opinion on this change request?
Well, if it's a fix, then I won't object :) I cannot really oversee the consequences though
is (eventually) being deprecated in favor of IIUC. Please reopen if this is still an issue for .
Change:
root * ${cfg.ui.package}/dist file_server } <ins> handle_path /static/undefined/* { root * ${cfg.ui.package}/dist file_server } </ins> @for_backend { path /api/* /pictrs/* /feeds/* /nodeinfo/* }

Discussion:
When trying to run a Lemmy instance with caddy enabled, the site is completely broken due to the caddy config not properly handling the requests to the static files for the lemmy-ui. On unstable nixpkgs as of today. The served lemmy site should not be broken. Calls such as should work. The site works with as expected. This is what happens with the current caddy handling ! This is what should happen ! I temporarily ""fixed"" this to produce the second screenshot by modifying the following line: to However, I'm not sure if this is the proper fix for this.
Looking at the nginx configuration, they just pass through everything that is not a json request to the ui to serve. How about something like we can add missing paths to the end of this if you find any others.
I'm not very well versed with caddy config so I don't know if this can be handled in a better way. It looks like can only handle a single argument and thus multiple paths like this don't work unless you copy the whole block again.
you're right, I had a look at the docs, and indeed, this needs a new block (handlepath is just handle with ) Would you mind making a PR to add the other block ? (no worries if you are busy or unavailable, just let me know).
Sorry for the delay, I've the pull request.
Change:
free = false; }; <ins> cc-by-nd-40 = { spdxId = "CC-BY-ND-4.0"; fullName = "Creative Commons Attribution-No Derivative Works v4.0"; free = false; }; </ins> cc-by-sa-10 = { spdxId = "CC-BY-SA-1.0"; fullName = "Creative Commons Attribution Share Alike 1.0";

Discussion:
Project description <!-- Describe the project a little: --Metadata homepage URL: https://mqtt- source URL: license: creative commons platforms: linux, darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
AppImage works fine with appimage-run. There is also a deb and snap package
I use this one
That package looks great. Maybe even worth to try to contribute to nixpkgs.
Unfortunately I don't think the appImage version would be accepted since the source code is available with a build manual so imho a PR to nixpkgs would need to be with a source build. I might look into it
I maybe have a potentially working version. I'll try to find some macs to test out the Darwin versions and if that's gonna be okay I'll then submit a PR
Great news, I can test on darwin.
Change:
systemd.services.systemd-timesyncd = { wantedBy = [ "sysinit.target" ]; <ins> aliases = [ "dbus-org.freedesktop.timesync1.service" ]; </ins> restartTriggers = [ config.environment.etc."systemd/timesyncd.conf".source ]; };

Discussion:
Describe the bug Systemd ships dbus system services (in ), which are used for dbus system activation (see ) This includes some of the units shipped with systemd itself: We currently don't have the proper tooling ready to make these available in NixOS. Also, we shouldn't blindly enable all. For example, we might not want to enable `share/dbus-1/system-services/org.freedesktop.resolve1.service, if resolved is enabled. Originally discovered in , but it always hasn't worked, so it's not a regression. Notify maintainers
I wonder if that's why every program I have that uses dBus in some way or another, spits from time to time:
Can you tell me which programs those are?
Sure, from , prints: I'm using as my display manager and I'm using as my desktop environment but I don't use . Not sure if that matters.. EDIT: Currently I can't identify another program that spits this message, although IIRC I saw it coming out of other programs as well. This could be an upstream issue as well.
It does seem that somehow picks up the systemd configuration; though I do not fully understand how it's just missing the when is enabled
Ah apparently all applications are loaded into dbus by default? Not sure how I feel about that ... so the only reason why resolved wasn't working is because we didnt included unit file in Easy fix! All the other services already work!
It seems we do, but we shouldn't do that. If we try to not restart , changes in there don't get propagated. It should just use nscd like everything else. can you file a PR removing this?
reopened, as got reverted.
I've found another example for: prints:
Another symptom is:
I'm not sure if that is a symptom of what I am solving here. I recall recently running into the same issue and I think it's a problem with how we set up user environment in certain desktop managers.
Should I open a distinct issue then?
Change:
mkdir -p $out/$dir fi <del> substitute $src $target $replacements </del> <ins> substitutionsList=($replacements) if [[ -v substitutions ]]; then eval "substitutionsList+=($substitutions)" fi substitute $src $target "${substitutionsList[@]}" </ins> if test -n "$isExecutable"; then chmod +x $target

Discussion:
Using with , currently does not allow me to replace a string that contains spaces. Steps to reproduce the behavior: the code below: It gives the following error: I tried quoting it, escaping the spaces... but none of them seemed to work. The I did succeeds. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. I posted this in the NixOS matrix room a while ago (but I forgot to submit an issue): !$ People showed me some bash magic I couldn't understand, I think they might be helpful and worth checking out. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (git blame) cc (people in the original conversation) Please run and paste the result. (I'm sorry if I described anything incorrectly, I'm a not a native English speaker and I am still trying to improve my language skills) Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Should be fixed with , please give it a try :)
Wonderful! It worked for me
Change:
wantedBy = [ "multi-user.target" ]; serviceConfig = { ExecStart = "${cfg.package.fhs}/bin/onlyoffice-wrapper DocService/docservice /run/onlyoffice/config"; <del> ExecStartPre = onlyoffice-prestart; </del> <ins> ExecStartPre = [ onlyoffice-prestart ]; </ins> Group = "onlyoffice"; Restart = "always"; RuntimeDirectory = "onlyoffice";

Discussion:
I want to change a configuration variable to onlyoffice. Currently, the NixOS module adapts on the fly in the upstream configuration with a call. I'd like to make my own adaptation. For now it's not possible due to ExecStartPre being not declared as a list, but as a direct value.
Change:
environment.etc."X11/xkb".source = xcfg.xkbDir; <ins> environment.sessionVariables.PLASMA_USE_QT_SCALING = mkIf cfg.useQtScaling "1"; </ins> # Enable GTK applications to load SVG icons services.xserver.gdk-pixbuf.modulePackages = [ pkgs.librsvg ];

Discussion:
We should add a NixOS option to set the environment variable. This variable is very useful for HiDPI displays, but it is not enabled by default.
I marked this as stale due to inactivity. &rarr;
This is still an issue, and a good first one at that.
Hey, i'd like to try and get this working, as a first issue :), seems within my grasp and i'd love to start contributing. Just to make sure, this variable being unset has the exact same effect of it being set to 0, right? So i can safely make the NixOS option (which would be the default?) explicitly set it to zero without changing current behaviour?
Change:
cmakeFlags = [ "-DWITH_PYTHON3=ON" <del> "-DWITH_SYSTEM_ROCKSDB=OFF" </del> <ins> "-DWITH_SYSTEM_ROCKSDB=OFF"  # breaks Bluestore </ins> "-DCMAKE_INSTALL_DATADIR=${placeholder "lib"}/lib" "-DWITH_SYSTEM_BOOST=ON" <del> "-DWITH_SYSTEM_ROCKSDB=ON" </del> "-DWITH_SYSTEM_GTEST=ON" "-DMGR_PYTHON_VERSION=${ceph-python-env.python.pythonVersion}" "-DWITH_SYSTEMD=OFF"

Discussion:
Describe the bug Using ceph-volume to create a new bluestore-backed OSD doesn't work. To Reproduce Steps to reproduce the behavior: -volume lvm create --data /dev/sda --bluestore --no-systemd Expected behavior A clear and concise description of what you expected to happen. A new Bluestore OSD (on LVM) is successfully provisioned. Switching RocksDB to the Ceph-bundled copy rather than the OS version makes it work. I note that the Ceph NixOS test uses filestore instead. Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
Change:
${optionalString cfg.userControlled.enable '' ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=${cfg.userControlled.group} update_config=1''} <del> ${concatStringsSep "n" (mapAttrsToList (ssid: networkConfig: '' </del> <ins> ${concatStringsSep "n" (mapAttrsToList (ssid: networkConfig: let psk = if networkConfig.psk != null then ''"${networkConfig.psk}"'' else networkConfig.pskRaw; in '' </ins> network={ ssid="${ssid}" <del> ${optionalString (networkConfig.psk != null) ''psk="${networkConfig.psk}"''} ${optionalString (networkConfig.psk == null) ''key_mgmt=NONE''} </del> <ins> ${optionalString (psk != null) ''psk=${psk}''} ${optionalString (psk == null) ''key_mgmt=NONE''} </ins> } '') cfg.networks)} '' else "/etc/wpa_supplicant.conf";

Discussion:
has two forms of input for the field. and . I personally use the latter as it is the output of and better than having cleartext passphrases. (This also works with a random AES key - so long that it is shared) The current implementation lacks the distinction and only works with passphrases. I believe this should be .
Change:
<ins> { lib , buildPythonPackage , pythonOlder , fetchFromGitHub , sphinx , requests }: buildPythonPackage rec { pname = "instaloader"; version = "4.9.2"; format = "pyproject"; disabled = pythonOlder "3.6"; src = fetchFromGitHub { owner = "instaloader"; repo = "instaloader"; rev = "v${version}"; sha256 = "sha256-IzOXtoHuKbeHlp4URAlRrSKZ8mRTK7QgsWGd5a99thY="; }; propagatedBuildInputs = [ requests sphinx ]; pythonImportsCheck = [ "instaloader" ]; meta = with lib; { homepage = "https://instaloader.github.io/"; description = "Download pictures (or videos) along with their captions and other metadata from Instagram"; maintainers = with maintainers; [ creator54 ]; license = licenses.mit; }; } </ins>

Discussion:
Project description Instaloader is a tool to download pictures (or videos) along with their captions and other metadata from Instagram. Metadata homepage URL: source URL: license: mit platforms: unix, linux, darwin, ...
Change:
patches = upstreamPatches ++ [ ./pgrp-pipe-5.patch <del> (fetchurl { name = "fix-static.patch"; url = "https://cgit.freebsd.org/ports/plain/shells/bash/files/patch-configure?id=3e147a1f594751a68fea00a28090d0792bee0b51"; sha256 = "XHFMQ6eXTReNoywdETyrfQEv1rKF8+XFbQZP4YoVKFk="; }) </del> # Apply parallel build fix pending upstream inclusion: #   https://savannah.gnu.org/patch/index.php?10373 # Had to fetch manually to workaround -p0 default. ./parallel.patch <ins> # Fix `pop_var_context: head of shell_variables not a function context`. ./fix-pop-var-context-error.patch </ins> ]; configureFlags = [

Discussion:
Not a nixpkgs bug nor the cause of any failure
I ran into this when trying to build Bottles. In case anyone finds this issue and is trying to track down a potential source of it. There is a with a workout around for Bottles that is merged and to nixos-unstable.
Hi this issue's topic is unrelated to the error you're speaking of. See -- the line in this issue can be ignored. The actual issue is above that line in the pahelper build you're talking about:
:pray: thank you very much for clarifying that !
Is there some mitigation for this I can do? Because right now I'm getting this error when trying to build various Python packages and it is pretty annoying.
Either ignore it or backport the fix
How do I ignore it? It seems to break my builds.
No, your builds are failing for a different reason. The error in this issue occurs when the build fails at a certain point, you can just ignore it.
I still have this issue as of today. I'm recompiling to change shortcuts (that's how it is done). When invoking in the hook, I have the mentioned issue. I have had issues with (and the very same error message) in other derivations, too. This has probably nothing to do with . I just happen to use it regularly.
No surprise here, your grep command is failing (because ), so the build fails. Please try to keep on topic.
Ah, yes, you're right. It's the combination of the + grep failing. Thanks. Please try to be polite.
I backported the upstream fix in It looks like only one part of that commit was relevant to this bug, so it applies pretty cleanly.
Change:
pynose = callPackage ../development/python-modules/pynose { }; <ins> pynotifier = callPackage ../development/python-modules/pynotifier { }; </ins> pynuki = callPackage ../development/python-modules/pynuki { }; pynut2 = callPackage ../development/python-modules/pynut2 { };

Discussion:
Project description Python3 module for sending notifications. Metadata homepage URL: source URL: license: mit platforms: unix, linux, darwin, ...
Check out , it helps with automating the packaging process of many packages.
please test
Change:
extraInstallCommands = '' ln -s $out/bin/${name} $out/bin/${pname} <ins> source "${makeWrapper}/nix-support/setup-hook" wrapProgram $out/bin/${pname}  --add-flags "''${NIXOS_OZONE_WL:+''${WAYLAND_DISPLAY:+--enable-features=UseOzonePlatform --ozone-platform=wayland}}" </ins> install -m 444 -D ${appimageContents}/${pname}.desktop $out/share/applications/${pname}.desktop install -m 444 -D ${appimageContents}/${pname}.png  $out/share/icons/hicolor/512x512/apps/${pname}.png substituteInPlace $out/share/applications/${pname}.desktop  --replace 'Exec=AppRun' 'Exec=${pname}' ''; meta = with lib; {

Discussion:
A few electron applications do not use environment variable to change settings. This causes a black screen when using these packages on wayland. Packages I have found not to work: postman beekeeper-studio This was made known to me by on Discord. Steps to reproduce the behavior: Black screen. ! ! A temporary work around is to run the application with the flag. I will work on this myself. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
If any other packages are exhibiting this behavior please let me know on this issue.
Package also seems to not respect the env
Can confirm, I'll create a new pr.
Sorry for taking so long, stuff happened
Ferdium also does not respect the env (and I assume Ferdi and Franz by looking at their sources).
For some reason the following is not working: But this is: I do have both NIXOSOZONEWL and WAYLANDDISPLAY set.
Change:
Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls <del> Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions </del> <ins> Reviewing guidelines: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#reviewing-contributions </ins> --> ---

Discussion:
the PR template points to instead of Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I kindly ask you to just create the PR the next time with this really trivial change instead of creating an issue.
it's only trivial if you have experience with how github works. i had no idea the template was controlled by a file within the repo and not some option in the settings.
Change:
<ins> { lib , buildPythonPackage , pythonOlder , fetchFromGitHub , black , jinja2 , poetry-core , round , graphviz , inkscape , imagemagick , pytestCheckHook }: buildPythonPackage rec { pname = "diagrams"; version = "0.19.1"; format = "pyproject"; disabled = pythonOlder "3.6"; src = fetchFromGitHub { owner = "mingrammer"; repo = pname; rev = "v${version}"; sha256 = "0qvk0cp3026n5jmwp9z7m70b6pws0h6a7slxr23glg18baxr44d4"; }; preConfigure = '' patchShebangs autogen.sh ./autogen.sh ''; patches = [ ./build_poetry.patch ]; checkInputs = [ pytestCheckHook ]; # Despite living in 'tool.poetry.dependencies', # these are only used at build time to process the image resource files nativeBuildInputs = [ black inkscape imagemagick jinja2 poetry-core round ]; propagatedBuildInputs = [ graphviz ]; meta = with lib; { description = "Diagram as Code"; homepage    = "https://diagrams.mingrammer.com/"; license     = licenses.mit; maintainers =  with maintainers; [ addict3d ]; }; } </ins>

Discussion:
Project description Generate architecture diagrams with python code. Allows for rapid iteration. Metadata homepage URL: source URL: license: mit platforms: linux, darwin This library requires graphviz (both native and the python library).
Change:
assertions = [ { assertion = !config.services.xserver.libinput.enable; <del> message = "cmt and libinput are incompatible, you cannot enable both (in services.xserver)."; </del> <ins> message = '' cmt and libinput are incompatible, meaning you cannot enable them both. To use cmt you need to disable libinput with `services.xserver.libinput.enable = false` If you haven't enabled it in configuration.nix, it's enabled by default on a different xserver module. ''; </ins> } ]; };

Discussion:
Describe the bug In , if you enable both xserver.services.desktopManager.plasma5 and , assertion fails. Failed assertions: cmt and libinput are incompatible, you cannot enable both (in services.xserver). To Reproduce Steps to reproduce the behavior: both and Expected behavior Failed assertion should happen Additional context Build with works fine. Metadata Maintainer information: kcalvinalvin a list of nixpkgs attributes affected by the problem a list of nixos modules affected by the problem
Found the culprit. Can we disable by default so that users can choose? The default generated has the option by default so I don't see the reason why it needs to also be defaulted in