jiebi/CodeConvo huggingface dataset:
Change:
in { description = "WPA Supplicant"; <del> after = [ "network.target" ] ++ lib.concatMap deviceUnit ifaces; </del> <ins> after = lib.concatMap deviceUnit ifaces; before = [ "network.target" ]; wants = [ "network.target" ]; </ins> requires = lib.concatMap deviceUnit ifaces; <del> wantedBy = [ "network-online.target" ]; </del> <ins> wantedBy = [ "multi-user.target" ]; </ins> path = [ pkgs.wpa_supplicant ];

Discussion:
I just switched from a 16.09 system onto a build from master. After rebooting, does not connect me to my WiFi. There does not even seem to be an attempt to start it. This is output from 16.09: Note that restarting the service will connect me to my WiFi: - RebootSystem: (Gorilla) Nix version: nix-env (Nix) 1.11.4 Nixpkgs version: "17.03pre93234."
Useful info from the duplicate issue:
it seems like you changed some related stuff recently, e.g. in . Any ideas what's wrong?
As stated in another issue on misbehavior is wrong in both modules. Also I think that s fix is not needed. Here's an untested patch Can someone who uses one of the broken modules please test if this fixes the issue (even better if both modules are tested)? I'm a bit reluctant on filing a PR blindly CC
Looks better: BTW, I was unable to copy-and-apply the patch and had to overwrite it by hand. For other testers:
I'm not on master, but FWIW is working for me fine (and wasn't before my patch, as unneeded as I agree it should be)
Oh of course the fix is not needed for since the devices take care of pulling the service in.. Maybe a bit hacky :seenoevil: But if it works. Maybe someday someone unifies both modules and removes the hacks :pray:
Could you wrap this into a proper PR?
Change:
<del> { lib, libgpiod, buildPythonPackage, fetchFromGitHub, }: buildPythonPackage rec { pname = "rpi-gpio2"; version = "0.4.0"; format = "setuptools"; # PyPi source does not work for some reason src = fetchFromGitHub { owner = "underground-software"; repo = "RPi.GPIO2"; rev = "refs/tags/v${version}"; hash = "sha256-CNnej67yTh3C8n4cCA7NW97rlfIDrrlepRNDkv+BUeY="; }; propagatedBuildInputs = [ libgpiod ]; # Disable checks because they need to run on the specific platform doCheck = false; meta = with lib; { homepage = "https://github.com/underground-software/RPi.GPIO2"; description = '' Compatibility layer between RPi.GPIO syntax and libgpiod semantics ''; license = licenses.gpl3Plus; maintainers = with maintainers; [ onny ]; }; } </del>

Discussion:
The version of rpi-gpio2 on nixos-unstable (as of ) appears to be incompatible with the version of gpiod at the same point Load the module successfully /cc
I wonder if we should keep/re-introduce a gpiod 1.x to nixpkgs until rpi-gpio2 supports gpiod 2.x?
I have since updated the component I was using rpi-gpio2 with to use libgpiod directly (). Should we mark this component broken in nixpkgs, or perhaps just remove it entirely? It doesn't appear to be used anywhere within nixpkgs. /cc
I got this error today as well, so this issue is still relevant. What is the simplest way to toggle a GPIO pin on NixOS as of today, then?
But I guess I could attempt the trivial fix to change out to in the package definition. That should be the correct fix right?
Change:
./services/monitoring/telegraf.nix ./services/monitoring/thanos.nix ./services/monitoring/tuptime.nix <ins> ./services/monitoring/unifi-poller.nix </ins> ./services/monitoring/ups.nix ./services/monitoring/uptime.nix ./services/monitoring/vnstat.nix

Discussion:
Project description Collect ALL UniFi Controller, Site, Device & Client Data Nixpkg currently has which is not developed anymore. Corresponding NixOS module may have to be updated. Metadata homepage URL: source URL: license: MIT platforms: unix, linux, darwin
Change:
<del> https://gitlab.com/federicomenaquintero/bzip2/commit/74de1e2e6ffc9d diff --git a/decompress.c b/decompress.c --- a/decompress.c +++ b/decompress.c @@ -287,7 +287,7 @@ GET_BITS(BZ_X_SELECTOR_1, nGroups, 3); if (nGroups < 2 || nGroups > 6) RETURN(BZ_DATA_ERROR); GET_BITS(BZ_X_SELECTOR_2, nSelectors, 15); -      if (nSelectors < 1) RETURN(BZ_DATA_ERROR); +      if (nSelectors < 1 || nSelectors > BZ_MAX_SELECTORS) RETURN(BZ_DATA_ERROR); for (i = 0; i < nSelectors; i++) { j = 0; while (True) { </del>

Discussion:
The package has a new maintainer and upstream:
Looks like they're up to 1.0.8 now, FWIW:
ping What's up with the "libtoolized" SUSE patch? AFAICT all it does it produce a useless file. Both the and the build without it; I rebuilt it with the stock 1.0.8 tarball and and shared-object Makefile and it seems to be fine. Hardly any packages even depend on anyway; mentions it in a weird , but that seems to break things rather than fix them, so I can't really test anything. The other one is which explicitly references for some insane reason (edit: I guess the is the wrong way round). It's dynamically loaded though, and I don't care enough to try and find what feature uses it. Perl also mentions . Not sure what to make of that.
The patch was useful before the recent maintenance pick-up upstream. I don't expect it will be useful anymore.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
.
I marked this as stale due to inactivity. &rarr;
There exist bzip2 archives in the wild which cannot be extracted by the 1.0.6 that's in nixpkgs due to the fix for CVE-2019-. It takes some gymnastics to use them in derivations, etc. because bzip2 is such a core package. It would be nice to be able to upgrade to 1.0.8, which can handle these files, or move to the 1.1 series as default.
What mentions is still an issue. I mentioned that just now on the closed PR to merge 1.0.8:
Fixed by
Change:
<del> { lib, stdenv, fetchgit, autoreconfHook, pkg-config, gtk3, openbox, imlib2, libxml2, libstartup_notification, makeWrapper, libSM }: </del> <ins> { lib , stdenv , fetchgit , autoreconfHook , pkg-config , wrapGAppsHook , gtk3 , imlib2 , libSM , libstartup_notification , libxml2 , openbox }: </ins> stdenv.mkDerivation rec { pname = "obconf";

Discussion:
Trying to run and interacting with the GUI in any meaningful matter results in this error: Steps to reproduce the behavior: from the terminal press or . <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
It seems I cannot add you as reviewer, but could you take a look at the fix in ?
I sadly cannot test it right now. The earliest is start of October.
Change:
runHook postInstall ''; <del> # Auto strip cannot detect files missing extension. fixupPhase = '' </del> <ins> # Strip failed on darwin: strip: error: symbols referenced by indirect symbol table entries that can't be stripped fixupPhase = lib.optionalString stdenv.isLinux '' </ins> runHook preFixup <del> strip -s $out/parser </del> <ins> $STRIP $out/parser </ins> runHook postFixup ''; }

Discussion:
Building tree-sitter grammars on MacOS results in a fatal error with the post-installation fixup stage due to differences in how is invoked on MacOS. The error reported is: Steps to reproduce the behavior: or with any other tree-sitter grammar. the fatal error in the post-installation fixup phase where it reports that no files are specified for . The grammar should build and execute the fixup phase without errors. This error does not occur on non-MacOS platforms. I reproduced the error on MacOS 12.0.1. I suspect this error was introduced with this commit but I'm not 100% sure.
Some discussion:
I can also replicate this with on macOS 12.0.1.
Change:
options = { services.nfs = { <ins> idmapd.settings = mkOption { type = format.type; default = {}; description = '' libnfsidmap configuration. Refer to <link xlink:href="https://linux.die.net/man/5/idmapd.conf"/> for details. ''; example = literalExample '' { Translation = { GSS-Methods = "static,nsswitch"; }; Static = { "root/hostname.domain.com@REALM.COM" = "root"; }; } ''; }; </ins> extraConfig = mkOption { type = types.lines; default = "";

Discussion:
If you want root access to an NFS share secured with Kerberos, you need to modify the default . Currently, I override the source, because NixOS has no options to modify : The text is mostly copied from the default NixOS . The only changes are This solution is brittle, and requires manual intervention if the default ever changes. I'm not sure exactly what the NixOS options should look like, but there should be mechanisms to modify in NixOS. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
what about an option like so you can easily override/append values as you see fit?
That looks great. I'm a big fan of RFC 42 :) Just one question though. Can you remove an option, such as ?
Good question. can we bug you for some advice on how you can remove values from a option?
There's nothing builtin for that. The best that can be done is to just filter out values during string generation. Though in INI's case, is also a valid value in INI files, so that might not be a great idea. There is that adds a way to "unset" values, though I haven't looked into it much.
Thanks for mentioning without the ability to remove values would this not work?
I did a double-check on , and it looks like and are actually separate, but related. defaults to the value of . Also, the default value of is already , so removing it in my configuration had no effect. On that note, we may consider removing , as that is already the default. Regardless, your RFC 42 solution should work, even without the ability to remove values.
are you interested in opening a PR? Feel free to use the branch I posted.
I can open a pull request. Just one question: is there a reason the option and variables are called instead of ?
Typo
pull request is up. I fixed the typo and a syntax error.
Change:
# 16.x    LTS        2018-10-09  2022-10-09  2023-10-09 # 17.x    Standard   2019-10-28  2020-10-28  2021-10-28 # 18.x    LTS        2020-10-20  2024-10-20  2025-10-20 <del> asterisk-lts = asterisk_18; asterisk-stable = asterisk_18; asterisk = asterisk_18; asterisk_13 = common { version = "13.38.2"; sha256 = "1v7wgsa9vf7qycg3xpvmn2bkandkfh3x15pr8ylg0w0gvfkkf5b9"; externals = { "externals_cache/pjproject-2.10.tar.bz2" = pjproject_2_10; "addons/mp3" = mp3-202; }; }; asterisk_16 = common { version = "16.17.0"; sha256 = "1bzlsk9k735qf8a693b6sa548my7m9ahavmdicwmc14px70wrvnw"; externals = { "externals_cache/pjproject-2.10.tar.bz2" = pjproject_2_10; "addons/mp3" = mp3-202; }; }; asterisk_17 = common { version = "17.9.3"; sha256 = "0nhk0izrxx24pz806fwnhidjmciwrkcrsvxvhrdvibiqyvfk8yk7"; externals = { "externals_cache/pjproject-2.10.tar.bz2" = pjproject_2_10; "addons/mp3" = mp3-202; }; }; </del> <ins> asterisk-lts = versions.asterisk_18; asterisk-stable = versions.asterisk_18; asterisk = versions.asterisk_18; </ins> <del> asterisk_18 = common { version = "18.3.0"; sha256 = "1xb953i9ay82vcdv8izi5dd5xnspcsvg10ajiyph377jw2xnd5fb"; externals = { "externals_cache/pjproject-2.10.tar.bz2" = pjproject_2_10; "addons/mp3" = mp3-202; }; }; } </del> <ins> } // versions </ins>

Discussion:
, CVSSv3=7.5 (nixos-20.09, nixos-unstable) Scanned versions: nixos-20.09: ; nixos-unstable: . Cc Cc Cc
Change:
assert args ? localSystem -> !(args ? system || args ? platform); import ./. (builtins.removeAttrs args [ "system" "platform" ] // { <del> inherit overlays crossSystem crossOverlays; config = defaultConfig // config; </del> <ins> inherit config overlays crossSystem crossOverlays; </ins> # Fallback: Assume we are building packages on the current (build, in GNU # Autotools parlance) system. localSystem = if builtins.isString localSystem then localSystem

Discussion:
Describe the bug Unable to evaluate due to bug To Reproduce Expected behavior does a nix-review Additional context Add any other context about the problem here. Metadata
Change:
you have scattered around your hard drive can be conveniently placed into a Cherrytree document where you can easily find it. ''; <del> homepage = "http://www.giuspen.com/cherrytree"; license = licenses.gpl3; </del> <ins> homepage = "https://www.giuspen.com/cherrytree"; changelog = "https://raw.githubusercontent.com/giuspen/cherrytree/${version}/changelog.txt"; license = licenses.gpl3Plus; </ins> maintainers = with maintainers; [ ]; }; }

Discussion:
Project description CherryTree by Giuspen, currently, we are using version 0.39.4, meanwhile the latest application is on 0.99.37. There's a weird jump of version from 0.39.4 to 0.99.13. I don't know why this happens. Metadata homepage URL: source URL: license: GPL3 + platforms: Linux
Package request is the wrong issue type for this, Out-of-date package report would've been better. ! The package is sadly orphaned so there's no maintainer to ping for this.
Change:
}; }; <ins> qtDeps = [ qtbase qtdeclarative qtlocation qtquickcontrols qtquickcontrols2 qtscript qtwebchannel qtwebengine qtimageformats qtsvg qttools qtwayland ]; qtEnv = env "zoom-us-qt-${qtbase.version}" qtDeps; </ins> in stdenv.mkDerivation { name = "zoom-us-${version}";

Discussion:
Zoom GUI is not shown on current master () This started to happen after package refactoring (, , ), and not due to package upgrade (I've checked that). I've documented some findings already ping and other Zoom users. Am I alone with this issue? At this moment no GUI (no greeting window) is shown. system: host os: multi-user?: sandbox: version: channels(root): channels(danbst): nixpkgs:
I at least cannot reproduce this with on nixpkgs
I installed to a profile using your reproduction steps, and it works fine here. What is in your in your shell? At least here it's:
I was able to reproduce this via: So there's some piece of the environment missing in the package.
This also reproduces the issue: Currently investigating what needs on the $PATH.
Thanks for your efforts, but when writing a command can you (and everyone else) please be complete? I had time to quickly confirm what you wanted to say, but here I am telling you that it is not a valid test case. I wrote an example of a complete command in closed thread with zoom in the title started by myself, so it's not like I don't practice this myself.
Sorry about that. As the package is unfree, you'll need in or in your environment. So a complete standalone test case would be:
does this reproduce issue too? I've checked that commit (last revision of old zoom-us expression) launches fine for me with this bash command.
It sounds like it was caused by using autoPatchelf? It could be that there is some incompatibility between what zoom-us is built with and what we have locally. Maybe we should just revert that part (but leave the version updates). I would much prefer to use Nixpkgs Qt here but there is a lot of unknown in how zoom-us is built. It might just be safest to revert to the old expression.
Turns out the issue was missing QML2 imports. This was discovered by comparing: to and looking for libraries loaded by the latter but not the former. One fix was to add a environment variable to the wrapper, but I found it simpler to re-use to build an environment with all the Qt dependencies symlinked in place and using its . The package should be easier to maintain as a result since you don't have to know what feature each qt5 package is meant to provide.
Change:
<ins> { lib, stdenv, fetchgit, build2, }: stdenv.mkDerivation (finalAttrs: { pname = "libstudxml"; version = "1.1.0-b.10+2"; src = fetchgit { url = "https://git.codesynthesis.com/libstudxml/libstudxml.git"; rev = "v${finalAttrs.version}"; hash = "sha256-OsjMhQ3u/wLhOay7qg9sQMEhnAOdrO30dsKQ8aDWUOo="; }; outputs = [ "out" "dev" "doc" ]; nativeBuildInputs = [ build2 ]; # lib files are not marked as executable by default postInstall = '' chmod +x "$out"/lib/* ''; meta = { description = "A streaming XML pull parser and streaming XML serializer implementation for modern, standard C++"; homepage = "https://www.codesynthesis.com/projects/libstudxml/"; license = lib.licenses.mit; maintainers = with lib.maintainers; [ tomasajt ]; platforms = lib.platforms.all; }; }) </ins>

Discussion:
libstudxml is a streaming XML pull parser and streaming XML serializer implementation for modern, standard C++. It has an API that we believe should have already been in Boost or even in the C++ standard library.
Change:
{ lib, stdenv, fetchFromGitHub , pkg-config, cmake, ninja, yasm <del> , libjpeg, openssl, libopus, ffmpeg, alsa-lib, libpulseaudio, protobuf </del> <ins> , libjpeg, openssl_1_1, libopus, ffmpeg, alsa-lib, libpulseaudio, protobuf </ins> , openh264, usrsctp, libevent, libvpx , libX11, libXtst, libXcomposite, libXdamage, libXext, libXrender, libXrandr, libXi , glib, abseil-cpp, pcre, util-linuxMinimal, libselinux, libsepol, pipewire

Discussion:
On current , (4.2.4) group voice chat will be stuck on "connecting" forever, while private group voice works. This issue exists when connecting from different countries, using different account, with or without proxy, so it seems not really a "connection issue". a voice chat in a private group. it stuck on "connecting" phase forever. Successfully starts or joins a voice chat. chat and live stream are broken. (one to one) voice chat works without issues. 's version of telegram works. (Its font is broken though) Please run and paste the result.
Change:
sha256 = "TRmul3t//izJRdViTvxFz29JZeGYsWc7WsJjagQ35nw="; }; <ins> patches = [ ./fix-restart.patch # https://github.com/NixOS/nixpkgs/issues/139568 ]; </ins> postPatch = '' substituteInPlace libqtile/pangocffi.py  --replace libgobject-2.0.so.0 ${glib.out}/lib/libgobject-2.0.so.0 

Discussion:
In , the patch was removed. Without this patch, trying to restart qtile just kills it and goes to the display manager, closing all of your apps. Steps to reproduce the behavior: into qtile any key combination to to press this combination Qtile restarts without closing any apps Qtile just quits and goes to the DM Maintainer information:
This patch can fix the issue
I think most of this can be done in the wrapper. I was hoping that buildenv would solve the issue as the python interpreter would have all of the dependencies it would need.
I dug a little deeper and found the cause to be the following: Qtile restarts with sys.executable, which leads to the following full command on my machine (ignore the package name, not important here): This results in a syntax error So it's trying to execute a bash script through python, which leads to a syntax error. I see some related issues on nixpkgs, , Do you have any idea how to continue? Edit: To add, we could re-introduce a patch like this (this is for current qtile master) But the whole idea was that we wanted to get rid of the patches :/
I'm okay with doing minor patches like that. It was just before were were modifying the entry point significantly. But I'm also not a qtile user, was just trying to get qtile to a more recent version. If you want to create a PR, I'll be happy to review it.
Change:
<ins> { config , cudaPackages , fetchFromGitHub , lib , mpiSupport ? false , mpi , stdenv , which }: cudaPackages.backendStdenv.mkDerivation (finalAttrs: { pname = "nccl-tests"; version = "2.13.6"; src = fetchFromGitHub { owner = "NVIDIA"; repo = finalAttrs.pname; rev = "v${finalAttrs.version}"; hash = "sha256-3gSBQ0g6mnQ/MFXGflE+BqqrIUoiBgp8+fWRQOvLVkw="; }; strictDeps = true; nativeBuildInputs = [ cudaPackages.cuda_nvcc which ]; buildInputs = [ cudaPackages.cuda_cudart cudaPackages.nccl ] ++ lib.optional mpiSupport mpi; makeFlags = [ "CUDA_HOME=${cudaPackages.cuda_nvcc}" "NCCL_HOME=${cudaPackages.nccl}" ] ++ lib.optionals mpiSupport [ "MPI=1" ]; enableParallelBuilding = true; installPhase = '' mkdir -p $out/bin cp -r build/* $out/bin/ ''; meta = with lib; { description = "Tests to check both the performance and the correctness of NVIDIA NCCL operations"; homepage = "https://github.com/NVIDIA/nccl-tests"; platforms = [ "x86_64-linux" ]; license = licenses.bsd3; broken = !config.cudaSupport || (mpiSupport && mpi == null); maintainers = with maintainers; [ jmillerpdt ]; }; }) </ins>

Discussion:
Project description tests the correctness and performance of NVIDIA's NCCL library: Given the upcoming work surrounding NCCL (and CUDA redistributable as a whole), it's important that we have utilities to ensure that changes don't introduce breakages. Metadata homepage URL: URL: bsd3 platforms: linux
Change:
<del> { lib , rustPlatform , fetchFromGitHub }: rustPlatform.buildRustPackage rec { pname = "cringify"; version = "0.1.1"; src = fetchFromGitHub { owner = "sansyrox"; repo = "cringify"; rev = "dd753818f8dd4b343be9370d2c29a6be070ad791"; hash = "sha256-6hSgOk9DzDfGtZX1vt6AQsKSLdPdqy2Mz3UtK6d2AuA="; }; cargoHash = "sha256-w6lqPyUCaXZBQ1EmMyj0sVnEHugMD6JugIIK0rEa19Y="; postPatch = '' # Upstream forgot to update the version value substituteInPlace src/main.rs --replace '0.1.0' ${version} ''; # No tests are present in the repository doCheck = false; meta = { description = "Annoy your friends with the cringified text"; homepage = "https://github.com/sansyrox/cringify"; license = lib.licenses.mit; mainProgram = "cringify"; maintainers = with lib.maintainers; [ tomasajt ]; }; } </del>

Discussion:
Package name: cringify Latest released version: 0.2.0 <!-- Search your package here: --- Current version on the unstable channel: 0.1.1 Current version on the stable/release channel: 0.1.1 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers Note for maintainers: Please tag this issue in your PR. NOTE: it seems that there are no tags on the upstream GitHub repository but it is released on with a new version 0.2.0
Change:
<ins> { cabal, blazeHtml, deepseq, Elm, filepath, happstackServer, HTTP , mtl, parsec, transformers }: cabal.mkDerivation (self: { pname = "elm-server"; version = "0.8"; sha256 = "0mnxayfg54f5mr27sd1zw3xrdijppgvrz2yzzmhp07qc1jiyfald"; isLibrary = false; isExecutable = true; buildDepends = [ blazeHtml deepseq Elm filepath happstackServer HTTP mtl parsec transformers ]; meta = { homepage = "http://elm-lang.org"; description = "The Elm language server"; license = self.stdenv.lib.licenses.bsd3; platforms = self.ghc.meta.platforms; }; }) </ins>

Discussion:
Kdenlive build fails because CMake can't find QtConcurrent. Error: It appears to have been broken by some changes made to qtbase but I am not familiar enough with it to know what specifically. Changes between success and first failure: Latest Hydra failure: cc Attempt to install Kdenlive System: NixOS: 17.09pre107928. (Hummingbird) Nix version: nix-env (Nix) 1.11.9 Nixpkgs version: "17.09pre107928." Sandboxing enabled: build-use-sandbox = true
You need to modify the to We should send a patch upstream. This must be a required change since QT5.8.
Fixed by: