jiebi/CodeConvo huggingface dataset:
Change:
description = lib.mdDoc '' User under which mastodon runs. If it is set to "mastodon", that user will be created, otherwise it should be set to the <del> name of a user created elsewhere.  In both cases, `mastodon` and a package containing only the shell script `mastodon-env` will be added to the user's package set. To run a command from `mastodon` such as `tootctl` with the environment configured by this module use `mastodon-env`, as in: `mastodon-env tootctl accounts create newuser --email newuser@example.com` </del> <ins> name of a user created elsewhere. In both cases, the `mastodon` package will be added to the user's package set and a tootctl wrapper to system packages that switches to the configured account and load the right environment. </ins> ''; type = lib.types.str; default = "mastodon";

Discussion:
When one installs mastodon via the following minimal config: Then there is no obvious way to run tootctl. or any other login user doesn't have the executable by default, nor can this be enabled in an obvious way. is not a login user, so can't (and shouldn't?) log in as and execute . Steps to reproduce the behavior: mastodon as per minimal config above ... nope. ... nope. ... nope. ... nope. Any of: a setting such that is installed for that user an explanation in the docs what to do as a login user (probably bad idea?) Workaround: CC
I think upstream intends only to be run by the mastodon user. My way for doing that is just running and continuing in that shell. The reason why doesn't work is probably because sudo inherits PATH from the user you are coming from? I'm not sure I understand the concept of a login user enough. How would mastodon become a login user and why would that be a bad idea?
In the mastodon docs, it is described the following way: But is not possible, it gives the error They do recommend (which is what I meant by it shouldn't be a login user), but still they seem to do something different than nixos does. Maybe that's fine, and it would be helpful to document this somewhere, so people don't spend a long time trying to find it out.
This is default for almost all service users because they have no login shell. Use ` This is wrong. Sudo resets all path like variables like PATH and PYTHON PATH. Also inheriting needs to be turned on explicitly and PATH mist always ve inherited explicitly. Other services like nextcloud include a wrapper that sudos to the right user. This should be for mastodon, too.
Sounds like a good solution. Then we could make the command globally available.
That isn't? I would have expected that it is very similar to nextcloud-occ.
No currently it is only available to the mastodon user, so tootctl never gets called as the wrong user.
There is a hack in the nixos nextcloud-occ script that automatically sudoes if called by a different user. This could be adapted to tootctl I think.
Yes, this should be adapted. Changing the mastodon to a login user would not be the correct fix.
Change:
let workDir = if cfg.workDir == null then runtimeDir else cfg.workDir; <del> package = cfg.package.override { inherit (cfg) nodeRuntimes; }; </del> <ins> # Support old github-runner versions which don't have the `nodeRuntimes` arg yet. package = cfg.package.override (old: optionalAttrs (hasAttr "nodeRuntimes" old) { inherit (cfg) nodeRuntimes; }); </ins> in { description = "GitHub Actions runner";

Discussion:
The commit at a new argument to the nixos github-runner service. It passes this argument to the (, line 25). However, this assumes that has a argument, and older versions don't, therefore breaking backwards compatibility. For example, you can't run this version of the service, with from "github:NixOS/nixpkgs/", because that version of github-runner doesn't take the argument. With Github Enterprise (on prem Github), the Github Runner version has to match the version of Github Enterprise, so this change breaks the ability to use the NixOS service. I think it's the case that because the variable is defined in a let statement on line 25 of , I can't modify or override the behaviour as a consumer, so the service has to be modified. In it looks like on the gets a default value anyway, so I think the correct behaviour would be for to only be passed to the override function of if is set as a configuration option in the service. Overlay your package with an older version, e.g. github:NixOS/nixpkgs/ - these two files are enough to reproduce. : : Try and build a VM image with Expect file in the directory.
Change:
}; cmp-pandoc-nvim = super.cmp-pandoc-nvim.overrideAttrs { <del> dependencies = with self; [ nvim-cmp pandoc plenary-nvim ]; </del> <ins> dependencies = with self; [ nvim-cmp plenary-nvim ]; </ins> }; cmp-rg = super.cmp-rg.overrideAttrs { <del> dependencies = with self; [ nvim-cmp ripgrep ]; </del> <ins> dependencies = with self; [ nvim-cmp ]; </ins> }; cmp-snippy = super.cmp-snippy.overrideAttrs {

Discussion:
Many cmp-* plugins have dependencies like curl, fish, tmux etc. But those are not plugins. In result those programs are to nvim runtimepath. Looks like it was introduced by Steps to reproduce the behavior: package e.g. -pack-dir now contains curl and git directories. Binaries should not be linked to runtimepath. Paths to binaries should be replaced in plugin source code or to nvim's PATH (does it work with propagatedBuildInputs?). If applicable, add screenshots to help explain your problem. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Change:
${dejavu_fonts}/share/fonts/truetype/DejaVuSans.ttf  $out/share/fonts/truetype/dejavu/DejaVuSans.ttf mkdir -p $out/share/doc/freenukum <del> install -Dm644 README.md CHANGELOG.md COPYING $out/share/doc/freenukum/ </del> <ins> install -Dm644 README.md CHANGELOG.md $out/share/doc/freenukum/ </ins> installManPage doc/freenukum.6 install -Dm644 "${desktopItem}/share/applications/"* -t $out/share/applications/ ''; meta = with lib; { description = "Clone of the original Duke Nukum 1 Jump'n Run game"; <ins> homepage = "https://salsa.debian.org/silwol/freenukum"; changelog = "https://salsa.debian.org/silwol/freenukum/-/blob/v${version}/CHANGELOG.md"; </ins> license = licenses.agpl3Plus; maintainers = with maintainers; [ _0x4A6F ]; broken = stdenv.isDarwin;

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: freenukum <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 0.3.5 desired version: <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR. Homepage: Project's URL has to:
Thanks a lot, (all of you).
Change:
pyserial setuptools wxPython_4_0 <del> ]; </del> <ins> ] ++ lib.optionals stdenv.isDarwin [ billiard gnureadline ]; </ins> # No tests doCheck = false;

Discussion:
Describe the bug wxPython40, , does not build there likely because it uses wxGTK rather than this prevents kicad from being built on darwin To Reproduce Steps to reproduce the behavior: darwin, Expected behavior wxPython40 to build on darwin and be usable by kicad there Additional context i maintain the kicad package and Notify maintainers while there are no listed maintainers for this package it was initially contributed by (if you already investigated after the kicad PR ping, nothing relevant changed since) and has a fair amount of contributions by Maintainer information:
Hi I don't have/use mac but happy to answer any wxPython questions as I can
I'm experiencing the same issue with Linux, using .
likely a different issue. Stacktrace? What nixpkgs version / commit?
The as of this writing. Here's the output I'm seeing. <details<summarybuild log</summary</detailsIt looks like pkg-config is giving an old version of GTK+?
please use your failure seems the same as which i closed because it's fixed in the branch by and i can confirm at least starts building there (it's still going...) i'm not sure when this fix will get to ...
nice! didn't know about the details tag. Ok yeah that looks like my issue, thanks for pointing me in that direction.
I can reproduce this on 10.14.6. My best take so far was to use and adapt other Darwin requirements. <details<summarydiff against master</summary</detailsUnfortunately it does not build with the same errors as for the .
Bumped to 3.0.5.1, to its , and it builds! was set, but no dependency specified. That's what caused the missing symbols. <details<summaryworking diff</summary</detailsI'm not even sure why this works at all. claims they build from a submodule, but obviously in this setup we take whatever is supplied through . To be pedantic, 4.0.7 is supposed use some specific instead of a release, as you can . That commit is after* 3.0.4 and shortly before 3.0.5. I only skimmed the , but it sounds and looks like backwards-compatible bug fixes. Opinions on how to proceed?

If we follow upstream and choose the intermediate revision, what to specify as the package version?
i've kinda given up on stuff, at least until the next release which i hope will either be built based on a release or be compatible with the latest release (i have no reason to believe this would be the case though) if you have a diff that fixes a package, i recommend you make a PR 4.0.7 seems to work with the 3.0.4, it seems reasonable to assume the same would be true for 3.0.4
Change:
fullName = "Unspecified free software license"; }; <ins> fsl11Mit = { fullName = "Functional Source License, Version 1.1, MIT Future License"; url = "https://fsl.software/FSL-1.1-MIT.template.md"; free = false; redistributable = true; }; </ins> ftl = { spdxId = "FTL"; fullName = "Freetype Project License";

Discussion:
Project description GitButler is a git client that lets you work on multiple branches at the same time. It allows you to quickly organize file changes into separate branches while still having them applied to your working directory. You can then push branches individually to your remote, or directly create pull requests. In a nutshell, it's a more flexible version of git add -p and git rebase -i, allowing you to efficiently multitask across branches. Metadata homepage URL: source URL: license: FSL-1.0-MIT platforms: linux, darwin
is also a Tauri app so the packaging is likely similar:
I'll work on this over the weekend, unless anyone has already started?
I don't think building from source is gonna be easy, precisely as we don't have done yet and this project uses pnpm workspaces. You can however wrap the Appimage though.
I've made Still draft. It does start the application, but clicking buttons results in problems on my system :sweatsmile: For a quick run: Update: it's now mostly working. The signin/login still gives an error and it's still unclear why. Also, I don't think I'll use gitbutler regularly atm, so it might be best if someone else wants to volunteer as maintainer of this package :sweatsmile:
I have made a PR that builds from source and has no issues with logging in (that just needed ).
Is this request open to contributions?
Would be best to wait for a while, if that PR goes abandoned, you can ask the author if it's okay to open another
Change:
"${pkgs.curl}/bin/curl --fail http://localhost/searx >&2" ) fancy.succeed( <del> "${pkgs.curl}/bin/curl --fail http://localhost/searx/static/themes/oscar/js/bootstrap.min.js >&2" </del> <ins> "${pkgs.curl}/bin/curl --fail http://localhost/searx/static/themes/simple/js/leaflet.js >&2" </ins> ) ''; })

Discussion:
The searx service is trying to start and it fails because the actual name is of the executable has been changed to Steps to reproduce the behavior: ... use newest unstable branch ... try to deploy searx service with ... searx service fails to start searx service should start without any issues The default searx package on Nixos is in Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thanks for reporting, I just encountered this bug as well after I updated to the latest unstable branch. I believe that a general migration from to naming needs to be done to avoid these kind of issues in the future.
Change:
--set-rpath "${atomEnv.libPath}"  $out/share/atom/resources/app/apm/bin/node <ins> rm -f $out/share/atom/resources/app/node_modules/dugite/git/bin/git ln -s ${pkgs.git}/bin/git $out/share/atom/resources/app/node_modules/dugite/git/bin/git </ins> find $out/share/atom -name "*.node" -exec patchelf --set-rpath "${atomEnv.libPath}:$out/share/atom" {} ; paxmark m $out/share/atom/atom

Discussion:
Atom editor ships with Git and GitHub integration bundled since version 1.18.0 (). On NixOS it does not work. The errors in the developer's console: Seems like GitHub integration package is shipped with it's own binary and indeed trying to execute it from a shell results in error: I suppose the binary needs to be patched with and I would love to contribute a PR, but frankly I'm a JavaScript monkey and can't figure out where to start, so I'll do the next best thing and file an issue. Install atom editor: Initialize a Git repository: Make some changes and start Atom editor If it's not already opened, open Git panel with Note that tree view shows changes correctly (green file), but the Git panel is empty Open Dev Tools and see red error messages. System: 17.09pre113107. (Hummingbird) Nix version: nix-env (Nix) 1.11.13 Nixpkgs version: 17.09pre113107. Sandboxing enabled: build-use-sandbox = false
Above pull request resolves the issue. I'm not the best at using atom, but I saw a green line next to my changes made, and no errors output to stdout when I opened the git panel.
Maybe replace the binary with a symbolic link to our own git?
How can I test it locally? I suppose I need to clone this report, checkout your PR and use somehow, but how do I point it to use the expression from the PR? I'm a total noob and a monkey when it comes to Nix and NixOS
I ran it using
That works as well and is a cleaner way to handle it in my opinion. I opened a new PR because my last PR I forgot to branch before pushing and it was PR'd to my master branch.
Hi again and thanks for all the help! I'm a little bit embarrassed to ask, but after two days of trying I still can't figure how to install this patched version of Atom using . I have a clone of at . Current contains the patch. If I start as explained by it works - I have an editor with working Git integration: but if I try to install it in my standard env it apparently installs the un-patched version: I have also tried variant with .

Then it compiles and installs version 1.18 (I don't understand where is it coming from). How can I install the version from my cloned repository and - perhaps more importantly - troubleshoot this kind of issues? Is there a way to print a path to expression used by ? Or the expression itself?
With you can use the option to point to a Nix expression, in this case your Nixpkgs repository. The option is not used by because does not use . Instead, it checks by default . It is confusing...
It worked! Thank you For the record and a benefit of posterity, this is the whole command that installs a package from local clone:
Change:
python3Packages.buildPythonApplication rec { pname = "veusz"; <del> version = "3.3.1"; </del> <ins> version = "3.6.2"; </ins> src = python3Packages.fetchPypi { inherit pname version; <del> sha256 = "4ClgYwiU21wHDve2q9cItSAVb9hbR2F+fJc8znGI8OA="; </del> <ins> sha256 = "whcaxF5LMEJNj8NSYeLpnb5uJboRl+vCQ1WxBrJjldE="; </ins> }; <del> nativeBuildInputs = [ wrapQtAppsHook python3Packages.sip_4 ]; </del> <ins> nativeBuildInputs = [ wrapQtAppsHook python3Packages.sip python3Packages.tomli ]; </ins> buildInputs = [ qtbase ];

Discussion:
Steps to reproduce the behavior: Add any other context about the problem here. system: host os: multi-user?: sandbox: version: channels(hervyqa): channels(root): nixpkgs:
issue still exits in unstable channel
Change:
thttpd = callPackage ../servers/http/thttpd { }; <ins> stalwart-mail_0_6 = (stalwart-mail.override { rocksdb_8_11 = rocksdb_8_3; }).overrideAttrs (old: rec { pname = "stalwart-mail_0_6"; version = "0.6.0"; src = fetchFromGitHub { owner = "stalwartlabs"; repo = "mail-server"; rev = "v${version}"; hash = "sha256-OHwUWSUW6ovLQTxnuUrolQGhxbhp4YqKSH+ZTpe2WXc="; fetchSubmodules = true; }; cargoDeps = old.cargoDeps.overrideAttrs (_: { inherit src; name = "${pname}-${version}-vendor.tar.gz"; outputHash = "sha256-mW3OXQj6DcIMO1YlTG3G+a1ORRcuvp5/h7BU+b4QbnE="; }); }); </ins> static-web-server = callPackage ../servers/static-web-server { }; stone = callPackage ../servers/stone { };

Discussion:
The new version of stalwart mail (0.7.0), has changed a lot and the module needs a rewrite for a while now, for example: I have forked nixpkgs, to remove the standard settings, to allow me to make a more complex setting. issues I see. No way to disable the default options, in: . WebUI is not currently supported The package imports the entire . <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
If you want to make a contribution, even a small one, im happy to help you get it merged !
I can take a look, as I have written quite extensive configuration for my Stalwart instance. I can check it out to make it available as a NixOS module
That would be amazing ! There is an open pr from the bot for the 0.7 upgrade, you can take over that one or make the update in a new pr. Thank you !
WIP module. I haven't tested it out yet. I will probably do so this evening:
Not yet entirely fixed, module and test need some work to support = 0.7.0
By the way, since migrating to stalwart = 0.7 requires some manual migration in any case, would it be worth setting the default database type to rocksdb instead of sqlite in the module?
In my opinion yes, for the love of Linux or just make it undefined. Do you have a git repo, where I can track your progress and when I have time, give improvements?
Change:
{ lib , stdenv , fetchFromGitHub <ins> , fetchpatch </ins> , autoPatchelfHook , makeWrapper , buildNpmPackage

Discussion:
Package name: sunshine Latest released version: 0.22.0 <!-- Search your package here: --- Current version on the unstable channel: 0.21.0 Current version on the stable/release channel: 0.21.0 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
patchShebangs build-aux/meson/postinstall.py ''; <del> patches = [ ./extension_dir.patch ]; </del> <ins> patches = [ ./extension_dir.patch # 3.30 now generates it's own thummbnails, # and no longer depends on `gnome-desktop` (substituteAll { src = ./bubblewrap-paths.patch; bubblewrap_bin = "${bubblewrap}/bin/bwrap"; inherit (builtins) storeDir; }) ]; </ins> passthru = { updateScript = gnome3.updateScript {

Discussion:
Thumbnails do not get generated for files. Instead, a 1x1 png file gets written to Here's the relevant terminal output: I'm guessing this is caused by and . Open nautilus in a folder containing images. Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Fixed in
I think the fix wasn't sufficient on 3.30 :/ I'm able to reproduce on master at least. IIRC I only checked the fix worked with 3.28.
It seems that patch may need to be applied directly to Nautilus too as it now seems to bundle that code? -
Change:
"CC=${stdenv.cc.targetPrefix}cc" "STRIP="  # Disable install stripping as it breaks cross-compiling. We strip binaries anyway in fixupPhase. "prefix=${placeholder "out"}" <del> "sysconfdir=${placeholder "out"}/etc" </del> <ins> "sysconfdir=/etc" </ins> "systemdsystemunitdir=${placeholder "out"}/lib/systemd/system" # contrib modules require these "moduledir=${placeholder "out"}/lib/modules"

Discussion:
The system-wide LDAP client configuration in is ignored by Openldap client programs. Steps to reproduce the behavior: settings into via or any other Openldap client Openldap client programs should obey the system-wide configuration file in . strace shows it's reading the example configuration from the package instead: Since commit the openldap package no longer passes to configure, it only passes to make instead. Please run and paste the result.
It seems a bit dodgy, but this might be a solution: plus corresponding changes to all the packages and tests that refer to . I'm just rebuilding a gazillion packages on my system from source, so I can check if that works properly...
you probably meant to ping and instead
Oops, sorry about that. I forgot that the maintainer handles listed in the package do not necessarily correspond to their Github usernames.
I realised that changing is probably unwise. Not only does it break some other packages (like python-ldap) and some Nixos tests, it will also break any users who have configured slapd to refer to the schemas under , as I myself have: And changing is not necessary to fix the bug anyway. It seems that the approach of passing differently in compile and install works. I'll send a PR for it.
Change:
Based on <xref linkend="opt-system.stateVersion" />, existing installations will continue to work. </para> </listitem> <ins> <listitem> <para> The prometheus json exporter is now managed by the prometheus community. Together with additional features some backwards incompatibilities were introduced. Most importantly the exporter no longer accepts a fixed command-line parameter to specify the URL of the endpoint serving JSON. It now expects this URL to be passed as an URL parameter, when scraping the exporter's <literal>/probe</literal> endpoint. In the prometheus scrape configuration the scrape target might look like this: <programlisting> http://some.json-exporter.host:7979/probe?target=https://example.com/some/json/endpoint </programlisting> </para> <para> Existing configuration for the exporter needs to be updated, but can partially be re-used. Documentation is available in the upstream repository and a small example for NixOS is available in the corresponding NixOS test. </para> <para> These changes also affect <xref linkend="opt-services.prometheus.exporters.rspamd.enable" />, which is just a preconfigured instance of the json exporter. </para> <para> For more information, take a look at the <link xlink:href="https://github.com/prometheus-community/json_exporter"> official documentation</link> of the json_exporter. </para> </listitem> </ins> </itemizedlist> </section>

Discussion:
current version: unstable-2017-10-06 desired version: 0.2.0 maintainers:
An option in the service definition to overwrite the package would be nice, too! :smile:
Why is this needed? -options are usually implemented if modifying the package in question with an overlay is a bad idea because it would mean that a lot of leaf-packages would require a rebuild as well. An example for that would be .
Ah, okay.
could you please update this package?
Oh sure, thank you for the ping :)