jiebi/CodeConvo huggingface dataset:
Change:
{ newScope, config, stdenv, fetchurl, makeWrapper <del> , llvmPackages_10, llvmPackages_11, ed, gnugrep, coreutils </del> <ins> , llvmPackages_10, llvmPackages_11, ed, gnugrep, coreutils, xdg_utils </ins> , glib, gtk3, gnome3, gsettings-desktop-schemas, gn, fetchgit , libva ? null , pipewire_0_2

Discussion:
Describe the bug Opening magnet links in Chromium fails and so does opening links in Discord when I'm using Sway. To Reproduce Steps to reproduce the behavior: to piratebay. using a magnet link. Discord. a link. Expected behavior When I use a magnet link to download torrent I expect it to open my torrent client (qbittorrent). In Discord clicking on links should open in Chromium. Screenshots Clicking on the open button doesn't do the thing. Additional context I only tried in Sway among the wayland compositors. X11 is fine. I haven't tried in Gnome wayland. The same might be the case with other electron apps. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Give advice if you know whom I should xdg_utils: Chromium: Discord: Metadata Maintainer information:
Have you tried configuring xdg using ?
Another possible option is that something like isn't set correctly within the sway context, so it doesn't find the correct settings
could you give (doesn't require rebuilding Chromium, only the wrapper) a test without xdg_utils installed globally?
I'm not sure how to do it, although is true by default, xdg tools are not available on PATH when I use sway unlike on for say bspwm.
Setting didn't help.
I'm currently rebuilding Chromium with , how do I avoid the full rebuild?
you can only avoid it if hydra populated the binary cache for you. You most likely CANT avoid it in this situation.
that's gonna take like 6 hours
I haven't had an issue with x11, so i changed your title
Just finished compiling, idd it works. On the other hand is it really a good solution?
FWIW, I use sway and have part of my user's packages and never had any issues with this, magnet links, mailto etc. links work just fine in Firefox, Chromium and everywhere else.
Next time you can try to e.g. cherry-pick the commit onto a channel like nixos-unstable. Should've mentioned that, sorry. In that case my branch was based on master the branch and the build on Hydra was still pending. I don't really see a problem with it.

It is a bit strange/hacky but Chromium depends on these binaries and in such cases we usually prefix accordingly (see for other Nixpkgs examples, usually via ).
All the discussion here seems to be about chromium, was there a fix for discord? I am having the same problem
You can e.g. "fix" it by installing .

Describe the bug "Set browser as default" functionality doesn't work for Firefox and Chromium in Sway. (bspwm and other x11 wms worked) Additional context If I have xdgutils installed globally, it works as expected. Notify maintainers xdgutils & firefox: firefox: Metadata Please run and paste the result.
Chromium seems to be ok now.
Added additional context, which might lead to solving the main issue.
Oh, I forgot that this is also for Firefox.
Change:
<ins> { lib , stdenv , nixosTests , rustPlatform , fetchFromGitHub , Security }: rustPlatform.buildRustPackage rec { pname = "libreddit"; version = "0.10.1"; src = fetchFromGitHub { owner = "spikecodes"; repo = pname; rev = "v${version}"; sha256 = "0f5xla6fgq4l9g95gwwvfxksaxj4zpayrsjacf53akjpxaqvqxdj"; }; cargoSha256 = "039k6kncdgy6q2lbcssj5dm9npk0yss5m081ps4nmdj2vjrkphf0"; buildInputs = lib.optional stdenv.isDarwin Security; cargoPatches = [ # Patch file to add/update Cargo.lock in the source code # https://github.com/spikecodes/libreddit/issues/191 ./add-Cargo.lock.patch ]; passthru.tests = { inherit (nixosTests) libreddit; }; meta = with lib; { description = "Private front-end for Reddit"; homepage = "https://github.com/spikecodes/libreddit"; license = with licenses; [ agpl3Only ]; maintainers = with maintainers; [ fab ]; }; } </ins>

Discussion:
Project description 10 second pitch: Libreddit is a portmanteau of "libre" (meaning freedom) and "Reddit". It is a private front-end like Invidious but for Reddit. Browse the coldest takes of r/unpopularopinion without being tracked. Demo: Metadata homepage URL: source URL: license: agpl3 platforms: unix, linux, darwin, ...
could you please give a try? Thanks
That's just the package, but not a service (like ) right?
Yes, it's only the package for the moment.
There seems to be a bug present in the latest release. I opened a feature request () which could improve the service. Sorry, it will take some time till we can finish this.
Change:
<ins> { stdenv , lib , fetchFromGitHub , pkg-config , meson , ncurses , ninja }: stdenv.mkDerivation rec { pname = "slurm"; version = "0.4.4"; src = fetchFromGitHub { owner = "mattthias"; repo = "slurm"; rev = "upstream/${version}"; hash = "sha256-w77SIXFctMwwNw9cQm0HQaEaMs/5NXQjn1LpvkpCCB8="; }; nativeBuildInputs = [ pkg-config meson ninja ]; buildInputs = [ ncurses ]; meta = with lib; { description = "A generic network load monitor"; homepage = "https://github.com/mattthias/slurm"; license = licenses.gpl2Plus; platforms = with platforms; [ "x86_64-linux" ]; maintainers = with maintainers; [ mikaelfangel ]; mainProgram = "slurm"; }; } </ins>

Discussion:
Project description slurm started as a FreeBSD port of the Linux ppp link monitor called pppstatus by Gabriel Montenegro. Hendrik Scholz ripped off the ppp dependent parts and the email checks to turn in into a generic network load monitor for BSD, Linux, HP-UX and Solaris. Metadata homepage URL: source URL: license: gpl2 platforms: unix, linux
Change:
let cfg = config.programs.mouse-actions; in <del> { options.programs.mouse-actions = { enable = lib.mkEnableOption '' mouse-actions udev rules. This is a prerequisite for using mouse-actions without being root </del> <ins> { options.programs.mouse-actions = { enable = lib.mkEnableOption "" // { description = '' Whether to install and set up mouse-actions and it's udev rules. Note that only users in the "uinput" group will be able to use the package ''; }; package = lib.mkPackageOption pkgs "mouse-actions" { example = "mouse-actions-gui"; }; autorun = lib.mkOption { type = lib.types.bool; default = false; description = '' Whether to start a user service to run mouse-actions on startup. </ins> ''; }; <del> config = lib.mkIf cfg.enable { services.udev.packages = [ pkgs.mouse-actions ]; </del> <ins> }; config = lib.mkIf cfg.enable { environment.systemPackages = [ cfg.package ]; services.udev.packages = [ cfg.package ]; systemd.user.services.mouse-actions =  lib.mkIf cfg.autorun { description = "mouse-actions launcher"; wantedBy = [ "graphical-session.target" ]; bindsTo = [ "graphical-session.target" ]; after = [ "graphical-session.target" ]; environment.PATH = lib.mkForce null; # don't use the default PATH provided by NixOS serviceConfig = { ExecStart = "${lib.getExe cfg.package} start"; PassEnvironment = "PATH"; # inherit PATH from user environment }; </ins> }; <del> } </del> <ins> }; } </ins>

Discussion:
Project description mouse-actions allows to execute some commands from mouse events such as: Clicks / wheel on the side / corners of the screen, Or drawing shapes. Obs: There is the no-gui package request here: This request is for implementing the element so we can configure . Metadata homepage URL: source URL: license: mit, bsd, gpl2+ , ... platforms: unix, linux, darwin, ... Priorities Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I have some experience packaging tauri apps, I'll see what I can do
Change:
See the nixpkgs manual for more details on how to [Submit changes to nixpkgs](https://nixos.org/nixpkgs/manual/#chap-submitting-changes). <ins> ## Writing good commit messages In addition to writing properly formatted commit messages, it's important to include relevant information so other developers can later understand *why* a change was made. While this information usually can be found by digging code, mailing list archives, pull request discussions or upstream changes, it may require a lot of work. For package version upgrades and such a one-line commit message is usually sufficient. </ins> ## Reviewing contributions See the nixpkgs manual for more details on how to [Review contributions](https://nixos.org/nixpkgs/manual/#sec-reviewing-contributions).

Discussion:
Nixpkgs already has some guidelines how to write commit messages in It describes how to structure the message. Most commits follow this guideline which is very good. However one Problem is that many people do really good changes in their commit but for somebody not directly involved it is really hard to understand why. In my opinion it's very important to have this "why" in the commit message, especially if the project has many collaborators of various degree of involvement. One project I found to do this very well is . I propose to add a section to that encourages to explain a bit more why the changes were made. Maintainers should then encourage people to follow this guidelines when reviewing PRs.
Do you have any special kind of commits in mind? I am asking because package updates and new package commits seems pretty much self-explanatory. (one improvement I can see in this regard is to put release notes for package updates commits) Also, the why, while not in mandatory in the commit message, should figure in the pull-request .
I recently stumbled upon this commit for example: While the commit message clearly states what is done, I have no Idea why it was done. Having the motivation in the pull request is good but doing self contained commits with all the information for somebody to understand the changes and the reasons behind is even better.
I second that the motivation should be in the commit message and not only the pr, so one can read it without searching for the pr on github first..
Change:
default = false; type = types.bool; description = '' <del> Turn on proxy_arp for this device (and proxy_ndp for ipv6). </del> <ins> Turn on proxy_arp for this device. </ins> This is mainly useful for creating pseudo-bridges between a real interface and a virtual network such as VPN or a virtual machine for interfaces that don't support real bridging (most wlan interfaces).

Discussion:
When setting proxyARP currently ip-routing is only set for ipv6, but not for ipv4. Set proxyARP on an interface and check wether ` is set to 1. system: host os: multi-user?: sandbox: version: channels(root): channels(louis): nixpkgs:
The description states the following: and also: But the implementation seems to neither enable forwarding for IPv6 nor for IPv6 (form ): is missing since which also broke IPv4 forwarding (completely removed since ).
It would be interesting to know the reason behind removing this in the first place. seems to state that the intention of this commit seems to have been to remove non-existent sysctl options, but clearly exists as sysctl option, so maybe something is going on here, that I'm not seeing at the moment.
I'm pretty sure that it was removed accidentally ( was a pretty big change, which can be difficult to review properly). There was a minor typo in there that is unfortunately pretty easy to miss but very important. The correct kernel parameter is (vs. with an underscore instead of a dot). Feel free to make a PR to fix this (i.e. enabling IPv4 forwarding and for IPv6, instead of ), if you have time (if you don't have time for it I can probably do this in a few days, but unfortunately I cannot test this probably at the moment).
Ok. This shouldn't take to long, so I think I can send something later.
I assume was a typo, and should have been renamed to in .
Change:
rio.pkg = p: p.rio; rio.cmd = "rio -e $command"; <ins> rio.pinkValue = "#FF1261"; </ins> roxterm.pkg = p: p.roxterm; roxterm.cmd = "roxterm -e $command";

Discussion:
Package name: rio Latest released version: 0.0.27 <!-- Search your package here: --- Current version on the unstable channel: 0.0.19 Current version on the stable/release channel: N/A <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Seems one of the dependence of depends on which not entered master yet (see ). I'll handle this once it gets ready.
Not sure why it requires it. Maybe removing this requirement?
And it's an critical component that could not be remove.
1.72.1 merged into master
:+1: Looking forward to this as well. Hopefully fixes
Still not merged into master, merged into staging-next though.
1.73 has been merged into master.
I sent the update
Change:
runHook postCheck ''; passthru.plugins = allPlugins; <ins> passthru.tests.gstreamer = runCommand "beets-gstreamer-test" { meta.timeout = 60; } '' set -euo pipefail export HOME=$(mktemp -d) mkdir $out cat << EOF > $out/config.yaml replaygain: backend: gstreamer EOF echo $out/config.yaml ${beets}/bin/beet -c $out/config.yaml > /dev/null ''; </ins> meta = with lib; { description = "Music tagger and library organizer"; homepage = "https://beets.io";

Discussion:
Using the beets package together with replaygain setting stopped working on unstable and master branches. With the following config: Beets will not launch and just returns an error: Beets should launch correctly without a error. A workaround to make it work again is to replace the backend to . Please run and paste the result.
This also breaks the mopidy-youtube extension, with the same error:
Mopidy should be fixed by in the next nixos-unstable bump. I imagine the cause of the issue for beets is similar
Yep, that's it. Fix in the PR.
Change:
/* * PAM_USER and PAM_RUSER do not necessarily have to get set by the calling application, and we may be unable to divine the latter. <del> @@ -187,16 +184,17 @@ </del> <ins> @@ -184,5 +181,5 @@ </ins> */ if(user && strlen(ruser) > 0) { -        pamsshagentauth_verbose("Attempting authentication: `%s' as `%s' using %s", ruser, user, authorized_keys_file); +        pamsshagentauth_verbose("Attempting authentication: `%s' as `%s' using %s", ruser, user, authorized_keys_file_input); <ins> @@ -201,3 +197,3 @@ retval = PAM_SUCCESS; -                pamsshagentauth_logit("Authenticated (sshd): `%s' as `%s' using %s", ruser, user, authorized_keys_file); +                pamsshagentauth_logit("Authenticated (sshd): `%s' as `%s' using %s", ruser, user, authorized_keys_file_input); @@ -211,11 +208,12 @@ </ins> /* * this pw_uid is used to validate the SSH_AUTH_SOCK, and so must be the uid of the ruser invoking the program, not the target-user */ -        if(pamsshagentauth_find_authorized_keys(user, ruser, servicename)) { /* getpwnam(ruser)->pw_uid)) { */ <del> -            pamsshagentauth_logit("Authenticated: `%s' as `%s' using %s", ruser, user, authorized_keys_file); </del> <ins> -            pamsshagentauth_logit("Authenticated (agent): `%s' as `%s' using %s", ruser, user, authorized_keys_file); </ins> +        const char *key_file; +        if((key_file = pamsshagentauth_find_authorized_keys(user, ruser, servicename))) { /* getpwnam(ruser)->pw_uid)) { */ <del> +            pamsshagentauth_logit("Authenticated: `%s' as `%s' using %s", ruser, user, key_file); </del> <ins> +            pamsshagentauth_logit("Authenticated (agent): `%s' as `%s' using %s", ruser, user, key_file); </ins> retval = PAM_SUCCESS; } else { -            pamsshagentauth_logit("Failed Authentication: `%s' as `%s' using %s", ruser, user, authorized_keys_file);

Discussion:
Describe the bug After upgrading to NixOS 20.03, sudo often (but not always) segfaults: From the logs: Disabling appears to have made this problem to away, so the problem may be in . Metadata NixOS 20.03..
Maybe the patch to use a not insecure openssl is the source of the issue for you
same issue here - the sourceforge repo is way old, there's a github mirror but not maintained either, and there's a fork of the mirror which includes fixes for openssl 1.1.1:
I marked this as stale due to inactivity. &rarr;
Hmm, kinda forgot about this
I missed the fact that the "supported" branch didn't actually include the patch to fix this.
Change:
lib, buildPythonPackage, fetchFromGitHub, <del> fetchpatch, </del> isPy27, pytestCheckHook, autoconf271,

Discussion:
Steps to reproduce the behavior: python311Packages.awslambdaric e.g.: I'm using a flake to build a docker image with awslambdaric to deploy in a AWS Lambda. I'm on NixOS unstable. I attempted to override doChecks to false but that did not help. There is a where the simplejson version changed. More recently, upstream has relaxed the version requirements: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thanks, should fix it.
Change:
<ins> { lib , stdenv , python3 , fetchFromGitHub , rustPlatform , SDL2 , libiconv , darwin }: python3.pkgs.buildPythonApplication rec { pname = "pyxel"; version = "2.0.7"; pyproject = true; disabled = python3.pythonOlder "3.7"; src = fetchFromGitHub { owner = "kitao"; repo = "pyxel"; rev = "v${version}"; hash = "sha256-5Jrwfi79HbS4hh+eMwI49Rsk4jrAdAuDhNpUT2cEvDo="; }; patches = [ ./never-bundle-sdl2.patch ./update-bindgen-f16-support.patch # can be removed once rust-bindgen gets a new release ]; cargoRoot = "crates/pyxel-wrapper"; # Lockfile is generated by applying patches with `git apply` # and then running `cargo generate-lockfile` in `crates/pyxel-wrapper` cargoDeps = rustPlatform.importCargoLock { lockFile = ./Cargo.lock; outputHashes = { "bindgen-0.69.1" = "sha256-1967EmuyWgmrKmhwAcW49dlmuWPNuKjuRr5/u7ZKpXQ="; }; }; postPatch = '' cp ${./Cargo.lock} crates/pyxel-wrapper/Cargo.lock ''; nativeBuildInputs = with rustPlatform; [ cargoSetupHook maturinBuildHook bindgenHook ]; buildInputs = [ SDL2 ] ++ lib.optionals stdenv.isDarwin [ libiconv darwin.apple_sdk.frameworks.IOKit ]; env.NIX_CFLAGS_COMPILE = "-I${lib.getDev SDL2}/include/SDL2"; # Tests can't use the display dontCheck = true; pythonImportsCheck = [ "pyxel" "pyxel.pyxel_wrapper" ]; meta = { changelog = "https://github.com/kitao/pyxel/tree/${src.rev}/CHANGELOG.md"; description = "A retro game engine for Python"; homepage = "https://github.com/kitao/pyxel"; license = lib.licenses.mit; mainProgram = "pyxel"; maintainers = with lib.maintainers; [ tomasajt ]; platforms = lib.platforms.linux ++ lib.platforms.darwin; }; } </ins>

Discussion:
Project description Pyxel is a retro game engine for Python. Metadata homepage URL: source URL: license: mit platforms: unix, linux, darwin Priorities Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
oops!
Change:
sha256 = "c0abe3218b86533cca287e7057a37481883c07acef7814b70583406938214cc8"; }; }); <del> pyyaml = super.pyyaml_3; </del> }; }; in newPython.pkgs.buildPythonApplication rec { <del> version = "1.12.0"; </del> <ins> version = "1.12.3"; </ins> pname = "conan"; src = newPython.pkgs.fetchPypi { inherit pname version; <del> sha256 = "0hgy3wfy96likdchz42h9mawfjw4dxx7k2iinrrlhph7128kji1j"; </del> <ins> sha256 = "1cnfy9b57apps4bfai6r67g0mrvgnqa154z9idv0kf93k1nvx53g"; </ins> }; <ins> propagatedBuildInputs = with newPython.pkgs; [ colorama deprecation distro fasteners bottle future node-semver patch pygments pluginbase pyjwt pylint pyyaml requests six tqdm ]; </ins> checkInputs = [ <ins> pkgconfig </ins> git ] ++ (with newPython.pkgs; [ codecov mock <ins> pytest </ins> node-semver nose parameterized webtest ]); <del> propagatedBuildInputs = with newPython.pkgs; [ colorama deprecation distro fasteners bottle future node-semver patch pygments pluginbase pyjwt pylint pyyaml requests six tqdm ]; </del> checkPhase = '' <del> export HOME="$TMP/conan-home" mkdir -p "$HOME" </del> <ins> export HOME=$TMPDIR pytest conans/test/{utils,unittests}  -k 'not SVN and not ToolsNetTest' </ins> ''; postPatch = '' substituteInPlace conans/requirements_server.txt  --replace "pluginbase>=0.5, < 1.0" "pluginbase>=0.5" <ins> substituteInPlace conans/requirements.txt  --replace "PyYAML>=3.11, <3.14.0" "PyYAML" </ins> ''; meta = with lib; {

Discussion:
In the pinned pyyaml3 was removed since the package works now with the current version. It is still used in other packages. Check if it is still needed. When no package needs it anymore, wen can deprecate pyyaml_3. cc maintainers
Relevant issue:
seems that only 3 packages use it, we should be able to push that into the application expressions themselves.
Please do that. PyYAML 3.x is known for numerous security problems and won't get fixed upstream.
Change:
<del> { lib, rustPlatform, fetchCrate, pkg-config, openssl, stdenv, Security }: </del> <ins> { lib , rustPlatform , fetchCrate , pkg-config , libgit2 , openssl , zlib , stdenv , darwin }: </ins> rustPlatform.buildRustPackage rec { pname = "panamax"; <del> version = "1.0.3"; </del> <ins> version = "1.0.6"; </ins> src = fetchCrate { inherit pname version; <del> sha256 = "sha256-w4waFdzd/Ps0whOp39QLBE/YF2eyc4t2Ili7FskUt1M="; </del> <ins> sha256 = "sha256-/JW2QB5PtwKo0TLU/QmkgsE6/ne+51EVmWyGn7Lljdw="; </ins> }; <del> cargoSha256 = "sha256-52snmkTFHI26xJo9qJkmqh1M5lLzhDxw8WT6uFd57aw="; </del> <ins> cargoSha256 = "sha256-aKdDismdPcExqznS6S2LvAij6gv9/Hw2FBvkhr9rJGo="; </ins> nativeBuildInputs = [ pkg-config ]; <del> buildInputs = [ openssl ] ++ lib.optional stdenv.isDarwin Security; </del> <ins> buildInputs = [ libgit2 openssl zlib ] ++ lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; </ins> meta = with lib; { description = "Mirror rustup and crates.io repositories for offline Rust and cargo usage";

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: panamax <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.0.3 desired version: 1.0.6 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
sed -i 's/raise.*No Xcode or CLT version detected.*/version = "7.0.0"/' tools/gyp/pylib/gyp/xcode_emulation.py ''; <del> patches = stdenv.lib.optionals stdenv.isDarwin [ ./no-xcode.patch ./pkg-libpath.patch ]; </del> <ins> patches = stdenv.lib.optionals stdenv.isDarwin [ ./no-xcode.patch ]; </ins> postFixup = '' sed -i 's/raise.*No Xcode or CLT version detected.*/version = "7.0.0"/' $out/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py

Discussion:
All builds of fail. When I try to build nixpkgs/master locally, I get the same failure as Any ideas what might cause this?
I think the issue is that it's reaching out to the host Xcode and needs to be patched not to do that. I don't have time to look and although I know about darwin impurities a fair amount, know nothing about nodejs. Someone who actually uses it needs to step up and fix it properly. The fix will likely look like a patch that tells it not to reach out to Xcode and instead teaches it where to find the things it needs. Also relevant is a project is working on to present a fake Xcode to our , but I don't think that's ready yet.
For what it is worth. I have Xcode installed and if I add this line back in it builds for me:
That's weird. I took it out because I couldn't even find that line in the source, but I might have missed it somehow. Feel free to push it back in!