jiebi/CodeConvo huggingface dataset:
Change:
description = "Customizable gtk-layer-shell wlroots/sway bar written in Rust"; license = licenses.mit; platforms = platforms.linux; <del> maintainers = with maintainers; [ yavko donovanglover jakestanger ]; </del> <ins> maintainers = with maintainers; [ yavko donovanglover jakestanger ]; </ins> mainProgram = "ironbar"; }; }

Discussion:
Package name: Ironbar Latest released version: 0.15.0Current version on the unstable channel: 0.14.1 Current version on the stable/release channel: 0.13.0 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<ins> { lib, stdenvNoCC, fetchFromGitHub, zsh, installShellFiles, ncurses, nix-update-script, testers, runCommand, }: stdenvNoCC.mkDerivation (finalAttrs: { pname = "revolver"; version = "0.2.4-unstable-2020-09-30"; src = fetchFromGitHub { owner = "molovo"; repo = "revolver"; rev = "6424e6cb14da38dc5d7760573eb6ecb2438e9661"; hash = "sha256-2onqjtPIsgiEJj00oP5xXGkPZGQpGPVwcBOhmicqKcs="; }; strictDeps = true; doInstallCheck = true; nativeBuildInputs = [ installShellFiles ]; buildInputs = [ zsh ncurses ]; nativeInstallCheckInputs = [ zsh ]; patches = [ ./no-external-call.patch ]; postPatch = '' substituteInPlace revolver  --replace-fail "tput cols" "${ncurses}/bin/tput cols" ''; installPhase = '' runHook preInstall install -D revolver $out/bin/revolver runHook postInstall ''; postInstall = '' installShellCompletion --cmd revolver --zsh revolver.zsh-completion ''; installCheckPhase = '' runHook preInstallCheck PATH=$PATH:$out/bin revolver --help runHook postInstallCheck ''; passthru = { tests = { demo = runCommand "revolver-demo" { nativeBuildInputs = [ finalAttrs.finalPackage ]; } '' export HOME="$TEMPDIR" # Drop stdout, redirect stderr to stdout and check if it's not empty exec 9>&1 echo "Running revolver demo..." if [[ $(revolver demo 2>&1 1>/dev/null | tee >(cat - >&9)) ]]; then exit 1 fi echo "Demo done!" mkdir $out ''; version = testers.testVersion { package = finalAttrs.finalPackage; # Wrong '0.2.0' version in the code version = "0.2.0"; }; }; updateScript = nix-update-script { }; }; meta = { description = "Progress spinner for ZSH scripts"; homepage = "https://github.com/molovo/revolver"; downloadPage = "https://github.com/molovo/revolver/releases"; license = lib.licenses.mit; mainProgram = "revolver"; inherit (zsh.meta) platforms; maintainers = with lib.maintainers; [ d-brasher ]; }; }) </ins>

Discussion:
Project description A progress spinner for ZSH scripts <!-- Describe the project a little: --Metadata homepage URL: source URL: license: mit platforms: unix
Change:
config = lib.mkIf cfg.enable { <del> environment.systemPackages = [ pkgs.podman # Docker compat pkgs.runc # Default container runtime pkgs.crun # Default container runtime (cgroups v2) pkgs.conmon # Container runtime monitor pkgs.slirp4netns # User-mode networking for unprivileged namespaces pkgs.fuse-overlayfs # CoW for images, much faster than default vfs pkgs.utillinux # nsenter pkgs.iptables ] ++ lib.optional cfg.dockerCompat dockerCompat; </del> <ins> environment.systemPackages = [ podmanPackage ] ++ lib.optional cfg.dockerCompat dockerCompat; </ins> environment.etc."containers/libpod.conf".text = '' cni_plugin_dir = ["${pkgs.cni-plugins}/bin/"] <del> cni_config_dir = "/etc/cni/net.d/" </del> '' + cfg.libpod.extraConfig; <del> environment.etc."cni/net.d/87-podman-bridge.conflist".source = copyFile "${pkgs.podman.src}/cni/87-podman-bridge.conflist"; </del> <ins> environment.etc."cni/net.d/87-podman-bridge.conflist".source = copyFile "${pkgs.podman-unwrapped.src}/cni/87-podman-bridge.conflist"; </ins> # Enable common /etc/containers configuration virtualisation.containers.enable = true;

Discussion:
Describe the bug Podman's packaging isn't following the spirit of Nix, as far as I can tell. It seems to pull in a bunch of run-time executable dependencies via PATH resolution instead of build-time resolution. To Reproduce nix-shell -p podman --run podman based on the module, it looks like several run-time executables are referenced through PATH resolution instead of build-time pinning: Expected behavior Nix's build products should have stable references to their run-time dependencies whenever possible. Given podman's rootless container support, I doubly expected to give a usable podman.
Maintainer cc
Hmm im not sure how I feel about this. Podman is agnostic of container runtime for example. So it not having a path to either runc or crun is a feature. But conmon should probably be referenced by nix path yes. And utillinux too. We could perhaps default to runc runtime and let people opt to crun?
check out this PR from
I see the issue here. We could also discuss if it generally would make sense to have a build-time config feature for podman. Having strong defaults without configuration could be achieved that way for NixOS, too.
Is this expected to work without registry and policy files in ?
I would like it to, and it sounds like there is upstream work to make that possible.
This already works with rootless podman if you have the appropriate subuib/subgids set up. If is merged will work out of the box on NixOS.
Change:
{ lib , fetchFromGitHub , resholve <del> , substituteAll </del> , bash , coreutils , goss

Discussion:
is structured in a way that makes it impossible to write a for an absolute path that’s in the Nix store. Try to build this Nix expression: It will give you this error: That Nix expression builds successfully. To workaround this problem, you can use a fake directive… …or you can use a keep directive that refers to a variable instead of an absolute path: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
I think it might be a misfeature to make this work the way you're trying it--you don't need to interpolate the absolute store path into the script: The API could debatably be improved here by implicitly adding to the path and generate/collect lore for those locations. (I'm not certain that'd be an improvement; I'd probably need to census existing libexec directories and see if the stuff in them is likely to clash with the contents of other directories...)
Now that I know that I can do , I’m inclined to agree. I wouldn’t add to the path by default. It would be confusing because installing or running doesn’t add to your . The thing that would have really helped me here would have been improved documentation. That quote and the code examples made me assume that I was only allowed to put packages in the list. If I had known that I could put paths to directories that contain executables, then I would have probably done that instead of trying to put an absolute store path into the script.
Thanks for this--my next question was going to be whether you had a sense of what the right breadcrumb would've been. (Left to my own devices, I would've gone off adding an admonition to the documentation for keep directives...)
Change:
${cfg.promptInit} ${cfg.interactiveShellInit} <del> # and leave a note to our children to spare them the same work set -gx __fish_nixos_interactive_config_sourced 1 </del> <ins> # and leave a note so we don't source this config section again from # this very shell (children will source the general config anew, # allowing configuration changes in, e.g, aliases, to propagate) set -g __fish_nixos_interactive_config_sourced 1 </ins> end '';

Discussion:
Fish usually has available, but the aliases are now missing, when the shell is not a login shell (presumably because of ). Have Then launch as a not-login shell. Try to use . System: 17.09pre107265. (Hummingbird)
Agh, what a mess. Thanks for raising this issue.
I think this issue is a little subtler than one would think: aliases are sourced, but only when the parent shell has not already sourced the interactive configuration. This is out of line with the behavior of the other shells on NixOS. I have a fix which I've tested with your example here. I will post a link to the relevant PR momentarily (after I put it up).
So apparently outgoing SSH is blocked from the WiFi on this cruise ship, so I can't push commits with the remotes I have set up, and my sister is nagging me to get off the computer so we can go out. If you need a quick fix on your own machine (I will be back later today, while I still have internet access, to submit the new PR), just change the lines in the NixOS module for fish () to and your aliases will get sourced every time the shell starts, so changes will be reflected without a reboot or manually unsetting the relevant variable before starting a new shell (). (The latter will do the trick if you want a quick fix without any changes to your Nixpkgs tree.)
there's a fix in this commit:
Thanks!

It looks like PR messed something up with fish environment as now connecting to a server with mosh fails giving fish: Unknown command 'mosh-server new -c 256 -s -l LANG=enUS.UTF-8 -l LCALL=enUS.UTF-8' fish: mosh-server 'new' '-c' '256' '-s' '-l' 'LANG=enUS.UTF-8' '-l' 'LCALL=enUS.UTF-8' I reverted the commit (it was mistakenly merged into 17.03) and mosh started working again. the system
I will likely not get a chance to really look into this until next week, but I will definitely figure out what went wrong here. Sorry about this! :-(
Don't worry too much, it's not something critical (hopefully it's the only thing affected). I'll try to sort this out though I have little experience here.
there's a fix in this commit:
Change:
inherit (chickenPackages_4) eggDerivation fetchegg; }; <del> unar = callPackage ../tools/archivers/unar { stdenv = clangStdenv; }; </del> <ins> unar = callPackage ../tools/archivers/unar { inherit (darwin.apple_sdk.frameworks) Foundation AppKit; stdenv = clangStdenv; }; </ins> unp = callPackage ../tools/archivers/unp { };

Discussion:
Sadly doesn't build on macOS right now, so we can't use this on macOS. If someone could make work on macOS, it would be great. I did try to do it here but could get it to fix the link issue: Originally posted by in
If someone wants to know what is the link error I am getting, here is the build log: The error: As far I understand from searching, is proprietary so we can't link to it directly. Still, I am really curious on why it is trying to build with ARC enabled since I am not passing as parameter to .
Have you tried passing ?
Not sure how to pass it, I tried this: Same error.
To make it clear: it doesn't seem that is picking this option. Searching from my buffer if it was being passed I didn't found any references for .
Here is a tip: you can check compiler flags by passing to
It does seem to be passing it, but linker still tries to link with . I also tried this. Same thing:
This works here:
Thanks Finally it works. Just doing some checks and clean-up and I am going to open a PR.
Maybe we should use Text API files, similar to what we do when linking against ?
Change:
''; }; <del> enableSandbox = mkOption { default = false; type = types.bool; description = '' Starting Nginx web server with additional sandbox/hardening options. ''; }; </del> user = mkOption { type = types.str; default = "nginx";

Discussion:
ping It was agreed that should be removed before . It was generally accepted that an option isn't a great idea and was to the module temporarily for ease of testing. It is important to remove this because other people have seen this option and started believing this is an accepted design pattern for NixOS modules - we don't want people getting the wrong idea and having more options like this slip in. can you please file a PR removing this option and the entry from the release notes?
Change:
CapabilityBoundingSet = [ "CAP_NET_BIND_SERVICE" "CAP_SYS_RESOURCE" ]; # Security NoNewPrivileges = true; <del> } // optionalAttrs cfg.enableSandbox { </del> # Sandboxing ProtectSystem = "strict"; ProtectHome = mkDefault true;

Discussion:
ping It was agreed that should be removed before . It was generally accepted that an option isn't a great idea and was to the module temporarily for ease of testing. It is important to remove this because other people have seen this option and started believing this is an accepted design pattern for NixOS modules - we don't want people getting the wrong idea and having more options like this slip in. can you please file a PR removing this option and the entry from the release notes?
Change:
<ins> { buildGoModule , fetchFromGitHub , lib }: buildGoModule rec { pname = "go-audit"; version = "1.0.0"; src = fetchFromGitHub { owner = "slackhq"; repo = pname; rev = "v${version}"; sha256 = "02iwjzaz2ks0zmwijaijwzc3gn9mhn7xpx369ylgaz68arlapfjg"; }; vendorSha256 = "11kb7xm82s0d8d06b2jknwn3dfh4i0a1dv0740y47vk62sf6f05i"; # Tests need network access doCheck = false; meta = with lib; { description = "An alternative to the auditd daemon"; homepage = "https://github.com/slackhq/go-audit"; license = with licenses; [ mit ]; maintainers = with maintainers; [ fab ]; platforms = platforms.linux; }; } </ins>

Discussion:
Project description go-audit is an alternative to the auditd daemon that ships with many distros. From : Metadata homepage URL: source URL: license: MIT platforms: Linux
Change:
}; }; <ins> systemd.services.gitlab-mailroom = mkIf (gitlabConfig.production.incoming_email.enabled or false) { description = "GitLab incoming mail daemon"; after = [ "network.target" "redis.service" "gitlab.service" ]; # gitlab.service creates configs wantedBy = [ "multi-user.target" ]; environment = gitlabEnv; serviceConfig = { Type = "simple"; TimeoutSec = "infinity"; Restart = "on-failure"; User = cfg.user; Group = cfg.group; ExecStart = "${cfg.packages.gitlab.rubyEnv}/bin/bundle exec mail_room -c ${cfg.packages.gitlab}/share/gitlab/config.dist/mail_room.yml"; WorkingDirectory = gitlabEnv.HOME; }; }; </ins> systemd.services.gitlab = { after = [ "gitlab-workhorse.service" "gitaly.service" "network.target" "gitlab-postgresql.service" "redis.service" ]; requires = [ "gitlab-sidekiq.service" ];

Discussion:
In order to enable in GitLab you need to edit the Procfile or the systemd service, which I don't think is currently possible. The output of is: Install GitLab service Run as rootsystem: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
reading up on , it seems this is configuration nowadays. Can you get it working by adding the options mentioned in the docs to ? If so, we probably should add that as regular options into the gitlab module.
cc
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
I still think this is desirable. can you take a look?
Change:
''} ''; } // optionalAttrs (backup.dynamicFilesFrom != null || backup.backupCleanupCommand != null) { <del> postStart = '' </del> <ins> postStop = '' </ins> ${optionalString (backup.backupCleanupCommand != null) '' ${pkgs.writeScript "backupCleanupCommand" backup.backupCleanupCommand} ''}

Discussion:
Wouldn't it make sense to use instead of for the ? That way the can also run when the backup service failed for some reason.
It does make sense. Could you prepare a PR?
Thanks for the fast answer. Since I'm pretty new to NixOS, I can try. :) Is it simply changing to here?
Yes, it'd use in all cases.
Do I have to follow those "complex" PR rules? Since the change is really small and should be save.
Yes. PR rules need to be followed.
Ok. It will take a while to understand then. Since I never built or tested anything locally ...
No worries. You can use the nixpkgs clone to test in your machine. Also restic has regression tests.
Sorry, I'm too busy right now and this is pretty low on my priority list. So I think I won't do that. Maybe at some point in the future ...
Change:
}; in [ "${mingw-patch}/*.patch" <del> ]); </del> <ins> ]) ++ optionals (pythonAtLeast "3.12" && (stdenv.hostPlatform != stdenv.buildPlatform) && ( stdenv.hostPlatform.isAarch32 || stdenv.hostPlatform.isAarch64 || stdenv.hostPlatform.isRiscV )) [ # backport fix for various platforms; armv7l, riscv64 # https://github.com/python/cpython/pull/121178 ( if (pythonAtLeast "3.13") then ./3.13/0001-Fix-build-with-_PY_SHORT_FLOAT_REPR-0.patch else ./3.12/0001-Fix-build-with-_PY_SHORT_FLOAT_REPR-0.patch ) ]; </ins> postPatch = optionalString (!stdenv.hostPlatform.isWindows) '' substituteInPlace Lib/subprocess.py 

Discussion:
() regressed cross compilation for python3. Steps to reproduce the behavior: Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
preparing a PR.
Change:
<del> { lib , bundlerApp , bundlerUpdateScript }: bundlerApp { pname = "neocities"; gemdir = ./.; exes = [ "neocities" ]; passthru.updateScript = bundlerUpdateScript "neocities"; meta = with lib; { description = "Neocities Gem - A CLI and library for using the Neocities web site API"; homepage = "https://github.com/neocities/neocities-ruby"; license = licenses.mit; mainProgram = "neocities"; maintainers = with maintainers; [ dawoox ]; platforms = platforms.unix; }; } </del>

Discussion:
I'm not really sure how it happened, however we have 2 copies of the Neocities CLI: One from , and another from . After formatting the nix files in each, the only differences are: Description Maintainers Platforms ( lists ) Gemfile lock platform/bundled-with version ( is bundled-with , has as a platform and is bundled-with ) is older, while is newer and slightly more complete, as it seems. One should be removed, with the other aliased to it. CC as the maintainer of the other Neocities package.
this happened before, i wonder if there are more cases like this rn
I'll take care of this -- it seems like is out of date so might as well take care of that, too.
Change:
license = with licenses; [ aom bsd3 ]; maintainers = with maintainers; [ Madouura ]; platforms = platforms.unix; <del> broken = stdenv.isAarch64; # undefined reference to `cpuinfo_arm_linux_init' </del> <ins> # error: use of undeclared identifier 'kCVPixelFormatType_444YpCbCr16BiPlanarVideoRange' broken = stdenv.isAarch64 && stdenv.isDarwin; </ins> }; })

Discussion:
As title says, the ffmpeg that handbrake uses can't be built, complaining about missing sdl2. Steps to reproduce the behavior: to install handbrake the error Handbrake is installable If applicable, add screenshots to help explain your problem. Please run and paste the result.
Try with this patch:
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
sorry i missed this, I don't know how can I try that?
I am getting a similar error, after running a channel update on the unstable channel.
Here to report the same issues, specifically seems to fail with . Here's the errors: Results of : Might be worth reopening.
This is a different issue and already fixed in nixos-unstable-small and should be in normal nixos-unstable shortly.
Sounds great, appreciate the heads up.
Change:
hash = "sha256-4wW58H9SdDykgdoKTgx2w179YK2vGwaU6zuwIeITfjk="; }; <ins> patches = [ # dlopen libsoup_3 with an absolute path (substituteAll { src = ./souploader.diff; nixLibSoup3Path = "${lib.getLib libsoup_3}/lib"; }) ]; </ins> strictDeps = true; depsBuildBuild = [ pkg-config ];

Discussion:
According to the GStreamer website, the "good" plugins package should contain the "soup" plugin. However, the nix package does not. Steps to reproduce the behavior: packages and Result: nothing found. As a result, cannot play any streams, failing with "could not create souphttpsrc element". should include . : : Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
please try and see if that fixes the problem for radiotray-ng
This fixes the problem for , thanks. Does this mean that is OK?
not really, in my opinion as it doesn't work out of the box. there was a PR to partially fix gstreamer but seems like it was missing glib-networking and didn't want to add it for some reason and was abandoned. if the gstreamer pkg isn't modified then adding glib-networking and libsoup to the ldlibrarypath is a work around.
The issue title is misleading. The loading of the library is broken but gst-plugins-good is actually compiled against libsoup.
Change:
, enableContrib   ? true , enableCuda      ? (config.cudaSupport or false) && <del> stdenv.hostPlatform.isx86_64, cudatoolkit </del> <ins> stdenv.hostPlatform.isx86_64, cudatoolkit, nvidia-optical-flow-sdk </ins> , enableUnfree    ? false , enableIpp       ? false

Discussion:
Describe the bug OpenCV 4 fails to build with cuda enabled due to missing NVIDIA optical flow sdk To Reproduce Steps to reproduce the behavior: -build -A opencv4 Expected behavior Either we disable OpenCV 4's option to compile with the NVIDIA optical flow SDK or allow compilation against the NVIDIA optical flow sdk headers. See: I've done some preliminary work towards this on the following branch:
Change:
# Do not test on Python 2 because the tests suite gets stuck # https://github.com/NixOS/nixpkgs/issues/60786 <del> doCheck = !(isPy27); </del> <ins> # Also macOS tests are broken on python38 doCheck = !(isPy27 || (stdenv.isDarwin && pythonAtLeast "3.8")); </ins> checkInputs = [ six ]; propagatedBuildInputs = [ nose colorama termstyle ];

Discussion:
Describe the bug fails to build. The issue appears to be with failing tests. To Reproduce Steps to reproduce the behavior: results in: Expected behavior The build is successful Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Metadata system: host os: multi-user?: sandbox: version: channels(matt): channels(root): nixpkgs: Maintainer information:
Change:
isSystemUser = true; }; <del> users.groups.traefik = {}; </del> <ins> users.groups.traefik = { }; </ins> }; }

Discussion:
Project description Traefik is a microservice oriented reverse proxy written in Go. It configures itself by container labels from docker/other provider or from text files. It does TLS termination and can fetch certs from let's encrypt automatically. A nixOS module to add configuration to the file backend (similar to the nginx ones) seems easy to implement. Traefik 1.0 is currently packaged (, ) Traefik 2.0 is NOT backwards compatible A package for 2.0 (not source built) has been written up by Metadata homepage URL: source URL: license: MIT platforms: linux, darwin, freebsd, openbsd, windows