jiebi/CodeConvo huggingface dataset:
Change:
githubId = 1583484; name = "Andrey Golovizin"; }; <ins> errnoh = { github = "errnoh"; githubId = 373946; name = "Erno Hopearuoho"; }; </ins> ersin = { email = "me@ersinakinci.com"; github = "ersinakinci";

Discussion:
Project description An unofficial GoXLR App replacement for Linux, Windows and MacOS. Metadata homepage URL: source URL: license: MIT platforms: linux
Moving conversation back here to avoid spamming goxlr-utility maintainers :sweat_smile: I made a draft PR that you can find from It's closer to what the official .deb and .rpm packaging is doing, i.e. including some of the relevant resources, shell completion etc. I wouldn't mind adding you as a maintainer but to do that it probably requires adding you to the maintainer list as well. Should be easy to fix if you want to add PR to the branch.
Hey wow you are fast :D Yes, you can add me as a maintainer for this package. But as I understand it, I need to add me to the maintainer list first, right?
Hah, had some free time during the night and since I wanted to get my GoXLR setup working anyways thought I might as well sort this out. For the question: Yup, the requires to be on . The file itself lists the mandatory/optional fields in the metadata, but basically "a name and at least one contact/identity information" (e.g. a github id). Oh, and the list needs to stay in alphabetical order ^^ Feel free to make PR against this branch, I'll merge it as soon as I notice the PR :)
Added the module to the PR as well. I guess it might be hard to wait for someone with GoXLR to come in and review the PR (though I'd prefer someone to check that it doesn't violate any major guidelines) so if you don't mind I think it's possible for you to try it out and do a PR review, which likely speeds up the process at least :)
Managed to get the PR reviewed and should now be code-wise idiomatic enough to pass. I think based on the main thing remaining is getting thumbs up from you functionality-wise so that's it's not only "works on my machine" :sweat_smile:
I saw your PR and tried using nixpkgs-review to download it to my local machine and try to run it. I used these steps: Do you know if my approach is wrong? This is the first time I've tried a Nix PR. Unfortunately, I haven't found much information about it.

EDIT: Got it working
Glad to hear you got it working! :) The nixpkgs-review tool seems nice, hadn't used it myself but for building the PR it seems to do exactly what one would expect. I guess in this case there's a limit what it can do though as the udev rules are being on the module side and it probably doesn't handle that so some manual work is required :shrug: But again, all is good since you did manage to test the build!
Change:
stdenv.mkDerivation rec { name = "singularity-${version}"; <del> version = "2.5.1"; </del> <ins> version = "2.5.2"; </ins> enableParallelBuilding = true;

Discussion:
I get the following collision: What I don't understand is why this collision is happening in the first place? I'm installing this package into an empty profile!
That's a multiple-output problem. The derivation creates two of them, both containing the file. When installing into user profiles, currently the semantics is that all outputs are installed, so this creates the collision.
Vladimír Čunát writes: What's the reason for these semantics? I would expect only 'out' to get installed by default.
Well, as for build inputs, we normally want all to be available, because you need include, lib and possibly others. should know details. It hasn't been used much yet, so I suppose we still have to figure out how to do these best (and have the most usual setup as the default).
What I haven't figured out in these cases: why installing attempts to install both and .
I am getting this same error message. Fresh install of Nix 16. Could it have regressed? This happens when I run nix-env -iA nixos.openjdk but not when I dun nix-env -iA Though those both say they point to openjdk-8
Change:
cargo, darwin, fetchFromGitHub, <ins> libiconv, </ins> pythonOlder, rustc, rustPlatform,

Discussion:
Steps to reproduce the behavior: Run: <details<summaryClick here for logs...</summary</detailsFor some reason, isn't being to the dependencies . No idea why. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Looks like an issue for I only have access to a real Darwin builder beside the community one.
This is , not . Maybe this is the easiest fix (confirmed it works for me)? What do you think is your package:
I opened to add libiconv to ruff-api.
Change:
<del> { stdenv, fetchurl, cmake, boost155, zlib, openssl, R, qt4, libuuid, hunspellDicts, unzip, ant, jdk, gnumake, makeWrapper }: </del> <ins> { stdenv, fetchurl, makeDesktopItem, cmake, boost155, zlib, openssl, R, qt4, libuuid, hunspellDicts, unzip, ant, jdk, gnumake, makeWrapper }: </ins> let version = "0.98.110"; ginVer = "1.5"; gwtVer = "2.5.1"; in <del> stdenv.mkDerivation { </del> <ins> stdenv.mkDerivation rec { </ins> name = "RStudio-${version}"; buildInputs = [ cmake boost155 zlib openssl R qt4 libuuid unzip ant jdk makeWrapper ];

Discussion:
No file is provided by Rstudio so system menus in KDE (and presumably any DE) don't show it. System: Nix version: (run ) Nixpkgs version: (run )
Change:
coreutilsMinimal = (pkgs.coreutils.override (args: { <del> # We want coreutils without ACL support. </del> <ins> # We want coreutils without ACL/attr support. </ins> aclSupport = false; <ins> attrSupport = false; </ins> # Our tooling currently can't handle scripts in bin/, only ELFs and symlinks. singleBinary = "symlinks"; })).crossDrv;

Discussion:
When trying to copy a file with extended attributes, the attributes don't get copied. When forcing to copy the attributes, it reports: The issue was probably introduced with multiple outputs support. Previously, would find libs&headers while building, propagated through . But now, only the libs propagate and not , so can't find the header and disables support. Not sure if coreutils should just list as a (when is) or if should somehow signal that its output should propagate too. System: Nix version: Nixpkgs version:
By default, the output should be propagated and it should propagate libs and some others in turn. I'll re-check all this later (if noone else is faster).
Hmm, as far as I can tell from the git logs, at least explicitly didn't propagate .
When I tested 16.03 it doesn't have xattr support there either. But anyway, enables it.
I'm pretty sure it used to work at some point, but it might have been a few years ago :) Thanks!
Change:
| sh ''; outputHashMode = "recursive"; <del> outputHash = "sha256-1TWySkS8w7L6Q+V946kcLOnM4hL3fieFvLrF5BZAlh4="; </del> <ins> outputHashAlgo = "sha256"; outputHash = "sha256-GjBUwJxeyJA6vGrPQVtNpcHb4CJlNlY4kHt1PT21xjo="; </ins> }; in stdenv.mkDerivation rec { inherit pname version src sourceRoot;

Discussion:
Gradle 7.4 is out, see (I am one of the maintainers, this is a TODO.)
Change:
jmusicbot = callPackage ../applications/audio/jmusicbot { }; <ins> junction = callPackage ../applications/misc/junction { }; </ins> lemonade = callPackage ../applications/misc/lemonade { }; libquvi = callPackage ../applications/video/quvi/library.nix { };

Discussion:
Project description Junction lets you choose the application to open files and links. Junction will pop up automatically when you open a link in a desktop application. Use the mouse or keyboard navigation to choose the application to open the link or file with. Metadata homepage URL: source URL: license: gpl3 platforms: linux
Change:
done done sed -i -e '/^$cmd .= " -pn";/a$cmd .= " -fp '"$fontPath"'";' unix/vncserver <ins> substituteInPlace vncviewer/vncviewer.cxx  --replace '"/usr/bin/ssh' '"${openssh}/bin/ssh' </ins> ''; dontUseCmakeBuildDir = true;

Discussion:
The tigerVNC vnc client can tunnel over ssh, but does so defaulting to /usr/bin/ssh as the path to the ssh client tigervnc -via user localhost:0 Will display System: NixOS 17.03.1775. (Gorilla) Nix version: nix-env (Nix) 1.11.13 Nixpkgs version:17.03.1775. Sandboxing enabled: false
Does adding either or to the command work?
I didn't try that, but does work, which is the documented way of handling this.
I see, where is that documented? The reason I asked that is because it seemed like was set as a default parameter value , so I thought this could just be patched in nixpkgs.
Just add to the package and make a pull request:
It's documented in the tigervnc manpage for vncviewer. I'm 99% certain it's not in that Java file, but in this C++ file:
import and try the following:
Change:
buildInputs = [ alsa-lib fluidsynth libpulseaudio qtbase qtsvg sonivox <del> ]; </del> <ins> ] ++ lib.optionals isQt6 [ qt5compat ]; </ins> cmakeFlags = [ <del> "-DUSE_DBUS=ON" </del> <ins> (lib.cmakeBool "USE_DBUS" true) (lib.cmakeBool "USE_QT5" (!isQt6)) </ins> ]; meta = with lib; { <del> maintainers = []; description = "MIDI libraries for Qt5/C++"; </del> <ins> description = "MIDI libraries for Qt/C++"; </ins> homepage = "https://drumstick.sourceforge.io/"; license = licenses.gpl2Plus; <ins> maintainers = with maintainers; [ wegank ]; </ins> platforms = platforms.linux; }; }

Discussion:
Package name: kmetronome Latest released version: 1.4.0 Current version on the unstable channel: 1.2.0 Current version on the stable/release channel: 1.2.0 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
stdenv.mkDerivation { pname = "plan9port"; <del> version = "0.pre+date=2021-10-19"; </del> <ins> version = "2021-10-19"; </ins> src =  fetchFromGitHub { owner = "9fans";

Discussion:
The new scheme introduced in confuses the script. latest plan9port from unstable as of writing to use from within an environment spawned by gets moved from the front of to the back Here is a session using unmodified p9p: ylh ~ PATH ylh ~ $ 9 zsh ylh ~ PATH /nix/store/d4iwcgqwgk8whxjxgmhh20ykni7flkb2-plan9port-0.pre+date=2021-10- ylh ~ $ u zsh ylh ~ PATH /nix/store/d4iwcgqwgk8whxjxgmhh20ykni7flkb2-plan9port-0.pre+date=2021-10- After applying the following overlay: self: { lib, plan9port, ... }: let lastby = sep: x: (lib.splitString sep x); in { plan9port = plan9port.overrideAttrs (old pname, ... }: { version = lastby "=" (lastby "+" old.version); name = "{version}"; }); } the desired result is achieved: ylh ~ PATH ylh ~ $ 9 zsh ylh ~ PATH /nix/store/zh1iaayjg7baqvgh1g645k4wzxjrmfzx-plan9port-2021-10- ylh ~ $ u zsh ylh ~ PATH Amusingly, is left unaffected; the tool calls out to , which, in a environment (why else would you be calling ), is p9p sed, which interprets as a metacharacter without the need for . In any case, RFC 0107 clearly needs work, and this should hopefully demonstrate why enacting it (self-merging, no less) pre-approval is somewhat irresponsible. system: host os: multi-user?: sandbox: version: channels(root): channels(ylh): nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs Maintainer information:
This obsession with arbitrary versioning formatting standards is getting annoying.
Change:
}; wlroots = wlroots_0_15; <del> wlroots_0_12 = callPackage ../development/libraries/wlroots/0.12.nix {}; </del> wlroots_0_14 = callPackage ../development/libraries/wlroots/0.14.nix { inherit (xorg) xcbutilrenderutil; };

Discussion:
We've temporarily introduced as part of to avoid breaking some reverse dependencies. The affected attributes should switch to when possible (usually a new upstream release). There's no hurry but let's use this issue to track the current progress. : [x] phoc [x] cage (): [x] hikari ( and ): [x] waybox (): [x] wayfire (supported since ): [x] wio (, turns out the pending patches on the ML should fix the build with wlroots 0.13): [x] cagebreak ( and additional commits): () : [x] sway: [x] hikari (downstream patches: ): [x] wio (, send via git-send-email to ):
cage: was just merged, do we want to: until a next release it using the now-merged patch the latest version from master
I think waiting for the next release is the best option for now (we're in no hurry). For some other packages that are already based on commits instead of releases there's no need to wait if the package maintainers deem a newer version stable (in that case I'd leave it up to the package maintainers).
(though I hope that doesn't have the same problems as cage)
(kinda flew under the radar for me, but it happened!)
Don't we want to split this issue up per version? It seems like we're always gonna have a handful of wlroots versions around, would be nice if we could close those issues individually instead of having one perpetually open issue
I thought about that too but I was hoping we can close this before the next wlroots release. is the main blocker, should be fairly easy to drop (I'm waiting for patches and, if necessary, I might be able to patch again but I might also mark it as broken instead (until there's a maintained fork) as I don't intend to do that every release).
I have merely made a new fork for wio outside SourceHut, but me myself do not plan to maintain it alone.
in that case we should eventually drop it from Nixpkgs, at least IMO. I had some time yesterday so I've sent you a patch for wlroots 0.14 (, tested with ).
I have patched it on my particular fork
Phoc 0.11.0 was released targeting wlroots 0.14.0 (), so this can finally be closed.
Change:
in buildPythonApplication rec { pname = "lutris-unwrapped"; <del> version = "0.5.16"; </del> <ins> version = "0.5.17"; </ins> src = fetchFromGitHub { owner = "lutris"; repo = "lutris"; rev = "v${version}"; <del> hash = "sha256-Ed1bhugBe97XmY050A5jCPcnLj0Fd7qPX2p/Ab+YbOE="; </del> <ins> hash = "sha256-Tr5k5LU0s75+1B17oK8tlgA6SlS1SHyyLS6UBKadUmw="; </ins> }; nativeBuildInputs = [ wrapGAppsHook3 gobject-introspection ];

Discussion:
Package name: Lutris Latest released version: 0.5.17Current version on the unstable channel: 0.5.16 Current version on the stable/release channel: 0.5.14 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
stdenv.mkDerivation rec { pname = "jitsi-meet-electron"; <del> version = "2022.3.1"; </del> <ins> version = "2022.10.1"; </ins> src = fetchurl { url = "https://github.com/jitsi/jitsi-meet-electron/releases/download/v${version}/jitsi-meet-x86_64.AppImage"; <del> sha256 = "sha256-/5WpjmTLwQN73m7nHg4DKPbXIbD9WyJ+YBbFMD4ZDfg="; </del> <ins> sha256 = "sha256-98zuAsGT30paxszSO1XcMY8tsrMBeBLDFjK/JWhLC8s="; </ins> name = "${pname}-${version}.AppImage"; };

Discussion:
The package can no longer be installed because one of its dependencies () has been marked EOL. Steps to reproduce the behavior: Please run and paste the result.
Change:
<ins> { lib, stdenv, fetchFromGitHub, cmake, bzip2, libtomcrypt, zlib }: stdenv.mkDerivation rec { pname = "StormLib"; version = "9.22"; src = fetchFromGitHub { owner = "ladislav-zezula"; repo = "StormLib"; rev = "v${version}"; sha256 = "1rcdl6ryrr8fss5z5qlpl4prrw8xpbcdgajg2hpp0i7fpk21ymcc"; }; cmakeFlags = [ "-DBUILD_SHARED_LIBS=ON" "-DWITH_LIBTOMCRYPT=ON" ]; nativeBuildInputs = [ cmake ]; buildInputs = [ bzip2 libtomcrypt zlib ]; meta = with lib; { homepage = "https://github.com/ladislav-zezula/StormLib"; license = licenses.mit; description = "An open-source project that can work with Blizzard MPQ archives"; platforms = platforms.all; maintainers = with maintainers; [ aanderse karolchmist ]; }; } </ins>

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: devilutionx <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.2.1 desired version: 1.3.0 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR. There are a number of changes in the new version, many of which make it difficult to package for nixpkgs.
Change:
buildPythonPackage rec { pname = "b2sdk"; <del> version = "1.32.0"; </del> <ins> version = "1.33.0"; </ins> pyproject = true; disabled = pythonOlder "3.7";

Discussion:
Steps to reproduce the behavior: on <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- I don't have a machine, the failure is discovered by ofborg. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Closed by
No, that fixes runtime issue . Darwin still has failing tests
Change:
synfigstudio = callPackage ../applications/graphics/synfigstudio { }; <ins> typora = callPackage ../applications/editors/typora { }; </ins> taxi = callPackage ../applications/networking/ftp/taxi { }; taxi-cli = with python3Packages; toPythonApplication taxi;

Discussion:
Project description Typora is a distraction free markdown editor. Developed by Metadata homepage URL: source URL: Not open source :( Github Organization: license: platforms: , darwin
Hmmm I found this issue: Looks like the not open source thing is a problem here
Just checked, It seems to work fine with , so using buildFHSEnv should work. As says, there's nothing preventing this from being present in nixpkgs, as long as it works.
Change:
#! /bin/sh [ -n "$2" ] && NIXPKGS_ALL="$2"; <del> [ -z "$NIXPKGS_ALL" ] && [ -f "/etc/nixos/nixpkgs" ] && NIXPKGS_ALL="/etc/nixos/nixpkgs"; [ -z "$NIXPKGS_ALL" ] && [ -f "$HOME/nixpkgs" ] && NIXPKGS_ALL="$HOME/nixpkgs"; </del> <ins> [ -z "$NIXPKGS_ALL" ] && [ -d "/etc/nixos/nixpkgs" ] && NIXPKGS_ALL="/etc/nixos/nixpkgs"; [ -z "$NIXPKGS_ALL" ] && [ -d "$HOME/nixpkgs" ] && NIXPKGS_ALL="$HOME/nixpkgs"; </ins> [ -z "$NIXPKGS_ALL" ] && { echo "Cannot find Nixpkgs source. Please specify it via NIXPKGS_ALL or second command line argument" exit 1

Discussion:
Describe the bug Thunderbird 78.2.1 is working. master (Thunderbird 78.2.2) has rendering issues (see screenshot). Most buttons do not react to clicks and the menu is also not reacting. To Reproduce Switch to the mentioned commit and rebuild. Expected behavior Normally working thunderbird. Screenshots ! Notify maintainers Metadata
This was also a bug in Ubuntu, it was fixed there with:
Upstream bug appears to be
Btw temporary workaround would be to switch to thunderbird-bin-78 if you are not opposed to binaries
Change:
<del> { stdenv, lib, fetchFromGitHub, cmake, perl, zlib, libxml2, eigen, python, cairo, pcre, pkg-config, swig, rapidjson }: </del> <ins> { stdenv , lib , fetchFromGitHub , cmake , perl , zlib , libxml2 , eigen , python , cairo , pcre , pkg-config , swig , rapidjson , boost , maeparser , coordgenlibs }: </ins> stdenv.mkDerivation rec { pname = "openbabel";

Discussion:
Steps to reproduce the behavior: openbabel or any package that depends on it, i.e Kalzium The issue seems to have appeared in the most recent push to nixos-unstable, it seems to be an issue with the openbabel dependency <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Actually after properly inspecting this issue I realize that it is rather an issue with it's dependency, openbabel that fails to build
The problem is exactly this line and Python 3.12, which removed distutils: We can work around it by setting in CMake , but I didn't manage to get the Python bindings to build again, as the nix expression also crafts a custom like that:
Change:
# Run a command in the container. sub runInContainer { my @args = @_; <del> my $leader = getLeader; exec($nsenter, "-t", $leader, "-m", "-u", "-i", "-n", "-p", "--", @args); die "cannot run ‘nsenter’: $!n"; </del> <ins> exec("systemd-run", "--machine", $containerName, "--pty", "--quiet", "--", @args); die "cannot run ‘systemd-run’: $!n"; </ins> } # Remove a directory while recursively unmounting all mounted filesystems within

Discussion:
Currently nixos- uses to attach to containers. However this methods miss out some container context and does not create a pseudo tty. is the offical method recommended by upstream: Previous there was an attempt to use , which does not return the exit code. cc System: (NixOS: , Ubuntu/Fedora: , ...) Nix version: (run ) Nixpkgs version: (run ) Sandboxing enabled: (run )
Previous opinion on this:
Can be fixed by adding .
and don't give the complete container environment, so I'd consider and broken as of now. I agree with using for and for , which is also what systemd themselves recommend. From the : There is still a problem with merging / as , but I don't think that it's currently resolvable, since other container tools also just use a pty.
It is possible by using with the latest systemd release: However I still don't think exposing raw stdin/stdout by default is a good idea for the reason I have given here:
UPDATE I just read it possible to use and in conjunction and uses the more appropriate depending on the context.
Change:
# Create the tarball system.build.tarball = import ../../../lib/make-system-tarball.nix { <del> inherit (pkgs) stdenv perl xz pathsFromGraph; </del> <ins> inherit (pkgs) stdenv closureInfo pixz; </ins> inherit (config.tarball) contents storeContents; };

Discussion:
The module fails to evaluate since we are calling without a required argument. caused the regression. I'm not sure how to fix this. Please run and paste the results.
Change:
<del> { lib, stdenv, fetchurl, pkg-config, SDL2, libpng, libiconv }: </del> <ins> { lib, stdenv, fetchurl, pkg-config, SDL2, libpng, libiconv, libobjc }: </ins> stdenv.mkDerivation rec { pname = "qrencode";

Discussion:
As the title says, the package is including wayland despite the system being Darwin. Steps to reproduce the behavior: on Darwin Nix should evaluate and not fail.
Change:
services.xserver.displayManager.sddm = { theme = "breeze"; <del> themes = [ pkgs.extra-cmake-modules # for the setup-hook plasma5.plasma-workspace pkgs.breeze-icons ]; </del> <ins> package = pkgs.sddmPlasma5; </ins> }; security.pam.services.kde = { allowNullPassword = true; };

Discussion:
On NixOS 17.03, the in the system configuration with Plasma 5 enabled, has and in its runtime closure, which causes unnecessary bloat. This is because has: then causes the directories of and to be to the wrapper script. (Automatically adding everything with a directory to the wrapper seems pretty drastic BTW.) System: NixOS Nix version: 1.12pre5073_1cf4801
KDE upstream is slightly careless about implicit runtime dependencies. I spent hours trying to figure out which runtime dependencies needed to be in . By the way, you have to guess at this because SDDM doesn't log error messages. Could we drop ? Probably. Can I answer that question for any of the other dependencies? Not a chance. So I nuked it from orbit. Guessing the correct setting would be a good project for a first-time contributor with a lot of free time. At the moment, I'm trying to get rid of entirely. This problem may go away as a happy accident, but that won't help this release. I'm open to other suggestions.