jiebi/CodeConvo huggingface dataset:
Change:
++ lib.optional enableTWBT twbt.art ++ [ dwarf-fortress ]; <ins> fixup = lib.singleton (runCommand "fixup" {} '' mkdir -p $out/data/init cp ${dwarf-fortress}/data/init/init.txt $out/data/init/init.txt '' + lib.optionalString enableDFHack '' mkdir -p $out/hack # Patch the MD5 orig_md5=$(cat "${dwarf-fortress}/hash.md5.orig") patched_md5=$(cat "${dwarf-fortress}/hash.md5") input_file="${dfhack_}/hack/symbols.xml" output_file="$out/hack/symbols.xml" echo "[DFHack Wrapper] Fixing Dwarf Fortress MD5:" echo "  Input:   $input_file" echo "  Search:  $orig_md5" echo "  Output:  $output_file" echo "  Replace: $patched_md5" substitute "$input_file" "$output_file" --replace "$orig_md5" "$patched_md5" '' + lib.optionalString enableTWBT '' substituteInPlace $out/data/init/init.txt  --replace '[PRINT_MODE:2D]' '[PRINT_MODE:TWBT]' '' + '' substituteInPlace $out/data/init/init.txt  --replace '[INTRO:YES]' '[INTRO:${unBool enableIntro}]'  --replace '[TRUETYPE:YES]' '[TRUETYPE:${unBool enableTruetype}]'  --replace '[FPS:NO]' '[FPS:${unBool enableFPS}]' ''); </ins> env = buildEnv { name = "dwarf-fortress-env-${dwarf-fortress.dfVersion}"; <del> paths = themePkg ++ pkgs; </del> <ins> paths = fixup ++ themePkg ++ pkgs; </ins> pathsToLink = [ "/" "/hack" "/hack/scripts" ]; <del> postBuild = '' # De-symlink init.txt cp $out/data/init/init.txt init.txt rm -f $out/data/init/init.txt mv init.txt $out/data/init/init.txt '' + lib.optionalString enableDFHack '' # De-symlink symbols.xml rm $out/hack/symbols.xml # Patch the MD5 orig_md5=$(cat "${dwarf-fortress}/hash.md5.orig") patched_md5=$(cat "${dwarf-fortress}/hash.md5") input_file="${dfhack_}/hack/symbols.xml" output_file="$out/hack/symbols.xml" echo "[DFHack Wrapper] Fixing Dwarf Fortress MD5:" echo "  Input:   $input_file" echo "  Search:  $orig_md5" echo "  Output:  $output_file" echo "  Replace: $patched_md5" substitute "$input_file" "$output_file" --replace "$orig_md5" "$patched_md5" '' + lib.optionalString enableTWBT '' substituteInPlace $out/data/init/init.txt  --replace '[PRINT_MODE:2D]' '[PRINT_MODE:TWBT]' '' + '' substituteInPlace $out/data/init/init.txt  --replace '[INTRO:YES]' '[INTRO:${unBool enableIntro}]'  --replace '[TRUETYPE:YES]' '[TRUETYPE:${unBool enableTruetype}]'  --replace '[FPS:NO]' '[FPS:${unBool enableFPS}]' ''; </del> ignoreCollisions = true; }; in

Discussion:
Called from here: system: host os: multi-user?: sandbox: version: channels(root): channels(chris): nixpkgs:
I can reproduce this on system: host os: multi-user?: sandbox: version: channels(root): channels(addy): nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos
The problem seems to be, that already is a symlink. So it is no wonder that we can't edit it, as it is part of the original derivation. I'm not sure why that ever worked in the past, pkgs/build- hasn't been changed since there was an update to the dwarf-fortress derivation. I think the easiest way would to create the file in a separate derivation and add it to .
Change:
sha256 = "0jrc84lkc7xb53rb8dbswxrxj21ndj1iiclmk3r9wkp6xm55w6j8"; }; <del> nativeBuildInputs = lib.optionals stdenv.isDarwin [ which cctools ]; </del> <ins> nativeBuildInputs = [ cmake ]; </ins> patches = lib.optional stdenv.isFreeBSD ./freebsd.patch;

Discussion:
the build ends up with:
We can trivially workaround this by disabling the tests for aarch64-darwin: but it would be much better to understand the underlying issue and fix that instead
ping
Fixed by
follow-up fix in PR:
I can see two PRs disabling hardening features, and , but neither have an explanation of the problem, or why turning off hardening features was the best / correct fix? Can you explain further? I see the workarounds are still present: and It would be great to know why this is necessary for Nix. These hardening features work fine for native builds, and are used in our release binaries.
This used to fix "Killed: 9" error while running the tests, but it seems this is not helping anymore. My guess is that code signing is somehow messing with the test binaries.
I think the hardening feature was broken when building with gfortran. The issue has been fixed recently.
Still broken with "Killed: 9". Looks like binaries are not signed before .
As can be seen here, the issue is intermittent and does not appear all the time: This makes it harder to debug.
Fix in
Change:
setupHook = ./setup-hook.sh; <del> buildInputs = [ setupHook pkgconfig ] </del> <ins> depsBuildBuild = [ buildPackages.stdenv.cc ]; nativeBuildInputs = [ setupHook pkgconfig ]; buildInputs = [] </ins> ++ lib.optionals useSharedLibraries [ bzip2 curl expat libarchive xz zlib libuv rhash ] ++ lib.optional useNcurses ncurses ++ lib.optional useQt4 qt4 ++ lib.optional withQt5 qtbase; <del> depsBuildBuild = [ buildPackages.stdenv.cc ]; </del> propagatedBuildInputs = lib.optional stdenv.isDarwin ps; preConfigure = ''

Discussion:
I try to do some weird cross and notice that cmake is being rebuilt. That's odd. Here's why: -config now has a target-specific wrapper. has long had a run-time dep on package config So either we give CMake a wrapper too (ugh...) or we just remove pkg-config from of CMake. I learn towards the latter. CC and who I think the dep?
I only made some dependencies optional at some point to reduce the number of things needed to bootstrap. What's the issue exactly? If you mean moving pkgconfig to nativeBuildInputs then that sounds fine to me.
CMake is rebuilt when it's target platform changes.. Oh, I assume it had some and so it was in in purpose, but maybe it wasn't! Oh yeah, because CMake kinda bootstraps itself.
Change:
makeWrapper # Ren'Py currently does not compile on Cython 3.x. # See https://github.com/renpy/renpy/issues/5359 <del> python3.pkgs.cython_0 python3.pkgs.setuptools </del> <ins> python311.pkgs.cython_0 python311.pkgs.setuptools </ins> ]; buildInputs =

Discussion:
Package name: renpy Latest released version: 8.3.2 <!-- Search your package here: --- Current version on the unstable channel: 8.2.1. Current version on the stable/release channel: 8.2.1. <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
, libdatachannel , libvpl , qrcodegencpp <ins> , nix-update-script </ins> }: let

Discussion:
Package name: obs-studio Latest released version: 30.1 <!-- Search your package here: --- Current version on the unstable channel: 30.0.2 Current version on the stable/release channel: 29.1.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<ins> # Interactive shell helpers {#sec-shell-helpers} Some packages provide the shell integration to be more useful. But unlike other systems, nix doesn't have a standard `share` directory location. This is why a bunch `PACKAGE-share` scripts are shipped that print the location of the corresponding shared folder. Current list of such packages is as following: - `fzf` : `fzf-share` E.g. `fzf` can then used in the `.bashrc` like this: ```bash source "$(fzf-share)/completion.bash" source "$(fzf-share)/key-bindings.bash" ``` </ins>

Discussion:
This issue tracks the conversion of from Docbook to CommonMark per . If you intend to work on this conversion, please comment below! here that you intend to work on it. (Please also post if you stop working on it.) a new branch of nixpkgs master. : change to . to . the contents from Docbook to . Follow . Use existing sections for inspiration. from the folder to build the manual. the manual on your computer at after running from folder: it looks good, submit a PR and reference this issue.
Done!

This issue tracks the conversion of from Docbook to Commonmark per . If you intend to work on this conversion, please comment below! in this issue that you intend to work on it. (Please also post if you stop working on it) a new branch of nixpkgs master. : change to . to . the contents from Docbook to . Follow . Use existing sections for inspiration. from the folder to build the manual. the manual on your computer at after running from folder: it looks good, submit a PR and reference this issue.
Done!
Change:
export LC_ALL="en_US.UTF-8" export QT_QPA_PLATFORM=offscreen export QT_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}" <del> # testcli and testgui are flaky - skip them both make test ARGS+="-E 'testcli|testgui' --output-on-failure" </del> <ins> # testcli, testgui and testkdbx4 are flaky - skip them all # testautotype on darwin throws "QWidget: Cannot create a QWidget without QApplication" make test ARGS+="-E 'testcli|testgui${lib.optionalString stdenv.isDarwin "|testautotype|testkdbx4"}' --output-on-failure" </ins> runHook postCheck '';

Discussion:
See Hydra failure: I could not find anything directly keepassxc-related in the changes on hydra from last successful to first failing build. CC Also relevant: Version bump to 2.7: A fix for this issue might give a merge conflict there in the worst case, or alleviate the build problems there in the best case.
Does keepassxc depend on Qt? We're stuck on an older Qt because of the SDK version for x86_64-darwin. I think keepassxc may require a newer SDK.
mentions QT = 5.9.5.
Current version builds just fine. There's one test failure instead: I'll see if that's fixable...
Another issue though is that somehow became wrapped so can't be loaded anymore. Which may be related to the test failure... Either way, after trying to run the app, the gui just spins with 100% CPU. The cli part works just fine though.
I came across this issue because I was investigating something else, this is because of the wrap qt apps hook which wraps all the executable files, even if it's a dynamic library. This can be fixed by removing the executable flag from the library. You might be able to resolve it with something like: In the derivation. This should be fixed in the fixup script however
Change:
# added 2019-09-06 zeroc_ice = pkgs.zeroc-ice; <ins> # added 2020-06-22 zeromq3 = throw "zeromq3 has been deprecated by zeromq4."; jzmq = throw "jzmq has been removed from nixpkgs, as it was unmaintained"; </ins> } // (with ocaml-ng; { # added 2016-09-14 ocaml_4_00_1 = ocamlPackages_4_00_1.ocaml; ocaml_4_01_0 = ocamlPackages_4_01_0.ocaml;

Discussion:
, (nixos-20.03, nixos-unstable) Scanned versions: nixos-20.03: ; nixos-unstable: . May contain false positives.
According to this comment , should not be affected. Nontheless, this is a very old version and there are only two packages depends on it: rzmq (apparently supports 4.x but is broken since 2016) jzmq (support 3.x and looks unmaintained) jzmq is only needed by apache stom but the dependecy as since been dropped: see can you update apache storm so we can get rid of jzmq?
Change:
in buildPythonApplication rec { pname = "ocrmypdf"; <del> version = "8.2.3"; </del> <ins> version = "9.0.3"; </ins> disabled = ! python3Packages.isPy3k; src = fetchFromGitHub { owner = "jbarlow83"; repo = "OCRmyPDF"; rev = "v${version}"; <del> sha256 = "1ldlyhxkav34y9d7g2kx3d4p26c2b82vnwi0ywnfynb16sav36d5"; </del> <ins> sha256 = "1qnjdcbwkxxqfahylzl0wj1gk51yi9m8akd4d1rrq37vg2vwdkjy"; </ins> }; nativeBuildInputs = with python3Packages; [

Discussion:
Describe the bug ocrmypdf doesn't work until I also install . To Reproduce Steps to reproduce the behavior: 't have installed or in PATH. one of: Additional context Running nixpkgs master Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(at): channels(play): nixpkgs: Maintainer information: cc
I'm really swamped right now but I do need to do some updates that were requested to be in the PR before it got merged. I was half expecting someone to find problems anyway (it was really, really difficult to even get it to work at all). I'll try to get around to fixing it ASAP... which might be in a few days... if nobody does it sooner. Sorry about it not working!
No, thank you for packaging it! I successfully used it today :-)
This should be fixed as of the upgrade I did to 9.0.3. would you mind testing it to confirm it truly is fixed? It's in nixos-unstable now. After that we can close this! :D
Thanks! This does look fixed in master.
Change:
sha256 = "014igqm5vwswz0yhz0cdxsj3a6dh7i79hvhgc3jmmmz3z0xm1gyn"; }; <ins> patches = [ ./0001-fix-2131.patch ]; </ins> buildInputs = [ python fixDarwinDylibNames ]; propagatedBuildInputs = [ python.pkgs.setuptools ]; enableParallelBuilding = true;

Discussion:
Running on unstable gives the following: system: host os: multi-user?: sandbox: version: channels(swflint): channels(root): nixpkgs: Please run and paste the results.
Fixed upstream: Z3Prover/z3.
I believe closes this.
Change:
{ branch ? "stable", callPackage, fetchurl, lib, stdenv }: let versions = if stdenv.isLinux then { <del> stable = "0.0.26"; </del> <ins> stable = "0.0.27"; </ins> ptb = "0.0.42"; canary = "0.0.151"; development = "0.0.216";

Discussion:
Package name: Discord Latest released version: 0.0.27 <!-- Search your package here: --- Current version on the unstable channel: 0.0.26 Current version on the stable/release channel: 0.0.26 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Surprised that an auto-update didn't catch this one.
Change:
description = "A plugin that changes the default look and feel of py.test"; homepage = https://github.com/Frozenball/pytest-sugar; license = licenses.bsd3; <ins> # incompatible with pytest 3.5 # https://github.com/Frozenball/pytest-sugar/issues/134 broken = true; # 2018-04-20 </ins> }; }

Discussion:
has a test failure and won't install.
That's a known upstream issue:
I guess you didn't initially try to build pytest-sugar but some other package. That one should build fine once is merged.
thanks for looking into this. :)
Change:
###### implementation config = mkIf cfg.enable { <del> location.provider = "geoclue2"; </del> environment.systemPackages = [ package ]; services.dbus.packages = [ package ];

Discussion:
Fails to begin evaluation example failure : example PR (if still relevant): cc
There seems to be also an error in nixpkgs, where building nixos results in infinite recursion, but it seems to be independent of this issues, as error persists, even if i rebase on nixos-unstable branch??
offending commit: cc
this seems to concur with the
actually, the other offending line is in I think that's setting to enable, which then causes the geoclue2 to reset the provider to geoclue, which then causes infinite recursion.
Seems like the main issue is that we have 2 ways of declaring that geoclue2 should be used: location.provider I think the correct course of action would be to eliminate one of these options. Seeing as location.provider is stringly typed, and only used to set , I think it can be removed.
Change:
{ stdenv , buildPythonPackage , fetchFromGitHub <ins> , fetchpatch </ins> , python , bootstrapped-pip , lib

Discussion:
Try to build for . Note, I'm trying staging because is necessary. fails: staging is at :
This was caused by setuptools 60, which now uses bundled distutils. All Python packages with extension modules fail to cross-compile currently, but this will be fixed by . I also noticed that the libbtrfsutil Python bindings are never actually installed, so I also created .
Change:
# https://github.com/jellyfin/jellyfin/issues/610#issuecomment-537625510 license = licenses.gpl2Plus; maintainers = with maintainers; [ nyanloutre minijackson purcell jojosch ]; <ins> mainProgram = "jellyfin"; </ins> platforms = dotnet-runtime.meta.platforms; }; }

Discussion:
I currently run Jellyfin in a Docker container but want to deploy it using an ephemeral NixOS container. However, does not expose a option and runs Jellyfin with where . I understand that this directory will be cleared when the container restarts. I'm not familiar with 's nor the aggressive sandboxing. Need I consider something else when adding the option other than user permissions?
I am experimenting with this, I just some options for defining a and a . It seems to "just work tm", but is there anything I should be aware of? I'll run my own nixpkgs branch on my own machine for a little bit before creating a PR, but so far it seems fine.
I looked a bit into this, and I think bind mounts is what works best with systemd. But I didn't really find a lot of info...
Relevant:
I'm interested in this as well. Currently the Sonarr, Radarr, Jackett, and Ombi services provide . Is the approach they use also usable here?
Change:
"zpool create rpool /dev/vda2", "zfs create -o mountpoint=legacy rpool/root", "mount -t zfs rpool/root /mnt", <ins> "zfs create -o mountpoint=legacy rpool/root/usr", "mkdir /mnt/usr", "mount -t zfs rpool/root/usr /mnt/usr", </ins> "udevadm settle", ) '';

Discussion:
, but for resulting in failing in one of the first steps of the initdr boot process. Didn't try replicating it anywhere else and I'm not sure why it doesn't fail on zfs mounts as opposed to mounting through zfs I expect system to boot properly If applicable, add screenshots to help explain your problem. My setup is: failing computer uses mountpoints instead of the one I'm writing from has mounts nad works fine After yesterday's update (roughly 1-2 weeks since previous nixpkgs-unstable update) I'm getting failure before gets decrypted and it drops into emergency shell after decrypting volume. In an emergency shell I can just followed by and it boots properly. Might be related/the same issue, but previously (nixpkgs-unstable from between 2week ago to month ago) I was often getting random boot process hangups: it was pending for some unit I couldn't see without failing/dropping into emergency shell. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
Change:
pytestFlagsArray = [ "--timeout=0" ]; # Fixes hanging tests on Darwin __darwinAllowLocalNetworking = true; <ins> disabledTests = [ # https://github.com/microsoft/debugpy/issues/1241 "test_flask_breakpoint_multiproc" ]; </ins> pythonImportsCheck = [ "debugpy" ];

Discussion:
Steps to reproduce the behavior: on latest Nixpkgs master (See ). Tracked upstream:
Oh nice catch! I'll try a git bisect on the to try to narrow down the cause.
Forgot I was running this in the background :sweat_smile: - tracked it down to the :
debugpy doesn't depend on etils
Oh yep, it was probably just a bad automatic bisect then, I'll try manually.
Ok, I just ran it again and it just looks like there was just an unrelated error in one of the commits it sampled before: If this wasn't going to work I was thinking of adding failing inputDrvs as a skip condition. Didn't need to, but it'll be helpful for next time!
Change:
maintainers = with maintainers; [ astsmtl antono ] ++ teams.gnome.members; platforms = platforms.unix; }; <del> } </del> <ins> }) </ins>

Discussion:
They apparently fixed the issue where the cursor wouldn’t show up in new tabs. Needs backport to 23.11. Thanks! Package name: vte Latest released version: 0.74.2 Current version on the unstable channel: 0.74.1 Current version on the stable/release channel: 0.74.1 Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
accounts-qt = callPackage ../development/libraries/accounts-qt { }; appstream-qt = callPackage ../development/libraries/appstream/qt.nix { }; <ins> drumstick = callPackage ../development/libraries/drumstick { }; </ins> fcitx5-chinese-addons = callPackage ../tools/inputmethods/fcitx5/fcitx5-chinese-addons.nix { }; fcitx5-configtool = kdePackages.callPackage ../tools/inputmethods/fcitx5/fcitx5-configtool.nix { };

Discussion:
Package name: kmetronome Latest released version: 1.4.0 Current version on the unstable channel: 1.2.0 Current version on the stable/release channel: 1.2.0 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
); preStop = if cfg.backend == "podman" <del> then "[ $SERVICE_RESULT = success ] || podman stop --ignore --cidfile=/run/podman-${escapedName}.ctr-id" else "[ $SERVICE_RESULT = success ] || ${cfg.backend} stop ${name}"; postStop =  if cfg.backend == "podman" </del> <ins> then "podman stop --ignore --cidfile=/run/podman-${escapedName}.ctr-id" else "${cfg.backend} stop ${name}"; postStop = if cfg.backend == "podman" </ins> then "podman rm -f --ignore --cidfile=/run/podman-${escapedName}.ctr-id" else "${cfg.backend} rm -f ${name} || true";

Discussion:
I ran into an issue when playing with oci-containers. Stopping the containers results in a coredump for some containers, because the monitor process is killed with the rest of the cgroup. Playing with the stop script and looking at the systemd unit generated with the problem seems to be the check for : This will only run if the result is not "success". But "success" is the normal value when succeeded. Maybe this should use ? Then if the container exited with an error by itself the would not run. No such check is present in the podman generated unit: The same is used for docker, so probably the same error there.
Change:
stdenv.mkDerivation rec { name = "libivykis-${version}"; <del> version = "0.40"; </del> <ins> version = "0.41"; </ins> src = fetchurl { url = "mirror://sourceforge/libivykis/${version}/ivykis-${version}.tar.gz"; <del> sha256 = "1rn32dijv0pn9y2mbdg1n7al4h4i5pwwhhihr9pyakwyb6qgmqxj"; </del> <ins> sha256 = "1igk3svf36i5xgb6ipc507xpj6zjm4xi9j1j2cdqaachllwlb4rc"; </ins> }; nativeBuildInputs = [ autoreconfHook pkgconfig ];

Discussion:
I'm upgrading my systems from NixOS 16.03 to 16.09 and I'm trying to get syslog-ng working again. It's currently configured as: The issue is that systemd is not noticing that syslog-ng has started: I do see that syslog-ng is running: Note that the systemd syslog-ng service is with This that syslog-ng should notify systemd when it has started up. My current hypotheses is that with the systemd upgrade to 231 something in the notification protocol has changed causing the syslog-ng notification to fail.
It has strange config: how could this work ? could you test this? syslog-ng at least starts for me
thanks with those changes syslog-ng starts up correctly.
means that the syslog-ng unit will be activated (started) if gets activated. By itself this relation defines no order. That's why you can add and relations as you wish. As I've mention in , the root problem is that our current version of syslog-ng can't be built with our current version of systemd and thus the sd-notify feature is not present.
Hi I did some work on the syslog-ng upgrade. I've managed to get syslog-ng-3.9.1 to build with I will now test this a bit.