jiebi/CodeConvo huggingface dataset:
Change:
# helpers <del> wrapPython = callPackage ../development/interpreters/python/wrap-python.nix {inherit python; inherit (pkgs) makeSetupHook makeWrapper; }; </del> <ins> # We use build packages because we are making a setup hook to be used as a # native build input. The script itself references both the build-time # (build) and run-time (host) python from the explicitly passed in `python` # attribute, so the `buildPackages` doesn't effect that. wrapPython = pkgs.buildPackages.callPackage ../development/interpreters/python/wrap-python.nix { inherit python; }; </ins> # Dont take pythonPackages from "global" pkgs scope to avoid mixing python versions pythonPackages = self;

Discussion:
Describe the bug Evaluation breaks with cross-compilation and . Note that () changes nothing here. To Reproduce On: Expected behavior It at least evaluates and tries to build. Notify maintainers as cross-compilation buffs for python things, but just if it looks related to our python infra internals. This is a regression coming from . Reverting fixes eval. It looks like gets hella confused* somehow, here it is traced with some shenanigans: I would expect to contain a bit more than a mostly empty .
Change:
<ins> { fetchzip, lib }: let version = "0.0.20060226"; in fetchzip { name = "lao-${version}"; url = "mirror://debian/pool/main/f/fonts-lao/fonts-lao_${version}.orig.tar.xz"; sha256 = "sha256-Ti3DNOgLR5VBJ1mSe8M+qs4UYbCR7qOPgqxRfmHa+jY="; postFetch = '' mkdir -p $out/share/fonts tar xf $downloadedFile --strip-components=1 -C $out/share/fonts fonts-lao-${version}/Phetsarath_OT.ttf ''; meta = with lib; { description = "TrueType font for Lao language"; license = licenses.gpl2Plus; maintainers = with lib.maintainers; [ serge ]; platforms = platforms.all; }; } </ins>

Discussion:
Project description The package contains TrueType fonts for Lao language. Metadata homepage URL: source URL: license: gpl2+ platforms: all
Change:
User = "minio"; Group = "minio"; LimitNOFILE = 65536; <ins> EnvironmentFile = if (cfg.rootCredentialsFile != null) then cfg.rootCredentialsFile else if ((cfg.accessKey != "") || (cfg.secretKey != "")) then (legacyCredentials cfg) else null; </ins> }; environment = { MINIO_REGION = "${cfg.region}"; MINIO_BROWSER = "${if cfg.browser then "on" else "off"}"; <del> } // optionalAttrs (cfg.accessKey != "") { MINIO_ACCESS_KEY = "${cfg.accessKey}"; } // optionalAttrs (cfg.secretKey != "") { MINIO_SECRET_KEY = "${cfg.secretKey}"; </del> }; };

Discussion:
Describe the bug The minio service set environment variables - which are . This is the release currently used hence the breakage. Tested on To Reproduce Expected behavior It should be possible to login with the provided key.
thanks for the report! In future please tag maintainers so they actually see the issue, no one watches all nixpkgs issues :sweat_smile:
While the variables are deprecated, they are by minio. So I'm not sure this is really the cause of the breakage. However I will update the module to make use of the new variables and maybe even rename (or alias) the current options to make it consistent.
Yeah minio (on unstable) seems to be working just fine for me, but updating the variables seems to be the proper thing to do.
I implemented a the change in
Change:
stdenv.mkDerivation rec { name = "audacious-${version}"; <del> version = "3.8"; </del> <ins> version = "3.8.2"; </ins> src = fetchurl { url = "http://distfiles.audacious-media-player.org/audacious-${version}-gtk3.tar.bz2"; <del> sha256 = "0rpdzf9pb52lcswxypwh4nq3qkjzliw42v39nm5rlwwxdq6bm99q"; </del> <ins> sha256 = "1g08xprc9q0lyw3knq723j7xr7i15f8v1x1j3k5wvi8jv21bvijf"; </ins> }; pluginsSrc = fetchurl { url = "http://distfiles.audacious-media-player.org/audacious-plugins-${version}-gtk3.tar.bz2"; <del> sha256 = "0j9svdqdjvj5spx1vfp0m63xh8xwk8naqsikdxfxbb68xk33rxb9"; </del> <ins> sha256 = "1vqcxwqinlwb2l0kkrarg33sw1brjzrnq5jbhzrql6z6x95h4jbq"; </ins> }; nativeBuildInputs = [

Discussion:
I guess it's a political question whether Qt is an upgrade from Gtk, but for whatever reason the Qt version appears to have text in the toolbar instead of icons, so I'd like to stick with the inferior Gtk for now. nixos.audacious{,Qt5} have the same name, but versions 3.8 and 3.8.1 respectively.
What I understand from they support both. If we want to support both they should have different names.
For what it's worth, the qt/gtk separation was again abolished in . I wouldn't really blame gebner for what happened though: the upstream has indeed stated that they want to focus on Qt in the future. That said, anyone interested is still welcome to make a Qt-less build; shows it's still possible. about that focus thing: they seem to have walked it back in https://audacious-media- now gtk3 is back to "no[t] considered legacy".
Change:
''; description = '' Use this option to configure advanced authentication methods like EAP. <del> See wpa_supplicant.conf(5) for example configurations. </del> <ins> See <citerefentry> <refentrytitle>wpa_supplicant.conf</refentrytitle> <manvolnum>5</manvolnum> </citerefentry> for example configurations. </ins> Mutually exclusive with <varname>psk</varname> and <varname>pskRaw</varname>. '';

Discussion:
References to (5) should have hyperlinks to the article/section.
These are references to man pages so there can't easily be a hyperlink. I made a PR that makes sure these are referenced to using , though. So that they at least carry some semantic meaning.
My bad I didn't think about the man pages. There are man pages online, too. I found this site: but it'd be nice to have them generated into the NixOS documentation. Having the man page sources piped into HTML would be useful I not a huge space waster.
Change:
<ins> { lib , rustPlatform , fetchFromGitHub , pkg-config , libsodium , sqlite , nix-update-script , testers , rustdesk-server }: rustPlatform.buildRustPackage rec { pname = "rustdesk-server"; version = "1.1.8"; src = fetchFromGitHub { owner = "rustdesk"; repo = "rustdesk-server"; rev = version; hash = "sha256-KzIylbPe+YN513UNFuisvDAIe4kICGYDUrfURDOw/no="; }; cargoLock = { lockFile = ./Cargo.lock; outputHashes = { "async-speed-limit-0.3.1" = "sha256-iOel6XA07RPrBjQAFLnxXX4VBpDrYZaqQc9clnsOorI="; "confy-0.4.0" = "sha256-e91cvEixhpPzIthAxzTa3fDY6eCsHUy/eZQAqs7QTDo="; "tokio-socks-0.5.1" = "sha256-inmAJk0fAlsVNIwfD/M+htwIdQHwGSTRrEy6N/mspMI="; }; }; nativeBuildInputs = [ pkg-config ]; buildInputs = [ libsodium sqlite ]; passthru = { updateScript = nix-update-script { }; tests.version = testers.testVersion { inherit version; package = rustdesk-server; command = "hbbr --version"; }; }; meta = with lib; { description = "RustDesk Server Program"; homepage = "https://github.com/rustdesk/rustdesk-server"; changelog = "https://github.com/rustdesk/rustdesk-server/releases/tag/${version}"; license = licenses.agpl3Only; platforms = platforms.unix; maintainers = with maintainers; [ gaelreyrol ]; }; } </ins>

Discussion:
Self hosting server for Rust Desk remote desktop the rustdesk client app is available, but it would be great to be able to self-host. Metadata homepage URL: source URL: license: GNU AFFERO GENERAL PUBLIC LICENSE platforms: linux, windows, mac, android, ios
Wow, that was speedy. Thanks!
Change:
platforms = platforms.linux; }; nativeBuildInputs = [ extra-cmake-modules kdoctools makeWrapper ]; <del> propagatedBuildInputs = [ </del> <ins> buildInputs = [ </ins> # qt qtwebkit # kde

Discussion:
If Flac is installed, K3b should provide Flac encoder as an external audio encoder. See: is indeed a propagated build input of : So I suppose in principle it should work. However, could it be that doesn't find the executable properly on NixOS: Any ideas how to fix? Open K3b. Go to Settings -Configure K3B -Plugins Find K3B External Audio Encoder and click on the Configure icon There should be Flac option on the list, but the list is empty. Please run and paste the results.
I copied the command from the K3b link in the original post: I this as an external audio encoder. Tried to use it but the ripping stopped and showed an error immediately:
Here is a full log from the following steps: Launch K3b Choose the audio CD Choose start ripping Select Flac (that I have defined manually) as the format Start ripping Error is raised Close dialogs and exit K3b
I tried adding and on the PATH by adding them on this line: Still, the same error.
I tried with other file formats too, I still get the same error that libcdparanoia could not be loaded.
It probably uses dlopen to load . Therefore it either needs to be to LDLIBRARYPATH: or needs to be marked as required with patchelf: will not work here and is wrong.
Thanks, I made a pull request.
Change:
let pname = "pulsar"; <del> version = "1.117.0"; </del> <ins> version = "1.119.0"; </ins> sourcesPath = { x86_64-linux.tarname = "Linux.${pname}-${version}.tar.gz"; <del> x86_64-linux.hash = "sha256-iDQV4wcb+TY5qv8X6UW6PumK9+i5cn705ZzCSx5VgMs="; </del> <ins> x86_64-linux.hash = "sha256-wW+mbN+XPpqdksFrJ37eHMYccXxg9zIR139SkuawTmA="; </ins> aarch64-linux.tarname = "ARM.Linux.${pname}-${version}-arm64.tar.gz"; <del> aarch64-linux.hash = "sha256-NJc6CQA7ZCX70ui+QcVcLW2qxM05A93yqpiiW+YosGc="; </del> <ins> aarch64-linux.hash = "sha256-XSEAo/wGNdzx8MtUrCJ6U1pDoY1p+cTdVAn1NsayZW4="; </ins> }.${stdenv.hostPlatform.system} or (throw "Unsupported system: ${stdenv.hostPlatform.system}"); newLibpath = lib.makeLibraryPath [

Discussion:
Package name: pulsar Latest released version: 1.118.0 Current version on the unstable channel: 1.117.0 Current version on the stable/release channel: 1.117.0 Notify maintainers
Sorry I'm super busy these days... I'll try to get back to this as soon as possible. In the meantime, please try the of this package if you can, and see if the resulting package build fine. Thank you!
i am not familiar with updateScript and not really urgently need the latest Pulsar version, but i think update request is a good way to keep actual nixpkgs's packages version.
Change:
swaybg = callPackage ../applications/window-managers/sway/bg.nix { }; swayidle = callPackage ../applications/window-managers/sway/idle.nix { }; swaylock = callPackage ../applications/window-managers/sway/lock.nix { }; <ins> swayosd = callPackage ../applications/window-managers/sway/osd.nix { }; </ins> swayws = callPackage ../applications/window-managers/sway/ws.nix { }; swaywsr = callPackage ../applications/window-managers/sway/wsr.nix { }; sway-contrib = recurseIntoAttrs (callPackages ../applications/window-managers/sway/contrib.nix { });

Discussion:
Project description A GTK based on screen display for keyboard shortcuts like caps-lock and volume Metadata homepage URL: source URL: license: gpl3-only platforms: linux
Change:
vorta = python3Packages.callPackage ../applications/backup/vorta { }; <ins> utahfs = callPackage ../applications/networking/utahfs { }; </ins> wallutils = callPackage ../tools/graphics/wallutils { }; wev = callPackage ../tools/misc/wev { };

Discussion:
Project description UtahFS is a state-of-the art encrypted storage solution, meant to be similar to Dropbox. It has a FUSE binding that creates a synthetic drive on the user's computer that they can interact with like an external hard-drive. Files stored in the drive are uploaded to a cloud storage provider, which means the drive will never run out of space and minimizes the likelihood of any files being lost. However the files are encrypted such that the cloud storage provider knows almost nothing about what's being stored. Completely written in Go. Metadata homepage URL: source URL: license: bsd platforms: unix
Looks interesting, but we gotta wait for a official release/git tag.
Change:
}; checkInputs = [ python3.pkgs.pytest ]; <ins> nativeBuildInputs = with python3.pkgs; [ setuptools-scm ]; </ins> propagatedBuildInputs = with python3.pkgs; [ Babel

Discussion:
Describe the bug fava does not build on master since the merge of staging-next in : To Reproduce Steps to reproduce the behavior: -env -f ~/code/nixpkgs -iA fava Notify maintainers hi
Change:
--zsh <(shtab --shell=zsh -u tmuxp.cli.create_parser) ''; <del> meta = with lib; { </del> <ins> meta = { </ins> description = "tmux session manager"; homepage = "https://tmuxp.git-pull.com/"; changelog = "https://github.com/tmux-python/tmuxp/raw/v${version}/CHANGES"; <del> license = licenses.mit; maintainers = with maintainers; [ peterhoeg otavio ]; </del> <ins> license = lib.licenses.mit; maintainers = with lib.maintainers; [ otavio ]; </ins> mainProgram = "tmuxp"; }; }

Discussion:
Steps to reproduce the behavior: This package is working in 23.11 I'm using as a stopgap measure. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
please test
Change:
</listitem> <listitem> <para> <del> <filename>./services/networking/dnscrypt-proxy2.nix</filename> </para> </listitem> <listitem> <para> </del> <filename>./services/networking/go-shadowsocks2.nix</filename> </para> </listitem> <listitem> <para> <del> <filename>./services/networking/ntp/chrony.nix</filename> </para> </listitem> <listitem> <para> <filename>./services/networking/ntp/ntpd.nix</filename> </para> </listitem> <listitem> <para> </del> <filename>./services/networking/ntp/openntpd.nix</filename> </para> </listitem>

Discussion:
I have read the release notes of 20.03, here are the things i noticed: Linux kernel is updated to branch 5.4 by default (from 4.19). Users of Intel GPUs may prefer to explicitly set branch to 4.19 to avoid some regressions. Can you add a link to an open issue to see when it is fixed? At least link to "more information" e.g.: Not all entries are services. Maybe "Modules" would be more accurate? If we decide to change it, apply it to all NixOS releases. Some services are listed here, but they where just moved. For example: Best would be to update the tooling to exclude moved files and update it. The services.dnscrypt-proxy module has been removed as it used the deprecated version of dnscrypt-proxy. We've services.dnscrypt- to use the supported version. can't it be a drop-in replacement? it would be more user friendly if the new version would just be used with services.dnscrypt-proxy (i don't know the software, so it might makes sense) Update: This seems fine since the options have changed completely. It has option now. Maybe mention that the options have changed. Like "options are now organized using a settings option" or something like that to make it really clear fixed small typo myself (backported in )
I was hoping to do/address all these things :+1:
Change:
homepage = "https://rogueamoeba.com/soundsource"; license = licenses.unfree; sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; <del> maintainers = with maintainers; [ emilytrau ]; </del> <ins> maintainers = with maintainers; [ emilytrau donteatoreo ]; </ins> platforms = platforms.darwin; }; })

Discussion:
Package name: soundsource Latest released version: 5.7.1 <!-- Search your package here: --- Current version on the unstable channel: 5.6.3 Current version on the stable/release channel: 5.6.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
inherit (lxqt) qtermwidget; }; <ins> ctx = callPackage ../applications/terminal-emulators/ctx { }; </ins> darktile = callPackage ../applications/terminal-emulators/darktile { }; eterm = callPackage ../applications/terminal-emulators/eterm { };

Discussion:
Project description A UTF-8 vector graphics and audio capable terminal. Not a high priority, already available in Flatpak. But it seems cool, so just want to get it in the pkg queue. Metadata homepage URL: https://ctx.graphics/terminal/ source URL: license: terminal GPLv3+, renderer LGPLv3+ platforms: linux, darwin
Change:
homepage = "https://github.com/tramhao/termusic"; license = with lib.licenses; [ gpl3Only ]; maintainers = with lib.maintainers; [ devhell ]; <ins> mainProgram = "termusic"; </ins> }; }

Discussion:
Package name: termusic Latest released version: <!-- Search your package here: --- Current version on the unstable channel: 0.7.11 Current version on the stable/release channel: 0.7.11 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --I attempted to update this package myself and create a PR, however, I'm getting an error when building the cargo dependency and doesn't appear to be any issues reported for building either it or termusic, so I am unsure how to proceed. Cargo Error: Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
## types.functionTo checkConfigOutput '^"input is input"$' config.result ./functionTo/trivial.nix checkConfigOutput '^"a b"$' config.result ./functionTo/merging-list.nix <del> checkConfigError 'A definition for option .fun.[function body]. is not of type .string.. Definition values:ns*- In .*wrong-type.nix' config.result ./functionTo/wrong-type.nix </del> <ins> checkConfigError 'A definition for option .fun.<function body>. is not of type .string.. Definition values:ns*- In .*wrong-type.nix' config.result ./functionTo/wrong-type.nix </ins> checkConfigOutput '^"b a"$' config.result ./functionTo/list-order.nix checkConfigOutput '^"a c"$' config.result ./functionTo/merging-attrs.nix checkConfigOutput '^"a bee"$' config.result ./functionTo/submodule-options.nix <del> checkConfigOutput '^"fun.[function body].a fun.[function body].b"$' config.optionsResult ./functionTo/submodule-options.nix </del> <ins> checkConfigOutput '^"fun.<function body>.a fun.<function body>.b"$' config.optionsResult ./functionTo/submodule-options.nix </ins> # moduleType checkConfigOutput '^"a b"$' config.resultFoo ./declare-variants.nix ./define-variant.nix

Discussion:
doesn't quote attributes containing periods, so the output is identical for e.g. and . Steps to reproduce the behavior: It should return . Instead it returns . It also doesn't include quotes for components containing other non-attribute-valid chars such as spaces. This is more of an aesthetic issue as is unambiguous, though it bothers me. Not quoting components containing periods is a correctness issue. Right now it calls and checks if the output is identical to . It does have comments explaining that it allows options starting with digits, as well as placeholders like <namelib.strings.escapeNixIdentifierlib.strings.escapeNixIdentifier` and then modifying the regex to allow these additional values. My suggestion for such a regex is something like . This way most punctuation and all whitespace will cause quoting but it will still allow and . Alternatively it could be more conservative and only quote for spaces and periods, but it seems more reasonable to me to quote for arbitrary punctuation as well.
Note that my suggested regex takes advantage of the fact that doesn't seem to be unicode-aware, in that succeeds. This seems like a bug, so if Nix ever gains unicode support here, this might have to be modified to explicitly allow either common placeholder chars or just all non-ASCII chars.
This relates to and
Change:
<ins> { lib , stdenv , fetchFromGitHub , rustPlatform , Security , testers , git-stack }: rustPlatform.buildRustPackage rec { pname = "git-stack"; version = "0.10.12"; src = fetchFromGitHub { owner = "gitext-rs"; repo = "git-stack"; rev = "v${version}"; hash = "sha256-ghH3wmXLPzJZ4lNXFwEGKD89r7xaRMXUe9kGHm7MC4s="; }; cargoHash = "sha256-5FXcReXgq5LFysPGBuYawFdkYAgRHsW+p2Ytin4+ZxI="; buildInputs = lib.optionals stdenv.isDarwin [ Security ]; # Many tests try to access the file system. doCheck = false; passthru.tests.version = testers.testVersion { package = git-stack; }; meta = with lib; { description = "Stacked branch management for Git"; homepage = "https://github.com/gitext-rs/git-stack"; changelog = "https://github.com/gitext-rs/git-stack/releases/tag/v${version}"; license = licenses.asl20; maintainers = with maintainers; [ stehessel ]; }; } </ins>

Discussion:
Stacked branch management for Git git-stack helps automate a lot of common workflows when dealing with PRs, especially when you start to create PRs on top of PRs. Metadata homepage URL: source URL: license: mit platforms: all
Thank you
Change:
enableParallelBuilding = true; <ins> preConfigure = '' configureFlagsArray+=("--syslibdir=$out/lib") ''; </ins> configureFlags = [ "--enable-shared" "--enable-static"

Discussion:
This derivation isn't usable because it looses track of a key file. has to be available. Otherwise anything built with will fail to run with the mysterious error. This might present a particular problem for since it has to be an absolute path to the interpreter. Anything built with will need it's interpreter set to the absolute path of in the nix store.
I take it back. It's not totally unusable. You can compile like . It's just dynamic linking which it can't handle. Might be interesting to try to build a completely statically linked system this way.
I think it will be as simple as modifying , this line: needs to point to the nix store and needs to be in the store.
It would suffice to pass to but that would mean knowing before you build your ultimate path in the nix store. I don't know if it's possible to calculate that ahead of time but I guess probably not.
ah, i was correct initially (i deleted my comment out of fear of lying) the output store path is available in the variable in stdenv build scripts (set by etc). Even if you set the argument to stdenv, you can and then this variable will be available to you
remember, the output path is computed as a function of the inputs to a package, not a hash of its output. you can notice this if your build is not deterministic, and you end up with different binaries under the same store path on separate computers
Thanks I'm still figuring it out. No matter what I do, I can't get get configureFlags or configurePhase to pass the interpolated value of . It just ends up literally configuring it as . I did have success using a builder script. This clunky solution works, but I'm sure it's not how the pros do it.
Fixed