jiebi/CodeConvo huggingface dataset:
Change:
prefix ${strAddr cfg.ipv6.pool} dynamic-pool ${strAddr cfg.ipv4.pool} data-dir ${cfg.dataDir} <ins> ${concatStringsSep "n" (mapAttrsToList (ipv4: ipv6: "map " + ipv4 + " " + ipv6) cfg.mappings)} </ins> ''; addrOpts = v:

Discussion:
When using the provided tayga service, it's not really possible to setup explicit mappings. This seems like an oversight. N/A Some sort of should exist. N/A It is possible to workaround the issue by sticking them into but... uh yeah anyway. :sweat_smile: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (?) Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
}; system.nssModules = optional cfg.enable pkgs.sssd; <del> services.nscd.config = builtins.readFile ./nscd-sssd.conf; </del> services.dbus.packages = [ pkgs.sssd ]; })

Discussion:
Currently, seems to be broken. I thought this was a systemd issue, but they claim it's because we misconfigured . However, I thought we configured this correctly since since this commit and seems to indeed confirm this. Yet is still currently broken in . I have a feeling isn't correctly loading that aren't shipped with . This would mean and aren't loaded either if that's the case Please run and paste the results.
Related
Also related:
Also related: It seems like isn't properly loading all
When I run It seems to try to load all the from a very strange_ location, confirming my suspicion that isn't loading any of the NSS modules out side of Anything but the right place. So loading custom modules seems to be broken.
Okay so it actually does seem to load the libraries, after suggestion from Then why is not working?
cc
Also cc who originally fixed this
You can use and watch for dbus calls named to the service
In you should see a unix socket connection opened to dbus follow by system calls on the resulting file descriptor.
The call is being made. I more and more suspect this being a systemd issue
The response looks as expected.
Indeed. so why is the systemd unit then failing on ?
Ah I also get this in the logs: Here is the full trace:
This error seems to be coming from which leads us to:
After hacking around with this turns out to be a cache invalidation problem. See Since we only use for tricking to load nss modules from an absolute path, and actually not for its caching behaviour the recommended course of action seems to be to disable all caching that provides (at least for passwd and group, perhaps not for host) This is already disabled when is enabled () So the simplest option seems to be to also use this config when is disabled. Note (this should probably be documented somewhere) we can't fully disable the cache, as then will not preload the , and delegate that to instead, which will cause to not be able to find the modules, as they are not in the global . To trick into loading these modules from a pure path, we enable caching but set all to .
Awesome detective work!
Since upstream systemd merged their nscd cache invalidation fix and released it in v240, and we're on v242 now, should some caching be turned on again?

Seems to me like it'd be nice, but I can't imagine getent lookups are hugely performance-critical. :man_shrugging: Either way though, perhaps you folks would be good reviewers for my pull request , which gets rid of various years-old cruft from the nscd module. If non-zero TTLs are still worth-while, I'd hope my patches would be merged first.
Change:
librttopo libspatialite libxml2 <ins> libz </ins> minizip proj readosm

Discussion:
Steps to reproduce the behavior: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
The build fails with
Adding to the buildInputs fixes the issue, I'll create a PR…
Mind giving the PR commit a try,
Supah! Now I can continue setting up valhalla. :+1:
Happy I could help, a review and formal approval on would greatly be appreciated and help move the PR addressing this issue forward
Change:
gconf = pkgs.gnome2.GConf; }; <del> # only kept for zed, see https://github.com/NixOS/nixpkgs/issues/37361 nwjs_0_9 = callPackage ../development/tools/node-webkit/nw9.nix { gconf = pkgs.gnome2.GConf; }; </del> # only kept for nixui, see https://github.com/matejc/nixui/issues/27 nwjs_0_12 = callPackage ../development/tools/node-webkit/nw12.nix { gconf = pkgs.gnome2.GConf;

Discussion:
zed uses the binary release of (at this time still called ), while the newest version is . As this is basically a Chromium binary that can execute arbitrary Javascript and deliberately breaks all sandboxing features, we should at least keep it on a current version. cc I’m pushing an update of to 0.26 at the moment, but the package can’t handle it, so I’m pinning to for the time being.
Hi Thanks a lot for working on this. It's been a while ago since I worked on this part of , but I slightly remember that I had to deal with several outdated versions when dealing with . I'll definitely have a look into this in the next days, hopefully there's a patch by some contributors (or it's easy to file one to fix this). However the project isn't too active, so at least when we suffer from more further breaks or security issues because of severely outdated dependencies, we shouldn't hesitate to mark this package as broken or even drop it entirely (unless there are folks heavily relying on this).
I’d be in favor of a drop; people will complain if they still use it, if that happens we can restore & update, or the package is pulled outside of nixpkgs until someone can push and maintain a recent update.
In fact I agree with you, I've observed this "restore & update" pattern with some bigger applications (especially web-services) and I think that this is unneeded extra-work for the nixpkgs maintainers and release managers before each release. Before I file a patch to either {drop it,mark it as broken} or fix the dependency issue, I'd like to check two things before: is there any active fork? I'd like to ensure that the project is actually dead/unresponsive or does it have a working/maintained fork? check in the IRC if there are active users (I don't use it, I just fixed the derivation to help to get rid of ). If there are any, we should ask them to take over maintenance (or ask them to create their own overlay) I'll try to have a deeper look into it tonight, when I know more and have an actual opinion on how to proceed, I'll leave a comment here.

As far as I know, the author is no longer actively developing Zed anymore: I happen to know him personally, but as far as I know he has no interests in doing any major additional developments any time soon. Of course, I can always ask but I think I already know the answer. :) For me it's fine if it gets removed.
ok I suspected something like this as the last commit was from 2015. In this case I'm also :+1: for dropping it...
just submitted a PR for now, I asked in the IRC if there are any folks using , if I don't get a response, I'd just vote for merging it to master and do a backport to 18.03
Change:
sed "s# $(basename "$tool") # $tool #g" -i "$out"/bin/* done <ins> substituteInPlace $out/bin/xdg-open  --replace "/usr/bin/printf" "${coreutils}/bin/printf" substituteInPlace $out/bin/xdg-mime  --replace "/usr/bin/file" "${file}/bin/file" </ins> sed 's# which # type -P #g' -i "$out"/bin/* '';

Discussion:
To make sure that we are on the same page: Kernel: System: Nix version: Nixpkgs version: leads to error: should correctly recognize file type (as through command), but it fails with error 4 should return for pdf-file as command. Described above. I noticed that for installed xdg-utility is just a bash script and there is command inside funtion. gives May be this is the reason.
Change:
changelog = "https://github.com/intel/media-driver/releases/tag/intel-media-${version}"; license = with licenses; [ bsd3 mit ]; platforms = platforms.linux; <del> maintainers = with maintainers; [ primeos jfrankenau ]; </del> <ins> maintainers = with maintainers; [ primeos jfrankenau SuperSandro2000 ]; </ins> }; }

Discussion:
The build of fails on i686. Fails with: Found with Please run and paste the result. Maintainer information:
if you don't ping any maintainer likely nothing will happen ping
I think I never tried compiling intel-media-driver on i686 but only fixed an eval error in nixGL. The problem seems to be that it compiles 64 bit code on 32 bit.
I did a quick look what other distros do and found this helpful Debian patch () at least fixes. There are still some other compile errors that need fixing. Edit1: and with it compiles
Change:
{ lib, stdenv, buildGoModule, fetchFromGitHub <ins> , nixosTests </ins> , pkg-config, taglib, zlib # Disable on-the-fly transcoding,

Discussion:
Project description music streaming server / subsonic server API implementation Metadata homepage URL: source URL: license: gpl3 platforms: linux package: The package is already there, maintained by It'd be nice to have a module too!
I can submit a module PR once is merged, as it adds some new options (filesystem watcher).
Change:
, qtmultimedia , qtlocation , qqc2-desktop-style <ins> , kirigami-addons </ins> , kirigami2 <ins> , kio </ins> , knotifications <ins> , kquickimageedit </ins> , zxing-cpp , qxmpp , sonnet

Discussion:
Steps to reproduce the behavior: kaidan <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thanks for notifying me!
Change:
modules = toList modules; }; <ins> # The type of a type! optionType = mkOptionType { name = "optionType"; description = "optionType"; check = value: value._type or null == "option-type"; merge = loc: defs: let # Prepares the type definitions for mergeOptionDecls, which # annotates submodules types with file locations optionModules = map ({ value, file }: { _file = file; # There's no way to merge types directly from the module system, # but we can cheat a bit by just declaring an option with the type options = lib.mkOption { type = value; }; } ) defs; # Merges all the types into a single one, including submodule merging. # This also propagates file information to all submodules mergedOption = fixupOptionType loc (mergeOptionDecls loc optionModules); in mergedOption.type; }; </ins> submoduleWith = { modules , specialArgs ? {}

Discussion:
See the : the options aren't declared by any file (it's actually , but that's stripped at some point). I think this is most likely because they are declared inside a : but I don't know the module system well enough to troubleshoot this. This was causing the unstable channel import to because of an which should be fixed by This is an issue of the module system, so pinging
fixes this, thanks for the report!
Change:
</programlisting> </para> </listitem> <ins> <listitem> <para> The <xref linkend="opt-services.postgresql.dataDir"/> option is now set to <literal>"/var/lib/postgresql/${cfg.package.psqlSchema}"</literal> regardless of your <xref linkend="opt-system.stateVersion"/>. Users with an existing postgresql install that have a <xref linkend="opt-system.stateVersion"/> of <literal>17.09</literal> or below should double check what the value of their <xref linkend="opt-services.postgresql.dataDir"/> option is (<literal>/var/db/postgresql</literal>) and then explicitly set this value to maintain compatibility: <programlisting> services.postgresql.dataDir = "/var/db/postgresql"; </programlisting> </para> </listitem> </ins> </itemizedlist> </section>

Discussion:
Describe the bug A clear and concise description of what the bug is. I have The error I got when starting the service is:
The folder is owned by user postgres:
what are the permissions on ?
it's
it works if I set it to but is created by the build/installation. why doesn't it set the right permission?
Looks line should be a one time required step and you're good to go :+1: Looks like with both and together pushes permissions up to all new parent directories. The module is still using (which is deprecated) so the module should be updated to remove that and fix your issue at the same time. Thanks for reporting!
Thank you for your help!
Change:
<ins> { stdenv , lib , fetchurl , copyDesktopItems , makeDesktopItem , makeWrapper , jre , libpulseaudio , libXxf86vm }: let desktopItem = makeDesktopItem { name = "unciv"; exec = "unciv"; comment = "An open-source Android/Desktop remake of Civ V"; desktopName = "Unciv"; categories = "Game;"; }; envLibPath = lib.makeLibraryPath [ libpulseaudio libXxf86vm ]; in stdenv.mkDerivation rec { pname = "unciv"; version = "3.12.8"; src = fetchurl { url = "https://github.com/yairm210/Unciv/releases/download/${version}/Unciv.jar"; sha256 = "178lasa6ahwg2s2hamm13yysg42qm13v6a9pgs6nm66np93nskc7"; }; dontUnpack = true; nativeBuildInputs = [ copyDesktopItems makeWrapper ]; installPhase = '' runHook preInstall makeWrapper ${jre}/bin/java $out/bin/unciv  --prefix LD_LIBRARY_PATH : ${envLibPath}  --prefix PATH : ${lib.makeBinPath [ jre ]}  --add-flags "-jar ${src}" runHook postInstall ''; desktopItems = [ desktopItem ]; meta = with lib; { description = "An open-source Android/Desktop remake of Civ V"; homepage = "https://github.com/yairm210/Unciv"; maintainers = with maintainers; [ tex ]; license = licenses.mpl20; platforms = [ "x86_64-linux" ]; }; } </ins>

Discussion:
Project description Open-source Android/Desktop remake of Civ V Metadata homepage URL: source URL: license: Mozilla Public License 2.0 platforms: linux, darwin, windows, android
I marked this as stale due to inactivity. &rarr;
Change:
# Avoid using pybind11 from git submodule # Also avoids pytorch exporting the headers of pybind11 <del> USE_SYSTEM_BIND11 = true; </del> <ins> USE_SYSTEM_PYBIND11 = true; </ins> preBuild = '' export MAX_JOBS=$NIX_BUILD_CORES

Discussion:
Instead of setting , we set :
I suspect that this is related: when I create a python environment with both and in it: I am running into a collision like this: The hypothesis is that torch was using its own pybind11 instead of the "system" pybind11, leading to this collision.
Confirmed that by having the overlay with The collision issue is gone. Is there any caveats that I should pay attention to before submitting a PR for this?
not that I'm aware of -- I should be able to merge it fairly quickly if you do, just tag me as a reviewer and I'll get to it ASAP.
Sure, I have created It seems that I cannot assign reviewers at this moment.
Change:
sourceRoot = "source/Kvantum"; <ins> patches = [ (fetchpatch { # add xdg dirs support url = "https://github.com/tsujan/Kvantum/commit/01989083f9ee75a013c2654e760efd0a1dea4a68.patch"; hash = "sha256-HPx+p4Iek/Me78olty1fA0dUNceK7bwOlTYIcQu8ycc="; stripLen = 1; }) ]; </ins> postPatch = '' # Fix plugin dir substituteInPlace style/style.pro 

Discussion:
Describe the bug Besides the included themes, Kvantum manager is does not allow the user to select other themes installed from packages like or . To Reproduce Steps to reproduce the behavior: Kvantum manager and try to select Arc theme Expected behavior Being able to select an installed theme. Screenshots As you can see the themes Adapta and AdaptaNokto do not appear in the drop down menu, even though they are installed in the correct folder. ! Metadata Please run and paste the result. Maintainer information:
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
still important to me
I marked this as stale due to inactivity. &rarr;
Here is a patch that adds XDGDATADIRS support for theme lookup paths: Would be nice to submit a PR upstream, but if you take a look at the code: it's just impenetrable. If time allows, I'll try to submit a PR making the code more maintainable and the submit this patch (if the author agrees).
Change:
description = "List files recursively"; license = licenses.mit; platforms = platforms.all; <del> maintainers = [ ]; </del> <ins> maintainers = with maintainers; [ vika_nezrimaya ]; </ins> }; }

Discussion:
Someone asked in #nixos today for a list of packages without maintainers. I don't know of one so I made this : ) Behold, the Approximate List of Unmaintained Packages: This is 168 unmaintained packages. Some that caught my eye, , , , , and . Command I used to produce this approximate list (there's false positives and probably negatives alike): Alternative by Graham (not sure where to get , probably fewer false negatives but more false positives:
Python has some maintainers assigned - looking deeper at Nix expressions, cpython is maintained by PyPy is maintained by GNU Tar, zip, rxvt_unicode, bzip2 and ed indeed lack a maintainer.
Note that certain packages have a special deriver that automatically adds a maintainer. I think a clearer way to check what packages have no maintainers is to use or perhaps using nix directly would be even better.
I did try this , which yields a longer (includes some false positives such as automatically generated derviations).
All emacs packages without maintainers were dropped as a part of
Closing this because there isn't anything actionable and the list is not entirely accurate either. Note that, when talking about maintained or not, there are many core packages maintained by only few. It would be very important if those packages get more maintainers. An example is .
the actionable part would be setting up a webpage that allows people to easily find packages that aren't maintained or have few maintainers. Using maybe some stats from the binary cache or about version lag to indicate which packages have a greater need of maintainers.
Now since a few maintainers have left leaving many packages without maintainers, I think this has to be a priority.
Cross-posting for reference since I stumbled across this, there is/was an RFC regarding this topic:
Change:
meta = { homepage = https://github.com/cedadev/ndg_httpsclient/; description = "Provide enhanced HTTPS support for httplib and urllib2 using PyOpenSSL"; <del> license = licenses.bsd; </del> <ins> license = licenses.bsd2; </ins> maintainers = with maintainers; [ DamienCassou ]; }; };

Discussion:
in have you tested it? i get this problem on OS X (darwin) and NixOS (x86_64).
Should be fixed now, thanks!
I successfully built it as it was a dependency of a project I installed. But building with and even installing a dependent package does not reveal issues in meta data. Thanks for noticing it. Can you please tell me how you found it?
tarball job checks information:
i tried to test another PR () and got the error above. i don't see how is a dependency of or does that informations get evaluated for all packages? you can use nox to easily test PRs like you can see above. before creating a PR you can test with the problem is solved, thank you! :+1:
Change:
buildInputs = [ gnome3.gtk libglade networkmanager libnotify libsecret gsettings_desktop_schemas polkit isocodes makeWrapper udev libgudev gnome3.gconf gnome3.libgnome_keyring <del> modemmanager jansson librsvg glib_networking gnome3.dconf </del> <ins> modemmanager jansson librsvg glib_networking gnome3.dconf webkitgtk </ins> ]; nativeBuildInputs = [ intltool pkgconfig wrapGAppsHook ];

Discussion:
After nixos-rebuild switch, the network-manager service goes down and immediately segfaults every time it tries to come up again. journalctl for the segfault message or something, anyway, at this point I don't have working network anymore. nixos 17.09pre104870.
Specifically it segfaults because returns a non-zero exit status (saying "No for interface NetworkManager"); the segfault itself appears fixes in their HEAD. I haven't checked whether that makes it actually work, yet, but maybe we could arrange for it to have a in the meantime, whatever that means.
In which commit it was fixed?
Does this also happen in 17.03?
Happens with both the 17.03 tag and the 17.03 channel. Looks like cherry-picking the above commit as a patch for our network-manager lets it work correctly, btw.
also fixed in 17.03:
Change:
volnoti = callPackage ../applications/misc/volnoti { }; <del> vorbis-tools = callPackage ../applications/audio/vorbis-tools { }; </del> <ins> vorbis-tools = callPackage ../applications/audio/vorbis-tools { autoreconfHook = buildPackages.autoreconfHook269; }; </ins> vscode = callPackage ../applications/editors/vscode/vscode.nix { };

Discussion:
, (nixos-unstable) (nixos-unstable) (nixos-unstable) (nixos-unstable) (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives.
BTW, I opened
CVE-2014-9638: Fixed upstream at , not released yet. CVE-2014-9639: Fixed upstream at , not released yet. CVE-2014-9640: Fixed upstream at , not released yet. CVE-2015-6749: Fixed upstream at , not released yet. CVE-2017-: Not fixed upstream, though apparently covers this case according to .
I wonder when they manage to release years-old fixes :-/
Change:
"-D sdl=true" "-D elua=true" "-D bindings=lua,cxx" <ins> # for wayland client support "-D wl=true" "-D drm=true" </ins> ]; patches = [

Discussion:
Describe the bug Setting the variable to , as suggested , does nothing. Unsetting results in this error: Expected behavior There are two issues. First, the Enlightenment Foundation Libraries are not complied with Wayland support. Secondly, the variable needs to be set correctly a Wayland environment. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Maintainer information:
PR fixes this issue. Tested terminology with sway. The environment variable should not be set. In my test it was not needed to set . !
Change:
githubId = 887072; name = "Alexander Lebedev"; }; <ins> lebensterben = { name = "Lucius Hu"; github = "lebensterben"; githubId = 1222865; keys = [{ fingerprint = "80C6 77F2 ED0B E732 3835 A8D3 7E47 4E82 E29B 5A7A"; }]; }; </ins> lecoqjacob = { name = "Jacob LeCoq"; email = "lecoqjacob@gmail.com";

Discussion:
Project description LXGW WenKai TC is the Traditional Chinese Edition of LXGW WenKai, where the latter has already been packaged as . Metadata homepage URL: <https URL: ofl platforms: all Below is a working package build script I tested locally, which is largely based on 's script: (I commented out field.
If that snippet is working, could you turn it into a PR? It looks good enough for inclusion to me.