jiebi/CodeConvo huggingface dataset:
Change:
<del> { pkgs </del> <ins> { nixosTests , pkgs </ins> , poetry2nix , lib , overrides ? (self: super: {})

Discussion:
Describe the bug introduced a change that breaks NixOps. When we have a test, something like this will be detected faster and not depend on users running into an issue. That would increase the quality. To Reproduce Steps to reproduce the behavior: nixops complain :grimacing:
I marked this as stale due to inactivity. &rarr;
Tests would still be nice. has been more broken than I expected...
I marked this as stale due to inactivity. &rarr;
Change:
xrandr ]; <del> postPatch = let ext = stdenv.hostPlatform.extensions.sharedLibrary; in '' </del> <ins> dontWrapQtApps = true; makeWrapperArgs = [ "${qtWrapperArgs[@]}" # import Qt.labs.platform failed without this "--prefix QML2_IMPORT_PATH : ${qt5.qtquickcontrols2.bin}/${qt5.qtbase.qtQmlPrefix}" ]; postPatch = '' </ins> substituteInPlace virtscreen/__main__.py  <del> --replace "'GL'" "'${libGL}/lib/libGL${ext}'"  </del> <ins> --replace "'GL'" "'${libGL}/lib/libGL${stdenv.hostPlatform.extensions.sharedLibrary}'"  </ins> ''; meta = with lib; {

Discussion:
Describe the bug Related to , virtscreen needs to be updated to work with . I've tried to do it myself based on the qutebrowser derivation but haven't been able to figure it out. To Reproduce Steps to reproduce the behavior: I've attempted to fix it like so: with the above patch applied it seems to get further but still doesn't quite work: along with those messages I get a dialog box that says "Failed to load QML": ! I must be missing something here; can someone help me out?
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
I didn't test virtscreen but I have some tips: a look at . That's most of the definition of . You can see, e.g., that is already in . is appropriate here, because Python executables get already wrapped if using . using manually then is probably mainly for controlling exactly when something is wrapped. Python apps are already wrapped, and you probably don't want to wrap the wrapper. You rather amend them by adding to . Have a look at the reference for in the of the manual and at the of simultaneous gnome, qt and python wrappers. An example is . global nipkgs scope uses qt-5.15 by default while python3Packages use qt-5.14. Therefore you either need to use , or you use and use / as a package input.

The second method ensures that you always get the same the current are using. If you then still have problems, feel free to ask again.
I marked this as stale due to inactivity. &rarr;
Bump: virtscreen seems quite useful and currently broken.
Change:
libtiff = if stdenv.isDarwin && stdenv.isAarch64 then callPackage ../development/libraries/libtiff/aarch64-darwin.nix { } <del> else callPackage ../development/libraries/libtiff { inherit (darwin.apple_sdk.frameworks) Cocoa GLUT; }; </del> <ins> else callPackage ../development/libraries/libtiff { }; </ins> libtiger = callPackage ../development/libraries/libtiger { };

Discussion:
I don't know if Mesa is even required on Darwin but I think it definitely shouldn't cause more rebuilds on Darwin than on Linux. CI currently reports 1001-2500 rebuilds on Linux and 5001+ rebuilds on Darwin (see e.g. ). For CI reported 2501-5000 rebuilds on Darwin but for the next PR () this increased to 5001+ rebuilds. Mesa updates are merged though staging-next as staging is too slow for the biweekly releases. I'll leave this issue here for you in case you want to avoid that (those rebuilds are most likely unnecessary and AFAIK Hydra's build capacity for Darwin is severely lacking). Otherwise you may just close it as well. Edit: Oh, and if something just needs the headers it shouldn't depend on Mesa, see: and
Not the case on darwin:
what does mean? I looked though the Git history and you didn't document this in or (that code was later extracted into : ). It looks like does at least build on Darwin, e.g.: and . I have no idea if the dispatching works but I'd assume that at least the headers should be usable on Darwin.
IIRC the used to be marked as broken on darwin in the past, I don't know why.
The strange thing is that fixed the build on Darwin () before And it wasn't marked as broken at that time. The following doesn't return anything: . And only returns two commits: and (the latter the Darwin support).
The original issue should be fixed now. Regarding libglvnd, I'm not sure what the deal is. The X11 implementation for OpenGL with / probably shouldn't differ much between Linux/BSD and macOS. Probably not worth looking into that, unless there is some maintenance burden associated with that.
Ok, thanks a lot for decreasing the number of unnecessary rebuilds.
Change:
owner = "Textualize"; repo = pname; rev = "refs/tags/v${version}"; <del> hash = "sha256-UT+ApD/TTb5cxIdgK+n3B2J3z/nEwVXtuyPHpGCv6Tg="; </del> <ins> hash = "sha256-XgJ43yyiwzSH22NzidJ7z+Qh6+pOuAdfL7ZxabJkd3U="; </ins> }; nativeBuildInputs = [ poetry-core ]; <del> postPatch = '' substituteInPlace pyproject.toml  --replace 'importlib-metadata = "^4.11.3"' 'importlib-metadata = "*"' ''; </del> propagatedBuildInputs = [ rich markdown-it-py

Discussion:
Package name: textual Latest released version: 0.23.0 <!-- Search your package here: --- Current version on the unstable channel: 0.15.1 Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Does resolve this?
As far as I can tell: yes. Would be great to have it merged into master (so it shows up in nixpkgs-unstable at some point).
And of course there have been two new releases in the meantime....
Was fixed, closing.
Change:
}: let <del> version = "3.8.1"; </del> <ins> version = "3.8.2"; </ins> sources = { "audacious-${version}" = fetchurl { url = "http://distfiles.audacious-media-player.org/audacious-${version}.tar.bz2"; <del> sha256 = "1k9blmgqia0df18l39bd2bbcwmjfxak6bd286vcd9zzmjhqs4qdc"; </del> <ins> sha256 = "14xyvmxdax0aj1gqcz8z23cjcavsysyh6b3lkiczkv4vrqf4gwdx"; </ins> }; "audacious-plugins-${version}" = fetchurl { url = "http://distfiles.audacious-media-player.org/audacious-plugins-${version}.tar.bz2"; <del> sha256 = "0f16ivcp8nd83r781hnw1qgbs9hi2b2v22zwv7c3sw3jq1chb70h"; </del> <ins> sha256 = "1m7xln93zc4qvb1fi83icyd5x2r6azqlvs5nigjz8az3l2kzrknp"; </ins> }; }; in stdenv.mkDerivation { inherit version; <del> name = "audacious-${version}"; </del> <ins> name = "audacious-qt5-${version}"; </ins> sourceFiles = lib.attrValues sources; sourceRoots = lib.attrNames sources;

Discussion:
I guess it's a political question whether Qt is an upgrade from Gtk, but for whatever reason the Qt version appears to have text in the toolbar instead of icons, so I'd like to stick with the inferior Gtk for now. nixos.audacious{,Qt5} have the same name, but versions 3.8 and 3.8.1 respectively.
What I understand from they support both. If we want to support both they should have different names.
For what it's worth, the qt/gtk separation was again abolished in . I wouldn't really blame gebner for what happened though: the upstream has indeed stated that they want to focus on Qt in the future. That said, anyone interested is still welcome to make a Qt-less build; shows it's still possible. about that focus thing: they seem to have walked it back in https://audacious-media- now gtk3 is back to "no[t] considered legacy".
Change:
<ins> { lib, rustPlatform, fetchFromGitHub, }: rustPlatform.buildRustPackage rec { pname = "cargo-features-manager"; version = "0.8.0"; src = fetchFromGitHub { owner = "ToBinio"; repo = "cargo-features-manager"; rev = "v${version}"; hash = "sha256-ez8WIDHV6/f0Kk6cvzB25LoYBPT+JTzmOWrSxXXzpBc="; }; cargoHash = "sha256-G1MBH4c9b/h87QgCleTMnndjWc70KZI+6W4KWaxk28o="; meta = { description = "A command-line tool for managing Architectural Decision Records"; homepage = "https://github.com/ToBinio/cargo-features-manager"; changelog = "https://github.com/ToBinio/cargo-features-manager/blob/v${version}/CHANGELOG.md"; license = lib.licenses.mit; maintainers = with lib.maintainers; [ luftmensch-luftmensch ]; mainProgram = "cargo-features-manager"; }; } </ins>

Discussion:
a TUI-like CLI tool to manage the features of a Rust project Metadata homepage URL: source URL: license: mit platforms: everything that Rust supports Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<ins> { lib, stdenv, fetchFromGitHub, makeWrapper, nodejs, overrideSDK, pnpm_9, python3, renovate, testers, xcbuild, }: let # fix build error, `no member named 'aligned_alloc'` on x86_64-darwin # https://github.com/NixOS/nixpkgs/issues/272156#issuecomment-1839904283 stdenv' = if stdenv.hostPlatform.isDarwin then overrideSDK stdenv "11.0" else stdenv; in stdenv'.mkDerivation (finalAttrs: { pname = "renovate"; version = "37.393.0"; src = fetchFromGitHub { owner = "renovatebot"; repo = "renovate"; rev = "refs/tags/${finalAttrs.version}"; hash = "sha256-YgxcGNMgmwrausdR7kvG1NiyQPn0FcCq/isf9qUDCFY="; }; postPatch = '' substituteInPlace package.json  --replace-fail "0.0.0-semantic-release" "${finalAttrs.version}" ''; nativeBuildInputs = [ makeWrapper nodejs pnpm_9.configHook python3 ] ++ lib.optional stdenv'.hostPlatform.isDarwin xcbuild; pnpmDeps = pnpm_9.fetchDeps { inherit (finalAttrs) pname version src; hash = "sha256-Zbe561q6xDKDIN+E/2eyQMz2GtpPvJEv2pAauMa+8pE="; }; env.COREPACK_ENABLE_STRICT = 0; buildPhase = '' runHook preBuild pnpm build pnpm prune --prod --ignore-scripts '' # The optional dependency re2 is not built by pnpm and needs to be built manually. # If re2 is not built, you will get an annoying warning when you run renovate. + '' pushd node_modules/.pnpm/re2*/node_modules/re2 mkdir -p $HOME/.node-gyp/${nodejs.version} echo 9 > $HOME/.node-gyp/${nodejs.version}/installVersion ln -sfv ${nodejs}/include $HOME/.node-gyp/${nodejs.version} export npm_config_nodedir=${nodejs} npm run rebuild popd runHook postBuild ''; # TODO: replace with `pnpm deploy` # now it fails to build with ERR_PNPM_NO_OFFLINE_META # see https://github.com/pnpm/pnpm/issues/5315 installPhase = '' runHook preInstall mkdir -p $out/{bin,lib/node_modules/renovate} cp -r dist node_modules package.json $out/lib/node_modules/renovate makeWrapper "${lib.getExe nodejs}" "$out/bin/renovate"  --add-flags "$out/lib/node_modules/renovate/dist/renovate.js" makeWrapper "${lib.getExe nodejs}" "$out/bin/config-validator"  --add-flags "$out/lib/node_modules/renovate/dist/config-validator.js" runHook postInstall ''; passthru.tests = { version = testers.testVersion { package = renovate; }; }; meta = { description = "Cross-platform Dependency Automation by Mend.io"; homepage = "https://github.com/renovatebot/renovate"; license = lib.licenses.agpl3Only; maintainers = with lib.maintainers; [ marie natsukium ]; mainProgram = "renovate"; platforms = nodejs.meta.platforms; }; }) </ins>

Discussion:
Project description Universal dependency update tool that fits into your workflows. Metadata homepage URL: source URL: license: agpl3+ platforms: unix, linux, darwin, ... note that this software may use an open-core model, with features they mention to advertise the paid subscription being 'automatic scaling and Merge Confidence workflows'. edit: an existing nix effort to package this .
Change:
"-DARROW_WITH_SNAPPY=ON" "-DARROW_WITH_ZLIB=ON" "-DARROW_WITH_ZSTD=ON" <ins> "-DARROW_ZSTD_USE_SHARED=OFF" # TODO use shared zstd once #91984 hits the master </ins> # Parquet options: "-DARROW_PARQUET=ON" "-DPARQUET_BUILD_EXECUTABLES=ON"

Discussion:
Describe the bug arrow-cpp cannot be installed on Darwin To Reproduce Steps to reproduce the behavior: -env -i arrow-cpp Expected behavior Successful installation Additional context nix-build -A arrow-cpp from nixpkgs master fails with this error: Notify maintainers Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(lclaude): nixpkgs: Maintainer information:
Change:
<ins> diff --git a/cps/tornado_wsgi.py b/cps/tornado_wsgi.py index af93219c..cf302042 100644 --- a/cps/tornado_wsgi.py +++ b/cps/tornado_wsgi.py @@ -53,7 +53,7 @@ class MyWSGIContainer(WSGIContainer): return response.append app_response = self.wsgi_application( -            MyWSGIContainer.environ(request), start_response +            self.environ(request), start_response ) try: response.extend(app_response) @@ -86,9 +86,8 @@ class MyWSGIContainer(WSGIContainer): request.connection.finish() self._log(status_code, request) -    @staticmethod -    def environ(request: httputil.HTTPServerRequest) -> Dict[Text, Any]: -        environ = WSGIContainer.environ(request) +    def environ(self, request: httputil.HTTPServerRequest) -> Dict[Text, Any]: +        environ = super().environ(request) environ['RAW_URI'] = request.path return environ </ins>

Discussion:
calibre-web failed to start Steps to reproduce the behavior: -rebuild switch -u calibre-web The service start successfully, and no error occurs. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Change:
} // optionalAttrs (backup.environmentFile != null) { EnvironmentFile = backup.environmentFile; }; <del> } // optionalAttrs (backup.initialize || backup.dynamicFilesFrom != null || backup.backupPrepareCommand != null) { </del> <ins> } // optionalAttrs (backup.initialize || doBackup || backup.backupPrepareCommand != null) { </ins> preStart = '' ${optionalString (backup.backupPrepareCommand != null) '' ${pkgs.writeScript "backupPrepareCommand" backup.backupPrepareCommand}

Discussion:
Recent changes to the assume the presence of the list even when it is not in use (it defaults to null). This prevents the service from running. Problem line: Steps to reproduce the behavior: a backup service without the 'dynamicFilesFrom' option that is included in the service's ExecStart service failing due to error Argument should not be passed if is not in use <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
cc
Please provide the relevant part of your configuration hughobrien am Mi., 1. Nov. 2023, 01:07:
The problematic section is unconditional so I do not believe the config matters. Nevertheless
Ah, I see. I'll send a fix in the evening. In the meantime, you can work around the problem by setting (which does not change anything if the repository already exists). hughobrien am Mi., 1. Nov. 2023, 15:08:
Change:
hash = "sha256-PfXrj4d2SHmatiPPFxjsxvhusML1HTRNjoYEQtzFzW8="; }; <ins> # code predates c99 env.CFLAGS = "-std=c89"; </ins> preInstall = '' mkdir -p $out/man/man1 $out/bin '';

Discussion:
Steps to reproduce the behavior: wakelan on aarch64-darwin Add any other context about the problem here.
does work for you? or
Yes, thanks! wow C89, I guess I should switch to another WoL tool :P
Change:
}); in { <del> hledger = installHledgerExtraFiles super.hledger; hledger-web = installHledgerExtraFiles (hledgerWebTestFix super.hledger-web); hledger-ui = installHledgerExtraFiles super.hledger-ui; </del> <ins> hledger = installHledgerExtraFiles "" super.hledger; hledger-web = installHledgerExtraFiles "" (hledgerWebTestFix super.hledger-web); hledger-ui = installHledgerExtraFiles "" super.hledger-ui; </ins> <del> hledger_1_30_1 = installHledgerExtraFiles (doDistribute (super.hledger_1_30_1.override { hledger-lib = self.hledger-lib_1_30; </del> <ins> hledger_1_34 = installHledgerExtraFiles "embeddedfiles" (doDistribute (super.hledger_1_34.override { hledger-lib = self.hledger-lib_1_34; </ins> })); <del> hledger-web_1_30 = installHledgerExtraFiles (hledgerWebTestFix (doDistribute (super.hledger-web_1_30.override { hledger = self.hledger_1_30_1; hledger-lib = self.hledger-lib_1_30; </del> <ins> hledger-ui_1_34 = installHledgerExtraFiles "" (doDistribute (super.hledger-ui_1_34.override { hledger = self.hledger_1_34; hledger-lib = self.hledger-lib_1_34; })); hledger-web_1_34 = installHledgerExtraFiles "" (hledgerWebTestFix (doDistribute (super.hledger-web_1_34.override { hledger = self.hledger_1_34; hledger-lib = self.hledger-lib_1_34; </ins> }))); } ) hledger hledger-web hledger-ui <del> hledger_1_30_1 hledger-web_1_30 </del> <ins> hledger_1_34 hledger-ui_1_34 hledger-web_1_34 </ins> ; cufft = overrideCabal (drv: {

Discussion:
Running the package fails, apparently because it uses as input instead of as would be required to run:
Change:
postFixup = '' # Remove references to bootstrap. find "$out" -name *.so | while read lib; do <del> new_refs="$(patchelf --print-rpath "$lib" | sed -E 's,:?${openjdk11_headless}[^:]*,,')" </del> <ins> new_refs="$(patchelf --print-rpath "$lib" | sed -E 's,:?${lib.escape ["+"] openjdk11_headless.outPath}[^:]*,,')" </ins> patchelf --set-rpath "$new_refs" "$lib" done '';

Discussion:
Describe the bug as described in , the build fails with: To Reproduce Steps to reproduce the behavior: Since this is a dependency of openjdk14, reproduce with: Additional context This broke somewhere between and ; I'm bisecting now. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
I could've sworn I tested this back when I was working on ... rebuilding from those commits now to confirm.
Yeah, somehow the release fixes this, but I don't know how.
Change:
{ lib, appleDerivation, xcbuildHook <del> , libressl, Librpcsvc, xnu, libpcap, developer_cmds }: </del> <ins> , libressl_3_4, Librpcsvc, xnu, libpcap, developer_cmds }: </ins> appleDerivation { nativeBuildInputs = [ xcbuildHook ]; <del> buildInputs = [ libressl xnu Librpcsvc libpcap developer_cmds ]; </del> <ins> buildInputs = [ libressl_3_4 xnu Librpcsvc libpcap developer_cmds ]; </ins> NIX_CFLAGS_COMPILE = " -I./unbound -I${xnu}/Library/Frameworks/System.framework/Headers/";

Discussion:
LibreSSL 3.4 version will go EOL in October of this year, so we'll need to switch to 3.5
Change:
pname = "wev"; version = "1.0.0"; <del> src = fetchurl { url = "https://git.sr.ht/~sircmpwn/wev/archive/${version}.tar.gz"; sha256 = "0vlxdkb59v6nb10j28gh1a56sx8jk7ak7liwzv911kpmygnls03g"; </del> <ins> src = fetchFromSourcehut { owner = "~sircmpwn"; repo = pname; rev = version; sha256 = "0l71v3fzgiiv6xkk365q1l08qvaymxd4kpaya6r2g8yzkr7i2hms"; </ins> }; nativeBuildInputs = [ pkg-config scdoc wayland ];

Discussion:
Describe the bug Sources from archives from fail to download with hash mismatches. To Reproduce Expected behavior The hash should match and the source should download. Additional context It sounds like , causing changes to all generated archives (to come in-line with GNU gzip). I've determined some packages which this affects (listed in "Maintainer information") by . I'm happy to have a go making a PR for all of these packages with the following process: archive from cache (by with subsituters) archive from both and confirm tar files are identical hash according to newly retrieved archive But if there's a better process, please let me know :) Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Sounds good
I think it is preferable to switch all affected derivations to fetchzip. This should prevent this from happening again, if the actual content of the tarball is the same. Even better, you could add a fetchFromSourceHut function which uses fetchzip under the hood, like fetchFromGitHub and fetchFromGitLab. This would encourage people not to use fetchurl to fetch procedurally generated tarballs from sourcehut.
From a quick look at the ticket, this is supposed to be a one-time change to make the hash the same as in other forges though
I think getting the new hashes with e.g. should be enough (fetches securely via HTTPS and we should be able to trust that the contents remain unchanged). +1, that seems like the best (long-term) solution. Edit: And IMO we should keep using archives (e.g. because it's consistent with the GitHub and GitLab fetchers) and should indeed be fine now:
the point is: with fetchzip, we don't have to trust this pinky promise (I mean, I'm sure that they intend to keep it, but it could break unwillingly). That's exactly why fetchzip exists in the first place. So on fixes keeping fetchurl.
oh, my bad, I didn't read your comment carefully enough :o I thought you've meant vs. (which didn't make much sense) but realized now that it was vs. . :+1: for that then :)
Hah, same. too then
is merged now so you could submit a PR to switch the affected attributes/packages to the new (s. ). I can also take care of it if you want.
Change:
, stdenv , zlib , xz <del> , ncompress </del> , gzip , bzip2 , gnutar

Discussion:
The and packages both provide an implementation of that is incompatible. This is leading to some trouble when having both packages installed and executing shell scripts that expect to be present in the path. Since isn't that widely used I would recommend to either remove from (it is a symbolic link anyway) or to rename it to . Steps to reproduce the behavior: and on a gzip compressed file (example: some ) There might be valid use cases where from is used, for example for very old shell scripts dating back to the early 1990s or earlier. These days the default is expected to be from and other distributions (like Fedora) do not seem to be creating the symlink for .
Change:
hardeningDisable = [ "strictoverflow" ]; preConfigure = '' <ins> export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 </ins> dotnetVersion="$(${dotnet-sdk}/bin/dotnet --list-runtimes | grep -Po '^Microsoft.NETCore.App K.*?(?= )')" cmakeFlagsArray+=( "-DDBGSHIM_RUNTIME_DIR=${dotnet-sdk}/shared/Microsoft.NETCore.App/$dotnetVersion" )

Discussion:
Steps to reproduce the behavior: netcoredbg <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
My first hunch is that caused something to break it, but I'm going to investigate futher when I have the time.