jiebi/CodeConvo huggingface dataset:
Change:
set -eu set -o pipefail <ins> if [ -n "${BASH_VERSINFO-}" ] && [ "${BASH_VERSINFO-}" -lt 4 ]; then echo "Detected Bash version that isn't supported by Nixpkgs (${BASH_VERSION})" echo "Please install Bash 4 or greater to continue." exit 1 fi </ins> if (( "${NIX_DEBUG:-0}" >= 6 )); then set -x fi

Discussion:
Describe the bug Since this commit: Whenever I run commands like: I get the following error: Additional context My default shell is zsh, which has been the cause of some issues at times. Metadata Paging in particular. Let me know how I can help!
You need recent bash (=4) as macOS has outdated bash by default. I'm not sure how nix behaves on macOS, but try either of the following: you have environment variable, unset it. your system bash or install it via nix:
Thanks. I personally solved it by: Which installed an ambient bash v5.0. Feel free to close this if you think you're done tracking this concern.
Nix should use bashInteractive from Nixpkgs. I suspect it's hitting some error and falling back here:
I could also solve the issue for me with these steps.
I got this issue on macOS, and installing via comment worked out well (which was also the solution you mentioned). I am running macOS Catalina, and wanted a pure nix/macOS machine, so for me this was a better solution.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . 3. Ask on the on .
It might still be important.
I marked this as stale due to inactivity. &rarr;
Change:
catfish = throw "'catfish' has been renamed to/replaced by 'xfce.catfish'"; # Converted to throw 2023-09-10 cawbird = throw "cawbird has been abandoned upstream and is broken anyways due to Twitter closing its API"; ccloud-cli = throw "ccloud-cli has been removed, please use confluent-cli instead"; # Added 2023-06-09 <ins> certmgr-selfsigned = certmgr; # Added 2023-11-30 </ins> chefdk = throw "chefdk has been removed due to being deprecated upstream by Chef Workstation"; # Added 2023-03-22 chocolateDoom = chocolate-doom; # Added 2023-05-01 chrome-gnome-shell = gnome-browser-connector; # Added 2022-07-27

Discussion:
Steps to reproduce the behavior: build certmgr-selfsigned, eg Caused by this by by this out of date shar and also detected Please run and paste the result. Add a to . Thanks!
Change:
listen_addresses = '${if cfg.enableTCPIP then "*" else "localhost"}' port = ${toString cfg.port} ${cfg.extraConfig} <del> ''; </del> <ins> ''; </ins> groupAccessAvailable = versionAtLeast postgresql.version "11.0";

Discussion:
Describe the bug A clear and concise description of what the bug is. I have The error I got when starting the service is:
The folder is owned by user postgres:
what are the permissions on ?
it's
it works if I set it to but is created by the build/installation. why doesn't it set the right permission?
Looks line should be a one time required step and you're good to go :+1: Looks like with both and together pushes permissions up to all new parent directories. The module is still using (which is deprecated) so the module should be updated to remove that and fix your issue at the same time. Thanks for reporting!
Thank you for your help!
Change:
{ stdenv , fetchurl, perl, gcc <del> , ncurses5, gmp, glibc, libiconv </del> <ins> , ncurses5, ncurses6, gmp, glibc, libiconv </ins> , llvmPackages }:

Discussion:
Describe the bug Trying to build GHC 8.8.3 on pkgsMusl (in order to build static Haskell executables) fails with: To Reproduce On a recent pin of nixpkgs-unstable (rev ): Expected behavior GHC 8.8.3 is built based on Musl Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(remo): nixpkgs:
Thanks for creating this issue. Unfortunately, we don't always check to make sure the musl builds succeed before merging stuff in. If you wanted to fix this issue, we'd happily accept a PR. Also, is doing a lot with the musl builds, especially in If you absolutely need a musl'd GHC, I'd suggest to use
To add to that: I pin a nixpkgs that works well in a submodule: ! and the same in the : On the issue: We've seen build failures on latest nixpkgs with musl recently, hopefulyy they will be fixed soon!
Just for the record, current versions of (and ) still have this issue. We'll try to build the package with reverted to check whether the update of the boot compiler caused this problem.
Many thanks all for your help and quick responses! As suggested I reverted and is currently building, getting much further than on ghc865-binary - looking good! I'll update once the build is done, takes quite a bit of time... Edit: Confirmed, successfully built ! I would like to contribute a fix if possible, but I'm not sure what direction would be best to take - GHC 8.8.3 binaries are , would it make sense to bootstrap from there? Edit2: Maybe it just needs in Trying that out right now. Would that be likely to break anything else? Edit3: Couldn't get the dependency from ncurses to work for 8.6.5-binary on pkgsMusl... , I saw that you worked on related things, do you have an idea maybe how to solve this?
CC
It looks to me like this is a bug in the derivation. In particular, the it exposes has the incorrect soname. This is likely because is isn't at all; rather, it's simply a symlink to . In general I don't see how this could work.

We work around this in mpickering/ghc-artefact-nix via
Collecting some info for myself: The derivation refers to (called rather in the issue description) is Question: Do you know what a fix could look like? Instead of a symlink, should it be a copy of the file, on which is subsequently run, as shown in your link? If yes, should that happen unconditionally or only for ? I don't know anything about the ncurses 5-6 switch, so I have no idea why this sophisticated mechanism is there in the first place.
The ideal solution would be to rather use a GHC binary distribution which expects ABI 6. For instance, this patch appears to work around the issue locally:
I have opened to track the symlink issue.
Is it feasible to add to hydra to prevent this from happening?
FWIW this also happens with the ghc-8.10.2 binary used to bootstrap ghc901:
I built things with patch above and it all went very smoothly, is there a reason against including it in nixpkgs, even if just for musl builds?
Change:
ninja vala gobject-introspection <del> gtk-doc docbook-xsl-nons docbook_xml_dtd_43 </del> <ins> gi-docgen </ins> ]; buildInputs = [

Discussion:
Package name: gegl Latest released version: 0.4.48 <!-- Search your package here: --- Current version on the unstable channel: 0.4.46 Current version on the stable/release channel: 0.4.46 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- I can take over the package if you wish. Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
If you are able to bump the package (and babl), feel free. I probably will not be able to get to it this week.
Change:
<del> From 04bfb877c8ccbd431dcae429abb487c1e3390801 Mon Sep 17 00:00:00 2001 From: Yureka <yuka@yuka.dev> Date: Sun, 30 Jun 2024 09:37:49 +0200 Subject: [PATCH] Fix build with _PY_SHORT_FLOAT_REPR == 0 --- Include/internal/pycore_dtoa.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Include/internal/pycore_dtoa.h b/Include/internal/pycore_dtoa.h index 4d9681d59a..899d413b05 100644 --- a/Include/internal/pycore_dtoa.h +++ b/Include/internal/pycore_dtoa.h @@ -11,8 +11,6 @@ extern "C" { #include "pycore_pymath.h"        // _PY_SHORT_FLOAT_REPR -#if _PY_SHORT_FLOAT_REPR == 1 - typedef uint32_t ULong; struct @@ -22,15 +20,15 @@ Bigint { ULong x[1]; }; -#ifdef Py_USING_MEMORY_DEBUGGER +#if defined(Py_USING_MEMORY_DEBUGGER) || _PY_SHORT_FLOAT_REPR == 0 struct _dtoa_state { int _not_used; }; -#define _dtoa_interp_state_INIT(INTERP)  +#define _dtoa_state_INIT(INTERP)  {0} -#else  // !Py_USING_MEMORY_DEBUGGER +#else  // !Py_USING_MEMORY_DEBUGGER && _PY_SHORT_FLOAT_REPR != 0 /* The size of the Bigint freelist */ #define Bigint_Kmax 7 @@ -65,8 +63,6 @@ PyAPI_FUNC(char *) _Py_dg_dtoa(double d, int mode, int ndigits, int *decpt, int *sign, char **rve); PyAPI_FUNC(void) _Py_dg_freedtoa(char *s); -#endif // _PY_SHORT_FLOAT_REPR == 1 - #ifdef __cplusplus } #endif -- 2.45.1 </del>

Discussion:
Package name: python312 Latest released version: 3.12.5 <!-- Search your package here: --- Current version on the unstable channel: 3.12.4 Current version on the stable/release channel: 3.12.4 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
merged
Change:
<ins> { lib , stdenv , fetchFromGitHub , autoreconfHook , makeWrapper , curl , ncurses , gtk3 , pkg-config , scoreDirectory ? "$HOME/.local/share" }: stdenv.mkDerivation (finalAttrs: { pname = "dopewars"; version = "1.6.2"; src = fetchFromGitHub { owner = "benmwebb"; repo = "dopewars"; rev = "v${finalAttrs.version}"; hash = "sha256-CpgqRYmrfOFxhC7yAS2OqRBi4r3Vesq3+7a0q5rc3vM="; }; nativeBuildInputs = [ autoreconfHook makeWrapper pkg-config ]; buildInputs = [ curl gtk3 ncurses ]; # remove the denied setting of setuid bit permission patches = [ ./0001-remove_setuid.patch ]; # run dopewars with -f so that it finds its scoreboard file in ~/.local/share postInstall = '' wrapProgram $out/bin/dopewars  --run 'mkdir -p ${scoreDirectory}'  --add-flags '-f ${scoreDirectory}/dopewars.sco' ''; meta = with lib; { description = "Game simulating the life of a drug dealer in New York"; homepage = "https://dopewars.sourceforge.io"; license = licenses.gpl2Plus; maintainers = with maintainers; [ geri1701 ]; mainProgram = "dopewars"; platforms = platforms.unix; }; }) </ins>

Discussion:
Dopewars is a game simulating the life of a drug dealer in New York. The aim of the game is to make lots and lots of money... unfortunately, you start the game with a hefty debt, accumulating interest, and the cops take a rather dim view of drug dealing... <!-- Describe the project a little: --Metadata homepage URL: source URL: license: GPL-2.0 platforms: Linux, Windows, MAC
Change:
postInstall = '' # Avoid a runtime reference to gcc sed -i $out/lib/grub/*/modinfo.sh -e "/grub_target_cppflags=/ s|'.*'|' '|" <ins> # just adding bash to buildInputs wasn't enough to fix the shebang substituteInPlace $out/lib/grub/*/modinfo.sh  --replace ${buildPackages.bash} "/usr/bin/bash" </ins> ''; passthru.tests = {

Discussion:
After upgrading to 21.05, when running , I get the following warning: Everything else seems to work fine, but it's unclear what has gone wrong here, or if I should be worried. Metadata Maintainer information:
discussed here a bit you can safely ignore it to hide it we could add to the or to
Not sure if my case is related, but I had the same error after : The overall install didn't error. Attempting to reboot, it would be unable to boot:
My boot got fixed after converting my MBR to GPT and creating an ESP partition and setting it to use systemd-boot instead of GRUB. If GRUB continues to work with people that see this warning, it's unlikely that my boot problems are related. (But, still, a different bug; if MBR got deprecated, there should have been an announcement.)
But the issue is quite severe (I just lost hours on it because it happened on a remote server which boots very slowly on a web-mounted rescue iso), and I could only get my system running again by reverting to . I'd propose to throw out the new version () for now. I can't do GPT, because the system only has a legacy BIOS (no UEFI), it appears that this is the reason this issue has flown under the radar? Same error referenced , it appears to be an issue with the grub package itself. EDIT: since OP defined a "parallel" but much less severe bug, I made a new report here:
Change:
<ins> diff --git a/api/build.rs b/api/build.rs index 617c1b9a..20d728e3 100644 --- a/api/build.rs +++ b/api/build.rs @@ -5,10 +5,10 @@ use prost_wkt_build::{FileDescriptorSet, Message}; /// According to the file kclvm/spec/gpyrpc/gpyrpc.proto, automatically generate /// the corresponding rust source file to the directory src/model fn main() { -    std::env::set_var( -        "PROTOC", -        protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), -    ); +    // std::env::set_var( +    //     "PROTOC", +    //     protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), +    // ); let out = PathBuf::from(env::var("OUT_DIR").unwrap()); let descriptor_file = out.join("kclvm_service_descriptor.bin"); diff --git b/third-party/prost-wkt/wkt-types/build.rs a/third-party/prost-wkt/wkt-types/build.rs index e49222d5..a933ddf4 100644 --- a/third-party/prost-wkt/wkt-types/build.rs +++ b/third-party/prost-wkt/wkt-types/build.rs @@ -13,10 +13,10 @@ use regex::Regex; fn main() { //hack: set protoc_bin_vendored::protoc_bin_path() to PROTOC -    std::env::set_var( -        "PROTOC", -        protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), -    ); +    // std::env::set_var( +    //     "PROTOC", +    //     protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), +    // ); let dir = PathBuf::from(env::var("OUT_DIR").unwrap()); process_prost_pbtime(&dir); </ins>

Discussion:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
buildPythonApplication rec { pname = "PySolFC"; <del> version = "2.6.4"; </del> <ins> version = "2.16.0"; </ins> src = fetchzip { url = "https://versaweb.dl.sourceforge.net/project/pysolfc/PySolFC/PySolFC-${version}/PySolFC-${version}.tar.xz"; <del> sha256 = "1bd84law5b1yga3pryggdvlfvm0l62gci2q8y3q79cysdk3z4w3z"; </del> <ins> sha256 = "sha256-kklB16IrDicxqMee1kbxtoqgwcSrMjCV4HP6GtnZxo8="; </ins> }; cardsets = fetchzip { <del> url = "https://versaweb.dl.sourceforge.net/project/pysolfc/PySolFC-Cardsets/PySolFC-Cardsets-2.0/PySolFC-Cardsets-2.0.tar.bz2"; sha256 = "0h0fibjv47j8lkc1bwnlbbvrx2nr3l2hzv717kcgagwhc7v2mrqh"; </del> <ins> url = "https://versaweb.dl.sourceforge.net/project/pysolfc/PySolFC-Cardsets/PySolFC-Cardsets-2.1/PySolFC-Cardsets-2.1.tar.bz2"; sha256 = "sha256-0ji6jY7zJFaaaJdInaULKUou+u934RMzYjxVDGVHbE0="; </ins> }; propagatedBuildInputs = with python3Packages; [ <del> tkinter six random2 </del> <ins> tkinter six random2 configobj pysol-cards attrs pycotap </ins> # optional : pygame freecell-solver pillow ];

Discussion:
The package PySolFC is broken: It does not even start but throws an exception. Looks like noone has ever tested this. :( -shell -p pysolfc .py Traceback (most recent call last): File "/nix/store/y3xs17qmzs898jyjcbp9vbcj2kkjqhgz-PySolFC-", line 37, in <modulefrom import main # noqa: E402,I202 File "/nix/store/y3xs17qmzs898jyjcbp9vbcj2kkjqhgz-PySolFC-2.6.4/lib/python3.9/site-", line 30, in <modulefrom import Application File "/nix/store/y3xs17qmzs898jyjcbp9vbcj2kkjqhgz-PySolFC-2.6.4/lib/python3.9/site-", line 31, in <modulefrom import GAMEDB, GI, loadGame File "/nix/store/y3xs17qmzs898jyjcbp9vbcj2kkjqhgz-PySolFC-2.6.4/lib/python3.9/site-", line 28, in <modulefrom pysollib.mfxutil import Struct, printerr File "/nix/store/y3xs17qmzs898jyjcbp9vbcj2kkjqhgz-PySolFC-2.6.4/lib/python3.9/site-", line 146, in <moduleuclock = AttributeError: module 'time' has no attribute 'clock'
Just ran into this as well. Looks like was removed in Python 3.8, but also the version of PySolFC in is three and a half years (and ten minor versions) old so decent chance bumping the package version takes care of it
Change:
<del> { stdenv, fetchFromGitHub </del> <ins> { stdenv, fetchFromGitHub, fetchpatch </ins> , cmake, pkgconfig, SDL2, SDL, SDL2_ttf, openssl, spice-protocol, fontconfig , libX11, freefont_ttf, nettle, libconfig }:

Discussion:
Add looking-glass-client package and rebuild. This used to work but something changed awhile back. I just commented out the package and forgot about it because I wasn't using it at the time. Now I'd like to use it again. system: host os: multi-user?: sandbox: version: channels(root): channels(nix): nixpkgs:
Change:
<ins> diff --git a/src/gui/systemd/systemdprocessrunner.cpp b/src/gui/systemd/systemdprocessrunner.cpp index afe3e2c69..5e5ee012d 100644 --- a/src/gui/systemd/systemdprocessrunner.cpp +++ b/src/gui/systemd/systemdprocessrunner.cpp @@ -128,7 +128,7 @@ void SystemdProcessRunner::startProcess() // so we can be notified (see https://github.com/systemd/systemd/pull/3984) {QStringLiteral("Environment"), m_process->environment()}, {QStringLiteral("WorkingDirectory"), m_process->workingDirectory()}, -            {QStringLiteral("ExecStart"), QVariant::fromValue(ExecCommandList{{m_process->program().first(), m_process->program(), false}})}, +            {QStringLiteral("ExecStart"), QVariant::fromValue(ExecCommandList{{QStandardPaths::findExecutable(m_process->program().first()), m_process->program(), false}})}, }, {} // aux is currently unused and should be passed as empty array. ); </ins>

Discussion:
After the KDE Frameworks 6.3.0 update, I can no longer launch kcm modules by searching for them in Application Launcher or KRunner. I can open them directly with "systemsettings kcmabout-distro" in a terminal with no issues. I can also access them by opening systemsettings first and then clicking the particular kcm module I'm trying to access. I'm having issues getting any usable information about this bug because it launches successfully through the terminal. If this is upstream please let me know and I'll submit this over on the KDE Bugtracker. Steps to reproduce the behavior: in to KDE Plasma 6. the Meta key and type "About This System" and hit enter. that the systemsettings icon shows in task manager and then closes after a few seconds. Nothing is launched. I press the Meta key, type "About This System", hit enter, and see the kcmabout-distro module load displaying information about the system. Please run and paste the result.
Please test
Sorry, I've been crazy busy at work. I just got to test this myself and it did work in my case as well. Thanks for the quick update!
Change:
, cmake, gettext, libtool , glproto, mesa_glu , gnutls, pam, nettle <del> , xterm }: </del> <ins> , xterm, openssh }: </ins> with stdenv.lib;

Discussion:
The tigerVNC vnc client can tunnel over ssh, but does so defaulting to /usr/bin/ssh as the path to the ssh client tigervnc -via user localhost:0 Will display System: NixOS 17.03.1775. (Gorilla) Nix version: nix-env (Nix) 1.11.13 Nixpkgs version:17.03.1775. Sandboxing enabled: false
Does adding either or to the command work?
I didn't try that, but does work, which is the documented way of handling this.
I see, where is that documented? The reason I asked that is because it seemed like was set as a default parameter value , so I thought this could just be patched in nixpkgs.
Just add to the package and make a pull request:
It's documented in the tigervnc manpage for vncviewer. I'm 99% certain it's not in that Java file, but in this C++ file:
import and try the following:
Change:
<del> { stdenv, fetchurl, pkgconfig, udev, runtimeShellPackage, runtimeShell }: </del> <ins> { stdenv, fetchurl, fetchpatch, pkgconfig, udev, runtimeShellPackage, runtimeShell }: </ins> stdenv.mkDerivation rec { # when updating this to >=7, check, see previous reverts:

Discussion:
Describe the bug
cc
says the first bad commit is “dhcpcd: 8.1.2 -8.1.4” ().
And on dhcpcd says the first bad commit is rsmarples/dhcpcd “Linux: prefer ms RA times”.
cc
Sent a proposed fix upstream as rsmarples/dhcpcd.
And sent the fix here as .
Change:
wrapProgram $out/bin/nixos-test-driver  --set startScripts "''${vmStartScripts[*]}"  --set testScript "$out/test-script"  <del> --set vlans '${toString vlans}' </del> <ins> --set vlans '${toString vlans}'  ${lib.optionalString (interactive) "--add-flags --interactive"} </ins> ''); # Make a full-blown test

Discussion:
When building an interactive test driver with and running the generated binary, the test just runs without an interactivity. Steps to reproduce the behavior: that the test just starts instead of displaying the interactive prompt. I'd expect to be dropped into the interactive prompt. cc as someone who's touched a lot.
Mostly reviews and minor additions though. Maybe broke it, but that's just a guess. Probably best to bisect with if going back to before that doesn't fix the problem.
Ah, it was broken by
Change:
in lib.optionalString stdenv.hostPlatform.isDarwin darwinPatches + genericPatches; <del> buildInputs = [buildJdk] ++ defaultShellUtils; </del> <ins> buildInputs = [buildJdk bashWithDefaultShellUtils] ++ defaultShellUtils; </ins> # when a command can’t be found in a bazel build, you might also # need to add it to `defaultShellPath`.

Discussion:
I'm trying to use from nixpkgs on my laptop and use remote builders (buildbarn). This fails due to patches that are applied in nixpkgs. Vanilla Bazel has a hardcoded fallback path for bash () . This has the downside of not producing a working fallback for (bash from nixpkgs will default initialize as ). The workaround for this is to default initialize the path variables somewhere else. Currently, this is done . This works fine for local execution, since this is where this function is called. However, this function is never called for remote execution (it is a hack to override things for the local execution environment only). So when using Bazel from nixpkgs locally and enabling remote execution, the shell is set to a bash from nixpkgs during the analysis phase but the variable is explicitly left unset by many actions, leading to the PATH in bash being and resulting in errors when executing tools in a script. I think there are two possible solutions: when using remote execution, do not replace the hardcoded (this is probably not a great fix since it only works for FHS executors) instead of replacing with a regular bash from nixpkgs, add a little helper script that adds shell utils to . This way, any shell rule created by bazel has a minimal set of tools. use when turning on remote execution. This has the downside of only working when the remote builder has a shell in that path. See this for a detailed reproducer: Using bazel from nixpkgs should work with remote execution. Using this version of bazel with remote execution is becoming more viable due to <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- [^1]: [^2]:
got reverted, I'll reopen it.
Could we also remove the related patch here -, or is it still needed for some reason ?
To the best of my understanding, it should be sufficient to use a prepared bash (with tools in the PATH) and remove the patch you mentioned. Probably still a good idea to test this in practice!