jiebi/CodeConvo huggingface dataset:
Change:
]; postInstall = '' <ins> install -D -m 644 misc/rio.desktop -t $out/share/applications install -D -m 644 rio/src/screen/window/resources/images/logo.png  $out/share/icons/hicolor/scalable/apps/rio.png </ins> install -dm 755 "$terminfo/share/terminfo/r/" tic -xe rio,rio-direct -o "$terminfo/share/terminfo" misc/rio.terminfo mkdir -p $out/nix-support

Discussion:
Package name: Rio Latest released version: v0.0.19 <!-- Search your package here: --- Current version on the unstable channel: v0.018 Current version on the stable/release channel: N/A <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Change:
<ins> { lib, astropy, bottleneck, buildPythonPackage, cython, extension-helpers, fetchFromGitHub, gwcs, matplotlib, numpy, photutils, pythonOlder, rasterio, scikit-image, scikit-learn, scipy, setuptools-scm, setuptools, shapely, tomli, tqdm, python, wheel, }: buildPythonPackage rec { pname = "photutils"; version = "1.12.0"; pyproject = true; disabled = pythonOlder "3.10"; src = fetchFromGitHub { owner = "astropy"; repo = "photutils"; rev = "refs/tags/${version}"; hash = "sha256-k5MxpkCAvefSRoNPMAVIvNcCTU5HPicU4XSFXk13O9Q="; }; postPatch = '' substituteInPlace pyproject.toml  --replace-fail "'numpy>=2.0.0rc1'," "" ''; build-system = [ setuptools setuptools-scm wheel ]; nativeBuildInputs = [ cython extension-helpers numpy ]; dependencies = [ astropy numpy ]; passthru.optional-dependencies = { all = [ bottleneck gwcs matplotlib rasterio scikit-image scikit-learn scipy shapely tqdm ]; }; # With 1.12.0 tests have issues importing modules doCheck = false; pythonImportsCheck = [ "photutils" ]; meta = with lib; { description = "Astropy package for source detection and photometry"; homepage = "https://github.com/astropy/photutils"; changelog = "https://github.com/astropy/photutils/blob/${version}/CHANGES.rst"; license = licenses.bsd3; maintainers = with maintainers; [ fab ]; }; } </ins>

Discussion:
Project description Photutils is an Astropy package for detection and photometry of astronomical sources. Metadata homepage URL: source URL: license: 3-clause BSD platforms: unix, linux, darwin, Linux, Darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I could to built here withou errors from source, just the 1.11.0 version, it is not the latest one. My nix block:
Change:
, mkDerivation , fetchurl , cmake <ins> , flatbuffers </ins> , gettext , pkg-config , libdigidocpp

Discussion:
Package name: qdigidoc Latest released version: 4.4.0 <!-- Search your package here: --- Current version on the unstable channel: 4.2.12 Current version on the stable/release channel: 4.2.12 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers Note for maintainers: Please tag this issue in your PR.
Change:
doCheck = true; checkInputs = [ <del> unixtools.script </del> pytest coverage flake8

Discussion:
Describe the bug yq fails to install with the latest nixpkgs and/or version. To Reproduce Steps to reproduce the behavior: -channel --update; nix-env -iA -env -i yq Expected behavior Installs without error. Additional context I had previously happily installed yq with an older nixpkgs-unstable. Upgrading myPackages failed with yq included. So I excluded it to proceed. Attempting to re-install it individually fails with an illegal arg. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata Please run and paste the result. Maintainer information:
Change:
<del> diff --git a/src/ppp-manager/nm-ppp-manager.c b/src/ppp-manager/nm-ppp-manager.c index 89a7add..ae99eb4 100644 --- a/src/ppp-manager/nm-ppp-manager.c +++ b/src/ppp-manager/nm-ppp-manager.c @@ -843,7 +843,7 @@ create_pppd_cmd_line (NMPPPManager *self, </del> <ins> --- NetworkManager-1.6.2.org/src/ppp/nm-ppp-manager.c	2017-02-15 13:10:27.000000000 +0100 +++ NetworkManager-1.6.2/./src/ppp/nm-ppp-manager.c	2017-04-03 11:45:39.891653216 +0200 @@ -724,7 +724,7 @@ </ins> g_return_val_if_fail (setting != NULL, NULL);

Discussion:
After nixos-rebuild switch, the network-manager service goes down and immediately segfaults every time it tries to come up again. journalctl for the segfault message or something, anyway, at this point I don't have working network anymore. nixos 17.09pre104870.
Specifically it segfaults because returns a non-zero exit status (saying "No for interface NetworkManager"); the segfault itself appears fixes in their HEAD. I haven't checked whether that makes it actually work, yet, but maybe we could arrange for it to have a in the meantime, whatever that means.
In which commit it was fixed?
Does this also happen in 17.03?
Happens with both the 17.03 tag and the 17.03 channel. Looks like cherry-picking the above commit as a patch for our network-manager lets it work correctly, btw.
also fixed in 17.03:
Change:
#!@shell@ <ins> # shellcheck shell=bash </ins> if [ -n "$DEBUG" ] ; then set -x fi

Discussion:
Describe the bug appimage-run can't run appimages containing /bin/sh for example the one in attachment. it was created with nix-bundle and works with ubuntu. To Reproduce Steps to reproduce the behavior: the appimage: Expected behavior Hello world Additional context Works with the appimage-run in 20.03: Also works if the link to /bin/sh is omitted. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --cc Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(symphorien): nixpkgs: Maintainer information:
Maybe we need in some of the fhsUserenv's in ?
Mhm. That should be the case usually: I don't know what the issue is here.
the fact that offset is 0 looks wrong
oh the problem is fixed by exporting LANG=C
Change:
<del> commit c44347b3b813e209fff537b4d46d23430727a5e2 Author: Bernardo Meurer <meurerbernardo@gmail.com> Date:   Tue Feb 25 21:27:39 2020 -0800 makefile: correctly sed paths The default Makefile for tlp makes a mess with catenating `DESTDIR` to everything, but then not actualy using the catenated (_ prefixed) variables to sed it's `.in` files. This patch makes sure that it correctly sets the paths, taking `DESTDIR` in account where it makes sense (e.g. /bin where we want $out/bin) but not where it doesn't (/etc/tlp.conf should be just that). The reason DESTDIR is used at all, as opposed to the more appropriate PREFIX, is covered in the nix formula, and is (also) due to the Makefile being a bit "different." diff --git a/Makefile b/Makefile index b5af74e..95122df 100644 --- a/Makefile +++ b/Makefile @@ -47,17 +47,17 @@ _TPACPIBAT = $(DESTDIR)$(TPACPIBAT) SED = sed  -e "s|@TLPVER@|$(TLPVER)|g"  -	-e "s|@TLP_SBIN@|$(TLP_SBIN)|g"  -	-e "s|@TLP_TLIB@|$(TLP_TLIB)|g"  -	-e "s|@TLP_FLIB@|$(TLP_FLIB)|g"  -	-e "s|@TLP_ULIB@|$(TLP_ULIB)|g"  +	-e "s|@TLP_SBIN@|$(_SBIN)|g"  +	-e "s|@TLP_TLIB@|$(_TLIB)|g"  +	-e "s|@TLP_FLIB@|$(_FLIB)|g"  +	-e "s|@TLP_ULIB@|$(_ULIB)|g"  -e "s|@TLP_CONFUSR@|$(TLP_CONFUSR)|g"  -e "s|@TLP_CONFDIR@|$(TLP_CONFDIR)|g"  -	-e "s|@TLP_CONFDEF@|$(TLP_CONFDEF)|g"  +	-e "s|@TLP_CONFDEF@|$(_CONFDEF)|g"  -e "s|@TLP_CONF@|$(TLP_CONF)|g"  -e "s|@TLP_RUN@|$(TLP_RUN)|g"    -e "s|@TLP_VAR@|$(TLP_VAR)|g"    -	-e "s|@TPACPIBAT@|$(TPACPIBAT)|g" +	-e "s|@TPACPIBAT@|$(_TPACPIBAT)|g" INFILES =  tlp  </del>

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.3.1 desired version: 1.4.0 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
''; configureFlags = [ <del> ''--with-mountutildir="$out/sbin" --localstatedir=/var'' </del> <ins> ''--localstatedir=/var'' </ins> ]; makeFlags = "DESTDIR=$(out)";

Discussion:
The glusterfs derivation does not install mount.glusterfs. So it is not possible to mount glusterfs filesystems. ls /nix/store/8p888wid9lm02zw0gaqzdzv41d8yc75r-glusterfs-3.8.1/sbin fusermount-glusterfs gfindmissingfiles glfsheal gluster glusterd glusterfind glusterfs glusterfsd Install glusterfs and try to mount a glusterfs. Even if you don't have a cluster ready, mount should return an error: mount -t glusterfs 172.16.0.167:/var/gluster/testvol tmp/mnt Look inside the sbin folder, there is no mount.glusterfs file. The makefile that install mount.glusterfs () concatenates and to find the right directory. For an unknown reason, the configure flags set mountutildir to but when executed by the Makefile it get evaluated to . So by removing the configureFlag the file get installed properly. But then this script is not able to find basic utilities like sed, cat, grep, etc because no PATH is set. We can use makeWrapper to set it. On the postInstall phase I add: wrapProgram { [ pkgs.coreutils pkgs.gnugrep]}" And I also add makeWrapper to buildInputs. It still print an error about not found (even so it is in the PATH) but at least I can mount my glusterfs volumes. Should I do a PR for this or will someone else provide a better fix? System: 16.09.1272. (Flounder) Nix version: nix-env (Nix) 1.11.4 Nixpkgs version: "16.09.1272."
Possible (just run ), but point taken. Hm, I guess long long ago it tried to install to global and failed. Then I didn't notice the Makefile improvement during the updates… Not sure a better fix is possible here. Yes, a PR would be welcome.
Change:
{ stdenv, substituteAll, fetchurl <del> , zlib ? null, zlibSupport ? true, bzip2, pkgconfig, libffi </del> <ins> , zlib ? null, zlibSupport ? true, bzip2, pkgconfig, libffi, libunwind, Security </ins> , sqlite, openssl_1_0_2, ncurses, python, expat, tcl, tk, tix, xlibsWrapper, libX11 , self, gdbm, db, lzma , python-setup-hook

Discussion:
Describe the bug pypy3 cannot be installed using on macOS. The package fails to build from source. To Reproduce Steps to reproduce the behavior: latest macOS (Catalina 10.15, but same error on previous version) latest (master) to home.packages ( from binary cache does work/does not have this problem) Expected behavior pypy3 package builds successfully (including all needed deps). Output/Errors Error encountered during compilation: Metadata
I am also not sure why from binary cache is not used (for pypy's dependency, it is compiled from source), but that could be my misunderstanding of normal behaviour -- I'm new!
Change:
<del> { fetchurl, stdenv, mesa, freeglut, libX11, plib, openal, freealut, libXrandr, xproto, </del> <ins> { fetchpatch, fetchurl, stdenv, mesa, freeglut, libX11, plib, openal, freealut, libXrandr, xproto, </ins> libXext, libSM, libICE, libXi, libXt, libXrender, libXxf86vm, libvorbis, libpng, zlib, bash, makeWrapper }:

Discussion:
failed to build with Full building log exists but I am not sure how to apply it correctly. Could be easy for anyone who know the process. $ cd /nix/nixpkgs/; git rev-parse HEAD $ nix-shell -I nixpkgs=/nix/nixpkgs -p torcs 2&1 | tee System: NixOS: (Impala) Nix version: nix-env (Nix) 1.11.15 Nixpkgs version: "18.03pre117327." Sandboxing enabled: build-use-sandbox = true
Change:
postPatch = '' sed -i 's/==.*$//' requirements.txt <ins> # can't be fetchpatched as it is essentially empty and it complains about that # TODO: drop when updating to a version that includes https://github.com/searxng/searxng/pull/3563 touch searx/answerers/random/__init__.py touch searx/answerers/statistics/__init__.py </ins> ''; preBuild =

Discussion:
The user's Special Queries preferences page is blank. the searx service: The Special Queries page should be filled in. ! The empty Special Queries preferences page. ! While investigating this problem I noticed that the directory is blank (save for and ) while this directory should have something in . I'm not sure if this is related. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Good catch! I think they are missing the Let me test that out.
Will be fixed with
Change:
<ins> From 0c1357470450d98b3b7fe5444ac460ba9ee04425 Mon Sep 17 00:00:00 2001 From: Jeremy Cutler <jerz4lunch@users.noreply.github.com> Date: Mon, 17 Jun 2024 02:19:33 -0700 Subject: [PATCH 1/2] Update lrc.py for updated function in python-syncedlyrics See syncedlyrics commit: [here](https://github.com/moehmeni/syncedlyrics/commit/64d3f9de3d17bec69cbc3b3b5acd1ab847fde4b2) --- spotdl/utils/lrc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spotdl/utils/lrc.py b/spotdl/utils/lrc.py index 726fefbee..e59490b53 100644 --- a/spotdl/utils/lrc.py +++ b/spotdl/utils/lrc.py @@ -7,7 +7,7 @@ from pathlib import Path from syncedlyrics import search as syncedlyrics_search -from syncedlyrics.utils import is_lrc_valid, save_lrc_file +from syncedlyrics.utils import has_translation, save_lrc_file from spotdl.types.song import Song @@ -25,7 +25,7 @@ def generate_lrc(song: Song, output_file: Path): - output_file: Path to the output file """ -    if song.lyrics and is_lrc_valid(song.lyrics): +    if song.lyrics and has_translation(song.lyrics): lrc_data = song.lyrics else: try: From bfa9456049132e64b5c83655bdeae7c9dcd1b532 Mon Sep 17 00:00:00 2001 From: Jeremy Cutler <jerz4lunch@users.noreply.github.com> Date: Wed, 26 Jun 2024 18:06:59 -0700 Subject: [PATCH 2/2] Update lrc.py Seems to have fixed the update of syncedlyrics to 1.0.0 --- spotdl/utils/lrc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spotdl/utils/lrc.py b/spotdl/utils/lrc.py index e59490b53..cf7478214 100644 --- a/spotdl/utils/lrc.py +++ b/spotdl/utils/lrc.py @@ -7,7 +7,7 @@ from pathlib import Path from syncedlyrics import search as syncedlyrics_search -from syncedlyrics.utils import has_translation, save_lrc_file +from syncedlyrics.utils import has_translation, Lyrics from spotdl.types.song import Song @@ -34,7 +34,7 @@ def generate_lrc(song: Song, output_file: Path): lrc_data = None if lrc_data: -        save_lrc_file(str(output_file.with_suffix(".lrc")), lrc_data) +        Lyrics.save_lrc_file(str(output_file.with_suffix(".lrc")), lrc_data) logger.debug("Saved lrc file for %s", song.display_name) else: logger.debug("No lrc file found for %s", song.display_name) </ins>

Discussion:
Steps to reproduce the behavior: spotdl. Building from rev . <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (maintainer) (recent commit) Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<del> { lib, nixosTest, path, writeText, hello, figlet, stdenvNoCC }: </del> <ins> { lib, nixosTest, pkgs, writeText, hello, figlet, stdenvNoCC }: # -------------------------------------------------------------------------- # # #                         trivial-builders test # # -------------------------------------------------------------------------- # # #  This file can be run independently (quick): # #      $ pkgs/build-support/trivial-builders/test.sh # #  or in the build sandbox with a ~20s VM overhead # #      $ nix-build -A tests.trivial-builders # # -------------------------------------------------------------------------- # let invokeSamples = file: lib.concatStringsSep " " ( lib.attrValues (import file { inherit pkgs; }) ); in </ins> nixosTest { name = "nixpkgs-trivial-builders"; nodes.machine = { ... }: {

Discussion:
There is an issue in the test by . This line introduces a dependency on the contents of nixpkgs, making every change evaluate with a different hash. cc
Steps to reproduce:
You're absolutely right, but I don't think I see the impact of this fact. It's not recursed into (no /) and it's not even built by ofborg. The test needs to compare results, but perhaps the actual evaluation can be removed from it; injected as store paths by the test runner instead. It won't make the test easier to read :(
This currently impacts every ofborg evaluation. For example:
I have no idea how to solve this. Why would ofborg have a different hash for multiple evaluations? Cause it puts stuff in the nixpkgs path?
is the whole Nixpkgs source tree, which kinda always changes. Here's a solution . Not pretty but still quick to run outside the sandbox and solves this issue.
Still an issue ?
Ofborg doesn't rebase PRs so if the PR is based on a master that's of the wrong age, you'll still see this happen. Please check that the PR includes the improved test.
I did, and it's been more than 12 hours since the commit landed. At the same time my original repro doesn't see the issue:
It's a broader issue that applies to all NixOS tests, , but it went under the radar.
This seems to be fixed now. Thanks for looking into this!
Change:
<del> { lib, stdenv, fetchurl, glibc, zlib, libxcrypt , enableStatic ? stdenv.hostPlatform.isStatic </del> <ins> { lib, stdenv, fetchurl, zlib, libxcrypt </ins> , enableSCP ? false , sftpPath ? "/run/current-system/sw/libexec/sftp-server" }:

Discussion:
Steps to reproduce the behavior: Broken from , worked in . Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
If I'm reading the log correctly, this fails already when building the glibc dependency, doesn't it? After some experimentation, I came up with the changes in
Very cool, that solves it! Thank you :)
Change:
DRM_SIMPLEDRM = whenAtLeast "5.14" no; }; <ins> fonts = { FONTS = yes; # Default fonts enabled if FONTS is not set FONT_8x8 = yes; FONT_8x16 = yes; # High DPI font FONT_TER16x32 = whenAtLeast "5.0" yes; }; </ins> video = { DRM_LEGACY = no; NOUVEAU_LEGACY_CTX_SUPPORT = whenAtLeast "5.2" no;

Discussion:
NixOS's default kernel configuration only enables the 8x8 and 8x16 fonts. This is not ideal, because they are too small for high-resolution displays. The current workaround used by is to set . There are problems with this however: during early boot, before the GPU drivers are loaded, the firmware or bootloader may initialize the display at a lower resolution, resulting in an oversized font in fact, the hidpi module sets , which in my opinion is a bad idea, because it will force switching to a low resolution when the firmware could have set us up with a high-res framebuffer; this also breaks seamless boot for those who care (sd-boot's default is to keep the mode unchanged) resolution switches reset the font to the kernel default, and under certain circumstances it seems a race condition can prevent userspace from setting the font correctly again The kernel is actually able to select an appropriate font for the current resolution using a simple heuristic since mid-2019 (). This bypasses the problems listed above and ensures a good font is always selected after resolution switches. The only requirement appears to be that the fonts must be built into the kernel. Font-related kconfig options as configured by NixOS: Arch Linux: So Arch enables the default 8x16 and Terminus 16x32 (the same font that the hidpi module sets). The observed behavior on Arch is that it seamlessly switches fonts after mode switches, and I've never seen this break since it has been enabled.
Same issue here with a NVIDIA card and a 3840x1600 monitor. tty0 console text covers the entire screen. I couldn't resolve this issue manually with and (DP-3 is my monitor). Setting the font manually to the default value () gives the right font size but this particular font doesn't have antialiasing which looks quite bad on a HIDPI monitor.
There's no antialiasing in console fonts, they're all bitmap fonts.
Gotcha, thanks. On side note, I looked for a different consolefont and came up with this. Looks a lot better now :smile:
Change:
# postBuild = '' #     wrapProgram "$out/bin/asciidoctor-epub3"  <del> #       ${lib.optionalString (epubcheck != null) "--set EPUBCHECK ${epubcheck}/bin/epubcheck"}  #       ${lib.optionalString (kindlegen != null) "--set KINDLEGEN ${kindlegen}/bin/kindlegen"} </del> <ins> #       ${lib.optionalString (epubcheck != null) "--set EPUBCHECK ${epubcheck}/bin/epubcheck"} </ins> #   ''; # passthru = {

Discussion:
. Consequently, the is broken. I suppose we need to choose whether to remove the package or find a mirror? CC maintainer: Side notes: Sadly, its replacement, , has no Linux support. But on a more positive note, there are other programs that can produce mobi files, some mentioned in .
I suggest we just drop it. Considering that kindlegen was under an unfree license, we're probably not allowed to distribute it, so let's just blow it away with a release note entry that mentions some alternatives.
I marked this as stale due to inactivity. &rarr;
My current recommendation for NixOS is to use calibre for conversion. It also has commandline tools for scripting.
Change:
hash = "sha256-pqj1LwRdOK2CUu3hYIsogQIXxWzShDuKEbDTbtWkgnQ="; }; <ins> patches = lib.optionals stdenv.isDarwin [ # https://github.com/libproxy/libproxy/pull/189 (fetchpatch { url = "https://github.com/libproxy/libproxy/commit/4331b9db427ce2c25ff5eeb597bec4bc35ed1a0b.patch"; sha256 = "sha256-uTh3rYVvEke1iWVHsT3Zj2H1F+gyLrffcmyt0JEKaCA="; }) ]; </ins> outputs = [ "out" "dev" "py3" ]; nativeBuildInputs = [

Discussion:
Steps to reproduce the behavior: See . Regression of Blocks: Blocks: porting GSound and GNOME Clocks to macOS Notify upstream: libproxy/libproxy <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
A possible fix:
That looks like an upstream bug – the build system should never use functions it is undefining. And either way, on Darwin, I would expect system JavaScriptCore to be used instead of Duktape.
Change:
description = "A small, fast, portable implementation of TLS/SSL for embedded devices"; homepage    = "https://www.wolfssl.com/"; platforms   = platforms.all; <del> license = lib.licenses.gpl2; </del> <ins> license     = licenses.gpl2Plus; </ins> maintainers = with maintainers; [ mcmtroffaes ]; }; }

Discussion:
, CVSSv3=9.8 (nixos-unstable) Scanned versions: nixos-unstable: . Cc