jiebi/CodeConvo huggingface dataset:
Change:
, sentencepiece , torchsde , transformers <ins> , pythonAtLeast </ins> }: buildPythonPackage rec {

Discussion:
Steps to reproduce the behavior: Gradio / Gradio Client <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
fix for py311
Change:
if lib.versionAtLeast (parsed.cpu.version or "0") "6" then abis.gnueabihf else abis.gnueabi <del> else if cpu == "powerpc64" then abis.elfv2 </del> else abis.gnu else                     abis.unknown; };

Discussion:
Describe the bug broke parsing of powerpc64 abi-specific configs and . Previously these ad hoc ELF ABI specifiers passed through fine. Since (cc they error with: () It's possible this only worked due to gnu-config being permissive with its parsing. The abi suffix is just a convention I came up with for powerpc64 weirdness, so I'm open to changing the way this is specified, if there is a more established convention for this. To Reproduce
Change:
LockPersonality = true; RestrictSUIDSGID = true; <ins> ReadWritePaths = [ cfg.stateDir ]; </ins> Restart = "on-failure"; RestartSec = "5s"; };

Discussion:
I wanted to setup unbound on a server. I did have this configuration: I then manually created the file using in the folder as it did not automagically create one. The folder was set to 0777 permissions and the key to 0666. I checked then the systemd status: All looked fine. Port 5335 also opened on the firewall. Basically running PiHole container there that should call unbound for recursive resolution. As systemd showed unbound running, I tried to do a query but it errored out: Interestingly I run unbound on another server. On the other server I did not set the as it does not wipe everything that's not explicitely saved (see ). I thought I would need the on this setup, as everything gets wiped on reboot that is not explicitely set to save. After removing the option from the configuration, unbound works as expected. So there are two problem with the option: does not get automagically created don't work system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Change:
sha256 = "046sqfmr84blxh4vkipmh8ff7wd19fxmh6lnr5ibchx3l02p49bc"; }; <del> patches = optional stdenv.isDarwin ./darwin-compilation.patch ++ optional doCheck ./skip-timer-test.patch ++ optionals stdenv.hostPlatform.isMusl [ ./quark_init_on_demand.patch ./gobject_init_on_demand.patch ] ++ [ ./schema-override-variable.patch # Require substituteInPlace in postPatch ./fix-gio-launch-desktop-path.patch # GLib contains many binaries used for different purposes; # we will install them to different outputs: # 1. Tools for desktop environment ($bin) #    * gapplication (non-darwin) #    * gdbus #    * gio #    * gio-launch-desktop (symlink to $out) #    * gsettings # 2. Development/build tools ($dev) #    * gdbus-codegen #    * gio-querymodules #    * glib-compile-resources #    * glib-compile-schemas #    * glib-genmarshal #    * glib-gettextize #    * glib-mkenums #    * gobject-query #    * gresource #    * gtester #    * gtester-report # 3. Tools for desktop environment that cannot go to $bin due to $out depending on them ($out) #    * gio-launch-desktop ./split-dev-programs.patch ]; </del> <ins> patches = optionals stdenv.isDarwin [ ./darwin-compilation.patch # fix loading dylibs on darwin # Remove on 2.62.1 (fetchpatch { url = "https://gitlab.gnome.org/GNOME/glib/commit/e2409e5e180f1fa369d0e87e38e4d646d9f68791.patch"; sha256 = "1dhjwlsqdgnn8fr8pzfrnd63m7pdgf7mizdyn8lwg17ggvq6qsqf"; }) ] ++ optionals stdenv.hostPlatform.isMusl [ ./quark_init_on_demand.patch ./gobject_init_on_demand.patch ] ++ [ ./schema-override-variable.patch # Require substituteInPlace in postPatch ./fix-gio-launch-desktop-path.patch # GLib contains many binaries used for different purposes; # we will install them to different outputs: # 1. Tools for desktop environment ($bin) #    * gapplication (non-darwin) #    * gdbus #    * gio #    * gio-launch-desktop (symlink to $out) #    * gsettings # 2. Development/build tools ($dev) #    * gdbus-codegen #    * gio-querymodules #    * glib-compile-resources #    * glib-compile-schemas #    * glib-genmarshal #    * glib-gettextize #    * glib-mkenums #    * gobject-query #    * gresource #    * gtester #    * gtester-report # 3. Tools for desktop environment that cannot go to $bin due to $out depending on them ($out) #    * gio-launch-desktop ./split-dev-programs.patch ] ++ optional doCheck ./skip-timer-test.patch; </ins> outputs = [ "bin" "out" "dev" "devdoc" ];

Discussion:
Describe the bug is broken on Darwin. git bisect shows (part of ) as the first failing commit To Reproduce Try to build on Darwin at <details<summarynix-build -A gobject-introspection </summary</detailsExpected behavior Able to build on Darwin Additional context <!-- There is a 10 years old bug report with the same error message --Metadata Maintainer information: cc:
Looks like this upstream issue: . It's fixed on master so we should probably pick the patches.
Our jobset needs to be building on the darwin platform if we don't want things breaking like this.
Change:
cp ${seabios}/Csm16.bin OvmfPkg/Csm/Csm16/Csm16.bin ''; <del> postFixup = if stdenv.hostPlatform.isAarch then '' </del> <ins> postFixup = ( if stdenv.hostPlatform.isAarch then '' </ins> mkdir -vp $fd/FV mkdir -vp $fd/AAVMF mv -v $out/FV/QEMU_{EFI,VARS}.fd $fd/FV

Discussion:
Steps to reproduce the behavior: pkgsCross.aarch64-multiplatform.edk2 Full log here: Few last lines: EDK2 package was updated in nixpkgs, and after that cross-compilation from x86_64 to aarch64 stopped working. The issue appeared in latest update commit: The package has no maintainers set in meta. The breaking change was introduced by: I see cross-compilation fixes have been made previously by: Other contributors who have contributed over the past year, I got from and : "Sandro Jäckel" and Please run and paste the result.
Actually I had binfmt for aarch64-linux emulated, I disabled it and now build fails even earlier when it tries to run antlr built for aarch64-linux:
Unable to reproduce: I just cross compiled EDK2 with .
Wait, I had a dinosaur nixpkgs there on a feature branch, testing again.
I concur, antlr is trying to be executed but it's not a binary for the right platform. This seems to be a breakage upstream as they seem to ship their own ANTLR binaries.
I won't have time to tackle it as I have too much on my plate right now.
Any change on looking at this now as we are going towards NixOS 23.11?
Thank you!
Change:
sphinxcontrib_httpdomain = buildPythonPackage (rec { name = "sphinxcontrib-httpdomain-1.3.0"; <del> # See issue #6548 disabled = isPyPy; </del> # Check is disabled due to this issue: # https://bitbucket.org/pypa/setuptools/issue/137/typeerror-unorderable-types-str-nonetype doCheck = false;

Discussion:
The package pypy2.4-Sphinx-1.2.3 appears to be broken in the stable channel (as well as in the master branch of the repository with pypy 2.5). My $ load-env-pypySphinx $ sphinx-quickstart
Interesting, only happens on pypy. Wrapper is not generated.
Fixed hopefully.
Tested with pypy 2.5. The sphinx-quickstart works and building a non trivial set of documentation also. Thank you.
Change:
# TODO This was always in buildInputs before, why? buildInputs = optionals withFullDeps [ libdc1394 ] ++ optionals (withFullDeps && !stdenv.isDarwin) [ libraw1394 ] # TODO where does this belong to <del> ++ optionals (withNvdec || withNvenc) [ nv-codec-headers ] </del> <ins> ++ optionals (withNvdec || withNvenc) [ (if (lib.versionAtLeast version "6") then nv-codec-headers-11 else nv-codec-headers) ] </ins> ++ optionals withAlsa [ alsa-lib ] ++ optionals withAom [ libaom ] ++ optionals withAss [ libass ]

Discussion:
Package name: ffmpeg Latest released version: 6.0 Current version on the unstable channel: 5.1.2 Notify maintainers Related: I think the way to go with such a rename should be to follow the instructions here: Note for maintainers: Please tag this issue in your PR.
Current version is 4.x, this would probably be as an extra package (ffmpeg_6 and variants)
BTW, 5.1 is LTS and should be maintained by upstream for two years, if I got it right.
I wonder if this should be closed, as default remained same. (even 4 on , but 5 soon from )
I think 6 by default is something we should do for 23.11 and keep 5 on 23.05.
ffmpeg defaults to 6 now on master
Change:
buildGoModule rec { pname = "tailscale"; <del> version = "1.38.4"; </del> <ins> version = "1.40.0"; </ins> src = fetchFromGitHub { owner = "tailscale"; repo = "tailscale"; rev = "v${version}"; <del> hash = "sha256-HjN8VzysxQvx5spXgbgbItH3y1bLbfHO+udNQMuyhAk="; </del> <ins> hash = "sha256-iPf3ams613VHPesbxoBaaw9eav5p781+wEmbJ+15yfY="; </ins> }; <del> vendorHash = "sha256-LIvaxSo+4LuHUk8DIZ27IaRQwaDnjW6Jwm5AEc/V95A="; </del> <ins> vendorHash = "sha256-lirn07XE3JOS6oiwZBMwxzywkbXHowOJUMWWLrZtccY="; </ins> nativeBuildInputs = lib.optionals stdenv.isLinux [ makeWrapper ];

Discussion:
Package name: tailscale Latest released version: 1.40.0 <!-- Search your package here: --- Current version on the unstable channel: 1.38.4 Current version on the stable/release channel: 1.38.4 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Change:
(fetchNuGet { pname = "Vortice.DirectX"; version = "2.4.2"; sha256 = "11yjyvyz922z1ygl8gxmdym3918df12nl7xxry4pdjpl8is33qic"; }) (fetchNuGet { pname = "Vortice.DXGI"; version = "2.4.2"; sha256 = "17vsnm9ca6nqk3f1dfpfvd6i6fp8x8v41bn65rchrzwcv1zzi6pz"; }) (fetchNuGet { pname = "Vortice.Mathematics"; version = "1.4.25"; sha256 = "0vl6g087disxyzskvkbnwym74s47lkza0ly3nk4y0y88zibcggrj"; }) <ins> (fetchNuGet { pname = "ZstdSharp.Port"; version = "0.7.2"; sha256 = "0ngngpjaxy3dnrz3mrfhkw52bp05n1xg4ckzf07yhc81hwzq1yi1"; }) </ins> ]

Discussion:
Package name: osu-lazer Latest released version: <!-- Search your package here: --- Current version on the unstable channel: 2023.815.0 Current version on the stable/release channel: 2023.511.0 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers Note for maintainers: Please tag this issue in your PR.
Change:
<ins> diff --git a/sendto_silhouette.inx b/sendto_silhouette.inx index 55a3278..d780730 100644 --- a/sendto_silhouette.inx +++ b/sendto_silhouette.inx @@ -188,6 +188,6 @@ Always use the least amount of blade possible. </effect> <script> -      <command location="inx" interpreter="python">sendto_silhouette.py</command> +      <command location="inx" interpreter="shell">sendto_silhouette.sh</command> </script> </inkscape-extension> diff --git a/silhouette_multi.inx b/silhouette_multi.inx index f6fd2ed..2d9dba6 100644 --- a/silhouette_multi.inx +++ b/silhouette_multi.inx @@ -31,6 +31,6 @@ </effect> <script> -      <command location="inx" interpreter="python">silhouette_multi.py</command> +      <command location="inx" interpreter="shell">silhouette_multi.sh</command> </script> </inkscape-extension> </ins>

Discussion:
Project description An extension to drive Silhouette vinyl cutters (e.g. Cameo, Portrait, Curio series) from within inkscape Metadata homepage URL: source URL: license: gpl2 platforms: unix
Change:
<del> { callPackage, fetchurl, ... } @ args: </del> <ins> { callPackage, ... } @ args: </ins> callPackage ./generic.nix (args // rec { version = "${branch}.0"; branch = "2.1"; <del> src = fetchurl { url = "mirror://gentoo/distfiles/openjpeg-${version}.tar.gz"; sha256 = "00zzm303zvv4ijzancrsb1cqbph3pgz0nky92k9qx3fq9y0vnchj"; }; </del> <ins> sha256 = "00zzm303zvv4ijzancrsb1cqbph3pgz0nky92k9qx3fq9y0vnchj"; </ins> })

Discussion:
I tried building openjpeg as a dependency when using on Mac OS X, and it failed on trying to run javac. Nevertheless, its derivation seemed to define (long line follows). The package built successfully after I installed an external JDK. It seems that for some strange reason the build script is ignoring the option.
Should fix this. JPIP builds a java component, but the cmake script does not require for
Thanks for the quick reaction! I will try the fix soon!
Change:
pkgs.iproute2 # Needed for ping "/run/wrappers" <del> ]; </del> <ins> # See https://github.com/NixOS/nixpkgs/issues/262681 ] ++ (lib.optional config.networking.resolvconf.enable config.networking.resolvconf.package); </ins> startLimitBurst = 5; startLimitIntervalSec = 20; serviceConfig = {

Discussion:
I'm using resolvconf with mullvad. By default, mullvad ignores the resolvconf configuration, replacing by itself and putting the old contents in . shows However, directly running correctly uses resolvconf. This is because when deciding which dns management strategy to use. If it can't be found, it uses instead, which directly deletes/creates/restores . This can be fixed by adding to the daemon's path in the unit file. Steps to reproduce the behavior: mullvad with resolvconf with the contents of mullvad-daemon should use resolvconf if it's enabled. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- ( ?) Please run and paste the result. system: host os: multi-user?: sandbox: version: nixpkgs:
That makes sense to me. Were you planning to open a PR? One change I would request is to only include if resolvconf is enabled, since this reference would force the package to be installed. Something like (Also yes, I renamed my GH account from patricksjackon -arcuru. I missed updating my handle here and will do that shortly).
I opened . From the maintainer perspective, for trivial changes, is it easier to review a PR? I wasn't sure whether I should open a PR or to just leave it to you.
Change:
<ins> { lib, fetchFromGitLab, rustPlatform, pkg-config, openssl, wayland, autoPatchelfHook, libxkbcommon, libGL, libX11, libXcursor, libXi, stdenv, makeWrapper, zenity, }: rustPlatform.buildRustPackage rec { pname = "surfer"; version = "0.2.0"; src = fetchFromGitLab { owner = "surfer-project"; repo = "surfer"; rev = "v${version}"; hash = "sha256-C5jyWLs7fdEn2oW5BORZYazQwjXNxf8ketYFwlVkHpA"; fetchSubmodules = true; }; nativeBuildInputs = [ pkg-config autoPatchelfHook makeWrapper ]; buildInputs = [ openssl stdenv.cc.cc.lib ]; # Wayland and X11 libs are required at runtime since winit uses dlopen runtimeDependencies = [ wayland libxkbcommon libGL libX11 libXcursor libXi ]; cargoLock = { lockFile = ./Cargo.lock; outputHashes = { "codespan-0.12.0" = "sha256-3F2006BR3hyhxcUTaQiOjzTEuRECKJKjIDyXonS/lrE="; "egui_skia-0.5.0" = "sha256-dpkcIMPW+v742Ov18vjycLDwnn1JMsvbX6qdnuKOBC4="; "tracing-tree-0.2.0" = "sha256-/JNeAKjAXmKPh0et8958yS7joORDbid9dhFB0VUAhZc="; }; }; # Avoid the network attempt from skia. See: https://github.com/cargo2nix/cargo2nix/issues/318 doCheck = false; postFixup = '' wrapProgram $out/bin/surfer  --prefix PATH : ${lib.makeBinPath [ zenity ]} ''; meta = { description = "Extensible and Snappy Waveform Viewer"; homepage = "https://surfer-project.org/"; changelog = "https://gitlab.com/surfer-project/surfer/-/releases/v${version}"; license = lib.licenses.eupl12; maintainers = with lib.maintainers; [ hakan-demirli ]; platforms = lib.platforms.linux; mainProgram = "surfer"; }; } </ins>

Discussion:
Project description A waveform viewer with a focus on a snappy usable interface, and extensibility. <!-- Describe the project a little: --Metadata homepage URL: https://surfer- source URL: license: eupl12 platforms: linux Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I tried to package it myself however, the following derivation fails: Error: Similar issue: Looks like the real issue has been solved couple years ago. I should update the derivation accordingly.
Change:
hledger = overrideCabal super.hledger (drv: { postInstall = '' for i in $(seq 1 9); do <del> for j in $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/*.$i $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/.otherdocs/*.$i; do </del> <ins> for j in $data/share/${self.ghc.name}/*-${self.ghc.name}/*/*.$i $data/share/${self.ghc.name}/*-${self.ghc.name}/*/.otherdocs/*.$i; do </ins> mkdir -p $out/share/man/man$i cp $j $out/share/man/man$i/ done done <del> mkdir $out/share/info cp $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/*.info $out/share/info/ </del> <ins> mkdir -p $out/share/info cp $data/share/${self.ghc.name}/*-${self.ghc.name}/*/*.info $out/share/info/ </ins> ''; }); hledger-ui = overrideCabal super.hledger-ui (drv: { postInstall = '' for i in $(seq 1 9); do <del> for j in $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/*.$i $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/.otherdocs/*.$i; do </del> <ins> for j in $data/share/${self.ghc.name}/*-${self.ghc.name}/*/*.$i $data/share/${self.ghc.name}/*-${self.ghc.name}/*/.otherdocs/*.$i; do </ins> mkdir -p $out/share/man/man$i cp $j $out/share/man/man$i/ done done <del> mkdir $out/share/info cp $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/*.info $out/share/info/ </del> <ins> mkdir -p $out/share/info cp $data/share/${self.ghc.name}/*-${self.ghc.name}/*/*.info $out/share/info/ </ins> ''; }); hledger-web = overrideCabal super.hledger-web (drv: { postInstall = '' for i in $(seq 1 9); do <del> for j in $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/*.$i $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/.otherdocs/*.$i; do </del> <ins> for j in $data/share/${self.ghc.name}/*-${self.ghc.name}/*/*.$i $data/share/${self.ghc.name}/*-${self.ghc.name}/*/.otherdocs/*.$i; do </ins> mkdir -p $out/share/man/man$i cp $j $out/share/man/man$i/ done done <del> mkdir $out/share/info cp $data/share/${self.ghc.name}/${pkgs.stdenv.system}-${self.ghc.name}/*/*.info $out/share/info/ </del> <ins> mkdir -p $out/share/info cp $data/share/${self.ghc.name}/*-${self.ghc.name}/*/*.info $out/share/info/ </ins> ''; });

Discussion:
hledger fails to build on darwin system: host os: multi-user?: sandbox: version: channels(clacke): The commit that introduced the error was . The install code assumes the man pages will be there and that will be run, so the *.info install only does and fails. The root problem is that it looks for man and info files in . On linux this works, but on darwin is , whereas ghc calls the system in the directory name.
Change:
<literal>CI_SERVER_URL=&lt;CI server URL&gt;</literal> <literal>REGISTRATION_TOKEN=&lt;registration secret&gt;</literal> <ins> WARNING: make sure to use quoted absolute path, or it is going to be copied to Nix Store. </ins> ''; }; registrationFlags = mkOption {

Discussion:
Describe the bug A file that is explicitly created to contain secrets, namely the for new gitlab runners ends up in the nix store To Reproduce Steps to reproduce the behavior: a gitlab runner with the module Expected behavior Secrets don't end up in the nix store Screenshots Contents of : Notify maintainers Metadata Maintainer information:
Could you please share your config?
Using unquoted paths will always copy them to nix store. You should use instead of
Yes, but there should be a check that this doesn't happen. It's still an information disclosure.
What if user wants them to be in nix store?
I could add a warning if is in . This will still allow doing whatever user wants to. Should I open pull-request with this change?
I think that is a good compromise.
please take a look at
I marked this as stale due to inactivity. &rarr;
I appreciate that you did something about this problem. I also get this warning for my config, which does something like this: In that case the warning is a false positive, because the registration token itself does not actually end up in the store. I think to avoid this problem the secret by itself would have to be represented in its own field as part of the service configuration so that the warning can look at that field by itself. I'm not sure if what I am doing in my config is a good way to make that happen and it's not a universal solution. Usually I would prefer my configs to not run code. Maybe this can be taken into account as part of some future work, for example if someone implements and changes registration anyways. It would be great if there was a better solution for this general problem, because even if a user sees the warning and fixes the issue the registration token is already in the store at that point and getting it back out is a pain. Right now probably not even an error would prevent it from ending up in the store.
I use sops and I've had a related issue where I can only reference the path to the token. I ended up with:
nevermind this seems to break the way the gitlab module works (my module contains 3 runners, the gitlab module creates the 3 but then remove 1 in a cyclic fashion). I will try your solution instead .

EDIT: so in fact my technique should work, I just hadn't realized that the gitlab runner is registering the runners everytime, wich is quite different from what we did before. The current approach forces to keep a registration token around which could be seen as a security flaw vs just giving a runner token. I will subscribe to
Change:
- `network-interfaces.target` system target was removed as it has been deprecated for a long time. Use `network.target` instead. <ins> - `services.redis.vmOverCommit` now defaults to `true` and no longer enforces Transparent Hugepages (THP) to be disabled. Redis only works with THP configured to `madvise` which is the kernel's default. </ins> - `azure-cli` now has extension support. For example, to install the `aks-preview` extension, use ```nix

Discussion:
Describe the bug A clear and concise description of what the bug is. To Reproduce Steps to reproduce the behavior: redis via: at the log and observe: Expected behavior No warnings or errors in log. Additional context I thought line was supposed to prevent such a warning... :thinking: Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --ping Metadata Please run and paste the result. Maintainer information:
If the sysctl doesn't work, we can probably also put the suggested line into the script. :thinking: This should be relatively easy to test, given we have a NixOS vm test :-)
As long as another solution does not fail loudly in containers, i.e. reintroduce bug which we fixed by switching to sysctl. I’m game. But my question is: Is the broken since that "fix"? Can others reproduce this issue? Or is maybe running redis in a container where this line doesn’t take effect?
I'm just running on a regular NixOS install which happens to be running on VMWare.
Strange... when I add to the test I don't see the warning :thinking:
I marked this as stale due to inactivity. &rarr;