jiebi/CodeConvo huggingface dataset:
Change:
, curl , enableTNC            ? false, trousers, sqlite, libxml2 , enableNetworkManager ? false, networkmanager <ins> , libpcap </ins> }: # Note on curl support: If curl is built with gnutls as its backend, the

Discussion:
This is addressed on staging by which doesn't seem appropriate for master due to the amount of rebuilds. The build failure is blocking two tests on the channel. master
There's also which turns on by default, preventing these problems more generally (would also have to go through staging of course). Hydra has almost nothing to do at the moment though , so we should probably start up staging-next again.
Change:
meritous = callPackage ../games/meritous { }; <ins> oh-my-git = callPackage ../games/oh-my-git { }; </ins> opendune = callPackage ../games/opendune { }; merriweather = callPackage ../data/fonts/merriweather { };

Discussion:
Project description made with godot engine it does not run with steam-run (), so a proper package would be great Metadata homepage URL: source URL: license: Blue Oak Model License platforms: linux, darwin, windows
Change:
, ninja , wrapGAppsHook4 , libadwaita <ins> , xdotool , wl-clipboard </ins> }: python3.pkgs.buildPythonApplication rec {

Discussion:
The emoji picker terminates unexpectedly upon clicking an emoji. Steps to reproduce the behavior: any X desktop environment, and make sure is not installed an emoji error message: The emoji is inserted in the current window and the emoji picker exits gracefully. N/A N/A Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thank you!
Change:
markdownlint-cli = pkgs.markdownlint-cli; # added 2023-07-29 inherit (pkgs) markdownlint-cli2; # added 2023-08-22 mdctl-cli = self."@medable/mdctl-cli"; # added 2023-08-21 <ins> musescore-downloader = pkgs.dl-librescore; # added 2023-08-19 </ins> node-inspector = throw "node-inspector was removed because it was broken"; # added 2023-08-21 readability-cli = pkgs.readability-cli; # Added 2023-06-12 reveal-md = pkgs.reveal-md; # added 2023-07-31

Discussion:
I'm trying to package which directly depends on I get the following error: If I set , then I get the following error from npm: The error messages are good enough at explaining why it's a problem, but I don't know how to fix it. I'd appreciate some help! I cannot feasibly remove the pdfkit dependency because generating PDFs is essential functionality of this package. Steps to reproduce the behavior: to build the package from , e.g. by issuing: The package builds. cc
Setting should fix that problem specifically but there are more issues which the git deps error is warning will probably be the case So the problem specifically is: dl-librescore depends on pdfkit as a git dep rather than registry dep pdfkit doesn't have a npm lockfile (only a ) npm requires dev dependencies for git deps that have install scripts (which pdfkit has) npm does not lock transitive dev dependencies at all, so without an upstream npm lockfile then there just is no (npm) lock information for these required dev dependencies There's only so much we can do downstream about this, but we have had some ideas for how to deal with mixed lockfiles (like having a in a git dev dep with install scripts), but it'll be a good while before we get around to implementing such a thing (since it's more in the "nice to have" rather than "required for many packages" sort of thing) As for what you can do about it now, here are some options: to depend on only as a registry dep rather than git dep out install scripts from really needs an unreleased version, pester to make a new release and then have depend on as a registry dep similar to option 1 I wish I had better news for you, but npm is kinda hell in regards to git deps :(
Change:
, darwin , withLibsecret ? false , pkgconfig, glib, libsecret <ins> , gzip # needed at runtime by gitweb.cgi </ins> }: assert sendEmailSupport -> perlSupport;

Discussion:
start a webserver that is mean to serve for the current repo. In order to do this, it generates an httpd config with But the expression for moves to a separate output. Run in any repo.
Hm, ok, I have fixed the path issue, but it still doesn’t work because perl has no CGI module.
Change:
''; })) <ins> (patchExtension "pano@elhan.io" (old: { patches = [ (substituteAll { src = ./extensionOverridesPatches/pano_at_elhan.io.patch; inherit gsound libgda; }) ]; })) </ins> (patchExtension "screen-autorotate@kosmospredanie.yandex.ru" (old: { # Requires gjs # https://github.com/NixOS/nixpkgs/issues/164865

Discussion:
Project description Next-gen Clipboard Manager for Gnome Shell Metadata homepage URL: source URL: license: gpl2 platforms: linux
Change:
# Filesystem entry disappeared, so unmount it. $units_to_stop{$unit} = 1; } elsif ($cur->{fsType} ne $new->{fsType} || $cur->{device} ne $new->{device}) { <del> # Filesystem type or device changed, so unmount and mount it. $units_to_stop{$unit} = 1; $units_to_start{$unit} = 1; record_unit($start_list_file, $unit); </del> <ins> if ($mount_point eq '/' or $mount_point eq '/nix') { if ($cur->{options} ne $new->{options}) { # Mount options changed, so remount it. $units_to_reload{$unit} = 1; record_unit($reload_list_file, $unit); } else { # Don't unmount / or /nix if the device changed $units_to_skip{$unit} = 1; } } else { # Filesystem type or device changed, so unmount and mount it. $units_to_restart{$unit} = 1; record_unit($restart_list_file, $unit); } </ins> } elsif ($cur->{options} ne $new->{options}) { # Mount options changes, so remount it. $units_to_reload{$unit} = 1;

Discussion:
The script is apparently trying to stop and start changed .mount units, presumably to cause a ? If that happens the script fails and the new configuration is not activated. Worse, the system is left in a broken state with some of the stopped (as part of the switch) units never restarted. Steps to reproduce the behavior: the value of , for example from to . The unit should probably not be stopped and the switch should succeed. If using remotely also the SSH connection drops. NixOS version: 23.05.1194. (Stoat) The filesystem entry is: cc:
I just ran into this error myself. I am unsure of which configuration change caused this. But I was changing config and I think was saying some setting conflicts with my , which was at . So I updated to and then flashed me this error: before giving me a black screen and send me to the login prompt.
were you ever able to fix your issue?
No fix, I'm pretty sure changing the unit will still trigger a stop.
Unfortunately, you are correct. I do have a fix in the pipeline though. improves the handling of mount units () and I plan to adapt this to fstab mounts as well (). This is currently being blocked by the fstab parser not having any tests but I plan on writing them. Will keep this issue in mind.
Now that I look at the code again… it already looks correct. Can someone with this issue post a diff of their fstab? Something like should do.
Change:
<ins> { stdenvNoCC , fetchurl , lib }: stdenvNoCC.mkDerivation rec { pname = "lxgw-wenkai-tc"; version = "1.330"; src = fetchurl { url = "https://github.com/lxgw/LxgwWenKaiTC/releases/download/v${version}/${pname}-v${version}.tar.gz"; hash = "sha256-qpX5shH1HbGMa287u/R1rMFgQeAUC0wwKFVD+QSTyho="; }; installPhase = '' runHook preInstall mkdir -p $out/share/fonts/truetype mv *.ttf $out/share/fonts/truetype runHook postInstall ''; meta = with lib; { homepage = "https://github.com/lxgw/LxgwWenKaiTC"; description = "The Traditional Chinese Edition of LXGW WenKai."; license = licenses.ofl; platforms = platforms.all; maintainers = with maintainers; [ lebensterben ]; }; } </ins>

Discussion:
Project description LXGW WenKai TC is the Traditional Chinese Edition of LXGW WenKai, where the latter has already been packaged as . Metadata homepage URL: <https URL: ofl platforms: all Below is a working package build script I tested locally, which is largely based on 's script: (I commented out field.
If that snippet is working, could you turn it into a PR? It looks good enough for inclusion to me.
Change:
<ins> diff --git a/vendor/adb/client/usb_linux.cpp b/vendor/adb/client/usb_linux.cpp index 25a50bd..0d09c47 100644 --- a/vendor/adb/client/usb_linux.cpp +++ b/vendor/adb/client/usb_linux.cpp @@ -59,8 +59,15 @@ using namespace std::literals; #define DBGX(x...) struct usb_handle { +    usb_handle() : urb_in(0), urb_out(0) { +      this->urb_in = new usbdevfs_urb; +      this->urb_out = new usbdevfs_urb; +    } + ~usb_handle() { if (fd != -1) unix_close(fd); +      delete urb_in; +      delete urb_out; } std::string path; @@ -72,8 +79,8 @@ struct usb_handle { unsigned zero_mask; unsigned writeable = 1; -    usbdevfs_urb urb_in; -    usbdevfs_urb urb_out; +    usbdevfs_urb *urb_in; +    usbdevfs_urb *urb_out; bool urb_in_busy = false; bool urb_out_busy = false; @@ -304,7 +311,7 @@ static int usb_bulk_write(usb_handle* h, const void* data, int len) { std::unique_lock<std::mutex> lock(h->mutex); D("++ usb_bulk_write ++"); -    usbdevfs_urb* urb = &h->urb_out; +    usbdevfs_urb* urb = h->urb_out; memset(urb, 0, sizeof(*urb)); urb->type = USBDEVFS_URB_TYPE_BULK; urb->endpoint = h->ep_out; @@ -343,7 +350,7 @@ static int usb_bulk_read(usb_handle* h, void* data, int len) { std::unique_lock<std::mutex> lock(h->mutex); D("++ usb_bulk_read ++"); -    usbdevfs_urb* urb = &h->urb_in; +    usbdevfs_urb* urb = h->urb_in; memset(urb, 0, sizeof(*urb)); urb->type = USBDEVFS_URB_TYPE_BULK; urb->endpoint = h->ep_in; @@ -388,7 +395,7 @@ static int usb_bulk_read(usb_handle* h, void* data, int len) { } D("[ urb @%p status = %d, actual = %d ]", out, out->status, out->actual_length); -        if (out == &h->urb_in) { +        if (out == h->urb_in) { D("[ reap urb - IN complete ]"); h->urb_in_busy = false; if (urb->status != 0) { @@ -397,7 +404,7 @@ static int usb_bulk_read(usb_handle* h, void* data, int len) { } return urb->actual_length; } -        if (out == &h->urb_out) { +        if (out == h->urb_out) { D("[ reap urb - OUT compelete ]"); h->urb_out_busy = false; h->cv.notify_all(); @@ -501,10 +508,10 @@ void usb_kick(usb_handle* h) { ** but this ensures that a reader blocked on REAPURB ** will get unblocked */ -            ioctl(h->fd, USBDEVFS_DISCARDURB, &h->urb_in); -            ioctl(h->fd, USBDEVFS_DISCARDURB, &h->urb_out); -            h->urb_in.status = -ENODEV; -            h->urb_out.status = -ENODEV; +            ioctl(h->fd, USBDEVFS_DISCARDURB, h->urb_in); +            ioctl(h->fd, USBDEVFS_DISCARDURB, h->urb_out); +            h->urb_in->status = -ENODEV; +            h->urb_out->status = -ENODEV; h->urb_in_busy = false; h->urb_out_busy = false; h->cv.notify_all(); </ins>

Discussion:
Same on nixpkgs-unstable:
see
also see
I tried cherry-picking both PR's but still unable to build on . I'm on 5.19.16 kernel.
FYI, your kernel doesn't matter. The headers used here are a separate thing.
Change:
"INSTALL_MOD_PATH=${out}" ]; <ins> postBuild = optionalString buildKernel '' find . -name "*.ko" -print0 | xargs -0 -P$NIX_BUILD_CORES strip --strip-debug ''; </ins> postInstall = optionalString buildKernel '' # Add reference that cannot be detected due to compressed kernel module mkdir -p "$out/nix-support"

Discussion:
Since , the size of the ZFS kernel modules have increased massively. For example, was 881K prior to that change, and is now 9.4M. This is a big problem for ZFS users with small /boot partitions, because assuming a zpool is the rest of the disk, it's not possible to shrink the zpool to add more space to /boot, so updates are just impossible.
My last few initrds have ballooned by about as much (14M -27M) and my boot partition is full again. Honestly, I'd be in favour of disabling BTF by default (or even reverting the patch) with the next kernel bump.
Is ZFS not meant for systems with a lot of storage? In this case the fix would be to have a larger boot partition.
Stripping debug info prior to compression seems to solve the issue:
Change:
nativeBuildInputs = [ meson ninja ]; <ins> mesonBuildType = "release"; </ins> mesonFlags = [ "-Dgit_hash=release" ]; doCheck = true;

Discussion:
Steps to reproduce the behavior: on an apple silicon darwin machine. Obtained via I know this wasn't an issue a month ago, but haven't bisected this to be able to pinpoint when this started happening. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Change:
patches = [ (fetchpatch { <del> url = "https://git.alpinelinux.org/aports/plain/community/presage/gcc6.patch"; </del> <ins> url = "https://git.alpinelinux.org/aports/plain/community/presage/gcc6.patch?id=40e2044c9ecb36eacb3a1fd043f09548d210dc01"; </ins> sha256 = "0243nx1ygggmsly7057vndb4pkjxg9rpay5gyqqrq9jjzjzh63dj"; }) ./fixed-cppunit-detection.patch

Discussion:
Steps to reproduce the behavior: the and using an overlay, . Nix twice: (building Nix that targets new store, but lives in old store) (building Nix that targets and lives in new store) for error. I'm trying to build Nix with a different store path, so it's trying to build musl, but it fails due to a hash mismatch. Current hash in should actually be since that file was recently . However, I was told it would be better to include the commit ref in the URL instead of relying on the main branch. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Change:
, vulkan-loader , vulkan-utility-libraries , writeText <ins> , libsForQt5 </ins> }: stdenv.mkDerivation rec {

Discussion:
Add vulkan-tools-lunarg to a devshell and see that the only executable it provides is vkvia. It should also at least build and provice vkconfig Steps to reproduce the behavior: vulkan-tools-lunarg to a devshell to execute vkconfig to debug your vulkan application that it is not found in your path I expected vkconfig to be built and included in the vulkan-tools-lunarg derivation
Change:
vendorSha256 = null; <ins> postInstall = '' install -D misc/systemd/ipfs.service $out/etc/systemd/system/ipfs.service install -D misc/systemd/ipfs-api.socket $out/etc/systemd/system/ipfs-api.socket install -D misc/systemd/ipfs-gateway.socket $out/etc/systemd/system/ipfs-gateway.socket substituteInPlace $out/etc/systemd/system/ipfs.service  --replace /usr/bin/ipfs $out/bin/ipfs ''; </ins> meta = with stdenv.lib; { description = "A global, versioned, peer-to-peer filesystem"; homepage = "https://ipfs.io/";

Discussion:
Describe the bug IPFS module should use upstream systemd files for socket-based activation. Right now we have a custom service file that is different from the one in ipfs-go 0.5.0. This is something quickly I can do. /cc
Change:
{ lib , stdenv , fetchurl <ins> , fetchpatch </ins> # By default, jemalloc puts a je_ prefix onto all its symbols on OSX, which # then stops downstream builds (mariadb in particular) from detecting it. This # option should remove the prefix and give us a working jemalloc.

Discussion:
does not build aarch64-darwin as of . Steps to reproduce the behavior: out . on aarch64-darwin The build to succeed or the package to be marked as broken. n/a Full build log: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Can you try with ?
Ah didn't realize this was a jemalloc failure at first. Sure, here's the result on Overriding with gives me a more substantial failure: Full build log:
From : LLVM 10.x is not compatible with aarch64-darwin and we can't use LLVM 11.x or later because of this upstream bug. So this issue is blocked until the upstream fixes
ISTM there is another issue present as aarch64-darwin as well, wrong detection of - see - adding to seems to help to build jemalloc with newer LLVM, but I am still getting test failures on aarch64-darwin.
Change:
, python3 }: <del> python3.pkgs.buildPythonApplication rec { </del> <ins> let py = python3.override { packageOverrides = self: super: { # Doesn't work with latest urwid urwid = super.urwid.overridePythonAttrs (oldAttrs: rec { version = "2.1.2"; src = fetchFromGitHub { owner = "urwid"; repo = "urwid"; rev = "refs/tags/${version}"; hash = "sha256-oPb2h/+gaqkZTXIiESjExMfBNnOzDvoMkXvkZ/+KVwo="; }; doCheck = false; }); }; }; in with py.pkgs; buildPythonApplication rec { </ins> pname = "khal"; version = "0.11.2"; <ins> pyproject = true; </ins> src = fetchFromGitHub { owner = "pimutils"; <del> repo = pname; rev = "v${version}"; </del> <ins> repo = "khal"; rev = "refs/tags/v${version}"; </ins> hash = "sha256-yI33pB/t+UISvSbLUzmsZqBxLF6r8R3j9iPNeosKcYw="; };

Discussion:
Steps to reproduce the behavior: This might be broken since but I did not bisect. maintainer: author of : Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I can confirm that broke the test. One solution would be to override the urwid version khal uses. I also suggest opening an upstream issue.
Change:
}.${stdenv.hostPlatform.parsed.abi.name} or lib.systems.parse.abis.musl; }; <ins> } // lib.optionalAttrs (stdenv.hostPlatform.system == "powerpc64-linux") { gcc.abi = "elfv2"; </ins> }; }); };

Discussion:
Describe the bug broke parsing of powerpc64 abi-specific configs and . Previously these ad hoc ELF ABI specifiers passed through fine. Since (cc they error with: () It's possible this only worked due to gnu-config being permissive with its parsing. The abi suffix is just a convention I came up with for powerpc64 weirdness, so I'm open to changing the way this is specified, if there is a more established convention for this. To Reproduce
Change:
let wantCurl = withRemote || withImportd; wantGcrypt = withResolved || withImportd; <del> version = "252.1"; </del> <ins> version = "252.3"; </ins> # Bump this variable on every (major) version change. See below (in the meson options list) for why. # command:

Discussion:
As said here , you can't download nvidia drivers from ftp, and downloads it from there. Place in your System: NixOS Nix version: Nixpkgs version:
Should be fixed by
Change:
{ lib , stdenv , fetchFromGitHub <ins> , gmic , gmic-qt </ins> }: stdenv.mkDerivation rec {

Discussion:
Steps to reproduce the behavior: gmic from There are more of those function arity errors, but just a small sample since they're the same. I'm going to assume pull in today has something to do with it. no maintainer? merged and it shows failures for gmic. gmic is used for me in GIMP and darktable. Please run and paste the result.
I will revert this preventively. There are many strange bugs happening.
Change:
oskItem ]; <ins> systemd.packages = [ pkgs.phosh ]; </ins> programs.feedbackd.enable = true; security.pam.services.phosh = {}; <ins> hardware.opengl.enable = mkDefault true; </ins> services.gnome.core-shell.enable = true; services.gnome.core-os-services.enable = true; services.xserver.displayManager.sessionPackages = [ pkgs.phosh ];

Discussion:
Phosh does not have g-s-d available, resulting in the inability to change the screen brightness using the slider in the top bar. The following error is logged: It appears that since we use systemd for gnome-session, it does not start g-s-d: Maybe we need to start phosh using systemd too. There is a . Though for GNOME Shell, g-s-d is started by and I see no such in the upstream . Perhaps we would need to add that mirror the from . cc
I've been using the systemd service, which in turn is inspired by that upstream service. I'm really not familiar with the systemd + user session stuff here, and I tried adding all the from to that session, but it doesn't start things. I assume this is a split from between user and non-user services. As is a system service this way. Is the solution to have this be a user service? Though that wouldn't help with a gdm-started session, right?
Ah, some progress: I feel this is not a solution, but a workaround. It does make keyboard shortcuts work, and brightness work. I have to check more in depth for other things. When ran under gdm (unverified as a service) it also fixes the hardware power/volume buttons being usable. Though oddly it doesn't seem to help with the night light feature. (Looking into another issue.) Could it be that we need to pass something to for it to properly manage with systemd?
Yeah, it would have to be a user service. And unless gnome-session is informed that phosh supports systemd, it will continue using the session file. So if you want the service to be used, you will have to start it manually using . I am not sure what exactly it would take, here is a and a . I also asked at the .
Looking at , we would probably “just” need: Add to Install (and patch the paths there) Create and Use instead of gnome-session flag
Ok, I gave it a try and systemd session management seems to be working. There are two patches to be upstreamed (waiting for Purism to approve my account creation), and I'm not entirely sure what is the correct way to start phoc (currently it sits outside the session).

My branch is , and it can be tested with the following configurations: Edit: Patches submitted to upstream .
I believe those systemd user services should, somehow, be part of the NixOS phosh configuration. I don't know how this could be handled, but ideally enabling posh should, by default, enable this. Or if not by default enabled, a second option like . anything against doing this way? Not sure if this can cause trouble.
Phosh is already in so I would expect it to work.
Change:
}; checkInputs = [ pytest ]; <del> propagatedBuildInputs = [numpy pandas]; </del> <ins> propagatedBuildInputs = [ numpy pandas setuptools ]; </ins> checkPhase = '' pytest $out/${python.sitePackages}

Discussion:
Since , xarray has depended on setuptools, but this is not listed in the propagatedBuildInputs Please run and paste the result.
Change:
pythonPath = with python3Packages; requiredPythonModules [ pycups pycurl dbus-python pygobject3 requests pycairo pysmbc ]; <ins> preConfigure = '' intltoolize --copy --force --automake ''; </ins> configureFlags = [ "--with-udev-rules" "--with-udevdir=${placeholder "out"}/etc/udev"

Discussion:
Describe the bug fails to build in the latest nixos-unstable (). This seems to be caused by a failing test: I'm running right now and will update this issue when it's done. To Reproduce Steps to reproduce the behavior: Additional context <details<summaryComplete build logs</summary</detailsNotify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --There aren't any maintainers listed :( Metadata system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
Seems to be a side effect of switching to Python 3.9 as default. Upstream has resolved this issue in v1.5.13 and newer.
I opened a PR that should fix this . As there are, as you mentioned, no maintainers, would you mind taking a look and leaving a review?
I still run into this issue on unstable?
Right now unstable is still at You can check to see when the channels were last updated.
Change:
gviz-api = callPackage ../development/python-modules/gviz-api { }; <ins> gwcs = callPackage ../development/python-modules/gwcs { }; </ins> gym = callPackage ../development/python-modules/gym { }; gym-notices = callPackage ../development/python-modules/gym-notices { };

Discussion:
Project description Photutils is an Astropy package for detection and photometry of astronomical sources. Metadata homepage URL: source URL: license: 3-clause BSD platforms: unix, linux, darwin, Linux, Darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I could to built here withou errors from source, just the 1.11.0 version, it is not the latest one. My nix block: