jiebi/CodeConvo huggingface dataset:
Change:
cmakeFlags+=" -DKDE_INSTALL_KCONFUPDATEDIR=${!outputBin}/share/kconf_update" cmakeFlags+=" -DKDE_INSTALL_KAPPTEMPLATESDIR=${!outputDev}/share/kdevappwizard/templates" cmakeFlags+=" -DKDE_INSTALL_KFILETEMPLATESDIR=${!outputDev}/share/kdevfiletemplates/templates" <del> cmakeFlags+=" -DKDE_INSTALL_KXMLGUIDIR=${!outputBin}/share/kxmlgui6" </del> <ins> cmakeFlags+=" -DKDE_INSTALL_KXMLGUIDIR=${!outputBin}/share/kxmlgui5"  # Yes, this needs to be 5 and not 6. Don't ask. </ins> cmakeFlags+=" -DKDE_INSTALL_KNOTIFYRCDIR=${!outputBin}/share/knotifications6" cmakeFlags+=" -DKDE_INSTALL_ICONDIR=${!outputBin}/share/icons" cmakeFlags+=" -DKDE_INSTALL_LOCALEDIR=${!outputLib}/share/locale"

Discussion:
I am on the unstable channel, running KDE. When I install ktorrent 24.02.2 (kdePackages.ktorrent) some toolbar buttons like start, pause and stop a torrent is missing. When I try version 23.08.5 (libsForQt5.ktorrent) they are there as expected. Steps to reproduce the behavior: ktorrent 24.02.2 (kdePackages.ktorrent) at the toolbar. There is only new, open and paste icons. click and select configure toolbar, there should be a drop down menu for selecting torrent icons but it's missing. V.23: ! V.24: ! Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Apparently it's the new intended default layout? There's a 'Configure Toolbars...' button in Settings menu
Perhaps you are right, now I looked at the screenshot of ktorrent on KDE website and I don't see those buttons either. That's odd, so now people have to use hotkeys to manage torrents? That's very silly if they removed important toolbar buttons, it's something the Gnome team does but I don't expect KDE team to do it. Settings Configure Toolbars does not contain the missing buttons. On v23 there is a drop down menu there where the torrent management icons are. I am on Plasma 6.
Looks like it can't find the kxmlgui layout files
Is that something you could fix? I see that on Arch Linux those files for package ktorrent 24.02.2 are in the folder /usr/share/kxmlgui5/ktorrent/. On nix the files are in /nix/store/phi9j2i10065cqhs89wkr8c0ap1hrypx-ktorrent-24.02.1/share/kxmlgui6/ktorrent/. Perhaps the Arch maintainers copied the files from the older version and that's why there is a kxmlgui5 folder instead of kxmlgui6. Maybe the buttons are present on Arch, I can not test now. If this can not be fixed then this report can be closed and I will have to either use hotkeys or switch to qbitorrent.

Yeah, it looks for kxmlgui5 directory while nixpkgs seem to force kxmlgui6
Oh great, kxmlgui has kxmlgui5 hardcoded in a bunch of places to this day.
Please test
Change:
libXext libXfixes libXtst <del> libxml2 </del> libxfce4ui libxfce4util wayland

Discussion:
Missing dependency on breaks "Open Terminal Here" functionality Steps to reproduce the behavior:  without in that right clicking and selecting "Open Terminal Here" is broken Package should handle so users don't have to manually install Possible to fix by wrapping lines occur in <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
--set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)"  --set-rpath "${libPath}"  opt/vivaldi/vivaldi-bin <ins> '' + stdenv.lib.optionalString proprietaryCodecs '' sed -i '/^VIVALDI_FFMPEG_FOUND/ a  checkffmpeg "${vivaldi-ffmpeg-codecs}/lib/libffmpeg.so"' opt/vivaldi/vivaldi '' + '' </ins> echo "Finished patching Vivaldi binaries" '';

Discussion:
H.264 videos and specifically those (WebM and Theora are fine) don't play, which means that videos on Facebook and Twitter (at least) report an error. There are instructions for getting a patched version of the ffmpeg lib installed into your home folder which works, but ideally wouldn't be needed: to that the H.264 video don't work but the others do. System: (NixOS: , Ubuntu/Fedora: , ...) Nix version: (run ) Nixpkgs version: (run ) Sandboxing enabled: (run )
What browser are you using? Works on Chromium, Firefox and qutebrowser (qtwebkit) on master for me.
Vivaldi, hence the title of the issue...
Oh, sorry, didn't know there's a browser called vivaldi.
Change:
preConfigure = '' rm cmake/FindNETPBM.cmake <del> echo "SET(NETPBM_LIBRARY `find ${netpbm} -name "*.${stdenv.hostPlatform.extensions.sharedLibrary}*" -type f`)" >> cmake/FindNETPBM.cmake echo "SET(NETPBM_LIBRARIES `find ${netpbm} -name "*.${stdenv.hostPlatform.extensions.sharedLibrary}*" -type f`)" >> cmake/FindNETPBM.cmake echo "SET(NETPBM_INCLUDE_DIR ${netpbm}/include/netpbm)" >> cmake/FindNETPBM.cmake </del> <ins> echo "SET(NETPBM_LIBRARY `find ${stdenv.lib.getLib netpbm} -name "*.${stdenv.hostPlatform.extensions.sharedLibrary}*" -type f`)" >> cmake/FindNETPBM.cmake echo "SET(NETPBM_LIBRARIES `find ${stdenv.lib.getLib netpbm} -name "*.${stdenv.hostPlatform.extensions.sharedLibrary}*" -type f`)" >> cmake/FindNETPBM.cmake echo "SET(NETPBM_INCLUDE_DIR ${stdenv.lib.getDev netpbm}/include/netpbm)" >> cmake/FindNETPBM.cmake </ins> echo "INCLUDE(FindPackageHandleStandardArgs)" >> cmake/FindNETPBM.cmake echo "FIND_PACKAGE_HANDLE_STANDARD_ARGS(NETPBM DEFAULT_MSG NETPBM_LIBRARY NETPBM_INCLUDE_DIR)" >> cmake/FindNETPBM.cmake '';

Discussion:
no $ Add to installPhase
For some reason netpbm is installing the symlink to . Will be fixed by

Describe the bug Netpbm misses TIFF converters, such as . To Reproduce Steps to reproduce the behavior: to find some commands. Expected behavior TIFF converters installed with Netpbm. Additional context libtiff is required to build the following Netpbm programs: , , and (). Indeed is input for the , but TIFF converters are missed. Metadata output:
Change:
in { libressl_3_4 = generic { version = "3.4.3"; <del> sha256 = "sha256-/4i//jVIGLPM9UXjyv5FTFAxx6dyFwdPUzJx1jw38I0="; </del> <ins> hash = "sha256-/4i//jVIGLPM9UXjyv5FTFAxx6dyFwdPUzJx1jw38I0="; </ins> }; libressl_3_5 = generic { <del> version = "3.5.2"; sha256 = "sha256-Vv6rjiHD+mVJ+LfXURZYuOmFGBYoOKeVMUcyZUrfPl8="; </del> <ins> version = "3.5.3"; hash = "sha256-OrXl6u9pziDGsXDuZNeFtCI19I8uYrCV/KXXtmcriyg="; </ins> }; }

Discussion:
LibreSSL 3.4 version will go EOL in October of this year, so we'll need to switch to 3.5
Change:
makeWrapper pkg-config python3 <del> ] ++ lib.optionals enableQt [ wrapQtAppsHook ]; </del> <ins> ] ++ lib.optionals enableQt [ wrapQtAppsHook ]; </ins> buildInputs = [ SDL2 <del> ffmpeg_4 (glew.override { enableEGL = forceWayland; }) </del> <ins> glew </ins> libzip <del> snappy </del> zlib <del> ] ++ lib.optionals enableQt [ </del> <ins> ] ++ lib.optionals useSystemFfmpeg [ ffmpeg ] ++ lib.optionals useSystemSnappy [ snappy ] ++ lib.optionals enableQt [ </ins> qtbase qtmultimedia <del> ] ++ lib.optionals enableVulkan [ vulkan-loader ] </del> <ins> ] ++ lib.optionals enableVulkan [ vulkan-loader ] </ins> ++ lib.optionals vulkanWayland [ wayland libffi ]; cmakeFlags = [ (lib.cmakeBool "HEADLESS" (!enableQt)) <del> (lib.cmakeBool "USE_SYSTEM_FFMPEG" true) </del> <ins> (lib.cmakeBool "USE_SYSTEM_FFMPEG" useSystemFfmpeg) </ins> (lib.cmakeBool "USE_SYSTEM_LIBZIP" true) <del> (lib.cmakeBool "USE_SYSTEM_SNAPPY" true) </del> <ins> (lib.cmakeBool "USE_SYSTEM_SNAPPY" useSystemSnappy) </ins> (lib.cmakeBool "USE_WAYLAND_WSI" vulkanWayland) (lib.cmakeBool "USING_QT_UI" enableQt) (lib.cmakeFeature "OpenGL_GL_PREFERENCE" "GLVND")

Discussion:
When adding the ppsspp package (or any of its derivates such as ppsspp-sdl-wayland) and running a game, I would get very severe graphical glitches during cutscene or video playback. After reaching out to the PPSSPP team, they mentioned that building with the USESYSTEMFFMPEG flag set to true can cause these issues and is not recommended. After locally building PPSSPP using the file from this repo modified to have USESYSTEMFFMPEG = false (and removing the ffmpeg4 build inputs), I can confirm that the games that I used to have graphical glitches on, now work perfectly. I can create a pull request for this but this is my first time working with packaging in nix and wanted to see if there was a specific reason why USESYSTEMFFMPEG is used (or if it's maybe against design principles of nix to use bundled ffmpeg libraries in apps) Steps to reproduce the behavior: package ppsspp as normal -you get behaviour similar to the before screenshot package ppsspp using modified that has USESYSTEMFFMPEG = false -you get behaviour similar to the after screenshot The after behaviour is expected. Before: <img width="567" alt="Screenshot 2024-04-16 " src=""<img width="563" alt="Screenshot 2024-04-16 " src=""After: ! Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
By default we prefer to use system libraries, in order to avoid duplication and increase "cache hits" from Hydra. Further, I particularly subscribe to some recommendations from Gentoo team: Nonetheless I will verify this issue tomorrow or asap
I agree with that statement to limit dependency bundling as much as possible, but happy to see what you get out of your testing :). I'm good for now since I build the package myself with my modified
Would be interesting to know why they bundle ffmpeg and what patches they use
Change:
meta = with lib; { description = "Mini PXE server"; maintainers = [ maintainers.raskin ]; <del> platforms = ["x86_64-linux"]; </del> <ins> platforms = [ "x86_64-linux" "aarch64-linux" ]; </ins> license = lib.licenses.free; }; }

Discussion:
I'm trying to build the netboot files for a raspberry pi, I tried both on an Ampere aarch64 and on the rRPI itself, I alwasy get this error sometimes it happens directly in the , sometimes in replace-initrd- Steps to reproduce the behavior: -build '' -A netboot tried -A netboot.aarch64-linux and adding --option system aarch64-linux, same results. error: a 'x8664-linux' with features {} is required to build '/nix/store/jbyl55lz04dmfv6blcc47zqsn38568rh-', but I am a 'aarch64-linux' with features {benchmark, big-parallel, gccarch-armv8-a, kvm, nixos-test} I altro tried cross compiling on a x8664 machine but I get the same error when it gets to replace-initrd- Please run and paste the result. this path will be fetched (0.06 MiB download, 0.30 MiB unpacked): /nix/store/x1q75v4ysr72w4x6c713cpf1dmfg18cq-bash-interactive-5.1-p16-dev copying path '/nix/store/x1q75v4ysr72w4x6c713cpf1dmfg18cq-bash-interactive-5.1-p16-dev' from ''... system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
sorry i dont have any expirience in this area but it looks like neboot builds on aarch64-linux, please test this PR
Thanks for the answer, I'll try applying the fix, I'll let you know how it goes.
Change:
homepage = "https://www.isc.org/dhcp/"; license = licenses.mpl20; platforms = platforms.unix; <ins> knownVulnerabilities = lib.optional (withClient || withRelay) "The client and relay component of the dhcp package have reached their end of life"; </ins> }; }

Discussion:
Was announced multiple times, now it is EOL with release 4.2.3 We should remove it before branching 22.05.
Change:
}); xf86videoqxl = super.xf86videoqxl.overrideAttrs (attrs: { <ins> # https://gitlab.freedesktop.org/xorg/driver/xf86-video-qxl/-/issues/12 postPatch = '' patch -p1 <<EOF --- a/src/qxl_option_helpers.c +++ b/src/qxl_option_helpers.c @@ -37 +37 @@ -        return options[option_index].value.bool; +        return options[option_index].value.boolean; EOF ''; </ins> buildInputs =  attrs.buildInputs ++ [ spice-protocol ]; });

Discussion:
This breaks a NixOS test which is blocking 's advance. See also and . on .
we may have to update xorgserver OUR there's a abi difference between the version were using now and the newest version NEW xf86videovmware wants a newer abi than ours
The first failing nixpkgs:master commit is
We didn't update xorgserver or this driver. It's libdrm update which triggered this, PR .
I see what's happening. : and now in some libdrm headers was , defining the type.
Change:
strictDeps = true; postPatch = '' <del> substituteInPlace stack-lang.c --replace /usr/share /run/current-system/sw/share sed -i '/{ NULL, "/usr/share" },/i { NULL, "/run/current-system/sw/share" },' theme.c </del> <ins> substituteInPlace stack-lang.c --replace /usr/share/X11/xkb ${xkeyboard_config}/share/X11/xkb substituteInPlace theme.c --replace /usr/share /run/current-system/sw/share </ins> ''; <ins> passthru.updateScript = unstableGitUpdater { }; </ins> meta = { homepage = "https://github.com/labwc/labwc-tweaks"; description = "Configuration gui app for labwc"; mainProgram = "labwc-tweaks"; <del> license = lib.licenses.gpl2Plus; </del> <ins> license = lib.licenses.gpl2Only; </ins> platforms = lib.platforms.unix; <del> maintainers = with lib.maintainers; [ romildo ]; </del> <ins> maintainers = with lib.maintainers; [ AndersonTorres romildo ]; </ins> }; })

Discussion:
labwc-tweaks failes to start no matter what I do I get this error message if I try to open it in terminal: Error opening file: No such file or directory Run labwc-tweaks in the terminal labwc-tweaks starting Please run and paste the result. these 4 paths will be fetched (0.03 MiB download, 0.17 MiB unpacked): /nix/store/1alqjnr40dsk7cl15l5sn5y2zdxidc1v-binutils-wrapper-2.40 /nix/store/4dr83a4wn25zkb5pvsq2y3q3v586jzs9-expand-response-params /nix/store/90h6k8ylkgn81k10190v5c9ldyjpzgl9-gcc-wrapper-12.3.0 /nix/store/wr08yanv2bjrphhi5aai12hf2qz5kvic-stdenv-linux copying path '/nix/store/4dr83a4wn25zkb5pvsq2y3q3v586jzs9-expand-response-params' from ''... copying path '/nix/store/1alqjnr40dsk7cl15l5sn5y2zdxidc1v-binutils-wrapper-2.40' from ''... copying path '/nix/store/90h6k8ylkgn81k10190v5c9ldyjpzgl9-gcc-wrapper-12.3.0' from ''... copying path '/nix/store/wr08yanv2bjrphhi5aai12hf2qz5kvic-stdenv-linux' from ''... system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
The issue might be related to this hard coded path: it seems like that xkeyboard_config provides this file
Until recently the keyboard related files were available in . Fixed in
Change:
useMupdf = config.zathura.useMupdf or true; }; <del> zed = callPackage ../applications/editors/zed { node_webkit = nwjs_0_9; }; </del> zeroc_ice = callPackage ../development/libraries/zeroc-ice { inherit (darwin.apple_sdk.frameworks) Security; };

Discussion:
zed uses the binary release of (at this time still called ), while the newest version is . As this is basically a Chromium binary that can execute arbitrary Javascript and deliberately breaks all sandboxing features, we should at least keep it on a current version. cc I’m pushing an update of to 0.26 at the moment, but the package can’t handle it, so I’m pinning to for the time being.
Hi Thanks a lot for working on this. It's been a while ago since I worked on this part of , but I slightly remember that I had to deal with several outdated versions when dealing with . I'll definitely have a look into this in the next days, hopefully there's a patch by some contributors (or it's easy to file one to fix this). However the project isn't too active, so at least when we suffer from more further breaks or security issues because of severely outdated dependencies, we shouldn't hesitate to mark this package as broken or even drop it entirely (unless there are folks heavily relying on this).
I’d be in favor of a drop; people will complain if they still use it, if that happens we can restore & update, or the package is pulled outside of nixpkgs until someone can push and maintain a recent update.
In fact I agree with you, I've observed this "restore & update" pattern with some bigger applications (especially web-services) and I think that this is unneeded extra-work for the nixpkgs maintainers and release managers before each release. Before I file a patch to either {drop it,mark it as broken} or fix the dependency issue, I'd like to check two things before: is there any active fork? I'd like to ensure that the project is actually dead/unresponsive or does it have a working/maintained fork? check in the IRC if there are active users (I don't use it, I just fixed the derivation to help to get rid of ). If there are any, we should ask them to take over maintenance (or ask them to create their own overlay) I'll try to have a deeper look into it tonight, when I know more and have an actual opinion on how to proceed, I'll leave a comment here.

As far as I know, the author is no longer actively developing Zed anymore: I happen to know him personally, but as far as I know he has no interests in doing any major additional developments any time soon. Of course, I can always ask but I think I already know the answer. :) For me it's fine if it gets removed.
ok I suspected something like this as the last commit was from 2015. In this case I'm also :+1: for dropping it...
just submitted a PR for now, I asked in the IRC if there are any folks using , if I don't get a response, I'd just vote for merging it to master and do a backport to 18.03
Change:
The nixpkgs repository has several utility functions to manipulate Nix expressions. </para> <xi:include href="functions/library.xml" /> <del> <xi:include href="functions/generators.xml" /> </del> <ins> <xi:include href="functions/generators.section.xml" /> </ins> <xi:include href="functions/debug.section.xml" /> <xi:include href="functions/prefer-remote-fetch.section.xml" /> <xi:include href="functions/nix-gitignore.section.xml" />

Discussion:
This issue tracks the conversion of from Docbook to CommonMark per . If you intend to work on this conversion, please comment below! here that you intend to work on it. (Please also post if you stop working on it.) a new branch of nixpkgs master. : change to . to . the contents from Docbook to . Follow . Use existing sections for inspiration. from the folder to build the manual. the manual on your computer at after running from folder: it looks good, submit a PR and reference this issue.
I'll do this one.
Change:
fishnet = callPackage ../servers/fishnet { }; <ins> authy = callPackage ../applications/misc/authy { }; </ins> avro-tools = callPackage ../development/tools/avro-tools { }; bacnet-stack = callPackage ../tools/networking/bacnet-stack {};

Discussion:
Project description Authy is a very popular 2fa client known by its sync capabilities. Metadata homepage URL: source URL: license: proprietary platforms: linux
Change:
ldacbt = callPackage ../development/libraries/ldacbt { }; <del> ldb = callPackage ../development/libraries/ldb { python = python2; }; </del> <ins> ldb = callPackage ../development/libraries/ldb { }; </ins> lensfun = callPackage ../development/libraries/lensfun {};

Discussion:
Describe the bug build of failed. To Reproduce Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(gtgteq): nixpkgs: Maintainer information:
Looks like regression in . We need to build talloc with Python 3 too.
It might also need
Change:
<ins> { stdenv, lib, fetchFromGitHub, kernel, }: stdenv.mkDerivation rec { pname = "nullfs"; version = "0.17"; src = fetchFromGitHub { owner = "abbbi"; repo = "nullfsvfs"; rev = "v${version}"; sha256 = "sha256-Hkplhem4Gb1xsYQtRSWub0m15Fiil3qJAO183ygP+WI="; }; hardeningDisable = [ "pic" ]; enableParallelBuilding = true; nativeBuildInputs = kernel.moduleBuildDependencies; makeFlags = kernel.makeFlags ++ [ "KSRC=${kernel.dev}/lib/modules/${kernel.modDirVersion}/build" ]; prePatch = '' substituteInPlace "Makefile"  --replace-fail "/lib/modules/$(shell uname -r)/build" "$(KSRC)" ''; installPhase = '' runHook preInstall mkdir -p "$out/lib/modules/${kernel.modDirVersion}/kernel/fs/nullfs/" install -p -m 644 nullfs.ko $out/lib/modules/${kernel.modDirVersion}/kernel/fs/nullfs/ runHook postInstall ''; meta = with lib; { description = "A virtual black hole file system that behaves like /dev/null"; homepage = "https://github.com/abbbi/nullfsvfs"; license = licenses.gpl3; platforms = platforms.linux; maintainers = with maintainers; [ callumio ]; }; } </ins>

Discussion:
Project description A virtual file system that behaves like . I use it to discard unwanted files writing to my SSDs, that do not need to be read, such as caches and temp files. You can also set a mount option to prevent a file being discarded which is placed in RAM. Refer to . <!-- Describe the project a little: --It can handle regular file operations like mkdir/rmdir/ln but writing to files does NOT store any data. The file size is however saved, reading from the files behaves like reading from . Writing and reading is basically an NOOP, so it can be used for performance testing with applications that require directory structures. Implemented as kernel module, instead of using FUSE, there is absolutely no overhead for copying application data from user to kernel space while performing write or read operations. Metadata homepage URL: source URL: license: GPL-3.0 platforms: unix, linux, darwin (not sure) Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
Xsetup = pkgs.writeScript "Xsetup" '' #!/bin/sh <del> # Prior to Qt 5.9.2, there is a QML cache invalidation bug which sometimes # strikes new Plasma 5 releases. If the QML cache is not invalidated, SDDM # will segfault without explanation. We really tore our hair out for awhile # before finding the bug: # https://bugreports.qt.io/browse/QTBUG-62302 # We work around the problem by deleting the QML cache before startup. It # will be regenerated, causing a small but perceptible delay when SDDM # starts. rm -fr /var/lib/sddm/.cache/sddm-greeter/qmlcache </del> ${cfg.setupScript} '';

Discussion:
After got merged, and is in the nixos-unstable channel, I noticed after I rebuilt my system that when sddm starts and I type in my password it just goes black and restarts sddm. Meaning that I can never reach the desktop :( I could also not find anything useful in the journal. cc
In a VT, try this as root:
Ahh that makes perfect sense and worked :hand: Is there any real way to make sure this doesn't happen for someone else?
There was a PR some time ago that was supposed to address this (it was merged) that would simply clear out the directory on start but it looks like that didn't do the trick. I don't remember which. IMHO, the proper way to handle this is something like this:
I also often have this problem.. could you open a pull request that removes the old solution and that adds your solution?
The commit was - I'll PR this.
Change:
nativeBuildInputs = [ cmake ninja python3 ]; buildInputs = [ llvm clang-unwrapped ]; strictDeps = true; <ins> cmakeFlags = [ "-DCMAKE_INSTALL_INCLUDEDIR=include" ]; </ins> meta = with lib; { homepage = "http://libclc.llvm.org/";

Discussion:
I got this error message when running , as well as OpenCL hello-world programs with mesa (restored in ), and it fails to compile OpenCL kernels. Steps to reproduce the behavior: OpenCL by setting . . The error message shows up. The error shoudn't be shown, and compiling OpenCL kernels should work. It seems that it tried to find that file, but the path is ill-formatted. See the repeated path in the strace below. <details<summarystrace output</summary</detailsThe path is hardcoded in . <details<summaryxxd output</summary</detailsThe wrong include directory is the , which is generated by . I'm not knowledgeable enough to fix it, but I think this is close to the root of the problem. I'm using flakes on nixos-21.11. The command fails so it's not included.