jiebi/CodeConvo huggingface dataset:
Change:
meta = with lib; { homepage = "https://github.com/ncbi/sra-tools"; description = "The SRA Toolkit and SDK from NCBI is a collection of tools and libraries for using data in the INSDC Sequence Read Archives."; <del> license = licenses.publicDomain; </del> <ins> license = licenses.ncbiPd; </ins> maintainers = with maintainers; [ thyol ]; platforms = [ "x86_64-linux" ]; };

Discussion:
See
Same question a in . We could add the license if there is a need for it.
That would be for , which is not public domain worldwide.
Please open a PR that adds the license to and adjust the license of .
I'd do that, except I can't find any documentation as to what format the commit message should be.
Change:
ntopng = callPackage ../tools/networking/ntopng { }; <del> ntp = callPackage ../tools/networking/ntp { libcap = if stdenv.isLinux then libcap else null; }; </del> <ins> ntp = callPackage ../tools/networking/ntp { }; </ins> numdiff = callPackage ../tools/text/numdiff { };

Discussion:
ntpd is killed shortly after start. strace ends with: 950 select(23, [16 17 18 19 20 21 22], NULL, NULL, NULL) = 1 (in [19]) 950 recvmsg(19, {msgname={safamily=AFINET, sinport=htons(123), sinaddr=inetaddr("x.x.x.x")}, msgnamelen=28 =16, msgiov=[{iovbase="..."..., iovlen=2120}], msgiovlen=1, msgcontrol=[{cmsglen=32, cmsglevel=SOLSOCKET, cmsgtype=SOTIMESTAMPNSOLD, cmsgdata={tvsec=, tvnsec=}}], msgcontrollen=32, msgflags=0}, 0) = 48 950 recvmsg(19, {msgnamelen=28}, 0) = -1 EAGAIN (Resource temporarily unavailable) 950 clockadjtime(CLOCKREALTIME, <unfinished ...) = ? 950 +++ killed by SIGSYS (core dumped) +++ After adding clockadjtime to , ntpd proceeds after the call to clockadjtime(). Updated is attached. Use this config: = { enable = true; servers = [ "x.x.x.x" ]; extraFlags = [ "-g" ]; }; Do not crash. glibc changed the implementation of adjtimex to use clock_adjtime: ;a=commit;h=
There have been multiple reported regressions introduced by NTP's seccomp "support" over the years, e.g. and , now this, and several others I'm sure we're missing. While it's hilarious for me (a lazy maintainer) to say so, I'm getting a bit tired of it. Out of curiosity since this seems like a trend, I note that the patch for this original change in glibc was from 2019. Why did it take this long for this to percolate downstream, and why is there not an ntp patch for it already upstream? I did not find a historical answer to this, but I suspect no concrete one exists; it's probably a number of things leading to this. Either way, it isn't ideal for an almost 2-year old patch to suddenly be busting an extremely common daemon.

Let's also look at the seccomp filter itself: it basically enables , including some that seemingly have no reason at all for being here. You can do everything with this syscall list from write reverse-proxies to normal open/read/write/close on files. On top of that, from glancing at the , I cannot see a single security flaw that would have been mitigated by this filter in any way. But I might have missed something. Finally, didn't have much to say in support of NTPd, either. The actual award would go to chrony, which on top of that, also supports NTS (like ntpsec) and even supports features like PTP for highly accurate virtualized clocks, in addition to its normal time keeping duties being more accurate, too. My actual inclination, in light of all this, is not to add another patch to , it's to turn off seccomp support for ntpd entirely, and in the long run, deprecate and remove all alternatives in favor of chrony. Users who want to sport their own favorite-flavour NTP daemon can handle these issues on their own.
Maybe --enable-libseccomp isn't used by many. At least, CentOS, Slackware, Arch and Debian don't seem to use it. See Fine for me.
Fedora didn't have it enabled either back when they used ntp (they've switched to ntpsec)
Change:
sed -i 's/os_trace((.*)");$/printf(1n");/g' ./projects/compiler-rt/lib/sanitizer_common/sanitizer_mac.cc substituteInPlace CMakeLists.txt  <del> --replace 'set(CMAKE_INSTALL_NAME_DIR "@rpath")' "set(CMAKE_INSTALL_NAME_DIR "$out/lib")"  </del> <ins> --replace 'set(_install_name_dir INSTALL_NAME_DIR "@rpath")' "set(_install_name_dir)"  </ins> --replace 'set(CMAKE_INSTALL_RPATH "@executable_path/../lib")' "" '' + ''

Discussion:
Run , observe: Please run and paste the results.
Very weird... It must have come in from a recent update. You can find libLLDB in the lldb derivation:
/cc
Change:
, extra-cmake-modules , wayland , wayland-protocols <ins> , wayland-scanner </ins> , enableX11 ? stdenv.isLinux , xorg }:

Discussion:
Steps to reproduce the behavior: full: Occurred on last system update. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
should be fixed by
Change:
rpy2 sphinx pillow <del> ]; </del> <ins> ] ++ extraPythonPackages python3.pkgs; </ins> pythonEnv = python3.buildEnv.override { extraLibs = pythonRuntimeDeps;

Discussion:
Is it possible to load additional python libraries when using sage. For example, if I want to load , how do I do so? <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
Possible solution
Change:
"gitlab-db-config.service" ]; bindsTo = [ <del> "redis-gitlab.service" </del> "gitlab-config.service" "gitlab-db-config.service" <del> ] ++ optional (cfg.databaseHost == "") "postgresql.service"; </del> <ins> ]; wants = [ "redis-gitlab.service" ] ++ optional (cfg.databaseHost == "") "postgresql.service"; </ins> requiredBy = [ "gitlab.target" ]; partOf = [ "gitlab.target" ]; environment = gitlabEnv;

Discussion:
In the NixOS gitlab module, the fleet of Gitlab component services is strongly coupled to the (local) postgresql and – via sidekiq – to Redis. On a systemd unit dependency level, this happens via a relationship and causes the other services to be stopped and (re)started when just one of them is instructed to do so. Unfortunately, there can be several edge cases where the system ends up with not all of the components being in the desired state (mostly up). Steps to reproduce the behavior: This issue is a subtle race condition, so I choose to describe the general problematic setup instead of trying to engineer a reproducer: I've encountered a situation where both and where restarted (stop and start) at system switch time due to changed configuration. This triggered Gitlab to be stopped as well. Unfortunately the service(s) was in its startup (Activating) phase and stayed inactive. The expectation is that Gitlab comes back after the dependency restart. Instead of continuing to tune the strongly-tied, evermore complex inter-service dependencies I propose to decouple postgresql and redis from the rest of the gitlab services. I'll open a WIP pr on this. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Here's my proposal on reducing the coupling between DBs and the rest of gitlab, currently with failing tests unfortunately:
Change:
}: python3Packages.buildPythonApplication rec { pname = "bottles-unwrapped"; <del> version = "2022.11.14"; </del> <ins> version = "2022.12.14"; </ins> src = fetchFromGitHub { owner = "bottlesdevs"; repo = "bottles"; rev = version; <del> sha256 = "sha256-bigrJtqx9iZURYojwxlGe7xSGWS13wSaGcrTTROP9J8="; </del> <ins> sha256 = "sha256-G2FQy+mea/+2RjK/WjLeX+7TP+HU6fCUFYuprFGKEyw="; </ins> }; patches = [ ./vulkan_icd.patch ]; <ins> # https://github.com/bottlesdevs/Bottles/wiki/Packaging </ins> nativeBuildInputs = [ blueprint-compiler meson

Discussion:
When using at first startup it tries to download some runtime, but seems to fail. Steps to reproduce the behavior: it next, next, install 's stuck at "Downloading" forever It actually downloads the required runtime. ! When running through the console I can see some additional info, and it shows: This repeats forever. Nothing, I think? <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
can you write what version of package you are using? It seems this problem from old version that still in stable and resolved in one that in unstable channel it seems you're maintaining bottles better than me now, can you add yourself into maintainers with new PR and backport it?
It's not solved by updating to 2022.11.14. Seems to be an upstream issue:
I'm indeed using the current version of the stable channel: I also tried the version from the unstable branch, but indeed that does not fix it as SuperSamus said. I'll keep an eye on the upstream issue.
I was able to fix this by and extracting it into To be clear, inside the folder there should be a folder, inside which are , , , etc.
Change:
<listitem><para>Mount the boot file system on <filename>/mnt/boot</filename>, e.g. <screen> <ins> # mkdir -p /mnt/boot </ins> # mount /dev/disk/by-label/boot /mnt/boot </screen>

Discussion:
1/ The manual contains this command but it should be as doesn't accept the -L flag and it will warn when using lowercase 2/ the manual recommands but this gives "unknown filesystem type LVM2_member` for lvm 3/ it says to mount a drive in /mnt/boot but the folder doesn't exist 4/ apparently nixos-generate-config doesn't setup the root filesystem with LLVM: "the fileSystems option does not specify your root file system" Other propositions: Add useOSProber in the nixos-generate-config I know nixos targets more advanced users but I guess this can still be improved
The LVM example is meant as an additional way to explore. Simply following the command in the order presented is not promising. I'd suggest to leave out the logical volume setup code. Users with LVM knowledge probably know how to operate and friends. For users without LVM knowledge this is probably misleading.
thanks for the fixes !
Change:
<ins> diff --git a/cmd/main.go b/cmd/main.go index ede7cd8..c553140 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -401,8 +401,11 @@ func splitWith(arg string) (module, version, replace string, err error) { return } +var customVersion string + // xcaddyVersion returns a detailed version string, if available. func xcaddyVersion() string { +	return customVersion mod := goModule() ver := mod.Version if mod.Sum != "" { </ins>

Discussion:
Caddy fails to build for riscv64 Steps to reproduce the behavior: ... ... ... A clear and concise description of what you expected to happen. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
(please fill out more parts of the bug report template next time) Assuming this is , likely an instance of . Pinging maintainers:
Hi, thanks for the ping :) The fix for this is fairly trivial. Either skip the shell completions/man pages[^1], or use something like But I am upset that you ( didn't even care enough to do the bare minimum and fill out the issue template. [^1]: Technically only the kills the build, not the , because bash pipefail defaults.
i'm sorry for the issue template, it was more of a quick note to myself. i'll do it right next time
Change:
, freetype , libass , libpthreadstubs <del> , nv-codec-headers </del> <ins> , nv-codec-headers-11 </ins> , lua , libuchardet , libiconv

Discussion:
After update from 23.05 to 23.11, mpv started throwing following error and using nvdec-copy instead of normal nvdec.(Not sure if these two are related. Please ignore libva error if it's not related to usage of and , as it's not the point of the issue) Use of nvdec-copy is not desirable as it routes the decoded image data through system memory. In other words, it round-trips the frame through the cpu and back to the gpu, so it's fairly wasteful, especially on older hardware. Steps to reproduce the behavior: any video with codec supported by the gpu in mpv(tested on h.264 file and VP9 youtube video) mpv throw a libva error and using nvdec-copy. No libva error is thrown and mpv using nvdec like it did on 23.05 After some digging I found a potential cause that I have no knowledge of how to check/confirm/deny. Issues describing it: described in second issue does not help. All packages are installed and configured via CPU Q9650 GPU: GT1030 Nvidia driver version 545.29.02 Please ask for any additional required system information/logs. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Well, it's not literally the same issue as you linked, we do have the relevant headers:
I have linked these two issues because they are the only things I was able to find that I believed to be relevant to my issue with my limited understanding of how these things work, which is why I called it a potential cause that I have no knowledge on how to check/confirm/deny.
mpv is being built with ffmpeg 6, which is , while mpv is built with . Thanks for drawing my attention to that line in the ffmpeg derivation over on discord, So I tested if that was the source of the issue, and indeed, this used as desired:
Change:
, zlib }: <del> stdenv.mkDerivation rec { version = "2.8.3091"; </del> <ins> stdenv.mkDerivation (finalAttrs: { </ins> pname = "grafx2"; <ins> version = "2.8.3091"; outputs = [ "out" "man" ]; </ins> src = fetchurl { <ins> name = "grafx2-${finalAttrs.version}.tar.gz"; </ins> url = "https://pulkomandy.tk/projects/GrafX2/downloads/65"; <del> name = "${pname}-${version}.tar.gz"; </del> hash = "sha256-KdY7GUhQp/Q7t/ktLPGxI66ZHy2gDAffn2yB5pmcJCM="; }; <del> nativeBuildInputs = [ pkg-config ]; </del> <ins> postPatch = '' substituteInPlace misc/unix/grafx2.desktop  --replace "Exec=grafx2" "Exec=grafx2-sdl" ''; nativeBuildInputs = [ installShellFiles pkg-config ]; </ins> buildInputs = [ SDL SDL_image

Discussion:
The GrafX2 desktop entry points to an incorrect executable, causing it to not work. Steps to reproduce the behavior: GrafX2 to use the installed desktop entry to execute child process "grafx2" (No such file or directory) GrafX2 actually starting up ! The actual executable name is "grafx2-sdl" Add a new file in "" called , with the following contents: You might have to run afterwards to clear caches? i'm not sure. Importantly, this changes to Maintainer list is empty! people who edited the file recently. (this is what happens when you don't leave a specified successor) <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I will adopt this, then.
Change:
# nix build .#mesa .#pkgsi686Linux.mesa .#pkgsCross.aarch64-multiplatform.mesa .#pkgsMusl.mesa let <del> version = "24.0.3"; hash = "sha256-d67JoqN7fTWW6hZAs8xT0LXZs7Uqvtid4H43F+kb/b4="; </del> <ins> version = "24.0.4"; hash = "sha256-kP69MKCYy82X/2Lsw9z1yT129/oxTelEz86BlRunRfA="; </ins> # Release calendar: https://www.mesa3d.org/release-calendar.html # Release frequency: https://www.mesa3d.org/releasing.html#schedule

Discussion:
Package name: mesa Latest released version: <!-- Search your package here: --- Current version on the unstable channel: 24.0.3 Current version on the stable/release channel: 23.1.9 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
{ mkDerivation, lib, fetchurl, autoPatchelfHook, makeWrapper, xdg-utils, dbus <del> , qtbase, qtwebkit, qtx11extras, qtquickcontrols, glibc , libXrandr, libX11, libXext, libXdamage, libXtst, libSM, libXfixes </del> <ins> , qtbase, qtwebkit, qtwebengine, qtx11extras, qtquickcontrols, getconf, glibc , libXrandr, libX11, libXext, libXdamage, libXtst, libSM, libXfixes, coreutils </ins> , wrapQtAppsHook }: mkDerivation rec { pname = "teamviewer"; <del> version = "15.15.5"; </del> <ins> version = "15.22.3"; </ins> src = fetchurl { url = "https://dl.tvcdn.de/download/linux/version_15x/teamviewer_${version}_amd64.deb"; <del> sha256 = "sha256-H/CSc2RcjI+Fm8awYcXm3ioAJpbSNEMwGVrTozMux3A="; </del> <ins> sha256 = "15fvzhdq7mnx2l2w4byvij8ww16qwdlkbadal60rm66yzv79mv9w"; </ins> }; unpackPhase = ''

Discussion:
Describe the bug When busybox is installed - teamviewer cannot starts correctly To Reproduce Steps to reproduce the behavior: " = true;" to busybox to "environment.systemPackages = with pkgs;" to launch the teamviewer Expected behavior Teamviewer gui starts Screenshots If applicable, add screenshots to help explain your problem. ! Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked): /nix/store/d43v6bx7r6fcaq3fbbfd5mwh1f5s7rmg-bash-interactive-4.4-p23-dev copying path '/nix/store/d43v6bx7r6fcaq3fbbfd5mwh1f5s7rmg-bash-interactive-4.4-p23-dev' from ''... system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
I marked this as stale due to inactivity. &rarr;
This should be fixed by . Please confirm by closing if it indeed does.
Change:
let inherit (lib) lists strings trivial; <del> inherit (cudaPackages) cudaAtLeast cudaFlags cudaOlder; </del> inherit (magmaRelease) version hash supportedGpuTargets; <ins> # Per https://icl.utk.edu/magma/downloads, support for CUDA 12 wasn't added until 2.7.1. # If we're building a version prior to that, use the latest release of the 11.x series. effectiveCudaPackages = if strings.versionOlder version "2.7.1" then cudaPackages_11 else cudaPackages; inherit (effectiveCudaPackages) cudaAtLeast cudaFlags cudaOlder; inherit (cudaFlags) cudaCapabilities; </ins> # NOTE: The lists.subtractLists function is perhaps a bit unintuitive. It subtracts the elements #   of the first list *from* the second list. That means: #   lists.subtractLists a b = b - a

Discussion:
Build of failed on x86_64-linux as of . This is currently breaking . python3Packages.torchvision maintainers cc: magma maintainers cc: Other cc: n/a nixpkgs at commit Contents of : This issue was automatically generated by . that created this issue. Internal tags: - -
Will be closed by
Change:
github = "numkem"; githubId = 332423; }; <ins> nu-nu-ko = { email = "host@nuko.city"; github = "nu-nu-ko"; githubId = 153512689; name = "nuko"; }; </ins> nviets = { email = "nathan.g.viets@gmail.com"; github = "nviets";

Discussion:
I currently run Jellyfin in a Docker container but want to deploy it using an ephemeral NixOS container. However, does not expose a option and runs Jellyfin with where . I understand that this directory will be cleared when the container restarts. I'm not familiar with 's nor the aggressive sandboxing. Need I consider something else when adding the option other than user permissions?
I am experimenting with this, I just some options for defining a and a . It seems to "just work tm", but is there anything I should be aware of? I'll run my own nixpkgs branch on my own machine for a little bit before creating a PR, but so far it seems fine.
I looked a bit into this, and I think bind mounts is what works best with systemd. But I didn't really find a lot of info...
Relevant:
I'm interested in this as well. Currently the Sonarr, Radarr, Jackett, and Ombi services provide . Is the approach they use also usable here?
Change:
let bnumber = with stdenv.lib; build: last (splitString "-" build); <del> mkIdeaProduct' = callPackage ./common.nix { }; mkIdeaProduct = attrs: mkIdeaProduct' ({ # After IDEA 15 we can no longer use OpenJDK. # https://youtrack.jetbrains.com/issue/IDEA-147272 jdk = if (bnumber attrs.build) < "143" then jdk else oraclejdk8; } // attrs); </del> <ins> mkIdeaProduct = callPackage ./common.nix { }; </ins> buildAndroidStudio = { name, version, build, src, license, description }: let drv = (mkIdeaProduct rec {

Discussion:
Right now the IntelliJ derivation hardcodes oraclejdk8, and AFAICT the only way to override this choice is by overriding oraclejdk8 itself: (I have tried and with no effect.) Can we make this overridable somehow? (FWIW, I've had no problems with 15 and 15 EAP under openjdk8, although I'm getting redraw artifacts with 16 EAP.) cc
It was just recently changed away from that due to Idea having some bug with and not seeming very open to dealing with it. I can't find the ticket right now...
Oh
Okay, found the root cause of this bug. The crucial line is the following in (in openjdk): This checks that is indeed in , and guess what this returns with our symlink maze... As a temporary workaround you can set as an extra environment variable. This manages to hit the only special case in which doesn't have this check, and then intellij works fine with openjdk. Maybe I can draft a PR to fix this tomorrow.
Since the PR is merged, I assume this issue was just forgotten.
Change:
githubId = 6652840; name = "Jade"; }; <ins> lgcl = { email = "dev@lgcl.de"; name = "Leon Vack"; github = "LogicalOverflow"; githubId = 5919957; }; </ins> lheckemann = { email = "git@sphalerite.org"; github = "lheckemann";

Discussion:
Project description Add Youtube Music Desktop player Metadata homepage URL: source URL: license: Creative Commons Zero v1.0 Universal platforms: linux, MacOS Similar application to Google Play Music Desktop:
Change:
"app-builder-lib": "^22.14.10", "asar": "^2.0.1", "chokidar": "^3.5.2", <del> "electron": "^15.3.5", </del> <ins> "electron": "^17", </ins> "electron-builder": "22.11.4", "electron-builder-squirrel-windows": "22.11.4", "electron-devtools-installer": "^3.1.1",

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: element-web <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.10.4 desired version: 1.10.6 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Myself i am waiting for an , ... please keep an eye on the release.