jiebi/CodeConvo huggingface dataset:
Change:
, testers , mold , nix-update-script <ins> , runCommandCC , mold-wrapped , hello , buildPackages , useMoldLinker </ins> }: stdenv.mkDerivation rec {

Discussion:
is a fast and multi threaded modern linker. We already have it in Nixpkgs, however, unlike , it has not been wrapped in a package so that it can find the libraries to dynamically link against. Hence, dynamic linking in in NixOS fails. This issue is created so that we can wrap mold inside a shell script, like what happens to when it is installed through or even normal . I would be open to helping port such a script for .
I have tried simply replacing the executable with in the wrapper script, but it didn't seem to work. I am not very familiar with how this script works or what I am missing For more information, see
After some discussion on Matrix (thanks !), I was able to get mold working in a dev shell by using the following snippet: Is there any way we can just expose this as a wrapped mold in Nixpkgs so we don't have to add this to every shell we need mold in?
Is this relevant anymore? In addition to , we also have now. Here's a test we have for it in :
Further work is to rename to so users have to choose explicitly
Change:
# USB drivers "xhci-pci-renesas" <ins> # Reset controllers "reset-raspberrypi" # Triggers USB chip firmware load. </ins> # Misc "weak" dependencies "analogix-dp" "analogix-anx6345" # For DP or eDP (e.g. integrated display)

Discussion:
The "nixos.sdimagenewkernel.aarch64-linux" image from unstable channel fails to boot when flashed to a USB drive. The boot process hangs early in the boot process. Steps to reproduce the behavior: to a USB drive. The tested build is . using UART, update and change to . this drive to a RPi 4 with updated EEPROM. Power it on. The image boots to the shell. The boot process hangs with the following boot message, logged from UART: The boot proceeds from U-Boot to the kernel, but then hangs there. According to [1], it seems like in 5.14 the option is demoted from to . The same email seems to suggest that the module () is needed for USB to work. I checked the initrd of the image; the module isn't there. So, I guess if this module is included in the initrd, it could fix the problem. I'll try to create a PR to do that. [1] <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Assumes that is how kernel modules is included in the SD card image: Also tag SD card installer file for good measure: Please run and paste the result. -- Not applicable, image does not boot. Maintainer information:
I marked this as stale due to inactivity. &rarr;
Ping Anything else for that PR?
Change:
- The top-level `termonad-with-packages` alias for `termonad` has been removed. <ins> - Linux 4.9 has been removed because it will reach its end of life within the lifespan of 22.11. </ins> - (Neo)Vim can not be configured with `configure.pathogen` anymore to reduce maintainance burden. Use `configure.packages` instead. - Neovim can not be configured with plug anymore (still works for vim).

Discussion:
The Linux 4.9 LTS release will be EOL after 2023/01 and I hope we can remove it before the 22.11 release, so we don't carry it around until then. via cc kernel maintainer team
Thanks for the heads-up. I'd be fine with doing the removal right now (considering that it's LTS and having that one removed on stable may be an unpleasant surprise), but FWIW: we usually drop kernel releases when they get EOLed (also from stable branches), otherwise we wouldn't be able to provide non-LTS kernels on any stable branch anyways.
Change:
ant-bloody-theme = callPackage ../data/themes/ant-theme/ant-bloody.nix { }; <del> ant-dracula-theme = callPackage ../data/themes/ant-theme/ant-dracula.nix { }; </del> <ins> dracula-theme = callPackage ../data/themes/dracula-theme { }; </ins> ant-nebula-theme = callPackage ../data/themes/ant-theme/ant-nebula.nix { };

Discussion:
[Ant-Dracula] has moved to [Dracula]. [Dracula]: [Ant-Dracula]: Homepage: Repository:
Change:
buildInputs = [ gmp ] ++ optional aclSupport acl <ins> ++ optional attrSupport attr </ins> ++ optionals stdenv.isCygwin [ autoconf automake114x texinfo ]   # due to patch ++ optionals selinuxSupport [ libselinux libsepol ]; crossAttrs = { buildInputs = [ gmp.crossDrv ] ++ optional aclSupport acl.crossDrv <ins> ++ optional attrSupport attr.crossDrv </ins> ++ optionals selinuxSupport [ libselinux.crossDrv libsepol.crossDrv ] ++ optional (stdenv.ccCross.libc ? libiconv) stdenv.ccCross.libc.libiconv.crossDrv;

Discussion:
When trying to copy a file with extended attributes, the attributes don't get copied. When forcing to copy the attributes, it reports: The issue was probably introduced with multiple outputs support. Previously, would find libs&headers while building, propagated through . But now, only the libs propagate and not , so can't find the header and disables support. Not sure if coreutils should just list as a (when is) or if should somehow signal that its output should propagate too. System: Nix version: Nixpkgs version:
By default, the output should be propagated and it should propagate libs and some others in turn. I'll re-check all this later (if noone else is faster).
Hmm, as far as I can tell from the git logs, at least explicitly didn't propagate .
When I tested 16.03 it doesn't have xattr support there either. But anyway, enables it.
I'm pretty sure it used to work at some point, but it might have been a few years ago :) Thanks!
Change:
url = "https://github.com/elm/compiler"; sha256 = "13jks6c6i80z71mjjfg46ri570g5ini0k3xw3857v6z66zcl56x4"; rev = "d5cbc41aac23da463236bbc250933d037da4055a"; <ins> fetchSubmodules = true; </ins> }; isLibrary = false; isExecutable = true;

Discussion:
Not sure whether this is darwin-specific. I cannot install next to , because both want link . It seems wrong for either of the packages to link shared libraries. I suspect this is because e.g. sets . I'd be happy to submit a patch to change this, but there seems to be a stack of scripts that's meant to generate this that's too deep for me. nix-env -iA nix-env -iA system: host os: multi-user?: sandbox: version: channels(rob): nixpkgs:
Usually we need a for these to work currently. Not sure if that is currently possible? You can also set meta.priority to a different number for each (default is 5). /cc
I think this must be darwin-specific; I have these packages happily coexisting alongside each other in on NixOS:
Yes, looks darwin-specific, via
Fixed in
Change:
propagatedBuildInputs = [ ExtUtilsDepends ExtUtilsPkgConfig ]; }; <ins> GlibObjectIntrospection = buildPerlPackage rec { name = "Glib-Object-Introspection-0.046"; src = fetchurl { url = "mirror://cpan/authors/id/X/XA/XAOC/${name}.tar.gz"; sha256 = "1d3gl943p27gd42kxc1i9sp5z55gpgcslz1jvx7cxd6mflhdlck6"; }; buildInputs = [ Glib ExtUtilsDepends ExtUtilsPkgConfig ]; propagatedBuildInputs = [ pkgs.gobject-introspection ]; meta = { description = "Dynamically create Perl language bindings"; license = stdenv.lib.licenses.lgpl2Plus; }; }; </ins> Gnome2 = buildPerlPackage rec { name = "Gnome2-1.047"; src = fetchurl {

Discussion:
I'm going to be putting this aside for a bit but it still needs some work, so I'm posting this here till I have a PR ready. At the moment this appears to generate a functional gscan2pdf derivation, however I would like to find a way to allow at least part, if not all of the (graphical) tests to be run. I also intend to merge the perl packages into perl packages properly instead of leaving them like this, and I need to look into whether they have any extra things I should configure, currently this is somewhat modified output of nix-generate-from-cpan. Also I don't know if this should go into tools/graphics, or into perlPackages, or what. Though I'm leaning towards the former. Also please send suggestions on how to improve the script in general. If anyone wants to pick this up, please do.
Any progress on this?
Change:
<ins> import ../make-test-python.nix ({ pkgs, ...}: let adminpass = "hunter2"; adminuser = "custom-admin-username"; in { name = "nextcloud-with-declarative-redis"; meta = with pkgs.lib.maintainers; { maintainers = [ eqyiel ]; }; nodes = { # The only thing the client needs to do is download a file. client = { ... }: {}; nextcloud = { config, pkgs, ... }: { networking.firewall.allowedTCPPorts = [ 80 ]; services.nextcloud = { enable = true; hostName = "nextcloud"; caching = { apcu = false; redis = true; memcached = false; }; config = { dbtype = "pgsql"; dbname = "nextcloud"; dbuser = "nextcloud"; dbhost = "/run/postgresql"; inherit adminuser; adminpassFile = toString (pkgs.writeText "admin-pass-file" '' ${adminpass} ''); }; extraOptions.redis = { host = "/run/redis/redis.sock"; port = 0; dbindex = 0; password = "secret"; timeout = 1.5; }; extraOptions.memcache = { local = "OCMemcacheRedis"; locking = "OCMemcacheRedis"; }; }; services.redis = { enable = true; }; systemd.services.nextcloud-setup= { requires = ["postgresql.service"]; after = [ "postgresql.service" ]; }; services.postgresql = { enable = true; ensureDatabases = [ "nextcloud" ]; ensureUsers = [ { name = "nextcloud"; ensurePermissions."DATABASE nextcloud" = "ALL PRIVILEGES"; } ]; }; }; }; testScript = let withRcloneEnv = pkgs.writeScript "with-rclone-env" '' #!${pkgs.runtimeShell} export RCLONE_CONFIG_NEXTCLOUD_TYPE=webdav export RCLONE_CONFIG_NEXTCLOUD_URL="http://nextcloud/remote.php/webdav/" export RCLONE_CONFIG_NEXTCLOUD_VENDOR="nextcloud" export RCLONE_CONFIG_NEXTCLOUD_USER="${adminuser}" export RCLONE_CONFIG_NEXTCLOUD_PASS="$(${pkgs.rclone}/bin/rclone obscure ${adminpass})" "''${@}" ''; copySharedFile = pkgs.writeScript "copy-shared-file" '' #!${pkgs.runtimeShell} echo 'hi' | ${pkgs.rclone}/bin/rclone rcat nextcloud:test-shared-file ''; diffSharedFile = pkgs.writeScript "diff-shared-file" '' #!${pkgs.runtimeShell} diff <(echo 'hi') <(${pkgs.rclone}/bin/rclone cat nextcloud:test-shared-file) ''; in '' start_all() nextcloud.wait_for_unit("multi-user.target") nextcloud.succeed("curl -sSf http://nextcloud/login") nextcloud.succeed( "${withRcloneEnv} ${copySharedFile}" ) client.wait_for_unit("multi-user.target") client.succeed( "${withRcloneEnv} ${diffSharedFile}" ) # redis cache should not be empty nextcloud.fail("redis-cli KEYS * | grep -q 'empty array'") ''; }) </ins>

Discussion:
Currently, the nextcloud modules has a set list of config options (in ), and no -style hook for freeform text which should be appended to nextcloud's configuration file. In particular, I am unable to figure out how to set up redis caching with the nextcloud module — the description for states that "you still need to enable Redis in your ", but there is no description of how to do that, and no corresponding option in the module. I think the module should offer something like , particular since this is probably also an issue for other possible configurations of nextcloud (given that its is prohibitively long) — or am I just missing something obvious?
I started a pull request with this here:
I marked this as stale due to inactivity. &rarr;
Same problem ;(
Change:
action="$i" ;; --install-grub) <del> export NIXOS_INSTALL_GRUB=1 </del> <ins> echo "$0: --install-grub deprecated, use --install-bootloader instead" >&2 export NIXOS_INSTALL_BOOTLOADER=1 ;; --install-bootloader) export NIXOS_INSTALL_BOOTLOADER=1 </ins> ;; --no-build-nix) buildNix=

Discussion:
I was using gummiboot and struggling to figure out how to reinstall it. This option should be aliased and deprecated in favor of "--install-bootloader" or the like, and the manpage updated to be agnostic of the bootloader selected in , since the correct behavior is already in place (--install-grub reinstalls gummiboot properly).
Change:
{ stdenv, fetchFromGitHub , makeWrapper, makeDesktopItem, mkYarnPackage <del> , electron_7, riot-web, gtk3 , wrapGAppsHook, glib </del> <ins> , electron_7, riot-web </ins> }: # Notes for maintainers: # * versions of `riot-web` and `riot-desktop` should be kept in sync.

Discussion:
Describe the bug The electron package tries to wrap in . Because of this the wrapper is completely void of any entries in . It needs to be rewritten in whatever fashion that the call happens in . This is why has needed to be wrapped recently , it's because isn't wrapped correctly itself. A change should be made to stable to revert this to riot-desktop, and to backport this fix instead. Expression: buildInputs should also have for it's setup-hook
I created a PR here:
Change:
, pkg-config , gtk3 , libxml2 <ins> , xkeyboard_config </ins> , wrapGAppsHook <ins> , unstableGitUpdater </ins> }: stdenv.mkDerivation (finalAttrs: { pname = "labwc-tweaks"; <del> version = "unstable-2023-12-08"; </del> <ins> version = "unstable-2024-01-04"; </ins> src = fetchFromGitHub { owner = "labwc"; <del> repo = finalAttrs.pname; rev = "1c79d6a5ee3ac3d1a6140a1a98ae89674ef36635"; hash = "sha256-RD1VCKVoHsoY7SezY7tjZzomikMgA7N6B5vaYkIo9Es="; </del> <ins> repo = "labwc-tweaks"; rev = "1604f64cc62e4800ee04a6e1c323a48ee8140d83"; hash = "sha256-xFvc+Y03HjSvj846o84Wpk5tEXI49z8xkILSX2oas8A="; </ins> }; nativeBuildInputs = [

Discussion:
labwc-tweaks failes to start no matter what I do I get this error message if I try to open it in terminal: Error opening file: No such file or directory Run labwc-tweaks in the terminal labwc-tweaks starting Please run and paste the result. these 4 paths will be fetched (0.03 MiB download, 0.17 MiB unpacked): /nix/store/1alqjnr40dsk7cl15l5sn5y2zdxidc1v-binutils-wrapper-2.40 /nix/store/4dr83a4wn25zkb5pvsq2y3q3v586jzs9-expand-response-params /nix/store/90h6k8ylkgn81k10190v5c9ldyjpzgl9-gcc-wrapper-12.3.0 /nix/store/wr08yanv2bjrphhi5aai12hf2qz5kvic-stdenv-linux copying path '/nix/store/4dr83a4wn25zkb5pvsq2y3q3v586jzs9-expand-response-params' from ''... copying path '/nix/store/1alqjnr40dsk7cl15l5sn5y2zdxidc1v-binutils-wrapper-2.40' from ''... copying path '/nix/store/90h6k8ylkgn81k10190v5c9ldyjpzgl9-gcc-wrapper-12.3.0' from ''... copying path '/nix/store/wr08yanv2bjrphhi5aai12hf2qz5kvic-stdenv-linux' from ''... system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
The issue might be related to this hard coded path: it seems like that xkeyboard_config provides this file
Until recently the keyboard related files were available in . Fixed in
Change:
<del> { lib, stdenv, callPackage }: </del> <ins> { lib, callPackage, ... }@args: </ins> let k3s_builder = import ./builder.nix lib; common = opts: callPackage (k3s_builder opts); <ins> # extraArgs is the extra arguments passed in by the caller to propogate downward. # This is to allow all-packages.nix to do: # #     let k3s_1_23 = (callPackage ./path/to/k3s { #       commonK3sArg = .... #     }).k3s_1_23; extraArgs = builtins.removeAttrs args [ "callPackage" ]; </ins> in { k3s_1_26 = common ((import ./1_26/versions.nix) // { updateScript = [ ./update-script.sh "26" ]; <del> }) { }; </del> <ins> }) extraArgs; </ins> # 1_27 can be built with the same builder as 1_26 k3s_1_27 = common ((import ./1_27/versions.nix) // { updateScript = [ ./update-script.sh "27" ]; <del> }) { }; </del> <ins> }) extraArgs; </ins> }

Discussion:
Tried updating to latest nixos-unstable, but k3s service won't start due to bug described here (): According to the issue golang 1.20 should be used for building. Steps to reproduce the behavior: to latest nixos-unstable k3s service enabled won't start k3s is starting without errors I downgraded to k3s125 for the time being, this version seems unaffected by the bug, 1.26 and 1.27 both seem to not work properly <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Thanks for the clear report, and digging up the upstream issue! Appreciated! I put up a PR to fix this: Since the tests pass there, that seems like a good sign the service starts up after that fix
Thank you for the quick fix, I tried to build your branch on my kind of weak Linux server, but I think it ran out of memory, so I can't test it right now unfortunately. Are there any tests in place for the module that check if it can start correctly? Maybe implementing something like that could save time in the future
There are such tests, yup. On current nixpkgs master: In , only package builds were tested, not individual packages. I think it just impacted so many packages total it wasn't practical to run all the package's tests.
Ah, that makes a lot of sense, my next question would have been why it didn't show up as failing earlier Thanks for the explanation! Did you have a chance to test it with the service? If not, I can boot up my slightly beefier NAS and see if it works there.
The k3s tests in the PR pass, which means the service starts and a pod runs! The tests cover enough that I'm fine trusting them for this fix. I appreciate the offer though!
Change:
maintainers = [ lib.maintainers.ttuegel ]; }; nativeBuildInputs = [ extra-cmake-modules kdoctools ]; <ins> propagatedUserEnvPkgs = [ baloo ]; </ins> propagatedBuildInputs = [ baloo baloo-widgets kactivities kbookmarks kcmutils kcompletion kconfig kcoreaddons kdelibs4support kdbusaddons kfilemetadata ki18n kiconthemes

Discussion:
Describe the bug A clear and concise description of what the bug is. When running dolphin on plasma5, getting this error: /cc To Reproduce Steps to reproduce the behavior: dolphin "Search for -Document" error Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): channels(mbauer): nixpkgs: Maintainer information:
It looks like adding to systemPackage fixes it.
cc
There is also a similar bug with Kmail if you don't include Akonadi in system path. Something must have changed in the way binaries are found.
We should make sure that puts in ; actually, anything that provides a should.
Change:
, esbuild , fetchFromGitHub , gdk-pixbuf <ins> , glib-networking </ins> , gobject-introspection , lib <del> , libsoup </del> <ins> , libsoup_3 </ins> , makeBinaryWrapper , nodejs , openssl

Discussion:
Steps to reproduce the behavior: Attempt to build surrealist version 2.0.6 on NixOS 24.11. The build fails during the build phase. I reported a similar issue here: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
another failure
Change:
virtualisation.bootDevice = mkDefault (driveDeviceName 1); <ins> virtualisation.useEFIBoot = mkDefault (config.boot.loader.systemd-boot.enable || config.boot.loader.efi.canTouchEfiVariables); </ins> virtualisation.pathsInNixDB = [ config.system.build.toplevel ]; # FIXME: Consolidate this one day.

Discussion:
Describe the bug on a NixOS configuration with systemd-boot as bootloader (the default for NixOS installs on UEFI systems) fails with this error: I checked that the file exists, so what's missing in the kernel since it reports "No such device"? Steps to reproduce This happens with nixos-20.09 and nixos-unstable, but not nixos-20.03. (Just change the command above.) Expected behavior The build succeeds, like it did before (on nixos-20.03). Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Metadata Please run and paste the result. Maintainer information:
Disabling ~systemd-boot~ efi settings from results in So the insmod error is the same, but now the init script doesn't die on
Ah, the default value of is , and with that value it actually succeeds. So it's not really the systemd-boot part of the config that is broken.
Oh, this comment recommends NOT to set , because it can wear out the NVRAM:
Ah, the default value of is false, [...] Well, except that sets it to true, so it is enabled by default for NixOS EFI installs.
Interestingly, the uses . That results in success!
Now the question is, where to set (or )? I see at least these places where conditionally adding it could make sense: Call site: Option declaration, in qemu- Implementation, in qemu- In the systemd- module:
Change:
enabled = mkOption { type = types.bool; default = false; <ins> defaultText = literalExpression "false"; </ins> description = '' Whether to enable proxying of remote media through the instance's proxy. '';

Discussion:
Seems like introduced a dependency on inside the default of , which make fail to build with: Steps to reproduce the behavior: to build a based on System builds fine Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
nextcloudGreaterOrEqualThan = req: versionAtLeast cfg.package.version req; <ins> mkAppStoreConfig = name: { enabled, writable, ... }: optionalString enabled '' [ 'path' => '${webroot}/${name}', 'url' => '/${name}', 'writable' => ${boolToString writable} ], ''; </ins> overrideConfig = pkgs.writeText "nextcloud-config.php" '' <?php ${optionalString requiresReadSecretFunction ''

Discussion:
The extraApp called displays as blank. This was working fine on nextcloud27. Rest of the site is working fine. Steps to reproduce the behavior: am currently on to webpage is blank on: Firefox Chrome Edge It should display the normal forms page. ! Found non-nixos issue relating to it here: Seems it may be a related issue? <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]: