jiebi/CodeConvo huggingface dataset:
Change:
license = licenses.gpl2Only; maintainers = with maintainers; [ Anton-Latukha wmertens ]; platforms = with platforms; unix; <del> broken = stdenv.isDarwin && lib.versionOlder stdenv.hostPlatform.darwinMinVersion "10.13"; </del> <ins> broken = stdenv.isDarwin;  # https://github.com/NixOS/nixpkgs/pull/297984#issuecomment-2016503434 </ins> }; }; in

Discussion:
Package name: handbrake Latest released version: 1.7.3 Current version on the unstable channel: 1.6.1 Current version on the stable/release channel: 1.6.1 Notify maintainers Note for maintainers: Please tag this issue in your PR.
Revised to 1.7.2 release
Revised to 1.7.3
Change:
, mesa , alsa-lib , wayland <del> , openssl_1_1 </del> , atk , qt6 , at-spi2-atk

Discussion:
the package wechat uos is still using OpenSSL 1.1 which is end of life on 2023/09/11, so it is marked as insecure now. not sure if we need to wait for wechat-uos or we can just bump it up in here. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
As far as I know, only from depends on OpenSSL 1.1. Seems like we may replace it with to completely remove dependency. I will try to fix that in the next PR when I have free time.
Would it be offensive if I could submit a patch about it now.
Feel free to do so. I would be happy to review your pr :)
Change:
double-conversion flatbuffers giflib <del> grpc </del> jsoncpp libjpeg_turbo ml-dtypes

Discussion:
Build of failed on x86_64-linux as of . This is currently breaking . maintainers cc: maintainers cc: Other cc: n/a nixpkgs at commit Contents of : This issue was automatically generated by . that created this issue. Internal tags: -
Bisected to
Since then, updating both (currently v1.60 on ) and (to ) has not made any difference on this matter.
See
Change:
```ShellSession $ nix-build . -A nixosTests.login.driverInteractive <del> $ ./result/bin/nixos-test-driver --interactive </del> <ins> $ ./result/bin/nixos-test-driver </ins> [...] >>> ```

Discussion:
When building an interactive test driver with and running the generated binary, the test just runs without an interactivity. Steps to reproduce the behavior: that the test just starts instead of displaying the interactive prompt. I'd expect to be dropped into the interactive prompt. cc as someone who's touched a lot.
Mostly reviews and minor additions though. Maybe broke it, but that's just a guess. Probably best to bisect with if going back to before that doesn't fix the problem.
Ah, it was broken by
Change:
let pname = "xonsh"; <del> version = "0.14.4"; </del> <ins> version = "0.15.1"; </ins> in python3.pkgs.buildPythonApplication { inherit pname version;

Discussion:
Using xonsh in a environment can override the Python interpreter, which is a problem if the environment is supposed to use a specific one. Then create containing Then inside xonsh, a different Python interpreter is used: Running xonsh should not modify the such that a different executable is used. In the above, when we run we should get the library. Running removes the problematic PATH entry but this is pretty hacky. Please run and paste the result.
I think the recommended way to do this is to add an override to xonsh. See
That's a help but if I launch a nested xonsh by running in xonsh, the extra packages are gone. I've removed these unwanted entries by doing, e.g. in : Everything works fine so far.
since your PR was is this issue still fixed? ETA: looks ok but if anyone still has in their config they should probably remove it before upgrading xonsh or they may get
To make it clear, was reapplied in , while reverting
Oops, it seems we have re-introduced this issue in
Change:
cudaPackages.cuda_cudart cudaPackages.cuda_cccl # <thrust/*> cudaPackages.libnpp # npp.h <del> cudaPackages.nvidia-optical-flow-sdk </del> <ins> nvidia-optical-flow-sdk </ins> ] ++ lib.optionals enableCublas [ # May start using the default $out instead once # https://github.com/NixOS/nixpkgs/issues/271792

Discussion:
nixpkgs @
Introduced in
apologies for the breakage, please see
Thanks! Unfortunately, I have no rights to merge.
Please review and test, then I will merge.
Yep, it works.
Merged. In future, could you use the "Files changed" tab on the PR to do acceptance?
Change:
url = mirror://cpan/authors/id/A/AB/ABRAXXA/CatalystX-Script-Server-Starman-0.02.tar.gz; sha256 = "0h02mpkc4cmi3jpvcd7iw7xyzx55bqvvl1qkf967gqkvpklm0qx5"; }; <ins> patches = [ # See Nixpkgs issues #16074 and #17624 ../development/perl-modules/CatalystXScriptServerStarman-fork-arg.patch ]; </ins> buildInputs = [ TestWWWMechanizeCatalyst ]; propagatedBuildInputs = [ CatalystRuntime Moose namespaceautoclean Starman ]; meta = {

Discussion:
As of nixos/nixpkgs (i.e., today) seems to be failing due to an unsupported command line switch being passed (see ) Actually, starting doesn't fail, but some (all?) of the other command line arguments are ignored. For example, I tried setting , but see how insists on starting on port . Removing the switch makes start as expected, respecting the other given command line switches, but is this what we want to do? cc
this was broken due to Catalyst bump. See duplicated - I don't know how to best fix this as switch might have an impact. If someone has time to fix it, I'd be very happy :)
Change:
description = "TUI and CLI for the BitTorrent client Transmission"; homepage = "https://github.com/rndusr/stig"; license = licenses.gpl3Plus; <del> maintainers = with maintainers; [ doronbehar ]; </del> <ins> # Too many broken tests, and it fails to launch broken = true; maintainers = with maintainers; [  ]; </ins> }; }

Discussion:
Steps to reproduce the behavior: stig If I try to install it from my config, I get . If I try to run it by nix-shell: is the nixpkgs commit I'm currently using to get a working version of this program. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
The different experience you get with vs is a problem in your Nix environment - probably an old version of nixpkgs you use for vs how you build "your config". However the test failing mark this package is now completely broken. See also discussion with upstream at: . I opened that marks stig as broken, and it will close this issue when merged.
stig works for me with this overlay: I think since addresses
It'd be great if you'd share this in a PR.
Opened at !
Change:
""" def check_active(_: Any) -> bool: <del> info = self.get_unit_info(unit, user) state = info["ActiveState"] </del> <ins> state = self.get_unit_property(unit, "ActiveState", user) </ins> if state == "failed": raise Exception(f'unit "{unit}" reached state "{state}"')

Discussion:
The error currently does not even elaborate which unit it's been inquiring about, and overall it looks like the test driver is failing, rather than the service being tested: One can see the same behaviour in e.g. This is far from a minimal example, but it works for me: after () until you observe the driver failing with (the error isn't deterministic) The test work or fail deterministically. Instead of in the driver, a message about the unit should be displayed If applicable, add screenshots to help explain your problem. Add any other context about the problem here. I suspect the systemctl might be running into this branch and then we're not seeing the message, because the driver only captures the stdout: I couldn't confirm though. The SLURM test: Recently edited : <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Possibly a better reproducer: try (or any ). When I run locally/outsdie the VM I observe . It fails pretty consistently inside the VM for me
Change:
''; homepage = "https://ra3xdh.github.io/"; license = licenses.gpl2Plus; <del> maintainers = with maintainers; [ mazurel ]; </del> <ins> maintainers = with maintainers; [ mazurel kashw2 ]; </ins> platforms = with platforms; linux; }; }

Discussion:
Package name: qucs-s Latest released version: 2.0.0 Current version on the unstable channel: 1.1.0 Current version on the stable/release channel: 1.0.2 Notify maintainers Release: Note for maintainers: Please tag this issue in your PR.
Change:
<ins> { lib, buildPythonPackage, fetchFromGitHub, setuptools, setuptools-scm, pillow, qrcode, python-barcode, six, appdirs, pyyaml, argcomplete, importlib-resources, pyusb, pyserial, pycups, jaconv, pytestCheckHook, pytest-mock, scripttest, mock, hypothesis, }: buildPythonPackage rec { pname = "python-escpos"; version = "3.1"; pyproject = true; src = fetchFromGitHub { owner = "python-escpos"; repo = "python-escpos"; rev = "refs/tags/v${version}"; hash = "sha256-f7qA1+8PwnXS526jjULEoyn0ejnvsneuWDt863p4J2g="; fetchSubmodules = true; }; build-system = [ setuptools setuptools-scm ]; dependencies = [ pillow qrcode python-barcode six appdirs pyyaml argcomplete importlib-resources ]; optional-dependencies = { usb = [ pyusb ]; serial = [ pyserial ]; cups = [ pycups ]; all = [ pyusb pyserial pycups ]; }; preCheck = '' # force the tests to use the module in $out rm -r src # disable checking coverage substituteInPlace pyproject.toml  --replace-fail "--cov escpos --cov-report=xml" "" # allow tests to find the cli executable export PATH="$out/bin:$PATH" ''; nativeCheckInputs = [ jaconv pytestCheckHook pytest-mock scripttest mock hypothesis ] ++ optional-dependencies.all; pythonImportsCheck = [ "escpos" ]; meta = { changelog = "https://github.com/python-escpos/python-escpos/blob/${src.rev}/CHANGELOG.rst"; description = "Python library to manipulate ESC/POS printers"; homepage = "https://python-escpos.readthedocs.io/"; license = lib.licenses.mit; mainProgram = "python-escpos"; maintainers = with lib.maintainers; [ tomasajt ]; }; } </ins>

Discussion:
Python library that provides useful tools for thermal printers using the ESC/POS standard. <!-- Describe the project a little: --Metadata homepage URL: source URL: license: mit platforms: linux Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
start org.nixos.nix-daemon</command>. </para> </listitem> <ins> <listitem> <para> The Syncthing state and configuration data has been moved from <varname>services.syncthing.dataDir</varname> to the newly defined <varname>services.syncthing.configDir</varname>, which default to <literal>/var/lib/syncthing/.config/syncthing</literal>. This change makes possible to share synced directories using ACLs without Syncthing resetting the permission on every start. </para> </listitem> </ins> </itemizedlist> </listitem> <listitem>

Discussion:
The NixOS syncthing service with default settings sets (where $HOME is /var/lib/syncthing) and with that breaks upstream assumption: The result is that you cannot run syncthing with (nixos) default settings and give access to various users with ACLs, as syncthing will set perms 700 on the directory passed in each time it starts. And as is the same as , your default shared folders are now hidden behind 700 perms. Workaround (hack): Based on , the fix seems to be simply setting instead of . and ACL: that your user has access: syncthing: no longer have access to the share: system: host os: multi-user?: sandbox: version: channels(root): channels(bfo): nixpkgs:
The fix is easy but it will break all existing setups. We could add a and mention it in the release changes.
Change:
}; }; <ins> NetLibIDN2 = buildPerlModule { pname = "Net-LibIDN2"; version = "1.02"; src = fetchurl { url = "mirror://cpan/authors/id/T/TH/THOR/Net-LibIDN2-1.02.tar.gz"; hash = "sha256-0fMK/GrPplQbAMCafkx059jkuknjJ3wLvEGuNcE5DQc="; }; propagatedBuildInputs = [ pkgs.libidn2 ]; meta = { description = "Perl bindings for GNU Libidn2"; homepage = "https://github.com/gnuthor/Net--LibIDN2"; license = with lib.licenses; [ artistic1 gpl1Plus ]; }; }; </ins> NetNetmask = buildPerlPackage { pname = "Net-Netmask"; version = "2.0001";

Discussion:
SpamAssassin generates and compiles C code from anti-spam rules. This currently fails because the generated code makes use of the function, which is not available during the rule compilation process. Steps to reproduce the behavior: the SpamAssassin service that sa-update.service fails with the error message: that, consequently, spamd.service will not function. Alternatively, the error can also be observed by invoking directly. sa-update.service succeeds <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
A smoke-test that serves as a reproducer is available in .
In theory, this could be addressed by making libxcrypt available when compiling rules, but care must probably also be taken so that the dynamic linker can find it at rule run-time.
Rule compilation seems to complete without errors for the rule if we set . However, of course the resulting binary is not linked against libxcrypt then. I’m not sure when Spamassassin will generate code that actually calls functions from that library.
Change:
hashed-mirrors = connect-timeout = 1 ''; <ins> # save some memory documentation.enable = false; </ins> }; # /etc/nixos/configuration.nix for the vm configFile = pkgs.writeText "configuration.nix"  ''

Discussion:
Describe the bug See This is because vmTools.diskImageFuns.debian9i386 doesn't build
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
Closing since indicates that it fixed this.
Change:
<ins> { config, lib, pkgs, ... }: with lib; let cfg = config.services.gonic; settingsFormat = pkgs.formats.keyValue { mkKeyValue = lib.generators.mkKeyValueDefault { } " "; listsAsDuplicateKeys = true; }; in { options = { services.gonic = { enable = mkEnableOption (lib.mdDoc "Gonic music server"); settings = mkOption rec { type = settingsFormat.type; apply = recursiveUpdate default; default = { listen-addr = "127.0.0.1:4747"; cache-path = "/var/cache/gonic"; tls-cert = null; tls-key = null; }; example = { music-path = [ "/mnt/music" ]; podcast-path = "/mnt/podcasts"; }; description = lib.mdDoc '' Configuration for Gonic, see <https://github.com/sentriz/gonic#configuration-options> for supported values. ''; }; }; }; config = mkIf cfg.enable { systemd.services.gonic = { description = "Gonic Media Server"; after = [ "network.target" ]; wantedBy = [ "multi-user.target" ]; serviceConfig = { ExecStart = let # these values are null by default but should not appear in the final config filteredSettings = filterAttrs (n: v: !((n == "tls-cert" || n == "tls-key") && v == null)) cfg.settings; in "${pkgs.gonic}/bin/gonic -config-path ${settingsFormat.generate "gonic" filteredSettings}"; DynamicUser = true; StateDirectory = "gonic"; CacheDirectory = "gonic"; WorkingDirectory = "/var/lib/gonic"; RuntimeDirectory = "gonic"; RootDirectory = "/run/gonic"; ReadWritePaths = ""; BindReadOnlyPaths = [ # gonic can access scrobbling services "-/etc/ssl/certs/ca-certificates.crt" builtins.storeDir cfg.settings.podcast-path ] ++ cfg.settings.music-path ++ lib.optional (cfg.settings.tls-cert != null) cfg.settings.tls-cert ++ lib.optional (cfg.settings.tls-key != null) cfg.settings.tls-key; CapabilityBoundingSet = ""; RestrictAddressFamilies = [ "AF_UNIX" "AF_INET" "AF_INET6" ]; RestrictNamespaces = true; PrivateDevices = true; PrivateUsers = true; ProtectClock = true; ProtectControlGroups = true; ProtectHome = true; ProtectKernelLogs = true; ProtectKernelModules = true; ProtectKernelTunables = true; SystemCallArchitectures = "native"; SystemCallFilter = [ "@system-service" "~@privileged" ]; RestrictRealtime = true; LockPersonality = true; MemoryDenyWriteExecute = true; UMask = "0066"; ProtectHostname = true; }; }; }; meta.maintainers = [ maintainers.autrimpo ]; } </ins>

Discussion:
Project description music streaming server / subsonic server API implementation Metadata homepage URL: source URL: license: gpl3 platforms: linux package: The package is already there, maintained by It'd be nice to have a module too!
I can submit a module PR once is merged, as it adds some new options (filesystem watcher).
Change:
}; services.resolved.fallbackDns = mkOption { <del> default = [ ]; </del> <ins> default = null; </ins> example = [ "8.8.8.8" "2001:4860:4860::8844" ]; <del> type = types.listOf types.str; </del> <ins> type = types.nullOr (types.listOf types.str); </ins> description = lib.mdDoc '' A list of IPv4 and IPv6 addresses to use as the fallback DNS servers. <del> If this option is empty, a compiled-in list of DNS servers is used instead. </del> <ins> If this option is null, a compiled-in list of DNS servers is used instead. Setting this option to an empty list will override the built-in list to an empty list, disabling fallback. </ins> ''; };

Discussion:
is empty as a default value, and has the description of: A list of IPv4 and IPv6 addresses to use as the fallback DNS servers. If this option is empty, a compiled-in list of DNS servers is used instead. The "compiled-in list" seems to be: This means that if somebody wanted to intentionally set the list to an empty value, the person will need to try some workarounds. Just set the compiled value as the default value, and stop relying on the compiled-in list. This affects , , and versions of at least .
I marked this as stale due to inactivity. &rarr;
set to empty value is not empty, it affects . For me it's security issue, I don't want my server to contact public DNS without being explicitly allowed to do so.
Relevant upstream issue: Looks like they don't care to change it. This value only seems to be used as a last resort when the isn't set and "if none could be learnt via dhcp or ppp".
Oh, he cares. He cares so much and has a strong oppinion on how this should be done that he refuses to change it. Don't mistake Poetterings answer for not caring. He cares deeply.
Note that overriding default values is indeed possible using a single statement with no value. In fact this would be supported by the NixOS module if it weren't for the default being injected on an empty list. This would be a breaking change for a select few I assume, but to be and to and to be then providing as a value (from a user perspective) would set the config value to which would override the upstream behaviour to use no fallback servers. As a stopgap measure you can use this in your config, but being able to use this without extraConfig would be nice considering there is an actual option for this kind of thing. Edit: gonna send a pull request
Change:
let spirv_sources = { <del> # `vulkan-loader` requires a specific version of `spirv-tools` and `spirv-headers` as specified in # `<vulkan-loader-repo>/external_revisions/spirv-tools_revision`. </del> <ins> # `glslang` requires a specific version of `spirv-tools` and `spirv-headers` as specified in `known-good.json`. </ins> tools = fetchFromGitHub { owner = "KhronosGroup"; repo = "SPIRV-Tools"; <del> rev = "7e2d26c77b606b21af839b37fd21381c4a669f23"; sha256 = "1nlzj081v1xdyfz30nfs8hfcnqd072fra127h46gav179f04kss2"; </del> <ins> rev = "9e19fc0f31ceaf1f6bc907dbf17dcfded85f2ce8"; sha256 = "1zpwznq0fyvkzs5h9nnkr7g6svr0w8z6zx62xgnss17c2a5cz0lk"; </ins> }; headers = fetchFromGitHub { owner = "KhronosGroup"; repo = "SPIRV-Headers"; <del> rev = "2bb92e6fe2c6aa410152fc6c63443f452acb1a65"; sha256 = "1rgjd7kpa7xpbwpzd6m3f6yq44s9xn5ddhz135213pxwbi5c0c26"; </del> <ins> rev = "ce309203d7eceaf908bea8862c27f3e0749f7d00"; sha256 = "1sv1iy2d46sg7r3xy591db6fn9h78wd079yvfa87vwmwsdkhiqhm"; </ins> }; };

Discussion:
Tried to make a system upgrade, got this: Obviously, upgrade can't be completed. have in . run Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
This looks like the offending line: This could be related to what file system you are using?
Actually this looks like unrelated to glslang. Works on master:
Change:
, zsh # command-t dependencies <ins> , getconf </ins> , ruby # cpsm dependencies

Discussion:
The vim plugin is currently undergoing a full rewrite. As part of this, it appears to have changed how it compiles. On Darwin it now compiles using (). is not available when building in Nix and so it fails. Most likely the reference to can just be patched out. It also runs () which is also reporting a "command not found" line, although this appears to be non-fatal. This affects all platforms. Steps to reproduce the behavior: I don't know if anyone in particular is responsible here but appears to have fixed the build of this plugin most recently Please run and paste the result.
Change:
./services/audio/alsa.nix ./services/audio/botamusique.nix ./services/audio/gmediarender.nix <ins> ./services/audio/gonic.nix </ins> ./services/audio/hqplayerd.nix ./services/audio/icecast.nix ./services/audio/jack.nix

Discussion:
Project description music streaming server / subsonic server API implementation Metadata homepage URL: source URL: license: gpl3 platforms: linux package: The package is already there, maintained by It'd be nice to have a module too!
I can submit a module PR once is merged, as it adds some new options (filesystem watcher).
Change:
buildGoModule rec { pname = "ghorg"; <del> version = "1.5.1"; </del> <ins> version = "1.7.8"; </ins> src = fetchFromGitHub { owner = "gabrie30"; repo = "ghorg"; <del> rev = version; sha256 = "sha256-HkOMG7VG8jyvr1W1T/62murtNYE8wyT/p3lDtuxfm5M="; </del> <ins> rev = "v${version}"; sha256 = "sha256-NZlPcr13onxgbmKPdv0ODOhYDT5T+OeSvHE8VGOGyo4="; </ins> }; doCheck = false;

Discussion:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.5.1 desired version: 1.7.8 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Change:
, qtbase , qtsvg , qttools <ins> , wrapGAppsHook </ins> , wrapQtAppsHook , guiSupport ? true

Discussion:
I encountered this error when attempting to open files from qBittorrent: It's working fine on . Steps to reproduce the behavior: Run nix shell nixpkgs#qbittorrent. Open qBittorrent. Navigate to Files -Add torrent files. The app crashes. It should open my File Manager. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Seems to be a case of the first error in the . Would you mind trying out