jiebi/CodeConvo huggingface dataset:
Change:
}) ]; <del> depsBuildBuild = [ buildPackages.stdenv.cc ]; </del> nativeBuildInputs = [ autoreconfHook ]; <del> configureFlags = [ "--with-hotplug-dir=$(out)/lib/firmware" ]; </del> <ins> configureFlags = [ "--with-hotplug-dir=$(out)/lib/firmware" ]; depsBuildBuild = lib.optional ( stdenv.buildPlatform != stdenv.hostPlatform || stdenv.hostPlatform.isAarch64 ) buildPackages.stdenv.cc; </ins> dontStrip = true;

Discussion:
Steps to reproduce the behavior: Discovered by <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
in pkgs.writeShellScript "manage" '' ${setupEnv} <ins> eval "$(${config.systemd.package}/bin/systemctl show -pUID,MainPID photoprism.service | ${pkgs.gnused}/bin/sed "s/UID/ServiceUID/")" exec ${pkgs.util-linux}/bin/nsenter  -t $MainPID -m -S $ServiceUID -G $ServiceUID --wdns=${cfg.storagePath}  </ins> exec ${cfg.package}/bin/photoprism "$@" ''; in

Discussion:
Cannot use script created by the photoprism nixos module. Example config: And then with the instance up and running: The script should work and list the users. Seems that the systemd service running photoprism runs as user , which mariadb's unix socket auth works correctly. And the uses the same user , but do not let user to access the database as user . Maybe this can be fix by changing the database user to but that implies changing that in the systemd service user as well. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
have a look at PRs are welcome.
Here is the he's referring. So basically we could change the script to grab the UID of the photoprism user and the PID of the systemd service and then execute the binary?
Change:
propagatedBuildInputs = [ # Required for linking downstream binaries. <del> abseil-cpp openh264 usrsctp libevent libvpx </del> <ins> abseil-cpp openh264 usrsctp libevent libvpx openssl_1_1 </ins> ]; meta = with lib; {

Discussion:
On current , (4.2.4) group voice chat will be stuck on "connecting" forever, while private group voice works. This issue exists when connecting from different countries, using different account, with or without proxy, so it seems not really a "connection issue". a voice chat in a private group. it stuck on "connecting" phase forever. Successfully starts or joins a voice chat. chat and live stream are broken. (one to one) voice chat works without issues. 's version of telegram works. (Its font is broken though) Please run and paste the result.
Change:
lcms openjpeg tbb_2021_11 <ins> blend2d </ins> ]; cmakeFlags = [ (lib.cmakeBool "PDF4QT_INSTALL_TO_USR" false) ]; <ins> dontWrapGApps = true; preFixup = '' qtWrapperArgs+=(''${gappsWrapperArgs[@]}) ''; </ins> meta = { description = "Open source PDF editor"; longDescription = ''

Discussion:
Package name: PDF4QT Latest released version: 1.4.0 Current version on the unstable channel: 1.3.7 Current version on the stable/release channel: 1.3.7 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Sorry for the ignorance. Repology didn't prompt me to update. I will try to update it tomorrow.
is it possible to backport to 24.05?
Change:
<ins> { stdenv, fetchurl }: stdenv.mkDerivation rec { pname = "pstree"; version = "2.39"; src = fetchurl { urls = [ "https://distfiles.macports.org/${pname}/${pname}-${version}.tar.gz" "https://fossies.org/linux/misc/${pname}-${version}.tar.gz" "ftp://ftp.thp.uni-duisburg.de/pub/source/${pname}-${version}.tar.gz" ]; sha256 = "17s7v15c4gryjpi11y1xq75022nkg4ggzvjlq2dkmyg67ssc76vw"; }; sourceRoot = "."; buildPhase = '' runHook preBuild $CC $NIX_CFLAGS -o pstree pstree.c runHook postBuild ''; installPhase = '' runHook preInstall install -Dm0555 ${pname} -t $out/bin install -Dm0444 ${pname}.1 -t $out/share/man/man1 runHook postInstall ''; meta = with stdenv.lib; { description = "Show the set of running processes as a tree"; homepage = "http://www.thp.uni-duisburg.de/pstree/"; license = licenses.gpl2; maintainers = [ maintainers.c0bw3b ]; platforms = platforms.unix; priority = 5; # Lower than psmisc also providing pstree on Linux platforms }; } </ins>

Discussion:
removed the old package and aliased it to instead. The problem is, is specifically only supported on Linux (it even lives in the subdirectory), whereas the old was supported on Darwin. On macOS, run . This used to work, but now it tries to install and throws an error.
cc
I was convinced was enabled on all unix platforms too but I fooled myself. I'll revive classic pstree (with more stable sources) later today and remove the alias. Thanks for raising the issue
The description of says it uses the filesystem so it sounds like there's no chance it will ever support macOS.
Change:
bypassCache = true; reconstructLock = true; }; <del> bash-language-server = nodeEnv.buildNodePackage { name = "bash-language-server"; packageName = "bash-language-server"; version = "5.3.4"; src = fetchurl { url = "https://registry.npmjs.org/bash-language-server/-/bash-language-server-5.3.4.tgz"; sha512 = "9GEzJVOOyU7ZQbDI/uFc8N9FGuun6UZv1qB9bNUbehIb1gA4pOpkIYtqtfSq0XQSO25hMp8d/tzsmFJmeX+dQg=="; }; dependencies = [ sources."@nodelib/fs.scandir-2.1.5" sources."@nodelib/fs.stat-2.0.5" sources."@nodelib/fs.walk-1.2.8" sources."braces-3.0.3" sources."domino-2.1.6" sources."encoding-0.1.13" sources."fast-glob-3.3.2" sources."fastq-1.17.1" sources."fill-range-7.1.1" sources."fuzzy-search-3.2.1" sources."glob-parent-5.1.2" sources."iconv-lite-0.6.3" sources."is-extglob-2.1.1" sources."is-glob-4.0.3" sources."is-number-7.0.0" sources."merge2-1.4.1" sources."micromatch-4.0.7" sources."node-fetch-2.7.0" sources."picomatch-2.3.1" sources."queue-microtask-1.2.3" sources."reusify-1.0.4" sources."run-parallel-1.2.0" sources."safer-buffer-2.1.2" sources."to-regex-range-5.0.1" sources."tr46-0.0.3" sources."turndown-7.1.3" sources."vscode-jsonrpc-8.0.2" sources."vscode-languageserver-8.0.2" sources."vscode-languageserver-protocol-3.17.2" sources."vscode-languageserver-textdocument-1.0.11" sources."vscode-languageserver-types-3.17.2" sources."web-tree-sitter-0.22.5" sources."webidl-conversions-3.0.1" sources."whatwg-url-5.0.0" sources."zod-3.22.4" ]; buildInputs = globalBuildInputs; meta = { description = "A language server for Bash"; homepage = "https://github.com/bash-lsp/bash-language-server#readme"; license = "MIT"; }; production = true; bypassCache = true; reconstructLock = true; }; </del> bower = nodeEnv.buildNodePackage { name = "bower"; packageName = "bower";

Discussion:
Steps to reproduce the behavior: This seems to have been caused by although I'm not familiar with the package, so I could be wrong. It is causing to fail as a result. I don't quite understand the organization of the structure, so I'm not sure who the appropriate maintainer is. As a fallback, and were involved in the above linked PR, so they may be of help here. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
sorry for the breakage, i opened to fix this
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Had the same issue. But I think it's fixed in PR as mentioned You can track the progress of the PR , apparently it hasn't been merged into nixpkgs-unstable yet.
Change:
hint = self.hint_0_4_3; }; <ins> # Looks like Avahi provides the missing library dnssd = super.dnssd.override { dns_sd = pkgs.avahi.override { withLibdnssdCompat = true; }; }; </ins> }

Discussion:
The Haskell package build fails due to missing C library. I assume it just needs a dependency on . The describes how to add non-Haskell dependencies to a Stack build, but what if I'm not using Stack? The build fails, outputting:
Change:
testToolDepends = (drv.testToolDepends or []) ++ [pkgs.postgresql]; }) super.beam-postgres; <ins> # PortMidi needs an environment variable to have ALSA find its plugins: # https://github.com/NixOS/nixpkgs/issues/6860 PortMidi = overrideCabal (drv: { patches = (drv.patches or []) ++ [ ./patches/portmidi-alsa-plugins.patch ]; postPatch = (drv.postPatch or "") + '' substituteInPlace portmidi/pm_linux/pmlinuxalsa.c  --replace @alsa_plugin_dir@ "${pkgs.alsa-plugins}/lib/alsa-lib" ''; }) super.PortMidi; </ins> # Fix for base >= 4.11 scat = overrideCabal (drv: { patches = [(fetchpatch {

Discussion:
Shell environment settings required for correct operation of Haskell packages don't seem to be ensured. This report discusses the impact on ALSA sound access. It may be platform dependent to some extent. Steps to reproduce the behavior: inside to play a sound through MIDI (MIDI must be set up): access fails: No error message. Instead, you hear a sound. It works when setting For executables, this would be solved by setting the environment using (e.g. , or ). AFAIK, there is nothing similar for shared objects, and would have to be wrapped instead. Would there be any mechanism that allows collecting the required environment variables and wrap them from ? Pinging the Haskell team since I don't see specific maintainers in the relevant packages: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
There are now two possible fixes that could be merged: might still need adaption for ways to consume other than through . But it should be way easier to apply the approach to other Haskell modules that suffer from the ALSA plugin path issue. modifies the environment when the process is already running, so its correct operation might depend on assumptions regarding library data access timings. But it has the advantage of solving the issue more locally, thus being less dependent on how the Haskell module is being used.
Change:
./services/audio/botamusique.nix ./services/audio/gmediarender.nix ./services/audio/gonic.nix <ins> ./services/audio/goxlr-utility.nix </ins> ./services/audio/hqplayerd.nix ./services/audio/icecast.nix ./services/audio/jack.nix

Discussion:
Project description An unofficial GoXLR App replacement for Linux, Windows and MacOS. Metadata homepage URL: source URL: license: MIT platforms: linux
Moving conversation back here to avoid spamming goxlr-utility maintainers :sweat_smile: I made a draft PR that you can find from It's closer to what the official .deb and .rpm packaging is doing, i.e. including some of the relevant resources, shell completion etc. I wouldn't mind adding you as a maintainer but to do that it probably requires adding you to the maintainer list as well. Should be easy to fix if you want to add PR to the branch.
Hey wow you are fast :D Yes, you can add me as a maintainer for this package. But as I understand it, I need to add me to the maintainer list first, right?
Hah, had some free time during the night and since I wanted to get my GoXLR setup working anyways thought I might as well sort this out. For the question: Yup, the requires to be on . The file itself lists the mandatory/optional fields in the metadata, but basically "a name and at least one contact/identity information" (e.g. a github id). Oh, and the list needs to stay in alphabetical order ^^ Feel free to make PR against this branch, I'll merge it as soon as I notice the PR :)
Added the module to the PR as well. I guess it might be hard to wait for someone with GoXLR to come in and review the PR (though I'd prefer someone to check that it doesn't violate any major guidelines) so if you don't mind I think it's possible for you to try it out and do a PR review, which likely speeds up the process at least :)
Managed to get the PR reviewed and should now be code-wise idiomatic enough to pass. I think based on the main thing remaining is getting thumbs up from you functionality-wise so that's it's not only "works on my machine" :sweat_smile:
I saw your PR and tried using nixpkgs-review to download it to my local machine and try to run it. I used these steps: Do you know if my approach is wrong? This is the first time I've tried a Nix PR. Unfortunately, I haven't found much information about it.

EDIT: Got it working
Glad to hear you got it working! :) The nixpkgs-review tool seems nice, hadn't used it myself but for building the PR it seems to do exactly what one would expect. I guess in this case there's a limit what it can do though as the udev rules are being on the module side and it probably doesn't handle that so some manual work is required :shrug: But again, all is good since you did manage to test the build!
Change:
unitConfig.Documentation = if service == "zebra" then "man:zebra(8)" else "man:${daemon}(8) man:zebra(8)"; <del> restartTriggers = [ </del> <ins> restartTriggers = mkIf (service != "mgmt") [ </ins> (configFile service) ]; <del> reloadIfChanged = true; </del> <ins> reloadIfChanged = (service != "mgmt"); </ins> serviceConfig = { PIDFile = "frr/${daemon}.pid"; <del> ExecStart = "${pkgs.frr}/libexec/frr/${daemon} -f /etc/frr/${service}.conf" </del> <ins> ExecStart = "${pkgs.frr}/libexec/frr/${daemon}" </ins> + optionalString (scfg.vtyListenAddress != "") " -A ${scfg.vtyListenAddress}" + optionalString (scfg.vtyListenPort != null) " -P ${toString scfg.vtyListenPort}" + " " + (concatStringsSep " " scfg.extraOptions); <del> ExecReload = "${pkgs.python3.interpreter} ${pkgs.frr}/libexec/frr/frr-reload.py --reload --daemon ${daemonName service} --bindir ${pkgs.frr}/bin --rundir /run/frr /etc/frr/${service}.conf"; </del> <ins> ExecReload = mkIf (service != "mgmt") "${pkgs.python3.interpreter} ${pkgs.frr}/libexec/frr/frr-reload.py --reload --daemon ${daemon} --bindir ${pkgs.frr}/bin --rundir /run/frr /etc/frr/${daemon}.conf"; </ins> Restart = "on-abnormal"; }; });

Discussion:
using frr-9.0.1 from nixos-23.11 results in failure of staticd.service: = true systemctl status staticd staticd used to work with option see Quick fix see below. maybe / want to insert themselves kindly into maintainers :-) system: host os: multi-user?: sandbox: version: channels(fd): channels(root): nixpkgs:
No, sorry. I'm a BIRD user, and I like it that way. Me writing that test and getting FRR over the finish line was some morbid curiosity. My only interest in FRR was bgp-evpn signaling fwiw.
Thanks even more for contributing! My quickfix for this issue is so far It seems, config file location with mgmtd is now instead of mgmtd is needed for staticd to get configured.
also mentions
yes, all daemons have as default config file, I'll try to adapt the nixos service accordingly to get rid of in all service definitions.
Please also test with: (should not have changed this).
Change:
srandrd = callPackage ../tools/X11/srandrd { }; <del> sratoolkit = callPackage ../applications/science/biology/sratoolkit { }; </del> srecord = callPackage ../development/tools/misc/srecord { }; srelay = callPackage ../tools/networking/srelay { };

Discussion:
Package name: sratoolkit Latest released version: 3.1.1 Current version on the unstable channel: 2.11.3 Current version on the stable/release channel: 2.11.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
''; }; <del> startGnuPGAgent = mkOption { type = types.bool; default = false; description = '' Whether to start the GnuPG agent when you log in.  The GnuPG agent remembers private keys for you so that you don't have to type in passphrases every time you make an SSH connection or sign/encrypt data.  Use <command>ssh-add</command> to add a key to the agent. ''; }; </del> startDbusSession = mkOption { type = types.bool; default = true;

Discussion:
Commit from updated the default version of the GNU Privacy Guard a.k.a. GPG to version 2.1. Unfortunately, this update broke the gpg-related tests of , , apparently because there is some subtle change in the behavior of the GPG 1.x compatibility layer (git-annex relies on rather than using gpg2 directly). To remedy that issue, I fixed to use version 2.0 in . This is no good solution, unfortunately, because now people who rely on `gnupg1' end up having a version of GnuPG 2.0 in their profile that cannot talk to the gpg-agent from version 2.1, which happens to be the one that's installed in the system by default. In it's current state, gpg1 does not work reliably in NIxOS. To work around this issue, I would suggest that we revert to version 2.0 until we've had time to figure out what exactly has changed between versions 2.1 and 2.0 and why this affects .
FYI: Another thing I came across, due to a broken clawsmail pgp, was that the handling of gpg-agent differs from version 2.0 . GnuPG 2.1 do not use GPGAGENTINFO anymore. Instead it search for the gpg-agent socket in
For now at least, setting GPGAGENTINFO to $ seems to make claws-mail work.
Change:
export HOME=$TMPDIR ''; <ins> dontWrapPythonPrograms = true; </ins> passthru = { shellPath = "/bin/xonsh"; python = python3; # To the wrapper

Discussion:
Using xonsh in a environment can override the Python interpreter, which is a problem if the environment is supposed to use a specific one. Then create containing Then inside xonsh, a different Python interpreter is used: Running xonsh should not modify the such that a different executable is used. In the above, when we run we should get the library. Running removes the problematic PATH entry but this is pretty hacky. Please run and paste the result.
I think the recommended way to do this is to add an override to xonsh. See
That's a help but if I launch a nested xonsh by running in xonsh, the extra packages are gone. I've removed these unwanted entries by doing, e.g. in : Everything works fine so far.
since your PR was is this issue still fixed? ETA: looks ok but if anyone still has in their config they should probably remove it before upgrading xonsh or they may get
To make it clear, was reapplied in , while reverting
Oops, it seems we have re-introduced this issue in
Change:
in { openvpn_24 = generic { <del> version = "2.4.9"; sha256 = "1qpbllwlha7cffsd5dlddb8rl22g9rar5zflkz1wrcllhvfkl7v4"; </del> <ins> version = "2.4.11"; sha256 = "06s4m0xvixjhd3azrzbsf4j86kah4xwr2jp6cmcpc7db33rfyyg5"; </ins> }; openvpn = generic { <del> version = "2.5.0"; sha256 = "sha256-AppCbkTWVstOEYkxnJX+b8mGQkdyT1WZ2Z35xMNHj70="; </del> <ins> version = "2.5.2"; sha256 = "sha256-sSdDg2kB82Xvr4KrJJOWfhshwh60POmo2hACoXycHcg="; </ins> }; }

Discussion:
, CVSSv3=7.5 (nixos-unstable) CVSSv3=7.5 (nixos-unstable) Scanned versions: nixos-unstable: . Cc Cc
The second one is about the Aviatrix VPN Client.

, CVSSv3=7.5 (nixos-20.09, nixos-unstable) CVSSv3=7.5 (nixos-20.09, nixos-unstable) Scanned versions: nixos-20.09: ; nixos-unstable: . Cc Cc
Change:
# I set --disable-strip because later we strip anyway. And it fails to strip # properly when cross building. configureFlags = [ <ins> "--sbindir=${out}/bin" </ins> "--localstatedir=/var" "--with-pid-dir=/run" "--with-mantype=man"

Discussion:
My understanding was that nix rejected the / distinction and we avoided having folders in our outputs. At the same time, I see that at least the following packages have nontrivial output folders: - - - probably several more And that we have workarounds like in place to deal with that fact. Questions: Are those packages supposed to have output folders? Is the exception policy described somewhere? What mechanism is suppressing in , for example? It looks like at least for , the was intentional:
Are you sure they're not symlinks? E.g. for iptables is a symlink: The script seems to be working fine here and on Hydra. For the other examples, they were written before the move-sbin-to-bin script, so they can probably just be fixed to use /bin. A stricter policy would be to remove /sbin completely; I like that, as the current approach does cause some overhead, particularly in buildEnv (It's not smart enough to merge all the symlinks together) Old mailing list discussion:
That would first need quite some changes in nixpkgs: but it should be safe to sed this without much checking.
All packages on this list do have sbin only as symlink to bin (x86_64-linux, master). Perhaps some buildEnv confused you? (It seems you meant the same platform.) The string there was very long ago: .
(triage) Is there an action item? Are the sbin folders problematic?
i believe there is a fixupPhase that moves all sbin items to bin, but then symlinks sbin to bin incase sbin paths where hard-coded into things that may be part of what is adding confusion to this
In all the cases above it's just a symlink, as there's that hook moving stuff around. It doesn't seem likely to me that someone would really want to eliminate all references, as it's nontrivial work with risks of breakage and very little to gain IMHO. (Also, contrary to merge that is quite common nowadays, I haven't noticed any other distro getting rid of .)
Change:
) + "-patched" , patches   ? [] , postPatch ? "" <del> }: stdenvNoCC.mkDerivation { </del> <ins> , ... }@args: stdenvNoCC.mkDerivation { </ins> inherit name src patches postPatch; preferLocalBuild = true; allowSubstitutes = false; phases = "unpackPhase patchPhase installPhase"; installPhase = "cp -R ./ $out"; <del> }; </del> <ins> } # Carry `meta` information from the underlying `src` if present. // (optionalAttrs (src?meta) { inherit (src) meta; }) // (removeAttrs args [ "src" "name" "patches" "postPatch" ]); </ins> /* An immutable file in the store with a length of 0 bytes. */ emptyFile = runCommand "empty-file" {

Discussion:
The nextcloud package set offers apps, that have licensing information attached, but not exposed as part of their meta attribute. Also, there are some apps, like news, where the licensing information says , which requires clarification. This needs to be fixed.
Thank you for opening the draft PR in order to fix my mistakes and broken packages. I'm sorry for the bad communication and the inability to resolve this serious issue. Fixing this for Wordpress packages and themes (wp4nix) and Nextcloud apps (nc4nix) in a foreseeable time exceeds my skills and competence. Therefore I would like to offer to add a flag to these package sets and remove them for the next release 23.11 if it's not resolved by then.
Change:
ldflags = [ "-s" <del> "-w" </del> "-X github.com/solo-io/gloo/pkg/version.Version=${version}" ]; <ins> preCheck = '' export HOME=$TMPDIR ''; </ins> postInstall = '' mv $out/bin/cmd $out/bin/glooctl installShellCompletion --cmd glooctl 

Discussion:
Steps to reproduce the behavior: on nixpkgs (nixos-unstable) or (staging-next) none (they last updated 1.16.16 -1.16.17) Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Also it would be great if it was updated to 1.17.x, but that warrants a separate issue
(sorry didnt ping you in the original i didnt look so far :(
I'm just back from a trip; I'll take a look in the next 24 hours