jiebi/CodeConvo huggingface dataset:
Change:
''; }); <ins> # check that the vim-doc hook correctly generates the tag # for neovim packages from luaPackages # we know for a fact gitsigns-nvim has a doc folder and comes from luaPackages checkForTagsLuaPackages = vimPlugins.gitsigns-nvim.overrideAttrs(oldAttrs: { doInstallCheck = true; installCheckPhase = '' [ -f $out/doc/tags ] ''; }); nvim_with_gitsigns_plugin = neovim.override { extraName = "-with-gitsigns-plugin"; configure.packages.plugins = { start = [ vimPlugins.gitsigns-nvim ]; }; }; checkHelpLuaPackages = runTest nvim_with_gitsigns_plugin '' export HOME=$TMPDIR ${nvim_with_gitsigns_plugin}/bin/nvim -i NONE -c 'help gitsigns' +quitall! -e ''; </ins> # nixpkgs should detect that no wrapping is necessary nvimShouldntWrap = wrapNeovim2 "-should-not-wrap" nvimAutoDisableWrap;

Discussion:
When Neovim and associated vim plugins are installed, the help docs for some of the plugins is missing Steps to reproduce the behavior: Neovim and plugins Neovim and try to pull up help for the listed plugins. Help is missing when trying to pull them up using for these plugins Help is available for all the plugins. If applicable, add screenshots to help explain your problem. I have verified that the plugins are loaded using command Please run and paste the result.
I think this is an issue specific to neovim plugins from luarocks-packages, cc
doc is generated via the maybe it's missing from the close (should be though) or it doesn't work as expected. Feel free to have a look, else I will have a look when I've time. I've noticed it too. Note to myself: vim plugins depend on vim and neovim because of so maybe we should address that too
and do not have documentation, so there is no issue there. However, should have it, but it doesn't. I looked at other plugins using luarocks packages and noticed that there are 3 that are missing in their rockspec: However, this does not fully solve the issue since on the side the documentation tags are still missing. For instance, has a correct rockspec which includes the folder, but the documentation tags are still not generated: The relevant error is here: It seems that looks for $out/doc, but at the moment it is run in a luarocks plugin, the structure is as follows: Seems that should happen before but the former is in and the latter is in . Alternatively, looking at , maybe we could override the substitution so that it points to inside the rocks.
Change:
{ stdenv, fetchurl, pkgconfig, yasm <del> , freetype, fribidi </del> <ins> , freetype, fribidi, harfbuzz </ins> , encaSupport ? true, enca ? null # enca support , fontconfigSupport ? true, fontconfig ? null # fontconfig support <del> , harfbuzzSupport ? true, harfbuzz ? null # harfbuzz support </del> , rasterizerSupport ? false # Internal rasterizer , largeTilesSupport ? false # Use larger tiles in the rasterizer , libiconv

Discussion:
, CVSSv3=8.8 (nixos-20.03, nixos-20.09, nixos-unstable) Scanned versions: nixos-20.03: ; nixos-20.09: ; nixos-unstable: . Cc
Change:
{ lib , stdenv , fetchFromGitHub <ins> , fetchpatch </ins> , installShellFiles , makeWrapper , pkg-config

Discussion:
nnn includes a , but this is not currently included. nnn supports building with , but this is not supported. Nerdfonts has been recently updated to 3.0, this partially broke the icons in nnn. A fix is already , this should be backported. It would be nice to have all of this --
Change:
<del> { stdenv, fetchurl, python, cairomm, sparsehash, pycairo, autoreconfHook, pkgconfig, boost, expat, scipy, cgal, gmp, mpfr, gobject-introspection, pygobject3, gtk3, matplotlib, ncurses, buildPythonPackage }: </del> <ins> { stdenv, fetchurl, python, cairomm, sparsehash, pycairo, autoreconfHook , pkgconfig, boost, expat, scipy, cgal, gmp, mpfr , gobject-introspection, pygobject3, gtk3, matplotlib, ncurses , buildPythonPackage , fetchpatch }: </ins> buildPythonPackage rec { pname = "graph-tool";

Discussion:
I fail to compile graph-tool on nixos-unstable. The error message is a template one, thus cc
This is caused by
Fixed upstream:
thanks !
Change:
}; adapter = mkOption { <del> default = if (builtins.baseNameOf cfg.configFile) == "Caddyfile" then "caddyfile" else null; </del> <ins> default = if ((cfg.configFile != configFile) || (builtins.baseNameOf cfg.configFile) == "Caddyfile") then "caddyfile" else null; </ins> defaultText = literalExpression '' <del> if (builtins.baseNameOf cfg.configFile) == "Caddyfile" then "caddyfile" else null </del> <ins> if ((cfg.configFile != configFile) || (builtins.baseNameOf cfg.configFile) == "Caddyfile") then "caddyfile" else null </ins> ''; example = literalExpression "nginx"; type = with types; nullOr str;

Discussion:
I wanted to configure caddy with my own config file, setting as documented in the option. Steps to reproduce the behavior: above snippet how caddy does not start, as does not exist. at the filesystem, observe there's a directory with a inside, while sets Possibly introduced in Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Looks like a regression to me. Will investigate further. Thanks for your report and the commit you suggested that might have introduced it :)
I don't think it's that commit. Can you try ?
I am pretty sure this documentation error has been introduced all the way back in . The option docs simply switched from to , but forgot to wrap add a at the end. And now we are somewhat stuck with behavior that expects it that way... sigh.
I think this in combination with introduced the breaking change, since we now always pass as the arg, but expect a basename of to enable the adapter.
It works if you do as demonstrated here: But it's ugly.
Alternatively do and explicitly set .
I tried with too, it doesn't work. I extended with an example (at least I think I did), and it fails. It's pushed to , if someone does a PR fixing the issue feel free to cherry-pick it in ;-)
With you also need to explicitly set .
Fixed it in (when using )
Can you also fix the writeTextDir case? That's what the documentation recommends to use...
I adjusted the documentation to use (which it used to be before )
I could also instead fix the case, if you have strong opinions, but this was a bit easier.
I think fixing the writeTextDir case makes more sense. That's what people might have in their configs, and getting everyone to notice they now need to write it like this, and update configs is worse UX than fixing the usage that was documented. Assuming it worked with 23.05 for example, but regressed with 23.11 again. That is, if this ever worked like this before. If it was broken all the time, no one could have a working config so it doesn't matter much :laughing:
Both and (without ) have been broken since , which landed in .
Ok, in that case, it's been broken for an entire release, so this is not just a regression when upgrading to 23.11. then it's probably ok.
Change:
, alsa-lib , wayland , libpulseaudio <ins> , gobject-introspection </ins> }: let

Discussion:
can not able to install mod and modpack from local file Steps to reproduce the behavior: Instances a modpack from local file error message: my desktop environment is plasma5(X11) <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
, ... } @ args: let <del> version = "6.1.46-rt14"; # updated by ./update-rt.sh </del> <ins> version = "6.1.54-rt15"; # updated by ./update-rt.sh </ins> branch = lib.versions.majorMinor version; kversion = builtins.elemAt (lib.splitString "-" version) 0; in buildLinux (args // {

Discussion:
Mounting NFS volumes stopped working without configuration change other than updates. Steps to reproduce the behavior: updated system as of 2023-09-18 from stable to mount a nfs volume Get the error The volume to be mounted Please run and paste the result.
I am having the same issue, with very similar messages: I am running: It happened between ..., the only suspicious changes are kernel changes. In particular, both 6.5.2-6.5.3 and 6.1.52-6.1.53 include the patch "vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing" which I think seems suspicious, but I don't know enough to dig any further. Any help would be appreciated.
Gentoo . In that bug, someone bisected the kernel and identified the patch that mentioned as the culprit. This link to a kernel patch that fixes the issue was also posted and verified to work:
I hit this as well, hoping it gets fixed promptly. For now I've worked around it by using an older stable kernel on affected clients:
I am guessing it will be fixed in upstream soonish, will it be fixed in NixOS like the gentoo folks did? For now, I have confirmed the above patch works on my configuration: nevivurn/nixos-config
The patch worked for me, didn't know it was that easy to apply one
cc
This patch works great! This issue still appears in , but the patch still seems to works if applied to that version.
Change:
''; postPatch = '' <del> substituteInPlace oldanki/lang.py --subst-var-by anki $out substituteInPlace anki/lang.py --subst-var-by anki $out </del> # Remove unused starter. We'll create our own, minimalistic, # starter. <del> rm anki/anki </del> <ins> # rm anki/anki </ins> # Remove QT translation files. We'll use the standard QT ones. rm "locale/"*.qm

Discussion:
With the current packaged version of Anki, downloading addons fails with an SSLCERTIFICATEVERIFYFAILED. Download any addon from the Ankiweb library. I used , but any addon causes the issue. Go to to enter the ID. Then this error shows up in a dialog box: Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
The update to anki 2.1 () will close this issue, according to my testing. (Add-on downloads work perfectly.)
(oops, I'll keep it open until that PR is merged)
Given that some useful addons don't support Anki 2.1, I'd like this to be fixed for 2.0. OTOH I'm not sure how this can be done.
You can still manually install addons by dropping the files in . An example is described .
Change:
exec = "jadx-gui"; icon = "jadx"; comment = finalAttrs.meta.description; <del> categories = [ "Development" "Utility" ]; </del> <ins> categories = [ "Development" "Utility" ]; </ins> }) ];

Discussion:
Package name: jadx Latest released version: 1.5.0 Current version on the unstable channel: 1.4.7 Current version on the stable/release channel: 1.4.7 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers affects 1.4.7 - I would generally bump this myself but the packaging appears to have quirks that look like they need adaptation. Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<del> { stdenv, fetchurl, steam-run, bash </del> <ins> { stdenv, fetchurl, steam-run, bash, coreutils </ins> , steamRoot ? "~/.local/share/Steam" }:

Discussion:
I tried to create a Docker file using Nix which, in its , just calls . This fails because contains , which, apparently, isn't put into the Docker image. system: host os: multi-user?: sandbox: version: channels(philipp): channels(root): nixpkgs:
Change:
src = ./src; <del> cargoLock.lockFile = ./src/Cargo.lock; </del> <ins> cargoLock = { lockFile = ./src/Cargo.lock; outputHashes."rust-ini-0.21.1" = "sha256-0nSBhme/g+mVsYdiq0Ash0ek9WEdvbf/b9FRxA7sauk="; }; </ins> nativeBuildInputs = [ pkg-config ]; buildInputs = [ dbus ];

Discussion:
See title. It also may fail to correctly parse comments within such blocks as well, but unsure. a systemd unit in config e.g. to switch configuration (though this might only happen on the second switch, trying to parse existing config?) with Per , this is valid syntax: The value of should thus be parsed to (I may have gotten the spaces wrong there) If applicable, add screenshots to help explain your problem. Patch for failing example test case (may not be perfect): also due to authoring Please run and paste the result. I was running dry-activate to a config using nixpkgs @ Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
thanks for the report! I've looked a little into this so far and switch-to-configuration doesn't actually use that much of the unit file contents, which could be fine considering that systemd's DBus interface exposes almost all of their unit properties as DBus properties. However, since NixOS uses some custom unit properties (think ), these aren't exposed as DBus properties. So instead I've gone the route of adding support for multi-line values in the INI parser used for switch-to-configuration-ng, with the eventual goal of upstreaming this support to that crate. This isn't going to be something that's immediately ready though, I should have a PR for review within the coming days. For now, I would recommend opting out of the switch-to-configuration-ng implementation with the following config until it's fixed:
The problem with INI in general is that there is no standard. The systemd syntax, after all, “is inspired by XDG Desktop Entry Specification .desktop files, which are in turn inspired by Microsoft Windows .ini files”.
Change:
rustPlatform.buildRustPackage rec { pname = "swayws"; <del> version = "unstable-2022-03-10"; </del> <ins> version = "1.2.0"; </ins> src = fetchFromGitLab { owner = "w0lff"; repo = pname; <del> rev = "514f3c664439cf2c11bb9096c7e1d3b8c0b898a2"; sha256 = "sha256-vUnbn79v08riYLMBI8BxeBPpe/pHOWlraG7QAaohw3s="; </del> <ins> rev = "v${version}"; sha256 = "sha256-f0kXy7/31imgHHqKPmW9K+QrLqroaPaXwlJkzOoezRU="; </ins> }; <del> cargoSha256 = "sha256-PvKpcTewajvbzUHPssBahWVcAQB3V/aMmOJ/wA0Nrv4="; </del> <ins> cargoSha256 = "sha256-VYT6wV59fraAoJgR/i6GlO8s7LUoehGtxPAggEL1eLo="; # Required patch until upstream fixes https://gitlab.com/w0lff/swayws/-/issues/1 cargoPatches = [ ./ws-update-Cargo-lock.patch ]; </ins> # swayws does not have any tests doCheck = false;

Discussion:
Package name: swayws Latest released version: 1.2.0 <!-- Search your package here: --- Current version on the unstable channel: 2022-03-10 Current version on the stable/release channel: 2022-03-10 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Change:
nativeBuildInputs = [ jekyll cmake ]; buildInputs = [ gtest ]; <del> cmakeFlags = ["-DBUILD_STATIC_LIBS=ON" "-DUSE_SYSTEM_GTEST=ON" ]; </del> <ins> cmakeFlags = [ "-DUSE_SYSTEM_GTEST=ON" "-DBUILD_STATIC_LIBS=${if stdenv.hostPlatform.isStatic then "ON" else "OFF"}" "-DBUILD_SHARED_BINARIES=${if stdenv.hostPlatform.isStatic then "OFF" else "ON"}" ]; # https://github.com/google/jsonnet/issues/778 patches = [ ./fix-cpp-unresolved-symbols.patch ]; </ins> enableParallelBuilding = true;

Discussion:
I cannot install on my Apple M1 PowerBook any more (potentially due to ?) I'm tracking (commit ) Steps to reproduce the behavior: Here's the output of
I'm afraid I don't have a Mac around to test with, but from glancing at the build log it appears the problem may go away if you remove from in the jsonnet derivation, or make it conditional on stdenv.hostPlatform.isStatic as suggested in .
I can confirm this issue. We worked around this in our own overlay by reverting to the last known (to us) NixPkgs version for the Jsonnet package only (i.e. we overlayed the derivation with one that is basically . No idea what exactly causes the problem, though.
didn't fix this, I still can't build jsonnet on Darwin.
This is fixed in , PTAL.
Change:
# Make a crude approximation of the size of the target image. # If the script starts failing, increase the fudge factors here. numInodes=$(find ./rootImage | wc -l) <del> numDataBlocks=$(du -s -c -B 4096 --apparent-size ./rootImage | tail -1 | awk '{ print int($1 * 1.10) }') </del> <ins> numDataBlocks=$(du -s -c -B 4096 --apparent-size ./rootImage | tail -1 | awk '{ print int($1 * 1.20) }') </ins> bytes=$((2 * 4096 * $numInodes + 4096 * $numDataBlocks)) echo "Creating an EXT4 image of $bytes bytes (numInodes=$numInodes, numDataBlocks=$numDataBlocks)" <ins> mebibyte=$(( 1024 * 1024 )) # Round up to the nearest mebibyte. # This ensures whole 512 bytes sector sizes in the disk image # and helps towards aligning partitions optimally. if (( bytes % mebibyte )); then bytes=$(( ( bytes / mebibyte + 1) * mebibyte )) fi </ins> truncate -s $bytes $img faketime -f "1970-01-01 00:00:01" fakeroot mkfs.ext4 -L ${volumeLabel} -U ${uuid} -d ./rootImage $img

Discussion:
Steps to reproduce the behavior: Cross compile for Microchip Icicle Kit() from machine. Make sure is enable for architecture. Root fs size is more than the disk image size. See file snippet 10% extra space may not be enough in some cases. In my case, apparent size of rootfs is data blocks, while it's size on disk is data blocks. so 10% extra space may not be enough in some cases. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
<del> { stdenv, fetchFromGitHub, fetchurl, makeDesktopItem, pkgconfig, cmake, python3 </del> <ins> { stdenv, fetchFromGitHub, fetchurl, pkgconfig, cmake, python3 </ins> , libX11, libXrandr, qtbase, qtwebchannel, qtwebengine, qtx11extras , libvdpau, SDL2, mpv, libGL }: let

Discussion:
This is pretty confusing: ! Install and try to launch it from your DE. Which icon do you click on? They both do the same thing anyway. system: host os: multi-user?: sandbox: version: channels(root): channels(stanislas): nixpkgs:
I can reproduce this issue. I think it is caused by this line Would need to have more of a look but at least one of the desktop items is coming from this line and removing it would likely solve the problem
Thanks! I submitted a PR to remove the custom desktop file.
Change:
godot-headless = throw "godot-headless has been renamed to godot3-headless to distinguish from version 4"; # Added 2023-07-16 godot-server = throw "godot-server has been renamed to godot3-server to distinguish from version 4"; # Added 2023-07-16 <ins> google-chrome-beta = throw "'google-chrome-beta' has been removed due to the lack of maintenance in nixpkgs. Consider using 'google-chrome' instead."; # Added 2023-10-18 google-chrome-dev = throw "'google-chrome-dev' has been removed due to the lack of maintenance in nixpkgs. Consider using 'google-chrome' instead."; # Added 2023-10-18 </ins> google-gflags = throw "'google-gflags' has been renamed to/replaced by 'gflags'"; # Converted to throw 2023-09-10 go-thumbnailer = thud; # Added 2023-09-21 gometer = throw "gometer has been removed from nixpkgs because goLance stopped offering Linux support"; # Added 2023-02-10

Discussion:
Package name: google-chrome Latest released version: 116.0.5845.187 Current version on the unstable channel: 116.0.5845.179 Current version on the stable/release channel: 116.0.5845.179 Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Please note a new version of Chrome is now available to address an exploited-in-the-wild zero-day vulnerability in the WebP image parsing code in the Chrome browser. This vulnerability could allow arbitrary code execution when a specially crafted image is viewed. Please update as soon as possible. For more information on the vulnerability, tracked as CVE-2023-4863, refer to this disclosure from Google: Note for maintainers: Please tag this issue in your PR.
I'm seeing on both 23.05 and unstable. Per chromium/google-chrome was one of the first things that was patched.
Those versions are released on both channels but on stable updates for google-chrome-dev and google-chrome-beta are missing
Change:
{ lib , stdenv , fetchFromGitHub <ins> , fetchpatch </ins> , cmake , perl , pkg-config

Discussion:
Describe the bug texlive core big bin builds failed on macOS. It seems failed after zziplib updated to 0.13.72. Full log: To Reproduce Steps to reproduce the behavior: Metadata system: host os: multi-user?: sandbox: version: channels(Nasy): nixpkgs:
Regression from (had to workaround this one before )
Upstream fix gdraheim/zziplib
Change:
<ins> { lib , stdenv , fetchFromGitHub , qtbase , qmake , wrapQtAppsHook , copyDesktopItems , makeDesktopItem }: stdenv.mkDerivation rec { pname = "cubiomes-viewer"; version = "1.12.1"; src = fetchFromGitHub { owner = "Cubitect"; repo = pname; rev = version; sha256 = "sha256-F0c6gMQKu35iBNRw+wpoxSUOhRUbPRKIXSNDDNZsfPE="; fetchSubmodules = true; }; buildInputs = [ qtbase ]; nativeBuildInputs = [ qmake wrapQtAppsHook copyDesktopItems ]; desktopItems = [ (makeDesktopItem { name = pname; desktopName = "Cubiomes Viewer"; exec = pname; icon = pname; categories = "Game"; comment = meta.description; }) ]; preBuild = '' # QMAKE_PRE_LINK is not executed (I dont know why) make -C ./cubiomes libcubiomes CFLAGS="-DSTRUCT_CONFIG_OVERRIDE=1" all ''; installPhase = '' runHook preInstall mkdir -p $out/bin cp cubiomes-viewer $out/bin mkdir -p $out/share/pixmaps cp icons/map.png $out/share/pixmaps/cubiomes-viewer.png runHook postInstall ''; meta = with lib; { homepage = "https://github.com/Cubitect/cubiomes-viewer"; description = "A graphical Minecraft seed finder and map viewer"; longDescription = '' Cubiomes Viewer provides a graphical interface for the efficient and flexible seed-finding utilities provided by cubiomes and a map viewer for the Minecraft biomes and structure generation. ''; platforms = platforms.all; license = licenses.gpl3Plus; maintainers = with maintainers; [ hqurve ]; }; } </ins>

Discussion:
Project description Cubiomes Viewer provides a graphical interface for the efficient and flexible seed-finding utilities provided by cubiomes and a map viewer for the Minecraft biomes and structure generation. The tool is designed for high performance and supports Minecraft Java Edition main releases 1.0 - 1.18. Metadata what does this mean? homepage URL: source URL: license: GPL-3.0 platforms: Linux
Change:
map (dep: { name = "${dep.pname}/${dep.pname}-${dep.version}.zip"; path = dep.src; <del> }) lockedDeps </del> <ins> }) dubDeps </ins> ); combinedFlags = "--skip-registry=all --compiler=${lib.getExe compiler} ${toString dubFlags}";

Discussion:
fails to build a lockfile with dependencies in the format (). Here's the error: any repository whose contains a dependency that fetches from Git, e.g. , e.g. . a few moments, then see error. A generated lockfile containing the Git dependency. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thanks for reporting this bug, I'll try to extend the lockfile logic later today, (the current one is pretty primitive, as you might have seen)