jiebi/CodeConvo huggingface dataset:
Change:
owner = "gethomepage"; repo = "homepage"; rev = "v${version}"; <del> hash = "sha256-EgZhk3NtuIjvFab0y9UdGYDR+Iw/0vg/uFxnzqKuloo="; </del> <ins> hash = "sha256-K1brnHA4e8lHIXwpajdY6f+3/pgP8My4QznoYLmZNWw="; </ins> }; npmDepsHash = "sha256-jYZUVwrOxoAbfHHSBkN5IlYhC6yZVVwRoZErkbYrjUs=";

Discussion:
Steps to reproduce the behavior: homepage-dashboard Apparently this is a hash mismatch... <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. I'm running nixos-unstable-small in a flake... also, from this commit: Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
That's weird. Seems like either someone has attacked r-ryantm or upstream has amended to the same release tag.
Hmm, I think the upstream have messed with the original tag. I'll get a PR together.
Thanks for the quick response guys! at least homepage isn't as critical as xz was, and is nice to see that nix can provide a way to catch this issues...
Change:
{ callPackage, ... } @ args: <del> callPackage ./generic.nix (args // { </del> <ins> callPackage ./generic.nix (args // rec { </ins> brand = "Midas"; type = "M32"; <del> version = "3.2"; sha256 = "1cds6qinz37086l6pmmgrzrxadygjr2z96sjjyznnai2wz4z2nrd"; homepage = "http://www.musictri.be/Categories/Midas/Mixers/Digital/M32/p/P0B3I/downloads"; </del> <ins> version = "4.1"; url = "https://mediadl.musictribe.com/download/software/midas_${type}/${type}-Edit_LINUX_64-Bit_${version}.tar.gz"; sha256 = "0aqhdrxqa49liyvbbw5x32kwk0h1spzvmizmdxklrfs64vvr9bvh"; homepage = "https://midasconsoles.com/midas/product?modelCode=P0B3I"; </ins> })

Discussion:
Describe the bug A clear and concise description of what the bug is. Tracking issue for srcs that can no longer be built with . Having these around isn't critical but it creates dependence on and it is not certain that it will keep around all srcs it once fetched.
While reviewing I found a few:
Thanks for the heads-up I found a fix for x32-edit and m32-edit and I'll do a PR for them asap. (ie when I have a clean git state in my $NIXPKGS dir) For hybridreverb2 I did not find the exact cause of problem though. ` complains: When I look into the , there is a pointer to , but I don't understand why nix-env tries to download a non-existing reference. I looked in various places for the 78ae... string, but didn't find it: nixpkgs, hybridreverb2, JUCE. Any pointers on why it tries to download this specific version of JUCE? PS: At first I thought it was an upstream problem, that had occured before, so I commented on a, what I thought to be relevant, , but a regular git clone works just fine:
The broken hash comes from HybridReverb2 repo: Looks like they use their own JUCE fork and force pushed so the commit used by HR 2.1.1 has been garbage collected on GitHub.
Thanks, I've passed the info upstream, hoping they will fix the issue.
I marked this as stale due to inactivity. &rarr;
Change:
inherit go-tiny-dream go-rwkv go-bert go-llama gpt4all go-piper llama-cpp-grpc whisper-cpp go-tiny-dream-ncnn espeak-ng' piper-phonemize <del> piper-tts'; </del> <ins> piper-tts' llama-cpp-rpc; </ins> }; passthru.features = {

Discussion:
Package name: local-ai Latest released version: 2.16.0 <!-- Search your package here: --- Current version on the unstable channel: Current version on the stable/release channel: <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- On nixos-unstable, I currently have with so I thought I would try an update even though it's probably going to change nothing. Notify maintainers I was wondering if you had a script to update pkgs/by-name/lo/local- ? I've started doing it manually but it's annoying. Might be worth adding one, would you accept one ? Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
'' + lib.optionalString stdenv.hostPlatform.isCygwin '' sed -i -e "s/(cldr_plurals_LDADD = )/1../gnulib-lib/libxml_rpl.la /" gettext-tools/src/Makefile.in sed -i -e "s/(libgettextsrc_la_LDFLAGS = )/1../gnulib-lib/libxml_rpl.la /" gettext-tools/src/Makefile.in <ins> '' + lib.optionalString stdenv.hostPlatform.isMinGW '' sed -i "s/@GNULIB_CLOSE@/1/" */*/unistd.in.h </ins> ''; strictDeps = true;

Discussion:
mingw32 build support for gettext is broken. There are conditionals within the gettext derivation that leads me to believe that mingw32 builds should be working. Steps to reproduce the behavior: The package to be built with not error If applicable, add screenshots to help explain your problem. Here is the error that I get Looks like the changes for one of the patches was upstreamed. If I remove the patch (this is okay because it is now in the source code), I will get the following error. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Change:
rhdf5= old.rhdf5.overrideAttrs (attrs: { patches = [ ./patches/rhdf5.patch ]; }); <ins> textshaping = old.textshaping.overrideAttrs (attrs: { env.NIX_LDFLAGS = "-lfribidi -lharfbuzz"; }); </ins> }; in self

Discussion:
rPackages.textshaping fails to build on aarch64-darwin systems. Consequently, tidyverse won't build I tried adding fribidi to the buildInputs, but it wasn't enough.
Fribidi is already an input: Seems to work fine on aarch64 linux, and other fribidi packages work fine on darwin, so I don't see anything obvious. I don't have a mac sadly so hard to work on this.
Change:
with lib; let <ins> /** * Given a list of `options`, concats the result of mapping each options * to a menuentry for use in grub. * *  * defaults: {name, image, params, initrd} *  * options: [ option... ] *  * option: {name, params, class} */ menuBuilderGrub2 = defaults: options: lib.concatStrings ( map (option: '' menuentry '${defaults.name} ${ # Name appended to menuentry defaults to params if no specific name given. option.name or (if option ? params then "(${option.params})" else "") }' ${if option ? class then " --class ${option.class}" else ""} { linux ${defaults.image} ${defaults.params} ${ option.params or "" } initrd ${defaults.initrd} } '') options ) ; /** * Given a `config`, builds the default options. */ buildMenuGrub2 = config: buildMenuAdditionalParamsGrub2 config "" ; /** * Given a `config` and params to add to `params`, build a set of default options. * Use this one when creating a variant (e.g. hidpi) */ buildMenuAdditionalParamsGrub2 = config: additional: let finalCfg = { name = "NixOS ${config.system.nixos.label}${config.isoImage.appendToMenuLabel}"; params = "init=${config.system.build.toplevel}/init ${additional} ${toString config.boot.kernelParams}"; image = "/boot/bzImage"; initrd = "/boot/initrd"; }; in menuBuilderGrub2 finalCfg [ { class = "installer"; } { class = "nomodeset"; params = "nomodeset"; } { class = "copytoram"; params = "copytoram"; } { class = "debug";     params = "debug"; } ] ; </ins> # Timeout in syslinux is in units of 1/10 of a second. # 0 is used to disable timeouts. syslinuxTimeout = if config.boot.loader.timeout == null then

Discussion:
It points at this: ! I'm not sure anyone's made updated splash images with the new logo, but it'd be good to standardize.
Basically an instance of
Oh, true. Unsure whether to leave this open as a concrete thing that can be fixed, since isn't very specific about what's left to be fixed. Or just to close it and add more detail there?
Best to fix it immediately ;-)
That is actually the ISOLINUX background only. There's a separate on for GRUB:
Change:
<ins> { lib , rustPlatform , fetchFromGitHub }: rustPlatform.buildRustPackage rec { pname = "ripsecrets"; version = "0.1.6"; src = fetchFromGitHub { owner = "sirwart"; repo = "ripsecrets"; rev = "v${version}"; hash = "sha256-p3421sQko/WulSNUxXpjsHPAtRoHHg61angfxJpoyFg="; }; cargoHash = "sha256-DJkEhqW5DZOmoNiS4nw+i2G0+KN2d7FbBuKp7fdAwMk="; meta = with lib; { description = "A command-line tool to prevent committing secret keys into your source code"; homepage = "https://github.com/sirwart/ripsecrets"; changelog = "https://github.com/sirwart/ripsecrets/blob/${src.rev}/CHANGELOG.md"; license = licenses.mit; maintainers = with maintainers; [ figsoda ]; mainProgram = "ripsecrets"; }; } </ins>

Discussion:
Project description A command-line tool to prevent committing secret keys into your source code. It has a few features that distinguish it from other secret scanning tools. Metadata homepage URL: source URL: license: mit platforms: linux, darwin
Change:
qtdatavis3d = callPackage ./modules/qtdatavis3d.nix { }; qtdeclarative = callPackage ./modules/qtdeclarative.nix { }; qtdoc = callPackage ./modules/qtdoc.nix { }; <del> qtgrpc = callPackage ./modules/qtgrpc.nix { }; </del> <ins> qtgrpc = callPackage ./modules/qtgrpc.nix { patches = [ (fetchpatch2 { # fix compatibility with protobuf 23 url = "https://gitlab.archlinux.org/archlinux/packaging/packages/qt6-grpc/-/raw/d6b33bd915dc6e63b30db2cd29150d55b289d7ed/protobuf-23.patch"; hash = "sha256-KQAcrjQ3rK9pDQUOUK6AS4ej8YvtRv9WZOxby31Y5r4="; }) ]; }; </ins> qthttpserver = callPackage ./modules/qthttpserver.nix { }; qtimageformats = callPackage ./modules/qtimageformats.nix { }; qtlanguageserver = callPackage ./modules/qtlanguageserver.nix { };

Discussion:
Steps to reproduce the behavior: on nixos-unstable channel Add any other context about the problem here.
Change:
ln -s $dir $out/share/ fi done <del> ln -s ${unwrapped}/lib $out/lib </del> for f in $out/share/applications/*.desktop; do substituteInPlace "$f"  --replace "Exec=libreoffice${major}.${minor}" "Exec=soffice" done <ins> mkdir -p $out/bin mkdir -p $out/lib/libreoffice/program lndir -silent ${unwrapped}/lib/libreoffice/program $out/lib/libreoffice/program </ins> for i in sbase scalc sdraw smath swriter simpress soffice unopkg; do <del> makeWrapper ${unwrapped}/lib/libreoffice/program/$i $out/bin/$i ${makeWrapperArgs} </del> <ins> # Delete the symlink created by lndir, and replace it by our wrapper rm $out/lib/libreoffice/program/$i makeWrapper  ${unwrapped}/lib/libreoffice/program/$i  $out/lib/libreoffice/program/$i  ${makeWrapperArgs} </ins> '' + lib.optionalString dbusVerify '' # Delete the dbus socket directory after libreoffice quits <del> sed -i 's/^exec -a "$0" //g' $out/bin/"$i" echo 'code="$?"' >> $out/bin/$i echo 'test -n "$dbus_socket_dir" && { rm -rf "$dbus_socket_dir"; kill $dbus_pid; }' >> $out/bin/$i echo 'exit "$code"' >> $out/bin/$i </del> <ins> sed -i 's/^exec -a "$0" //g' $out/lib/libreoffice/program/$i echo 'code="$?"' >> $out/lib/libreoffice/program/$i echo 'test -n "$dbus_socket_dir" && { rm -rf "$dbus_socket_dir"; kill $dbus_pid; }' >> $out/lib/libreoffice/program/$i echo 'exit "$code"' >> $out/lib/libreoffice/program/$i </ins> '' + '' <ins> ln -s $out/lib/libreoffice/program/$i $out/bin/$i </ins> done <ins> # A symlink many users rely upon ln -s $out/bin/soffice $out/bin/libreoffice </ins> '')

Discussion:
i can no longer use libreoffice headlessly i suspect this is due to the rewrite of the wrapper additionally, the binary is no longer provided, only etc, which are supposed to be usable headlessly too and maybe more impactful, attempting to launch the GUI with doesn't work either Steps to reproduce the behavior: -, -for a known working .odt file or project using the headless feature, see (already amended to attempt to use instead of ) to open libreoffice with the appropriate sub-app with that file open to open libreoffice writer with that file open to yield to yield error window on ! due to , the wrapper rewrite which seems to have introduced this issue
Aish... didn't realize this usage would break when I the flag to ... As a workaround, you can run the unwrapped executables in the meantime, this should work (works for me): I'm a bit confused though, which revision are you evaluating exactly? which is used in your report is before the wrapper rewrite.
I don't experience other issues you mention on current branch .
oh right, i had this issue on up-to-date yesterday on my laptop i filed the issue on my desktop
i'm unclear about what issues you don't experience on current on the branch, there's no
My bad :sweat_smile: My wasn't updated at all! Adding won't be that hard, but fixing the issue is harder...
Change:
# TODO Patch this somehow; tries to dlopen './libturbojpeg.so' from cwd ln -s $(readlink -e "${libjpeg_turbo.out}/lib/libturbojpeg.so") $packagePath/libturbojpeg.so <ins> ln -s ${qtEnv}/bin/qt.conf $packagePath </ins> makeWrapper $packagePath/zoom $out/bin/zoom-us  <del> --prefix PATH : "${makeBinPath [ pciutils procps ]}"  --set QSG_INFO 1  --set QT_QPA_PLATFORM_PLUGIN_PATH ${qtbase.bin}/lib/qt-${qtbase.qtCompatVersion}/plugins/platforms  --set QT_PLUGIN_PATH ${qtbase.bin}/${qtbase.qtPluginPrefix}:${qtimageformats}/${qtbase.qtPluginPrefix}  </del> <ins> --prefix PATH : "${makeBinPath [ coreutils glib.dev pciutils procps qttools.dev utillinux ]}"  </ins> --run "cd $packagePath" runHook postInstall

Discussion:
Zoom GUI is not shown on current master () This started to happen after package refactoring (, , ), and not due to package upgrade (I've checked that). I've documented some findings already ping and other Zoom users. Am I alone with this issue? At this moment no GUI (no greeting window) is shown. system: host os: multi-user?: sandbox: version: channels(root): channels(danbst): nixpkgs:
I at least cannot reproduce this with on nixpkgs
I installed to a profile using your reproduction steps, and it works fine here. What is in your in your shell? At least here it's:
I was able to reproduce this via: So there's some piece of the environment missing in the package.
This also reproduces the issue: Currently investigating what needs on the $PATH.
Thanks for your efforts, but when writing a command can you (and everyone else) please be complete? I had time to quickly confirm what you wanted to say, but here I am telling you that it is not a valid test case. I wrote an example of a complete command in closed thread with zoom in the title started by myself, so it's not like I don't practice this myself.
Sorry about that. As the package is unfree, you'll need in or in your environment. So a complete standalone test case would be:
does this reproduce issue too? I've checked that commit (last revision of old zoom-us expression) launches fine for me with this bash command.
It sounds like it was caused by using autoPatchelf? It could be that there is some incompatibility between what zoom-us is built with and what we have locally. Maybe we should just revert that part (but leave the version updates). I would much prefer to use Nixpkgs Qt here but there is a lot of unknown in how zoom-us is built. It might just be safest to revert to the old expression.
Turns out the issue was missing QML2 imports. This was discovered by comparing: to and looking for libraries loaded by the latter but not the former. One fix was to add a environment variable to the wrapper, but I found it simpler to re-use to build an environment with all the Qt dependencies symlinked in place and using its . The package should be easier to maintain as a result since you don't have to know what feature each qt5 package is meant to provide.
Change:
karchive kconfig kcrash kdbusaddons kdeclarative kio kirigami2 kitemmodels knewstuff kwindowsystem kxmlgui plasma-framework ]; <ins> meta.knownVulnerabilities = [ "https://kde.org/info/security/advisory-20210310-1.txt" ]; </ins> }

Discussion:
, CVSSv3=7.5 (nixos-20.09) Scanned versions: nixos-20.09: . Cc Cc
Change:
''; dmDefault = cfg.desktopManager.default; <ins> # fallback default for cases when only default wm is set dmFallbackDefault = if dmDefault != null then dmDefault else "none"; </ins> wmDefault = cfg.windowManager.default; <del> defaultSessionFromLegacyOptions = concatStringsSep "+" (filter (s: s != null) ([ dmDefault ] ++ optional (wmDefault != "none") wmDefault)); </del> <ins> defaultSessionFromLegacyOptions = dmFallbackDefault + optionalString (wmDefault != null && wmDefault != "none") "+${wmDefault}"; </ins> in

Discussion:
Describe the bug I have a NixOS installation with a very simple xserver configuration: When trying to rebuild with master I get an error: To Reproduce Steps to reproduce the behavior: my lines from the above Expected behavior The old configuration should continue to work unless I opt into Metadata Please run and paste the result. Maintainer information: This has to do with cc
Right, looks like there's a bug when constructing the legacy the session name from the legacy defaults. Specifically when only supplying a default for the window manager. Will fix.
IMHO, is only meant for mutable state like database schemata, that does not offer downgrade/rollback path. Abusing it for versioning option tree only adds complexity for little benefit, especially when we already employ other transition aids. Nevertheless, this was an oversight on my part. Something like this might fix it:
What is the proper way to update my configuration to the new system? Where should I look for that information? Are there release notes? I couldn't figure it out from
Yes, release notes are included in the pull request: Also the module system should give you upgrade instruction when we fix the oversight. Could you test the patch above?
Your patch fixes the issue for me.
Closing since this is fixed.
We still need to apply the patch to the nixpkgs.
Oops, thought this was
Yeah, I just looked up that one, but it actually predates me filing the issue and it's currently the latest commit for the file.
Change:
# Root certificates for internet access SSL_CERT_FILE = "${cacert}/etc/ssl/certs/ca-bundle.crt"; <ins> NIX_SSL_CERT_FILE = "${cacert}/etc/ssl/certs/ca-bundle.crt"; </ins> # https://github.com/NixOS/nix/blob/2.8.0/src/libstore/build/local-derivation-goal.cc#L1027-L1030 # PATH = "/path-not-set";

Discussion:
I can not clone git repositories inside containers that were created with . Steps to reproduce the behavior: a container: Error messages with verbose logging: Be able to clone git repositories. Git clone works when running the container with and using the full nix path to the git binary. Note that the is empty in this case. Just took a look at the of . The problem seems to be: With or set to the value of , git clone works too. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (since you introduced buildNixShellImage in ) Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Not related to the issue but I am wondering how I could add a "/tmp" folder to the image? Currently I am binding my hosts /tmp folder as workaround.
Ohh good catch. Could you make a PR to also set for ? Right below
I guess was faster^^
Change:
python3.pkgs.buildPythonApplication rec { pname = "copier"; <del> version = "7.0.1"; </del> <ins> version = "8.1.0"; </ins> format = "pyproject"; src = fetchFromGitHub {

Discussion:
Package name: copier Latest released version: 8.1.0 <!-- Search your package here: --- Current version on the unstable channel: 7.0.1 Current version on the stable/release channel: 7.0.1 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Change:
argon2_cffi dateutil future ]; <del> # no tests in PyPI tarball doCheck = false; </del> <ins> checkPhase = '' ${python.interpreter} -m unittest tests.tests ''; </ins> <del> meta = { homepage = "https://github.com/pschmitt/pykeepass"; </del> <ins> meta = with lib; { homepage = "https://github.com/libkeepass/pykeepass"; changelog = "https://github.com/libkeepass/pykeepass/blob/${version}/CHANGELOG.rst"; </ins> description = "Python library to interact with keepass databases (supports KDBX3 and KDBX4)"; <del> license = lib.licenses.gpl3; </del> <ins> license = licenses.gpl3Only; maintainers = with maintainers; [ dotlambda ]; </ins> }; }

Discussion:
Describe the bug fails due to To Reproduce Steps to reproduce the behavior: nixos-unstable, or nixos-unstable-small a derivation depending on , for example or Expected behavior Build succeeds Screenshots Additional context With I was able to narrow this down to the merge from that happened in . Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Hello pass-import maintainers! Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Change:
system.userActivationScripts.plasmaSetup = activationScript; programs.firefox.nativeMessagingHosts.packages = [ pkgs.plasma5Packages.plasma-browser-integration ]; <ins> programs.chromium.enablePlasmaBrowserIntegration = true; </ins> }) (mkIf (cfg.kwinrc != {}) {

Discussion:
Describe the bug addon in chromium does not work. After install addon show errors: "Failed to connect to the main process." "Verify the installation of the plasma-browser-integration package. The running environment of the Plasma desktop environment must be at least version 5.13." "Specified native messaging host not found." Manually run from console not help. To Reproduce Steps to reproduce the behavior: Add to : Expected behavior No errors. Additional context I found issue Everything looks like the same problem but in chromium Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Metadata Please run nix-shell -p nix-info --run "nix-info -m" and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Try adding the following line to your configuration:
now And also does not work. Maybe I need to reboot?
That issue is actually unrelated, it has to do with a patch only in our source build of firefox.
I make test with: in . The same error.
I can't reproduce this issue. I just tested in a vm using with this configuration: Are you using plasma5?
Yes plasma5. Looks like it worked for me too. Now all errors are gone. Thanks !
Why are we adding to systemPackages when using the chromium program module? It does this for you.
Just an oversight on my part. You're right, adding chromium to systemPackages is not necessary.
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
Thanks - the fix worked for me! Can you please comment on what's the role of package that you install?
I marked this as stale due to inactivity. &rarr;
Proposed fix in