jiebi/CodeConvo huggingface dataset:
Change:
// Deletes the PVC/PV, and launches a pod with hostpath volume to remove the test directory. func cleanupLocalVolumeGCELocalSSD(config *localTestConfig, volume *localTestVolume) { By("Removing the test directory") <del> removeCmd := fmt.Sprintf("rm %s", volume.hostDir+"/"+testFile) </del> <ins> file := volume.hostDir + "/" + testFile removeCmd := fmt.Sprintf("if [ -f %s ]; then rm %s; fi", file, file) </ins> err := issueNodeCommand(config, removeCmd, volume.node) Expect(err).NotTo(HaveOccurred()) }

Discussion:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Since 8/31, these tests have started flaking, and then started failing consistently. https://k8s- https://k8s- /assign
/kind failing-test
/milestone v1.12
Does this need cherry picked back to 1.11? Still have upgrade failures with this symptom, eg: https://k8s-
No, the localssd tests are not failing in the upgrade suite
/reopen I'm going to call this one a partial fix, as we are still seeing the "Set fsGroup for local volume should not set different fsGroups for two pods simultaneously" error on a whole bunch of test suites.
Reopening this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
can you link me to other suites where it is failing?
okay "a whole bunch" was exaggerated, I apologize: https://k8s- https://k8s-
The upgrade tests are not failing with "gce-localssd", which is what this issue is addressing, so is not related. The upgrade tests issues are being tracked in /close
Closing this issue. <detailsIn response to : The upgrade tests are not failing with "gce-localssd", which is what this issue is addressing, so is not related. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Change:
Selector:        map[string]string{"bar": "baz"}, SessionAffinity: api.ServiceAffinityNone, Type:            api.ServiceTypeNodePort, <ins> ClusterIP:       "1.2.3.5", </ins> Ports: []api.ServicePort{{ NodePort:   30020, Port:       6502,

Discussion:
Which test(s) are flaking: TestServiceRegistryUpdateDryRun Reason for failure: This is flaking rarely enough that it is not caught by our CI jobs, which currently tolerate up to 2 unit test failures per run (!). With that toleration removed in , this flake has been seen (). Reproducible with the following steps: the bug in the test that casts the return value even when the create fails: logging on slow etcd writes because of etcd-io/etcd a test binary for the affected package: the affected test using the tool: failures are seen, look at the logs to see the details about the error: /sig network
/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. ‍
heh this, was a funny one, we had 1/2^8 chances of using a duplicate, with 1/2^16 I've got 2000 runs without any failures
/assign /remove-triage unresolved
Change:
return deployment, newRS } <ins> func stopDeploymentOverlap(c *clientset.Clientset, oldC client.Interface, ns, deploymentName, overlapWith string) { stopDeploymentMaybeOverlap(c, oldC, ns, deploymentName, overlapWith) } </ins> func stopDeployment(c *clientset.Clientset, oldC client.Interface, ns, deploymentName string) { <ins> stopDeploymentMaybeOverlap(c, oldC, ns, deploymentName, "") } func stopDeploymentMaybeOverlap(c *clientset.Clientset, oldC client.Interface, ns, deploymentName, overlapWith string) { </ins> deployment, err := c.Extensions().Deployments(ns).Get(deploymentName) Expect(err).NotTo(HaveOccurred())

Discussion:
https://k8s- Failed: [] Deployment overlapping deployment should not fight with each other {Kubernetes e2e suite}
https://k8s- Failed: [] Deployment overlapping deployment should not fight with each other {Kubernetes e2e suite}
https://k8s- Failed: [] Deployment overlapping deployment should not fight with each other {Kubernetes e2e suite} Happened on a presubmit run in .
[FLAKE-PING] This flaky-test issue would love to have more attention.
https://k8s- Failed: [] Deployment overlapping deployment should not fight with each other {Kubernetes e2e suite}
https://k8s- Failed: [] Deployment overlapping deployment should not fight with each other {Kubernetes e2e suite}
Looking
Flakes happened when stopping overlapping deployments at clean up step.
You probably need to move the check before the deletionTimestamp check. Just make sure that observedGeneration is updated for the first case.
Because the deployments are overlapping, when deleting one deployment and determining if its RSes are deleted, there might be a race when the other deployment creates an RS
[FLAKE-PING] This flaky-test issue would love to have more attention.
Change:
) // Serial because the test restarts Kubelet <del> var _ = framework.KubeDescribe("Device Plugin [Feature:DevicePlugin]", func() { </del> <ins> var _ = framework.KubeDescribe("Device Plugin [Feature:DevicePlugin] [Serial]", func() { </ins> f := framework.NewDefaultFramework("device-plugin-errors") Context("DevicePlugin", func() {

Discussion:
http://k8s- looks like the job has multiple flaky tests :- /sig node /priority failing-test /kind bug /status approved-for-milestone cc any clue :smirk: ?
Change:
ginkgo.It("should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes", func(ctx context.Context) { // requires cloud load-balancer support <del> e2eskipper.SkipUnlessProviderIs("gce", "gke", "aws", "azure") </del> <ins> e2eskipper.SkipUnlessProviderIs("gce", "gke", "azure") </ins> ns := f.Namespace.Name nodes, err := e2enode.GetBoundedReadySchedulableNodes(ctx, cs, 2) framework.ExpectNoError(err)

Discussion:
When running the e2e tests on AWS, the following two tests are failing: with the stated cause being: these tests were with Expected the tests to pass Run the loadbalancer test suite on AWS While investigating the root cause of these failures, i cam across this function in the cloud-provider-aws: This function checks to ensure that a specific annotation has been applied to the Service object to determine if it is an NLB. The test in question creates the Service object with no annotations placed upon it, this in turn causes the test to fail. This confirms the need for the user to add the annotation. It is a continuation of a discussion that started in the SIG Cloud Provider meeting from 15 Feb 2023. <detailsi don't have a live cluster for this anymore, but it was version 1.26.1 </details<detailsAWS </details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig network /sig cloud-provider
when exploring this issue, i noticed we have this function in a different load balancer test: that function appears to have some specific logic for adding/removing annotations depending on the cloud provider. i thought this might be a place we could also use for AWs and the new tests, but i'm not sure if it is appropriate.
the test should be as much agnostic as possible, theoretically we tried to remove all the checks for cloud providers but Adding annotations and supporting all permutations on each cloud provider will be hard to support in the long term. If AWS doesn't support it we just can skip them in AWS
/assign
thanks , agreed on all points
please go ahead and tag me
Change:
// Wait all pods in waitSchedulingPods to be scheduled. wg.Wait() <del> // Ensure that all waitingPods in scheduler can be obtained from any profiles. for _, fwk := range scheduler.Profiles { actualPodNamesInWaitingPods := sets.NewString() fwk.IterateOverWaitingPods(func(pod framework.WaitingPod) { actualPodNamesInWaitingPods.Insert(pod.GetPod().Name) }) // Validate the name of pods in waitingPods matches expectations. if actualPodNamesInWaitingPods.Len() != len(tc.expectPodNamesInWaitingPods) || !actualPodNamesInWaitingPods.HasAll(tc.expectPodNamesInWaitingPods...) { t.Fatalf("Unexpected waitingPods in scheduler profile %s, expect: %#v, got: %#v", fwk.ProfileName(), tc.expectPodNamesInWaitingPods, actualPodNamesInWaitingPods.List()) </del> <ins> utiltesting.Eventually(tCtx, func(utiltesting.TContext) sets.Set[string] { // Ensure that all waitingPods in scheduler can be obtained from any profiles. actualPodNamesInWaitingPods := sets.New[string]() for _, fwk := range scheduler.Profiles { fwk.IterateOverWaitingPods(func(pod framework.WaitingPod) { actualPodNamesInWaitingPods.Insert(pod.GetPod().Name) }) </ins> } <del> } </del> <ins> return actualPodNamesInWaitingPods }).WithTimeout(permitTimeout).Should(gomega.Equal(sets.New(tc.expectPodNamesInWaitingPods...)), "unexpected waitingPods in scheduler profile") </ins> }) } }

Discussion:
/kind failing-test /kind flake First seen in an unrelated PR, but also occurs in periodic jobs. /sig scheduling
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign This feature is reverted once, and I fixed the flake, I'm cherry-pick that back again.
Change:
} } Expect(errCount).To(Equal(0), "Found invalid samples") <del> Expect(found).To(BeTrue(), "PVC %s, Namespace %s not found for %s", pvcName, namespace, metricKeyName) </del> <ins> return found </ins> }

Discussion:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: What you expected to happen: Test should not flake /sig storage /cc
/assign
GitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
GitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
- You won't be able to assign this to me (not a kubernetes member). Am taking a look.
volumemetrics.go_ could/should have more logging, either calling or more calls to .
The test appears to fail on this metric: "kubeletvolumestatsused_bytes". So samplePVC != pvcName and/or sampleNS != namespace. It would be nice if the sample name and ns were also logged. Also something is weird here: the framework's is called before the local . Note in the log:
- will add a couple of Logf() statements to log the samples - you're right that will help. Once the volume is attached, volume stats are grabbed every interval. The thing I noticed in the logs is that we issue a delete for the pod at but the volume only got attached/bound successfully at The test assumes blocks till the pod is running and PVC is attached but maybe that's not a valid assumption?
Nevermind - That log message has 2 timestamps in it - the volume was provisioned at .
Pushed The working theory being that volume stats were not collected within the wait earlier being used.
did you figure out if I was correct in thinking that the framework was invoked before the local ? That seems very, very unlikely but that is how it looked in the log.
- I believe you're right that the framework is being invoked before the local one.

I observe the same in a test as well, so I don't think it's specific to this call. Based on the , nested blocks should be invoked inner-outer. It's not clear, however - whether the local is nested - or at the same level as the framework block when I look at
Change:
import ( "fmt" <ins> "time" </ins> autoscalingv1 "k8s.io/kubernetes/pkg/apis/autoscaling/v1" "k8s.io/kubernetes/test/e2e/common"

Discussion:
Currently the time it takes for HPA and CA to scale up after load increase is not measured at all, and this can lead to regressions that will be missed. This issue is about adding an e2e test that will prevent such regressions.
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list .
Filip, can you reopen? I cannot do this myself, and this issue is clearly not closed yet.
Thanks Wojtek!
Change:
return nil, false, fmt.Errorf("Spec does not reference an AzureFile volume type") } <ins> func getAzureCloud(cloudProvider cloudprovider.Interface) (*azure.Cloud, error) { azure, ok := cloudProvider.(*azure.Cloud) if !ok || azure == nil { return nil, fmt.Errorf("Failed to get Azure Cloud Provider. GetCloudProvider returned %v instead", cloudProvider) } return azure, nil } func getStorageEndpointSuffix(cloudprovider cloudprovider.Interface) string { const publicCloudStorageEndpointSuffix = "core.windows.net" azure, err := getAzureCloud(cloudprovider) if err != nil { glog.Warningf("No Azure cloud provider found. Using the Azure public cloud endpoint: %s", publicCloudStorageEndpointSuffix) return publicCloudStorageEndpointSuffix } return azure.Environment.StorageEndpointSuffix } </ins>

Discussion:
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue
could you help confirm this?
One possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.
azure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.
I'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.
Change:
<ins> # Please keep kube-proxy configuration in-sync with: # cluster/addons/kube-proxy/kube-proxy-ds.yaml </ins> apiVersion: v1 kind: Pod metadata:

Discussion:
<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: ci-kubernetes-e2e-gci-gce-alpha-features Which test(s) are failing: BeforeSuite Since when has it been failing: Failing since 7/18 The failure seems to have been introduced in is the only PR within that window that modifies any cluster configuration. This PR is related to Testgrid link: Reason for failure: kube-proxy is stuck in a pending state /milestone v1.16 /priority critical-urgent /kind failing-test /sig testing /sig cluster-lifecycle /cc
almost definitely related to the image change E0725 05:54:40. 1368 ] container start failed: ErrImagePull: rpc error: code = Unknown desc = Error response from daemon: manifest for not found
/assign
hmm, we should watch to ensure that actually fixed it /reopen
Reopened this issue. <detailsIn response to : hmm, we should watch to ensure that actually fixed it /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Cluster came up in the most recent run, however it looks like tests may fail (it's not done yet). That should be a new issue though. /close
Closing this issue. <detailsIn response to : Cluster came up in the most recent run, however it looks like tests may fail (it's not done yet). That should be a new issue though. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Change:
ginkgo.By("creating a windows pod and waiting for it to be running") windowsPod = f.PodClient().CreateSync(windowsPod) <del> ginkgo.By("verifying pod external connectivity to the internet") ginkgo.By("checking connectivity to 8.8.8.8 53 (google.com) from Linux") assertConsistentConnectivity(f, linuxPod.ObjectMeta.Name, linuxOS, linuxCheck("8.8.8.8", 53)) ginkgo.By("checking connectivity to www.google.com from Windows") assertConsistentConnectivity(f, windowsPod.ObjectMeta.Name, windowsOS, windowsCheck("www.google.com")) </del> ginkgo.By("verifying pod internal connectivity to the cluster dataplane") ginkgo.By("checking connectivity from Linux to Windows")

Discussion:
We pinging to the original E2Es, however in airgapped environments, these tests fail for obvious reasons: In general, we need to parameterize this if possible. Running the or tests should pass in air-gapped environments, especially those that dont explicitly declare external connectivity. For example: Run the test suites inside of a kuberentes cluster which has no internet connection. pointing finger at :) <details</details<details</details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
some of these were recently removed by :) but some more to remove i think
They should have the corresponding tags so they can be filtered
and do we need to add a parameter in function as and replace from link. If not, what are we trying to achieve here ? I would like to collaborate.
independent test cases with their own feature tags as in
/assign
/sig testing windows network
/triage accepted
Change:
# Otherwise, we want a completely empty directory. if [[ "${JENKINS_FORCE_GET_TARS:-}" =~ ^[yY]$ ]]; then rm -rf kubernetes* <del> elif [[ $(find . -not -path './.config*' | wc -l) != 1 ]]; then echo $PWD not empty, bailing! </del> <ins> # .config and its children are created by the gcloud call that we use to # get the GCE service account. # console-log.txt is created by Jenkins, but is usually not flushed out # this early in the script. elif [[ $(find . -not -path "./.config*" -not -name "console-log.txt"  | wc -l) != 1 ]]; then echo "${PWD} not empty, bailing!" </ins> find . exit 1 fi

Discussion:
I've already seen it a couple of time. The cluster just don't start with the following logs: The example failure:
+1 I saw this a few times yesterday, but it went away, so I chalked it up to fallout from the GCE outage, and didn't open an issue. If we're still seeing it today, we should definitely try to track down and fix.
Additional failures might be helpful to track this down. I can't see where the extra files came from in the Jenkins log, and the workspace has long since been destroyed and recreated. Created to help debug this.
FYI, I created a Jenkins Failure Cause for this yesterday, so it should be reasonably easy to spot from now on:
Another example from before the debug patch.
Another instance: - this has just happened - you should have more information now
Relevant log: This might be an awkward race condition where most of the time Jenkins hasn't written out to console- by the time this check goes through, but occasionally it has. If that's the case, it might be worth printing a warning instead of failing the job when the workspace isn't empty, or else ignoring console- in the find.
I'm fine with the fix. can you please do it?
Change:
go func() { err := cmd.Run() if err != nil { <del> cmdErrorChan <- fmt.Errorf("%s Exited with status %v.  Output:n%v", cmd, err, *cmd.OutputBuffer) </del> <ins> cmdErrorChan <- fmt.Errorf("%s Failed with error "%v".  Command output:n%s", cmd, err, *cmd.OutputBuffer) </ins> } close(cmdErrorChan) }()

Discussion:
Looks like it maybe the ssh connect is getting killed
The relevant log snippet:
And another one, not just coreos.