jiebi/CodeConvo huggingface dataset:
Change:
} func TestSyncCreateTimeout(t *testing.T) { <ins> testOver := make(chan struct{}) defer close(testOver) </ins> storage := SimpleRESTStorage{ injectedFunction: func(obj interface{}) (interface{}, error) { <del> time.Sleep(5 * time.Millisecond) </del> <ins> // Eliminate flakes by ensuring the create operation takes longer than this test. <-testOver </ins> return obj, nil }, }

Discussion:
https://travis- Seems surprising-- I will look into it later if no one else does first.
Got another flake. Looking into it.
Change:
} __EOF__ <ins> # taint/untaint # Pre-condition: node has no taints kube::test::get_object_assert "nodes 127.0.0.1" "{{.spec.taints}}" '<no value>' # taint can add a taint kubectl taint node 127.0.0.1 dedicated=foo:PreferNoSchedule kube::test::get_object_assert "nodes 127.0.0.1" '{{range .spec.taints}}{{.effect}}{{end}}' 'PreferNoSchedule' # taint can remove a taint kubectl taint node 127.0.0.1 dedicated- # Post-condition: node has no taints kube::test::get_object_assert "nodes 127.0.0.1" "{{.spec.taints}}" '<no value>' </ins> ### kubectl cordon update with --dry-run does not mark node unschedulable # Pre-condition: node is schedulable kube::test::get_object_assert "nodes 127.0.0.1" "{{.spec.unschedulable}}" '<no value>'

Discussion:
https://k8s- This test is currently failing in sig-release master-blocking and upgrade suites since late 5/11. . This could potentially block Beta v1.11 which is due to be cut Tuesday,5/15. can you please help triage? /kind bug /priority failing-test /priority important-soon /sig cli cc /assign
Here are the failing upgrade jobs
Its all green now and I feel like crying :) thanks
Change:
go_test( name = "go_default_test", srcs = [ <ins> "nested_volumes_test.go", </ins> "resize_util_test.go", "util_test.go", ] + select({

Discussion:
This bug affects any pod that has a container with a nested volume (any type) beneath an API data volume, such as a secret, configMap, downwardAPI or projected volume. In the description and reproduction details below I use a secret volume, but any of the four will demonstrate this behavior. Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating a pod with nested secrets volumes (e.g. one volume mounted at and one mounted at ), the container fails to start with an error like: What you expected to happen: The container should start with both and mounted. How to reproduce it (as minimally and precisely as possible): out master, any version since a file with 2 secrets and a pod that makes volumes for the 2 secrets, with one of them mounted within the other: the 2 secrets and the pod. Assuming you named the above file : Anything else we need to know?: This may work for other runtimes if they create mountpoints outside of the sandbox. But it's definitely broken with Docker as the runtime.
This should be fixed by /sig storage /sig node /assign
Change:
local attempt=1 local result="" while true; do <del> if result=$(gcloud "${group}" "${resource}" list --project="${PROJECT}" "${filter:+--filter="$filter"}" "${@:4}"); then </del> <ins> if result=$(gcloud "${group}" "${resource}" list --project="${PROJECT}" ${filter:+--filter="$filter"} "${@:4}"); then </ins> if [[ -n "${GREP_REGEX:-}" ]]; then result=$(echo "${result}" | grep "${GREP_REGEX}" || true) fi

Discussion:
<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: gci-gce-scalability and all other gce performance tests Which test(s) are failing: List resource fails. Since when has it been failing: Run . 02:57 PDT 04/25/2019 Testgrid link: Reason for failure: After 4th attempt the script fails. Anything else we need to know:
/sig testing
The error is returned by the
IIUC the problem is cause by call. When there is no filter argument passed (${3}) there is call executed. The "" causes unrecognized arguments error.
/assign
Change:
) const ( <del> nautilusImage       = "kubernetes/update-demo:nautilus" kittenImage         = "kubernetes/update-demo:kitten" updateDemoSelector  = "name=update-demo" updateDemoContainer = "update-demo" kubectlProxyPort    = 8011 </del> <ins> nautilusImage            = "kubernetes/update-demo:nautilus" kittenImage              = "kubernetes/update-demo:kitten" updateDemoSelector       = "name=update-demo" updateDemoContainer      = "update-demo" frontendSelector         = "name=frontend" redisMasterSelector      = "name=redis-master" redisSlaveSelector       = "name=redis-slave" kubectlProxyPort         = 8011 guestbookResponseTimeout = 10 * time.Minute </ins> ) var _ = Describe("kubectl", func() { <del> // Constants. var ( updateDemoRoot = filepath.Join(testContext.repoRoot, "examples/update-demo/v1beta1") nautilusPath   = filepath.Join(updateDemoRoot, "nautilus-rc.yaml") kittenPath     = filepath.Join(updateDemoRoot, "kitten-rc.yaml") ) </del> var c *client.Client BeforeEach(func() {

Discussion:
Implement guestbook test as a kubectl-driven test in . this should be a fairly straightforward follow up from , if you are interested/have cycles.
As I wrote in the email the plan is: problem w guestbook example (). test becomes actual test (). it do ginkgo. Should be done this week, but it depends on how fast 1. can be done.
Change:
<ins> /* Copyright 2015 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package executor import ( "time" log "github.com/golang/glog" bindings "github.com/mesos/mesos-go/executor" ) // func that attempts suicide type jumper func(bindings.ExecutorDriver, <-chan struct{}) type suicideWatcher interface { Next(time.Duration, bindings.ExecutorDriver, jumper) suicideWatcher Reset(time.Duration) bool Stop() bool } // TODO(jdef) add metrics for this? type suicideTimer struct { timer *time.Timer } func (w *suicideTimer) Next(d time.Duration, driver bindings.ExecutorDriver, f jumper) suicideWatcher { return &suicideTimer{ timer: time.AfterFunc(d, func() { log.Warningf("Suicide timeout (%v) expired", d) f(driver, nil) }), } } func (w *suicideTimer) Stop() (result bool) { if w != nil && w.timer != nil { log.Infoln("stopping suicide watch") //TODO(jdef) debug result = w.timer.Stop() } return } // return true if the timer was successfully reset func (w *suicideTimer) Reset(d time.Duration) bool { if w != nil && w.timer != nil { log.Infoln("resetting suicide watch") //TODO(jdef) debug w.timer.Reset(d) return true } return false } </ins>

Discussion:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Followed the documentation on rules to limit group Id's to non-superuser (root) using the rule. The creation attempt failed with: From PSP yaml: What you expected to happen: Successfully create a new PSP for non-superuser (root) group privileges using available rule values (which actually seems to be , , according the the ) How to reproduce it (as minimally and precisely as possible): Attempt to create a PSP with a rule set to Anything else we need to know?: I don't think so Environment: Kubernetes version (use ): , looks to affect , and doc as well Cloud provider or hardware configuration: IBM Cloud OS (e.g: ):Kernel (e.g. ): Install tools: Others:
/sig docs
/assign
thanks will send out a fix next week
I wonder whether this is a bug in implementation or the document. Is this really a documentation issue?
yes, RunAsGroup does not support MustRunAsNonRoot
Got it. Thank you!
/priority important-soon
Change:
} func (o *DescribeOptions) DescribeMatchingResources(originalError error, resource, prefix string) error { <del> r := o.Builder. </del> <ins> r := o.NewBuilder(). </ins> Unstructured(). NamespaceParam(o.Namespace).DefaultNamespace(). ResourceTypeOrNameArgs(true, resource).

Discussion:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If this may be security issue, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: I run and I got Running with shows What you expected to happen: How to reproduce it (as minimally and precisely as possible): With Kubernetes master branch and in different terminal on the same machine Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: VM via libvirtd OS (e.g. from /etc/os-release): Fedora 27 with golang-1.10.1-1.fc29.x86_64 from rawhide Kernel (e.g. ):Install tools: ?? Others:
/sig cli
/assign
/assign
Change:
<ins> load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") go_library( name = "go_default_library", srcs = ["main.go"], importmap = "k8s.io/kubernetes/vendor/k8s.io/client-go/examples/dynamic-create-update-delete-deployment", importpath = "k8s.io/client-go/examples/dynamic-create-update-delete-deployment", visibility = ["//visibility:private"], deps = [ "//staging/src/k8s.io/api/core/v1:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library", "//staging/src/k8s.io/client-go/dynamic:go_default_library", "//staging/src/k8s.io/client-go/tools/clientcmd:go_default_library", "//staging/src/k8s.io/client-go/util/homedir:go_default_library", "//staging/src/k8s.io/client-go/util/retry:go_default_library", ], ) go_binary( name = "dynamic-create-update-delete-deployment", embed = [":go_default_library"], visibility = ["//visibility:public"], ) filegroup( name = "package-srcs", srcs = glob(["**"]), tags = ["automanaged"], visibility = ["//visibility:private"], ) filegroup( name = "all-srcs", srcs = [":package-srcs"], tags = ["automanaged"], visibility = ["//visibility:public"], ) </ins>

Discussion:
What would you like to be : Add documentation/example showing the usage of dynamic package in the client-go repo. /sig api-machinery
Change:
o.BuilderArgs = args o.Describer = f.Describer <del> o.Builder = f.NewBuilder() </del> <ins> o.NewBuilder = f.NewBuilder </ins> // include the uninitialized objects by default // unless user explicitly set --include-uninitialized=false

Discussion:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If this may be security issue, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: I run and I got Running with shows What you expected to happen: How to reproduce it (as minimally and precisely as possible): With Kubernetes master branch and in different terminal on the same machine Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: VM via libvirtd OS (e.g. from /etc/os-release): Fedora 27 with golang-1.10.1-1.fc29.x86_64 from rawhide Kernel (e.g. ):Install tools: ?? Others:
/sig cli
/assign
/assign
Change:
return unresPlugin, nil } <del> var perPlugin = &PermitPlugin{} </del> // Name returns name of the plugin. func (pp *PermitPlugin) Name() string { return permitPluginName

Discussion:
<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-integration Which test(s) are failing: TestPreemptWithPermitPlugin Since when has it been failing: 13:30 PST, Sep 9, 2019 Testgrid link: Reason for failure: Need investigations. Anything else we need to know: /sig scheduling
Another flaky It happens at 2019-08-06 05:43:47 +0000 UTC
The above repeated for 30 seconds.
I checked the code and log again. I think the reason is as following: When scheduler preempted , it failed to delete the pod(same as the case for , there might be something wrong with etcd), so it could not schedule because had not been deleted successfully.
/assign Find the root cause now, will send a PR soon.
Thanks for your work! Not sure whether you are still investigating it, the flaky test is impacting many PRs now, so I send a PR for it now, sorry for it.
Change:
package service <del> import ( "strconv" "github.com/golang/glog" "k8s.io/kubernetes/pkg/api/v1" ) </del> const ( // AnnotationLoadBalancerSourceRangesKey is the key of the annotation on a service to set allowed ingress ranges on their LoadBalancers //

Discussion:
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: AWS m4.2xlarge OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): 4.4.0-36-generic Install tools: kubeadm Others: 1 master and 1 minion What happened: This states that if using kube-proxy will only proxy requests to local endpoints, never forwarding traffic to other nodes and thereby preserving the original source IP address. However when I annotate my NodePort type service with this annotation I see the following error in the logs of kube-proxy of the node where the only pod of the service is running: After this message the service stops working outside of the cluster on the specified NodePort. What you expected to happen: I expected to see that only the with the pod on it serves traffic. How to reproduce it (as minimally and precisely as possible): Anything else we need to know:
Sorry, I have found the issue, I had a setup where the none of the node names were the same as the hostname of the kube-proxy pod and this caused the issue, where none of the Pods running on a hosts were recognised as local pods. I have fixed this issue by manually setting the hostname with in kube-proxy. However I still insist that this error message is misleading and shouldn't be printed in case of NodePort type services, but only for just LoadBalancers.
I met the same problem in the aws cloud providers, by adding - the hostname-override to solve this problem. good
Change:
tokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token `), os.FileMode(0755))) framework.Logf("copying override kubeconfig to the %s pod", simplePodName) <del> framework.RunKubectlOrDie("cp", filepath.Join(tmpDir, overrideKubeconfigName), ns+"/"+simplePodName+":/tmp/"+overrideKubeconfigName) </del> <ins> framework.RunKubectlOrDie("cp", filepath.Join(tmpDir, overrideKubeconfigName), ns+"/"+simplePodName+":/tmp/") framework.ExpectNoError(ioutil.WriteFile(filepath.Join(tmpDir, "invalid-configmap-with-namespace.yaml"), []byte(` kind: ConfigMap apiVersion: v1 metadata: name: "configmap with namespace and invalid name" namespace: configmap-namespace `), os.FileMode(0755))) framework.ExpectNoError(ioutil.WriteFile(filepath.Join(tmpDir, "invalid-configmap-without-namespace.yaml"), []byte(` kind: ConfigMap apiVersion: v1 metadata: name: "configmap without namespace and invalid name" `), os.FileMode(0755))) framework.Logf("copying configmap manifests to the %s pod", simplePodName) framework.RunKubectlOrDie("cp", filepath.Join(tmpDir, "invalid-configmap-with-namespace.yaml"), ns+"/"+simplePodName+":/tmp/") framework.RunKubectlOrDie("cp", filepath.Join(tmpDir, "invalid-configmap-without-namespace.yaml"), ns+"/"+simplePodName+":/tmp/") </ins> By("getting pods with in-cluster configs") execOutput := framework.RunHostCmdOrDie(ns, simplePodName, "/tmp/kubectl get pods --v=7 2>&1")

Discussion:
This is similar to , but that report (and fix) focussed on the in-cluster namespace vs configured .kube/config context namespace. I have a similar issue with the in-cluster namespace vs an explicit in the JSON/YAML file I'm passing to When run in-cluster, 1.5+ (including 1.6.0) refuses to allow me to create a resource in another namespace via an explicit property on a resource. 1.4.x honours when run in-cluster as expected. All versions honour when run out-of-cluster. I don't want to / can't provide an explicit arg or context declaration as suggested by the error text, because this is an automated deployment pipeline that creates resources in multiple namespaces. I just want the client to do-what-I-say without imposing additional client-side restrictions :stuckouttongue:
Fixed in
Change:
} ginkgo.By("Deleting the previously created pod") <del> err = e2epod.DeletePodWithWait(ctx, m.cs, pod) framework.ExpectNoError(err, "while deleting pod for resizing") </del> <ins> if test.simulatedCSIDriverError == expansionFailedMissingStagingPath { e2epod.DeletePodOrFail(ctx, m.cs, pod.Namespace, pod.Name) } else { err = e2epod.DeletePodWithWait(ctx, m.cs, pod) framework.ExpectNoError(err, "while deleting pod for resizing") } </ins> ginkgo.By("Creating a new pod with same volume") pod2, err := m.createPodWithPVC(pvc)

Discussion:
When a pod is quickly deleted and re-created on a node, it may not be necessary to unstage the volume and in which case only node-publish is called for the volume. When this happens - stagepath won't be set for RPC call because volume was not staged even though, volume does have capability. We should try and fix this behaviour so that - nodestagepath is always set in RPC call. We should try and fix this behaviour so that - nodestagepath is always set in RPC call. Quickly delete and recreate a pod No response master Any No response_ <details</details<details</details<details</details
/sig storage /triage accepted
Change:
}{ "catch all host and default backend with default TLS returns empty TLS": { rules: []string{ <del> "_/=catchall:8080,tls=", </del> <ins> "/=catchall:8080,tls=", </ins> }, ingressclass:   ingressClass, defaultbackend: "service1:https",

Discussion:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: kubectl create ingress panics because there is no cmdutil.AddDryRunFlag What you expected to happen: Command to work How to reproduce it (as minimally and precisely as possible): Compile the upstream, run ` Anything else we need to know?: Environment: Kubernetes version (use ): upstream/dev /sig cli /kind bug /priority critical-urgent
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Change:
framework.Failf("didn't find resource %s in the discovery doc", spec.Names.Plural) } }) <ins> ginkgo.It("should validate PreferredVersion for each APIGroup", func() { // get list of APIGroup endpoints list := &metav1.APIGroupList{} err := f.ClientSet.Discovery().RESTClient().Get().AbsPath("/apis/").Do(context.TODO()).Into(list) framework.ExpectNoError(err, "Failed to find /apis/") framework.ExpectNotEqual(len(list.Groups), 0, "Missing APIGroups") for _, group := range list.Groups { framework.Logf("Checking APIGroup: %v", group.Name) // locate APIGroup endpoint checkGroup := &metav1.APIGroup{} apiPath := "/apis/" + group.Name + "/" err = f.ClientSet.Discovery().RESTClient().Get().AbsPath(apiPath).Do(context.TODO()).Into(checkGroup) framework.ExpectNoError(err, "Fail to access: %s", apiPath) framework.ExpectNotEqual(len(checkGroup.Versions), 0, "No version found for %v", group.Name) framework.Logf("PreferredVersion.GroupVersion: %s", checkGroup.PreferredVersion.GroupVersion) framework.Logf("Versions found %v", checkGroup.Versions) // confirm that the PreferredVersion is a valid version match := false for _, version := range checkGroup.Versions { if version.GroupVersion == checkGroup.PreferredVersion.GroupVersion { framework.Logf("%s matches %s", version.GroupVersion, checkGroup.PreferredVersion.GroupVersion) match = true break } } framework.ExpectEqual(true, match, "failed to find a valid version for PreferredVersion") } }) </ins> })

Discussion:
] 20 July 2020 [x] Two weeks soak end date: 3 August 2020 According to this APIsnoop query, there are still an endpoint which is untested. Get a list of all group /apis Iterate through list Query each endpoint List the PreferredVersion for the endpoint Discover useragents: List endpoints hit by the test: Display endpoint coverage change: If a test with these calls gets merged, test coverage will go up by 15 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/retitle Write checkAPIGroupPreferredVersion Test +Promote - +16 Endpoint coverage
/reopen Merged /assign Ready for creation of Promotion PR
Reopened this issue. <detailsIn response to : /reopen Merged /assign Ready for creation of Promotion PR Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Change:
wantStatusFailed:    0, wantStatusSucceeded: 0, }, <ins> "ignore pod failure based on OnPodConditions, ignored failures delays pod recreation": { enableJobPodFailurePolicy: true, job: batch.Job{ TypeMeta:   metav1.TypeMeta{Kind: "Job"}, ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:     validSelector, Template:     validTemplate, Parallelism:  pointer.Int32(1), Completions:  pointer.Int32(1), BackoffLimit: pointer.Int32(0), PodFailurePolicy: &batch.PodFailurePolicy{ Rules: []batch.PodFailurePolicyRule{ { Action: batch.PodFailurePolicyActionIgnore, OnPodConditions: []batch.PodFailurePolicyOnPodConditionsPattern{ { Type:   v1.DisruptionTarget, Status: v1.ConditionTrue, }, }, }, }, }, }, }, pods: []v1.Pod{ { ObjectMeta: metav1.ObjectMeta{ DeletionTimestamp: &now, }, Status: v1.PodStatus{ Phase: v1.PodFailed, Conditions: []v1.PodCondition{ { Type:   v1.DisruptionTarget, Status: v1.ConditionTrue, }, }, }, }, }, wantConditions:      nil, wantStatusActive:    0, wantStatusFailed:    0, wantStatusSucceeded: 0, }, </ins> "fail job based on OnPodConditions": { enableJobPodFailurePolicy: true, job: batch.Job{

Discussion:
Pod backoff calculation excludes pods that match an rule in the failure policy: This could lead to fast retries, overwhelming the control plane, if most failures match an rule. The semantics of is not to count towards the limit, but the backoff should still be respected. /sig apps Recreations to be throttled. a Job with failure policy that matches every kind of failure. a container that always fails You would observe immediate recreation. No response_ 27+ <detailsN/A </details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
cc