Change:
}, }, }, <ins> { name: "set new condition which doesn't have lastTransitionTime set", crdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionTrue, Reason:             "Accepted", Message:            "the initial names have been accepted", LastTransitionTime: metav1.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC), }, }, newCondition: CustomResourceDefinitionCondition{ Type:    Established, Status:  ConditionFalse, Reason:  "NotAccepted", Message: "Not accepted", }, expectedcrdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionFalse, Reason:             "NotAccepted", Message:            "Not accepted", LastTransitionTime: metav1.Date(2018, 1, 2, 0, 0, 0, 0, time.UTC), }, }, }, { name: "append new condition which doesn't have lastTransitionTime set", crdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionTrue, Reason:             "Accepted", Message:            "the initial names have been accepted", LastTransitionTime: metav1.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC), }, }, newCondition: CustomResourceDefinitionCondition{ Type:    Terminating, Status:  ConditionFalse, Reason:  "NeverEstablished", Message: "resource was never established", }, expectedcrdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionTrue, Reason:             "Accepted", Message:            "the initial names have been accepted", LastTransitionTime: metav1.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC), }, { Type:               Terminating, Status:             ConditionFalse, Reason:             "NeverEstablished", Message:            "resource was never established", LastTransitionTime: metav1.Date(2018, 2, 1, 0, 0, 0, 0, time.UTC), }, }, }, </ins> } for _, tc := range tests { crd := generateCRDwithCondition(tc.crdCondition)

Discussion:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: the for a CRDs Established condition is always null What you expected to happen: it should have a timestamp How to reproduce it (as minimally and precisely as possible): create a CRD and then examine its yaml/json. For example: Anything else we need to know?: Environment: community master
/assign
/area custom-resource
/sig api-machinery /area custom-resources
/assign
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
/remove-lifecycle rotten
edit: actually, that issue is about kubectl display and clock skew. this issue is about the condition timestamp updating, which still requires correction
Closing this issue. <detailsIn response to : duplicate of Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Hello I'm a bug triage shadow for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. Code freeze is starting on August 29th (about 3 days from now), which means that this PR must merged by then. Do we still target this issue to be fixed for 1.16?
yes, will take a look at it tomorrow /assign