jiebi/CodeConvo huggingface dataset:
Change:
} } <del> // KubePod returns the kube pod </del> <ins> // KubePod returns the kube pod (will add label selectors for windows if needed). </ins> func (p *Pod) KubePod() *v1.Pod { zero := int64(0) <del> return &v1.Pod{ </del> <ins> thePod := &v1.Pod{ </ins> ObjectMeta: metav1.ObjectMeta{ Name:      p.Name, Labels:    p.LabelSelector(),

Discussion:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Ive done preliminary testing with on calico powered clusters on some windows variants and found that the probing seems to work. Can we add wrapper to netpol suite so that we can run it on windows clusters ? Why is this needed: We need this because otherwise, CNIs such as EKS will give us This error is caused when, for example, pods that are landing on a windows node havent defined their target platform. Somehow i guess pods which are landing on linux nodes dont have this issue. Its also needed for the obvious reason that we probably want separate linux and windows test suites for policies, in general, even though we expect the logic to be identical (modulo hostports , which we dont currently test)
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig windows
/assign
grepping around, I can't figure out where those are supposed to go. Can you give me pointers?
(resolved in slack, matts digging into this)
ok, these are running now on eks, lots of failures. will dig
/assign
the netpol are not being applied for the ns: Instead of failing because should not be able to access , the connection succeeds.
Change:
w.Write(output) } })) <del> defer srv.Close() tests := []struct { c      string e      string expect bool }{ { c:      "", e:      "", expect: false, }, { c:      "", e:      srv.URL, expect: true, }, { c:      "foo", e:      srv.URL, expect: true, }, } for _, rt := range tests { s := &kubeadmapi.TokenDiscovery{} c := &kubeadmapi.ClusterInfo{Endpoints: []string{rt.e}, CertificateAuthorities: []string{rt.c}} _, actual := EstablishMasterConnection(s, c) if (actual == nil) != rt.expect { t.Errorf( "failed EstablishMasterConnection:ntexpected: %tnt  actual: %t", rt.expect, (actual == nil), ) } } </del> <ins> return srv </ins> } func TestCreateClients(t *testing.T) {

Discussion:
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): No. What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubeadm join kubeadm join crash kubeadm close of closed channel Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Client Version: version.Info{Major:"1", Minor:"4", GitVersion:"v1.4.4", GitCommit:"", GitTreeState:"clean", BuildDate:"2016-10-21T02:48:38Z", GoVersion:"go1.6.3", Compiler:"gc", Platform:"linux/amd64"} kubeadm version (use ): kubeadm version: version.Info{Major:"1", Minor:"5+", GitVersion:"v1.5.0-alpha.2.380+", GitCommit:"", GitTreeState:"clean", BuildDate:"2016-11-02T14:58:17Z", GoVersion:"go1.7.1", Compiler:"gc", Platform:"linux/amd64"} Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): CentOS Kernel (e.g.

): 3.10.0-327.36.1.el7.x8664 SMP Sun Sep 18 13:04:29 UTC 2016 x8664 x8664 x8664 GNU/Linux Install tools: yum Others: What happened: kubeadm crash when join mulitple API endpoints What you expected to happen: How to reproduce it (as minimally and precisely as possible): join mulitple API endpoints Anything else do we need to know: kubeadm output:
It is already fixed by
seems not fixed, still having this issue with master code
I'm also running into this with a clean build from master kubeadm version kubeadm output kubectl version Environment kernel versionOS version
seems not fixed. I met the same issue . kubeadm version: kernel version: os version: kubectl version: error output by "kubeadm join --token=. 10.47.217.91":
I can also repro this issue - I will work on contributing a fix.
I can also reproduce this issue, following the guide with packaged versions of all the components
Change:
const ( podWaitingReason = "podWaiting" <ins> permitTimeout    = 10 * time.Second </ins> ) func (f fakePermitPlugin) Permit(ctx context.Context, state *framework.CycleState, p *v1.Pod, nodeName string) (*framework.Status, time.Duration) {

Discussion:
/kind failing-test /kind flake First seen in an unrelated PR, but also occurs in periodic jobs. /sig scheduling
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign This feature is reverted once, and I fixed the flake, I'm cherry-pick that back again.
Change:
} } <del> sort.Stable(sortableGroupResource(resources)) </del> <ins> sort.Stable(sortableResource{resources, o.SortBy}) </ins> for _, r := range resources { switch o.Output { case "name":

Discussion:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.
/sig usability
Change:
--etcd-servers="http://${ETCD_HOST}:${ETCD_PORT}"  --service-cluster-ip-range="${SERVICE_CLUSTER_IP_RANGE}"  --feature-gates="${FEATURE_GATES}"  <ins> --emulated-version="${EMULATED_VERSION}"  </ins> --external-hostname="${EXTERNAL_HOSTNAME}"  --requestheader-username-headers=X-Remote-User  --requestheader-group-headers=X-Remote-Group 

Discussion:
Currently the local-up- script does not have support for the flag. This flag was recently here as a part of For development, testing, and full plumbing through of the feature the flag should be to local-up- to allow for usage of the feature when setting up a cluster via local-up-
/sig apimachinery
The label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig apimachinery Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig api-machinery
/sig testing /triage accepted /assign
Change:
accBody: "ok body", }, { <del> // Echo handler that returns the contents of request headers in the body handler: func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(200) output := "" for k, arr := range r.Header { for _, v := range arr { output += fmt.Sprintf("%s: %sn", k, v) } } w.Write([]byte(output)) }, </del> <ins> handler: headerEchoHandler, </ins> reqHeaders: http.Header{ "X-Muffins-Or-Cupcakes": {"muffins"}, },

Discussion:
Grabbed tcpdump of a readiness probe - the src ip was the bridge address (10.244.1.1), but apart from this, there is no identifying information in the HTTP request that this is a Kubernetes daemon requesting readiness checks - this might help QoS/priority assignment by the container application.
IIUC, you mean we should add a better when kubernetes daemon request a readiness check to identify this request comes from kubernetes daemon?
Yes, we should override the default net/http user-agent with our own. Better usability for users and we have no future upgrade hazards if users start hardcoding and expecting this default User-Agent string in their analytic tools.
Any news about this one? It would be nice! I've this little hack in my nginx configuration (in order to not be spamed by health check in logs) :)
This can probably be closed now that probes have support.
Change:
}, } { t.Run(desc, func(t *testing.T) { <del> t.Parallel() </del> vals := DefaultTestClusterValues() nodeNames := []string{"test-node-1"}

Discussion:
Seeing several of the tests in ./pkg/cloudprovider/providers/gce flake 1 in 5-10 runs when run locally (I am logged in to gcloud). Is it possible one of the APIs is not correctly shimmed and is fetching real data?
you were the last folks in here - why would this and other internal_tests in here be flaking?
Happens in both master and 1.11 release branches
/cc cheftako
Change:
if ! gcloud compute instances add-metadata "${instance}"  --project "${PROJECT}"  --zone "${ZONE}"  <del> --metadata-from-file "${kvs[@]}"; then </del> <ins> --metadata-from-file $(IFS=, ; echo "${kvs[*]}"); then </ins> if (( attempt > 5 )); then echo -e "${color_red}Failed to add instance metadata in ${instance} ${color_norm}" exit 2

Discussion:
WARNING: Lists should be separated by commas, try "--metadata-from-file=kube-env=/tmp/kubernetes.sCQI6j/master-kube-,startup-". If you intend to use startup- for positional arguments, put them before the flag.
Change:
func describeNodeResource(nodeNonTerminatedPodsList *corev1.PodList, node *corev1.Node, w PrefixWriter) { w.Write(LEVEL_0, "Non-terminated Pods:t(%d in total)n", len(nodeNonTerminatedPodsList.Items)) <del> w.Write(LEVEL_1, "NamespacetNamettCPU RequeststCPU LimitstMemory RequeststMemory LimitstAGEn") </del> <ins> w.Write(LEVEL_1, "NamespacetNamettCPU RequeststCPU LimitstMemory RequeststMemory LimitstAgen") </ins> w.Write(LEVEL_1, "---------t----tt------------t----------t---------------t-------------t---n") allocatable := node.Status.Capacity if len(node.Status.Allocatable) > 0 {

Discussion:
At line 3775 in (), the last column is "AGE", all uppercase, while the other columns are sentence case. Is this intentional or an oversight?
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig cli
If this is a mistake I will open a PR to fix it.
/cc
/triage accepted
The label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /triage excepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/triage accepted
The label cannot be applied. Only GitHub organization members can add the label. <detailsIn response to : /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
yes ,should be Age
Change:
errExpected:      context.Canceled, }, { <ins> name:    "context already canceled condition success and immediate 1 attempt expected", context: cancelledContext, callback: func(_ int) (bool, error) { return true, nil }, immediate:        true, attemptsExpected: 1, }, { name:    "context already canceled condition fail and immediate 1 attempt expected", context: cancelledContext, callback: func(_ int) (bool, error) { return false, conditionErr }, immediate:        true, attemptsExpected: 1, errExpected:      conditionErr, }, { name:             "context already canceled and immediate 1 attempt expected", context:          cancelledContext, callback:         defaultCallback, immediate:        true, attemptsExpected: 1, errExpected:      context.Canceled, }, { </ins> name:               "context cancelled after 5 attempts", context:            defaultContext, callback:           defaultCallback,

Discussion:
Calling wait.PollUntilContextTimeout with immediate=true does not invoke the passed condition function if context has already been cancelled. wait.PollUntilContextTimeout with immediate=true should invoke the passed condition function at least once even if context has already been cancelled as wait.PollUntilContextCancel documentation says: Note that wait.PollUntilContextTimeout wraps wait.PollUntilContextCancel, so the above should be applied to wait.PollUntilContextTimeout as well. This program panics because context ctx.Err is checked before invoking the passed function. The deprecated wait.PollImmediateWithContext does not have this kind of issue. If wait.PollUntilContextTimeout is the replacement of wait.PollImmediateWithContext, it should exhibit the same behavior. k8s v1.27.2 <details</details<details</details<details</details<details</details<details</details<details</details
/sig api-machinery
TestloopConditionUntilContextsemantic also has an issue that immediate and sliding are not tested as expected. immediate and sliding are loop variable, but they are not used in the test. The ones that are used are in testcase struct which are always false.
/assign
ok, it seems this would do it
/assign
/triage accepted
Change:
classUnsupportedMountOptions string = "unsupported-mountoptions" classLarge                   string = "large" classWait                    string = "wait" <ins> classCSI                     string = "csi" </ins> modeWait = storage.VolumeBindingWaitForFirstConsumer )

Discussion:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: In clusters that have intree drivers as the default storageclass, if you try to create a PVC with snapshot data source and forget to put the csi storageclass in it, then an empty PVC will be provisioned using the default storageclass. What you expected to happen: PVC creation should not proceed and instead have an event with an incompatible error, similar to how we check proper csi driver in the csi provisioner. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
I think similar issue exists with cloning. We'll need to think about what the behavior should be for data populators too. cc
/triage accepted
Scenario to reproduce the issue Create the nginx deployment and the PVC used by it Exec into the running container, cd into the PVC mounted path and create some files Create the following using as source the The used is the following and wait until it becomes Delete the deployment and the initial PVC Create a new PVC, using the previously created as its Set the name of the new (restored) PVC to the nginx deployment and create the again into the PVC mounted directory. It should contain the previously created files but its empty
can you modify the title of this issue and change to ? In addition to snapshot datasource, using PVC datasource and AnyVolumeDataSource should also fail for in-tree PVC.
/assign
I wasn't 100% sure on data populators. Because it shouldn't have a dependency on CSI right?
I guess even if data populators does support intree volumes, pv controller should ignore it similar to csi provisioner
It may or may not have a dependency on CSI. Design is still in progress. We can leave it out for now until we know exactly how to use it. One thing I know is that the any volume data source cannot be an in-tree k8s resource.
Yes, we can actually just ignore it in pv controller.

Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/remove-lifecycle stale
I'm getting same with longhorn, is this issue resolved on your side?
Change:
By("Clean up the node condition") patch := []byte(fmt.Sprintf(`{"status":{"conditions":[{"$patch":"delete","type":"%s"}]}}`, condition)) c.Core().RESTClient().Patch(types.StrategicMergePatchType).Resource("nodes").Name(framework.TestContext.NodeName).SubResource("status").Body(patch).Do() <del> By("Clean up the temporary directory") Expect(os.RemoveAll(path.Dir(tmpLogFile))).To(Succeed()) </del> }) }) })

Discussion:
Leads to this avc: In general, HostPath volumes in tests are bad news for selinux.
Change:
return numPods, missingTimestamp, nil } <ins> // isDynamicDiscoveryError returns true if the error is a group discovery error // only for groups expected to be created/deleted dynamically during e2e tests func isDynamicDiscoveryError(err error) bool { if !discovery.IsGroupDiscoveryFailedError(err) { return false } discoveryErr := err.(*discovery.ErrGroupDiscoveryFailed) for gv := range discoveryErr.Groups { switch gv.Group { case "mygroup.example.com": // custom_resource_definition // garbage_collector case "wardle.k8s.io": // aggregator default: Logf("discovery error for unexpected group: %#v", gv) return false } } return false } </ins> // hasRemainingContent checks if there is remaining content in the namespace via API discovery func hasRemainingContent(c clientset.Interface, clientPool dynamic.ClientPool, namespace string) (bool, error) { // some tests generate their own framework.Client rather than the default

Discussion:
Seen in https://k8s- Aug 26 09:35:45.074: Couldn't delete ns: "e2e-tests-containers-9cscj": an error on the server ("missing route (service "sample-api" not found)") has prevented the request from succeeding (get ) (&errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:""}, Status:"Failure", Message:"an error on the server ("missing route (service "sample-api" not found)") has prevented the request from succeeding (get )", Reason:"InternalError", Details:(*v1.StatusDetails)(0xc4217a4900), Code:500}})
https://k8s-
Change:
} if err := proxier.syncService(svcNameString, serv, true); err == nil { activeIPVSServices[serv.String()] = true <del> if err := proxier.syncEndpoint(svcName, svcInfo.OnlyNodeLocalEndpoints, serv); err != nil { </del> <ins> if err := proxier.syncEndpoint(svcName, false, serv); err != nil { </ins> glog.Errorf("Failed to sync endpoint for service: %v, err: %v", serv, err) } } else {

Discussion:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: The test is flaky with the error something like: What you expected to happen: Test should pass /assign
/sig network /area ipvs
/close
Cases are green now. :tada:
Change:
"!('x' in self.val1)", "self.val1 + self.val2 == ['a', 'b', 'c']", "self.val1 + ['c', 'd'] == ['a', 'b', 'c', 'd']", <ins> // Join function "self.val1.join('-') == 'a-b-c'", "['a', 'b', 'c'].join('-') == 'a-b-c'", "self.val1.join() == 'abc'", "['a', 'b', 'c'].join() == 'abc'", </ins> }, }, {name: "listMaps",

Discussion:
Added this test to : this resulted in: The test should pass. Add the above test No response All versions where CEL is used. All Doesn't matter No response No response No response_
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
Opened to discuss the expected behavior in cel-go for this.
Change:
cs := context.clientSet // Add multiple nodes, one of them will be scored much higher than the others. <del> nodes, err := createNodes(cs, "test-node", nil, 10) </del> <ins> _, err := createNodes(cs, "test-node", nil, 10) </ins> if err != nil { t.Fatalf("Cannot create nodes: %v", err) } <del> scPlugin.highScoreNode = nodes[3].Name </del> for i, fail := range []bool{false, true} { scPlugin.failScore = fail

Discussion:
What happened: The new TestScorePlugin for the scheduler framework is flaky How to reproduce it (as minimally and precisely as possible): An example: Anything else we need to know?: The test evaluates that a pod should be scheduled on specific node with a higher score. I think the test sometimes fails because the higher score node that the test creates didn't propagate yet to the scheduler (i.e., the node exists in etcd, but scheduler hasn't been notified that it exists yet, and so it is not evaluated at all). /kind bug /sig scheduling /assign
/kind flake
Change:
// and keep accepting inbound traffic. outConn, err := net.DialTimeout(protocol, endpoint, retryTimeout*time.Second) if err != nil { <ins> if isTooManyFDsError(err) { panic("Dial failed: " + err.Error()) } </ins> glog.Errorf("Dial failed: %v", err) continue }

Discussion:
Restarting might also be acceptable. It's a pretty painful user experience right now if this happens-- it fills the logs with this message.
Yes, it should just panic() , Daniel Smith wrote:
Yeah I guess if it's out of FDs it can't really open a network connection to file an event...
kube-proxy should send an event when it starts up, just like kubelet does with its method. This works around the fact that you can't send an event when you are out of FDs, and it still provides a lot of debugging value.
Agreed with 1) kube-proxy should panic when hitting out of fd 2) restarted kube-proxy should pick up the crash reason like what we do for internal agent 3) crash reason should be propogated to upstream as an event.
Moving to the right sig.
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/lifecycle frozen
/remove-lifecycle stale
/area kube-proxy
we're going to close this because, after 3 years or so , decreasing interest in the userspace proxy and nobody other then some openshift folks, are using the linux kube proxy .. can reopen if necessary ping :)
/close
Closing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details