Change:
<del> /* Copyright 2015 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package defaults import ( "fmt" "net/http/httptest" "reflect" "testing" "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/util/sets" "k8s.io/client-go/informers" clientset "k8s.io/client-go/kubernetes" restclient "k8s.io/client-go/rest" utiltesting "k8s.io/client-go/util/testing" _ "k8s.io/kubernetes/pkg/apis/core/install" schedulerapi "k8s.io/kubernetes/pkg/scheduler/api" latestschedulerapi "k8s.io/kubernetes/pkg/scheduler/api/latest" "k8s.io/kubernetes/pkg/scheduler/factory" ) func TestCompatibility_v1_Scheduler(t *testing.T) { // Add serialized versions of scheduler config that exercise available options to ensure compatibility between releases schedulerFiles := map[string]struct { JSON           string ExpectedPolicy schedulerapi.Policy }{ // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.0": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsPorts"}, {"name": "NoDiskConflict"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "LeastRequestedPriority",   "weight": 1}, {"name": "ServiceSpreadingPriority", "weight": 2}, {"name": "TestServiceAntiAffinity",  "weight": 3, "argument": {"serviceAntiAffinity": {"label": "zone"}}}, {"name": "TestLabelPreference",      "weight": 4, "argument": {"labelPreference": {"label": "bar", "presence":true}}} ] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsPorts"}, {Name: "NoDiskConflict"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "LeastRequestedPriority", Weight: 1}, {Name: "ServiceSpreadingPriority", Weight: 2}, {Name: "TestServiceAntiAffinity", Weight: 3, Argument: &schedulerapi.PriorityArgument{ServiceAntiAffinity: &schedulerapi.ServiceAntiAffinity{Label: "zone"}}}, {Name: "TestLabelPreference", Weight: 4, Argument: &schedulerapi.PriorityArgument{LabelPreference: &schedulerapi.LabelPreference{Label: "bar", Presence: true}}}, }, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.1": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsHostPorts"}, {"name": "PodFitsResources"}, {"name": "NoDiskConflict"}, {"name": "HostName"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "TestServiceAntiAffinity",  "weight": 3, "argument": {"serviceAntiAffinity": {"label": "zone"}}}, {"name": "TestLabelPreference",      "weight": 4, "argument": {"labelPreference": {"label": "bar", "presence":true}}} ] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsHostPorts"}, {Name: "PodFitsResources"}, {Name: "NoDiskConflict"}, {Name: "HostName"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "TestServiceAntiAffinity", Weight: 3, Argument: &schedulerapi.PriorityArgument{ServiceAntiAffinity: &schedulerapi.ServiceAntiAffinity{Label: "zone"}}}, {Name: "TestLabelPreference", Weight: 4, Argument: &schedulerapi.PriorityArgument{LabelPreference: &schedulerapi.LabelPreference{Label: "bar", Presence: true}}}, }, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.2": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "TestServiceAntiAffinity",  "weight": 3, "argument": {"serviceAntiAffinity": {"label": "zone"}}}, {"name": "TestLabelPreference",      "weight": 4, "argument": {"labelPreference": {"label": "bar", "presence":true}}} ] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "TestServiceAntiAffinity", Weight: 3, Argument: &schedulerapi.PriorityArgument{ServiceAntiAffinity: &schedulerapi.ServiceAntiAffinity{Label: "zone"}}}, {Name: "TestLabelPreference", Weight: 4, Argument: &schedulerapi.PriorityArgument{LabelPreference: &schedulerapi.LabelPreference{Label: "bar", Presence: true}}}, }, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.3": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2} ] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, }, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.4": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2} ] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, }, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.7": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2} ],"extenders": [{ "urlPrefix":        "/prefix", "filterVerb":       "filter", "prioritizeVerb":   "prioritize", "weight":           1, "BindVerb":         "bind", "enableHttps":      true, "tlsConfig":        {"Insecure":true}, "httpTimeout":      1, "nodeCacheCapable": true }] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, }, ExtenderConfigs: []schedulerapi.ExtenderConfig{{ URLPrefix:        "/prefix", FilterVerb:       "filter", PrioritizeVerb:   "prioritize", Weight:           1, BindVerb:         "bind", // 1.7 was missing json tags on the BindVerb field and required "BindVerb" EnableHTTPS:      true, TLSConfig:        &restclient.TLSClientConfig{Insecure: true}, HTTPTimeout:      1, NodeCacheCapable: true, }}, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.8": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "CheckNodeCondition"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2} ],"extenders": [{ "urlPrefix":        "/prefix", "filterVerb":       "filter", "prioritizeVerb":   "prioritize", "weight":           1, "bindVerb":         "bind", "enableHttps":      true, "tlsConfig":        {"Insecure":true}, "httpTimeout":      1, "nodeCacheCapable": true }] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "CheckNodeCondition"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, }, ExtenderConfigs: []schedulerapi.ExtenderConfig{{ URLPrefix:        "/prefix", FilterVerb:       "filter", PrioritizeVerb:   "prioritize", Weight:           1, BindVerb:         "bind", // 1.8 became case-insensitive and tolerated "bindVerb" EnableHTTPS:      true, TLSConfig:        &restclient.TLSClientConfig{Insecure: true}, HTTPTimeout:      1, NodeCacheCapable: true, }}, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.9": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "CheckNodeCondition"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "CheckVolumeBinding"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2} ],"extenders": [{ "urlPrefix":        "/prefix", "filterVerb":       "filter", "prioritizeVerb":   "prioritize", "weight":           1, "bindVerb":         "bind", "enableHttps":      true, "tlsConfig":        {"Insecure":true}, "httpTimeout":      1, "nodeCacheCapable": true }] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "CheckNodeCondition"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "CheckVolumeBinding"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, }, ExtenderConfigs: []schedulerapi.ExtenderConfig{{ URLPrefix:        "/prefix", FilterVerb:       "filter", PrioritizeVerb:   "prioritize", Weight:           1, BindVerb:         "bind", // 1.9 was case-insensitive and tolerated "bindVerb" EnableHTTPS:      true, TLSConfig:        &restclient.TLSClientConfig{Insecure: true}, HTTPTimeout:      1, NodeCacheCapable: true, }}, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.10": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "CheckNodePIDPressure"}, {"name": "CheckNodeCondition"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "CheckVolumeBinding"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2} ],"extenders": [{ "urlPrefix":        "/prefix", "filterVerb":       "filter", "prioritizeVerb":   "prioritize", "weight":           1, "bindVerb":         "bind", "enableHttps":      true, "tlsConfig":        {"Insecure":true}, "httpTimeout":      1, "nodeCacheCapable": true, "managedResources": [{"name":"example.com/foo","ignoredByScheduler":true}], "ignorable":true }] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "CheckNodePIDPressure"}, {Name: "CheckNodeCondition"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "CheckVolumeBinding"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, }, ExtenderConfigs: []schedulerapi.ExtenderConfig{{ URLPrefix:        "/prefix", FilterVerb:       "filter", PrioritizeVerb:   "prioritize", Weight:           1, BindVerb:         "bind", // 1.10 was case-insensitive and tolerated "bindVerb" EnableHTTPS:      true, TLSConfig:        &restclient.TLSClientConfig{Insecure: true}, HTTPTimeout:      1, NodeCacheCapable: true, ManagedResources: []schedulerapi.ExtenderManagedResource{{Name: v1.ResourceName("example.com/foo"), IgnoredByScheduler: true}}, Ignorable:        true, }}, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.11": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "CheckNodePIDPressure"}, {"name": "CheckNodeCondition"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "CheckVolumeBinding"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2}, { "name": "RequestedToCapacityRatioPriority", "weight": 2, "argument": { "requestedToCapacityRatioArguments": { "shape": [ {"utilization": 0,  "score": 0}, {"utilization": 50, "score": 7} ] } }} ],"extenders": [{ "urlPrefix":        "/prefix", "filterVerb":       "filter", "prioritizeVerb":   "prioritize", "weight":           1, "bindVerb":         "bind", "enableHttps":      true, "tlsConfig":        {"Insecure":true}, "httpTimeout":      1, "nodeCacheCapable": true, "managedResources": [{"name":"example.com/foo","ignoredByScheduler":true}], "ignorable":true }] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "CheckNodePIDPressure"}, {Name: "CheckNodeCondition"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "CheckVolumeBinding"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, { Name:   "RequestedToCapacityRatioPriority", Weight: 2, Argument: &schedulerapi.PriorityArgument{ RequestedToCapacityRatioArguments: &schedulerapi.RequestedToCapacityRatioArguments{ UtilizationShape: []schedulerapi.UtilizationShapePoint{ {Utilization: 0, Score: 0}, {Utilization: 50, Score: 7}, }}, }, }, }, ExtenderConfigs: []schedulerapi.ExtenderConfig{{ URLPrefix:        "/prefix", FilterVerb:       "filter", PrioritizeVerb:   "prioritize", Weight:           1, BindVerb:         "bind", // 1.11 restored case-sensitivity, but allowed either "BindVerb" or "bindVerb" EnableHTTPS:      true, TLSConfig:        &restclient.TLSClientConfig{Insecure: true}, HTTPTimeout:      1, NodeCacheCapable: true, ManagedResources: []schedulerapi.ExtenderManagedResource{{Name: v1.ResourceName("example.com/foo"), IgnoredByScheduler: true}}, Ignorable:        true, }}, }, }, // Do not change this JSON after the corresponding release has been tagged. // A failure indicates backwards compatibility with the specified release was broken. "1.12": { JSON: `{ "kind": "Policy", "apiVersion": "v1", "predicates": [ {"name": "MatchNodeSelector"}, {"name": "PodFitsResources"}, {"name": "PodFitsHostPorts"}, {"name": "HostName"}, {"name": "NoDiskConflict"}, {"name": "NoVolumeZoneConflict"}, {"name": "PodToleratesNodeTaints"}, {"name": "CheckNodeMemoryPressure"}, {"name": "CheckNodeDiskPressure"}, {"name": "CheckNodePIDPressure"}, {"name": "CheckNodeCondition"}, {"name": "MaxEBSVolumeCount"}, {"name": "MaxGCEPDVolumeCount"}, {"name": "MaxAzureDiskVolumeCount"}, {"name": "MaxCSIVolumeCountPred"}, {"name": "MatchInterPodAffinity"}, {"name": "GeneralPredicates"}, {"name": "CheckVolumeBinding"}, {"name": "TestServiceAffinity", "argument": {"serviceAffinity" : {"labels" : ["region"]}}}, {"name": "TestLabelsPresence",  "argument": {"labelsPresence"  : {"labels" : ["foo"], "presence":true}}} ],"priorities": [ {"name": "EqualPriority",   "weight": 2}, {"name": "ImageLocalityPriority",   "weight": 2}, {"name": "LeastRequestedPriority",   "weight": 2}, {"name": "BalancedResourceAllocation",   "weight": 2}, {"name": "SelectorSpreadPriority",   "weight": 2}, {"name": "NodePreferAvoidPodsPriority",   "weight": 2}, {"name": "NodeAffinityPriority",   "weight": 2}, {"name": "TaintTolerationPriority",   "weight": 2}, {"name": "InterPodAffinityPriority",   "weight": 2}, {"name": "MostRequestedPriority",   "weight": 2}, { "name": "RequestedToCapacityRatioPriority", "weight": 2, "argument": { "requestedToCapacityRatioArguments": { "shape": [ {"utilization": 0,  "score": 0}, {"utilization": 50, "score": 7} ] } }} ],"extenders": [{ "urlPrefix":        "/prefix", "filterVerb":       "filter", "prioritizeVerb":   "prioritize", "weight":           1, "bindVerb":         "bind", "enableHttps":      true, "tlsConfig":        {"Insecure":true}, "httpTimeout":      1, "nodeCacheCapable": true, "managedResources": [{"name":"example.com/foo","ignoredByScheduler":true}], "ignorable":true }] }`, ExpectedPolicy: schedulerapi.Policy{ Predicates: []schedulerapi.PredicatePolicy{ {Name: "MatchNodeSelector"}, {Name: "PodFitsResources"}, {Name: "PodFitsHostPorts"}, {Name: "HostName"}, {Name: "NoDiskConflict"}, {Name: "NoVolumeZoneConflict"}, {Name: "PodToleratesNodeTaints"}, {Name: "CheckNodeMemoryPressure"}, {Name: "CheckNodeDiskPressure"}, {Name: "CheckNodePIDPressure"}, {Name: "CheckNodeCondition"}, {Name: "MaxEBSVolumeCount"}, {Name: "MaxGCEPDVolumeCount"}, {Name: "MaxAzureDiskVolumeCount"}, {Name: "MaxCSIVolumeCountPred"}, {Name: "MatchInterPodAffinity"}, {Name: "GeneralPredicates"}, {Name: "CheckVolumeBinding"}, {Name: "TestServiceAffinity", Argument: &schedulerapi.PredicateArgument{ServiceAffinity: &schedulerapi.ServiceAffinity{Labels: []string{"region"}}}}, {Name: "TestLabelsPresence", Argument: &schedulerapi.PredicateArgument{LabelsPresence: &schedulerapi.LabelsPresence{Labels: []string{"foo"}, Presence: true}}}, }, Priorities: []schedulerapi.PriorityPolicy{ {Name: "EqualPriority", Weight: 2}, {Name: "ImageLocalityPriority", Weight: 2}, {Name: "LeastRequestedPriority", Weight: 2}, {Name: "BalancedResourceAllocation", Weight: 2}, {Name: "SelectorSpreadPriority", Weight: 2}, {Name: "NodePreferAvoidPodsPriority", Weight: 2}, {Name: "NodeAffinityPriority", Weight: 2}, {Name: "TaintTolerationPriority", Weight: 2}, {Name: "InterPodAffinityPriority", Weight: 2}, {Name: "MostRequestedPriority", Weight: 2}, { Name:   "RequestedToCapacityRatioPriority", Weight: 2, Argument: &schedulerapi.PriorityArgument{ RequestedToCapacityRatioArguments: &schedulerapi.RequestedToCapacityRatioArguments{ UtilizationShape: []schedulerapi.UtilizationShapePoint{ {Utilization: 0, Score: 0}, {Utilization: 50, Score: 7}, }}, }, }, }, ExtenderConfigs: []schedulerapi.ExtenderConfig{{ URLPrefix:        "/prefix", FilterVerb:       "filter", PrioritizeVerb:   "prioritize", Weight:           1, BindVerb:         "bind", // 1.11 restored case-sensitivity, but allowed either "BindVerb" or "bindVerb" EnableHTTPS:      true, TLSConfig:        &restclient.TLSClientConfig{Insecure: true}, HTTPTimeout:      1, NodeCacheCapable: true, ManagedResources: []schedulerapi.ExtenderManagedResource{{Name: v1.ResourceName("example.com/foo"), IgnoredByScheduler: true}}, Ignorable:        true, }}, }, }, } registeredPredicates := sets.NewString(factory.ListRegisteredFitPredicates()...) registeredPriorities := sets.NewString(factory.ListRegisteredPriorityFunctions()...) seenPredicates := sets.NewString() seenPriorities := sets.NewString() for v, tc := range schedulerFiles { fmt.Printf("%s: Testing scheduler confign", v) policy := schedulerapi.Policy{} if err := runtime.DecodeInto(latestschedulerapi.Codec, []byte(tc.JSON), &policy); err != nil { t.Errorf("%s: Error decoding: %v", v, err) continue } for _, predicate := range policy.Predicates { seenPredicates.Insert(predicate.Name) } for _, priority := range policy.Priorities { seenPriorities.Insert(priority.Name) } if !reflect.DeepEqual(policy, tc.ExpectedPolicy) { t.Errorf("%s: Expected:nt%#vnGot:nt%#v", v, tc.ExpectedPolicy, policy) } handler := utiltesting.FakeHandler{ StatusCode:   500, ResponseBody: "", T:            t, } server := httptest.NewServer(&handler) defer server.Close() client := clientset.NewForConfigOrDie(&restclient.Config{Host: server.URL, ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}}) informerFactory := informers.NewSharedInformerFactory(client, 0) if _, err := factory.NewConfigFactory(&factory.ConfigFactoryArgs{ SchedulerName:                  "some-scheduler-name", Client:                         client, NodeInformer:                   informerFactory.Core().V1().Nodes(), PodInformer:                    informerFactory.Core().V1().Pods(), PvInformer:                     informerFactory.Core().V1().PersistentVolumes(), PvcInformer:                    informerFactory.Core().V1().PersistentVolumeClaims(), ReplicationControllerInformer:  informerFactory.Core().V1().ReplicationControllers(), ReplicaSetInformer:             informerFactory.Apps().V1().ReplicaSets(), StatefulSetInformer:            informerFactory.Apps().V1().StatefulSets(), ServiceInformer:                informerFactory.Core().V1().Services(), PdbInformer:                    informerFactory.Policy().V1beta1().PodDisruptionBudgets(), StorageClassInformer:           informerFactory.Storage().V1().StorageClasses(), HardPodAffinitySymmetricWeight: v1.DefaultHardPodAffinitySymmetricWeight, DisablePreemption:              false, PercentageOfNodesToScore:       schedulerapi.DefaultPercentageOfNodesToScore, }).CreateFromConfig(policy); err != nil { t.Errorf("%s: Error constructing: %v", v, err) continue } } if !seenPredicates.HasAll(registeredPredicates.List()...) { t.Errorf("Registered predicates are missing from compatibility test (add to test stanza for version currently in development): %#v", registeredPredicates.Difference(seenPredicates).List()) } if !seenPriorities.HasAll(registeredPriorities.List()...) { t.Errorf("Registered priorities are missing from compatibility test (add to test stanza for version currently in development): %#v", registeredPriorities.Difference(seenPriorities).List()) } } </del>

Discussion:
PLEASE COORDINATE WITH SIG-SCHEDULING BEFORE WORKING ON THIS ISSUE. We want to avoid the situation where two people accidentally start work on the same fix. Main tracking issue: If you contributed in phase 1, please give others a chance before claiming this issue. You can also help out by reviewing the phase 2 PRs. The tests in ensure backwards compatibility with the types in . It makes more sense for these tests to live in that package. /sig scheduling /kind cleanup /help /good-first-issue
This request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : PLEASE COORDINATE WITH SIG-SCHEDULING BEFORE WORKING ON THIS ISSUE. We want to avoid the situation where two people accidentally start work on the same fix. The tests in ensure backwards compatibility with the types in . It makes more sense for these tests to live in that package. /kind cleanup /help /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I would like to take it and thanks
Hi! I am contributer and I would like to take it.
while you're working on do you mind letting take a crack at this one?
OK, go head
, thanks!
/lifecycle active for
Thanks for taking care of this one! :smiley:
You are wellcome