jiebi/CodeConvo huggingface dataset:
Change:
} encoder := f.JSONEncoder() <ins> decoder := f.Decoder(false) </ins> count := 0 err = r.Visit(func(info *resource.Info, err error) error {

Discussion:
kubectl create, delete, etc. can already take a List object. kubectl apply can take the list object when it does creation, but it gives an (ugly) error when it's configuring the objects. Then... expected: Actual:
what's you ?
0-alpha.5
Sounds like a bug. Are you interested in taking a look
sure I will take a look during this weekend.
I think the root cause is , the actually is , in the origin , is not , but after the , this object is nil. Would you like to double check this?
I'll take a look.
if you have make sure about this, please let me know. Thanks :)
Is there any ways we could get this into 1.2? It's actually making our config generation quite painful to have to make a separate file for every object. It looks like got pretty far? would you like to make a PR that we can review?
I don't see how. It could have made 1.2 if a PR had been sent within a few days of the issue being filed.
I unassigned all issues assigned to you. Please only assign issues that are actively being worked on, so that others can know which issues are available to be picked up.
My apologies. If I'm not mistaken, this issue was filed after the code freeze for 1.2. I didn't realize that it was time critical or that it could make the release at that time. However, I should have asked. Sorry for the inconvenience. Thank you. I still plan to address those issues for the next release, as discussed, but will assign each one to myself as I work on it.
I created which fixes this. I'm really hoping we can get this into 1.2 since it's a pretty small, isolated fix but a pretty big bug that is complicating our config generation system. Let me know what else I can do to help.
Thanks for the PR. We're short on reviewer bandwidth at the moment. I assigned it to Clayton for review or delegation.
Change:
image: e2e-node-containervm-v20160321-image project: kubernetes-node-e2e-images gci-family: <del> image_regex: gci-dev-54-8743-3-0 </del> <ins> image_regex: gci-dev-55-8820-0-0 </ins> project: google-containers metadata: "user-data<test/e2e_node/jenkins/gci-init.yaml"

Discussion:
The upgraded version of container-vm (gci) has significant performance regressions with localhost networking when compared to its previous versions. is working on making gci kernel fixes to resolve this issue. This issue is meant to track the GCI fix from release 1.4 perspective. The fix for this issue will result in upgrading the gci version pinned to release 1.4 branch. ETA: <TBDStatus: Yellow
can you update the ETA for fixing this issue?
cc for release tracking purposes.
is this a release blocker (why?) or are we aiming for a minor release?
It is a blocker because it causes about 70% drop in throughput which is a significant regression from a k8s on GCP user perspective.
The kernel fix should get merged in GCI kernel today, and hopefully we will be able to release a GCI version tomorrow that includes the fix.
Hmm, I somehow fail to see why a kubernetes release needs to be blocked on a bug fix going into one os the kubernetes release is being deployed on top of, but that's just my opinion
I get your point of view. But, k8s on GCE cannot have serious user-facing issues. The distro is just an implementation detail, but an important one. If we include first-class support for additional distros like ubuntu, debian, etc. in the future, we will have to make the very same priority calls. At the end of the day, the release needs to work for most users in most environments. , Prashanth B wrote:
I think gci related issues shouldn't blocker OSS k8s 1.4 release. I also agreed that k8s on GCE cannot have serious user-facing issues, but that can be resolved by reverting the changes of making GCE node on GCI default. I am not suggesting that we do that now, but I do suggest we have the summary of the entire issue (not only this particular one) on GCI on node, and deeply understand the risk, then make the final decision. On another hand, we are still planning to enable GCI on node default between 1.4 and 1.5 time framework. cc/
Change:
`, }, { <ins> name: "nil container metrics", summary: &statsapi.Summary{ Pods: []statsapi.PodStats{ { PodRef: statsapi.PodReference{ Name:      "pod_a", Namespace: "namespace_a", }, Containers: []statsapi.ContainerStats{ { Name:      "container_a", StartTime: metav1.NewTime(staticTimestamp.Add(-30 * time.Second)), CPU: &statsapi.CPUStats{ Time:                 testTime, UsageCoreNanoSeconds: nil, }, Memory: &statsapi.MemoryStats{ Time:            testTime, WorkingSetBytes: nil, }, }, }, }, { PodRef: statsapi.PodReference{ Name:      "pod_b", Namespace: "namespace_b", }, Containers: []statsapi.ContainerStats{ { Name:      "container_a", StartTime: metav1.NewTime(staticTimestamp.Add(-10 * time.Minute)), CPU: &statsapi.CPUStats{ Time:                 testTime, UsageCoreNanoSeconds: uint64Ptr(10000000000), }, Memory: &statsapi.MemoryStats{ Time:            testTime, WorkingSetBytes: uint64Ptr(1000), }, }, }, }, }, }, summaryErr: nil, expectedMetrics: ` # HELP container_cpu_usage_seconds_total [ALPHA] Cumulative cpu time consumed by the container in core-seconds # TYPE container_cpu_usage_seconds_total counter container_cpu_usage_seconds_total{container="container_a",namespace="namespace_b",pod="pod_b"} 10 1624396278302 # HELP container_memory_working_set_bytes [ALPHA] Current working set of the container in bytes # TYPE container_memory_working_set_bytes gauge container_memory_working_set_bytes{container="container_a",namespace="namespace_b",pod="pod_b"} 1000 1624396278302 # HELP container_start_time_seconds [ALPHA] Start time of the container since unix epoch in seconds # TYPE container_start_time_seconds gauge container_start_time_seconds{container="container_a",namespace="namespace_a",pod="pod_a"} 1.6243962483020916e+09 1624396248302 container_start_time_seconds{container="container_a",namespace="namespace_b",pod="pod_b"} 1.6243956783020916e+09 1624395678302 # HELP scrape_error [ALPHA] 1 if there was an error while getting container metrics, 0 otherwise # TYPE scrape_error gauge scrape_error 0 `, }, { </ins> name: "arbitrary pod metrics", summary: &statsapi.Summary{ Pods: []statsapi.PodStats{

Discussion:
kubelet panic when accessing metrics/resource endpoint kubelet log kubelet works fine access metrics/resource endpoint of kubelet No response <details</details<details</details<details</details<details</details<detailsINFO[2022-07-14 05:36:21.474173892Z] Starting CRI-O, version: 1.23.0, git: (dirty) Version: 1.23.0 GitCommit: GitTreeState: dirty BuildDate: 1980-01-01T00:00:00Z GoVersion: go1.17.4 Compiler: gc Platform: linux/amd64 Linkmode: static BuildTags: apparmor, excludegraphdriverdevicemapper, seccomp, selinux SeccompEnabled: true AppArmorEnabled: true </details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig node
Change:
CROSS_BUILD_COPY qemu-QEMUARCH-static /usr/bin/ <ins> # WARNING: Please note that the script below removes the security packages from arm64 and ppc64el images # as they do not exist anymore in the debian repositories for jessie. So we do not recommend using this # image for any production use and limit use of this image to just test scenarios. COPY fixup-apt-list.sh / RUN ["/fixup-apt-list.sh"] </ins> RUN apt-get -q update &&  apt-get install -y dnsutils &&  apt-get clean

Discussion:
[X] "goproxy" to "" [X] "jessie-dnsutils" to "" [X] "redis" to "" [X] "serve-hostname" to ""
/assign /assign
we can use to iterate
/sig testing
tip for uploading is here -
should be published to now. I'm rerunning for the other 3 images.
I think the and images were published successfully this time. :
can you please try ?
should now be published too thanks to PR.
related to
Change:
"github.com/coreos/go-etcd/etcd" ) <ins> type testRESTStrategy struct { runtime.ObjectTyper api.NameGenerator namespaceScoped     bool allowCreateOnUpdate bool } func (t *testRESTStrategy) NamespaceScoped() bool     { return t.namespaceScoped } func (t *testRESTStrategy) AllowCreateOnUpdate() bool { return t.allowCreateOnUpdate } func (t *testRESTStrategy) ResetBeforeCreate(obj runtime.Object) {} func (t *testRESTStrategy) Validate(obj runtime.Object) errors.ValidationErrorList { return nil } func (t *testRESTStrategy) ValidateUpdate(obj, old runtime.Object) errors.ValidationErrorList { return nil } func hasCreated(t *testing.T, pod *api.Pod) func(runtime.Object) bool { return func(obj runtime.Object) bool { actualPod := obj.(*api.Pod) if !api.Semantic.DeepDerivative(pod.Status, actualPod.Status) { t.Errorf("not a deep derivative %#v", actualPod) return false } return api.HasObjectMetaSystemFieldValues(&actualPod.ObjectMeta) } } </ins> func NewTestGenericEtcdRegistry(t *testing.T) (*tools.FakeEtcdClient, *Etcd) { f := tools.NewFakeEtcdClient(t) f.TestIndex = true h := tools.EtcdHelper{f, testapi.Codec(), tools.RuntimeVersionAdapter{testapi.MetadataAccessor()}} <ins> strategy := &testRESTStrategy{api.Scheme, api.SimpleNameGenerator, true, false} </ins> return f, &Etcd{ <del> NewFunc:      func() runtime.Object { return &api.Pod{} }, NewListFunc:  func() runtime.Object { return &api.PodList{} }, EndpointName: "pods", KeyRootFunc:  func(ctx api.Context) string { return "/registry/pods" }, </del> <ins> NewFunc:        func() runtime.Object { return &api.Pod{} }, NewListFunc:    func() runtime.Object { return &api.PodList{} }, EndpointName:   "pods", CreateStrategy: strategy, UpdateStrategy: strategy, KeyRootFunc:    func(ctx api.Context) string { return "/registry/pods" }, </ins> KeyFunc: func(ctx api.Context, id string) (string, error) { return path.Join("/registry/pods", id), nil }, <del> Helper: h, </del> <ins> ObjectNameFunc: func(obj runtime.Object) (string, error) { return obj.(*api.Pod).Name, nil }, Helper:         h, </ins> } }

Discussion:
The use of AtomicUpdate by genericetcd doesn't handle conflicting writes by rejecting that to a user. It should. Eventually, we may want to hide write conflicts to /pods when status has changed, and to spec when /pods/status changes, but that requires us to have two version counters and that's not worth the effort. Fix incoming.
Also we need a unit/integration test for this.
Change:
$CLOUDCFG delete services/redismaster $CLOUDCFG delete pods/redis-master-2 <del> POD_LIST_2=$($CLOUDCFG -json list pods | jq ".items[].id") </del> <ins> POD_LIST_2=$($CLOUDCFG '-template={{range.Items}}{{.ID}} {{end}}' list pods) </ins> echo "Pods running after shutdown: ${POD_LIST_2}" exit 0

Discussion:
We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.
Change:
return clusterName } <del> func (az *Cloud) getLoadBalancerRuleName(service *v1.Service, protocol v1.Protocol, port int32, subnetName *string) string { </del> <ins> func (az *Cloud) getLoadBalancerRuleName(service *v1.Service, protocol v1.Protocol, port int32) string { </ins> prefix := az.getRulePrefix(service) <del> if subnetName == nil { return fmt.Sprintf("%s-%s-%d", prefix, protocol, port) </del> <ins> ruleName := fmt.Sprintf("%s-%s-%d", prefix, protocol, port) subnet := subnet(service) if subnet == nil { return ruleName </ins> } <del> return fmt.Sprintf("%s-%s-%s-%d", prefix, *subnetName, protocol, port) </del> <ins> // Load balancer rule name must be less or equal to 80 characters, so excluding the hyphen two segments cannot exceed 79 subnetSegment := *subnet if len(ruleName)+len(subnetSegment)+1 > loadBalancerRuleNameMaxLength { subnetSegment = subnetSegment[:loadBalancerRuleNameMaxLength-len(ruleName)-1] } return fmt.Sprintf("%s-%s-%s-%d", prefix, subnetSegment, protocol, port) </ins> } func (az *Cloud) getSecurityRuleName(service *v1.Service, port v1.ServicePort, sourceAddrPrefix string) string {

Discussion:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When the specified internal LB uses a subnet with longer name, the LB configuration will fail with following error: What you expected to happen: When constructing the frontend IP configuration name and the load balancing rules name, the subnet name should be truncated if too long. How to reproduce it (as minimally and precisely as possible): Use a subnet that has long name (70 charactors) and create ILB service. Anything else we need to know?: Environment: Kubernetes version (use ): 1.15 Cloud provider or hardware configuration: azure OS (e.g: ): Ubuntu 16.04 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig cloud-provider /area provider/azure /assign
Change:
pods = append(pods, pod) } <del> events, _ := d.Events(namespace).Search(node) </del> <ins> var events *api.EventList if ref, err := api.GetReference(node); err != nil { glog.Errorf("Unable to construct reference to '%#v': %v", node, err) } else { // TODO: We haven't decided the namespace for Node object yet. ref.UID = types.UID(ref.Name) events, _ = d.Events("").Search(ref) } </ins> return describeNode(node, pods, events) }

Discussion:
now shows NodePhase, NodeCondition, etc. information from NodeStatus. It should also show related events like what we did for pods.
Change:
return nil, errors } <ins> // HttpProxyCheck checks if https connection to specific host is going // to be done directly or over proxy. If proxy detected, it will return warning. type HttpProxyCheck struct { Proto string Host  string Port  int } func (hst HttpProxyCheck) Check() (warnings, errors []error) { url := fmt.Sprintf("%s://%s:%d", hst.Proto, hst.Host, hst.Port) req, err := http.NewRequest("GET", url, nil) if err != nil { return nil, []error{err} } proxy, err := http.DefaultTransport.(*http.Transport).Proxy(req) if err != nil { return nil, []error{err} } if proxy != nil { return []error{fmt.Errorf("Connection to %q uses proxy %q. If that is not intended, adjust your proxy settings", url, proxy)}, nil } return nil, nil } </ins> func RunInitMasterChecks(cfg *kubeadmapi.MasterConfiguration) error { // TODO: Some of these ports should come from kubeadm config eventually: checks := []PreFlightCheck{

Discussion:
Environment: VMware CentOS Linux release 7.2.1511 (Core) kernel: 3.10.0-327.36.1.el7.x8664 Installed packages: kubeadm.x8664 1.5.0-0.alpha.0.1534.gcf7301f kubectl.x8664 1.4.0-0 kubelet.x8664 1.4.0-0 kubernetes-cni.x8664 0.3.0.1-0. docker-engine.x8664 1.11.2- docker-engine- 1.12.1- What happened: kubeadm init hangs indefintely after: kubeadm init <master/tokensgenerated token: "." <master/pkicreated keys and certificates in "/etc/kubernetes/pki" <util/kubeconfigcreated "" <util/kubeconfigcreated "" <master/apiclientcreated API client configuration <master/apiclientcreated API client, waiting for the control plane to become readykubeadm init What you expected to happen: Master node initialize Anything else do we need to know: Only the kubeadm and kublet processes are running. When I do docker ps no containers are running. If i type docker images the only image that has been downloaded are: I've also tried: kubeadm init --api-advertise-addresses but with the same outcome (followed the clean-up at ) Im behind a firewall so I'm using proxy settings for docker. I have confirmed I can reach images on docker hub and google cloud registry
will download the required binaries viz etcd. When you are behind firewall kubeadm will hang/wait forever to download the binaries. I dont know whether it is addressed correctly in kubeadm implementation. I am also facing the same issue and waiting for the resolution.
Thx, I suspected it to be some firewall issue. Do you know if there's a way to add httpsproxy & httpproxy settings to kubeadm?
Kubeadm doesn't seem to pick proxy environment variables. I am looking at recompiling with proxy support may work. But I dont know how to do that. Waiting for updates about proxy
This issue same as Lets join there. The solution mentioned there may work.

You can try kubeadm with patch applied from PR : It works at least in my environment behind restrictive proxy.
thanks, I will look into it
Change:
When building final release tars, they are first staged into `_output/release-stage` before being tar'd up and put into `_output/release-tars`. <ins> ## Proxy Settings If you are behind a proxy, you need to edit `build/build-image/Dockerfile` and add proxy settings to execute command in that container correctly. example: `ENV http_proxy http://username:password@proxyaddr:proxyport` `ENV https_proxy http://username:password@proxyaddr:proxyport` Besides, to avoid integration test touch the proxy while connecting to local etcd service, you need to set `ENV no_proxy 127.0.0.1` </ins> ## TODOs These are in no particular order

Discussion:
I was tring to build kubernetes following But failed for some times. I looked into the error and found it's because I'm behind a proxy. Then I edited the dockerfile under build/build-image/ folder, some proxy settings into it and solved the problem. Though it may not be a problem for experienced guys. Would it be better for the beginners to describe these detaied settings in the document? Can I add the proxy settings I found into the doc? I'm new to kubernetes and need your opinion.
Yes, please, by all means. Please describe your problem and the solution in the doc and send a PR.
Change:
} } <ins> // Finished writing into the file, close it, so we can delete it later. err = file.Close() assert.NoErrorf(t, err, "could not close file.") </ins> time.Sleep(20 * time.Millisecond) // Make the function ReadLogs end. fakeRuntimeService.Lock()

Discussion:
The test is failing on Windows [0]: The idea of the test is to check that kubelet still follows and reads the Container Logs after a Log Rotation occured. However, because the followed file is open, it cannot be renamed, and thus, the container logs cannot be rotated. This issue could be prevented if the file would be opened with the [0] [1] Kubelet should not block container log rotation. Run the test ` is failing on Windows. /sig windows /kind bug /kind failing-test latest, master. This unit test has been failing for a while. N/A Windows nodes </detailsN/A N/A N/A
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/kind failing-test /sig windows
Change:
if err != nil { klog.V(3).Infof("Unable to check for quota support on %s: %s", dir, err.Error()) } else if hasQuotas { <del> _, err := fsquota.GetQuotaOnDir(ed.mounter, dir) if err != nil { klog.V(4).Infof("Attempt to check quota on dir %s failed: %v", dir, err) // this is not a fatal error so return nil return nil } </del> klog.V(4).Infof("emptydir trying to assign quota %v on %s", mounterSize, dir) if err := fsquota.AssignQuota(ed.mounter, dir, ed.pod.UID, mounterSize); err != nil { klog.V(3).Infof("Set quota on %s failed %s", dir, err.Error())

Discussion:
I have kubernetes 1.24.7. I tried to use on formated volume. It works until first reboot. After reboot, I get messages: I expect that project quota can be assigned even after reboot. Use xfs for /var/lib/containerd with discard,quota,prjquota No response <details</details<detailsbaremetal </details<details</details<details</details<detailsrke2 </details<details</details
/sig node Can this be reproduced? Can this pod be recreated correctly if you force delete the pod?
/triage accepted
It can be reproduced. Pod is created if I remove . I can test force delete.
/assign we are looking into gate to understand if we need to keep it or deprecate it.
If I force delete pod, it does not start again:
/assign Let me check on the latest code with the fix
Change:
return "", "", err } <del> diskController = getSCSIController(vmDevices, vs.cfg.Disk.SCSIControllerType) if diskController == nil { </del> <ins> scsiController = getSCSIController(vmDevices, vs.cfg.Disk.SCSIControllerType) if scsiController == nil { </ins> glog.Errorf("cannot find SCSI controller in VM - %v", err) // attempt clean up of scsi controller cleanUpController(newSCSIController, vmDevices, vm, ctx)

Discussion:
vSphere cloud provider volume plugin attach disk limits the number of volumes because of two issues: new SCSI controller is only created when one does not exist. A new controller should be when required and limit not reached. disk will fail when attaching disk to slot 7 on controller. Slot 7 on SCSI controller is reserved and therefore should be skipped. This issue has been brought up in Govmomi library .
Change:
) evictionsNumber = metrics.NewCounterVec( &metrics.CounterOpts{ <ins> Subsystem:         nodeControllerSubsystem, Name:              evictionsNumberKey, Help:              "Number of Node evictions that happened since current instance of NodeController started, This metric is replaced by node_collector_evictions_total.", DeprecatedVersion: "1.24.0", StabilityLevel:    metrics.ALPHA, }, []string{"zone"}, ) evictionsTotal = metrics.NewCounterVec( &metrics.CounterOpts{ </ins> Subsystem:      nodeControllerSubsystem, <del> Name:           evictionsNumberKey, </del> <ins> Name:           evictionsTotalKey, </ins> Help:           "Number of Node evictions that happened since current instance of NodeController started.", <del> StabilityLevel: metrics.ALPHA, </del> <ins> StabilityLevel: metrics.STABLE, </ins> }, []string{"zone"}, )

Discussion:
I would like to propose the graduation of the metric from alpha to stable. The metric has been stable for 2 years now.
/sig api-machinery /sig instrumentation
I am willing to do all StabilityLevels from alpha to stable? Is that right?
/assign
- The request is to have the stability level for the metric graduate to stable. If there are other metrics you want to do at the same time that's a bonus, but not part of the request in this issue.
/sig node /remove-sig api-machinery /cc
To be promoted to stable, the metrics would need to be renamed from to in order to follow Prometheus best practices as well as sig-instrumentation naming guidelines.
/cc
/assign
/triage accepted
Change:
// Test purposeful shutdown go manager.watchControllers() <del> time.Sleep(10 * time.Millisecond) </del> <ins> fakeEtcd.WaitForWatchCompletion() </ins> fakeEtcd.WatchStop <- true <del> time.Sleep(10 * time.Millisecond) </del> // Did everything shut down? if _, open := <-fakeEtcd.WatchResponse; open {

Discussion:
Detected by
Create a Pod as follows: Name: jenkins Using image: jenkins In a new Kubenetes namespace named website-frontend kubectl create ns website-frontend apiVersion: v1 kind: Pod metadata: name: jenkins namespace: website-frontend spec: containers: name: jenkins image: jenkins kubectl create -f