jiebi/CodeConvo huggingface dataset:
Change:
}, expectErr: false, }, <ins> "test-valid-use-no-email": { params: map[string]interface{}{ "name":            "foo", "docker-server":   server, "docker-username": username, "docker-password": password, }, expected: &api.Secret{ ObjectMeta: metav1.ObjectMeta{ Name: "foo", }, Data: map[string][]byte{ api.DockerConfigKey: secretDataNoEmail, }, Type: api.SecretTypeDockercfg, }, expectErr: false, }, </ins> "test-missing-required-param": { params: map[string]interface{}{ "name":            "foo",

Discussion:
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): Is this a BUG REPORT or FEATURE REQUEST? (choose one): <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: What happened: When I create a docker registry secret, the is also a MUST, I think we should make this parameter as optional as there is no need always put when creating a docker registry secret. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know:
Agree it should not be required
Did this change get reverted? I do not see as optional on stable.
I feel that this code should be changed because "--docker-email flag" is no longer required.
error: flag docker-email is required. On kubenetes 1.10.3, the above error message still exists
The field is still required. This is very frustrating as does not require an email but Kubernetes does? Is there a good reason for this?
Why is this closed? As far as I can see it is still required?
Change:
<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package testing import ( "reflect" ) // ValueFuzz recursively changes all basic type values in an object. Any kind of references will not // be touch, i.e. the addresses of slices, maps, pointers will stay unchanged. func ValueFuzz(obj interface{}) { valueFuzz(reflect.ValueOf(obj)) } func valueFuzz(obj reflect.Value) { switch obj.Kind() { case reflect.Array: for i := 0; i < obj.Len(); i++ { valueFuzz(obj.Index(i)) } case reflect.Slice: if obj.IsNil() { // TODO: set non-nil value } else { for i := 0; i < obj.Len(); i++ { valueFuzz(obj.Index(i)) } } case reflect.Interface, reflect.Ptr: if obj.IsNil() { // TODO: set non-nil value } else { valueFuzz(obj.Elem()) } case reflect.Struct: for i, n := 0, obj.NumField(); i < n; i++ { valueFuzz(obj.Field(i)) } case reflect.Map: if obj.IsNil() { // TODO: set non-nil value } else { for _, k := range obj.MapKeys() { // map values are not addressable. We need a copy. v := obj.MapIndex(k) copy := reflect.New(v.Type()) copy.Elem().Set(v) valueFuzz(copy.Elem()) obj.SetMapIndex(k, copy.Elem()) } // TODO: set some new value } case reflect.Func: // ignore, we don't have function types in our API default: if !obj.CanSet() { return } switch obj.Kind() { case reflect.String: obj.SetString(obj.String() + "x") case reflect.Bool: obj.SetBool(!obj.Bool()) case reflect.Float32, reflect.Float64: obj.SetFloat(obj.Float()*2.0 + 1.0) case reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64, reflect.Int: obj.SetInt(obj.Int() + 1) case reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uint: obj.SetUint(obj.Uint() + 1) default: } } } </ins>

Discussion:
The apimachinery roundtripping test does not ensure that deep copies work. We need to provide a deep copy test that makes sure we don't end up with shallow copies.
I looked into gofuzz some days ago and noticed that it does not support value-only fuzzing that preserves object structure (= does not change pointer values). So we need something clever, maybe reflection based here. Any other idea?
Change:
ipt := iptablestest.NewFake() fp := NewFakeProxier(ipt) metrics.RegisterMetrics() <ins> defer legacyregistry.Reset() </ins> // Create initial state var svc2 *v1.Service

Discussion:
When unit tests in are invoked with 1, it fails Unit tests should work for any . This is important for troubleshooting flaking tests. Discovered when I tried to add parallel execution as described in master N/A N/A N/A N/A N/A
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig network /area kube-proxy
/cc
Change:
"k8s.io/apimachinery/pkg/api/resource" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" <ins> "k8s.io/apimachinery/pkg/runtime" </ins> "k8s.io/apimachinery/pkg/util/intstr" "k8s.io/client-go/kubernetes" "k8s.io/client-go/kubernetes/fake"

Discussion:
Create a deployment as described in section, and run 'kubectl describe deploy/testWhat happened: shows , while shows the current replicaset infomation What you expected to happen: shows the current replicaset infomation, while shows How to reproduce it (as minimally and precisely as possible): Create a deployment as follows, and wait its pod started. Then, run 'kubectl describe deploy/test Anything else we need to know?: Environment: Kubernetes version (use ): kubectl of 1.14+(I did not try older versions) Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig cli
/assign
Ok, can confirm here. With the old code, during a rollout the data is shown at OldReplicaSets (both the old and new RS) while with the patch during the rollout the NewReplicaSet contains the net one and the Old the old one ( obvious here) while the old exists. I'll make some more tests here and check if is there anything else in your PR that needs better verification, otherwise wer can follow with it! Thank you!
/triage accepted
Change:
) const ( <del> configFile             = "config/performance-config.yaml" createNodesOpcode      = "createNodes" createNamespacesOpcode = "createNamespaces" createPodsOpcode       = "createPods" createPodSetsOpcode    = "createPodSets" churnOpcode            = "churn" barrierOpcode          = "barrier" </del> <ins> configFile               = "config/performance-config.yaml" createNodesOpcode        = "createNodes" createNamespacesOpcode   = "createNamespaces" createPodsOpcode         = "createPods" createPodSetsOpcode      = "createPodSets" churnOpcode              = "churn" barrierOpcode            = "barrier" extensionPointsLabelName = "extension_point" </ins> // Two modes supported in "churn" operator.

Discussion:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : run got the below error message, We should provide the metric data for different extension points from the metric of "schedulerframeworkextensionpointdurationseconds" Why is this needed: Those metrics have been removed by this commit - Those metrics are deprecated cause it is suggested to use - , but simply remove those metrics definitely is not a nice way to address the issue. /sig scheduling
/triage accept
The label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /triage accept Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/triage accepted
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale
/remove-lifecycle stale
Change:
fi for g in "${codegens_to_run[@]}"; do <del> "codegen::${g}" "${flags_to_pass[@]}" </del> <ins> # The array-syntax abomination is to accommodate older bash. "codegen::${g}" "${flags_to_pass[@]:+"${flags_to_pass[@]}"}" </ins> done

Discussion:
I am working on a PR where I am removing some legacy code from a API. I believe I have to run some scripts to generate code. When I run I get the following error: I expect the script to work and run without error. Run hack/update- or run I am on the latest build. <details</details<details</details<details</details<details</details<details</details<details</details
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
cc are you synced to HEAD of master? what version of bash are you running?
I am synced to HEAD of master and my bash version is version 4.2.46(2).
Pretty sure identified it correctly as a bash version issue. I ran into this issue and it was due to using an older bash. I know that 4.2.46 (which is used in AL2) is too old, but I'm not sure exactly what the minimum version is. If you are using AL2 for development, this will drop in a compatible version:
/kind support
Let me see if there's a way to make old-bash shut up. Sadly I do not have an old version to try against - - are you willing to type commands into your shell for me?
Yep, you just caught me before I purged my old environment with suggestions.
would a slack conversation be easier?
maybe but I am juggling meetings :)
There are a few problems I ran into before just deciding to upgrade to bash v5, but I think this initial thing was a bug fixed in bash 4.4+: From, when the nounset option is enabled no longer throws an unbound variable error. So on 4.2, this fails:
working on a patch
Change:
go_library( name = "go_default_library", <del> srcs = ["yaml.go"], </del> <ins> srcs = [ "meta.go", "yaml.go", ], </ins> importmap = "k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/serializer/yaml", importpath = "k8s.io/apimachinery/pkg/runtime/serializer/yaml", deps = [ "//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/util/yaml:go_default_library", <ins> "//vendor/sigs.k8s.io/yaml:go_default_library", </ins> ], )

Discussion:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add an external MetaFactory that allows for serializing multiple YAML (or JSON) files in kubeadm. The logic of marshalling YAML should be factored out from to . Why is this needed: This will allow processing component configs containing multiple documents per file. Additionally, an out-of-tree library would allow sharing this functionality with other components.
I will try work on this as carry-on from /sig cluster-lifecycle /cc
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/remove-lifecycle stale
Change:
diskURL := "https://foo.blob./vhds/bar.vhd" err := b.DeleteVolume(diskURL) expectedErr := fmt.Errorf("no key for storage account foo, err Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: %w", error(nil)) <del> assert.Equal(t, expectedErr, err) </del> <ins> assert.EqualError(t, err, expectedErr.Error()) </ins> err = b.DeleteVolume(diskURL) <del> assert.Equal(t, expectedErr, err) </del> <ins> assert.EqualError(t, err, expectedErr.Error()) </ins> mockSAClient.EXPECT().ListKeys(gomock.Any(), b.common.resourceGroup, "foo").Return(storage.AccountListKeysResult{ Keys: &[]storage.AccountKey{

Discussion:
Our internal CI job that runs k8s unit tests with master golang. TestCreateVolume TestDeleteVolume Probably after the master golang GITCOMMIT= Change: https://go- No response No response /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
^^
Updates: Observed that with the latest version of Go dev branch, the underlying type is no longer fmt.WrapError, but is rather errors.ErrorString when a nil error is using the verb is used. Both, the expected error and the returned error had a similar type until go 1.19 - , which now switched to when a error is wrapped with the verb. The changes are made in where the earlier used is now replaced with to check for error equality. The changes have been tested with both go 1.19 and go 1.20-devel and works as intended.
Change:
SystemPodsStartup:         10 * time.Minute, NodeSchedulable:           30 * time.Minute, SystemDaemonsetStartup:    5 * time.Minute, <ins> NodeNotReady:              3 * time.Minute, </ins> } // TimeoutContext contains timeout settings for several actions.

Discussion:
We need to explore how DRA interacts with One likely outcome is that the DRA helper code watches for nodes with the special label and helps DRA drivers clean up. /sig node
/assign
/triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29
The label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/triage accepted
Here's a test that was written for volumes:
Thank you. I’ve found it last week. Unfortunately kind image doesn’t have ssh, so stopping kubelet is not possible the way this test does. I’ve found another solution.
I was able to simulate non-graceful node shutdown by running . It turned out that after adding tent, all node pods are deleted by the GC controller and the resource claim controller successfully deallocated the resource. So, it looks like a non-graceful shutdown is handled correctly and no code changes are required. However, the fact that can potentially be called without calling should be explained in the DRA KEP, so that DRA plugin authors will be aware of this. I'll add an explanation of handling non-graceful node shoutdown to the and add a correspondent e2e test case to the DRA e2e test suite.
KEP update PR: E2E PR:
Change:
utilipvs "k8s.io/kubernetes/pkg/util/ipvs" utilsysctl "k8s.io/kubernetes/pkg/util/sysctl" utilexec "k8s.io/utils/exec" <del> "golang.org/x/sys/unix" </del> ) const (

Discussion:
https://k8s- https://k8s- cc: /priority failing-test
Sorry, but I will fix it ASAP.
/assign
PR is already sent. Wating for CI report...
Change:
Logf("Warning: kubectl exec encountered i/o timeout.nerr=%vnstdout=%vnstderr=%v)", err, string(stdOutBytes), string(stdErrBytes)) continue } <ins> if strings.Contains(strings.ToLower(string(stdErrBytes)), "container not found") { // Retry on "container not found" errors Logf("Warning: kubectl exec encountered container not found.nerr=%vnstdout=%vnstderr=%v)", err, string(stdOutBytes), string(stdErrBytes)) time.Sleep(2 * time.Second) continue } </ins> } return stdOutBytes, stdErrBytes, err

Discussion:
The following tests failed multiple times both in GCE and GKE suites: The error message is the same: Logs:
Assigning for fix or triage. cc
I can work on this, as I am writing tests for openstack in .
It would be great!
Huamin, Thanks for jumping on this. Please consider it priority - flaky tests are killing us, and if this turns out to be real, we need it fixed. , Huamin Chen wrote:
sure
These two tests are so flaky that they will block the merge queue for over half of the time it takes to merge a fix. If you think the fix will take more than a day, I'd suggest moving these to the flaky suite until they're fixed.
I'd suggest tagging them flaky ASAP. Whenever they get fixed they can be untagged.
I am okay with moving these to the flaky suite until we can get some focus on it.
PR is , will likely need a manual merge since the SQ is so blocked.
Hang on this looks like it was broken by a PR merged on Sunday: Test Run and earlier are Green. Test Run (after this PR was merged) are Flaky. CC I'll prepare a roll back.
good catch, i'll take a look at the gce attacher.
give me some moments to figure out a fix
I think the appropriate thing to do here was to move them into the flaky suite or revert the offending PR right away, not wait several hours for the fix to pass code review and CI.
Agreed, this could've been handled better.
PR marking tests as flaky () has been merged. will follow up with his PR () to see if he can fix the test, if so, he will move the tests back out of flaky.
Occurrences tracked automatically in . I don't care if you leave this one open too.
Closing this in favor autogenerated
Change:
if err != nil { return nil, err } <del> err = balancer.CreateTCPLoadBalancer(srv.ID, zone, srv.Port, hosts) </del> <ins> err = balancer.CreateTCPLoadBalancer(srv.ID, zone.Region, srv.Port, hosts) </ins> if err != nil { return nil, err }

Discussion:
Comments that the PR bot adds solely to trigger email notification of a label change, should be immediately deleted by the bot after it adds them. I have no idea what team to assign this to... cc/
, David Oppenheimer wrote:
(Motivation, of course, is to avoid having PR threads that are 90% bot comments...)
should really be an issue over in that's where (some of) the bots live. Lets make a list of which comments we want deleted immediately. [x] Label size. [x] Needs rebase. [x] test this stale CI [x] test this pending CI [x] PR changed after LGTM, removing LGTM. [x] Comment about blocking based on the paths touched (old docs) [x] unapproved cherrypick comment [x] cherrypicks must set a milestone [x] ok to test from bot I don't want to make it all comments. There are way too many times people have asked me "Why did the bot add 'do-not-merge'?" and I can just link them the comment 2 lines above which tells exactly why....
"Test this" with an issue is also useful, isn't it? On Apr 7, 2016 6:30 PM, "Eric Paris" wrote:
OK to test Add to whitelist On Apr 7, 2016 6:30 PM, "Eric Paris" wrote:
I was envisioning deleting the by the bot. (every 48 hours after LGTM, when retesting right before merge) not those by users (with an issue) After LGTM the bot will add , that one I can remove. The request to comes from the jenkins bot. And in that I am clueless...
any interest in a review (I'm trying to not just self merge all my own bot changes). This deleted hundreds and hundreds of comments.
Looks like reviewed it since your last message:

The contains instructions for downloading kubectl. The doesn't contain these instructions but it should if it's now the recommended way of running Kubernetes locally.
+1 Just ran into this.
cc
By the way, we encourage anyone to propose improvements/fixes to docs. You can do so pretty easily by clicking the pencil icon in the top right corner of every page of
kubectl download instructions to the guide in
Change:
Namespace:      namespace, Subsystem:      subsystem, Name:           "compilation_duration_seconds", <ins> Help:           "CEL compilation time in seconds.", </ins> StabilityLevel: metrics.ALPHA, }), evaluationTime: metrics.NewHistogram(&metrics.HistogramOpts{ Namespace:      namespace, Subsystem:      subsystem, Name:           "evaluation_duration_seconds", <ins> Help:           "CEL evaluation time in seconds.", </ins> StabilityLevel: metrics.ALPHA, }), }

Discussion:
Both and are missing help texts.
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign