Change:
<ins> /* Copyright 2024 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package storage import ( "context" "fmt" "math/rand" "time" storagev1 "k8s.io/api/storage/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/types" utilrand "k8s.io/apimachinery/pkg/util/rand" "k8s.io/client-go/util/retry" "k8s.io/kubernetes/test/e2e/framework" "k8s.io/kubernetes/test/e2e/storage/utils" "github.com/onsi/ginkgo/v2" "github.com/onsi/gomega" ) var _ = utils.SIGDescribe("VolumeAttachment", func() { f := framework.NewDefaultFramework("volumeattachment") ginkgo.Describe("Conformance", func() { ginkgo.It("should run through the lifecycle of a VolumeAttachment", func(ctx context.Context) { vaClient := f.ClientSet.StorageV1().VolumeAttachments() firstVA, vaNodeName := createVolumeAttachment(f, ctx) ginkgo.By(fmt.Sprintf("Get VolumeAttachment %q on node %q", firstVA, vaNodeName)) retrievedVA, err := vaClient.Get(ctx, firstVA, metav1.GetOptions{}) framework.ExpectNoError(err, "failed to get VolumeAttachment %q", firstVA) gomega.Expect(retrievedVA.Name).To(gomega.Equal(firstVA), "Checking that retrieved VolumeAttachment has the correct name") ginkgo.By(fmt.Sprintf("Patch VolumeAttachment %q on node %q", firstVA, vaNodeName)) payload := "{"metadata":{"labels":{"" + retrievedVA.Name + "":"patched"}}}" patchedVA, err := vaClient.Patch(ctx, retrievedVA.Name, types.MergePatchType, []byte(payload), metav1.PatchOptions{}) framework.ExpectNoError(err, "failed to patch PV %q", firstVA) gomega.Expect(patchedVA.Labels).To(gomega.HaveKeyWithValue(patchedVA.Name, "patched"), "Checking that patched label has been applied") patchedSelector := labels.Set{patchedVA.Name: "patched"}.AsSelector().String() ginkgo.By(fmt.Sprintf("List VolumeAttachments with %q label", patchedSelector)) vaList, err := vaClient.List(ctx, metav1.ListOptions{LabelSelector: patchedSelector}) framework.ExpectNoError(err, "failed to list VolumeAttachments") gomega.Expect(vaList.Items).To(gomega.HaveLen(1)) ginkgo.By(fmt.Sprintf("Delete VolumeAttachment %q on node %q", firstVA, vaNodeName)) err = vaClient.Delete(ctx, firstVA, metav1.DeleteOptions{}) framework.ExpectNoError(err, "failed to delete VolumeAttachment %q", firstVA) ginkgo.By(fmt.Sprintf("Confirm deletion of VolumeAttachment %q on node %q", firstVA, vaNodeName)) type state struct { VolumeAttachments []storagev1.VolumeAttachment } err = framework.Gomega().Eventually(ctx, framework.HandleRetry(func(ctx context.Context) (*state, error) { vaList, err := vaClient.List(ctx, metav1.ListOptions{LabelSelector: patchedSelector}) if err != nil { return nil, fmt.Errorf("failed to list VolumeAttachment: %w", err) } return &state{ VolumeAttachments: vaList.Items, }, nil })).WithTimeout(30 * time.Second).Should(framework.MakeMatcher(func(s *state) (func() string, error) { if len(s.VolumeAttachments) == 0 { return nil, nil } return func() string { return fmt.Sprintf("Expected VolumeAttachment to be deleted, found %q", s.VolumeAttachments[0].Name) }, nil })) framework.ExpectNoError(err, "Timeout while waiting to confirm VolumeAttachment %q deletion", firstVA) secondVA, vaNodeName := createVolumeAttachment(f, ctx) updatedLabel := map[string]string{"va-e2e": "updated"} updatedSelector := labels.Set{"va-e2e": "updated"}.AsSelector().String() ginkgo.By(fmt.Sprintf("Update the VolumeAttachment %q on node %q with label %q", secondVA, vaNodeName, updatedSelector)) var updatedVA *storagev1.VolumeAttachment err = retry.RetryOnConflict(retry.DefaultRetry, func() error { currentVA, err := vaClient.Get(ctx, secondVA, metav1.GetOptions{}) framework.ExpectNoError(err, "failed to get VolumeAttachment %q", patchedVA.Name) currentVA.Labels = updatedLabel updatedVA, err = vaClient.Update(ctx, currentVA, metav1.UpdateOptions{}) return err }) framework.ExpectNoError(err, "failed to update VolumeAttachment %q on node %q", secondVA, vaNodeName) gomega.Expect(updatedVA.Labels).To(gomega.HaveKeyWithValue("va-e2e", "updated"), "Checking that updated label has been applied") thirdVA, vaNodeName := createVolumeAttachment(f, ctx) ginkgo.By(fmt.Sprintf("Update the VolumeAttachment %q on node %q with label %q", thirdVA, vaNodeName, updatedSelector)) err = retry.RetryOnConflict(retry.DefaultRetry, func() error { currentVA, err := vaClient.Get(ctx, thirdVA, metav1.GetOptions{}) framework.ExpectNoError(err, "failed to get VolumeAttachment %q", patchedVA.Name) currentVA.Labels = updatedLabel updatedVA, err = vaClient.Update(ctx, currentVA, metav1.UpdateOptions{}) return err }) framework.ExpectNoError(err, "failed to update VolumeAttachment %q on node %q", thirdVA, vaNodeName) gomega.Expect(updatedVA.Labels).To(gomega.HaveKeyWithValue("va-e2e", "updated"), "Checking that updated label has been applied") ginkgo.By(fmt.Sprintf("DeleteCollection of VolumeAttachments with %q label", updatedSelector)) err = vaClient.DeleteCollection(ctx, metav1.DeleteOptions{}, metav1.ListOptions{LabelSelector: updatedSelector}) framework.ExpectNoError(err, "failed to delete VolumeAttachment collection") ginkgo.By(fmt.Sprintf("Confirm deleteCollection of VolumeAttachments with %q label", updatedSelector)) err = framework.Gomega().Eventually(ctx, framework.HandleRetry(func(ctx context.Context) (*state, error) { vaList, err := vaClient.List(ctx, metav1.ListOptions{LabelSelector: updatedSelector}) if err != nil { return nil, fmt.Errorf("failed to list VolumeAttachment: %w", err) } return &state{ VolumeAttachments: vaList.Items, }, nil })).WithTimeout(30 * time.Second).Should(framework.MakeMatcher(func(s *state) (func() string, error) { if len(s.VolumeAttachments) == 0 { return nil, nil } return func() string { list := []string{} for _, va := range s.VolumeAttachments { list = append(list, va.Name) } return fmt.Sprintf("Expected VolumeAttachment(s) to be deleted, found %v", list) }, nil })) framework.ExpectNoError(err, "Timeout while waiting to confirm deletion of all VolumeAttachments") }) }) }) func NewVolumeAttachment(vaName, pvName, nodeName string, status bool) *storagev1.VolumeAttachment { return &storagev1.VolumeAttachment{ ObjectMeta: metav1.ObjectMeta{ UID:  types.UID(vaName), Name: vaName, }, Spec: storagev1.VolumeAttachmentSpec{ Attacher: "e2e-test.storage.k8s.io", NodeName: nodeName, Source: storagev1.VolumeAttachmentSource{ PersistentVolumeName: &pvName, }, }, Status: storagev1.VolumeAttachmentStatus{ Attached: status, }, } } func createVolumeAttachment(f *framework.Framework, ctx context.Context) (string, string) { randUID := "e2e-" + utilrand.String(5) vaName := "va-" + randUID pvName := "pv-" + randUID nodes, err := f.ClientSet.CoreV1().Nodes().List(ctx, metav1.ListOptions{}) framework.ExpectNoError(err, "failed to list nodes") randNode := rand.Intn(len(nodes.Items)) vaNodeName := nodes.Items[randNode].Name vaAttachStatus := false ginkgo.By(fmt.Sprintf("Create VolumeAttachment %q on node %q", vaName, vaNodeName)) va := NewVolumeAttachment(vaName, pvName, vaNodeName, vaAttachStatus) createdVA, err := f.ClientSet.StorageV1().VolumeAttachments().Create(ctx, va, metav1.CreateOptions{}) framework.ExpectNoError(err, "failed to create VolumeAttachment %q", vaName) gomega.Expect(createdVA.Name).To(gomega.Equal(vaName), "Checking that the created VolumeAttachment has the correct name") return createdVA.Name, vaNodeName } </ins>

Discussion:
[x] two weeks soak end date : 14 Mar 2024 : According to following APIsnoop query, there are six VolumeAttachment endpoints that are untested. Using a number of existing e2e test practices a new has been created to provide future Conformance coverage for the 7 endpoints. The e2e logs for this test are listed below. This query shows the following VolumeAttachment endpoints are hit within a short period of running this e2e test. If a test with these calls gets merged, test coverage will go up by 7 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue as fresh with Close this issue with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details