jiebi/CodeConvo huggingface dataset:
Change:
challengeMetaSelector } from '../redux'; <ins> import { isSignedInSelector } from '../../../redux'; </ins> const mapStateToProps = createSelector( challengeFilesSelector, challengeMetaSelector, isCompletionModalOpenSelector, <ins> isSignedInSelector, </ins> successMessageSelector, <del> (files, { title }, isOpen, message) => ({ </del> <ins> (files, { title }, isOpen, isSignedIn, message) => ({ </ins> files, title, isOpen, <ins> isSignedIn, </ins> message }) );

Discussion:
I'm testing beta. Describe the bug When submitting a challenge using Ctrl+Enter it automatically completes also the following challenge. To Reproduce Steps to reproduce the behavior: a logged out user to the first challenge it Ctrl+Enter marks as solved also the following challenge and you can go ahead Expected behavior It should solve the current challenge and present the following one. Screenshots As you can see I can submit multiple challenges: ! Desktop (please complete the following information): OS: Ubuntu Browser Firefox Version 69.0.1 Additional context I've been able to reproduce it on but I could skip only one challenge. On my local dev I managed to skip 4.
I've digged a bit on this issue, and I think the problem is somehow related to this line: As this is triggered also when I'm submitting the finished challenge. If I comment that line out everything works fine, meaning I can Ctrl+Enter to run the tests and submit and the bug disappear. I'm going to dig a bit more, but does that makes any sense to you?
Thanks for testing our beta version and reporting this! You rock. /cc
Thanks It looks like I didn't test the logged out behaviour. so, what do we want to happen for logged out users? The issue I see is that it currently says 'Submit and go to the next challenge', but clearly they can't submit. For now, do we just want them to see the same as logged in users (and quietly not submit)?
Here is what I would do: ! Of course the modal should close as well like you mentioned. The signin button can link to same as the home page CTA. And we could remove from the first button
Turns out it's not working properly even when the user is logged in. I think it's a race condition between and . was quite right, the problem is on that line. It shouldn't be called if the modal is open since it's listening to as well.
yes I think it's with the in the editor and the in the . I can give a further look later if you wish.
Thanks for the offer but I think (with your help!) I've fixed it. It seemed only fair, since I introduced the bug.
Excellent!
Release on its way, should be available within the hour.
Change:
# --description-- <del> You can also replace the `done` reference in your `padRow` call. Note that `rows.length` here would give you an off-by-one error, because `done` is incremented *before* the call. So you'll need to replace `done` here with `rows.length + 1`. When you do this, you may see a `Range Error`, because we've created another off-by-one error. You'll need to change the `while` condition to use the less than operator, instead of the less than or equal operator. </del> <ins> Replace the `done` reference in your `padRow` call with `rows.length + 1`. </ins> # --hints--

Discussion:
On step 89 and 90 of the Pyramid generator there is this misterious error that appear, it can be confusing for campers. !
Error is coming from the function, specifically one of the string repeats. Depending on the and , when or will be , calling method of string will show that error. Edit: When condition is there's no such issue.
Yep. I think reworking the lessons so we never leave the learner with broken code (or at least never unexplained broken code) is the way to go.
I'm not sure if it was even intended to have broken code, description is suggesting everything should work fine. Step 91 asks for two changes, one of which specifically makes this error appear (second change fixes the issue).
Yeah, it's a bit confusing. Probably not intentional, though. On 91 there's this: the only time I don't see the error is when I've followed all the instructions on step 91.
Is this not enough to clear up any doubts? Cuz after following the instructions in step 91, there's nothing mysterious about the error anymore.
I don't think so. Step 89, where error is introduced, doesn't mention it. Neither does 90. It's only when you reach 91 that the error is mentioned and the text is which is incorrect. Changing to has no effect on the error. It's only the combination of that and adjusting the conditional that finally removes the error. The main issue with this is that it breaks the feedback loop between learner's actions and the code's behaviour. Speaking for myself, everything gets harder when the results of my actions are essentially invisible. I know we run tests to check you re doing it right, but that's not really a substitute for them seeing how your actions impact the program.
Okay. We need to at least note the possibility of an unexpected error to the camper. I'm thinking on step 89 now.
Just for posterity, the steps got shifted. Error is introduced by completing step 95 Error is resolved by completing step 96 What should be changed here: Step 95 should: Introduce and explain the error Ask the campers to change the comparison to Step 96 should: No longer ask campers to change the to Not mention that creates a
Change:
"For example, if you wanted to make a text input field required, you can just add the word "required" within your <code>input</code> element use: <code>&#60;input type='text' required&#62;</code>" ], "tests": [ <del> "assert($('input').prop('required'), 'Your text field should have the property of being required.')", "assert(new RegExp('cat photo URL').test($('input').prop('placeholder')), 'Your text field should have the placeholder text of "cat photo URL".')" </del> <ins> "assert($('input').prop('required'), 'Your text field should have the property of being required.')" </ins> ], "challengeSeed": [ "<link href='http://fonts.googleapis.com/css?family=Lobster' rel='stylesheet' type='text/css'>",

Discussion:
This challenge has the additional requirement of "Your text field should have the placeholder text of "cat photo URL".", when this placeholder text was before, then removed again arbitrarily in this lesson. Assuming this is a bug since it doesn't match the tutorial flow.
Change:
"dashedName": "waypoint-create-decimal-numbers-with-javascript", "difficulty": "9.9815", "description": [ <del> "in JavaScript we can can work with decimal numbers", </del> <ins> "In JavaScript we can can work with decimal numbers.", </ins> "Let's create a variable <code>myDecimal</code> and give it a decimal value." ], "tests": [

Discussion:
Challenge has an issue. In JavaScript whole numbers (called integers) can be easily used to preform mathematical functions <-- Let's try a few of the most commonly used ones now <-- We use - for subtraction <---
merged to

Challenge has an issue. In JavaScript whole numbers (called integers) can be easily used to preform mathematical functions <-- Let's try a few of the most commonly used ones now <--- We use * for multiplication <---
merged to

Challenge has an issue. in JavaScript we can can work with decimal numbers <--- needs full stop.
merged to
Change:
Here is an example of a `switch` statement: ```js <del> switch (lowercaseLetter) { case "a": console.log("A"); </del> <ins> switch (fruit) { case "apple": console.log("The fruit is an apple"); </ins> break; <del> case "b": console.log("B"); </del> <ins> case "orange": console.log("The fruit is an orange"); </ins> break; } ```

Discussion:
It isn't a huge deal, but I do think the camper has a point, see the forum thread for more info. I think updating the example code with something less ambiguous wouldn't be a horrible idea. Current example New example (I can't think of anything better right now, you get the point). Less ambiguous example code that does not involve letter case logic or identifiers with the word in it when teaching about and . No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22]
I agree, the example is unnecessarily confusing. I have submitted a pull request that uses a classic fruit example. The console log is also more explicit on what is being selected. Additionally, may I suggest that we also change the instructions to be more explicit? So instead of: it'll be something like:Additionally, additionally, may I also suggest we expand the explanation on strict equality testing? So add a simple sentence like: "Strings with different cases will be treated as different values"
I guess the conditions can be clarified, but I don't remember seeing this being a problem. That isn't how strict equality works. It has to do with type coercion. Letters with different casings always have different values.
Yes I get that, but for this specific example, I just thought it would be good to keep it simple. On second thought, the explanations / instructions are good enough. Lets leave it as it is.
hello can you please tell me why my pull requests are getting blocked when I am trying to close an issue
Change:
Simply clicking the `Preview Custom 404 Page` button will forward you to the correct page. <del> ![Image - How to sign in when working locally](https://user-images.githubusercontent.com/1884376/52650951-48922e80-2f11-11e9-9eee-360a25ad28ad.gif) </del> <ins> ![Image - How to sign in when working locally](https://user-images.githubusercontent.com/29990697/71541249-f63cdf00-2923-11ea-8a85-cefb6f9c9977.gif) </ins> ## Quick commands reference when working locally

Discussion:
The GIF depicts fCC in its old design. Even though I don't think there's anything wrong with it, I guess it should be updated to align with how fCC looks now !
Hi, I'll work on this
Just submit a PR when you are ready.
When I click the "sign-in" button on the homepage, I see this screen - ! Is this the expected behavior? Should I be creating a GIF of this?
Yes, this is expected behavior.
Change:
assert(document.querySelector("fieldset:nth-of-type(3) input:nth-of-type(5)[type='checkbox']")); ``` <del> You should have an checkbox input with an `id` of `"price"`. </del> <ins> You should have a checkbox input with an `id` of `"price"`. </ins> ```js assert.strictEqual(document.querySelectorAll("fieldset:nth-of-type(3) input[type='checkbox']")[4].getAttribute('id'), 'price');

Discussion:
"an checkbox input" should be changed to "a checkbox input". Fix the typo in the following files:
This issue is open for contribution. The file that you should be updating is linked in the original post. We typically do not assign issues. Instead, we accept the most quality contribution followed by the one that is made first. Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Happy contributing.
Change:
script(src='/js/lib/codemirror/mode/htmlmixed/htmlmixed.js') script(src='/js/lib/codemirror/addon/emmet/emmet.js') .row.courseware-height <del> .col-xs-12.col-sm-12.col-md-3.col-lg-3 </del> <ins> .col-md-3.col-lg-3 </ins> .scroll-locker(id = "scroll-locker") .innerMarginFix(style = "width: 99%;") .well

Discussion:
A camper relayed this to me: There is some problem with the first challenge ending button on android with firefox browser. And in this moment I tried in chrome too, the issue is the same, the button is not active after the challenge is done. Xperia Z1 compact, android: 5.0.2, firefox: 39.0 Chrome: 43.0.2357.93
This is an issue whenever the screen size is small. It will also happen on a desktop if you resize the window to half screen or less.
Change:
.negative-bottom-margin-30 label.negative-10.btn.btn-primary.btn-block#submitButton i.fa.fa-play <del> | &nbsp; Run code (ctrl + enter) </del> <ins> | &nbsp; Run tests (ctrl + enter) </ins> br if (user) .button-spacer

Discussion:
I noticed on this challenge that the button to run the tests still runs code ! I think this should say run tests
Change:
# --description-- <del> Give both your `#controls` and `#stats` elements a `border` of `1px solid #0a0a23`, a `#0a0a23` text color, and `5px` of padding. </del> <ins> Using a selector list (`selector1, selector2`) give both your `#controls` and `#stats` elements a `border` of `1px solid #0a0a23`, a `#0a0a23` text color, and `5px` of `padding`. </ins> # --hints-- <del> You should have a `#controls, #stats` selector. </del> <ins> You should have a `#controls, #stats` selector list. </ins> ```js const selector = new __helpers.CSSHelp(document).getStyle('#controls, #stats');

Discussion:
Below is syntactically valid code that meets the challenge description. The error message says but we've adopted a policy of accepting any valid syntax that meets the challenge description, so I think we need to check that the target elements received the desired style. Valid code should be accepted. No response All No response
I think I would be fine with only checking the style of the elements here. My only concern would be that - presumably, would we remove the test that says - do we need a hint like that to help guide people, or do we expect them to know that at this point?
I think we should update the requirements and specifically ask for a selector list. I don't think we should allow the duplication of styles in separate selectors. I know the selector list was taught in the CSS curriculum, but maybe we need an example here, I.e. (). Or maybe we do not if they are expected to know about it already. Edit: The test would really just say this instead
That'd also be a fine approach to me. One way or another we need the target solution and the instructions to agree
I am fine with instructions explaining better. Since instructions did not give more context. it was lack of context. it caused someone got misunderstand when they asked a help. and thank you!
An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the Here is the file you will need to work with You will need to update the description to be this You will also need to update the first hint text to be this instead
Hello! I am a new open source contributor and I tried to contribute to issue number which I did but in a weird manual way on GitHub because I am getting error cloning the freeCodeCamp repo after I fork it. I hope anyone can help me with it. Here it was it exactly says: Updating files: 100% (/), done. fatal: unable to checkout working tree warning: Clone succeeded, but checkout failed.

You can inspect what was checked out with 'git status' and retry with 'git restore --source=HEAD :/'
Hi ! It is best to post your question on the forum or discord so people can assist you there instead of on this issue. Thanks for understanding
Change:
--- title: Caesars Cipher --- <del> ![:triangular_flag_on_post:](https://forum.freecodecamp.com/images/emoji/emoji_one/triangular_flag_on_post.png?v=3 ":triangular_flag_on_post:") Remember to use <a>**`Read-Search-Ask`**</a> if you get stuck. Try to pair program ![:busts_in_silhouette:](https://forum.freecodecamp.com/images/emoji/emoji_one/busts_in_silhouette.png?v=3 ":busts_in_silhouette:") and write your own code ![:pencil:](https://forum.freecodecamp.com/images/emoji/emoji_one/pencil.png?v=3 ":pencil:") ### ![:checkered_flag:](https://forum.freecodecamp.com/images/emoji/emoji_one/checkered_flag.png?v=3 ":checkered_flag:") Problem Explanation: *   You need to write a function, which will take a string encoded with _Caesar cipher_ as a parameter and decode it. *   The one used here is ROT13 where the value of the letter is shifted by 13 places. e.g. 'A' ![:left_right_arrow:](https://forum.freecodecamp.com/images/emoji/emoji_one/left_right_arrow.png?v=3 ":left_right_arrow:") 'N', 'T' ![:left_right_arrow:](https://forum.freecodecamp.com/images/emoji/emoji_one/left_right_arrow.png?v=3 ":left_right_arrow:") 'G'. *   You have to shift it back 13 positions, such that 'N' ![:left_right_arrow:](https://forum.freecodecamp.com/images/emoji/emoji_one/left_right_arrow.png?v=3 ":left_right_arrow:") 'A'. #### Relevant Links *   <a href='http://forum.freecodecamp.com/t/javascript-string-prototype-charcodeat/15933' target='_blank' rel='nofollow'>String.prototype.charCodeAt</a> *   <a href='https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/fromCharCode' target='_blank' rel='nofollow'>String.fromCharCode</a> </del> ## ![:speech_balloon:](https://forum.freecodecamp.com/images/emoji/emoji_one/speech_balloon.png?v=3 ":speech_balloon:") Hint: 1

Discussion:
Describe your problem and how to reproduce it: First Issue: The Basic solution uses call() function but doesn't include any reference to it. Second Issue: The Basic solution doesn't work when you use it as a solution for the challenge. You get the following error on the beta site: I guess setting to fixes this issue. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Mozilla Firefox Browser Version: 66.0.5 Operating System: Windows 10 One more thing. The error generated on the old site is helpful whereas the one on the new site isn't. Probably something to look at.
That is a valid point regarding the error message, but that is a different issue related to how the challenge tests are ran. I have gone ahead and created a PR () to address the solution in the Guide, but the last issue you mentioned will have to be discussed in a separate issue (feel free to create it if you have the time). I could not find any outstanding issues regarding why this does not show the error "assignment to undeclared variable x" which does show in the actual browser console. Are errors like this being suppressed on showing in the fake console for any reason?
Change:
assert([...document.querySelector('form').attributes].length < 2); ``` <del> You should create an input element. Check the syntax. </del> <ins> You should create an `input` element. Check the syntax. </ins> ```js assert(document.querySelector('input'));

Discussion:
In step 36 of catAppPhoto project, the hint in line 33 missing code block This should be changed to Here is the markdown file Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
Change:
"Now try commenting out your call to Google Fonts, so that the "Lobster" font isn't available. Notice how it degrades to the "Monospace" font." ], "tests": [ <del> "assert($('h2').css('font-family').match(/lobster/i), 'Your h2 element should use the font "Lobster".')", "assert($('h2').css('font-family').match(/monospace/i), 'Your h2 element should degrade to the font "Monospace" when "Lobster" is not available.')" </del> <ins> "assert($('h2').css('font-family').match(/^"?lobster/i), 'Your h2 element should use the font "Lobster".')", "assert($('h2').css('font-family').match(/lobster"?,monospace/i), 'Your h2 element should degrade to the font "Monospace" when "Lobster" is not available.')" </ins> ], "challengeSeed": [ "<link href='http://fonts.googleapis.com/css?family=Lobster' rel='stylesheet' type='text/css'>",

Discussion:
Challenge has an issue. Please describe how to reproduce it, and include links to screen shots if possible. In the Challenge it ask that "use "Lobster" as their font family, but degrade to the "Monospace" font when the "Lobster" font isn't available" but if you write the other way in the CSS you can pass the challenge. !
I found the corresponding line but I don't know what does and why has such strange input, so I'm not sure how to fix this ticket. Perhaps split the css value string by into an array and make sure the item with "monospace" has a higher index than the item with "lobster".
assert is part of the test library fcc uses. So in this case the tests like you were saying should be for example: assert($('h2').css('font-family').toLowerCase().replace(' ', '').split(',')[0].match(/lobster/i) assert($('h2').css('font-family').toLowerCase().replace(' ', '').split(',')[1].match(/monospace/i)
Please note that both and are legal, so one should probably first split with only and then .
it doesn't really change the result but sure!
Change:
Fulfill the user stories and pass all the tests below to complete this project. Give it your own personal style. Happy Coding! <ins> **Note:** Be sure to add `<link rel="stylesheet" href="styles.css">` in your HTML to link your stylesheet and apply your CSS </ins> # --hints-- You should have an `h1` element with an `id` of `title`

Discussion:
With the new format, a lot of people are not linking their css files to the HTML document. It is coming up a lot on the forum. Especially for those that are going through the Legacy curriculum. I think we should add a message underneath the sample projects, to remember to link the CSS file. Proposed change: Remember to link your CSS file in the HTML document. <img width="460" alt="Screen Shot 2022-05-14 at 8 57 10 AM" src="https://user-"
I had trouble fixing , because I didn't link To I hope this will be implemented
I think we should do this.
Change:
</head> <body> <header> <del> <img id="logo" src="https://cdn.freecodecamp.org/platform/universal/fcc_primary.svg"> </del> <ins> <img id="logo" alt="freeCodeCamp" src="https://cdn.freecodecamp.org/platform/universal/fcc_primary.svg"> </ins> <h1>HTML/CSS Quiz</h1> <nav></nav> </header>

Discussion:
[X] The "CSS" and the have the same value. This is affecting screen reader users since this involves an input and associated label. [ ] The logo in the upper left needs alt text. I would suggest it just be "freeCodeCamp". A lot of them. N/A Resolved Add alt text to the logo. Do we need to add an extra step for this or can we just add it to ? No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Seeing as the logo is non-functional, do we want the alt to be null? ? If it does require an , then this should get its own step, and a clear description as to why it needs one should be given. I suggest changing the of the (and associated ) to .
Per , the logo does require alt text. Functionality isn't the deciding factor here, it's if the image conveys information (i.e. is not purely decorative), which this image clearly does. Do we want to split this off into its own issue if we are going to create a new step?
I would say yes, but it is not fun to deal with the merge conflict, when two PRs are opened at the same time.
The logo still needs an alt text. The logo is introduced in step 7: That step should be updated to instruct campers to give the an alt text of . The seed code in all subsequent steps should be updated to include that new attribute.
hey may i work on this issue? if so please assign it to me
Hey We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.