jiebi/CodeConvo huggingface dataset:
Change:
const isMacOS = navigator.userAgent.includes('Mac OS'); <ins> const isDesktop = window.innerWidth > MAX_MOBILE_WIDTH; let buttonText; if (isDesktop) { if (isMacOS) { buttonText = isSignedIn ? t('buttons.submit-and-go-3') : t('buttons.go-to-next-3'); } else { buttonText = isSignedIn ? t('buttons.submit-and-go-2') : t('buttons.go-to-next-2'); } } else { buttonText = isSignedIn ? t('buttons.submit-and-go') : t('buttons.go-to-next'); } </ins> return ( <Modal onClose={close}

Discussion:
We are using the class to conditionally hide some text on mobile screens: This class comes from Bootstrap, which is something we are going to remove (). So instead of using the class, we can use an check, like this (which is also a little more consistent with how we've handled this kind of conditional rendering): Update the file to replace the class with an check. I noticed that we are using multiple methods for mobile device detection, so I think the check should be standardized, and there should be a shared util for this check. But I'm leaving this out of the scope of this issue, and will create a separate issue for it.
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
I already have a pull request that technically resolves this. While it is done the same way we did the lower-jaw i.e checks for a desktop instead of being mobile , it does solve the problem and pass the tests.
Change:
```js const labelChildNodes = [...$('label')].map((node) => [...node.childNodes]); assert( <del> labelChildNodes.filter((childNode) => childNode[0].nodeName === 'INPUT') .length === 2 </del> <ins> labelChildNodes.filter( childNodes => childNodes.filter(node => node.nodeName === 'INPUT').length === 1 ).length === 2 </ins> ); ```

Discussion:
The tests for the formatting are too strict and won't let valid code pass. The above code should pass. This code passes: No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
here is failing test, in this markdown file Both radio buttons should still be located between opening and closing element tags. but why it's failing is alluding me. Anyway, I am in support of changing it to make it pass
This code works: But this code doesn't: Those 2 codes are exactly the same expect the second one has a little empty space between and . So something about the empty space makes the thing declare it as 'no longer between the opening and closing of the ' I dont know if this helps but that seems to be how to reproduce this bug. As even in the original buggy code that showed us there is empty space between the and : As you can see the code passes: ! So the empty space is messing stuff up. Again idk if this helps its my first time contributing so idk what im doing lol but i hope it helps somewhat in fixing the issue.
finding this, without debugging is impressive, good job. Yeab, this is helpful
Test expects to be first child node of the . When there's text (spaces) before it, first node will be node with spaces. To check for in all child nodes, and to ensure there's only one input per label, assertion can be changed to something like:
Change:
<div className='badge-card-container'> {isDonating && ( <div className='badge-card'> <del> <div className='badge'> </del> <ins> <div className='camper-badge'> </ins> <SupporterBadgeEmblem /> </div> <div className='badge-card-description'>

Discussion:
A2 English blocks have challenges whose title is displayed next to a completion indicator. The indicator is having a right margin, which creates a gap between the indicator and the text. <img width="746" alt="Screenshot 2024-05-31 at 22 49 13" src=""This issue is because the indicator has a class: This class was harmless as it didn't have any CSS rules associated, until we badges to the user profile page, which caused a class name collision: Remove the class from: Rename the class in to to avoid future collision
I can take this one, but I don't seem to have the permissions to assign myself to this issue.
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
Awesome, thanks for clarifying!
Change:
guideUrl: PropTypes.string, instructions: PropTypes.string, introPath: PropTypes.string, <ins> isChallengeCompleted: PropTypes.bool, </ins> nextChallengePath: PropTypes.string, prevChallengePath: PropTypes.string, section: PropTypes.string,

Discussion:
In the new beta (currently at ), it would be great if a challenge page indicated somehow when the challenge has already been completed. Currently, since user inputed code is not saved, there is no indication on a challenge page that it has already been completed.
We need a check mark in the title or a badge or to indicate the same?
The most elegant thing I can think of to have something like the little circular check mark next to the title like how it is on the learn homepage - only if it's been solved, and don't show anything if it hasn't.
That would be a nice way to handle it. Please go forth if you are interested in this?
Change:
//## Night mode styles @night-body-bg:         @gray-dark; <del> @night-text-color:            #999; </del> <ins> @night-text-color:            #ccc; </ins> //== Typography //

Discussion:
<!-- freeCodeCamp Issue Template --<!-- Please provide as much detail as possible for us to fix your issue --<!-- Remove any heading sections you did not fill out --<!-- NOTE: If your issue is CodePen Project / Test Suite related, please open it using the below URL instead --<!-- --<!-- Describe below when the issue happens and how to reproduce it --I love Night Mode when doing the challenges. However, I noticed that the contrast seemed a bit low. Running the WCAG Contrast Checker extension confirmed my belief. See screenshot below. Lightening up the foreground color would be beneficial to everyone. Thanks! <!-- Describe your workspace in which you are having issues--Browser Name, Version: Mozilla 52.0 Operating System: Windows 7 Mobile, Desktop, or Tablet: Desktop <!-- Add a screenshot of your issue --!
I'm happy to tackle this, if it's open! I just need to finish setting up my dev environment according to the contribution guidelines.
I have set up local FCC. I will be able to give it a shot by tonight unless hasn't done it already.
Hi, i have committed a . It passed WCAG luminosity as shown in the below screenshot. <img width="838" alt="screen shot 2017-03-21 at 10 41 47 pm" src=""
You beat me to it! This is an improvement, though. Thanks for making the site better.
Change:
"title": "Sift through Text with Regular Expressions", "difficulty":"9.984", "description":[ <del> "<code>Regular expressions</code> are way to find certain words or patterns inside of <code>strings</code>.", </del> <ins> "<code>Regular expressions</code> are used to find certain words or patterns inside of <code>strings</code>.", </ins> "For example, if we wanted to find the number of times the word <code>the</code> occurred in the string <code>The dog chased the cat</code>, we could use the following <code>regular expression</code>: <code>/the+/gi</code>", "Let's break this down a bit:", "<code>the</code> is the pattern we want to match.",

Discussion:
Challenge has an issue. The original text is, "Regular expressions are way to find certain words or patterns inside of strings." It should instead read, "Regular expressions are a way to find certain words or patterns inside of strings." I would instead write, "Regular expressions are used to find certain words or patterns inside of strings."
Change:
Within the `header`, provide context about the page by nesting one `img`, `h1`, and `nav` element. <del> The `img` should point to `https://cdn.freecodecamp.org/platform/universal/fcc_primary.svg`, and have an `id` of `logo`. </del> <ins> The `img` should point to `https://cdn.freecodecamp.org/platform/universal/fcc_primary.svg`, have an `id` of `logo`, and have an `alt` text of `freeCodeCamp`. </ins> The `h1` should contain the text `HTML/CSS Quiz`.

Discussion:
[X] The "CSS" and the have the same value. This is affecting screen reader users since this involves an input and associated label. [ ] The logo in the upper left needs alt text. I would suggest it just be "freeCodeCamp". A lot of them. N/A Resolved Add alt text to the logo. Do we need to add an extra step for this or can we just add it to ? No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Seeing as the logo is non-functional, do we want the alt to be null? ? If it does require an , then this should get its own step, and a clear description as to why it needs one should be given. I suggest changing the of the (and associated ) to .
Per , the logo does require alt text. Functionality isn't the deciding factor here, it's if the image conveys information (i.e. is not purely decorative), which this image clearly does. Do we want to split this off into its own issue if we are going to create a new step?
I would say yes, but it is not fun to deal with the merge conflict, when two PRs are opened at the same time.
The logo still needs an alt text. The logo is introduced in step 7: That step should be updated to instruct campers to give the an alt text of . The seed code in all subsequent steps should be updated to include that new attribute.
hey may i work on this issue? if so please assign it to me
Hey We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
Change:
## --text-- <del> What is Sarah referring to with `it` in his question `Is it contactless?` </del> <ins> What is Sarah referring to with `it` in her question `Is it contactless?` </ins> ## --answers--

Discussion:
Jake is explaining the purpose of his visit to Sarah. He's there to hand over something that Sarah needs, which will permit him (should be her) access to certain areas. <!DOCTYPE html<html lang="en" <head</head<body</body</htmlNo response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Thank you for reporting the issue. This issue is open to first-time code contributors to this repository. The file that you should be updating is Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Next step has similar error. Should be
Hii excellent catch. Solved it locally, will be raising a PR in few minutes. This my first valid pull request, pls assign me if possible !
Thank you for your interest in contributing. We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labeled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
Hii fixed the typos in both the task (154 & 155) ! ! Hope it clear all the test and get merged
Change:
assert($('input[type="checkbox"]')[0]); ``` <del> Your checkbox should still have an `id` attribute with the value `loving`. You may have removed the attribute or changed its value. </del> <ins> Your checkbox should still have an `id` attribute with the value `loving`.  Expected `--fcc-expected--`, but found `--fcc-actual--`. </ins> ```js <del> assert($('input[type="checkbox"]')[0].id === 'loving'); </del> <ins> assert.equal($('input[type="checkbox"]')[0].id, 'loving'); </ins> ``` The text ` Loving` should no longer be located directly to the right of your checkbox. It should be wrapped in a `label` element. Make sure there is a space between the two elements.

Discussion:
This is a common error on this Step - we should modify the hint to point out the capitalization User should receive hint that helps them see the capitalization error No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
The current hint is: "The new element should have a attribute with the value . You have either omitted the value or have a typo. Remember that attribute values should be surrounded with quotation marks." Technically, the attribute value doesn't need to be wrapped in quotes since there are no spaces in the value. Also, it will pass if you don't use quotes for the value, so this part of the hint seems unneeded and should probably be removed. Are you thinking that we should have a separate test just to check whether the value has been capitalized? Or do you think we just add a warning to the current hint reminding them that capitalization (or lack thereof) matters?
I'm not quite sure what the best way forward would be. I just know what most questions for this step on the forum are related to Loving vs loving.
We do have dynamic hints we can use:
Change:
files: PropTypes.object.isRequired, handleKeypress: PropTypes.func.isRequired, isOpen: PropTypes.bool, <ins> isSignedIn: PropTypes.bool.isRequired, </ins> message: PropTypes.string, submitChallenge: PropTypes.func.isRequired, title: PropTypes.string

Discussion:
I'm testing beta. Describe the bug When submitting a challenge using Ctrl+Enter it automatically completes also the following challenge. To Reproduce Steps to reproduce the behavior: a logged out user to the first challenge it Ctrl+Enter marks as solved also the following challenge and you can go ahead Expected behavior It should solve the current challenge and present the following one. Screenshots As you can see I can submit multiple challenges: ! Desktop (please complete the following information): OS: Ubuntu Browser Firefox Version 69.0.1 Additional context I've been able to reproduce it on but I could skip only one challenge. On my local dev I managed to skip 4.
I've digged a bit on this issue, and I think the problem is somehow related to this line: As this is triggered also when I'm submitting the finished challenge. If I comment that line out everything works fine, meaning I can Ctrl+Enter to run the tests and submit and the bug disappear. I'm going to dig a bit more, but does that makes any sense to you?
Thanks for testing our beta version and reporting this! You rock. /cc
Thanks It looks like I didn't test the logged out behaviour. so, what do we want to happen for logged out users? The issue I see is that it currently says 'Submit and go to the next challenge', but clearly they can't submit. For now, do we just want them to see the same as logged in users (and quietly not submit)?
Here is what I would do: ! Of course the modal should close as well like you mentioned. The signin button can link to same as the home page CTA. And we could remove from the first button
Turns out it's not working properly even when the user is logged in. I think it's a race condition between and . was quite right, the problem is on that line. It shouldn't be called if the modal is open since it's listening to as well.
yes I think it's with the in the editor and the in the . I can give a further look later if you wish.
Thanks for the offer but I think (with your help!) I've fixed it. It seemed only fair, since I introduced the bug.
Excellent!
Release on its way, should be available within the hour.
Change:
showPoints, showPortfolio, showTimeLine, <del> updateMyProfileUI </del> <ins> updateMyProfileUI, user </ins> } = props; const toggleFlag = flag => () => updateMyProfileUI({ profileUI: { [flag]: !props[flag] } });

Discussion:
Once we've built the JSON we want to output, I believe we can just use Pug like this for the button to initiate the file download:
Change:
## --seed-contents-- ```jsx ``` # --solutions--

Discussion:
An empty solution seed with the following format does not parse correctly in Crowdin: ! Adding an empty new-line between the backtick lines will parse correctly in Crowdin: ! The following files have empty seeds with the first format and need a blank line : JavaScript / Basic JavaScript comment your javascript code declare javascript variables declare string variables initializing variables with the assignment operator passing values to functions with arguments return a value from a function with return write reusable javascript with functions JavaScript / ES6 create a javascript promise JavaScript / Object Oriented Programming define a constructor function Front End Libraries / Bootstrap Create a bootstrap headline Front End Libraries / React Create a complex jsx element Quality Assurance Projects metric imperial converter Coding Interview Prep / Data Structures Create an ES6 Javascript Map
Hi, I'll add those blank lines. It'll be my first time contributing to an open-source project, though.
Please visit to find all the info you will need to get started with contributing a fix for this issue.
Alright. I'll go through the documentation.
Hi. First time contributor here. I have forked the free code camp files to my github page. I have cloned them locally, opened the appropriate folders into my VSCode editor and made the changes (though I was not able to find a # --seed-- in Quality Assurance Projects: metric imperial conversion) but now I have no idea of how to get the code back here. Is there some documentation with instructions on how to do that? Thanks in advance.
Change:
#learn-app-wrapper .reflex-container.horizontal > .reflex-splitter { height: 5px; } <ins> #description p, #instructions p { font-family: 'Lato', sans-serif; } </ins>

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Browser Version: Operating System: If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
Change:
assert(!!el && el.tagName === 'LABEL') ``` <del> Your `#name-label` should not be empty </del> <ins> Your `#name-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('name-label') assert(!!el && el.innerText.length > 0) ``` <del> Your `#email-label` should not be empty </del> <ins> Your `#email-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('email-label') assert(!!el && el.innerText.length > 0) ``` <del> Your `#number-label` should not be empty </del> <ins> Your `#number-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('number-label')

Discussion:
There are three tests that test for non-empty labels: "Your #name-label should not be empty." "Your #email-label should not be empty." "Your #number-label should not be empty." I think the word "empty" is slightly ambiguous here. These tests appear to be looking for actual text inside the label. But if the user nests an inside the label without text then the isn't exactly empty: The above will fail because there is no actual text in the but I can see how the user would not think the is empty. N/A Adjust the test descriptions so they clarify that text needs to be inside the . Perhaps something like: "Your #name-label should contain text that describes the input". No response N/A No response
Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
Change:
# --description-- <del> You may be familiar with the `meta` tag already; it is used to specify information about the page, such as the title, description, keywords, and author. </del> <ins> You may be familiar with the `meta` element already; it is used to specify information about the page, such as the title, description, keywords, and author. </ins> <del> Give your page a `meta` tag with an appropriate `charset` value. </del> <ins> Give your page a `meta` element with an appropriate `charset` value. </ins> The `charset` attribute specifies the character encoding of the page, and, nowadays, `UTF-8` is the only encoding supported by most browsers.

Discussion:
related to In the new Responsive Design curriculum the words tag and element are used interchangebly The correct use should be element and tag (or at least, element is the whole thing, tag is the one that start with and end with and can be an opening tag, a closing tag or a self-closing tag). Should this be changed in the new curriculum?
Do we have many/any incorrect uses?
actually mostly not - there is some ambiguity with in the second step of the accessibility quiz I have been hasty
My concern was with these steps, which are about meta tags
That does look like something that should be standardised. Thank you, for listing them. I am opening this issue up for first timers only. The files that need changed are listed in the above reply. What needs changed There are a few uses of the word which should be changed to . Example Original: New: Note Not all uses of the word should be changed. Example: An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the
Hi - is it ok if i pick this up? First timer here