jiebi/CodeConvo huggingface dataset:
Change:
testString: assert(beagle instanceof Animal); - text: The constructor for <code>beagle</code> should be set to <code>Dog</code>. testString: assert(beagle.constructor === Dog); <ins> - text: <code>beagle.eat()</code> should log <code>"nom nom nom"</code> testString: | console.log = function(msg){throw msg;} assert.throws(() => beagle.eat(),"nom nom nom"); - text: <code>beagle.bark()</code> should log <code>"Woof!"</code> testString: | console.log = function(msg){throw msg;} assert.throws(() => beagle.bark(),"Woof!"); </ins> ``` </section>

Discussion:
Originally posted by _
Can you explain exactly where the issue is
The issue i see is that, if someone poorly implements the eat function, they don't get feedback that they did something wrong. Take this code for example: Console output: Still passing the lession, although im deviding by zero ;)
We could spy on the console and assert, that after () is called, the spy got called once with "nom nom nom". Since we are using chai allready, i assumed we could just use it in the markdown files. My code so far (): Maybe it's helping someone :)
it's a nice idea, but we only use the core package, not . A custom solution where you proxy should work, albeit with a little more effort.
I tried doing this Unfortunately, this does not work.
that's almost right and it's a neat approach. I played with it for a bit and came up with: Since each test is isolated, there's no need to restore the original .
awesome! Do you mind if I push this or will you do that?
Not at all, go for it!
I guess you can add the change for all languages :)
No need to do that. We are working to using the English version of the file's to work across all languages. See PR for more information.
Once we merge your PR, you can find all the challenges where we need to test for a specific value being logged to the console.
Acknowledged. Thanks for the heads up. I will push the fixes for all such instances.
Make sure to put the others on a different PR, so as not to hold up your existing PR.
of course :)
Change:
"react-hotkeys": "^2.0.0", "react-identicons": "^1.1.7", "react-instantsearch-dom": "^6.0.0-beta.0", <del> "react-monaco-editor": "^0.30.1", </del> <ins> "react-monaco-editor": "^0.31.0", </ins> "react-redux": "^5.0.7", "react-reflex": "^3.0.18", "react-responsive": "^6.1.1",

Discussion:
Describe the bug When viewing any challenge in Firefox, I can scroll in the instructions/theory part of the window, but the scrolling does not work in the code editor. I have tried with an external mouse as well as with the Trackpad in my Mac. In the same computer and with the same devices it works perfectly using Chrome. To Reproduce to any challenge. to scroll inside the code editor. does not work. Expected behavior It should scroll. Desktop: macOS 10.14.6 Mozilla Firefox 69.0.3 Additional context So far, to scroll in Firefox I have to click and drag the side scrolling bar in order to navigate the code. I think I'm only having this issue since the last redesign, but I may be wrong on this.
I've noticed this for quite a while - but I don't recall if it was present before the latest redesign.
I am also experiencing this problem as of the update. Windows 10 desktop Firefox 69.0.3 External mouse with a scroll wheel In order to scroll I have to find the very small and hard to see scroll bar inside the code editor and click+drag
Having the same issue as you Might take a dig in the code/inspector and see what's up.
It looks like a possible bug with the monaco editor (we are using monaco-editor": "^0.17.1") I confirmed the bug locally first and I then updated to the latest version of monaco and the scroll works again in Firefox. So it has been fixed. I'm just not sure how involved it is for us to update the editor?
Thanks for digging into this and finding the updates. I think we should be able to update monaco-editor itself which we have as a dep: But the issue right now is to confirm if react-monaco-editor is going to play along as well: I think I could not bump it last time I was trying to update it. Opening up for investigation and fix. A PR is most welcome, or any pointers are welcome as well.
I am also experiencing this problem after the update. MacOS 10.14.6 Firefox 69.0.3 Both external mouse with a scroll wheel and Macbook Pro trackpad cannot scroll the code window however Chrome and Safari browser does not have this problem.
I was able to update to both and .

I updated react-monaco to 0.18.1 and react-monaco-editor to 0.31.0, did a few challenges locally and didn't see any immediate issues from the editor update. A PR would just be a chore update to and package- correct?
Thanks for reporting, please use the voting feature instead of confirming further. We know this is a confirmed bug, more so in an underlying library that we have little control over. We are working on a solution. Keeping the thread free for solutions will help.
Yes please. You are the rockstar.
Change:
"Fill in the object constructor with the methods specified in the tests.", "Those methods are getFirstName(), getLastName(), getFullName(), setFirstName(), setLastName(), and setFullName().", "These methods must be the only available means for interacting with the object.", <del> "There will be some linting errors on the tests, you may safely ignore them. You should see undefined in the console output." </del> <ins> "There will be some linting errors on the tests. You may safely ignore them. You should see undefined in the console output." </ins> ], "challengeEntryPoint": "var bob = new Person('Bob Ross');", "challengeSeed": "var Person = function(firstAndLast) {n    return firstAndLast;rn};",

Discussion:
Need to document the rename challenge tool and the i18n sync tool. Sometime later this week. Not urgent.
I can take this on?
Go for it, Thanks!
I will start with the rename challenge tool, for the i18n sync, I will wait news if it works now
Change:
import { submitNewAbout, updateUserFlag, verifyCert } from '../redux/settings'; import { createFlashMessage } from '../components/Flash/redux'; <del> import Spacer from '../components/helpers/Spacer'; import Loader from '../components/helpers/Loader'; import FullWidthRow from '../components/helpers/FullWidthRow'; </del> <ins> import { FullWidthRow, Link, Loader, Spacer } from '../components/helpers'; </ins> import About from '../components/settings/About'; import Privacy from '../components/settings/Privacy'; import Email from '../components/settings/Email';

Discussion:
To reduce making api calls we should use Link from client/src/components/helpers/Link that utilizes Gatsby Link.
I can take a look at this one
Change:
## --sentence-- <del> `Hey. You are Sarah, right? I'm Jake, _ _.` </del> <ins> `Hey. You're Sarah, right? I'm Jake, _ _.` </ins> ## --blanks--

Discussion:
Change "You are Sarah" to "You're Sarah" in step 150, 154, and 155 of Learn Greetings in your First Day at the Office. The change is to match the caption text. (The text isn't visible on the Task 155 page, but in the code.) Change "You are Sarah" to "You're Sarah" in the following files:
We introduce contraction form in task 1 () so I assume we would want to use contractions in later tasks. But I'll wait for the curriculum team to confirm before opening this issue up for contribution. (If we don't want to use contraction in these tasks, the caption text should be updated to match the fill the blank text.)
Change:
script(src='/js/lib/codemirror/mode/javascript/javascript.js') script(src='/js/lib/jailed/jailed.js') script(src='/js/lib/bonfire/bonfireInit.js') <ins> script(src="https://cdn.jsdelivr.net/ramda/0.10.0/ramda.min.js") </ins> .row

Discussion:
the first line in the function says - it wont pass testing unless you change it to Browser Name: Firefox Browser Version: 60.0.1 Operating System: High Sierra ! <hr!
You don't have to it, but because of strict mode it does need to be declared with , , or .
so its missing the then?
That's how I would update it.

i am suspecting another small bug, the next challenge after succesful code run in Bonfire: Chunky Monkey actually points to itself
Change:
export const Landing = ({ edges }) => { const superBlocks = uniq(edges.map(element => element.node.superBlock)); <ins> const interviewPrep = superBlocks.splice(6, 1); </ins> return ( <Fragment> <Helmet>

Discussion:
On the home page, it lists the section as a certification.... ! Maybe remove that since there's no cert for it?
Yes, you are correct. I will defer to for the correct categorization for this.
We could change the font size of this. Then it would be visually distinct from the other items in this list.
We can indent the list belonging to same category. And make change in font style Like this way:- Certifications: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="#"Responsive Web Design</a&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="#"JavaScript Algorithms and Data Structures</a&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="#"Front End Libraries</a&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="#"Data Visualization</a&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="#"APIs and Microservices</a&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="#"Information Security and Quality Assurance</a<a href="#"Coding Interview Prep</a
I'm not sure I like either of these solutions - it seems like it might just make a user ask themselves something like: "what's with that last one?" - And not be quite clear enough that it is not a cert. What about something a little more specific... Certifications: &nbsp;&nbsp;<a href="#"Responsive Web Design</a&nbsp;&nbsp;<a href="#"JavaScript Algorithms and Data Structures</a&nbsp;&nbsp;<a href="#"Front End Libraries</a&nbsp;&nbsp;<a href="#"Data Visualization</a&nbsp;&nbsp;<a href="#"APIs and Microservices</a&nbsp;&nbsp;<a href="#"Information Security and Quality Assurance</aAdditional Challenges: &nbsp;&nbsp;<a href="#"Coding Interview Prep</a
Change:
} return ''; }) <del> .reduce((head, element) => head.concat(element), displayTheme); </del> <ins> .reduce((head, element) => head.concat(element)); </ins> const source = files.reduce( (source, file) => source.concat(file.contents, htmlCatch),

Discussion:
I did not see anyone raising this issue, but I don't think the background of the preview in default or night mode should be anything other than white unless the coding exercise specifically changes the background to something else. The preview should be exactly what you would see in a browser. In almost all the challenges, the background would be white. !
I share your concerns The reason we changed the color of the display is that a white display is discomforting to the eye on night mode when everything else is dark. so we injected some styles to harmonize the view in general. That convention was carried over to light mode.
It might be better to default to white in light mode, same as the editor. As for night mode, some of the css challenges might need some changes to look reasonable in both modes. For instance, in night mode, looks like this: ! If we change the seed code to it would become ! It would have to be case-by-case, though.
That is a very good point. I will defer this to
Logically, I have to agree with - displaying anything other than what the code in the editor would produce might confuse campers. But it is a little rough on the eyes to have the white background on night mode. And the current theme looks a lot better - so it's a tough call. I scrolled through a number of challenges, and there's quite a few that don't look right with the blue background. So there might be a decent amount of work to go through and fix all of them.
I really like the new theme, but a preview should be a true preview. We want to make this like the real world. Developers working in some kind of night mode on their favorite local editors, still expect to check the "real" result of the code they have written on a browser or in a preview mode in their local editors. The night mode should only apply to the editor or the non-preview part of the FCC site. Anything else is just not realistic.
The preview should be white.
I agree with everyone here on this thread. The preview should remain white. Note that soon the preview won't always be there on the right side "brightening up" the user interface and ruining people's night mode experience.

Soon we will have a single column layout where you the preview only shows up when you click a button to show it, or it loads in a separate tab. - could you update the styling on this so that the preview area is unaffected by our styling?
Definitely.
Change:
Essentially, you will edit and store your code on Ubuntu-18.04 with VS Code installed on Windows. <ins> If you use [IntelliJ Idea](https://www.jetbrains.com/idea/), you may need to update your Node interpreter and Npm package manager to what is installed on your WSL distro. You can check these settings by going to Settings > Languages & Frameworks > Node.js and NPM. </ins> ## Installing Docker Desktop **Docker Desktop for Windows** allows you to install and run database and services like MongoDB, NGINX, etc. This is useful to avoid common pitfalls with installing MongoDB or other services directly on Windows or WSL2.

Discussion:
Description: I use IntelliJ Idea on Windows 10 with WSL2 to run the project locally. The specific problem I ran in to was running tests via the IDE instead of the command line. I had to configure IntelliJ to use the version of Node I have installed in WSL2. This is the error I encountered when trying to run the tests via the IDE: CMD.EXE was started with the above path as the current directory. UNC paths are not supported. Defaulting to Windows directory. 'jest' is not recognized as an internal or external command, operable program or batch file. Recommended fix, suggestions: I think it would be worth while to add a small section to the WSL set up doc () for anyone using IntelliJ products.
I really liked how the Windows and WSL set up guides were easy to read and follow! I think adding this would lower barrier of entry for people who are using or evaluating IntelliJ IDEs. If this change is approved I'd be happy to update this docs :)
Sure, go ahead and add a line to this area:
Change:
); ``` <del> The new image does not have an `src` attribute. Check that there is a space after the opening tag's name and/or there are spaces before all attribute names. </del> <ins> The new image does not have a `src` attribute. Check that there is a space after the opening tag's name and/or there are spaces before all attribute names. </ins> ```js assert($('section')[1].lastElementChild.hasAttribute('src')); ``` <del> The new image should have an `src` value of `https://cdn.freecodecamp.org/curriculum/cat-photo-app/lasagna.jpg`. Make sure the `src` attribute's value is surrounded with quotation marks. </del> <ins> The new image should have a `src` value of `https://cdn.freecodecamp.org/curriculum/cat-photo-app/lasagna.jpg`. Make sure the `src` attribute's value is surrounded with quotation marks. </ins> ```js assert(

Discussion:
I noticed that we are using both "a attribute" and "an attribute" in challenge descriptions. And we even use both in the same challenge (): <img width="596" alt="Screenshot 2024-05-21 at 22 44 29" src=""I think both are acceptable, since the articles depend on how we pronounce "src" ("es-ar-see" vs "source"), but I think we should stick to one for consistency. I'll let native English speakers make the call
I always pronounce it as , so I vote
I'm with Jessica on this one. The second sentence should be changed to .
This issue is open to first-time code contributors to this repository. The files that you should be updating are: Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hi everyone. This is a great pick up! I am happy to help out there and will get a initial PR up for review today :)
I have reviewed the changes made in PR, all the related file have been fixed correctly and checked locally.
Hello, This is my first Open source contribution so if you guys can give me feedback on what i did wrong and how i should correct it please guide me. from the seven files mentioned above, I have created pull request for each one which is as below. sorry if i messed up, as it is my first try. I am actively looking for any advice, suggestion, criticism. Thank You.
Change:
} ``` <del> Use a selector list to center the `h1`, `h2` and `p` elements at the same time. </del> <ins> Delete the three existing type selectors and replace them with one selector list that centers the text for the `h1`, `h2`, and `p` elements. </ins> # --hints--

Discussion:
Campers are creating the new rule set properly but are adding it below the existing rule sets instead of deleting them, which is necessary to pass this step. Even though the hint says "You should only have one selector in your style element." it doesn't seem that they understand what this means. I don't think the instructions make it clear that the three existing rule sets should be deleted and replaced with one new rule set. Perhaps change the instructions to something like: "Replace the three existing type selectors with one selector list that centers the text for the , , and elements." Or even: "Delete the three existing type selectors and replace them with one selector list that centers the text for the , , and elements." No response N/A No response
I like this second option. I think adding this to the instructions will make it more clear.
Change:
<!-- AUDIO REFERENCE: <del> Jake: Hey. You are Sarah, right? I'm Jake, from Security. I'm here to give you your access card. </del> <ins> Jake: Hey. You're Sarah, right? I'm Jake, from Security. I'm here to give you your access card. </ins> --> # --description--

Discussion:
Change "You are Sarah" to "You're Sarah" in step 150, 154, and 155 of Learn Greetings in your First Day at the Office. The change is to match the caption text. (The text isn't visible on the Task 155 page, but in the code.) Change "You are Sarah" to "You're Sarah" in the following files:
We introduce contraction form in task 1 () so I assume we would want to use contractions in later tasks. But I'll wait for the curriculum team to confirm before opening this issue up for contribution. (If we don't want to use contraction in these tasks, the caption text should be updated to match the fill the blank text.)
Change:
# --instructions-- <del> There is a component in the code editor that is trying to render a `name` property from its `state`. However, there is no `state` defined. Initialize the component with `state` in the `constructor` and assign your name to a property of `name`. </del> <ins> There is a component in the code editor that is trying to render a `firstName` property from its `state`. However, there is no `state` defined. Initialize the component with `state` in the `constructor` and assign your name to a property of `firstName`. </ins> # --hints--

Discussion:
A user wondering why his solution passed. I then realized the 2nd test test is not working as intended. The user is supposed to assign a string to a property of . The user's solution assigns an uninitialized variable as a property. The purpose of the test is to make sure the user assigns a string value to a prop named , but the test still allows the user to pass as the prop's value and the test passes. Not sure why, but assigning an uninitialized property to ends up assigned an empty string to it. This of course passes the test requirement but defeats the purpose of the learning here. I suggest changed the required property name to something like , so if a user does something like this, all of the tests will fail. Test in question: The second test should fail because the property of should be undefinedbecause it was not initialized by the user's code. No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
After a bit of research, it appears that assigning as a property that is uninitialized is the same as writing: = { } Since the window has no name, it is just an empty string.
Change:
assert(document.querySelector('img')); ``` <del> Your `img` element should have an `src` attribute. You have either omitted the attribute or have a typo. Make sure there is a space between the element name and the attribute name. </del> <ins> Your `img` element should have a `src` attribute. You have either omitted the attribute or have a typo. Make sure there is a space between the element name and the attribute name. </ins> ```js assert(document.querySelector('img').src);

Discussion:
I noticed that we are using both "a attribute" and "an attribute" in challenge descriptions. And we even use both in the same challenge (): <img width="596" alt="Screenshot 2024-05-21 at 22 44 29" src=""I think both are acceptable, since the articles depend on how we pronounce "src" ("es-ar-see" vs "source"), but I think we should stick to one for consistency. I'll let native English speakers make the call
I always pronounce it as , so I vote
I'm with Jessica on this one. The second sentence should be changed to .
This issue is open to first-time code contributors to this repository. The files that you should be updating are: Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hi everyone. This is a great pick up! I am happy to help out there and will get a initial PR up for review today :)
I have reviewed the changes made in PR, all the related file have been fixed correctly and checked locally.
Hello, This is my first Open source contribution so if you guys can give me feedback on what i did wrong and how i should correct it please guide me. from the seven files mentioned above, I have created pull request for each one which is as below. sorry if i messed up, as it is my first try. I am actively looking for any advice, suggestion, criticism. Thank You.
Change:
'/learn/back-end-development-and-apis/back-end-development-and-apis-projects'; const qaBase = '/learn/quality-assurance/quality-assurance-projects'; const infoSecBase = '/learn/information-security/information-security-projects'; <del> const sciCompPyBase = '/learn/scientific-computing-with-python/' + 'scientific-computing-with-python-projects'; </del> <ins> const sciCompPyBase = '/learn/scientific-computing-with-python'; </ins> const dataAnalysisPyBase = '/learn/data-analysis-with-python/data-analysis-with-python-projects'; const machineLearningPyBase =

Discussion:
Describe the bug Clicking on the certification project name results in both in settings and from the view certification page. ! To Reproduce Steps to reproduce the behavior: to either or (note that you must replace in the link) on a certification project name 404 Page Not Found