jiebi/CodeConvo huggingface dataset:
Change:
isSignedIn, output, theme, <del> tests </del> <ins> tests, isChallengeCompleted </ins> }) );

Discussion:
I am learning from the RWD course, and I wanted to revise what I had done previously. I went to previous steps, but I found that the steps are shown incomplete when I open them. It tells you to do the step again. This doesn't make sense because you have a button at the top if you do want to do the step again. Completed code should be shown in completed challenge's code editor along with an indicator like ! !
It would be relatively easy to show the solution to a step, and the "Step completed" text, (rather than storing the user's code) if a user has already submitted that step. If other maintainers are in favour of this change, I'd be happy to open this up for PRs.
My concern with that approach would be it completely destroys the UX if someone wants to go through a practise project again.
I propose to add a button under the summary of each project for this issue.
I'm not keen on adding a button to do that, given the potential for frustration if someone triggers that accidentally.
I think I'd be in favour of the existing flow, presonally.
At a minimum, we could probably add the checkmark next to "Step 22" like we do for all the other challenges after it has been completed. That seems to be missing here. !
That's a good idea, IMO.
I think just adding that check mark is probably the way to go then. It keeps it consistent with everything else. I'm going to open it up for contributions. If anyone still has reservations, be sure to bring them up.
May I suggest in addition to indicating completed challenges in the challenge itself, to do that in the list of steps. Here is a crude representation of what I have in mind: <p align="center"<img src="https://user-" width=500 align="centre"/</p
I believe it already does that. Here's a screenshot of what the challenge looks like for me, after I've completed it (the steps are highlighted in blue instead of white). !
Also, I would like to work on this issue, and I agree that adding a checkmark next to the step would be a good fix, but I noticed that the RWD courses don't have a step number or title at the top like the other courses do.

For other courses, the checkmark for completion is displayed next to the name of the challenge, like you can see in the first screenshot (of the JS Algorithms & Data Structures courses). However, for the RWD course, there is nothing in this location, as you can see in the second screenshot. ! ! How should we go about adding a checkmark to the RWD course? Should we just put it next to where it says on the screenshot (inside the instructions block)? Or should we move the step number to the same place as where the challenge names are for the other courses and put the checkmark there, in order to be consistent with the other courses?
Thanks I could not log in since yesterday and this is probably the reason I don't see indication for completed challenges in the list of steps.
Change:
You have either deleted the `head` element or it is missing an opening tag or closing tag. ```js <del> assert(code.match(/<head>/) && code.match(/</head>/)); </del> <ins> assert.match(code, /<head>/); assert.match(code, /</head>/); </ins> ``` Your `title` element should be nested in the `head` element. Make sure to add an opening tag and closing tag for the `title` element. ```js const noSpaces = code.replace(/s/g, ''); <del> assert(noSpaces.match(/<head><title>.*</title></head>/)); </del> <ins> assert.match(noSpaces, /<head><title>.*</title></head>/); </ins> ``` Your `title` element should have a closing tag. Closing tags have a `/` just after the `<` character. ```js <del> assert(code.match(/</title>/)); </del> <ins> assert.match(code, /</title>/); </ins> ``` Your `title` element's text should be `CatPhotoApp`. You have either omitted the text or have a typo. ```js <del> assert(document.title && document.title.toLowerCase() === 'catphotoapp'); </del> <ins> assert.equal(document.title?.toLowerCase(), 'catphotoapp'); </ins> ``` # --seed--

Discussion:
We recently updated the guidelines for writing assertions here For consistency and matching what is in the docs, we should slowly start to update the tests for the workshops and labs in the new frontend cert. For this issue, just focus on updating the tests for steps 36 - 40 of the cat photo app workshop. We don't want to have a large PR that updates a whole bunch of tests in a bunch of steps and makes it harder to review. Here is the link to the workshop: The tests should be updated, where appropriate, to use specific methods like , , , etc instead of just . Here is the complete API reference Just focus on the new frontend cert and don't worry about updating the RWD cat photo app since that will become legacy anyway.
Change:
.map-title-completed { margin-left: auto; <del> width: 90px; </del> <ins> width: 100px; </ins> padding-left: 20px; }

Discussion:
Describe the bug When you open a dropdown for any of the certificate, if the subtopic has 3 digit number of challenges it gets pushed to the next line. I think that it would be better if kept in same line. Screenshots ! !
Change:
"The <code>map</code> method is a convenient way to iterate through arrays. Here's an example usage:", "<blockquote>var timesFour = oldArray.map(function(val){<br>&nbsp;&nbsp;return val * 4;<br>});</blockquote>", "", <del> "The <code>map</code> method will iterate through every element of the array, creating a new array with values that have been modified by the callback function, and return it.", </del> <ins> "The <code>map</code> method will iterate through every element of the array, creating a new array with values that have been modified by the callback function, and return it.  Note that it does not modify the original array.", </ins> "In our example the callback only uses the value of the array element (the <code>val</code> argument) but your callback can also include arguments for the <code>index</code> and <code>array</code> being acted on.", <del> "Use the map function to add 3 to every value in the variable <code>oldArray</code>." </del> <ins> "Use the map function to add 3 to every value in the variable <code>oldArray</code>, and save the results into variable <code>newArray</code>. oldArray should not change." </ins> ], "challengeSeed": [ "var oldArray = [1,2,3,4,5];", <del> "var newArray = [];", </del> "", "// Only change code below this line.", "", <del> "newArray = oldArray;" </del> <ins> "var newArray = oldArray;" </ins> ], "tail": [ "(function() {return newArray;})();" ], "tests": [ <ins> "assert.deepEqual(oldArray, [1,2,3,4,5], 'message: You should not change the original array.');", </ins> "assert.deepEqual(newArray, [4,5,6,7,8], 'message: You should add three to each value in the array.');", "assert(editor.getValue().match(/.maps*(/gi), 'message: You should be making use of the <code>map</code> method.');", "assert(editor.getValue().match(/[1,2,3,4,5]/gi), 'message: You should only modify the array with <code>map</code>.');"

Discussion:
There are two exercises dealing with JavaScript array functions that don't change the original array (.map and .filter). It is very confusing to a learner whether to modify the existing array or to assign the results to a separate array. Here's a snippet from The test assertions are all on , meaning it doesn't matter if was changed at all. I have two suggestions, either of which should make these exercises less confusing: Remove all references of and make the test assertions on or Reword the goal statement to : Update the starter code to : This concept would apply to both:
I like suggestion number two :+1:
Change:
# --description-- <del> The `hasatttr` built-in function takes an object as its first argument and a string representing an attribute name as its second argument. It returns a boolean indicating if the object has the specified attribute. </del> <ins> The `hasattr` built-in function takes an object as its first argument and a string representing an attribute name as its second argument. It returns a boolean indicating if the object has the specified attribute. </ins> Now you are going to use the `__init_subclass__` method to check if the child class has the `degree` attribute at the moment of the instantiation.

Discussion:
There’s a typo in the instruction of step 11, which introduces the built-in function hasattr, which is mistyped as “hasatttr”. Campers who follow it would find the console raises “NameError: name ‘hasatttr’ is not defined”. Correct the typo No response Device: PC OS: Windows 10 Browser: Chrome Version: 126.0.6478.182 No response
Thank you for reporting the issue. This issue is open to first-time code contributors to this repository. The file that you should be updating is: We typically do not assign issues. Instead, we accept the most quality contribution followed by the one that is made first. Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Happy contributing.
Thanks for quick response. I have made a pull request.
Change:
# --description-- <del> Back in your event listener, you need to update the text of the `result` element. </del> <ins> Back in your event listener, you need to update the text of the `result` element. You can use a `ternary` operator to achieve this task. Here is an example of assigning the result of a ternary operator to an element's text content: ```js el.textContent = condition ? "Use this text if the condition is true" : "Use this text if the condition is false"; ``` </ins> After the `if` statement, use a ternary operator to check the truthiness of calling `isSpam()` with `messageInput.value` as the argument. If true, set the `textContent` property on the `result` element to `Oh no! This looks like a spam message.`. Otherwise, set it to `This message does not seem to contain any spam.`

Discussion:
We need to show the proper syntax for assiging the result of a ternary operator to a variable's text content as mentioned in this . Let's go with this updated description js el.textContent = condition ? "Use this text if the condition is true" : "Use this text if the condition is false"; ` see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the Happy coding
I guess I'm fine with being this explicit about it and showing an example. But I would hope by now in the curriculum (this challenge is far in) we have promoted the proper usage of the ternary so that it might be handled just in the assert hints. Also, the hint in the assert for the code posted on the forum isn't super helpful in guiding the camper to the desired syntax.
I am not sure how the assert messages would be updated here to show the syntax. Unless we just give them the answer here. I am open to ideas for changes
Change:
**Desktop (please complete the following information):** - OS: [e.g. iOS] <del> - Browser [e.g. chrome, safari] - Version [e.g. 22] </del> <ins> - Browser: [e.g. chrome, safari] - Version: [e.g. 22] </ins> **Smartphone (please complete the following information):** - Device: [e.g. iPhone6] - OS: [e.g. iOS8.1] <del> - Browser [e.g. stock browser, safari] - Version [e.g. 22] </del> <ins> - Browser: [e.g. stock browser, safari] - Version: [e.g. 22] </ins> **Additional context** Add any other context about the problem here.

Discussion:
Describe the bug There's some formatting inconsistency in the issue templates. To Reproduce Steps to reproduce the behavior: to create an issue the issue template and you'll find the formatting inconsistency Screenshots !
Good catch Also want to thank you for helping a new contributor with the process of submitting a pull request.
Change:
"</div>" ], "challengeType": 0, <del> "type": "waypoint" </del> <ins> "type": "waypoint", "nameEs": "Cambia texto con eventos de pulsación", "descriptionEs": [ "Cuando nuestro evento de pulsación ocurre, podemos utilizar Ajax para actualizar un elemento HTML.", "Hagamos que cuando un usuario pulse el botón "Get Message", el texto del elemento con la clase <code>message</code> cambie para decir "Here is the message".", "Podemos hacerlo añadiendo el siguiente código dentro de nuestro evento de pulsación:", "<code>&nbsp;&nbsp;$(".message").html("Here is the message");</code>" ] </ins> }, { "id": "bb000000000000000000002",

Discussion:
[x] Trigger Click Events with jQuery [x] Change Text with Click Events [x] Get JSON with the jQuery getJSON Method [x] Convert JSON Data to HTML [x] Render Images from Data Sources [x] Prefilter JSON [x] Get Geo-location Data
Trabajando en esta
Change:
# --instructions-- <del> Create a function that returns the $ n^{th} $ member of the sequence using the method outlined above. </del> <ins> Create a function that returns the position in the Stern-Brocot sequence at which $ n $ is first encountered, where the sequence is generated with the method outlined above. Note that this sequence uses 1 based indexing. </ins> # --hints--

Discussion:
Describe your problem and how to reproduce it: Challenge description gives slightly different task, to what needs to be done to pass tests. Challenge is about , which looks at the beginning like (skipping zero at start): Challenge description asks to create function returning n-th member of the sequence. However expected values in tests, and sample solution don't match that. sternBrocot(2) should return 3. sternBrocot(3) should return 5. sternBrocot(5) should return 11. sternBrocot(7) should return 19. sternBrocot(10) should return 39. Function matching tests would be one returning at which position in sequence number is encountered for first time. Original challenge on Rosetta Code - have both these variations as a part of task, so that's most likely how it sneaked in. Add a Link to the page with the problem:
I vote to have the function return the position in the sequence of the argument. We wouldn't need to change the tests, just the description.
I'm in favour of that approach as well.
Change:
**Examples** ```js <del> 1 !=  2 1 != "1" 1 != '1' 1 != true 0 != false </del> <ins> 1 !=  2    // true 1 != "1"   // false 1 != '1'   // false 1 != true  // false 0 != false // false </ins> ``` <del> In order, these expressions would evaluate to `true`, `false`, `false`, `false`, and `false`. </del> # --instructions-- Add the inequality operator `!=` in the `if` statement so that the function will return the string `Not Equal` when `val` is not equivalent to `99`.

Discussion:
The student has to go all the way down up to the explanation "In order, these expressions would evaluate to true, false, true, and true." to realize what the result of the operations is. My suggestion is that the second section of the code should look like this: 1 == 1 // true 1 == 2 // false 1 == '1' // true "3" == 3 // true instead of the screenshot attached. <!-- Add a link to the coding challenge with the problem. -- <!-- If applicable, add screenshots to help explain your problem. you can drag and drop, png, jpg, gif, etc. in this box. --!
I would be fine with this change. Any interest in making a PR for it
, Can I? I don't know how to do it and I have never done it in my life, but besides that, I would like to do it by myself using some guide you could give me. I have never used GitHub in the past. And this will help me to contribute even more to this awesome project.
We have some . It may look a little intimidating, but if you follow the instructions it's not bad. The file where this needs to be fixed is Technically, you can edit the file on github and make a PR from there - which can work for some simple fixes, but you can't see and test your changes. I think we would accept those if you want to do that, but I would recommend setting the project up locally at some point if you want to contribute regularly. To be clear, we usually like to get second opinion before making changes like this - since we don't have that, I can't guarantee a PR would be merged - but I think others would be fine with the change so if you want to make a PR, go ahead.
This change seems good. For context, we got rid of a lot of comments since we'd need to translate them. However, these are keywords and don't need translation.
shall I take this up?
Could you clarify if this is actually what we wanted, because this is exactly what we removed 12 months ago in:
Yes, this is okay because these instances specifically are only keywords that don't get translated anyway.
Change:
## The `dashedName` Property <del> The `dashedName` property is used to generate the URL path for the superblock, block, or challenge. These should generally match what the `/utils/dasherize.js` helper would output for the file name. </del> <ins> The `dashedName` property is used to generate the URL path for the superblock, block, or challenge. These should generally match what the `/utils/slugs.js` helper would output for the file name. </ins>

Discussion:
In the The Property section of Curriculum File Structure documentation there's reference to file. That file no longer exists, and the relevant helper function is now in file. It's needed to point to the correct file and/or adjust the wording in the section. Here are the files that you should be looking at to work on a fix: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Change:
`<a href="http://freecodecamp.org"> ... </a>` <del> The text, `link to freecodecamp.org`, within the `a` element is called `anchor text`, and will display the link to click: </del> <ins> The text, `link to freecodecamp.org`, within the `a` element is called <dfn>anchor text</dfn>, and will display the link to click: </ins> `<a href=" ... ">link to freecodecamp.org</a>`

Discussion:
Within the the text which reads: is incorrectly formatted - "anchor text" is within backticks and is thus untranslatable on Crowdin. The text in the English file should be updated to use tags instead: This issue is open to first time contributors for this repository. If you are interested in contributing, we recommend you start by reading our . And if you run in to any issues or have any questions, you can reach us in our .
Hi . I would like to work on this.
Hey there Thank you for your interest in contributing. Note that we do not typically assign issues except to long-term contributors. Instead, we generally review and merge the first pull request which comprehensively resolves the issue. Feel free to let us know if you have any questions.
Change:
--- title: Cooling Systems --- <del> Your computer contains many parts that generate heat. Heat can cause premature failure and erratic behaviors. The more you overclock the graphics or the CPU, the hotter the computer will run. Cooling systems assure that your computer is stable and you extend the life of your investment. </del> <ins> Your computer contains many parts that generate heat. Heat can cause premature failure and erratic behaviors. The more you overclock the graphics or the CPU, the hotter the computer will run. Cooling systems assure that your computer is stable and help you extend the life of your investment. </ins> ## Case Cooling <del> Case cooling can be a combination of a well ventilated case and the use of fans to circulate air within the case. Most cases come with at least one fan. This is the minimum configuration. For best results, there be at least two fans in the case. One is as an intake to draw in cold air while the other is an exhaust to expel hot air. There are many different types of fans and configurations. Cable management also plays a huge part in cooling the system. Bad cable management and tangled wires disrupt airflow and cause dust to accumulate inside the case. </del> <ins> Case cooling can be a combination of a well ventilated case and the use of fans to circulate air within the case. Most cases come with at least one fan. This is the minimum configuration. For best results, there should be at least two fans in the case. One should be used as an intake to draw in cold air while the other should be an exhaust to expel hot air. There are many different types of fans and configurations. Cable management also plays a huge part in cooling the system. Bad cable management and tangled wires disrupt airflow and cause dust to accumulate inside the case. </ins> ## Components Cooling Cooling devices are available for individual parts on the computer. The two most common are coolers for CPU's and graphics cards. There are generally two types of component cooling systems, active and passive. <del> * Passive Systems - Usually consist of a heat sink or a heat conductive metal attached to the component. Passive cooling works by providing a larger surface to adsorb and dissipate the heat. </del> <ins> * Passive Systems - Usually consist of a heat sink or a heat conductive metal attached to the component. Passive cooling works by providing a larger surface to absorb and dissipate the heat. </ins> * Active Systems - Add a fan to the heat sink and you are actively removing heat. The cooling fan can be dynamically adjusted to the load of the CPU or graphics card on most motherboards. * Liquid Cooling - High performance computers can benefit from a liquid cooled system. These types of systems circulate a liquid between the hot components and a cooling radiator.

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Add a Link to the page with the problem: If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): !
I'm taking this
Change:
background-color: #c9d2fc; } <ins> --fcc-editable-region-- </ins> .cat-head { width: 205px; height: 180px; border: 1px solid #000; border-radius: 46%; <del> --fcc-editable-region-- --fcc-editable-region-- </del> } <ins> --fcc-editable-region-- </ins> ```

Discussion:
I've run into this several times in the forum in the past week. The active editor is placed within the existing rule set and apparently people don't notice that and instead create a new rule set and add the there. This is what I'm seeing in the forum: I think the active editor should include the entire existing rule set so that it is clear it already exists and that that is where the property should be . We can add an empty line at the bottom of the rule set to indicate where the property should go. No response N/A No response
I definitely agree. I went ahead and made a PR that moves the editable region to include the full selector.