jiebi/CodeConvo huggingface dataset:
Change:
To run all Playwright tests, run the following command: ```bash <ins> cd e2e </ins> npx playwright test ```

Discussion:
In "Playwright-Gitpod Setup" section of "How to add Playwright" tests page, it's missing the step: cd to e2e directory, readers can be confusing and run the command in the root directory, this will cause error to "How to add Playwright tests" page, "Playwright-Gitpod Setup" section: step 3, you can see the missing step: cd to e2e directory (this step is in section) Update the doc to add the missing step !
An issue with the label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the To close this, add within the same codeblock as the text. The file to change is located within the directory. Only the English file should be changed.
updated the documentation part of playwright tests
If you've made a fix, you can Let us know if you need any help.
I'm new to contributing and I really don't know a thing about how to do it or its working Please help me in my learning
You can read this guide:
Change:
assert(document.querySelector('tbody')?.querySelectorAll('tr')?.[3]?.querySelectorAll('td')?.[2]?.textContent === '$809'); ``` <ins> Your third `td` element should have the `class` attribute set to `current`. ```js assert(document.querySelector('tbody')?.querySelectorAll('tr')?.[3]?.querySelectorAll('td')?.[2]?.classList?.contains('current')); ``` </ins> # --seed-- ## --seed-contents--

Discussion:
As i love free code ; I would like to inform the problem and stay as minimal as i can. staight on problem. in : Responsive Web Design Learn More About CSS Pseudo Selectors By Building A Balance SheetQUALITY CONTROL DEGRADING CODE ROBUSTNESS. 47: <tr class="data"48: <thSavings <span class="description"Funds set aside for emergencies.</span</th49: <td650</td51: <td 500</td<td728</td<---------- answered passed without this line of code. </tr! ! Device: [Asus f17 gaming] OS: [ Windows 11] Browser: [Chrome] thanks for such a go tutorial platform!
Hi thanks for the report. Could you share your full code here so that we can dig into what's going wrong?
Edit: I backticks for clarity.
Thanks for sharing that but the code you shared passes the tests. That's expected, since it has in the correct place. If I remove then it fails, as it should. From your screenshot, it looked like you'd entered invalid code (i.e. without ) and managed to pass the tests. However, I've been unable to replicate this behaviour. If you have an example of invalid code that passes, could you share it here?
first screen shot mentions step 15, the second one shows 16. Isn't the issue in the step 16?
but it is there in step 16 code
yes in hurry i was not able to give accurate problem details. IT IS IN STEP 16 THANKS BRO
Silly me newbie.
Okay, that makes sense, thanks for clarifying. To fix this, there needs to be one more test that asserts that is set on the third element.
sir did u get what i want to say? as if not possible is it allowed to express it on video call? if okay so? like on ms teams.
Hey we understand the issue and have a pull request open to address it. Thank you for reporting. We will get the fix in as soon as we can
Change:
editorDidMount={editorDidMount} editorWillMount={editorWillMount} onChange={onChange} <del> options={options} </del> <ins> options={{ ...options, folding: !hasEditableRegion() }} </ins> theme={editorTheme} /> </span>

Discussion:
Steps to reproduce the behavior: on toggle button(code folding) on line 36 of the code editor (check screenshots) error no idea ! ! <!-- Please complete the following information. --- Device: Laptop OS: Windows 10 Browser: firefox Version: 98.0.1 (64-bit) <!-- Add any other context about the problem here. --
The UI is designed with the assumption that the editable region is visible and will be surrounded by the instructions and the Check Your Code button. With the editable region hidden the UI will look quite confusing. I think the best solution would simply be to disable folding for project steps. Folding is an editor option, , so we can disable it.
I'd be in favour of that solution. Should just be a matter of adding to this editor options object right?
I think so, yeah. We could make it conditional: false if there's an editable region and true otherwise. That might be nice if you're working on a project using the multifile editor, since they can be quite large and don't have editable regions.
I'll go ahead and open this one up for contribution then
Change:
"assert.deepEqual(drawer(19.50, 20.00, [["PENNY", 1.01], ["NICKEL", 2.05], ["DIME", 3.10], ["QUARTER", 4.25], ["ONE", 90.00], ["FIVE", 55.00], ["TEN", 20.00], ["TWENTY", 60.00], ["ONE HUNDRED", 100.00]]), [["QUARTER", 0.50]], 'message: <code>drawer(19.50, 20.00, [["PENNY", 1.01], ["NICKEL", 2.05], ["DIME", 3.10], ["QUARTER", 4.25], ["ONE", 90.00], ["FIVE", 55.00], ["TEN", 20.00], ["TWENTY", 60.00], ["ONE HUNDRED", 100.00]])</code> should return <code>[["QUARTER", 0.50]]</code>.');", "assert.deepEqual(drawer(3.26, 100.00, [["PENNY", 1.01], ["NICKEL", 2.05], ["DIME", 3.10], ["QUARTER", 4.25], ["ONE", 90.00], ["FIVE", 55.00], ["TEN", 20.00], ["TWENTY", 60.00], ["ONE HUNDRED", 100.00]]), [["TWENTY", 60.00], ["TEN", 20.00], ["FIVE", 15], ["ONE", 1], ["QUARTER", 0.50], ["DIME", 0.20], ["PENNY", 0.04]], 'message: <code>drawer(3.26, 100.00, [["PENNY", 1.01], ["NICKEL", 2.05], ["DIME", 3.10], ["QUARTER", 4.25], ["ONE", 90.00], ["FIVE", 55.00], ["TEN", 20.00], ["TWENTY", 60.00], ["ONE HUNDRED", 100.00]])</code> should return <code>[["TWENTY", 60.00], ["TEN", 20.00], ["FIVE", 15], ["ONE", 1], ["QUARTER", 0.50], ["DIME", 0.20], ["PENNY", 0.04]]</code>.');", "assert.deepEqual(drawer(19.50, 20.00, [["PENNY", 0.01], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 0], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]]), "Insufficient Funds", 'message: <code>drawer(19.50, 20.00, [["PENNY", 0.01], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 0], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]])</code> should return "Insufficient Funds".');", <ins> "assert.deepEqual(drawer(19.50, 20.00, [["PENNY", 0.01], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 1.00], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]]), "Insufficient Funds", 'message: <code>drawer(19.50, 20.00, [["PENNY", 0.01], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 1.00], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]])</code> should return "Insufficient Funds".');", </ins> "assert.deepEqual(drawer(19.50, 20.00, [["PENNY", 0.50], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 0], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]]), "Closed", 'message: <code>drawer(19.50, 20.00, [["PENNY", 0.50], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 0], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]])</code> should return "Closed".');" ], "MDNlinks": [

Discussion:
The instinct on this bonfire is to total up all the change in the drawer to determine whether this is greater than the amount required. This will, however, miss the case where you don't have sufficient lower denominations to make change. In this case, we have a total of 2.50. A test should be written to check for a return value of 'Insufficient Funds' in this case.
I agree, I notice this today so it's still hasn't been resolved. I tested one where I was short two pennies... should I just give the customer back a nickel? ha! FYI that I created an "if" statement at the end that if the amount due doesn't equal zero, then it returns "Insufficient Funds" instead of the array of denominations.
Change:
<SectionHeader>Privacy Settings</SectionHeader> <FullWidthRow> <p> <del> The settings in this section enable you to control what is show on{' '} </del> <ins> The settings in this section enable you to control what is shown on{' '} </ins> your freeCodeCamp public portfolio. </p> <ins> <p>There is also a button to see what data we hold on your account</p> </ins> <ToggleSetting action='Make my profile completely private' explain={

Discussion:
Once we've built the JSON we want to output, I believe we can just use Pug like this for the button to initiate the file download:
Change:
"</div>" ], "challengeType": 0, <del> "type": "waypoint" </del> <ins> "type": "waypoint", "nameEs": "Recibir datos de Geo-localización", "descriptionEs": [ "Otra cosa interesante que podemos hacer es acceder a la ubicación actual de nuestros usuarios. Todos los navegadores han incorporado un geo-localizador que nos puede dar esta información. ", "El navegador puede obtener la longitud y latitud actual de nuestros usuarios.", "Como usuario verás un mensaje para permitir o evitar que el sitio conozca tu ubicación actual. El desafío se puede completar de cualquier manera, siempre y cuando el código sea correcto. ", "Si lo permites, verás que el texto en el teléfono de la derecha cambiará con tu latitud y longitud", "Aquí hay un código que hace esto:", "<code>if (navigator.geolocation) {</code>", "<code>&nbsp;&nbsp;navigator.geolocation.getCurrentPosition(function(position) {</code>", "<code>&nbsp;&nbsp;&nbsp;&nbsp;$("#data").html("latitude: " + position.coords.latitude + "&lt;br&gt;longitude: " + position.coords.longitude);</code>", "<code>&nbsp;&nbsp;});</code>", "<code>}</code>" ] </ins> } ] }

Discussion:
[x] Trigger Click Events with jQuery [x] Change Text with Click Events [x] Get JSON with the jQuery getJSON Method [x] Convert JSON Data to HTML [x] Render Images from Data Sources [x] Prefilter JSON [x] Get Geo-location Data
Trabajando en esta
Change:
FormGroup, ControlLabel, Button, <del> Col </del> <ins> Col, Row </ins> } from '@freecodecamp/react-bootstrap'; import Helmet from 'react-helmet';

Discussion:
<img width="616" alt="Screen Shot 2019-10-01 at 3 26 24 PM" src="https://user-"This is a picture of my own private profile locally, seems like it should say something like "You have not made your profile public" instead of "mot01 has not made their profile public" And as I'm typing this, I'm wondering if a profile should render completely if it's theirs, even if it's not public - there's no way for a user to see what their profile would look like if they don't have it public.
That does look better. The next sentence should be something like "You need to change your privacy settings in order for other people to view your profile". So, they should be able to preview their public profile, basically? Sounds good. If going that route, it would be good to emphasise (even more than currently) that their preview is not public. It wouldn't be good if people went to their preview, saw that it looked right and didn't notice that they were the only people that could see it.
Yes to this, please open a PR. It seems to have been an oversight. I think it's fair to leave the warning on their own pages while showing this page in that case, which means we may need to update the copy for them.
Can you clarify what you want here I'm not sure I understand - do we want to keep the page how it is, and just change the two sentences? Or do we want to display their private profile for them?
Yes. Sorry about being vague last time. I thought about this a little more and I think we should show the users their own profile only when they are signed in. Here is what we should achieve at the end of the day: profiles which are public are visible by default. settings button is only available if the user is on their own profile page. who are not signed in and are visiting profiles which are not public and are not their own are shown the current notice and warnings: ! who are signed in and are visiting their own private profiles are shown the same notice as the above screenshot in point 3 with the verbiage stating "You" and the settings button available. The rest of the their profile is visible as a preview.

So, there'd be a button on their private profile labelled 'Preview profile' and a label 'preview how your profile would look if you made it public'. Clicking that would take them to, say, which shows the preview (and a notice saying that it's currently private). Something like that?
Nope, we do not need a new route. Their profiles can be rendered just below the notice like so: ! Here is the copy: You have not made your profile public. You need to change your privacy setting in order for your profile to be seen by others. This is a preview of how your profile will look when made public.
Change:
```yml question: <del> text: 'What type of HTTP is request is usually used to access a website?' </del> <ins> text: 'What type of HTTP request is usually used to access a website?' </ins> answers: - 'POST' - 'GET'

Discussion:
Describe your problem and how to reproduce it: Not Major: The sentence grammar should read: What type of HTTP request is usually used to access a website? Currently reads: What type of HTTP is request is usually used to access a website? Add a Link to the page with the problem:
Change:
ROLLBAR_CLIENT_ID='post_client_id from rollbar dashboard' ALGOLIA_ADMIN_KEY=123abc <del> ALGOLIA_APP_ID=ACDEFG ALGOLIA_API_KEY=123abc </del> <ins> ALGOLIA_APP_ID='Algolia app id from dashboard' ALGOLIA_API_KEY='Algolia api key from dashboard' </ins> AUTH0_CLIENT_ID=stuff AUTH0_CLIENT_SECRET=stuff

Discussion:
Is there any reason not to put the real and in ? I reflexively put in a dummy key when I set this up, but now that I revisit this, that seems like a mistake.
Yes, actually it broke the .dev build unsurprisingly , I think noticed it and reported in the team chat. My bad for not catching this previously. The real fix is to ignore and move ahead when the keys are not available are default. We do this with google application credentials.
Oh, I assume it broke the build because .dev isn't using I didn't think of that... So, we should implement the fix and add the public keys to , right?
I was thinking something more along the lines of (example from api-server): I would try to avoid hundreds of contributors hitting the indexes locally. Ideally people should get their own keys. While the key and index is public, it's still not recommended to hit it?
As for the production keys, it's actually fine because the build should fail. I have since the keys in the build pipeline.
One thing: if we don't want contributors spamming search (fair enough!) I think there should be some docs that let people know what's what. Either that search isn't available in development or the steps they need to take to make it work.
I agree. We should add some docs on getting keys, or perhaps creating a test index and sharing that instead
Change:
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment videoId={videoId} /> <del> <i> <a href={ 'https://www.youtube.com/timedtext_editor?action_mde_edit_form=1&v=' + videoId + '&lang=en&bl=watch&ui=hd&ref=wt&tab=captions' } rel='noopener noreferrer' target='_blank' > {t('learn.add-subtitles')} </a> . </i> </del> </div> </Col> <Col md={8} mdOffset={2} sm={10} smOffset={1} xs={12}>

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Affected page Add a Link to the page with the problem. To Reproduce Steps to reproduce the behavior: to the video text "Help improve or add subtitles" is obscured by the video Expected behavior Either this text should be visible or the code should be removed. Screenshots The text is underneath this corner of the video. !
YouTube doesn't allow anymore for crowd sourcing subtitles If we don't have a different alternative it should be to remove the improve subtitles link for that challenge brings to a 404 page, I imagine all the others too if maybe there is a different service that allows for crowdsourcing subtitles the link could be updated (and the text made visible)
Change:
} </style> <header> <del> <img src="https://freecodecamp.s3.amazonaws.com/quincy-twitter-photo.jpg" alt="Quincy Larson's profile picture" class="profile-thumbnail"> </del> <ins> <img src="https://cdn.freecodecamp.org/curriculum/legacy-css-flexbox/quincy-twitter-photo.jpg" alt="Quincy Larson's profile picture" class="profile-thumbnail"> </ins> <div class="profile-name"> <h3>Quincy Larson</h3> <h4>@ossia</h4>

Discussion:
We need to replace all images and audio samples for the legacy content with the ones that were just to our freeCodeCamp cdn. Here are all of the files that will need to be updated Here are all of the new asset links
Change:
} </style> <header> <del> <img src="https://freecodecamp.s3.amazonaws.com/quincy-twitter-photo.jpg" alt="Quincy Larson's profile picture" class="profile-thumbnail"> </del> <ins> <img src="https://cdn.freecodecamp.org/curriculum/legacy-css-flexbox/quincy-twitter-photo.jpg" alt="Quincy Larson's profile picture" class="profile-thumbnail"> </ins> <div class="profile-name"> <h3>Quincy Larson</h3> <h4>@ossia</h4>

Discussion:
All links in the english curriculum need to be replaced. This is the last of the S3 links Here are the new CDN links that should be used instead multiple see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Change:
.modal-dialog { .modal-content { background-color: @gray; <ins> .btn-success, .btn-danger { background: #FFFFFF; } </ins> } .modal-header, .modal-footer {

Discussion:
<!-- freeCodeCamp Issue Template --<!-- Please provide as much detail as possible for us to fix your issue --<!-- Remove any heading sections you did not fill out --<!-- NOTE: If your issue is CodePen Project / Test Suite related, please open it using the below URL instead --<!-- --My Profile -Update My Settings -Reset Progress/Brownie Points <!-- Describe below when the issue happens and how to reproduce it --The confirmation popup window, the text is not readable. Either the background is too dark because its in dark mode or the buttons should be filled in and the text be in white <!-- Describe your workspace in which you are having issues--Browser Name, Version: Operating System: FireFox 57.0 (64-bit) and Chrome Version 63.0.3239.84 (Official Build) (64-bit) Mobile, Desktop, or Tablet: Laptop Windows 10 Professional 64-bit <!-- If relevant, paste all of your challenge code in here --<!-- Add a screenshot of your issue --!
Fixing this with . I'll be waiting for your review.
Change:
assert.equal(document.querySelector('img')?.id, 'logo'); ``` <ins> You should give the `img` element an `alt` attribute of `freeCodeCamp`. ```js assert.equal(document.querySelector('img')?.alt, 'freeCodeCamp'); ``` </ins> You should give the `h1` element the text `HTML/CSS Quiz`. ```js

Discussion:
[X] The "CSS" and the have the same value. This is affecting screen reader users since this involves an input and associated label. [ ] The logo in the upper left needs alt text. I would suggest it just be "freeCodeCamp". A lot of them. N/A Resolved Add alt text to the logo. Do we need to add an extra step for this or can we just add it to ? No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Seeing as the logo is non-functional, do we want the alt to be null? ? If it does require an , then this should get its own step, and a clear description as to why it needs one should be given. I suggest changing the of the (and associated ) to .
Per , the logo does require alt text. Functionality isn't the deciding factor here, it's if the image conveys information (i.e. is not purely decorative), which this image clearly does. Do we want to split this off into its own issue if we are going to create a new step?
I would say yes, but it is not fun to deal with the merge conflict, when two PRs are opened at the same time.
The logo still needs an alt text. The logo is introduced in step 7: That step should be updated to instruct campers to give the an alt text of . The seed code in all subsequent steps should be updated to include that new attribute.
hey may i work on this issue? if so please assign it to me
Hey We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
Change:
.then(checkFilesErrors) .then(files => ({ challengeType: challengeTypes.html, <del> build: concatHtml({ required: finalRequires, template, files, theme }), </del> <ins> build: concatHtml({ required: finalRequires, template, files }), </ins> sources: buildSourceMap(files), loadEnzyme }));

Discussion:
I did not see anyone raising this issue, but I don't think the background of the preview in default or night mode should be anything other than white unless the coding exercise specifically changes the background to something else. The preview should be exactly what you would see in a browser. In almost all the challenges, the background would be white. !
I share your concerns The reason we changed the color of the display is that a white display is discomforting to the eye on night mode when everything else is dark. so we injected some styles to harmonize the view in general. That convention was carried over to light mode.
It might be better to default to white in light mode, same as the editor. As for night mode, some of the css challenges might need some changes to look reasonable in both modes. For instance, in night mode, looks like this: ! If we change the seed code to it would become ! It would have to be case-by-case, though.
That is a very good point. I will defer this to
Logically, I have to agree with - displaying anything other than what the code in the editor would produce might confuse campers. But it is a little rough on the eyes to have the white background on night mode. And the current theme looks a lot better - so it's a tough call. I scrolled through a number of challenges, and there's quite a few that don't look right with the blue background. So there might be a decent amount of work to go through and fix all of them.
I really like the new theme, but a preview should be a true preview. We want to make this like the real world. Developers working in some kind of night mode on their favorite local editors, still expect to check the "real" result of the code they have written on a browser or in a preview mode in their local editors. The night mode should only apply to the editor or the non-preview part of the FCC site. Anything else is just not realistic.
The preview should be white.
I agree with everyone here on this thread. The preview should remain white. Note that soon the preview won't always be there on the right side "brightening up" the user interface and ruining people's night mode experience.

Soon we will have a single column layout where you the preview only shows up when you click a button to show it, or it loads in a separate tab. - could you update the styling on this so that the preview area is unaffected by our styling?
Definitely.