jiebi/CodeConvo huggingface dataset:
Change:
)}`} onChange={this.handleInputChange} data-index={node.value} <del> style={{ width: `${ blankAnswers[node.value].length * 11 + 11 }px` }} </del> <ins> size={blankAnswers[node.value].length} </ins> aria-label={t('learn.blank')} /> );

Discussion:
In the fill in the blank challenges, the size of the blanks are based on the number of characters in that blank. It's 11px per letter, plus an additional 11px buffer - This works pretty good, but sometimes you get a word with really wide letters and it doesn't fit: <img width="774" alt="Screenshot 2024-06-17 at 5 36 44 PM" src=""^ You can see is a little too wide to fit because it has wide letters. Other times, you have a bunch of narrow letters like with in the image. That fits, but there's more space on each side than needed. The challenge I noticed this on is still in beta, so you will have to run the repo with upcoming changes shown to see this specific one - but you can see it in any of the fill in the blank challenges. to http://localhost:8000/learn/a2-english-for-developers/learn-how-to-document-code-for-a-project/task-38 in the first blank that one of the letters gets cut off. The in firefox, the in Chrome. So browsers are handling it differently. in the third blank the extra space in the input before and after the word. See the image above The answers to fit in the blanks better. I think the solution I would prefer is to make a map of the letters and their spacing and make the size of the input based on what letters are in the answers. Or perhaps just a default size of the 11px or something, and a small group of narrow letters that get maybe 8, and small group wide letters that get maybe 13 or something. Or perhaps we could use a monospace font.
Not sure why, but this is what it looks like for me (Chrome, and in incognito/on Windows). ! Also, the text color doesn't seem to change to white in night mode.
I don't think monospace fonts are quite the answer; at least not itself. ! Sure it's fine for say the word "When" but for "descriptive", it's a little bigger than the blank.
I'm only using the font for the blanks, but the point remains the same.
I think using 14 maxlength will be be a better solution. before : ! after !
That's not a viable solution.

That's hard-coding a value for this one specific input. They're dynamically generated we can't do that.
I think this is the way to go. Then we can reliably know the size of every character, space our inputs accordingly, and we get the feature of visual feedback when a word is too long for that blank.
This is because the spacing is configured for 11px wide characters. I'd be willing to bet that monospace font is bigger. :)
Change:
**Examples** ```js <del> 3 !==  3 3 !== '3' 4 !==  3 </del> <ins> 3 !==  3  // false 3 !== '3' // true 4 !==  3  // true </ins> ``` <del> In order, these expressions would evaluate to `false`, `true`, and `true`. </del> # --instructions-- Add the strict inequality operator to the `if` statement so the function will return the string `Not Equal` when `val` is not strictly equal to `17`

Discussion:
The student has to go all the way down up to the explanation "In order, these expressions would evaluate to true, false, true, and true." to realize what the result of the operations is. My suggestion is that the second section of the code should look like this: 1 == 1 // true 1 == 2 // false 1 == '1' // true "3" == 3 // true instead of the screenshot attached. <!-- Add a link to the coding challenge with the problem. -- <!-- If applicable, add screenshots to help explain your problem. you can drag and drop, png, jpg, gif, etc. in this box. --!
I would be fine with this change. Any interest in making a PR for it
, Can I? I don't know how to do it and I have never done it in my life, but besides that, I would like to do it by myself using some guide you could give me. I have never used GitHub in the past. And this will help me to contribute even more to this awesome project.
We have some . It may look a little intimidating, but if you follow the instructions it's not bad. The file where this needs to be fixed is Technically, you can edit the file on github and make a PR from there - which can work for some simple fixes, but you can't see and test your changes. I think we would accept those if you want to do that, but I would recommend setting the project up locally at some point if you want to contribute regularly. To be clear, we usually like to get second opinion before making changes like this - since we don't have that, I can't guarantee a PR would be merged - but I think others would be fine with the change so if you want to make a PR, go ahead.
This change seems good. For context, we got rid of a lot of comments since we'd need to translate them. However, these are keywords and don't need translation.
shall I take this up?
Could you clarify if this is actually what we wanted, because this is exactly what we removed 12 months ago in:
Yes, this is okay because these instances specifically are only keywords that don't get translated anyway.
Change:
You should have an opening `<html>` tag with a `lang` attribute of `en`. ```js <del> assert(code.match(/<htmls+lang=('|")en1s*>/i)); </del> <ins> assert(code.match(/<htmls+langs*=s*('|")en1s*>/gi)); </ins> ``` You should have a closing `<html>` tag. Remember that closing tags have a `/` following the opening `<` bracket.

Discussion:
In step 1 of building a cafe menu, the attribute test is strict with space Here is the markdown file The code above should pass, for this to happen you should change to ! Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
Can I work on this issue ?
Yes، feel free to open a pull request
Change:
npm run delete-step X # where X is the step number to be deleted. ``` <del> ## update-step-titles </del> <ins> ### update-step-titles </ins> A one-off script that automatically updates the frontmatter in a project's markdown files so that they are consistent with the project's meta.json. It ensures that each step's title (and dashedName) match the meta's challengeOrder. <del> ### How to run script </del> <ins> #### How to run script </ins> 1. Change to the directory of the project. 2. Run the following npm command:

Discussion:
challenge-editor should be to the "How to work on practice projects" documentation here:
I'll tackle this today.
Change:
"description": [ "With JavaScript <code>array</code> variables, we can store several pieces of data in one place.", "You start an array declaration with an opening bracket, end it with a closing bracket, and put a comma between each entry, like this: <code>var sandwich = ["peanut butter", "jelly", "bread"]</code>.", <del> "Now let's create a new array called <code>myArray</code> that contains both a <code>string</code> and a <code>number</code>.", </del> <ins> "Now let's create a new array called <code>myArray</code> that contains both a <code>string</code> and a <code>number</code> (in that order).", </ins> "Refer to the comments if you get stuck." ], "tests": [

Discussion:
Challenge has an issue. Please describe how to reproduce it, and include links to screenshots if possible. Wants an array with a string and number. If you make the number the first element in array, it tells you that's wrong IE: var myArray = [12, "hi"]; The first item in myArray should be a string The Directions make no mention of the string having to be first
Thanks Would "Now let's create a new array called myArray that contains both a string and a number (in that order)." make this clearer for you? Or do you have a better suggestion?
Change:
- text: No global <code>myVar</code> variable testString: assert(typeof myVar === 'undefined', 'No global <code>myVar</code> variable'); - text: Add a local <code>myVar</code> variable <del> testString: assert(/vars+myVar/.test(code), 'Add a local <code>myVar</code> variable'); </del> <ins> testString: assert(/functions+myLocalScopes*(s*)s*{s[sS]+s*vars*myVars*(s*|=[sS]+)s*;[sS]+}/.test(code), 'Add a local <code>myVar</code> variable'); </ins> ```

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: While working inside the coding challenge "Basic JavaScript: Local Scope and Functions", I found out that while the challenge works fine if you declare a local 'var' variable inside the function 'myLocalScope' and then deleting the log out at the end. as usual. But, initially accidentally I wasn't paying attention and declared the 'myVar' outside of the function scope just below its call, and the challenge validated it as correct and completed the test. Not being a complete beginner I was able to recognize the problem, but I am aware most beginners maybe stumble upon this problem and accidentally may learn the wrong thing or may NOT learn this properly. The test looks out for global variables as variables not being declared by any 'var' keyword but it misses out variable declarations outside of the scope of the function but using the 'var' keyword, which are also global variables and shouldn't be validated. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Safari Browser Version: 12.0.2 (.3.4)(Latest) Operating System: MacOS Mojave 10.14.2 If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): <img width="1388" alt="screenshot 2019-01-19 at 8 31 05 pm" src="https://user-"<img width="1214" alt="screenshot 2019-01-19 at 8 33 06 pm" src="https://user-"
I have opened a PR, which modifies the test case for checking if the variable is a local scope of the function. Did a regex test
Hopefully this fixes the issue. Even though I think it was already throwing an error if we declare a global variable (by not using var keyword) But the bug came when we used the var keyword.
Change:
} .footer-col a { <del> padding: 5px 0px; </del> <ins> padding: 5px 0; </ins> } .footer-desc-col {

Discussion:
found an issue: Unexpected shorthand &quot;padding&quot; after &quot;padding-bottom&quot; (declaration-block-no-shorthand-property-overrides) It's currently on:
I'm happy to fix this (and remove the units from zero values also in that file), but I'm not sure what the preferred replacement is for the padding. Should I just remove the padding: and add lines for padding-top: 0; padding-right: 15px; to reflect the styles currently specified by the padding: 0 15px 15px line?
I would delete , you can start and these question will be answer by reviewers if they need changes later
Change:
# --instructions-- <del> Time to take a break from Camper Cat and meet fellow camper Zersiax (@zersiax), a champion of accessibility and a screen reader user. To hear a clip of his screen reader in action, add an `audio` element after the `p` element. Include the `controls` attribute. Then place a `source` element inside the `audio` tags with the `src` attribute set to `https://s3.amazonaws.com/freecodecamp/screen-reader.mp3` and `type` attribute set to `"audio/mpeg"`. </del> <ins> Time to take a break from Camper Cat and meet fellow camper Zersiax (@zersiax), a champion of accessibility and a screen reader user. To hear a clip of his screen reader in action, add an `audio` element after the `p` element. Include the `controls` attribute. Then place a `source` element inside the `audio` tags with the `src` attribute set to `https://cdn.freecodecamp.org/curriculum/applied-accessibility/screen-reader.mp3` and `type` attribute set to `"audio/mpeg"`. </ins> **Note:** The audio clip may sound fast and be difficult to understand, but that is a normal speed for screen reader users.

Discussion:
All links in the english curriculum need to be replaced. This is the last of the S3 links Here are the new CDN links that should be used instead multiple see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Change:
}); function bonfireExecute() { <ins> attempts++; ga('send', 'event',  'Bonfire', 'ran-code', bonfireName); </ins> userTests= null; $('#codeOutput').empty(); var userJavaScript = myCodeMirror.getValue(); userJavaScript = removeComments(userJavaScript); userJavaScript = scrapeTests(userJavaScript); // simple fix in case the user forgets to invoke their function <del> if (challengeEntryPoint) { </del> <ins> if (challengeEntryPoint && challengeSeed) { </ins> userJavaScript = challengeEntryPoint + ' ' + userJavaScript; } <ins> console.log(userJavaScript); </ins> submit(userJavaScript, function(cls, message) { if (cls) { codeOutput.setValue(message.error);

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --In the challenge CSS Flexbox: Use the flex-wrap Property to Wrap a Row or Column, the value wrap-reverse is defined: wrap-reverse: "wraps items from right-to-left if they are in a row, or bottom-to-top if they are in a column." This definition is not correct. Actually wrap-reverse wrap content changing de cross-axis direction, bottom to top in a row, and left to right in a column. Browser Name: Browser Version: Operating System:
I'd like to take on this issue please
Since the curriculum content is in the repo, I submitted the PR there.
Ok, thanks Simon.
Change:
## Description <section id='description'> You are given two arrays and an index. <del> Use the array methods <code>slice</code> and <code>splice</code> to copy each element of the first array into the second array, in order. </del> <ins> Copy each element of the first array into the second array, in order. </ins> Begin inserting elements at index <code>n</code> of the second array. Return the resulting array. The input arrays should remain the same after the function runs. </section>

Discussion:
In the challenge, the following line tells users to use and , but the tests do not force the user to use and . Since this is an algorithm challenge, I believe we should let the users write the code any way that solves the problem. My suggestion is to change the line's text to the following: Any thoughts?
I'll try to solve problem
Before creating a PR, let's wait for feedback from at least one of the users I tagged.
sure, that sounds like a good idea, especially since we're not testing for those methods.
I think this sounds like a good improvement
ok
Go for it.
Nice, I'm thinking use on the testString, but I first want to know what's the asset version used on this repository. If you want that I use other way, please tell me. I also want to learn more about JavaScript
Or use keyword?
Hello , There should be no need for either of those. The idea is to change the wording of this line of text: Use the array methods slice and splice to copy each element of the first array into the second array, in order. To this: There is no need to change the tests, as they do not check for the or methods.
Thanks. It's very much easy!
Change:
Now we're several `div` elements deep on each column of our row. This is as deep as we'll need to go. Now we can add our `button` elements. <del> Nest three `button` elements within each of your `well` `div` elements. </del> <ins> Nest three `button` elements within each of your `div` elements having the class name `well`. </ins> # --hints--

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: In the description, it said "Nest three elements within each of your elements." I think it would be clearer to change it to the following: Nest three elements within each of your elements with class . Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: 87.0.4280.88 Operating System: Mac OS If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): !
What about the following?
That's even better, thank you.
Would you like to create a PR with this change?
Yes, I would like to do this.
Change:
padding-left: 36px; } <ins> .map-accordion-panel-nested-title > a { cursor: pointer; } </ins> @media (max-width: 400px) { .map-accordion-panel-nested { margin: 0;

Discussion:
On the map, if I hover my cursor over a link, it shows the text selection cursor, not the clicker cursor.
I get both pointers and text selectors in Chrome. Same with a big map (full page). !
Change:
'*.ionicframework.com', 'https://syndication.twitter.com', '*.youtube.com', <ins> 'cdn.jsdelivr.net/' </ins> ]; app.use(helmet.contentSecurityPolicy({

Discussion:
the first line in the function says - it wont pass testing unless you change it to Browser Name: Firefox Browser Version: 60.0.1 Operating System: High Sierra ! <hr!
You don't have to it, but because of strict mode it does need to be declared with , , or .
so its missing the then?
That's how I would update it.

i am suspecting another small bug, the next challenge after succesful code run in Bonfire: Chunky Monkey actually points to itself
Change:
it('shows test output when the tests are run', () => { cy.visit(locations.index); // first wait for the editor to load <del> cy.get(selectors.editor, { timeout: 10000 }); </del> <ins> cy.get(selectors.editor, { timeout: 15000 }); </ins> cy.get(selectors.runTestsButton) .click() .then(() => {

Discussion:
!
Dropping Firefox support temporarily with . This was causing me to slow down with the PRs and rapid testing we are doing on the staging. I will let someone else investigate this.
any thoughts on this one? I'll take a look when I can, but I figured you might have some insight.
I'll look into it soon. Will let you know when I get to the bottom of it.
Mrugesh shared two links to the CI runs that failed and both of them failed for the . So, I was looking at the test and saw a lot of explicit timeout increasing... this is probably the reason why it fails on Firefox. Because the timeout were increased by watching the time it took on Chrome and manually adjusting it. But Firefox normally needs a few more seconds to finish running (this is due to ). I think increasing the timeout limit should do the trick.
We do wait for the editor, but everything after that should be basically instantaneous. Thanks for investigating that, but it should be fixed for Firefox 80 () and that's what we run the tests on. Also, suggests we should be using which could be a factor, but would have thought that would make things fail entirely rather than run slowly. That could work, yeah. The strange thing is the dev mode works perfectly locally and the CI should be even faster, since it uses the built site.
The bug is fixed on Firefox but Cypress still manually triggers GC as it is said in the Cypress docs (also when you run the tests locally in Firefox, it'll show you a message about GC. This is because Cypress doesn't manually run GC on but when it's run in CI using then Cypress manually triggers GC). I agree. I don't think this is the reason. I couldn't reproduce the bug locally... maybe we should try to reproduce it in CI by running it repeatedly?
Right, but would this make a test fail? If it runs between tests, which is the default, it should just make the whole run a bit slower. If it's included in the timeout for a particular test, that would be a massive oversight. My assumption is that the only timeout you might hit because of this is the limit for the entire run. Sure.

I'll let decide when he wants to do this, though, since it makes deploying a bit of a headache (if you're being bombarded with fail negatives, I mean).
I am open to creating a new branch on the upstream if you need to test it on CI by adding random commits? In theory you should be able to test it on a fork as well.
Change:
id: 56533eb9ac21ba0edf2244bb title: Word Blanks challengeType: 1 <del> videoUrl: 'https://scrimba.com/c/cP3vVsm' </del> <ins> videoUrl: 'https://scrimba.com/c/caqn8zuP' </ins> forumTopicId: 18377 ---

Discussion:
The video for the challenge needs to be updated due to changes in the challenge. We simplified the challenge to not introduce functions in this challenge.
Sure, I'll update the video.
Any status on this update?
Done.
Change:
isOnline: boolean, isServerOnline: boolean, fetchState: UserFetchState, <ins> showCodeAlly: boolean, </ins> user: User ) => ({ isSignedIn,

Discussion:
The page gets stuck and goes blank with you leave the relational database challenges. to 'Start the course' the fCC logo/button in the nav goes blank and nav disappears Page not to go blank. Clicking fCC logo should go to /learn No response Same on Chrome and Firefox Console errors: <img width="671" alt="Screen Shot 2023-02-16 at 11 44 19 AM" src="https://user-"
Change:
Your `charset` attribute should be set to `utf-8`. ```js <del> assert(document.querySelector('meta')?.getAttribute('charset') === 'utf-8'); </del> <ins> assert(document.querySelector('meta')?.getAttribute('charset')?.toLowerCase() === 'utf-8'); </ins> ``` You should add exactly one `title` element.

Discussion:
The value for is case-insensitive. Not sure if I missed any, but here are case-sensitive ones I found. Case sensitive curriculumchallengesenglish14-responsive-web-design-22learn-accessibility-by-building-a-quiz Case sensitive curriculumchallengesenglish14-responsive-web-design-22learn-css-animation-by-building-a-ferris-wheel Case sensitive curriculumchallengesenglish14-responsive-web-design-22learn-intermediate-css-by-building-a-picasso-painting Case sensitive curriculumchallengesenglish14-responsive-web-design-22learn-responsive-web-design-by-building-a-piano Case sensitive curriculumchallengesenglish14-responsive-web-design-22learn-the-css-box-model-by-building-a-rothko-painting a lot Both are valid The value for should be case insensitive for all challenges. No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22]
Change:
**Tips** <del> - Remember that you learned about conditional statements(`if`, `else if`, and `else`). </del> <ins> - Remember that you learned about conditional statements (`if`, `else if`, and `else`). </ins> - Remember that you learned about comparison operators (`>`, `<`, `>=`, `<=`, `===`). # --hints--

Discussion:
This issue is open to first-time code contributors to this repository. The file that you should be updating is: We typically do not assign issues. Instead, we accept the most quality contribution followed by the one that is made first. Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Happy contributing.