jiebi/CodeConvo huggingface dataset:
Change:
function LinkedList() { var length = 0; var head = null; <ins> var currentNode = null; </ins> var Node = function(element){ this.element = element; this.next = null;

Discussion:
Tests run with the error: "assignment to undeclared variable currentNode". It happens because a variable "currentNode" is not declared in the method in the challenge code (not in the student code). Link: Steps to reproduce: the challenge. the button "Run the Tests". The challenge code: = function(element){ var node = new Node(element); if(head === null){ head = node; } else { currentNode = head; ...
Closing this issue, because it was fixed by PR
perhaps there was a regression. This bug is still present. Visit the link above and click 'Run the Tests'. You will see I did a hard refresh in two browsers to be sure. I also, checked the master branch. And it appears the code is fixed there. Is this something that is still waiting for a release?
Change:
"dashedName": "waypoint-add-two-numbers-with-javascript", "difficulty": "9.98141", "description": [ <del> "In JavaScript whole numbers (called integers) can be easily used to preform mathematical functions", "Let's try a few of the most commonly used ones now", "We use <code>+</code>for addition", </del> <ins> "In JavaScript whole numbers (called integers) can be easily used to perform mathematical functions.", "Let's try a few of the most commonly used ones now.", "We use <code>+</code>for addition.", </ins> "Replace the <code>0</code>with correct number to achieve the result in the comment." ], "tests": [

Discussion:
Challenge has an issue. In JavaScript whole numbers (called integers) can be easily used to preform mathematical functions <-- Let's try a few of the most commonly used ones now <-- We use - for subtraction <---
merged to

Challenge has an issue. In JavaScript whole numbers (called integers) can be easily used to preform mathematical functions <-- Let's try a few of the most commonly used ones now <--- We use * for multiplication <---
merged to

Challenge has an issue. in JavaScript we can can work with decimal numbers <--- needs full stop.
merged to
Change:
} }; <del> exports.createPages = function createPages({ graphql, actions }) { </del> <ins> exports.createPages = function createPages({ graphql, actions, reporter }) { if (!env.algoliaAPIKey || !env.algoliaAppId) { if (process.env.FREECODECAMP_NODE_ENV === 'production') { throw new Error( 'Algolia App id and API key are required to start the client!' ); } else { reporter.info( 'Algolia keys missing or invalid. Required for search to yield results.' ); } } </ins> const { createPage } = actions; return new Promise((resolve, reject) => {

Discussion:
Is there any reason not to put the real and in ? I reflexively put in a dummy key when I set this up, but now that I revisit this, that seems like a mistake.
Yes, actually it broke the .dev build unsurprisingly , I think noticed it and reported in the team chat. My bad for not catching this previously. The real fix is to ignore and move ahead when the keys are not available are default. We do this with google application credentials.
Oh, I assume it broke the build because .dev isn't using I didn't think of that... So, we should implement the fix and add the public keys to , right?
I was thinking something more along the lines of (example from api-server): I would try to avoid hundreds of contributors hitting the indexes locally. Ideally people should get their own keys. While the key and index is public, it's still not recommended to hit it?
As for the production keys, it's actually fine because the build should fail. I have since the keys in the build pipeline.
One thing: if we don't want contributors spamming search (fair enough!) I think there should be some docs that let people know what's what. Either that search isn't available in development or the steps they need to take to make it work.
I agree. We should add some docs on getting keys, or perhaps creating a test index and sharing that instead
Change:
You should use the concatenation operator on your `result` variable. ```js <del> assert.match(code, /results*+/); </del> <ins> assert.match(code, /(?:results*+|+s*result)/); </ins> ``` You should concatenate `row` to your `result` variable. ```js <del> assert.match(code, /results*+s*row/); </del> <ins> assert.match(code, /results*+s*row|rows*+s*result/); </ins> ``` You should assign the result of your concatenation back to the `result` variable. ```js <del> assert.match(code, /results*=s*results*+s*row;?/) </del> <ins> assert.match(code, /results*=s*(results*+s*row|rows*+s*result);?/); </ins> ``` # --seed--

Discussion:
A camper on the forum had issues with passing step 37 of the pyramid project This was their code Their code is correct but the tests expect a certain order of The tests should be updated to expect either correct answer see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
const character = "#"; const count = 8; const rows = []; for (let i = 0; i < count; i = i + 1) { (i); } let result = "" for (const row of rows) { result = + ; (result); } This worked for me, it took a while but realized I needed to swap the result with the row... This was helpful thank you
Thank you for this,I was really stuck
Change:
<img src="https://cdn.freecodecamp.org/platform/universal/fcc_secondary.svg"> ``` <del> Inside the existing `img` element, add an `src` attribute with this URL: </del> <ins> Inside the existing `img` element, add a `src` attribute with this URL: </ins> `https://cdn.freecodecamp.org/curriculum/cat-photo-app/relaxing-cat.jpg`

Discussion:
I noticed that we are using both "a attribute" and "an attribute" in challenge descriptions. And we even use both in the same challenge (): <img width="596" alt="Screenshot 2024-05-21 at 22 44 29" src=""I think both are acceptable, since the articles depend on how we pronounce "src" ("es-ar-see" vs "source"), but I think we should stick to one for consistency. I'll let native English speakers make the call
I always pronounce it as , so I vote
I'm with Jessica on this one. The second sentence should be changed to .
This issue is open to first-time code contributors to this repository. The files that you should be updating are: Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hi everyone. This is a great pick up! I am happy to help out there and will get a initial PR up for review today :)
I have reviewed the changes made in PR, all the related file have been fixed correctly and checked locally.
Hello, This is my first Open source contribution so if you guys can give me feedback on what i did wrong and how i should correct it please guide me. from the seven files mentioned above, I have created pull request for each one which is as below. sorry if i messed up, as it is my first try. I am actively looking for any advice, suggestion, criticism. Thank You.
Change:
<label for="css-question">Do you have any questions:</label> </div> <div class="answer"> <del> <textarea id="css-question" name="css-question" rows="5" cols="24"> Who is flexbox... </textarea> </del> <ins> <textarea id="css-question" name="css-question" rows="5" cols="24" placeholder="Who is flexbox..."></textarea> </ins> </div> </div> </section>

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --<!-- Add a link to the coding challenge with the problem. -- The final instructions for this step say: "Then, give the placeholder text describing an example answer." Since the instructions mention "placeholder" I think it is safe to assume that some people will think they should use the attribute on the to fulfill this requirement. But the code check test checks the of the : So using the attribute will result in the following hint: "You should give the placeholder text describing an example answer." Which does not make it clear that the example answer should be embedded in the instead of using the attribute. Based on the current instructions I think most users will assume that the attribute should be used to complete this step and the test should be updated accordingly. <!-- Please complete the following information. --- Device: Desktop OS: Linux/Fedora 34 Browser: Firefox Version: 95.0.2
On
I was going to fix this issue by updating the test in step 38 to check the placeholder attribute on the textarea but then I realized that if we make this change then the HTML in each step after 38 would also need to be updated to use the placeholder attribute as well. So the question is, do we want to use the placeholder attribute and update all of the remaining steps or do we want to reword the instructions in step 38 to make it clear that you should embed the question text in the textarea and not use the placeholder attribute?
That's a good question. The placeholder text matches wording from referring to the attribute. That would make me think, the intention is to use the attribute.
Agreed, this should probably be updated to use the placeholder attribute. Looks like I've got a lot of updates to include in the PR.
Thank you, for opening this. When I wrote this, I vaguely remember reading a resource mentioning using the attribute on was not the recommended approach. However, as I cannot find that, I agree using the attribute in this case seems like the better option. Yes, this will require a rewrite for all subsequent lessons. However, this usually is a simple Find and Replace.
Perfect. I'll submit a PR for this in just a bit.
Change:
'project.backEnd': submitProject }; <del> function shouldShowDonate(state) { return showDonationSelector(state) ? of(openDonationModal()) : empty(); } </del> export default function completionEpic(action$, state$) { return action$.pipe( ofType(types.submitChallenge), switchMap(({ type }) => { const state = state$.value; const meta = challengeMetaSelector(state); <del> const { isDonating } = userSelector(state); </del> const { nextChallengePath, introPath, challengeType } = meta; <del> const showDonate = isDonating ? empty() : shouldShowDonate(state); </del> const closeChallengeModal = of(closeModal('completion')); let submitter = () => of({ type: 'no-user-signed-in' }); if (

Discussion:
Donate modal is rendered/animated twice when invoked
Steps to reproduce. Complete at least 9 challenges. See modal once per session.
alternatively, change this line to true and get the modal after completion of each challenge.
Just in case someone tackle this before I get back to it. it seems like the app gets updated after the donate modal is up. so that might be causing the flashing. redux devtools actions order: <img width="338" alt="screen shot 2019-02-22 at 6 46 38 pm" src="https://user-"devtoolds error: <img width="642" alt="screen shot 2019-02-23 at 12 19 40 pm" src="https://user-"and here is where the modal is being called:
Change:
"</div>" ], "challengeType": 0, <del> "type": "waypoint" </del> <ins> "type": "waypoint", "nameEs": "Presentar imágenes de fuentes de datos", "descriptionEs": [ "Tanto en el JSON que recibimos de la API de fotos de gato de Free Code Camp, como en ", "lo que hemos visto en las dos últimas lecciones, cada objeto en nuestro vector JSON contiene una llave <code>imageLink</code> con un valor que corresponde a la url de la imagen de un gato.", "Cuando estamos recorriendo estos objetos, usemos esta propiedad <code>imageLink</code> para visualizar la imagen en un elemento <code>img</code>.", "Aquí está el código que hace esto:", "<code>&nbsp;&nbsp;html += "&lt;img src = '" + val.imageLink + "'&gt;";</code>" ] </ins> }, { "id": "bb000000000000000000005", <del> "title":  "Prefilter JSON", </del> <ins> "title": "Prefilter JSON", </ins> "description": [ "If we don't want to render every cat photo we get from our Free Code Camp's Cat Photo JSON API, we can pre-filter the json before we loop through it.", "Let's filter out the cat who's "id" key has a value of 1.",

Discussion:
[x] Trigger Click Events with jQuery [x] Change Text with Click Events [x] Get JSON with the jQuery getJSON Method [x] Convert JSON Data to HTML [x] Render Images from Data Sources [x] Prefilter JSON [x] Get Geo-location Data
Trabajando en esta
Change:
assert.equal(document.querySelector('fieldset:nth-child(3) + label')?.innerText.trim(), 'I accept the terms and conditions'); ``` <del> You should use an `a` element to link to the terms and conditions. </del> <ins> You should use an `a` element to link to the terms and conditions. ```js assert.exists(document.querySelector('fieldset:nth-child(3) + label a')); ``` You should put the new text immediately after the `input` element in the `label`. </ins> ```js assert.exists(document.querySelector('fieldset:nth-child(3) + label > input + a'));

Discussion:
The current instructions say: But they don't specifically say where the new text should be within the . If you add the text before the (with the anchor correctly to the text) then you get the following hint: This creates even more confusion since the anchor was correctly. I think these instructions are relying on the fact that the text for the radio buttons was after the and thus the assumption is that the text for the check box should also be after the . And I agree that usually the text for radio buttons/check boxes is placed after the , but this is not a requirement. Also, in step 26 when we have them add the text for the radio buttons, we explicitly say "immediately after the element", so it seems like this is important information to add. N/A Change the instructions to: I should have done better testing :slightlysmilingface: The tests don't care if there is a space between the and the text. We might also want to update the tests so it gives a better hint if they put the text before the . No response N/A No response
I like the proposed change in wording.
Please let me know if there are any other changes needed.
the issue is not marked as ready for contribution yet.
This issue has been around for a while and I'm still seeing it come up in the forums. Do we need any more discussion on this? Two things to fix in this PR: Update instructions to make it clear that the text comes after the Fix the test that is erroneously telling the user they need to add an anchor element when it is already there.
I don't think so, no. The requirements are nice and clear, thanks!
Change:
> {t('learn.exam.exit-no')} </Button> <ins> <Button data-cy='exit-exam-modal-confirm' block={true} bsStyle='danger' onClick={exitExam} > {t('learn.exam.exit-yes')} </Button> </ins> </Modal.Footer> </Modal> );

Discussion:
In the exit exam modal, the primary button comes first then the close button, while the reset progress and delete account modals have it the other way around. We have been displaying buttons from the most used/important to the least (check code -save code -get help), so I think the reset progress and delete account modals should be changed to follow the pattern. It's to maintain the consistency and to prevent the user from clicking the wrong button with their muscle memory (the color in this case helps, but non-sighted users won't have the cue). The button order of the reset progress and delete account modals should be flipped.
Other way around, I think. The exit exam should be flipped. If the top button is the most commonly used one, then we should set that to the non-destructive action here. That way, if someone clicks it out of muscle memory and not intention, they haven't done something irreversible.
Yup, I think the exam one should be flipped - that's how it is in the danger zone on the settings too
Okay, thanks everyone for the input. We are going to proceed with an update in the exit exam modal. This issue is open to first-time code contributors to this repository. The file that you should be updating is Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Yes, I agree. The 'Reset progress' and 'Delete account' buttons should be reversed. The affirmative option always comes first, followed by the negative option.
Hello, I have flipped the order of the buttons. This should reflect the structure that it appears as.
Follow the
I have flipped the order of exit-exam model buttons, Please review it
Change:
Select which project you want to contribute to, and you will see a list of available languages for translation. <del> ![Image - List of available languages](./images/crowdin/languages.png) </del> <ins> ![Image - List of available languages](https://contribute.freecodecamp.org/images/crowdin/languages.png) </ins> Select the language you want to work on, and you will see the complete file tree. <del> ![Image - List of available files](./images/crowdin/file-tree.png) </del> <ins> ![Image - List of available files](https://contribute.freecodecamp.org/images/crowdin/file-tree.png) </ins> Each file and folder will show a progress bar. The **blue** portion of the progress bar indicates what percentage of the file has been translated, while the **green** portion of the progress bar indicates what percentage of the file has been approved by the proofreading team.

Discussion:
! Our local images currently do not render in the translated documentation views. This is due to the use of a relative link, which breaks with the new path generated for i18n pages. A couple of potential fixes: Use an absolute link (<filename). This, IMHO, is the most effective. Have translators fix the link in the translation flow. Host the images through our CDN and fetch them.
We should use the absolute path.
Sounds good. I'll get a PR up shortly.
Change:
"tests": [], "type": "basejump", "challengeType": 4, <del> "isRequired": true </del> <ins> "isRequired": true, "nameEs": "Microservicio para analizar el encabezado de una petición", "description": [ "<strong>Objetivo:</strong> Arma una aplicación de Pila Completa en JavaScript que sea funcionalmente similar a esta: <a href='https://cryptic-ridge-9197.herokuapp.com/api/whoami/' target='_blank'>https://cryptic-ridge-9197.herokuapp.com/api/whoami/</a> y despliegala en Heroku.", "Ten en cuenta que para cada proyecto, deberías crear un nuevo repositorio en GitHub y un nuevo proyecto en Heroku. Si no recuerdas como hacer esto, vuelve a visitar <a href='/challenges/get-set-for-our-back-end-development-projects'>http://freecodecamp.com//challenges/get-set-for-our-back-end-development-projects</a>.", "Aquí están las historias de usuario específicas que debes implementar para este proyecto:", "<strong>Historia de Usuario:</strong> Puedo obtener la dirección IP, idioma y sistema operativo de mi navegador.", "Una vez que hayas terminado de implementar estas historias de usuarios, pulsa el botón "I've completed this challenge" e introduce los URLs de tu repositorio en GitHub y de tu aplicación en vivo en Heroku.", "Puedes obtener retroalimentación sobre tu proyecto por parte de otros campistas, compartiendolo en nuestra <a href='//gitter.im/freecodecamp/codereview' target='_blank'>Sala de chat para revisión de código</a>. También puedes compartirlo en Twitter y en el campamento de tu ciudad (en Facebook)." ] </ins> }, { "id": "bd7158d8c443edefaeb5bd0e",

Discussion:
[x] Get Set for our Back End Development Projects [x] Timestamp Microservice [x] Request Header Parser Microservice [x] URL Shortener Microservice [x] Image Search Abstraction Layer [x] File Metadata Microservice
Currently working on this.
I just used part of the PR that you closed. Thank you. Blessings.
Change:
.form-group label.col-sm-2.control-label.wrappable(for='description') description: .col-sm-10 <del> textarea#description.form-control(name="description", placeholder="Separate sentences by exactly one space only. Do not add in line breaks.") </del> <ins> textarea#description.form-control(name="description", rows=5, placeholder="Separate sentences by exactly one space only. Do not add in line breaks.") </ins> .form-group label.col-sm-2.control-label.wrappable(for='challengeSeed') challengeSeed: .col-sm-10

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --The test requires a multi-line comment of the form . However, the test fails if additional ` characters are present at the beginning or the end of the text contained within the comment. Some examples : The regular expression for the corresponding test needs to be updated. Browser Name: Google Chrome Browser Version: 60+ Operating System: Ubuntu 18.04 !
Hi, I would like to have a go to fix this problem
That's good, please read .
Test fails if multiline style comment includes either / File: Line: 33 this regex is the problem

When I attempt to Run the tests for the code I submitted for Roman Numerals Converter, the page freezes and I cannot solve the issue until I clear the cashe of my browser. Help!
I have the same issue. My browser complains about a long running script and then bails out.
Ok, I figured this one out... if you use the solution in the Gritter chat, that solution will cause a never ending loop, because of the while expression (while numCopy 0 - which is always true btw). This never ending loop will freeze your browser. Moreover, as I lately discovered, the solution there only covers very few of the cases that we need to test to pass the Bonfire. So back to the drawing board, people!
Leaving this open as a bug for someone to fix the solution in the wiki to one that works with the new test cases.
Change:
--- <del> `What does she do as our team lead?` </del> <ins> `What does she do as the team lead?` </ins> ## --video-solution--

Discussion:
The fill-in-the-blank sentence doesn't match what the character says. The written sentence is: The character says: Note the "the", instead of "our". No response Device: all OS: all Browser: all Version: all No response
Thank you for reporting the issue. Note for maintainers: Step 54 () uses "our" instead of "the" in the quiz. I think it's fine as-is since there isn't associated audio/caption text, but I'd vote updating it, too, for consistency. This issue is open to first-time code contributors to this repository. Requirements: In Change the text in the tag from to In Change the text in the tag from to Change the fill-in-the-blank text from to Change the backtick placement in the description text from ` In Change the text of the answers from to Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hi I've created a PR addressing these changes.