jiebi/CodeConvo huggingface dataset:
Change:
const { formValues: { githubProfile, linkedin, twitter, website } } = this.state; <ins> const { state: githubProfileValidation, message: githubProfileValidationMessage } = this.getValidationStateFor(githubProfile); const { state: linkedinValidation, message: linkedinValidationMessage } = this.getValidationStateFor(linkedin); const { state: twitterValidation, message: twitterValidationMessage } = this.getValidationStateFor(twitter); const { state: websiteValidation, message: websiteValidationMessage } = this.getValidationStateFor(website); </ins> return ( <Fragment> <SectionHeader>Your Internet Presence</SectionHeader>

Discussion:
Describe the bug For field in , error state can not be triggered. Warning state will be triggered when an email address with incorrect domain is entered (for example: ). For all fields in , both error and success state can not be triggered. To Reproduce Steps to reproduce the behavior: to http://localhost:8000/settings to fill and to Describe the bug Expected behavior For field in , error state should be triggered instead of warning state. There should only be two states for an email address. Success state is when it is a valid and reachable email address. Error state is when it is an invalid and unreachable email address. For all fields in . Success state is when it is a valid and reachable URL. Error state is when it is an invalid and unreachable URL. Desktop (please complete the following information): OS: Windows 10 1809 Build .832 Browser Latest Chrome Version 77.0.3865.120 (Official Build) (64-bit)
Calling to discuss this from issue . What do you think about this? Are there anything to add or change from the Expected Behavior I described?
the only thing I'm not sure about is 'unreachable'. Do you just mean unreachable because the URL is malformed? Like , for example. If so, then I completely agree. cc
Yes of course. 'Unreachable' is only defined by malformed email format ( valid length, etc) and URL format (protocol, colon, double slash, etc). It is also possible to check the top level domain part against current existing TLD programatically. Other than that, for example checking real email address which is existing should be done by email confirmation / verification.
Change:
"Return true if the passed string is a valid US phone number", "The user may fill out the form field any way they choose as long as it is a valid US number. The following are all valid formats for US numbers:", "555-555-5555, (555)555-5555, (555) 555-5555, 555 555 5555, 5555555555, 1 555 555 5555", <del> "For this challenge you will be presented with a string such as "800-692-7753" or "8oo-six427676;laskdjf". Your job is to validate or reject the US phone number based on any combination of the formats provided above. The area code is required. If the country code code is provided, you must confirm that the country code is "1". Return true if the string is a valid US phone number; otherwise false." </del> <ins> "For this challenge you will be presented with a string such as "800-692-7753" or "8oo-six427676;laskdjf". Your job is to validate or reject the US phone number based on any combination of the formats provided above. The area code is required. If the country code is provided, you must confirm that the country code is "1". Return true if the string is a valid US phone number; otherwise false." </ins> ], "tests": [ "expect(telephoneCheck("555-555-5555")).to.be.a("boolean");",

Discussion:
Need to document the rename challenge tool and the i18n sync tool. Sometime later this week. Not urgent.
I can take this on?
Go for it, Thanks!
I will start with the rename challenge tool, for the i18n sync, I will wait news if it works now
Change:
<label for="css-questions">Do you have any questions:</label> </div> <div class="answer"> <del> <textarea id="css-questions" name="css-questions" rows="5" cols="24"> Who is flexbox... </textarea> </del> <ins> <textarea id="css-questions" name="css-questions" rows="5" cols="24" placeholder="Who is flexbox..."></textarea> </ins> </div> </div> </section>

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --<!-- Add a link to the coding challenge with the problem. -- The final instructions for this step say: "Then, give the placeholder text describing an example answer." Since the instructions mention "placeholder" I think it is safe to assume that some people will think they should use the attribute on the to fulfill this requirement. But the code check test checks the of the : So using the attribute will result in the following hint: "You should give the placeholder text describing an example answer." Which does not make it clear that the example answer should be embedded in the instead of using the attribute. Based on the current instructions I think most users will assume that the attribute should be used to complete this step and the test should be updated accordingly. <!-- Please complete the following information. --- Device: Desktop OS: Linux/Fedora 34 Browser: Firefox Version: 95.0.2
On
I was going to fix this issue by updating the test in step 38 to check the placeholder attribute on the textarea but then I realized that if we make this change then the HTML in each step after 38 would also need to be updated to use the placeholder attribute as well. So the question is, do we want to use the placeholder attribute and update all of the remaining steps or do we want to reword the instructions in step 38 to make it clear that you should embed the question text in the textarea and not use the placeholder attribute?
That's a good question. The placeholder text matches wording from referring to the attribute. That would make me think, the intention is to use the attribute.
Agreed, this should probably be updated to use the placeholder attribute. Looks like I've got a lot of updates to include in the PR.
Thank you, for opening this. When I wrote this, I vaguely remember reading a resource mentioning using the attribute on was not the recommended approach. However, as I cannot find that, I agree using the attribute in this case seems like the better option. Yes, this will require a rewrite for all subsequent lessons. However, this usually is a simple Find and Replace.
Perfect. I'll submit a PR for this in just a bit.
Change:
assert(document.querySelectorAll('a').length >= 2); ``` <del> You should only add one opening anchor (`a`) tag. Please remove any extras. </del> <ins> You are missing a closing (`a`) tag after the image. </ins> ```js assert(document.querySelectorAll('a').length === 2);

Discussion:
I've run into this enough in the forums that it might be time to fix it. A lot of people leave off the closing tag when turning the image into a link. The hint they get is: "You should only add one opening anchor (a) tag. Please remove any extras." Which is confusing since the objective of the step is to add a second link to the page and the hint makes it sound like there should only be one. Instead, the hint should probably remind them that an anchor element needs both an opening and closing tag. Whether we want to spell it out even further by telling them that they are missing the closing tag I will leave up to the hive mind. If we don't want to be too explicit we could do something like: "Hint: Creating a link with the anchor element requires both an opening and closing tag." Or: "Hint: You must use both an opening and closing tag to create a link." Or if we want to be more direct: "Hint: You are missing a closing tag after the image." No response N/A No response
I think being explicit about a closing tag being needed is the way to go this early in the curriculum
Let us go with this.
Yeah I read through your Issue and it is quite confusing to get this hint. The explicit hint you mentioned is the way to go.
Can I make that change ? I just did this locally and works.
This has a help wanted tag, so anyone is free to open a PR for this.
I think that we need to decide exactly what to change - just changing the text of the hint without changing the associated test will cause more problems
Is this designed just to discourage newbies like me? Over an hour on this step. No previously posted code nor clarifications helped... just sent me down new rabbit holes. You need to know code to decipher the clarifications. Must be part of a hazing process. THIS code works as of the date of this posting: <a href=""<img src="" alt="A cute orange cat lying on its back."</a (eliminate the space between the closing anchor "a" and the "" <h 1Now I know I am crazy enough to continue down this road/ rabbit hole universe</h 1(extra spaces for effect, LOL)
please use the freeCodeCamp forum if you have questions about your code or you get stuck. This content is hard, but there is no intentional 'hazing'.
Change:
Convert a given date from the Gregorian calendar to the Discordian calendar. <del> Note that in the Discordian calendar (Chaos 1, 3188 YOLD) is (January 1, 2022), in the Gregorian calendar. </del> <ins> Note that the day Chaos 1, 3188 YOLD in the Discordian calendar is the day January 1, 2022 in the Gregorian calendar. </ins> # --hints--

Discussion:
Just transcribing issues from crowdin. In this line: There is an extra comma before the anchor element that has to be removed. In this line: There is an incorrect use of parenthesis. It should become This looks like something that can be fixed by "first-time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hey, I would like to work on this.
Change:
# --description-- <del> In your `goTown` function, update your button `innerText` properties to be `Go to store`, `Go to cave`, and `Fight dragon`. Update your `onclick` properties to be `goStore`, `goCave`, and `fightDragon`, respectively. Finally, update your text's `innerText` property to be `You are in the town square. You see a sign that says Store.`. </del> <ins> In your `goTown` function, update your `button` elements' `innerText` properties to be `Go to store`, `Go to cave`, and `Fight dragon`. Update your `onclick` properties to be `goStore`, `goCave`, and `fightDragon`, respectively. Finally, update your text's `innerText` property to be `You are in the town square. You see a sign that says Store.`. </ins> # --hints--

Discussion:
In crowdin, I noticed that step 48 of the new JS course, build an rpg, uses a sentence that may need a grammar correction. Instead of “your button innerText” it should say “your buttons’ innerText”? Full sentence was: Grammar correction. No response N/A No response
Hello , Can you assign me this?
Should be changed to:
Thanks for opening this issue. This looks like something that can be fixed by "first-time" code contributors to this repository. Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Change:
justify-content: space-around; flex-direction: row-reverse; margin-bottom: 0px; <ins> padding-top: 3px; padding-bottom: 3px; </ins> position: fixed; width: 100%; z-index: 1000;

Discussion:
When you sign in or change an option on settings, you get an alert banner up top. It could be a little thinner so it doesn't cut so close to the body elements <img width="1420" alt="Learn_freeCodeCamp_org" src="https://user-"
should we go all the way? <img width="1198" alt="Screen Shot 2019-10-19 at 12 39 56 AM" src="https://user-"
The layout element needs to be pushed below the notification. Currently it overlays on top of it.
Should I work on it?
Yes please. Note the the notification should be shorter in height and should also be "injected" in-between the nav and the layout instead of overlaying.
Change:
Variable myStr should contain the string: `I am a "double quoted" string inside "double quotes".` ```js <del> assert(myStr === 'I am a "double quoted" string inside "double quotes".'); </del> <ins> assert(/I am a "double quoted" string inside "double quotes(."|".)$/.test(myStr)); </ins> ``` # --seed--

Discussion:
This is a dumb problem and I am new to GitHub so please forgive me for any weirdness. Basically, on this page, we see this explanation: This signals to JavaScript that the following quote is not the end of the string, but should instead appear inside the string. So if you were to print this to the console, you would get: Alan said, "Peter is learning JavaScript". and we are asked to make this string: I am a "double quoted" string inside "double quotes". However, I think that the period should be inside the quotations, grammatically. Like "double quotes." Thank you.
Thank you for your bug report, but I think this is in the realm of bike shedding
I do agree with that this is indeed a small typo but I also agree with that it is indeed a grammatical prob. Since this typo got noticed, I'd say let's fix it.
While I think it is fine to correct the typo, I think the tests should be loose enough to accommodate the period inside or outside the last double quote. The point of the challenge is escaping double quotes, so we do not want to get caught up in forcing the user to keep the period inside or outside the quotes. The reason I say this is the new curriculum is going in this direction. We are going to be lenient in the tests when it makes sense to. In my opinion, this is one of those cases.
Sure. Let's keep the tests lenient and fix the typo.
Is this still a first-timers issue now, since the contributor must also modify the test to accommodate both versions of the string?
Ooops. Forgot to update that. Thanks for the catch!
Thank you for your reply. I agree the grammar shouldn’t matter in the challenge. The problem was that when I tried to submit the answer with the “proper grammar,” it told me my answer was wrong, and I had to change it to the “improper” way. I’m an English teacher rather than a programmer, so completing the challenge with the improper grammar hurt my soul a little bit, haha.
Hey , I just made a PR () that fixes the grammar issue and it looks quite simple as there's no need to change the tests. So, let's open this up for , what do you say?

Just to add this: I do not see this as a bug/typo, because I mostly use British-styled English. So, the only reason we might change this is if we are trying to have uniformity about using only American-styled English within the curriculum.
both versions should be allowed, dot inside and dot outside. Your PR just changes wich version is allowed
I didn't knew that it differed in these two styles. If that is the case I'm in favour of closing this issue as it is proper English eitherway. The tests and the sentence in the test question isn't changed in my PR as it is correct. I only changed the example sentence in the PR. (Apologies for the trouble and misunderstanding )
the change discussed here about making both solutions work is not wanted anymore?
Re-opening.
Change:
```js { <del> username: "fcc_test" </del> <ins> username: "fcc_test", </ins> description: "test", duration: 60, date: "Mon Jan 01 1990",

Discussion:
There should be a comma for "username: "fcc_test", otherwise the JavaScript Object syntax is wrong. <img width="775" alt="image" src="https://user-"- Device: MacBook Air M1 OS: macOS Monterey 12.0.1 Browser: Chrome Version: 98.0.4758.109
Thanks for opening this issue. This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Change:
You should add a `constructor` method to the `ShoppingCart` class. ```js <del> assert.match(code,  /classs+ShoppingCarts*{s*constructor(s*)s*/) </del> <ins> assert.match(code,  /classs+ShoppingCarts*{s*constructors*(s*)s*/) </ins> ``` Your `constructor` method should be empty. ```js <del> assert.match(code,  /classs+ShoppingCarts*{s*constructor(s*)s*{s*}s*}/) </del> <ins> assert.match(code,  /classs+ShoppingCarts*{s*constructors*(s*)s*{s*}s*}/) </ins> ``` # --seed--

Discussion:
the check for step 15 of the shopping cart does not allow a space to be placed to the immediate right-hand-side of the word constructor (just before the parenthesis), however that seems to be valid syntax. update the check for this step to allow a space to the immediate right-hand-side of the word constructor No response N/A No response
I found a similar issue with another step here: (it also doesn't allow the constructor to have a single space to the immediate right of the word constructor) Can this be fixed at the same time?
Change:
# --hints-- <del> You should modify the pattern passed as the first argument to the `re.sub()` call using a negative lookbehind. TODO: add details/improve wording </del> <ins> You should modify the pattern passed as the first argument to the `re.sub()` call using a negative lookbehind. </ins> ```js ({ test: () => assert(runPython(`

Discussion:
There was a TODO comment left in the hints for the Equation Solver project <img width="759" alt="Screenshot 2024-09-30 at 11 11 37 AM" src=""The hint should be updated to the following: see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the Happy coding
can you please add label to this issue as "Hacktoberfest"
Hi, I'd like to contribute to this issue! I'll update the hint for the () call to use a negative lookbehind and submit a PR shortly. Thanks for the opportunity!
Hello! I'm interested in resolving this issue by refining the str method within the Equation class. My plan is to adjust the () function to incorporate a negative lookbehind, ensuring that the digit '1' is only replaced when it isn't preceded by another digit. This approach will prevent unintended substitutions in multi-digit numbers. I'll prepare a pull request with these modifications soon.
I would like to contribute to this issue. I have contributed to hacktoberfest last year as well. Please assign it to me.
the repo has the label, the issue label don't matter. We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labeled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
Please do not make any changes outside what is outlined in the issue. The scope of the issue to only update the hint text to remove the TODO comment. Any other changes will not be accepted in a PR Thank you
Thank you for the clarification!

I'll ensure the changes in my PR are limited to updating the hint text and removing the TODO comment, as specified in the issue. I appreciate the guidance!
Thanks for the clarification Mam
Change:
let textMessage = dedent( `**Tell us what's happening:** <ins> Describe your issue in detail here. </ins> ${ projectFormValues.length

Discussion:
Describe the bug Last week, I saw multiple posts where people asking for help didn’t write down what they needed help with. I think the help post template may be confusing some folks. Screenshots ! Additional context “Tell us what’s happening” looks a bit like an overall heading. I suggest the following changes to make it more obvious that people are supposed to write something down: Mockup !
Hello there, Thank you, for taking the time to open this. I believe it would help some Campers understand the need to add more information. However, I suspect the large majority just post without reading any further. The Discourse software does have a lot of cool features aiding the topic creating (e.g. Information about informative titles, showing similar topics). If others are in agreement, this would be an easy implementation, and could be put up for first timers? That being said, I find dedent to be pesky.
I'm not big on the idea of adding an extra heading. Perhaps just the extra describe prompt: Tell us what's happening: Describe your issue in detail here Your code so far: Your browser information: blah blah blah Mildly related - I think we should add a colon after "Your code so far" to match the other headings.
If it's a first-timer I'll let somebody do it but if not I can take care of making the changes. Your call!
Any decision on if we're opening this for first timers?
Can I work on this issue, being my first contribution to freeCodeCamp?
please go ahead.
Hi, I saw that this issue wanted to be done by someone a few days ago, but its still not been closed, I am also an newbie and am really eager to contribute so would be happy to help, and close it today. Was trying to find the template to change it, but couldn't find the file. Would it be possible for someone to point me to the right file? Thanks :)
Hey it's this one -
Thanks
Change:
return n; } <del> intRightTriangles(1000); </del> <ins> console.log(intRightTriangles(500)); // 420 </ins> ``` </div>

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: Project Euler 39 automated test for n=800 should expect 720, which is the correct answer [ [ 45, 336, 339 ], [ 72, 320, 328 ], [ 80, 315, 325 ], [ 120, 288, 312 ], [ 144, 270, 306 ], [ 180, 240, 300 ] ] Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: 79.0.3945.130 (Official Build) (64-bit) Operating System: MacOS If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
Change:
Вы можете внести свой вклад в интересующую вас область: <del> 1. [Внести вклад в этот открытый репозиторий.](#contribute-to-this-open-source-codebase) </del> <ins> 1. [Внести вклад в этот открытый репозиторий.](#внести-свой-вклад-в-этот-open-source-проект) </ins> Помогите нам в создании или редактировании [обучающих статей](https://www.freecodecamp.org/guide), [задач по программированию](https://www.freecodecamp.org/learn) или исправлении ошибок на нашей обучающей платформе.

Discussion:
Describe your problem and how to reproduce it: Anchor links such is not working properly in several languages. For sure is not working in: Russian, Spanish, Chinese languages. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: Version 74.0.3729.169 (Official Build) (64-bit) Operating System: Windows 10 Pro 1809 If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): !
These 3/4 PRs (exlude one - which I PR'd to my own forked-repo) may close this issue. Please review them.