jiebi/CodeConvo huggingface dataset:
Change:
Your `.cabin` selector should have an `animation` property set to `cabins 10s linear infinite`. ```js <del> assert(new __helpers.CSSHelp(document).getStyle('.cabin')?.animation === '10s linear 0s infinite normal none running cabins'); </del> <ins> const cabinElementStyles = new __helpers.CSSHelp(document).getStyle('.cabin'); assert( cabinElementStyles?.animationName === "cabins" && cabinElementStyles?.animationDuration === "10s" && cabinElementStyles?.animationTimingFunction === "linear" && cabinElementStyles?.animationIterationCount === "infinite" ); </ins> ``` # --seed--

Discussion:
We got a report that the current test for Step 23 of the Learn CSS Animation by Building a Ferris Wheel project fails in the latest version of Safari. The test works as expected in Firefox and Chrome. This test should pass with the above code like it does in Firefox and Chrome. No response Device: Macbook Air OS: macOS Browser: Safari Version: 16.5.2 In of this project, the CSS helper () returns the string when the correct code is submitted in both Chrome and Firefox. In the latest version of Safari, the CSS helper returns . The test in the should be updated to check for both strings so learners using all supported browsers can complete this step. If this is an issue for other people running Safari, this would be a good candidate for someone's first PR.
Another arguably more verbose option is to look at each individual property. I suspect they will never change values or be different between browsers so that might be more future-proof than looking at the shorthand value.
Thanks for sharing that, I agree – it would be much more future-proof to test those properties / values individually. I'm not sure what our CSS Helper library returns for each individual property in the browsers we support. But if they're consistent across Chrome, Firefox, and Safari, testing each one would be a much better approach.
Change:
"title": "Use Spans for Inline Elements", "difficulty": 2.105, "description": [ <del> "You can use use spans to create inline elements. Remember when we used the <code>btn-block</code> class to make the button grow fill the entire row?", </del> <ins> "You can use use spans to create inline elements. Remember when we used the <code>btn-block</code> class to make the button fill the entire row?", </ins> "This image illustrates the difference between <code>inline</code> elements and <code>block-level</code> elements:", "<img class="img-responsive" src="https://www.evernote.com/l/AHTFU358y71AV6mokPeuTEgrZVdUJ4A8v3AB/image.png" alt="An "inline" button is as small as the text it contains. In this image, it's centered. Below it is a "block-level" button, which stretches to fill the entire horizontal space.'>", "By using the <code>span</code> element, you can put several elements together, and even style different parts of the same element differently.",

Discussion:
Challenge has an issue. Please describe how to reproduce it, and include links to screenshots if possible. There are two typos in this waypoint, as indicated in the screenshot: ! In the first paragraph, remove the "s" from the word "elements." In the second test, the close-paren needs to immediately follow the open-paren, and should not appear at the end of the sentence.
Thanks for reporting this! The referenced commit fixes one of your issues, and the other (closing parenthesis) had already been fixed!

Challenge has an issue. In the second sentence, Remember when we used the class to make the button grow fill the entire row? --remove the word "grow".
Change:
"tape": "^4.2.2" }, "snyk": true <del> } </del>  No newline at end of file <ins> } </ins>

Discussion:
A caret symbol, needs to be . So the result should look like this: . Please review before opening a PR, thank you!
Hi there - can I take this one? I'm new to contributing to FCC and this issue seems like a great way to get everything set up and working properly to help out more in the future.
Change:
], "tests": [ "assert(confirmEnding("Bastian", "n") === true, 'message: <code>confirmEnding("Bastian", "n")</code> should return true.');", <ins> "assert(confirmEnding("Congratulation", "on") === true, 'message: <code>confirmEnding("Congratulation", "on")</code> should return true.');", </ins> "assert(confirmEnding("Connor", "n") === false, 'message: <code>confirmEnding("Connor", "n")</code> should return false.');", "assert(confirmEnding("Walking on water and developing software from a specification are easy if both are frozen", "specification") === false, 'message: <code>confirmEnding("Walking on water and developing software from a specification are easy if both are frozen"&#44; "specification"&#41;</code> should return false.');", "assert(confirmEnding("He has to give me a new name", "name") === true, 'message: <code>confirmEnding("He has to give me a new name", "name")</code> should return true.');",

Discussion:
There should be a test case for a target ending that appears anywhere else other than the end of the string. The purpose of the function is to determine whether the 'target' string appears at the end of the given string (str). The issue is that the code below will pass when it shouldn't. It looks for the first appearance of the target in the string (str), creates a substring from that to the end, and returns if it's equal to the target string. There are no test cases for the case when the target appears anywhere else than the end. <img width="286" alt="screen shot 2017-03-15 at 4 12 49 pm" src=""<img width="1376" alt="screen shot 2017-03-15 at 4 08 45 pm" src=""
You're right, nice find! I'll give it a go and make a PR.
Awesome! Thanks a lot! :)
Np, let's just hope it gets accepted! :)
Change:
assert(nonMutatingSort(globalArray) !== globalArray); ``` <ins> `nonMutatingSort([1, 30, 4, 21, 100000])` should return `[1, 4, 21, 30, 100000]`. ```js assert(JSON.stringify(nonMutatingSort([1, 30, 4, 21, 100000])) === JSON.stringify([1, 4, 21, 30, 100000])) ``` `nonMutatingSort([140000, 104, 99])` should return `[99, 104, 140000]`. ```js assert(JSON.stringify(nonMutatingSort([140000, 104, 99])) === JSON.stringify([99, 104, 140000])) ``` </ins> # --seed-- ## --seed-contents--

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: Below mentioned challenge can be passed using simple .sort() function instead of using .sort((a,b) =a-b) Link to the page with the problem: Possible solutions the existing array from [5, 6, 3, 2, 9] to something like [1, 30, 4, 21, ] another test case with array [1, 30, 4, 21, ] So that the challenge cannot be passed without using .sort((a,b) =a-b) function
https://user- Here is my simple solution to this problem. I just use ES6 syntax using spread. return [].sort(); and that is it!
I think this is a change that may be necessary, there often cases where users are stumped in following lessons because they use without an argument and can't understand why the numbers are not ordered from lowest to highest but I will wait for others to comment
The risks of using without a callback function are pretty well covered in the previous challenge : I think changing the test case could be a good way to help campers remember this. And/or adding some sort of warning in the challenge description : "Caution : remember that in order to work as expected, should be used with a callback function"
In order to ensure that the callback function is provided, a test case with the array [, 104, 99] can also be
Change:
# --instructions-- <del> Add `mongodb` and `mongoose` to the project’s `package.json`. Then, require mongoose as `mongoose` in `myApp.js`. Store your MongoDB Atlas database URI in a private `.env` file as `MONGO_URI`. Surround the the URI with single or double quotes, and make sure no space exists between both the variable and the `=`, and the value and `=`. Connect to the database using the following syntax: </del> <ins> Add `mongodb` and `mongoose` to the project’s `package.json`. Then, require mongoose as `mongoose` in `myApp.js`. Create a `.env` file and add a `MONGO_URI` variable to it. Its value should be your MongoDB Atlas database URI. Be sure to surround the URI with single or double quotes, and remember that you can't use spaces around the `=` in environment variables. For example, `MONGO_URI='VALUE'`. When you are done, connect to the database using the following syntax: </ins> ```js mongoose.connect(<Your URI>, { useNewUrlParser: true, useUnifiedTopology: true });

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: A couple of concerns were brought up in the Discord server regarding the verbiage on this challenge. First, the language "make sure no space exists between both the variable and the and the value and " is not particularly clear, and could possibly be re-written to something like "make sure no space exists between the variable, the , and the value." Second, it seems that Glitch has a GUI to the .env file which is confusing some users. We could either add text to the instructions to say "We recommend you click to switch the .env file to a text view", or change the instructions to match Glitch's format. I definitely recommend the first option, as it would be more universal to other IDE platforms. This change would likely need to be made in a few places, though. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: Operating System: Windows 10 Home 1909 If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): Glitch's new GUI !
I agree. The instructions can be made simpler. Also, we should teach how to use the proper syntax in file.... not the GUI that Glitch offers.
Change:
--- <del> title: Bash ssh </del> <ins> title: Bash ssh (Secure SHell) </ins> --- ## Bash command: ssh <del> This command is used **to connect to a remote computer**, for example `ssh 123.456.789.012` will try to establish a connection with that host. The address of the remote computer can be provided using an IP address or, if provided, an identifier. </del> <ins> **Used to securly connect to a remote server** using Diffie-Hellman algorythm for key exchange, ssh replaces the archaic telnet program for remote shell sessions. </ins> <del> If the remote computer requires the user to login, they can use the form `ssh username@remote_address`, which will then prompt them for the user password on a successful connection. </del> <ins> for example `ssh 192.0.2.1` will try to establish a connection with that host. The address of the remote computer can be provided using an IP address resolvable hostname or FQDN. </ins> <del> It also has command line options which can be found on the SSH website. </del> <ins> If you wish to use a different username then the one initiating the session (i.e. you're using ssh from root but wish to log in as different user to a remote system), the form `ssh username@remote_address` can be used, which will then prompt for the user password on successful connection. </ins> <del> One thing to note, if the server is configured to listen to any port other than `22`, then you have to use `-p` option to specify the port. For example: `ssh -p 2024 123.456.789.012`. If the remote computer requires user login, the form `ssh username@remote_address` can be used, which will then prompt for the user password on successful connection. </del> <ins> Basic usage arguments: - `-p` - use a different port then configured in ssh_config file (usually 22) - `-u` - pass username outside of hostname URI - `-i` - use a different location for private key </ins> ### More Information: * [Wikipedia](https://en.wikipedia.org/wiki/Secure_Shell)

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: this needs more work, but to begin a process - adding the proper acronym explanation (which is almost 50% of understanding the topic) and reducing misinformation about identifiers. also some explanation on the benefit of using this tool compared to its predecessor also adding basic usage and giving some more basic understanding of this tool Add a Link to the page with the problem:
I created a pull request for adding some basic information. Still need to correct the misinformation about identifiers.
Change:
## --sentence-- <del> `Those are great traits for someone in her position, I think. What _ she _ as our team lead?` </del> <ins> `Those are great traits for someone in her position, I think. What _ she _ as the team lead?` </ins> ## --blanks--

Discussion:
The fill-in-the-blank sentence doesn't match what the character says. The written sentence is: The character says: Note the "the", instead of "our". No response Device: all OS: all Browser: all Version: all No response
Thank you for reporting the issue. Note for maintainers: Step 54 () uses "our" instead of "the" in the quiz. I think it's fine as-is since there isn't associated audio/caption text, but I'd vote updating it, too, for consistency. This issue is open to first-time code contributors to this repository. Requirements: In Change the text in the tag from to In Change the text in the tag from to Change the fill-in-the-blank text from to Change the backtick placement in the description text from ` In Change the text of the answers from to Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hi I've created a PR addressing these changes.
Change:
assert.isNotNaN(Number(cols)); ``` <del> You should give the `textarea` placeholder text describing an example answer. </del> <ins> You should give the `textarea` a `placeholder` attribute with text describing an example answer. </ins> ```js <del> assert.notEmpty(document.querySelectorAll('div.answer')?.[1]?.querySelector('textarea')?.textContent); </del> <ins> assert.notEmpty(document.querySelectorAll('div.answer')?.[1]?.querySelector('textarea')?.getAttribute('placeholder')); </ins> ``` # --seed--

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --<!-- Add a link to the coding challenge with the problem. -- The final instructions for this step say: "Then, give the placeholder text describing an example answer." Since the instructions mention "placeholder" I think it is safe to assume that some people will think they should use the attribute on the to fulfill this requirement. But the code check test checks the of the : So using the attribute will result in the following hint: "You should give the placeholder text describing an example answer." Which does not make it clear that the example answer should be embedded in the instead of using the attribute. Based on the current instructions I think most users will assume that the attribute should be used to complete this step and the test should be updated accordingly. <!-- Please complete the following information. --- Device: Desktop OS: Linux/Fedora 34 Browser: Firefox Version: 95.0.2
On
I was going to fix this issue by updating the test in step 38 to check the placeholder attribute on the textarea but then I realized that if we make this change then the HTML in each step after 38 would also need to be updated to use the placeholder attribute as well. So the question is, do we want to use the placeholder attribute and update all of the remaining steps or do we want to reword the instructions in step 38 to make it clear that you should embed the question text in the textarea and not use the placeholder attribute?
That's a good question. The placeholder text matches wording from referring to the attribute. That would make me think, the intention is to use the attribute.
Agreed, this should probably be updated to use the placeholder attribute. Looks like I've got a lot of updates to include in the PR.
Thank you, for opening this. When I wrote this, I vaguely remember reading a resource mentioning using the attribute on was not the recommended approach. However, as I cannot find that, I agree using the attribute in this case seems like the better option. Yes, this will require a rewrite for all subsequent lessons. However, this usually is a simple Find and Replace.
Perfect. I'll submit a PR for this in just a bit.
Change:
`dispatch` method is what you use to dispatch actions to the Redux store. Calling `store.dispatch()` and passing the value returned from an action creator sends an action back to the store. <del> Recall that action creators return an object with a type property that specifies the action that has occurred. Then the method dispatches an action object to the Redux store. Based on the previous challenge's example, the following lines are equivalent, and both dispatch the action of type `LOGIN`: </del> <ins> Recall that action creators return an object with a type property that specifies the type of action that has occurred. Then the method dispatches an action object to the Redux store. Based on the previous challenge's example, the following lines are equivalent, and both dispatch the action of type `LOGIN`: </ins> ```js store.dispatch(actionCreator());

Discussion:
Currently, the second paragraph in module, happens to be as follows: The first line of the second paragraph seems to be a bit incomplete. Considering that, I believe the first line of the second paragraph should be as follows: The first line of the second paragraph of module, should be as follows: <img width="513" alt="image" src=""- Device: Laptop OS: macOS 13.0.1 Browser: Chrome Version: 107.0.5304.110
This issue is still open?
Change:
# --description-- <del> Users will be allowed to chose either a `Personal Account` or `Business Account`. </del> <ins> Users will be allowed to choose either a `Personal Account` or `Business Account`. </ins> To do this, within each of the first two `label` elements, add one `input` element with `type="radio"`.

Discussion:
In the file curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration- There is a typo, "chose" should be "choose". If you would like to fix this issue please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
I would like to work on this
Go for it.
Added updated wording and is linked to issue.
We have two pull requests with the same change.
Change:
var bonfireSolution = myCodeMirror.getValue(); var thisBonfireHash = passedBonfireHash || null; var didCompleteWith = $('#completed-with').val() || null; completedBonfire(didCompleteWith, bonfireSolution, thisBonfireHash); });

Discussion:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --In the challenge CSS Flexbox: Use the flex-wrap Property to Wrap a Row or Column, the value wrap-reverse is defined: wrap-reverse: "wraps items from right-to-left if they are in a row, or bottom-to-top if they are in a column." This definition is not correct. Actually wrap-reverse wrap content changing de cross-axis direction, bottom to top in a row, and left to right in a column. Browser Name: Browser Version: Operating System:
I'd like to take on this issue please
Since the curriculum content is in the repo, I submitted the PR there.
Ok, thanks Simon.
Change:
## Feedback on pull requests <del> > Congratulations! :tada: on making a PR and thanks a lot for taking the time to contribute. </del> <ins> > :tada: Congratulations on making a PR and thanks a lot for taking the time to contribute. </ins> Our moderators will now take a look and leave you feedback. Please be patient with the fellow moderators and respect their time. All pull requests are reviewed in due course.

Discussion:
<!-- NOTE: If you want to become an author on freeCodeCamp, you can find everything here: --<!-- If you are reporting an issue with an article on our News publication, please follow this link to send an email to our editorial team -- <!-- Add a link to the page with the problem. --View the string in Crowdin where the is being parsed as a separate sentence. This is grammatically incorrect anyway and should be updated. <!-- Describe the problem and how to reproduce it. --Update the sentence to: <!-- A clear and concise description of how you want to update it. --<!-- If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box). --
Change:
return array; // Only change code above this line } <del> selectionSort([1, 4, 2, 8, 345, 123, 43, 32, 5643, 63, 123, 43, 2, 55, 1, 234, 92]); </del> ``` # --solutions--

Discussion:
The following challenges have an example function call in the seed code. These function calls should be removed and the related tests should be clarified to reflect the call instead. This sorting challenge is correct and could be used for reference.
Hi, nhcarrigan. I'd like to try to help and solve it. I'm still learning about the project so I would like to ask a question so I can understand the issue better. There is a function call in the file.. bubleSort([1,2,3....]) (example: implement-bubble-) ! And it should be removed from the seed section and transferred to here, similarly to implement-quick-sort: ! ! Is it correct or are there other files that I should be concerned about?
That is correct, yes - this same change should be completed on the four files I've linked. I would, however, recommend holding off on working on this until we receive additional consensus that this is the best way to proceed. If you run in to any questions, feel free to review our or ask in our or the .
Sounds great!! Thanks for the fast response. I will wait until further notice.
Hi MuriloMarquesSantos, are you still interested in fixing this issue?
Change:
dashedName: task-50 --- <del> <!-- (audio) Tom: Those are great traits for someone in her position, I think. What does she do as our team lead? --> </del> <ins> <!-- (audio) Tom: Those are great traits for someone in her position, I think. What does she do as the team lead? --> </ins> # --description--

Discussion:
The fill-in-the-blank sentence doesn't match what the character says. The written sentence is: The character says: Note the "the", instead of "our". No response Device: all OS: all Browser: all Version: all No response
Thank you for reporting the issue. Note for maintainers: Step 54 () uses "our" instead of "the" in the quiz. I think it's fine as-is since there isn't associated audio/caption text, but I'd vote updating it, too, for consistency. This issue is open to first-time code contributors to this repository. Requirements: In Change the text in the tag from to In Change the text in the tag from to Change the fill-in-the-blank text from to Change the backtick placement in the description text from ` In Change the text of the answers from to Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hi I've created a PR addressing these changes.