jiebi/CodeConvo huggingface dataset:
Change:
If a number appears four or more times, you will need to update the `Four of a Kind` option with your `updateRadioOption` function. If a number appears three or more times, you will need to update the `Three of a Kind` option. In both cases, the score value should be the sum of all five dice. <del> If neither of those are true, the final option should be updated with a score of `0`. Make sure to call your `getHighestDuplicates` when the dice are rolled. </del> <ins> Regardless of the outcome, the final option should be updated with a score of `0`. Make sure to call your `getHighestDuplicates` when the dice are rolled. </ins> # --hints--

Discussion:
In step 7 of the dice game (js beta) project, the instructions say: If a number appears four or more times, you will need to update the Four of a Kind option with your updateRadioOption function. If a number appears three or more times, you will need to update the Three of a Kind option. In both cases, the score value should be the sum of all five dice. If neither of those are true, the final option should be updated with a score of 0. However, when we check the code in step 8 we see that in fact, the final radio button should be updated regardless of whether any four or three of kind checks passed or failed. The code looks like this in step 8: So in fact the instruction was misleading when it said: If neither of those are true, the final option should be updated with a score of 0. What it actually should have said was: Also, the final option should be updated with a score of 0. (since the decision to update has nothing to do with whether duplicates were found) Whoever works on this issue should be aware of the other issue affecting step 13 in case the discussion there ends up changing what is done for this step N/A step should not suggest that the last radio button should only be updated if the previous checks have failed No response N/A No response
How about:? Regardless of the outcome, the final option should be updated with a score of .
Yes, let's go with this:
Change:
import meta from './meta'; import mathjax from './mathjax'; import sassjs from './sassjs'; <ins> import scripts from './scripts'; </ins> const metaAndStyleSheets = meta <del> .concat(favicons, mathjax, sassjs) </del> <ins> .concat(favicons, mathjax, sassjs, scripts) </ins> .map((element, i) => ({ ...element, key: `meta-stylesheet-${i}`,

Discussion:
I can work on this. A little confused though, since it appears to be there already. Does the mission statement go here? Please provide instructions, thanks.
Change:
"tests": [ "assert($("#left-well").css("background-color") === 'red' || $("#left-well").css("background-color") === 'rgb(255, 0, 0)' || $("#left-well").css("background-color").toLowerCase() === '#ff0000' || $("#left-well").css("background-color").toLowerCase() === '#f00', 'message: Your <code>left-well</code> element should have a red background.');", "assert(code.match(/.parents*()s*.css/g), 'message: You should use the <code>&#46;parent&#40;&#41;</code> function to modify this element.');", <del> "assert(code.match(/$s*?(s*?(?:'|")s*?#target1s*?(?:'|")s*?).parent/gi), 'message: The <code>&#46;parent&#40;&#41;</code> method should be called on the <code>&#35;target1</code> element.');", </del> <ins> "assert(code.match(/$s*?(s*?(?:'|")s*?#target1s*?(?:'|")s*?)s*?.parent/gi), 'message: The <code>&#46;parent&#40;&#41;</code> method should be called on the <code>&#35;target1</code> element.');", </ins> "assert(code.match(/<div class="well" id="left-well">/g), 'message: Only use jQuery to add these classes to the element.');" ], "type": "waypoint",

Discussion:
Challenge has an issue. User Agent is: <codeMozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.109 Safari/537.36</code. Please describe how to reproduce this issue, and include links to screenshots if possible. My code: The challenge accepts only (single or double quotes) without any spaces between the end of the call and the dot. For example, neither of the following is accepted:
Regex should probably be this (escaped for JS): instead of this:
We welcome a PR to fix this :smile:
Change:
"assert($("img").length === 2, 'You should have a total of two images.')", "assert(editor.match(/<img/g) && editor.match(/<img.*>/g).length === 2 && editor.match(/<img/g).length === 2, 'Make sure your new <code>img</code> element has a closing angle bracket.')", "assert($("img").hasClass("img-responsive"), 'Your new image should have the class <code>img-responsive</code>.')", <del> "assert(new RegExp("http://bit.ly/fcc-running-cats", "gi").test($("img.img-responsive").attr("src")), 'Add a second image with the <code>src</code> of <code>http&#58;//bit.ly/fcc-running-cats</code>.')" </del> <ins> "assert(new RegExp("http://bit.ly/fcc-running-cats", "gi").test($("img.img-responsive").attr("src")), 'Your new image should have a <code>src</code> attribute of <code>http&#58;//bit.ly/fcc-running-cats</code>.')" </ins> ], "challengeSeed": [ "<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">",

Discussion:
Challenge has an issue. Please describe how to reproduce it, and include links to screen shots if possible. The following will pass the test: Note: it's missing a at the end of it Im thinking this is a flaw with it rendering it on the fly creating the dom elements even if it's not complete? But it leads to a false sense of being done when you really aren't done with the element to pass it. Subjective I guess depending on your view of it?
new url
This is not passing for me. Has this been fixed? EDIT: okay yeah, it IS passing for me.
should apparently fix it. I have no idea how to add regex to the challenge, so is someone willing to test this out?
I will take a look into it, please feel free to assign the issue to me. EDIT: I've got some changes together to fix the issue.
Change:
isUsingKeyboardInTablist }: RenderEditorArgs) => { return ( <del> reduxChallengeFiles && ( </del> <ins> challengeFiles && ( </ins> <MultifileEditor <del> challengeFiles={reduxChallengeFiles} </del> <ins> challengeFiles={challengeFiles} </ins> block={block} superBlock={superBlock} containerRef={containerRef}

Discussion:
During development adding or modifying the head or tail code ( and ) don't seem to be updated in the challenge. Tested locally and on gitpod. Steps to reproduce the behavior: /modify the or in challenge. For example one of the steps in the JS curriculum. I was adding function and variables to it, and then was attempting to use them in tests. and wait for challenge to be updated. () the challenge page, or visit it for the first time. running tests, referencing the function/variables from head/tail code, there will be reference errors. Changing head or tail code, should update the challenge to use it. Login status don't seem to affect issue. During changing the code, thinking I might do something incorrectly, there were handful times when challenge was updated with the head/tail code. Not sure what was the exact reason. What makes it stranger is stopping client develop and starting again, is not necessarily solving the problem. At some point I thought that's working to get challenge fully updated, but right now that doesn't seem to work.
I might have seen this as well. I remember trying to save a regex in to use in multiple tests, and it didn't seem to work. Kind of just thought I was using it incorrectly, but maybe this was the issue.
Thanks for the detailed investigation of another tricky bug. It was another example where saved code messes things up. They're always a pain to debug because everyone sees something different, depending on whether or not they have something saved. Hopefully this is the last of them!
What's the most throwing off, that wasn't even code saved manually!
Weird. Is there nothing in your local storage?
Hmm, well there is after running tests. That must have been the point when saving mishap happened.
Oh, that's right. No mystery beyond "how did I forget this?" :face_exhaling:
Change:
"  ", "  ", "</style>", <del> "<a href="https://atjonathan.github.io/catphotoapp" target="_blank">CatPhotoApp</a>" </del> <ins> "<a href="http://freecatphotoapp.com/" target="_blank">CatPhotoApp</a>" </ins> ], "tests": [ "assert($('a').css('color') == 'rgb(0, 0, 0)', 'message: The anchor tag <code>color</code> should remain black, only add CSS rules for the <code>:hover</code> state.');",

Discussion:
We need to update the links in the challenges from to Changes are to be made here: and here:
I can take it! :)
please go ahead! Good luck. Here are the .
Donezo :). Thanks!
Change:
"descriptionEs": [ [ "http://i.imgur.com/NAOFJWN.jpg", <del> "Una imagen de algunos de nuestros campistas compartiendo en un café local. 3 hombres y 3 mujeres estan sentados alrededor de una mesa con portátiles afuera, y estan sonriendo y programando.", </del> <ins> "Una imagen de algunos de nuestros campistas compartiendo en un café local. 3 hombres y 3 mujeres están sentados alrededor de una mesa con portátiles afuera, y están sonriendo y programando.", </ins> "Nuestros Campamentos te ayudan a programar con otros campistas en tu ciudad. Puedes coordinar grupos de estudio o atender eventos de programación locales juntos.", "" ], [ "http://i.imgur.com/fTFMjwf.gif", <del> "Un gif mostrandote como puedes pulsar en el enlace inferior, encontrar tu ciudad en la lista de Campamentos, entonces haz clic en el enlace de Facebook para tu ciudad y unirte al grupo de Facebook de tu ciudad.", </del> <ins> "Un gif mostrándote como puedes pulsar en el enlace inferior, encontrar tu ciudad en la lista de Campamentos, entonces haz clic en el enlace de Facebook para tu ciudad y unirte al grupo de Facebook de tu ciudad.", </ins> "Encuentra tu ciudad en esta lista y haz clic en esta. Esto te llevara al grupo de Facebook del Campamento de tu ciudad. Da clic en el botón de "Unirse al grupo" para unirte a el grupo. Alguien del mismo campamento debería aprobarte en breve. Si tu ciudad no esta en esta lista, ve al final del articulo de la wiki para ver instrucciones de como crear un campamento para tu ciudad.", "https://github.com/FreeCodeCamp/freecodecamp/wiki/List-of-Free-Code-Camp-city-based-Campsites" ]

Discussion:
[X] Learn how Free Code Camp Works [X] Create a GitHub Account and Join our Chat Rooms [X] Configure your Code Portfolio [X] Join a Campsite in Your City [X] Learn What to Do If You Get Stuck
Change:
*, ::before, ::after { padding: 0; margin: 0; <ins> box-sizing: border-box; </ins> } html { font-size: 62.5%; <del> box-sizing: border-box; </del> } body {

Discussion:
Someone in the forums pointed out that adding the property just to will not have the intended effect since the property is not inherited. It appears to me that removing this property completely from in the final product does not seem to make any difference to the layout. Do we need ? If so, if the intent is to apply it to all elements then it should probably be moved to the rule set. Either remove completely or move it into the ruleset. No response N/A No response
Pretty sure I saw this in another challenge too and it got fixed. The CSS used looks like the of setting the but with the actual inheriting missing from the code. It should be fixed, but I would not suggest we remove , setting that (in my opinion) is pretty much a best pratice.
I'm guessing it would be easier and take less explaining to update step 26 to add the on that selector and then remove the mention of it in step 27. Then update all the seed code.
Just a heads up, if lasjorg PR merged without issue, balance sheet project suffer the same issue, we can open a PR or issue for it, if the PR is merged. Except that the balance sheet project , doesn't do much and moving it break the layout.
Change:
<p>Lets render this to the DOM</p> </div> ); <del> // Change code below this line </del> <ins> // Add your code below this line </ins> ReactDOM.render(JSX, document.getElementById('challenge-node')); ```

Discussion:
In module, the users are supposed to add their code after the provided code snippet. Keeping that in mind, the comment ( within the provided code snippet ) should be changed from to . In module, the provided code snippet should look as follows: ! Device: Laptop OS: macOS 13.0.1 Browser: Chrome Version: 107.0.5304.110
Change:
"Left factorials" ], [ <del> "5a23c84252665b21eecc7ee1", </del> <ins> "5e4ce2bbac708cc68c1df25f", </ins> "Letter frequency" ], [ <del> "5a23c84252665b21eecc7ee2", </del> <ins> "5e4ce2eaac708cc68c1df260", </ins> "Levenshtein distance" ], [ <del> "5a23c84252665b21eecc7ee3", </del> <ins> "5e4ce2f5ac708cc68c1df261", </ins> "Linear congruential generator" ], [ <del> "5a23c84252665b21eecc7eec", </del> <ins> "5e4ce2a1ac708cc68c1df25d", </ins> "Long multiplication" ], [

Discussion:
<img width="428" alt="Screen Shot 2020-03-26 at 8 07 49 PM" src="https://user-"The rosetta code challenges are all in alphabetical order except those first few. I did some digging and found that regenerated some mongo ID's for the challenge files. But it looks like those ID's we're never updated to match in the . I'm assuming that's the problem. And strangely I can't find them when I search my local DB - This may cause some issues if someone tries to submit one of these - not sure. Edit: that first link is actually to a commit and not a PR - with that commit Seems like there should be a test for this.
Change:
</head> <body> <header> <del> <img id="logo" src="https://cdn.freecodecamp.org/platform/universal/fcc_primary.svg"> </del> <ins> <img id="logo" alt="freeCodeCamp" src="https://cdn.freecodecamp.org/platform/universal/fcc_primary.svg"> </ins> <h1>HTML/CSS Quiz</h1> <nav> --fcc-editable-region--

Discussion:
[X] The "CSS" and the have the same value. This is affecting screen reader users since this involves an input and associated label. [ ] The logo in the upper left needs alt text. I would suggest it just be "freeCodeCamp". A lot of them. N/A Resolved Add alt text to the logo. Do we need to add an extra step for this or can we just add it to ? No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Seeing as the logo is non-functional, do we want the alt to be null? ? If it does require an , then this should get its own step, and a clear description as to why it needs one should be given. I suggest changing the of the (and associated ) to .
Per , the logo does require alt text. Functionality isn't the deciding factor here, it's if the image conveys information (i.e. is not purely decorative), which this image clearly does. Do we want to split this off into its own issue if we are going to create a new step?
I would say yes, but it is not fun to deal with the merge conflict, when two PRs are opened at the same time.
The logo still needs an alt text. The logo is introduced in step 7: That step should be updated to instruct campers to give the an alt text of . The seed code in all subsequent steps should be updated to include that new attribute.
hey may i work on this issue? if so please assign it to me
Hey We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
Change:
)}n${i18next.t('forum-help.add-code-three')}nn```n${endingText}` ); <del> const category = window.encodeURIComponent(helpCategory || 'Help'); </del> <ins> const category = window.encodeURIComponent( i18next.t('links:help.' + helpCategory || 'Help') ); </ins> const studentCode = window.encodeURIComponent(textMessage); const altStudentCode = window.encodeURIComponent(altTextMessage);

Discussion:
As we are now rolling out the curriculum in Chinese and Spanish, we need to think about how to get the button to work for the two languages. Currently, when the button is clicked, the user is taken to the English forum () where a pre-populated topic message (in English) is displayed for the user to fill in with relevant information. These topics are dynamically generated before the post is created on the forum, so we will just need to make use of the file for the content of the topics. Also, we will need to route to the correct forum url for Chinese and target the correct subforum for Spanish.
So the Chinese links work correctly, because the Chinese forum is hosted at a different domain (which is passed in to the environment variable). For Espanol, as it currently stands the category comes from the value returned by the .
Change:
Something does not look right. You added the correct `class` attribute value to the `p` element with `Donut` as its text, but you have not defined a selector for it. <del> Since the `flavor` class selector already has the properties you want, just add the `dessert` class name to it. </del> <ins> The CSS rule for the `flavor` class already sets the properties you want. Add the `dessert` class as an additional selector for this CSS rule. </ins> # --hints--

Discussion:
'just' is a bad word. If it doesn't already, our style guide should dissuade it. It implies the task is 'simple' which can frustrate learners who don't get it right. N/A Text should use friendly language. Possible fix: Note: the selector technically doesn't have the properties; the selector is part of a CSS rule that sets the desired properties. No response All No response_
Change:
runs-on: ubuntu-18.04 strategy: matrix: <del> browsers: [chrome] </del> <ins> browsers: [chrome, firefox] </ins> services: mongodb: image: mongo:3.6.19

Discussion:
!
Dropping Firefox support temporarily with . This was causing me to slow down with the PRs and rapid testing we are doing on the staging. I will let someone else investigate this.
any thoughts on this one? I'll take a look when I can, but I figured you might have some insight.
I'll look into it soon. Will let you know when I get to the bottom of it.
Mrugesh shared two links to the CI runs that failed and both of them failed for the . So, I was looking at the test and saw a lot of explicit timeout increasing... this is probably the reason why it fails on Firefox. Because the timeout were increased by watching the time it took on Chrome and manually adjusting it. But Firefox normally needs a few more seconds to finish running (this is due to ). I think increasing the timeout limit should do the trick.
We do wait for the editor, but everything after that should be basically instantaneous. Thanks for investigating that, but it should be fixed for Firefox 80 () and that's what we run the tests on. Also, suggests we should be using which could be a factor, but would have thought that would make things fail entirely rather than run slowly. That could work, yeah. The strange thing is the dev mode works perfectly locally and the CI should be even faster, since it uses the built site.
The bug is fixed on Firefox but Cypress still manually triggers GC as it is said in the Cypress docs (also when you run the tests locally in Firefox, it'll show you a message about GC. This is because Cypress doesn't manually run GC on but when it's run in CI using then Cypress manually triggers GC). I agree. I don't think this is the reason. I couldn't reproduce the bug locally... maybe we should try to reproduce it in CI by running it repeatedly?
Right, but would this make a test fail? If it runs between tests, which is the default, it should just make the whole run a bit slower. If it's included in the timeout for a particular test, that would be a massive oversight. My assumption is that the only timeout you might hit because of this is the limit for the entire run. Sure.

I'll let decide when he wants to do this, though, since it makes deploying a bit of a headache (if you're being bombarded with fail negatives, I mean).
I am open to creating a new branch on the upstream if you need to test it on CI by adding random commits? In theory you should be able to test it on a fork as well.
Change:
</Table> )} {id && ( <del> <Modal onClose={closeSolution} open={solutionOpen}> </del> <ins> <Modal onClose={closeSolution} open={solutionOpen} size='large'> </ins> <Modal.Header showCloseButton={true} closeButtonClassNames='close'> {`${username}'s Solution to ${ idToNameMap.get(id)?.challengeTitle ?? '' }`} </Modal.Header> <del> <Modal.Body> </del> <ins> <Modal.Body alignment='left'> </ins> <SolutionViewer challengeFiles={challengeData.challengeFiles} solution={challengeData.solution ?? ''}

Discussion:
The code should not be centered in the preview modal. or to on button for certification project with code ! ! Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response_
Change:
# --description-- <del> <a href="https://rosettacode.org/wiki/Cramer%27s_rule" target="_blank" rel="noopener noreferrer nofollow">Cramer's rule</a> is a formula for solving a system of linear equations by using the determinants of matrixes formed from subsets of the coefficients and right hand side values. </del> <ins> <a href="https://rosettacode.org/wiki/Cramer%27s_rule" target="_blank" rel="noopener noreferrer nofollow">Cramer's rule</a> is a formula for solving a system of linear equations by using the determinants of matrices formed from subsets of the coefficients and right hand side values. </ins> <del> The determinate of a matrix with 2 rows and two columns is given by: </del> <ins> The determinant of a matrix with 2 rows and two columns is given by: </ins> $begin{aligned}|A|={begin{vmatrix}a&bc&dend{vmatrix}}=ad-bc.end{aligned}$

Discussion:
there is a typo in cramers-rule challenge, is used instead of which is wrong these sentences should be changed to Here is the markdown file Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
I wanted to work on this issue
feel free to open pull request after you have read
Change:
You have either deleted the `body` element or it is missing an opening tag or closing tag. ```js <del> assert(document.querySelector('body') && code.match(/</body>/)); </del> <ins> assert.exists(document.querySelector('body')); assert.match(code, /</body>/); </ins> ``` Your `head` element should have an opening tag. Opening tags have the following syntax: `<elementName>`. ```js <del> assert(code.match(/<head>/)); </del> <ins> assert.match(code, /<head>/); </ins> ``` Your `head` element should have a closing tag. Closing tags have a `/` just after the `<` character. ```js <del> assert(code.match(/</head>/)); </del> <ins> assert.match(code, /</head>/); </ins> ``` Your `head` element should be above the opening `body` element tag. You have put it somewhere else. ```js const noSpaces = code.replace(/s/g, ''); <del> assert(noSpaces.match(/</head><body>/)); </del> <ins> assert.match(noSpaces, /</head><body>/); </ins> ``` # --seed--

Discussion:
We recently updated the guidelines for writing assertions here For consistency and matching what is in the docs, we should slowly start to update the tests for the workshops and labs in the new frontend cert. For this issue, just focus on updating the tests for steps 36 - 40 of the cat photo app workshop. We don't want to have a large PR that updates a whole bunch of tests in a bunch of steps and makes it harder to review. Here is the link to the workshop: The tests should be updated, where appropriate, to use specific methods like , , , etc instead of just . Here is the complete API reference Just focus on the new frontend cert and don't worry about updating the RWD cat photo app since that will become legacy anyway.