jiebi/CodeConvo huggingface dataset:
Code change:
Describe the bug AdGuardHome has the meta platform , but is a . To Reproduce Try to run on (or any architecture other than ). It will fail with : Expected behavior should execute, so that it can be used. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
I will try to get it instead of pulling a pre-compiled binary, but I'm not sure whether I'll get this solved. EDIT: Okay, that looks to be above my packaging skills, as the project consists of both a node component and a golang component, so it's nontrivial to package. An intermediate solution might be to use the architecture to determine the download URL, but that would make the src (and thus the hash) depend on the architecture. The downloads for different architectures .
Hotfix for aarch64 by using :
I marked this as stale due to inactivity. &rarr;
I also have the problem from the thread starter and I was wondering whether there is now official support for aarch64 (trying adguardhome on raspberrypi 3) or do I need to change smth in my config. I just use adguardhome as the inside of the systemPackages and I enable it. I also see this PR: .
the pr wasn't backported to 21.05. the pr will be in the 21.11 release which will be released today or tommorow afaik
great, thx for the info :)

Related discussion:
text: <ins> { fetchurl, fetchzip }: { "x86_64-darwin" = fetchzip { sha256 = "sha256-ec1l4KxKJH4Iwg9hW+xlxLADGLN1vParYaWIw7nCfKA="; url = "https://github.com/AdguardTeam/AdGuardHome/releases/download/v0.106.3/AdGuardHome_darwin_amd64.zip"; }; "i686-linux" = fetchurl { sha256 = "sha256-9aGyC76WyzwHlAkR72kuNcd/68XdWWC3gfT92IuW2LY="; url = "https://github.com/AdguardTeam/AdGuardHome/releases/download/v0.106.3/AdGuardHome_linux_386.tar.gz"; }; "x86_64-linux" = fetchurl { sha256 = "sha256-qJMymTxmoPlIhuJD6zFBWWwzz+CFx+9+MOrRiFtA4IY="; url = "https://github.com/AdguardTeam/AdGuardHome/releases/download/v0.106.3/AdGuardHome_linux_amd64.tar.gz"; }; "aarch64-linux" = fetchurl { sha256 = "sha256-Z5hekNxeemqWsMu7n3UTmYCzdKp5Xsp9ku0G2LOqC80="; url = "https://github.com/AdguardTeam/AdGuardHome/releases/download/v0.106.3/AdGuardHome_linux_arm64.tar.gz"; }; } </ins>
Code change:
Describe the bug AdGuardHome has the meta platform , but is a . To Reproduce Try to run on (or any architecture other than ). It will fail with : Expected behavior should execute, so that it can be used. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
I will try to get it instead of pulling a pre-compiled binary, but I'm not sure whether I'll get this solved. EDIT: Okay, that looks to be above my packaging skills, as the project consists of both a node component and a golang component, so it's nontrivial to package. An intermediate solution might be to use the architecture to determine the download URL, but that would make the src (and thus the hash) depend on the architecture. The downloads for different architectures .
Hotfix for aarch64 by using :
I marked this as stale due to inactivity. &rarr;
I also have the problem from the thread starter and I was wondering whether there is now official support for aarch64 (trying adguardhome on raspberrypi 3) or do I need to change smth in my config. I just use adguardhome as the inside of the systemPackages and I enable it. I also see this PR: .
the pr wasn't backported to 21.05. the pr will be in the 21.11 release which will be released today or tommorow afaik
great, thx for the info :)

Related discussion:
text: <del> { lib, stdenv, fetchurl }: </del> <ins> { lib, stdenv, fetchurl, fetchzip, system ? stdenv.targetPlatform }: </ins> stdenv.mkDerivation rec { pname = "adguardhome"; version = "0.106.3"; <del> src = fetchurl { url = "https://github.com/AdguardTeam/AdGuardHome/releases/download/v${version}/AdGuardHome_linux_amd64.tar.gz"; sha256 = "11p081dqilga61zfziw5w37k6v2r84qynhz2hr4gk8367jck54x8"; }; </del> <ins> src = (import ./bins.nix { inherit fetchurl fetchzip; }).${system}; </ins> installPhase = '' install -m755 -D ./AdGuardHome $out/bin/adguardhome ''; <ins> passthru = { updateScript = ./update.sh; }; </ins> meta = with lib; { homepage = "https://github.com/AdguardTeam/AdGuardHome"; description = "Network-wide ads & trackers blocking DNS server"; <del> platforms = platforms.linux; maintainers = with maintainers; [ numkem ]; license = licenses.gpl3; </del> <ins> platforms = [ "x86_64-linux" "aarch64-linux" "i686-linux" "x86_64-darwin" ]; maintainers = with maintainers; [ numkem iagoq ]; license = licenses.gpl3Only; </ins> }; }
Code change:
Describe the bug AdGuardHome has the meta platform , but is a . To Reproduce Try to run on (or any architecture other than ). It will fail with : Expected behavior should execute, so that it can be used. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
I will try to get it instead of pulling a pre-compiled binary, but I'm not sure whether I'll get this solved. EDIT: Okay, that looks to be above my packaging skills, as the project consists of both a node component and a golang component, so it's nontrivial to package. An intermediate solution might be to use the architecture to determine the download URL, but that would make the src (and thus the hash) depend on the architecture. The downloads for different architectures .
Hotfix for aarch64 by using :
I marked this as stale due to inactivity. &rarr;
I also have the problem from the thread starter and I was wondering whether there is now official support for aarch64 (trying adguardhome on raspberrypi 3) or do I need to change smth in my config. I just use adguardhome as the inside of the systemPackages and I enable it. I also see this PR: .
the pr wasn't backported to 21.05. the pr will be in the 21.11 release which will be released today or tommorow afaik
great, thx for the info :)

Related discussion:
text: <ins> #! /usr/bin/env nix-shell #! nix-shell -i bash -p curl gnugrep nix-prefetch jq # This file is based on /pkgs/servers/gotify/update.sh set -euo pipefail dirname="$(dirname "$0")" bins="$dirname/bins.nix" latest_release=$(curl --silent https://api.github.com/repos/AdguardTeam/AdGuardHome/releases/latest) version=$(jq -r '.tag_name' <<<"$latest_release") echo "got version $version" declare -A systems systems[linux_386]=i686-linux systems[linux_amd64]=x86_64-linux systems[linux_arm64]=aarch64-linux systems[darwin_amd64]=x86_64-darwin echo '{ fetchurl, fetchzip }:' > "$bins" echo '{'        >> "$bins" for asset in $(curl --silent https://api.github.com/repos/AdguardTeam/AdGuardHome/releases/latest | jq -c '.assets[]') ; do url="$(jq -r '.browser_download_url' <<< "$asset")" adg_system="$(grep -Eo '(darwin|linux)_(386|amd64|arm64)' <<< "$url" || true)" if [ -n "$adg_system" ]; then fetch="$(grep '.zip$' <<< "$url" > /dev/null && echo fetchzip || echo fetchurl)" nix_system=${systems[$adg_system]} nix_src="$(nix-prefetch -s --output nix $fetch --url $url)" echo ""$nix_system" = $fetch $nix_src;" >> $bins fi done echo '}' >> "$bins" sed -i -r -e "s/versions*?=s*?.*?;/version = "${version#v}";/" "$dirname/default.nix" </ins>
Code change:
Describe the bug As of this commit the package no longer allows overriding the JRE without failing to build. It still worked as of this commit To Reproduce Note that is the content of the in the above commit. note it also fails when overriding with however which is the current java15 version works. Expected behavior Successful build of SBT Additional context Non Debug output Notify maintainers Metadata Maintainer information:

Related discussion:
text: sha256 = "sha256-wqdZ/kCjwhoWtaiNAM1m869vByHk6mG2OULfuDotVP0="; }; <del> patchPhase = '' </del> <ins> postPatch = '' </ins> echo -java-home ${jre.home} >>conf/sbtopts '';
Code change:
Describe the bug As of this commit the package no longer allows overriding the JRE without failing to build. It still worked as of this commit To Reproduce Note that is the content of the in the above commit. note it also fails when overriding with however which is the current java15 version works. Expected behavior Successful build of SBT Additional context Non Debug output Notify maintainers Metadata Maintainer information:

Related discussion:
text: buildInputs = lib.optionals stdenv.isLinux [ zlib ]; installPhase = '' <ins> runHook preInstall </ins> mkdir -p $out/share/sbt $out/bin cp -ra . $out/share/sbt ln -sT ../share/sbt/bin/sbt $out/bin/sbt ln -sT ../share/sbt/bin/sbtn-x86_64-${ if (stdenv.isDarwin) then "apple-darwin" else "pc-linux" } $out/bin/sbtn <del> ''; doInstallCheck = true; installCheckPhase = '' ($out/bin/sbt --offline --version 2>&1 || true) | grep 'getting org.scala-sbt sbt ${version}  (this may take some time)' </del> <ins> runHook postInstall </ins> ''; meta = with lib; {
Code change:
Describe the bug After electron 12 came out, adding in home-manager succeeds, but trying to start the app fails mentioning a missing javascript function from an older version of electron. To Reproduce Steps to reproduce the behavior: to home-manager's app from terminal with Expected behavior Expected the application start as it had before. Additional context I was able to get it working locally by providing an overlay to home-manager: I would have created a PR myself, but I'm still new to nix and not sure entirely how to require a different electron version in the package derivation. Notify maintainers Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(jon): nixpkgs: Maintainer information:
thanks for catching this! Just fixed in the PR above.

Related discussion:
text: <del> { lib, stdenv, fetchurl, appimageTools, makeWrapper, electron, libsecret }: </del> <ins> { lib, stdenv, fetchurl, appimageTools, makeWrapper, electron_11, libsecret }: </ins> stdenv.mkDerivation rec { pname = "todoist-electron";
Code change:
Describe the bug After electron 12 came out, adding in home-manager succeeds, but trying to start the app fails mentioning a missing javascript function from an older version of electron. To Reproduce Steps to reproduce the behavior: to home-manager's app from terminal with Expected behavior Expected the application start as it had before. Additional context I was able to get it working locally by providing an overlay to home-manager: I would have created a PR myself, but I'm still new to nix and not sure entirely how to require a different electron version in the package derivation. Notify maintainers Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(jon): nixpkgs: Maintainer information:
thanks for catching this! Just fixed in the PR above.

Related discussion:
text: ''; postFixup = '' <del> makeWrapper ${electron}/bin/electron $out/bin/${pname}  </del> <ins> makeWrapper ${electron_11}/bin/electron $out/bin/${pname}  </ins> --add-flags $out/share/${pname}/resources/app.asar  --prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath [ stdenv.cc.cc libsecret ]}" '';
Code change:
Project description On some installations this simple text editor even has syntax highlightning, but it might require non-trivial amounts of work to get that part to work. Metadata homepage URL: source URL: Gitlab, , tag = or alternatively: latest current version: 1.2.2 license: MIT (according to the ebuild in the Gentoo repository) platforms: at least linux, but might also support other platforms with X11 support
I marked this as stale due to inactivity. &rarr;
I still need this.

Related discussion:
text: <ins> { lib , stdenv , fetchFromGitLab , autoreconfHook , pkg-config , utilmacros , libX11 , libXaw , libXmu , libXt }: stdenv.mkDerivation rec { pname = "xedit"; version = "1.2.2"; src = fetchFromGitLab { domain = "gitlab.freedesktop.org"; owner = "xorg/app"; repo = "xedit"; rev = "${pname}-${version}"; sha256 = "0b5ic13aasv6zh20v2k7zyxsqbnsxfq5rs3w8nwzl1gklmgrjxa3"; }; nativeBuildInputs = [ autoreconfHook pkg-config utilmacros ]; buildInputs = [ libX11 libXaw libXmu libXt ]; configureFlags = [ "--with-lispdir=$out/share/X11/xedit/lisp" "--with-appdefaultdir=$out/share/X11/app-defaults" ]; meta = with lib; { description = "Simple graphical text editor using Athena Widgets (Xaw)"; homepage = "https://gitlab.freedesktop.org/xorg/app/xedit"; license = with licenses; [ mit ]; maintainers = with maintainers; [ shamilton ]; platforms = platforms.linux; }; } </ins>
Code change:
Project description On some installations this simple text editor even has syntax highlightning, but it might require non-trivial amounts of work to get that part to work. Metadata homepage URL: source URL: Gitlab, , tag = or alternatively: latest current version: 1.2.2 license: MIT (according to the ebuild in the Gentoo repository) platforms: at least linux, but might also support other platforms with X11 support
I marked this as stale due to inactivity. &rarr;
I still need this.

Related discussion:
text: xed = callPackage ../development/libraries/xed { }; <ins> xedit = callPackage ../applications/editors/xedit { }; </ins> xine-lib = callPackage ../development/libraries/xine-lib { }; xautolock = callPackage ../misc/screensavers/xautolock { };
Code change:
The package hard-codes various X11 libraries as dependencies while making many other features optional, including GUIs. It would be nice to have an option to disable the X11 feature and the related . The use case I have in mind is installing a custom Vim on a remote server. Pulling X libraries, even without enabling a GUI, adds a few dozen megabytes for something essentially useless. An approach is doing something like this: but it doesn't feel very clean... Any thoughts from or ?
I agree. It would have been nice if these X dependencies would have been to only if is or .
/me whispers neovim~~~
I'm all for testing new things and neovim is on my list. But according to , the neovim package pulls 428MiB of dependencies, half of which for Ruby, the other half for both Python 3 and Python 2 (seriously?). Is there a way, by any chance, to configure neovim to avoid this bloat ?
admittedly I've never tried to configure a mininmal version but one can unselect these ecosystems:
See .

Related discussion:
text: patches = [ ./cflags-prune.diff ] ++ lib.optional ftNixSupport ./ft-nix-support.patch; configureFlags = [ <del> "--enable-gui=${guiSupport}" </del> "--with-features=${features}" "--disable-xsmp"              # XSMP session management "--disable-xsmp_interact"     # XSMP interaction
Code change:
The package hard-codes various X11 libraries as dependencies while making many other features optional, including GUIs. It would be nice to have an option to disable the X11 feature and the related . The use case I have in mind is installing a custom Vim on a remote server. Pulling X libraries, even without enabling a GUI, adds a few dozen megabytes for something essentially useless. An approach is doing something like this: but it doesn't feel very clean... Any thoughts from or ?
I agree. It would have been nice if these X dependencies would have been to only if is or .
/me whispers neovim~~~
I'm all for testing new things and neovim is on my list. But according to , the neovim package pulls 428MiB of dependencies, half of which for Ruby, the other half for both Python 3 and Python 2 (seriously?). Is there a way, by any chance, to configure neovim to avoid this bloat ?
admittedly I've never tried to configure a mininmal version but one can unselect these ecosystems:
See .

Related discussion:
text: "--disable-carbon_check" "--disable-gtktest" ] <ins> ++ lib.optional (guiSupport == "gtk2" || guiSupport == "gtk3") "--enable-gui=${guiSupport}" </ins> ++ lib.optional stdenv.isDarwin (if darwinSupport then "--enable-darwin" else "--disable-darwin") ++ lib.optionals luaSupport [
Code change:
The package hard-codes various X11 libraries as dependencies while making many other features optional, including GUIs. It would be nice to have an option to disable the X11 feature and the related . The use case I have in mind is installing a custom Vim on a remote server. Pulling X libraries, even without enabling a GUI, adds a few dozen megabytes for something essentially useless. An approach is doing something like this: but it doesn't feel very clean... Any thoughts from or ?
I agree. It would have been nice if these X dependencies would have been to only if is or .
/me whispers neovim~~~
I'm all for testing new things and neovim is on my list. But according to , the neovim package pulls 428MiB of dependencies, half of which for Ruby, the other half for both Python 3 and Python 2 (seriously?). Is there a way, by any chance, to configure neovim to avoid this bloat ?
admittedly I've never tried to configure a mininmal version but one can unselect these ecosystems:
See .

Related discussion:
text: ++ lib.optional (guiSupport == "gtk3") wrapGAppsHook ; <del> buildInputs = [ ncurses libX11 libXext libSM libXpm libXt libXaw libXau libXmu glib libICE ] </del> <ins> buildInputs = [ ncurses glib ] # All X related dependencies ++ lib.optionals (guiSupport == "gtk2" || guiSupport == "gtk3") [ libSM libICE libX11 libXext libXpm libXt libXaw libXau libXmu ] </ins> ++ lib.optional (guiSupport == "gtk2") gtk2-x11 ++ lib.optional (guiSupport == "gtk3") gtk3-x11 ++ lib.optionals darwinSupport [ CoreServices CoreData Cocoa Foundation libobjc ]
Code change:
Project description a mining pool, maintains a fork of XMRig which adds the benefit of automatic algorithm switching. I have created following overlay which seems to work fine. The question is if anyone is interested in having it implemented as a separate package, replace the , or if it should be integrated as an option to a new XMRig systemd service (which would also be a nice-to-have, such as ) Notify Maintainers: Metadata homepage URL: source URL: license: gpl3 platforms: linux, darwin

Related discussion:
text: <ins> { fetchFromGitHub, lib, xmrig }: xmrig.overrideAttrs (oldAttrs: rec { pname = "xmrig-mo"; version = "6.14.1-mo1"; src = fetchFromGitHub { owner = "MoneroOcean"; repo = "xmrig"; rev = "v${version}"; sha256 = "sha256-1YG0llNv1VR8ocNFxYLZFXMzowNNqpqSyIu7iCr/rfM="; }; meta = with lib; { description = "A fork of the XMRig CPU miner with support for algorithm switching"; homepage = "https://github.com/MoneroOcean/xmrig"; license = licenses.gpl3Plus; platforms = [ "x86_64-linux" "x86_64-darwin" ]; maintainers = with maintainers; [ j0hax ]; }; }) </ins>
Code change:
Project description a mining pool, maintains a fork of XMRig which adds the benefit of automatic algorithm switching. I have created following overlay which seems to work fine. The question is if anyone is interested in having it implemented as a separate package, replace the , or if it should be integrated as an option to a new XMRig systemd service (which would also be a nice-to-have, such as ) Notify Maintainers: Metadata homepage URL: source URL: license: gpl3 platforms: linux, darwin

Related discussion:
text: xmrig = callPackage ../applications/misc/xmrig { }; <ins> xmrig-mo = callPackage ../applications/misc/xmrig/moneroocean.nix { }; </ins> xmrig-proxy = callPackage ../applications/misc/xmrig/proxy.nix { }; molot-lite = callPackage ../applications/audio/molot-lite { };
Code change:
Describe the bug creates a defect as the block is defined two times. To Reproduce Steps to reproduce the behavior: Enable and Expected behavior and should be merged to one block. Additional context I'm on zfs. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(plumps): channels(root): nixpkgs: Maintainer information:
I have a PR up to fix this

Related discussion:
text: inherit (lib) mkOption types; <del> # Once https://github.com/NixOS/nixpkgs/pull/75584 is merged we can use the TOML generator toTOML = name: value: pkgs.runCommandNoCC name { nativeBuildInputs = [ pkgs.remarshal ]; value = builtins.toJSON value; passAsFile = [ "value" ]; } '' json2toml "$valuePath" "$out" ''; </del> <ins> toml = pkgs.formats.toml { }; </ins> in { meta = {
Code change:
Describe the bug creates a defect as the block is defined two times. To Reproduce Steps to reproduce the behavior: Enable and Expected behavior and should be merged to one block. Additional context I'm on zfs. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(plumps): channels(root): nixpkgs: Maintainer information:
I have a PR up to fix this

Related discussion:
text: [ "virtualisation" "containers" "users" ] "All users with `isNormalUser = true` set now get appropriate subuid/subgid mappings." ) <ins> ( lib.mkRemovedOptionModule [ "virtualisation" "containers" "containersConf" "extraConfig" ] "Use virtualisation.containers.containersConf.settings instead." ) </ins> ]; options.virtualisation.containers = {
Code change:
Describe the bug creates a defect as the block is defined two times. To Reproduce Steps to reproduce the behavior: Enable and Expected behavior and should be merged to one block. Additional context I'm on zfs. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(plumps): channels(root): nixpkgs: Maintainer information:
I have a PR up to fix this

Related discussion:
text: description = "Enable the OCI seccomp BPF hook"; }; <del> containersConf = mkOption { default = {}; </del> <ins> containersConf.settings = mkOption { type = toml.type; default = { }; </ins> description = "containers.conf configuration"; <del> type = types.submodule { options = { extraConfig = mkOption { type = types.lines; default = ""; description = '' Extra configuration that should be put in the containers.conf configuration file ''; }; }; }; </del> }; registries = {
Code change:
Describe the bug creates a defect as the block is defined two times. To Reproduce Steps to reproduce the behavior: Enable and Expected behavior and should be merged to one block. Additional context I'm on zfs. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(plumps): channels(root): nixpkgs: Maintainer information:
I have a PR up to fix this

Related discussion:
text: }; config = lib.mkIf cfg.enable { <ins> virtualisation.containers.containersConf.settings = { network.cni_plugin_dirs = [ "${pkgs.cni-plugins}/bin/" ]; engine = { init_path = "${pkgs.catatonit}/bin/catatonit"; } // lib.optionalAttrs cfg.ociSeccompBpfHook.enable { hooks_dir = [ config.boot.kernelPackages.oci-seccomp-bpf-hook ]; }; }; </ins> <del> environment.etc."containers/containers.conf".text = '' [network] cni_plugin_dirs = ["${pkgs.cni-plugins}/bin/"] [engine] init_path = "${pkgs.catatonit}/bin/catatonit" ${lib.optionalString (cfg.ociSeccompBpfHook.enable) '' hooks_dir = [ "${config.boot.kernelPackages.oci-seccomp-bpf-hook}", ] ''} '' + cfg.containersConf.extraConfig; </del> <ins> environment.etc."containers/containers.conf".source = toml.generate "containers.conf" cfg.containersConf.settings; </ins> <del> environment.etc."containers/registries.conf".source = toTOML "registries.conf" { </del> <ins> environment.etc."containers/registries.conf".source = toml.generate "registries.conf" { </ins> registries = lib.mapAttrs (n: v: { registries = v; }) cfg.registries; };
Code change:
Describe the bug creates a defect as the block is defined two times. To Reproduce Steps to reproduce the behavior: Enable and Expected behavior and should be merged to one block. Additional context I'm on zfs. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(plumps): channels(root): nixpkgs: Maintainer information:
I have a PR up to fix this

Related discussion:
text: virtualisation.containers = { enable = true; # Enable common /etc/containers configuration <del> containersConf.extraConfig = lib.optionalString cfg.enableNvidia (builtins.readFile (toml.generate "podman.nvidia.containers.conf" { engine = { conmon_env_vars = [ "PATH=${lib.makeBinPath [ pkgs.nvidia-podman ]}" ]; runtimes.nvidia = [ "${pkgs.nvidia-podman}/bin/nvidia-container-runtime" ]; }; })); </del> <ins> containersConf.settings = lib.optionalAttrs cfg.enableNvidia { engine = { conmon_env_vars = [ "PATH=${lib.makeBinPath [ pkgs.nvidia-podman ]}" ]; runtimes.nvidia = [ "${pkgs.nvidia-podman}/bin/nvidia-container-runtime" ]; }; }; </ins> }; systemd.packages = [ cfg.package ];