jiebi/CodeConvo huggingface dataset:
Code change:
Describe the bug When I launch using a keyboard shortcut, it didn't get any context, resulting in it displaying strangely: ! If I launch it using the menu it displays correctly. For other applications, depending on what they requires, they sometime just don't open. EDIT : I have the feeling that the reason that is not opening when using the keybinding is the same reason. To Reproduce Steps to reproduce the behavior: a shortcut to Konsole konsole with the shortcut Additional information While starting with the shortcut, this inputs is visible in : Expected behavior The program should behave the same way as when launched using menu. Metadata Maintainer information:
Woah, it doesn't seem to even have a PATH environment.
New way to reproduce the issue : when the feature to restore previous window after a logout/login is active, it restarts the application with the same issue.
Applying the fix from fixed this issue.
I cherry-picked and it fixed this issue for me; however my KDE windows are all still borderless.
Hmm, that sounds like kwin died.

Related discussion:
text: <del> Index: kinit-5.32.0/src/kdeinit/kinit.cpp =================================================================== --- kinit-5.32.0.orig/src/kdeinit/kinit.cpp +++ kinit-5.32.0/src/kdeinit/kinit.cpp @@ -623,19 +623,15 @@ static pid_t launch(int argc, const char if (!libpath.isEmpty()) { if (libpath_relative) { -                // NB: Because Qt makes the actual dlopen() call, the -                //     RUNPATH of kdeinit is *not* respected - see -                //     https://sourceware.org/bugzilla/show_bug.cgi?id=13945 -                //     - so we try hacking it in ourselves -                QString install_lib_dir = QFile::decodeName( -                        CMAKE_INSTALL_PREFIX "/" LIB_INSTALL_DIR "/"); -                QString orig_libpath = libpath; -                libpath = install_lib_dir + libpath; -                l.setFileName(libpath); -                if (!l.load()) { -                    libpath = orig_libpath; -                    l.setFileName(libpath); -                    l.load(); +                // Try to load the library relative to the active profiles. +                QByteArrayList profiles = qgetenv("NIX_PROFILES").split(' '); +                // Reverse the profile list. +                std::reverse(profiles.begin(), profiles.end()); +                for (const QByteArray &profile: profiles) { +                    if (!profile.isEmpty()) { +                        l.setFileName(QFile::decodeName(profile) + QStringLiteral("/lib/") + libpath); +                        if (l.load()) break; +                    } } } else { l.load(); </del>
Code change:
Describe the bug When I launch using a keyboard shortcut, it didn't get any context, resulting in it displaying strangely: ! If I launch it using the menu it displays correctly. For other applications, depending on what they requires, they sometime just don't open. EDIT : I have the feeling that the reason that is not opening when using the keybinding is the same reason. To Reproduce Steps to reproduce the behavior: a shortcut to Konsole konsole with the shortcut Additional information While starting with the shortcut, this inputs is visible in : Expected behavior The program should behave the same way as when launched using menu. Metadata Maintainer information:
Woah, it doesn't seem to even have a PATH environment.
New way to reproduce the issue : when the feature to restore previous window after a logout/login is active, it restarts the application with the same issue.
Applying the fix from fixed this issue.
I cherry-picked and it fixed this issue for me; however my KDE windows are all still borderless.
Hmm, that sounds like kwin died.

Related discussion:
text: <del> Index: kinit-5.24.0/src/start_kdeinit/start_kdeinit_wrapper.c =================================================================== --- kinit-5.24.0.orig/src/start_kdeinit/start_kdeinit_wrapper.c +++ kinit-5.24.0/src/start_kdeinit/start_kdeinit_wrapper.c @@ -23,7 +23,7 @@ #include <string.h> #include <unistd.h> -#define EXECUTE CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 "/start_kdeinit" +#define EXECUTE "/run/wrappers/bin/start_kdeinit" #if KDEINIT_OOM_PROTECT </del>
Code change:
Describe the bug bazel broken on darwin in nixpkgs HEAD () To Reproduce Steps to reproduce the behavior: to build bazel on darwin Expected behavior Able to build bazel on darwin Additional context might be related to Metadata Please run and paste the result. Maintainer information: cc:
The bazel build is passing LDFLAGS flags to the compiler instead of the linker. Those should be prefixed with or moved somewhere else.
Clang used as a frontend should accept linker flags.
Flags were in .

Related discussion:
text: postPatch = let darwinPatches = '' <ins> bazelLinkFlags () { eval set -- "$NIX_LDFLAGS" local flag for flag in "$@"; do printf ' -Wl,%s' "$flag" done } </ins> # Disable Bazel's Xcode toolchain detection which would configure compilers # and linkers from Xcode instead of from PATH export BAZEL_USE_CPP_ONLY_TOOLCHAIN=1
Code change:
Describe the bug bazel broken on darwin in nixpkgs HEAD () To Reproduce Steps to reproduce the behavior: to build bazel on darwin Expected behavior Able to build bazel on darwin Additional context might be related to Metadata Please run and paste the result. Maintainer information: cc:
The bazel build is passing LDFLAGS flags to the compiler instead of the linker. Those should be prefixed with or moved somewhere else.
Clang used as a frontend should accept linker flags.
Flags were in .

Related discussion:
text: # Framework search paths aren't added by bintools hook # https://github.com/NixOS/nixpkgs/pull/41914 <del> export NIX_LDFLAGS="$NIX_LDFLAGS -F${CoreFoundation}/Library/Frameworks -F${CoreServices}/Library/Frameworks -F${Foundation}/Library/Frameworks" </del> <ins> export NIX_LDFLAGS+=" -F${CoreFoundation}/Library/Frameworks -F${CoreServices}/Library/Frameworks -F${Foundation}/Library/Frameworks" </ins> # libcxx includes aren't added by libcxx hook # https://github.com/NixOS/nixpkgs/pull/41589 export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${libcxx}/include/c++/v1" # don't use system installed Xcode to run clang, use Nix clang instead <del> sed -i -E "s;/usr/bin/xcrun (--sdk macosx )?clang;${stdenv.cc}/bin/clang $NIX_CFLAGS_COMPILE $NIX_LDFLAGS -framework CoreFoundation;g"  </del> <ins> sed -i -E "s;/usr/bin/xcrun (--sdk macosx )?clang;${stdenv.cc}/bin/clang $NIX_CFLAGS_COMPILE $(bazelLinkFlags) -framework CoreFoundation;g"  </ins> scripts/bootstrap/compile.sh  src/tools/xcode/realpath/BUILD  src/tools/xcode/stdredirect/BUILD
Code change:
Describe the bug Installing nomachine-client fails To Reproduce Steps to reproduce the behavior: to environment.systemPackages Expected behavior It should build the derivation Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:
I tried overriding the hash (any tip on how to more properly do this would be appreciated), but still got build errors in my under environment.systemPackages result:
There's a PR to upgrade : I this to my and it seems to be working for me:
Yep, this is because NoMachine removes each old release as soon as they make a new one. To combat this, I'll add to the sources list when the update is done.
I was finding at the time that even overriding with the latest URL and hash from the nomachine website, that it was failing to download the whole blob. I could do it from my browser, but it seemed to abort/not download the full size via nixos
Oh, that's strange.. Thankfully, it seems to work just fine now :)

Related discussion:
text: { stdenv, file, fetchurl, makeWrapper, autoPatchelfHook, jsoncpp, libpulseaudio }: let <del> versionMajor = "6.9"; versionMinor = "2"; </del> <ins> versionMajor = "6.10"; versionMinor = "12"; </ins> versionBuild_x86_64 = "1"; versionBuild_i686 = "1"; in stdenv.mkDerivation rec { pname = "nomachine-client"; version = "${versionMajor}.${versionMinor}"; src = if stdenv.hostPlatform.system == "x86_64-linux" then fetchurl { url = "https://download.nomachine.com/download/${versionMajor}/Linux/nomachine_${version}_${versionBuild_x86_64}_x86_64.tar.gz"; <del> sha256 = "1z2pcfkzicjma4lxrj4qx43xyml993v7qyjd7k8xy8hw85fwnzii"; </del> <ins> sha256 = "17yb377ry7i7cmkb72xmhyqkfggv1ygqlz55ymvmrs7psbh7ql01"; </ins> } else if stdenv.hostPlatform.system == "i686-linux" then fetchurl { url = "https://download.nomachine.com/download/${versionMajor}/Linux/nomachine_${version}_${versionBuild_i686}_i686.tar.gz"; <del> sha256 = "03421s0k91c02ga9k6bdvixw71brlgi13q82cinnfayg3fhb0rb6"; </del> <ins> sha256 = "0k6dspmwdkm0zf0c2zqlqy0jya8qgsg90wwv9wa12fn4chp66gqg"; </ins> } else throw "NoMachine client is not supported on ${stdenv.hostPlatform.system}"; postUnpack = '' mv $(find . -type f -name nxclient.tar.gz) . mv $(find . -type f -name nxplayer.tar.gz) .
Code change:
Describe the bug Installing nomachine-client fails To Reproduce Steps to reproduce the behavior: to environment.systemPackages Expected behavior It should build the derivation Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:
I tried overriding the hash (any tip on how to more properly do this would be appreciated), but still got build errors in my under environment.systemPackages result:
There's a PR to upgrade : I this to my and it seems to be working for me:
Yep, this is because NoMachine removes each old release as soon as they make a new one. To combat this, I'll add to the sources list when the update is done.
I was finding at the time that even overriding with the latest URL and hash from the nomachine website, that it was failing to download the whole blob. I could do it from my browser, but it seemed to abort/not download the full size via nixos
Oh, that's strange.. Thankfully, it seems to work just fine now :)

Related discussion:
text: tar xf nxplayer.tar.gz rm $(find . -maxdepth 1 -type f) ''; nativeBuildInputs = [ file makeWrapper autoPatchelfHook ]; buildInputs = [ jsoncpp libpulseaudio ];
Code change:
Describe the bug Installing nomachine-client fails To Reproduce Steps to reproduce the behavior: to environment.systemPackages Expected behavior It should build the derivation Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:
I tried overriding the hash (any tip on how to more properly do this would be appreciated), but still got build errors in my under environment.systemPackages result:
There's a PR to upgrade : I this to my and it seems to be working for me:
Yep, this is because NoMachine removes each old release as soon as they make a new one. To combat this, I'll add to the sources list when the update is done.
I was finding at the time that even overriding with the latest URL and hash from the nomachine website, that it was failing to download the whole blob. I could do it from my browser, but it seemed to abort/not download the full size via nixos
Oh, that's strange.. Thankfully, it seems to work just fine now :)

Related discussion:
text: cp "$i"/* "$out/share/icons/hicolor/$(basename $i)/apps/" fi done mkdir $out/share/applications cp share/applnk/player/xdg/*.desktop $out/share/applications/ cp share/applnk/client/xdg-mime/*.desktop $out/share/applications/
Code change:
Describe the bug Installing nomachine-client fails To Reproduce Steps to reproduce the behavior: to environment.systemPackages Expected behavior It should build the derivation Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:
I tried overriding the hash (any tip on how to more properly do this would be appreciated), but still got build errors in my under environment.systemPackages result:
There's a PR to upgrade : I this to my and it seems to be working for me:
Yep, this is because NoMachine removes each old release as soon as they make a new one. To combat this, I'll add to the sources list when the update is done.
I was finding at the time that even overriding with the latest URL and hash from the nomachine website, that it was failing to download the whole blob. I could do it from my browser, but it seemed to abort/not download the full size via nixos
Oh, that's strange.. Thankfully, it seems to work just fine now :)

Related discussion:
text: substituteInPlace "$i" --replace /usr/NX/bin $out/bin done ''; postFixup = '' makeWrapper $out/bin/nxplayer.bin $out/bin/nxplayer --set NX_SYSTEM $out/NX makeWrapper $out/bin/nxclient.bin $out/bin/nxclient --set NX_SYSTEM $out/NX
Code change:
Describe the bug Installing nomachine-client fails To Reproduce Steps to reproduce the behavior: to environment.systemPackages Expected behavior It should build the derivation Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:
I tried overriding the hash (any tip on how to more properly do this would be appreciated), but still got build errors in my under environment.systemPackages result:
There's a PR to upgrade : I this to my and it seems to be working for me:
Yep, this is because NoMachine removes each old release as soon as they make a new one. To combat this, I'll add to the sources list when the update is done.
I was finding at the time that even overriding with the latest URL and hash from the nomachine website, that it was failing to download the whole blob. I could do it from my browser, but it seemed to abort/not download the full size via nixos
Oh, that's strange.. Thankfully, it seems to work just fine now :)

Related discussion:
text: # have a DT_NEEDED entry for it. patchelf --add-needed libpulse.so.0 $out/NX/lib/libnxcau.so ''; dontBuild = true; dontStrip = true;
Code change:
Describe the bug Installing nomachine-client fails To Reproduce Steps to reproduce the behavior: to environment.systemPackages Expected behavior It should build the derivation Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:
I tried overriding the hash (any tip on how to more properly do this would be appreciated), but still got build errors in my under environment.systemPackages result:
There's a PR to upgrade : I this to my and it seems to be working for me:
Yep, this is because NoMachine removes each old release as soon as they make a new one. To combat this, I'll add to the sources list when the update is done.
I was finding at the time that even overriding with the latest URL and hash from the nomachine website, that it was failing to download the whole blob. I could do it from my browser, but it seemed to abort/not download the full size via nixos
Oh, that's strange.. Thankfully, it seems to work just fine now :)

Related discussion:
text: platforms = [ "x86_64-linux" "i686-linux" ]; }; }
Code change:
Describe the bug I've tried building two packages from source on my new MacBook Air running macOS 10.15/Catalina ( and a custom expression for ), and both times I get the same set of errors involving Xcode/iOS simulator/permissions/etc. It never seems to start to the build. Example: I don't know for sure whether it has to do with Catalina, but I never received these errors when using 10.14/Mojave. To Reproduce Steps to reproduce the behavior: Nix on a Mac running Catalina. I used the instructions . to install a package that has a source-based build for Darwin such as . Expected behavior The package should install or at least give me errors related to the build rather than Xcode/iOS simulator/permissions/etc. errors. Metadata Maintainer information:
iterm2 is currently broken on Catalina. I remember to have it fixed locally months ago but didn't find the time to open a pull request.
I was just using iterm2 as an example. The errors I'm receiving are generic and occur for any source build using Xcode on my new computer running Catalina. Separately, I also remember iterm2 being broken while I was using Mojave. These are different errors.
Could you test my pull request that should fix this issue (at least for iterm2)?
just tested and it works, thanks! But what are and ? I can't find those documented anywhere.

Related discussion:
text: { stdenv, fetchFromGitHub }: <ins> /* This derivation is impure: it relies on an Xcode toolchain being installed and available in the expected place. The values of sandboxProfile are copied pretty directly from the MacVim derivation, which is also impure. In order to build you at least need the `sandbox` option set to `relaxed` or `false`. */ </ins> stdenv.mkDerivation rec { pname = "iterm2"; <del> version = "3.0.14"; </del> <ins> version = "3.3.9"; </ins> src = fetchFromGitHub { owner = "gnachman"; repo = "iTerm2"; rev = "v${version}"; <del> sha256 = "03m0ja11w9910z96yi8fzq3436y8xl14q031rdb2w3sapjd54qrj"; </del> <ins> sha256 = "06mq3gfjgy8jw2f3fzdsi3pbfkdijfzzlhlw6ixa5bfb4hbcgn5j"; </ins> }; patches = [ ./disable_updates.patch ]; postPatch = '' sed -i -e 's/CODE_SIGN_IDENTITY = "Developer ID Application"/CODE_SIGN_IDENTITY = ""/g' ./iTerm2.xcodeproj/project.pbxproj ''; preConfigure = "LD=$CC"; <del> makeFlagsArray = ["Deployment"]; </del> <ins> makeFlagsArray = ["Nix"]; </ins> installPhase = '' <del> mkdir -p "$out/Applications" mv "build/Deployment/iTerm2.app" "$out/Applications/iTerm.app" </del> <ins> mkdir -p $out/Applications mv Build/Products/Deployment/iTerm2.app $out/Applications/iTerm.app ''; sandboxProfile = '' (allow file-read* file-write* process-exec mach-lookup) ; block homebrew dependencies (deny file-read* file-write* process-exec mach-lookup (subpath "/usr/local") (with no-log)) </ins> ''; <del> meta = { </del> <ins> meta = with stdenv.lib; { </ins> description = "A replacement for Terminal and the successor to iTerm"; homepage = https://www.iterm2.com/; <del> license = stdenv.lib.licenses.gpl2; platforms = stdenv.lib.platforms.darwin; </del> <ins> license = licenses.gpl2; maintainers = with maintainers; [ tricktron ]; platforms = platforms.darwin; hydraPlatforms = []; </ins> }; }
Code change:
Update certbot Current packaged version is 0.39.0, upstream version is 1.2.0.
Fix in

Related discussion:
text: 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/certbot/setup.py b/certbot/setup.py <del> index c1bf914..7456bf2 100644 </del> <ins> index d19327e5e..ac1524793 100644 </ins> --- a/certbot/setup.py +++ b/certbot/setup.py <del> @@ -3,7 +3,6 @@ import os </del> <ins> @@ -1,5 +1,4 @@ import codecs -from distutils.version import StrictVersion import os </ins> import re import sys <del> -from distutils.version import StrictVersion from setuptools import find_packages, setup, __version__ as setuptools_version from setuptools.command.test import test as TestCommand @@ -56,20 +55,8 @@ install_requires = [ </del> <ins> @@ -58,20 +57,8 @@ install_requires = [ </ins> # Add pywin32 on Windows platforms to handle low-level system calls. # This dependency needs to be added using environment markers to avoid its installation on Linux.
Code change:
Update certbot Current packaged version is 0.39.0, upstream version is 1.2.0.
Fix in

Related discussion:
text: +install_requires.append(pywin32_req + " ; sys_platform == 'win32'") dev_extras = [ <del> 'astroid==1.6.5', </del> <ins> 'coverage', </ins> -- 2.24.1
Code change:
Update certbot Current packaged version is 0.39.0, upstream version is 1.2.0.
Fix in

Related discussion:
text: <del> { stdenv, python37Packages, fetchFromGitHub, fetchurl, dialog, autoPatchelfHook }: </del> <ins> { lib , buildPythonApplication , fetchFromGitHub , ConfigArgParse, acme, configobj, cryptography, distro, josepy, parsedatetime, pyRFC3339, pyopenssl, pytz, requests, six, zope_component, zope_interface , dialog, mock, gnureadline , pytest_xdist, pytest, dateutil }: </ins> <del> python37Packages.buildPythonApplication rec { </del> <ins> buildPythonApplication rec { </ins> pname = "certbot"; <del> version = "1.0.0"; </del> <ins> version = "1.3.0"; </ins> src = fetchFromGitHub { owner = pname; repo = pname; rev = "v${version}"; <del> sha256 = "180x7gcpfbrzw8k654s7b5nxdy2yg61lq513dykyn3wz4gssw465"; </del> <ins> sha256 = "1nzp1l63f64qqp89y1vyd4lgfhykfp5dkr6iwfiyf273y7sjwpsa"; </ins> }; patches = [ ./0001-Don-t-use-distutils.StrictVersion-that-cannot-handle.patch ]; <del> propagatedBuildInputs = with python37Packages; [ </del> <ins> propagatedBuildInputs = [ </ins> ConfigArgParse acme configobj
Code change:
Update certbot Current packaged version is 0.39.0, upstream version is 1.2.0.
Fix in

Related discussion:
text: distro josepy parsedatetime <del> psutil </del> pyRFC3339 pyopenssl pytz <ins> requests </ins> six zope_component zope_interface ]; <del> buildInputs = [ dialog ] ++ (with python37Packages; [ mock gnureadline ]); </del> <ins> buildInputs = [ dialog mock gnureadline ]; </ins> <del> checkInputs = with python37Packages; [ pytest_xdist pytest dateutil ]; </del> <ins> checkInputs = [ pytest_xdist pytest dateutil ]; </ins> <del> postPatch = '' </del> <ins> preBuild = '' </ins> cd certbot <del> substituteInPlace certbot/_internal/notify.py --replace "/usr/sbin/sendmail" "/run/wrappers/bin/sendmail" </del> ''; postInstall = ''
Code change:
Update certbot Current packaged version is 0.39.0, upstream version is 1.2.0.
Fix in

Related discussion:
text: doCheck = true; <del> meta = with stdenv.lib; { </del> <ins> meta = with lib; { </ins> homepage = src.meta.homepage; description = "ACME client that can obtain certs and extensibly update server configurations"; platforms = platforms.unix; <del> maintainers = [ maintainers.domenkozar ]; license = licenses.asl20; </del> <ins> maintainers = with maintainers; [ domenkozar ]; license = with licenses; [ asl20 ]; </ins> }; }
Code change:
Update certbot Current packaged version is 0.39.0, upstream version is 1.2.0.
Fix in

Related discussion:
text: ogre = ogre1_10; }; <del> certbot = callPackage ../tools/admin/certbot { }; </del> <ins> certbot = python3Packages.callPackage ../tools/admin/certbot { }; </ins> caf = callPackage ../development/libraries/caf {};