jiebi/CodeConvo huggingface dataset:
Code change:
OAuth2 Proxy's Nginx plugin used to forward and headers to downstream programs. This stopped working after I updated on unstable channel, which is potentially related to or . Steps to reproduce the behavior: up OAuth2 Proxy + Nginx up of header name . does not recognize the session More simply: up OAuth2 Proxy + Nginx or something similar the headers — and used to be present, but not anymore and are passed to downstream servers under Nginx. I have I went on upgrade of nixpkgs unstable from sometime late January to a few hours ago, which is what led me to the two PRs mentioned above. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --cc Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
are you able to play around a bit and confirm if the changes mentioned introduced this regression?
yes. I can't really pin-point to what exactly since there were a lot of changes. Instead, I just have a local fork from (prior to the changes mentioned in the PRs above).
I have a pretty good idea what it could be.
Can you give a try? I didn't test it yet, so it could completely break everything and be completely insecure, just as warning.
fantastic work please let us know how it goes ‍
Sorry for the late reply, I haven't been able to have time to test it out. Now that I do, it seems like has been converted to . This won't be an easy find-and-replace for me to try in my setup, so I will have to find some time to do proper cleanup.

Related discussion:
text: proxy_pass_request_body           off; ''; }; "@redirectToAuth2ProxyLogin" = { return = "307 https://${cfg.domain}/oauth2/start?rd=$scheme://$host$request_uri"; extraConfig = ''
Code change:
OAuth2 Proxy's Nginx plugin used to forward and headers to downstream programs. This stopped working after I updated on unstable channel, which is potentially related to or . Steps to reproduce the behavior: up OAuth2 Proxy + Nginx up of header name . does not recognize the session More simply: up OAuth2 Proxy + Nginx or something similar the headers — and used to be present, but not anymore and are passed to downstream servers under Nginx. I have I went on upgrade of nixpkgs unstable from sometime late January to a few hours ago, which is what led me to the two PRs mentioned above. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --cc Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
are you able to play around a bit and confirm if the changes mentioned introduced this regression?
yes. I can't really pin-point to what exactly since there were a lot of changes. Instead, I just have a local fork from (prior to the changes mentioned in the PRs above).
I have a pretty good idea what it could be.
Can you give a try? I didn't test it yet, so it could completely break everything and be completely insecure, just as warning.
fantastic work please let us know how it goes ‍
Sorry for the late reply, I haven't been able to have time to test it out. Now that I do, it seems like has been converted to . This won't be an easy find-and-replace for me to try in my setup, so I will have to find some time to do proper cleanup.

Related discussion:
text: auth_request /oauth2/auth; error_page 401 = @redirectToAuth2ProxyLogin; <del> # pass information via X-User and X-Email headers to backend, # requires running with --set-xauthrequest flag </del> <ins> # set variables being used in locations."/".extraConfig </ins> auth_request_set $user   $upstream_http_x_auth_request_user; auth_request_set $email  $upstream_http_x_auth_request_email; <del> proxy_set_header X-User  $user; proxy_set_header X-Email $email; # if you enabled --cookie-refresh, this is needed for it to work with auth_request </del> auth_request_set $auth_cookie $upstream_http_set_cookie; <del> add_header Set-Cookie $auth_cookie; </del> ''; }; }) cfg.virtualHosts)));
Code change:
Package name: snapcast Latest released version: 0.28.0 <!-- Search your package here: --- Current version on the unstable channel: 0.27.0 Current version on the stable/release channel: 0.27.0 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <del> { stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config </del> <ins> { stdenv, lib, fetchFromGitHub, cmake, pkg-config </ins> , alsa-lib, asio, avahi, boost179, flac, libogg, libvorbis, libopus, soxr , IOKit, AudioToolbox , aixlog, popl , pulseaudioSupport ? false, libpulseaudio , nixosTests }: <del> assert pulseaudioSupport -> libpulseaudio != null; </del> stdenv.mkDerivation rec { pname = "snapcast"; <del> version = "0.27.0"; </del> <ins> version = "0.28.0"; </ins> src = fetchFromGitHub { owner  = "badaix"; repo   = "snapcast"; rev    = "v${version}"; <del> sha256 = "sha256-dlK1xQQqst4VQjioC7MZzqXwMC+JfqtvnD5lrOqGhYI="; </del> <ins> sha256 = "sha256-XxpiLojs1TI3qM7yXS+OPcHKo6pLcfJ+Eop7GjQ4HQw="; </ins> }; <del> patches = [ # Can be removed with next release after 0.27.0 (fetchpatch { name = "include-cstdint.patch"; url = "https://github.com/badaix/snapcast/commit/481f08199ca31c60c9a3475f1064e6b06a503d12.patch"; hash = "sha256-klpvmBpBAlBMtcgnNfW6X6vDbJFnOuOsPUDXcNf5tGc="; }) ]; </del> nativeBuildInputs = [ cmake pkg-config ]; # snapcast also supports building against tremor but as we have libogg, that's # not needed
Code change:
Package name: gummy Latest released version: 0.6.0 <!-- Search your package here: --- Current version on the unstable channel: 0.3 Current version on the stable/release channel: 0.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- There is an open pull request () by from October 2023, but it has not been merged and later versions of the program have been released since then. I think it is also worth noting that the source code repository of the is no longer available on GitHub. as the repository has moved to Codeberg (see ). Notify maintainers (last updated the package) <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I updated my linked PR to the latest version.
Thank you for updating it so quickly! Is there a time frame in which we can expect the pull request to be merged by someone?

Related discussion:
text: { lib , stdenv <del> , fetchFromGitHub </del> <ins> , fetchFromGitea , substituteAll </ins> , testers , gummy , cmake
Code change:
Package name: gummy Latest released version: 0.6.0 <!-- Search your package here: --- Current version on the unstable channel: 0.3 Current version on the stable/release channel: 0.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- There is an open pull request () by from October 2023, but it has not been merged and later versions of the program have been released since then. I think it is also worth noting that the source code repository of the is no longer available on GitHub. as the repository has moved to Codeberg (see ). Notify maintainers (last updated the package) <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I updated my linked PR to the latest version.
Thank you for updating it so quickly! Is there a time frame in which we can expect the pull request to be merged by someone?

Related discussion:
text: , libXext , sdbus-cpp , udev <ins> , xcbutilimage </ins> , coreutils <ins> , cli11 , ddcutil , fmt , nlohmann_json , spdlog </ins> }: stdenv.mkDerivation rec { pname = "gummy"; <del> version = "0.3"; </del> <ins> version = "0.6.0"; </ins> <del> src = fetchFromGitHub { owner = "fushko"; </del> <ins> src = fetchFromGitea { domain = "codeberg.org"; owner = "fusco"; </ins> repo = "gummy"; rev = version; <del> sha256 = "sha256-dw2yOXTS61OIe+NOq8MPydhkZvTit13eC7cbL5nFseg="; </del> <ins> hash = "sha256-kATieFf+dEpcYgSEPoETacP7R+u2dOrg7rOhIkNQ1uE="; </ins> }; nativeBuildInputs = [
Code change:
Package name: gummy Latest released version: 0.6.0 <!-- Search your package here: --- Current version on the unstable channel: 0.3 Current version on the stable/release channel: 0.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- There is an open pull request () by from October 2023, but it has not been merged and later versions of the program have been released since then. I think it is also worth noting that the source code repository of the is no longer available on GitHub. as the repository has moved to Codeberg (see ). Notify maintainers (last updated the package) <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I updated my linked PR to the latest version.
Thank you for updating it so quickly! Is there a time frame in which we can expect the pull request to be merged by someone?

Related discussion:
text: ]; buildInputs = [ <ins> cli11 ddcutil fmt </ins> libX11 libXext <ins> nlohmann_json </ins> sdbus-cpp <ins> spdlog </ins> udev <ins> xcbutilimage </ins> ]; cmakeFlags = [ "-DUDEV_DIR=${placeholder "out"}/lib/udev" <ins> "-DUDEV_RULES_DIR=${placeholder "out"}/lib/udev/rules.d" </ins> ]; # Fixes the "gummy start" command, without this it cannot find the binary. # Setting this through cmake does not seem to work. postPatch = '' <del> substituteInPlace src/gummy/gummy.cpp  </del> <ins> substituteInPlace gummyd/gummyd/api.cpp  </ins> --replace "CMAKE_INSTALL_DAEMON_PATH" ""${placeholder "out"}/libexec/gummyd"" ''; preFixup = '' <del> substituteInPlace $out/lib/udev/99-gummy.rules  </del> <ins> substituteInPlace $out/lib/udev/rules.d/99-gummy.rules  </ins> --replace "/bin/chmod" "${coreutils}/bin/chmod" ln -s $out/libexec/gummyd $out/bin/gummyd
Code change:
Package name: gummy Latest released version: 0.6.0 <!-- Search your package here: --- Current version on the unstable channel: 0.3 Current version on the stable/release channel: 0.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- There is an open pull request () by from October 2023, but it has not been merged and later versions of the program have been released since then. I think it is also worth noting that the source code repository of the is no longer available on GitHub. as the repository has moved to Codeberg (see ). Notify maintainers (last updated the package) <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I updated my linked PR to the latest version.
Thank you for updating it so quickly! Is there a time frame in which we can expect the pull request to be merged by someone?

Related discussion:
text: passthru.tests.version = testers.testVersion { package = gummy; }; meta = with lib; { <del> homepage = "https://github.com/Fushko/gummy"; </del> <ins> homepage = "https://codeberg.org/fusco/gummy"; </ins> description = "Brightness and temperature manager for X11"; longDescription = '' CLI screen manager for X11 that allows automatic and manual brightness/temperature adjustments, via backlight (currently only for embedded displays) and gamma. Multiple monitors are supported. ''; license = licenses.gpl3Only; <del> maintainers = [ maintainers.ivar ]; </del> <ins> maintainers = with maintainers; [ ivar ]; </ins> }; }
Code change:
Package name: clapper Latest released version: 0.6.0 Current version on the unstable channel: 0.5.2 Current version on the stable/release channel: 0.5.2 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: , lib , stdenv , fetchFromGitHub <del> , glib </del> , gobject-introspection <del> , python3 </del> , pkg-config , ninja , wayland
Code change:
Package name: clapper Latest released version: 0.6.0 Current version on the unstable channel: 0.5.2 Current version on the stable/release channel: 0.5.2 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: , shared-mime-info , wrapGAppsHook4 , meson <del> , gjs </del> , gtk4 , gst_all_1 , libGL , libadwaita <del> , appstream-glib , libsoup </del> <ins> , libsoup_3 , vala , cmake , libmicrodns </ins> }: <del> stdenv.mkDerivation rec { </del> <ins> stdenv.mkDerivation (finalAttrs: { </ins> pname = "clapper"; <del> version = "0.5.2"; </del> <ins> version = "0.6.0"; </ins> src = fetchFromGitHub { owner  = "Rafostar"; <del> repo   = pname; rev    = version; sha256 = "sha256-s+qdTq3/pHHstwr1W3Hs2Zje++iJFHM6hQTFoZD43bY="; </del> <ins> repo   = "clapper"; rev    = finalAttrs.version; hash = "sha256-5fD1OnVcY3ZC+QfoFqe2jV43/J36r85SpLUYF2ti7dY="; </ins> }; nativeBuildInputs = [ <del> appstream-glib desktop-file-utils # for update-desktop-database glib </del> gobject-introspection meson <ins> cmake </ins> ninja makeWrapper pkg-config <del> python3 shared-mime-info # for update-mime-database </del> wrapGAppsHook4 # for gsettings <ins> desktop-file-utils # for update-desktop-database shared-mime-info # for update-mime-database vala </ins> ]; buildInputs = [ <del> gjs </del> gst_all_1.gstreamer gst_all_1.gst-plugins-base gst_all_1.gst-plugins-good
Code change:
Package name: clapper Latest released version: 0.6.0 Current version on the unstable channel: 0.5.2 Current version on the stable/release channel: 0.5.2 Notify maintainers Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: gtk4 libGL libadwaita <del> libsoup </del> <ins> libsoup_3 </ins> wayland wayland-protocols <ins> libmicrodns </ins> ]; postPatch = '' <del> patchShebangs build-aux/meson/postinstall.py ''; postInstall = '' cp ${src}/data/icons/*.svg $out/share/icons/hicolor/scalable/apps/ cp ${src}/data/icons/*.svg $out/share/icons/hicolor/symbolic/apps/ </del> <ins> patchShebangs --build build-aux/meson/postinstall.py </ins> ''; meta = with lib; { <del> description = "A GNOME media player built using GJS with GTK4 toolkit and powered by GStreamer with OpenGL rendering. "; </del> <ins> description = "A GNOME media player built using GTK4 toolkit and powered by GStreamer with OpenGL rendering"; </ins> longDescription = '' <del> Clapper is a GNOME media player build using GJS with GTK4 toolkit. The media player is using GStreamer as a media backend and renders everything via OpenGL. </del> <ins> Clapper is a GNOME media player built using the GTK4 toolkit. The media player is using GStreamer as a media backend. </ins> ''; homepage = "https://github.com/Rafostar/clapper"; license = licenses.gpl3Plus; maintainers = with maintainers; [ ]; platforms = platforms.linux; }; <del> } </del> <ins> }) </ins>
Code change:
example: This one is low on the massive bucket list, but extending the number of retries and the timeout between each retry will reduce friction.
This might be caused by , in which case increasing the timeout wouldn't help much. We can try though, PR appreciated!
please view

Related discussion:
text: # https://docs.github.com/en/rest/guides/using-the-rest-api-to-interact-with-your-git-database?apiVersion=2022-11-28#checking-mergeability-of-pull-requests # Retry the API query this many times <del> retryCount=3 </del> <ins> retryCount=5 </ins> # Start with 5 seconds, but double every retry retryInterval=5 while true; do
Code change:
When installing usbimager the path in the desktop file is /usr/bin/usbimager, so when you try to open the application it doesn't open, to fix it you have to copy the desktop file from /run/current-system/sw/share/applications/usbimager.desktop to and edit the desktop so it reads Exec=usbimager Install usbimager, try to open the application from your menu, at least this is the behaviour on xfce, I've not tested it on other desktop environments system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Does it work in a nix-shell? nix-shell -p usbimager usbimager Worked perfectly for me on hyprland.
It works in a shell, it also works when installed system wide when you launch it from a terminal, its when you try and launch it from a menu like xfce's whiskermenu it doesn't launch, because the desktop file has Exec=/usr/bin/usbimager

Related discussion:
text: -e 's|install -m 2755 -g $(GRP)|install |g' Makefile ''; <ins> postInstall = '' substituteInPlace $out/share/applications/usbimager.desktop  --replace-fail "Exec=/usr/bin/usbimager" "Exec=usbimager" ''; </ins> dontConfigure = true; makeFlags =  [ "PREFIX=$(out)" ]
Code change:
Koodo reader is an electron application, and although the build process to add the proper ozone flags when the app is launched in a Wayland environment, it seems for some reason, it's not working as expected: But launching the app with the required flags, it works: The process arguments seem weird: Notice that the the by the package are truncated after the first space . I tried splitting up the flag into two sentences to avoid spaces: But now it looks l like the process does not pick up the environment variables: The variables exist, I define them as . Changing the above override to explicitly set the ozone flags (without the shell expansion conditional) works. Other packages like do the same shell expansion, and they also work in my environment without overriding anything. Steps to reproduce the behavior: in a wayland environment (I'm using hyprland) if the application is using xwayland by running shows the application again but with the ozone flags the app does not use xwayland: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I'm not a wayland user, so I usually just copy this line from other electron apps' definitions and hope it works. I think the issue here is that when is present will use the binary implementation, which doesn't expand shell variables, thus not making this work. It looks like I forgot about this behaviour when packaging this.

Related discussion:
text: fetchYarnDeps, makeDesktopItem, copyDesktopItems, <ins> makeWrapper, </ins> wrapGAppsHook, electron, }:
Code change:
Koodo reader is an electron application, and although the build process to add the proper ozone flags when the app is launched in a Wayland environment, it seems for some reason, it's not working as expected: But launching the app with the required flags, it works: The process arguments seem weird: Notice that the the by the package are truncated after the first space . I tried splitting up the flag into two sentences to avoid spaces: But now it looks l like the process does not pick up the environment variables: The variables exist, I define them as . Changing the above override to explicitly set the ozone flags (without the shell expansion conditional) works. Other packages like do the same shell expansion, and they also work in my environment without overriding anything. Steps to reproduce the behavior: in a wayland environment (I'm using hyprland) if the application is using xwayland by running shows the application again but with the ozone flags the app does not use xwayland: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I'm not a wayland user, so I usually just copy this line from other electron apps' definitions and hope it works. I think the issue here is that when is present will use the binary implementation, which doesn't expand shell variables, thus not making this work. It looks like I forgot about this behaviour when packaging this.

Related discussion:
text: nativeBuildInputs = [ copyDesktopItems <ins> makeWrapper </ins> wrapGAppsHook ];
Code change:
Koodo reader is an electron application, and although the build process to add the proper ozone flags when the app is launched in a Wayland environment, it seems for some reason, it's not working as expected: But launching the app with the required flags, it works: The process arguments seem weird: Notice that the the by the package are truncated after the first space . I tried splitting up the flag into two sentences to avoid spaces: But now it looks l like the process does not pick up the environment variables: The variables exist, I define them as . Changing the above override to explicitly set the ozone flags (without the shell expansion conditional) works. Other packages like do the same shell expansion, and they also work in my environment without overriding anything. Steps to reproduce the behavior: in a wayland environment (I'm using hyprland) if the application is using xwayland by running shows the application again but with the ozone flags the app does not use xwayland: Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I'm not a wayland user, so I usually just copy this line from other electron apps' definitions and hope it works. I think the issue here is that when is present will use the binary implementation, which doesn't expand shell variables, thus not making this work. It looks like I forgot about this behaviour when packaging this.

Related discussion:
text: runHook postInstall ''; <ins> # we use makeShellWrapper instead of the makeBinaryWrapper provided by wrapGAppsHook for proper shell variable expansion </ins> postFixup = '' <del> makeWrapper ${electron}/bin/electron $out/bin/koodo-reader  </del> <ins> makeShellWrapper ${electron}/bin/electron $out/bin/koodo-reader  </ins> --add-flags $out/share/lib/koodo-reader/resources/app.asar  "''${gappsWrapperArgs[@]}"  --add-flags "''${NIXOS_OZONE_WL:+''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}"