jiebi/CodeConvo huggingface dataset:
Code change:
Applications are starting to allocate more times than allowed by the default value of vm.maxmapcount, . For instance, this situation arises in applications such as Ryujinx () and newer Windows games like Hogwarts Legacy (). SteamOS has already addressed this matter by augmenting the aforementioned value, while Fedora intends to implement the same modification in Fedora 39 (, ).
Please feel free to send PRs, it's hard to track those issues as you don't mention any owner.
The line to add is: The questions are: How big should n be? ? ? In which file should I add it? At the bottom of
You mentioned other distros were thinking about bumping it, let's follow Fedora lead In the relevant file, a quick grep shows indeed that sysctl is one of the best candidate. :)
For the policy discussion: I'm all in favor of doing this soon(m). It is not really dangerous and as people have explained to me the previous default has been there for historical reasons and 32 bit systems.

Related discussion:
text: "fs.inotify.max_queued_events" = 1048576; "fs.inotify.max_user_instances" = 1048576; "fs.inotify.max_user_watches" = 1048576; <del> "vm.max_map_count" = 262144; </del> <ins> "vm.max_map_count" = 262144; # TODO: Default vm.max_map_count has been increased system-wide </ins> "kernel.dmesg_restrict" = 1; "net.ipv4.neigh.default.gc_thresh3" = 8192; "net.ipv6.neigh.default.gc_thresh3" = 8192;
Code change:
Applications are starting to allocate more times than allowed by the default value of vm.maxmapcount, . For instance, this situation arises in applications such as Ryujinx () and newer Windows games like Hogwarts Legacy (). SteamOS has already addressed this matter by augmenting the aforementioned value, while Fedora intends to implement the same modification in Fedora 39 (, ).
Please feel free to send PRs, it's hard to track those issues as you don't mention any owner.
The line to add is: The questions are: How big should n be? ? ? In which file should I add it? At the bottom of
You mentioned other distros were thinking about bumping it, let's follow Fedora lead In the relevant file, a quick grep shows indeed that sysctl is one of the best candidate. :)
For the policy discussion: I'm all in favor of doing this soon(m). It is not really dangerous and as people have explained to me the previous default has been there for historical reasons and 32 bit systems.

Related discussion:
text: export MOZILLA_OFFICIAL=1 '' + lib.optionalString stdenv.hostPlatform.isMusl '' # linking firefox hits the vm.max_map_count kernel limit with the default musl allocator <ins> # TODO: Default vm.max_map_count has been increased, retest without this </ins> export LD_PRELOAD=${mimalloc}/lib/libmimalloc.so '';
Code change:
Originally spotted by (thank you!). Steps to reproduce the behavior (assuming and are both ): The environment variable contains semicolons and must be quoted, otherwise bash will interpret the semicolons as command separators.
- Hey, I am not sure how to clean up the mess I just made on . Really embarrassed. I intended to rebase and hit merge instead, which pulled in 10k changes.
No worries, Happens to everyone at some point :) Personally, I'd just open a new PR.
Here it is: . Does the commit history look clean enough? I'll try to rebase it later, but I am concerned about retagging all of those folks.
I'd say don't worry about it -- as far as best practice goes, I'm actually not sure what's recommended for commits. do we recommend squashing before merge? I know I typically just do force pushes to avoid any commit history :l
I went ahead and squashed, and I'll post a nixpkgs-review when it's finished.
I don't think we have an official stance on this. Contributors use their best judgement for whatever keeps the commit history simplest and easiest to use

Related discussion:
text: <del> { cmake , cudaPackages , fetchFromGitHub , lib , ninja , pkgs , python3Packages ? { } , pythonSupport ? false , stdenv , symlinkJoin , which }: let </del> <ins> { cmake, cudaPackages, fetchFromGitHub, lib, ninja, python3Packages ? {}, pythonSupport ? false, stdenv, symlinkJoin, which, }: let </ins> inherit (lib) lists strings; inherit (cudaPackages) backendStdenv cudaFlags; cuda-common-redist = with cudaPackages; [ <ins> cuda_cudart # cuda_runtime.h </ins> libcublas # cublas_v2.h libcusolver # cusolverDn.h libcusparse # cusparse.h
Code change:
Originally spotted by (thank you!). Steps to reproduce the behavior (assuming and are both ): The environment variable contains semicolons and must be quoted, otherwise bash will interpret the semicolons as command separators.
- Hey, I am not sure how to clean up the mess I just made on . Really embarrassed. I intended to rebase and hit merge instead, which pulled in 10k changes.
No worries, Happens to everyone at some point :) Personally, I'd just open a new PR.
Here it is: . Does the commit history look clean enough? I'll try to rebase it later, but I am concerned about retagging all of those folks.
I'd say don't worry about it -- as far as best practice goes, I'm actually not sure what's recommended for commits. do we recommend squashing before merge? I know I typically just do force pushes to avoid any commit history :l
I went ahead and squashed, and I'll post a nixpkgs-review when it's finished.
I don't think we have an official stance on this. Contributors use their best judgement for whatever keeps the commit history simplest and easiest to use

Related discussion:
text: cuda-native-redist = symlinkJoin { name = "cuda-redist"; <del> paths = with cudaPackages; [ cuda_cudart # cuda_runtime.h cuda_nvcc ] ++ cuda-common-redist; </del> <ins> paths = with cudaPackages; [cuda_nvcc] ++ cuda-common-redist; </ins> }; cuda-redist = symlinkJoin {
Code change:
the sway test is flaky, both because ocr itself seems to flaky and because ocr seems to be very slow. Steps to reproduce the behavior: a couple times, we haven't gotten it to work even once this seems to be blocking nixos-unstable channel updates. there are a number of timeouts in the hydra build logs that we can very clearly attribute to either ocr not working, or ocr timing out because it gets only one shot at finding the gpg prompt (and if that fails, loops forever on the empty desktop).
I found it failing quite reliably, exactly since merging the .
scrolling throug hydra logs it's been flaky before too though, something is definitely up. there's failures in early may that look exactly like what we see now
Where do you see this? Looking through I only see successful builds (apart from the cancelled builds and dependency failures). I also don't remember it ever failing when working on it. So this definitely seems to be a regression from staging-next (either it just causes issues with (some of) the OCR tests or it can even affect users - in which case it would be very good that the test is failing). Unfortunately I don't really have time to look into it right now (maybe Thursday or Saturday). It could be due to a font rendering regression. Hm, that's strange - the GnuPG pinentry-gnome3 passphrase prompt shouldn't disappear automatically / after a short timeout (if that's the case than we definitely need to change that part).
Both and failed consistently at this point: So it looks like either doesn't start when using the Wayland backend or the font rendering is broken then (with the X11 backend (XWayland) the test succeeds).
Some of the “cancelled” builds are cancelled due to it timing-out, e.g. and ; the reason there may be unrelated, though. Indeed most appear to be non-timeout cancellations.
run locally here the things the tests wants to happen did always happen, but OCR was incredibly flaky and either did not detect them at the first try, or not at all. this is especially bad for pinentry because it closes after 10 seconds for reasons we have not dug into. it looks like this is squarely a failure of OCR (and the way it's used here does seem at least somewhat suspect, maybe using other tooling to list windows would be more appropriate? would almost certainly not take three minutes per attempt to find a window)
Ah, right, thanks for the examples :) Indeed, that seems to be to the gnome3-pinentry timeout that I wasn't aware of (so that part would be fixable). Weird, that shouldn't happen. OCR is slow but should be reliable. Not sure if this could be setup dependant. On Hydra it doesn't seem to be an issue. That is indeed bad. Luckily already found a solution for the timeout in . I intentionally chose OCR to ensure that the (font) rendering works but it isn't required for ensuring that the windows are there. The slowness of OCR is certainly a drawback though.

Related discussion:
text: regular2 = foreground; }; }; <ins> etc."gpg-agent.conf".text = '' pinentry-timeout 86400 ''; </ins> }; fonts.fonts = [ pkgs.inconsolata ];
Code change:
Project description pyenv lets you easily switch between multiple versions of Python. It's simple, unobtrusive, and follows the UNIX tradition of single-purpose tools that do one thing well. It is a critical application for Python development. Metadata homepage URL: source URL: license: MIT platforms: ALL

Related discussion:
text: <ins> { lib , stdenv , fetchFromGitHub , installShellFiles }: stdenv.mkDerivation rec { pname = "pyenv"; version = "2.3.21"; src = fetchFromGitHub { owner = "pyenv"; repo = "pyenv"; rev = "refs/tags/v${version}"; hash = "sha256-+rMkbrRSQBHX9qdifIpdLmQ8Uk39ott0xyJTD/mb+9w="; }; postPatch = '' patchShebangs --build src/configure ''; nativeBuildInputs = [ installShellFiles ]; configureScript = "src/configure"; makeFlags = ["-C" "src"]; installPhase = '' runHook preInstall mkdir -p "$out" cp -R bin "$out/bin" cp -R libexec "$out/libexec" cp -R plugins "$out/plugins" runHook postInstall ''; postInstall = '' installManPage man/man1/pyenv.1 installShellCompletion completions/pyenv.{bash,fish,zsh} ''; meta = with lib; { description = "Simple Python version management"; homepage = "https://github.com/pyenv/pyenv"; changelog = "https://github.com/pyenv/pyenv/blob/${src.rev}/CHANGELOG.md"; license = licenses.mit; maintainers = with maintainers; [ tjni ]; platforms = platforms.all; }; } </ins>
Code change:
Project description pyenv lets you easily switch between multiple versions of Python. It's simple, unobtrusive, and follows the UNIX tradition of single-purpose tools that do one thing well. It is a critical application for Python development. Metadata homepage URL: source URL: license: MIT platforms: ALL

Related discussion:
text: psrecord = python3Packages.callPackage ../tools/misc/psrecord { }; <ins> pyenv = callPackage ../development/tools/pyenv { }; </ins> r53-ddns = callPackage ../applications/networking/r53-ddns { }; rare = python3Packages.callPackage ../games/rare { };
Code change:
Spideroak GUI does not work in NixOS unstable. When running , I get this error: As far as I am able to tell, headless mode runs fine. Install spideroak and try to run . System: 17.09pre102667. (Hummingbird) Nix version: nix-env (Nix) 1.11.7 Nixpkgs version: "17.09pre102667."
Python uses the default zlib which is currently 1.2.11. I see the following options: override Python expression and use an older version of zlib let spideroak use our version of libpng. cc
Well the package's approach is strange to me. It installs private versions of libs that depend on libs not installed (e.g. freetype), and at the same time, some of the missing libs naturally depend on libs that are also installed privately (on zlib, for example). You can try such tweaks to find what will work now, but I'm afraid it's likely to remain fragile.

Related discussion:
text: { stdenv, fetchurl, makeWrapper, glib , fontconfig, patchelf, libXext, libX11 <del> , freetype, libXrender </del> <ins> , freetype, libXrender, zlib </ins> }: let
Code change:
Spideroak GUI does not work in NixOS unstable. When running , I get this error: As far as I am able to tell, headless mode runs fine. Install spideroak and try to run . System: 17.09pre102667. (Hummingbird) Nix version: nix-env (Nix) 1.11.7 Nixpkgs version: "17.09pre102667."
Python uses the default zlib which is currently 1.2.11. I see the following options: override Python expression and use an older version of zlib let spideroak use our version of libpng. cc
Well the package's approach is strange to me. It installs private versions of libs that depend on libs not installed (e.g. freetype), and at the same time, some of the missing libs naturally depend on libs that are also installed privately (on zlib, for example). You can try such tweaks to find what will work now, but I'm afraid it's likely to remain fragile.

Related discussion:
text: else throw "Spideroak client for: ${stdenv.system} not supported!"; ldpath = stdenv.lib.makeLibraryPath [ <del> glib fontconfig libXext libX11 freetype libXrender </del> <ins> glib fontconfig libXext libX11 freetype libXrender zlib </ins> ]; version = "6.0.1";
Code change:
Spideroak GUI does not work in NixOS unstable. When running , I get this error: As far as I am able to tell, headless mode runs fine. Install spideroak and try to run . System: 17.09pre102667. (Hummingbird) Nix version: nix-env (Nix) 1.11.7 Nixpkgs version: "17.09pre102667."
Python uses the default zlib which is currently 1.2.11. I see the following options: override Python expression and use an older version of zlib let spideroak use our version of libpng. cc
Well the package's approach is strange to me. It installs private versions of libs that depend on libs not installed (e.g. freetype), and at the same time, some of the missing libs naturally depend on libs that are also installed privately (on zlib, for example). You can try such tweaks to find what will work now, but I'm afraid it's likely to remain fragile.

Related discussion:
text: rmdir $out/usr/bin || true mv $out/usr/share $out/ <ins> rm -f $out/opt/SpiderOakONE/lib/libz* </ins> patchelf --set-interpreter ${stdenv.glibc.out}/lib/${interpreter}  "$out/opt/SpiderOakONE/lib/SpiderOakONE"
Code change:
Project description A fork of Golden Dictionary which fixes many old bugs, provides improvement, and is being actively developed. It might be better to switch to altogether instead of continuing to maintain . Metadata homepage URL: source URL: license: gplv3 platforms: linux
doesn't seem too inactive now: they even had a new release last month (based on Qt WebKit, though).
I think it might be a good idea to have both versions as provides extra features and bug fixes if that's possible.

Related discussion:
text: githubId = 3789764; name = "skykanin"; }; <ins> slbtty = { email = "shenlebantongying@gmail.com"; github = "shenlebantongying"; githubId = 20123683; name = "Shenleban Tongying"; }; </ins> sleexyz = { email = "freshdried@gmail.com"; github = "sleexyz";
Code change:
Project description A fork of Golden Dictionary which fixes many old bugs, provides improvement, and is being actively developed. It might be better to switch to altogether instead of continuing to maintain . Metadata homepage URL: source URL: license: gplv3 platforms: linux
doesn't seem too inactive now: they even had a new release last month (based on Qt WebKit, though).
I think it might be a good idea to have both versions as provides extra features and bug fixes if that's possible.

Related discussion:
text: <ins> { stdenv , lib , fetchFromGitHub , pkg-config , cmake , libvorbis , ffmpeg , libeb , hunspell , opencc , xapian , libzim , lzo , xz , tomlplusplus , fmt , bzip2 , libiconv , libXtst , qtbase , qtsvg , qtwebengine , qttools , qtwayland , qt5compat , qtmultimedia , qtspeech , wrapQtAppsHook }: stdenv.mkDerivation (finalAttrs: { pname = "goldendict-ng"; version = "23.07.23"; src = fetchFromGitHub { owner = "xiaoyifang"; repo = "goldendict-ng"; rev = "v${finalAttrs.version}"; hash = "sha256-ZKbrO5L4KFmr2NsGDihRWBeW0OXHoPRwZGj6kt1Anc8="; }; nativeBuildInputs = [ pkg-config cmake wrapQtAppsHook ]; buildInputs = [ qtbase qtsvg qttools qtwebengine qt5compat qtmultimedia qtspeech libvorbis tomlplusplus fmt hunspell xz lzo libXtst bzip2 libiconv opencc libeb ffmpeg xapian libzim ]; cmakeFlags = [ "-DWITH_XAPIAN=ON" "-DWITH_ZIM=ON" "-DWITH_FFMPEG_PLAYER=ON" "-DWITH_EPWING_SUPPORT=ON" "-DUSE_SYSTEM_FMT=ON" "-DUSE_SYSTEM_TOML=ON" ]; meta = with lib; { homepage = "https://xiaoyifang.github.io/goldendict-ng/"; description = "Advanced multi-dictionary lookup program."; platforms = platforms.linux; maintainers = with maintainers; [ slbtty ]; license = licenses.gpl3Plus; }; }) </ins>
Code change:
Project description A fork of Golden Dictionary which fixes many old bugs, provides improvement, and is being actively developed. It might be better to switch to altogether instead of continuing to maintain . Metadata homepage URL: source URL: license: gplv3 platforms: linux
doesn't seem too inactive now: they even had a new release last month (based on Qt WebKit, though).
I think it might be a good idea to have both versions as provides extra features and bug fixes if that's possible.

Related discussion:
text: }; goldendict = libsForQt5.callPackage ../applications/misc/goldendict { }; <ins> goldendict-ng = qt6Packages.callPackage ../applications/misc/goldendict-ng { }; </ins> gomuks = callPackage ../applications/networking/instant-messengers/gomuks { };
Code change:
reaper can't export video (wrong ffmpeg version) in nixos 23.05 Steps to reproduce the behavior: the package reaper -Render : "Video (ffmpeg/libav encoder)" is missing There should be an option in the list where you can use ffmpeg as encoder If you override the ffmpeg dependency with: (reaper.override { ffmpeg = pkgs.ffmpeg_4-full; }) then it works.

Related discussion:
text: reaper = callPackage ../applications/audio/reaper { jackLibrary = libjack2; # Another option is "pipewire.jack". <ins> ffmpeg = ffmpeg_4-headless; </ins> }; recapp = callPackage ../applications/video/recapp { };
Code change:
Package name: ultrastardx Latest released version: Current version on the unstable channel: 2021-04-03 Current version on the stable/release channel: 2021-04-03 Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.

Related discussion:
text: in stdenv.mkDerivation rec { pname = "ultrastardx"; <del> version = "2021-04-03"; </del> <ins> version = "2023.9.0"; </ins> src = fetchFromGitHub { owner = "UltraStar-Deluxe"; repo = "USDX"; <del> rev = "d49e916705092f3d765d85d276b283b9e7e232a6"; sha256 = "0sdcz2vc8i2z50nj7zbkdpxx2mvx0m0927lfsj7d7qr0p8vkm0wa"; </del> <ins> rev = "v${version}"; hash = "sha256-KvYfWdpgN72F8Y5iFNba0SCjPoS33O3FAdrrC49xoGo="; </ins> }; nativeBuildInputs = [ pkg-config autoreconfHook ];
Code change:
Package name: ultrastardx Latest released version: Current version on the unstable channel: 2021-04-03 Current version on the stable/release channel: 2021-04-03 Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.

Related discussion:
text: dontPatchELF = true; meta = with lib; { <del> homepage = "http://ultrastardx.sourceforge.net/"; </del> <ins> homepage = "https://usdx.eu/"; </ins> description = "Free and open source karaoke game"; license = licenses.gpl2Plus; maintainers = with maintainers; [ Profpatsch ];
Code change:
Package name: MuseScore Latest released version: 4.1 Current version on the unstable channel: 4.0.2 Current version on the stable/release channel: 4.0.2 Notify maintainers Note for maintainers: Please tag this issue in your PR.
Thanks for the notification! Your review is welcome at .

Related discussion:
text: <del> { stdenv, lib, fetchurl, undmg }: let versionComponents = [ "4" "0" "1" ]; appName = "MuseScore ${builtins.head versionComponents}"; ref = "230121751"; in stdenv.mkDerivation rec { pname = "musescore-darwin"; version = lib.concatStringsSep "." versionComponents; # The disk image contains the .app and a symlink to /Applications. sourceRoot = "${appName}.app"; src = fetchurl { url =  "https://github.com/musescore/MuseScore/releases/download/v${version}/MuseScore-${version}.${ref}.dmg"; hash = "sha256-tkIEV+tCS0SYh2TlC70/zEBUEOSg//EaSKDGA7kH/vo="; }; buildInputs = [ undmg ]; installPhase = '' mkdir -p "$out/Applications/${appName}.app" cp -R . "$out/Applications/${appName}.app" chmod a+x "$out/Applications/${appName}.app/Contents/MacOS/mscore" ''; meta = with lib; { description = "Music notation and composition software"; homepage = "https://musescore.org/"; license = licenses.gpl3Only; platforms = platforms.darwin; maintainers = []; }; } </del>
Code change:
Package name: MuseScore Latest released version: 4.1 Current version on the unstable channel: 4.0.2 Current version on the stable/release channel: 4.0.2 Notify maintainers Note for maintainers: Please tag this issue in your PR.
Thanks for the notification! Your review is welcome at .

Related discussion:
text: homepage = "https://musescore.org/"; license = licenses.gpl3Only; maintainers = with maintainers; [ vandenoever turion doronbehar ]; <del> # Darwin requires CoreMIDI from SDK 11.3, we use the upstream built .dmg # file in ./darwin.nix in the meantime. platforms = platforms.linux; </del> <ins> # on aarch64-linux: # error: cannot convert '<brace-enclosed initializer list>' to 'float32x4_t' in assignment broken = (stdenv.isLinux && stdenv.isAarch64); </ins> mainProgram = "mscore"; }; }
Code change:
Package name: MuseScore Latest released version: 4.1 Current version on the unstable channel: 4.0.2 Current version on the stable/release channel: 4.0.2 Notify maintainers Note for maintainers: Please tag this issue in your PR.
Thanks for the notification! Your review is welcome at .

Related discussion:
text: autoreconfHook = buildPackages.autoreconfHook269; }; <del> # TODO: we should probably merge these 2 musescore = if stdenv.isDarwin then callPackage ../applications/audio/musescore/darwin.nix { } else libsForQt5.callPackage ../applications/audio/musescore { }; </del> <ins> musescore = libsForQt5.callPackage ../applications/audio/musescore { }; </ins> music-player = callPackage ../applications/audio/music-player { };
Code change:
Project description Language Server for Perl Metadata homepage URL: source URL: license: artisticlicense2_0 platforms: unix, linux, darwin, ...

Related discussion:
text: }; }; <ins> ClassRefresh = buildPerlPackage { pname = "Class-Refresh"; version = "0.07"; src = fetchurl { url = "mirror://cpan/authors/id/D/DO/DOY/Class-Refresh-0.07.tar.gz"; hash = "sha256-47ADU1XLs1oq7j8iNojVeJRqenxXCs05iyjN2x/UvrM="; }; buildInputs = [ TestFatal TestRequires ]; propagatedBuildInputs = [ ClassLoad ClassUnload DevelOverrideGlobalRequire TryTiny ]; meta = { homepage = "http://metacpan.org/release/Class-Refresh"; description = "Refresh your classes during runtime"; license = with lib.licenses; [ artistic1 gpl1Plus ]; }; }; </ins> ClassReturnValue = buildPerlPackage { pname = "Class-ReturnValue"; version = "0.55";
Code change:
Project description Language Server for Perl Metadata homepage URL: source URL: license: artisticlicense2_0 platforms: unix, linux, darwin, ...

Related discussion:
text: }; }; <ins> PerlLanguageServer = buildPerlPackage { pname = "Perl-LanguageServer"; version = "2.5.0"; src = fetchurl { url = "mirror://cpan/authors/id/G/GR/GRICHTER/Perl-LanguageServer-2.5.0.tar.gz"; hash = "sha256-LQYcIkepqAT1JMkSuIN6mxivz6AZkpShcRsVD1oTmQQ="; }; propagatedBuildInputs = [ AnyEvent AnyEventAIO ClassRefresh CompilerLexer Coro DataDump HashSafeKeys IOAIO JSON Moose PadWalker ]; meta = { description = "Language Server and Debug Protocol Adapter for Perl"; license = lib.licenses.artistic2; }; }; </ins> perlldap = buildPerlPackage { pname = "perl-ldap"; version = "0.68";