jiebi/CodeConvo huggingface dataset:
Code change:
NixOS on boot loops waiting for devices with wrong names. According to device paths are split by ":", but for some persistent block device names we have ":" in valid paths. The boot is stuck trying to load: Steps to reproduce the behavior: NixOS using /dev/disk/by-path devices boot waiting loop Boot without waiting for nonexistant devices ! Please run and paste the result.
This is a recent phenomenon I've experienced a few times, on bcachefs. I'm not entirely sure why this happens, but since Linux 6.4.8 I believe, I haven't had this issue. There are two reasons why this could happen AFAIK: is messed up between the linux kernel and stage-1. needs to have all the devices loaded before trying to mount multiple. That's the best I have ATM. Current nix-info for reference: system: host os: multi-user?: sandbox: version: channels(mado): channels(root): nixpkgs:
I should also clarify in my case that it was a breaking bug, where I would have to reboot because one of the devices never loaded and would drop me into an error, until it worked.
it seems like you're describing a different issue with bcachefs and multiple devices separated by . This bug, as far as I understand, is about non-bcachefs block device paths that contain incidentally (not as a multi-device delimiter). I'd suggest filing a separate issue for your problem.
(But as the author of the change that introduced that behavior - - I suspect you might want to be involved here regardless :P)
My bad, the usual bad reading comprehension and I didn't look at the paths that were listed closely enough. I would suggest, if possible, using something like instead until this is fixed. As for the fix, while it would break the use-case of colon-separated if it is the aforementioned path.
This should be considered a bug. There are a lot of paths in that have colons in their name (including RAID UUID devices). Requiring users to know that devices with colons in their name are treated special is unreasonable, especially if it's not documented. If bcachefs requires this then I think we need a new configuration option or the stage 1 function needs to be extended so it considers the file system type before setting .
IMO, we should get rid of it for bcachefs (it's only use) and just use the new ` mechanism.
I don't use bcachefs so I don't know what the mechanism is. Is it safe to simply revert your patch to ?
Unfortunately no, because many people's auto-generated configs still use the ':' separator. It's something I think we'll have to do at some point though. I think the better option may be to omit a warning if it's being used (i.e: using bcachefs) until 24.05, backport that to 23.11, and remove it in 24.05.
I would suggest that we change the function to take an optional second argument, the file system type. If that argument is set and it is set to "" then (and only then) do we set . Of course, this only works if the auto-generated configs correctly set the file system type. Can you point me to the commit where you changed the auto-generation process?
Should be fixed in

Related discussion:
text: , rustPlatform , makeWrapper , writeScript <ins> , python3 </ins> , fuseSupport ? false }:
Code change:
Project description zcfan is a Zero-configuration fan control daemon for ThinkPads. Metadata homepage URL: source URL: license: mit platforms: linux

Related discussion:
text: <ins> { lib , stdenv , fetchFromGitHub }: # Testing this requires a Thinkpad or the presence of /proc/acpi/ibm/fan stdenv.mkDerivation (finalAttrs: { pname = "zcfan"; version = "1.2.1"; src = fetchFromGitHub { owner = "cdown"; repo = "zcfan"; rev = finalAttrs.version; hash = "sha256-XngchR06HP2iExKJVe+XKBDgsv98AEYWOkl1a/Hktgs="; }; postPatch = '' substituteInPlace Makefile  --replace "/usr/local" $out ''; doInstallCheck = true; installCheckPhase = '' runHook preInstallCheck $out/bin/${finalAttrs.pname} -h runHook postInstallCheck ''; meta = with lib; { description = "A zero-configuration fan daemon for ThinkPads"; homepage = "https://github.com/cdown/zcfan"; changelog = "https://github.com/cdown/zcfan/tags/${finalAttrs.version}"; license = licenses.mit; maintainers = with maintainers; [ kashw2 ]; platforms = platforms.linux; }; }) </ins>
Code change:
Project description Streaming media player for Plex Metadata homepage URL: source URL: license: proprietary platforms: linux Unfortunately, this app is only available as a Snap or a Flatpak. It looks like Snap is easier to unpack, as we have . There is also , which appears to be unmaintened.
would also appreciate this being packaged, the flatpak version does not start for me ( I don't like using flatpak anyways).
It also supports Darwin and Windows.
Just to be clear this is not this package This is a completely different package with different build steps that just looks the exact same.
Submitted a draft PR that adds this to nixpkgs. What's there now works on my machine&trade; (3 of them). I'd appreciate people testing this out on different hardware and suggesting any improvements that makes this more reliable. I have a couple more things I'd like to do before officially submitting this. Edit: Also need help with Darwin. I'm guessing it doesn't work there and I don't have a convenient way to test that platform.

Related discussion:
text: github = "Detegr"; githubId = 724433; }; <ins> detroyejr = { name = "Jonathan De Troye"; email = "detroyejr@outlook.com"; github = "detroyejr"; githubId = 12815411; }; </ins> Dettorer = { name = "Paul Hervot"; email = "paul.hervot@dettorer.net";
Code change:
Project description onedriver is a native Linux filesystem for Microsoft OneDrive. It contains GUI and CLI tools for mounting Onedrive cloud shares as local drives, downloading files accessed on demand. Metadata homepage URL: source URL: license: gpl3 platforms: linux
I am very excited about this one, I am actually a DM in a D&D campaign and onedriver has always been my best tool for rapid storage and edit of the stuff. Thanks everyone!

Related discussion:
text: githubId = 29855073; name = "Michael Colicchia"; }; <ins> massimogengarelli = { email = "massimo.gengarelli@gmail.com"; github = "massix"; githubId = 585424; name = "Massimo Gengarelli"; }; </ins> matejc = { email = "cotman.matej@gmail.com"; github = "matejc";
Code change:
Project description onedriver is a native Linux filesystem for Microsoft OneDrive. It contains GUI and CLI tools for mounting Onedrive cloud shares as local drives, downloading files accessed on demand. Metadata homepage URL: source URL: license: gpl3 platforms: linux
I am very excited about this one, I am actually a DM in a D&D campaign and onedriver has always been my best tool for rapid storage and edit of the stuff. Thanks everyone!

Related discussion:
text: <ins> { buildGoModule , fetchFromGitHub , lib , pkg-config , webkitgtk , glib , fuse , installShellFiles }: let pname = "onedriver"; version = "0.13.0-2"; src = fetchFromGitHub { owner = "jstaf"; repo = "onedriver"; rev = "v${version}"; hash = "sha256-Bcjgmx9a4pTRhkzR3tbOB6InjvuH71qomv4t+nRNc+w="; }; in buildGoModule { inherit pname version src; vendorHash = "sha256-OOiiKtKb+BiFkoSBUQQfqm4dMfDW3Is+30Kwcdg8LNA="; nativeBuildInputs = [ pkg-config installShellFiles ]; buildInputs = [ webkitgtk glib fuse ]; ldflags = [ "-X github.com/jstaf/onedriver/cmd/common.commit=v${version}" ]; subPackages = [ "cmd/onedriver" "cmd/onedriver-launcher" ]; postInstall = '' echo "Running postInstall" install -Dm644 ./resources/onedriver.svg $out/share/icons/onedriver/onedriver.svg install -Dm644 ./resources/onedriver.png $out/share/icons/onedriver/onedriver.png install -Dm644 ./resources/onedriver-128.png $out/share/icons/onedriver/onedriver-128.png install -Dm644 ./resources/onedriver.desktop $out/share/applications/onedriver.desktop mkdir -p $out/share/man/man1 installManPage ./resources/onedriver.1 substituteInPlace $out/share/applications/onedriver.desktop  --replace "/usr/bin/onedriver-launcher" "$out/bin/onedriver-launcher"  --replace "/usr/share/icons" "$out/share/icons" ''; meta = with lib; { description = "A network filesystem for Linux"; longDescription = '' onedriver is a network filesystem that gives your computer direct access to your files on Microsoft OneDrive. This is not a sync client. Instead of syncing files, onedriver performs an on-demand download of files when your computer attempts to use them. onedriver allows you to use files on OneDrive as if they were files on your local computer. ''; inherit (src.meta) homepage; license = licenses.gpl3Plus; maintainers = [ maintainers.massimogengarelli ]; platforms = platforms.linux; }; } </ins>
Code change:
Steps to reproduce the behavior: itch system: host os: multi-user?: sandbox: version: channels(root): channels(username): nixpkgs:
Looks like there is an issue already posted for this package NixOS/nixpkgs and there was a PR (NixOS/nixpkgs which uses a canary build instead) posted. Since there is no stable update (the canary builds uses a separate config directory, which is also explained here ) this is still a upstream issue.

Related discussion:
text: , fetchzip , fetchFromGitHub , butler <del> , electron_11 </del> <ins> , electron </ins> , steam-run , makeWrapper , copyDesktopItems
Code change:
Steps to reproduce the behavior: itch system: host os: multi-user?: sandbox: version: channels(root): channels(username): nixpkgs:
Looks like there is an issue already posted for this package NixOS/nixpkgs and there was a PR (NixOS/nixpkgs which uses a canary build instead) posted. Since there is no stable update (the canary builds uses a separate config directory, which is also explained here ) this is still a upstream issue.

Related discussion:
text: }: stdenvNoCC.mkDerivation rec { pname = "itch"; <del> version = "25.6.2"; </del> <ins> version = "26.1.2"; # TODO: Using kitch instead of itch, revert when possible </ins> src = fetchzip { <del> url = "https://broth.itch.ovh/${pname}/linux-amd64/${version}/itch.zip"; </del> <ins> url = "https://broth.itch.ovh/k${pname}/linux-amd64/${version}/archive/default#.zip"; </ins> stripRoot = false; <del> sha256 = "sha256-F/vaYBHCygseiKNMJ+jBy31YDIFqYToAETGUl/pkHII="; </del> <ins> sha256 = "sha256-thXe+glpltSiKNGIRgvOZQZPJWfDHWo3dLdziyp2BM4="; </ins> }; itch-setup = fetchzip {
Code change:
Steps to reproduce the behavior: itch system: host os: multi-user?: sandbox: version: channels(root): channels(username): nixpkgs:
Looks like there is an issue already posted for this package NixOS/nixpkgs and there was a PR (NixOS/nixpkgs which uses a canary build instead) posted. Since there is no stable update (the canary builds uses a separate config directory, which is also explained here ) this is still a upstream issue.

Related discussion:
text: fetchFromGitHub { owner = "itchio"; repo = pname; <del> rev = "v25.6.1-canary"; # Use ${version} if possible hash = "sha256-iBp7K7AW97SOlRa8N8TW2LcVtmUi9JU00fYUuPwKORc="; </del> <ins> rev = "v${version}-canary"; sha256 = "sha256-veZiKs9qHge+gCEpJ119bAT56ssXJAH3HBcYkEHqBFg="; </ins> sparseCheckout = [ sparseCheckout ]; } + sparseCheckout;
Code change:
Steps to reproduce the behavior: itch system: host os: multi-user?: sandbox: version: channels(root): channels(username): nixpkgs:
Looks like there is an issue already posted for this package NixOS/nixpkgs and there was a PR (NixOS/nixpkgs which uses a canary build instead) posted. Since there is no stable update (the canary builds uses a separate config directory, which is also explained here ) this is still a upstream issue.

Related discussion:
text: installPhase = '' runHook preInstall <ins> # TODO: Remove when the next stable Itch is stabilized substituteInPlace ./resources/app/package.json  --replace "kitch" "itch" </ins> mkdir -p $out/bin $out/share/${pname}/resources/app cp -r resources/app "$out/share/${pname}/resources/"
Code change:
Steps to reproduce the behavior: itch system: host os: multi-user?: sandbox: version: channels(root): channels(username): nixpkgs:
Looks like there is an issue already posted for this package NixOS/nixpkgs and there was a PR (NixOS/nixpkgs which uses a canary build instead) posted. Since there is no stable update (the canary builds uses a separate config directory, which is also explained here ) this is still a upstream issue.

Related discussion:
text: postFixup = '' makeWrapper ${steam-run}/bin/steam-run $out/bin/${pname}  <del> --add-flags ${electron_11}/bin/electron  </del> <ins> --add-flags ${electron}/bin/electron  </ins> --add-flags $out/share/${pname}/resources/app  --set BROTH_USE_LOCAL butler,itch-setup  --prefix PATH : ${butler}/bin/:${itch-setup}
Code change:
After a recent Nixpkgs git update, my Firefox browser can no longer download files to the local disk. At the point where the file browser is supposed to pop up to let me choose the directory in which to save the file, the entire browser just crashes. The console doesn't say much: This issue occurs in and earlier. I'll try to find a commit that causes the issue by way of git bisect, but that's no not easy to pull off (for obvious reasons).
There are and ; there are and . Adding some combination of these to could help. I guess the wrapper needs updating…
~This one should be just IIRC.~ I was wrong.
I don't understand why it doesn't crash on 17.03.
The fix worked! Thank you very much.

Related discussion:
text: <ins> {stdenv, fetchurl, yacc, flex, pkgconfig, glib, xz}: stdenv.mkDerivation rec { version = "0.15.2"; name = "vala-${version}"; src = fetchurl { url = "mirror://gnome/sources/vala/0.15/${name}.tar.xz"; sha256 = "0g71zq6dpqrw2f40wfzdf18fdw41ymr17laqniy2kr622hkxdi8w"; }; buildNativeInputs = [ yacc flex pkgconfig xz ]; buildInputs = [ glib ]; meta = { description = "Compiler for the GObject type system"; homepage = "http://live.gnome.org/Vala"; license = "free-copyleft"; platforms = stdenv.lib.platforms.all; maintainers = [ stdenv.lib.maintainers.antono ]; }; } </ins>
Code change:
After a recent Nixpkgs git update, my Firefox browser can no longer download files to the local disk. At the point where the file browser is supposed to pop up to let me choose the directory in which to save the file, the entire browser just crashes. The console doesn't say much: This issue occurs in and earlier. I'll try to find a commit that causes the issue by way of git bisect, but that's no not easy to pull off (for obvious reasons).
There are and ; there are and . Adding some combination of these to could help. I guess the wrapper needs updating…
~This one should be just IIRC.~ I was wrong.
I don't understand why it doesn't crash on 17.03.
The fix worked! Thank you very much.

Related discussion:
text: <ins> {stdenv, fetchurl, yacc, flex, pkgconfig, glib, xz}: stdenv.mkDerivation rec { version = "0.16.1"; name = "vala-${version}"; src = fetchurl { url = "mirror://gnome/sources/vala/0.16/${name}.tar.xz"; sha256 = "1n708n9ixyy9qrzyv1wf4ybvcclx43ib9ki028wwpvkz6kv8zqlb"; }; buildNativeInputs = [ yacc flex pkgconfig xz ]; buildInputs = [ glib ]; meta = { description = "Compiler for the GObject type system"; homepage = "http://live.gnome.org/Vala"; license = "free-copyleft"; platforms = stdenv.lib.platforms.all; maintainers = [ stdenv.lib.maintainers.antono ]; }; } </ins>
Code change:
After a recent Nixpkgs git update, my Firefox browser can no longer download files to the local disk. At the point where the file browser is supposed to pop up to let me choose the directory in which to save the file, the entire browser just crashes. The console doesn't say much: This issue occurs in and earlier. I'll try to find a commit that causes the issue by way of git bisect, but that's no not easy to pull off (for obvious reasons).
There are and ; there are and . Adding some combination of these to could help. I guess the wrapper needs updating…
~This one should be just IIRC.~ I was wrong.
I don't understand why it doesn't crash on 17.03.
The fix worked! Thank you very much.

Related discussion:
text: {stdenv, fetchurl, yacc, flex, pkgconfig, glib, xz}: stdenv.mkDerivation rec { <del> name = "vala-0.14.2"; </del> <ins> version = "0.17.2"; name = "vala-${version}"; </ins> src = fetchurl { <del> url = mirror://gnome/sources/vala/0.14/vala-0.14.2.tar.xz; sha256 = "1l5kllw9vpwv24lzv9fp64l3sad46wpxgvsgryrwlrjg91w6jzl0"; </del> <ins> url = "mirror://gnome/sources/vala/0.17/${name}.tar.xz"; sha256 = "09i2s0dwmrk147ind2dx7nq845g12fp6fsjqrphhrr0dbi0zzgh3"; </ins> }; buildNativeInputs = [ yacc flex pkgconfig xz ];
Code change:
After a recent Nixpkgs git update, my Firefox browser can no longer download files to the local disk. At the point where the file browser is supposed to pop up to let me choose the directory in which to save the file, the entire browser just crashes. The console doesn't say much: This issue occurs in and earlier. I'll try to find a commit that causes the issue by way of git bisect, but that's no not easy to pull off (for obvious reasons).
There are and ; there are and . Adding some combination of these to could help. I guess the wrapper needs updating…
~This one should be just IIRC.~ I was wrong.
I don't understand why it doesn't crash on 17.03.
The fix worked! Thank you very much.

Related discussion:
text: meta = { description = "Compiler for the GObject type system"; homepage = "http://live.gnome.org/Vala"; <ins> license = "free-copyleft"; platforms = stdenv.lib.platforms.all; maintainers = [ stdenv.lib.maintainers.antono ]; </ins> }; }
Code change:
After a recent Nixpkgs git update, my Firefox browser can no longer download files to the local disk. At the point where the file browser is supposed to pop up to let me choose the directory in which to save the file, the entire browser just crashes. The console doesn't say much: This issue occurs in and earlier. I'll try to find a commit that causes the issue by way of git bisect, but that's no not easy to pull off (for obvious reasons).
There are and ; there are and . Adding some combination of these to could help. I guess the wrapper needs updating…
~This one should be just IIRC.~ I was wrong.
I don't understand why it doesn't crash on 17.03.
The fix worked! Thank you very much.

Related discussion:
text: urweb = callPackage ../development/compilers/urweb { }; <del> vala = callPackage ../development/compilers/vala { }; </del> <ins> vala = vala17; vala15 = callPackage ../development/compilers/vala/15.2.nix { }; vala16 = callPackage ../development/compilers/vala/16.1.nix { }; vala17 = callPackage ../development/compilers/vala/default.nix { }; </ins> visualcpp = callPackage ../development/compilers/visual-c++ { };
Code change:
Steps to reproduce the behavior: that build exited with success code, but directory is empty. Removing the following fixes the issue for me. Disclaimer: I'm not familiar with golang so I'm not sure what this does or why it was in the first place. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
thank you for your bugreport, we need cgo because a dependency needs cgo

Related discussion:
text: buildGoModule rec { pname = "katana"; <del> version = "1.0.3"; </del> <ins> version = "1.0.4"; </ins> src = fetchFromGitHub { owner = "projectdiscovery"; repo = pname; rev = "refs/tags/v${version}"; <del> hash = "sha256-0OXpA+sa97YjbHhIq3Uj65OWg53PH9y2cY8bjCqC3tQ="; </del> <ins> hash = "sha256-wpGRpgRJtywkTJ3YBk5TzXc2taPPWjOhj+Kg8hAgm7M="; </ins> }; <del> vendorHash = "sha256-rb0fNAOP4y2yvJb7FIlAIfXF0uw0eLKgup75f9cwT6U="; CGO_ENABLED = 0; </del> <ins> vendorHash = "sha256-qqivaKipe7lfUq3Neod8JMvtMVQN4O03JpDMSMHf8YY="; </ins> subPackages = [ "cmd/katana" ];
Code change:
A clear and concise description of what the bug is. Steps to reproduce the behavior: Try to configure to work on all keyboards. Note that, although this is a common use case, trying to do so with the exposed API leads to errors. For instance: This code throws the following It's expected to have some way of declaratively configuring kanata, such that a given configuration block works for all keyboards. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
Does setting work for you?
Yes, that seems to work! Thank you :)

Related discussion:
text: options = { devices = mkOption { type = types.listOf types.str; <ins> default = [ ]; </ins> example = [ "/dev/input/by-id/usb-0000_0000-event-kbd" ]; <del> description = mdDoc "Paths to keyboard devices."; </del> <ins> description = mdDoc '' Paths to keyboard devices. An empty list, the default value, lets kanata detect which input devices are keyboards and intercept them all. ''; </ins> }; config = mkOption { type = types.lines;
Code change:
A clear and concise description of what the bug is. Steps to reproduce the behavior: Try to configure to work on all keyboards. Note that, although this is a common use case, trying to do so with the exposed API leads to errors. For instance: This code throws the following It's expected to have some way of declaratively configuring kanata, such that a given configuration block works for all keyboards. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
Does setting work for you?
Yes, that seems to work! Thank you :)

Related discussion:
text: }; config = mkIf cfg.enable { <ins> warnings = let keyboardsWithEmptyDevices = filterAttrs (name: keyboard: keyboard.devices == [ ]) cfg.keyboards; existEmptyDevices = length (attrNames keyboardsWithEmptyDevices) > 0; moreThanOneKeyboard = length (attrNames cfg.keyboards) > 1; in optional (existEmptyDevices && moreThanOneKeyboard) "One device can only be intercepted by one kanata instance.  Setting services.kanata.keyboards.${head (attrNames keyboardsWithEmptyDevices)}.devices = [ ] and using more than one services.kanata.keyboards may cause a race condition."; </ins> hardware.uinput.enable = true; systemd.services = mapAttrs' mkService cfg.keyboards;
Code change:
Project description Floorp is a firefox fork. Metadata homepage URL: source URL: license: MPLv2.0 platforms: windows, macos, linux

Related discussion:
text: firewall-nftables = handleTest ./firewall.nix { nftables = true; }; fish = handleTest ./fish.nix {}; flannel = handleTestOn ["x86_64-linux"] ./flannel.nix {}; <ins> floorp = handleTest ./firefox.nix { firefoxPackage = pkgs.floorp; }; </ins> fluentd = handleTest ./fluentd.nix {}; fluidd = handleTest ./fluidd.nix {}; fontconfig-default-fonts = handleTest ./fontconfig-default-fonts.nix {};
Code change:
Project description Floorp is a firefox fork. Metadata homepage URL: source URL: license: MPLv2.0 platforms: windows, macos, linux

Related discussion:
text: <ins> { stdenv , lib , fetchFromGitHub , buildMozillaMach , nixosTests }: ((buildMozillaMach rec { pname = "floorp"; packageVersion = "11.5.0"; applicationName = "Floorp"; binaryName = "floorp"; version = "155.4.0"; src = fetchFromGitHub { owner = "Floorp-Projects"; repo = "Floorp"; fetchSubmodules = true; rev = "v${packageVersion}"; hash = "sha256-adK3LAu3cDh6d+GvtnkWmSnxansnSZoIgtA9TAqIMyA="; }; extraConfigureFlags = [ "--with-app-name=${pname}" "--with-app-basename=${applicationName}" "--with-branding=browser/branding/official" "--with-distribution-id=app.floorp.Floorp" "--with-unsigned-addon-scopes=app,system" "--allow-addon-sideload" ]; meta = { description = "A fork of Firefox, focused on keeping the Open, Private and Sustainable Web alive, built in Japan"; homepage = "https://floorp.app/"; maintainers = with lib.maintainers; [ christoph-heiss ]; platforms = lib.platforms.unix; badPlatforms = lib.platforms.darwin; broken = stdenv.buildPlatform.is32bit; # since Firefox 60, build on 32-bit platforms fails with "out of memory". # not in `badPlatforms` because cross-compilation on 64-bit machine might work. maxSilent = 14400; # 4h, double the default of 7200s (c.f. #129212, #129115) license = lib.licenses.mpl20; }; tests = [ nixosTests.floorp ]; }).override { privacySupport = true; enableOfficialBranding = false; }).overrideAttrs (prev: { MOZ_REQUIRE_SIGNING = ""; }) </ins>