jiebi/CodeConvo huggingface dataset:
Code change:
Describe the bug Riot-Desktop -Security & Privacy Under the "Message search" heading, observe: Riot is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom Riot Desktop with search components . it links to here: Notify maintainers cc: Metadata Maintainer information:
Would be fantastic to have built with . I tried building it myself but couldn't do it. :cry:
Just stumbled across this myself. What's the current state on this? What needs to be done before this can be fixed?
So, element seems to use its own build system to build these native dependencies. It tries to download and build those itself with cargo and stuff. Seems quite complicated to package.
I would like to add that support for desktop notifications would be also appreciated. (They showed up on Arch's version, at least) Edit: This problem has been resolved since
I made some progress. This solves the issue of downloading the hakDependencies. Unfortunately they are not locked in any way, so we need to lock them at packaging-time (is that even a term?) by adding them to and Since yarn2nix always runs yarn with , we can safely ignore the upstream reasoning for fetching them outside of yarn dependencies. I'm now at the point where it tries to build seshat in the element-desktop derivation, but unfortunately they don't provide a Cargo lockfile. I'm working on resolving this problem upstream: <details</details
It turns out to be much more complicated, because the cargo build of seshat-node-native calls , so we have multiple layers of npm calling yarn calling cargo calling npm. With lots of things being downloaded and executed. It's a huge shitshow.
Is there anything we could do to help fix building with encrypted chat search working on NixOS?
I poured some (many) more hours into this today. I can build the two native modules, matrix-seshat and keytar, both in a seperate derivation and as part of the element-desktop build. However, I can not build them correctly against electron's node lib, so when starting the compiled thing, it refuses to load the module. Attempting to build against electron gives a mystic error. Or the second approach, with everything in one derivation using the hak tool: <details</details<rantHonestly it's just a horrible build system. hak and neon and so on don't give any consideration to users who want to build the libraries in an environment without an internet connection. </rant If you can find a fix for the error, there shouldn't be much work left.
I think I found the solution to that error: Upstream is using Electron 12.x while we are using Electron 13.x.
! PR incoming :sparkles:

Related discussion:
text: nativeBuildInputs = [ makeWrapper ]; <ins> seshat = callPackage ./seshat {}; keytar = callPackage ./keytar {}; </ins> buildPhase = '' runHook preBuild export HOME=$(mktemp -d)
Code change:
Describe the bug Riot-Desktop -Security & Privacy Under the "Message search" heading, observe: Riot is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom Riot Desktop with search components . it links to here: Notify maintainers cc: Metadata Maintainer information:
Would be fantastic to have built with . I tried building it myself but couldn't do it. :cry:
Just stumbled across this myself. What's the current state on this? What needs to be done before this can be fixed?
So, element seems to use its own build system to build these native dependencies. It tries to download and build those itself with cargo and stuff. Seems quite complicated to package.
I would like to add that support for desktop notifications would be also appreciated. (They showed up on Arch's version, at least) Edit: This problem has been resolved since
I made some progress. This solves the issue of downloading the hakDependencies. Unfortunately they are not locked in any way, so we need to lock them at packaging-time (is that even a term?) by adding them to and Since yarn2nix always runs yarn with , we can safely ignore the upstream reasoning for fetching them outside of yarn dependencies. I'm now at the point where it tries to build seshat in the element-desktop derivation, but unfortunately they don't provide a Cargo lockfile. I'm working on resolving this problem upstream: <details</details
It turns out to be much more complicated, because the cargo build of seshat-node-native calls , so we have multiple layers of npm calling yarn calling cargo calling npm. With lots of things being downloaded and executed. It's a huge shitshow.
Is there anything we could do to help fix building with encrypted chat search working on NixOS?
I poured some (many) more hours into this today. I can build the two native modules, matrix-seshat and keytar, both in a seperate derivation and as part of the element-desktop build. However, I can not build them correctly against electron's node lib, so when starting the compiled thing, it refuses to load the module. Attempting to build against electron gives a mystic error. Or the second approach, with everything in one derivation using the hak tool: <details</details<rantHonestly it's just a horrible build system. hak and neon and so on don't give any consideration to users who want to build the libraries in an environment without an internet connection. </rant If you can find a fix for the error, there shouldn't be much work left.
I think I found the solution to that error: Upstream is using Electron 12.x while we are using Electron 13.x.
! PR incoming :sparkles:

Related discussion:
text: yarn run i18n node ./scripts/copy-res.js popd <ins> rm -rf node_modules/matrix-seshat node_modules/keytar ln -s $keytar node_modules/keytar ln -s $seshat node_modules/matrix-seshat </ins> runHook postBuild '';
Code change:
Describe the bug Riot-Desktop -Security & Privacy Under the "Message search" heading, observe: Riot is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom Riot Desktop with search components . it links to here: Notify maintainers cc: Metadata Maintainer information:
Would be fantastic to have built with . I tried building it myself but couldn't do it. :cry:
Just stumbled across this myself. What's the current state on this? What needs to be done before this can be fixed?
So, element seems to use its own build system to build these native dependencies. It tries to download and build those itself with cargo and stuff. Seems quite complicated to package.
I would like to add that support for desktop notifications would be also appreciated. (They showed up on Arch's version, at least) Edit: This problem has been resolved since
I made some progress. This solves the issue of downloading the hakDependencies. Unfortunately they are not locked in any way, so we need to lock them at packaging-time (is that even a term?) by adding them to and Since yarn2nix always runs yarn with , we can safely ignore the upstream reasoning for fetching them outside of yarn dependencies. I'm now at the point where it tries to build seshat in the element-desktop derivation, but unfortunately they don't provide a Cargo lockfile. I'm working on resolving this problem upstream: <details</details
It turns out to be much more complicated, because the cargo build of seshat-node-native calls , so we have multiple layers of npm calling yarn calling cargo calling npm. With lots of things being downloaded and executed. It's a huge shitshow.
Is there anything we could do to help fix building with encrypted chat search working on NixOS?
I poured some (many) more hours into this today. I can build the two native modules, matrix-seshat and keytar, both in a seperate derivation and as part of the element-desktop build. However, I can not build them correctly against electron's node lib, so when starting the compiled thing, it refuses to load the module. Attempting to build against electron gives a mystic error. Or the second approach, with everything in one derivation using the hak tool: <details</details<rantHonestly it's just a horrible build system. hak and neon and so on don't give any consideration to users who want to build the libraries in an environment without an internet connection. </rant If you can find a fix for the error, there shouldn't be much work left.
I think I found the solution to that error: Upstream is using Electron 12.x while we are using Electron 13.x.
! PR incoming :sparkles:

Related discussion:
text: <ins> #!/usr/bin/env nix-shell #!nix-shell -I nixpkgs=../ -i bash -p wget yarn2nix set -euo pipefail if [ "$#" -ne 1 ] || [[ "$1" == -* ]]; then echo "Regenerates the Yarn dependency lock files." echo "Usage: $0 <git release tag>" exit 1 fi SRC="https://raw.githubusercontent.com/matrix-org/seshat/$1" wget "$SRC/seshat-node/yarn.lock" yarn2nix > yarn.nix rm yarn.lock </ins>
Code change:
, CVSSv3=9.8 (nixos-20.03) Scanned versions: nixos-20.03: . May contain false positives.
merged - closing

Related discussion:
text: { stdenv, fetchurl, gettext, bzip2 }: stdenv.mkDerivation rec { <del> name = "sysstat-12.2.0"; </del> <ins> name = "sysstat-12.2.3"; </ins> src = fetchurl { url = "http://pagesperso-orange.fr/sebastien.godard/${name}.tar.xz"; <del> sha256 = "0xc3983ccr0dwab1px2jhbgj86pfmmr29k7ggnwjwm1qigmriak1"; </del> <ins> sha256 = "0c7lcjj796fvb0abqlhkval82r9yp5kvn3vi9k823r45422xv5y1"; </ins> }; buildInputs = [ gettext ];
Code change:
Describe the bug The package is supposed to vend a binary called . Instead it's vending a binary called . The upstream repo has a Makefile that explicitly passes to . I don't see any equivalent in our package (which bypasses the Makefile). This is a problem both because of breaking expectations, and also because the package makes the assumption that provides a binary called . In particular, the script tries to invoke the binary as part of the subcommand. To Reproduce Steps to reproduce the behavior: what binaries it provides Expected behavior It should provide . Notify maintainers Also the maintainers, in case the resolution is to change to use the name instead of : Metadata system: host os: multi-user?: sandbox: version: channels(lilyball): nixpkgs: Maintainer information:
It's possible to override the buildPhase in to run make. However in this case it might be easier to just perform the remame with a in .

Related discussion:
text: passthru.updateScript = ./update.sh; <ins> postInstall = '' mv $out/bin/wireguard $out/bin/wireguard-go ''; </ins> meta = with stdenv.lib; { description = "Userspace Go implementation of WireGuard"; homepage = "https://git.zx2c4.com/wireguard-go/about/";
Code change:
Describe the bug Error build php packages. To Reproduce Steps to reproduce the behavior: Run Notify maintainers Build error occurs after this PR Build log:
After this PR error build php. cc
fixes it

Related discussion:
text: hardeningDisable = [ "bindnow" ]; <del> preConfigure = '' # Don't record the configure flags since this causes unnecessary # runtime dependencies </del> <ins> preConfigure = # Don't record the configure flags since this causes unnecessary # runtime dependencies '' </ins> for i in main/build-defs.h.in scripts/php-config.in; do substituteInPlace $i  --replace '@CONFIGURE_COMMAND@' '(omitted)'
Code change:
Describe the bug Error build php packages. To Reproduce Steps to reproduce the behavior: Run Notify maintainers Build error occurs after this PR Build log:
After this PR error build php. cc
fixes it

Related discussion:
text: done export EXTENSION_DIR=$out/lib/php/extensions <ins> '' # PKG_CONFIG need not be a relative path + lib.optionalString (! lib.versionAtLeast version "7.4") '' for i in $(find . -type f -name "*.m4"); do substituteInPlace $i  --replace 'test -x "$PKG_CONFIG"' 'type -P "$PKG_CONFIG" >/dev/null' done '' + '' </ins> ./buildconf --copy --force if test -f $src/genfiles; then
Code change:
Describe the bug It should be the path to ca- To Reproduce Expected behavior No error happens. Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(mnacamura): nixpkgs:

Related discussion:
text: "--with-iconv=${libiconv}" "--with-dbm=gdbm" "--with-zlib=${zlib}" <del> "--with-ca-bundle=$NIX_SSL_CERT_FILE" </del> <ins> "--with-ca-bundle=${cacert}/etc/ssl/certs/ca-bundle.crt" </ins> # TODO: Enable slib #       Current slib in nixpkgs is specialized to Guile # "--with-slib=${slibGuile}/lib/slib"
Code change:
, CVSSv3=9.8 (nixos-20.03, nixos-unstable) Scanned versions: nixos-20.03: ; nixos-unstable: . May contain false positives.
merged
Need to keep open for 20.09
Merged to 20.09 too. Closing.

Related discussion:
text: with stdenv.lib; stdenv.mkDerivation rec { <del> name = "corosync-2.4.3"; </del> <ins> pname = "corosync"; version = "2.4.5"; </ins> src = fetchurl { <del> url = "http://build.clusterlabs.org/corosync/releases/${name}.tar.gz"; sha256 = "15y5la04qn2lh1gabyifygzpa4dx3ndk5yhmaf7azxyjx0if9rxi"; </del> <ins> url = "http://build.clusterlabs.org/corosync/releases/${pname}-${version}.tar.gz"; sha256 = "0pxs18vci9kq3qnqsg5i1h35jrxxiccwbm0mzja3g8j3izdsyvmb"; </ins> }; nativeBuildInputs = [ makeWrapper pkgconfig ];
Code change:
, CVSSv3=6.1 (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives. Cc Cc

Related discussion:
text: <del> { lib, buildGoPackage, fetchFromGitHub }: </del> <ins> { lib, buildGoModule, fetchFromGitHub }: </ins> <del> buildGoPackage rec { pname = "oauth2_proxy"; version = "5.1.0"; goPackagePath = "github.com/pusher/${pname}"; </del> <ins> buildGoModule rec { pname = "oauth2-proxy"; version = "5.1.1"; </ins> src = fetchFromGitHub { repo = pname;
Code change:
, CVSSv3=6.1 (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives. Cc Cc

Related discussion:
text: rev = "v${version}"; }; <del> goDeps = ./deps.nix; </del> <ins> vendorSha256 = "01lf7xbhgn5l42ahym12vr1w00zx1qzy6sgwgcbvvxp48k0b271d"; </ins> doCheck = true;
Code change:
, CVSSv3=6.1 (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives. Cc Cc

Related discussion:
text: meta = with lib; { description = "A reverse proxy that provides authentication with Google, Github, or other providers"; <del> homepage = "https://github.com/pusher/oauth2_proxy/"; </del> <ins> homepage = "https://github.com/oauth2-proxy/oauth2-proxy/"; </ins> license = licenses.mit; maintainers = with maintainers; [ yorickvp knl ]; };
Code change:
I am failing to install on right now: What more details should I provide?
perf fails on kernel 4.1 and 4.2 only
for an (arguably hacky) fix.

Related discussion:
text: {stdenv, fetchurl}: stdenv.mkDerivation rec { <del> name = "ncompress-4.2.4.3"; </del> <ins> name = "ncompress-4.2.4.4"; </ins> builder = ./builder.sh;
Code change:
I am failing to install on right now: What more details should I provide?
perf fails on kernel 4.1 and 4.2 only
for an (arguably hacky) fix.

Related discussion:
text: src = fetchurl { url = "mirror://sourceforge/project/ncompress/${name}.tar.gz"; <del> sha256 = "1y44ixc1w2vfvj1lm4dkcljlwv882ynrvm5i6l0lg1gf883j246l"; </del> <ins> sha256 = "0yjiwv1hwb253x3m6r1dq2k7m5c9nz0ib2j7fnm3hark7y6s42xh"; </ins> }; meta = {
Code change:
I am failing to install on right now: What more details should I provide?
perf fails on kernel 4.1 and 4.2 only
for an (arguably hacky) fix.

Related discussion:
text: # perf refers both to newt and slang # binutils is required for libbfd. nativeBuildInputs = [ asciidoc xmlto docbook_xsl docbook_xml_dtd_45 libxslt flex bison ]; <del> buildInputs = [ elfutils python perl newt slang pkgconfig libunwind binutils ] ++ </del> <ins> buildInputs = [ python perl newt slang pkgconfig libunwind binutils ] ++ </ins> stdenv.lib.optional withGtk gtk; <del> NIX_CFLAGS_COMPILE = "-Wno-error=cpp"; </del> <ins> # Note: we don't add elfutils to buildInputs, since it provides a # bad `ld' and other stuff. NIX_CFLAGS_COMPILE = "-I${elfutils}/include -Wno-error=cpp"; NIX_CFLAGS_LINK = "-L${elfutils}/lib"; </ins> installFlags = "install install-man ASCIIDOC8=1";
Code change:
Project description Netdata agent plugin Metadata homepage URL: source URL: license: GPL 3.0 platforms: unix, linux, darwin We already do have netdata, however it seems to be built without support for the cloud agent that allows it to stream to the cloud or other netdata servers.
I have a local checkout with some edits that allow me to build netdata with cloud support. Unfortunately they also require a change in the libwebsockets build expression. Should I open a PR to integrate my changes into nixpkgs?
A PR would be great! I'm not a maintainer, but if they decide it's out of scope for nixpkgs, perhaps one on NUR might work - I'd try for a PR here first though
Great, I think having a configuration option that is per default would make sense. Maybe ?
Yeah, that seems to fall in line with the various flags present in other packages
I marked this as stale due to inactivity. &rarr;
Upstream has incorporated some of the suggestions in this thread, I intend to pick up on it again soon
what would be needed to make this work? Perhaps I can help?
The newest major release of Netdata (1.30.0) includes a cloud link implementation without the need for vendored dependencies. Unfortunately, it is not currently in a reliable state because of a bug in the custom HTTPS implementation. The has already been merged into Netdata master and will be included in the next release. I plan to make a PR that enables cloud support as soon as that release is available.
v1.31.0 dropped 12 minutes ago :) Anything I can do to help?
Thanks, I've already gotten a notification for that. Planning to make a PR when I get off work today. When my PR is done, it would be helpful if you could test my changes on your machines.
Just FYI, I have opened the PR that enables cloud support a few days ago. If you are still interested it would be greatly appreciated if you could test if everything works for you and maybe drop a comment.
Sorry, missed this but the pr looks good! I propose we backport this to stable?

Related discussion:
text: { lib, stdenv, callPackage, fetchFromGitHub, autoreconfHook, pkg-config , CoreFoundation, IOKit, libossp_uuid <del> , curl, libcap,  libuuid, lm_sensors, zlib </del> , nixosTests <ins> , curl, libcap, libuuid, lm_sensors, zlib </ins> , withCups ? false, cups , withDBengine ? true, libuv, lz4, judy , withIpmi ? (!stdenv.isDarwin), freeipmi , withNetfilter ? (!stdenv.isDarwin), libmnl, libnetfilter_acct <ins> , withCloud ? (!stdenv.isDarwin), json_c </ins> , withSsl ? true, openssl , withDebug ? false <del> , fetchpatch </del> }: with lib;
Code change:
Project description Netdata agent plugin Metadata homepage URL: source URL: license: GPL 3.0 platforms: unix, linux, darwin We already do have netdata, however it seems to be built without support for the cloud agent that allows it to stream to the cloud or other netdata servers.
I have a local checkout with some edits that allow me to build netdata with cloud support. Unfortunately they also require a change in the libwebsockets build expression. Should I open a PR to integrate my changes into nixpkgs?
A PR would be great! I'm not a maintainer, but if they decide it's out of scope for nixpkgs, perhaps one on NUR might work - I'd try for a PR here first though
Great, I think having a configuration option that is per default would make sense. Maybe ?
Yeah, that seems to fall in line with the various flags present in other packages
I marked this as stale due to inactivity. &rarr;
Upstream has incorporated some of the suggestions in this thread, I intend to pick up on it again soon
what would be needed to make this work? Perhaps I can help?
The newest major release of Netdata (1.30.0) includes a cloud link implementation without the need for vendored dependencies. Unfortunately, it is not currently in a reliable state because of a bug in the custom HTTPS implementation. The has already been merged into Netdata master and will be included in the next release. I plan to make a PR that enables cloud support as soon as that release is available.
v1.31.0 dropped 12 minutes ago :) Anything I can do to help?
Thanks, I've already gotten a notification for that. Planning to make a PR when I get off work today. When my PR is done, it would be helpful if you could test my changes on your machines.
Just FYI, I have opened the PR that enables cloud support a few days ago. If you are still interested it would be greatly appreciated if you could test if everything works for you and maybe drop a comment.
Sorry, missed this but the pr looks good! I propose we backport this to stable?

Related discussion:
text: let go-d-plugin = callPackage ./go.d.plugin.nix {}; in stdenv.mkDerivation rec { <del> version = "1.30.1"; </del> <ins> version = "1.31.0"; </ins> pname = "netdata"; src = fetchFromGitHub { owner = "netdata"; repo = "netdata"; rev = "v${version}"; <del> sha256 = "0cp6gbn38f1cr0jkr64vvwz005cvnwj3hgfxs147wap9w228k46r"; </del> <ins> sha256 = "0735cxmljrp8zlkcq7hcxizy4j4xiv7vf782zkz5chn06n38mcik"; fetchSubmodules = true; </ins> }; nativeBuildInputs = [ autoreconfHook pkg-config ];
Code change:
Project description Netdata agent plugin Metadata homepage URL: source URL: license: GPL 3.0 platforms: unix, linux, darwin We already do have netdata, however it seems to be built without support for the cloud agent that allows it to stream to the cloud or other netdata servers.
I have a local checkout with some edits that allow me to build netdata with cloud support. Unfortunately they also require a change in the libwebsockets build expression. Should I open a PR to integrate my changes into nixpkgs?
A PR would be great! I'm not a maintainer, but if they decide it's out of scope for nixpkgs, perhaps one on NUR might work - I'd try for a PR here first though
Great, I think having a configuration option that is per default would make sense. Maybe ?
Yeah, that seems to fall in line with the various flags present in other packages
I marked this as stale due to inactivity. &rarr;
Upstream has incorporated some of the suggestions in this thread, I intend to pick up on it again soon
what would be needed to make this work? Perhaps I can help?
The newest major release of Netdata (1.30.0) includes a cloud link implementation without the need for vendored dependencies. Unfortunately, it is not currently in a reliable state because of a bug in the custom HTTPS implementation. The has already been merged into Netdata master and will be included in the next release. I plan to make a PR that enables cloud support as soon as that release is available.
v1.31.0 dropped 12 minutes ago :) Anything I can do to help?
Thanks, I've already gotten a notification for that. Planning to make a PR when I get off work today. When my PR is done, it would be helpful if you could test my changes on your machines.
Just FYI, I have opened the PR that enables cloud support a few days ago. If you are still interested it would be greatly appreciated if you could test if everything works for you and maybe drop a comment.
Sorry, missed this but the pr looks good! I propose we backport this to stable?

Related discussion:
text: ++ optionals withDBengine [ libuv lz4.dev judy ] ++ optionals withIpmi [ freeipmi ] ++ optionals withNetfilter [ libmnl libnetfilter_acct ] <ins> ++ optionals withCloud [ json_c ] </ins> ++ optionals withSsl [ openssl.dev ]; patches = [ # required to prevent plugins from relying on /etc # and /var ./no-files-in-etc-and-var.patch <del> # cgroups: fix network interfaces detection when using virsh (fetchpatch { url = "https://patch-diff.githubusercontent.com/raw/netdata/netdata/pull/11096.patch"; sha256 = "0f2rd7kgbwbyq9wyn085d213ifvivnpl3qlx1gjrg42rkbi4n8jj"; }) </del> ]; NIX_CFLAGS_COMPILE = optionalString withDebug "-O1 -ggdb -DNETDATA_INTERNAL_CHECKS=1";