jiebi/CodeConvo huggingface dataset:
Code change:
Describe the bug error: --- Error --- build-remote build of '/nix/store/x4nz3kqn24vlz257hm8mnsvrn6ggfsrs-v4l-utils-' on 'ssh://root failed: builder for '/nix/store/x4nz3kqn24vlz257hm8mnsvrn6ggfsrs-v4l-utils-' failed with exit code 2 error: --- Error
-------------------------------------------------------- nix builder for '/nix/store/x4nz3kqn24vlz257hm8mnsvrn6ggfsrs-v4l-utils-' failed with exit code 1; last 10 log lines: ../../utils/libcecutil/cec- ../../include/linux/cec.h ../../utils/libcecutil/cec-htng.h ../../include/linux/cec-funcs.h ../../utils/libcecutil/cec-htng-funcs.h /nix/store/j8vysakw78bpgngba32hfwwikqda9yx2-bash-4.4-p23/bin/bash: ../../utils/libcecutil/cec- /usr/bin/perl: bad interpreter: No such file or directory make[3]: [Makefile:782: gen.intermediate] Error 126 make[3]: Leaving directory '/build/v4l-utils-1.20.0/utils/libcecutil' make[2]: [Makefile:482: all-recursive] Error 1 make[2]: Leaving directory '/build/v4l-utils-1.20.0/utils' make[1]: [Makefile:591: all-recursive] Error 1 make[1]: Leaving directory '/build/v4l-utils-1.20.0' make: [Makefile:518: all] Error 2 builder for '/nix/store/x4nz3kqn24vlz257hm8mnsvrn6ggfsrs-v4l-utils-' failed with exit code 2 error: --- Error
-------------------------------------------------------- nix 1 dependencies of derivation '/nix/store/2544nk822aa38adwvdgk8kc1zyxf1wgd-system-' failed to build we need another . PR incoming... I'm on

Related discussion:
text: postPatch = '' patchShebangs utils/cec-ctl/msg2ctl.pl <ins> patchShebangs utils/libcecutil/cec-gen.pl </ins> ''; meta = with stdenv.lib; {
Code change:
Describe the bug as described in , the build fails with: To Reproduce Steps to reproduce the behavior: Since this is a dependency of openjdk14, reproduce with: Additional context This broke somewhere between and ; I'm bisecting now. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
I could've sworn I tested this back when I was working on ... rebuilding from those commits now to confirm.
Yeah, somehow the release fixes this, but I don't know how.

Related discussion:
text: postFixup = '' # Remove references to bootstrap. find "$out" -name *.so | while read lib; do <del> new_refs="$(patchelf --print-rpath "$lib" | sed -E 's,:?${openjdk11_headless}[^:]*,,')" </del> <ins> new_refs="$(patchelf --print-rpath "$lib" | sed -E 's,:?${lib.escape ["+"] openjdk11_headless.outPath}[^:]*,,')" </ins> patchelf --set-rpath "$new_refs" "$lib" done '';
Code change:
Describe the bug A clear and concise description of what the bug is. If I try to use the function in from the command line I get an error: To Reproduce Steps to reproduce the behavior: is printed to console Expected behavior A clear and concise description of what you expected to happen. should define so works. Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Currently NixOS modules (, ) handle this for the most part, but it would be nice to avoid duplication and have this defined once - in the package instead of modules. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:

Related discussion:
text: { callPackage, lib, stdenv, nixosTests, config, fetchurl, makeWrapper , symlinkJoin, writeText, autoconf, automake, bison, flex, libtool , pkgconfig, re2c, apacheHttpd, libargon2, libxml2, pcre, pcre2 <del> , systemd, valgrind, xcbuild </del> <ins> , systemd, system-sendmail, valgrind, xcbuild </ins> , version , sha256
Code change:
Describe the bug A clear and concise description of what the bug is. If I try to use the function in from the command line I get an error: To Reproduce Steps to reproduce the behavior: is printed to console Expected behavior A clear and concise description of what you expected to happen. should define so works. Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Currently NixOS modules (, ) handle this for the most part, but it would be nice to avoid duplication and have this defined once - in the package instead of modules. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:

Related discussion:
text: ++ lib.optional systemdSupport "--with-fpm-systemd" ++ lib.optional valgrindSupport "--with-valgrind=${valgrind.dev}" ++ lib.optional ztsSupport "--enable-maintainer-zts" <ins> # Sendmail ++ [ "PROG_SENDMAIL=${system-sendmail}/bin/sendmail" ] </ins> ; hardeningDisable = [ "bindnow" ];
Code change:
Describe the bug peek fails to build on macOS To Reproduce Clone then Notify maintainers Log
I marked this as stale due to inactivity. &rarr;
sadly its not supported though getting keybinder3 to compile would be good
I marked this as stale due to inactivity. &rarr;

Related discussion:
text: "-Dtests=false" "-Dtracker3=${lib.boolToString trackerSupport}" "-Dbroadway_backend=${lib.boolToString broadwaySupport}" <ins> "-Dx11_backend=${lib.boolToString x11Support}" "-Dquartz_backend=${lib.boolToString (stdenv.isDarwin && !x11Support)}" </ins> ]; doCheck = false; # needs X11
Code change:
Describe the bug peek fails to build on macOS To Reproduce Clone then Notify maintainers Log
I marked this as stale due to inactivity. &rarr;
sadly its not supported though getting keybinder3 to compile would be good
I marked this as stale due to inactivity. &rarr;

Related discussion:
text: NIX_CFLAGS_COMPILE = "-DG_ENABLE_DEBUG -DG_DISABLE_CAST_CHECKS"; postPatch = '' <ins> # See https://github.com/NixOS/nixpkgs/issues/132259 substituteInPlace meson.build  --replace "x11_enabled = false" "" </ins> files=( build-aux/meson/post-install.py demos/gtk-demo/geninclude.py
Code change:
Describe the bug peek fails to build on macOS To Reproduce Clone then Notify maintainers Log
I marked this as stale due to inactivity. &rarr;
sadly its not supported though getting keybinder3 to compile would be good
I marked this as stale due to inactivity. &rarr;

Related discussion:
text: description = "Library for registering global key bindings"; homepage = "https://github.com/kupferlauncher/keybinder/"; license = licenses.mit; <del> platforms = platforms.linux; </del> <ins> platforms = platforms.unix; </ins> maintainers = [ maintainers.cstrahan ]; }; }
Code change:
Describe the bug peek fails to build on macOS To Reproduce Clone then Notify maintainers Log
I marked this as stale due to inactivity. &rarr;
sadly its not supported though getting keybinder3 to compile would be good
I marked this as stale due to inactivity. &rarr;

Related discussion:
text: }; keybinder3 = callPackage ../development/libraries/keybinder3 { <ins> gtk3 = if stdenv.isDarwin then gtk3-x11 else gtk3; </ins> automake = automake111x; };
Code change:
Project description cchat-gtk appears to be a generic chat frontend cchat-discord appears to be a discord-capable backend gtkcord3 was the predecessor and was quite nice, I'm excited to get this packaged. Metadata homepage URL: source URL: license: gpl3 platforms: linux
updated OP to reflect that we should package cchat-gtk/cchat-discord now instead of gtkcord3.
I marked this as stale due to inactivity. &rarr;
still important to me
I have this packaged in my own config:
I marked this as stale due to inactivity. &rarr;

Related discussion:
text: <ins> { buildGoModule , cairo , fetchFromGitHub , gdk-pixbuf , glib , gobject-introspection , graphene , gtk4 , lib , pango , pkg-config }: buildGoModule rec { pname = "gtkcord4"; version = "0.0.6"; src = fetchFromGitHub { owner = "diamondburned"; repo = pname; rev = "v${version}"; hash = "sha256-uEG1pAHMQT+C/E5rKByflvL0NNkC8SeSPMAXanzvhE4="; }; nativeBuildInputs = [ gobject-introspection pkg-config ]; buildInputs = [ cairo gdk-pixbuf glib graphene gtk4 pango ]; vendorHash = "sha256-QZSjSk1xu5ZcrNEra5TxnUVvlQWb5/h31fm5Nc7WMoI="; meta = with lib; { description = "GTK4 Discord client in Go, attempt #4."; homepage = "https://github.com/diamondburned/gtkcord4"; license = licenses.gpl3Only; maintainers = with maintainers; [ urandom ]; }; } </ins>
Code change:
Project description cchat-gtk appears to be a generic chat frontend cchat-discord appears to be a discord-capable backend gtkcord3 was the predecessor and was quite nice, I'm excited to get this packaged. Metadata homepage URL: source URL: license: gpl3 platforms: linux
updated OP to reflect that we should package cchat-gtk/cchat-discord now instead of gtkcord3.
I marked this as stale due to inactivity. &rarr;
still important to me
I have this packaged in my own config:
I marked this as stale due to inactivity. &rarr;

Related discussion:
text: gspeech = callPackage ../applications/audio/gspeech { }; <ins> gtkcord4 = callPackage ../applications/audio/gtkcord4 {}; </ins> haruna = libsForQt5.callPackage ../applications/video/haruna { }; hdrmerge = libsForQt5.callPackage ../applications/graphics/hdrmerge { };
Code change:
Describe the bug It's easiest to see in this picture: ! To Reproduce Steps to reproduce the behavior: system with nixpkgs at how init complains about /dev/fd/62 Expected behavior No error pertaining to /dev/fd/62. Screenshots See above. Additional context I don't actually remember when this started, because the boot logging scrolls so fast I missed it a few times (and I might have updated nixos-unstable-small at some point). The problematic line is: According to the blame, that hasn't been touched in 5 years, so I don't know why this would start cropping up now. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Why I think we should block on this: there should be no scary pointless outputs in the init script in nixos. Same if the activation script was being loud and scary for no reason.
So, I attempted to bisect this, but due to build failures (and the size of some builds) I was unable to pinpoint. However, I've now set up a machine that I can use for those huge builds, and will try to go further sometime soon. For anybody interested, below is my ( and ):
OK, I re-bisected (by removing all the skipped commits and building them on a machine) and got this result: cc What are the chances this is an issue with the package/one of our patches and not with upstream? New bisect log, for the curious:
did this happen in a VM, or on your real machine as well? What's with the `chown: invalid user" in there? Is this related?
I can reproduce in a VM and on my machine. Ignore everything below the fd error -- screenshot was taken from another issue, before I was able to build a VM myself. (EDIT: I've uploaded my own screenshot sans the JSON and errors, to make things clearer.) I'm going to try to bisect systemd soon, but it'll probably take a while, especially given how many patches there are that could fail to apply :P
OK, maybe the stuff is a red herring? I d the entire call and got the following log: <details<summarystrace output</summary</detailsCan't interpret this now, but maybe it will give somebody an idea. Most interesting part to me:
Alright, thanks to my Google-fu, I found a diff that fixes the issue: According to , one of the articles that turned up, this might be caused by udev missing?

Related discussion:
text: # Create device nodes in /dev. @preDeviceCommands@ echo "running udev..." <ins> ln -sfn /proc/self/fd /dev/fd </ins> mkdir -p /etc/systemd ln -sfn @linkUnits@ /etc/systemd/network mkdir -p /etc/udev
Code change:
Describe the bug When trying to start a dynamic playlist, the user is greeted by an error banner stating the following: To Reproduce Steps to reproduce the behavior: Cantata dynamic playlist to play dynamic playlist Expected behavior I expected Cantata to start the dynamic playlist. Screenshots ! Additional context This is likely fallout from perl's removal in However, this exposed something impure about Cantata's packaging, so it's a good thing! I tried simply patching the shebang to point to (as well as changing this condition to never return true: ), but to no avail. EDIT: Even adding to my does nothing -- when I click on the play button by the dynamic playlist, it turns to the red stop button, and then back to the play button without ever playing or queuing any songs. Seems like this might need more work. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
If you have the time to give it go, I think this should do the trick: And then add to .
Thanks for the tip. It was slightly more involved than that, but fixed in this PR:

Related discussion:
text: { mkDerivation, lib, fetchFromGitHub, cmake, pkgconfig <del> , qtbase, qtsvg, qttools </del> <ins> , qtbase, qtsvg, qttools, perl </ins> # Cantata doesn't build with cdparanoia enabled so we disable that # default for now until I (or someone else) figure it out.
Code change:
Describe the bug When trying to start a dynamic playlist, the user is greeted by an error banner stating the following: To Reproduce Steps to reproduce the behavior: Cantata dynamic playlist to play dynamic playlist Expected behavior I expected Cantata to start the dynamic playlist. Screenshots ! Additional context This is likely fallout from perl's removal in However, this exposed something impure about Cantata's packaging, so it's a good thing! I tried simply patching the shebang to point to (as well as changing this condition to never return true: ), but to no avail. EDIT: Even adding to my does nothing -- when I click on the play button by the dynamic playlist, it turns to the red stop button, and then back to the play button without ever playing or queuing any songs. Seems like this might need more work. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
If you have the time to give it go, I think this should do the trick: And then add to .
Thanks for the tip. It was slightly more involved than that, but fixed in this PR:

Related discussion:
text: withUdisks = (withTaglib && withDevices); <ins> perl' = perl.withPackages (ppkgs: [ ppkgs.URI ]); </ins> in mkDerivation { name = "${pname}-${version}";
Code change:
Describe the bug When trying to start a dynamic playlist, the user is greeted by an error banner stating the following: To Reproduce Steps to reproduce the behavior: Cantata dynamic playlist to play dynamic playlist Expected behavior I expected Cantata to start the dynamic playlist. Screenshots ! Additional context This is likely fallout from perl's removal in However, this exposed something impure about Cantata's packaging, so it's a good thing! I tried simply patching the shebang to point to (as well as changing this condition to never return true: ), but to no avail. EDIT: Even adding to my does nothing -- when I click on the play button by the dynamic playlist, it turns to the red stop button, and then back to the play button without ever playing or queuing any songs. Seems like this might need more work. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
If you have the time to give it go, I think this should do the trick: And then add to .
Thanks for the tip. It was slightly more involved than that, but fixed in this PR:

Related discussion:
text: sha256 = "0ix7xp352bziwz31mw79y7wxxmdn6060p8ry2px243ni1lz1qx1c"; }; <del> buildInputs = [ qtbase qtsvg ] </del> <ins> patches = [ # Cantata wants to check if perl is in the PATH at runtime, but we # patchShebangs the playlists scripts, making that unnecessary (perl will # always be available because it's a dependency) ./dont-check-for-perl-in-PATH.diff ]; postPatch = '' patchShebangs playlists ''; buildInputs = [ qtbase qtsvg perl' ] </ins> ++ lib.optionals withTaglib [ taglib taglib_extras ] ++ lib.optionals withReplaygain [ ffmpeg_3 speex mpg123 ] ++ lib.optional  withHttpStream qtmultimedia
Code change:
Describe the bug When trying to start a dynamic playlist, the user is greeted by an error banner stating the following: To Reproduce Steps to reproduce the behavior: Cantata dynamic playlist to play dynamic playlist Expected behavior I expected Cantata to start the dynamic playlist. Screenshots ! Additional context This is likely fallout from perl's removal in However, this exposed something impure about Cantata's packaging, so it's a good thing! I tried simply patching the shebang to point to (as well as changing this condition to never return true: ), but to no avail. EDIT: Even adding to my does nothing -- when I click on the play button by the dynamic playlist, it turns to the red stop button, and then back to the play button without ever playing or queuing any songs. Seems like this might need more work. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
If you have the time to give it go, I think this should do the trick: And then add to .
Thanks for the tip. It was slightly more involved than that, but fixed in this PR:

Related discussion:
text: <ins> diff --git a/playlists/dynamicplaylists.cpp b/playlists/dynamicplaylists.cpp index 07b6dce3..6a3f97c9 100644 --- a/playlists/dynamicplaylists.cpp +++ b/playlists/dynamicplaylists.cpp @@ -211,11 +211,6 @@ void DynamicPlaylists::start(const QString &name) return; } -    if (Utils::findExe("perl").isEmpty()) { -        emit error(tr("You need to install "perl" on your system in order for Cantata's dynamic mode to function.")); -        return; -    } - QString fName(Utils::dataDir(rulesDir, false)+name+constExtension); if (!QFile::exists(fName)) { </ins>
Code change:
Describe the bug It was left out being implemented in the initial PR , but it's a very useful feature for nixos development and endusers. I do understand it's nothing can't do, but it's a useful wrapper. cc
See for an attempt at adding support for this.

Related discussion:
text: outputs = { self }: let jobs = import ./pkgs/top-level/release.nix { nixpkgs = self; };
Code change:
Describe the bug It was left out being implemented in the initial PR , but it's a very useful feature for nixos development and endusers. I do understand it's nothing can't do, but it's a useful wrapper. cc
See for an attempt at adding support for this.

Related discussion:
text: lib = lib.extend (final: prev: { nixosSystem = { modules, ... } @ args: import ./nixos/lib/eval-config.nix (args // { <del> modules = modules ++ [ { system.nixos.versionSuffix = </del> <ins> modules = let vmConfig = (import ./nixos/lib/eval-config.nix (args // { modules = modules ++ [ ./nixos/modules/virtualisation/qemu-vm.nix ]; })).config; vmWithBootLoaderConfig = (import ./nixos/lib/eval-config.nix (args // { modules = modules ++ [ ./nixos/modules/virtualisation/qemu-vm.nix { virtualisation.useBootLoader = true; } ]; })).config; in modules ++ [ { system.nixos.versionSuffix = </ins> ".${final.substring 0 8 (self.lastModifiedDate or self.lastModified)}.${self.shortRev or "dirty"}"; system.nixos.revision = final.mkIf (self ? rev) self.rev; <ins> system.build = { vm = vmConfig.system.build.vm; vmWithBootLoader = vmWithBootLoaderConfig.system.build.vm; }; </ins> } ]; });
Code change:
Describe the bug It was left out being implemented in the initial PR , but it's a very useful feature for nixos development and endusers. I do understand it's nothing can't do, but it's a useful wrapper. cc
See for an attempt at adding support for this.

Related discussion:
text: if [[ -z $flake ]]; then pathToConfig="$(nixBuild '<nixpkgs/nixos>' -A vm -k "${extraBuildFlags[@]}")" else <del> echo "$0: 'build-vm' is not supported with '--flake'" >&2 exit 1 </del> <ins> nix "${flakeFlags[@]}" build "$flake#$flakeAttr.config.system.build.vm"  "${extraBuildFlags[@]}" "${lockFlags[@]}" pathToConfig="$(readlink -f ./result)" </ins> fi elif [ "$action" = build-vm-with-bootloader ]; then if [[ -z $flake ]]; then pathToConfig="$(nixBuild '<nixpkgs/nixos>' -A vmWithBootLoader -k "${extraBuildFlags[@]}")" else <del> echo "$0: 'build-vm-with-bootloader' is not supported with '--flake'" >&2 exit 1 </del> <ins> nix "${flakeFlags[@]}" build "$flake#$flakeAttr.config.system.build.vmWithBootLoader"  "${extraBuildFlags[@]}" "${lockFlags[@]}" pathToConfig="$(readlink -f ./result)" </ins> fi else showSyntax
Code change:
ping It was agreed that should be removed before . It was generally accepted that an option isn't a great idea and was to the module temporarily for ease of testing. It is important to remove this because other people have seen this option and started believing this is an accepted design pattern for NixOS modules - we don't want people getting the wrong idea and having more options like this slip in. can you please file a PR removing this option and the entry from the release notes?

Related discussion:
text: </listitem> <listitem> <para> <del> Add option <literal>services.nginx.enableSandbox</literal> to starting Nginx web server with additional sandbox/hardening options. By default, write access to <literal>services.nginx.stateDir</literal> is allowed. To allow writing to other folders, </del> <ins> Nginx web server now starting with additional sandbox/hardening options. By default, write access to <literal>services.nginx.stateDir</literal> is allowed. To allow writing to other folders, </ins> use <literal>systemd.services.nginx.serviceConfig.ReadWritePaths</literal> <programlisting> systemd.services.nginx.serviceConfig.ReadWritePaths = [ "/var/www" ];
Code change:
ping It was agreed that should be removed before . It was generally accepted that an option isn't a great idea and was to the module temporarily for ease of testing. It is important to remove this because other people have seen this option and started believing this is an accepted design pattern for NixOS modules - we don't want people getting the wrong idea and having more options like this slip in. can you please file a PR removing this option and the entry from the release notes?

Related discussion:
text: ''; }; <del> enableSandbox = mkOption { default = false; type = types.bool; description = '' Starting Nginx web server with additional sandbox/hardening options. ''; }; </del> user = mkOption { type = types.str; default = "nginx";
Code change:
ping It was agreed that should be removed before . It was generally accepted that an option isn't a great idea and was to the module temporarily for ease of testing. It is important to remove this because other people have seen this option and started believing this is an accepted design pattern for NixOS modules - we don't want people getting the wrong idea and having more options like this slip in. can you please file a PR removing this option and the entry from the release notes?

Related discussion:
text: CapabilityBoundingSet = [ "CAP_NET_BIND_SERVICE" "CAP_SYS_RESOURCE" ]; # Security NoNewPrivileges = true; <del> } // optionalAttrs cfg.enableSandbox { </del> # Sandboxing ProtectSystem = "strict"; ProtectHome = mkDefault true;