jiebi/CodeConvo huggingface dataset:
Code change:
When multiple ZFS filesystems are present and configured to import, each individual attempts to load the keys for ALL pools/datasets, instead of just its own. A clear and concise description of what the bug is. Steps to reproduce the behavior: encrypted zfs filesystems in your NixOS configuration. & Reboot All targets complete successfully The below snippet from the services's script. It's 'ing, and just looping over all pools/datasets. Instead, it should just specify the name directly in the command. (Generated in ) Please run and paste the result. system: host os: multi-user?: sandbox: version: nixpkgs:
Can you post the relevant Nix config you used? Do you have set to anything?
Yep, here's my zfs config. uses (unlocked at boot) is unencrypted and have on-disk
Ok, I think this is fundamentally the same issue as . Basically, when there are multiple pools and is a list, we accidentally run with no dataset argument in the import service for pools that have no datasets in the list. So those services end up iterating over all datasets on all pools instead of none.

Related discussion:
text: done poolImported "${pool}" || poolImport "${pool}"  # Try one last time, e.g. to import a degraded pool. if poolImported "${pool}"; then <del> ${optionalString (if isBool cfgZfs.requestEncryptionCredentials then cfgZfs.requestEncryptionCredentials else cfgZfs.requestEncryptionCredentials != []) '' ${getKeyLocations pool} | while IFS=$'t' read ds kl ks; do </del> <ins> ${optionalString keyLocations.hasKeys '' ${keyLocations.command} | while IFS=$'t' read ds kl ks; do </ins> { if [[ "$ks" != unavailable ]]; then continue
Code change:
When multiple ZFS filesystems are present and configured to import, each individual attempts to load the keys for ALL pools/datasets, instead of just its own. A clear and concise description of what the bug is. Steps to reproduce the behavior: encrypted zfs filesystems in your NixOS configuration. & Reboot All targets complete successfully The below snippet from the services's script. It's 'ing, and just looping over all pools/datasets. Instead, it should just specify the name directly in the command. (Generated in ) Please run and paste the result. system: host os: multi-user?: sandbox: version: nixpkgs:
Can you post the relevant Nix config you used? Do you have set to anything?
Yep, here's my zfs config. uses (unlocked at boot) is unencrypted and have on-disk
Ok, I think this is fundamentally the same issue as . Basically, when there are multiple pools and is a list, we accidentally run with no dataset argument in the import service for pools that have no datasets in the list. So those services end up iterating over all datasets on all pools instead of none.

Related discussion:
text: '' else concatMapStrings (fs: '' zfs load-key -- ${escapeShellArg fs} <del> '') cfgZfs.requestEncryptionCredentials} </del> <ins> '') (filter (x: datasetToPool x == pool) cfgZfs.requestEncryptionCredentials)} </ins> '') rootPools)); # Systemd in stage 1
Code change:
twmnd does not launch because qt5 library path is missing. Install the twmn package and run twmnd. twmnd works when I manually set the LDLIBRARYPATH to <qtbase/lib. System: NixOS 16.09.931. Nix version: 1.11.4 Nixpkgs version:16.09.931.
I noticed the same or similar thing when trying to run twmnd as a systemd user service. It just SIGABRTs: I could reproduce with Although works fine... So clearly there is some impurity in my local environment which is making twmnd work "by accident?" Possibly related?:

Related discussion:
text: <del> { stdenv, fetchFromGitHub, qtbase, qtx11extras, qmake, pkgconfig, boost }: </del> <ins> { lib, mkDerivation, fetchFromGitHub, qtbase, qtx11extras, qmake, pkgconfig, boost }: </ins> <del> stdenv.mkDerivation { </del> <ins> mkDerivation { </ins> name = "twmn-git-2018-10-01"; src = fetchFromGitHub {
Code change:
twmnd does not launch because qt5 library path is missing. Install the twmn package and run twmnd. twmnd works when I manually set the LDLIBRARYPATH to <qtbase/lib. System: NixOS 16.09.931. Nix version: 1.11.4 Nixpkgs version:16.09.931.
I noticed the same or similar thing when trying to run twmnd as a systemd user service. It just SIGABRTs: I could reproduce with Although works fine... So clearly there is some impurity in my local environment which is making twmnd work "by accident?" Possibly related?:

Related discussion:
text: meta = { description = "A notification system for tiling window managers"; homepage = https://github.com/sboli/twmn; <del> platforms = with stdenv.lib.platforms; linux; maintainers = [ stdenv.lib.maintainers.matejc ]; license = stdenv.lib.licenses.lgpl3; </del> <ins> platforms = with lib.platforms; linux; maintainers = [ lib.maintainers.matejc ]; license = lib.licenses.lgpl3; </ins> }; }
Code change:
BlueZ is currently setup to read auxiliary config files (i.e. , ) from its package directory, which makes it hard to write to them properly on a NixOS system. These configuration files are the only way to configure certain behaviours of , such as in , which is an important setting for device power saving. It's not possible to specify these options in . And it's not possible to specify the path of at runtime. Steps to reproduce the behavior: a file, either manually or from a nix configuration. with . hasn't loaded any settings from . (It's easy to test if you fill with trash since it should log: ). It should be possible to configure all aspects of in the same way. BlueZ loads from a hardcoded path: The same is try for : The define is set to the package directory by default. For a symlink is setup, however no such link is setup for or : I wonder if a fix for this might be adding to the of BlueZ? There's no maintainer listed in , so I'm pinging the people who last touched it :) , Please run and paste the result.
I feel like this could be easily fixed rather in the by adding 2 more options for and under (?) Let me see if I can carve out some time later this week..
Fixed in

Related discussion:
text: }; description = lib.mdDoc "Set configuration for system-wide bluetooth (/etc/bluetooth/main.conf)."; }; <ins> input = mkOption { type = cfgFmt.type; default = { }; example = { General = { IdleTimeout = 30; ClassicBondedOnly = true; }; }; description = lib.mdDoc "Set configuration for the input service (/etc/bluetooth/input.conf)."; }; network = mkOption { type = cfgFmt.type; default = { }; example = { General = { DisableSecurity = true; }; }; description = lib.mdDoc "Set configuration for the network service (/etc/bluetooth/network.conf)."; }; </ins> }; };
Code change:
BlueZ is currently setup to read auxiliary config files (i.e. , ) from its package directory, which makes it hard to write to them properly on a NixOS system. These configuration files are the only way to configure certain behaviours of , such as in , which is an important setting for device power saving. It's not possible to specify these options in . And it's not possible to specify the path of at runtime. Steps to reproduce the behavior: a file, either manually or from a nix configuration. with . hasn't loaded any settings from . (It's easy to test if you fill with trash since it should log: ). It should be possible to configure all aspects of in the same way. BlueZ loads from a hardcoded path: The same is try for : The define is set to the package directory by default. For a symlink is setup, however no such link is setup for or : I wonder if a fix for this might be adding to the of BlueZ? There's no maintainer listed in , so I'm pinging the people who last touched it :) , Please run and paste the result.
I feel like this could be easily fixed rather in the by adding 2 more options for and under (?) Let me see if I can carve out some time later this week..
Fixed in

Related discussion:
text: environment.systemPackages = [ package ] ++ optional cfg.hsphfpd.enable pkgs.hsphfpd; <ins> environment.etc."bluetooth/input.conf".source = cfgFmt.generate "input.conf" cfg.input; environment.etc."bluetooth/network.conf".source = cfgFmt.generate "network.conf" cfg.network; </ins> environment.etc."bluetooth/main.conf".source = cfgFmt.generate "main.conf" (recursiveUpdate defaults cfg.settings); services.udev.packages = [ package ];
Code change:
BlueZ is currently setup to read auxiliary config files (i.e. , ) from its package directory, which makes it hard to write to them properly on a NixOS system. These configuration files are the only way to configure certain behaviours of , such as in , which is an important setting for device power saving. It's not possible to specify these options in . And it's not possible to specify the path of at runtime. Steps to reproduce the behavior: a file, either manually or from a nix configuration. with . hasn't loaded any settings from . (It's easy to test if you fill with trash since it should log: ). It should be possible to configure all aspects of in the same way. BlueZ loads from a hardcoded path: The same is try for : The define is set to the package directory by default. For a symlink is setup, however no such link is setup for or : I wonder if a fix for this might be adding to the of BlueZ? There's no maintainer listed in , so I'm pinging the people who last touched it :) , Please run and paste the result.
I feel like this could be easily fixed rather in the by adding 2 more options for and under (?) Let me see if I can carve out some time later this week..
Fixed in

Related discussion:
text: mkdir $out/etc/bluetooth ln -s /etc/bluetooth/main.conf $out/etc/bluetooth/main.conf <ins> # https://github.com/NixOS/nixpkgs/issues/204418 ln -s /etc/bluetooth/input.conf $out/etc/bluetooth/input.conf ln -s /etc/bluetooth/network.conf $out/etc/bluetooth/network.conf </ins> # Add missing tools, ref https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/bluez for files in `find tools/ -type f -perm -755`; do filename=$(basename $files)
Code change:
Build PHP on non-NixOS. Both PHP 5.6 and PHP 7 fail to build for the same reason. System: Debian Nixpkgs version: 16.09
Apparently, LDAP_xxx variables are ignored: This is output by Near
Damn, this is because I have LDAP on the host system.
Ok? This also helps PHP forget host and probably other stuff.
Are you building with sandboxing disabled? If so, I think this kind of stuff is to be expected.
I know this is kind of old, but it looks like the Travis build for failed due to this issue. Any reason that patch hasn't been applied? https://travis-

Related discussion:
text: ldap = { configureFlags = [ <del> "--with-ldap" </del> <ins> "--with-ldap=/invalid/path" </ins> "LDAP_DIR=${openldap.dev}" "LDAP_INCDIR=${openldap.dev}/include" "LDAP_LIBDIR=${openldap.out}/lib"
Code change:
I would like to use the dolibarr module without nginx. I plan to use caddy instead. In my NixOS configuration, I have . All the nginx-related settings in the dolibarr module are ignored if which is good. However, this line is not: I get the following output: This happens with simply adding to my config.
Opened for the fix, as I do not use any other web server beyond NGINX, I have no plan to maintain advanced integrations of other web servers, if you are interested into this, I will need another co-maintainer :).

Related discussion:
text: { config, pkgs, lib, ... }: let <del> inherit (lib) any boolToString concatStringsSep isBool isString literalExpression mapAttrsToList mkDefault mkEnableOption mkIf mkOption optionalAttrs types; </del> <ins> inherit (lib) any boolToString concatStringsSep isBool isString mapAttrsToList mkDefault mkEnableOption mkIf mkMerge mkOption optionalAttrs types; </ins> package = pkgs.dolibarr.override { inherit (cfg) stateDir; }; cfg = config.services.dolibarr; <del> vhostCfg = config.services.nginx.virtualHosts."${cfg.domain}"; </del> <ins> vhostCfg = lib.optionalAttr (cfg.nginx != null) config.services.nginx.virtualHosts."${cfg.domain}"; </ins> mkConfigFile = filename: settings: let
Code change:
I would like to use the dolibarr module without nginx. I plan to use caddy instead. In my NixOS configuration, I have . All the nginx-related settings in the dolibarr module are ignored if which is good. However, this line is not: I get the following output: This happens with simply adding to my config.
Opened for the fix, as I do not use any other web server beyond NGINX, I have no plan to maintain advanced integrations of other web servers, if you are interested into this, I will need another co-maintainer :).

Related discussion:
text: force_install_database = cfg.database.name; force_install_databaselogin = cfg.database.user; <del> force_install_mainforcehttps = vhostCfg.forceSSL; </del> <ins> force_install_mainforcehttps = vhostCfg.forceSSL or false; </ins> force_install_createuser = false; force_install_dolibarrlogin = null; } // optionalAttrs (cfg.database.passwordFile != null) {
Code change:
I would like to use the dolibarr module without nginx. I plan to use caddy instead. In my NixOS configuration, I have . All the nginx-related settings in the dolibarr module are ignored if which is good. However, this line is not: I get the following output: This happens with simply adding to my config.
Opened for the fix, as I do not use any other web server beyond NGINX, I have no plan to maintain advanced integrations of other web servers, if you are interested into this, I will need another co-maintainer :).

Related discussion:
text: }; # implementation <del> config = mkIf cfg.enable { </del> <ins> config = mkIf cfg.enable (mkMerge [ { </ins> assertions = [ { assertion = cfg.database.createLocally -> cfg.database.user == cfg.user;
Code change:
I would like to use the dolibarr module without nginx. I plan to use caddy instead. In my NixOS configuration, I have . All the nginx-related settings in the dolibarr module are ignored if which is good. However, this line is not: I get the following output: This happens with simply adding to my config.
Opened for the fix, as I do not use any other web server beyond NGINX, I have no plan to maintain advanced integrations of other web servers, if you are interested into this, I will need another co-maintainer :).

Related discussion:
text: # Security settings dolibarr_main_prod = true; <del> dolibarr_main_force_https = vhostCfg.forceSSL; </del> <ins> dolibarr_main_force_https = vhostCfg.forceSSL or false; </ins> dolibarr_main_restrict_os_commands = "${pkgs.mariadb}/bin/mysqldump, ${pkgs.mariadb}/bin/mysql"; dolibarr_nocsrfcheck = false; dolibarr_main_instance_unique_id = ''
Code change:
I would like to use the dolibarr module without nginx. I plan to use caddy instead. In my NixOS configuration, I have . All the nginx-related settings in the dolibarr module are ignored if which is good. However, this line is not: I get the following output: This happens with simply adding to my config.
Opened for the fix, as I do not use any other web server beyond NGINX, I have no plan to maintain advanced integrations of other web servers, if you are interested into this, I will need another co-maintainer :).

Related discussion:
text: users.groups = optionalAttrs (cfg.group == "dolibarr") { dolibarr = { }; }; <del> users.users."${config.services.nginx.group}".extraGroups = [ cfg.group ]; }; </del> <ins> } (mkIf (cfg.nginx != null) { users.users."${config.services.nginx.group}".extraGroups = mkIf (cfg.nginx != null) [ cfg.group ]; }) ]); </ins> }
Code change:
Upstream issue: Since the issue seems to be specific to NixOS, let's track it here. The two commands above should only print "True". If applicable, add screenshots to help explain your problem. Tested on xonsh 0.13.3 and 0.13.4 system: host os: multi-user?: sandbox: version: nixpkgs:
Upstream fix:

Related discussion:
text: }; package = lib.mkPackageOption pkgs "xonsh" { <del> example = "xonsh.override { extraPackages = ps: [ ps.requests ]; }"; </del> <ins> example = "xonsh.wrapper.override { extraPackages = ps: [ ps.requests ]; }"; </ins> }; config = lib.mkOption {
Code change:
Upstream issue: Since the issue seems to be specific to NixOS, let's track it here. The two commands above should only print "True". If applicable, add screenshots to help explain your problem. Tested on xonsh 0.13.3 and 0.13.4 system: host os: multi-user?: sandbox: version: nixpkgs:
Upstream fix:

Related discussion:
text: aliases['ls'] = _ls_alias del _ls_alias ${cfg.config} ''; environment.systemPackages = [ cfg.package ]; <del> environment.shells = [ "/run/current-system/sw/bin/xonsh" "${cfg.package}/bin/xonsh" ]; </del> <ins> environment.shells = [ "/run/current-system/sw/bin/xonsh" "${lib.getExe cfg.package}" ]; </ins> }; }
Code change:
Upstream issue: Since the issue seems to be specific to NixOS, let's track it here. The two commands above should only print "True". If applicable, add screenshots to help explain your problem. Tested on xonsh 0.13.3 and 0.13.4 system: host os: multi-user?: sandbox: version: nixpkgs:
Upstream fix:

Related discussion:
text: <del> { lib , coreutils , fetchFromGitHub , git , gitUpdater , glibcLocales , python3 }: let pname = "xonsh"; version = "0.15.1"; in python3.pkgs.buildPythonApplication { inherit pname version; pyproject = true; # fetch from github because the pypi package ships incomplete tests src = fetchFromGitHub { owner = "xonsh"; repo = "xonsh"; rev = "refs/tags/${version}"; hash = "sha256-mHOCkUGiSSPmkIQ4tgRZIaCTLgnx39SMwug5EIx/jrU="; }; nativeBuildInputs = with python3.pkgs; [ setuptools wheel ]; propagatedBuildInputs = with python3.pkgs; [ ply prompt-toolkit pygments ]; env.LC_ALL = "en_US.UTF-8"; postPatch = '' sed -ie "s|/bin/ls|${coreutils}/bin/ls|" tests/test_execer.py sed -ie "s|SHELL=xonsh|SHELL=$out/bin/xonsh|" tests/test_integrations.py sed -ie 's|/usr/bin/env|${coreutils}/bin/env|' tests/test_integrations.py sed -ie 's|/usr/bin/env|${coreutils}/bin/env|' scripts/xon.sh find scripts -name 'xonsh*' -exec sed -i -e "s|env -S|env|" {} ; find -name "*.xsh" | xargs sed -ie 's|/usr/bin/env|${coreutils}/bin/env|' patchShebangs . ''; disabledTests = [ # fails on sandbox "test_colorize_file" "test_loading_correctly" "test_no_command_path_completion" "test_bsd_man_page_completions" "test_xonsh_activator" # fails on non-interactive shells "test_capture_always" "test_casting" "test_command_pipeline_capture" "test_dirty_working_directory" "test_man_completion" "test_vc_get_branch" "test_bash_and_is_alias_is_only_functional_alias" ]; disabledTestPaths = [ # fails on sandbox "tests/completers/test_command_completers.py" "tests/test_ptk_highlight.py" "tests/test_ptk_shell.py" # fails on non-interactive shells "tests/prompt/test_gitstatus.py" "tests/completers/test_bash_completer.py" ]; nativeCheckInputs = [ git glibcLocales ] ++ (with python3.pkgs; [ pip pyte pytest-mock pytest-subprocess pytestCheckHook ]); preCheck = '' export HOME=$TMPDIR ''; dontWrapPythonPrograms = true; passthru = { shellPath = "/bin/xonsh"; python = python3; # To the wrapper updateScript = gitUpdater { }; }; meta =  { homepage = "https://xon.sh/"; description = "Python-ish, BASHwards-compatible shell"; changelog = "https://github.com/xonsh/xonsh/raw/${version}/CHANGELOG.rst"; license = with lib.licenses; [ bsd3 ]; maintainers = with lib.maintainers; [ AndersonTorres ]; }; } </del>
Code change:
Upstream issue: Since the issue seems to be specific to NixOS, let's track it here. The two commands above should only print "True". If applicable, add screenshots to help explain your problem. Tested on xonsh 0.13.3 and 0.13.4 system: host os: multi-user?: sandbox: version: nixpkgs:
Upstream fix:

Related discussion:
text: <ins> { lib, runCommand, xonsh, # configurable options extraPackages ? (ps: [ ]), }: let inherit (xonsh.passthru) python; pythonEnv = python.withPackages (ps: [ (ps.toPythonModule xonsh) ] ++ extraPackages ps); in runCommand "xonsh-wrapped-${xonsh.version}" { inherit (xonsh) pname version meta passthru; } '' mkdir -p $out/bin for bin in ${lib.getBin xonsh}/bin/*; do ln -s ${pythonEnv}/bin/$(basename "$bin") $out/bin/ done '' </ins>
Code change:
Upstream issue: Since the issue seems to be specific to NixOS, let's track it here. The two commands above should only print "True". If applicable, add screenshots to help explain your problem. Tested on xonsh 0.13.3 and 0.13.4 system: host os: multi-user?: sandbox: version: nixpkgs:
Upstream fix:

Related discussion:
text: xineLib = xine-lib; # Added 2021-04-27 xineUI = xine-ui; # Added 2021-04-27 xmlada = gnatPackages.xmlada; # Added 2024-02-25 <del> xonsh-unwrapped = xonsh.passthru.unwrapped; </del> <ins> xonsh-unwrapped = python3Packages.xonsh; # Added 2024-06-18 </ins> xtrt = throw "xtrt has been removed due to being abandoned"; # Added 2023-05-25 xulrunner = firefox-unwrapped; # Added 2023-11-03 xvfb_run = xvfb-run; # Added 2021-05-07
Code change:
Upstream issue: Since the issue seems to be specific to NixOS, let's track it here. The two commands above should only print "True". If applicable, add screenshots to help explain your problem. Tested on xonsh 0.13.3 and 0.13.4 system: host os: multi-user?: sandbox: version: nixpkgs:
Upstream fix:

Related discussion:
text: xnd = callPackage ../development/python-modules/xnd { }; <ins> xonsh = toPythonModule (pkgs.xonsh.override { python3Packages = self; }); </ins> xpath-expressions = callPackage ../development/python-modules/xpath-expressions { }; xpybutil = callPackage ../development/python-modules/xpybutil { };
Code change:
The build fails in the test phase when CUDA is enabled with errors like this: Note that the did not have this problem. Steps to reproduce the behavior:
I've played around a little bit and couldn't get it working. The problems is that the CUDA drivers are available at runtime in but not in the cudatoolkit. I've symlinked and then the library is found but CUDA is not running properly in the sandbox (). I've looked around somewhat and neither Torch, nor Tensorflow, nor Numba, ... have CUDA tests running in their respective expressions. I would assume for exactly this reasons. I suggest to just disable the CUDA tests and have them running for CPU only.
That sounds reasonable.

Related discussion:
text: , fftwSinglePrec , doxygen , swig <del> , python3Packages, enablePython ? false , opencl-headers, ocl-icd, enableOpencl ? false , clang, enableClang ? true , cudatoolkit, enableCuda ? false </del> <ins> , enablePython ? false , python3Packages , enableOpencl ? true , opencl-headers , ocl-icd , enableCuda ? false , cudaPackages , addOpenGLRunpath </ins> }: stdenv.mkDerivation rec {
Code change:
The build fails in the test phase when CUDA is enabled with errors like this: Note that the did not have this problem. Steps to reproduce the behavior:
I've played around a little bit and couldn't get it working. The problems is that the CUDA drivers are available at runtime in but not in the cudatoolkit. I've symlinked and then the library is found but CUDA is not running properly in the sandbox (). I've looked around somewhat and neither Torch, nor Tensorflow, nor Numba, ... have CUDA tests running in their respective expressions. I would assume for exactly this reasons. I suggest to just disable the CUDA tests and have them running for CPU only.
That sounds reasonable.

Related discussion:
text: serialization/tests/TestSerializeIntegrator.cpp ''; <del> nativeBuildInputs = [ cmake gfortran swig doxygen python3Packages.python ]; </del> <ins> nativeBuildInputs = [ cmake gfortran swig doxygen python3Packages.python ] ++ lib.optional enableCuda addOpenGLRunpath; </ins> buildInputs = [ fftwSinglePrec ] ++ lib.optionals enableOpencl [ ocl-icd opencl-headers ] <del> ++ lib.optional enableCuda cudatoolkit; </del> <ins> ++ lib.optional enableCuda cudaPackages.cudatoolkit; </ins> propagatedBuildInputs = lib.optionals enablePython (with python3Packages; [ python