jiebi/CodeConvo huggingface dataset:
Code change:
Package name: fluent-gtk-theme Latest released version: 2024-04-28 <!-- Search your package here: --- Current version on the unstable channel: 2023-06-20 Current version on the stable/release channel: 2023-06-20 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: passthru.updateScript = gitUpdater { }; <del> meta = with lib; { </del> <ins> meta = { </ins> description = "Fluent design gtk theme"; homepage = "https://github.com/vinceliuice/Fluent-gtk-theme"; <del> license = licenses.gpl3Only; platforms = platforms.unix; maintainers = [ maintainers.romildo ]; </del> <ins> license = lib.licenses.gpl3Only; platforms = lib.platforms.unix; maintainers = with lib.maintainers; [ romildo ]; </ins> }; <del> } </del> <ins> }) </ins>
Code change:
uses and to convert PCI device ID to human-readable product name. Currently their paths are hard coded as and . It won't work with NixOS of course. I found some packages that have similar issues. They are patched directly before building: Fastfetch needs to be patched too. Steps to reproduce the behavior: N/A Fastfetch can properly find and N/A Reference: Fastfetch provided cmake config option  for but not for . I can add one if needed. N/A Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hi thanks for the detailed issue report! This should be pretty straightforward to fix. If you could add a config option for the path that would be great! Many thanks.
.
was released with support
Many thanks! Much appreciated.

Related discussion:
text: , hwdata , imagemagick_light , libXrandr <ins> , libdrm </ins> , libglvnd , libpulseaudio , libselinux
Code change:
uses and to convert PCI device ID to human-readable product name. Currently their paths are hard coded as and . It won't work with NixOS of course. I found some packages that have similar issues. They are patched directly before building: Fastfetch needs to be patched too. Steps to reproduce the behavior: N/A Fastfetch can properly find and N/A Reference: Fastfetch provided cmake config option  for but not for . I can add one if needed. N/A Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hi thanks for the detailed issue report! This should be pretty straightforward to fix. If you could add a config option for the path that would be great! Many thanks.
.
was released with support
Many thanks! Much appreciated.

Related discussion:
text: in stdenv'.mkDerivation (finalAttrs: { pname = "fastfetch"; <del> version = "2.11.0"; </del> <ins> version = "2.11.3"; </ins> src = fetchFromGitHub { owner = "fastfetch-cli"; repo = "fastfetch"; rev = finalAttrs.version; <del> hash = "sha256-/j0dRnApP5PQV4qVkqM6WlFdSZHlBTheaoWXSd2YP5k="; </del> <ins> hash = "sha256-kKtJvGnPncosmwjfTKa14G5jQiSkzkURBATvBmavdys="; </ins> }; outputs = [ "out" "man" ];
Code change:
uses and to convert PCI device ID to human-readable product name. Currently their paths are hard coded as and . It won't work with NixOS of course. I found some packages that have similar issues. They are patched directly before building: Fastfetch needs to be patched too. Steps to reproduce the behavior: N/A Fastfetch can properly find and N/A Reference: Fastfetch provided cmake config option  for but not for . I can add one if needed. N/A Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hi thanks for the detailed issue report! This should be pretty straightforward to fix. If you could add a config option for the path that would be great! Many thanks.
.
was released with support
Many thanks! Much appreciated.

Related discussion:
text: ddcutil glib hwdata <ins> libdrm </ins> libpulseaudio libselinux libsepol
Code change:
uses and to convert PCI device ID to human-readable product name. Currently their paths are hard coded as and . It won't work with NixOS of course. I found some packages that have similar issues. They are patched directly before building: Fastfetch needs to be patched too. Steps to reproduce the behavior: N/A Fastfetch can properly find and N/A Reference: Fastfetch provided cmake config option  for but not for . I can add one if needed. N/A Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hi thanks for the detailed issue report! This should be pretty straightforward to fix. If you could add a config option for the path that would be great! Many thanks.
.
was released with support
Many thanks! Much appreciated.

Related discussion:
text: (lib.cmakeBool "ENABLE_XCB_RANDR" x11Support) (lib.cmakeBool "ENABLE_XFCONF" (x11Support && (!stdenv.isDarwin))) (lib.cmakeBool "ENABLE_XRANDR" x11Support) <ins> ] ++ lib.optionals stdenv.isLinux [ (lib.cmakeOptionType "filepath" "CUSTOM_PCI_IDS_PATH" "${hwdata}/share/hwdata/pci.ids") (lib.cmakeOptionType "filepath" "CUSTOM_AMDGPU_IDS_PATH" "${libdrm}/share/libdrm/amdgpu.ids") </ins> ]; postInstall = ''
Code change:
On nixpkgs commit , running Tailscale with Tailscale SSH connected, then trying to connect to it, results in an error: . Steps to reproduce the behavior: the tailscale node service with (in my case, using a systemd service). to use Tailscale SSH to access the node (e.g. ). that no shell is opened and the connection is closed immediately. A shell opens (if the default SSH behavior is unchanged). This appears to the result of The underlying patch sets the systemd hardening option , along with an allowlist of devices. This prevents from accessing , which is needed to open a PTY for the shell. Please run and paste the result.

Related discussion:
text: , shadow , procps , nixosTests <del> , fetchpatch </del> }: let
Code change:
On nixpkgs commit , running Tailscale with Tailscale SSH connected, then trying to connect to it, results in an error: . Steps to reproduce the behavior: the tailscale node service with (in my case, using a systemd service). to use Tailscale SSH to access the node (e.g. ). that no shell is opened and the connection is closed immediately. A shell opens (if the default SSH behavior is unchanged). This appears to the result of The underlying patch sets the systemd hardening option , along with an allowlist of devices. This prevents from accessing , which is needed to open a PTY for the shell. Please run and paste the result.

Related discussion:
text: }; vendorHash = "sha256-pYeHqYd2cCOVQlD1r2lh//KC+732H0lj1fPDBr+W8qA="; <del> patches = [ # Reverts "cmd/tailscaled/tailscaled.service: revert recent hardening" (fetchpatch { url = "https://github.com/tailscale/tailscale/commit/2889fabaefc50040507ead652d6d2b212f476c2b.patch"; hash = "sha256-DPBrv7kjSVXhmptUGGzOkaP4iXi/Bym3lvqy4otL9HE="; revert = true; }) ]; </del> nativeBuildInputs = lib.optionals stdenv.isLinux [ makeWrapper ]; CGO_ENABLED = 0;
Code change:
Affects our 3.12.17, 3.13.10 and 3.14.1.
Only 3.13 is vulnerable now, but I don't know what to do about it. Personally I'd drop it, but it's also possible to follow the Ubuntu-maintained branch if people care for it, or just leave it as it is...
Removing 3.13 is fine - we were going to initially keep it because grsecurity was going to use it, but it looks like they've chosen the 3.14 kernel instead.
I have no idea if anyone else can depend on it, but reverting will be easy.
After finishing build tests locally, I'll push to release and close this.
Well, doesn't build on release (it does on master), but it's probably not worth debugging. The rest builds fine.

Related discussion:
text: import ./generic.nix ( rec { <del> version = "3.4.2"; </del> <ins> version = "3.4.4"; </ins> testing = false; preConfigure = ''
Code change:
Affects our 3.12.17, 3.13.10 and 3.14.1.
Only 3.13 is vulnerable now, but I don't know what to do about it. Personally I'd drop it, but it's also possible to follow the Ubuntu-maintained branch if people care for it, or just leave it as it is...
Removing 3.13 is fine - we were going to initially keep it because grsecurity was going to use it, but it looks like they've chosen the 3.14 kernel instead.
I have no idea if anyone else can depend on it, but reverting will be easy.
After finishing build tests locally, I'll push to release and close this.
Well, doesn't build on release (it does on master), but it's probably not worth debugging. The rest builds fine.

Related discussion:
text: src = fetchurl { url = "mirror://kernel/linux/kernel/v3.x/${if testing then "testing/" else ""}linux-${version}.tar.xz"; <del> sha256 = "0pd96g1qcp2wgdnvk79hljjrpr6xjk0159lks47n181a3yirzf4x"; </del> <ins> sha256 = "0l4h7amhsmgpnii8rgwi32nd7ajsifk2xckjd39pfzwdifacw5yw"; </ins> }; config = configWithPlatform stdenv.platform;
Code change:
Updating my falke to latest nixpkgs unstable gives an error that vault is non-free. But my package doesn't use or need vault. My package at has: This gives the error: If I comment out the it works. Steps to reproduce the behavior: to use nixpkgs-unstable instead of nixpkgs 23.11 Should build without errors. As above. ` Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
helm-secrets depends on vault
What happened to vault? It use to be open source I thought. Did the license change?
Does helm-secrets really depend on vault? From the it says: Which seems to indicate that it should be able to use any secret manager, not just vault.
the vault license change, which sparked quite the outrage. you ask a question and follow with the answer, that's both rare and impressive ^^'' You can see it here: I suggest you follow the recommendation and accept the new license for vault. If you dont need it, you can remove support for it as well from helm-secrets (but will require some nix skills though you can search the web for plenty of examples)
How about switching the dependency from vault to OpenBAO - would that be possible?
Heh, I didn't realize LF forked Vault too. :popcorn: It's certainly possible, but might have unintended side effects for Nix users. (I realize how annoying that might sound, given your recent experience.) By default, helm-secrets supports and . After a quick glance, it looks like both sops and vals use the Vault Go library, so maybe we don't even need at runtime anyway... I wonder if sops and vals will have to alter their licenses... Edit: It seems the is still .
I've just tried a modified helm-secrets derivation, removing all references to , against a repo that uses helm-secrets (with AWS KMS backend) and it worked fine. I then switched the config to point use a Vault backend, and that also worked. Note that I used to get a token, but assuming exists or the env var is set somehow, it seems doesn't need a binary at runtime at all. So, I suggest we drop the dependency.
might you be able to test It Works on my Machine, and I'm fairly confident, but I'd love some additional verification.
It seems to work OK on my system, so far. Don't have a good test case for vault though. Will think about additional ways to test this.

Related discussion:
text: <del> { lib, stdenv, fetchFromGitHub, makeWrapper, coreutils, findutils, getopt, gnugrep, gnused, sops, vault }: </del> <ins> { lib, stdenv, fetchFromGitHub, makeWrapper, coreutils, findutils, getopt, gnugrep, gnused, sops }: </ins> stdenv.mkDerivation rec { pname = "helm-secrets";
Code change:
Updating my falke to latest nixpkgs unstable gives an error that vault is non-free. But my package doesn't use or need vault. My package at has: This gives the error: If I comment out the it works. Steps to reproduce the behavior: to use nixpkgs-unstable instead of nixpkgs 23.11 Should build without errors. As above. ` Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
helm-secrets depends on vault
What happened to vault? It use to be open source I thought. Did the license change?
Does helm-secrets really depend on vault? From the it says: Which seems to indicate that it should be able to use any secret manager, not just vault.
the vault license change, which sparked quite the outrage. you ask a question and follow with the answer, that's both rare and impressive ^^'' You can see it here: I suggest you follow the recommendation and accept the new license for vault. If you dont need it, you can remove support for it as well from helm-secrets (but will require some nix skills though you can search the web for plenty of examples)
How about switching the dependency from vault to OpenBAO - would that be possible?
Heh, I didn't realize LF forked Vault too. :popcorn: It's certainly possible, but might have unintended side effects for Nix users. (I realize how annoying that might sound, given your recent experience.) By default, helm-secrets supports and . After a quick glance, it looks like both sops and vals use the Vault Go library, so maybe we don't even need at runtime anyway... I wonder if sops and vals will have to alter their licenses... Edit: It seems the is still .
I've just tried a modified helm-secrets derivation, removing all references to , against a repo that uses helm-secrets (with AWS KMS backend) and it worked fine. I then switched the config to point use a Vault backend, and that also worked. Note that I used to get a token, but assuming exists or the env var is set somehow, it seems doesn't need a binary at runtime at all. So, I suggest we drop the dependency.
might you be able to test It Works on my Machine, and I'm fairly confident, but I'd love some additional verification.
It seems to work OK on my system, so far. Don't have a good test case for vault though. Will think about additional ways to test this.

Related discussion:
text: install -m644 -Dt $out/${pname} plugin.yaml cp -r scripts/* $out/${pname}/scripts wrapProgram $out/${pname}/scripts/run.sh  <del> --prefix PATH : ${lib.makeBinPath [ coreutils findutils getopt gnugrep gnused sops vault ]} </del> <ins> --prefix PATH : ${lib.makeBinPath [ coreutils findutils getopt gnugrep gnused sops ]} </ins> runHook postInstall '';
Code change:
After installation notation shell completion is not available. Steps to reproduce the behavior: notation completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <del> { lib, buildGoModule, fetchFromGitHub, testers, notation }: </del> <ins> { lib, buildGoModule, fetchFromGitHub, installShellFiles, testers, notation }: </ins> buildGoModule rec { pname = "notation";
Code change:
After installation notation shell completion is not available. Steps to reproduce the behavior: notation completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: vendorHash = "sha256-USkufc1dG4eyRfRJHSX4mVZHnvOc5onHenF98Aedac4="; <ins> nativeBuildInputs = [ installShellFiles ]; </ins> # This is a Go sub-module and cannot be built directly (e2e tests). excludedPackages = [ "./test" ];
Code change:
After installation notation shell completion is not available. Steps to reproduce the behavior: notation completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: "-X github.com/notaryproject/notation/internal/version.BuildMetadata=" ]; <ins> postInstall = '' installShellCompletion --cmd notation  --bash <($out/bin/notation completion bash)  --fish <($out/bin/notation completion fish)  --zsh <($out/bin/notation completion zsh) ''; </ins> passthru.tests.version = testers.testVersion { package = notation; command = "notation version";
Code change:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <del> { lib , buildGoModule , fetchFromGitHub }: buildGoModule rec { pname = "kcl-cli"; version = "0.8.9"; src = fetchFromGitHub { owner = "kcl-lang"; repo = "cli"; rev = "v${version}"; hash = "sha256-slU3n7YCV5VfvXArzlcITb9epdu/gyXlAWq9KLjGdJA="; }; vendorHash = "sha256-Xv8Tfq9Kb1xGFCWZQwBFDX9xZW9j99td/DUb7jBtkpE="; ldflags = [ "-X=kcl-lang.io/cli/pkg/version.version=${version}" ]; subPackages = [ "cmd/kcl" ]; meta = with lib; { description = "Command line interface for KCL programming language"; homepage = "https://github.com/kcl-lang/cli"; license = licenses.asl20; maintainers = with maintainers; [ peefy ]; mainProgram = "kcl"; }; } </del>
Code change:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <ins> { lib , buildGoModule , fetchFromGitHub , kclvm_cli , kclvm , makeWrapper , installShellFiles , }: buildGoModule rec { pname = "kcl"; version = "0.8.9"; src = fetchFromGitHub { owner = "kcl-lang"; repo = "cli"; rev = "v${version}"; hash = "sha256-slU3n7YCV5VfvXArzlcITb9epdu/gyXlAWq9KLjGdJA="; }; vendorHash = "sha256-Xv8Tfq9Kb1xGFCWZQwBFDX9xZW9j99td/DUb7jBtkpE="; ldflags = [ "-w -s" "-X=kcl-lang.io/cli/pkg/version.version=v${version}" ]; nativeBuildInputs = [ makeWrapper installShellFiles ]; buildInputs = [ kclvm kclvm_cli ]; subPackages = [ "cmd/kcl" ]; # env vars https://github.com/kcl-lang/kcl-go/blob/main/pkg/env/env.go#L29 postFixup = '' wrapProgram $out/bin/kcl  --set PATH ${lib.makeBinPath [kclvm_cli]}  --set KCL_LIB_HOME ${lib.makeLibraryPath [kclvm]}  --set KCL_GO_DISABLE_INSTALL_ARTIFACT false  ''; postInstall = '' installShellCompletion --cmd kcl  --bash <($out/bin/kcl completion bash)  --fish <($out/bin/kcl completion fish)  --zsh <($out/bin/kcl completion zsh) ''; meta = with lib; { description = "A command line interface for KCL programming language"; homepage = "https://github.com/kcl-lang/cli"; license = licenses.asl20; platforms = platforms.linux; maintainers = with maintainers; [ selfuryon peefy ]; mainProgram = "kcl"; }; } </ins>
Code change:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <ins> diff --git a/api/build.rs b/api/build.rs index 617c1b9a..20d728e3 100644 --- a/api/build.rs +++ b/api/build.rs @@ -5,10 +5,10 @@ use prost_wkt_build::{FileDescriptorSet, Message}; /// According to the file kclvm/spec/gpyrpc/gpyrpc.proto, automatically generate /// the corresponding rust source file to the directory src/model fn main() { -    std::env::set_var( -        "PROTOC", -        protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), -    ); +    // std::env::set_var( +    //     "PROTOC", +    //     protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), +    // ); let out = PathBuf::from(env::var("OUT_DIR").unwrap()); let descriptor_file = out.join("kclvm_service_descriptor.bin"); diff --git b/third-party/prost-wkt/wkt-types/build.rs a/third-party/prost-wkt/wkt-types/build.rs index e49222d5..a933ddf4 100644 --- a/third-party/prost-wkt/wkt-types/build.rs +++ b/third-party/prost-wkt/wkt-types/build.rs @@ -13,10 +13,10 @@ use regex::Regex; fn main() { //hack: set protoc_bin_vendored::protoc_bin_path() to PROTOC -    std::env::set_var( -        "PROTOC", -        protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), -    ); +    // std::env::set_var( +    //     "PROTOC", +    //     protoc_bin_vendored::protoc_bin_path().unwrap().as_os_str(), +    // ); let dir = PathBuf::from(env::var("OUT_DIR").unwrap()); process_prost_pbtime(&dir); </ins>
Code change:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <ins> { lib , rustPlatform , fetchFromGitHub , protobuf , pkg-config , }: rustPlatform.buildRustPackage rec { pname = "kclvm"; version = "0.8.7"; src = fetchFromGitHub { owner = "kcl-lang"; repo = "kcl"; rev = "v${version}"; hash = "sha256-ieGpuNkzT6AODZYUcEanb7Jpb+PXclnQ9KkdmlehK0o="; }; sourceRoot = "source/kclvm"; cargoLock = { lockFile = ./Cargo.lock; outputHashes = { "inkwell-0.2.0" = "sha256-JxSlhShb3JPhsXK8nGFi2uGPp8XqZUSiqniLBrhr+sM="; }; }; nativeBuildInputs = [ pkg-config protobuf ]; patches = [ ./enable_protoc_env.patch ]; PROTOC = "${protobuf}/bin/protoc"; PROTOC_INCLUDE = "${protobuf}/include"; meta = with lib; { description = "A high-performance implementation of KCL written in Rust that uses LLVM as the compiler backend"; homepage = "https://github.com/kcl-lang/kcl"; license = licenses.asl20; platforms = platforms.linux; maintainers = with maintainers; [ selfuryon peefy ]; }; } </ins>
Code change:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <ins> # This file is automatically @generated by Cargo. # It is not intended for manual editing. version = 3 [[package]] name = "kclvm_cli" version = "0.8.7" </ins>
Code change:
After installation kcl-cli shell completion is not available. Steps to reproduce the behavior: kcl-cli completion Shell completion should be installed. N/A N/A <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Related discussion:
text: <ins> --- /dev/null	2024-03-29 17:01:59.989114590 +0100 +++ cli/Cargo.lock	2024-04-17 13:27:32.243365234 +0200 @@ -0,0 +1,7 @@ +# This file is automatically @generated by Cargo. +# It is not intended for manual editing. +version = 3 + +[[package]] +name = "kclvm_cli" +version = "0.8.7" </ins>