jiebi/CodeConvo huggingface dataset:
Code change:
<literal>freetype</literal> and others. </para> </listitem> <ins> <listitem> <para> .NET 5.0 was removed due to being end-of-life, use a newer, supported .NET version - https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core </para> </listitem> </ins> </itemizedlist> </section> <section xml:id="sec-release-23.05-notable-changes">

Related discussion:
text: Since May 10, .NET 5.0 is EOL (End Of Life), and should not be used. Should it be marked as EOF similar to dotnet 2.2 and 3.0? See All packages using dotnet 5.0 should be updated to use a newer, supported version. These packages still need updating: [x] - [x] - [x] - [x] pkgs/development/tools/build- - [x] -
There is at least one package, which currently uses dotnet 5 sdk - . So we will need to update it beforehand. Btw, I'm not sure if we have any policy regarding packages removal, for nixpkgs in general or specifically for it's dotnet part. , what do you think?
The package is also using .NET 5: . But this is because I made the PR upstream updating it from .NET 4 to 5. I suspect that the transition to 6 will be similarly easy.
I think we should just mark it as depricated, as many projects do still use it upstream. Dotnet version 3 is also still commonly used, so I dont expect it would be realistic to remove version 5 any time soon. also uses dotnet 5 by default, I'll go ahead and switch that over now. See . That doesnt mark dotnet 5 as deprecated or change anything from a SDK perspective, just some preperation work.
See as well, it adds a warning whenever dotnet version 5 is used. Not using a throw for now since a few packages depend on it and I dont have the time to clean that all up at the moment.
Can you provide a list of packages that need updating?
Based on a quick grep: pkgs/development/tools/build-
I believe that after all the above PRs are merged, we should be able to safely remove .NET 5 from nixpkgs :)
Code change:
--replace "= gcc" "=${stdenv.cc.targetPrefix}cc"  --replace "= g++" "=${stdenv.cc.targetPrefix}c++"  --replace "-DGNU_RUNTIME=1" ""  <del> --replace "-fgnu-runtime" "-fobjc-nonfragile-abi" </del> <ins> --replace "-fgnu-runtime" "-fobjc-runtime=gnustep-2.0" </ins> done # we need to build inside this directory as well, so we have to make it writeable

Related discussion:
text: Steps to reproduce the behavior: unar from Full build: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
This could be related to GNUstep being updated??
Yes, that PR is the cause.
Ouch, sorry. Could've sworn I ran nixpkgs-review against it, but maybe I didn't. I'll try to see what I can do, although maybe only next week. We can also revert, if I can't find the time or nobody else comes up with a fix.
For the status on Hydra:
Code change:
githubId = 15693688; name = "Lucas Eduardo Wendt"; }; <ins> lucastso10 = { email = "lucastso10@gmail.com"; github = "lucastso10"; githubId = 84486266; name = "Lucas Teixeira Soares"; }; </ins> lucc = { email = "lucc+nix@posteo.de"; github = "lucc";

Related discussion:
text: Project description Granian is a Rust HTTP server for Python ASGI/WSGI/RSGI applications. It fulfills a similar purpose as daphne, gunicorn, uvicorn or uwsgi, but . Metadata homepage URL: source URL: license: bsd3 platforms: unix Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
machine.succeed( """ find /boot -iname '*.efi' -print0 |  <del> xargs -0 -I '{}' sed -i 's/#### LoaderInfo: systemd-boot .* ####/#### LoaderInfo: systemd-boot 001 ####/' '{}' </del> <ins> xargs -0 -I '{}' sed -i 's/#### LoaderInfo: systemd-boot .* ####/#### LoaderInfo: systemd-boot 000.0-1-notnixos ####/' '{}' </ins> """ ) output = machine.succeed("/run/current-system/bin/switch-to-configuration boot") <del> assert "updating systemd-boot from 001 to " in output </del> <ins> assert "updating systemd-boot from (000.0-1-notnixos) to " in output </ins> ''; }; }

Related discussion:
text: shows this for me: When I try to upgrade my system, I get the error “could not find any previously installed systemd-boot”. This is because the script can't deal with systemd-boot versions with a minor version appended to it, since the regex is : Fixing this is not quite straightforward sadly, since the version is later used for comparison, so fixing this requires adding support for proper major/minor version comparison in this script. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --??? Please run and paste the result. Maintainer information:
related
Code change:
let <del> execFormatIsELF = platform: platform.parsed.kernel.execFormat.name == "elf"; </del> <ins> withGold = platform: platform.parsed.kernel.execFormat.name == "elf" && !platform.isRiscV; </ins> in { stdenv

Related discussion:
text: Despite the bintools for riscv64-linux advertises the existence of , it is actually missing. Steps to reproduce the behavior: , returns the output, there is only , no the same process for , is both advertised and available. Either evaluates to , or is available in <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --
Looking at ;a=blob;;h=;hb=HEAD is not supported on riscv64. tracks it upstream. I don't expect progress implementing the support any time soon.
Then we should accept the second solution: mark as false, we should also double check the availability of gold on other ELF platforms.
Code change:
<ins> { lib, buildPythonPackage, fetchFromGitHub, poetry-core, pytestCheckHook, }: buildPythonPackage { pname = "bpylist2"; version = "4.1.1"; pyproject = true; src = fetchFromGitHub { owner = "parabolala"; repo = "bpylist2"; rev = "ddb89e0b0301c6b298de6469221d99b5fe127b58"; hash = "sha256-OBwDQZL5++LZgpQM96tmplAh1Pjme3KGSNFTKqKUn00="; }; build-system = [ poetry-core ]; pythonImportsCheck = [ "bpylist2" ]; nativeCheckInputs = [ pytestCheckHook ]; postPatch = '' substituteInPlace setup.cfg  --replace-fail "--pycodestyle" ""  --replace-fail "--pylint --pylint-rcfile=pylint.rc" ""  --replace-fail "--mypy" "" ''; meta = { description = "Parse and Generate binary plists and NSKeyedArchiver archives"; license = lib.licenses.mit; homepage = "https://github.com/parabolala/bpylist2"; maintainers = with lib.maintainers; [ sigmanificient ]; }; } </ins>

Related discussion:
text: Project description Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata. Metadata homepage URL: source URL: license: mit platforms: unix, linux, darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
This was the most complex package i ever tried to write :sweat_smile:
Code change:
stdenv.mkDerivation rec { pname = "invoiceplane"; <del> version = "1.5.11"; </del> <ins> version = "1.6-beta-1"; </ins> src = fetchurl { url = "https://github.com/InvoicePlane/InvoicePlane/releases/download/v${version}/v${version}.zip"; <del> sha256 = "137g0xps4kb3j7f5gz84ql18iggbya6d9dnrfp05g2qcbbp8kqad"; </del> <ins> sha256 = "sha256-hIbk9zzqbwv2kSFClgPfTObB1YHj7KR4swKjGoN2v2E="; </ins> }; <del> patches = [ # Fix CVE-2021-29024, unauthenticated directory listing # Should be included in a later release > 1.5.11 # https://github.com/NixOS/nixpkgs/issues/166655 # https://github.com/InvoicePlane/InvoicePlane/pull/754 (fetchpatch { url = "https://patch-diff.githubusercontent.com/raw/InvoicePlane/InvoicePlane/pull/754.patch"; sha256 = "sha256-EHXw7Zqli/nA3tPIrhxpt8ueXvDtshz0XRzZT78sdQk="; }) # Fix CVE-2021-29023, password reset rate-limiting # Should be included in a later release > 1.5.11 # https://github.com/NixOS/nixpkgs/issues/166655 # https://github.com/InvoicePlane/InvoicePlane/pull/739 (fetchpatch { url = "https://patch-diff.githubusercontent.com/raw/InvoicePlane/InvoicePlane/pull/739.patch"; sha256 = "sha256-6ksJjW6awr3lZsDRxa22pCcRGBVBYyV8+TbhOp6HBq0="; }) # Fix CVE-2021-29022, full path disclosure # Should be included in a later release > 1.5.11 # https://github.com/NixOS/nixpkgs/issues/166655 # https://github.com/InvoicePlane/InvoicePlane/pull/767 #(fetchpatch { #  url = "https://patch-diff.githubusercontent.com/raw/InvoicePlane/InvoicePlane/pull/767.patch"; #  sha256 = "sha256-rSWDH8KeHSRWLyQEa7RSwv+8+ja9etTz+6Q9XThuwUo="; #}) ]; </del> nativeBuildInputs = [ unzip ]; sourceRoot = "."; installPhase = '' mkdir -p $out/ <del> cp -r . $out/ </del> <ins> cp -r ip/. $out/ </ins> ''; passthru.tests = {

Related discussion:
text: , CVSSv3=7.5 (nixos-unstable) CVSSv3=5.3 (nixos-unstable) CVSSv3=5.3 (nixos-unstable) In InvoicePlane 1.5.11 a misconfigured web server allows unauthenticated directory listing and file download. Allowing an attacker to directory traversal and download files suppose to be private without authentication. In InvoicePlane 1.5.11, the upload feature discloses the full path of the file upload directory. InvoicePlane 1.5.11 doesn't have any rate-limiting for password reset and the reset token is generated using a weak mechanism that is predictable. Scanned versions: nixos-unstable: . Cc
Code change:
preInstall = '' substituteInPlace src/cmake_install.cmake  --replace ${fcitx} $out <del> substituteInPlace po/cmake_install.cmake  --replace ${fcitx} $out </del> substituteInPlace data/cmake_install.cmake  --replace ${fcitx} $out substituteInPlace dictmanager/cmake_install.cmake 

Related discussion:
text: Describe the bug fcitx-qt5 fails to build on unstable: To Reproduce Metadata nixos unstable
It's trying to install into qtbase . Probably should set this to be within the proper prefix.
yep I've seen that as well. Seems like some packages set to work around this but haven't had the time to test it yet. EDIT: that fixed the first problem but not the second one:
will fix this.
This is still an issue on stable -- Installing: /nix/store/phkl5sfpn4jvncjd2sa29g182gpmmja7-fcitx-qt5-1.2.3/share/locale/zhCN/LCMESSAGES/fcitx- -- Installing: /nix/store/phkl5sfpn4jvncjd2sa29g182gpmmja7-fcitx-qt5-1.2.3/share/locale/zhTW/LCMESSAGES/fcitx- -- Installing: /nix/store/g83143pyn6sc1x1nqqjcamap4c2b1rbw-qtbase-5.12.0-bin/lib/qt- CMake Error at (file): file INSTALL cannot copy file "" to "/nix/store/g83143pyn6sc1x1nqqjcamap4c2b1rbw-qtbase-5.12.0-bin/lib/qt-".
Code change:
preInstall = '' substituteInPlace src/cmake_install.cmake  --replace ${fcitx} $out <del> substituteInPlace po/cmake_install.cmake  --replace ${fcitx} $out </del> substituteInPlace data/cmake_install.cmake  --replace ${fcitx} $out substituteInPlace dictmanager/cmake_install.cmake 

Related discussion:
text: Call Stack (most recent call first): (include) make: * [Makefile:106: install] Error 1 builder for '/nix/store/ypfmrmajq452nmskg0ffwa27hm58l492-fcitx-qt5-' failed with exit code 2 cannot build derivation '/nix/store/hdsvn6hc7h7wf29kdnpvr7iaivplyyb8-fcitx-with-plugins-': 1 dependencies couldn't be built cannot build derivation '/nix/store/4lwxfbacn5fcymlm3jpv6wl4anllxmzd-system-': 1 dependencies couldn't be built cannot build derivation '/nix/store/d4k8dywj47xrbxfmvdaw4gywnwdn874r-xsession-': 1 dependencies couldn't be built cannot build derivation '/nix/store/fj8xinm3fjd7sp9s20iqg23yx27zc193-nixos-system-voyagertwo-': 1 dependencies couldn't be built error: build of '/nix/store/fj8xinm3fjd7sp9s20iqg23yx27zc193-nixos-system-voyagertwo-' failed Note that I have a following setting in environment.extraOutputsToInstall = ["out"]; environment.pathsToLink = [ "/share/locale" ];
:confused: Didn't expect that to broken the same way on stable. please open a separate issue requesting some sort of backport for the relevant commit
Still seems to fail on unstable?
Code change:
<del> {stdenv, fetchurl, fetchpatch, libtool, libjpeg, openssl, zlib, libgcrypt, autoreconfHook, pkgconfig, libpng, systemd </del> <ins> { stdenv, fetchzip, fetchpatch, cmake , libjpeg, openssl, zlib, libgcrypt, libpng , systemd </ins> }: let s = # Generated upstream information rec { <del> baseName="libvncserver"; version="0.9.11"; name="${baseName}-${version}"; url="https://github.com/LibVNC/libvncserver/archive/LibVNCServer-${version}.tar.gz"; sha256="15189n09r1pg2nqrpgxqrcvad89cdcrca9gx6qhm6akjf81n6g8r"; </del> <ins> pname = "libvncserver"; version = "0.9.12"; url = "https://github.com/LibVNC/libvncserver/archive/LibVNCServer-${version}.tar.gz"; sha256 = "1226hb179l914919f5nm2mlf8rhaarqbf48aa649p4rwmghyx9vm"; # unpacked archive checksum </ins> }; in stdenv.mkDerivation { <del> inherit (s) name version; src = fetchurl { </del> <ins> inherit (s) pname version; src = fetchzip { </ins> inherit (s) url sha256; }; patches = [ <del> # CVE-2018-7225. Remove with the next release </del> (fetchpatch { <del> url = https://salsa.debian.org/debian/libvncserver/raw/master/debian/patches/CVE-2018-7225.patch; sha256 = "1hj1lzxsrdmzzl061vg0ncdpvfmvvkrpk8q12mp70qvszcqa7ja3"; </del> <ins> name = "CVE-2018-20750.patch"; url = "https://github.com/LibVNC/libvncserver/commit/09e8fc02f59f16e2583b34fe1a270c238bd9ffec.patch"; sha256 = "004h50786nvjl3y3yazpsi2b767vc9gqrwm1ralj3zgy47kwfhqm"; }) (fetchpatch { name = "CVE-2019-15681.patch"; url = "https://github.com/LibVNC/libvncserver/commit/d01e1bb4246323ba6fcee3b82ef1faa9b1dac82a.patch"; sha256 = "0hf0ss7all2m50z2kan4mck51ws44yim4ymn8p0d991y465y6l9s"; </ins> }) ]; <del> preConfigure = '' sed -e 's@/usr/include/linux@${stdenv.cc.libc}/include/linux@g' -i configure ''; nativeBuildInputs = [ pkgconfig autoreconfHook ]; </del> <ins> nativeBuildInputs = [ cmake ]; </ins> buildInputs = [ <del> libtool libjpeg openssl libgcrypt libpng </del> <ins> libjpeg openssl libgcrypt libpng </ins> ] ++ stdenv.lib.optional stdenv.isLinux systemd; propagatedBuildInputs = [ zlib ]; meta = { inherit (s) version; <del> description =  "VNC server library"; </del> <ins> description = "VNC server library"; homepage = "https://libvnc.github.io/"; </ins> license = stdenv.lib.licenses.gpl2Plus ; maintainers = [stdenv.lib.maintainers.raskin]; platforms = stdenv.lib.platforms.unix;

Related discussion:
text: , (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) (nixos-19.09, nixos-unstable) Scanned versions: nixos-19.09: ; nixos-unstable: . May contain false positives.
On it
Done
Code change:
<del> { lib, stdenv, buildPackages, fetchFromGitHub, autoconf, automake, libtool, pkgconfig, zlib, ilmbase, fetchpatch }: let # Doesn't really do anything when not crosscompiling emulator = stdenv.hostPlatform.emulator buildPackages; in </del> <ins> { lib , stdenv , buildPackages , fetchFromGitHub , zlib , ilmbase , fetchpatch , cmake , libtool }: </ins> stdenv.mkDerivation rec { pname = "openexr"; version = "2.4.1";

Related discussion:
text: Describe the bug build of OpenEXR fails to find -lImath24 To Reproduce Expected behavior Successful build. Screenshots Additional context Add any other context about the problem here. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(jfelice): nixpkgs: Maintainer information:
Something seems to be mangling the library names incorrectly? The ilmbase package contains: Notice the periods.
cc.
I lack the hardware to debug this. any ideas?
Repro'd on 10.14
seems to indicate that autoconf-based builds are only supported on linux - we may want to switch this to cmake. Building outside of nix via cmake is working fine for me.
can you give a try?
I can confirm this still builds on at least.
appears to fix this for me (macos 10.14). Reopen if it's still a problem for you.
Code change:
''; startAt = optional cfg.autoPrune.enable cfg.autoPrune.dates; <ins> after = [ "docker.service" ]; requires = [ "docker.service" ]; </ins> }; assertions = [

Related discussion:
text: While deploying a machine via deploy-rs, I had this error: Then stop docker or deploy the service from scratch, my belief is that docker-prune can start before docker.service and thus fail since it can't access the docker daemon. No systemd error whatever the configuration. I believe a patch like this should fix it but I am no systemd expert: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- from blame current unstable
I think the patch you propose makes sense. Could you open an PR for it?
Code change:
<del> { lib, stdenv, fetchFromGitHub, buildLinux, ... } @ args: </del> <ins> { lib, stdenv, fetchFromGitHub, buildLinux, variant, ... } @ args: </ins> let # comments with variant added for update script <del> # ./update-zen.py zen zenVariant = { version = "6.10.5"; #zen suffix = "zen1"; #zen sha256 = "08ibz7560xsmlnrm8j13hxf8hjjcxfmnjdrwffqc81g9g6rvpqra"; #zen isLqx = false; }; # ./update-zen.py lqx lqxVariant = { version = "6.10.5"; #lqx suffix = "lqx1"; #lqx sha256 = "09rscj20j94qkmvk0hlpjm6v1n1ndnkv2vl035gsp5lwggws2jqm"; #lqx isLqx = true; </del> <ins> variants = { # ./update-zen.py zen zen = { version = "6.10.5"; #zen suffix = "zen1"; #zen sha256 = "08ibz7560xsmlnrm8j13hxf8hjjcxfmnjdrwffqc81g9g6rvpqra"; #zen isLqx = false; }; # ./update-zen.py lqx lqx = { version = "6.10.5"; #lqx suffix = "lqx1"; #lqx sha256 = "09rscj20j94qkmvk0hlpjm6v1n1ndnkv2vl035gsp5lwggws2jqm"; #lqx isLqx = true; }; </ins> }; zenKernelsFor = { version, suffix, sha256, isLqx }: buildLinux (args // { inherit version;

Related discussion:
text: Mainline / hardened / testing / ... kernels can be painlessly modified via : Sadly, this does not work with a bunch of other kernel variants: All kernels should honor I am not entirely sure how dynamic binding is implemented in kernel stuff, however slightly changing xanmod parts this way seems to fix : zen and lqx look similar to xanmod, no idea about libre Pinging people who seem to update affected packages often Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
same underlying issue as it seems
Can confirm that this patch fix the issue for zen and lqx kernels:
have you submitted these changes as a PR that I can review?
sorry for the late response. I created a new PR with this changes.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Code change:
cp ${pandoc}/bin/pandoc dependencies/common/pandoc/ ''; <del> cmakeFlags = [ "-DRSTUDIO_TARGET=Desktop" "-DQT_QMAKE_EXECUTABLE=${qt5.qmake}/bin/qmake" ]; </del> <ins> cmakeFlags = [ "-DRSTUDIO_TARGET=Desktop" "-DQT_QMAKE_EXECUTABLE=$NIX_QT5_TMP/bin/qmake" ]; </ins> desktopItem = makeDesktopItem { name = name;

Related discussion:
text: Building RStudio fails with the following error message (seems to be something to do with the fact that QMake got upgraded): Run . System: (NixOS: , Ubuntu/Fedora: , ...) . Nix version: (run ) Nixpkgs version: (run ) Sandboxing enabled: (run )
Code change:
--replace "${ if stdenv.cc.cc or null != null then stdenv.cc.cc else "/no-such-path" }" /no-such-path  <ins> --replace "${stdenv.cc}" /no-such-path  </ins> --replace "$man" /no-such-path '' + stdenv.lib.optionalString crossCompiling ''

Related discussion:
text: It's interesting that this doesn't happen on (x86_64-)linux, apparently.
Code change:
inherit passthruFun; }; <ins> rustpython = callPackage ./rustpython/default.nix { inherit (darwin.apple_sdk.frameworks) SystemConfiguration; }; </ins> })

Related discussion:
text: Project description A Python-3 (CPython = 3.9.0) Interpreter written in Rust Metadata homepage URL: source URL: license: mit platforms: unix, linux, darwin
I tried to package it here: but run into compilation failure:
Rustpython master builds just fine. PR in
Code change:
<ins> { lib, rustPlatform, yabridge }: rustPlatform.buildRustPackage rec { pname = "yabridgectl"; version = yabridge.version; src = yabridge.src; sourceRoot = "source/tools/yabridgectl"; cargoSha256 = "1sjhani8h7ap42yqlnj05sx59jyz2h12qlm1ibv8ldxcpwps0bwy"; patches = [ ./libyabridge-from-nix-profiles.patch ]; patchFlags = [ "-p3" ]; meta = with lib; { description = "A small, optional utility to help set up and update yabridge for several directories at once"; homepage = "https://github.com/robbert-vdh/yabridge/tree/master/tools/yabridgectl"; license = licenses.gpl3Plus; maintainers = with maintainers; [ metadark ]; }; } </ins>

Related discussion:
text: Project description Yet Another way to use Windows VST plugins on Linux. Yabridge seamlessly supports using both 32-bit and 64-bit Windows VST2 and VST3 plugins in a 64-bit Linux VST host as if they were native VST2 and VST3 plugins, with optional support for plugin groups to enable inter-plugin communication for VST2 plugins and quick startup times. Its modern concurrent architecture and focus on transparency allows yabridge to be both fast and highly compatible, while also staying easy to debug and maintain. If I understand correctly, this provides similar functionality to the airwave package. I think the big plus to this package though is that it emulates as if they were native which means the build process doesn't need to require the user to go to the steinberg site and download the VST SDK (as airwave currently does). I used this on Arch with Reaper and it was extremely easy to get going. I had a much easier time using yabridge than trying to get carla set up and running. There are multiple AUR packages for installing from source or just pulling in the binaries. I've tried to package this myself but it's just a bit beyond my means. I think that if someone is more familiar with packaging wine related binaries or compiling with meson from source this would be a quick win. homepage URL: source URL: license: GPL 3.0 platforms: linux
I probably won't have time today, but I can take a look at this later. I'm pretty familiar with the nixpkgs wine build, and I've worked with the ZynAddSubFx build to add support for the Zyn-Fusion ui.
Amazing. I was able to take your PR and get Upright Piano working with Reaper as well. Thank you so much for the quick turn around, I really appreciate it.
Hi! I don't use NixOS myself, but if it helps, there's one person in the yabridge Discord currently using yabridge's master branch with NixOS. And I've also ran into another Nix build definition on GitHub in the past (but that one's pretty outdated by now).
I've just released with a lot of important new features, fixes and improvements including the first ever Linux <-Windows VST3 plugin bridge.