jiebi/CodeConvo huggingface dataset:
Code change:
diff --git a/src/protontricks/cli.py b/src/protontricks/cli.py <del> index fec0563..d158b96 100755 </del> <ins> index 9641970..6a2b268 100755 </ins> --- a/src/protontricks/cli.py +++ b/src/protontricks/cli.py <del> @@ -14,7 +14,7 @@ import os import logging </del> <ins> @@ -15,8 +15,8 @@ import sys </ins> from . import __version__ <del> -from .steam import (find_proton_app, find_steam_path, find_steam_runtime_path, +from .steam import (find_proton_app, find_steam_path, get_steam_apps, get_steam_lib_paths) from .winetricks import get_winetricks_path </del> from .gui import select_steam_app_with_gui <ins> -from .steam import (find_legacy_steam_runtime_path, find_proton_app, -                    find_steam_path, get_steam_apps, get_steam_lib_paths) +from .steam import (find_proton_app, find_steam_path, get_steam_apps, +                    get_steam_lib_paths) from .util import run_command from .winetricks import get_winetricks_path </ins> @@ -75,8 +75,7 @@ def main(args=None): "WINE: path to a custom 'wine' executablen" "WINESERVER: path to a custom 'wineserver' executablen"

Related discussion:
text: This issue is mainly a note to myself since the upgrade won't be trivial and will need a lot of testing. Protontricks is now using the Pressure Vessel runtime, so I have to refactor my patches with steam-run to account for this. <!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: protontricks <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.4.4 desired version: 1.5.0 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: myself
Code change:
boost = boost179; }; <del> libreoffice-qt = lowPrio (callPackage ../applications/office/libreoffice/wrapper.nix { </del> <ins> libreoffice-qt-fresh = lowPrio (callPackage ../applications/office/libreoffice/wrapper.nix { </ins> unwrapped = libsForQt5.callPackage ../applications/office/libreoffice (libreoffice-args // { kdeIntegration = true; variant = "fresh"; }); }); <ins> libreoffice-qt-fresh-unwrapped = libreoffice-qt-fresh.unwrapped; libreoffice-qt-still = lowPrio (callPackage ../applications/office/libreoffice/wrapper.nix { unwrapped = libsForQt5.callPackage ../applications/office/libreoffice (libreoffice-args // { kdeIntegration = true; variant = "still"; }); }); libreoffice-qt-still-unwrapped = libreoffice-qt-still.unwrapped; </ins> libreoffice-fresh = lowPrio (callPackage ../applications/office/libreoffice/wrapper.nix { unwrapped = callPackage ../applications/office/libreoffice

Related discussion:
text: Project description It would be nice to have libreoffice-still-qt, to have a stable version of libreoffice (still) with kde integration (qt). In my undestranding, so far we only have libreoffice-qt which is the fresh version cf.
Code change:
cmakeFlags = with stdenv.lib; [ "-DENABLE_MAN=ON" "-DENABLE_DOC=ON" <ins> "-DENABLE_JAVASCRIPT=OFF"  # Requires v8 <= 3.24.3, https://github.com/weechat/weechat/issues/360 "-DENABLE_PHP=OFF" </ins> ] ++ optionals stdenv.isDarwin ["-DICONV_LIBRARY=${libiconv}/lib/libiconv.dylib" "-DCMAKE_FIND_FRAMEWORK=LAST"] ++ map (p: "-D${p.cmakeFlag}=" + (if p.enabled then "ON" else "OFF")) plugins

Related discussion:
text: Currently we have two expressions that both build the kernel, whose only interface differences are in whether or not the .config is generated or provided. These builds should be merged with the two different interfaces simply being two ways to call the same underlying function, reducing code duplication and allowing the generic kernel builds to benefit from the IMO better structure of the newer manual kernel builds.
+1 on getting rid of duplication What is the "better structure"?
Structure may have been the wrong word, but the manual kernel build uses multiple outputs (suboptimally currently, which was part of the problem with the old PR) and uses the official kernel build system for building and installing, while the generic one (last I checked) had a manually maintained shell script to handle the install and parts of the build.
Fixed by
Code change:
cmakeFlags = with stdenv.lib; [ "-DENABLE_MAN=ON" "-DENABLE_DOC=ON" <ins> "-DENABLE_JAVASCRIPT=OFF"  # Requires v8 <= 3.24.3, https://github.com/weechat/weechat/issues/360 "-DENABLE_PHP=OFF" </ins> ] ++ optionals stdenv.isDarwin ["-DICONV_LIBRARY=${libiconv}/lib/libiconv.dylib" "-DCMAKE_FIND_FRAMEWORK=LAST"] ++ map (p: "-D${p.cmakeFlag}=" + (if p.enabled then "ON" else "OFF")) plugins

Related discussion:
text: For example: If this is called with instead of , it will fail to produce a output. This causes an assertion of the form: Unfortunately, doesn't keep the build directory around, making the source of the problem difficult to debug.
This is more of an issue for Thanks for reporting though!
Whoops! Is there an easy way to move it?
Not that I know of, sorry.
Fixed, thanks!
Code change:
cmakeFlags = with stdenv.lib; [ "-DENABLE_MAN=ON" "-DENABLE_DOC=ON" <ins> "-DENABLE_JAVASCRIPT=OFF"  # Requires v8 <= 3.24.3, https://github.com/weechat/weechat/issues/360 "-DENABLE_PHP=OFF" </ins> ] ++ optionals stdenv.isDarwin ["-DICONV_LIBRARY=${libiconv}/lib/libiconv.dylib" "-DCMAKE_FIND_FRAMEWORK=LAST"] ++ map (p: "-D${p.cmakeFlag}=" + (if p.enabled then "ON" else "OFF")) plugins

Related discussion:
text: migrated from python branch issue tracker
I'm closing this as it seems no longer relevant. From what I could find, python-virtinst is "CLI tools for building virtual machines using libvirt". But it is now merged with virtmanager: <-- contains one single file named MERGEDWITHVIRTMANAGER
Code change:
, icu66 , krb5 , lib <ins> , libtasn1 </ins> , makeWrapper , stdenv , openssl }: stdenv.mkDerivation rec { pname = "roon-server"; <del> version = "1.8-850"; </del> <ins> version = "1.8-880"; </ins> src = let

Related discussion:
text: <!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: roon-server <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.8-850 desired version: 1.8-880 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Code change:
sha256 = "sha256-CqmE4V+svSuQAsoX0I3NpUqPU5CQf3fyCHJPrjUjHF4="; }; <del> nativeBuildInputs = [ wheel ]; </del> <ins> nativeBuildInputs = [ wheel ]; </ins> propagatedBuildInputs = [ arrow

Related discussion:
text: Describe the bug Gitlint fails to build due to a dependency on click v7.1.2 To Reproduce Steps to reproduce the behavior: Expected behavior Successful build of gitlint Screenshots ! Additional context Looks like click got separated into two packages, one where it updated to 8.0.1 and is present in and one where it was kept back for . Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(david): nixpkgs: Maintainer information:
Yeah this is interesting. As far as I know, things shouldn't just break like this. I assume this is a regression, as it used to build, it seems a LOT of stuff has started breaking.
doesn't work with later releases. We have 8.0.1 and is pinning all releases (affects also , I guess). It would requires that is overriding the releases.
could you please give a try?
Looks to be good on my system. Runs as intended with
Code change:
runHook postInstall ''; <del> meta = with lib; { </del> <ins> postFixup = '' makeWrapper $out/opt/liberation-circuit/launcher.sh $out/bin/liberation-circuit  "''${gappsWrapperArgs[@]}" ''; meta = { </ins> description = "Real-time strategy game with programmable units"; mainProgram = "liberation-circuit"; longDescription = '' <del> Escape from a hostile computer system! Harvest data to create an armada of battle-processes to aid your escape! Take command directly and play the game as an RTS, or use the game's built-in editor and compiler to write your own unit AI in a simplified version of C. </del> <ins> Escape from a hostile computer system! Harvest data to create an armada of battle-processes to aid your escape! Take command directly and play the game as an RTS, or use the game's built-in editor and compiler to write your own unit AI in a simplified version of C. </ins> ''; homepage = "https://linleyh.itch.io/liberation-circuit"; <del> maintainers = with maintainers; [ emilytrau ]; license = licenses.gpl3Only; platforms = platforms.linux; </del> <ins> maintainers = with lib.maintainers; [ emilytrau ]; license = lib.licenses.gpl3Only; platforms = lib.platforms.linux; </ins> }; }

Related discussion:
text: When trying to load a multi-binary, a GLib error occurs on the terminal, and liberation-circuit crashes. In fact, this appears when interacting with anything using files: Saving a code, loading a code, and saving a multi-binary. This causes the player to have no way to program his processes. Steps to reproduce the behavior: multi-binary A window should appear to select a file This is the error appearing in the terminal : Please run and paste the result.
Code change:
installPhase = '' runHook preInstall <del> # resources mkdir -p "$out/share/redisinsight" mkdir -p "$out/share/redisinsight/static/resources/plugins" mkdir -p "$out/share/redisinsight/default" </del> <ins> mkdir -p "$out/share/redisinsight"/{app,defaults,static/plugins,static/resources/plugins} </ins> <del> cp -r release/${if stdenv.isDarwin then "darwin-" else "linux-"}${lib.optionalString stdenv.hostPlatform.isAarch64 "arm64-"}unpacked/resources/{app.asar,app.asar.unpacked} $out/share/redisinsight/ cp -r resources/ $out/share/redisinsight </del> <ins> cp -r release/*-unpacked/{locales,resources{,.pak}} "$out/share/redisinsight/app" mv "$out/share/redisinsight/app/resources/resources" "$out/share/redisinsight" </ins> # icons <del> for icon in "$out/resources/icons/*.png"; do </del> <ins> for icon in "$out/share/redisinsight/resources/icons"/*.png; do </ins> mkdir -p "$out/share/icons/hicolor/$(basename $icon .png)/apps" ln -s "$icon" "$out/share/icons/hicolor/$(basename $icon .png)/apps/redisinsight.png" done <del> ln -s "${finalAttrs.desktopItem}/share/applications" "$out/share/applications" </del> makeWrapper '${electron}/bin/electron' "$out/bin/redisinsight"  <del> --add-flags "$out/share/redisinsight/app.asar"  </del> <ins> --add-flags "$out/share/redisinsight/app/resources/app.asar"  </ins> --add-flags "''${NIXOS_OZONE_WL:+''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}"  <del> --chdir "$out/share/redisinsight"  --argv0 "$out/share/redisinsight/app.asar" </del> <ins> --set-default ELECTRON_FORCE_IS_PACKAGED 1  --inherit-argv0 </ins> runHook postInstall ''; <del> desktopItem = makeDesktopItem { name = "redisinsight"; exec = "redisinsight %u"; icon = "redisinsight"; desktopName = "RedisInsight"; genericName = "RedisInsight Redis Client"; comment = finalAttrs.meta.description; categories = [ "Development" ]; startupWMClass = "redisinsight"; }; meta = with lib; { </del> <ins> desktopItems = [ (makeDesktopItem { name = "redisinsight"; exec = "redisinsight %u"; icon = "redisinsight"; desktopName = "RedisInsight"; genericName = "RedisInsight Redis Client"; comment = finalAttrs.meta.description; categories = [ "Development" ]; startupWMClass = "redisinsight"; }) ]; meta = { </ins> description = "RedisInsight Redis client powered by Electron"; homepage = "https://github.com/RedisInsight/RedisInsight"; <del> license = licenses.sspl; maintainers = with maintainers; [ gmemstr ]; platforms = [ "x86_64-linux" ]; </del> <ins> #license = licenses.sspl; maintainers = with lib.maintainers; [ gmemstr tomasajt ]; platforms = lib.platforms.linux; </ins> }; })

Related discussion:
text: Steps to reproduce the behavior: -shell -p redisinsight Multiple of these errors Full log - Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
gspeech = callPackage ../applications/audio/gspeech { }; <ins> gtkcord4 = callPackage ../applications/audio/gtkcord4 {}; </ins> haruna = libsForQt5.callPackage ../applications/video/haruna { }; hdrmerge = libsForQt5.callPackage ../applications/graphics/hdrmerge { };

Related discussion:
text: Project description cchat-gtk appears to be a generic chat frontend cchat-discord appears to be a discord-capable backend gtkcord3 was the predecessor and was quite nice, I'm excited to get this packaged. Metadata homepage URL: source URL: license: gpl3 platforms: linux
updated OP to reflect that we should package cchat-gtk/cchat-discord now instead of gtkcord3.
I marked this as stale due to inactivity. &rarr;
still important to me
I have this packaged in my own config:
I marked this as stale due to inactivity. &rarr;
Code change:
mv $out/bin/arion $out/libexec makeWrapper $out/libexec/arion $out/bin/arion  --unset PYTHONPATH  <del> --prefix PATH : ${lib.makeBinPath [ pkgs.docker-compose_1 ]}  </del> <ins> --prefix PATH : ${lib.makeBinPath [ pkgs.docker-compose ]}  </ins> ; ''; };

Related discussion:
text: and other operations fail with See upstream bug report Steps to reproduce the behavior: arion on a basic , e.g. Arion is operations complete succesfully - you seem to think this is a docker compose issue, should those maintainers be pinged? Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
weird, the fix to seemed not to fix this one for me yet
Code change:
hash = "sha256-wHCTqcBvVN/pTXH3iW57DPpMEsnehutRQB5NaugS6Zs="; }; <del> patches = [ ./01-kdtree-signature.patch ]; </del> <ins> nativeBuildInputs = [ setuptools ]; </ins> propagatedBuildInputs = [ numba

Related discussion:
text: Steps to reproduce the behavior: python311Packages.pymatting Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
config = mkIf cfg.enable { warnings = [] <del> ++ optional (cfg.settings != null && cfg.settings.location != null) </del> <ins> ++ optional (cfg.settings != null && cfg.settings ? location) </ins> "`services.borgmatic.settings.location` is deprecated, please move your options out of sections to the global scope" ++ optional (catAttrs "location" (attrValues cfg.configurations) != []) "`services.borgmatic.configurations.<name>.location` is deprecated, please move your options out of sections to the global scope"

Related discussion:
text: introduced a deprecation warning for the option. Upon following the warning and moving all options out of the option and removing it, the build fails with the following error: Steps to reproduce the behavior: the service without using the option the configuration Build succeeds. As a temporary workaround, I tried setting to an empty set but then borgmatic fails to parse the config file. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Code change:
doCheck = true; <ins> # NOTE: Purity check is disabled for checkPhase because it doesn't fare well # with the DMD linker. See https://github.com/NixOS/nixpkgs/issues/97420 </ins> checkPhase = '' cd dmd <del> make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 CC=$CXX DMD=${pathToDmd} BUILD=release SHELL=$SHELL </del> <ins> NIX_ENFORCE_PURITY=  make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 CC=$CXX DMD=${pathToDmd} BUILD=release SHELL=$SHELL </ins> cd ../druntime <del> make -j$NIX_BUILD_CORES -f posix.mak unittest PIC=1 DMD=${pathToDmd} BUILD=release </del> <ins> NIX_ENFORCE_PURITY=  make -j$NIX_BUILD_CORES -f posix.mak unittest PIC=1 DMD=${pathToDmd} BUILD=release </ins> cd ../phobos <del> make -j$NIX_BUILD_CORES -f posix.mak unittest BUILD=release ENABLE_RELEASE=1 PIC=1 DMD=${pathToDmd} DFLAGS="-version=TZDatabaseDir -version=LibcurlPath -J$(pwd)" </del> <ins> NIX_ENFORCE_PURITY=  make -j$NIX_BUILD_CORES -f posix.mak unittest BUILD=release ENABLE_RELEASE=1 PIC=1 DMD=${pathToDmd} DFLAGS="-version=TZDatabaseDir -version=LibcurlPath -J$(pwd)" </ins> cd .. '';

Related discussion:
text: Describe the bug To Reproduce Steps to reproduce the behavior: ~/nixpkgs -build -A tilix <details<summarylog</summary</detailsExpected behavior Screenshots Additional context Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
build tilix
I guess that only works for PR. Sorry.
This looks like an issue with the package.
This probably needs patching
My mistake, the same error occurs in multiple tests, so fixing a single test won't do.
grepping for points to the DMD linker: It looks like the DMD linker invokes gcc with to do the actual work. Considering that the package hasn't been updated since April, perhaps some change in the gcc toolchain caused this build failure?
Pinging maintainers
output of <details
Thanks everyone
Code change:
<ins> { config, pkgs ,lib ,... }: with lib; { options.xdg.portal = { enable = mkEnableOption "<link xlink:href='https://github.com/flatpak/xdg-desktop-portal'>xdg desktop integration</link>"//{ default = true; }; extraPortals = mkOption { type = types.listOf types.package; default = []; description = '' List of additional portals to add to path. Portals allow interaction with system, like choosing files or taking screenshots. At minimum, a desktop portal implementation should be listed. GNOME and KDE already adds <package>xdg-desktop-portal-gtk</package>; and <package>xdg-desktop-portal-kde</package> respectively. On other desktop environments you probably want to add them yourself. ''; }; }; config = let cfg = config.xdg.portal; packages = [ pkgs.xdg-desktop-portal ] ++ cfg.extraPortals; in mkIf cfg.enable { services.dbus.packages  = packages; systemd.packages = packages; environment.variables = { GTK_USE_PORTAL = "1"; XDG_DESKTOP_PORTAL_PATH = map (p: "${p}/share/xdg-desktop-portal/portals") cfg.extraPortals; }; }; } </ins>

Related discussion:
text: It is possible to use Plasma’s native file dialogues in Firefox 64 to open or save a file. Currently this feature is not working in NixOS, and it seems to me some small changes would need to be made to derivation in order to enable it. I propose we include this option together with as a Firefox option in NixOS (see also: ). I followed the explanation on how to enable this feature as it was published on : Firefox (64 is current stable) from a terminal emulator But it produces the following error: system: host os: multi-user?: sandbox: version: channels(root): channels(hook): nixpkgs:
You'll probably have to do something like this to expose the dbus service:
Where? In:
It needs to go into a nixos module or your .
Code change:
done poolImported "${pool}" || poolImport "${pool}"  # Try one last time, e.g. to import a degraded pool. if poolImported "${pool}"; then <del> ${optionalString cfgZfs.requestEncryptionCredentials '' </del> <ins> ${optionalString (if isBool cfgZfs.requestEncryptionCredentials then cfgZfs.requestEncryptionCredentials else cfgZfs.requestEncryptionCredentials != []) '' </ins> ${packages.zfsUser}/sbin/zfs list -rHo name,keylocation ${pool} | while IFS=$'t' read ds kl; do <del> (case "$kl" in </del> <ins> (${optionalString (!isBool cfgZfs.requestEncryptionCredentials) '' if ! echo '${concatStringsSep "n" cfgZfs.requestEncryptionCredentials}' | grep -qFx "$ds"; then continue fi ''} case "$kl" in </ins> none ) ;; prompt )

Related discussion:
text: Describe the bug I have a ZFS pool with approximately the following layout: The datasets under are those that the local system is installed on and the datasets under are backups from a different machine received via . All datasets are using native ZFS encryption, however, datasets under are encrypted with a different key (that of the machine that sent the backups) than the rest of the pool. When I boot, the initrd will query me for the key for and but this key is not available and I also don't want to make it available for obvious reasons. The culprit lies in this statement in the : This forces loading of all keys, which is a good default, but cannot easily be overridden. My current workaround for this is to turn this off and only load the key for manually. To this end I would like to propose the following patch by which it should be possible to load the key only for the specified datasets. To Reproduce Steps to reproduce the behavior: NixOS with an encrypted ZFS pool a dataset with a different encryption key and set you lost the key for this new dataset errors when mounting due to the lack of keys Expected behavior It should be possible to restrict for which pools and datasets to query encryption credentials. Screenshots N/A Additional context N/A Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: nixpkgs: Maintainer information:
I think you can open a PR with your patch for this one.
Code change:
make -f Makefile.sharedlibrary install INSTALL_PREFIX=$out substituteAll ${./duktape.pc.in} $out/lib/pkgconfig/duktape.pc ''; enableParallelBuilding = true; meta = with lib; {

Related discussion:
text: Steps to reproduce the behavior: The regression is directly caused by , and the root cause is the library is not properly linked, upstream issue: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Code change:
vix = callPackage ../tools/misc/vix { }; <ins> vkBasalt = callPackage ../tools/graphics/vkBasalt { vkBasalt32 = pkgsi686Linux.vkBasalt; }; </ins> vnc2flv = callPackage ../tools/video/vnc2flv {}; vncrec = callPackage ../tools/video/vncrec { };

Related discussion:
text: vkBasalt is a Vulkan post processing layer to enhance the visual graphics of games. Metadata homepage URL: source URL: license: zlib platforms: linux
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .