jiebi/CodeConvo huggingface dataset:
Code change:
# verifies: #   1. nginx generates config file with shared http context definitions above #      generated virtual hosts config. <ins> #   2. whether the ETag header is properly generated whenever we're serving #      files in Nix store paths </ins> <del> import ./make-test.nix ({ pkgs, ...} : { </del> <ins> import ./make-test.nix ({ pkgs, ... }: { </ins> name = "nginx"; meta = with pkgs.stdenv.lib.maintainers; { maintainers = [ mbbx6spp ]; }; <del> nodes = { webserver = { ... }: { services.nginx.enable = true; services.nginx.commonHttpConfig = '' </del> <ins> nodes = let commonConfig = { pkgs, ... }: { services.nginx.enable = true; services.nginx.commonHttpConfig = '' </ins> log_format ceeformat '@cee: {"status":"$status",' '"request_time":$request_time,' '"upstream_response_time":$upstream_response_time,'

Related discussion:
text: If you serve files from , nginx will set last-modified header to unix timestamp 1. The result is that browser will cache indefinitely. Not sure what we should do about it really, following nginx configuration helps:
Why do you need to turn etag off?
Ah, I see. nginx's etags aren't hashes.
I wonder if we could find a way to pull the hash out of the nix store path and put it into an etag header.
Thanks for finding this. I've been having issues with broken caching on my nginx/nixos server. Even when the files on the server were updated (files in the nix store), the browser was told that no change had happened. If I'm understanding this correctly, since nginx's etags are based on filesystem modification time; you can't have proper cache invalidation (ie. it will always send 304 not modified). Or is there a workaround?
+1 this is a problem. And turning off etag seems like overkill. Is there some way to 1) set the date on a file so that Nginx can pick it up, or 2) do something else awesome?
Is the zero-timestamp rule set in stone in Nix, or is there some way to override it if you really want a file in /nix/store to have a particular timestamp?
I think we could get away with: It's not perfect, as it will change on each Nix evaluation instead of being content addressed. Another way would be to turn the store path passed to nginx directive to translate into an etag.
The etag function is at called from and . Making it dependent on the realpath of the file seems doable.
Explanation how to configure nginx to use the hash from the nix path:
In my testing, this sends the correct etag, but does not send the 304 not modified, when the etag matches. Also, the header gets stripped out when compression is enabled.
It's working perfectly for me. I've gzip compression enabled, the etag header is sent and the browser gets a 304 when querying the header.
Nice! An example with a directory would be more common:
I've to correct what I said. your statement seems to be correct. What happens in my case is that Cloudflare is actually handling the caching of the ETag correctly, not nginx.
Code change:
# verifies: #   1. nginx generates config file with shared http context definitions above #      generated virtual hosts config. <ins> #   2. whether the ETag header is properly generated whenever we're serving #      files in Nix store paths </ins> <del> import ./make-test.nix ({ pkgs, ...} : { </del> <ins> import ./make-test.nix ({ pkgs, ... }: { </ins> name = "nginx"; meta = with pkgs.stdenv.lib.maintainers; { maintainers = [ mbbx6spp ]; }; <del> nodes = { webserver = { ... }: { services.nginx.enable = true; services.nginx.commonHttpConfig = '' </del> <ins> nodes = let commonConfig = { pkgs, ... }: { services.nginx.enable = true; services.nginx.commonHttpConfig = '' </ins> log_format ceeformat '@cee: {"status":"$status",' '"request_time":$request_time,' '"upstream_response_time":$upstream_response_time,'

Related discussion:
text: So this approach is completely useless without external caching. I'll investigate further and see if I can come up with a solution.
Here is a patch: If real path (after dereferencing symlinks) of is in Nix store, it will use path's hash as ETag. For example: I'll take some time to double check everything and only then send a PR. However, feel free to test: nix { pkgs, ... }: { = { enable = true; package = with pkgs; nginx.overrideAttrs (super: { patches = (super.patches or []) ++ [(fetchpatch { url = ; sha256 = "16pa1vwcm7kibkjsxpk3szaa2vnxdinml6v0fp4038i2qaav113k"; })]; }); }; }
This is really great! or anyone, do you have a moment to write an explanation of this new feature and its practical ramifications for anyone configuring an nginx server? Since it isn't typical nginx behavior, I think the nixos manual should explain it somewhere so it doesn't catch people by surprise.
I think is a good explanation, just needs to be put into the manual.
Cool, submitted .
Code change:
<ins> { lib , fetchFromGitHub , mkDerivation , breeze-icons , breeze-qt5 , cmake , extra-cmake-modules , kcodecs , kconfig , kcoreaddons , kfilemetadata , ki18n , kiconthemes , kio , kio-extras , kirigami2 , kxmlgui , mpv , pkg-config , qqc2-desktop-style , qtbase , qtquickcontrols2 , qtwayland , youtube-dl }: mkDerivation rec { pname = "haruna"; version = "0.6.1"; src = fetchFromGitHub { owner = "g-fb"; repo = "haruna"; rev = version; sha256 = "sha256-8MauKmvQUwzq4Ssmm6g7/y6ADkye+eg/zyR3v/Wu848="; }; buildInputs = [ breeze-icons breeze-qt5 kcodecs kconfig kcoreaddons kfilemetadata ki18n kiconthemes kio kio-extras kirigami2 kxmlgui mpv qqc2-desktop-style qtbase qtquickcontrols2 qtwayland youtube-dl ]; nativeBuildInputs = [ cmake extra-cmake-modules pkg-config ]; meta = with lib; { homepage = "https://github.com/g-fb/haruna"; description = "Open source video player built with Qt/QML and libmpv"; license = with licenses; [ bsd3 cc-by-40 gpl3Plus wtfpl ]; maintainers = with maintainers; [ jojosch ]; }; } </ins>

Related discussion:
text: Project description Metadata homepage URL: source URL: license: idk, its not obvious and im not a lawyer platforms: unix/linux?
Code change:
./services/networking/radicale.nix ./services/networking/radvd.nix ./services/networking/rdnssd.nix <ins> ./services/networking/realm.nix </ins> ./services/networking/redsocks.nix ./services/networking/resilio.nix ./services/networking/robustirc-bridge.nix

Related discussion:
text: Project description A simple, high performance relay server written in rust. Metadata homepage URL: source URL: license: mit platforms: Linux, darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
privateKey = testCerts.${domain}.key; httpPort = 80; tlsPort = 443; <del> ocspResponderURL = "http://0.0.0.0:4002"; </del> <ins> ocspResponderURL = "http://${domain}:4002"; </ins> strict = true; };

Related discussion:
text: Describe the bug causes Lego to fail. To Reproduce Steps to reproduce the behavior: set on an enabled certificate. to this configuration. fail. Lego complains about an unrecognized (really misplaced) flag. Expected behavior The certificate will be successfully fetched, with Must-Staple enabled. Screenshots Additional context I think the problematic code is here: should not be in commonOpts, it should instead be in runOpts and renewOpts. Lego runs successfully when is to and . Notify maintainers (the acme team) Metadata Maintainer information:
Thanks for the report :) It appears that the --must-staple option is common to both "run" and "renew" modes, but is not actually a common option that can be specified before the mode. I'll get a PR ready for this.
Code change:
mirror://xorg/individual/util/makedepend-1.0.9.tar.xz mirror://xorg/individual/util/util-macros-1.20.0.tar.xz mirror://xorg/individual/util/xorg-cf-files-1.0.8.tar.xz <del> mirror://xorg/individual/xserver/xorg-server-21.1.12.tar.xz </del> <ins> mirror://xorg/individual/xserver/xorg-server-21.1.13.tar.xz </ins>

Related discussion:
text: XOrg crashes when certain applications are launched. More details here: Steps to reproduce the behavior: any of the IntelliJ IDEs. You may have to set anti aliasing to greyscale. Xorg will crash. Xorg doesn't crash. This is the bug: It looks like a security fix caused this regression. Ubuntu has already applied patches that fix this for Xorg and Xwayland: see this message from the above Ubuntu thread: NixOS should use the same patches until this is fixed upstream in XOrg. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Sounds like this will be addressed by this update:
xwayland too: looks like updating xorg and xwayland to their latest versions will do the trick then
xwayland was bumped to the latest version in PR
Code change:
<del> { stdenv, fetchurl, pkgs, ... }: </del> <ins> { stdenv, fetchurl, pkgs, makeWrapper, mono, ffmpeg, ... }: </ins> stdenv.mkDerivation rec { name = "emby-${version}";

Related discussion:
text: Emby uses ffmpeg for transcoding media and for generating thumbnails. Emby fails to find the FFmpeg binary during the setup wizard but can be specified manually if FFmpeg has been installed separately. Add to , browse to , and advance through the wizard. System: 17.03pre92039. (Gorilla) Nix version:nix-env (Nix) 1.11.4 Nixpkgs version: 17.03pre92039.
cc
Funny thing is that I was just watching a movie when I was mentioned on a system without any ffmpeg/ffprobe binary. My system was upgraded from an older version (config was already existing so no check was done by the wizard). I was able to reproduce the issue. Will take a more detailed look at it sometime tomorrow :)
Code change:
} ~~~ <del> This expression should fetch </del> <ins> This expression should fetch </ins> -  the *nix* vscode extension from whatever source defined in the default nixpkgs extensions set `vscodeExtensions`. <del> -  the *code-runner* vscode extension from the marketplace using the </del> <ins> -  the *code-runner* vscode extension from the marketplace using the </ins> following url: ~~~

Related discussion:
text: Rofi doesn't seem to find the application for VSCode even though the .desktop file seems to be there. It shows the command when running but when running it doesn't seem it show.
Code change:
(wm: pkgs.gnome.gnome-flashback.mkSessionForWm { inherit (wm) wmName wmLabel wmCommand enableGnomePanel; <ins> inherit (cfg.flashback) panelModulePackages; </ins> } ) flashbackWms;

Related discussion:
text: Panel applets are being picked up from environment variable in and a completely hardcoded path in . First, we will need to patch the latter manager to use an environment variable as well. Second, we will need to do something similar to what . Or better, create  derivation. Originally posted by in
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
I'd like to tackle this, do you have any pointers? We need to get it to pick up at least right?
Code change:
rec { thunderbird = common rec { pname = "thunderbird"; <del> version = "91.5.1"; </del> <ins> version = "91.6.0"; </ins> application = "comm/mail"; binaryName = pname; src = fetchurl { url = "mirror://mozilla/thunderbird/releases/${version}/source/thunderbird-${version}.source.tar.xz"; <del> sha512 = "5939e09b143e440efa906d95cda06826bd3a73b2edde5eed86229b8a0e4d1434519059f37d319d26978d7eea9b3906c5e1c1543a2bc2465625d5ab5438855717"; </del> <ins> sha512 = "a11eafe1390141ee3508eea06ba8ab135d0725513977a3b37b3b35f413a1f825dc14fef530b9ac961840804be59291c7f5cba3c93b12726605d4a7255660f749"; </ins> }; patches = [ # The file to be patched is different from firefox's `no-buildconfig-ffx90.patch`.

Related discussion:
text: Thunderbird fails to compile with " error: undefined symbol: wlproxymarshal_flags" when rebuilding system configuration. Steps to reproduce the behavior: updated my system configuration flake inputs () run system rebuild () Thunderbird compiles successfully. Relevant lines from the build log: So it looks like the error has something to do with Wayland support. nixpkgs lock: nix-info:
Please, search before opening issues:
Code change:
rm -f /tmp/.X0-lock ''; <del> script = "${cfg.displayManager.job.execCmd}"; </del> <ins> # TODO: move declaring the systemd service to its own mkIf script = mkIf (config.systemd.services.display-manager.enable == true) "${cfg.displayManager.job.execCmd}"; </ins> # Stop restarting if the display manager stops (crashes) 2 times # in one minute. Starting X typically takes 3-4s.

Related discussion:
text: I believe that this prevents the use of other display managers -Don't force it?
if you enable a another dm you wouldn't get this error i submitted a pr so that this error does not happen when lightdm is disabled but a another dm isn't enabled
Code change:
<ins> { lib , stdenv , fetchFromGitHub , appstream-glib , desktop-file-utils , gobject-introspection , libadwaita , meson , ninja , pkg-config , python3 , wrapGAppsHook4 , apx , gnome-console }: stdenv.mkDerivation (finalAttrs: { pname = "apx-gui"; version = "0.1.1"; src = fetchFromGitHub { owner  = "Vanilla-OS"; repo   = "apx-gui"; rev    = "v${finalAttrs.version}"; hash = "sha256-orP5kAsoXX0zyDskeIPKKHNt5c757eUm9un4Ws6uFYA="; }; strictDeps = true; nativeBuildInputs = [ appstream-glib desktop-file-utils gobject-introspection meson ninja pkg-config (python3.withPackages (ps: [ ps.pygobject3 ])) wrapGAppsHook4 ]; buildInputs = [ libadwaita ]; preFixup = '' gappsWrapperArgs+=( --prefix PATH : "${lib.makeBinPath [ apx gnome-console ]}" ) ''; meta = { description = "A GUI frontend for Apx in GTK 4 and Libadwaita"; homepage    = "https://github.com/Vanilla-OS/apx-gui"; license     = lib.licenses.gpl3Only; platforms   = lib.platforms.linux; maintainers = with lib.maintainers; [ chewblacka ]; mainProgram = "apx-gui"; }; }) </ins>

Related discussion:
text: A frontend in GTK 4 and Libadwaita for Apx. GUI for tool for (both are already packaged in nixpkgs) Metadata homepage URL: source URL: license: GPL-3.0 platforms: linux Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
<del> { lib , stdenvNoCC , fetchFromGitHub , fetchurl , clickgen , attrs }: stdenvNoCC.mkDerivation rec { pname = "bibata-cursors"; version = "2.0.3"; src = fetchFromGitHub { owner = "ful1e5"; repo = "Bibata_Cursor"; rev = "v${version}"; sha256 = "zCk7qgPeae0BfzhxxU2Dk1SOWJQOxiWyJuzH/ri+Gq4="; }; buildInputs = [ clickgen attrs ]; buildPhase = '' ctgen build.toml -p x11 -d 'bitmaps/Bibata-Modern-Amber' -n 'Bibata-Modern-Amber' -c 'Yellowish and rounded edge bibata cursors.' ctgen build.toml -p x11 -d 'bitmaps/Bibata-Modern-Classic' -n 'Bibata-Modern-Classic' -c 'Black and rounded edge Bibata cursors.' ctgen build.toml -p x11 -d 'bitmaps/Bibata-Modern-Ice' -n 'Bibata-Modern-Ice' -c 'White and rounded edge Bibata cursors.' ctgen build.toml -p x11 -d 'bitmaps/Bibata-Original-Amber' -n 'Bibata-Original-Amber' -c 'Yellowish and sharp edge Bibata cursors.' ctgen build.toml -p x11 -d 'bitmaps/Bibata-Original-Classic' -n 'Bibata-Original-Classic' -c 'Black and sharp edge Bibata cursors.' ctgen build.toml -p x11 -d 'bitmaps/Bibata-Original-Ice' -n 'Bibata-Original-Ice' -c 'White and sharp edge Bibata cursors.' ''; installPhase = '' install -dm 0755 $out/share/icons cp -rf themes/* $out/share/icons/ ''; meta = with lib; { description = "Material Based Cursor Theme"; homepage = "https://github.com/ful1e5/Bibata_Cursor"; license = licenses.gpl3; platforms = platforms.linux; maintainers = with maintainers; [ rawkode AdsonCicilioti ]; }; } </del>

Related discussion:
text: Package name: bibata-cursors Latest released version: 2.0.4 <!-- Search your package here: --- Current version on the unstable channel: 2.0.3 Current version on the stable/release channel: 2.0.3 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Code change:
test2.psk = "@PSK_SPECIAL@";            # should be replaced test3.psk = "@PSK_MISSING@";            # should not be replaced test4.psk = "P@ssowrdWithSome@tSymbol"; # should not be replaced <ins> test5.psk = "@PSK_AWK_REGEX@";          # should be replaced </ins> }; # secrets environmentFile = pkgs.writeText "wpa-secrets" '' PSK_VALID="S0m3BadP4ssw0rd"; # taken from https://github.com/minimaxir/big-list-of-naughty-strings <del> PSK_SPECIAL=",./;'[]-= <>?:"{}|_+ !@#$%^&*()`~"; </del> <ins> PSK_SPECIAL=",./;'[]/-= <>?:"{}|_+ !@#$%^&*()`~"; PSK_AWK_REGEX="PassowrdWith&symbol"; </ins> ''; }; };

Related discussion:
text: Using the NixOS option to specify the configuration, I noticed that if an ampersand () is present, the password field of isn't generated correctly. the option along with the option. The environment file should contain . the field "password= the content of . The password is decrypted to . The password shuld be decrypted to . The global variable's name shouldn't show. Here are some nix code that is tested to trigger this issue instead. The environment file: Generated in the aforementioned path, note how the field is erroneous. A hack to get around this is to split your password in two halves, and put the & in plain text. . Of course I would still like to see this get fixed :p Thank you for maintaining this module and reading this issue ! Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
It looks like a missed a metacharacter: I don't know if escaping it as works, or it interacts somehow with other systemd/shell/nix metacharacters. I lost counts of how many level of escaping we are in. I hope to get rid of all of this nonsense with , but next release of wpasupplicant is taking forever.
Done in The fix should be in NixOS 24.05.
Code change:
broken = builtins.compareVersions qtbase.version "5.7.0" < 0; }; nativeBuildInputs = [ extra-cmake-modules ]; <del> buildInputs = [ hunspell qttools ]; </del> <ins> buildInputs = [ aspell qttools ]; </ins> propagatedBuildInputs = [ qtbase ]; }

Related discussion:
text: Currently we build with support for . Sonnet typically looks in for dictionaries That means it won't be able to find any dictionaries and thus spellchecking won't work.
Is this still a problem? It seems that hunspell paths are not hardcoded in hunspelldict.h anymore: But they are still hardcoded in
Yes, this is still a problem. It seems like we should disable hunspell and use aspell, which is configured correctly in NixOS.
I marked this as stale due to inactivity. &rarr;
I marked this with "good first bug" because I think we need only to change to depend on , and do some testing.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Code change:
buildDotnetModule rec { pname = "ArchiSteamFarm"; # nixpkgs-update: no auto update <del> version = "5.4.13.4"; </del> <ins> version = "5.5.0.11"; </ins> src = fetchFromGitHub { owner = "JustArchiNET"; repo = "ArchiSteamFarm"; rev = version; <del> hash = "sha256-RQx+E/lxdSgB2ddNIeWOd/S2OMMiznXCbYUXdYKRvCM="; </del> <ins> hash = "sha256-VlJiTCdoH6hlVtQgECIlbsQvg3S58B5IIy1zRxh1eOg="; </ins> }; <del> dotnet-runtime = dotnetCorePackages.aspnetcore_7_0; dotnet-sdk = dotnetCorePackages.sdk_7_0; </del> <ins> dotnet-runtime = dotnetCorePackages.aspnetcore_8_0; dotnet-sdk = dotnetCorePackages.sdk_8_0; </ins> nugetDeps = ./deps.nix;

Related discussion:
text: Looks like it now uses .NET 8 which probably made all existing plugins incompatible - Package name: ArchiSteamFarm Latest released version: 5.5.0.11 <!-- Search your package here: --- Current version on the unstable channel: 5.4.13.4 Current version on the stable/release channel: 5.4.12.5 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
The package/module has no official way to use plugins, so there is no way to use them unless people are using overlays which should be constructed in a smart way to re-use the same methods as archisteamfarm does. Anyway, here is the update
Code change:
disabled = pythonOlder "3.8"; <del> src = fetchPypi { pname = "snowflake_connector_python"; inherit version; hash = "sha256-/ZvCqxv1OE0si2W8ALsEdVV9UvBHenESkzSqtT+Wef0="; </del> <ins> src = fetchFromGitHub { owner = "snowflakedb"; repo = "snowflake-connector-python"; rev = "refs/tags/v${version}"; hash = "sha256-A6QnKCROd1vJpFCTrLEoHVo43xojdjpgYS3qQm64gcY="; </ins> }; build-system = [ cython setuptools <del> wheel </del> ]; dependencies = [ asn1crypto certifi cffi charset-normalizer <ins> cryptography </ins> filelock idna <del> oscrypto </del> packaging platformdirs <del> pycryptodomex </del> pyjwt pyopenssl pytz

Related discussion:
text: package lists and as dependencies but upstream uses instead. Steps to reproduce the behavior: dependencies of package it to the dependencies listed by upstream and should not be in the dependencies list, but should n/a <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
That's a bot.
Thank you for the quick turnaround!
Code change:
composable_kernel = throw "'composable_kernel' has been replaced with 'rocmPackages.composable_kernel'"; # Added 2023-10-08 cpp-ipfs-api = cpp-ipfs-http-client; # Project has been renamed. Added 2022-05-15 crispyDoom = crispy-doom; # Added 2023-05-01 <ins> cryptowatch-desktop = throw "Cryptowatch Desktop was sunset on September 30th 2023 and has been removed from nixpkgs"; # Added 2023-12-22 </ins> clash = throw "'clash' has been removed, upstream gone. Consider using 'clash-meta' instead."; # added 2023-11-10 clasp = clingo; # added 2022-12-22 claws-mail-gtk3 = claws-mail; # Added 2021-07-10

Related discussion:
text: Steps to reproduce the behavior: cryptowatch-desktop download url redirects to a blog Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
As of September the 30th 2023, Cryptowatch was sunset and users were advised to use their parent companies offering Kraken Pro. I'll create a pull request to remove cryptowatch from nixpkgs as there aren't any archives available that contain it that are reliable
Code change:
stdenv.mkDerivation rec { pname = "gmic"; <del> version = "3.1.6"; </del> <ins> version = "3.2.0"; </ins> outputs = [ "out" "lib" "dev" "man" ]; src = fetchFromGitHub { owner = "dtschump"; repo = "gmic"; <del> rev = "326ea9b7dc320b3624fe660d7b7d81669ca12e6d"; sha256 = "RRCzYMN/IXViiUNnacJV3DNpku3hIHQkHbIrtixExT0="; </del> <ins> rev = "v.${version}"; hash = "sha256-lrIlzxXWqv046G5uRkBQnjvysaIcv+iDKxjuUEJWqcs="; </ins> }; # TODO: build this from source

Related discussion:
text: Steps to reproduce the behavior: gmic in a nix shell using the unstable channel Add any other context about the problem here.
Will be fixed by
Thanks! Note that it makes darktable fail to build.
This issue has been mentioned on NixOS Discourse. There might be relevant details there: