jiebi/CodeConvo huggingface dataset:
Code change:
runHook postInstall ''; <del> # Electron version is set to 22 in order to match upstream </del> postFixup = '' <del> makeWrapper ${electron_22}/bin/electron $out/bin/${pname}  </del> <ins> makeWrapper ${electron}/bin/electron $out/bin/${pname}  </ins> --add-flags $out/share/${pname}/resources/app.asar '';

Related discussion:
text: Steps to reproduce the behavior: system configuration with Freetube in it. See and for the exact same issue with Morgen. Electron version lock seems to have been introduced with . Upstream seems to be at Electron 27: . and
Maybe we could add the patches from It looks like they were waiting for a nixos user to test it and eventually gave up on us.
are you able to test ?
Looks good as far as I can tell.
fails on this branch, for whatever reason.
Code change:
wrapt zeroconf zipstream-new <del> ] ++ lib.optionals stdenv.isDarwin [ py.pkgs.appdirs ]; </del> <ins> ] ++ lib.optionals stdenv.isDarwin [ py.pkgs.appdirs ]; </ins> <del> checkInputs = with super; [ pytestCheckHook mock ddt ]; </del> <ins> checkInputs = with super; [ ddt mock pytestCheckHook ]; </ins> patches = [ # substitute pip and let it find out, that it can't write anywhere

Related discussion:
text: Octoprint can't build on unstable due to a conflict of the required version for . octoprint , while the dependency requires (due to ) . Octoprint builds successfully I ran a between and (known good) , the first bad commit was I suspect that it's necessary to pin the additional dependencies (and maybe some more), too, but I'm not that experienced with packaging python packages. made the first bad commit Octoprint maintainers: system: host os: multi-user?: sandbox: version: channels(root): channels(richard): nixpkgs: Maintainer information:
Code change:
<del> { stdenv, fetchurl, intltool, pkgconfig, gtk3, vala_0_32 , makeWrapper, gdk_pixbuf, cmake, desktop_file_utils </del> <ins> { stdenv, fetchurl, intltool, pkgconfig, gtk3, vala_0_38, enchant , wrapGAppsHook, gdk_pixbuf, cmake, desktop_file_utils </ins> , libnotify, libcanberra_gtk3, libsecret, gmime , libpthreadstubs, sqlite , gnome3, librsvg, gnome_doc_utils, webkitgtk }: let <del> majorVersion = "0.11"; </del> <ins> majorVersion = "0.12"; </ins> in stdenv.mkDerivation rec { <del> name = "geary-${majorVersion}.3"; </del> <ins> name = "geary-${majorVersion}.0"; </ins> src = fetchurl { url = "mirror://gnome/sources/geary/${majorVersion}/${name}.tar.xz"; <del> sha256 = "1r42ijxafach5lv8ibs6y0l5k4nacjg427dnma8fj00xr1sri7j1"; </del> <ins> sha256 = "0ii4qaqfqx90kvqwg0g9jahygkir4mb03ja55fa55yyx6cq0kwff"; </ins> }; propagatedUserEnvPkgs = [ gnome3.gnome_themes_standard ]; <del> nativeBuildInputs = [ pkgconfig ]; buildInputs = [ intltool gtk3 makeWrapper cmake desktop_file_utils gnome_doc_utils vala_0_32 webkitgtk libnotify libcanberra_gtk3 gnome3.libgee libsecret gmime sqlite </del> <ins> nativeBuildInputs = [ vala_0_38 intltool pkgconfig wrapGAppsHook cmake desktop_file_utils gnome_doc_utils ]; buildInputs = [ gtk3 enchant webkitgtk libnotify libcanberra_gtk3 gnome3.libgee libsecret gmime sqlite </ins> libpthreadstubs gnome3.gsettings_desktop_schemas gnome3.gcr gdk_pixbuf librsvg gnome3.defaultIconTheme ]; preConfigure = '' <del> substituteInPlace src/CMakeLists.txt --replace '`pkg-config --variable=girdir gobject-introspection-1.0`' '${webkitgtk}/share/gir-1.0' ''; postInstall = '' mkdir -p $out/share/gsettings-schemas/${name}/ mv $out/share/glib-2.0 $out/share/gsettings-schemas/${name} </del> <ins> substituteInPlace src/CMakeLists.txt --replace '`''${PKG_CONFIG_EXECUTABLE} --variable=girdir gobject-introspection-1.0`' '${webkitgtk.dev}/share/gir-1.0' </ins> ''; preFixup = '' <del> wrapProgram "$out/bin/geary"  --set GDK_PIXBUF_MODULE_FILE "$GDK_PIXBUF_MODULE_FILE"  --prefix XDG_DATA_DIRS : "$XDG_ICON_DIRS:${gnome3.gnome_themes_standard}/share:$out/share:$GSETTINGS_SCHEMAS_PATH" </del> <ins> # Add geary to path for geary-attach gappsWrapperArgs+=(--prefix PATH : "$out/bin") </ins> ''; enableParallelBuilding = true;

Related discussion:
text: Geary and are . I suppose updating might remove its dependency on the insecure . (I think i remember having seen somewhere in an issue tracker that this dependency was removed in Geary source code, but i cannot find now where i saw it.)
By the way, I do not really understand these GTK and WebKitGTK issues and versions, but, just for reference, there is an open issue about previous versions of Geary using GTK2 instead of GTK3: .
In Geary 0.12 there are some fresh bugs (for example, ). It looks like version 0.12.1 is in the beginning of November.
Running shows gtk2 as a transitive dependency from webkitgtk (which depends on both GTK 2 and GTK 3) and gnome-themes-standard. I do not think the latter is necessary for GTK 3 applications since Adwaita is built into GTK 3.
Code change:
default = []; description = "Other GNOME Flashback sessions to enable."; }; <ins> panelModulePackages = mkOption { default = [ pkgs.gnome.gnome-applets ]; type = types.listOf types.path; description = '' Packages containing modules that should be made available to <literal>gnome-panel</literal> (usually for applets). If you're packaging something to use here, please install the modules in <literal>$out/lib/gnome-panel/modules</literal>. ''; example = literalExample "[ pkgs.gnome.gnome-applets ]"; }; </ins> }; };

Related discussion:
text: Panel applets are being picked up from environment variable in and a completely hardcoded path in . First, we will need to patch the latter manager to use an environment variable as well. Second, we will need to do something similar to what . Or better, create  derivation. Originally posted by in
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
I'd like to tackle this, do you have any pointers? We need to get it to pick up at least right?
Code change:
githubId = 40633781; name = "Sergei S."; }; <ins> dit7ya = { email = "7rat13@gmail.com"; github = "dit7ya"; githubId = 14034137; name = "Mostly Void"; }; </ins> dizfer = { email = "david@izquierdofernandez.com"; github = "dizfer";

Related discussion:
text: cliphist wayland clipboard manager Metadata homepage URL: source URL: license: gplv3+ platforms: linux
Code change:
{ lib <ins> , stdenv </ins> , rustPlatform , gettext , meson

Related discussion:
text: Describe the bug fails to compile with Additional context See for a possible cause. Notify maintainers cc (sorry for notifying you here and in the PR!)
Gonna try to just switch it to . We should probably update gnome docs for Rust+Gnome packages
Yeah, I think that would be best. The idea of the hooks is that is not necessary anymore in mixed projects. I will also do a PR for cargoBuildHook, since it should not be used when is set explicitly.
Code change:
-- Some needed machinery to handle multiple-output external dependencies, -- as per https://github.com/luarocks/luarocks/issues/766 ${lib.optionalString (lib.length depVariables > 0) '' <del> ${lib.concatStringsSep "n  " depVariables}''} ${extraVariables} </del> <ins> ${lib.concatStringsSep "n  " depVariables}''} ${extraVariablesStr} </ins> } ${extraConfig} '';

Related discussion:
text: Describe the bug neovim fails to build with missing , similar to , on . To Reproduce Steps to reproduce the behavior: to from master () Expected behavior The package should successfully build. Metadata On master () Maintainer information:
via in
so you could do until a proper fix.
Reverting the luarocks bump doesn't work for me. That fix is also very surprising to me, since neovim broke (for me) after the latest nixos-unstable channel update.
Interesting. It worked fine for me. Running the above revert command and then (inside my local nixpkgs with it reverted) let me build neovim properly. I don't think it's particularly surprising if updating a channel that happens to include the luarocks bump causes it to break, unless I'm misunderstanding you.
I updated from a channel where the luarocks bump had already happened, and neovim worked on that channel. In fact, I reverted to the previous hydra evaluation to make my system evaluate again.
This was actually before and it was working without problems and then suddenly the problem appeared again. I can also report that I cam getting this in the same way described (updated latest nixos-unstable channel and then neovim stopped building again).
I confirm this fixed by on master (channels may take a while). For now I'll assume that charvp's failure to resolve the issue with that revert was some kind of mistake; we can re-open otherwise, perhaps separately if it's a different kind of error.
Does anyone know why updating the luarocks dependency is so brittle? Is it possible to at least add a test so we don't regress again in the future?
the tool exists (nixpkgs-review) but it takes CPU and disk space to run plus some reviewer time (and was not run in this case). Also for this specific case, the luarocks update broke in subtle ways the build so I wouldn't call it . It is called unstable for a reason. The good thing about nixpkgs is you can pin neovim to an older version while keeping your system on unstable.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Are we sure this is fixed on Darwin? still shows failing with logs of: Or is this a different issue?
Code change:
-- Some needed machinery to handle multiple-output external dependencies, -- as per https://github.com/luarocks/luarocks/issues/766 ${lib.optionalString (lib.length depVariables > 0) '' <del> ${lib.concatStringsSep "n  " depVariables}''} ${extraVariables} </del> <ins> ${lib.concatStringsSep "n  " depVariables}''} ${extraVariablesStr} </ins> } ${extraConfig} '';

Related discussion:
text: I think the root problem here is that luarocks has a poor implementation of "move". Combined with the build's behavior being affected by filesystem ordering the result is essentially random. The [implementation of move][] calls out to the operating system commands [][] and [][]. Building with will contain a sequence of , and . I've extracted the [relevant part of the log][]. The critical aspect here is that by default, unix will dereference symlinks and copy their contents. [implementation of move]: []: []: [relevant part of the log]: My theory: luarocks scans the directory for external libraries in filesystem order and attempts to move all shared libraries from to . At which point one of 3! things will happen, but the two main ones are: is copied and deleted and , now broken symlinks, fail to copy and are copied by dereferencing, and deleted is copied and deleted Either way is wrong to some degree, but one of them happens to work well enough for downstream packages to build. If I build locally, the filesystem order I get seems to work, so we can inspect the two results: I've been focusing on this for darwin since the failure case happens to be cached, but I believe it applies equally to linux.
is that sthg you have already witnessed ?
What LuaRocks version is this happening with? I have pushed fixes related to the file deployment stage in 3.3.1.
I've tested 3.2.1 (current nixpkgs master) and 3.3.1 (hasty upgrade locally), they both have similar results, except on 3.3.1 the errors now propagate correctly. I've uploaded a [log of a failed build][] with 3.3.1. [log of a failed build]:
I was hoping to find time to write a proper issue report and a test lua package for this, but haven't yet. My test case would have a directory structure made with , that looks like: In order to succeed the deployment stage would have to produce both the file and its symlink.
Code change:
-- Some needed machinery to handle multiple-output external dependencies, -- as per https://github.com/luarocks/luarocks/issues/766 ${lib.optionalString (lib.length depVariables > 0) '' <del> ${lib.concatStringsSep "n  " depVariables}''} ${extraVariables} </del> <ins> ${lib.concatStringsSep "n  " depVariables}''} ${extraVariablesStr} </ins> } ${extraConfig} '';

Related discussion:
text: Describe the bug I have neovim in my systemPackages, I did and today and it stuck at building luajit: To Reproduce Steps to reproduce the behavior: to Expected behavior The system should upgrade properly. Additional context Output: Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(kj): nixpkgs: Maintainer information:
Possible fix is in . There was already an open issue about it () but from an unclear reason people have reached the conclusion it was fixed on latest master.
Oh I meant , not .
Well, I agree with that conclusion. For me, on the build is broken with the error above and on current master it isn't. EDIT: note that the channels lag behind, usually less than a couple days, but sometimes we get a week or two due to some harder regression.
Yea right. For me on NixOS I tried with the nixpkgs-unstable channel and could install successfully. The nixos-unstable still fails though.
Code change:
sourceProvenance = with sourceTypes; [ binaryNativeCode ]; license = licenses.unfree; platforms = [ "x86_64-linux" ]; # TODO Mac support <del> maintainers = [ maintainers.mausch ]; </del> <ins> maintainers = with maintainers; [ mausch dylanmtaylor ]; </ins> }; }

Related discussion:
text: Package name: aws-workspaces Latest released version: 4.5.0 <!-- Search your package here: --- Current version on the unstable channel: 4.1.0.1523 Current version on the stable/release channel: 4.1.0.1523 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.
Code change:
, rustPlatform , stdenv , stdenvNoCC <del> , wasm-bindgen-cli </del> , webkitgtk }: let <del> esbuild-18-20 = let version = "0.18.20"; </del> <ins> esbuild-20-2 = let version = "0.20.2"; </ins> in esbuild.override { buildGoModule = args: buildGoModule (args // {

Related discussion:
text: Package name: surrealist Latest released version: 2.0.1 <!-- Search your package here: --- Current version on the unstable channel: 1.11.7 Current version on the stable/release channel: - <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --NOTE Surrealist has now officially moved to the SurrealDB Github org, see Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Nvm the nix package is actually built from source, just Tauri builds a deb in that process
Working on it. I'm currently stuck at an issue with the frontend build. There is a transitive dependency to that does not get installed by pnpm.
Code change:
<ins> import ./make-test-python.nix ({ lib, ... }: { name = "swap-file-btrfs"; meta.maintainers = with lib.maintainers; [ oxalica ]; nodes.machine = { pkgs, ... }: { virtualisation.useDefaultFilesystems = false; virtualisation.bootDevice = "/dev/vda"; boot.initrd.postDeviceCommands = '' ${pkgs.btrfs-progs}/bin/mkfs.btrfs --label root /dev/vda ''; virtualisation.fileSystems = { "/" = { device = "/dev/disk/by-label/root"; fsType = "btrfs"; }; }; swapDevices = [ { device = "/var/swapfile"; size = 1; # 1MiB. } ]; }; testScript = '' machine.wait_for_unit('var-swapfile.swap') machine.succeed("stat --file-system --format=%T /var/swapfile | grep btrfs") # First run. Auto creation. machine.succeed("swapon --show | grep /var/swapfile") machine.shutdown() machine.start() # Second run. Use it as-is. machine.wait_for_unit('var-swapfile.swap') machine.succeed("swapon --show | grep /var/swapfile") ''; }) </ins>

Related discussion:
text: When using to create and activate a swapfile on btrfs, it fails with messages like this: The kernel says: I am not very familiar with Nix, but after reading the corresponding and , it seems that creating a swapfile on btrfs requires disabling copy-on-write for that file (via ) as well. However, doesn't do it currently. BTW, manually creating the swapfile and letting NixOS activating it works fine for me. to ( is supposed to be mounted as btrfs). . Swapfile is created and activated without any issue. There is a workaround on NixOS Discourse: system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
I have the same issue. I already tried disabling copy-on-write for the partition but it still fails: I also still get the warning like even though I the attribute to my mount options (afterwards). My current swap configuration can be found .
Mounting with attribute won't work because: [^1]:
I came up with this yesterday, which seems to work (or at least you can follow the general pattern): I have as a separate subvolume, nothing else on it. Once you've run this to create the swapfile, it seems to mount and function properly from there on out. But yes, it would be nice if this were taken care of automatically. EDIT: Fix link
brilliant, that helped me solve my issue. While your script didn't work out for me, I was able to adjust it so it did. I noticed the following warning when running your script: So, I searched for this and found the following note on ArchWiki: — Replacing with made the warning disappear for me but running still failed with . Then I compared the script to what I've used in and noticed that I used instead of to create the empty swapfile. The full script I ended up with:
Thanks for the update. I originally used , but switched after reading that should be much faster (and have to admit I can't remember if I tested that change yet -- thank you for the feedback). I've switched it back to .
Code change:
mesonFlags = (lib.mapAttrsToList lib.mesonEnable { <del> "cava" = cavaSupport; </del> <ins> "cava" = cavaSupport && lib.asserts.assertMsg sndioSupport "Sndio support is required for Cava"; </ins> "dbusmenu-gtk" = traySupport; "jack" = jackSupport; <ins> "libevdev" = evdevSupport; </ins> "libinput" = inputSupport; "libnl" = nlSupport; "libudev" = udevSupport;

Related discussion:
text: Steps to reproduce the behavior: Checking waybar's , it appears that fixing this would just be a case of passing in . <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
It appears that a similar issue also arises with .
Code change:
installPhase = '' runHook preInstall <del> install -Dm644 *.ttf -t $out/share/fonts/hack </del> <ins> install -Dm644 *.ttf -t $out/share/fonts/truetype </ins> runHook postInstall '';

Related discussion:
text: After installing the hack font it can not be found. Probably because it's installed in the wrong folder. Steps to reproduce the behavior: font-hack up Gnome Font application for the font hack and see it's not there and see it's in a separate directory next to Font should show up in Gnome Font and other applications Running nixos 23.05 beta
For me it seems to work when adding:
Yeah, rearranges font files anyway. But it seems like a good idea to unify the output directory with other fonts, thanks for catching this!
Code change:
} ) <ins> # Octoprint pulls in celery indirectly but has no support for the up-to-date releases ( self: super: { celery = super.celery.overrideAttrs (oldAttrs: rec { version = "5.0.0"; src = oldAttrs.src.override { inherit version; sha256 = "sha256-MTkw/d3nA9jjcCmjBL+RQpzRGu72PFfebayp2Vjh8lU="; }; doCheck = false; }); } ) # Octoprint would allow later sentry-sdk releases but not later click releases ( self: super: { sentry-sdk = super.sentry-sdk.overrideAttrs (oldAttrs: rec { pname = "sentry-sdk"; version = "1.4.3"; src = fetchFromGitHub { owner = "getsentry"; repo = "sentry-python"; rev = version; sha256 = "sha256-vdE6eqELMM69CWHaNYhF0HMCTV3tQsJlMHAA96oCy8c="; }; disabledTests = [ "test_apply_simulates_delivery_info" "test_auto_enabling_integrations_catches_import_error" ]; disabledTestPaths = [ # Don't test integrations "tests/integrations" ]; }); } ) </ins> # Built-in dependency ( self: super: {

Related discussion:
text: Octoprint can't build on unstable due to a conflict of the required version for . octoprint , while the dependency requires (due to ) . Octoprint builds successfully I ran a between and (known good) , the first bad commit was I suspect that it's necessary to pin the additional dependencies (and maybe some more), too, but I'm not that experienced with packaging python packages. made the first bad commit Octoprint maintainers: system: host os: multi-user?: sandbox: version: channels(root): channels(richard): nixpkgs: Maintainer information:
Code change:
<ins> { lib , rustPlatform , fetchFromGitHub , stdenv , darwin , nix-update-script , nixosTests }: rustPlatform.buildRustPackage rec { pname = "realm"; version = "2.6.0"; src = fetchFromGitHub { owner = "zhboner"; repo = "realm"; rev = "v${version}"; hash = "sha256-G3scFSOxbmR3Q2fkRdg115WN/GCYpys/8Y4JC4YMGdY="; }; cargoHash = "sha256-EvXafTujqTdQwfK4NXgT7lGKGnrpyP9ouplD6DmJUKU="; buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; env.RUSTC_BOOTSTRAP = 1; passthru = { updateScript = nix-update-script { }; tests = { inherit (nixosTests) realm; }; }; meta = with lib; { description = "A simple, high performance relay server written in rust"; homepage = "https://github.com/zhboner/realm"; mainProgram = "realm"; license = licenses.mit; maintainers = with maintainers; [ ocfox ]; }; } </ins>

Related discussion:
text: Project description A simple, high performance relay server written in rust. Metadata homepage URL: source URL: license: mit platforms: Linux, darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
pydantic ] ++ lib.optionals stdenv.isDarwin [ py.pkgs.appdirs <ins> ] ++ lib.optionals (!stdenv.isDarwin) [ octoprint-pisupport </ins> ]; nativeCheckInputs = with self; [

Related discussion:
text: Steps to reproduce the behavior: also yields the "got" hash. The hash was last changed in nixpkgs @
we just hit the same issue in Alpine - it looks like the upstream uses format specifiers for that change depending on the state of the repo: (found by [here][1]) in your case it might help to do instead ( provided that doesn't just do on the remote URL, but fetches the repo in some other way ): [1]:
thanks for the new upstream issue and the infos!
Code change:
librsvg ]; <del> # Don't use buildRustPackage phases, only use it for rust deps setup configurePhase = null; buildPhase = null; checkPhase = null; installPhase = null; </del> postPatch = '' chmod +x build-aux/meson_post_install.py patchShebangs build-aux/meson_post_install.py

Related discussion:
text: Describe the bug fails to compile with Additional context See for a possible cause. Notify maintainers cc (sorry for notifying you here and in the PR!)
Gonna try to just switch it to . We should probably update gnome docs for Rust+Gnome packages
Yeah, I think that would be best. The idea of the hooks is that is not necessary anymore in mixed projects. I will also do a PR for cargoBuildHook, since it should not be used when is set explicitly.