jiebi/CodeConvo huggingface dataset:
Code change:
<del> let lib = import ../../../lib; in lib.makeOverridable ( </del> <ins> let lib = import ../../../lib; stdenv-overridable = lib.makeOverridable ( </ins> <del> { name ? "stdenv", preHook ? "", initialPath </del> <ins> argsStdenv@{ name ? "stdenv", preHook ? "", initialPath </ins> , # If we don't have a C compiler, we might either have `cc = null` or `cc = # throw ...`, but if we do have a C compiler we should definiely have `cc !=

Related discussion:
text: I tried to build a package with debug symbols today and failed. NixOS wiki and nixpkgs repository comments say the following should work: Please run and paste the result.
It worked in Aug 2018: Bisected down to breakage at : Looks like it stems from the fact that does not expose anymore, only . /cc
Woah. master and both work for me with nix stable.
That's surprising. Here is my attempt at current master checkout: I tried removing and seeing the same failure. I wonder why it works for you. Might be a different stdenv?
Does it mean and are the same object?
i can reproduce
I can also reproduce with stable Nix (2.3.14):
Hmm, the issue is that / slaps the on after is defined, closing over the old . In Smalltalk paralance, this would be an issue of insufficiently "late binding".
Still reproducible on current master ()
I ran into this.
Bump, ran into this while updating the Nixpkgs pin on a project of mine.
There should be a test for this :)
Gonna spend next hour or two trying to fix this.
Things that are also missing:
So, this function is not executed on passed through stdenv. Not yet sure why.
Yeah, I've fixed it (thanks, for being there :heart:)
Post-mortem: always read threads. Solution was kinda already provided in , but I delved right in without knowing that)
atleast you now know more about stdenv :slightlysmilingface:
How is the PR looking? I've been waiting on this for a couple of weeks to debug an intermittent crash I'm having with xfce4-sesion :)
Code change:
buildInputs = [ unrar ]; <ins> NIX_CFLAGS_LINK = lib.optionalString stdenv.isDarwin "-headerpad_max_install_names"; postInstall = lib.optionalString stdenv.isDarwin '' install_name_tool -change libunrar.so ${unrar}/lib/libunrar.so $out/lib/python*/site-packages/unrardll/unrar.*-darwin.so install_name_tool -change libunrar.so ${unrar}/lib/libunrar.so build/lib.*/unrardll/unrar.*-darwin.so ''; </ins> pythonImportsCheck = [ "unrardll" ]; meta = with lib; {

Related discussion:
text: Steps to reproduce the behavior: Happens on intel darwin. Please run and paste the result.
The .so dependency should be fixed up:
Code change:
nativeBuildInputs = [ cmake pkg-config <del> qttools </del> <ins> (qttools.override { withClang = true; }) </ins> wrapQtAppsHook python3 ninja

Related discussion:
text: Installing causes large dependencies such as and to be pulled in at run-time Steps to reproduce the behavior: that some of the large dependencies such as are pulled in. I'd expect and to be build-time dependencies, and as such shouldn't be needed at run-time The additional dependencies are being pulled in due to , which itself should be a build dependency. FWIW, declares as a make* dependency Please run and paste the result.
not the maintainer for -qt ( is), but I took a quick look at it nevertheless and it seems that gets to in the invocation for even if it is moved to . Unfortunately I don't know enough about the Qt ecosystem to tell why this is the case.
I think that the issue lies in qttools itself, for some reason after , qttools depends on clang and llvm at runtime This doesn't seem to be the case on and
qttools provides a qt plugin so wrapQtAppsHook will add to ‘QTPLUGINPATH’ automaticallyUnfortunately, the packaging of qttools is not subdivided, all output is almost in one packagethis leads to the addition of unnecessary runtime dependencies. ( Actually even may not be needed is required by and , lupdate seems to be just a optional feature dependency on clangbut is not feasiblewe have to recompile to disable this feature Splitting into multiple packages should be a better solutionqdoc/lupdate are often used to generate documentation/translations, almost no packages runtime depends on them This pr should solve the problem of qalculate-qt but this may cause some packages fail to find lupdate. it‘s not an elegant solution
I think it's easier to add a flag to qttools, and only use that variant for building the docs.
should be , set can prevent qttools from being recognized as a runtime dependency the pull request to disable clang-based c++ parser by default
If that helps, maybe is no longer necessary?
For this issue, yes But not sure if there is a package need qttools (qt plugin ) as runtime dependency
I checked all packages that depends on qttools, and found that most if not all of them have a runtime reference on qttools due to it being in . So this problem is actually widespread, we can have the workaround in for now.
Code change:
mv artifacts/msbuild artifacts/mono-msbuild chmod +x artifacts/mono-msbuild/MSBuild.dll <del> ln -s $(find ${dotnet-sdk} -name libhostfxr.so) artifacts/mono-msbuild/SdkResolvers/Microsoft.DotNet.MSBuildSdkResolver/ </del> <ins> # The provided libhostfxr.dylib is for x86_64-darwin, so we remove it rm artifacts/mono-msbuild/SdkResolvers/Microsoft.DotNet.MSBuildSdkResolver/libhostfxr.dylib ln -s $(find ${dotnet-sdk} -name libhostfxr${sharedLibrary}) artifacts/mono-msbuild/SdkResolvers/Microsoft.DotNet.MSBuildSdkResolver/ </ins> # overwrite the file echo "#!${stdenv.shell}" > eng/common/dotnet-install.sh echo "#!${stdenv.shell}" > mono/build/get_sdk_files.sh <ins> # Prevent msbuild from downloading a new libhostfxr echo "#!${stdenv.shell}" > mono/build/extract_and_copy_hostfxr.sh </ins> mkdir -p mono/dotnet-overlay/msbuild-bin cp ${dotnet-sdk}/sdk/*/{Microsoft.NETCoreSdk.BundledVersions.props,RuntimeIdentifierGraph.json} mono/dotnet-overlay/msbuild-bin

Related discussion:
text: Steps to reproduce the behavior: msbuild Trying to build msbuild on a mac fails. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result.
Code change:
{ stdenv, stdenv_32bit, fetchurl, unzip, makeWrapper <del> , platformTools, buildTools, support, supportRepository, platforms, sysimages, addons </del> <ins> , platformTools, buildTools, support, supportRepository, platforms, sysimages, addons, sources </ins> , libX11, libXext, libXrender, libxcb, libXau, libXdmcp, libXtst, mesa, alsaLib , freetype, fontconfig, glib, gtk2, atk, file, jdk, coreutils, libpulseaudio, dbus , zlib, glxinfo, xkeyboardconfig <ins> , includeSources </ins> }: { platformVersions, abiVersions, useGoogleAPIs, useExtraSupportLibs ? false, useGooglePlayServices ? false }:

Related discussion:
text: Currently, our Android SDK derivations contain only binary files. This is unfortunate during development, when one wants to jump to a definition of a particular symbol in the SDK and it is not found. For comparison, ArchLinux is doing this in their packages, e.g. System: 16.09pre-git (Flounder) Nix version: nix-env (Nix) 1.11.4 Nixpkgs version: "16.09beta335." /cc
Created PR .
Code change:
#seeks = 148; # removed 2020-06-21 prosody = 149; i2pd = 150; <ins> systemd-coredump = 151; </ins> systemd-network = 152; systemd-resolve = 153; systemd-timesync = 154;

Related discussion:
text: Describe the bug when a root-owned process dumps core (eg recent sshd, due to a known bug) and coredumps are enabled, systemd-coredump warns (but proceeds successfully). To Reproduce Steps to reproduce the behavior: systemd coredumps enabled a SIGABRT to any root-owned process (eg by running ) Expected behavior coredumps succeeds with proper privsep Screenshots Additional context Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Can you reproduce this with a simple c binary you interactively run as root user?
yes, as root does it. amended the original post addendum: if you want a minimal C example that causes it:
still happening regularly due to a bug in openssh (race conditions in process shutdown can cause seccomp filters to trigger)
I am also observing this problem, both sshd dumping core and the systemd-coredump error when it happens. I can also reproduce it with as root.
I can confirm I see the log messages: I looked at . It seems systemd-coredump wants to drop privileges to a user (but falls back to root if it can't find it). suggests we should create it (like we create one for ). I opened , which does that.
Code change:
`fetchpatch` works very similarly to `fetchurl` with the same arguments expected. It expects patch files as a source and performs normalization on them before computing the checksum. For example it will remove comments or other unstable parts that are sometimes added by version control systems and can change over time. <del> Other fetcher functions allow you to add source code directly from a VCS such as subversion or git. These are mostly straightforward nambes based on the name of the command used with the VCS system. Because they give you a working repository, they act most like `fetchzip`. </del> <ins> Most other fetchers return a directory rather than a single file. </ins> ## `fetchsvn` {#fetchsvn}

Related discussion:
text: Fetchers are hard to test because when the output sha is verified, Nix won't download it again. This leads to confusion and PRs that are effectively untested because the others do not realize that they need to remove the store path before testing. Examples: Steps to reproduce the behavior: a fetcher -build the fetcher -build "success" but the fetcher is broken a PR effort The fetcher runs every time. This is expected but not realistic, because Nix can not guess what to re-fetch. Instead, we can make fetcher testing easier by adding fetcher tests following the pattern: So this uses IFD which is probably ok for ofborg? Regarding ; instead of somewhere, we'll have to use to set on the fetchers because they're functions. The salt may need to be passed externally in case of pure evaluation. We could make it a Nixpkgs parameter that defaults to . <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Maintainer information:
Workaround: Use followed by
Or we can just put the salt in the parameter. Nix isn't clever enough to find same-hash renames in the store :)
And the salt can be derived from the unsalted drv path, which is exactly what we want. See
Code change:
environment.sessionVariables.TZDIR = "/etc/zoneinfo"; <ins> # This way services are restarted when tzdata changes. </ins> systemd.globalEnvironment.TZDIR = tzdir; environment.etc.localtime = <del> { source = "${tzdir}/${config.time.timeZone}"; </del> <ins> { source = "/etc/zoneinfo/${config.time.timeZone}"; </ins> mode = "direct-symlink"; }; <del> environment.etc.zoneinfo.source = "${pkgs.tzdata}/share/zoneinfo"; </del> <ins> environment.etc.zoneinfo.source = tzdir; </ins> };

Related discussion:
text: is meant to show the current timezone. It doesn't. (I have some reason to believe that this is connected to Steam game failures, but still working on that. In any case...) Set time.timeZone to anything other than UTC. Rebuild your system. Run The output will be in UTC, with no timezone shown: lists only UTC. System: 17.03pre92039. (Gorilla) Nix version: nix-env (Nix) 1.11.4 Nixpkgs version: 17.03pre92039.
I think this is because of this line: We can patch this to not check prefix, but still wouldn't work. For discoverability of timezones we can add to and look for them in but I'm not sure this is a good idea.
See ,
Code change:
<ins> See: https://lkml.org/lkml/2017/11/25/90 diff -urNZ a/src/wl/sys/wl_linux.c b/src/wl/sys/wl_linux.c --- a/src/wl/sys/wl_linux.c	2015-09-18 22:47:30.000000000 +0000 +++ b/src/wl/sys/wl_linux.c	2018-01-31 22:52:10.859856221 +0000 @@ -93,7 +93,11 @@ #include <wlc_wowl.h> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0) +static void wl_timer(struct timer_list *tl); +#else static void wl_timer(ulong data); +#endif static void _wl_timer(wl_timer_t *t); static struct net_device *wl_alloc_linux_if(wl_if_t *wlif); @@ -2298,9 +2302,15 @@ } static void +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0) +wl_timer(struct timer_list *tl) +{ +	wl_timer_t *t = from_timer(t, tl, timer); +#else wl_timer(ulong data) { wl_timer_t *t = (wl_timer_t *)data; +#endif if (!WL_ALL_PASSIVE_ENAB(t->wl)) _wl_timer(t); @@ -2352,9 +2362,13 @@ bzero(t, sizeof(wl_timer_t)); +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0) +	timer_setup(&t->timer, wl_timer, 0); +#else init_timer(&t->timer); t->timer.data = (ulong) t; t->timer.function = wl_timer; +#endif t->wl = wl; t->fn = fn; t->arg = arg; </ins>

Related discussion:
text: When I ran , it failed to build my configuration because dependencies couldn't be built. Relevant sections from and : Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): channels(user): nixpkgs:
a full log might be helpful
Sorry, forgot to attach the log. Here it is:
It seems needs to be cherry-picked there...
I've created a pull request for this:
Fixed by
Code change:
buildPythonPackage rec { pname = "matrix-nio"; <del> version = "0.18.0"; </del> <ins> version = "0.18.1"; </ins> format = "pyproject"; src = fetchFromGitHub { owner = "poljar"; repo = "matrix-nio"; rev = version; <del> sha256 = "1rn5lz81y4bvgjhxzd57qhr0lmkm5xljl4bj9w10lnm4f7ls0xdi"; </del> <ins> sha256 = "QHNirglqSxGMmbST96LUp9MHoGj0yAwLoTRlsbMqwaM="; </ins> }; nativeBuildInputs = [

Related discussion:
text: (the .0 version has a bug that breaks ) <!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: matrix-nio <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 0.18.0 desired version: 0.18.1 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.
Code change:
, libXxf86dga, libXxf86misc , libXxf86vm, openal, libGLU, libGL, libjpeg, flac , libXi, libXfixes, freetype, libopus, libtheora <del> , physfs, enet, pkg-config, gtk2, pcre, libpulseaudio, libpthreadstubs </del> <ins> , physfs, enet, pkg-config, gtk3, pcre, libpulseaudio, libpthreadstubs </ins> , libXdmcp }:

Related discussion:
text: RTS/game with programming on simplified C Metadata version: 1.3 homepage URL: source URL: license: GPLv3 platforms: GNU/Linux, Windows, IOS
Code change:
makeFlags = lib.optionals stdenv.hostPlatform.isGnu [ "udevruledir=$(out)/lib/udev/rules.d" ]; <ins> installFlags = [ "install_python" ]; </ins> enableParallelBuilding = true; passthru.tests = {

Related discussion:
text: Project description Python 3 bindings of the , library for managing BTRFS file systems. This binding is part of the project. Metadata homepage URL: source URL: license: lgpl2Only platforms: linux (I'm not sure if it works on BSD or Mac)
I marked this as stale due to inactivity. &rarr;
See
Code change:
githubId = 1755789; name = "Robert Irelan"; }; <ins> tembleking = { name = "Fede Barcelona"; email = "fede_rico_94@hotmail.com"; github = "tembleking"; githubId = 2988780; }; </ins> tengkuizdihar = { name = "Tengku Izdihar"; email = "tengkuizdihar@gmail.com";

Related discussion:
text: Project description Gorm is Golang ORM for SQL databases. Gen Tool is a single binary without dependencies can be used to generate structs from database. Metadata homepage URL: source URL: license: mit platforms: all? Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Code change:
sets are * `pkgs.python27Packages` <del> * `pkgs.python35Packages` </del> * `pkgs.python36Packages` * `pkgs.python37Packages` <ins> * `pkgs.python38Packages` * `pkgs.python39Packages` </ins> * `pkgs.pypyPackages` and the aliases * `pkgs.python2Packages` pointing to `pkgs.python27Packages` <del> * `pkgs.python3Packages` pointing to `pkgs.python37Packages` </del> <ins> * `pkgs.python3Packages` pointing to `pkgs.python38Packages` </ins> * `pkgs.pythonPackages` pointing to `pkgs.python2Packages` #### `buildPythonPackage` function

Related discussion:
text: According to the 3.5 life-cycle () , the final release has already occurred and is now considered EOL. The jump from 3.5 to 3.6 has already happened in the majority of python packages and should not be a similar situation in which we had to extend python2's life long after its official EOL date.
Code change:
monA.wait_until_succeeds("ceph -s | grep 'mgr: ${cfg.monA.name}(active,'") monA.wait_until_succeeds("ceph -s | grep 'HEALTH_OK'") <del> # This test has been commented out due to the upstream issue with pyo3 # that has broken this dashboard # Reference: https://www.spinics.net/lists/ceph-users/msg77812.html </del> # Enable the dashboard and recheck health <del> # monA.succeed( #     "ceph mgr module enable dashboard", #     "ceph config set mgr mgr/dashboard/ssl false", #     # default is 8080 but it's better to be explicit #     "ceph config set mgr mgr/dashboard/server_port 8080", # ) # monA.wait_for_open_port(8080) # monA.wait_until_succeeds("curl -q --fail http://localhost:8080") # monA.wait_until_succeeds("ceph -s | grep 'HEALTH_OK'") </del> <ins> monA.succeed( "ceph mgr module enable dashboard", "ceph config set mgr mgr/dashboard/ssl false", # default is 8080 but it's better to be explicit "ceph config set mgr mgr/dashboard/server_port 8080", ) monA.wait_for_open_port(8080) monA.wait_until_succeeds("curl -q --fail http://localhost:8080") monA.wait_until_succeeds("ceph -s | grep 'HEALTH_OK'") </ins> ''; in { name = "basic-single-node-ceph-cluster";

Related discussion:
text: Steps to reproduce the behavior:  nixos-unstable Noticed when setting and rebuilding &lt;!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
You won't get a reply if you leave that empty.
I'm having the same issue I didn't notice when it happened, but I also have sambaFull
Same error whit the package .
This seems related to
That turned out not to be the issue. The actual error: In colour so that one can actually make sense of C++ error messages: ! One potential problem here: This is because of having: Switching to : Builds Removing entirely (which swiches to ): Fails on new related errors (see below) Removing and : Fails because Ceph requires lua = 5.3 and nixpkgs's default is still 5.2: CMake saysCould NOT find Lua (missing: LUAINCLUDEDIR) (Required is at least version "5.3")` Build failure with : <details</detailsI noticed Arch . But we can just use to fix the build.
PR for the
Code change:
<del> --- a/certdata2pem.py	2017-08-01 23:10:00.000000000 +0300 +++ b/certdata2pem.py	2017-08-01 23:08:21.131297636 +0300 @@ -88,7 +88,7 @@ # Read blacklist. blacklist = [] if os.path.exists('blacklist.txt'): -    for line in open('blacklist.txt', 'r'): +    for line in io.open('blacklist.txt', 'r', encoding='utf-8'): line = line.strip() if line.startswith('#') or len(line) == 0: continue @@ -101,7 +101,7 @@ if obj['CKA_CLASS'] != 'CKO_NSS_TRUST': continue if obj['CKA_LABEL'] in blacklist: -        print("Certificate %s blacklisted, ignoring." % obj['CKA_LABEL']) +        print("Certificate %s blacklisted, ignoring." % unicode(obj['CKA_LABEL']).encode('utf-8')) elif obj['CKA_TRUST_SERVER_AUTH'] == 'CKT_NSS_TRUSTED_DELEGATOR': trust[obj['CKA_LABEL']] = True elif obj['CKA_TRUST_EMAIL_PROTECTION'] == 'CKT_NSS_TRUSTED_DELEGATOR': </del>

Related discussion:
text: Describe the bug Putting a valid certificate name in will cause nixos-rebuild to fail. To Reproduce Steps to reproduce the behavior: this line in . This command will fail. Expected behavior finishes sucessfully. Additional context This error message is related to : I guess this error is caused by switching to python 3. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata Please run and paste the result. Maintainer information:
isn't compatible with Python 3, it seems. We'll need to update or carry a patch.
MRTC:
Code change:
sed -i '/virnetsockettest/d' tests/meson.build # delete only the first occurrence of this sed -i '0,/qemuxml2argvtest/{/qemuxml2argvtest/d;}' tests/meson.build <ins> '' + optionalString isLinux '' sed -i 's,define PARTED "parted",define PARTED "${parted}/bin/parted",'  src/storage/storage_backend_disk.c  src/storage/storage_util.c </ins> '' + optionalString isDarwin '' sed -i '/qemucapabilitiestest/d' tests/meson.build sed -i '/vircryptotest/d' tests/meson.build

Related discussion:
text: When attempting to create a volume on a physical node pool parted is not found. Steps to reproduce the behavior: Create a physical disk node pool. Attempt to create a volume using that node pool. In this case I have created a node pool called and I am attempting to create a volume called Volume is created normally. If applicable, add screenshots to help explain your problem. I have tried to add parted manually using and overriding the package in the libvirtd module: but this did not fix the issue.
That won't work, it seems like we need to wrap to include in its . I'll take a look.
You most likely need to add it to in because libvirtd will probably call it.
Code change:
sed -i '/virnetsockettest/d' tests/meson.build # delete only the first occurrence of this sed -i '0,/qemuxml2argvtest/{/qemuxml2argvtest/d;}' tests/meson.build <ins> '' + optionalString isLinux '' sed -i 's,define PARTED "parted",define PARTED "${parted}/bin/parted",'  src/storage/storage_backend_disk.c  src/storage/storage_util.c </ins> '' + optionalString isDarwin '' sed -i '/qemucapabilitiestest/d' tests/meson.build sed -i '/vircryptotest/d' tests/meson.build

Related discussion:
text: I sometimes create a qemu VM in libvirt in "session mode", meaning that the libvirt daemon is running as my non-root user, and the system-wide libvirtd does not need to be running (). This VM has a network bridge, which libvirt apparently creates by calling , which in turn uses . The problem is that doesn't get fully populated until the system libvirtd gets started. Previously, in nixpkgs (from February), this wasn't noticeable because libvirtd.service was WantedBy libvirt-guests.service (which is WantedBy multi-), so libvirtd would always be started on boot to populate that directory. Now, with , this is no longer the case, and libvirtd.service does not get started (presumably, if libvirt-guests.service actually needed to start a VM, then libvirtd.service would be socket-activated, but for me this is not the case). As a result, doesn't get populated and my session-mode libvirt can't find . python: The VM's XML file defines a network bridge, which is why gets involved. the following output: The libvirt user session should be usable without first starting the system-wide libvirtd. If you start (and optionally stop) the system libvirtd.service before following the steps to reproduce, everything works fine, because the directory gets populated. Probably, should be put somewhere else, where session-mode daemons can use it without needing to have previously started system-mode libvirtd. (The same may be true of other stuff in too.) libvirt maintainers: Okay, but I'm using flakes and that channel looks old. See relevant commit hashes above.
Oof, happy to find this, it would have taken me a long time to figure out I needed to run first. Can't the sudo wrapper point to the file in the nix store?