jiebi/CodeConvo huggingface dataset:
Code change:
The desciption of --all-namespaces is listing the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace." But when I used the following command: error: namespace may not be empty when retrieving a resource by name no namespace set on resource pods "counter" The error messages are unclear, and the second message isn't labeled as an error even.
And why couldn't use --all-namespaces flag?
You're asking for a specific pod name (counter) in all namespaces, which is a nonsensical query. The pod name is not a grep-like filter, it's a specific name. Yeah, the errors could be better. Describe could work, but potentially generates a LOT of information and API calls.
But I found the following API is supported now. Get The result is: has the more information. Do we need to support the following kubectl command(using the above API) or just return clear error messages? get pods counter --all-namespaces
I'd be ok with this being implemented via the field selector.
The issue is still here :). What's our expected result? I'd like to contribute this.
, after check the code, the URL was built by ; do you mean we should update it; or avoid to use , instead, build url () directly.
After checking the code, it's better to add fieldSelector to , is created for fieldSelector. Will submit a PR based on .
getting an object with a particular name across all namespaces seems like something we shouldn't encourage... it breaks the assumption of namespace independence.
, so we'll only update message for this issue? for example:
Disagree. Need easy way to troubleshouting the problem "why pods is stuck in Pending status". It's tiring for every pod to find who created it and in which namespace. In the logs there is only the name of the pod.
Now, with field selectors we can do To further my understanding, I'd ask:- doesn't itself break independence? One can search by label across all namespaces, it feels funny for by name to be special.

Related discussion:
text: # Clean up kubectl delete namespace other <del> ############## </del> <ins> ########### </ins> # Secrets # <del> ############## </del> <ins> ########### </ins> ### Create a new namespace # Pre-condition: the test-secrets namespace does not exist
Code change:
The desciption of --all-namespaces is listing the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace." But when I used the following command: error: namespace may not be empty when retrieving a resource by name no namespace set on resource pods "counter" The error messages are unclear, and the second message isn't labeled as an error even.
And why couldn't use --all-namespaces flag?
You're asking for a specific pod name (counter) in all namespaces, which is a nonsensical query. The pod name is not a grep-like filter, it's a specific name. Yeah, the errors could be better. Describe could work, but potentially generates a LOT of information and API calls.
But I found the following API is supported now. Get The result is: has the more information. Do we need to support the following kubectl command(using the above API) or just return clear error messages? get pods counter --all-namespaces
I'd be ok with this being implemented via the field selector.
The issue is still here :). What's our expected result? I'd like to contribute this.
, after check the code, the URL was built by ; do you mean we should update it; or avoid to use , instead, build url () directly.
After checking the code, it's better to add fieldSelector to , is created for fieldSelector. Will submit a PR based on .
getting an object with a particular name across all namespaces seems like something we shouldn't encourage... it breaks the assumption of namespace independence.
, so we'll only update message for this issue? for example:
Disagree. Need easy way to troubleshouting the problem "why pods is stuck in Pending status". It's tiring for every pod to find who created it and in which namespace. In the logs there is only the name of the pod.
Now, with field selectors we can do To further my understanding, I'd ask:- doesn't itself break independence? One can search by label across all namespaces, it feels funny for by name to be special.

Related discussion:
text: resources []string <del> namespace string names     []string </del> <ins> namespace    string allNamespace bool names        []string </ins> resourceTuples []resourceTuple
Code change:
The desciption of --all-namespaces is listing the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace." But when I used the following command: error: namespace may not be empty when retrieving a resource by name no namespace set on resource pods "counter" The error messages are unclear, and the second message isn't labeled as an error even.
And why couldn't use --all-namespaces flag?
You're asking for a specific pod name (counter) in all namespaces, which is a nonsensical query. The pod name is not a grep-like filter, it's a specific name. Yeah, the errors could be better. Describe could work, but potentially generates a LOT of information and API calls.
But I found the following API is supported now. Get The result is: has the more information. Do we need to support the following kubectl command(using the above API) or just return clear error messages? get pods counter --all-namespaces
I'd be ok with this being implemented via the field selector.
The issue is still here :). What's our expected result? I'd like to contribute this.
, after check the code, the URL was built by ; do you mean we should update it; or avoid to use , instead, build url () directly.
After checking the code, it's better to add fieldSelector to , is created for fieldSelector. Will submit a PR based on .
getting an object with a particular name across all namespaces seems like something we shouldn't encourage... it breaks the assumption of namespace independence.
, so we'll only update message for this issue? for example:
Disagree. Need easy way to troubleshouting the problem "why pods is stuck in Pending status". It's tiring for every pod to find who created it and in which namespace. In the logs there is only the name of the pod.
Now, with field selectors we can do To further my understanding, I'd ask:- doesn't itself break independence? One can search by label across all namespaces, it feels funny for by name to be special.

Related discussion:
text: if allNamespace { b.namespace = api.NamespaceAll } <ins> b.allNamespace = allNamespace </ins> return b }
Code change:
The desciption of --all-namespaces is listing the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace." But when I used the following command: error: namespace may not be empty when retrieving a resource by name no namespace set on resource pods "counter" The error messages are unclear, and the second message isn't labeled as an error even.
And why couldn't use --all-namespaces flag?
You're asking for a specific pod name (counter) in all namespaces, which is a nonsensical query. The pod name is not a grep-like filter, it's a specific name. Yeah, the errors could be better. Describe could work, but potentially generates a LOT of information and API calls.
But I found the following API is supported now. Get The result is: has the more information. Do we need to support the following kubectl command(using the above API) or just return clear error messages? get pods counter --all-namespaces
I'd be ok with this being implemented via the field selector.
The issue is still here :). What's our expected result? I'd like to contribute this.
, after check the code, the URL was built by ; do you mean we should update it; or avoid to use , instead, build url () directly.
After checking the code, it's better to add fieldSelector to , is created for fieldSelector. Will submit a PR based on .
getting an object with a particular name across all namespaces seems like something we shouldn't encourage... it breaks the assumption of namespace independence.
, so we'll only update message for this issue? for example:
Disagree. Need easy way to troubleshouting the problem "why pods is stuck in Pending status". It's tiring for every pod to find who created it and in which namespace. In the logs there is only the name of the pod.
Now, with field selectors we can do To further my understanding, I'd ask:- doesn't itself break independence? One can search by label across all namespaces, it feels funny for by name to be special.

Related discussion:
text: selectorNamespace = "" } else { if len(b.namespace) == 0 { <del> return &Result{singular: isSingular, err: fmt.Errorf("namespace may not be empty when retrieving a resource by name")} </del> <ins> errMsg := "namespace may not be empty when retrieving a resource by name" if b.allNamespace { errMsg = "a resource cannot be retrieved by name across all namespaces" } return &Result{singular: isSingular, err: fmt.Errorf(errMsg)} </ins> } }
Code change:
From gen-swagger-docs should read the local swagger spec rather than fetching it from That way it generates release api-reference when run-gen-swagger-docs is run in release branch and it generates api-reference for HEAD code, when the script is run on HEAD.
Assigning to as per discussion.
Blocks

Related discussion:
text: #run the script once to download the dependent java libraries into the image RUN mkdir /output <del> RUN build/gen-swagger-docs.sh v1 https://raw.githubusercontent.com/GoogleCloudPlatform/kubernetes/master/api/swagger-spec/v1.json https://raw.githubusercontent.com/GoogleCloudPlatform/kubernetes/master/pkg/api/v1/register.go </del> <ins> RUN mkdir /swagger-source RUN wget https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/swagger-spec/v1.json -O /swagger-source/v1.json RUN build/gen-swagger-docs.sh v1 https://raw.githubusercontent.com/GoogleCloudPlatform/kubernetes/master/pkg/api/v1/register.go RUN rm /output/* RUN rm /swagger-source/* </ins> ENTRYPOINT ["build/gen-swagger-docs.sh"]
Code change:
From gen-swagger-docs should read the local swagger spec rather than fetching it from That way it generates release api-reference when run-gen-swagger-docs is run in release branch and it generates api-reference for HEAD code, when the script is run on HEAD.
Assigning to as per discussion.
Blocks

Related discussion:
text: cd /build/ <del> wget "$2" -O input.json wget "$3" -O register.go </del> <ins> wget "$2" -O register.go # gendocs takes "input.json" as the input swagger spec. cp /swagger-source/"$1".json input.json </ins> ./gradle-2.5/bin/gradle gendocs --info
Code change:
From gen-swagger-docs should read the local swagger spec rather than fetching it from That way it generates release api-reference when run-gen-swagger-docs is run in release branch and it generates api-reference for HEAD code, when the script is run on HEAD.
Assigning to as per discussion.
Blocks

Related discussion:
text: KUBE_ROOT=$(dirname "${BASH_SOURCE}")/../.. V1_PATH="$PWD/${KUBE_ROOT}/docs/api-reference/v1/" V1BETA1_PATH="$PWD/${KUBE_ROOT}/docs/api-reference/extensions/v1beta1" <ins> SWAGGER_PATH="$PWD/${KUBE_ROOT}/api/swagger-spec/" </ins> mkdir -p $V1_PATH mkdir -p $V1BETA1_PATH <del> docker run -v $V1_PATH:/output gcr.io/google_containers/gen-swagger-docs:v2  </del> <ins> docker run -v $V1_PATH:/output -v ${SWAGGER_PATH}:/swagger-source gcr.io/google_containers/gen-swagger-docs:v3  </ins> v1  <del> https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/swagger-spec/v1.json  </del> https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/api/v1/register.go <del> docker run -v $V1BETA1_PATH:/output gcr.io/google_containers/gen-swagger-docs:v2  </del> <ins> docker run -v $V1BETA1_PATH:/output -v ${SWAGGER_PATH}:/swagger-source gcr.io/google_containers/gen-swagger-docs:v3  </ins> v1beta1  <del> https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/swagger-spec/v1beta1.json  </del> https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/apis/extensions/v1beta1/register.go
Code change:
The of the persistent-volumes walkthrough contains the volume mount which seems to be outdated for the used nginx conatiner which is by default serving from the folder. As a result, the data wrtitten in in the node will not be returned by the at the end of the walkthought. Proposed change: Update the path
Thanks for bringing up this issue, Would you be up for sending a pull request with the fix?

Related discussion:
text: - containerPort: 80 name: "http-server" volumeMounts: <del> - mountPath: "/var/www/html" </del> <ins> - mountPath: "/usr/share/nginx/html" </ins> name: mypd volumes: - name: mypd
Code change:
Per our email discussion while getting 1.1 out the door. It looks like this never happened, though, which means we're not running autoscaling tests against GCE on the 1.1 branch, (we were running it on GKE with the 1.1-features job, but I'm removing that job in ). I'd once again like to (strongly) suggest that we mirror test suites running against release branch to jobs running against master, so that we avoid this problem of accidentally not running tests when we think we are. I'd much rather have a perhaps-unnecessary slow/HPA/whatever suite than continually try to figure out where slow/HPA/whatever tests are running, depending on if I'm looking at release jobs versus jobs running against master. cc
+1 We should be running the autoscaling tests in slow or continuous.

Related discussion:
text: # Specialized tests which should be skipped by default for projects. GCE_DEFAULT_SKIP_TESTS=( "${REBOOT_SKIP_TESTS[@]}" <del> "AutoscalingsSuite" </del> "Reboot" "ServiceLoadBalancer" )
Code change:
Per our email discussion while getting 1.1 out the door. It looks like this never happened, though, which means we're not running autoscaling tests against GCE on the 1.1 branch, (we were running it on GKE with the 1.1-features job, but I'm removing that job in ). I'd once again like to (strongly) suggest that we mirror test suites running against release branch to jobs running against master, so that we avoid this problem of accidentally not running tests when we think we are. I'd much rather have a perhaps-unnecessary slow/HPA/whatever suite than continually try to figure out where slow/HPA/whatever tests are running, depending on if I'm looking at release jobs versus jobs running against master. cc
+1 We should be running the autoscaling tests in slow or continuous.

Related discussion:
text: # Tests which kills or restarts components and/or nodes. DISRUPTIVE_TESTS=( <del> "AutoscalingsSuite.*scalescluster" </del> "DaemonRestart" "Etcdsfailure" "NodessResize"
Code change:
Per our email discussion while getting 1.1 out the door. It looks like this never happened, though, which means we're not running autoscaling tests against GCE on the 1.1 branch, (we were running it on GKE with the 1.1-features job, but I'm removing that job in ). I'd once again like to (strongly) suggest that we mirror test suites running against release branch to jobs running against master, so that we avoid this problem of accidentally not running tests when we think we are. I'd much rather have a perhaps-unnecessary slow/HPA/whatever suite than continually try to figure out where slow/HPA/whatever tests are running, depending on if I'm looking at release jobs versus jobs running against master. cc
+1 We should be running the autoscaling tests in slow or continuous.

Related discussion:
text: # comments below, and for poorly implemented tests, please quote the # issue number tracking speed improvements. GCE_SLOW_TESTS=( <del> # TODO: add deployment test here once it will become stable "AutoscalingsSuite.*viasreplicationController" </del> # Before enabling this loadbalancer test in any other test list you must # make sure the associated project has enough quota. At the time of this # writing a GCE project is allowed 3 backend services by default. This
Code change:
Per our email discussion while getting 1.1 out the door. It looks like this never happened, though, which means we're not running autoscaling tests against GCE on the 1.1 branch, (we were running it on GKE with the 1.1-features job, but I'm removing that job in ). I'd once again like to (strongly) suggest that we mirror test suites running against release branch to jobs running against master, so that we avoid this problem of accidentally not running tests when we think we are. I'd much rather have a perhaps-unnecessary slow/HPA/whatever suite than continually try to figure out where slow/HPA/whatever tests are running, depending on if I'm looking at release jobs versus jobs running against master. cc
+1 We should be running the autoscaling tests in slow or continuous.

Related discussion:
text: }) // CPU tests via replication controllers <del> It(fmt.Sprintf(titleUp, "[Autoscaling Suite]", kindRC), func() { </del> <ins> It(fmt.Sprintf(titleUp, "[Skipped][Autoscaling Suite]", kindRC), func() { </ins> scaleUp("rc", kindRC, rc, f) }) <del> It(fmt.Sprintf(titleDown, "[Autoscaling Suite]", kindRC), func() { </del> <ins> It(fmt.Sprintf(titleDown, "[Skipped][Autoscaling Suite]", kindRC), func() { </ins> scaleDown("rc", kindRC, rc, f) }) })
Code change:
Hi, Right now in the installation script for Ubuntu there are hardcoded SSH_OPTS. In my case I am using a custom SSH port, and, unless I am mistaken, I have no way to customize it, either globally or on a per-host basis. Would it be possible to do that? I can try to submit a patch if necessary. Thanks.
Yes, please. Just send a PR to add in and make it configurable.

Related discussion:
text: DEBUG=${DEBUG:-"false"} <ins> # Add SSH_OPTS: Add this to config ssh port SSH_OPTS="-oPort=22 -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oLogLevel=ERROR" </ins>
Code change:
When I try to bring up my cluster (with a custom wrapper script that sources some other environment files,but calling in the end) using the AWS provider, the script fails with following reason: This happens because the correct environment variable set is . Changing the line to use this value fixes the issue.

Related discussion:
text: # This tarball is only used by Ubuntu Trusty. KUBE_MANIFESTS_TAR= <del> if [[ "${OS_DISTRIBUTION}" == "trusty" ]]; then KUBE_MANIFESTS_TAR="${KUBE_ROOT}/server/kuernetes-manifests.tar.gz" </del> <ins> if [[ "${KUBE_OS_DISTRIBUTION}" == "trusty" ]]; then KUBE_MANIFESTS_TAR="${KUBE_ROOT}/server/kubernetes-manifests.tar.gz" </ins> if [[ ! -f "${KUBE_MANIFESTS_TAR}" ]]; then KUBE_MANIFESTS_TAR="${KUBE_ROOT}/_output/release-tars/kubernetes-manifests.tar.gz" fi
Code change:
Have only seen this once, personally.
This flaked in Jenkins as well. [job/kubernetes-test-go/5351]
can you take a look at this? I think has a lot already :)

Related discussion:
text: func (f fakeRL) TryAccept() bool { return bool(f) } func (f fakeRL) Accept()         {} <del> func expectHTTP(url string, code int, t *testing.T) { </del> <ins> func expectHTTP(url string, code int) error { </ins> r, err := http.Get(url) if err != nil { <del> t.Errorf("unexpected error: %v", err) return </del> <ins> return fmt.Errorf("unexpected error: %v", err) </ins> } if r.StatusCode != code { <del> t.Errorf("unexpected response: %v", r.StatusCode) </del> <ins> return fmt.Errorf("unexpected response: %v", r.StatusCode) </ins> } <ins> return nil </ins> } func getPath(resource, namespace, name string) string {
Code change:
Have only seen this once, personally.
This flaked in Jenkins as well. [job/kubernetes-test-go/5351]
can you take a look at this? I think has a lot already :)

Related discussion:
text: // 'short' accounted ones. calls := &sync.WaitGroup{} calls.Add(AllowedInflightRequestsNo * 2) <ins> // Responses is used to wait until all responses are // received. This prevents some async requests getting EOF // errors from prematurely closing the server responses := sync.WaitGroup{} responses.Add(AllowedInflightRequestsNo * 2) </ins> // Block is used to keep requests in flight for as long as we need to. All requests will // be unblocked at the same time. block := sync.WaitGroup{}
Code change:
Have only seen this once, personally.
This flaked in Jenkins as well. [job/kubernetes-test-go/5351]
can you take a look at this? I think has a lot already :)

Related discussion:
text: for i := 0; i < AllowedInflightRequestsNo; i++ { // These should hang waiting on block... go func() { <del> expectHTTP(server.URL+"/foo/bar/watch", http.StatusOK, t) </del> <ins> if err := expectHTTP(server.URL+"/foo/bar/watch", http.StatusOK); err != nil { t.Error(err) } responses.Done() </ins> }() } // Check that sever is not saturated by not-accounted calls <del> expectHTTP(server.URL+"/dontwait", http.StatusOK, t) oneAccountedFinished := sync.WaitGroup{} oneAccountedFinished.Add(1) var once sync.Once </del> <ins> if err := expectHTTP(server.URL+"/dontwait", http.StatusOK); err != nil { t.Error(err) } </ins> // These should hang and be accounted, i.e. saturate the server for i := 0; i < AllowedInflightRequestsNo; i++ { // These should hang waiting on block... go func() { <del> expectHTTP(server.URL, http.StatusOK, t) once.Do(oneAccountedFinished.Done) </del> <ins> if err := expectHTTP(server.URL, http.StatusOK); err != nil { t.Error(err) } responses.Done() </ins> }() } // We wait for all calls to be received by the server
Code change:
Have only seen this once, personally.
This flaked in Jenkins as well. [job/kubernetes-test-go/5351]
can you take a look at this? I think has a lot already :)

Related discussion:
text: // Do this multiple times to show that it rate limit rejected requests don't block. for i := 0; i < 2; i++ { <del> expectHTTP(server.URL, errors.StatusTooManyRequests, t) </del> <ins> if err := expectHTTP(server.URL, errors.StatusTooManyRequests); err != nil { t.Error(err) } </ins> } // Validate that non-accounted URLs still work <del> expectHTTP(server.URL+"/dontwait/watch", http.StatusOK, t) </del> <ins> if err := expectHTTP(server.URL+"/dontwait/watch", http.StatusOK); err != nil { t.Error(err) } </ins> // Let all hanging requests finish block.Done() // Show that we recover from being blocked up. // Too avoid flakyness we need to wait until at least one of the requests really finishes. <del> oneAccountedFinished.Wait() expectHTTP(server.URL, http.StatusOK, t) </del> <ins> responses.Wait() if err := expectHTTP(server.URL, http.StatusOK); err != nil { t.Error(err) } </ins> } func TestReadOnly(t *testing.T) {
Code change:
there is a test that you marked as skipped that needs to be reenabled or otherwise taken care of (see ): "Security Context [Skipped]" Can we instead classify these as ? See for context. Happy to answer any questions if anything doesn't make sense.
This is work toward .
I like the reclassification! I would be happy to relabel the test. I'll wait for to merge though
has been merged; if you send a PR, I will review it. Thank you!

Related discussion:
text: return pod } <del> var _ = Describe("Security Context [Skipped]", func() { </del> <ins> var _ = Describe("Security Context [Feature:SecurityContext]", func() { </ins> framework := NewFramework("security-context") It("should support pod.Spec.SecurityContext.SupplementalGroups", func() {
Code change:
cc:
It was broken by . I'll send a fix in a sec.
Sorry & thanks for fixing.

Related discussion:
text: find-release-tars upload-server-tars <ins> # ensure that environmental variables specifying number of migs to create set_num_migs </ins> if [[ ${KUBE_USE_EXISTING_MASTER:-} == "true" ]]; then create-nodes create-autoscaler