jiebi/CodeConvo huggingface dataset:
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /assign What happened: The tests are failing again because the scheduler messages have changed yet again. I'm going to remove the check for the exact messages because this is at least the 3rd time this has happened. Instead depend on unit/integration tests to check for specific failures. Also there's no need for these tests to run across all types of local volumes because it's just testing the scheduler part.

Related discussion:
text: type makeLocalPodWith func(config *localTestConfig, volume *localTestVolume, nodeName string) *v1.Pod <del> func testPodWithNodeName(config *localTestConfig, testVolType localVolumeType, ep *eventPatterns, nodeName string, makeLocalPodFunc makeLocalPodWith, bindingMode storagev1.VolumeBindingMode) { </del> <ins> func testPodWithNodeConflict(config *localTestConfig, testVolType localVolumeType, nodeName string, makeLocalPodFunc makeLocalPodWith, bindingMode storagev1.VolumeBindingMode) { </ins> By(fmt.Sprintf("local-volume-type: %s", testVolType)) testVols := setupLocalVolumesPVCsPVs(config, testVolType, config.node0, 1, bindingMode) testVol := testVols[0]
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /assign What happened: The tests are failing again because the scheduler messages have changed yet again. I'm going to remove the check for the exact messages because this is at least the 3rd time this has happened. Instead depend on unit/integration tests to check for specific failures. Also there's no need for these tests to run across all types of local volumes because it's just testing the scheduler part.

Related discussion:
text: pod := makeLocalPodFunc(config, testVol, nodeName) pod, err := config.client.CoreV1().Pods(config.ns).Create(pod) Expect(err).NotTo(HaveOccurred()) <del> err = framework.WaitForPodRunningInNamespace(config.client, pod) Expect(err).To(HaveOccurred()) checkPodEvents(config, pod.Name, ep) </del> <ins> err = framework.WaitForPodNameUnschedulableInNamespace(config.client, pod.Name, pod.Namespace) Expect(err).NotTo(HaveOccurred()) </ins> cleanupLocalVolumes(config, []*localTestVolume{testVol}) }
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: I tried to use pvs provisioned by the cephfs storageclass build from PV and pvc are OK but it failed when mounting. here is the output of the ceph-fuse mount command: I try the ceph-fuse mounting outside kubernetes environment, and found that I have to pass the --id argument to make ceph-fuse work correctly: so I add the --id option in file on line 401: and cephfs volumes can mount corretly with ceph-fuse then. Anything else we need to know?: My kubernetes cluster version is v1.6.7, running on arm64 servers, with ceph version 10.1.2, the kernel version is 4.4.58 . I backported the latest version to mount cephfs volumes with ceph-fuse.
/sig storage
Does this problem still exist in the latest k8s version?
yes, I've tested on kubernetes v1.10.0-alpha.3 with ceph version 10.2.10 and the problem still exists
OK, let me see it ,and feedback soon. =)
Hi, one question is that do you use 'admin' as user or other user to mount cephfs by fuse ?
when no "--id" specified, the default user is admin, which will result in bug when user is not admin.
/assign

Related discussion:
text: mountArgs = append(mountArgs, mountpoint) mountArgs = append(mountArgs, "-r") mountArgs = append(mountArgs, cephfsVolume.path) <ins> mountArgs = append(mountArgs, "--id") mountArgs = append(mountArgs, cephfsVolume.id) </ins> glog.V(4).Infof("Mounting cmd ceph-fuse with arguments (%s)", mountArgs) command := exec.Command("ceph-fuse", mountArgs...)
Code change:
/kind test-flake https://k8s-
/kind flake
cc
Saw this on
Sorry, I haven't had time to look into this. Let's see if can get to this earlier than I do.
I'm seeing this a lot in the rush to code freeze.
if this is actually a 1.10 bug, can you add status/approved-for-milestone to it? Thanks.
Something suspicious from the , but probably it's not related to the failure:
The garbage collector's behavior looks right, it does delete the dependent configmap: The tested start at 16:44:27., and failed with "test timed out after 5m0s" at 16:44:50.. I'll check if other failed cases have the same causes.
The "Kubernetes Aggregated Failures" shows there is no "TestCRDDeletionCascading" failure in the last tests (). Maybe I used the wrong tool? cc
cc because triage does not support pull-kubernetes-unit? I cannot find in as well
gave a new failure sample: https://k8s- (And the triage dashboard can't find it). Anyway, the test showed similar behavior. The tested started at I0226 20:57:02.. The gc behaved correctly: And the 5min timeout occurred 23s after the test began. I'll check what's the 5min timeout for.
The 5 min timeout is for all the tests in the test/integration/garbagecollector package. The tests are run sequentially, so is the last one to run, and unfortunately uses up the 5 min quota. The two logs I looked into showed the test itself was healthy. We just need to increase the timeout limit for this package.
found a lot of failure samples here: https://k8s- The first 11 of them failed because the 5m timeout.
Indicates this is still present and severe.
I was trying to get recent failures, it seems we recently moved intergration tests out of the unit test suites, https://k8s-, where there is no failure yet. I'll try again tomorrow.
(we rename the job this afternoon, it was named kubernetes-unit but only runs integration test)
https://k8s- that looks all green so far
Can we also check run time of the tests in that package over the past couple weeks? It seems like this just spiked. Did our tests slow down, or did we add tests to that package?
as far as I can tell the runtime of the test didn't spike ( shows the test running in just over 300s and also included the original bump of the timeout from 300s to 600s), but the timeout was accidentally decreased from 600s back to 300s as an unintended side effect of
ah, ok
Since it has passed the last 26 times, is this safe to reclose?
/close

Related discussion:
text: export ARTIFACTS_DIR=${WORKSPACE}/artifacts # Save the verbose stdout as well. export KUBE_KEEP_VERBOSE_TEST_OUTPUT=y <del> export KUBE_TIMEOUT='-timeout 300s' </del> export KUBE_INTEGRATION_TEST_MAX_CONCURRENCY=4 export LOG_LEVEL=4
Code change:
Is this a BUG REPORT or FEATURE REQUEST?: What happened: docs recommend using '--leader-elect' to have HA setup for kube-scheduler and kube-controller-manager. However, these two components approach differently what is default value for the flag. . . Seems that setting the value to true in kube-scheduler code was lost in refactoring scheduler API config in . The code before refactoring had the value . What you expected to happen: kube-scheduler set true as a default value for '--leader-elect' Environment:
not sure I picked right SIG
/sig api-machinery
/assign
/sig scheduling

Related discussion:
text: return nil, err } <ins> // TODO: we should fix this up better (PR 59732) o.config.LeaderElection.LeaderElect = true </ins> return o, nil }
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: import ( "context" "fmt" <ins> "os" "strings" </ins> "k8s.io/api/core/v1" "k8s.io/kubernetes/pkg/cloudprovider"
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: func (az *Cloud) isCurrentInstance(name types.NodeName) (bool, error) { nodeName := mapNodeNameToVMName(name) metadataName, err := az.metadata.Text("instance/compute/name") <ins> if err != nil { return false, err } if az.VMType == vmTypeVMSS { // VMSS vmName is not same with hostname, use hostname instead. metadataName, err = os.Hostname() if err != nil { return false, err } } metadataName = strings.ToLower(metadataName) </ins> return (metadataName == nodeName), err } // InstanceID returns the cloud provider ID of the specified instance. // Note that if the instance does not exist or is no longer running, we must return ("", cloudprovider.InstanceNotFound) func (az *Cloud) InstanceID(ctx context.Context, name types.NodeName) (string, error) { <ins> nodeName := mapNodeNameToVMName(name) </ins> if az.UseInstanceMetadata { isLocalInstance, err := az.isCurrentInstance(name) if err != nil { return "", err } <del> if isLocalInstance { nodeName := mapNodeNameToVMName(name) return az.getMachineID(nodeName), nil </del> <ins> // Not local instance, get instanceID from Azure ARM API. if !isLocalInstance { return az.vmSet.GetInstanceIDByNodeName(nodeName) } // Compose instanceID based on nodeName for standard instance. if az.VMType == vmTypeStandard { return az.getStandardMachineID(nodeName), nil } // Get scale set name and instanceID from vmName for vmss. metadataName, err := az.metadata.Text("instance/compute/name") if err != nil { return "", err } ssName, instanceID, err := extractVmssVMName(metadataName) if err != nil { return "", err </ins> } <ins> // Compose instanceID based on ssName and instanceID for vmss instance. return az.getVmssMachineID(ssName, instanceID), nil </ins> } <del> return az.vmSet.GetInstanceIDByNodeName(string(name)) </del> <ins> return az.vmSet.GetInstanceIDByNodeName(nodeName) </ins> } // InstanceTypeByProviderID returns the cloudprovider instance type of the node with the specified unique providerID
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: var errNotInVMSet = errors.New("vm is not in the vmset") var providerIDRE = regexp.MustCompile(`^` + CloudProviderName + `://(?:.*)/Microsoft.Compute/virtualMachines/(.+)$`) <del> // returns the full identifier of a machine func (az *Cloud) getMachineID(machineName string) string { </del> <ins> // getStandardMachineID returns the full identifier of a virtual machine. func (az *Cloud) getStandardMachineID(machineName string) string { </ins> return fmt.Sprintf( machineIDTemplate, az.SubscriptionID,
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: // ErrorNotVmssInstance indicates an instance is not belongint to any vmss. ErrorNotVmssInstance = errors.New("not a vmss instance") <del> scaleSetNameRE = regexp.MustCompile(`.*/subscriptions/(?:.*)/Microsoft.Compute/virtualMachineScaleSets/(.+)/virtualMachines(?:.*)`) </del> <ins> scaleSetNameRE        = regexp.MustCompile(`.*/subscriptions/(?:.*)/Microsoft.Compute/virtualMachineScaleSets/(.+)/virtualMachines(?:.*)`) vmssMachineIDTemplate = "/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/virtualMachineScaleSets/%s/virtualMachines/%s" </ins> ) // scaleSet implements VMSet interface for Azure scale set.
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: return nil } <ins> // getVmssMachineID returns the full identifier of a vmss virtual machine. func (az *Cloud) getVmssMachineID(scaleSetName, instanceID string) string { return fmt.Sprintf( vmssMachineIDTemplate, az.SubscriptionID, az.ResourceGroup, scaleSetName, instanceID) } </ins>
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: return fmt.Sprintf("%s%s%s", scaleSetName, vmssNameSeparator, instanceID) } <del> func (ss *scaleSet) extractVmssVMName(name string) (string, string, error) { </del> <ins> func extractVmssVMName(name string) (string, string, error) { </ins> ret := strings.Split(name, vmssNameSeparator) if len(ret) != 2 { glog.Errorf("Failed to extract vmssVMName %q", name)
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: func (ss *scaleSet) newVmssVMCache() (*timedCache, error) { getter := func(key string) (interface{}, error) { // vmssVM name's format is 'scaleSetName_instanceID' <del> ssName, instanceID, err := ss.extractVmssVMName(key) </del> <ins> ssName, instanceID, err := extractVmssVMName(key) </ins> if err != nil { return nil, err }
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: ) func TestExtractVmssVMName(t *testing.T) { <del> ss := &scaleSet{} </del> cases := []struct { description        string vmName             string
Code change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
adding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon

Related discussion:
text: } for _, c := range cases { <del> ssName, instanceID, err := ss.extractVmssVMName(c.vmName) </del> <ins> ssName, instanceID, err := extractVmssVMName(c.vmName) </ins> if c.expectError { assert.Error(t, err, c.description) continue
Code change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating an IPv6 cluster, the --pod-network-cidr needs to be a /66, it cannot be for a larger network (smaller value) What you expected to happen: Should be able to use values smaller then /66, /64 or a /48 How to reproduce it (as minimally and precisely as possible): Create a cluster with Kubeadm, and set the podSubnet as below networking: podSubnet: "fd00:1:2:3::/64" Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area ipv6 /sig network
/assign rpothier

Related discussion:
text: // RangeSize returns the size of a range in valid addresses. func RangeSize(subnet *net.IPNet) int64 { ones, bits := subnet.Mask.Size() <del> if bits == 32 && (bits-ones) >= 31 || bits == 128 && (bits-ones) >= 63 { </del> <ins> if bits == 32 && (bits-ones) >= 31 || bits == 128 && (bits-ones) >= 127 { </ins> return 0 } <del> max := int64(1) << uint(bits-ones) return max </del> <ins> // For IPv6, the max size will be limited to 65536 // This is due to the allocator keeping track of all the // allocated IP's in a bitmap. This will keep the size of // the bitmap to 64k. if bits == 128 && (bits-ones) >= 16 { return int64(1) << uint(16) } else { return int64(1) << uint(bits-ones) } </ins> } // GetIndexedIP returns a net.IP that is subnet.IP + index in the contiguous IP space.
Code change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating an IPv6 cluster, the --pod-network-cidr needs to be a /66, it cannot be for a larger network (smaller value) What you expected to happen: Should be able to use values smaller then /66, /64 or a /48 How to reproduce it (as minimally and precisely as possible): Create a cluster with Kubeadm, and set the podSubnet as below networking: podSubnet: "fd00:1:2:3::/64" Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area ipv6 /sig network
/assign rpothier

Related discussion:
text: }, { name:  "supported IPv6 cidr", <del> cidr:  "2001:db8::/98", addrs: 1073741824, </del> <ins> cidr:  "2001:db8::/48", addrs: 65536, </ins> }, { name:  "unsupported IPv6 mask", <del> cidr:  "2001:db8::/65", </del> <ins> cidr:  "2001:db8::/1", </ins> addrs: 0, }, }