Code change:
<ins> /* Copyright 2021 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package rest import ( "context" "testing" v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" utilpointer "k8s.io/utils/pointer" ) type mockStrategy struct { RESTDeleteStrategy RESTGracefulDeleteStrategy } func (m mockStrategy) ObjectKinds(obj runtime.Object) ([]schema.GroupVersionKind, bool, error) { gvk := obj.GetObjectKind().GroupVersionKind() if len(gvk.Kind) == 0 { return nil, false, runtime.NewMissingKindErr("object has no kind field ") } if len(gvk.Version) == 0 { return nil, false, runtime.NewMissingVersionErr("object has no apiVersion field") } return []schema.GroupVersionKind{obj.GetObjectKind().GroupVersionKind()}, false, nil } func TestBeforeDelete(t *testing.T) { type args struct { strategy RESTDeleteStrategy ctx      context.Context pod      *v1.Pod options  *metav1.DeleteOptions } makePod := func(deletionGracePeriodSeconds int64) *v1.Pod { return &v1.Pod{ TypeMeta: metav1.TypeMeta{APIVersion: "v1", Kind: "Pod"}, ObjectMeta: metav1.ObjectMeta{ DeletionTimestamp:          &metav1.Time{}, DeletionGracePeriodSeconds: &deletionGracePeriodSeconds, }, } } makeOption := func(gracePeriodSeconds int64) *metav1.DeleteOptions { return &metav1.DeleteOptions{ GracePeriodSeconds: &gracePeriodSeconds, } } tests := []struct { name                           string args                           args wantGraceful                   bool wantGracefulPending            bool wantGracePeriodSeconds         *int64 wantDeletionGracePeriodSeconds *int64 wantErr                        bool }{ { name: "when DeletionGracePeriodSeconds=-1, GracePeriodSeconds=-1", args: args{ pod:     makePod(-1), options: makeOption(-1), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   false, wantGracefulPending:            true, }, { name: "when DeletionGracePeriodSeconds=-1, GracePeriodSeconds=0", args: args{ pod:     makePod(-1), options: makeOption(0), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(0), wantGraceful:                   true, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=-1, GracePeriodSeconds=1", args: args{ pod:     makePod(-1), options: makeOption(1), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   false, wantGracefulPending:            true, }, { name: "when DeletionGracePeriodSeconds=-1, GracePeriodSeconds=2", args: args{ pod:     makePod(-1), options: makeOption(2), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(2), wantGraceful:                   false, wantGracefulPending:            true, }, { name: "when DeletionGracePeriodSeconds=0, GracePeriodSeconds=-1", args: args{ pod:     makePod(0), options: makeOption(-1), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   false, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=0, GracePeriodSeconds=0", args: args{ pod:     makePod(0), options: makeOption(0), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(0), wantGraceful:                   false, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=0, GracePeriodSeconds=1", args: args{ pod:     makePod(0), options: makeOption(1), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   false, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=0, GracePeriodSeconds=2", args: args{ pod:     makePod(0), options: makeOption(2), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(2), wantGraceful:                   false, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=1, GracePeriodSeconds=-1", args: args{ pod:     makePod(1), options: makeOption(-1), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   false, wantGracefulPending:            true, }, { name: "when DeletionGracePeriodSeconds=1, GracePeriodSeconds=0", args: args{ pod:     makePod(1), options: makeOption(0), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(0), wantGraceful:                   true, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=1, GracePeriodSeconds=1", args: args{ pod:     makePod(1), options: makeOption(1), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   false, wantGracefulPending:            true, }, { name: "when DeletionGracePeriodSeconds=1, GracePeriodSeconds=2", args: args{ pod:     makePod(1), options: makeOption(2), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(2), wantGraceful:                   false, wantGracefulPending:            true, }, { name: "when DeletionGracePeriodSeconds=2, GracePeriodSeconds=-1", args: args{ pod:     makePod(2), options: makeOption(-1), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   true, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=2, GracePeriodSeconds=0", args: args{ pod:     makePod(2), options: makeOption(0), }, // want 0 wantDeletionGracePeriodSeconds: utilpointer.Int64(0), wantGracePeriodSeconds:         utilpointer.Int64(0), wantGraceful:                   true, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=2, GracePeriodSeconds=1", args: args{ pod:     makePod(2), options: makeOption(1), }, // want 1 wantDeletionGracePeriodSeconds: utilpointer.Int64(1), wantGracePeriodSeconds:         utilpointer.Int64(1), wantGraceful:                   true, wantGracefulPending:            false, }, { name: "when DeletionGracePeriodSeconds=2, GracePeriodSeconds=2", args: args{ pod:     makePod(2), options: makeOption(2), }, // want 2 wantDeletionGracePeriodSeconds: utilpointer.Int64(2), wantGracePeriodSeconds:         utilpointer.Int64(2), wantGraceful:                   false, wantGracefulPending:            true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { if tt.args.strategy == nil { tt.args.strategy = mockStrategy{} } if tt.args.ctx == nil { tt.args.ctx = context.Background() } gotGraceful, gotGracefulPending, err := BeforeDelete(tt.args.strategy, tt.args.ctx, tt.args.pod, tt.args.options) if (err != nil) != tt.wantErr { t.Errorf("BeforeDelete() error = %v, wantErr %v", err, tt.wantErr) return } if gotGraceful != tt.wantGraceful { t.Errorf("BeforeDelete() gotGraceful = %v, want %v", gotGraceful, tt.wantGraceful) } if gotGracefulPending != tt.wantGracefulPending { t.Errorf("BeforeDelete() gotGracefulPending = %v, want %v", gotGracefulPending, tt.wantGracefulPending) } if gotGracefulPending != tt.wantGracefulPending { t.Errorf("BeforeDelete() gotGracefulPending = %v, want %v", gotGracefulPending, tt.wantGracefulPending) } if !utilpointer.Int64Equal(tt.args.pod.DeletionGracePeriodSeconds, tt.wantDeletionGracePeriodSeconds) { t.Errorf("metadata.DeletionGracePeriodSeconds = %v, want %v", utilpointer.Int64Deref(tt.args.pod.DeletionGracePeriodSeconds, 0), utilpointer.Int64Deref(tt.wantDeletionGracePeriodSeconds, 0)) } if !utilpointer.Int64Equal(tt.args.options.GracePeriodSeconds, tt.wantGracePeriodSeconds) { t.Errorf("options.GracePeriodSeconds = %v, want %v", utilpointer.Int64Deref(tt.args.options.GracePeriodSeconds, 0), utilpointer.Int64Deref(tt.wantGracePeriodSeconds, 0)) } }) } } </ins>

Related discussion:
text: <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Some k8s client tried to evict a pod by setting negative value for deletionGracePeriodSeconds. But all eventual delete calls (and force-delete calls) made by kubelet, pod-garbage-collector, etc were not able to delete that pod, because apiserver doesnt allow deletionGracePeriodSeconds to be increased once it is set. So force-delete (which set it to 0) doesn't take effect when it's already negative. Not even kubectl is able to call delete with negative grace-period. But curl with an even more negative grace-period value worked. What you expected to happen: force-delete works. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: I think the issue is in the code below As the comment suggest, in phase 1, the was set to a negative value (meaning was in the past), and in phase 2, has to be set even lower, otherwise, it will be considered as pending graceful deletion and not performing the immediate delete. I think there're two possible fixes. not allowing setting in the past ( should be non-negative). In that case, we could convert to 0 if negative. that could be set in the past. In that case, in phase 2, we treat negative value of the same as 0, and allow immediate delete. Thoughts? Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig api-machinery
The label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig api-machinery Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/cc /triage accepted
No component in the system should ever treat the timestamp of DeletionTimestamp as authoritative.