jiebi/CodeConvo huggingface dataset:
Code change:
// if the secret is not nil, compare it if expectedCall.expectedSecret != nil { <del> if !reflect.DeepEqual(expectedCall.expectedSecret, c.Request.Secret) { return allCalls, i, fmt.Errorf("Unexpected secret: expected %v, got %v", expectedCall.expectedSecret, c.Request.Secret) </del> <ins> if !reflect.DeepEqual(expectedCall.expectedSecret, c.Request.Secrets) { return allCalls, i, fmt.Errorf("Unexpected secret: expected %v, got %v", expectedCall.expectedSecret, c.Request.Secrets) </ins> } }

Related discussion:
text: Seen in pull-kubernetes-e2e-gce-cos-alpha-features Specific job failure
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
from the error message I don't know if it refers to the sig-storage error or to the sig-auth one
/sig storage
/kind failing-test
/assign From : ... I am not sure if it's related:
is the culprit. cannot be used inside a . This only gets caught when the test actually runs, otherwise Ginkgo never sees the incorrect .
I don’t understand why sometimes it can get the pv by namebut sometimes it failed
but then is a sig-auth test , not storage , sorry /sig auth this seems that was recently in
/remove sig-storage
/assign /priority important-soon
/unassign
is still failed. seems not fixing the whole problem. /reopen feel free to close if the ci is green.
Reopened this issue. <detailsIn response to : is still failed. /reopen feel free to close if the ci is green. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
the failure now looks like it is just a sig storage issue:
cc
/assign looks like the new test is still an issue
I think this line is the problem: When the test creates the object, it may take time for the PV to be provisioned and to be bound to the PVC. So you should do another before this call so you can get the latest PVC object with the bound PV.
I opened to get PVC again before using .
Only do PersistentVolumeClaims.Get() is not enough, whether we need to wait for sometimes to wait it bound? because sometimes the testcase is successful and sometime is failed.
If the Pod was able to run, then the PVC has to be bound.
so I can't understand why sometimes the testcase is successful and sometimes is failed.
Code change:
// if the secret is not nil, compare it if expectedCall.expectedSecret != nil { <del> if !reflect.DeepEqual(expectedCall.expectedSecret, c.Request.Secret) { return allCalls, i, fmt.Errorf("Unexpected secret: expected %v, got %v", expectedCall.expectedSecret, c.Request.Secret) </del> <ins> if !reflect.DeepEqual(expectedCall.expectedSecret, c.Request.Secrets) { return allCalls, i, fmt.Errorf("Unexpected secret: expected %v, got %v", expectedCall.expectedSecret, c.Request.Secrets) </ins> } }

Related discussion:
text: By default, the DelayBinding is false, it will wait for PVC bound during creation. This is weird.
It waits for the claim to be bound, but the test case still needs to refresh its pvc object.
Because of the refresh is async, so after the pvc was bound, we need to get the pvc again, isn't it?
Code change:
// case 1: node1:SG1  node2:SG2  return SG1,SG2 // case 2: node1:SG1,SG2  node2:SG3,SG4  return SG1,SG3 // case 3: node1:SG1,SG2  node2:SG2,SG3  return SG1,SG2 <del> securityGroupName := srv.SecurityGroups[0]["name"] nodeSecurityGroupIDs.Insert(securityGroupName.(string)) </del> <ins> secGroupNames.Insert(srv.SecurityGroups[0]["name"].(string)) </ins> } <del> return nodeSecurityGroupIDs.List(), nil </del> <ins> secGroupIDs := make([]string, secGroupNames.Len()) for i, name := range secGroupNames.List() { secGroupID, err := groups.IDFromName(network, name) if err != nil { return []string{}, err } secGroupIDs[i] = secGroupID } return secGroupIDs, nil </ins> } // isSecurityGroupNotFound return true while 'err' is object of gophercloud.ErrResourceNotFound

Related discussion:
text: Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: kubelet fails when Kubernetes master gets started using cloud-provider openstack und kubeadm init command. says: What you expected to happen: kubelet starts and manages the loadbalancer and its security group. How to reproduce it (as minimally and precisely as possible): Setup an instance on Openstack. Place the following cloud-config in And : As well as : Run: For further information: +-----------------+
--------------------------+ +-----------------+
--------------------------+ +-----------------+
--------------------------+ Environment: Kubernetes version (use ): 1.9.1 Cloud provider or hardware configuration: Openstack OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS Kernel (e.g. ): x86_64 Install tools: kubeadm
/sig cloud-provider
Looks like auto-probing for for (s), please see [1] and [2]. Apologies, the deprecation should have been handled better. [1] [2]
If I understand you correctly, this cloud-config would be enough: If I try this, no Loadbalancer gets created at all and the service which requests type LoadBalancer says: The service I use there is the nginx helm chart ().
Can you please comment? /assign
/sig openstack
From that, '' is your service name and '-202f-4d44-a538-' is your subnet id, can you ensure '-202f-4d44-a538-' exist? Is it "-c60c-48cb-a146-"? I suspect that failed to autoprobe subnet. Can you give me more logs from kube controller manager
Actually, -202f-4d44-a538- is a network, not a subnet. The subnet has the ID -c1d5-4cc1-8b98-
And here the relevant logs from kube-controller-manager,first: And then it keeps repeating:
Oh, I see. Oops, should get 'sub network id', not 'network id'. I will fix it soon.
I tried the fix in 1.9.2, but it does not work. I tried multiple setting combinations of providing and/or/neither , but none works. The Service does not get a LoadBalancer IP assigned.
Code change:
// case 1: node1:SG1  node2:SG2  return SG1,SG2 // case 2: node1:SG1,SG2  node2:SG3,SG4  return SG1,SG3 // case 3: node1:SG1,SG2  node2:SG2,SG3  return SG1,SG2 <del> securityGroupName := srv.SecurityGroups[0]["name"] nodeSecurityGroupIDs.Insert(securityGroupName.(string)) </del> <ins> secGroupNames.Insert(srv.SecurityGroups[0]["name"].(string)) </ins> } <del> return nodeSecurityGroupIDs.List(), nil </del> <ins> secGroupIDs := make([]string, secGroupNames.Len()) for i, name := range secGroupNames.List() { secGroupID, err := groups.IDFromName(network, name) if err != nil { return []string{}, err } secGroupIDs[i] = secGroupID } return secGroupIDs, nil </ins> } // isSecurityGroupNotFound return true while 'err' is object of gophercloud.ErrResourceNotFound

Related discussion:
text: Here are the logs and settings for the config version neither providing nor , since it seemed that's the way you recommended to me: cat /etc/kubernetes/pki/cloud-config kubectl get nodes journalctl -u kubelet.service kubectl describe svc ingress-nginx-ingress-controller Can you please re-open the issue? Do you need any other information?
Is it ok when you disable manage-security-group(manage-security-group=false)?
And please review .
/reopen
Yes, when I disable "manage-security-group" it assigns a LoadBalancer correctly. It also works, as soon as I run . I tried to check , but since I don't know go, I don't really understand what you are doing there and how it relates to my issue.
I check gophercloud.ErrResourceNotFound is not a interface, so the '' will return error and excute "" which is 'error occurred finding security group: ...'.
Okay, so you "just" print a better error message, right? But my question is, why does the error occur at all? In my understanding the kubelet should create a security-group on itself, if configured manage-security-groups=true and do not provide a security-group. However I also tried to define a valid security group id on my own, but in that case I again find these logs in kubelet (same as described first):
Okay, so you "just" print a better error message, right? But my question is, why does the error occur at all? In my understanding the kubelet should create a security-group on itself, if configured manage-security-groups=true and do not provide a security-group. No, not 'just print a better error message', openstack cloud provider can ensure security group for LB. Firstly, openstack cloud provider check whether security group does not exist, if not exist, it will create security group for LB. The "gophercloud.ErrResourceNotFound" means that security group not exist.
Now OpenStack cloud provider has not "node-security-group" variable. You should not specify it.
Please check this note:
Well, to me it does not look like the removal of any resources is the problem, rather that they do not get created at all. I can offer you a direct debugging session using Google Hangout or so, maybe that way it is easier to detect the real problem?
Have you see this log?
Code change:
// case 1: node1:SG1  node2:SG2  return SG1,SG2 // case 2: node1:SG1,SG2  node2:SG3,SG4  return SG1,SG3 // case 3: node1:SG1,SG2  node2:SG2,SG3  return SG1,SG2 <del> securityGroupName := srv.SecurityGroups[0]["name"] nodeSecurityGroupIDs.Insert(securityGroupName.(string)) </del> <ins> secGroupNames.Insert(srv.SecurityGroups[0]["name"].(string)) </ins> } <del> return nodeSecurityGroupIDs.List(), nil </del> <ins> secGroupIDs := make([]string, secGroupNames.Len()) for i, name := range secGroupNames.List() { secGroupID, err := groups.IDFromName(network, name) if err != nil { return []string{}, err } secGroupIDs[i] = secGroupID } return secGroupIDs, nil </ins> } // isSecurityGroupNotFound return true while 'err' is object of gophercloud.ErrResourceNotFound

Related discussion:
text: It means the security group we need to create does not exist, we should create it, not raise error, right? And I get 'non-interface type ErrResourceNotFound on left' error, 'err.(*gophercloud.ErrResourceNotFound)' is incorrect.
Yes, exactly. I also tried to fix the error manually, so first I created the sg-group . After that kubelet complained about empty pool-targets. After fixing that, it complained about invalid endpoint which pointed to the nginx server, don't know how to fix that one yet. I just want to point out: All that errors only occur if I activate manageSecurityGroups, otherwise the kubelet is able to assign a LoadBalancer to the IngressController.
Hi, how is going? I've deployed k8s 1.9.5 on OpenStack with kubespray and I'm struggling with this issue. If I do not set the LBAAS is created but it's not assigned to any Security Group. So, the service is not reachable from the outside world. I can fix it by hand creating the Security Group and assign it to the VIP. If I do set kubelet fails to start. According to it's a valid parameter... (?) And finally, if I do as in his last comment, the LBAAS remains in a PENDING state forever... Well, I wonder if there is any workaround to deal with this... I presume you're working on the fix, aren't you? Any information will be appreciate. Thanks
I'm hitting the same issue as yours with openstack loadbalancer with 1.9.4. Anyone know if fixes this issue? If so, when will it be part of a release?
Any updates on this?
I just tried to use this feature in kubernetes 1.10.2 and it still seems to be broken. The security groups do not get created and the service creation is stuck at pending without an ip address. I used this configuration and i also tried all the alternatives listed here. Either nothing gets created or the controller-manager crashes if i add node-security-group.
It's an issue with as well. The behaviour is as described by
Bump
fixes this for us.
So, If I do not enable manage-security-groups, This should work?
Code change:
// case 1: node1:SG1  node2:SG2  return SG1,SG2 // case 2: node1:SG1,SG2  node2:SG3,SG4  return SG1,SG3 // case 3: node1:SG1,SG2  node2:SG2,SG3  return SG1,SG2 <del> securityGroupName := srv.SecurityGroups[0]["name"] nodeSecurityGroupIDs.Insert(securityGroupName.(string)) </del> <ins> secGroupNames.Insert(srv.SecurityGroups[0]["name"].(string)) </ins> } <del> return nodeSecurityGroupIDs.List(), nil </del> <ins> secGroupIDs := make([]string, secGroupNames.Len()) for i, name := range secGroupNames.List() { secGroupID, err := groups.IDFromName(network, name) if err != nil { return []string{}, err } secGroupIDs[i] = secGroupID } return secGroupIDs, nil </ins> } // isSecurityGroupNotFound return true while 'err' is object of gophercloud.ErrResourceNotFound

Related discussion:
text: I am getting the following error: Error creating load balancer (will retry): failed to ensure load balancer for service default/lbs-test: error creating LB floatingip {FloatingNetworkID:YYYY FloatingIP: PortID:XXXX FixedIP: TenantID:}: Resource not found
Yes. Don't specify and at all in config. The LoadBalancer(s) will by default apply the security rules in the security-group .
You need to specify to automatically add / alter security groups. I get the following error after I've upgraded to 1.9.10:
I ran into the same issue. It seems to be related to how k8's openstack driver deals with adding floating ips to the LB. For now I set the lb to internal in the service metadata then manually associate a floating ip . This could also be a queens magnum issue not providing all required cloud config info. I am not sure yet.
Code change:
return err } if !notMnt { <del> return nil </del> <ins> // testing original mount point, make sure the mount link is valid if _, err := ioutil.ReadDir(dir); err == nil { glog.V(4).Infof("azureFile - already mounted to target %s", dir) return nil } // mount link is invalid, now unmount and remount later glog.Warningf("azureFile - ReadDir %s failed with %v, unmount this directory", dir, err) if err := b.mounter.Unmount(dir); err != nil { glog.Errorf("azureFile - Unmount directory %s failed with %v", dir, err) return err } notMnt = true </ins> } var accountKey, accountName string if accountName, accountKey, err = b.util.GetAzureCredentials(b.plugin.host, b.secretNamespace, b.secretName); err != nil { return err

Related discussion:
text: <!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: azure file plugin on Windows does not work after node restart, this is due to powershell cmdlet has lost account name/key after reboot, we should remove the invalid link and do the mount again after kubelet restart. What you expected to happen: azure file plugin on Windows should work after node restart How to reproduce it (as minimally and precisely as possible): has created a pod with azure file mount on Windows agent node could get following error: Anything else we need to know?: Environment: Kubernetes version (use ): v1.9, v1.10 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign /sig windows /sig azure
Added to v1.10 milestone since it is a critical bug fix. cc
Code change:
package flocker import ( <ins> "io/ioutil" "os" </ins> "testing" flockerClient "github.com/ClusterHQ/flocker-go"

Related discussion:
text: Unit tests on our CI have apparently been failing for 2 weeks and no one noticed (oops!)... The PR that seems to have caused the failures is . The failing test is - . Full Test Log: I'm not sure why this is failing on our CI and not on shippable. Has anyone else seen something similar? That test only seems to fail on the second run through with . Our unit tests run in a container built specifically for testing k8s-mesos: The Dockerfile for the env: Is anyone else able to repro with the above env or their own?
/cc
that test was around a week ago, it's doesn't seem possible to me that it was failing since 2 weeks ago. Anyway, we have few duplications of this issue: this one And the PR where is working on: It's a little bit difficult to me to follow all the conversations in all the differente places about the same bug, could it be possible to unificate some? Since you provided the environment I will try and take a look to reproduce it locally. Thanks!
I think I've got a working patch in
Closing in favor of &
Code change:
package flocker import ( <ins> "io/ioutil" "os" </ins> "testing" flockerClient "github.com/ClusterHQ/flocker-go"

Related discussion:
text: reports the following failure after syncing with latest code: --- FAIL: TestSetUpAtInternal (0.00s) Error Trace: Error: Not equal: "expected-to-be-set-properly" (expected) != "" (actual) FAIL FAIL 0.067s cc/
CC
Taking a look. What do you mean with failed sometimes? Is it a random failure?
Can you please provide more information. This test seems to be consistently green in our CI runs.
The test is failing on this assertion: but as you can see on the previous line I am checking that there was no error on that call. So the function is returning for the error checking but it's not setting . Only place where it can happen is here: Is the not been clean between runs?
When I said "the only place where it can happen" it was because the other s are being returned after a check. I think that there is no other way to get there.
PS: I run the test suite 100 times and I didn't get any error: (That branch is based on the branch)
can you test to see if the patch in fixes things for you?
See for reproducible test environment and failure logs.
Based on the solution in it sounds like this test creates files the first time through which causes the tests to fail on the second time through.
Code change:
return false } <ins> // return the size of the list func (q *graceTerminateRSList) len() int { q.lock.Lock() defer q.lock.Unlock() return len(q.list) } </ins> func (q *graceTerminateRSList) flushList(handler func(rsToDelete *listItem) (bool, error)) bool { q.lock.Lock() defer q.lock.Unlock()

Related discussion:
text: pull-kubernetes-unit ~1 day since merging of Test introduced in /sig network
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/cc
ahhhg let me fix it
oh, I will take a look.
Code change:
stopCh:           stopCh, clock:            clock, timer:            time.NewTimer(time.Duration(0)), <del> bookmarkWatchers: newTimeBucketWatchers(clock), </del> <ins> bookmarkWatchers: newTimeBucketWatchers(clock, defaultBookmarkFrequency), </ins> } // Ensure that timer is stopped.

Related discussion:
text: Currently, (best-effort) watch bookmarks are sent just right before the given watch is supposed to timeout: In we're adjusting how the size of watch cache is determined and make it dynamic and more duration-oriented (rather than based on some magic constants) - we're targeting to always keep 5 minutes of history in watch cache. With that change, we should get back to our bookmark policy: change it to (additionally to right before timeout) also send bookmarks every N seconds (setting N to slightly less than expected watch cache history period, so slightly less than X minutes we will use there) scale-test this change (to see if it doesn't introduce non-negligible overhead) if so permanently introduce this change /sig scalability api-machinery
/cc
/cc
/cc
I'm reverting as it broke bookmarks. I'm going to fix and re-submit for review hopefully later this week.
Code change:
set -o nounset set -o pipefail <del> KUBE_RELEASE_VERSION=${1-} VERSION_REGEX="^v(0|[1-9][0-9]*).(0|[1-9][0-9]*).(0|[1-9][0-9]*)$" [[ ${KUBE_RELEASE_VERSION} =~ $VERSION_REGEX ]] || { echo "!!! You must specify the version you are releasing in the form of '$VERSION_REGEX'" >&2 </del> <ins> if [ "$#" -ne 1 ]; then echo "Usage: ${0} <version>" </ins> exit 1 <del> } </del> <ins> fi KUBE_RELEASE_VERSION="${1-}" </ins> <del> KUBE_GCS_NO_CACHING=n KUBE_GCS_MAKE_PUBLIC=y KUBE_GCS_UPLOAD_RELEASE=y KUBE_GCS_RELEASE_BUCKET=kubernetes-release KUBE_GCS_RELEASE_PREFIX=release/${KUBE_RELEASE_VERSION} KUBE_GCS_LATEST_FILE="release/latest.txt" KUBE_GCS_LATEST_CONTENTS=${KUBE_RELEASE_VERSION} </del> <ins> KUBE_GCS_NO_CACHING='n' KUBE_GCS_MAKE_PUBLIC='y' KUBE_GCS_UPLOAD_RELEASE='y' KUBE_GCS_RELEASE_BUCKET='kubernetes-release' KUBE_GCS_RELEASE_PREFIX="release/${KUBE_RELEASE_VERSION}" KUBE_GCS_PUBLISH_VERSION="${KUBE_RELEASE_VERSION}" </ins> <del> KUBE_ROOT=$(dirname "${BASH_SOURCE}")/.. source "$KUBE_ROOT/build/common.sh" </del> <ins> KUBE_ROOT="$(dirname "${BASH_SOURCE}")/.." source "${KUBE_ROOT}/build/common.sh" </ins> <del> if ${KUBE_ROOT}/cluster/kubectl.sh version | grep Client | grep dirty; then </del> <ins> if "${KUBE_ROOT}/cluster/kubectl.sh" 'version' | grep 'Client' | grep 'dirty'; then </ins> echo "!!! Tag at invalid point, or something else is bad. Build is dirty. Don't push this build." >&2 exit 1 fi <ins> kube::release::parse_and_validate_release_version "${KUBE_RELEASE_VERSION}" </ins> kube::release::gcs::release <del> kube::release::gcs::publish_latest_official </del> <ins> kube::release::gcs::publish_official 'latest' </ins>

Related discussion:
text: (cc Despite doing very, very similar things, doesn't rely on . It should, or the logic should otherwise be consolidated. I'm going to maybe work on this to make easier.
Code change:
node *v1.Node // Path to the volume on the host node hostDir string <del> // Path to the volume in the local util container containerDir string </del> // PVC for this volume pvc *v1.PersistentVolumeClaim // PV for this volume

Related discussion:
text: 8 tests failed, 2 jobs failed, 88 builds failed. Failure stats cover 1 day time range '3 Aug 2017 03:31 UTC' to '4 Aug 2017 03:31 UTC'.
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig storage
This should have been fixed by /cc
The test panic is fixed, but now it's failing because it can't SSH into the node.
/assign