Code change:
<ins> /* Copyright 2023 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package service import ( "bytes" "context" "encoding/base64" "fmt" "math/rand" "net" "os" "path/filepath" "testing" "time" "google.golang.org/grpc" "google.golang.org/grpc/credentials/insecure" kmsapi "k8s.io/kms/apis/v2alpha1" ) const version = "v2alpha1" func TestGRPCService(t *testing.T) { t.Parallel() defaultTimeout := 30 * time.Second ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout) t.Cleanup(cancel) address := filepath.Join(os.TempDir(), "kmsv2.sock") plaintext := []byte("lorem ipsum dolor sit amet") r := rand.New(rand.NewSource(time.Now().Unix())) id, err := makeID(r.Read) if err != nil { t.Fatal(err) } kmsService := newBase64Service(id) server := NewGRPCService(address, defaultTimeout, kmsService) go func() { if err := server.ListenAndServe(); err != nil { panic(err) } }() t.Cleanup(server.Shutdown) client := newClient(t, address) t.Run("should be able to encrypt and decrypt through unix domain sockets", func(t *testing.T) { t.Parallel() encRes, err := client.Encrypt(ctx, &kmsapi.EncryptRequest{ Plaintext: plaintext, Uid:       id, }) if err != nil { t.Fatal(err) } if bytes.Equal(plaintext, encRes.Ciphertext) { t.Fatal("plaintext and ciphertext shouldn't be equal!") } decRes, err := client.Decrypt(ctx, &kmsapi.DecryptRequest{ Ciphertext:  encRes.Ciphertext, KeyId:       encRes.KeyId, Annotations: encRes.Annotations, Uid:         id, }) if err != nil { t.Fatal(err) } if !bytes.Equal(decRes.Plaintext, plaintext) { t.Errorf("want: %q, have: %q", plaintext, decRes.Plaintext) } }) t.Run("should return status data", func(t *testing.T) { t.Parallel() status, err := client.Status(ctx, &kmsapi.StatusRequest{}) if err != nil { t.Fatal(err) } if status.Healthz != "ok" { t.Errorf("want: %q, have: %q", "ok", status.Healthz) } if len(status.KeyId) == 0 { t.Errorf("want: len(keyID) > 0, have: %d", len(status.KeyId)) } if status.Version != version { t.Errorf("want %q, have: %q", version, status.Version) } }) } func newClient(t *testing.T, address string) kmsapi.KeyManagementServiceClient { t.Helper() cnn, err := grpc.Dial( address, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithDialer(func(addr string, t time.Duration) (net.Conn, error) { return net.Dial("unix", addr) }), ) if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = cnn.Close() }) return kmsapi.NewKeyManagementServiceClient(cnn) } type testService struct { decrypt func(ctx context.Context, uid string, req *DecryptRequest) ([]byte, error) encrypt func(ctx context.Context, uid string, data []byte) (*EncryptResponse, error) status  func(ctx context.Context) (*StatusResponse, error) } var _ Service = (*testService)(nil) func (s *testService) Decrypt(ctx context.Context, uid string, req *DecryptRequest) ([]byte, error) { return s.decrypt(ctx, uid, req) } func (s *testService) Encrypt(ctx context.Context, uid string, data []byte) (*EncryptResponse, error) { return s.encrypt(ctx, uid, data) } func (s *testService) Status(ctx context.Context) (*StatusResponse, error) { return s.status(ctx) } func makeID(rand func([]byte) (int, error)) (string, error) { b := make([]byte, 10) if _, err := rand(b); err != nil { return "", err } return base64.StdEncoding.EncodeToString(b), nil } func newBase64Service(keyID string) *testService { decrypt := func(_ context.Context, _ string, req *DecryptRequest) ([]byte, error) { if req.KeyID != keyID { return nil, fmt.Errorf("keyID mismatch. want: %q, have: %q", keyID, req.KeyID) } return base64.StdEncoding.DecodeString(string(req.Ciphertext)) } encrypt := func(_ context.Context, _ string, data []byte) (*EncryptResponse, error) { return &EncryptResponse{ Ciphertext: []byte(base64.StdEncoding.EncodeToString(data)), KeyID:      keyID, }, nil } status := func(_ context.Context) (*StatusResponse, error) { return &StatusResponse{ Version: version, Healthz: "ok", KeyID:   keyID, }, nil } return &testService{ decrypt: decrypt, encrypt: encrypt, status:  status, } } </ins>

Related discussion:
text: generation for local KEK based on counter; also rotate once a week even if the counter does not hit 2 million? using AES-GCM encryption of local KEK ref: The implementation would be to the directory.
/sig auth /triage accepted
/assign
GitHub didn't allow me to assign the following users: ibihim. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
thank you !
/milestone v1.26
Hi bug-triage shadow team member for 1.26 here. Looks like this issue is in the 1.26 milestone, but has been moved to 1.27. Is there something else or should this issue go to 1.27 as well? Thank you!
I just forgot to move this issue /milestone v1.27
/reopen is the partial implementation.
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
My suggestion on the reference implementation, after reading 's comments is like so... The GRPC server, which implements the expects an implementation that satisfies . The local key logic can be a middleware. So it expects a it can fallback to, if it doesn't know a key or needs to encrypt its own local KEK. So the local implementation would be need to: have a storage of s have a reference to the current in use (if we put it into the cache, it might vanish) have a reference to another , which should be the remote KMS. So the sub-stories could look like: write Middleware write Transformers that can get exhausted (by time, by usage) write 's storage write some dummy for remote KMS? I have some sketches of what I am talking about .