jiebi/CodeConvo huggingface dataset:
Code change:
related to In the new Responsive Design curriculum the words tag and element are used interchangebly The correct use should be element and tag (or at least, element is the whole thing, tag is the one that start with and end with and can be an opening tag, a closing tag or a self-closing tag). Should this be changed in the new curriculum?
Do we have many/any incorrect uses?
actually mostly not - there is some ambiguity with in the second step of the accessibility quiz I have been hasty
My concern was with these steps, which are about meta tags
That does look like something that should be standardised. Thank you, for listing them. I am opening this issue up for first timers only. The files that need changed are listed in the above reply. What needs changed There are a few uses of the word which should be changed to . Example Original: New: Note Not all uses of the word should be changed. Example: An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the
Hi - is it ok if i pick this up? First timer here

Related discussion:
text: # --description-- <del> Continuing with the `meta` tags, a `viewport` definition tells the browser how to render the page. Including one betters visual accessibility on mobile, and improves _SEO_ (search engine optimisation). </del> <ins> Continuing with the `meta` elements, a `viewport` definition tells the browser how to render the page. Including one betters visual accessibility on mobile, and improves _SEO_ (search engine optimisation). </ins> Add a `viewport` definition with a `content` attribute detailing the `width` and `initial-scale` of the page.
Code change:
related to In the new Responsive Design curriculum the words tag and element are used interchangebly The correct use should be element and tag (or at least, element is the whole thing, tag is the one that start with and end with and can be an opening tag, a closing tag or a self-closing tag). Should this be changed in the new curriculum?
Do we have many/any incorrect uses?
actually mostly not - there is some ambiguity with in the second step of the accessibility quiz I have been hasty
My concern was with these steps, which are about meta tags
That does look like something that should be standardised. Thank you, for listing them. I am opening this issue up for first timers only. The files that need changed are listed in the above reply. What needs changed There are a few uses of the word which should be changed to . Example Original: New: Note Not all uses of the word should be changed. Example: An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the
Hi - is it ok if i pick this up? First timer here

Related discussion:
text: # --description-- <del> Another important `meta` tag for accessibility and SEO is the `description` definition. The value of the `content` attribute is used by search engines to provide a description of your page. </del> <ins> Another important `meta` element for accessibility and SEO is the `description` definition. The value of the `content` attribute is used by search engines to provide a description of your page. </ins> <del> Add a `meta` tag with the `name` attribute set to `description`, and give it a useful `content` attribute. </del> <ins> Add a `meta` element with the `name` attribute set to `description`, and give it a useful `content` attribute. </ins> # --hints-- <del> You should add a new `meta` tag to the `head`. </del> <ins> You should add a new `meta` element to the `head`. </ins> ```js assert.equal(document.querySelectorAll('meta').length, 3);
Code change:
Steps to reproduce the behavior: on toggle button(code folding) on line 36 of the code editor (check screenshots) error no idea ! ! <!-- Please complete the following information. --- Device: Laptop OS: Windows 10 Browser: firefox Version: 98.0.1 (64-bit) <!-- Add any other context about the problem here. --
The UI is designed with the assumption that the editable region is visible and will be surrounded by the instructions and the Check Your Code button. With the editable region hidden the UI will look quite confusing. I think the best solution would simply be to disable folding for project steps. Folding is an editor option, , so we can disable it.
I'd be in favour of that solution. Should just be a matter of adding to this editor options object right?
I think so, yeah. We could make it conditional: false if there's an editable region and true otherwise. That might be nice if you're working on a project using the multifile editor, since they can be quite large and don't have editable regions.
I'll go ahead and open this one up for contribution then

Related discussion:
text: editorDidMount={editorDidMount} editorWillMount={editorWillMount} onChange={onChange} <del> options={options} </del> <ins> options={{ ...options, folding: !hasEditableRegion() }} </ins> theme={editorTheme} /> </span>
Code change:
The use of the term "Gender" as an objective feature variable type with a categorical code value type seems to be an outdated understanding of gender and can be potentially offensive or insulting to those who would identify with the LQBT+ community as there are potentially too many genders to possibly categorize I would suggest the use of the term "Sex" as opposed to "Gender" as this will not effect the overall behavior of the project while also ensuring a safe and inclusive environment for those who identify as genders other than man or woman

Related discussion:
text: extends ../layout block content <del> .jumbotron .col-sm-8.col-sm-offset-2 form(method='POST') </del> <ins> .col-sm-8.col-sm-offset-2.jumbotron form(method='POST', action="/forgot") </ins> h1 Forgot Password input(type='hidden', name='_csrf', value=_csrf) .form-group
Code change:
The use of the term "Gender" as an objective feature variable type with a categorical code value type seems to be an outdated understanding of gender and can be potentially offensive or insulting to those who would identify with the LQBT+ community as there are potentially too many genders to possibly categorize I would suggest the use of the term "Sex" as opposed to "Gender" as this will not effect the overall behavior of the project while also ensuring a safe and inclusive environment for those who identify as genders other than man or woman

Related discussion:
text: button.btn.btn-primary(type='submit') i.fa.fa-key | Reset Password
Code change:
found an issue: Unexpected shorthand &quot;padding&quot; after &quot;padding-bottom&quot; (declaration-block-no-shorthand-property-overrides) It's currently on:
I'm happy to fix this (and remove the units from zero values also in that file), but I'm not sure what the preferred replacement is for the padding. Should I just remove the padding: and add lines for padding-top: 0; padding-right: 15px; to reflect the styles currently specified by the padding: 0 15px 15px line?
I would delete , you can start and these question will be answer by reviewers if they need changes later

Related discussion:
text: .footer-container .col-header { flex: 0 0 100%; <del> padding-bottom: 15px; </del> font-weight: 700; font-size: 16px; text-align: center;
Code change:
found an issue: Unexpected shorthand &quot;padding&quot; after &quot;padding-bottom&quot; (declaration-block-no-shorthand-property-overrides) It's currently on:
I'm happy to fix this (and remove the units from zero values also in that file), but I'm not sure what the preferred replacement is for the padding. Should I just remove the padding: and add lines for padding-top: 0; padding-right: 15px; to reflect the styles currently specified by the padding: 0 15px 15px line?
I would delete , you can start and these question will be answer by reviewers if they need changes later

Related discussion:
text: display: flex; flex-direction: row; flex-wrap: wrap; <del> margin: 0px; </del> <ins> margin: 0; </ins> } .footer-col {
Code change:
found an issue: Unexpected shorthand &quot;padding&quot; after &quot;padding-bottom&quot; (declaration-block-no-shorthand-property-overrides) It's currently on:
I'm happy to fix this (and remove the units from zero values also in that file), but I'm not sure what the preferred replacement is for the padding. Should I just remove the padding: and add lines for padding-top: 0; padding-right: 15px; to reflect the styles currently specified by the padding: 0 15px 15px line?
I would delete , you can start and these question will be answer by reviewers if they need changes later

Related discussion:
text: } .footer-col a { <del> padding: 5px 0px; </del> <ins> padding: 5px 0; </ins> } .footer-desc-col {
Code change:
found an issue: Unexpected shorthand &quot;padding&quot; after &quot;padding-bottom&quot; (declaration-block-no-shorthand-property-overrides) It's currently on:
I'm happy to fix this (and remove the units from zero values also in that file), but I'm not sure what the preferred replacement is for the padding. Should I just remove the padding: and add lines for padding-top: 0; padding-right: 15px; to reflect the styles currently specified by the padding: 0 15px 15px line?
I would delete , you can start and these question will be answer by reviewers if they need changes later

Related discussion:
text: flex-direction: column; } .footer-right { <del> padding-left: 0px; </del> <ins> padding-left: 0; </ins> } .footer-container .col-spacer { margin-top: 40px;
Code change:
The following test (user story) prevents my previously passing project from passing: Important: Notice I use instead of just I never claimed to be a UI expert Do we want to keep such a test? No response Unrelated No response
Maybe you should update your project Honestly I think small tweaks are going to be okay - my tribute page fails because the image needs a height now.
I am also happy with small tweaks, but we did (largely) want to keep the requirements exactly the same. The only change we agreed upon is to add requirements for tags.
Looks like they accommodated for the tag in that test. Maybe we can just add it here too.
although, I think it's good, that we moved on from the old test. tag is extremely useful in html, it has attribute that help developers use less needed css, which lead to better experience, . it should be accepted to use Edit: if you paste this code in it won't pass although there is a media query but in the html Edit: I changed the for easier testing

Related discussion:
text: Your `#video` should have a `src` attribute ```js <del> const el = document.getElementById('video') assert(!!el && !!el.src) </del> <ins> let el = document.getElementById('video') const sourceNode = el.children; let sourceElement = null; if (sourceNode.length) { sourceElement = [...video.children].filter(el => el.localName === 'source')[0]; } if (sourceElement) { el = sourceElement; } assert(el.hasAttribute('src')); </ins> ``` You should have a `form` element with an `id` of `form`
Code change:
The following test (user story) prevents my previously passing project from passing: Important: Notice I use instead of just I never claimed to be a UI expert Do we want to keep such a test? No response Unrelated No response
Maybe you should update your project Honestly I think small tweaks are going to be okay - my tribute page fails because the image needs a height now.
I am also happy with small tweaks, but we did (largely) want to keep the requirements exactly the same. The only change we agreed upon is to add requirements for tags.
Looks like they accommodated for the tag in that test. Maybe we can just add it here too.
although, I think it's good, that we moved on from the old test. tag is extremely useful in html, it has attribute that help developers use less needed css, which lead to better experience, . it should be accepted to use Edit: if you paste this code in it won't pass although there is a media query but in the html Edit: I changed the for easier testing

Related discussion:
text: Your `#video` should have a `src` attribute. ```js <del> const el = document.getElementById('video') assert(!!el && !!el.src) </del> <ins> let el = document.getElementById('video') const sourceNode = el.children; let sourceElement = null; if (sourceNode.length) { sourceElement = [...video.children].filter(el => el.localName === 'source')[0]; } if (sourceElement) { el = sourceElement; } assert(el.hasAttribute('src')); </ins> ``` You should have a `form` element with an `id` of `form`.
Code change:
! I "of" It is missing orginally. there is no code, just lesson typo for the text to read "front of it" No response Device: Omen Desktop OS: Windows 10 Browser: Chrome Version: version of? Sry if the System section isnt very clear, its just a typo so i assume it doesnt matter all to much.
Thanks for opening this issue. It looks like this issue is something that "first-time" code contributors to this repository can fix. Here are the files that you should be looking at to work on: List of files:  Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We prioritize accepting the most quality contribution, followed by the earliest request. Happy contributing.
i it to my pull request it took me a while to find it lol
No clue what to do to help with files or fixing stuff tbh, I'm still pretty new to all this GitHub stuff. Someone might be much better for this than I. But hopefully ill have the experience in the future to help with things like this, big or small.
I see that it's a perfect start for beginners like me, however using repo or GitHub is not easy that much :D. For this issue, finding correct challenge on my local files and fixing it is an achievement for me. I am excited for more. :)
Contributing to open-source is a rewarding experience. You get to learn so much, things like coding practices, collaboration skills, and most critically, working with folks you have never met (or most likely never will) in person. We encourage you to participate, not just in this community but in many different open-source projects out there. You got this! If you need help, we are here to help you help us. All you need to do is get started. As I mentioned earlier, if you are interested, head over to the contributing docs and jump right in. Cheers & happy coding.

Related discussion:
text: # --description-- <del> So far you have been using type selectors to style elements. A <dfn>class selector</dfn> is defined by a name with a dot directly in front it, like this: </del> <ins> So far you have been using type selectors to style elements. A <dfn>class selector</dfn> is defined by a name with a dot directly in front of it, like this: </ins> ```css .class-name {
Code change:
I think that the instructions for the media query are a little difficult for (relative) beginners to understand. Up until now, as far as I can see, they've only been asked to create media queries for CSS rules that they're already somewhat familiar with (, etc.). So, to me, it just feels a little too ambitious at this stage to expect them to have fully grasped the terminology involved (media-rule, values etc.) and to be able to construct the appropriate media query. It doesn't help that the MDN docs page has no examples using either or which also makes it a little more difficult for students to search for help via Google. I feel as though some kind of example would be very useful here, although I do appreciate that it's difficult to provide an example without effectively giving the solution away. Perhaps something like "reminder - the format of a media-query is (media-rule: value)" could be ? (at least to the hint if not to the instructions). Alternatively, perhaps add a link to this which does have an appropriate example. No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] Recent forum posts:
I do agree an example would work, but it isn't the optimal way. It's against freeCodeCamp policy to add an external link, there is an issue with the content of the external link changing. We can change previous media challenge to include this , until media reduce article is written.
Agreed, users are always free to search if they want to, but we should try to make our lessons self-contained if possible. I just tried doing the lesson myself and found it frustrating to keep getting the hint when I had wrapped the rule correctly, but the rule was wrong. should trigger a different hint. That sounds good to me, though I'd word it slightly differently to be more consistent with the rest of the hints: cc:

Related discussion:
text: # --hints-- <del> You should have a `@media (prefers-reduced-motion: no-preference)` rule. </del> <ins> You should have one `@media (prefers-reduced-motion: no-preference)` rule. </ins> ```js <del> assert.exists(new __helpers.CSSHelp(document).getRuleListsWithinMedia('(prefers-reduced-motion: no-preference)')); </del> <ins> assert.equal(new __helpers.CSSHelp(document).getRuleListsWithinMedia('(prefers-reduced-motion: no-preference)').length, 1); </ins> ``` You should wrap the existing `*` rule within the `@media` rule.
Code change:
In step 1 of building a cafe menu, the attribute test is strict with space Here is the markdown file The code above should pass, for this to happen you should change to ! Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
Can I work on this issue ?
Yes، feel free to open a pull request

Related discussion:
text: You should have an opening `<html>` tag with a `lang` attribute of `en`. ```js <del> assert(code.match(/<htmls+lang=('|")en1s*>/i)); </del> <ins> assert(code.match(/<htmls+langs*=s*('|")en1s*>/gi)); </ins> ``` You should have a closing `<html>` tag. Remember that closing tags have a `/` following the opening `<` bracket.
Code change:
The challenge text mentions Ryan but there is no Ryan. We should only mention parts of the example that exist, ideally. No response All No response
wow. Ryan was exist? that is interesting.
Thanks for opening this issue. This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.

Related discussion:
text: } ``` <del> This would log `Alan`, `Jeff`, `Sarah`, and `Ryan` - each value on its own line. </del> <ins> This would log `Alan`, `Jeff`, and `Sarah` - each value on its own line. </ins> In this statement, we defined a variable `user`, and as you can see, this variable was reset during each iteration to each of the object's keys as the statement looped through the object, resulting in each user's name being printed to the console.
Code change:
There are three tests that test for non-empty labels: "Your #name-label should not be empty." "Your #email-label should not be empty." "Your #number-label should not be empty." I think the word "empty" is slightly ambiguous here. These tests appear to be looking for actual text inside the label. But if the user nests an inside the label without text then the isn't exactly empty: The above will fail because there is no actual text in the but I can see how the user would not think the is empty. N/A Adjust the test descriptions so they clarify that text needs to be inside the . Perhaps something like: "Your #name-label should contain text that describes the input". No response N/A No response
Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.

Related discussion:
text: assert(!!el && el.tagName === 'LABEL') ``` <del> Your `#name-label` should not be empty </del> <ins> Your `#name-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('name-label') assert(!!el && el.innerText.length > 0) ``` <del> Your `#email-label` should not be empty </del> <ins> Your `#email-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('email-label') assert(!!el && el.innerText.length > 0) ``` <del> Your `#number-label` should not be empty </del> <ins> Your `#number-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('number-label')
Code change:
There are three tests that test for non-empty labels: "Your #name-label should not be empty." "Your #email-label should not be empty." "Your #number-label should not be empty." I think the word "empty" is slightly ambiguous here. These tests appear to be looking for actual text inside the label. But if the user nests an inside the label without text then the isn't exactly empty: The above will fail because there is no actual text in the but I can see how the user would not think the is empty. N/A Adjust the test descriptions so they clarify that text needs to be inside the . Perhaps something like: "Your #name-label should contain text that describes the input". No response N/A No response
Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.

Related discussion:
text: assert(!!el && el.tagName === 'LABEL') ``` <del> Your `#name-label` should not be empty. </del> <ins> Your `#name-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('name-label') assert(!!el && el.innerText.length > 0) ``` <del> Your `#email-label` should not be empty. </del> <ins> Your `#email-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('email-label') assert(!!el && el.innerText.length > 0) ``` <del> Your `#number-label` should not be empty. </del> <ins> Your `#number-label` should contain text that describes the input. </ins> ```js const el = document.getElementById('number-label')
Code change:
challenge-editor should be to the "How to work on practice projects" documentation here:
I'll tackle this today.

Related discussion:
text: npm run create-next-step ``` <del> ## create-empty-steps </del> <ins> ### create-empty-steps </ins> A one-off script that automatically adds a specified number of steps. The challenge seed code for all steps created will be empty. **Note:** This script also runs [update-step-titles](#update-step-titles). <del> ### How to run script: </del> <ins> #### How to run script: </ins> 1. Change to the directory of the project. 2. Run the following npm command: