jiebi/CodeConvo huggingface dataset:
Code change:
Moving on to the final `fieldset`. What if you wanted to allow a user to upload a profile picture? <del> Well, the `input` type `file` allows just that. Add a `label` with the text `Upload a profile picture: `, and add an `input` accepting a file upload. </del> <ins> Well, the `input` type `file` allows just that. Add a `label` with the text `Upload a profile picture: `, and nest an `input` accepting a file upload. </ins> # --hints--

Related discussion:
text: In step 31 of the Learn HTML Forms by Building a Registration Form project, the step doesn't explicitly say that it wants the input element to be nested inside the label element. Instead it says: "Add a label with the text Upload a profile picture: , and add an input accepting a file upload." This could be interpreted to mean that the input element should be on the right side of the label element. Only when we attempt this are we told by the Hint "You should nest an input element inside the label element." To clarify the requirement, the step should use the word nest in the exercise as below for eg.: "Add a label with the text Upload a profile picture: , and nest an input accepting a file upload within it.", The step should explicitly state that the input element should be nested within the new label element. No response Not Applicable No response
I think if all of the challenges will have specifications defined explicitly, it will serve no purpose of "challenging" the learners to really think and solve it. In the first place, the solution is already implied from the given code and then, if the learners will still have the hard time solving it, then the feature will definitely do its job.
Agreed. The instructions should be clear to begin with. Making the users guess what the test requires isn't a "challenge", it's just rude.
For what it is worth, the camper has nested an input in a label element a few times in this challenge prior to this step. I am not against adding this reminder to the instructions, but I don't want to lose sight of our goal to keep the instructions more lean and have the hints serve as the reminders.
Definitely. But I looked back at the instructions on the steps where they add the previous inputs and we do explicitly tell them to put the input within the label: step 17: Nest an input element within each label. step 25: within each of the first two label elements, add one input element with type="radio". If we can add that information to those instructions then I think we can add it to this one. And let me just clarify that what I am really concerned about is this correct solution being rejected: I'm working under the assumption that correct code should always pass. So we need to tell the user that only a nested input will pass if that's all the test will accept.
Code change:
Moving on to the final `fieldset`. What if you wanted to allow a user to upload a profile picture? <del> Well, the `input` type `file` allows just that. Add a `label` with the text `Upload a profile picture: `, and add an `input` accepting a file upload. </del> <ins> Well, the `input` type `file` allows just that. Add a `label` with the text `Upload a profile picture: `, and nest an `input` accepting a file upload. </ins> # --hints--

Related discussion:
text: I understand that if someone is working on a series of steps they may not need to be told to nest the input again. However, if they stop and return to the project a few weeks later on, they may not remember that. The hint will remind them sure. I guess this is a minor issue given the hint is quite clear. Personally I like a more explicit instruction.
Code change:
className="spacer" style={ { <del> "height": "1px", </del> "padding": "15px 0", } }

Related discussion:
text: We have instances which is used to provide spacing for both side of the component to wrap it up in specific space Example: We can make the Spacer component smarter, and allow it to accept children, so the code be like. But in doing so, we need to: change the current values and how the padding is calculated, the old layout shouldn't change with the new spacers. change which padding has the new value, I think paddingBlock, which is paddingTop and paddingBottom, is the new padding property . I am requesting this because this will make live simpler, and we have to worry about less elements while controling the layout, and if we have specific cases, we can still use
There is an abstraction with , we need address, it's better if we can specify the direction of the padding. but this can be sorted in another issue, for now to solve this issue please allow to have children prop inside of it, but the current styles of the curriculum shouldn't change. If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our prolific contributors will guide you through this.
Hey I have few questions while looking into this issue are few files where we have used Spacer, so may I just change wrap the content where ever needed or it would be handled in new issue? (I guess it must be done in other issue, as it would be easy to maintain) have implemented the children props, so may I raise a PR? Will break this issue in 2 other issues as well. 1 for wrapping the places it has been used, and 2nd for specifying the direction. I was wrapping and trying it out, I found out that Spacer has been used at every 2nd-3rd line of code, so do we need such a wrapper which would give spacing to all components present inside it or only to the parent component? EG: If we have 2 divs wrapped inside Spacer, then does both div have the spacing around them or only the outmost div.
Code change:
className="spacer" style={ { <del> "height": "1px", </del> "padding": "15px 0", } }

Related discussion:
text: sorry for the delay, it was difficult to understand what you mean without looking at an example of code, so to answer you: yes the direction will be in a second issue, but the spacing and values should still be in this issue, so the pages won't look different Of course, please raise a PR after reading the guideline, nicely done . The Spacer shouldn't affect the children inside of it, think of it as creating a container with margin-block to space the area of the children inside of it from other areas
I guess we could close this issue
will be closed when the height is removed in the other PR
Code change:
expect(redirectUrl.pathname).toBe('/authorize'); }); }); <ins> describe('GET /mobile-login', () => { let superGet: ReturnType<typeof createSuperRequest>; beforeAll(() => { superGet = createSuperRequest({ method: 'GET' }); }); beforeEach(async () => { await fastifyTestInstance.prisma.userRateLimit.deleteMany({}); await fastifyTestInstance.prisma.user.deleteMany({ where: { email: newUserEmail } }); }); it('should be rate-limited', async () => { await Promise.all( [...Array(10).keys()].map(() => superGet('/mobile-login')) ); const res = await superGet('/mobile-login'); expect(res.status).toBe(429); }); it('should return 401 if the authorization header is invalid', async () => { mockedFetch.mockResolvedValueOnce(mockAuth0NotOk()); const res = await superGet('/mobile-login').set( 'Authorization', 'Bearer invalid-token' ); expect(res.body).toStrictEqual({ type: 'danger', message: 'We could not log you in, please try again in a moment.' }); expect(res.status).toBe(401); }); it('should return 400 if the email is not valid', async () => { mockedFetch.mockResolvedValueOnce(mockAuth0InvalidEmail()); const res = await superGet('/mobile-login').set( 'Authorization', 'Bearer valid-token' ); expect(res.body).toStrictEqual({ type: 'danger', message: 'The email is incorrectly formatted' }); expect(res.status).toBe(400); }); it('should set the jwt_access_token cookie if the authorization header is valid', async () => { mockedFetch.mockResolvedValueOnce(mockAuth0ValidEmail()); const res = await superGet('/mobile-login').set( 'Authorization', 'Bearer valid-token' ); expect(res.status).toBe(200); expect(res.get('Set-Cookie')).toEqual( expect.arrayContaining([expect.stringMatching(/jwt_access_token=/)]) ); }); it('should create a user if they do not exist', async () => { mockedFetch.mockResolvedValueOnce(mockAuth0ValidEmail()); const existingUserCount = await fastifyTestInstance.prisma.user.count(); const res = await superGet('/mobile-login').set( 'Authorization', 'Bearer valid-token' ); const newUserCount = await fastifyTestInstance.prisma.user.count(); expect(existingUserCount).toBe(0); expect(newUserCount).toBe(1); expect(res.status).toBe(200); }); it('should redirect to returnTo if already logged in', async () => { mockedFetch.mockResolvedValueOnce(mockAuth0ValidEmail()); const firstRes = await superGet('/mobile-login').set( 'Authorization', 'Bearer valid-token' ); expect(firstRes.status).toBe(200); const res = await superRequest('/mobile-login', { method: 'GET', // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment setCookies: firstRes.get('Set-Cookie') }) .set('Authorization', 'Bearer does-not-matter') .set('Referer', 'https://www.freecodecamp.org/back-home'); expect(res.status).toBe(302); expect(res.headers.location).toBe( 'https://www.freecodecamp.org/back-home' ); }); }); </ins> });

Related discussion:
text: This endpoint needs to use jwtaccesstoken in the same way that web login does.
Code change:
# --description-- <del> **Objective:** Build an app that is functionally similar to this: <a href="https://codepen.io/freeCodeCamp/full/EZKqza" target="_blank" rel="noopener noreferrer nofollow">https://codepen.io/freeCodeCamp/full/EZKqza</a>. </del> <ins> **Objective:** Build an app that is functionally similar to this: <a href="https://choropleth-map.freecodecamp.rocks" target="_blank" rel="noopener noreferrer nofollow">https://choropleth-map.freecodecamp.rocks</a>. </ins> Fulfill the below user stories and get all of the tests to pass. Use whichever libraries or APIs you need. Give it your own personal style.

Related discussion:
text: All the data viz projects were created on our .rocks domain. We just need to replace the codepen URL's with the new addresses in the curriculum files of those five projects. Here's the URL's: https://bar- https://scatterplot- https://heat- https://choropleth- https://treemap- And the
Hey Just to make sure you want this replaced with https://bar- ?
I want to contribute to this project. Please assign me this task.
thank you for your interested in contributing, but this issue is not open for contributions, please look at issues with labels or
Code change:
assert(document.querySelectorAll('table')?.[1]?.querySelector('tbody')?.querySelectorAll('tr')?.[3]?.querySelector('th')); ``` <ins> Your text `Total Liabilities` should not include period `.`. ```js assert(document.querySelectorAll('table')?.[1]?.querySelector('tbody')?.querySelectorAll('tr')?.[3]?.querySelector('th')?.innerText !== 'Total Liabilities.'); ``` </ins> Your `th` element should have the text `Total Liabilities`. ```js

Related discussion:
text: The instructions state "In your fourth tr element, add a th element with the text Total Liabilities." However it is not really clear that the user should or should not include a period. Users will have failed previous tasks if the period was omitted (periods are required on previous exercises) , therefore they will most likely add the period which will result in a failed test case. Also, if the period is included after "Liabilities", the error message gives "Your th element should have the text Total Liabilities." Which does not highlight the actual issue. Maybe making a different test case message that looks for the period would make it more understandable? The code above should highlight the issue of the period being present. The test case that is currently in place can confuse users that they have a spelling issue/spacing instead of the actual issue being the period at the end of "Liabilities". No response Device: Desktop OS: Windows 10 Browser: Chrome Version: Version 108.0.5359.125 No response
I was thinking, that we could change to But this doesn't make a coherent sentence. I am in favor of adding a new test.
I also think a new test case would be good.
Hi! We just opened a to fix it, but it was not accepted . Could you please kindly inform us some feedback about what was going wrong and what else we need to do? So that we can know where to focus. We appreciate any help, thank you!!
Hi Thanks for reaching out and creating a pull request. For reasons of sanity, we can't accept PRs from forks that organizations maintain. You should make a PR from your own personal GitHub account. You can collaborate with others and have commits made by multiple people, but one person needs to create the PR, and then others may push to the same PR should they wish. It is OK if you want to use the draft mode while collaborating. The person making the PR is responsible for ensuring the checklist is followed, tests are working, and so on. You can also commit on someone's behalf. See: Also, please create good, small, and succinct commit messages and PR titles. Keep your commits clean and avoid any merge commits unless you have conflicts to resolve. The final PR should not have dirty commits from collaborating on an organization fork like the previous PR.
Code change:
assert(document.querySelectorAll('table')?.[1]?.querySelector('tbody')?.querySelectorAll('tr')?.[3]?.querySelector('th')); ``` <ins> Your text `Total Liabilities` should not include period `.`. ```js assert(document.querySelectorAll('table')?.[1]?.querySelector('tbody')?.querySelectorAll('tr')?.[3]?.querySelector('th')?.innerText !== 'Total Liabilities.'); ``` </ins> Your `th` element should have the text `Total Liabilities`. ```js

Related discussion:
text: The reason is the maintainers of this project will need to validate your changes and the source of the commits. Keeping it clean makes everyone's lives easy. Thanks and happy coding!
Hi Mrugesh! Thank you for your precious feedback! I've switched back to my personal GitHub account, and made a pull request . This time the commits are clean and the messages are concise. Thank you for taking time reviewing! I appreciate any feedback. :D
Code change:
"cert-map-estimates": { "certs": "Certification (300u00A0hours)", "coding-prep": "(Thousands of hours of challenges)" <ins> }, "editor-tabs": { "info": "Info", "code": "Code", "tests": "Tests", "preview": "Preview" </ins> } }, "donate": {

Related discussion:
text: Describe the bug When you enter a challenge using a mobile device, the tabs below the main header are displayed with untranslated text To Reproduce Steps to reproduce the behavior (mobile device): to untranslated tabs below the main header Expected behavior Tabs text should be translated. Screenshots Spanish site ! Chinese site ! Desktop (please complete the following information): OS: [Windows 10] Browser: [chrome] Version: [88] Additional context Those strings are not available yet on the Crowdin platform.