jiebi/CodeConvo huggingface dataset:
Faulty method of the class can expose itself only during function tests. Case when number of balls to draw is higher than number of balls in hat is not tested explicitly, but it can fail function test, as it includes such experiment. - - Depending on the number of balls to draw and number of balls in Hat: Remove the required number of balls randomly selected, from the Hat. If number of balls to draw is higher than the number of balls, return all the balls. Test for the method checks only the first case: The second behavior is not checked explicitly, but it's a part of the second sub-case in the function test. This creates situation where passing method test and failing function test, can suggest to camper that issue lies in the function. Example with faulty method: Error: Adding test to check second behavior of the method would make debugging easier for campers, as it would show more clearly where is the issue. No response n/a No response
I have created this issue so we can come to a final conclusion about the best format of notes when they are to the or sections of a challenge file. Below are all the combinations I have seen scattered throughout the curriculum. There may be others, so please let me know and I will update the list. This only applies if there is a single note. For multiple notes (which in my opinion starts to get unnecessary), see later in this topic. Example 1: Example 2: Example 3: Example 4: Example 5: Example 6: Example 7: Regarding situations where two or more separate notes are , I have seen: Example 1: Example 2: Example 3: If everyone can cast a vote for their preference of both a single note and multiple notes, this will help us in deciding on one way and then we can update the Styling Guide for challenges in the documentation.
I will cast my vote as I prefer Example 7 for single notes, because it takes up less space and adds one additional space between the word and the content. I like Example 3 for multiple notes, because I like the to be bold.
I'll vote for number 6 for the single notes and number 3 for multiple notes. I don't really see the need for extra space between and whatever comes after it, a simple space is fine
Also to add on, perhaps we can have a background-color for all Note sections as we want users to pay attention to those sections particularly. Something like this: ! Color code used: #C9F8CF
This is the style guide contain freeCodeCamp's Brand colors: https://design-style- . We try to deviate as least as possible from this and I'm yet to see a major deviation
Also, the note is not the most important thing in the challenge. The actual instruction is. We don't want to highlight anything that is not relative to the instruction. Most of the time, these notes are FYIs.
I vote for example 6 and example 3, The says to use something in none of the examples for single notes, the output would be the same as example 2, I think - Also, the guide doesn't say anything about multi-notes
6 and 3.
I vote for example 6 in single notes and example 3 in multiple notes.
I think it is settled then.
6 and 3. What do you think?
Agreed, with you all. Thanks. Please proceed with pull requests.
I would like to work on this. Is there a way to assign my name under the assignee? I am not able to do so
Hi Go ahead with PR. We cannot assign you the issue. It's unfortunately a limitation from GitHub. Feel free to make a PR. We usually allow the first open and valid PR to go in as a fix. Thanks.
The suggestion in the PR above says to make a multi-note different from the example - so I did some testing to see the outputs and thought I should share.<brthese codes.... <img width="570" alt="screen shot 2019-03-05 at 10 26 56 am" src="https://user-"produce the following...<br<img width="415" alt="screen shot 2019-03-05 at 10 27 51 am" src="https://user-"The first two here produce the same result (same as example 3 above)... I'm not sure I like that extra space in there - I suppose it's fine, but I made a few others to see if I could make it look more like how I think it should look. So basically, I'm saying, I'm having second thoughts on how we should do the multi-notes.
I found more cases for single note. Perhaps you can update the list Case 1: Case 2: Case 3: Case 4:
Are you going ahead with a PR to put it somewhere into the docs?
Are you converting them to the suggested style And have you come across many multi-notes?
In challenges like , we have this sentence: Note that property names with spaces in them must be in quotes (single or double). So, should that sentence also be converted to: or can we ignore such cases?
yes i am following the example 6 for single note (as voted) Have not come across multiple notes yet. Will re-check.
Good points. Maybe multiple notes should just be different sentences in the same style as for a single note. Which ends up looking like: <strongNote(s):</strongFirst note goes here. Second note which is a bit longer goes here. Third note which is the longest note of all goes here.
That's a judgement call I think it could be converted. I would hold off on the mult-notes for a little bit - and if you're going to make a PR, it's probably best to try and keep it to maybe one section or so at a time, or maybe a few sections if there's only a couple files changed.
I have a doubt: in , Is the note section considered multi-note or single note? The note section has more than one sentence. Does it qualify as multi-note then?
That one looks like you could probably just put the two sentences together in a single note. Since they are so related. And we aren't sure yet what we want a multi-note to look like.
I agree if they are related a single paragraph note will be fine. However, if it gets to long it may be more difficult for the user to parse the information, and should then be broken up into individual lines. Any Notes section with more than one sentence should still be described as Notes My opinion on the multi-line notes - we should use markdown bullets. It may put a bit of space between items, but they are much simpler to manage when making changes to the markdown. They automatically insert line breaks after each item and don't require verbose HTML wrapping the text. Visually it also looks like a bulleted list. Spacing between bullets can be modified in CSS if needed. It's also easy to replace the bullet with numbers if the order of the note matters. Note vs Notes should be explicit, Note(s) is only useful if you expect someone to add a second Note and they will forget to update Note to Notes, something we should quickly catch in review with the requirement of multiple reviewers. After some conversation with I agree that it really doesn't make sense to have too many notes in a document - we should work to insert the notes into the curriculum, or provide a place for additional information that may not be directly related to the exercise but provide valuable insights/information/resources.
I believe the corresponding Guide article for the challenge is the place where extra information is supposed to go, to avoid cluttering up the challenge itself.
that may be the case but the way it's conveyed is not great IMO. The only link to the guide article is Get a Hint, something many won't click, especially if it's a fairly simple exercise.
I also don't see the guide article at all when I search for the exercise title, something we should look into, unless that is by design.
I see guide links when searching for a lesson title (none of the links work right now) - perhaps you searched for a lesson where the guide article is still a stub, and they don't show up or something.
The search indexes have not been updated in over 12 months, so that could be part of this problem.
I just remember that Quincy prefers not to have links going to other places when a user is on the challenge. He believes the challenge should stand on its own or rely on previously introduced material as much as possible. We want people to stay on the challenge until they just can not, which is where the Get a Hint or Ask for Help buttons come into play.
So the single note structure was to the guide with the PR above. The multinote issue wasn't exactly concluded - do we want to continue the conversation? I'm thinking we can close this, and mods should just keep notes small when we can. And multinotes can just be combined into a single paragraph after a
I don't know how many multi-notes there actually are, but I say we just combine them like you suggest in the same paragraph. I can create a PR to reflect this. Then, as we come across the multi-notes, we can first figure out if there even needs to be a multi-note and then probably just make it a single paragraph. How does that sound?
A PR to describe this in the guide? Sure
In [()] step it is written but in the html file there is no selector instead there is selector present. ( In [()] step it is written but in the html file there is no selector instead there is selector present. either change the to or remove the totally from the step to do. No response
Page File: the seed content doesn't have , and the step after it do include it as well. we should swap with This looks something that can be fixed by "first time" code contributors to this repository. Here is the file that you should be looking at to work on a fix: file: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
I would like to work on this issue. Please assign this issue to me .
We don't give assignment unless to an old time contributor to the repo. Edit: sorry should have provided more info. There were times when people assigned an issue and didn't commit to it, because of that the guide mentions we don't assign people and seek quality and fast commits. Sorry if my original answer was uninformative. I hope you have a good day and happy coding.
Description and question refers to the Here's the main office area. And over there, let me show you, that's the conference room. text. However the audio mentions let me show you in context of showing to the desk. n/a Audio used in task should match the description context. Or the other way around. No response n/a No response
Yes, this is a problem. None of the answers are correct. Here's how I'd fix it: change the option "the conference room" to "the desk". This should solve the problem. We could also: simplify the question to "What is Maria directing attention to?" simplify the example to "Here's the main office area. Let me show you to the conference room."
I am fine with the suggestion. You could use as the example. What do you think
Agreed I'm going to add the help wanted label.
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: The challenge wants the user to do a ("Hello World"); which sounds simple enough but it doesn't specify that it has to be in the but it eventually does with the error "hello world is not in the " or a similar error but when you go to the you see this: /* PLEASE DO NOT EDIT THIS FILE the verification process may break / It's jarring for someone who doesn't know about this language or system yet. I suggest changing "file" into "file section" or "section of the file" just to prevent confusion. As one material (the challenge page) is telling me to edit the file while the other material (the glitch material) is telling me NOT to edit the file. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Browser Version: Operating System: If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):**
I agree, we can clarify the instructions to something like: To get started, just print the classic "Hello World" in the console. You need to modify the file. The file shouldnt be modified at all. There is in which you can add and the latter challenges code.
Can I take this issue?
If I remember correctly, that's what I did first. I did the on the and it gave me the error of "log isn't in the server"(paraphrased). Just to clarify that that's what happened. If you mean that the challenge should instead change so that it's the that should be manipulated, then I think that's better.
Sure! I'm still very new and inexperienced so I leave it to your more capable hands! 8D
I have started course and in my Glitch app there is no file, also putting console log in is also not working
You need to use the boilerplate project mentioned in the introduction challenge.
Okay just to make it clear... First I cloned the Github boilerplate-express-gomix template... I'm not a big fan of Glitch... So if I have a project on Github at similar URL then logically file would be located at Now my question is pretty simple... JUST WHICH EXACT URL should I use in this case... this is a bit confusing... I managed to pass the whole previous Managing Packages with Npm section, still I had a bit of of hard time finding the proper URL to point to I found the main way to make it work in my case was to select the file, then click on Raw button. That would give me a similar URL which I later passed in the URL. Any hint on how to make the boilerplate project URL work with Github Thank you...
I think this should be to the Hint: "Use the new Glitch link for this episode" See this forum posts:
<!-- freeCodeCamp Issue Template --<!-- Please provide as much detail as possible for us to fix your issue --<!-- Remove any heading sections you did not fill out --<!-- NOTE: If your issue is CodePen Project / Test Suite related, please open it using the below URL instead --<!-- --<!-- Insert link to challenge below -- <!-- Describe below when the issue happens and how to reproduce it --Correct solution doesn't pass. Behavior of "Preview" page matches challenge description but these tests don't pass: When a number of less than 18 is entered into the input element and the button is clicked, the button's inner text should read You Shall Not Pass. }; When a number greater than or equal to 18 is entered into the input element and the button is clicked, the button's inner text should read You May Enter. }; Once a number has been submitted, and the value of the input is once again changed, the button should return to reading Submit. }; <!-- Describe your workspace in which you are having issues--Browser Name, Version: Chrome, Version 64.0.3282.140 (Official Build) (64-bit) Operating System: Windows 10 Mobile, Desktop, or Tablet: Desktop <!-- If relevant, paste all of your challenge code in here --<!-- Add a screenshot of your issue --<img width="422" alt="react-use-a-ternary-expression-for-conditional-rendering" src="https://user-"
The bug seems to come from the first boolean, . An alternative to checking a string's emptiness——works fine. I'm guessing that at some point during the tests, is not actually a string. For instance, if at some point becomes a (which does not have the attribute) then we're in trouble.
Found the bug: as predicted, there was a and mix-up. In the tests, the values sent into the input element are numbers, making undefined and failing the tests. These tests should not be sending numbers into input elements. As written in the MDN web docs for , the attribute of the Input Element in HTML is always of type String. Yet, the in the challenge has , so shouldn't the user still account for this? The MDN web docs say otherwise: Notice that the type attribute only alters the "type of control to display".
When type is set to "number", only numbers are allowed to be entered, yet the value is still stored as a . Therefore, the value attribute of the input element still returns a data type.
I've opened a pull request to fix these tests. Luckily, this "input-number-value problem" only afflicted this particular challenge.
thanks for explaining and for fixing :+1:
anytime :smiley:
Hi guys, thanks for taking the time to report and fix, we will get this reviewed soon. Happy contributing!
Hi, why this solution is not working. It's working fine if I enter a value greater than 18 but fails when I enter a value lesser than 18.
it won't work for values lesser than 18 as it this is an invalid expression (buttonThree && buttonOne) Instead, try the below solution : { ( == '' ? buttonOne: ( < 18 ? buttonThree : buttonTwo) }
There appears to be a slight typo in the English instructions on Step 41 of "Learn Typography by Building a Nutrition Label". The instructions are displayed on the file and read as: The typo is with the text: . The and <p class="bold right"% Daily Value </p% Daily Value ` as part of the exercise. The following code is what the challenge starts with - where the instructions are displayed The expected instructions would read with instead of : This would match the actual text value for the paragraph element the instructions are referencing. ! ! Device: PC OS: Windows 10 Browser: Chrome Version: Version 115.0.5790.110 (Official Build) (64-bit) I would like to point out that I have only seen this issue with English and I am not sure if other languages are also impacted.
Thanks for opening this issue. This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
We recently a lot of updates to this project. So the step numbers in the main branch don't match up with what is currently on production. Here is the correct file you need to look at We had this issue reported on the forum If you try to use the wrong variable name like this then the hint text tells you this: it looks like the third test here will need to be updated You should declare a variable named . see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Potentially, upgrading to MongoDB 4 has broken the GitPod Development. I am looking into it, but here are the errors: Shortened Error (me trying to restart Mongodb, after an initial crash): <details<summarymongod --version</summary</details<details<summaryFull Error</summary</details<details<summaryPotentially relevant client error</summary</details
To the best of my knowledge no code changes were made to upgrade MongoDB on GitPod. The base image using MongoDB 4 needs to be looked at. In other words, the move to MongoDB 4.0.x (not same as 4.x) breaking GitPod is coincidental?
To be honest, I have no idea. The base image: Source: Docs: From what I can see, the docker hub provides no information about the image, but the GitHub repo suggests the image has not been updated in 4 months. To me, this suggests an issue definitely on our side.
That is pretty easy to confirm. On GitPod you should be able to checkout a commit (any commit) that was best known to working from a few days ago. A diff should bring you closer to the root cause, say for example a dependency update somewhere. But to prevent beating around the bush, I think we instead provide our own base image with requirements set in the local setup file. Let me know if you need help with this & thanks for looking into it.
Update: There is a high likelyhood I have been looking into the wrong section for where the problem is. Here is the original error which lead me to look into the database stuff: <details<summaryClient Error</summary</detailsSteps to reproduce: 1) Open any instance off fCC GitPod 2) Wait for client to finish developing 3) Open browser preview of app 4) See client crash with above error I tried killing the database, restarting it, and restarting the client, but the app crashes, everytime the browser tries to load.
I can't reproduce this, sorry! If I go to it just works. I know we've talked about this before, but do you have any special settings for GitPod besides Enable feature preview? Environment variables are the only thing I can see that might cause an issue.
Other than the Feature Preview, everything is bog-standard. I will try to disable FP.
Disabled Feature Preview Rebased fork against upstream <details<summaryNew Client Error (similar, but different)</summary</details
If you have a lot of work in progress branches, I would suggest pushing them up to your fork and starting with a clean workspace, then on you should delete everything that is old/stale. As a best-practice I would start with a new workspace (provided the work is saved elsewhere like pushing up to th remote fork) and getting rid of older workspaces.
Fork? That could be relevant. Could you drop the Gitpod link that you're using here.
I might be using the wrong word... all I meant is: Here is the link I sometimes use - depends on whether I am testing with changes or not:
All of my testing (outside of the open PR branch) has been with a new workspace. I regularly clean the workspaces. Positive this is not part of the issue on my end.
Quick question: Are you using the preview browser within the GitPod environment? What happens if you ignore the crash on the preview browser and just use the "open in a new tab" button: ! If you reload there, is it the same behavior?
I never use the preview browser - always the new tab view (full). Had not thought to try it there, but, if I am relegated to using the preview, I still would not use it...
Hmm, I was able to reproduce with a link from your fork in your previous comment. But the link from this main repo works A-OK. Is it the same case for you? Or is it broken no matter what you do? I know you rely on GitPod quite a bit, we are totally cool with you pushing branches directly up to the main repository as an exception considering the massive amounts of work you put into contributions. If there is anything we can do to unblock you we would be happy to assist. Sorry about not being able to troubleshoot. :(
I've one idea left to try, that's updating my own fork and seeing if I can repro. I'll have a go tomorrow.
This is the same for me. A workspace from appears to work as expected. So, it is just my fork (unless proved otherwise by Oliver)... I will report this to the GitPod GitHub. Thank you, both, for your time in this.