jiebi/CodeConvo huggingface dataset:
Even though on macOS it would seem that Ctrl+Enter does not work & Cmd+Enter does; website still tells you to use Ctrl+Enter. I think this might end up being confusing for some - and should be fairly straightforward of a change. All coding pages You must use macOS for this issue. to any coding challenge your changes will see button underneath says "Check your code (Ctrl + Enter)" Ctrl + Enter will happen. Cmd + Enter behaviour will occur. It should tell the user correct shortcut (Cmd + Enter) instead of (Ctrl + Enter) depending on the platform. <img width="647" alt="Screenshot 2022-06-09 at 16 52 28" src="https://user-"- Device: M1 MacBook Pro OS: macOS 12.0.1 Browser: Safari Version: 15.1 No response
I would like to handle this issue as a first contribution. My proposal would be to use (). Use Ctrl + Enter as a fallback and define a special case for macOS cases. Alternatively we could use () however that is not widely supported as opposed to . As far as I can tell on mobile we don't show modifier keys on the button; so I'll preserve that behaviour. I can't change the labels on this issue - I don't think this is severe enough to be classified as a bug based on definition; my apologies regarding that.
Hey thanks for raising this issue and don't worry about the labels, they need to be handled by maintainers. What you've suggested does sound good to me, so if you're happy to take this on, that's awesome.
I've created the PR however; I've updated non English translations as well in here to use dynamic values; however not really sure how to align it with the crowdin. Since updated translations should coincide with this change; any opinions on this?
Do not worry, I think you are putting too much effort into it. Simply drop the changes to those files and as the bot mentioned, they will get updated eventually via our translation workflow. As for the bug itself: I am 100% sure at some point we introduced a regression, because (in addition to the implicit Cmd + Enter) was working since the inception of the code editor. do you happen to know if this was just an accident with the new editor?
To be clear it should always work with regardless of the OS in addition to implicitly working with just like it was before.
I can't check this myself, since I don't have a mac, but it should work. This is the code: and could you try and reproduce the issue?
I've shot a short video of the behaviour I am seeing; if that helps.
That does help, yeah. It seems to be ignoring the command button entirely, which is odd. I can't investigate myself, but this will help anyone that has access to a Mac.
Thanks for the video I don't recall if ctrl+enter ever worked on mac - I may or may not have ever used it. I just hit buttons without looking I'm not sure if you are trying to show something specific with those code snippets - that's the code on main. Which results in the current behavior. Edit: I get it now - you were just showing the code and that it should be working. I thought you trying to show new changes or something. Here's the current behavior I see (all on mac) - there's some nuance... New RWD: Execute: only command+enter works on mac Submit: Enter alone works, so any key+enter works Legacy RWD, JS, etc: Execute: Only cmd+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work Multiple choice Python video questions: Execute: Enter alone does not work - ctrl+enter and cmd+enter work Submit: Enter alone does not work - both ctrl+enter or command+enter do work Projects with URL inputs - e.g. front end libs cert project, or backend api challenges, etc: Execute: Enter alone works cause it's a form I suppose, which also means any key+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work The last three groups there have the same submit modal, so the behavior is the same on all of them. What I see is that the submit modal, and the video question both allow [ctrl or cmd] +enter - we should see what those are doing. Looking into to it...
K, I think I found a fix. ctrl+enter works when the hotkeys package/component is used. So crtl+enter actually does work on the legacy challenges when the instructions are focused.
When the editor is focused, those hotkeys don't get used, the actions/hotkeys we add to the editor take over. I made ctrl+enter work when the editor is focused by changing that line 431 mentioned to this: That should work. There's a number of actions in that file that use the same hotkeys - lines 457 and 469 for example. There may be others. I think we should be safe to change all those. Do you mind playing with that a bit and updating the PR to make those changes.
Nice work, Tom. I thought CtrlCmd was "Ctrl or Command", but it must be Ctrl on Windows and Command on Mac :man_facepalming: I guess this has never worked properly.
happy to give it a look and update the PR. Thank you
Here's an I had created sometime back when working on the . Apparently the logic goes like this - the first word is Windows and the second one is Mac button.
Describe the bug 1) It appears a was accidentally left in the script. 2) A request to my/(a user's) page-data is returning a 404. To Reproduce Steps to reproduce the behavior: to DevTools log or in console, due to: File: Line 126 error in console as in picture below. Expected behavior No Errors, no logs. Screenshots ! Desktop (please complete the following information): OS: Windows 10 Browser: Chrome Version: 83.0.4103.97 Additional Info I believe the: 'progress updates processed where possible' Is useful, and should stay.
I think it would be better to remove all the logs, since we can use the flash messages if we need to communicate information. Ideally, all errors should go to Sentry. This currently does happen for the server, but we haven't implemented it for the client, yet. Basically because there's still a bit too much noise (like the page- 404 in your screenshot).
Yep, git blame and me for missing it in the QA. Reference: A PR is welcome to remove this and any other rogue logs. This is an expected side-effect of us using Gatsby's routing to query and get the user profile available at . Essentially, when you hit , we first let Gatsby check in the static files if something is available at that path, if not we query the API to lookup there for a username. If both conditions fail, we would render an actual 404 page. But for this to work the status code 404 is sort of abused. Its hacky but there is no way around this to the best of my knowledge. Just to clarify, this should be left as is.
any suggestions where to search? I am trying to search around, but there doesn't seem to be, or I am finding those in the challenges code maybe there aren't
It's a bit tricky, because we use console logs as part of the challenge code, but the place to look is in could you explain why 'progress updates processed where possible' should appear in the console?
there are a few, but they all seems needed where they are
I don't know why, but it comes from file line 98
there are some s, s s, too. gets me: of which probably should not be there.
I'd like to get input before we remove them, though. I think should eventually make it to Sentry and possibly should too.
could you explain why 'progress updates processed where possible' should appear in the console? , Sorry - my language was too strong. I meant to say: For no other reason than it is a debugging message. Re-thinking about it, I think it could be more useful being changed to , as that is how I interpret the message. After all, it is a component.
There's nothing to apologise for. So, my position is just that debugging messages are things that should be shown to developers, rather than users (if possible). Essentially because that information is intended to help find and fix bugs, which isn't something a user should be expected to do. In this case 'progress updates processed where possible' mostly just indicates that you've navigated to a challenge, so I don't think it's useful. seems worth showing, but only because we don't have access to this information with a remote error logger (Sentry in our case).
<!-- NOTE: If you want to become an author on freeCodeCamp, you can find everything here: --<!-- If you are reporting an issue with an article on our News publication, please follow this link to send an email to our editorial team --<!-- Add a link to the page with the problem. --<!-- Describe the problem and how to reproduce it. --<!-- A clear and concise description of how you want to update it. --<!-- If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box). --!
Hi ! Thank you for finding this typo. I have the first timers only label since this is an easy fix. For those interested in fixing this issue, here is the file you need to change. Proposed fix: The border-radius property accepts up to four values to round the top-left, top-right, bottom-right, and bottom-left corners. Please also read through our . When the file is fixed, please make a PR referencing this issue and it will be reviewed. Happy contributing!
I'm going to start looking into this.
Thank you for fixing the issue. It was the first time for me on Github. I'm a total newbie in the webdev coding bootcamp.
There is a difference in the font size and the margin between the text , on the home page () and the learn page (). Although you may not notice it on first glance but it disturbs the UI. The "sign in and get started" button on home page is also wider than the "sign in to save your progress button" on /learn page.
Hi Could you add some screenshots that demonstrate the problem you're describing?
Here are two screenshots from the landing and the /learn tab, before you're logged in. ! ! There is a difference with the button width being stretched to fit the container in the landing page, but not on the /learn page. There is a minor difference in the margin right below the 'Welcome' Header between the two pages.
I was talking about the change in margin between "Welcome to " and "Learn to code." on the lading page and the /learn page , and the width of the yellow Button on the two pages , as you can see in the screenshots shared by
Thanks for clarifying, and I'll open this up for PRs.
Implemented some changes. Please see screenshots <img width="1280" alt="Screenshot 2020-01-19 at 09 59 13" src="https://user-"<img width="1280" alt="Screenshot 2020-01-19 at 09 59 31" src="https://user-"
We got some feedback here about the spreadsheet project step 31 They mentioned that if you try to use an OR operator here then the hint does not tell you what's wrong. I think the easiest fix would be to just update the directions and hint text to explicitly mention the use of the AND operator. This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the Happy coding see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
Hey Jessica, may I open a PR to fix this issue? Thank you!
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
I suggest changing the phrase 'template interpolation' to 'template literals,' because are correctly referred to as template literals, which support string interpolation. ! Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response_
it should be "string interpolation". Template literals are already mentioned a few words before, it would be extremely redundant. I'm opening this issue for first timers to make the change "template interpolation" -"string interpolation". This change needs to be done twice in this file: Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Sorry for the misunderstanding. I need to change the text from 'template interpolation' -'string interpolation'
Hi, I guess has raised his PR with the needed change. I haven't contributed before to any open source project. I thought this was an easy one to do to get started. Please tell any easy code or non-code contributions to be made. Happy to help.
I am able to make the required change and happy to start open source contribution with hacktoberfest . Kindly assign this issue to me.
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labeled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.
This pull request resolves the issue of incorrect terminology in the JavaScript curriculum where "template interpolation" was used. The correct term is "string interpolation," as template literals support string interpolation. I have made the following changes: Replaced "template interpolation" with "string interpolation" in the two locations within the file. Fix :
After reading the contributing guidelines, I now understand the mistake I made in my PR.
This sentence seems to be confusing campers on the forum Let's go with this updated description here see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the Happy coding
Hi, I have created this PR as a first time contributor (no PRs merged yet) to this codebase. Hope the changes are up to expected requirements. Thanks!
There is a typo in Step 156, the word is used to refer to the operator. Here is the typo it should be Can you change the lowercase that refers to the operator in the file, to uppercase , as well? to follow the docs of Mozilla If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
Hello, I would like to work on this issue.
hello,can i resolve the issue?
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --From this forum topic: Affected page File: Your code Expected behavior As this challenge is about lazy matching this code should fail Maybe a way is to make sure that the character appear in the right place, there is a test that check if the character is used, so maybe we would need to have a test that check if or are used this in the screenshot checks only for , maybe we can add also the possibility to use as that is also lazy matching ! and just as we are there, removing the flag from the regex as it is not needed, see maybe also this can be fixed so that nor nor are included in the regex
Describe the bug The PayPal sdk gets called by the local site, even when there are no keys specified in .env To Reproduce Steps to reproduce the behavior: to any page with a donation component the console a 400 error Expected behavior If the keys are missing, PayPal should not be contacted. Screenshots !
/cc
Hello guys! Does this happen on page or somewhere else too? Can't recreate it anymore, happend only once. I'd like to help with that issue if you don't mind Also, I noticed PaypalButton has a typo -in props, example:
it should happen if you hard refresh on donation page. (and on donation modal) That script loads the button. A solution would be to check for paypalClientId in the render of PaypalButton component and return PayPalButtonScriptLoader only if paypalClientId is truthy.
PR is ready. Could you please take a look? Also about the Stripe issue. I'm not sure if it's expected/known but if I don't configure the key for stripe, the page isn't loading for me at all. <img width="1054" alt="CleanShot 2020-05-11 at 02 59 29 src="https://user-"
Yikes, that seems like it needs a fix as well. Thanks for catching that.
Challenge has an issue. User Agent is: <codeMozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36</code. Please describe how to reproduce this issue, and include links to screenshots if possible. My code: Usually, paragraphs are separated with an empty line but here it is not. Currently, both paragraphs are in one string with a separating the two paragraphs. For this challenge in the file, the second paragraph should be on its own string so the spacing is consistent with all the other challenges. !
Same goes for this challenge as well:
Humm, don't know why I did that. Yes, these need a proper line break.
Is this how you fork? This is my first time.
I would consult the . It's got a lot of helpful information. The things I can see that need to be changed are: the branch name (it needs to be in the form of so like would be good) and also the issue number should not be in the commit title. It should be in the commit body and say something like . Here's more information about .
to your profile settings page the privacy setting to the top and click The privacy setting you changed will not have taken effect. From there, you can go back to the settings using the settings button, and the privacy setting will still show it as it was before you changed it. I believe this is due to using to navigate to the portfolio. The setting will have actually changed in the DB, but the effects won't show until you do a hard reload.
I can fix this if it's decided to change it.
As far as I can see, the problem is that the user is only pulled from the server once. The server is getting updated correctly, but the redux store isn't being asked to mirror these changes.
as there seems to be an issue with a redux reducer.
I was speaking to earlier and he says:
Is someone looking into this ( Otherwise I can take a crack at it tomorrow.
Go for it - let me know if you want to team up on it.
I don't think this challenge is described correctly. The idea that a variable is only available to the element and it's children has nothing to do with cascading. It's a clear definition of scope. Cascading is the concept that if there are multiple of a thing, the last one wins, which is described in the previous challenge related to fallbacks. Just my 2cents for what it's worth, but if I had someone come in for an interview and tell me cascading was the idea that a variable could only be used by an element and it's children, I would consider that a wildly misunderstood concept.
Thanks for reporting this! While this challenge isn't intended to introduce the concepts of cascade and inheritance, it clearly does not use the terms correctly. I'll have a go at rewriting the challenge to show that CSS variables behave like ordinary properties in this respect.
for what it's worth, this was discussed a little bit in a previous issue that was never resolved - - perhaps it should be reworded since it has now come up multiple times.
Describe the bug Using the search-Field and clicking "See all results ..." To Reproduce Steps to reproduce the behavior: to '' on 'Search Field' and enter s.th. I did "Flutter" and then I clicked "See all results for Flutter" error: "404 Page not found" I think the error is easy to fix: The automatic created result link after clicking has double "news"-part: if I manually remove one "news" as the result would be the correct one.
Thanks for the report! It seems it's a problem with redirection. redirects to and the link is to which redirects to cc:
Thank you for reporting this This was also a problem on /news. I deployed a quick fix and am working on PRs now. I noticed that we could change the URLs in the search related files from to This seems to get around the problematic redirect, at least for search results. Still an issue we need to investigate further for other use cases.
search is still broken? I can't get anything to load for generic searches.
what sort of generic searches are not loading for you? Things seem to be working on my end whether I search from .org/ or .news/.
working on my side on news and learn from multiple locations for the initial test case.
!
Should it say something like "No results for for 'this is a generic search', please try a different query"?
Thanks for the gif, I see what you mean now. The behavior should be a message that says "No tutorials found" and not to allow the search to complete. There's a PR for this on News , and I'll start working on the implementation in the main repo.
I am going close this since the above prs address the issue. Feel free to reopen if you think this issue has been closed by mistake.
Has the fix landed on production. I am able to reproduce the issue?
has not landed yet on learn. but you could see the fix on /news
The query string is passed on to the news application. URL is available on the GIF that I sent.
we deployed the updated theme to News, so you shouldn't be able to enter a long string there and hit the search results page. Once the fix to Learn is deployed you won't be able to pass long strings with no hits to News like in the GIF.
Quick follow up, is there anything that is preventing us from deploying?
sorry for the delay in deploying. We just got access to the client VM to clear out the old builds. We'll do that later today and get all these changes out.
Great, thanks for confirming. Apologies I have the keys to the VMs a couple days ago. I missed letting you know. I have also cleared the older builds. You should be able to simply run a build. Thanks.
No worries man. Thank you for adding our keys. We should have checked to see if we had access yet. We're just about to go in now and run a build.
This fix has been deployed. The problem in the gif above should no longer be possible on or
There are two links in docs. Following are the two links how to work on coding challenges. up freeCodeCamp locally I am also adding screenshot to show more clearly that which links are broken. ! so when we click on these links in README in docs it shows page not found
Nice catch! I will correct this.
i have linked pr for this issue kindly merge it thanks
We will have to figure out a better way to handle links. We are currently using to host our documentation at This means we have to handle links in a way that they work on that page. I think a quick way to work around this would be to rename to which we render on the contribute page. Then we create a in which just has a notice similar to the Thoughts?