jiebi/CodeConvo huggingface dataset:
Maybe the good ol' if statements are fine here:
Let's see what says after my last reply, before we assign it to you.
Yeah, even I think it is better to make it in the form of as many people still get confused with nested ternaries.
I would take a different perspective here. For the purposes of the tutorial, I suggest that nested ternaries are the way to go. If people do get confused, this will encourage them to look up their doubt and they will be better versed with ternaries for later. I have opened a PR with the edit implementing nested ternaries.
On second thought, and the fact we already have a nested ternary lesson in basic JS section. I think it's fine to use a nested ternary. Good point as well.
Make sure to reference that it closes this issue # if you have not already done so.
just remember to ask first before you create a PR as there might be other people waiting to do one, like had asked here before if he could work on it? sorry about not getting to do a PR for this issue, there are other issues you might take a look at.
I will take care of this in future PRs. Apologies for my mistake .
Comment on issue
What are these PRs you have referenced?
could be spam.
The sample code on the FCC website is still the old version. I noticed on the challenge's GitHub page the sample code is different than what I saw on the live FCC website. I did this challenge on December 19, 2018. The sample code on the FCC website website is the old version (different from the GitHub version). I thought that the GitHub version of the challenge was reflected on the FCC site. Does this happen at regular intervals, or do updated challenges need to be pushed live to the site? As a side note, the sample code on the GitHub page and the live FCC site doesn't work in Chrome 70+ for reasons addressed above. May I update the sample code to a version that works? In this case, the description would also need updating to explain the code. Should I make the changes as a pull request? Sorry, I'm really new to FCC and Open Source contributing in general. I just want to make sure I do things in the most efficient way.
I propose the following (the opposite of the reverse alphabetical sort suggested above): The old version that doesn't work in Chrome 70+: Here's the screenshot: ! Here is the link to the GitHub page:
Not sure if I misunderstood you, by "sample code" do you mean the guide? is a PR for the guide, although it seems to be missing the fix for reverseAlpha ascendingOrder version of sort where the compare function is using subtraction is only (to be) used with numbers, not strings. Which is not explained, nor is the function name very explicit about that fact. On a side note: Personally, I would like to see the use of parentheses as I feel it makes the nested ternary more legible. Maybe also a version using (maybe just in the guide) I would also like to see a link to the MDN docs (and maybe a short explanation of how the method and callback works).
RE: Sort an Array Alphabetically using the sort Method Challenge... Maybe not the cleanest but simply running this code: worked in my case :)
Hi I was not referring to the guide, but instead to the live/production and the GitHub version. (Now that you mentioned it, I checked out the PR you linked and noticed that even in the guide, the first example for an ascending sort does not work in Chrome 70+. I'll comment on that PR as well.) Here are screenshots and tables below summarizing the issue. In short, the sample code on the FCC site for ascending sort is an example of how to sort numbers. It works for numbers but does not work when applied to letters/strings in Chrome 70+. The sample code for the reverse alphabetical sort also doesn't work in Chrome 70+ but does in FireFox. I think it would be best to have sample code that applies to the challenge, and works across major browsers. ! ! PASS PASS PASS PASS Note: there is a typo in the second sample code block of the GitHub version screenshot. The PR you linked addresses that as well. Hope this info helps. Please let me know if anything is unclear.
Hi I like the brackets in the nested ternary. This may be minor, but I think a different arrangement of the nested ternary would be even more intuitive and brackets wouldn't really be necessary. I my suggestions as comments to the code blocks below.
They match the code on the MDN page, which states that the ternary operator is right-associative (details below). What do you think? MDN: Conditional (ternary) operator 
The TLDR; The only bug is, Chrome used to accept boolean return values like Firefox still does. After Chrome changed their sort it no longer does. This is not a bug in Chrome, but incorrect usage of the compare function in the assignment text, this has now been fixed (site is not updated yet). The comparefn is supposed to return numeric values: 0 (a must be equal to b) 1 (a is greater than b by the ordering criterion) -1 (a is less than b by some ordering criterion) If the comparefn does not return numeric values it is not consistent and the sort order is implementation-defined (which is spec compliant). ascendingOrder (return a - b) version is not meant to work with strings, in any browser. It is an example of using a compare function for sorting an array of numbers using subtraction. You seem to be mixing the number (ascendingOrder) and string versions (alphabeticalOrder/reverseAlpha), not sure why. Your screenshot and table are confusing and as far as I can tell must be wrong. The screenshot shows Chrome failing to sort an array of numbers, using ascendingOrder, which is incorrect. Then your table shows Firefox passing on an array of strings, using ascendingOrder, which it does not. For both browsers, using ascendingOrder on an array of numbers sorts the array correctly. Using ascendingOrder in Chrome on an array of strings leaves the array unchanged. Using ascendingOrder in Firefox on an array of strings reverses the array but does not sort it. Just to be clear, ascendingOrder is meant to sort the array, not reverse it. It just happens to be shown in the example text on an array of numbers that is in reverse order and so sorting the array effectively reverses it. can't put the alphabeticalOrder version in the assignment text, that is the solution to the assignment. That is why I asked. deeply nested ternaries your last style example is pretty common, however, for what we have in the assignment I think a single line expression is better. My format suggestion is based on how prettier formats the code.
Last I'm not sure if this conversation on a closed issue is considered proper etiquette or not, I simply don't have enough experience.
The above analysis is spot on. Thank you for the great explanation and its fine to have a discussion in a closed issue as long as its on topic. Otherwise you can always create new issue.
function alphabeticalOrder(arr) { return ((a, b) =a !== b ? (a < b ? -1 : 1) : 0); }
Point 7. of instruction says: There is missing underscore near eye in the result text. The correct solution for this test is text: eye is a palindrome (with underscore) Instruction text at Point 7. changed to: ! Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
The result looks correct to me because the instructions have this note in the beginning If we remove all special characters from then we would be left with
Look at the instructions for tests 16 and 17. The string includes all of the non-alphanumeric characters. But for test 7 the underscore is left out of the string.
I see it now. I misread that as returning the string without non-alphanumeric characters. In addition to updating the test description the hint text will also need to be updated This is has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the User story 7 will need to be updated and the hint text here will need to be updated
All numbers for descriptions should be in backticks. Here is the updated description Here is the file you will need to change Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing. see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
id like to pick up this, can you assign it to me pls
We do not assign issues to anyone other than long-time contributors and core team members. This issue is free to pick up for anyone interested in working on it. If you would like to contribute and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the
The formula given for converting from C to F is given as a) But this can also be written as b) These two formulas are producing different results. Using for (which is used in the tests) we get: a) b) If formula is used then the tests for this challenge will fail due to the floating point rounding issue. The tests should pass regardless of where C is placed in the formula. Either we need to do a little rounding in the tests or replace with a different number in the tests that won't produce different results depending on the placement of C in the formula. No response Device: Desktop OS: Linux/Fedora 36 Browser: Firefox Version: 112 No response
I followed Step 4 instructions. As I finished typing out the element, by habit I press + , and noticed that it accepted it, even though it shouldn't have as I was still missing the element It should have failed, as it's still missing the that Step 4 asked for ! Device: PC OS: Window 11 Version 23H2 Browser: Firefox 127.0.2 (64-bit) No response
This seem to also happen in other parts of the same course, such as Step 7 ! As you can see, it is missing its closing tag As well as Step 11 ! It's missing its closing tag yet the Step still validate it
Can you please open a new issue for the form element. I'm guessing the browser is auto closing it, and we don't have a regex test for it. It should result in a valid form element, because the browser will close it. However, the element technically does not have any "Tag omission" so it should have an end tag in the HTML (even if it gets to the DOM by the browser).
Done
Currently the map looks like this: ! I think it would look a lot better if we made more use of the available space. Something like this: !
I can fix the css in a separate PR, if you like. Unless you're already handling it, of course.
I think it is handled now in the PR already. I moved things into the Grid system
That PR still has the heavy indentation: !
You are correct, if you have something going please go ahead and push to the PR. I am done with the basic consolidation of the views that I was going for.
The declaration of arr doesn’t need to be guarded by ‘Do Not Change’ comments. There exist many solutions (3 in the guide) that do not need that variable declaration. These comments should be removed or at least moved. All No response
. I lean towards the second option of having only the comments within the function and no extra starter code.
I was thinking something simplier We've ditched a lot of these comments in the rest of the intermediate algorithm challenges. Does the comment help us at all here?
Probably not. I honestly would not even put the . At this point in the curriculum, users should know the function needs to have a statement and they can craft their own.
Sure, then the fix would be: This looks like a good first-timer issue.
Thanks for opening this issue. This looks like something that can be fixed by "first-time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
The instructions are really confusing and could be rephrased. ! I don't think what is referred to as a conditional is a what people are going to think of as a conditional. It is just a Boolean expression that is being asked for. No action or assignment is being given depending on truthiness of the expression. It seems like it is looking for an if, switch, ternary or bare conditional, and I believe only ternary or a bare conditional can be placed inside of an array (Not being nested inside of IIFE) which is knowledge a novice probably won't have. The difference, although small, is that a condition takes an action based on the result of a Boolean expression. No conditional action is being taken, so it is just an expression. Might ask for the first element in the array to be a Boolean expression of the sum of the player's position, height and velocity greater than or equal to the platform's position. There are various steps that follow that refer to Boolean expressions as conditionals. The concern is people learning incorrect terminology and getting mixed up in the field.
Yes, you are correct we should update the terminology for steps 78-81 to say boolean expression instead of conditional statement. I have opened this up for contribution.
For each of the steps, make sure to make the change mentioned above in all of the descriptions. Also, go through and check all of the hint text to make sure the correct terminology is used as well
It is bigger than a few steps. I did not track all the steps but kept seeing it through to the end of the course. It happens everywhere that we later do conditional action based on the Booleans stored in arrays. For each array we made, (I think there were 3? player, platform and checkpoints), the instructions use the same wording.
Looks like we have a PR to address the few steps I mentioned earlier. We can review that and merge it in which will close this particular issue. But then I can audit the project to find the other steps and create a second PR to remove the rest
Did a search and replace for the english files and found five more files total where the change needed to be applied. Here is the PR to resolve that.
Describe your problem and how to reproduce it: Data with test cases is in wrong place in challenge template. This makes it inaccessible when tests are run and makes challenge virtually unsolvable, unless test data is manually copied to the user code. Tests in this challenge uses three arrays, containing two inputs for the function and function outcome - arrays , , . They are called this way: Those variables are currently at the end of sample solution in challenge template. Simple moving them to more appropriate place - or section in the section - as shown in the , would deal with the issue. Add a Link to the page with the problem:
All the data viz projects were created on our .rocks domain. We just need to replace the codepen URL's with the new addresses in the curriculum files of those five projects. Here's the URL's: https://bar- https://scatterplot- https://heat- https://choropleth- https://treemap- And the
Hey Just to make sure you want this replaced with https://bar- ?
I want to contribute to this project. Please assign me this task.
thank you for your interested in contributing, but this issue is not open for contributions, please look at issues with labels or
I would suggest removing the second paragraph for step 66 (as a quite novice coder I guess the wording caught me up and I thought the challenge would lean on the side of more difficult rather than easy). I re-read it quite a few times but didn't realize that it was just explaining a later step. It took me a bit of time until I realized that only the first paragraph was needed to solve the solution. I just have an issue with the wording. Nothing else. Sorry if I did something wrong. This is my first time submitting an issue request No response Device: Desktop OS: Windows Browser: Chrome Version: 10 Just had issues with the wording and was recommending it being changed. Sorry if I did something wrong. This is my first github issue request
It looks like the original intent was to describe what the function was going to be about. I think removing it all together would leave the step in a place where campers are just asked to create a new function with no clue as to why or what it does. It would be better to provide some explanation on what they will be doing in the next few steps. A rewording would be better. Something like could work I'll open it up for discussion by the other maintainers to hear thoughts on wording. You didn't do anything wrong. It is a good issue
I am going to go ahead and open this up for contribution
I got a mini heart attack as I randomly tested the Storybook page of the component and found that the component failed a11y checks. <img width="1680" alt="Screenshot 2024-03-06 at 00 49 32" src=""This is because: We pass as an empty string to the component in the Storybook demo: We use the operator in the computation of the button's label, which would only fall back to if is either or : Note that this issue is only in Storybook and not in /learn as we do pass a to there: In , replace the operator with the operator In , make an empty object instead of containing empty and
I do not care much about the implementation, BUT, surely if a label of is never valid, then it is best to make the optional, and not pass one to the component? That is, I can imagine passing to a component because I do not want one, but was forced to pass one because it is not optional.
For this particular component, I agree that can be optional or can even be removed as a configuration option, since I don't think we need any customization here (the button's label should just be "Close" rather than something else). In fact, is already an optional prop of . However, has a limitation, which is that the library is not localized, so we still want to pass strings from /learn in order to have them translated. Semi-related, there was a discussion a while back regarding whether or not we should expose for consumption outside of . We decided to export the component because: The component in doesn't have a close button, but its version in /learn (which is called ) has one, so was built. (I wasn't around during the development of most of the components so I don't have the full context of the technical design) The limitation mentioned above.
Uploads: Everyday Downloads: Twice a week This should suffice our deployment targets which are usually Tuesdays? and Thursdays (optional) at around UTC+3 We can shake it up so that PRs can be merged on Mondays and Wednesdays?
So downloads should be triggered on Mondays and Wednesdays?
Yes, or a day before, for all we care. As long as they are: a week only on Mondays and Wednesdays for deployments on Tuesdays and Thursdays
There's typo in two hints. Instead of element it mentions . - - This is something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
I was making a PR for a different issue and saw this, so I the fix to the PR.
According to Google Analytics, the is way too hard, and is taking campers an average of 6 minutes and 35 seconds to finish (if they finish - a lot of them seem to give up). According to this table, campers spend more time on it than they do on the algorithm challenges. ! We need to either reword this or simplify the challenge so it can be completed in closer to 3 minutes. Otherwise, we should move it back to the algorithm section.
This challenge does have a large amount of constant strings which could cause users to take a longer time than a typical challenge. Maybe we could provide an array of the responses in the seed code. Make the seed code: This could help in two ways. The first is the users can save time by not having to type out each response. The second is this approach could minimize errors from typos in the response phrases (i.e. Hole-in-one! vs. Hole in one!). We could remove the number of different responses. Maybe remove Eagle and Double Bogey.
yes - that is a great suggestion. I think leaving all the names is fine but we should pre-populate the array with the names. Since this was your suggestion, would you be interested in tackling this and submitting a PR?
Yes, I would like to tackle this and submit a PR.
The Golf Code challenge did take me longer that the other challenges. I did not initially realize that golfScore() had BOTH strokes and par as parameters. With the other IF ELSE challenges we were only dealing with one argument to pass into the IF ELSE condition. I found myself in that "flow" and completely overlooked that two parameters were available to work with in the IF ELSE condition. I also found myself looking at the Strokes/Par table thinking, "How will IF( <= par-2) work?" After a little head scratching, I realized the values under the Strokes column were what you were supposed to compare Strokes to (i.e. IF (strokes <= par-2)). Hopefully, this feedback is helpful. I think the confusion is coming from the wording of the challenge and suddenly going from using one passed in parameter to two in your IF ELSE condition.
Awesome. has a PR open already. Could you take a look at that first and let me know what you think of his proposed changes?
I agree with MiloATH's proposed changes. Would definitely reduce the potential for typos when working the problem. As a side note, feel free to let me know if I am breaking any GitHub etiquette at any point. Zero experience providing input on collaborative projects. Looking for to learning and have really enjoyed FreeCodeCamp thus far. You guys and gals are doing awesome work. :)
Sure - we will let you know in a polite way if you break GitHub etiquette. Thanks for being receptive to feedback :)
<img width="1074" alt="Profile_freeCodeCamp_org" src="https://user-"
can I take this issue?
Thank you and for your interest. This issue might need a little more investigation before arriving at the final solution. I encourage you to find similar issues to tackle in the meantime. should I only audit the copy to replace profile with portfolio or you would rather changing the profile instances in the client and the api-server entirely?
I would like to get it assigned..
this should come as a cosmetic change to the copy only, do not change any endpoints or code (functions, objects, files) etc. It can be done to both API and the client where copy edit is needed.
This wasn't always the case, but right now the formatting for smaller screens isn't great: ! Smaller screens used to have tabs letting you switch between the instructions, editor and so on. You can see them briefly (in the gif) at medium screen sizes, but not for mobile. If we still want to support this, I can look into restoring it.
Looks like they're just hidden behind the search bar.
Thanks for reporting this, we are still figuring out the final state for the nav. Once that is settled, this issue will be resolved automatically.
This wasn't entirely resolved by , as the challenge tabs are still displaying incorrectly: !