Repository: pytorch/text

Issue:
todo-decorator-remove-solved
Removed the code as the issue is closed.


Discussion:
@arnavmehta7 thanks for creating this! Can you please fix the [linter issues](https://app.circleci.com/pipelines/github/pytorch/text/6752/workflows/6d68e250-d994-490d-bc96-f5fd360f4a81/jobs/233009) that show up on CI before we merge the PR? 
@Nayef211  Thanks, I've tried to do that but I'm still unable to do so. I'm quite new to opensource. I'd be grateful if you can tell me how do I correct that. 
EDIT:- I ran ```pre-commit ``` to find the solution. 
How can I fix these MacOS build issues?
> How can I fix these MacOS build issues?

This was fixed by https://github.com/pytorch/text/pull/1889 and should be fixed in your PR once you rebase on the latest main branch. 
> > How can I fix these MacOS build issues?
> 
> This was fixed by #1889 and should be fixed in your PR once you rebase on the latest main branch.

Would I need to sync again then do these changes again?

EDIT: JUST TRYING THAT
Still MacOS errors? Can you point out my mistake, I'm extremely sorry if I have done something wrong 

EDIT: Still 3 errors :(
> Still MacOS errors? Can you point out my mistake, I'm extremely sorry if I have done something wrong
> 
> EDIT: Still 3 errors :(

@arnavmehta7 the current failures are not related to your changes and are caused by flaky tests. Thanks again for working on this. I think you might need to merge in the latest changes from the main branch again since it looks like some of the changes from the latest commits are not reflected in your PR.
@Nayef211 Thanks for guidance, I've done that already :D
@Nayef211  Hey, It is working.

Resolving patch:
diff --git a/torchtext/datasets/multi30k.py b/torchtext/datasets/multi30k.py
--- a/torchtext/datasets/multi30k.py
+++ b/torchtext/datasets/multi30k.py
@@ -12,11 +12,10 @@
     from torchdata.datapipes.iter import FileOpener, IterableWrapper
     from torchtext._download_hooks import HttpReader
 
-# TODO: Update URL to original once the server is back up (see https://github.com/pytorch/text/issues/1756)
 URL = {
-    "train": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/training.tar.gz",
-    "valid": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/validation.tar.gz",
-    "test": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/mmt16_task1_test.tar.gz",
+    "train": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/training.tar.gz",
+    "valid": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/validation.tar.gz",
+    "test": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/mmt16_task1_test.tar.gz",
 }
 
 MD5 = {


Test patch:
diff --git a/test/torchtext_unittest/prototype/test_functional.py b/test/torchtext_unittest/prototype/test_functional.py
--- a/test/torchtext_unittest/prototype/test_functional.py
+++ b/test/torchtext_unittest/prototype/test_functional.py
@@ -1,6 +1,4 @@
 import os
-import platform
-import unittest
 
 import torch
 import torchtext.data as data
@@ -10,8 +8,6 @@
 
 
 class TestFunctional(TorchtextTestCase):
-    # TODO(Nayef211): remove decorator once https://github.com/pytorch/pytorch/issues/38207 is closed
-    @unittest.skipIf(platform.system() == "Windows", "Test is known to fail on Windows.")
     def test_BasicEnglishNormalize(self) -> None:
         test_sample = "'\".<br />,()!?;:   Basic English Normalization for a Line of Text   '\".<br />,()!?;:"
         ref_results = [