Repository: great-expectations/great_expectations

Issue:
show_cta_footer: false has no effect
**Describe the bug**
When building data docs the footer with buttons is not disable-able.

**To Reproduce**
Steps to reproduce the behavior:
1. configure GE to not build footer
2. build docs
3. see footer

**Expected behavior**
I'd expect the footer to respect the disabling.

**Environment (please complete the following information):**
 - OS: [e.g. iOS] macOS
 - GE Version: [e.g. 0.10.0] seen as old as 0.12.6? and as new as 0.13.1


Discussion:
@Aylr Which browser do you see this issue with? Asking to make sure that the browser does not ignore cookies.
both Safari and Chrome

Resolving patch:
diff --git a/great_expectations/core/usage_statistics/anonymizers/data_docs_site_anonymizer.py b/great_expectations/core/usage_statistics/anonymizers/data_docs_site_anonymizer.py
--- a/great_expectations/core/usage_statistics/anonymizers/data_docs_site_anonymizer.py
+++ b/great_expectations/core/usage_statistics/anonymizers/data_docs_site_anonymizer.py
@@ -39,6 +39,7 @@ def anonymize_data_docs_site_info(self, site_name, site_config):
                 site_builder_config=site_index_builder_config
             )
         )
+        # Note AJB-20201218 show_cta_footer was removed in v 0.9.9 via PR #1249
         if "show_cta_footer" in site_index_builder_config:
             anonymized_site_index_builder[
                 "show_cta_footer"
diff --git a/great_expectations/core/usage_statistics/schemas.py b/great_expectations/core/usage_statistics/schemas.py
--- a/great_expectations/core/usage_statistics/schemas.py
+++ b/great_expectations/core/usage_statistics/schemas.py
@@ -45,6 +45,7 @@
             },
             "additionalProperties": True,
             # we don't want this to be true, but this is required to allow show_cta_footer
+            # Note AJB-20201218 show_cta_footer was removed in v 0.9.9 via PR #1249
             "required": ["parent_class"],
         }
     ],
diff --git a/great_expectations/data_context/types/base.py b/great_expectations/data_context/types/base.py
--- a/great_expectations/data_context/types/base.py
+++ b/great_expectations/data_context/types/base.py
@@ -839,15 +839,14 @@ class DataContextConfigDefaults(enum.Enum):
     DEFAULT_DATA_DOCS_SITES = {
         DEFAULT_DATA_DOCS_SITE_NAME: {
             "class_name": "SiteBuilder",
+            "show_how_to_buttons": True,
             "store_backend": {
                 "class_name": "TupleFilesystemStoreBackend",
                 "base_directory": "uncommitted/data_docs/local_site/",
             },
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
-            "show_how_to_buttons": True,
         }
     }
 
@@ -968,7 +967,6 @@ def __init__(
                 },
                 "site_index_builder": {
                     "class_name": "DefaultSiteIndexBuilder",
-                    "show_cta_footer": True,
                 },
             }
         }
@@ -1100,7 +1098,6 @@ def __init__(
                 },
                 "site_index_builder": {
                     "class_name": "DefaultSiteIndexBuilder",
-                    "show_cta_footer": True,
                 },
             }
         }


Test patch:
diff --git a/tests/data_context/test_data_context_config_ui.py b/tests/data_context/test_data_context_config_ui.py
--- a/tests/data_context/test_data_context_config_ui.py
+++ b/tests/data_context/test_data_context_config_ui.py
@@ -199,7 +199,6 @@ def test_DataContextConfig_with_S3StoreBackendDefaults(
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "bucket": "my_default_bucket",
@@ -292,7 +291,6 @@ def test_DataContextConfig_with_S3StoreBackendDefaults_using_all_parameters(
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "bucket": "custom_data_docs_store_bucket_name",
@@ -463,7 +461,6 @@ def test_DataContextConfig_with_GCSStoreBackendDefaults(
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "bucket": "my_default_bucket",
@@ -563,7 +560,6 @@ def test_DataContextConfig_with_GCSStoreBackendDefaults_using_all_parameters(
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "bucket": "custom_data_docs_store_bucket_name",
@@ -664,7 +660,6 @@ def test_DataContextConfig_with_DatabaseStoreBackendDefaults(
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "base_directory": "uncommitted/data_docs/local_site/",
@@ -785,7 +780,6 @@ def test_DataContextConfig_with_DatabaseStoreBackendDefaults_using_all_parameter
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "base_directory": "uncommitted/data_docs/local_site/",
@@ -893,7 +887,6 @@ def test_override_general_defaults(
                 },
                 "site_index_builder": {
                     "class_name": "DefaultSiteIndexBuilder",
-                    "show_cta_footer": True,
                 },
             },
             "local_site": {
@@ -901,7 +894,6 @@ def test_override_general_defaults(
                 "show_how_to_buttons": True,
                 "site_index_builder": {
                     "class_name": "DefaultSiteIndexBuilder",
-                    "show_cta_footer": True,
                 },
                 "store_backend": {
                     "base_directory": "uncommitted/data_docs/local_site/",
@@ -973,7 +965,6 @@ def test_override_general_defaults(
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "base_directory": "uncommitted/data_docs/local_site/",
@@ -984,7 +975,6 @@ def test_override_general_defaults(
             "class_name": "SiteBuilder",
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "bucket": "REPLACE_ME",
@@ -1088,7 +1078,6 @@ def test_DataContextConfig_with_S3StoreBackendDefaults_and_simple_defaults_with_
             "show_how_to_buttons": True,
             "site_index_builder": {
                 "class_name": "DefaultSiteIndexBuilder",
-                "show_cta_footer": True,
             },
             "store_backend": {
                 "bucket": "my_default_bucket",
diff --git a/tests/data_context/test_data_context_in_code_config.py b/tests/data_context/test_data_context_in_code_config.py
--- a/tests/data_context/test_data_context_in_code_config.py
+++ b/tests/data_context/test_data_context_in_code_config.py
@@ -80,7 +80,6 @@ def build_in_code_data_context_project_config(
                 },
                 "site_index_builder": {
                     "class_name": "DefaultSiteIndexBuilder",
-                    "show_cta_footer": True,
                 },
             }
         },