Repository: biolab/orange3

Issue:
Feature Statistics: put controls above main area
Feature Statistics has a large control area to the left. It only has one setting + apply button.

Remove control area. Put controls below the widget (similar to Venn Diagram).


Discussion:
I know we did this with Venn, but should we really be doing this?

- Vertical space is usually more valuable than horizontal space,
- the control area can always be collapsed,
- (perhaps most importantly,) it breaks OW standards (controls to the left, viz to the right).

If we decide to do this for all widgets with not a lot of controls, we should make it a feature – making it collapsible and easily settable as a GUI layout option.
TBH, Venn is not the only widget like that. File and Datasets are kindaaa like that, but I would say Correlations, Create Instance, Sieve Diagram, Distance Matrix are exactly like that.

You say yourself that vertical space is more valuable than horizontal? So what not make the most of it and move the single control at the top?

I agree, that collapsability is something that would not be fully supported with this option (yet).
As much as I don't like the current layout, neither of these two is to die for. Nicer than before, though. Comments?

<img width="803" alt="Screenshot 2021-01-29 at 14 09 00" src="https://user-images.githubusercontent.com/2387315/106278934-e0db6800-623b-11eb-8589-3538061fe39d.png">

<img width="779" alt="Screenshot 2021-01-29 at 14 10 57" src="https://user-images.githubusercontent.com/2387315/106278939-e33dc200-623b-11eb-8de1-01a1c1ea2105.png">


On top isn't so bad, though.

<img width="882" alt="Screenshot 2021-01-29 at 14 17 38" src="https://user-images.githubusercontent.com/2387315/106279502-c786eb80-623c-11eb-8dc6-d76eab430a29.png">

I actually like the second one best. 😆 UI is just hard.
If you like the second one, what about this one? (Top, no box.)

<img width="823" alt="Screenshot 2021-01-29 at 14 35 30" src="https://user-images.githubusercontent.com/2387315/106281265-48df7d80-623f-11eb-861f-3c11152fd29c.png">


Resolving patch:
diff --git a/Orange/widgets/data/owfeaturestatistics.py b/Orange/widgets/data/owfeaturestatistics.py
--- a/Orange/widgets/data/owfeaturestatistics.py
+++ b/Orange/widgets/data/owfeaturestatistics.py
@@ -710,7 +710,7 @@ class Outputs:
         reduced_data = Output('Reduced Data', Table, default=True)
         statistics = Output('Statistics', Table)
 
-    want_main_area = True
+    want_control_area = False
     buttons_area_orientation = Qt.Vertical
 
     settingsHandler = DomainContextHandler()
@@ -738,11 +738,13 @@ def __init__(self):
         # shortcut = QShortcut(QKeySequence('Ctrl+f'), self, self.filter_text.setFocus)
         # shortcut.setWhatsThis('Filter variables by name')
 
+        box = gui.hBox(None, box=False)
+        box.setContentsMargins(0, 0, 0, 0)
+
         self.color_var_model = DomainModel(
             valid_types=(ContinuousVariable, DiscreteVariable),
             placeholder='None',
         )
-        box = gui.vBox(self.controlArea, 'Histogram')
         self.cb_color_var = gui.comboBox(
             box, master=self, value='color_var', model=self.color_var_model,
             label='Color:', orientation=Qt.Horizontal, contentsLength=13,
@@ -750,8 +752,9 @@ def __init__(self):
         )
         self.cb_color_var.activated.connect(self.__color_var_changed)
 
-        gui.rubber(self.controlArea)
-        gui.auto_send(self.buttonsArea, self, "auto_commit")
+        gui.rubber(box)
+        gui.auto_send(box, self, "auto_commit", box=None)
+        self.mainArea.layout().addWidget(box)
 
         self.info.set_input_summary(self.info.NoInput)
         self.info.set_output_summary(self.info.NoOutput)


Test patch: