Repository: kivy/python-for-android

Issue:
vlc recipe build fail
### Logs

A first build fails with

```
[INFO]:    Building vlc for arm64-v8a
[INFO]:    -> directory context /home/bobf/ex/hello/.buildozer/android/platform/build-arm64-v8a/build/other_builds/vlc/arm64-v8a__ndk_target_21/vlc/vlc-port-android
[INFO]:    compiling vlc from sources
[DEBUG]:   environment: {'SHELL': '/bin/bash', 'WSL2_GUI_APPS_ENABLED': '1', 'WSL_DISTRO_NAME': 'Ubuntu-22.04', 'WT_SESSION': '15e13e88-1c44-49f6-a30f-3567f5691f5f', 'NAME': 'DESK', 'PWD': '/home/bobf/ex/hello', 'LOGNAME': 'bobf', 'KIVY': '/mnt/c/users/bobf/documents/kivy', 'UIMD': '/mnt/c/users/bobf/documents/pm/uimd', 'HOME': '/home/bobf', 'LANG': 'C.UTF-8', 'WSL_INTEROP': '/run/WSL/9_interop', 'LS_COLORS': 'rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.webp=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:', 'WAYLAND_DISPLAY': 'wayland-0', 'LESSCLOSE': '/usr/bin/lesspipe %s %s', 'TERM': 'xterm-256color', 'LESSOPEN': '| /usr/bin/lesspipe %s', 'USER': 'bobf', 'WIN': '/mnt/c/users/bobf', 'DISPLAY': ':0', 'SHLVL': '1', 'XDG_RUNTIME_DIR': '/mnt/wslg/runtime-dir', 'WSLENV': 'WT_SESSION::WT_PROFILE_ID', 'XDG_DATA_DIRS': '/usr/local/share:/usr/share:/var/lib/snapd/desktop', 'GITHUB': '/mnt/c/users/bobf/documents/GitHub', 'PATH': '/home/bobf/.buildozer/android/platform/apache-ant-1.9.4/bin:/home/bobf/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Program Files (x86)/Common Files/Oracle/Java/javapath:/mnt/c/WINDOWS/system32:/mnt/c/WINDOWS:/mnt/c/WINDOWS/System32/Wbem:/mnt/c/WINDOWS/System32/WindowsPowerShell/v1.0/:/mnt/c/WINDOWS/System32/OpenSSH/:/mnt/c/Program Files/Git/cmd:/mnt/c/Program Files/dotnet/:/mnt/c/Users/Bobf/AppData/Local/Programs/Python/Python311/Scripts/:/mnt/c/Users/Bobf/AppData/Local/Programs/Python/Python311/:/mnt/c/Users/Bobf/AppData/Local/Programs/Python/Python310/Scripts/:/mnt/c/Users/Bobf/AppData/Local/Programs/Python/Python310/:/mnt/c/Users/Bobf/AppData/Local/Microsoft/WindowsApps:/mnt/c/Users/Bobf/AppData/Local/Android/Sdk/platform-tools:/mnt/c/Users/Bobf/AppData/Local/Android/Sdk/emulator:/mnt/c/Program Files/MySQL/MySQL Server 8.0/bin:/mnt/c/tools/kotlinc/bin:/mnt/c/Users/Bobf/AppData/Local/Programs/MiKTeX/miktex/bin/x64/:/mnt/c/Users/Bobf/AppData/Local/GitHubDesktop/bin:/mnt/c/Tools/ffmpeg-2023-01-25-essentials/bin:/snap/bin:/home/bobf/.local/bin/', 'HOSTTYPE': 'x86_64', 'PULSE_SERVER': 'unix:/mnt/wslg/PulseServer', 'WT_PROFILE_ID': '{d7b20cea-47a9-518c-95a4-c8bd91e2e1c6}', 'OLDPWD': '/home/bobf/ex/regression', '_': '/home/bobf/.local/bin/buildozer', 'PACKAGES_PATH': '/home/bobf/.buildozer/android/packages', 'ANDROIDSDK': '/home/bobf/.buildozer/android/platform/android-sdk', 'ANDROIDNDK': '/home/bobf/.buildozer/android/platform/android-ndk-r25b', 'ANDROIDAPI': '31', 'ANDROIDMINAPI': '21', 'ANDROID_ABI': 'arm64-v8a', 'ANDROID_NDK': '/home/bobf/.buildozer/android/platform/android-ndk-r25b', 'ANDROID_SDK': '/home/bobf/.buildozer/android/platform/android-sdk'}
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/toolchain.py", line 1312, in <module>
    main()
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/entrypoints.py", line 18, in main
    ToolchainCL()
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/toolchain.py", line 734, in __init__
    getattr(self, command)(args)
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/toolchain.py", line 153, in wrapper_func
    build_dist_from_args(ctx, dist, args)
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/toolchain.py", line 212, in build_dist_from_args
    build_recipes(build_order, python_modules, ctx,
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/build.py", line 504, in build_recipes
    recipe.build_arch(arch)
  File "/home/bobf/ex/hello/.buildozer/android/platform/python-for-android/pythonforandroid/recipes/vlc/__init__.py", line 68, in build_arch
    shprint(sh.Command('./compile.sh'), _env=env,
  File "/home/bobf/.local/lib/python3.10/site-packages/sh.py", line 1342, in __init__
    raise CommandNotFound(path)
sh.CommandNotFound: ./compile.sh
========================================
```
subsequent builds fail with 
```
[DEBUG]:   -> running git clone http://git.videolan.org/git/vlc-ports/android.git /home/bobf/ex/hello/.buildozer/android/platform/build-arm64-v8a/build/other_builds/vlc/arm64-v8a__ndk_target_21/vlc/vlc-port-android
[DEBUG]:        fatal: destination path '/home/bobf/ex/hello/.buildozer/android/platform/build-arm64-v8a/build/other_builds/vlc/arm64-v8a__ndk_target_21/vlc/vlc-port-android' already exists and is not an empty directory.
Exception in thread background thread for pid 21212:
```



Discussion:

Resolving patch:
diff --git a/pythonforandroid/recipes/vlc/__init__.py b/pythonforandroid/recipes/vlc/__init__.py
--- a/pythonforandroid/recipes/vlc/__init__.py
+++ b/pythonforandroid/recipes/vlc/__init__.py
@@ -6,7 +6,7 @@
 
 
 class VlcRecipe(Recipe):
-    version = '3.0.0'
+    version = '3.0.18'
     url = None
     name = 'vlc'
 
@@ -52,7 +52,7 @@ def prebuild_arch(self, arch):
     def build_arch(self, arch):
         super().build_arch(arch)
         build_dir = self.get_build_dir(arch.arch)
-        port_dir = join(build_dir, 'vlc-port-android')
+        port_dir = join(build_dir, 'vlc-port-android', 'buildsystem')
         aar = self.aars[arch]
         if not isfile(aar):
             with current_directory(port_dir):
@@ -67,7 +67,7 @@ def build_arch(self, arch):
                 if not isfile(join('bin', 'VLC-debug.apk')):
                     shprint(sh.Command('./compile.sh'), _env=env,
                             _tail=50, _critical=True)
-                shprint(sh.Command('./compile-libvlc.sh'), _env=env,
+                shprint(sh.Command('./compile-medialibrary.sh'), _env=env,
                         _tail=50, _critical=True)
         shprint(sh.cp, '-a', aar, self.ctx.aars_dir)
 


Test patch: