Repository: openstates/openstates-scrapers

Issue:
NY failing since at least 2017-12-03
NY has been failing since 2017-12-03

Based on automated runs it appears that NY has not run successfully in 2 days (2017-12-03).


```
  23:04:41 INFO pupa: save person Simotas, Aravella as person_a26f9bb2-d8b0-11e7-b5da-0242ac110006.json
23:04:41 INFO pupa: save membership a26f9bb2-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a26f9f40-d8b0-11e7-b5da-0242ac110006.json
23:04:41 INFO pupa: save membership a26f9bb2-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Democratic"} as membership_a26fa166-d8b0-11e7-b5da-0242ac110006.json
23:04:41 INFO scrapelib: GET - http://assembly.state.ny.us/mem/Frank-Skartados
23:04:42 INFO pupa: save person Skartados, Frank as person_a314bd22-d8b0-11e7-b5da-0242ac110006.json
23:04:42 INFO pupa: save membership a314bd22-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a314c0a6-d8b0-11e7-b5da-0242ac110006.json
23:04:42 INFO pupa: save membership a314bd22-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Democratic"} as membership_a314c52e-d8b0-11e7-b5da-0242ac110006.json
23:04:42 INFO scrapelib: GET - http://assembly.state.ny.us/mem/James-Skoufis
23:04:43 INFO pupa: save person Skoufis, James as person_a3a6999a-d8b0-11e7-b5da-0242ac110006.json
23:04:43 INFO pupa: save membership a3a6999a-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a3a69d3c-d8b0-11e7-b5da-0242ac110006.json
23:04:43 INFO pupa: save membership a3a6999a-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Democratic"} as membership_a3a69f62-d8b0-11e7-b5da-0242ac110006.json
23:04:43 INFO scrapelib: GET - http://assembly.state.ny.us/mem/Michaelle-C-Solages
23:04:44 INFO pupa: save person Solages, Michaelle as person_a43aed52-d8b0-11e7-b5da-0242ac110006.json
23:04:44 INFO pupa: save membership a43aed52-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a43af0f4-d8b0-11e7-b5da-0242ac110006.json
23:04:44 INFO pupa: save membership a43aed52-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Democratic"} as membership_a43af496-d8b0-11e7-b5da-0242ac110006.json
23:04:44 INFO scrapelib: GET - http://assembly.state.ny.us/mem/Dan-Stec
23:04:45 INFO pupa: save person Stec, Dan as person_a4ca023a-d8b0-11e7-b5da-0242ac110006.json
23:04:45 INFO pupa: save membership a4ca023a-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a4ca062c-d8b0-11e7-b5da-0242ac110006.json
23:04:45 INFO pupa: save membership a4ca023a-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Republican"} as membership_a4ca0866-d8b0-11e7-b5da-0242ac110006.json
23:04:45 INFO scrapelib: GET - http://assembly.state.ny.us/mem/Phil-Steck
23:04:46 INFO pupa: save person Steck, Phil as person_a570bb52-d8b0-11e7-b5da-0242ac110006.json
23:04:46 INFO pupa: save membership a570bb52-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a570bfe4-d8b0-11e7-b5da-0242ac110006.json
23:04:46 INFO pupa: save membership a570bb52-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Democratic"} as membership_a570c214-d8b0-11e7-b5da-0242ac110006.json
23:04:46 INFO scrapelib: GET - http://assembly.state.ny.us/mem/Al-Stirpe
23:04:47 INFO pupa: save person Stirpe, Al as person_a60930ee-d8b0-11e7-b5da-0242ac110006.json
23:04:47 INFO pupa: save membership a60930ee-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "lower"} as membership_a6093486-d8b0-11e7-b5da-0242ac110006.json
23:04:47 INFO pupa: save membership a60930ee-d8b0-11e7-b5da-0242ac110006 membership in ~{"classification": "party", "name": "Democratic"} as membership_a60938e6-d8b0-11e7-b5da-0242ac110006.json
23:04:47 CRITICAL pupa: Party for Taylor, Al (Assembly district 71) has not been listed yet
no pupa_settings on path, using defaults
ny (scrape, import)
  people: {}
  bills: {}
  File "/opt/openstates/venv-pupa//bin/pupa", line 11, in <module>
Traceback (most recent call last):
    load_entry_point('pupa', 'console_scripts', 'pupa')()
  File "/opt/openstates/venv-pupa/src/pupa/pupa/cli/__main__.py", line 67, in main
    subcommands[args.subcommand].handle(args, other)
  File "/opt/openstates/venv-pupa/src/pupa/pupa/cli/commands/update.py", line 260, in handle
    return self.do_handle(args, other, juris)
  File "/opt/openstates/venv-pupa/src/pupa/pupa/cli/commands/update.py", line 305, in do_handle
    report['scrape'] = self.do_scrape(juris, args, scrapers)
  File "/opt/openstates/venv-pupa/src/pupa/pupa/cli/commands/update.py", line 173, in do_scrape
    report[scraper_name] = scraper.do_scrape(**scrape_args)
  File "/opt/openstates/venv-pupa/src/pupa/pupa/scrape/base.py", line 111, in do_scrape
    for obj in self.scrape(**kwargs) or []:
  File "/opt/openstates/openstates/openstates/ny/people.py", line 237, in scrape
    yield from self.scrape_lower_chamber('lower')
  File "/opt/openstates/openstates/openstates/ny/people.py", line 411, in scrape_lower_chamber
    raise ValueError(name)
ValueError: Taylor, Al
```

Visit http://bobsled.openstates.org for more info.



Discussion:

Resolving patch:
diff --git a/openstates/ny/people.py b/openstates/ny/people.py
--- a/openstates/ny/people.py
+++ b/openstates/ny/people.py
@@ -405,7 +405,10 @@ def scrape_lower_chamber(self, chamber):
                 self.critical(
                     'Party for {} (Assembly district {}) has not been listed yet'.format(
                         name, district))
-                if name in ('Farrell, Jr., Herman', 'Simanowitz, Michael', 'Rosenthal, Daniel'):
+                if name in ('Farrell, Jr., Herman',
+                            'Simanowitz, Michael',
+                            'Rosenthal, Daniel',
+                            'Taylor, Al'):
                     party = 'Democratic'
                 else:
                     raise ValueError(name)


Test patch: