Repository: spyder-ide/spyder

Issue:
Wrong Sphinx version detection for jsmath
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->

### Issue Report Checklist

* [x] Searched the [issues page](https://github.com/spyder-ide/spyder/issues?q=is%3Aissue) for similar reports
* [ ] Read the relevant sections of the [Spyder Troubleshooting Guide](https://github.com/spyder-ide/spyder/wiki/Troubleshooting-Guide-and-FAQ) and followed its advice
* [x] Reproduced the issue after updating with ``conda update spyder`` (or ``pip``, if not using Anaconda)
* [ ] Could not reproduce inside ``jupyter qtconsole`` (if console-related)
* [x] Tried basic troubleshooting (if a bug/error)
    * [x] Restarted Spyder
    * [ ] Reset preferences with ``spyder --reset``
    * [ ] Reinstalled the latest version of [Anaconda](https://www.anaconda.com/download/)
    * [ ] Tried the other applicable steps from the Troubleshooting Guide
* [ ] Completed the **Problem Description**, **Steps to Reproduce** and **Version** sections below


## Problem Description

I am getting an error everytime for the help panel:
![image](https://github.com/spyder-ide/spyder/assets/403283/5f4c42c3-ee41-4c1e-89d7-22fc1715864c)

Looking at the code the jsmath package is not updated since 2019 and I have sphinx 7.2.6.
Reading the code on this check that use jsmath should be for 1.1 < releases.

https://github.com/spyder-ide/spyder/blob/2429caa5a7066a5d8fb5754aed2e07d7d8266062/spyder/plugins/help/utils/conf.py#L40

Change the line 40 in that file to:

```
if sphinx_version < "1.1" and not math:
```

Fix the issue (in my case the `math` variable is false).

### What is the expected output? What do you see instead?


## Versions

* Spyder version: 5.4.5
* Python version: 3.11

### Dependencies
<!--- Please go to the menu entry Help > Dependencies,
press the Copy to clipboard button and paste below --->

```
# Mandatory:
atomicwrites >=1.2.0                                                        :  1.4.1 (OK)
chardet >=2.0.0                                                             :  5.2.0 (OK)
cloudpickle >=0.5.0                                                         :  2.2.1 (OK)
cookiecutter >=1.6.0                                                        :  2.1.1 (OK)
diff_match_patch >=20181111                                                 :  20200713 (OK)
intervaltree >=3.0.2                                                        :  3.1.0 (OK)
IPython >=7.31.1,<9.0.0,!=8.8.0,!=8.9.0,!=8.10.0,!=8.11.0,!=8.12.0,!=8.12.1 :  8.14.0 (OK)
jedi >=0.17.2,<0.19.0                                                       :  0.18.2 (OK)
jellyfish >=0.7                                                             :  0.9.0 (OK)
jsonschema >=3.2.0                                                          :  4.10.3 (OK)
keyring >=17.0.0                                                            :  24.2.0 (OK)
nbconvert >=4.0                                                             :  6.5.3 (OK)
numpydoc >=0.6.0                                                            :  1.5.0 (OK)
parso >=0.7.0,<0.9.0                                                        :  0.8.3 (OK)
pexpect >=4.4.0                                                             :  4.8.0 (OK)
pickleshare >=0.4                                                           :  0.7.5 (OK)
psutil >=5.3                                                                :  5.9.5 (OK)
pygments >=2.0                                                              :  2.15.1 (OK)
pylint >=2.5.0,<3.0                                                         :  2.17.4 (OK)
pylint_venv >=3.0.2                                                         :  3.0.3 (OK)
pyls_spyder >=0.4.0                                                         :  0.4.0 (OK)
pylsp >=1.7.4,<1.8.0                                                        :  1.7.4 (OK)
pylsp_black >=1.2.0,<3.0.0                                                  :  1.3.0 (OK)
qdarkstyle >=3.0.2,<3.2.0                                                   :  3.0.3 (OK)
qstylizer >=0.2.2                                                           :  0.2.2 (OK)
qtawesome >=1.2.1                                                           :  1.2.2 (OK)
qtconsole >=5.4.2,<5.5.0                                                    :  5.4.3 (OK)
qtpy >=2.1.0                                                                :  2.3.1 (OK)
rtree >=0.9.7                                                               :  1.0.1 (OK)
setuptools >=49.6.0                                                         :  68.1.2 (OK)
sphinx >=0.6.6                                                              :  7.2.6 (OK)
spyder_kernels >=2.4.4,<2.5.0                                               :  2.4.4 (OK)
textdistance >=4.2.0                                                        :  4.5.0 (OK)
three_merge >=0.1.1                                                         :  0.1.1 (OK)
watchdog >=0.10.3                                                           :  3.0.0 (OK)
xdg >=0.26                                                                  :  0.28 (OK)
zmq >=22.1.0                                                                :  24.0.1 (OK)

# Optional:
cython >=0.21                                                               :  None (NOK)
matplotlib >=3.0.0                                                          :  3.6.3 (OK)
numpy >=1.7                                                                 :  1.24.2 (OK)
pandas >=1.1.1                                                              :  1.5.3 (OK)
scipy >=0.17.0                                                              :  None (NOK)
sympy >=0.7.3                                                               :  1.12 (OK)
```



Discussion:
Hi @Mte90 thank you for the feedback! I think I was able to reproduce this :+1: So, I think the `math` value is the state of the Help `Render mathematical equations` option:

![image](https://github.com/spyder-ide/spyder/assets/16781833/046b35c4-f72a-48a9-b4fa-0230edd002dd)

Disabling it triggers the error indeed. From my understanding seems like your suggested fix make sense but, just in case, what do you think @ccordoba12 ?

Resolving patch:
diff --git a/spyder/plugins/help/utils/conf.py b/spyder/plugins/help/utils/conf.py
--- a/spyder/plugins/help/utils/conf.py
+++ b/spyder/plugins/help/utils/conf.py
@@ -37,10 +37,13 @@
 # We need jsmath to get pretty plain-text latex in docstrings
 math = CONF.get('help', 'math', '')
 
-if sphinx_version < "1.1" or not math:
-    extensions = ['sphinx.ext.jsmath']
-else:
-    extensions = ['sphinx.ext.mathjax']
+extensions = []
+
+if math:
+    if sphinx_version < "1.1":
+        extensions = ['sphinx.ext.jsmath']
+    else:
+        extensions = ['sphinx.ext.mathjax']
 
 # For scipy and matplotlib docstrings, which need this extension to
 # be rendered correctly. See spyder-ide/spyder#1138.


Test patch: