Repository: nvaccess/nvda

Issue:
In the windows explorer in the open dialog file list file names are read twice
<!--
Please thoroughly read NVDA's wiki article on how to fill in this template, including how to provide the required files.
Issues may be closed if the required information is not present.
https://github.com/nvaccess/nvda/wiki/Github-issue-template-explanation-and-examples
-->

### Steps to reproduce:
1. for example, open the NVDA add-ons manager, and press on install add-on button.
2. when pressed, the open dialog appears to chose the add-on.
3. press shift+tab twice to go to the file list.
4. find the desired file you need
### Actual behavior:
file and folder names are pronounced twice, for example ad-on updater.nvda-addon, or the folder name add-ons add-ons
### Expected behavior:
Folder and file names should be spoken once, as in NVDA 2019.2.1
### System configuration
#### NVDA installed/portable/running from source:
installed and portable
#### NVDA version:
latest NVDA beta 2019.3 beta 1 and the last snap from the alpha branch
#### Windows version:
10.0.18363
#### Name and version of other software in use when reproducing the issue:
n/a
#### Other information about your system:
DualCore Intel Core i7-7500U, 3500 MHz (35 x 100),
8GB DDR 4 (2133)
tested also on my lenovo ideapad 320 15isk intel i3 6006U
### Other questions
#### Does the issue still occur after restarting your PC?
yes
#### Have you tried any other versions of NVDA? If so, please report their behaviors.
2019.2.1, this version pronounces file and folder names in the windows explorer open dialog file  list once.
Dubbal Speaking in the New Add-On manager
**Reported by Brendon22 on 2012-05-29 03:09**
Hi when browsing to the Folder that you have your Add-on's in for NVDA. All of your folder names are being spoken twice? So if you had a folder called NVDA Add-on's. NVDA would say NVDA Add-on's NVDA Add-on's not just NVDA Add-on's . This is true for every folder that you pass? Using NVDA RC1



Discussion:
Actually, I can replicate that bug in 2019.2.1.

> 2019.2.1, this version pronounces file and folder names in the windows explorer open dialog file list once.

What about in the add-on installer dialog? I am getting your double-speak 
behavior there in 2019.2.1.

This is a duplicate of #2395 and it is definitely not a regression.
Can you give arguments, why this is not a bug?

Users see this like a bug, because it’s spurious
Luke…

It’s normal for portable copies, but not for installed
@zstanecic wrote;

> 
> Can you give arguments, why this is not a bug? Users see this like a bug, because it’s spurious 

Where you've seen me saying that it is not a bug? I only said that it is not a regression because, well duplicate of issue from 2012 cannot be a regression, can it?
> It’s normal for portable copies, but not for installed

My 2019.2.1 is installed. Win 10 1909.
And that shouldn't be normal for any copies.
Are tool tips turned on?

One thing I do notice though is that some open dialogues are different to 
others and have different behaviour quite often, some are more like the old 
xp  look and feel, others like the version of windows being run. I've even 
found the sorting order of files different in open dialogues as well, so one 
has to be careful about blaming explorer.

Hi brian,

Tooltips are off.
I can reproduce this issue in 2019.3beta2 and also in 2019.2.1. While it is not a regression it would be good to fix it if we can. It won't get fixed for 2019.3.
Hi, I get a feeling that this is caused by name/description pair where both strings are the same. If so, fixing this should also fix the problem experienced by people trying to install add-ons from Add-ons Manager rather than from File Explorer. Thanks.
Comment 1 by briang1 on 2012-05-29 08:09
Now though I do not myself have a 64bit system, there is some anecdotal evidence that sometimes double speaking of list items and tree views can occur in nvda. anyone else care to comment.

Are you using 64 bit by any chance?

Comment 2 by Brendon22 on 2012-05-29 08:29
Hi, Yes I am using a 64-Bit Version on Win 7! And I do get a lot of dubbal speaking! :)

Comment 3 by jteh on 2012-05-29 09:00
This occurs due to the fact that we disable UI Automation for our own process in Windows 7, but the Windows 7 Explorer file list behaves better with UIA than it does with MSAA. Not sure how to solve this yet.
Changes:
Milestone changed from None to near-term

Comment 4 by Brendon22 (in reply to comment 3) on 2012-05-29 09:14
Hi, if this is changed, would this fix some other places wair NVDA says things more than once?

Comment 5 by jteh on 2012-05-29 09:15
No.

Comment 6 by Brendon22 on 2012-08-21 05:52
Hello,
This problem hasn't been fixed yet? Just wondering how this is going?
Comment made by Jamey:
This occurs due to the fact that we disable UI Automation for our own process in Windows 7, but the Windows 7 Explorer file list behaves better with UIA than it does with MSAA. Not sure how to solve this yet.

Comment 7 by Brendon22 on 2012-09-17 05:07
Hello,

Even with the changes made to the Add-on manager, this problem still isn't fixed yet.

Comment 8 by Brendon22 on 2013-03-31 00:58
Hello,

This would be really nice if this was fixed. This happends know ware else in NVDA.

Comment 9 by Ahiiron on 2013-04-06 08:47
OK. I think he gets it.  Oy Oy.

If it's that annoying, assuming it's an installed copy, just find the addon file adn wack Enter on it. You can install addons that way now.

Comment 10 by Brendon22 on 2013-04-06 10:43
Hello Ahiiron,

Thank you for your comment, I was just checking up on when this will be fixed! I wasn't trying to make anyone angry.

Comment 11 by Brendon22 on 2014-05-29 10:50
Hello,

This issue is still happening. Any chance of fixing this issue?

@Brendon22 is this still an issue?
Just to inform, this is still reproducible in NVDA 2019.1.1 on Windows 10 1809 Update.

Resolving patch:
diff --git a/source/NVDAObjects/IAccessible/__init__.py b/source/NVDAObjects/IAccessible/__init__.py
--- a/source/NVDAObjects/IAccessible/__init__.py
+++ b/source/NVDAObjects/IAccessible/__init__.py
@@ -1954,6 +1954,14 @@ def event_alert(self):
 				speech.speakObject(child,reason=controlTypes.REASON_FOCUS)
 			child=child.simpleNext
 
+
+class UIItem(IAccessible):
+	"""List items in Windows Explorer repeat the name as the value"""
+
+	def _get_value(self):
+		return ""
+
+
 ###class mappings
 
 _staticMap={
@@ -1979,6 +1987,7 @@ def event_alert(self):
 	("SysListView32",oleacc.ROLE_SYSTEM_LIST):"sysListView32.List",
 	("SysListView32",oleacc.ROLE_SYSTEM_GROUPING):"sysListView32.List",
 	("SysListView32",oleacc.ROLE_SYSTEM_LISTITEM):"sysListView32.ListItem",
+	("DirectUIHWND", oleacc.ROLE_SYSTEM_LISTITEM): "UIItem",
 	("SysListView32",oleacc.ROLE_SYSTEM_MENUITEM):"sysListView32.ListItemWithoutColumnSupport",
 	("SysTreeView32",oleacc.ROLE_SYSTEM_OUTLINE):"sysTreeView32.TreeView",
 	("SysTreeView32",oleacc.ROLE_SYSTEM_OUTLINEITEM):"sysTreeView32.TreeViewItem",


Test patch: