Repository: svthalia/concrexit

Issue:
TinyMCE5
### Summary
Updates our tinymce dependency

### How to test
1. View event admin change
2. View an event details page
TinyMCE editor shows superfluous markup options
### Describe the bug
PR #2201 changed the TinyMCE settings to include a whole toolbar. And I am not sure why, because we had a carefully selected list of options available. 

### How to reproduce
Steps to reproduce the behaviour:
1. Go to a page with a TinyMCE HTMLField (that works and is not broken)
2. Note that the toolbar contains a thousand options.

### Expected behaviour
The toolbar should only contain a really small subset of HTML options.

### Screenshots
If applicable, add screenshots to help explain your problem.

### Additional context
We have deliberately chosen for a subset of HTML options in the past because we don't want anyone using the website actually inserting any fancy styles at all. This is for multiple reasons:
 - People within Thalia do crazy stuff, like fill a description with tables and images instead of readable text that also works on the frontpage, on mobile and in the app.
 - Some HTML tags do not have proper styling, like quotes and some of the header styles
 - In some of the HTML editor situations we cannot even support some of the styles, like in the newsletter. Since it needs inline styling on all elements we want the input (which is directly taken from the events) to be as basic as possible.

Some of this behaviour is also enforced by [our bleach configuration](https://github.com/svthalia/concrexit/blob/master/website/thaliawebsite/templatetags/bleach_tags.py). Some of the options available in the toolbar after this change will just be filtered out and are thus there for no reason.



Discussion:
Code Climate has analyzed commit 400d29bf and detected **0 issues** on this pull request.

View more on [Code Climate](https://codeclimate.com/github/svthalia/concrexit/pull/2201).



Resolving patch:
diff --git a/website/thaliawebsite/settings.py b/website/thaliawebsite/settings.py
--- a/website/thaliawebsite/settings.py
+++ b/website/thaliawebsite/settings.py
@@ -683,20 +683,17 @@ def from_env(
 
 # TinyMCE config
 TINYMCE_DEFAULT_CONFIG = {
-    "selector": "textarea",
-    "plugins": "advlist anchor autolink autosave charmap code codesample fullscreen hr image media link lists table",
-    "toolbar1": "styleselect | bold italic underline strikethrough | hr charmap codesample | link unlink | bullist numlist outdent indent | table image media | undo redo | code",
-    "contextmenu": "bold italic underline strikethrough | image",
+    "max_height": 500,
     "menubar": False,
-    "inline": False,
-    "statusbar": True,
-    "width": "auto",
-    "height": 240,
+    "plugins": "autolink autoresize link image code media paste",
+    "toolbar": "h2 h3 | bold italic underline strikethrough | image media | link unlink | "
+    "bullist numlist | undo redo | code",
+    "contextmenu": "bold italic underline strikethrough | link",
     "paste_as_text": True,
     "relative_urls": False,
     "remove_script_host": False,
+    "autoresize_bottom_margin": 50,
 }
-TINYMCE_COMPRESSOR = True
 
 BOOTSTRAP5 = {"required_css_class": "required-field"}
 


Test patch: