Repository: acl-org/acl-anthology

Issue:
Paper Metadata: 2023.emnlp-main.325, 2023.emnlp-main.336, 2023.emnlp-main.1037, 2023.findings-emnlp.962
### Confirm that this is a metadata correction

- [X] I want to file corrections to make the metadata match the PDF file hosted on the ACL Anthology.

### Anthology ID

2023.emnlp-main.325, 2023.emnlp-main.336, 2023.emnlp-main.1037, 2023.findings-emnlp.962

### Type of Paper Metadata Correction

- [ ] Paper Title
- [ ] Paper Abstract
- [X] Author Name(s)

### Correction to Paper Title

_No response_

### Correction to Paper Abstract

_No response_

### Correction to Author Name(s)

Hello, for these papers I have noticed that my name is listed as Junyi Li, but it should be Junyi Jessy Li (double first name, "Jessy" is not a middle name). Strangely, this is the first time that this happened; my OpenReview page has the correct name, and ACL Anthology ingestion was fine with ACL and NAACL in 2022 when OpenReview was also used. Please help look into this, thanks! -- Jessy


Discussion:

Resolving patch:
diff --git a/bin/ingest_aclpub2.py b/bin/ingest_aclpub2.py
--- a/bin/ingest_aclpub2.py
+++ b/bin/ingest_aclpub2.py
@@ -149,8 +149,8 @@ def parse_conf_yaml(ingestion_dir: str) -> Dict[str, Any]:
     ingestion_dir = Path(ingestion_dir)
 
     paths_to_check = [
-        ingestion_dir / 'conference_details.yml',
         ingestion_dir / 'inputs' / 'conference_details.yml',
+        ingestion_dir / 'conference_details.yml',
     ]
     meta = None
     for path in paths_to_check:
@@ -193,8 +193,8 @@ def parse_paper_yaml(ingestion_dir: str) -> List[Dict[str, str]]:
     ingestion_dir = Path(ingestion_dir)
 
     paths_to_check = [
-        ingestion_dir / 'papers.yml',
         ingestion_dir / 'inputs' / 'papers.yml',
+        ingestion_dir / 'papers.yml',
     ]
     papers = None
     for path in paths_to_check:
@@ -236,8 +236,6 @@ def add_paper_nums_in_paper_yaml(
         paths_to_check = [
             ingestion_dir / "watermarked_pdfs" / paper_path,
             ingestion_dir / "watermarked_pdfs" / f"{paper_id}.pdf",
-            ingestion_dir / "build" / "watermarked_pdfs" / paper_path,
-            ingestion_dir / "build" / "watermarked_pdfs" / f"{paper_id}.pdf",
         ]
         paper_need_read_path = None
         for path in paths_to_check:
@@ -491,7 +489,6 @@ def copy_pdf_and_attachment(
     pdfs_src_dir = None
     paths_to_check = [
         meta['path'] / 'watermarked_pdfs',
-        meta['path'] / 'build' / 'watermarked_pdfs',
     ]
     for path in paths_to_check:
         if path.exists() and path.is_dir():
@@ -540,15 +537,13 @@ def copy_pdf_and_attachment(
     frontmatter_src_path = None
     paths_to_check = [
         meta['path'] / 'front_matter.pdf',
-        meta['path'] / '0.pdf',
         meta['path'] / "watermarked_pdfs" / 'front_matter.pdf',
         meta['path'] / "watermarked_pdfs" / '0.pdf',
-        meta['path'] / "build" / 'front_matter.pdf',
-        meta['path'] / "build" / '0.pdf',
     ]
     for path in paths_to_check:
         if path.exists():
             frontmatter_src_path = str(path)
+            print(f"Found frontmatter at {frontmatter_src_path}", file=sys.stderr)
             break
     else:
         print(
@@ -701,8 +696,15 @@ def create_xml(
         # print(f'creating xml for paper name {paper}, in papers {papers[paper_num-1]}')
         if paper_num == 0:
             paper_node = proceeding2xml(paper_id_full, meta, volume[0])
+            # year, venue = collection_id.split(".")
+            # bibkey = f"{venue}-{year}-{volume_name}"
         else:
             paper_node = paper2xml(papers[paper_num - 1], paper_num, paper_id_full, meta)
+            # bibkey = anthology.pindex.create_bibkey(paper_node, vidx=anthology.venues)
+
+        # Ideally this would be here, but it requires a Paper object, which requires a Volume object, etc
+        # Just a little bit complicated
+        # make_simple_element("bibkey", "", parent=paper)
 
         paper_id = paper_node.attrib['id']
         if paper_id == '0':
@@ -848,7 +850,6 @@ def create_xml(
 )
 def main(ingestion_dir, pdfs_dir, attachments_dir, dry_run, anthology_dir, ingest_date):
     anthology_datadir = Path(sys.argv[0]).parent / ".." / "data"
-
     # anthology = Anthology(
     #     importdir=anthology_datadir, require_bibkeys=False
     # )


Test patch: