Repository: spack/spack

Issue:
incorrect intel-tbb sha256sums from #14783 

I think yesterday's commit #14783 broke the checksums for the recent
intel-tbb versions.

The commit added:

```
  version('2020.1', sha256='48d51c63b16787af54e1ee4aaf30042087f20564b4eecf9a032d5568bc2f0bf8')
  version('2020.0', sha256='8eed2377ac62e6ac10af5a8303ce861e4525ffe491a061b48e8fe094fc741ce9')
  version('2019.9', sha256='15652f5328cf00c576f065e5cd3eaf3317422fe82afb67a9bcec0dc065bd2abe')
```

But when I wget the tar files directly, I get a different sha256sum.

```
72cffaeac3b50b117c4e2279f9162308d35873b3e744aff5a088beff6f65c9af  2020_U1.tar.gz
db80f4f7abb95c2d08fe64abdc0a9250903e4c725f1c667ac517450de426023a  2020.tar.gz
15652f5328cf00c576f065e5cd3eaf3317422fe82afb67a9bcec0dc065bd2abe  2019_U9.tar.gz
```

So, 2019_U9 is correct, but the 2020 and 2020_U1 are not.

Also, the name of the 2020 tar file is `2020.tar.gz`, not
`2020_U0.tar.gz`.

I would just submit a PR to fix this, but this was part of a larger
commit that "updated" the versions of several intel packages.  I don't
use the other ones (just tbb), so I don't know if those sha hashes
need fixing or not.

```
M       var/spack/repos/builtin/packages/intel-daal/package.py
M       var/spack/repos/builtin/packages/intel-ipp/package.py
M       var/spack/repos/builtin/packages/intel-mkl-dnn/package.py
M       var/spack/repos/builtin/packages/intel-mkl/package.py
M       var/spack/repos/builtin/packages/intel-mpi/package.py
M       var/spack/repos/builtin/packages/intel-parallel-studio/package.py
M       var/spack/repos/builtin/packages/intel-pin/package.py
M       var/spack/repos/builtin/packages/intel-tbb/package.py
```

Could someone check this and see who has the right sha256sum?
And check the other packages.

Thanks.

@robert-mijakovic 


Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/intel-tbb/package.py b/var/spack/repos/builtin/packages/intel-tbb/package.py
--- a/var/spack/repos/builtin/packages/intel-tbb/package.py
+++ b/var/spack/repos/builtin/packages/intel-tbb/package.py
@@ -23,8 +23,8 @@ class IntelTbb(Package):
 
     # See url_for_version() below.
 
-    version('2020.1', sha256='48d51c63b16787af54e1ee4aaf30042087f20564b4eecf9a032d5568bc2f0bf8')
-    version('2020.0', sha256='8eed2377ac62e6ac10af5a8303ce861e4525ffe491a061b48e8fe094fc741ce9')
+    version('2020.1', sha256='72cffaeac3b50b117c4e2279f9162308d35873b3e744aff5a088beff6f65c9af')
+    version('2020',   sha256='db80f4f7abb95c2d08fe64abdc0a9250903e4c725f1c667ac517450de426023a')
     version('2019.9', sha256='15652f5328cf00c576f065e5cd3eaf3317422fe82afb67a9bcec0dc065bd2abe')
     version('2019.8', sha256='7b1fd8caea14be72ae4175896510bf99c809cd7031306a1917565e6de7382fba')
     version('2019.7', sha256='4204a93f4c0fd989fb6f79acae74feb02ee39725c93968773d9b6efeb75c7a6a')
@@ -102,6 +102,9 @@ class IntelTbb(Package):
     patch("tbb_cmakeConfig-2019.5.patch", level=0, when='@2019.5:')
     patch("tbb_cmakeConfig.patch", level=0, when='@2017.7:2019.4')
 
+    # Restore the debug targets.
+    patch("makefile-debug.patch", when="@2020:")
+
     # Some very old systems don't support transactional memory.
     patch("disable-tm.patch", when='~tm')
 


Test patch: