Repository: spack/spack

Issue:
Installation issue: catalyst
`spack install catalyst`

fails to run like:

```
==> Installing catalyst
==> Searching for binary cache of catalyst
==> Warning: No Spack mirrors are currently configured
==> No binary for catalyst found: installing from source
==> Fetching http://www.paraview.org/files/v5.6/ParaView-v5.6.0.tar.xz
######################################################################## 100.0%
==> Staging archive: /storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/ParaView-v5.6.0.tar.xz
==> Created stage in /storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6
python: can't open file '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0/Catalyst/catalyze.py': [Errno 2] No such file or directory
==> Error: CalledProcessError: Command '['python', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0/Catalyst/catalyze.py', '-r', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0', '-o', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/Catalyst-v5.6.0', '-i', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0/Catalyst/Editions/Base', '-i', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0/Catalyst/Editions/Essentials', '-i', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0/Catalyst/Editions/Extras', '-i', '/storage/users/wspear/bin/SPACK/spack-clean/var/spack/stage/catalyst-5.6.0-mqtecpxp4aghuyw6shftr2uf55rq2wo6/spack-src/ParaView-v5.6.0/Catalyst/Editions/Rendering-Base']' returned non-zero exit status 2

/storage/users/wspear/bin/SPACK/spack-clean/var/spack/repos/builtin/packages/catalyst/package.py:145, in do_stage:
        142
        143        if not os.path.isdir(catalyst_source_dir):
        144            os.mkdir(catalyst_source_dir)
  >>    145            subprocess.check_call(command)
        146            tty.msg("Generated catalyst source in %s" % self.stage.source_path)
        147        else:
        148            tty.msg("Already generated %s in %s" % (self.name,

```


Discussion:
@chuckatkins @danlipsa are listed as maintainers

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/catalyst/package.py b/var/spack/repos/builtin/packages/catalyst/package.py
--- a/var/spack/repos/builtin/packages/catalyst/package.py
+++ b/var/spack/repos/builtin/packages/catalyst/package.py
@@ -127,14 +127,14 @@ def do_stage(self, mirror_only=False):
         super(Catalyst, self).do_stage(mirror_only)
 
         # extract the catalyst part
-        paraview_dir = os.path.join(self.stage.source_path,
-                                    'ParaView-v' + str(self.version))
-        catalyst_script = os.path.join(paraview_dir, 'Catalyst', 'catalyze.py')
-        editions_dir = os.path.join(paraview_dir, 'Catalyst', 'Editions')
+        catalyst_script = os.path.join(self.stage.source_path, 'Catalyst',
+                                       'catalyze.py')
+        editions_dir = os.path.join(self.stage.source_path, 'Catalyst',
+                                    'Editions')
         catalyst_source_dir = os.path.abspath(self.root_cmakelists_dir)
 
         command = ['python', catalyst_script,
-                   '-r', paraview_dir,
+                   '-r', self.stage.source_path,
                    '-o', catalyst_source_dir]
 
         for edition in self.editions:


Test patch: