Repository: nvaccess/nvda

Issue:
Regular expression hotkey conflict in add dictionary entry dialog
When adding a dictionary entry (NVDA+N, P, D, then enter, then alt+a or select an entry and alt+e)

The replacement field can be accessed directly by pressing alt+r.

The regular expression field has "r" underlined, however, alt+r only goes to replacement.

Also in the add dictionary entry dialog, the underlines only appear visually when alt is pressed.  In the edit dictionary entry field, the appropriate letters are underlined all the time.

Both very minor issues.


Discussion:
Hi, Which pneumonic would you suggest? Thanks.

 

From: Quentin Christensen [mailto:notifications@github.com] 
Sent: Sunday, January 22, 2017 4:24 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] Regular expression hotkey conflict in add dictionary entry dialog (#6782)

 

When adding a dictionary entry (NVDA+N, P, D, then enter, then alt+a or select an entry and alt+e)

The replacement field can be accessed directly by pressing alt+r.

The regular expression field has "r" underlined, however, alt+r only goes to replacement.

Also in the add dictionary entry dialog, the underlines only appear visually when alt is pressed. In the edit dictionary entry field, the appropriate letters are underlined all the time.

Both very minor issues.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <https://github.com/nvaccess/nvda/issues/6782> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkI_HsNCzRWHkWj0TrzrrVRyxmCxVks5rU_M4gaJpZM4LqkB_> .


E would probably be the obvious choice, though I keep wanting to say x. :)

I'm the same.  Both options start with R and E.  To be honest, I've always
thought, once you can't use the first letter of something, it's going to be
hard to remember.  E would probably work here though as it's the second
letter and the first letter of the second word (expression).  I can see the
argument for X as well though.


--
22 Point

Check out our first app, RapiTap! - Tap targets fast & avoid decoys:
Adrenaline pumping, Challenging, Accessible!
https://play.google.com/store/apps/details?id=au.com.twentytwopoint.rapitap
Free trial:
https://play.google.com/store/apps/details?id=au.com.twentytwopoint.rapitapfree

Web: http://www.22point.com.au
Facebook: https://www.facebook.com/22Point
Twitter: https://twitter.com/22PointApps

On 23 January 2017 at 11:47, James Teh <notifications@github.com> wrote:

> E would probably be the obvious choice, though I keep wanting to say x. :)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/nvaccess/nvda/issues/6782#issuecomment-274374231>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/APKmCM3VYFmO3bxPsE5zC3x8GjsHafw1ks5rU_izgaJpZM4LqkB_>
> .
>

@Qchristensen, can you confirm whether the second issue still exists for you? Seems okay with the latest Master.
[**@Qchristensen**](https://github.com/Qchristensen) commented:
> Also in the add dictionary entry dialog, the underlines only appear visually when alt is pressed.  In the edit dictionary entry field, the appropriate letters are underlined all the time.

Do we agree on the pneumonic for Regular expression to be "E"? (For the "E" in expression)
With 2017.3 at least, the underline issue seems resolved.  Re the pneumonic, I'm happy with "E".

Resolving patch:
diff --git a/source/gui/settingsDialogs.py b/source/gui/settingsDialogs.py
--- a/source/gui/settingsDialogs.py
+++ b/source/gui/settingsDialogs.py
@@ -1,7 +1,7 @@
 # -*- coding: UTF-8 -*-
 #settingsDialogs.py
 #A part of NonVisual Desktop Access (NVDA)
-#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Heiko Folkerts, Zahari Yurukov, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager
+#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Heiko Folkerts, Zahari Yurukov, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger
 #This file is covered by the GNU General Public License.
 #See the file COPYING for more details.
 
@@ -1352,7 +1352,7 @@ class DictionaryEntryDialog(wx.Dialog):
 		# Translators: This is a label for an Entry Type radio button in add dictionary entry dialog.
 		speechDictHandler.ENTRY_TYPE_WORD: _("Whole &word"),
 		# Translators: This is a label for an Entry Type radio button in add dictionary entry dialog.
-		speechDictHandler.ENTRY_TYPE_REGEXP: _("&Regular expression")
+		speechDictHandler.ENTRY_TYPE_REGEXP: _("Regular &expression")
 	}
 	TYPE_LABELS_ORDERING = (speechDictHandler.ENTRY_TYPE_ANYWHERE, speechDictHandler.ENTRY_TYPE_WORD, speechDictHandler.ENTRY_TYPE_REGEXP)
 


Test patch: