Repository: spack/spack

Issue:
netCDF-C bump to 4.7.2
Hi,
building netCDF 4.7.0 I got this bug: https://github.com/Unidata/netcdf-c/issues/1408.
Forcing spack to build the 4.7.2 version, solved the problem for me.
So I would like to ask if it is possible to bump netCDF to 4.7.2.

Thanks

---

### Steps to reproduce the issue

```console
$ spack install netcdf
```

### Platform and user environment

Please report your OS here:
```commandline
$ uname -a 
Linux vmTest01 3.10.0-1062.4.1.el7.x86_64 #1 SMP Fri Oct 18 17:15:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -d
CentOS 7.7
``` 



Discussion:
Of course! Want to submit a pull request?
I do not have a modification ready.
Can you do it?

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/netcdf-cxx4/package.py b/var/spack/repos/builtin/packages/netcdf-cxx4/package.py
--- a/var/spack/repos/builtin/packages/netcdf-cxx4/package.py
+++ b/var/spack/repos/builtin/packages/netcdf-cxx4/package.py
@@ -9,9 +9,10 @@
 class NetcdfCxx4(AutotoolsPackage):
     """C++ interface for NetCDF4"""
 
-    homepage = "http://www.unidata.ucar.edu/software/netcdf"
-    url      = "https://www.github.com/unidata/netcdf-cxx4/tarball/v4.3.0"
+    homepage = "https://www.unidata.ucar.edu/software/netcdf"
+    url      = "https://www.unidata.ucar.edu/downloads/netcdf/ftp/netcdf-cxx4-4.3.1.tar.gz"
 
+    version('4.3.1', sha256='6a1189a181eed043b5859e15d5c080c30d0e107406fbb212c8fb9814e90f3445')
     version('4.3.0', sha256='f4766d5a19c91093be80ddd2eaf1fbbd8d203854cc69fc73d2ad293b099ac799')
 
     # Usually the configure automatically inserts the pic flags, but we can
diff --git a/var/spack/repos/builtin/packages/netcdf-fortran/package.py b/var/spack/repos/builtin/packages/netcdf-fortran/package.py
--- a/var/spack/repos/builtin/packages/netcdf-fortran/package.py
+++ b/var/spack/repos/builtin/packages/netcdf-fortran/package.py
@@ -9,9 +9,10 @@
 class NetcdfFortran(AutotoolsPackage):
     """Fortran interface for NetCDF4"""
 
-    homepage = "http://www.unidata.ucar.edu/software/netcdf"
-    url      = "http://www.unidata.ucar.edu/downloads/netcdf/ftp/netcdf-fortran-4.4.3.tar.gz"
+    homepage = "https://www.unidata.ucar.edu/software/netcdf"
+    url      = "https://www.unidata.ucar.edu/downloads/netcdf/ftp/netcdf-fortran-4.5.2.tar.gz"
 
+    version('4.5.2', sha256='b959937d7d9045184e9d2040a915d94a7f4d0185f4a9dceb8f08c94b0c3304aa')
     version('4.4.5', sha256='2467536ce29daea348c736476aa8e684c075d2f6cab12f3361885cb6905717b8')
     version('4.4.4', sha256='b2d395175f8d283e68c8be516e231a96b191ade67ad0caafaf7fa01b1e6b5d75')
     version('4.4.3', sha256='330373aa163d5931e475b5e83da5c1ad041e855185f24e6a8b85d73b48d6cda9')
diff --git a/var/spack/repos/builtin/packages/netcdf/package.py b/var/spack/repos/builtin/packages/netcdf/package.py
--- a/var/spack/repos/builtin/packages/netcdf/package.py
+++ b/var/spack/repos/builtin/packages/netcdf/package.py
@@ -23,7 +23,7 @@ class Netcdf(AutotoolsPackage):
 
     homepage = "http://www.unidata.ucar.edu/software/netcdf"
     git      = "https://github.com/Unidata/netcdf-c"
-    url      = "https://www.gfd-dennou.org/arch/netcdf/unidata-mirror/netcdf-c-4.6.3.tar.gz"
+    url      = "https://www.gfd-dennou.org/arch/netcdf/unidata-mirror/netcdf-c-4.7.2.tar.gz"
 
     def url_for_version(self, version):
         if version >= Version('4.6.2'):
@@ -34,6 +34,8 @@ def url_for_version(self, version):
         return url.format(version.dotted)
 
     version('master', branch='master')
+    version('4.7.2',   sha256='b751cc1f314ac8357df2e0a1bacf35a624df26fe90981d3ad3fa85a5bbd8989a')
+    version('4.7.1',   sha256='5c537c585773e575a16b28c3973b9608a98fdc4cf7c42893aa5223024e0001fc')
     version('4.7.0',   sha256='a512d2b4828c6177dd4b96791c4163e4e06e6bfc7123bebfbfe01762d777d1cb')
     version('4.6.3',   sha256='335fdf16d7531f430ad75e732ed1a9a3fc83ad3ef91fb33a70119a555dd5415c')
     version('4.6.2',   sha256='c37525981167b3cd82d32e1afa3022afb94e59287db5f116c57f5ed4d9c6a638')


Test patch: