Repository: great-expectations/great_expectations

Issue:
Use cleaner solution for non-truncating division in python 2
Prefer `from __future__ import division` to `1.*x/y`


Discussion:
Done inline during improve_partitions push.

Resolving patch:
diff --git a/great_expectations/cli/suite.py b/great_expectations/cli/suite.py
--- a/great_expectations/cli/suite.py
+++ b/great_expectations/cli/suite.py
@@ -235,7 +235,6 @@ def suite_demo(suite, directory, view):
 
 @suite.command(name="new")
 @click.option("--suite", "-es", default=None, help="Expectation suite name.")
-@click.option("--empty", "empty", flag_value=True, help="Create an empty suite.")
 @click.option(
     "--directory",
     "-d",
@@ -248,40 +247,23 @@ def suite_demo(suite, directory, view):
     help="By default launch jupyter notebooks unless you specify the --no-jupyter flag",
     default=True,
 )
-@click.option(
-    "--view/--no-view",
-    help="By default open in browser unless you specify the --no-view flag",
-    default=True,
-)
 @click.option(
     "--batch-kwargs",
     default=None,
     help="Additional keyword arguments to be provided to get_batch when loading the data asset. Must be a valid JSON dictionary",
 )
-@mark.cli_as_deprecation(
-    """<yellow>In the next major release:
-  - `suite new` will create an empty suite and will no longer have the --empty flag
-  - `suite new` will no longer have a --view/no-view flag. Data Docs will not be opened.
-  - The current behavior of creating a demo suite will transition to the new command `suite demo` which can be used now.
-  - We also suggest using the `suite scaffold` command for faster suite creation.
-</yellow>"""
-)
-def suite_new(suite, directory, empty, jupyter, view, batch_kwargs):
-    # TODO update docstring on next major release
+def suite_new(suite, directory, jupyter, batch_kwargs):
     """
-    Create a new Expectation Suite.
+    Create a new empty Expectation Suite.
 
-    Great Expectations will choose a couple of columns and generate expectations about them
-    to demonstrate some examples of assertions you can make about your data.
-
-    If you wish to skip the examples, add the `--empty` flag.
+    Edit in jupyter notebooks, or skip with the --no-jupyter flag
     """
     _suite_new(
         suite=suite,
         directory=directory,
-        empty=empty,
+        empty=True,
         jupyter=jupyter,
-        view=view,
+        view=False,
         batch_kwargs=batch_kwargs,
         usage_event="cli.suite.new",
     )


Test patch:
diff --git a/tests/cli/test_suite.py b/tests/cli/test_suite.py
--- a/tests/cli/test_suite.py
+++ b/tests/cli/test_suite.py
@@ -21,7 +21,7 @@ def test_suite_help_output(caplog):
   demo      Create a new demo Expectation Suite.
   edit      Generate a Jupyter notebook for editing an existing Expectation...
   list      Lists available Expectation Suites.
-  new       Create a new Expectation Suite.
+  new       Create a new empty Expectation Suite.
   scaffold  Scaffold a new Expectation Suite."""
         in result.stdout
     )
@@ -215,10 +215,9 @@ def test_suite_new_creates_empty_suite(
     os.chdir(root_dir)
     runner = CliRunner(mix_stderr=False)
     csv = os.path.join(filesystem_csv_2, "f1.csv")
-    # TODO this test must be updated to remove the --empty flag in the next major release
     result = runner.invoke(
         cli,
-        ["suite", "new", "-d", root_dir, "--empty", "--suite", "foo"],
+        ["suite", "new", "-d", root_dir, "--suite", "foo"],
         input=f"{csv}\n",
         catch_exceptions=False,
     )
@@ -300,10 +299,9 @@ def test_suite_new_empty_with_no_jupyter(
     root_dir = data_context_parameterized_expectation_suite.root_directory
     runner = CliRunner(mix_stderr=False)
     csv = os.path.join(filesystem_csv_2, "f1.csv")
-    # TODO this test must be updated to remove the --empty flag in the next major release
     result = runner.invoke(
         cli,
-        ["suite", "new", "-d", root_dir, "--empty", "--suite", "foo", "--no-jupyter"],
+        ["suite", "new", "-d", root_dir, "--suite", "foo", "--no-jupyter"],
         input=f"{csv}\n",
         catch_exceptions=False,
     )