Repository: great-expectations/great_expectations

Issue:
Use cleaner solution for non-truncating division in python 2
Prefer `from __future__ import division` to `1.*x/y`


Discussion:
Done inline during improve_partitions push.

Resolving patch:
diff --git a/contrib/experimental/great_expectations_experimental/expectations/expect_table_linear_feature_importances_to_be.py b/contrib/experimental/great_expectations_experimental/expectations/expect_table_linear_feature_importances_to_be.py
--- a/contrib/experimental/great_expectations_experimental/expectations/expect_table_linear_feature_importances_to_be.py
+++ b/contrib/experimental/great_expectations_experimental/expectations/expect_table_linear_feature_importances_to_be.py
@@ -117,6 +117,7 @@ class ExpectTableLinearFeatureImportancesToBe(TableExpectation):
     library_metadata = {
         "tags": ["ai/ml", "fair-ai", "hackathon-22"],
         "contributors": ["@austiezr"],
+        "requirements": ["sklearn"],
     }
 
     metric_dependencies = ("table.modeling.linear.feature_importances",)


Test patch:
diff --git a/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_table_columns_to_be_unique.py b/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_table_columns_to_be_unique.py
--- a/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_table_columns_to_be_unique.py
+++ b/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_table_columns_to_be_unique.py
@@ -52,27 +52,27 @@ def _pandas(
 
         return unique_columns
 
-    @metric_value(engine=SqlAlchemyExecutionEngine)
-    def _sqlalchemy(
-        cls,
-        execution_engine,
-        metric_domain_kwargs,
-        metric_value_kwargs,
-        metrics,
-        runtime_configuration,
-    ):
-        raise NotImplementedError
-
-    @metric_value(engine=SparkDFExecutionEngine)
-    def _spark(
-        cls,
-        execution_engine,
-        metric_domain_kwargs,
-        metric_value_kwargs,
-        metrics,
-        runtime_configuration,
-    ):
-        raise NotImplementedError
+    # @metric_value(engine=SqlAlchemyExecutionEngine)
+    # def _sqlalchemy(
+    #     cls,
+    #     execution_engine,
+    #     metric_domain_kwargs,
+    #     metric_value_kwargs,
+    #     metrics,
+    #     runtime_configuration,
+    # ):
+    #     raise NotImplementedError
+    #
+    # @metric_value(engine=SparkDFExecutionEngine)
+    # def _spark(
+    #     cls,
+    #     execution_engine,
+    #     metric_domain_kwargs,
+    #     metric_value_kwargs,
+    #     metrics,
+    #     runtime_configuration,
+    # ):
+    #     raise NotImplementedError
 
     @classmethod
     def _get_evaluation_dependencies(
diff --git a/tests/integration/test_script_runner.py b/tests/integration/test_script_runner.py
--- a/tests/integration/test_script_runner.py
+++ b/tests/integration/test_script_runner.py
@@ -242,6 +242,10 @@ class IntegrationTestFixture:
         name="expect_column_values_to_equal_three",
         user_flow_script="tests/integration/docusaurus/expectations/creating_custom_expectations/expect_column_values_to_equal_three.py",
     ),
+    IntegrationTestFixture(
+        name="expect_table_columns_to_be_unique",
+        user_flow_script="tests/integration/docusaurus/expectations/creating_custom_expectations/expect_table_columns_to_be_unique.py",
+    ),
 ]