Repository: kubeflow/pipelines

Issue:
Support Azure authentication for pipeline ops
Pipeline authors can currently authenticate against GCP by adding a ".apply(gcp.use_gcp_secret('user-gcp-sa'))" suffix to their ops. This makes the GCP secret provisioned during kubeflow setup available to the op container.

However there is no way to do this on Azure


Discussion:

Resolving patch:
diff --git a/sdk/python/kfp/azure.py b/sdk/python/kfp/azure.py
new file mode 100644
--- /dev/null
+++ b/sdk/python/kfp/azure.py
@@ -0,0 +1,75 @@
+# Copyright 2019 The Kubeflow Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+def use_azure_secret(secret_name='azcreds'):
+    """An operator that configures the container to use Azure user credentials.
+
+        The azcreds secret is created as part of the kubeflow deployment that
+        stores the client ID and secrets for the kubeflow azure service principal.
+
+        With this service principal, the container has a range of Azure APIs to
+        access to. 
+    """
+
+    def _use_azure_secret(task):
+        from kubernetes import client as k8s_client
+        return (
+            task            
+                .add_env_variable(
+                    k8s_client.V1EnvVar(
+                        name='AZ_SUBSCRIPTION_ID',
+                        value_from=k8s_client.V1EnvVarSource(
+                            secret_key_ref=k8s_client.V1SecretKeySelector(
+                                name=secret_name,
+                                key='AZ_SUBSCRIPTION_ID'
+                            )
+                        )
+                    )
+                )
+                .add_env_variable(
+                    k8s_client.V1EnvVar(
+                        name='AZ_TENANT_ID',
+                        value_from=k8s_client.V1EnvVarSource(
+                            secret_key_ref=k8s_client.V1SecretKeySelector(
+                                name=secret_name,
+                                key='AZ_TENANT_ID'
+                            )
+                        )
+                    )
+                )
+                .add_env_variable(
+                    k8s_client.V1EnvVar(
+                        name='AZ_CLIENT_ID',
+                        value_from=k8s_client.V1EnvVarSource(
+                            secret_key_ref=k8s_client.V1SecretKeySelector(
+                                name=secret_name,
+                                key='AZ_CLIENT_ID'
+                            )
+                        )
+                    )
+                )
+                .add_env_variable(
+                    k8s_client.V1EnvVar(
+                        name='AZ_CLIENT_SECRET',
+                        value_from=k8s_client.V1EnvVarSource(
+                            secret_key_ref=k8s_client.V1SecretKeySelector(
+                                name=secret_name,
+                                key='AZ_CLIENT_SECRET'
+                            )
+                        )
+                    )
+                )
+        )
+    
+    return _use_azure_secret


Test patch:
diff --git a/sdk/python/tests/dsl/test_azure_extensions.py b/sdk/python/tests/dsl/test_azure_extensions.py
new file mode 100644
--- /dev/null
+++ b/sdk/python/tests/dsl/test_azure_extensions.py
@@ -0,0 +1,40 @@
+# Copyright 2019 The Kubeflow Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from kfp.dsl import Pipeline, ContainerOp
+from kfp.azure import use_azure_secret
+import unittest
+import inspect
+
+class AzExtensionTests(unittest.TestCase):
+    def test_default_secret_name(self):
+        spec = inspect.getfullargspec(use_azure_secret)
+        assert len(spec.defaults) == 1
+        assert spec.defaults[0] == 'azcreds'
+
+    def test_use_azure_secret(self):
+        with Pipeline('somename') as p:
+            op1 = ContainerOp(name='op1', image='image')
+            op1 = op1.apply(use_azure_secret('foo'))
+            assert len(op1.env_variables) == 4
+            
+            index = 0
+            for expected in ['AZ_SUBSCRIPTION_ID', 'AZ_TENANT_ID', 'AZ_CLIENT_ID', 'AZ_CLIENT_SECRET']:
+                assert op1.env_variables[index].name == expected
+                assert op1.env_variables[index].value_from.secret_key_ref.name == 'foo'
+                assert op1.env_variables[index].value_from.secret_key_ref.key == expected
+                index += 1
+
+if __name__ == '__main__':
+    unittest.main()