Repository: spyder-ide/spyder

Issue:
Disabled toolbars get enabled when restarting Spyder
<!--- **PLEASE READ:** When submitting here, please ensure you've completed the following checklist and checked the boxes to confirm. Issue reports without it may be closed. Thanks! --->

### Issue Report Checklist

* [x] Searched the [issues page](https://github.com/spyder-ide/spyder/issues?q=is%3Aissue) for similar reports
* [x] Read the relevant sections of the [Spyder Troubleshooting Guide](https://github.com/spyder-ide/spyder/wiki/Troubleshooting-Guide-and-FAQ) and followed its advice
* [x] Reproduced the issue after updating with ``conda update spyder`` (or ``pip``, if not using Anaconda)
* [ ] Could not reproduce inside ``jupyter qtconsole`` (if console-related)
* [x] Tried basic troubleshooting (if a bug/error)
    * [x] Restarted Spyder
    * [x] Reset preferences with ``spyder --reset``
    * [ ] Reinstalled the latest version of [Anaconda](https://www.anaconda.com/download/)
    * [ ] Tried the other applicable steps from the Troubleshooting Guide
* [ ] Completed the **Problem Description**, **Steps to Reproduce** and **Version** sections below


## Problem Description

With spyder 5.2.0, disabled toolbars get re-enabled when restarting (no errors are thrown). This did not happen in previous versions.

### What steps reproduce the problem?

1. Disable 1 or more toolbar(s)
2. Quit spyder
3. Start spyder
4. All toolbars are enabled

### What is the expected output? What do you see instead?

Disabled toolbars should stay disabled.

## Versions
<!--- You can get this information from Help > About Spyder...
or (if Spyder won't launch) the "conda list" command
from the Anaconda Prompt/Terminal/command line. --->

* Spyder version: 5.2.0 None
* Python version: 3.8.12 64-bit
* Qt version: 5.12.9
* PyQt5 version: 5.12.3
* Operating System: Darwin 20.6.0

### Dependencies
<!--- Please go to the menu entry Help > Dependencies,
press the Copy to clipboard button and paste below --->

```

# Mandatory:
applaunchservices >=0.1.7     :  0.2.1 (OK)
atomicwrites >=1.2.0          :  1.4.0 (OK)
chardet >=2.0.0               :  4.0.0 (OK)
cloudpickle >=0.5.0           :  2.0.0 (OK)
cookiecutter >=1.6.0          :  1.7.3 (OK)
diff_match_patch >=20181111   :  20200713 (OK)
intervaltree >=3.0.2          :  3.0.2 (OK)
IPython >=7.6.0               :  7.30.0 (OK)
jedi >=0.17.2;<0.19.0         :  0.18.1 (OK)
jellyfish >=0.7               :  0.8.9 (OK)
jsonschema >=3.2.0            :  4.2.1 (OK)
keyring >=17.0.0              :  23.4.0 (OK)
nbconvert >=4.0               :  6.3.0 (OK)
numpydoc >=0.6.0              :  1.1.0 (OK)
parso >=0.7.0;<0.9.0          :  0.8.3 (OK)
pexpect >=4.4.0               :  4.8.0 (OK)
pickleshare >=0.4             :  0.7.5 (OK)
psutil >=5.3                  :  5.8.0 (OK)
pygments >=2.0                :  2.10.0 (OK)
pylint >=2.5.0                :  2.12.1 (OK)
pyls_spyder >=0.4.0           :  0.4.0 (OK)
pylsp >=1.3.1;<1.4.0          :  1.3.2 (OK)
pylsp_black >=1.0.0           :  None (OK)
qdarkstyle =3.0.2             :  3.0.2 (OK)
qstylizer >=0.1.10            :  0.2.1 (OK)
qtawesome >=1.0.2             :  1.1.1 (OK)
qtconsole >=5.2.1;<5.3.0      :  5.2.1 (OK)
qtpy >=1.5.0                  :  1.11.2 (OK)
rtree >=0.9.7                 :  0.9.7 (OK)
setuptools >=49.6.0           :  59.4.0 (OK)
sphinx >=0.6.6                :  4.3.1 (OK)
spyder_kernels >=2.2.0;<2.3.0 :  2.2.0 (OK)
textdistance >=4.2.0          :  4.2.2 (OK)
three_merge >=0.1.1           :  0.1.1 (OK)
watchdog >=0.10.3             :  2.1.6 (OK)
zmq >=17                      :  22.3.0 (OK)

# Optional:
cython >=0.21                 :  None (OK)
matplotlib >=2.0.0            :  3.5.0 (OK)
numpy >=1.7                   :  1.21.4 (OK)
pandas >=1.1.1                :  1.3.4 (OK)
scipy >=0.17.0                :  None (OK)
sympy >=0.7.3                 :  None (OK)
```



Discussion:
Hi @remisalmon thank you for the feedback! I was able to reproduce this. Will check this in a future release 👍🏼 

Resolving patch:
diff --git a/spyder/plugins/toolbar/container.py b/spyder/plugins/toolbar/container.py
--- a/spyder/plugins/toolbar/container.py
+++ b/spyder/plugins/toolbar/container.py
@@ -128,7 +128,8 @@ def setup(self):
         self.toolbars_menu.setObjectName('checkbox-padding')
 
     def update_actions(self):
-        if self.get_conf("toolbars_visible"):
+        visible_toolbars = self.get_conf("toolbars_visible")
+        if visible_toolbars:
             text = _("Hide toolbars")
             tip = _("Hide toolbars")
         else:
@@ -137,6 +138,7 @@ def update_actions(self):
 
         self.show_toolbars_action.setText(text)
         self.show_toolbars_action.setToolTip(tip)
+        self.toolbars_menu.setEnabled(visible_toolbars)
 
     # ---- Public API
     # ------------------------------------------------------------------------
@@ -328,9 +330,16 @@ def get_application_toolbars(self):
         """
         return self._toolbarslist
 
+    def save_last_visible_toolbars(self):
+        """Save the last visible toolbars state in our preferences."""
+        if self.get_conf("toolbars_visible"):
+            self._get_visible_toolbars()
+        self._save_visible_toolbars()
+
     def load_last_visible_toolbars(self):
-        """Load the last visible toolbars from our preferences.."""
+        """Load the last visible toolbars from our preferences."""
         toolbars_names = self.get_conf('last_visible_toolbars')
+        toolbars_visible = self.get_conf("toolbars_visible")
 
         if toolbars_names:
             toolbars_dict = {}
@@ -347,7 +356,7 @@ def load_last_visible_toolbars(self):
             self._get_visible_toolbars()
 
         for toolbar in self._visible_toolbars:
-            toolbar.setVisible(True)
+            toolbar.setVisible(toolbars_visible)
 
         self.update_actions()
 
diff --git a/spyder/plugins/toolbar/plugin.py b/spyder/plugins/toolbar/plugin.py
--- a/spyder/plugins/toolbar/plugin.py
+++ b/spyder/plugins/toolbar/plugin.py
@@ -118,7 +118,7 @@ def on_mainwindow_visible(self):
 
     def on_close(self, _unused):
         container = self.get_container()
-        container._save_visible_toolbars()
+        container.save_last_visible_toolbars()
         for toolbar in container._visible_toolbars:
             toolbar.setVisible(False)
 


Test patch: