Repository: scikit-image/scikit-image

Issue:
rename `feret_diameter` -> `max_feret_diameter` ?
## Description

Sorry, I meant to comment on this while it was still an open PR, but then forgot to do so.
As it has not been in a release, maybe it is not too late to rename the new region property
`feret_diameter` to `max_feret_diameter`. 
Tagging @emmanuelle as she added it.

The simple reason being is that sometimes the minimum feret diameter is of interest and
it would be nice to be able to have naming consistency so that a `min_feret_diameter` property
can get added later.
  


Discussion:
A good point! I'd be 👍 on this. (And yes it's totally fine to change this pre-release.)

Resolving patch:
diff --git a/skimage/measure/_regionprops.py b/skimage/measure/_regionprops.py
--- a/skimage/measure/_regionprops.py
+++ b/skimage/measure/_regionprops.py
@@ -36,7 +36,7 @@
     'EulerNumber': 'euler_number',
     'Extent': 'extent',
     # 'Extrema',
-    'FeretDiameter': 'feret_diameter',
+    'FeretDiameterMax': 'feret_diameter_max',
     'FilledArea': 'filled_area',
     'FilledImage': 'filled_image',
     'HuMoments': 'moments_hu',
@@ -86,7 +86,7 @@
     'equivalent_diameter': float,
     'euler_number': int,
     'extent': float,
-    'feret_diameter': float,
+    'feret_diameter_max': float,
     'filled_area': int,
     'filled_image': object,
     'moments_hu': float,
@@ -234,7 +234,7 @@ def extent(self):
         return self.area / self.image.size
 
     @property
-    def feret_diameter(self):
+    def feret_diameter_max(self):
         identity_convex_hull = np.pad(self.convex_image,
                                       2, mode='constant', constant_values=0)
         if self._ndim == 2:
@@ -736,7 +736,7 @@ def regionprops(label_image, intensity_image=None, cache=True,
     **extent** : float
         Ratio of pixels in the region to pixels in the total bounding box.
         Computed as ``area / (rows * cols)``
-    **feret_diameter** : float
+    **feret_diameter_max** : float
         Maximum Feret's diameter computed as the longest distance between
         points around a region's convex hull contour as determined by
         ``find_contours``. [5]_


Test patch:
diff --git a/skimage/measure/tests/test_regionprops.py b/skimage/measure/tests/test_regionprops.py
--- a/skimage/measure/tests/test_regionprops.py
+++ b/skimage/measure/tests/test_regionprops.py
@@ -73,24 +73,24 @@ def test_ndim():
         regionprops(np.zeros((10, 10, 10, 2), dtype=np.int))
 
 
-def test_feret_diameter():
+def test_feret_diameter_max():
     # comparator result is based on SAMPLE from manually-inspected computations
     comparator_result = 18
-    test_result = regionprops(SAMPLE)[0].feret_diameter
+    test_result = regionprops(SAMPLE)[0].feret_diameter_max
     assert np.abs(test_result - comparator_result) < 1
-    # square, test that Feret diameter is sqrt(2) * square side
+    # square, test that maximum Feret diameter is sqrt(2) * square side
     img = np.zeros((20, 20), dtype=np.uint8)
     img[2:-2, 2:-2] = 1
-    feret_diameter = regionprops(img)[0].feret_diameter
-    assert np.abs(feret_diameter - 16 * np.sqrt(2)) < 1
+    feret_diameter_max = regionprops(img)[0].feret_diameter_max
+    assert np.abs(feret_diameter_max - 16 * np.sqrt(2)) < 1
 
 
-def test_feret_diameter_3d():
+def test_feret_diameter_max_3d():
     img = np.zeros((20, 20), dtype=np.uint8)
     img[2:-2, 2:-2] = 1
     img_3d = np.dstack((img,) * 3)
-    feret_diameter = regionprops(img_3d)[0].feret_diameter
-    assert np.abs(feret_diameter - 16 * np.sqrt(2)) < 1
+    feret_diameter_max = regionprops(img_3d)[0].feret_diameter_max
+    assert np.abs(feret_diameter_max - 16 * np.sqrt(2)) < 1
 
 
 def test_area():