Repository: jupyterhub/jupyterhub

Issue:
Documentation issue: c.JupyterHub.port is deprecated but not indicated in doc
<!-- Thank you for contributing. These HTML comments will not render in the issue, but you can delete them once you've read them if you prefer! -->

### Bug description

<!-- Use this section to clearly and concisely describe the bug. -->

In the docs in url: https://jupyterhub.readthedocs.io/en/stable/getting-started/networking-basics.html
it states that: 
```
Or by placing the following lines in a configuration file, jupyterhub_config.py:
c.JupyterHub.ip = '192.168.1.2'
c.JupyterHub.port = 443
```
But in the latest Jupyterhub 2.x.x the generated config file states the above property is deprecated:
```
## The public facing port of the proxy.
#
#          This is the port on which the proxy will listen.
#          This is the only port through which JupyterHub
#          should be accessed by users.
#
#          .. deprecated: 0.9
#              Use JupyterHub.bind_url
#  Default: 8000
# c.JupyterHub.port = 8000
```

#### Expected behaviour

<!-- Tell us what you thought would happen. -->
The readthedocs document should mention the non-deprecated property not the deprecated property.





Discussion:
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
<br>If you haven't done so already, check out [Jupyter's Code of Conduct](https://github.com/jupyter/governance/blob/master/conduct/code_of_conduct.md). Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
![welcome](https://raw.githubusercontent.com/jupyterhub/.github/master/images/welcome.jpg)
You can meet the other [Jovyans](https://jupyter.readthedocs.io/en/latest/community/content-community.html?highlight=jovyan#what-is-a-jovyan) by joining our [Discourse forum](http://discourse.jupyter.org/). There is also an intro thread there where you can stop by and say Hi! :wave:
<br>Welcome to the Jupyter community! :tada:

Thanks for catching and reporting this @ebebpl! The docs should be indeed updated with latest info.

A PR to fix this issue would be very appreciated and a great [first JupyterHub contribution](https://github.com/jupyterhub/jupyterhub/blob/main/CONTRIBUTING.md) ✨ 
The source of that docs page is this file https://github.com/jupyterhub/jupyterhub/blob/main/docs/source/getting-started/networking-basics.md

Hi,
I would like to work on this issue.
Thanks @hsadia538 you can work on it.
I have submitted a PR that closes this issue #4042. Please review and accept.
Hey @ebebpl, if no one is working on this issue at the moment, could I give it a try?😊
@BhavyaT-135 you can go ahead if no pending fix or PRs.
Hi @ebebpl, I have created a pull request addressing the mentioned issue. Kindly take a look and suggest any changes if required. 😊 
Hey, @ebebpl I would like to work on this issue, can you please help me to understand this issue and assign it to me?
@akashthedeveloper this issue already fixed by another user so no longer need further work.
Thanks, @ebebpl for clarifying but can you please close this issue if it is solved?
@akashthedeveloper The pull requests are open, it will be closed when they have been reviewed and merged. You can see the links on the right hand side:

![Screen Shot 2022-10-10 at 09 26 04](https://user-images.githubusercontent.com/151929/194816395-e6211599-0d53-429e-b484-b13112b359be.png)

and linked in the conversation:

![Screen Shot 2022-10-10 at 09 26 35](https://user-images.githubusercontent.com/151929/194816452-99ab924a-0748-48aa-a6ef-a374cee85447.png)


hi @ebebpl i would like to work on this issue
@Achele please read earlier comments this is already done by others.
my bad,  @ebebpl thanks for the clarification.

Resolving patch:
diff --git a/jupyterhub/app.py b/jupyterhub/app.py
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -624,9 +624,6 @@ def _template_paths_default(self):
         This is the address on which the proxy will listen. The default is to
         listen on all interfaces. This is the only address through which JupyterHub
         should be accessed by users.
-
-        .. deprecated: 0.9
-            Use JupyterHub.bind_url
         """,
     ).tag(config=True)
 
@@ -637,9 +634,6 @@ def _template_paths_default(self):
         This is the port on which the proxy will listen.
         This is the only port through which JupyterHub
         should be accessed by users.
-
-        .. deprecated: 0.9
-            Use JupyterHub.bind_url
         """,
     ).tag(config=True)
 
@@ -649,9 +643,6 @@ def _template_paths_default(self):
 
         Add this to the beginning of all JupyterHub URLs.
         Use base_url to run JupyterHub within an existing website.
-
-        .. deprecated: 0.9
-            Use JupyterHub.bind_url
         """,
     ).tag(config=True)
 
@@ -677,9 +668,7 @@ def _url_part_changed(self, change):
             if self.bind_url != self._bind_url_default():
                 self.log.warning(
                     "Both bind_url and ip/port/base_url have been configured. "
-                    "JupyterHub.ip, JupyterHub.port, JupyterHub.base_url are"
-                    " deprecated in JupyterHub 0.9,"
-                    " please use JupyterHub.bind_url instead."
+                    " please use just one or the other."
                 )
             self.bind_url = bind_url
 


Test patch: