Repository: ansible-collections/community.general

Issue:
`pacman --sync --sysupgrade` broken
### Summary

[This commit](https://github.com/ansible-collections/community.general/commit/1580f3c2b4876aeb06a0c785a14c5a4e057e843e#diff-ba1a07866081b3bf3a75e76b1c3154a4f9ca26e9a39915b8f491f0a5922f8f50R413) introduced a `-` where none should be. See [here](https://archlinux.org/pacman/pacman.8.html)



### Issue Type

Bug Report

### Component Name

pacman

### Ansible Version

```console (paste below)
$ ansible --version
ansible [core 2.12.2]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/marcus/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.10/site-packages/ansible
  ansible collection location = /home/marcus/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.10.2 (main, Jan 15 2022, 19:56:27) [GCC 11.1.0]
  jinja version = 3.0.3
  libyaml = True

```


### Community.general Version

```console (paste below)
$ ansible-galaxy collection list community.general
# /usr/lib/python3.10/site-packages/ansible_collections
Collection        Version
----------------- -------
community.general 4.4.0

```


### Configuration

```console (paste below)
$ ansible-config dump --only-changed

```


### OS / Environment

archlinux

### Steps to Reproduce

<!--- Paste example playbooks or commands between quotes below -->
```yaml (paste below)
How to reproduce:

- hosts: all
  tasks:
  - name: pacman upgrade
    pacman:
      upgrade: yes
```


### Expected Results

I expected my archlinux machines to be upgraded.

### Actual Results

```console (paste below)
fatal: [example.com]: FAILED! => {"attempts": 10, "changed": false, "msg": "Could not upgrade", "packages": ["python-pyparsing", "expat", "bind", "libxml2", "mariadb-libs", "tree"], "stderr": "/usr/bin/pacman: unrecognized option '--sys-upgrade'\n", "stderr_lines": ["/usr/bin/pacman: unrecognized option '--sys-upgrade'"]}

```


### Code of Conduct

- [X] I agree to follow the Ansible Code of Conduct


Discussion:
Files identified in the description:
* [`plugins/modules/packaging/os/pacman.py`](https://github.com/ansible-collections/community.general/blob/main/plugins/modules/packaging/os/pacman.py)

If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.

[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
cc @indrajitr @tchernomax
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: notify --->
CC @jraby

Another reason why #4272 would be helpful :)
wow, sorry about that, fix incoming.

Resolving patch:
diff --git a/plugins/modules/packaging/os/pacman.py b/plugins/modules/packaging/os/pacman.py
--- a/plugins/modules/packaging/os/pacman.py
+++ b/plugins/modules/packaging/os/pacman.py
@@ -410,7 +410,7 @@ def upgrade(self):
             cmd = [
                 self.pacman_path,
                 "--sync",
-                "--sys-upgrade",
+                "--sysupgrade",
                 "--quiet",
                 "--noconfirm",
             ]


Test patch:
diff --git a/tests/unit/plugins/modules/packaging/os/test_pacman.py b/tests/unit/plugins/modules/packaging/os/test_pacman.py
--- a/tests/unit/plugins/modules/packaging/os/test_pacman.py
+++ b/tests/unit/plugins/modules/packaging/os/test_pacman.py
@@ -365,7 +365,7 @@ def test_update_db(self, mock_empty_inventory, module_args, expected_call):
                 # for real
                 False,
                 {
-                    "args": ["pacman", "--sync", "--sys-upgrade", "--quiet", "--noconfirm"],
+                    "args": ["pacman", "--sync", "--sysupgrade", "--quiet", "--noconfirm"],
                     "return_value": [0, "stdout", "stderr"],
                 },
                 None,
@@ -377,7 +377,7 @@ def test_update_db(self, mock_empty_inventory, module_args, expected_call):
                     "args": [
                         "pacman",
                         "--sync",
-                        "--sys-upgrade",
+                        "--sysupgrade",
                         "--quiet",
                         "--noconfirm",
                         "--some",