Repository: pyjanitor-devs/pyjanitor

Issue:
[ENH] Naming conventions
I wanted to discuss naming conventions for the various functions and arguments for consistency. `expand_column` has a parameter `column` whereas `add_column` had `col_name`.

Also, is `_column` necessary in each function? Would it be ok to just have an `add()` or `transform()` method? In general I'm more on the side of more verbose function names, but just wanted to throw the idea out there.

Similarly, when following the format of `limit_column_characters` functions like `change_type` should probably be named `change_column_type`.

I'm not married to any of this (except the function arguments, those should be consistent) but wanted to get peoples' ideas.


Discussion:
Thanks for raising this issue, @szuckerman! I’m also in favor of consistent naming schemes. 

Breaking this down a bit:

### Columns

I vote in favor of “col_name”. It is more explicit than “column”.

### Verbose vs Concise Functions

Zen of Python states that explicit is better than implicit, with no qualifiers afterwards. For that reason, I vote in favor of verbose names. 
Labelling this a "good first issue" for newcomers, as it basically involves a find-and-replace.
I'd be interested in taking on this issue if no one has done so yet. Would this need some support to warn users that names have changed, and that previous names will no longer work in a future version?
@HectorM14 yes, that would be great! Please do go ahead.

> Would this need some support to warn users that names have changed, and that previous names will no longer work in a future version?

Yes agreed. Since we're at version 0.16.x right now, the responsible way to evolve the API is to keep it through the next two minor versions, and the deprecate it at the next major or 3rd minor version. Perhaps raising a warning if and only if certain functions are called/keyword arguments are used.

Personally, I would prefer one function at a time, which makes it easier to review, but at the same time, I think we should trust your judgment - especially if there's things that are logically groupable, feel free to PR in them together. Looking forward to what you've got; also, don't hesitate to ping in here!
Great, I'll use my best judgement for PR scope. Is there a standard way to deprecate/discourage old argument names? I was thinking of using decorators to keep the method APIs clear about their usage going forward.
Thanks @HectorM14!

> Is there a standard way to deprecate/discourage old argument names? 

To the best of my knowledge, the standard way to do this should be to insert a conditional checking to see if that old argument name was called or not, and then inside the conditional:

1. Raise a warning.
2. Assign the value of the old argument to a new variable that has the same name as the new argument.

For example:

```python
from warning import warning

def deprecation_warning(old_arg, new_arg):
    """generic warning function."""
    warning(f"{argname.__name__} is deprecated, and will be replaced with {new_arg.__name__}")

def func(df, old_arg1, arg2, arg3, new_arg):
    """docstring here"""
    if old_arg1 is not None:
        deprecation_warning(old_arg1, new_arg)
        new_arg = old_arg1
    # continue code
```

> I was thinking of using decorators to keep the method APIs clear about their usage going forward.

That might actually be better than what I had up there! I'd like to see the pattern in the first PR, it'd be educational for myself.
[Relevant PyCon talk on refactoring and adding `warnings` for legacy code](https://youtu.be/D_6ybDcU5gc?t=787). The actual code for warnings comes in around 17:00.
Oh cool, thanks for sharing that, @szuckerman! 
Following advice in that talk, we could update `expand_column()` as follows:

```python
def expand_column(df, sep, column_name=None, concat=True, **kwargs):
    """
    Expand a categorical column with multiple labels into dummy-coded columns.

    Super sugary syntax that wraps :py:meth:`pandas.Series.str.get_dummies`.

    Functional usage example:

    .. code-block:: python

        df = expand_column(df, column_name='col_name',
                           sep=', ')  # note space in sep

    Method chaining example:

    .. code-block:: python

        import pandas as pd
        import janitor
        df = pd.DataFrame(...).expand_column(df, column_name='col_name', sep=', ')

    :param df: A pandas DataFrame.
    :param column_name: A `str` indicating which column to expand.
    :param sep: The delimiter. Example delimiters include `|`, `, `, `,` etc.
    :param bool concat: Whether to return the expanded column concatenated to
        the original dataframe (`concat=True`), or to return it standalone
        (`concat=False`).
    """
    if kwargs and column_name is not None:
        raise TypeError('Mixed usage of column and column_name')
    if column_name is None:
        warnings.warn('Use of column is deprecated. You should use column_name.')
        column_name = kwargs['column']
    expanded = df[column_name].str.get_dummies(sep=sep)
    if concat:
        df = df.join(expanded)
        return df
    else:
        return expanded
```
One notable consequence of this, is having to set column_name as None, which requires us to move its position in the list of arguments (during the deprecation period). 

The way it's written also assumes that additional arguments received would only relate to deprecated usage, and include `column`.

Another issue is to decide what is the proper variable form of "column". Even when the variable names are explicit, `*_col_*` and `*_column_*` are both used throughout the code.
@HectorM14 those are great points you've raised :smile:. 

> Another issue is to decide what is the proper variable form of "column". Even when the variable names are explicit, `*_col_*` and `*_column_*` are both used throughout the code.

I am guilty of being inconsistent here, as I sometimes use `col` and sometimes use `column` and sometimes use `colname`. Yes, being consistent is a great thing. I would personally vote for `column_name`, in adherence to "explicit is better than implicit", but if there are better reasons (brevity, perhaps?) for other conventions, not a problem! I have no strong opinions on this one, as long as we can make it towards consistency in the end!
I like column_name too. I can aim for being explicit with these names unless they become too unwieldy. I'll start making individual PRs for each updated function. Updating variables relating columns is easy, but if anyone finds other variables that should be updated, they can list them here.
Updating names is becoming a bit more complicated. For example we currently have:
```python
def coalesce(df, columns, new_column_name):
```
Following the current style we've been using, we would update this to:
```python
def coalesce(df, new_column_name, columns=None, **kwargs):
```
But quick, intuitive usage of this function from `example.py` is:
```python
df = (
    df
    .coalesce(["certification", "certification_1"], "certification")
```
With the proposed changes, this would become (due to rearranging of argument order):
```python
df = (
    df
    .coalesce(column_names=["certification", "certification_1"], new_column_name="certification")
)
```
Which is excessively more complicated. So our fix will have to be more complex/clever to keep it clean for the user.
@HectorM14 I wouldn't worry too much about the kwargs. In Python, explicit is better than implicit, generally speaking. I find myself writing out kwarg names even though it is sometimes easier to not do so, because I recognize that it makes the code more readable, actually. I would encourage you to keep going with the PRs :smile:. 
Thanks @ericmjl , explicit is good!
I actually came across this example on [SO](https://stackoverflow.com/questions/49802412/how-to-implement-deprecation-in-python-with-argument-alias):

```python
import functools
import warnings

def _deprecated_alias(**aliases):
    def deco(f):
        @functools.wraps(f)
        def wrapper(*args, **kwargs):
            _rename_kwargs(f.__name__, kwargs, aliases)
            return f(*args, **kwargs)
        return wrapper
    return deco

def _rename_kwargs(func_name, kwargs, aliases):
    for alias, new in aliases.items():
        if alias in kwargs:
            if new in kwargs:
                raise TypeError('{} received both {} and {}'.format(
                    func_name, alias, new))
            warnings.warn('{} is deprecated; use {}'.format(alias, new),
                          DeprecationWarning)
            kwargs[new] = kwargs.pop(alias)
```
using this as a decorator we would be able to do:
```python
@_deprecated_alias(a='alpha', b='beta')
def simple_sum(alpha, beta):
    return alpha + beta

print(simple_sum(alpha=6, beta=9))
print(simple_sum(a=6, b=9))
```
With this method, updating the argument names would be much faster, and when the deprecation period has expired, we only need to delete one/two lines instead of 6+ lines currently. If we used this approach, I would make the above functions more human-readable.

What do you think?
This is a really great find! I'm all for reducing the maintenance burden :smile:. 

Perhaps this function can be inserted into `utils.py`? Be sure to acknowledge the source by linking to SO!

Also, does this mean you'd redo the name changes already PR'd? I don't want to put too much pressure on you, but if you'd do so, that'd be superb for maintenance purposes!
Cool! `utils.py` sounds like a good place. 

I'll link to the SO post in the `_deprecated_alias` docstring. 
I'll start with a PR that includes these new functions, and include some tests to make sure it works/fails/warns as expected. After that, I'm fine updating the previously changed functions and moving forward. I actually was considering revisiting those functions anyway after learning that there was an actual `DeprecationWarning` subclass.
I have been merging from `upstream` before committing, should I be rebasing instead?
Rebasing works as well! It's a suggestion from @zbarry, which, frankly speaking, I rarely do, because it's just easier to remember `git fetch upstream; git merge upstream/dev`. :smile:

That said, good practices are good to use, so I'm going to try moving to rebasing now.

Resolving patch:
diff --git a/janitor/functions.py b/janitor/functions.py
--- a/janitor/functions.py
+++ b/janitor/functions.py
@@ -702,8 +702,9 @@ def expand_column(df, column_name, sep, concat=True):
 
 
 @pf.register_dataframe_method
+@deprecated_alias(columns="column_names")
 def concatenate_columns(
-    df, columns: List, new_column_name: str, sep: str = "-"
+    df, column_names: List, new_column_name: str, sep: str = "-"
 ):
     """
     Concatenates the set of columns into a single column.
@@ -715,7 +716,7 @@ def concatenate_columns(
     .. code-block:: python
 
         df = concatenate_columns(df,
-                                 columns=['col1', 'col2'],
+                                 column_names=['col1', 'col2'],
                                  new_column_name='id',
                                  sep='-')
 
@@ -724,18 +725,18 @@ def concatenate_columns(
     .. code-block:: python
 
         df = (pd.DataFrame(...).
-              concatenate_columns(columns=['col1', 'col2'],
+              concatenate_columns(column_names=['col1', 'col2'],
                                   new_column_name='id',
                                   sep='-'))
 
     :param df: A pandas DataFrame.
-    :param columns: A list of columns to concatenate together.
+    :param column_names: A list of columns to concatenate together.
     :param new_column_name: The name of the new column.
     :param sep: The separator between each column's data.
     :returns: A pandas DataFrame with concatenated columns.
     """
-    assert len(columns) >= 2, "At least two columns must be specified"
-    for i, col in enumerate(columns):
+    assert len(column_names) >= 2, "At least two columns must be specified"
+    for i, col in enumerate(column_names):
         if i == 0:
             df[new_column_name] = df[col].astype(str)
         else:
@@ -747,7 +748,10 @@ def concatenate_columns(
 
 
 @pf.register_dataframe_method
-def deconcatenate_column(df, column: str, new_column_names: List, sep: str):
+@deprecated_alias(column="column_name")
+def deconcatenate_column(
+    df, column_name: str, new_column_names: List, sep: str
+):
     """
     De-concatenates a single column into multiple columns.
 
@@ -760,7 +764,7 @@ def deconcatenate_column(df, column: str, new_column_names: List, sep: str):
     .. code-block:: python
 
         df = deconcatenate_columns(df,
-                                   column='id',
+                                   column_name='id',
                                    new_column_names=['col1', 'col2'],
                                    sep='-')
 
@@ -769,20 +773,20 @@ def deconcatenate_column(df, column: str, new_column_names: List, sep: str):
     .. code-block:: python
 
         df = (pd.DataFrame(...).
-              deconcatenate_columns(columns='id',
-                                    new_column_name=['col1', 'col2'],
+              deconcatenate_columns(column_name='id',
+                                    new_column_names=['col1', 'col2'],
                                     sep='-'))
 
     :param df: A pandas DataFrame.
-    :param column: The column to split.
+    :param column_name: The column to split.
     :param new_column_names: A list of new column names post-splitting.
     :param sep: The separator delimiting the column's data.
     :returns: A pandas DataFrame with a deconcatenated column.
     """
     assert (
-        column in df.columns
-    ), f"column name {column} not present in dataframe"  # noqa: E501
-    deconcat = df[column].str.split(sep, expand=True)
+        column_name in df.columns
+    ), f"column name {column_name} not present in dataframe"  # noqa: E501
+    deconcat = df[column_name].str.split(sep, expand=True)
     assert (
         len(new_column_names) == deconcat.shape[1]
     ), "number of new column names not correct."
@@ -791,8 +795,9 @@ def deconcatenate_column(df, column: str, new_column_names: List, sep: str):
 
 
 @pf.register_dataframe_method
+@deprecated_alias(column="column_name")
 def filter_string(
-    df, column: str, search_string: str, complement: bool = False
+    df, column_name: str, search_string: str, complement: bool = False
 ):
     """
     Filter a string-based column according to whether it contains a substring.
@@ -827,7 +832,7 @@ def filter_string(
     .. code-block:: python
 
         df = filter_string(df,
-                           column='column',
+                           column_name='column',
                            search_string='pattern'
                            complement=False)
 
@@ -836,18 +841,18 @@ def filter_string(
     .. code-block:: python
 
         df = (pd.DataFrame(...)
-              .filter_string(column='column',
+              .filter_string(column_name='column',
                              search_string='pattern'
                              complement=False)
               ...)
 
     :param df: A pandas DataFrame.
-    :param column: The column to filter. The column should contain strings.
+    :param column_name: The column to filter. The column should contain strings.
     :param search_string: A regex pattern or a (sub-)string to search.
     :param complement: Whether to return the complement of the filter or not.
     :returns: A filtered pandas DataFrame.
     """
-    criteria = df[column].str.contains(search_string)
+    criteria = df[column_name].str.contains(search_string)
     if complement:
         return df[~criteria]
     else:
@@ -1144,8 +1149,12 @@ def _get_day(x):
 
 
 @pf.register_dataframe_method
+@deprecated_alias(column="column_name")
 def filter_column_isin(
-    df: pd.DataFrame, column: str, iterable: Iterable, complement: bool = False
+    df: pd.DataFrame,
+    column_name: str,
+    iterable: Iterable,
+    complement: bool = False,
 ):
     """
     Filters a dataframe based on whether the values of a given column are
@@ -1161,7 +1170,7 @@ def filter_column_isin(
         df = (
             pd.DataFrame(...)
             .clean_names()
-            .filter_column_isin(column="names", iterable=["James", "John"]
+            .filter_column_isin(column_name="names", iterable=["James", "John"]
             )
         )
 
@@ -1172,7 +1181,7 @@ def filter_column_isin(
         df = df[df['names'].isin(['James', 'John'])]
 
     :param df: A pandas DataFrame
-    :param column: The column on which to filter.
+    :param column_name: The column on which to filter.
     :param iterable: An iterable. Could be a list, tuple, another pandas
         Series.
     :param complement: Whether to return the complement of the selection or
@@ -1183,7 +1192,7 @@ def filter_column_isin(
         raise ValueError(
             "`iterable` kwarg must be given an iterable of length 1 or greater"
         )
-    criteria = df[column].isin(iterable)
+    criteria = df[column_name].isin(iterable)
 
     if complement:
         return df[~criteria]


Test patch:
diff --git a/tests/functions/test_concatenate_columns.py b/tests/functions/test_concatenate_columns.py
--- a/tests/functions/test_concatenate_columns.py
+++ b/tests/functions/test_concatenate_columns.py
@@ -4,6 +4,8 @@
 @pytest.mark.functions
 def test_concatenate_columns(dataframe):
     df = dataframe.concatenate_columns(
-        columns=["a", "decorated-elephant"], sep="-", new_column_name="index"
+        column_names=["a", "decorated-elephant"],
+        sep="-",
+        new_column_name="index",
     )
     assert "index" in df.columns
diff --git a/tests/functions/test_deconcatenate_column.py b/tests/functions/test_deconcatenate_column.py
--- a/tests/functions/test_deconcatenate_column.py
+++ b/tests/functions/test_deconcatenate_column.py
@@ -4,10 +4,12 @@
 @pytest.mark.functions
 def test_deconcatenate_column(dataframe):
     df = dataframe.concatenate_columns(
-        columns=["a", "decorated-elephant"], sep="-", new_column_name="index"
+        column_names=["a", "decorated-elephant"],
+        sep="-",
+        new_column_name="index",
     )
     df = df.deconcatenate_column(
-        column="index", new_column_names=["A", "B"], sep="-"
+        column_name="index", new_column_names=["A", "B"], sep="-"
     )
     assert "A" in df.columns
     assert "B" in df.columns
diff --git a/tests/functions/test_filter_string.py b/tests/functions/test_filter_string.py
--- a/tests/functions/test_filter_string.py
+++ b/tests/functions/test_filter_string.py
@@ -3,12 +3,14 @@
 
 @pytest.mark.functions
 def test_filter_string(dataframe):
-    df = dataframe.filter_string(column="animals@#$%^", search_string="bbit")
+    df = dataframe.filter_string(
+        column_name="animals@#$%^", search_string="bbit"
+    )
     assert len(df) == 3
 
 
 def test_filter_string_complement(dataframe):
     df = dataframe.filter_string(
-        column="cities", search_string="hang", complement=True
+        column_name="cities", search_string="hang", complement=True
     )
     assert len(df) == 6