Repository: statsmodels/statsmodels

Issue:
Statsmodels 0.13 statsmodels.tsa.stattools.kpss nlags=None behavior
#### Describe the bug

The default nlags for kpss was changed from None to "auto" in 0.13 (commit https://github.com/statsmodels/statsmodels/commit/3d6c3884b9804842ff039c8c5d63a9ccf519867a). This has 2 problems:

1. The docstring still says that nlags=None will behave like nlags="legacy"
2. The branch for None was removed, instead of setting nlags="auto" when None is provided. So now if None is passed explicitly the code assumes it is integer, and throws TypeError when it does `int(nlags)` here https://github.com/statsmodels/statsmodels/blob/v0.13.0/statsmodels/tsa/stattools.py#L1976.

#### Code Sample, a copy-pastable example if possible


```python
from statsmodels.tsa.stattools import kpss
help(kpss)  # shows None is allowed for nlags
kpss([1,2,3], nlags=None)  # TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
```

#### Expected Output

The docstring should either not say that None is allowed or say that None is same as auto.
The implementation should be changed to convert nlags=None to nlags="auto" if None is allowed.

#### Output of ``import statsmodels.api as sm; sm.show_versions()``
<details>

INSTALLED VERSIONS
------------------
Python: 3.9.7.final.0

statsmodels
===========

Installed: 0.13.0 (D:\ss\Miniconda3\lib\site-packages\statsmodels)

Required Dependencies
=====================

cython: 0.29.24 (D:\ss\Miniconda3\lib\site-packages\Cython)
numpy: 1.21.2 (D:\ss\Miniconda3\lib\site-packages\numpy)
scipy: 1.7.1 (D:\ss\Miniconda3\lib\site-packages\scipy)
pandas: 1.3.3 (D:\ss\Miniconda3\lib\site-packages\pandas)
    dateutil: 2.8.2 (D:\ss\Miniconda3\lib\site-packages\dateutil)
patsy: 0.5.2 (D:\ss\Miniconda3\lib\site-packages\patsy)

Optional Dependencies
=====================

matplotlib: 3.4.3 (D:\ss\Miniconda3\lib\site-packages\matplotlib)
    backend: Qt5Agg
cvxopt: Not installed
joblib: 1.1.0 (D:\ss\Miniconda3\lib\site-packages\joblib)

Developer Tools
================

IPython: 7.28.0 (D:\ss\Miniconda3\lib\site-packages\IPython)
    jinja2: 3.0.2 (D:\ss\Miniconda3\lib\site-packages\jinja2)
sphinx: 4.2.0 (D:\ss\Miniconda3\lib\site-packages\sphinx)
    pygments: 2.10.0 (D:\ss\Miniconda3\lib\site-packages\pygments)
pytest: 6.2.5 (D:\ss\Miniconda3\lib\site-packages\pytest)
virtualenv: Not installed

</details>


Discussion:
Thanks.  The `None` options should have been removed.


Resolving patch:
diff --git a/statsmodels/tsa/stattools.py b/statsmodels/tsa/stattools.py
--- a/statsmodels/tsa/stattools.py
+++ b/statsmodels/tsa/stattools.py
@@ -5,9 +5,10 @@
 
 from statsmodels.compat.numpy import lstsq
 from statsmodels.compat.pandas import deprecate_kwarg
-from statsmodels.compat.python import lzip
+from statsmodels.compat.python import lzip, Literal
 from statsmodels.compat.scipy import _next_regular
 
+from typing import Tuple
 import warnings
 
 import numpy as np
@@ -179,8 +180,9 @@ def adfuller(
     ----------
     x : array_like, 1d
         The data series to test.
-    maxlag : int
-        Maximum lag which is included in test, default 12*(nobs/100)^{1/4}.
+    maxlag : {None, int}
+        Maximum lag which is included in test, default value of
+        12*(nobs/100)^{1/4} is used when ``None``.
     regression : {"c","ct","ctt","n"}
         Constant and trend order to include in regression.
 
@@ -1059,7 +1061,7 @@ def ccovf(x, y, adjusted=True, demean=True, fft=True):
         d = n
 
     method = "fft" if fft else "direct"
-    return correlate(xo, yo, "full", method=method)[n - 1:] / d
+    return correlate(xo, yo, "full", method=method)[n - 1 :] / d
 
 
 @deprecate_kwarg("unbiased", "adjusted")
@@ -1867,7 +1869,12 @@ def has_missing(data):
     return np.isnan(np.sum(data))
 
 
-def kpss(x, regression="c", nlags="auto", store=False):
+def kpss(
+    x,
+    regression: Literal["c", "ct"] = "c",
+    nlags: Literal["auto", "legacy"] | int = "auto",
+    store: bool = False,
+) -> Tuple[float, float, int, dict[str, float]]:
     """
     Kwiatkowski-Phillips-Schmidt-Shin test for stationarity.
 
@@ -1883,12 +1890,11 @@ def kpss(x, regression="c", nlags="auto", store=False):
 
         * "c" : The data is stationary around a constant (default).
         * "ct" : The data is stationary around a trend.
-    nlags : {None, str, int}, optional
-        Indicates the number of lags to be used. If None (default), lags is
-        calculated using the legacy method. If "auto", lags is calculated
-        using the data-dependent method of Hobijn et al. (1998). See also
-        Andrews (1991), Newey & West (1994), and Schwert (1989). If set to
-        "legacy",  uses int(12 * (n / 100)**(1 / 4)) , as outlined in
+    nlags : {str, int}, optional
+        Indicates the number of lags to be used. If "auto" (default), lags
+        is calculated using the data-dependent method of Hobijn et al. (1998).
+        See also Andrews (1991), Newey & West (1994), and Schwert (1989). If
+        set to "legacy",  uses int(12 * (n / 100)**(1 / 4)) , as outlined in
         Schwert (1989).
     store : bool
         If True, then a result instance is returned additionally to
@@ -1914,7 +1920,7 @@ def kpss(x, regression="c", nlags="auto", store=False):
 
     Notes
     -----
-    To estimate sigma^2 the Newey-West estimator is used. If lags is None,
+    To estimate sigma^2 the Newey-West estimator is used. If lags is "legacy",
     the truncation lag parameter is set to int(12 * (n / 100) ** (1 / 4)),
     as outlined in Schwert (1989). The p-values are interpolated from
     Table 1 of Kwiatkowski et al. (1992). If the computed statistic is
@@ -1968,19 +1974,26 @@ def kpss(x, regression="c", nlags="auto", store=False):
     if nlags == "legacy":
         nlags = int(np.ceil(12.0 * np.power(nobs / 100.0, 1 / 4.0)))
         nlags = min(nlags, nobs - 1)
-    elif nlags == "auto":
+    elif nlags == "auto" or nlags is None:
+        if nlags is None:
+            # TODO: Remove before 0.14 is released
+            warnings.warn(
+                "None is not a valid value for nlags. It must be an integer, "
+                "'auto' or 'legacy'. None will raise starting in 0.14",
+                FutureWarning,
+            )
         # autolag method of Hobijn et al. (1998)
         nlags = _kpss_autolag(resids, nobs)
         nlags = min(nlags, nobs - 1)
+    elif isinstance(nlags, str):
+        raise ValueError("nvals must be 'auto' or 'legacy' when not an int")
     else:
-        nlags = int(nlags)
+        nlags = int_like(nlags, "nlags", optional=False)
 
-    if nlags >= nobs:
-        raise ValueError(
-            "lags ({}) must be < number of observations ({})".format(
-                nlags, nobs
+        if nlags >= nobs:
+            raise ValueError(
+                f"lags ({nlags}) must be < number of observations ({nobs})"
             )
-        )
 
     pvals = [0.10, 0.05, 0.025, 0.01]
 
@@ -2053,6 +2066,7 @@ def _kpss_autolag(resids, nobs):
     autolags = int(gamma_hat * np.power(nobs, pwr))
     return autolags
 
+
 def range_unit_root_test(x, store=False):
     """
     Range unit-root test for stationarity.
@@ -2111,21 +2125,25 @@ def range_unit_root_test(x, store=False):
     # Table from [1] has been replicated using 200,000 samples
     # Critical values for new n_obs values have been identified
     pvals = [0.01, 0.025, 0.05, 0.10, 0.90, 0.95]
-    n = np.array([25, 50, 100, 150, 200, 250, 500, 1000, 2000, 3000, 4000, 5000])
-    crit = np.array([
-        [0.6626, 0.8126, 0.9192, 1.0712, 2.4863, 2.7312],
-        [0.7977, 0.9274, 1.0478, 1.1964, 2.6821, 2.9613],
-        [0.9070, 1.0243, 1.1412, 1.2888, 2.8317, 3.1393],
-        [0.9543, 1.0768, 1.1869, 1.3294, 2.8915, 3.2049],
-        [0.9833, 1.0984, 1.2101, 1.3494, 2.9308, 3.2482],
-        [0.9982, 1.1137, 1.2242, 1.3632, 2.9571, 3.2842],
-        [1.0494, 1.1643, 1.2712, 1.4076, 3.0207, 3.3584],
-        [1.0846, 1.1959, 1.2988, 1.4344, 3.0653, 3.4073],
-        [1.1121, 1.2200, 1.3230, 1.4556, 3.0948, 3.4439],
-        [1.1204, 1.2295, 1.3303, 1.4656, 3.1054, 3.4632],
-        [1.1309, 1.2347, 1.3378, 1.4693, 3.1165, 3.4717],
-        [1.1377, 1.2402, 1.3408, 1.4729, 3.1252, 3.4807]
-    ])
+    n = np.array(
+        [25, 50, 100, 150, 200, 250, 500, 1000, 2000, 3000, 4000, 5000]
+    )
+    crit = np.array(
+        [
+            [0.6626, 0.8126, 0.9192, 1.0712, 2.4863, 2.7312],
+            [0.7977, 0.9274, 1.0478, 1.1964, 2.6821, 2.9613],
+            [0.9070, 1.0243, 1.1412, 1.2888, 2.8317, 3.1393],
+            [0.9543, 1.0768, 1.1869, 1.3294, 2.8915, 3.2049],
+            [0.9833, 1.0984, 1.2101, 1.3494, 2.9308, 3.2482],
+            [0.9982, 1.1137, 1.2242, 1.3632, 2.9571, 3.2842],
+            [1.0494, 1.1643, 1.2712, 1.4076, 3.0207, 3.3584],
+            [1.0846, 1.1959, 1.2988, 1.4344, 3.0653, 3.4073],
+            [1.1121, 1.2200, 1.3230, 1.4556, 3.0948, 3.4439],
+            [1.1204, 1.2295, 1.3303, 1.4656, 3.1054, 3.4632],
+            [1.1309, 1.2347, 1.3378, 1.4693, 3.1165, 3.4717],
+            [1.1377, 1.2402, 1.3408, 1.4729, 3.1252, 3.4807],
+        ]
+    )
 
     # Interpolation for nobs
     inter_crit = np.zeros((1, crit.shape[1]))
@@ -2141,9 +2159,9 @@ def range_unit_root_test(x, store=False):
 
     rur_stat = count / np.sqrt(len(x))
 
-    k = len(pvals)-1
-    for i in range(len(pvals)-1,-1,-1):
-        if rur_stat < inter_crit[0,i]:
+    k = len(pvals) - 1
+    for i in range(len(pvals) - 1, -1, -1):
+        if rur_stat < inter_crit[0, i]:
             k = i
         else:
             break
@@ -2156,14 +2174,21 @@ def range_unit_root_test(x, store=False):
 """
     direction = ""
     if p_value == pvals[-1]:
-        direction="smaller"
+        direction = "smaller"
     elif p_value == pvals[0]:
-        direction="larger"
+        direction = "larger"
 
     if direction:
-        warnings.warn(warn_msg.format(direction=direction), InterpolationWarning)
+        warnings.warn(
+            warn_msg.format(direction=direction), InterpolationWarning
+        )
 
-    crit_dict = {"10%": inter_crit[0,3], "5%": inter_crit[0,2], "2.5%": inter_crit[0,1], "1%": inter_crit[0,0]}
+    crit_dict = {
+        "10%": inter_crit[0, 3],
+        "5%": inter_crit[0, 2],
+        "2.5%": inter_crit[0, 1],
+        "1%": inter_crit[0, 0],
+    }
 
     if store:
         from statsmodels.stats.diagnostic import ResultsStore


Test patch:
diff --git a/statsmodels/tsa/tests/test_stattools.py b/statsmodels/tsa/tests/test_stattools.py
--- a/statsmodels/tsa/tests/test_stattools.py
+++ b/statsmodels/tsa/tests/test_stattools.py
@@ -17,6 +17,7 @@
 import pandas as pd
 from pandas import DataFrame, Series, date_range
 import pytest
+from scipy.interpolate import interp1d
 
 from statsmodels.datasets import macrodata, modechoice, nile, randhie, sunspots
 from statsmodels.tools.sm_exceptions import (
@@ -25,15 +26,17 @@
     InterpolationWarning,
     MissingDataError,
 )
+# Remove imports when range unit root test gets an R implementation
+from statsmodels.tools.validation import array_like, bool_like
 from statsmodels.tsa.arima_process import arma_acovf
 from statsmodels.tsa.statespace.sarimax import SARIMAX
 from statsmodels.tsa.stattools import (
     acf,
     acovf,
-    ccovf,
     adfuller,
     arma_order_select_ic,
     breakvar_heteroskedasticity_test,
+    ccovf,
     coint,
     grangercausalitytests,
     innovations_algo,
@@ -49,10 +52,6 @@
     zivot_andrews,
 )
 
-# Remove imports when range unit root test gets an R implementation
-from statsmodels.tools.validation import array_like, bool_like
-from scipy.interpolate import interp1d
-
 DECIMAL_8 = 8
 DECIMAL_6 = 6
 DECIMAL_5 = 5
@@ -829,6 +828,10 @@ def test_unknown_lags(self):
         with pytest.raises(ValueError):
             kpss(self.x, "c", nlags="unknown")
 
+    def test_none(self):
+        with pytest.warns(FutureWarning):
+            kpss(self.x, nlags=None)
+
 
 class TestRUR:
     """
@@ -859,21 +862,25 @@ def simple_rur(self, x, store=False):
         # Table from [1] has been replicated using 200,000 samples
         # Critical values for new n_obs values have been identified
         pvals = [0.01, 0.025, 0.05, 0.10, 0.90, 0.95]
-        n = np.array([25, 50, 100, 150, 200, 250, 500, 1000, 2000, 3000, 4000, 5000])
-        crit = np.array([
-            [0.6626, 0.8126, 0.9192, 1.0712, 2.4863, 2.7312],
-            [0.7977, 0.9274, 1.0478, 1.1964, 2.6821, 2.9613],
-            [0.907, 1.0243, 1.1412, 1.2888, 2.8317, 3.1393],
-            [0.9543, 1.0768, 1.1869, 1.3294, 2.8915, 3.2049],
-            [0.9833, 1.0984, 1.2101, 1.3494, 2.9308, 3.2482],
-            [0.9982, 1.1137, 1.2242, 1.3632, 2.9571, 3.2482],
-            [1.0494, 1.1643, 1.2712, 1.4076, 3.0207, 3.3584],
-            [1.0846, 1.1959, 1.2988, 1.4344, 3.0653, 3.4073],
-            [1.1121, 1.2200, 1.3230, 1.4556, 3.0948, 3.4439],
-            [1.1204, 1.2295, 1.3318, 1.4656, 3.1054, 3.4632],
-            [1.1309, 1.2347, 1.3318, 1.4693, 3.1165, 3.4717],
-            [1.1377, 1.2402, 1.3408, 1.4729, 3.1252, 3.4807]
-        ])
+        n = np.array(
+            [25, 50, 100, 150, 200, 250, 500, 1000, 2000, 3000, 4000, 5000]
+        )
+        crit = np.array(
+            [
+                [0.6626, 0.8126, 0.9192, 1.0712, 2.4863, 2.7312],
+                [0.7977, 0.9274, 1.0478, 1.1964, 2.6821, 2.9613],
+                [0.907, 1.0243, 1.1412, 1.2888, 2.8317, 3.1393],
+                [0.9543, 1.0768, 1.1869, 1.3294, 2.8915, 3.2049],
+                [0.9833, 1.0984, 1.2101, 1.3494, 2.9308, 3.2482],
+                [0.9982, 1.1137, 1.2242, 1.3632, 2.9571, 3.2482],
+                [1.0494, 1.1643, 1.2712, 1.4076, 3.0207, 3.3584],
+                [1.0846, 1.1959, 1.2988, 1.4344, 3.0653, 3.4073],
+                [1.1121, 1.2200, 1.3230, 1.4556, 3.0948, 3.4439],
+                [1.1204, 1.2295, 1.3318, 1.4656, 3.1054, 3.4632],
+                [1.1309, 1.2347, 1.3318, 1.4693, 3.1165, 3.4717],
+                [1.1377, 1.2402, 1.3408, 1.4729, 3.1252, 3.4807],
+            ]
+        )
 
         # Interpolation for nobs
         inter_crit = np.zeros((1, crit.shape[1]))
@@ -917,9 +924,16 @@ def simple_rur(self, x, store=False):
             direction = "larger"
 
         if direction:
-            warnings.warn(warn_msg.format(direction=direction), InterpolationWarning)
+            warnings.warn(
+                warn_msg.format(direction=direction), InterpolationWarning
+            )
 
-        crit_dict = {"10%": inter_crit[0, 3], "5%": inter_crit[0, 2], "2.5%": inter_crit[0, 1], "1%": inter_crit[0, 0]}
+        crit_dict = {
+            "10%": inter_crit[0, 3],
+            "5%": inter_crit[0, 2],
+            "2.5%": inter_crit[0, 1],
+            "1%": inter_crit[0, 0],
+        }
 
         if store:
             from statsmodels.stats.diagnostic import ResultsStore
@@ -941,21 +955,18 @@ def test_fail_nonvector_input(self, reset_randomstate):
         x = np.random.rand(20, 2)
         assert_raises(ValueError, range_unit_root_test, x)
 
-
     def test_teststat(self):
         with pytest.warns(InterpolationWarning):
             rur_stat, _, _ = range_unit_root_test(self.x)
             simple_rur_stat, _, _ = self.simple_rur(self.x)
         assert_almost_equal(rur_stat, simple_rur_stat, DECIMAL_3)
 
-
     def test_pval(self):
         with pytest.warns(InterpolationWarning):
             _, pval, _ = range_unit_root_test(self.x)
             _, simple_pval, _ = self.simple_rur(self.x)
         assert_equal(pval, simple_pval)
 
-
     def test_store(self):
         with pytest.warns(InterpolationWarning):
             _, _, _, store = range_unit_root_test(self.x, True)