Repository: Qiskit/qiskit

Issue:
rename "python" drawer to "matplot"
The name options for the `circuit_drawer` are `['latex', 'latex_source', 'python', 'text']`. The output `python` is no very descriptive of the expected output. I suggest to rename it to `'matplot'`.



Discussion:
I'm totally fine with this. I only used `python` as the name because @jaygambetta did not like using matplotlib as the name. We can change it to `matplot` though, I agree that's a much better name.
How about just `'mpl'` since that is the canonical short-name for Matplotlib?
@nonhermitian oh, yeah that's a good point. That's what we should do
i agree

Resolving patch:
diff --git a/qiskit/tools/visualization/_circuit_visualization.py b/qiskit/tools/visualization/_circuit_visualization.py
--- a/qiskit/tools/visualization/_circuit_visualization.py
+++ b/qiskit/tools/visualization/_circuit_visualization.py
@@ -79,9 +79,9 @@ def circuit_drawer(circuit,
         filename (str): file path to save image to
         style (dict or str): dictionary of style or file name of style file
         output (str): Select the output method to use for drawing the circuit.
-            Valid choices are `latex`, `latex_source`, `python`. Note if one is
+            Valid choices are `latex`, `latex_source`, `mpl`. Note if one is
             not specified it will use latex and if that fails fallback to
-            python. However this behavior is deprecated and in a future release
+            mpl. However this behavior is deprecated and in a future release
             the default will change.
         interactive (bool): when set true show the circuit in a new window
             (cannot inline in Jupyter). Note when used with the latex_source
@@ -98,18 +98,18 @@ def circuit_drawer(circuit,
     if not output:
         warnings.warn('The current behavior for the default output will change'
                       ' in a future release. Instead of trying latex and '
-                      'falling back to python on failure it will just use '
-                      'python by default', DeprecationWarning)
+                      'falling back to mpl on failure it will just use '
+                      'mpl by default', DeprecationWarning)
         try:
             im = _latex_circuit_drawer(circuit, basis, scale, filename, style)
         except (OSError, subprocess.CalledProcessError):
             im = _matplotlib_circuit_drawer(circuit, basis, scale, filename,
                                             style)
     else:
-        if output not in ['latex', 'latex_source', 'python']:
+        if output not in ['latex', 'latex_source', 'mpl']:
             raise VisualizationError(
                 'Invalid output type %s selected. The only valid choices are '
-                'latex, latex_source, and python' % output)
+                'latex, latex_source, and mpl' % output)
         if output == 'latex':
             im = _latex_circuit_drawer(circuit, basis=basis, scale=scale,
                                        filename=filename, style=style)
@@ -117,7 +117,7 @@ def circuit_drawer(circuit,
             return _generate_latex_source(circuit, basis=basis,
                                           filename=filename, scale=scale,
                                           style=style)
-        elif output == 'python':
+        elif output == 'mpl':
             im = _matplotlib_circuit_drawer(circuit, basis=basis, scale=scale,
                                             filename=filename, style=style)
     if im and interactive:
@@ -1491,7 +1491,7 @@ def matplotlib_circuit_drawer(circuit,
     warnings.warn('The matplotlib_circuit_drawer() function is deprecated and '
                   'will be removed in a future release. Instead use the '
                   'circuit_drawer() function with the `output` kwarg set to '
-                  '`python`.', DeprecationWarning)
+                  '`mpl`.', DeprecationWarning)
     return _matplotlib_circuit_drawer(circuit, basis=basis, scale=scale,
                                       filename=filename, style=style)
 


Test patch: