Repository: cltk/cltk

Issue:
Add "Gorman Trees" corpus for Greek
https://github.com/perseids-publications/gorman-trees = https://perseids-publications.github.io/gorman-trees/

~500,000 tokens of parsed Ancient Greek.


Discussion:
Or provide instructions for loading it as a remote corpus; though that may take rewriting corpus_importer (would have to check—@kylepjohnson?)
Related—worth separate issues: retrain the backoff lemmatizer, the pos taggers, etc. Will create soon.
> Or provide instructions for loading it as a remote corpus; though that may take rewriting corpus_importer (would have to check—@kylepjohnson?)

If it is a Git repo, we only need [to add it to our official Greek repo](https://github.com/cltk/cltk/wiki/How-to-add-a-corpus-to-the-CLTK#adding-a-git-backed-corpus-to-github) or an individual can it [locally through a custom config file](http://docs.cltk.org/en/latest/importing_corpora.html#user-defined-distributed-corpora).

Regarding the structure of this repo, it appears to be meant to be an entire website. So there is a bunch of stuff our users wouldn't be interested in, however I do see there is a config.json file. Example, point to a work by Aeschines: https://github.com/perseids-publications/gorman-trees/blob/df219711d26f12089f47b4e0fd4fd1a468da844b/src/config.json#L14

```
     "path": "aeschines-1-1-50-bu1",
        "xml": "aeschines-1-1-50-bu1.xml",
        "chunks": {
```

So someone might want to make a corpus reader, using this config, that pulls these directly.

@ryanfb if you want to give a shot at adding this corpus, and thus get to know the project a little better, I would welcome a PR. Otherwise I can do it quickly myself.

Also, a related topic: Should we continue to fork other repos ([example](https://github.com/cltk/treebank-releases)) or simply point to the original upstream?

The benefit of forking is that we protect against upstream breakage; the downside is that someone must manually update each repo with a PR, which in practice means that the data in our forked repos is usually out of date.

In the past, I favored forking, though now I lean towards pointing to the original repo and hoping working with those maintainers when they break compatibility.
Vanessa Gorman also has a repo with just the XML files [here](https://github.com/vgorman1/Greek-Dependency-Trees), and has stated (on the GLtreebank Google Group) that she intends to keep both up to date.

I'd be happy to make a quick PR for pulling that repo in as a Greek treebank corpus. The past forking was why I was unsure. There are, as you mention, upsides and downsides to each approach.
OK please make the PR using the original XML repo (thus not our own cltk fork).

Meta: In general, I am inclined to reduce the number of corpora we make available, and instead focus energies on better integration.

Resolving patch:
diff --git a/cltk/corpus/greek/corpora.py b/cltk/corpus/greek/corpora.py
--- a/cltk/corpus/greek/corpora.py
+++ b/cltk/corpus/greek/corpora.py
@@ -42,6 +42,12 @@
      'name': 'greek_treebank_perseus',
      'location': 'remote',
      'type': 'treebank'},
+    {'encoding': 'utf-8',
+     'markup': 'xml',
+     'origin': 'https://github.com/vgorman1/Greek-Dependency-Trees.git',
+     'name': 'greek_treebank_gorman',
+     'location': 'remote',
+     'type': 'treebank'},
     {'encoding': 'xml',
      'markup': 'plaintext',
      'origin': 'https://github.com/cltk/greek_lexica_perseus.git',


Test patch: