Repository: great-expectations/great_expectations

Issue:
`great_expectations datasource new` inaccurate messaging
**Describe the bug**
The new datasource notebook states the following:

> Credentials will not be saved until you run the last cell. The credentials will be saved in uncommitted/config_variables.yml which should not be added to source control.

This is not true; they are saved to `great_expectations.yml` which is not in the provided `.gitignore`. I consider this misleading and even harmful.

**To Reproduce**
Steps to reproduce the behavior:
1. run `great_expectations datasource new`
2. follow instructions
3. observe credentials stored in different location than suggested, particularly in a non-git-ignored file.


**Expected behavior**
Either accurate messaging, or a fix to store them wherever is intended.

**Environment (please complete the following information):**
- Operating System: macOS 12.6, zsh, python 3.9.13
- Great Expectations Version: 0.15.26


**Additional context**
I'm using postgres



Discussion:

Resolving patch:
diff --git a/great_expectations/render/renderer/datasource_new_notebook_renderer.py b/great_expectations/render/renderer/datasource_new_notebook_renderer.py
--- a/great_expectations/render/renderer/datasource_new_notebook_renderer.py
+++ b/great_expectations/render/renderer/datasource_new_notebook_renderer.py
@@ -31,7 +31,7 @@ class DatasourceNewNotebookRenderer(BaseNotebookRenderer):
 
 Also, if you would like to learn more about the **DataConnectors** used in this configuration, please see our docs on [InferredAssetDataConnectors](https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/how_to_configure_an_inferredassetdataconnector), [ConfiguredAssetDataConnectors](https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/how_to_configure_a_configuredassetdataconnector), and [RuntimeDataConnectors](https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/how_to_configure_a_runtimedataconnector).
 
-Credentials will not be saved until you run the last cell. The credentials will be saved in `uncommitted/config_variables.yml` which should not be added to source control."""
+Credentials will not be saved until you run the last cell."""
 
     FILES_DOCS = """### For files based Datasources:
 Here we are creating an example configuration.  The configuration contains an **InferredAssetFilesystemDataConnector** which will add a Data Asset for each file in the base directory you provided. It also contains a **RuntimeDataConnector** which can accept filepaths.   This is just an example, and you may customize this as you wish!


Test patch:
diff --git a/tests/render/renderer/test_datasource_new_notebook_renderer.py b/tests/render/renderer/test_datasource_new_notebook_renderer.py
--- a/tests/render/renderer/test_datasource_new_notebook_renderer.py
+++ b/tests/render/renderer/test_datasource_new_notebook_renderer.py
@@ -94,7 +94,7 @@ def _construct_datasource_new_notebook_assets(
 
 Also, if you would like to learn more about the **DataConnectors** used in this configuration, please see our docs on [InferredAssetDataConnectors](https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/how_to_configure_an_inferredassetdataconnector), [ConfiguredAssetDataConnectors](https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/how_to_configure_a_configuredassetdataconnector), and [RuntimeDataConnectors](https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/how_to_configure_a_runtimedataconnector).
 
-Credentials will not be saved until you run the last cell. The credentials will be saved in `uncommitted/config_variables.yml` which should not be added to source control.""",
+Credentials will not be saved until you run the last cell.""",
                 "metadata": {},
             }
         ]