Repository: Qiskit/qiskit

Issue:
Issues with unified circuit drawer
<!-- ⚠️ If you do not respect this template, your issue will be closed -->
<!-- ⚠️ Make sure to browse the opened and closed issues -->

### Informations

- **Qiskit Terra version**:
- **Python version**:
- **Operating system**:

### What is the current behavior?
I think the following should be fixed regarding the merge of #1055:

1- Remove `DeprecationWarning`: This is a bit annoying as it gets printed all the time. I think deprecation warnings should be about something the user should update in their code. Here, we are just announcing plans for changing a default. Most people just want to write `circuit_drawer(circuit)`.

2- ```circuit_drawer(circ, output='python')```: can we force the output to be shown here? Otherwise, changing the default will mean everyone has to add a ```%matplotlib inline``` to their notebooks.

3- ```circuit_drawer(circ, output='latex_source')``` raises an AttributeError.

4- ```interactive=True``` has no effect with ```ouput='python'``` either. I should it should display it, right? The docstring only says
```Note when used with the latex_source output type this has no effect```



Discussion:
1. It should only be printed when there is no output specified. The users will need to change their code if they're expecting latex drawer to be used with no output specified (as that's the current default) it will be changed to python or ascii in the future.

2. I didn't change anything related to jupyter for the matplotlib output on circuit drawer. It should work exactly the same as it did before.

3. I likely missed something in that case can you paste the stack trace with the attribute error? I'll take a look tomorrow.

4. I didn't test that, but it's just calling PIL image_show when interactive is set true. It should work the same way plot_circuit() function did.

Resolving patch:
diff --git a/qiskit/tools/visualization/_circuit_visualization.py b/qiskit/tools/visualization/_circuit_visualization.py
--- a/qiskit/tools/visualization/_circuit_visualization.py
+++ b/qiskit/tools/visualization/_circuit_visualization.py
@@ -111,12 +111,15 @@ def circuit_drawer(circuit,
                 'Invalid output type %s selected. The only valid choices are '
                 'latex, latex_source, and python' % output)
         if output == 'latex':
-            im = _latex_circuit_drawer(circuit, basis, scale, filename, style)
+            im = _latex_circuit_drawer(circuit, basis=basis, scale=scale,
+                                       filename=filename, style=style)
         elif output == 'latex_source':
-            return _generate_latex_source(circuit, basis, scale, filename, style)
+            return _generate_latex_source(circuit, basis=basis,
+                                          filename=filename, scale=scale,
+                                          style=style)
         elif output == 'python':
-            im = _matplotlib_circuit_drawer(circuit, basis, scale, filename,
-                                            style)
+            im = _matplotlib_circuit_drawer(circuit, basis=basis, scale=scale,
+                                            filename=filename, style=style)
     if im and interactive:
         im.show()
     return im


Test patch: