Repository: great-expectations/great_expectations

Issue:
Use cleaner solution for non-truncating division in python 2
Prefer `from __future__ import division` to `1.*x/y`


Discussion:
Done inline during improve_partitions push.

Resolving patch:
diff --git a/great_expectations/rule_based_profiler/expectation_configuration_builder/default_expectation_configuration_builder.py b/great_expectations/rule_based_profiler/expectation_configuration_builder/default_expectation_configuration_builder.py
--- a/great_expectations/rule_based_profiler/expectation_configuration_builder/default_expectation_configuration_builder.py
+++ b/great_expectations/rule_based_profiler/expectation_configuration_builder/default_expectation_configuration_builder.py
@@ -123,6 +123,10 @@ def __init__(
 
         self._condition = condition
 
+        self._validation_parameter_builder_configs = (
+            validation_parameter_builder_configs
+        )
+
         self._kwargs = kwargs
 
     @property
@@ -133,6 +137,12 @@ def expectation_type(self) -> str:
     def condition(self) -> Optional[str]:
         return self._condition
 
+    @property
+    def validation_parameter_builder_configs(
+        self,
+    ) -> Optional[List[ParameterBuilderConfig]]:
+        return self._validation_parameter_builder_configs
+
     @property
     def kwargs(self) -> dict:
         return self._kwargs
diff --git a/great_expectations/rule_based_profiler/parameter_builder/parameter_builder.py b/great_expectations/rule_based_profiler/parameter_builder/parameter_builder.py
--- a/great_expectations/rule_based_profiler/parameter_builder/parameter_builder.py
+++ b/great_expectations/rule_based_profiler/parameter_builder/parameter_builder.py
@@ -136,6 +136,10 @@ def __init__(
 
         self._name = name
 
+        self._evaluation_parameter_builder_configs = (
+            evaluation_parameter_builder_configs
+        )
+
         self._evaluation_parameter_builders = init_rule_parameter_builders(
             parameter_builder_configs=evaluation_parameter_builder_configs,
             data_context=self._data_context,
@@ -240,6 +244,12 @@ def evaluation_parameter_builders(
     ) -> Optional[List["ParameterBuilder"]]:  # noqa: F821
         return self._evaluation_parameter_builders
 
+    @property
+    def evaluation_parameter_builder_configs(
+        self,
+    ) -> Optional[List[ParameterBuilderConfig]]:
+        return self._evaluation_parameter_builder_configs
+
     @property
     def json_serialize(self) -> Union[str, bool]:
         return self._json_serialize


Test patch:
diff --git a/tests/conftest.py b/tests/conftest.py
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -3616,7 +3616,6 @@ def bobby_columnar_table_multi_batch(empty_data_context):
         ExpectationConfiguration(
             **{
                 "expectation_type": "expect_column_values_to_match_regex",
-                "meta": {"notes": {"format": "markdown", "content": None}},
                 "kwargs": {
                     "column": "RatecodeID",
                     "regex": r"^\d{1}$",
@@ -3638,7 +3637,6 @@ def bobby_columnar_table_multi_batch(empty_data_context):
         ExpectationConfiguration(
             **{
                 "expectation_type": "expect_column_values_to_match_regex",
-                "meta": {"notes": {"format": "markdown", "content": None}},
                 "kwargs": {
                     "column": "PULocationID",
                     "regex": r"^\d{1}$",
@@ -4923,7 +4921,7 @@ def bobster_columnar_table_multi_batch_normal_mean_5000_stdev_1000_data_context(
     of a batch sampled from a normal distribution with the mean of 5,000 rows and the standard deviation of 1,000 rows.
     """
     # Re-enable GE_USAGE_STATS
-    monkeypatch.delenv("GE_USAGE_STATS")
+    monkeypatch.delenv("GE_USAGE_STATS", raising=False)
     monkeypatch.setattr(AnonymizedUsageStatisticsConfig, "enabled", True)
 
     project_path: str = str(tmp_path_factory.mktemp("taxi_data_context"))
diff --git a/tests/rule_based_profiler/parameter_builder/test_mean_unexpected_map_metric_multi_batch_parameter_builder.py b/tests/rule_based_profiler/parameter_builder/test_mean_unexpected_map_metric_multi_batch_parameter_builder.py
--- a/tests/rule_based_profiler/parameter_builder/test_mean_unexpected_map_metric_multi_batch_parameter_builder.py
+++ b/tests/rule_based_profiler/parameter_builder/test_mean_unexpected_map_metric_multi_batch_parameter_builder.py
@@ -752,6 +752,7 @@ def test_mean_unexpected_map_metric_multi_batch_parameter_builder_bobby_check_se
         "null_count_parameter_builder_name",
         "metric_domain_kwargs",
         "metric_value_kwargs",
+        "evaluation_parameter_builder_configs",
         "json_serialize",
         "batch_request",
     }
@@ -831,6 +832,7 @@ def test_mean_unexpected_map_metric_multi_batch_parameter_builder_bobby_check_se
         "null_count_parameter_builder_name",
         "metric_domain_kwargs",
         "metric_value_kwargs",
+        "evaluation_parameter_builder_configs",
         "json_serialize",
         "batch_request",
     }