Repository: vacanza/python-holidays

Issue:
Wrong workday info for country HR
Today (Oct. 8, 2020) my alarmclock automation did not go off, because my workday sensor gave the wrong info (no workday). This day used to be a holiday in Croatia, but is not anymore.

binary_sensor:
  - platform: workday
    country: HR

![image](https://user-images.githubusercontent.com/61622258/95419607-4082d000-093a-11eb-904c-77a2639b1719.png)



Discussion:

Resolving patch:
diff --git a/holidays/countries/croatia.py b/holidays/countries/croatia.py
--- a/holidays/countries/croatia.py
+++ b/holidays/countries/croatia.py
@@ -11,18 +11,18 @@
 #  Website: https://github.com/dr-prodigy/python-holidays
 #  License: MIT (see LICENSE file)
 
-from datetime import date
+from datetime import date, timedelta
 
 from dateutil.easter import easter
-from dateutil.relativedelta import relativedelta as rd
 
-from holidays.constants import JAN, MAY, JUN, AUG, OCT, \
-    NOV, DEC
+from holidays.constants import JAN, MAY, JUN, AUG, OCT, NOV, DEC
 from holidays.holiday_base import HolidayBase
 
 
 class Croatia(HolidayBase):
 
+    # Updated with act 022-03 / 19-01 / 219 of 14 November 2019
+    # https://narodne-novine.nn.hr/clanci/sluzbeni/2019_11_110_2212.html
     # https://en.wikipedia.org/wiki/Public_holidays_in_Croatia
 
     def __init__(self, **kwargs):
@@ -32,6 +32,7 @@ def __init__(self, **kwargs):
     def _populate(self, year):
         # New years
         self[date(year, JAN, 1)] = "Nova Godina"
+
         # Epiphany
         self[date(year, JAN, 6)] = "Sveta tri kralja"
         easter_date = easter(year)
@@ -39,23 +40,23 @@ def _populate(self, year):
         # Easter
         self[easter_date] = "Uskrs"
         # Easter Monday
-        self[easter_date + rd(days=1)] = "Uskršnji ponedjeljak"
+        self[easter_date + timedelta(days=1)] = "Uskrsni ponedjeljak"
 
         # Corpus Christi
-        self[easter_date + rd(days=60)] = "Tijelovo"
+        self[easter_date + timedelta(days=60)] = "Tijelovo"
 
         # International Workers' Day
         self[date(year, MAY, 1)] = "Međunarodni praznik rada"
 
+        # Statehood day (new)
         if year >= 2020:
-            # Statehood day
             self[date(year, MAY, 30)] = "Dan državnosti"
 
         # Anti-fascist struggle day
         self[date(year, JUN, 22)] = "Dan antifašističke borbe"
 
+        # Statehood day (old)
         if year < 2020:
-            # Statehood day
             self[date(year, JUN, 25)] = "Dan državnosti"
 
         # Victory and Homeland Thanksgiving Day
@@ -64,17 +65,16 @@ def _populate(self, year):
         # Assumption of Mary
         self[date(year, AUG, 15)] = "Velika Gospa"
 
+        # Independence Day (old)
         if year < 2020:
-            # Independence Day
             self[date(year, OCT, 8)] = "Dan neovisnosti"
 
         # All Saints' Day
-        self[date(year, NOV, 1)] = "Dan svih svetih"
+        self[date(year, NOV, 1)] = "Svi sveti"
 
         if year >= 2020:
             # Memorial day
-            self[date(year, NOV, 18)] =\
-                "Dan sjećanja na žrtve Domovinskog rata"
+            self[date(year, NOV, 18)] = "Dan sjećanja"
 
         # Christmas day
         self[date(year, DEC, 25)] = "Božić"


Test patch:
diff --git a/tests.py b/tests.py
--- a/tests.py
+++ b/tests.py
@@ -4949,6 +4949,9 @@ def test_2018(self):
         self.assertIn(date(2018, 11, 1), self.holidays)
         self.assertIn(date(2018, 12, 25), self.holidays)
         self.assertIn(date(2018, 12, 26), self.holidays)
+
+    def test_2020_new(self):
+        self.assertIn(date(2020, 5, 30), self.holidays)
         self.assertIn(date(2020, 11, 18), self.holidays)