Repository: Azure/azure-cli-extensions

Issue:
min_pro is used in the example of help in express-route-cross-connection
- If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at [Azure/azure-cli](https://github.com/Azure/azure-cli/issues)

### Extension name (the extension in question)
express-route-cross-connection

### Description of issue (in as much detail as possible)
https://github.com/Azure/azure-cli-extensions/blob/bbefbe73a620c6407b522484d6b2ba848cb4f9f5/src/express-route-cross-connection/azext_expressroutecrossconnection/_help.py#L131

We shouldn't use min_profile in the help example. It needs to be updated to supportedprofile instead.
-----




Discussion:
In this case, the value can simply be removed. It serves no purpose.

Resolving patch:
diff --git a/src/express-route-cross-connection/azext_expressroutecrossconnection/_help.py b/src/express-route-cross-connection/azext_expressroutecrossconnection/_help.py
--- a/src/express-route-cross-connection/azext_expressroutecrossconnection/_help.py
+++ b/src/express-route-cross-connection/azext_expressroutecrossconnection/_help.py
@@ -16,18 +16,18 @@
 
 helps['network cross-connection list'] = """
     type: command
-    short-summary: List all ExpressRoute circuits for the current subscription.
+    short-summary: List all ExpressRoute cross-connections for the current subscription.
     examples:
-        - name: List all ExpressRoute circuits for the current subscription.
+        - name: List all ExpressRoute cross-connections for the current subscription.
           text: >
             az network cross-connection list -g MyResourceGroup
 """
 
 helps['network cross-connection list-arp-tables'] = """
     type: command
-    short-summary: Show the current Address Resolution Protocol (ARP) table of an ExpressRoute circuit peering.
+    short-summary: Show the current Address Resolution Protocol (ARP) table of an ExpressRoute cross-connection peering.
     examples:
-        - name: Show the current Address Resolution Protocol (ARP) table of an ExpressRoute circuit.
+        - name: Show the current Address Resolution Protocol (ARP) table of an ExpressRoute cross-connection.
           text: |
             az network cross-connection list-arp-tables -g MyResourceGroup -n MyCircuit \\
                 --path primary --peering-name AzurePrivatePeering
@@ -35,9 +35,9 @@
 
 helps['network cross-connection list-route-tables'] = """
     type: command
-    short-summary: Show the current routing table of an ExpressRoute circuit peering.
+    short-summary: Show the current routing table of an ExpressRoute cross-connection peering.
     examples:
-        - name: Show the current routing table of an ExpressRoute circuit peering.
+        - name: Show the current routing table of an ExpressRoute cross-connection peering.
           text: |
             az network cross-connection list-route-tables -g MyResourceGroup -n MyCircuit \\
                 --path primary --peering-name AzurePrivatePeering
@@ -45,50 +45,46 @@
 
 helps['network cross-connection show'] = """
     type: command
-    short-summary: Get the details of an ExpressRoute circuit.
+    short-summary: Get the details of an ExpressRoute cross-connection.
     examples:
-        - name: Get the details of an ExpressRoute circuit.
+        - name: Get the details of an ExpressRoute cross-connection.
           text: >
             az network cross-connection show -n MyCircuit -g MyResourceGroup
 """
 
 helps['network cross-connection update'] = """
     type: command
-    short-summary: Update settings of an ExpressRoute circuit.
-    examples:
-        - name: Change the SKU of an ExpressRoute circuit from Standard to Premium.
-          text: >
-            az network cross-connection update -n MyCircuit -g MyResourceGroup --sku-tier Premium
+    short-summary: Update settings of an ExpressRoute cross-connection.
 """
 
 helps['network cross-connection wait'] = """
     type: command
     short-summary: Place the CLI in a waiting state until a condition of the ExpressRoute is met.
     examples:
-        - name: Pause executing next line of CLI script until the ExpressRoute circuit is successfully provisioned.
-          text: az network cross-connection wait -n MyCircuit --g MyResourceGroup --created
+        - name: Pause executing next line of CLI script until the ExpressRoute cross-connection is successfully provisioned.
+          text: az network cross-connection wait -n MyCircuit -g MyResourceGroup --created
 """
 
 helps['network cross-connection peering'] = """
     type: group
-    short-summary: Manage ExpressRoute peering of an ExpressRoute circuit.
+    short-summary: Manage ExpressRoute peering of an ExpressRoute cross-connection.
 """
 
 helps['network cross-connection peering create'] = """
     type: command
-    short-summary: Create peering settings for an ExpressRoute circuit.
+    short-summary: Create peering settings for an ExpressRoute cross-connection.
     examples:
         - name: Create Microsoft Peering settings with IPv4 configuration.
           text: |
-            az network cross-connection peering create -g MyResourceGroup --circuit-name MyCircuit \\
+            az network cross-connection peering create -g MyResourceGroup --cross-connection-name MyCircuit \\
                 --peering-type MicrosoftPeering --peer-asn 10002 --vlan-id 103 \\
                 --primary-peer-subnet 101.0.0.0/30 --secondary-peer-subnet 102.0.0.0/30 \\
                 --advertised-public-prefixes 101.0.0.0/30
-        - name: Add IPv6 settings to existing IPv4 config for Microsoft peering.
-          text: |
-            az network cross-connection peering update -g MyResourceGroup --circuit-name MyCircuit \\
-                --peering-type MicrosoftPeering --ip-version ipv6 --primary-peer-subnet 2002:db00::/126 \\
-                --secondary-peer-subnet 2003:db00::/126 --advertised-public-prefixes 2002:db00::/126
+"""
+
+helps['network cross-connection peering update'] = """
+    type: command
+    short-summary: Update peering settings for an ExpressRoute cross-connection.
 """
 
 helps['network cross-connection peering delete'] = """
@@ -97,35 +93,23 @@
     examples:
     - name: Delete private peering.
       text: >
-        az network cross-connection peering delete -g MyResourceGroup --circuit-name MyCircuit -n AzurePrivatePeering
+        az network cross-connection peering delete -g MyResourceGroup --cross-connection-name MyCircuit -n AzurePrivatePeering
 """
 
 helps['network cross-connection peering list'] = """
     type: command
-    short-summary: List peering settings of an ExpressRoute circuit.
+    short-summary: List peering settings of an ExpressRoute cross-connection.
     examples:
-    - name: List peering settings of an ExpressRoute circuit.
+    - name: List peering settings of an ExpressRoute cross-connection.
       text: >
-        az network cross-connection peering list -g MyResourceGroup --circuit-name MyCircuit
+        az network cross-connection peering list -g MyResourceGroup --cross-connection-name MyCircuit
 """
 
 helps['network cross-connection peering show'] = """
     type: command
     short-summary: Get the details of an express route peering.
     examples:
-    - name: Get private peering details of an ExpressRoute circuit.
+    - name: Get private peering details of an ExpressRoute cross-connection.
       text: >
-        az network cross-connection peering show -g MyResourceGroup --circuit-name MyCircuit -n AzurePrivatePeering
-"""
-
-helps['network cross-connection peering update'] = """
-    type: command
-    short-summary: Update peering settings of an ExpressRoute circuit.
-    examples:
-        - name: Add IPv6 Microsoft Peering settings to existing IPv4 config.
-          text: |
-            az network cross-connection peering update -g MyResourceGroup \\
-                --circuit-name MyCircuit --peering-type MicrosoftPeering --ip-version ipv6 \\
-                --primary-peer-subnet 2002:db00::/126 --secondary-peer-subnet 2003:db00::/126 \\
-                --advertised-public-prefixes 2002:db00::/126
+        az network cross-connection peering show -g MyResourceGroup --cross-connection-name MyCircuit -n AzurePrivatePeering
 """
diff --git a/src/express-route-cross-connection/azext_expressroutecrossconnection/_params.py b/src/express-route-cross-connection/azext_expressroutecrossconnection/_params.py
--- a/src/express-route-cross-connection/azext_expressroutecrossconnection/_params.py
+++ b/src/express-route-cross-connection/azext_expressroutecrossconnection/_params.py
@@ -20,9 +20,11 @@ def load_arguments(self, _):
     name_arg_type = CLIArgumentType(options_list=('--name', '-n'), metavar='NAME')
     cross_connection_name_type = CLIArgumentType(options_list=('--cross-connection-name',), metavar='NAME', help='ExpressRoute cross-connection name.', id_part='name', completer=get_resource_name_completion_list('Microsoft.Network/expressRouteCrossConnections'))
     routing_registry_values = ['ARIN', 'APNIC', 'AFRINIC', 'LACNIC', 'RIPENCC', 'RADB', 'ALTDB', 'LEVEL3']
+    device_path_values = ['primary', 'secondary']
 
     with self.argument_context('network cross-connection') as c:
-        c.argument('cross_connection_name', cross_connection_name_type, options_list=('--name', '-n'))
+        c.argument('cross_connection_name', cross_connection_name_type, options_list=['--name', '-n'])
+        c.argument('device_path', options_list='--path', arg_type=get_enum_type(device_path_values))
 
     with self.argument_context('network cross-connection update') as c:
         c.argument('notes', help='Service provider notes.')
@@ -35,8 +37,8 @@ def load_arguments(self, _):
         c.argument('cross_connection_name', cross_connection_name_type)
         c.argument('peering_name', name_arg_type, id_part='child_name_1')
         c.argument('peering_type', validator=validate_peering_type, arg_type=get_enum_type(ExpressRoutePeeringType), help='BGP peering type for the circuit.')
-        c.argument('primary_peer_address_prefix', options_list=['--primary-peer-subnet'], help='/30 subnet used to configure IP addresses for primary interface.')
-        c.argument('secondary_peer_address_prefix', options_list=['--secondary-peer-subnet'], help='/30 subnet used to configure IP addresses for secondary interface.')
+        c.argument('primary_peer_address_prefix', options_list='--primary-peer-subnet', help='/30 subnet used to configure IP addresses for primary interface.')
+        c.argument('secondary_peer_address_prefix', options_list='--secondary-peer-subnet', help='/30 subnet used to configure IP addresses for secondary interface.')
         c.argument('advertised_public_prefixes', arg_group='Microsoft Peering', nargs='+', help='Space-separated list of prefixes to be advertised through the BGP peering.')
         c.argument('customer_asn', arg_group='Microsoft Peering', help='Autonomous system number of the customer.')
         c.argument('routing_registry_name', arg_group='Microsoft Peering', arg_type=get_enum_type(routing_registry_values), help='Internet Routing Registry / Regional Internet Registry')
diff --git a/src/express-route-cross-connection/setup.py b/src/express-route-cross-connection/setup.py
--- a/src/express-route-cross-connection/setup.py
+++ b/src/express-route-cross-connection/setup.py
@@ -30,7 +30,7 @@
     name='express-route-cross-connection',
     version=VERSION,
     description='Manage customer ExpressRoute circuits using an ExpressRoute cross-connection.',
-    long_description='These commands give ISPs limited ability to manage the ExpressRoute circuits of ' \
+    long_description='These commands give ISPs limited ability to manage the ExpressRoute circuits of '
                      'their customers through an ExpressRoute cross-connection resource.',
     license='MIT',
     author='Microsoft Corporation',


Test patch: