Repository: freedomofpress/securedrop

Issue:
Use "Submissions" instead of "Documents" and "Messages" in source application strings.
# Bug

_This is a good first issue. If you have questions ask in this ticket or reach out via our [Gitter channel](https://gitter.im/freedomofpress/securedrop)._

## Description

There are mixed usages of the terms "Submissions", "Documents", and "Messages" in both English and German.

Found by @xella

## Expected Behavior

We use the term "submissions" consistently in user-facing strings.

Change use of word "document" across SI and JI, to "file"
## Description

In confirmation messaging in the Source UI, on the "All Sources" page of the JI, and maybe on the individual Source page in the JI, the word "document" is shown. In the H2 and Body copy of the SI, we have already changed the word to "File," and I believe in the SDW Client have also made the update. 

The file-name format including the word "doc" for files in the `.gz` filename, I'm not too worried about. it's more in the SI confirmation messaging and possible error messaging, as well as in the JI, that it feels nitpicky and out of place. 

## User Research Evidence
![image](https://user-images.githubusercontent.com/8262612/142579763-a0725fe3-5c30-4fa8-ba28-5b9bb5ab8305.png)


## User Stories

As a Source submitting an image, there is a cognitive disconnect when I get a confirmation message thanking me for my document. As a journalist, it is adding cognitive friction to see "doc" when I know they're "files." 



Discussion:
True, this is confusing. I think standardizing on submissions is the best call. Submissions are then divided into files and messages. We should stop using the term documents, as the use of that term has been confusing: the uploaded files can be videos, pictures, or "documents" (PDFs, office documents). 
"document" and "submission" are still both in use, this is are relatively easy fix, so can be bumped up in priority.
A quick addendum to this: Having to clarify that "doc" in the filename doesn't mean it's a Microsoft Word document file but any kind of file (image, video, etc) is something I go out of my way to explain in SecureDrop training sessions to avoid confused trainees.

Resolving patch:
diff --git a/securedrop/manage.py b/securedrop/manage.py
--- a/securedrop/manage.py
+++ b/securedrop/manage.py
@@ -331,7 +331,7 @@ def get_args() -> argparse.ArgumentParser:
     parser.add_argument(
         "--store-dir",
         default=config.STORE_DIR,
-        help=("directory in which the documents are stored"),
+        help=("directory in which the files are stored"),
     )
     subps = parser.add_subparsers()
     # Add/remove journalists + admins
diff --git a/securedrop/source_app/main.py b/securedrop/source_app/main.py
--- a/securedrop/source_app/main.py
+++ b/securedrop/source_app/main.py
@@ -292,9 +292,9 @@ def submit(logged_in_source: SourceUser) -> werkzeug.Response:
             elif msg and not fh:
                 html_contents = gettext("Thanks! We received your message.")
             elif fh and not msg:
-                html_contents = gettext("Thanks! We received your document.")
+                html_contents = gettext("Thanks! We received your file.")
             else:
-                html_contents = gettext("Thanks! We received your message and document.")
+                html_contents = gettext("Thanks! We received your file and message.")
 
             flash_msg("success", gettext("Success!"), html_contents)
 


Test patch:
diff --git a/securedrop/tests/test_integration.py b/securedrop/tests/test_integration.py
--- a/securedrop/tests/test_integration.py
+++ b/securedrop/tests/test_integration.py
@@ -462,7 +462,7 @@ def test_delete_collection(mocker, source_app, journalist_app, test_journo):
             in text
         )
 
-        assert "No documents have been submitted!" in text
+        assert "There are no submissions!" in text
 
         # Make sure the collection is deleted from the filesystem
         def assertion():
diff --git a/securedrop/tests/test_journalist.py b/securedrop/tests/test_journalist.py
--- a/securedrop/tests/test_journalist.py
+++ b/securedrop/tests/test_journalist.py
@@ -373,7 +373,7 @@ def test_login_valid_credentials(config, journalist_app, test_journo, locale):
             follow_redirects=True,
         )
         assert page_language(resp.data) == language_tag(locale)
-        msgids = ["All Sources", "No documents have been submitted!"]
+        msgids = ["All Sources", "There are no submissions!"]
         with xfail_untranslated_messages(config, locale, msgids):
             resp_text = resp.data.decode("utf-8")
             for msgid in msgids:
diff --git a/securedrop/tests/test_source.py b/securedrop/tests/test_source.py
--- a/securedrop/tests/test_source.py
+++ b/securedrop/tests/test_source.py
@@ -467,7 +467,7 @@ def test_submit_file(source_app):
         )
         assert resp.status_code == 200
         text = resp.data.decode("utf-8")
-        assert "Thanks! We received your document" in text
+        assert "Thanks! We received your file" in text
 
 
 def test_submit_both(source_app):
@@ -481,7 +481,7 @@ def test_submit_both(source_app):
         )
         assert resp.status_code == 200
         text = resp.data.decode("utf-8")
-        assert "Thanks! We received your message and document" in text
+        assert "Thanks! We received your file and message" in text
 
 
 def test_submit_antispam(source_app):