Repository: apluslms/a-plus

Issue:
Small accessibility issues on login page
- Heading levels don't match
- It would make sense to use `section` for types of login
- The old button contrast issue
- Input ttype should be programmatically determinable - add some `autocomplete` attributes. 


Discussion:
@Mankro I supposed that the button contrast has already been solved.  What do we exactly want to autocomplete in the login page? 

Resolving patch:
diff --git a/aplus/settings.py b/aplus/settings.py
--- a/aplus/settings.py
+++ b/aplus/settings.py
@@ -35,8 +35,8 @@
 
 WELCOME_TEXT = 'Welcome to A+ <small>modern learning environment</small>'
 SHIBBOLETH_TITLE_TEXT = 'Aalto University users'
-SHIBBOLETH_BODY_TEXT = 'Log in with Aalto University user account by clicking the button below. Programme students and faculty must log in here.'
-SHIBBOLETH_BUTTON_TEXT = 'Aalto login'
+SHIBBOLETH_BODY_TEXT = 'Log in with your Aalto University user account by clicking on the button below. FiTech, Open University and programme students as well as staff members must log in here.'
+SHIBBOLETH_BUTTON_TEXT = 'Log in with Aalto account'
 MOOC_TITLE_TEXT = 'Users external to Aalto'
 MOOC_BODY_TEXT = 'Some of our courses are open for everyone. Log in with your user account from one of the following services.'
 INTERNAL_USER_LABEL = 'Aalto'
@@ -44,8 +44,8 @@
 
 WELCOME_TEXT_FI = 'A+ <small>verkkopohjainen oppimisympäristö</small>'
 SHIBBOLETH_TITLE_TEXT_FI = 'Aalto-yliopiston käyttäjät'
-SHIBBOLETH_BODY_TEXT_FI = 'Kirjaudu palveluun Aalto-yliopiston käyttäjätunnuksella alla olevasta painikkeesta. Koulutusohjelmien opiskelijoiden ja henkilökunnan pitää kirjautua tästä.'
-SHIBBOLETH_BUTTON_TEXT_FI = 'Aalto-kirjautuminen'
+SHIBBOLETH_BODY_TEXT_FI = 'Kirjaudu palveluun Aalto-yliopiston käyttäjätunnuksella alla olevasta painikkeesta. FiTechin, avoimen yliopiston ja koulutusohjelmien opiskelijoiden sekä henkilökunnan täytyy kirjautua tästä.'
+SHIBBOLETH_BUTTON_TEXT_FI = 'Kirjaudu Aalto-tunnuksella'
 MOOC_TITLE_TEXT_FI = 'Käyttäjät Aallon ulkopuolelta'
 MOOC_BODY_TEXT_FI = 'Osa kursseistamme on avoinna kaikille. Kirjaudu sisään jonkin seuraavan palvelun käyttäjätunnuksellasi.'
 


Test patch:
diff --git a/selenium_test/test/locators.py b/selenium_test/test/locators.py
--- a/selenium_test/test/locators.py
+++ b/selenium_test/test/locators.py
@@ -10,6 +10,7 @@ class FirstPageLocators(object):
     BANNER = (By.XPATH, "//*[@class='page-header']/h1")
     APLUS_TEST_COURSE_INSTANCE_BUTTON = (By.XPATH, "//div[contains(@class, 'card')]/a[contains(@href, '/aplus1/basic_instance/')]//*[contains(@class, 'card-title')]")
     HOOK_EXAMPLE_BUTTON = (By.XPATH, "//div[contains(@class, 'card')]/a[contains(@href, '/aplus1/hook_instance/')]//*[contains(@class, 'card-title')]")
+    SHOW_LOGIN_BUTTON = (By.XPATH, "//*[contains(@class, 'show-extra-login-btn')]")
 
 class BasePageLocators(object):
     COURSE_BANNER = (By.XPATH, "//*[@id='bs-navbar-collapse']/ul[1]/li[1]/a")
diff --git a/selenium_test/test/page_objects.py b/selenium_test/test/page_objects.py
--- a/selenium_test/test/page_objects.py
+++ b/selenium_test/test/page_objects.py
@@ -147,6 +147,7 @@ def loginToCourse(self, course, username=defaultUsername, password=defaultPasswo
             self.clickThrough(FirstPageLocators.HOOK_EXAMPLE_BUTTON)
         self.waitForElement(LoginPageLocators.BANNER)
         self.waitForElement(BasePageLocators.FOOTER)
+        self.getElement(FirstPageLocators.SHOW_LOGIN_BUTTON).click()
         self.signIn(username, password)
 
     def loginAsStudent(self, course=CourseName.APLUS):