Repository: microsoft/ptvsd

Issue:
Default values for exceptionBreakpointFilters sent in initialize event are strings
The default values for the exception breakpoint filters are strings, when they need to be booleans.
https://github.com/Microsoft/vscode-debugadapter-node/blob/master/protocol/src/debugProtocol.ts#L1180

```json
            supportsModulesRequest=True,
            exceptionBreakpointFilters=[
                {
                    "filter": "raised",
                    "label": "Raised Exceptions",
                    "default": "false"
                },
                {
                    "filter": "uncaught",
                    "label": "Uncaught Exceptions",
                    "default": "true"
                },
            ],
```


Discussion:

Resolving patch:
diff --git a/ptvsd/wrapper.py b/ptvsd/wrapper.py
--- a/ptvsd/wrapper.py
+++ b/ptvsd/wrapper.py
@@ -802,12 +802,12 @@ def on_initialize(self, request, args):
                 {
                     'filter': 'raised',
                     'label': 'Raised Exceptions',
-                    'default': 'false'
+                    'default': False
                 },
                 {
                     'filter': 'uncaught',
                     'label': 'Uncaught Exceptions',
-                    'default': 'true'
+                    'default': True
                 },
             ],
         )


Test patch:
diff --git a/tests/highlevel/test_lifecycle.py b/tests/highlevel/test_lifecycle.py
--- a/tests/highlevel/test_lifecycle.py
+++ b/tests/highlevel/test_lifecycle.py
@@ -72,12 +72,12 @@ def test_attach(self):
                     {
                         'filter': 'raised',
                         'label': 'Raised Exceptions',
-                        'default': 'false'
+                        'default': False
                     },
                     {
                         'filter': 'uncaught',
                         'label': 'Uncaught Exceptions',
-                        'default': 'true'
+                        'default': True
                     },
                 ],
                 supportsEvaluateForHovers=True,
@@ -146,12 +146,12 @@ def test_launch(self):
                     {
                         'filter': 'raised',
                         'label': 'Raised Exceptions',
-                        'default': 'false'
+                        'default': False
                     },
                     {
                         'filter': 'uncaught',
                         'label': 'Uncaught Exceptions',
-                        'default': 'true'
+                        'default': True
                     },
                 ],
                 supportsEvaluateForHovers=True,
diff --git a/tests/highlevel/test_live_pydevd.py b/tests/highlevel/test_live_pydevd.py
--- a/tests/highlevel/test_live_pydevd.py
+++ b/tests/highlevel/test_live_pydevd.py
@@ -125,12 +125,12 @@ def test_launch(self):
                     {
                         'filter': 'raised',
                         'label': 'Raised Exceptions',
-                        'default': 'false'
+                        'default': False
                     },
                     {
                         'filter': 'uncaught',
                         'label': 'Uncaught Exceptions',
-                        'default': 'true'
+                        'default': True
                     },
                 ],
                 supportsEvaluateForHovers=True,
diff --git a/tests/highlevel/test_messages.py b/tests/highlevel/test_messages.py
--- a/tests/highlevel/test_messages.py
+++ b/tests/highlevel/test_messages.py
@@ -114,12 +114,12 @@ def test_basic(self):
                     {
                         'filter': 'raised',
                         'label': 'Raised Exceptions',
-                        'default': 'true'
+                        'default': True
                     },
                     {
                         'filter': 'uncaught',
                         'label': 'Uncaught Exceptions',
-                        'default': 'true'
+                        'default': True
                     },
                 ],
                 supportsEvaluateForHovers=True,