Repository: rotki/rotki

Issue:
API request failed
## Problem Definition

I upgraded to version 1.2.0 and all my accounts from before were gone. I got 2 errors from the notification panel:

- Querying blockchain balances died because of: Etherscan returned error response: {'status': FVal(0.0), 'message': 'NOTOK', 'result': 'Maximum rate limit reached'}. Check the logs for more details.

- Task for startup of makerdao died with exception: Etherscan returned error response: {'status': FVal(0.0), 'message': 'NOTOK', 'result': 'Maximum rate limit reached'}. Check the logs for more details

I tried to add one account back manually and got this error:

- Operation failed due to Etherscan API request failed due to ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Plus this new error appears (note that I don't use cryptocompare and didn't add an API key for it):

- The backend query task died unexpectedly: HTTPSConnectionPool(host='min-api.cryptocompare.com', port=443): Read timed out. (read timeout=None)

## Relevant logs

08/03/2020 20:45:51 CET -- ERROR:rotkehlchen.greenlets:Task for startup of makerdao died with exception: Etherscan returned error response: {'status': FVal(0.0), 'message': 'NOTOK', 'result': 'Maximum rate limit reached'}.
Exception Name: <class 'rotkehlchen.errors.RemoteError'>
Exception Info: Etherscan returned error response: {'status': FVal(0.0), 'message': 'NOTOK', 'result': 'Maximum rate limit reached'}
Traceback:
   File "src/gevent/greenlet.py", line 818, in gevent._greenlet.Greenlet.run
  File "rotkehlchen/makerdao.py", line 556, in on_startup
  File "rotkehlchen/makerdao.py", line 387, in get_historical_dsr
  File "rotkehlchen/makerdao.py", line 337, in _historical_dsr_for_account
  File "rotkehlchen/makerdao.py", line 224, in _get_vat_move_event_value
  File "rotkehlchen/chain/ethereum.py", line 449, in get_logs
  File "rotkehlchen/externalapis/etherscan.py", line 436, in get_logs
  File "rotkehlchen/externalapis/etherscan.py", line 212, in _query

08/03/2020 22:07:26 CET -- ERROR:rotkehlchen.api.rest:Greenlet for task 3 dies with exception: HTTPSConnectionPool(host='min-api.cryptocompare.com', port=443): Read timed out. (read timeout=None).
Exception Name: <class 'requests.exceptions.ReadTimeout'>
Exception Info: HTTPSConnectionPool(host='min-api.cryptocompare.com', port=443): Read timed out. (read timeout=None)
Traceback:
   File "src/gevent/greenlet.py", line 818, in gevent._greenlet.Greenlet.run
  File "rotkehlchen/api/rest.py", line 206, in _do_query_async
  File "rotkehlchen/api/rest.py", line 415, in _query_exchange_balances
  File "rotkehlchen/utils/interfaces.py", line 110, in wrapper
  File "rotkehlchen/utils/interfaces.py", line 69, in wrapper
  File "rotkehlchen/exchanges/kraken.py", line 424, in query_balances
  File "rotkehlchen/inquirer.py", line 122, in find_usd_price
  File "rotkehlchen/externalapis/cryptocompare.py", line 237, in query_endpoint_price
  File "rotkehlchen/externalapis/cryptocompare.py", line 153, in _api_query
  File "requests/sessions.py", line 537, in get
  File "requests/sessions.py", line 524, in request
  File "requests/sessions.py", line 637, in send
  File "requests/adapters.py", line 529, in send


Discussion:

Resolving patch:
diff --git a/docs/conf.py b/docs/conf.py
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -24,9 +24,9 @@
 author = 'Lefteris Karapetsas'
 
 # The short X.Y version
-version = '1.2.0'
+version = '1.2.1'
 # The full version, including alpha/beta/rc tags
-release = '1.2.0'
+release = '1.2.1'
 
 
 # -- General configuration ---------------------------------------------------
diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -21,7 +21,7 @@ def read(fname):
     if not requirement.lstrip().startswith('#')
 ))
 
-version = '1.2.0'  # Do not edit: this is maintained by bumpversion (see .bumpversion.cfg)
+version = '1.2.1'  # Do not edit: this is maintained by bumpversion (see .bumpversion.cfg)
 
 setup(
     name='rotkehlchen',


Test patch: