internlm/SWE-Fixer-Train-110K huggingface dataset:
Repository: spack/spack

Issue:
Fail to build libmng [AutotoolsPackage]
@alalazo I got this error while installing `libmng`:

```
...
==> Already patched libmng
==> Building libmng [AutotoolsPackage]
==> Executing phase : 'autoreconf'
==> Executing phase : 'configure'
==> Error: ProcessError: Command exited with status 1:
    '/my/path/spack/var/spack/stage/libmng-2.0.2-2x5fkukzf3sf4uexegr3n35jwmy5pclu/libmng-2.0.2/configure' '--prefix=/my/path/spack/opt/spack/linux-scientificcernslc6-x86_64/gcc-6.2.0/libmng-2.0.2-2x5fkukzf3sf4uexegr3n35jwmy5pclu'
/my/path/spack/lib/spack/spack/build_systems/autotools.py:265, in configure:
     258      def configure(self, spec, prefix):
     259          """Runs configure with the arguments specified in :py:meth:`.configure_args`
     260          and an appropriately set prefix.
     261          """
     262          options = ['--prefix={0}'.format(prefix)] + self.configure_args()
     263  
     264          with working_dir(self.build_directory, create=True)
```

And this is the spack-build.out:

```
...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
configure: error: source directory already configured; run "make distclean" there first
```

Before merge #2859 I could install it correctly but now I get this, do you think that could be related with the commit or maybe I have to install it in a different way now?


Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/libmng/package.py b/var/spack/repos/builtin/packages/libmng/package.py
--- a/var/spack/repos/builtin/packages/libmng/package.py
+++ b/var/spack/repos/builtin/packages/libmng/package.py
@@ -42,3 +42,7 @@ def patch(self):
         # jpeg requires stdio to beincluded before its headrs.
         filter_file(r'^(\#include \<jpeglib\.h\>)',
                     '#include<stdio.h>\n\\1', 'libmng_types.h')
+
+    @run_before('configure')
+    def clean_configure_directory(self):
+        make('distclean')


Test patch:
Repository: spack/spack

Issue:
Ocaml fails to build, AutotoolsPackage issue?
Ocaml is `class Ocaml(AutotoolsPackage):`

When I try to build it, using the devel branch of a clone from 20160131, it dies with the following message in the `spack-build.out` file:

```
==> '/isilon/Analysis/scratch/hartzelg/spack/spack-20170131/var/spack/stage/ocaml-4.03.0-ktkzdjwhbav3td6aqi3zeufdhs4g2is3/ocaml-4.03.0/configure' '--prefix=/isilon/Analysis/scratch/hartzelg/spack/spack-20170131/opt/spack/linux-centos7-x86_64/gcc-5.4.0/ocaml-4.03.0-ktkzdjwhbav3td6aqi3zeufdhs4g2is3'
Configuring OCaml version 4.03.0
[ERROR!] configure expects arguments of the form '-prefix /foo/bar', not '-prefix=/foo/bar' (note the '=').
```

Before I dig in, does this ring any bells?



Discussion:
@adamjstewart -- ping?

i suppose you need to move it back to `Package` by adding `class Ocaml(Package)` and 
```
def install(self, spec, prefix):
         configure('-prefix', '{0}'.format(prefix))
 
         make('world.opt')
         make('install')
```
which was removed in https://github.com/LLNL/spack/pull/2845. That looks as a very infrequent usage case.
@adamjstewart converted about 300 packages, so one false conversion is not too bad :smile:
Ouch, two in one day. Sorry about that. @davydden has the right answer.
I'm a big fan of @adamjstewart's work.  Happy to do the lazy/testing bit....  PR in the works.

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/ocaml/package.py b/var/spack/repos/builtin/packages/ocaml/package.py
--- a/var/spack/repos/builtin/packages/ocaml/package.py
+++ b/var/spack/repos/builtin/packages/ocaml/package.py
@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Ocaml(AutotoolsPackage):
+class Ocaml(Package):
     """OCaml is an industrial strength programming language supporting
        functional, imperative and object-oriented styles"""
 
@@ -36,4 +36,8 @@ class Ocaml(AutotoolsPackage):
 
     depends_on('ncurses')
 
-    build_targets = ['world.opt']
+    def install(self, spec, prefix):
+        configure('-prefix', '{0}'.format(prefix))
+        
+        make('world.opt')
+        make('install')


Test patch:
Repository: spack/spack

Issue:
Spack cannot fetch spark
``` bash
==> Installing spark
==> Fetching http://mirrors.ocf.berkeley.edu/apache/spark/spark-2.0.0/spark-2.0.0-bin-without-hadoop.tgz

curl: (22) The requested URL returned error: 404 Not Found
==> Fetching from http://mirrors.ocf.berkeley.edu/apache/spark/spark-2.0.0/spark-2.0.0-bin-without-hadoop.tgz failed.
==> Error: FetchError: All fetchers failed for spark-2.0.0-siuvjddnvh3c352byzbz3yjopqrbbsdw
```

Berkeley is taking down old versions of spark. This may be a better place for the fetcher to look.
```
http://archive.apache.org/dist/spark/
```


Discussion:
maybe it needs `list_url`, similar to https://github.com/LLNL/spack/pull/2935
@davydden No, the older versions simply don't exist on that particular mirror.

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/spark/package.py b/var/spack/repos/builtin/packages/spark/package.py
--- a/var/spack/repos/builtin/packages/spark/package.py
+++ b/var/spack/repos/builtin/packages/spark/package.py
@@ -33,7 +33,7 @@ class Spark(Package):
     """
 
     homepage = "http://spark.apache.org"
-    url      = "http://mirrors.ocf.berkeley.edu/apache/spark/spark-2.0.0/spark-2.0.0-bin-without-hadoop.tgz"
+    url      = "http://archive.apache.org/dist/spark/spark-2.0.0/spark-2.0.0-bin-without-hadoop.tgz"
 
     variant('hadoop', default=False,
             description='Build with Hadoop')
@@ -41,6 +41,8 @@ class Spark(Package):
     depends_on('jdk', type=('build', 'run'))
     depends_on('hadoop', when='+hadoop', type=('build', 'run'))
 
+    version('2.1.0', '21d4471e78250775b1fa7c0e6c3a1326')
+    version('2.0.2', '32110c1bb8f081359738742bd26bced1')
     version('2.0.0', '8a5307d973da6949a385aefb6ff747bb')
     version('1.6.2', '304394fbe2899211217f0cd9e9b2b5d9')
     version('1.6.1', 'fcf4961649f15af1fea78c882e65b001')


Test patch:
Repository: spack/spack

Issue:
Cannot build `mpc` on Comet
When I try to build `mpc` on Comet, then this fails because it tries to use a system-installed `mpfr` instead of the one that Spack just installed. Spack should pass the respective configure option to point `mpc` to its `mpfr`.

This used to work. I assume this is a fall-out from the recent conversion to `AutotoolsPackage` that removed the respective configure options.


Discussion:
The conversion to AutotoolsPackage in #2845 didn't remove any configure options, so it's unrelated. I'm not sure if we ever passed the options properly. I'll try building it locally and see if I can recreate the issue. If so, I'll submit a PR to pass the configure options properly.
Hmm, I am unable to reproduce the problem you are seeing:
```
$ ldd -r /home/ajstewart/spack/opt/spack/linux-fedora25-x86_64/gcc-6.2.1/mpc-1.0.3-bjhoziwbvzgftq3gc6w42eyrjromy7wg/lib/libmpc.so
	linux-vdso.so.1 (0x00007ffdf499c000)
	libmpfr.so.4 => /home/ajstewart/spack/opt/spack/linux-fedora25-x86_64/gcc-6.2.1/mpfr-3.1.5-bevr3ajxn6an4lk5il456xm35yfsh263/lib/libmpfr.so.4 (0x00007faf10176000)
	libgmp.so.10 => /home/ajstewart/spack/opt/spack/linux-fedora25-x86_64/gcc-6.2.1/gmp-6.1.2-p2wh3r2fbpgd32a6slpig4nkepaofoxj/lib/libgmp.so.10 (0x00007faf0ff00000)
	libm.so.6 => /lib64/libm.so.6 (0x00007faf0fbda000)
	libc.so.6 => /lib64/libc.so.6 (0x00007faf0f812000)
	/lib64/ld-linux-x86-64.so.2 (0x000055db05ac8000)
```
But adding the configure option would be simple, so I'll submit a PR and you can see if it helps on Comet.

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/mpc/package.py b/var/spack/repos/builtin/packages/mpc/package.py
--- a/var/spack/repos/builtin/packages/mpc/package.py
+++ b/var/spack/repos/builtin/packages/mpc/package.py
@@ -35,11 +35,18 @@ class Mpc(AutotoolsPackage):
     version('1.0.3', 'd6a1d5f8ddea3abd2cc3e98f58352d26')
     version('1.0.2', '68fadff3358fb3e7976c7a398a0af4c3')
 
-    depends_on('gmp')   # mpir is a drop-in replacement for this
-    depends_on('mpfr')  # Could also be built against mpir
+    depends_on('gmp@4.3.2:')   # mpir is a drop-in replacement for this
+    depends_on('mpfr@2.4.2:')  # Could also be built against mpir
 
     def url_for_version(self, version):
         if version < Version("1.0.1"):
             return "http://www.multiprecision.org/mpc/download/mpc-%s.tar.gz" % version
         else:
             return "https://ftp.gnu.org/gnu/mpc/mpc-%s.tar.gz" % version
+
+    def configure_args(self):
+        spec = self.spec
+        return [
+            '--with-mpfr={0}'.format(spec['mpfr'].prefix),
+            '--with-gmp={0}'.format(spec['gmp'].prefix)
+        ]


Test patch:
Repository: spack/spack

Issue:
Better default for spack module refresh
When you run `spack module refresh --help`, it queries `spack.modules.module_types` to get a list of choices for `--module-type`. But regardless of whether or not `tcl` is in your list of enabled modules, the default is always `tcl`. We should default to whatever is enabled. If there are multiple module types enabled, then we should refresh all of them.


Discussion:

Resolving patch:
diff --git a/lib/spack/spack/cmd/common/arguments.py b/lib/spack/spack/cmd/common/arguments.py
--- a/lib/spack/spack/cmd/common/arguments.py
+++ b/lib/spack/spack/cmd/common/arguments.py
@@ -79,8 +79,10 @@ def _specs(self, **kwargs):
     help='constraint to select a subset of installed packages')
 
 _arguments['module_type'] = Args(
-    '-m', '--module-type', help='type of module files',
-    default='tcl', choices=spack.modules.module_types)
+    '-m', '--module-type',
+    choices=spack.modules.module_types.keys(),
+    default=spack.modules.module_types.keys()[0],
+    help='type of module files [default: %(default)s]')
 
 _arguments['yes_to_all'] = Args(
     '-y', '--yes-to-all', action='store_true', dest='yes_to_all',


Test patch:
Repository: spack/spack

Issue:
scotch build issue on bg-q (cross-compiling env)
On `bg-q` building `scotch_6.0.4` gives : 

```bash

$ spack install -v --keep-stage scotch -shared
.........
/gpfs/mira-home/kumbhar/spack/lib/spack/env/xl/xlc -O3 -DCOMMON_RANDOM_FIXED_SEED -DSCOTCH_DETERMINISTIC -DSCOTCH_RENAME -qstrict -qlanglvl=extc99 -s -D_ALL_SOURCE -DCOMMON_FILE_COMPRESS_GZ -DCOMMON_PTHREAD  -c vgraph_separate_st.c -o vgraph_separate_st.o
./dummysizes library.h scotch.h
./dummysizes library_f.h scotchf.h
make[2]: *** [scotchf.h] Illegal instruction (core dumped)
make[2]: *** Waiting for unfinished jobs....
```
Obvious issue : trying to run compute node exe on login node. Note that the provided `Makefile.inc` build the package properly : 
```
Make.inc/Makefile.inc.ppca2_ibm_bgq
```

P.S. I am trying to build set of packages on bg-q in cross-compiling environment. Will create issues as I encounter the failures. Will update these later possibly with patches.


Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/scotch/package.py b/var/spack/repos/builtin/packages/scotch/package.py
--- a/var/spack/repos/builtin/packages/scotch/package.py
+++ b/var/spack/repos/builtin/packages/scotch/package.py
@@ -56,6 +56,10 @@ class Scotch(Package):
     depends_on('mpi', when='+mpi')
     depends_on('zlib', when='+compression')
 
+    # NOTE: In cross-compiling environment parallel build
+    # produces weird linker errors.
+    parallel = False
+
     # NOTE: Versions of Scotch up to version 6.0.0 don't include support for
     # building with 'esmumps' in their default packages.  In order to enable
     # support for this feature, we must grab the 'esmumps' enabled archives
@@ -140,9 +144,14 @@ def configure(self):
             ldflags.append('-L%s -lz' % (self.spec['zlib'].prefix.lib))
 
         cflags.append('-DCOMMON_PTHREAD')
+
+        # NOTE: bg-q platform needs -lpthread (and not -pthread)
+        # otherwise we get illegal instruction error during runtime
         if self.spec.satisfies('platform=darwin'):
             cflags.append('-DCOMMON_PTHREAD_BARRIER')
             ldflags.append('-lm -pthread')
+        elif self.spec.satisfies('platform=bgq'):
+            ldflags.append('-lm -lrt -lpthread')
         else:
             ldflags.append('-lm -lrt -pthread')
 


Test patch:
Repository: spack/spack

Issue:
gl2ps build error
gl2ps build fails because it depends on cmake. Better yet, it should become a CMakePackage.



Discussion:
Feel free to submit a PR!

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/gl2ps/package.py b/var/spack/repos/builtin/packages/gl2ps/package.py
--- a/var/spack/repos/builtin/packages/gl2ps/package.py
+++ b/var/spack/repos/builtin/packages/gl2ps/package.py
@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gl2ps(Package):
+class Gl2ps(CMakePackage):
     """GL2PS is a C library providing high quality vector output for any
     OpenGL application."""
 
@@ -34,10 +34,37 @@ class Gl2ps(Package):
 
     version('1.3.9', '377b2bcad62d528e7096e76358f41140')
 
-    depends_on("libpng")
+    variant('png',  default=True, description='Enable PNG support')
+    variant('zlib', default=True, description='Enable compression using ZLIB')
 
-    def install(self, spec, prefix):
-        cmake('.', *std_cmake_args)
+    depends_on('cmake@2.4:', type='build')
 
-        make()
-        make("install")
+    # TODO: Add missing dependencies on OpenGL/Mesa and LaTeX
+
+    # X11 libraries:
+    depends_on('libice')
+    depends_on('libsm')
+    depends_on('libxau')
+    depends_on('libxdamage')
+    depends_on('libxdmcp')
+    depends_on('libxext')
+    depends_on('libxfixes')
+    depends_on('libxi')
+    depends_on('libxmu')
+    depends_on('libxt')
+    depends_on('libxxf86vm')
+    depends_on('libxcb')
+    depends_on('libdrm')
+    depends_on('expat')
+
+    depends_on('libpng', when='+png')
+    depends_on('zlib',   when='+zlib')
+
+    def variant_to_bool(self, variant):
+        return 'ON' if variant in self.spec else 'OFF'
+
+    def cmake_args(self):
+        return [
+            '-DENABLE_PNG={0}'.format(self.variant_to_bool('+png')),
+            '-DENABLE_ZLIB={0}'.format(self.variant_to_bool('+zlib')),
+        ]


Test patch:
Repository: spack/spack

Issue:
spack fails to build patch@2.7.5 because of symlink problems
Hi all,

yesterday I did a fresh spack install on a virtual machine with a minimal OS installation (CentOS 7 with only few packages, including Python 2.7, git, curl and GCC 4.8.5) that still fulfills the minimal requirement for spack.

The first thing that I noticed is, that I need to build patch, but this already failed:

```
[sfux@develop02 ~]$ spack purge -a
[sfux@develop02 ~]$ spack find
==> 0 installed packages.
[sfux@develop02 ~]$ spack install patch
==> Installing patch
==> Fetching http://ftp.gnu.org/gnu/patch/patch-2.7.5.tar.xz
######################################################################## 100.0%
==> Staging archive: /local/cluster/spack/var/spack/stage/patch-2.7.5-3jgpfxlxg35dn4l4duohkkoombxag4oo/patch-2.7.5.tar.xz
==> Created stage in /local/cluster/spack/var/spack/stage/patch-2.7.5-3jgpfxlxg35dn4l4duohkkoombxag4oo
==> Ran patch() for patch
==> Building patch [AutotoolsPackage]
==> Executing phase : 'autoreconf'
==> Executing phase : 'configure'
==> Executing phase : 'build'
==> Error: ProcessError: Command exited with status 2:
    'make' '-j8'
/local/cluster/spack/lib/spack/spack/build_systems/autotools.py:275, in build:
     270      def build(self, spec, prefix):
     271          """Makes the build targets specified by
     272          :py:attr:``~.AutotoolsPackage.build_targets``
     273          """
     274          with working_dir(self.build_directory):
  >> 275              inspect.getmodule(self).make(*self.build_targets)

See build log for details:
  /local/scratch/sfux/spack-stage/spack-stage-DFYEr8/patch-2.7.5/spack-build.out
```

Looking at the error message:

```
make: GNUmakefile: Too many levels of symbolic links
make: stat: GNUmakefile: Too many levels of symbolic links
make: *** No rule to make target `GNUmakefile'.  Stop.
==> Error: ProcessError: Command exited with status 2:
```

it seems that there is a symlink pointing to itself:

lrwxrwxrwx 1 sfux sfux-group    105 Mar  9 09:55 GNUmakefile -> /local/cluster/spack/var/spack/stage/patch-2.7.5-3jgpfxlxg35dn4l4duohkkoombxag4oo/patch-2.7.5/GNUmakefile


Any ideas ?

Please let me know what additional information I can provide to resolve this issue.

Best regards

Sam


Discussion:
I can reproduce the problem, which is similar to other we have seen with recent versions of autotools. PR incoming

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/patch/package.py b/var/spack/repos/builtin/packages/patch/package.py
--- a/var/spack/repos/builtin/packages/patch/package.py
+++ b/var/spack/repos/builtin/packages/patch/package.py
@@ -35,3 +35,5 @@ class Patch(AutotoolsPackage):
     url      = "http://ftp.gnu.org/gnu/patch/patch-2.7.5.tar.xz"
 
     version('2.7.5', 'e3da7940431633fb65a01b91d3b7a27a')
+
+    build_directory = 'spack-build'


Test patch:
Repository: spack/spack

Issue:
bison doesn't find m4 at run time
While building `flex`, I had `bison` fail because it could not execute `m4`. The reason was that I had uninstalled the `m4` package (via Spack) which `bison` installed as its build dependency. Then, `bison` failed since this `m4` executable did not exist any more.

I think `m4` needs to be a run-time dependency of `bison` as well.


Discussion:
Feel free to contribute a PR. Should be an easy change.

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/autoconf/package.py b/var/spack/repos/builtin/packages/autoconf/package.py
--- a/var/spack/repos/builtin/packages/autoconf/package.py
+++ b/var/spack/repos/builtin/packages/autoconf/package.py
@@ -36,7 +36,9 @@ class Autoconf(AutotoolsPackage):
     version('2.59', 'd4d45eaa1769d45e59dcb131a4af17a0')
     version('2.13', '9de56d4a161a723228220b0f425dc711')
 
-    depends_on('m4@1.4.6:',   type='build')
+    # Note: m4 is not a pure build-time dependency of autoconf. m4 is
+    # needed when autoconf runs, not only when autoconf is built.
+    depends_on('m4@1.4.6:', type=('build', 'run'))
 
     build_directory = 'spack-build'
 


Test patch:
Repository: spack/spack

Issue:
spack compiler find on Cray says no new compilers found
Deleted my compilers.yaml and tried to create a new one but this happens

```┌[mamelara-edison06::spack
└┤[22:52] ➜ spack compiler find
==> Found no new compilers
```

It still writes to compilers.yaml and the yaml configuration looks correct but the output needs to be fixed.



Discussion:
I believe I created this with #2999 - I will work on having a fix tomorrow.

Resolving patch:
diff --git a/lib/spack/spack/cmd/compiler.py b/lib/spack/spack/cmd/compiler.py
--- a/lib/spack/spack/cmd/compiler.py
+++ b/lib/spack/spack/cmd/compiler.py
@@ -95,8 +95,8 @@ def compiler_find(args):
     new_compilers = []
     for c in compilers:
         arch_spec = ArchSpec(None, c.operating_system, c.target)
-        same_specs = spack.compilers.compilers_for_spec(c.spec,
-                                                        arch_spec)
+        same_specs = spack.compilers.compilers_for_spec(
+            c.spec, arch_spec, init_config=False)
 
         if not same_specs:
             new_compilers.append(c)
diff --git a/lib/spack/spack/compilers/__init__.py b/lib/spack/spack/compilers/__init__.py
--- a/lib/spack/spack/compilers/__init__.py
+++ b/lib/spack/spack/compilers/__init__.py
@@ -200,10 +200,11 @@ def supported(compiler_spec):
 
 
 @_auto_compiler_spec
-def find(compiler_spec, scope=None):
+def find(compiler_spec, scope=None, init_config=True):
     """Return specs of available compilers that match the supplied
        compiler spec.  Return an empty list if nothing found."""
-    return [c for c in all_compiler_specs(scope) if c.satisfies(compiler_spec)]
+    return [c for c in all_compiler_specs(scope, init_config)
+            if c.satisfies(compiler_spec)]
 
 
 def all_compilers(scope=None):
@@ -217,16 +218,16 @@ def all_compilers(scope=None):
 
 @_auto_compiler_spec
 def compilers_for_spec(compiler_spec, arch_spec=None, scope=None,
-                       use_cache=True):
+                       use_cache=True, init_config=True):
     """This gets all compilers that satisfy the supplied CompilerSpec.
        Returns an empty list if none are found.
     """
     if use_cache:
-        config = all_compilers_config(scope)
+        config = all_compilers_config(scope, init_config)
     else:
-        config = get_compiler_config(scope)
+        config = get_compiler_config(scope, init_config)
 
-    matches = set(find(compiler_spec, scope))
+    matches = set(find(compiler_spec, scope, init_config))
     compilers = []
     for cspec in matches:
         compilers.extend(get_compilers(cspec, config, arch_spec))


Test patch:
Repository: spack/spack

Issue:
curl: Bugs found in security audit
Spack should probably update accordingly.  See:

http://www.theregister.co.uk/2016/11/25/mozilla_hackers_give_curl_security_audit_tick/



Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/curl/package.py b/var/spack/repos/builtin/packages/curl/package.py
--- a/var/spack/repos/builtin/packages/curl/package.py
+++ b/var/spack/repos/builtin/packages/curl/package.py
@@ -25,14 +25,15 @@
 from spack import *
 
 
-class Curl(Package):
+class Curl(AutotoolsPackage):
     """cURL is an open source command line tool and library for
     transferring data with URL syntax"""
 
     homepage = "http://curl.haxx.se"
     # URL must remain http:// so Spack can bootstrap curl
-    url      = "http://curl.haxx.se/download/curl-7.46.0.tar.bz2"
+    url      = "http://curl.haxx.se/download/curl-7.53.1.tar.bz2"
 
+    version('7.53.1', 'fb1f03a142236840c1a77c035fa4c542')
     version('7.52.1', 'dd014df06ff1d12e173de86873f9f77a')
     version('7.50.3', 'bd177fd6deecce00cfa7b5916d831c5e')
     version('7.50.2', '6e161179f7af4b9f8b6ea21420132719')
@@ -45,13 +46,13 @@ class Curl(Package):
     version('7.43.0', '11bddbb452a8b766b932f859aaeeed39')
     version('7.42.1', '296945012ce647b94083ed427c1877a8')
 
-    depends_on("openssl")
-    depends_on("zlib")
+    depends_on('openssl')
+    depends_on('zlib')
 
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix,
-                  '--with-zlib=%s' % spec['zlib'].prefix,
-                  '--with-ssl=%s' % spec['openssl'].prefix)
+    def configure_args(self):
+        spec = self.spec
 
-        make()
-        make("install")
+        return [
+            '--with-zlib={0}'.format(spec['zlib'].prefix),
+            '--with-ssl={0}'.format(spec['openssl'].prefix),
+        ]


Test patch: