Repository: nvaccess/nvda

Issue:
Enable catalan Braille table included in Liblouis
<!-- Please read the text in this edit field before filling it in.
Please thoroughly read NVDA's wiki article on how to fill in this template, including how to provide the required files.
Issues may be closed if the required information is not present.
https://github.com/nvaccess/nvda/blob/master/devDocs/githubIssueTemplateExplanationAndExamples.md
Please also note that the NVDA project has a Citizen and Contributor Code of Conduct which can be found at https://github.com/nvaccess/nvda/blob/master/CODE_OF_CONDUCT.md. NV Access expects that all contributors and other community members read and abide by the rules set out in this document while participating or contributing to this project. This includes creating or commenting on issues and pull requests. 

Each of the questions and sections below start with multiple hash symbols (#). Place your answers and information on the blank line below each question.
-->

### Is your feature request related to a problem? Please describe.

When using spanish grade 1 Braille table to read text in catalan, some accented characters aren't properly displayed. Liblouis includes a catalan Braille grade 1 table (ca.tbl / ca-g1.ctb), but it is not available from the NVDA Braille settings category.

### Describe the solution you'd like

Registering this table in the brailleTables module should be enough to fix this issue.

### Describe alternatives you've considered
N/A
### Additional context
This request has been made by Sergio Gómez, a member of the spanish community, on this thread: https://groups.google.com/g/nvda-es/c/YSqxy4AxP0g
CC: @quetzatl, @ivnc 


Discussion:

Resolving patch:
diff --git a/source/brailleTables.py b/source/brailleTables.py
--- a/source/brailleTables.py
+++ b/source/brailleTables.py
@@ -1,7 +1,7 @@
 # A part of NonVisual Desktop Access (NVDA)
 # This file is covered by the GNU General Public License.
 # See the file COPYING for more details.
-# Copyright (C) 2008-2021 NV Access Limited, Joseph Lee, Babbage B.V.
+# Copyright (C) 2008-2022 NV Access Limited, Joseph Lee, Babbage B.V.
 
 """Manages information about available braille translation tables.
 """
@@ -63,29 +63,31 @@ def listTables():
 
 #: Maps old table names to new table names for tables renamed in newer versions of liblouis.
 RENAMED_TABLES = {
-	"ar-fa.utb" : "fa-ir-g1.utb",
-	"da-dk-g16.utb":"da-dk-g16.ctb",
-	"da-dk-g18.utb":"da-dk-g18.ctb",
-	"de-de-g0.utb":"de-g0.utb",
-	"de-de-g1.ctb":"de-g1.ctb",
-	"de-de-g2.ctb":"de-g2.ctb",
-	"en-us-comp8.ctb" : "en-us-comp8-ext.utb",
-	"fr-ca-g1.utb":"fr-bfu-comp6.utb",
-	"Fr-Ca-g2.ctb":"fr-bfu-g2.ctb",
+	"ar-fa.utb": "fa-ir-g1.utb",
+	"da-dk-g16.utb": "da-dk-g16.ctb",
+	"da-dk-g18.utb": "da-dk-g18.ctb",
+	"de-de-g0.utb": "de-g0.utb",
+	"de-de-g1.ctb": "de-g1.ctb",
+	"de-de-g2.ctb": "de-g2.ctb",
+	"de-g0-bidi.utb": "de-g0-detailed.utb",
+	"de-g1-bidi.ctb": "de-g1-detailed.ctb",
+	"en-us-comp8.ctb": "en-us-comp8-ext.utb",
+	"fr-ca-g1.utb": "fr-bfu-comp6.utb",
+	"Fr-Ca-g2.ctb": "fr-bfu-g2.ctb",
 	"gr-bb.ctb": "grc-international-en.utb",
-	"gr-gr-g1.utb":"el.ctb",
+	"gr-gr-g1.utb": "el.ctb",
 	"he.ctb": "he-IL-comp8.utb",
-	"hr.ctb":"hr-comp8.utb",
-	"mn-MN.utb":"mn-MN-g1.utb",
+	"hr.ctb": "hr-comp8.utb",
+	"mn-MN.utb": "mn-MN-g1.utb",
 	"nl-BE-g0.utb": "nl-NL-g0.utb",
-	"nl-NL-g1.ctb":"nl-NL-g0.utb",
-	"no-no.ctb":"no-no-8dot.utb",
-	"no-no-comp8.ctb":"no-no-8dot.utb",
-	"ru-compbrl.ctb":"ru.ctb",
+	"nl-NL-g1.ctb": "nl-NL-g0.utb",
+	"no-no.ctb": "no-no-8dot.utb",
+	"no-no-comp8.ctb": "no-no-8dot.utb",
+	"ru-compbrl.ctb": "ru.ctb",
 	"ru-ru-g1.utb": "ru-litbrl-detailed.utb",
-	"sk-sk-g1.utb":"sk-g1.ctb",
-	"UEBC-g1.ctb":"en-ueb-g1.ctb",
-	"UEBC-g2.ctb":"en-ueb-g2.ctb",
+	"sk-sk-g1.utb": "sk-g1.ctb",
+	"UEBC-g1.ctb": "en-ueb-g1.ctb",
+	"UEBC-g2.ctb": "en-ueb-g2.ctb",
 	"vi-g1.ctb": "vi-vn-g1.ctb",
 }
 
@@ -128,6 +130,9 @@ def listTables():
 addTable("bg.utb", _("Bulgarian grade 1"))
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
+addTable("ca-g1.ctb", _("Catalan grade 1"))
+# Translators: The name of a braille table displayed in the
+# braille settings dialog.
 addTable("ckb-g1.ctb", _("Central Kurdish grade 1"))
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
@@ -161,6 +166,9 @@ def listTables():
 addTable("da-dk-g28.ctb", _("Danish 8 dot grade 2"), contracted=True)
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
+addTable("de-comp6.utb", _("German 6 dot computer braille"))
+# Translators: The name of a braille table displayed in the
+# braille settings dialog.
 addTable("de-de-comp8.ctb", _("German 8 dot computer braille"))
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
@@ -168,14 +176,14 @@ def listTables():
 
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
-addTable("de-g0-bidi.utb", _("German grade 0 (detailed)"))
+addTable("de-g0-detailed.utb", _("German grade 0 (detailed)"))
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
 addTable("de-g1.ctb", _("German grade 1"), input=False)
 
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
-addTable("de-g1-bidi.ctb", _("German grade 1 (detailed)"))
+addTable("de-g1-detailed.ctb", _("German grade 1 (detailed)"))
 # Translators: The name of a braille table displayed in the
 # braille settings dialog.
 addTable("de-g2.ctb", _("German grade 2"), contracted=True, input=False)


Test patch: