Repository: aio-libs/aiohttp

Issue:
tests_require: add trustme
It is required since https://github.com/aio-libs/aiohttp/pull/3487.

<!-- Thank you for your contribution! -->

## What do these changes do?

<!-- Please give a short brief about these changes. -->

## Are there changes in behavior for the user?

<!-- Outline any notable behaviour for the end users. -->

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this change? -->

## Checklist

- [ ] I think the code is well written
- [ ] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names. 
- [ ] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
  * if you don't have an `issue_id` change it to the pr id after creating the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
    * `.misc`: A ticket has been closed, but it is not of interest to users.
  * Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."



Discussion:
I've missed this.
How do you use `test_require`? Do you run `python setup.py test`?
# [Codecov](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=h1) Report
> Merging [#3518](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=desc) into [master](https://codecov.io/gh/aio-libs/aiohttp/commit/a86af67e92597ee3d0d5bb546531d35d23420d39?src=pr&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/graphs/tree.svg?width=650&token=LJn22G3rd7&height=150&src=pr)](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
- Coverage   97.92%   97.54%   -0.38%     
==========================================
  Files          44       44              
  Lines        8562     8561       -1     
  Branches     1381     1380       -1     
==========================================
- Hits         8384     8351      -33     
- Misses         72      101      +29     
- Partials      106      109       +3
```


| [Impacted Files](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [aiohttp/locks.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC9sb2Nrcy5weQ==) | `92.85% <0%> (-7.15%)` | :arrow_down: |
| [aiohttp/http\_parser.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC9odHRwX3BhcnNlci5weQ==) | `93.11% <0%> (-4.82%)` | :arrow_down: |
| [aiohttp/http\_writer.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC9odHRwX3dyaXRlci5weQ==) | `95.28% <0%> (-2.84%)` | :arrow_down: |
| [aiohttp/frozenlist.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC9mcm96ZW5saXN0LnB5) | `97.87% <0%> (-2.13%)` | :arrow_down: |
| [aiohttp/helpers.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC9oZWxwZXJzLnB5) | `95.98% <0%> (-0.76%)` | :arrow_down: |
| [aiohttp/test\_utils.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC90ZXN0X3V0aWxzLnB5) | `99.03% <0%> (-0.33%)` | :arrow_down: |
| [aiohttp/streams.py](https://codecov.io/gh/aio-libs/aiohttp/pull/3518/diff?src=pr&el=tree#diff-YWlvaHR0cC9zdHJlYW1zLnB5) | `98.46% <0%> (-0.26%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=footer). Last update [a86af67...c5693e7](https://codecov.io/gh/aio-libs/aiohttp/pull/3518?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> How do you use test_require? Do you run python setup.py test?

I do. And as long as `tests_require` is specified, it should be complete.

Actually, there are more missing: pytest-mock, pytest-cov trustme and brotlipy.
@dotlambda the thing is that using this mechanism is discouraged, we don't really use it and should probably just remove that completely.
@webknjaz agree 
We need either use `test_requires` in our Travis CI or drop this facility.
I'm inclining to removal.
No, we don't use that at all. But we should probably consider it a breaking change for ones who use it so not backport. Maybe a deprecation warning though.
I don't have a problem with removing it.
Our CI is broken now.
Please keep the PR open as the reminder.
I'll close the PR after preparing a new one for dropping `python setup.py test` command.
#3752 drops `setup.py test` support

Resolving patch:
diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -80,18 +80,6 @@ def read(f):
     return (here / f).read_text("utf-8").strip()
 
 
-NEEDS_PYTEST = {"pytest", "test"}.intersection(sys.argv)
-pytest_runner = ["pytest-runner"] if NEEDS_PYTEST else []
-
-tests_require = [
-    "pytest",
-    "gunicorn",
-    "pytest-timeout",
-    "async-generator",
-    "pytest-xdist",
-]
-
-
 args = dict(
     name="aiohttp",
     version=version,
@@ -144,8 +132,6 @@ def read(f):
             "cchardet",
         ],
     },
-    tests_require=tests_require,
-    setup_requires=pytest_runner,
     include_package_data=True,
     ext_modules=extensions,
     cmdclass=dict(build_ext=ve_build_ext),


Test patch: