Repository: nvaccess/nvda

Issue:
Tether Braille: "Automatically" does not follow mouse when (Review cursor) "Follow mouse cursor is checked.
<!--
Please thoroughly read NVDA's wiki article on how to fill in this template, including how to provide the required files.
Issues may be closed if the required information is not present.
https://github.com/nvaccess/nvda/wiki/Github-issue-template-explanation-and-examples
-->

### Steps to reproduce:
1) In NVDA's Braille settings, set "Tether Braille" to "Automatically" (this is set by default).
2) In NVDA's Mouse settings, check "Enable mouse tracking" (This is set by default).
3) In NVDA's Review cursor settings, check "Follow mouse cursor".
3) Apply the changes
4) Move the mouse over something (say the heading of this issue).  NVDA reads the line under the mouse.
5) Press numpad8 / NVDA+shift+. to read the current line in review.  NVDA reads the line under the mouse.
6) Read the line on the Braille display.

### Actual behavior:

At step 6, as reported by a Spanish speaking user, Sergio via email, the text is not updated on the Braille display as it should be.  I don't currently have a Braille display to test with but the Braille viewer does not update with that text.

### Expected behavior:

The Braille display should update with the text under the mouse as it is now the location of the review cursor.

### System configuration
#### NVDA installed/portable/running from source:

#### NVDA version:


NVDA 2020.2 (Sergio) and NVDA alpha-20763,1ef4dfb0 (me), both installed.

#### Windows version:

Windows 10.  I have Windows 10 (64-bit) Version: 1903 Build 18362 - I don't have Sergio's exact build.

#### Name and version of other software in use when reproducing the issue:

#### Other information about your system:

### Other questions
#### Does the issue still occur after restarting your computer?

Yes

#### Have you tried any other versions of NVDA? If so, please report their behaviors.

#### If addons are disabled, is your problem still occuring?

Yes

#### Did you try to run the COM registry fixing tool in NVDA menu / tools?
No


Discussion:
I think that the read current line under review cursor command doesn't toggle tethering. There is also much to say that when review cursor follows mouse is on, everything that's reported by moving the mouse trigger auto tethering.

Resolving patch:
diff --git a/source/globalCommands.py b/source/globalCommands.py
--- a/source/globalCommands.py
+++ b/source/globalCommands.py
@@ -1401,7 +1401,7 @@ def script_review_currentLine(self,gesture):
 		info=api.getReviewPosition().copy()
 		info.expand(textInfos.UNIT_LINE)
 		# Explicitly tether here
-		braille.handler.setTether(braille.handler.TETHER_REVIEW, auto=True)
+		braille.handler.handleReviewMove(shouldAutoTether=True)
 		scriptCount=scriptHandler.getLastScriptRepeatCount()
 		if scriptCount==0:
 			speech.speakTextInfo(info, unit=textInfos.UNIT_LINE, reason=controlTypes.OutputReason.CARET)
@@ -1478,7 +1478,7 @@ def script_review_currentWord(self,gesture):
 		info=api.getReviewPosition().copy()
 		info.expand(textInfos.UNIT_WORD)
 		# Explicitly tether here
-		braille.handler.setTether(braille.handler.TETHER_REVIEW, auto=True)
+		braille.handler.handleReviewMove(shouldAutoTether=True)
 		scriptCount=scriptHandler.getLastScriptRepeatCount()
 		if scriptCount==0:
 			speech.speakTextInfo(info, reason=controlTypes.OutputReason.CARET, unit=textInfos.UNIT_WORD)
@@ -1566,7 +1566,7 @@ def script_review_currentCharacter(self,gesture):
 		info=api.getReviewPosition().copy()
 		info.expand(textInfos.UNIT_CHARACTER)
 		# Explicitly tether here
-		braille.handler.setTether(braille.handler.TETHER_REVIEW, auto=True)
+		braille.handler.handleReviewMove(shouldAutoTether=True)
 		scriptCount=scriptHandler.getLastScriptRepeatCount()
 		if scriptCount==0:
 			speech.speakTextInfo(info, unit=textInfos.UNIT_CHARACTER, reason=controlTypes.OutputReason.CARET)


Test patch: