Repository: openshift/openshift-ansible

Issue:
Origin containerized install requires etcd from registry.access.redhat.com
#### Description
Origin containerized install pulls down an image from Red Hat's internal registry (registry.access.redhat.com)

##### Version

```
Latest
```

##### Steps To Reproduce
1. Deploy Origin containerized
2. Check etcd container repo


##### Expected Results
Pull etcd image from https://hub.docker.com/u/openshift/ as others pods instead the registry.access.redhat.com one.

##### Additional Information
* Forcing the etcd container to be pulled from a F26 one seems to work

```
deployment_type=origin
containerized=true
openshift_release=v3.6
openshift_image_tag=v3.6.1

# the following was needed as 3.6.1 rpms weren't yet available
openshift_pkg_version=-3.1.0.0

osm_etcd_image=registry.fedoraproject.org/f26/etcd
```



Discussion:
Same happens to me.

```
openshift_release=v3.7
openshift_image_tag=v3.7.0-rc.0
```

```
openshift-ansible-3.7.0-0.195.0
```
Looks like this [commit e760ccf93410c94f174a694f3d6bb02f5a5c82e9](https://github.com/openshift/openshift-ansible/pull/6010/commits/e760ccf93410c94f174a694f3d6bb02f5a5c82e9) is suspected. 
But why the `openshift_enterprise.yaml` is used since we both have `deployment_type=origin`
We can use registry.fedoraproject.org/f26/etcd as the default for origin installs but we cannot ensure stepwise upgrades so we need to modify the etcd upgrade playbooks to simply update to the latest version of the image. Otherwise this is just changing the default image in the openshift_facts module.
Shall we create an etcd container for CentOS and host it in the docker hub as we do with some other pods https://hub.docker.com/u/openshift/?
hmm, but I'm configuring option `openshift_use_system_containers=False` so that `etcd_image` should be ignored, right?
@bamachrn can we ensure that a full stack of origin containers, based on CentOS-PaaS-SIG content is available at registry.centos.org ? 

cc @detiber @sdodson @tdawson  
> We can use registry.fedoraproject.org/f26/etcd as the default for origin installs but we cannot ensure stepwise upgrades so we need to modify the etcd upgrade playbooks to simply update to the latest version of the image. Otherwise this is just changing the default image in the openshift_facts module.

We opened an issue to see if we can do something like `registry.fedoraproject.org/latest/etcd`: https://pagure.io/atomic-wg/issue/376

Resolving patch:
diff --git a/roles/openshift_facts/library/openshift_facts.py b/roles/openshift_facts/library/openshift_facts.py
--- a/roles/openshift_facts/library/openshift_facts.py
+++ b/roles/openshift_facts/library/openshift_facts.py
@@ -1630,7 +1630,6 @@ def set_container_facts_if_unset(facts):
         cli_image = master_image
         node_image = 'openshift3/node'
         ovs_image = 'openshift3/openvswitch'
-        etcd_image = 'registry.access.redhat.com/rhel7/etcd'
         pod_image = 'openshift3/ose-pod'
         router_image = 'openshift3/ose-haproxy-router'
         registry_image = 'openshift3/ose-docker-registry'
@@ -1640,7 +1639,6 @@ def set_container_facts_if_unset(facts):
         cli_image = master_image
         node_image = 'openshift/node'
         ovs_image = 'openshift/openvswitch'
-        etcd_image = 'registry.access.redhat.com/rhel7/etcd'
         pod_image = 'openshift/origin-pod'
         router_image = 'openshift/origin-haproxy-router'
         registry_image = 'openshift/origin-docker-registry'
@@ -1667,8 +1665,6 @@ def set_container_facts_if_unset(facts):
         facts['common']['registry_image'] = registry_image
     if 'deployer_image' not in facts['common']:
         facts['common']['deployer_image'] = deployer_image
-    if 'etcd' in facts and 'etcd_image' not in facts['etcd']:
-        facts['etcd']['etcd_image'] = etcd_image
     if 'master' in facts and 'master_image' not in facts['master']:
         facts['master']['master_image'] = master_image
         facts['master']['master_system_image'] = master_image


Test patch: