Repository: cloud-custodian/cloud-custodian

Issue:
EC2 Security Groups Filters doesn't work
```
(custodian) root@ip-172-31-1-84:~# custodian schema aws.security-group.filters.ingress

Help
----
...
.. code-block:: yaml

  - type: ingress
    Ports: [22, 3389]
    Cidr:
      values:
        - "0.0.0.0/0"
        - "::/0"
      op: in

...
(custodian) root@ip-172-31-1-84:~# aws ec2 describe-security-groups
{
    "SecurityGroups": [
        {
            "Description": "Open RDP",
            "GroupName": "sgOpenRDP",
            "IpPermissions": [
                {
                    "FromPort": 3389,
                    "IpProtocol": "tcp",
                    "IpRanges": [
                        {
                            "CidrIp": "0.0.0.0/0",
                            "Description": ""
                        }
                    ],
                    "Ipv6Ranges": [],
                    "PrefixListIds": [],
                    "ToPort": 3389,
                    "UserIdGroupPairs": []
                }
            ],
            "OwnerId": "335325095793",
            "GroupId": "sg-076a0b1116720aeb0",
            "IpPermissionsEgress": [
                {
                    "IpProtocol": "-1",
                    "IpRanges": [
                        {
                            "CidrIp": "0.0.0.0/0"
                        }
                    ],
                    "Ipv6Ranges": [],
                    "PrefixListIds": [],
                    "UserIdGroupPairs": []
                }
            ],
            "Tags": [
                {
                    "Key": "Name",
                    "Value": "test"
                }
            ],
            "VpcId": "vpc-0406a0f592f5e9164"
        }
    ]
}
(custodian) root@ip-172-31-1-84:~# cat has_sec_group_rdp_open.yml
policies:
  - name: has_sec_group_rdp_open
    resource: security-group
    filters:
      - type: ingress
        Ports: [3389]
        Cidr:
          values:
            - 0.0.0.0/0
            - ::/0
          op: in
(custodian) root@ip-172-31-1-84:~# custodian run --output-dir=. has_sec_group_rdp_open.yml
2019-01-21 09:32:58,743: custodian.policy:INFO policy: has_sec_group_rdp_open resource:security-group region:us-east-1 count:0 time:0.22
(custodian) root@ip-172-31-1-84:~# cat has_sec_group_rdp_open/resources.json
[]
```


Discussion:
the doc here is wrong it should be `value:` not `values`

Resolving patch:
diff --git a/c7n/resources/vpc.py b/c7n/resources/vpc.py
--- a/c7n/resources/vpc.py
+++ b/c7n/resources/vpc.py
@@ -866,11 +866,12 @@ class SGPermission(Filter):
       - type: ingress
         Ports: [22, 3389]
         Cidr:
-          values:
+          value:
             - "0.0.0.0/0"
             - "::/0"
           op: in
 
+
     """
 
     perm_attrs = set((


Test patch:
diff --git a/tests/data/placebo/test_iam_user_access_key_multi/iam.ListAccessKeys_1.json b/tests/data/placebo/test_iam_user_access_key_multi/iam.ListAccessKeys_1.json
--- a/tests/data/placebo/test_iam_user_access_key_multi/iam.ListAccessKeys_1.json
+++ b/tests/data/placebo/test_iam_user_access_key_multi/iam.ListAccessKeys_1.json
@@ -16,21 +16,6 @@
                     "second": 26,
                     "microsecond": 0
                 }
-            },
-            {
-                "UserName": "kapil",
-                "AccessKeyId": "AKIAJYQQRLIX6ZMMRXQQ",
-                "Status": "Active",
-                "CreateDate": {
-                    "__class__": "datetime",
-                    "year": 2018,
-                    "month": 10,
-                    "day": 28,
-                    "hour": 14,
-                    "minute": 7,
-                    "second": 57,
-                    "microsecond": 0
-                }
             }
         ],
         "IsTruncated": false,