Repository: oppia/oppia

Issue:
Broken image icon displayed when there are no uploaded images
```
What steps will reproduce the problem?
1. Create a new exploration
2. In a state's content editor, try to add a new image
3. Because there aren't any uploaded images yet, a broken image icon is 
displayed

What is the expected output? What do you see instead?
I expect to see nothing since there are no uploaded images, instead I see a 
broken image icon.

What operating system are you using?
Mac OSX, latest version of Chrome


Please provide any additional information below.
Screenshot attached.


```

Original issue reported on code.google.com by `amitdeut...@google.com` on 10 Mar 2014 at 3:56

Attachments:
- [brokenimage.png](https://storage.googleapis.com/google-code-attachments/oppia/issue-131/comment-0/brokenimage.png)



Discussion:
```
I am seeing brokenimage icon after I have uploaded files, apparently. It 
sometimes takes more than a couple of attempts to add a file - am I being 
impatient ?
```

Original comment by `paulmart...@gmail.com` on 12 Mar 2014 at 6:10

Original comment by `s...@seanlip.org` on 19 Apr 2014 at 2:10
- Added labels: **Difficulty-Easy**

```
Update: this appears to be fixed (in that the broken image icon doesn't show 
up), but it would be nice to have a line of italicized text in its place saying 
something like "No image selected." Currently the space is just blank.
```

Original comment by `s...@seanlip.org` on 5 Dec 2014 at 9:25

Original comment by `s...@seanlip.org` on 30 Jan 2015 at 8:48

```
FYI: The broken image still shows up.
```

Original comment by `sbhow...@google.com` on 11 Feb 2015 at 5:05

```
Oddly enough, this seems to have been fixed on Aug 4, 2014: see changes made to 
filepath_editor.html here:

    https://code.google.com/p/oppia/source/detail?r=9f4fa8e

Hence, closing.


```

Original comment by `s...@seanlip.org` on 26 Feb 2015 at 5:55
- Changed state: **Fixed**


Resolving patch:
diff --git a/core/feconf.py b/core/feconf.py
--- a/core/feconf.py
+++ b/core/feconf.py
@@ -575,7 +575,6 @@ def get_empty_ratings() -> Dict[str, int]:
 # (i.e. admin) is also 'admin'.
 SYSTEM_COMMITTER_ID = 'admin'
 # Domain name for email address.
-INCOMING_EMAILS_DOMAIN_NAME = 'example.com'
 SYSTEM_EMAIL_ADDRESS = 'system@example.com'
 SYSTEM_EMAIL_NAME = '.'
 ADMIN_EMAIL_ADDRESS = 'testadmin@example.com'
diff --git a/scripts/pre_commit_hook.py b/scripts/pre_commit_hook.py
--- a/scripts/pre_commit_hook.py
+++ b/scripts/pre_commit_hook.py
@@ -49,7 +49,7 @@
 RELEASE_CONSTANTS_FILEPATH: Final = os.path.join(
     '.', 'assets', 'release_constants.json')
 KEYS_UPDATED_IN_FECONF: Final = [
-    b'INCOMING_EMAILS_DOMAIN_NAME', b'ADMIN_EMAIL_ADDRESS',
+    b'ADMIN_EMAIL_ADDRESS',
     b'SYSTEM_EMAIL_ADDRESS', b'NOREPLY_EMAIL_ADDRESS', b'CAN_SEND_EMAILS',
     b'CAN_SEND_EDITOR_ROLE_EMAILS', b'CAN_SEND_FEEDBACK_MESSAGE_EMAILS',
     b'CAN_SEND_SUBSCRIPTION_EMAILS', b'DEFAULT_EMAIL_UPDATES_PREFERENCE',


Test patch:
diff --git a/core/tests/release_sources/feconf.txt b/core/tests/release_sources/feconf.txt
--- a/core/tests/release_sources/feconf.txt
+++ b/core/tests/release_sources/feconf.txt
@@ -20,8 +20,7 @@ CURRENT_COLLECTION_SCHEMA_VERSION = 4
 # The current version of story contents dict in the story schema.
 CURRENT_STORY_CONTENTS_SCHEMA_VERSION = 5
 
-INCOMING_EMAILS_DOMAIN_NAME = ''
-ADMIN_EMAIL_ADDRESS = 'adm@example.com'
+ADMIN_EMAIL_ADDRESS = ''
 SYSTEM_EMAIL_ADDRESS = 'sys@example.com'
 NOREPLY_EMAIL_ADDRESS = 'norep@example.com'
 
diff --git a/core/tests/release_sources/feconf_updates_with_extra_line.config b/core/tests/release_sources/feconf_updates_with_extra_line.config
--- a/core/tests/release_sources/feconf_updates_with_extra_line.config
+++ b/core/tests/release_sources/feconf_updates_with_extra_line.config
@@ -1,5 +1,4 @@
 EXTRA_KEY = 'extra'
-INCOMING_EMAILS_DOMAIN_NAME = 'inc@example.com'
 ADMIN_EMAIL_ADDRESS = 'adm@example.com'
 SYSTEM_EMAIL_ADDRESS = 'sys@example.com'
 NOREPLY_EMAIL_ADDRESS = 'norep@example.com'
diff --git a/core/tests/release_sources/invalid_feconf_updates.config b/core/tests/release_sources/invalid_feconf_updates.config
--- a/core/tests/release_sources/invalid_feconf_updates.config
+++ b/core/tests/release_sources/invalid_feconf_updates.config
@@ -1,5 +1,4 @@
 INVALID_KEY: 'invalid'
-INCOMING_EMAILS_DOMAIN_NAME = 'inc@example.com'
 ADMIN_EMAIL_ADDRESS = 'adm@example.com'
 SYSTEM_EMAIL_ADDRESS = 'sys@example.com'
 NOREPLY_EMAIL_ADDRESS = 'norep@example.com'
diff --git a/core/tests/release_sources/valid_feconf_updates.config b/core/tests/release_sources/valid_feconf_updates.config
--- a/core/tests/release_sources/valid_feconf_updates.config
+++ b/core/tests/release_sources/valid_feconf_updates.config
@@ -1,4 +1,3 @@
-INCOMING_EMAILS_DOMAIN_NAME = 'oppia.org'
 ADMIN_EMAIL_ADDRESS = 'adm@example.com'
 SYSTEM_EMAIL_ADDRESS = 'sys@example.com'
 NOREPLY_EMAIL_ADDRESS = 'norep@example.com'
diff --git a/scripts/release_scripts/update_configs_test.py b/scripts/release_scripts/update_configs_test.py
--- a/scripts/release_scripts/update_configs_test.py
+++ b/scripts/release_scripts/update_configs_test.py
@@ -284,8 +284,8 @@ def test_changes_are_applied_to_config(self) -> None:
         with utils.open_file(MOCK_LOCAL_FECONF_PATH, 'r') as f:
             original_text = f.read()
         expected_text = original_text.replace(
-            'INCOMING_EMAILS_DOMAIN_NAME = \'\'',
-            'INCOMING_EMAILS_DOMAIN_NAME = \'oppia.org\'')
+            'ADMIN_EMAIL_ADDRESS = \'\'',
+            'ADMIN_EMAIL_ADDRESS = \'adm@example.com\'')
         try:
             update_configs.apply_changes_based_on_config(
                 MOCK_LOCAL_FECONF_PATH,