Repository: ansible/ansible-modules-extras

Issue:
Redshift module missing supported machine types in a dictionary
<!--- Verify first that your issue/request is not already reported in GitHub -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
 - Bug Report
 

##### COMPONENT NAME
<!--- Name of the plugin/module/task -->
ansible/redshift 

##### ANSIBLE VERSION
<!--- Paste verbatim output from “ansible --version” between quotes below -->
latest dev branch
##### CONFIGURATION
<!---
Mention any settings you have changed/added/removed in ansible.cfg
(or using the ANSIBLE_* environment variables).
-->



##### OS / ENVIRONMENT
<!---
Mention the OS you are running Ansible from, and the OS you are
managing, or say “N/A” for anything that is not platform-specific.
-->



##### SUMMARY
<!--- Explain the problem briefly -->

Supported machine types in a dictionary are not relevant .
Missing machine type for : 'dc1.large'




##### STEPS TO REPRODUCE
<!---
For bugs, show exactly how to reproduce the problem.
For new features, show how the feature would be used.
-->

<!--- Paste example playbooks or commands between quotes below -->
```

```

<!--- You can also paste gist.github.com links for larger files -->

##### EXPECTED RESULTS
<!--- What did you expect to happen when running the steps above? -->

##### ACTUAL RESULTS
<!--- What actually happened? If possible run with high verbosity (-vvvv) -->

<!--- Paste verbatim command output between quotes below -->
```

```



Discussion:
<!-- @amishel: Thanks for filing this bug report! -->

@j-carl ping, this issue is waiting for your response.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)

<!--- boilerplate: issue_bug_new --->


Resolving patch:
diff --git a/cloud/amazon/redshift.py b/cloud/amazon/redshift.py
--- a/cloud/amazon/redshift.py
+++ b/cloud/amazon/redshift.py
@@ -38,7 +38,7 @@
     description:
       - The node type of the cluster. Must be specified when command=create.
     required: false
-    choices: ['dw1.xlarge', 'dw1.8xlarge', 'dw2.large', 'dw2.8xlarge', ]
+    choices: ['ds1.xlarge', 'ds1.8xlarge', 'ds2.xlarge', 'ds2.8xlarge', 'dc1.large', 'dc1.8xlarge', 'dw1.xlarge', 'dw1.8xlarge', 'dw2.large', 'dw2.8xlarge']
   username:
     description:
       - Master database username. Used only when command=create.
@@ -160,7 +160,7 @@
 # Basic cluster provisioning example
 - redshift: >
     command=create
-    node_type=dw1.xlarge
+    node_type=ds1.xlarge
     identifier=new_cluster
     username=cluster_admin
     password=1nsecure
@@ -430,7 +430,7 @@ def main():
     argument_spec.update(dict(
             command                             = dict(choices=['create', 'facts', 'delete', 'modify'], required=True),
             identifier                          = dict(required=True),
-            node_type                           = dict(choices=['dw1.xlarge', 'dw1.8xlarge', 'dw2.large', 'dw2.8xlarge', ], required=False),
+            node_type                           = dict(choices=['ds1.xlarge', 'ds1.8xlarge', 'ds2.xlarge', 'ds2.8xlarge', 'dc1.large', 'dc1.8xlarge', 'dw1.xlarge', 'dw1.8xlarge', 'dw2.large', 'dw2.8xlarge'], required=False),
             username                            = dict(required=False),
             password                            = dict(no_log=True, required=False),
             db_name                             = dict(require=False),


Test patch: