Repository: ManimCommunity/manim

Issue:
Rename instances of `OpenGLMobject.set_submobjects` in opengl_mobject.py
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
They were deprecated but not their calls weren't renamed, leaving behind a trail of unnecessary deprecation warnings.

## Expected behavior
<!-- Add a clear and concise description of what you expected to happen. -->
No deprecation warnings since the user isn't calling it themselves.

## How to reproduce the issue
<!-- Provide a piece of code illustrating the undesired behavior. -->

<details><summary>Code for reproducing the problem</summary>

```py
class Test(Scene):
    def construct(self):
        a = MathTex("\\theta\\pi")
        self.play(Write(a))
```

</details>


## Additional media files
<!-- Paste in the files manim produced on rendering the code above. -->

<details><summary>Images/GIFs</summary>

<!-- PASTE MEDIA HERE -->

</details>


## Logs
<details><summary>Terminal output</summary>
<!-- Add "-v DEBUG" when calling manim to generate more detailed logs -->

```
Manim Community v0.12.0

[11/03/21 10:43:14] WARNING  The method OpenGLMobject.set_submobjects has been deprecated since v0.12.0 and is expected to be removed after         deprecation.py:210
                             v0.13.0. Use self.submobjects instead. Switching to using properties for submobjects
                    WARNING  The method OpenGLMobject.set_submobjects has been deprecated since v0.12.0 and is expected to be removed after         deprecation.py:210
                             v0.13.0. Use self.submobjects instead. Switching to using properties for submobjects
[11/03/21 10:43:15] INFO     Rendered Test                                                                                                                scene.py:234
                             Played 1 animations
```

<!-- Insert screenshots here (only when absolutely necessary, we prefer copy/pasted output!) -->

</details>


## System specifications

<details><summary>System Details</summary>

- OS (with version, e.g Windows 10 v2004 or macOS 10.15 (Catalina)):
- RAM:
- Python version (`python/py/python3 --version`):
- Installed modules (provide output from `pip list`):
```
PASTE HERE
```
</details>

<details><summary>LaTeX details</summary>

+ LaTeX distribution (e.g. TeX Live 2020):
+ Installed LaTeX packages:
<!-- output of `tlmgr list --only-installed` for TeX Live or a screenshot of the Packages page for MikTeX -->
</details>

<details><summary>FFMPEG</summary>

Output of `ffmpeg -version`:

```
PASTE HERE
```
</details>

## Additional comments
<!-- Add further context that you think might be relevant for this issue here. -->



Discussion:

Resolving patch:
diff --git a/manim/mobject/numbers.py b/manim/mobject/numbers.py
--- a/manim/mobject/numbers.py
+++ b/manim/mobject/numbers.py
@@ -115,7 +115,7 @@ def font_size(self, font_val):
 
     def set_submobjects_from_number(self, number):
         self.number = number
-        self.set_submobjects([])
+        self.submobjects = []
 
         num_string = self.get_num_string(number)
         self.add(*(map(self.string_to_mob, num_string)))
diff --git a/manim/mobject/opengl_mobject.py b/manim/mobject/opengl_mobject.py
--- a/manim/mobject/opengl_mobject.py
+++ b/manim/mobject/opengl_mobject.py
@@ -460,7 +460,7 @@ def remove(self, *mobjects, update_parent=False):
         return self
 
     def add_to_back(self, *mobjects):
-        self.set_submobjects(list_update(mobjects, self.submobjects))
+        self.submobjects = list_update(mobjects, self.submobjects)
         return self
 
     def replace_submobject(self, index, new_submob):
@@ -517,7 +517,7 @@ def digest_mobject_attrs(self):
         mobject_attrs = [
             x for x in list(self.__dict__.values()) if isinstance(x, OpenGLMobject)
         ]
-        self.set_submobjects(list_update(self.submobjects, mobject_attrs))
+        self.submobjects = list_update(self.submobjects, mobject_attrs)
         return self
 
     # Submobject organization
@@ -1527,7 +1527,7 @@ def pfp(self, alpha):
 
     def get_pieces(self, n_pieces):
         template = self.copy()
-        template.set_submobjects([])
+        template.submobjects = []
         alphas = np.linspace(0, 1, n_pieces + 1)
         return OpenGLGroup(
             *(
@@ -1641,7 +1641,7 @@ def align_family(self, mobject):
 
     def push_self_into_submobjects(self):
         copy = self.deepcopy()
-        copy.set_submobjects([])
+        copy.submobjects = []
         self.resize_points(0)
         self.add(copy)
         return self
@@ -1655,7 +1655,7 @@ def add_n_more_submobjects(self, n):
             # If empty, simply add n point mobjects
             null_mob = self.copy()
             null_mob.set_points([self.get_center()])
-            self.set_submobjects([null_mob.copy() for k in range(n)])
+            self.submobjects = [null_mob.copy() for k in range(n)]
             return self
         target = curr + n
         repeat_indices = (np.arange(target) * curr) // target
@@ -1670,7 +1670,7 @@ def add_n_more_submobjects(self, n):
                 if submob.get_opacity() < 1:
                     new_submob.set_opacity(0)
                 new_submobs.append(new_submob)
-        self.set_submobjects(new_submobs)
+        self.submobjects = new_submobs
         return self
 
     # Interpolate
diff --git a/manim/mobject/svg/tex_mobject.py b/manim/mobject/svg/tex_mobject.py
--- a/manim/mobject/svg/tex_mobject.py
+++ b/manim/mobject/svg/tex_mobject.py
@@ -358,14 +358,14 @@ def break_up_by_substrings(self):
                 # For cases like empty tex_strings, we want the corresponding
                 # part of the whole MathTex to be a VectorizedPoint
                 # positioned in the right part of the MathTex
-                sub_tex_mob.set_submobjects([VectorizedPoint()])
+                sub_tex_mob.submobjects = [VectorizedPoint()]
                 last_submob_index = min(curr_index, len(self.submobjects) - 1)
                 sub_tex_mob.move_to(self.submobjects[last_submob_index], RIGHT)
             else:
-                sub_tex_mob.set_submobjects(self.submobjects[curr_index:new_index])
+                sub_tex_mob.submobjects = self.submobjects[curr_index:new_index]
             new_submobjects.append(sub_tex_mob)
             curr_index = new_index
-        self.set_submobjects(new_submobjects)
+        self.submobjects = new_submobjects
         return self
 
     def get_parts_by_tex(self, tex, substring=True, case_sensitive=True):


Test patch: