internlm/SWE-Fixer-Train-110K huggingface dataset:
Repository: sunpy/sunpy

Issue:
Passing a norm from the plot_settings of one map to another modifies plot settings in place
<!-- This comments are hidden when you submit the issue so you do not need to remove them!
Please be sure to check out our contributing guidelines: https://github.com/sunpy/sunpy/blob/master/CONTRIBUTING.rst
Please be sure to check out our code of conduct:
https://github.com/sunpy/sunpy/blob/master/CODE_OF_CONDUCT.rst -->

<!-- Please have a search on our GitHub repository to see if a similar issue has already been posted.
If a similar issue is closed, have a quick look to see if you are satisfied by the resolution.
If not please go ahead and open an issue! -->

### Description
When passing the normalization from the `plot_settings` dict of a map to the plot method of another map via the `norm` keyword, the new norm is ignored and the original normalization is modified in place such that the original map has the normalization of the new map.

### Expected behavior
<!-- What did you expect to happen. -->
The new map to plotted with the normalization of the original and the plot settings to not be modified in place.

### Actual behavior
The code snippet below produces the following (in this order):

![image](https://user-images.githubusercontent.com/8676141/76036326-be4cac00-5f11-11ea-9a35-5d62d10d0b46.png)
![image](https://user-images.githubusercontent.com/8676141/76036355-d91f2080-5f11-11ea-8954-d85cdbd4a9ea.png)
![image](https://user-images.githubusercontent.com/8676141/76036359-de7c6b00-5f11-11ea-9a05-905d35c3f87d.png)



### Steps to Reproduce

```python
import sunpy.data.test
import sunpy.map
import sunpy.data.sample
m = sunpy.map.Map(sunpy.data.sample.AIA_171_IMAGE)
m_new = m._new_instance(np.where(m.data<100, -10000, m.data), m.meta)
m.peek(title='original')
m_new.peek(title='new', norm=m.plot_settings['norm'])
m.peek(title='original')
```

### System Details
<!-- We at least need to know the SunPy version you are using. -->
<!-- We provide a short function in SunPy that will provide some of the below information. -->
<!-- It is sunpy.util.system_info(), this is optional but strongly recommended. -->

  - SunPy Version: 1.1.1
  - Astropy Version: 4.0
  - Python Version: 3.8.1
  - OS information: Ubuntu 18.04.4 LTS



Discussion:

Resolving patch:
diff --git a/sunpy/map/mapbase.py b/sunpy/map/mapbase.py
--- a/sunpy/map/mapbase.py
+++ b/sunpy/map/mapbase.py
@@ -1764,7 +1764,10 @@ def plot(self, annotate=True, axes=None, title=True,
             x_range = list(u.Quantity([bl[0], tr[0]]).to(self.spatial_units[0]).value)
             y_range = list(u.Quantity([bl[1], tr[1]]).to(self.spatial_units[1]).value)
             imshow_args.update({'extent': x_range + y_range})
-        imshow_args.update(imshow_kwargs)
+
+        # Take a deep copy here so that a norm in imshow_kwargs doesn't get modified
+        # by setting it's vmin and vmax
+        imshow_args.update(copy.deepcopy(imshow_kwargs))
 
         if clip_interval is not None:
             if len(clip_interval) == 2:


Test patch:
Repository: sunpy/sunpy

Issue:
DATE-OBS in GenericMap.wcs is not FITS compliant
```python
import sunpy.map
from sunpy.coordinates import frames
from astropy.coordinates import SkyCoord
import astropy.units as u
import numpy as np

data = np.random.rand(1024, 1024)
my_coord = SkyCoord(0*u.arcsec, 0*u.arcsec, obstime="2017-08-01",
                    observer = 'earth', frame=frames.Helioprojective)
my_header = sunpy.map.make_fitswcs_header(data, my_coord)
my_map = sunpy.map.Map(data, my_header)
print(my_map.wcs.to_header()['DATE-OBS'])
```
prints
```
2017-08-01 00:00:00.000
```
Instead of a space between the date and time, this should have a "T" character. This means if we then round trip this in to a WCS again, astropy raises a warning:
```python
from astropy.wcs import WCS
WCS(my_map.wcs.to_header())
```
prints
```
WARNING: FITSFixedWarning: 'datfix' made the change 'Changed DATE-OBS from '2017-08-01 00:00:00.000' to '2017-08-01T00:00:00.000''. [astropy.wcs.wcs]
```


Discussion:

Resolving patch:
diff --git a/sunpy/map/mapbase.py b/sunpy/map/mapbase.py
--- a/sunpy/map/mapbase.py
+++ b/sunpy/map/mapbase.py
@@ -296,7 +296,7 @@ def wcs(self):
         w2.wcs.ctype = self.coordinate_system
         w2.wcs.pc = self.rotation_matrix
         w2.wcs.cunit = self.spatial_units
-        w2.wcs.dateobs = self.date.iso
+        w2.wcs.dateobs = self.date.isot
         w2.rsun = self.rsun_meters
 
         # Astropy WCS does not understand the SOHO default of "solar-x" and


Test patch:
diff --git a/sunpy/map/tests/test_mapbase.py b/sunpy/map/tests/test_mapbase.py
--- a/sunpy/map/tests/test_mapbase.py
+++ b/sunpy/map/tests/test_mapbase.py
@@ -779,3 +779,8 @@ def test_bad_header_final_fallback():
     assert (m.wcs.wcs.crval == [0.0, 0.0]).all()
     assert (m.wcs.wcs.crpix == [5.5, 5.5]).all()
     assert (m.wcs.wcs.cdelt == [1.0, 1.0]).all()
+
+
+def test_wcs_isot(aia171_test_map):
+    # Check that a Map WCS returns the time as isot format
+    assert aia171_test_map.wcs.to_header()['DATE-OBS'] == '2011-02-15T00:00:00.340'
Repository: sunpy/sunpy

Issue:
We don't close VSO connections
When I run the some of the examples that call the VSO, I see this in the output in my terminal:

```
generating gallery for generated/gallery/acquiring_data... [100%] searching_vso.py                                                                                                             
/home/nabil/GitHub/sunpy/.tox/build_docs/lib/python3.8/site-packages/sphinx_gallery/gen_rst.py:692: ResourceWarning: unclosed <socket.socket fd=14, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.1.103', 45712), raddr=('146.5.21.123', 80)>
  gc.collect()
/home/nabil/GitHub/sunpy/.tox/build_docs/lib/python3.8/site-packages/sphinx_gallery/gen_rst.py:692: ResourceWarning: unclosed <socket.socket fd=17, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.1.103', 45792), raddr=('146.5.21.123', 80)>
  gc.collect()
/home/nabil/GitHub/sunpy/.tox/build_docs/lib/python3.8/site-packages/sphinx_gallery/gen_rst.py:692: ResourceWarning: unclosed <socket.socket fd=16, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.1.103', 45790), raddr=('146.5.21.123', 80)>
  gc.collect()
```

We should find out where we aren't closing these connections and close them.


Discussion:

Resolving patch:
diff --git a/sunpy/net/vso/vso.py b/sunpy/net/vso/vso.py
--- a/sunpy/net/vso/vso.py
+++ b/sunpy/net/vso/vso.py
@@ -909,3 +909,6 @@ def _can_handle_query(cls, *query):
     @classmethod
     def _attrs_module(cls):
         return 'vso', 'sunpy.net.vso.attrs'
+
+    def __del__(self):
+        self.api.transport.session.close()


Test patch:
diff --git a/sunpy/net/tests/test_fido.py b/sunpy/net/tests/test_fido.py
--- a/sunpy/net/tests/test_fido.py
+++ b/sunpy/net/tests/test_fido.py
@@ -206,7 +206,7 @@ def test_tables_single_response():
 @pytest.mark.remote_data
 def test_tables_multiple_response():
     results = Fido.search(a.Time('2012/3/4', '2012/3/6'),
-                           a.Instrument('lyra') | (a.Instrument('rhessi') & a.Physobs("summary_lightcurve")))
+                          a.Instrument('lyra') | (a.Instrument('rhessi') & a.Physobs("summary_lightcurve")))
     tables = results.tables
     assert isinstance(tables, list)
     assert all(isinstance(t, Table) for t in tables)
@@ -460,6 +460,14 @@ def test_vso_fetch_hmi(tmpdir):
     assert len(files) == 1
 
 
+@pytest.mark.remote_data
+def test_unclosedSocket_warning():
+    with pytest.warns(None):
+        attrs_time = a.Time('2005/01/01 00:10', '2005/01/01 00:15')
+        result = Fido.search(attrs_time, a.Instrument('eit'))
+        Fido.fetch(result)
+
+
 def test_fido_no_time(mocker):
     jsoc_mock = mocker.patch("sunpy.net.jsoc.JSOCClient.search")
     jsoc_mock.return_value = jsoc.JSOCResponse()
@@ -468,6 +476,7 @@ def test_fido_no_time(mocker):
 
     jsoc_mock.assert_called_once()
 
+
 @pytest.mark.remote_data
 def test_slice_jsoc():
     tstart = '2011/06/07 06:32:45'
Repository: sunpy/sunpy

Issue:
Data manager docs report inconsistent information about hashes
It says SHA-1 here

https://github.com/sunpy/sunpy/blob/12225c4315d7dbe071bd0e3283adbf3f3e5f1709/sunpy/data/data_manager/manager.py#L44

and SHA-256 here 

https://github.com/sunpy/sunpy/blob/12225c4315d7dbe071bd0e3283adbf3f3e5f1709/sunpy/data/data_manager/manager.py#L123

Searching for [SHA-1](https://github.com/sunpy/sunpy/search?q=SHA-1&unscoped_q=SHA-1) yield 2 occurrences.

It should both say SHA-256


Discussion:

Resolving patch:
diff --git a/sunpy/data/data_manager/cache.py b/sunpy/data/data_manager/cache.py
--- a/sunpy/data/data_manager/cache.py
+++ b/sunpy/data/data_manager/cache.py
@@ -123,7 +123,7 @@ def get_by_hash(self, sha_hash):
         Parameters
         ----------
         sha_hash: `str`
-            SHA-1 hash of the file.
+            SHA-256 hash of the file.
         """
         details = self._storage.find_by_key('file_hash', sha_hash)
         return details
diff --git a/sunpy/data/data_manager/manager.py b/sunpy/data/data_manager/manager.py
--- a/sunpy/data/data_manager/manager.py
+++ b/sunpy/data/data_manager/manager.py
@@ -41,7 +41,7 @@ def require(self, name, urls, sha_hash):
         urls: `list` or `str`
             A list of urls to download the file from.
         sha_hash: `str`
-            SHA-1 hash of file.
+            SHA-256 hash of file.
         """
         if isinstance(urls, str):
             urls = [urls]


Test patch:
Repository: sunpy/sunpy

Issue:
make_fitswcs_header indexes from 1, not 0 as claimed in docs
Using the following toy example, I would expect the reference coordinate (0, 0) to correspond to the center of the [1, 1] pixel in the array, ie. the top right pixel. Looking at the figure below it seems like it refers to the [0, 0] pixel, which would mean `make_fitswcs_header` is indexing from 1 instead of 0.

The docstring [claims to be indexing from 0.](https://docs.sunpy.org/en/stable/api/sunpy.map.make_fitswcs_header.html#sunpy.map.make_fitswcs_header)

```python
import numpy as np
import sunpy.map
import sunpy.coordinates
from astropy.coordinates import SkyCoord
import astropy.units as u

data = np.arange(4).reshape((2, 2))
ref_coord = SkyCoord(0, 0, frame='helioprojective', obstime='now', unit='deg')
ref_pix = [1, 1] * u.pix
scale = [2, 2] * u.arcsec / u.pix
header = sunpy.map.make_fitswcs_header(data, ref_coord, reference_pixel=ref_pix, scale=scale)
print(header)

m = sunpy.map.Map(data, header)
m.peek()
```

![Figure_1](https://user-images.githubusercontent.com/6197628/81411191-f05cd300-9139-11ea-807e-3828fa12aa8d.png)



Discussion:
You are correct, we are indexing from 1, if we were indexing from 0 we would need to be adding `+1`s here: https://github.com/sunpy/sunpy/blob/master/sunpy/map/header_helper.py#L143L144

I am not sure if it's best to change the docstring or the implementation, I lean towards changing the implementation.

[this](https://github.com/sunpy/sunpy/blob/master/sunpy/map/header_helper.py#L136) line would also need adjusting if the implementation were to be changed.

Resolving patch:
diff --git a/sunpy/map/header_helper.py b/sunpy/map/header_helper.py
--- a/sunpy/map/header_helper.py
+++ b/sunpy/map/header_helper.py
@@ -133,15 +133,16 @@ def make_fitswcs_header(data, coordinate,
     meta_wcs.update(meta_instrument)
 
     if reference_pixel is None:
-        reference_pixel = u.Quantity([(shape[1] + 1)/2.*u.pixel, (shape[0] + 1)/2.*u.pixel])
+        reference_pixel = u.Quantity([(shape[1] - 1)/2.*u.pixel, (shape[0] - 1)/2.*u.pixel])
     if scale is None:
         scale = [1., 1.] * (u.arcsec/u.pixel)
 
     meta_wcs['crval1'], meta_wcs['crval2'] = (coordinate.spherical.lon.to_value(meta_wcs['cunit1']),
                                               coordinate.spherical.lat.to_value(meta_wcs['cunit2']))
 
-    meta_wcs['crpix1'], meta_wcs['crpix2'] = (reference_pixel[0].to_value(u.pixel),
-                                              reference_pixel[1].to_value(u.pixel))
+    # Add 1 to go from input 0-based indexing to FITS 1-based indexing
+    meta_wcs['crpix1'], meta_wcs['crpix2'] = (reference_pixel[0].to_value(u.pixel) + 1,
+                                              reference_pixel[1].to_value(u.pixel) + 1)
 
     meta_wcs['cdelt1'], meta_wcs['cdelt2'] = (scale[0].to_value(meta_wcs['cunit1']/u.pixel),
                                               scale[1].to_value(meta_wcs['cunit2']/u.pixel))


Test patch:
Repository: sunpy/sunpy

Issue:
Update .zenodo.json with new contributors for 2.0 release



Discussion:

Resolving patch:
diff --git a/tools/update_zenodo.py b/tools/update_zenodo.py
new file mode 100644
--- /dev/null
+++ b/tools/update_zenodo.py
@@ -0,0 +1,52 @@
+import json
+import subprocess
+
+
+def remove_initials(name):
+    # Remove initials for a string name
+    # Assumes names/initials are all separated by a single space
+    new_name = []
+    for n in name.split(' '):
+        if len(n) == 2 and n[1] == '.':
+            continue
+        new_name.append(n)
+    return ' '.join(new_name)
+
+
+authors = subprocess.check_output(['git shortlog -s -n'], shell=True)
+authors = authors.decode('utf-8')
+# 1 author per line
+authors = authors.split('\n')[:-1]
+# Use tab between number of commits and name to get name
+authors = [author.split('\t')[1] for author in authors]
+# Remove initials
+authors = [remove_initials(auth) for auth in authors]
+# List of authors to ignore because they are bots
+manual_ignore = ['codetriage-readme-bot']
+authors = [auth for auth in authors if auth not in manual_ignore]
+
+# Get list of current authors in zenodo.yml
+with open('.zenodo.json') as zenodo_file:
+    data = json.load(zenodo_file)
+
+creators = data['creators']
+already_auth = [auth['name'] for auth in creators]
+# Remove any initials
+already_auth = [remove_initials(auth) for auth in already_auth]
+
+new_creators = []
+# Loop through all the current authors
+for author in authors:
+    # If already in .zenodo.json, take the entry to preserve ORCID and affiliation
+    if author in already_auth:
+        new_creators.append(creators[already_auth.index(author)])
+    else:
+        new_creators.append({'name': author})
+
+# Add in anyone currently in .zenodo.json, but who hasn't committed to the repository
+for author in list(set(already_auth) - set(authors)):
+    new_creators.append(creators[already_auth.index(author)])
+
+data['creators'] = new_creators
+with open('.zenodo.json', 'w') as zenodo_file:
+    json.dump(data, zenodo_file, indent='    ', ensure_ascii=False)


Test patch:
Repository: sunpy/sunpy

Issue:
submap inverted rectangle warning fires when not expected
This example triggers the warning, but I am specifying a width and height, on an aligned map, how?!

```python
from astropy.coordinates import SkyCoord
import astropy.units as u

import sunpy.map
from sunpy.data.sample import AIA_171_IMAGE

aia = sunpy.map.Map(AIA_171_IMAGE)

bottom_left = SkyCoord(-100 * u.arcsec, -100 * u.arcsec, frame=aia.coordinate_frame)
width = 500 * u.arcsec
height = 300 * u.arcsec

sub_aia = aia.submap(bottom_left, width=width, height=height)
```


Discussion:
@dstansby any ideas?

Resolving patch:
diff --git a/sunpy/map/mapbase.py b/sunpy/map/mapbase.py
--- a/sunpy/map/mapbase.py
+++ b/sunpy/map/mapbase.py
@@ -1530,7 +1530,7 @@ def submap(self, bottom_left, *, top_right=None, width: (u.deg, u.pix) = None, h
         bottom_left, top_right = self._parse_submap_input(bottom_left, top_right, width, height)
 
         x_pixels = u.Quantity([bottom_left[0], top_right[0]]).to_value(u.pix)
-        y_pixels = u.Quantity([top_right[1], bottom_left[1]]).to_value(u.pix)
+        y_pixels = u.Quantity([bottom_left[1], top_right[1]]).to_value(u.pix)
         if x_pixels[0] > x_pixels[1]:
             warnings.warn("The rectangle is inverted in the left/right direction,  "
                           "which may lead to unintended behavior.", SunpyUserWarning)


Test patch:
Repository: sunpy/sunpy

Issue:
Should coordinates.sun.B0 return a Latitude object?
https://docs.sunpy.org/en/stable/api/sunpy.coordinates.sun.B0.html, returns "the heliographic latitude of the of the center of the disk of the Sun as seen from Earth.". Currently the return type is an `Angle`, and in a few tests both here and in `heliopy` I've had to convert this to a `Latitude` object to compare with other coordinates etc.

So should the return type of `B0` be `Latitude`? I think it should be, but thought I'd open an issue to solicit input before making a PR.


Discussion:
Also worth noting that `L0` (https://docs.sunpy.org/en/stable/api/sunpy.coordinates.sun.L0.html#sunpy.coordinates.sun.L0) returns a `Longitude` object (as opposed to an `Angle`).
Yup, the return type should probably be `Latitude`.

Resolving patch:
diff --git a/sunpy/coordinates/sun.py b/sunpy/coordinates/sun.py
--- a/sunpy/coordinates/sun.py
+++ b/sunpy/coordinates/sun.py
@@ -462,10 +462,10 @@ def B0(time='now'):
 
     Returns
     -------
-    out : `~astropy.coordinates.Angle`
+    out : `~astropy.coordinates.Latitude`
         The position angle
     """
-    return Angle(get_earth(time).lat)
+    return Latitude(get_earth(time).lat)
 
 
 # Function returns a SkyCoord's longitude in the de-tilted frame (HCRS rotated so that the Sun's


Test patch:
Repository: sunpy/sunpy

Issue:
Deprecate map.size
Given the discussion in #4202, we should deprecate the `size` attribute on `Map` for consistency as we do not want to add a `shape` attribute for the reasons listed in that issue.


Discussion:

Resolving patch:
diff --git a/sunpy/map/mapbase.py b/sunpy/map/mapbase.py
--- a/sunpy/map/mapbase.py
+++ b/sunpy/map/mapbase.py
@@ -36,7 +36,7 @@
 from sunpy.sun import constants
 from sunpy.time import is_time, parse_time
 from sunpy.util import expand_list
-from sunpy.util.decorators import deprecate_positional_args_since
+from sunpy.util.decorators import deprecate_positional_args_since, deprecated
 from sunpy.util.exceptions import SunpyUserWarning
 from sunpy.util.functools import seconddispatch
 from sunpy.visualization import axis_labels_from_ctype, peek_show, wcsaxes_compat
@@ -531,6 +531,7 @@ def dtype(self):
         return self.data.dtype
 
     @property
+    @deprecated(since="2.1", message="Use map.data.size instead", alternative="map.data.size")
     def size(self):
         """
         The number of pixels in the array of the map.


Test patch:
diff --git a/sunpy/map/tests/test_mapbase.py b/sunpy/map/tests/test_mapbase.py
--- a/sunpy/map/tests/test_mapbase.py
+++ b/sunpy/map/tests/test_mapbase.py
@@ -152,7 +152,8 @@ def test_dtype(generic_map):
 
 
 def test_size(generic_map):
-    assert generic_map.size == 36 * u.pix
+    with pytest.warns(SunpyDeprecationWarning, match='Use map.data.size instead'):
+        assert generic_map.size == 36 * u.pix
 
 
 def test_min(generic_map):
Repository: sunpy/sunpy

Issue:
32 bit tests failing
The 32 bit tests are currently failing, due to a failed attempt to install the `cryptography` library from source. See e.g. https://dev.azure.com/sunpy/sunpy/_build/results?buildId=9154&view=logs&jobId=a7b3aa55-7d57-562f-3433-7f6b2d4252da&j=2920fa54-56c6-5dfd-d3d8-7b1b694d90cb&t=bba4d609-c264-5f9c-e072-020a8a3b573f


Discussion:

Resolving patch:
diff --git a/sunpy/data/data_manager/cache.py b/sunpy/data/data_manager/cache.py
--- a/sunpy/data/data_manager/cache.py
+++ b/sunpy/data/data_manager/cache.py
@@ -157,16 +157,17 @@ def _download_and_hash(self, urls):
         def download(url):
             path = self._cache_dir / get_filename(urlopen(url), url)
             # replacement_filename returns a string and we want a Path object
-            path = Path(replacement_filename(path))
+            path = Path(replacement_filename(str(path)))
             self._downloader.download(url, path)
             shahash = hash_file(path)
             return path, shahash, url
 
+        errors = []
         for url in urls:
             try:
                 return download(url)
             except Exception as e:
-                warn(e, SunpyUserWarning)
-                error = e
+                warn(f"{e}", SunpyUserWarning)
+                errors.append(f"{e}")
         else:
-            raise RuntimeError from error
+            raise RuntimeError(errors)
diff --git a/sunpy/util/util.py b/sunpy/util/util.py
--- a/sunpy/util/util.py
+++ b/sunpy/util/util.py
@@ -41,7 +41,7 @@ def unique(itr, key=None):
                 items.add(x)
 
 
-def replacement_filename(path):
+def replacement_filename(path: str) -> str:
     """
     Return a replacement path if input path is currently in use.
 


Test patch:
Repository: sunpy/sunpy

Issue:
Wrong plot in goes hek m25 example
<!--
We know asking good questions takes effort, and we appreciate your time.
Thank you.

Please be aware that everyone has to follow our code of conduct:
https://github.com/sunpy/sunpy/blob/master/CODE_OF_CONDUCT.rst

Also that these comments are hidden when you submit this github issue.

Please have a search on our GitHub repository to see if a similar issue has already been posted.
If a similar issue is closed, have a quick look to see if you are satisfied by the resolution.
If not please go ahead and open an issue!
-->

### Description
<!-- Provide a general description of the bug. -->
The plot in timeseries example gallery of sunpy for goes and hek flare data looks very different when same code is run on master.

### Expected behavior
<!-- What did you expect to happen. -->
It should look like this
https://docs.sunpy.org/en/stable/_images/sphx_glr_goes_hek_m25_001.png

### Actual behavior
<!--
What actually happened.
Was the output confusing or poorly described?
-->
![goes_xrs](https://user-images.githubusercontent.com/43112347/90966194-2e191800-e4ed-11ea-9228-0378e1c2a7bb.png)
### Steps to Reproduce
<!--
Please include **code** that reproduces the issue whenever possible.
The best reproductions are self-contained scripts with minimal dependencies.
-->

https://docs.sunpy.org/en/stable/generated/gallery/time_series/goes_hek_m25.html#sphx-glr-generated-gallery-time-series-goes-hek-m25-py run this example.

### System Details
<!--
We at least need to know the sunpy version you are using.
We provide a short function (``sunpy.util.system_info()``) that will provide most of the below information.
This step is optional but strongly recommended.
-->
- SunPy Version: master, 2.0.1, 2.0.rc2 all are giving error
- Astropy Version: 4.0.1.post1
- Python Version: 3.8.5, 3.7.5 both were giving error
- OS information: Ubuntu 18.04 LTS



Discussion:
Seems something we merged in between 2.0.1 and the 2.0 branch.

Resolving patch:
diff --git a/examples/time_series/goes_hek_m25.py b/examples/time_series/goes_hek_m25.py
--- a/examples/time_series/goes_hek_m25.py
+++ b/examples/time_series/goes_hek_m25.py
@@ -34,9 +34,9 @@
 # Lets plot everything together
 fig, ax = plt.subplots()
 goes.plot()
-ax.axvline(parse_time(flares_hek[0].get('event_peaktime')).plot_date)
-ax.axvspan(parse_time(flares_hek[0].get('event_starttime')).plot_date,
-           parse_time(flares_hek[0].get('event_endtime')).plot_date,
+ax.axvline(parse_time(flares_hek[0].get('event_peaktime')).datetime)
+ax.axvspan(parse_time(flares_hek[0].get('event_starttime')).datetime,
+           parse_time(flares_hek[0].get('event_endtime')).datetime,
            alpha=0.2, label=flares_hek[0].get('fl_goescls'))
 ax.legend(loc=2)
 ax.set_yscale('log')


Test patch: