Repository: sunpy/sunpy

Issue:
New NumPy update breaks some of the documentation tests
NumPy v1.14.0 updates the way that arrays and numbers are printed to the terminal. As we use this alot in the documentation testing, we have a problem. 

Fixing this will mean running the documentation tests locally, checking the print out and changing the current results to the now expected results. Probably just to simpler to run the documentation code in a terminal and then copy and paste terminal output to the places it needs changing. 


Discussion:
Hey @nabobalis, I want to work on this issue. Will I have run all the codes in the documentation?
@yashkgp, you would have to run the SunPy test suite locally using `pytest -k-figure` after having configured the local python environment with all our test depencides and having the main repo cloned locally. That should print out to your terminal all the test failures (you could pipe it to a file instead).

You could also have a look at the travis jobs and see the output there.  But I have not checked the CI in a while now. 

If you are unsure how to do any of these we do have some guides, [here](http://docs.sunpy.org/en/stable/dev_guide/newcomers.html) and [here](http://docs.sunpy.org/en/stable/dev_guide/tests.html) which hopefully would be useful. 

@nabobalis I ran the test locally with NumPy v1.14 , Its passing all the test . The result of the test was : 
```
============================= 28 tests deselected ==============================
 1246 passed, 168 skipped, 28 deselected, 1 xpassed, 743 warnings in 381.21 seconds 
```
Numpy version that I am using 
```
numpy                     1.14.0           py36h3dfced4_0    anaconda
```
@yashkgp I suspect you used the wrong method to call the doctests. 
`sunpy.self_test()` or the `python setup.py test` do not call the doctests. It is a known issue that will hopefully be fixed eventually. You have to call pytest directly with `pytest -k-figure` from the main sunpy folder. 

You should see 1500+ tests and these [results.](https://travis-ci.org/sunpy/sunpy/jobs/328136830) Note that as I write this, its running but on my fork of sunpy, I see ~10 doctest failures. 
Hey @nabobalis 
I have send a PR .Can you give it a look?

@yashkgp Sure

Resolving patch:
diff --git a/sunpy/instr/goes.py b/sunpy/instr/goes.py
--- a/sunpy/instr/goes.py
+++ b/sunpy/instr/goes.py
@@ -368,9 +368,9 @@ def _goes_chianti_tem(longflux, shortflux, satellite=8,
     ...                              date='2014-04-16',
     ...                              abundances="coronal")  # doctest: +REMOTE_DATA
     >>> temp  # doctest: +REMOTE_DATA
-    <Quantity [ 11.28295376, 11.28295376] MK>
+    <Quantity [11.28295376, 11.28295376] MK>
     >>> em  # doctest: +REMOTE_DATA
-    <Quantity [  4.78577516e+48,  4.78577516e+48] 1 / cm3>
+    <Quantity [4.78577516e+48, 4.78577516e+48] 1 / cm3>
 
     """
     if not download_dir:
@@ -506,7 +506,7 @@ def _goes_get_chianti_temp(fluxratio, satellite=8, abundances="coronal",
     >>> temp = _goes_get_chianti_temp(fluxratio, satellite=15,
     ...                               abundances="coronal")  # doctest: +REMOTE_DATA
     >>> temp  # doctest: +REMOTE_DATA
-    <Quantity [ 12.27557778, 12.27557778] MK>
+    <Quantity [12.27557778, 12.27557778] MK>
 
     """
     if not download_dir:
@@ -662,7 +662,7 @@ def _goes_get_chianti_em(longflux, temp, satellite=8, abundances="coronal",
     >>> em = _goes_get_chianti_em(longflux, temp, satellite=15,
     ...                           abundances="coronal")  # doctest: +REMOTE_DATA
     >>> em  # doctest: +REMOTE_DATA
-    <Quantity [  3.45200672e+48,  3.45200672e+48] 1 / cm3>
+    <Quantity [3.45200672e+48, 3.45200672e+48] 1 / cm3>
 
     """
     if not download_dir:
@@ -942,7 +942,7 @@ def _calc_rad_loss(temp, em, obstime=None, force_download=False,
     >>> em = Quantity([4.0e+48, 4.0e+48], unit="cm**(-3)")
     >>> rad_loss = _calc_rad_loss(temp, em)  # doctest: +REMOTE_DATA
     >>> rad_loss["rad_loss_rate"]  # doctest: +REMOTE_DATA
-    <Quantity [  3.01851392e+19,  3.01851392e+19] J / s>
+    <Quantity [3.01851392e+19, 3.01851392e+19] J / s>
     """
     if not download_dir:
         download_dir = get_and_create_download_dir()
@@ -1171,15 +1171,15 @@ def _goes_lx(longflux, shortflux, obstime=None, date=None):
     ...                     datetime(2014,1,1,0,0,10),], dtype=object)
     >>> lx_out = _goes_lx(longflux, shortflux, obstime)  # doctest: +REMOTE_DATA
     >>> lx_out["longlum"]  # doctest: +REMOTE_DATA
-    <Quantity [  1.96860565e+18,  1.96860565e+18,  1.96860565e+18,
-                 1.96860565e+18,  1.96860565e+18,  1.96860565e+18] W>
+    <Quantity [1.96860565e+18, 1.96860565e+18, 1.96860565e+18, 1.96860565e+18,
+                 1.96860565e+18, 1.96860565e+18] W>
     >>> lx_out["shortlum"]  # doctest: +REMOTE_DATA
-    <Quantity [  1.96860565e+17,  1.96860565e+17,  1.96860565e+17,
-                 1.96860565e+17,  1.96860565e+17,  1.96860565e+17] W>
+    <Quantity [1.96860565e+17, 1.96860565e+17, 1.96860565e+17, 1.96860565e+17,
+               1.96860565e+17, 1.96860565e+17] W>
     >>> lx_out["longlum_int"]  # doctest: +REMOTE_DATA
-    <Quantity 1.968605654118636e+19 s W>
+    <Quantity 1.96860565e+19 s W>
     >>> lx_out["shortlum_int"]  # doctest: +REMOTE_DATA
-    <Quantity 1.9686056541186358e+18 s W>
+    <Quantity 1.96860565e+18 s W>
 
     """
     # Calculate X-ray luminosities
@@ -1266,7 +1266,7 @@ def _calc_xraylum(flux, date=None):
     >>> flux = Quantity([7e-6,7e-6], unit="W/m**2")
     >>> xraylum = _calc_xraylum(flux, date="2014-04-21")  # doctest: +REMOTE_DATA
     >>> xraylum  # doctest: +REMOTE_DATA
-    <Quantity [  1.98751663e+18,  1.98751663e+18] W>
+    <Quantity [1.98751663e+18, 1.98751663e+18] W>
 
     """
     if date is not None:


Test patch: