Repository: spacetelescope/jwql

Issue:
JDox links to Instrument documentation pages broken
The links to the JDOX documentation per instrument seems to be broken. 

From the main page, choosing 'Documentation' in the drop down from any instrument returns the following: 
Don't feel lost...

JDox content at the link you’re using may have been moved or deleted.
Please use the navigation sidebar or the search bar to find the information you’re seeking 

The links need to be checked and updated.



Discussion:
New links should be:
https://jwst-docs.stsci.edu/jwst-mid-infrared-instrument
https://jwst-docs.stsci.edu/jwst-near-infrared-camera
https://jwst-docs.stsci.edu/jwst-near-infrared-imager-and-slitless-spectrograph
https://jwst-docs.stsci.edu/jwst-near-infrared-spectrograph
https://jwst-docs.stsci.edu/jwst-observatory-hardware/jwst-fine-guidance-sensor

Resolving patch:
diff --git a/jwql/utils/constants.py b/jwql/utils/constants.py
--- a/jwql/utils/constants.py
+++ b/jwql/utils/constants.py
@@ -345,12 +345,12 @@
 
 # Concatenate all suffix types (ordered to ensure successful matching)
 FILE_SUFFIX_TYPES = GUIDER_SUFFIX_TYPES + GENERIC_SUFFIX_TYPES + \
-                    TIME_SERIES_SUFFIX_TYPES + NIRCAM_CORONAGRAPHY_SUFFIX_TYPES + \
-                    NIRISS_AMI_SUFFIX_TYPES + WFSC_SUFFIX_TYPES
+    TIME_SERIES_SUFFIX_TYPES + NIRCAM_CORONAGRAPHY_SUFFIX_TYPES + \
+    NIRISS_AMI_SUFFIX_TYPES + WFSC_SUFFIX_TYPES
 
 # Instrument Documentation Links
-URL_DICT = {'fgs': 'https://jwst-docs.stsci.edu/jwst-observatory-hardware/fine-guidance-sensor',
-            'miri': 'https://jwst-docs.stsci.edu/mid-infrared-instrument',
-            'niriss': 'https://jwst-docs.stsci.edu/near-infrared-imager-and-slitless-spectrograph',
-            'nirspec': 'https://jwst-docs.stsci.edu/near-infrared-spectrograph',
-            'nircam': 'https://jwst-docs.stsci.edu/near-infrared-camera'}
+URL_DICT = {'fgs': 'https://jwst-docs.stsci.edu/jwst-observatory-hardware/jwst-fine-guidance-sensor',
+            'miri': 'https://jwst-docs.stsci.edu/jwst-mid-infrared-instrument',
+            'niriss': 'https://jwst-docs.stsci.edu/jwst-near-infrared-imager-and-slitless-spectrograph',
+            'nirspec': 'https://jwst-docs.stsci.edu/jwst-near-infrared-spectrograph',
+            'nircam': 'https://jwst-docs.stsci.edu/jwst-near-infrared-camera'}
diff --git a/jwql/utils/utils.py b/jwql/utils/utils.py
--- a/jwql/utils/utils.py
+++ b/jwql/utils/utils.py
@@ -190,7 +190,7 @@ def copy_files(files, out_dir):
                 shutil.copy2(input_file, out_dir)
                 success.append(input_new_path)
                 permissions.set_permissions(input_new_path)
-            except:
+            except Exception:
                 failed.append(input_file)
     return success, failed
 
@@ -429,8 +429,7 @@ def filename_parser(filename):
 
     # Raise error if unable to parse the filename
     except AttributeError:
-        jdox_url = 'https://jwst-docs.stsci.edu/display/JDAT/' \
-                   'File+Naming+Conventions+and+Data+Products'
+        jdox_url = 'https://jwst-docs.stsci.edu/understanding-jwst-data-files/jwst-data-file-naming-conventions'
         raise ValueError(
             'Provided file {} does not follow JWST naming conventions.  '
             'See {} for further information.'.format(filename, jdox_url)
@@ -528,15 +527,15 @@ def check_config_for_key(key):
         get_config()[key]
     except KeyError:
         raise KeyError(
-            'The key `{}` is not present in config.json. Please add it.'.format(key)
-            + ' See the relevant wiki page (https://github.com/spacetelescope/'
+            'The key `{}` is not present in config.json. Please add it.'.format(key) +
+            ' See the relevant wiki page (https://github.com/spacetelescope/' +
             'jwql/wiki/Config-file) for more information.'
         )
 
     if get_config()[key] == "":
         raise ValueError(
-            'Please complete the `{}` field in your config.json. '.format(key)
-            + ' See the relevant wiki page (https://github.com/spacetelescope/'
+            'Please complete the `{}` field in your config.json. '.format(key) + 
+            ' See the relevant wiki page (https://github.com/spacetelescope/' +
             'jwql/wiki/Config-file) for more information.'
         )
 


Test patch: