Repository: spack/spack

Issue:
Installation issue: ParaView's LZMA dependency not satisfied by LZMA spack package
<!-- Thanks for taking the time to report this build failure. To proceed with the report please:

1. Title the issue "Installation issue: <name-of-the-package>".
2. Provide the information required below.

We encourage you to try, as much as possible, to reduce your problem to the minimal example that still reproduces the issue. That would help us a lot in fixing it quickly and effectively! -->

@chuckatkins @danlipsa The `lzma` spack package does not provide the files ParaView needs (`lzma.h` and `liblzma.so`).
 I think this has not been working as intended for quite some time now. I guess paraview has been able to find lzma from other places, but this is biting us now.

### Steps to reproduce the issue
<!-- Fill in the exact spec you are trying to build and the relevant part of the error message -->
```console
$ spack install paraview
...
$ spack find -dl paraview # get hash for installed lzma
7znb5nr paraview@master
jyftvl3     bzip2@1.0.8
dxlmwrx     double-conversion@2.0.1
22i5bqe     eigen@3.3.8
tre26e2     expat@2.2.10
5jprghg         libbsd@0.10.0
d7jlbki     freetype@2.7.1
2ik2h6j         libpng@1.6.37
ewsfmtb             zlib@1.2.11
56hzmx6     hdf5@1.10.2
qlbvmo4         openmpi@2.1.2
au7m252     jsoncpp@1.9.4
zpfg2a7     libjpeg-turbo@2.0.6
cvvnyzx     libogg@1.3.2
kednyqb     libtheora@1.1.1
7mehihb     libtiff@4.1.0
w3cqnv2         xz@5.2.5
jfio5zj     libxml2@2.7.8
byycvhr         libiconv@1.16
sc2vev7     lz4@1.9.2
tdlzalj     lzma@4.32.7
2nk77ni     mesa@20.2.1
lurbnoe         llvm@7.1.0
3jwkqal             hwloc@2.4.1
jf3b5x2                 libpciaccess@0.16
u5hc5jj                 ncurses@6.1
njlhtbo     netcdf-c@4.7.4
r6y777o     protobuf@3.4.0
73qfbjj     pugixml@1.11
nikovkp     py-matplotlib@3.1.1
aaeamcj         py-cycler@0.10.0
6z3pduk             py-six@1.15.0
qay5m5h                 python@3.6.8
ku2imth                     gdbm@1.18.1
44rn35p                         readline@8.0
g2wuy3j                     gettext@0.21
cpv6f3m                         tar@1.32
immayjb                     libffi@3.3
ycyudm7                     openssl@1.1.1j
dxvlv6t                     sqlite@3.34.0
6k63h74         py-kiwisolver@1.1.0
ijaylup         py-numpy@1.17.3
nttqgix             openblas@0.3.6
i3ycese             py-setuptools@50.3.2
r6pfhco         py-pillow@7.2.0
lpru7br         py-pyparsing@2.4.7
lwns22j         py-python-dateutil@2.8.1
xzkzph3     py-mpi4py@3.0.3
$ ls `spack location -i /tdlzalj`/lib
liblzmadec.so  liblzmadec.so.0	liblzmadec.so.0.0.0
```

### Information on your system

<!-- Please include the output of `spack debug report` -->

```console
$ spack debug report
* **Spack:** 0.16.1-1976-1144666c09
* **Python:** 3.6.8
* **Platform:** linux-rhel7-broadwell
* **Concretizer:** original
```

<!-- If you have any relevant configuration detail (custom `packages.yaml` or `modules.yaml`, etc.) you can add that here as well. -->

### Additional information

The [homepage for that package](https://tukaani.org/lzma/) suggest people move to XZ Utils. I would vote for that too, since XZ does have the required files:

```console
$ #xz hash from above is w3cqnv2
$ ls `spack location -i /w3cqnv2`/lib
liblzma.a  liblzma.so  liblzma.so.5  liblzma.so.5.2.5  pkgconfig
$ $ ls `spack location -i /w3cqnv2`/include
lzma  lzma.h
```

<!-- Some packages have maintainers who have volunteered to debug build failures. Run `spack maintainers <name-of-the-package>` and @mention them here if they exist. -->

### General information

<!-- These boxes can be checked by replacing [ ] with [x] or by clicking them after submitting the issue. -->
- [x] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [x] I have run `spack maintainers <name-of-the-package>` and @mentioned any maintainers
- [ ] I have uploaded the build log and environment files
- [x] I have searched the issues of this repo and believe this is not a duplicate



Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/paraview/package.py b/var/spack/repos/builtin/packages/paraview/package.py
--- a/var/spack/repos/builtin/packages/paraview/package.py
+++ b/var/spack/repos/builtin/packages/paraview/package.py
@@ -127,7 +127,7 @@ class Paraview(CMakePackage, CudaPackage):
     depends_on('protobuf@3.4:')
     depends_on('libxml2')
     depends_on('lz4')
-    depends_on('lzma')
+    depends_on('xz')
     depends_on('zlib')
 
     # Older builds of pugi export their symbols differently,


Test patch: