Repository: bokeh/bokeh

Issue:
Clean up toolbar's CSS
The existing implementation is unmaintainable and needs replacement. This work will be the basis for further toolbar improvements. This is unrelated to making toolbar a standalone widget.



Discussion:

Resolving patch:
diff --git a/bokeh/models/tools.py b/bokeh/models/tools.py
--- a/bokeh/models/tools.py
+++ b/bokeh/models/tools.py
@@ -320,7 +320,7 @@ class TapTool(Tap):
 
 
 class CrosshairTool(Inspection):
-    """ *toolbar icon*: |inspector_icon|
+    """ *toolbar icon*: |crosshair_icon|
 
     The crosshair tool is a passive inspector tool. It is generally on
     at all times, but can be configured in the inspector's menu
@@ -331,7 +331,7 @@ class CrosshairTool(Inspection):
     configured to draw across only one dimension by setting the
     ``dimension`` property to only ``width`` or ``height``.
 
-    .. |inspector_icon| image:: /_images/icons/Inspector.png
+    .. |crosshair_icon| image:: /_images/icons/Crosshair.png
         :height: 18pt
 
     """
@@ -617,7 +617,7 @@ class PolySelectTool(Tap):
     """)
 
 class HoverTool(Inspection):
-    """ *toolbar icon*: |inspector_icon|
+    """ *toolbar icon*: |crosshair_icon|
 
     The hover tool is a passive inspector tool. It is generally on at
     all times, but can be configured in the inspector's menu associated
@@ -667,7 +667,7 @@ class HoverTool(Inspection):
             * segment
             * text
 
-    .. |hover_icon| image:: /_images/icons/Inspector.png
+    .. |hover_icon| image:: /_images/icons/Hover.png
         :height: 18pt
     """
 


Test patch:
diff --git a/bokehjs/test/models/tools/toolbar.coffee b/bokehjs/test/models/tools/toolbar.coffee
--- a/bokehjs/test/models/tools/toolbar.coffee
+++ b/bokehjs/test/models/tools/toolbar.coffee
@@ -28,15 +28,6 @@ describe "ToolbarView", ->
     expect(spy.calledOnce).is.true
     expect(spy.args[0][0]['location']).is.equal 'below'
 
-  it "render should call template with above toolbar_location if location is None", ->
-    # We need to set above so toolbar looks nice
-    @test_tb.toolbar_location = null
-    tb_view = new @test_tb.default_view({ model: @test_tb })
-    spy = sinon.spy(tb_view, 'template')
-    tb_view.render()
-    expect(spy.calledOnce).is.true
-    expect(spy.args[0][0]['location']).is.equal 'above'
-
   it "render should set the appropriate positions and paddings on the element in box mode", ->
     dom_left = 12
     dom_top = 44
diff --git a/tests/integration/interaction/screenshots/base__test_hover__test_hover_changes_color.png b/tests/integration/interaction/screenshots/base__test_hover__test_hover_changes_color.png
Binary files a/tests/integration/interaction/screenshots/base__test_hover__test_hover_changes_color.png and b/tests/integration/interaction/screenshots/base__test_hover__test_hover_changes_color.png differ
diff --git a/tests/integration/plotting/screenshots/base__test_visible_property__test_visible_property_hides_things_correctly.png b/tests/integration/plotting/screenshots/base__test_visible_property__test_visible_property_hides_things_correctly.png
Binary files a/tests/integration/plotting/screenshots/base__test_visible_property__test_visible_property_hides_things_correctly.png and b/tests/integration/plotting/screenshots/base__test_visible_property__test_visible_property_hides_things_correctly.png differ