Repository: bokeh/bokeh

Issue:
Remove logo_url from resources
While looking into #3081, I realized that resources.logo_url isn't actually used anywhere.

If you look at https://github.com/bokeh/bokeh/search?q=logo_url&type=Code&utf8=%E2%9C%93

you can see it in 3 places:
- as an attribute on resources - https://github.com/bokeh/bokeh/blob/1214c2deaa625433650ceecb346872f562756ec4/bokeh/resources.py#L112
- passed into a template in the load_notebook method https://github.com/bokeh/bokeh/blob/3711adfd91d7afe4a3f27663d6f8a5c22dda8ce7/bokeh/util/notebook.py#L56
- referenced in the docstring for the notebook template https://github.com/bokeh/bokeh/blob/8e2276f5bd118095cccdba5e8e2bea3f4ab0fbef/bokeh/_templates/notebook_load.html#L8  but crucially not actually used in that template



Discussion:
Leftover cruft from the first implementation. Now the image is base64 encoded as a CSS image. Perhaps this could be hooked up to override that, though. 

I'd really keen to override the bokeh image with another (user-specified) one.

However, I'm unlikely to be able to do this anytime soon - still have much to learn about git (and Python in general for that matter)


Resolving patch:
diff --git a/bokeh/resources.py b/bokeh/resources.py
--- a/bokeh/resources.py
+++ b/bokeh/resources.py
@@ -202,8 +202,6 @@ class BaseResources(object):
     _default_root_dir = "."
     _default_root_url = DEFAULT_SERVER_HTTP_URL
 
-    logo_url = "http://bokeh.pydata.org/static/bokeh-transparent.png"
-
     def __init__(self, mode='inline', version=None, root_dir=None,
                  minified=True, log_level="info", root_url=None,
                  path_versioner=None, components=None):
@@ -348,7 +346,6 @@ class JSResources(BaseResources):
     Once configured, a Resource object exposes the following public attributes:
 
     Attributes:
-        logo_url : location of the BokehJS logo image
         css_raw : any raw CSS that needs to be places inside ``<style>`` tags
         css_files : URLs of any CSS files that need to be loaded by ``<link>`` tags
         messages : any informational messages concerning this configuration
@@ -505,7 +502,6 @@ class CSSResources(BaseResources):
     Once configured, a Resource object exposes the following public attributes:
 
     Attributes:
-        logo_url : location of the BokehJS logo image
         css_raw : any raw CSS that needs to be places inside ``<style>`` tags
         css_files : URLs of any CSS files that need to be loaded by ``<link>`` tags
         messages : any informational messages concerning this configuration
@@ -568,7 +564,6 @@ class Resources(JSResources, CSSResources):
     Once configured, a Resource object exposes the following public attributes:
 
     Attributes:
-        logo_url : location of the BokehJS logo image
         js_raw : any raw JS that needs to be placed inside ``<script>`` tags
         css_raw : any raw CSS that needs to be places inside ``<style>`` tags
         js_files : URLs of any JS files that need to be loaded by ``<script>`` tags
diff --git a/bokeh/util/notebook.py b/bokeh/util/notebook.py
--- a/bokeh/util/notebook.py
+++ b/bokeh/util/notebook.py
@@ -59,7 +59,6 @@ def _load_notebook_html(resources=None, verbose=False, hide_banner=False):
 
     html = NOTEBOOK_LOAD.render(
         element_id    = element_id,
-        logo_url      = resources.logo_url,
         verbose       = verbose,
         js_info       = js_info,
         css_info      = css_info,


Test patch: