Repository: openshift/openshift-ansible

Issue:
installer status callback plugin should be scoped to installer playbooks
#### Description

> When running non-install playbooks (health checks, re-certs, restarts, upgrades...) the callback still displays as if there is an install in progress. This could be confusing for users.


##### Version

origin master

##### Steps To Reproduce
1. `ansible-playbook -i hosts playbooks/byo/openshift-checks/pre-install.yml`

##### Observed Results
Describe what is actually happening.

```
...
INSTALLER STATUS **************************************************************************************************************************************************************************************************
Initialization             : Complete
etcd Install               : Not Started
NFS Install                : Not Started
Load balancer Install      : Not Started
Master Install             : Not Started
Master Additional Install  : Not Started
Node Install               : Not Started
GlusterFS Install          : Not Started
Hosted Install             : Not Started
Metrics Install            : Not Started
Logging Install            : Not Started
Service Catalog Install    : Not Started
```



Discussion:
/assign mtnbikenc

On Thu, Oct 5, 2017 at 1:09 PM, Luke Meyer <notifications@github.com> wrote:

> Description
>
> When running non-install playbooks (health checks, re-certs, restarts,
> upgrades...) the callback still displays as if there is an install in
> progress. This could be confusing for users.
>
> Version
>
> origin master
> Steps To Reproduce
>
>    1. ansible-playbook -i hosts playbooks/byo/openshift-
>    checks/pre-install.yml
>
> Observed Results
>
> Describe what is actually happening.
>
> ...
> INSTALLER STATUS **************************************************************************************************************************************************************************************************
> Initialization             : Complete
> etcd Install               : Not Started
> NFS Install                : Not Started
> Load balancer Install      : Not Started
> Master Install             : Not Started
> Master Additional Install  : Not Started
> Node Install               : Not Started
> GlusterFS Install          : Not Started
> Hosted Install             : Not Started
> Metrics Install            : Not Started
> Logging Install            : Not Started
> Service Catalog Install    : Not Started
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/openshift/openshift-ansible/issues/5675>, or mute the
> thread
> <https://github.com/notifications/unsubscribe-auth/AAC8IQQvvvjhtxH0KIce5HufkzZXbDy4ks5spQ1BgaJpZM4PvaJZ>
> .
>


Resolving patch:
diff --git a/roles/installer_checkpoint/callback_plugins/installer_checkpoint.py b/roles/installer_checkpoint/callback_plugins/installer_checkpoint.py
--- a/roles/installer_checkpoint/callback_plugins/installer_checkpoint.py
+++ b/roles/installer_checkpoint/callback_plugins/installer_checkpoint.py
@@ -159,11 +159,6 @@ def v2_playbook_on_stats(self, stats):
                         self._display.display(
                             '\tThis phase can be restarted by running: {}'.format(
                                 phase_attributes[phase]['playbook']))
-                else:
-                    # Phase was not found in custom stats
-                    self._display.display(
-                        '{}{}: {}'.format(phase_title, ' ' * padding, 'Not Started'),
-                        color=C.COLOR_SKIP)
 
         self._display.display("", screen_only=True)
 


Test patch: