Repository: mdn/kuma

Issue:
waffle cleanup 2014-01-22
Remove:
- profile_subscription
- redesign_beta_notice
- external_signup
- elasticsearch



Discussion:
All gone except for `external_signup`, but do we plan to removethe  `external_signup` flag?

Yeah, we should remove the flag and remove the feature/form code behind it. It sparked very little attention.


Resolving patch:
diff --git a/apps/wiki/urls.py b/apps/wiki/urls.py
--- a/apps/wiki/urls.py
+++ b/apps/wiki/urls.py
@@ -70,7 +70,7 @@
     url(r'^/new$', 'new_document', name='wiki.new_document'),
     url(r'^/all$', 'list_documents', name='wiki.all_documents'),
     url(r'^/with-errors$', 'list_documents_with_errors', name='wiki.errors'),
-    url(r'^/without-parent$', 'list_documents_without_parent', 
+    url(r'^/without-parent$', 'list_documents_without_parent',
         name='wiki.without_parent'),
     url(r'^/top-level$', 'list_top_level_documents',
         name='wiki.top_level'),
@@ -78,7 +78,6 @@
         name='wiki.list_review_tag'),
     url(r'^/needs-review/?', 'list_documents_for_review',
         name='wiki.list_review'),
-    url(r'^/external-signup$', 'external_signup', name='wiki.external_signup'),
     url(r'^/category/(?P<category>\d+)$', 'list_documents',
     name='wiki.category'),
 
diff --git a/apps/wiki/views.py b/apps/wiki/views.py
--- a/apps/wiki/views.py
+++ b/apps/wiki/views.py
@@ -22,7 +22,7 @@
 
 from django.conf import settings
 from django.db import transaction
-from django.core.exceptions import PermissionDenied, ValidationError
+from django.core.exceptions import PermissionDenied
 from django.utils.safestring import mark_safe
 from django.template import RequestContext, loader
 from django.core.cache import cache
@@ -82,9 +82,6 @@
 
 from pyquery import PyQuery as pq
 
-from django.core.validators import URLValidator
-from django.core.mail import send_mail
-
 
 log = logging.getLogger('k.wiki')
 
@@ -1623,39 +1620,6 @@ def select_locale(request, document_slug, document_locale):
     return render(request, 'wiki/select_locale.html', {'document': doc})
 
 
-@require_http_methods(['GET', 'POST'])
-@prevent_indexing
-def external_signup(request):
-    """ Something """
-    context = {'submitted': False}
-
-    if request.method == 'POST':
-        location = request.POST.get('location', '')
-        context['location'] = location
-
-        if location:
-            validate = URLValidator(verify_exists=True)
-            try:
-                validate(location)
-                context['submitted'] = True
-
-                message = """
-A request for external documentation to be added to MDN has
-been made for the following address:
-
-%s
-                """ % location
-                send_mail('MVP External Source Documentation Request',
-                            message,
-                            settings.TIDINGS_FROM_ADDRESS,
-                            [constance.config.EXTERNAL_SIGNUP_EMAIL,])
-
-            except ValidationError:
-                context['error'] = _('The URL you provided could not be reached.')
-                pass
-    return render(request, 'wiki/mvp_signup.html', context)
-
-
 @require_http_methods(['GET', 'POST'])
 @login_required
 @process_document_path
diff --git a/settings.py b/settings.py
--- a/settings.py
+++ b/settings.py
@@ -1041,11 +1041,6 @@ def JINJA_CONFIG():
         "JSON array of tags that are enabled for search faceting"
     ),
 
-    EXTERNAL_SIGNUP_EMAIL = (
-        '',
-        'The email address to receive external docs signup emails.'
-    ),
-
     SESSION_CLEANUP_CHUNK_SIZE = (
         1000,
         'Number of expired sessions to cleanup up in one go.',


Test patch: