Repository: OCHA-DAP/hdx-ckan

Issue:
Main Nav changes to accomodate "Feedback" button
Updating the action based on discussions:
1. Remove `Contact` from main nav. 
2. Between `About` and `Submit Data`, add a button `Feedback`.  
3. While you are there, change `Submit Data` to `Share Data` (there's a later issue for that which this will close)

Button style should be the same as the "Follow Us" button here, except gray, not blue: http://docs.hdx.rwlabs.org/get-involved/

Note that the megaphone icon shown below will not be used.  No icon on the button.



Discussion:
@ochadataproject The easiest way to implement this would be to put it where search is or in the main nav.  Both options are shown below (icons and colors just a placeholder). 

 onHover would say "Send feedback to hdx.feedback@gmail.com."  

Click behavior would be the same as clicking on the email address on our current contact page: http://docs.hdx.rwlabs.org/get-involved/

![image](https://cloud.githubusercontent.com/assets/1654485/4750901/23c653b2-5a98-11e4-87a5-c9b1365d1a2b.png)

I have the implementation plan for this.  Will write it up soon. 

@cjhendrix @danmihaila 
I'm not sure about the look with the gray button, so here are some experiments. What do you think?

Current look:
![style1](https://cloud.githubusercontent.com/assets/5638491/4824041/d7abd3fe-5f55-11e4-935f-ed40f711effd.png)
Icon shout - blue
![style2](https://cloud.githubusercontent.com/assets/5638491/4824047/e1baabfe-5f55-11e4-8c0f-b73de51d2b3c.png)
Icon shout - gray
![style3](https://cloud.githubusercontent.com/assets/5638491/4824054/ef7fe2ea-5f55-11e4-8563-7c68bbcdb88c.png)
Icon send - blue
![style5](https://cloud.githubusercontent.com/assets/5638491/4824057/f747ab98-5f55-11e4-8ae2-428f1faefdbd.png)
Icon send - gray 
![style4](https://cloud.githubusercontent.com/assets/5638491/4824067/018f8954-5f56-11e4-8118-9a8c5bf92071.png)

I bet on second one, Icon shout - gray :)

I like icon send gray (last one).  But let's let @ochadataproject decide.  Sarah, have a look at Arti's comment above with 5 different options and let us know what you prefer.

Yes on the feedback with the grey button thanks

On Wednesday, October 29, 2014, Alexandru Artimon notifications@github.com
wrote:

> Reopened #1517 https://github.com/OCHA-DAP/hdx-ckan/issues/1517.
> 
> —
> Reply to this email directly or view it on GitHub
> https://github.com/OCHA-DAP/hdx-ckan/issues/1517#event-185261311.

Another small change on this one.  Reopening.

Keep the button style as is, but move it over to the end of the main nav instead of against the submit button.

@cjhendrix so right after the "About" link? 

Yes.  Thanks.


Resolving patch:
diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/version.py b/ckanext-hdx_theme/ckanext/hdx_theme/version.py
--- a/ckanext-hdx_theme/ckanext/hdx_theme/version.py
+++ b/ckanext-hdx_theme/ckanext/hdx_theme/version.py
@@ -1 +1 @@
-hdx_version = 'v0.4.5'
+hdx_version = 'v0.4.6'


Test patch:
diff --git a/ckanext-hdx_search/ckanext/hdx_search/tests/test_search.py b/ckanext-hdx_search/ckanext/hdx_search/tests/test_search.py
--- a/ckanext-hdx_search/ckanext/hdx_search/tests/test_search.py
+++ b/ckanext-hdx_search/ckanext/hdx_search/tests/test_search.py
@@ -20,7 +20,7 @@ class TestHDXSearch(hdx_test_base.HdxBaseTest):
     @classmethod
     def _load_plugins(cls):
         try:
-            p.load('hdx_search')
+            hdx_test_base.load_plugin('hdx_search hdx_org_group hdx_theme')
         except Exception as e:
             log.warn('Module already loaded')
             log.info(str(e))
@@ -61,6 +61,7 @@ def test_sort(self):
 
     def test_package_search(self):
         import ckanext.hdx_search.controllers.search_controller as search
+        import ckanext.hdx_search.actions.actions as hdx_actions
         user = model.User.by_name('hdx')
         data_dict = {
                 'q': '',
@@ -73,17 +74,17 @@ def test_package_search(self):
             }
         context = {'model': model, 'session': model.Session,
                        'user': user, 'for_view': True, 'auth_user_obj': user}
-        s = search.package_search(context, data_dict)
+        s = hdx_actions.package_search(context, data_dict)
         assert len(s['results']) > 0
 
-    def test_new_sort_org(self):
-        org = h.url_for(
-            controller='organization', action='list')
-        response = self.app.get(org, params={'sort':'title+asc'})
-        assert '200' in response.status
-
-    def test_new_sort_grp(self):
-        grp = h.url_for(
-            controller='group', action='list')
-        response = self.app.get(grp, params={'sort':'title+asc'})
-        assert '200' in response.status
+#     def test_new_sort_org(self):
+#         org = h.url_for(
+#             controller='organization', action='list')
+#         response = self.app.get(org, params={'sort':'title+asc'})
+#         assert '200' in response.status
+# 
+#     def test_new_sort_grp(self):
+#         grp = h.url_for(
+#             controller='group', action='list')
+#         response = self.app.get(grp, params={'sort':'title+asc'})
+#         assert '200' in response.status