Repository: freedomofpress/securedrop

Issue:
replace "hidden service" occurrences
## Status

ready for review

## Description of Changes

Changes Proposed:

  - no longer refer to [Onion Services](https://2019.www.torproject.org/docs/onion-services.html.en) as hidden services;
  - there are NO new images I added, it's just text;
  - all changed content here is either just a comment (playbook, or shell script);
  - changelog was kept as is.

## Testing

I followed the _(slightly outdated)_ [Documentation Guidelines](https://docs.securedrop.org/en/latest/development/documentation_guidelines.html), and all looked fine:

```
# make docs
```

Gave me the following:

```
    ...

| copying static files... done
| copying extra files... done
| dumping search index in English (code: en) ... done
| dumping object inventory... done
| build succeeded.
+--------------------------------------------------------------------------------

[I 190725 16:16:16 server:296] Serving on http://127.0.0.1:8000
[I 190725 16:16:16 handlers:62] Start watching changes
[I 190725 16:16:16 handlers:64] Start detecting changes
```
`make docs-linkcheck` returned an error, but that's not related to the changes made here. `docs-lint` ran just fine.

## Deployment

Any special considerations for deployment?

  - AFAIK, no.

## Checklist

### If you made changes to the server application code:

- [ ] Linting (`make lint`) and tests (`make -C securedrop test`) pass in the development container

### If you made changes to `securedrop-admin`:

- [ ] Linting and tests (`make -C admin test`) pass in the admin development container

### If you made changes to the system configuration:

- [ ] [Configuration tests](https://docs.securedrop.org/en/latest/development/testing_configuration_tests.html) pass

### If you made non-trivial code changes:

- [ ] I have written a test plan and validated it for this PR

### If you made changes to documentation:

- [x] Doc linting (`make docs-lint`) passed locally



Discussion:

Resolving patch:
diff --git a/install_files/ansible-base/roles/backup/files/0.3_collect.py b/install_files/ansible-base/roles/backup/files/0.3_collect.py
--- a/install_files/ansible-base/roles/backup/files/0.3_collect.py
+++ b/install_files/ansible-base/roles/backup/files/0.3_collect.py
@@ -39,7 +39,7 @@ def collect_custom_header_image(zf):
 
 
 def collect_tor_files(zf):
-    # All of the tor hidden service private keys are stored in the THS specific
+    # All of the tor Onion Service private keys are stored in the THS specific
     # subdirectory `/var/lib/tor/services` backing up this directory will back
     # up all of the THS and ATHS required keys needed to restore all the hidden
     # services on that system.


Test patch:
diff --git a/molecule/testinfra/staging/app/test_tor_config.py b/molecule/testinfra/staging/app/test_tor_config.py
--- a/molecule/testinfra/staging/app/test_tor_config.py
+++ b/molecule/testinfra/staging/app/test_tor_config.py
@@ -38,7 +38,7 @@ def test_tor_torrc_options(host, torrc_option):
     These options should be present regardless of machine role,
     meaning both Application and Monitor server will have them.
 
-    Separate tests will check for specific hidden services.
+    Separate tests will check for specific Onion Services.
     """
     f = host.file("/etc/tor/torrc")
     assert f.is_file
diff --git a/molecule/testinfra/staging/app/test_tor_hidden_services.py b/molecule/testinfra/staging/app/test_tor_hidden_services.py
--- a/molecule/testinfra/staging/app/test_tor_hidden_services.py
+++ b/molecule/testinfra/staging/app/test_tor_hidden_services.py
@@ -22,9 +22,9 @@ def test_tor_service_directories(host, tor_service):
 @pytest.mark.parametrize('tor_service', sdvars.tor_services)
 def test_tor_service_hostnames(host, tor_service):
     """
-    Check contents of tor service hostname file. For normal Hidden Services,
+    Check contents of tor service hostname file. For normal Onion Services,
     the file should contain only hostname (.onion URL). For Authenticated
-    Hidden Services, it should also contain the HidServAuth cookie.
+    Onion Services, it should also contain the HidServAuth cookie.
     """
     # Declare regex only for THS; we'll build regex for ATHS only if
     # necessary, since we won't have the required values otherwise.
@@ -56,12 +56,12 @@ def test_tor_service_hostnames(host, tor_service):
 def test_tor_services_config(host, tor_service):
     """
     Ensure torrc file contains relevant lines for Hidden Service declarations.
-    All hidden services must include:
+    All Onion Services must include:
 
       * HiddenServiceDir
       * HiddenServicePort
 
-    Only authenticated hidden services must also include:
+    Only authenticated Onion Services must also include:
 
       * HiddenServiceAuthorizeClient