Repository: hydroshare/hydroshare

Issue:
Improve iRODS account creation and deletion messaging
When creating an iRODS account the message Success "iRODS account username is created successfully" should be changed to "iRODS account username **was** created successfully", i.e. past tense.
![image](https://user-images.githubusercontent.com/3456833/51769869-5cc8d580-20a1-11e9-8641-89df2e9d4579.png)

Also when an iRODS account is deleted the Failure message below flashes up.  Account deletion appears to work (at least for me the account and its content goes away).  So this message should be changed to either indicate success or just be silent
![image](https://user-images.githubusercontent.com/3456833/51769783-1ffcde80-20a1-11e9-80a9-cd96f58fa71d.png)

Left over from #2969 



Discussion:

Resolving patch:
diff --git a/theme/views.py b/theme/views.py
--- a/theme/views.py
+++ b/theme/views.py
@@ -597,7 +597,7 @@ def delete_irods_account(request):
                     # there is an error from icommand run, report the error
                     return JsonResponse(
                         {"error": 'iRODS server failed to delete this iRODS account {0}. '
-                                  'Check the server log for details.'.format(user.username)},
+                                  'If this issue persists, please notify help@cuahsi.org.'.format(user.username)},
                         status=status.HTTP_500_INTERNAL_SERVER_ERROR
                     )
 
@@ -610,7 +610,8 @@ def delete_irods_account(request):
             )
         except Exception as ex:
             return JsonResponse(
-                    {"error": str(ex)},
+                    {"error": str(ex) + ' - iRODS server failed to delete this iRODS account. '
+                    'If this issue persists, please notify help@cuahsi.org.'},
                     status=status.HTTP_500_INTERNAL_SERVER_ERROR
             )
 
@@ -634,7 +635,7 @@ def create_irods_account(request):
                     # that the user already exists, report the error
                     return JsonResponse(
                         {"error": 'iRODS server failed to create this iRODS account {0}. '
-                                  'Check the server log for details.'.format(user.username)},
+                                  'If this issue persists, please notify help@cuahsi.org.'.format(user.username)},
                         status=status.HTTP_500_INTERNAL_SERVER_ERROR
                     )
 
@@ -642,12 +643,13 @@ def create_irods_account(request):
             user_profile.create_irods_user_account = True
             user_profile.save()
             return JsonResponse(
-                    {"success": "iRODS account {0} is created successfully".format(user.username)},
+                    {"success": "iRODS account {0} was created successfully".format(user.username)},
                     status=status.HTTP_200_OK
             )
         except Exception as ex:
             return JsonResponse(
-                    {"error": str(ex) + ' - iRODS server failed to create this iRODS account.'},
+                    {"error": str(ex) + ' - iRODS server failed to create this iRODS account. '
+                    'If this issue persists, please notify help@cuahsi.org.'},
                     status=status.HTTP_500_INTERNAL_SERVER_ERROR
             )
     else:


Test patch: