Repository: bridgecrewio/checkov

Issue:
CKV_AZURE_53 is a duplicate of CKV_AZURE_90
**Is your feature request related to a problem? Please describe.**
CKV_AZURE_53 is a duplicate of CKV_AZURE_90. We should use only one.

**Describe the solution you'd like**
N/A

**Describe alternatives you've considered**
N/A

**Additional context**
N/A


Discussion:
@schosterbarak looks like both do really the same, but `CKV_AZURE_53` looks better on how it is programmed 🙂 

Resolving patch:
diff --git a/checkov/terraform/checks/resource/azure/MySQLServerPublicAccessDisabled.py b/checkov/terraform/checks/resource/azure/MySQLServerPublicAccessDisabled.py
deleted file mode 100644
--- a/checkov/terraform/checks/resource/azure/MySQLServerPublicAccessDisabled.py
+++ /dev/null
@@ -1,23 +0,0 @@
-from checkov.common.models.enums import CheckCategories, CheckResult
-from checkov.terraform.checks.resource.base_resource_value_check import BaseResourceValueCheck
-
-
-class MySQLServerHasPublicAccessDisabled(BaseResourceValueCheck):
-    def __init__(self):
-        name = "Ensure that MySQL server disables public network access"
-        id = "CKV_AZURE_90"
-        supported_resources = ['azurerm_mysql_server']
-        categories = [CheckCategories.NETWORKING]
-        super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources)
-
-    def get_inspected_key(self):
-        return 'public_network_access_enabled'
-
-    def scan_resource_conf(self, conf):
-        public_access = conf.get('public_network_access_enabled', [True])
-        if public_access[0]:
-            return CheckResult.FAILED
-        return CheckResult.PASSED
-
-
-check = MySQLServerHasPublicAccessDisabled()


Test patch:
diff --git a/tests/terraform/checks/resource/azure/test_MySQLServerPublicAccessDisabled.py b/tests/terraform/checks/resource/azure/test_MySQLServerPublicAccessDisabled.py
deleted file mode 100644
--- a/tests/terraform/checks/resource/azure/test_MySQLServerPublicAccessDisabled.py
+++ /dev/null
@@ -1,93 +0,0 @@
-import unittest
-
-import hcl2
-
-from checkov.terraform.checks.resource.azure.MySQLServerPublicAccessDisabled import check
-from checkov.common.models.enums import CheckResult
-
-
-class TestMysqlSQLServerPublicAccessDisabled(unittest.TestCase):
-
-    def test_failure_1(self):
-        hcl_res = hcl2.loads("""
-            resource "azurerm_mysql_server" "example" {
-              name                = "example-mysqlserver"
-              location            = azurerm_resource_group.example.location
-              resource_group_name = azurerm_resource_group.example.name
-            
-              administrator_login          = "mysqladminun"
-              administrator_login_password = "H@Sh1CoR3!"
-            
-              sku_name   = "B_Gen5_2"
-              storage_mb = 5120
-              version    = "5.7"
-            
-              auto_grow_enabled                 = true
-              backup_retention_days             = 7
-              geo_redundant_backup_enabled      = false
-              infrastructure_encryption_enabled = false
-              public_network_access_enabled     = true
-              ssl_enforcement_enabled           = true
-              ssl_minimal_tls_version_enforced  = "TLS1_2"
-            }
-                """)
-        resource_conf = hcl_res['resource'][0]['azurerm_mysql_server']['example']
-        scan_result = check.scan_resource_conf(conf=resource_conf)
-        self.assertEqual(CheckResult.FAILED, scan_result)
-
-    def test_failure_2(self):
-        hcl_res = hcl2.loads("""
-            resource "azurerm_mysql_server" "example" {
-              name                = "example-mysqlserver"
-              location            = azurerm_resource_group.example.location
-              resource_group_name = azurerm_resource_group.example.name
-            
-              administrator_login          = "mysqladminun"
-              administrator_login_password = "H@Sh1CoR3!"
-            
-              sku_name   = "B_Gen5_2"
-              storage_mb = 5120
-              version    = "5.7"
-            
-              auto_grow_enabled                 = true
-              backup_retention_days             = 7
-              geo_redundant_backup_enabled      = false
-              infrastructure_encryption_enabled = false
-              ssl_enforcement_enabled           = true
-              ssl_minimal_tls_version_enforced  = "TLS1_2"
-            }
-                """)
-        resource_conf = hcl_res['resource'][0]['azurerm_mysql_server']['example']
-        scan_result = check.scan_resource_conf(conf=resource_conf)
-        self.assertEqual(CheckResult.FAILED, scan_result)
-
-    def test_success(self):
-        hcl_res = hcl2.loads("""
-            resource "azurerm_mysql_server" "example" {
-              name                = "example-mysqlserver"
-              location            = azurerm_resource_group.example.location
-              resource_group_name = azurerm_resource_group.example.name
-            
-              administrator_login          = "mysqladminun"
-              administrator_login_password = "H@Sh1CoR3!"
-            
-              sku_name   = "B_Gen5_2"
-              storage_mb = 5120
-              version    = "5.7"
-            
-              auto_grow_enabled                 = true
-              backup_retention_days             = 7
-              geo_redundant_backup_enabled      = false
-              infrastructure_encryption_enabled = false
-              public_network_access_enabled     = false
-              ssl_enforcement_enabled           = true
-              ssl_minimal_tls_version_enforced  = "TLS1_2"
-            }
-                """)
-        resource_conf = hcl_res['resource'][0]['azurerm_mysql_server']['example']
-        scan_result = check.scan_resource_conf(conf=resource_conf)
-        self.assertEqual(CheckResult.PASSED, scan_result)
-
-
-if __name__ == '__main__':
-    unittest.main()
diff --git a/tests/terraform/runner/test_runner.py b/tests/terraform/runner/test_runner.py
--- a/tests/terraform/runner/test_runner.py
+++ b/tests/terraform/runner/test_runner.py
@@ -236,6 +236,8 @@ def test_no_missing_ids(self):
                 continue  # Pending merge; blocked by another issue https://github.com/bridgecrewio/checkov/pull/429
             if f'CKV_AZURE_{i}' == 'CKV_AZURE_51':
                 continue  # https://github.com/bridgecrewio/checkov/pull/983
+            if f"CKV_AZURE_{i}" == "CKV_AZURE_90":
+                continue  # duplicate of CKV_AZURE_53
             if f'CKV_AZURE_{i}' == 'CKV_AZURE_119':
                 continue  # this rule has been refactored into a v2 graph implementation