Repository: cobbler/cobbler

Issue:
some lines  only have three blank intent in action_dlcontent.py  
please check action_dlcontent.py .



Discussion:
True. But we don't have a code style formulated with regard to white spacing. So this kind of inconsistency is all over the code base. So, basically we shall not fix this. 


Resolving patch:
diff --git a/cobbler/action_dlcontent.py b/cobbler/action_dlcontent.py
--- a/cobbler/action_dlcontent.py
+++ b/cobbler/action_dlcontent.py
@@ -26,61 +26,61 @@
 
 class ContentDownloader:
 
-   def __init__(self,config,logger=None):
-       """
-       Constructor
-       """
-       self.config   = config
-       self.settings = config.settings()
-       if logger is None:
-           logger       = clogger.Logger()
-       self.logger      = logger
-
-
-   def run(self,force=False):
-       """
-       Download bootloader content for all of the latest bootloaders, since the user
-       has chosen to not supply their own.  You may ask "why not get this from yum", though
-       Fedora has no IA64 repo, for instance, and we also want this to be able to work on Debian and
-       further do not want folks to have to install a cross compiler.  For those that don't like this approach
-       they can still source their cross-arch bootloader content manually.
-       """
-
-       content_server = "http://www.cobblerd.org/loaders"
-       dest = "/var/lib/cobbler/loaders"
-
-       files = (
-          ( "%s/README" % content_server, "%s/README" % dest ),
-          ( "%s/COPYING.elilo" % content_server, "%s/COPYING.elilo" % dest ),
-          ( "%s/COPYING.yaboot" % content_server, "%s/COPYING.yaboot" % dest),
-          ( "%s/COPYING.syslinux" % content_server, "%s/COPYING.syslinux" % dest),
-          ( "%s/elilo-3.8-ia64.efi" % content_server, "%s/elilo-ia64.efi" % dest ),
-          ( "%s/yaboot-1.3.14-12" % content_server, "%s/yaboot" % dest),
-          ( "%s/pxelinux.0-3.86" % content_server, "%s/pxelinux.0" % dest),
-          ( "%s/menu.c32-3.86" % content_server, "%s/menu.c32" % dest),
-          ( "%s/grub-0.97-x86.efi" % content_server, "%s/grub-x86.efi" % dest),
-          ( "%s/grub-0.97-x86_64.efi" % content_server, "%s/grub-x86_64.efi" % dest),
-       )
-
-       proxies = {}
-       if os.environ.has_key("HTTP_PROXY"):
-          proxies['http'] = os.environ["HTTP_PROXY"]
-
-       if os.environ.has_key("HTTPS_PROXY"):
-          proxies['https'] = os.environ["HTTPS_PROXY"]
-
-       if os.environ.has_key("FTP_PROXY"):
-          proxies['ftp'] = os.environ["FTP_PROXY"]
-
-       if len(proxies) == 0:
-          proxies = None
-
-       for src,dst in files:
-          if os.path.exists(dst) and not force:
-             self.logger.info("path %s already exists, not overwriting existing content, use --force if you wish to update" % dst)
-             continue
-          self.logger.info("downloading %s to %s" % (src,dst))
-          urlgrabber.grabber.urlgrab(src, filename=dst, proxies=proxies)
-
-       return True
+    def __init__(self,config,logger=None):
+        """
+        Constructor
+        """
+        self.config   = config
+        self.settings = config.settings()
+        if logger is None:
+            logger       = clogger.Logger()
+        self.logger      = logger
+
+
+    def run(self,force=False):
+        """
+        Download bootloader content for all of the latest bootloaders, since the user
+        has chosen to not supply their own.  You may ask "why not get this from yum", though
+        Fedora has no IA64 repo, for instance, and we also want this to be able to work on Debian and
+        further do not want folks to have to install a cross compiler.  For those that don't like this approach
+        they can still source their cross-arch bootloader content manually.
+        """
+
+        content_server = "http://www.cobblerd.org/loaders"
+        dest = "/var/lib/cobbler/loaders"
+
+        files = (
+           ( "%s/README" % content_server, "%s/README" % dest ),
+           ( "%s/COPYING.elilo" % content_server, "%s/COPYING.elilo" % dest ),
+           ( "%s/COPYING.yaboot" % content_server, "%s/COPYING.yaboot" % dest),
+           ( "%s/COPYING.syslinux" % content_server, "%s/COPYING.syslinux" % dest),
+           ( "%s/elilo-3.8-ia64.efi" % content_server, "%s/elilo-ia64.efi" % dest ),
+           ( "%s/yaboot-1.3.14-12" % content_server, "%s/yaboot" % dest),
+           ( "%s/pxelinux.0-3.86" % content_server, "%s/pxelinux.0" % dest),
+           ( "%s/menu.c32-3.86" % content_server, "%s/menu.c32" % dest),
+           ( "%s/grub-0.97-x86.efi" % content_server, "%s/grub-x86.efi" % dest),
+           ( "%s/grub-0.97-x86_64.efi" % content_server, "%s/grub-x86_64.efi" % dest),
+        )
+
+        proxies = {}
+        if os.environ.has_key("HTTP_PROXY"):
+            proxies['http'] = os.environ["HTTP_PROXY"]
+
+        if os.environ.has_key("HTTPS_PROXY"):
+            proxies['https'] = os.environ["HTTPS_PROXY"]
+
+        if os.environ.has_key("FTP_PROXY"):
+            proxies['ftp'] = os.environ["FTP_PROXY"]
+
+        if len(proxies) == 0:
+            proxies = None
+
+        for src,dst in files:
+            if os.path.exists(dst) and not force:
+                self.logger.info("path %s already exists, not overwriting existing content, use --force if you wish to update" % dst)
+                continue
+            self.logger.info("downloading %s to %s" % (src,dst))
+            urlgrabber.grabber.urlgrab(src, filename=dst, proxies=proxies)
+
+        return True
 
diff --git a/cobbler/item_distro.py b/cobbler/item_distro.py
--- a/cobbler/item_distro.py
+++ b/cobbler/item_distro.py
@@ -175,9 +175,9 @@ def set_os_version(self, os_version):
 
     def set_initrd(self,initrd):
         """
-	Specifies an initrd image.  Path search works as in set_kernel.
-	File must be named appropriately.
-	"""
+	    Specifies an initrd image.  Path search works as in set_kernel.
+	    File must be named appropriately.
+	    """
         if initrd is None or initrd == "":
             raise CX("initrd not specified")
         if utils.find_initrd(initrd):


Test patch: