Repository: rucio/rucio

Issue:
Remove gfalv2 implementation
Motivation
----------

This has already been superseded since 1.26 as `gfal.NoRename`


Discussion:

Resolving patch:
diff --git a/lib/rucio/rse/protocols/gfalv2.py b/lib/rucio/rse/protocols/gfalv2.py
deleted file mode 100644
--- a/lib/rucio/rse/protocols/gfalv2.py
+++ /dev/null
@@ -1,63 +0,0 @@
-# Copyright 2016-2020 CERN for the benefit of the ATLAS collaboration.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-# Authors:
-# - Vincent Garonne <vgaronne@gmail.com>, 2016
-# - Hannes Hansen <hannes.jakob.hansen@cern.ch>, 2018-2019
-# - Tomas Javurek <tomasjavurek09@gmail.com>, 2020
-# - Mario Lassnig <mario.lassnig@cern.ch>, 2020
-#
-# PY3K COMPATIBLE
-
-# !!! DEPRECATION WARNING !!!
-#
-# This module will go away.
-#
-# Use instead: impl=rucio.rse.protocols.gfal.NoRename
-#
-# !!! DEPRECATION WARNING !!!
-
-try:
-    # PY2
-    from exceptions import NotImplementedError
-except ImportError:
-    # PY3
-    pass
-
-from rucio.rse.protocols import gfal
-
-
-class Default(gfal.Default):
-
-    """ Implementing access to RSEs using the ngarc protocol."""
-
-    def __init__(self, protocol_attr, rse_settings, logger=None):
-        """ Initializes the object with information about the referred RSE.
-
-            :param props Properties derived from the RSE Repository
-        """
-        super(Default, self).__init__(protocol_attr, rse_settings, logger=logger)
-        self.renaming = False
-        self.attributes.pop('determinism_type', None)
-        self.files = []
-
-    def rename(self, pfn, new_pfn):
-        """ Allows to rename a file stored inside the connected RSE.
-
-            :param pfn      Current physical file name
-            :param new_pfn  New physical file name
-
-            :raises DestinationNotAccessible, ServiceUnavailable, SourceNotFound
-        """
-        raise NotImplementedError


Test patch:
diff --git a/lib/rucio/tests/test_replica.py b/lib/rucio/tests/test_replica.py
--- a/lib/rucio/tests/test_replica.py
+++ b/lib/rucio/tests/test_replica.py
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# Copyright 2013-2021 CERN
+# Copyright 2013-2022 CERN
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
 # Authors:
 # - Vincent Garonne <vincent.garonne@cern.ch>, 2013-2018
 # - Ralph Vigne <ralph.vigne@cern.ch>, 2013-2014
-# - Mario Lassnig <mario.lassnig@cern.ch>, 2013-2020
+# - Mario Lassnig <mario.lassnig@cern.ch>, 2013-2022
 # - Cedric Serfon <cedric.serfon@cern.ch>, 2014-2021
 # - Thomas Beermann <thomas.beermann@cern.ch>, 2014
 # - Martin Barisits <martin.barisits@cern.ch>, 2015-2021
@@ -406,7 +406,7 @@ def test_list_replica_with_schemes(self, rse_factory, mock_scope, root_account,
                               'hostname': 'http.aperture.com',
                               'port': 80,
                               'prefix': '//test/chamber/',
-                              'impl': 'rucio.rse.protocols.gfalv2.Default',
+                              'impl': 'rucio.rse.protocols.gfal.Default',
                               'domains': {
                                   'lan': {'read': 1, 'write': 1, 'delete': 1},
                                   'wan': {'read': 1, 'write': 1, 'delete': 1}}})