Repository: holoviz/hvplot

Issue:
Incorrect param warning on bar plot + width
There is a new param warning that feels incorrect:

`WARNING:param.BarPlot02810: BarPlot width option is deprecated use 'bar_width' instead.`

<img width="1010" alt="Screen Shot 2019-08-08 at 9 57 27 AM" src="https://user-images.githubusercontent.com/4806877/62709258-0418b480-b9c3-11e9-985d-67eebb658669.png">



Discussion:

Resolving patch:
diff --git a/hvplot/converter.py b/hvplot/converter.py
--- a/hvplot/converter.py
+++ b/hvplot/converter.py
@@ -357,10 +357,9 @@ def __init__(self, data, x, y, kind=None, by=None, use_index=True,
 
         # Process options
         self.stacked = stacked
-        self._style_opts, kwds = self._process_style(kwds)
 
         plot_opts = {**self._default_plot_opts,
-                     **self._process_plot(self._style_opts.get('color'))}
+                     **self._process_plot()}
         if xlim is not None:
             plot_opts['xlim'] = tuple(xlim)
         if ylim is not None:
@@ -397,6 +396,8 @@ def __init__(self, data, x, y, kind=None, by=None, use_index=True,
             if plotwd in kwds:
                 plot_opts[plotwd] = kwds.pop(plotwd)
 
+        self._style_opts, plot_opts, kwds = self._process_style(kwds, plot_opts)
+
         for axis_name in ['xaxis', 'yaxis']:
             if axis_name in kwds:
                 axis = kwds.pop(axis_name)
@@ -692,7 +693,7 @@ def _process_data(self, kind, data, x, y, by, groupby, row, col,
                     param.main.warning('Unable to auto label using xarray attrs '
                                        'because {e}'.format(e=e))
 
-    def _process_plot(self, color):
+    def _process_plot(self):
         kind = self.kind
         options = Store.options(backend='bokeh')
         elname = self._kind_mapping[kind].__name__
@@ -701,15 +702,9 @@ def _process_plot(self, color):
         if kind.startswith('bar'):
             plot_opts['stacked'] = self.stacked
 
-        # Color
-        if color is not None and 'colorbar' not in plot_opts:
-            if 'c' in self._kind_options.get(kind, []) and (color in self.variables):
-                if self.data[color].dtype.kind not in 'OSU':
-                    plot_opts['colorbar'] = True
-
         return plot_opts
 
-    def _process_style(self, kwds):
+    def _process_style(self, kwds, plot_opts):
         kind = self.kind
         eltype = self._kind_mapping[kind]
         registry =  Store.registry['bokeh']
@@ -756,6 +751,7 @@ def _process_style(self, kwds):
                     cmap = cmap or self._default_cmaps['categorical']
                 else:
                     cmap = cmap or self._default_cmaps['linear']
+                    plot_opts['colorbar'] = plot_opts.get('colorbar', True)
 
         if isinstance(cmap, str) and cmap in self._default_cmaps:
             cmap = self._default_cmaps[cmap]
@@ -798,7 +794,7 @@ def _process_style(self, kwds):
         if 'marker' in kwds and 'marker' in self._kind_options[self.kind]:
             style_opts['marker'] = kwds.pop('marker')
 
-        return style_opts, kwds
+        return style_opts, plot_opts, kwds
 
     def _validate_kwds(self, kwds):
         kind_opts = self._kind_options.get(self.kind, [])
@@ -1338,7 +1334,7 @@ def kde(self, x, y, data=None):
                 dists = NdOverlay({0: Area([], self.value_label, vdim)},
                                   [self.group_label])
         redim = self._merge_redim(ranges)
-        return (dists.redim(redim).relabel(**self._relabel).opts(opts))
+        return (dists.redim(**redim).relabel(**self._relabel).opts(opts))
 
     ##########################
     #      Other charts      #


Test patch:
diff --git a/etc/test_notebooks.py b/etc/test_notebooks.py
deleted file mode 100644
--- a/etc/test_notebooks.py
+++ /dev/null
@@ -1,90 +0,0 @@
-# Temporary script to allow checking notebooks run without errors, or
-# to approximately lint check notebooks.
-#
-# Note: lint checking will not yet work on windows unless sed is
-# present or we replace sed with python equivalent.
-#
-# Run all notebooks & render to html:
-#  python examples/test_notebooks.py
-#
-# Approximately lint check all notebooks:
-#  python examples/test_notebooks.py lint
-
-from __future__ import print_function
-
-import sys
-import os
-import glob
-import pprint
-
-############################################################
-# Set nbdir, run_skip, and run_allow_error for your project.
-# You may need to increase run_cell_timeout if you have
-# notebook cells that take a long time to execute.
-
-nbdir = "examples"
-
-run_skip = []
-
-run_allow_error = []
-
-run_cell_timeout = 360
-
-############################################################
-
-
-notebooks = sorted([x.replace(os.path.sep,"/") for x in glob.glob(nbdir+"/*.ipynb")])
-
-checked = []
-errored = []
-run_skipped = []
-
-if len(sys.argv) == 1:
-    do_what = "run"
-elif sys.argv[1] == "lint":
-    do_what = "lint"
-else:
-    raise
-
-if do_what=="run":
-    for nb in notebooks:
-        cmd = "jupyter nbconvert %s --execute --ExecutePreprocessor.kernel_name=python%s --ExecutePreprocessor.timeout=%s --to html"%(nb,sys.version_info[0],run_cell_timeout)
-        if nb in run_skip:
-            run_skipped.append(nb)
-            continue
-            
-        if nb in run_allow_error:
-            cmd += " --allow-errors"
-        print(cmd)
-        r = os.system(cmd)
-        checked.append(nb)
-        if r!=0:
-            errored.append(nb)
-
-elif sys.argv[1]=='lint':
-    for nb in notebooks:
-        cmd = """sed -e 's/%/#%/' {f} > {f}~ && jupyter nbconvert {f}~ --to python --PythonExporter.file_extension=.py~ && flake8 --ignore=E,W {p}""".format(f=nb,p=nb[0:-5]+'py~')
-        print(cmd)
-        r = os.system(cmd)
-        checked.append(nb)
-        if r!=0:
-            errored.append(nb)
-else:
-    raise
-
-print("%s checked"%len(checked))
-if len(checked)>0: pprint.pprint(checked)
-print()
-print("%s error(s)"%len(errored))
-if len(errored)>0: pprint.pprint(errored)
-print()
-
-if do_what == 'run':
-    print("%s skipped"%len(run_skipped))
-    if len(run_skipped)>0: pprint.pprint(run_skipped)
-    print()
-    if len(run_allow_error) > 0:
-        print("Note: the following notebooks were not checked for run errors:")
-        pprint.pprint(run_allow_error)
-
-sys.exit(len(errored))