Repository: numpy/numpy

Issue:
Numpy logo in new theme links to an undesirable page
It goes to https://numpy.org/devdocs/contents.html instead of the index.




Discussion:
Can I work on this issue? And I'm a first-timer so can I get help in case I'm stuck ?
In general: We don't really assign issues, help is welcome. We do appreciate that getting started with NumPy can be challenging, so please feel free to submit a PR, even if it is clearly wrong, and ask for help. 

We have a general overview of how to contribute [here](https://numpy.org/doc/stable/dev/index.html). Since this is a documentation issue, you will want to also read about [building the docs](https://numpy.org/doc/stable/dev/index.html#building-docs) locally.

This specific issue may be challenging if this is your first encounter with sphinx and theming.
Did some digging and it turns out the problem is that `pydata-sphinx-theme` set the link to `master_doc` instead of `index`.

One obvious way to get around this is to use bare `index.rst` file instead of a custom HTML template - or I guess we can "hardcode" the HTML template in `index.rst` but it would be very messy in my opinion.

In any case, I have created a PR in their repo to change the logo reference to `index` instead of `master_doc`. If the PR is accepted, this issue should be fixed.
Thanks for looking at this. Could you link to the PR here so we can track it?
Here it is: pandas-dev/pydata-sphinx-theme#246
My reading of this is that our `master_doc` value is wrong: I'd argue the top-level webpage and top-level toctree should be one and the same.
Maybe, but then there needs to be a way to specify which documents we want on the top navbar. Currently that is taken from the toctree of `master_doc`.
What is the toctree of index right now?
It is not a toctree, it is a pre-formatted html document `_templates/indexcontent.html`. I had played with turning this into a rst document with a toctree, which led me to the conclusion above.
Can we make it an rst document with an `.. html::` directive and a hidden toctree?
> Maybe, but then there needs to be a way to specify which documents we want on the top navbar. Currently, that is taken from the toctree of `master_doc`.

Yeah it looks like this is what's going to be done in `pydata-sphinx-theme` (i.e. provide an option).

That said, I'd like to think NumPy's method to change `master_doc` to `contents` in order to create a custom landing webpage is not entirely outlandish. For example, this documentation uses the same method https://fairlearn.github.io/about/index.html and has the same problem as well (i.e. logo links to `contents` instead of `index`).
Just when I thought I knew a lot about sphinx: what is an `.. html::` directive? 
A misremembering... I mean `.. raw:: html`
Ahh, cool. Although [the admonition in the docs](https://docutils.sourceforge.io/docs/ref/rst/directives.html#raw-data-pass-through) is not encouraging, it would provide a path forward until the theme has an option for the top navbar.
I think that admonition would be equally against what we're already doing of having a standalone html page - it's just that what we're using today is a Sphinx not docutil feature.
Is there something I need to learn as I don't completely understand most of the discussion above ?. Help me please. Thank you.

Resolving patch:
diff --git a/doc/source/conf.py b/doc/source/conf.py
--- a/doc/source/conf.py
+++ b/doc/source/conf.py
@@ -161,6 +161,7 @@ def setup(app):
 html_logo = '_static/numpylogo.svg'
 
 html_theme_options = {
+  "logo_link": "index",
   "github_url": "https://github.com/numpy/numpy",
   "twitter_url": "https://twitter.com/numpy_team",
 }


Test patch: