Repository: mdn/kuma

Issue:
I set default language english in profile, but site's language always my local.
@hzx commented on [Thu Feb 20 2020](https://github.com/mdn/sprints/issues/2837)

# Request type
<!-- Select the appropriate option -->
- [ ] Show site in language I set in my profile. In addition even after selecting default language in popup.

# Details
I set default language english in profile, but site's language always my local.
<img width="1790" alt="Screen Shot 2020-02-21 at 02 34 40" src="https://user-images.githubusercontent.com/869203/74990065-45e6e500-5453-11ea-9e0d-015dcb6fa4f8.png">

<img width="1781" alt="Screen Shot 2020-02-21 at 02 35 22" src="https://user-images.githubusercontent.com/869203/74990066-4a130280-5453-11ea-8f05-76d781c4002b.png">

<img width="627" alt="Screen Shot 2020-02-21 at 02 40 17" src="https://user-images.githubusercontent.com/869203/74990160-8e9e9e00-5453-11ea-994f-132b3340c13e.png">

<img width="1792" alt="Screen Shot 2020-02-21 at 02 41 51" src="https://user-images.githubusercontent.com/869203/74990386-3caa4800-5454-11ea-940c-bc176e10f08a.png">


---

@chrisdavidmills commented on [Fri Feb 21 2020](https://github.com/mdn/sprints/issues/2837#issuecomment-589607478)

This is more of a platform issue, so I'll move this over to the kuma repo.




Discussion:

Resolving patch:
diff --git a/kuma/settings/common.py b/kuma/settings/common.py
--- a/kuma/settings/common.py
+++ b/kuma/settings/common.py
@@ -901,7 +901,6 @@ def pipeline_one_scss(slug, **kwargs):
             "js/components/banners/banners.js",
         ),
         "output_filename": "build/js/banners.js",
-        "extra_context": {"async": True},
     },
     "mathml": {
         "source_filenames": ("js/components/mathml.js",),
@@ -911,12 +910,10 @@ def pipeline_one_scss(slug, **kwargs):
     "users": {
         "source_filenames": ("js/users.js",),
         "output_filename": "build/js/users.js",
-        "extra_context": {"async": True},
     },
     "user-signup": {
         "source_filenames": ("js/components/user-signup/signup.js",),
         "output_filename": "build/js/signup.js",
-        "extra_context": {"async": True},
     },
     "delete-user-page": {
         "source_filenames": (
@@ -945,7 +942,6 @@ def pipeline_one_scss(slug, **kwargs):
     "dashboard": {
         "source_filenames": ("js/dashboard.js",),
         "output_filename": "build/js/dashboard.js",
-        "extra_context": {"async": True},
     },
     "jquery-ui": {
         "source_filenames": (
@@ -958,7 +954,6 @@ def pipeline_one_scss(slug, **kwargs):
     "search": {
         "source_filenames": ("js/search.js",),
         "output_filename": "build/js/search.js",
-        "extra_context": {"async": True},
     },
     "payments": {
         "source_filenames": ("js/components/payments/payments-manage.js",),
@@ -1005,7 +1000,6 @@ def pipeline_one_scss(slug, **kwargs):
             "js/components/page-load-actions.js",
         ),
         "output_filename": "build/js/wiki.js",
-        "extra_context": {"async": True},
     },
     "wiki-edit": {
         "source_filenames": (
@@ -1019,7 +1013,6 @@ def pipeline_one_scss(slug, **kwargs):
     "wiki-move": {
         "source_filenames": ("js/wiki-move.js",),
         "output_filename": "build/js/wiki-move.js",
-        "extra_context": {"async": True},
     },
     "wiki-compat-tables": {
         "source_filenames": ("js/wiki-compat-tables.js",),
@@ -1029,7 +1022,6 @@ def pipeline_one_scss(slug, **kwargs):
     "task-completion": {
         "source_filenames": ("js/task-completion.js",),
         "output_filename": "build/js/task-completion.js",
-        "extra_context": {"async": True},
     },
     "newsletter": {
         "source_filenames": ("js/newsletter.js",),


Test patch: