Repository: great-expectations/great_expectations

Issue:
Use cleaner solution for non-truncating division in python 2
Prefer `from __future__ import division` to `1.*x/y`


Discussion:
Done inline during improve_partitions push.

Resolving patch:
diff --git a/examples/expectations/column_aggregate_expectation_template.py b/examples/expectations/column_aggregate_expectation_template.py
--- a/examples/expectations/column_aggregate_expectation_template.py
+++ b/examples/expectations/column_aggregate_expectation_template.py
@@ -34,14 +34,14 @@ def _pandas(cls, column, **kwargs):
         raise NotImplementedError
 
     # This method defines the business logic for evaluating your Metric when using a SqlAlchemyExecutionEngine
-    @column_aggregate_partial(engine=SqlAlchemyExecutionEngine)
-    def _sqlalchemy(cls, column, _dialect, **kwargs):
-        raise NotImplementedError
-
+    # @column_aggregate_partial(engine=SqlAlchemyExecutionEngine)
+    # def _sqlalchemy(cls, column, _dialect, **kwargs):
+    #     raise NotImplementedError
+    #
     # This method defines the business logic for evaluating your Metric when using a SparkDFExecutionEngine
-    @column_aggregate_partial(engine=SparkDFExecutionEngine)
-    def _spark(cls, column, **kwargs):
-        raise NotImplementedError
+    # @column_aggregate_partial(engine=SparkDFExecutionEngine)
+    # def _spark(cls, column, **kwargs):
+    #     raise NotImplementedError
 
 
 # This class defines the Expectation itself
diff --git a/examples/expectations/column_map_expectation_template.py b/examples/expectations/column_map_expectation_template.py
--- a/examples/expectations/column_map_expectation_template.py
+++ b/examples/expectations/column_map_expectation_template.py
@@ -31,14 +31,14 @@ def _pandas(cls, column, **kwargs):
         raise NotImplementedError
 
     # This method defines the business logic for evaluating your metric when using a SqlAlchemyExecutionEngine
-    @column_condition_partial(engine=SqlAlchemyExecutionEngine)
-    def _sqlalchemy(cls, column, _dialect, **kwargs):
-        raise NotImplementedError
+    # @column_condition_partial(engine=SqlAlchemyExecutionEngine)
+    # def _sqlalchemy(cls, column, _dialect, **kwargs):
+    #     raise NotImplementedError
 
     # This method defines the business logic for evaluating your metric when using a SparkDFExecutionEngine
-    @column_condition_partial(engine=SparkDFExecutionEngine)
-    def _spark(cls, column, **kwargs):
-        raise NotImplementedError
+    # @column_condition_partial(engine=SparkDFExecutionEngine)
+    # def _spark(cls, column, **kwargs):
+    #     raise NotImplementedError
 
 
 # This class defines the Expectation itself


Test patch:
diff --git a/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_column_max_to_be_between_custom.py b/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_column_max_to_be_between_custom.py
--- a/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_column_max_to_be_between_custom.py
+++ b/tests/integration/docusaurus/expectations/creating_custom_expectations/expect_column_max_to_be_between_custom.py
@@ -117,7 +117,6 @@ class ExpectColumnMaxToBeBetweenCustom(ColumnExpectation):
             "test_backends": [
                 {
                     "backend": "pandas",
-                    "dialects": None,
                 },
                 {
                     "backend": "sqlalchemy",
@@ -125,7 +124,6 @@ class ExpectColumnMaxToBeBetweenCustom(ColumnExpectation):
                 },
                 {
                     "backend": "spark",
-                    "dialects": None,
                 },
             ],
         }