Repository: deepset-ai/haystack

Issue:
PR stuck after approval and automated "Update Documentation & Code Style" commit
**Describe the bug**
See https://github.com/deepset-ai/haystack/pull/2838
This PR has approval, all tests passed and is ready to merge. However due to the "Update Documentation & Code Style" commit, the required tests have not been executed and it's stuck. Manually executing the Test workflow on this branch does not help: see https://github.com/deepset-ai/haystack/actions/runs/2692003395.

All I can do, is make a minimal change to trigger the Test workflow correctly. That's cumbersome.

**Expected behavior**
Being able to merge after "Update Documentation & Code Style" commit when all tests of the previous commit are green or maybe easier: being able to manually trigger the workflow to run all required tests for merging.

**To Reproduce**
- Create PR with docs change
- Wait till workflows pass correctly and someone approves


Discussion:

Resolving patch:
diff --git a/.github/utils/convert_notebooks_into_webpages.py b/.github/utils/convert_notebooks_into_webpages.py
old mode 100644
new mode 100755
--- a/.github/utils/convert_notebooks_into_webpages.py
+++ b/.github/utils/convert_notebooks_into_webpages.py
@@ -1,3 +1,5 @@
+#!/usr/bin/env python3
+
 import re
 
 from nbconvert import MarkdownExporter
@@ -142,7 +144,7 @@
 id: "tutorial17md"
 --->""",
     18: """<!---
-title: "Tutorial 18"    
+title: "Tutorial 18"
 metaTitle: "GPL Domain Adaptation"
 metaDescription: ""
 slug: "/docs/tutorial18"
diff --git a/.github/utils/generate_json_schema.py b/.github/utils/generate_json_schema.py
old mode 100644
new mode 100755
--- a/.github/utils/generate_json_schema.py
+++ b/.github/utils/generate_json_schema.py
@@ -1,3 +1,5 @@
+#!/usr/bin/env python3
+
 import sys
 import logging
 from pathlib import Path
diff --git a/.github/utils/generate_openapi_specs.py b/.github/utils/generate_openapi_specs.py
old mode 100644
new mode 100755
--- a/.github/utils/generate_openapi_specs.py
+++ b/.github/utils/generate_openapi_specs.py
@@ -1,3 +1,5 @@
+#!/usr/bin/env python3
+
 import json
 from pathlib import Path
 import os


Test patch:
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -96,7 +96,7 @@ jobs:
 
     - name: Setup Python
       uses: ./.github/actions/python_cache/
-      
+
     - name: Install torch-scatter
       run: pip install torch-scatter -f https://data.pyg.org/whl/torch-1.12.0+cpu.html
 
@@ -499,7 +499,7 @@ jobs:
       run: |
         pip install -U rest_api/
         pip install -U ui/
-        
+
     - name: Run tests
       run: |
         pytest ${{ env.PYTEST_PARAMS }} rest_api/ ui/
@@ -618,39 +618,3 @@ jobs:
       # FIXME many tests are disabled here!
       run: |
         pytest ${{ env.PYTEST_PARAMS }} -m "integration and not tika and not graphdb" ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} test/${{ matrix.folder }} --document_store_type=memory,faiss,elasticsearch
-
-
-  # This CI action mirrors autoformat.yml, with the difference that it
-  # runs on Haystack's end. If the contributor hasn't run autoformat.yml,
-  # then this check will fail.
-  bot-check:
-    runs-on: ubuntu-latest
-    needs: unit-tests-linux
-    steps:
-
-      - uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: ./.github/actions/python_cache/
-
-      - name: Install Dependencies
-        run: |
-          pip install --upgrade pip
-          pip install .[all]
-          pip install rest_api/
-          pip install ui/
-
-      - name: Code and Docs Updates
-        run: ./.github/utils/code_and_docs.sh
-
-      # If there is anything to commit, fail
-      - name: Check status
-        run: |
-          if [[ `git status --porcelain` ]]; then
-            git status
-            echo ""
-            echo "This means that the 'autoformat.yml' action didn't run."
-            echo "Please enable GitHub Action on your fork to pass this check!"
-            echo "See https://github.com/deepset-ai/haystack/blob/master/CONTRIBUTING.md#forks for instructions"
-            exit 1
-          fi