Repository: lutris/lutris

Issue:
Installing from Lutris can fail silently
### Bug description

Some Lutris games can't be installed, but give no error- Install just does nothing.

This seems to happen for games with no installation scripts. The example I have is "Attack of the Earthlings"- that is on Lutris as "https://lutris.net/games/attack-of-the-earthlings/", but somehow the search can't seem to find it. Lutris has no scripts for this.

### How to Reproduce

Open Lutris and go to the "Lutris" section. Select "Attack of the Earthlings"; an "Install" button will appear in the game box. Click it.

Nothing happens.

There's a catch though; if you've installed it once it'll be in the PGA, and then it will know to install it the same way as before. You have to install something that's not in the PGA, I think.

### Expected behavior

I expect an error message in this case.

I see the debug output in the log, "Wait? how did you get here?". Attack of the Earthlings, that's how.

### Log output

```shell
INFO     2021-12-25 13:12:58,931 [startup.check_driver:53]:Using NVIDIA drivers 470.86 for x86_64
INFO     2021-12-25 13:12:58,931 [startup.check_driver:57]:GPU: NVIDIA GeForce RTX 3060
INFO     2021-12-25 13:12:58,931 [startup.check_driver:73]:GPU: 10DE:2503 196E:1377 (nvidia drivers)
DEBUG    2021-12-25 13:12:59,112 [lutriswindow.update_store:451]:Showing 24 games
DEBUG    2021-12-25 13:13:00,566 [lutriswindow.update_store:451]:Showing 25 games
DEBUG    2021-12-25 13:13:04,902 [lutriswindow.update_store:451]:Showing 21 games
DEBUG    2021-12-25 13:13:06,475 [lutriswindow.update_store:451]:Showing 175 games
DEBUG    2021-12-25 13:13:11,812 [__init__.fetch_script:22]:Fetching installer https://lutris.net/api/installers/attack-of-the-earthlings
DEBUG    2021-12-25 13:13:11,812 [http.get:81]:GET https://lutris.net/api/installers/attack-of-the-earthlings
DEBUG    2021-12-25 13:13:11,962 [application.on_game_install:515]:Should generate automagical installer here but....
DEBUG    2021-12-25 13:13:11,962 [application.on_game_install:516]:Wait? how did you get here?
DEBUG    2021-12-25 13:13:15,044 [__init__.fetch_script:22]:Fetching installer https://lutris.net/api/installers/attack-of-the-earthlings
DEBUG    2021-12-25 13:13:15,045 [http.get:81]:GET https://lutris.net/api/installers/attack-of-the-earthlings
DEBUG    2021-12-25 13:13:15,208 [application.on_game_install:515]:Should generate automagical installer here but....
DEBUG    2021-12-25 13:13:15,208 [application.on_game_install:516]:Wait? how did you get here?
INFO     2021-12-25 13:13:18,515 [application.do_shutdown:631]:Shutting down Lutris
```


### System Information

```shell
[System]
OS:              Pop!_OS 21.10 impish
Arch:            x86_64
Kernel:          5.15.8-76051508-generic
Desktop:         GNOME
Display Server:  x11

[CPU]
Vendor:          AuthenticAMD
Model:           AMD Ryzen 7 5800X 8-Core Processor
Physical cores:  8
Logical cores:   16

[Memory]
RAM:             31.4 GB
Swap:            0.0 GB

[Graphics]
Vendor:          NVIDIA Corporation
OpenGL Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2
OpenGL Version:  4.6.0 NVIDIA 470.86
OpenGL Core:     4.6.0 NVIDIA 470.86
OpenGL ES:       OpenGL ES 3.2 NVIDIA 470.86
Vulkan:          Supported
```


### Media (optional)

_No response_

### Checklist:

- [X] I'm not asking for support with a game or the wine runner.
- [X] I have followed the above mentioned guides and have all the graphics and wine dependencies installed.
- [X] I have checked for existing issues that describe my problem prior to opening this one.
- [X] I understand that improperly formatted bug reports may be closed without explanation.


Discussion:

Resolving patch:
diff --git a/lutris/gui/application.py b/lutris/gui/application.py
--- a/lutris/gui/application.py
+++ b/lutris/gui/application.py
@@ -514,8 +514,7 @@ def on_game_install(self, game):
         if installers:
             self.show_installer_window(installers)
         else:
-            logger.debug("Should generate automagical installer here but....")
-            logger.debug("Wait? how did you get here?")
+            ErrorDialog(_("There is no installer available for %s.") % game.name, parent=self.window)
         return True
 
     def get_running_game_ids(self):


Test patch: