Repository: nvaccess/nvda

Issue:
Winamp support: NVDA doesn't detect the status of shuffle and repeat modes
<!--
Please thoroughly read NVDA's wiki article on how to fill in this template, including how to provide the required files.
Issues may be closed if the required information is not present.
https://github.com/nvaccess/nvda/wiki/Github-issue-template-explanation-and-examples
-->

### Steps to reproduce:
1. Start winamp
2. Press r or s toggle shuffle or repeat
3. NVDA will say "off" every time you toggle those modes
### Actual behavior:
NVDA will say "off" every time you toggle those modes
##
### Expected behavior:
NVDA needs to state if setting is on or off.
### System configuration
#### NVDA installed/portable/running from source:
Installed
#### NVDA version:
2019.3.1
#### Windows version:
Windows10 latest

#### Name and version of other software in use when reproducing the issue:
Winamp 5.666 Build 3516
#### Other information about your system:

### Other questions
#### Does the issue still occur after restarting your computer?
Yes
#### Have you tried any other versions of NVDA? If so, please report their behaviors.
No
#### If addons are disabled, is your problem still occuring?
Yes
#### Did you try to run the COM registry fixing tool in NVDA menu / tools?
No


Discussion:
Hi, caused by calling ANSI version of GetWindow function – needed to use W (Unicode version). PR on its way – thanks for catching this.

 

From: burakyuksek <notifications@github.com> 
Sent: Monday, April 6, 2020 5:28 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] Winamp support: NVDA doesn't detect the status of shuffle and repeat modes (#10945)

 


Steps to reproduce:


1.	Start winamp
2.	Press r or s toggle shuffle or repeat
3.	NVDA will say "off" every time you toggle those modes


Actual behavior:


NVDA will say "off" every time you toggle those modes


Expected behavior:


NVDA needs to state if setting is on or off.


System configuration


NVDA installed/portable/running from source:


Installed


NVDA version:


2019.3.1


Windows version:


Windows10 latest


Name and version of other software in use when reproducing the issue:


Winamp 5.666 Build 3516


Other information about your system:


Other questions


Does the issue still occur after restarting your computer?


Yes


Have you tried any other versions of NVDA? If so, please report their behaviors.


No


If addons are disabled, is your problem still occuring?


Yes


Did you try to run the COM registry fixing tool in NVDA menu / tools?


No

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <https://github.com/nvaccess/nvda/issues/10945> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEBM5SQYETPVVEWP4UTRLHDDNANCNFSM4MCHM7QQ> .



Resolving patch:
diff --git a/source/appModules/winamp.py b/source/appModules/winamp.py
--- a/source/appModules/winamp.py
+++ b/source/appModules/winamp.py
@@ -1,8 +1,7 @@
-#appModules/winamp.py
-#A part of NonVisual Desktop Access (NVDA)
-#Copyright (C) 2006-2012 NVDA Contributors
-#This file is covered by the GNU General Public License.
-#See the file COPYING for more details.
+# A part of NonVisual Desktop Access (NVDA)
+# Copyright (C) 2006-2020 NV Access Limited
+# This file is covered by the GNU General Public License.
+# See the file COPYING for more details.
 
 from ctypes import *
 from ctypes.wintypes import *
@@ -57,7 +56,7 @@ class AppModule(appModuleHandler.AppModule):
 
 	def event_NVDAObject_init(self,obj):
 		global hwndWinamp
-		hwndWinamp=windll.user32.FindWindowA("Winamp v1.x",None)
+		hwndWinamp = winUser.FindWindow("Winamp v1.x", None)
 
 	def chooseNVDAObjectOverlayClasses(self, obj, clsList):
 		windowClass = obj.windowClassName


Test patch: