Repository: great-expectations/great_expectations

Issue:
Use cleaner solution for non-truncating division in python 2
Prefer `from __future__ import division` to `1.*x/y`


Discussion:
Done inline during improve_partitions push.

Resolving patch:
diff --git a/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_eth_address.py b/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_eth_address.py
--- a/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_eth_address.py
+++ b/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_eth_address.py
@@ -1,138 +1,138 @@
-from multiprocessing.sharedctypes import Value
-from typing import Optional
-
-from cryptoaddress import EthereumAddress
-
-from great_expectations.core.expectation_configuration import ExpectationConfiguration
-from great_expectations.execution_engine import PandasExecutionEngine
-from great_expectations.expectations.expectation import ColumnMapExpectation
-from great_expectations.expectations.metrics import (
-    ColumnMapMetricProvider,
-    column_condition_partial,
-)
-
-
-# This method compares a string to the valid ETH address.
-def is_valid_eth_address(address: str) -> bool:
-    try:
-        EthereumAddress(address)
-        return True
-    except ValueError:
-        return False
-
-
-# This class defines a Metric to support your Expectation.
-# For most ColumnMapExpectations, the main business logic for calculation will live in this class.
-class ColumnValuesToBeValidEthAddress(ColumnMapMetricProvider):
-
-    # This is the id string that will be used to reference your metric.
-    condition_metric_name = "column_values.valid_eth_address"
-
-    # This method implements the core logic for the PandasExecutionEngine
-    @column_condition_partial(engine=PandasExecutionEngine)
-    def _pandas(cls, column, **kwargs):
-        return column.apply(lambda x: is_valid_eth_address(x))
-
-    # This method defines the business logic for evaluating your metric when using a SqlAlchemyExecutionEngine
-    # @column_condition_partial(engine=SqlAlchemyExecutionEngine)
-    # def _sqlalchemy(cls, column, _dialect, **kwargs):
-    #     raise NotImplementedError
-
-    # This method defines the business logic for evaluating your metric when using a SparkDFExecutionEngine
-    # @column_condition_partial(engine=SparkDFExecutionEngine)
-    # def _spark(cls, column, **kwargs):
-    #     raise NotImplementedError
-
-
-# This class defines the Expectation itself
-class ExpectColumnValuesToBeValidEthAddress(ColumnMapExpectation):
-    """This Expectation validates data as conforming to the valid ETH address."""
-
-    # These examples will be shown in the public gallery.
-    # They will also be executed as unit tests for your Expectation.
-    examples = [
-        {
-            "data": {
-                "well_formed_eth_address": [
-                    "b794f5ea0ba39494ce839613fffba74279579268",
-                    "0xb794f5ea0ba39494ce839613fffba74279579268",
-                    "0x73bceb1cd57c711feac4224d062b0f6ff338501e",
-                    "0x9bf4001d307dfd62b26a2f1307ee0c0307632d59",
-                ],
-                "malformed_eth_address": [
-                    "",
-                    "b794",
-                    "b794f5ea0ba39494ce839613fffba74279579260",
-                    "This is not a valid ETH address.",
-                ],
-            },
-            "tests": [
-                {
-                    "title": "basic_positive_test",
-                    "exact_match_out": False,
-                    "include_in_gallery": True,
-                    "in": {"column": "well_formed_eth_address"},
-                    "out": {"success": True},
-                },
-                {
-                    "title": "basic_negative_test",
-                    "exact_match_out": False,
-                    "include_in_gallery": True,
-                    "in": {"column": "malformed_eth_address"},
-                    "out": {"success": False},
-                },
-            ],
-        }
-    ]
-
-    # This is the id string of the Metric used by this Expectation.
-    # For most Expectations, it will be the same as the `condition_metric_name` defined in your Metric class above.
-    map_metric = "column_values.valid_eth_address"
-
-    # This is a list of parameter names that can affect whether the Expectation evaluates to True or False
-    success_keys = ("mostly",)
-
-    # This dictionary contains default values for any parameters that should have default values
-    default_kwarg_values = {}
-
-    def validate_configuration(
-        self, configuration: Optional[ExpectationConfiguration]
-    ) -> None:
-        """
-        Validates that a configuration has been set, and sets a configuration if it has yet to be set. Ensures that
-        necessary configuration arguments have been provided for the validation of the expectation.
-        Args:
-            configuration (OPTIONAL[ExpectationConfiguration]): \
-                An optional Expectation Configuration entry that will be used to configure the expectation
-        Returns:
-            None. Raises InvalidExpectationConfigurationError if the config is not validated successfully
-        """
-
-        super().validate_configuration(configuration)
-        if configuration is None:
-            configuration = self.configuration
-
-        # # Check other things in configuration.kwargs and raise Exceptions if needed
-        # try:
-        #     assert (
-        #         ...
-        #     ), "message"
-        #     assert (
-        #         ...
-        #     ), "message"
-        # except AssertionError as e:
-        #     raise InvalidExpectationConfigurationError(str(e))
-
-    # This object contains metadata for display in the public Gallery
-    library_metadata = {
-        "maturity": "experimental",
-        "tags": ["experimental", "hackathon", "typed-entities"],
-        "contributors": [
-            "@voidforall",
-        ],
-        "requirements": ["cryptoaddress"],
-    }
-
-
-if __name__ == "__main__":
-    ExpectColumnValuesToBeValidEthAddress().print_diagnostic_checklist()
+from multiprocessing.sharedctypes import Value
+from typing import Optional
+
+from cryptoaddress import EthereumAddress
+
+from great_expectations.core.expectation_configuration import ExpectationConfiguration
+from great_expectations.execution_engine import PandasExecutionEngine
+from great_expectations.expectations.expectation import ColumnMapExpectation
+from great_expectations.expectations.metrics import (
+    ColumnMapMetricProvider,
+    column_condition_partial,
+)
+
+
+# This method compares a string to the valid ETH address.
+def is_valid_eth_address(address: str) -> bool:
+    try:
+        EthereumAddress(address)
+        return True
+    except ValueError:
+        return False
+
+
+# This class defines a Metric to support your Expectation.
+# For most ColumnMapExpectations, the main business logic for calculation will live in this class.
+class ColumnValuesToBeValidEthAddress(ColumnMapMetricProvider):
+
+    # This is the id string that will be used to reference your metric.
+    condition_metric_name = "column_values.valid_eth_address"
+
+    # This method implements the core logic for the PandasExecutionEngine
+    @column_condition_partial(engine=PandasExecutionEngine)
+    def _pandas(cls, column, **kwargs):
+        return column.apply(lambda x: is_valid_eth_address(x))
+
+    # This method defines the business logic for evaluating your metric when using a SqlAlchemyExecutionEngine
+    # @column_condition_partial(engine=SqlAlchemyExecutionEngine)
+    # def _sqlalchemy(cls, column, _dialect, **kwargs):
+    #     raise NotImplementedError
+
+    # This method defines the business logic for evaluating your metric when using a SparkDFExecutionEngine
+    # @column_condition_partial(engine=SparkDFExecutionEngine)
+    # def _spark(cls, column, **kwargs):
+    #     raise NotImplementedError
+
+
+# This class defines the Expectation itself
+class ExpectColumnValuesToBeValidEthAddress(ColumnMapExpectation):
+    """This Expectation validates data as conforming to the valid ETH address."""
+
+    # These examples will be shown in the public gallery.
+    # They will also be executed as unit tests for your Expectation.
+    examples = [
+        {
+            "data": {
+                "well_formed_eth_address": [
+                    "b794f5ea0ba39494ce839613fffba74279579268",
+                    "0xb794f5ea0ba39494ce839613fffba74279579268",
+                    "0x73bceb1cd57c711feac4224d062b0f6ff338501e",
+                    "0x9bf4001d307dfd62b26a2f1307ee0c0307632d59",
+                ],
+                "malformed_eth_address": [
+                    "",
+                    "b794",
+                    "b794f5ea0ba39494ce839613fffba74279579260",
+                    "This is not a valid ETH address.",
+                ],
+            },
+            "tests": [
+                {
+                    "title": "basic_positive_test",
+                    "exact_match_out": False,
+                    "include_in_gallery": True,
+                    "in": {"column": "well_formed_eth_address"},
+                    "out": {"success": True},
+                },
+                {
+                    "title": "basic_negative_test",
+                    "exact_match_out": False,
+                    "include_in_gallery": True,
+                    "in": {"column": "malformed_eth_address"},
+                    "out": {"success": False},
+                },
+            ],
+        }
+    ]
+
+    # This is the id string of the Metric used by this Expectation.
+    # For most Expectations, it will be the same as the `condition_metric_name` defined in your Metric class above.
+    map_metric = "column_values.valid_eth_address"
+
+    # This is a list of parameter names that can affect whether the Expectation evaluates to True or False
+    success_keys = ("mostly",)
+
+    # This dictionary contains default values for any parameters that should have default values
+    default_kwarg_values = {}
+
+    def validate_configuration(
+        self, configuration: Optional[ExpectationConfiguration]
+    ) -> None:
+        """
+        Validates that a configuration has been set, and sets a configuration if it has yet to be set. Ensures that
+        necessary configuration arguments have been provided for the validation of the expectation.
+        Args:
+            configuration (OPTIONAL[ExpectationConfiguration]): \
+                An optional Expectation Configuration entry that will be used to configure the expectation
+        Returns:
+            None. Raises InvalidExpectationConfigurationError if the config is not validated successfully
+        """
+
+        super().validate_configuration(configuration)
+        if configuration is None:
+            configuration = self.configuration
+
+        # # Check other things in configuration.kwargs and raise Exceptions if needed
+        # try:
+        #     assert (
+        #         ...
+        #     ), "message"
+        #     assert (
+        #         ...
+        #     ), "message"
+        # except AssertionError as e:
+        #     raise InvalidExpectationConfigurationError(str(e))
+
+    # This object contains metadata for display in the public Gallery
+    library_metadata = {
+        "maturity": "experimental",
+        "tags": ["experimental", "hackathon", "typed-entities"],
+        "contributors": [
+            "@voidforall",
+        ],
+        "requirements": ["cryptoaddress"],
+    }
+
+
+if __name__ == "__main__":
+    ExpectColumnValuesToBeValidEthAddress().print_diagnostic_checklist()
diff --git a/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_ethereum_address.py b/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_ethereum_address.py
new file mode 100644
--- /dev/null
+++ b/contrib/experimental/great_expectations_experimental/expectations/expect_column_values_to_be_valid_ethereum_address.py
@@ -0,0 +1,154 @@
+"""
+This is a template for creating custom ColumnMapExpectations.
+For detailed instructions on how to use it, please see:
+    https://docs.greatexpectations.io/docs/guides/expectations/creating_custom_expectations/how_to_create_custom_column_map_expectations
+"""
+import json
+from typing import Optional
+
+import coinaddrvalidator
+
+from great_expectations.core.expectation_configuration import ExpectationConfiguration
+from great_expectations.exceptions import InvalidExpectationConfigurationError
+from great_expectations.execution_engine import PandasExecutionEngine
+from great_expectations.expectations.expectation import ColumnMapExpectation
+from great_expectations.expectations.metrics import (
+    ColumnMapMetricProvider,
+    column_condition_partial,
+)
+
+
+def is_valid_eth_address(addr: str) -> bool:
+    try:
+        res = coinaddrvalidator.validate("eth", addr).valid
+        return res
+    except Exception as e:
+        return False
+
+
+# This class defines a Metric to support your Expectation.
+# For most ColumnMapExpectations, the main business logic for calculation will live in this class.
+class ColumnValuesToBeValidEthAddress(ColumnMapMetricProvider):
+
+    # This is the id string that will be used to reference your metric.
+    condition_metric_name = "column_values.valid_eth_address"
+
+    # This method implements the core logic for the PandasExecutionEngine
+    @column_condition_partial(engine=PandasExecutionEngine)
+    def _pandas(cls, column, **kwargs):
+        return column.apply(lambda x: is_valid_eth_address(x))
+
+    # This method defines the business logic for evaluating your metric when using a SqlAlchemyExecutionEngine
+    # @column_condition_partial(engine=SqlAlchemyExecutionEngine)
+    # def _sqlalchemy(cls, column, _dialect, **kwargs):
+    #     raise NotImplementedError
+
+    # This method defines the business logic for evaluating your metric when using a SparkDFExecutionEngine
+    # @column_condition_partial(engine=SparkDFExecutionEngine)
+    # def _spark(cls, column, **kwargs):
+    #     raise NotImplementedError
+
+
+# This class defines the Expectation itself
+class ExpectColumnValuesToBeValidEthereumAddress(ColumnMapExpectation):
+    """Expect column values to be valid Ethereum address"""
+
+    # These examples will be shown in the public gallery.
+    # They will also be executed as unit tests for your Expectation.
+    examples = [
+        {
+            "data": {
+                "all_valid": [
+                    "0xcb8bbfa45541a95c1de883eb3606708cae9fd45c",
+                    "0x24affae9c683b7615d4130300288e348e4b5d091",
+                    "0xfbddadd80fe7bda00b901fbaf73803f2238ae655",
+                    "0x9d96b0561be0440ebe93e79fe06a23bbe8270f90",
+                ],
+                "some_other": [
+                    "0xcb8bbfa45541a95c1de883eb3606708cae9fd45c",
+                    "0x24affae9c683b7615d4130300288e348e4b5d091",
+                    "0xfbddadd80fe7bda00b901fbaf73803f2238ae655",
+                    "0x9d96b0561be0440ebe93e79fe06a23bbe8270f9x",
+                ],
+            },
+            "tests": [
+                {
+                    "title": "basic_positive_test",
+                    "exact_match_out": False,
+                    "include_in_gallery": True,
+                    "in": {"column": "all_valid"},
+                    "out": {
+                        "success": True,
+                    },
+                },
+                {
+                    "title": "basic_negative_test",
+                    "exact_match_out": False,
+                    "include_in_gallery": True,
+                    "in": {"column": "some_other", "mostly": 1},
+                    "out": {
+                        "success": False,
+                    },
+                },
+            ],
+        }
+    ]
+
+    # This is the id string of the Metric used by this Expectation.
+    # For most Expectations, it will be the same as the `condition_metric_name` defined in your Metric class above.
+    map_metric = "column_values.valid_eth_address"
+
+    # This is a list of parameter names that can affect whether the Expectation evaluates to True or False
+    success_keys = ("mostly",)
+
+    # This dictionary contains default values for any parameters that should have default values
+    default_kwarg_values = {}
+
+    def validate_configuration(
+        self, configuration: Optional[ExpectationConfiguration]
+    ) -> None:
+        """
+        Validates that a configuration has been set, and sets a configuration if it has yet to be set. Ensures that
+        necessary configuration arguments have been provided for the validation of the expectation.
+
+        Args:
+            configuration (OPTIONAL[ExpectationConfiguration]): \
+                An optional Expectation Configuration entry that will be used to configure the expectation
+        Returns:
+            None. Raises InvalidExpectationConfigurationError if the config is not validated successfully
+        """
+
+        super().validate_configuration(configuration)
+        if configuration is None:
+            configuration = self.configuration
+
+        # # Check other things in configuration.kwargs and raise Exceptions if needed
+        # try:
+        #     assert (
+        #         ...
+        #     ), "message"
+        #     assert (
+        #         ...
+        #     ), "message"
+        # except AssertionError as e:
+        #     raise InvalidExpectationConfigurationError(str(e))
+
+        return True
+
+    # This object contains metadata for display in the public Gallery
+    library_metadata = {
+        "maturity": "experimental",
+        "tags": [
+            "hackathon-22",
+            "experimental",
+            "typed-entities",
+        ],  # Tags for this Expectation in the Gallery
+        "contributors": [  # Github handles for all contributors to this Expectation.
+            "@szecsip",  # Don't forget to add your github handle here!
+        ],
+        "requirements": ["coinaddrvalidator"],
+    }
+
+
+if __name__ == "__main__":
+    ExpectColumnValuesToBeValidEthereumAddress().print_diagnostic_checklist()


Test patch: