Repository: spack/spack

Issue:
py-h5py needs package py-pkgconfig
My build of `py-h5py` fails with this error message:

```
Executing cythonize()
Traceback (most recent call last):
  File "setup.py", line 149, in <module>
    cmdclass = CMDCLASS,
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/command/install.py", line 563, in run
    self.run_command('build')
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/command/build.py", line 127, in run
    self.run_command(cmd_name)
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/xfs1/eschnetter/spacktest/spack/opt/spack/linux-Ubuntu14-x86_64/gcc-6.1.0-spacktest/python-2.7.12-b5sf3vacbqfghadqm6uj2tti2oemd3xy/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/tmp/eschnetter/spack-stage/spack-stage-fBrRmJ/h5py-2.6.0/setup_build.py", line 188, in run
    self.extensions = cythonize(self._make_extensions(config),
  File "/tmp/eschnetter/spack-stage/spack-stage-fBrRmJ/h5py-2.6.0/setup_build.py", line 73, in _make_extensions
    import pkgconfig
ImportError: No module named pkgconfig
```

I believe this means that the package depends on the Python package `py-pkgconfig` https://pypi.python.org/pypi/pkgconfig which does not yet exist in Spack.



Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/py-h5py/package.py b/var/spack/repos/builtin/packages/py-h5py/package.py
--- a/var/spack/repos/builtin/packages/py-h5py/package.py
+++ b/var/spack/repos/builtin/packages/py-h5py/package.py
@@ -40,7 +40,7 @@ class PyH5py(PythonPackage):
 
     # Build dependencies
     depends_on('py-cython@0.19:', type='build')
-    depends_on('pkg-config', type='build')
+    depends_on('py-pkgconfig', type='build')
     depends_on('py-setuptools', type='build')
     depends_on('hdf5@1.8.4:')
     depends_on('hdf5+mpi', when='+mpi')
diff --git a/var/spack/repos/builtin/packages/py-pkgconfig/package.py b/var/spack/repos/builtin/packages/py-pkgconfig/package.py
new file mode 100644
--- /dev/null
+++ b/var/spack/repos/builtin/packages/py-pkgconfig/package.py
@@ -0,0 +1,42 @@
+##############################################################################
+# Copyright (c) 2013-2016, Lawrence Livermore National Security, LLC.
+# Produced at the Lawrence Livermore National Laboratory.
+#
+# This file is part of Spack.
+# Created by Todd Gamblin, tgamblin@llnl.gov, All rights reserved.
+# LLNL-CODE-647188
+#
+# For details, see https://github.com/llnl/spack
+# Please also see the LICENSE file for our notice and the LGPL.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License (as
+# published by the Free Software Foundation) version 2.1, February 1999.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the IMPLIED WARRANTY OF
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the terms and
+# conditions of the GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+##############################################################################
+from spack import *
+
+
+class PyPkgconfig(PythonPackage):
+    """Interface Python with pkg-config."""
+
+    homepage = "http://github.com/matze/pkgconfig"
+    url      = "https://pypi.io/packages/source/p/pkgconfig/pkgconfig-1.2.2.tar.gz"
+
+    version('1.2.2', '81a8f6ef3371831d081e03db39e09683')
+
+    depends_on('python@2.6:')
+    depends_on('py-setuptools', type='build')
+
+    depends_on('pkg-config', type=('build', 'run'))
+
+    # TODO: Add a 'test' deptype
+    # depends_on('py-nose@1.0:', type='test')


Test patch: