Repository: zulip/zulip

Issue:
Rename "All messages" to "Combined feed"
<!-- Issue description -->

We should rename "All messages" to "Combined feed", and update documentation accordingly.

This issue is just for changing user-facing strings. Backend changes can happen once we are confident that the new name has been finalized.

<!-- Link to a message in the chat.zulip.org discussion. Message links will still work even if the topic is renamed or resolved. Link back to this issue from the chat.zulip.org thread. -->

[CZO thread](https://chat.zulip.org/#narrow/stream/101-design/topic/All.20messages.20view.20label.20and.20icon/near/1668230)



Discussion:
Hello @zulip/server-message-view, @zulip/server-user-docs members, this issue was labeled with the "area: message view", "area: documentation (user)" labels, so you may want to check it out!

<!-- areaLabelAddition -->

Please assign this issue to me @alya 
@alya Can I get assigned to this issue? I've previously worked on renaming `display-settings` to preferences in pr [26110](https://github.com/zulip/zulip/pull/26110).
@nimishmedatwal Sure, thanks!
@zulipbot claim
@darksapien23151 This issue cannot be claimed, as someone else is already working on it. Please see our [contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html#your-first-codebase-contribution) for advice on finding an issue to work on. Thanks!

@nimishmedatwal You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@zulipbot claim

@ayush4345 This issue cannot be claimed, as someone else is already working on it. Please see our [contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html#your-first-codebase-contribution) for advice on finding an issue to work on. Thanks!

@zulipbot claim
@ayush4345 This issue cannot be claimed, as someone else is already working on it. Please see our [contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html#your-first-codebase-contribution) for advice on finding an issue to work on. Thanks!

@zulipbot claim
@bisoladebiyi This issue cannot be claimed, as someone else is already working on it. Please see our [contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html#your-first-codebase-contribution) for advice on finding an issue to work on. Thanks!

@zulipbot claim

Welcome to Zulip, @harshsbhat! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

- Join me on the [Zulip developers' server](https://chat.zulip.org), to get help, chat about this issue, and meet the other developers.
- [Unwatch this repository](https://help.github.com/articles/unwatching-repositories/), so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the [Zulip code contribution guide](https://zulip.readthedocs.io/en/latest/contributing/index.html), as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot claim
@nupurkale78 This issue cannot be claimed, as someone else is already working on it. Please see our [contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html#your-first-codebase-contribution) for advice on finding an issue to work on. Thanks!

@harshsbhat You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!


Resolving patch:
diff --git a/zerver/lib/markdown/help_relative_links.py b/zerver/lib/markdown/help_relative_links.py
--- a/zerver/lib/markdown/help_relative_links.py
+++ b/zerver/lib/markdown/help_relative_links.py
@@ -181,7 +181,7 @@ def group_handle_match(key: str) -> str:
     "drafts": ["Drafts", "/#drafts", draft_instructions],
     "scheduled": ["Scheduled messages", "/#scheduled", scheduled_instructions],
     "recent": ["Recent conversations", "/#recent", recent_instructions],
-    "all": ["Combined feed", "/#all_messages", all_instructions],
+    "all": ["Combined feed", "/#feed", all_instructions],
     "starred": ["Starred messages", "/#narrow/is/starred", starred_instructions],
     "direct": ["Direct message feed", "/#narrow/is/dm", direct_instructions],
     "inbox": ["Inbox", "/#inbox", inbox_instructions],
diff --git a/zerver/lib/url_redirects.py b/zerver/lib/url_redirects.py
--- a/zerver/lib/url_redirects.py
+++ b/zerver/lib/url_redirects.py
@@ -83,6 +83,7 @@ class URLRedirect:
     URLRedirect("/help/view-and-browse-images", "/help/view-images-and-videos"),
     URLRedirect("/help/bots-and-integrations", "/help/bots-overview"),
     URLRedirect("/help/configure-notification-bot", "/help/configure-automated-notices"),
+    URLRedirect("/help/all-messages", "/help/combined-feed"),
 ]
 
 LANDING_PAGE_REDIRECTS = [


Test patch:
diff --git a/web/tests/hashchange.test.js b/web/tests/hashchange.test.js
--- a/web/tests/hashchange.test.js
+++ b/web/tests/hashchange.test.js
@@ -228,7 +228,7 @@ run_test("hash_interactions", ({override, override_rewire}) => {
         [message_viewport, "stop_auto_scrolling"],
     ]);
 
-    window.location.hash = "#all_messages";
+    window.location.hash = "#feed";
     hide_all_called = false;
 
     helper.clear_events();
diff --git a/web/tests/hotkey.test.js b/web/tests/hotkey.test.js
--- a/web/tests/hotkey.test.js
+++ b/web/tests/hotkey.test.js
@@ -21,9 +21,8 @@ const $ = require("./lib/zjquery");
 // it calls any external module other than `ui.foo`, it'll crash.
 // Future work includes making sure it actually does call `ui.foo()`.
 
-// Since all the tests here are based on narrow starting with all_messages.
-// We set our default narrow to the combined feed here.
-window.location.hash = "#all_messages";
+// All tests use the combined feed as the default narrow.
+window.location.hash = "#feed";
 
 set_global("navigator", {
     platform: "",