Repository: googleapis/google-auth-library-python

Issue:
Create system tests for OAuth2 credentials
(This may be punted depending on how difficult it is to obtain test credentials)



Discussion:
Already exists in `oauth2client`, the credentials are just for my user account with email being the only scope.

I can probably obtain a test account.


Resolving patch:
diff --git a/scripts/obtain_user_auth.py b/scripts/obtain_user_auth.py
new file mode 100644
--- /dev/null
+++ b/scripts/obtain_user_auth.py
@@ -0,0 +1,65 @@
+# Copyright 2016 Google Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""This program obtains a set of user credentials.
+
+These credentials are needed to run the system test for OAuth2 credentials.
+It's expected that a developer will run this program manually once to obtain
+a refresh token. It's highly recommended to use a Google account created
+specifically created for testing.
+"""
+
+import json
+import os
+
+from oauth2client import client
+from oauth2client import tools
+
+HERE = os.path.dirname(__file__)
+CLIENT_SECRETS_PATH = os.path.abspath(os.path.join(
+    HERE, '..', 'system_tests', 'data', 'client_secret.json'))
+AUTHORIZED_USER_PATH = os.path.abspath(os.path.join(
+    HERE, '..', 'system_tests', 'data', 'authorized_user.json'))
+SCOPES = ['email', 'profile']
+
+
+class NullStorage(client.Storage):
+    """Null storage implementation to prevent oauth2client from failing
+    on storage.put."""
+    def locked_put(self, credentials):
+        pass
+
+
+def main():
+    flow = client.flow_from_clientsecrets(CLIENT_SECRETS_PATH, SCOPES)
+
+    print('Starting credentials flow...')
+    credentials = tools.run_flow(flow, NullStorage())
+
+    # Save the credentials in the same format as the Cloud SDK's authorized
+    # user file.
+    data = {
+        'type': 'authorized_user',
+        'client_id': flow.client_id,
+        'client_secret': flow.client_secret,
+        'refresh_token': credentials.refresh_token
+    }
+
+    with open(AUTHORIZED_USER_PATH, 'w') as fh:
+        json.dump(data, fh, indent=4)
+
+    print('Created {}.'.format(AUTHORIZED_USER_PATH))
+
+if __name__ == '__main__':
+    main()


Test patch:
diff --git a/system_tests/conftest.py b/system_tests/conftest.py
--- a/system_tests/conftest.py
+++ b/system_tests/conftest.py
@@ -33,6 +33,12 @@ def service_account_file():
     yield os.path.join(DATA_DIR, 'service_account.json')
 
 
+@pytest.fixture
+def authorized_user_file():
+    """The full path to a valid authorized user file."""
+    yield os.path.join(DATA_DIR, 'authorized_user.json')
+
+
 @pytest.fixture
 def request():
     """A transport.request object."""
diff --git a/system_tests/secrets.tar.enc b/system_tests/secrets.tar.enc
Binary files a/system_tests/secrets.tar.enc and b/system_tests/secrets.tar.enc differ
diff --git a/system_tests/test_oauth2_credentials.py b/system_tests/test_oauth2_credentials.py
new file mode 100644
--- /dev/null
+++ b/system_tests/test_oauth2_credentials.py
@@ -0,0 +1,43 @@
+# Copyright 2016 Google Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import json
+
+from google.auth import _helpers
+import google.oauth2.credentials
+
+GOOGLE_OAUTH2_TOKEN_ENDPOINT = 'https://accounts.google.com/o/oauth2/token'
+
+
+def test_refresh(authorized_user_file, request, token_info):
+    with open(authorized_user_file, 'r') as fh:
+        info = json.load(fh)
+
+    credentials = google.oauth2.credentials.Credentials(
+        None,  # No access token, must be refreshed.
+        refresh_token=info['refresh_token'],
+        token_uri=GOOGLE_OAUTH2_TOKEN_ENDPOINT,
+        client_id=info['client_id'],
+        client_secret=info['client_secret'])
+
+    credentials.refresh(request)
+
+    assert credentials.token
+
+    info = token_info(credentials.token)
+
+    info_scopes = _helpers.string_to_scopes(info['scope'])
+    assert set(info_scopes) == set([
+        'https://www.googleapis.com/auth/userinfo.email',
+        'https://www.googleapis.com/auth/userinfo.profile'])