Repository: kubeflow/pipelines

Issue:
Potentially duplicated function list_pipeline_versions()?
Seems like there are two versions of this function within the same module:

https://github.com/kubeflow/pipelines/blob/7875b68654a69ca761cb0ba4a920a30925a0e94b/sdk/python/kfp/_client.py#L661

https://github.com/kubeflow/pipelines/blob/7875b68654a69ca761cb0ba4a920a30925a0e94b/sdk/python/kfp/_client.py#L1324

Should one of these be deprecated/removed/renamed?
Potentially duplicated function list_pipeline_versions()?
Seems like there are two versions of this function within the same module:

https://github.com/kubeflow/pipelines/blob/7875b68654a69ca761cb0ba4a920a30925a0e94b/sdk/python/kfp/_client.py#L661

https://github.com/kubeflow/pipelines/blob/7875b68654a69ca761cb0ba4a920a30925a0e94b/sdk/python/kfp/_client.py#L1324

Should one of these be deprecated/removed/renamed?


Discussion:
Since they have the same name, the last one will be the one that is exposed when using the `Client`. Thus I think it should be fine to remove the one on L661. 
@NikeNano - agreed - not sure on how proceed to a PR for this 🤷🏾‍♂️ 

I'm unable to create a remote branch with the change. I'm following the contribution readme [CONTRIBUTION.md](https://github.com/kubeflow/pipelines/blob/master/CONTRIBUTING.md) but it doesn't say much re: creating upstream branches.

Or am I supposed to fork, fix, and send a patch? 

Or is there a core dev team that's taking care of it? 
Workflow would be along the lines: 
1) Fork the repository: https://github.com/kubeflow/pipelines
2) Create a branch and update the code
3) Make a pull request to https://github.com/kubeflow/pipelines from your forked repo. 

You are more than welcome to make a PR to Kubeflow pipelines :) someone in the core team have to approve the PR, you can see who are part of the core team after you make a PR in the comments from the bot. 
Since they have the same name, the last one will be the one that is exposed when using the `Client`. Thus I think it should be fine to remove the one on L661. 
@NikeNano - agreed - not sure on how proceed to a PR for this 🤷🏾‍♂️ 

I'm unable to create a remote branch with the change. I'm following the contribution readme [CONTRIBUTION.md](https://github.com/kubeflow/pipelines/blob/master/CONTRIBUTING.md) but it doesn't say much re: creating upstream branches.

Or am I supposed to fork, fix, and send a patch? 

Or is there a core dev team that's taking care of it? 
Workflow would be along the lines: 
1) Fork the repository: https://github.com/kubeflow/pipelines
2) Create a branch and update the code
3) Make a pull request to https://github.com/kubeflow/pipelines from your forked repo. 

You are more than welcome to make a PR to Kubeflow pipelines :) someone in the core team have to approve the PR, you can see who are part of the core team after you make a PR in the comments from the bot. 

Resolving patch:
diff --git a/sdk/python/kfp/_client.py b/sdk/python/kfp/_client.py
--- a/sdk/python/kfp/_client.py
+++ b/sdk/python/kfp/_client.py
@@ -658,29 +658,6 @@ def list_pipelines(self, page_token='', page_size=10, sort_by=''):
         return self._pipelines_api.list_pipelines(
             page_token=page_token, page_size=page_size, sort_by=sort_by)
 
-    def list_pipeline_versions(self,
-                               pipeline_id: str,
-                               page_token='',
-                               page_size=10,
-                               sort_by=''):
-        """List all versions of a given pipeline.
-
-        Args:
-          pipeline_id: The id of a pipeline.
-          page_token: Token for starting of the page.
-          page_size: Size of the page.
-            sort_by: one of 'field_name', 'field_name desc'. For example, 'name desc'.
-
-        Returns:
-          A response object including a list of pipeline versions and next page token.
-        """
-        return self._pipelines_api.list_pipeline_versions(
-            resource_key_type="PIPELINE",
-            resource_key_id=pipeline_id,
-            page_token=page_token,
-            page_size=page_size,
-            sort_by=sort_by)
-
     # TODO: provide default namespace, similar to kubectl default namespaces.
     def run_pipeline(
         self,


Test patch: