Repository: sunpy/sunpy

Issue:
The ticks for the HGS overlay on map plots are white and invisible by default
Also the HPC ticks are on all four axes.


Discussion:

Resolving patch:
diff --git a/sunpy/visualization/wcsaxes_compat.py b/sunpy/visualization/wcsaxes_compat.py
--- a/sunpy/visualization/wcsaxes_compat.py
+++ b/sunpy/visualization/wcsaxes_compat.py
@@ -144,6 +144,12 @@ def wcsaxes_heliographic_overlay(axes, grid_spacing: u.deg = 10*u.deg, **kwargs)
     else:
         raise ValueError("grid_spacing must be a Quantity of length one or two.")
 
+    # Set the native coordinates to be bottom and left only so they don't share
+    # axes with the overlay.
+    c1, c2 = axes.coords
+    c1.set_ticks_position('bl')
+    c2.set_ticks_position('bl')
+
     overlay = axes.get_coords_overlay('heliographic_stonyhurst')
 
     lon = overlay[0]
@@ -161,8 +167,10 @@ def wcsaxes_heliographic_overlay(axes, grid_spacing: u.deg = 10*u.deg, **kwargs)
     grid_kw = {'color': 'white', 'zorder': 100, 'alpha': 0.5}
     grid_kw.update(kwargs)
 
-    lon.set_ticks(spacing=lon_space, color=grid_kw['color'])
-    lat.set_ticks(spacing=lat_space, color=grid_kw['color'])
+    # Don't plot white ticks by default (only if explicitly asked)
+    tick_color = grid_kw['color'] if 'color' in kwargs else 'k'
+    lon.set_ticks(spacing=lon_space, color=tick_color)
+    lat.set_ticks(spacing=lat_space, color=tick_color)
 
     overlay.grid(**grid_kw)
 


Test patch:
diff --git a/sunpy/tests/figure_hashes_py36.json b/sunpy/tests/figure_hashes_py36.json
--- a/sunpy/tests/figure_hashes_py36.json
+++ b/sunpy/tests/figure_hashes_py36.json
@@ -1,12 +1,12 @@
 {
     "sunpy.map.tests.test_plotting.test_draw_contours_aia": "576ce31e7cabaf98fa9edc8b802da07c5f0cad24ce6cc0498f4053db267c1d12",
-    "sunpy.map.tests.test_plotting.test_draw_grid_aia171": "eb3f5b9b7317b31e7e77a278d83a4e4717077f2e996b2449909f10cf6d582c4b",
+    "sunpy.map.tests.test_plotting.test_draw_grid_aia171": "3eda0e9222ae0e03e49ee1d2548a744f39873f2513e7c1d9c6c088fcd958304f",
     "sunpy.map.tests.test_plotting.test_heliographic_peek": "f826ff27728903a6e5fb7eafe4754df3ea86cf033ed41756155946a0ef6c247c",
     "sunpy.map.tests.test_plotting.test_heliographic_rectangle": "e366f103b4f96946fb06da1d591b3bdb8ee027eaf387b3ff78b0bb7b5ad69124",
     "sunpy.map.tests.test_plotting.test_peek_aia171": "bfbe20f58929eb19812b9bbb2c21f4d3fbb7e53defcd00e484ef6c1a943d2222",
-    "sunpy.map.tests.test_plotting.test_peek_grid_aia171": "6d06cce44421a95012e62f42dec533379ce407ae7f35856ac335e7846e264d26",
-    "sunpy.map.tests.test_plotting.test_peek_grid_limb_aia171": "bedeef83c9e84c2b1bce8ce579de4d78c9228e540a5e0d4b57a142f6e23438f7",
-    "sunpy.map.tests.test_plotting.test_peek_grid_spacing_aia171": "9d8db2f2da8e8bb2b1f3fd5f321f137f9d11573a420fd3bedde8acbf963fd245",
+    "sunpy.map.tests.test_plotting.test_peek_grid_aia171": "049f5d514ee8f4783f3ca30d82b5a20ef72066a484709da10e2b1b85a0ea7f6c",
+    "sunpy.map.tests.test_plotting.test_peek_grid_limb_aia171": "52e204782368643c2ba36b3c51addcbd31731743d4905763d57cff1b669f1d10",
+    "sunpy.map.tests.test_plotting.test_peek_grid_spacing_aia171": "241d559d0a8661ee9ae035b8d7a50bc4f871fa002fac0543f3047b3ef6bc8078",
     "sunpy.map.tests.test_plotting.test_peek_limb_aia171": "dbee8e3f01517a79b6305e03e52b3b6cdcfb4deb46f6d3d92efdcf6700e73742",
     "sunpy.map.tests.test_plotting.test_plot_aia171": "eb9784d991df9291be773eaafcdb979bccc3d9d628a88c30369c5bc8c922e2bf",
     "sunpy.map.tests.test_plotting.test_plot_aia171_clip": "d16762707b2df85108b43763ad4ee617e4267876e87782cc8b0fa11d45f7ddd0",