Repository: mdn/kuma

Issue:
Remove contributor notification post account creation
Once a user has successfully signed up, we show a banner similar to the one below either just below the page header, or generally at the top of the page.

![Screenshot 2019-10-30 at 16 06 16 16 41 01](https://user-images.githubusercontent.com/10350960/67869535-3ce5a700-fb36-11e9-930b-66b82f6fd141.png)


Because of the changes to account roles, these no longer makes sense and should be removed.


Discussion:
@schalkneethling the first one should still be shown, no?
> @schalkneethling the first one should still be shown, no?

Yes, the first one will remain.
@atopal FYI, we have the following copy in the current welcome email. Should this be cleaned up as well?

```
{# L10n: This is an email. Whitespace matters! #}
{{ _("You've completed the first step of Getting Started on MDN by creating a profile. Now, keep going by picking a task on MDN, and doing it! We have a bunch of intro tasks you can choose based on your interests.") }}

{# Note: If you change this string also change ``WELCOME_EMAIL_STRINGS`` in kuma/users/tasks.py #}
{# L10n: This is an email. Whitespace matters! #}
{{ _('Like words?') }}
{{ add_utm('https://developer.mozilla.org/en-US/docs/MDN/Getting_started#Option_1.3A_I_like_words', 'welcome') }}

{# L10n: This is an email. Whitespace matters! #}
{{ _('Like code?') }}
{{ add_utm('https://developer.mozilla.org/en-US/docs/MDN/Getting_started#Option_2.3A_I_like_code', 'welcome') }}

{# L10n: This is an email. Whitespace matters! #}
{{ _('Like both words and code?') }}
{{ add_utm('https://developer.mozilla.org/en-US/docs/MDN/Getting_started#Option_3.3A_I_like_both_words_and_code', 'welcome') }}

{# L10n: This is an email. Whitespace matters! #}
{{ _('Want to translate MDN to your language?') }}
{{ add_utm('https://developer.mozilla.org/en-US/docs/MDN/Getting_started#Option_4.3A_I_want_MDN_in_my_language', 'welcome') }}
```

Resolving patch:
diff --git a/kuma/users/signal_handlers.py b/kuma/users/signal_handlers.py
--- a/kuma/users/signal_handlers.py
+++ b/kuma/users/signal_handlers.py
@@ -1,14 +1,11 @@
 from allauth.account.signals import email_confirmed, user_signed_up
 from allauth.socialaccount.signals import social_account_removed
-from django.contrib import messages
 from django.core.exceptions import ObjectDoesNotExist
 from django.db import transaction
 from django.db.models.signals import post_delete, post_save, pre_delete
 from django.dispatch import receiver
-from django.utils.translation import ugettext_lazy as _
 from waffle import switch_is_active
 
-from kuma.core.urlresolvers import reverse
 from kuma.payments.utils import cancel_stripe_customer_subscription
 from kuma.wiki.jobs import DocumentContributorsJob
 
@@ -21,10 +18,6 @@ def on_user_signed_up(sender, request, user, **kwargs):
     """
     Signal handler to be called when a given user has signed up.
     """
-    url = reverse('wiki.document', args=['MDN/Getting_started'])
-    msg = _('You have completed the first step of '
-            '<a href="%s">getting started with MDN</a>') % url
-    messages.success(request, msg)
     if switch_is_active('welcome_email'):
         # only send if the user has already verified
         # at least one email address


Test patch:
diff --git a/kuma/users/tests/test_tasks.py b/kuma/users/tests/test_tasks.py
--- a/kuma/users/tests/test_tasks.py
+++ b/kuma/users/tests/test_tasks.py
@@ -3,7 +3,6 @@
 from allauth.account.models import EmailAddress, EmailConfirmationHMAC
 from allauth.account.signals import user_signed_up
 from django.conf import settings
-from django.contrib import messages as django_messages
 from django.core import mail
 from django.test import RequestFactory, TestCase
 from waffle.testutils import override_switch
@@ -90,21 +89,6 @@ def test_welcome_mail_for_verified_email(self):
         self.assertEqual(expected_to, welcome_email.to)
         self.assertTrue('utm_campaign=welcome' in welcome_email.body)
 
-    def test_signup_getting_started_message(self):
-        testuser = user(username='welcome', email='welcome@tester.com',
-                        password='welcome', save=True)
-        request = self.setup_request_for_messages()
-        messages = self.get_messages(request)
-        self.assertEqual(len(messages), 0)
-
-        user_signed_up.send(sender=testuser.__class__, request=request,
-                            user=testuser)
-
-        queued_messages = list(messages)
-        self.assertEqual(len(queued_messages), 1)
-        self.assertEqual(django_messages.SUCCESS, queued_messages[0].level)
-        self.assertTrue('getting started' in queued_messages[0].message)
-
     @override_switch('welcome_email', True)
     @call_on_commit_immediately
     def test_welcome_mail_for_unverified_email(self):