Repository: ansible/ansible

Issue:
win_domain_controller: documentation error in examples '_pass' should be '_password'
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->

##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->

 - Documentation Report

##### COMPONENT NAME
<!--- Name of the module/plugin/task/feature -->
win_domain_controller
##### ANSIBLE VERSION
<!--- Paste verbatim output from “ansible --version” between quotes below -->
```
ansible 2.3.0.0 (detached HEAD e4494f85b6) last updated 2017/03/17 12:34:17 (GMT +100)
  config file = /home/jon/ansible/ansible.cfg
  configured module search path = [u'/home/jon/ansible/library']
  python version = 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2]
```

##### CONFIGURATION
<!---
Mention any settings you have changed/added/removed in ansible.cfg
(or using the ANSIBLE_* environment variables).
-->

##### OS / ENVIRONMENT
<!---
Mention the OS you are running Ansible from, and the OS you are
managing, or say “N/A” for anything that is not platform-specific.
-->
Ansible controller Windows 10 WSL (ubuntu)
targets: Windows Server 2012 R2
##### SUMMARY
<!--- Explain the problem briefly -->

The examples need updating to match the correct parameter names for the _password parameters.
For example in the examples domain_admin_pass, but the module actually expects 'domain_admin_password'.  The same thing is true for 'safe_mode_password' and 'local_admin_password'.

Would create a PR for this but am away from dev machine at the moment.


##### STEPS TO REPRODUCE
<!---
For bugs, show exactly how to reproduce the problem, using a minimal test-case.
For new features, show how the feature would be used.
-->
N/A
<!--- Paste example playbooks or commands between quotes below -->
```yaml

```

<!--- You can also paste gist.github.com links for larger files -->

##### EXPECTED RESULTS
<!--- What did you expect to happen when running the steps above? -->
N/A
##### ACTUAL RESULTS
<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
N/A
<!--- Paste verbatim command output between quotes below -->
```

```



Discussion:
Also spotted a similar issue with 'win_domain'.  The module expects 'forest_root_dns_domain' but docs just say dns_domain_name.  I think in this case the name in the docs is probably the intended one.
\cc @nitzmahone

Resolving patch:
diff --git a/lib/ansible/modules/windows/win_domain_controller.py b/lib/ansible/modules/windows/win_domain_controller.py
--- a/lib/ansible/modules/windows/win_domain_controller.py
+++ b/lib/ansible/modules/windows/win_domain_controller.py
@@ -75,8 +75,8 @@
   - win_domain_controller:
       dns_domain_name: ansible.vagrant
       domain_admin_user: testguy@ansible.vagrant
-      domain_admin_pass: password123!
-      safe_mode_pass: password123!
+      domain_admin_password: password123!
+      safe_mode_password: password123!
       state: domain_controller
       log_path: c:\ansible_win_domain_controller.txt
 
@@ -91,8 +91,8 @@
   tasks:
   - win_domain_controller:
       domain_admin_user: testguy@ansible.vagrant
-      domain_admin_pass: password123!
-      local_admin_pass: password123!
+      domain_admin_password: password123!
+      local_admin_password: password123!
       state: member_server
       log_path: c:\ansible_win_domain_controller.txt
 


Test patch: