Repository: great-expectations/great_expectations

Issue:
Use cleaner solution for non-truncating division in python 2
Prefer `from __future__ import division` to `1.*x/y`
Data docs filter on date is broken
**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Run few expectation suite
2. Generate the data docs
3. On the data docs, check the date of the last run and set this date in the "run time" date picker
4. The error is there : there is no data displayed for this day

It looks like the date picker don't format the date correctly, this is why the data grid component can't filter by date.
See the screeshots for details

![first step](https://user-images.githubusercontent.com/16429809/132181416-25752163-a713-4466-b462-a48f2b31dddf.png)
![second step](https://user-images.githubusercontent.com/16429809/132181442-26030a91-b0ce-4c8f-b24f-d7ab0f29c495.png)




Discussion:
Done inline during improve_partitions push.
Thanks for submitting this issue, @fosk06! We will review internally and respond over the next week or so.
Hi @fosk06! Would you be interested in making a contribution to address this? We would be happy to offer any guidance needed.
i could do it i guess. I'm a JS developer after all. 
Hi @fosk06! I wanted to check in - is this something which you are interested in contributing? Please let us know how we can assist.
Hey @fosk06! Just checking in again, is this something you would be interested in contributing?
Sorry but I don't have time to contribute right now.

Le mer. 8 déc. 2021 à 18:06, Austin Ziech Robinson
***@***.***> a écrit :
>
> Hey @fosk06! Just checking in again, is this something you would be interested in contributing?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
> Triage notifications on the go with GitHub Mobile for iOS or Android.


Resolving patch:
diff --git a/great_expectations/render/renderer/site_index_page_renderer.py b/great_expectations/render/renderer/site_index_page_renderer.py
--- a/great_expectations/render/renderer/site_index_page_renderer.py
+++ b/great_expectations/render/renderer/site_index_page_renderer.py
@@ -97,6 +97,13 @@ def _generate_profiling_results_link_table(cls, index_links_dict):
                 "sortName": "_run_time_sort",
                 "sortable": "true",
                 "filterControl": "datepicker",
+                "filterCustomSearch": "formatRuntimeDateForFilter",
+                "filterDatepickerOptions": {
+                    "clearBtn": "true",
+                    "autoclose": "true",
+                    "format": "yyyy-mm-dd",
+                    "todayHighlight": "true",
+                },
             },
             {
                 "field": "asset_name",
@@ -167,6 +174,7 @@ def _generate_validation_results_link_table(cls, index_links_dict):
             "filterControl": "true",
             "iconSize": "sm",
             "toolbarAlign": "right",
+            "showSearchClearButton": "true",
         }
 
         table_columns = [
@@ -184,6 +192,13 @@ def _generate_validation_results_link_table(cls, index_links_dict):
                 "sortName": "_run_time_sort",
                 "sortable": "true",
                 "filterControl": "datepicker",
+                "filterCustomSearch": "formatRuntimeDateForFilter",
+                "filterDatepickerOptions": {
+                    "clearBtn": "true",
+                    "autoclose": "true",
+                    "format": "yyyy-mm-dd",
+                    "todayHighlight": "true",
+                },
             },
             {
                 "field": "run_name",


Test patch: