internlm/SWE-Fixer-Train-110K huggingface dataset:
Repository: spack/spack

Issue:
Installation issue: chaco on with apple-clang@12:
### Steps to reproduce the issue

```console
$ spack spec -l chaco
Input spec
--------------------------------
chaco

Concretized
--------------------------------
jtdjsxb  chaco@2020-07-16%apple-clang@13.0.0~ipo+shared build_type=RelWithDebInfo arch=darwin-bigsur-skylake
rz3rype      ^cmake@3.22.1%apple-clang@13.0.0~doc+ncurses+ownlibs~qt build_type=Release arch=darwin-bigsur-skylake

```


### Error message

<details><summary>Error message</summary><pre>
>> 80    /var/folders/ck/bwzqcv_s1pz1t9fc86731shh0000gq/T/ptb/spack-stage/spack-s
           tage-chaco-2020-07-16-pq6dhovfy4dswevyeattwcadfrcqltar/spack-src/code/co
           arsen/makecgraph.c:200:2: error: implicit declaration of function 'makec
           coords' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
</pre></details>


### Information on your system

* **Spack:** 0.18.0.dev0 (7367f9e213034ebbf6204c94865aa5edcae784ff)
* **Python:** 3.9.12
* **Platform:** darwin-bigsur-skylake
* **Concretizer:** clingo

### Additional information

_No response_

### General information

- [X] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [X] I have run `spack maintainers <name-of-the-package>` and **@mentioned** any maintainers
- [X] I have uploaded the build log and environment files
- [X] I have searched the issues of this repo and believe this is not a duplicate


Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/chaco/package.py b/var/spack/repos/builtin/packages/chaco/package.py
--- a/var/spack/repos/builtin/packages/chaco/package.py
+++ b/var/spack/repos/builtin/packages/chaco/package.py
@@ -22,6 +22,8 @@ class Chaco(CMakePackage):
     depends_on('cmake@3.16:', type='build')
 
     def cmake_args(self):
-        return [
-            self.define_from_variant('BUILD_SHARED_LIBS', 'shared')
-        ]
+        opts = [self.define_from_variant('BUILD_SHARED_LIBS', 'shared')]
+        if self.spec.satisfies('%apple-clang@12:'):
+            opts.append(self.define("CMAKE_C_FLAGS",
+                                    "-Wno-error=implicit-function-declaration"))
+        return opts


Test patch:
Repository: spack/spack

Issue:
Perl: Fix (again) macOS 11
I think this (#19210 / #18660) needs to be written in a more general way, since one can set only the major version as well.

I saw on an Azure runner with macOS 11:
```
*** Unexpected MACOSX_DEPLOYMENT_TARGET=11
***
*** Please either set it to a valid macOS version number (e.g., 10.15) or to empty.
```
for Perl 5.34.1
```
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/runner/spack-stage/spack-stage-perl-5.34.1-pi4awot23n4knuuugmvfjussoweu3ui4/spack-build-out.txt
```

This problem is also visible in Spack `macos-nightly` tests:
https://github.com/spack/spack/actions/workflows/macos_python.yml?query=workflow%3A%22macOS+builds+nightly%22

cc @zhiyuanzhai @johnwparent]

- [ ] patch untested, because I am a Linux user


Discussion:
Or the problem is that this issue is still not fixed upstream, we now ship already never versions, but limit the patch to:
```
    # Fix 'Unexpected product version' error on macOS 11.0 Big Sur
    # https://github.com/Perl/perl5/pull/17946
    patch('macos-11-version-check.patch', when='@5.24.1:5.32.0 platform=darwin')
```
...?

Seems to appear since 3 days in nightly tests: #29840
I changed this most recently at  #28797: we might need to just bump the version '5.34.0' I put in there? (I wrote the most recent version in the hopes that the next one would fix this bug.)

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/perl/package.py b/var/spack/repos/builtin/packages/perl/package.py
--- a/var/spack/repos/builtin/packages/perl/package.py
+++ b/var/spack/repos/builtin/packages/perl/package.py
@@ -100,10 +100,6 @@ class Perl(Package):  # Perl doesn't use Autotools, it should subclass Package
     # https://bugzilla.redhat.com/show_bug.cgi?id=1536752
     patch('https://src.fedoraproject.org/rpms/perl/raw/004cea3a67df42e92ffdf4e9ac36d47a3c6a05a4/f/perl-5.26.1-guard_old_libcrypt_fix.patch', level=1, sha256='0eac10ed90aeb0459ad8851f88081d439a4e41978e586ec743069e8b059370ac', when='@:5.26.2')
 
-    # Fix 'Unexpected product version' error on macOS 11.0 Big Sur
-    # https://github.com/Perl/perl5/pull/17946
-    patch('macos-11-version-check.patch', when='@5.24.1:5.32.0 platform=darwin')
-
     # Enable builds with the NVIDIA compiler
     # The Configure script assumes some gcc specific behavior, and use
     # the mini Perl environment to bootstrap installation.
@@ -372,8 +368,7 @@ def setup_build_environment(self, env):
 
         spec = self.spec
 
-        if (spec.version <= Version('5.34.0')
-            and spec.platform == 'darwin'
+        if (spec.satisfies('@:5.34 platform=darwin')
             and macos_version() >= Version('10.16')):
             # Older perl versions reject MACOSX_DEPLOYMENT_TARGET=11 or higher
             # as "unexpected"; override the environment variable set by spack's


Test patch:
Repository: spack/spack

Issue:
Want Spack Docker container based on Ubuntu 20.04
I want a Spack Docker container based on Ubuntu 20.04. I refer to the image that is used by Spack to build packages (the "build" stage).

### Rationale

Ubuntu 18.04 provides GCC 7, which is too old. I need at least GCC 8. By using Ubuntu 20.04 as base image, this would be solved.

### Description

It is possible to install GCC 8 with Ubuntu 18.04, and change a few settings to make it the default compiler. However, this would also need to be done in the base image that Spack uses to build, and might be more difficult than switching to Ubuntu 20.04.

Another option would be to build a newer GCC with Spack, and use this later to build other packages. This is also a more complex approach.

### General information

$ spack --version
0.15.3-490-80a382c21

- [x] I have run `spack --version` and reported the version of Spack
- [x] I have searched the issues of this repo and believe this is not a duplicate

docker: adding ubuntu20.04



Discussion:
FWIW, it's trivial to install gcc-9 on ubuntu:16.04 even:

```
FROM ubuntu:16.04

RUN apt-get update -qq && \
  apt-get install -qq software-properties-common apt-transport-https --no-install-recommends && \
  add-apt-repository -y ppa:ubuntu-toolchain-r/test && \
  apt-get -qq install gcc-9 g++-9 gfortran-9 --no-install-recommends && \
  rm -rf /var/lib/apt/lists/*
```
it could be useful because linking against an older libc makes your binaries compatible with newer versions too. At the same time though, spack sees different OS-platforms as incompatible by default, since it's part of the triplet.
GCC-9 produces (in its default setting) code that is not binary compatible with older versions of GCC. The problem is that the STL (e.g. the `string` class) is sensitive to whether `-std=c++17` is used or not, and this option is the default on newer versions of GCC, but not on older ones. Hence packages written in C++ (Boost etc.) are not binary compatible: I cannot use GCC-9 to compiler code that wants to link to a system Boost, since the system Boost was built without this option and is hence not ABI compatible.
Any updates here? I'd like this added.
@RikkiButler20 Please resolve conflicts.  There are also some questions here.

Resolving patch:
diff --git a/lib/spack/spack/container/images.py b/lib/spack/spack/container/images.py
--- a/lib/spack/spack/container/images.py
+++ b/lib/spack/spack/container/images.py
@@ -129,5 +129,6 @@ def checkout_command(url, ref, enforce_sha, verify):
     if enforce_sha or verify:
         ref = _verify_ref(url, ref, enforce_sha)
 
-    command = 'git clone {0} . && git checkout {1} '.format(url, ref)
+    command = ('git clone {0} . && git fetch origin {1}:container_branch &&'
+               ' git checkout container_branch ').format(url, ref)
     return command


Test patch:
Repository: spack/spack

Issue:
Installation issue: esmf does not set ESMF_COMM when using hpcx-mpi
### Steps to reproduce the issue

Use hpcx-mpi as mpi provider
```console
$ spack add esmf
$ spack install
```
Can be fixed by add hpcx-mpi to https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/esmf/package.py#L193
@climbfuji 

### Error message

Will get a bunch of errors indicate MPI not found
<details><summary>Error message</summary><pre>
>> 2143    /mnt/nfs4/node2/home/jiych/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-11.3.0/parallel-netcdf-1.12.2-j3rv6kyr4efjbfijwfqwmjb6jiugc3vh/include/pnetcdf.h:676:58: error: 'MPI_Info' has not been declared
</pre></details>


### Information on your system

* **Spack:** 0.18.0.dev0 (3f57c7c67ac29a4dbbc7caeb8b9c808b86d1e5fe)
* **Python:** 3.8.10
* **Platform:** linux-ubuntu20.04-zen2
* **Concretizer:** clingo

### Additional information

[spack-build-out.txt](https://github.com/spack/spack/files/8550961/spack-build-out.txt)


### General information

- [X] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [X] I have run `spack maintainers <name-of-the-package>` and **@mentioned** any maintainers
- [X] I have uploaded the build log and environment files
- [X] I have searched the issues of this repo and believe this is not a duplicate


Discussion:
Thanks for reporting. Please create a PR for this.

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/esmf/package.py b/var/spack/repos/builtin/packages/esmf/package.py
--- a/var/spack/repos/builtin/packages/esmf/package.py
+++ b/var/spack/repos/builtin/packages/esmf/package.py
@@ -190,7 +190,8 @@ def edit(self, spec, prefix):
                 # The mpich 3 series split apart the Fortran and C bindings,
                 # so we link the Fortran libraries when building C programs:
                 os.environ['ESMF_CXXLINKLIBS'] = '-lmpifort'
-            elif '^openmpi' in spec:
+            elif '^openmpi' in spec or \
+                 '^hpcx-mpi' in spec:
                 os.environ['ESMF_COMM'] = 'openmpi'
             elif '^intel-parallel-studio+mpi' in spec or \
                  '^intel-mpi' in spec or \


Test patch:
Repository: spack/spack

Issue:
`spack build-env` does not support `--reuse`
### Summary

Currently on develop `spack install` and `spack spec` support the `--reuse` flag. `spack build-env` does not support this flag making it slightly awkward to use `spack install --reuse --only dependencies <spec>` and then `spack build-env` to get the same environment since one has to use the hash of the concretized spec instead of just using `spack build-env --reuse <spec>`.

I've seen the note in the documentation about `--reuse` becoming the default in a future version, so I'm unsure if this is an intentional or unintentional omission. If you're planning on making `--reuse` the default soon I think this is a non-issue, but wanted to report in case the omission is unintentional.

### Rationale

Convenience in using `spack install --only dependencies --reuse <spec>` together with `spack build-env <spec>`.

### Description

`spack build-env` should accept a `--reuse` flag.

### Additional information

```
> spack --version
0.17.1-1545-474493713b
```

### General information

- [X] I have run `spack --version` and reported the version of Spack
- [X] I have searched the issues of this repo and believe this is not a duplicate


Discussion:

Resolving patch:
diff --git a/lib/spack/spack/cmd/common/env_utility.py b/lib/spack/spack/cmd/common/env_utility.py
--- a/lib/spack/spack/cmd/common/env_utility.py
+++ b/lib/spack/spack/cmd/common/env_utility.py
@@ -18,6 +18,8 @@
 
 def setup_parser(subparser):
     arguments.add_common_arguments(subparser, ['clean', 'dirty'])
+    arguments.add_concretizer_args(subparser)
+
     subparser.add_argument(
         '--dump', metavar="FILE",
         help="dump a source-able environment to FILE"


Test patch:
Repository: spack/spack

Issue:
Installation issue: Praview needs Verdict
### Steps to reproduce the issue

```console
$ spack install paraview@master+qt+python3
```


Installing paraview crash during CMake because it does not find the Verdict lib.
Am I the only one to have this ?
To fix this, we could add ```'-DVTK_MODULE_USE_EXTERNAL_verdict=OFF'``` in the CMake args

@chuckatkins @danlipsa  @vicentebolea, do you agree ?



### Error message

```
1 error found in build log:
     225    Call Stack (most recent call first):
     226      VTK/CMake/vtkModule.cmake:5065 (vtk_module_find_package)
     227      VTK/CMake/vtkModule.cmake:4936 (vtk_module_third_party_external)
     228      VTK/ThirdParty/verdict/CMakeLists.txt:1 (vtk_module_third_party)
     229    
     230    
  >> 231    CMake Error at VTK/CMake/vtkModule.cmake:4471 (message):
     232      Could not find the Verdict external dependency.
     233    Call Stack (most recent call first):
     234      VTK/CMake/vtkModule.cmake:5065 (vtk_module_find_package)
     235      VTK/CMake/vtkModule.cmake:4936 (vtk_module_third_party_external)
     236      VTK/ThirdParty/verdict/CMakeLists.txt:1 (vtk_module_third_party)
     237    

See build log for details:
  /tmp/billae/spack-stage/spack-stage-paraview-master-ob4aut4wpm5cue2sl6ecxc5ubtphxztd/spack-build-out.txt
```


### Information on your system

* **Spack:** 0.18.0.dev0 (ac9bd3d72d7a4ed49e5bbdd3f07a4fdf91f8d0ce)
* **Python:** 3.6.9
* **Platform:** linux-ubuntu18.04-skylake
* **Concretizer:** clingo


### Additional information

_No response_

### General information

- [X] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [X] I have run `spack maintainers <name-of-the-package>` and **@mentioned** any maintainers
- [X] I have uploaded the build log and environment files
- [X] I have searched the issues of this repo and believe this is not a duplicate


Discussion:
@Billae `verdict` lib is shipped with the VTK source code, this is odd.
cc @kwryankrattiger 

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/paraview/package.py b/var/spack/repos/builtin/packages/paraview/package.py
--- a/var/spack/repos/builtin/packages/paraview/package.py
+++ b/var/spack/repos/builtin/packages/paraview/package.py
@@ -345,6 +345,9 @@ def nvariant_bool(feature):
             '-DBUILD_TESTING:BOOL=OFF',
             '-DOpenGL_GL_PREFERENCE:STRING=LEGACY']
 
+        if spec.satisfies('@5.11:'):
+            cmake_args.append('-DVTK_MODULE_USE_EXTERNAL_VTK_verdict:BOOL=OFF')
+
         if spec.satisfies('@5.10:'):
             cmake_args.extend([
                 '-DVTK_MODULE_USE_EXTERNAL_ParaView_vtkcatalyst:BOOL=OFF',


Test patch:
Repository: spack/spack

Issue:
UnboundLocalError: local variable 'acc_flags_var' referenced before assignment
**Build Command tried**

`spack -d install -v -j 16 cp2k@7.1+elpa %aocc@3.2.0 target=zen3 ^amdfftw@3.1 ^amdscalapack@3.1 ^amdblis@3.1 ^amdlibflame@3.1 ^libint@2.6.0 ^libxsmm@1.15 ^libxc@4.2.3 ^elpa@2019.11.001+openmp ^openmpi@4.1.1+cxx fabrics=auto`

**Spack debug report**

* **Spack:** 0.18.0.dev0 (f40780310b650cfb331eb608a6cd833cf413429e)
* **Python:** 3.6.8
* **Platform:** linux-centos8-zen3
* **Concretizer:** clingo


**Error**

```
File "/home/spack/var/spack/repos/builtin/packages/cp2k/package.py", line 665, in edit
mkf.write(fflags('FCFLAGS', fcflags))
UnboundLocalError: local variable 'acc_flags_var' referenced before assignment
==> [2022-05-12-10:26:12.641119] Flagging cp2k-7.1-j36btk4b5hmh2ftgyhp247vy72kv6wyt as failed: UnboundLocalError: local variable 'acc_flags_var' referenced before assignment
==> [2022-05-12-10:26:12.653667] ChildError: UnboundLocalError: local variable 'acc_flags_var' referenced before assignment
```


Discussion:
Hi @alalazo , @dev-zero 

Please have look into this issue, the root cause of the issue is https://github.com/spack/spack/pull/29108.

suggestion, initializing `acc_flags_var` to empty string may resolve the issue or keep this (`acc_flags_var`) variable only for `nvcc` 

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/cp2k/package.py b/var/spack/repos/builtin/packages/cp2k/package.py
--- a/var/spack/repos/builtin/packages/cp2k/package.py
+++ b/var/spack/repos/builtin/packages/cp2k/package.py
@@ -661,7 +661,8 @@ def fflags(var, lst):
             mkf.write(fflags('CPPFLAGS', cppflags))
             mkf.write(fflags('CFLAGS', cflags))
             mkf.write(fflags('CXXFLAGS', cxxflags))
-            mkf.write(fflags(acc_flags_var, nvflags))
+            if '+cuda' in spec:
+                mkf.write(fflags(acc_flags_var, nvflags))
             mkf.write(fflags('FCFLAGS', fcflags))
             mkf.write(fflags('LDFLAGS', ldflags))
             mkf.write(fflags('LIBS', libs))


Test patch:
Repository: spack/spack

Issue:
Fix patch scheme
closes #31222 

Issue introduced with #30605 and not detected in CI until it landed in develop. See for instance:
- https://github.com/spack/spack/runs/6995848809?check_suite_focus=true


Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/meson/package.py b/var/spack/repos/builtin/packages/meson/package.py
--- a/var/spack/repos/builtin/packages/meson/package.py
+++ b/var/spack/repos/builtin/packages/meson/package.py
@@ -65,8 +65,8 @@ class Meson(PythonPackage):
     patch('rpath-0.56.patch', when='@0.56:0.57')
     patch('rpath-0.58.patch', when='@0.58:')
     # Help meson recognize Intel OneAPI compilers
-    patch('https://patch-diff.githubusercontent.com/raw/mesonbuild/meson/pull/9850.patch',
-          sha256='72c77637f4dd5f8af5788dacf01c71d921cd4073af0aa0641a4b5111c50f59cb',
+    patch('https://patch-diff.githubusercontent.com/raw/mesonbuild/meson/pull/9850.patch?full_index=1',
+          sha256='9c874726ce0a06922580d3e3d6adbe74e5144b3a661ef1059f32c9c1bc478b65',
           when='@0.60.0:')
 
     executables = ['^meson$']


Test patch:
Repository: spack/spack

Issue:
Installation issue: hwloc+rocm
### Steps to reproduce the issue

```console
$ spack install hwloc+rocm
```

### Error message

```
/builds/spack/spack/var/spack/repos/builtin/packages/hwloc/package.py:170, in configure_args:
        167            args.append("--disable-rsmi")
        168
        169        if "+rocm" in self.spec:
  >>    170            args.append("--with-rocm={0}".format(self.spec["rocm"].prefix))
        171            args.append("--with-rocm-version={0}".format(self.spec["rocm"].version))
        172
        173        if "+netloc" in self.spec:
```
The problem is that there is no `rocm` package in Spack. Should it instead be `rocm-smi-lib`?

### Information on your system

* **Spack:** 0.19.0.dev0 (8698ca310e15d799a63d96dfc00f1b5cf71319cd)
* **Python:** 3.9.13
* **Platform:** linux-amzn2-x86_64_v4
* **Concretizer:** clingo

### Additional information

@bgoglin @bvanessen this bug was introduced in #30788

### General information

- [X] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [X] I have run `spack maintainers <name-of-the-package>` and **@mentioned** any maintainers
- [X] I have uploaded the build log and environment files
- [X] I have searched the issues of this repo and believe this is not a duplicate


Discussion:

Resolving patch:
diff --git a/var/spack/repos/builtin/packages/hwloc/package.py b/var/spack/repos/builtin/packages/hwloc/package.py
--- a/var/spack/repos/builtin/packages/hwloc/package.py
+++ b/var/spack/repos/builtin/packages/hwloc/package.py
@@ -8,7 +8,7 @@
 from spack.package import *
 
 
-class Hwloc(AutotoolsPackage):
+class Hwloc(AutotoolsPackage, CudaPackage, ROCmPackage):
     """The Hardware Locality (hwloc) software project.
 
     The Portable Hardware Locality (hwloc) software package
@@ -64,7 +64,6 @@ class Hwloc(AutotoolsPackage):
 
     variant("nvml", default=False, description="Support NVML device discovery")
     variant("gl", default=False, description="Support GL device discovery")
-    variant("cuda", default=False, description="Support CUDA devices")
     variant("libxml2", default=True, description="Build with libxml2")
     variant("libudev", default=False, description="Build with libudev")
     variant(
@@ -167,8 +166,8 @@ def configure_args(self):
             args.append("--disable-rsmi")
 
         if "+rocm" in self.spec:
-            args.append("--with-rocm={0}".format(self.spec["rocm"].prefix))
-            args.append("--with-rocm-version={0}".format(self.spec["rocm"].version))
+            args.append("--with-rocm={0}".format(self.spec["hip"].prefix))
+            args.append("--with-rocm-version={0}".format(self.spec["hip"].version))
 
         if "+netloc" in self.spec:
             args.append("--enable-netloc")


Test patch:
Repository: spack/spack

Issue:
Installation issue: Binary libffi fails checksum verification
### Steps to reproduce the issue

```
# On develop branch
spack mirror add binary_mirror  https://binaries.spack.io/releases/v0.18
spack buildcache keys --install --trust
spack -vvv install /d6d3lh3
```

### Error message

==> Installing libffi-3.4.2-d6d3lh3hgkjwbifbbjuvqs2a3w5xj7pd
==> Fetching https://binaries.spack.io/releases/v0.18/build_cache/linux-amzn2-x86_64_v4-gcc-7.3.1-libffi-3.4.2-d6d3lh3hgkjwbifbbjuvqs2a3w5xj7pd.spec.json.sig
gpg: Signature made Tue 31 May 2022 07:27:40 AM UTC using RSA key ID 3DB0C723
gpg: Good signature from "Spack Project Official Binaries <maintainers@spack.io>"
==> Fetching https://binaries.spack.io/releases/v0.18/build_cache/linux-amzn2-x86_64_v4/gcc-7.3.1/libffi-3.4.2/linux-amzn2-x86_64_v4-gcc-7.3.1-libffi-3.4.2-d6d3lh3hgkjwbifbbjuvqs2a3w5xj7pd.spack
==> Extracting libffi-3.4.2-d6d3lh3hgkjwbifbbjuvqs2a3w5xj7pd from binary cache
==> Error: Failed to install libffi due to NoChecksumException: Package tarball failed checksum verification.
It cannot be installed.


### Information on your system

[ec2-user@ip-10-7-228-156 ~]$ spack debug report
* **Spack:** 0.19.0.dev0 (b065d69136023693ace8e4d35d9fdad817d63d93)
* **Python:** 3.7.10
* **Platform:** linux-amzn2-skylake_avx512
* **Concretizer:** clingo


### Additional information

_No response_

### General information

- [X] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [X] I have run `spack maintainers <name-of-the-package>` and **@mentioned** any maintainers
- [X] I have uploaded the build log and environment files
- [X] I have searched the issues of this repo and believe this is not a duplicate


Discussion:

Resolving patch:
diff --git a/lib/spack/spack/installer.py b/lib/spack/spack/installer.py
--- a/lib/spack/spack/installer.py
+++ b/lib/spack/spack/installer.py
@@ -1702,6 +1702,16 @@ def install(self):
                 spack.hooks.on_install_cancel(task.request.pkg.spec)
                 raise
 
+            except binary_distribution.NoChecksumException as exc:
+                if not task.cache_only:
+                    # Checking hash on downloaded binary failed.
+                    err = "Failed to install {0} from binary cache due to {1}:"
+                    err += " Requeueing to install from source."
+                    tty.error(err.format(pkg.name, str(exc)))
+                    task.use_cache = False
+                    self._requeue_task(task)
+                    continue
+
             except (Exception, SystemExit) as exc:
                 self._update_failed(task, True, exc)
                 spack.hooks.on_install_failure(task.request.pkg.spec)


Test patch: