Repository: certbot/certbot

Issue:
Coveralls
Added coveralls badge



Discussion:

Resolving patch:
diff --git a/letsencrypt/client/apache/configurator.py b/letsencrypt/client/apache/configurator.py
--- a/letsencrypt/client/apache/configurator.py
+++ b/letsencrypt/client/apache/configurator.py
@@ -43,7 +43,7 @@
 
 
 class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
-    # pylint: disable=too-many-instance-attributes
+    # pylint: disable=too-many-instance-attributes,too-many-public-methods
     """Apache configurator.
 
     State of Configurator: This code has been tested under Ubuntu 12.04
diff --git a/letsencrypt/client/log.py b/letsencrypt/client/log.py
--- a/letsencrypt/client/log.py
+++ b/letsencrypt/client/log.py
@@ -6,7 +6,7 @@
 from letsencrypt.client import display
 
 
-class DialogHandler(logging.Handler):
+class DialogHandler(logging.Handler):  # pylint: disable=too-few-public-methods
     """Logging handler using dialog info box.
 
     :ivar int height: Height of the info box (without padding).
diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -25,8 +25,7 @@
     'coverage',
     'nose',
     'nosexcover',
-    'pylint<1.4',  # py2.6 compat, c.f #97
-    'astroid<1.3.0',  # py2.6 compat, c.f. #187
+    'pylint>=1.4.0',  # upstream #248
     'tox',
 ]
 


Test patch:
diff --git a/letsencrypt/client/tests/acme_test.py b/letsencrypt/client/tests/acme_test.py
--- a/letsencrypt/client/tests/acme_test.py
+++ b/letsencrypt/client/tests/acme_test.py
@@ -42,7 +42,7 @@ def test_invalid_fails(self):
         self._test_fails('{"type": "foo", "price": "asd"}')
 
 
-class PrettyTest(unittest.TestCase):
+class PrettyTest(unittest.TestCase):  # pylint: disable=too-few-public-methods
     """Tests for letsencrypt.client.acme.pretty."""
 
     @classmethod
diff --git a/letsencrypt/client/tests/apache/util.py b/letsencrypt/client/tests/apache/util.py
--- a/letsencrypt/client/tests/apache/util.py
+++ b/letsencrypt/client/tests/apache/util.py
@@ -12,7 +12,7 @@
 from letsencrypt.client.apache import obj
 
 
-class ApacheTest(unittest.TestCase):
+class ApacheTest(unittest.TestCase):  # pylint: disable=too-few-public-methods
 
     def setUp(self):
         super(ApacheTest, self).setUp()
diff --git a/letsencrypt/client/tests/crypto_util_test.py b/letsencrypt/client/tests/crypto_util_test.py
--- a/letsencrypt/client/tests/crypto_util_test.py
+++ b/letsencrypt/client/tests/crypto_util_test.py
@@ -95,7 +95,7 @@ def test_invalid_false(self):
         self.assertFalse(self._call_testdata('csr.pem', RSA512_KEY))
 
 
-class MakeKeyTest(unittest.TestCase):
+class MakeKeyTest(unittest.TestCase):  # pylint: disable=too-few-public-methods
     """Tests for letsencrypt.client.crypto_util.make_key."""
 
     def test_it(self):  # pylint: disable=no-self-use
@@ -124,6 +124,7 @@ def test_random_false(self):
 
 
 class MakeSSCertTest(unittest.TestCase):
+    # pylint: disable=too-few-public-methods
     """Tests for letsencrypt.client.crypto_util.make_ss_cert."""
 
     def test_it(self):  # pylint: disable=no-self-use
@@ -170,6 +171,7 @@ def test_san(self):
 
 
 class B64CertToPEMTest(unittest.TestCase):
+    # pylint: disable=too-few-public-methods
     """Tests for letsencrypt.client.crypto_util.b64_cert_to_pem."""
 
     def test_it(self):
diff --git a/letsencrypt/client/tests/reverter_test.py b/letsencrypt/client/tests/reverter_test.py
--- a/letsencrypt/client/tests/reverter_test.py
+++ b/letsencrypt/client/tests/reverter_test.py
@@ -385,6 +385,7 @@ def _setup_three_checkpoints(self):
 
 
 class QuickInitReverterTest(unittest.TestCase):
+    # pylint: disable=too-few-public-methods
     """Quick test of init."""
     def test_init(self):
         from letsencrypt.client.reverter import Reverter