Repository: numpy/numpy
Pull request: DOC: Add note for installing `asv` library to run benchmark tests
The `test_requirements.txt` file did not contain the `asv`(Airspeed velocity) library which resulted in failure of benchmarks unless it was installed separately.

fixes #24024 



Problem statement:
BUG: When executing the python runtests.py --bench command, the benchmarks fail to run or execute.
### Describe the issue:

After successfully building NumPy from source, I ran the `python runtests.py -v` command, and it executed without any issues. However, when I attempted to run the `python runtests.py --bench` command, I encountered a `NotADirectoryError`

### Reproduce the code example:

```python
After pulling the latest changes, run the command

`python runtests.py --bench`
```


### Error message:

```shell
Building, see build.log...
Build OK
Traceback (most recent call last):
  File "/home/okabe/Programming/numpy/runtests.py", line 715, in <module>
    main(argv=sys.argv[1:])
  File "/home/okabe/Programming/numpy/runtests.py", line 319, in main
    ret = subprocess.call(cmd, cwd=os.path.join(ROOT_DIR, 'benchmarks'))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 389, in call
    with Popen(*popenargs, **kwargs) as p:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.11/subprocess.py", line 1950, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
NotADirectoryError: [Errno 20] Not a directory: 'asv'
```
```


### Runtime information:

Although the command `print(sys.version)` says `Python 3.8.10`, I am using `Python 3.11.4` in my development environment

```console
>>> import numpy, sys
>>> print(numpy.__version__)
1.24.3
>>> print(sys.version)
3.8.10 (default, May 26 2023, 14:05:08)
[GCC 9.4.0]
>>> print(numpy.show_runtime())
WARNING: `threadpoolctl` not found in system! Install it by `pip install threadpoolctl`. Once installed, try `np.show_runtime` again for more detailed build information
[{'simd_extensions': {'baseline': ['SSE', 'SSE2', 'SSE3'],
                      'found': ['SSSE3',
                                'SSE41',
                                'POPCNT',
                                'SSE42',
                                'AVX',
                                'F16C',
                                'FMA3',
                                'AVX2'],
                      'not_found': ['AVX512F',
                                    'AVX512CD',
                                    'AVX512_KNL',
                                    'AVX512_KNM',
                                    'AVX512_SKX',
                                    'AVX512_CLX',
                                    'AVX512_CNL',
                                    'AVX512_ICL']}}]
None
```

### Context for the issue:

I want to contribute code NumPy, but I cannot run benchmark tests due to this problem.

Hints from issue discussion:

Commit message: DOC: Add note to install asv library for benchmark tests

Patch to review:
diff --git a/doc/source/dev/development_environment.rst b/doc/source/dev/development_environment.rst
index 5ba5fbf04647..2a4e3923a5bc 100644
--- a/doc/source/dev/development_environment.rst
+++ b/doc/source/dev/development_environment.rst
@@ -76,6 +76,11 @@ Before running the tests, first install the test dependencies::
 
     $ python -m pip install -r test_requirements.txt
 
+.. note:: 
+    For running the benchmarks, install the ``asv`` library by running command in the interactive shell::
+
+        $ python -m pip install asv
+
 To build the development version of NumPy and run tests, spawn
 interactive shells with the Python import paths properly set up etc.,
 do one of::


Code review comments:
diff_hunk: @@ -76,6 +76,11 @@ Before running the tests, first install the test dependencies::
 
     $ python -m pip install -r test_requirements.txt
 
+.. note:: 
+    For running the benchmarks, install the ``asv`` library by running command in the interactive shell::
+
+        $ python -m pip install asv
path: doc/source/dev/development_environment.rst
text: @user1:
Can you leave out the `.. note::` (it's a lot of visual attention that isn't really necessary) and change this to a line like this right below the use of `test_requirements.txt`?
```
$ python -m pip install asv  # only needed for running benchmarks
```

@author:
I have made  a commit addressing the requested changes @user1