Repository: home-assistant/core
Pull request: Attempt to fix occasional Flo timeouts
<!--
  You are amazing! Thanks for contributing to our project!
  Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
  If your PR contains a breaking change for existing users, it is important
  to tell them what breaks, how to make it work again and why we did this.
  This piece of text is published with the release notes, so it helps if you
  write it towards our users, not us.
  Note: Remove this section if this PR is NOT a breaking change.
-->
No

## Proposed change
<!--
  Describe the big picture of your changes here to communicate to the
  maintainers why we should accept this pull request. If it fixes a bug
  or resolves a feature request, be sure to link to that issue in the
  additional information section.
-->
This PR increases the timeout guard in the Flo DataUpdateCoordinator in an effort to thwart occasional timeouts when we hit the API. Fixes: #81316

## Type of change
<!--
  What type of change does your PR introduce to Home Assistant?
  NOTE: Please, check only 1! box!
  If your PR requires multiple boxes to be checked, you'll most likely need to
  split it into multiple PRs. This makes things easier and faster to code review.
-->

- [ ] Dependency upgrade
- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests

## Additional information
<!--
  Details are important, and help maintainers processing your PR.
  Please be sure to fill out additional details, if applicable.
-->

- This PR fixes or closes issue: fixes #81316
- This PR is related to issue: 
- Link to documentation pull request: 

## Checklist
<!--
  Put an `x` in the boxes that apply. You can also fill these out after
  creating the PR. If you're unsure about any of them, don't hesitate to ask.
  We're here to help! This is simply a reminder of what we are going to look
  for before merging your code.
-->

- [X] The code change is tested and works locally.
- [X] Local tests pass. **Your PR cannot be merged unless tests pass**
- [X] There is no commented out code in this PR.
- [X] I have followed the [development checklist][dev-checklist]
- [X] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.  
      Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.  
      Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.

<!--
  This project is very active and we have a high turnover of pull requests.

  Unfortunately, the number of incoming pull requests is higher than what our
  reviewers can review and merge so there is a long backlog of pull requests
  waiting for review. You can help here!
  
  By reviewing another pull request, you will help raise the code quality of
  that pull request and the final review will be faster. This way the general
  pace of pull request reviews will go up and your wait time will go down.
  
  When picking a pull request to review, try to choose one that hasn't yet
  been reviewed.

  Thanks for helping out!
-->

To help with the load of incoming pull requests:

- [ ] I have reviewed two other [open pull requests][prs] in this repository.

[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure

<!--
  Thank you for contributing <3

  Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io


Problem statement:
Flo by Moen Disconnects  
### The problem

All my Flo devices report no data. If I do the reload command the data returns.  Any ideas. Can I script a daily reload ?

Steven 

### What version of Home Assistant Core has the issue?

Home Assistant 2022.10.5 Supervisor 2022.10.0 Operating System 9.3 Frontend 20221010.0 - latest

### What was the last working version of Home Assistant Core?

_No response_

### What type of installation are you running?

Home Assistant Container

### Integration causing the issue

Flo by Moen

### Link to integration documentation on our website

_No response_

### Diagnostics information

Logger: homeassistant.components.flo
Source: helpers/update_coordinator.py:182
Integration: Flo (documentation, issues)
First occurred: October 30, 2022 at 12:08:30 PM (6 occurrences)
Last logged: October 30, 2022 at 12:08:31 PM

Timeout fetching flo-66143d00-6b3b-4051-8cc7-17d50a2a28e6 data
Timeout fetching flo-8950d9aa-6427-47b0-a1ab-97a6e5e5f409 data
Timeout fetching flo-a7c07aa0-3e91-44c5-8522-bfd0ccfd87c0 data
Timeout fetching flo-23a9121f-391e-4123-b331-4cf1cd927c0e data
Timeout fetching flo-3c8f3618-c758-468c-9886-20b250f5a38b data

### Example YAML snippet

_No response_

### Anything in the logs that might be useful for us?

```txt
Logger: homeassistant.components.flo
Source: helpers/update_coordinator.py:182
Integration: Flo (documentation, issues)
First occurred: October 30, 2022 at 12:08:30 PM (6 occurrences)
Last logged: October 30, 2022 at 12:08:31 PM

Timeout fetching flo-66143d00-6b3b-4051-8cc7-17d50a2a28e6 data
Timeout fetching flo-8950d9aa-6427-47b0-a1ab-97a6e5e5f409 data
Timeout fetching flo-a7c07aa0-3e91-44c5-8522-bfd0ccfd87c0 data
Timeout fetching flo-23a9121f-391e-4123-b331-4cf1cd927c0e data
Timeout fetching flo-3c8f3618-c758-468c-9886-20b250f5a38b data
```


### Additional information

_No response_

Hints from issue discussion:
Hey there @dmulcahey, mind taking a look at this issue as it has been labeled with an integration (`flo`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L362) for? Thanks!

<details>
<summary>Code owner commands</summary>


Code owners of `flo` can trigger bot actions by commenting:

- `@home-assistant close` Closes the issue.
- `@home-assistant rename Awesome new title` Change the title of the issue.
- `@home-assistant reopen` Reopen the issue.
- `@home-assistant unassign flo` Removes the current integration label and assignees on the issue, add the integration domain after the command.

</details>


<sub><sup>(message by CodeOwnersMention)</sup></sub>

---

[flo documentation](https://www.home-assistant.io/integrations/flo)
[flo source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/flo)
<sub><sup>(message by IssueLinks)</sup></sub>

Commit message: Attempt to fix occasional Flo timeouts

Patch to review:
diff --git a/homeassistant/components/flo/device.py b/homeassistant/components/flo/device.py
index ca4b6aa623488..c636b23a41d38 100644
--- a/homeassistant/components/flo/device.py
+++ b/homeassistant/components/flo/device.py
@@ -40,7 +40,7 @@ def __init__(
     async def _async_update_data(self):
         """Update data via library."""
         try:
-            async with timeout(10):
+            async with timeout(20):
                 await asyncio.gather(
                     *[
                         self.send_presence_ping(),


Code review comments:
diff_hunk: @@ -40,7 +40,7 @@ def __init__(
     async def _async_update_data(self):
         """Update data via library."""
         try:
-            async with timeout(10):
+            async with timeout(20):
                 await asyncio.gather(
path: homeassistant/components/flo/device.py
text: @user1:
Since you are having timeouts with this, does it make sense to make it do one at a time instead of a gather?

@author:
The timeouts are very infrequent from what I have seen but I’m not opposed to splitting them up if you think it makes sense? 

@user1:
I've seen cases where 

- the webserver on embedded devices can't handle the additional concurrency and drops requests which lead to timeouts.
- a cloud service blocks too many requests at the same time because of WAF rules

Not sure if thats what is going on here without an `strace` or wireshark dump

@author:
I don’t think it’s either. I think it’s just poor performance occasionally from the cloud service because it works 99% of the time. If it was a WAF I’d expect many more failures. 

I don’t mind splitting them. I assume each should have its own timeout when split?

@user1:
I think its fine to have a single timeout unless you expect one of them is more likely to timeout than the other or you need to know which call timed out

@author:
gather removed