Repository: saltstack/salt
Pull request: push dep of neutron
### What does this PR do?
Push dep of neutron module
### What issues does this PR fix or reference?
Fixes: https://github.com/saltstack/salt/issues/49430

- [x] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html


Problem statement:
Handle deprecated neutron module
- [ ] salt/utils/openstack/neutron.py

The neutron module has been replaced with neutronng.py. Anything relying on the neutron utils module must be addressed.

Don't forget to remove the autodoc files + references, as well as the stale doc files on the doc build server.

Hints from issue discussion:
going to bump the warn until version to aluminium due to this blocker: https://github.com/saltstack/salt/issues/55663
I accidentally opened a duplicate about this! Copy/paste of what I had:

----

The [salt/utils/openstack/neutron.py](https://github.com/saltstack/salt/blob/master/salt/utils/openstack/neutron.py) utils module says it is being deprecated, and/or that the [salt/modules/neutron.py](https://github.com/saltstack/salt/blob/master/salt/modules/neutron.py) execution module is being deprecated? It has a `warn_until()` message specifying `Aluminium`. It says it is being replaced by the [salt/modules/neutronng.py](https://github.com/saltstack/salt/blob/master/salt/modules/neutronng.py) execution module.

https://github.com/saltstack/salt/blob/116ab7bca102ca2e8755c88bd94806f81cd513ed/salt/utils/openstack/neutron.py#L102-L111

This was included in the output of a query using the following `grep` command from root of the repo:

```
grep -Rn "warn_until" -A1 | egrep -i "Alu" | egrep -v "_build|salt.7|deprecations.rst"
```
````
pillar/neutron.py
modules/neutron.py
````
Need work.
`openstack/neutron.py` is OOP as neutronng is "functional". Method names do not line up with function names and args are different. The biggest difference is the way you are expected to authenticate. It seems we need to rename functions that use this module and handle the new way they authenticate. 
pillar/neutron.py is the only once that needs a port pillar/neutron.py

Commit message: Merge branch 'master' into move_n_dep

Patch to review:
diff --git a/changelog/49430.changed b/changelog/49430.changed
new file mode 100644
index 000000000000..dbfd52047cc1
--- /dev/null
+++ b/changelog/49430.changed
@@ -0,0 +1 @@
+move dep of neutron to Argon. Pls move to neutronng
diff --git a/salt/utils/openstack/neutron.py b/salt/utils/openstack/neutron.py
index 63e2b56beab3..b7934b5f651c 100644
--- a/salt/utils/openstack/neutron.py
+++ b/salt/utils/openstack/neutron.py
@@ -94,7 +94,7 @@ def __init__(
         Set up neutron credentials
         """
         salt.utils.versions.warn_until(
-            "Sulfur",
+            "Argon",
             "The neutron module has been deprecated and will be removed in {version}.\n"
             "This includes\n"
             "* salt.utils.openstack.neutron\n"


Code review comments:
diff_hunk: @@ -0,0 +1 @@
+move dep of neutron to Argon. Pls move to neutronng
path: changelog/49430.changed
text: @user1:
```suggestion
Move deprecation of the neutron module to Argon. Please migrate to the neutronng module instead.
```