Repository: pypa/pip
Pull request: Fix Tests for Travis CI
Fixes #4198 

Problem statement:
Travis CI - pypy broken dues to dependency change in pycrypto
Currently the pypy build on Travis CI is broken since the latest paramiko (2.0) now depends on cryptography >= 1.1 which is incompatible with PyPy 2.5 which is used on Travis CI.

Hints from issue discussion:
One way to fix this, would be to pin down paramiko to a version <2.0 using a version constraint.

Commit message: FIx Tests to pip paramiko

Patch to review:
diff --git a/tests/functional/test_install_reqs.py b/tests/functional/test_install_reqs.py
index c78a21786ea..f441f098b99 100644
--- a/tests/functional/test_install_reqs.py
+++ b/tests/functional/test_install_reqs.py
@@ -171,7 +171,7 @@ def test_install_local_editable_with_extras(script, data):
 @pytest.mark.network
 def test_install_collected_dependencies_first(script):
     result = script.pip(
-        'install', 'paramiko',
+        'install', 'paramiko==1.17',
     )
     text = [line for line in result.stdout.split('\n')
             if 'Installing' in line][0]


Code review comments:
diff_hunk: @@ -171,7 +171,7 @@ def test_install_local_editable_with_extras(script, data):
 @pytest.mark.network
 def test_install_collected_dependencies_first(script):
     result = script.pip(
-        'install', 'paramiko',
+        'install', 'paramiko==1.17',
path: tests/functional/test_install_reqs.py
text: @user1:
Instead of needing paramiko, we could perform this test without the need for network with `toporequires2` which requires `toporequires` (with ``--no-index`, '-f', data.find_links`)

@author:
Yeah. I knew there was some package that could be used but I was being lazy.