Repository: pandas-dev/pandas
Pull request: Fixed code issue from compat with new numpydoc
- [X] closes #26187
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Problem statement:
Doc Check Failures
This just started showing up in the CI failures today:

```sh
Traceback (most recent call last):
  File "ci/../scripts/validate_docstrings.py", line 991, in <module>
    args.ignore_deprecated))
  File "ci/../scripts/validate_docstrings.py", line 891, in main
    result = validate_all(prefix, ignore_deprecated)
  File "ci/../scripts/validate_docstrings.py", line 845, in validate_all
    doc_info = validate_one(func_name)
  File "ci/../scripts/validate_docstrings.py", line 801, in validate_one
    errs, wrns, examples_errs = get_validation_data(doc)
  File "ci/../scripts/validate_docstrings.py", line 749, in get_validation_data
    if not doc.see_also:
  File "ci/../scripts/validate_docstrings.py", line 477, in see_also
    in self.doc['See Also'])
  File "ci/../scripts/validate_docstrings.py", line 476, in <genexpr>
    for name, desc, _
ValueError: not enough values to unpack (expected 3, got 2)
```

I think it's an issue with upgrading to numpydoc 0.9 but will look in more detail and confirm

Hints from issue discussion:
Here's the relevant enhancement on the numpydoc side released in v0.9:

https://github.com/numpy/numpydoc/pull/172

Commit message: Fixed code issue from compat with new numpydoc

Patch to review:
diff --git a/scripts/validate_docstrings.py b/scripts/validate_docstrings.py
index 19df1b92448ef..9592d705a8eb8 100755
--- a/scripts/validate_docstrings.py
+++ b/scripts/validate_docstrings.py
@@ -473,8 +473,7 @@ def parameter_desc(self, param):
     @property
     def see_also(self):
         return collections.OrderedDict((name, ''.join(desc))
-                                       for name, desc, _
-                                       in self.doc['See Also'])
+                                       for name, desc in self.doc['See Also'])
 
     @property
     def examples(self):


Code review comments:
diff_hunk: @@ -473,8 +473,7 @@ def parameter_desc(self, param):
     @property
     def see_also(self):
         return collections.OrderedDict((name, ''.join(desc))
-                                       for name, desc, _
-                                       in self.doc['See Also'])
+                                       for name, desc in self.doc['See Also'])
path: scripts/validate_docstrings.py
text: @user1:
prob want to put a ``numpydoc>=0.9.0`` in environment.yml

alt you might be able to 

``for name, desc, * in self.doc[....]``