Repository: axolotl-ai-cloud/axolotl
Pull request: Added pip install ninja to accelerate installation of flash-attn
# Description
In the Quickstart section, it is required to install flash-attn
Without ninja , installing flash-attn takes more than 2hrs on 64cores


## Motivation and Context

The Quickstart section is expected to get started quickly. however the installation of flash-attn takes a long time
fixes #1460 

## How has this been tested?
Only README.md has changed

## Screenshots (if appropriate)
![Screenshot 2024-03-30 at 11 46 47 AM](https://github.com/OpenAccess-AI-Collective/axolotl/assets/6395936/c27f3f9f-2123-45c4-b039-45b135ce9d3b)


## Types of changes

NA

## Social Handles (Optional)
twitter: @jamesmel24
discord: jamesmel


Problem statement:
Added installation of ninja to Quickstart
### What piece of documentation is affected?

The Quickstart section in README.md 

### What part(s) of the article would you like to see updated?

the Quickstart section of the README.md

pip3 install ninja is required before 
pip3 install -e '.[flash-attn,deepspeed]'

ninja helps using all the cores, else it takes more than 2hrs and defeates the "Quickstart" section

### Additional Information

_No response_

### Acknowledgements

- [X] My issue title is concise, descriptive, and in title casing.
- [X] I have searched the existing issues to make sure this feature has not been requested yet.
- [X] I have provided enough information for the maintainers to understand and evaluate this request.

Hints from issue discussion:

Commit message: Added pip install ninja to accelerate installation of flash-attn

Patch to review:
diff --git a/README.md b/README.md
index 027c476c3b..3e9722b173 100644
--- a/README.md
+++ b/README.md
@@ -109,6 +109,7 @@ git clone https://github.com/OpenAccess-AI-Collective/axolotl
 cd axolotl
 
 pip3 install packaging
+pip3 install ninja
 pip3 install -e '.[flash-attn,deepspeed]'
 ```
 
@@ -1305,6 +1306,7 @@ git clone https://github.com/OpenAccess-AI-Collective/axolotl
 cd axolotl
 
 pip3 install packaging
+pip3 install ninja
 pip3 install -e '.[flash-attn,deepspeed]'
 
 pip3 install -r requirements-dev.txt -r requirements-tests.txt


Code review comments:
diff_hunk: @@ -109,6 +109,7 @@ git clone https://github.com/OpenAccess-AI-Collective/axolotl
 cd axolotl
 
 pip3 install packaging
+pip3 install ninja
path: README.md
text: @user1:
```suggestion
pip3 install packaging ninja
```

@author:
agree

diff_hunk: @@ -1305,6 +1306,7 @@ git clone https://github.com/OpenAccess-AI-Collective/axolotl
 cd axolotl
 
 pip3 install packaging
+pip3 install ninja
path: README.md
text: @user1:
```suggestion
pip3 install packaging ninja
```

@author:
agree