Repository: pandas-dev/pandas
Pull request: Fix issue #35010: Double requirement given for fsspec
- [ ] closes #35010 
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Problem statement:
BUG: Double requirement given for fsspec in requirements-dev.txt
Following error is found, while trying to set up local development environment:

ERROR: Double requirement given: fsspec>=0.7.4 (from -r requirements-dev.txt (line 69)) (already in fsspec>=0.5.1 (from -r requirements-dev.txt (line 25)), name='fsspec')

In requirements-dev.txt, two different versions of fsspec modules are specified.
fsspec>=0.5.1
fsspec>=0.7.4

Hints from issue discussion:
Thanks for the report. We need to remove https://github.com/pandas-dev/pandas/blob/998e2abdca47f37072f4ec5ca72beffb3b1afeaf/environment.yml#L40 and then run `python scripts/generate_pip_deps_from_conda.py`. Would you be able to submit a PR with that?

Commit message: Fixed issue #35010: Double requirement given for fsspec

Patch to review:
diff --git a/doc/source/whatsnew/v1.1.0.rst b/doc/source/whatsnew/v1.1.0.rst
index 75f406d908c73..a6640ea39804b 100644
--- a/doc/source/whatsnew/v1.1.0.rst
+++ b/doc/source/whatsnew/v1.1.0.rst
@@ -1136,7 +1136,7 @@ Other
 - Bug in :class:`Tick` comparisons raising ``TypeError`` when comparing against timedelta-like objects (:issue:`34088`)
 - Bug in :class:`Tick` multiplication raising ``TypeError`` when multiplying by a float (:issue:`34486`)
 - Passing a `set` as `names` argument to :func:`pandas.read_csv`, :func:`pandas.read_table`, or :func:`pandas.read_fwf` will raise ``ValueError: Names should be an ordered collection.`` (:issue:`34946`)
-
+- Fixed bug where two different versions of fsspec is mentioned in requirements-dev.txt (:issue:`35010`)
 .. ---------------------------------------------------------------------------
 
 .. _whatsnew_110.contributors:
diff --git a/environment.yml b/environment.yml
index 3783b7d360f1a..2429f4ab3d699 100644
--- a/environment.yml
+++ b/environment.yml
@@ -37,7 +37,6 @@ dependencies:
   # Dask and its dependencies (that dont install with dask)
   - dask-core
   - toolz>=0.7.3
-  - fsspec>=0.5.1
   - partd>=0.3.10
   - cloudpickle>=0.2.1
 
diff --git a/requirements-dev.txt b/requirements-dev.txt
index 90f9fec2f4bdf..44c975a3b3cfb 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -22,7 +22,6 @@ nbsphinx
 pandoc
 dask
 toolz>=0.7.3
-fsspec>=0.5.1
 partd>=0.3.10
 cloudpickle>=0.2.1
 markdown


Code review comments:
diff_hunk: @@ -1136,7 +1136,7 @@ Other
 - Bug in :class:`Tick` comparisons raising ``TypeError`` when comparing against timedelta-like objects (:issue:`34088`)
 - Bug in :class:`Tick` multiplication raising ``TypeError`` when multiplying by a float (:issue:`34486`)
 - Passing a `set` as `names` argument to :func:`pandas.read_csv`, :func:`pandas.read_table`, or :func:`pandas.read_fwf` will raise ``ValueError: Names should be an ordered collection.`` (:issue:`34946`)
-
+- Fixed bug where two different versions of fsspec is mentioned in requirements-dev.txt (:issue:`35010`)
path: doc/source/whatsnew/v1.1.0.rst
text: @user1:
remove this as not needed, fsspec was just added in 1.1