Repository: frappe/erpnext
Pull request: fix(UX): misleading stock entry lables
1. flip field location (consumption on left, receipt on right like warehouses)
2. Change incorrect label on value difference field


closes https://github.com/frappe/erpnext/issues/30867

before
<img width="1132" alt="Screenshot 2022-05-02 at 2 43 50 PM" src="https://user-images.githubusercontent.com/9079960/166211942-9ac6678e-ba23-4a2f-b5fc-d5f416915fea.png">


after

![image](https://user-images.githubusercontent.com/9079960/166213257-a1ae6b18-9bd3-4c4c-9345-7781fd44d761.png)


Problem statement:
Field "Value Difference" in Stock Entry doctype calculation wrong way round.
### Information about bug

I think the Value Difference field is supposed to calculate the value added to an item. The text says "Total Value Difference(Out - In) but the code calculates (In - Out)

From stock_entry.py
`def set_total_incoming_outgoing_value(self):`
		`self.total_incoming_value = self.total_outgoing_value = 0.0`
		`for d in self.get("items"):`
			`if d.t_warehouse:`
				`self.total_incoming_value += flt(d.amount)`
			`if d.s_warehouse:`
				`self.total_outgoing_value += flt(d.amount)`

		`self.value_difference = self.total_incoming_value - self.total_outgoing_value`



### Module

stock

### Version

v13.21.0
v13.21.0

### Installation method

manual install

### Relevant log output / Stack trace / Full Error Message.

_No response_

Hints from issue discussion:
It's correct. 

Example: 

Additional cost is added to inventory value using repack: 
<img width="1132" alt="Screenshot 2022-05-02 at 2 43 50 PM" src="https://user-images.githubusercontent.com/9079960/166211942-9ac6678e-ba23-4a2f-b5fc-d5f416915fea.png">



Outgoing = consumption
incoming = receipt


difference ~= difference added in inventory value. 

Anyway, this field isn't used anywhere in business logic. 




The field order and field labels are confusing maybe?

Commit message: fix(UX): misleading stock entry lables

Patch to review:
diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.json b/erpnext/stock/doctype/stock_entry/stock_entry.json
index c38dfaa1c844..e658040bd0a6 100644
--- a/erpnext/stock/doctype/stock_entry/stock_entry.json
+++ b/erpnext/stock/doctype/stock_entry/stock_entry.json
@@ -46,9 +46,9 @@
   "items",
   "get_stock_and_rate",
   "section_break_19",
-  "total_incoming_value",
-  "column_break_22",
   "total_outgoing_value",
+  "column_break_22",
+  "total_incoming_value",
   "value_difference",
   "additional_costs_section",
   "additional_costs",
@@ -374,7 +374,7 @@
   {
    "fieldname": "total_incoming_value",
    "fieldtype": "Currency",
-   "label": "Total Incoming Value",
+   "label": "Total Incoming Value (Receipt)",
    "options": "Company:company:default_currency",
    "print_hide": 1,
    "read_only": 1
@@ -386,7 +386,7 @@
   {
    "fieldname": "total_outgoing_value",
    "fieldtype": "Currency",
-   "label": "Total Outgoing Value",
+   "label": "Total Outgoing Value (Consumption)",
    "options": "Company:company:default_currency",
    "print_hide": 1,
    "read_only": 1
@@ -394,7 +394,7 @@
   {
    "fieldname": "value_difference",
    "fieldtype": "Currency",
-   "label": "Total Value Difference (Out - In)",
+   "label": "Total Value Difference (In - Out)",
    "options": "Company:company:default_currency",
    "print_hide_if_no_value": 1,
    "read_only": 1
@@ -619,7 +619,7 @@
  "index_web_pages_for_search": 1,
  "is_submittable": 1,
  "links": [],
- "modified": "2022-02-07 12:55:14.614077",
+ "modified": "2022-05-02 05:21:39.060501",
  "modified_by": "Administrator",
  "module": "Stock",
  "name": "Stock Entry",


Code review comments:
diff_hunk: @@ -386,15 +386,15 @@
   {
    "fieldname": "total_outgoing_value",
    "fieldtype": "Currency",
-   "label": "Total Outgoing Value",
+   "label": "Total Outgoing Value (Consumption)",
    "options": "Company:company:default_currency",
    "print_hide": 1,
    "read_only": 1
   },
   {
    "fieldname": "value_difference",
    "fieldtype": "Currency",
-   "label": "Total Value Difference (Out - In)",
+   "label": "Total Value Difference (In - Out)",
path: erpnext/stock/doctype/stock_entry/stock_entry.json
text: @user1:
```suggestion
   "label": "Total Value Difference (Incoming - Outgoing)",
```
A bit hard to visually cross check right now because instinct was to do LHS - RHS