Repository: explosion/spaCy
Pull request: Limiting noun_chunks for specific languages
Limiting noun_chunks for specific languages as a fix to #5226 

## Description
Enabled noun_chunks to raise Value Error when Doc is not parsed for specific languages.
Added New tests to cover the change.

### Types of change
Enhancement
New tests added

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.


Problem statement:
Can this error raising be lifted?
In doc.pyx' s line 590:

```
 if not self.is_parsed:
            raise ValueError(Errors.E029)
```

I can still do a good job of chunking by tokenization and pos tagging only, without the full parse. Also in some languages parse isn't available.  This will leave more flexibilities to users. I can comment out this in my copy of spacy, but when I update spacy to a new release, I have to change it again.

It would be great if this error can be lifted.

Hints from issue discussion:
I think it would be fine to move this check into each individual noun chunks iterator rather than having it in `Doc.noun_chunks`.

Would you like to submit a PR to make this change? It looks like there are 9 languages that would need to be modified.
How to submit a PR? Have never done that and thanks. 
You can find some basic information here: https://github.com/explosion/spaCy/blob/master/CONTRIBUTING.md#contributing-to-the-code-base

Basically, you'll have to fork (copy) the repo and build it from source. Set up a new virtual environment and `git` to do this. Then you can make changes on a new branch, test them, commit them, and if you're satisified with the final result, you can go to your branches (for me, this is https://github.com/svlandeg/spaCy/branches) and hit the "New pull request" button on the right next to your local branch (you will only see this button if you own that specific fork). This will create a PR against spacy's `master` branch which we can then review.
My implantation now actually depends on this updated release recently:
https://github.com/howl-anderson/Chinese_models_for_SpaCy

And I am talking to the author, and we think it would be nice to make that model official in Spacy for Chinese. Then we can improve quality of some models in it, when we start to use it.  So I would rather wait until it's pushed into the codebase. My previous version depends on Jieba pos tagger, but I would rather like using the full-fledged Chinese model.
Hi @svlandeg and @adrianeboyd! I would like to pick this up if no one is actively working on it.
Sure, I don't think anyone is currently working on this. Moving the check to the individual noun chunks iterators, as Adriane suggested, should be straightforward to do, irrespective of potential other changes to Chinese.
I think Adriane is working on a full Chinese model release and that would be a better time to work on this after that release. Jieba's POS tagging is shaky.
This change doesn't really interact with the Chinese model development, so it would be totally fine to start working on it now.
Thanks, I am working on it and will keep you posted.

Commit message: Limiting noun_chunks for specific languages

Contributor Agreement

Patch to review:
diff --git a/.github/contributors/vishnupriyavr.md b/.github/contributors/vishnupriyavr.md
new file mode 100644
index 00000000000..73657a7729b
--- /dev/null
+++ b/.github/contributors/vishnupriyavr.md
@@ -0,0 +1,106 @@
+# spaCy contributor agreement
+
+This spaCy Contributor Agreement (**"SCA"**) is based on the
+[Oracle Contributor Agreement](http://www.oracle.com/technetwork/oca-405177.pdf).
+The SCA applies to any contribution that you make to any product or project
+managed by us (the **"project"**), and sets out the intellectual property rights
+you grant to us in the contributed materials. The term **"us"** shall mean
+[ExplosionAI UG (haftungsbeschränkt)](https://explosion.ai/legal). The term
+**"you"** shall mean the person or entity identified below.
+
+If you agree to be bound by these terms, fill in the information requested
+below and include the filled-in version with your first pull request, under the
+folder [`.github/contributors/`](/.github/contributors/). The name of the file
+should be your GitHub username, with the extension `.md`. For example, the user
+example_user would create the file `.github/contributors/example_user.md`.
+
+Read this agreement carefully before signing. These terms and conditions
+constitute a binding legal agreement.
+
+## Contributor Agreement
+
+1. The term "contribution" or "contributed materials" means any source code,
+object code, patch, tool, sample, graphic, specification, manual,
+documentation, or any other material posted or submitted by you to the project.
+
+2. With respect to any worldwide copyrights, or copyright applications and
+registrations, in your contribution:
+
+    * you hereby assign to us joint ownership, and to the extent that such
+    assignment is or becomes invalid, ineffective or unenforceable, you hereby
+    grant to us a perpetual, irrevocable, non-exclusive, worldwide, no-charge,
+    royalty-free, unrestricted license to exercise all rights under those
+    copyrights. This includes, at our option, the right to sublicense these same
+    rights to third parties through multiple levels of sublicensees or other
+    licensing arrangements;
+
+    * you agree that each of us can do all things in relation to your
+    contribution as if each of us were the sole owners, and if one of us makes
+    a derivative work of your contribution, the one who makes the derivative
+    work (or has it made will be the sole owner of that derivative work;
+
+    * you agree that you will not assert any moral rights in your contribution
+    against us, our licensees or transferees;
+
+    * you agree that we may register a copyright in your contribution and
+    exercise all ownership rights associated with it; and
+
+    * you agree that neither of us has any duty to consult with, obtain the
+    consent of, pay or render an accounting to the other for any use or
+    distribution of your contribution.
+
+3. With respect to any patents you own, or that you can license without payment
+to any third party, you hereby grant to us a perpetual, irrevocable,
+non-exclusive, worldwide, no-charge, royalty-free license to:
+
+    * make, have made, use, sell, offer to sell, import, and otherwise transfer
+    your contribution in whole or in part, alone or in combination with or
+    included in any product, work or materials arising out of the project to
+    which your contribution was submitted, and
+
+    * at our option, to sublicense these same rights to third parties through
+    multiple levels of sublicensees or other licensing arrangements.
+
+4. Except as set out above, you keep all right, title, and interest in your
+contribution. The rights that you grant to us under these terms are effective
+on the date you first submitted a contribution to us, even if your submission
+took place before the date you sign these terms.
+
+5. You covenant, represent, warrant and agree that:
+
+    * Each contribution that you submit is and shall be an original work of
+    authorship and you can legally grant the rights set out in this SCA;
+
+    * to the best of your knowledge, each contribution will not violate any
+    third party's copyrights, trademarks, patents, or other intellectual
+    property rights; and
+
+    * each contribution shall be in compliance with U.S. export control laws and
+    other applicable export and import laws. You agree to notify us if you
+    become aware of any circumstance which would make any of the foregoing
+    representations inaccurate in any respect. We may publicly disclose your 
+    participation in the project, including the fact that you have signed the SCA.
+
+6. This SCA is governed by the laws of the State of California and applicable
+U.S. Federal law. Any choice of law rules will not apply.
+
+7. Please place an “x” on one of the applicable statement below. Please do NOT
+mark both statements:
+
+    * [x] I am signing on behalf of myself as an individual and no other person
+    or entity, including my employer, has or will have rights with respect to my
+    contributions.
+
+    * [ ] I am signing on behalf of my employer or a legal entity and I have the
+    actual authority to contractually bind that entity.
+
+## Contributor Details
+
+| Field                          | Entry                    |
+|------------------------------- | ------------------------ |
+| Name                           | Vishnu Priya VR          |
+| Company name (if applicable)   | Uniphore                 |
+| Title or role (if applicable)  | NLP/AI Engineer          |
+| Date                           | 2020-05-03               |
+| GitHub username                | vishnupriyavr            |
+| Website (optional)             |                          |
diff --git a/spacy/lang/de/syntax_iterators.py b/spacy/lang/de/syntax_iterators.py
index 89d784a0c66..13bb857cad7 100644
--- a/spacy/lang/de/syntax_iterators.py
+++ b/spacy/lang/de/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -28,6 +29,10 @@ def noun_chunks(obj):
         "app",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_label = doc.vocab.strings.add("NP")
     np_deps = set(doc.vocab.strings.add(label) for label in labels)
     close_app = doc.vocab.strings.add("nk")
diff --git a/spacy/lang/el/syntax_iterators.py b/spacy/lang/el/syntax_iterators.py
index 5dfd44f07f3..f02619ac930 100644
--- a/spacy/lang/el/syntax_iterators.py
+++ b/spacy/lang/el/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -14,6 +15,10 @@ def noun_chunks(obj):
     # Further improvement of the models will eliminate the need for this tag.
     labels = ["nsubj", "obj", "iobj", "appos", "ROOT", "obl"]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings.add(label) for label in labels]
     conj = doc.vocab.strings.add("conj")
     nmod = doc.vocab.strings.add("nmod")
diff --git a/spacy/lang/en/syntax_iterators.py b/spacy/lang/en/syntax_iterators.py
index ed665ef29f3..5ff84812448 100644
--- a/spacy/lang/en/syntax_iterators.py
+++ b/spacy/lang/en/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -20,6 +21,10 @@ def noun_chunks(obj):
         "ROOT",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings.add(label) for label in labels]
     conj = doc.vocab.strings.add("conj")
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/lang/es/syntax_iterators.py b/spacy/lang/es/syntax_iterators.py
index 6a78d86f71d..0badddca1e7 100644
--- a/spacy/lang/es/syntax_iterators.py
+++ b/spacy/lang/es/syntax_iterators.py
@@ -2,10 +2,15 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON, VERB, AUX
+from ...errors import Errors
 
 
 def noun_chunks(obj):
     doc = obj.doc
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     if not len(doc):
         return
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/lang/fa/syntax_iterators.py b/spacy/lang/fa/syntax_iterators.py
index ed665ef29f3..5ff84812448 100644
--- a/spacy/lang/fa/syntax_iterators.py
+++ b/spacy/lang/fa/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -20,6 +21,10 @@ def noun_chunks(obj):
         "ROOT",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings.add(label) for label in labels]
     conj = doc.vocab.strings.add("conj")
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/lang/fr/syntax_iterators.py b/spacy/lang/fr/syntax_iterators.py
index 4712d34d927..9495dcf1e17 100644
--- a/spacy/lang/fr/syntax_iterators.py
+++ b/spacy/lang/fr/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -19,6 +20,10 @@ def noun_chunks(obj):
         "nmod:poss",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings[label] for label in labels]
     conj = doc.vocab.strings.add("conj")
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/lang/id/syntax_iterators.py b/spacy/lang/id/syntax_iterators.py
index 4712d34d927..9495dcf1e17 100644
--- a/spacy/lang/id/syntax_iterators.py
+++ b/spacy/lang/id/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -19,6 +20,10 @@ def noun_chunks(obj):
         "nmod:poss",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings[label] for label in labels]
     conj = doc.vocab.strings.add("conj")
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/lang/nb/syntax_iterators.py b/spacy/lang/nb/syntax_iterators.py
index 4712d34d927..9495dcf1e17 100644
--- a/spacy/lang/nb/syntax_iterators.py
+++ b/spacy/lang/nb/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -19,6 +20,10 @@ def noun_chunks(obj):
         "nmod:poss",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings[label] for label in labels]
     conj = doc.vocab.strings.add("conj")
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/lang/sv/syntax_iterators.py b/spacy/lang/sv/syntax_iterators.py
index 7a82e6b59aa..148884efe7e 100644
--- a/spacy/lang/sv/syntax_iterators.py
+++ b/spacy/lang/sv/syntax_iterators.py
@@ -2,6 +2,7 @@
 from __future__ import unicode_literals
 
 from ...symbols import NOUN, PROPN, PRON
+from ...errors import Errors
 
 
 def noun_chunks(obj):
@@ -20,6 +21,10 @@ def noun_chunks(obj):
         "nmod:poss",
     ]
     doc = obj.doc  # Ensure works on both Doc and Span.
+
+    if not doc.is_parsed:
+        raise ValueError(Errors.E029)
+
     np_deps = [doc.vocab.strings[label] for label in labels]
     conj = doc.vocab.strings.add("conj")
     np_label = doc.vocab.strings.add("NP")
diff --git a/spacy/tests/lang/de/test_noun_chunks.py b/spacy/tests/lang/de/test_noun_chunks.py
new file mode 100644
index 00000000000..542479ae0da
--- /dev/null
+++ b/spacy/tests/lang/de/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_de():
+    """Test that noun_chunks raises Value Error for 'de' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["Er", "lag", "auf", "seinem"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'de'")
diff --git a/spacy/tests/lang/el/test_noun_chunks.py b/spacy/tests/lang/el/test_noun_chunks.py
new file mode 100644
index 00000000000..fa5e5fc7fb4
--- /dev/null
+++ b/spacy/tests/lang/el/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_el():
+    """Test that noun_chunks raises Value Error for 'el' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["είναι", "χώρα", "της", "νοτιοανατολικής"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'el'")
diff --git a/spacy/tests/lang/en/test_noun_chunks.py b/spacy/tests/lang/en/test_noun_chunks.py
index 7dc47f9cc28..48c877a1574 100644
--- a/spacy/tests/lang/en/test_noun_chunks.py
+++ b/spacy/tests/lang/en/test_noun_chunks.py
@@ -6,9 +6,35 @@
 from spacy.symbols import nsubj, dobj, amod, nmod, conj, cc, root
 from spacy.lang.en.syntax_iterators import SYNTAX_ITERATORS
 
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
 from ...util import get_doc
 
 
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed():
+    """Test that noun_chunks raises Value Error if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["This", "is", "a", "sentence"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError")
+
+
 def test_en_noun_chunks_not_nested(en_vocab):
     words = ["Peter", "has", "chronic", "command", "and", "control", "issues"]
     heads = [1, 0, 4, 3, -1, -2, -5]
diff --git a/spacy/tests/lang/es/test_noun_chunks.py b/spacy/tests/lang/es/test_noun_chunks.py
new file mode 100644
index 00000000000..b150bcd2cdf
--- /dev/null
+++ b/spacy/tests/lang/es/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_es():
+    """Test that noun_chunks raises Value Error for 'es' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["en", "Oxford", "este", "verano"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'es'")
diff --git a/spacy/tests/lang/fa/test_noun_chunks.py b/spacy/tests/lang/fa/test_noun_chunks.py
new file mode 100644
index 00000000000..b3759850515
--- /dev/null
+++ b/spacy/tests/lang/fa/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_fa():
+    """Test that noun_chunks raises Value Error for 'fa' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["چطور ","هستید"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'fa'")
diff --git a/spacy/tests/lang/fr/test_noun_chunks.py b/spacy/tests/lang/fr/test_noun_chunks.py
new file mode 100644
index 00000000000..8b519ecbcf6
--- /dev/null
+++ b/spacy/tests/lang/fr/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_fr():
+    """Test that noun_chunks raises Value Error for 'fr' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["trouver", "des", "travaux", "antérieurs"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'fr'")
diff --git a/spacy/tests/lang/id/test_noun_chunks.py b/spacy/tests/lang/id/test_noun_chunks.py
new file mode 100644
index 00000000000..af959c2f79c
--- /dev/null
+++ b/spacy/tests/lang/id/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_id():
+    """Test that noun_chunks raises Value Error for 'id' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["sebelas"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'id'")
diff --git a/spacy/tests/lang/nb/test_noun_chunks.py b/spacy/tests/lang/nb/test_noun_chunks.py
new file mode 100644
index 00000000000..d24ba815ccd
--- /dev/null
+++ b/spacy/tests/lang/nb/test_noun_chunks.py
@@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_nb():
+    """Test that noun_chunks raises Value Error for 'nb' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["Smørsausen", "brukes", "bl.a.", "til"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'nb'")
diff --git a/spacy/tests/lang/sv/test_noun_chunks.py b/spacy/tests/lang/sv/test_noun_chunks.py
index ac7c066bae2..494d10d368d 100644
--- a/spacy/tests/lang/sv/test_noun_chunks.py
+++ b/spacy/tests/lang/sv/test_noun_chunks.py
@@ -2,9 +2,33 @@
 from __future__ import unicode_literals
 
 import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
 from ...util import get_doc
 
 
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_sv():
+    """Test that noun_chunks raises Value Error for 'sv' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["Studenten", "läste", "den", "bästa", "boken"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'sv'")
+
+
 SV_NP_TEST_EXAMPLES = [
     (
         "En student läste en bok",  # A student read a book
diff --git a/spacy/tokens/doc.pyx b/spacy/tokens/doc.pyx
index ec0cd66b823..7b1b987f9b7 100644
--- a/spacy/tokens/doc.pyx
+++ b/spacy/tokens/doc.pyx
@@ -586,8 +586,7 @@ cdef class Doc:
 
         DOCS: https://spacy.io/api/doc#noun_chunks
         """
-        if not self.is_parsed:
-            raise ValueError(Errors.E029)
+        
         # Accumulate the result before beginning to iterate over it. This
         # prevents the tokenisation from being changed out from under us
         # during the iteration. The tricky thing here is that Span accepts


Code review comments:
diff_hunk: @@ -0,0 +1,28 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+import pytest
+from spacy.language import Language
+from spacy.vocab import Vocab
+from spacy.tokens import Doc
+
+
+@pytest.fixture
+def nlp():
+    return Language()
+
+
+def test_noun_chunks_is_parsed_de():
+    """Test that noun_chunks raises Value Error for 'de' language if Doc is not parsed. 
+    To check this test, we're constructing a Doc
+    with a new Vocab here and forcing is_parsed to 'False' 
+    to make sure the noun chunks don't run.
+    """
+    try:
+        doc = Doc(Vocab(), words=["Er", "lag", "auf", "seinem"])
+        doc.is_parsed = False
+        list(doc[0:3].noun_chunks)
+    except ValueError:
+        pass
+    else:
+        pytest.fail("Parsing did not catch a E029 ValueError for language 'de'")
path: spacy/tests/lang/de/test_noun_chunks.py
text: @user1:
You can use the language-specific tokenizer that's already been initialized for use in the test suite and `pytest.raises` to detect the error:

```
def test_noun_chunks_is_parsed_de(de_tokenizer):
    """Test that noun_chunks raises Value Error for 'de' language if Doc is not parsed. 
    To check this test, we're constructing a Doc
    with a new Vocab here and forcing is_parsed to 'False' 
    to make sure the noun chunks don't run.
    """
    doc = de_tokenizer("Er lag auf seinem")
    doc.is_parsed = False
    with pytest.raises(ValueError):
        list(doc.noun_chunks)
```

There should be a tokenizer for each language called `lg_tokenizer` for language `lg`.

@author:
Hi @user1 , Thanks for the review and suggestion. I will make the changes and update the PR accordingly. :)

@author:
Hi @user1 , I have addressed the review comments, retested them and it is working fine with the changes. Can you please review and merge it? Thanks!

@user1:
Looks good! The only remaining thing would be to clean up the now unused imports and fixtures in the tests and then I think it will be ready to be merged.

@author:
Sure @user1, I will work on it and get back to you.