Repository: apache/tvm
Pull request: Fix repository URL in ubuntu_install_rocm.sh
Fix repository URL in ubuntu_install_rocm.sh:
* ROCm dependency installation process was following outdated procedures.
  This PR makes the installation script to point to the correct repository
* Installation documentation is at:
  https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html
* Fixes #9413

cc @tqchen @jtuyls @Mousius 

Problem statement:
[Bug] ubuntu_install_rocm.sh fails when generating ci-gpu image
The nightly Docker image rebuild job is failing for the `ci-gpu` with the following error:

```
 ---> Running in 4087679497b3
Warning: apt-key output should not be parsed (stdout is not a terminal)
gpg: no valid OpenPGP data found.
The command '/bin/sh -c bash /install/ubuntu_install_rocm.sh' returned a non-zero code: 2
ERROR: docker build failed.
script returned exit code 1
```

Looking at the history of the file, can either @jtuyls or @tqchen help with understanding what is going wrong?

Hints from issue discussion:
OK, so it looks like http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key disappeared, and this script then needs updating.

Commit message: Fix repository URL in ubuntu_install_rocm.sh

* ROCm dependency installation process was following outdated procedures.
  This PR makes the installation script to point to the correct repository

* Installation documentation is at:
  https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html

* Fixes #9413

Patch to review:
diff --git a/docker/install/ubuntu_install_rocm.sh b/docker/install/ubuntu_install_rocm.sh
index 0945c582489f..494f6f3e3181 100755
--- a/docker/install/ubuntu_install_rocm.sh
+++ b/docker/install/ubuntu_install_rocm.sh
@@ -21,8 +21,8 @@ set -u
 set -o pipefail
 
 # Install ROCm cross compilation toolchain.
-wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key add -
-echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > /etc/apt/sources.list.d/rocm.list
+wget -qO - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
+echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/4.3/ ubuntu main' | sudo tee /etc/apt/sources.list.d/rocm.list
 apt-get update && apt-get install -y \
     rocm-dev \
     lld && \


Code review comments:
diff_hunk: @@ -21,8 +21,8 @@ set -u
 set -o pipefail
 
 # Install ROCm cross compilation toolchain.
-wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key add -
-echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > /etc/apt/sources.list.d/rocm.list
+wget -qO - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
+echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/4.3/ ubuntu main' | sudo tee /etc/apt/sources.list.d/rocm.list
 apt-get update && apt-get install -y \
     rocm-dev \
     lld && \
path: docker/install/ubuntu_install_rocm.sh
text: @user1:
I think it's just this @author:
```suggestion
    lld-12 && \
```