Repository: home-assistant/core
Pull request: Fix battery reading in SOMA API
<!--
  You are amazing! Thanks for contributing to our project!
  Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->


## Proposed change
<!--
  SOMA Connect API has for a long time now provided a battery level reading as a percentage. Doing that calculation in device makes much more sense. This fix is in response to our release of a new model that has a higher battery voltage. Doing the percentage calculation in the integration here breaks when faced with the newer higher voltage battery. Currently all SOMA Smart Shades v3 motors always report 100% battery in HA. This change fixes that.
-->


## Type of change
<!--
  What type of change does your PR introduce to Home Assistant?
  NOTE: Please, check only 1! box!
  If your PR requires multiple boxes to be checked, you'll most likely need to
  split it into multiple PRs. This makes things easier and faster to code review.
-->

- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests

## Additional information
<!--
  Details are important, and help maintainers processing your PR.
  Please be sure to fill out additional details, if applicable.
-->

- This PR fixes or closes issue: fixes #93034
- This PR is related to issue: 
- Link to documentation pull request: 

## Checklist
<!--
  Put an `x` in the boxes that apply. You can also fill these out after
  creating the PR. If you're unsure about any of them, don't hesitate to ask.
  We're here to help! This is simply a reminder of what we are going to look
  for before merging your code.
-->

- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.  
      Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.  
      Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.

<!--
  This project is very active and we have a high turnover of pull requests.

  Unfortunately, the number of incoming pull requests is higher than what our
  reviewers can review and merge so there is a long backlog of pull requests
  waiting for review. You can help here!
  
  By reviewing another pull request, you will help raise the code quality of
  that pull request and the final review will be faster. This way the general
  pace of pull request reviews will go up and your wait time will go down.
  
  When picking a pull request to review, try to choose one that hasn't yet
  been reviewed.

  Thanks for helping out!
-->

To help with the load of incoming pull requests:

- [ ] I have reviewed two other [open pull requests][prs] in this repository.

[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure

<!--
  Thank you for contributing <3

  Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr


Problem statement:
Battery values are displayed incorrectly in Soma Connect
### The problem

I use for our roller blinds, drives from Soma. As a bridge I use the new version with the USB stick. I have installed the integration Soma Connect, but it is always displayed at the battery levels 100%.
I have to test whether the values of the USB Brigde are output, installed a plugin on my Homebridge and there the correct values are read out.
As a comparison, I still have the manufacturer app, which also displays the battery values.
The values from Homebridge and the app are the same.

### What version of Home Assistant Core has the issue?

2023.5.2

### What was the last working version of Home Assistant Core?

_No response_

### What type of installation are you running?

Home Assistant OS

### Integration causing the issue

Soma Connect

### Link to integration documentation on our website

_No response_

### Diagnostics information

_No response_

### Example YAML snippet

_No response_

### Anything in the logs that might be useful for us?

_No response_

### Additional information

_No response_

Hints from issue discussion:
Hey there @ratsept, @sebfortier2288, mind taking a look at this issue as it has been labeled with an integration (`soma`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1163) for? Thanks!

<details>
<summary>Code owner commands</summary>


Code owners of `soma` can trigger bot actions by commenting:

- `@home-assistant close` Closes the issue.
- `@home-assistant rename Awesome new title` Renames the issue.
- `@home-assistant reopen` Reopen the issue.
- `@home-assistant unassign soma` Removes the current integration label and assignees on the issue, add the integration domain after the command.

</details>


<sub><sup>(message by CodeOwnersMention)</sup></sub>

---

[soma documentation](https://www.home-assistant.io/integrations/soma)
[soma source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/soma)
<sub><sup>(message by IssueLinks)</sup></sub>

Commit message: Merge branch 'dev' into soma-battery-fix

Patch to review:
diff --git a/homeassistant/components/soma/sensor.py b/homeassistant/components/soma/sensor.py
index 6472f6934e00dc..e48c51f40d3ad1 100644
--- a/homeassistant/components/soma/sensor.py
+++ b/homeassistant/components/soma/sensor.py
@@ -43,11 +43,6 @@ def native_value(self):
     async def async_update(self) -> None:
         """Update the sensor with the latest data."""
         response = await self.get_battery_level_from_api()
-
-        # https://support.somasmarthome.com/hc/en-us/articles/360026064234-HTTP-API
-        # battery_level response is expected to be min = 360, max 410 for
-        # 0-100% levels above 410 are consider 100% and below 360, 0% as the
-        # device considers 360 the minimum to move the motor.
-        _battery = round(2 * (response["battery_level"] - 360))
+        _battery = response["battery_percentage"]
         battery = max(min(100, _battery), 0)
         self.battery_state = battery


Code review comments:
diff_hunk: @@ -43,11 +43,6 @@ def native_value(self):
     async def async_update(self) -> None:
         """Update the sensor with the latest data."""
         response = await self.get_battery_level_from_api()
-
-        # https://support.somasmarthome.com/hc/en-us/articles/360026064234-HTTP-API
-        # battery_level response is expected to be min = 360, max 410 for
-        # 0-100% levels above 410 are consider 100% and below 360, 0% as the
-        # device considers 360 the minimum to move the motor.
-        _battery = round(2 * (response["battery_level"] - 360))
+        _battery = response["battery_percentage"]
path: homeassistant/components/soma/sensor.py
text: @user1:
Why we can't support both ways?

Assuming only devices with the new firmware have `battery_percentage` in the response, we could do something like this:

```suggestion 
        _battery = response.get("battery_percentage")
        if _battery is None:
            # https://support.somasmarthome.com/hc/en-us/articles/360026064234-HTTP-API
            # battery_level response is expected to be min = 360, max 410 for
            # 0-100% levels above 410 are consider 100% and below 360, 0% as the
            # device considers 360 the minimum to move the motor.
            _battery = round(2 * (response["battery_level"] - 360))
```