id,modified_comment,Anger,Love,Fear,Joy,Sadness,Surprise 704844644,"This change doesn't affect anything but makes the code more clear. If you look at the line about, `currentUrlTree` is set to `urlAfterRedirects`.",0,0,0,1,0,0 886568180,"Thanks very much for your feedback [USER] Your point is totally fair. My intention was to highlight that camelCase or dash-case class names are perfectly fine to use in Angular templates. Most people, especially beginners, do not know that and end up using the `ngClass` directive. Do you think that rewording the alert towards that direction would make sense?",0,1,0,0,0,0 950480127,"[BLOCK QUOTE]. Works perfectly that way! Thanks!",0,1,0,0,0,0 897560867,"[USER] Thanks for the quick answers! It is good to have this cleared out of the way. I do like your clarification on how this is a different dynamic as using Angular elements. [BLOCK QUOTE]. This would be the same thing as it is for stand-alone(module-less) components, or am I looking from the wrong side? Those problems need to be solved anyway for truly dynamic components as far as I can see.",0,1,0,0,0,0 878517138,"[USER] I don't think that it would be possible to get this fixed in Angular v8, but many thanks for investigating the root cause and posting info here.",0,1,0,0,0,0 649409703,oh nice! I tried to find one but couldn't,0,1,0,0,0,0 695111102,"Oke. Thanks. Wow, it was my 300th PR :).",0,1,0,0,0,0 94057267,"[USER] my bad! Thanks for the suggestion, I have removed the leftovers from testing.",0,1,0,0,0,0 94108066,"No probs, thank you for double checking.",0,1,0,0,0,0 94288011,I made my first commit at 4AM :-) May be why! Thank you,0,1,0,0,0,0 94314710,Thanks for the feedback. Done,0,1,0,0,0,0 94482514,I'll wait on this one before merging. Nice work overall.,0,1,0,0,0,0 96147085,probably much more readable :D like that.,0,1,0,0,0,0 132652883,That's a great idea. A Tombstone object,0,1,0,0,0,0 157323470,I think I like your first suggestion because it allows us to keep the hooks in one place.,0,1,0,0,0,0 157376729,"hmm for some reason i thought it was opposite, updating. Thank you [USER]",0,1,0,0,0,0 161802761,"neat, thanks for the tip.",0,1,0,0,0,0 166580511,"Oh, you didn't add composes and values. Well, I like it even more. Those features are hard to maintain.",0,1,0,0,0,0 178769538,I prefer how Tobias wrote it. It is more expressive and easier to understand how it works.,0,1,0,0,0,0 194542610,"[USER] If you need help, feel free to assign us to a respective project, sub-ticket we can work on.",0,1,0,0,0,0 448856427,"Interesting idea. That's worth trying. I think I refactor the whole thing in a way to not leak the parsed version into the API, so all this is webpack internal and can be changed in future.",0,1,0,0,0,0 483824904,Thanks for the clarification πŸ‘,0,1,0,0,0,0 499866755,ah! Got it [USER] thank you.,0,1,0,0,0,0 534503726,"I love the subtlety of this fix and I keep on being amazed that DevTools ""fuzzes"" TypeScript πŸ˜‚",0,1,0,0,0,0 550365711,"Love it. how do we do that? Update: Well you already explained. I'm gonna try to do it πŸ˜…",0,1,0,0,0,0 561371829,"in context, I think this is a pretty good name.",0,1,0,0,0,0 566340114,"consider unit testing this function. It's a pure function which should make it easy to unit test, it's reusable, and it's non-trivial enough to warrant a test IMHO.",0,1,0,0,0,0 622142795,🧐 awwww I have no idea how I managed that. Goodness! Thank you for catching this! 😁,0,1,0,0,0,0 626115467,Oh! Thank you!!! Actually fixed now. πŸ™ƒ,0,1,0,0,0,0 626601399,"Pete answered here: [URL] Thanks, both of you!",0,1,0,0,0,0 638742132,I like the idea of having a class πŸ‘,0,1,0,0,0,0 641696774,"Wow, this was a tricky one. Thank you!",0,1,0,0,0,0 644409707,Interesting. Thanks for the explanation.,0,1,0,0,0,0 654631907,"This looks good, thanks for clarifying the docs.",0,1,0,0,0,0 665722743,Just wanted to note that I appreciate this name to avoid the keyword `class`,0,1,0,0,0,0 666535767,makes sense! thanks for the clarification.,0,1,0,0,0,0 668308645,These are great tests and really helped me understand how this works πŸ‘,0,1,0,0,0,0 669081074,These are much more helpful. I will update. :),0,1,0,0,0,0 669849854,"That's a good point, developers would find completing pipe arguments helpful (e.g. the `date` pipe). For inputs with square brackets we can only complete with strings. For pipe arguments, we can complete with strings, number literals, true, false, null and undefined. Do you think we need separate scopes for pipe arguments and inputs without square brackets? or can we results for filter inputs without square brackets to only include strings?",0,1,0,0,0,0 670758656,Thanks for the detailed explanation!,0,1,0,0,0,0 671451986,"let's look what [USER] answer, maybe it is not bad to have parser pinned, sometimes regressions happens",0,1,0,0,0,0 671822413,"cool thank you very much both, I will amend this :smiley:",0,1,0,0,0,0 675865624,"πŸ‘ Awesome, looks good to me!",0,1,0,0,0,0 677784183,awesome points! I will amend this sorry :bow:,0,1,0,0,0,0 680570961,"Ah wow! thank you so so very much for the clear explanation!!!! you're amazing as always! thanks so much!!! :slightly_smiling_face: --- About your comment regarding the tsconfig file locations, my current solution uses the existing `.eslintrc.json` file so I'd imagine the tconfigs are relative to that one and don't cause issues, and it does lint the files inside the ts files inside the `firebase-test-utils` directory, I tested that by violating some rules there and getting indeed errors But I understand that it could be beneficial to keep the directories self contained (especially after your explanation) I will add an `.eslintrc.json` file there too then :slightly_smiling_face: , I think a good solution would just be to extend the existing `.eslintrc.json` (meaning `""extends"": ""../../.eslintrc.json""`), as that is also what the existing `tsconfig.json` does ( [URL] )",0,1,0,0,0,0 681206232,"Oh I see, the rest was factored out of the assert. This is a really nice clean up.",0,1,0,0,0,0 681312224,"I think that's a pretty good, realistic example of this πŸ‘",0,1,0,0,0,0 684418921,"Yeah, using `JSON.stringify()` might not be possible. My proposal is to rephrase the error string to be more explicit on what the problem is (currently it's quite unclear) without additional `JSON.stringify()` calls.",0,1,0,0,0,0 687277770,"Ah, I was working around the fact that _localFocalPoint is `late` and won't be initialized on the first run here, so I can't grab the value out of it here. I've updated it to an if/else that avoids the recalculation, let me know if you like the old way better.",0,1,0,0,0,0 688423762,"Correct, just fixed, thank you!",0,1,0,0,0,0 690217023,Thanks! I've extended a new parameter `autoWrap` to control whether or not to wrap the parameter automatically.,0,1,0,0,0,0 690663413,"awesome thanks a lot :slightly_smiling_face: I also see don't have a strong preference either way, but I am leaning a bit more on the second one, so since you're giving me carte blanche I'll go with that thanks! :smiley:",0,1,0,0,0,0 694266175,"Ah my bad! Thanks for your comment [USER] I think my confusion comes from the fact that I made the wrong assumption that part ""the browser will not block while the service waits"" was a consequence of the first part of the sentence. Here is a proposition of a new wording: _The HeroService must wait for the server to respond, getHeroes() cannot return immediately with hero data, and because the browser don't block while the service waits the heroes property won't be updated._ What do you think?",0,1,0,0,0,0 694986103,This is nice and clean! Awesome!,0,1,0,0,0,0 698685297,"Nice, thanks for adding this missing shape parameter to this.",0,1,0,0,0,0 705777941,Thank you for documenting these quirks πŸ™,0,1,0,0,0,0 706383441,"Thank you for this suggestion! Just made the change, the variable names are definitely more understandable now.",0,1,0,0,0,0 708655866,[USER] Thank you for the confirmation.,0,1,0,0,0,0 713436499,yep that is a much nicer way of doing it. Thanks Ron!,0,1,0,0,0,0 713918292,Ya that's totally fair! I decided to add it for both test cases just for my own sanity that it narrows it down correctly. Appreciate the help and guidance πŸ˜„,0,1,0,0,0,0 719360325,"sweet! I love what you did here [USER], the assertions are much nicer after JSON.parse. Awesome!",0,1,0,0,0,0 719423176,YEEESSSSSS!!!!!!! THANK YOU ❀️,0,1,0,0,0,0 719432207,thank you for adding the lint rule. πŸ™‡πŸ»,0,1,0,0,0,0 722474737,"I definitely agree that the name is confusing, but couldnt think of a great way to create a new variable which remains backward compatible. Let me give it another go. I like the suggestions you gave above",0,1,0,0,0,0 724089127,"[USER] Ok. I've closed PR. If you have any interest in fixing this issue, I would be very grateful for that. πŸ‘πŸ»",0,1,0,0,0,0 724371984,Thanks for the detailed comment!,0,1,0,0,0,0 725279828,"Thanks, that explanation makes sense.",0,1,0,0,0,0 726535928,"[USER] thanks for your excellent code review, I totally missed both of those.",0,1,0,0,0,0 730143882,"Your changes do seem to be doing the trick and the tests pass with them, thank you very much, I committed them (but I will need to come back to this tomorrow with a clearer head and reason about this stuff to understand the logic better :sweat_smile:)",0,1,0,0,0,0 730264646,Either way works for me. Up to you :smiley:,0,1,0,0,0,0 732155277,Thanks for the picture. This is great context that should be added as a comment,0,1,0,0,0,0 733987019,thanks for explaining your thought process! 😊,0,1,0,0,0,0 738369609,"Your approach looks fine to me :smiley: The only thing is that the last part, `(?` works is it will actually restart the server even if there are type errors and not hold up the refresh cycle. This can be handy, except when it's not, ie. you didn't notice you forgot to pass in a new function parameter and thats why your endpoint doesn't work, for example. In my opinion **extreme** is the long term solution here, other tools are starting to integrate and support non TS based tooling (like esbuild and swc) as they are written in Rust or other more performant languages. I love Angular and don't want it to fall behind in terms of compilation performance or DX because it is not embracing new tools. Of course I realize this is a major lift and will take a lot of time and effort so I don't expect the Angular team to just go and implement it overnight but do strongly believe we need to keep up to date with tooling. The Angular CLI has always been one of the best selling points of Angular and one of the best built in CLI tools out there, let's not let it fall behind. All in all, I love this RFC and support optimizing the pipeline wholeheartedly, the better we make it for the developers using it the more people will use it and love it.",0,1,0,0,0,0 915815692,"Thank you for landing this feature in time for TypeScript 4.5! πŸŽ‰ I am super excited for the follow-on PR to introduce type-only import identifiers. Probably we would wait for that before enabling this feature, to avoid doubling up on import lines (that would occur via the addition of an `import type` line). IMO this all adds up to excellent progress towards explicitness and simplicity.",0,1,0,0,0,0 918441034,"Excellent detective work, [USER] πŸ•΅οΈ",0,1,0,0,0,0 919125167,Aah okay. Thanks for the explanation.,0,1,0,0,0,0 920542149,"[BLOCK QUOTE]. @andrewbranch Thanks for the tips! I ran the 'baseline-accept' script after running the tests one more time and I've pushed another commit to the PR with the changes the script produced.",0,1,0,0,0,0 923313638,"[USER] Thanks a lot for the awesome reviewing!!!! (like always! :heart_eyes:) I addressed all your comments :slightly_smiling_face::+1: The only one still not addressed (waiting for your replies) should be: - ~~[URL] - ~~[URL] - ~~[URL] (maybe? :thinking:)~~ - ~~[URL] (maybe? :thinking:)~~ ___ Update: all addressed now :slightly_smiling_face::+1:",0,1,0,0,0,0 924308978,"Great, that's exactly what I was looking for. It was tough to find this in the docs. Thank you. Closing this one.",0,1,0,0,0,0 926156624,"Thanks for taking a look, after reading your response (a few times hehe) I guess it makes sense... I'm tempted to suggest something like: [TRIPLE QUOTE]. but I think it is too un-facile to consider seriously. /shrug Thanks again for all your work on everyone's favorite language πŸ’ͺ",0,1,0,0,0,0 926495436,"Having been loosely keeping up with the TypeScript discussions around the new Node resolutions, I just wanna say thanks for putting in what is clearly a significantly amount of time and effort towards both getting things right and making things as user-friendly as possible! πŸ˜€",0,1,0,0,0,0 927917698,"This is definitely broken, thanks for reporting!",0,1,0,0,0,0 929224730,Cool. Thanks for explaining. This makes it easier for me to explain why things are the way things are,0,1,0,0,0,0 932938842,"My latest implementation (at least for me) seems to work exactly as the webkit implementation now :slightly_smiling_face: , the only thing different being that the webkit icon doesn't have `cursor: pointer` but the new icon does, I like it better this was, feels more polished, but if you disagree I can remove it :+1:",0,1,0,0,0,0 932941397,"Hello, I have exactly same issue but on Linux, but i have found the problem and an temporary solution. The problem come from `include` property in `tsconfig.json` when that property is set to folder or too ambigu in that case `src`(but this is same if is set to `src/**/*`). My solution its stupid but simply specify file type `src/**/*.ts`. Thanks.",0,1,0,0,0,0 939286414,duh! thanks so much... I guess I can ignore that warning for now.,0,1,0,0,0,0 940657139,"[BLOCK QUOTE]. Thank you, I understand now",0,1,0,0,0,0 941395566,"Ok thank you very much, I'll do my best! :smile:",0,1,0,0,0,0 941927064,"Dear [USER] , it's so brilliant to get the reproducible code! Before fixing it, could we have any workaround for this code, so that my repo can work as expected under a specific version of TypeScript(4.4, or next, or dev version are all acceptable)? Thank you very much and appreciate your help.",0,1,0,0,0,0 944261863,"Ack, thanks for the details!",0,1,0,0,0,0 945145629,"[BLOCK QUOTE]. Aha, excellent point πŸ’‘ I think it is fine to always apply all regexes (or just apply the HTML regexes on TS files). If we wanted to be even more sophisticated, we could look for an `@Component` annotation, but looking for a `template` property sounds a bit too much. (I won't stop you if you want to give it a shot, but it will complicate things quite a bit.) **Fun fact** (not pragmatically relevant, but...): HTML comments are [kind of respected][1] in JavaScript (for legacy reasons). [1]: [URL]",0,1,0,0,0,0 945996633,Thanks for the suggestions [USER],0,1,0,0,0,0 946610241,"[BLOCK QUOTE]. @owl-from-hogvarts Updated. Thank for your advice.",0,1,0,0,0,0 946635394,Yeah - sorry [USER] it is not the easiest onboarding. Perhaps your first contribution could be to improve that README??,0,1,0,0,0,0 947409620,Thanks for the quick and comprehensive answer!,0,1,0,0,0,0 947562574,"Hello Taha, sorry for the late response and kindly find the below figures : [TRIPLE QUOTE]. [TRIPLE QUOTE]. for the minimal app for only local auth, please consider this as minimal because this is just a test on how to implement.",0,1,0,0,0,0 947745882,"Thanks for spending so much time on my issue πŸ˜„ I know about the lazyStyleTag syntax, I learned about it from the [USER] plugin πŸ˜† Actually I just wanted to use that plugin to switch between the themes from my library in storybook... I also don't know how to set up such an exclusion as I don't know how to change the angular-generated webpack config... 8 days ago Webpack was just some tool that was used ""under the hood"" by Angular. I didn't even know what it's used for 🀣 Now I know (a little) about modules, loaders, inline syntax...",0,1,0,0,0,0 948411724,"Hi [USER] you appear to be on an older version of flutter. Please upgrade to the latest version of flutter and see if you still experience this issue. If you do, please provide a complete minimal reproducible code sample and output of `flutter doctor -v`. Thank you",0,1,0,0,0,0 949000003,"[BLOCK QUOTE]. I can confirm this seems fixed when using master channel! @darshankawar : Many thanks for taking this bug seriously and addressing it so that it got the right attention! Hopefully this will make its way to beta channel soon.",0,1,0,0,0,0 949608009,Thanks for the update. Treating this as a proposal.,0,1,0,0,0,0 949976247,I personally like this. [USER] [USER] what do you think?,0,1,0,0,0,0 953126498,Thanks! I did not know that existed. Looks like there is a similar discussion going on at [URL],0,1,0,0,0,0 953445513,"Thanks again for the hack! I just wanted to call out that if your VSCode config specifies the `""typescript.tsdk""` option, you'll need to update the `tsserver.ts` in whatever location that option specifies. It would have saved me a bit of debugging time πŸ™ƒ",0,1,0,0,0,0 953450209,"hi [USER] thank you so much about the explanation",0,1,0,0,0,0 953848468,[USER] Thanks for the patch. I don't have a setup to build the Flutter Engine just yet so it may take a little time to be able to verify the patch. Will keep you posted once I'm able to.,0,1,0,0,0,0 954729022,"Hi [USER] Thank you for your confirmation. I have split this issue for iPad OS. I've also edited the title of this issue for iOS. I'm new to creating issues, so I'm not sure about tagging. Thank you",0,1,0,0,0,0 955030877,"Yup that looks like it. Awesome and thanks a ton for the pointer, I tried looking around for an explanation but could not find one.",0,1,0,0,0,0 955054851,Thanks [USER] for doing this work!,0,1,0,0,0,0 955955379,"[USER] thanks for the reply. If you don't have a chance to help - don't worry, I can take care of creating a PR and you can help with other fixes/improvements in the future. Thank you.",0,1,0,0,0,0 956879912,"[USER] Thank you for your comment. Because when I did 'Tour of Heroes' in Angular version 12, There was a difference between the code generated by Angular CLI and example code.",0,1,0,0,0,0 959400185,"[USER] Sorry for the late reply, also thanks for your awesome repro demo, I tried it, but I only repro once :), I already make a PR [URL] to try to fix it. Let's wait for Flutter team to review.",0,1,0,0,0,0 959459146,[USER] Awesome! Thank you for taking a look at this issue quickly. Really appreciate your efforts!,0,1,0,0,0,0 724598198,This sparks joy. :) Thank you,0,1,0,0,0,0 652595957,thanks for your suggestion. please review again.,0,1,0,0,0,0 117821949,I guess a JSON.stringify would be great here if the env is an object.,0,1,0,0,0,0 959346020,"[USER] finally I solved the issue (by reading this page on [overstack]([URL] I've reset Android Studio to the default settings, then I installed Dart and Flutter plugins, then It worked Manage IDE Settings ---> Restore Default Settings... ![image]([URL] ![image]([URL] Thank you [USER] for your help",0,1,0,1,0,0 779270595,"Yep, bug, thanks for the issue",0,0,0,1,0,0 92501584,"I also agree, but lets keep them for now since we aren't done with setting it up on webpack.js.org yet.",0,0,0,1,0,0 94004395,I simply took what was above in the same file! I do agree they don't really make sense though.,0,0,0,1,0,0 94504993,"Yeah, that makes sense. I have omitted the output property from the test.",0,0,0,1,0,0 101964698,uhh good catch. and yes should have further cleaned up.,0,0,0,1,0,0 168005195,Then it's fine πŸ‘,0,0,0,1,0,0 184581200,"I agree we can discuss there. If we need to change, I'll go in and remove where needed.",0,0,0,1,0,0 206464542,Yep. I was hesitant. That's probably the best move.,0,0,0,1,0,0 225866422,"No it isn't, good catch",0,0,0,1,0,0 274094522,"Yes, We need to implement features that can be used with the file/url-loader. So, I want to implement it in the next step. Also, I want to move all test cases from these loaders.",0,0,0,1,0,0 324006383,"you're right, I should have wrapped the entire thing in the promise. I changed it, should be visible in the latest commit",0,0,0,1,0,0 477496765,"oh, that makes sense; `[USER] {[USER] ... }` is a pretty common construction I think. never mind.",0,0,0,1,0,0 485136866,"This looks sketchy, but I manually verified that the assertion should hold in all cases we currently have; it’s just hard to encode it into the types. The only times `host.getCurrentDirectory` is `undefined` are 1. The command line parser and typings installer each call the module name resolver in an ad-hoc way under certain circumstances, but they pass a hard-coded `compilerOptions` that lack `paths`, so this code path is never taken. 2. `Project` calls `getAutomaticTypeDirectives` with a `DirectoryStructureHost`, but that function never uses `host.getCurrentDirectory()`. Changing `ModuleResolutionHost['getCurrentDirectory']` to be non-optional makes these call sites a bit of a nuisance.",0,0,0,1,0,0 540864006,"Yeah, pretty much that exactly.",0,0,0,1,0,0 552161218,You are right because it would resolve completely to actual path even if equivalent of npm link kind of thing is used .,0,0,0,1,0,0 567249541,"I agree with the more general point that it is rarely useful to look at the constraints of types when determining whether one is an instance of the other. I do think, however, that this is one of the rare cases where it actually is useful. I completely agree with all the other points you're making πŸ™‚ I also added your example to the test, although I don' think it will be immediately impacted by the change.",0,0,0,1,0,0 595303968,"Code size/performance, yes I would have to agree",0,0,0,1,0,0 600179413,"[BLOCK QUOTE]. That's precisely what I was describing, yes.",0,0,0,1,0,0 616117268,Seems good!,0,0,0,1,0,0 629735298,"That looks good, but you could also just use a class field in the binding and update it [as described here]([URL]",0,0,0,1,0,0 654364216,Absolutely right! :),0,0,0,1,0,0 656585390,"yes, this is the way i will go about fixing this issue. Please make sure the mechanism is only enabled during debug mode, i.e. wraps the logic in an assert",0,0,0,1,0,0 656631873,"Good point. In that case overflowAlignment applies. This would be a good place to mention overflowAlignment, I'll add it.",0,0,0,1,0,0 657494742,"Yes, because usage indicates that it's unhelpful.",0,0,0,1,0,0 658744651,Looks good! I was unsure how to implement it cleanly in my PR so I just force committed the changes. To my PR Branch 🀞,0,0,0,1,0,0 658793281,"Looks fine to me. You could do this with a second regex replace (!) but I don't think it would make much difference to the performance, and this is pretty easy to follow.",0,0,0,1,0,0 678725568,can we use `getStart()` rather than `pos` to follow the convention in the rest of the file?,0,0,0,1,0,0 680251404,"That is actually a good point, let me think about this more",0,0,0,1,0,0 687724118,[USER] right! I just pushed the updated commit,0,0,0,1,0,0 688181503,"Ah ok interesting, best to keep both then πŸ‘",0,0,0,1,0,0 690000276,"Yeah, that's sounds right. I image we probably shouldn't ignore casts.",0,0,0,1,0,0 692149722,"You're right. What's a better wording for this paragraph? How about [BLOCK QUOTE].",0,0,0,1,0,0 702198884,that makes sense. just FYI this may lead to a bigger overall image size (although maybe with caching image size isn't an issue for our cirrus builds?),0,0,0,1,0,0 705693089,"I agree, it's not bad to keep this test, even if it passes without this change and has coverage in a golden file test. I think it's never bad to have another test. :)",0,0,0,1,0,0 721770912,"Good point and that's pretty slick but it may not help with the ""pretty complicated"" issue :-). Factoring out the resolve function makes it a little more obvious that we're just return the first MaterialStateProperty that resolves to null. So: [TRIPLE QUOTE]. That's pretty close to what you had, whichever way you find more readable is OK with me.",0,0,0,1,0,0 724610147,"Aaah I see. That is so true. What about something a bit more explicit like... 1. Execute `flutter run` code below 2. 3. This way it also nudges folks to fill out your code template below :) WDYT?",0,0,0,1,0,0 788800390,"It is the same problem, duplicate, yes steps are different but the problem is the same",0,0,0,1,0,0 874048172,"[USER] yep, it is bug, we will fix it, so we have it in `experiments` :+1:",0,0,0,1,0,0 880074565,"Yep, you are right, duplicate, let's close in favor [URL] thanks for hing",0,0,0,1,0,0 881669113,"Heya, sorry it took me a while to respond. I think I understand what you mean in your last comment about parameter normalization and I agree that it's a different issue, so no need to worry about that in this PR. I think I agree with your analysis that numeric parameters should not cause normalization failures due to a hidden conversion to strings.",0,0,0,1,0,0 881791172,"Agreed - if this is needed in a particular application, custom structural directives are a better solution. Attempting to solve this problem generally would be a major undertaking.",0,0,0,1,0,0 902790283,Very good point.,0,0,0,1,0,0 902995065,"I agree that I rarely need this feature, however when I use any of the 'tsconfig' packages, e.g. [URL] I often want to use both that and some base config that has my common rules in. Currently, the only way to use tsconfig packages is to maintain parity -- which is, to some extent just fine.",0,0,0,1,0,0 910832606,"Looks good to me. Please move forward with the PRs to get your examples implemented. Thank you",0,0,0,1,0,0 926892894,"[BLOCK QUOTE]. I share your feeling that duplication of tokens should be reported as an error (see [URL] πŸ˜„), but strictly speaking that would be a breaking change and separate from this fix.",0,0,0,1,0,0 932418639,[USER] & my approval should be enough for this.,0,0,0,1,0,0 932482827,"Good call, I assumed it would be an open-and-shut normative PR but it looks like it hasn't been updated for a while; let's hold off until [URL] is actually merged.",0,0,0,1,0,0 938967285,"Merge assistance: it looks like NgBot is confused: the necessary approvals were provided, so it's safe to proceed with the merge.",0,0,0,1,0,0 940421867,"Yeah what you're saying makes total sense, sorry I think I've just had tunnel vision on the lines section as that seemed the cleanest and more efficient place where to put this. With the regexes done beforehand we will parse each file one extra time, which thinking of that, it's not even that bad as this is just done at build time so it's not like it needs to be ultra performant or anything (also regexes are should be quite optimized right?) Anyways I would really not mind having a crack at this :slightly_smiling_face: , but you'd do a better and faster job with you mad regex skills :heart_eyes:, so I can do it or if you'd enjoy this task I am also totally fine with you handling it :slightly_smiling_face::+1:",0,0,0,1,0,0 951499389,"Ahh yes ok, that makes sense.",0,0,0,1,0,0 952016891,"You are right its a duplicate, even tho the issue is not very well described",0,0,0,1,0,0 952413616,[USER] says verbally that he's ok with it too.,0,0,0,1,0,0 953862319,[USER] Sounds good. The crash is very random but always happen on the closing of the app. I'll work on a minimal sample app to see if it can be reproduced easily.,0,0,0,1,0,0 954948987,"Yeah, that's a good suggestion.",0,0,0,1,0,0 956013136,"[USER] This is the correct place to report this issue. Can you provide `flutter doctor -v` and any evidence of plugin unable to release the memory.",0,0,0,1,0,0 796915785,"Makes sense. I agree, we should all be pulling the ecosystem toward clear standards and not a mishmash like auto mode. Thanks.",0,0,0,1,0,0 645957280,"[BLOCK QUOTE]. Excellent point ! πŸ‘ Let's go ahead without support of `undefined`, and I'll deal with it in my own code with one of the workarounds mentioned earlier.",0,0,0,1,0,0 669937414,yeah agreed! I'm on it :slightly_smiling_face:,0,0,0,1,0,0 656831098,"These kinds of types should be forbidden 😠 My brain hurts 🀯 πŸ˜›",0,0,0,1,0,0 947904739,"[BLOCK QUOTE]. Some PR has to be the first one to use it 😁 It's a bit ugly, as with all FFI, but it didn't seem terrible.",0,0,0,1,0,0 122603437,"yeah, I wasn't sure if this approach is ok and if I wanted to shadow as little as possible from the initial set (: happy to add some logic there",0,0,0,1,0,0 90701231,oops πŸ˜… I haven't implemented the tests yet so I hadn't audited yet.,0,0,0,1,0,0 94291425,wrapping these lines into block will make linter happy :),0,0,0,1,0,0 94530840,"Yeah that looks great, I think that is a good approach.",0,0,0,1,0,0 95046608,Heh didn't even notice this in the src before that's awesome.,0,0,0,1,0,0 150086821,If this is just github displaying tabs `\t` weirdly forget what I said then πŸ˜›,0,0,0,1,0,0 163396586,"Touche. Haha well we should just update them all in one PR, not this one though. πŸ˜‚",0,0,0,1,0,0 166578897,"Guys I just hadn't the time to finalize the local stuff I'm working on for the `postcss-icss-*` side of affairs, this stuff (dependencies) will be moved soon from the PR :D πŸ˜›. Happy with every `postcss-value-parser` that is capable of parsing `@import/url()` for the initial `CSSParser` in it's default state. `css-modules` will still be an opt-in either via `postcss-loader` or something like [TRIPLE QUOTE].",0,0,0,1,0,0 177721513,It's merged. :tada:,0,0,0,1,0,0 185240719,Lmaooooo nanifest seems cooler though πŸ˜‚,0,0,0,1,0,0 186009736,This is wrong for `index === 0`,0,0,0,1,0,0 220100243,Is this the correct way? I don't think so... πŸ˜›,0,0,0,1,0,0 379757627,Good catch :clap:,0,0,0,1,0,0 523003305,"I'm not sure how to fix this, nor if this is acceptable in this test case. Namespaces in TS are magic to me πŸ˜…",0,0,0,1,0,0 523003698,"Oh, so you are one of those... Added a new test to cover for this πŸ˜‰",0,0,0,1,0,0 571242698,[USER] Thanks for the feedback. Renamed `generateReturn` to `generateReturnInDocTemplate`.,0,0,0,1,0,0 571687515,"Yeah, that was actually wrong, not sure how it worked πŸ˜…",0,0,0,1,0,0 582164148,"I agree that line looks weird, and I was hoping we could remove it too πŸ˜† I still don’t understand that filter, so I’ll have to take a closer look at what it means. Thanks for pointing out the failure in nodeServer.ts. That will be useful to look at.",0,0,0,1,0,0 606605808,"Thanks, makes sense",0,0,0,1,0,0 614195174,"Nothing is doing the upgrading. They are just left alone πŸ˜„ Perhaps one could say: [BLOCK QUOTE].",0,0,0,1,0,0 638325040,"After some benchmarking([URL]) the simplest thing to do was use our `isWhiteSpaceLike` function that we already export from the scanner - the simple branching is apparently faster than either the regex or a native Set. That's probably a good thing, given how much it's used inside the scanner. 🐱",0,0,0,1,0,0 638749612,done. we should start linting this! πŸ˜„,0,0,0,1,0,0 643994320,I see. good point. We should be okay keeping as is; but should rename the function to not suggest it's similar to the async `withDebugOutput` helper. We don't deal with any debug output here; rather it's a simple `spawnSync` wrapper with our Windows compatibility settings (e.g. `shell`).,0,0,0,1,0,0 645073135,Oh goodness! My brain must've still been on vacation. πŸ˜‹ Thanks!,0,0,0,1,0,0 655635656,"Optional nit: It's a bit tricky because this assumes that the properties (`users` or `teams`) are not defined if it would be empty. Seems like this is something YAML does, but that is not necessarily known here πŸ˜„ For more clarity and a more obvious check here, we could always set `users` and `teams` to an empty array if it's not defined.",0,0,0,1,0,0 656711547,"Friendly ping. needs some suggestions hereπŸ˜‚. [USER] for push, I see you are recently online)",0,0,0,1,0,0 664947251,"Uhh... Yeah, it's probably fine - there's an `any` due to truncation in the removed type text, so all we did was truncate more, which is generally fine.",0,0,0,1,0,0 671736550,"yeah all good points, I totally agree with the comment regarding the `;` about the multiline thing I am not sure but yeah I think you're probably right on those too, I'll need to check thanks a lot!!! :slightly_smiling_face:",0,0,0,1,0,0 672894662,Definitely! You can always safely mark things as resolved when using my regexes πŸ˜›,0,0,0,1,0,0 687172118,It may not be πŸ˜…,0,0,0,1,0,0 695272975,Oh I see. 😝 Reference this above for when folks are in the api docs on individual pages.,0,0,0,1,0,0 695293645,"Oh nice, I didn't realize this showed up anywhere!",0,0,0,1,0,0 696826933,"Good call, I was able to get rid of it. The previousCharacter thing seems to have been used to work around these wordwrap problems mainly when getLineBoundary didn't respect TextAffinity.",0,0,0,1,0,0 702098157,"TBH, I don't think there is much benefit in moving shell commands to external files :grin: πŸ™Š πŸ˜‡ We do not lint, test or otherwise validate them (afaict) and it just makes it harder for authors to edit them (and ensure they remain relevant with the surrounding text). As much as I prefer having code-snippets be derived from docregions, it might make sense to make an exception for some content types, such as shell commands.",0,0,0,1,0,0 704831786,"Yes, aspect is so much better. I have updated the code.",0,0,0,1,0,0 711259165,"Ah thanks! Yes, the goldens are expected. I added an image that would otherwise be overflowing onto the following child. :)",0,0,0,1,0,0 714038314,"You are 100% on the money with this. Turns out the parsing was incorrect, and so is the parsing in v8 (about to raise a ticket). I'm changing things to the way you said and it works much better.",0,0,0,1,0,0 719889205,I don't know where is this source comes from πŸ˜‚,0,0,0,1,0,0 727413212,"Yeah, I just chuckle because when this test was first added it had this error, then it got removed by another change, then it got added back, and now it's being removed again. This test is surprisingly good at capturing how strict we are about comparing infinite types, even if that's not what it was meant to test (it was meant to test a crash).",0,0,0,1,0,0 729442182,This seems like an acceptable protocol change. πŸ˜†,0,0,0,1,0,0 730137163,"awesome thanks :slightly_smiling_face: just a couple of questions :slightly_smiling_face: do we need the groups to be non-capturing? :thinking: and, I can see a small slight issue with the regex, as you can see here for example: [URL] we take the spaces after the eslint comment, but is that really correct? in this case, we will get `text` indented only 5 spaces and not 10 do you think this is ok? (I know that in theory the eslint comment should have the same indentation as the next line but who knows, you can find someone else as bad as me at indenting stuff :laughing: :man_shrugging: )",0,0,0,1,0,0 742384352,This looks great!,0,0,0,1,0,0 783542251,Thanks [USER] for pointing out these functions. I'm also +1 on using the builtin functions rather than rolling our own incomplete checks.,0,0,0,1,0,0 785050492,"[BLOCK QUOTE]. No worries if you don't have bandwidth [USER] I can send a PR for exporting these types.",0,0,0,1,0,0 796731497,"[USER] I see you liked the comment - if you want to review, that's also welcome πŸ˜€ This is literally our only blocker left...",0,0,0,1,0,0 797460963,"Also, I am thing I can officially call this issue resolved with Webpack 5 πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰",0,0,0,1,0,0 799351710,"[BLOCK QUOTE]. topLevelAwait cause this problem,we had improved our code.πŸ˜ƒ",0,0,0,1,0,0 875608145,"[BLOCK QUOTE]. Guilty as charged πŸ˜‡ (To my defense, I thought I was doing you a favor πŸ˜›) Thx for still taking a look :grin:",0,0,0,1,0,0 881638125,You guys are on top of it. Cheers 🍻,0,0,0,1,0,0 882682739,You're welcome!,0,0,0,1,0,0 884877653,"good to know, thanks! I will update the configuration",0,0,0,1,0,0 898017970,[USER] thank you πŸ™ I hope you will like it πŸ˜„,0,0,0,1,0,0 912806448,"Ah thanks! Sorry, it thought that `""lib"": [""dom""]` would include all other `dom.*` libs as well.",0,0,0,1,0,0 913202933,"As a complete surprise, this just started working. [TRIPLE QUOTE]. Digging deeper, the new index signature features are in the [4.4 release notes]([URL]",0,0,0,1,0,0 913692354,It wasn't when I posted this issue :slightly_smiling_face:,0,0,0,1,0,0 914557671,"thanks, [USER] for clarification. I was just a little bit worried by this [BLOCK QUOTE]. and by the plans of using esbuild (because esbuild doesn't check types). But if it will be totally configurable - it’s amazing.",0,0,0,1,0,0 917619220,Glad you got to the bottom of this,0,0,0,1,0,0 919009505,"thx [USER] I switched to [uvu]([URL]) and everything is working nice!",0,0,0,1,0,0 921236280,"[BLOCK QUOTE]. yeah it works perfectly!!! :smile: .... so the look-ahead is ok, but the look-behind is not? I had not idea :open_mouth:",0,0,0,1,0,0 922332071,"Excellent work on this PR and mjs/cjs support, Wes. (We have been discussing full ES specifier support in #42151.)",0,0,0,1,0,0 922713721,Friendly ping.,0,0,0,1,0,0 925433950,"Sorry [USER] that's what the notes were *meant* to reflect, but the convo was happening a bit too fast. I think the analogy was fine. Usually the idiom ""it's not rocket science"" implies ""this is simple, so nobody should get overwhelmed by it"" whereas this is something we *don't* think is simple, and thus can make no guarantees about whether anyone will be overwhelmed by it πŸ˜…",0,0,0,1,0,0 934325654,"[BLOCK QUOTE]. Sigh 😞 There used to be a time when my word was enough πŸ˜› Added a test πŸ˜ƒ",0,0,0,1,0,0 939870826,[USER] [USER] Thnx for the quick response. The suggested workaround is similar to our own workaround so thnx for that! Wanted to share the change in behavior ;),0,0,0,1,0,0 940648238,"Hello! Please let me know which milestone will this land to, when you know. Thank you. πŸ˜€",0,0,0,1,0,0 942246719,"[USER] with the help of [USER] I found a workaround. See [URL]",0,0,0,1,0,0 942642232,"No, but I think there might be a previous issue for that too πŸ˜†",0,0,0,1,0,0 948916151,"This is great, news. Added the new version to the allow list!",0,0,0,1,0,0 949803809,"[USER] Thanks for the reply. This response will swerve into off topic for this thread, but, of course I'd be happy to submit PRs.. My most pressing issue would be: [URL] Happy to discuss elsewhere.",0,0,0,1,0,0 955085840,"I think we should get opinions from people that do use snippets, I feel totally unequipped to give an opinion on this because I pretty much just never use snippets and I *click* things heh πŸ˜…",0,0,0,1,0,0 956099297,Hi [USER] thank you for filing this issue. Please check out this document [URL] which explains the breaking changes and how the flutter team handles migration.,0,0,0,1,0,0 956562099,"I'm happy to see continued enthusiasm for solving this problem. Keep the upvotes and (especially) constructive suggestions and PRs coming! Like many hard things, eventually I'm sure we'll help to get a solution built for this annoying gap in the TS developer experience. [BLOCK QUOTE]. As far as I can tell, this impression is not correct. Almost all* packages that are written in TS, transpiled to JS, and published to npm don't work with ""Go To Implementation"" any more than packages originally written in JS. I said ""almost all"" above because there is a way to make it work: using the [declarationMap]([URL] tsconfig compiler option. But: 1. This setting is not enabled by default. IMHO it should be enabled by default whenever `sourceMap` is enabled. (Maybe also when `inlineSourceMap` is enabled?) 2. There is AFAICT no evangelism from the TS team (or anyone else!) about how package authors should enable this setting and include declaration map files when publishing their packages to npm. 3. There's also no push to get declaration map files into existing DefinitelyTyped packages. Could this be automated instead of relying on 1000s of type-package maintainers to do it? Anyone who wants to see this problem get better could: 1. **Send a PR to try to change the default of `declarationMap` to be `true` if the `sourceMap` or `inlineSourceMap` option is `true`**. This minor change would probably have the biggest impact on this problem over time. 2. **Send a PR to update the TS docs to be more vehement that `declarationMap` should be enabled for all library packages**, and explaining why (""_because ""Go To Implementation"" in VS Code relies on declaration map files_""). These documentation changes will be crucial if (1) is not approved. 3. **Send a PR that adds or extends the TS docs with specific guidance for package authors**, including ""publish your sourcemaps"" and ""publish declaration maps"". 4. **Write a tool that will automatically add declaration map files to all compatible DefinitelyTyped packages**, and convince the DefinitelyTyped maintainers to merge the output of that tool into every compatible DefinitelyTyped package. Part of the work would be figuring out what ""compatible"" means and what packages' declaration maps can't be automated. Note that [USER] above was pessimistic that this automation would be possible. But I wonder if things have improved since then to make automation possible? Or if it'd be possible for a large subset of packages? Here's what he said: [BLOCK QUOTE]. 5. **Send a PR to change the build actions for DefinitelyTyped to warn users if they try to add a new package that lacks a declaration map**. Not sure if this is something that can be done outside the DT maintainer team, depending on how the existing DT toolchain works. Someone who knows DT better than me could answer this. The community has agency! If we want things to get better, any of the items above can make things better. There's also IMHO another confusion with ""Go to Definition"" vs. ""Go To Type Definition"" are implemented. My preference would be for ""Go to Type Definition"" to navigate to the types and ""Go to Definition"" to navigate to the implementation. Not sure this is worth changing community expectations, though, given how long the current behavior has been in place. For more details, see: [URL]",0,0,0,1,0,0 957148739,[USER] Lucky one! I guess one of the problematic package was updated. Have a nice day! 😊,0,0,0,1,0,0 961241626,"[BLOCK QUOTE]. Indeed πŸ˜ƒ [BLOCK QUOTE]. Yeah that's exactly why this suggestion is possible. But your example is a nested one, meaning that it might try destructuring undefined into `{ a, b }`, which should be prevented.",0,0,0,1,0,0 961394578,Thanks for the info [USER] glad to know that the drop for it appearing is soon.,0,0,0,1,0,0 736898221,ahhhh yeah :thinking: :slightly_smiling_face::+1:,0,0,0,1,0,0 619287712,That's how [USER] formatted it. :),0,0,0,1,0,0 850845815,"[USER] oh, perfect. Which version was it added to?",0,0,0,1,0,0 688053781,"I actually had already moved this to TextEditingActionTarget as a private instance method that uses TextMetrics.getWordPosition, but I had forgotten to delete this static method here. Thanks for catching this. Let me know if you like it on TextEditingActionTarget or if you think it would be better on TextMetrics. Regarding RTL, you're right, I think we have a lot of missing support for this. I've created an issue ([URL]) and I'll add TODOs for it here.",0,0,0,1,0,0 955385844,"I think this is a good change. It is true that these properties can be undefined - in fact they are even set to undefined explicitly. So the typings are not correct as they stand. I agree that this would break compilations in many projects. That being said, it is actually a real problem and the errors will be easy to fix. We could probably write a migration that marked these properties with `!` or `?` but I worry this could then hide the problem. I would like to see the results of a presubmit.",0,0,0,1,0,0 120718903,"Yea, my first attempt was to use a set for `r.chunks`, and then convert it back at the end of the function w/ `Array.from` this was only marginally faster than the original code though. IIRC the `Array.from` calls were taking ~12 seconds. I can create another profile showing that if you want.",0,0,0,1,0,0 262272600,Prettier changed the indentation here to be sort of weird imo. I'm happy to change the style of the code here that generates the System.register string -- open to suggestions.,0,0,0,1,0,0 350895784,"If there's a way to do that, now or in the next months, I'm all for it πŸ‘ My anxiety is mostly that as you mentioned, there have been similar requests for a long time. Plugin systems are notoriously hard to get right, and you understandably want to be sure it won't bite you in the future. That's fine - but meanwhile, we're still left in a state where we have to rely on very creative solutions (a virtual filesystem!) where a simple integration would appear to work fine - within the constraint of our runtime, admittedly. Anyway, I understand what you're saying and your roof, your rules. I'll be eagerly waiting for progress on #16607 then πŸ™‚",0,0,0,1,0,0 367998001,I think both behaviors make sense for different use cases.,0,0,0,1,0,0 407979876,"Yes, it's very trick to detect the stop timing under current solution. I will take the idea mentioned above and add tests. 😊",0,0,0,1,0,0 429102122,"Oh yeah, that sounds much better than deleting it. I just updated my code to deprecate it instead.",0,0,0,1,0,0 465686582,"Could do. I considered it but thought the tests that are already quite loopy would get harder to follow what's going on. Happy to update if you prefer.",0,0,0,1,0,0 497734327,"After our discussion, I think it's OK to leave this; there aren't any equivalent helpers already, and it's used in quite a few places throughout the checker already. It might be worth a cleanup pass later, to holistically find a replacement, but that would be a lot of work.",0,0,0,1,0,0 504865825,"Indeed I missed that, but not sure how it didn't affect the generated code... In any case -- fixed.",0,0,0,1,0,0 546152955,"Sounds good to me. Dev containers definitely make things easy once you have VS Code and docker setup, and with Codespaces you can just connect and the container will automatically be setup for you",0,0,0,1,0,0 560580809,I looked deeper into it and now should be fixed. All scenarios on the test are passing as expected.,0,0,0,1,0,0 612068880,That makes it easier for me 🀠,0,0,0,1,0,0 628253160,"And indeed it did fail, so that is good: [URL]",0,0,0,1,0,0 629542983,"Yeah, that would also work for me πŸ‘",0,0,0,1,0,0 633892971,"I agree, I personally don't love having it, but felt it would be easier to perform the angular-cli migration to using the release tool. I suppose I should probably just put in the effort to create the changelog for CLI ahead of time.",0,0,0,1,0,0 635656005,I think we can just leave it there because we will no longer create new tags with the `v` but we can support discovering the previous tags indefinitely.,0,0,0,1,0,0 642112555,Thank you for letting me know! I have fixed this now.,0,0,0,1,0,0 646725531,"[USER] Thanks, I've rebased the PR and pushed, looks green.",0,0,0,1,0,0 653735100,"[TRIPLE QUOTE]. I would probably just throw that into the `string` case and seed it with an empty string. No need to try to come up with a placeholder that actually fits the template πŸ˜„",0,0,0,1,0,0 693160039,"I wasn't sure, but this does work. Added a test.",0,0,0,1,0,0 694222620,Glad we're able to remove this now!,0,0,0,1,0,0 700594086,"as I said I am not completely sure about it, but yes it doesn't sound terrible, and if you say it's better that way then I will just go for it then :slightly_smiling_face::+1:",0,0,0,1,0,0 716013640,"It shouldn't matter, because we pin to specific version via the lockfile anyway, so either way is fine.",0,0,0,1,0,0 721316882,Got it !,0,0,0,1,0,0 743211174,"Pretty much anything other than ToolExit will show up in crash logging. You could throw a bare `Exception`, as we do elsewhere in this file, I'm not picky :)",0,0,0,1,0,0 824998066,":star: Feel free to feedback, you can always ask questions here [URL]",0,0,0,1,0,0 870881627,"I'm having some success simply applying both plugins. Not sure of any unintended side-effects yet: [TRIPLE QUOTE].",0,0,0,1,0,0 893548823,"[USER] Sounds reasonable, thanks. However could you please provide the link to the issue you mentioned?",0,0,0,1,0,0 899511728,"Basically looks good. @sandersn Would you mind tell us how could we use baseline to test the inlay hints？It's painful for now.",0,0,0,1,0,0 903220818,"[BLOCK QUOTE]. @sandersn Maybe I don't have too much time to investigate it deeply, it's ok to close the PR.",0,0,0,1,0,0 919794646,No worries! It looks great now πŸš€,0,0,0,1,0,0 923715301,The above approvals should be enough since this is a lock file change.,0,0,0,1,0,0 926852403,"OK, cool, thatβ€˜s kind of what I meant by β€œsquatting” on a standard lib name, but reframed like this, perhaps that’s actually an intended rather than hacky use β€” you’re overriding/augmenting an existing lib, so that does fall into the #45771 use case. The fact this requires two configuration points across separate files that need to be kept in sync does still introduce more friction than I’d like, and the fact that tsconfig doesn’t clearly show the actual lib in use _may_ be a source of confusion, but you can’t have everything in life πŸ˜ƒ. Thanks for taking the time to consider this anyway!",0,0,0,1,0,0 936532808,"This is an inconsistency in our iterator checking; with no contextual type, the hard-coded TNext default is `unknown`; with a defective, `next`-free contextual type, the hard-coded default is `any` instead. We should maybe consider fixing this, but only if it doesn't break anybody, or if anybody thinks the current state is bad enough. In any case, I think this change is fine to ship as-is.",0,0,0,1,0,0 944920839,"[BLOCK QUOTE]. This work for me, as a temporary solution of course : [TRIPLE QUOTE].",0,0,0,1,0,0 946413492,"[BLOCK QUOTE]. Based on this comment, I feel it is safe to close this issue as fixed. As such I will be closing it. If you still experience this issue, kindly leave a comment and I will reopen. Thank you",0,0,0,1,0,0 947807081,"That's a tough one to get behind. But if that's where we draw the line, I can respect that.",0,0,0,1,0,0 949056793,"Done for now. Generally seems pretty solid. Nice work, [USER]",0,0,0,1,0,0 949082529,"Yeah, if the real world code is fast then I’m happy. Just wanted to make sure it was checked against the latest changes.",0,0,0,1,0,0 949958480,"From the design discussion today, we think this is a fine change to make, but will result in such a small improvement that it's not worth the churn. In particular, it fixes the precise repro from #45798, but I doubt that it fixes the original code since nobody is likely to write literal numbers in a template literal slot.",0,0,0,1,0,0 952616746,I'd be happy to take a look at this as well. I have a sample Angular project that I could try to replicate the issue in. What type of files are you uploading or does it occur on all files?,0,0,0,1,0,0 954811289,[USER] The issue is fixed. Looks good.πŸ‘,0,0,0,1,0,0 960145697,"[USER] you are too kind As I said I cannot guarantee this to be the right answer, but it's what I came up by checking the behaviour and the code, and it does seem to make enough sense to me I'm very happy that you've found it useful :slightly_smiling_face:",0,0,0,1,0,0 960321886,This issue on angular.io has been resolved.,0,0,0,1,0,0 666530178,"It's always good to explicitly type arrays like this. Also, this can be `const` since we don't need to change its value.",0,0,0,1,0,0 685271530,"Ah, good point :+1: It is still unfortunate that we have the same bits of code before and inside the `while` loop. How about something like this (to avoid the code duplication): [TRIPLE QUOTE].",0,0,0,0,1,0 713475952,"To be honest, I'm very new to the team and I don't know if there's a methodical way to figure those things out. I don't think there is, sadly. Some things in the code have very descriptive names or comments, but others sometimes don't, as is the case of `assumeTrue`. I'd say if you can't find an explanation by looking at the code, or in the TypeScript wiki, or in [URL] your best bet is to ask someone from the team and we'll be able to help. @sandersn and [USER] might have more tips about where/who to ask those kinds of question. About `assumeTrue`'s meaning: to give you an example, I figured this one out by looking at the code in `narrowTypeByEquality` and seeing that `assumeTrue` had its boolean value flipped if the condition we had was an inequality (e.g. `a !== b`). **tl;dr** in `narrowTypeByEquality(type, operator, value, assumeTrue)`, if `assumeTrue` is true we should assume `value` has type `type`. Otherwise, we should assume `value` does *not* have type `type`. To give you an example: [TRIPLE QUOTE].",0,0,0,0,1,0 715216708,"Unfortunately, you can't change the name and remove bringup from this PR",0,0,0,0,1,0 720577815,"What I mean to say is that this assertion that you are adding in this PR catches the error you intend to catch, but it is also catching other cases that are not valid to assert. While I cannot share internal code, it stands to reason that if the internal code were invalid, it would crash with the same bad error message you are trying to fix here. I am going to close this PR as the internal test proves that it asserts when it should not. Unfortunately, I do not have a simple reproduction of this case. I appreciate your work on this, it just does not work in the way that you expect.",0,0,0,0,1,0 824976425,"same result unfortunately [TRIPLE QUOTE].",0,0,0,0,1,0 887502766,[USER] ci still broken(,0,0,0,0,1,0 897875936,"[USER] unfortunately as [USER] mentioned without a reproduction, even shared privately it will not be possible to get to the bottom of this.",0,0,0,0,1,0 899418860,"Thank you! Yes, it was a problem due to the `webpack-stream` plugin which depends on version 4 of the webpack. Unfortunately, this plugin does not support version 5 and now it is supported only in the [pull request]([URL] We are waiting for the merge))))",0,0,0,0,1,0 917098487,"Oh, there are different failures now 😞 I'll have to take another look πŸ˜…",0,0,0,0,1,0 917503891,"Sorry it took long to reply! Unfortunately, that is not going to work in my setup: I am dynamically importing Preact during the runtime, that is `getPreact()` returns Preact's exports. `jsxImportSource` implies automatic import, which is not going to work. I can, of course, use it to silence TypeScript and continue using ESBuild, which will actually use `h` defined in the scope, but then TypeScript starts to complain about β€˜unused’ `h` declaration, while also not saying anything if I don't declare the `h` (duh). I'd actually expect TypeScript to *not expect* that `h` can only come from the imports, but rather do what ESBuild does β€” use `h` defined within the scope; like in my situation β€” it is defined at the top of the file. Thus I filed it as a bug report, because it's an absolutely valid use case. Also, I just noticed that I accidentally deleted CodeSandbox example, I re-wrote it here (will update in the issue body): [URL]",0,0,0,0,1,0 925392557,Unfortunately the fix wasn't quite right and we decided to revert it and investigate more for next releaseβ€”see #46009 and #46012,0,0,0,0,1,0 933258523,"Also somewhat related: #41470. --- I find the idea of ""local"" types declared within the implementation body to leak outside extremely unpleasant and disturbing. This would also require additional new syntax for declaration files, which was not considered at all in this issue. I hardly see any benefit and a lot of complexity. And unfortunately the issue template for feature requests was not filled out.",0,0,0,0,1,0 944607416,"Unfortunately there's disadvantages to this approach too -- Android/iOS tools no longer work because files appear to be missing, for example. Understanding what Android/iOS want from you is harder because the files aren't there so you can't just explore the files and find the comments we left explaining things. You could imagine a mode where you ask the files to appear, then edit them, then ask the unchanged files to be removed, but now there's extra steps, none of which are obvious to the developer, and it's easy to accidentally add or delete the wrong file (or make trivial changes that you don't need to save), etc. I do wish something like this would exist, though. cc [USER] [USER] [USER]",0,0,0,0,1,0 947000738,"[BLOCK QUOTE]. This is very disappointing - this will require us to introduce a build step in our monorepo development environment",0,0,0,0,1,0 957179425,"Flutter has not provided us a way to change it, so the document is impossible for now.",0,0,0,0,1,0 729462534,"[BLOCK QUOTE]. Is there an API that Flutter supports that allows to do that? I don't think the current embedding/engine APIs allows to pass custom parameters. [BLOCK QUOTE]. That doesn't work unfortunately. The Dart plugin registrant isn't called. It might just be that the engine cannot find the dart plugin registrant because it isn't in the same file that defined the main entrypoint.",0,0,0,0,1,0 607233139,"Just a PR -- I'll mark it with the Housekeeping label. (The bot doesn't know about Housekeeping iirc, so it will still probably comment, unfortunately.)",0,0,0,0,1,0 645799029,"That is an unfortunate how onSelectionHandleTapped behave differently based on the implementation of TextSelectionControls. I am ok with this approach if we can deprecate the onSelectionHandleTapped at some point....",0,0,0,0,1,0 665335063,mh.... yeah sorry about that :disappointed:,0,0,0,0,1,0 685491920,"yeah, sorry my bad :disappointed:",0,0,0,0,1,0 711649080,"I don't have access to ""real"" Safari, but by playing in an emulator another option that I think would work (and avoid repetition) would be to use a `` element and a CSS scale transform: [TRIPLE QUOTE]. ## Either way is not great, so leaving it up to you πŸ˜‡",0,0,0,0,1,0 851132132,I don't quite understand why CI failed. Could you please give me some help,0,0,0,0,1,0 856050690,"Sorry we can't fix it in webpack or webpack-dev-server, anyway feel free to feedback",0,0,0,0,1,0 899814627,"Hi [USER], thanks for working on the changes in this PR! I had a quick chat about this with [USER], and the problem with this fix is that changing DOM value happens asynchronously and that can lead to subtle issues as described in [this comment]([URL]) We think the best approach would be to update the DOM value once the rendering is complete. Currently there is no lifecycle hook that for that, and we'd need a project proposal to add one. If there is a decision to add such lifecycle hook, the fix in this PR can leverage that and we should be able to land the change. This is certainly a disappointing outcome, since this is a major performance issue and you put in a lot of effort on this. Sorry that it turned out to be blocked on a major addition like this :/",0,0,0,0,1,0 903122738,"But you can use `--profile` and avoid output stats, I don't understand what is the problem with `--stats verbose`",0,0,0,0,1,0 916475242,Closing. This isn't feasible at this time.,0,0,0,0,1,0 922159377,It happens to me too. :disappointed:,0,0,0,0,1,0 942688270,I closed it because it's gotten 3 upvotes over the past 3 years,0,0,0,0,1,0 946029784,[USER] [USER] I am not sure how to fix this since I cannot reproduce locally. Do either of you have ideas for a fix?,0,0,0,0,1,0 948692661,"Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away! Thanks for your contribution. Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of `flutter doctor -v`. All system setups can be slightly different, so it's always better to open new issues and reference related issues.",0,0,0,0,1,0 953541913,"I don't think there's a way to distinguish what buttons are pushed when the mouse is clicked, unfortunately. We should add an onStartDetails handler (or probably just change the argument to onStart, if we can find a good way to `dart fix` it, but that might not be easy) that gives you that information. Currently you only get that information on the first move update after the click.",0,0,0,0,1,0 955279639,"[BLOCK QUOTE]. I tried this, sadly it doesn't work for me.",0,0,0,0,1,0 957183512,"[USER] I’m unable to reproduce the issue to pinpoint the cause, it could be the third party’s integration with the framework. I'll be labelling it for further investigation.",0,0,0,0,1,0 958255605,Closing this since it's seen no updates for 2 years and is out of date. We can re-open and land if the change is still valid.,0,0,0,0,1,0 959791063,"Hello, I have tried both suggestions but unfortunately none of them worked. The first option did not change anything; for the second options, I could not see these files anywhere.",0,0,0,0,1,0 184589259,I generally don't like using `Function` but it seems appropriate in this case πŸ˜”,0,0,0,0,1,0 613542715,ahh well it still is going to build all the time i guess... it was never tested scenario.. so ....,0,0,0,0,1,0 912968761,"When you create reproducible test repo please avoid using private package, unfortunately nobody can test it: [TRIPLE QUOTE].",0,0,0,0,1,0 924140805,"[BLOCK QUOTE]. Just comment on the closed bug. We don’t unsubscribe from closed issues, and if there is a reason to reopen them or reengage with them, we doβ€”as is happening here. [BLOCK QUOTE]. I think you’re forgetting that you have ways of making plausibly correct subtypes of objects in JavaScript. It’s true that if you wind up with primitives you’re kind of stuck. [URL] You can also do some arguably correct things with user-defined type guards, which are not checked for accuracy, but are not wrong and are less suspicious than casting to `any`. If you have some pattern of runtime reflection that TypeScript can’t analyze, but you’ve convinced yourself of its safety and its utility, I don’t think I’d call that β€œshenanigans” anyway; I’d call it a limitation of our compiler. I guess we’ll have to agree to disagree about what type parameters are for. I won’t be monitoring this thread anymore as the discussion has been exhausted of anything useful to resolving the original issue.",1,0,0,0,0,0 708503165,I don't think this import is necessary. What was the reason for adding it?,1,0,0,0,0,0 94004246,These conditions are weird. A test should have an expected behavior and not two possible.,1,0,0,0,0,0 95499985,[USER] I thinks it's better to leave it as is (i.e. string concatenation) than this for better readability,1,0,0,0,0,0 102410303,"This is unrelated to your changes. Could you rollback this, please?",1,0,0,0,0,0 152751925,should not be here,1,0,0,0,0,0 153119784,Not sure if it's a good idea to set this global variable here.,1,0,0,0,0,0 161375219,"I didn't see the point in burying this function in the class, so it's outside. I'm not sure if this matches the code styles well.",1,0,0,0,0,0 164664288,The `sourceUrlComment` is not part of the footer. It doesn't make sense to move it into this module.,1,0,0,0,0,0 170027075,"returning a value doesn't make sense here. It's an async function. Maybe you want to wrap this in a Promise:",1,0,0,0,0,0 171155778,Not sure I agree with this particular change. It breaks the grammar of the sentence.,1,0,0,0,0,0 178605387,"This is not correct. A Chunk doesn't have this probably. You probably found this in the HMR code. The template takes a `Chunk | { id, modules, removedModules }`. This is a kind of fake Chunk with this extra info.",1,0,0,0,0,0 178605793,"This is incorrect. Actually the usage of `this.chunks` below is incorrect. It should be `compilation.chunks` instead. This happend probably while the migration from function to arrow function. Better do a separate PR here, as we should also add tests for this.",1,0,0,0,0,0 186031083,"This is wrong. If options is `undefined`, then `bail` is not a `boolean`",1,0,0,0,0,0 186620605,This is wrong,1,0,0,0,0,0 189286545,Remove this whole file. It's a bad test because it test the internal behavior.,1,0,0,0,0,0 198086388,"Not sure if the above changes are needed since we already do that in `WebpackOptionsDefaulter`. /cc [USER]",1,0,0,0,0,0 225843589,You should not repeat fields which are serialized in the base class.,1,0,0,0,0,0 248169866,That's an assumption this piece of code should not make.,1,0,0,0,0,0 303461904,"Makes sense, but in this case I don't even need DateTimeFormat and can save the initialization cost...",1,0,0,0,0,0 305635514,I see no reason why this can't be inlined into `getPolicy`,1,0,0,0,0,0 322592566,"But we even bothering with a Promise, the original code should work fine here and is simpler.",1,0,0,0,0,0 351888259,I think here mistake,1,0,0,0,0,0 407966535,"That's not something you can use here. signals is something for the CLI not for a plugin.",1,0,0,0,0,0 467174466,"It's legal, but not correct. The car would have the ModuleDependency, but at runtime it could also have other types. That's why it's wrong. You must only use casts when the type is restricted at runtime but typescript doesn't know about that. Here the cast is useful to tell typescript that you are sure that this is the type here.",1,0,0,0,0,0 512943729,I am not sure. but i am certain that extendedSourceFiles should contain source file name that wasnt present. It would need another file exists check or another field just to return information if file is present or not and that seems unnecessary just to let project structure information. Let me know if you think its necessary. If it is we would probably need another field on tsconfig source files,1,0,0,0,0,0 544653738,"Not exactly; it asserts that the exported symbol was in fact found to be exported by its module symbol, according to either the main program checker or the AutoImportProvider checker. This is basically redoing work during the completions _details_ request that was done during the previous completions _list_ request, so it should always be found, but of course there’s no guarantee of that in the types, hence the assertion. (It’s also the sort of assumption that could plausibly be violated by a bizarre sequence of edits triggering some race condition, or just wrong code, so we do see assertions like this come up in telemetry every once in a while.)",1,0,0,0,0,0 594591557,"You should not do it, it is wrong",1,0,0,0,0,0 637396180,"Is this actually relevant to this bug? It seems to me that this PR has two parts: 1) Fixing the bug which is when there is only one task, and that task has a error, we were not throwing the error. 2) Speeding up the case where there are multiple tasks but only one of them has an error. Is the second part actually necessary? I think the code could be smaller without this performance change.",1,0,0,0,0,0 643506552,"This doesn't work in the presence of whitespace. [TRIPLE QUOTE]. I would change your search string to `meta` instead.",1,0,0,0,0,0 644290236,I don't think .call is necessary here,1,0,0,0,0,0 647633096,"isnt this incorrect, you would want to return the watcher.close function that does what it is doing below instead of returning the actual watcher created by nodeModules watcher?",1,0,0,0,0,0 647642414,"I thought about this, but it didn't make sense to me that an entry would be both updated and deleted during the lifetime of the cache (which I think corresponds to a file change event). If that *is* possible, then I'll update the code to keep the two collections in sync.",1,0,0,0,0,0 657385922,"Same thing here, do we really need to use a todo if this is not meant for us?",1,0,0,0,0,0 665724193,I'm not sure that adding to tslint at this stage in its life is a good use of our time.,1,0,0,0,0,0 668371289,"I'm not planning to start supporting events in this PR - the whole point is just to baseline the output of the event, and I'll admit that I don't necessarily know what it would mean to support events.",1,0,0,0,0,0 680512074,"Why this change? ""Native"" sounds more appropriate/accurate than ""built-in"" here :confused:",1,0,0,0,0,0 692424334,Is this logic really needed? If we unroll the loop one more iteration we'll naturally hit the `ts.isArrowFunction` case above.,1,0,0,0,0,0 692538172,"these comments seem superfluous to me -- the intersection one might need a comment if it were on its own, but here it's clearly the inverse of the union case, and the union case is clear as-is",1,0,0,0,0,0 702517538,"hi [USER] thanks for catching mistake. Regarding your comment `we can probably have min/max and a value in tests as float numbers and come up with a case when parseInt would cause an issue` So I doubt this can be valid scenario because if min is `1.0` and max is `3.0` and user enters just `2` then still it will be correct to user always enter decimal value developers should add pattern or regex. Please feel free tp correct me If am wrong in above scenario or in case you have other thought in your mind.",1,0,0,0,0,0 703903526,"The wording here is inconsistent with other similar messages, such as: [URL] [URL] [URL] [URL] [URL] Not that we're terribly consistent, but ""cannot be specified"" and ""can only be used"" are the most common qualifiers we use.",1,0,0,0,0,0 705799769,Is this needed? These tests are testing the factory constructor right?,1,0,0,0,0,0 705830073,"Unfortunately I do not. I recall that a number of tests had to have their parameters updated to keep the ""goldens"" valid. The main intent behind this change was to fix the jitter users would experience as the scroll slowed down. I added a test for that invalid behavior, see `ClampingScrollSimulation velocity eventually reaches zero`.",1,0,0,0,0,0 707483092,"I might be missing something, but I don't see the benefit of moving certain types of code-snippets outside the Markdown. In fact, there is quite an overhead for authors (whomever that might be: the docs team, SWEs and most importantly community contributors). FWIW, our early choice to move the TypeScript and HTML code-snippets outside the Markdown was only made because we believe the benefits of being able to validate the code outweigh the cost of not having the code side-by-side with the rest of the docs content (where it would be much easier to keep in-sync). So, I strongly believe that there are certain code types (i.e. those we cannot validate) that would be better off being left in the Markdown. But, since this is related to docs authoring, I am happy to leave it up to the docs team :smiley:",1,0,0,0,0,0 715774007,Is this necessary? I think it should be left up to the scaffold body to inset its own content appropriately,1,0,0,0,0,0 715947884,"Not sure how important this functionality is, no other existing tests were broken by the change.",1,0,0,0,0,0 738814346,"Absolutely not. This situation is much different from the one above because that one doesn't make sense and has alternatives. This here has an alternative, which is passing an explicit 0, but when running .at() it would make sense for it to default to the first element in the array. This doesn't seem like another one of JS's quirks, but in fact very much intentional and should stay like this, unless a maintainer says otherwise",1,0,0,0,0,0 804762054,"[BLOCK QUOTE]. But that other issue seems to describe a different broken behaviour, not related to HMR.",1,0,0,0,0,0 866833762,You can't do it dynamically,1,0,0,0,0,0 873375987,"I don't think we are at a point where adding this syntactic sugar would improve things noticeably. The `entryComponents` are no longer a thing, so that improves the situation a bit. Also, we would need to keep the existing APIs, because there are cases where you want more configurability. As a result, we would be introducing multiple ways to achieve the same thing, which is undesirable. Based on the above (and the relatively low number of upvotes), I am going to close it. In the future, once the `@angular/elements` APIs are more refined and stabilized, we can look into ways to streamline the syntax.",1,0,0,0,0,0 877601081,"I feel that this decision is wrong in many ways. * Angular and RxJS go hand in hand from the beginning. In fact I came to know RxJS thanks to Angular. I don't think this was a bad decision. It was a nice standard way for Angular to be reactive. For me the places where it was not used, like `@Input` or lifecycle hooks, feel out of tone from the rest of Angular. * How do you plan to remove or replace Angular's dependency on RxJS without introducing a massive backward incompatibility breakup like in the AngularJS -> Angular 2+ era? Don't repeat history but learn from it! * If you manage to not create backward incompatibility issues, then why do you think that introducing input as observable will? * It _already_ is possible to merely see the usage of observable/observer as a Subscribable pattern. RxJS was meant to be functionality around this pattern. But because Observable was not an ECMA standard like Promise, Observable was included in RxJS. If I remember correctly, Ben Lesh regrets his decision not to make Observable a separate lib apart from RxJS, because now the two are seen as one while in fact they are not. I hope this decision is reverted soon and Angular will return to it's declarative reactive path instead of holding on to partly forcing users to use error prone imperative reactiveness.",1,0,0,0,0,0 881785239,"I see the problem here, but unfortunately Angular does allow recursive components, so I don't think we can automatically make this an error.",1,0,0,0,0,0 882136287,"A lot of people are also using similar argument against Angular in general, but I have an inkling that we actually disagree on what that usually foreshadows.",1,0,0,0,0,0 904507572,"Unfortunately no, you webpack v5 required...",1,0,0,0,0,0 919082522,I disagree. A framework is exactly that: Decreasing the complexity and amount of written code and avoiding duplicate boilerplate code.,1,0,0,0,0,0 919132145,"[BLOCK QUOTE]. An optional spread argument makes no sense and is invalid. But `fn(...args: any[])` actually is callable without arguments. [URL]",1,0,0,0,0,0 920707569,"You really want a default behavior like this? [TRIPLE QUOTE]. Result: [TRIPLE QUOTE]. I doubt anyone will miss that. I think people are more likely to get upset that it won't finally be changed. It's not only related to a `Map`. I would really just remove this sort. Keep it simple.",1,0,0,0,0,0 920773565,"[BLOCK QUOTE]. I can still see the unused functions used in the production mode also",1,0,0,0,0,0 923881959,"That is an interesting idea [USER] I think the wording should not mention redirects, since that is not what is happening. Perhaps ""leaves angular.io domain"" or ""external URL"" might be accurate.",1,0,0,0,0,0 932994975,"[BLOCK QUOTE]. But it's not, as it has been mentioned several times already...",1,0,0,0,0,0 936098797,"I don't see any problems with cast, it is not related",1,0,0,0,0,0 938692115,BTW I don't understand why this issue was closed. Is there any sensible reasons why `Array.prototype.includes` can not be a typeguard?,1,0,0,0,0,0 941234580,"I think you’re right that this would be fairly easy from an implementation standpoint, but there are two main reasons why we don’t want to move forward without careful consideration of the full problem space: 1. If we _simply_ add a flag that allows module resolution to work with `.ts` files, it will 100% contribute to the misconception that TypeScript does, can, or should emit JS files with the transformation `import ""./foo.ts""` β†’ `import ""./foo.js""`. We already have angry mobs demanding that this happen for `import ""./foo""` β†’ `import ""./foo.js""` so if we allowed `.ts` extensions on there without it being very clear what use cases it is intended to serve, it would just pour fuel on that fire. 2. Such a flag would look like a gift to Deno users, but it would actually be woefully incomplete for them. There are obviously a lot of other parts of module resolution that are either specific to Deno or shared between Deno and the browser that we don’t currently support, and I think those users would be confused and disappointed that we stopped so far short of proper support for these things. Don’t get me wrong, I want us to solve all of these problems, but we’re still in the phase where we’re trying to develop a thorough understanding of all the different reasons people want this and what the existing solutions are.",1,0,0,0,0,0 944216399,"While I do agree with [USER] my argument why this shouldn't really be considered a bug would be on a much more fundamental level. There is not much typescript can do about this without breaking it's [Non-Goal No 3]([URL] [BLOCK QUOTE]. The only alternative would be treating properties that are known to be getters the same as function calls, which is not what you want in most cases, they are almost always supposed to be treated like regular properties. This kind of check is quite common check to prevent check if a value is not null so flagging it based on the signature alone would be annoying to most people that dont have such edge case uses as they'd have to do the non-null assertion even if it's not really needed. So yes the only way you could detect it without troubling people when it mostly isn't necessary is by analyzing the flow in depth, which isn't worth it for such an edge case in my opinion but the issue above has more discussion on that. On top of that a simple way to avoid this using modern ECMAScript features is `a.member?.do()`.",1,0,0,0,0,0 944899862,"Please vote for specific issues, or file new issues with specific details if you have issues that are not already filed. Closing as this is not an actionable issue.",1,0,0,0,0,0 947366138,"[BLOCK QUOTE]. No, if there would have an overflow error, it would have shown in console too, which I don't see at all. Also tried scrolling but don't see any issue.",1,0,0,0,0,0 947893665,"Given the disagreement, I've reopened the issue.",1,0,0,0,0,0 948264963,I really don't see how this is any different than #467.,1,0,0,0,0,0 948437097,"[USER] The link you provided is not the issue, i fixed it by myself. Firebase was the problem here. In older versions i had Application and FirebaseCloudMessagingPluginRegistrant. I had to remove these files completely since they are no longer needed in new version. [TRIPLE QUOTE]. [TRIPLE QUOTE].",1,0,0,0,0,0 950815592,[USER] I am not sure that this make sense since we have module federation,1,0,0,0,0,0 951958223,I'm not convinced that the glossary should require public-api approval πŸ€”,1,0,0,0,0,0 956248457,"Hi [USER], This doesn't look like flutter specific issue but rather the flutter plugin for Android Studio, I would advise you to please file the issue in the dedicated repo [URL] Closing, as this isn't an issue with flutter. If you disagree feel free to write in the comments and I will reopen it. Thank you.",1,0,0,0,0,0 956260525,I don't understand the use case. This would add unnecessary complexity with no real benefit.,1,0,0,0,0,0 956435881,"[BLOCK QUOTE]. No, that would not. Obviously what's being asked is for the background of the label to keep a constant size regardless of where it's located over the border.",1,0,0,0,0,0 957915873,Duplicate of [URL] Closing in favor of the above since it has a reproduction.,1,0,0,0,0,0 958251397,"Closing this as it's out of date and hasn't seen updates since February 2020, but we can re-open if necessary to land any changes in here after updates.",1,0,0,0,0,0 958324195,Closing this as the replacement PR for this documentation has landed already.,1,0,0,0,0,0 653148464,"I'm not sure I see the advantage, since it's not closing over anything.",1,0,0,0,0,0 577022246,Please revert. This isn't a typo.,1,0,0,0,0,0 666307582,"Ewww. OK, I'll change it, but... ewww.",1,0,0,0,0,0 668992882,As mentioned by [USER] this should be removed.,1,0,0,0,0,0 901188031,"[BLOCK QUOTE]. Same here! An ugly workaround would be enabling strict mode and adding the [// @ts-expect-error]([URL]) comment everywhere where you cannot fix the compilation errors right away.",1,0,0,0,0,0 902648515,"For anybody looking for an ugly workaround, I've yet to see any issues with this patch of `attachPatchData`: [TRIPLE QUOTE].",1,0,0,0,0,0 931429308,"Yeah, there are several issues asking us to be more aggressive about either recognizing code as unreachable or issuing errors when we already do (like hereβ€”`value` is successfully narrowed to `never` inside `if (!value)`, but the user has no way of noticing that because they think they just detected it to be `undefined`, so of course they’re not going to try to use it). But I like this issue because the scope is very narrow, and seems to sit well within the unawaited Promise / uncalled function checks we already have. Also related is #45267",1,0,0,0,0,0 938210972,"IMO [USER] you're absolutely correct, rewriting imports is compile-time behavior that is *not* a runtime changeβ€”in fact, for this resolution algorithm, you are having to make the compile-time changes by hand, in your source code, rather than letting the TS compiler do it for you. I have personally said enough on this to digress now also, as maintainers have made it clear they feel like it's a waste of their timeβ€”but it seems clear that developers would prefer to not rewrite thousands of imports by hand.",1,0,0,0,0,0 957181607,"Any update ? my app have been removed because this , I never never never try to read clipboard , ​ Just because I used textfiled , Can't beleive such a big bug has not been solved yet",1,0,0,0,0,0 696157106,"This seems like a poorer developer experience-it's out of keeping with other similar `flutter/flutter` widgets (see LinearGradient.stops([URL]) and requires a ton more boiler plate. Readability and editability for `SnapSizes()..add(.1)..add(2)` is pretty poor. Also, what does it mean for `snapToMin/Max` to be false? That the sheet slides without snapping between the outer snap points and the min/max? That sounds like very strange UX that we'd not want to expose...Or the sheet could always snap to the available snap points so you could drag to the max size, but if max size isn't a snap size, you'd snap back down to the nearest snap size. That sounds more sane, but still weird UX. And this construction still doesn't ensure that users don't attempt to specify snap points that are outside of min and max-we'll still need an assert at least for that case. What do you think about staying with just a plain old list and a bool (or just a plain list and no bool, with the added caveat that this means an empty list will enable snapping which is awkward...)? This keeps us in line with the one comparable example I know of (`LinearGradient.stops`) and it feels like we're adding a lot of complexity to avoid relying on assertion errors, I'm not sure I see the tradeoff being worth it. I could move the assertion errors into the sheet's constructors so it's easier for devs to interpret the stacktrace-would that help? and/or we could return an ordered list instead of throwing if an unordered list is provided-but I think it's better to loudly fail than silently do something weird-I can't imagine a developer intentionally supplying an undordered list-it'll make their code way less readable. If the list is unordered, it's probably the result of a bug and it's better to fail so the developer can root cause the issue than to continue with potentially unintended `snapSizes`.",1,0,0,0,0,0 157991924,"Yeah, that's a problem. Omit the brackets to make the tools happy",1,0,0,0,0,0 183948266,This never returns false. There is alway a runtime chunk.,1,0,0,0,0,0 224008349,"Ahh yep, github did manage to display tabs correctly until this day... πŸ™„",1,0,0,0,0,0 247363022,"Sorry, I'm not sure what change you'd like to see here? From my perspective, this is already an allowed edge case: [TRIPLE QUOTE]. ...since TypeScript gives no checker complaint, and its downpiled output runs without error, but running that directly gives the ""Must call super constructor..."" error.",1,0,0,0,0,0 707711101,"thanks, I was so frustrated as to why this was still failing",1,0,0,0,0,0 797642403,"Unfortunately, I can't help much, I spent 3~4 hours on debug and no luck, it require more time on debug, but I think it should done by `terser` contributors, feel free to report in `terser` repo and provide information about `compress.unused: false` is fix the problem. Nothing to fix on our side, sorry, I helped as much as I could My **BIG** recommendation is drop IE 11, I know that some clients still require it, but it's time to tell them no, it is not possible do good and it is very slow. As workaround you can setup `terser-webpack-plugin` manually using `vue.config.js` and setup `compress.unused: false`. Feel free to feedback",1,0,0,0,0,0 800913191,Tried everything on this page but nothing seems to work. It's a really big issue with webpack and also the only issue that is bugging a lot.,1,0,0,0,0,0 815426944,"webpack@5.31.0 still get this problem ![image]([URL] `concatenateModules: false ` can fix it。 @Knagis [USER] Could you reopen this issue?",1,0,0,0,0,0 872341926,Any news regarding this issue? It's pretty frustrating :),1,0,0,0,0,0 877598129,"At least it's fair, even too late. More frustrating is the root of this decision - Angular team want to move away from Rxjs. As for me it's the first sign to move away from Angular.",1,0,0,0,0,0 880924074,"How could we even check them? Note that this voting process is purely to give us some insight into how important a feature is to people in the community. While this is taken into account, the final decision whether to implement a feature comes down to how it fits into our overall strategy and how it fits with other features; how complex it is for the benefit; how big a breaking change it might require; but also what capacity the team has.",1,0,0,0,0,0 898557681,"[USER] could not look at this problem again, it seems to me the author has not fully revealed the essence of the problem. I have the following situation: [TRIPLE QUOTE]. In that case `tsb -b` report error in pacakge-three x3 times. even with [TRIPLE QUOTE]. This makes me very frustrating and does not at all correlate with what I expect from such a configuration.",1,0,0,0,0,0 899119740,Why is this closed? It's still very much an issue in the circumstance that [USER] describes.,1,0,0,0,0,0 900222068,are we getting fix?,1,0,0,0,0,0 913254182,Still here and struggling.. the code works fine but intellisense is not working and the error shows up in VSCode..,1,0,0,0,0,0 918873799,Bump. Still facing this issue when loading svg from different extensions like tsx or less.,1,0,0,0,0,0 919361406,"[BLOCK QUOTE]. @csvan : disagree : projects only requiring webpack4 along with version 4 of `@types/webpack` like [URL] through npm shouldn’t stop compiling because webpack5 is now available (as a result, I’ve no ideas on what to do to get [URL] to compile whereas it compiled just fine before 2021).",1,0,0,0,0,0 922246857,"[USER] [USER] [USER] hello, is there any plans to include this issue in the roadmap? I also find it extremely frustrating. At least, can you give me a brief insight how difficult will it be to solve in case if I will try to create PR for this issue? Wish you to have a nice weekend.",1,0,0,0,0,0 922487629,Any news about this one? I am having the same issue with vue-cli and webpack5,1,0,0,0,0,0 923134732,"I don't know if there's a better way to ask for this to get priority other than commenting. It has been frustrating to no longer have `occurrencesHighlight` functionality. For me, this occurred because my GraphQL type definition files are exported from a .ts file. This functionalty used to work even in those files, but with this change, the functionality has to be disabled.",1,0,0,0,0,0 924200778,Too bad! Thank you anyway ... This issue is really driving me nuts ...,1,0,0,0,0,0 927300836,is this getting fixed anytime soon ?,1,0,0,0,0,0 929572189,"[BLOCK QUOTE]. Why is this when other type modules, afaik, are loaded without requiring the `[USER]` prefix? I spent hours on this.",1,0,0,0,0,0 944476051,"I am coming from [URL] I followed the instructions still I am getting [TRIPLE QUOTE].",1,0,0,0,0,0 945169237,No news? No answer? [USER] [USER],1,0,0,0,0,0 948199142,"I also encountered the same problem, tried the following solution, the problem still exists [TRIPLE QUOTE].",1,0,0,0,0,0 948250397,[USER] Did you finally solve this problem? I have the same idea and encountered a problem,1,0,0,0,0,0 948447080,Any news about this issue?,1,0,0,0,0,0 948624251,"How come something like that is still not solved after 4 full years ? XSRF is highly configurable in most server side technology, it should be the same on frontend side. I need to interact with a backend that checks XSRF on each request with header ""application/json"", whatever the http method is.",1,0,0,0,0,0 949326882,Angular 12.1.1 and this is still the case. Can't reliably calculate styles of rendered elements because of this. Why isn't this fixed yet 4 years later?,1,0,0,0,0,0 951202592,Guys any solution after 3 years?,1,0,0,0,0,0 955667880,"[BLOCK QUOTE]. If this is a workaround, and this issue was closed, what is the solution?",1,0,0,0,0,0 960494704,5 years after issue creation and still forms cause this bug. Are you going to fix it?,1,0,0,0,0,0 946366720,"The longer backtrace also doesn't make sense to me, but maybe [USER] or [USER] have more insights.",1,0,0,0,0,0 947440525,"[USER] I know about the workarounds. In these cases, adding alignment to the outer container causes the apps to render as expected. But the issue is that the widget are behaving in a way that doesn't match their documentation.",1,0,0,0,0,0 623086599,"As the change currently stands I'm not a huge fan of extracting this function. It makes the diff pretty hard to read. On the other hand, if adding `set` tests shows that the code needs to be more complex, it might tip the balance more strongly toward having a separate function.",0,0,1,0,0,0 655517945,"Please be wary of [URL] This would be a good place exactly what the borderRadius property applies to. Just the button, the menu items, the menu? etc.",0,0,1,0,0,0 657684839,😱 - good spot.,0,0,1,0,0,0 686060174,It turned out that this was a bit more complicated since we need to update `super` containers with proxies even if they are not async but only if they contain `super` accesses within an async function inside the `super` container. 😱,0,0,1,0,0,0 694843924,"This comment is outdated now, It defaults to 80 all the time regardless of labelBehavior",0,0,1,0,0,0 715116533,"I don't see it, where is logger nullable? Doesn't it need to be present in `handleError`?",0,0,1,0,0,0 716975979,"This looks scary, why we need to put this in a microtask? also do we need to debounce?",0,0,1,0,0,0 872327838,I'm afraid that this got no community support.,0,0,1,0,0,0 932410737,"[BLOCK QUOTE]. Great. I'll wait for everything to go green, then merge and sync. I'm a bit scared of missing stuff in the Slack, so pls remove the merge label if that changes!",0,0,1,0,0,0 950728707,"I have the exact same issue. For me, it happens for all kinds of widget tests, not just for text input. I'm also on MacOS and can confirm that running `flutter clean` then running the tests again would solve the issue. Another thing to note is that I'm pretty sure I didn't have this issue before Flutter 2.5. Maybe something introduced in 2.5 caused this issue.",0,0,1,0,0,0 955954934,"[USER] and others this has been fixed in latest webpack for almost a week now, please check the last comments and do not copy the first workaround you find - it's both unnecessary and might break other Node tools.",0,0,1,0,0,0 957125817,"Yeah, exactly the same issue. Thanks for the link. But i need to recode to accomodate the updated pluging. I know i am asking for too much, but i just hope pluging developer don't just remove the feature just like that.",0,0,1,0,0,0 954299591,This problem still persists...,1,0,0,0,0,0 90343794,Why only show warnings for emitted chunks? Show them always. The error doesn't vanish on recompile. It's still to big.,1,0,0,0,0,0 100009777,double `;;`. Please check if your tests make sense when writing...,1,0,0,0,0,0 101380209,"it does look weird but if i do what you suggest (what i tried in the first place) the linter complains. Having it not like that makes eslint complain though. The two linters should be aligned at some point",1,0,0,0,0,0 104302457,"Just to call this out, a SyntaxError is still being thrown but the message no longer contains this text.",1,0,0,0,0,0 127898160,just making this a little more readable - hard to grok with such high arity if all on one line,1,0,0,0,0,0 149628835,"Throwing is expensive, but this line doesn't throw. It's not in the hot path anyway. Not worth changing.",1,0,0,0,0,0 173096042,Please add brackets here. It's really hard to read.,1,0,0,0,0,0 187769710,"Sorry but I don't understand why you are renaming the internal name here? How are the usage detected? I'm not able to trigger the DCE. [TRIPLE QUOTE].",1,0,0,0,0,0 216911283,Please read my comment again. This is supposed to return a function when `this.name` is a function.,1,0,0,0,0,0 425446839,"Well, you can't fix the entire world. We'll have to figure out what the right balance of correctness vs not breaking everyone is. I'll bring it up in our weekly design meeting.",1,0,0,0,0,0 536463509,"bash is so dumb, I hate computers",1,0,0,0,0,0 575565644,🀷 it's backward compatible,1,0,0,0,0,0 576750629,"I'm *pretty sure* we should sort this in some way, since I think our array ordering will respect the input order (our maps all respect insertion order for iteration at least) - so `{a, b}` and `{b, a}` are going to yield props in differing orders, which'll in turn make differing keys here, but are... essentially the same type? The same as far as we actually reason about anyway.",1,0,0,0,0,0 619346313,"All of these are fine to have, and correct, but as far as I understand, essentially pointless. I don’t think they’re particularly important to test, and I definitely think that little to no implementation code should be written to make these cases pass.",1,0,0,0,0,0 622428301,I can't reproduce this formatting issue. Is your screen zoomed in by chance? I've broken the layout by forgetting I zoomed in.,1,0,0,0,0,0 626076316,"This seems kind of repetitive: ""Strict mode is the default"", ""automatically uses strict mode""",1,0,0,0,0,0 627465339,"FWIW, I find this way of formatting difficult to read. I'd rather stick to how similar elements are formatted in the `i18n` examples (but I don't feel particularly strongly about it).",1,0,0,0,0,0 637383047,This seems to work fine for me πŸ˜•,1,0,0,0,0,0 641433569,"You are right, this change actually breaks some tests.",1,0,0,0,0,0 651918294,Could you please remove these unrelated formatting changes (here and below)? :pray:,1,0,0,0,0,0 658926348,"I think the whitespace is wrong but hard to tell in GitHub [TRIPLE QUOTE].",1,0,0,0,0,0 668225309,"Please revert all these unrelated code formatting changes. The flutter repo does not use dartfmt, see also [URL]",1,0,0,0,0,0 668974964,I'm sure you're aware but heads up there is a commented out method here.,1,0,0,0,0,0 669906139,"This is pretty hard to read. Here's an alternative: [TRIPLE QUOTE].",1,0,0,0,0,0 669942401,this comment is a little outdated,1,0,0,0,0,0 671498090,"Of course, none is asking for our agreement, it was just stating an opinion for the sake of the discussion. My first intuition was that because imports in NgModules could only import modules, then using the same name in components would be semantically different. However, considering you'll now be able to import Components as well, perhaps it IS semantically the same.",1,0,0,0,0,0 673540353,"This file's diff is really hard to read, but basically what happened was: * Lots of logic moved to TextEditingAction, TextEditingValue, and TextSelection. * Some alphabetizing/reordering may have happened... * TextMetrics was implemented. * debugAssertLayoutUpToDate was turned into a function and deduplicated.",1,0,0,0,0,0 677019183,Please don't reformat this,1,0,0,0,0,0 681141416,"This is a bit hard to read. Here's a suggestion: [TRIPLE QUOTE].",1,0,0,0,0,0 703925795,"I hate β€œcan only be used” but will match existing options. --- [BLOCK QUOTE]. β€” _Dreyer’s English_, p. 253",1,0,0,0,0,0 715214195,"Sorry, I don't see what you mean. It's in line with the `math.min` line, which is what it matches.",1,0,0,0,0,0 716710724,"What does ""break down"" refer to here (and below)? πŸ˜•",1,0,0,0,0,0 730398750,"Are you sure they are not ignored? Based on the regexes, I think they are ignored πŸ˜•",1,0,0,0,0,0 739521555,"Note that this is never surfaced by the VS Code UI 🀷 I think that's totally fine, I only made it because the protocol made me have a message to go along with the fix",1,0,0,0,0,0 785823452,You don't ask something,1,0,0,0,0,0 794177661,"Expected, do not mix webpack v4 and webpack v5, it was answered a lot of time",1,0,0,0,0,0 794180596,"So you're saying the entire industry should upgrade to webpack 5 at the same time? It's rather difficult even in my own small ecosystem. `app` has some dependency that does not support webpack@5 yet, so I shouldn't upgrade anything else either?",1,0,0,0,0,0 797512596,"I have the same issue Cannot read property 'includes' of undefined"".",1,0,0,0,0,0 809284754,"You still use old version of `terser-webpack-plugin`, please double check your `webpack` and `terser-webpack-plugin` versions",1,0,0,0,0,0 809338018,"Never ignore the issue template, respect time of other developers",1,0,0,0,0,0 814970212,"[BLOCK QUOTE]. Steps to reproduce, don't understand what is misleading here... without code nobody can't help",1,0,0,0,0,0 839699752,"`*` never work, please read docs how alias works [URL]",1,0,0,0,0,0 856804454,"You should fix it in your app, sorry won't fix, there is no HTML in JS, only strings",1,0,0,0,0,0 869009588,"[BLOCK QUOTE]. How come this is downvoted? Isn't this **the** official Webpack solution?",1,0,0,0,0,0 872265480,"If there were any news, you'd be able to read it here. Please don't ping several dozen of people bumping this issue unnecessarily, thank you!",1,0,0,0,0,0 876998140,"I was not aware that the directive wraps the validator in a problematic way. So it's a relief that a ""normal usage"" of `Validators.required` would indeed be detectable by `@angular/material`. That's the most frequent and annoying thing from my point of view. And I'm looking forward to seeing it fixed. However this would not be true for any other validators that takes an argument, such as `Validators.min`. Similar to the required validator that should automatically show a `*` to the user, I would like that the `Validators.min(3)` set by TypeScript is reflected as the attribute `min=""3""` in DOM, so that browsers can behave accordingly (prevent input of invalid things). Unfortunately it would seems that I would have to wait for that future Forms redesign.",1,0,0,0,0,0 877308201,"Agreed, very lame. One of the most annoying things I've found with this ""community library component"" approach is that you have to factor in passing every single viable attribute to both links, which makes it way more cumbersome than just passing a link string.",1,0,0,0,0,0 877309743,"ahhh every time I read ""good opportunity for a community library component"" I feel pain... It's like: we don't have the mood, so pls solve it instead of us. I see 235 unhandled issue reports, begging for maintenance when you'd upgrade etc... it's ridiculous. I understand the other side's concerns too, but I can't believe that there is no better way to handle external links on **web**. It's like bicycles without wheels.",1,0,0,0,0,0 877547567,"[USER] since it's likely developers will keep encountering the issue, what is the official recommendation from the Angular team on how to deal with this?",1,0,0,0,0,0 878249439,"Please do not ignore the issue template, fix it and I will reopen",1,0,0,0,0,0 880069933,"I'm sorry but we don't understand the problem you are reporting. If the problem still exists in your application, please [open a new issue]([URL] and follow the instructions in the issue template.",1,0,0,0,0,0 880071474,Looks like this might be a duplicate of #12960 after investigating further - sorry!,1,0,0,0,0,0 884292533,"No bugs here, wrong template for the issue",1,0,0,0,0,0 885583176,Please respect time of other devleopers,1,0,0,0,0,0 887526993,Please can you provide a running example of this problem for us to investigate. Without this it is not possible to look into this issue.,1,0,0,0,0,0 892770343,"Guys, please stop with the `+1`. On the right sidebar, you have a ""Subscribe"" button, please use that.",1,0,0,0,0,0 894266430,"Yes, `as const` works, but it a bit ugly to add everywhere. Thx for feedback.",1,0,0,0,0,0 894964803,"This is not a bug, this is working as intended. A change to omit has been proposed and rejected already. There are implementations out there (even in the issues linked) that work as you want by first excluding the Index signature.",1,0,0,0,0,0 897816045,"Please do not duplicate issues, we already have issue here [URL] put your investigation here [URL] with example of reproducing",1,0,0,0,0,0 899787982,This *still* exists as of August 2021. I'm having the same error messages as [USER] and this is a major annoyance.,1,0,0,0,0,0 901050363,[USER] [USER] Please don't forget this PR. Please.,1,0,0,0,0,0 902187896,It's going to be really hard to diagnose this problem without some more information. Is it possible to share a reproduction that can be debugged?,1,0,0,0,0,0 904339392,"[USER] You are joking right, like ability for ts guys understand stuff is very low in seeing permutations/combinations puzzle peace come to gather for nice tight fitting language, starting to get frustrated. 2 Seconds on a problem you guys give up, by the looks of it.",1,0,0,0,0,0 906084897,Complete English sentences are my preference in documentation and error messages.,1,0,0,0,0,0 909621683,This has been over a year. This is a very annoying bug. Any updates on the progress? This shouldn't take more than 2 major versions.,1,0,0,0,0,0 911706309,"We have a lot of tsconfig files, kind of annoying to keep them all in sync.",1,0,0,0,0,0 913671594,"Thanks for your contribution. However, this is already being addressed by someone else in [URL]",1,0,0,0,0,0 916059076,"Increase your memory usage, file is so bug, not related to this problem",1,0,0,0,0,0 916440817,"It’s not intentional that it was ever included in the first place, as it doesn’t meet our bar of spec/support for standard lib inclusion. The removal was documented ahead of time as [USER] pointed out. We’re aware that 4.4 included more lib breaks than usual as we transitioned to a new process for generating them, and while we expect that the breakiness of 4.4 was a one-time pain associated with that transition, we’re having conversations about how we can do better with this in the future. That’s part of the motivation for a versioned `@types/web` ([URL] and potentially other ways of versioning and resolving libs (#45685)β€”in general, we don’t think it makes sense for people to be stuck dealing with lib changes (particularly DOM lib changes) if they want to upgrade their TS version.",1,0,0,0,0,0 916801688,"There are a number of times something like `""pathsAppend"": [], ""libsAppend"": [], ""referencesAppend"": [], ""includesAppend"": []` Where we want to ADD to what ever the default/extended options are, rather than replace/override. Libs being the most annoying even in 'standard' circumstances without extending another tsconfig, but the fact that 'adding' a single lib, REMOVES ALL the default ones added by the ""target"" setting. And you can't even get a definitive list of what those libs were..",1,0,0,0,0,0 917047364,"Renaming a file causes the same problem too, I need to restart it, which takes nearly a minute, so pretty annoying",1,0,0,0,0,0 920222212,"[USER] Why did you close this issue? Your answer is another prove that the TypeScript crew should do ""something"" with this request. The plugin you send isn't compatible with the native `typescript` library. It's for `ttypescript`, which is forked by a random guy probably because you didn't want to implement some functionalities. Creating custom transformers could be a solution, but it should be supported by a native `typescript` library with official support. I guess that developers would be satisfied with such a solution, especially that it offers much more. Could you share info if TypeScript supports such plugins? Still, I don't know why did you close this issue if you didn't provide a solution on how to resolve paths using **native typescript library** (which this request refers to). If you want to say ""do not use typescript – use everything else"" just say it directly, but it's not a definition of contributing to this library, nor solves this issue.",1,0,0,0,0,0 920907560,I don't see how runtime fix this problem,1,0,0,0,0,0 922498675,"[USER] You didn't read the link I provided, did you? Filipe provided you the solution, which is mentioned in the provided documentation as well. [BLOCK QUOTE]. Just because you don't know how it's done correctly doesn't mean it's a bug. :-) You're just dealing with behaviour your don't understand, but don't try to line out what exactly is the bug, instead want to know how to achieve the desired result. [BLOCK QUOTE]. Terrible library. I always feel pain having to use it.",1,0,0,0,0,0 923845868,"I don't know what we need explain here, Node.js docs describe how `exports` works",1,0,0,0,0,0 929391408,"I welcome thoughtful discussion and debate, but this conversation is running in circles and getting heated. I apologize to those who were just asking questions in good faith, but some others in this thread are going to have to find a more productive way to engage in conversation about decisions they disagree with. This issue is a duplicate of many others, linked throughout the comments above. We have been talking about this for _years_, and nothing new has been said in this thread, so it has become just a drain on maintainer time and energy. Thank you for understanding.",1,0,0,0,0,0 932467100,The issue template you didn't fill out has a checklist. Your suggestion goes against the design philosophy of TypeScript and would be a fairly bad fit. It's also a duplicate: #563,1,0,0,0,0,0 934533771,"[BLOCK QUOTE]. Honestly, this is getting ridiculous. It's clear that you don't know what the heck you're talking about. In the brief example you can't call `meth()` because TypeScript correctly narrows it to `never`. This is due to the behaviour of assignments narrowing the type of variables. TypeScript sees that a `Foo[]` is assigned, but no `Foo`. So trying to narrow it to `Foo` using `'bar' in ff` results in `never`, because it can't be a `Foo`. If you take this behaviour out of the equation (e.g. by returning the value from a function) you will get the issue mentioned: [TRIPLE QUOTE]. [Playground link]([URL]",1,0,0,0,0,0 934976734,"[BLOCK QUOTE]. I'm not saying that a type cannot have additional properties (I said the exact opposite [here]([URL] myself). I'm saying the compiler is correct when handling `f` as `Foo` due to `Foo[]` ""not have"" `'bar'` because it already is the expected behaviour. The compiler is optimistic and handles as _exact types_ with respect to the `in` operator. This is enough for the vast majority of cases if you use good programming practices. I never had any problems using `in` to determine the type, neither in my personal projects nor in my work. This was explained here: [URL] [BLOCK QUOTE]. Yes, it is a duplicate and, even if it wasn't, the issue is incoherent and must be closed",1,0,0,0,0,0 936112827,"[BLOCK QUOTE]. How it is related to webpack? It is typescript problem",1,0,0,0,0,0 945482231,"[USER] I think you are hitting [URL] If so, please follow-up in it for further updates. Closing this as a duplicate. If you disagree, write in comments and I'll reopen it. Thanks.",1,0,0,0,0,0 945633797,"Thanks [USER] Looking forward to a fix or workaround , this is extremely annoying :)",1,0,0,0,0,0 947048082,"Please read answer again [URL] we can't fix it, because it is wrong, you can't use `import('./something.js.gz')` in JS code",1,0,0,0,0,0 947584682,This is already in flutter. Pl;ease search `stackoverflow`.,1,0,0,0,0,0 947754758,"Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.",1,0,0,0,0,0 947931540,"any solutions for this , its very annoying , happen after flutter last update !",1,0,0,0,0,0 948410407,"[USER] have you tried what [USER] stated above? Also, [USER] is right, the flutter issue tracker is for bugs and issues with flutter itself, not for help with personal code. Closing as this is an issue with implementation and not an actual issue with flutter.",1,0,0,0,0,0 948546791,this issue should be opened in the plugin's repo and not here,1,0,0,0,0,0 948616224,"Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on [StackOverflow]([URL] using tag `angular`. If you are wondering why we don't resolve support issues via the issue tracker, please [check out this explanation]([URL]",1,0,0,0,0,0 948865097,This is not related to TypeScript; it says eslint right there in the error message.,1,0,0,0,0,0 949455296,"This is more of a question for support channels like StackOverflow. Also, see [this]([URL] video and check if it answers your question. Closing from here.",1,0,0,0,0,0 949517979,Yeah it's a bit hard to understand the flow of what you're doing. If you can provide a minimal repro that will be very helpful [URL],1,0,0,0,0,0 949580851,"[BLOCK QUOTE]. Compared to what? A number like this isn't particularly informative in isolation. What GUI applications are you comparing to?",1,0,0,0,0,0 949808750,Images of text are difficult to deal with; please replace with plaintext and preferably a TS Playground link so that others can easily assess the issue.,1,0,0,0,0,0 950202494,"There is no difference in effects of RAM usage in an app made with Flutter vs with any other technology stack. Limits on RAM usage are purely a function of the platform, so this question should be addressed to a general discussion forum about those platforms.",1,0,0,0,0,0 950467908,Please see flutter.dev/community for links to other resources where you can ask questions about developing your own application; the issue tracker is for bug reports and specific feature requests.,1,0,0,0,0,0 950629187,"[USER] This question is better suited for support channels like StackOverflow or flutter's reddit page. Closing from here as this is more of a `how to` question, but this repo is for bugs and feature requests.",1,0,0,0,0,0 952764563,"Hi [USER] these warning messages correspond to the respective plugins/packages, that use a deprecated api, The right place to report these warnings would be in their respective repositories. [BLOCK QUOTE]. if you feel the error is caused due to the issue in the framework feel free to file a new issue with exact details and steps to reproduce the issue. [BLOCK QUOTE]. The number of supported devices depends on your application targetting the min SDK version. Closing, As this doesn't seem to describe a bug or a feature request in the flutter framework, If you disagree feel free to write in the comments and I will reopen it. Thank you.",1,0,0,0,0,0 952780583,"Hi [USER] Thanks for filing the issue. [BLOCK QUOTE]. Please try asking such questions on StackOverflow, The goal of the issue tracker is to track bugs and feature requests in the flutter framework. Closing as this isn't an issue with flutter itself if you disagree feel free to write in the comments and I will reopen it. Thank you.",1,0,0,0,0,0 953000455,"[BLOCK QUOTE]. Nobody is actively working on this issue, so there are no updates. If there were updates, you would see them here, so it's not necessary to ask. [BLOCK QUOTE]. Anyone interested in investigating this further is certainly welcome to do so.",1,0,0,0,0,0 953574609,"tried to turn off this error but still vs code makes it again and again again, just dont want to change vs code, but have this annoying thing error TS6053: File 'index.ts' not found.",1,0,0,0,0,0 954622478,"[USER] Your question is better suited for support channels like StackOverflow, so please ask the same there. Closing from here as this isn't a bug or feature request.",1,0,0,0,0,0 956088565,"Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances. Please help us help you by recreating the issue using one of our templates. Please fill out all fields, we can't help you without it",1,0,0,0,0,0 959880474,"[BLOCK QUOTE]. Please see flutter.dev/community for links to other resources where you can get help with your own projects; the issue tracker is specifically for bug reports and feature requests in Flutter itself, and can't provide support for project-level issue.",1,0,0,0,0,0 954241920,"I feel like in order to address a memory usage issue, we need to be comparing the same application implemented with Flutter and the thing you want to compare it to, with the details of the memory usage statistics (how much is resident, etc.). A simple measurement and ""I think it's too big"" isn't going to get us to any actionable issues, even if we agree with you. Telling us that some subsystem (fonts, i18n, images, etc.) uses more memory than expected is closer to something actionable, but we'd still need to know what the goal was and what it was begin compared to.",1,0,0,0,0,0 883376886,What is the actual error logged? Are there interceptors active? Please share a runnable reproduction of the issue as otherwise this isn't actionable for us.,1,0,0,0,0,0 912952924,Unfortunately without a reproduction it's hard to tell what is happening.,1,0,0,0,0,0 921523287,"Without a reproduction we're unable to help you here, unfortunately. Can you provide a Github repo with reproduction?",1,0,0,0,0,0 796733359,"Can you provide stack or something more, playing guessing is bad practice",1,0,0,0,0,0 902350845,"Please share a valid, self contained code sample that demonstrates the problems",1,0,0,0,0,0 149015057,I'm wanting this to land in v3 so still v4 support at least.,0,1,0,0,0,0 175118415,It would be great if this stays in a single log call.,0,1,0,0,0,0 665722062,I think it would be more helpful to explain how to inset a shape within a RawScrollbar that has a border. An example would be useful.,0,1,0,0,0,0 714383190,A comment that explains what 42x14 is based on would help,0,1,0,0,0,0 733180347,"Something [USER] mentioned in the design meeting is that this also has to gate out distributive conditionals. [TRIPLE QUOTE]. It would be good to have a test case here if nothing else fails.",0,1,0,0,0,0 898682837,Very interesting proposal! Would be greate to have an example of using pipes in bindings and conditions as it's also a very important part of building templates.,0,1,0,0,0,0 913018889,"I am the maintainer of the official Vue IDE plugin. Due to the particularity of the Vue template syntax, we need to use the `with` statement to make some very important performance improvements. Considering the number of Vue users, the benefits this brings will be huge. If TS can support this, we would be very grateful. πŸ™",0,1,0,0,0,0 951168813,[USER] - it would be really helpful if you could further bisect this to a specific commit using `git bisect`. We can do this but you might be able to get to it sooner than any of us :),0,1,0,0,0,0 951780448,"Thank you so much, I'll wait your update",0,1,0,0,0,0 959471483,Really need this,0,1,0,0,0,0 901411102,"Personally I'm hesitant to add more complexity to `TemplateStringsArray` - especially since it's inevitable that people will overuse this to write slow DSL parsers on long template strings. That said, it does feel like there should be a way to capture the contents of a template string today.",0,1,0,0,0,0 121332634,"It would be great to refactor all these defineProperty calls to getter and setter [TRIPLE QUOTE].",0,1,0,0,0,0 926011190,Would love a response from the Typescript team on this,0,1,0,0,0,0 926020531,"Thanks for that sample: I actually did that in my branch and indeed the code works with all versions of `tsc`. It'd be a huge help if you could make 4.4 emit a warning for this situation. I suspect every non-trivial backend typescript user is about to be bit by this issue.",0,1,0,0,0,0 953984119,"This is a first pass at the template updates for the PlatformInterface abstraction. This doesn't hit some of the requests of the ticket including showing an FFI implementation or any documentation updates on PlatformInterface. But, I would love some guidance on whether that should be part of this PR or part of a different one, and what we might want to update. Also, I did not add any tests for this, but all current tests pass. I'll double-check to see if any tests need to change or if I need to add one. Otherwise, I'll ask for a test exemption. Would love guidance on that as well.",0,1,0,0,0,0 853769619,"Thanks for the fast reply! I categorized it as a bug, sorry for the inconvenience... I assume you mean to use require.resolve within the alias to have a direct path to the module. This however, still leads to the same result. [TRIPLE QUOTE].",0,0,0,0,1,0 685514378,"You are totally right about the commas and the regex, I actually took a very naive and brittle approach and felt ok with it because it passed all the tests as soon as you mentioned that and I noticed a regex I right away got what where you were saying and totally agree with you of course I'll see to make the change and add the tests, so sorry for my silliness :bow: :bow: :bow: :cry:",0,0,0,0,1,0 108326688,My bad. Looks like didn't load the .editorconfig at the time. It's weird. I've reinstall my editor plugin then fixed it.,0,0,0,0,1,0 112711969,"You forgot to add the prettier rule to the eslint rules. This does nothing currently. [URL]",0,0,0,0,1,0 139258275,"Oops, that wasn't intentional",0,0,0,0,1,0 159822327,"Right, I forgot to remove this while investigating the failing test case.",0,0,0,0,1,0 159985236,Right. This is embarrassing...,0,0,0,0,1,0 164284889,Nope this is still proof of concept and is a good reminder that I forget console logs. 😬,0,0,0,0,1,0 175305372,Oops my bad,0,0,0,0,1,0 175672802,"Yeah, will edit that, sorry. :smiley:, wanted to ask question related to mocking.",0,0,0,0,1,0 187519600,"Sorry, I meant to include the exposed variables in the diff.",0,0,0,0,1,0 195418891,"aaa I see what you mean, sh...... ok, sorry will fix this",0,0,0,0,1,0 441936829,"🀦 It was meant to be: [TRIPLE QUOTE]. Do you have any suggestions?",0,0,0,0,1,0 499866660,"Ah, yes that's right! I was thinking about this case again over the weekend and forgot why I had previously realized it would be fine (because we skip the browser url update in this case 🀦 )",0,0,0,0,1,0 527391825,"Oh, I forgot to revert that. Sorry. Fixed!",0,0,0,0,1,0 531047169,"Hah, sorry, yeah, ok. Diffs don't really expand in `checker` and I was reading on mobile~",0,0,0,0,1,0 545912300,"Oops, missed the precedent. Changed.",0,0,0,0,1,0 561172432,sorry about that..,0,0,0,0,1,0 608856666,"Ok, so, in this case, we don’t need a semicolon because we had a line break and `{` is not one of the tokens that prevents ASI from happening. So here, we do want `Unexpected token. A constructor, method, accessor, or property was expected.` But if it were on the previous line, we’d want `';' expected.` Sorry if I led you astray in my previous commentβ€”I think what I said was right, but incomplete. This stuff is tricky πŸ˜… Some test cases: [TRIPLE QUOTE]. which is what they all say in current master.",0,0,0,0,1,0 624256467,Sorry i wasnt very clear in my comment.. What i was saying was that comparison needs to be between `Path` but value needs to be string.,0,0,0,0,1,0 626079878,"Oh yes, I just mixed that one up. Fixing!",0,0,0,0,1,0 646869077,"I thought I did, my bad",0,0,0,0,1,0 648607519,"Oh whoops, I thought I'd added this.",0,0,0,0,1,0 661805785,"Oh sorry, you're good. I was misreading the open/close brackets for the parameters in SelectableText.rich.",0,0,0,0,1,0 668162301,"Oops, good catch. I'd forgotten to commit some local changes.",0,0,0,0,1,0 670810244,Obvious typo I wish I'd caught sooner πŸ˜”. Good catch.,0,0,0,0,1,0 670920406,"You are indeed correct. I must have screwed something up when I initially tested this, but I've now formatted all of the SVGs properly and confirmed that they are still working fine.",0,0,0,0,1,0 676953338,"yeah sorry, I got so focused on the other issues that I missed the simplest thing :cry: :sob: `str` is 100% useless, I'll get rid of it, sorry :disappointed: :bow:",0,0,0,0,1,0 678683145,I think it's best to avoid the null assertion.,0,0,0,0,1,0 680373369,"""Illustrate"" doesn't seem right. I think the original meaning was ""let's take an example of"" or ""let's take a look at"".",0,0,0,0,1,0 688922297,"Ah good point, not sure how I missed that πŸ˜…",0,0,0,0,1,0 691654921,I'm embarrassed that I never thought of using reduce for calculating math.max of more than 2 items. πŸ‘,0,0,0,0,1,0 704845188,"Ah, I've missed that 🀦 Thanks Andrew.",0,0,0,0,1,0 708188146,Seems my fault.,0,0,0,0,1,0 713771774,"Oops my mistake. This should be: [TRIPLE QUOTE].",0,0,0,0,1,0 714192042,"sorry, didn't push yet...",0,0,0,0,1,0 720379174,"Oh right! πŸ™ƒ This started as a Mac issue, I forgot to add the rest",0,0,0,0,1,0 725161517,"Ooops! I would swear there was a higher up `describe` with something like `'on initialization'` 🧐 I'll change it to `should be enabled when the component is initialized` (because it get enabled in the `ngOnInit()` hook).",0,0,0,0,1,0 729849950,"Oops, bad copy/paste from Dart. Updated to refer to Flutter tool.",0,0,0,0,1,0 729998768,"Oh my, clearly not enough coffee this day. πŸ€¦β€β™€οΈ",0,0,0,0,1,0 730130505,"Oh my bad, removed.",0,0,0,0,1,0 731743222,🀦 will fix,0,0,0,0,1,0 732620316,Sorry i was careless.,0,0,0,0,1,0 860083418,"Oops, forgot a step in the reproduction instructions, `output.wasmLoading` needs to be set also",0,0,0,0,1,0 878506656,"New to GitHub pull-requests, I apologize for the unintended close.",0,0,0,0,1,0 904916186,"whoops, I hit undo one too many times before committing. Fixed, sorry. Issue is in `a/c.ts`",0,0,0,0,1,0 917988261,"Sorry, accidentally closed it.",0,0,0,0,1,0 919488143,"Ok, sorry for raising the alarm. I didn't realize I had to use `browserslist` and configure that I wanted support for IE11 explicitly in later versions, but it makes sense. Gotta forget about IE at some point :)",0,0,0,0,1,0 920557276,"[BLOCK QUOTE]. [USER] to be honest i completely neglected it because of a sizable, single-person project that landed on me several months ago. If I can't carve out some time inside the next couple days to get this done I will let you know. Sincere apologies...",0,0,0,0,1,0 926787602,"Ah, I forgot about that πŸ‘",0,0,0,0,1,0 931556612,Apparently I didn’t pull recently enough to resolve all the conflicts 🀦,0,0,0,0,1,0 932902244,"Yeah sorry that was a bit lazy of me, that was just the earliest version on playground I tested against before other errors started to show up",0,0,0,0,1,0 938433530,"I think I messed up this pull request, I didn't push with `--force-with-lease`. Let me open a new clean pull request.",0,0,0,0,1,0 944841426,"I'm not entirely sure what #45267 is going for - while it makes sense in theory, the reality of allowUnreachableCode: false is that it seems to include the type-unreachable things. Anyhow I suppose my complaint for type-unreachable code is that the error messages could be more clear, even when allowUnreachableCode: true. It's not immediately clear to me if that means this ticket will have the same resolution as that one or not.",0,0,0,0,1,0 946750179,"Hi [USER], my question was poorly phrased. I meant are you running the app or `android`, `web` or `desktop`? Thank you",0,0,0,0,1,0 949074310,"Yes, sorry - I forgot to close this when that patch got reverted. It may still be possible to do something with `Picture.dispose` on the DOM side, but not for diffing.",0,0,0,0,1,0 949935121,"Oh snap, I didn't even see that 😭.",0,0,0,0,1,0 952144731,This one was on me. I somehow ended up with two different copies of `webpack` in my `node_modules` and so the mix of versions didn't go well. 🀦 Really sorry for the trouble.,0,0,0,0,1,0 952194368,"Can't believe I missed that, that does the trick. Thanks!",0,0,0,0,1,0 953315083,"I don't think we've seen this flake in a long time, so I'm going to close this as part of the engine flaky issue triage process. Please feel free to re-open if I'm mistaken.",0,0,0,0,1,0 539427939,"haha sorry, my scheme history finally caught up with me",0,0,0,0,1,0 925412915,"I think the notes lost some context thereβ€”what I called β€œrocket science” was actually hand-authoring type definitions (e.g. for DefinitelyTyped) that work for a package that ships CJS and ESM side-by-side, and my point was that being able to redirect type resolution (to a separate module definition for each module kind) via export maps is going to be a super nice feature for us, and for type definition authors. (Also, rocket science was probably a bad analogy, since I assume that rocket science is meticulous, precise, and reliable 😬)",0,0,0,0,1,0 921221402,"Sorry, it seems I lost track of this. Is this PR still useful? Should I try to fix the issues?",0,0,0,0,1,0 526495093,You are right.. this must be friday evening brain fog.. external projects can create configured projects not inferred projects so this doesnt make sense. i am updating the test case..,0,0,1,0,0,0 740060843,"I am not convinced that multiformat runs of ngcc are more typical even on the command line. Obviously the CLI will target only one property per entry-point. But command line users who are not doing something similar (by providing a list of acceptable properties and asking to only build the first one) are probably wasting a lot of time processing formats that are not used. But I think it is reasonable to keep one of the two (property or format) in the info message. But I found that keeping both just added a lot of noise to the message, making it less helpful.",0,0,1,0,0,0 101927254,That's not the same as before. Would be a breaking change if you change this.,0,0,1,0,0,0 139083319,"I guess this could be more efficiently processed, but I guess it would break the code generation because of the assumption that the prefix can be replaced with a string literal. But as nobody writes such code by hand and babel won't generate this code (first argument to concat is always an expression), we can keep it simple.",0,0,1,0,0,0 159079807,I had to remove them because of the mocking system. Many tests were failing because of additional hooks.,0,0,1,0,0,0 159144172,This one was really hard to debug...,0,0,1,0,0,0 161679884,"It's kind of weird to support wrong booleans `""false""`. Remove this.",0,0,1,0,0,0 173051390,You should probably delete this..,0,0,1,0,0,0 182763900,Why is this happening? A side effect of generating tests dynamically?,0,0,1,0,0,0 184582031,"Hmm this was causing some strange assertions, I'll double check here.",0,0,1,0,0,0 189431101,"hmm.. I'll remove it, but the problem was there before this change...",0,0,1,0,0,0 191852312,"Yep, something is wrong",0,0,1,0,0,0 221837163,Still not sure if this handels all possible cases... :),0,0,1,0,0,0 247323467,this will falsely abort recursing into parameters of arrow functions,0,0,1,0,0,0 247501571,Yep. Same concern for me.,0,0,1,0,0,0 282613868,"My primary concern is performance. I'd rather avoid lookups against the `resolver` for every generated identifier, if possible. The only case where this check seems like it is needed is [here]([URL] so incurring the cost of the lookup for *every* hoisted variable is unnecessary overhead. I would still recommend that we add `addBlockVariableDeclaration` for this case, but we can mark it as `/* [USER] */` for now and revisit the API for custom transformer consumption later.",0,0,1,0,0,0 322592231,"That looks suspicious. Should it be more like this: [TRIPLE QUOTE].",0,0,1,0,0,0 343607217,"I think all files is unnecessary, plugins and webpack.js (as Node.js API) maybe.. don't know exactly",0,0,1,0,0,0 343838539,This change doesn't work correctly.,0,0,1,0,0,0 343840578,"Many attached types are missing here. This seem to be a typescript bug. Source file: [URL]",0,0,1,0,0,0 391751718,"Bug, i think it is breaking change",0,0,1,0,0,0 498581436,"Slightly afraid of all the places that are going to need to be patched up in the future to check like this, but I guess that's programming",0,0,1,0,0,0 516378355,This might be a premature optimization. Happy to roll it back if people have concerns.,0,0,1,0,0,0 527286267,"I was worried that, if I declared it as something other than an expanded union, we might change the representation in the future, silently invalidating the test. For example, one can imagine specializing type comparison for string template types so that the union didn't have to be expanded. TBH, string template types hadn't occurred to me, but I did specifically avoid using conditional spreads.",0,0,1,0,0,0 537022104,"Sorry that was a bit unclear. I'm not against the prefix. I was only complaining about the `Compilation finished` message, which is redundant to the `webpack compiled successfully` message in the stats output. A prefix is good in general for all other messages...",0,0,1,0,0,0 540428972,"You can still get duplicate reports with it in place if a comparison happens to show up multiple times in a program, and we do do some comparisons with `reportErrors` off only.",0,0,1,0,0,0 551036875,I wondered why this change is necessary as there cannot be syntactic modifiers in JS files. In case you also wondered: it turns out this might be a bug: #42189,0,0,1,0,0,0 553662723,"Also, whatever function this ends up using, it’s likely to be more expensive than the next couple conditions in this function, so this calculation should be moved to be the last.",0,0,1,0,0,0 566674300,I'm sure there is a nicer (and safer!) way of determining whether the properties of a mapped type are optional. Right now I'm looking at the syntax node. But this approach does not work with `+?` for example.,0,0,1,0,0,0 568290121,"You cannot rely on parents in transformers, prior transformations do not set them so they are likely to be `undefined`.",0,0,1,0,0,0 583047802,"I’m going to take a closer look at this implementation today, but first thing to note is that this test doesn’t actually generate the crash at #41925. I haven’t checked yet to see whether your changes do in fact fix that crash, but it seems like the test doesn’t actually prove that the linked bug is fixed.",0,0,1,0,0,0 597535481,"I am maybe missing something but it seems to be a dead code anyways, because `this.watcher` is always `null` at this point so this `if` branch with `this.watcher.pause()` is actually never executed (see line 252)? [URL]",0,0,1,0,0,0 608001823,"There are a couple failing tests now; I’m guessing some of this was still important. If I had to guess, I would say that this `else` block needs to be preserved for insertions where the next element is on a different line.",0,0,1,0,0,0 629544142,"moved, though I'm not 100% on how I set up the tests for it also, worried that while it fixes a bug, it's a bit breaking because it was added into es5 half a year ago",0,0,1,0,0,0 638232605,"I was thinking about this check more and I think this might actually become a source of flakes on CI. Also since this check would be invoked for each change and some URLs might become unreachable over time, we may end up with failing CI for main branches that would not be directly related to the changed code. I think the check is still useful, but I'd propose making it a warning instead and log the findings to the output (avoid throwing an error). In this case we would have all the necessary info and tooling to do these cleanup once in a while, but avoid flakes and CI failures due to 3rd party websites availability.",0,0,1,0,0,0 646820683,Isn't it a bug if attributes or resources below is null here?,0,0,1,0,0,0 646867180,"I don't think we can't do this, because it will be different depending on what the width of someone's terminal would be when running the tests (aka it'd be inconsistent)",0,0,1,0,0,0 652170292,"I thought the problem was with `AssignmentDeclarationKind.ThisProperty`. Why is the new code in `None` instead? Is it because there's an existing PropertyDeclaration? The new code in `getSymbolForExpression` kind of looks like it's a fallback mode for when syntactic detection fails in the checker, which it shouldn't if it has succeeded in the binder. So maybe the fix needs to be to iron out some mismatch between the binder and checker.",0,0,1,0,0,0 652291343,Is this change still break the G-test or internal test?,0,0,1,0,0,0 654710933,"This is getting a bit too clever... it seems we're relying on the fact that this returns `undefined` for all _other_ kinds of type nodes, correct? At the very least, we should have a comment here explaining: 1) what kinds of nodes we want to return `INELIGIBLE` for, and why. 2) the mechanism by which eligible nodes end up getting selected.",0,0,1,0,0,0 655711946,You could certainly be seeing an artifact of the fourslash client 😬. Have you checked the behavior against a Real Editor?,0,0,1,0,0,0 655792163,"Depending on the synchronously-executed part of an API that's documented to return a `Promise` seems dangerous, and even before this patch error handling is broken if you try to do so. But I can still implement the synchronous `then()` if you'd like.",0,0,1,0,0,0 656114362,I'm afraid that it is breaking change,0,0,1,0,0,0 657419914,Can we print a warning to nudge people to fix the lifecycles of their objects?,0,0,1,0,0,0 659305436,I think that this might not work if the array only has one element. Not sure if that can actually happen at runtime.,0,0,1,0,0,0 662652274,This looks worse? It has `number[]` twice.,0,0,1,0,0,0 665713857,I am a bit torn on instructing people to read the comment for context. Would it be better to express the reasoning here instead?,0,0,1,0,0,0 666500391,"[TRIPLE QUOTE]. This sounds like it is a bug we should fix directly rather than through a parameter like this.",0,0,1,0,0,0 669245883,"I see, this makes sense if the intent is to make this explicit to the user. Will this affect other `testWidget` blocks though? If so we should probably use `addTearDown` within the implementation to reset this after the current test block runs to avoid things like order-dependent tests.",0,0,1,0,0,0 670851195,"[USER] Since that affects all methods in the package, rather than just the proposed new ones, it would need to be changed consistently everywhere. Please feel free to open an issue about this!",0,0,1,0,0,0 671744800,"mh.... yeah I find that unlikely but I can see your point... I will think of something then to make this more robust... :slightly_smiling_face: unfortunately I am afraid I will have to also take into consideration vendor prefixes, so this can become quite more verbose and ugly :disappointed:",0,0,1,0,0,0 678671514,This sentence is hard to understand. Maybe rephrase?,0,0,1,0,0,0 685384838,aren't these Fuchsia specific too? Are they passing because they are working correctly or just passing by mistake?,0,0,1,0,0,0 691553976,I think we're introducing extra whitespace here?,0,0,1,0,0,0 691682727,"It doesn't seem to be an easy change, cocoon is still using existing `updateRequest`, which is different from the properties defined in TaskResult. I prefer to have that change in a separate PR to avoid breaking anything before validating the effectiveness of the intended logic. Created [URL] to track.",0,0,1,0,0,0 692481694,"Not sure if it's intentional, but there's a test that specifies an output file without "".dart"" suffix: [URL]",0,0,1,0,0,0 695142359,"Ouch my eyes hurt as I read what I wrote ! Anyway, the more I look into it, the harder it is for me to find a better wording...I think that the use of the future tense and the ""and"" made me wrongly believe that somehow the second part of the sentence was a consequence of the first one. Maybe because it just happen that the browser doesn't wait for these operations, the use of the present tense would be more appropriate : _The HeroService must wait for the server to respond, getHeroes() cannot return immediately with hero data, and the browser does not block while the service waits._ If this proposition is not convincing, I think I will consider closing this PR: I would not want to overcomplicate the sentence because I alone mis-interpreted it. Thank you for having taken the time to answer me πŸ˜ƒ",0,0,1,0,0,0 698729183,"I'm interested in what other reviewers think of this. In some cases multiple deltas are sent in one updateEditingValueWithDeltas, and in others just one is sent. Is this the cleanest way to do that?",0,0,1,0,0,0 698757630,"It's already pretty hard to understand what these are for. I'd encourage us to start documenting what the use-cases for each of these are. For example. [TRIPLE QUOTE].",0,0,1,0,0,0 701433441,Wow 2 minutes? Doesn't that sound excessive?,0,0,1,0,0,0 705653059,Feel free to file a bug for that - that code has a history of breaking :\,0,0,1,0,0,0 719854095,"I don't fully understand the value of this, especially if it means adding unused getters to the code. The documentation is: [URL] [BLOCK QUOTE]. With the example: [TRIPLE QUOTE]. In this example, the only way of ""observing the property's value"" is by accessing the value of `r`. It seems like a setter that really just assigns a value to a public property is the anti-pattern here.",0,0,1,0,0,0 720426290,"I think these are probably the same, but experience would advise not touching it if it’s not broken πŸ˜…",0,0,1,0,0,0 723625280,"We must not forget to add this at some point, although the text works without it.",0,0,1,0,0,0 724075575,"There's really no need to get so defensive, this wasn't meant as an attack or anything like that. I saw a discrepancy and voiced concern. Just ignoring the question and just closing it wasn't the nice way. There are many different ways to solve this issue. Which way is a good one highly depends on the existing code base and the stance of the team regarding this, and my knowledge about the code base is very little. - Make the `name` property of the existing interface optional. - Add a new interface with the `name` property optional for this case. - Use a null-object if an empty name is valid (might cause issues at different locations when a non-empty string is expected). - Do the workaround just as you did.",0,0,1,0,0,0 728460314,[USER] am I overengineering the ts part? :sweat:,0,0,1,0,0,0 732863681,"[BLOCK QUOTE]. I don't, really πŸ˜…",0,0,1,0,0,0 734095070,"Yeah. In order to trigger the bug, the symbol has to not exist by the meaning of the original lookup, but exist in the value meaning, _and_ it has to be part of a qualified name on the right-hand of an import equals, at least in the stack trace we're exclusively seeing in reports. I think the implicit assumption in this code was that if the symbol wasn't found in the lookup but exists by value, we must have been looking for a type, which of course is not true when we’re looking for namespaces exclusively. There is definitely some logical cleanup that should ideally happen around that, but I’m a little concerned because it would fix this particular repro, but is pretty far removed from the root cause, so I’m not confident it would fix all instances of this crash. There could be some other entrypoint to it that doesn’t come from resolving an `import =` entity name.",0,0,1,0,0,0 734893712,"There's some danger that people will see this thousands of times when they first change the setting, but I'm a little reluctant to ""optimize"" it without some way to establish that the change helped. Probably better to keep it simple until we measure a problem.",0,0,1,0,0,0 739482895,"I guess VS Code is ignoring this, but this doesn’t look right πŸ€”",0,0,1,0,0,0 740377665,"Is this intentional? There's two docregions here with the same name, and the closing of them results in broken html.",0,0,1,0,0,0 779330906,Yes that's a problem.,0,0,1,0,0,0 781305449,"[BLOCK QUOTE]. Because it is unsafe",0,0,1,0,0,0 796843409,"It's just that I'll be making a talk in the end of March that will be relying on a library that I can OSS only after this issue is resolved, and I'm getting a bit worried about this dependency chain and don't know what else to do on my side πŸ˜€ (meanwhile, I can point npm to my own fork for testing, but it won't be that helpful for other consumers of the said lib)",0,0,1,0,0,0 799565336,"[BLOCK QUOTE]. it is breaking change and potential break terminal for other developers, we can't do it",0,0,1,0,0,0 804007892,"Best avoid using contenthashes during development. This does have similar problems in other places, e. g. it writes a lot files into the filesystem (on disk or in memory).",0,0,1,0,0,0 805014039,"[USER] I've just added a test. By the way, I took really hard time understanding how test works :tired_face:",0,0,1,0,0,0 812886854,I am unsure why the lint test is failing - I have executed the command it suggests and it makes no further changes.,0,0,1,0,0,0 813032830,"I still see this issue, even with v5.30.0 [TRIPLE QUOTE].",0,0,1,0,0,0 826830753,"[USER] Can you provide example? Yep, it may be bug",0,0,1,0,0,0 834520801,"Could you please create new issue if this is still a problem? This issue is about webpack 3...",0,0,1,0,0,0 852588001,Bump - we still should address this it not already,0,0,1,0,0,0 868474298,"[USER] yep, I think we have critical perf bug here",0,0,1,0,0,0 872187676,"I think we should print warning in this case, still valid",0,0,1,0,0,0 872294314,Still no solution to this?,0,0,1,0,0,0 872918157,"If you need fix ASAP, please provide, bug I think bug somewhere else",0,0,1,0,0,0 879952810,"This seems like a bug, but it's unclear why this happens. Could you please provide a reproduction of the issue?",0,0,1,0,0,0 882454990,Any updates? We really need this in our project 😒,0,0,1,0,0,0 883501622,"Hi [USER] - thank you for this clear explanation of you problems with finding documentation on how to integrate Angular with Firebase. As you say there is https://github.com/angular/angularfire which has quite good docs. I am not sure what your concerns are about that library. It is probably the most up to date resource on such an integration. Regarding the Angular team documenting this integration directly, I'm afraid that is not going to happen. There are lots of potential backends out there that can be accessed via Angular apps and it is beyond our ability to document them all. I would recommend using AngularFire and filing issues or feature requests with them if there are areas that do not work as you wish.",0,0,1,0,0,0 892556228,should this even work.. spec disallow requesting directories..,0,0,1,0,0,0 894847214,This would happen if LS and server go out of sync and ls operation was invoked without synchronized data from project …,0,0,1,0,0,0 895683218,Err [USER] I think this is still a bug report,0,0,1,0,0,0 899533589,[USER] my concern with cutting corners here is that it would come at a high resource usage and high complexity (just the cache invalidation alone would be tricky to get right). But it is an idea with exploring more. Thanks for sharing.,0,0,1,0,0,0 902346222,Can you please revise the code example as markdown formatting messed up the original. I tried adding a fenced code block but it still looks weird,0,0,1,0,0,0 904020545,"I am concerned about declaration emit, for the same reasons I described above. Funnily enough, when I test it on the playground, JS emit preserves the radix, but not the .D.TS emit: [URL]",0,0,1,0,0,0 904133418,These failures look like TAP noise.,0,0,1,0,0,0 904406981,"[USER] keenly tracking your activity in the PRs you mentioned and cheering for the success πŸ‘πŸ‘πŸ‘πŸ‘ I just noticed that one of the two PRs targets the `compiler-cli`... Any chance that the transform could also be made available outside of the Angular compiler, as part of a standalone Zone package? If this is going to be supported, what will the required toolset look like? (I am naturally worried about the future of framework-agnostic zone.js usage... Definitely would be a bummer to have to rewrite the whole application in Angular!)",0,0,1,0,0,0 909740016,This is more correct but I'm not sure it's better for UX. The inlay hint just for `(` seems quite easy to overlook and I am worried it will end up causing confusion about what is in the file and what isn't,0,0,1,0,0,0 910123241,"I'm afraid that would be over-stepping, as they are allowed in those modes: [URL]",0,0,1,0,0,0 910458454,"On second thought, I don’t think we’d want the displays between these two scenarios to look too similar; as it is they kind of portray something fundamental about what’s going on. Needs some consideration.",0,0,1,0,0,0 912711121,I don't see how this is working as intended as `bugged` is **explicitly typed** `const bugged: Person[]`. Shouldn't the compiler reveal this contradiction? `Cannot assign any[] to Person[]`? I would agree this is working as intended if `bugged` was being _implicitly typed_ and was being inferred to be `any[]`.,0,0,1,0,0,0 917390173,"Bump. What are you going to do regarding this issue? Is there an alternative library that could be used instead?",0,0,1,0,0,0 919966458,This is still broken in v12.,0,0,1,0,0,0 922984235,"I second concerned about this. What is the reason of such breaking changes in 4.4 version?",0,0,1,0,0,0 924284753,"[BLOCK QUOTE]. I am currently spending 80% of my time on this. I cannot promise any specific dates, but the roadmap ***tentatively*** looks like this: - September: finish implementation on the prototype. We will probably add a `FormTuple` class, but it's otherwise very close to complete. If you're curious, the in-progress commit is linked to this issue. - October: check that google3 internal migration is seamless (simply adding explicit `` type params at call sites should preserve the exact old behavior). If there are any big compatibility issues, we'll find them here. - November: publish an RFC, with emphasis on important design questions (i.e. whether to capture `AbstractControl` types in the type parameters, the tradeoffs of `FormArray` vs `FormArray`, etc). - November: publish a downloadable version of the package that people can swap in to try out, and collect info on whether it causes any breakages. - May: ship it with v14, together with a migration schematic. I'm aware that this has slipped from v13 -- unfortunately, there's just not time for the RFC or google3 migration before v13. Again, I can't promise these dates, but I think the schedule is reasonable. The biggest risk is that the google3 migration uncovers a show-stopping backwards incompatibility.",0,0,1,0,0,0 926521260,"[BLOCK QUOTE]. The issue is that this check is actually making things less convenient :(",0,0,1,0,0,0 927500074,"I have some worries about this. I'm using some API that is marked as `@internal` but still exported to the `ts` namespace because there is no choice. Those internal functions provide some critical abilities to make the job done. If everything turned to the module and bundled by things like Rollup, they'll become truly inaccessible.",0,0,1,0,0,0 927878060,I'm afraid that you cannot mix and match versions of ngcc with the rest of the framework. You will need to update your project to v11.1 or later.,0,0,1,0,0,0 928060555,"[USER] I'm probably missing something obvious, but why is the `getBasePaths` call a mistake? Edit: The claim that it should use the absolute path is very plausible, but `getBasePaths` has a bunch of logic that suggests that it was expecting to handle relative paths.",0,0,1,0,0,0 929888883,"Personally I think TypeScript could allow receiving parameters that may not exist from rest parameters, similarly to how TypeScript currently allows accessing array elements that may not exist. Considering `noUncheckedIndexedAccess` in that case may be nicer. Either way, current behavior is unsafe, so a fix is desired.",0,0,1,0,0,0 934839400,"I understand these discussions can get frustrating - I encourage everyone to cool down for a bit. [USER] and [USER] are correct in their assessment. This is a duplicate of [URL] a duplicate of [URL] and probably more. We've made the design decision not to allow this code for the exact reasons discussed in this issue along with those issues. Object types are open (i.e. ""width"" subtyping) which means any object could have a property that it doesn't declare, and it's unsafe to narrow based on that.",0,0,1,0,0,0 940380780,"Is this a breaking change though? It seems that the current implementation is a bug, and anyone relying on the non-spec-compliant behavior would have an issue if they switched to `--target es2015`. We wouldn't be changing documented behavior in any way, so it might be worth taking in the beta timeframe.",0,0,1,0,0,0 943832719,Fair to say I significantly underestimated how much work this feature would take πŸ˜…,0,0,1,0,0,0 945148756,I know from #15300 that this is by design but I don’t know that I quite understand why. Is there a unique danger to allowing implicit index signatures for interface types? Merging new properties into existing interfaces seems like it could always break code that depends on these interfaces; I don’t really see the problem as being worse with implicit index signatures. Could someone enlighten me?,0,0,1,0,0,0 946417466,"The issue was never your code to begin with, it was likely something on the engine side, so I'm afraid that you may not find the reason",0,0,1,0,0,0 946662003,"Sorry, I wasn't ignoring that part of the template - I thought I had answered sufficiently. This doesn't seem optimal as it stands, and using `named` would cause a large size increase.",0,0,1,0,0,0 947140526,"[USER] just in case the feature request reaches the required upvotes *and* is considered an improvement, I took the liberty to already open a PR. Since this is the first time I'm tapping into the Angular sources, please forgive any stupidities on my side and just reject it if not deemed satisfactory or necessary.",0,0,1,0,0,0 947191315,"From talking with [USER] my understanding is that the tar approach we have is essentially a workaround for the limitations of the GitHub text search APIs and should go away when the GitHub search APIs improve. It's not clear when the search APIs will be improved, but I slightly worry about whether we should really be exposing that and having TypeScript depend on that implementation.",0,0,1,0,0,0 947668010,This issue need more attention.,0,0,1,0,0,0 948093511,"Trying to figure out what makes the tests fail. I can't check this locally, because they fail with same error for me even on master",0,0,1,0,0,0 948120013,"I was hoping to hear from the analyzer team how the additional lints came up by surprise. I think at the moment if we re-enabled the Dart rolls, we would just hit the same issue again since there were also lints beyond the ones from flutter_gallery.",0,0,1,0,0,0 948924239,`initializeTypeChecker` is kicking off work via `mergeSymbolTable` that ends up pulling on `globalObjectType` before it's initialized (later in `initializeTypeChecker`) 😱,0,0,1,0,0,0 949356853,"[BLOCK QUOTE]. It's not just occured with jenkins. when I start multiple tasks to build project with ""flutter build apk"" locally at same time. Problem still occured.",0,0,1,0,0,0 949794606,"Oh and just to clarify a few things... The P labels are not the same as the priority that I mentioned above. Once a piece of work is deemed complex enough it has to go into our team prioritization process amid many other tasks, of which quite a few are not even visible publicly. And also, open issues are never closed by any bot. Only closed issues that have not received activity for a long time are locked. This is a common misconception but I am not sure how we can communicate that better.",0,0,1,0,0,0 950534201,"[USER] we can take your example to again show that a plugin/hook system like the one from rollup is badly neeeded. you mixed linux shell script into your package.json as workaround.",0,0,1,0,0,0 950745708,"Tried it on Iphone 11 and visual bug was still there, but on Ipad air 2 it's not. I think it's with IOS mobile devices in general but I might be wrong",0,0,1,0,0,0 950888912,"Hi [USER] It seems to me the other issue tracks documentation updates (thus P4 priority) This one has reproducible steps and a code sample, and it seems to me that if the image cache leads to OOM this is a problem. What do you think?",0,0,1,0,0,0 951604428,"[USER] Yes. There's an issue in general with the stepper widget if we try to implement it horizontally and could be the root -cause, and using and not using keys are the variants of it. So it's better to follow in the original linked issue.",0,0,1,0,0,0 953221305,"There aren't any breaking issues on the current rollout, but the elevated error rate is concerning. [URL] should resolve the issues, and we can resume the rollouts.",0,0,1,0,0,0 953498958,"[USER] could you share some insight into why this is a potentially breaking change? Maybe it could be addressed, instead of just closing the issue?",0,0,1,0,0,0 953907569,I'm experiencing this as well.,0,0,1,0,0,0 954617743,"I have this issue in my desktop app, but the issue occurs when the app is launched and the title bar of the app flickers till the app loads",0,0,1,0,0,0 954898480,"I am also encountering this issue when calling `evaluateJavascript `. [TRIPLE QUOTE]. Has anyone found a workaround to avoid it? It's filling into my Sentry quite fast! πŸ˜… Thanks alot!",0,0,1,0,0,0 955072061,The highlights were pretty much my only concern with placing the tab stops,0,0,1,0,0,0 955088324,"My primary concerns are (1) real-world usefulness and (2) consistency. For me, [USER] actual user experience trumps most other considerations (barring an opposite opinion from some other user). I'm fine with never having tab-stops; I'd be reluctant to have tab-stops conditionally unless it's _really_ clear when you should expect them.",0,0,1,0,0,0 955199095,"JSDoc is used to only give type-hints in TypeScript and JavaScript files, not to direct how the syntax should change. I'm afraid any changes here would be massively breaking to the ecosystem, and break the TypeScript design guides which were mentioned in the issue template.",0,0,1,0,0,0 955576538,This is going to just cause more questions now. I mean anyone writing an angular app that has to fork an angular library will be wondering how they build that angular library and get the code into their app. The assumption that this problem goes away because Angular supports workspaces won't hold true when the library is externally maintained.,0,0,1,0,0,0 955657476,"same problem for me any suggestion for solve that? some weeks ago, i updated flutter(it was 2.0.5 i guess) on flutter 2.0.5 it's working perfectly but it doesn't work on flutter 2.5.1",0,0,1,0,0,0 956325678,"same issue with XIAOMI Redmi Note 7. For me it's not device specific.",0,0,1,0,0,0 956342935,"[USER] It's in a production, and I can't reproduce it, but a lot of users crash because of it.",0,0,1,0,0,0 956420930,Our production builds are failing with the same error. Seems like we need to revert back to 12.0.1. ng v: [TRIPLE QUOTE].,0,0,1,0,0,0 956443164,Same issue. Anyone has a solution? It just randomly appeared for me,0,0,1,0,0,0 958113929,"Sorry I didn't notice it was using Roboto - I'm not sure to be honest for the reason of the failure. It was just a guess based on the previous time we had a similar issue where HHH bots were failung due to missed backup fonts, but failures could not be reproduced locally. This makes me wonder about the other tests that fail because we were using Ahem. Could those tests be rewritten to use Roboto instead? @yjbanov - I don't believe there is a way already, but we can explore expose some environment variable to skip conditionally only in HHH. Meanwhile I'll close this PR.",0,0,1,0,0,0 960151101,"You are right, but we shouldnt' close this bug - something is wrong here, probably in devtools or Dart.",0,0,1,0,0,0 961325855,[USER] Hi i've just switched and built on Master channel & glitch still happening,0,0,1,0,0,0 949907634,"[USER] `@angular/*` packages seem to be very tightly controlled by Google. Why not communicate that `@angular/animations` is, and we can quibble about wording here, unmaintained. I'd wager that those who rely on it would like to know that it has been ""significantly de-prioritized"" quietly. Why not loudly request community or corporate support? We know where the bugs, flaws, and deficits are. Not sounding the alarm about them outside of issue trackers and using an ""ALL ENGINES GO!"" tone in the documentation/communications is unhelpful and infuriating for the people who have to dig around in the code to see what's really going on. I love Angular. However, the communication issues (policies?) combined with actual bugs make me understand why there's no amount of money most JS, React, and Vue developers can be paid to learn Angular. It's a shame! Angular+NgRx are the best way to structure code for the web. I've described using Angular as running with rocks in my shoes. Very nice shoes that help you run very fast to be sure, but, the rocks eventually leave your toes bloody. Angular has a lot of issues. More than most open source projects. While features like optional modules have been getting a lot of attention, modules are not one of the issues keeping developers from adopting or learning Angular. Poor communication, bugs, and moving slowly on common functionality/features large and small (Zone.js+async/await, no passive HostListeners w\o hacks, etc.) *are* keeping developers out. It's also hard to get a deep insight into what's actually going on with Angular development. That information is scattered across GitHub, Twitter, Medium, a smattering of newsletters, courses, and videos, or, is internal to Google and not communicated to external developers at all. The Angular blog hasn't been updated since early June and the Twitter account is often surface level DR/PR. Reading the Twitter account, the most robust Angular news aggregator, you'd have no idea that a major Angular package like animations is unmaintained. How do you stay truly informed? From the outside it seems like the day-to-day problems/bugs are here to stay. I've never seen a large open source project run like Angular. It's not working. Here's a positive example: This is how I keep up to date with Django development: Typically there are a few posts similar to this([URL]) on the [homepage](https://www.djangoproject.com/) that contains a link to extensive, developer friendly, release notes([URL]) for each release. To compare, Angular's homepage does not feature the latest releases (LTR, latest, or dev/next) and Angular's [release notes]([URL]) are less useful. New features link to, sometimes, several GitHub issues and release notes are not linked anywhere on the Angular homepage. I think this is by design? Hiding the version numbers to keep from scaring off new developers? I think it's time for an Angular Foundation similar in structure to Django, Python, or GNOME's. Thoughts?",0,0,1,0,1,0 721380347,"Sorry, I am not following πŸ˜… I am sure there async implementation, but what difference does it make? πŸ€”",0,0,0,0,0,0 91411117,Why removing this new line?,0,0,0,0,0,0 178075450,"What do you mean? That's a more explicit check otherwise the engine has to run the `ToBoolean` coercion.",0,0,0,0,0,0 628430282,"I wondered about that, which is why I have put this in the info box rather than updating the original instruction. It is possible that we could parse out the current major version of the docs and generate something like: [TRIPLE QUOTE]. Alternatively we could just add a bit more text that says something like, ""or the appropriate version if not latest."" WDYT?",0,0,0,0,0,0 89100022,"This is not bound, so calling it will push into `undefined` or `global` (whichever is inappropriate πŸ˜„). It also doesn't actually notify the parent that something changed.",0,0,0,0,0,0 89540995,Same here. Would it be better to defer to the docs to slim this down? Easier to maintain again.,0,0,0,0,0,0 94244130,So this is because The file doesn't exist. This was also a lint error.,0,0,0,0,0,0 94530810,"[BLOCK QUOTE]. To me I'd say just use when you actually are performing any type of interpolation. That way its a clear signal.",0,0,0,0,0,0 95077008,could you name these anonymous function? It better for stacktraces and profiling...,0,0,0,0,0,0 98040317,"I think for starters you could just validate that an error occurs, rather the exact error message.",0,0,0,0,0,0 103465306,"not possible, this is just a string. This is the whole point of bringing in single quotes.",0,0,0,0,0,0 144482513,This neither should make a difference.,0,0,0,0,0,0 177125324,Masks were wrong,0,0,0,0,0,0 177690515,"These same permutations also apply to `class` declarations, but we probably don't need to test them here πŸ€”",0,0,0,0,0,0 187585644,I take the risk for now...,0,0,0,0,0,0 197067655,hmm yes the guide was wrong `@returns {void}` can't be omitted. Omitting it would mean `@returns {any}`.,0,0,0,0,0,0 202972871,Please follow code format: Add space before and after the equal.,0,0,0,0,0,0 229201743,"You no longer need this argument, as `param` now contains this information.",0,0,0,0,0,0 229203290,"To avoid a breaking change, make this argument optional. In this case expressions are not walked.",0,0,0,0,0,0 290027999,"[TRIPLE QUOTE]. Give it a bit more time. I hardly assume the fs watcher will grab the change that fast.",0,0,0,0,0,0 450379266,That doesn't work because it's in a closure and called later. walkMemberExpressionWithExpressionName modifies members that why we need a copy.,0,0,0,0,0,0 483232179,"This change means you can't merge another declaration of RelativeTimeFormat to type expando assignments to it. The current version already forbids calls with the error ""Value of type { new .... } isn't callable. Did you mean to include 'new'?"". We should stay with the old interface+const.",0,0,0,0,0,0 486716317,"Actually, scratch that. Its feasible to do. The implementation that supports unicode escapes depends on using a regular expression, so is costlier. I have a version I can push that actually tracks on the source file whether it contains identifiers with unicode escapes, and if it doesn't then it can use the existing `indexOf` logic, which should be faster: ![image]([URL] I might wait on that until after this PR, however, as I'd need to also add fourslash tests for find-all-references which could be time consuming and could possibly wait until after 4.1-beta.",0,0,0,0,0,0 488158524,"Per our discussion, I switched this to None for the beta. It turns out that the checker already issues an error in this case, but we can add an exclusion for `undefined`-as-initialiser later.",0,0,0,0,0,0 508084569,"Yep! The JS output is different for each! In `react` `createElement` is used, with arrays or singleton children. In `react-jsx`, the `jsx` and `jsxs` ctors are toggled between based on if the child is detected as singleton or not (in addition to array/no array in the actual argument). In `react-jsxdev`, the `isStatic` parameter passed to the ctor is changed based on weather a singleton child is detected or not. So there's meaningful output to check for all 3!",0,0,0,0,0,0 521664294,"Really picky, so feel free to ignore: I think that a dash makes more sense between the two... (Makes it easier for mass processing of dump files, whenever that's needed.)",0,0,0,0,0,0 522589114,"As far as I can tell, this was actually a red herring because the project's `CompilerOptions` (most importantly `configFile`) have not been calculated at this point. Not sure if there are other comments like this that should be removed with this PR. πŸ˜„",0,0,0,0,0,0 557718620,You might want to drop the type annotation for consistency.,0,0,0,0,0,0 600881122,"I think this might be the right thing to do but it doesn't solve the duplicated comments that come from the `receiver`. You can see the changes to fixtures here: [URL] Also just want to confirm, we call `setOriginalNode` for the helper expressions with the original property access/assignment. Do we still need to call `setCommentRange`?",0,0,0,0,0,0 602584809,"Some sort of comment (an overview of the algorithm / what it's trying to do, or the name of it if this is a well-known one?) seems justified here",0,0,0,0,0,0 609701561,One question i'd like to see answered here is: Does the linker consume both ... ivy partial & view engine code? Or do we have to keep ngcc'ing libs that didn't move to or we can't update to the ivy partial one?,0,0,0,0,0,0 610737087,"This is the code I copied. While here, I deleted the first comment line because it restates the code itself, and reworded the second comment line because I couldn't figure out what it meant until I read the comments on the original PR.",0,0,0,0,0,0 611991969,"It depends. Most of the time we just remove a single key, but in some degenerate cases (like the original issue) we end up removing a lot of keys at once. But it only happens a single time, so probably not worth optimizing beyond what's here now.",0,0,0,0,0,0 617695218,"We’ll have to revisit my comment about newlines after this issue is fixedβ€”you’re right that the behavior is currently unchanged, but I think it’s because of this issue.",0,0,0,0,0,0 622073240,I think it would be helpful to mention that one can still build a library with View Engine and link to some place (where?) that contains info on how to do it?,0,0,0,0,0,0 622203052,"Here, the word tooling is a noun, so it's what uses Webpack.",0,0,0,0,0,0 630371232,"As far as I could tell, it wasn't being used.",0,0,0,0,0,0 635548708,"I could go either way on this replacement. Among paths that require updates, this is commonly enough (1/3 if I had to ballpark it), but the number is dwarfed by the number that require no changes at all (in which case this is a wasted string traversal). I measured it both ways and the difference was less than the margin of error.",0,0,0,0,0,0 636227586,"That's reasonable. How about still adding a comment mentioning this? I think we want to clarify in the code why we handle the `v` prefix here, if the release tool never generates such tags.",0,0,0,0,0,0 636268831,"I have done this in most spots, except where the other classes were part of a pre-existing check.",0,0,0,0,0,0 643492324,"I've changed this wording because it's no longer relevant to this patch. This patch doesn't add anything for disposing of layers, that will be coming in a separate patch. To start to answer these questions though - if a repaint boundary disposes its layer, it means that repaint boundary is going way and won't be drawn again without getting completely recreated/repainted. And so if it has any child repaint boundaries that have not been moved to some active part of the tree, they will not get drawn again either unless recreated/repainted.",0,0,0,0,0,0 645709185,is this method used?,0,0,0,0,0,0 646153713,"I thought the `unknown` is better: If we add type parameter `TMessage ` into `editorService`, We should also add the type parameter into `Project` and etc. Too many changes. And we are not really care about the type of message in `editorService`. We just forward session into pluin. And the `handlers` or `addProtocolHandler` does not have `TMessage ` too. Thay are raw string.",0,0,0,0,0,0 646869569,Nothing. There was no text displayed before.,0,0,0,0,0,0 647459518,"there's probably a platform-independent package on npm that does recursive file string search, although feature-detecting grep vs findstr would work too.",0,0,0,0,0,0 648600427,"I think there is a typo here. [TRIPLE QUOTE].",0,0,0,0,0,0 648718343,"I see, you want it lazily instantiated, but it's nullable.",0,0,0,0,0,0 650324271,I slightly prefer the current way since they're describing 2 different things and splitting them is clearer.,0,0,0,0,0,0 651825748,I have added a commit that ensures this breaking change does not happen.,0,0,0,0,0,0 654063677,"This would be a good place to explain that the current default text styles are based on the 2018 version of the Material spec and that there's an older set of text styles from the 2014 spec, that are still available for the sake of backwards compatibility [please phrase this point more clearly].",0,0,0,0,0,0 660057651,"I see. I've made the changes btw, would you like to modify anything else?",0,0,0,0,0,0 661807584,[USER] are the new mechanisms sufficient to test your concerns?,0,0,0,0,0,0 663161588,[USER] That was the problem. I had ro choose between no closing app snd force close by restart.,0,0,0,0,0,0 665753762,I stole it from [USER] review of another null safety migration.,0,0,0,0,0,0 666639103,"why not? The reason to use it is not because it's used in multiple places, if that is what you mean; The reason is so that the user may have access to the default value rather than have his own const based on const, and have to worry about the flutter team possibly changing it in the future making his constant deprecated. imo that should be the behavior for all default values.",0,0,0,0,0,0 668292314,"Is this not the case on web? We should probably explain why this is the case here.",0,0,0,0,0,0 670172856,iirc [USER] added the reveal caret logic. I think at some point I tried to account for phone rotation (portrait -> landscape) but didn't end up doing it for reasons I don't remember.,0,0,0,0,0,0 671720713,"The guide specifies that the elements enter from top to bottom but if the stagger value is negative they are inserted from bottom to top [stackblitz example]([URL]",0,0,0,0,0,0 671823789,FYI the merge window for v13 is expected to open in about 3 weeks.,0,0,0,0,0,0 672800194,Is this import needed? It doesn't look like this is used in this file,0,0,0,0,0,0 673358149,"is this for message/debug only? if so, maybe name it debugToolKit",0,0,0,0,0,0 675549714,"So as far as I can see, this function is only here as a reminder of what the generated code (in `generatorTest1()`) is supposed to represent, yes? Is it actually needed?",0,0,0,0,0,0 678000128,"I was thinking it's just an option for a minor to move directly into RC, but it should be still possible to go into feature freeze. or do you think we should not permit feature freeze for minors at all?",0,0,0,0,0,0 680238700,Talked offline and decided to generate a diagnostic for every output which is enclosed by brackets.,0,0,0,0,0,0 680243841,"Both should work (they're just different config locations, both are essentially system-wide - one's just for your user, one is every user) - I guess it depends on how you have it installed as to weather you have rights for the system-wide one.",0,0,0,0,0,0 680262520,"If this doesn't make sense, we probably need a hook, something like didInitializeScrollMetrics",0,0,0,0,0,0 680511343,"In the context of ServiceWorkers, it might be more appropriate to say ""get rid of"" or ""deactivate"" or ""unregister"".",0,0,0,0,0,0 681918655,"Theoretically, sure, but we explicitly state in our public API guarantee that [extending Angular classes is not supported unless explicitly documented]([URL])",0,0,0,0,0,0 683845128,I don't think there are any formatters (even dartfmt) running on flutter/flutter (plus I hate how clang formatter mangles Obj-C blocks). Let me shorten these up.,0,0,0,0,0,0 687913270,I didn't notice userUpdateTextEditingValue is abstract method. yeah this should be fine.,0,0,0,0,0,0 688167053,Nit: I think we can also remove this dependency from the associated build file. It's good to do that to keep individual targets as small as possible where we can.,0,0,0,0,0,0 688659258,"I knew that was going to be confusing. I'll add some docs about it in both expandSelectionTo and extendSelectionTo. Basically, ""extend"" moves the extentOffset while holding the baseOffset fixed, but ""expand"" grows the selection to include the given position. If you try cmd+shift+left/right on a Mac, that's expand, while option+shift+up/down is extend.",0,0,0,0,0,0 689744876,Looks like a copy and paste error here.,0,0,0,0,0,0 689900306,"This is preferable as enabled_branches is straight forward, but if for some reason in the future we need more advanced logic it should rely directly on the backend.",0,0,0,0,0,0 690612198,I've tweaked the wording to avoid this.,0,0,0,0,0,0 691686003,"[USER] Sorry for the delay, i noticed that to do a test for a different locale i have to use GlobalMaterialLocalizations and GlobalWidgetLocalizations as delegates who are localized in flutter_localizations package and i don't have that package in flutter test, so i tried to add the test in flutter_localizations package, but i dont have the SemanticsTester class right there, should i move this class to flutter_localizations package tests or that would be a bad approach?",0,0,0,0,0,0 692425492,TBH I haven't checked the extensiveness of all of these. The logic LGTM and any missing cases here are very unlikely to be hit.,0,0,0,0,0,0 697027169,"If you’re sure you’ve written the `excludes` correctly, you can keep it. It’s just so easy to make mistakes with that.",0,0,0,0,0,0 697679220,"I may be missing it, but the only place I see this used is: [URL] [URL]",0,0,0,0,0,0 698571620,"Hm. Are we missing a link? If so, let's add it! Can you tell me where the example is?",0,0,0,0,0,0 698951980,This is a bug and I add an assertion to check this at line 580,0,0,0,0,0,0 702188065,Note: I checked the collaborators page and this change seems not to have broken anything,0,0,0,0,0,0 703555285,"Hmm, I think the `build` of the `NavigationDestination` sort of already serves as an example since it uses a `NavigationDestinationBuilder`",0,0,0,0,0,0 705796405,"On a different thought, the json probably needs to be a map anyways. We need to added a global timestamp to the message in the future to help with synchronization: [URL]",0,0,0,0,0,0 705875828,No idea. It's still a hard choice to make when an index is strictly within the replace range. The old implementation works in most cases I think.,0,0,0,0,0,0 706154128,Why is it not `row.onLongPress`? The `onSelectChanged` was written this way because it needed to use a parameter.,0,0,0,0,0,0 709391880,"I don't have familiarity with this code, [USER] may have opinions.",0,0,0,0,0,0 709632217,"Thanks, that example is a good explanation. I intentionally limited property access lookup by the type of the receiver in order to keep precision high. So the example is working as intended. Let's move lexical lookup to a separate issue+PR pair. I think it might make sense as a separate feature [1], but not as part of this one. [1] Some questions I'd like to see discussed there: 1. How much does it improve real-world recall? 2. How much does it hurt precision? 3. Should it only apply to #privates? 4. Does iterated lookup hurt performance? (Probably not, but worth thinking about a little.) 5. When the type is explicitly any or unknown, shouldn't the editor first suggest a specific type or narrowing for the receiver?",0,0,0,0,0,0 709635515,"This isn't intuitive why it is the correct thing to do, we should probably add a small comment.",0,0,0,0,0,0 709702484,"No, we can't use it in that way",0,0,0,0,0,0 711819706,"Not particularly related to this PR, but this code was improperly formatted.",0,0,0,0,0,0 713436265,"Ah yes, the transformed code also reads much nicer now too. I like it.",0,0,0,0,0,0 714187726,I don't think this is testing anything now that `validate` doesn't use `sdkManagerPath` anywhere (unless I'm missing it).,0,0,0,0,0,0 714963867,"this error message should change to ""must be a private identifier or of type any, ...""",0,0,0,0,0,0 715260893,can we deprecate this old overload please?,0,0,0,0,0,0 715947790,This is the main bug fix. We use the whole expression rather than just the receiver's name.,0,0,0,0,0,0 716055400,"Right, there was code to set the flag, but we never examined it. We must have used it at some point, though I don't recall what for.",0,0,0,0,0,0 716656836,"Yep, I supposed that. I am really talking about a bit different thing. I am targeting the easy availability to destroy a module instance to release the used memory even though a router creates this module instance. I mentioned it here because there are some shared synergy areas.",0,0,0,0,0,0 716663160,Not that it makes any difference since we are not publishing links to this stackblitz in the docs.,0,0,0,0,0,0 716709680,"""without manipulating the DOM"" sounds confusing (and even wrong) here imo. The previous wording (""without the DOM moving things around"") is marginally better πŸ˜… It is not about the DOM here (i.e. the extra styles discussed here will not affect the DOM). It is about how the DOM is rendered. So, how about: [TRIPLE QUOTE]",0,0,0,0,0,0 719651616,I added this one while resolving merge conflicts,0,0,0,0,0,0 720426851,"1. Good observationβ€”project loading is super expensive, so that definitely explains why the numbers we were seeing were so bad. We definitely don’t want to load projects if we don’t have to. 2. Yes.",0,0,0,0,0,0 721318488,"sure, so what about I revert such changes if there are no good reason to change this part ? cc [USER]",0,0,0,0,0,0 721591565,"I don't believe the InputDecorator classes have used the term ""segment"" before. Best to use existing terminology (here and elsewhere).",0,0,0,0,0,0 722596832,"I think it would be good to match this example to the template one above: [TRIPLE QUOTE].",0,0,0,0,0,0 724509217,I think it still kinda does - all children to the right will also not contain the position.,0,0,0,0,0,0 729850629,"Oops, done!",0,0,0,0,0,0 733031195,"I don't think we need to mention `CupertinoActivityIndicator` in this comment since it's a property of the class. [TRIPLE QUOTE].",0,0,0,0,0,0 736989289,"My suggestion was purely aesthetic, so if it actually makes code elsewhere more complicated, then it’s not worth it.",0,0,0,0,0,0 738863663,Need to follow up on this separately,0,0,0,0,0,0 743225231,"No, not more familiar, I'm catching up with the source issue before I have an opinion...",0,0,0,0,0,0 787095008,"You **should not touch** cache file, please use `Discussions` for questions",0,0,0,0,0,0 791479583,"Still valid, we can get real position from source map, if they present",0,0,0,0,0,0 796964653,"Yes, please debug it, it is easy, just print `items` in `itemsJoinMoreSpacing`, I still think bug in custom plugin",0,0,0,0,0,0 804239823,[USER] I'll try after having some sleep :sleepy:,0,0,0,0,0,0 818776361,Can you try comment non official webpack plugins? Maybe leaking somewhere in these packages,0,0,0,0,0,0 843944916,Busy pong but not forgotten.,0,0,0,0,0,0 844007072,"[USER] Sorry no, you should not got `Cannot read property 'call' of undefined`, if you got this problem, it means bug in webpack or problem in configuration, maybe you can provide configuration (or the main idea how you use module federation with configurations)? Also will be great to look at `output` options",0,0,0,0,0,0 846091718,No bugs here double check your regexps,0,0,0,0,0,0 864574715,"Ah, by the way, it looks like pageExtensions is the best solution to the problem of co-location: [URL]",0,0,0,0,0,0 869729870,I think still make sense,0,0,0,0,0,0 878052358,Writing a wrapper component every time can become annoying. You can use libraries like [USER] or [USER] that wrap the tested component automatically.,0,0,0,0,0,0 880803369,"Because it is expected, and should not be used in this way?",0,0,0,0,0,0 885291829,"I think you could also make the commit message a bit more clear in terms of what's going to be using this new method and defend why it's appropriate to be placed here (i.e. it makes sense for the template type checker to have this method because users of the `TemplateTypeChecker` could use the typing information available there to determine if a diagnostic should be produced). Try to provide the whole context in your commit message so if someone were to look at this in isolation, it would still make sense.",0,0,0,0,0,0 886795776,You could try putting a break point at [URL],0,0,0,0,0,0 888562189,It's worth noting (for later reference) that we can return empty stamp values since the release tool will error if the versions do not match up in the package json,0,0,0,0,0,0 888563478,"To help us to diagnose this bug, please could you provide a reproduction in Stackblitz that we can run?",0,0,0,0,0,0 892341955,Hi [USER] I'm not sure but I think we can remove the `RouterSpyLocation` class of `computed_state_restoration.spec.ts` in this PR. What do you think ?,0,0,0,0,0,0 899669278,"Duplicate of or strongly related to #32693, although the particular suggestion of β€œautomatic case analysis” reminds me of #25051.",0,0,0,0,0,0 905778690,"I never said it's easy, only that it's expected functionality that worked in v4.",0,0,0,0,0,0 907576836,"[BLOCK QUOTE]. But it's not. You have the same issue in JS: You optionally want to set a property. You don't want a property with an `undefined` value, you either want a proper value or the property not exist in the first place. This is what `exactOptionalPropertyTypes` means.",0,0,0,0,0,0 907844652,"As I understand this is intended behaviour, I will close this issue.",0,0,0,0,0,0 910240086,"That doesn't look like an issue with TypeScript, but with Angular.",0,0,0,0,0,0 913680957,"[BLOCK QUOTE]. What is your problem solving? [USER]",0,0,0,0,0,0 914253243,"Because the problem in other place, what is the problem with waiting an answer?",0,0,0,0,0,0 917914576,Can you share the stackblitz URL to reproduce this issue?,0,0,0,0,0,0 918060752,[USER] I found this improvement idea during the investigation of #14203,0,0,0,0,0,0 926737277,"Anyway, to your point about not liking `""types""` or triple-slash references, I think `""include""` addresses your concerns about each of those? You’d have to specify node_modules as part of the path, which is unattractive, but not problematic as far as I know: `""include"": [""node_modules/custom-lib-module""]`",0,0,0,0,0,0 928194070,"[BLOCK QUOTE]. Can you clarify what the RxJS approach is here?",0,0,0,0,0,0 931217774,Another one...,0,0,0,0,0,0 932234983,"[BLOCK QUOTE]. We can't do anything about that in webpack. We throw the error to make it easier to find the problem. Without the error this would lead to hanging builds, since the loader waits on it's on response.",0,0,0,0,0,0 932587516,"Confirmed that VS Code does not inspect `locs` if `canRename` is false. [USER], any concerns about this on the VS side?",0,0,0,0,0,0 938896893,[USER] what is the state of this PR now? Are there other smaller PRs that should be merged first? What are the remaining tasks before getting this ready to merge?,0,0,0,0,0,0 938914977,"Wouldn’t this have more to do with your build configuration? You can disable renaming/obfuscation to accomplish this or configure the js compiler / webpack to specifically not rename these, no?",0,0,0,0,0,0 939298700,This issue is 18 months old and is under-specified. Closing for now. If there is a desire to actually implement this we can reopen it.,0,0,0,0,0,0 939559157,"[BLOCK QUOTE]. exactly - that's why min and max ignore it Let's say it will not ignore it - then we will get an error that 'dada' is violating min and max at the same time - where is logic in that?",0,0,0,0,0,0 944834490,"This isn't a bug, you need to pass `S` as the type parameter for `Uppercase`. `Uppercase` is just `string`.",0,0,0,0,0,0 945152375,"No direct solution yet. Flutter needs to fix this. However, wrapping the custom scrollview in a notification listener, and then a gesture detector seems to do the trick. [TRIPLE QUOTE].",0,0,0,0,0,0 945408262,"Would be great if you could provide some specific technical details about the issue, or at least from your computer, I also have 6GB of RAM and it works perfectly",0,0,0,0,0,0 945514943,"[BLOCK QUOTE]. @shiv-k-sharma Not yet. Still waiting.",0,0,0,0,0,0 945862233,"[BLOCK QUOTE]. [USER] What is the strategy for cupertino-looking widgets from flutter core going forward? Seems like a strong statement to stop building them since many people expect/want/use it.",0,0,0,0,0,0 946655147,[USER] Do you know when this will get assigned a milestone?,0,0,0,0,0,0 946976557,"This was my original fix for this in the framework but I closed it as not ideal: [URL] I'll investigate an engine solution as I look at [URL] as well.",0,0,0,0,0,0 947603521,"So what is the problem? [How to remove hash (#) from URL in Flutter web]([URL] If you don't want to install pacakge just look inside [source code]([URL]",0,0,0,0,0,0 948547720,"Hi, It was an antivirus problem when extracting the dart sdk file. Thanks",0,0,0,0,0,0 948928192,[USER] I still can’t reproduce thisβ€”do you have a repo you can share where this is happening?,0,0,0,0,0,0 949060837,"[USER] [BLOCK QUOTE]. Yes (thank you [USER]!) [BLOCK QUOTE]. It is in stable and beta. [USER] [URL] narrowed it down to [URL] which rolled in [URL] first available in 2.4.0-4.0.pre. We have one confirmation this now no longer reproduces in master: [URL] For anyone else seeing this issue: can you confirm it's fixed on the master channel? [ BLOCK QUOTE]. It seems bad enough to warrant a cp to stable, but I don't think it's baked enough, I want to see if any bugs/crashes fall out. So yes, a cherry pick to beta for now.",0,0,0,0,0,0 949085220,It doesn't really make sense to distinguish a missing getter from `| undefined` because that get accessor will always be installed. You might be better off mirroring the type of your class and using optional properties.,0,0,0,0,0,0 949996712,"[BLOCK QUOTE]. No it isn't. [BLOCK QUOTE]. Because it's asking for exactly the same thing.",0,0,0,0,0,0 950156251,I didn't add any thing in that file,0,0,0,0,0,0 951751815,"[USER] okay thank you, I've solved the pdf issue but how about the image ?",0,0,0,0,0,0 953066464,"Glancing quickly, I'm not able to find any big differences between the most recent traces, and the one in my initial report, but here is a recent one: [TRIPLE QUOTE].",0,0,0,0,0,0 953364092,"We're going to close this PR since it's out of date, but the issue remains open and is still being discussed.",0,0,0,0,0,0 954029572,"[BLOCK QUOTE]. Because users need to go to the next page?",0,0,0,0,0,0 954267585,"This is potentially a couple of days of work. We also need the additional bot capacity for try. [USER] can we add one linux android test bed to luci.flutter.try?",0,0,0,0,0,0 954660070,"Hi [USER] Thanks for filing the issue. please share your output of `flutter doctor -v` and a minimal reproducible code sample to investigate further. Thanks",0,0,0,0,0,0 954670030,"[BLOCK QUOTE]. @briankariuki Can you please share the logs ?",0,0,0,0,0,0 955061722,Will look at the device when I am at the lab.,0,0,0,0,0,0 956350106,"Debugger.skia.org is helpful there but it might be possible for tooling to look at the skp and list expensive operations, at the very least repeated calls to saveLayer",0,0,0,0,0,0 956436204,Closing this as this was an unreliable indicator and one that has gone back to zero.,0,0,0,0,0,0 956477956,"[BLOCK QUOTE]. This is what I assumed but wasn't sure of. I don't know what code patterns trigger the tooling in a way that requires the comment to be present, so I wasn't confident that both repos actually needed it. Intuitively, I would have expected that _only_ VS Code needs any of these comments, since that's the place where this data actually gets sent to telemetry.",0,0,0,0,0,0 956618387,"Oh, I know, but we could have a check sequence like 1,2,1,1,1,1,... and previously we'd have marked it as deep (5x repeated 1), whereas because of the 2, now we won't.",0,0,0,0,0,0 956655779,"Ahh not yet, I wil try to get to it soon.",0,0,0,0,0,0 957179488,"[USER] Can you upgrade to latest stable and try again to see if you still get same error or not ?",0,0,0,0,0,0 957199696,[USER] I have not seen this yet but you need to figure out the possible new keyboard vendor string for those devices.,0,0,0,0,0,0 957387009,When is this going to be in the stable branch?,0,0,0,0,0,0 957476351,"[BLOCK QUOTE]. All work has some priority, but whether something has a hard requirement by a certain date or not affects that priority.",0,0,0,0,0,0 957484835,"Since this problem only happened on me. Therefore, I close this issue until someone encountered same issue or what I confirmed.",0,0,0,0,0,0 959731063,None from me,0,0,0,0,0,0 959811007,Maybe we should call this out more explicitly in the stable blog post. There’s a section about the broader Promise/Awaited changes but the type parameter change isn’t specifically mentioned.,0,0,0,0,0,0 959814140,"This may have the same root cause as this one: [URL] It seems that no touches within a `SliverAppBar` are recognized while scrolling. This includes: - Back/dismiss buttons - Action buttons - Custom gesture detectors in the title widget - iOS Status bar taps (for the tap to scroll up gesture) My guess is that the logic that prevents, say, a button within a scroll view from getting pressed if the user taps during scrolling is not distinguishing between slivers that are moving and slivers that are fixed in place. It seems to me that the proper behavior is that any sliver that is fixed in place ought to be able to receive touch events even while the `CustomScrollView` is scrolling.",0,0,0,0,0,0 961327890,"Uh, depends, what compiler options we talking about? We only add the implicit whole-module `default` member to the import if `allowSyntheticDefaultImports` (or `esModuleInterop` or `module: node12` or `module: nodenext`) is set.",0,0,0,0,0,0 660012447,"Yes, we don't currently use our knowledge of what T is. We could add this feature later if we decide we really like it -- dartdoc does have enough data to figure this out. Though in this case, since T is defined as ""extending Object?"" it won't have an operator+.",0,0,0,1,0,0 912949518,"I think it is definitely possible to write a migration for these cases, but I don't think it is trivial. So we would need to plan the work alongside prioritising other work.",0,0,0,1,0,0 86189573,"Arf :/ @sokra Should I make a PR to fix it?",0,0,0,1,0,0 183173801,I'll work on it tomorrow,0,0,0,1,0,0 483122434,Can you put here test case? I will help,0,0,0,1,0,0 616418092,"Hopefully these changes will lead to `export { LoaderDefintion }` being generated... But maybe there is also a bug in the type generation. We didn't export generic types yet...",0,0,0,1,0,0 639680771,[USER] I made the suggested changes. thanks!,0,0,0,1,0,0 654733052,Thanks for additional info πŸ‘ Let's keep it.,0,0,0,1,0,0 666441728,"I am not so certain about why we need to remove this code. If this is indeed a bug fixes, we should have a test for this.",0,0,0,1,0,0 672677368,"I agree, they're not very comprehensive. They are supposed to be smoke tests to make sure that we're generating at least a minimum of the output for each of the platforms without the test being too fragile. I added them because some symbols I was depending on have disappeared/changed names in the past, and because we didn't have any tests at all for the keygen script. Just having a test file makes it more likely that tests will get written, even if it were just ""exit(0)"".",0,0,0,1,0,0 674339040,"In fact, I’m confident that this comment is the reason I had it in my head that I should not check the cancellation token tens of thousands of times in a row in a loop.",0,0,0,1,0,0 676946399,"Please have a look, I hope it's fine now :slightly_smiling_face:",0,0,0,1,0,0 678610731,Adding a negative test case would be a good idea too. i.e. `should not produce banana in a box warning if written correctly`,0,0,0,1,0,0 679543716,"Thanks, re-added! One day my LSC script will support not overriding these :)",0,0,0,1,0,0 686244585,"Yes, thank you! I just updated with all of the constants from Android together. Hopefully more readable. :)",0,0,0,1,0,0 699604800,"It's be great to add a comment here to explain why we strip `index.html`. We do remove the `index.html` once there is nothing else at the end of the URL string, it'd be great to include that into the doc (why we do that). Also we can probably add tests for cases like `[URL] to verify that we do not remove `index.html` if it's in the GET params part of the URL.",0,0,0,1,0,0 716553951,"I think it might be worth, given that this is a public API, explaining what it means to create an NgModule without providing a parent injector. AFAICT it uses `getNullInjector()` instead.",0,0,0,1,0,0 720548093,I don't know that we ever run this command with asserts. Perhaps this should be an explicit integration test?,0,0,0,1,0,0 801994480,"Cool, let me study awhile for write js test code.",0,0,0,1,0,0 802483839,"Sorry for the wait. What exactly would you need from me?",0,0,0,1,0,0 814679266,"I'm happy to help, if you could share what kind of error in our code you suspect is causing this problem. All I noticed, is the difference in how the generated code references the imported modules: The problem identifies the modules by using a (local) variable `types` and the variable seems to be undefined: [TRIPLE QUOTE]. But in locations that do not cause an exception functions from the same `types.ts` module are referenced by using `Source_ODS_types__WEBPACK_IMPORTED_MODULE_1__`: [TRIPLE QUOTE].",0,0,0,1,0,0 838829883,You can format this issue as bug report or create a new and ping me,0,0,0,1,0,0 871346978,Interesting solutions :smile: but should work without problems :smile:,0,0,0,1,0,0 873413245,"Thx for the insights, everyone. It is not clear what the specific issues are that would prevent an Angular Component from being exported as a Custom Element and whether they are generic or related to the specific project setup. As such, this issue is not really actionable for us. I believe the main underlying problem is being able to easily consume Angular Elements in non-Angular apps, for which we don't have a great solution yet. This is tracked in other GitHub issues though (such as #25421 and #33942), so let's close this one and track the problem there.",0,0,0,1,0,0 875412183,"[USER] hey, I'm planning to fix the test, just it will take some time. thanks",0,0,0,1,0,0 881783556,"I don't think we will address this feature request specifically, but we do plan to simplify our bootstrapping API, and will consider this redundancy when we do.",0,0,0,1,0,0 888568205,"[BLOCK QUOTE]. I'm still trying to determine which module it is coming from, but I pointed right at the place where the error is being thrown which should be easy enough to fix.",0,0,0,1,0,0 912886132,I guess it's might helpful to [USER],0,0,0,1,0,0 912959563,"Let's keep, we should improve this",0,0,0,1,0,0 919265559,"If you need help, please provide full steps to reproduce",0,0,0,1,0,0 920476873,"[BLOCK QUOTE]. Let’s try to get this in this PR if possible. Preventing runtime errors seems high priority to me. I personally like the idea of an open-ended interface, but I think that warrants some design discussion to make sure we’re all on the same page. Let’s discuss at Friday’s meeting.",0,0,0,1,0,0 920671743,"Hey [USER] I am a typescript beginner and want to contribute here, could you guide me where to start?",0,0,0,1,0,0 922004437,"Anyway, don't want to join the back and forth of that other thread. We may very likely utilize my linked patch for our migration - if so, I will report back on whether we found it to be as useful as I suspect it will be. Hopefully that might provide the conversation with a real-world case study of these changes",0,0,0,1,0,0 924308969,"I'll have a look at this later this afternoon, sorry I didn't see the mention yesterday!",0,0,0,1,0,0 924656052,"If I understand the problem correctly, the issue with the ""else"" branch. Sure, if the number is finite then it's obviously not undefined, but if it's not finite, what is the type? What type should TypeScript use in the else branch? [TRIPLE QUOTE]. [See in the playground.]([URL] But I agree it's stupid :(, hopefully will be fixed soon by #15048",0,0,0,1,0,0 934961472,"The error itself is working as intended, with the caveat that we’re still working on the proper way to work around it.",0,0,0,1,0,0 935287859,This didn't make it into v12. Maybe v13? 🀞,0,0,0,1,0,0 939143685,Come back with some data to back it up if you want us to consider it πŸ™‚,0,0,0,1,0,0 944255137,No! Not a mistake! Just an extra bonus feature that you can implement.,0,0,0,1,0,0 945670969,"I hope these will help you
Camera screen (ArPoisPage) [TRIPLE QUOTE].
Unity page [TRIPLE QUOTE].
",0,0,0,1,0,0 946414559,Thanks! I want to know the reason for that so I can improve my app. Please open that until the reason was found.,0,0,0,1,0,0 946424559,Thansks for the same! Hope this feedback be helpful to.p improve the engine!,0,0,0,1,0,0 946585055,"Hi [USER] I can't see flickering in the video you posted. Could you please elaborate a bit more on the issue?",0,0,0,1,0,0 946878317,[USER] I don't have access to whatever google-testing is - are you able to check the results and let me know what failed (if it's something I need to fix). Thanks!,0,0,0,1,0,0 947752174,"I think you can ask angular team team, I think it is possible",0,0,0,1,0,0 950823798,"[BLOCK QUOTE]. Unfortunately `DraggableScrollableSheet` is not helpful for my use case since I want single items of a list to be draggable and not the whole list as such. [BLOCK QUOTE]. Happy to hear that! Would you say this issue is ""up for grabs"" [USER] ? I would really like to contribute.",0,0,0,1,0,0 950848300,I'm just wondering if anyone's running into this problem and how to solve this. If possible we can create a plugin for handling this kind of problem instead.,0,0,0,1,0,0 950987553,"I want to work on this issue, but I need little help in this before starting.",0,0,0,1,0,0 952019009,I'd also like to extend any help I can provide as well!,0,0,0,1,0,0 952975603,"Hello, I'm sorry to be persistent but was wondering if there is any updates on this issue. Let me know if I can help you somehow.",0,0,0,1,0,0 953424569,"Yes, we are working on that but also need android. I only have access to one Mac and it will be next week before I get to test on it. I do have android though and method channels are not working.",0,0,0,1,0,0 954396291,"To add, this is not something that we can easily reproduce, out of 10 devices in prod, only one device get this issue. However, when I see this crash logs, the app is not killed / restarted like how typically app behave when crashes. Ofc this issue is solved by restart the app. But the app is expected to be used for 24h. Question: are there any ways we can detect this kind of issue runtime? To notify user to restart the app manually themselves. Our users most of the time not brave enough to restart the app themselves without negotiating with their manager or us.",0,0,0,1,0,0 955972112,"[USER] In order to properly address this issue, we would need a complete minimal reproducible code sample without any 3rd party plugin and clear steps to replicate the issue that throws the `null` error, along with `flutter doctor -v`.",0,0,0,1,0,0 958346666,"[USER] [USER] This would be a great optimization to land. If we can get it rebased and updated, that would be great.",0,0,0,1,0,0 958748054,"[USER] Can you upgrade to latest stable and see if you get same behavior ? If so, provide us a complete minimal code sample without using any 3rd party plugins.",0,0,0,1,0,0 960501506,"Hi [USER], Thanks for filing the issue. [BLOCK QUOTE]. please share the minimal and complete reproducible code along with the steps to reproduce the issue. This will help to replicate the issue and eventually find the cause of the bug. Thanks",0,0,0,1,0,0 937914188,"I do understand your advice and I agree with them. However I am not in control of this software I am working on. Users have angular apps compiled and hosted. Then they buy our service and include our script on the page as the first script. We work as an apm tool. Angular app and our script are completely separated, and we have 0 prod dependencies. Also we have our own rollout mechanism and users can disable injection of our script via UI on demand. We are working in sprints and users can only use latest version of our software month in the past. I do get the router instance passed in as a parameter but from a compiled app which is already live in the page. I am able to subscribe to the router events via `router[""events""][""subscribe""](createRouterEventHandler());` Is there maybe something on the compiled router instance that I could use more in this regards? If not at least having stringified event as a name is a second option, which is better than only one option. Event type property would be great if there would be a plan to add that to angular. Would simplify things a lot for us.",0,0,0,1,0,0 947059736,[USER] [USER] Let me know if I missed something from our conversation yesterday. cc [USER] [USER] who are looking into [similar issues with engine managed snapshots]([URL],0,0,0,1,0,0 921046688,We’re now tracking this at #44953β€”a full repro would still be helpful πŸ™,0,0,0,1,0,0 928896400,"Oops, sorry, my bad! However, I have overworked for several weeks(including weekends), and have almost no time left for this PR :( But goods new is that a 7-day holiday is coming, start at 10/1, hope I could finish the reaming work during these days!",0,0,0,1,1,0 947447978,"Ok, I'm pretty sure that the problem is with serializing and deserializing the result, which is done on the main thread. When I changed the kotlin code to only return the first 5 entries (after fetching all of them), there were no lost frames.",0,0,0,1,0,0 703366846,"Great ideas, implemented πŸ‘πŸ» and pushed",0,0,0,1,0,0 716035218,Might have found a solution here: [URL] :slightly_smiling_face:,0,0,0,1,0,0 718870954,ah nice! Was able to cleanup all the tests with this change.,0,0,0,1,0,0 926829428,This got OK'd at a design meeting πŸ‘πŸ»,0,0,0,1,0,0 741886691,not sure that this is ok.. users will need to cast twice,1,0,0,0,0,0 937115980,"As far as I can tell, regardless of whether the stream is typed to allow undefined or not, `async` always expands the type to include undefined and null. I am not sure what might be possible here. I do believe that matching the async type to the stream type would be best, but if that is not possible, then I feel that `T | undefined` is better that `T | null` for `AsyncPipe` return type, ultimately it is the narrower type in the end. I honestly cannot speak to I internal implementation factors here...I don't know what restrictions other angular code may impose here. All I do know, is all my components with inputs are now completely polluted with nulls I don't want and are not appropriate, and as a result I have lost some of the benefits of typescript strict mode.",1,0,0,0,0,0 939221420,why was my issue marked as a duplicate of the newer one lol,1,0,0,0,0,0 859539722,"Your suggestion does not work and no asset file is being emitted by the generator. See my demo-changes and the build log: - [URL] - [URL] My intention of this issue thread is not seeking for help or asking a question, but reporting a bug/regression in Webpack 5 as it has deprecated the `{file,raw,url}-loader`s in favor of native asset modules and currently it's not possible to load assets from within a loader (while loading them from regular imports works - of course). Also, special syntax should not be needed for this, because otherwise it's a breaking change, and this is not documented. And if this is indeed needed, then how is a loader supposed to know when a certain request is an asset and when not? This is not the job of the loader but the module rules configuration and webpack resolving it correctly. ---- I haven't found any documentation in regards to this request syntax and thus took a look at the code and found the responsible parts in the `resolve` hook of the `NormalModuleFactory`. - https://github.com/webpack/webpack/blob/6a4cb8e39d717ef3d710eaebd3db31accf229dec/lib/NormalModuleFactory.js#L353-L374 - [URL] While setting breakpoints and debugging through this code, it looks like a simple type override, but unfortunately it doesn't do anything in this case. The `this.ruleSet.exec` call from above which is supposed to find the rule where the asset type is defined (I think) doesn't return anything either.",1,0,0,0,0,0 93827082,I really don't like this approach. Maybe someone can suggest something better?,1,0,0,0,0,0 961201498,"This issue only happens in android, neither ios nor web. It is an annoying problem, especially you are working with other non alphabetic languages. It is a big problem if your text has to be aligned with other elements. It is aesthetically not acceptable. You can fix it by setting a fixed height in TextStyle as a walkaround, but there is no universal value that you can use to fix the problem for a particular language at all places in your app. You have to try and error to find an acceptable value. Imagine your app is reasonably big and supports multiple languages. Someone has sorted out the root cause in this article. ([URL] Although it is poorly written (pretty sure it is from google translate), it clearly states it is a problem with the flutter engine. The author has submitted a pull request to fix it. ([URL] Unfortunately, it has been rejected. Can Flutter team give a push to fix it? It should be an issue to be fixed ASAP and now there is already an available solution to this. I cannot see the point of holding it up for another year. This is an open issue since 2019.",1,0,0,0,0,0 103417879,That's not ok. Fix your quotes.,1,0,0,0,0,0 106084390,"yeah I would refactor the whole thing. Its currently quite hard to wrap your head around whats happening. Seeing the perf increase it might be worth investing some time to implement Set/Map throughout webpack though :0",1,0,0,0,0,0 161389256,"This is ugly and doesn't quite match the other code, but it was the only thing I could find to make both the linters happy.",1,0,0,0,0,0 169085594,Either remove or include these lines. Don't leave code in comments.,1,0,0,0,0,0 444767599,this should not work,1,0,0,0,0,0 499962528,Seems like it would be ironic to blow the stack doing this and unrolling the recursion looks trivial in this case.,1,0,0,0,0,0 542502640,"Actually, I think I'll make this optional and skip resolving links if it's not provided. I wasn't happy about requiring it, and [resolved] link info is not something everybody needs all that frequently.",1,0,0,0,0,0 553836947,"That test is indeed bad under isolatedModules:true. I do not understand any of the other methods you referenced, so I am not intending to make any further changes to this PR.",1,0,0,0,0,0 555418615,I hate phrasing these recursive relationships.,1,0,0,0,0,0 558641651,"[TRIPLE QUOTE]. now creates a unwanted template literal type πŸ™„",1,0,0,0,0,0 587820028,I hate this ones. Fixed.,1,0,0,0,0,0 637095612,"Eh, why not?",1,0,0,0,0,0 645778936,"I think ultimately this depends on what kind of selection control you're using, so it's not really platform-dependant. Even in `TextField`'s implementation you can override `textSelectionControl` so it's still up to the developer. Anyways IMO we should deprecate this callback and let the `TextSelectionControl` implementation decides how the handles should be built and what interactions it should support. Currently it does not have enough information (as it doesn't have access to the `EditableTextState` that builds the selection overlay).",1,0,0,0,0,0 648393172,"Is this change necessary? If not, please revert",1,0,0,0,0,0 665758802,Not a huge preference. Lets leave it this way and worst case we find its annoying to have the complete link and we can remove it or change it,1,0,0,0,0,0 671564674,"I also think it's ridiculous that some hosts expose it as a function, but I'm not sure how comfortable I am with ignoring that.",1,0,0,0,0,0 718879442,"Dont quite understand this, so not sure if this is required",1,0,0,0,0,0 724512753,"Technically I don't have to smuggle it out at all - I could always rehydrate it by rechecking the conditions on the finally selected child; but saving it off like this results in the least amount of repeated comparisons, so I chose to just save it off here. If you want to blame anything, blame the silly preceding token case - because if it, there's no truly clean structure possible for this code, imo, since it creates this odd alternative condition and hard bail in what's otherwise a straightforward traversal. I'd prefer if we didn't need it, honestly.",1,0,0,0,0,0 737855202,"This looks pretty squished, do you have your line lengths set to 120?",1,0,0,0,0,0 796705240,"I don't know there is the problem, please provide reproducible test repo and step to reproduce, otherwise won't fix, sorry",1,0,0,0,0,0 797457631,"Sorry I can't help you, won't fix for me, I can’t guess and unfortunately I don’t have time for that, if you need help try to reduce your app and provide example of the problem",1,0,0,0,0,0 895623301,"....Welp, you've jinxed it - I restarted by insiders editor to enable tsserver debugging again and now I can't repro it no matter how fast I type.",1,0,0,0,0,0 902565139,How is this still not fixed?,1,0,0,0,0,0 907322213,"Can you show an example of why you'd use a pattern like this in real life? It doesn't seem useful to apply an array spread to an array _literal_, but I'm sure I'm missing something.",1,0,0,0,0,0 919083803,"Unbelievable how TS devs are stubborn on this. On Tue, Sep 14, 2021, 11:33 Daniel Kuschny ***@***.***> wrote: [BLOCK QUOTE].",1,0,0,0,0,0 939298840,"[USER] - is this something you still want? How can we prioritise this work over other? If it is just a nice to have and not really necessary, then I would prefer to close this.",1,0,0,0,0,0 947931216,"Hell no. Yeah it was using a f...ing row instead of a column.....",1,0,0,0,0,0 949069112,"[BLOCK QUOTE]. I don't understand how that is intended, or why `typeof` is necessary. Using `const enum` means `CharCode` is not an object in runtime, referring to it using `typeof` as if it were a runtime object makes no sense.",1,0,0,0,0,0 952764502,Please do not open issues until we finish [URL] there are no problems with webpack,1,0,0,0,0,0 955023614,"I don't think TS even has a way, internally, to track the correlation between the two values here. The compiler just sees an expression of the form `x + y` where `x` and `y` are independent terms of type `string | number` (because it doesn't know which type `par` is) and errors accordingly. Also, please follow the issue template next time.",1,0,0,0,0,0 957898638,"I think hostility/arrogance must be in the eye of the beholder, but it’s probably more productive at this point for me to bow out of this conversation and leave the issue in the hands of those whose behavior I hope you’ll find more palatable. Good luck to you!",1,0,0,0,0,0 958927432,Not fixed since 2016? Seriously?,1,0,0,0,0,0 161791875,Should I remove `will be removed soon`? I feel like it's a bit to much.,1,0,0,0,0,0 336796724,"Aha, going through the baselines, this has a bug! [TRIPLE QUOTE]. This logic should check for how many unique names are in the node members.",0,0,0,0,0,0 101379573,just realized that even the parameter this resembles doesnt even exist :),0,0,0,0,0,0 192954324,"Interesting, I had trouble to find a test case for that, maybe you're right and it's not even needed. The case is: [TRIPLE QUOTE]. Without handling the global referencing another global, the init function will be: [TRIPLE QUOTE]. And with is should look like this: [TRIPLE QUOTE]. It seems to not be required. I need to recheck my tests.",0,0,0,0,0,0 425983552,"[USER] Very interesting, forgot about toJSON. It seems like comprehensively typing stringify is not an option right now. It is tempting though. However, falsely returning `string` for any input value is bad and not doing that would be a vast improvement.",0,0,0,0,0,0 516378121,"Why? This was a sneaky way to flag the checker events that don't get reported in server traces. I was going to use a separate boolean, but realized that the restriction would only ever apply in the checker.",0,0,0,0,0,0 645060469,"Actually, this may be better handled in the Scaffold, see comment below.",0,0,0,0,0,0 666620736,"oh i see, wow. how did that not get caught before.",0,0,0,0,0,0 667115380,"Oh got it, I didn't realize it was only for a single character.",0,0,0,0,0,0 735890067,"ahh, I see they are in the containing scope.",0,0,0,0,0,0 743149916,"I seeβ€”must be a difference with Monaco, because that’s the behavior I was seeing in the Playground.",0,0,0,0,0,0 925391490,"We realized that [TRIPLE QUOTE]. should really error, and this PR makes it legal (`T` is inferred as `[any, any, any`]). While it _may_ be true that object binding patterns never contribute anything useful to type argument inference, it is _not_ true that array binding patterns _always_ contribute usefully to type argument inference. What we really want is for binding patterns to contribute contextual typing information to _other_ inference sources, while never being allowed to stand on their own as inference sources. I’m going to close this and do a full revert of #45719 so we can investigate a more thorough solution in the future.",0,0,0,0,0,0 944038085,"ah sorry I minimized the repro further after my initial post, Just updated that. ... I am shocked to realize you are right, that this is in fact a compiler default - [URL] defaults to undefined, which only shows unreachable code as warnings. However, typescript playground still has no way to actually set that to undefined it seems. So the behavior does differ, just perhaps not usefully. I still hold that it would be much more useful to include a warning about the code being unreachable when narrowing the types to `never`s. Perhaps that shouldn't be error `TS7027` but rather some sort of extension of the ""hey this is never so this doesn't work"" error messages, for those of us working without editor integration.",0,0,0,0,0,0 950360854,Okay... My understanding was overtuned twice... I'll close this issue because it is just duplicate of [URL],0,0,0,0,0,0 956424862,"This was not intentional, but fallout from two things: 1. A quirk in the way the Flutter CLI tool calculates the version on the `master` channel (it only looks at version tags that are on direct ancestors); and 2. The fact that the last beta release was not based on a dev release. To fix this, I will update the flutter conductor release tool to always tag the branch point when publishing a new release branch.",0,0,0,0,0,0 735900904,"Ahh, I see. Let's first discuss whether we should add mockito to the repo then.",0,0,0,0,0,0 688339712,"Ahh, I think this is just some bad file merging on my end. Templates seem fine.",0,0,0,0,0,0 657369594,"Thank you so very much!!! :smiley: yeah also in my PR comment I wasn't totally sure if this was a breaking change but yeah since those can be referenced in js code it does really seem like a breaking change! I also totally agree, that identifying the problem can be quite difficult especially in complex projects, whilst the workaround is straightforward. Another thing that I don't like is that this kind of breaks angular's view encapsulation contract by actually leaking some css unbeknown of the user (opposite to what happens to the native shadow dom). About the scope name being a suffix, I think you are right, I didn't really put much thought on where to put the scope name to be honest (by prefix felt natural as it is sort of what happens with classes, the scope gets put before the actual element), I will amend it :slightly_smiling_face:",0,0,0,1,0,0 391758119,"It's local, so no problem",0,0,0,1,0,0 439591404,"leftover from an earlier iteration, fixed",0,0,0,1,0,0 578248955,"I was about to suggest a MultiMap, thinking this was going to get a lot slower. Glad I actually started reading the code. πŸ˜…",0,0,0,1,0,0 587059740,"Thanks for the notice & discussion! TIL πŸ˜„ , and it makes a lot of sense. This actually ended up not changing much in the output: 107e10d908 only showed a few _very_ edge case tests get a small amount of extra messages. Not so terrible. Phew.",0,0,0,1,0,0 602607176,"πŸ‘ In my defense, `reportError` wasn't there when I wrote this code πŸ˜…",0,0,0,1,0,0 633828940,"Oh never mind, these are deps, not peer deps!!",0,0,0,1,0,0 639302215,"any reduction is good! As long as the number of calls didn't increase I am not too concerned. It's also worth nothing that this test is for View Engine language service, which is no longer the default in v12.",0,0,0,1,0,0 640820577,"Ah yes, I knew I would miss one of those!",0,0,0,1,0,0 645281984,Ahh I had it this way and then mistakenly worried we'd somehow miss some other type of exception.,0,0,0,1,0,0 646943360,"Ahh, got it",0,0,0,1,0,0 661483824,"[BLOCK QUOTE]. This works for me!",0,0,0,1,0,0 705879399,"Oh nvm the documentation was right, it works fine with inverted selections. Many test cases have the selection range inverted.",0,0,0,1,0,0 713826681,"Thanks, I've retained this header so it's in both places the original comment has been split up into, and fixed the spelling error.",0,0,0,1,0,0 725465717,"wow that was a hell of a typo fixed!",0,0,0,1,0,0 798606383,"~~I am afraid it is not easy to fix, even more I think it is not fixable~~ I was wrong, not hard to fix",0,0,0,1,0,0 799352104,"[USER] Yep, it is just workaround",0,0,0,1,0,0 843115609,"[USER] Thanks for your response. I realised that there was something more to that problem that I didn't understand. The incorrect mapping that I was seeing happened when I was exploring a failed React client-side rehydration by following the stack trace in the console. When I tried to reproduce it in a simpler scenario, the dev tools redirected me to the correct source file. So I deleted my comment, but not fast enough for nobody to notice πŸ˜„ Sorry for that. The deleted comment read as follows: [BLOCK QUOTE].",0,0,0,1,0,0 873370671,I try to revert webpack version to 5.41.1. project works fine!,0,0,0,1,0,0 877811803,"Sorry for the delayed response on this. I think you're right, it seemed like it was swallowing the error instead of showing it. I've adjusted my code and everything works as intended. I believe this issue can be closed!",0,0,0,1,0,0 891882719,#resolved I dont know but it is working fine today on that same branch.,0,0,0,1,0,0 896368442,"[USER] I have to say, I'm also disheartened by this. A team could spend a long time building a library and assuming that ""if it compiles, it'll work!"" only to find out after turning `declarations` on that they have a ton of very difficult to solve errors. It's not intuitive and not very much documented that there are such limitations. I'm happy I'm finding this out now by chance.",0,0,0,1,0,0 904153362,I just fixed an annoying bug that would have been caught by this. I was doing string interpolation to construct an URL in CSS. I can't imagine anyone ever intends to load `url(undefined)`. Thanks [USER] for the eslint rule links.,0,0,0,1,0,0 906573092,"[USER] ah, thank you! I bet that’s what [USER] is talking about. The examples I tested all had initializers. It’s a little hard to repro something without a code snippet πŸ˜…",0,0,0,1,0,0 916909700,Just to flag i had this same error on version 4.4.2 on Mac OS 11.5.2. Downgraded to 4.3.5 and error not present.,0,0,0,1,0,0 917040100,"Yes, that's right! I have to admit I didn't even search, I always assume we're the only odd people who care about the comment emit that much...",0,0,0,1,0,0 917608676,"[USER] this work around works! Finally found it after wasting hours searching for the solution. This is especially annoying when trying to wrap a type as a promise, since that also doesn't work correctly with specifying a separate promise-wrapped type. Any new on if this is going to be fixed?",0,0,0,1,0,0 947630112,"Actually it turns out that behavior does not reproduce in master, my bad. So it was fixed, thanks for the support!",0,0,0,1,0,0 948203695,"[USER] I switched the Flutter version to master and it succeeded Thank you!",0,0,0,1,0,0 948322120,"Then I feel it is safe to close this issue. Closing as solved.",0,0,0,1,0,0 948562007,Hi [USER] - sorry not to respond so far on this issue. It is a bit tricky to implement on our side. I need to talk with [USER] about how this could work - I am not sure if it is something we would do. I am glad that for the time being you appear to have a workaround.,0,0,0,1,0,0 950707181,[USER] Alright I thought its an error :),0,0,0,1,0,0 953595449,"I stand corrected, thank you. Although it's quite difficult to figure out what feature came out with what version. The document you linked with ""verified"" only mentions an **expected** year.",0,0,0,1,0,0 955683969,"[USER] God only this work for me. Thanks [BLOCK QUOTE].",0,0,0,1,0,0 958923728,I found a way to resolve this issue not quite efficient but it is working fine! using bloc and creating just one CameraController and also making the bloc acts like a synchronized block and not initialize the camera if there is an active event on it is solving the problem but I guess I can found a better navigation system to not create and listen to the life cycle change in app many times. Thanks for your advices.,0,0,0,1,0,0 594169910,I hate TmLanguage. 😭😭😭😭😭,0,0,0,0,1,0 878122592,"Yes, I agree with your assessment. This is still a bug. But just to manage expectations: since the workaround is straightforward and it seems this bug is hit fairly rarely, it is unlikely that it will be fixed very soon.",0,0,0,0,1,0 94136333,It's sad that this has to be removed. It was intended as documentation of the available parameters,0,0,0,0,1,0 97872933,I forget to change that 😟,0,0,0,0,1,0 128043467,"Yep, I was wrong. Sorry",0,0,0,0,1,0 177723176,"Unfortunately I didn't check it earlier but there are errors in the type definitions. If `context` is defined, then the first argument is not `T1` but the context.",0,0,0,0,1,0 180850694,"Interesting, TIL! Unfortunately, the elegance of this implementation relies on the fact that setting script src produces an absolute URL, even if the original path is relative. Which versions of IE suffer from that problem? According to this MDN table([URL]) IE doesn't support the `crossorigin` attribute, so it could be safely set after setting src. I'll move setting src back to the end, but I think setting crossorigin after `src` is still safe. The alternative might be producing an absolute URL via something like: [URL]",0,0,0,0,1,0 187446670,I don't understand this change,0,0,0,0,1,0 290343159,thought that could be a problem,0,0,0,0,1,0 349088242,"Oh!! Sorry! while I was updating my node version, I touched it!! Lemme Solve it!",0,0,0,0,1,0 562879521,these errors seem worse than before,0,0,0,0,1,0 575596542,Sad! Maybe we should continue to auto-synthesize un-declared symbols.,0,0,0,0,1,0 599231575,"Unfortunately, we changed how we write the type of `keyof A` here, so the only way to validate it now is using assignability.",0,0,0,0,1,0 629528064,"my bad, I saw it was added to the available options in es5 here [URL] so I assumed it would also be in the resolved options at that point I'm happy to move it",0,0,0,0,1,0 640065913,Unfortunately not in a reasonable way. The data is stored in `Cldr._resolved` and we'd need to specify a locale to get access (which I think is odd given this is global data not specific to a given locale),0,0,0,0,1,0 642114763,Yes. My bad,0,0,0,0,1,0 649834230,One person's bug fix is another person's breaking change... but perhaps you are right 😞 No doubt there will be loads of these in G3...,0,0,0,0,1,0 650371928,"I’m sorry, I didn’t understand that? Should I remove the reference to the type of MaterialState?",0,0,0,0,1,0 653426749,"[USER] This is a **breaking change** πŸ˜“ How are we supposed to deal with packages that should work with multiple versions of Flutter that call `buildHandle`. [URL] is such a package and now it cannot work. The change should have been `[VoidCallback? onTap]`, otherwise it is breaking. Should I make a PR and we cherry pick a hot fix for the dev channel?",0,0,0,0,1,0 657432636,"Forgive me. [TRIPLE QUOTE].",0,0,0,0,1,0 657694993,Oops. My bad.,0,0,0,0,1,0 665138134,This makes me a bit sad...,0,0,0,0,1,0 666193520,"Oh gosh, I am so sorry you had to look into things so much because of me :cry: I see what you mean, I will check it and try to place the normalization where it makes more sense :slightly_smiling_face: ( again sorry for not having looked at this well enough :sob: )",0,0,0,0,1,0 671742097,":fearful: you're right!!!!!! sorry :cry:",0,0,0,0,1,0 675514594,"This is completely foreign to me, but I think it is just simply stripping off the last line if the file contains a `sourceMappingURL`, right? Perhaps a comment here would be helpful?",0,0,0,0,1,0 687159377,"I didnt get the logic, the _scheduleShowCaretOnScreen will be called in line 1770 anyway?",0,0,0,0,1,0 690217466,"Sorry, updated.",0,0,0,0,1,0 700599098,"sorry I am not completely sure :sweat: , in what they can help? .... :thinking: I have been thinking but I can't formulate a sentence with ""Wildcard states can help you in/with..."" :sweat: I believe that the sentence as it currently is does make sense in saying that wildcard states are ""better"" when there are multiple states, I just don't think that that is the right word as they don't actually become better, they are give more useful... :thinking: is there something you particularly don't like in the sentence?",0,0,0,0,1,0 707557723,"Yeah sorry I digressed. I was suggesting the json should be a map with a list of deltas. - a map so we can add a fields in the future. - a list of deltas so we don't have to write separately logic for handling batched/non-batched updates .",0,0,0,0,1,0 714195532,"Parser logic updated now. At first I thought going with this approach had broken the tests but turned out the tests were wrong, and this new approach leads to the correct result. When I wrote the tests for this back in Febuary there were not implementations to try, and babel did not get the parsing right (they have now addressed these issues). So I unfortunately developed the wrong intuition for how this syntax should parse when nested within other expressions. Did spot an issue in V8 when trying to compare to what they do: [URL]",0,0,0,0,1,0 716891371,"Yeah I'm not a big fan of the force unwraps, I'm something of a typesafety cultist myself. Sadly there isn't syntax sugar for unwrapping an expression in dart. I wouldn't too worried about the performance cost of an additional local variable, it's the compiler's job to optimize this kind of things I think.",0,0,0,0,1,0 729997614,"I don't think I can, since it is an implementing class. The analyzer is unhappy with it.",0,0,0,0,1,0 732302912,"I agree, although moving all of those properties around (again) will be painful.",0,0,0,0,1,0 736906624,"- my bad you're totally right about the `-foo` I totally missed that :sweat:, I guess it could be fixed with a negative lookahead? :thinking: - about the ` *` and catastrophic backtracking (:fearful:) yeah it's unnecessary, sorry I just sort of got confused there sort of treating `.` as it would not match ` ` :sweat: - yeah, not sure why I put the group there :sweat_smile: :cry:",0,0,0,0,1,0 738719288,"I am very sorry that I so bad at explaining stuff :sweat: what I was trying to say is that I try to avoid using string literals spanning across multiple lines as they more often than not in order to preserve their spacing need to break the normal document's indentation for example in the code I mentioned in my previous comment we have: [TRIPLE QUOTE]. which I don't like too much as it breaks the natural nice indentation of the document (since the second line of the string literal needs to have precisely two leading spaces and the last line zero) so in that case something like: [TRIPLE QUOTE]. would probably look nicer in my opinion (not sure if the `toEqual` block should be less indented, but yeah that's not the point) Anyways it is really unimportant and boils down to personal preferences I guess :slightly_smiling_face: (also I think it doesn't apply to the the comment anymore as the code has already changed a bunch since when the comment was made? :thinking: )",0,0,0,0,1,0 739509440,"One day, we should find an easy/reusable way to easily ask ""is this true *assuming that there are no circularities?"" Today is not that day.",0,0,0,0,1,0 742485985,"My apologies. For testing, I have run the `yarn jest ConfigTestCases` and from my understanding the testing has been done in `ConfigTestCases.tempate.js` file which grabs the files from `configCases` folder and tests them. But still didn't understand what should I update in `test/configCases/emit-asset/different-source` ? Please, let me know about it.",0,0,0,0,1,0 791360637,"You’re totally right, I think `package-lock.json` was playing tricks on me. Sorry for the noise.",0,0,0,0,1,0 793841817,"Sorry, I don't know this repo well enough to create it.",0,0,0,0,1,0 809948282,all your review are worthless to me πŸ˜ͺ,0,0,0,0,1,0 819669744,"Ooops sorry, missed it somehow",0,0,0,0,1,0 822773291,"Thank you for that. Sadly it only changed a word in my output: ""asset"" to ""hidden"" Sad to see the nice table overview of the sizes of the assets gone. Was useful to quickly skim over the sizes row to see if something was wrong. Now it's quick to miss if something got unexpectedly big: [URL]",0,0,0,0,1,0 839753858,"Sorry, I don't think I'll be able to help, since I could not get it to compile multiple CSS files (using mini-css-extract-plugin) with my setup in a satisfying way. The problem is that my CSS files are imported from the JS files, so the _layers_ solution only works if I multiply the main JS entrypoint, but then obviously it also compiles the whole JS again and again for every theme. I worked around it by adding an entry point for every theme, each listing every single CSS file and defining `layer: theme`, so I could define different loader rules based on the `issuerLayer`.",0,0,0,0,1,0 861433761,Duplicate of [URL] unfortunately shared cache is not supported right now,0,0,0,0,1,0 867036924,"Sorry, my example was a bit wrong: I'm reading aliases from the filesystem structure, and they are not static in the webpack config file (so I guess `buildDependencies: {config: [__filename]}` can't kick in): [TRIPLE QUOTE] I could maybe add `/dirname/theme/**` to buildDependencies as well, but it is also quite aggressive to evict the cache if any of the files are updated. --- [BLOCK QUOTE]. Actually, I don't ask webpack to know about external things, but only aliases that I explicitly provide as webpack config. [BLOCK QUOTE]. I totally understand it is a complex problem to solve. I don't really expect it to be solved in the near future and my workaround will be fine. Wanted to document this issue a bit as others might encounter it. I also think the doc could explain better which config changes are supported by webpack caching and which the user should take care of.",0,0,0,0,1,0 873062003,I also need this... Any updates?,0,0,0,0,1,0 873062847,Still nothing... 😭😭😭,0,0,0,0,1,0 877571048,So back to reinventing the wheel every time I need to do this - in a slightly different way each time :-(,0,0,0,0,1,0 880975085,"Thanks for the tip. Unfortunately, because of this and due to there is no support for http multiplexing, I have to write my own service worker",0,0,0,0,1,0 881783211,Unfortunately we're not currently planning to add any features to animations.,0,0,0,0,1,0 891359597,"Ah, sorry, I think there is a minor comment related to the tests that would be great to address, so I'm adding the ""cleanup"" label for now. Another presubmit should not be required since additional changes would be in tests only.",0,0,0,0,1,0 891814919,"[BLOCK QUOTE]. Unfortunately, this is not entirely possible with types, even we fix it, we still have other types problems",0,0,0,0,1,0 895693953,Sorry my bad. Would we just add a new command?,0,0,0,0,1,0 896292481,"[USER] Unfortunately this issue is really only apparently when we actually went to perform the next merge, we will be changing how our infrastructure tooling is generated and consumed so in the future this isn't even a concern, but that is a couple weeks away likely.",0,0,0,0,1,0 898772496,My first impression is that all the extra time is spent on file existence checks. 😒,0,0,0,0,1,0 900894267,"😭 - I am sorry [USER] - this is becoming an epic. I just realised that I don't think I fixed the i18n problem for attributes, only for text nodes. Let me add tests and fix that.",0,0,0,0,1,0 901000739,Unfortunately without profile file we can't help,0,0,0,0,1,0 903120729,"Well, life is complicated, so this issue is not that easy as it looks... @DanielRosenwasser Sorry for bothering, but I want to ask some questions before continuing coding. Or is there an existing design meeting note I missed? Some existing problem I found(or I think it is! Not pretty sure): 1. Property could not inherit JsDoc too, not only setter/getter 2. When we have setter and getter in base class and derived class, and the getter and setter in base class are documented, the description of quickInfo getter/setter in derived class are both combined. I think they should only inherit correspond accessor. 3. quickInfo of getter and setter in class declaration should be ""getter""/""setter"" rather than ""property"" Finally, [USER] should we really use `@returns` on getter/setter? There is a discussion:[URL]",0,0,0,0,1,0 903166962,I'm afraid that is not something I can help you with.,0,0,0,0,1,0 907110947,"Having the same problem in nextjs because of webpack. Compiles fine locally, but fails on server. Please fix this. πŸ™",0,0,0,0,1,0 907623277,"Ok, sorry about opening the issue then. But IMO this is super weird behaviour even with the flag. It feels counter-intuitive that a strict flag makes the code ""less strict"".",0,0,0,0,1,0 913848015,"[USER] thanks I think I'm starting to understand better now, think it's the part about it cascading that made me understand. I don't think any of the articles I've read has mentioned this. Sorry, I posted on the Discord but didn't get a satisfying answer, I should have tried StackOverflow first. Just one more thing though. Shouldn't we change the doc at [URL] ? The bit about it applying to all child directive doesn't seem to be accurate at least the way I read it. So from what I understand, in my StackBlitz with parent set to OnPush and Child set to Default, the reason the setInterval isn't doing anything isn't because the Child is inheriting OnPush from the parent but because the Parent doesn't invocate change detection so it doesn't cascade down to the Child.",0,0,0,0,1,0 916232365,"I think somebody modify URL so I got this problem, I can't reproduce this problem even with broken data URI",0,0,0,0,1,0 918641453,Why was this abandoned? :(,0,0,0,0,1,0 920094505,"Hi [USER] - thank you for your work on this. We discussed this further today and decided that we do not want to implement this feature. We don't control the quality of the sites that we would be redirecting users to, and also this would add more snackbar pop ups which is not a great UX either.",0,0,0,0,1,0 922603520,"[USER] Sorry my bad, clearly I haven't understood enum behavior here.",0,0,0,0,1,0 923543995,"As the OP, apology for not linking to the original bug #38752. Regarding opening this bug, I didn't think the original bug (#38752) was given close attention that it needed. After it was marked external, I replied and a bot closed it, I didn't see a way to reopen it to continue the conversation. I then emailed the issue to some TypeScript more-expert-than-me colleagues at work and there was consensus on the issue was fair. So I reopened this one without any references to typescript-eslint to keep it focused on TypeScript itself. I agree, making a new bug to continue the discussion isn't good. I would like to request a way to reopen bugs or have a second look at them. Any suggestions? How would I do that in the future? Thanks for reconsidering this topic.",0,0,0,0,1,0 924196484,"I'm sorry, I do not.",0,0,0,0,1,0 924896165,Nothing yet?,0,0,0,0,1,0 928082343,"That looks all as expected, so all is fine there. Unfortunately that does leave us in the dark as to what might be going on; we'd need to be able to reproduce this to get to the bottom of it.",0,0,0,0,1,0 930019073,"Right, sorry missed that one. I'll close this. Thanks for the heads up!",0,0,0,0,1,0 934356939,Same here i'm not sure how to solve this.. can someone help please?,0,0,0,0,1,0 945002738,"[USER]... I just realized something :sweat: The division between js/ts and html is a bit flawed, as we can have the html in the component's decorator :cry: (js/ts can't really be present in html to the extent of having eslint comments there I believe) so I may need to rethink that... or just apply the all regexes to all types js/ts/html (I don't see too much a problem with that, except having html comments with js/ts code with eslint comments and vice versa).... ( this could actually force me to restart from scratch :disappointed: ) I am so sorry for realizing this only now... :cry: What are your thoughts on it? ___ or I could just ignore the html comments that could contain js/ts and handle ts in the following way: check if there is a `@Component` decorators and see if it uses the `template` property, if so put a placeholder for the html, run the normal js/ts lint on the file with the html placeholder and reapply the original html but run through the remove eslint-comment function (sort of borrowing the same logic I mentioned here([URL]))",0,0,0,0,1,0 945649905,"Any solution apart from this? [BLOCK QUOTE].",0,0,0,0,1,0 946015294,"Unfortunately, the symbolicated backtrace seems like it doesn't make sense, and we probably can't extract any actionable information from it. Do you have a backtrace with more frames in it, or a small test case that locally demonstrates the issue?",0,0,0,0,1,0 947079950,"I was on vacation, apologies for the delay. If the stable update is near, let's just wait. FYI, Dwds fix: [URL]",0,0,0,0,1,0 947226052,"Yes, this should be closed. Sorry [USER] I’m sad about it too πŸ˜•",0,0,0,0,1,0 947372272,"[BLOCK QUOTE]. Didn't try anything yet sadly, so no.",0,0,0,0,1,0 949082369,"Please, no more plot twists, my heart can't handle it anymore.",0,0,0,0,1,0 950842534,"Any follow-up on this? I made the entire application on Gotham fonts and now it won't work on iOS, any text closer to looking as Gotham can help too.",0,0,0,0,1,0 950886728,Anyone get a solution to this.,0,0,0,0,1,0 951146872,[USER] sounds good! Apologies we never found a more definitive answer to this problem :/,0,0,0,0,1,0 951650211,Help me.,0,0,0,0,1,0 952816078,"[BLOCK QUOTE]. Sorry, I made a mistake",0,0,0,0,1,0 953556510,"Unfortunately I don't have Windows 7 machine / OS to verify and confirm this behavior, so I'll need to directly label it for further investigation from team. /cc [USER]",0,0,0,0,1,0 955179043,"[BLOCK QUOTE]. Yeah, I was wrong, sorry. I'm not familliar with Deno and it seems like the ""value"" propery is just the way the framework your using parses the body. But, If I may have another assumption, you probably need to provide a ""content-type"" header when making your post request to the server on [TRIPLE QUOTE]., like so: [TRIPLE QUOTE]. It should tell the body parser to treat the request's body as json.",0,0,0,0,1,0 957299529,I don't understand what you want to achieve,0,0,0,0,1,0 957306324,Unfortunately this is a showstopper for me. I can't use Flutter as pointer is a hard requirement. I doubt we will switch to Flutter at a later stage once we have a fully functional iOS app.,0,0,0,0,1,0 957820609,"[BLOCK QUOTE]. It turns out it's not that simple unfortunately. Filed [URL] Given that nobody has ever asked for that functionality it's going to be low priority, but it is fixable.",0,0,0,0,1,0 958777099,"I had the same problem, also use A ，😭",0,0,0,0,1,0 959695696,It still not working,0,0,0,0,1,0 955787744,"[USER] I am a Flutter dev for about 3 years now. I really love everything about Flutter, but I really think Flutter or (dartpad) needs something like Expo. I have apps on the Playstore, but I don't have any on the App store. The only reason being that MacBook are crazy expensive. The cheapest you can get here in Nigeria is around 250,000 NGN (610 USD). But with something like Expo, you can test how your app will look and behave on all platforms and even build the app irrespective of the platform Linux, Windows or Mac. I think Expo can also handle release on the App store and Playstore. That's one of the reasons why I think Flutter needs something similar",0,0,0,0,1,0 801669067,Could somebody provide a complete example or link to some documentation please?,0,0,0,0,1,0 802052512,Can someone help me with the failing test please?,0,0,0,0,1,0 629699307,Sorry I forgot to mention that we also need to add tests for the async validators as well (they have the same contract). You can probably just extend this test to add one more custom validator (it'd provide itself as `NG_ASYNC_VALIDATORS`) that would increment a different counter.,0,0,0,0,1,0 714629888,"Regretting that when I disabled all of my extensions to free up some CPU I also disabled the code-spell-checker. I'll reenable, as mistakes like this shouldn't be getting through to the PR.",0,0,0,0,1,0 824966555,"Unfortunately, then I can hardly help you and probably nobody can, sorry. Do you try `--stats-children`?",0,0,0,0,1,0 877496933,"Thank you for submitting this feature request. The team has reviewed the feature request and has decided not to move forward with it. The approach described here would introduce significant XSS concerns and does not align with the angular architectural approach. We do see the need, though, and we will discuss addressing dynamically creating components in other creative approaches that should satisfy this need in a safe and robust way.",0,0,0,0,1,0 908550521,"We'll monitor comments on this issue, but if it wasn't noticed until a full version later, it's unlikely this warrants a patch.",0,0,0,0,1,0 917987679,"[BLOCK QUOTE]. My apologies [USER], a little late to the party. Unfortunately it's my company's repo, so it's private. I'm using `npm`. node - v12.13.0; npm - 6.12.0; [TRIPLE QUOTE].",0,0,0,0,1,0 949804899,"This PR has not received much support in term of votes and, as mentioned above, it is already provided for in a number of 3rd party libraries. So we do not plan to implement this ourselves.",0,0,0,0,1,0 950629088,"Hi [USER] Thanks for filing the issue. Unfortunately, we do not provide support for older versions of flutter, I would advise you to please upgrade to the latest `stable 2.5.3` and feel free to write back if you still see the issue. Thanks",0,0,0,0,1,0 954104040,"[BLOCK QUOTE]. Unlikely since there's a workaround, and it doesn't reproduce every time. [URL]",0,0,0,0,1,0 954481520,"Hi [USER] This issue doesn't seem to describe a bug or a feature request. Please see [URL] for resources and asking questions like this, you may also get some help if you post it on Stackoverflow and if you need help with your code, please see [URL] Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it. Thank you",0,0,0,0,1,0 955770319,"The issue tracker is specifically for bug reports and feature request; see [URL] for a list of other resources where you can get help with your own code. Closing as this is not a Flutter bug.",0,0,0,0,1,0 956449272,"Yes, this is happening because the SW strips off request headers. This is being tracked in #24227. Closing as a duplicate of #24227.",0,0,0,0,1,0 98041125,But I cannot catch the error 😒 .,0,0,0,0,1,0 888903136,"[USER] Hey did you find a solution to this issue? I am facing a similar issue during the compilation of app using webpack 5, [URL] [USER] Please see if you can provide any inputs. Thanks,",0,0,0,0,1,0 908178680,"same problem happened to me, did you fix it?",0,0,0,0,1,0 914234942,"nothing, but some part of the angular break this functionality that is why I am asking the angular team about it and not stackoverflow",0,0,0,0,1,0 927257879,[USER] how you fix this problem? I meet the same problem,0,0,0,0,1,0 948315684,I have the same problem. any update?,0,0,0,0,1,0 960665789,I am also facing this problem. Has anyone found a solution to this?,0,0,0,0,1,0 917704604,I can't actually even build the libraries...,0,0,0,0,1,0 86515132,"Interesting, we don't use that anywhere in the schema at the moment. Will try out if it works.",0,0,0,0,0,0 175115024,This is weird. Just add the `parser` as additional argument to call member methods.,0,0,0,0,0,0 175290087,"Not sure it's the best way to filter out an entrypoint, but it looks like the easiest one",0,0,0,0,0,0 192952534,"Ah I was wondering why, ok thanks.",0,0,0,0,0,0 236088525,`true` feels like magic. Maybe it should be a default value provided to the set or a symbol.,0,0,0,0,0,0 244567313,This is weird,0,0,0,0,0,0 467085009,interesting... I'll fix that,0,0,0,0,0,0 499872328,I'm a little surprised by this - it seems like whatever the editor sends on the specific project is unconditionally overwritten by the host config. Is that intended?,0,0,0,0,0,0 533806843,Interesting.. i thought that would be elided only if O had elided it.,0,0,0,0,0,0 549814226,This was a very strange test,0,0,0,0,0,0 582760126,This is not expected. But I have no idea about that...,0,0,0,0,0,0 598752673,I don't understand what you mean with that?,0,0,0,0,0,0 623522289,Not sure how that got there! Deleted.,0,0,0,0,0,0 636512072,"Well, it *used* to. I'm not sure why it didn't complain this time.",0,0,0,0,0,0 644243466,"Surprised this wasn't caught by the compiler, but thanks.",0,0,0,0,0,0 644408851,I don't know why I used it.,0,0,0,0,0,0 650409367,"[BLOCK QUOTE]. Yes, I didn't realise that!",0,0,0,0,0,0 664549260,"Interestingly, `ResourceLoader` is now abstract, along with `get()` so this override does not strictly appear to be necessary?",0,0,0,0,0,0 679530906,Is this intended?,0,0,0,0,0,0 681890997,"ah so you change this line, too? I thought this pr is aiming at the Form.onchange is called after the field value changes, not the CupertinoTextFormFieldRow.onChange? or am I missing something?",0,0,0,0,0,0 682149383,Oh this is a snippet not a sample so no `main` needed.,0,0,0,0,0,0 692353282,"Oh, wow, it never occurred to me that my `OOC` (or other acronyms I use) could be interpreted differently than I intended (in fact giving my comments the exact opposite meaning) 🀯 I wonder how many times I've given the wrong impression to people due to this 😱 Good lesson for me to try to use less acronyms in the future. (Written communication is already nuanced enough πŸ˜…) Thx a lot for pointing this out ❀️ (and sorry for all the scares I've caused πŸ˜‡)",0,0,0,0,0,0 696001650,"Oh strange, the nit was a line break in between 70/71",0,0,0,0,0,0 715866242,Yeah I was surprised by this as well. I don't know what's caused this output to be different; it is generated exactly like this by api-extractor and not touched by a formatter afterwards. I am a bit surprised how a change to the whitespace does not cause golden file failures in the first place.,0,0,0,0,0,0 717814697,"I see, so it will run before the next frame starts. SGTM",0,0,0,0,0,0 720486012,"this got reverted? did you change this, or was it flutter update-packages?",0,0,0,0,0,0 722787651,"Ahh, OK, I'll revert this. Is someone migrating the template too?",0,0,0,0,0,0 733968505,I'm surprised that there aren't more tests to update!,0,0,0,0,0,0 797023712,Hmm yeah I see. That's the weird backward-compat stuff...,0,0,0,0,0,0 818892510,"[BLOCK QUOTE]. Weird, should work, in theory you can try to capture memory usage in watch mode (without this plugin, [URL] so we will understand leaking inside webpack or dev server.",0,0,0,0,0,0 838640650,"I see, make sense... we need think how better to do it, maybe in future we will have more args...",0,0,0,0,0,0 862192637,"So there's no way to workaround it for inline loader? Since there's no way to set `type: ""javascript/auto""` on it.",0,0,0,0,0,0 904224196,"I was surprised you marked it as ""bug"" but then realized it indeed is a bug -- as the renaming refactor produces a compile error! xD",0,0,0,0,0,0 914589705,"Yes I agree, it is not as clear cut as it first appeared",0,0,0,0,0,0 923893956,Nice! I didn't know `content` could accept alt text 🀯,0,0,0,0,0,0 927878841,"[USER] Ok, so just to be clear. That means that noone running Angular 9 - pre-11.1.0 project can use those libs, and there's no way to fix it?",0,0,0,0,0,0 934671785,"[BLOCK QUOTE]. I looked at this with a few others on the team and nobody could quite remember or figure out where the difference comes from within a short amount of time, but we supposed there is probably an old, old PR that would explain it. I will say that it does kind of match my intuition of the subtle differences between object types and interfaces, where interfaces are just presumed to be more class-like. There is clearly not some super rigorous principle that we can appeal to in the abstract hereβ€”the example you came up with does look sort of surprisingβ€”but it is likely driven by heuristics that lend more useful type checking behavior to certain patterns in code that uses a lot of classes and interfaces. Coming up with a more specific answer would require a bit more spelunking into the `git blame` of the checker.",0,0,0,0,0,0 934941507,"[BLOCK QUOTE]. [TRIPLE QUOTE]. should work. The error could be silenced, since it’s really meant to stop you from doing something that’s impossible at _runtime_, but we need to think about whether it’s more or less confusing for type-only imports to be exempt πŸ˜•. [USER] [USER] thoughts?",0,0,0,0,0,0 947478694,"Wait a minute, i'm recovering...",0,0,0,0,0,0 948116812,"Wow, this PR really came back from the dead! 🧟",0,0,0,0,0,0 953237690,"I'm a bit surprised at the suggested workaround since that process is already running in Rosetta, all the executables in question are x86_64. [URL] has merged. If possible, could anyone reproducing this validate that it no longer crashes on the master channel (without the `Open in Rosetta` workaround)?",0,0,0,0,0,0 957072254,see what I said before. I also had this issue before with another project and it magically worked after tweaking random settings,0,0,0,0,0,0 957307796,"wait, do you say if you add it in the compilerOptions is doesn't work, but as a command line parameter it does? that would be.... surprising.",0,0,0,0,0,0 958163863,"Why is this issue closed ? Glitch is not fixed [TRIPLE QUOTE].",0,0,0,0,0,0 958659484,"I find it interesting that even if TS2732 error occurs, the tsc compiler just continues. Surely there must be a way to make it not bother compiling the JSON file, so that we can reference things outside the `outDir`.",0,0,0,0,0,0 671666729,ah wow! sorry I did not notice that! I find this strange thought... it looks like a pretty low level function to be in the public API :confused: What can we do about this? :disappointed:,0,0,0,0,0,0 622382190,"Ummm, me too. Neither one of these functions are specific to jsdoc, so jsdoc-specific code is surprise in both. Probably means that this is good enough.",0,0,0,1,0,0 873033825,"Due to the low priority and low demand for this feature, I don't think we will ever get to implementing it at this point.",0,0,0,0,1,0 873096201,"Yes, regression on our side, please wait, we will fix it in near future",0,0,0,0,1,0 947268725,"Hi there. This issue affects my app quite significantly, as Samsung phones are quite popular. Is there any workaround for it? I would love to help to figure out the issue, but I haven't contributed to Flutter before. Can anyone give any pointers on which areas of the engine (I'm assuming it's a to do with the engine) to look into?",0,0,0,1,0,0 107297025,will check that tonight! thanks πŸ‘,0,0,0,1,0,0 946149649,"[USER] Thanks! I will take a look at it πŸ™‚",0,0,0,1,0,0 959781169,"[BLOCK QUOTE]. Hi there [USER] for some reason _file_ a bug/defect/issue didn't sound right while reading the doc. Mostly have seen usage of either _report_ or _log_ bug/defect, Ha πŸ˜ƒ I could be wrong too. But in my opinion, I felt _report_ sound much better than _file_, even though it is a tiny change.",0,0,0,1,0,0 94140211,"Ah nice idea, that may be the cleanest solution.",0,0,0,1,0,0 94406257,Interesting workaround πŸ˜„,0,0,0,1,0,0 155162450,On it! πŸ˜…,0,0,0,1,0,0 247250572,Every time you comment I realize something new about JS or TS. This is very exciting. 😊,0,0,0,1,0,0 571246442,"Nonetheless, I reworked to make it start at the nearest possible ancestor instead of the source file, and skipped it altogether in cases where neither list element went through a transformation (which is the only way they could be reordered or reparented, I think).",0,0,0,1,0,0 624072499,"I like your suggested wording, [USER] . Let's go with that!",0,0,0,1,0,0 640820626,"Ah cool, I didn't know that!",0,0,0,1,0,0 641000887,"I’m open to suggestions for a better name or for doing this differently, and there’s no reason right now that it needs to be a function instead of a readonly value. The deal is that the emit host _must_ get a non-empty answer when it asks for a module specifier between two files, whereas the language service host can get an empty answer, since it only uses module specifier resolution for auto-import-related things. This allows the two hosts to distinguish those requirements. The name would be much easier to understand if it were inverted, like `requireResolutionResults` or something (still not great), but that would mean it either needs to default to true or be a breaking API change for ModuleSpecifierResolutionHost implementations (which is internal, so maybe not so bad). I initially planned to add this value as a parameter to `getModuleSpecifiers()` et al, but that has weird implications for caching (technically it should be part of the cache key, but in practice, each host should always pass the same value).",0,0,0,1,0,0 666619504,the more documentation the better!,0,0,0,1,0,0 685488755,Ooo this is a very exciting change. There are so many work arounds for this that we could clean up. :),0,0,0,1,0,0 694491680,Also worth mentioning how this interacts with text composition.,0,0,0,1,0,0 699357686,I think these comments are great!,0,0,0,1,0,0 706468634,"Fair, I'll fix this. Previously we couldn't use that because 255 was also special cased :)",0,0,0,1,0,0 707986098,May want to also mention that using this results in more granular explicit set of changes rather than batched together general updates to the editing value. We want to help developers find/decide if this feature is right for them.,0,0,0,1,0,0 715807530,I'll try to find a workaround to remove these 2 imports.,0,0,0,1,0,0 816711243,wow - that sounds amazing.. I will take a look asap πŸ‘ will the result be cached?,0,0,0,1,0,0 873607864,"[USER] Can I try to fix this problem？",0,0,0,1,0,0 889890044,"Hi, this is a great thread read! I have a tokenizer in the deploy stage of my pipeline that replaces and env variable. It seems that this should cause an issue for the SW. Is that correct? Is there a workaround? (the project is already built at this point)",0,0,0,1,0,0 908748646,Giving this a bump because I think it's still an important issue to fix.,0,0,0,1,0,0 910456535,Feels like a best effort is likely better than nothing here. Though I would lean toward showing nothing if there’s an ambiguity as in [USER] example.,0,0,0,1,0,0 916232072,"This is a fantastic feature but what about taking it a step farther and requiring use of the `virtual` keyword on the base class so you can actually control when you want to allow sub-classes to override or not? That could also be an opt-in switch, `noImplicitVirtual`. There are often situations where overriding a function without calling `super` could break the application.",0,0,0,1,0,0 918421589,"I don't think I follow; #33200 is about `Object.values` of enums, but this PR changes `Array.includes`. The problem in #33200 also seems to be about string literals not being assignable to string enum members with the same value. But your object sounds more general. Is it? Discussing that and proposing a solution would be good to do in a separate issue from #33200, especially since that one's already closed.",0,0,0,1,0,0 925049118,"Hi, great progress here. How is it going with merge? I want to encourage you to finish it. It would be unfortunate to stop here. A lot of devs having problems with this. Thanks.",0,0,0,1,0,0 927860156,"[USER] I can help in this, can you assign it to me.",0,0,0,1,0,0 934576358,Hello ! [USER] Please let me know if you are not working on this anymore so that I can take this forward 😊,0,0,0,1,0,0 940400304,"Okay fair comment, that makes sense. I will do my best to get one up and running - thanks! Will try and get it done this week. Inidentally, trying to figure this out myself I came across `extendedDiagnostics` and this showing that all the `node_modules` are being type chcked, wondering if this might be why? Or if there is any useful output avaliable from this aid where to look?",0,0,0,1,0,0 946966708,"Assigning myself while I investigate this. Related: [URL] Maybe related: [URL]",0,0,0,1,0,0 947350117,"You can use [this]([URL] workaround mentioned in same issue to get it working. Or also, try to switch to latest master and run again to see if it still persists or not.",0,0,0,1,0,0 948236795,Okay. I'll do it.,0,0,0,1,0,0 949076777,"I'll reiterate that I'm with ignoring my repro since I probably made nonsense out of the logic while tinkering with it. Obviously, never being slow is the ideal, but it's more important to focus on code people might actually write. Alternatively, we could call this good and file a separate bug to go investigate that repro.",0,0,0,1,0,0 949356494,"[USER] I can help on this, you can assign it to me",0,0,0,1,0,0 949692147,"[USER] Thank you for replay. I've done a rudimentary implementation with a SliverToBoxAdapter and a Stack, it's not ok. I'll try some other way to fix it and let you know if has result.",0,0,0,1,0,0 949781457,"I would be very happy to review and help merge updates to the docs that highlight these known issues, if you would like to send in some PRs.",0,0,0,1,0,0 949956387,Would like to work on this. How do I get started?,0,0,0,1,0,0 950196065,"Clarification on above comment: I was responding to someone who mistakenly thought `code` and `code2` in the repro code were the same variable. That comment has since been deleted, but I left my response in case someone else makes the same mistake.",0,0,0,1,0,0 952939031,"Feel free to give it a go, [USER] πŸš€ (It is still on my TODO list, but I won't get to it for another week or so. I would be happy for someone to beat me to it :grin:)",0,0,0,1,0,0 954592493,"I think it would be better to document a feature after it been released. πŸ™‚ And by the way I'm really exciting about this feature. ❀️",0,0,0,1,0,0 955208564,"we decided to fix forward, so this PR is not needed. closing.",0,0,0,1,0,0 956023992,Thank you for the screenshot [USER] I'll be labelling it for further investigation as I cannot reproduce on my end.,0,0,0,1,0,0 956472417,"[BLOCK QUOTE]. I'm not sure I understand your question, so I'll just answer broadly. Basically, there's an include mechanism for these GDPR comments, but you can't include something from another repo. Since both repos refer to the same fragment, both repos have to declare it. Why have a reusable fragment for a single property? I'm pretty sure there used to be multiple and, I assume, there might be multiple in the future.",0,0,0,1,0,0 957549827,"[BLOCK QUOTE]. This does not necessarily mean that the bug does not exist. Feel free to write back if you encounter the issue again, with some more details and reproducible steps I would be happy to take a look. Thanks",0,0,0,1,0,0 957564557,[USER] Thank you for your reply. I will prepare a new project and I will try to make it have the same issue and provide it for the investigation.,0,0,0,1,0,0 959790258,I have raised a pull request on your fork with the working solution I wrote. See if that help 😬.,0,0,0,1,0,0 699668336,"Ah yeah that is interesting! I didn't know of such a type and actually be googling around it doesn't even seem too well documented! Thanks a lot for mentioning it! :slightly_smiling_face: You did say not to bother but actually indeed having the set as readonly would make things quite more clear I'd imagine, so please if you would prefer me to revert to the old version and have the set as readonly I really really really really really would not mind!!! Please just say the word and I will get to it! :slightly_smiling_face: I think it would indeed make things clearer... on the other hand, in order not to have to parse the css text one time more than necessary I would indeed need to do a passing and return the tuple as I did before (unless there's a better alternative, but I can't think of one...) so yeah it's up to you, just please say what you think would be the nicest solution for you and I will gladly be fine with that! :slightly_smiling_face:",0,1,0,1,0,0 449260392,This is a well-known limitation; it’s not a problem in the context of this PR.,0,0,0,0,0,0 496857126,You forgot to add this file,0,0,0,0,0,0 944511653,"[USER] Thanks for looking! You actually successfully replicated the oddity! Please take a second at your video. :) In the top button the splash is misaligned towards the bottom of the trapezoid. And if you try once again with the changes I made in the linked PR above you can see that it is fixed. At least for this particular scenario and likely for all since the inkwell now used the exact same shape as the parent material. [USER] Any reason the InkWell shape parameter wasn't also resolvedShape!.copyWith(side: resolvedSide); in your merge? And if we are really looking at it. You can see that despite using the same outlineshape the shapes differ. And in fact, the splash of the first shape is the shape of the second trapezoid.",0,1,0,0,0,1 737899679,"I think [USER] suggestion is a good one for suggesting extensions. I don't think I could get this ready for the RC, though. Does it still make sense to include this PR as is? I think the error message without the suggestion is going to remain as is, so that should go in. I think it would only make sense to remove the extension suggestion message/check if we have performance concerns over calling `fileExists`. Is that the case?",0,1,0,0,0,1 949001832,[USER] Thanks for the detailed explanation. Is there a reason to keep the unpopulated and populated entries in the same cache object? Would it make any sense to have separate caches for unpopulated and populated entries? Or is keeping them in the same cache and tracking with separate counts the best fix?,0,1,0,0,0,1 918672907,"I don’t understand, how does it make the code less portable? I use this function to evaluate strings of code and to see how they look when transpiled, and I want the actual result that TS would produce if it was a regular file. Is there a better way to do this?",0,0,0,0,0,1 932608742,"[BLOCK QUOTE]. My ""pleasure"" (I guess :-D ) [USER] [BLOCK QUOTE]. Ah, wow. Sorry to learn that, but thanks [BLOCK QUOTE]. Hehe, that is probably a good thing indeed, but we need to stay realistic until the (featured) templates cover all situations. [BLOCK QUOTE]. Hehe, the report might seem exaggerated, but the current situation is certainly confusing / sub-optimal. If you are referring to a ""merge request"", I have not changed anything, but it seems trivial. Is there a reason why this ticket is closed?",0,0,0,0,0,1 82121251,I am not sure what you mean by that,0,0,0,0,0,1 89186541,It seems like you don't use this require anywhere?,0,0,0,0,0,1 94506335,"not sure, which space are you guys referring to? or should i add one here?",0,0,0,0,0,1 95076433,❓ Not sure if this file should have been committed,0,0,0,0,0,1 97830353,"Done. Strangely, falling tests, when I tried to remove it before",0,0,0,0,0,1 117588007,on second thought not sure i should have switched n and t. it looks like it might change the behavior of the resulting code. but i'm not sure why the output switched either.,0,0,0,0,0,1 138079032,Okay thanks. I wasn't sure about that.,0,0,0,0,0,1 157990120,"Not sure about this. Once `prettier` will land, we won't have to worry anymore",0,0,0,0,0,1 186056719,I am not sure if it is fine to edit an existing test.,0,0,0,0,0,1 191767183,"I'm stuck here, I don't know how to get the used exports [USER] thanks",0,0,0,0,0,1 197090722,"Not sure what exactly to put here, would appreciate some guidance",0,0,0,0,0,1 202604993,Not sure why the snapshots changed...,0,0,0,0,0,1 215908087,This change is strange. Why is there such a big difference?,0,0,0,0,0,1 243922465,Not sure if the test makes sense this way,0,0,0,0,0,1 245948453,"Why is this change made? We want to have caching in the CI.",0,0,0,0,0,1 247910899,"""I thought the original pull request needed just a rebase. I'll look into it. Do you have any suggestions what needs to be done? Also - I'm not sure why there was such a complex test function [URL], the test can be simpler, right? And looking at it some more, maybe `Preserve existing chunk as an entrypoint when it has matching modules` is not a very clear description, or is it? I'd suggest something like `Preserve entrypoint when it has same name as chunk`?""",0,0,0,0,0,1 450314177,"Not sure, maybe better slice on line 2378",0,0,0,0,0,1 453322531,cache results at least for first one.. not sure because of merge result is cached (at least for resolver options),0,0,0,0,0,1 488231078,not sure what is correct now.. web or browser? [USER],0,0,0,0,0,1 494426360,"this error comes from the same information as before, and is just as correct; I'm not sure what caused it to change, though.",0,0,0,0,0,1 539004530,"Oh.... Sorry for the misleading... And, I am a little confused, if there is not any special folder, according to the module resolution [URL] How could file find the correct modules? Did I miss something?",0,0,0,0,0,1 560552229,"Oh, github didn't load the previous 3 comments before I commented. I guess the point is that I think the comment is not confusing, even if the code itself is.",0,0,0,0,0,1 562258053,"Hm, so the user test previously just applied a custom tsconfig to the contents of the `src` directory and built it. That actually includes way more than they typecheck in their own build: [URL] Do we want to continue checking the whole src folder under our own rules like the `user` test used to, or should we use their build like this?",0,0,0,0,0,1 562449136,"Wait, what do you mean? And is this a TS bug too?",0,0,0,0,0,1 572453108,I don’t understand this; can you explain?,0,0,0,0,0,1 583178068,Does this cause us to be any more eager in resolving method types than before?,0,0,0,0,0,1 613450356,"This name is a little confusingβ€”it looks like it’s getting the constraint of a type argument, and then optionally drilling into a property of that constraint type, based on the syntax location of the cursor. I was confused about why we’d want to get a subtype of a type argument when its constraint is necessarily a supertype of it. Maybe `getConstraintOfTypeArgumentProperty` or something?",0,0,0,0,0,1 615399836,πŸ˜• So we should simply ignore private `Symbol.iterator/Symbol.asyncIterator` when checking unused members?,0,0,0,0,0,1 625279107,It doesn't appear to be deleted?,0,0,0,0,0,1 628914459,"I'm not sure why this code is here, and why it is hard-coded to the `/testing/` path.",0,0,0,0,0,1 630039493,Why is the `| null` part needed? πŸ˜•,0,0,0,0,0,1 635391807,"OOC, why move this here? :confused:",0,0,0,0,0,1 644306608,"Sorry, I don't understand this comment.",0,0,0,0,0,1 644370206,Why just the first one? Why not hide them all?,0,0,0,0,0,1 646623642,I’m not 100% sure what the implications are for removing itβ€”we should check with [USER] ad [USER].,0,0,0,0,0,1 651170934,I am not sure what this id is adding. Is this meant to be used in the test?,0,0,0,0,0,1 661682280,Ah I see. But I'm not sure if there's a good way to check if a `FocusNode` is already `dispose`d. It seems fine to keep a `dispose`d `FocusNode` around? In `_applyFocusChange` if either of these 2 nodes are detached from the tree then we throw the entry away anyways.,0,0,0,0,0,1 661718222,"[BLOCK QUOTE]. It sounds like with the current implementation something in the first row should be auto-focused, and then it will be unfocused so the scope is gonna get the focus, and with this patch the second row (or whoever got mounted first and remain attached after the first frame) should be autofocused. I'm not sure what the expected behavior is in this case.",0,0,0,0,0,1 662590100,Yeah that sounds good! I was a bit confused about what `delta` was since there are at least 2 pointers involved in a scale gesture.,0,0,0,0,0,1 662642181,I don't understand. Is the concern that there might be multiple instances of the same component running?,0,0,0,0,0,1 664890186,I'm... Not even sure what's different at a glance,0,0,0,0,0,1 665720185,"Not sure why we're doing case analysis here. The value of `shape` can be any OutlinedBorder, not just one of the predefined subclasses. Why is `shape!.paint(canvas, _thumbRect!)` insufficient?",0,0,0,0,0,1 667366663,I wonder if this comment is still relevant with `textContent` πŸ€”,0,0,0,0,0,1 671719392,I am not sure about this... it looks nicer but maybe it's be better not to use new JS features?,0,0,0,0,0,1 677464104,I am a little confused by this implementation πŸ˜• (I am probably missing something πŸ˜…) Why aren't you using something more similar to [URL] What are you trying to improve on by having two different code paths?,0,0,0,0,0,1 677808605,I'm not sure about adding these. Is this the way to do it or is there a better way?,0,0,0,0,0,1 678661619,Cool! Is the name ok? `ImportMetaKeyword`/`NewTargetKeyword`? I'm not sure.,0,0,0,0,0,1 684542134,It's not clear to me what the differences are between expand and extend from reading the documentation.,0,0,0,0,0,1 685380165,I'm not quite sure what to do with the scale slop right now.,0,0,0,0,0,1 691577537,Why is this here?,0,0,0,0,0,1 706423410,"I see that there are some asserts in here, but not sure if they protect every value test or not.",0,0,0,0,0,1 716230227,"I highly doubt, but I can check tomorrow.",0,0,0,0,0,1 717777299,I thought the scheduleMicrotask will also be pushed at the end of the frame? or am I missing something?,0,0,0,0,0,1 720239843,i'm not sure but i think this part was just trying to match the result of `findRenameLocations`. doesn't look like we _need_ this info.,0,0,0,0,0,1 722392706,Why did you mark this conversation as resolved? I'm confused.,0,0,0,0,0,1 724881472,"I did do this at one point but I was concerned that it is a bit hard to work out the cases for the `if` to succeed, since it relies on `undefined !== 0` in the case where `associatedMessage` is not defined. So I went with the more explicit notation since I found it easier to grok the two cases. Do you not have this problem? Perhaps it is just me?",0,0,0,0,0,1 730257276,This class doesn't seem to be used πŸ˜•,0,0,0,0,0,1 732293262,"Sorry, I'm not quite sure I'm following: you want to make sure that if `errorsAreFatal` is set that `hadWarningOutput` is false in the case where we're going to exit cleanly? So, in other words, making sure that there were no warnings if there were no fatal errors? I was intending for it to be the case that if `errorsAreFatal` is set, but not `warningsAreFatal` that only errors cause failure exit, and if `warningsAreFatal` is set, that _either_ warnings or errors would cause a failure exit (basically that fatal warnings implies fatal errors too). Does that sound right to you?",0,0,0,0,0,1 736878776,"I'm not sure, this test is similar to the previous one for ltr text.",0,0,0,0,0,1 738243449,"Sorry, I am still not following πŸ˜…",0,0,0,0,0,1 787106547,"Yes, `output.devtoolNamespace: 'no_slashes_here'` fixes the issue, by just using something other than package name, thanks. Sorry for bothering, i should probably read the entire webpack docs from start to finish one day. Stackoverflow couldn't help for days. I am still a bit confused, why a default of package name including slashes was chosen, but i guess I can wonder about that after some more research on the topic. Thanks again :)",0,0,0,0,0,1 799785939,"I didn't really run this part of my project on Friday, but I ran it as suggested all day today with no segfaults. I'm a little confused as to what changed. I'm still running the same version of node as I was when using webpack 4 and didn't have this issue. Is webpack requesting a different memory limit of node somehow? Or am I misunderstanding what's going on?",0,0,0,0,0,1 800194469,"[BLOCK QUOTE]. No Problem still exists? Do you try the latest version of v5?",0,0,0,0,0,1 803216554,"I have signed CLA but job is marked as Pending, not sure how to resolve.",0,0,0,0,0,1 829414970,"Seems to be closed in Terser, but not sure if released [URL]",0,0,0,0,0,1 876841286,"I hope I'm wrong, but I don't think this proposal would allow us to solve [URL] according to the mentioned caveat. This is because if my own code set `Validators.required` in a form control, then `@angular/material` has no way to know which function reference to use to check for the required validator presence. Is this correct ? I was under the impression that this use-case was one of the major thing to solve. If associating a validator with a name would properly solve all use-cases, maybe a redesign of the Forms API, that also include all the good things from #31963, should be considered, instead of doing half-measures ? A sort of `ReactiveFormsV2Module` ?",0,0,0,0,0,1 880021733,Jetbrains has their own analysis of Angular templates so it's unclear whether this is an Angular bug or not.,0,0,0,0,0,1 883212345,"[BLOCK QUOTE]. Sorry, I am not sure what you mean by this πŸ˜• Can you please elaborate?",0,0,0,0,0,1 884985610,"[USER] I don't understand you, what is mean `doesn't break windows`",0,0,0,0,0,1 887448093,"[BLOCK QUOTE]. Are you sure about this? I am a little confused based on docs which actually point to `watchOptions` inside `devServer` conf. Also, when I put `{ followSymlinks: true }` in webpack conf, nothing happens but adding it to devServer actually makes my app to recompile (though it does not hot reloads).",0,0,0,0,0,1 910717385,My fault :confused:. What should be the name of the option for this case?,0,0,0,0,0,1 913650309,Is it possible that my issue described here [URL] is related to this issue here?,0,0,0,0,0,1 920818407,[USER] I actually don't understand what is an issue? original issue fixed in webpack[USER],0,0,0,0,0,1 923887913,"We already generate the same name, what is the problem?",0,0,0,0,0,1 927873771,Sorry not to reply sooner. I'm wondering if the benefits outway the effort and weirdnesses here...,0,0,0,0,0,1 930567715,Pull Approve is confused...,0,0,0,0,0,1 932720637,"[BLOCK QUOTE]. I'm not sure why I had to, but I needed the updated deps to be able to run the site locally. Feel free to commit changes to this PR to help us get the CI to pass.",0,0,0,0,0,1 932996602,I don’t really understand what it is you’re asking for here?,0,0,0,0,0,1 933361077,"well... I don't really remember why it was done like this (years ago). I think I'll just use the defaults now, was just surprised that webpack5 behaves differently than file-loader",0,0,0,0,0,1 935896634,"You have `target: 'node'`, so I don't understand",0,0,0,0,0,1 937303236,"[BLOCK QUOTE]. I'm not sure why I had to, but I needed the updated deps to be able to run the site locally. Feel free to commit changes to this PR to help us get the CI to pass.",0,0,0,0,0,1 939850663,"I also have a problem like this inside a monorepo, and just reinstalling the deps with `yarn` solves it. It's happened a few times. Don't know it could be something to do with the `yarn.lock` file getting out of sync after merging branches or something. The regenerated lock filed always shows a diff around the package referenced in the TS error. Don't really understand what's going on but hope that helps someone.",0,0,0,0,0,1 943854856,Oof that's really confusing. Shouldn't `import` take priority over `types` too though?,0,0,0,0,0,1 945910040,"[USER] I'm confused about both points. * For the first point, the only difference in going through a shell would be if the executable itself is a shell-variable. Given that `getDiffTool` returns the value from an envvar, I'm guessing that it's ok to assume that using a shell is no longer needed for this? * Re the second point, I don't see how it's related, this is in a js file, so can be used without having anything built, no?",0,0,0,0,0,1 946396130,"Hmm, it might be the case, but I am wondering why it works fine the in production version of my app (which still uses Flutter 1.26 because of this issue).",0,0,0,0,0,1 946516684,"[USER] Sure here it is, but I'm wondering why it was running smooth before? [TRIPLE QUOTE].",0,0,0,0,0,1 947787018,"Sounds good. I get a bit confused by ""language and locale"" since it feels like it is two separate things, where the CurrencyPipe only has a `locale` parameter, not a `language` parameter. So perhaps we could also drop the ""language and"" words?",0,0,0,0,0,1 948345870,"[USER] I'm not certain what you're seeing can be classified as ""flickering"". I guess it's more like compared to the smooth animation of the hero, the leading of the appbar's sudden entrance feels janky by comparison. Would that be a more accurate way to describe what you're seeing?",0,0,0,0,0,1 948473811,"I'm not entirely sure what you're asking. Can you provide more details as to what you want to accomplish?",0,0,0,0,0,1 950358151,"[BLOCK QUOTE]. I'm not sure what you mean by ""misleading"". If you mean that changing it should change the corresponding entry in the RC file, that would ideally true of several things (notably, version) but isn't currently implemented for anything on Windows as discussed in [URL]",0,0,0,0,0,1 951608829,I doubt if this is specific to Flutter then. you may try the same with native android and see if it occurs there too. I am inclined to think this could be related to gradle.,0,0,0,0,0,1 952086818,then what to do ?,0,0,0,0,0,1 952931512,"[USER] Tthe concern was more that `InjectFlags.Self` was not being passed through before, and now will be. So previously it would have had no effect and now it will. If this makes no difference then is there a reason to have that flag there at all? Also, I don't understand why this code would fail after this PR but not before? Does passing `undefined` equate to passing `InjectFlags.Optional`?",0,0,0,0,0,1 955178251,"I've also encountered this a few times and it's sometimes confusing. I use return instead of a comment as described in the issue but I've learned not to do this in typescript. It's mostly confusing when you accidentally write code that returns. I just did this mistake now and was going to file an issue but found this issue instead. And for some reason my code is not marked as dead probably due to some bad setup in my vscode.",0,0,0,0,0,1 956485425,"N.B. another workaround is writing the module augmentation for the _originally_ exporting module, i.e. `declare module ""../../main-package/interfaces/metadata.interface""`. Honestly not sure whether this is a bug or not, as the two reexport syntaxes have different symbol representations under the hood. The fact that we're kind of exposing that here is definitely confusing and unintuitive, but I can't say with 100% certainty that there's not some logical reason or technical limitation behind it.",0,0,0,0,0,1 957815562,I don't know why I can not see this in Android Studio,0,0,0,0,0,1 958198295,"I can't say. For use in widgets, there are already a number of mechanisms to help them deal easily and naturally with Futures. It depends on what other use cases might be envisioned, but the Future version would mean you wouldn't really have to explain the need to keep it away from the builder thread. Also, I guess it depends on if the Future version was implemented in such a way that the work was done on another thread. If it is just a cover for doing asynchronous work on the same thread then we'd still potentially see some disruption of frame build times maybe? Perhaps [USER] or [USER] might have some insights.",0,0,0,0,0,1 958289760,"[USER] This PR was approved, but looks like it stalled. Can you take a look at it again?",0,0,0,0,0,1 958594871,"Neither of the links have the problem shown in the screenshots when I follow them, so it's either transient or machine/browser-specific. Do you still see it?",0,0,0,0,0,1 958713799,"Strange, the same thing, no error shown after reinstalling Android Studio, also I'm using my physical phone (Samsung Galaxy Note 10+) ![image]([URL]",0,0,0,0,0,1 959774272,"Hey [USER] πŸ‘‹, not sure why _file_ an issue is different than _report_ πŸ˜• I think that the former is a valid word for filing/reporting issues, bugs, and other things.",0,0,0,0,0,1 960653927,"[BLOCK QUOTE]. @yanwei49 I am not really sure why it worked. [BLOCK QUOTE]. Provided you last message I feel it's safe to close the issue, If you disagree feel free to write in the comments and I will reopen it.",0,0,0,0,0,1 952388360,"Is there an easy way to pass time as a uniform from flutter? I see that I can pass in some uniforms to the fragmentshader constructor. what is the glsl layout syntax for accessing them? Do I need to pass by reference or pointer somehow so they get updated each frame? Sorry if I'm not making sense. This is a little outside my comfort zone, but fragment shader is a feature I'm really excited about!",0,0,0,1,0,1 705761494,Do you know why this was done in the first place? Was it just because it was easier? Talking about separating before/during/after selection. I agree that it seems much more useful the new way.,0,0,0,0,0,1 658147515,Oh sorry I thought this line was in `FocusScopeState`. Although very unlikely but it still can happen if someone schedules a `focsusNode.dispose` in a postframe callback right?,0,0,0,0,0,1 93185043,"`;` missing, but i wonder why this is not catched by the linting...",0,0,0,0,0,1 160947935,"hmm... could you move the ""if"" to these calls.",0,0,0,0,0,1 181647184,"Just curious – have you considered switching to TypeScript entirely, instead of using doc comments? [TRIPLE QUOTE].",0,0,0,0,0,1 187571129,Why is this hardcoded? πŸ€”,0,0,0,0,0,1 204883888,I don't understand. The specifier is defined in `dep`. What are you referring to?,0,0,0,0,0,1 209835333,"that's what came out of `declarator.init`, could you please elaborate why so I can try and figure out what went wrong? Sorry about the delay, I've been caught up in so many things this summer.",0,0,0,0,0,1 245470523,Could you please give some background about this change? What does it match? What’s the reasoning here?,0,0,0,0,0,1 245951861,I see... are you saying it would break for folks who are overriding the default `inputFileSystem`?,0,0,0,0,0,1 328533277,[USER] I am just curious why you use here lazy sorting? Looks like inserting in right order will be faster.,0,0,0,0,0,1 459807477,"I haven't found that I've needed that in my own investigations but, to be fair, I don't often investigate composite projects. Is there a scenario you have in mind? Also, how would I distinguish those files?",0,0,0,0,0,1 521689646,I'm missing something - how would use a dash help with batch processing?,0,0,0,0,0,1 536078285,"I have a question regarding this behavior, sorry in advance if it sounds silly. Though it'd be perfect for our usecase (πŸ™Œ), is it the usual way of treating include/exclude in the other places of Webpack (for modules rules for example)? In other words, what is considered _the_ best practice? includes overruling exludes? or excludes overruling includes?",0,0,0,0,0,1 616856306,why was this changed?,0,0,0,0,0,1 620692134,"Double-checking my understanding; is this correct?: it's enough to bail after seeing that typeParameters is set, because a normal run of this function sets both typeParameters and parameters. So you don't have to check parameters as well.",0,0,0,0,0,1 623079420,Hey [USER] could you help me with this? I don't know how to do it.,0,0,0,0,0,1 624162350,Yes this is accurate but what i am asking is do we want to show these options when --showConfig is run?,0,0,0,0,0,1 625401548,"Curious - who uses this, and what do they use it for?",0,0,0,0,0,1 628916017,Is this change necessary?,0,0,0,0,0,1 629622724,"OOC, why is this change needed?",0,0,0,0,0,1 638210024,"Yeah, this was just a mistake, but if I do want to share the watches with the closed script info watches (and I think I doβ€”isn’t sharing minimizing recursive directory watches by sharing them good practice?), I guess I will end up using this type?",0,0,0,0,0,1 643465346,Is this still valid? Looks like _layer is now nulled regardless of isRepaintBoundary?,0,0,0,0,0,1 644252582,"ahh, that's better. Why does it have significantly worse performance though?",0,0,0,0,0,1 649886645,"OOC, why not include this when creating the array right above?",0,0,0,0,0,1 650017091,I'm not quite sure I understand. Could you please elaborate on what you mean by 'use { }'?,0,0,0,0,0,1 656819209,"Given that this is an interface, do we care about minification?",0,0,0,0,0,1 657245532,"I am wondering whether it is better to use a regex replacement here? Something like: [TRIPLE QUOTE].",0,0,0,0,0,1 659184414,is this comment still true?,0,0,0,0,0,1 659972976,"Why 1 and not 0? (Asking out of total ignorance, never having seen this code before.)",0,0,0,0,0,1 667254322,"Should this mention position in the widget tree, or is that not a concern of the Action widget itself?",0,0,0,0,0,1 670167144,"Out of curiosity, why does this need to be in a post-frame callback? `didChangeMetrics` is not going to be called during `drawFrame` so it sounds like it's OK to just call `updateForScroll` here?",0,0,0,0,0,1 674671395,"Hi, I am not sure I fully understand your suggestion, so add some codes below for discussing. Is this what you expect ？ if not please let me know how to modify . Thanks ! [TRIPLE QUOTE]. [TRIPLE QUOTE]. [TRIPLE QUOTE].",0,0,0,0,0,1 691488362,Is this right? Dependencies can change after a user has interacted with the sheet.,0,0,0,0,0,1 692431160,"I was wondering about `const { arguments } = { arguments: {} };` but TypeScript doesn't even allow me to type that in strict mode, reporting TS1210 on the destructuring assignment.",0,0,0,0,0,1 694773800,I'm curious about this - can you give more context on what exactly goes wrong? Perhaps if that causes bugs this should be prohibited instead?,0,0,0,0,0,1 695009343,"I actually wonder if this whole second condition is even needed now... seems like the examples in the comments would be covered by the new condition you added. It doesn’t hurt to leave it in, so I probably wouldn’t change it this close to a release, but it might be worth running tests with it removed just to see if it can be cleaned up and simplified in the future.",0,0,0,0,0,1 698572690,"What about: ""The code in this example performs the following tasks:"" ?",0,0,0,0,0,1 698730792,"Is this just `TextSelection.fromPosition`, except this preserves the `isDirectional` property?",0,0,0,0,0,1 699716975,What was wrong here?,0,0,0,0,0,1 704081644,"A small question, why not enum?",0,0,0,0,0,1 704840212,Just wanted to check if this change is intentional. Should we move that to a separate PR/commit? Would this change require tests?,0,0,0,0,0,1 712055253,"I see. Thanks. If I remember correctly, we had a workaround in the doc-gen to cope with this scenario, by adding in the current path to all local fragment URLs. I wonder if we could remove that doc-gen fix, now that the app itself is able to cope?",0,0,0,0,0,1 714266492,[USER] So what is that valid code? Why can we not fix the assertion?,0,0,0,0,0,1 715193824,"Why ""slightly less""? Do we just want to make sure it doesn't paint outside of the chip?",0,0,0,0,0,1 716648129,"[USER] Hmm, even when doing it fully programmatically? What happens with an already existed module instance? Is it simply overwritten in the registry even already used in an application?",0,0,0,0,0,1 716661839,Hmm I wonder if we should actually include these files?,0,0,0,0,0,1 717848960,"Why not throw an error? I don't really have an opinion either way, just seeing if you do.",0,0,0,0,0,1 717994498,Is this deleted because it's covered by an EditableText test now?,0,0,0,0,0,1 718039974,Is this font already bundled with Flutter?,0,0,0,0,0,1 718043500,No unfortunately. I'll put a comment there. I'm a bit curious how macOS handles a keyboard layout that doesn't have a command key. Does it automatically detect that and change the shortcuts?,0,0,0,0,0,1 718942362,"to make sure I understand this: without the new code, would only rc-table show up? Or would neither show up?",0,0,0,0,0,1 720568368,I also wonder whether this should be paired with an `inactiveCircleColor` property πŸ€”,0,0,0,0,0,1 722809324,is this ensured to exist?,0,0,0,0,0,1 725846342,Is this ignore still needed given that ListTileTheme doesn't implement ListTileThemeData?,0,0,0,0,0,1 727920077,"Just curious, why using xor here?",0,0,0,0,0,1 728359136,"is this relevant for the test, or could it just be an empty `void main() {}`?",0,0,0,0,0,1 732186725,"anyways yeah sorry, just wanted to ask you, so would you want us to use ` *` instead of `\s*`? or would you like to go a step further and go with ` {num}`? or even forget about the `toMatch` altogether and I just use `toEqual` with string literals everywhere?",0,0,0,0,0,1 813345539,"Dear community, what's the current workaround until this is fixed?",0,0,0,0,0,1 818272671,Any updates here?,0,0,0,0,0,1 823315003,"I see. But what is the plus of this intend, why it inlines instead of referencing it like other modules?",0,0,0,0,0,1 841912387,"Hello [USER] , out of curiosity, have you figured out a way to do it without the proxy? I am on the same boat as you. My team has a proxy service that can do the routing correctly, however, it will break without the proxy which makes the dev experience kinda bad.",0,0,0,0,0,1 870966514,hmm... interesting... Could you try to run `gc()` before doing the heapdump? (`--expose-gc`),0,0,0,0,0,1 898692298,"[USER] I'm always interested in real-life repos to do perf tests with, as they often show new insights in ways to optimize builds. The first rebuild is indeed slower because incremental type checking of TS sources is ineffective in the first rebuild. This is a known limitation because of how template type checking is achieved. I'd be interested to learn where the 7s deficit from JIT mode comes from.",0,0,0,0,0,1 899112604,"[BLOCK QUOTE]. Fascinating. Could you point out what I am ""not fully correct"" about?",0,0,0,0,0,1 916414317,[USER] sorry for bothering you :sweat: is this PR ok to merge? What's the plan? When can breaking change PRs be merged? :slightly_smiling_face:,0,0,0,0,0,1 917168702,"[USER] What is the issue number of the previous one that was closed? Also, please provide a sample project.",0,0,0,0,0,1 936068938,"[USER] I don't see workarounds here, what is your target? What is `Critical line in index.ts line 57.`?",0,0,0,0,0,1 937982740,Any updates please?,0,0,0,0,0,1 940030145,But why?,0,0,0,0,0,1 940518902,What bugs did that introduce?,0,0,0,0,0,1 943521102,What exactly was happening here?,0,0,0,0,0,1 945184362,any update?,0,0,0,0,0,1 945965495,"Correct me if I'm wrong, but all material dropdown buttons were behaving like that in older Android version (6.x, 7.x), but in newer versions (starting from 8.x or 9.x, I'm not sure) they decided to remove this behavior for some reason. I remember that it was possible to select entries in Chrome main menu with single finger gesture, and also change language in Google Translate dropdowns on top of the screen. But at some point this behavior was ditched out from all applications, deliberately or by accident, and it became not possible since then. However, it's still possible in some Android apps, for example please see [Vivaldi browser]([URL] β€” main menu button behaves exactly like that: ![Screen_Recording_20210814-193643_Vivaldi]([URL] And I wonder now how to replicate this behavior in Flutter application.",0,0,0,0,0,1 945968078,Also do you know why it just started failing now?,0,0,0,0,0,1 947420199,Hi [USER] I'm curious. Why did you replace dot notation with bracket notation? 😢,0,0,0,0,0,1 947625085,Do we have any workaround for this yet in the meantime?,0,0,0,0,0,1 948136622,"[BLOCK QUOTE]. …with what? The suspense is killing me!",0,0,0,0,0,1 948306551,"[USER], is it safe to assume that your issue has been solved?",0,0,0,0,0,1 948858522,[USER] [USER] I'm curious what you guys think about the approaches in [URL],0,0,0,0,0,1 950663179,Any news on this? NoopAnimationsModule still costs 17kb even with gzipped.,0,0,0,0,0,1 950928012,"Hello, any update on this ?",0,0,0,0,0,1 952255014,Any news about investigation of this problem?,0,0,0,0,0,1 953301655,"[USER] Based on your description of the problem, I'm not sure exactly how this is related to the Angular router. Presumably the analytics code is throwing an error while the Router is navigating, and that error causes the navigation to abort? How/where is that problematic piece of code invoked? Now that you've identified the source of the error, are you able to create a minimal reproduction?",0,0,0,0,0,1 954082678,"I'm also very curious about it, [USER] . Can you provide some example code to us?",0,0,0,0,0,1 954440724,any body support me to tell roadmap for how to start the flutter embedded.,0,0,0,0,0,1 955795913,[USER] Any updates on this?,0,0,0,0,0,1 955823494,Was this a breaking change? Are end-users going to have to take any action to compensate for the updated engine deps?,0,0,0,0,0,1 958353427,[USER] Any updates on this PR? Is it still needed?,0,0,0,0,0,1 958721169,"Hi [USER], can you explain more what exactly you're requesting for?",0,0,0,0,0,1 524603224,"I understand why we skip the work if there are no open files, but not why we're looking at external projects. Can you please explain?",0,0,0,0,0,1 920311878,"I can't wait for this <3 I am curious, what kind of feedback is needed?",0,1,0,0,0,1 644306715,"I can think of a couple ways to fix this - Always return all errors, then have `tsc` have a filter when displaying errors for JS files. This would add errors to all other API consumers, though. - Give the language service a separate way to request unchecked JS errors. The checker will have to store these errors separately and the language service will have to add them late. - Possibly: Not report these errors in the ""errors in closed files"" list. But I don't know if that would be what users of that feature expect. Opinions? Ideas? I'm pretty sure that this feature is going to stick around and grow, so I'd like for it to be easier to use than to not use. Specifically, it's annoying if the future status quo for the language service is to request diagnostics twice, once for unchecked JS and again for everything else.",0,0,0,1,0,0