Possible bug in MPASM include "16f627.inc" (and other include files) - Page 1
Forum section: electronics / general

author: glossywhite
author_rank: Regular Contributor
timestamp: February 01, 2011, 12:41:14 pm
content: Hi there. I have been scanning through some code that was included in my Velleman PIC programmer, and in the ASM listing to disable data code protection, it explicitly says "_DATA_CP_OFF", whereas in the Microchip MPASM include file "16f627.inc" you will see the preceeding underscore "_" missing, and it simply says "DATA_CP_OFF". This is also the case in other .INC files in the latest MPASM.Here is the listing for the latest "16f627.inc" so you can see for yourself. Surely this is an error?:Code:LIST;==========================================================================; MPASM PIC16F627 processor include;; (c) Copyright 1999-2010 Microchip Technology, All rights reserved;==========================================================================NOLIST;==========================================================================; This header file defines configurations, registers, and other useful; bits of information for the PIC16F627 microcontroller. These names; are taken to match the data sheets as closely as possible.;; Note that the processor must be selected before this file is included.; The processor may be selected the following ways:;; 1. Command line switch:; C:\MPASM MYFILE.ASM /PIC16F627; 2. LIST directive in the source file; LIST P=PIC16F627; 3. Processor Type entry in the MPASM full-screen interface; 4. Setting the processor in the MPLAB Project Dialog;==========================================================================;==========================================================================;; Verify Processor;;==========================================================================IFNDEF __16F627MESSG "Processor-header file mismatch. Verify selected processor."ENDIF;==========================================================================;; Register Definitions;;==========================================================================W EQU H'0000'F EQU H'0001';----- Register Files -----------------------------------------------------;-----Bank0------------------INDF EQU H'0000'TMR0 EQU H'0001'PCL EQU H'0002'STATUS EQU H'0003'FSR EQU H'0004'PORTA EQU H'0005'PORTB EQU H'0006'PCLATH EQU H'000A'INTCON EQU H'000B'PIR1 EQU H'000C'TMR1L EQU H'000E'TMR1H EQU H'000F'T1CON EQU H'0010'TMR2 EQU H'0011'T2CON EQU H'0012'CCPR1 EQU H'0015'CCPR1L EQU H'0015'CCPR1H EQU H'0016'CCP1CON EQU H'0017'RCSTA EQU H'0018'TXREG EQU H'0019'RCREG EQU H'001A'CMCON EQU H'001F';-----Bank1------------------OPTION_REG EQU H'0081'TRISA EQU H'0085'TRISB EQU H'0086'PIE1 EQU H'008C'PCON EQU H'008E'PR2 EQU H'0092'TXSTA EQU H'0098'SPBRG EQU H'0099'EEDATA EQU H'009A'EEADR EQU H'009B'EECON1 EQU H'009C'EECON2 EQU H'009D'VRCON EQU H'009F';----- STATUS Bits -----------------------------------------------------C EQU H'0000'DC EQU H'0001'Z EQU H'0002'NOT_PD EQU H'0003'NOT_TO EQU H'0004'IRP EQU H'0007'RP0 EQU H'0005'RP1 EQU H'0006';----- PORTA Bits -----------------------------------------------------RA0 EQU H'0000'RA1 EQU H'0001'RA2 EQU H'0002'RA3 EQU H'0003'RA4 EQU H'0004'RA5 EQU H'0005'RA6 EQU H'0006'RA7 EQU H'0007';----- PORTB Bits -----------------------------------------------------RB0 EQU H'0000'RB1 EQU H'0001'RB2 EQU H'0002'RB3 EQU H'0003'RB4 EQU H'0004'RB5 EQU H'0005'RB6 EQU H'0006'RB7 EQU H'0007';----- INTCON Bits -----------------------------------------------------RBIF EQU H'0000'INTF EQU H'0001'T0IF EQU H'0002'RBIE EQU H'0003'INTE EQU H'0004'T0IE EQU H'0005'PEIE EQU H'0006'GIE EQU H'0007'TMR0IF EQU H'0002'TMR0IE EQU H'0005';----- PIR1 Bits -----------------------------------------------------TMR1IF EQU H'0000'TMR2IF EQU H'0001'CCP1IF EQU H'0002'TXIF EQU H'0004'RCIF EQU H'0005'CMIF EQU H'0006'EEIF EQU H'0007';----- T1CON Bits -----------------------------------------------------TMR1ON EQU H'0000'TMR1CS EQU H'0001'NOT_T1SYNC EQU H'0002'T1OSCEN EQU H'0003'T1CKPS0 EQU H'0004'T1CKPS1 EQU H'0005';----- T2CON Bits -----------------------------------------------------TMR2ON EQU H'0002'T2CKPS0 EQU H'0000'T2CKPS1 EQU H'0001'TOUTPS0 EQU H'0003'TOUTPS1 EQU H'0004'TOUTPS2 EQU H'0005'TOUTPS3 EQU H'0006';----- CCP1CON Bits -----------------------------------------------------CCP1Y EQU H'0004'CCP1X EQU H'0005'CCP1M0 EQU H'0000'CCP1M1 EQU H'0001'CCP1M2 EQU H'0002'CCP1M3 EQU H'0003';----- RCSTA Bits -----------------------------------------------------RX9D EQU H'0000'OERR EQU H'0001'FERR EQU H'0002'ADEN EQU H'0003'CREN EQU H'0004'SREN EQU H'0005'RX9 EQU H'0006'SPEN EQU H'0007'ADDEN EQU H'0003';----- CMCON Bits -----------------------------------------------------CIS EQU H'0003'C1INV EQU H'0004'C2INV EQU H'0005'C1OUT EQU H'0006'C2OUT EQU H'0007'CM0 EQU H'0000'CM1 EQU H'0001'CM2 EQU H'0002';----- OPTION_REG Bits -----------------------------------------------------PSA EQU H'0003'T0SE EQU H'0004'T0CS EQU H'0005'INTEDG EQU H'0006'NOT_RBPU EQU H'0007'PS0 EQU H'0000'PS1 EQU H'0001'PS2 EQU H'0002';----- TRISA Bits -----------------------------------------------------TRISA0 EQU H'0000'TRISA1 EQU H'0001'TRISA2 EQU H'0002'TRISA3 EQU H'0003'TRISA4 EQU H'0004'TRISA5 EQU H'0005'TRISA6 EQU H'0006'TRISA7 EQU H'0007';----- TRISB Bits -----------------------------------------------------TRISB0 EQU H'0000'TRISB1 EQU H'0001'TRISB2 EQU H'0002'TRISB3 EQU H'0003'TRISB4 EQU H'0004'TRISB5 EQU H'0005'TRISB6 EQU H'0006'TRISB7 EQU H'0007';----- PIE1 Bits -----------------------------------------------------TMR1IE EQU H'0000'TMR2IE EQU H'0001'CCP1IE EQU H'0002'TXIE EQU H'0004'RCIE EQU H'0005'CMIE EQU H'0006'EEIE EQU H'0007';----- PCON Bits -----------------------------------------------------NOT_BOR EQU H'0000'NOT_POR EQU H'0001'OSCF EQU H'0003'NOT_BO EQU H'0000'NOT_BOD EQU H'0000';----- TXSTA Bits -----------------------------------------------------TX9D EQU H'0000'TRMT EQU H'0001'BRGH EQU H'0002'SYNC EQU H'0004'TXEN EQU H'0005'TX9 EQU H'0006'CSRC EQU H'0007';----- EECON1 Bits -----------------------------------------------------RD EQU H'0000'WR EQU H'0001'WREN EQU H'0002'WRERR EQU H'0003';----- VRCON Bits -----------------------------------------------------VRR EQU H'0005'VROE EQU H'0006'VREN EQU H'0007'VR0 EQU H'0000'VR1 EQU H'0001'VR2 EQU H'0002'VR3 EQU H'0003';==========================================================================;; RAM Definitions;;==========================================================================__MAXRAM H'01FF'__BADRAM H'0007'-H'0009'__BADRAM H'000D'__BADRAM H'0013'-H'0014'__BADRAM H'001B'-H'001E'__BADRAM H'0087'-H'0089'__BADRAM H'008D'__BADRAM H'008F'-H'0091'__BADRAM H'0093'-H'0097'__BADRAM H'009E'__BADRAM H'0105'__BADRAM H'0107'-H'0109'__BADRAM H'010C'-H'011F'__BADRAM H'0150'-H'016F'__BADRAM H'0185'__BADRAM H'0187'-H'0189'__BADRAM H'018C'-H'019F'__BADRAM H'01A0'-H'01EF';==========================================================================;; Configuration Bits;; NAME Address; CONFIG 2007h;;==========================================================================; The following is an assignment of address values for all of the; configuration registers for the purpose of table reads_CONFIG EQU H'2007';----- CONFIG Options --------------------------------------------------_LP_OSC EQU H'3FEC' ; LP oscillator: Low-power crystal on RA6/OSC2/CLKOUT and RA7/OSC1/CLKIN_XT_OSC EQU H'3FED' ; XT oscillator: Crystal/resonator on RA6/OSC2/CLKOUT and RA7/OSC1/CLKIN_HS_OSC EQU H'3FEE' ; HS oscillator: High-speed crystal/resonator on RA6/OSC2/CLKOUT and RA7/OSC1/CLKIN_EXTCLK_OSC EQU H'3FEF' ; EC: I/O function on RA6/OSC2/CLKOUT pin, CLKIN on RA7/OSC1/CLKIN_INTRC_OSC_NOCLKOUT EQU H'3FFC' ; INTRC oscillator: I/O function on RA6/OSC2/CLKOUT pin, I/O function on RA7/OSC1/CLKIN_INTRC_OSC_CLKOUT EQU H'3FFD' ; INTRC oscillator: CLKOUT function on RA6/OSC2/CLKOUT pin, I/O function on RA7/OSC1/CLKIN_ER_OSC_NOCLKOUT EQU H'3FFE' ; ER oscillator: I/O function on RA6/OSC2/CLKOUT pin, Resistor on RA7/OSC1/CLKIN_ER_OSC_CLKOUT EQU H'3FFF' ; ER oscillator: CLKOUT function on RA6/OSC2/CLKOUT pin, Resistor on RA7/OSC1/CLKIN_WDT_OFF EQU H'3FFB' ; WDT disabled_WDT_ON EQU H'3FFF' ; WDT enabled_PWRTE_ON EQU H'3FF7' ; PWRT enabled_PWRTE_OFF EQU H'3FFF' ; PWRT disabled_MCLRE_OFF EQU H'3FDF' ; RA5/MCLR pin function is digital input, MCLR internally tied to VDD_MCLRE_ON EQU H'3FFF' ; RA5/MCLR pin function is MCLR_BODEN_OFF EQU H'3FBF' ; BOD Reset disabled_BODEN_ON EQU H'3FFF' ; BOD Reset enabled_LVP_OFF EQU H'3F7F' ; RB4/PGM pin has digital I/O function, HV on MCLR must be used for programming_LVP_ON EQU H'3FFF' ; RB4/PGM pin has PGM function, low-voltage programming enabledDATA_CP_ON EQU H'3EFF' ; Data memory code protectedDATA_CP_OFF EQU H'3FFF' ; Data memory code protection off_CP_ALL EQU H'03FF' ; 0000h-03FFh code protected_CP_75 EQU H'17FF' ; 0200h-03FFh code protected_CP_50 EQU H'2BFF' ; Program memory code protection off_CP_OFF EQU H'3FFF' ; Program memory code protection off;----- DEVID Equates --------------------------------------------------_DEVID1 EQU H'2006';----- IDLOC Equates --------------------------------------------------_IDLOC0 EQU H'2000'_IDLOC1 EQU H'2001'_IDLOC2 EQU H'2002'_IDLOC3 EQU H'2003'LIST

author: Mechatrommer
author_rank: Super Contributor
timestamp: February 01, 2011, 02:55:25 pm
content: thats not a bug, thats ladybird.

author: glossywhite
author_rank: Regular Contributor
timestamp: February 01, 2011, 03:04:30 pm
content: Quote from: Mechatrommer on February 01, 2011, 02:55:25 pm...

author: Balaur
author_rank: Unknown
timestamp: February 01, 2011, 04:09:36 pm
content: That's strange.I've checked the include files from PicProg2009 (the tool that Velleman provides as a free download for the K8048). This tool actually includes an somewhat older version (v5.2) of the Microchip MPASM tool.Thus, the include files are identical to the files provided with MPASM (v5.37) from my installation of the MPLAB v8.56 and work as expected.Here is an excerpt:Code:LIST; P16F627.INC Standard Header File, Version 1.01 Microchip Technology, Inc.NOLIST; This header file defines configurations, registers, and other useful bits of; information for the PIC16F627 microcontroller. These names are taken to match; the data sheets as closely as possible.; Note that the processor must be selected before this file is; included. The processor may be selected the following ways:; 1. Command line switch:; C:\ MPASM MYFILE.ASM /PIC16F627; 2. LIST directive in the source file; LIST P=PIC16F627; 3. Processor Type entry in the MPASM full-screen interface;==========================================================================;; Revision History;;==========================================================================;Rev: Date: Reason:;1.01 13 Sept 2001 Added _DATA_CP_ON and _DATA_CP_OFF;1.00 10 Feb 1999 Initial Release...;==========================================================================;; Configuration Bits;;==========================================================================_BODEN_ON EQU H'3FFF'_BODEN_OFF EQU H'3FBF'_CP_ALL EQU H'03FF'_CP_75 EQU H'17FF'_CP_50 EQU H'2BFF'_CP_OFF EQU H'3FFF'_DATA_CP_ON EQU H'3EFF'_DATA_CP_OFF EQU H'3FFF'_PWRTE_OFF EQU H'3FFF'_PWRTE_ON EQU H'3FF7'_WDT_ON EQU H'3FFF'_WDT_OFF EQU H'3FFB'_LVP_ON EQU H'3FFF'_LVP_OFF EQU H'3F7F'_MCLRE_ON EQU H'3FFF'_MCLRE_OFF EQU H'3FDF'_ER_OSC_CLKOUT EQU H'3FFF'_ER_OSC_NOCLKOUT EQU H'3FFE'_INTRC_OSC_CLKOUT EQU H'3FFD'_INTRC_OSC_NOCLKOUT EQU H'3FFC'_EXTCLK_OSC EQU H'3FEF'_LP_OSC EQU H'3FEC'_XT_OSC EQU H'3FED'_HS_OSC EQU H'3FEE'LISTWhat is your MPLAB version?Maybe they changed some stuff in the MPLAB X?Cheers,Dan

author: glossywhite
author_rank: Regular Contributor
timestamp: February 01, 2011, 04:17:06 pm
content: I have MPLAB v8.63 and MPASM v5.39. It seems your versions are out of date, but I still cannot work outwhythis is how it is... odd.

author: Mechatrommer
author_rank: Super Contributor
timestamp: February 01, 2011, 04:26:23 pm
content: its just a definition, you can name whatever definition you like, assuming the value is the same. as long as it is compiled, you are ok.

author: glossywhite
author_rank: Regular Contributor
timestamp: February 01, 2011, 04:43:28 pm
content: Quote from: Mechatrommer on February 01, 2011, 04:26:23 pmYes, I know, but that doesn't escape the fact that the syntax is still incorrect. In ASM, each fuse begins with an "_" underscore, and the __CONFIG, a *double* "__" underscore. I know it willwork, but that was not my point.

author: Balaur
author_rank: Unknown
timestamp: February 01, 2011, 04:44:23 pm
content: Quote from: Mechatrommer on February 01, 2011, 04:26:23 pmThis change may break your own code if the configuration word (__CONFIG) relies on pre-defined options. Ex:Code:processor16f627include<p16f627.inc>__CONFIG _CP_OFF & _WDT_OFF & _PWRTE_ON & _EXTCLK_OSC & _BODEN_ON & _LVP_OFF

author: Mechatrommer
author_rank: Super Contributor
timestamp: February 01, 2011, 05:01:28 pm
content: Quote from: glossywhite on February 01, 2011, 04:43:28 pmand again, thats not called syntax, thats called coding style.Quote from: Balaur on February 01, 2011, 04:44:23 pmyes, if you run old codes in a new library vice versa. that "coding style" is changing which is not a very good thing for the programmer/library maker who code it, ie Microchip, in your case.you may as well call the "coding style" as "backward compatibilitiness".although, there maybe a reason for the change which i dont know, finding it out might give some clue.and possibly its a bug, but i seldomly saw this kind of stupid bug, reporting to Microchip might give some clue... as well.

author: glossywhite
author_rank: Regular Contributor
timestamp: February 01, 2011, 05:46:56 pm
content: Quote from: Mechatrommer on February 01, 2011, 05:01:28 pmI actually beg to differ, Shafri. I think this is actuallysyntax, because the prefixed "_" underscore is always used within the context of assembly for PIC.PS: Not that it makes one iota of difference to me, but why have you changed your username?

author: RayJones
author_rank: Frequent Contributor
timestamp: February 01, 2011, 06:45:15 pm
content: Quote from: glossywhite on February 01, 2011, 05:46:56 pmThe use of a leading underscore is a standard across many compilers, if not actually chiseled into stone.The C source would be without the underscore, the *generated* assembly will have a leading underscore.The same rule applies if you wanted to write an assembly function called from the C source file.In asm, you have to create the function name with the underscore, but in C you leave it out.The linker however sees the generated C name has a underscore, and thus matches perfectly with the asm file (which of course is not compiled, but assembled)Welcome to the world of including ASM code with C code!