CVE-2023-52137 (Shell, published 2023-12-29T17:16Z)
Description: value: The [`tj-actions/verify-changed-files`](https://github.com/tj-actions/verify-changed-files) action allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets. The [`verify-changed-files`](https://github.com/tj-actions/verify-changed-files) workflow returns the list of files changed within a workflow execution. This could potentially allow filenames that contain special characters such as `;` which can be used by an attacker to take over the [GitHub Runner](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners) if the output value is used in a raw fashion (thus being directly replaced before execution) inside a `run` block. By running custom commands, an attacker may be able to steal secrets such as `GITHUB_TOKEN` if triggered on other events than `pull_request`.

This has been patched in versions [17](https://github.com/tj-actions/verify-changed-files/releases/tag/v17) and [17.0.0](https://github.com/tj-actions/verify-changed-files/releases/tag/v17.0.0) by enabling `safe_output` by default and returning filename paths escaping special characters for bash environments.
Severity: nan (CVSS v3 base score: 8.8)
Weakness: CWE-77 \u2014 Improper Neutralization of Special Elements used in a Command ('Command Injection')
The product constructs all or part of a command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended command when it is sent to a downstream component.
Repository: https://github.com/tj-actions/verify-changed-files
Files changed:
entrypoint.sh
Commit message: chore: update entrypoint.sh (#357)



Vulnerable code:
# Function to concatenate non-empty strings with a separator
  for str in "$@"; do
    if [[ -n $str ]]; then
        result+="$separator$str"
        result="$str"
  echo "Found uncommited changes"
  if [[ "$INPUT_SAFE_OUTPUT" == "true" ]]; then
    CHANGED_FILES=${CHANGED_FILES//$/\\$} # Replace $ with \$
    CHANGED_FILES=${CHANGED_FILES//\(/\\\(}} # Replace ( with \(
    CHANGED_FILES=${CHANGED_FILES//\)/\\\)}} # Replace ) with \)
    CHANGED_FILES=${CHANGED_FILES//\`/\\\`} # Replace ` with \`
    CHANGED_FILES=${CHANGED_FILES//|/\\|} # Replace | with \|
    CHANGED_FILES=${CHANGED_FILES//&/\\&} # Replace & with \&
    CHANGED_FILES=${CHANGED_FILES//;/\\;} # Replace ; with \;
  fi



Fixed code:
# Function to concatenate non-empty file names with a separator
  for filename in "$@"; do
    if [[ "$INPUT_SAFE_OUTPUT" == "true" ]]; then
      filename=${filename//$/\\$} # Replace $ with \$
      filename=${filename//\(/\\\(} # Replace ( with \(
      filename=${filename//\)/\\\)} # Replace ) with \)
      filename=${filename//\`/\\\`} # Replace ` with \`
      filename=${filename//|/\\|} # Replace | with \|
      filename=${filename//&/\\&} # Replace & with \&
      filename=${filename//;/\\;} # Replace ; with \;
    fi
    if [[ -n $filename ]]; then
        result+="$separator$filename"
        result="$filename"
  echo "Found uncommitted changes"