CVE-2023-48292 (XML, published 2023-11-20T18:15Z)
Description: value: The XWiki Admin Tools Application provides tools to help the administration of XWiki. Starting in version 4.4 and prior to version 4.5.1, a cross site request forgery vulnerability in the admin tool for executing shell commands on the server allows an attacker to execute arbitrary shell commands by tricking an admin into loading the URL with the shell command. A very simple possibility for an attack are comments. When the attacker can leave a comment on any page in the wiki it is sufficient to include an image with an URL like  `/xwiki/bin/view/Admin/RunShellCommand?command=touch%20/tmp/attacked` in the comment. When an admin views the comment, the file `/tmp/attacked` will be created on the server. The output of the command is also vulnerable to XWiki syntax injection which offers a simple way to execute Groovy in the context of the XWiki installation and thus an even easier way to compromise the integrity and confidentiality of the whole XWiki installation. This has been patched by adding a form token check in version 4.5.1 of the admin tools. Some workarounds are available. The patch can be applied manually to the affected wiki pages. Alternatively, the document `Admin.RunShellCommand` can also be deleted if the possibility to run shell commands isn't needed.
Severity: nan (CVSS v3 base score: 8.8)
Weakness: CWE-352 \u2014 Cross-Site Request Forgery (CSRF)
The web application does not, or can not, sufficiently verify whether a well-formed, valid, consistent request was intentionally provided by the user who submitted the request.
Repository: https://github.com/xwiki-contrib/application-admintools
Files changed:
src/main/resources/Admin/RunShellCommand.xml
src/main/resources/Admin/Translations.xml
Commit message: ADMINTOOL-91: Add a form token check in RunShellCommand


Vulnerable code:
  if (shellCmd != null ) {
    String[] cmd = ["sh", "-c", shellCmd];
    stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
    println("{{code language=none}}")
    while ((s = stdout.readLine()) != null) {
      println(s);
    println("{{/code}}")
admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.</content>

Fixed code:
      &lt;input type="hidden" name="form_token" value="${services.csrf.token}" /&gt;
  def tokenValid = services.csrf.isTokenValid(request.getParameter('form_token'));
  if (shellCmd != null) {
    if (!tokenValid) {
      println("{{error}}${services.localization.render('admintools.server.tools.shellCommand.invalidToken')}{{/error}}\n\n");
    } else {
      String[] cmd = ["sh", "-c", shellCmd];
      stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
      println("{{code language=none}}")
      while ((s = stdout.readLine()) != null) {
        println(s);
      }
      println("{{/code}}")
admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.
admintools.server.tools.shellCommand.invalidToken=Invalid form token. Please verify the command and resubmit.</content>