CVE-2023-48293 (XML, published 2023-11-20T19:15Z)
Description: value: The XWiki Admin Tools Application provides tools to help the administration of XWiki. Prior to version 4.5.1, a cross-site request forgery vulnerability in the query on XWiki tool allows executing arbitrary database queries on the database of the XWiki installation. Among other things, this allows modifying and deleting all data of the wiki. This could be both used to damage the wiki and to create an account with elevated privileges for the attacker, thus impacting the confidentiality, integrity and availability of the whole XWiki instance. A possible attack vector are comments on the wiki, by embedding an image with wiki syntax like `[[image:path:/xwiki/bin/view/Admin/QueryOnXWiki?query=DELETE%20FROM%20xwikidoc]]`, all documents would be deleted from the database when an admin user views this comment. This has been patched in Admin Tools Application 4.5.1 by adding form token checks. Some workarounds are available. The patch can also be applied manually to the affected pages. Alternatively, if the query tool is not needed, by deleting the document `Admin.SQLToolsGroovy`, all database query tools can be deactivated.
Severity: nan (CVSS v3 base score: 8.8)
Weakness: CWE-352 \u2014 Cross-Site Request Forgery (CSRF)
The web application does not, or can not, sufficiently verify whether a well-formed, valid, consistent request was intentionally provided by the user who submitted the request.
Repository: https://github.com/xwiki-contrib/application-admintools
Files changed:
src/main/resources/Admin/Query.xml
src/main/resources/Admin/QueryOnXWiki.xml
src/main/resources/Admin/SQLToolsGroovy.xml
Commit message: ADMINTOOL-92: Add a form token check to Query tools


Vulnerable code:
  $sqlTools.getForm($request, $doc, true, true, $xcontext)
    #set($connection = $sqlTools.getConnectionFromRequest($request))
    #set($results = $sqlTools.getResults($connection, $request.query, true))
    = Results =
    $results
  $sqlTools.getForm($request, $doc, false, true, $xcontext)
    #set($connection = $sqlTools.getXWikiConnection($xwiki, $xcontext))
    #set($results = $sqlTools.getResults($connection, $request.query, false))
    = Results =
    $results
  String getForm(request, doc, withJDBCForm, withQuery, xcontext){

Fixed code:
  $sqlTools.getForm($request, $doc, true, true, $xcontext, $services.csrf.token)
    #if ($services.csrf.isTokenValid($request.getParameter('form_token')))
      #set($connection = $sqlTools.getConnectionFromRequest($request))
      #set($results = $sqlTools.getResults($connection, $request.query, true))
      = Results =
      $results
    #else
      {{error}}Invalid form token. Please verify the query and resubmit.{{/error}}
    #end
  $sqlTools.getForm($request, $doc, false, true, $xcontext, $services.csrf.token)
    #if ($services.csrf.isTokenValid($request.getParameter('form_token')))
      #set($connection = $sqlTools.getXWikiConnection($xwiki, $xcontext))
      #set($results = $sqlTools.getResults($connection, $request.query, false))
      = Results =
      $results
    #else
      {{error}}Invalid form token. Please verify the query and resubmit.{{/error}}
    #end
  String getForm(request, doc, withJDBCForm, withQuery, xcontext, csrfToken){
        &lt;input type="hidden" name="form_token" value="${csrfToken}" /&gt;