helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: test: execute shell directly for refresh()

What if we just called the shell directly to avoid the cost of booting a Node.js instance? 

cc @nodejs/build any concerns?

Changed files:
filename: test/common/tmpdir.js
patch: @@ -5,17 +5,28 @@ const fs = require('fs');
 const path = require('path');
 const { pathToFileURL } = require('url');
 const { isMainThread } = require('worker_threads');
+const isUnixLike = process.platform !== 'win32';
+let escapePOSIXShell;
 
 function rmSync(pathname, useSpawn) {
   if (useSpawn) {
-    const escapedPath = pathname.replaceAll('\\', '\\\\');
-    spawnSync(
-      process.execPath,
-      [
-        '-e',
-        `require("fs").rmSync("${escapedPath}", { maxRetries: 3, recursive: true, force: true });`,
-      ],
-    );
+    if (isUnixLike) {
+      escapePOSIXShell ??= require('./index.js').escapePOSIXShell;
+      for (let i = 0; i < 3; i++) {
+        const { status } = spawnSync(...escapePOSIXShell`rm -rf "${pathname}"`);
+        if (status === 0) {
+          break;
+        }
+      }
+    } else {
+      spawnSync(
+        process.execPath,
+        [
+          '-e',
+          `fs.rmSync(${JSON.stringify(pathname)}, { maxRetries: 3, recursive: true, force: true });`,
+        ],
+      );
+    }
   } else {
     fs.rmSync(pathname, { maxRetries: 3, recursive: true, force: true });
   }
Repository: denoland/deno
Pull request: fix(help): missing package specifier

Was notified of one more occurance where we were missing an explicit specifier for a `deno add` call.

See https://github.com/denoland/deno/issues/26295#issuecomment-2421637401

Changed files:
filename: cli/args/flags.rs
patch: @@ -1178,7 +1178,7 @@ static DENO_HELP: &str = cstr!(
 
   <y>Dependency management:</>
     <g>add</>          Add dependencies
-                  <p(245)>deno add @std/assert  |  deno add npm:express</>
+                  <p(245)>deno add jsr:@std/assert  |  deno add npm:express</>
     <g>install</>      Install script as an executable
     <g>uninstall</>    Uninstall a script previously installed with deno install
     <g>remove</>       Remove dependencies from the configuration file
Repository: ggml-org/llama.cpp
Pull request: vulkan: update windows SDK in release.yml

Fixes #14230. Followon to #14334.

Changed files:
filename: .github/workflows/release.yml
patch: @@ -302,7 +302,7 @@ jobs:
 
     env:
       OPENBLAS_VERSION: 0.3.23
-      VULKAN_VERSION: 1.4.309.0
+      VULKAN_VERSION: 1.4.313.2
 
     strategy:
       matrix:
@@ -332,7 +332,7 @@ jobs:
         id: get_vulkan
         if: ${{ matrix.backend == 'vulkan' }}
         run: |
-          curl.exe -o $env:RUNNER_TEMP/VulkanSDK-Installer.exe -L "https://sdk.lunarg.com/sdk/download/${env:VULKAN_VERSION}/windows/VulkanSDK-${env:VULKAN_VERSION}-Installer.exe"
+          curl.exe -o $env:RUNNER_TEMP/VulkanSDK-Installer.exe -L "https://sdk.lunarg.com/sdk/download/${env:VULKAN_VERSION}/windows/vulkansdk-windows-X64-${env:VULKAN_VERSION}.exe"
           & "$env:RUNNER_TEMP\VulkanSDK-Installer.exe" --accept-licenses --default-answer --confirm-command install
           Add-Content $env:GITHUB_ENV "VULKAN_SDK=C:\VulkanSDK\${env:VULKAN_VERSION}"
           Add-Content $env:GITHUB_PATH "C:\VulkanSDK\${env:VULKAN_VERSION}\bin"
Repository: denoland/deno
Pull request: fix(ext/node): add null check for kStreamBaseField

It's not guaranteed that `kStreamBaseField` is not undefined, so
added a check for it.

Closes https://github.com/denoland/deno/issues/26363

Changed files:
filename: ext/node/polyfills/internal_binding/tcp_wrap.ts
patch: @@ -300,7 +300,7 @@ export class TCP extends ConnectionWrap {
    * @return An error status code.
    */
   setNoDelay(noDelay: boolean): number {
-    if ("setNoDelay" in this[kStreamBaseField]) {
+    if (this[kStreamBaseField] && "setNoDelay" in this[kStreamBaseField]) {
       this[kStreamBaseField].setNoDelay(noDelay);
     }
     return 0;
Repository: facebook/react
Pull request: move resource acquisition to mutation phase

We initially put the acquisition in layout because we could not guarantee there would be a head mounted during mutation. Now that Singletons have landed we can do this. This does however mean that float is now dependent on singletons and so we can't have enableFloat without also having enableHostSingletons. If there is a way we've encoded these dependent flags in the past let me know and I'll update the PR.

Changed files:
filename: packages/react-reconciler/src/ReactFiberCommitWork.new.js
patch: @@ -1089,19 +1089,6 @@ function commitLayoutEffectOnFiber(
           committedLanes,
         );
 
-        if (flags & Update) {
-          const newResource = finishedWork.memoizedState;
-          if (current !== null) {
-            const currentResource = current.memoizedState;
-            if (currentResource !== newResource) {
-              releaseResource(currentResource);
-            }
-          }
-          finishedWork.stateNode = newResource
-            ? acquireResource(newResource)
-            : null;
-        }
-
         if (flags & Ref) {
           safelyAttachRef(finishedWork, finishedWork.return);
         }
@@ -2617,6 +2604,19 @@ function commitMutationEffectsOnFiber(
             safelyDetachRef(current, current.return);
           }
         }
+
+        if (flags & Update) {
+          const newResource = finishedWork.memoizedState;
+          if (current !== null) {
+            const currentResource = current.memoizedState;
+            if (currentResource !== newResource) {
+              releaseResource(currentResource);
+            }
+          }
+          finishedWork.stateNode = newResource
+            ? acquireResource(newResource)
+            : null;
+        }
         return;
       }
     }

filename: packages/react-reconciler/src/ReactFiberCommitWork.old.js
patch: @@ -1089,19 +1089,6 @@ function commitLayoutEffectOnFiber(
           committedLanes,
         );
 
-        if (flags & Update) {
-          const newResource = finishedWork.memoizedState;
-          if (current !== null) {
-            const currentResource = current.memoizedState;
-            if (currentResource !== newResource) {
-              releaseResource(currentResource);
-            }
-          }
-          finishedWork.stateNode = newResource
-            ? acquireResource(newResource)
-            : null;
-        }
-
         if (flags & Ref) {
           safelyAttachRef(finishedWork, finishedWork.return);
         }
@@ -2617,6 +2604,19 @@ function commitMutationEffectsOnFiber(
             safelyDetachRef(current, current.return);
           }
         }
+
+        if (flags & Update) {
+          const newResource = finishedWork.memoizedState;
+          if (current !== null) {
+            const currentResource = current.memoizedState;
+            if (currentResource !== newResource) {
+              releaseResource(currentResource);
+            }
+          }
+          finishedWork.stateNode = newResource
+            ? acquireResource(newResource)
+            : null;
+        }
         return;
       }
     }
Repository: vercel/next.js
Pull request: [release] fix: `GITHUB_TOKEN` is needed to open release pr

To open a "Version Packages" PR, the Action requires a `GITHUB_TOKEN` token.

Discovered while testing:

![CleanShot 2025-05-25 at 13 38 56@2x](https://github.com/user-attachments/assets/91d6b4b6-0f13-4cf1-85d7-fa309ca3aaa0)


Changed files:
filename: .github/workflows/trigger_release_new.yml
patch: @@ -111,3 +111,5 @@ jobs:
         uses: changesets/action@v1
         with:
           version: pnpm ci:version
+        env:
+          GITHUB_TOKEN: ${{ secrets.RELEASE_BOT_GITHUB_TOKEN }}
Repository: nodejs/node
Pull request: test: improve test description

Refs: https://github.com/nodejs/node/pull/55270#discussion_r1929865237
<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: test/parallel/test-stream-pipe-objectmode-to-non-objectmode.js
patch: @@ -4,8 +4,8 @@ const common = require('../common');
 const assert = require('node:assert');
 const { Readable, Transform, Writable } = require('node:stream');
 
-// Pipeine objects from object mode to non-object mode should throw an error and
-// catch by the consumer
+// Piping objects from object mode to non-object mode in a pipeline should throw
+// an error and catch by the consumer
 {
   const objectReadable = Readable.from([
     { hello: 'hello' },
Repository: electron/electron
Pull request: fix: Linux crash after `webContents.print()` with no parent window

Backport of #44246

See that PR for details.


Notes: Fixed an issue where closing a window after printing on Linux triggered a crash.


Changed files:
filename: patches/chromium/printing.patch
patch: @@ -894,3 +894,23 @@ index e89fd87753bad3c5663fa53f8dcc4542e7e307e5..2b433a0705234af6f9808ee741a9795d
  namespace sandbox::policy {
  
  base::FilePath GetCanonicalPath(const base::FilePath& path) {
+diff --git a/ui/gtk/gtk_util.cc b/ui/gtk/gtk_util.cc
+index d86fbcf969f2fa0d176ead903703ab612e5464c2..6b963ea8401d20e655d068a69105586814bab320 100644
+--- a/ui/gtk/gtk_util.cc
++++ b/ui/gtk/gtk_util.cc
+@@ -227,9 +227,13 @@ aura::Window* GetAuraTransientParent(GtkWidget* dialog) {
+ }
+ 
+ void ClearAuraTransientParent(GtkWidget* dialog, aura::Window* parent) {
++  if (!parent || !parent->GetHost()) {
++    return;
++  }
++
+   g_object_set_data(G_OBJECT(dialog), kAuraTransientParent, nullptr);
+-  GtkUi::GetPlatform()->ClearTransientFor(
+-      parent->GetHost()->GetAcceleratedWidget());
++  gfx::AcceleratedWidget parent_id = parent->GetHost()->GetAcceleratedWidget();
++  GtkUi::GetPlatform()->ClearTransientFor(parent_id);
+ }
+ 
+ base::OnceClosure DisableHostInputHandling(GtkWidget* dialog,
Repository: huggingface/transformers
Pull request: Expose AutoModelForTimeSeriesPrediction for import

Add `AutoModelForTimeSeriesPrediction` to `__all__` in `modeling_auto` so that it can be imported:
```
from transformers import AutoModelForTimeSeriesPrediction
```
This class will be the portal to all time series models in Hugging Face. 

It is a missing part of #34082 and this PR aims to fix it. 


Changed files:
filename: docs/source/en/model_doc/auto.md
patch: @@ -389,3 +389,9 @@ The following auto classes are available for the following multimodal tasks.
 ### AutoModelForImageTextToText
 
 [[autodoc]] AutoModelForImageTextToText
+
+## Time Series
+
+### AutoModelForTimeSeriesPrediction
+
+[[autodoc]] AutoModelForTimeSeriesPrediction

filename: docs/source/ja/model_doc/auto.md
patch: @@ -372,3 +372,10 @@ AutoModel.register(NewModelConfig, NewModel)
 ### AutoModelForImageTextToText
 
 [[autodoc]] AutoModelForImageTextToText
+
+## Time Series
+
+### AutoModelForTimeSeriesPrediction
+
+[[autodoc]] AutoModelForTimeSeriesPrediction
+

filename: docs/source/ko/model_doc/auto.md
patch: @@ -373,3 +373,10 @@ AutoModel.register(NewModelConfig, NewModel)
 ### FlaxAutoModelForVision2Seq[[transformers.FlaxAutoModelForVision2Seq]]
 
 [[autodoc]] FlaxAutoModelForVision2Seq
+
+## Time Series
+
+### AutoModelForTimeSeriesPrediction[[transformers.AutoModelForTimeSeriesPrediction]]
+
+[[autodoc]] AutoModelForTimeSeriesPrediction
+

filename: src/transformers/models/auto/modeling_auto.py
patch: @@ -2103,6 +2103,7 @@ def from_pretrained(cls, pretrained_model_name_or_path, *model_args, **kwargs):
     "AutoModelForTableQuestionAnswering",
     "AutoModelForTextToSpectrogram",
     "AutoModelForTextToWaveform",
+    "AutoModelForTimeSeriesPrediction",
     "AutoModelForTokenClassification",
     "AutoModelForUniversalSegmentation",
     "AutoModelForVideoClassification",
Repository: denoland/deno
Pull request: fix(jupyter): fix panics for overslow subtraction

I don't have a reliable reproduction for it, but it makes it
painful to use the Jupyter kernel with semi-frequent random panics.

The completions don't always work correctly anyway, so I think
it's better to just not panic here for the time being.

Fixes https://github.com/denoland/deno/issues/26340

Changed files:
filename: cli/tools/jupyter/server.rs
patch: @@ -329,7 +329,12 @@ impl JupyterServer {
             })
             .collect();
 
-            (candidates, cursor_pos - prop_name.len())
+            if prop_name.len() > cursor_pos {
+              // TODO(bartlomieju): most likely not correct, but better than panicking because of sub with overflow
+              (candidates, cursor_pos)
+            } else {
+              (candidates, cursor_pos - prop_name.len())
+            }
           } else {
             // combine results of declarations and globalThis properties
             let mut candidates = get_expression_property_names(
@@ -349,7 +354,12 @@ impl JupyterServer {
             candidates.sort();
             candidates.dedup(); // make sure to sort first
 
-            (candidates, cursor_pos - expr.len())
+            if expr.len() > cursor_pos {
+              // TODO(bartlomieju): most likely not correct, but better than panicking because of sub with overflow
+              (candidates, cursor_pos)
+            } else {
+              (candidates, cursor_pos - expr.len())
+            }
           };
 
           connection
Repository: vercel/next.js
Pull request: [release-legacy] fix: set `stable` dist tag for backport releases instead of `latest`

### Why?

If the current version is less than the latest, it means this is a backport release. Since NPM sets the `latest` tag by default during publishing, when users install `next@latest`, they might get the backported version instead of the actual "latest" version. Therefore, we explicitly set the tag as `stable` for backports.



Changed files:
filename: scripts/publish-release.js
patch: @@ -3,6 +3,7 @@
 
 const path = require('path')
 const execa = require('execa')
+const semver = require('semver')
 const { Sema } = require('async-sema')
 const { execSync } = require('child_process')
 const fs = require('fs')
@@ -32,6 +33,34 @@ const cwd = process.cwd()
     }
     throw err
   }
+
+  let tag = isCanary ? 'canary' : isReleaseCandidate ? 'rc' : 'latest'
+
+  try {
+    if (!isCanary && !isReleaseCandidate) {
+      const version = JSON.parse(
+        await fs.promises.readFile(path.join(cwd, 'lerna.json'), 'utf-8')
+      ).version
+
+      const res = await fetch(
+        `https://registry.npmjs.org/-/package/next/dist-tags`
+      )
+      const tags = await res.json()
+
+      if (semver.lt(version, tags.latest)) {
+        // If the current version is less than the latest, it means this
+        // is a backport release. Since NPM sets the 'latest' tag by default
+        // during publishing, when users install `next@latest`, they might
+        // get the backported version instead of the actual "latest" version.
+        // Therefore, we explicitly set the tag as 'stable' for backports.
+        tag = 'stable'
+      }
+    }
+  } catch (error) {
+    console.log('Failed to fetch Next.js dist tags from the NPM registry.')
+    throw error
+  }
+
   console.log(
     `Publishing ${isCanary ? 'canary' : isReleaseCandidate ? 'rc' : 'stable'}`
   )
@@ -57,11 +86,7 @@ const cwd = process.cwd()
           '--access',
           'public',
           '--ignore-scripts',
-          ...(isCanary
-            ? ['--tag', 'canary']
-            : isReleaseCandidate
-              ? ['--tag', 'rc']
-              : []),
+          ['--tag', tag],
         ],
         { stdio: 'pipe' }
       )
Repository: ggml-org/llama.cpp
Pull request: vulkan: update windows SDK in CI

Fixes #14230.

Changed files:
filename: .github/workflows/build.yml
patch: @@ -683,7 +683,7 @@ jobs:
     env:
       OPENBLAS_VERSION: 0.3.23
       SDE_VERSION: 9.33.0-2024-01-07
-      VULKAN_VERSION: 1.4.309.0
+      VULKAN_VERSION: 1.4.313.2
 
     strategy:
       matrix:
@@ -736,7 +736,7 @@ jobs:
         id: get_vulkan
         if: ${{ matrix.build == 'kompute-x64' || matrix.build == 'vulkan-x64' }}
         run: |
-          curl.exe -o $env:RUNNER_TEMP/VulkanSDK-Installer.exe -L "https://sdk.lunarg.com/sdk/download/${env:VULKAN_VERSION}/windows/VulkanSDK-${env:VULKAN_VERSION}-Installer.exe"
+          curl.exe -o $env:RUNNER_TEMP/VulkanSDK-Installer.exe -L "https://sdk.lunarg.com/sdk/download/${env:VULKAN_VERSION}/windows/vulkansdk-windows-X64-${env:VULKAN_VERSION}.exe"
           & "$env:RUNNER_TEMP\VulkanSDK-Installer.exe" --accept-licenses --default-answer --confirm-command install
           Add-Content $env:GITHUB_ENV "VULKAN_SDK=C:\VulkanSDK\${env:VULKAN_VERSION}"
           Add-Content $env:GITHUB_PATH "C:\VulkanSDK\${env:VULKAN_VERSION}\bin"
Repository: electron/electron
Pull request: fix: Linux crash after `webContents.print()` with no parent window

Backport of #44246

See that PR for details.


Notes: Fixed an issue where closing a window after printing on Linux triggered a crash.


Changed files:
filename: patches/chromium/printing.patch
patch: @@ -926,3 +926,23 @@ index 7a65f7f2d68edb74fbaf74fe41949ed9cc198b25..4d7c59e93d71b624d4e93e643932c816
  namespace sandbox::policy {
  
  base::FilePath GetCanonicalPath(const base::FilePath& path) {
+diff --git a/ui/gtk/gtk_util.cc b/ui/gtk/gtk_util.cc
+index d86fbcf969f2fa0d176ead903703ab612e5464c2..6b963ea8401d20e655d068a69105586814bab320 100644
+--- a/ui/gtk/gtk_util.cc
++++ b/ui/gtk/gtk_util.cc
+@@ -227,9 +227,13 @@ aura::Window* GetAuraTransientParent(GtkWidget* dialog) {
+ }
+ 
+ void ClearAuraTransientParent(GtkWidget* dialog, aura::Window* parent) {
++  if (!parent || !parent->GetHost()) {
++    return;
++  }
++
+   g_object_set_data(G_OBJECT(dialog), kAuraTransientParent, nullptr);
+-  GtkUi::GetPlatform()->ClearTransientFor(
+-      parent->GetHost()->GetAcceleratedWidget());
++  gfx::AcceleratedWidget parent_id = parent->GetHost()->GetAcceleratedWidget();
++  GtkUi::GetPlatform()->ClearTransientFor(parent_id);
+ }
+ 
+ base::OnceClosure DisableHostInputHandling(GtkWidget* dialog,
Repository: vercel/next.js
Pull request: [release-old] use `backport` NPM dist tag instead of `stable` for backports

PR https://github.com/vercel/next.js/pull/79596 introduced setting `stable` dist tag for backports, but due to https://github.com/vercel/next.js/pull/79538#pullrequestreview-2866854431, 

> This sounds like something users would use. However, it might point to 14.x when 15.x exists and we would certainly want people to use 14.x. It's also weird that 14.x would have a `stable` tag but not 15.x.
> 
> That's why `backport` makes more sense since it's less specific and not common vernacular when talking about release characteristics (e.g. "experimental", "nightly", "stable", "unstable" etc.).
> 
> The tag could actually just be "internal-backport" and ideally we'd remove it right after publish. The goal here isn't to come up with a useful tag for backports. We just want to work around NPM requiring a tag during publish.

better to use another dist tag: i.e.,`backport`.

Changed files:
filename: scripts/publish-release.js
patch: @@ -52,18 +52,16 @@ const cwd = process.cwd()
         // is a backport release. Since NPM sets the 'latest' tag by default
         // during publishing, when users install `next@latest`, they might
         // get the backported version instead of the actual "latest" version.
-        // Therefore, we explicitly set the tag as 'stable' for backports.
-        tag = 'stable'
+        // Therefore, we explicitly set the tag as 'backport' for backports.
+        tag = 'backport'
       }
     }
   } catch (error) {
     console.log('Failed to fetch Next.js dist tags from the NPM registry.')
     throw error
   }
 
-  console.log(
-    `Publishing ${isCanary ? 'canary' : isReleaseCandidate ? 'rc' : 'stable'}`
-  )
+  console.log(`Publishing as "${tag}" dist tag...`)
 
   if (!process.env.NPM_TOKEN) {
     console.log('No NPM_TOKEN, exiting...')
Repository: facebook/react
Pull request: Fix download-build script

The download-build script works by scraping the CircleCI job number from the GitHub status API. Yes, I know this is super hacky but last I checked this was the least bad of not a lot of options. Because the response is paginated, sometimes the status for the build job exceeds the page size.

This increases the page size to 100 so this is less likely to happen.

It'd be great to find a better way to download the artifacts. I don't love how brittle this solution is. I think switching to the GitHub Checks API might be worth trying, but last I looked into it, it has other flaws.

Changed files:
filename: scripts/release/shared-commands/get-build-id-for-commit.js
patch: @@ -19,7 +19,7 @@ async function getBuildIdForCommit(sha, allowBrokenCI = false) {
   const retryLimit = Date.now() + RETRY_TIMEOUT;
   retry: while (true) {
     const statusesResponse = await fetch(
-      `https://api.github.com/repos/facebook/react/commits/${sha}/status`
+      `https://api.github.com/repos/facebook/react/commits/${sha}/status?per_page=100`
     );
 
     if (!statusesResponse.ok) {
Repository: nodejs/node
Pull request: src: disallow copy/move fns/constructors

Following @addaleax's recommendation on https://github.com/nodejs/node/pull/56452#discussion_r1932994017, let's disallow copy/move functions and constructors on MaybeStackBuffer.

Changed files:
filename: src/debug_utils-inl.h
patch: @@ -50,7 +50,7 @@ struct ToStringHelper {
   template <unsigned BASE_BITS,
             typename T,
             typename = std::enable_if_t<!std::is_integral_v<T>>>
-  static std::string BaseConvert(T value) {
+  static std::string BaseConvert(T& value) {  // NOLINT(runtime/references)
     return Convert(std::forward<T>(value));
   }
 };

filename: src/util.h
patch: @@ -388,6 +388,11 @@ constexpr size_t strsize(const T (&)[N]) {
 template <typename T, size_t kStackStorageSize = 1024>
 class MaybeStackBuffer {
  public:
+  // Disallow copy constructor
+  MaybeStackBuffer(const MaybeStackBuffer&) = delete;
+  // Disallow copy assignment operator
+  MaybeStackBuffer& operator=(const MaybeStackBuffer& other) = delete;
+
   const T* out() const {
     return buf_;
   }
Repository: vercel/next.js
Pull request: Fix --tag argument in publish-release

Somehow `@ts-check` didn't catch this array not being spread anymore. 

Changed files:
filename: scripts/publish-release.js
patch: @@ -86,7 +86,8 @@ const cwd = process.cwd()
           '--access',
           'public',
           '--ignore-scripts',
-          ['--tag', tag],
+          '--tag',
+          tag,
         ],
         { stdio: 'pipe' }
       )