Repository: nodejs/node
Pull request: test: enforce strict mode in test-zlib-const

Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: test/parallel/test-zlib-const.js
patch: @@ -1,4 +1,4 @@
-/* eslint-disable strict */
+'use strict';
 require('../common');
 const assert = require('assert');
 
@@ -9,27 +9,17 @@ assert.strictEqual(zlib.constants.Z_OK, 0,
                      'Expected Z_OK to be 0;',
                      `got ${zlib.constants.Z_OK}`,
                    ].join(' '));
-zlib.constants.Z_OK = 1;
-assert.strictEqual(zlib.constants.Z_OK, 0,
-                   [
-                     'Z_OK should be immutable.',
-                     `Expected to get 0, got ${zlib.constants.Z_OK}`,
-                   ].join(' '));
+
+assert.throws(() => { zlib.constants.Z_OK = 1; },
+              TypeError, 'zlib.constants.Z_OK should be immutable');
 
 assert.strictEqual(zlib.codes.Z_OK, 0,
                    `Expected Z_OK to be 0; got ${zlib.codes.Z_OK}`);
-zlib.codes.Z_OK = 1;
-assert.strictEqual(zlib.codes.Z_OK, 0,
-                   [
-                     'Z_OK should be immutable.',
-                     `Expected to get 0, got ${zlib.codes.Z_OK}`,
-                   ].join(' '));
-zlib.codes = { Z_OK: 1 };
-assert.strictEqual(zlib.codes.Z_OK, 0,
-                   [
-                     'Z_OK should be immutable.',
-                     `Expected to get 0, got ${zlib.codes.Z_OK}`,
-                   ].join(' '));
+assert.throws(() => { zlib.codes.Z_OK = 1; },
+              TypeError, 'zlib.codes.Z_OK should be immutable');
+
+assert.throws(() => { zlib.codes = { Z_OK: 1 }; },
+              TypeError, 'zlib.codes should be immutable');
 
 assert.ok(Object.isFrozen(zlib.codes),
           [