helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: doc: remove confusing and outdated sentence

Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: https://github.com/nodejs/node/issues/55987

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/stream.md
patch: @@ -3846,8 +3846,6 @@ added: v8.0.0
 
 The `_destroy()` method is called by [`writable.destroy()`][writable-destroy].
 It can be overridden by child classes but it **must not** be called directly.
-Furthermore, the `callback` should not be mixed with async/await
-once it is executed when a promise is resolved.
 
 #### `writable._final(callback)`
Repository: facebook/react
Pull request: Update Node.js to latest v14.17.6 LTS

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

<!--
 Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->

I decided to update Node.js to the latest LTS version.
The change affects ci.json and the .nvmrc file.

## How did you test this change?

<!--
  Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
  How exactly did you verify that your PR solves the issue you wanted to solve?
  If you leave this empty, your PR will very likely be closed.
-->

I ran testing scripts (`yarn test`, `yarn test --prod`), building script (`yarn build`) and Flow types checking (`yarn flow dom`). Looks like is working fine.

Changed files:
filename: .codesandbox/ci.json
patch: @@ -1,7 +1,7 @@
 {
   "packages": ["packages/react", "packages/react-dom", "packages/scheduler"],
   "buildCommand": "download-build-in-codesandbox-ci",
-  "node": "12",
+  "node": "14",
   "publishDirectory": {
     "react": "build/oss-experimental/react",
     "react-dom": "build/oss-experimental/react-dom",

filename: .nvmrc
patch: @@ -1 +1 @@
-v12.17.0
+v14.17.6
Repository: nodejs/node
Pull request: fs: fix linter issue

Linter is failing on `main`, it seems https://github.com/nodejs/node/pull/54160 landed with an outdated CI.
<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: lib/internal/fs/utils.js
patch: @@ -723,7 +723,7 @@ const validatePath = hideStackFrames((path, propName = 'path', options) => {
 
   const pathIsString = typeof path === 'string';
   const pathIsUint8Array = isUint8Array(path);
-  if (options && options.expectFile) {
+  if (options?.expectFile) {
     const lastCharacter = path[path.length - 1];
     if (
       lastCharacter === '/' || lastCharacter === 47 ||

filename: test/sequential/test-fs-path-dir.js
patch: @@ -77,7 +77,7 @@ function checkPromiseFn(promiseFn, p, args, fail) {
       console.log(failMsg, err);
       throw err;
     });
-    if (r && r.close) r.close();
+    r?.close?.();
   } else {
     assert.rejects(
       promiseFn(p, ...args), {
Repository: vercel/next.js
Pull request: [font] prefix leading numeric google-font name with underscore

Fixes #77488

Error: https://github.com/vercel/next.js/actions/runs/14414095731/job/40427803167 

> An identifier or keyword cannot immediately follow a numeric literal

Triggered by the [42dot Sans](https://fonts.google.com/specimen/42dot+Sans) font.

Note this leads `family[0]` to be `'4'` which triggers the error... 

> `function 42dot_Sans... // ⚠️⚠️ bad`

Fixed by prepending font names starting with digits (`/\d/.test()`) with an `_`.

(thanks to [this comment ](https://github.com/vercel/next.js/issues/77488#issuecomment-2798920312) from [MoSadie](https://github.com/MoSadie))

Changed files:
filename: scripts/update-google-fonts.js
patch: @@ -66,10 +66,11 @@ const fetch = require('node-fetch')
     const weightTypes = [...weights]
     const styleTypes = [...styles]
 
-    fontFunctions += `export declare function ${family.replaceAll(
-      ' ',
-      '_'
-    )}<T extends CssVariable | undefined = undefined>(options${optionalIfVariableFont}: {
+    fontFunctions += `export declare function ${(/\d/.test(family[0])
+      ? '_' + family
+      : family
+    ).replaceAll(' ', '_')}
+    <T extends CssVariable | undefined = undefined>(options${optionalIfVariableFont}: {
     weight${optionalIfVariableFont}:${formatUnion(
       weightTypes
     )} | Array<${formatUnion(
Repository: denoland/deno
Pull request: fix(net): set correct max size for Datagram

Fixes [#21609](https://github.com/denoland/deno/issues/21609)

Changed files:
filename: ext/net/01_net.js
patch: @@ -28,6 +28,8 @@ import {
   op_set_keepalive,
   op_set_nodelay,
 } from "ext:core/ops";
+const UDP_DGRAM_MAXSIZE = 65507;
+
 const {
   Error,
   Number,
@@ -378,7 +380,7 @@ class DatagramConn {
   #unref = false;
   #promise = null;
 
-  constructor(rid, addr, bufSize = 1024) {
+  constructor(rid, addr, bufSize = UDP_DGRAM_MAXSIZE) {
     this.#rid = rid;
     this.#addr = addr;
     this.bufSize = bufSize;

filename: tests/unit/net_test.ts
patch: @@ -385,6 +385,70 @@ Deno.test(
   },
 );
 
+Deno.test(
+  { permissions: { net: true } },
+  async function netUdpSendReceiveTestSizeLimits() {
+    // Ensure payload being sent is within UDP limit, which seems to be 65507
+    // bytes
+    const alice = Deno.listenDatagram({
+      port: listenPort,
+      transport: "udp",
+      hostname: "127.0.0.1",
+    });
+    // wrap this in a try/catch so other tests can continue if we fail
+    // if we don't close here then listening on future tests fails
+    try {
+      assert(alice.addr.transport === "udp");
+      assertEquals(alice.addr.port, listenPort);
+      assertEquals(alice.addr.hostname, "127.0.0.1");
+    } catch (err) {
+      alice.close();
+      throw err;
+    }
+
+    const bob = Deno.listenDatagram({
+      port: listenPort2,
+      transport: "udp",
+      hostname: "127.0.0.1",
+    });
+    try {
+      assert(bob.addr.transport === "udp");
+      assertEquals(bob.addr.port, listenPort2);
+      assertEquals(bob.addr.hostname, "127.0.0.1");
+    } catch (err) {
+      bob.close();
+      throw err;
+    }
+
+    const sizes = [0, 1, 2, 256, 1024, 4096, 16384, 65506, 65507, 65508, 65536];
+    const rx = /.+ \(os error \d+\)/;
+
+    for (const size of sizes) {
+      const tosend = new Uint8Array(size);
+      let byteLength = 0;
+      try {
+        byteLength = await alice.send(tosend, bob.addr);
+      } catch (err) {
+        // Note: we have to do the test this way as different OS's have
+        // different UDP size limits enabled, so we will just ensure if
+        // an error is thrown it is the one we are expecting.
+        assert(err.message.match(rx));
+        alice.close();
+        bob.close();
+        return;
+      }
+      assertEquals(byteLength, size);
+      const [recvd, remote] = await bob.receive();
+      assert(remote.transport === "udp");
+      assertEquals(remote.port, listenPort);
+      assertEquals(recvd.length, size);
+    }
+
+    alice.close();
+    bob.close();
+  },
+);
+
 Deno.test(
   { permissions: { net: true }, ignore: true },
   async function netUdpSendReceiveBroadcast() {
Repository: huggingface/transformers
Pull request: Remove HQQ from caching allocator warmup

# What does this PR do?

HQQ quantizer injects items in the state dict of the model which are neither parameters nor buffers, and do not seem to be moved to device with usual params (even though they are Tensor).
See https://github.com/huggingface/transformers/issues/37263 here for the bug that was introduced when allowing all quantizers to go through the caching allocator warmup.
So skipping this quantizer from allocation for now, but we truly need to standardize these quantizers.

Changed files:
filename: src/transformers/modeling_utils.py
patch: @@ -4612,6 +4612,7 @@ def _load_pretrained_model(
     ):
         # Useful flags
         is_quantized = hf_quantizer is not None
+        is_hqq = is_quantized and hf_quantizer.quantization_config.quant_method == QuantizationMethod.HQQ
         is_hqq_or_bnb = is_quantized and hf_quantizer.quantization_config.quant_method in [
             QuantizationMethod.HQQ,
             QuantizationMethod.BITS_AND_BYTES,
@@ -4777,7 +4778,7 @@ def _load_pretrained_model(
             expected_keys = hf_quantizer.update_expected_keys(model_to_load, expected_keys, checkpoint_keys)
 
         # Warmup cuda to load the weights much faster on devices
-        if device_map is not None:
+        if device_map is not None and not is_hqq:
             expanded_device_map = expand_device_map(device_map, expected_keys)
             caching_allocator_warmup(model_to_load, expanded_device_map, factor=2 if hf_quantizer is None else 4)
Repository: nodejs/node
Pull request: module: exports & imports runtime deprecate invalid slashes

This is a follow-on to https://github.com/nodejs/node/pull/44477, making the deprecation a runtime deprecation.

Creating now since there may be time to make the runtime deprecation for version 19.

@nodejs/modules 

Changed files:
filename: doc/api/deprecations.md
patch: @@ -3201,13 +3201,16 @@ The [`--trace-atomics-wait`][] flag is deprecated.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/44495
+    description: Runtime deprecation.
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/44477
     description: Documentation-only deprecation
                  with `--pending-deprecation` support.
 -->
 
-Type: Documentation-only (supports [`--pending-deprecation`][])
+Type: Runtime
 
 Package imports and exports targets mapping into paths including a double slash
 (of _"/"_ or _"\\"_) are deprecated and will fail with a resolution validation

filename: lib/internal/modules/esm/resolve.js
patch: @@ -33,7 +33,6 @@ const {
   Stats,
 } = require('fs');
 const { getOptionValue } = require('internal/options');
-const pendingDeprecation = getOptionValue('--pending-deprecation');
 // Do not eagerly grab .manifest, it may be in TDZ
 const policy = getOptionValue('--experimental-policy') ?
   require('internal/process/policy') :
@@ -102,7 +101,6 @@ function emitTrailingSlashPatternDeprecation(match, pjsonUrl, base) {
 const doubleSlashRegEx = /[/\\][/\\]/;
 
 function emitInvalidSegmentDeprecation(target, request, match, pjsonUrl, base) {
-  if (!pendingDeprecation) { return; }
   const pjsonPath = fileURLToPath(pjsonUrl);
   const double = RegExpPrototypeExec(doubleSlashRegEx, target) !== null;
   process.emitWarning(
Repository: facebook/react
Pull request: Reapply changes from #22631

Accidentally reverted these in #22638

Audited the commits listed here to make sure none of those changes were missed: https://github.com/facebook/react/pull/22638#issuecomment-953875125

Changed files:
filename: packages/react-devtools-extensions/src/backend.js
patch: @@ -13,16 +13,15 @@ function welcome(event) {
   ) {
     return;
   }
-  const extensionId = event.data.extensionId;
 
   window.removeEventListener('message', welcome);
 
-  setup(window.__REACT_DEVTOOLS_GLOBAL_HOOK__, extensionId);
+  setup(window.__REACT_DEVTOOLS_GLOBAL_HOOK__);
 }
 
 window.addEventListener('message', welcome);
 
-function setup(hook, extensionId) {
+function setup(hook) {
   if (hook == null) {
     // DevTools didn't get injected into this page (maybe b'c of the contentType).
     return;
@@ -56,7 +55,6 @@ function setup(hook, extensionId) {
         {
           source: 'react-devtools-bridge',
           payload: {event, payload},
-          extensionId,
         },
         '*',
         transferable,

filename: packages/react-devtools-extensions/src/main.js
patch: @@ -27,6 +27,7 @@ const LOCAL_STORAGE_SUPPORTS_PROFILING_KEY =
   'React::DevTools::supportsProfiling';
 
 const isChrome = getBrowserName() === 'Chrome';
+const isEdge = getBrowserName() === 'Edge';
 
 let panelCreated = false;
 
@@ -149,7 +150,7 @@ function createPanelIfReactLoaded() {
 
         store = new Store(bridge, {
           isProfiling,
-          supportsReloadAndProfile: isChrome,
+          supportsReloadAndProfile: isChrome || isEdge,
           supportsProfiling,
           // At this time, the scheduling profiler can only parse Chrome performance profiles.
           supportsSchedulingProfiler: isChrome,
Repository: ggml-org/llama.cpp
Pull request: main : Fix Ctrl+D/newline handling

This restores the behavior from #491. This does not affect Ctrl+D's ability to terminate --multiline-input lines (#1040).

This also actually implements #587: "If the user wants the text to end in a newline, this should be accomplished by explicitly adding a newline by using \ followed by return, then returning control by pressing return again."

Fixes #12949


Changed files:
filename: examples/main/main.cpp
patch: @@ -865,9 +865,22 @@ int main(int argc, char ** argv) {
                 console::set_display(console::reset);
                 display = true;
 
-                // Add tokens to embd only if the input buffer is non-empty
-                // Entering a empty line lets the user pass control back
-                if (buffer.length() > 1) {
+                if (buffer.empty()) { // Ctrl+D on empty line exits
+                    LOG("EOF by user\n");
+                    break;
+                }
+
+                if (buffer.back() == '\n') {
+                    // Implement #587:
+                    // If the user wants the text to end in a newline,
+                    // this should be accomplished by explicitly adding a newline by using \ followed by return,
+                    // then returning control by pressing return again.
+                    buffer.pop_back();
+                }
+
+                if (buffer.empty()) { // Enter key on empty line lets the user pass control back
+                    LOG_DBG("empty line, passing control back\n");
+                } else { // Add tokens to embd only if the input buffer is non-empty
                     // append input suffix if any
                     if (!params.input_suffix.empty() && !params.conversation_mode) {
                         LOG_DBG("appending input suffix: '%s'\n", params.input_suffix.c_str());
@@ -915,8 +928,6 @@ int main(int argc, char ** argv) {
 
                     n_remain -= line_inp.size();
                     LOG_DBG("n_remain: %d\n", n_remain);
-                } else {
-                    LOG_DBG("empty line, passing control back\n");
                 }
 
                 input_echo = false; // do not echo this again
Repository: denoland/deno
Pull request: fix(cli): panic in  --help/-h with OS pipes

fixes #22863

![image](https://github.com/denoland/deno/assets/8139783/da10f72c-d23e-41fd-a6e4-aef888fa502e)


Changed files:
filename: cli/main.rs
patch: @@ -347,7 +347,8 @@ fn resolve_flags_and_init(
       if err.kind() == clap::error::ErrorKind::DisplayHelp
         || err.kind() == clap::error::ErrorKind::DisplayVersion =>
     {
-      err.print().unwrap();
+      // Ignore results to avoid BrokenPipe errors.
+      let _ = err.print();
       std::process::exit(0);
     }
     Err(err) => exit_for_error(AnyError::from(err)),

filename: tests/specs/cli/help_and_version_broken_pipe/__test__.jsonc
patch: @@ -0,0 +1,9 @@
+{
+  "steps": [{
+    "args": "task help",
+    "output": "help.out"
+  }, {
+    "args": "task version",
+    "output": "version.out"
+  }]
+}

filename: tests/specs/cli/help_and_version_broken_pipe/deno.json
patch: @@ -0,0 +1,6 @@
+{
+  "tasks": {
+    "help": "deno help | echo",
+    "version": "deno --version | echo"
+  }
+}

filename: tests/specs/cli/help_and_version_broken_pipe/help.out
patch: @@ -0,0 +1,2 @@
+Task help deno help | echo
+

filename: tests/specs/cli/help_and_version_broken_pipe/version.out
patch: @@ -0,0 +1,2 @@
+Task version deno --version | echo
+
Repository: vercel/next.js
Pull request: Update Turbopack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-build-tests-manifest.json
patch: @@ -18080,6 +18080,24 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/production/app-dir/graceful-degrade-error/graceful-degrade-error-non-bot.test.ts": {
+    "passed": [
+      "graceful-degrade-error - non bot should not degrade to graceful error when chunk loading fails in ssr for non-bot user agents"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
+  "test/production/app-dir/graceful-degrade-error/graceful-degrade-error.test.ts": {
+    "passed": [
+      "graceful-degrade-error should degrade to graceful error when chunk loading fails in ssr for bot"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/production/app-dir/mangle-reserved/mangle-reserved.test.ts": {
     "passed": ["mangle-reserved should preserve the name"],
     "failed": [],
Repository: huggingface/transformers
Pull request: Update translation template

Updates translation template so we stop pinging Maria

Changed files:
filename: .github/ISSUE_TEMPLATE/i18n.md
patch: @@ -23,7 +23,7 @@ Some notes:
 * Please translate in a gender-neutral way.
 * Add your translations to the folder called `<languageCode>` inside the [source folder](https://github.com/huggingface/transformers/tree/main/docs/source).
 * Register your translation in `<languageCode>/_toctree.yml`; please follow the order of the [English version](https://github.com/huggingface/transformers/blob/main/docs/source/en/_toctree.yml).
-* Once you're finished, open a pull request and tag this issue by including #issue-number in the description, where issue-number is the number of this issue. Please ping @stevhliu and @MKhalusova for review.
+* Once you're finished, open a pull request and tag this issue by including #issue-number in the description, where issue-number is the number of this issue. Please ping @stevhliu for review.
 * 🙋 If you'd like others to help you with the translation, you can also post in the 🤗 [forums](https://discuss.huggingface.co/).
 
 ## Get Started section