helloadhavan/github_issues huggingface dataset:
Repository: vercel/next.js
Pull request: [test] add rspack flaky test to build manifest

We already have these failing test cases tracked in rscpack dev manifest but missing in build manifest. When it's running with build manfiest it's still failing.

```
Run export NEXT_EXTERNAL_TESTS_FILTERS="$(pwd)/test/rspack-build-tests-manifest.json"
Filtering tests using manifest: /root/actions-runner/_work/next.js/next.js/test/rspack-build-tests-manifest.json
```

x-ref: https://github.com/vercel/next.js/actions/runs/15557352135/job/43812766616?pr=80356

Changed files:
filename: test/rspack-build-tests-manifest.json
patch: @@ -17765,8 +17765,6 @@
   },
   "test/integration/server-side-dev-errors/test/index.test.js": {
     "passed": [
-      "server-side dev errors should show server-side error for api route correctly",
-      "server-side dev errors should show server-side error for dynamic api route correctly",
       "server-side dev errors should show server-side error for dynamic gssp page correctly",
       "server-side dev errors should show server-side error for gsp page correctly",
       "server-side dev errors should show server-side error for gssp page correctly",
@@ -17775,7 +17773,10 @@
       "server-side dev errors should show server-side error for uncaught exception correctly",
       "server-side dev errors should show server-side error for uncaught rejection correctly"
     ],
-    "failed": [],
+    "failed": [
+      "server-side dev errors should show server-side error for api route correctly",
+      "server-side dev errors should show server-side error for dynamic api route correctly"
+    ],
     "pending": [],
     "flakey": [],
     "runtimeError": false
Repository: nodejs/node
Pull request: doc: ping nodejs/tsc for each security pull request

Refs: https://github.com/nodejs/TSC/issues/1687


Changed files:
filename: doc/contributing/security-release-process.md
patch: @@ -56,6 +56,9 @@ The current security stewards are documented in the main Node.js
     * Use the "summary" feature in HackerOne. Example [2038134](https://hackerone.com/reports/2038134)
     * `git node security --add-report=report_id`
     * `git node security --remove-report=report_id`
+  * Ensure to ping the Node.js TSC team for review of the PRs prior to the release date.
+    * Adding individuals with expertise in the report topic is also a viable option if
+      communicated properly with nodejs/security and TSC.
 
 * [ ] 3\. **Assigning Severity and Writing Team Summary:**
   * [ ] Assign a severity and write a team summary on HackerOne for the reports
Repository: denoland/deno
Pull request: fix: deno_resolver crate without 'sync' feature


Changed files:
filename: resolvers/deno/sync.rs
patch: @@ -13,21 +13,35 @@ mod inner {
 
 #[cfg(not(feature = "sync"))]
 mod inner {
+  use std::cell::Ref;
+  use std::cell::RefCell;
+  use std::collections::HashMap;
+  use std::hash::BuildHasher;
+  use std::hash::Hash;
   use std::hash::RandomState;
   pub use std::rc::Rc as MaybeArc;
 
   // Wrapper struct that exposes a subset of `DashMap` API.
-  #[derive(Default)]
-  struct MaybeDashMap<K, V, S = RandomState>(RefCell<HashMap<K, V, S>>);
+  #[derive(Debug)]
+  pub struct MaybeDashMap<K, V, S = RandomState>(RefCell<HashMap<K, V, S>>);
+
+  impl<K, V, S> Default for MaybeDashMap<K, V, S>
+  where
+    K: Eq + Hash,
+    S: Default + BuildHasher + Clone,
+  {
+    fn default() -> Self {
+      Self(RefCell::new(Default::default()))
+    }
+  }
 
-  impl MaybeDashMap<K, V, S> {
-    pub fn get(&'a self, key: &K) -> Option<&'a V> {
-      let inner = self.0.borrow();
-      inner.get(key)
+  impl<K: Eq + Hash, V, S: BuildHasher> MaybeDashMap<K, V, S> {
+    pub fn get<'a>(&'a self, key: &K) -> Option<Ref<'a, V>> {
+      Ref::filter_map(self.0.borrow(), |map| map.get(key)).ok()
     }
 
     pub fn insert(&self, key: K, value: V) -> Option<V> {
-      let inner = self.0.borrow_mut();
+      let mut inner = self.0.borrow_mut();
       inner.insert(key, value)
     }
   }
Repository: huggingface/transformers
Pull request: Update repo consistency check

The old check is wrong, and doesn't actually test things! My bad, this PR fixes it.

Changed files:
filename: utils/check_repo.py
patch: @@ -683,7 +683,7 @@ def check_all_models_are_tested():
         test_file = [file for file in test_files if f"test_{module.__name__.split('.')[-1]}.py" in file]
         if len(test_file) == 0:
             # We do not test TF or Flax models anymore because they're deprecated.
-            if not (module.__name__.startswith("modeling_tf") or module.__name__.startswith("modeling_flax")):
+            if not ("modeling_tf" in module.__name__ or "modeling_flax" in module.__name__):
                 failures.append(f"{module.__name__} does not have its corresponding test file {test_file}.")
         elif len(test_file) > 1:
             failures.append(f"{module.__name__} has several test files: {test_file}.")
Repository: facebook/react
Pull request: Fix: Selective hydration causing incorrect thenable type passed to DevTools

Selective hydration is implemented by suspending the current render using a special internal opaque object. This is conceptually similar to suspending with a thenable in userspace, but the opaque object should not leak outside of the reconciler.

We were accidentally passing this object to DevTool's markComponentSuspended function, which expects an actual thenable. This happens in the error handling path (handleThrow).

The fix is to check for the exception reason before calling markComponentSuspended. There was already a naive check in place, but it didn't account for all possible enum values of the exception reason.

Changed files:
filename: packages/react-reconciler/src/ReactFiberWorkLoop.js
patch: @@ -1846,19 +1846,34 @@ function handleThrow(root: FiberRoot, thrownValue: any): void {
 
   if (enableSchedulingProfiler) {
     markComponentRenderStopped();
-    if (workInProgressSuspendedReason !== SuspendedOnError) {
-      const wakeable: Wakeable = (thrownValue: any);
-      markComponentSuspended(
-        erroredWork,
-        wakeable,
-        workInProgressRootRenderLanes,
-      );
-    } else {
-      markComponentErrored(
-        erroredWork,
-        thrownValue,
-        workInProgressRootRenderLanes,
-      );
+    switch (workInProgressSuspendedReason) {
+      case SuspendedOnError: {
+        markComponentErrored(
+          erroredWork,
+          thrownValue,
+          workInProgressRootRenderLanes,
+        );
+        break;
+      }
+      case SuspendedOnData:
+      case SuspendedOnImmediate:
+      case SuspendedOnDeprecatedThrowPromise:
+      case SuspendedAndReadyToUnwind: {
+        const wakeable: Wakeable = (thrownValue: any);
+        markComponentSuspended(
+          erroredWork,
+          wakeable,
+          workInProgressRootRenderLanes,
+        );
+        break;
+      }
+      case SuspendedOnHydration: {
+        // This is conceptually like a suspend, but it's not associated with
+        // a particular wakeable. DevTools doesn't seem to care about this case,
+        // currently. It's similar to if the component were interrupted, which
+        // we don't mark with a special function.
+        break;
+      }
     }
   }
 }
Repository: ggml-org/llama.cpp
Pull request: HIP: add GGML_HIP_MMQ_MFMA option to allow disableing the MFMA path.

This is useful for testing for regressions on GCN with CDNA hardware.

With GGML_HIP_MMQ_MFMA=Off and GGML_CUDA_FORCE_MMQ=On we can conveniently test the GCN code path on CDNA. As CDNA is just GCN renamed with MFMA added and limited use ACC registers, this provides a good alternative for regression testing when GCN hardware is not available.


Changed files:
filename: ggml/CMakeLists.txt
patch: @@ -174,6 +174,7 @@ option(GGML_HIP_GRAPHS                      "ggml: use HIP graph, experimental,
 option(GGML_HIP_NO_VMM                      "ggml: do not try to use HIP VMM"                 ON)
 option(GGML_HIP_ROCWMMA_FATTN               "ggml: enable rocWMMA for FlashAttention"         OFF)
 option(GGML_HIP_FORCE_ROCWMMA_FATTN_GFX12   "ggml: enable rocWMMA FlashAttention on GFX12"    OFF)
+option(GGML_HIP_MMQ_MFMA                    "ggml: enable MFMA MMA for CDNA in MMQ"           ON)
 option(GGML_MUSA_GRAPHS                     "ggml: use MUSA graph, experimental, unstable"    OFF)
 option(GGML_MUSA_MUDNN_COPY                 "ggml: enable muDNN for accelerated copy"         OFF)
 option(GGML_VULKAN                          "ggml: use Vulkan"                                OFF)

filename: ggml/src/ggml-cuda/common.cuh
patch: @@ -227,7 +227,7 @@ typedef float2 dfloat2;
 #define FP16_MMA_AVAILABLE
 #endif // defined(GGML_HIP_ROCWMMA_FATTN) && (defined(CDNA) || defined(RDNA3) || (defined(GGML_HIP_ROCWMMA_FATTN_GFX12) && defined(RDNA4)))
 
-#if defined(GGML_USE_HIP) && defined(__HIP_PLATFORM_AMD__) && defined(CDNA3)
+#if defined(GGML_USE_HIP) && defined(__HIP_PLATFORM_AMD__) && defined(CDNA3) && !defined(GGML_HIP_NO_MMQ_MFMA)
 #define AMD_MFMA_AVAILABLE
 #endif // defined(GGML_USE_HIP) && defined(__HIP_PLATFORM_AMD__) && defined(CDNA3)
 
@@ -295,7 +295,11 @@ static bool fp32_mma_hardware_available(const int cc) {
 
 // AMD CDNA3 matrix cores.. Will add support for other CDNA generations later.
 static bool amd_mfma_available(const int cc) {
-    return cc >= GGML_CUDA_CC_OFFSET_AMD && GGML_CUDA_CC_IS_CDNA3(cc);
+#if !defined(GGML_HIP_NO_MMQ_MFMA)
+    return GGML_CUDA_CC_IS_CDNA3(cc);
+#else
+    return false;
+#endif //!defined(GGML_HIP_NO_MMQ_MFMA)
 }
 
 // Volta technically had FP16 tensor cores but they work very differently compared to Turing and later.

filename: ggml/src/ggml-hip/CMakeLists.txt
patch: @@ -113,6 +113,10 @@ if (GGML_HIP_ROCWMMA_FATTN)
     add_compile_definitions(GGML_HIP_ROCWMMA_FATTN)
 endif()
 
+if (NOT GGML_HIP_MMQ_MFMA)
+    add_compile_definitions(GGML_HIP_NO_MMQ_MFMA)
+endif()
+
 if (GGML_HIP_FORCE_ROCWMMA_FATTN_GFX12 OR ${hip_VERSION} VERSION_GREATER_EQUAL 7.0)
     add_compile_definitions(GGML_HIP_ROCWMMA_FATTN_GFX12)
 endif()
Repository: nodejs/node
Pull request: src: handle duplicate paths granted

This commit fixes a crash whenever someone tries to allow access to the same path twice

Changed files:
filename: src/permission/fs_permission.cc
patch: @@ -143,10 +143,12 @@ void FSPermission::Apply(Environment* env,
 
 void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
   const std::string path = WildcardIfDir(res);
-  if (perm == PermissionScope::kFileSystemRead) {
+  if (perm == PermissionScope::kFileSystemRead &&
+      !granted_in_fs_.Lookup(path)) {
     granted_in_fs_.Insert(path);
     deny_all_in_ = false;
-  } else if (perm == PermissionScope::kFileSystemWrite) {
+  } else if (perm == PermissionScope::kFileSystemWrite &&
+             !granted_out_fs_.Lookup(path)) {
     granted_out_fs_.Insert(path);
     deny_all_out_ = false;
   }

filename: test/parallel/test-permission-fs-repeat-path.js
patch: @@ -0,0 +1,40 @@
+// Flags: --permission --allow-fs-read=* --allow-child-process
+'use strict';
+
+const common = require('../common');
+const path = require('path');
+common.skipIfWorker();
+
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+
+{
+  // Relative path as CLI args are supported
+  const { status, stdout } = spawnSync(
+    process.execPath,
+    [
+      '--permission',
+      '--allow-fs-write', path.resolve('../fixtures/permission/deny/regular-file.md'),
+      '--allow-fs-write', path.resolve('../fixtures/permission/deny/regular-file.md'),
+      '--allow-fs-read', path.resolve('../fixtures/permission/deny/regular-file.md'),
+      '--allow-fs-read', path.resolve('../fixtures/permission/deny/regular-file.md'),
+      '-e',
+      `
+      const path = require("path");
+      const absolutePath = path.resolve("../fixtures/permission/deny/regular-file.md");
+      const blockedPath = path.resolve("../fixtures/permission/deny/protected-file.md");
+      console.log(process.permission.has("fs.write", absolutePath));
+      console.log(process.permission.has("fs.read", absolutePath));
+      console.log(process.permission.has("fs.read", blockedPath));
+      console.log(process.permission.has("fs.write", blockedPath));
+       `,
+    ]
+  );
+
+  const [fsWrite, fsRead, fsBlockedRead, fsBlockedWrite] = stdout.toString().split('\n');
+  assert.strictEqual(status, 0);
+  assert.strictEqual(fsWrite, 'true');
+  assert.strictEqual(fsRead, 'true');
+  assert.strictEqual(fsBlockedRead, 'false');
+  assert.strictEqual(fsBlockedWrite, 'false');
+}
Repository: vercel/next.js
Pull request: fix: Revert bugfix for conflicting assets

### What?

Revert https://github.com/vercel/next.js/pull/78011

cc @Karibash

### Why?

Because it caused a regression like https://github.com/vercel/next.js/issues/79938

### How?

Closes https://github.com/vercel/next.js/issues/79938

Closes PACK-4715

Changed files:
filename: packages/next/src/build/webpack/plugins/flight-manifest-plugin.ts
patch: @@ -223,7 +223,7 @@ export class ClientReferenceManifestPlugin {
   }
 
   apply(compiler: webpack.Compiler) {
-    compiler.hooks.thisCompilation.tap(PLUGIN_NAME, (compilation) => {
+    compiler.hooks.compilation.tap(PLUGIN_NAME, (compilation) => {
       compilation.hooks.processAssets.tap(
         {
           name: PLUGIN_NAME,

filename: packages/next/src/build/webpack/plugins/middleware-plugin.ts
patch: @@ -781,7 +781,7 @@ export default class MiddlewarePlugin {
   }
 
   public apply(compiler: webpack.Compiler) {
-    compiler.hooks.thisCompilation.tap(NAME, (compilation, params) => {
+    compiler.hooks.compilation.tap(NAME, (compilation, params) => {
       const { hooks } = params.normalModuleFactory
       /**
        * This is the static code analysis phase.

filename: packages/next/src/build/webpack/plugins/next-trace-entrypoints-plugin.ts
patch: @@ -650,7 +650,7 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
   }
 
   apply(compiler: webpack.Compiler) {
-    compiler.hooks.thisCompilation.tap(PLUGIN_NAME, (compilation) => {
+    compiler.hooks.compilation.tap(PLUGIN_NAME, (compilation) => {
       const compilationSpan =
         getCompilationSpan(compilation) || getCompilationSpan(compiler)!
       const traceEntrypointsPluginSpan = compilationSpan.traceChild(

filename: packages/next/src/build/webpack/plugins/next-types-plugin/index.ts
patch: @@ -1003,7 +1003,7 @@ export class NextTypesPlugin {
       }
     }
 
-    compiler.hooks.thisCompilation.tap(PLUGIN_NAME, (compilation) => {
+    compiler.hooks.compilation.tap(PLUGIN_NAME, (compilation) => {
       compilation.hooks.processAssets.tapAsync(
         {
           name: PLUGIN_NAME,

filename: packages/next/src/build/webpack/plugins/profiling-plugin.ts
patch: @@ -91,7 +91,7 @@ export class ProfilingPlugin {
   traceTopLevelHooks(compiler: any) {
     this.traceHookPair(
       'webpack-compilation',
-      compiler.hooks.thisCompilation,
+      compiler.hooks.compilation,
       compiler.hooks.afterCompile,
       {
         parentSpan: () =>
@@ -146,7 +146,7 @@ export class ProfilingPlugin {
       },
     })
 
-    compiler.hooks.thisCompilation.tap(
+    compiler.hooks.compilation.tap(
       { name: pluginName, stage: -Infinity },
       (compilation: any) => {
         compilation.hooks.buildModule.tap(pluginName, (module: any) => {
Repository: ggml-org/llama.cpp
Pull request: HIP: Ignore unsupported unroll transformation in fattn-vec

llvm with the amdgcn target dose not support unrolling loops with conditional break statements, when those statements can not be resolved at compile time. Similar to other places in GGML lets simply ignore this warning, as we want to keep the unroll as the CUDA compiler may be successfully unrolling this loop, alto if it really manages to do so is unknown since it dose not warn.


Changed files:
filename: ggml/src/ggml-cuda/fattn-vec-f16.cuh
patch: @@ -1,6 +1,12 @@
 #include "common.cuh"
 #include "fattn-common.cuh"
 
+// Currenlty llvm with the amdgcn target dose not support unrolling loops
+// that contain a break that can not be resolved at compile time.
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wpass-failed"
+#endif // __clang__
 template<int D, int ncols, ggml_type type_K, ggml_type type_V, bool use_logit_softcap> // D == head size
 #ifndef GGML_USE_HIP
 __launch_bounds__(D, 1)
@@ -341,6 +347,9 @@ static __global__ void flash_attn_vec_ext_f16(
     NO_DEVICE_CODE;
 #endif // defined(FLASH_ATTN_AVAILABLE) && defined(FP16_AVAILABLE)
 }
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif // __clang__
 
 template <int D, int cols_per_block, ggml_type type_K, ggml_type type_V, bool use_logit_softcap>
 void ggml_cuda_flash_attn_ext_vec_f16_case_impl(ggml_backend_cuda_context & ctx, ggml_tensor * dst) {

filename: ggml/src/ggml-cuda/fattn-vec-f32.cuh
patch: @@ -1,6 +1,12 @@
 #include "common.cuh"
 #include "fattn-common.cuh"
 
+// Currenlty llvm with the amdgcn target dose not support unrolling loops
+// that contain a break that can not be resolved at compile time.
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wpass-failed"
+#endif // __clang__
 template<int D, int ncols, ggml_type type_K, ggml_type type_V, bool use_logit_softcap> // D == head size
 #ifndef GGML_USE_HIP
 __launch_bounds__(D, 1)
@@ -336,6 +342,9 @@ static __global__ void flash_attn_vec_ext_f32(
     NO_DEVICE_CODE;
 #endif // FLASH_ATTN_AVAILABLE
 }
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif // __clang__
 
 template <int D, int cols_per_block, ggml_type type_K, ggml_type type_V, bool use_logit_softcap>
 void ggml_cuda_flash_attn_ext_vec_f32_case_impl(ggml_backend_cuda_context & ctx, ggml_tensor * dst) {
Repository: denoland/deno
Pull request: feat(permission): separate PermissionDeniedError to Retryable and Fatal

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->

This commit separates `PermissionDeniedError` into two kinds; `Retryable` and `Fatal`.

The existing `PermissionDeniedError`s fall into `Retryable`, since permission errors can be resolved by retrying with proper permissions in Deno CLI. The motivation of adding `Fatal` is that in some environments some operations are just disabled; for instance, in Deno Deploy, any write operations to filesystem can never be granted, in which case `Fatal` kind becomes useful.


Changed files:
filename: runtime/permissions/lib.rs
patch: @@ -39,10 +39,11 @@ pub use prompter::PromptCallback;
 pub use prompter::PromptResponse;
 
 #[derive(Debug, thiserror::Error)]
-#[error("Requires {access}, {}", format_permission_error(.name))]
-pub struct PermissionDeniedError {
-  pub access: String,
-  pub name: &'static str,
+pub enum PermissionDeniedError {
+  #[error("Requires {access}, {}", format_permission_error(.name))]
+  Retryable { access: String, name: &'static str },
+  #[error("Requires {access}, which cannot be granted in this environment")]
+  Fatal { access: String },
 }
 
 fn format_permission_error(name: &'static str) -> String {
@@ -144,11 +145,11 @@ impl PermissionState {
     )
   }
 
-  fn error(
+  fn retryable_error(
     name: &'static str,
     info: impl FnOnce() -> Option<String>,
   ) -> PermissionDeniedError {
-    PermissionDeniedError {
+    PermissionDeniedError::Retryable {
       access: Self::fmt_access(name, info),
       name,
     }
@@ -201,10 +202,12 @@ impl PermissionState {
             Self::log_perm_access(name, info);
             (Ok(()), true, true)
           }
-          PromptResponse::Deny => (Err(Self::error(name, info)), true, false),
+          PromptResponse::Deny => {
+            (Err(Self::retryable_error(name, info)), true, false)
+          }
         }
       }
-      _ => (Err(Self::error(name, info)), false, false),
+      _ => (Err(Self::retryable_error(name, info)), false, false),
     }
   }
 }
Repository: denoland/deno
Pull request: fix: upgrade deno_doc to 0.161.3

upgrades itoa requirement to `1.0.14`. needed for #27308 

Changed files:
filename: Cargo.lock
patch: @@ -1575,9 +1575,9 @@ dependencies = [
 
 [[package]]
 name = "deno_doc"
-version = "0.161.2"
+version = "0.161.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3af787319136f3e7f73ef551c618aeec70794522e36cd75ae35132a3bad983ef"
+checksum = "353a39c70d248af04600928cefc8066a9e4535fb6e7d7c518411e5efc822819f"
 dependencies = [
  "anyhow",
  "cfg-if",

filename: cli/Cargo.toml
patch: @@ -72,7 +72,7 @@ deno_ast = { workspace = true, features = ["bundler", "cjs", "codegen", "proposa
 deno_cache_dir.workspace = true
 deno_config.workspace = true
 deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
-deno_doc = { version = "=0.161.2", features = ["rust", "comrak"] }
+deno_doc = { version = "=0.161.3", features = ["rust", "comrak"] }
 deno_graph = { version = "=0.86.3" }
 deno_lint = { version = "=0.68.2", features = ["docs"] }
 deno_lockfile.workspace = true