Repository: facebook/react
Pull request: Flow: add some missing types in react-reconciler

To enable the next Flow version, we need to annotate exported values. This adds a few automatically inferred types that didn't look huge or just `any`.

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

<!--
 Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->

## How did you test this change?

<!--
  Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
  How exactly did you verify that your PR solves the issue you wanted to solve?
  If you leave this empty, your PR will very likely be closed.
-->


Changed files:
filename: packages/react-reconciler/src/ReactFiber.new.js
patch: @@ -693,7 +693,7 @@ export function createFiberFromSuspense(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(SuspenseComponent, pendingProps, key, mode);
   fiber.elementType = REACT_SUSPENSE_TYPE;
   fiber.lanes = lanes;
@@ -705,7 +705,7 @@ export function createFiberFromSuspenseList(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(SuspenseListComponent, pendingProps, key, mode);
   fiber.elementType = REACT_SUSPENSE_LIST_TYPE;
   fiber.lanes = lanes;
@@ -717,7 +717,7 @@ export function createFiberFromOffscreen(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
   fiber.elementType = REACT_OFFSCREEN_TYPE;
   fiber.lanes = lanes;
@@ -736,7 +736,7 @@ export function createFiberFromLegacyHidden(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
   fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
   fiber.lanes = lanes;
@@ -757,7 +757,7 @@ export function createFiberFromCache(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(CacheComponent, pendingProps, key, mode);
   fiber.elementType = REACT_CACHE_TYPE;
   fiber.lanes = lanes;
@@ -769,7 +769,7 @@ export function createFiberFromTracingMarker(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
   fiber.elementType = REACT_TRACING_MARKER_TYPE;
   fiber.lanes = lanes;

filename: packages/react-reconciler/src/ReactFiber.old.js
patch: @@ -693,7 +693,7 @@ export function createFiberFromSuspense(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(SuspenseComponent, pendingProps, key, mode);
   fiber.elementType = REACT_SUSPENSE_TYPE;
   fiber.lanes = lanes;
@@ -705,7 +705,7 @@ export function createFiberFromSuspenseList(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(SuspenseListComponent, pendingProps, key, mode);
   fiber.elementType = REACT_SUSPENSE_LIST_TYPE;
   fiber.lanes = lanes;
@@ -717,7 +717,7 @@ export function createFiberFromOffscreen(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
   fiber.elementType = REACT_OFFSCREEN_TYPE;
   fiber.lanes = lanes;
@@ -736,7 +736,7 @@ export function createFiberFromLegacyHidden(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
   fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
   fiber.lanes = lanes;
@@ -757,7 +757,7 @@ export function createFiberFromCache(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(CacheComponent, pendingProps, key, mode);
   fiber.elementType = REACT_CACHE_TYPE;
   fiber.lanes = lanes;
@@ -769,7 +769,7 @@ export function createFiberFromTracingMarker(
   mode: TypeOfMode,
   lanes: Lanes,
   key: null | string,
-) {
+): Fiber {
   const fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
   fiber.elementType = REACT_TRACING_MARKER_TYPE;
   fiber.lanes = lanes;

filename: packages/react-reconciler/src/ReactFiberAct.new.js
patch: @@ -37,7 +37,7 @@ export function isLegacyActEnvironment(fiber: Fiber): boolean {
   return false;
 }
 
-export function isConcurrentActEnvironment() {
+export function isConcurrentActEnvironment(): void | boolean {
   if (__DEV__) {
     const isReactActEnvironmentGlobal =
       // $FlowFixMe – Flow doesn't know about IS_REACT_ACT_ENVIRONMENT global

filename: packages/react-reconciler/src/ReactFiberAct.old.js
patch: @@ -37,7 +37,7 @@ export function isLegacyActEnvironment(fiber: Fiber): boolean {
   return false;
 }
 
-export function isConcurrentActEnvironment() {
+export function isConcurrentActEnvironment(): void | boolean {
   if (__DEV__) {
     const isReactActEnvironmentGlobal =
       // $FlowFixMe – Flow doesn't know about IS_REACT_ACT_ENVIRONMENT global