Repository: nodejs/node
Pull request: fs: make `dirent.path` writable

Refs: https://github.com/nodejs/node/issues/55538

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/fs.md
patch: @@ -6822,6 +6822,9 @@ deprecated:
   - v20.12.0
   - v18.20.0
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55547
+    description: The property is no longer read-only.
   - version: v23.0.0
     pr-url: https://github.com/nodejs/node/pull/51050
     description: Accessing this property emits a warning. It is now read-only.
@@ -6831,7 +6834,7 @@ changes:
 
 * {string}
 
-Alias for `dirent.parentPath`. Read-only.
+Alias for `dirent.parentPath`.
 
 ### Class: `fs.FSWatcher`
 

filename: lib/internal/fs/utils.js
patch: @@ -49,6 +49,7 @@ const {
   once,
   deprecate,
   isWindows,
+  setOwnProperty,
 } = require('internal/util');
 const { toPathIfFileURL } = require('internal/url');
 const {
@@ -214,6 +215,9 @@ ObjectDefineProperty(Dirent.prototype, 'path', {
   get: deprecate(function() {
     return this.parentPath;
   }, 'dirent.path is deprecated in favor of dirent.parentPath', 'DEP0178'),
+  set(value) {
+    setOwnProperty(this, 'path', value);
+  },
   configurable: true,
   enumerable: false,
 });

filename: test/parallel/test-fs-utils-get-dirents.js
patch: @@ -78,6 +78,18 @@ const filename = 'foo';
     },
     ));
 }
+{
+  // Reassigning `.path` property should not trigger a warning
+  const dirent = getDirent(
+    tmpdir.path,
+    filename,
+    UV_DIRENT_UNKNOWN,
+  );
+  assert.strictEqual(dirent.name, filename);
+  dirent.path = 'some other value';
+  assert.strictEqual(dirent.parentPath, tmpdir.path);
+  assert.strictEqual(dirent.path, 'some other value');
+}
 {
   // string + Buffer
   const filenameBuffer = Buffer.from(filename);