helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: Clean up vestige of useOpaqueIdentifier

Found some code that was left over from the experimental useOpaqueIdentifier hook, which we eventually replaced with useId.

This deletes it.

Changed files:
filename: packages/react-reconciler/src/ReactFiberHooks.new.js
patch: @@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
     hookTypesUpdateIndexDev = -1;
 
     currentHookNameInDev = null;
-
-    isUpdatingOpaqueValueInRenderPhase = false;
   }
 
   didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
   return [isPending, start];
 }
 
-let isUpdatingOpaqueValueInRenderPhase = false;
-export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
-  if (__DEV__) {
-    return isUpdatingOpaqueValueInRenderPhase;
-  }
-}
-
 function mountId(): string {
   const hook = mountWorkInProgressHook();
 

filename: packages/react-reconciler/src/ReactFiberHooks.old.js
patch: @@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
     hookTypesUpdateIndexDev = -1;
 
     currentHookNameInDev = null;
-
-    isUpdatingOpaqueValueInRenderPhase = false;
   }
 
   didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
   return [isPending, start];
 }
 
-let isUpdatingOpaqueValueInRenderPhase = false;
-export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
-  if (__DEV__) {
-    return isUpdatingOpaqueValueInRenderPhase;
-  }
-}
-
 function mountId(): string {
   const hook = mountWorkInProgressHook();
 

filename: packages/react-reconciler/src/ReactFiberWorkLoop.new.js
patch: @@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.new';
 import {
   resetHooksAfterThrow,
   ContextOnlyDispatcher,
-  getIsUpdatingOpaqueValueInRenderPhaseInDEV,
 } from './ReactFiberHooks.new';
 import {DefaultCacheDispatcher} from './ReactFiberCache.new';
 import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
 
 function warnAboutRenderPhaseUpdatesInDEV(fiber) {
   if (__DEV__) {
-    if (
-      ReactCurrentDebugFiberIsRenderingInDEV &&
-      !getIsUpdatingOpaqueValueInRenderPhaseInDEV()
-    ) {
+    if (ReactCurrentDebugFiberIsRenderingInDEV) {
       switch (fiber.tag) {
         case FunctionComponent:
         case ForwardRef:

filename: packages/react-reconciler/src/ReactFiberWorkLoop.old.js
patch: @@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.old';
 import {
   resetHooksAfterThrow,
   ContextOnlyDispatcher,
-  getIsUpdatingOpaqueValueInRenderPhaseInDEV,
 } from './ReactFiberHooks.old';
 import {DefaultCacheDispatcher} from './ReactFiberCache.old';
 import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
 
 function warnAboutRenderPhaseUpdatesInDEV(fiber) {
   if (__DEV__) {
-    if (
-      ReactCurrentDebugFiberIsRenderingInDEV &&
-      !getIsUpdatingOpaqueValueInRenderPhaseInDEV()
-    ) {
+    if (ReactCurrentDebugFiberIsRenderingInDEV) {
       switch (fiber.tag) {
         case FunctionComponent:
         case ForwardRef:
Repository: ggml-org/llama.cpp
Pull request: convert : fix broken sentencepiece vocab

Conversion got broken in #14400

Fixes https://github.com/ggml-org/llama.cpp/pull/14400#issuecomment-3011994259

Changed files:
filename: convert_hf_to_gguf.py
patch: @@ -936,7 +936,11 @@ def _create_vocab_sentencepiece(self):
         scores: list[float] = [-10000.0] * vocab_size
         toktypes: list[int] = [SentencePieceTokenTypes.UNUSED] * vocab_size
 
-        for token_id in range(vocab_size):
+        for token_id in range(tokenizer.vocab_size()):
+            if token_id >= vocab_size:
+                logger.warning(f'ignore tokens from {token_id}: id is out of range, max={vocab_size - 1}')
+                break
+
             piece = tokenizer.IdToPiece(token_id)
             text = piece.encode("utf-8")
             score = tokenizer.GetScore(token_id)
@@ -951,10 +955,6 @@ def _create_vocab_sentencepiece(self):
             elif tokenizer.IsByte(token_id):
                 toktype = SentencePieceTokenTypes.BYTE
 
-            if token_id >= vocab_size:
-                logger.warning(f'ignore tokens from {token_id}: id is out of range, max={vocab_size - 1}')
-                break
-
             tokens[token_id] = text
             scores[token_id] = score
             toktypes[token_id] = toktype
Repository: huggingface/transformers
Pull request: fix typo: `tokenizer` -> `tokenize`

# What does this PR do?

This PR fixes a small but annoying typo.


## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu 

Changed files:
filename: src/transformers/models/gemma3/modeling_gemma3.py
patch: @@ -1079,7 +1079,7 @@ def forward(
 
         >>> inputs = processor.apply_chat_template(
         ...     messages,
-        ...     tokenizer=True,
+        ...     tokenize=True,
         ...     return_dict=True,
         ...     return_tensors="pt",
         ...     add_generation_prompt=True

filename: src/transformers/models/gemma3/modular_gemma3.py
patch: @@ -920,7 +920,7 @@ def forward(
 
         >>> inputs = processor.apply_chat_template(
         ...     messages,
-        ...     tokenizer=True,
+        ...     tokenize=True,
         ...     return_dict=True,
         ...     return_tensors="pt",
         ...     add_generation_prompt=True

filename: src/transformers/utils/doc.py
patch: @@ -910,7 +910,7 @@ def _prepare_output_docstrings(output_type, config_class, min_indent=None, add_i
 
     >>> inputs = processor.apply_chat_template(
     ...     messages,
-    ...     tokenizer=True,
+    ...     tokenize=True,
     ...     return_dict=True,
     ...     return_tensors="pt",
     ...     add_generation_prompt=True
Repository: denoland/deno
Pull request: fix(check): support `--frozen` on deno check

Fixes https://github.com/denoland/deno/issues/26391

Changed files:
filename: cli/args/flags.rs
patch: @@ -1856,6 +1856,7 @@ Unless --reload is specified, this command will not re-download already cached d
             .required_unless_present("help")
             .value_hint(ValueHint::FilePath),
         )
+        .arg(frozen_lockfile_arg())
         .arg(allow_import_arg())
       }
     )
@@ -4373,6 +4374,7 @@ fn check_parse(
   flags.type_check_mode = TypeCheckMode::Local;
   compile_args_without_check_parse(flags, matches)?;
   unstable_args_parse(flags, matches, UnstableArgsConfig::ResolutionAndRuntime);
+  frozen_lockfile_arg_parse(flags, matches);
   let files = matches.remove_many::<String>("file").unwrap().collect();
   if matches.get_flag("all") || matches.get_flag("remote") {
     flags.type_check_mode = TypeCheckMode::All;

filename: tests/specs/lockfile/frozen_lockfile/__test__.jsonc
patch: @@ -183,6 +183,19 @@
           "exitCode": 1
         }
       ]
+    },
+    "check_subcommand": {
+      "steps": [
+        {
+          "args": "check --frozen=true add.ts",
+          "output": "[WILDCARD]The lockfile is out of date[WILDCARD]",
+          "exitCode": 1
+        },
+        {
+          "args": "check --frozen=false add.ts",
+          "output": "[WILDCARD]Check [WILDCARD]add.ts\n"
+        }
+      ]
     }
   }
 }
Repository: vercel/next.js
Pull request: Update Turbopack development test manifest

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-dev-tests-manifest.json
patch: @@ -6132,6 +6132,7 @@
     "passed": [
       "empty-fallback-shells with cached IO and the page not wrapped in Suspense and params.then/catch/finally passed to a cached function does not resume a postponed fallback shell",
       "empty-fallback-shells with cached IO and the page not wrapped in Suspense and the params accessed in a cached non-page function does not resume a postponed fallback shell",
+      "empty-fallback-shells with cached IO and the page not wrapped in Suspense and the params accessed in the cached page does not render a fallback shell when using a params placeholder",
       "empty-fallback-shells with cached IO and the page not wrapped in Suspense and the params accessed in the cached page does not resume a postponed fallback shell",
       "empty-fallback-shells with cached IO and the page wrapped in Suspense and params.then/catch/finally passed to a cached function resumes a postponed fallback shell",
       "empty-fallback-shells with cached IO and the page wrapped in Suspense and the params accessed in cached non-page function resumes a postponed fallback shell",
Repository: nodejs/node
Pull request: doc: only apply content-visibility on all.html

Refs: https://github.com/nodejs/node/issues/40099#issuecomment-2175492569

`content-visibility` is the source of bad anchor scrolling behaviours in [select browsers](https://caniuse.com/?search=content-visibility) that support this rule. This change makes it only apply to the sections in the `all.html` docs page.

Changed files:
filename: doc/api_assets/style.css
patch: @@ -445,7 +445,7 @@ dd + dt.pre {
   padding-top: 1rem;
 }
 
-#apicontent section {
+#api-section-all #apicontent section {
   content-visibility: auto;
   contain-intrinsic-size: 1px auto 5000px;
 }
Repository: denoland/deno
Pull request: fix(cli): increase size of blocking task threadpool on windows

Fixes #26179.

The original error reported in that issue is fixed on canary, but in local testing on my windows machine, `next build` would just hang forever. 

After some digging, what happens is that at some point in next build, readFile promises (from `fs/promises` ) just never resolve, and so next hangs.

It turns out the issue is saturating tokio's blocking task thread pool. We previously limited the number of blocking threads to 32, and at some point those threads are all in use and there's no thread available for the file reads.

What's taking up all of those threads? The answer turns out to be `tokio::process`. On windows, child process stdio uses the blocking threadpool: https://github.com/tokio-rs/tokio/pull/4824. When you poll the child's stdio on windows, it spawns a blocking task per poll, and calls `std::io::Read::read` in the blocking context. That call can block until data is available.
Putting it all together, what happens is that Next.js spawns `2 * the number of CPU cores` deno child subprocesses to do work. We implement `child_process` with `tokio::process`. When the child processes' stdio get polled, blocking tasks get spawned, and those blocking tasks might block until data is available. So if you have 16 cores (as I do), there are going to be potentially >32 blocking task threadpool threads taken just by the child processes. That leaves no room for other tasks to make progress

---

To fix this, for now, increase the size of the blocking threadpool on windows. 4 * the number of CPU cores should be enough to leave room for other tasks to make progress.

Longer term, this can be fixed more properly when we handroll our own subprocess code (needed for detached processes and additional pipes on windows).

Changed files:
filename: runtime/tokio_util.rs
patch: @@ -43,7 +43,15 @@ pub fn create_basic_runtime() -> tokio::runtime::Runtime {
     // parallel for deno fmt.
     // The default value is 512, which is an unhelpfully large thread pool. We
     // don't ever want to have more than a couple dozen threads.
-    .max_blocking_threads(32)
+    .max_blocking_threads(if cfg!(windows) {
+      // on windows, tokio uses blocking tasks for child process IO, make sure
+      // we have enough available threads for other tasks to run
+      4 * std::thread::available_parallelism()
+        .map(|n| n.get())
+        .unwrap_or(8)
+    } else {
+      32
+    })
     .build()
     .unwrap()
 }
Repository: ggml-org/llama.cpp
Pull request: cmake: regen vulkan shaders when shaders-gen sources change

Because adding an external project in cmake does not provide granular source-level dependency tracking, it is required to explicitly add the C++ sources of vulkan-shaders-gen to ensure changes cascade and force shader regeneration.

This is because the external targets provide a generic, higher-level means of building external targets. The vulkan-shaders-gen project is is conceptually an "in-source" build, but external to allow it to work when cross-compiling.

Changed files:
filename: ggml/src/ggml-vulkan/CMakeLists.txt
patch: @@ -143,7 +143,8 @@ if (Vulkan_FOUND)
                    -DCMAKE_BUILD_TYPE=$<CONFIG>
                    ${VULKAN_SHADER_GEN_CMAKE_ARGS}
 
-        BUILD_COMMAND   ${CMAKE_COMMAND} --build   . --config $<CONFIG>
+        BUILD_COMMAND ${CMAKE_COMMAND} --build . --config $<CONFIG>
+        BUILD_ALWAYS  TRUE
 
         # NOTE: When DESTDIR is set using Makefile generators and
         # "make install" triggers the build step, vulkan-shaders-gen
@@ -164,6 +165,14 @@ if (Vulkan_FOUND)
 
     file(GLOB _ggml_vk_shader_files CONFIGURE_DEPENDS "${_ggml_vk_input_dir}/*.comp")
 
+    # Because external projects do not provide source-level tracking,
+    # the vulkan-shaders-gen sources need to be explicitly added to
+    # ensure that changes will cascade into shader re-generation.
+
+    file(GLOB _ggml_vk_shaders_gen_sources
+              CONFIGURE_DEPENDS "${_ggml_vk_input_dir}/*.cpp"
+                                "${_ggml_vk_input_dir}/*.h")
+
     add_custom_command(
         OUTPUT ${_ggml_vk_header}
                ${_ggml_vk_source}
@@ -177,6 +186,7 @@ if (Vulkan_FOUND)
             --no-clean
 
         DEPENDS ${_ggml_vk_shader_files}
+                ${_ggml_vk_shaders_gen_sources}
                 vulkan-shaders-gen
 
         COMMENT "Generate vulkan shaders"
Repository: denoland/deno
Pull request: fix: unpin tokio version

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->

Fixes https://github.com/denoland/deno/issues/26455

Changed files:
filename: Cargo.toml
patch: @@ -187,7 +187,7 @@ tar = "=0.4.40"
 tempfile = "3.4.0"
 termcolor = "1.1.3"
 thiserror = "1.0.61"
-tokio = { version = "=1.36.0", features = ["full"] }
+tokio = { version = "1.36.0", features = ["full"] }
 tokio-metrics = { version = "0.3.0", features = ["rt"] }
 tokio-rustls = { version = "0.26.0", default-features = false, features = ["ring", "tls12"] }
 tokio-socks = "0.5.1"
Repository: denoland/deno
Pull request: fix(fmt): upgrade formatters

Fixes #25926 
Fixes #26004 

Changed files:
filename: Cargo.lock
patch: @@ -4327,9 +4327,9 @@ dependencies = [
 
 [[package]]
 name = "malva"
-version = "0.10.1"
+version = "0.11.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "484beda6e5d775ed06a8ec0fce79e51d39f49d834ed2a29da3f437079321804f"
+checksum = "1c67b97ed99f56b86fa3c010843441f1fcdb71884bab96b8551bb3d1e7c6d529"
 dependencies = [
  "aho-corasick",
  "itertools 0.13.0",
@@ -4340,9 +4340,9 @@ dependencies = [
 
 [[package]]
 name = "markup_fmt"
-version = "0.13.1"
+version = "0.14.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "9dab5ae899659fbe5c8835b2c8ca8d3e357974a3e454138925b404004973361f"
+checksum = "3f15d7b24ae4ea9b87279bc0696462a4fb6c2168847f2cc162a2da05fe1a0f61"
 dependencies = [
  "aho-corasick",
  "css_dataset",

filename: cli/Cargo.toml
patch: @@ -130,8 +130,8 @@ libc.workspace = true
 libz-sys.workspace = true
 log = { workspace = true, features = ["serde"] }
 lsp-types.workspace = true
-malva = "=0.10.1"
-markup_fmt = "=0.13.1"
+malva = "=0.11.0"
+markup_fmt = "=0.14.0"
 memmem.workspace = true
 monch.workspace = true
 notify.workspace = true

filename: cli/tools/fmt.rs
patch: @@ -978,6 +978,7 @@ fn get_resolved_malva_config(
     single_line_top_level_declarations: false,
     selector_override_comment_directive: "deno-fmt-selector-override".into(),
     ignore_comment_directive: "deno-fmt-ignore".into(),
+    ignore_file_comment_directive: "deno-fmt-ignore-file".into(),
   };
 
   FormatOptions {
@@ -1036,6 +1037,7 @@ fn get_resolved_markup_fmt_config(
     svelte_directive_shorthand: Some(true),
     astro_attr_shorthand: Some(true),
     ignore_comment_directive: "deno-fmt-ignore".into(),
+    ignore_file_comment_directive: "deno-fmt-ignore-file".into(),
   };
 
   FormatOptions {
Repository: facebook/react
Pull request: Flight client error stack

restore error message into stack for flight prod errors

Changed files:
filename: packages/react-client/src/ReactFlightClient.js
patch: @@ -646,7 +646,7 @@ export function resolveErrorProd(
       ' builds to avoid leaking sensitive details. A digest property is included on this error instance which' +
       ' may provide additional details about the nature of the error.',
   );
-  error.stack = '';
+  error.stack = 'Error: ' + error.message;
   (error: any).digest = digest;
   const errorWithDigest: ErrorWithDigest = (error: any);
   const chunks = response._chunks;

filename: packages/react-client/src/__tests__/ReactFlight-test.js
patch: @@ -57,6 +57,9 @@ describe('ReactFlight', () => {
               ' may provide additional details about the nature of the error.',
           );
           expect(this.state.error.digest).toContain(this.props.expectedMessage);
+          expect(this.state.error.stack).toBe(
+            'Error: ' + this.state.error.message,
+          );
         }
       }
       render() {
Repository: huggingface/transformers
Pull request: for now disable compile

# What does this PR do?
We should disable compile on CB for now as it breaks on mac. 
Until we have a decorator that only applies it for mac devices

Changed files:
filename: src/transformers/generation/continuous_batching.py
patch: @@ -773,7 +773,6 @@ def setup_static_tensors(self):
 
     @traced
     @torch.no_grad()
-    @torch.compile()
     def reset_static_tensors(self):
         """Reset static tensors for the next batch."""
         self.input_ids.zero_()
@@ -1226,7 +1225,6 @@ def _model_forward(self, batch_data):
         return self.model(**batch_data).logits
 
     @traced(span_name="logit_processing")
-    @torch.compile()
     def _process_logit(self, batch_data, logits):
         return self.logit_processor(batch_data["input_ids"], logits)
Repository: electron/electron
Pull request: fix: respect setAlwaysOnTop before showInactive on Linux under X11

Backport of #44078

See that PR for details.


Notes: Fixed calling setAlwaysOnTop on a hidden window which is then shown with showInactive on Linux under X11. 

Changed files:
filename: shell/browser/native_window_views.cc
patch: @@ -538,6 +538,11 @@ void NativeWindowViews::ShowInactive() {
 #if BUILDFLAG(IS_LINUX)
   if (global_menu_bar_)
     global_menu_bar_->OnWindowMapped();
+
+  // On X11, setting Z order before showing the window doesn't take effect,
+  // so we have to call it again.
+  if (IsX11())
+    widget()->SetZOrderLevel(widget()->GetZOrderLevel());
 #endif
 }
 

filename: spec/api-browser-window-spec.ts
patch: @@ -2512,6 +2512,22 @@ describe('BrowserWindow module', () => {
       expect(c.isAlwaysOnTop()).to.be.true('child is not always on top');
       expect(c._getAlwaysOnTopLevel()).to.equal('screen-saver');
     });
+
+    it('works when called prior to show', async () => {
+      w = new BrowserWindow({ show: false });
+      w.setAlwaysOnTop(true, 'screen-saver');
+      w.show();
+      await setTimeout(1000);
+      expect(w.isAlwaysOnTop()).to.be.true('is not alwaysOnTop');
+    });
+
+    it('works when called prior to showInactive', async () => {
+      w = new BrowserWindow({ show: false });
+      w.setAlwaysOnTop(true, 'screen-saver');
+      w.showInactive();
+      await setTimeout(1000);
+      expect(w.isAlwaysOnTop()).to.be.true('is not alwaysOnTop');
+    });
   });
 
   describe('preconnect feature', () => {
Repository: denoland/deno
Pull request: fix(ext/console): ignore casing for named colors in css parsing

Fixes #26459

Changed files:
filename: ext/console/01_console.js
patch: @@ -2653,6 +2653,7 @@ const HSL_PATTERN = new SafeRegExp(
 );
 
 function parseCssColor(colorString) {
+  colorString = StringPrototypeToLowerCase(colorString);
   if (colorKeywords.has(colorString)) {
     colorString = colorKeywords.get(colorString);
   }

filename: tests/unit/console_test.ts
patch: @@ -1227,6 +1227,7 @@ Deno.test(function consoleParseCssColor() {
   assertEquals(parseCssColor("inherit"), null);
   assertEquals(parseCssColor("black"), [0, 0, 0]);
   assertEquals(parseCssColor("darkmagenta"), [139, 0, 139]);
+  assertEquals(parseCssColor("darkMaGenta"), [139, 0, 139]);
   assertEquals(parseCssColor("slateblue"), [106, 90, 205]);
   assertEquals(parseCssColor("#ffaa00"), [255, 170, 0]);
   assertEquals(parseCssColor("#ffAA00"), [255, 170, 0]);