helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: [v18.x] tools: fix failing GHA workflows

The fix landed on `main` with an unrelated commit (https://github.com/nodejs/node/commit/021cf912084005f4ecd7db06e0bad75353067a46#diff-0d4336c14130a2e69ae463aa9dc439815825ee04ce8419ca65b3428d2af83f17), it seems better to make a new PR for it than to attempt to cherry-pick the original commit.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: tools/dep_updaters/update-openssl.sh
patch: @@ -97,6 +97,8 @@ main() {
     * )
       echo "unknown command: $1"
       help 1
+
+      # shellcheck disable=SC2317
       exit 1
     ;;
   esac
Repository: vercel/next.js
Pull request: Update Turbopack development test manifest

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-dev-tests-manifest.json
patch: @@ -591,6 +591,13 @@
     "flakey": [],
     "runtimeError": false
   },
+  "packages/next/src/client/components/react-dev-overlay/utils/launch-editor.test.ts": {
+    "passed": ["applescript string escaping should escape strings correctly"],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "packages/next/src/client/components/react-dev-overlay/utils/webpack-module-path.test.ts": {
     "passed": [
       "webpack-module-path formatFrameSourceFile should return the original file path",
@@ -5195,6 +5202,8 @@
       "app dir - basic should not share edge workers",
       "app dir - basic should pass props from getServerSideProps in root layout",
       "app dir - basic should return normalized dynamic route params for catch-all edge page",
+      "app dir - basic should return the `vary` header from edge runtime",
+      "app dir - basic should return the `vary` header from pages for flight requests",
       "app dir - basic should serve /index as separate page",
       "app dir - basic should serve dynamic parameter",
       "app dir - basic should serve dynamic route from pages",
@@ -12267,9 +12276,9 @@
   },
   "test/e2e/vary-header/test/index.test.ts": {
     "passed": [
-      "Vary Header Tests should preserve custom vary header",
+      "Vary Header Tests should preserve custom vary header and append RSC headers in app route handlers",
       "Vary Header Tests should preserve custom vary header in API routes",
-      "Vary Header Tests should preserve middleware vary header"
+      "Vary Header Tests should preserve middleware vary header in combination with route handlers"
     ],
     "failed": [],
     "pending": [],
Repository: facebook/react
Pull request: [Tiny] Fixed incorrect import in `react-server-dom-webpack`

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

In https://github.com/facebook/react/pull/25504, `react-server-dom-webpack/` was deprecated in favor of `react-server-dom-webpack/client`, but a remaining import wasn't adjusted accordingly.

As a result, the remaining conditions within the file are no longer firing appropriately, which I ran into while playing around with a fork of [server-components-demo](https://github.com/reactjs/server-components-demo).

The `index.js` file now contains a [placeholder](https://github.com/facebook/react/blob/main/packages/react-server-dom-webpack/index.js) and the actual logic of the client now sits in `/client`.

## How did you test this change?

I replaced `require.resolve('../')` with `require.resolve('../client')` in the `react-server-dom-webpack` package in `node_modules` and confirmed that the output of the build looked good again.

Changed files:
filename: packages/react-server-dom-webpack/src/ReactFlightWebpackPlugin.js
patch: @@ -40,7 +40,7 @@ class ClientReferenceDependency extends ModuleDependency {
 // without the client runtime so it's the first time in the loading sequence
 // you might want them.
 const clientImportName = 'react-server-dom-webpack/client';
-const clientFileName = require.resolve('../');
+const clientFileName = require.resolve('../client');
 
 type ClientReferenceSearchPath = {
   directory: string,
Repository: denoland/deno
Pull request: fix(npm): support version ranges with && or comma

* https://github.com/denoland/deno_semver/pull/38

This adds support for npm packages that have dependencies with `&&` or `,` in their version constraints.

Closes https://github.com/denoland/deno/issues/26168

Changed files:
filename: Cargo.lock
patch: @@ -2058,9 +2058,9 @@ dependencies = [
 
 [[package]]
 name = "deno_semver"
-version = "0.5.14"
+version = "0.5.16"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "670fec7ef309384e23c2a90ac5d2d9d91a776d225306c75f5cdd28cf6cc8a59f"
+checksum = "c957c6a57c38b7dde2315df0da0ec228911e56a74f185b108a488d0401841a67"
 dependencies = [
  "monch",
  "once_cell",

filename: Cargo.toml
patch: @@ -55,7 +55,7 @@ deno_npm = "=0.25.4"
 deno_path_util = "=0.2.1"
 deno_permissions = { version = "0.33.0", path = "./runtime/permissions" }
 deno_runtime = { version = "0.182.0", path = "./runtime" }
-deno_semver = "=0.5.14"
+deno_semver = "=0.5.16"
 deno_terminal = "0.2.0"
 napi_sym = { version = "0.103.0", path = "./cli/napi/sym" }
 test_util = { package = "test_server", path = "./tests/util/server" }
Repository: electron/electron
Pull request: fix: respect setAlwaysOnTop before showInactive on Linux under X11

#### Description of Change

On Linux under X11, setting the Z-order before showing the window apparently does not work properly, so it needs to be called again. This is done in `Show` (since #34766) but not `ShowInactive`. Thus, if a hidden window is set as always-on-top and then shown with `showInactive`, it does not properly end up as always-on-top.

Fix this by copying the relevant code from `Show` to `ShowInactive`, and add some test cases for `setAlwaysOnTop` with `show`/`showInactive` to ensure this doesn't break in the future.

#### Checklist

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes _(except a few failures which seem to be spurious)_
- [x] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed calling setAlwaysOnTop on a hidden window which is then shown with showInactive on Linux under X11. 

Changed files:
filename: shell/browser/native_window_views.cc
patch: @@ -538,6 +538,11 @@ void NativeWindowViews::ShowInactive() {
 #if BUILDFLAG(IS_LINUX)
   if (global_menu_bar_)
     global_menu_bar_->OnWindowMapped();
+
+  // On X11, setting Z order before showing the window doesn't take effect,
+  // so we have to call it again.
+  if (IsX11())
+    widget()->SetZOrderLevel(widget()->GetZOrderLevel());
 #endif
 }
 

filename: spec/api-browser-window-spec.ts
patch: @@ -2514,6 +2514,22 @@ describe('BrowserWindow module', () => {
       expect(c.isAlwaysOnTop()).to.be.true('child is not always on top');
       expect(c._getAlwaysOnTopLevel()).to.equal('screen-saver');
     });
+
+    it('works when called prior to show', async () => {
+      w = new BrowserWindow({ show: false });
+      w.setAlwaysOnTop(true, 'screen-saver');
+      w.show();
+      await setTimeout(1000);
+      expect(w.isAlwaysOnTop()).to.be.true('is not alwaysOnTop');
+    });
+
+    it('works when called prior to showInactive', async () => {
+      w = new BrowserWindow({ show: false });
+      w.setAlwaysOnTop(true, 'screen-saver');
+      w.showInactive();
+      await setTimeout(1000);
+      expect(w.isAlwaysOnTop()).to.be.true('is not alwaysOnTop');
+    });
   });
 
   describe('preconnect feature', () => {
Repository: facebook/react
Pull request: Bug fix when resolving cache

We must use the asynclocalstorage one if it's available.



Changed files:
filename: packages/react-server/src/ReactFlightCache.js
patch: @@ -32,21 +32,23 @@ function resolveCache(): Map<Function, mixed> {
 
 export const DefaultCacheDispatcher: CacheDispatcher = {
   getCacheSignal(): AbortSignal {
-    let entry: AbortSignal | void = (resolveCache().get(createSignal): any);
+    const cache = resolveCache();
+    let entry: AbortSignal | void = (cache.get(createSignal): any);
     if (entry === undefined) {
       entry = createSignal();
       // $FlowFixMe[incompatible-use] found when upgrading Flow
-      currentCache.set(createSignal, entry);
+      cache.set(createSignal, entry);
     }
     return entry;
   },
   getCacheForType<T>(resourceType: () => T): T {
-    let entry: T | void = (resolveCache().get(resourceType): any);
+    const cache = resolveCache();
+    let entry: T | void = (cache.get(resourceType): any);
     if (entry === undefined) {
       entry = resourceType();
       // TODO: Warn if undefined?
       // $FlowFixMe[incompatible-use] found when upgrading Flow
-      currentCache.set(resourceType, entry);
+      cache.set(resourceType, entry);
     }
     return entry;
   },

filename: packages/react/src/__tests__/ReactFetch-test.js
patch: @@ -36,6 +36,7 @@ let React;
 let ReactServerDOMServer;
 let ReactServerDOMClient;
 let use;
+let cache;
 
 describe('ReactFetch', () => {
   beforeEach(() => {
@@ -50,6 +51,7 @@ describe('ReactFetch', () => {
     ReactServerDOMServer = require('react-server-dom-webpack/server.browser');
     ReactServerDOMClient = require('react-server-dom-webpack/client');
     use = React.experimental_use;
+    cache = React.experimental_cache;
   });
 
   async function render(Component) {
@@ -96,6 +98,27 @@ describe('ReactFetch', () => {
     expect(fetchCount).toBe(2);
   });
 
+  // @gate enableFetchInstrumentation && enableCache
+  it('can dedupe cache in micro tasks', async () => {
+    const cached = cache(async () => {
+      fetchCount++;
+      return 'world';
+    });
+    async function getData() {
+      const r1 = await fetch('hello');
+      const t1 = await r1.text();
+      const t2 = await cached();
+      return t1 + ' ' + t2;
+    }
+    function Component() {
+      return use(getData());
+    }
+    expect(await render(Component)).toMatchInlineSnapshot(
+      `"GET hello [] world"`,
+    );
+    expect(fetchCount).toBe(2);
+  });
+
   // @gate enableFetchInstrumentation && enableCache
   it('can dedupe fetches using Request and not', async () => {
     function Component() {
Repository: huggingface/transformers
Pull request: Add support to Marimo Notebooks and Enverge.ai

# What does this PR do?

Adding support to Marimo notebooks so output rendering happens in Python instead of CLI mode.
This is necessary for anyone using Marimo notebooks or doing training at Enverge.ai

This is how using train() at Marimo current looks:

https://github.com/user-attachments/assets/316cc614-b731-4bea-a810-981e0b43b478

This is what this PR delivers:

https://github.com/user-attachments/assets/0706e352-45c5-45f0-914f-0ae7c551c5e3


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Library:
- trainer:
Hi @zach-huggingface and @SunMarc, any feedback would be appreciated, is a very small PR, but my first contribution here :)


Changed files:
filename: src/transformers/utils/import_utils.py
patch: @@ -1222,6 +1222,9 @@ def is_keras_nlp_available():
 
 def is_in_notebook():
     try:
+        # Check if we are running inside Marimo
+        if "marimo" in sys.modules:
+            return True
         # Test adapted from tqdm.autonotebook: https://github.com/tqdm/tqdm/blob/master/tqdm/autonotebook.py
         get_ipython = sys.modules["IPython"].get_ipython
         if "IPKernelApp" not in get_ipython().config:
Repository: nodejs/node
Pull request: [v18.x backport] doc: add history entries for JSON modules stabilization

Backport of https://github.com/nodejs/node/pull/55855

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/esm.md
patch: @@ -7,6 +7,9 @@
 <!-- YAML
 added: v8.5.0
 changes:
+  - version: v18.20.5
+    pr-url: https://github.com/nodejs/node/pull/55333
+    description: Import attributes are no longer experimental.
   - version: v18.20.0
     pr-url: https://github.com/nodejs/node/pull/50140
     description: Add experimental support for import attributes.
@@ -550,6 +553,13 @@ separate cache.
 
 ## JSON modules
 
+<!-- YAML
+changes:
+  - version: v18.20.5
+    pr-url: https://github.com/nodejs/node/pull/55333
+    description: JSON modules are no longer experimental.
+-->
+
 > Stability: 2 - Stable
 
 JSON files can be referenced by `import`:
Repository: electron/electron
Pull request: fix: respect setAlwaysOnTop before showInactive on Linux under X11

Backport of #44078

See that PR for details.


Notes: Fixed calling setAlwaysOnTop on a hidden window which is then shown with showInactive on Linux under X11. 

Changed files:
filename: shell/browser/native_window_views.cc
patch: @@ -543,6 +543,11 @@ void NativeWindowViews::ShowInactive() {
 #if BUILDFLAG(IS_LINUX)
   if (global_menu_bar_)
     global_menu_bar_->OnWindowMapped();
+
+  // On X11, setting Z order before showing the window doesn't take effect,
+  // so we have to call it again.
+  if (IsX11())
+    widget()->SetZOrderLevel(widget()->GetZOrderLevel());
 #endif
 }
 

filename: spec/api-browser-window-spec.ts
patch: @@ -2508,6 +2508,22 @@ describe('BrowserWindow module', () => {
       expect(c.isAlwaysOnTop()).to.be.true('child is not always on top');
       expect(c._getAlwaysOnTopLevel()).to.equal('screen-saver');
     });
+
+    it('works when called prior to show', async () => {
+      w = new BrowserWindow({ show: false });
+      w.setAlwaysOnTop(true, 'screen-saver');
+      w.show();
+      await setTimeout(1000);
+      expect(w.isAlwaysOnTop()).to.be.true('is not alwaysOnTop');
+    });
+
+    it('works when called prior to showInactive', async () => {
+      w = new BrowserWindow({ show: false });
+      w.setAlwaysOnTop(true, 'screen-saver');
+      w.showInactive();
+      await setTimeout(1000);
+      expect(w.isAlwaysOnTop()).to.be.true('is not alwaysOnTop');
+    });
   });
 
   describe('preconnect feature', () => {
Repository: ggml-org/llama.cpp
Pull request: ggml : do not output unprintable characters on GGUF load failure

On failure to load a GGUF the first four characters of the file will be output to the console, leading to all kinds of trouble depending on the characters.

This is especially important to resolve before starting to support GGUF for other kinds of data files, see https://github.com/ggml-org/llama.cpp/pull/9400#pullrequestreview-2955060828

Changed files:
filename: ggml/src/gguf.cpp
patch: @@ -335,7 +335,11 @@ struct gguf_context * gguf_init_from_file_impl(FILE * file, struct gguf_init_par
 
         for (uint32_t i = 0; i < magic.size(); i++) {
             if (magic[i] != GGUF_MAGIC[i]) {
-                GGML_LOG_ERROR("%s: invalid magic characters: '%c%c%c%c', expected 'GGUF'\n", __func__, magic[0], magic[1], magic[2], magic[3]);
+                char c0 = isprint(magic[0]) ? magic[0] : '?';
+                char c1 = isprint(magic[1]) ? magic[1] : '?';
+                char c2 = isprint(magic[2]) ? magic[2] : '?';
+                char c3 = isprint(magic[3]) ? magic[3] : '?';
+                GGML_LOG_ERROR("%s: invalid magic characters: '%c%c%c%c', expected 'GGUF'\n", __func__, c0, c1, c2, c3);
                 gguf_free(ctx);
                 return nullptr;
             }
Repository: facebook/react
Pull request: Revert fetch instrumentation to only RSC

Revert fetch instrumentation so that it only affects RSC by applying it only in the react-server condition of "react".

This helps make the rollout a little smoother because these affects existing libraries that fetch during client components, and then gets forever cached. We need to implement the GC first.

I haven't fully implemented the SSR part anyway.

The main problem that we discovered is that `"react"` and `"react/react.shared-subset"` have separate dispatchers in an environment that runs both Fizz and Flight. That's intentional and sometimes a feature. However, in this case it means that we instrument fetch twice and when you run Flight inside Fizz, that fetch goes into both caches when it's supposed to only see the inner one. I'm not sure how to solve that atm.

Changed files:
filename: packages/react/src/React.js
patch: @@ -71,9 +71,6 @@ import ReactSharedInternals from './ReactSharedInternals';
 import {startTransition} from './ReactStartTransition';
 import {act} from './ReactAct';
 
-// Patch fetch
-import './ReactFetch';
-
 // TODO: Move this branching into the other module instead and just re-export.
 const createElement: any = __DEV__
   ? createElementWithValidation

filename: packages/react/src/ReactSharedSubset.experimental.js
patch: @@ -7,6 +7,9 @@
  * @flow
  */
 
+// Patch fetch
+import './ReactFetch';
+
 export {
   __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED,
   Children,

filename: packages/react/src/__tests__/ReactFetch-test.js
patch: @@ -41,6 +41,9 @@ describe('ReactFetch', () => {
     fetchCount = 0;
     global.fetch = fetchMock;
 
+    if (gate(flags => flags.experimental && !flags.www)) {
+      jest.mock('react', () => require('react/react.shared-subset'));
+    }
     React = require('react');
     ReactServerDOMServer = require('react-server-dom-webpack/server.browser');
     ReactServerDOMClient = require('react-server-dom-webpack/client');