helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: [Fizz] Fix <select> check of defaultValue/value type

I forgot to check that the value is defined so it always warned since either defaultValue or value was not defined.

Changed files:
filename: packages/react-dom/src/server/ReactDOMServerFormatConfig.js
patch: @@ -568,19 +568,22 @@ let didWarnSelectedSetOnOption = false;
 
 function checkSelectProp(props, propName) {
   if (__DEV__) {
-    const array = isArray(props[propName]);
-    if (props.multiple && !array) {
-      console.error(
-        'The `%s` prop supplied to <select> must be an array if ' +
-          '`multiple` is true.',
-        propName,
-      );
-    } else if (!props.multiple && array) {
-      console.error(
-        'The `%s` prop supplied to <select> must be a scalar ' +
-          'value if `multiple` is false.',
-        propName,
-      );
+    const value = props[propName];
+    if (value != null) {
+      const array = isArray(value);
+      if (props.multiple && !array) {
+        console.error(
+          'The `%s` prop supplied to <select> must be an array if ' +
+            '`multiple` is true.',
+          propName,
+        );
+      } else if (!props.multiple && array) {
+        console.error(
+          'The `%s` prop supplied to <select> must be a scalar ' +
+            'value if `multiple` is false.',
+          propName,
+        );
+      }
     }
   }
 }
Repository: ggml-org/llama.cpp
Pull request: server : add speculative decoding presets for FIM

```bash
# 7B target + 0.5 draft
llama-server --fim-qwen-7b-spec

# 14B target + 0.5 draft
llama-server --fim-qwen-14b-spec
```

Changed files:
filename: common/arg.cpp
patch: @@ -2571,5 +2571,43 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         }
     ).set_examples({LLAMA_EXAMPLE_SERVER}));
 
+    add_opt(common_arg(
+        {"--fim-qwen-7b-spec"},
+        string_format("use Qwen 2.5 Coder 7B + 0.5B draft for speculative decoding (note: can download weights from the internet)"),
+        [](common_params & params) {
+            params.hf_repo = "ggml-org/Qwen2.5-Coder-7B-Q8_0-GGUF";
+            params.hf_file = "qwen2.5-coder-7b-q8_0.gguf";
+            params.speculative.hf_repo = "ggml-org/Qwen2.5-Coder-0.5B-Q8_0-GGUF";
+            params.speculative.hf_file = "qwen2.5-coder-0.5b-q8_0.gguf";
+            params.speculative.n_gpu_layers = 99;
+            params.port = 8012;
+            params.n_gpu_layers = 99;
+            params.flash_attn = true;
+            params.n_ubatch = 1024;
+            params.n_batch = 1024;
+            params.n_ctx = 0;
+            params.n_cache_reuse = 256;
+        }
+    ).set_examples({LLAMA_EXAMPLE_SERVER}));
+
+    add_opt(common_arg(
+        {"--fim-qwen-14b-spec"},
+        string_format("use Qwen 2.5 Coder 14B + 0.5B draft for speculative decoding (note: can download weights from the internet)"),
+        [](common_params & params) {
+            params.hf_repo = "ggml-org/Qwen2.5-Coder-14B-Q8_0-GGUF";
+            params.hf_file = "qwen2.5-coder-14b-q8_0.gguf";
+            params.speculative.hf_repo = "ggml-org/Qwen2.5-Coder-0.5B-Q8_0-GGUF";
+            params.speculative.hf_file = "qwen2.5-coder-0.5b-q8_0.gguf";
+            params.speculative.n_gpu_layers = 99;
+            params.port = 8012;
+            params.n_gpu_layers = 99;
+            params.flash_attn = true;
+            params.n_ubatch = 1024;
+            params.n_batch = 1024;
+            params.n_ctx = 0;
+            params.n_cache_reuse = 256;
+        }
+    ).set_examples({LLAMA_EXAMPLE_SERVER}));
+
     return ctx_arg;
 }
Repository: huggingface/transformers
Pull request: Final CI cleanup

@gante's recent PR has mostly resolved the CI issues, but there are a couple more problems left to fix! One is a flaky issue with an unusual error message that isn't caught by the pytest retry pattern, and the other two are actual failures that are blocking the CI. I'm skipping them for now, but we'll need to deal with those.

Changed files:
filename: tests/models/auto/test_tokenization_auto.py
patch: @@ -49,6 +49,7 @@
     DUMMY_UNKNOWN_IDENTIFIER,
     SMALL_MODEL_IDENTIFIER,
     RequestCounter,
+    is_flaky,
     require_tokenizers,
     slow,
 )
@@ -147,6 +148,7 @@ def test_tokenizer_identifier_with_correct_config(self):
             self.assertEqual(tokenizer.model_max_length, 512)
 
     @require_tokenizers
+    @is_flaky()  # This one is flaky even with the new retry logic because it raises an unusual error
     def test_tokenizer_identifier_non_existent(self):
         for tokenizer_class in [BertTokenizer, BertTokenizerFast, AutoTokenizer]:
             with self.assertRaisesRegex(
@@ -439,6 +441,7 @@ def test_revision_not_found(self):
         ):
             _ = AutoTokenizer.from_pretrained(DUMMY_UNKNOWN_IDENTIFIER, revision="aaaaaa")
 
+    @unittest.skip("This test is failing on main")  # TODO Matt/ydshieh, fix this test!
     def test_cached_tokenizer_has_minimum_calls_to_head(self):
         # Make sure we have cached the tokenizer.
         _ = AutoTokenizer.from_pretrained("hf-internal-testing/tiny-random-bert")

filename: tests/utils/test_offline.py
patch: @@ -14,6 +14,7 @@
 
 import subprocess
 import sys
+import unittest
 from typing import Tuple
 
 from transformers import BertConfig, BertModel, BertTokenizer, pipeline
@@ -22,6 +23,7 @@
 
 class OfflineTests(TestCasePlus):
     @require_torch
+    @unittest.skip("This test is failing on main")  # TODO matt/ydshieh, this test needs to be fixed
     def test_offline_mode(self):
         # this test is a bit tricky since TRANSFORMERS_OFFLINE can only be changed before
         # `transformers` is loaded, and it's too late for inside pytest - so we are changing it
Repository: denoland/deno
Pull request: fix: update CLI flags for WPT

Fixes #23500

Changed files:
filename: .github/workflows/ci.generate.ts
patch: @@ -862,13 +862,9 @@ const ci = {
             DENO_BIN: "./target/debug/deno",
           },
           run: [
-            "deno run --allow-env --allow-net --allow-read --allow-run \\",
-            "        --allow-write --unstable                         \\",
-            "        --lock=tools/deno.lock.json                      \\",
+            "deno run -A --unstable --lock=tools/deno.lock.json       \\",
             "        ./tests/wpt/wpt.ts setup",
-            "deno run --allow-env --allow-net --allow-read --allow-run \\",
-            "         --allow-write --unstable                         \\",
-            "         --lock=tools/deno.lock.json              \\",
+            "deno run -A --unstable --lock=tools/deno.lock.json       \\",
             '         ./tests/wpt/wpt.ts run --quiet --binary="$DENO_BIN"',
           ].join("\n"),
         },

filename: .github/workflows/ci.yml
patch: @@ -526,13 +526,9 @@ jobs:
         env:
           DENO_BIN: ./target/debug/deno
         run: |-
-          deno run --allow-env --allow-net --allow-read --allow-run \
-                  --allow-write --unstable                         \
-                  --lock=tools/deno.lock.json                      \
+          deno run -A --unstable --lock=tools/deno.lock.json       \
                   ./tests/wpt/wpt.ts setup
-          deno run --allow-env --allow-net --allow-read --allow-run \
-                   --allow-write --unstable                         \
-                   --lock=tools/deno.lock.json              \
+          deno run -A --unstable --lock=tools/deno.lock.json       \
                    ./tests/wpt/wpt.ts run --quiet --binary="$DENO_BIN"
       - name: Run web platform tests (release)
         if: '!(matrix.skip) && (matrix.wpt && matrix.profile == ''release'')'

filename: .github/workflows/wpt_epoch.yml
patch: @@ -66,12 +66,10 @@ jobs:
       - name: Run web platform tests
         shell: bash
         run: |
-          deno run --unstable --allow-write --allow-read --allow-net           \
-            --allow-env --allow-run --lock=tools/deno.lock.json                \
+          deno run --unstable -A --lock=tools/deno.lock.json                   \
             ./tests/wpt/wpt.ts setup
-          deno run --unstable --allow-write --allow-read --allow-net           \
-            --allow-env --allow-run --lock=tools/deno.lock.json                \
-            ./tests/wpt/wpt.ts run                                                 \                                                \
+          deno run --unstable -A --lock=tools/deno.lock.json                   \
+            ./tests/wpt/wpt.ts run                                             \                                                \
             --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json --exit-zero
 
       - name: Upload wpt results to wpt.fyi
Repository: nodejs/node
Pull request: Update README.md

Changed the command used to verify with SHASUMS256.txt to another that is simpler and allows you to verify all downloads so you don't have to specify each of them one by one.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: README.md
patch: @@ -104,11 +104,10 @@ To download `SHASUMS256.txt` using `curl`:
 curl -O https://nodejs.org/dist/vx.y.z/SHASUMS256.txt
 ```
 
-To check that a downloaded file matches the checksum, run
-it through `sha256sum` with a command such as:
+To check that downloaded files match the checksum, use `sha256sum`:
 
 ```bash
-grep node-vx.y.z.tar.gz SHASUMS256.txt | sha256sum -c -
+sha256sum -c SHASUMS256.txt --ignore-missing
 ```
 
 For Current and LTS, the GPG detached signature of `SHASUMS256.txt` is in
Repository: ggml-org/llama.cpp
Pull request: ggml-backend : make path_str compatible with C++20

#12144 breaks the compatibility with C++20

In C++20, `fs::path::u8string()` return type changed from `std::string` (C++17) to `std::u8string` (C++20+). This PR modifies the `path_str` function to use conditional compilation to detect `__cpp_lib_char8_t` (a standard feature flag introduced in C++20):
- When compiled with C++20+, convert `std::u8string` to `std::string`
- When compiled with C++17, use the returned `std::string` directly

Changed files:
filename: AUTHORS
patch: @@ -1045,3 +1045,4 @@ zrm <trustiosity.zrm@gmail.com>
 蕭澧邦 <45505768+shou692199@users.noreply.github.com>
 谢乃闻 <sienaiwun@users.noreply.github.com>
 Нияз Гарифзянов <112617865+garrnizon@users.noreply.github.com>
+Jason C.H <ctrysbita@outlook.com>

filename: ggml/src/ggml-backend-reg.cpp
patch: @@ -76,7 +76,14 @@ namespace fs = std::filesystem;
 static std::string path_str(const fs::path & path) {
     std::string u8path;
     try {
+#if defined(__cpp_lib_char8_t)
+        // C++20 and later: u8string() returns std::u8string
+        std::u8string u8str = path.u8string();
+        u8path = std::string(reinterpret_cast<const char*>(u8str.c_str()));
+#else
+        // C++17: u8string() returns std::string
         u8path = path.u8string();
+#endif
     } catch (...) {
     }
     return u8path;
Repository: huggingface/transformers
Pull request: fix: fsdp sharded state dict wont work for save_only_model knob

# What does this PR do?

Fixes #36626


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

- trainer: @muellerzr and @SunMarc
@ArthurZucker @Rocketknight1 


Changed files:
filename: src/transformers/trainer.py
patch: @@ -5175,6 +5175,12 @@ def create_accelerator_and_postprocess(self):
             raise ValueError(
                 "`auto_find_batch_size` isn't supported yet with DeepSpeed Zero-3. Please consider using Zero-2, Zero-1, or FSDP"
             )
+        if (
+            self.args.save_only_model
+            and self.is_fsdp_enabled
+            and "SHARDED_STATE_DICT" in str(self.accelerator.state.fsdp_plugin.state_dict_type)
+        ):
+            raise ValueError("save_only_model option is not compatible with FSDP state dict type 'SHARDED_STATE_DICT'")
 
     def propagate_args_to_deepspeed(self, auto_find_batch_size=False):
         """
Repository: vercel/next.js
Pull request: [metadata] add Yeti to html limited bots

### What

Add `Yeti` to html limited bots for serving blocking metadata to the corresponding search engine.

x-ref: https://github.com/vercel/next.js/issues/55524#issuecomment-2699550055

Closes NDX-987

Changed files:
filename: packages/next/src/shared/lib/router/utils/html-bots.ts
patch: @@ -1,4 +1,4 @@
 // This regex contains the bots that we need to do a blocking render for and can't safely stream the response
 // due to how they parse the DOM. For example, they might explicitly check for metadata in the `head` tag, so we can't stream metadata tags after the `head` was sent.
 export const HTML_LIMITED_BOT_UA_RE =
-  /Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview/i
+  /Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti/i

filename: test/production/app-dir/metadata-streaming-config/metadata-streaming-config.test.ts
patch: @@ -11,7 +11,7 @@ describe('app-dir - metadata-streaming-config', () => {
     )
 
     expect(requiredServerFiles.config.htmlLimitedBots).toMatchInlineSnapshot(
-      `"Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview"`
+      `"Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti"`
     )
 
     const prerenderManifest = JSON.parse(
@@ -38,7 +38,7 @@ describe('app-dir - metadata-streaming-config', () => {
        "/ppr": {
          "key": "user-agent",
          "type": "header",
-         "value": "Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview",
+         "value": "Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti",
        },
      }
     `)
Repository: ggml-org/llama.cpp
Pull request: server : infill gen ends on new line

Prevent infill generations from ending in the middle of a line.

Master:

<img width="1114" alt="image" src="https://github.com/user-attachments/assets/01899515-61ee-4ba5-bb7c-06609809afe7" />

PR:

<img width="1120" alt="image" src="https://github.com/user-attachments/assets/1ed5bd07-7c93-4308-8219-a07321781a4f" />


Changed files:
filename: examples/server/server.cpp
patch: @@ -1312,7 +1312,7 @@ struct server_slot {
         return task_type == SERVER_TASK_TYPE_EMBEDDING || task_type == SERVER_TASK_TYPE_RERANK;
     }
 
-    bool can_batch_with(server_slot & other_slot) {
+    bool can_batch_with(server_slot & other_slot) const {
         return is_non_causal() == other_slot.is_non_causal()
             && are_lora_equal(lora, other_slot.lora);
     }
@@ -2157,14 +2157,6 @@ struct server_context {
         }
 
         if (slot.has_new_line) {
-            // if we have already seen a new line, we stop after a certain time limit
-            if (slot.params.t_max_predict_ms > 0 && (ggml_time_us() - slot.t_start_generation > 1000.0f*slot.params.t_max_predict_ms)) {
-                slot.stop           = STOP_TYPE_LIMIT;
-                slot.has_next_token = false;
-
-                SLT_DBG(slot, "stopped by time limit, n_decoded = %d, t_max_predict_ms = %d ms\n", slot.n_decoded, (int) slot.params.t_max_predict_ms);
-            }
-
             // require that each new line has a whitespace prefix (i.e. indentation) of at least slot.params.n_indent
             if (slot.params.n_indent > 0) {
                 // check the current indentation
@@ -2203,6 +2195,14 @@ struct server_context {
         // check if there is a new line in the generated text
         if (result.text_to_send.find('\n') != std::string::npos) {
             slot.has_new_line = true;
+
+            // if we have seen a new line, we stop after a certain time limit, but only upon another new line
+            if (slot.params.t_max_predict_ms > 0 && (ggml_time_us() - slot.t_start_generation > 1000.0f*slot.params.t_max_predict_ms)) {
+                slot.stop           = STOP_TYPE_LIMIT;
+                slot.has_next_token = false;
+
+                SLT_DBG(slot, "stopped by time limit, n_decoded = %d, t_max_predict_ms = %d ms\n", slot.n_decoded, (int) slot.params.t_max_predict_ms);
+            }
         }
 
         // if context shift is disabled, we stop when it reaches the context limit
Repository: facebook/react
Pull request: Expose Fizz in stable builds

We want to let people test it with the prereleases so let's expose it in all builds.

Changed files:
filename: scripts/rollup/bundles.js
patch: @@ -267,16 +267,14 @@ const bundles = [
 
   /******* React DOM Fizz Server *******/
   {
-    bundleTypes: __EXPERIMENTAL__
-      ? [NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD]
-      : [],
+    bundleTypes: [NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD],
     moduleType: RENDERER,
     entry: 'react-dom/unstable-fizz.browser',
     global: 'ReactDOMFizzServer',
     externals: ['react', 'react-dom/server'],
   },
   {
-    bundleTypes: __EXPERIMENTAL__ ? [NODE_DEV, NODE_PROD] : [],
+    bundleTypes: [NODE_DEV, NODE_PROD],
     moduleType: RENDERER,
     entry: 'react-dom/unstable-fizz.node',
     global: 'ReactDOMFizzServer',
Repository: nodejs/node
Pull request: build: fix GN build for cares/uv deps

Fix failures in GN build caused by updates of deps.

Changed files:
filename: deps/cares/unofficial.gni
patch: @@ -38,7 +38,10 @@ template("cares_gn_build") {
       ]
     }
 
-    include_dirs = [ "src/lib" ]
+    include_dirs = [
+      "src/lib",
+      "src/lib/include",
+    ]
     if (is_win) {
       include_dirs += [ "config/win32" ]
     } else if (is_linux) {
@@ -55,9 +58,6 @@ template("cares_gn_build") {
     }
 
     sources = gypi_values.cares_sources_common
-    if (is_win) {
-      sources += gypi_values.cares_sources_win
-    }
     if (is_linux) {
       sources += [ "config/linux/ares_config.h" ]
     }

filename: deps/uv/unofficial.gni
patch: @@ -40,6 +40,7 @@ template("uv_gn_build") {
         "-Wno-extra-semi",
         "-Wno-implicit-fallthrough",
         "-Wno-missing-braces",
+        "-Wno-sign-compare",
         "-Wno-string-conversion",
         "-Wno-shadow",
         "-Wno-unreachable-code",

filename: unofficial.gni
patch: @@ -68,6 +68,7 @@ template("node_gn_build") {
       "-Wno-extra-semi",
       "-Wno-implicit-fallthrough",
       "-Wno-macro-redefined",
+      "-Wno-missing-braces",
       "-Wno-return-type",
       "-Wno-shadow",
       "-Wno-sometimes-uninitialized",
Repository: denoland/deno
Pull request: fix(ext/node): define http.maxHeaderSize

Closes https://github.com/denoland/deno/issues/23432

Changed files:
filename: ext/node/polyfills/http.ts
patch: @@ -1820,6 +1820,8 @@ export function get(...args: any[]) {
   return req;
 }
 
+export const maxHeaderSize = 16_384;
+
 export {
   Agent,
   ClientRequest,
@@ -1848,4 +1850,5 @@ export default {
   get,
   validateHeaderName,
   validateHeaderValue,
+  maxHeaderSize,
 };

filename: tests/unit_node/http_test.ts
patch: @@ -998,3 +998,7 @@ Deno.test("[node/http] ServerResponse getHeaders", () => {
   assertEquals(res.getHeaderNames(), ["bar", "foo"]);
   assertEquals(res.getHeaders(), { "bar": "baz", "foo": "bar" });
 });
+
+Deno.test("[node/http] maxHeaderSize is defined", () => {
+  assertEquals(http.maxHeaderSize, 16_384);
+});