helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: [v18.x] test: skip and mark flaky some tests

Most those test have either been fixed in a semver-minor way on later release lines, or seems to not affect the other release lines for another reason.
<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: test/parallel/parallel.status
patch: @@ -34,6 +34,8 @@ test-domain-error-types: PASS,FLAKY
 test-file-write-stream4: PASS,FLAKY
 # https://github.com/nodejs/node/issues/43465
 test-http-server-request-timeouts-mixed: PASS, FLAKY
+# https://github.com/nodejs/node/issues/50046
+test-inspector-stop-profile-after-done: PASS, FLAKY
 
 [$system==linux || $system==win32]
 # https://github.com/nodejs/node/issues/49605
Repository: denoland/deno
Pull request: fix(upgrade): stop running `deno lsp` processes on windows before attempting to replace executable

It's such a PITA on Windows to get the error that you need to run `Stop-Process -name deno` to kill running Deno processes. Most of the time this is just running `deno lsp` commands, so we can safely kill those before replacing the executable.

Changed files:
filename: cli/tools/upgrade.rs
patch: @@ -579,6 +579,10 @@ pub async fn upgrade(
 
   let output_exe_path =
     full_path_output_flag.as_ref().unwrap_or(&current_exe_path);
+
+  #[cfg(windows)]
+  kill_running_deno_lsp_processes();
+
   let output_result = if *output_exe_path == current_exe_path {
     replace_exe(&new_exe_path, output_exe_path)
   } else {
@@ -966,6 +970,34 @@ fn check_windows_access_denied_error(
   })
 }
 
+#[cfg(windows)]
+fn kill_running_deno_lsp_processes() {
+  // limit this to `deno lsp` invocations to avoid killing important programs someone might be running
+  let is_debug = log::log_enabled!(log::Level::Debug);
+  let get_pipe = || {
+    if is_debug {
+      std::process::Stdio::inherit()
+    } else {
+      std::process::Stdio::null()
+    }
+  };
+  let _ = Command::new("powershell.exe")
+    .args([
+      "-Command",
+      r#"Get-WmiObject Win32_Process | Where-Object {
+    $_.Name -eq 'deno.exe' -and
+    $_.CommandLine -match '^(?:\"[^\"]+\"|\S+)\s+lsp\b'
+} | ForEach-Object {
+  if ($_.Terminate()) {
+    Write-Host 'Terminated:' $_.ProcessId
+  }
+}"#,
+    ])
+    .stdout(get_pipe())
+    .stderr(get_pipe())
+    .output();
+}
+
 fn set_exe_permissions(
   current_exe_path: &Path,
   output_exe_path: &Path,
Repository: nodejs/node
Pull request: src: add self-assigment memcpy checks

Fixes: https://github.com/nodejs/node/issues/56718

Maybe it's pointless, but imho more clear



Changed files:
filename: src/node_sockaddr-inl.h
patch: @@ -79,12 +79,16 @@ SocketAddress::SocketAddress(const SocketAddress& addr) {
 }
 
 SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
-  memcpy(&address_, addr, GetLength(addr));
+  if (reinterpret_cast<const sockaddr*>(&address_) != addr) {
+    memcpy(&address_, addr, GetLength(addr));
+  }
   return *this;
 }
 
 SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
-  memcpy(&address_, &addr.address_, addr.length());
+  if (this != &addr) {
+    memcpy(&address_, &addr.address_, addr.length());
+  }
   return *this;
 }
Repository: denoland/deno
Pull request: fix(install): regression - do not panic when config file contains \r\n newlines

This is specifically for `deno install`/`deno add` commands.

* https://github.com/dprint/jsonc-parser/pull/49

Closes https://github.com/denoland/deno/issues/26543

Changed files:
filename: Cargo.lock
patch: @@ -4005,9 +4005,9 @@ dependencies = [
 
 [[package]]
 name = "jsonc-parser"
-version = "0.26.1"
+version = "0.26.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "57c78ad024523b61a2f20b1cad47413dd24db744a15d3d1b7276e69d1bee106c"
+checksum = "b558af6b49fd918e970471374e7a798b2c9bbcda624a210ffa3901ee5614bc8e"
 dependencies = [
  "serde_json",
 ]

filename: Cargo.toml
patch: @@ -137,7 +137,7 @@ hyper-util = { version = "=0.1.7", features = ["tokio", "client", "client-legacy
 hyper_v014 = { package = "hyper", version = "0.14.26", features = ["runtime", "http1"] }
 indexmap = { version = "2", features = ["serde"] }
 ipnet = "2.3"
-jsonc-parser = { version = "=0.26.1", features = ["serde"] }
+jsonc-parser = { version = "=0.26.2", features = ["serde"] }
 lazy-regex = "3"
 libc = "0.2.126"
 libz-sys = { version = "1.1.20", default-features = false }
Repository: ggml-org/llama.cpp
Pull request: sync : ggml


Changed files:
filename: ggml/src/ggml.c
patch: @@ -4458,7 +4458,7 @@ static struct ggml_tensor * ggml_interpolate_impl(
         int64_t               ne3,
         uint32_t              mode) {
     GGML_ASSERT((mode & 0xFF) < GGML_SCALE_MODE_COUNT);
-    
+
     struct ggml_tensor * result = ggml_new_tensor_4d(ctx, a->type, ne0, ne1, ne2, ne3);
 
     ggml_set_op_params_i32(result, 0, (int32_t)mode);
Repository: nodejs/node
Pull request: doc: update options to include signal in filehandle.writeFile()

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


This PR updates the documentation for `filehandle.writeFile()` to include the signal option in the options parameter. 

This is my first pull request to this repository, and I understand there may be areas for improvement. I would appreciate your review and feedback.




Changed files:
filename: doc/api/fs.md
patch: @@ -805,6 +805,7 @@ changes:
 * `options` {Object|string}
   * `encoding` {string|null} The expected character encoding when `data` is a
     string. **Default:** `'utf8'`
+  * `signal` {AbortSignal|undefined} allows aborting an in-progress writeFile. **Default:** `undefined`
 * Returns: {Promise}
 
 Asynchronously writes data to a file, replacing the file if it already exists.
Repository: vercel/next.js
Pull request: Turbopack Build: Fix conflicting page error

## What?

Implements the missing part of the error to make the test pass.

Small difference between webpack/Turbopack is that Turbopack will spot the conflict earlier and because of that errors earlier too, making the path still correct but shorter, not a problem in my opinion.

Closes PACK-4691

Changed files:
filename: crates/next-core/src/app_structure.rs
patch: @@ -767,6 +767,7 @@ fn directory_tree_to_entrypoints(
 #[turbo_tasks::value]
 struct DuplicateParallelRouteIssue {
     app_dir: ResolvedVc<FileSystemPath>,
+    previously_inserted_page: AppPage,
     page: AppPage,
 }
 
@@ -783,11 +784,17 @@ impl Issue for DuplicateParallelRouteIssue {
     }
 
     #[turbo_tasks::function]
-    fn title(self: Vc<Self>) -> Vc<StyledString> {
-        StyledString::Text(
-            "You cannot have two parallel pages that resolve to the same path.".into(),
+    async fn title(self: Vc<Self>) -> Result<Vc<StyledString>> {
+        let this = self.await?;
+        Ok(StyledString::Text(
+            format!(
+                "You cannot have two parallel pages that resolve to the same path. Please check \
+                 {} and {}.",
+                this.previously_inserted_page, this.page
+            )
+            .into(),
         )
-        .cell()
+        .cell())
     }
 }
 
@@ -826,6 +833,7 @@ async fn check_duplicate(
             if prev != page_path {
                 DuplicateParallelRouteIssue {
                     app_dir: app_dir.to_resolved().await?,
+                    previously_inserted_page: prev.clone(),
                     page: loader_tree.page.clone(),
                 }
                 .resolved_cell()

filename: test/e2e/app-dir/conflicting-page-segments/conflicting-page-segments.test.ts
patch: @@ -1,5 +1,5 @@
 import { nextTestSetup } from 'e2e-utils'
-import { check } from 'next-test-utils'
+import { retry } from 'next-test-utils'
 
 describe('conflicting-page-segments', () => {
   const { next, isNextDev, skipped } = nextTestSetup({
@@ -25,10 +25,11 @@ describe('conflicting-page-segments', () => {
     } else {
       await expect(next.start()).rejects.toThrow('next build failed')
 
-      await check(
-        () => next.cliOutput,
-        /You cannot have two parallel pages that resolve to the same path\. Please check \/\(group-a\)\/page and \/\(group-b\)\/page\./i
-      )
+      await retry(() => {
+        expect(next.cliOutput).toMatch(
+          /You cannot have two parallel pages that resolve to the same path\. Please check \/\(group-a\)(\/page)? and \/\(group-b\)(\/page)?\./i
+        )
+      })
     }
   })
 })

filename: test/turbopack-build-tests-manifest.json
patch: @@ -1641,10 +1641,10 @@
     "runtimeError": false
   },
   "test/e2e/app-dir/conflicting-page-segments/conflicting-page-segments.test.ts": {
-    "passed": [],
-    "failed": [
+    "passed": [
       "conflicting-page-segments should throw an error when a route groups causes a conflict with a parallel segment"
     ],
+    "failed": [],
     "pending": [],
     "flakey": [],
     "runtimeError": false
Repository: denoland/deno
Pull request: build: use 'fs' feature of 'nix' crate in ext/fs

Hot-fix to unblock `v2.0.3` release

Changed files:
filename: ext/fs/Cargo.toml
patch: @@ -31,7 +31,7 @@ serde.workspace = true
 thiserror.workspace = true
 
 [target.'cfg(unix)'.dependencies]
-nix = { workspace = true, features = ["user"] }
+nix = { workspace = true, features = ["fs", "user"] }
 
 [target.'cfg(windows)'.dependencies]
 winapi = { workspace = true, features = ["winbase"] }
Repository: nodejs/node
Pull request: build: fix GN build of uv

Which was broken after 756a24242ed6dd99be7ccaed68346c3b9fd1bbea.

Changed files:
filename: deps/uv/unofficial.gni
patch: @@ -90,7 +90,7 @@ template("uv_gn_build") {
       ldflags = [ "-pthread" ]
     }
     if (is_linux) {
-      libs += [
+      libs = [
         "m",
         "dl",
         "rt",
Repository: denoland/deno
Pull request: fix(install): don't cache json exports of JSR packages (for now)

Temporary fix for #26509, so people don't get errors.

Changed files:
filename: cli/tools/registry/pm/cache_deps.rs
patch: @@ -90,8 +90,13 @@ pub async fn cache_top_level_deps(
     while let Some(info_future) = info_futures.next().await {
       if let Some((specifier, info)) = info_future {
         let exports = info.exports();
-        for (k, _) in exports {
+        for (k, v) in exports {
           if let Ok(spec) = specifier.join(k) {
+            if v.ends_with(".json") {
+              // TODO(nathanwhit): this should work, there's a bug with
+              // json roots in deno_graph. skip it for now
+              continue;
+            }
             roots.push(spec);
           }
         }
Repository: electron/electron
Pull request: build: update appveyor image to latest version

Backport of #44334

See that PR for details.


Notes: none

Changed files:
filename: appveyor-woa.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6781.0
+image: e-132.0.6788.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default

filename: appveyor.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6781.0
+image: e-132.0.6788.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default
Repository: denoland/deno
Pull request: fix: add 'fmt-component' to unstable features in schema file

Closes https://github.com/denoland/deno/issues/26510

Changed files:
filename: cli/schemas/config-file.v1.json
patch: @@ -531,6 +531,7 @@
           "detect-cjs",
           "ffi",
           "fs",
+          "fmt-component",
           "http",
           "kv",
           "net",
Repository: huggingface/transformers
Pull request: [tests] remove overload for deleted test (`test_offloaded_cache_implementation`)

# What does this PR do?

`test_offloaded_cache_implementation` was deleted in #37724 

This PR deletes stray overloads (which were skipping the test)

Changed files:
filename: tests/models/mllama/test_modeling_mllama.py
patch: @@ -17,7 +17,6 @@
 
 import pytest
 import requests
-from parameterized import parameterized
 
 from transformers import (
     AutoProcessor,
@@ -396,12 +395,6 @@ def test_sdpa_can_compile_dynamic(self):
     def test_model_parallelism(self):
         pass
 
-    @parameterized.expand([("offloaded",)])
-    @pytest.mark.generate
-    @unittest.skip(reason="Offloaded cache seems to not work with mllama's kv cache type")
-    def test_offloaded_cache_implementation(self, cache_implementation):
-        pass
-
     @unittest.skip(
         reason="Mllama cache type doesn't allow correct check on output `past_key_values` due to `Cache.crop()`"
     )

filename: tests/models/whisper/test_modeling_whisper.py
patch: @@ -546,12 +546,6 @@ def test_training_gradient_checkpointing_use_reentrant_false(self):
     def test_generate_with_head_masking(self):
         pass
 
-    @parameterized.expand([("offloaded",)])
-    @pytest.mark.generate
-    @unittest.skip(reason="Whisper doesn't work with offloaded cache implementation yet")
-    def test_offloaded_cache_implementation(self, cache_implementation):
-        pass
-
     @require_torch_fp16
     def test_generate_fp16(self):
         config, input_dict = self.model_tester.prepare_config_and_inputs()
Repository: electron/electron
Pull request: build: update appveyor image to latest version

This PR updates appveyor.yml to the latest baked image, e-132.0.6788.0.

Notes: none

Changed files:
filename: appveyor-woa.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6781.0
+image: e-132.0.6788.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default

filename: appveyor.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6781.0
+image: e-132.0.6788.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default
Repository: ggml-org/llama.cpp
Pull request: ggml-cpu: sycl: Re-enable exp f16

Following https://github.com/ggml-org/llama.cpp/pull/14317, the support for fp16 EXP was disabled in https://github.com/ggml-org/llama.cpp/pull/14395.

The main issue is that the icpx compiler essentially enables `-ffast-math` (or part of it) by default internally which can cause the CPU backend to return incorrect results or nans with fp16 exp.
This fix seems enough to prevent incorrect results when the CPU backend is compiled with icpx, which allows us to re-enable this op in the SYCL backend.

Changed files:
filename: ggml/src/ggml-cpu/CMakeLists.txt
patch: @@ -589,4 +589,9 @@ function(ggml_add_cpu_backend_variant_impl tag_name)
     if (EMSCRIPTEN)
         set_target_properties(${GGML_CPU_NAME} PROPERTIES COMPILE_FLAGS "-msimd128")
     endif()
+
+    if (CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
+        # The compiler automatically enables "-ffast-math" which can cause NaNs in tests due to "-fassociative-math"
+        target_compile_options(${GGML_CPU_NAME} PRIVATE "-fno-associative-math")
+    endif()
 endfunction()

filename: ggml/src/ggml-sycl/ggml-sycl.cpp
patch: @@ -4215,6 +4215,7 @@ static bool ggml_backend_sycl_device_supports_op(ggml_backend_dev_t dev, const g
                 case GGML_UNARY_OP_GELU_QUICK:
                 case GGML_UNARY_OP_GELU_ERF:
                 case GGML_UNARY_OP_TANH:
+                case GGML_UNARY_OP_EXP:
                 case GGML_UNARY_OP_SGN:
                 case GGML_UNARY_OP_ABS:
                 case GGML_UNARY_OP_ELU:
@@ -4223,9 +4224,6 @@ static bool ggml_backend_sycl_device_supports_op(ggml_backend_dev_t dev, const g
 #else
                     return ggml_is_contiguous(op->src[0]) && (op->src[0]->type == GGML_TYPE_F32 && op->type == GGML_TYPE_F32) && (op->type == op->src[0]->type);
 #endif
-                case GGML_UNARY_OP_EXP:
-                     // Disable FP16 until we find out the root cause of failing fp16 sycl::exp
-                    return ggml_is_contiguous(op->src[0]) && (op->type == op->src[0]->type) && op->src[0]->type == GGML_TYPE_F32;
                 default:
                     return false;
             }
Repository: denoland/deno
Pull request: fix(fmt): --ext flag requires to pass files

To avoid situations like described in https://github.com/denoland/deno/issues/26402
using `deno fmt` with `--ext` flag now requires to explicitly specify list of files (or
globs) to format.

Closes https://github.com/denoland/deno/issues/26402

Changed files:
filename: cli/args/flags.rs
patch: @@ -2274,7 +2274,7 @@ Ignore formatting a file by adding an ignore comment at the top of the file:
             "sass", "less", "html", "svelte", "vue", "astro", "yml", "yaml",
             "ipynb",
           ])
-          .help_heading(FMT_HEADING),
+          .help_heading(FMT_HEADING).requires("files"),
       )
       .arg(
         Arg::new("ignore")
@@ -6802,6 +6802,32 @@ mod tests {
         ..Flags::default()
       }
     );
+
+    let r = flags_from_vec(svec!["deno", "fmt", "--ext", "html"]);
+    assert!(r.is_err());
+    let r = flags_from_vec(svec!["deno", "fmt", "--ext", "html", "./**"]);
+    assert_eq!(
+      r.unwrap(),
+      Flags {
+        subcommand: DenoSubcommand::Fmt(FmtFlags {
+          check: false,
+          files: FileFlags {
+            include: vec!["./**".to_string()],
+            ignore: vec![],
+          },
+          use_tabs: None,
+          line_width: None,
+          indent_width: None,
+          single_quote: None,
+          prose_wrap: None,
+          no_semicolons: None,
+          unstable_component: false,
+          watch: Default::default(),
+        }),
+        ext: Some("html".to_string()),
+        ..Flags::default()
+      }
+    );
   }
 
   #[test]
Repository: ggml-org/llama.cpp
Pull request: test-backend-ops : disable llama test


Changed files:
filename: tests/test-backend-ops.cpp
patch: @@ -4860,9 +4860,9 @@ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval() {
 
     test_cases.emplace_back(new test_opt_step_adamw(GGML_TYPE_F32, {10, 5, 4, 3}));
 
-    test_cases.emplace_back(new test_llama(2, true));
-    // these tests are disabled to save execution time, but they can be handy for debugging
 #if 0
+    // these tests are disabled to save execution time, sbut they can be handy for debugging
+    test_cases.emplace_back(new test_llama(2, true));
     test_cases.emplace_back(new test_llama(1));
     test_cases.emplace_back(new test_llama(2));
     test_cases.emplace_back(new test_falcon(1));
Repository: facebook/react
Pull request: [react-float] feature detect getRootNode

Some old environments like IE11 or very old versions of jsdom are missing `getRootNode()`. Use feature detection to fall back to `ownerDocuments` in these environments that also won't be supporting shadow DOM anyway.

Changed files:
filename: packages/react-dom-bindings/src/client/ReactDOMFloatClient.js
patch: @@ -167,9 +167,7 @@ let lastCurrentDocument: ?Document = null;
 
 let previousDispatcher = null;
 export function prepareToRenderResources(rootContainer: Container) {
-  // Flot thinks that getRootNode returns a Node but it actually returns a
-  // Document or ShadowRoot
-  const rootNode: FloatRoot = (rootContainer.getRootNode(): any);
+  const rootNode = getRootNode(rootContainer);
   lastCurrentDocument = getDocumentFromRoot(rootNode);
 
   previousDispatcher = Dispatcher.current;
@@ -191,10 +189,20 @@ export type FloatRoot = Document | ShadowRoot;
 // global maps of Resources
 const preloadResources: Map<string, PreloadResource> = new Map();
 
+// getRootNode is missing from IE and old jsdom versions
+function getRootNode(container: Container): FloatRoot {
+  // $FlowFixMe[method-unbinding]
+  return typeof container.getRootNode === 'function'
+    ? /* $FlowFixMe[incompatible-return] Flow types this as returning a `Node`,
+       * but it's either a `Document` or `ShadowRoot`. */
+      container.getRootNode()
+    : container.ownerDocument;
+}
+
 function getCurrentResourceRoot(): null | FloatRoot {
   const currentContainer = getCurrentRootHostContainer();
   // $FlowFixMe flow should know currentContainer is a Node and has getRootNode
-  return currentContainer ? currentContainer.getRootNode() : null;
+  return currentContainer ? getRootNode(currentContainer) : null;
 }
 
 // This resource type constraint can be loosened. It really is everything except PreloadResource
@@ -204,7 +212,7 @@ function resetInstance(resource: ScriptResource | HeadResource) {
 }
 
 export function clearRootResources(rootContainer: Container): void {
-  const rootNode: FloatRoot = (rootContainer.getRootNode(): any);
+  const rootNode = getRootNode(rootContainer);
   const resources = getResourcesFromRoot(rootNode);
 
   // We can't actually delete the resource cache because this function is called