helloadhavan/github_issues huggingface dataset:
Repository: ggml-org/llama.cpp
Pull request: cuda: fix build warnings in set-rows.cu (unused variable)

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

```bash
/ws/ggml/src/ggml-cuda/set-rows.cu:6:42: warning: unused parameter 'src_f' [-Wunused-parameter]
__device__ void set_rows_1(const src_t * src_f, dst_t * dst_f) {}
                                         ^
/ws/ggml/src/ggml-cuda/set-rows.cu:6:57: warning: unused parameter 'dst_f' [-Wunused-parameter]
__device__ void set_rows_1(const src_t * src_f, dst_t * dst_f) {}
                                                        ^
/ws/ggml/src/ggml-cuda/set-rows.cu:27:23: warning: unused parameter 'ne10' [-Wunused-parameter]
        const int64_t ne10, const int64_t ne11, const int64_t ne12, const int64_t ne13,
                      ^
/ws/ggml/src/ggml-cuda/set-rows.cu:27:83: warning: unused parameter 'ne13' [-Wunused-parameter]
        const int64_t ne10, const int64_t ne11, const int64_t ne12, const int64_t ne13,
                                                                                  ^
```

Changed files:
filename: ggml/src/ggml-cuda/set-rows.cu
patch: @@ -3,7 +3,10 @@
 typedef void (*set_rows_kernel_t)(const char * src, char * dst);
 
 template<typename src_t, typename dst_t>
-__device__ void set_rows_1(const src_t * src_f, dst_t * dst_f) {}
+__device__ void set_rows_1(const src_t * src_f, dst_t * dst_f) {
+    GGML_UNUSED(src_f);
+    GGML_UNUSED(dst_f);
+}
 
 template<>
 __device__ __forceinline__ void set_rows_1<float, half>(const float * src_f, half * dst_h) {
@@ -53,6 +56,9 @@ static __global__ void k_set_rows(
     const src_t* src_elem = src0_row + i00;
     dst_t* dst_elem = dst_row_ptr + i00;
     set_rows_1(src_elem, dst_elem);
+
+    GGML_UNUSED(ne10);
+    GGML_UNUSED(ne13);
 }
 
 template<typename src_t, typename dst_t>
Repository: huggingface/transformers
Pull request: Fix `utils/notification_service.py`

# What does this PR do?

Currently, `Model CI` still include `quantization` in its matrix. And when there is any failure in it, the key in the new failure json report contains the key like `bnb` not `quantization`. 

However, the `job_link` contains the key `quantization` (as it is in `Model CI` job not `Quantization` job, so the whole `quantization` is a single job)


See https://github.com/huggingface/transformers/actions/runs/15407385951/job/43361291899

I think we can remove `quantization` from `Model CI` job, WDYT?

But in the long-term, we still need (a better) way to avoid such failures. This PR still implement a quick fix.

Changed files:
filename: utils/notification_service.py
patch: @@ -615,7 +615,10 @@ def payload(self) -> str:
                         pattern = r"<(https://github.com/huggingface/transformers/actions/runs/.+?/job/.+?)\|(.+?)>"
                         items = re.findall(pattern, line)
                     elif "tests/" in line:
-                        if "tests/models/" in line or "tests/quantization/" in line:
+                        # TODO: Improve the condition here.
+                        if "tests/models/" in line or (
+                            "tests/quantization/" in line and job_name == "run_quantization_torch_gpu"
+                        ):
                             model = line.split("/")[2]
                         else:
                             model = line.split("/")[1]
Repository: facebook/react
Pull request: [DiffTrain] Add REVISION and REVISION_TRANSFORM to output

We use these for the sync script, so to preserve option value let's continue adding these files so the script can still be used for arbitrary commits.

Changed files:
filename: .github/workflows/commit_artifacts.yml
patch: @@ -129,6 +129,10 @@ jobs:
             ./compiled/babel-plugin-react-refresh/index.js
 
           ls -R ./compiled
+      - name: Add REVISION files
+        run: |
+          echo ${{ github.sha }} >> ./compiled/facebook-www/REVISION
+          cp ./compiled/facebook-www/REVISION ./compiled/facebook-www/REVISION_TRANSFORMS
       - uses: actions/upload-artifact@v3
         with:
           name: compiled
Repository: ggml-org/llama.cpp
Pull request: sycl: Hotfix for non dnnl codepath

PR #14617  introduced new logic for dnnl codepath for batched mulmats to improve broadcast logic and support strided data. Due to this the use of `get_to_fp16_nc_sycl` which has overhead compared to `get_to_fp16_sycl`.

The non DNNL codepath however still does not support non continuous `src1` without the `nc_sycl` function which caused failures when not running DNNL.

This PR ensures correct behaviour.

Changed files:
filename: ggml/src/ggml-sycl/ggml-sycl.cpp
patch: @@ -2875,12 +2875,20 @@ static void ggml_sycl_mul_mat_batched_sycl(ggml_backend_sycl_context & ctx, cons
             }
 
         }
+#if GGML_SYCL_DNNL
+        // oneDNN handles strided data and does not need overhead of get_to_fp16_nc_sycl
         const int64_t ne_src1 = src1->nb[last_str] * src1->ne[last_dim] / type_size_src1;
         src1_f16_alloc.alloc(ne_src1);
-
         const to_fp16_sycl_t to_fp16_sycl = ggml_get_to_fp16_sycl(src1->type, dst);
         GGML_ASSERT(to_fp16_sycl != nullptr);
         to_fp16_sycl(src1_f16, src1_f16_alloc.get(), ne_src1, queue);
+# else
+        const int64_t ne_src1 = ggml_nelements(src1);
+        src1_f16_alloc.alloc(ne_src1);
+        const to_fp16_nc_sycl_t to_fp16_nc_sycl = get_to_fp16_nc_sycl(src1->type);
+        GGML_ASSERT(to_fp16_nc_sycl != nullptr);
+        to_fp16_nc_sycl(src1_f16, src1_f16_alloc.get(), ne10, ne11, ne12, ne13, s11, s12, s13, queue);
+#endif
 
         src1_f16 = src1_f16_alloc.get();
         s11      = ne10;
Repository: facebook/react
Pull request: [DiffTrain] Strip @license from files

We need to remove this for some internal tests. This was previously in our upgrade script so adding it back here for parity.

Test plan: files were updated correctly [[1]](https://github.com/facebook/react/commit/1704bbb8268345bf7aa405101313b3639e03e221#diff-80b968e05ce2ceeff6e17c938dc722aff2c1c660f8ef402e6664bc5b2cafa5fbL2) [[2]](https://github.com/facebook/react/commit/1704bbb8268345bf7aa405101313b3639e03e221#diff-6ecd07a61c8e0e28793dace3f9f62751e4808de9c2965aa1ddeb0157f3c9b4ecL2)

Changed files:
filename: .github/workflows/commit_artifacts.yml
patch: @@ -99,6 +99,11 @@ jobs:
             } else {
               process.exitCode = 1;
             }
+      - name: Strip @license from eslint plugin and react-refresh
+        run: |
+          sed -i -e 's/ @license React*//' \
+            build/oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
+            build/oss-stable/react-refresh/cjs/react-refresh-babel.development.js
       - name: Move relevant files into compiled
         run: |
           mkdir -p ./compiled
Repository: nodejs/node
Pull request: #57169 fix/streamResetBurst-and-streamResetRate-options-are-missing-in-the-documentation-of-http2.CreateSecureServer


<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->

Title: Documentation Update: Include streamResetBurst and streamResetRate Options in http2.CreateSecureServer

Description:

This PR addresses the issue where the streamResetBurst and streamResetRate options were missing in the documentation for http2.CreateSecureServer.

Changes:

Added documentation for the streamResetBurst and streamResetRate options in the http2.CreateSecureServer section.


If you need any adjustments or further additions, feel free to let me know!



Changed files:
filename: doc/api/http2.md
patch: @@ -3055,6 +3055,9 @@ changes:
     **Default:** `100`.
   * `settings` {HTTP/2 Settings Object} The initial settings to send to the
     remote peer upon connection.
+  * `streamResetBurst` {number} and `streamResetRate` {number} Sets the rate
+    limit for the incoming stream reset (RST\_STREAM frame). Both settings must
+    be set to have any effect, and default to 1000 and 33 respectively.
   * `remoteCustomSettings` {Array} The array of integer values determines the
     settings types, which are included in the `customSettings`-property of the
     received remoteSettings. Please see the `customSettings`-property of the
Repository: denoland/deno
Pull request: perf(windows): delay load webgpu and some other dlls

Before: ~100ms, After: ~40ms for a hello world

Closes https://github.com/denoland/deno/issues/26914

Changed files:
filename: cli/build.rs
patch: @@ -400,6 +400,24 @@ fn main() {
   println!("cargo:rustc-env=TARGET={}", env::var("TARGET").unwrap());
   println!("cargo:rustc-env=PROFILE={}", env::var("PROFILE").unwrap());
 
+  if cfg!(windows) {
+    // these dls load slowly, so delay loading them
+    let dlls = [
+      // webgpu
+      "d3dcompiler_47",
+      "OPENGL32",
+      // network related functions
+      "iphlpapi",
+    ];
+    for dll in dlls {
+      println!("cargo:rustc-link-arg-bin=deno=/delayload:{dll}.dll");
+      println!("cargo:rustc-link-arg-bin=denort=/delayload:{dll}.dll");
+    }
+    // enable delay loading
+    println!("cargo:rustc-link-arg-bin=deno=delayimp.lib");
+    println!("cargo:rustc-link-arg-bin=denort=delayimp.lib");
+  }
+
   let c = PathBuf::from(env::var_os("CARGO_MANIFEST_DIR").unwrap());
   let o = PathBuf::from(env::var_os("OUT_DIR").unwrap());
Repository: denoland/deno
Pull request: fix(ext/node): increase tolerance for interval test

Fixes tests added in https://github.com/denoland/deno/pull/26703 by increasing
tolerance due to noisy CI machines.

Changed files:
filename: tests/unit_node/timers_test.ts
patch: @@ -118,7 +118,7 @@ Deno.test({
       expectedValue: 42,
       intervalMs: 100,
       iterations: 3,
-      tolerancePercent: 10,
+      tolerancePercent: 50,
     };
 
     const { setInterval } = timersPromises;
Repository: vercel/next.js
Pull request: Extend bot list with googleweblight, Storebot-Google, Google-Inspecti…

### What

Simplify the default html limited bots regex to `/google/i` to match various types of google bots UA listed in https://developers.google.com/search/docs/crawling-indexing/google-common-crawlers


Resolves #75032 



Changed files:
filename: packages/next/src/shared/lib/router/utils/is-bot.ts
patch: @@ -1,8 +1,9 @@
 import { HTML_LIMITED_BOT_UA_RE } from './html-bots'
 
-// Bot crawler that will spin up a headless browser and execute JS
-const HEADLESS_BROWSER_BOT_UA_RE =
-  /Googlebot|Google-PageRenderer|AdsBot-Google|googleweblight|Storebot-Google/i
+// Bot crawler that will spin up a headless browser and execute JS.
+// By default, only googlebots are considered as DOM bots. Blow is where the regex is computed from:
+// x-ref: https://developers.google.com/search/docs/crawling-indexing/google-common-crawlers
+const HEADLESS_BROWSER_BOT_UA_RE = /google/i
 
 export const HTML_LIMITED_BOT_UA_RE_STRING = HTML_LIMITED_BOT_UA_RE.source
Repository: nodejs/node
Pull request: src: fix ThrowInvalidURL call in PathToFileURL

Fixes #57133.

Replaces `nullptr` with `std::nullopt` when calling `ThrowInvalidURL` in `PathToFileURL`. This ensures the function receives the correct argument type and aligns with the expected behavior.

PS: I'm not sure how to test this, any help would be appreciated.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/node_url.cc
patch: @@ -161,7 +161,7 @@ void BindingData::PathToFileURL(const FunctionCallbackInfo<Value>& args) {
       ada::parse<ada::url_aggregator>(EncodePathChars(input_str, os), nullptr);
 
   if (!out) {
-    return ThrowInvalidURL(realm->env(), input.ToStringView(), nullptr);
+    return ThrowInvalidURL(realm->env(), input.ToStringView(), std::nullopt);
   }
 
   if (os == OS::WINDOWS && args.Length() > 2 && !args[2]->IsUndefined())
Repository: vercel/next.js
Pull request: [dev-tools] better description for restart server button

Better reflect why this button is needed.

x-ref: [slack thread](https://vercel.slack.com/archives/C04A1276AGK/p1748977699699439?thread_ts=1748886481.971709&cid=C04A1276AGK)

Changed files:
filename: packages/next/src/client/components/react-dev-overlay/ui/components/errors/dev-tools-indicator/dev-tools-info/user-preferences.tsx
patch: @@ -186,12 +186,14 @@ export function UserPreferences({
           <div className="preference-header">
             <label id="restart-dev-server">Restart Dev Server</label>
             <p className="preference-description">
-              Restart the dev server to rebuild your application.
+              Restarts the development server without needing to leave the
+              browser.
             </p>
           </div>
           <div className="preference-control">
             <button
               aria-describedby="restart-dev-server"
+              title="Restarts the development server without needing to leave the browser."
               name="restart-dev-server"
               data-restart-dev-server
               className="action-button"
@@ -208,13 +210,14 @@ export function UserPreferences({
             <div className="preference-header">
               <label id="reset-bundler-cache">Reset Bundler Cache</label>
               <p className="preference-description">
-                Reset the bundler cache to rebuild your application without
-                cache.
+                Clears the bundler cache and restarts the dev server. Helpful if
+                you are seeing stale errors or changes are not appearing.
               </p>
             </div>
             <div className="preference-control">
               <button
                 aria-describedby="reset-bundler-cache"
+                title="Clears the bundler cache and restarts the dev server. Helpful if you are seeing stale errors or changes are not appearing."
                 name="reset-bundler-cache"
                 data-reset-bundler-cache
                 className="action-button"

filename: packages/next/src/client/components/react-dev-overlay/ui/components/errors/error-overlay-toolbar/restart-server-button.tsx
patch: @@ -48,7 +48,15 @@ export function RestartServerButton({ error }: { error: Error }) {
   }
 
   return (
-    <button className="restart-dev-server-button" onClick={handleClick}>
+    <button
+      className="restart-dev-server-button"
+      onClick={handleClick}
+      title={
+        process.env.__NEXT_TURBOPACK_PERSISTENT_CACHE
+          ? 'Clears the bundler cache and restarts the dev server. Helpful if you are seeing stale errors or changes are not appearing.'
+          : 'Restarts the development server without needing to leave the browser.'
+      }
+    >
       <RefreshClockWise width={14} height={14} />
       Restart Dev Server
     </button>
Repository: huggingface/transformers
Pull request: [TP] Change command in tests to `python3`

Simple fix, should fix failing tests (atleast partially)
https://github.com/huggingface/transformers/actions/runs/15407385951/job/43352806705



Changed files:
filename: tests/tensor_parallel/test_tensor_parallel.py
patch: @@ -77,7 +77,7 @@ def torchrun(self, script: str, is_torchrun: bool = True):
                     f"torchrun --nproc_per_node {self.nproc_per_node} --master_port {get_torch_dist_unique_port()} {tmp.name}"
                 ).split()
             else:
-                cmd = ["python", tmp.name]
+                cmd = ["python3", tmp.name]
 
             # Note that the subprocess will be waited for here, and raise an error if not successful
             try:
Repository: ggml-org/llama.cpp
Pull request: llama-context: add ability to get logits

From #14644 

Changed files:
filename: src/llama-context.cpp
patch: @@ -731,7 +731,8 @@ int llama_context::encode(const llama_batch & batch_inp) {
 
     const auto & hparams = model.hparams;
 
-    const int64_t n_embd = hparams.n_embd;
+    const int64_t n_embd  = hparams.n_embd;
+    const int32_t n_vocab = model.vocab.n_tokens();
 
     // note: during encode, we always pass the full sequence starting from pos = 0
     if (!balloc->init(batch_inp, model.vocab, nullptr, n_embd, true)) {
@@ -791,10 +792,20 @@ int llama_context::encode(const llama_batch & batch_inp) {
         }
     }
 
+    auto * t_logits = res->get_logits();
     auto * t_embd = res->get_embd_pooled() ? res->get_embd_pooled() : res->get_embd();
 
+    // extract logits
+   if (logits && t_logits) {
+        ggml_backend_t backend_res = ggml_backend_sched_get_tensor_backend(sched.get(), t_logits);
+        GGML_ASSERT(backend_res != nullptr);
+        GGML_ASSERT(logits != nullptr);
+
+        ggml_backend_tensor_get_async(backend_res, t_logits, logits, 0, n_tokens*n_vocab*sizeof(float));
+    }
+
     // extract embeddings
-    if (t_embd) {
+    if (embd && t_embd) {
         ggml_backend_t backend_embd = ggml_backend_sched_get_tensor_backend(sched.get(), t_embd);
         GGML_ASSERT(backend_embd != nullptr);
Repository: huggingface/transformers
Pull request: Align TP check

# What does this PR do?

We need to have the following check `is_torch_greater_or_equal("2.5") and _torch_distributed_available` when checking that the tp_plan is correctly designed, otherwise `ALL_PARALLEL_STYLES` might be empty (e.g for torch 2.4) and it will raise an error when loading a model like llama that has a `_tp_plan`

Saw in accelerate CI https://github.com/huggingface/accelerate/actions/runs/15199790246/job/42795709533?pr=3581

Might need a patch for that but let's see if this impacts a lot of users 

FIxed partly here https://github.com/huggingface/transformers/pull/38370


Changed files:
filename: src/transformers/modeling_utils.py
patch: @@ -2084,7 +2084,7 @@ def post_init(self):
             if plan := getattr(module, "_tp_plan", None):
                 self._tp_plan.update({f"{name}.{k}": v for k, v in plan.copy().items()})
 
-        if self._tp_plan is not None and is_torch_greater_or_equal("2.5"):
+        if self._tp_plan is not None and is_torch_greater_or_equal("2.5") and _torch_distributed_available:
             for _, v in self._tp_plan.items():
                 if v not in ALL_PARALLEL_STYLES:
                     raise ValueError(
Repository: electron/electron
Pull request: perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter

Backport of #44501

See that PR for details.


Notes: none.

Changed files:
filename: shell/common/gin_converters/std_converter.h
patch: @@ -70,12 +70,10 @@ struct Converter<char[]> {
   }
 };
 
-template <size_t n>
-struct Converter<char[n]> {
-  static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {
-    return v8::String::NewFromUtf8(isolate, val, v8::NewStringType::kNormal,
-                                   n - 1)
-        .ToLocalChecked();
+template <size_t N>
+struct Converter<char[N]> {
+  static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char (&val)[N]) {
+    return v8::String::NewFromUtf8Literal(isolate, val);
   }
 };
Repository: facebook/react
Pull request: Fork ReactDOMSharedInternals for www

This isn't the right way to do this, but internally we have some restrictions so we need to add an indirection. Let's land this now so we can catch up our sync and then fix forward from there.

Changed files:
filename: packages/shared/forks/ReactDOMSharedInternals.www.js
patch: @@ -0,0 +1,16 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow
+ */
+
+// $FlowIgnore[cannot-resolve-module] provided by www
+const ReactDOM = require('ReactDOMComet');
+
+const ReactDOMSharedInternals =
+  ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
+
+export default ReactDOMSharedInternals;

filename: scripts/rollup/forks.js
patch: @@ -70,6 +70,14 @@ const forks = Object.freeze({
     if (entry === 'react-dom' || entry === 'react-dom/server-rendering-stub') {
       return './packages/react-dom/src/ReactDOMSharedInternals.js';
     }
+    switch (bundleType) {
+      case FB_WWW_DEV:
+      case FB_WWW_PROD:
+      case FB_WWW_PROFILING:
+        return './packages/shared/forks/ReactDOMSharedInternals.www.js';
+      default:
+        break;
+    }
     if (
       !entry.startsWith('react-dom/') &&
       dependencies.indexOf('react-dom') === -1