Repository: vercel/next.js
Pull request: feat: using eval source map plugin for Rspack

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

Use rspack.EvalSourceMapDevToolPlugin when running with Rspack

The modification specifically pass the test case in:
test/integration/server-side-dev-errors/test/index.test.js


Changed files:
filename: packages/next/src/build/webpack/config/blocks/base.ts
patch: @@ -4,6 +4,7 @@ import { COMPILER_NAMES } from '../../../../shared/lib/constants'
 import type { ConfigurationContext } from '../utils'
 import DevToolsIgnorePlugin from '../../plugins/devtools-ignore-list-plugin'
 import EvalSourceMapDevToolPlugin from '../../plugins/eval-source-map-dev-tool-plugin'
+import { getRspackCore } from '../../../../shared/lib/get-rspack'
 
 function shouldIgnorePath(modulePath: string): boolean {
   return (
@@ -65,15 +66,23 @@ export const base = curry(function base(
         shouldIgnorePath,
       })
     )
-  } else if (config.devtool === 'eval-source-map' && !process.env.NEXT_RSPACK) {
+  } else if (config.devtool === 'eval-source-map') {
     // We're using a fork of `eval-source-map`
     config.devtool = false
-    config.plugins.push(
-      new EvalSourceMapDevToolPlugin({
-        moduleFilenameTemplate: config.output?.devtoolModuleFilenameTemplate,
-        shouldIgnorePath,
-      })
-    )
+    if (process.env.NEXT_RSPACK) {
+      config.plugins.push(
+        new (getRspackCore().EvalSourceMapDevToolPlugin)({
+          moduleFilenameTemplate: config.output?.devtoolModuleFilenameTemplate,
+        })
+      )
+    } else {
+      config.plugins.push(
+        new EvalSourceMapDevToolPlugin({
+          moduleFilenameTemplate: config.output?.devtoolModuleFilenameTemplate,
+          shouldIgnorePath,
+        })
+      )
+    }
   }
 
   // TODO: add codemod for "Should not import the named export" with JSON files

filename: test/integration/server-side-dev-errors/test/index.test.js
patch: @@ -12,8 +12,6 @@ import {
 } from 'next-test-utils'
 import stripAnsi from 'strip-ansi'
 
-const isRspack = process.env.NEXT_RSPACK !== undefined
-
 const appDir = join(__dirname, '../')
 const gspPage = join(appDir, 'pages/gsp.js')
 const gsspPage = join(appDir, 'pages/gssp.js')
@@ -369,7 +367,7 @@ describe('server-side dev errors', () => {
       )
       .trim()
     // FIXME(veil): error repeated
-    if (isTurbopack || isRspack) {
+    if (isTurbopack) {
       expect(stderrOutput).toMatchInlineSnapshot(`
         "Error: catch this rejection
             at Timeout._onTimeout (../../test/integration/server-side-dev-errors/pages/uncaught-rejection.js:7:19)
@@ -448,7 +446,7 @@ describe('server-side dev errors', () => {
       )
       .trim()
     // FIXME(veil): error repeated
-    if (isTurbopack || isRspack) {
+    if (isTurbopack) {
       expect(stderrOutput).toMatchInlineSnapshot(`
        "Error: 
            at Timeout._onTimeout (../../test/integration/server-side-dev-errors/pages/uncaught-empty-rejection.js:7:19)
@@ -526,7 +524,7 @@ describe('server-side dev errors', () => {
       )
       .trim()
     // FIXME(veil): error repeated
-    if (isTurbopack || isRspack) {
+    if (isTurbopack) {
       expect(stderrOutput).toMatchInlineSnapshot(`
         "Error: catch this exception
             at Timeout._onTimeout (../../test/integration/server-side-dev-errors/pages/uncaught-exception.js:7:10)
@@ -604,7 +602,7 @@ describe('server-side dev errors', () => {
       )
       .trim()
     // FIXME(veil): error repeated
-    if (isTurbopack || isRspack) {
+    if (isTurbopack) {
       expect(stderrOutput).toMatchInlineSnapshot(`
        "Error: 
            at Timeout._onTimeout (../../test/integration/server-side-dev-errors/pages/uncaught-empty-exception.js:7:10)