helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: build: fix patchup logic only running on one platform

#### Description of Change

Don't run patchup if we don't have patchup creds -  Also run it on Linux as it's a bit faster.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none

Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -75,7 +75,7 @@ runs:
         "$GITHUB_SERVER_URL/$GITHUB_REPOSITORY"
 
       ELECTRON_USE_THREE_WAY_MERGE_FOR_PATCHES=1 gclient sync --with_branch_heads --with_tags -vvvvv
-      if [ "${{ inputs.is-release }}" != "true" ]; then
+      if [ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]; then
         # Re-export all the patches to check if there were changes.
         python3 src/electron/script/export_all_patches.py src/electron/patches/config.json
         cd src/electron

filename: .github/workflows/build.yml
patch: @@ -90,7 +90,6 @@ jobs:
         - /var/run/sas:/var/run/sas
     env:
       GCLIENT_EXTRA_ARGS: '--custom-var=checkout_mac=True --custom-var=host_os=mac'
-      PATCH_UP_APP_CREDS: ${{ secrets.PATCH_UP_APP_CREDS }}
     outputs:
       build-image-sha: ${{ needs.setup.outputs.build-image-sha }}
     steps:
@@ -116,6 +115,7 @@ jobs:
         - /var/run/sas:/var/run/sas
     env:
       GCLIENT_EXTRA_ARGS: '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True'
+      PATCH_UP_APP_CREDS: ${{ secrets.PATCH_UP_APP_CREDS }}
     outputs:
       build-image-sha: ${{ needs.setup.outputs.build-image-sha}}
     steps:
Repository: vercel/next.js
Pull request: [ts-next-plugin] clean up unused proxy

Cleaned up a leftover unused proxy following up on https://github.com/vercel/next.js/pull/78237.

Besides being unused, there was an issue reported from a large repository. The repository was a monorepo, and the apps' modules were shared with each other. The user received an error:

```
[trace] <semantic> Response received: definitionAndBoundSpan (951). Request took 0 ms. Success: false .
Message: Error processing request. Cannot read properties of undefined (reading 'updateFromProject')
TypeError: Cannot read properties of undefined (reading 'updateFromProject')
    at synchronizeHostData (...)
    at Object.getProgram (...)
    at getSource (...)
    at getEntryInfo (...)
    at proxy.getDefinitionAndBoundSpan
```

The issue begins when `getDefinitionAndBoundSpan` is triggered—typically via `Cmd + Click` or even hovering(!) to view definitions, imports, or module references. In our case, since the repository contains multiple apps, each enabling the plugin, navigating across apps using `Cmd + Click` caused `getDefinitionAndBoundSpan` to fire across multiple plugin instances.

The root cause is that when `getDefinitionAndBoundSpan` is triggered, it calls `synchronizeHostData()` and checks whether it is to update the project by checking the `host.updateFromProject` exists. However, the Language Service Host is somehow `undefined` (assuming memory is overloaded due to initiating multiple plugins), so we received the error above.

x-ref: https://github.com/microsoft/TypeScript/blob/11e79327598db412a161616849041487673fadab/src/services/services.ts#L1692-L1693

If we clean up this `getDefinitionAndBoundSpan` proxy, the error above will be gone, but `synchronizeHostData` is called pretty much every time on language service requests, including `getSemanticDiagnostics` we are still proxying — a potential issue we can't control that could happen for complicated repositories like the above.

x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1744231020199229)

Changed files:
filename: packages/next/src/server/typescript/index.ts
patch: @@ -343,15 +343,6 @@ export const createTSPlugin: tsModule.server.PluginModuleFactory = ({
       return prior
     }
 
-    // Get definition and link for specific node
-    proxy.getDefinitionAndBoundSpan = (fileName: string, position: number) => {
-      const entryInfo = getEntryInfo(fileName)
-      if (isAppEntryFile(fileName) && !entryInfo.client) {
-      }
-
-      return info.languageService.getDefinitionAndBoundSpan(fileName, position)
-    }
-
     return proxy
   }
Repository: ggml-org/llama.cpp
Pull request: Use tagged version of llguidance that does not break the build

This is a very simple PR to bump the version of llguidance to the commit that implemented that added [fancy-regex](https://github.com/guidance-ai/llguidance/pull/172) because the build with `-DLLAMA_LLGUIDANCE=ON` breaks without it.

This fixes #13412 

Changed files:
filename: common/CMakeLists.txt
patch: @@ -119,8 +119,8 @@ if (LLAMA_LLGUIDANCE)
 
     ExternalProject_Add(llguidance_ext
         GIT_REPOSITORY https://github.com/guidance-ai/llguidance
-        # v0.7.10:
-        GIT_TAG 0309d2a6bf40abda35344a362edc71e06d5009f8
+        # v0.7.19 (+ fancy-regex build fix):
+        GIT_TAG b59f98f85269892a7de3d3641ad155366f13daa6
         PREFIX ${CMAKE_BINARY_DIR}/llguidance
         SOURCE_DIR ${LLGUIDANCE_SRC}
         BUILD_IN_SOURCE TRUE
Repository: nodejs/node
Pull request: doc: fix 'which' to 'that' and added comma

Replaced 'which' with 'that' and added comma for clarity.

Changed files:
filename: doc/contributing/technical-priorities.md
patch: @@ -21,11 +21,11 @@ on October 1st 2022.
 
 _Present in: 2021_
 
-Base HTTP support is a key component of modern cloud-native applications
+Base HTTP support is a key component of modern cloud-native applications,
 and built-in support was part of what made Node.js a success in the first
 10 years. The current implementation is hard to support and a common
 source of vulnerabilities. We must work towards an
-implementation which is easier to support and makes it easier to integrate
+implementation that is easier to support and makes it easier to integrate
 the new HTTP versions (HTTP3, QUIC) and to support efficient
 implementations of different versions concurrently.
 
@@ -96,7 +96,7 @@ supported tools to implement those processes (logging, metrics and tracing).
 This includes support within the Node.js runtime itself (for example
 generating heap dumps, performance metrics, etc.) as well as support for
 applications on top of the runtime. In addition, it is also important to
-clearly document the use cases, problem determination methods and best
+clearly document the use cases, problem determination methods, and best
 practices for those tools.
 
 ## Better multithreaded support
Repository: electron/electron
Pull request: build: fix patchup logic only running on one platform

Backport of #43139

See that PR for details.


Notes: none

Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -75,7 +75,7 @@ runs:
         "$GITHUB_SERVER_URL/$GITHUB_REPOSITORY"
 
       ELECTRON_USE_THREE_WAY_MERGE_FOR_PATCHES=1 gclient sync --with_branch_heads --with_tags -vvvvv
-      if [ "${{ inputs.is-release }}" != "true" ]; then
+      if [ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]; then
         # Re-export all the patches to check if there were changes.
         python3 src/electron/script/export_all_patches.py src/electron/patches/config.json
         cd src/electron

filename: .github/workflows/build.yml
patch: @@ -115,6 +115,7 @@ jobs:
         - /var/run/sas:/var/run/sas
     env:
       GCLIENT_EXTRA_ARGS: '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True'
+      PATCH_UP_APP_CREDS: ${{ secrets.PATCH_UP_APP_CREDS }}
     outputs:
       build-image-sha: ${{ needs.setup.outputs.build-image-sha}}
     steps:
Repository: nodejs/node
Pull request: doc: fix typo

CI is failling

/cc @ruyadorno

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/changelogs/CHANGELOG_V22.md
patch: @@ -80,11 +80,11 @@ When a `Buffer` is created using a resizable `ArrayBuffer`, the `Buffer` length
 ```js
 const ab = new ArrayBuffer(10, { maxByteLength: 20 });
 const buffer = Buffer.from(ab);
-console.log(buffer.byteLength); 10
+console.log(buffer.byteLength); // 10
 ab.resize(15);
-console.log(buffer.byteLength); 15
+console.log(buffer.byteLength); // 15
 ab.resize(5);
-console.log(buffer.byteLength); 5
+console.log(buffer.byteLength); // 5
 ```
 
 Contributed by James Snell in [#55377](https://github.com/nodejs/node/pull/55377)
Repository: huggingface/transformers
Pull request: Flag SpeechT5 flaky test

# What does this PR do?

Flags a test as flaky - it's been blocking a few PRs. Not sure what is causing it to fail, cc @eustlb here maybe

Changed files:
filename: tests/models/speecht5/test_modeling_speecht5.py
patch: @@ -20,6 +20,7 @@
 
 from transformers import SpeechT5Config, SpeechT5HifiGanConfig
 from transformers.testing_utils import (
+    is_flaky,
     is_torch_available,
     require_deterministic_for_xpu,
     require_sentencepiece,
@@ -722,6 +723,10 @@ def test_training_gradient_checkpointing_use_reentrant(self):
     def test_training_gradient_checkpointing_use_reentrant_false(self):
         pass
 
+    @is_flaky(max_attempts=5, description="Flaky for some input configurations.")
+    def test_past_key_values_format(self):
+        super().test_past_key_values_format()
+
     # overwrite from test_modeling_common
     def _mock_init_weights(self, module):
         if hasattr(module, "weight") and module.weight is not None:
Repository: ggml-org/llama.cpp
Pull request: CUDA: fix FlashAttention on Turing

Fixes https://github.com/ggml-org/llama.cpp/pull/13306#issuecomment-2867857459 .

The problem is that the V data is not being loaded correctly for `nstages == 0` (no asynchronous data loading available) and I forgot to test this configuration prior to merging. Sorry!

Changed files:
filename: ggml/src/ggml-cuda/fattn-mma-f16.cuh
patch: @@ -546,7 +546,7 @@ static __device__ __forceinline__ void flash_attn_ext_f16_iter(
         const int i0_stop = i0_start + 2*c::nbatch_V2 < DV ? i0_start + 2*c::nbatch_V2 : DV;
         const int i0_diff = i0_stop - i0_start;
 
-        if (nstages == 1) {
+        if (nstages <= 1) {
             constexpr bool use_cp_async = nstages == 1;
             flash_attn_ext_f16_load_tile<stride_tile_V, nwarps, c::nbatch_fa, use_cp_async>
                 (V_h2 + k_VKQ_0*stride_V + i0_start/2, tile_V, i0_diff/2, stride_V);
Repository: vercel/next.js
Pull request: Removed unnecessary React Fragment

<!--
Thanks for opening a PR! Your contribution is much appreciated.
In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->
## Update
[-] Removed React fragment from index


Changed files:
filename: examples/cms-wordpress/pages/index.js
patch: @@ -12,27 +12,25 @@ export default function Index({ allPosts: { edges }, preview }) {
   const morePosts = edges.slice(1)
 
   return (
-    <>
-      <Layout preview={preview}>
-        <Head>
-          <title>Next.js Blog Example with {CMS_NAME}</title>
-        </Head>
-        <Container>
-          <Intro />
-          {heroPost && (
-            <HeroPost
-              title={heroPost.title}
-              coverImage={heroPost.featuredImage}
-              date={heroPost.date}
-              author={heroPost.author}
-              slug={heroPost.slug}
-              excerpt={heroPost.excerpt}
-            />
-          )}
-          {morePosts.length > 0 && <MoreStories posts={morePosts} />}
-        </Container>
-      </Layout>
-    </>
+    <Layout preview={preview}>
+      <Head>
+        <title>Next.js Blog Example with {CMS_NAME}</title>
+      </Head>
+      <Container>
+        <Intro />
+        {heroPost && (
+          <HeroPost
+            title={heroPost.title}
+            coverImage={heroPost.featuredImage}
+            date={heroPost.date}
+            author={heroPost.author}
+            slug={heroPost.slug}
+            excerpt={heroPost.excerpt}
+          />
+        )}
+        {morePosts.length > 0 && <MoreStories posts={morePosts} />}
+      </Container>
+    </Layout>
   )
 }
Repository: huggingface/transformers
Pull request: Fix some GPU OOM after #37553

# What does this PR do?

Can't say anything why #37553 gives some tests GPU OOM and the only way I can make those tests to pass is to do some cuda cleanup at some places.

Changed files:
filename: tests/models/llama/test_modeling_llama.py
patch: @@ -699,6 +699,7 @@ def tearDown(self):
         cleanup(torch_device, gc_collect=True)
 
     def setUp(self):
+        cleanup(torch_device, gc_collect=True)
         model_name = "TinyLlama/TinyLlama-1.1B-Chat-v1.0"
         self.model_dtype = torch.float32
         self.tokenizer = LlamaTokenizer.from_pretrained(model_name)
Repository: denoland/deno
Pull request: fix(runtime/windows): fix calculation of console size

Fixes #23872.

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->


Changed files:
filename: runtime/ops/tty.rs
patch: @@ -351,10 +351,20 @@ fn console_size_from_fd(
     {
       return Err(Error::last_os_error());
     }
-    Ok(ConsoleSize {
-      cols: bufinfo.dwSize.X as u32,
-      rows: bufinfo.dwSize.Y as u32,
-    })
+
+    // calculate the size of the visible window
+    // * use over/under-flow protections b/c MSDN docs only imply that srWindow components are all non-negative
+    // * ref: <https://docs.microsoft.com/en-us/windows/console/console-screen-buffer-info-str> @@ <https://archive.is/sfjnm>
+    let cols = std::cmp::max(
+      bufinfo.srWindow.Right as i32 - bufinfo.srWindow.Left as i32 + 1,
+      0,
+    ) as u32;
+    let rows = std::cmp::max(
+      bufinfo.srWindow.Bottom as i32 - bufinfo.srWindow.Top as i32 + 1,
+      0,
+    ) as u32;
+
+    Ok(ConsoleSize { cols, rows })
   }
 }
Repository: facebook/react
Pull request: Remove flushControlled from experimental releases

This brings the exports on npm to parity which simplifies things a bit.

We also don't plan to ever release this. It is used by Draft.js but that caller will need to switch to flushSync.


Changed files:
filename: packages/react-dom/index.experimental.js
patch: @@ -18,7 +18,6 @@ export {
   render,
   unmountComponentAtNode,
   unstable_batchedUpdates,
-  unstable_flushControlled,
   unstable_renderSubtreeIntoContainer,
   unstable_runWithPriority, // DO NOT USE: Temporarily exposed to migrate off of Scheduler.runWithPriority.
   version,

filename: packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.js
patch: @@ -286,7 +286,7 @@ describe('ReactDOMFiberAsync', () => {
       expect(ops).toEqual(['BC', 'ABCD']);
     });
 
-    // @gate experimental || www
+    // @gate www
     it('flushControlled flushes updates before yielding to browser', () => {
       let inst;
       class Counter extends React.Component {
@@ -326,7 +326,7 @@ describe('ReactDOMFiberAsync', () => {
       ]);
     });
 
-    // @gate experimental || www
+    // @gate www
     it('flushControlled does not flush until end of outermost batchedUpdates', () => {
       let inst;
       class Counter extends React.Component {
@@ -357,7 +357,7 @@ describe('ReactDOMFiberAsync', () => {
       ]);
     });
 
-    // @gate experimental || www
+    // @gate www
     it('flushControlled returns nothing', () => {
       // In the future, we may want to return a thenable "work" object.
       let inst;
Repository: electron/electron
Pull request: fix: ensure bounds stability in `OnWidgetBoundsChanged`

Backport of #43431

See that PR for details.


Notes: Fixed an issue with `resize` events being emitted on Windows when the window was moved but not resized.

Changed files:
filename: shell/browser/native_window_views.cc
patch: @@ -22,6 +22,7 @@
 
 #include "base/containers/contains.h"
 #include "base/memory/raw_ptr.h"
+#include "base/numerics/ranges.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/browser/browser_thread.h"
@@ -1644,10 +1645,18 @@ void NativeWindowViews::OnWidgetBoundsChanged(views::Widget* changed_widget,
   if (changed_widget != widget())
     return;
 
-  // Note: We intentionally use `GetBounds()` instead of `bounds` to properly
-  // handle minimized windows on Windows.
+  // |GetWindowBoundsInScreen| has a ~1 pixel margin of error, so if we check
+  // existing bounds directly against the new bounds without accounting for that
+  // we'll have constant false positives when the window is moving but the user
+  // hasn't changed its size at all.
+  auto areWithinOnePixel = [](gfx::Size old_size, gfx::Size new_size) -> bool {
+    return base::IsApproximatelyEqual(old_size.width(), new_size.width(), 1) &&
+           base::IsApproximatelyEqual(old_size.height(), new_size.height(), 1);
+  };
+
+  // We use |GetBounds| to account for minimized windows on Windows.
   const auto new_bounds = GetBounds();
-  if (widget_size_ != new_bounds.size()) {
+  if (!areWithinOnePixel(widget_size_, new_bounds.size())) {
     NotifyWindowResize();
     widget_size_ = new_bounds.size();
   }
Repository: vercel/next.js
Pull request: Turbopack: prevent hanging due to content hashing

If you enable content hashing, you need to use `CurrentChunkMethod::DocumentCurrentScript`, otherwise there's an infinite loop of `getting the current chunk's name for including it in the content <--> building the content of the chunk`

This was already being done here for next-client: https://github.com/vercel/next.js/blob/fb0abb44bf21ca98848d0b9c7ff45a291cc05e46/crates/next-core/src/next_client/context.rs#L465

Closes PACK-4446

Changed files:
filename: turbopack/crates/turbopack-cli/src/build/mod.rs
patch: @@ -21,7 +21,7 @@ use turbopack::{
     css::chunk::CssChunkType, ecmascript::chunk::EcmascriptChunkType,
     global_module_ids::get_global_module_id_strategy,
 };
-use turbopack_browser::{BrowserChunkingContext, ContentHashing};
+use turbopack_browser::{BrowserChunkingContext, ContentHashing, CurrentChunkMethod};
 use turbopack_cli_utils::issue::{ConsoleUi, LogOptions};
 use turbopack_core::{
     asset::Asset,
@@ -335,6 +335,7 @@ async fn build_internal(
             )
             .source_maps(source_maps_type)
             .module_id_strategy(module_id_strategy)
+            .current_chunk_method(CurrentChunkMethod::DocumentCurrentScript)
             .minify_type(minify_type);
 
             match *node_env.await? {
Repository: huggingface/transformers
Pull request: Fix Quark quantization config

# What does this PR do?

Raises an `ImportException` in the quantization config if quark is not installed, since it's needed there

Changed files:
filename: src/transformers/utils/quantization_config.py
patch: @@ -1821,7 +1821,10 @@ def __init__(
             from quark.torch.export.config.config import JsonExporterConfig
             from quark.torch.export.main_export.quant_config_parser import QuantConfigParser
             from quark.torch.quantization.config.config import Config
-
+        else:
+            raise ImportError(
+                "Quark is not installed. Please refer to https://quark.docs.amd.com/latest/install.html."
+            )
         # This might be e.g. `"fp8"` or `"awq"`.
         self.custom_mode = kwargs["quant_method"]
         self.legacy = "export" not in kwargs

filename: tests/quantization/quark_integration/test_quark.py
patch: @@ -33,6 +33,7 @@
     from quark.torch.export.nn.modules.qparamslinear import QParamsLinear
 
 
+@require_quark
 class QuarkConfigTest(unittest.TestCase):
     def test_commmon_args(self):
         config = AutoConfig.from_pretrained("amd/Llama-3.1-8B-Instruct-w-int8-a-int8-sym-test")
Repository: denoland/deno
Pull request: fix(ext/node): don't concat set-cookie in ServerResponse.appendHeader

Fixes #24987

Follow-on to https://github.com/denoland/deno/pull/24216/files#r1642188672


Changed files:
filename: ext/node/polyfills/http.ts
patch: @@ -1439,12 +1439,11 @@ export class ServerResponse extends NodeWritable {
   }
 
   appendHeader(name: string, value: string | string[]) {
-    if (Array.isArray(value)) {
-      this.#hasNonStringHeaders = true;
-    }
     if (this.#headers[name] === undefined) {
+      if (Array.isArray(value)) this.#hasNonStringHeaders = true;
       this.#headers[name] = value;
     } else {
+      this.#hasNonStringHeaders = true;
       if (!Array.isArray(this.#headers[name])) {
         this.#headers[name] = [this.#headers[name]];
       }

filename: tests/unit_node/http_test.ts
patch: @@ -1118,6 +1118,27 @@ Deno.test("[node/http] ServerResponse appendHeader", async () => {
   await promise;
 });
 
+Deno.test("[node/http] ServerResponse appendHeader set-cookie", async () => {
+  const { promise, resolve } = Promise.withResolvers<void>();
+  const server = http.createServer((_req, res) => {
+    res.appendHeader("Set-Cookie", "a=b");
+    res.appendHeader("Set-Cookie", "c=d");
+    res.end("Hello World");
+  });
+
+  server.listen(async () => {
+    const { port } = server.address() as { port: number };
+    const res = await fetch(`http://localhost:${port}`);
+    assertEquals(res.headers.getSetCookie(), ["a=b", "c=d"]);
+    assertEquals(await res.text(), "Hello World");
+    server.close(() => {
+      resolve();
+    });
+  });
+
+  await promise;
+});
+
 Deno.test("[node/http] IncomingMessage override", () => {
   const req = new http.IncomingMessage(new net.Socket());
   // https://github.com/dougmoscrop/serverless-http/blob/3aaa6d0fe241109a8752efb011c242d249f32368/lib/request.js#L20-L30