helloadhavan/github_issues huggingface dataset:
Repository: denoland/deno
Pull request: fix(lsp): use CliLockfile

The build broke in https://github.com/denoland/deno/pull/24365.

Changed files:
filename: cli/lsp/resolver.rs
patch: @@ -3,6 +3,7 @@
 use crate::args::create_default_npmrc;
 use crate::args::package_json;
 use crate::args::CacheSetting;
+use crate::args::CliLockfile;
 use crate::graph_util::CliJsrUrlProvider;
 use crate::http_util::HttpClientProvider;
 use crate::lsp::config::Config;
@@ -26,12 +27,10 @@ use dashmap::DashMap;
 use deno_ast::MediaType;
 use deno_cache_dir::HttpCache;
 use deno_core::error::AnyError;
-use deno_core::parking_lot::Mutex;
 use deno_core::url::Url;
 use deno_graph::source::Resolver;
 use deno_graph::GraphImport;
 use deno_graph::ModuleSpecifier;
-use deno_lockfile::Lockfile;
 use deno_npm::NpmSystemInfo;
 use deno_runtime::deno_fs;
 use deno_runtime::deno_node::NodeResolution;
@@ -110,7 +109,7 @@ impl LspScopeResolver {
     )));
     let redirect_resolver = Some(Arc::new(RedirectResolver::new(
       cache.for_specifier(config_data.map(|d| &d.scope)),
-      config_data.and_then(|d| d.lockfile.as_deref()),
+      config_data.and_then(|d| d.lockfile.clone()),
     )));
     let npm_graph_resolver = graph_resolver.create_graph_npm_resolver();
     let graph_imports = config_data
@@ -552,7 +551,7 @@ impl std::fmt::Debug for RedirectResolver {
 impl RedirectResolver {
   fn new(
     cache: Arc<dyn HttpCache>,
-    lockfile: Option<&Mutex<Lockfile>>,
+    lockfile: Option<Arc<CliLockfile>>,
   ) -> Self {
     let entries = DashMap::new();
     if let Some(lockfile) = lockfile {
Repository: facebook/react
Pull request: Remove duplicate error code

The codemod seem to have found this error message twice.

There's kind of a flaw in the extract-errors script in that it uses map from message to ID which doesn't allow multiple IDs with the same name. That could happen if we end up changing names of something in the future.

Currently this means that running `extract-errors` will delete a row.

We should never delete a code that has been used. Even an unreleased one can show up in FB error logs even in the future.

However, since this is so recent, this shouldn't have leaked much yet so maybe it's fine to just delete this duplicate.

Changed files:
filename: scripts/error-codes/codes.json
patch: @@ -396,7 +396,6 @@
   "407": "Missing getServerSnapshot, which is required for server-rendered content. Will revert to client rendering.",
   "408": "Missing getServerSnapshot, which is required for server-rendered content.",
   "409": "Cannot update an unmounted root.",
-  "410": "%s suspended while rendering, but no fallback UI was specified.\n\nAdd a <Suspense fallback=...> component higher in the tree to provide a loading indicator or placeholder to display.",
   "411": "%s suspended while rendering, but no fallback UI was specified.\n\nAdd a <Suspense fallback=...> component higher in the tree to provide a loading indicator or placeholder to display.",
   "412": "Connection closed.",
   "413": "Expected finished root and lanes to be set. This is a bug in React.",
Repository: electron/electron
Pull request: build: update NMV to 130 for Electron 33

In preparation for releasing Electron 32, we are reserving a new Node Module Version in advance for Electron 33.

Node.js PR: ✅ https://github.com/nodejs/node/pull/54383 (Merged)

Notes: none

Changed files:
filename: build/args/all.gn
patch: @@ -2,7 +2,7 @@ is_electron_build = true
 root_extra_deps = [ "//electron" ]
 
 # Registry of NMVs --> https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json
-node_module_version = 128
+node_module_version = 130
 
 v8_promise_internal_field_count = 1
 v8_embedder_string = "-electron.0"
Repository: nodejs/node
Pull request: tools: use tokenless Codecov uploads

Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token

I already enabled it in the Codecov settings for the `nodejs` org.


Changed files:
filename: .github/workflows/coverage-linux-without-intl.yml
patch: @@ -79,7 +79,6 @@ jobs:
       - name: Clean tmp
         run: rm -rf coverage/tmp && rm -rf out
       - name: Upload
-        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238  # v4.6.0
+        uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a  # v5.0.7
         with:
           directory: ./coverage
-          token: ${{ secrets.CODECOV_TOKEN }}

filename: .github/workflows/coverage-linux.yml
patch: @@ -79,7 +79,6 @@ jobs:
       - name: Clean tmp
         run: rm -rf coverage/tmp && rm -rf out
       - name: Upload
-        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238  # v4.6.0
+        uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a  # v5.0.7
         with:
           directory: ./coverage
-          token: ${{ secrets.CODECOV_TOKEN }}

filename: .github/workflows/coverage-windows.yml
patch: @@ -71,7 +71,6 @@ jobs:
       - name: Clean tmp
         run: npx rimraf ./coverage/tmp
       - name: Upload
-        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238  # v4.6.0
+        uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a  # v5.0.7
         with:
           directory: ./coverage
-          token: ${{ secrets.CODECOV_TOKEN }}
Repository: ggml-org/llama.cpp
Pull request: ggml: disable CUDA graphs for unsupported DUP and CONT node types

Fixes #12798



Changed files:
filename: ggml/src/ggml-cuda/ggml-cuda.cu
patch: @@ -2488,10 +2488,10 @@ static bool check_node_graph_compatibility_and_refresh_copy_ops(ggml_backend_cud
 #endif
         }
 
-        if (node->op == GGML_OP_MUL_MAT_ID) {
+        if (node->op == GGML_OP_MUL_MAT_ID || node->op == GGML_OP_CONT || node->op == GGML_OP_DUP) {
             use_cuda_graph = false; // This node type is not supported by CUDA graph capture
 #ifndef NDEBUG
-            GGML_LOG_DEBUG("%s: disabling CUDA graphs due to mul_mat_id\n", __func__);
+            GGML_LOG_DEBUG("%s: disabling CUDA graphs due to unsupported node type\n", __func__);
 #endif
         }
Repository: nodejs/node
Pull request: doc: add vetted courses to the ambassador benefits

Fixes https://github.com/nodejs/nodejs.org/issues/7201

Changed files:
filename: doc/contributing/advocacy-ambasador-program.md
patch: @@ -18,6 +18,10 @@ The ambassador program does that by:
   messages and topics defined.
 * Advocating for ambassadors to be part of the OpenJS speakers bureau, even if the
   ambassador is not otherwise an active member of the project itself.
+* Each ambassador could add a maximum of three links to resources to learn Node.js
+  on a dedicated page on the main Node.js website. At least one of those must be a
+  free resource. The Node.js TSC members could ask for coupon codes to verify the
+  material if they so decide.
 
 ## Ambassadors nominations
Repository: electron/electron
Pull request: build: fix build when `enable_pdf_viewer` and `enable_electron_extensions` disabled

#### Description of Change

As in title. Compilation was failing when 

```
enable_pdf_viewer=false
enable_electron_extensions=false
```

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none

Changed files:
filename: shell/browser/api/electron_api_session.cc
patch: @@ -48,6 +48,7 @@
 #include "net/base/completion_repeating_callback.h"
 #include "net/base/load_flags.h"
 #include "net/base/network_anonymization_key.h"
+#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_auth_preferences.h"
 #include "net/http/http_cache.h"

filename: shell/browser/electron_browser_context.cc
patch: @@ -377,8 +377,10 @@ ElectronBrowserContext::~ElectronBrowserContext() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   NotifyWillBeDestroyed();
 
+#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)
   // the DestroyBrowserContextServices() call below frees this.
   extension_system_ = nullptr;
+#endif
 
   // Notify any keyed services of browser context destruction.
   BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices(
Repository: vercel/next.js
Pull request: Turbopack warning spelling fix

sourcecode -> source code
sourcemap -> source map


Closes PACK-4316

Changed files:
filename: packages/next/src/build/index.ts
patch: @@ -3758,7 +3758,7 @@ function warnAboutTurbopackBuilds(config?: NextConfigComplete) {
   warningStr +=
     '\n\n- ' +
     bold(
-      'Turbopack currently always builds production sourcemaps for the browser. This will include project sourcecode if deployed to production.'
+      'Turbopack currently always builds production source maps for the browser. This will include project source code if deployed to production.'
     )
   warningStr +=
     '\n- It is expected that your bundle size might be different from `next build` with webpack. This will be improved as we work towards stability.'
Repository: denoland/deno
Pull request: perf: improve Buffer.from(buf) by 29x

Improve `Buffer.from(buffer)` performance by ~29x

```
$ deno run -A bench.mjs
7987.390458 ms

$ node bench.mjs
773.420042 ms

$ bun bench.mjs
737.7943750 ms

$ target/release/deno run -A bench.mjs
275.3805 ms
```

```js
import { Buffer } from "node:buffer";

const buffer = Buffer.alloc(1024 * 10, "latin1");

const start = performance.now();
for (let i = 0; i < 1000000; i++) {
  Buffer.from(buffer);
}
console.log(performance.now() - start);
```

Ref #24323 

Changed files:
filename: ext/node/polyfills/internal/buffer.mjs
patch: @@ -229,11 +229,22 @@ function fromArrayLike(array) {
   return buf;
 }
 
+function fromUint8Array(u8) {
+  const buf = new Uint8Array(u8.buffer, u8.byteOffset, u8.byteLength);
+  Object.setPrototypeOf(buf, Buffer.prototype);
+  return buf.slice();
+}
+
 function fromObject(obj) {
   if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
     if (typeof obj.length !== "number") {
       return createBuffer(0);
     }
+
+    if (obj instanceof Uint8Array) {
+      return fromUint8Array(obj);
+    }
+
     return fromArrayLike(obj);
   }
Repository: huggingface/transformers
Pull request: Fix `utils/check_bad_commit.py`

# What does this PR do?

See the comment in the change.

Changed files:
filename: utils/check_bad_commit.py
patch: @@ -47,6 +47,9 @@ def create_script(target_test):
 
 if len(result.stderr) > 0:
     if "ERROR: file or directory not found: " in result.stderr:
+        print("test file or directory not found in this commit")
+        exit(0)
+    elif "ERROR: not found: " in result.stderr:
         print("test not found in this commit")
         exit(0)
     else:
Repository: nodejs/node
Pull request: doc: fix Node.js 23 column in CHANGELOG.md

The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering.

---

* Before
![image](https://github.com/user-attachments/assets/ba337565-7b5d-4efe-8127-0a31b400c48f)

* After
![image](https://github.com/user-attachments/assets/3ebd177d-65fc-4b9c-aca3-02fd1a289e76)

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: CHANGELOG.md
patch: @@ -38,6 +38,7 @@ release.
   <th title="LTS Until 2025-04"><a href="doc/changelogs/CHANGELOG_V18.md">18</a> (LTS)</th>
 </tr>
 <tr>
+  <td valign="top">
 <b><a href="doc/changelogs/CHANGELOG_V23.md#23.3.0">23.3.0</a></b><br/>
 <a href="doc/changelogs/CHANGELOG_V23.md#23.2.0">23.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V23.md#23.1.0">23.1.0</a><br/>
Repository: ggml-org/llama.cpp
Pull request: Define cache directory on AIX

Hi @ngxson. This PR addresses your comment in #12892

Changed files:
filename: common/common.cpp
patch: @@ -830,7 +830,7 @@ std::string fs_get_cache_directory() {
     if (getenv("LLAMA_CACHE")) {
         cache_directory = std::getenv("LLAMA_CACHE");
     } else {
-#if defined(__linux__) || defined(__FreeBSD__)
+#if defined(__linux__) || defined(__FreeBSD__) || defined(_AIX)
         if (std::getenv("XDG_CACHE_HOME")) {
             cache_directory = std::getenv("XDG_CACHE_HOME");
         } else {

filename: examples/rpc/rpc-server.cpp
patch: @@ -126,7 +126,7 @@ static std::string fs_get_cache_directory() {
     if (getenv("LLAMA_CACHE")) {
         cache_directory = std::getenv("LLAMA_CACHE");
     } else {
-#if defined(__linux__) || defined(__FreeBSD__)
+#if defined(__linux__) || defined(__FreeBSD__) || defined(_AIX)
         if (std::getenv("XDG_CACHE_HOME")) {
             cache_directory = std::getenv("XDG_CACHE_HOME");
         } else {
Repository: vercel/next.js
Pull request: Turbopack: fix dynamic request lookup with only a single match

Previously, if `require("./dynamic-files/"+name)` had only a single match, it would always return that one, regardless of whether `name` was equal to the matches' filename or not.

Closes https://github.com/vercel/next.js/issues/74664
Closes PACK-4309

Changed files:
filename: turbopack/crates/turbopack-ecmascript/src/references/pattern_mapping.rs
patch: @@ -410,7 +410,7 @@ impl PatternMapping {
                 request_to_string(request).await?.to_string(),
             ))
             .cell()),
-            1 => {
+            1 if !request.request_pattern().await?.has_dynamic_parts() => {
                 let resolve_item = &result.primary.first().unwrap().1;
                 let single_pattern_mapping =
                     to_single_pattern_mapping(origin, chunking_context, resolve_item, resolve_type)

filename: turbopack/crates/turbopack-tests/tests/execution/turbopack/dynamic-requests/basic/input/index.js
patch: @@ -11,6 +11,8 @@ const importAddSuffix = (key) => import("./dir/" + key + ".js");
 const importConcat = (key) => import("./dir/".concat(key));
 const importConcatSuffix = (key) => import("./dir/".concat(key, ".js"));
 
+const requireSingleSuffix = (key) => require(`./dir/${key}.ts`);
+
 it("should support dynamic requests in require with template literals", () => {
   expect(requireTemplate("a.js")).toBe(a);
   expect(requireTemplate("b.ts")).toBe(b);
@@ -103,3 +105,8 @@ it("should not support dynamic requests with double extension", async () => {
   await expect(importConcatSuffix("a.js")).rejects.toThrowError();
   await expect(importConcatSuffix("d.js")).rejects.toThrowError();
 });
+
+it("should still interpolate even with a single match", async () => {
+  expect(requireSingleSuffix("b")).toBe(b)
+  expect(() => requireSingleSuffix("non-existent")).toThrowError()
+});
Repository: ggml-org/llama.cpp
Pull request: Define cache directory on FreeBSD

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*


Changed files:
filename: common/common.cpp
patch: @@ -830,7 +830,7 @@ std::string fs_get_cache_directory() {
     if (getenv("LLAMA_CACHE")) {
         cache_directory = std::getenv("LLAMA_CACHE");
     } else {
-#ifdef __linux__
+#if defined(__linux__) || defined(__FreeBSD__)
         if (std::getenv("XDG_CACHE_HOME")) {
             cache_directory = std::getenv("XDG_CACHE_HOME");
         } else {
@@ -840,7 +840,9 @@ std::string fs_get_cache_directory() {
         cache_directory = std::getenv("HOME") + std::string("/Library/Caches/");
 #elif defined(_WIN32)
         cache_directory = std::getenv("LOCALAPPDATA");
-#endif // __linux__
+#else
+#  error Unknown architecture
+#endif
         cache_directory = ensure_trailing_slash(cache_directory);
         cache_directory += "llama.cpp";
     }
Repository: huggingface/transformers
Pull request: update error msg

change error msg #36291 

Changed files:
filename: src/transformers/convert_slow_tokenizer.py
patch: @@ -1730,7 +1730,7 @@ def convert_slow_tokenizer(transformer_tokenizer, from_tiktoken=False) -> Tokeni
             ).converted()
         except Exception:
             raise ValueError(
-                f"Converting from Tiktoken failed, if a converter for SentencePiece is available, provide a model path "
+                f"Converting from SentencePiece and Tiktoken failed, if a converter for SentencePiece is available, provide a model path "
                 f"with a SentencePiece tokenizer.model file."
                 f"Currently available slow->fast converters: {list(SLOW_TO_FAST_CONVERTERS.keys())}"
             )
Repository: vercel/next.js
Pull request: Update Turbopack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-build-tests-manifest.json
patch: @@ -1438,6 +1438,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/back-forward-cache/back-forward-cache.test.ts": {
+    "passed": [
+      "back/forward cache Activity component is renderable when the routerBFCache flag is on"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/binary/rsc-binary.test.ts": {
     "passed": [
       "RSC binary serialization should correctly encode/decode binaries and hydrate"
@@ -4499,6 +4508,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/rewrite-with-search-params/rewrite-with-search-params.test.ts": {
+    "passed": [
+      "rewrite-with-search-params should not contain params in search params after rewrite"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/rewrites-redirects/rewrites-redirects.test.ts": {
     "passed": [
       "redirects and rewrites navigation using button should redirect from middleware correctly",
@@ -4643,6 +4661,16 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/rsc-query-routing/rsc-query-routing.test.ts": {
+    "passed": [
+      "rsc-query-routing should contain rsc query in rsc request when redirect the page",
+      "rsc-query-routing should contain rsc query in rsc request when rewrite the page"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/rsc-webpack-loader/rsc-webpack-loader.test.ts": {
     "passed": [],
     "failed": [],
@@ -8122,6 +8150,16 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/turbopack-turbo-config-compatibility/index.test.ts": {
+    "passed": [
+      "turbopack-turbo-config-compatibility including both turbopack and deprecated experimental turbo config prefers turbopack config over deprecated experimental turbo config",
+      "turbopack-turbo-config-compatibility only including deprecated experimental turbo config still uses the deprecated experimental turbo config"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/type-module-interop/index.test.ts": {
     "passed": [
       "Type module interop should render client-side",
@@ -14971,7 +15009,7 @@
     "flakey": [],
     "runtimeError": false
   },
-  "test/integration/module-id-strategies/test/index.test.js": {
+  "test/integration/module-ids/test/index.test.js": {
     "passed": [
       "minified module ids production mode should have no long module id for the next client runtime module",
       "minified module ids production mode should have no long module ids for async loader modules",
Repository: denoland/deno
Pull request: fix(ext/node): make next tick queue resilient to `Array.prototype` tampering

Closes #24358.


Changed files:
filename: ext/node/polyfills/internal/fixed_queue.ts
patch: @@ -1,8 +1,8 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 // Copyright Joyent, Inc. and other Node contributors.
 
-// TODO(petamoriken): enable prefer-primordials for node polyfills
-// deno-lint-ignore-file prefer-primordials
+import { primordials } from "ext:core/mod.js";
+const { ArrayFrom } = primordials;
 
 // Currently optimal queue size, tested on V8 6.0 - 6.6. Must be power of two.
 const kSize = 2048;
@@ -65,7 +65,7 @@ class FixedCircularBuffer {
   constructor() {
     this.bottom = 0;
     this.top = 0;
-    this.list = new Array(kSize);
+    this.list = ArrayFrom({ __proto__: null, length: kSize });
     this.next = null;
   }
 
@@ -111,11 +111,13 @@ export class FixedQueue {
       // and sets it as the new main queue.
       this.head = this.head.next = new FixedCircularBuffer();
     }
+    // deno-lint-ignore prefer-primordials -- `push` is a method of `FixedCircularBuffer`
     this.head.push(data);
   }
 
   shift() {
     const tail = this.tail;
+    // deno-lint-ignore prefer-primordials -- `shift` is a method of `FixedCircularBuffer`
     const next = tail.shift();
     if (tail.isEmpty() && tail.next !== null) {
       // If there is another queue, it forms the new tail.