helloadhavan/github_issues huggingface dataset:
Repository: huggingface/transformers
Pull request: Relaxed the output_attention condition for ValueError

In the `GenerationConfig` object, the `output_attentions` attribute is not meant to evaluate to true when `attn_implementation` is not eager, eg. it is SDPA. 
An issue arises we have a `GenerationConfig` object `gen_cfg_0` with `attn_implementation == "sdpa"` and want to update some of its keys with another `gen_cfg_1` object. Since `GenerationConfig` sets `self.output_attentions = False` by default, when when doing the update, `gen_cfg_0` thinks we are trying to update `output_attention` to `True` even though we are updating it from `False` to `False`, which is totally ok. 
To avoid this, we added a very restrictive check (`value is False` which more restrictive than just checking if value evaluates to false) to always allow update of `output_attentions` with the default value `False`. 

cc. @mht-sharma 

Changed files:
filename: src/transformers/configuration_utils.py
patch: @@ -340,7 +340,8 @@ def output_attentions(self):
 
     @output_attentions.setter
     def output_attentions(self, value):
-        if self._attn_implementation != "eager":
+        # We always allow updates with the default value, which is False
+        if (self._attn_implementation != "eager") and (value is not False):
             raise ValueError(
                 "The `output_attentions` attribute is not supported when using the `attn_implementation` set to "
                 f"{self._attn_implementation}. Please set it to 'eager' instead."
Repository: electron/electron
Pull request: build: add new status to verify if all the required gha jobs have run

Backport of #44432

See that PR for details.


Notes: none

Changed files:
filename: .github/workflows/build.yml
patch: @@ -249,4 +249,14 @@ jobs:
       gn-build-type: testing
       generate-symbols: false
       upload-to-storage: '0'
-    secrets: inherit
\ No newline at end of file
+    secrets: inherit
+
+  gha-done:
+    name: GitHub Actions Completed
+    runs-on: ubuntu-latest
+    needs: [docs-only, macos-x64, macos-arm64, linux-x64, linux-x64-asan, linux-arm, linux-arm64]
+    if: always() && !contains(needs.*.result, 'failure')
+    steps: 
+    - name: GitHub Actions Jobs Done
+      run: |
+        echo "All GitHub Actions Jobs are done"
Repository: ggml-org/llama.cpp
Pull request: convert : make hf token optional

We don't need to require a HF token for `convert_hf_to_gguf_update.py` to work.

Gated repos will fail to download, but this only affects the end result when you are adding a new model, in which case we will throw an error later on.

Changed files:
filename: convert_hf_to_gguf_update.py
patch: @@ -7,7 +7,6 @@
 import re
 
 import requests
-import sys
 import json
 import shutil
 import argparse
@@ -69,8 +68,7 @@ class TOKENIZER_TYPE(IntEnum):
 hf_token = args.hf_token if args.hf_token is not None else hf_token
 
 if hf_token is None:
-    logger.error("HF token is required. Please provide it as an argument or set it in ~/.cache/huggingface/token")
-    sys.exit(1)
+    logger.warning("HF token not found. You can provide it as an argument or set it in ~/.cache/huggingface/token")
 
 # TODO: this string has to exercise as much pre-tokenizer functionality as possible
 #       will be updated with time - contributions welcome
@@ -151,7 +149,7 @@ class TOKENIZER_TYPE(IntEnum):
 
 
 def download_file_with_auth(url, token, save_path):
-    headers = {"Authorization": f"Bearer {token}"}
+    headers = {"Authorization": f"Bearer {token}"} if token else None
     response = sess.get(url, headers=headers)
     response.raise_for_status()
     os.makedirs(os.path.dirname(save_path), exist_ok=True)
@@ -250,20 +248,18 @@ def get_existing_models(convert_py):
     else:
         # otherwise, compute the hash of the tokenizer
 
-        # Skip if the tokenizer folder does not exist or there are other download issues previously
-        if not os.path.exists(f"models/tokenizers/{name}"):
-            logger.warning(f"Directory for tokenizer {name} not found. Skipping...")
-            continue
+        # Fail if the tokenizer folder with config does not exist or there are other download issues previously
+        if not os.path.isfile(f"models/tokenizers/{name}/tokenizer_config.json"):
+            raise OSError(f"Config for tokenizer {name} not found. The model may not exist or is not accessible with the provided token.")
 
         try:
             logger.info(f"Loading tokenizer from {f'models/tokenizers/{name}'}...")
             if name == "t5":
                 tokenizer = AutoTokenizer.from_pretrained(f"models/tokenizers/{name}", use_fast=False)
             else:
                 tokenizer = AutoTokenizer.from_pretrained(f"models/tokenizers/{name}")
-        except OSError as e:
-            logger.error(f"Error loading tokenizer for model {name}. The model may not exist or is not accessible with the provided token. Error: {e}")
-            continue  # Skip to the next model if the tokenizer can't be loaded
+        except Exception as e:
+            raise OSError(f"Error loading tokenizer for model {name}.") from e
 
         chktok = tokenizer.encode(CHK_TXT)
         chkhsh = sha256(str(chktok).encode()).hexdigest()
Repository: ggml-org/llama.cpp
Pull request: Fix parameter order issue for hybrid memory initialization

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

Fixes #14724 ; simply reordering the parameters resolves the issue.

Changed files:
filename: src/llama-memory-hybrid.cpp
patch: @@ -38,9 +38,9 @@ llama_memory_hybrid::llama_memory_hybrid(
         type_v,
         v_trans,
         offload,
+        1,
         kv_size,
         n_seq_max,
-        1,
         n_pad,
         n_swa,
         swa_type
Repository: nodejs/node
Pull request: src: improve error handling in tcp_wrap.cc

More error handling improvements.

In case folks are curious why I've been working on these across multiple PRs.. Consider this example:

```js
Object.defineProperty(Object.prototype, 'port1', {
  set() { throw new Error('boom'); }
});

new MessageChannel();
```

Before this PR: crashes the process
With this PR: throws the catchable error

Changed files:
filename: src/node_messaging.cc
patch: @@ -1627,10 +1627,15 @@ static void MessageChannel(const FunctionCallbackInfo<Value>& args) {
 
   MessagePort::Entangle(port1, port2);
 
-  args.This()->Set(context, env->port1_string(), port1->object())
-      .Check();
-  args.This()->Set(context, env->port2_string(), port2->object())
-      .Check();
+  if (args.This()
+          ->Set(context, env->port1_string(), port1->object())
+          .IsNothing() ||
+      args.This()
+          ->Set(context, env->port2_string(), port2->object())
+          .IsNothing()) {
+    port1->Close();
+    port2->Close();
+  }
 }
 
 static void BroadcastChannel(const FunctionCallbackInfo<Value>& args) {
Repository: electron/electron
Pull request: build: add new status to verify if all the required gha jobs have run

Backport of #44432

See that PR for details.


Notes: none


Changed files:
filename: .github/workflows/build.yml
patch: @@ -250,3 +250,13 @@ jobs:
       generate-symbols: false
       upload-to-storage: '0'
     secrets: inherit
+
+  gha-done:
+    name: GitHub Actions Completed
+    runs-on: ubuntu-latest
+    needs: [docs-only, macos-x64, macos-arm64, linux-x64, linux-x64-asan, linux-arm, linux-arm64]
+    if: always() && !contains(needs.*.result, 'failure')
+    steps: 
+    - name: GitHub Actions Jobs Done
+      run: |
+        echo "All GitHub Actions Jobs are done"
Repository: vercel/next.js
Pull request: [dev-tools] Re-focus previous item after closing sub menu

This PR fixes a small bug with the menu keyboard interactions. Namely, if you open a sub-menu and close it, visually the correct item is highlighted but does not respond when pressing Enter.


The bug is visible here on this video:

https://github.com/user-attachments/assets/368311eb-1400-4a76-b42b-b59676dedef2


After this PR you can infinitely toggle between the menus:


https://github.com/user-attachments/assets/9ff7f5cd-67cf-4db5-a12f-fd1bf8ebe96b






Changed files:
filename: packages/next/src/client/components/react-dev-overlay/ui/components/errors/dev-tools-indicator/dev-tools-indicator.tsx
patch: @@ -219,18 +219,21 @@ function DevToolsPopover({
     dispatch({ type: ACTION_ERROR_OVERLAY_TOGGLE })
   }
 
-  function openRootMenu() {
-    setOpen((prevOpen) => {
-      if (prevOpen === null) select('first')
-      return OVERLAYS.Root
-    })
+  function closeToRootMenu() {
+    setOpen(OVERLAYS.Root)
+    // We wait for the menu animation to complete
+    setTimeout(() => {
+      // This places focus again on the selected item
+      // so you can press Enter to trigger the selected item again
+      select(selectedIndex)
+    }, MENU_DURATION_MS)
   }
 
   function onTriggerClick() {
     if (open === OVERLAYS.Root) {
       setOpen(null)
     } else {
-      openRootMenu()
+      setOpen(OVERLAYS.Root)
       setTimeout(() => {
         select('first')
       })
@@ -301,7 +304,7 @@ function DevToolsPopover({
       {/* Route Info */}
       <RouteInfo
         isOpen={isRouteInfoOpen}
-        close={openRootMenu}
+        close={closeToRootMenu}
         triggerRef={triggerRef}
         style={popover}
         routerType={routerType}
@@ -311,15 +314,15 @@ function DevToolsPopover({
       {/* Turbopack Info */}
       <TurbopackInfo
         isOpen={isTurbopackInfoOpen}
-        close={openRootMenu}
+        close={closeToRootMenu}
         triggerRef={triggerRef}
         style={popover}
       />
 
       {/* Preferences */}
       <UserPreferences
         isOpen={isPreferencesOpen}
-        close={openRootMenu}
+        close={closeToRootMenu}
         triggerRef={triggerRef}
         style={popover}
         hide={handleHideDevtools}
@@ -333,7 +336,7 @@ function DevToolsPopover({
       {process.env.__NEXT_DEVTOOL_SEGMENT_EXPLORER ? (
         <SegmentsExplorer
           isOpen={isSegmentExplorerOpen}
-          close={openRootMenu}
+          close={closeToRootMenu}
           triggerRef={triggerRef}
           style={popover}
         />
Repository: ggml-org/llama.cpp
Pull request: ggml : add asserts

Little QoL improvement for noticing FP range problems.

Changed files:
filename: ggml/src/ggml-cpu/ops.cpp
patch: @@ -4015,6 +4015,9 @@ static void ggml_compute_forward_rms_norm_f32(
 
                 const float scale = 1.0f/sqrtf(mean + eps);
 
+                // if you hit this, likely you got an inf somewhere earlier
+                assert(scale > 0.0f);
+
                 ggml_vec_scale_f32(ne00, y, scale);
             }
         }

filename: ggml/src/ggml-cpu/vec.cpp
patch: @@ -221,6 +221,9 @@ void ggml_vec_dot_f16(int n, float * GGML_RESTRICT s, size_t bs, ggml_fp16_t * G
     for (int i = np; i < n; ++i) {
         sumf += (ggml_float)(GGML_CPU_FP16_TO_FP32(x[i])*GGML_CPU_FP16_TO_FP32(y[i]));
     }
+
+    // if you hit this, you are likely running outside the FP range
+    assert(!isnan(sumf) && !isinf(sumf));
 #else
     for (int i = 0; i < n; ++i) {
         sumf += (ggml_float)(GGML_CPU_FP16_TO_FP32(x[i])*GGML_CPU_FP16_TO_FP32(y[i]));
Repository: nodejs/node
Pull request: doc: add missing assert return types

This commit documents the return types for `assert.rejects()` and `assert.doesNotReject()`.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/assert.md
patch: @@ -1097,6 +1097,7 @@ added: v10.0.0
 * `asyncFn` {Function|Promise}
 * `error` {RegExp|Function}
 * `message` {string}
+* Returns: {Promise}
 
 Awaits the `asyncFn` promise or, if `asyncFn` is a function, immediately
 calls the function and awaits the returned promise to complete. It will then
@@ -2041,6 +2042,7 @@ added: v10.0.0
 * `asyncFn` {Function|Promise}
 * `error` {RegExp|Function|Object|Error}
 * `message` {string}
+* Returns: {Promise}
 
 Awaits the `asyncFn` promise or, if `asyncFn` is a function, immediately
 calls the function and awaits the returned promise to complete. It will then
Repository: denoland/deno
Pull request: fix(ext/webgpu): Create GPUQuerySet converter before usage 

Hi, while trying to do performance tests for TypeGPU we encountered a problem when using Timestamp Queries.

Converter for `GPUComputePassTimestampWrites` uses converter for `GPUQuerySet` before it is defined making it impossible to use. This PR simply reorders converter creation to resolve this issue. Logging the `GPUQuerySet` still fails (as mentioned in #26769) but it is now usable inside pass descriptors and works when used.


Changed files:
filename: ext/webgpu/01_webgpu.js
patch: @@ -6982,6 +6982,12 @@ webidl.converters.GPUComputePassEncoder = webidl.createInterfaceConverter(
   GPUComputePassEncoder.prototype,
 );
 
+// INTERFACE: GPUQuerySet
+webidl.converters.GPUQuerySet = webidl.createInterfaceConverter(
+  "GPUQuerySet",
+  GPUQuerySet.prototype,
+);
+
 // DICTIONARY: GPUComputePassTimestampWrites
 webidl.converters["GPUComputePassTimestampWrites"] = webidl
   .createDictionaryConverter(
@@ -7154,12 +7160,6 @@ webidl.converters["GPURenderPassDepthStencilAttachment"] = webidl
     dictMembersGPURenderPassDepthStencilAttachment,
   );
 
-// INTERFACE: GPUQuerySet
-webidl.converters.GPUQuerySet = webidl.createInterfaceConverter(
-  "GPUQuerySet",
-  GPUQuerySet.prototype,
-);
-
 // DICTIONARY: GPURenderPassTimestampWrites
 webidl.converters["GPURenderPassTimestampWrites"] = webidl
   .createDictionaryConverter(
Repository: nodejs/node
Pull request: src: do not expose simdjson.h in node_config_file.h

It is not needed, and on Windows files including the header needs some other configs otherwise errors like this may happen:

```
../../node/deps/simdjson/simdjson.h(12949,7): error: implicitly declaring library function '_BitScanReverse64' with type 'unsigned char (unsigned long *, unsigned long long) noexcept' [-Werror,-Wimplicit-function-declaration]
 12949 |   if (_BitScanReverse64(&leading_zero, input_num))
       |       ^
../../node/deps/simdjson/simdjson.h(12949,7): note: include the header <intrin.h> or explicitly provide a declaration for '_BitScanReverse64'
1 error generated.
```

Changed files:
filename: src/node_config_file.h
patch: @@ -6,7 +6,6 @@
 #include <map>
 #include <string>
 #include <variant>
-#include "simdjson.h"
 #include "util-inl.h"
 
 namespace node {
Repository: ggml-org/llama.cpp
Pull request: server : fix handling of the ignore_eos flag

fix https://github.com/ggml-org/llama.cpp/pull/14695#issue-3232092501

- Remove `slot_params.ignore_eos`
- When `ignore_eos` is passed in the request, we ignore all EOG tokens by adding -INF logit bias to the sampler

Changed files:
filename: tools/server/server.cpp
patch: @@ -127,7 +127,6 @@ struct slot_params {
     std::vector<std::string> response_fields;
     bool timings_per_token = false;
     bool post_sampling_probs = false;
-    bool ignore_eos = false;
 
     struct common_params_sampling sampling;
     struct common_params_speculative speculative;
@@ -441,7 +440,6 @@ struct server_task {
 
         {
             params.sampling.logit_bias.clear();
-            params.ignore_eos = json_value(data, "ignore_eos", false);
 
             const auto & logit_bias = data.find("logit_bias");
             if (logit_bias != data.end() && logit_bias->is_array()) {
@@ -472,6 +470,16 @@ struct server_task {
                     }
                 }
             }
+
+            params.sampling.ignore_eos = json_value(data, "ignore_eos", params_base.sampling.ignore_eos);
+            if (params.sampling.ignore_eos) {
+                for (llama_token i = 0; i < llama_vocab_n_tokens(vocab); i++) {
+                    if (llama_vocab_is_eog(vocab, i)) {
+                        //SRV_DBG("%s: added %s logit bias = %f\n", __func__, common_token_to_piece(ctx, i).c_str(), -INFINITY);
+                        params.sampling.logit_bias.push_back({i, -INFINITY});
+                    }
+                }
+            }
         }
 
         {
@@ -2217,10 +2225,6 @@ struct server_context {
             slot.params.n_predict = slot.n_predict;
         }
 
-        if (slot.params.ignore_eos && has_eos_token) {
-            slot.params.sampling.logit_bias.push_back({llama_vocab_eos(vocab), -INFINITY});
-        }
-
         {
             if (slot.smpl != nullptr) {
                 common_sampler_free(slot.smpl);
Repository: denoland/deno
Pull request: fix(lsp): ignore editor indent settings if deno.json is present

Fixes https://github.com/denoland/vscode_deno/issues/1140.

Changed files:
filename: cli/lsp/language_server.rs
patch: @@ -1396,9 +1396,11 @@ impl Inner {
         .fmt_config_for_specifier(&specifier)
         .options
         .clone();
-      fmt_options.use_tabs = Some(!params.options.insert_spaces);
-      fmt_options.indent_width = Some(params.options.tab_size as u8);
       let config_data = self.config.tree.data_for_specifier(&specifier);
+      if !config_data.is_some_and(|d| d.maybe_deno_json().is_some()) {
+        fmt_options.use_tabs = Some(!params.options.insert_spaces);
+        fmt_options.indent_width = Some(params.options.tab_size as u8);
+      }
       let unstable_options = UnstableFmtOptions {
         component: config_data
           .map(|d| d.unstable.contains("fmt-component"))

filename: tests/integration/lsp_tests.rs
patch: @@ -11680,7 +11680,7 @@ fn lsp_format_with_config() {
       },
       "options": {
         "tabSize": 2,
-        "insertSpaces": false
+        "insertSpaces": true,
       }
     }),
   );
Repository: huggingface/transformers
Pull request: Fixed a multiple-devices issue in SmolVLMModel

A minor fix to prevent a device mismatch issue in Smol VLM

cc. @mht-sharma 

Changed files:
filename: src/transformers/models/smolvlm/modeling_smolvlm.py
patch: @@ -750,7 +750,7 @@ def forward(
         if pixel_values is not None and image_hidden_states is not None:
             raise ValueError("You cannot specify both pixel_values and image_hidden_states at the same time")
         elif pixel_values is not None:
-            image_hidden_states = self.get_image_features(pixel_values, pixel_attention_mask)
+            image_hidden_states = self.get_image_features(pixel_values, pixel_attention_mask).to(input_ids.device)
         elif image_hidden_states is not None:
             image_hidden_states = image_hidden_states.to(dtype=self.dtype, device=input_ids.device)
 

filename: src/transformers/models/smolvlm/modular_smolvlm.py
patch: @@ -307,7 +307,7 @@ def forward(
         if pixel_values is not None and image_hidden_states is not None:
             raise ValueError("You cannot specify both pixel_values and image_hidden_states at the same time")
         elif pixel_values is not None:
-            image_hidden_states = self.get_image_features(pixel_values, pixel_attention_mask)
+            image_hidden_states = self.get_image_features(pixel_values, pixel_attention_mask).to(input_ids.device)
         elif image_hidden_states is not None:
             image_hidden_states = image_hidden_states.to(dtype=self.dtype, device=input_ids.device)
Repository: electron/electron
Pull request: build: remove unused lint package

Backport of #44525

See that PR for details.


Notes: none <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->


Changed files:
filename: package.json
patch: @@ -40,7 +40,6 @@
     "folder-hash": "^2.1.1",
     "got": "^11.8.5",
     "husky": "^8.0.1",
-    "lint": "^1.1.2",
     "lint-staged": "^10.2.11",
     "markdownlint-cli2": "^0.13.0",
     "minimist": "^1.2.8",

filename: yarn.lock
patch: @@ -4553,11 +4553,6 @@ lint-staged@^10.2.11:
     string-argv "0.3.1"
     stringify-object "^3.3.0"
 
-lint@^1.1.2:
-  version "1.1.2"
-  resolved "https://registry.yarnpkg.com/lint/-/lint-1.1.2.tgz#35ed064f322547c331358d899868664968ba371f"
-  integrity sha1-Ne0GTzIlR8MxNY2JmGhmSWi6Nx8=
-
 listr2@^2.1.0:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/listr2/-/listr2-2.2.0.tgz#cb88631258abc578c7fb64e590fe5742f28e4aac"