Repository: ggml-org/llama.cpp
Pull request: mtmd : fix glm-edge redundant token count

Cont https://github.com/ggml-org/llama.cpp/pull/13081

`libmtmd` need to exclude the 2 redundant BOI/EOI embeddings as they are now processed as text token.

For unknown reason, the provided jinja chat template (without `[gMASK]<sop>`) doesn't work. Using GLM4 template with `[gMASK]<sop>`, the model does response normally.


Changed files:
filename: examples/llava/mtmd.cpp
patch: @@ -203,9 +203,6 @@ int32_t mtmd_tokenize(mtmd_context * ctx,
     }
 
     // llava-1.5, llava-1.6, Yi-VL, Yi-34B, granite: don't need to add prefix and suffix
-    // for glm-edge, we don't need to add because the tokens are already in the returned embeddings
-
-    // TODO @ngxson : glm-edge : remove BOI / EOI tokens embeddings, decode them as normal tokens
 
     std::vector<std::string> parts = string_split_str(prompt_modified, ctx->image_marker);
     output.clear();
@@ -246,7 +243,7 @@ int32_t mtmd_tokenize(mtmd_context * ctx,
     };
 
     for (const auto & part : parts) {
-        //printf("tokenizing part: %s\n", part.c_str());
+        // printf("tokenizing part: %s\n", part.c_str());
         bool add_bos = &parts.front() == &part;
         auto tokens = mtmd_tokenize_text_internal(vocab, part, text.add_special && add_bos, text.parse_special);
         if (tokens.empty()) {
@@ -338,11 +335,6 @@ int32_t mtmd_tokenize(mtmd_context * ctx,
                 LOG_DBG("image_tokens->ny = %d\n", image_tokens->ny);
                 LOG_DBG("batch_f32 size = %d\n", (int)image_tokens->batch_f32.entries.size());
 
-                if (clip_is_glm(ctx->ctx_clip)) {
-                    // glm-edge
-                    image_tokens->nx += 2; // add 2 for the begin_of_image and end_of_image token embeddings
-                }
-
                 mtmd_input_chunk chunk{
                     MTMD_INPUT_CHUNK_TYPE_IMAGE,
                     {},

filename: src/llama-chat.cpp
patch: @@ -447,7 +447,7 @@ int32_t llm_chat_apply_template(
         if (add_ass) {
             ss << "
";
         }
-    } else if (tmpl == LLM_CHAT_TEMPLATE_CHATGLM_4) {
+    } else if (tmpl == LLM_CHAT_TEMPLATE_CHATGLM_4 || tmpl == LLM_CHAT_TEMPLATE_GLMEDGE) {
         ss << "[gMASK]" << "<sop>";
         for (auto message : chat) {
             std::string role(message->role);
@@ -456,14 +456,6 @@ int32_t llm_chat_apply_template(
         if (add_ass) {
             ss << "
";
         }
-    } else if (tmpl == LLM_CHAT_TEMPLATE_GLMEDGE) {
-        for (auto message : chat) {
-            std::string role(message->role);
-            ss << "<|" << role << "|>" << "\n" << message->content;
-        }
-        if (add_ass) {
-            ss << "
";
-        }
     } else if (tmpl == LLM_CHAT_TEMPLATE_MINICPM) {
         // MiniCPM-3B-OpenHermes-2.5-v2-GGUF
         for (auto message : chat) {

filename: tests/test-chat-template.cpp
patch: @@ -187,14 +187,15 @@ int main(void) {
             /* .bos_token= */ "",
             /* .eos_token= */ "",
         },
-        {
-            /* .name= */ "GLMEdge",
-            /* .template_str= */ "{% for item in messages %}{% if item['role'] == 'system' %}
\n{{ item['content'] }}{% elif item['role'] == 'user' %}
\n{{ item['content'] }}{% elif item['role'] == 'assistant' %}
\n{{ item['content'] }}{% endif %}{% endfor %}
",
-            /* .expected_output= */ "
\nYou are a helpful assistant
\nHello
\nHi there
\nWho are you
\n   I am an assistant   
\nAnother question
",
-            /* .expected_output_jinja= */ "
\nYou are a helpful assistant
\nHello
\nHi there
\nWho are you
\n   I am an assistant   
\nAnother question
",
-            /* .bos_token= */ "",
-            /* .eos_token= */ "",
-        },
+        // TODO @ngxson : GLMEdge produces poor result without `[gMASK]<sop>`, so we're temporarily using GLM4 template for it. We should fix this in the future.
+        // {
+        //     /* .name= */ "GLMEdge",
+        //     /* .template_str= */ "{% for item in messages %}{% if item['role'] == 'system' %}
\n{{ item['content'] }}{% elif item['role'] == 'user' %}
\n{{ item['content'] }}{% elif item['role'] == 'assistant' %}
\n{{ item['content'] }}{% endif %}{% endfor %}
",
+        //     /* .expected_output= */ "
\nYou are a helpful assistant
\nHello
\nHi there
\nWho are you
\n   I am an assistant   
\nAnother question
",
+        //     /* .expected_output_jinja= */ "
\nYou are a helpful assistant
\nHello
\nHi there
\nWho are you
\n   I am an assistant   
\nAnother question
",
+        //     /* .bos_token= */ "",
+        //     /* .eos_token= */ "",
+        // },
         {
             /* .name= */ "MiniCPM-3B-OpenHermes-2.5-v2-GGUF",
             /* .template_str= */ U8C("{% for message in messages %}{% if message['role'] == 'user' %}{{'<用户>' + message['content'].strip() + '<AI>'}}{% else %}{{message['content'].strip()}}{% endif %}{% endfor %}"),