helloadhavan/github_issues huggingface dataset:
Repository: huggingface/transformers
Pull request: Don't accidentally mutate the base_model_tp_plan

All credit goes to @gante and @arthurzucker for figuring this one out and I'm just swooping in and stealing credit because I want this to be merged quickly!

If no `tp_plan` is provided, our code uses `self.config.base_model_tp_plan` as the default. The problem is that this is a mutable, instance-level dict, and we do in fact mutate it, which causes the instance dict to get very large and weird over time. We resolve the issue by correctly copying the base dict as an instance attribute instead of mutating it in-place.

Changed files:
filename: src/transformers/modeling_utils.py
patch: @@ -1895,9 +1895,15 @@ def post_init(self):
 
         # If current model is a base model, attach `base_model_tp_plan` and `base_model_pp_plan` from config
         if self.base_model is self:
-            self._pp_plan = self.config.base_model_pp_plan
-
-        self._tp_plan = self._tp_plan or self.config.base_model_tp_plan or {}
+            self._pp_plan = (
+                self.config.base_model_pp_plan.copy() if self.config.base_model_pp_plan is not None else None
+            )
+            self._tp_plan = self.config.base_model_tp_plan.copy() if self.config.base_model_tp_plan is not None else {}
+        else:
+            self._tp_plan = self._tp_plan or {}
+            for name, module in self.named_children():
+                if plan := getattr(module, "_tp_plan", None):
+                    self._tp_plan.update({f"{name}.{k}": v for k, v in plan.items()})
         for name, module in self.named_children():
             if plan := getattr(module, "_tp_plan", None):
                 self._tp_plan.update({f"{name}.{k}": v for k, v in plan.items()})

filename: tests/generation/test_utils.py
patch: @@ -2305,6 +2305,7 @@ def test_generate_methods_with_logits_to_keep(self):
             self.assertEqual(with_all_logits.tolist(), without_all_logits.tolist())
 
     @pytest.mark.generate
+    @is_flaky
     def test_assisted_decoding_with_logits_to_keep(self):
         for model_class in self.all_generative_model_classes:
             if "logits_to_keep" not in set(inspect.signature(model_class.forward).parameters.keys()):

filename: tests/trainer/test_trainer.py
patch: @@ -803,6 +803,7 @@ def test_model_init(self):
             trainer.train()
             self.check_trained_model(trainer.model, alternate_seed=True)
 
+    @slow
     def test_gradient_accumulation_loss_alignment_with_model_loss(self):
         set_seed(42)
         import datasets
Repository: nodejs/node
Pull request: test: deflake `test-cluster-shared-handle-bind-privileged-port`

On some Linux systems (not reproducible in CI, but reproducible locally), this test will fail because the port 42 is not priviledged. For example, on my Kali Linux installation:

```console
└─$ out/Release/node test/parallel/test-cluster-shared-handle-bind-privileged-port.js
node:assert:137
  throw err;
  ^

AssertionError [ERR_ASSERTION]: listen should have failed at test/parallel/test-cluster-shared-handle-bind-privileged-port.js:51
    at Server.mustNotCall (test/common/index.js:557:12)
    at Object.onceWrapper (node:events:621:28)
    at Server.emit (node:events:519:35)
    at emitListeningNT (node:net:1948:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:89:21) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: undefined,
  operator: 'fail'
}

Node.js v23.0.0-pre
node:assert:90
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at Worker.<anonymous> (test/parallel/test-cluster-shared-handle-bind-privileged-port.js:47:12)
    at Worker.<anonymous> (test/common/index.js:491:15)
    at Worker.emit (node:events:507:28)
    at ChildProcess.<anonymous> (node:internal/cluster/primary:187:12)
    at Object.onceWrapper (node:events:622:26)
    at ChildProcess.emit (node:events:507:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}

Node.js v23.0.0-pre
```

Changed files:
filename: test/parallel/test-cluster-shared-handle-bind-privileged-port.js
patch: @@ -35,6 +35,22 @@ if (common.isWindows)
 if (process.getuid() === 0)
   common.skip('as this test should not be run as `root`');
 
+// Some systems won't have port 42 set as a privileged port, in that
+// case, skip the test.
+if (common.isLinux) {
+  const { readFileSync } = require('fs');
+
+  try {
+    const unprivilegedPortStart = parseInt(readFileSync('/proc/sys/net/ipv4/ip_unprivileged_port_start'));
+    if (unprivilegedPortStart <= 42) {
+      common.skip('Port 42 is unprivileged');
+    }
+  } catch {
+    // Do nothing, feature doesn't exist, minimum is 1024 so 42 is usable.
+    // Continue...
+  }
+}
+
 const assert = require('assert');
 const cluster = require('cluster');
 const net = require('net');
Repository: denoland/deno
Pull request: feat: upgrade V8 to 12.4


Changed files:
filename: Cargo.lock
patch: @@ -1297,9 +1297,9 @@ dependencies = [
 
 [[package]]
 name = "deno_core"
-version = "0.275.0"
+version = "0.277.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "010130fa045837285920b52a8a2b2a42a2e6aa05ee547adb796992c2de7097ff"
+checksum = "3c562e5660bfaebd9565e938402c55f482faab0c4bd7a784817d9696a9c9cdf0"
 dependencies = [
  "anyhow",
  "bincode",
@@ -1756,9 +1756,9 @@ dependencies = [
 
 [[package]]
 name = "deno_ops"
-version = "0.151.0"
+version = "0.153.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "01605540e65fcab72a454cddf67a23e007d1bf5ac7692dc186c6694cbbcb0e1d"
+checksum = "ad83b1a23861e77c36c2e7d0158a24d613c8a2303b423d0a2c21b27bc199821c"
 dependencies = [
  "proc-macro-rules",
  "proc-macro2",
@@ -5703,9 +5703,9 @@ dependencies = [
 
 [[package]]
 name = "serde_v8"
-version = "0.184.0"
+version = "0.186.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c27d659c725a9bad587a4da48bc46da09cf9347dc536ec99dae8e228ba29b96f"
+checksum = "ed95f28fe0e7082a4bf8b914d14d3876e21340fab5c088556496e5c4b26cfedb"
 dependencies = [
  "bytes",
  "num-bigint",
@@ -7226,9 +7226,9 @@ dependencies = [
 
 [[package]]
 name = "v8"
-version = "0.90.1"
+version = "0.91.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f1bcf540b968aed8a609e790ec7d25d064a70d62b48677cc9cff085528c56918"
+checksum = "03bdee44e85d6235cff99e1ed5b1016c53822c70d1cce3d51f421b27a125a1e8"
 dependencies = [
  "bitflags 2.5.0",
  "fslock",

filename: Cargo.toml
patch: @@ -44,7 +44,7 @@ repository = "https://github.com/denoland/deno"
 
 [workspace.dependencies]
 deno_ast = { version = "=0.37.1", features = ["transpiling"] }
-deno_core = { version = "0.275.0" }
+deno_core = { version = "0.277.0" }
 
 deno_bench_util = { version = "0.141.0", path = "./bench_util" }
 deno_lockfile = "0.19.0"
Repository: vercel/next.js
Pull request: log the instrumentation-client execution time

Follow up to https://github.com/vercel/next.js/pull/76916#discussion_r1994126285


![CleanShot 2025-03-14 at 10.33.51@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/rKSEEwxbNzdFs9t0yyxN/13cbdcea-02c2-41b4-9219-103b1dbf545e.png)



Changed files:
filename: packages/next/src/lib/require-instrumentation-client.ts
patch: @@ -4,7 +4,15 @@
  * The `private-next-instrumentation-client` module is automatically aliased to
  * the `instrumentation-client.ts` file in the project root by webpack or turbopack.
  */
-
 if (process.env.__NEXT_EXPERIMENTAL_CLIENT_INSTRUMENTATION_HOOK) {
-  require('private-next-instrumentation-client')
+  if (process.env.NODE_ENV === 'development') {
+    const startTime = performance.now()
+    require('private-next-instrumentation-client')
+    const endTime = performance.now()
+    console.log(
+      `[Client Instrumentation Hook] executed in ${(endTime - startTime).toFixed(0)}ms (Note: Code download overhead is not included in this measurement)`
+    )
+  } else {
+    require('private-next-instrumentation-client')
+  }
 }

filename: test/e2e/instrumentation-client-hook/instrumentation-client-hook.test.ts
patch: @@ -20,7 +20,7 @@ describe('Instrumentation Client Hook', () => {
 
   testCases.forEach(({ name, appDir }) => {
     describe(name, () => {
-      const { next } = nextTestSetup({
+      const { next, isNextDev } = nextTestSetup({
         files: path.join(__dirname, appDir),
       })
 
@@ -35,6 +35,11 @@ describe('Instrumentation Client Hook', () => {
         expect(instrumentationTime).toBeDefined()
         expect(hydrationTime).toBeDefined()
         expect(instrumentationTime).toBeLessThan(hydrationTime)
+        expect(
+          (await browser.log()).some((log) =>
+            log.message.startsWith('[Client Instrumentation Hook]')
+          )
+        ).toBe(isNextDev)
       })
     })
   })
Repository: ggml-org/llama.cpp
Pull request: llava: add big-endian conversion for image encoder

This pull request enables Big-Endian byte-ordering conversion for the `convert_image_encoder_to_gguf.py` script within `examples/llava`. Tested on IBM z15 and it successfully generates the mmproj-model.gguf file for Big-Endian.

PR also in-preparation for Granite Vision surgery for Big-Endian machines i.e., IBM Z & LinuxONE

Changed files:
filename: examples/llava/convert_image_encoder_to_gguf.py
patch: @@ -89,6 +89,7 @@ def bytes_to_unicode():
 ap = argparse.ArgumentParser()
 ap.add_argument("-m", "--model-dir", help="Path to model directory cloned from HF Hub", required=True)
 ap.add_argument("--use-f32", action="store_true", default=False, help="Use f32 instead of f16")
+ap.add_argument('--bigendian', action="store_true", default=False, help="Model is executed on big-endian machine")
 ap.add_argument("--text-only", action="store_true", required=False,
                 help="Save a text-only model. It can't be used to encode images")
 ap.add_argument("--vision-only", action="store_true", required=False,
@@ -191,7 +192,7 @@ def bytes_to_unicode():
 os.makedirs(output_dir, exist_ok=True)
 output_prefix = os.path.basename(output_dir).replace("ggml_", "")
 fname_out = os.path.join(output_dir, f"{fname_middle}model-{ftype_str[ftype]}.gguf")
-fout = GGUFWriter(path=fname_out, arch="clip")
+fout = GGUFWriter(path=fname_out, arch="clip", endianess=GGUFEndian.LITTLE if not args.bigendian else GGUFEndian.BIG)
 
 fout.add_bool("clip.has_text_encoder", has_text_encoder)
 fout.add_bool("clip.has_vision_encoder", has_vision_encoder)
Repository: facebook/react
Pull request: DevTools bugfix for useState() with hasOwnProperty key

Fixes bug reported in #21522

Changed files:
filename: packages/react-devtools-shared/src/__tests__/profilerStore-test.js
patch: @@ -135,4 +135,36 @@ describe('ProfilerStore', () => {
       });
     }).toThrow('Cannot modify filter preferences while profiling');
   });
+
+  it('should not throw if state contains a property hasOwnProperty ', () => {
+    let setStateCallback;
+    const ControlledInput = () => {
+      const [state, setState] = React.useState({hasOwnProperty: true});
+      setStateCallback = setState;
+      return state.hasOwnProperty;
+    };
+
+    const container = document.createElement('div');
+
+    // This element has to be in the <body> for the event system to work.
+    document.body.appendChild(container);
+
+    // It's important that this test uses legacy sync mode.
+    // The root API does not trigger this particular failing case.
+    ReactDOM.render(<ControlledInput />, container);
+
+    utils.act(() => store.profilerStore.startProfiling());
+    utils.act(() =>
+      setStateCallback({
+        hasOwnProperty: false,
+      }),
+    );
+    utils.act(() => store.profilerStore.stopProfiling());
+
+    // Only one commit should have been recorded (in response to the "change" event).
+    const root = store.roots[0];
+    const data = store.profilerStore.getDataForRoot(root);
+    expect(data.commitData).toHaveLength(1);
+    expect(data.operations).toHaveLength(1);
+  });
 });

filename: packages/react-devtools-shared/src/backend/renderer.js
patch: @@ -1221,15 +1221,18 @@ export function attach(
   }
 
   function isEffect(memoizedState) {
+    if (memoizedState === null || typeof memoizedState !== 'object') {
+      return false;
+    }
+    const {deps} = memoizedState;
+    const hasOwnProperty = Object.prototype.hasOwnProperty.bind(memoizedState);
     return (
-      memoizedState !== null &&
-      typeof memoizedState === 'object' &&
-      memoizedState.hasOwnProperty('tag') &&
-      memoizedState.hasOwnProperty('create') &&
-      memoizedState.hasOwnProperty('destroy') &&
-      memoizedState.hasOwnProperty('deps') &&
-      (memoizedState.deps === null || isArray(memoizedState.deps)) &&
-      memoizedState.hasOwnProperty('next')
+      hasOwnProperty('create') &&
+      hasOwnProperty('destroy') &&
+      hasOwnProperty('deps') &&
+      hasOwnProperty('next') &&
+      hasOwnProperty('tag') &&
+      (deps === null || isArray(deps))
     );
   }
Repository: denoland/deno
Pull request: FUTURE: remove `Deno.customInspect`

Towards #23089

Changed files:
filename: runtime/js/99_main.js
patch: @@ -667,7 +667,7 @@ ObjectDefineProperties(finalDenoNs, {
         new Error().stack,
         'Use `Symbol.for("Deno.customInspect")` instead.',
       );
-      return customInspect;
+      return internals.future ? undefined : customInspect;
     },
   },
 });

filename: tests/specs/future/runtime_api/main.js
patch: @@ -61,8 +61,12 @@ if (Deno.build.os === "windows") {
 // TLS
 // Since these tests may run in parallel, ensure this port is unique to this file
 const tlsPort = 4510;
-const cert = Deno.readTextFileSync("../../../testdata/tls/localhost.crt");
-const key = Deno.readTextFileSync("../../../testdata/tls/localhost.key");
+const cert = Deno.readTextFileSync(
+  new URL("../../../testdata/tls/localhost.crt", import.meta.url),
+);
+const key = Deno.readTextFileSync(
+  new URL("../../../testdata/tls/localhost.key", import.meta.url),
+);
 const tlsListener = Deno.listenTls({ port: tlsPort, cert, key });
 console.log("Deno.TlsListener.prototype.rid is", tlsListener.rid);
 
@@ -88,4 +92,6 @@ try {
   }
 }
 
+console.log("Deno.customInspect is", Deno.customInspect);
+
 self.close();

filename: tests/specs/future/runtime_api/main.out
patch: @@ -34,3 +34,4 @@ Deno.TlsListener.prototype.rid is undefined
 Deno.TlsConn.prototype.rid is undefined
 Deno.FsWatcher.prototype.rid is undefined
 Deno.FsFile constructor is illegal
+Deno.customInspect is undefined
Repository: nodejs/node
Pull request: deps: update googletest to df1544b

This is an automated update of googletest to df1544b.

Changed files:
filename: deps/googletest/src/gtest.cc
patch: @@ -1660,10 +1660,25 @@ std::string GetBoolAssertionFailureMessage(
   return msg.GetString();
 }
 
-// Helper function for implementing ASSERT_NEAR.
+// Helper function for implementing ASSERT_NEAR. Treats infinity as a specific
+// value, such that comparing infinity to infinity is equal, the distance
+// between -infinity and +infinity is infinity, and infinity <= infinity is
+// true.
 AssertionResult DoubleNearPredFormat(const char* expr1, const char* expr2,
                                      const char* abs_error_expr, double val1,
                                      double val2, double abs_error) {
+  // We want to return success when the two values are infinity and at least
+  // one of the following is true:
+  //  * The values are the same-signed infinity.
+  //  * The error limit itself is infinity.
+  // This is done here so that we don't end up with a NaN when calculating the
+  // difference in values.
+  if (std::isinf(val1) && std::isinf(val2) &&
+      (std::signbit(val1) == std::signbit(val2) ||
+       (abs_error > 0.0 && std::isinf(abs_error)))) {
+    return AssertionSuccess();
+  }
+
   const double diff = fabs(val1 - val2);
   if (diff <= abs_error) return AssertionSuccess();
Repository: huggingface/transformers
Pull request: Fix bnb regression due to empty state dict

# What does this PR do?

This PR fixes a bug that was introduced since we are loading empty state dict now. For bnb, we need to pass a full state dict as we extract some params from it. 

Changed files:
filename: src/transformers/modeling_utils.py
patch: @@ -833,7 +833,7 @@ def _load_state_dict_into_meta_model(
     bin_state_dict = None
     if shard_file.endswith(".safetensors"):
         file_pointer = safe_open(shard_file, framework="pt", device=tensor_device)
-    else:
+    elif shard_file.endswith(".bin"):
         map_location = "cpu"
         if (
             device_map is not None
@@ -848,6 +848,13 @@ def _load_state_dict_into_meta_model(
 
     is_quantized = hf_quantizer is not None
 
+    # get full state dict
+    if is_quantized:
+        if shard_file.endswith(".safetensors"):
+            full_state_dict = load_state_dict(shard_file, map_location="cpu")
+        elif shard_file.endswith(".bin"):
+            full_state_dict = bin_state_dict
+
     for serialized_param_name, empty_param in state_dict.items():
         # serialized_param_name is the raw, serialized name
         # fixed_param_name is the model's equivalent
@@ -912,7 +919,7 @@ def _load_state_dict_into_meta_model(
                         model,
                         param,
                         fixed_param_name,
-                        state_dict,
+                        full_state_dict,
                         param_device=param_device,
                         device_map=device_map,
                     )
@@ -928,7 +935,7 @@ def _load_state_dict_into_meta_model(
                 )
             else:
                 hf_quantizer.create_quantized_param(
-                    model, param, fixed_param_name, param_device, state_dict, unexpected_keys
+                    model, param, fixed_param_name, param_device, full_state_dict, unexpected_keys
                 )
                 # For quantized modules with FSDP/DeepSpeed Stage 3, we need to quantize the parameter on the GPU
                 # and then cast it to CPU to avoid excessive memory usage on each GPU
Repository: denoland/deno
Pull request: fix(fmt): error for more unterminated nodes

https://github.com/dprint/dprint-plugin-typescript/pull/628

Closes https://github.com/denoland/deno/issues/23438

Changed files:
filename: .dprint.json
patch: @@ -57,7 +57,7 @@
     "ext/websocket/autobahn/reports"
   ],
   "plugins": [
-    "https://plugins.dprint.dev/typescript-0.90.1.wasm",
+    "https://plugins.dprint.dev/typescript-0.90.3.wasm",
     "https://plugins.dprint.dev/json-0.19.2.wasm",
     "https://plugins.dprint.dev/markdown-0.16.4.wasm",
     "https://plugins.dprint.dev/toml-0.6.1.wasm",

filename: Cargo.lock
patch: @@ -2302,9 +2302,9 @@ dependencies = [
 
 [[package]]
 name = "dprint-plugin-typescript"
-version = "0.90.2"
+version = "0.90.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f46179b46809eb71f8d73898a5ef4660a0e60df4bf17821654eec771cbf457ec"
+checksum = "e1339c9a9642a58bd6ac77018b5e06a1dd61f524a8097586231112839dcc7c70"
 dependencies = [
  "anyhow",
  "deno_ast",

filename: cli/Cargo.toml
patch: @@ -98,7 +98,7 @@ dotenvy = "0.15.7"
 dprint-plugin-json = "=0.19.2"
 dprint-plugin-jupyter = "=0.1.3"
 dprint-plugin-markdown = "=0.16.4"
-dprint-plugin-typescript = "=0.90.2"
+dprint-plugin-typescript = "=0.90.3"
 env_logger = "=0.10.0"
 fancy-regex = "=0.10.0"
 faster-hex.workspace = true
Repository: ggml-org/llama.cpp
Pull request: HIP/CUDA: set the paramerter value in maintain_cuda_graph instead of replaceing it.

This avoids conflict with internal cuda/hip runtime memory management behavior.

This fix is a stop gap fix for https://github.com/ggml-org/llama.cpp/issues/12152

Changed files:
filename: ggml/src/ggml-cuda/ggml-cuda.cu
patch: @@ -2571,7 +2571,7 @@ static void maintain_cuda_graph(ggml_backend_cuda_context * cuda_ctx, std::vecto
         for (size_t i = 0; i < cuda_ctx->cuda_graph->num_nodes; i++) {
             if(count(ggml_cuda_cpy_fn_ptrs.begin(), ggml_cuda_cpy_fn_ptrs.end(), cuda_ctx->cuda_graph->params[i].func) > 0) {
                 char ** updated_kernel_arg_ptr = cuda_ctx->cuda_graph->updated_kernel_arg.at(k++);
-                cuda_ctx->cuda_graph->params[i].kernelParams[1] = updated_kernel_arg_ptr;
+                *(void**)cuda_ctx->cuda_graph->params[i].kernelParams[1] = *(void**)updated_kernel_arg_ptr;
                 CUDA_CHECK(cudaGraphKernelNodeSetParams(cuda_ctx->cuda_graph->nodes[i], &cuda_ctx->cuda_graph->params[i]));
             }
         }
Repository: electron/electron
Pull request: fix: dangling raw_ptr<Session> in UserDataLink

Manual backport of #42786. See that PR for details.

Notes: none

Changed files:
filename: shell/browser/api/electron_api_session.cc
patch: @@ -530,9 +530,10 @@ class DictionaryObserver final : public SpellcheckCustomDictionary::Observer {
 #endif  // BUILDFLAG(ENABLE_BUILTIN_SPELLCHECKER)
 
 struct UserDataLink : base::SupportsUserData::Data {
-  explicit UserDataLink(Session* ses) : session(ses) {}
+  explicit UserDataLink(base::WeakPtr<Session> session_in)
+      : session{std::move(session_in)} {}
 
-  raw_ptr<Session> session;
+  base::WeakPtr<Session> session;
 };
 
 const void* kElectronApiSessionKey = &kElectronApiSessionKey;
@@ -552,8 +553,9 @@ Session::Session(v8::Isolate* isolate, ElectronBrowserContext* browser_context)
 
   protocol_.Reset(isolate, Protocol::Create(isolate, browser_context).ToV8());
 
-  browser_context->SetUserData(kElectronApiSessionKey,
-                               std::make_unique<UserDataLink>(this));
+  browser_context->SetUserData(
+      kElectronApiSessionKey,
+      std::make_unique<UserDataLink>(weak_factory_.GetWeakPtr()));
 
 #if BUILDFLAG(ENABLE_BUILTIN_SPELLCHECKER)
   SpellcheckService* service =
@@ -1512,7 +1514,7 @@ bool Session::IsSpellCheckerEnabled() const {
 Session* Session::FromBrowserContext(content::BrowserContext* context) {
   auto* data =
       static_cast<UserDataLink*>(context->GetUserData(kElectronApiSessionKey));
-  return data ? data->session : nullptr;
+  return data ? data->session.get() : nullptr;
 }
 
 // static

filename: shell/browser/api/electron_api_session.h
patch: @@ -10,6 +10,7 @@
 #include <vector>
 
 #include "base/memory/raw_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "content/public/browser/download_manager.h"
 #include "electron/buildflags/buildflags.h"
@@ -215,7 +216,9 @@ class Session : public gin::Wrappable<Session>,
   // The client id to enable the network throttler.
   base::UnguessableToken network_emulation_token_;
 
-  raw_ptr<ElectronBrowserContext> browser_context_;
+  const raw_ptr<ElectronBrowserContext> browser_context_;
+
+  base::WeakPtrFactory<Session> weak_factory_{this};
 };
 
 }  // namespace api
Repository: nodejs/node
Pull request: doc: remove outdated remarks about `highWaterMark` in fs

`Readable`'s `highWaterMark` has in fact been 64KiB since #52037.

Changed files:
filename: doc/api/fs.md
patch: @@ -270,9 +270,6 @@ added: v16.11.0
   * `signal` {AbortSignal|undefined} **Default:** `undefined`
 * Returns: {fs.ReadStream}
 
-Unlike the 16 KiB default `highWaterMark` for a {stream.Readable}, the stream
-returned by this method has a default `highWaterMark` of 64 KiB.
-
 `options` can include `start` and `end` values to read a range of bytes from
 the file instead of the entire file. Both `start` and `end` are inclusive and
 start counting at 0, allowed values are in the
@@ -2551,9 +2548,6 @@ changes:
   * `signal` {AbortSignal|null} **Default:** `null`
 * Returns: {fs.ReadStream}
 
-Unlike the 16 KiB default `highWaterMark` for a {stream.Readable}, the stream
-returned by this method has a default `highWaterMark` of 64 KiB.
-
 `options` can include `start` and `end` values to read a range of bytes from
 the file instead of the entire file. Both `start` and `end` are inclusive and
 start counting at 0, allowed values are in the