Repository: facebook/react
Pull request: Fix Jest cache for transform-react-version-pragma

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary
Jest caching wasn't working correctly for `transform-react-version-pragma`. One condition for including `transform-react-version-pragma` is that `process.env.REACT_VERSION` is set, but it wasn't included in the cache key computation. Thus local test runs would only run without `transform-react-version-pragma`, if jest runs weren't using the `-reactVersion` flag and then added it.

Inlined the `scripts/jest/devtools/preprocessor.js` file, because it makes it more obvious that `process.env.REACT_VERSION` is used in `scripts/jest/preprocessor.js`

<!--
 Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->

## How did you test this change?

<!--
  Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
  How exactly did you verify that your PR solves the issue you wanted to solve?
  If you leave this empty, your PR will very likely be closed.
-->

Repro step:
- Clear jest cache
- node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 18.0
- node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental

Before:
Jest cached the first run with `REACT_VERSION` set, so in the second run `transform-react-version-pragma` is still there and runs only the regression tests on old react versions. 

After:
- The second run runs all tests and ignore `// @reactVersion` as expected.

Changed files:
filename: scripts/jest/devtools/preprocessor.js
patch: @@ -1,20 +0,0 @@
-'use strict';
-
-const pathToTransformReactVersionPragma = require.resolve(
-  '../../babel/transform-react-version-pragma'
-);
-
-function getDevToolsPlugins(filePath) {
-  const plugins = [];
-  if (
-    process.env.REACT_VERSION ||
-    filePath.match(/\/transform-react-version-pragma-test/)
-  ) {
-    plugins.push(pathToTransformReactVersionPragma);
-  }
-  return plugins;
-}
-
-module.exports = {
-  getDevToolsPlugins,
-};

filename: scripts/jest/preprocessor.js
patch: @@ -7,7 +7,6 @@ const coffee = require('coffee-script');
 
 const tsPreprocessor = require('./typescript/preprocessor');
 const createCacheKeyFunction = require('fbjs-scripts/jest/createCacheKeyFunction');
-const {getDevToolsPlugins} = require('./devtools/preprocessor.js');
 
 const pathToBabel = path.join(
   require.resolve('@babel/core'),
@@ -26,6 +25,9 @@ const pathToTransformInfiniteLoops = require.resolve(
 const pathToTransformTestGatePragma = require.resolve(
   '../babel/transform-test-gate-pragma'
 );
+const pathToTransformReactVersionPragma = require.resolve(
+  '../babel/transform-react-version-pragma'
+);
 const pathToBabelrc = path.join(__dirname, '..', '..', 'babel.config.js');
 const pathToErrorCodes = require.resolve('../error-codes/codes.json');
 
@@ -83,8 +85,13 @@ module.exports = {
       const plugins = (isTestFile ? testOnlyPlugins : sourceOnlyPlugins).concat(
         babelOptions.plugins
       );
-      if (isTestFile && isInDevToolsPackages) {
-        plugins.push(...getDevToolsPlugins(filePath));
+      if (
+        isTestFile &&
+        isInDevToolsPackages &&
+        (process.env.REACT_VERSION ||
+          filePath.match(/\/transform-react-version-pragma-test/))
+      ) {
+        plugins.push(pathToTransformReactVersionPragma);
       }
       return babel.transform(
         src,
@@ -103,12 +110,19 @@ module.exports = {
     return src;
   },
 
-  getCacheKey: createCacheKeyFunction([
-    __filename,
-    pathToBabel,
-    pathToBabelrc,
-    pathToTransformInfiniteLoops,
-    pathToTransformTestGatePragma,
-    pathToErrorCodes,
-  ]),
+  getCacheKey: createCacheKeyFunction(
+    [
+      __filename,
+      pathToBabel,
+      pathToBabelrc,
+      pathToTransformInfiniteLoops,
+      pathToTransformTestGatePragma,
+      pathToTransformReactVersionPragma,
+      pathToErrorCodes,
+    ],
+    [
+      (process.env.REACT_VERSION != null).toString(),
+      (process.env.NODE_ENV === 'development').toString(),
+    ]
+  ),
 };