helloadhavan/github_issues huggingface dataset:
Repository: ggml-org/llama.cpp
Pull request: vulkan: fix warnings in perf logger querypool code

Fix some warnings about type mismatch, uninitialized fields, and unused result.

Changed files:
filename: ggml/src/ggml-vulkan/ggml-vulkan.cpp
patch: @@ -444,7 +444,7 @@ struct vk_device_struct {
     // for GGML_VK_PERF_LOGGER
     std::unique_ptr<vk_perf_logger> perf_logger;
     vk::QueryPool query_pool;
-    uint32_t num_queries;
+    int32_t num_queries;
 
     ~vk_device_struct() {
         VK_LOG_DEBUG("destroy device " << name);
@@ -9513,8 +9513,8 @@ static ggml_status ggml_backend_vk_graph_compute(ggml_backend_t backend, ggml_cg
             if (ctx->device->query_pool) {
                 ctx->device->device.destroyQueryPool(ctx->device->query_pool);
             }
-            VkQueryPoolCreateInfo query_create_info = { VK_STRUCTURE_TYPE_QUERY_POOL_CREATE_INFO };
-            query_create_info.queryType = VK_QUERY_TYPE_TIMESTAMP;
+            vk::QueryPoolCreateInfo query_create_info;
+            query_create_info.queryType = vk::QueryType::eTimestamp;
             query_create_info.queryCount = cgraph->n_nodes + 100;
             ctx->device->query_pool = ctx->device->device.createQueryPool(query_create_info);
             ctx->device->num_queries = query_create_info.queryCount;
@@ -9600,7 +9600,7 @@ static ggml_status ggml_backend_vk_graph_compute(ggml_backend_t backend, ggml_cg
 
         // Get the results and pass them to the logger
         std::vector<uint64_t> timestamps(cgraph->n_nodes + 1);
-        ctx->device->device.getQueryPoolResults(ctx->device->query_pool, 0, cgraph->n_nodes + 1, (cgraph->n_nodes + 1)*sizeof(uint64_t), timestamps.data(), sizeof(uint64_t), vk::QueryResultFlagBits::e64 | vk::QueryResultFlagBits::eWait);
+        VK_CHECK(ctx->device->device.getQueryPoolResults(ctx->device->query_pool, 0, cgraph->n_nodes + 1, (cgraph->n_nodes + 1)*sizeof(uint64_t), timestamps.data(), sizeof(uint64_t), vk::QueryResultFlagBits::e64 | vk::QueryResultFlagBits::eWait), "get timestamp results");
         for (int i = 0; i < cgraph->n_nodes; i++) {
             if (!ggml_vk_is_empty(cgraph->nodes[i])) {
                 ctx->device->perf_logger->log_timing(cgraph->nodes[i], uint64_t((timestamps[i+1] - timestamps[i]) * ctx->device->properties.limits.timestampPeriod));
Repository: nodejs/node
Pull request: build: drop support for python 3.8

> After next Monday ___acceptable___ versions should be py39, py310, py311, py312, py313.

_Originally posted by @cclauss in https://github.com/nodejs/node/issues/54358#issuecomment-2388762359_


Changed files:
filename: android-configure
patch: @@ -9,7 +9,6 @@ command -v python3.12 >/dev/null && exec python3.12 "$0" "$@"
 command -v python3.11 >/dev/null && exec python3.11 "$0" "$@"
 command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
 command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
-command -v python3.8 >/dev/null && exec python3.8 "$0" "$@"
 command -v python3 >/dev/null && exec python3 "$0" "$@"
 exec python "$0" "$@"
 ''' "$0" "$@"
@@ -23,7 +22,7 @@ except ImportError:
   from distutils.spawn import find_executable as which
 
 print('Node.js android configure: Found Python {}.{}.{}...'.format(*sys.version_info))
-acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8))
+acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9))
 if sys.version_info[:2] in acceptable_pythons:
   import android_configure
 else:

filename: configure
patch: @@ -9,7 +9,6 @@ command -v python3.12 >/dev/null && exec python3.12 "$0" "$@"
 command -v python3.11 >/dev/null && exec python3.11 "$0" "$@"
 command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
 command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
-command -v python3.8 >/dev/null && exec python3.8 "$0" "$@"
 command -v python3 >/dev/null && exec python3 "$0" "$@"
 exec python "$0" "$@"
 ''' "$0" "$@"
@@ -23,7 +22,7 @@ except ImportError:
   from distutils.spawn import find_executable as which
 
 print('Node.js configure: Found Python {}.{}.{}...'.format(*sys.version_info))
-acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8))
+acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9))
 if sys.version_info[:2] in acceptable_pythons:
   import configure
 else:

filename: configure.py
patch: @@ -2143,7 +2143,7 @@ def make_bin_override():
   if sys.platform == 'win32':
     raise Exception('make_bin_override should not be called on win32.')
   # If the system python is not the python we are running (which should be
-  # python 3.8+), then create a directory with a symlink called `python` to our
+  # python 3.9+), then create a directory with a symlink called `python` to our
   # sys.executable. This directory will be prefixed to the PATH, so that
   # other tools that shell out to `python` will use the appropriate python
 

filename: pyproject.toml
patch: @@ -7,7 +7,7 @@ exclude = [
   "tools/eslint/node_modules"
 ]
 line-length = 172
-target-version = "py38"
+target-version = "py39"
 
 [tool.ruff.lint]
 select = [
Repository: denoland/deno
Pull request: test: make specs::test::doc_success less flaky

On Windows some of these steps were taking more than 1s

Changed files:
filename: tests/specs/test/doc_success/main.out
patch: @@ -5,15 +5,15 @@ Check [WILDCARD]/main.ts$26-31.tsx
 Check [WILDCARD]/main.ts$42-47.ts
 running 0 tests from ./main.ts
 running 1 test from ./main.ts$8-13.js
-[WILDCARD]/main.ts$8-13.js ... ok ([WILDCARD]ms)
+[WILDCARD]/main.ts$8-13.js ... ok ([WILDCARD]s)
 running 1 test from ./main.ts$14-19.jsx
-[WILDCARD]/main.ts$14-19.jsx ... ok ([WILDCARD]ms)
+[WILDCARD]/main.ts$14-19.jsx ... ok ([WILDCARD]s)
 running 1 test from ./main.ts$20-25.ts
-[WILDCARD]/main.ts$20-25.ts ... ok ([WILDCARD]ms)
+[WILDCARD]/main.ts$20-25.ts ... ok ([WILDCARD]s)
 running 1 test from ./main.ts$26-31.tsx
-[WILDCARD]/main.ts$26-31.tsx ... ok ([WILDCARD]ms)
+[WILDCARD]/main.ts$26-31.tsx ... ok ([WILDCARD]s)
 running 1 test from ./main.ts$42-47.ts
-[WILDCARD]/main.ts$42-47.ts ... ok ([WILDCARD]ms)
+[WILDCARD]/main.ts$42-47.ts ... ok ([WILDCARD]s)
 
 ok | 5 passed | 0 failed ([WILDCARD]ms)
Repository: facebook/react
Pull request: fixture: Fix typo from perfomrance to performance

I fixed typo from perfomrance to performance (line 2) in README.md of fizz

Changed files:
filename: fixtures/fizz/README.md
patch: @@ -1,6 +1,6 @@
 # Fizz Fixtures
 
-A set of basic tests for Fizz primarily focussed on baseline perfomrance of legacy renderToString and streaming implementations.
+A set of basic tests for Fizz primarily focussed on baseline performance of legacy renderToString and streaming implementations.
 
 ## Setup
Repository: electron/electron
Pull request: ci: write test logging to console on Windows

Backport of #43990

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: appveyor-woa.yml
patch: @@ -326,4 +326,3 @@ for:
     on_finish:
       # Uncomment these lines to enable RDP
       # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
-      - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log )

filename: appveyor.yml
patch: @@ -307,7 +307,7 @@ for:
           if ($env:TARGET_ARCH -eq 'ia32') {
             $env:npm_config_arch = "ia32"
           }
-      - echo Running main test suite & node script/yarn test -- --trace-uncaught --runners=main --enable-logging=file --log-file=%cd%\electron.log
+      - echo Running main test suite & node script/yarn test -- --trace-uncaught --runners=main --enable-logging
       - cd ..
       - echo Verifying non proprietary ffmpeg & python electron\script\verify-ffmpeg.py --build-dir out\Default --source-root %cd% --ffmpeg-path out\ffmpeg
       - echo "About to verify mksnapshot"
@@ -319,4 +319,3 @@ for:
     on_finish:
       # Uncomment these lines to enable RDP
       # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
-      - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log )
Repository: denoland/deno
Pull request: ci: Fix uploading latest canary version


Changed files:
filename: .github/workflows/ci.generate.ts
patch: @@ -1087,6 +1087,7 @@ const ci = {
       if:
         "github.repository == 'denoland/deno' && github.ref == 'refs/heads/main'",
       steps: [
+        ...cloneRepoStep,
         authenticateWithGoogleCloud,
         {
           name: "Setup gcloud",

filename: .github/workflows/ci.yml
patch: @@ -683,6 +683,15 @@ jobs:
       - build
     if: github.repository == 'denoland/deno' && github.ref == 'refs/heads/main'
     steps:
+      - name: Configure git
+        run: |-
+          git config --global core.symlinks true
+          git config --global fetch.parallel 32
+      - name: Clone repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 50
+          submodules: false
       - name: Authenticate with Google Cloud
         uses: google-github-actions/auth@v2
         with:
Repository: electron/electron
Pull request: ci: write test logging to console on Windows

#### Description of Change

<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->
Windows testing (on x64 and ia32) on AppVeyor was throwing the following error during testing:
```ERROR:logging.cc(148)] Failed to init logging: Access is denied. (0x5)```
I investigated this error and it appears that it is simply a contention issue writing to an error log. (https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/50689680/job/hw1k8991ug0jkkve contains some additional debugging to try to track down this issue). In looking at the rest of our CI configurations, we do not write to an error log file but instead log errors to the console.  This PR moves our Windows testing on AppVeyor to write logging to the console to be consistent with the rest of CI.
 
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: appveyor-woa.yml
patch: @@ -328,4 +328,3 @@ for:
     on_finish:
       # Uncomment these lines to enable RDP
       # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
-      - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log )

filename: appveyor.yml
patch: @@ -308,7 +308,7 @@ for:
           if ($env:TARGET_ARCH -eq 'ia32') {
             $env:npm_config_arch = "ia32"
           }
-      - echo Running main test suite & node script/yarn test -- --trace-uncaught --runners=main --enable-logging=file --log-file=%cd%\electron.log
+      - echo Running main test suite & node script/yarn test -- --trace-uncaught --runners=main --enable-logging
       - cd ..
       - echo Verifying non proprietary ffmpeg & python electron\script\verify-ffmpeg.py --build-dir out\Default --source-root %cd% --ffmpeg-path out\ffmpeg
       - echo "About to verify mksnapshot"
@@ -320,4 +320,3 @@ for:
     on_finish:
       # Uncomment these lines to enable RDP
       # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
-      - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log )
Repository: huggingface/transformers
Pull request: fix(conversion): Fix size mismatch error during TF->PT model loading

# What does this PR do?

Loading a PyTorch model from a saved TensorFlow checkpoint using
`from_pretrained(..., from_tf=True)` could fail with a
`RuntimeError: size mismatch`. The error indicated that weights like
position embeddings were expected to have the shape of word embeddings
(e.g., [vocab_size, hidden_size]).

This issue was triggered by recent changes that defaulted to initializing
the PyTorch model with meta tensors (`init_empty_weights`) during this
conversion process.

The root cause was in the tied weight handling logic within
`load_tf2_state_dict_in_pytorch_model` in `modeling_tf_pytorch_utils.py`.
Multiple distinct parameters initialized as meta tensors can share the same
`data_ptr() == 0`. The existing logic incorrectly identified these as tied
weights and reused the tensor loaded for the first parameter encountered
with `data_ptr() == 0` (often the word embeddings) for subsequent parameters
that also had `data_ptr() == 0`.

This fix modifies the tied weight check to explicitly skip cases where
`pt_weight.data_ptr() == 0`, preventing the incorrect reuse of tensors
for distinct meta parameters and resolving the size mismatch error.

Includes a unit test in `test_modeling_utils.py` to specifically verify
this scenario using `from_pretrained(..., from_tf=True)` with meta initialization.

Fixes #37786


## Who can review?

@Rocketknight1 @gante 


Changed files:
filename: src/transformers/modeling_tf_pytorch_utils.py
patch: @@ -585,8 +585,8 @@ def load_tf2_state_dict_in_pytorch_model(pt_model, tf_state_dict, allow_missing_
     loaded_pt_weights_data_ptr = {}
     missing_keys_pt = []
     for pt_weight_name, pt_weight in current_pt_params_dict.items():
-        # Handle PyTorch shared weight ()not duplicated in TF 2.0
-        if pt_weight.data_ptr() in loaded_pt_weights_data_ptr:
+        # Handle PyTorch shared weight not duplicated in TF 2.0
+        if pt_weight.data_ptr() in loaded_pt_weights_data_ptr and pt_weight.data_ptr() != 0:
             new_pt_params_dict[pt_weight_name] = loaded_pt_weights_data_ptr[pt_weight.data_ptr()]
             continue
 

filename: tests/utils/test_modeling_utils.py
patch: @@ -1571,6 +1571,14 @@ def test_safetensors_torch_from_tf(self):
         for p1, p2 in zip(hub_model.parameters(), new_model.parameters()):
             self.assertTrue(torch.equal(p1, p2))
 
+    @require_tf
+    def test_torch_from_tf(self):
+        model = TFBertModel.from_pretrained("hf-internal-testing/tiny-bert-tf-only")
+
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            model.save_pretrained(tmp_dir)
+            _ = BertModel.from_pretrained(tmp_dir, from_tf=True)
+
     @require_safetensors
     def test_safetensors_torch_from_torch_sharded(self):
         model = BertModel.from_pretrained("hf-internal-testing/tiny-bert-pt-only")
Repository: denoland/deno
Pull request: fix: don't include extensionless files in file collection for lint & fmt by default

Fixes #25717

When using the `ext` flag, it will still attempt formatting them with the provided extension

Changed files:
filename: cli/tools/fmt.rs
patch: @@ -221,10 +221,8 @@ fn collect_fmt_files(
   files: FilePatterns,
 ) -> Result<Vec<PathBuf>, AnyError> {
   FileCollector::new(|e| {
-    cli_options.ext_flag().as_ref().is_some_and(|ext| {
-      is_supported_ext_fmt(Path::new(&format!("placeholder.{ext}")))
-    }) || is_supported_ext_fmt(e.path)
-      || e.path.extension().is_none()
+    is_supported_ext_fmt(e.path)
+      || (e.path.extension().is_none() && cli_options.ext_flag().is_some())
   })
   .ignore_git_folder()
   .ignore_node_modules()

filename: cli/tools/lint/mod.rs
patch: @@ -430,10 +430,8 @@ fn collect_lint_files(
   files: FilePatterns,
 ) -> Result<Vec<PathBuf>, AnyError> {
   FileCollector::new(|e| {
-    cli_options.ext_flag().as_ref().is_some_and(|ext| {
-      is_script_ext(Path::new(&format!("placeholder.{ext}")))
-    }) || is_script_ext(e.path)
-      || e.path.extension().is_none()
+    is_script_ext(e.path)
+      || (e.path.extension().is_none() && cli_options.ext_flag().is_some())
   })
   .ignore_git_folder()
   .ignore_node_modules()

filename: tests/specs/fmt/default_ts/__test__.jsonc
patch: @@ -12,6 +12,11 @@
     },
     "extensionless": {
       "args": "fmt extensionless",
+      "output": "error: No target files found.\n",
+      "exitCode": 1
+    },
+    "extensionless_with_flag": {
+      "args": "fmt --ext=ts extensionless",
       "output": "Checked 1 file\n"
     }
   }

filename: tests/specs/lint/default_ts/__test__.jsonc
patch: @@ -12,6 +12,11 @@
     },
     "extensionless": {
       "args": "lint extensionless",
+      "output": "error: No target files found.\n",
+      "exitCode": 1
+    },
+    "extensionless_with_flag": {
+      "args": "lint --ext=ts extensionless",
       "output": "Checked 1 file\n"
     }
   }
Repository: vercel/next.js
Pull request: perf(turbopack): Drop AST node before generating source maps

### What?

Source map generation uses lots of memory, so drop another memory hog before performing it.

For `minify()`, we were already doing it, although it seems unintentional.

### Why?

x-ref: Numbers in https://vercel.slack.com/archives/C06PPGZ0FD3/p1747245989125859?thread_ts=1746834549.272939&cid=C06PPGZ0FD3

Closes PACK-4614

Changed files:
filename: turbopack/crates/turbopack-ecmascript/src/lib.rs
patch: @@ -1123,6 +1123,8 @@ async fn emit_content(content: CodeGenResult) -> Result<Vc<EcmascriptModuleConte
         };
 
         emitter.emit_program(&program)?;
+        // Drop the AST eagerly so we don't keep it in memory while generating source maps
+        drop(program);
     }
 
     let source_map = if generate_source_map {
Repository: ggml-org/llama.cpp
Pull request: Note about necessity of having libcurl installed for standard build

Since https://github.com/ggml-org/llama.cpp/commit/bd3f59f81289b920bcc597a208c14f55e39ed37e the basic build requires installation of curl development files, for example from the `libcurl4-openssl-dev` package for Ubuntu.

This PR simply adds note of the change in behavior and how can you revert to the previous state of affairs. 

Changed files:
filename: docs/build.md
patch: @@ -63,6 +63,7 @@ cmake --build build --config Release
       cmake --preset x64-windows-llvm-release
       cmake --build build-x64-windows-llvm-release
       ```
+- Curl usage is enabled by default and can be turned off with `-DLLAMA_CURL=OFF`. Otherwise you need to install development libraries for libcurl.
 
 ## BLAS Build
Repository: facebook/react
Pull request: [DevTools] Add events necessary for click to inspect on RN

We want to enable the inspector toggle on devtools and allow click to inspect on RN. 
The changes here are necessary to enable the toggle and pass events to RN.

The change is tested locally on RN. Verified events are received on RN and toggle is shown.

Changed files:
filename: packages/react-devtools-core/src/standalone.js
patch: @@ -256,7 +256,7 @@ function initialize(socket: WebSocket) {
 
   store = new Store(bridge, {
     checkBridgeProtocolCompatibility: true,
-    supportsNativeInspection: false,
+    supportsNativeInspection: true,
   });
 
   log('Connected');

filename: packages/react-devtools-shared/src/backend/agent.js
patch: @@ -144,6 +144,8 @@ type PersistedSelection = {|
 export default class Agent extends EventEmitter<{|
   hideNativeHighlight: [],
   showNativeHighlight: [NativeType],
+  startInspectingNative: [],
+  stopInspectingNative: [],
   shutdown: [],
   traceUpdates: [Set<NativeType>],
 |}> {
@@ -655,6 +657,10 @@ export default class Agent extends EventEmitter<{|
     this._bridge.send('profilingStatus', this._isProfiling);
   };
 
+  stopInspectingNative = (selected: boolean) => {
+    this._bridge.send('stopInspectingNative', selected);
+  };
+
   storeAsGlobal = ({count, id, path, rendererID}: StoreAsGlobalParams) => {
     const renderer = this._rendererInterfaces[rendererID];
     if (renderer == null) {

filename: packages/react-devtools-shared/src/backend/views/Highlighter/index.js
patch: @@ -48,6 +48,8 @@ export default function setupHighlighter(
       window.addEventListener('pointerdown', onPointerDown, true);
       window.addEventListener('pointerover', onPointerOver, true);
       window.addEventListener('pointerup', onPointerUp, true);
+    } else {
+      agent.emit('startInspectingNative');
     }
   }
 
@@ -74,6 +76,8 @@ export default function setupHighlighter(
       window.removeEventListener('pointerdown', onPointerDown, true);
       window.removeEventListener('pointerover', onPointerOver, true);
       window.removeEventListener('pointerup', onPointerUp, true);
+    } else {
+      agent.emit('stopInspectingNative');
     }
   }
Repository: ggml-org/llama.cpp
Pull request: opencl: add `backend_synchronize`

This PR adds `backend_synchronize`. This is not needed by the normal use where the result is read using `tensor_get`, which already contains synchronization, but it allows perf mode of `test-backend-ops` to properly measure performance.


Changed files:
filename: ggml/src/ggml-opencl/ggml-opencl.cpp
patch: @@ -2022,7 +2022,12 @@ static bool ggml_backend_opencl_cpy_tensor_async(ggml_backend_t backend, const g
 }
 
 static void ggml_backend_opencl_synchronize(ggml_backend_t backend) {
-    GGML_UNUSED(backend);
+    auto * backend_ctx = static_cast<ggml_backend_opencl_context *>(backend->context);
+
+    cl_event evt;
+    CL_CHECK(clEnqueueBarrierWithWaitList(backend_ctx->queue, 0, nullptr, &evt));
+    CL_CHECK(clWaitForEvents(1, &evt));
+    CL_CHECK(clReleaseEvent(evt));
 }
 
 // Syncronizes the 'backend_ctx's device with others so that commands
@@ -2225,7 +2230,7 @@ static ggml_backend_i ggml_backend_opencl_i = {
     /* .set_tensor_async        = */ NULL,  /* ggml_backend_opencl_set_tensor_async */
     /* .get_tensor_async        = */ NULL,  /* ggml_backend_opencl_get_tensor_async */
     /* .cpy_tensor_async        = */ NULL,  /* ggml_backend_opencl_cpy_tensor_async */
-    /* .synchronize             = */ NULL,  /* ggml_backend_opencl_synchronize */
+    /* .synchronize             = */ ggml_backend_opencl_synchronize,
     /* .graph_plan_create       = */ NULL,
     /* .graph_plan_free         = */ NULL,
     /* .graph_plan_update       = */ NULL,