helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: build: add double quotes around <(python)

Handle cases where the path to the Python executable contains spaces.

Refs: https://github.com/nodejs/node/pull/56791

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: node.gyp
patch: @@ -402,8 +402,8 @@
     ],
     'node_cctest_sources': [
       'src/node_snapshot_stub.cc',
-      '<!@(<(python) tools/search_files.py . test/cctest cc)',
-      '<!@(<(python) tools/search_files.py . test/cctest h)',
+      '<!@("<(python)" tools/search_files.py . test/cctest cc)',
+      '<!@("<(python)" tools/search_files.py . test/cctest h)',
     ],
     'node_cctest_openssl_sources': [
       'test/cctest/test_crypto_clienthello.cc',
Repository: huggingface/transformers
Pull request: Hotfix: Flash Attention 2 support in Pixtral

## Context

Pixtral support for `ALL_ATTENTION_FUNCTIONS` was added in [this PR](https://github.com/huggingface/transformers/pull/37960), but a subsequent [rebase](https://github.com/huggingface/transformers/pull/37576) unintentionally modified a line that sets `attention_mask` to `None` when using Flash Attention 2. 

Currently, without this condition, using Flash Attention 2 with Pixtral raises the following error:

`RuntimeError: cu_seqlens_q must have shape (batch_size + 1)`

Setting `attention_mask` to `None` resolves the issue. It also appears that the current tests doesn’t catch this case.

cc: @zucchini-nlp, @ArthurZucker


Changed files:
filename: src/transformers/models/pixtral/modeling_pixtral.py
patch: @@ -211,6 +211,11 @@ def forward(
             else:
                 attention_interface = ALL_ATTENTION_FUNCTIONS[self.config._attn_implementation]
 
+        # Since we use packing, if flash_attention_2 is selected we rely on position_ids
+        if self.config._attn_implementation == "flash_attention_2":
+            kwargs["position_ids"] = kwargs["position_ids"].to(hidden_states.device, non_blocking=True)
+            attention_mask = None
+
         attn_output, attn_weights = attention_interface(
             self,
             query_states,
Repository: ggml-org/llama.cpp
Pull request: convert : fix duplicate key DeepSeek-R1 conversion error

Since DeepSeekV3 support was merged into `transformers` `AutoConfig` started returning an incorrect `head_dim` value.

Fixes #14093

Changed files:
filename: convert_hf_to_gguf.py
patch: @@ -556,8 +556,11 @@ def set_gguf_parameters(self):
             logger.info(f"gguf: experts used count = {n_experts_used}")
 
         if (head_dim := self.hparams.get("head_dim")) is not None:
-            self.gguf_writer.add_key_length(head_dim)
-            self.gguf_writer.add_value_length(head_dim)
+            # Workaround for incorrect AutoConfig value for DeepSeekV3 (is set correctly in DeepSeekV2Model class)
+            # https://github.com/huggingface/transformers/blob/19224c3642705c5b6988c9f5f4251f83323d05ae/src/transformers/models/deepseek_v3/configuration_deepseek_v3.py#L210
+            if self.hparams.get("model_type") != "deepseek_v3":
+                self.gguf_writer.add_key_length(head_dim)
+                self.gguf_writer.add_value_length(head_dim)
 
         self.gguf_writer.add_file_type(self.ftype)
         logger.info(f"gguf: file type = {self.ftype}")
Repository: denoland/deno
Pull request: ci: use macos-14-xlarge on 'main' branch

We only do `release` build for Mac ARM on `main` branch. It now takes more than 2.5h and sometimes
it even times out after 3h.

Gonna try to use `macos-14-xlarge` runner for a day to evaluate the spending.
https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#per-minute-rates-for-arm64-powered-larger-runners

Changed files:
filename: .github/workflows/ci.generate.ts
patch: @@ -14,6 +14,7 @@ const windowsX86Runner = "windows-2022";
 const windowsX86XlRunner = "windows-2022-xl";
 const macosX86Runner = "macos-13";
 const macosArmRunner = "macos-14";
+const macosArmXlRunner = "macos-14-xlarge";
 
 const Runners = {
   linuxX86: {
@@ -42,6 +43,12 @@ const Runners = {
     arch: "aarch64",
     runner: macosArmRunner,
   },
+  macosArmXl: {
+    os: "macos",
+    arch: "aarch64",
+    runner:
+      `\${{ github.repository == 'denoland/deno' && '${macosArmXlRunner}' || '${macosArmRunner}' }}`,
+  },
   windowsX86: {
     os: "windows",
     arch: "x86_64",
@@ -378,7 +385,7 @@ const ci = {
             job: "test",
             profile: "debug",
           }, {
-            ...Runners.macosArm,
+            ...Runners.macosArmXl,
             job: "test",
             profile: "release",
             skip_pr: true,

filename: .github/workflows/ci.yml
patch: @@ -73,7 +73,7 @@ jobs:
             profile: debug
           - os: macos
             arch: aarch64
-            runner: '${{ (!contains(github.event.pull_request.labels.*.name, ''ci-full'') && (github.event_name == ''pull_request'')) && ''ubuntu-22.04'' || ''macos-14'' }}'
+            runner: '${{ (!contains(github.event.pull_request.labels.*.name, ''ci-full'') && (github.event_name == ''pull_request'')) && ''ubuntu-22.04'' || github.repository == ''denoland/deno'' && ''macos-14-xlarge'' || ''macos-14'' }}'
             job: test
             profile: release
             skip: '${{ !contains(github.event.pull_request.labels.*.name, ''ci-full'') && (github.event_name == ''pull_request'') }}'
Repository: denoland/deno
Pull request: feat: Don't warn about --allow-script when using esbuild

`esbuild` can work fine without needing to run post-install script, so to make it easier
on users (especially people using Vite) we are not prompting to run with `--allow-scripts` again.
We only do that for version >= 0.18.0 to be sure.

Changed files:
filename: cli/npm/managed/resolvers/common/lifecycle_scripts.rs
patch: @@ -4,6 +4,7 @@ use super::bin_entries::BinEntries;
 use crate::args::LifecycleScriptsConfig;
 use deno_npm::resolution::NpmResolutionSnapshot;
 use deno_semver::package::PackageNv;
+use deno_semver::Version;
 use std::borrow::Cow;
 use std::rc::Rc;
 
@@ -113,6 +114,17 @@ impl<'a> LifecycleScripts<'a> {
       } else if !self.strategy.has_run(package)
         && (self.config.explicit_install || !self.strategy.has_warned(package))
       {
+        // Skip adding `esbuild` as it is known that it can work properly without lifecycle script
+        // being run, and it's also very popular - any project using Vite would raise warnings.
+        {
+          let nv = &package.id.nv;
+          if nv.name == "esbuild"
+            && nv.version >= Version::parse_standard("0.18.0").unwrap()
+          {
+            return;
+          }
+        }
+
         self
           .packages_with_scripts_not_run
           .push((package, package_path.into_owned()));
Repository: huggingface/transformers
Pull request: [Qwen3] Qwen3 MoE add tp plan for expert mlps

# What does this PR do?
Qwen3 MoE config: add tp plan for expert mlps

tested via vllm

@ArthurZucker


Changed files:
filename: src/transformers/models/qwen3_moe/configuration_qwen3_moe.py
patch: @@ -155,6 +155,9 @@ class Qwen3MoeConfig(PretrainedConfig):
         "layers.*.self_attn.k_proj": "colwise",
         "layers.*.self_attn.v_proj": "colwise",
         "layers.*.self_attn.o_proj": "rowwise",
+        "layers.*.mlp.experts.*.gate_proj": "colwise",
+        "layers.*.mlp.experts.*.up_proj": "colwise",
+        "layers.*.mlp.experts.*.down_proj": "rowwise",
         "layers.*.mlp.gate_proj": "colwise",
         "layers.*.mlp.up_proj": "colwise",
         "layers.*.mlp.down_proj": "rowwise",
Repository: ggml-org/llama.cpp
Pull request: Vulkan: Don't default to CPU device (like llvmpipe)

This should fix https://github.com/containers/ramalama/issues/1479

llvmpipe can still be used by setting `GGML_VK_VISIBLE_DEVICES` to override automatic device selection. This may be required now to allow the Github CI test-backend-ops to run for Vulkan.

Changed files:
filename: ggml/src/ggml-vulkan/ggml-vulkan.cpp
patch: @@ -3595,11 +3595,11 @@ static void ggml_vk_instance_init() {
 
     vk_perf_logger_enabled = getenv("GGML_VK_PERF_LOGGER") != nullptr;
 
-    size_t num_available_devices = vk_instance.instance.enumeratePhysicalDevices().size();
-
     // Emulate behavior of CUDA_VISIBLE_DEVICES for Vulkan
     char * devices_env = getenv("GGML_VK_VISIBLE_DEVICES");
     if (devices_env != nullptr) {
+        size_t num_available_devices = vk_instance.instance.enumeratePhysicalDevices().size();
+
         std::string devices(devices_env);
         std::replace(devices.begin(), devices.end(), ',', ' ');
 
@@ -3615,9 +3615,9 @@ static void ggml_vk_instance_init() {
     } else {
         std::vector<vk::PhysicalDevice> devices = vk_instance.instance.enumeratePhysicalDevices();
 
-        // Make sure at least one device exists
+        // If no vulkan devices are found, return early
         if (devices.empty()) {
-            std::cerr << "ggml_vulkan: Error: No devices found." << std::endl;
+            GGML_LOG_INFO("ggml_vulkan: No devices found.\n");
             return;
         }
 
@@ -3700,9 +3700,20 @@ static void ggml_vk_instance_init() {
             }
         }
 
-        // If no dedicated GPUs found, fall back to GPU 0
+        // If no dedicated GPUs found, fall back to the first non-CPU device.
+        // If only CPU devices are available, return without devices.
+        if (vk_instance.device_indices.empty()) {
+            for (size_t i = 0; i < devices.size(); i++) {
+                if (devices[i].getProperties().deviceType != vk::PhysicalDeviceType::eCpu) {
+                    vk_instance.device_indices.push_back(i);
+                    break;
+                }
+            }
+        }
+
         if (vk_instance.device_indices.empty()) {
-            vk_instance.device_indices.push_back(0);
+            GGML_LOG_INFO("ggml_vulkan: No devices found.\n");
+            return;
         }
     }
     GGML_LOG_DEBUG("ggml_vulkan: Found %zu Vulkan devices:\n", vk_instance.device_indices.size());
Repository: facebook/react
Pull request: Flow: enable exact_by_default

With this change, a simple object type `{ }` means an exact object `{| |}` which most people assume. Opting for inexact requires the extra `{ a: number, ... }` syntax at the end.

A followup, someone could replace all the `{| |}` with `{ }`.


Changed files:
filename: scripts/flow/config/flowconfig
patch: @@ -37,18 +37,17 @@
 
 [lints]
 untyped-type-import=error
-implicit-inexact-object=error
 
 [options]
 server.max_workers=4
 esproposal.class_static_fields=enable
 esproposal.class_instance_fields=enable
 esproposal.optional_chaining=enable
+exact_by_default=true
+munge_underscores=false
 
 # Substituted by createFlowConfig.js:
 %REACT_RENDERER_FLOW_OPTIONS%
 
-munge_underscores=false
-
 [version]
 ^0.122.0
Repository: nodejs/node
Pull request: http: be more generational GC friendly

Avoid any potential ref to Buffer in new generation from old generation. Otherwise, the lightweight Minor GC could not collect Buffer, as a result, the heavy Major GC may be invoked more frequently

Similar tricks are used in Writable and Readable

https://github.com/nodejs/node/blob/ce6a62872081d720734d82bf975653a322795288/lib/internal/streams/writable.js#L779

https://github.com/nodejs/node/blob/ce6a62872081d720734d82bf975653a322795288/lib/internal/streams/readable.js#L1598

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: lib/_http_outgoing.js
patch: @@ -1218,6 +1218,8 @@ OutgoingMessage.prototype._flushOutput = function _flushOutput(socket) {
   // Refs: https://github.com/nodejs/node/pull/30958
   for (let i = 0; i < outputLength; i++) {
     const { data, encoding, callback } = outputData[i];
+    // Avoid any potential ref to Buffer in new generation from old generation
+    outputData[i].data = null;
     ret = socket.write(data, encoding, callback);
   }
   socket.uncork();
Repository: ggml-org/llama.cpp
Pull request: vulkan: force device 0 in CI


Changed files:
filename: .github/workflows/build.yml
patch: @@ -306,6 +306,7 @@ jobs:
         id: cmake_test
         run: |
           cd build
+          export GGML_VK_VISIBLE_DEVICES=0
           # This is using llvmpipe and runs slower than other backends
           ctest -L main --verbose --timeout 3600
Repository: ggml-org/llama.cpp
Pull request: sync : ggml


Changed files:
filename: scripts/sync-ggml.last
patch: @@ -1 +1 @@
-a1761cd64ce4a75a9770a954a013422c7910db8b
+6a7d170c04789f6ebcf320ed03c1b16973f93bd7
Repository: denoland/deno
Pull request: v2.0.0-rc.6


Changed files:
filename: Cargo.lock
patch: @@ -1146,7 +1146,7 @@ dependencies = [
 
 [[package]]
 name = "deno"
-version = "2.0.0-rc.5"
+version = "2.0.0-rc.6"
 dependencies = [
  "anstream",
  "async-trait",

filename: cli/Cargo.toml
patch: @@ -2,7 +2,7 @@
 
 [package]
 name = "deno"
-version = "2.0.0-rc.5"
+version = "2.0.0-rc.6"
 authors.workspace = true
 default-run = "deno"
 edition.workspace = true
Repository: facebook/react
Pull request: Flow: upgrade to 0.131

The one small change here is a new Flow lint rule about adding numbers and potentially undefined values.

I disabled the lint to avoid new suppressions. We can enable the lint separately.

Changed files:
filename: package.json
patch: @@ -63,7 +63,7 @@
     "eslint-plugin-react-internal": "link:./scripts/eslint-rules",
     "fbjs-scripts": "1.2.0",
     "filesize": "^6.0.1",
-    "flow-bin": "^0.127",
+    "flow-bin": "^0.131",
     "glob": "^7.1.6",
     "glob-stream": "^6.1.0",
     "google-closure-compiler": "^20200517.0.0",

filename: scripts/flow/config/flowconfig
patch: @@ -38,6 +38,10 @@
 [lints]
 untyped-type-import=error
 
+# TODO: We might want to enable this this as a error (the default), it
+#       disallows adding undefined and numbers.
+unsafe-addition=off
+
 [options]
 server.max_workers=4
 esproposal.class_static_fields=enable
@@ -50,4 +54,4 @@ munge_underscores=false
 %REACT_RENDERER_FLOW_OPTIONS%
 
 [version]
-^0.127.0
+^0.131.0

filename: yarn.lock
patch: @@ -6901,6 +6901,7 @@ eslint-plugin-no-unsanitized@3.1.2:
 
 "eslint-plugin-react-internal@link:./scripts/eslint-rules":
   version "0.0.0"
+  uid ""
 
 eslint-plugin-react@^6.7.1:
   version "6.10.3"
@@ -7913,10 +7914,10 @@ flatted@^2.0.0:
   resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138"
   integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==
 
-flow-bin@^0.127:
-  version "0.127.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.127.0.tgz#0614cff4c1b783beef1feeb7108d536e09d77632"
-  integrity sha512-ywvCCdV4NJWzrqjFrMU5tAiVGyBiXjsJQ1+/kj8thXyX15V17x8BFvNwoAH97NrUU8T1HzmFBjLzWc0l2319qg==
+flow-bin@^0.131:
+  version "0.131.0"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.131.0.tgz#d4228b6070afdf3b2a76acdee77a7f3f8e8f5133"
+  integrity sha512-fZmoIBcDrtLhy/NNMxwJysSYzMr1ksRcAOMi3AHSoYXfcuQqTvhGJx+wqjlIOqIwz8RRYm8J4V4JrSJbIKP+Xg==
 
 fluent-syntax@0.13.0:
   version "0.13.0"
Repository: electron/electron
Pull request: perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (32-x-y)

Manually backport #44067 to 32-x-y. See that PR for details.

Simple manual patching needed due to context shear from the `base::StringPiece` -> `std::string_view` migration.

Notes: none.

Changed files:
filename: shell/common/api/electron_api_native_image.cc
patch: @@ -255,9 +255,7 @@ v8::Local<v8::Value> NativeImage::ToBitmap(gin::Arguments* args) {
 
   auto array_buffer =
       v8::ArrayBuffer::New(args->isolate(), info.computeMinByteSize());
-  auto backing_store = array_buffer->GetBackingStore();
-  if (bitmap.readPixels(info, backing_store->Data(), info.minRowBytes(), 0,
-                        0)) {
+  if (bitmap.readPixels(info, array_buffer->Data(), info.minRowBytes(), 0, 0)) {
     return node::Buffer::New(args->isolate(), array_buffer, 0,
                              info.computeMinByteSize())
         .ToLocalChecked();

filename: shell/common/api/electron_api_url_loader.cc
patch: @@ -710,8 +710,7 @@ void SimpleURLLoaderWrapper::OnDataReceived(std::string_view string_piece,
   v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
   v8::HandleScope handle_scope(isolate);
   auto array_buffer = v8::ArrayBuffer::New(isolate, string_piece.size());
-  auto backing_store = array_buffer->GetBackingStore();
-  memcpy(backing_store->Data(), string_piece.data(), string_piece.size());
+  memcpy(array_buffer->Data(), string_piece.data(), string_piece.size());
   Emit("data", array_buffer,
        base::AdaptCallbackForRepeating(std::move(resume)));
 }
Repository: facebook/react
Pull request: Flow: upgrade to 0.127

Stacked on #25220, this updates Flow some more releases with only a minor suppression.

Changed files:
filename: package.json
patch: @@ -63,7 +63,7 @@
     "eslint-plugin-react-internal": "link:./scripts/eslint-rules",
     "fbjs-scripts": "1.2.0",
     "filesize": "^6.0.1",
-    "flow-bin": "^0.122",
+    "flow-bin": "^0.127",
     "glob": "^7.1.6",
     "glob-stream": "^6.1.0",
     "google-closure-compiler": "^20200517.0.0",

filename: packages/react-native-renderer/src/ReactFabric.js
patch: @@ -97,6 +97,7 @@ function findHostInstance_DEPRECATED<TElementType: ElementType>(
     return (hostInstance: any).canonical;
   }
   // $FlowFixMe[incompatible-return]
+  // $FlowFixMe[incompatible-exact]
   return hostInstance;
 }
 

filename: packages/react-native-renderer/src/ReactNativeRenderer.js
patch: @@ -96,6 +96,7 @@ function findHostInstance_DEPRECATED(
     return (hostInstance: any).canonical;
   }
   // $FlowFixMe[incompatible-return]
+  // $FlowFixMe[incompatible-exact]
   return hostInstance;
 }
 

filename: scripts/flow/config/flowconfig
patch: @@ -50,4 +50,4 @@ munge_underscores=false
 %REACT_RENDERER_FLOW_OPTIONS%
 
 [version]
-^0.122.0
+^0.127.0

filename: yarn.lock
patch: @@ -7913,10 +7913,10 @@ flatted@^2.0.0:
   resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138"
   integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==
 
-flow-bin@^0.122:
-  version "0.122.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.122.0.tgz#c723a2b33b1a70bd10204704ae1dc776d5d89d79"
-  integrity sha512-my8N5jgl/A+UVby9E7NDppHdhLgRbWgKbmFZSx2MSYMRh3d9YGnM2MM+wexpUpl0ftY1IM6ZcUwaAhrypLyvlA==
+flow-bin@^0.127:
+  version "0.127.0"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.127.0.tgz#0614cff4c1b783beef1feeb7108d536e09d77632"
+  integrity sha512-ywvCCdV4NJWzrqjFrMU5tAiVGyBiXjsJQ1+/kj8thXyX15V17x8BFvNwoAH97NrUU8T1HzmFBjLzWc0l2319qg==
 
 fluent-syntax@0.13.0:
   version "0.13.0"