helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: build: update linux container

Backport of #44392

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: .github/workflows/build.yml
patch: @@ -6,7 +6,7 @@ on:
       build-image-sha:
         type: string
         description: 'SHA for electron/build image'
-        default: 'cf814a4d2501e8e843caea071a6b70a48e78b855'
+        default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
         required: true
       skip-macos:
         type: boolean
@@ -53,7 +53,7 @@ jobs:
       id: set-output
       run: |
         if [ -z "${{ inputs.build-image-sha }}" ]; then
-          echo "build-image-sha=77262e58c37631ab082482f42c33cdf68c6c394b" >> "$GITHUB_OUTPUT"
+          echo "build-image-sha=bc2f48b2415a670de18d13605b1cf0eb5fdbaae1" >> "$GITHUB_OUTPUT"
         else
           echo "build-image-sha=${{ inputs.build-image-sha }}" >> "$GITHUB_OUTPUT"
         fi

filename: .github/workflows/linux-publish.yml
patch: @@ -6,7 +6,7 @@ on:
       build-image-sha:
         type: string
         description: 'SHA for electron/build image'
-        default: 'cf814a4d2501e8e843caea071a6b70a48e78b855'
+        default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
       upload-to-storage:
         description: 'Uploads to Azure storage'
         required: false

filename: .github/workflows/macos-publish.yml
patch: @@ -6,7 +6,7 @@ on:
       build-image-sha:
         type: string
         description: 'SHA for electron/build image'
-        default: 'cf814a4d2501e8e843caea071a6b70a48e78b855'
+        default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
         required: true
       upload-to-storage:
         description: 'Uploads to Azure storage'
Repository: vercel/next.js
Pull request: Run `tsc` in watch mode during `pnpm dev`

Now that `tsc` can be run repeatedly without erroring, we can run it in watch mode during `pnpm dev` to ensure that type errors are always up-to-date while developing. Previously, we had to restart `pnpm dev`, like animals.

Changed files:
filename: packages/next/taskfile.js
patch: @@ -2835,9 +2835,11 @@ export async function build(task, opts) {
 }
 
 export async function generate_types(task, opts) {
-  await execa.command('pnpm run types', {
-    stdio: 'inherit',
-  })
+  await execa(
+    'pnpm',
+    ['run', 'types', ...(opts.dev ? ['--watch', '--preserveWatchOutput'] : [])],
+    { stdio: 'inherit' }
+  )
 }
 
 export async function check_error_codes(task, opts) {
Repository: facebook/react
Pull request: Remove canonical check in fiber host component

I believe this is a dead branch.

I added this code in https://github.com/facebook/react/pull/15126 and I *think* it has always been wrong. At least, I'm not sure what could trigger it.

I think I was pattern matching from this code in NativeMethodsMixin  https://github.com/facebook/react/blob/master/packages/react-native-renderer/src/NativeMethodsMixin.js#L166-L182

Simplified: 
```
const maybeInstance = findHostInstance(this);
if (maybeInstance == null) {
  return;
}

if (maybeInstance.canonical) {
```

The only thing in the codebase that creates an object with a canonical key is [createInstance in ReactFabricHostConfig](https://github.com/facebook/react/blob/master/packages/react-native-renderer/src/ReactFabricHostConfig.js#L238-L241). `canonical` is only set on Fabric host components, not paper ones.

In order to get that instance, you must call `findHostInstance`. NativeMethodsMixin and ReactNativeComponent both use `findHostInstance` in order to detect whether an instance is created with the paper renderer or the fabric renderer to know which API to call. 

FiberHostComponent only needs to deal with paper components and the FabricHostComponent only needs to deal with the fabric components, so this check for canonical in paper is unnecessary.

When I wrote this code I also added tests for calling this function passing an argument created with all three `NativeMethodsMixin`, `ReactNativeComponent`, and a host component. If I add a `throw` to this if statement, none of the tests fail.


Changed files:
filename: packages/react-native-renderer/src/ReactNativeFiberHostComponent.js
patch: @@ -83,15 +83,6 @@ class ReactNativeFiberHostComponent {
       relativeNode = relativeToNativeNode;
     } else if (relativeToNativeNode._nativeTag) {
       relativeNode = relativeToNativeNode._nativeTag;
-    } else if (
-      /* $FlowFixMe canonical doesn't exist on the node.
-       I think this branch is dead and will remove it in a followup */
-      relativeToNativeNode.canonical &&
-      relativeToNativeNode.canonical._nativeTag
-    ) {
-      /* $FlowFixMe canonical doesn't exist on the node.
-       I think this branch is dead and will remove it in a followup */
-      relativeNode = relativeToNativeNode.canonical._nativeTag;
     }
 
     if (relativeNode == null) {
Repository: vercel/next.js
Pull request: Update script location used in `pnpm unpack-next`

Fixes "pack-next" + "unpack-next" workflows and updates docs.

Follow-up to https://github.com/vercel/next.js/pull/77538 and https://github.com/vercel/next.js/issues/77536

Changed files:
filename: contributing/core/developing.md
patch: @@ -56,13 +56,13 @@ see **[Developing Using Your Local Version of Next.js](./developing-using-local-
 Since Turbopack doesn't support symlinks when pointing outside of the workspace directory, it can be difficult to develop against a local Next.js version. Neither `pnpm link` nor `file:` imports quite cut it. An alternative is to pack the Next.js version you want to test into a tarball and add it to the pnpm overrides of your test application. The following script will do it for you:
 
 ```bash
-pnpm pack-next --release && pnpm unpack-next path/to/project
+pnpm pack-next --tar && pnpm unpack-next path/to/project
 ```
 
 Or without running the build:
 
 ```bash
-pnpm pack-next --no-build --release && pnpm unpack-next path/to/project
+pnpm pack-next --no-js-build --tar && pnpm unpack-next path/to/project
 ```
 
 Without going through a tarball (only works if you've added the overrides from `pack-next`):
@@ -74,21 +74,19 @@ pnpm patch-next path/to/project
 Supports the same arguments:
 
 ```bash
-pnpm patch-next --no-build --release path/to/project
+pnpm patch-next --no-js-build path/to/project
 ```
 
 ### Explanation of the scripts
 
 ```bash
 # Generate a tarball of the Next.js version you want to test
-$ pnpm pack-next
+$ pnpm pack-next --tar
 
-# If you need to build in release mode:
-$ pnpm pack-next --release
 # You can also pass any cargo argument to the script
 
 # To skip the `pnpm i` and `pnpm build` steps in next.js (e. g. if you are running `pnpm dev`)
-$ pnpm pack-next --no-build
+$ pnpm pack-next --no-js-build
 ```
 
 Afterwards, you'll need to unpack the tarball into your test project. You can either manually edit the `package.json` to point to the new tarballs (see the stdout from `pack-next` script), or you can automatically unpack it with:

filename: package.json
patch: @@ -71,7 +71,7 @@
     "sync-react": "node ./scripts/sync-react.js",
     "update-google-fonts": "node ./scripts/update-google-fonts.js",
     "patch-next": "node scripts/patch-next.cjs",
-    "unpack-next": "tsx scripts/unpack-next.cjs",
+    "unpack-next": "tsx scripts/unpack-next.ts",
     "swc-build-native": "tsx scripts/build-native.ts",
     "swc-build-wasm": "tsx scripts/build-wasm.cjs",
     "build-turbopack-cli": "cargo build -p turbopack-cli --release",
Repository: facebook/react
Pull request: Revert "Clear memoizedState on unmount of fiber to avoid memory leak"

Reverts facebook/react#14218

Changed files:
filename: packages/react-reconciler/src/ReactFiberCommitWork.js
patch: @@ -726,20 +726,11 @@ function detachFiber(current: Fiber) {
   // get GC:ed but we don't know which for sure which parent is the current
   // one so we'll settle for GC:ing the subtree of this child. This child
   // itself will be GC:ed when the parent updates the next time.
-  // We do not null out the 'nextEffect' field as it causes tests to fail.
   current.return = null;
   current.child = null;
-  current.memoizedState = null;
-  current.updateQueue = null;
-  current.firstEffect = null;
-  current.lastEffect = null;
   if (current.alternate) {
-    current.alternate.return = null;
     current.alternate.child = null;
-    current.alternate.memoizedState = null;
-    current.alternate.updateQueue = null;
-    current.alternate.firstEffect = null;
-    current.alternate.lastEffect = null;
+    current.alternate.return = null;
   }
 }
Repository: ggml-org/llama.cpp
Pull request: ci : disable fast-math for Metal GHA CI

cont #14460

https://github.com/ggml-org/llama.cpp/pull/14460#issuecomment-3023280339

Changed files:
filename: .github/workflows/build.yml
patch: @@ -84,7 +84,8 @@ jobs:
             -DCMAKE_BUILD_RPATH="@loader_path" \
             -DLLAMA_FATAL_WARNINGS=ON \
             -DGGML_METAL_USE_BF16=ON \
-            -DGGML_METAL_EMBED_LIBRARY=ON \
+            -DGGML_METAL_EMBED_LIBRARY=OFF \
+            -DGGML_METAL_SHADER_DEBUG=ON \
             -DGGML_RPC=ON
           cmake --build build --config Release -j $(sysctl -n hw.logicalcpu)
 

filename: ggml/src/ggml-metal/CMakeLists.txt
patch: @@ -71,7 +71,9 @@ else()
         # note: adding -fno-inline fixes the tests when using MTL_SHADER_VALIDATION=1
         # note: unfortunately, we have to call it default.metallib instead of ggml.metallib
         #       ref: https://github.com/ggerganov/whisper.cpp/issues/1720
-        set(XC_FLAGS -fno-fast-math -fno-inline -g)
+        # note: adding -g causes segmentation fault during compile
+        #set(XC_FLAGS -fno-fast-math -fno-inline -g)
+        set(XC_FLAGS -fno-fast-math -fno-inline)
     else()
         set(XC_FLAGS -O3)
     endif()
@@ -90,7 +92,7 @@ else()
     add_custom_command(
         OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/default.metallib
         COMMAND xcrun -sdk macosx metal ${XC_FLAGS} -c ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.metal -o - |
-            xcrun -sdk macosx metallib - -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/default.metallib
+                xcrun -sdk macosx metallib        - -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/default.metallib
         COMMAND rm -f ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-common.h
         COMMAND rm -f ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.metal
         DEPENDS ggml-metal.metal ${METALLIB_COMMON}
Repository: facebook/react
Pull request: [DiffTrain] Tweak folder structure

Should hopefully be final tweaks! Sorry about all the noise.

Test plan: temporarily ran the workflow on this branch, verified output in the builds/facebook-www branch is correct: https://github.com/facebook/react/commit/bfc0eb6cd4d0a3cf9ae67f95b08d786356260cf6

Changed files:
filename: .github/workflows/commit_artifacts.yml
patch: @@ -39,7 +39,7 @@ jobs:
 
             let artifactsUrl = null;
             // This is a temporary, dirty hack to avoid needing a GitHub auth token in the circleci
-            // workflow to notify this GitHub action. Sorry.
+            // workflow to notify this GitHub action. Sorry!
             let iter = 0;
             spinloop: while (iter < 15) {
               const res = await github.rest.repos.listCommitStatusesForRef({
@@ -73,30 +73,33 @@ jobs:
             const data = await res.json();
             for (const artifact of data) {
               if (artifact.path === 'build.tgz') {
-                console.log(`Downloading and unzipping ${artifact.url}...`);
+                console.log(`Downloading and unzipping ${artifact.url}`);
                 await execHelper(
                   `curl -L ${artifact.url} | tar -xvz`
                 );
               }
             }
       - name: Move relevant files into compiled
         run: |
-          rm -rf ./compiled
-
           mkdir -p ./compiled
           mkdir -p ./compiled/facebook-www
           mkdir -p ./compiled/babel-plugin-react-refresh
 
-          mv build/facebook-www \
-            ./compiled/facebook-www
-          mv build/WARNINGS \
-            ./compiled/facebook-www/WARNINGS
-          mv build/COMMIT_SHA \
-            ./compiled/facebook-www/COMMIT_SHA
+          # Copy the facebook-www folder into compiled
+          mv build/facebook-www ./compiled
+
+          # Copy WARNINGS to facebook-www
+          mv build/WARNINGS ./compiled/facebook-www/WARNINGS
+
+          # Copy eslint-plugin-react-hooks into facebook-www
           mv build/oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
             ./compiled/facebook-www/eslint-plugin-react-hooks.js
+
+          # Copy unstable_server-external-runtime.js into facebook-www
           mv build/oss-stable/react-dom/unstable_server-external-runtime.js \
             ./compiled/facebook-www/unstable_server-external-runtime.js
+
+          # Copy react-refresh-babel.development.js into babel-plugin-react-refresh
           mv build/oss-stable/react-refresh/cjs/react-refresh-babel.development.js \
             ./compiled/babel-plugin-react-refresh/index.js
 
@@ -111,6 +114,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+        with:
+          ref: builds/facebook-www
+      - name: Ensure clean directory
+        run: rm -rf compiled
       - uses: actions/download-artifact@v3
         with:
           name: compiled
Repository: facebook/react
Pull request: [DiffTrain] Fix incorrect build path


Changed files:
filename: .github/workflows/commit_artifacts.yml
patch: @@ -103,8 +103,8 @@ jobs:
           ls -R ./compiled
       - uses: actions/upload-artifact@v3
         with:
-          name: facebook-www
-          path: facebook-www/
+          name: compiled
+          path: compiled/
 
   commit_artifacts:
     needs: download_artifacts
@@ -113,8 +113,8 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/download-artifact@v3
         with:
-          name: facebook-www
-          path: facebook-www/
+          name: compiled
+          path: compiled/
       - run: git status -u
       - name: Commit changes to branch
         uses: stefanzweifel/git-auto-commit-action@v4
Repository: facebook/react
Pull request: Reorganize build folders for DiffTrain

Reorganize some files to make the DiffTrain config easier to setup. Also add unstable_server-external-runtime to sync.

Changed files:
filename: .github/workflows/commit_artifacts.yml
patch: @@ -79,22 +79,28 @@ jobs:
                 );
               }
             }
-      - name: Move relevant files into facebook-www
+      - name: Move relevant files into compiled
         run: |
-          mkdir -p ./facebook-www
-          mkdir -p ./facebook-www/babel-plugin-react-refresh
+          rm -rf ./compiled
+
+          mkdir -p ./compiled
+          mkdir -p ./compiled/facebook-www
+          mkdir -p ./compiled/babel-plugin-react-refresh
 
           mv build/facebook-www \
-            ./facebook-www
+            ./compiled/facebook-www
           mv build/WARNINGS \
-            ./facebook-www/WARNINGS
+            ./compiled/facebook-www/WARNINGS
           mv build/COMMIT_SHA \
-            ./facebook-www/COMMIT_SHA
+            ./compiled/facebook-www/COMMIT_SHA
           mv build/oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
-            ./facebook-www/eslint-plugin-react-hooks.js
+            ./compiled/facebook-www/eslint-plugin-react-hooks.js
+          mv build/oss-stable/react-dom/unstable_server-external-runtime.js \
+            ./compiled/facebook-www/unstable_server-external-runtime.js
           mv build/oss-stable/react-refresh/cjs/react-refresh-babel.development.js \
-            ./facebook-www/babel-plugin-react-refresh/index.js
-          ls -R ./facebook-www
+            ./compiled/babel-plugin-react-refresh/index.js
+
+          ls -R ./compiled
       - uses: actions/upload-artifact@v3
         with:
           name: facebook-www
Repository: nodejs/node
Pull request: doc: update cleanup to trust on vuln db automation

Since https://github.com/nodejs-private/security-release/pull/56 this process has been automated.

Changed files:
filename: doc/contributing/security-release-process.md
patch: @@ -170,7 +170,7 @@ security announcements for more information.
       Then uncheck the Public Disclosure on HackerOne box at the bottom of the
       page.
       ![screenshot of HackerOne CVE form](https://github.com/nodejs/node/assets/26234614/e22e4f33-7948-4dd2-952e-2f9166f5568d)
-  * [ ] PR machine-readable JSON descriptions of the vulnerabilities to the [core](https://github.com/nodejs/security-wg/tree/HEAD/vuln/core)
+  * PR machine-readable JSON descriptions of the vulnerabilities to the [core](https://github.com/nodejs/security-wg/tree/HEAD/vuln/core)
     vulnerability DB.
   * [ ] Add yourself as a steward in the [Security Release Stewards](https://github.com/nodejs/node/blob/HEAD/doc/contributing/security-release-process.md#security-release-stewards)
Repository: vercel/next.js
Pull request: Update Turbopack development test manifest

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-dev-tests-manifest.json
patch: @@ -8077,22 +8077,6 @@
     "flakey": [],
     "runtimeError": false
   },
-  "test/e2e/app-dir/ppr-navigations/simple/per-segment-prefetching.test.ts": {
-    "passed": ["per segment prefetching ppr is disabled"],
-    "failed": [],
-    "pending": [],
-    "flakey": [],
-    "runtimeError": false
-  },
-  "test/e2e/app-dir/ppr-navigations/simple/simple.test.ts": {
-    "passed": [
-      "ppr-navigations simple can navigate between all the links and back"
-    ],
-    "failed": [],
-    "pending": [],
-    "flakey": [],
-    "runtimeError": false
-  },
   "test/e2e/app-dir/ppr-navigations/stale-prefetch-entry/stale-prefetch-entry.test.ts": {
     "passed": ["stale-prefetch-entry should skip dev & deploy"],
     "failed": [],
@@ -8929,6 +8913,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/segment-cache/cdn-cache-busting/cdn-cache-busting.test.ts": {
+    "passed": [
+      "segment cache (CDN cache busting) should not run during dev or deploy test runs"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/segment-cache/client-only-opt-in/client-only-opt-in.test.ts": {
     "passed": ["segment cache prefetch scheduling prefetching is disabled"],
     "failed": [],
Repository: ggml-org/llama.cpp
Pull request: Add Vulkan images to docker.md

Right now it's not easy to find those.



Changed files:
filename: docs/docker.md
patch: @@ -25,6 +25,9 @@ Additionally, there the following images, similar to the above:
 - `ghcr.io/ggml-org/llama.cpp:full-intel`: Same as `full` but compiled with SYCL support. (platforms: `linux/amd64`)
 - `ghcr.io/ggml-org/llama.cpp:light-intel`: Same as `light` but compiled with SYCL support. (platforms: `linux/amd64`)
 - `ghcr.io/ggml-org/llama.cpp:server-intel`: Same as `server` but compiled with SYCL support. (platforms: `linux/amd64`)
+- `ghcr.io/ggml-org/llama.cpp:full-vulkan`: Same as `full` but compiled with Vulkan support. (platforms: `linux/amd64`)
+- `ghcr.io/ggml-org/llama.cpp:light-vulkan`: Same as `light` but compiled with Vulkan support. (platforms: `linux/amd64`)
+- `ghcr.io/ggml-org/llama.cpp:server-vulkan`: Same as `server` but compiled with Vulkan support. (platforms: `linux/amd64`)
 
 The GPU enabled images are not currently tested by CI beyond being built. They are not built with any variation from the ones in the Dockerfiles defined in [.devops/](../.devops/) and the GitHub Action defined in [.github/workflows/docker.yml](../.github/workflows/docker.yml). If you need different settings (for example, a different CUDA, ROCm or MUSA library, you'll need to build the images locally for now).
Repository: electron/electron
Pull request: build: update linux container

Backport of #44392

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none

Changed files:
filename: .github/workflows/build.yml
patch: @@ -6,7 +6,7 @@ on:
       build-image-sha:
         type: string
         description: 'SHA for electron/build image'
-        default: 'cf814a4d2501e8e843caea071a6b70a48e78b855'
+        default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
         required: true
       skip-macos:
         type: boolean
@@ -53,7 +53,7 @@ jobs:
       id: set-output
       run: |
         if [ -z "${{ inputs.build-image-sha }}" ]; then
-          echo "build-image-sha=77262e58c37631ab082482f42c33cdf68c6c394b" >> "$GITHUB_OUTPUT"
+          echo "build-image-sha=bc2f48b2415a670de18d13605b1cf0eb5fdbaae1" >> "$GITHUB_OUTPUT"
         else
           echo "build-image-sha=${{ inputs.build-image-sha }}" >> "$GITHUB_OUTPUT"
         fi

filename: .github/workflows/linux-publish.yml
patch: @@ -6,7 +6,7 @@ on:
       build-image-sha:
         type: string
         description: 'SHA for electron/build image'
-        default: 'cf814a4d2501e8e843caea071a6b70a48e78b855'
+        default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
       upload-to-storage:
         description: 'Uploads to Azure storage'
         required: false

filename: .github/workflows/macos-publish.yml
patch: @@ -6,7 +6,7 @@ on:
       build-image-sha:
         type: string
         description: 'SHA for electron/build image'
-        default: 'cf814a4d2501e8e843caea071a6b70a48e78b855'
+        default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
         required: true
       upload-to-storage:
         description: 'Uploads to Azure storage'
Repository: ggml-org/llama.cpp
Pull request: metal : disable fast-math for some cpy kernels

Fix intermittent failures such as:

- https://github.com/ggml-org/llama.cpp/actions/runs/15929296382/job/44934264247#step:6:25782
- https://github.com/ggml-org/llama.cpp/actions/runs/15969591421/job/45037602724?pr=14460#step:6:25816

Changed files:
filename: ggml/src/ggml-metal/ggml-metal.metal
patch: @@ -138,6 +138,7 @@ void quantize_q4_0(device const float * src, device block_q4_0 & dst) {
 }
 
 void quantize_q4_1(device const float * src, device block_q4_1 & dst) {
+#pragma METAL fp math_mode(safe)
     float min = FLT_MAX;
     float max = -FLT_MAX;
 
@@ -203,6 +204,7 @@ void quantize_q5_0(device const float * src, device block_q5_0 & dst) {
 }
 
 void quantize_q5_1(device const float * src, device block_q5_1 & dst) {
+#pragma METAL fp math_mode(safe)
     float max = src[0];
     float min = src[0];
 
@@ -239,6 +241,7 @@ void quantize_q5_1(device const float * src, device block_q5_1 & dst) {
 }
 
 void quantize_iq4_nl(device const float * src, device block_iq4_nl & dst) {
+#pragma METAL fp math_mode(safe)
     float amax = 0.0f; // absolute max
     float max  = 0.0f;