helloadhavan/github_issues huggingface dataset:
Repository: vercel/next.js
Pull request: Update Turbopack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-build-tests-manifest.json
patch: @@ -2639,6 +2639,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/global-not-found/css/global-not-found-css.test.ts": {
+    "passed": [
+      "global-not-found - css should include css for global-not-found properly"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/global-not-found/metadata/metadata.test.ts": {
     "passed": [
       "global-not-found - metadata should render metadata of global-not-found for 404"
@@ -2967,6 +2976,7 @@
       "app dir - metadata dynamic routes icon image routes should render apple icon with dynamic routes",
       "app dir - metadata dynamic routes icon image routes should render icon with dynamic routes",
       "app dir - metadata dynamic routes robots.txt should handle robots.[ext] dynamic routes",
+      "app dir - metadata dynamic routes route segment config should generate dynamic route if dynamic config is force-dynamic",
       "app dir - metadata dynamic routes should generate unique path for image routes under group routes",
       "app dir - metadata dynamic routes should include default og font files in file trace",
       "app dir - metadata dynamic routes should inject dynamic metadata properly to head",
@@ -2989,8 +2999,7 @@
       "app dir - metadata dynamic routes social image routes should render og image with opengraph-image dynamic routes",
       "app dir - metadata dynamic routes social image routes should render og image with twitter-image dynamic routes",
       "app dir - metadata dynamic routes social image routes should support generate multi images with generateImageMetadata",
-      "app dir - metadata dynamic routes social image routes should support params as argument in dynamic routes",
-      "app dir - metadata dynamic routes route segment config should generate dynamic route if dynamic config is force-dynamic"
+      "app dir - metadata dynamic routes social image routes should support params as argument in dynamic routes"
     ],
     "failed": [],
     "pending": [],
@@ -4609,6 +4618,17 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/preferred-region/preferred-region.test.ts": {
+    "passed": [
+      "preferred-region should include preferredRegion in functions config manifest for nodejs runtime",
+      "preferred-region should return success from Edge API route",
+      "preferred-region should return success from Node.js API route"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/prefetch-searchparam/prefetch-searchparam.test.ts": {
     "passed": [
       "prefetch-searchparam should set prefetch cache properly on different search params"
Repository: denoland/deno
Pull request: fix(compile): do not error embedding same symlink via multiple methods

Closes https://github.com/denoland/deno/issues/27012

Changed files:
filename: cli/standalone/virtual_fs.rs
patch: @@ -329,7 +329,7 @@ impl VfsBuilder {
     let dir = self.add_dir(path.parent().unwrap())?;
     let name = path.file_name().unwrap().to_string_lossy();
     match dir.entries.binary_search_by(|e| e.name().cmp(&name)) {
-      Ok(_) => unreachable!(),
+      Ok(_) => Ok(()), // previously inserted
       Err(insert_index) => {
         dir.entries.insert(
           insert_index,
@@ -341,9 +341,9 @@ impl VfsBuilder {
               .collect::<Vec<_>>(),
           }),
         );
+        Ok(())
       }
     }
-    Ok(())
   }
 
   pub fn into_dir_and_files(self) -> (VirtualDirectory, Vec<Vec<u8>>) {

filename: tests/specs/compile/include/symlink_twice/__test__.jsonc
patch: @@ -0,0 +1,27 @@
+{
+  "tempDir": true,
+  "steps": [{
+    "args": "run -A setup.js",
+    "output": "[WILDCARD]"
+  }, {
+    "if": "unix",
+    "args": "compile --allow-read=data --include . --output main link.js",
+    "output": "[WILDCARD]"
+  }, {
+    "if": "unix",
+    "commandName": "./main",
+    "args": [],
+    "output": "1\n",
+    "exitCode": 0
+  }, {
+    "if": "windows",
+    "args": "compile --allow-read=data --include . --output main.exe link.js",
+    "output": "[WILDCARD]"
+  }, {
+    "if": "windows",
+    "commandName": "./main.exe",
+    "args": [],
+    "output": "1\n",
+    "exitCode": 0
+  }]
+}

filename: tests/specs/compile/include/symlink_twice/setup.js
patch: @@ -0,0 +1,3 @@
+Deno.mkdirSync("data");
+Deno.writeTextFileSync("index.js", "console.log(1);");
+Deno.symlinkSync("index.js", "link.js");
Repository: electron/electron
Pull request: build: update appveyor image to latest version

This PR updates appveyor.yml to the latest baked image, e-132.0.6824.0.

Notes: none

Changed files:
filename: appveyor-woa.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6807.0
+image: e-132.0.6824.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default

filename: appveyor.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6807.0
+image: e-132.0.6824.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default
Repository: nodejs/node
Pull request: src: use cached `emit` string

This patch uses the emit v8::String, which is already cached.

Changed files:
filename: src/node_process_events.cc
patch: @@ -56,7 +56,8 @@ MaybeLocal<Value> ProcessEmit(Environment* env,
 
   Local<Object> process = env->process_object();
   Local<Value> argv[] = {event_string, message};
-  return MakeCallback(isolate, process, "emit", arraysize(argv), argv, {0, 0});
+  return MakeCallback(
+      isolate, process, env->emit_string(), arraysize(argv), argv, {0, 0});
 }
 
 Maybe<bool> ProcessEmitWarningGeneric(Environment* env,
Repository: ggml-org/llama.cpp
Pull request: sycl: Fix im2col

Apply similar fix to https://github.com/ggml-org/llama.cpp/pull/14789 to the SYCL backend. I confirmed this fixes recent test failures.

Changed files:
filename: ggml/src/ggml-sycl/im2col.cpp
patch: @@ -26,7 +26,7 @@ static void im2col_kernel(const float * x, T * dst, int64_t batch_offset, int64_
 
     // make each work-item deal with more elements since sycl global range can not exceed max int
     for (int64_t i = global_id; i < pelements; i += (work_group_size * item_ct1.get_group_range(2))) {
-        const int64_t ksize = OW * (KH > 1 ? KW : 1);
+        const int64_t ksize = OW * KH;
         const int64_t kx    = i / ksize;
         const int64_t kd    = kx * ksize;
         const int64_t ky    = (i - kd) / OW;
Repository: electron/electron
Pull request: build: update appveyor image to latest version

Backport of #44606

See that PR for details.


Notes: none

Changed files:
filename: appveyor-woa.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6807.0
+image: e-132.0.6824.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default

filename: appveyor.yml
patch: @@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-132.0.6807.0
+image: e-132.0.6824.0
 environment:
   GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
   ELECTRON_OUT_DIR: Default
Repository: huggingface/transformers
Pull request: Allow `mlm_probability` to be set to `None` when `mlm=False` in DataCollatorForLanguageModeling (#38522)

Currently, in the `DataCollatorForLanguageModeling` class, the `mlm_probability` argument is required to be a float between 0 and 1, regardless of whether `mlm` is `True` or `False`.

However, since `mlm_probability` is only used when `mlm=True`, it would make sense to allow `mlm_probability=None` when `mlm=False`, in order to reduce confusion and unnecessary configuration.

Changed files:
filename: src/transformers/data/data_collator.py
patch: @@ -824,7 +824,7 @@ class DataCollatorForLanguageModeling(DataCollatorMixin):
 
     tokenizer: PreTrainedTokenizerBase
     mlm: bool = True
-    mlm_probability: float = 0.15
+    mlm_probability: Optional[float] = 0.15
     mask_replace_prob: float = 0.8
     random_replace_prob: float = 0.1
     pad_to_multiple_of: Optional[int] = None
@@ -833,21 +833,22 @@ class DataCollatorForLanguageModeling(DataCollatorMixin):
     seed: Optional[int] = None
 
     def __post_init__(self):
-        if self.mlm and self.tokenizer.mask_token is None:
-            raise ValueError(
-                "This tokenizer does not have a mask token which is necessary for masked language modeling. "
-                "You should pass `mlm=False` to train on causal language modeling instead."
-            )
-        if self.mlm_probability < 0 or self.mlm_probability > 1:
-            raise ValueError("mlm_probability should be between 0 and 1.")
+        if self.mlm:
+            if self.tokenizer.mask_token is None:
+                raise ValueError(
+                    "This tokenizer does not have a mask token which is necessary for masked language modeling. "
+                    "You should pass `mlm=False` to train on causal language modeling instead."
+                )
+            if self.mlm_probability is None or self.mlm_probability < 0 or self.mlm_probability > 1:
+                raise ValueError("mlm_probability should be between 0 and 1.")
+            self.mlm_probability = float(self.mlm_probability)
         if self.mask_replace_prob + self.random_replace_prob > 1:
             raise ValueError("The sum of mask_replace_prob and random_replace_prob should not exceed 1")
         if self.mask_replace_prob < 0 or self.mask_replace_prob > 1:
             raise ValueError("mask_replace_prob should be between 0 and 1.")
         if self.random_replace_prob < 0 or self.random_replace_prob > 1:
             raise ValueError("random_replace_prob should be between 0 and 1.")
 
-        self.mlm_probability = float(self.mlm_probability)
         self.mask_replace_prob = float(self.mask_replace_prob)
         self.random_replace_prob = float(self.random_replace_prob)
Repository: denoland/deno
Pull request: fix(runtime/ops): Fix watchfs remove event

Fix related to #26906 . 
Currently, if a file is removed, no event is emitted because the file path no longer exists. As a result, [this check](https://github.com/denoland/deno/blob/12b377247be2b74155ded3a678ff2996ef3d7c9f/runtime/ops/fs_events.rs#L149) returns false. 

With this PR, an additional check is introduced to verify if the file exists. If the file does not exist, a custom "remove" event is emitted.
This change is necessary because, based on tests conducted on macOS and Linux (Ubuntu 24.04.1 LTS), Linux emits a "rename" event instead of a "remove" event when a file is deleted. Introducing a dedicated "remove" event ensures consistent and clearer behavior across platforms.



Changed files:
filename: runtime/ops/fs_events.rs
patch: @@ -109,6 +109,14 @@ fn starts_with_canonicalized(path: &Path, prefix: &str) -> bool {
   }
 }
 
+fn is_file_removed(event_path: &PathBuf) -> bool {
+  let exists_path = std::fs::exists(event_path);
+  match exists_path {
+    Ok(res) => !res,
+    Err(_) => false,
+  }
+}
+
 #[derive(Debug, thiserror::Error)]
 pub enum FsEventsError {
   #[error(transparent)]
@@ -150,6 +158,13 @@ fn start_watcher(
             })
           }) {
             let _ = sender.try_send(Ok(event.clone()));
+          } else if event.paths.iter().any(is_file_removed) {
+            let remove_event = FsEvent {
+              kind: "remove",
+              paths: event.paths.clone(),
+              flag: None,
+            };
+            let _ = sender.try_send(Ok(remove_event));
           }
         }
       }

filename: tests/unit/fs_events_test.ts
patch: @@ -45,6 +45,14 @@ async function makeTempDir(): Promise<string> {
   return testDir;
 }
 
+async function makeTempFile(): Promise<string> {
+  const testFile = await Deno.makeTempFile();
+  // The watcher sometimes witnesses the creation of it's own root
+  // directory. Delay a bit.
+  await delay(100);
+  return testFile;
+}
+
 Deno.test(
   { permissions: { read: true, write: true } },
   async function watchFsBasic() {
@@ -155,3 +163,25 @@ Deno.test(
     assert(done);
   },
 );
+
+Deno.test(
+  { permissions: { read: true, write: true } },
+  async function watchFsRemove() {
+    const testFile = await makeTempFile();
+    using watcher = Deno.watchFs(testFile);
+    async function waitForRemove() {
+      for await (const event of watcher) {
+        if (event.kind === "remove") {
+          return event;
+        }
+      }
+    }
+    const eventPromise = waitForRemove();
+
+    await Deno.remove(testFile);
+
+    // Expect zero events.
+    const event = await eventPromise;
+    assertEquals(event!.kind, "remove");
+  },
+);
Repository: vercel/next.js
Pull request: [dev-overlay] Remove unnecessary code from /pages dev error boundary

No longer needed in React 18+

Changed files:
filename: packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx
patch: @@ -15,10 +15,6 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent<
     return { error }
   }
 
-  componentDidCatch(error: Error) {
-    this.setState({ error })
-  }
-
   // Explicit type is needed to avoid the generated `.d.ts` having a wide return type that could be specific to the `@types/react` version.
   render(): React.ReactNode {
     // The component has to be unmounted or else it would continue to error

filename: packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx
patch: @@ -17,9 +17,7 @@ export function PagesDevOverlay({ children }: PagesDevOverlayProps) {
 
   return (
     <>
-      <PagesDevOverlayErrorBoundary>
-        {children ?? null}
-      </PagesDevOverlayErrorBoundary>
+      <PagesDevOverlayErrorBoundary>{children}</PagesDevOverlayErrorBoundary>
 
       {/* Fonts can only be loaded outside the Shadow DOM. */}
       <FontStyles />
Repository: facebook/react
Pull request: Rejct toWarnDev if given callback throws



## Summary

Should unblock https://github.com/facebook/react/pull/25970
If the callback for `toWarnDev` was `async` and threw, we didn't ultimately reject the await Promise from the matcher. This resulted in tests failing even though the failure was expected due to a test gate.

## How did you test this change?

- [x] tested in https://github.com/facebook/react/pull/25970 with `yarn test --r=stable --env=development packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js --watch`
- [x] `yarn test`
- [x] CI 


Changed files:
filename: scripts/jest/matchers/toWarnDev.js
patch: @@ -270,15 +270,20 @@ const createMatcherFor = (consoleMethod, matcherName) =>
           // Once `act(async () => {}).then(() => {}).then(() => {})` works
           // we can just return `result.then(onFinally, error => ...)`
           returnPromise = new Promise((resolve, reject) => {
-            result.then(
-              () => {
-                resolve(onFinally());
-              },
-              error => {
-                caughtError = error;
-                return resolve(onFinally());
-              }
-            );
+            result
+              .then(
+                () => {
+                  resolve(onFinally());
+                },
+                error => {
+                  caughtError = error;
+                  return resolve(onFinally());
+                }
+              )
+              // In case onFinally throws we need to reject from this matcher
+              .catch(error => {
+                reject(error);
+              });
           });
         }
       } catch (error) {
Repository: ggml-org/llama.cpp
Pull request: docker : disable arm64 and intel images


Changed files:
filename: .github/workflows/docker.yml
patch: @@ -36,10 +36,14 @@ jobs:
       matrix:
         config:
           # Multi-stage build
-          - { tag: "cpu", dockerfile: ".devops/cpu.Dockerfile", platforms: "linux/amd64,linux/arm64", full: true, light: true, server: true, free_disk_space: false }
+          # Note: the arm64 images are failing, which prevents the amd64 images from being built
+          # https://github.com/ggml-org/llama.cpp/issues/11888
+          #- { tag: "cpu", dockerfile: ".devops/cpu.Dockerfile", platforms: "linux/amd64,linux/arm64", full: true, light: true, server: true, free_disk_space: false }
+          - { tag: "cpu", dockerfile: ".devops/cpu.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, free_disk_space: false }
           - { tag: "cuda", dockerfile: ".devops/cuda.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, free_disk_space: false }
           - { tag: "musa", dockerfile: ".devops/musa.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, free_disk_space: true }
-          - { tag: "intel", dockerfile: ".devops/intel.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, free_disk_space: false }
+          # Note: the intel images are failing due to an out of disk space error
+          # - { tag: "intel", dockerfile: ".devops/intel.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, free_disk_space: false }
           - { tag: "vulkan", dockerfile: ".devops/vulkan.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, free_disk_space: false }
           # Note: the rocm images are failing due to a compiler error and are disabled until this is fixed to allow the workflow to complete
           #- {tag: "rocm", dockerfile: ".devops/rocm.Dockerfile", platforms: "linux/amd64,linux/arm64", full: true, light: true, server: true, free_disk_space: true }
Repository: huggingface/transformers
Pull request: fix spelling errors 

Hey team! Fixed errors in `test_modeling_mllama.py` / `test_modeling_video_llava.py` / `test_processing_common.py`

`dirrectly` - `directly` x3
`successfull` - `successful`
`suports` - `supports`

Changed files:
filename: tests/models/mllama/test_modeling_mllama.py
patch: @@ -366,15 +366,15 @@ def test_contrastive_generate_low_memory(self, assistant_type):
     def test_assisted_decoding_with_num_logits_to_keep(self):
         pass
 
-    @unittest.skip(reason="Mllama uses self.weights dirrectly causing device mismatch when offloading`")
+    @unittest.skip(reason="Mllama uses self.weights directly causing device mismatch when offloading`")
     def test_cpu_offload(self):
         pass
 
-    @unittest.skip(reason="Mllama uses self.weights dirrectly causing device mismatch when offloading`")
+    @unittest.skip(reason="Mllama uses self.weights directly causing device mismatch when offloading`")
     def test_disk_offload_bin(self):
         pass
 
-    @unittest.skip(reason="Mllama uses self.weights dirrectly causing device mismatch when offloading`")
+    @unittest.skip(reason="Mllama uses self.weights directly causing device mismatch when offloading`")
     def test_disk_offload_safetensors(self):
         pass
 

filename: tests/models/video_llava/test_modeling_video_llava.py
patch: @@ -399,7 +399,7 @@ def test_mismatching_num_image_tokens(self):
         for model_class in self.all_model_classes:
             model = model_class(config).to(torch_device)
             curr_input_dict = copy.deepcopy(input_dict)
-            _ = model(**curr_input_dict)  # successfull forward with no modifications
+            _ = model(**curr_input_dict)  # successful forward with no modifications
 
             # remove one image but leave the image token in text
             curr_input_dict["pixel_values_images"] = curr_input_dict["pixel_values_images"][-1:, ...]

filename: tests/test_processing_common.py
patch: @@ -915,7 +915,7 @@ def test_apply_chat_template_audio(self, batch_size: int, return_tensors: str):
         )
 
     @require_av
-    @parameterized.expand([(1, "pt"), (2, "pt")])  # video processor suports only torchvision
+    @parameterized.expand([(1, "pt"), (2, "pt")])  # video processor supports only torchvision
     def test_apply_chat_template_video(self, batch_size: int, return_tensors: str):
         self._test_apply_chat_template(
             "video", batch_size, return_tensors, "videos_input_name", "video_processor", MODALITY_INPUT_DATA["videos"]
Repository: vercel/next.js
Pull request: Turbopack Build: Implement helpful error for missing sass package

## What?

Implements the same error message that we add to the webpack handling. I'm not super happy about this solution (though it matches what we do for webpack) ideally we improve the sass-loader error itself in the future but that requires upgrading sass-loader as well and introducing a breaking change. For now this unblocks the test passing.

Closes PACK-4769

Changed files:
filename: packages/next/src/shared/lib/turbopack/utils.ts
patch: @@ -190,7 +190,17 @@ export function formatIssue(issue: Issue) {
   }
 
   if (description) {
-    message += renderStyledStringToErrorAnsi(description) + '\n\n'
+    if (
+      description.type === 'text' &&
+      description.value.includes(`Cannot find module 'sass'`)
+    ) {
+      message +=
+        "To use Next.js' built-in Sass support, you first need to install `sass`.\n"
+      message += 'Run `npm i sass` or `yarn add sass` inside your workspace.\n'
+      message += '\nLearn more: https://nextjs.org/docs/messages/install-sass'
+    } else {
+      message += renderStyledStringToErrorAnsi(description) + '\n\n'
+    }
   }
 
   // TODO: make it possible to enable this for debugging, but not in tests.

filename: test/e2e/app-dir/scss/webpack-error/webpack-error.test.ts
patch: @@ -24,7 +24,6 @@ describe('SCSS Support', () => {
         'Learn more: https://nextjs.org/docs/messages/install-sass'
       )
 
-      expect(cliOutput).toContain('Failed to compile.')
       expect(cliOutput).not.toContain('css-loader')
       expect(cliOutput).not.toContain('sass-loader')
     })

filename: test/turbopack-build-tests-manifest.json
patch: @@ -5320,10 +5320,10 @@
     "runtimeError": false
   },
   "test/e2e/app-dir/scss/webpack-error/webpack-error.test.ts": {
-    "passed": [],
-    "failed": [
+    "passed": [
       "SCSS Support Friendly Webpack Error should be a friendly error successfully"
     ],
+    "failed": [],
     "pending": [],
     "flakey": [],
     "runtimeError": false