helloadhavan/github_issues huggingface dataset:
Repository: ollama/ollama
Pull request: fix download

`inner` is a context that needs to be passed to functions inside the goroutine otherwise `g.Wait` may wait indefinitely even on error

Changed files:
filename: server/download.go
patch: @@ -144,7 +144,7 @@ func (b *blobDownload) run(ctx context.Context, requestURL *url.URL, opts *Regis
 
 	file.Truncate(b.Total)
 
-	g, _ := errgroup.WithContext(ctx)
+	g, inner := errgroup.WithContext(ctx)
 	g.SetLimit(numDownloadParts)
 	for i := range b.Parts {
 		part := b.Parts[i]
@@ -156,7 +156,7 @@ func (b *blobDownload) run(ctx context.Context, requestURL *url.URL, opts *Regis
 		g.Go(func() error {
 			for try := 0; try < maxRetries; try++ {
 				w := io.NewOffsetWriter(file, part.StartsAt())
-				err := b.downloadChunk(ctx, requestURL, w, part, opts)
+				err := b.downloadChunk(inner, requestURL, w, part, opts)
 				switch {
 				case errors.Is(err, context.Canceled):
 					return err
Repository: vercel/next.js
Pull request: Turbopack: fix the require.cache clear logic

### What?

Fixes a typo and an oversight in the logic.

Closes PACK-5303

Changed files:
filename: packages/next/src/server/dev/hot-reloader-turbopack.ts
patch: @@ -316,6 +316,10 @@ export async function createHotReloaderTurbopack(
   ): boolean {
     if (force) {
       for (const { path, contentHash } of writtenEndpoint.serverPaths) {
+        // We ignore source maps
+        if (path.endsWith('.map')) continue
+        const localKey = `${key}:${path}`
+        serverPathState.set(localKey, contentHash)
         serverPathState.set(path, contentHash)
       }
     } else {
@@ -332,11 +336,11 @@ export async function createHotReloaderTurbopack(
           (globalHash && globalHash !== contentHash)
         ) {
           hasChange = true
-          serverPathState.set(key, contentHash)
+          serverPathState.set(localKey, contentHash)
           serverPathState.set(path, contentHash)
         } else {
           if (!localHash) {
-            serverPathState.set(key, contentHash)
+            serverPathState.set(localKey, contentHash)
           }
           if (!globalHash) {
             serverPathState.set(path, contentHash)
Repository: facebook/react
Pull request: [Tests][Fizz] Test script runtime even when external runtime is available

Previously if the external runtime was enabled Fizz tests would use it exclusively. However now that this flag is enabled for OSS and Meta builds this means we were no longer testing the inline script runtime. This changes the test flags to produce some runs where we test the inline script runtime and others where we test the external runtime

the external runtime will be tested if the flag is enabled and
* Meta Builds: variant is true
* OSS Builds: experiemental is true

this gives us decent coverage. long term we should probably bring variant to OSS builds since we will eventually want to test both modes even when the external runtime is stable.

Changed files:
filename: packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
patch: @@ -153,7 +153,7 @@ describe('ReactDOMFizzServer', () => {
     });
 
     renderOptions = {};
-    if (gate(flags => flags.enableFizzExternalRuntime)) {
+    if (gate(flags => flags.shouldUseFizzExternalRuntime)) {
       renderOptions.unstable_externalRuntimeSrc =
         'react-dom-bindings/src/server/ReactDOMServerExternalRuntime.js';
     }
@@ -610,7 +610,7 @@ describe('ReactDOMFizzServer', () => {
         Array.from(container.getElementsByTagName('script')).filter(
           node => node.getAttribute('nonce') === CSPnonce,
         ).length,
-      ).toEqual(6);
+      ).toEqual(gate(flags => flags.shouldUseFizzExternalRuntime) ? 6 : 5);
 
       await act(() => {
         resolve({default: Text});
@@ -4292,7 +4292,7 @@ describe('ReactDOMFizzServer', () => {
     );
   });
 
-  // @gate enableFizzExternalRuntime
+  // @gate shouldUseFizzExternalRuntime
   it('does not send script tags for SSR instructions when using the external runtime', async () => {
     function App() {
       return (

filename: packages/react-dom/src/__tests__/ReactDOMFloat-test.js
patch: @@ -97,7 +97,7 @@ describe('ReactDOMFloat', () => {
     });
 
     renderOptions = {};
-    if (gate(flags => flags.enableFizzExternalRuntime)) {
+    if (gate(flags => flags.shouldUseFizzExternalRuntime)) {
       renderOptions.unstable_externalRuntimeSrc =
         'react-dom/unstable_server-external-runtime';
     }

filename: scripts/jest/TestFlags.js
patch: @@ -83,6 +83,15 @@ function getTestFlags() {
       enableSuspenseList: releaseChannel === 'experimental' || www,
       enableLegacyHidden: www,
 
+      // This flag is used to determine whether we should run Fizz tests using
+      // the external runtime or the inline script runtime.
+      // For Meta we use variant to gate the feature. For OSS we use experimental
+      shouldUseFizzExternalRuntime: !featureFlags.enableFizzExternalRuntime
+        ? false
+        : www
+        ? __VARIANT__
+        : __EXPERIMENTAL__,
+
       // This is used by useSyncExternalStoresShared-test.js to decide whether
       // to test the shim or the native implementation of useSES.
       // TODO: It's disabled when enableRefAsProp is on because the JSX
Repository: huggingface/transformers
Pull request: Run FA2 tests in CI

# What does this PR do?

As discussed internally. This PR adds  `flash-attn` in the CI docker image so the FA2 tests would be run.

Changed files:
filename: docker/transformers-all-latest-gpu/Dockerfile
patch: @@ -51,6 +51,10 @@ RUN python3 -m pip install --no-cache-dir bitsandbytes
 # Some tests require quanto
 RUN python3 -m pip install --no-cache-dir quanto
 
+# After using A10 as CI runner, let's run FA2 tests
+RUN python3 -m pip uninstall -y ninja && python3 -m pip install --no-cache-dir ninja && python3 -m pip install flash-attn --no-cache-dir --no-build-isolation
+
+# TODO (ydshieh): check this again
 # `quanto` will install `ninja` which leads to many `CUDA error: an illegal memory access ...` in some model tests
 # (`deformable_detr`, `rwkv`, `mra`)
 RUN python3 -m pip uninstall -y ninja
Repository: ollama/ollama
Pull request: validate api options fields from map

We use a map to set options from the API so that we can see which option fields were specified, otherwise we override default options with zero values. The issue here is that there was no validation that the input option fields were valid, so using an incorrect field by mistake did not return an error.

New response:
```
curl -X 'POST' -d '{"prompt":"hello", "model": "mistral", "options": {"seed": 1234, "temperature": 0, "test": 1234}}' 'http://127.0.0.1:11434/api/generate'
{"error":"invalid options: test"}
```

from #694

Changed files:
filename: api/types.go
patch: @@ -205,6 +205,8 @@ type Options struct {
 	NumThread int `json:"num_thread,omitempty"`
 }
 
+var ErrInvalidOpts = fmt.Errorf("invalid options")
+
 func (opts *Options) FromMap(m map[string]interface{}) error {
 	valueOpts := reflect.ValueOf(opts).Elem() // names of the fields in the options struct
 	typeOpts := reflect.TypeOf(opts).Elem()   // types of the fields in the options struct
@@ -218,6 +220,7 @@ func (opts *Options) FromMap(m map[string]interface{}) error {
 		}
 	}
 
+	invalidOpts := []string{}
 	for key, val := range m {
 		if opt, ok := jsonOpts[key]; ok {
 			field := valueOpts.FieldByName(opt.Name)
@@ -281,8 +284,14 @@ func (opts *Options) FromMap(m map[string]interface{}) error {
 					return fmt.Errorf("unknown type loading config params: %v", field.Kind())
 				}
 			}
+		} else {
+			invalidOpts = append(invalidOpts, key)
 		}
 	}
+
+	if len(invalidOpts) > 0 {
+		return fmt.Errorf("%w: %v", ErrInvalidOpts, strings.Join(invalidOpts, ", "))
+	}
 	return nil
 }
 

filename: server/routes.go
patch: @@ -68,7 +68,6 @@ func load(ctx context.Context, workDir string, model *Model, reqOpts map[string]
 	}
 
 	if err := opts.FromMap(reqOpts); err != nil {
-		log.Printf("could not merge model options: %v", err)
 		return err
 	}
 
@@ -186,6 +185,10 @@ func GenerateHandler(c *gin.Context) {
 	// TODO: set this duration from the request if specified
 	sessionDuration := defaultSessionDuration
 	if err := load(c.Request.Context(), workDir, model, req.Options, sessionDuration); err != nil {
+		if errors.Is(err, api.ErrInvalidOpts) {
+			c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+			return
+		}
 		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
 		return
 	}
Repository: facebook/react
Pull request: [DOM] Infer react-server entries bundles if not explicitly configured

When packaging we want to infer that a bundle exists for a `react-server` file even if it isn't explicitly configured. This is useful in particular for the react-server entrypoints that error on import that were recently added to `react-dom`

This change also cleans up a wayward comment left behind in a prior PR

Changed files:
filename: packages/react-dom/src/ReactDOMSharedInternals.js
patch: @@ -47,8 +47,4 @@ const Internals: ReactDOMInternals = {
   usingClientEntryPoint: false,
 };
 
-// if (__DEV__) {
-//   (Internals: any).usingClientEntryPoint = false;
-// }
-
 export default Internals;

filename: scripts/rollup/packaging.js
patch: @@ -213,6 +213,18 @@ function filterOutEntrypoints(name) {
       hasBundle =
         entryPointsToHasBundle.get(entry + '.node') ||
         entryPointsToHasBundle.get(entry + '.browser');
+
+      // The .react-server and .rsc suffixes may not have a bundle representation but
+      // should infer their bundle status from the non-suffixed entry point.
+      if (entry.endsWith('.react-server')) {
+        hasBundle = entryPointsToHasBundle.get(
+          entry.slice(0, '.react-server'.length * -1)
+        );
+      } else if (entry.endsWith('.rsc')) {
+        hasBundle = entryPointsToHasBundle.get(
+          entry.slice(0, '.rsc'.length * -1)
+        );
+      }
     }
     if (hasBundle === undefined) {
       // This doesn't exist in the bundles. It's an extra file.
Repository: vercel/next.js
Pull request: fix: typesafe linking to route handlers and pages API routes

Fixes #82833

Changed files:
filename: packages/next/src/server/lib/router-utils/typegen.ts
patch: @@ -201,18 +201,24 @@ export function generateLinkTypesFile(
   routesManifest: RouteTypesManifest
 ): string {
   // Generate serialized static and dynamic routes for the internal namespace
-  const allRoutes = {
-    ...routesManifest.appRoutes,
-    ...routesManifest.pageRoutes,
-    ...routesManifest.redirectRoutes,
-    ...routesManifest.rewriteRoutes,
-  }
+  // Build a unified set of routes across app/pages/redirect/rewrite as well as
+  // app route handlers and Pages Router API routes.
+  const allRoutesSet = new Set<string>([
+    ...Object.keys(routesManifest.appRoutes),
+    ...Object.keys(routesManifest.pageRoutes),
+    ...Object.keys(routesManifest.redirectRoutes),
+    ...Object.keys(routesManifest.rewriteRoutes),
+    // Allow linking to App Route Handlers (e.g. `/logout/route.ts`)
+    ...Object.keys(routesManifest.appRouteHandlerRoutes),
+    // Allow linking to Pages Router API routes (e.g. `/api/*`)
+    ...Array.from(routesManifest.pageApiRoutes),
+  ])
 
   const staticRouteTypes: string[] = []
   const dynamicRouteTypes: string[] = []
 
   // Process each route using the same logic as the plugin
-  for (const route of Object.keys(allRoutes)) {
+  for (const route of allRoutesSet) {
     const { isDynamic, routeType } = formatRouteToRouteType(route)
     if (isDynamic) {
       dynamicRouteTypes.push(routeType)

filename: test/e2e/app-dir/typed-routes/app/api-test/route.ts
patch: @@ -0,0 +1,5 @@
+import { NextResponse } from 'next/server'
+
+export function GET() {
+  return NextResponse.json({ message: 'Hello, world!' })
+}

filename: test/e2e/app-dir/typed-routes/typed-links.test.ts
patch: @@ -15,6 +15,12 @@ describe('typed-links', () => {
     expect(dts).toContain(`declare module 'next/link'`)
   })
 
+  it('should include handler route from app/api-test/route.ts in generated link route definitions', async () => {
+    const dts = await next.readFile('.next/types/link.d.ts')
+    // Ensure the app route handler at app/api-test/route.ts ("/api-test") is present
+    expect(dts).toContain('`/api-test`')
+  })
+
   if (isNextStart) {
     it('should pass type checking with valid routes', async () => {
       await next.stop()

filename: test/e2e/app-dir/typed-routes/typed-routes.test.ts
patch: @@ -2,7 +2,7 @@ import { nextTestSetup } from 'e2e-utils'
 
 const expectedDts = `
 type AppRoutes = "/" | "/_shop/[[...category]]" | "/dashboard" | "/dashboard/settings" | "/docs/[...slug]" | "/gallery/photo/[id]" | "/project/[slug]"
-type AppRouteHandlerRoutes = "/api/docs/[...slug]" | "/api/shop/[[...category]]" | "/api/users/[id]"
+type AppRouteHandlerRoutes = "/api-test" | "/api/docs/[...slug]" | "/api/shop/[[...category]]" | "/api/users/[id]"
 type PageRoutes = "/about" | "/users/[id]"
 type LayoutRoutes = "/" | "/dashboard"
 type RedirectRoutes = "/blog/[category]/[[...slug]]" | "/project/[slug]"
Repository: denoland/deno
Pull request: fix(bundle): set the type of the outputFile in the deno bundle to `Uint8Array<ArrayBuffer>`

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->

fix #30711

Changed files:
filename: cli/tsc/dts/lib.deno.unstable.d.ts
patch: @@ -146,7 +146,7 @@ declare namespace Deno {
      */
     export interface OutputFile {
       path: string;
-      contents?: Uint8Array;
+      contents?: Uint8Array<ArrayBuffer>;
       hash: string;
       text(): string;
     }
Repository: facebook/react
Pull request: CI: Run with Node.js 18.20

## Summary

Run CI with Node.js 18.20.1 instead of 16.16.0. Node.js 16.x has reached end-of-life. Codesandbox and local development already use 18.x due to `.nvmrc` anyway.

cimg/openjdk has no version satisfying Node.js ^18.18 which we need for ESLint v9. However, cimg/node does have Java 11 (which is sufficient for GCC). We can only choose between Node.js 18.13 (too low) and Node.js 20.x when using cimg/openjdk. Using Node.js 20.x would be an alternative but means we no longer test the lowest Node.js LTS release.

cimg/node-browsers is also just 170MB instead of 530MB that cimg/openjdk uses which is nice.


## How did you test this change?

- [x] CI


Changed files:
filename: .circleci/config.yml
patch: @@ -2,7 +2,7 @@ version: 2.1
 
 aliases:
   - &docker
-    - image: cimg/openjdk:18.0-node
+    - image: cimg/node:18.20.1-browsers
 
   - &environment
     TZ: /usr/share/zoneinfo/America/Los_Angeles
@@ -246,8 +246,7 @@ jobs:
           command: ./scripts/circleci/run_devtools_e2e_tests.js
 
   run_fixtures_flight_tests:
-    docker:
-      - image: cimg/openjdk:20.0-node
+    docker: *docker
     environment: *environment
     steps:
       - checkout
Repository: nodejs/node
Pull request: fs: make `processReadResult()` and `readSyncRecursive()` private

These two methods are for internal use only. They alter `dir`'s internal state and don't return anything, i.e. can't be used in userland in meaningful way.
Unless there are objections, these can be unexposed without deprecation cycle.

Closes: https://github.com/nodejs/node/issues/58671
Refs: https://github.com/nodejs/node/pull/41439

Changed files:
filename: lib/internal/fs/dir.js
patch: @@ -82,7 +82,7 @@ class Dir {
       );
 
       if (result !== null) {
-        this.processReadResult(path, result);
+        this.#processReadResult(path, result);
         if (result.length > 0) {
           ArrayPrototypePush(this.#handlerQueue, handler);
         }
@@ -125,7 +125,7 @@ class Dir {
         const dirent = ArrayPrototypeShift(this.#bufferedEntries);
 
         if (this.#options.recursive && dirent.isDirectory()) {
-          this.readSyncRecursive(dirent);
+          this.#readSyncRecursive(dirent);
         }
 
         if (maybeSync)
@@ -151,10 +151,10 @@ class Dir {
       }
 
       try {
-        this.processReadResult(this.#path, result);
+        this.#processReadResult(this.#path, result);
         const dirent = ArrayPrototypeShift(this.#bufferedEntries);
         if (this.#options.recursive && dirent.isDirectory()) {
-          this.readSyncRecursive(dirent);
+          this.#readSyncRecursive(dirent);
         }
         callback(null, dirent);
       } catch (error) {
@@ -170,7 +170,7 @@ class Dir {
     );
   }
 
-  processReadResult(path, result) {
+  #processReadResult(path, result) {
     for (let i = 0; i < result.length; i += 2) {
       ArrayPrototypePush(
         this.#bufferedEntries,
@@ -183,7 +183,7 @@ class Dir {
     }
   }
 
-  readSyncRecursive(dirent) {
+  #readSyncRecursive(dirent) {
     const path = pathModule.join(dirent.parentPath, dirent.name);
     const handle = dirBinding.opendir(
       path,
@@ -209,7 +209,7 @@ class Dir {
     if (this.#processHandlerQueue()) {
       const dirent = ArrayPrototypeShift(this.#bufferedEntries);
       if (this.#options.recursive && dirent.isDirectory()) {
-        this.readSyncRecursive(dirent);
+        this.#readSyncRecursive(dirent);
       }
       return dirent;
     }
@@ -223,11 +223,11 @@ class Dir {
       return result;
     }
 
-    this.processReadResult(this.#path, result);
+    this.#processReadResult(this.#path, result);
 
     const dirent = ArrayPrototypeShift(this.#bufferedEntries);
     if (this.#options.recursive && dirent.isDirectory()) {
-      this.readSyncRecursive(dirent);
+      this.#readSyncRecursive(dirent);
     }
     return dirent;
   }
Repository: denoland/deno
Pull request: fix(ext/node): handle falsy values enumerability in process.env

Closes #30701

Changed files:
filename: ext/node/polyfills/_process/process.ts
patch: @@ -85,7 +85,7 @@ export const env: InstanceType<ObjectConstructor> & Record<string, string> =
     ownKeys: () => ReflectOwnKeys(Deno.env.toObject()),
     getOwnPropertyDescriptor: (_target, name) => {
       const value = denoEnvGet(String(name));
-      if (value) {
+      if (value !== undefined) {
         return {
           enumerable: true,
           configurable: true,

filename: tests/unit_node/process_test.ts
patch: @@ -433,6 +433,20 @@ Deno.test({
   },
 });
 
+// #30701
+Deno.test({
+  name: "process.env handles falsy values correctly",
+  fn() {
+    const key = "TEST_ENV_VAR_EMPTY_STRING";
+    Deno.env.set(key, "");
+
+    assertEquals(process.env[key], "");
+    assertEquals(Object.keys(process.env).includes(key), true);
+    assert(key in process.env);
+    assert(Object.hasOwn(process.env, key));
+  },
+});
+
 Deno.test({
   name: "process.env requires scoped env permission",
   permissions: { env: ["FOO"] },
Repository: ollama/ollama
Pull request: Don't assume download has started if cancelled during preparation

Discards download progress if cancelled (e.g. by `ctrl+c`) while preparing to download

Changed files:
filename: server/download.go
patch: @@ -314,6 +314,7 @@ func downloadBlob(ctx context.Context, opts downloadOpts) error {
 		requestURL := opts.mp.BaseURL()
 		requestURL = requestURL.JoinPath("v2", opts.mp.GetNamespaceRepository(), "blobs", opts.digest)
 		if err := download.Prepare(ctx, requestURL, opts.regOpts); err != nil {
+			blobDownloadManager.Delete(opts.digest)
 			return err
 		}
Repository: denoland/deno
Pull request: fix(ext/node): set default callback for `fs.close`

Fixes #30718

Changed files:
filename: ext/node/polyfills/_fs/_fs_close.ts
patch: @@ -13,9 +13,19 @@ const {
   ObjectPrototypeIsPrototypeOf,
 } = primordials;
 
-export function close(fd: number, callback: CallbackWithError) {
+function defaultCloseCallback(err: Error | null) {
+  if (err !== null) throw err;
+}
+
+export function close(
+  fd: number,
+  callback: CallbackWithError = defaultCloseCallback,
+) {
   fd = getValidatedFd(fd);
-  callback = makeCallback(callback);
+  if (callback !== defaultCloseCallback) {
+    callback = makeCallback(callback);
+  }
+
   setTimeout(() => {
     let error = null;
     try {

filename: tests/unit_node/_fs/_fs_close_test.ts
patch: @@ -1,7 +1,7 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 import { assert, assertThrows, fail } from "@std/assert";
 import { assertCallbackErrorUncaught } from "../_test_utils.ts";
-import { close, closeSync } from "node:fs";
+import { close, closeSync, openSync } from "node:fs";
 
 Deno.test({
   name: "ASYNC: File is closed",
@@ -101,3 +101,12 @@ Deno.test({
     },
   });
 });
+
+Deno.test({
+  name: "[std/node/fs] close with default callback if none is provided",
+}, async () => {
+  const tempFile = await Deno.makeTempFile();
+  const rid = openSync(tempFile, "r");
+  close(rid);
+  await Deno.remove(tempFile);
+});
Repository: vercel/next.js
Pull request: Remove experimental appDocumentPreloading

## What?

This functionality has been succeeded by experimental.preloadEntriesOnStart which is enabled by default. `preloadEntriesOnStart` can likely also be removed as an option given that it's `true` since 16 months ago. But that's for another PR.

Closes PACK-5309

Changed files:
filename: packages/next/src/server/config-schema.ts
patch: @@ -333,7 +333,6 @@ export const configSchema: zod.ZodType<NextConfig> = z.lazy(() =>
         adapterPath: z.string().optional(),
         useSkewCookie: z.boolean().optional(),
         after: z.boolean().optional(),
-        appDocumentPreloading: z.boolean().optional(),
         appNavFailHandling: z.boolean().optional(),
         preloadEntriesOnStart: z.boolean().optional(),
         allowedRevalidateHeaderKeys: z.array(z.string()).optional(),

filename: packages/next/src/server/config-shared.ts
patch: @@ -455,7 +455,6 @@ export interface ExperimentalConfig {
   clientSegmentCache?: boolean | 'client-only'
   clientParamParsing?: boolean
   dynamicOnHover?: boolean
-  appDocumentPreloading?: boolean
   preloadEntriesOnStart?: boolean
   clientRouterFilter?: boolean
   clientRouterFilterRedirects?: boolean
@@ -1541,7 +1540,6 @@ export const defaultConfig = Object.freeze({
     clientSegmentCache: false,
     clientParamParsing: false,
     dynamicOnHover: false,
-    appDocumentPreloading: undefined,
     preloadEntriesOnStart: true,
     clientRouterFilter: true,
     clientRouterFilterRedirects: false,

filename: packages/next/src/server/next-server.ts
patch: @@ -292,32 +292,6 @@ export default class NextNodeServer extends BaseServer<
       this.imageResponseCache = new ResponseCache(this.minimalMode)
     }
 
-    const { appDocumentPreloading } = this.nextConfig.experimental
-    const isDefaultEnabled = typeof appDocumentPreloading === 'undefined'
-
-    if (
-      !options.dev &&
-      (appDocumentPreloading === true ||
-        !(this.minimalMode && isDefaultEnabled))
-    ) {
-      // pre-warm _document and _app as these will be
-      // needed for most requests
-      loadComponents({
-        distDir: this.distDir,
-        page: '/_document',
-        isAppPath: false,
-        isDev: this.isDev,
-        sriEnabled: this.sriEnabled,
-      }).catch(() => {})
-      loadComponents({
-        distDir: this.distDir,
-        page: '/_app',
-        isAppPath: false,
-        isDev: this.isDev,
-        sriEnabled: this.sriEnabled,
-      }).catch(() => {})
-    }
-
     if (
       !options.dev &&
       !this.minimalMode &&