helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: fix: `assert.ok` in the renderer process

Backport of #46528.

See that PR for details.

Notes: Fixed an issue with the `assert` Node.js module in the renderer process.

Changed files:
filename: patches/node/feat_add_oom_error_callback_in_node_isolatesettings.patch
patch: @@ -13,7 +13,7 @@ To fix this issue, provide the interface oom_error_callback to enable a
 custom oom error callback set from Electron.
 
 diff --git a/src/api/environment.cc b/src/api/environment.cc
-index 32fc075e97eebca6c47e796ac5308915746ffa2a..e72bee385865c7d34e9eea6b90c6d911d592f8af 100644
+index fc9b056d2f7e25109100fbde5f3ab0aebc8c619a..9b155213ce301df7e396a4a113992499fc7e9910 100644
 --- a/src/api/environment.cc
 +++ b/src/api/environment.cc
 @@ -241,7 +241,10 @@ void SetIsolateErrorHandlers(v8::Isolate* isolate, const IsolateSettings& s) {

filename: patches/node/fix_assert_module_in_the_renderer_process.patch
patch: @@ -43,20 +43,6 @@ index 59b5a16f1309a5e4055bccfdb7a529045ad30402..bfdaf6211466a01b64b7942f7b16c480
  
    let filename = call.getFileName();
    const line = call.getLineNumber() - 1;
-diff --git a/src/api/environment.cc b/src/api/environment.cc
-index fc9b056d2f7e25109100fbde5f3ab0aebc8c619a..32fc075e97eebca6c47e796ac5308915746ffa2a 100644
---- a/src/api/environment.cc
-+++ b/src/api/environment.cc
-@@ -247,6 +247,9 @@ void SetIsolateErrorHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
-     auto* prepare_stack_trace_cb = s.prepare_stack_trace_callback ?
-         s.prepare_stack_trace_callback : PrepareStackTraceCallback;
-     isolate->SetPrepareStackTraceCallback(prepare_stack_trace_cb);
-+  } else {
-+    auto env = Environment::GetCurrent(isolate);
-+    env->set_prepare_stack_trace_callback(Local<Function>());
-   }
- }
- 
 diff --git a/src/node_options.cc b/src/node_options.cc
 index 3608ab2b4aeb09e985ca98e23f2dff23567ade71..620776c06d835eb1bfeed060751c570e8d435b29 100644
 --- a/src/node_options.cc

filename: spec/node-spec.ts
patch: @@ -983,6 +983,17 @@ describe('node feature', () => {
     });
   });
 
+  itremote('handles assert module assertions as expected', () => {
+    const assert = require('node:assert');
+    try {
+      assert.ok(false);
+      expect.fail('assert.ok(false) should throw');
+    } catch (err) {
+      console.log(err);
+      expect(err).to.be.instanceOf(assert.AssertionError);
+    }
+  });
+
   it('Can find a module using a package.json main field', () => {
     const result = childProcess.spawnSync(process.execPath, [path.resolve(fixtures, 'api', 'electron-main-module', 'app.asar')], { stdio: 'inherit' });
     expect(result.status).to.equal(0);
Repository: facebook/react
Pull request: Deprecate `renderToStaticNodeStream` (#28872)

This commit adds warnings indicating that `renderToStaticNodeStream` will be removed in an upcoming React release. This API has been legacy, is not widely used (renderToStaticMarkup is more common) and has semantically eqiuvalent implementations with renderToReadableStream and renderToPipeableStream.

landed in main in #28872 
changed the warning to match renderToNodeStream

Changed files:
filename: packages/react-dom/src/__tests__/ReactServerRendering-test.js
patch: @@ -620,17 +620,27 @@ describe('ReactDOMServer', () => {
   describe('renderToStaticNodeStream', () => {
     it('should generate simple markup', () => {
       const SuccessfulElement = React.createElement(() => <img />);
-      const response = ReactDOMServer.renderToStaticNodeStream(
-        SuccessfulElement,
-      );
-      expect(response.read().toString()).toMatch(new RegExp('<img' + '/>'));
+      expect(() => {
+        const response = ReactDOMServer.renderToStaticNodeStream(
+          SuccessfulElement,
+        );
+        expect(response.read().toString()).toMatch(new RegExp('<img' + '/>'));
+      }).toErrorDev('ReactDOMServer.renderToStaticNodeStream() is deprecated', {
+        withoutStack: true,
+      });
     });
 
     it('should handle errors correctly', () => {
       const FailingElement = React.createElement(() => {
         throw new Error('An Error');
       });
-      const response = ReactDOMServer.renderToStaticNodeStream(FailingElement);
+
+      let response;
+      expect(() => {
+        response = ReactDOMServer.renderToStaticNodeStream(FailingElement);
+      }).toErrorDev('ReactDOMServer.renderToStaticNodeStream() is deprecated', {
+        withoutStack: true,
+      });
       return new Promise(resolve => {
         response.once('error', () => {
           resolve();

filename: packages/react-dom/src/server/ReactDOMLegacyServerNodeStream.js
patch: @@ -100,6 +100,13 @@ function renderToStaticNodeStream(
   children: ReactNodeList,
   options?: ServerOptions,
 ): Readable {
+  if (__DEV__) {
+    console.error(
+      'ReactDOMServer.renderToStaticNodeStream() is deprecated.' +
+        ' Use ReactDOMServer.renderToPipeableStream() and wait to `pipe` until the `onAllReady`' +
+        ' callback has been called instead.',
+    );
+  }
   return renderToNodeStreamImpl(children, options, true);
 }
Repository: vercel/next.js
Pull request: [CNA] use linter preference

Linter preference is not used.

Changed files:
filename: packages/create-next-app/index.ts
patch: @@ -291,6 +291,11 @@ async function run(): Promise<void> {
         opts.biome = preferredLinter === 'biome'
         // No need to set noLinter flag since we check args at runtime
       } else {
+        const linterIndexMap = {
+          eslint: 0,
+          biome: 1,
+          none: 2,
+        }
         const { linter } = await prompts({
           onState: onPromptState,
           type: 'select',
@@ -313,7 +318,10 @@ async function run(): Promise<void> {
               description: 'Skip linter configuration',
             },
           ],
-          initial: 0,
+          initial:
+            linterIndexMap[
+              getPrefOrDefault('linter') as keyof typeof linterIndexMap
+            ],
         })
 
         opts.eslint = linter === 'eslint'
Repository: huggingface/transformers
Pull request: Set `test_all_params_have_gradient=False` for `DeepseekV2ModelTest`

# What does this PR do?

Same as #40530

Changed files:
filename: tests/models/deepseek_v2/test_modeling_deepseek_v2.py
patch: @@ -80,6 +80,7 @@ class DeepseekV2ModelTest(CausalLMModelTest, unittest.TestCase):
     test_pruning = False
     fx_compatible = False
     test_torchscript = False
+    test_all_params_have_gradient = False
     model_tester_class = DeepseekV2ModelTester
     rotary_embedding_layer = DeepseekV2RotaryEmbedding
     model_split_percents = [0.5, 0.7, 0.8]
Repository: vercel/next.js
Pull request: Turbopack: Un-deprecate the `TurbopackLoaderItem` type

It looks like this was accidentally deprecated as part of https://github.com/vercel/next.js/pull/77850 ?

- It suggests using `TurbopackRuleConfigItem` instead, but the required `loaders` field on `TurbopackRuleConfigItemOptions` uses it, so the type is unavoidable.
- Perhaps there was intent to deprecate the shortcut version of `TurbopackRuleConfigItemOrShortcut` (the shortcut syntax is undocumented), but it looks like Sentry uses it, so it's probably not worth getting rid of: https://sourcegraph.com/search?q=context:global+/turbopack:%28%5B%5E%7B%7D%5D%7C%5Cn%29*%7B%5B%5E%7B%7D%5D*rules:%5B%5E%7B%7D%5D*%7B%5B%5E%7B%5D*%5C%5B/&patternType=keyword&sm=0

Closes PACK-5370

Changed files:
filename: packages/next/src/server/config-shared.ts
patch: @@ -251,9 +251,6 @@ type JSONValue =
   | JSONValue[]
   | { [k: string]: JSONValue }
 
-/**
- * @deprecated Use `TurbopackRuleConfigItem` instead.
- */
 export type TurbopackLoaderItem =
   | string
   | {
Repository: nodejs/node
Pull request: doc: clarify triager role

highlight additional points around triager role

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/contributing/issues.md
patch: @@ -60,5 +60,17 @@ activities, such as applying labels and closing/reopening/assigning issues.
 For more information on the roles and permissions, see ["Permission levels for
 repositories owned by an organization"](https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization).
 
+When triagging issues and PRs:
+
+* Show patience and empathy, especially to first-time contributors.
+* Show no patience towards spam or troll, close the issue without interacting with it and
+  report the user to the moderation repository.
+* If you're not able to reproduce an issue, leave a comment asking for more info and
+  add the `needs more info` label.
+* Ideally issues should be closed only when they have been fixed or answered (and
+  merged for pull requests). Closing an issue (or PR) earlier can be seen as
+  dismissive from the point of view of the reporter/author.
+  Always try to communicate the reason for closing the issue/PR.
+
 [Node.js help repository]: https://github.com/nodejs/help/issues
 [Technical Steering Committee (TSC) repository]: https://github.com/nodejs/TSC/issues
Repository: ollama/ollama
Pull request: Add ollama.nvim to list of terminal links

`ollama.nvim` is a good plugin, uses the ollama API directly! 

Changed files:
filename: README.md
patch: @@ -232,6 +232,7 @@ See the [API documentation](./docs/api.md) for all endpoints.
 - [Ellama Emacs client](https://github.com/s-kostyaev/ellama)
 - [Emacs client](https://github.com/zweifisch/ollama)
 - [gen.nvim](https://github.com/David-Kunz/gen.nvim)
+- [ollama.nvim](https://github.com/nomnivore/ollama.nvim)
 - [gptel Emacs client](https://github.com/karthink/gptel)
 
 ### Libraries
Repository: huggingface/transformers
Pull request: pin `pytest-rerunfailures<16.0`

# What does this PR do?

Avoid failures due to https://github.com/pytest-dev/pytest-rerunfailures/issues/303

Changed files:
filename: setup.py
patch: @@ -152,7 +152,7 @@
     "pydantic>=2",
     "pytest>=7.2.0",
     "pytest-asyncio",
-    "pytest-rerunfailures",
+    "pytest-rerunfailures<16.0",
     "pytest-timeout",
     "pytest-xdist",
     "pytest-order",

filename: src/transformers/dependency_versions_table.py
patch: @@ -58,7 +58,7 @@
     "pydantic": "pydantic>=2",
     "pytest": "pytest>=7.2.0",
     "pytest-asyncio": "pytest-asyncio",
-    "pytest-rerunfailures": "pytest-rerunfailures",
+    "pytest-rerunfailures": "pytest-rerunfailures<16.0",
     "pytest-timeout": "pytest-timeout",
     "pytest-xdist": "pytest-xdist",
     "pytest-order": "pytest-order",
Repository: denoland/deno
Pull request: fix(ext/node): cpus() should not error when there's no cpu info

os.cpus() in Node returns an empty array if there is no cpu info. This is also specified in [its documentation](https://nodejs.org/api/os.html#oscpus:~:text=The%20array%20will%20be%20empty%20if%20no%20CPU%20information%20is%20available): "The array will be empty if no CPU information is available, such as if the /proc file system is unavailable." Currently, Deno throws an error instead.

Fixes #25929.

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

3. Ensure there are tests that cover the changes.
-->


Changed files:
filename: ext/node/ops/os/mod.rs
patch: @@ -24,9 +24,6 @@ pub enum OsError {
     #[inherit]
     PermissionCheckError,
   ),
-  #[class(type)]
-  #[error("Failed to get cpu info")]
-  FailedToGetCpuInfo,
   #[class(inherit)]
   #[error("Failed to get user info")]
   FailedToGetUserInfo(
@@ -276,7 +273,7 @@ where
     permissions.check_sys("cpus", "node:os.cpus()")?;
   }
 
-  cpus::cpu_info().ok_or(OsError::FailedToGetCpuInfo)
+  Ok(cpus::cpu_info().unwrap_or_default())
 }
 
 #[op2(stack_trace)]
Repository: electron/electron
Pull request: fix: window border on Gnome Wayland

Backport of #46624

See that PR for details.


Notes: Fixed an inverted conditional in the above PR that caused broken window borders in some circumstances on Wayland.


Changed files:
filename: shell/browser/ui/electron_desktop_window_tree_host_linux.cc
patch: @@ -204,7 +204,7 @@ void ElectronDesktopWindowTreeHostLinux::UpdateFrameHints() {
     if (ui::OzonePlatform::GetInstance()->IsWindowCompositingSupported()) {
       // Set the opaque region.
       std::vector<gfx::Rect> opaque_region;
-      if (!IsShowingFrame()) {
+      if (IsShowingFrame()) {
         // The opaque region is a list of rectangles that contain only fully
         // opaque pixels of the window.  We need to convert the clipping
         // rounded-rect into this format.
Repository: ggml-org/llama.cpp
Pull request: server : disable checkpoints with mtmd

fix #17043

Context checkpoints are not yet supported with `mtmd`, so disallow this logic.

Changed files:
filename: tools/server/server.cpp
patch: @@ -3832,7 +3832,9 @@ struct server_context {
                             // the largest pos_min required for a checkpoint to be useful
                             const auto pos_min_thold = std::max(0, n_past - n_swa);
 
-                            if (n_past > 0 && n_past < slot.prompt.n_tokens()) {
+                            // note: disallow with mtmd contexts for now
+                            //       https://github.com/ggml-org/llama.cpp/issues/17043
+                            if (!mctx && n_past > 0 && n_past < slot.prompt.n_tokens()) {
                                 const auto pos_min = llama_memory_seq_pos_min(llama_get_memory(ctx), slot.id);
                                 if (pos_min == -1) {
                                     SLT_ERR(slot, "n_past = %d, slot.prompt.tokens.size() = %d, seq_id = %d, pos_min = %d\n", n_past, (int) slot.prompt.tokens.size(), slot.id, pos_min);
Repository: nodejs/node
Pull request: test: close dirs in `fs-opendir` test

Two subtests in `test-fs-opendir.js` are not closing dir. Let's fix it.

Changed files:
filename: test/parallel/test-fs-opendir.js
patch: @@ -229,6 +229,7 @@ for (const bufferSize of ['', '1', null]) {
 async function doAsyncIterInvalidCallbackTest() {
   const dir = await fs.promises.opendir(testDir);
   assert.throws(() => dir.close('not function'), invalidCallbackObj);
+  dir.close();
 }
 doAsyncIterInvalidCallbackTest().then(common.mustCall());
 
@@ -257,6 +258,7 @@ doConcurrentAsyncAndSyncOps().then(common.mustCall());
 {
   const dir = fs.opendirSync(testDir);
   assert.throws(() => dir.read('INVALID_CALLBACK'), /ERR_INVALID_ARG_TYPE/);
+  dir.close();
 }
 
 // Check that concurrent read() operations don't do weird things.
Repository: huggingface/transformers
Pull request: Fix collated reports upload filename


Changed files:
filename: utils/collated_reports.py
patch: @@ -197,8 +197,9 @@ def upload_collated_report(job: str, report_repo_id: str, filename: str):
 
         collated_report_buffer.append(report)
 
+    filename = f"collated_reports_{machine_type}_{commit_hash}.json"
     # Write collated report
-    with open(f"collated_reports_{machine_type}_{commit_hash}.json", "w") as f:
+    with open(filename, "w") as f:
         json.dump(
             {
                 "gpu_name": gpu_name,
@@ -211,5 +212,6 @@ def upload_collated_report(job: str, report_repo_id: str, filename: str):
             indent=2,
         )
 
+    # Upload collated report
     if job and report_repo_id:
-        upload_collated_report(job, report_repo_id, f"collated_reports_{commit_hash}.json")
+        upload_collated_report(job, report_repo_id, filename)
Repository: ollama/ollama
Pull request: Fixed incorrect base model name

Added tag version to 'GetNamespaceRepository' method in order to set the correct model used model tag version.

(This PR fixes bug/issue: #946 )

Changed files:
filename: server/images.go
patch: @@ -397,7 +397,7 @@ func CreateModel(ctx context.Context, name string, path string, fn func(resp api
 					if err != nil {
 						return err
 					}
-					newLayer.From = mp.GetNamespaceRepository()
+					newLayer.From = mp.GetShortTagname()
 					layers = append(layers, newLayer)
 				}
 			}
Repository: electron/electron
Pull request: fix: window border on Gnome Wayland

#### Description of Change

Closes https://github.com/electron/electron/issues/46484.
Refs https://github.com/electron/electron/issues/46155.

Fixes an inverted conditional in the above PR that caused broken window borders in some circumstances on Wayland.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed an inverted conditional in the above PR that caused broken window borders in some circumstances on Wayland.


Changed files:
filename: shell/browser/ui/electron_desktop_window_tree_host_linux.cc
patch: @@ -195,7 +195,7 @@ void ElectronDesktopWindowTreeHostLinux::UpdateFrameHints() {
     if (ui::OzonePlatform::GetInstance()->IsWindowCompositingSupported()) {
       // Set the opaque region.
       std::vector<gfx::Rect> opaque_region;
-      if (!IsShowingFrame()) {
+      if (IsShowingFrame()) {
         // The opaque region is a list of rectangles that contain only fully
         // opaque pixels of the window.  We need to convert the clipping
         // rounded-rect into this format.
Repository: vercel/next.js
Pull request: [turbopack] Change execution and snapshot tests to check for the existence of files rather than directories

This fixes an annoying devex issue when switching branches

Closes PACK-5368

Changed files:
filename: turbopack/crates/turbopack-tests/tests/execution.rs
patch: @@ -102,8 +102,12 @@ fn register() {
 //
 // "Skip" directories named `__skipped__`, which include test directories to
 // skip.
-#[testing::fixture("tests/execution/*/*/*", exclude("node_modules|__skipped__"))]
+#[testing::fixture(
+    "tests/execution/*/*/*/input/index.js",
+    exclude("node_modules|__skipped__")
+)]
 fn test(resource: PathBuf) {
+    let resource = resource.parent().unwrap().parent().unwrap().to_path_buf();
     let messages = get_messages(run(resource, IssueSnapshotMode::Snapshots).unwrap());
     if !messages.is_empty() {
         panic!(
@@ -113,10 +117,10 @@ fn test(resource: PathBuf) {
     }
 }
 
-#[testing::fixture("tests/execution/*/*/__skipped__/*/input")]
+#[testing::fixture("tests/execution/*/*/__skipped__/*/input/index.js")]
 #[should_panic]
 fn test_skipped_fails(resource: PathBuf) {
-    let resource = resource.parent().unwrap().to_path_buf();
+    let resource = resource.parent().unwrap().parent().unwrap().to_path_buf();
 
     let JsResult {
         // Ignore uncaught exceptions for skipped tests.

filename: turbopack/crates/turbopack-tests/tests/snapshot.rs
patch: @@ -168,8 +168,9 @@ fn is_empty_dir_tree(dir_entries: impl IntoIterator<Item = io::Result<fs::DirEnt
     true
 }
 
-#[testing::fixture("tests/snapshot/*/*/", exclude("node_modules"))]
+#[testing::fixture("tests/snapshot/*/*/input/index.js", exclude("node_modules"))]
 fn test(resource: PathBuf) {
+    let resource = resource.parent().unwrap().parent().unwrap().to_path_buf();
     let resource = canonicalize(resource).unwrap();
 
     let mut has_output_dir = false;
Repository: ollama/ollama
Pull request: Add OllamaKit to the community integrations

Hello folks, I'm excited to share that I've been working on `OllamaKit`. Originally created for `Ollamac`, I've realized its potential extends to assisting anyone looking to integrate the Ollama API with Swift. 😃

Changed files:
filename: README.md
patch: @@ -242,6 +242,7 @@ See the [API documentation](./docs/api.md) for all endpoints.
 - [Ollama-rs for Rust](https://github.com/pepperoni21/ollama-rs)
 - [Ollama4j for Java](https://github.com/amithkoujalgi/ollama4j)
 - [ModelFusion Typescript Library](https://modelfusion.dev/integration/model-provider/ollama)
+- [OllamaKit for Swift](https://github.com/kevinhermawan/OllamaKit)
 
 ### Extensions & Plugins
Repository: facebook/react
Pull request: Add missing bundle types for ReactCacheOld

Add missing bundle types for ReactCacheOld

These are used at FB and we need to update them for the SecretInternals update.


Changed files:
filename: scripts/rollup/bundles.js
patch: @@ -879,9 +879,7 @@ const bundles = [
 
   /******* React Cache (experimental, old) *******/
   {
-    // This is only used by our own tests.
-    // We can delete it later.
-    bundleTypes: [NODE_DEV, NODE_PROD],
+    bundleTypes: [NODE_DEV, NODE_PROD, FB_WWW_DEV, FB_WWW_PROD],
     moduleType: ISOMORPHIC,
     entry: 'react-cache',
     global: 'ReactCacheOld',
Repository: electron/electron
Pull request: fix: window border on Gnome Wayland

Backport of #46624

See that PR for details.


Notes: Fixed an inverted conditional in the above PR that caused broken window borders in some circumstances on Wayland.


Changed files:
filename: shell/browser/ui/electron_desktop_window_tree_host_linux.cc
patch: @@ -192,7 +192,7 @@ void ElectronDesktopWindowTreeHostLinux::UpdateFrameHints() {
     if (ui::OzonePlatform::GetInstance()->IsWindowCompositingSupported()) {
       // Set the opaque region.
       std::vector<gfx::Rect> opaque_region;
-      if (!IsShowingFrame()) {
+      if (IsShowingFrame()) {
         // The opaque region is a list of rectangles that contain only fully
         // opaque pixels of the window.  We need to convert the clipping
         // rounded-rect into this format.