helloadhavan/github_issues huggingface dataset:
Repository: ggml-org/llama.cpp
Pull request: llama : fix typo in llama_set_embeddings comment


- [x] I have read the [contributing guidelines](https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md)
- Self-reported review complexity:
  - [x] Low
  - [ ] Medium
  - [ ] High


Changed files:
filename: llama.h
patch: @@ -786,7 +786,7 @@ extern "C" {
     // Get the number of threads used for prompt and batch processing (multiple token).
     LLAMA_API uint32_t llama_n_threads_batch(struct llama_context * ctx);
 
-    // Set whether the model is in embeddings model or not
+    // Set whether the model is in embeddings mode or not
     // If true, embeddings will be returned but logits will not
     LLAMA_API void llama_set_embeddings(struct llama_context * ctx, bool embeddings);
Repository: facebook/react
Pull request: DevTools: Fix Settings dialog scroll/size bug in Firefox

Resolves #21718

The reason for the difference between Firefox and Chrome is that the (supposedly hidden) `<input type=radio>` buttons used for the Tab bar accessibility isn't 0 width for Firefox. In addition to this, there was a bit too much content in the tab bar and it was crowding tabs, so I made it a little wider as well.

Changed files:
filename: packages/react-devtools-shared/src/devtools/views/Settings/SettingsModal.css
patch: @@ -22,7 +22,7 @@
   box-shadow: 0 2px 4px var(--color-shadow);
   border-radius: 0.25rem;
   overflow: auto;
-  width: 400px;
+  width: 410px;
   max-width: 100%;
 }
 

filename: packages/react-devtools-shared/src/devtools/views/TabBar.css
patch: @@ -10,6 +10,9 @@
   user-select: none;
   color: var(--color-text);
 
+  /* Hide radio buttons for Firefox too */
+  position:  relative;
+
   /* Electron drag area */
   -webkit-app-region: no-drag;
 }
@@ -48,6 +51,9 @@
   width: 0;
   margin: 0;
   opacity: 0;
+
+  /* Hide radio buttons for Firefox too */
+  position:  absolute;
 }
 
 .IconSizeNavigation,
Repository: nodejs/node
Pull request: doc: fix wrong verb form

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/modules.md
patch: @@ -208,7 +208,7 @@ regarding which files are parsed as ECMAScript modules.
   3. The file has a `.js` extension, the closest `package.json` does not contain
      `"type": "commonjs"`, and the module contains ES module syntax.
 
-If the ES Module being loaded meet the requirements, `require()` can load it and
+If the ES Module being loaded meets the requirements, `require()` can load it and
 return the module namespace object. In this case it is similar to dynamic
 `import()` but is run synchronously and returns the name space object
 directly.
Repository: denoland/deno
Pull request: fix(init): force --reload if npm or jsr package

Ref https://github.com/denoland/deno/issues/28148#issuecomment-2663189433

Changed files:
filename: cli/tools/init/mod.rs
patch: @@ -334,6 +334,7 @@ async fn init_npm(name: &str, args: Vec<String>) -> Result<i32, AnyError> {
       script: script_name,
       ..Default::default()
     }),
+    reload: true,
     ..Default::default()
   };
   crate::tools::run::run_script(
Repository: ggml-org/llama.cpp
Pull request: baby-llama : remove duplicate vector include


- [x] I have read the [contributing guidelines](https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md)
- Self-reported review complexity:
  - [x] Low
  - [ ] Medium
  - [ ] High


Changed files:
filename: examples/baby-llama/baby-llama.cpp
patch: @@ -1,7 +1,6 @@
 #include "ggml.h"
 #include "train.h"
 
-#include <vector>
 #include <cassert>
 #include <cstdlib>
 #include <cstring>
Repository: facebook/react
Pull request: Updated Copyright comment from Facebook to Meta

## Summary
Changed the comment in react/packages/react
/react.shared-subset.js saying 
```
Copyright (c) Facebook, Inc. and affiliates ..
```
To 
```
Copyright (c) Meta Platforms, Inc. and affiliates ..
```
as raised in the following issues: https://github.com/facebook/react/issues/26829

Files Changed: 
react/packages/react/react.shared-subset.js

## How did you test this change?

Tests Required: No


Changed files:
filename: packages/react/react.shared-subset.js
patch: @@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and its affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
Repository: huggingface/transformers
Pull request: fix: astronomical loss with ModernBERT when using gradient checkpointing (#38982)

@ArthurZucker @SunMarc This PR fixes #38982 by passing `kwargs` to `loss_function()` in the forward function for the ModernBERT MLM block -- no more astronomical loss when using gradient accumulation while training ModernBERT.

Changed files:
filename: src/transformers/models/modernbert/modeling_modernbert.py
patch: @@ -1071,7 +1071,7 @@ def forward(
 
         loss = None
         if labels is not None:
-            loss = self.loss_function(logits, labels, vocab_size=self.config.vocab_size)
+            loss = self.loss_function(logits, labels, vocab_size=self.config.vocab_size, **kwargs)
 
         if self.config._attn_implementation == "flash_attention_2":
             with nullcontext() if self.config.repad_logits_with_grad or labels is None else torch.no_grad():

filename: src/transformers/models/modernbert/modular_modernbert.py
patch: @@ -1201,7 +1201,7 @@ def forward(
 
         loss = None
         if labels is not None:
-            loss = self.loss_function(logits, labels, vocab_size=self.config.vocab_size)
+            loss = self.loss_function(logits, labels, vocab_size=self.config.vocab_size, **kwargs)
 
         if self.config._attn_implementation == "flash_attention_2":
             with nullcontext() if self.config.repad_logits_with_grad or labels is None else torch.no_grad():
Repository: denoland/deno
Pull request: fix(ext/node): use primordials in `ext/node/polyfills/path/common.ts`

Related to https://github.com/denoland/deno/issues/24236

Changed files:
filename: ext/node/polyfills/path/common.ts
patch: @@ -1,9 +1,16 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 // This module is browser compatible.
 
-// TODO(petamoriken): enable prefer-primordials for node polyfills
-// deno-lint-ignore-file prefer-primordials
-
+import { primordials } from "ext:core/mod.js";
+const {
+  StringPrototypeSubstring,
+  StringPrototypeLastIndexOf,
+  StringPrototypeSplit,
+  ArrayPrototypeSlice,
+  StringPrototypeEndsWith,
+  ArrayPrototypeJoin,
+  SafeArrayIterator,
+} = primordials;
 import { SEP } from "ext:deno_node/path/separator.ts";
 
 /** Determines the common path from a set of paths, using an optional separator,
@@ -18,15 +25,19 @@ import { SEP } from "ext:deno_node/path/separator.ts";
  * ```
  */
 export function common(paths: string[], sep = SEP): string {
-  const [first = "", ...remaining] = paths;
+  const [first = "", ...remaining] = new SafeArrayIterator(paths);
   if (first === "" || remaining.length === 0) {
-    return first.substring(0, first.lastIndexOf(sep) + 1);
+    return StringPrototypeSubstring(
+      first,
+      0,
+      StringPrototypeLastIndexOf(first, sep) + 1,
+    );
   }
-  const parts = first.split(sep);
+  const parts = StringPrototypeSplit(first, sep);
 
   let endOfPrefix = parts.length;
-  for (const path of remaining) {
-    const compare = path.split(sep);
+  for (const path of new SafeArrayIterator(remaining)) {
+    const compare = StringPrototypeSplit(path, sep);
     for (let i = 0; i < endOfPrefix; i++) {
       if (compare[i] !== parts[i]) {
         endOfPrefix = i;
@@ -37,6 +48,9 @@ export function common(paths: string[], sep = SEP): string {
       return "";
     }
   }
-  const prefix = parts.slice(0, endOfPrefix).join(sep);
-  return prefix.endsWith(sep) ? prefix : `${prefix}${sep}`;
+  const prefix = ArrayPrototypeJoin(
+    ArrayPrototypeSlice(parts, 0, endOfPrefix),
+    sep,
+  );
+  return StringPrototypeEndsWith(prefix, sep) ? prefix : `${prefix}${sep}`;
 }
Repository: ggml-org/llama.cpp
Pull request: llama: remove redundant reshape in build_kv_store

This commit removes the reshape of the V matrix in the build_kv_store.

The motivation for this is that V matrix has the shape:
```console
(gdb) p *v_cur
$46 = {type = GGML_TYPE_F32, backend = GGML_BACKEND_TYPE_CPU,
       buffer = 0x0, ne = {4096, 512, 1, 1}, nb = {4, 16384, 8388608,
       8388608}, op = GGML_OP_MUL_MAT, op_params = {
       0 <repeats 16 times>}, flags = 0, grad = 0x0,
       src = {0xb496b0, 0x7ffef1c40950, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
       0x0, 0x0}, perf_runs = 0, perf_cycles = 0, perf_time_us = 0,
       view_src = 0x0, view_offs = 0, data = 0x0,
       name = "Vcur-0", '\000' <repeats 57 times>, extra = 0x0,
       padding = "\000\000\000\000\000\000\000"}
```
And after reshaping this tensor we get:
```console
gdb) p *ggml_reshape_2d(ctx, v_cur, n_embd_v_gqa, n_tokens)
$44 = {type = GGML_TYPE_F32, backend = GGML_BACKEND_TYPE_CPU,
       buffer = 0x0, ne = {4096, 512, 1, 1}, nb = {4, 16384, 8388608,
       8388608}, op = GGML_OP_RESHAPE, op_params = {
       0 <repeats 16 times>}, flags = 0, grad = 0x0,
       src = {0x7ffef1c40e00, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
       0x0}, perf_runs = 0, perf_cycles = 0, perf_time_us = 0,
       view_src = 0x7ffef1c40e00, view_offs = 0, data = 0x0,
       name = "Vcur-0 (reshaped)", '\000' <repeats 46 times>, extra = 0x0,
       padding = "\000\000\000\000\000\000\000"}
```
I noticed that the `src` and `view_src` fields are different but that the dimensions are the same. From the code comment it seems like the reshape call is not needed and perhaps the above can motivate the removal of the reshape call.

Changed files:
filename: llama.cpp
patch: @@ -5523,8 +5523,8 @@ static void llm_build_kv_store(
     GGML_ASSERT(kv.size == n_ctx);
 
     // compute the transposed [n_tokens, n_embd] V matrix
-    struct ggml_tensor * v_cur_t = ggml_transpose(ctx, ggml_reshape_2d(ctx, v_cur, n_embd_v_gqa, n_tokens));
-    //struct ggml_tensor * v_cur_t = ggml_transpose(ctx, v_cur); // TODO: reshape above is likely not needed
+    assert(v_cur->ne[0] == n_embd_v_gqa && v_cur->ne[1] == n_tokens);
+    struct ggml_tensor * v_cur_t = ggml_transpose(ctx, v_cur);
     cb(v_cur_t, "v_cur_t", il);
 
     struct ggml_tensor * k_cache_view = ggml_view_1d(ctx, kv.k_l[il], n_tokens*n_embd_k_gqa,
Repository: ggml-org/llama.cpp
Pull request: ci : add fetch-depth to xcframework upload

This commit adds the fetch-depth: 0 option to the checkout action in the build.yml workflow file (0 meaning that it fetches the complete history). The default value is 1 when not specified which only fetches the latest commit.

This is necessary to ensure that `git rev-list --count HEAD` counts the total number of commits in the history. Currently because the default is being used the name of the xcframework artifact is always llama-b1-xcframework.

----
Sorry about the many attempts to try to address this :disappointed:  This time I verified that this works on a separate repository. 

Changed files:
filename: .github/workflows/build.yml
patch: @@ -1320,6 +1320,8 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
       - name: Build
         id: cmake_build
Repository: ggml-org/llama.cpp
Pull request: ci : fix xcframework artifact tag

The commit add the name parameter to the upload-artifact action to ensure that the artifact is uploaded with the correct name.

The motivation for this is that currently the uploaded xcframework is named as llama-b1-xcframework.zip. With this change the name of this artifact should contain the build number like the other artifacts.


Changed files:
filename: .github/workflows/build.yml
patch: @@ -1368,6 +1368,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           path: llama-${{ steps.tag.outputs.name }}-xcframework.zip
+          name: llama-${{ steps.tag.outputs.name }}-xcframework
 
   android-build:
     runs-on: ubuntu-latest
Repository: nodejs/node
Pull request: module: remove unnecessary `readPackage` function

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: lib/internal/modules/cjs/loader.js
patch: @@ -478,7 +478,7 @@ function initializeCJS() {
 //   -> a.<ext>
 //   -> a/index.<ext>
 
-let _readPackage = packageJsonReader.readPackage;
+let _readPackage = (requestPath) => packageJsonReader.read(path.resolve(requestPath, 'package.json'));
 ObjectDefineProperty(Module, '_readPackage', {
   __proto__: null,
   get() { return _readPackage; },

filename: lib/internal/modules/package_json_reader.js
patch: @@ -124,17 +124,6 @@ function read(jsonPath, { base, specifier, isESM } = kEmptyObject) {
   };
 }
 
-/**
- * @deprecated Expected to be removed in favor of `read` in the future.
- * Behaves the same was as `read`, but appends package.json to the path.
- * @param {string} requestPath
- * @return {PackageConfig}
- */
-function readPackage(requestPath) {
-  // TODO(@anonrig): Remove this function.
-  return read(path.resolve(requestPath, 'package.json'));
-}
-
 /**
  * Get the nearest parent package.json file from a given path.
  * Return the package.json data and the path to the package.json file, or undefined.
@@ -320,7 +309,6 @@ function findPackageJSON(specifier, base = 'data:') {
 
 module.exports = {
   read,
-  readPackage,
   getNearestParentPackageJSON,
   getPackageScopeConfig,
   getPackageType,
Repository: facebook/react
Pull request: Fix strict mode badge URL

## Summary
Closes https://github.com/facebook/react/issues/26821

[[Fix #26821]](https://github.com/facebook/react/issues/26821) Update strict mode badge URL


Updated the URL in the strict mode badge to point to the correct React documentation for StrictMode. The previous URL was outdated. Now, when a component is not running in StrictMode, the badge links to https://react.dev/reference/react/StrictMode for more information.


## How did you test this change?

I verified that the strict mode badge now correctly links to the updated URL. Previously, it pointed to the outdated URL (https://fb.me/devtools-strict-mode). After the update, it correctly points to the React Dev documentation for StrictMode (https://react.dev/reference/react/StrictMode).


_Since its my first contribution here, i have completed the CLA_ 
 

Changed files:
filename: packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js
patch: @@ -237,7 +237,7 @@ export default function InspectedElementWrapper(_: Props): React.Node {
     strictModeBadge = (
       <a
         className={styles.StrictModeNonCompliant}
-        href="https://fb.me/devtools-strict-mode"
+        href="https://react.dev/reference/react/StrictMode"
         rel="noopener noreferrer"
         target="_blank"
         title="This component is not running in StrictMode. Click to learn more.">
Repository: facebook/react
Pull request: Lower Suspense throttling heuristic to 300ms

Now that the throttling mechanism applies more often, we've decided to lower this a tad to ensure it's not noticeable. The idea is it should be just large enough to prevent jank when lots of different parts of the UI load in rapid succession, but not large enough to make the UI feel sluggish. There's no perfect number, it's just a heuristic.

Changed files:
filename: packages/react-reconciler/src/ReactFiberWorkLoop.js
patch: @@ -375,7 +375,7 @@ let workInProgressRootRecoverableErrors: Array<CapturedValue<mixed>> | null =
 // content as it streams in, to minimize jank.
 // TODO: Think of a better name for this variable?
 let globalMostRecentFallbackTime: number = 0;
-const FALLBACK_THROTTLE_MS: number = 500;
+const FALLBACK_THROTTLE_MS: number = 300;
 
 // The absolute time for when we should start giving up on rendering
 // more and prefer CPU suspense heuristics instead.

filename: packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
patch: @@ -1863,8 +1863,8 @@ describe('ReactSuspenseWithNoopRenderer', () => {
     // Advance by a small amount of time. For testing purposes, this is meant
     // to be just under the throttling interval. It's a heurstic, though, so
     // if we adjust the heuristic we might have to update this test, too.
-    Scheduler.unstable_advanceTime(400);
-    jest.advanceTimersByTime(400);
+    Scheduler.unstable_advanceTime(200);
+    jest.advanceTimersByTime(200);
 
     // Now resolve B.
     await act(async () => {
Repository: ggml-org/llama.cpp
Pull request: ci : add --symlinks to xcframework zip command

This commit adds the `--symlinks` option to the zip command used to create the xcframework zip file. This is necessary to create symlinks in the zip file. Without this option,  the Versions symlink is stored as a regular directory entry in the zip file, rather than as a symlink in the zip which causes the followig error in xcode:
```console
Couldn't resolve framework symlink for '/Users/danbev/work/ai/llama.cpp/tmp_1/build-apple/llama.xcframework/macos-arm64_x86_64/llama.framework/Versions/Current': readlink(/Users/danbev/work/ai/llama.cpp/tmp_1/build-apple/llama.xcframework/macos-arm64_x86_64/llama.framework/Versions/Current): Invalid argument (22)
```

Refs: https://github.com/ggml-org/llama.cpp/pull/11996#issuecomment-2727026377


Changed files:
filename: .github/workflows/build.yml
patch: @@ -1379,7 +1379,7 @@ jobs:
         id: pack_artifacts
         if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
         run: |
-          zip -r llama-${{ steps.tag.outputs.name }}-xcframework.zip build-apple/llama.xcframework
+          zip --symlinks -r llama-${{ steps.tag.outputs.name }}-xcframework.zip build-apple/llama.xcframework
 
       - name: Upload artifacts
         if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
Repository: vercel/next.js
Pull request: Turbopack: use correct mark for swc

Not sure how this happened


<img width="756" alt="Bildschirmfoto 2025-06-23 um 10 50 52" src="https://github.com/user-attachments/assets/63a0f991-f115-43b6-a179-b2a6ef96ba3c" />


Closes PACK-4876

Changed files:
filename: turbopack/crates/turbopack-ecmascript/src/transform/mod.rs
patch: @@ -244,7 +244,7 @@ impl EcmascriptInputTransform {
                     program,
                     helpers,
                     preset_env::transform_from_env::<&'_ dyn Comments>(
-                        top_level_mark,
+                        unresolved_mark,
                         Some(&comments),
                         config,
                         Assumptions::default(),
Repository: denoland/deno
Pull request: perf(lsp): make auto-imports a little faster


Changed files:
filename: cli/tsc/00_typescript.js
patch: @@ -125170,14 +125170,6 @@ function changeCompilerHostLikeToUseCache(host, toPath3, getSourceFile) {
     }
     return sourceFile;
   } : void 0;
-  host.fileExists = (fileName) => {
-    const key = toPath3(fileName);
-    const value = fileExistsCache.get(key);
-    if (value !== void 0) return value;
-    const newValue = originalFileExists.call(host, fileName);
-    fileExistsCache.set(key, !!newValue);
-    return newValue;
-  };
   if (originalWriteFile) {
     host.writeFile = (fileName, data, ...rest) => {
       const key = toPath3(fileName);
@@ -165768,10 +165760,6 @@ function getDefaultCommitCharacters(isNewIdentifierLocation) {
   return allCommitCharacters;
 }
 function getCompletionsAtPosition(host, program, log, sourceFile, position, preferences, triggerCharacter, completionKind, cancellationToken, formatContext, includeSymbol = false) {
-  return spanned("Tsc::getCompletionsAtPosition", () => getCompletionsAtPositionInner(host, program, log, sourceFile, position, preferences, triggerCharacter, completionKind, cancellationToken, formatContext, includeSymbol));
-}
-
-function getCompletionsAtPositionInner(host, program, log, sourceFile, position, preferences, triggerCharacter, completionKind, cancellationToken, formatContext, includeSymbol = false) {
   var _a;
   const { previousToken } = getRelevantTokens(position, sourceFile);
   if (triggerCharacter && !isInString(sourceFile, position, previousToken) && !isValidTrigger(sourceFile, triggerCharacter, previousToken, position)) {

filename: cli/tsc/97_ts_host.js
patch: @@ -732,6 +732,12 @@ const hostImpl = {
     }
     return scriptSnapshot;
   },
+  getNearestAncestorDirectoryWithPackageJson() {
+    // always return `undefined` in order to short-circuit
+    // a codepath in the TypeScript compiler that always
+    // ends up returning `undefined` in Deno anyway
+    return undefined;
+  },
 };
 
 // these host methods are super noisy (often thousands of calls per TSC request)