helloadhavan/github_issues huggingface dataset:
Repository: ollama/ollama
Pull request: Update faq.md

Fix a typo in the CA update command

Changed files:
filename: docs/faq.md
patch: @@ -139,7 +139,7 @@ Ensure the certificate is installed as a system certificate when using HTTPS. Th
 ```dockerfile
 FROM ollama/ollama
 COPY my-ca.pem /usr/local/share/ca-certificates/my-ca.crt
-RUN update-ca-certificate
+RUN update-ca-certificates
 ```
 
 Build and run this image:
Repository: facebook/react
Pull request: Allow specifying timeout in tests via third argument

## Summary

Enables extending the timeout via `test(name, callback, timeoutMS)` when the test is gated. Extending the timeout is mostly useful with a debugger attached. With the debugger attached, you easily exceed the 5s timeout.


## How did you test this change?

- Added third argument to https://github.com/facebook/react/blob/8d41ed869e0283a661299765c563e462c9e78799/packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js#L816 and was able to debug tests for minutes without Jest aborting during a yield.


Changed files:
filename: scripts/jest/setupTests.js
patch: @@ -206,44 +206,55 @@ if (process.env.REACT_CLASS_EQUIVALENCE_TEST) {
   };
 
   const gatedErrorMessage = 'Gated test was expected to fail, but it passed.';
-  global._test_gate = (gateFn, testName, callback) => {
+  global._test_gate = (gateFn, testName, callback, timeoutMS) => {
     let shouldPass;
     try {
       const flags = getTestFlags();
       shouldPass = gateFn(flags);
     } catch (e) {
-      test(testName, () => {
-        throw e;
-      });
+      test(
+        testName,
+        () => {
+          throw e;
+        },
+        timeoutMS
+      );
       return;
     }
     if (shouldPass) {
-      test(testName, callback);
+      test(testName, callback, timeoutMS);
     } else {
       const error = new Error(gatedErrorMessage);
       Error.captureStackTrace(error, global._test_gate);
       test(`[GATED, SHOULD FAIL] ${testName}`, () =>
-        expectTestToFail(callback, error));
+        expectTestToFail(callback, error, timeoutMS));
     }
   };
-  global._test_gate_focus = (gateFn, testName, callback) => {
+  global._test_gate_focus = (gateFn, testName, callback, timeoutMS) => {
     let shouldPass;
     try {
       const flags = getTestFlags();
       shouldPass = gateFn(flags);
     } catch (e) {
-      test.only(testName, () => {
-        throw e;
-      });
+      test.only(
+        testName,
+        () => {
+          throw e;
+        },
+        timeoutMS
+      );
       return;
     }
     if (shouldPass) {
-      test.only(testName, callback);
+      test.only(testName, callback, timeoutMS);
     } else {
       const error = new Error(gatedErrorMessage);
       Error.captureStackTrace(error, global._test_gate_focus);
-      test.only(`[GATED, SHOULD FAIL] ${testName}`, () =>
-        expectTestToFail(callback, error));
+      test.only(
+        `[GATED, SHOULD FAIL] ${testName}`,
+        () => expectTestToFail(callback, error),
+        timeoutMS
+      );
     }
   };
Repository: nodejs/node
Pull request: doc: remove mhdawson from security steward rotation

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/contributing/security-release-process.md
patch: @@ -41,7 +41,6 @@ The current security stewards are documented in the main Node.js
 | IBM          | Joe             |              |
 | Platformatic | Matteo          |              |
 | NodeSource   | Juan            |              |
-| Red Hat      | Michael         |              |
 
 ## Planning
Repository: huggingface/transformers
Pull request: Fixed incorrect normalization

I've notices a possible typo in [s`rc/transformers/image_processing_utils_fast.py#compile_friendly_resize`](https://github.com/huggingface/transformers/blob/c81723d31b8a532803feee2bbce66e4f03829759/src/transformers/image_processing_utils_fast.py#L307) for `uin8` the normalization is done slightly off with `256` instead of `255`, which still works because its done consistenly (its normalized and denormalized the same way) incorrect.

[image = image.float() / 256](https://github.com/huggingface/transformers/blob/c81723d31b8a532803feee2bbce66e4f03829759/src/transformers/image_processing_utils_fast.py#L307)
[image = image * 256](https://github.com/huggingface/transformers/blob/c81723d31b8a532803feee2bbce66e4f03829759/src/transformers/image_processing_utils_fast.py#L309C13-L309C32)

The exaplanation is simple:

`255` (the max value for a uint8) should map to `1.` but it doesn't with the current implementation

Changed files:
filename: src/transformers/image_processing_utils_fast.py
patch: @@ -304,9 +304,9 @@ def compile_friendly_resize(
         A wrapper around `F.resize` so that it is compatible with torch.compile when the image is a uint8 tensor.
         """
         if image.dtype == torch.uint8:
-            image = image.float() / 256
+            image = image.float() / 255
             image = F.resize(image, new_size, interpolation=interpolation, antialias=antialias)
-            image = image * 256
+            image = image * 255
             image = torch.where(image > 255, 255, image)
             image = torch.where(image < 0, 0, image)
             image = image.round().to(torch.uint8)
Repository: ggml-org/llama.cpp
Pull request: metal : enable tensor API for A19

ref https://x.com/p3ery/status/1986505003683520758

Use the tensor API for new A19 mobile chips.

Changed files:
filename: ggml/src/ggml-metal/ggml-metal-device.m
patch: @@ -564,8 +564,10 @@ ggml_metal_device_t ggml_metal_device_init(void) {
             // TODO: try to update the tensor API kernels to at least match the simdgroup performance
             if (getenv("GGML_METAL_TENSOR_ENABLE") == NULL &&
                 ![[dev->mtl_device name] containsString:@"M5"] &&
-                ![[dev->mtl_device name] containsString:@"M6"]) {
-                GGML_LOG_WARN("%s: tensor API disabled for pre-M5 device\n", __func__);
+                ![[dev->mtl_device name] containsString:@"M6"] &&
+                ![[dev->mtl_device name] containsString:@"A19"] &&
+                ![[dev->mtl_device name] containsString:@"A20"]) {
+                GGML_LOG_WARN("%s: tensor API disabled for pre-M5 and pre-A19 devices\n", __func__);
                 dev->props.has_tensor = false;
             }
Repository: facebook/react
Pull request: Set enableUseMemoCacheHook to true everywhere

Set enableUseMemoCacheHook to true everywhere

Any reason we should have this disabled anywhere? I think we're set on the API?


Changed files:
filename: packages/shared/ReactFeatureFlags.js
patch: @@ -104,7 +104,7 @@ export const enableCPUSuspense = __EXPERIMENTAL__;
 
 // Enables useMemoCache hook, intended as a compilation target for
 // auto-memoization.
-export const enableUseMemoCacheHook = __EXPERIMENTAL__;
+export const enableUseMemoCacheHook = true;
 // Test this at Meta before enabling.
 export const enableNoCloningMemoCache = false;
 

filename: packages/shared/forks/ReactFeatureFlags.native-oss.js
patch: @@ -62,7 +62,7 @@ export const enableServerComponentLogs = __NEXT_RN_MAJOR__;
 export const debugRenderPhaseSideEffectsForStrictMode = __DEV__;
 
 // TODO: decide on React 19
-export const enableUseMemoCacheHook = false;
+export const enableUseMemoCacheHook = true;
 export const enableNoCloningMemoCache = false;
 export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__;
 

filename: packages/shared/forks/ReactFeatureFlags.test-renderer.js
patch: @@ -36,7 +36,7 @@ export const disableTextareaChildren = false;
 export const enableSuspenseAvoidThisFallback = false;
 export const enableSuspenseAvoidThisFallbackFizz = false;
 export const enableCPUSuspense = false;
-export const enableUseMemoCacheHook = __EXPERIMENTAL__;
+export const enableUseMemoCacheHook = true;
 export const enableNoCloningMemoCache = false;
 export const enableUseEffectEventHook = false;
 export const favorSafetyOverHydrationPerf = true;
Repository: facebook/react
Pull request: Setup Wave 2 of Feature Flags for React Native

## Summary

Sets up dynamic feature flags for `disableStringRefs`, `enableFastJSX`, and `enableRefAsProp` in React Native (at Meta).

## How did you test this change?

```
$ yarn test
$ yarn flow fabric
```

Changed files:
filename: packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
patch: @@ -19,10 +19,13 @@
 
 export const alwaysThrottleRetries = __VARIANT__;
 export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
-export const enableEarlyReturnForPropDiffing = __VARIANT__;
+export const disableDefaultPropsExceptForClasses = __VARIANT__;
+export const disableStringRefs = __VARIANT__;
+export const enableAddPropertiesFastPath = __VARIANT__;
 export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
+export const enableEarlyReturnForPropDiffing = __VARIANT__;
+export const enableFastJSX = __VARIANT__;
 export const enableInfiniteRenderLoopDetection = __VARIANT__;
+export const enableRefAsProp = __VARIANT__;
 export const enableUnifiedSyncLane = __VARIANT__;
 export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
-export const disableDefaultPropsExceptForClasses = __VARIANT__;
-export const enableAddPropertiesFastPath = __VARIANT__;

filename: packages/shared/forks/ReactFeatureFlags.native-fb.js
patch: @@ -21,13 +21,16 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
 export const {
   alwaysThrottleRetries,
   consoleManagedByDevToolsDuringStrictMode,
-  enableEarlyReturnForPropDiffing,
+  disableDefaultPropsExceptForClasses,
+  disableStringRefs,
+  enableAddPropertiesFastPath,
   enableDeferRootSchedulingToMicrotask,
+  enableEarlyReturnForPropDiffing,
+  enableFastJSX,
   enableInfiniteRenderLoopDetection,
+  enableRefAsProp,
   enableUnifiedSyncLane,
   passChildrenWhenCloningPersistedNodes,
-  disableDefaultPropsExceptForClasses,
-  enableAddPropertiesFastPath,
 } = dynamicFlags;
 
 // The rest of the flags are static for better dead code elimination.
@@ -94,12 +97,6 @@ export const disableClientCache = true;
 export const enableServerComponentKeys = true;
 export const enableServerComponentLogs = true;
 
-// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
-// because JSX is an extremely hot path.
-export const enableRefAsProp = false;
-export const disableStringRefs = false;
-export const enableFastJSX = false;
-
 export const enableReactTestRendererWarning = false;
 export const disableLegacyMode = false;
 export const disableDOMTestUtils = false;

filename: packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
patch: @@ -80,9 +80,9 @@ export const disableClientCache = true;
 export const enableServerComponentKeys = true;
 export const enableServerComponentLogs = true;
 
-export const enableRefAsProp = false;
-export const disableStringRefs = false;
-export const enableFastJSX = false;
+export const enableRefAsProp = true;
+export const disableStringRefs = true;
+export const enableFastJSX = true;
 
 export const enableReactTestRendererWarning = false;
 export const disableLegacyMode = false;
Repository: vercel/next.js
Pull request: fix: remove redundant posix normalization

See https://github.com/vercel/next.js/pull/83192#discussion_r2308660568

Changed files:
filename: packages/next/src/lib/typescript/writeAppTypeDeclarations.ts
patch: @@ -62,13 +62,8 @@ export async function writeAppTypeDeclarations({
     'types/routes.d.ts'
   )
 
-  // Ensure the path is POSIX-compliant for imports.
-  const routeTypesPathPosix = routeTypesPath
-    .split(path.sep)
-    .join(path.posix.sep)
-
   // Use ESM import instead of triple-slash reference for better ESLint compatibility
-  directives.push(`import "./${routeTypesPathPosix}";`)
+  directives.push(`import "./${routeTypesPath}";`)
 
   // Push the notice in.
   directives.push(
Repository: ollama/ollama
Pull request: Add Amica to community integrations

Hi!

This adds Amica (https://github.com/semperai/amica) to community integrations. 

Using ollama is very simple with Amica:

`settings -> chatbot -> chatbot backend -> select ollama`

Thanks for ollama it is a great project!

Changed files:
filename: README.md
patch: @@ -230,6 +230,7 @@ See the [API documentation](./docs/api.md) for all endpoints.
 - [Ollamac](https://github.com/kevinhermawan/Ollamac)
 - [big-AGI](https://github.com/enricoros/big-agi/blob/main/docs/config-ollama.md)
 - [Cheshire Cat assistant framework](https://github.com/cheshire-cat-ai/core)
+- [Amica](https://github.com/semperai/amica)
 
 ### Terminal
Repository: denoland/deno
Pull request: test: ignore flaky wpt test

This test is flaking from time to time and so far no resolution, ignoring to keep
CI helathy for now.

Changed files:
filename: tests/wpt/runner/expectation.json
patch: @@ -6140,9 +6140,9 @@
       "constructors.html": false,
       "default-iterator-object.html": true,
       "default-toJSON-cross-realm.html": false,
-      "global-immutable-prototype.any.worker.html": [
-        "Setting to a different prototype"
-      ],
+      "global-immutable-prototype.any.worker.html": {
+        "ignore": true
+      },
       "global-object-implicit-this-value-cross-realm.html": false,
       "has-instance.html": [
         "Manually-constructed prototype chains are correctly handled by instanceof",
Repository: facebook/react
Pull request: Add FB build for ReactReconcilerConstants

In order to integrate the `react-reconciler` build created in #28880 with third party libraries, we need to have matching `react-reconciler/constants` to go with it.


Changed files:
filename: scripts/rollup/bundles.js
patch: @@ -884,7 +884,7 @@ const bundles = [
   /******* Reconciler Constants *******/
   {
     moduleType: RENDERER_UTILS,
-    bundleTypes: [NODE_DEV, NODE_PROD],
+    bundleTypes: [NODE_DEV, NODE_PROD, FB_WWW_DEV, FB_WWW_PROD],
     entry: 'react-reconciler/constants',
     global: 'ReactReconcilerConstants',
     minifyWithProdErrorCodes: true,
Repository: electron/electron
Pull request: fix: crash on reconversion with google IME and editcontext on macOS

Backport of #46688

See that PR for details.


Notes: fix crash on reconversion with google IME and editcontext on macOS

Changed files:
filename: patches/chromium/.patches
patch: @@ -153,3 +153,4 @@ fix_take_snapped_status_into_account_when_showing_a_window.patch
 chore_modify_chromium_handling_of_mouse_events.patch
 cherry-pick-b8f80176b163.patch
 fix_false_activation_logic_for_context_menu.patch
+mac_fix_check_on_ime_reconversion_due_to_invalid_replacement_range.patch

filename: patches/chromium/mac_fix_check_on_ime_reconversion_due_to_invalid_replacement_range.patch
patch: @@ -0,0 +1,43 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Keren Zhu <kerenzhu@chromium.org>
+Date: Fri, 18 Apr 2025 11:02:46 -0700
+Subject: mac: fix CHECK on IME reconversion due to invalid replacement range
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+It appears that Google Japanese IME can call -setMarkedText: with an
+invalid replacement range when doing text reconversion (変換, i.e.,
+conversion between different text with same pronunciation). This range
+is a NSRange and NSRange.location is supposed to be NSNotFound (2^31-1)
+for invalid range, but the IME can pass in 2^32. Subsequently causing
+CHECK error.
+
+This CL fixes the issue by converting such invalid NSRange to
+gfx::InvalidRange using FromPossiblyInvalidNSRange(range).
+
+Fixed: 409864204
+Change-Id: I08ff426a933ef76aa81e33af59aa32e2ac0b674d
+Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6470915
+Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
+Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
+Cr-Commit-Position: refs/heads/main@{#1448935}
+
+diff --git a/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm b/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
+index c89f25bf49d773f5f77b2434bd6fabcfd8cb4e33..87c5c0b3d04769dcbcf43880d5ec88dea93b4d58 100644
+--- a/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
++++ b/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
+@@ -2337,9 +2337,10 @@ - (void)setMarkedText:(id)string
+   if ([self isHandlingKeyDown] && !_isReconversionTriggered) {
+     _setMarkedTextReplacementRange = gfx::Range(replacementRange);
+   } else {
+-    _host->ImeSetComposition(_markedText, _imeTextSpans,
+-                             gfx::Range(replacementRange), newSelRange.location,
+-                             NSMaxRange(newSelRange));
++    _host->ImeSetComposition(
++        _markedText, _imeTextSpans,
++        gfx::Range::FromPossiblyInvalidNSRange(replacementRange),
++        newSelRange.location, NSMaxRange(newSelRange));
+   }
+ 
+   [[self inputContext] invalidateCharacterCoordinates];
Repository: vercel/next.js
Pull request: Make FileSourceReference traced

This is needed for

```
fs.readFileSync(process.cwd() + "/static.txt")
```

Closes PACK-5385

Changed files:
filename: turbopack/crates/turbopack-ecmascript/src/references/raw.rs
patch: @@ -3,6 +3,7 @@ use tracing::Instrument;
 use turbo_rcstr::RcStr;
 use turbo_tasks::{ResolvedVc, ValueToString, Vc};
 use turbopack_core::{
+    chunk::{ChunkableModuleReference, ChunkingType, ChunkingTypeOption},
     reference::ModuleReference,
     resolve::{ModuleResolveResult, pattern::Pattern, resolve_raw},
     source::Source,
@@ -44,6 +45,14 @@ impl ModuleReference for FileSourceReference {
     }
 }
 
+#[turbo_tasks::value_impl]
+impl ChunkableModuleReference for FileSourceReference {
+    #[turbo_tasks::function]
+    fn chunking_type(&self) -> Vc<ChunkingTypeOption> {
+        Vc::cell(Some(ChunkingType::Traced))
+    }
+}
+
 #[turbo_tasks::value_impl]
 impl ValueToString for FileSourceReference {
     #[turbo_tasks::function]
Repository: ollama/ollama
Pull request: fix: gguf int type


Changed files:
filename: llm/gguf.go
patch: @@ -335,7 +335,7 @@ func (llm *ggufModel) readArrayV1(r io.Reader) (arr []any, err error) {
 		case ggufTypeUint8:
 			arr = append(arr, llm.readU8(r))
 		case ggufTypeInt8:
-			arr = append(arr, llm.readU8(r))
+			arr = append(arr, llm.readI8(r))
 		case ggufTypeUint16:
 			arr = append(arr, llm.readU16(r))
 		case ggufTypeInt16:
@@ -376,7 +376,7 @@ func (llm *ggufModel) readArray(r io.Reader) (arr []any, err error) {
 		case ggufTypeUint8:
 			arr = append(arr, llm.readU8(r))
 		case ggufTypeInt8:
-			arr = append(arr, llm.readU8(r))
+			arr = append(arr, llm.readI8(r))
 		case ggufTypeUint16:
 			arr = append(arr, llm.readU16(r))
 		case ggufTypeInt16:
Repository: electron/electron
Pull request: fix: crash on reconversion with google IME and editcontext on macOS

Backport of #46688

See that PR for details.


Notes: fix crash on reconversion with google IME and editcontext on macOS

Changed files:
filename: patches/chromium/.patches
patch: @@ -145,3 +145,4 @@ fix_win32_synchronous_spellcheck.patch
 chore_remove_conflicting_allow_unsafe_libc_calls.patch
 fix_linter_error.patch
 revert_enable_crel_for_arm32_targets.patch
+mac_fix_check_on_ime_reconversion_due_to_invalid_replacement_range.patch

filename: patches/chromium/mac_fix_check_on_ime_reconversion_due_to_invalid_replacement_range.patch
patch: @@ -0,0 +1,43 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Keren Zhu <kerenzhu@chromium.org>
+Date: Fri, 18 Apr 2025 11:02:46 -0700
+Subject: mac: fix CHECK on IME reconversion due to invalid replacement range
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+It appears that Google Japanese IME can call -setMarkedText: with an
+invalid replacement range when doing text reconversion (変換, i.e.,
+conversion between different text with same pronunciation). This range
+is a NSRange and NSRange.location is supposed to be NSNotFound (2^31-1)
+for invalid range, but the IME can pass in 2^32. Subsequently causing
+CHECK error.
+
+This CL fixes the issue by converting such invalid NSRange to
+gfx::InvalidRange using FromPossiblyInvalidNSRange(range).
+
+Fixed: 409864204
+Change-Id: I08ff426a933ef76aa81e33af59aa32e2ac0b674d
+Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6470915
+Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
+Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
+Cr-Commit-Position: refs/heads/main@{#1448935}
+
+diff --git a/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm b/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
+index f2499bc084312a09b2324567d270fc1b899e7617..12ee7e75e437426f28002c7c9f4d5f5b5016ec53 100644
+--- a/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
++++ b/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
+@@ -2415,9 +2415,10 @@ - (void)setMarkedText:(id)string
+   if ([self isHandlingKeyDown] && !_isReconversionTriggered) {
+     _setMarkedTextReplacementRange = gfx::Range(replacementRange);
+   } else {
+-    _host->ImeSetComposition(_markedText, _imeTextSpans,
+-                             gfx::Range(replacementRange), newSelRange.location,
+-                             NSMaxRange(newSelRange));
++    _host->ImeSetComposition(
++        _markedText, _imeTextSpans,
++        gfx::Range::FromPossiblyInvalidNSRange(replacementRange),
++        newSelRange.location, NSMaxRange(newSelRange));
+   }
+ 
+   [[self inputContext] invalidateCharacterCoordinates];
Repository: vercel/next.js
Pull request: Fix deployment tests

Only test on the latest React version, React 18 would require different snapshots.

Introduced by #82278

Closes PACK-5386

Changed files:
filename: test/production/next-server-nft/next-server-nft.test.ts
patch: @@ -2,14 +2,18 @@ import { nextTestSetup } from 'e2e-utils'
 import path from 'path'
 import fs from 'fs'
 
+const isReact18 = parseInt(process.env.NEXT_TEST_REACT_VERSION) === 18
+
 // Only run this test for Turbopack as it is more conservative (i.e. aggressive) in including
 // referenced files and might include too many. (The Webpack snapshots would different slightly from
 // the Turbopack ones below.)
 //
 // This test is not meant for testing correctness (which is done by the behavioral tests), but as a
 // regression test to ensure that some stray `path.join` doesn't cause all of the Next.js package to
 // get included.
-;(process.env.IS_TURBOPACK_TEST ? describe : describe.skip)(
+//
+// Also skip alternate React versions, as they would require different snapshots.
+;(process.env.IS_TURBOPACK_TEST && !isReact18 ? describe : describe.skip)(
   'next-server-nft',
   () => {
     const { next, skipped } = nextTestSetup({