helloadhavan/github_issues huggingface dataset:
Repository: huggingface/transformers
Pull request: Super tiny update

# What does this PR do?

Calling the processor with video inputs raises warning `Unused kwargs "images"` because we are passing `images=None` to the video processor

Changed files:
filename: src/transformers/models/qwen2_5_omni/processing_qwen2_5_omni.py
patch: @@ -172,15 +172,15 @@ def __call__(
             audio_lengths = iter([])
 
         if images is not None:
-            images_inputs = self.image_processor(images=images, videos=None, **output_kwargs["images_kwargs"])
+            images_inputs = self.image_processor(images=images, **output_kwargs["images_kwargs"])
             image_grid_thw = iter(images_inputs["image_grid_thw"])
         else:
             images_inputs = {}
             image_grid_thw = iter([])
 
         if videos is not None:
             videos = make_batched_videos(videos)
-            videos_inputs = self.video_processor(images=None, videos=videos, **output_kwargs["videos_kwargs"])
+            videos_inputs = self.video_processor(videos=videos, **output_kwargs["videos_kwargs"])
             fps = [fps] * len(videos)
             videos_inputs["video_second_per_grid"] = [
                 self.video_processor.temporal_patch_size / fps[i] for i in range(len(fps))
Repository: electron/electron
Pull request: test: disable `parallel/test-worker-resource-limits`

Backport of #46105

See that PR for details.


Notes: none


Changed files:
filename: script/node-disabled-tests.json
patch: @@ -153,6 +153,7 @@
   "parallel/test-webcrypto-wrap-unwrap",
   "parallel/test-worker-no-atomics",
   "parallel/test-worker-no-sab",
+  "parallel/test-worker-resource-limits",
   "parallel/test-zlib-unused-weak",
   "report/test-report-fatalerror-oomerror-compact",
   "report/test-report-fatalerror-oomerror-directory",
Repository: vercel/next.js
Pull request: [devtools] Cleanup folder structure

Some files did not fit into the folder structure established in https://github.com/vercel/next.js/pull/80281

The structure is both valueable to statically analyze that boundaries aren't violated and for contributors to orient.

Changed files:
filename: packages/next/src/next-devtools/dev-overlay/components/overview/segment-explorer.tsx
patch: @@ -5,7 +5,7 @@ import {
 } from '../../segment-explorer-trie'
 import { cx } from '../../utils/cx'
 import { SegmentBoundaryTrigger } from './segment-boundary-trigger'
-import { Tooltip } from '../../../components/tooltip'
+import { Tooltip } from '../tooltip/tooltip'
 import { useCallback, useMemo } from 'react'
 import {
   BUILTIN_PREFIX,

filename: packages/next/src/next-devtools/dev-overlay/components/overview/segment-suggestion.tsx
patch: @@ -1,4 +1,4 @@
-import { Tooltip } from '../../../components/tooltip'
+import { Tooltip } from '../tooltip/tooltip'
 import { InfoIcon } from './segment-explorer'
 
 export function SegmentSuggestion({

filename: packages/next/src/next-devtools/dev-overlay/components/tooltip/tooltip.tsx
patch: @@ -1,6 +1,6 @@
 import { forwardRef, useRef, useState } from 'react'
 import { Tooltip as BaseTooltip } from '@base-ui-components/react/tooltip'
-import { cx } from '../dev-overlay/utils/cx'
+import { cx } from '../../utils/cx'
 import './tooltip.css'
 
 type TooltipDirection = 'top' | 'bottom' | 'left' | 'right'

filename: packages/next/src/next-devtools/entrypoint.ts
patch: @@ -1,3 +1,3 @@
-import './global.css'
+import './dev-overlay/global.css'
 import './dev-overlay/components/toast/style.css'
 export * from './dev-overlay.browser'
Repository: denoland/deno
Pull request: fix(ext/node): ignore `parallel/test-eventsource-disabled.js` test

EventSource web API is always available in Deno

Towards https://github.com/denoland/deno/issues/29595

Changed files:
filename: tests/node_compat/run_all_test_unmodified.ts
patch: @@ -71,6 +71,7 @@ const NODE_IGNORED_TEST_DIRS = [
 const NODE_IGNORED_TEST_CASES = new Set([
   "parallel/test-benchmark-cli.js", // testing private benchmark utility
   "parallel/test-buffer-backing-arraybuffer.js", // Deno does not allow heap-allocated ArrayBuffer, and we can't change it (for now)
+  "parallel/test-eventsource-disabled.js", // EventSource global is always available in Deno (Web API)
 ]);
 
 /** The group is the directory name of the test file.
Repository: nodejs/node
Pull request: src: remove deprecated process exit APIs in node.h

The APIs have been deprecated for 5 years.

Refs: https://github.com/nodejs/node/pull/35486

Changed files:
filename: src/api/hooks.cc
patch: @@ -26,10 +26,6 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) {
   env->AtExit(cb, arg);
 }
 
-void EmitBeforeExit(Environment* env) {
-  USE(EmitProcessBeforeExit(env));
-}
-
 Maybe<bool> EmitProcessBeforeExit(Environment* env) {
   TRACE_EVENT0(TRACING_CATEGORY_NODE1(environment), "BeforeExit");
   if (!env->destroy_async_id_list()->empty())
@@ -50,14 +46,6 @@ Maybe<bool> EmitProcessBeforeExit(Environment* env) {
                                                              : Just(true);
 }
 
-static ExitCode EmitExitInternal(Environment* env) {
-  return EmitProcessExitInternal(env).FromMaybe(ExitCode::kGenericUserError);
-}
-
-int EmitExit(Environment* env) {
-  return static_cast<int>(EmitExitInternal(env));
-}
-
 Maybe<ExitCode> EmitProcessExitInternal(Environment* env) {
   // process.emit('exit')
   Isolate* isolate = env->isolate();

filename: src/node.h
patch: @@ -844,13 +844,9 @@ NODE_EXTERN void SetTracingController(v8::TracingController* controller);
 // Run `process.emit('beforeExit')` as it would usually happen when Node.js is
 // run in standalone mode.
 NODE_EXTERN v8::Maybe<bool> EmitProcessBeforeExit(Environment* env);
-NODE_DEPRECATED("Use Maybe version (EmitProcessBeforeExit) instead",
-    NODE_EXTERN void EmitBeforeExit(Environment* env));
 // Run `process.emit('exit')` as it would usually happen when Node.js is run
 // in standalone mode. The return value corresponds to the exit code.
 NODE_EXTERN v8::Maybe<int> EmitProcessExit(Environment* env);
-NODE_DEPRECATED("Use Maybe version (EmitProcessExit) instead",
-    NODE_EXTERN int EmitExit(Environment* env));
 
 // Runs hooks added through `AtExit()`. This is part of `FreeEnvironment()`,
 // so calling it manually is typically not necessary.
Repository: facebook/react
Pull request: Convert ReactJSXElementValidator to createRoot


Changed files:
filename: packages/react/src/__tests__/ReactJSXElementValidator-test.js
patch: @@ -13,8 +13,10 @@
 // of dynamic errors when using JSX with Flow.
 let React;
 let ReactDOM;
+let ReactDOMClient;
 let ReactTestUtils;
 let PropTypes;
+let act;
 
 describe('ReactJSXElementValidator', () => {
   let Component;
@@ -26,7 +28,9 @@ describe('ReactJSXElementValidator', () => {
     PropTypes = require('prop-types');
     React = require('react');
     ReactDOM = require('react-dom');
+    ReactDOMClient = require('react-dom/client');
     ReactTestUtils = require('react-dom/test-utils');
+    act = require('internal-test-utils').act;
 
     Component = class extends React.Component {
       render() {
@@ -172,7 +176,7 @@ describe('ReactJSXElementValidator', () => {
     );
   });
 
-  it('should update component stack after receiving next element', () => {
+  it('should update component stack after receiving next element', async () => {
     function MyComp() {
       return null;
     }
@@ -192,9 +196,14 @@ describe('ReactJSXElementValidator', () => {
     }
 
     const container = document.createElement('div');
-    ReactDOM.render(<ParentComp warn={false} />, container);
+    const root = ReactDOMClient.createRoot(container);
+    await act(() => {
+      root.render(<ParentComp warn={false} />);
+    });
     expect(() =>
-      ReactDOM.render(<ParentComp warn={true} />, container),
+      ReactDOM.flushSync(() => {
+        root.render(<ParentComp warn={true} />);
+      }),
     ).toErrorDev(
       'Warning: Failed prop type: ' +
         'Invalid prop `color` of type `number` supplied to `MyComp`, ' +
Repository: electron/electron
Pull request: test: disable `parallel/test-worker-resource-limits`

#### Description of Change

Refs https://github.com/electron/electron/pull/45922.

Seems like there's a threading issue upstream, and this feature is still very fresh and a little underbaked upstream. Disable this test to address a recent frequent CI flake.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none


Changed files:
filename: script/node-disabled-tests.json
patch: @@ -153,6 +153,7 @@
   "parallel/test-webcrypto-wrap-unwrap",
   "parallel/test-worker-no-atomics",
   "parallel/test-worker-no-sab",
+  "parallel/test-worker-resource-limits",
   "parallel/test-zlib-unused-weak",
   "report/test-report-fatalerror-oomerror-compact",
   "report/test-report-fatalerror-oomerror-directory",
Repository: nodejs/node
Pull request: src: fix `-Wreturn-stack-address` error

Refs https://github.com/nodejs/node/pull/57016

Fixes the following:

```
../../third_party/electron_node/src/node_config_file.cc:26:16: error: returning address of local temporary object [-Werror,-Wreturn-stack-address]
   26 |         return it->substr(flag_path.size() + 1);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/node_config_file.cc
patch: @@ -23,7 +23,7 @@ std::optional<std::string_view> ConfigReader::GetDataFromArgs(
     } else if (it->starts_with(flag_path)) {
       // Case: "--experimental-config-file=foo"
       if (it->size() > flag_path.size() && (*it)[flag_path.size()] == '=') {
-        return it->substr(flag_path.size() + 1);
+        return std::string_view(*it).substr(flag_path.size() + 1);
       }
     } else if (*it == default_file || it->starts_with(default_file)) {
       has_default_config_file = true;
Repository: huggingface/transformers
Pull request: [ASR pipline] fix with datasets 4.0

# What does this PR do?

Cf code comments!

Changed files:
filename: src/transformers/pipelines/automatic_speech_recognition.py
patch: @@ -380,7 +380,11 @@ def preprocess(self, inputs, chunk_length_s=0, stride_length_s=None):
 
             if isinstance(inputs, torchcodec.decoders.AudioDecoder):
                 _audio_samples = inputs.get_all_samples()
+
+                # torchcodec always returns (num_channels, num_samples)
+                # while before (datasets < 4.0) we had (2, num_samples) if stereo, (num_samples,) if mono
                 _array = _audio_samples.data
+                _array = _array[0] if _array.ndim == 2 and _array.shape[0] == 1 else _array
                 inputs = {"array": _array, "sampling_rate": _audio_samples.sample_rate}
 
         if isinstance(inputs, dict):
@@ -429,10 +433,13 @@ def preprocess(self, inputs, chunk_length_s=0, stride_length_s=None):
                 # can add extra data in the inputs, so we need to keep track
                 # of the original length in the stride so we can cut properly.
                 stride = (inputs.shape[0], int(round(stride[0] * ratio)), int(round(stride[1] * ratio)))
-        if not isinstance(inputs, np.ndarray):
+        if not isinstance(inputs, (np.ndarray, torch.Tensor)):
             raise TypeError(f"We expect a numpy ndarray or torch tensor as input, got `{type(inputs)}`")
-        if len(inputs.shape) != 1:
-            raise ValueError("We expect a single channel audio input for AutomaticSpeechRecognitionPipeline")
+        if inputs.ndim != 1:
+            logger.warning(
+                f"We expect a single channel audio input for AutomaticSpeechRecognitionPipeline, got {inputs.ndim}. Taking the mean of the channels for mono conversion."
+            )
+            inputs = inputs.mean(axis=0)
 
         if chunk_length_s:
             if stride_length_s is None:
Repository: vercel/next.js
Pull request: CI: add workflow_branch data to deploy test failure message

These can be triggered on PRs or release branches, so provides additional metadata about where the failure comes from. 

Changed files:
filename: .github/workflows/retry_deploy_test.yml
patch: @@ -54,7 +54,8 @@ jobs:
             {
               "commit_title": ${{ toJSON(github.event.workflow_run.display_title) }},
               "commit_url": "github.com/${{ github.repository }}/commit/${{ github.event.workflow_run.head_sha }}",
-              "workflow_run_url": "github.com/${{ github.repository }}/actions/runs/${{ github.event.workflow_run.id }}/attempts/${{ github.event.workflow_run.run_attempt }}"
+              "workflow_run_url": "github.com/${{ github.repository }}/actions/runs/${{ github.event.workflow_run.id }}/attempts/${{ github.event.workflow_run.run_attempt }}",
+              "workflow_branch": ${{ toJSON(github.event.workflow_run.head_branch) }}
             }
         env:
           SLACK_WEBHOOK_URL: ${{ env.SLACK_WEBHOOK_URL }}
Repository: ggml-org/llama.cpp
Pull request: metal : relax reorder conditions

Realized that the logic for reordering in the Metal backend is general enough to allow reorders even for nodes which dependencies might not be represented in the graph. The reason is that we keep track of the actual sources and destinations (either memory addresses or tensors) which is more general than the graph dependencies.

For example, the order of these ops would be preserved:

```c
ggml_build_forward_expand(gf, ggml_cpy(a, view(b));
ggml_something(b or another_view(b));
```

Reordering of CPY ops is useful in Whisper graphs.

Changed files:
filename: ggml/src/ggml-metal/ggml-metal-common.cpp
patch: @@ -256,8 +256,6 @@ static std::vector<int> ggml_metal_graph_optimize_reorder(const std::vector<node
 
     // perform reorders only across these types of ops
     // can be expanded when needed
-    // IMPORTANT: do not add ops such as GGML_OP_CPY or GGML_OP_SET_ROWS
-    //            the dependencies from such ops are not always represented in the graph
     const auto & h_safe = [](ggml_op op) {
         switch (op) {
             case GGML_OP_MUL_MAT:
@@ -273,6 +271,8 @@ static std::vector<int> ggml_metal_graph_optimize_reorder(const std::vector<node
             case GGML_OP_GLU:
             case GGML_OP_SCALE:
             case GGML_OP_GET_ROWS:
+            case GGML_OP_CPY:
+            case GGML_OP_SET_ROWS:
                 return true;
             default:
                 return ggml_op_is_empty(op);
Repository: huggingface/transformers
Pull request: Don't set `run_name` when none

# What does this PR do?

All the tracking library support `run_name=None`, and usually generate a name in this case, which can be quite practical.
Consequently, we don't need setting this value to `output_dir` when `None`


Changed files:
filename: src/transformers/integrations/integration_utils.py
patch: @@ -856,7 +856,7 @@ def setup(self, args, state, model, **kwargs):
             init_args = {}
             if trial_name is not None:
                 init_args["name"] = trial_name
-                init_args["group"] = args.run_name
+                init_args["group"] = args.run_name or args.output_dir
             elif args.run_name is not None:
                 init_args["name"] = args.run_name
                 if args.run_name == args.output_dir:
@@ -1230,11 +1230,7 @@ def setup(self, args, state, model):
 
             import comet_ml
 
-            # Do not use the default run_name as the experiment name
-            if args.run_name is not None and args.run_name != args.output_dir:
-                experiment_config = comet_ml.ExperimentConfig(name=args.run_name)
-            else:
-                experiment_config = comet_ml.ExperimentConfig()
+            experiment_config = comet_ml.ExperimentConfig(name=args.run_name)
 
             self._experiment = comet_ml.start(online=online, mode=mode, experiment_config=experiment_config)
             self._experiment.__internal_api__set_model_graph__(model, framework="transformers")
@@ -2357,10 +2353,12 @@ def setup(self, args, state, model, **kwargs):
                 combined_dict = {**{"peft_config": peft_config}, **combined_dict}
             trial_name = state.trial_name
             init_args = {}
-            if trial_name is not None:
+            if trial_name is not None and args.run_name is not None:
                 init_args["experiment_name"] = f"{args.run_name}-{trial_name}"
             elif args.run_name is not None:
                 init_args["experiment_name"] = args.run_name
+            elif trial_name is not None:
+                init_args["experiment_name"] = trial_name
             init_args["project"] = os.getenv("SWANLAB_PROJECT", None)
 
             if self._swanlab.get_run() is None:

filename: src/transformers/training_args.py
patch: @@ -1707,8 +1707,6 @@ def __post_init__(self):
             self.metric_for_best_model = "loss"
         if self.greater_is_better is None and self.metric_for_best_model is not None:
             self.greater_is_better = not self.metric_for_best_model.endswith("loss")
-        if self.run_name is None:
-            self.run_name = self.output_dir
         if self.framework == "pt" and is_torch_available():
             if self.fp16_backend and self.fp16_backend != "auto":
                 warnings.warn(
Repository: denoland/deno
Pull request: fix(coverage): `deno test --coverage` fails when importing modules from `data:` urls

Close #29479



Changed files:
filename: cli/tools/coverage/mod.rs
patch: @@ -576,6 +576,7 @@ fn filter_coverages(
     .into_iter()
     .filter(|e| {
       let is_internal = e.url.starts_with("ext:")
+        || e.url.starts_with("data:")
         || e.url.ends_with("__anonymous__")
         || e.url.ends_with("$deno$test.mjs")
         || e.url.ends_with(".snap")

filename: tests/specs/coverage/data_url/__test__.jsonc
patch: @@ -0,0 +1,6 @@
+{
+  "tempDir": true,
+  "args": "test --coverage main_test.ts",
+  "output": "main.out",
+  "exitCode": 0
+}

filename: tests/specs/coverage/data_url/main.out
patch: @@ -0,0 +1,15 @@
+Check [WILDLINE]/main_test.ts
+running 1 test from ./main_test.ts
+test ... ok ([WILDLINE])
+
+ok | 1 passed | 0 failed ([WILDLINE])
+
+--------------------------------
+File       | Branch % | Line % |
+--------------------------------
+ main.ts   |    100.0 |  100.0 |
+--------------------------------
+ All files |    100.0 |  100.0 |
+--------------------------------
+Lcov coverage report has been generated at [WILDLINE]
+HTML coverage report has been generated at [WILDLINE]

filename: tests/specs/coverage/data_url/main.ts
patch: @@ -0,0 +1,6 @@
+export async function foo() {
+  const { default: bar } = await import(
+    "data:application/typescript,export default 'bar'"
+  );
+  return bar;
+}

filename: tests/specs/coverage/data_url/main_test.ts
patch: @@ -0,0 +1,5 @@
+import { foo } from "./main.ts";
+
+Deno.test("test", () => {
+  foo();
+});
Repository: nodejs/node
Pull request: benchmark: fix broken fs.cpSync benchmark

https://github.com/nodejs/node/pull/58278 added some options to `benchmark/fs/bench-cpSync.js`, however after the changes the benchmark fails with an `ERR_FS_CP_EINVAL` error:
![Screenshot at 2025-05-26 18-23-13](https://github.com/user-attachments/assets/169aa5e2-70d0-4180-93d4-558a39a0899e)

I believe this is surfacing an actual bug in the cp/cpSync logic (see: https://github.com/nodejs/node/issues/58468) (please check out the issue and let me know if I am getting something wrong here :pray:) so here I am simply skipping the `force: true` option in the benchmarking file to make the benchmark actually work until the underlying issue is resolved.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: benchmark/fs/bench-cpSync.js
patch: @@ -8,7 +8,10 @@ const tmpdir = require('../../test/common/tmpdir');
 const bench = common.createBenchmark(main, {
   n: [1, 100, 10_000],
   dereference: ['true', 'false'],
-  force: ['true', 'false'],
+  // When `force` is `true` the `cpSync` function is called twice the second
+  // time however an `ERR_FS_CP_EINVAL` is thrown, so skip `true` for the time being
+  // TODO: allow `force` to also be `true` once https://github.com/nodejs/node/issues/58468 is addressed
+  force: ['false'],
 });
 
 function prepareTestDirectory() {