helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: fix: only remove the 'v' prefix from the git tag name

#### Description of Change

In the old version of get-version.js, it replaces the leading 'v', i.e. |output.stdout.toString().trim().replace(/^v/g, '')|. However, in the new version of get-git-version.py, it directly replaces all 'v'. Obviously, it does not conform to the original semantics. Although it will not affect the existing electron version calculation, it may affect other developers' customized git-tag-version, such as v0.0.0-dev.xxx, which will lose the 'v' of dev.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [ ] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [ ] relevant documentation, tutorials, templates and examples are changed or added
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: no-notes


Changed files:
filename: script/get-git-version.py
patch: @@ -2,6 +2,7 @@
 
 import subprocess
 import os
+import re
 
 # Find the nearest tag to the current HEAD.
 # This is equivalent to our old logic of "use a value in package.json" for the
@@ -24,7 +25,8 @@
       cwd=os.path.abspath(os.path.join(os.path.dirname(__file__), '..')),
       stderr=subprocess.PIPE,
       universal_newlines=True)
-  version = output.strip().replace('v', '')
+  # only remove the 'v' prefix from the tag name.
+  version = re.sub('^v', '', output.strip())
   print(version)
 except Exception:
   # When there is error we print a null version string instead of throwing an
Repository: ggml-org/llama.cpp
Pull request: llama : fix typo in llama-grammar.h [no ci]


Changed files:
filename: src/llama-grammar.h
patch: @@ -116,7 +116,7 @@ struct llama_grammar {
     llama_partial_utf8 partial_utf8;
 
     // lazy grammars wait for trigger words or tokens before constraining the sampling.
-    // we still ahve trigger_tokens for non-lazy grammars to force printing of special trigger tokens.
+    // we still have trigger_tokens for non-lazy grammars to force printing of special trigger tokens.
     // (useful e.g. for tool_choice=required)
     bool                     lazy             = false;
     bool                     awaiting_trigger = false; // Initialized to true for lazy grammars only
Repository: facebook/react
Pull request: DevTools should not crawl unmounted subtrees when profiling starts

Previously we crawled all subtrees, even not-yet-mounted ones, to initialize context values. This was not only unecessary, but it also caused an error to be thrown. This commit adds a test and fixes that behavior.

Resolves #22970

### Test (before)

![Screen Shot 2022-01-21 at 10 51 54 AM](https://user-images.githubusercontent.com/29597/150558047-142daef9-8566-497e-be1f-0d1fdd38ced9.png)

### Test (after)

![Screen Shot 2022-01-21 at 10 52 03 AM](https://user-images.githubusercontent.com/29597/150558049-e6dc7ecc-d7d6-4723-b0a9-ea8f73bbae64.png)



Changed files:
filename: packages/react-devtools-shared/src/__tests__/profilerStore-test.js
patch: @@ -221,4 +221,24 @@ describe('ProfilerStore', () => {
     expect(data.commitData).toHaveLength(1);
     expect(data.operations).toHaveLength(1);
   });
+
+  it('should not throw while initializing context values for Fibers within a not-yet-mounted subtree', () => {
+    const promise = new Promise(resolve => {});
+    const SuspendingView = () => {
+      throw promise;
+    };
+
+    const App = () => {
+      return (
+        <React.Suspense fallback="Fallback">
+          <SuspendingView />
+        </React.Suspense>
+      );
+    };
+
+    const container = document.createElement('div');
+
+    utils.act(() => legacyRender(<App />, container));
+    utils.act(() => store.profilerStore.startProfiling());
+  });
 });

filename: packages/react-devtools-shared/src/backend/renderer.js
patch: @@ -1347,11 +1347,19 @@ export function attach(
   // Fibers only store the current context value,
   // so we need to track them separately in order to determine changed keys.
   function crawlToInitializeContextsMap(fiber: Fiber) {
-    updateContextsForFiber(fiber);
-    let current = fiber.child;
-    while (current !== null) {
-      crawlToInitializeContextsMap(current);
-      current = current.sibling;
+    const id = getFiberIDUnsafe(fiber);
+
+    // Not all Fibers in the subtree have mounted yet.
+    // For example, Offscreen (hidden) or Suspense (suspended) subtrees won't yet be tracked.
+    // We can safely skip these subtrees.
+    if (id !== null) {
+      updateContextsForFiber(fiber);
+
+      let current = fiber.child;
+      while (current !== null) {
+        crawlToInitializeContextsMap(current);
+        current = current.sibling;
+      }
     }
   }
Repository: vercel/next.js
Pull request: Turbopack Build: Update manifest

## What?

Updates the manifest to reflect the fixed tests in #80603

Closes PACK-4887

Changed files:
filename: test/turbopack-build-tests-manifest.json
patch: @@ -10329,11 +10329,11 @@
     "runtimeError": false
   },
   "test/integration/css-features/test/browserslist.test.js": {
-    "passed": [],
-    "failed": [
+    "passed": [
       "Browserslist: New production mode should've emitted a single CSS file",
       "Browserslist: Old production mode should've emitted a single CSS file"
     ],
+    "failed": [],
     "pending": [],
     "flakey": [],
     "runtimeError": false
Repository: facebook/react
Pull request: Update enableSyncDefaultUpdates for www

If this is false, it dead code eliminates the path to use the root flag. Will follow up to clean this up.

Changed files:
filename: packages/shared/forks/ReactFeatureFlags.www.js
patch: @@ -105,8 +105,7 @@ export const enableUseMutableSource = true;
 export const useModernStrictMode = false;
 export const enableFizzExternalRuntime = true;
 
-// This is only used in VARIANT tests, setting it to true does nothing.
-export const enableSyncDefaultUpdates = false;
+export const enableSyncDefaultUpdates = true;
 
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);
Repository: facebook/react
Pull request: run SchedulerFeatureFlags with variant flags again

With df12d7eac40c87bd5fdde0aa5a739bce9e7dce27 I accidentally made it so that tests aren't run with the 2 variant modes for most SchedulerFeatureFlags anymore. This fixes it with the same approach as ee4233bdbc71a7e09395a613c7dde01194d2a830.

Test Plan:
Run and notice the boolean flags follow the variant:
```
yarn test-www --variant=true
yarn test-www --variant=false
```

Changed files:
filename: scripts/jest/setupTests.www.js
patch: @@ -24,9 +24,18 @@ jest.mock('scheduler/src/SchedulerFeatureFlags', () => {
       ),
     {virtual: true}
   );
-  return jest.requireActual(
+  const actual = jest.requireActual(
     schedulerSrcPath + '/src/forks/SchedulerFeatureFlags.www'
   );
+
+  // These flags are not a dynamic on www, but we still want to run
+  // tests in both versions.
+  actual.enableIsInputPending = __VARIANT__;
+  actual.enableIsInputPendingContinuous = __VARIANT__;
+  actual.enableProfiling = __VARIANT__;
+  actual.enableSchedulerDebugging = __VARIANT__;
+
+  return actual;
 });
 
 global.__WWW__ = true;
Repository: ggml-org/llama.cpp
Pull request: scripts : add --outdir option to hf.sh

This commit adds an option to the hf.sh script that allows the user to specify an output directory for the downloaded file.

The motivation for this changes is that examples that use the hf.sh script to download models from huggingface can now specify the output directory, perhaps to the `models` directory to keep them in one place and not clutter the root directory.

Changed files:
filename: scripts/hf.sh
patch: @@ -3,9 +3,9 @@
 # Shortcut for downloading HF models
 #
 # Usage:
-#   ./main -m $(./examples/hf.sh https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF/resolve/main/mixtral-8x7b-v0.1.Q4_K_M.gguf)
-#   ./main -m $(./examples/hf.sh --url https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF/blob/main/mixtral-8x7b-v0.1.Q4_K_M.gguf)
-#   ./main -m $(./examples/hf.sh --repo TheBloke/Mixtral-8x7B-v0.1-GGUF --file mixtral-8x7b-v0.1.Q4_K_M.gguf)
+#   ./main -m $(./scripts/hf.sh https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF/resolve/main/mixtral-8x7b-v0.1.Q4_K_M.gguf)
+#   ./main -m $(./scripts/hf.sh --url https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF/blob/main/mixtral-8x7b-v0.1.Q4_K_M.gguf)
+#   ./main -m $(./scripts/hf.sh --repo TheBloke/Mixtral-8x7B-v0.1-GGUF --file mixtral-8x7b-v0.1.Q4_K_M.gguf)
 #
 
 # all logs go to stderr
@@ -14,7 +14,7 @@ function log {
 }
 
 function usage {
-    log "Usage: $0 [[--url] <url>] [--repo <repo>] [--file <file>] [-h|--help]"
+    log "Usage: $0 [[--url] <url>] [--repo <repo>] [--file <file>] [--outdir <dir> [-h|--help]"
     exit 1
 }
 
@@ -26,9 +26,9 @@ function has_cmd {
 }
 
 if has_cmd wget; then
-    cmd="wget -q --show-progress -c -O %s %s"
+    cmd="wget -q --show-progress -c -O %s/%s %s"
 elif has_cmd curl; then
-    cmd="curl -C - -f -o %s -L %s"
+    cmd="curl -C - -f --output-dir %s -o %s -L %s"
 else
     log "[E] curl or wget not found"
     exit 1
@@ -37,6 +37,7 @@ fi
 url=""
 repo=""
 file=""
+outdir="."
 
 # parse args
 while [[ $# -gt 0 ]]; do
@@ -53,6 +54,10 @@ while [[ $# -gt 0 ]]; do
             file="$2"
             shift 2
             ;;
+        --outdir)
+            outdir="$2"
+            shift 2
+            ;;
         -h|--help)
             usage
             ;;
@@ -94,10 +99,10 @@ basename=$(basename $url)
 log "[+] attempting to download $basename"
 
 if [ -n "$cmd" ]; then
-    cmd=$(printf "$cmd" "$basename" "$url")
+    cmd=$(printf "$cmd" "$outdir" "$basename" "$url")
     log "[+] $cmd"
     if $cmd; then
-        echo $basename
+        echo $outdir/$basename
         exit 0
     fi
 fi
Repository: ggml-org/llama.cpp
Pull request: llama : make cell_id const in inp_s_mask block

This commit makes the cell_id variable const in the inp_s_mask block.

The motivation for this change is consistency with the code in the inp_s_copy block.



- [x] I have read the [contributing guidelines](https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md)
- Self-reported review complexity:
  - [x] Low
  - [ ] Medium
  - [ ] High


Changed files:
filename: src/llama.cpp
patch: @@ -15826,7 +15826,7 @@ static void llama_set_inputs(llama_context & lctx, const llama_ubatch & batch) {
 
             // clear unused states
             for (int i = 0; i < n_kv; ++i) {
-                uint32_t        cell_id = i + kv_self.head;
+                const uint32_t  cell_id = i + kv_self.head;
                 llama_kv_cell & kv_cell = lctx.kv_self.cells[cell_id];
 
                 data[i] = (float) (kv_cell.src >= 0);
Repository: denoland/deno
Pull request: fix(ext/node): Fix handling of sqlite large integers

Use `v8::Number` instead of `v8::Integer` to handle > i32::MAX.

Fixes https://github.com/denoland/deno/issues/28187


Changed files:
filename: ext/node/ops/sqlite/statement.rs
patch: @@ -138,7 +138,7 @@ impl StatementSync {
           if self.use_big_ints.get() {
             v8::BigInt::new_from_i64(scope, value).into()
           } else if value.abs() <= MAX_SAFE_JS_INTEGER {
-            v8::Integer::new(scope, value as _).into()
+            v8::Number::new(scope, value as f64).into()
           } else {
             return Err(SqliteError::NumberTooLarge(index, value));
           }

filename: tests/unit_node/sqlite_test.ts
patch: @@ -236,3 +236,11 @@ Deno.test("[node/sqlite] StatementSync#iterate", () => {
 
   db.close();
 });
+
+// https://github.com/denoland/deno/issues/28187
+Deno.test("[node/sqlite] StatementSync for large integers", () => {
+  const db = new DatabaseSync(":memory:");
+  const result = db.prepare("SELECT 2147483648").get();
+  assertEquals(result, { "2147483648": 2147483648, __proto__: null });
+  db.close();
+});
Repository: nodejs/node
Pull request: doc: explicitly state that corepack will be removed in v25+

The generic "future versions of" Node.js is causing a confusion among corepack users.
Example https://github.com/nodejs/corepack/issues/688#issuecomment-2778719004

This PR explicitly changes it to v25+ as agreed in TSC vote in https://github.com/nodejs/TSC/pull/1697#issuecomment-2737093616

Changed files:
filename: doc/api/corepack.md
patch: @@ -16,6 +16,6 @@ Documentation for this tool can be found on the [Corepack repository][].
 
 Despite Corepack being distributed with default installs of Node.js, the package
 managers managed by Corepack are not part of the Node.js distribution, and
-Corepack itself will no longer be distributed with future versions of Node.js.
+Corepack itself will no longer be distributed with Node.js 25+.
 
 [Corepack repository]: https://github.com/nodejs/corepack
Repository: facebook/react
Pull request: Move enableSyncDefaultUpdates to test config

# Overview

The only reason this needs imported from dynamic flags is for the variant tests, so let's set the variant in the test config directly instead.

Changed files:
filename: packages/shared/forks/ReactFeatureFlags.www.js
patch: @@ -23,7 +23,6 @@ export const {
   enableDebugTracing,
   enableUseRefAccessWarning,
   enableLazyContextPropagation,
-  enableSyncDefaultUpdates,
   enableUnifiedSyncLane,
   enableTransitionTracing,
   enableCustomElementPropertySupport,
@@ -106,5 +105,8 @@ export const enableUseMutableSource = true;
 export const useModernStrictMode = false;
 export const enableFizzExternalRuntime = true;
 
+// This is only used in VARIANT tests, setting it to true does nothing.
+export const enableSyncDefaultUpdates = false;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);

filename: scripts/jest/setupTests.www.js
patch: @@ -6,7 +6,12 @@ jest.mock('shared/ReactFeatureFlags', () => {
     () => jest.requireActual('shared/forks/ReactFeatureFlags.www-dynamic'),
     {virtual: true}
   );
-  return jest.requireActual('shared/forks/ReactFeatureFlags.www');
+  const actual = jest.requireActual('shared/forks/ReactFeatureFlags.www');
+
+  // This flag is only used by tests, it should never be set elsewhere.
+  actual.enableSyncDefaultUpdates = __VARIANT__;
+
+  return actual;
 });
 
 jest.mock('scheduler/src/SchedulerFeatureFlags', () => {
Repository: electron/electron
Pull request: test: reenable disabled GHA windows tests

Backport of #45062

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: spec/chromium-spec.ts
patch: @@ -655,9 +655,7 @@ describe('chromium features', () => {
       expect(size).to.be.a('number');
     });
 
-    // TODO: Re-enable for windows on GitHub Actions,
-    // fullscreen tests seem to hang on GHA specifically
-    ifit(process.platform !== 'win32' || process.arch === 'arm64')('should lock the keyboard', async () => {
+    it('should lock the keyboard', async () => {
       const w = new BrowserWindow({ show: true });
       await w.loadFile(path.join(fixturesPath, 'pages', 'modal.html'));
 
@@ -2982,9 +2980,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
     server.close();
   });
 
-  // TODO: Re-enable for windows on GitHub Actions,
-  // fullscreen tests seem to hang on GHA specifically
-  ifit(process.platform !== 'darwin' && (process.platform !== 'win32' || process.arch === 'arm64'))('can fullscreen from out-of-process iframes (non-macOS)', async () => {
+  ifit(process.platform !== 'darwin')('can fullscreen from out-of-process iframes (non-macOS)', async () => {
     const fullscreenChange = once(ipcMain, 'fullscreenChange');
     const html =
       `<iframe style="width: 0" frameborder=0 src="${crossSiteUrl}" allowfullscreen></iframe>`;
@@ -3039,7 +3035,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
 
   // TODO: Re-enable for windows on GitHub Actions,
   // fullscreen tests seem to hang on GHA specifically
-  ifit(process.platform !== 'win32' || process.arch === 'arm64')('can fullscreen from in-process iframes', async () => {
+  it('can fullscreen from in-process iframes', async () => {
     if (process.platform === 'darwin') await once(w, 'enter-full-screen');
 
     const fullscreenChange = once(ipcMain, 'fullscreenChange');
Repository: ggml-org/llama.cpp
Pull request: infill : add download instructions for model

This commit adds instructions on how to download a CodeLlama model using the `hf.sh` script. This will download the model and place it in the `models` directory which is the same model use later by the infill example.

Changed files:
filename: examples/infill/README.md
patch: @@ -36,6 +36,11 @@ The `infill` program offers a seamless way to interact with LLaMA models, allowi
 
 ### Example
 
+Download a model that supports infill, for example CodeLlama:
+```console
+scripts/hf.sh --repo TheBloke/CodeLlama-13B-GGUF --file codellama-13b.Q5_K_S.gguf --outdir models
+```
+
 ```bash
 ./infill -t 10 -ngl 0 -m models/codellama-13b.Q5_K_S.gguf -c 4096 --temp 0.7 --repeat_penalty 1.1 -n 20 --in-prefix "def helloworld():\n    print(\"hell" --in-suffix "\n   print(\"goodbye world\")\n    "
 ```
Repository: denoland/deno
Pull request: fix: don't panic when running with // as a filepath

Fixes #28128

Changed files:
filename: cli/args/flags.rs
patch: @@ -1006,7 +1006,7 @@ impl Flags {
             || module_specifier.scheme() == "npm"
           {
             if let Ok(p) = url_to_file_path(&module_specifier) {
-              Some(vec![p.parent().unwrap().to_path_buf()])
+              p.parent().map(|parent| vec![parent.to_path_buf()])
             } else {
               Some(vec![current_dir.to_path_buf()])
             }

filename: tests/specs/run/with_double_slash/__test__.jsonc
patch: @@ -0,0 +1,5 @@
+{
+  "args": "run //",
+  "exitCode": 1,
+  "output": "error: [WILDCARD]"
+}
Repository: nodejs/node
Pull request: doc: update position type to integer | null in fs

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->

Changed position type from `integer` to `integer | null `to reflect the ability for position to accept `null`.

Changed files:
filename: doc/api/fs.md
patch: @@ -741,7 +741,7 @@ added:
 * `options` {Object}
   * `offset` {integer} **Default:** `0`
   * `length` {integer} **Default:** `buffer.byteLength - offset`
-  * `position` {integer} **Default:** `null`
+  * `position` {integer|null} **Default:** `null`
 * Returns: {Promise}
 
 Write `buffer` to the file.
@@ -4997,7 +4997,7 @@ added:
 * `options` {Object}
   * `offset` {integer} **Default:** `0`
   * `length` {integer} **Default:** `buffer.byteLength - offset`
-  * `position` {integer} **Default:** `null`
+  * `position` {integer|null} **Default:** `null`
 * `callback` {Function}
   * `err` {Error}
   * `bytesWritten` {integer}
@@ -6531,7 +6531,7 @@ added:
 * `options` {Object}
   * `offset` {integer} **Default:** `0`
   * `length` {integer} **Default:** `buffer.byteLength - offset`
-  * `position` {integer} **Default:** `null`
+  * `position` {integer|null} **Default:** `null`
 * Returns: {number} The number of bytes written.
 
 For detailed information, see the documentation of the asynchronous version of
Repository: facebook/react
Pull request: Add $FlowFixMe to fix React Native DiffTrain

Flow errors for 0.206 were suppressed in fbsource. This adds the suppression in React code.

Changed files:
filename: scripts/rollup/shims/react-native/ReactNativeViewConfigRegistry.js
patch: @@ -106,6 +106,7 @@ exports.get = function (name: string): ViewConfig {
         'View config getter callback for component `%s` must be a function (received `%s`).%s',
         name,
         callback === null ? 'null' : typeof callback,
+        // $FlowFixMe[recursive-definition]
         typeof name[0] === 'string' && /[a-z]/.test(name[0])
           ? ' Make sure to start component names with a capital letter.'
           : '',