helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: ci: enable debugging mode when building electron_dist_zip

#### Description of Change

<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

We're seeing an intermittent issue where the `electron` binary for Linux arm64 isn't seeming to be stripped properly. I've noticed that in these cases there's output which shows that the `electron` binary is being relinked while building the `electron:electron_dist_zip` target, which is why the stripping that occurred earlier is reverted.

It's not clear why the relinking is occurring (seems that `libinstrumentation_probes` is a commonality), so enable the `-d explain` debugging mode so the next time it happens we have extra output explaining why the relinking is happening.

We see this in nightly releases, so not going to backport it since it's just for debugging purposes.

```
2024-12-11T19:32:20.7318370Z Running "autoninja -j 300 electron:electron_dist_zip" in /__w/electron/electron/src/out/Default
2024-12-11T19:32:20.9405774Z Proxy started successfully.
2024-12-11T19:32:32.2069616Z [1/7] COPY gen/components/resources/about_credits.html LICENSES.chromium.html
2024-12-11T19:32:32.2073165Z [2/7] COPY ../../electron/LICENSE LICENSE
2024-12-11T19:32:32.2206919Z [3/7] ACTION //electron:electron_version_file(//build/toolchain/linux:clang_arm)
2024-12-11T19:32:55.2710588Z [4/7] CXX obj/third_party/blink/renderer/core/probe/instrumentation_probes/core_probes_impl.o
2024-12-11T19:32:55.2742951Z [5/7] AR obj/third_party/blink/renderer/core/probe/libinstrumentation_probes.a
2024-12-11T19:33:49.3401364Z [6/7] LINK ./electron
2024-12-11T19:34:22.3013271Z [7/7] ACTION //electron:electron_dist_zip(//build/toolchain/linux:clang_arm)
```

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd

#### Release Notes

Notes: none <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->


Changed files:
filename: .github/actions/build-electron/action.yml
patch: @@ -69,7 +69,7 @@ runs:
       shell: bash
       run: |
         cd src
-        e build --target electron:electron_dist_zip -j $NUMBER_OF_NINJA_PROCESSES
+        e build --target electron:electron_dist_zip -j $NUMBER_OF_NINJA_PROCESSES -d explain
         if [ "${{ inputs.is-asan }}" != "true" ]; then
           target_os=${{ inputs.target-platform == 'macos' && 'mac' || inputs.target-platform }}
           if [ "${{ inputs.artifact-platform }}" = "mas" ]; then
Repository: denoland/deno
Pull request: fix(ext/cache): add missing Cargo feature


Changed files:
filename: ext/cache/Cargo.toml
patch: @@ -19,7 +19,7 @@ async-stream.workspace = true
 async-trait.workspace = true
 base64.workspace = true
 bytes.workspace = true
-chrono.workspace = true
+chrono = { workspace = true, features = ["now"] }
 deno_core.workspace = true
 deno_error.workspace = true
 futures.workspace = true
Repository: ggml-org/llama.cpp
Pull request: llama : suppress unary minus operator warning

This commit updates the _try_copy lambda and moves the unary minus operator to after the cast to int32_t.

The motivation for this that currently the following warning is generated on windows:

```console
llama.cpp\src\llama.cpp(21147,30): warning C4146: unary minus operator applied to unsigned type, result still unsigned
```



- [x] I have read the [contributing guidelines](https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md)
- Self-reported review complexity:
  - [x] Low
  - [ ] Medium
  - [ ] High


Changed files:
filename: src/llama.cpp
patch: @@ -21144,7 +21144,7 @@ int32_t llama_token_to_piece(const struct llama_model * model, llama_token token
             size--;
         }
         if (length < (int32_t)size) {
-            return (int32_t) -size;
+            return -(int32_t) size;
         }
         memcpy(buf, token, size);
         return (int32_t) size;
Repository: denoland/deno
Pull request: feat: support XDG_CACHE_HOME for deno dir on macos

* https://github.com/denoland/deno_cache_dir/pull/73

Changed files:
filename: Cargo.lock
patch: @@ -1683,9 +1683,9 @@ dependencies = [
 
 [[package]]
 name = "deno_cache_dir"
-version = "0.17.0"
+version = "0.18.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "27429da4d0e601baaa41415a43468d49a586645d13497f12e8a9346f9f6b1347"
+checksum = "4cadb05700726eb97cb4914d8016ff81ece094b1c3ed442d6f48f297961a5a96"
 dependencies = [
  "async-trait",
  "base32",

filename: Cargo.toml
patch: @@ -128,7 +128,7 @@ ctr = { version = "0.9.2", features = ["alloc"] }
 dashmap = "5.5.3"
 data-encoding = "2.3.3"
 data-url = "=0.3.1"
-deno_cache_dir = "=0.17.0"
+deno_cache_dir = "=0.18.0"
 deno_error = "=0.5.5"
 deno_package_json = { version = "=0.4.2", default-features = false }
 deno_unsync = "0.4.2"
Repository: huggingface/transformers
Pull request: Two ReDOS fixes

Fixes https://huntr.com/bounties/6a6c933f-9ce8-4ded-8b3b-2c1444c61f36 and https://huntr.com/bounties/287d15a7-6e7c-45d2-8c05-11e305776f1f

The Marian change should be 100% identical, and a lot more performant than using a regex. The TF change has a slight behaviour change if people are passing regex patterns in that field, but I don't think anyone is, and also the class is deprecated anyway!

Changed files:
filename: src/transformers/models/marian/tokenization_marian.py
patch: @@ -13,7 +13,6 @@
 # limitations under the License.
 import json
 import os
-import re
 import warnings
 from pathlib import Path
 from shutil import copyfile
@@ -104,7 +103,6 @@ class MarianTokenizer(PreTrainedTokenizer):
 
     vocab_files_names = VOCAB_FILES_NAMES
     model_input_names = ["input_ids", "attention_mask"]
-    language_code_re = re.compile(">>.+<<")  # type: re.Pattern
 
     def __init__(
         self,
@@ -186,9 +184,11 @@ def _convert_token_to_id(self, token):
 
     def remove_language_code(self, text: str):
         """Remove language codes like >>fr<< before sentencepiece"""
-        match = self.language_code_re.match(text)
-        code: list = [match.group(0)] if match else []
-        return code, self.language_code_re.sub("", text)
+        code = []
+        if text.startswith(">>") and (end_loc := text.find("<<")) != -1:
+            code.append(text[: end_loc + 2])
+            text = text[end_loc + 2 :]
+        return code, text
 
     def _tokenize(self, text: str) -> list[str]:
         code, text = self.remove_language_code(text)

filename: src/transformers/optimization_tf.py
patch: @@ -14,7 +14,6 @@
 # ==============================================================================
 """Functions and classes related to optimization (weight updates)."""
 
-import re
 from typing import Callable, Optional, Union
 
 import tensorflow as tf
@@ -296,12 +295,12 @@ def _do_use_weight_decay(self, param_name):
 
         if self._include_in_weight_decay:
             for r in self._include_in_weight_decay:
-                if re.search(r, param_name) is not None:
+                if r in param_name:
                     return True
 
         if self._exclude_from_weight_decay:
             for r in self._exclude_from_weight_decay:
-                if re.search(r, param_name) is not None:
+                if r in param_name:
                     return False
         return True
Repository: vercel/next.js
Pull request: Update Turbopack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Turbopack.

Changed files:
filename: test/turbopack-build-tests-manifest.json
patch: @@ -2963,6 +2963,18 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/mdx-no-mdx-components/mdx.test.ts": {
+    "passed": [
+      "mdx app directory should allow importing client components",
+      "mdx app directory should work in initial html",
+      "mdx app directory should work using browser",
+      "mdx pages directory should work in initial html"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/mdx/mdx.test.ts": {
     "passed": [
       "mdx with-mdx-rs app directory should allow importing client components",
@@ -18754,16 +18766,6 @@
     "flakey": [],
     "runtimeError": false
   },
-  "test/production/app-dir/resume-data-cache/resume-data-cache.test.ts": {
-    "passed": [
-      "resume-data-cache should have consistent data between static and dynamic renders with fetch cache",
-      "resume-data-cache should have consistent data between static and dynamic renders with use cache"
-    ],
-    "failed": [],
-    "pending": [],
-    "flakey": [],
-    "runtimeError": false
-  },
   "test/production/app-dir/revalidate/revalidate.test.ts": {
     "passed": [
       "app-dir revalidate should be able to revalidate the cache via pages/api"
@@ -19658,7 +19660,6 @@
   "test/production/standalone-mode/required-server-files/required-server-files-ppr.test.ts": {
     "passed": [
       "required server files app router middleware rewrite should work with a dynamic path with Next-Resume",
-      "required server files app router should de-dupe client segment tree revalidate requests",
       "required server files app router should handle RSC requests",
       "required server files app router should handle prefetch RSC requests",
       "required server files app router should handle revalidating the fallback page",
@@ -19669,8 +19670,7 @@
       "required server files app router should properly handle prerender for bot request",
       "required server files app router should properly stream resume with Next-Resume",
       "required server files app router should send cache tags in minimal mode for ISR",
-      "required server files app router should still render when postponed is corrupted with Next-Resume",
-      "required server files app router should use the postponed state for the RSC requests"
+      "required server files app router should still render when postponed is corrupted with Next-Resume"
     ],
     "failed": [],
     "pending": [],
Repository: nodejs/node
Pull request: doc: add note regarding commit message trailers

@aduh95 @anonrig 🙂 

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/contributing/pull-requests.md
patch: @@ -184,6 +184,11 @@ A good commit message should describe what changed and why.
    of the log. Use the `Fixes:` prefix and the full issue URL. For other
    references use `Refs:`.
 
+   `Fixes:` and `Refs:` trailers get automatically added to your commit message
+   when the Pull Request lands as long as they are included in the
+   Pull Request's description. If the Pull Request lands in several commits,
+   by default the trailers found in the description are added to each commits.
+
    Examples:
 
    * `Fixes: https://github.com/nodejs/node/issues/1337`
Repository: electron/electron
Pull request: fix: native module compilation with gcc<=8

#### Description of Change

Backports https://chromium-review.googlesource.com/c/v8/v8/+/5957255

```
npm error /home/cloudtest/.cache/node-gyp/33.3.0/include/node/v8-internal.h:1433:28: error: need 'typename' before 'Iterator::iterator_concept' because 'Iterator' is a dependent scope
npm error    using iterator_concept = Iterator::iterator_concept;
npm error                             ^~~~~~~~

```

#### Release Notes

Notes: fix native module compilation with gcc<= 8 and clang<=15

Changed files:
filename: patches/v8/.patches
patch: @@ -1,3 +1,4 @@
 chore_allow_customizing_microtask_policy_per_context.patch
 deps_add_v8_object_setinternalfieldfornodecore.patch
 fix_disable_scope_reuse_associated_dchecks.patch
+fix_compiler_failure_on_older_clang.patch

filename: patches/v8/fix_compiler_failure_on_older_clang.patch
patch: @@ -0,0 +1,44 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Peter Kasting <pkasting@chromium.org>
+Date: Wed, 23 Oct 2024 09:38:17 -0700
+Subject: Fix compiler failure on older Clang.
+
+On crrev.com/c/5774729 someone reported that omitting `typename` in a
+few places caused an error for them. This should be allowed in C++20,
+but apparently was not accepted by (what the author believes is)
+Clang 15. I don't know whether V8 officially supports this version.
+
+Since it's harmless to explicitly add the `typename` here, go ahead and
+do so to make life less painful.
+
+Bug: none
+Change-Id: I97a125a6ac9fa21fa15723888ca00790cc4fb4ee
+Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5957255
+Reviewed-by: Anton Bikineev <bikineev@chromium.org>
+Commit-Queue: Leszek Swirski <leszeks@chromium.org>
+Auto-Submit: Peter Kasting <pkasting@chromium.org>
+Cr-Commit-Position: refs/heads/main@{#96791}
+
+diff --git a/include/v8-internal.h b/include/v8-internal.h
+index a13db2bd74ad4b412cf8bd067c7b25c2acb1bcb8..99099fb1bb617014365b1ba3eaf4bd99d6eb6d4b 100644
+--- a/include/v8-internal.h
++++ b/include/v8-internal.h
+@@ -1430,7 +1430,7 @@ struct MaybeDefineIteratorConcept {};
+ template <typename Iterator>
+ struct MaybeDefineIteratorConcept<
+     Iterator, std::enable_if_t<kHaveIteratorConcept<Iterator>>> {
+-  using iterator_concept = Iterator::iterator_concept;
++  using iterator_concept = typename Iterator::iterator_concept;
+ };
+ // Otherwise fall back to `std::iterator_traits<Iterator>` if possible.
+ template <typename Iterator>
+@@ -1443,7 +1443,8 @@ struct MaybeDefineIteratorConcept<
+   // TODO(pkasting): Add this unconditionally after dropping support for old
+   // libstdc++ versions.
+ #if __has_include(<ranges>)
+-  using iterator_concept = std::iterator_traits<Iterator>::iterator_concept;
++  using iterator_concept =
++      typename std::iterator_traits<Iterator>::iterator_concept;
+ #endif
+ };
+
Repository: electron/electron
Pull request: test: reenable disabled GHA windows tests

Backport of #45062

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: spec/api-shell-spec.ts
patch: @@ -3,6 +3,7 @@ import { BrowserWindow, app } from 'electron/main';
 
 import { expect } from 'chai';
 
+import { execSync } from 'node:child_process';
 import { once } from 'node:events';
 import * as fs from 'node:fs';
 import * as http from 'node:http';
@@ -17,6 +18,15 @@ describe('shell module', () => {
     let envVars: Record<string, string | undefined> = {};
     let server: http.Server;
 
+    after(function () {
+      this.timeout(60000);
+      if (process.env.CI && process.platform === 'win32') {
+        // Edge may cause issues with visibility tests, so make sure it is closed after testing.
+        const killEdge = 'Get-Process | Where Name -Like "msedge" | Stop-Process';
+        execSync(killEdge, { shell: 'powershell.exe' });
+      }
+    });
+
     beforeEach(function () {
       envVars = {
         display: process.env.DISPLAY,

filename: spec/chromium-spec.ts
patch: @@ -653,9 +653,7 @@ describe('chromium features', () => {
       expect(size).to.be.a('number');
     });
 
-    // TODO: Re-enable for windows on GitHub Actions,
-    // fullscreen tests seem to hang on GHA specifically
-    ifit(process.platform !== 'win32' || process.arch === 'arm64')('should lock the keyboard', async () => {
+    it('should lock the keyboard', async () => {
       const w = new BrowserWindow({ show: true });
       await w.loadFile(path.join(fixturesPath, 'pages', 'modal.html'));
 
@@ -2980,9 +2978,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
     server.close();
   });
 
-  // TODO: Re-enable for windows on GitHub Actions,
-  // fullscreen tests seem to hang on GHA specifically
-  ifit(process.platform !== 'darwin' && (process.platform !== 'win32' || process.arch === 'arm64'))('can fullscreen from out-of-process iframes (non-macOS)', async () => {
+  ifit(process.platform !== 'darwin')('can fullscreen from out-of-process iframes (non-macOS)', async () => {
     const fullscreenChange = once(ipcMain, 'fullscreenChange');
     const html =
       `<iframe style="width: 0" frameborder=0 src="${crossSiteUrl}" allowfullscreen></iframe>`;
@@ -3037,7 +3033,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
 
   // TODO: Re-enable for windows on GitHub Actions,
   // fullscreen tests seem to hang on GHA specifically
-  ifit(process.platform !== 'win32' || process.arch === 'arm64')('can fullscreen from in-process iframes', async () => {
+  it('can fullscreen from in-process iframes', async () => {
     if (process.platform === 'darwin') await once(w, 'enter-full-screen');
 
     const fullscreenChange = once(ipcMain, 'fullscreenChange');
Repository: ggml-org/llama.cpp
Pull request: llama : rename ctx to user_data in progress_callback

This commit renames the `ctx` parameter to `user_data` in the `llama_progress_callback` typedef.

The motivation for this is that other callbacks use `user_data` or `data`, and using `ctx` in this case might be confusing as it could be confused with `llama_context`.

Changed files:
filename: llama.h
patch: @@ -171,7 +171,7 @@ extern "C" {
         bool sorted;
     } llama_token_data_array;
 
-    typedef bool (*llama_progress_callback)(float progress, void *ctx);
+    typedef bool (*llama_progress_callback)(float progress, void * user_data);
 
     // Input data for llama_decode
     // A llama_batch object can contain input about one or many sequences
Repository: electron/electron
Pull request: test: reenable disabled GHA windows tests

Backport of #45062

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: spec/api-shell-spec.ts
patch: @@ -3,6 +3,7 @@ import { BrowserWindow, app } from 'electron/main';
 
 import { expect } from 'chai';
 
+import { execSync } from 'node:child_process';
 import { once } from 'node:events';
 import * as fs from 'node:fs';
 import * as http from 'node:http';
@@ -17,6 +18,15 @@ describe('shell module', () => {
     let envVars: Record<string, string | undefined> = {};
     let server: http.Server;
 
+    after(function () {
+      this.timeout(60000);
+      if (process.env.CI && process.platform === 'win32') {
+        // Edge may cause issues with visibility tests, so make sure it is closed after testing.
+        const killEdge = 'Get-Process | Where Name -Like "msedge" | Stop-Process';
+        execSync(killEdge, { shell: 'powershell.exe' });
+      }
+    });
+
     beforeEach(function () {
       envVars = {
         display: process.env.DISPLAY,

filename: spec/chromium-spec.ts
patch: @@ -655,9 +655,7 @@ describe('chromium features', () => {
       expect(size).to.be.a('number');
     });
 
-    // TODO: Re-enable for windows on GitHub Actions,
-    // fullscreen tests seem to hang on GHA specifically
-    ifit(process.platform !== 'win32' || process.arch === 'arm64')('should lock the keyboard', async () => {
+    it('should lock the keyboard', async () => {
       const w = new BrowserWindow({ show: true });
       await w.loadFile(path.join(fixturesPath, 'pages', 'modal.html'));
 
@@ -2982,9 +2980,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
     server.close();
   });
 
-  // TODO: Re-enable for windows on GitHub Actions,
-  // fullscreen tests seem to hang on GHA specifically
-  ifit(process.platform !== 'darwin' && (process.platform !== 'win32' || process.arch === 'arm64'))('can fullscreen from out-of-process iframes (non-macOS)', async () => {
+  ifit(process.platform !== 'darwin')('can fullscreen from out-of-process iframes (non-macOS)', async () => {
     const fullscreenChange = once(ipcMain, 'fullscreenChange');
     const html =
       `<iframe style="width: 0" frameborder=0 src="${crossSiteUrl}" allowfullscreen></iframe>`;
@@ -3039,7 +3035,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
 
   // TODO: Re-enable for windows on GitHub Actions,
   // fullscreen tests seem to hang on GHA specifically
-  ifit(process.platform !== 'win32' || process.arch === 'arm64')('can fullscreen from in-process iframes', async () => {
+  it('can fullscreen from in-process iframes', async () => {
     if (process.platform === 'darwin') await once(w, 'enter-full-screen');
 
     const fullscreenChange = once(ipcMain, 'fullscreenChange');
Repository: vercel/next.js
Pull request: [devtools] fix: error overlay closes when footer is clicked

https://github.com/vercel/next.js/pull/77327 should've added the footer to the dialog's click outside exclude list as is moving out from the dialog.

#### Before

https://github.com/user-attachments/assets/3ee79982-acc7-4783-b629-7132361463fd

#### After

https://github.com/user-attachments/assets/172e413d-5276-4dd5-a13c-936ba4bd5e6a

Changed files:
filename: packages/next/src/next-devtools/dev-overlay/components/dialog/dialog.tsx
patch: @@ -18,6 +18,7 @@ const CSS_SELECTORS_TO_EXCLUDE_ON_CLICK_OUTSIDE = [
   '[data-info-popover]',
   '[data-nextjs-devtools-panel-overlay]',
   '[data-nextjs-devtools-panel-footer]',
+  '[data-nextjs-error-overlay-footer]',
 ]
 
 const Dialog: React.FC<DialogProps> = function Dialog({

filename: packages/next/src/next-devtools/dev-overlay/components/errors/error-overlay-footer/error-overlay-footer.tsx
patch: @@ -7,7 +7,7 @@ export type ErrorOverlayFooterProps = {
 
 export function ErrorOverlayFooter({ errorCode }: ErrorOverlayFooterProps) {
   return (
-    <footer className="error-overlay-footer">
+    <footer data-nextjs-error-overlay-footer className="error-overlay-footer">
       {errorCode ? (
         <ErrorFeedback className="error-feedback" errorCode={errorCode} />
       ) : null}