helloadhavan/github_issues huggingface dataset:
Repository: denoland/deno
Pull request: fix(cache): added support for the --env-file flag

Adds support for the --env-file flag, allowing environment variables such as DENO_AUTH_TOKENS to be loaded from a file.

Changed files:
filename: cli/args/flags.rs
patch: @@ -1897,6 +1897,7 @@ Future runs of this module will trigger no downloads or compilation unless --rel
       .arg(frozen_lockfile_arg())
       .arg(allow_scripts_arg())
       .arg(allow_import_arg())
+      .arg(env_file_arg())
   })
 }
 
@@ -4659,6 +4660,7 @@ fn cache_parse(
   frozen_lockfile_arg_parse(flags, matches);
   allow_scripts_arg_parse(flags, matches)?;
   allow_import_parse(flags, matches)?;
+  env_file_arg_parse(flags, matches);
   let files = matches.remove_many::<String>("file").unwrap().collect();
   flags.subcommand = DenoSubcommand::Cache(CacheFlags { files });
   Ok(())
@@ -7584,6 +7586,18 @@ mod tests {
         ..Flags::default()
       }
     );
+
+    let r = flags_from_vec(svec!["deno", "cache", "--env-file", "script.ts"]);
+    assert_eq!(
+      r.unwrap(),
+      Flags {
+        subcommand: DenoSubcommand::Cache(CacheFlags {
+          files: svec!["script.ts"],
+        }),
+        env_file: Some(svec![".env"]),
+        ..Flags::default()
+      }
+    );
   }
 
   #[test]
Repository: facebook/react
Pull request: fix[devtools]: display NaN as string in values

## Summary

>Warning: Received NaN for the `children` attribute. If this is expected, cast the value to a string.

Fixes this warning, when we try to display NaN as NaN in key-value list.

Changed files:
filename: packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js
patch: @@ -255,6 +255,8 @@ export default function KeyValue({
       displayValue = 'null';
     } else if (value === undefined) {
       displayValue = 'undefined';
+    } else if (isNaN(value)) {
+      displayValue = 'NaN';
     }
 
     let shouldDisplayValueAsLink = false;
Repository: denoland/deno
Pull request: ci: fix uploading canary once more


Changed files:
filename: tools/release/upload_canary.ts
patch: @@ -25,8 +25,9 @@ async function uploadCanaryForCurrentArch(currentGitSha: string) {
 }
 
 async function uploadCanaryLatest(currentGitSha: string) {
-  const latestCanaryHash = $`gsutil cat gs://dl.deno.land/canary-latest.txt`
-    .text();
+  const latestCanaryHash =
+    await $`gsutil cat gs://dl.deno.land/canary-latest.txt`
+      .text();
   const commitExistsInHistory = await $`git cat-file -e ${latestCanaryHash}`;
 
   if (commitExistsInHistory.code === 0) {
Repository: nodejs/node
Pull request: doc: fix typo of file `http.md`, `outgoingMessage.setTimeout` section

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/http.md
patch: @@ -3322,13 +3322,13 @@ const server = http.createServer((req, res) => {
 });
 ```
 
-### `outgoingMessage.setTimeout(msesc[, callback])`
+### `outgoingMessage.setTimeout(msecs[, callback])`
 
 <!-- YAML
 added: v0.9.12
 -->
 
-* `msesc` {number}
+* `msecs` {number}
 * `callback` {Function} Optional function to be called when a timeout
   occurs. Same as binding to the `timeout` event.
 * Returns: {this}
Repository: ggml-org/llama.cpp
Pull request: convert : force setting sliding_window from original config

This commit modifies the set_gguf_parameters method for EmbeddingGemma so that it reads the sliding_window parameter from the original model config.json and uses that value.

The motivation for this change is that the Gemma3TextConfig constructor adjusts the sliding_window value, which can lead to inconsistencies when converting models as we expects this value to match the original model's configuration.

Refs: https://github.com/huggingface/transformers/blob/bb45d3631ec7026db04a77d33a52b31766372160/src/transformers/models/gemma3/configuration_gemma3.py#L230


Changed files:
filename: convert_hf_to_gguf.py
patch: @@ -5128,6 +5128,20 @@ class EmbeddingGemma(Gemma3Model):
 
     def set_gguf_parameters(self):
         super().set_gguf_parameters()
+
+        # Override the sliding window size as it gets adjusted by the Gemma3TextConfig
+        # constructor. We want to use the value from the original model's config.json.
+        # ref: https://github.com/huggingface/transformers/pull/40700
+        with open(self.dir_model / "config.json", "r", encoding="utf-8") as f:
+            config = json.load(f)
+            orig_sliding_window = config.get("sliding_window")
+            if orig_sliding_window is None:
+                raise ValueError("sliding_window not found in model config - this is required for the model")
+
+            logger.info(f"Using original sliding_window from config: {orig_sliding_window} "
+                        f"instead of {self.hparams['sliding_window']}")
+            self.gguf_writer.add_sliding_window(orig_sliding_window)
+
         self._try_set_pooling_type()
Repository: huggingface/transformers
Pull request: fix: ImageTextToTextPipeline handles user-defined generation_config

# What does this PR do?

This allows an ImageTextToTextPipeline object to handle a user-defined generation_config passed to the pipeline, the same way a TextGenerationPipeline object does. Currently, it ignores these generation_config parameters set on pipeline object initialization, causing unexpected text generation behavior.

@Rocketknight1

Changed files:
filename: src/transformers/pipelines/image_text_to_text.py
patch: @@ -422,6 +422,11 @@ def _forward(self, model_inputs, generate_kwargs=None):
         input_ids = (
             model_inputs["input_ids"] if "input_ids" in model_inputs else model_inputs["decoder_input_ids"]
         )  # for decoder-only models
+
+        # User-defined `generation_config` passed to the pipeline call take precedence
+        if "generation_config" not in generate_kwargs:
+            generate_kwargs["generation_config"] = self.generation_config
+
         generated_sequence = self.model.generate(**model_inputs, **generate_kwargs)
 
         return {"generated_sequence": generated_sequence, "prompt_text": prompt_text, "input_ids": input_ids}
Repository: ggml-org/llama.cpp
Pull request: llama : fix incorrect model type for  Gemma 270M

This commit fixes the model type for the Gemma 270M model in llama_model.cpp which should be LLM_TYPE_270M. I incorrectly added this previously as LLM_TYPE_537M which was wrong.

The motivation for this is that it causes the model to not be identified properly when using tools like llama-bench. For example:
```console
$ ./build/bin/llama-bench -m models/gemma-3-270m-Q8_0.gguf
| model                          |       size | ...
| ------------------------------ | ---------: | ...
| gemma3 ?B Q8_0                 | 271.81 MiB | ...
| gemma3 ?B Q8_0                 | 271.81 MiB | ...
```

With the changes in this commit the output will be:
```console
$ ./build/bin/llama-bench -m models/gemma-3-270m-Q8_0.gguf
| model                          |       size | ...
| ------------------------------ | ---------: | ...
| gemma3 270M Q8_0               | 271.81 MiB | ...
| gemma3 270M Q8_0               | 271.81 MiB | ...
```


Changed files:
filename: src/llama-model.cpp
patch: @@ -1110,7 +1110,7 @@ void llama_model::load_hparams(llama_model_loader & ml) {
                 ml.get_key(LLM_KV_ATTENTION_LAYERNORM_RMS_EPS, hparams.f_norm_rms_eps);
 
                 switch (hparams.n_layer) {
-                    case 18: type = LLM_TYPE_537M; break;
+                    case 18: type = LLM_TYPE_270M; break;
                     case 26: type = LLM_TYPE_1B; break;
                     case 34: type = LLM_TYPE_4B; break;
                     case 48: type = LLM_TYPE_12B; break;

filename: src/llama-model.h
patch: @@ -39,7 +39,6 @@ enum llm_type {
     LLM_TYPE_410M,
     LLM_TYPE_450M,
     LLM_TYPE_475M,
-    LLM_TYPE_537M,
     LLM_TYPE_558M,
     LLM_TYPE_700M,
     LLM_TYPE_770M,
Repository: huggingface/transformers
Pull request: Update `GemmaIntegrationTest::test_model_2b_bf16_dola`

# What does this PR do?

The value is changed after #39120 but remain reasonable. Not sure the root reason why this might be changed though

Changed files:
filename: tests/models/gemma/test_modeling_gemma.py
patch: @@ -492,7 +492,7 @@ def test_model_2b_bf16_dola(self):
                 ],
                 ("cuda", 8): [
                     "Hello I am doing an experiment and need to get the mass of a block. The only tool I have is a scale",
-                    "Hi today we have the review for a <strong>2016/2017</strong> season of",
+                    "Hi today we have the review for a brand new set, this is the <strong>Lego</strong> set number ",
                 ],
             }
         )
Repository: nodejs/node
Pull request: sqlite: set `name` and `length` on `sqlite.backup()`


Changed files:
filename: src/node_sqlite.cc
patch: @@ -2686,9 +2686,11 @@ static void Initialize(Local<Object> target,
 
   Local<Function> backup_function;
 
-  if (!Function::New(context, Backup).ToLocal(&backup_function)) {
+  if (!Function::New(context, Backup, Local<Value>(), 2)
+           .ToLocal(&backup_function)) {
     return;
   }
+  backup_function->SetName(env->backup_string());
 
   target->Set(context, env->backup_string(), backup_function).Check();
 }

filename: test/parallel/test-sqlite-backup.mjs
patch: @@ -307,3 +307,8 @@ test('backup fails when path cannot be opened', async (t) => {
     message: 'unable to open database file'
   });
 });
+
+test('backup has correct name and length', (t) => {
+  t.assert.strictEqual(backup.name, 'backup');
+  t.assert.strictEqual(backup.length, 2);
+});
Repository: denoland/deno
Pull request: ci: fix uploading canary, again


Changed files:
filename: tools/release/upload_canary.ts
patch: @@ -5,14 +5,15 @@
 
 import { $ } from "jsr:@david/dax@0.41.0";
 
-async function uploadCanaryForCurrentArch(currentGitSha) {
+async function uploadCanaryForCurrentArch(currentGitSha: string) {
   const currentGitRev = await $`git rev-parse HEAD`.text();
   await $`gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs://dl.deno.land/canary/${currentGitRev}/`;
   await $`gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.sha256sum gs://dl.deno.land/canary/${currentGitRev}/`;
   await $`gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.symcache gs://dl.deno.land/canary/${currentGitRev}/`;
-  const llvmTriple = await $`rustc -vV | sed -n "s|host: ||p"`;
+  const llvmTriple = await $`rustc -vV | sed -n "s|host: ||p"`.text();
   const latestCanaryHash =
-    await $`gsutil cat gs://dl.deno.land/canary-${llvmTriple}-latest.txt`;
+    await $`gsutil cat gs://dl.deno.land/canary-${llvmTriple}-latest.txt`
+      .text();
   const commitExistsInHistory = await $`git cat-file -e ${latestCanaryHash}`;
 
   if (commitExistsInHistory.code === 0) {
@@ -23,8 +24,9 @@ async function uploadCanaryForCurrentArch(currentGitSha) {
   }
 }
 
-async function uploadCanaryLatest(currentGitSha) {
-  const latestCanaryHash = $`gsutil cat gs://dl.deno.land/canary-latest.txt`;
+async function uploadCanaryLatest(currentGitSha: string) {
+  const latestCanaryHash = $`gsutil cat gs://dl.deno.land/canary-latest.txt`
+    .text();
   const commitExistsInHistory = await $`git cat-file -e ${latestCanaryHash}`;
 
   if (commitExistsInHistory.code === 0) {
Repository: vercel/next.js
Pull request: Remove unused `syncDynamicExpression`

The `syncDynamicExpression` property of `DynamicTrackingState` is not used anymore.

Changed files:
filename: packages/next/src/server/app-render/dynamic-rendering.ts
patch: @@ -71,7 +71,6 @@ export type DynamicTrackingState = {
    */
   readonly dynamicAccesses: Array<DynamicAccess>
 
-  syncDynamicExpression: undefined | string
   syncDynamicErrorWithStack: null | Error
 }
 
@@ -90,7 +89,6 @@ export function createDynamicTrackingState(
   return {
     isDebugDynamicAccesses,
     dynamicAccesses: [],
-    syncDynamicExpression: undefined,
     syncDynamicErrorWithStack: null,
   }
 }
@@ -292,7 +290,6 @@ export function abortOnSynchronousPlatformIOAccess(
   // called the sync IO expression in the first place.
   if (dynamicTracking) {
     if (dynamicTracking.syncDynamicErrorWithStack === null) {
-      dynamicTracking.syncDynamicExpression = expression
       dynamicTracking.syncDynamicErrorWithStack = errorWithStack
     }
   }
@@ -337,7 +334,6 @@ export function abortAndThrowOnSynchronousRequestDataAccess(
     const dynamicTracking = prerenderStore.dynamicTracking
     if (dynamicTracking) {
       if (dynamicTracking.syncDynamicErrorWithStack === null) {
-        dynamicTracking.syncDynamicExpression = expression
         dynamicTracking.syncDynamicErrorWithStack = errorWithStack
       }
     }
Repository: huggingface/transformers
Pull request: Fix tests due to breaking change in accelerate

# What does this PR do?
This PR updates trainer tests due to a breaking change in https://github.com/huggingface/accelerate/pull/3684.

To be merged when accelerate will be released 

Changed files:
filename: tests/trainer/test_trainer.py
patch: @@ -3394,7 +3394,7 @@ def test_auto_batch_size_with_deepspeed(self):
         )
         trainer = Trainer(model, args, train_dataset=train_dataset, callbacks=[MockCudaOOMCallback()])
         trainer.train()
-        self.assertEqual(trainer._train_batch_size, 8)
+        self.assertEqual(trainer._train_batch_size, 14)
 
     def test_auto_batch_size_with_resume_from_checkpoint(self):
         train_dataset = RegressionDataset(length=128)
@@ -3414,16 +3414,16 @@ def test_auto_batch_size_with_resume_from_checkpoint(self):
         )
         trainer = Trainer(model, args, train_dataset=train_dataset, callbacks=[MockCudaOOMCallback()])
         trainer.train()
-        # After `auto_find_batch_size` is ran we should now be at 8
-        self.assertEqual(trainer._train_batch_size, 8)
+        # After `auto_find_batch_size` is ran we should now be at 16*0.9=14
+        self.assertEqual(trainer._train_batch_size, 14)
 
         # We can then make a new Trainer
         trainer = Trainer(model, args, train_dataset=train_dataset)
         # Check we are at 16 to start
         self.assertEqual(trainer._train_batch_size, 16 * max(trainer.args.n_gpu, 1))
         trainer.train(resume_from_checkpoint=True)
-        # We should be back to 8 again, picking up based upon the last ran Trainer
-        self.assertEqual(trainer._train_batch_size, 8)
+        # We should be back to 14 again, picking up based upon the last ran Trainer
+        self.assertEqual(trainer._train_batch_size, 14)
 
     # regression for this issue: https://github.com/huggingface/transformers/issues/12970
     def test_training_with_resume_from_checkpoint_false(self):

filename: tests/trainer/test_trainer_utils.py
patch: @@ -464,7 +464,7 @@ def mock_training_loop_function(batch_size):
                 raise RuntimeError("CUDA out of memory.")
 
         mock_training_loop_function()
-        self.assertEqual(batch_sizes, [64, 32, 16])
+        self.assertEqual(batch_sizes, [64, 57, 51, 45, 40, 36, 32, 28, 25, 22, 19, 17, 15])
 
     @require_accelerate
     def test_executable_batch_size_no_search(self):
Repository: denoland/deno
Pull request: fix: handling of contradictory global permission flags


Changed files:
filename: runtime/permissions/lib.rs
patch: @@ -410,6 +410,8 @@ impl<TQuery: QueryDescriptor> UnaryPermission<TQuery> {
 
   pub fn is_allow_all(&self) -> bool {
     self.granted_global
+      && !self.flag_denied_global
+      && !self.prompt_denied_global
       && self.flag_denied_list.is_empty()
       && self.prompt_denied_list.is_empty()
   }
@@ -4844,6 +4846,30 @@ mod tests {
     assert!(perms.write.check(&write_query, None).is_err());
   }
 
+  #[test]
+  fn test_check_allow_global_deny_global() {
+    let parser = TestPermissionDescriptorParser;
+    let mut perms = Permissions::from_options(
+      &parser,
+      &PermissionsOptions {
+        allow_read: Some(vec![]),
+        deny_read: Some(vec![]),
+        allow_write: Some(vec![]),
+        deny_write: Some(vec![]),
+        ..Default::default()
+      },
+    )
+    .unwrap();
+
+    assert!(perms.read.check_all(None).is_err());
+    let read_query = parser.parse_path_query("/foo").unwrap().into_read();
+    assert!(perms.read.check(&read_query, None).is_err());
+
+    assert!(perms.write.check_all(None).is_err());
+    let write_query = parser.parse_path_query("/foo").unwrap().into_write();
+    assert!(perms.write.check(&write_query, None).is_err());
+  }
+
   #[test]
   fn test_net_fully_qualified_domain_name() {
     set_prompter(Box::new(TestPrompter));
Repository: nodejs/node
Pull request: test: add `Float16Array` to `common.getArrayBufferViews()`


Changed files:
filename: test/common/index.js
patch: @@ -703,6 +703,7 @@ function getArrayBufferViews(buf) {
     Uint16Array,
     Int32Array,
     Uint32Array,
+    Float16Array,
     Float32Array,
     Float64Array,
     BigInt64Array,

filename: test/parallel/test-stream-typedarray.js
patch: @@ -63,7 +63,7 @@ const views = common.getArrayBufferViews(buffer);
         assert.strictEqual(chunk.encoding, 'buffer');
         res += chunk.chunk;
       }
-      assert.strictEqual(res, 'ABCD'.repeat(9));
+      assert.strictEqual(res, 'ABCD'.repeat(views.length));
     }),
 
   });
Repository: vercel/next.js
Pull request: Configure `url` for responses from patched fetch like the original `response.url`

The main config that was missing is enumerability which is relevant for showing properties in the Chrome performance track and inferring shorthands.

Changed files:
filename: packages/next/src/server/lib/clone-response.ts
patch: @@ -27,6 +27,10 @@ export function cloneResponse(original: Response): [Response, Response] {
 
   Object.defineProperty(cloned1, 'url', {
     value: original.url,
+    // How the original response.url behaves
+    configurable: true,
+    enumerable: true,
+    writable: false,
   })
 
   const cloned2 = new Response(body2, {
@@ -37,6 +41,10 @@ export function cloneResponse(original: Response): [Response, Response] {
 
   Object.defineProperty(cloned2, 'url', {
     value: original.url,
+    // How the original response.url behaves
+    configurable: true,
+    enumerable: true,
+    writable: false,
   })
 
   return [cloned1, cloned2]

filename: test/development/app-dir/react-performance-track/react-performance-track.test.ts
patch: @@ -29,9 +29,13 @@ describe('react-performance-track', () => {
     expect(track).toEqual(
       expect.arrayContaining([
         {
-          // TODO: Should include the URL.
-          name: 'fetch',
-          properties: expect.arrayContaining([['status', '200']]),
+          // React might decide to display the shorthand in round brackets differently.
+          // Double check with React changes if a shorthand change is intended.
+          name: 'fetch (random)',
+          properties: expect.arrayContaining([
+            ['status', '200'],
+            ['url', '"https://next-data-api-endpoint.vercel.app/api/random"'],
+          ]),
         },
       ])
     )
Repository: electron/electron
Pull request: feat: remove osr framerate limit when use shared texture

Backport of #45669

See that PR for details.


Notes: Remove 240 FPS limit when use shared texture OSR.

Changed files:
filename: docs/tutorial/offscreen-rendering.md
patch: @@ -14,7 +14,7 @@ _Notes_:
 * There are two rendering modes that can be used (see the section below) and only
 the dirty area is passed to the `paint` event to be more efficient.
 * You can stop/continue the rendering as well as set the frame rate.
-* The maximum frame rate is 240 because greater values bring only performance
+* When `webPreferences.offscreen.useSharedTexture` is not `true`, the maximum frame rate is 240 because greater values bring only performance
 losses with no benefits.
 * When nothing is happening on a webpage, no frames are generated.
 * An offscreen window is always created as a

filename: shell/browser/osr/osr_render_widget_host_view.cc
patch: @@ -918,7 +918,7 @@ void OffScreenRenderWidgetHostView::SetFrameRate(int frame_rate) {
   } else {
     if (frame_rate <= 0)
       frame_rate = 1;
-    if (frame_rate > 240)
+    if (!offscreen_use_shared_texture_ && frame_rate > 240)
       frame_rate = 240;
 
     frame_rate_ = frame_rate;
Repository: denoland/deno
Pull request: ci: fix uploading canary


Changed files:
filename: tools/release/upload_canary.ts
patch: @@ -6,7 +6,7 @@
 import { $ } from "jsr:@david/dax@0.41.0";
 
 async function uploadCanaryForCurrentArch(currentGitSha) {
-  const currentGitRev = await $`git rev-parse HEAD`;
+  const currentGitRev = await $`git rev-parse HEAD`.text();
   await $`gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs://dl.deno.land/canary/${currentGitRev}/`;
   await $`gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.sha256sum gs://dl.deno.land/canary/${currentGitRev}/`;
   await $`gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.symcache gs://dl.deno.land/canary/${currentGitRev}/`;
Repository: facebook/react
Pull request: Convert ReactCompositeComponentNestedState to createRoot


Changed files:
filename: packages/react-dom/src/__tests__/ReactCompositeComponentNestedState-test.js
patch: @@ -10,15 +10,17 @@
 'use strict';
 
 let React;
-let ReactDOM;
+let ReactDOMClient;
+let act;
 
 describe('ReactCompositeComponentNestedState-state', () => {
   beforeEach(() => {
     React = require('react');
-    ReactDOM = require('react-dom');
+    ReactDOMClient = require('react-dom/client');
+    act = require('internal-test-utils').act;
   });
 
-  it('should provide up to date values for props', () => {
+  it('should provide up to date values for props', async () => {
     class ParentComponent extends React.Component {
       state = {color: 'blue'};
 
@@ -96,11 +98,16 @@ describe('ReactCompositeComponentNestedState-state', () => {
     document.body.appendChild(container);
 
     const logger = jest.fn();
+    const root = ReactDOMClient.createRoot(container);
 
-    void ReactDOM.render(<ParentComponent logger={logger} />, container);
+    await act(async () => {
+      root.render(<ParentComponent logger={logger} />);
+    });
 
-    // click "light green"
-    container.childNodes[0].childNodes[3].click();
+    await act(async () => {
+      // click "light green"
+      container.childNodes[0].childNodes[3].click();
+    });
 
     expect(logger.mock.calls).toEqual([
       ['parent-render', 'blue'],