Repository: denoland/deno
Pull request: Revert "test: disable more tests on Mac Intel (#31541)"

This reverts commit dd80d7575f7c07e2eaa73ad76ce3d811fb61f1b0.

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->


Changed files:
filename: tests/integration/compile_tests.rs
patch: @@ -1,17 +1,11 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 
-// NB(bartlomieju): a bunch of code is not used on Mac Intel
-#![allow(dead_code)]
-#![allow(unused_imports)]
-
 use test_util as util;
 use util::TestContext;
 use util::TestContextBuilder;
 use util::assert_not_contains;
 use util::testdata_path;
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn compile_basic() {
   let context = TestContextBuilder::new().build();
@@ -63,8 +57,6 @@ fn compile_basic() {
   output.assert_matches_text("Welcome to Deno!\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_args() {
   let context = TestContextBuilder::new().build();
@@ -96,8 +88,6 @@ fn standalone_args() {
     .assert_matches_text("a\nb\nfoo\n--bar\n--unstable\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_load_datauri() {
   let context = TestContextBuilder::new().build();
@@ -126,8 +116,7 @@ fn standalone_load_datauri() {
     .assert_matches_text("Hello Deno!\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
+// https://github.com/denoland/deno/issues/13704
 #[test]
 fn standalone_follow_redirects() {
   let context = TestContextBuilder::new().build();
@@ -273,8 +262,6 @@ fn compile_and_overwrite_file() {
   }
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_runtime_flags() {
   let context = TestContextBuilder::new().build();
@@ -311,8 +298,6 @@ fn standalone_runtime_flags() {
     );
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_ext_flag_ts() {
   let context = TestContextBuilder::new().build();
@@ -344,8 +329,6 @@ fn standalone_ext_flag_ts() {
     .assert_matches_text("executing typescript with no extension\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_ext_flag_js() {
   let context = TestContextBuilder::new().build();
@@ -376,8 +359,6 @@ fn standalone_ext_flag_js() {
     .assert_matches_text("executing javascript with no extension\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_import_map() {
   let context = TestContextBuilder::new().build();
@@ -409,8 +390,6 @@ fn standalone_import_map() {
     .assert_exit_code(0);
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn standalone_import_map_config_file() {
   let context = TestContextBuilder::new().build();
@@ -442,8 +421,6 @@ fn standalone_import_map_config_file() {
     .assert_exit_code(0);
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 // https://github.com/denoland/deno/issues/12670
 fn skip_rebundle() {
@@ -523,8 +500,6 @@ fn check_local_by_default2() {
     );
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn workers_basic() {
   let context = TestContext::with_http_server();
@@ -555,8 +530,6 @@ fn workers_basic() {
     .assert_matches_file("./compile/workers/basic.out");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn workers_not_in_module_map() {
   let context = TestContext::with_http_server();
@@ -586,8 +559,6 @@ fn workers_not_in_module_map() {
   ));
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn workers_with_include_flag() {
   let context = TestContext::with_http_server();
@@ -619,8 +590,6 @@ fn workers_with_include_flag() {
     .assert_matches_text("Hello from worker!\nReceived 42\nClosing\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn dynamic_import() {
   let context = TestContext::with_http_server();
@@ -651,8 +620,6 @@ fn dynamic_import() {
     .assert_exit_code(0);
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn dynamic_import_unanalyzable() {
   let context = TestContext::with_http_server();
@@ -807,8 +774,6 @@ testing[WILDCARD]this
     .assert_matches_text("2\n");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn compile_npm_bin_esm() {
   run_npm_bin_compile_test(RunNpmBinCompileOptions {
@@ -825,8 +790,6 @@ fn compile_npm_bin_esm() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn compile_npm_bin_cjs() {
   run_npm_bin_compile_test(RunNpmBinCompileOptions {
     input_specifier: "npm:@denotest/bin/cli-cjs",
@@ -842,8 +805,6 @@ fn compile_npm_bin_cjs() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn compile_npm_cowsay_main() {
   run_npm_bin_compile_test(RunNpmBinCompileOptions {
     input_specifier: "npm:cowsay@1.5.0",
@@ -859,8 +820,6 @@ fn compile_npm_cowsay_main() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn compile_npm_no_permissions() {
   run_npm_bin_compile_test(RunNpmBinCompileOptions {
     input_specifier: "npm:@denotest/cli-with-permissions@1.0.0",
@@ -876,8 +835,6 @@ fn compile_npm_no_permissions() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn compile_npm_cowsay_explicit() {
   run_npm_bin_compile_test(RunNpmBinCompileOptions {
     input_specifier: "npm:cowsay@1.5.0/cowsay",
@@ -893,8 +850,6 @@ fn compile_npm_cowsay_explicit() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn compile_npm_cowthink() {
   run_npm_bin_compile_test(RunNpmBinCompileOptions {
     input_specifier: "npm:cowsay@1.5.0/cowthink",
@@ -968,8 +923,6 @@ fn run_npm_bin_compile_test(opts: RunNpmBinCompileOptions) {
   output.assert_matches_file(opts.output_file);
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn compile_node_modules_symlink_outside() {
   // this code is using a canonicalized temp dir because otherwise
@@ -1038,8 +991,6 @@ fn compile_node_modules_symlink_outside() {
   output.assert_matches_file("compile/node_modules_symlink_outside/main.out");
 }
 
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 #[test]
 fn compile_node_modules_symlink_non_existent() {
   let context = TestContextBuilder::for_npm().use_temp_cwd().build();
@@ -1084,8 +1035,6 @@ Embedded Files
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn dynamic_imports_tmp_lit() {
   let context = TestContextBuilder::new().build();
   let dir = context.temp_dir();
@@ -1110,8 +1059,6 @@ fn dynamic_imports_tmp_lit() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn granular_unstable_features() {
   let context = TestContextBuilder::new().build();
   let dir = context.temp_dir();
@@ -1139,8 +1086,6 @@ fn granular_unstable_features() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn granular_unstable_features_config_file() {
   let context = TestContextBuilder::new().use_temp_cwd().build();
   let dir = context.temp_dir();
@@ -1178,8 +1123,6 @@ fn granular_unstable_features_config_file() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn dynamic_import_bad_data_uri() {
   let context = TestContextBuilder::new().build();
   let dir = context.temp_dir();
@@ -1209,8 +1152,6 @@ fn dynamic_import_bad_data_uri() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn standalone_config_file_respects_compiler_options() {
   let context = TestContextBuilder::new().build();
   let dir = context.temp_dir();
@@ -1240,8 +1181,6 @@ fn standalone_config_file_respects_compiler_options() {
 }
 
 #[test]
-// TODO: fix this, see https://github.com/denoland/sui/issues/43
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 fn standalone_jsr_dynamic_import() {
   let context = TestContextBuilder::for_jsr().build();
   let dir = context.temp_dir();

filename: tests/integration/init_tests.rs
patch: @@ -216,7 +216,6 @@ fn init_subcommand_empty() {
 }
 
 #[tokio::test]
-#[cfg(not(all(target_os = "macos", target_arch = "x86_64")))]
 async fn init_subcommand_serve() {
   let context = TestContextBuilder::for_jsr().use_temp_cwd().build();
   let cwd = context.temp_dir().path();