helloadhavan/github_issues huggingface dataset:
Repository: ollama/ollama
Pull request: make response errors unique for error trace


Changed files:
filename: server/images.go
patch: @@ -510,7 +510,7 @@ func CopyModel(src, dest string) error {
 		return err
 	}
 
-	err = ioutil.WriteFile(destPath, input, 0644)
+	err = ioutil.WriteFile(destPath, input, 0o644)
 	if err != nil {
 		fmt.Println("Error reading file:", err)
 		return err
@@ -669,7 +669,7 @@ func PushModel(name string, regOpts *RegistryOptions, fn func(api.ProgressRespon
 	// Check for success: For a successful upload, the Docker registry will respond with a 201 Created
 	if resp.StatusCode != http.StatusCreated {
 		body, _ := io.ReadAll(resp.Body)
-		return fmt.Errorf("registry responded with code %d: %v", resp.StatusCode, string(body))
+		return fmt.Errorf("on push registry responded with code %d: %v", resp.StatusCode, string(body))
 	}
 
 	fn(api.ProgressResponse{Status: "success"})
@@ -743,7 +743,7 @@ func pullModelManifest(mp ModelPath, regOpts *RegistryOptions) (*ManifestV2, err
 	// Check for success: For a successful upload, the Docker registry will respond with a 201 Created
 	if resp.StatusCode != http.StatusOK {
 		body, _ := io.ReadAll(resp.Body)
-		return nil, fmt.Errorf("registry responded with code %d: %s", resp.StatusCode, body)
+		return nil, fmt.Errorf("on pull registry responded with code %d: %s", resp.StatusCode, body)
 	}
 
 	var m *ManifestV2
@@ -807,7 +807,7 @@ func startUpload(mp ModelPath, regOpts *RegistryOptions) (string, error) {
 	// Check for success
 	if resp.StatusCode != http.StatusAccepted {
 		body, _ := io.ReadAll(resp.Body)
-		return "", fmt.Errorf("registry responded with code %d: %s", resp.StatusCode, body)
+		return "", fmt.Errorf("on upload registry responded with code %d: %s", resp.StatusCode, body)
 	}
 
 	// Extract UUID location from header
@@ -896,7 +896,7 @@ func uploadBlobChunked(mp ModelPath, location string, layer *Layer, regOpts *Reg
 				Completed: int(totalUploaded),
 			})
 			body, _ := io.ReadAll(resp.Body)
-			return fmt.Errorf("registry responded with code %d: %v", resp.StatusCode, string(body))
+			return fmt.Errorf("on layer upload registry responded with code %d: %v", resp.StatusCode, string(body))
 		}
 
 		totalUploaded += n
@@ -913,7 +913,7 @@ func uploadBlobChunked(mp ModelPath, location string, layer *Layer, regOpts *Reg
 
 			if resp.StatusCode != http.StatusCreated {
 				body, _ := io.ReadAll(resp.Body)
-				return fmt.Errorf("registry responded with code %d: %v", resp.StatusCode, string(body))
+				return fmt.Errorf("on finish upload registry responded with code %d: %v", resp.StatusCode, string(body))
 			}
 			break
 		}
@@ -964,7 +964,7 @@ func downloadBlob(mp ModelPath, digest string, regOpts *RegistryOptions, fn func
 
 	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusPartialContent {
 		body, _ := ioutil.ReadAll(resp.Body)
-		return fmt.Errorf("registry responded with code %d: %v", resp.StatusCode, string(body))
+		return fmt.Errorf("on download registry responded with code %d: %v", resp.StatusCode, string(body))
 	}
 
 	err = os.MkdirAll(path.Dir(fp), 0o700)
Repository: denoland/deno
Pull request: feat(unstable): add DENO_NODE_CONDITIONS env var

Follow up to https://github.com/denoland/deno/pull/29586 that
adds a `DENO_NODE_CONDITIONS` env var that allows to
specify conditional exports when the user can't control
CLI flags passed to the command (eg. on Deploy).

Changed files:
filename: cli/args/flags.rs
patch: @@ -4577,6 +4577,7 @@ fn lock_args() -> [Arg; 3] {
 fn node_conditions_arg() -> Arg {
   Arg::new("unstable-node-conditions")
     .long("unstable-node-conditions")
+    .help("Use this argument to specify custom conditions for npm package exports. You can also use DENO_NODE_CONDITIONS env var.")
     .use_value_delimiter(true)
     .action(ArgAction::Append)
 }

filename: cli/main.rs
patch: @@ -548,6 +548,14 @@ fn resolve_flags_and_init(
 
   load_env_variables_from_env_file(flags.env_file.as_ref(), flags.log_level);
   flags.unstable_config.fill_with_env();
+  if flags.node_conditions.is_empty() {
+    if let Ok(conditions) = std::env::var("DENO_NODE_CONDITIONS") {
+      flags.node_conditions = conditions
+        .split(",")
+        .map(|c| c.trim().to_string())
+        .collect();
+    }
+  }
 
   let otel_config = flags.otel_config();
   init_logging(flags.log_level, Some(otel_config.clone()));

filename: tests/specs/run/conditional_exports/__test__.jsonc
patch: @@ -13,6 +13,14 @@
       "args": "run --unstable-node-conditions react-server -A main.js",
       "output": "condition.out",
       "exitCode": 1
+    },
+    {
+      "args": "run -A main.js",
+      "envs": {
+        "DENO_NODE_CONDITIONS": "react-server"
+      },
+      "output": "condition.out",
+      "exitCode": 1
     }
   ]
 }
Repository: nodejs/node
Pull request: doc: deprecate passing invalid types in fs.existsSync

Precursor to #55753

cc @aduh95 
<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/deprecations.md
patch: @@ -3772,6 +3772,20 @@ It is recommended to use the `new` qualifier instead. This applies to all REPL c
 
 <!-- md-lint skip-deprecation DEP0186 -->
 
+### DEP0187: Passing invalid argument types to `fs.existsSync`
+
+<!-- YAML
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55892
+    description: Documentation-only.
+-->
+
+Type: Documentation-only
+
+Passing non-supported argument types is deprecated and, instead of returning `false`,
+will throw an error in a future version.
+
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
 [RFC 8247 Section 2.4]: https://www.rfc-editor.org/rfc/rfc8247#section-2.4
Repository: vercel/next.js
Pull request: Represent "virtual" segments like route groups

Small update to #82383. Instead of using a special symbol to represent the "virtual" segments that get inserted into the loader tree for parallel routes, we can represent them like route groups, since they serve the same purpose. That will allow us to remove a special case in the param parsing logic, since we have to skip groups regardless; both will be skipped by the same check.

Changed files:
filename: crates/next-core/src/app_structure.rs
patch: @@ -1054,7 +1054,7 @@ async fn directory_tree_to_loader_tree_internal(
     let current_level_is_parallel_route = is_parallel_route(&directory_name);
 
     if current_level_is_parallel_route {
-        tree.segment = rcstr!("__virtual_segment__");
+        tree.segment = rcstr!("(slot)");
     }
 
     if let Some(page) = (app_path == for_app_path || app_path.is_catchall())

filename: packages/next/src/build/webpack/loaders/next-app-loader/index.ts
patch: @@ -397,7 +397,7 @@ async function createTreeCodeFromPath(
       // should instead be the corresponding segment keys (ie `__PAGE__`) or the `children` parallel route.
       parallelSegmentKey =
         parallelSegmentKey === PARALLEL_VIRTUAL_SEGMENT
-          ? '__virtual_segment__'
+          ? '(slot)'
           : parallelSegmentKey === PAGE_SEGMENT
             ? PAGE_SEGMENT_KEY
             : parallelSegmentKey
Repository: electron/electron
Pull request: perf: avoid double map lookup in `WebFrameMain::UpdateRenderFrameHost()`

Backport of #46293

See that PR for details.


Notes: none.

Changed files:
filename: shell/browser/api/electron_api_web_frame_main.cc
patch: @@ -194,8 +194,8 @@ void WebFrameMain::UpdateRenderFrameHost(content::RenderFrameHost* rfh) {
   // Ensure that RFH being swapped in doesn't already exist as its own
   // WebFrameMain instance.
   frame_token_ = rfh->GetGlobalFrameToken();
-  DCHECK(!GetFrameTokenMap().contains(frame_token_));
-  GetFrameTokenMap().emplace(frame_token_, this);
+  const auto [_, inserted] = GetFrameTokenMap().emplace(frame_token_, this);
+  DCHECK(inserted);
 
   render_frame_disposed_ = false;
   TeardownMojoConnection();
Repository: ollama/ollama
Pull request: allocate a large enough tokens slice

cherry picked from #102 

Changed files:
filename: llama/llama.go
patch: @@ -168,7 +168,7 @@ func (llm *llama) tokenize(prompt string) []C.llama_token {
 	cPrompt := C.CString(prompt)
 	defer C.free(unsafe.Pointer(cPrompt))
 
-	tokens := make([]C.llama_token, llm.NumCtx)
+	tokens := make([]C.llama_token, len(prompt)+1)
 	if n := C.llama_tokenize(llm.ctx, cPrompt, unsafe.SliceData(tokens), C.int(len(tokens)), true); n > 0 {
 		return tokens[:n]
 	}
Repository: electron/electron
Pull request: perf: avoid double map lookup in `WebFrameMain::UpdateRenderFrameHost()`

#### Description of Change

Remove another redundant map lookup. This one was in `WebFrameMain::UpdateRenderFrameHost()`.

Fix is similar to #46238

#### Checklist

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none.

Changed files:
filename: shell/browser/api/electron_api_web_frame_main.cc
patch: @@ -193,8 +193,8 @@ void WebFrameMain::UpdateRenderFrameHost(content::RenderFrameHost* rfh) {
   // Ensure that RFH being swapped in doesn't already exist as its own
   // WebFrameMain instance.
   frame_token_ = rfh->GetGlobalFrameToken();
-  DCHECK(!GetFrameTokenMap().contains(frame_token_));
-  GetFrameTokenMap().emplace(frame_token_, this);
+  const auto [_, inserted] = GetFrameTokenMap().emplace(frame_token_, this);
+  DCHECK(inserted);
 
   render_frame_disposed_ = false;
   TeardownMojoConnection();
Repository: ggml-org/llama.cpp
Pull request: kleidiai: fix GGML_ASSERT(*cur_backend_id != -1) failed

This patch fixes the assert issue for the latest whisper.cpp when KleidiAI is enabled: ggml/src/ggml-backend.cpp:1088: GGML_ASSERT(*cur_backend_id != -1) failed.

Changed files:
filename: ggml/src/ggml-cpu/kleidiai/kleidiai.cpp
patch: @@ -515,9 +515,6 @@ class extra_buffer_type : ggml::cpu::extra_buffer_type {
             op->src[0]->buffer &&
             (ggml_n_dims(op->src[0]) == 2) &&
             op->src[0]->buffer->buft == ggml_backend_cpu_kleidiai_buffer_type() && ctx.kernels) {
-            if (op->op == GGML_OP_GET_ROWS && op->src[1]->ne[0] != 8) {
-                return false;
-            }
             if (op->src[1]->buffer && !ggml_backend_buft_is_host(op->src[1]->buffer->buft)) {
                 return false;
             }
Repository: nodejs/node
Pull request: build: use glob for dependencies of out/Makefile

The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed.

Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: Makefile
patch: @@ -171,8 +171,7 @@ with-code-cache test-code-cache:
 	$(warning '$@' target is a noop)
 
 out/Makefile: config.gypi common.gypi node.gyp \
-	deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
-	deps/simdutf/simdutf.gyp deps/ada/ada.gyp deps/nbytes/nbytes.gyp \
+	deps/*/*.gyp \
 	tools/v8_gypfiles/toolchain.gypi \
 	tools/v8_gypfiles/features.gypi \
 	tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
Repository: denoland/deno
Pull request: fix(tsconfig): use tsc defaults for 'strict' and 'noImplicitOverride'

Closes #30038.

Changed files:
filename: libs/resolver/deno_json.rs
patch: @@ -295,10 +295,16 @@ pub fn get_base_compiler_options_for_emit(
       "moduleResolution": "NodeNext",
       "moduleDetection": "force",
       "noEmit": true,
-      "noImplicitOverride": true,
+      "noImplicitOverride": match defaults {
+        CompilerOptionsDefaults::Deno => true,
+        CompilerOptionsDefaults::TscCompatible => false,
+      },
       "resolveJsonModule": true,
       "sourceMap": false,
-      "strict": true,
+      "strict": match defaults {
+        CompilerOptionsDefaults::Deno => true,
+        CompilerOptionsDefaults::TscCompatible => false,
+      },
       "target": "esnext",
       "tsBuildInfoFile": "internal:///.tsbuildinfo",
       "useDefineForClassFields": true,

filename: tests/specs/check/tsconfig_non_strict_defaults/__test__.jsonc
patch: @@ -0,0 +1,4 @@
+{
+  "args": "check --quiet",
+  "output": ""
+}

filename: tests/specs/check/tsconfig_non_strict_defaults/deno.json
patch: @@ -0,0 +1 @@
+{}

filename: tests/specs/check/tsconfig_non_strict_defaults/main.ts
patch: @@ -0,0 +1,83 @@
+// Assumes `"strictNullChecks": false`.
+{
+  const foo: string | null = eval('"foo"');
+  foo.length;
+}
+
+// Assumes `"strictBindCallApply": false`.
+{
+  function fn1(x: string) {
+    return console.log(x);
+  }
+  fn1.call(undefined, 1);
+}
+
+// Assumes `"strictBuiltinIteratorReturn": false`.
+{
+  const foo = [];
+  const iterator = foo[Symbol.iterator]();
+  const entry = iterator.next();
+  if (entry.done) {
+    const bar: string = entry.value;
+    bar;
+  }
+}
+
+// Assumes `"strictFunctionTypes": false`.
+{
+  function fn2(x: string) {
+    console.log(x);
+  }
+  type StringOrNumberFunc = (ns: string | number) => void;
+  const func: StringOrNumberFunc = fn2;
+  func;
+}
+
+// Assumes `"strictPropertyInitialization": false`.
+{
+  class Foo {
+    bar: string;
+  }
+  new Foo();
+}
+
+// Assumes `"noImplicitAny": false`.
+{
+  function fn3(s) {
+    console.log(s.length);
+  }
+  fn3(1);
+}
+
+// Assumes `"noImplicitThis": false`.
+{
+  class Foo {
+    bar: number = 1;
+    method() {
+      return function () {
+        return this.bar;
+      };
+    }
+  }
+  new Foo();
+}
+
+// Assumes `"useUnknownInCatchVariables": false`.
+{
+  try {
+    // ...
+  } catch (err) {
+    err.stack;
+  }
+}
+
+// Assumes `"noImplicitOverride": false`.
+{
+  class Foo {
+    method() {}
+  }
+  class Bar extends Foo {
+    method() {}
+  }
+  new Bar();
+}

filename: tests/specs/check/tsconfig_non_strict_defaults/tsconfig.json
patch: @@ -0,0 +1,5 @@
+{
+  // It shouldn't matter that the tsconfig doesn't include any files, only that
+  // it's detected in the workspace.
+  "include": []
+}
Repository: ggml-org/llama.cpp
Pull request: ggml-cpu: cmake add arm64 cpu feature check for macos

Add fixe for https://github.com/ggerganov/llama.cpp/issues/10435


Changed files:
filename: ggml/src/ggml-cpu/CMakeLists.txt
patch: @@ -96,6 +96,39 @@ if (CMAKE_OSX_ARCHITECTURES      STREQUAL "arm64" OR
         endif ()
 
         set(CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS_PREV})
+    elseif (APPLE)
+        if (GGML_NATIVE)
+            set(USER_PROVIDED_MARCH FALSE)
+            foreach(flag_var IN ITEMS CMAKE_C_FLAGS CMAKE_CXX_FLAGS CMAKE_REQUIRED_FLAGS)
+                if ("${${flag_var}}" MATCHES "-march=[a-zA-Z0-9+._-]+")
+                    set(USER_PROVIDED_MARCH TRUE)
+                    break()
+                endif()
+            endforeach()
+
+            if (NOT USER_PROVIDED_MARCH)
+                set(MARCH_FLAGS "-march=armv8.2a")
+
+                check_cxx_source_compiles("#include <arm_neon.h>\nint main() { int8x16_t _a, _b; int32x4_t _s = vdotq_s32(_s, _a, _b); return 0; }" GGML_COMPILER_SUPPORT_DOTPROD)
+                if (GGML_COMPILER_SUPPORT_DOTPROD)
+                    set(MARCH_FLAGS "${MARCH_FLAGS}+dotprod")
+                    add_compile_definitions(__ARM_FEATURE_DOTPROD)
+                endif ()
+
+                set(TEST_I8MM_FLAGS "-march=armv8.2a+i8mm")
+
+                set(CMAKE_REQUIRED_FLAGS_SAVE ${CMAKE_REQUIRED_FLAGS})
+                set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${TEST_I8MM_FLAGS}")
+                check_cxx_source_compiles("#include <arm_neon.h>\nint main() { int8x16_t _a, _b; int32x4_t _s = vmmlaq_s32(_s, _a, _b); return 0; }" GGML_COMPILER_SUPPORT_MATMUL_INT8)
+                if (GGML_COMPILER_SUPPORT_MATMUL_INT8)
+                    set(MARCH_FLAGS "${MARCH_FLAGS}+i8mm")
+                    add_compile_definitions(__ARM_FEATURE_MATMUL_INT8)
+                endif ()
+                set(CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS_SAVE})
+
+                list(APPEND ARCH_FLAGS "${MARCH_FLAGS}")
+            endif ()
+        endif ()
     else()
         check_cxx_compiler_flag(-mfp16-format=ieee COMPILER_SUPPORTS_FP16_FORMAT_I3E)
         if (NOT "${COMPILER_SUPPORTS_FP16_FORMAT_I3E}" STREQUAL "")
Repository: ggml-org/llama.cpp
Pull request: server : add `/v1/health` endpoint

For consistency, add `/v1/health` endpoint - same as `/health`.

Changed files:
filename: tools/server/README.md
patch: @@ -393,7 +393,7 @@ node index.js
 
 ### GET `/health`: Returns health check result
 
-This endpoint is public (no API key check).
+This endpoint is public (no API key check). `/v1/health` also works.
 
 **Response format**
 

filename: tools/server/server.cpp
patch: @@ -4184,6 +4184,7 @@ int main(int argc, char ** argv) {
     auto middleware_validate_api_key = [&params, &res_error](const httplib::Request & req, httplib::Response & res) {
         static const std::unordered_set<std::string> public_endpoints = {
             "/health",
+            "/v1/health",
             "/models",
             "/v1/models",
             "/api/tags"
@@ -5232,6 +5233,7 @@ int main(int argc, char ** argv) {
 
     // register API routes
     svr->Get (params.api_prefix + "/health",              handle_health); // public endpoint (no API key check)
+    svr->Get (params.api_prefix + "/v1/health",           handle_health); // public endpoint (no API key check)
     svr->Get (params.api_prefix + "/metrics",             handle_metrics);
     svr->Get (params.api_prefix + "/props",               handle_props);
     svr->Post(params.api_prefix + "/props",               handle_props_change);
Repository: electron/electron
Pull request: perf: avoid double map lookup in `WebFrameMain::UpdateRenderFrameHost()`

Backport of #46293

See that PR for details.


Notes: none.

Changed files:
filename: shell/browser/api/electron_api_web_frame_main.cc
patch: @@ -193,8 +193,8 @@ void WebFrameMain::UpdateRenderFrameHost(content::RenderFrameHost* rfh) {
   // Ensure that RFH being swapped in doesn't already exist as its own
   // WebFrameMain instance.
   frame_token_ = rfh->GetGlobalFrameToken();
-  DCHECK(!GetFrameTokenMap().contains(frame_token_));
-  GetFrameTokenMap().emplace(frame_token_, this);
+  const auto [_, inserted] = GetFrameTokenMap().emplace(frame_token_, this);
+  DCHECK(inserted);
 
   render_frame_disposed_ = false;
   TeardownMojoConnection();
Repository: ggml-org/llama.cpp
Pull request: presets : fix pooling param for embedding models

fix #16451

No need to override the default pooling type of the embedding models.

Changed files:
filename: common/arg.cpp
patch: @@ -3859,7 +3859,6 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         [](common_params & params) {
             params.model.hf_repo = "ggml-org/bge-small-en-v1.5-Q8_0-GGUF";
             params.model.hf_file = "bge-small-en-v1.5-q8_0.gguf";
-            params.pooling_type = LLAMA_POOLING_TYPE_NONE;
             params.embd_normalize = 2;
             params.n_ctx = 512;
             params.verbose_prompt = true;
@@ -3873,7 +3872,6 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         [](common_params & params) {
             params.model.hf_repo = "ggml-org/e5-small-v2-Q8_0-GGUF";
             params.model.hf_file = "e5-small-v2-q8_0.gguf";
-            params.pooling_type = LLAMA_POOLING_TYPE_NONE;
             params.embd_normalize = 2;
             params.n_ctx = 512;
             params.verbose_prompt = true;
@@ -3887,7 +3885,6 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         [](common_params & params) {
             params.model.hf_repo = "ggml-org/gte-small-Q8_0-GGUF";
             params.model.hf_file = "gte-small-q8_0.gguf";
-            params.pooling_type = LLAMA_POOLING_TYPE_NONE;
             params.embd_normalize = 2;
             params.n_ctx = 512;
             params.verbose_prompt = true;