helloadhavan/github_issues huggingface dataset:
Repository: denoland/deno
Pull request: fix(coverage): HTML validation errors in coverage explorer

Closes #29493

Changed files:
filename: cli/tools/coverage/reporter.rs
patch: @@ -505,7 +505,7 @@ impl HtmlCoverageReporter {
     let footer = self.create_html_footer(timestamp);
     format!(
       "<!doctype html>
-      <html>
+      <html lang='en-US'>
         {head}
         <body>
           <div class='wrapper'>
@@ -530,7 +530,7 @@ impl HtmlCoverageReporter {
         <meta charset='utf-8'>
         <title>{title}</title>
         <style>{style_css}</style>
-        <meta name='viewport' content='width=device-width, initial-scale=1' />
+        <meta name='viewport' content='width=device-width, initial-scale=1'>
       </head>"
     )
   }
@@ -658,7 +658,7 @@ impl HtmlCoverageReporter {
   ) -> String {
     let line_num = file_text.lines().count();
     let line_count = (1..line_num + 1)
-      .map(|i| format!("<a name='L{i}'></a><a href='#L{i}'>{i}</a>"))
+      .map(|i| format!("<a href='#L{i}' id='L{i}'>{i}</a>"))
       .collect::<Vec<_>>()
       .join("\n");
     let line_coverage = (0..line_num)
@@ -667,12 +667,12 @@ impl HtmlCoverageReporter {
           report.found_lines.iter().find(|(line, _)| i == *line)
         {
           if *count == 0 {
-            "<span class='cline-any cline-no'>&nbsp</span>".to_string()
+            "<span class='cline-any cline-no'>&nbsp;</span>".to_string()
           } else {
             format!("<span class='cline-any cline-yes' title='This line is covered {count} time{}'>x{count}</span>", if *count > 1 { "s" } else { "" })
           }
         } else {
-          "<span class='cline-any cline-neutral'>&nbsp</span>".to_string()
+          "<span class='cline-any cline-neutral'>&nbsp;</span>".to_string()
         }
       })
       .collect::<Vec<_>>()

filename: tests/integration/coverage_tests.rs
patch: @@ -557,8 +557,7 @@ fn test_html_reporter() {
   // Check <T> in source code is escaped to &lt;T&gt;
   assert_contains!(bar_ts_html, "&lt;T&gt;");
   // Check that line anchors are correctly referenced by line number links
-  assert_contains!(bar_ts_html, "<a name='L1'></a>");
-  assert_contains!(bar_ts_html, "<a href='#L1'>1</a>");
+  assert_contains!(bar_ts_html, "<a href='#L1' id='L1'>1</a>");
 
   let baz_index_html = tempdir
     .join("html")

filename: tests/specs/coverage/default_reports/html_index_html.out
patch: @@ -1,2 +1,2 @@
 <!doctype html>
-      <html>[WILDCARD]</html>
+      <html lang='en-US'>[WILDCARD]</html>
Repository: facebook/react
Pull request: Add ReactDOMClient to ServerIntegrationBasic

## Overview

Branched off https://github.com/facebook/react/pull/28130

In `hydrateRoot`, we now error if you pass `undefined`:

```
Warning: Must provide initial children as second argument to hydrateRoot. 
```

So we expect 1 error for this now.

Changed files:
filename: packages/react-dom/src/__tests__/ReactDOMServerIntegrationBasic-test.js
patch: @@ -15,21 +15,21 @@ const ReactDOMServerIntegrationUtils = require('./utils/ReactDOMServerIntegratio
 const TEXT_NODE_TYPE = 3;
 
 let React;
-let ReactDOM;
+let ReactDOMClient;
 let ReactDOMServer;
 let ReactTestUtils;
 
 function initModules() {
   // Reset warning cache.
   jest.resetModules();
   React = require('react');
-  ReactDOM = require('react-dom');
+  ReactDOMClient = require('react-dom/client');
   ReactDOMServer = require('react-dom/server');
   ReactTestUtils = require('react-dom/test-utils');
 
   // Make them available to the helpers.
   return {
-    ReactDOM,
+    ReactDOMClient,
     ReactDOMServer,
     ReactTestUtils,
   };
@@ -149,8 +149,10 @@ describe('ReactDOMServerIntegration', () => {
       expect(await render([])).toBe(null);
       expect(await render(false)).toBe(null);
       expect(await render(true)).toBe(null);
-      expect(await render(undefined)).toBe(null);
       expect(await render([[[false]], undefined])).toBe(null);
+
+      // hydrateRoot errors for undefined children.
+      expect(await render(undefined, 1)).toBe(null);
     });
   });
 });
Repository: huggingface/transformers
Pull request: Update `QAPipelineTests::test_large_model_course` after #39193

# What does this PR do?

Update `QAPipelineTests::test_large_model_course` after #39193

Changed files:
filename: tests/pipelines/test_pipelines_question_answering.py
patch: @@ -412,7 +412,7 @@ def test_large_model_course(self):
 
         self.assertEqual(
             nested_simplify(outputs),
-            {"answer": "Jax, PyTorch and TensorFlow", "end": 1919, "score": 0.971, "start": 1892},
+            {"answer": "Jax, PyTorch and TensorFlow", "end": 1919, "score": 0.972, "start": 1892},
         )
Repository: ggml-org/llama.cpp
Pull request: clang-tidy : disable warning about performance enum size

Disable 'performance-enum-size' checking:

Enum 'llama_token_type' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size.

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*


Changed files:
filename: .clang-tidy
patch: @@ -17,6 +17,7 @@ Checks: >
     clang-analyzer-*,
     -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
     performance-*,
+    -performance-enum-size,
     portability-*,
     -portability-simd-intrinsics,
     misc-*,
Repository: denoland/deno
Pull request: fix(ext/node): use primordials in `ext/node/polyfills/_fs/_fs_truncate.ts`

Towards #24236. Replaces `Error`, `instanceof`, and `Promise.then()` with the equivalent primordials.

Changed files:
filename: ext/node/polyfills/_fs/_fs_truncate.ts
patch: @@ -1,18 +1,23 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 
-// TODO(petamoriken): enable prefer-primordials for node polyfills
-// deno-lint-ignore-file prefer-primordials
+import { primordials } from "ext:core/mod.js";
 
 import { CallbackWithError } from "ext:deno_node/_fs/_fs_common.ts";
 import { pathFromURL } from "ext:deno_web/00_infra.js";
 import { promisify } from "ext:deno_node/internal/util.mjs";
 
+const {
+  Error,
+  ObjectPrototypeIsPrototypeOf,
+  PromisePrototypeThen,
+} = primordials;
+
 export function truncate(
   path: string | URL,
   lenOrCallback: number | CallbackWithError,
   maybeCallback?: CallbackWithError,
 ) {
-  path = path instanceof URL ? pathFromURL(path) : path;
+  path = ObjectPrototypeIsPrototypeOf(URL, path) ? pathFromURL(path) : path;
   const len: number | undefined = typeof lenOrCallback === "number"
     ? lenOrCallback
     : undefined;
@@ -22,7 +27,11 @@ export function truncate(
 
   if (!callback) throw new Error("No callback function supplied");
 
-  Deno.truncate(path, len).then(() => callback(null), callback);
+  PromisePrototypeThen(
+    Deno.truncate(path, len),
+    () => callback(null),
+    callback,
+  );
 }
 
 export const truncatePromise = promisify(truncate) as (
@@ -31,7 +40,7 @@ export const truncatePromise = promisify(truncate) as (
 ) => Promise<void>;
 
 export function truncateSync(path: string | URL, len?: number) {
-  path = path instanceof URL ? pathFromURL(path) : path;
+  path = ObjectPrototypeIsPrototypeOf(URL, path) ? pathFromURL(path) : path;
 
   Deno.truncateSync(path, len);
 }
Repository: ggml-org/llama.cpp
Pull request: feat: Add conversion support in GraniteHybrid for non-hybrid (all attn)

This is a configuration of the hparams in the GraniteHybrid architecture that devolves to the Granite (or GraniteMoe) architecture (ie Granite 3.x). It may be used for some models in the Granite 4 family with the GraniteHybrid architecture acting as a superset arch. Rather than support it directly in the c++ graph, we simply coerce the architecture flag back to the correct "granite" or "granitemoe" architecture.


Changed files:
filename: convert_hf_to_gguf.py
patch: @@ -7656,6 +7656,21 @@ def __init__(self, *args, **kwargs):
             if i not in self._attn_layers
         ]
 
+        # There are some models in this family that are non-hybrid, but keep the
+        # same parent class by setting all layers to "attention." If this is the
+        # case, the model architecture needs to be updated to a standard
+        # "granite" or "granitemoe" model
+        if not self._ssm_layers:
+            has_experts = self.find_hparam(["num_experts_per_tok"], optional=True)
+            new_arch = (
+                gguf.MODEL_ARCH.GRANITE_MOE
+                if has_experts else
+                gguf.MODEL_ARCH.GRANITE
+            )
+            self.model_arch = new_arch
+            self.gguf_writer.arch = gguf.MODEL_ARCH_NAMES[new_arch]
+            self.gguf_writer.add_architecture()
+
         # n_group and d_inner are used during reshape_tensors for mamba2
         # NOTE: Explicitly include hparam prefix prefix for d_model to
         #   disambiguate with top-level head_dim
@@ -7740,8 +7755,11 @@ def set_gguf_parameters(self):
             self.gguf_writer.add_rope_dimension_count(rope_dim)
         self.gguf_writer.add_head_count_kv(head_count_kv_vec)
 
-        ## If Bamba, use rope, otherwise don't
-        use_rope = "BambaForCausalLM" in self.hparams["architectures"]
+        ## If Bamba or non-hybrid, use rope, otherwise don't
+        use_rope = (
+            "BambaForCausalLM" in self.hparams["architectures"]
+            or not self._ssm_layers
+        )
         self.gguf_writer.add_rope_scaling_finetuned(use_rope)
         if not use_rope:
             self.gguf_writer.add_context_length(2**20)
Repository: huggingface/transformers
Pull request: [`CI`] Add Eric to comment slow ci

As per title cc @ebezzam @eustlb 

Changed files:
filename: .github/workflows/self-comment-ci.yml
patch: @@ -29,7 +29,7 @@ jobs:
     runs-on: ubuntu-22.04
     name: Get PR number
     # For security: only allow team members to run
-    if: ${{ github.event.issue.state == 'open' && contains(fromJSON('["ydshieh", "ArthurZucker", "zucchini-nlp", "qubvel", "molbap", "gante", "LysandreJik", "Cyrilvallez", "Rocketknight1", "SunMarc", "muellerzr", "eustlb", "MekkCyber", "manueldeprada", "vasqu", "ivarflakstad", "stevhliu"]'), github.actor) && (startsWith(github.event.comment.body, 'run-slow') || startsWith(github.event.comment.body, 'run slow') || startsWith(github.event.comment.body, 'run_slow')) }}
+    if: ${{ github.event.issue.state == 'open' && contains(fromJSON('["ydshieh", "ArthurZucker", "zucchini-nlp", "qubvel", "molbap", "gante", "LysandreJik", "Cyrilvallez", "Rocketknight1", "SunMarc", "muellerzr", "eustlb", "MekkCyber", "manueldeprada", "vasqu", "ivarflakstad", "stevhliu", "ebezzam"]'), github.actor) && (startsWith(github.event.comment.body, 'run-slow') || startsWith(github.event.comment.body, 'run slow') || startsWith(github.event.comment.body, 'run_slow')) }}
     outputs:
       PR_NUMBER: ${{ steps.set_pr_number.outputs.PR_NUMBER }}
     steps:
Repository: denoland/deno
Pull request: fix: don't unwrap in global interceptor

Handle other contexts gracefully instead of panicking.

Fixes: https://github.com/denoland/deno/issues/29482

Changed files:
filename: ext/node/global.rs
patch: @@ -280,7 +280,9 @@ pub fn getter<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return v8::Intercepted::No;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
@@ -313,7 +315,9 @@ pub fn setter<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return v8::Intercepted::No;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
@@ -340,7 +344,9 @@ pub fn query<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return v8::Intercepted::No;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
@@ -372,7 +378,9 @@ pub fn deleter<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return v8::Intercepted::No;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
@@ -401,7 +409,9 @@ pub fn enumerator<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
@@ -435,7 +445,9 @@ pub fn definer<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return v8::Intercepted::No;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
@@ -469,7 +481,9 @@ pub fn descriptor<'s>(
 
   let context = scope.get_current_context();
   let inner = {
-    let storage = context.get_slot::<GlobalsStorage>().unwrap();
+    let Some(storage) = context.get_slot::<GlobalsStorage>() else {
+      return v8::Intercepted::No;
+    };
     storage.inner_for_mode(mode)
   };
   let inner = v8::Local::new(scope, inner);
Repository: nodejs/node
Pull request: lib: remove no-mixed-operators eslint rule

The rule often makes code less readable by requiring the additional brackets. I am also not aware that this rule ever caught a real issue in our code.

I have definitely stumbled upon it multiple times and I had to adjust my code to add the brackets due to not thinking about that initially.

If we want to have this rule, I would suggest to check for tenaries with other operators such as `['?:', '||']`, `['?:', '&&']`.

Refs: https://eslint.org/docs/latest/rules/no-mixed-operators

Changed files:
filename: lib/eslint.config_partial.mjs
patch: @@ -370,16 +370,6 @@ export default [
         },
       ],
 
-      // Stylistic rules.
-      '@stylistic/js/no-mixed-operators': [
-        'error',
-        {
-          groups: [
-            ['&&', '||'],
-          ],
-        },
-      ],
-
       // Custom rules in tools/eslint-rules.
       'node-core/alphabetize-errors': 'error',
       'node-core/alphabetize-primordials': 'error',
Repository: electron/electron
Pull request: fix: don't crash Utility Processes on unhandled rejections

#### Description of Change

Change default behavior of utility processes crashed on unhandled rejections. This happened by default because it's how Node.js behaves, but it something we already disabled in the main process and renderer processes because it's not how the web behaves. 

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed an issue where utility processes crashed on unhandled rejections.


Changed files:
filename: docs/breaking-changes.md
patch: @@ -14,6 +14,19 @@ This document uses the following convention to categorize breaking changes:
 
 ## Planned Breaking API Changes (36.0)
 
+### Utility Process unhandled rejection behavior change
+
+Utility Processes will now warn with an error message when an unhandled
+rejection occurs instead of crashing the process.
+
+To restore the previous behavior, you can use:
+
+```js
+process.on('uncaughtException', () => {
+  process.exit(1)
+})
+```
+
 ### Removed:`isDefault` and `status` properties on `PrinterInfo`
 
 These properties have been removed from the PrinterInfo Object

filename: shell/services/node/node_service.cc
patch: @@ -155,6 +155,9 @@ void NodeService::Initialize(
 
   node_env_->set_trace_sync_io(node_env_->options()->trace_sync_io);
 
+  // We do not want to crash the utility process on unhandled rejections.
+  node_env_->options()->unhandled_rejections = "warn-with-error-code";
+
   // Add Electron extended APIs.
   electron_bindings_->BindTo(node_env_->isolate(), node_env_->process_object());
Repository: nodejs/node
Pull request: child_process: give names to `ChildProcess` functions


Changed files:
filename: lib/internal/child_process.js
patch: @@ -352,7 +352,7 @@ function closePendingHandle(target) {
 }
 
 
-ChildProcess.prototype.spawn = function(options) {
+ChildProcess.prototype.spawn = function spawn(options) {
   let i = 0;
 
   validateObject(options, 'options');
@@ -490,7 +490,7 @@ function onSpawnNT(self) {
 }
 
 
-ChildProcess.prototype.kill = function(sig) {
+ChildProcess.prototype.kill = function kill(sig) {
 
   const signal = sig === 0 ? sig :
     convertToValidSignal(sig === undefined ? 'SIGTERM' : sig);
@@ -524,12 +524,12 @@ ChildProcess.prototype[SymbolDispose] = function() {
 };
 
 
-ChildProcess.prototype.ref = function() {
+ChildProcess.prototype.ref = function ref() {
   if (this._handle) this._handle.ref();
 };
 
 
-ChildProcess.prototype.unref = function() {
+ChildProcess.prototype.unref = function unref() {
   if (this._handle) this._handle.unref();
 };
Repository: ggml-org/llama.cpp
Pull request: common : remove unused local variables

These two local variables 'arg' and 'arg_prefix' have been overriden by:

  1. for (const auto & arg : opt.args)

  2. for (int i = 1; i < argc; i++) { 
        const std::string arg_prefix = "--";

        std::string arg = argv[i];

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*


Changed files:
filename: common/arg.cpp
patch: @@ -1068,8 +1068,6 @@ static std::string get_all_kv_cache_types() {
 //
 
 static bool common_params_parse_ex(int argc, char ** argv, common_params_context & ctx_arg) {
-    std::string arg;
-    const std::string arg_prefix = "--";
     common_params & params = ctx_arg.params;
 
     std::unordered_map<std::string, common_arg *> arg_to_options;
Repository: facebook/react
Pull request: fix(eslint-plugin-react-hooks): accepting `as` expression as a callback

## Summary

Closes #20750

## How did you test this change?

Added a test case


Changed files:
filename: packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js
patch: @@ -7765,6 +7765,15 @@ const testsTypescript = {
         }
       `,
     },
+    {
+      code: normalizeIndent`
+        function App(props) {
+          React.useEffect((() => {
+            console.log(props.test);
+          }) as any, [props.test]);
+        }
+      `,
+    },
   ],
   invalid: [
     {

filename: packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
patch: @@ -1223,6 +1223,15 @@ export default {
             isEffect,
           );
           return; // Handled
+        case 'TSAsExpression':
+          visitFunctionWithDependencies(
+            callback.expression,
+            declaredDependenciesNode,
+            reactiveHook,
+            reactiveHookName,
+            isEffect,
+          );
+          return; // Handled
         case 'Identifier':
           if (!declaredDependenciesNode) {
             // No deps, no problems.
Repository: vercel/next.js
Pull request: Add VSCode tasks to show TypeScript compilation errors in problems view

Showing compilation errors for files that aren't currently open is very useful during refactorings.

https://github.com/user-attachments/assets/629f8f2a-37ba-44c1-be6d-9a2e0f93e4f1



Changed files:
filename: .vscode/tasks.json
patch: @@ -0,0 +1,31 @@
+{
+  "version": "2.0.0",
+  "tasks": [
+    {
+      "label": "types",
+      "command": "pnpm",
+      "args": ["typescript", "--watch"],
+      "isBackground": true,
+      "group": {
+        "kind": "build"
+      },
+      "problemMatcher": ["$tsc-watch"]
+    },
+    {
+      "label": "types-next",
+      "command": "pnpm",
+      "args": ["types", "--watch"],
+      "options": {
+        "cwd": "${workspaceFolder}/packages/next"
+      },
+      "isBackground": true,
+      "group": {
+        "kind": "build"
+      },
+      "problemMatcher": {
+        "base": "$tsc-watch",
+        "fileLocation": ["relative", "${workspaceFolder}/packages/next"]
+      }
+    }
+  ]
+}
Repository: ggml-org/llama.cpp
Pull request: Fixed typos in embedding example README


Changed files:
filename: examples/embedding/README.md
patch: @@ -43,8 +43,8 @@ The above command will output space-separated float values.
 | $"string"$   | |
 |--------------|-|
 | "\n"         | (default)
-| "<#embSep#>" | for exemple
-| "<#sep#>"    | other exemple
+| "<#embSep#>" | for example
+| "<#sep#>"    | other example
 
 ## examples
 ### Unix-based systems (Linux, macOS, etc.):
Repository: electron/electron
Pull request: fix: don't crash Web Workers on unhandled rejections

Backport of #45992

See that PR for details.


Notes: Fixed an issue where Web Workers crashed on unhandled rejections.


Changed files:
filename: shell/renderer/web_worker_observer.cc
patch: @@ -86,6 +86,9 @@ void WebWorkerObserver::WorkerScriptReadyForEvaluation(
     }
   }
 
+  // We do not want to crash Web Workers on unhandled rejections.
+  env->options()->unhandled_rejections = "warn-with-error-code";
+
   // Add Electron extended APIs.
   electron_bindings_->BindTo(env->isolate(), env->process_object());