helloadhavan/github_issues huggingface dataset:
Repository: denoland/deno
Pull request: fix(ext/node): return `undefined` instead of `null` in sqlite

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->


Changed files:
filename: ext/node/ops/sqlite/database.rs
patch: @@ -238,6 +238,7 @@ impl DatabaseSync {
   // via the constructor. An exception is thrown if the database is
   // already opened.
   #[fast]
+  #[undefined]
   fn open(&self, state: &mut OpState) -> Result<(), SqliteError> {
     if self.conn.borrow().is_some() {
       return Err(SqliteError::AlreadyOpen);
@@ -262,6 +263,7 @@ impl DatabaseSync {
   // Closes the database connection. An exception is thrown if the
   // database is not open.
   #[fast]
+  #[undefined]
   fn close(&self) -> Result<(), SqliteError> {
     if self.conn.borrow().is_none() {
       return Err(SqliteError::AlreadyClosed);

filename: ext/node/ops/sqlite/session.rs
patch: @@ -64,6 +64,7 @@ impl Session {
 impl Session {
   // Closes the session.
   #[fast]
+  #[undefined]
   fn close(&self) -> Result<(), SqliteError> {
     let db_rc = self.db.upgrade().ok_or_else(|| {
       SqliteError::create_enhanced_error::<()>(

filename: ext/node/ops/sqlite/statement.rs
patch: @@ -703,11 +703,13 @@ impl StatementSync {
   }
 
   #[fast]
+  #[undefined]
   fn set_allow_bare_named_parameters(&self, enabled: bool) {
     self.allow_bare_named_params.set(enabled);
   }
 
   #[fast]
+  #[undefined]
   fn set_read_big_ints(&self, enabled: bool) {
     self.use_big_ints.set(enabled);
   }
Repository: denoland/deno
Pull request: fix(ext/node): make DatabaseSync `readOnly` optional

Extracted from https://github.com/denoland/deno/pull/29404

Changed files:
filename: ext/node/ops/sqlite/database.rs
patch: @@ -36,6 +36,7 @@ struct DatabaseSyncOptions {
   open: bool,
   #[serde(default = "true_fn")]
   enable_foreign_key_constraints: bool,
+  #[serde(default = "false_fn")]
   read_only: bool,
   #[serde(default = "false_fn")]
   allow_extension: bool,
Repository: nodejs/node
Pull request: build: sync libuv header change

removed in https://github.com/libuv/libuv/pull/3688

Changed files:
filename: deps/uv/uv.gyp
patch: @@ -101,7 +101,6 @@
       'include/uv/bsd.h',
       'include/uv/aix.h',
       'src/unix/async.c',
-      'src/unix/atomic-ops.h',
       'src/unix/core.c',
       'src/unix/dl.c',
       'src/unix/fs.c',
@@ -115,7 +114,6 @@
       'src/unix/process.c',
       'src/unix/random-devurandom.c',
       'src/unix/signal.c',
-      'src/unix/spinlock.h',
       'src/unix/stream.c',
       'src/unix/tcp.c',
       'src/unix/thread.c',
Repository: ggml-org/llama.cpp
Pull request: model-conversion : make causal-verify-logits fails with model names containing "."

`make causal-verify-logits` fails if model names containing "." like `Qwen2.5-0.5B-Instruct`.
```bash
export MODEL_PATH=~/share/Qwen2.5-0.5B-Instruct
make causal-verify-logits
```

The following is the error msg.
```
Logits saved to data/llamacpp-Qwen2.5-0.5B-Instruct.bin
Logits saved to data/llamacpp-Qwen2.5-0.5B-Instruct.txt
ggml_metal_free: deallocating
Error: PyTorch logits file not found: data/pytorch-Qwen2.5-0.bin
Please run scripts/run-org-model.sh first to generate this file.
make: *** [causal-verify-logits] Error 1
```

It should be `data/pytorch-Qwen2.5-0.5B-Instruct.bin` instead of `data/pytorch-Qwen2.5-0.bin`.

I suggest just using `os.path.basename(model_path)` to fix it assuming that the `model_path` should be a dir path.

Changed files:
filename: examples/model-conversion/scripts/causal/compare-logits.py
patch: @@ -48,7 +48,7 @@ def main():
         print(f"Error: Model file not found: {model_path}")
         sys.exit(1)
 
-    model_name = os.path.splitext(os.path.basename(model_path))[0]
+    model_name = os.path.basename(model_path)
     data_dir = Path("data")
 
     pytorch_file = data_dir / f"pytorch-{model_name}.bin"

filename: examples/model-conversion/scripts/utils/check-nmse.py
patch: @@ -67,7 +67,7 @@ def main():
     parser.add_argument('-m', '--model-path', required=True,  help='Path to the model directory')
     args = parser.parse_args()
 
-    model_name = os.path.splitext(os.path.basename(args.model_path))[0]
+    model_name = os.path.basename(args.model_path)
     data_dir = Path("data")
 
     pytorch_file = data_dir / f"pytorch-{model_name}.bin"
Repository: electron/electron
Pull request: fix: warning in file picker UI

#### Description of Change

Remove the code in `shell/browser/file_system_access/file_system_access_permission_context.cc` that loads `IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_SAVE_FILE_TITLE` for the title string in `kSaveFilePickerOptions` dialogs. The upstream default of that string is "Warning: this site can see edits you make", which doesn't make sense for Electron?

Removing the string there returns to the pre-30.0.0 behavior, which on my Linux test machine, is the string "All Files".

Fixes #46052.

#### Checklist

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed incorrect titlebar in file save dialogs.

Changed files:
filename: shell/browser/file_system_access/file_system_access_permission_context.cc
patch: @@ -825,13 +825,7 @@ std::u16string FileSystemAccessPermissionContext::GetPickerTitle(
               ? IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_WRITABLE_DIRECTORY_TITLE
               : IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_READABLE_DIRECTORY_TITLE);
       break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kSaveFilePickerOptions:
-      title = l10n_util::GetStringUTF16(
-          IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_SAVE_FILE_TITLE);
-      break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kOpenFilePickerOptions:
+    default:
       break;
   }
   return title;
Repository: nodejs/node
Pull request: http2: remove no longer userful options.selectPadding

This is a followup cleanup on a previous PR. Current source code and doc
explicitly states that `selectPadding` has been removed for all exports.

Refs: https://github.com/nodejs/node/pull/29144
Refs: https://nodejs.org/api/http2.html

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: lib/internal/http2/core.js
patch: @@ -247,7 +247,6 @@ const kPendingRequestCalls = Symbol('kPendingRequestCalls');
 const kProceed = Symbol('proceed');
 const kRemoteSettings = Symbol('remote-settings');
 const kRequestAsyncResource = Symbol('requestAsyncResource');
-const kSelectPadding = Symbol('select-padding');
 const kSentHeaders = Symbol('sent-headers');
 const kSentTrailers = Symbol('sent-trailers');
 const kServer = Symbol('server');
@@ -1100,8 +1099,6 @@ function setupHandle(socket, type, options) {
   const handle = new binding.Http2Session(type);
   handle[kOwner] = this;
 
-  if (typeof options.selectPadding === 'function')
-    this[kSelectPadding] = options.selectPadding;
   handle.consume(socket._handle);
   handle.ongracefulclosecomplete = this[kMaybeDestroy].bind(this, null);
Repository: denoland/deno
Pull request: fix(ext/node): add back perf_hooks.markResourceTiming

Adding back a sham for "perf_hooks.markResourceTiming" that was removed
by accident in https://github.com/denoland/deno/pull/29323; a test was added
too, to ensure it doesn't regress in the future.

Closes https://github.com/denoland/deno/issues/29539

Changed files:
filename: ext/node/polyfills/perf_hooks.js
patch: @@ -31,7 +31,7 @@ performance.nodeTiming = {};
 performance.timerify = () => notImplemented("timerify from performance");
 
 // TODO(bartlomieju):
-performance.timerify = () => {};
+performance.markResourceTiming = () => {};
 
 function monitorEventLoopDelay(options = {}) {
   const { resolution = 10 } = options;

filename: tests/unit_node/perf_hooks_test.ts
patch: @@ -86,3 +86,7 @@ Deno.test("[perf_hooks]: monitorEventLoopDelay", async () => {
 
   e.disable();
 });
+
+Deno.test("[perf_hooks]: markResourceTiming", () => {
+  assert(typeof performance.markResourceTiming === "function");
+});
Repository: electron/electron
Pull request: fix: warning in file picker UI

Backport of #46067

See that PR for details.


Notes: Fixed incorrect titlebar in file save dialogs.

Changed files:
filename: shell/browser/file_system_access/file_system_access_permission_context.cc
patch: @@ -797,13 +797,7 @@ std::u16string FileSystemAccessPermissionContext::GetPickerTitle(
               ? IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_WRITABLE_DIRECTORY_TITLE
               : IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_READABLE_DIRECTORY_TITLE);
       break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kSaveFilePickerOptions:
-      title = l10n_util::GetStringUTF16(
-          IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_SAVE_FILE_TITLE);
-      break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kOpenFilePickerOptions:
+    default:
       break;
   }
   return title;
Repository: facebook/react
Pull request: Convert InvalidEventListeners to createRoot


Changed files:
filename: packages/react-dom/src/__tests__/InvalidEventListeners-test.js
patch: @@ -13,13 +13,15 @@ jest.mock('react-dom-bindings/src/events/isEventSupported');
 
 describe('InvalidEventListeners', () => {
   let React;
-  let ReactDOM;
+  let ReactDOMClient;
+  let act;
   let container;
 
   beforeEach(() => {
     jest.resetModules();
     React = require('react');
-    ReactDOM = require('react-dom');
+    ReactDOMClient = require('react-dom/client');
+    act = require('internal-test-utils').act;
 
     container = document.createElement('div');
     document.body.appendChild(container);
@@ -30,13 +32,16 @@ describe('InvalidEventListeners', () => {
     container = null;
   });
 
-  it('should prevent non-function listeners, at dispatch', () => {
-    let node;
-    expect(() => {
-      node = ReactDOM.render(<div onClick="not a function" />, container);
+  it('should prevent non-function listeners, at dispatch', async () => {
+    const root = ReactDOMClient.createRoot(container);
+    await expect(async () => {
+      await act(() => {
+        root.render(<div onClick="not a function" />);
+      });
     }).toErrorDev(
       'Expected `onClick` listener to be a function, instead got a value of `string` type.',
     );
+    const node = container.firstChild;
 
     spyOnProd(console, 'error');
 
@@ -46,11 +51,13 @@ describe('InvalidEventListeners', () => {
     }
     window.addEventListener('error', handleWindowError);
     try {
-      node.dispatchEvent(
-        new MouseEvent('click', {
-          bubbles: true,
-        }),
-      );
+      await act(() => {
+        node.dispatchEvent(
+          new MouseEvent('click', {
+            bubbles: true,
+          }),
+        );
+      });
     } finally {
       window.removeEventListener('error', handleWindowError);
     }
@@ -77,12 +84,19 @@ describe('InvalidEventListeners', () => {
     }
   });
 
-  it('should not prevent null listeners, at dispatch', () => {
-    const node = ReactDOM.render(<div onClick={null} />, container);
-    node.dispatchEvent(
-      new MouseEvent('click', {
-        bubbles: true,
-      }),
-    );
+  it('should not prevent null listeners, at dispatch', async () => {
+    const root = ReactDOMClient.createRoot(container);
+    await act(() => {
+      root.render(<div onClick={null} />);
+    });
+
+    const node = container.firstChild;
+    await act(() => {
+      node.dispatchEvent(
+        new MouseEvent('click', {
+          bubbles: true,
+        }),
+      );
+    });
   });
 });
Repository: denoland/deno
Pull request: fix(ext/node): use primordials in `ext/node/polyfills/_fs/_fs_symlink.ts`

Towards #24236 


Replaces `instanceof`, `Error`, and `Promise.then()` with their primordial equivalents.

Changed files:
filename: ext/node/polyfills/_fs/_fs_symlink.ts
patch: @@ -1,12 +1,17 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 
-// TODO(petamoriken): enable prefer-primordials for node polyfills
-// deno-lint-ignore-file prefer-primordials
+import { primordials } from "ext:core/mod.js";
 
 import { CallbackWithError } from "ext:deno_node/_fs/_fs_common.ts";
 import { pathFromURL } from "ext:deno_web/00_infra.js";
 import { promisify } from "ext:deno_node/internal/util.mjs";
 
+const {
+  Error,
+  ObjectPrototypeIsPrototypeOf,
+  PromisePrototypeThen,
+} = primordials;
+
 type SymlinkType = "file" | "dir" | "junction";
 
 export function symlink(
@@ -15,8 +20,10 @@ export function symlink(
   typeOrCallback: SymlinkType | CallbackWithError,
   maybeCallback?: CallbackWithError,
 ) {
-  target = target instanceof URL ? pathFromURL(target) : target;
-  path = path instanceof URL ? pathFromURL(path) : path;
+  target = ObjectPrototypeIsPrototypeOf(URL, target)
+    ? pathFromURL(target)
+    : target;
+  path = ObjectPrototypeIsPrototypeOf(URL, path) ? pathFromURL(path) : path;
 
   const type: SymlinkType = typeof typeOrCallback === "string"
     ? typeOrCallback
@@ -28,7 +35,11 @@ export function symlink(
 
   if (!callback) throw new Error("No callback function supplied");
 
-  Deno.symlink(target, path, { type }).then(() => callback(null), callback);
+  PromisePrototypeThen(
+    Deno.symlink(target, path, { type }),
+    () => callback(null),
+    callback,
+  );
 }
 
 export const symlinkPromise = promisify(symlink) as (
@@ -42,8 +53,10 @@ export function symlinkSync(
   path: string | URL,
   type?: SymlinkType,
 ) {
-  target = target instanceof URL ? pathFromURL(target) : target;
-  path = path instanceof URL ? pathFromURL(path) : path;
+  target = ObjectPrototypeIsPrototypeOf(URL, target)
+    ? pathFromURL(target)
+    : target;
+  path = ObjectPrototypeIsPrototypeOf(URL, path) ? pathFromURL(path) : path;
   type = type || "file";
 
   Deno.symlinkSync(target, path, { type });
Repository: ggml-org/llama.cpp
Pull request: common: fix missing chrono header for common.cpp

Greetings!

The llama.cpp project is available through many package managers, including Conan. During the current version update there (PR https://github.com/conan-io/conan-center-index/pull/28435), we found the Windows build [failed](https://c3i.jfrog.io/artifactory/cci-build-logs/cci/prod/PR-28435/5/package_build_logs/build_log_llama-cpp_b4079_a101ce40228ffd7377aa0b3d7979edd9_f6e5ac131a4e0e29fdc594016ca9e30185cddc1e.txt) with the following error:

```
common\common.cpp(432): error C2039: 'system_clock': is not a member of 'std::chrono'
```

Doing a quick read in `common.cpp`, it misses the C++11 header `chrono`. This PR is related to https://github.com/ggml-org/llama.cpp/pull/11836

The CI there is using Windows + MSVC 194 + Release + C++14, in case you want to try to reproduce that scenario. And Llama is built as a shared library in that case. Previously, we did not note this error when building with MSVC 193, it started with the new version of Visual Studio compiler. 

Let me know if you need more information about that case. Regards! 



- [x] *Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*


Changed files:
filename: common/common.cpp
patch: @@ -14,6 +14,7 @@
 #include <climits>
 #include <cmath>
 #include <codecvt>
+#include <chrono>
 #include <cstdarg>
 #include <cstring>
 #include <ctime>
Repository: ggml-org/llama.cpp
Pull request: codeowners : match all requirements files

Partially revert #16210, I was actually going for all requirements files.

Changed files:
filename: CODEOWNERS
patch: @@ -103,4 +103,4 @@
 /LICENSE                                @ggerganov
 /README.md                              @ggerganov
 /SECURITY.md                            @ggerganov
-/requirements*.txt                      @CISC
+requirements*.txt                       @CISC
Repository: electron/electron
Pull request: fix: warning in file picker UI

Backport of #46067

See that PR for details.


Notes: Fixed incorrect titlebar in file save dialogs.

Changed files:
filename: shell/browser/file_system_access/file_system_access_permission_context.cc
patch: @@ -823,13 +823,7 @@ std::u16string FileSystemAccessPermissionContext::GetPickerTitle(
               ? IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_WRITABLE_DIRECTORY_TITLE
               : IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_READABLE_DIRECTORY_TITLE);
       break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kSaveFilePickerOptions:
-      title = l10n_util::GetStringUTF16(
-          IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_SAVE_FILE_TITLE);
-      break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kOpenFilePickerOptions:
+    default:
       break;
   }
   return title;
Repository: ggml-org/llama.cpp
Pull request: ci : upload xcframework artifact from ios-xcode-build job

This commit updates the github workflows build.yml file to include steps for uploading and downloading the xcframework artifact. The macos-latest-swift job now depends on the ios-xcode-build job and downloads the xcframework artifact produced by it.

The motivation for this changes is that it takes a long time to build the xcframework and we are currently doing this twice in the workflow. With this change, we only build it once and reuse the artifact.


Changed files:
filename: .github/workflows/build.yml
patch: @@ -711,6 +711,7 @@ jobs:
 
   macOS-latest-swift:
     runs-on: macos-latest
+    needs: ios-xcode-build
 
     strategy:
       matrix:
@@ -727,6 +728,12 @@ jobs:
           key: macOS-latest-swift
           evict-old-files: 1d
 
+      - name: Download xcframework artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: llama-xcframework
+          path: build-apple/llama.xcframework/
+
       - name: Dependencies
         id: depends
         continue-on-error: true
@@ -748,11 +755,6 @@ jobs:
             -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64"
           cmake --build build --config Release -j $(sysctl -n hw.logicalcpu)
 
-      - name: xcodebuild for swift package
-        id: xcodebuild
-        run: |
-          ./build-xcframework.sh
-
   windows-msys2:
     runs-on: windows-2025
 
@@ -1170,6 +1172,13 @@ jobs:
         run: |
           ./build-xcframework.sh
 
+      - name: Upload xcframework artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: llama-xcframework
+          path: build-apple/llama.xcframework/
+          retention-days: 1
+
       - name: Build Xcode project
         run: |
           xcodebuild -downloadPlatform iOS
Repository: huggingface/transformers
Pull request: add `libcst` to `extras["testing"]` in `setup.py`

# What does this PR do?

So tests like `tests/commands/test_serving.py` and `tests/utils/test_add_new_model_like.py`   in the job `tests_non_model` could run.

This job uses `"huggingface/transformers-torch-light` which has `testing` in the docker file.

(see https://app.circleci.com/pipelines/github/huggingface/transformers/139901/workflows/3cbe7abf-c504-458c-85b8-d7de51ded579/jobs/1853203/tests)



Changed files:
filename: setup.py
patch: @@ -363,6 +363,7 @@ def run(self):
         "pydantic",
         "sentencepiece",
         "sacrebleu",  # needed in trainer tests, see references to `run_translation.py`
+        "libcst",
     )
     + extras["retrieval"]
     + extras["modelcreation"]