Repository: nodejs/node
Pull request: process: make process.execve's args argument optional

Align the code with the documentation and similar methods used to execute os commands - the `args` argument should be optional, and if omitted, treated as an empty array (`[]`).

Fixes: https://github.com/nodejs/node/issues/58411

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: lib/internal/process/per_thread.js
patch: @@ -279,7 +279,7 @@ function wrapProcessMethods(binding) {
     return true;
   }
 
-  function execve(execPath, args, env) {
+  function execve(execPath, args = [], env) {
     emitExperimentalWarning('process.execve');
 
     const { isMainThread } = require('internal/worker');

filename: node.gyp
patch: @@ -1338,6 +1338,13 @@
         }],
       ]
     }, # overlapped-checker
+    {
+      'target_name': 'nop',
+      'type': 'executable',
+      'sources': [
+        'test/nop/nop.c',
+      ]
+    }, # nop
     {
       'target_name': 'node_js2c',
       'type': 'executable',

filename: test/nop/nop.c
patch: @@ -0,0 +1,3 @@
+int main(void) {
+  return 0;
+}

filename: test/parallel/test-process-execve-no-args.js
patch: @@ -0,0 +1,25 @@
+'use strict';
+
+const { skip, isWindows, isIBMi } = require('../common');
+const { fail } = require('assert');
+const { isMainThread } = require('worker_threads');
+const { dirname, join } = require('path');
+const { existsSync } = require('fs');
+
+if (!isMainThread) {
+  skip('process.execve is not available in Workers');
+} else if (isWindows || isIBMi) {
+  skip('process.execve is not available in Windows or IBM i');
+}
+
+// Get full path to the executable used for the test
+const executable = join(dirname(process.execPath), 'nop');
+
+// Sanity check that the binary exists
+if (!existsSync(executable)) {
+  skip(executable + ' binary is not available');
+}
+
+process.execve(executable);
+// If process.execve succeeds, this should never be executed.
+fail('process.execve failed');