Repository: denoland/deno
Pull request: test(ext/node): update some node compat tests to the latest version

Now these tests seem able be updated to the latest without particular changes.

Changed files:
filename: tests/node_compat/config.jsonc
patch: @@ -22,10 +22,8 @@
     ],
     "parallel": [
       "test-arm-math-illegal-instruction.js",
-      "test-assert-fail.js",
       "test-assert.js",
       "test-blocklist.js",
-      "test-buffer-arraybuffer.js",
       "test-buffer-backing-arraybuffer.js",
       "test-buffer-tostring-range.js",
       "test-child-process-exec-abortcontroller-promisified.js",

filename: tests/node_compat/test/parallel/test-assert-fail.js
patch: @@ -2,50 +2,56 @@
 // deno-lint-ignore-file
 
 // Copyright Joyent and Node contributors. All rights reserved. MIT license.
-// Taken from Node 20.11.1
+// Taken from Node 23.9.0
 // This file is automatically generated by `tests/node_compat/runner/setup.ts`. Do not modify this file manually.
 
 'use strict';
 
-const common = require('../common');
+require('../common');
 const assert = require('assert');
+const { test } = require('node:test');
 
-// No args
-assert.throws(
-  () => { assert.fail(); },
-  {
+test('No args', () => {
+  assert.throws(
+    () => { assert.fail(); },
+    {
+      code: 'ERR_ASSERTION',
+      name: 'AssertionError',
+      message: 'Failed',
+      operator: 'fail',
+      actual: undefined,
+      expected: undefined,
+      generatedMessage: true,
+      stack: /Failed/
+    }
+  );
+});
+
+test('One arg = message', () => {
+  assert.throws(() => {
+    assert.fail('custom message');
+  }, {
     code: 'ERR_ASSERTION',
     name: 'AssertionError',
-    message: 'Failed',
+    message: 'custom message',
     operator: 'fail',
     actual: undefined,
     expected: undefined,
-    generatedMessage: true,
-    stack: /Failed/
-  }
-);
-
-// One arg = message
-assert.throws(() => {
-  assert.fail('custom message');
-}, {
-  code: 'ERR_ASSERTION',
-  name: 'AssertionError',
-  message: 'custom message',
-  operator: 'fail',
-  actual: undefined,
-  expected: undefined,
-  generatedMessage: false
+    generatedMessage: false
+  });
 });
 
-// One arg = Error
-assert.throws(() => {
-  assert.fail(new TypeError('custom message'));
-}, {
-  name: 'TypeError',
-  message: 'custom message'
+test('One arg = Error', () => {
+  assert.throws(() => {
+    assert.fail(new TypeError('custom message'));
+  }, {
+    name: 'TypeError',
+    message: 'custom message'
+  });
 });
 
-Object.prototype.get = common.mustNotCall();
-assert.throws(() => assert.fail(''), { code: 'ERR_ASSERTION' });
-delete Object.prototype.get;
+test('Object prototype get', () => {
+  Object.prototype.get = () => { throw new Error('failed'); };
+  assert.throws(() => assert.fail(''), { code: 'ERR_ASSERTION' });
+  delete Object.prototype.get;
+});

filename: tests/node_compat/test/parallel/test-buffer-arraybuffer.js
patch: @@ -2,7 +2,7 @@
 // deno-lint-ignore-file
 
 // Copyright Joyent and Node contributors. All rights reserved. MIT license.
-// Taken from Node 18.12.1
+// Taken from Node 23.9.0
 // This file is automatically generated by `tests/node_compat/runner/setup.ts`. Do not modify this file manually.
 
 'use strict';