Repository: nodejs/node
Pull request: test: deflake test-watch-file-shared-dependency

Delay dependency file modification on macOS.

Refs: https://github.com/nodejs/node/pull/51842

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: test/parallel/test-watch-file-shared-dependency.mjs
patch: @@ -12,8 +12,6 @@ if (common.isIBMi)
 if (common.isAIX)
   common.skip('folder watch capability is limited in AIX.');
 
-tmpdir.refresh();
-
 const { FilesWatcher } = watcher;
 
 tmpdir.refresh();
@@ -32,15 +30,18 @@ Object.entries(fixtureContent)
   .forEach(([file, content]) => writeFileSync(fixturePaths[file], content));
 
 describe('watch file with shared dependency', () => {
-  it('should not remove shared dependencies when unfiltering an owner', () => {
+  it('should not remove shared dependencies when unfiltering an owner', (t, done) => {
     const controller = new AbortController();
-    const watcher = new FilesWatcher({ signal: controller.signal, debounce: 200 });
+    const watcher = new FilesWatcher({ signal: controller.signal });
 
     watcher.on('changed', ({ owners }) => {
-      assert.strictEqual(owners.size, 2);
+      if (owners.size !== 2) return;
+
+      // If this code is never reached the test times out.
       assert.ok(owners.has(fixturePaths['test.js']));
       assert.ok(owners.has(fixturePaths['test-2.js']));
       controller.abort();
+      done();
     });
     watcher.filterFile(fixturePaths['test.js']);
     watcher.filterFile(fixturePaths['test-2.js']);
@@ -49,6 +50,20 @@ describe('watch file with shared dependency', () => {
     watcher.unfilterFilesOwnedBy([fixturePaths['test.js']]);
     watcher.filterFile(fixturePaths['test.js']);
     watcher.filterFile(fixturePaths['dependency.js'], fixturePaths['test.js']);
-    writeFileSync(fixturePaths['dependency.js'], 'module.exports = { modified: true };');
+
+    if (common.isMacOS) {
+      // Do the write with a delay to ensure that the OS is ready to notify us.
+      setTimeout(() => {
+        writeFileSync(
+          fixturePaths['dependency.js'],
+          'module.exports = { modified: true };'
+        );
+      }, common.platformTimeout(200));
+    } else {
+      writeFileSync(
+        fixturePaths['dependency.js'],
+        'module.exports = { modified: true };'
+      );
+    }
   });
 });