helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: [DevTools] Add Snapshots on e2e test failure

We have a currently unreproducible flaky e2e test. This PR captures snapshots on e2e test failures so we can better debug flaky e2e tests that don't fail locally.

Changed files:
filename: .circleci/config.yml
patch: @@ -291,6 +291,8 @@ jobs:
       - run:
           name: Cleanup build regression folder
           command: rm -r ./build-regression
+      - store_artifacts:
+          path: ./tmp/screenshots
 
   yarn_lint_build:
     docker: *docker

filename: packages/react-devtools-inline/__tests__/__e2e__/components.test.js
patch: @@ -210,7 +210,6 @@ test.describe('Components', () => {
     let count = await getComponentSearchResultsCount();
     expect(count).toBe('1 | 4');
 
-    await focusComponentSearch();
     page.keyboard.insertText('Item');
     count = await getComponentSearchResultsCount();
     expect(count).toBe('1 | 3');

filename: packages/react-devtools-inline/playwright.config.js
patch: @@ -18,9 +18,10 @@ const config = {
     react_version: process.env.REACT_VERSION
       ? semver.coerce(process.env.REACT_VERSION).version
       : reactVersion,
+    trace: 'retain-on-failure',
   },
   // Some of our e2e tests can be flaky. Retry tests to make sure the error isn't transient
-  retries: 2,
+  retries: 3,
 };
 
 module.exports = config;

filename: scripts/circleci/run_devtools_e2e_tests.js
patch: @@ -9,6 +9,7 @@ const ROOT_PATH = join(__dirname, '..', '..');
 const reactVersion = process.argv[2];
 const inlinePackagePath = join(ROOT_PATH, 'packages', 'react-devtools-inline');
 const shellPackagePath = join(ROOT_PATH, 'packages', 'react-devtools-shell');
+const screenshotPath = join(ROOT_PATH, 'tmp', 'screenshots');
 
 let buildProcess = null;
 let serverProcess = null;
@@ -115,9 +116,11 @@ function runTestShell() {
 async function runEndToEndTests() {
   logBright('Running e2e tests');
   if (!reactVersion) {
-    testProcess = spawn('yarn', ['test:e2e'], {cwd: inlinePackagePath});
+    testProcess = spawn('yarn', ['test:e2e', `--output=${screenshotPath}`], {
+      cwd: inlinePackagePath,
+    });
   } else {
-    testProcess = spawn('yarn', ['test:e2e'], {
+    testProcess = spawn('yarn', ['test:e2e', `--output=${screenshotPath}`], {
       cwd: inlinePackagePath,
       env: {...process.env, REACT_VERSION: reactVersion},
     });
Repository: electron/electron
Pull request: fix: win.closeFilePreview recreates panel when called twice

Backport of #45319

See that PR for details.


Notes: Fixed file preview window reappearing when calling `win.closeFilePreview` twice on macOS.


Changed files:
filename: shell/browser/native_window_mac.mm
patch: @@ -1596,8 +1596,11 @@ static bool FromV8(v8::Isolate* isolate,
 }
 
 void NativeWindowMac::CloseFilePreview() {
-  if ([QLPreviewPanel sharedPreviewPanelExists]) {
+  // Need to be careful about checking [QLPreviewPanel sharedPreviewPanel] as
+  // simply accessing it will cause it to reinitialize and reappear.
+  if ([QLPreviewPanel sharedPreviewPanelExists] && preview_item_) {
     [[QLPreviewPanel sharedPreviewPanel] close];
+    preview_item_ = nil;
   }
 }
 

filename: spec/api-browser-window-spec.ts
patch: @@ -6255,6 +6255,7 @@ describe('BrowserWindow module', () => {
       w.previewFile(__filename);
       await setTimeout(500);
       expect(showCalled).to.equal(false, 'should not have called show twice');
+      w.closeFilePreview();
     });
   });
Repository: nodejs/node
Pull request: doc: remove link to `QUIC.md`

If we're not including the documentation anytime soon, we should probably remove the link for now.

Fixes: https://github.com/nodejs/node/issues/57252
<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/index.md
patch: @@ -49,7 +49,6 @@
 * [Process](process.md)
 * [Punycode](punycode.md)
 * [Query strings](querystring.md)
-* [QUIC](quic.md)
 * [Readline](readline.md)
 * [REPL](repl.md)
 * [Report](report.md)
Repository: denoland/deno
Pull request: perf(ext/node): improve node:http createServer performance

This PR reduces unnecessary `.end()` call on `ServerResponse` object, and improves the http server performance of `node:http`.

- main: 13.786 kRPS
- this PR: 50.32 kRPS

related https://github.com/denoland/deno/pull/28601

Changed files:
filename: ext/node/polyfills/http.ts
patch: @@ -1499,7 +1499,11 @@ export const ServerResponse = function (
   this._readable = readable;
   this._resolve = resolve;
   this.socket = socket;
-  this.socket?.on("close", () => this.end());
+  this.socket?.on("close", () => {
+    if (!this.finished) {
+      this.end();
+    }
+  });
   this._header = "";
 } as unknown as ServerResponseStatic;
Repository: denoland/deno
Pull request: fix(otel): only start deno_telemetry thread when needed

Closes #29064

Changed files:
filename: cli/main.rs
patch: @@ -51,6 +51,7 @@ use deno_runtime::tokio_util::create_and_run_current_thread_with_maybe_metrics;
 use deno_runtime::WorkerExecutionMode;
 pub use deno_runtime::UNSTABLE_FEATURES;
 use deno_telemetry::OtelConfig;
+use deno_telemetry::OtelConsoleConfig;
 use deno_terminal::colors;
 use factory::CliFactory;
 
@@ -489,10 +490,15 @@ fn resolve_flags_and_init(
 
   let otel_config = flags.otel_config();
   init_logging(flags.log_level, Some(otel_config.clone()));
-  deno_telemetry::init(
-    deno_lib::version::otel_runtime_config(),
-    otel_config.clone(),
-  )?;
+  if otel_config.metrics_enabled
+    || otel_config.tracing_enabled
+    || !matches!(otel_config.console, OtelConsoleConfig::Ignore)
+  {
+    deno_telemetry::init(
+      deno_lib::version::otel_runtime_config(),
+      otel_config.clone(),
+    )?;
+  }
 
   // TODO(bartlomieju): remove in Deno v2.5 and hard error then.
   if flags.unstable_config.legacy_flag_enabled {
Repository: denoland/deno
Pull request: fix: correct reported typescript version

https://github.com/denoland/deno/pull/29041#issuecomment-2831398138

Changed files:
filename: cli/lib/version.rs
patch: @@ -14,7 +14,7 @@ pub fn otel_runtime_config() -> OtelRuntimeConfig {
 }
 
 const GIT_COMMIT_HASH: &str = env!("GIT_COMMIT_HASH");
-const TYPESCRIPT: &str = "5.7.3";
+const TYPESCRIPT: &str = "5.8.3";
 pub const DENO_VERSION: &str = env!("CARGO_PKG_VERSION");
 // TODO(bartlomieju): ideally we could remove this const.
 const IS_CANARY: bool = option_env!("DENO_CANARY").is_some();

filename: cli/snapshot/shared.rs
patch: @@ -1,3 +1,3 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 
-pub static TS_VERSION: &str = "5.7.3";
+pub static TS_VERSION: &str = "5.8.3";

filename: tests/unit/version_test.ts
patch: @@ -6,5 +6,5 @@ Deno.test(function version() {
   const pattern = /^\d+\.\d+\.\d+/;
   assert(pattern.test(Deno.version.deno));
   assert(pattern.test(Deno.version.v8));
-  assertEquals(Deno.version.typescript, "5.7.3");
+  assertEquals(Deno.version.typescript, "5.8.3");
 });
Repository: electron/electron
Pull request: build: run source cache clean daily

Backport of #45652

See that PR for details.


Notes: none

Changed files:
filename: .github/workflows/clean-src-cache.yml
patch: @@ -1,8 +1,12 @@
 name: Clean Source Cache
 
+description: |
+  This workflow cleans up the source cache on the cross-instance cache volume
+  to free up space. It runs daily at midnight and clears files older than 15 days.
+
 on:
   schedule:
-    - cron: "0 0 * * SUN"  # Run at midnight every Sunday
+    - cron: "0 0 * * *"
 
 jobs:
   clean-src-cache:
@@ -17,5 +21,5 @@ jobs:
       shell: bash
       run: |
         df -h /mnt/cross-instance-cache
-        find /mnt/cross-instance-cache -type f -mtime +30 -delete
+        find /mnt/cross-instance-cache -type f -mtime +15 -delete
         df -h /mnt/cross-instance-cache
Repository: ggml-org/llama.cpp
Pull request: vulkan: fix min subgroup 16 condition for mmid subgroup optimization

This fixes a bug in the selection of the subgroup mmid optimization introduced in #15524.

@MrLavender please give it a try, it should be working for you with this fix.

Changed files:
filename: ggml/src/ggml-vulkan/ggml-vulkan.cpp
patch: @@ -2183,7 +2183,7 @@ static void ggml_vk_load_shaders(vk_device& device) {
     const uint32_t mul_mat_subgroup_size_32 = std::max(mul_mat_subgroup_size, 32u);
 
     const bool subgroup_min_size_16 = (!device->subgroup_size_control && device->subgroup_size >= 16) ||
-                                      (device->subgroup_size_control && device->subgroup_min_size <= 16 && device->subgroup_max_size >= 16);
+                                      (device->subgroup_size_control && device->subgroup_max_size >= 16);
 
     // mulmat
     std::vector<uint32_t> l_warptile, m_warptile, s_warptile,
Repository: nodejs/node
Pull request: doc: fix typo in url.md

Fix a typo "objg" should be "obj".

Fixes: https://github.com/nodejs/node/issues/57464

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/url.md
patch: @@ -767,7 +767,7 @@ case-insensitive matching if set to true.
 
 The constructor can throw a `TypeError` to indicate parsing failure.
 
-#### `new URLPattern(objg[, baseURL][, options])`
+#### `new URLPattern(obj[, baseURL][, options])`
 
 * `obj` {Object} An input pattern
 * `baseURL` {string | undefined} A base URL string
Repository: denoland/deno
Pull request: fix(ext/node): fix deepStrictEqual(-0, 0)

closes https://github.com/denoland/deno/issues/28037

Changed files:
filename: ext/node/polyfills/_util/std_asserts.ts
patch: @@ -103,7 +103,7 @@ export function equal(c: unknown, d: unknown): boolean {
       return aTime === bTime;
     }
     if (typeof a === "number" && typeof b === "number") {
-      return NumberIsNaN(a) && NumberIsNaN(b) || a === b;
+      return ObjectIs(a, b);
     }
     if (ObjectIs(a, b)) {
       return true;

filename: tests/unit_node/assert_test.ts
patch: @@ -16,3 +16,11 @@ Deno.test("[node/assert] .throws() compares Error instance", () => {
     TypeError,
   );
 });
+
+Deno.test("[node/assert] deepStrictEqual(0, -0)", () => {
+  assert.throws(
+    () => {
+      assert.deepStrictEqual(0, -0);
+    },
+  );
+});
Repository: vercel/next.js
Pull request: [dynamicIO] Track module loading in dev always

In dev we prerender and render concurrently. The former to validate dynamicIO rules. The latter to stream a response as soon as possible. If we only track module loading during prerenders it is possible to kick off loading a chunk during the render and then not observe that chunk load during prerender, leading to an early abort before all modules have had a chance to load.

To solve this we simply always track module loading in dev.

Changed files:
filename: packages/next/src/server/app-render/app-render.tsx
patch: @@ -1221,6 +1221,9 @@ async function renderToHTMLOrFlightImpl(
       if (!renderOpts.experimental.dynamicIO) {
         return false
       }
+      if (renderOpts.dev) {
+        return true
+      }
       const workUnitStore = workUnitAsyncStorage.getStore()
       return !!(
         workUnitStore &&
Repository: facebook/react
Pull request: Add dynamic `disableModulePatternComponents` flag for native-fb

Makes `disableModulePatternComponents` a flag to allow us a slow rollout for RN internally.

Changed files:
filename: packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
patch: @@ -20,12 +20,13 @@ import typeof * as DynamicFlagsType from 'ReactNativeInternalFeatureFlags';
 // flag here but it won't be set to `true` in any of our test runs. Need to
 // update the test configuration.
 
-export const enableUseRefAccessWarning = __VARIANT__;
+export const alwaysThrottleRetries = __VARIANT__;
+export const disableModulePatternComponents = __VARIANT__;
 export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
 export const enableUnifiedSyncLane = __VARIANT__;
-export const alwaysThrottleRetries = __VARIANT__;
-export const useMicrotasksForSchedulingInFabric = __VARIANT__;
+export const enableUseRefAccessWarning = __VARIANT__;
 export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
+export const useMicrotasksForSchedulingInFabric = __VARIANT__;
 
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): DynamicFlagsType): ExportsType);

filename: packages/shared/forks/ReactFeatureFlags.native-fb.js
patch: @@ -18,12 +18,13 @@ import * as dynamicFlags from 'ReactNativeInternalFeatureFlags';
 // We destructure each value before re-exporting to avoid a dynamic look-up on
 // the exports object every time a flag is read.
 export const {
-  enableUseRefAccessWarning,
+  alwaysThrottleRetries,
+  disableModulePatternComponents,
   enableDeferRootSchedulingToMicrotask,
   enableUnifiedSyncLane,
-  alwaysThrottleRetries,
-  useMicrotasksForSchedulingInFabric,
+  enableUseRefAccessWarning,
   passChildrenWhenCloningPersistedNodes,
+  useMicrotasksForSchedulingInFabric,
 } = dynamicFlags;
 
 // The rest of the flags are static for better dead code elimination.
@@ -55,7 +56,6 @@ export const enableSuspenseCallback = false;
 export const disableLegacyContext = false;
 export const enableTrustedTypesIntegration = false;
 export const disableTextareaChildren = false;
-export const disableModulePatternComponents = false;
 export const enableSuspenseAvoidThisFallback = false;
 export const enableSuspenseAvoidThisFallbackFizz = false;
 export const enableCPUSuspense = true;

filename: scripts/flow/xplat.js
patch: @@ -8,10 +8,11 @@
  */
 
 declare module 'ReactNativeInternalFeatureFlags' {
-  declare export var enableUseRefAccessWarning: boolean;
+  declare export var alwaysThrottleRetries: boolean;
+  declare export var disableModulePatternComponents: boolean;
   declare export var enableDeferRootSchedulingToMicrotask: boolean;
   declare export var enableUnifiedSyncLane: boolean;
-  declare export var alwaysThrottleRetries: boolean;
-  declare export var useMicrotasksForSchedulingInFabric: boolean;
+  declare export var enableUseRefAccessWarning: boolean;
   declare export var passChildrenWhenCloningPersistedNodes: boolean;
+  declare export var useMicrotasksForSchedulingInFabric: boolean;
 }
Repository: electron/electron
Pull request: build: run source cache clean daily

#### Description of Change

Attempt to address persistent source cache space issues:

See https://github.com/electron/electron/pull/45641

> The cross mount cache has 27G free space which is not enough - exiting

#### Release Notes

Notes: none

Changed files:
filename: .github/workflows/clean-src-cache.yml
patch: @@ -1,8 +1,12 @@
 name: Clean Source Cache
 
+description: |
+  This workflow cleans up the source cache on the cross-instance cache volume
+  to free up space. It runs daily at midnight and clears files older than 15 days.
+
 on:
   schedule:
-    - cron: "0 0 * * SUN"  # Run at midnight every Sunday
+    - cron: "0 0 * * *"
 
 jobs:
   clean-src-cache:
@@ -17,5 +21,5 @@ jobs:
       shell: bash
       run: |
         df -h /mnt/cross-instance-cache
-        find /mnt/cross-instance-cache -type f -mtime +30 -delete
+        find /mnt/cross-instance-cache -type f -mtime +15 -delete
         df -h /mnt/cross-instance-cache
Repository: denoland/deno
Pull request: fix(cli): Display error on invalid OTEL_EXPORTER_OTLP_PROTOCOL value

fixes #28646

Edit:

Hi apologies for the delayed explanation @marvinhagemeister.

The reason the error message wasn't appearing was due to the initialization order. The logging system was being initialized after the telemetry system. This created a problem: if telemetry failed during its own initialization, the logging system wasn't yet ready to capture and report the error.

My solution was to simply move the log initialization to occur before the telemetry initialization. This resolves the issue, ensuring any telemetry setup errors are correctly logged.

Changed files:
filename: cli/main.rs
patch: @@ -488,11 +488,11 @@ fn resolve_flags_and_init(
   };
 
   let otel_config = flags.otel_config();
+  init_logging(flags.log_level, Some(otel_config.clone()));
   deno_telemetry::init(
     deno_lib::version::otel_runtime_config(),
     otel_config.clone(),
   )?;
-  init_logging(flags.log_level, Some(otel_config));
 
   // TODO(bartlomieju): remove in Deno v2.5 and hard error then.
   if flags.unstable_config.legacy_flag_enabled {
Repository: nodejs/node
Pull request: build: escape > metachar in vcbuild

Escape the `>` metachar in vcbuild.bat to avoid that a file named as the major node version number is created.

Refs: #57991



Changed files:
filename: vcbuild.bat
patch: @@ -241,7 +241,7 @@ call :getnodeversion || exit /b 1
 set NODE_MAJOR_VERSION=
 for /F "tokens=1 delims=." %%i in ("%NODE_VERSION%") do set "NODE_MAJOR_VERSION=%%i"
 if %NODE_MAJOR_VERSION% GEQ 24 (
-  echo Using ClangCL because the Node.js version being compiled is >= 24.
+  echo Using ClangCL because the Node.js version being compiled is ^>= 24.
   set clang_cl=1
 )
Repository: vercel/next.js
Pull request: fix(CI): Update llvm when building native musl targets

Tested locally with

```
podman run --platform=linux/amd64 -t -i ghcr.io/napi-rs/napi-rs/nodejs-rust:stable-2023-09-17-alpine bash
```

We must ensure llvm16 is removed before installing llvm20 and llvm20-dev, as there's a file conflict between llvm16 and llvm20-dev.

Full build-and-deploy run: [https://github.com/vercel/next.js/actions/runs/16128142342](https://github.com/vercel/next.js/actions/runs/16128189670)

Closes PACK-5022

Changed files:
filename: .github/workflows/build_and_deploy.yml
patch: @@ -247,7 +247,8 @@ jobs:
             build: >-
               set -ex &&
               apk update &&
-              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev clang-static llvm-dev &&
+              apk del llvm &&
+              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev clang-static llvm llvm-dev &&
               rustup show &&
               rustup target add x86_64-unknown-linux-musl &&
               npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" &&
@@ -288,7 +289,8 @@ jobs:
             build: >-
               set -ex &&
               apk update &&
-              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev clang-static llvm-dev &&
+              apk del llvm &&
+              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev clang-static llvm llvm-dev &&
               export JEMALLOC_SYS_WITH_LG_PAGE=16 &&
               npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" &&
               rustup show &&
Repository: denoland/deno
Pull request: fix: better error message for bare run in file-like case

Fixes #28996

Changed files:
filename: cli/args/flags.rs
patch: @@ -1569,7 +1569,7 @@ where
     // causing strings with common prefix >=10 to be considered perfectly similar
     .map(|pv| (strsim::jaro(v, pv.as_ref()), pv.as_ref().to_owned()))
     // Confidence of 0.7 so that bar -> baz is suggested
-    .filter(|(confidence, _)| *confidence > 0.7)
+    .filter(|(confidence, _)| *confidence > 0.8)
     .collect();
   candidates
     .sort_by(|a, b| a.0.partial_cmp(&b.0).unwrap_or(std::cmp::Ordering::Equal));

filename: cli/main.rs
patch: @@ -246,7 +246,7 @@ async fn run_subcommand(flags: Arc<Flags>) -> Result<i32, AnyError> {
                 cmd.build();
                 let command_names = cmd.get_subcommands().map(|command| command.get_name()).collect::<Vec<_>>();
                 let suggestions = args::did_you_mean(&run_flags.script, command_names);
-                if !suggestions.is_empty() {
+                if !suggestions.is_empty() && !run_flags.script.contains('.') {
                   let mut error = clap::error::Error::<clap::error::DefaultFormatter>::new(clap::error::ErrorKind::InvalidSubcommand).with_cmd(&cmd);
                   error.insert(
                     clap::error::ContextKind::SuggestedSubcommand,

filename: tests/specs/run/bare_run_main/__test__.jsonc
patch: @@ -0,0 +1,5 @@
+{
+  "args": "main.ts",
+  "output": "main.out",
+  "exitCode": 1
+}

filename: tests/specs/run/bare_run_main/main.out
patch: @@ -0,0 +1 @@
+error: Module not found "[WILDCARD]/main.ts".