helloadhavan/github_issues huggingface dataset:
Repository: vercel/next.js
Pull request: Update Rspack development test manifest

This auto-generated PR updates the development integration test manifest used when testing Rspack.

Changed files:
filename: test/turbopack-dev-tests-manifest.json
patch: @@ -12043,10 +12043,11 @@
       "react-compiler default should render",
       "react-compiler default should show an experimental warning",
       "react-compiler default should work with a library that uses the react-server condition",
-      "react-compiler default should work with a library using use client",
       "react-compiler default throws if the React Compiler is used in a React Server environment"
     ],
-    "failed": [],
+    "failed": [
+      "react-compiler default should work with a library using use client"
+    ],
     "pending": [],
     "flakey": [],
     "runtimeError": false
Repository: facebook/react
Pull request: Convert multiple-copies-of-react to createRoot


Changed files:
filename: packages/react-dom/src/__tests__/multiple-copies-of-react-test.js
patch: @@ -10,7 +10,8 @@
 'use strict';
 
 let React = require('react');
-const ReactTestUtils = require('react-dom/test-utils');
+const ReactDOMClient = require('react-dom/client');
+const act = require('internal-test-utils').act;
 
 class TextWithStringRef extends React.Component {
   render() {
@@ -21,10 +22,14 @@ class TextWithStringRef extends React.Component {
 }
 
 describe('when different React version is used with string ref', () => {
-  it('throws the "Refs must have owner" warning', () => {
-    expect(() => {
-      ReactTestUtils.renderIntoDocument(<TextWithStringRef />);
-    }).toThrow(
+  it('throws the "Refs must have owner" warning', async () => {
+    const container = document.createElement('div');
+    const root = ReactDOMClient.createRoot(container);
+    await expect(
+      act(() => {
+        root.render(<TextWithStringRef />);
+      }),
+    ).rejects.toThrow(
       'Element ref was specified as a string (foo) but no owner was set. This could happen for one of' +
         ' the following reasons:\n' +
         '1. You may be adding a ref to a function component\n' +
Repository: nodejs/node
Pull request: tools: support `DisposableStack` and `AsyncDisposableStack` in linter


Changed files:
filename: eslint.config.mjs
patch: @@ -120,6 +120,7 @@ export default [
   {
     languageOptions: {
       globals: {
+        AsyncDisposableStack: 'readonly',
         ByteLengthQueuingStrategy: 'readonly',
         CompressionStream: 'readonly',
         CountQueuingStrategy: 'readonly',
@@ -128,6 +129,7 @@ export default [
         Crypto: 'readonly',
         CryptoKey: 'readonly',
         DecompressionStream: 'readonly',
+        DisposableStack: 'readonly',
         EventSource: 'readable',
         fetch: 'readonly',
         Float16Array: 'readonly',

filename: lib/eslint.config_partial.mjs
patch: @@ -356,11 +356,22 @@ export default [
           name: 'SubtleCrypto',
           message: "Use `const { SubtleCrypto } = require('internal/crypto/webcrypto');` instead of the global.",
         },
-        // Float16Array is not available in primordials because it's only available with --js-float16array CLI flag.
+        // Float16Array is not available in primordials because it can be
+        // disabled with --no-js-float16array CLI flag.
         {
           name: 'Float16Array',
           message: 'Use `const { Float16Array } = globalThis;` instead of the global.',
         },
+        // DisposableStack and AsyncDisposableStack are not available in primordials because they can be
+        // disabled with --no-js-explicit-resource-management CLI flag.
+        {
+          name: 'DisposableStack',
+          message: 'Use `const { DisposableStack } = globalThis;` instead of the global.',
+        },
+        {
+          name: 'AsyncDisposableStack',
+          message: 'Use `const { AsyncDisposableStack } = globalThis;` instead of the global.',
+        },
       ],
       'no-restricted-modules': [
         'error',
Repository: denoland/deno
Pull request: fix(node/assert): throw on deepStrictEqual({}, Object.create(null))

# `assert.deepStrictEqual` now differentiates `{}` from `Object.create(null)`

This PR updates the object comparison logic to throw when comparing a plain object `({})` with an object created via `Object.create(null)`, matching Node.js behavior.

Closes #27565 


Changed files:
filename: ext/node/polyfills/_util/std_asserts.ts
patch: @@ -198,9 +198,14 @@ export function equal(c: unknown, d: unknown): boolean {
 }
 
 function constructorsEqual(a: object, b: object) {
-  return a.constructor === b.constructor ||
-    a.constructor === Object && !b.constructor ||
-    !a.constructor && b.constructor === Object;
+  // Treat {} and Object.create(null) as not equal
+  if (
+    (a.constructor === Object && !b.constructor) ||
+    (!a.constructor && b.constructor === Object)
+  ) {
+    return false;
+  }
+  return a.constructor === b.constructor;
 }
 
 /** Make an assertion, error will be thrown if `expr` does not have truthy value. */
Repository: facebook/react
Pull request: Convert ReactDOMIframe to createRoot


Changed files:
filename: packages/react-dom/src/__tests__/ReactDOMIframe-test.js
patch: @@ -11,22 +11,30 @@
 
 describe('ReactDOMIframe', () => {
   let React;
-  let ReactTestUtils;
+  let ReactDOMClient;
+  let act;
 
   beforeEach(() => {
     React = require('react');
-    ReactTestUtils = require('react-dom/test-utils');
+    ReactDOMClient = require('react-dom/client');
+    act = require('internal-test-utils').act;
   });
 
-  it('should trigger load events', () => {
+  it('should trigger load events', async () => {
     const onLoadSpy = jest.fn();
-    let iframe = React.createElement('iframe', {onLoad: onLoadSpy});
-    iframe = ReactTestUtils.renderIntoDocument(iframe);
+    const container = document.createElement('div');
+    const root = ReactDOMClient.createRoot(container);
+    await act(() => {
+      root.render(React.createElement('iframe', {onLoad: onLoadSpy}));
+    });
+    const iframe = container.firstChild;
 
     const loadEvent = document.createEvent('Event');
     loadEvent.initEvent('load', false, false);
 
-    iframe.dispatchEvent(loadEvent);
+    await act(() => {
+      iframe.dispatchEvent(loadEvent);
+    });
 
     expect(onLoadSpy).toHaveBeenCalled();
   });
Repository: ggml-org/llama.cpp
Pull request: codeowners: add ownership of zdnn backend [no ci]

cont #16229 

Missed adding @Andreas-Krebbel to the list of codeowners for the IBM zDNN backend to help with maintenance.

Changed files:
filename: CODEOWNERS
patch: @@ -63,7 +63,7 @@
 /ggml/src/ggml-quants.*                 @ggerganov
 /ggml/src/ggml-threading.*              @ggerganov @slaren
 /ggml/src/ggml-vulkan/                  @0cc4m
-/ggml/src/ggml-zdnn/                    @taronaeo @AlekseiNikiforovIBM
+/ggml/src/ggml-zdnn/                    @taronaeo @Andreas-Krebbel @AlekseiNikiforovIBM
 /ggml/src/ggml.c                        @ggerganov @slaren
 /ggml/src/ggml.cpp                      @ggerganov @slaren
 /ggml/src/gguf.cpp                      @JohannesGaessler @Green-Sky
Repository: huggingface/transformers
Pull request: Fix OmDet test after arg deprecation

# What does this PR do?

As per the title!

Changed files:
filename: tests/models/omdet_turbo/test_modeling_omdet_turbo.py
patch: @@ -844,7 +844,7 @@ def test_inference_object_detection_head_batched(self):
             outputs,
             text_labels=text_labels_batched,
             target_sizes=[image.size[::-1] for image in images_batched],
-            score_threshold=0.2,
+            threshold=0.2,
         )
         expected_scores = torch.tensor([0.7675, 0.3016, 0.7454]).to(torch_device)
         expected_slice_boxes = torch.tensor(
Repository: nodejs/node
Pull request: test: add tests ensuring worker threads cannot access internals


Changed files:
filename: test/parallel/test-worker-internal-modules.mjs
patch: @@ -0,0 +1,36 @@
+import '../common/index.mjs';
+import tmpdir from '../common/tmpdir.js';
+import assert from 'node:assert/strict';
+import { once } from 'node:events';
+import fs from 'node:fs/promises';
+import { describe, test, before } from 'node:test';
+import { Worker } from 'node:worker_threads';
+
+const accessInternalsSource = `
+import 'node:internal/freelist';
+`;
+
+function convertScriptSourceToDataUrl(script) {
+  return new URL(`data:text/javascript,${encodeURIComponent(script)}`);
+}
+
+describe('Worker threads should not be able to access internal modules', () => {
+  before(() => tmpdir.refresh());
+
+  test('worker instantiated with module file path', async () => {
+    const moduleFilepath = tmpdir.resolve('test-worker-internal-modules.mjs');
+    await fs.writeFile(moduleFilepath, accessInternalsSource);
+    const w = new Worker(moduleFilepath);
+    await assert.rejects(once(w, 'exit'), { code: 'ERR_UNKNOWN_BUILTIN_MODULE' });
+  });
+
+  test('worker instantiated with module source', async () => {
+    const w = new Worker(accessInternalsSource, { eval: true });
+    await assert.rejects(once(w, 'exit'), { code: 'ERR_UNKNOWN_BUILTIN_MODULE' });
+  });
+
+  test('worker instantiated with data: URL', async () => {
+    const w = new Worker(convertScriptSourceToDataUrl(accessInternalsSource));
+    await assert.rejects(once(w, 'exit'), { code: 'ERR_UNKNOWN_BUILTIN_MODULE' });
+  });
+});
Repository: vercel/next.js
Pull request: Bump to swc_sourcemap 9.3.3

Pull in https://github.com/swc-project/swc-sourcemap/pull/4 to fix source maps

Closes PACK-5119

Changed files:
filename: Cargo.lock
patch: @@ -8241,9 +8241,9 @@ dependencies = [
 
 [[package]]
 name = "swc_sourcemap"
-version = "9.3.2"
+version = "9.3.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "9755c673c6a83c461e98fa018f681adb8394a3f44f89a06f27e80fd4fe4fa1e4"
+checksum = "3cd6e0cad02163875258edaf9ae6004e2526be137bdde6a46c540515615949b1"
 dependencies = [
  "base64-simd 0.8.0",
  "bitvec",

filename: Cargo.toml
patch: @@ -414,7 +414,7 @@ smallvec = { version = "1.13.1", features = [
   "union",
   "const_new",
 ] }
-swc_sourcemap = "9.3.2"
+swc_sourcemap = "9.3.3"
 strsim = "0.11.1"
 shrink-to-fit = "0.2.10"
 syn = "2.0.100"
Repository: ggml-org/llama.cpp
Pull request: devops: fix s390x docker release failure

I noticed that the s390x Docker build workflows were erroring out due to shared locks with parallel builds. This PR ensures parallel builds wait for each other before using the same cache files.

Also, it fixes the warnings about `FromPlatformFlagConstDisallowed`.

See: https://github.com/ggml-org/llama.cpp/actions/runs/17966160374/job/51152877214#step:8:362

Changed files:
filename: .devops/s390x.Dockerfile
patch: @@ -2,10 +2,10 @@ ARG GCC_VERSION=15.2.0
 ARG UBUNTU_VERSION=24.04
 
 ### Build Llama.cpp stage
-FROM --platform=linux/s390x gcc:${GCC_VERSION} AS build
+FROM gcc:${GCC_VERSION} AS build
 
-RUN --mount=type=cache,target=/var/cache/apt \
-    --mount=type=cache,target=/var/lib/apt/lists \
+RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
+    --mount=type=cache,target=/var/lib/apt/lists,sharing=locked \
     apt update -y && \
     apt upgrade -y && \
     apt install -y --no-install-recommends \
@@ -40,7 +40,7 @@ COPY requirements     /opt/llama.cpp/gguf-py/requirements
 
 
 ### Collect all llama.cpp binaries, libraries and distro libraries
-FROM --platform=linux/s390x scratch AS collector
+FROM scratch AS collector
 
 # Copy llama.cpp binaries and libraries
 COPY --from=build /opt/llama.cpp/bin     /llama.cpp/bin
@@ -49,13 +49,14 @@ COPY --from=build /opt/llama.cpp/gguf-py /llama.cpp/gguf-py
 
 
 ### Base image
-FROM --platform=linux/s390x ubuntu:${UBUNTU_VERSION} AS base
+FROM ubuntu:${UBUNTU_VERSION} AS base
 
-RUN --mount=type=cache,target=/var/cache/apt \
-    --mount=type=cache,target=/var/lib/apt/lists \
+RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
+    --mount=type=cache,target=/var/lib/apt/lists,sharing=locked \
     apt update -y && \
     apt install -y --no-install-recommends \
         # WARNING: Do not use libopenblas-openmp-dev. libopenblas-dev is faster.
+        # See: https://github.com/ggml-org/llama.cpp/pull/15915#issuecomment-3317166506
         curl libgomp1 libopenblas-dev && \
     apt autoremove -y && \
     apt clean -y && \
@@ -68,13 +69,13 @@ COPY --from=collector /llama.cpp/lib /usr/lib/s390x-linux-gnu
 
 
 ### Full
-FROM --platform=linux/s390x base AS full
+FROM base AS full
 
 ENV PATH="/root/.cargo/bin:${PATH}"
 WORKDIR /app
 
-RUN --mount=type=cache,target=/var/cache/apt \
-    --mount=type=cache,target=/var/lib/apt/lists \
+RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
+    --mount=type=cache,target=/var/lib/apt/lists,sharing=locked \
     apt update -y && \
     apt install -y \
         git cmake libjpeg-dev \
@@ -97,7 +98,7 @@ ENTRYPOINT [ "/app/tools.sh" ]
 
 
 ### CLI Only
-FROM --platform=linux/s390x base AS light
+FROM base AS light
 
 WORKDIR /llama.cpp/bin
 
@@ -108,7 +109,7 @@ ENTRYPOINT [ "/llama.cpp/bin/llama-cli" ]
 
 
 ### Server
-FROM --platform=linux/s390x base AS server
+FROM base AS server
 
 ENV LLAMA_ARG_HOST=0.0.0.0
Repository: electron/electron
Pull request: perf: avoid redundant map lookup in ElectronBrowserContext::From()

#### Description of Change

Small perf cleanup that I found while looking for something else: remove duplicate map lookups from `ElectronBrowserContet::From()` and `ElectronBrowserContext::FromPath()`

#### Checklist

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none.

Changed files:
filename: shell/browser/electron_browser_context.cc
patch: @@ -833,34 +833,23 @@ ElectronBrowserContext* ElectronBrowserContext::From(
     const std::string& partition,
     bool in_memory,
     base::Value::Dict options) {
-  PartitionKey key(partition, in_memory);
-  ElectronBrowserContext* browser_context = browser_context_map()[key].get();
-  if (browser_context) {
-    return browser_context;
+  auto& context = browser_context_map()[PartitionKey(partition, in_memory)];
+  if (!context) {
+    context.reset(new ElectronBrowserContext{std::cref(partition), in_memory,
+                                             std::move(options)});
   }
-
-  auto* new_context = new ElectronBrowserContext(std::cref(partition),
-                                                 in_memory, std::move(options));
-  browser_context_map()[key] =
-      std::unique_ptr<ElectronBrowserContext>(new_context);
-  return new_context;
+  return context.get();
 }
 
 ElectronBrowserContext* ElectronBrowserContext::FromPath(
     const base::FilePath& path,
     base::Value::Dict options) {
-  PartitionKey key(path);
-
-  ElectronBrowserContext* browser_context = browser_context_map()[key].get();
-  if (browser_context) {
-    return browser_context;
+  auto& context = browser_context_map()[PartitionKey(path)];
+  if (!context) {
+    context.reset(
+        new ElectronBrowserContext{std::cref(path), false, std::move(options)});
   }
-
-  auto* new_context =
-      new ElectronBrowserContext(std::cref(path), false, std::move(options));
-  browser_context_map()[key] =
-      std::unique_ptr<ElectronBrowserContext>(new_context);
-  return new_context;
+  return context.get();
 }
 
 }  // namespace electron
Repository: vercel/next.js
Pull request: Revert "[test] workaround test that needs stylus"

stylus is back to life

Reverts vercel/next.js#81965

Changed files:
filename: test/e2e/app-dir/nx-handling/nx-handling.test.ts
patch: @@ -32,10 +32,6 @@ describe('nx-handling', () => {
         tslib: '^2.3.0',
         typescript: '~5.7.2',
       },
-      overrides: {
-        // Workaround for `stylus` marked as a security vulnerability on npm
-        stylus: '0.0.1-security',
-      },
       workspaces: ['apps/*'],
     },
   })
Repository: nodejs/node
Pull request: test: remove --no-warnings flag

This change should have no effect since the test does not appear to emit any warnings. If there are warnings, we probably should handle them properly instead of passing this flag to the runtime.

Refs: https://github.com/nodejs/node/pull/35093

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: test/parallel/test-crypto-authenticated.js
patch: @@ -18,7 +18,7 @@
 // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
-// Flags: --no-warnings
+
 'use strict';
 const common = require('../common');
 if (!common.hasCrypto) {
Repository: electron/electron
Pull request: build: fix compound bash conditional in patchup

Backport of #46047

See that PR for details.


Notes: none

Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -99,7 +99,7 @@ runs:
       fi
 
       ELECTRON_USE_THREE_WAY_MERGE_FOR_PATCHES=1 e d gclient sync --with_branch_heads --with_tags -vv
-      if [ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]; then
+      if [[ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]]; then
         # Re-export all the patches to check if there were changes.
         python3 src/electron/script/export_all_patches.py src/electron/patches/config.json
         cd src/electron
@@ -128,6 +128,8 @@ runs:
             cat ../../patches/update-patches.patch
             exit 1
           fi
+        else
+          echo "No changes to patches detected"
         fi
       fi
Repository: nodejs/node
Pull request: zlib: remove mentions of unexposed Z_TREES constant

`Z_TREES` is never exposed on `DefineZlibConstants()`, hence it shall be
removed.

This fix is applicable to v18+.

Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/zlib.md
patch: @@ -615,7 +615,6 @@ Allowed flush values.
 * `zlib.constants.Z_FULL_FLUSH`
 * `zlib.constants.Z_FINISH`
 * `zlib.constants.Z_BLOCK`
-* `zlib.constants.Z_TREES`
 
 Return codes for the compression/decompression functions. Negative
 values are errors, positive values are used for special but normal

filename: lib/zlib.js
patch: @@ -307,7 +307,7 @@ ZlibBase.prototype._final = function(callback) {
 // This is currently only used to figure out which flush flag to use for the
 // last chunk.
 // Roughly, the following holds:
-// Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
+// Z_NO_FLUSH < Z_BLOCK < Z_PARTIAL_FLUSH <
 //     Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
 const flushiness = [];
 const kFlushFlagList = [Z_NO_FLUSH, Z_BLOCK, Z_PARTIAL_FLUSH,