helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: buffer: avoid creating unnecessary environment

We don't have to deference the args pointer to create an environment variable while having access to isolate using `args.GetIsolate()`

Changed files:
filename: src/node_buffer.cc
patch: @@ -721,11 +721,11 @@ void StringWrite(const FunctionCallbackInfo<Value>& args) {
 }
 
 void SlowByteLengthUtf8(const FunctionCallbackInfo<Value>& args) {
-  Environment* env = Environment::GetCurrent(args);
   CHECK(args[0]->IsString());
 
   // Fast case: avoid StringBytes on UTF8 string. Jump to v8.
-  args.GetReturnValue().Set(args[0].As<String>()->Utf8Length(env->isolate()));
+  args.GetReturnValue().Set(
+      args[0].As<String>()->Utf8Length(args.GetIsolate()));
 }
 
 uint32_t FastByteLengthUtf8(
Repository: electron/electron
Pull request: build: try removing embedder exception patch

Backport of #45429

See that PR for details.


Notes: none

Changed files:
filename: patches/node/.patches
patch: @@ -22,7 +22,6 @@ test_formally_mark_some_tests_as_flaky.patch
 fix_do_not_resolve_electron_entrypoints.patch
 ci_ensure_node_tests_set_electron_run_as_node.patch
 fix_assert_module_in_the_renderer_process.patch
-fix_capture_embedder_exceptions_before_entering_v8.patch
 test_make_test-node-output-v8-warning_generic.patch
 fix_revert_src_lb_reducing_c_calls_of_esm_legacy_main_resolve.patch
 fix_remove_deprecated_errno_constants.patch

filename: patches/node/fix_capture_embedder_exceptions_before_entering_v8.patch
patch: @@ -1,25 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: deepak1556 <hop2deep@gmail.com>
-Date: Tue, 26 Dec 2023 02:10:42 +0900
-Subject: fix: capture embedder exceptions before entering V8
-
-Upstrem bug: https://github.com/nodejs/node-v8/issues/274
-
-The patch only addresses the callsites that triggered failing DCHECKS
-in the nodejs test suite. Need to be followed-up with upstream
-on the broader change as there maybe other callsites.
-
-diff --git a/src/handle_wrap.cc b/src/handle_wrap.cc
-index 70db7ddbeab5963f1bdf6cb05ee2763d76011cec..6ffe2a2ad01f33ff68c6646df330ec3ac7781a19 100644
---- a/src/handle_wrap.cc
-+++ b/src/handle_wrap.cc
-@@ -148,6 +148,9 @@ void HandleWrap::OnClose(uv_handle_t* handle) {
-   wrap->OnClose();
-   wrap->handle_wrap_queue_.Remove();
- 
-+  if (env->isolate()->IsExecutionTerminating())
-+    return;
-+
-   if (!wrap->persistent().IsEmpty() &&
-       wrap->object()
-           ->Has(env->context(), env->handle_onclose_symbol())
Repository: denoland/deno
Pull request: fix: Remove unnecessary whitespace in prompt function

## Description
Fixes #28828

This PR addresses the issue where unnecessary whitespace is added between the label and input message in the `prompt()` function.

## Changes
- Modified the `prompt()` function to only add a space after the message if the message is non-empty
- This ensures no extra whitespace appears when using an empty label

## Before
- With label: `Statement:  Example statement` (extra space)
- With empty label: ` Example statement` (leading space)

## After
- With label: `Statement: Example statement` (single space)
- With empty label: `Example statement` (no extra space)

## Testing
Manually verified the behavior works correctly for both cases.

Changed files:
filename: runtime/js/41_prompt.js
patch: @@ -1,11 +1,8 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 import { core, primordials } from "ext:core/mod.js";
 import { op_read_line_prompt } from "ext:core/ops";
-const {
-  ArrayPrototypePush,
-  StringPrototypeCharCodeAt,
-  Uint8Array,
-} = primordials;
+const { ArrayPrototypePush, StringPrototypeCharCodeAt, Uint8Array } =
+  primordials;
 
 import { stdin } from "ext:deno_io/12_io.js";
 
@@ -41,10 +38,8 @@ function prompt(message = "Prompt", defaultValue) {
     return null;
   }
 
-  return op_read_line_prompt(
-    `${message} `,
-    `${defaultValue}`,
-  );
+  const formattedMessage = message.length === 0 ? "" : `${message} `;
+  return op_read_line_prompt(formattedMessage, `${defaultValue}`);
 }
 
 function readLineFromStdinSync() {
Repository: vercel/next.js
Pull request: Fix NEXT_CPU_PROF during development

## What?

`next dev` spawns a forked process that wouldn't be instrumented because `cpu-profile.ts` only runs in `cli/next-dev.ts` which is the process that boots the forked process. This adds the initialization to the forked process too. 

Closes PACK-4999

Changed files:
filename: packages/next/src/server/lib/start-server.ts
patch: @@ -1,3 +1,5 @@
+// Start CPU profile if it wasn't already started.
+import './cpu-profile'
 import { getNetworkHost } from '../../lib/get-network-host'
 
 if (performance.getEntriesByName('next-start').length === 0) {
Repository: denoland/deno
Pull request: fix(task): document source of tasks, fix punctuation


Changed files:
filename: cli/args/flags.rs
patch: @@ -3102,13 +3102,13 @@ fn task_subcommand() -> Command {
   command(
     "task",
     cstr!(
-      "Run a task defined in the configuration file.
+      "Run a task defined in the configuration file:
   <p(245)>deno task build</>
 
-List all available tasks:
+List all available tasks (from config files in the current and ancestor directories):
   <p(245)>deno task</>
 
-Evaluate a task from string
+Evaluate a task from string:
   <p(245)>deno task --eval \"echo $(pwd)\"</>"
     ),
     UnstableArgsConfig::ResolutionAndRuntime,
Repository: ggml-org/llama.cpp
Pull request: model-conversion : set pooling type to none in logits.cpp

This commit explicitly sets the pooling type to 'none' in the logits.cpp to support models that have a pooling type specified.

The motivation for this is that some models may have a pooling type set in the model file (.gguf file) and for this specific case where we only want to extract logits, we need to ensure that no pooling is used to so that we are comparing raw logits and not pooled embeddings.


Changed files:
filename: examples/model-conversion/logits.cpp
patch: @@ -112,6 +112,7 @@ int main(int argc, char ** argv) {
     ctx_params.no_perf = false;
     if (embedding_mode) {
         ctx_params.embeddings = true;
+        ctx_params.pooling_type = LLAMA_POOLING_TYPE_NONE;
         ctx_params.n_ubatch = ctx_params.n_batch;
     }
Repository: huggingface/transformers
Pull request: fix `aria` tests

# What does this PR do?



Changed files:
filename: src/transformers/models/aria/modeling_aria.py
patch: @@ -633,6 +633,10 @@ class AriaTextPreTrainedModel(PreTrainedModel):
     _supports_sdpa = True
     _supports_cache_class = True
     _supports_attention_backend = True
+    _can_record_outputs = {
+        "hidden_states": AriaTextDecoderLayer,
+        "attentions": AriaTextAttention,
+    }
 
     def _init_weights(self, module):
         std = self.config.initializer_range

filename: src/transformers/models/aria/modular_aria.py
patch: @@ -42,6 +42,7 @@
 from ..auto import CONFIG_MAPPING, AutoConfig, AutoTokenizer
 from ..llama.configuration_llama import LlamaConfig
 from ..llama.modeling_llama import (
+    LlamaAttention,
     LlamaDecoderLayer,
     LlamaForCausalLM,
     LlamaMLP,
@@ -1250,6 +1251,13 @@ def forward(self, hidden_states: torch.Tensor) -> torch.Tensor:
         return output + shared_expert_output
 
 
+class AriaTextAttention(LlamaAttention):
+    """Multi-headed attention from 'Attention Is All You Need' paper"""
+
+    def __init__(self, config: AriaTextConfig, layer_idx: int):
+        super().__init__()
+
+
 class AriaTextDecoderLayer(LlamaDecoderLayer):
     """
     Aria Text Decoder Layer.
@@ -1279,6 +1287,10 @@ class AriaTextPreTrainedModel(PreTrainedModel):
     _supports_sdpa = True
     _supports_cache_class = True
     _supports_attention_backend = True
+    _can_record_outputs = {
+        "hidden_states": AriaTextDecoderLayer,
+        "attentions": AriaTextAttention,
+    }
 
     def _init_weights(self, module):
         std = self.config.initializer_range
Repository: electron/electron
Pull request: fix: fix mksnapshot gen/v8 path

Backport of #45488

See that PR for details.


Notes: Fixed the path for a needed library used for mksnapshot


Changed files:
filename: .github/actions/build-electron/action.yml
patch: @@ -108,7 +108,9 @@ runs:
         if [ "${{ inputs.target-platform }}" = "win" ]; then
           cd out/Default
           powershell Compress-Archive -update mksnapshot_args mksnapshot.zip
-          powershell Compress-Archive -update gen/v8/embedded.S mksnapshot.zip
+          powershell mkdir mktmp\\gen\\v8
+          powershell Copy-Item gen\\v8\\embedded.S mktmp\\gen\\v8
+          powershell Compress-Archive -update -Path mktmp\\gen mksnapshot.zip
         else
           (cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S)
         fi
Repository: ggml-org/llama.cpp
Pull request: server : enable continuous batching by default

close #6229 

Changed files:
filename: common/common.h
patch: @@ -139,7 +139,7 @@ struct gpt_params {
     bool interactive_first = false; // wait for user input immediately
     bool multiline_input   = false; // reverse the usage of `\`
     bool simple_io         = false; // improves compatibility with subprocesses and limited consoles
-    bool cont_batching     = false; // insert new sequences for decoding on-the-fly
+    bool cont_batching     = true;  // insert new sequences for decoding on-the-fly
 
     bool input_prefix_bos  = false; // prefix BOS to user inputs, preceding input_prefix
     bool ignore_eos        = false; // ignore generated EOS tokens

filename: examples/server/server.cpp
patch: @@ -1758,7 +1758,7 @@ struct server_context {
         }
 
         // process in chunks of params.n_batch
-        int32_t n_batch = llama_n_batch(ctx);
+        int32_t n_batch  = llama_n_batch(ctx);
         int32_t n_ubatch = llama_n_ubatch(ctx);
 
         // next, batch any pending prompts without exceeding n_batch
@@ -2225,7 +2225,7 @@ static void server_print_usage(const char * argv0, const gpt_params & params, co
     printf("  -to N, --timeout N        server read/write timeout in seconds (default: %d)\n", sparams.read_timeout);
     printf("  --embeddings              enable embedding vector output (default: %s)\n", params.embedding ? "enabled" : "disabled");
     printf("  -np N, --parallel N       number of slots for process requests (default: %d)\n", params.n_parallel);
-    printf("  -cb, --cont-batching      enable continuous batching (a.k.a dynamic batching) (default: disabled)\n");
+    printf("  -cb, --cont-batching      enable continuous batching (a.k.a dynamic batching) (default: enabled)\n");
     printf("  -spf FNAME, --system-prompt-file FNAME\n");
     printf("                            set a file to load a system prompt (initial prompt of all slots), this is useful for chat applications.\n");
     printf("  -ctk TYPE, --cache-type-k TYPE\n");
Repository: vercel/next.js
Pull request: Ensure default run name is correct for deploy tests

Looks like when the retry workflow is triggered from the release workflow it doesn't have the default input like it should so this adds the fallback inline for the run-name. 

Changed files:
filename: .github/workflows/test_e2e_deploy_release.yml
patch: @@ -22,7 +22,7 @@ env:
   TURBO_TOKEN: ${{ secrets.HOSTED_TURBO_TOKEN }}
   DD_ENV: 'ci'
 
-run-name: test-e2e-deploy ${{ inputs.nextVersion }}
+run-name: test-e2e-deploy ${{ inputs.nextVersion || 'canary' }}
 
 jobs:
   setup:
Repository: facebook/react
Pull request: validateDOMNesting: Allow hr as child of select

fix #27572 

Changed files:
filename: packages/react-dom-bindings/src/client/validateDOMNesting.js
patch: @@ -244,7 +244,12 @@ function isTagValidWithParent(tag: string, parentTag: ?string): boolean {
   switch (parentTag) {
     // https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inselect
     case 'select':
-      return tag === 'option' || tag === 'optgroup' || tag === '#text';
+      return (
+        tag === 'hr' ||
+        tag === 'option' ||
+        tag === 'optgroup' ||
+        tag === '#text'
+      );
     case 'optgroup':
       return tag === 'option' || tag === '#text';
     // Strictly speaking, seeing an <option> doesn't mean we're in a <select>
Repository: electron/electron
Pull request: fix: fix mksnapshot gen/v8 path

#### Description of Change

Broken by the migration to GHA on Windows, this PR fixes the path for gen\v8\embedded.S used for mksnapshot

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [x] relevant documentation, tutorials, templates and examples are changed or added
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed the path for a needed library used for mksnapshot


Changed files:
filename: .github/actions/build-electron/action.yml
patch: @@ -108,7 +108,9 @@ runs:
         if [ "${{ inputs.target-platform }}" = "win" ]; then
           cd out/Default
           powershell Compress-Archive -update mksnapshot_args mksnapshot.zip
-          powershell Compress-Archive -update gen/v8/embedded.S mksnapshot.zip
+          powershell mkdir mktmp\\gen\\v8
+          powershell Copy-Item gen\\v8\\embedded.S mktmp\\gen\\v8
+          powershell Compress-Archive -update -Path mktmp\\gen mksnapshot.zip
         else
           (cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S)
         fi
Repository: ggml-org/llama.cpp
Pull request: tests : fix test-opt with GGML_BACKEND_DL

Fixes #15598

Changed files:
filename: tests/test-opt.cpp
patch: @@ -3,7 +3,6 @@
 #include "ggml.h"
 #include "ggml-alloc.h"
 #include "ggml-backend.h"
-#include "ggml-cpu.h"
 #include "ggml-opt.h"
 
 #include <cmath>
@@ -899,6 +898,7 @@ static std::pair<int, int> test_backend(
 
 int main(void) {
     ggml_log_set(nullptr, nullptr);
+    ggml_backend_load_all();
     const size_t dev_count = ggml_backend_dev_count();
     printf("Testing %zu devices\n\n", dev_count);
     size_t n_ok = 0;
@@ -911,11 +911,12 @@ int main(void) {
 
         ggml_backend_t backend = ggml_backend_dev_init(devs[i], NULL);
         GGML_ASSERT(backend != NULL);
-#ifndef _MSC_VER
-        if (ggml_backend_is_cpu(backend)) {
-            ggml_backend_cpu_set_n_threads(backend, std::thread::hardware_concurrency() / 2);
+
+        auto * reg = ggml_backend_dev_backend_reg(devs[i]);
+        auto ggml_backend_set_n_threads_fn = (ggml_backend_set_n_threads_t) ggml_backend_reg_get_proc_address(reg, "ggml_backend_set_n_threads");
+        if (ggml_backend_set_n_threads_fn) {
+            ggml_backend_set_n_threads_fn(backend, std::thread::hardware_concurrency() / 2);
         }
-#endif
         backends.push_back(backend);
     }
Repository: vercel/next.js
Pull request: backport: Turbopack: list `assert/strict` as external (#80884)

Backports: 
- #80884

Changed files:
filename: turbopack/crates/turbopack-resolve/src/resolve.rs
patch: @@ -15,8 +15,9 @@ use crate::{
     typescript::{apply_tsconfig_resolve_options, tsconfig, tsconfig_resolve_options},
 };
 
-const NODE_EXTERNALS: [&str; 63] = [
+const NODE_EXTERNALS: [&str; 64] = [
     "assert",
+    "assert/strict",
     "async_hooks",
     "buffer",
     "child_process",
Repository: nodejs/node
Pull request: test: update WPT for WebCryptoAPI to b48efd681e

This is an automated update of the WPT for WebCryptoAPI to https://github.com/web-platform-tests/wpt/commit/b48efd681ea3a5b0daa6b866c3bb54bec895037b.

Changed files:
filename: test/fixtures/wpt/README.md
patch: @@ -33,7 +33,7 @@ Last update:
 - user-timing: https://github.com/web-platform-tests/wpt/tree/5ae85bf826/user-timing
 - wasm/jsapi: https://github.com/web-platform-tests/wpt/tree/cde25e7e3c/wasm/jsapi
 - wasm/webapi: https://github.com/web-platform-tests/wpt/tree/fd1b23eeaa/wasm/webapi
-- WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/164426ace2/WebCryptoAPI
+- WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/b48efd681e/WebCryptoAPI
 - webidl/ecmascript-binding/es-exceptions: https://github.com/web-platform-tests/wpt/tree/a370aad338/webidl/ecmascript-binding/es-exceptions
 - webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/6495c91853/webmessaging/broadcastchannel
 - webstorage: https://github.com/web-platform-tests/wpt/tree/1291340aaa/webstorage

filename: test/fixtures/wpt/WebCryptoAPI/import_export/importKey_failures.js
patch: @@ -267,4 +267,23 @@ function run_test(algorithmNames) {
             });
         });
     });
+
+    // Use an 'alg' field with incorrect casing.
+    testVectors.forEach(function(vector) {
+        var name = vector.name;
+        if (name !== "Ed25519" && name !== "Ed448")
+            return; // The rest ignore the 'alg' field.
+        allAlgorithmSpecifiersFor(name).forEach(function(algorithm) {
+            getValidKeyData(algorithm).forEach(function(test) {
+                if (test.format === "jwk") {
+                    var data = {crv: test.data.crv, kty: test.data.kty, d: test.data.d, x: test.data.x, y: test.data.y};
+                    var usages =  validUsages(vector, 'jwk', test.data);
+                    [name.toLowerCase(), name.toUpperCase()].forEach(function(algName) {
+                        data.alg = algName;
+                        testError('jwk', algorithm, data, name, usages, true, "DataError", "Invalid 'alg' field '" + data.alg + "'");
+                    });
+                }
+            });
+        });
+    });
 }

filename: test/fixtures/wpt/versions.json
patch: @@ -92,7 +92,7 @@
     "path": "wasm/webapi"
   },
   "WebCryptoAPI": {
-    "commit": "164426ace287247bd99e6d1cee31035875ad57a0",
+    "commit": "b48efd681ea3a5b0daa6b866c3bb54bec895037b",
     "path": "WebCryptoAPI"
   },
   "webidl/ecmascript-binding/es-exceptions": {
Repository: denoland/deno
Pull request: fix(ext/node): Fix `Writable.toWeb()`

Fixes https://github.com/denoland/deno/issues/28905

<!--
Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label.
-->


Changed files:
filename: ext/node/polyfills/internal/webstreams/adapters.js
patch: @@ -627,7 +627,7 @@ export function newWritableStreamFromStreamWritable(streamWritable) {
 
     async write(chunk) {
       if (streamWritable.writableNeedDrain || !streamWritable.write(chunk)) {
-        backpressurePromise = createDeferredPromise();
+        backpressurePromise = Promise.withResolvers();
         return backpressurePromise.promise.finally(() => {
           backpressurePromise = undefined;
         });
@@ -640,7 +640,7 @@ export function newWritableStreamFromStreamWritable(streamWritable) {
 
     close() {
       if (closed === undefined && !isWritableEnded(streamWritable)) {
-        closed = createDeferredPromise();
+        closed = Promise.withResolvers();
         streamWritable.end();
         return closed.promise;
       }

filename: tests/unit_node/stream_test.ts
patch: @@ -3,7 +3,8 @@
 import { assert, assertEquals } from "@std/assert";
 import { fromFileUrl, relative } from "@std/path";
 import { finished, pipeline } from "node:stream/promises";
-import { getDefaultHighWaterMark, Stream } from "node:stream";
+import { getDefaultHighWaterMark, Stream, Writable } from "node:stream";
+import { TextEncoderStream } from "node:stream/web";
 import { createReadStream, createWriteStream } from "node:fs";
 import { EventEmitter } from "node:events";
 
@@ -52,3 +53,27 @@ Deno.test("finished on web streams", async () => {
   }
   await promise;
 });
+
+// https://github.com/denoland/deno/issues/28905
+Deno.test("Writable toWeb", async () => {
+  const nodeWritable = new Writable({
+    write(_chunk, _encoding, callback) {
+      // Simulate the issue by delaying the callback slightly
+      setTimeout(() => {
+        callback();
+      }, 10);
+    },
+  });
+
+  const webWritable = Writable.toWeb(nodeWritable);
+
+  const source = ["line1", "line2", "line3"];
+  const readable = ReadableStream.from(source);
+
+  await readable
+    // @ts-ignore wrong types
+    .pipeThrough(new TextEncoderStream())
+    .pipeTo(webWritable);
+
+  await finished(nodeWritable);
+});
Repository: electron/electron
Pull request: build: bump actions/cache past deprecated version

Backport of #45192

See that PR for details.


Notes: none


Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -49,7 +49,7 @@ runs:
       curl --unix-socket /var/run/sas/sas.sock --fail "http://foo/$DEPSHASH.tar" > sas-token
   - name: Save SAS Key
     if: ${{ inputs.generate-sas-token == 'true' }}
-    uses: actions/cache/save@v4
+    uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57
     with:
       path: |
         sas-token

filename: .github/actions/install-dependencies/action.yml
patch: @@ -7,7 +7,7 @@ runs:
     shell: bash
     id: yarn-cache-dir-path
     run: echo "dir=$(node src/electron/script/yarn cache dir)" >> $GITHUB_OUTPUT
-  - uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
+  - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57
     id: yarn-cache
     with:
       path: ${{ steps.yarn-cache-dir-path.outputs.dir }}

filename: .github/actions/restore-cache-azcopy/action.yml
patch: @@ -5,14 +5,14 @@ runs:
   steps:
   - name: Obtain SAS Key
     continue-on-error: true
-    uses: actions/cache/restore@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
+    uses: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57
     with:
       path: |
         sas-token
       key: sas-key-${{ github.run_number }}-1
   - name: Obtain SAS Key
     continue-on-error: true
-    uses: actions/cache/restore@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
+    uses: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57
     with:
       path: |
         sas-token