helloadhavan/github_issues huggingface dataset:
Repository: huggingface/transformers
Pull request: Fix loop var naming

Our code contained the loop `for tuple in gen:` which clobbered the built-in Python `tuple`. This was a silent error that surfaced when we did some recent type hint fixes.

This PR fixes it by renaming the loop variable to something that doesn't overwrite a Python built-in like that!

Changed files:
filename: src/transformers/modeling_utils.py
patch: @@ -380,10 +380,10 @@ def find_tensor_attributes(module: nn.Module) -> list[tuple[str, Tensor]]:
 
     gen = parameter._named_members(get_members_fn=find_tensor_attributes)
     last_tuple = None
-    for tuple in gen:
-        last_tuple = tuple
-        if tuple[1].is_floating_point():
-            return tuple[1].dtype
+    for gen_tuple in gen:
+        last_tuple = gen_tuple
+        if gen_tuple[1].is_floating_point():
+            return gen_tuple[1].dtype
 
     if last_tuple is not None:
         # fallback to the last dtype
Repository: vercel/next.js
Pull request: Show string values for configured experimental features

Follow-up to #74692. We can not only show numbers, but also strings when printing the configured experimental features in the CLI.

Changed files:
filename: packages/next/src/server/lib/app-info-log.ts
patch: @@ -53,7 +53,11 @@ export function logStartInfo({
             : bold('⨯')
           : '·'
 
-      const suffix = typeof exp.value === 'number' ? `: ${exp.value}` : ''
+      const suffix =
+        typeof exp.value === 'number' || typeof exp.value === 'string'
+          ? `: ${JSON.stringify(exp.value)}`
+          : ''
+
       const reason = exp.reason ? ` (${exp.reason})` : ''
 
       Log.bootstrap(`  ${symbol} ${exp.key}${suffix}${reason}`)

filename: test/integration/config-experimental-warning/test/index.test.js
patch: @@ -143,6 +143,20 @@ describe('Config Experimental Warning', () => {
     expect(stdout).toMatch(' · cpus: 2')
   })
 
+  it('should show the configured value for string features', async () => {
+    configFile.write(`
+      module.exports = {
+        experimental: {
+          ppr: 'incremental'
+        }
+      }
+    `)
+
+    const stdout = await collectStdoutFromDev(appDir)
+    expect(stdout).toMatch(experimentalHeader)
+    expect(stdout).toMatch(' · ppr: "incremental"')
+  })
+
   it('should show warning with config from object with experimental and multiple keys', async () => {
     configFile.write(`
       module.exports = {
Repository: denoland/deno
Pull request: fix(lsp): silence debug error for 'move to a new file' action

Alleviates https://github.com/denoland/deno/issues/27778#issuecomment-2607477597.

I think this might be fixed in TS 5.7:
- https://github.com/microsoft/TypeScript/issues/59651
- https://github.com/microsoft/TypeScript/pull/60333

Changed files:
filename: cli/lsp/language_server.rs
patch: @@ -1884,7 +1884,7 @@ impl Inner {
         })?;
       let asset_or_doc = self.get_asset_or_document(&action_data.specifier)?;
       let line_index = asset_or_doc.line_index();
-      let mut refactor_edit_info = self
+      let refactor_edit_info = self
         .ts_server
         .get_edits_for_refactor(
           self.snapshot(),
@@ -1905,19 +1905,34 @@ impl Inner {
           )),
           asset_or_doc.scope().cloned(),
         )
-        .await?;
-      if kind_suffix == ".rewrite.function.returnType"
-        || kind_suffix == ".move.newFile"
-      {
-        refactor_edit_info.edits =
-          fix_ts_import_changes(&refactor_edit_info.edits, self).map_err(
-            |err| {
-              error!("Unable to remap changes: {:#}", err);
-              LspError::internal_error()
-            },
-          )?
+        .await;
+
+      match refactor_edit_info {
+        Ok(mut refactor_edit_info) => {
+          if kind_suffix == ".rewrite.function.returnType"
+            || kind_suffix == ".move.newFile"
+          {
+            refactor_edit_info.edits =
+              fix_ts_import_changes(&refactor_edit_info.edits, self).map_err(
+                |err| {
+                  error!("Unable to remap changes: {:#}", err);
+                  LspError::internal_error()
+                },
+              )?
+          }
+          code_action.edit = refactor_edit_info.to_workspace_edit(self)?;
+        }
+        Err(err) => {
+          // TODO(nayeemrmn): Investigate cause for
+          // https://github.com/denoland/deno/issues/27778. Prevent popups for
+          // this error for now.
+          if kind_suffix == ".move.newFile" {
+            lsp_warn!("{:#}", err);
+          } else {
+            return Err(err);
+          }
+        }
       }
-      code_action.edit = refactor_edit_info.to_workspace_edit(self)?;
       code_action
     } else {
       // The code action doesn't need to be resolved
Repository: huggingface/transformers
Pull request: Fixed markdown for BertTokenizer's '[CLS]' token.

# What does this PR do?

This PR fixes a trivial markdown issue on the formatting of the BertTokenizer's '[CLS]' token in the docstring for `add_special_tokens`


Changed files:
filename: src/transformers/tokenization_utils_base.py
patch: @@ -911,7 +911,7 @@ def add_special_tokens(
           makes it easy to develop model-agnostic training and fine-tuning scripts.
 
         When possible, special tokens are already registered for provided pretrained models (for instance
-        [`BertTokenizer`] `cls_token` is already registered to be :obj*'[CLS]'* and XLM's one is also registered to be
+        [`BertTokenizer`] `cls_token` is already registered to be `'[CLS]'` and XLM's one is also registered to be
         `'
'`).
 
         Args:
Repository: facebook/react
Pull request: Move ReactDOMFloat to react-dom/src/

This is not really part of the bindings, it's more part of the package entry points. /shared/ is not really right neither because it's more like an isomorphic entry point and not some utility.

Changed files:
filename: packages/react-dom/src/client/ReactDOM.js
patch: @@ -55,12 +55,7 @@ import {
 } from 'react-dom-bindings/src/events/ReactDOMControlledComponent';
 import Internals from '../ReactDOMSharedInternals';
 
-export {
-  prefetchDNS,
-  preconnect,
-  preload,
-  preinit,
-} from 'react-dom-bindings/src/shared/ReactDOMFloat';
+export {prefetchDNS, preconnect, preload, preinit} from '../ReactDOMFloat';
 
 if (__DEV__) {
   if (

filename: packages/react-dom/src/server/ReactDOMServerRenderingStub.js
patch: @@ -7,12 +7,7 @@
  * @flow
  */
 
-export {
-  preinit,
-  preload,
-  preconnect,
-  prefetchDNS,
-} from 'react-dom-bindings/src/shared/ReactDOMFloat';
+export {preinit, preload, preconnect, prefetchDNS} from '../ReactDOMFloat';
 
 export function createPortal() {
   throw new Error(
Repository: denoland/deno
Pull request: fix(ext/node): reference error in zlib.crc32

Fixes https://github.com/denoland/deno/issues/27774

Changed files:
filename: ext/node/polyfills/zlib.ts
patch: @@ -45,6 +45,7 @@ import { validateUint32 } from "ext:deno_node/internal/validators.mjs";
 import { op_zlib_crc32 } from "ext:core/ops";
 import { core, primordials } from "ext:core/mod.js";
 import { TextEncoder } from "ext:deno_web/08_text_encoding.js";
+import { isArrayBufferView } from "ext:deno_node/internal/util/types.ts";
 const {
   Uint8Array,
   TypedArrayPrototypeGetBuffer,

filename: tests/unit_node/zlib_test.ts
patch: @@ -1,6 +1,6 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 
-import { assert, assertEquals } from "@std/assert";
+import { assert, assertEquals, assertThrows } from "@std/assert";
 import { fromFileUrl, relative } from "@std/path";
 import {
   brotliCompress,
@@ -229,4 +229,6 @@ Deno.test("gzip() and gzipSync() accept ArrayBuffer", async () => {
 
 Deno.test("crc32()", () => {
   assertEquals(crc32("hello world"), 222957957);
+  // @ts-expect-error: passing an object
+  assertThrows(() => crc32({}), TypeError);
 });
Repository: denoland/deno
Pull request: perf: full LTO in sysroot

Decreases binary size by ~15MB on Linux

```
$ du -h ./deno # full LTO
122M	./deno

$ du -h $(which deno) # thin LTO, canary
137M	/usr/bin/deno
```

Changed files:
filename: .github/workflows/ci.generate.ts
patch: @@ -130,9 +130,7 @@ cat /sysroot/.env
 #      to build because the object formats are not compatible.
 echo "
 CARGO_PROFILE_BENCH_INCREMENTAL=false
-CARGO_PROFILE_BENCH_LTO=false
 CARGO_PROFILE_RELEASE_INCREMENTAL=false
-CARGO_PROFILE_RELEASE_LTO=false
 RUSTFLAGS<<__1
   -C linker-plugin-lto=true
   -C linker=clang-${llvmVersion}
@@ -156,7 +154,7 @@ RUSTDOCFLAGS<<__1
   $RUSTFLAGS
 __1
 CC=/usr/bin/clang-${llvmVersion}
-CFLAGS=-flto=thin $CFLAGS
+CFLAGS=$CFLAGS
 " > $GITHUB_ENV`,
 };
 

filename: .github/workflows/ci.yml
patch: @@ -307,9 +307,7 @@ jobs:
           #      to build because the object formats are not compatible.
           echo "
           CARGO_PROFILE_BENCH_INCREMENTAL=false
-          CARGO_PROFILE_BENCH_LTO=false
           CARGO_PROFILE_RELEASE_INCREMENTAL=false
-          CARGO_PROFILE_RELEASE_LTO=false
           RUSTFLAGS<<__1
             -C linker-plugin-lto=true
             -C linker=clang-19
@@ -333,7 +331,7 @@ jobs:
             $RUSTFLAGS
           __1
           CC=/usr/bin/clang-19
-          CFLAGS=-flto=thin $CFLAGS
+          CFLAGS=$CFLAGS
           " > $GITHUB_ENV
       - name: Remove macOS cURL --ipv4 flag
         run: |-
Repository: nodejs/node
Pull request: meta: remove ovflowd as collaborator

I don't feel comfortable being a collaborator. While I am not actively involved in the day-to-day work within nodejs/node, I believe my contributions are still critical to it. However, I do not feel at ease participating in conversations within nodejs/collaborators. Given the internal discussions, I genuinely prefer to refrain from engaging in conversations related to collaborations; otherwise, I feel like I'm compromising my values and being hypocritical.

I will continue to do critical work, but I don’t think I should be a core collaborator as I don't belong in the "core collaborators" team.

Thank you.

Changed files:
filename: README.md
patch: @@ -403,8 +403,6 @@ For information about the governance of the Node.js project, see
   **Moshe Atlow** <<moshe@atlow.co.il>> (he/him)
 * [MrJithil](https://github.com/MrJithil) -
   **Jithil P Ponnan** <<jithil@outlook.com>> (he/him)
-* [ovflowd](https://github.com/ovflowd) -
-  **Claudio Wunder** <<cwunder@gnome.org>> (he/they)
 * [panva](https://github.com/panva) -
   **Filip Skokan** <<panva.ip@gmail.com>> (he/him)
 * [pimterry](https://github.com/pimterry) -
@@ -629,6 +627,8 @@ For information about the governance of the Node.js project, see
   **Alexis Campailla** <<orangemocha@nodejs.org>>
 * [othiym23](https://github.com/othiym23) -
   **Forrest L Norvell** <<ogd@aoaioxxysz.net>> (they/them/themself)
+* [ovflowd](https://github.com/ovflowd) -
+  **Claudio Wunder** <<cwunder@gnome.org>> (he/they)
 * [oyyd](https://github.com/oyyd) -
   **Ouyang Yadong** <<oyydoibh@gmail.com>> (he/him)
 * [petkaantonov](https://github.com/petkaantonov) -
Repository: electron/electron
Pull request: fix: clang-tidy `performance-inefficient-vector-operation` warnings (33-x-y)

Manually backport #44743 to 33-x-y. See that PR for details.

The backport needed human intervention because of minor `#include` context shear 

Notes: none.

Changed files:
filename: shell/browser/api/electron_api_crash_reporter.cc
patch: @@ -10,7 +10,7 @@
 #include <utility>
 #include <vector>
 
-#include "base/functional/bind.h"
+#include "base/containers/to_vector.h"
 #include "base/no_destructor.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ -221,18 +221,17 @@ v8::Local<v8::Value> GetUploadedReports(v8::Isolate* isolate) {
     list->LoadSync();
   }
 
+  auto to_obj = [isolate](const UploadList::UploadInfo* upload) {
+    return gin::DataObjectBuilder{isolate}
+        .Set("date", upload->upload_time)
+        .Set("id", upload->upload_id)
+        .Build();
+  };
+
   constexpr size_t kMaxUploadReportsToList = std::numeric_limits<size_t>::max();
-  const std::vector<const UploadList::UploadInfo*> uploads =
-      list->GetUploads(kMaxUploadReportsToList);
-  std::vector<v8::Local<v8::Object>> result;
-  for (auto* const upload : uploads) {
-    result.push_back(gin::DataObjectBuilder(isolate)
-                         .Set("date", upload->upload_time)
-                         .Set("id", upload->upload_id)
-                         .Build());
-  }
-  v8::Local<v8::Value> v8_result = gin::ConvertToV8(isolate, result);
-  return v8_result;
+  return gin::ConvertToV8(
+      isolate,
+      base::ToVector(list->GetUploads(kMaxUploadReportsToList), to_obj));
 }
 #endif
 

filename: shell/common/api/electron_api_clipboard.cc
patch: @@ -7,6 +7,7 @@
 #include <map>
 
 #include "base/containers/contains.h"
+#include "base/containers/to_vector.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "shell/browser/browser.h"
@@ -281,11 +282,8 @@ void Clipboard::Clear(gin_helper::Arguments* args) {
 
 // This exists for testing purposes ONLY.
 void Clipboard::WriteFilesForTesting(const std::vector<base::FilePath>& files) {
-  std::vector<ui::FileInfo> file_infos;
-  for (const auto& file : files) {
-    file_infos.emplace_back(ui::FileInfo(ui::FileInfo(file, file.BaseName())));
-  }
-
+  auto to_info = [](const auto& p) { return ui::FileInfo{p, p.BaseName()}; };
+  auto file_infos = base::ToVector(files, to_info);
   ui::ScopedClipboardWriter writer(ui::ClipboardBuffer::kCopyPaste);
   writer.WriteFilenames(ui::FileInfosToURIList(file_infos));
 }
Repository: vercel/next.js
Pull request: Prevent typescript errors in IDE for newly generated tests (part 2)

Follow-up to #78247. This prevents the following error when first opening the generated test file in the IDE:

```
Cannot find module 'e2e-utils' or its corresponding type declarations.
```

We're adding the patterns `**/*.test.ts` and `**/*.test.tsx` to the `tsconfig.json` exclude list in the generator. This is the same patch that's applied in `writeConfigurationDefaults` when first starting the app. By generating it upfront, we ensure that the test files compile without errors when first opened in the IDE, before running `next dev`.

Note: Excluding works because TypeScript looks for another matching `tsconfig.json` further up in the file tree. It finds the root config which includes the test files.

Changed files:
filename: turbo/generators/config.ts
patch: @@ -94,6 +94,11 @@ export default function generator(plop: NodePlopAPI): void {
           type: 'add',
           templateFile: path.join(cnaTemplatePath, 'tsconfig.json'),
           path: path.join(targetPath, name, 'tsconfig.json'),
+          transform: (template: string) =>
+            template.replace(
+              '"exclude": ["node_modules"]',
+              '"exclude": ["node_modules", "**/*.test.ts", "**/*.test.tsx"]'
+            ),
         },
         {
           type: 'add',
Repository: facebook/react
Pull request: [Flight] Gated test for dropped transport of undefined object values

## Summary

With https://github.com/facebook/react/pull/26349 we now serialize `undefined`. However, deserializing it on the client is currently indistinguishable from the value missing entirely due to how `JSON.parse` treats `undefined` return value of reviver functions.

This leads to inconsistent behavior of the `Object.hasOwn` or `in` operator (used for narrowing in TypeScript). In TypeScript-speak, `{ prop: T | undefined}` will arrive as `{ prop?: T }`.

## How did you test this change?

- Added test that is expected to fail. Though ideally the implementation of the component would not care whether it's used on the client or server.


Changed files:
filename: packages/react-client/src/__tests__/ReactFlight-test.js
patch: @@ -213,6 +213,40 @@ describe('ReactFlight', () => {
     expect(ReactNoop).toMatchRenderedOutput(null);
   });
 
+  // @gate FIXME
+  it('should transport undefined object values', async () => {
+    function ServerComponent(props) {
+      return 'prop' in props
+        ? `\`prop\` in props as '${props.prop}'`
+        : '`prop` not in props';
+    }
+    const ClientComponent = clientReference(ServerComponent);
+
+    const model = (
+      <>
+        <div>
+          Server: <ServerComponent prop={undefined} />
+        </div>
+        <div>
+          Client: <ClientComponent prop={undefined} />
+        </div>
+      </>
+    );
+
+    const transport = ReactNoopFlightServer.render(model);
+
+    await act(async () => {
+      ReactNoop.render(await ReactNoopFlightClient.read(transport));
+    });
+
+    expect(ReactNoop).toMatchRenderedOutput(
+      <>
+        <div>Server: `prop` in props as 'undefined'</div>
+        <div>Client: `prop` in props as 'undefined'</div>
+      </>,
+    );
+  });
+
   it('can render an empty fragment', async () => {
     function Empty() {
       return <React.Fragment />;
Repository: electron/electron
Pull request: fix: remove unused local variables

Backport of #44815

See that PR for details.


Notes: none.

Changed files:
filename: shell/browser/api/electron_api_app.cc
patch: @@ -1009,8 +1009,6 @@ bool App::RequestSingleInstanceLock(gin::Arguments* args) {
   if (HasSingleInstanceLock())
     return true;
 
-  std::string program_name = electron::Browser::Get()->GetName();
-
   base::FilePath user_dir;
   base::PathService::Get(chrome::DIR_USER_DATA, &user_dir);
   // The user_dir may not have been created yet.
@@ -1021,6 +1019,7 @@ bool App::RequestSingleInstanceLock(gin::Arguments* args) {
   blink::CloneableMessage additional_data_message;
   args->GetNext(&additional_data_message);
 #if BUILDFLAG(IS_WIN)
+  const std::string program_name = electron::Browser::Get()->GetName();
   bool app_is_sandboxed =
       IsSandboxEnabled(base::CommandLine::ForCurrentProcess());
   process_singleton_ = std::make_unique<ProcessSingleton>(

filename: shell/browser/relauncher.cc
patch: @@ -157,7 +157,6 @@ int RelauncherMain(const content::MainFunctionParams& main_parameters) {
   // Figure out what to execute, what arguments to pass it, and whether to
   // start it in the background.
   bool in_relauncher_args = false;
-  StringType relaunch_executable;
   StringVector relauncher_args;
   StringVector launch_argv;
   for (size_t argv_index = 2; argv_index < argv.size(); ++argv_index) {

filename: shell/browser/ui/views/global_menu_bar_registrar_x11.cc
patch: @@ -80,7 +80,6 @@ void GlobalMenuBarRegistrarX11::RegisterXWindow(x11::Window window) {
 
 void GlobalMenuBarRegistrarX11::UnregisterXWindow(x11::Window window) {
   DCHECK(registrar_proxy_);
-  std::string path = electron::GlobalMenuBarX11::GetPathForWindow(window);
 
   ANNOTATE_SCOPED_MEMORY_LEAK;  // http://crbug.com/314087
   // TODO(erg): The mozilla implementation goes to a lot of callback trouble
Repository: facebook/react
Pull request: Remove unnecessary CIRCLE_CI_API_TOKEN checks

Token is not required for GET

Changed files:
filename: packages/react-devtools-inline/README.md
patch: @@ -354,8 +354,6 @@ yarn
 ./download-experimental-build.js --commit=main
 ```
 
-Please note that you might need to [create a Circle CI API Token](https://circleci.com/docs/2.0/managing-api-tokens/) and set up an environment variable `CIRCLE_CI_API_TOKEN`.
-
 ## Build steps
 Once the above packages have been built or downloaded, you can watch for changes made to the source code and automatically rebuild by running:
 ```sh

filename: scripts/release/shared-commands/download-build-artifacts.js
patch: @@ -22,15 +22,9 @@ const run = async ({build, cwd, releaseChannel}) => {
   }
 
   // Download and extract artifact
-  const {CIRCLE_CI_API_TOKEN} = process.env;
-  if (CIRCLE_CI_API_TOKEN == null) {
-    throw new Error(
-      `Expected a CircleCI token to download artifacts, got ${CIRCLE_CI_API_TOKEN}`
-    );
-  }
   await exec(`rm -rf ./build`, {cwd});
   await exec(
-    `curl -L $(fwdproxy-config curl) ${buildArtifacts.url} -H "Circle-Token: ${CIRCLE_CI_API_TOKEN}" | tar -xvz`,
+    `curl -L $(fwdproxy-config curl) ${buildArtifacts.url} | tar -xvz`,
     {
       cwd,
     }

filename: scripts/release/utils.js
patch: @@ -59,18 +59,8 @@ const extractCommitFromVersionNumber = version => {
 };
 
 const getArtifactsList = async buildID => {
-  const {CIRCLE_CI_API_TOKEN} = process.env;
-  if (CIRCLE_CI_API_TOKEN == null) {
-    throw new Error(
-      `Expected a CircleCI token to download artifacts, got ${CIRCLE_CI_API_TOKEN}`
-    );
-  }
   const jobArtifactsURL = `https://circleci.com/api/v1.1/project/github/facebook/react/${buildID}/artifacts`;
-  const jobArtifacts = await fetch(jobArtifactsURL, {
-    headers: {
-      'Circle-Token': CIRCLE_CI_API_TOKEN,
-    },
-  });
+  const jobArtifacts = await fetch(jobArtifactsURL);
   return jobArtifacts.json();
 };
Repository: facebook/react
Pull request: Make disableSchedulerTimeoutInWorkLoop a static ff

## Overview

There's a known infinite loop with this but we're not running an experiment any time soon.

Changed files:
filename: packages/shared/forks/ReactFeatureFlags.www.js
patch: @@ -25,7 +25,6 @@ export const {
   enableDebugTracing,
   skipUnmountedBoundaries,
   enableUseRefAccessWarning,
-  disableSchedulerTimeoutInWorkLoop,
   enableLazyContextPropagation,
   enableUnifiedSyncLane,
   enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
@@ -47,6 +46,8 @@ export const enableUpdaterTracking = __PROFILE__;
 export const createRootStrictEffectsByDefault = false;
 export const enableSuspenseAvoidThisFallback = true;
 export const enableSuspenseAvoidThisFallbackFizz = false;
+
+export const disableSchedulerTimeoutInWorkLoop = false;
 export const enableCPUSuspense = true;
 export const enableFloat = true;
 export const enableUseHook = true;
Repository: electron/electron
Pull request: fix: remove unused local variables

#### Description of Change

Don't declare local variables that we don't use.

This `bugprone-unused-local-non-trivial-variable` off of our clang-tidy bingo card :smile_cat: 

#### Checklist

- [x] PR description included and stakeholders cc'd
- [ ] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none.

Changed files:
filename: shell/browser/api/electron_api_app.cc
patch: @@ -1011,8 +1011,6 @@ bool App::RequestSingleInstanceLock(gin::Arguments* args) {
   if (HasSingleInstanceLock())
     return true;
 
-  std::string program_name = electron::Browser::Get()->GetName();
-
   base::FilePath user_dir;
   base::PathService::Get(chrome::DIR_USER_DATA, &user_dir);
   // The user_dir may not have been created yet.
@@ -1023,6 +1021,7 @@ bool App::RequestSingleInstanceLock(gin::Arguments* args) {
   blink::CloneableMessage additional_data_message;
   args->GetNext(&additional_data_message);
 #if BUILDFLAG(IS_WIN)
+  const std::string program_name = electron::Browser::Get()->GetName();
   bool app_is_sandboxed =
       IsSandboxEnabled(base::CommandLine::ForCurrentProcess());
   process_singleton_ = std::make_unique<ProcessSingleton>(

filename: shell/browser/relauncher.cc
patch: @@ -157,7 +157,6 @@ int RelauncherMain(const content::MainFunctionParams& main_parameters) {
   // Figure out what to execute, what arguments to pass it, and whether to
   // start it in the background.
   bool in_relauncher_args = false;
-  StringType relaunch_executable;
   StringVector relauncher_args;
   StringVector launch_argv;
   for (size_t argv_index = 2; argv_index < argv.size(); ++argv_index) {

filename: shell/browser/ui/views/global_menu_bar_registrar_x11.cc
patch: @@ -80,7 +80,6 @@ void GlobalMenuBarRegistrarX11::RegisterXWindow(x11::Window window) {
 
 void GlobalMenuBarRegistrarX11::UnregisterXWindow(x11::Window window) {
   DCHECK(registrar_proxy_);
-  std::string path = electron::GlobalMenuBarX11::GetPathForWindow(window);
 
   ANNOTATE_SCOPED_MEMORY_LEAK;  // http://crbug.com/314087
   // TODO(erg): The mozilla implementation goes to a lot of callback trouble