helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: [Flight] Move pendingChunks ref count increment into createTask

Every time we create a task we need to wait for it so we increase a ref count. We can do this in `createTask`. This is in line with what Fizz does too.

They differ in that Flight counts when they're actually flushed where as Fizz decrements them when they complete.

Flight should probably count them when they complete so it's possible to wait for the end before flushing for buffering purposes.

Changed files:
filename: packages/react-server/src/ReactFlightServer.js
patch: @@ -296,7 +296,6 @@ export function createRequest(
     onError: onError === undefined ? defaultErrorHandler : onError,
     onPostpone: onPostpone === undefined ? defaultPostponeHandler : onPostpone,
   };
-  request.pendingChunks++;
   const rootTask = createTask(request, model, null, false, abortSet);
   pingedTasks.push(rootTask);
   return request;
@@ -318,7 +317,6 @@ function serializeThenable(
   task: Task,
   thenable: Thenable<any>,
 ): number {
-  request.pendingChunks++;
   const newTask = createTask(
     request,
     null,
@@ -722,6 +720,7 @@ function createTask(
   implicitSlot: boolean,
   abortSet: Set<Task>,
 ): Task {
+  request.pendingChunks++;
   const id = request.nextChunkId++;
   if (typeof model === 'object' && model !== null) {
     // If we're about to write this into a new task we can assign it an ID early so that
@@ -906,7 +905,6 @@ function serializeClientReference(
 }
 
 function outlineModel(request: Request, value: ReactClientValue): number {
-  request.pendingChunks++;
   const newTask = createTask(
     request,
     value,
@@ -1068,7 +1066,6 @@ function renderModel(
       // $FlowFixMe[method-unbinding]
       if (typeof x.then === 'function') {
         // Something suspended, we'll need to create a new task and resolve it later.
-        request.pendingChunks++;
         const newTask = createTask(
           request,
           task.model,
Repository: vercel/next.js
Pull request: Fix API stripping JSON incorrectly

This ensures we don't normalize unless it's actually a `_next/data` request. 

Fixes: https://github.com/vercel/next.js/issues/81936

Changed files:
filename: packages/next/src/shared/lib/page-path/normalize-data-path.ts
patch: @@ -1,7 +1,12 @@
+import { pathHasPrefix } from '../router/utils/path-has-prefix'
+
 /**
  * strip _next/data/<build-id>/ prefix and .json suffix
  */
 export function normalizeDataPath(pathname: string) {
+  if (!pathHasPrefix(pathname || '/', '/_next/data')) {
+    return pathname
+  }
   pathname = pathname
     .replace(/\/_next\/data\/[^/]{1,}/, '')
     .replace(/\.json$/, '')

filename: test/integration/api-support/test/index.test.js
patch: @@ -25,6 +25,12 @@ let mode
 let app
 
 function runTests(dev = false) {
+  it('should not strip .json from API route', async () => {
+    const res = await fetchViaHTTP(appPort, '/api/hello.json')
+    expect(res.status).toBe(200)
+    expect(await res.json()).toEqual({ post: 'hello.json' })
+  })
+
   it('should handle proxying to self correctly', async () => {
     const res1 = await fetchViaHTTP(appPort, '/api/proxy-self')
     expect(res1.status).toBe(200)
Repository: ggml-org/llama.cpp
Pull request: musa: fix ci

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

This PR addresses the musa docker build issue.

Changed files:
filename: .devops/musa.Dockerfile
patch: @@ -2,9 +2,9 @@ ARG UBUNTU_VERSION=22.04
 # This needs to generally match the container host's environment.
 ARG MUSA_VERSION=rc4.3.0
 # Target the MUSA build image
-ARG BASE_MUSA_DEV_CONTAINER=sh-harbor.mthreads.com/haive/mthreads/musa:${MUSA_VERSION}-devel-ubuntu${UBUNTU_VERSION}-amd64
+ARG BASE_MUSA_DEV_CONTAINER=mthreads/musa:${MUSA_VERSION}-devel-ubuntu${UBUNTU_VERSION}-amd64
 
-ARG BASE_MUSA_RUN_CONTAINER=sh-harbor.mthreads.com/haive/mthreads/musa:${MUSA_VERSION}-runtime-ubuntu${UBUNTU_VERSION}-amd64
+ARG BASE_MUSA_RUN_CONTAINER=mthreads/musa:${MUSA_VERSION}-runtime-ubuntu${UBUNTU_VERSION}-amd64
 
 FROM ${BASE_MUSA_DEV_CONTAINER} AS build
Repository: ggml-org/llama.cpp
Pull request: musa: upgrade musa sdk to 4.3.0

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

This PR upgrades the MUSA SDK from `rc4.2.0` to `rc4.3.0`.

### Testing Done

- [x] Build/run full/light/server docker targets using `.devops/musa.Dockerfile`

Changed files:
filename: .devops/musa.Dockerfile
patch: @@ -1,10 +1,10 @@
 ARG UBUNTU_VERSION=22.04
 # This needs to generally match the container host's environment.
-ARG MUSA_VERSION=rc4.2.0
+ARG MUSA_VERSION=rc4.3.0
 # Target the MUSA build image
-ARG BASE_MUSA_DEV_CONTAINER=mthreads/musa:${MUSA_VERSION}-devel-ubuntu${UBUNTU_VERSION}-amd64
+ARG BASE_MUSA_DEV_CONTAINER=sh-harbor.mthreads.com/haive/mthreads/musa:${MUSA_VERSION}-devel-ubuntu${UBUNTU_VERSION}-amd64
 
-ARG BASE_MUSA_RUN_CONTAINER=mthreads/musa:${MUSA_VERSION}-runtime-ubuntu${UBUNTU_VERSION}-amd64
+ARG BASE_MUSA_RUN_CONTAINER=sh-harbor.mthreads.com/haive/mthreads/musa:${MUSA_VERSION}-runtime-ubuntu${UBUNTU_VERSION}-amd64
 
 FROM ${BASE_MUSA_DEV_CONTAINER} AS build
 

filename: .github/workflows/build.yml
patch: @@ -475,7 +475,7 @@ jobs:
 
   ubuntu-22-cmake-musa:
     runs-on: ubuntu-22.04
-    container: mthreads/musa:rc4.2.0-devel-ubuntu22.04-amd64
+    container: mthreads/musa:rc4.3.0-devel-ubuntu22.04-amd64
 
     steps:
       - name: Clone

filename: ci/README-MUSA.md
patch: @@ -21,7 +21,7 @@ docker run --privileged -it \
     -v $HOME/llama.cpp/ci-cache:/ci-cache \
     -v $HOME/llama.cpp/ci-results:/ci-results \
     -v $PWD:/ws -w /ws \
-    mthreads/musa:rc4.2.0-devel-ubuntu22.04-amd64
+    mthreads/musa:rc4.3.0-devel-ubuntu22.04-amd64
 ```
 
 Inside the container, execute the following commands:

filename: docs/docker.md
patch: @@ -110,7 +110,7 @@ You may want to pass in some different `ARGS`, depending on the MUSA environment
 
 The defaults are:
 
-- `MUSA_VERSION` set to `rc4.2.0`
+- `MUSA_VERSION` set to `rc4.3.0`
 
 The resulting images, are essentially the same as the non-MUSA images:
Repository: electron/electron
Pull request: build: fail for out of date patches on forks

#### Description of Change

Follow-up to https://github.com/electron/electron/pull/46047.

Ensure out-of-date patches fail on forks as well by tweaking the patch-up script to fail without credentials.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none


Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -99,7 +99,7 @@ runs:
       fi
 
       ELECTRON_USE_THREE_WAY_MERGE_FOR_PATCHES=1 e d gclient sync --with_branch_heads --with_tags -vv
-      if [[ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]]; then
+      if [[ "${{ inputs.is-release }}" != "true" ]]; then
         # Re-export all the patches to check if there were changes.
         python3 src/electron/script/export_all_patches.py src/electron/patches/config.json
         cd src/electron

filename: script/push-patch.js
patch: @@ -2,23 +2,31 @@ const { appCredentialsFromString, getTokenForRepo } = require('@electron/github-
 
 const cp = require('node:child_process');
 
+const { PATCH_UP_APP_CREDS } = process.env;
+
 async function main () {
+  if (!PATCH_UP_APP_CREDS) {
+    throw new Error('PATCH_UP_APP_CREDS environment variable not set');
+  }
+
   const token = await getTokenForRepo(
     {
       name: 'electron',
       owner: 'electron'
     },
-    appCredentialsFromString(process.env.PATCH_UP_APP_CREDS)
+    appCredentialsFromString(PATCH_UP_APP_CREDS)
   );
+
   const remoteURL = `https://x-access-token:${token}@github.com/electron/electron.git`;
+
   // NEVER LOG THE OUTPUT OF THIS COMMAND
   // GIT LEAKS THE ACCESS CREDENTIALS IN CONSOLE LOGS
   const { status } = cp.spawnSync('git', ['push', '--set-upstream', remoteURL], {
     stdio: 'ignore'
   });
+
   if (status !== 0) {
-    console.error('Failed to push to target branch');
-    process.exit(1);
+    throw new Error('Failed to push to target branch');
   }
 }
Repository: nodejs/node
Pull request: test: remove duplicated allocUnsafeSlow test


Changed files:
filename: test/parallel/test-buffer-tostring-rangeerror.js
patch: @@ -38,7 +38,6 @@ function test(getBuffer) {
 }
 
 test(() => Buffer(len));
-test(() => Buffer.allocUnsafeSlow(len));
 test(() => Buffer.alloc(len));
 test(() => Buffer.allocUnsafe(len));
 test(() => Buffer.allocUnsafeSlow(len));
Repository: vercel/next.js
Pull request: Fix API stripping JSON incorrectly

Backports API stripping JSON fix to 15.4 branch

x-ref: https://github.com/vercel/next.js/pull/82061

Changed files:
filename: packages/next/src/shared/lib/page-path/normalize-data-path.ts
patch: @@ -1,7 +1,12 @@
+import { pathHasPrefix } from '../router/utils/path-has-prefix'
+
 /**
  * strip _next/data/<build-id>/ prefix and .json suffix
  */
 export function normalizeDataPath(pathname: string) {
+  if (!pathHasPrefix(pathname || '/', '/_next/data')) {
+    return pathname
+  }
   pathname = pathname
     .replace(/\/_next\/data\/[^/]{1,}/, '')
     .replace(/\.json$/, '')

filename: test/integration/api-support/test/index.test.js
patch: @@ -25,6 +25,12 @@ let mode
 let app
 
 function runTests(dev = false) {
+  it('should not strip .json from API route', async () => {
+    const res = await fetchViaHTTP(appPort, '/api/hello.json')
+    expect(res.status).toBe(200)
+    expect(await res.json()).toEqual({ post: 'hello.json' })
+  })
+
   it('should handle proxying to self correctly', async () => {
     const res1 = await fetchViaHTTP(appPort, '/api/proxy-self')
     expect(res1.status).toBe(200)
Repository: electron/electron
Pull request: build: move set chromium cookie before build tools step

Backport of #46091

See that PR for details.


Notes: none


Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -18,10 +18,10 @@ runs:
       echo "GIT_CACHE_PATH=$(pwd)/git-cache" >> $GITHUB_ENV
   - name: Install Dependencies
     uses: ./src/electron/.github/actions/install-dependencies
-  - name: Install Build Tools
-    uses: ./src/electron/.github/actions/install-build-tools
   - name: Set Chromium Git Cookie
     uses: ./src/electron/.github/actions/set-chromium-cookie
+  - name: Install Build Tools
+    uses: ./src/electron/.github/actions/install-build-tools
   - name: Get Depot Tools
     shell: bash
     run: |

filename: .github/workflows/pipeline-segment-node-nan-test.yml
patch: @@ -51,15 +51,15 @@ jobs:
         path: src/electron
         fetch-depth: 0
         ref: ${{ github.event.pull_request.head.sha }}
+    - name: Set Chromium Git Cookie
+      uses: ./src/electron/.github/actions/set-chromium-cookie
     - name: Install Build Tools
       uses: ./src/electron/.github/actions/install-build-tools
     - name: Init Build Tools
       run: |
         e init -f --root=$(pwd) --out=Default ${{ inputs.gn-build-type }} --import ${{ inputs.gn-build-type }} --target-cpu ${{ inputs.target-arch }}
     - name: Install Dependencies
       uses: ./src/electron/.github/actions/install-dependencies
-    - name: Set Chromium Git Cookie
-      uses: ./src/electron/.github/actions/set-chromium-cookie
     - name: Get Depot Tools
       timeout-minutes: 5
       run: |
Repository: electron/electron
Pull request: build: move set chromium cookie before build tools step

#### Description of Change
Followup to #45581.

This PR:
- [x] Reorders set chromium git cookie step before installing build tools and fetching depot tools.
<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [x] relevant API documentation, tutorials, and examples are updated and follow the [documentation style guide](https://github.com/electron/electron/blob/main/docs/development/style-guide.md)
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none


Changed files:
filename: .github/actions/checkout/action.yml
patch: @@ -18,10 +18,10 @@ runs:
       echo "GIT_CACHE_PATH=$(pwd)/git-cache" >> $GITHUB_ENV
   - name: Install Dependencies
     uses: ./src/electron/.github/actions/install-dependencies
-  - name: Install Build Tools
-    uses: ./src/electron/.github/actions/install-build-tools
   - name: Set Chromium Git Cookie
     uses: ./src/electron/.github/actions/set-chromium-cookie
+  - name: Install Build Tools
+    uses: ./src/electron/.github/actions/install-build-tools
   - name: Get Depot Tools
     shell: bash
     run: |

filename: .github/workflows/pipeline-segment-node-nan-test.yml
patch: @@ -51,15 +51,15 @@ jobs:
         path: src/electron
         fetch-depth: 0
         ref: ${{ github.event.pull_request.head.sha }}
+    - name: Set Chromium Git Cookie
+      uses: ./src/electron/.github/actions/set-chromium-cookie
     - name: Install Build Tools
       uses: ./src/electron/.github/actions/install-build-tools
     - name: Init Build Tools
       run: |
         e init -f --root=$(pwd) --out=Default ${{ inputs.gn-build-type }} --import ${{ inputs.gn-build-type }} --target-cpu ${{ inputs.target-arch }}
     - name: Install Dependencies
       uses: ./src/electron/.github/actions/install-dependencies
-    - name: Set Chromium Git Cookie
-      uses: ./src/electron/.github/actions/set-chromium-cookie
     - name: Get Depot Tools
       timeout-minutes: 5
       run: |
Repository: nodejs/node
Pull request: permission: remove useless conditional

Deleting a null pointer has no effect. The check is not needed.

Changed files:
filename: src/permission/fs_permission.cc
patch: @@ -45,9 +45,7 @@ void FreeRecursivelyNode(
     }
   }
 
-  if (node->wildcard_child != nullptr) {
-    delete node->wildcard_child;
-  }
+  delete node->wildcard_child;
   delete node;
 }
Repository: nodejs/node
Pull request: http: deprecate instantiating classes without new

We started making such changes for zlib and repl. I recommend documentation-only deprecating instantiating these classes without new qualifier, and runtime deprecating in next major depending on the usage. If usage is high, we can postpone runtime deprecating it.

cc @nodejs/tsc @nodejs/http

Changed files:
filename: doc/api/deprecations.md
patch: @@ -3955,6 +3955,21 @@ Type: Documentation-only
 The support for priority signaling has been deprecated in the [RFC 9113][], and
 will be removed in future versions of Node.js.
 
+### DEP0195: Instantiating `node:http` classes without `new`
+
+<!-- YAML
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/58518
+    description: Documentation-only deprecation.
+-->
+
+Type: Documentation-only
+
+Instantiating classes without the `new` qualifier exported by the `node:http` module is deprecated.
+It is recommended to use the `new` qualifier instead. This applies to all http classes, such as
+`OutgoingMessage`, `IncomingMessage`, `ServerResponse` and `ClientRequest`.
+
 [DEP0142]: #dep0142-repl_builtinlibs
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
Repository: denoland/deno
Pull request: fix(fmt): allow omission of semicolon in certain cases in css template

closes #29686

If a semicolon is omitted after the last statement expression (`${SOME_STYLE}` in below) in a block in CSS template literal:

```js
css`
  a {
    ${SOME_STYLE}
  }
`;
```

This currently results in parse error of css and can't be formatted.

The root cause of this is fixed in upstream css parser raffia (https://github.com/g-plane/raffia/issues/11). This PR upgrades raffia to the latest and avoids the above issue.

Note: The example above now formats to the below:

```js
css`
  a {
    ${SOME_STYLE};
  }
`;
```


Changed files:
filename: Cargo.lock
patch: @@ -6560,7 +6560,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "0c1318b19085f08681016926435853bbf7858f9c082d0999b80550ff5d9abe15"
 dependencies = [
  "bytes",
- "heck 0.5.0",
+ "heck 0.4.1",
  "itertools 0.13.0",
  "log",
  "multimap",
@@ -6750,9 +6750,9 @@ dependencies = [
 
 [[package]]
 name = "raffia"
-version = "0.9.1"
+version = "0.9.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c36f58fa7ad2f26bca656054c902becddeac5582df2bb31d4b4d2a148c62cfd5"
+checksum = "fffe6643ba09b12af3816c6d3687d8c16c8a306bdbf60e2804b4bbd2c1f5447e"
 dependencies = [
  "raffia_macro",
  "smallvec",

filename: tests/specs/fmt/external_formatter/badly_formatted.in
patch: @@ -11,6 +11,10 @@ margin: 0.5rem;
         ${OTHER_STYLES};
 		}
 	}
+
+  span {
+    ${SOME_STYLE}
+  }
 `;
 
 cssString = css`

filename: tests/specs/fmt/external_formatter/well_formatted.out
patch: @@ -11,6 +11,10 @@ const EqualDivider = styled.div`
       ${OTHER_STYLES};
     }
   }
+
+  span {
+    ${SOME_STYLE};
+  }
 `;
 
 cssString = css`

filename: tests/specs/fmt/external_formatter/well_formatted_unstable_sql.out
patch: @@ -11,6 +11,10 @@ const EqualDivider = styled.div`
       ${OTHER_STYLES};
     }
   }
+
+  span {
+    ${SOME_STYLE};
+  }
 `;
 
 cssString = css`

filename: tests/specs/fmt/external_formatter/well_formatted_use_tabs.out
patch: @@ -11,6 +11,10 @@ const EqualDivider = styled.div`
 			${OTHER_STYLES};
 		}
 	}
+
+	span {
+		${SOME_STYLE};
+	}
 `;
 
 cssString = css`
Repository: ggml-org/llama.cpp
Pull request: codeowners : add danbev as owner of build-xcframework.sh [no ci]


Changed files:
filename: CODEOWNERS
patch: @@ -103,4 +103,5 @@
 /LICENSE                                @ggerganov
 /README.md                              @ggerganov
 /SECURITY.md                            @ggerganov
+/build-xcframework.sh                   @danbev
 requirements*.txt                       @CISC
Repository: denoland/deno
Pull request: test(init): add retry in init_subcommand_serve to reduce flakiness

This PR adds retrying of http request to localhost in `init::init_subcommand_serve` test case to reduce [this](https://github.com/denoland/deno/actions/runs/15542323728/job/43755813240) flakiness.

Changed files:
filename: tests/integration/init_tests.rs
patch: @@ -199,7 +199,14 @@ async fn init_subcommand_serve() {
     .spawn_with_piped_output();
 
   tokio::time::sleep(std::time::Duration::from_millis(1000)).await;
-  let resp = reqwest::get("http://127.0.0.1:9500").await.unwrap();
+  let resp = match reqwest::get("http://127.0.0.1:9500").await {
+    Ok(resp) => resp,
+    Err(_) => {
+      // retry once
+      tokio::time::sleep(std::time::Duration::from_millis(1000)).await;
+      reqwest::get("http://127.0.0.1:9500").await.unwrap()
+    }
+  };
 
   let body = resp.text().await.unwrap();
   assert_eq!(body, "Home page");
Repository: nodejs/node
Pull request: test: make sqlite-database-sync tests work with system sqlite

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->
Does what it states on the tin.
My shared library sqlite seems to report this particular error without `"`'s, but otherwise seems perfectly functional.

Changed files:
filename: test/parallel/test-sqlite-database-sync.js
patch: @@ -164,7 +164,7 @@ suite('DatabaseSync() constructor', () => {
       db.exec('SELECT "foo";');
     }, {
       code: 'ERR_SQLITE_ERROR',
-      message: /no such column: "foo"/,
+      message: /no such column: "?foo"?/,
     });
   });