helloadhavan/github_issues huggingface dataset:
Repository: denoland/deno
Pull request: fix(install): error gracefully if user passes `--no-config` to `deno install <package>`

Fixes #28090. Fixes #28961.

Changed files:
filename: cli/args/flags.rs
patch: @@ -1412,7 +1412,7 @@ pub fn flags_from_vec(args: Vec<OsString>) -> clap::error::Result<Flags> {
       "fmt" => fmt_parse(&mut flags, &mut m)?,
       "init" => init_parse(&mut flags, &mut m)?,
       "info" => info_parse(&mut flags, &mut m)?,
-      "install" => install_parse(&mut flags, &mut m)?,
+      "install" => install_parse(&mut flags, &mut m, app)?,
       "json_reference" => json_reference_parse(&mut flags, &mut m, app),
       "jupyter" => jupyter_parse(&mut flags, &mut m),
       "lint" => lint_parse(&mut flags, &mut m)?,
@@ -5039,6 +5039,7 @@ fn info_parse(
 fn install_parse(
   flags: &mut Flags,
   matches: &mut ArgMatches,
+  app: Command,
 ) -> clap::error::Result<()> {
   runtime_args_parse(flags, matches, true, true, false)?;
 
@@ -5076,6 +5077,13 @@ fn install_parse(
     .remove_many("cmd")
     .map(|packages| add_parse_inner(matches, Some(packages)))
   {
+    if matches!(flags.config_flag, ConfigFlag::Disabled) {
+      return Err(app.override_usage("deno install [OPTIONS] [PACKAGE]...").error(
+        clap::error::ErrorKind::ArgumentConflict,
+        format!("deno install can't be used to add packages if `--no-config` is passed.\n{} to cache the packages without adding to a config, pass the `--entrypoint` flag", deno_terminal::colors::cyan("hint:")),
+      ));
+    }
+
     flags.subcommand = DenoSubcommand::Install(InstallFlags::Local(
       InstallFlagsLocal::Add(add_files),
     ))

filename: tests/specs/install/no_config_flag/__test__.jsonc
patch: @@ -0,0 +1,10 @@
+{
+  "tempDir": true,
+  "steps": [
+    {
+      "args": "install --no-config npm:chalk",
+      "output": "err.out",
+      "exitCode": 1
+    }
+  ]
+}

filename: tests/specs/install/no_config_flag/err.out
patch: @@ -0,0 +1,5 @@
+error: deno install can't be used to add packages if `--no-config` is passed.
+hint: to cache the packages without adding to a config, pass the `--entrypoint` flag
+
+Usage: deno install [OPTIONS] [PACKAGE]...
+
Repository: huggingface/transformers
Pull request: skip files in `src/` for doctest (for now)

# What does this PR do?

Fix #39159

Merge directly as 

https://github.com/huggingface/transformers/issues/39159#issuecomment-3045160413

Changed files:
filename: utils/split_doctest_jobs.py
patch: @@ -59,6 +59,13 @@
 
     for file in all_doctest_files:
         file_dir = "/".join(Path(file).parents[0].parts)
+
+        # not to run files in `src/` for now as it is completely broken at this moment. See issues/39159 and
+        # https://github.com/huggingface/transformers/actions/runs/15988670157
+        # TODO (ydshieh): fix the error, ideally before 2025/09
+        if file_dir.startswith("src/"):
+            continue
+
         raw_test_collection_map[file_dir].append(file)
 
     refined_test_collection_map = {}
Repository: nodejs/node
Pull request: build: use `$(BUILDTYPE)` when cleaning coverage files

These checks would previously fail in the case that a user built a Debug-only build of the project, now, it checks `$(BUILDTYPE)`, so any build type passes the check.

Changed files:
filename: Makefile
patch: @@ -238,7 +238,7 @@ coverage-clean: ## Remove coverage artifacts.
 	$(RM) -r node_modules
 	$(RM) -r gcovr
 	$(RM) -r coverage/tmp
-	@if [ -d "out/Release/obj.target" ]; then \
+	@if [ -d "out/$(BUILDTYPE)/obj.target" ]; then \
 		$(FIND) out/$(BUILDTYPE)/obj.target \( -name "*.gcda" -o -name "*.gcno" \) \
 			-type f | xargs $(RM); \
 	fi
@@ -265,7 +265,7 @@ coverage-build-js: ## Build JavaScript coverage files.
 
 .PHONY: coverage-test
 coverage-test: coverage-build ## Run the tests and generate a coverage report.
-	@if [ -d "out/Release/obj.target" ]; then \
+	@if [ -d "out/$(BUILDTYPE)/obj.target" ]; then \
 		$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f | xargs $(RM); \
 	fi
 	-NODE_V8_COVERAGE=coverage/tmp \
Repository: vercel/next.js
Pull request: [devtool] styling fixes

### Styling fixes

* The overlay needs to have the highiest index, it's regressed from the change in #80974 while tweaking around new panel UI
* Noticed the route info needs to be set as nowrap when pathname is super long

| After | Before |
|:-- |:-- |
| ![image](https://github.com/user-attachments/assets/0b4b2583-9b71-4a42-9255-ccd555afb3af) |  ![image](https://github.com/user-attachments/assets/16f5c3ae-2f68-4f53-aaef-983a1e4c88f6)  |
| ![image](https://github.com/user-attachments/assets/8f6f234a-a29b-4c4d-abf9-f75b0cb0b294) | ![image](https://github.com/user-attachments/assets/2aef4bb4-320e-43c3-984e-45d1b28bf0fc) |


Changed files:
filename: packages/next/src/next-devtools/dev-overlay/components/overlay/styles.tsx
patch: @@ -5,7 +5,8 @@ const styles = `
     right: 0;
     bottom: 0;
     left: 0;
-    z-index: 3;
+    /* secondary z-index, -1 than toast z-index */
+    z-index: 2147483646;
 
     display: flex;
     align-content: center;

filename: packages/next/src/next-devtools/dev-overlay/components/overview/segment-explorer.tsx
patch: @@ -258,6 +258,7 @@ export const DEV_TOOLS_INFO_RENDER_FILES_STYLES = css`
     font-weight: 500;
     color: var(--color-gray-1000);
     font-family: var(--font-mono);
+    white-space: nowrap;
   }
 
   .segment-explorer-item {
Repository: electron/electron
Pull request: build: make gen-libc++-filenames.js produce the same results on Windows

#### Description of Change

While working on #45535 I noticed that touching the `DEPS` file on Windows causes `filenames.libcxx.gni` and `filenames.libcxxabi.gni` to be regenerated with what appears to be a different list of paths. When I debugged the issue, I found that there are two causes for this:

1. The list of files returned by `fs.readdirSync` is not consistent between Mac and Windows, so when the script traverses the include directories on Windows, it gets back a list of paths that is in a different order.
2. For headers in nested folders, the `path.relative(path.resolve(...))` call still ends up with a backslash in the relative path on Windows.

To address these Windows inconsistencies, this PR updates the `findAllHeaders` function to sort the list of files in a folder before iterating over them, and updates the header parsing logic to replace `\` with `/` when resolving header paths.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: no-notes


Changed files:
filename: script/gen-libc++-filenames.js
patch: @@ -7,6 +7,7 @@ const check = process.argv.includes('--check');
 
 function findAllHeaders (basePath) {
   const allFiles = fs.readdirSync(basePath);
+  allFiles.sort();
   const toReturn = [];
   for (const file of allFiles) {
     const absPath = path.resolve(basePath, file);
@@ -48,7 +49,7 @@ for (const folder of ['libc++', 'libc++abi']) {
   const libcxxIncludeDir = path.resolve(__dirname, '..', '..', 'third_party', folder, 'src', 'include');
   const gclientPath = `third_party/${folder}/src/include`;
 
-  const headers = findAllHeaders(libcxxIncludeDir).map(absPath => path.relative(path.resolve(__dirname, '../..', gclientPath), absPath));
+  const headers = findAllHeaders(libcxxIncludeDir).map(absPath => path.relative(path.resolve(__dirname, '../..', gclientPath), absPath).replaceAll('\\', '/'));
 
   const newHeaders = headers.map(f => `//${path.posix.join(gclientPath, f)}`);
   const content = `${prettyName}_headers = [
Repository: denoland/deno
Pull request: test: temporarily ignore `specs::install::package_extra_nmd` test

These tests are failing randomly on Windows at the moment. The PR that added them was released in Deno v2.2.10 and users haven't reported any problems so far. So temporarily ignoring these tests to unblock another patch release.

Changed files:
filename: tests/specs/install/package_extra_nmd/__test__.jsonc
patch: @@ -1,5 +1,6 @@
 {
   "tempDir": true,
+  "ignore": true,
   "tests": {
     "auto": {
       "steps": [
Repository: huggingface/transformers
Pull request: add `stevhliu` to the list in `self-comment-ci.yml`

# What does this PR do?

welcome @stevhliu 

Changed files:
filename: .github/workflows/self-comment-ci.yml
patch: @@ -29,7 +29,7 @@ jobs:
     runs-on: ubuntu-22.04
     name: Get PR number
     # For security: only allow team members to run
-    if: ${{ github.event.issue.state == 'open' && contains(fromJSON('["ydshieh", "ArthurZucker", "zucchini-nlp", "qubvel", "molbap", "gante", "LysandreJik", "Cyrilvallez", "Rocketknight1", "SunMarc", "muellerzr", "eustlb", "MekkCyber", "manueldeprada", "vasqu", "ivarflakstad"]'), github.actor) && (startsWith(github.event.comment.body, 'run-slow') || startsWith(github.event.comment.body, 'run slow') || startsWith(github.event.comment.body, 'run_slow')) }}
+    if: ${{ github.event.issue.state == 'open' && contains(fromJSON('["ydshieh", "ArthurZucker", "zucchini-nlp", "qubvel", "molbap", "gante", "LysandreJik", "Cyrilvallez", "Rocketknight1", "SunMarc", "muellerzr", "eustlb", "MekkCyber", "manueldeprada", "vasqu", "ivarflakstad", "stevhliu"]'), github.actor) && (startsWith(github.event.comment.body, 'run-slow') || startsWith(github.event.comment.body, 'run slow') || startsWith(github.event.comment.body, 'run_slow')) }}
     outputs:
       PR_NUMBER: ${{ steps.set_pr_number.outputs.PR_NUMBER }}
     steps:
Repository: nodejs/node
Pull request: doc: add returns for https.get

Clarify the return value of `https.get` by also stating that it returns an `http.ClientRequest`. This brings it in line with the `http.get` documentation, improving consistency and reducing ambiguity.

![http.get doc has Returns](https://github.com/user-attachments/assets/27bf5a1a-923a-418f-933e-7ed20836e52b)

![https.get doc is missing Returns](https://github.com/user-attachments/assets/1726b7a7-3e00-47fb-b58a-3cb2eebb1630)


<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/https.md
patch: @@ -341,6 +341,7 @@ changes:
 * `options` {Object | string | URL} Accepts the same `options` as
   [`https.request()`][], with the method set to GET by default.
 * `callback` {Function}
+* Returns: {http.ClientRequest}
 
 Like [`http.get()`][] but for HTTPS.
Repository: vercel/next.js
Pull request: Only retry deploy tests for canary

This avoids retrying/alerting if triggering the deploy tests with a custom next tarball. The `run_name` is available as `display_title` [per docs here](https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_run:~:text=The%20event%2Dspecific%20title%20associated%20with%20the%20run%20or%20the%20run%2Dname%20if%20set%2C%20or%20the%20value%20of%20run%2Dname%20if%20it%20is%20set%20in%20the%20workflow) 

x-ref: [slack thread](https://vercel.slack.com/archives/C04KC8A53T7/p1751485507582049)

Changed files:
filename: .github/workflows/retry_deploy_test.yml
patch: @@ -18,6 +18,7 @@ jobs:
     # Retry the test-e2e-deploy-release workflow up to 2 times
     if: >-
       ${{ 
+        github.event.workflow_run.display_title == 'test-e2e-deploy canary'
         github.event.workflow_run.conclusion == 'failure' &&
         github.repository == 'vercel/next.js' &&
         github.event.workflow_run.run_attempt < 2

filename: .github/workflows/test_e2e_deploy_release.yml
patch: @@ -22,6 +22,8 @@ env:
   TURBO_TOKEN: ${{ secrets.HOSTED_TURBO_TOKEN }}
   DD_ENV: 'ci'
 
+run-name: test-e2e-deploy ${{ inputs.nextVersion }}
+
 jobs:
   setup:
     runs-on: ubuntu-latest
Repository: denoland/deno
Pull request: perf(npm): don't try to cache npm packages we've already cached

With `nodeModulesDir: auto` (and `none`, to a lesser extent), we frequently repeatedly try to cache npm packages during resolution. On a (private) fresh project, I counted that `sync_resolution_with_fs` was called 478 times over the course of a fresh build. This reduces the number of calls to 8, and doing so speeds things up substantially.

```
❯ hyperfine --warmup 2 -N "deno task build" "../deno/target/release-lite/deno task build"
Benchmark 1: deno task build
  Time (mean ± σ):      3.652 s ±  0.042 s    [User: 3.285 s, System: 2.399 s]
  Range (min … max):    3.587 s …  3.712 s    10 runs

Benchmark 2: ../deno/target/release-lite/deno task build
  Time (mean ± σ):      1.356 s ±  0.007 s    [User: 1.961 s, System: 1.108 s]
  Range (min … max):    1.345 s …  1.372 s    10 runs

Summary
  ../deno/target/release-lite/deno task build ran
    2.69 ± 0.03 times faster than deno task build
```

Changed files:
filename: cli/npm/installer/mod.rs
patch: @@ -13,6 +13,7 @@ use deno_npm::NpmSystemInfo;
 use deno_resolver::npm::managed::NpmResolutionCell;
 use deno_runtime::colors;
 use deno_semver::package::PackageReq;
+use rustc_hash::FxHashSet;
 
 pub use self::common::NpmPackageFsInstaller;
 use self::global::GlobalNpmPackageInstaller;
@@ -49,6 +50,7 @@ pub struct NpmInstaller {
   maybe_lockfile: Option<Arc<CliLockfile>>,
   npm_resolution: Arc<NpmResolutionCell>,
   top_level_install_flag: AtomicFlag,
+  cached_reqs: tokio::sync::Mutex<FxHashSet<PackageReq>>,
 }
 
 impl NpmInstaller {
@@ -100,6 +102,7 @@ impl NpmInstaller {
       npm_resolution_installer,
       maybe_lockfile,
       top_level_install_flag: Default::default(),
+      cached_reqs: Default::default(),
     }
   }
 
@@ -168,7 +171,28 @@ impl NpmInstaller {
     }
     if result.dependencies_result.is_ok() {
       if let Some(caching) = caching {
-        result.dependencies_result = self.cache_packages(caching).await;
+        // the async mutex is unfortunate, but needed to handle the edge case where two workers
+        // try to cache the same package at the same time. we need to hold the lock while we cache
+        // and since that crosses an await point, we need the async mutex.
+        //
+        // should have a negligible perf impact because acquiring the lock is still in the order of nanoseconds
+        // while caching typically takes micro or milli seconds.
+        let mut cached_reqs = self.cached_reqs.lock().await;
+        let uncached = {
+          packages
+            .iter()
+            .filter(|req| !cached_reqs.contains(req))
+            .collect::<Vec<_>>()
+        };
+
+        if !uncached.is_empty() {
+          result.dependencies_result = self.cache_packages(caching).await;
+          if result.dependencies_result.is_ok() {
+            for req in uncached {
+              cached_reqs.insert(req.clone());
+            }
+          }
+        }
       }
     }
Repository: electron/electron
Pull request: test: make sure test window is on top for focus tests

#### Description of Change
Fixes #45322.  Using a newly added spec helper `takeScreenshot`, I was able to determine that on the focus tests in Windows, the testing window was behind other windows which interfered with the focus tests.  This PR changes our focus tests to make sure the test window is always on top.
<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: spec/chromium-spec.ts
patch: @@ -98,14 +98,13 @@ describe('window.postMessage', () => {
   });
 });
 
-// Tests disabled due to regression in Chromium upgrade
-// https://github.com/electron/electron/issues/45322
-ifdescribe(!(process.platform === 'win32' && process.arch === 'ia32'))('focus handling', () => {
+describe('focus handling', () => {
   let webviewContents: WebContents;
   let w: BrowserWindow;
 
   beforeEach(async () => {
     w = new BrowserWindow({
+      alwaysOnTop: true,
       show: true,
       webPreferences: {
         nodeIntegration: true,

filename: spec/lib/screen-helpers.ts
patch: @@ -122,6 +122,14 @@ export class ScreenCapture {
     return this._expectImpl(findPoint(this.display.size), hexColor, true);
   }
 
+  public async takeScreenshot (filePrefix: string) {
+    const frame = await this.captureFrame();
+    return await createArtifactWithRandomId(
+      (id) => `${filePrefix}-${id}.png`,
+      frame.toPNG()
+    );
+  }
+
   private async captureFrame (): Promise<NativeImage> {
     const sources = await desktopCapturer.getSources({
       types: ['screen'],
Repository: vercel/next.js
Pull request: perf(next-napi): optimize output assets collection using flat_map

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

Replace manual loop with `extend()` calls with a single `flat_map().collect()` operation to reduce function call overhead and improve memory allocation efficiency when collecting output assets from multiple endpoints.


Changed files:
filename: crates/napi/src/next_api/project.rs
patch: @@ -956,10 +956,10 @@ async fn output_assets_operation(
         .try_join()
         .await?;
 
-    let mut output_assets: FxIndexSet<ResolvedVc<Box<dyn OutputAsset>>> = FxIndexSet::default();
-    for assets in endpoint_assets {
-        output_assets.extend(assets.iter());
-    }
+    let output_assets: FxIndexSet<ResolvedVc<Box<dyn OutputAsset>>> = endpoint_assets
+        .iter()
+        .flat_map(|assets| assets.iter().copied())
+        .collect();
 
     Ok(Vc::cell(output_assets.into_iter().collect()))
 }
Repository: nodejs/node
Pull request: src: remove unused detachArrayBuffer method

Removes unused method

Changed files:
filename: src/node_buffer.cc
patch: @@ -1267,20 +1267,6 @@ void GetZeroFillToggle(const FunctionCallbackInfo<Value>& args) {
   args.GetReturnValue().Set(Uint32Array::New(ab, 0, 1));
 }
 
-void DetachArrayBuffer(const FunctionCallbackInfo<Value>& args) {
-  Environment* env = Environment::GetCurrent(args);
-  if (args[0]->IsArrayBuffer()) {
-    Local<ArrayBuffer> buf = args[0].As<ArrayBuffer>();
-    if (buf->IsDetachable()) {
-      std::shared_ptr<BackingStore> store = buf->GetBackingStore();
-      if (buf->Detach(Local<Value>()).IsNothing()) {
-        return;
-      }
-      args.GetReturnValue().Set(ArrayBuffer::New(env->isolate(), store));
-    }
-  }
-}
-
 static void Btoa(const FunctionCallbackInfo<Value>& args) {
   CHECK_EQ(args.Length(), 1);
   Environment* env = Environment::GetCurrent(args);
@@ -1570,7 +1556,6 @@ void Initialize(Local<Object> target,
                             &fast_index_of_number);
   SetMethodNoSideEffect(context, target, "indexOfString", IndexOfString);
 
-  SetMethod(context, target, "detachArrayBuffer", DetachArrayBuffer);
   SetMethod(context, target, "copyArrayBuffer", CopyArrayBuffer);
 
   SetMethod(context, target, "swap16", Swap16);
@@ -1680,7 +1665,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
   registry->Register(StringWrite<UTF8>);
   registry->Register(GetZeroFillToggle);
 
-  registry->Register(DetachArrayBuffer);
   registry->Register(CopyArrayBuffer);
 
   registry->Register(Atob);